keyboard.c, keymap.c: Use bool for booleans.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e738ca56
PE
12012-10-10 Paul Eggert <eggert@cs.ucla.edu>
2
9fa1de30
PE
3 keyboard.c, keymap.c: Use bool for booleans.
4 * dispnew.c (sit_for): Distinguish between 3-way display_option
5 and boolean do_display.
6 * keyboard.c (single_kboard, this_command_key_count_reset)
7 (waiting_for_input, echoing, immediate_quit, input_pending)
8 (interrupt_input, interrupts_deferred, pop_kboard)
9 (temporarily_switch_to_single_kboard, ignore_mouse_drag_p)
10 (command_loop_1, adjust_point_for_property)
11 (safe_run_hooks_error, input_polling_used, read_char):
12 (help_char_p, readable_events, kbd_buffer_events_waiting)
13 (kbd_buffer_get_event, timer_check_2, make_lispy_event)
14 (lucid_event_type_list_p, get_input_pending):
15 (gobble_input, menu_separator_name_p, menu_bar_item)
16 (parse_menu_item, parse_tool_bar_item, read_char_x_menu_prompt)
17 (read_char_minibuf_menu_prompt, access_keymap_keyremap)
18 (keyremap_step, test_undefined, read_key_sequence)
19 (detect_input_pending, detect_input_pending_ignore_squeezables)
20 (detect_input_pending_run_timers, requeued_events_pending_p)
21 (quit_throw_to_read_char, Fset_input_interrupt_mode):
22 * keymap.c (get_keymap, keymap_parent, keymap_memberp)
23 (access_keymap_1, access_keymap, map_keymap, get_keyelt)
24 (Fdefine_key, Flookup_key, struct accessible_keymaps_data)
25 (accessible_keymaps_1, Fkey_description, push_key_description):
26 (shadow_lookup, struct where_is_internal_data)
27 (where_is_internal, Fwhere_is_internal, where_is_internal_1)
28 (Fdescribe_buffer_bindings, describe_map_tree, struct describe_map_elt)
29 (describe_map, describe_vector):
30 * menu.c (single_menu_item):
31 * nsmenu.m (ns_update_menubar):
32 * process.c (wait_reading_process_output):
33 * search.c (scan_buffer, scan_newline):
34 Use bool for boolean.
35 * keyboard.c (timers_run, swallow_events)
36 (detect_input_pending_run_timers):
37 * process.c (wait_reading_process_output):
38 Use unsigned for counter where wraparound-on-overflow is desired,
39 since unsigned is guaranteed to have that behavior and signed is not.
40 (read_char): Use ptrdiff_t for string length.
41 (get_input_pending): Remove first argument, since it was always
42 the same pointer-to-int (now pointer-to-boolean) &input_pending,
43 and behave as if it had that value. Return new value of
44 input_pending. All callers changed.
45 * keyboard.h (struct kboard): Use unsigned : 1 for boolean member
46 immediate_echo. Use ptrdiff_t for echo_after_prompt, since it's
47 a string length.
48 * keymap.c (push_key_description): Omit last arg, which was always 1.
49 All callers changed.
50
e738ca56
PE
51 * regex.c (immediate_quit) [emacs]: Remove duplicate decl.
52
29f21cdf
JB
532012-10-10 Juanma Barranquero <lekktu@gmail.com>
54
55 * makefile.w32-in ($(BLD)/dispnew.$(O), $(BLD)/indent.$(O))
56 ($(BLD)/term.$(O)): Update dependencies.
57
6aea7528
DA
582012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
59
60 * alloc.c (mark_object): Use meaningful PVEC_NORMAL_VECTOR.
61 * lisp.h (enum pvec_type): Adjust comments and omit explicit
62 initializer for PVEC_NORMAL_VECTOR.
63
5f3f57be
PE
642012-10-10 Paul Eggert <eggert@cs.ucla.edu>
65
66 Clean out old termopts cruft.
67 * termopts.h (flow_control, meta_key): Remove unused decls.
68 * dispnew.c, indent.c, nsterm.m, term.c, xsettings.c, xsmfns.c:
69 Don't include termopts.h.
70
3e98c68e
DA
712012-10-10 Dmitry Antipov <dmantipov@yandex.ru>
72
73 * alloc.c (gc_sweep): Use pointer-to-a-pointer loop for buffers.
74
77e344e5
PE
752012-10-10 Paul Eggert <eggert@cs.ucla.edu>
76
77 * commands.h (immediate_quit): Remove duplicate decl.
78
5683d7cd
JD
792012-10-09 Jan Djärv <jan.h.d@swipnet.se>
80
81 * nsfont.m (Vfonts_in_cache): Remove, not needed as font.c handles
82 caching.
83 (nsfont_open): Remove setting of Vfonts_in_cache.
84 (syms_of_nsfont): Remove initialization of Vfonts_in_cache
85
cf5fc6db
EZ
862012-10-09 Eli Zaretskii <eliz@gnu.org>
87
b15736e6
EZ
88 * w32fns.c (w32_last_error): Change the return value to DWORD, to
89 match what GetLastError returns. Explain why the function is
90 needed.
91
cf5fc6db
EZ
92 * frame.c (delete_frame): Rename local variable 'tooltip_frame' to
93 'is_tooltip_frame', to avoid confusion with its global namesake.
94
f99714ce
DC
952012-10-08 Daniel Colascione <dancol@dancol.org>
96
97 * xdisp.c (start_hourglass): Call w32_note_current_window when
2b1f11ed
EZ
98 HAVE_NTGUI, not just WINDOWSNT, resolving a problem in the cygw32
99 build that caused Emacs to display the hourglass cursor forever.
f99714ce 100
fd59cb29
GM
101 * w32fns.c (Fx_display_color_cells): Instead of using NCOLORS,
102 which is broken under remote desktop, calculate the number of
103 colors available for a display based on the display's number of
104 planes and number of bits per pixel per plane. (bug#10397).
105
62c480c9 1062012-10-08 Jan Djärv <jan.h.d@swipnet.se>
fd59cb29 107
62c480c9
JD
108 * nsfont.m (Vfonts_in_cache): New variable.
109 (nsfont_open): Use unsignedLongLongValue for cache in case wide ints
110 are used. Add cached fonts to Vfonts_in_cache.
111 (syms_of_nsfont): Initialize and staticpro Vfonts_in_cache.
112
607446ba
JB
1132012-10-08 Juanma Barranquero <lekktu@gmail.com>
114
fd5125ad
JB
115 * makefile.w32-in (LOCAL_FLAGS): Don't define HAVE_NTGUI, it's now
116 in nt/config.nt.
46979e0b
JB
117 (FONT_H): Define after FRAME_H.
118 ($(BLD)/emacs.$(O), $(BLD)/process.$(O), $(BLD)/w32heap.$(O)):
119 Update dependencies.
fd5125ad 120
607446ba
JB
121 * w32term.c: Remove leftover declaration of keyboard_codepage.
122
b6f4e300
EZ
1232012-10-08 Eli Zaretskii <eliz@gnu.org>
124
c54ebba4
EZ
125 * makefile.w32-in (FONT_H): Add $(FRAME_H).
126 (W32TERM_H): Add $(ATIMER_H) and $(FRAME_H).
127 ($(BLD)/emacs.$(O), $(BLD)/w32console.$(O)): Update dependencies.
128 (GLOBAL_SOURCES): Add cygw32.c.
fd59cb29
GM
129 ($(BLD)/unexw32.$(O)):
130 ($(BLD)/w32.$(O)):
131 ($(BLD)/w32console.$(O)):
132 ($(BLD)/w32fns.$(O)):
133 ($(BLD)/w32heap.$(O)):
134 ($(BLD)/w32menu.$(O)):
15c720a3 135 ($(BLD)/w32proc.$(O)): Add w32common.h.
c54ebba4 136
b6f4e300
EZ
137 * w32fns.c (w32_color_map_lookup, x_to_w32_color): Argument is now
138 'const char *'.
139 (x_to_w32_color): Don't modify the argument, modify a copy instead.
140
501199a3
DC
1412012-10-08 Daniel Colascione <dancol@dancol.org>
142
143 * w32term.h (WM_EMACS_BRINGTOTOP, WM_EMACS_INPUT_READY)
144 (WM_EMACS_END): Change WM_EMACS_BRINGTOTOP from 22 to 21 to close
145 accidental message numbering hole. Change other messages to
146 match.
147
148 * w32select.h (HAVE_W32SELECT): Remove.
149
150 * w32select.c, w32proc.c, w32menu.c, w32console.c, w32.c: Include
151 w32common.h instead of w32heap.h
152
153 * w32heap.h (ROUND_UP, ROUND_DOWN, get_page_size)
154 (get_allocation_unit, get_processor_type, get_w32_major_version)
155 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
156 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
157 (OS_NT, os_subtype, cache_system_info): Move declarations to
158 w32common.
159
160 * w32heap.c: Include w32common.h.
161 (sysinfo_cache, syspage_mask, osinfo_cache, w32_major_version)
162 (w32_minor_version, w32_build_number, w32_subtype): Remove
163 duplicate definitions.
164
165 * w32fns.c: Include w32common.h; include w32heap.h only in
166 WINDOWSNT.
167
168 (Fx_file_dialog): Clarify comment on GetOpenFileName structure.
169 Use `report_file_error' instead of `error' in order to better
170 inform users of what went wrong. Increase NTGUI_UNICODE file
171 dialog box file name length to 32k, the maximum allowed by the NT
172 kernel.
173
174 * w32common.h: New file.
175 (ROUND_UP, ROUND_DOWN, get_page_size)
176 (get_allocation_unit, get_processor_type, get_w32_major_version)
177 (get_w32_minor_version, sysinfo_cache, osinfo_cache)
178 (w32_major_version, w32_minor_version, w32_build_number, OS_9X)
179 (OS_NT, os_subtype, cache_system_info): Move here.
180
181 * unexw32.c, unexcw.c: Include w32common.h.
182
183 * emacs.c (main): Use (defined (WINDOWSNT) || defined
184 HAVE_NTGUI) instead of removed HAVE_W32SELECT to decide whether
185 to call syms_of_w32select.
186
187 * cygw32.h: Remove obsolete EXFUN declarations.
188
189 * cygw32.c (Qutf_16_le): Rename to Qutf_16le.
190
191 * Makefile.in (SOME_MACHINE_OBJECTS): Reverse accidental removal
192 of w32inevt.o from SOME_MACHINE_OBJECTS.
193
93aa5c81
DC
1942012-10-08 Daniel Colascione <dancol@dancol.org>
195
196 * image.c: Permanent fix for JPEG compilation issue --- limit
197 jpeglib `boolean' redefinition to Cygwin builds.
198
d424f3d8
EZ
1992012-10-08 Eli Zaretskii <eliz@gnu.org>
200
8ee4c6ce
EZ
201 * image.c (CHECK_LIB_AVAILABLE): Remove, no longer used.
202
d424f3d8
EZ
203 * emacs.c (DAEMON_MUST_EXEC) [HAVE_NTGUI]: Define this only on
204 Cygwin.
205
e08348a0
DC
2062012-10-08 Daniel Colascione <dancol@dancol.org>
207
208 * xfaces.c, xdisp.c, window.c, w32xfns.c, w32term.h, w32term.c,
209 w32select.h w32select.c, w32proc.c, w32menu.c, w32inevt.c,
210 w32help.c, w32font.c, w32font.c, w32fns.c, w32console.c, w32.h,
211 w32.c, unexw32.c, termhooks.h, process.c, menu.c, keyboard.h,
212 keyboard.c, image.c, frame.h, frame.c, fontset.c, font.h, font.c,
213 emacs.c, dispextern.h, cygw32.h, cygw32.c, conf_post.h,
214 Makefile.in: use HAVE_NTGUI for W32 GUI and WINDOWSNT for the
215 operating system. defined(HAVE_NTGUI) && !defined(WINDOWSNT) is
216 now a supported configuration.
217
218 * Makefile.in: consolidate image variables into LIBIMAGE; add
219 W32_OBJ and W32_LIBS. Compile new files.
220
221 * conf_post.h:
222 (_DebPrint) declare tracing facility for W32 debugging. We need
223 to unify tracing later.
224
225 (NTGUI_UNICODE) Define when compiling for Cygwin to allow the
226 unconditional use of W32 Unicode functions. Cygwin runs only on
227 100% Unicode operating systems.
228
229 * cygw32.c: New file. Define Cygwin-specific facilities.
230 (Fcygwin_convert_path_to_windows)
231 (Fcygwin_convert_path_from_windows): New user functions for
232 accessing Cygwin path-munging routines.
233
234 * cygw32.h: New file.
235 (WCSDATA, to_unicode, from_unicode): Define facilities for storing
236 UTF-16LE strings temporarily inside non-Lisp-visible string
237 objects.
238
239 (w32_strerror): Just what it says on the tin.
240
241 * emacs.c: Make the NS fork-then-exec code for daemon-launching
242 also run for Cygwin; both systems have the same problem with using
243 GUI facilities in a forked child. Also call syms_of_cygw32,
244 syms_of_w32select in correct places.
245
246 (DAEMON_MUST_EXEC): new macro defined to signal that a platform
247 needs fork-then-exec for daemon launching.
248
249 * font.h: Include frame.h.
250
251 * image.c: Use the image library cache machinery only when we're
252 compiling for native WINDOWSNT; Cygwin can use shared libraries
253 like any other Unixlike system.
254
255 * keyboard.c: Clarify a comment regarding the input loop.
256
257 * menu.c: When NTGUI_UNICODE is defined, use Unicode menu
258 functions directly instead of trying to detect at runtime that our
259 host operating system supports them. We make this change for two
260 reasons: Cygwin lacks support for the multibyte character
261 conversion functions used by the legacy menu code, and Cygwin
262 never needs to rely on non-Unicode APIs.
263
264 * unexw32.c (hinst): Declare extern.
265
266 * w32.c: Change header order;
267 (w32_strerror): Move to w32fns.c because we need it for
268 non-WINDOWSNT builds.
269
270 * w32.h: Add #error macro to make sure we don't include w32.h for
271 Cygwin builds. Remove w32select declarations.
272
273 * w32console.c (w32_sys_ring_bell, Fset_message_beep): Move to
274 w32fns.c. w32console.c is WINDOWSNT-only.
275
276 * w32fns.c: Include cygw32.h or w32.h depending on CYGWIN; more
277 NTGUI_UNICODE tweaks. (See above.) Change _snprintf to the more
278 POSIXy alternative.
279 (faked_key, sysinfo_cache, osinfo_cahce, syspage_mask)
280 (w32_major_version, w32_minor_version, w32_build_number)
281 (os_subtype, sound_type): Define here
282 (w32_defined_color): Make color parameter const for consistency
283 with other _defined_color functions.
284 (w32_createwindow): Unconditionally call w32_init_class instead of
285 doing so only when hprevinst is non-NULL. Plumbing hprevinst
286 through the code is complex and unnecessary because class
287 registration is practically free.
288 (w32_name_of_message): New EMACSDEBUG-only function.
289 (Fset_message_beep): Move here
290 (Fx_open_connection): Require that the display name for Windows be
291 "w32" for consistency, emacsclient disambiguation, and maybe, one
292 day, multi-window-system support.
293 (file_dialog_callback): NTGUI_UNICODE changes; encode and decode
294 Cygwin files for W32 GUI facilities, since these clearly don't
295 expect Cygwin names.
296 (_DebPrint): Define.
297 (w32_strerror, w32_console_toggle_lock_key, w32_kbd_mods_to_emacs)
298 (w32_kbd_patch_key, w32_sys_ring_bell): Move here.
299 (Ssystem_move_file_to_trash): Define only for native WINDOWSNT.
300 (w32_last_error): Remove.
301
302 * w32font.c: Define _strlwr to strlwr for non-WINDOWSNT builds.
303
304 * w32heap.c (syspage_mask): Declare here.
305 (cache_system_info): Remove.
306
307 * w32inevt.c (faked_key): Define globally, not statically.
308 (w32_kbd_mods_to_emacs, w32_kbd_patch_key, faked_key)
309 (w32_console_toggle_lock_key): Move to w32fns.c.
310
311 * w32menu.c: Include setjmp.h. NTGUI_UNICODE changes throughout.
312
313 * w32proc.c (_DebPrint): Move to w32fns.c.
314 * w32select.c: Include string.h, stdio.h for Cygwin.
315 * w32select.h: New File.
316
317 * w32term.c: Include io.h for non-CYGWIN builds; needed for
318 get_osfhandle.
319 (w32_message_fd): New variable. Under Cygwin, holds the file
320 descriptor the system used to tell us about pending thread
321 messages.
322
323 (w32_init_term): Remove incorrect calls to fcntl and init_sigio
324 that prevented compilation under non-WINDOWSNT systems.
325
326 (w32_initialize): Open /dev/windows and assign it to
327 w32_message_fd. Provide w32 feature.
328
329 * w32term.h: Include frame.h, atimer.h. Declare various frame functions.
330 (WM_EMACS_INPUT_READY): add.
331 (prepend_msg, w32_message_fd): Declare globally.
332
333 * w32xfns.c:
334 (keyboard_handle): Use only when WINDOWSNT.
335 (notify_msg_ready): New function. Posts a message to the main
336 thread's message queue under CYGWIN, which wakes up the main
337 thread from select(2) by making the /dev/windows file descriptor
338 ready. Under WINDOWSNT, it sets an event the same way the old
339 code did.
340
341 (post, prepend_msg): Actually call notify_msg_ready instead of
342 setting the input event directly.
343
98daa893
EZ
3442012-10-07 Eli Zaretskii <eliz@gnu.org>
345
346 * ralloc.c (relinquish): If a heap is ready to be relinquished,
347 but it still has blocs in it, don't return it to the system,
348 instead of aborting. (Bug#12402)
349
3bc0a2f7
JD
3502012-10-07 Jan Djärv <jan.h.d@swipnet.se>
351
8ad5b73b 352 * nsterm.m (ns_dumpglyphs_image): Only draw slice of image (Bug#12506).
493b5b1c 353
335f5ae4
JD
354 * nsterm.m (ns_update_auto_hide_menu_bar): Remove defintion of
355 MAC_OS_X_VERSION_10_6.
8ad5b73b
JD
356 (syms_of_nsterm): Remove comment about Panther and above for
357 ns-antialias-text.
335f5ae4
JD
358 * nsterm.h (MAC_OS_X_VERSION_10_3, onTiger): Remove.
359 (EmacsApp): Remove check for >= MAC_OS_X_VERSION_10_4.
360 (struct nsfont_info): Remove check for >= MAC_OS_X_VERSION_10_3.
361
362 * nsselect.m (ns_string_from_pasteboard): Remove check for >=
363 MAC_OS_X_VERSION_10_4.
364
8ad5b73b
JD
365 * nsmenu.m (fillWithWidgetValue:): Remove code for <
366 MAC_OS_X_VERSION_10_2.
335f5ae4
JD
367
368 * nsimage.m (setPixmapData, getPixelAtX, setAlphaAtX): Remove onTiger.
369
370 * nsfns.m (Fns_list_services): Remove comment and check for OSX < 10.4.
371 (ns_do_applescript): Remove check for >= MAC_OS_X_VERSION_10_4.
372
3bc0a2f7
JD
373 * nsterm.m (ns_in_resize): Remove (Bug#12479).
374 (ns_resize_handle_rect, mouseDown, mouseUp, mouseDragged): Remove.
8ad5b73b
JD
375 (ns_clear_frame, sendEvent, windowDidResize, drawRect:): Remove
376 ns_in_resize check.
3bc0a2f7
JD
377 (ns_clear_frame_area): Remove resize handle code.
378
379 * nsfns.m (ns_in_resize): Remove.
8ad5b73b
JD
380 (x_set_icon_name, ns_set_name, ns_set_name_as_filename): Remove
381 ns_in_resize check.
3bc0a2f7 382
c622b48f
PE
3832012-10-07 Paul Eggert <eggert@cs.ucla.edu>
384
385 Improve sys_siglist detection.
386 * sysdep.c (sys_siglist, init_signals): Use _sys_siglist if it's
387 defined as a macro, as is done in Solaris.
388 (sys_siglist_entries): New macro.
389 (save_strsignal): Use it.
390 * syssignal.h (safe_strsignal): Now ATTRIBUTE_CONST, to pacify
391 GCC 4.7.2 on Fedora 17 with the fixed sys_siglist detection.
392
04fafa46
JD
3932012-10-06 Jan Djärv <jan.h.d@swipnet.se>
394
395 * nsfns.m (Fx_create_frame): Call x_default_parameter with
396 fullscreen/Fullscreen.
397
398 * nsterm.h (EmacsView): Rename tbar_height to tibar_height.
399 tobar_height is new.
400
401 * nsterm.m (x_make_frame_visible): Check for fullscreen.
402 (ns_fullscreen_hook): Activate old style fullscreen with a timer.
403 (ns_term_init): Set activateIgnoringOtherApps if old style fullscreen.
404 (windowDidResize:): Check for correct window if old style fullscreen.
405 Capitalize word in comment. Remove incorrect comment.
406 (initFrameFromEmacs:): tbar_height renamed tibar_height.
407 (windowDidEnterFullScreen:): Toggle toolbar for fullscreen to fix
408 error in drawing background.
409 (toggleFullScreen:): Remove comment. Rearrange calls.
410 Set toolbar values to zero, save old height in tobar_height.
411 Restore tool bar height when leaving fullscreen.
412 (canBecomeMainWindow): New function.
413
c6e21c03
PE
4142012-10-06 Paul Eggert <eggert@cs.ucla.edu>
415
416 * keyboard.c (read_char): Remove unnecessary 'volatile's and label.
417
0d9f584b
EZ
4182012-10-05 Eli Zaretskii <eliz@gnu.org>
419
a65fbb5f
EZ
420 * w32proc.c (stop_timer_thread): Fix declaration of 'err'.
421
0d9f584b
EZ
422 * w32.c (utime): Open the file with FILE_FLAG_BACKUP_SEMANTICS, so
423 that time stamps of directories could also be changed. Don't
424 request the too broad GENERIC_WRITE, only the more restrictive
425 FILE_WRITE_ATTRIBUTES access rights.
426
427 * fileio.c (Fset_file_times): Special-case ignoring errors for
428 directories only on MSDOS, not on MS-Windows.
429
e8757f09 4302012-10-05 Ikumi Keita <ikumi@ikumi.que.jp> (tiny change)
ca347e3d
IK
431
432 * minibuf.c (Fcompleting_read): Doc fix. (Bug#12555)
433
7604f298
EZ
4342012-10-04 Eli Zaretskii <eliz@gnu.org>
435
436 * w32.c (utime): Test for INVALID_HANDLE_VALUE, not for NULL, to
437 see whether CreateFile failed.
438
88d69b7d
PE
4392012-10-04 Paul Eggert <eggert@cs.ucla.edu>
440
441 * profiler.c (handle_profiler_signal): Inhibit pending signals too,
442 to avoid similar races.
443 * keyboard.c (pending_signals): Now bool, not int.
444
7509f454
PE
445 Port timers to OpenBSD, plus check for timer failures.
446 OpenBSD problem reported by Han Boetes.
447 * profiler.c (setup_cpu_timer): Check for failure of timer_settime
448 and/or setitimer.
449 (Fprofiler_cpu_stop): Don't assume HAVE_SETITIMER.
450 * syssignal.h (HAVE_ITIMERSPEC): New macro. This is for platforms
451 like OpenBSD, which has timer_settime but does not declare it.
452 OpenBSD does not define SIGEV_SIGNAL, so use that when deciding
453 whether to use itimerspec-related primitives. All uses of
454 HAVE_TIMER_SETTIME replaced with HAVE_ITIMERSPEC.
455
a3c5c0c5
PE
4562012-10-02 Paul Eggert <eggert@cs.ucla.edu>
457
458 * profiler.c (handle_profiler_signal): Fix a malloc race
459 that caused Emacs to hang on Fedora 17 when profiling Lisp.
460
914e743b
JD
4612012-10-02 Jan Djärv <jan.h.d@swipnet.se>
462
463 * nsterm.m (windowDidEnterFullScreen): Remove fprintf.
464
d8ab37a8
EZ
4652012-10-02 Eli Zaretskii <eliz@gnu.org>
466
467 * w32proc.c (sys_wait): Declare 'signame' 'const char *', to be
468 consistent with the change in return value of 'safe_strsignal'.
469
b3ecad33
PE
4702012-10-02 Paul Eggert <eggert@cs.ucla.edu>
471
0a99eee1
PE
472 Prefer plain 'static' to 'static inline' (Bug#12541).
473 * bidi.c (bidi_get_type, bidi_check_type, bidi_get_category)
474 (bidi_set_sor_type, bidi_push_embedding_level)
475 (bidi_pop_embedding_level, bidi_remember_char, bidi_copy_it)
476 (bidi_cache_reset, bidi_cache_shrink, bidi_cache_fetch_state)
477 (bidi_cache_search, bidi_cache_ensure_space)
478 (bidi_cache_iterator_state, bidi_cache_find)
479 (bidi_peek_at_next_level, bidi_set_paragraph_end)
480 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
481 (bidi_explicit_dir_char, bidi_resolve_neutral_1):
482 Now 'static', not 'static inline'.
483
b3ecad33
PE
484 Count overruns when profiling; change units to ns.
485 * profiler.c (handle_profiler_signal): Count sampling intervals, not ms.
486 Give extra weight to samples after overruns, to attempt to count
487 the time more accurately.
488 (setup_cpu_timer): Change sampling interval units from ms to ns, since
489 the underlying primitives nominally do ns.
490 (Fprofiler_cpu_start): Document the change. Mention that
491 the sampling intervals are only approximate.
492
090cf9db
SM
4932012-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
494
495 * frame.c (Fmake_terminal_frame): Prefer safer CONSP over !NILP.
496
497 * coding.h (ENCODE_FILE, DECODE_FILE, DECODE_SYSTEM): Remove special
498 case for the special 0 coding-system.
499
500 * buffer.c (Fset_buffer_multibyte): Signal an error instead of widening.
501 (Fmake_overlay): Remove redundant tests.
64edc777 502 (fix_start_end_in_overlays): Remove redundant recentering.
090cf9db 503
81550bf4
JB
5042012-10-02 Juanma Barranquero <lekktu@gmail.com>
505
506 * makefile.w32-in ($(BLD)/alloc.$(O), $(BLD)/gmalloc.$(O)):
507 Update dependencies.
508
aa1ba90e
PE
5092012-10-01 Paul Eggert <eggert@cs.ucla.edu>
510
511 Fix a malloc race condition involving strsignal.
512 A signal can arrive in the middle of a malloc, and Emacs's signal
513 handler can invoke strsignal, which can invoke malloc, which is
514 not portable. This race condition bug makes Emacs hang on GNU/Linux.
515 Fix it by altering the signal handler so that it does not invoke
516 strsignal.
517 * emacs.c (shut_down_emacs): Use safe_strsignal, not strsignal.
518 * process.c (status_message): Use const pointer, in case strsignal
519 is #defined to safe_strsignal.
520 * sysdep.c (sys_siglist, init_signals): Always define and
521 initialize a substitute sys_siglist if the system does not define
522 one, even if HAVE_STRSIGNAL.
523 (safe_strsignal): Rename from strsignal. Always define,
524 using sys_siglist. Return a const pointer.
525 * syssignal.h (safe_strsignal): New decl.
526 (strsignal) [!HAVE_STRSIGNAL]: Define in terms of safe_strsignal.
527
ace917bd
EZ
5282012-10-01 Eli Zaretskii <eliz@gnu.org>
529
530 * w32proc.c (timer_loop): Fix code that waits for timer
531 expiration, to avoid high CPU usage.
532
9eb71b9c
SM
5332012-10-01 Stefan Monnier <monnier@iro.umontreal.ca>
534
535 * fns.c (check_hash_table, get_key_arg, maybe_resize_hash_table)
536 (sweep_weak_table): Remove redundant prototypes.
537
b3317662
FP
5382012-10-01 Fabrice Popineau <fabrice.popineau@gmail.com>
539
540 * emacs.c: Move the inclusion of TERM_HEADER after including
541 windows.h on WINDOWSNT. This avoids compilation problems with
542 MSVC.
543
f0e5f225
EZ
5442012-10-01 Eli Zaretskii <eliz@gnu.org>
545
2d7d1608
EZ
546 * unexw32.c (OFFSET_TO_RVA, RVA_TO_OFFSET)
547 (RVA_TO_SECTION_OFFSET): Encode all macro arguments in parentheses.
548 (RVA_TO_PTR): Cast the result of RVA_TO_OFFSET to 'unsigned char *',
549 as the previous version used 'void *'.
550
551 * ralloc.c (ROUNDUP): Fix last change.
552 (MEM_ROUNDUP): Don't cast MEM_ALIGN, it is already of type
553 'size_t'.
554
f0e5f225
EZ
555 * w32proc.c <disable_itimers>: New static flag.
556 (init_timers): Initialize it to zero, after creating the critical
557 sections used by the timer threads.
558 (term_timers): Set to 1 before deleting the critical sections.
559 (getitimer, setitimer): If disable_itimers is non-zero, return an
560 error indication without doing anything. Reported by Fabrice
561 Popineau <fabrice.popineau@supelec.fr> as part of bug#12544.
4cdfbb89
EZ
562 (alarm) [HAVE_SETITIMER]: Be more conformant to the expected
563 return results.
564 [!HAVE_SETITIMER]: Behave as the previous version that didn't
565 support timers.
f0e5f225
EZ
566
567 * emacs.c (shut_down_emacs) [WINDOWSNT]: Move the call to
568 term_ntproc after all the other bookkeeping, to get timers working
569 as long as possible.
570
82ef37c1
PE
5712012-10-01 Paul Eggert <eggert@cs.ucla.edu>
572
b3a4c387
PE
573 * xdisp.c (syms_of_xdisp): Default message-log-max to 1000, not 100.
574 Suggested by Juri Linkov in
575 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00821.html>.
576
b0ab8123
PE
577 Prefer plain 'static' to 'static inline' (Bug#12541).
578 With static functions, modern compilers inline pretty well by
579 themselves; advice from programmers often hurts as much as it helps.
580 On my host (x86-64, Fedora 17, GCC 4.7.2, default 'configure'),
581 this change shrinks the text size of the Emacs executable by 1.1%
582 without affecting CPU significantly in my benchmark.
583 * alloc.c (mem_find, live_string_p, live_cons_p, live_symbol_p)
584 (live_float_p, live_misc_p, live_vector_p, live_buffer_p)
585 (mark_maybe_object, mark_maybe_pointer, bounded_number):
586 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
587 (bset_auto_fill_function, bset_auto_save_file_format)
588 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
589 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
590 (bset_cache_long_line_scans, bset_case_fold_search)
591 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
592 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
593 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
594 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
595 (bset_header_line_format, bset_indicate_buffer_boundaries)
596 (bset_indicate_empty_lines, bset_invisibility_spec)
597 (bset_left_fringe_width, bset_major_mode, bset_mark)
598 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
599 (bset_name, bset_overwrite_mode, bset_pt_marker)
600 (bset_right_fringe_width, bset_save_length)
601 (bset_scroll_bar_width, bset_scroll_down_aggressively)
602 (bset_scroll_up_aggressively, bset_selective_display)
603 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
604 (bset_word_wrap, bset_zv_marker, set_buffer_overlays_before)
605 (set_buffer_overlays_after):
606 * category.c (bset_category_table):
607 * charset.c (read_hex):
608 * coding.c (produce_composition, produce_charset)
609 (handle_composition_annotation, handle_charset_annotation)
610 (char_encodable_p):
611 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers)
612 (assign_row, set_frame_matrix_frame, make_current)
613 (add_row_entry):
614 * eval.c (set_specpdl_symbol, set_specpdl_old_value):
615 * fns.c (maybe_resize_hash_table):
616 * frame.c (fset_buffer_predicate, fset_minibuffer_window):
617 * gmalloc.c (register_heapinfo):
618 * image.c (lookup_image_type):
619 * intervals.c (set_interval_object, set_interval_left)
620 (set_interval_right, copy_interval_parent, rotate_right)
621 (rotate_left, balance_possible_root_interval):
622 * keyboard.c (kset_echo_string, kset_kbd_queue)
623 (kset_keyboard_translate_table, kset_last_prefix_arg)
624 (kset_last_repeatable_command, kset_local_function_key_map)
625 (kset_overriding_terminal_local_map, kset_real_last_command)
626 (kset_system_key_syms, clear_event, set_prop):
627 * lread.c (digit_to_number):
628 * marker.c (attach_marker, live_buffer, set_marker_internal):
629 * nsterm.m (ns_compute_glyph_string_overhangs):
630 * process.c (pset_buffer, pset_command)
631 (pset_decode_coding_system, pset_decoding_buf)
632 (pset_encode_coding_system, pset_encoding_buf, pset_filter)
633 (pset_log, pset_mark, pset_name, pset_plist, pset_sentinel)
634 (pset_status, pset_tty_name, pset_type, pset_write_queue):
635 * syntax.c (bset_syntax_table, dec_bytepos):
636 * terminal.c (tset_param_alist):
637 * textprop.c (interval_has_some_properties)
638 (interval_has_some_properties_list):
639 * window.c (wset_combination_limit, wset_dedicated)
640 (wset_display_table, wset_hchild, wset_left_fringe_width)
641 (wset_left_margin_cols, wset_new_normal, wset_new_total)
642 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
643 (wset_right_fringe_width, wset_right_margin_cols)
644 (wset_scroll_bar_width, wset_start, wset_temslot, wset_vchild)
645 (wset_vertical_scroll_bar_type, wset_window_parameters):
646 * xdisp.c (wset_base_line_number, wset_base_line_pos)
647 (wset_column_number_displayed, wset_region_showing)
648 (window_box_edges, run_window_scroll_functions)
649 (append_glyph_string_lists, prepend_glyph_string_lists)
650 (append_glyph_string, set_glyph_string_background_width)
651 (append_glyph, append_composite_glyph)
652 (take_vertical_position_into_account):
653 * xfaces.c (x_create_gc, x_free_gc, merge_face_vectors)
654 (face_attr_equal_p, lface_equal_p, hash_string_case_insensitive)
655 (lface_hash, lface_same_font_attributes_p, lookup_face):
656 * xml.c (libxml2_loaded_p):
657 * xterm.c (x_set_mode_line_face_gc, x_set_glyph_string_gc)
658 (x_set_glyph_string_clipping, x_clear_glyph_string_rect):
659 Now 'static', not 'static inline'.
660
05584c31
PE
661 * bidi.c: Tune.
662 (bidi_copy_it): Do the whole copy with a single memcpy.
663 (bidi_char_at_pos): Merge the two STRING_CHAR calls into one.
664
86ec63ba
PE
665 Revert the FOLLOW-SYMLINKS change for file-attributes.
666 Doing it right would require several changes to Tramp, and there's
667 not enough time to get that tested before the freeze today.
668 * dired.c (directory_files_internal, Ffile_attributes):
669 Undo last change.
670
82ef37c1
PE
671 * frame.c (x_report_frame_params): Port better to wider ints.
672 Do not assume that EMACS_UINT is the same width as uprintmax_t,
673 or that pointers can be printed in 15 decimal digits.
674 Avoid GCC warnings if EMACS_UINT is wider than a pointer.
675
62aba0d4
FP
6762012-09-30 Fabrice Popineau <fabrice.popineau@supelec.fr>
677
678 Support x64 build on MS-Windows.
679 * w32term.h (SCROLL_BAR_PACK, SCROLL_BAR_UNPACK): Define for x64.
680 (SET_SCROLL_BAR_W32_WINDOW): Cast ID to intptr_t, for
681 compatibility with x64.
5e4daaf3 682 (x_get_focus_frame): Add prototype.
62aba0d4
FP
683
684 * w32term.c (w32_draw_underwave): Don't use GCC extensions for
685 defining an XRectangle structure.
686
687 * w32proc.c (RVA_TO_PTR, w32_executable_type): Fix pointer
688 arithmetics for compatibility with x64.
689
690 * w32menu.c (add_menu_item): Use UINT_PTR instead of UINT, for
691 compatibility with x64.
692
693 * w32heap.h: Adjust prototypes and declarations.
694
695 * w32heap.c (RVA_TO_PTR, allocate_heap, sbrk, init_heap)
696 (round_heap): Use DWORD_PTR, ptrdiff_t and size_t instead of
697 DWORD, long, and unsigned long, for compatibility with x64.
698 (allocate_heap) [_WIN64]: Reserve 32GB of memory.
699 (sbrk): Argument is now of type ptrdiff_t.
700
701 * w32fns.c (HMONITOR): Condition declaration on _WIN32_WINNT being
702 less than 0x0500.
703 (w32_msg_pump): Use WPARAM type for 'result'.
704
705 * w32.c (init_environment, get_emacs_configuration): Support AMD64
706 architecture.
707 (init_ntproc): Cast arguments of _open_osfhandle to intptr_t, for
708 compatibility with x64.
709
710 * vm-limit.c (lim_data): Now size_t.
711 (check_memory_limits): Adjust prototypes of real_morecore and
712 __morecore to receive argument of type ptrdiff_t. Use size_t for
713 five_percent and data_size.
714
715 * unexw32.c: Use DWORD_PTR instead of DWORD for file-scope
716 variables, for compatibility with x64.
717 (rva_to_section, offset_to_section, relocate_offset)
718 (OFFSET_TO_RVA, RVA_TO_OFFSET, RVA_TO_SECTION_OFFSET)
719 (PTR_TO_RVA, RVA_TO_PTR, OFFSET_TO_PTR, get_section_info)
720 (copy_executable_and_dump_data): Use DWORD_PTR instead of DWORD
721 for compatibility with x64.
722
723 * sysdep.c (STDERR_FILENO): Define if not already defined.
724
725 * ralloc.c (real_morecore): Argument type is now ptrdiff_t.
726 (__morecore): Argument type is now ptrdiff_t.
727 (ROUNDUP, MEM_ROUNDUP): Use size_t instead of 'unsigned long'.
728 (relinquish): Use ptrdiff_t type for 'excess'.
729 (r_alloc_sbrk): Argument type is now ptrdiff_t.
730
731 * makefile.w32-in (HEAPSIZE): Get value from EMACS_HEAPSIZE.
732 (bootstrap-temacs-CMD, bootstrap-temacs-SH): Use $(EMACS_PURESIZE)
733 instead of a literal number.
734
735 * gmalloc.c [WINDOWSNT]: Include w32heap.h.
736 (min): Define only if not already defined.
737
738 * frame.c (x_report_frame_params): Use EMACS_UINT for the return
739 value of FRAME_X_WINDOW, to fit a 64-bit pointer on 64-bit Windows
740 hosts.
741
742 * image.c (x_bitmap_pixmap): Return ptrdiff_t, not int, since
743 'bitmaps' is a pointer.
744
745 * dispextern.h (x_bitmap_pixmap): Adjust prototype.
746
747 * alloc.c (gdb_make_enums_visible): Now conditional on __GNUC__.
748
e7a2937b
PE
7492012-09-30 Paul Eggert <eggert@cs.ucla.edu>
750
751 file-attributes has a new optional arg FOLLOW-SYMLINKS.
752 * dired.c (directory_files_internal, Ffile_attributes):
753 New arg follow_symlinks. All uses changed.
754
b43d62ae
SM
7552012-09-30 Stefan Monnier <monnier@iro.umontreal.ca>
756
757 * .gdbinit (xbacktrace): Adjust to recent "struct backtrace" change.
758
c06c382a
EZ
7592012-09-30 Eli Zaretskii <eliz@gnu.org>
760
761 Support atimers and CPU profiler via profile.c on MS-Windows.
762 * w32proc.c (sig_mask, crit_sig): New static variables.
763 (sys_signal): Support SIGALRM and SIGPROF.
764 (sigemptyset, sigaddset, sigfillset, sigprocmask)
b43d62ae 765 (pthread_sigmask, setpgrp): Move here from w32.c. sigaddset,
c06c382a
EZ
766 sigfillset, and sigprocmask are no longer no-ops.
767 (sigismember): New function.
768 (struct itimer_data): New definition.
769 (ticks_now, real_itimer, prof_itimer, clocks_min, crit_real)
770 (crit_prof): New static variables.
771 (MAX_SINGLE_SLEEP): New definition.
772 (timer_loop, stop_timer_thread, term_timers, init_timers)
773 (start_timer_thread, getitimer, setitimer): New functions.
774 (alarm): No longer a no-op, calls setitimer.
775
776 * w32.c (term_ntproc): Call term_timers.
777 (init_ntproc): Make sure all signals are unblocked at startup, to
778 erase any traces of dumping. Call init_timers.
779
780 * w32fns.c (hourglass_timer, HOURGLASS_ID): Remove.
781 Windows-specific code to display the hourglass mouse pointer is no
782 longer used.
783 (w32_wnd_proc): Remove code that handled the WM_TIMER message due
784 to hourglass timer expiration.
785 (start_hourglass, cancel_hourglass, DEFAULT_HOURGLASS_DELAY):
786 Remove, no longer used.
b43d62ae
SM
787 (w32_note_current_window, show_hourglass, hide_hourglass):
788 New functions, in support of hourglass cursor display similar to other
c06c382a
EZ
789 window systems.
790 (syms_of_w32fns): Don't initialize hourglass_timer.
791
792 * xdisp.c (start_hourglass, cancel_hourglass): Now used on
793 WINDOWSNT as well.
794 (start_hourglass) [WINDOWSNT]: Call w32_note_current_window.
795
796 * w32.h (init_timers, term_timers): Add prototypes.
797
95402d5f
KH
7982012-09-30 Kenichi Handa <handa@gnu.org>
799
800 * coding.c (decode_coding_ccl, encode_coding_ccl): Pay attention
801 to the buffer relocation which may be caused by ccl_driver.
802
dd946752
JD
8032012-09-30 Jan Djärv <jan.h.d@swipnet.se>
804
d7e642cc
JD
805 * xfns.c (Fx_file_dialog): Update comment.
806
807 * w32fns.c (Fx_file_dialog): Update comment.
808
809 * nsfns.m (Fns_read_file_name): Add argument DIR_ONLY_P.
810 Initialize panel name field if OSX >= 10.6.
811
812 * fileio.c (Fnext_read_file_uses_dialog_p): Add HAVE_NS.
813
dd946752
JD
814 * nsfns.m (ns_frame_parm_handlers): Add x_set_fullscreen.
815
816 * nsterm.m (NEW_STYLE_FS): New define.
817 (ns_fullscreen_hook, windowWillEnterFullScreen)
818 (windowDidEnterFullScreen, windowWillExitFullScreen)
819 (windowDidExitFullScreen, toggleFullScreen, handleFS)
820 (setFSValue): New functions.
821 (EmacsFSWindow): New implementation.
822 (canBecomeKeyWindow): New function for EmacsFSWindow.
823 (ns_create_terminal): Set fullscreen_hook to ns_fullscreen_hook.
824 (dealloc): Release nonfs_window if in fullscreen.
825 (updateFrameSize:): Call windowDidMove to update top/left.
826 (windowWillResize:toSize:): Check if frame is still maximized.
827 (initFrameFromEmacs:): Initialize fs_state, fs_before_fs,
828 next_maximized, maximized_width, maximized_height and nonfs_window.
829 Call setCollectionBehavior if NEW_STYLE_FS. Initialize bwidth and
830 tbar_height.
831 (windowWillUseStandardFrame:defaultFrame:): Update frame parameter
832 fullscreen. Set maximized_width/height. Act on next_maximized.
833
834 * nsterm.h (MAC_OS_X_VERSION_10_7, MAC_OS_X_VERSION_10_8): New.
835 (EmacsView): Add variables for fullscreen.
836 (handleFS, setFSValue, toggleFullScreen): New in EmacsView.
837 (EmacsFSWindow): New interface for fullscreen.
838
427730eb
JB
8392012-09-30 Juanma Barranquero <lekktu@gmail.com>
840
841 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
842
48de8b12
CY
8432012-09-30 Chong Yidong <cyd@gnu.org>
844
845 * fns.c (Frandom): Doc fix.
846
5938d519
MR
8472012-09-30 Martin Rudalics <rudalics@gmx.at>
848
849 * window.c (Vwindow_combination_limit): New default value.
850 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
851
cb5b0266
PE
8522012-09-30 Paul Eggert <eggert@cs.ucla.edu>
853
854 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
855 Suggested by Eli Zaretskii in
856 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
857
84f72efd
EZ
8582012-09-30 Eli Zaretskii <eliz@gnu.org>
859
860 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
861 HAVE_TIMER_SETTIME is defined.
862
9d4dcdc9
PE
8632012-09-30 Paul Eggert <eggert@cs.ucla.edu>
864
d89460ed
PE
865 Profiler improvements: more-accurate timers, overflow checks.
866 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
867 signal.h, setjmp.h. Include systime.h instead.
868 (saturated_add): New function.
869 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
870 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
871 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
872 New static vars.
84f72efd 873 (enum profiler_cpu_running): New enum.
d89460ed
PE
874 (profiler_cpu_running): Now of that enum type, not bool.
875 All uses changed to store the new value.
876 (handle_profiler_signal): Rename from sigprof_handler_1,
877 for consistency with other handlers. Do not check whether
878 cpu_log is a hash-table if garbage collecting, since it
879 doesn't matter in that case.
880 (deliver_profiler_signal): Rename from sigprof_handler,
881 for consistency with other handlers.
882 (setup_cpu_timer): New function, with much of what used to be in
883 Fprofiler_cpu_start. Check for out-of-range argument.
884 Prefer timer_settime if available, and prefer
885 thread cputime clocks, then process cputime clocks, then
886 monotonic clocks, to the old realtime clock. Use make_timeval
887 to round more-correctly when falling back to setitimer.
888 (Fprofiler_cpu_start): Use it.
889 (Fprofiler_cpu_stop): Prefer timer_settime if available.
890 Don't assume that passing NULL as the 2nd argument of setitimer
891 is the same as passing a pointer to all-zero storage.
892 Ignore SIGPROF afterwards.
893 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
894 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
895 non-fatal signal handlers. Ignore SIGPROF on startup.
896 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
897 in profiler.c, since sysdep.c now uses it.
898
9d4dcdc9
PE
899 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
900 Suggested by Eli Zaretskii in
901 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
902
8e5691a0
JB
9032012-09-29 Juanma Barranquero <lekktu@gmail.com>
904
905 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
906
e7c1b6ef
SM
9072012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
908
909 * lisp.h (struct backtrace): Remove indirection for `function' field.
910 * xdisp.c (redisplay_internal):
911 * profiler.c (record_backtrace, sigprof_handler_1):
912 * alloc.c (Fgarbage_collect):
913 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
914 (Fbacktrace_frame): Adjust accordingly.
915
e61d39cd 9162012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
917
918 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
919 (Frun_hook_with_args_until_failure): Doc fixes.
920
404043ea
EZ
9212012-09-28 Eli Zaretskii <eliz@gnu.org>
922
923 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
924 Qautomatic_redisplay and change the symbol name. All users changed.
925
704d3f45
TM
9262012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
927
928 * profiler.c (sigprof_handler): Fix race condition.
929
757140ff
GM
9302012-09-28 Glenn Morris <rgm@gnu.org>
931
932 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
933
a615a3ae
PE
9342012-09-27 Paul Eggert <eggert@cs.ucla.edu>
935
936 Check more robustly for timer_settime.
89d17fd0
PE
937 * Makefile.in (LIB_TIMER_TIME): New macro.
938 (LIBES): Add it.
a615a3ae
PE
939 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
940 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
941 call timer_settime.
942
3670daf7
TM
9432012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
944
945 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
946
6a586b7f
JB
9472012-09-26 Juanma Barranquero <lekktu@gmail.com>
948
949 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
950
41c8bfcf
PE
9512012-09-26 Paul Eggert <eggert@cs.ucla.edu>
952
953 * character.h (MAYBE_UNIFY_CHAR): Remove.
954 * charset.c, charset.h (maybe_unify_char): Now static.
955 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
956 Since this stuff is now private to charset.c, there's no need for
957 a public macro and no need to inline by hand.
958
3a880af4
SM
9592012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
960 Stefan Monnier <monnier@iro.umontreal.ca>
961 Juanma Barranquero <lekktu@gmail.com>
611b7507 962
3a880af4
SM
963 * profiler.c: New file.
964 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
965 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
966 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
967 * emacs.c (main): Call syms_of_profiler.
968 * alloc.c (Qautomatic_gc): New constant.
969 (MALLOC_PROBE): New macro.
970 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
971 (total_bytes_of_live_objects): New function.
972 (Fgarbage_collect): Use it. Record itself in backtrace_list.
973 Call malloc_probe for the memory profiler.
974 (syms_of_alloc): Define Qautomatic_gc.
975 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
976 race condition.
977 (struct backtrace): Move definition...
978 * lisp.h (struct backtrace): ..here.
979 (Qautomatic_gc, profiler_memory_running): Declare vars.
980 (malloc_probe, syms_of_profiler): Declare functions.
981 * xdisp.c (Qautomatic_redisplay): New constant.
982 (redisplay_internal): Record itself in backtrace_list.
983 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 984
5938d519 9852012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
9862012-09-25 Juanma Barranquero <lekktu@gmail.com>
987
988 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
989
e26fd2e4
PE
9902012-09-25 Paul Eggert <eggert@cs.ucla.edu>
991
992 Prefer POSIX timers if available.
993 They avoid a race if the timer is too close to the current time.
994 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
995 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 996 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 997
eedec3ee
EZ
9982012-09-25 Eli Zaretskii <eliz@gnu.org>
999
1000 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
1001 CHAR_STRING_ADVANCE.
1002 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
1003 STRING_CHAR_ADVANCE.
1004
aa15c6bb
JB
10052012-09-25 Juanma Barranquero <lekktu@gmail.com>
1006
1007 Move Vlibrary_cache to emacs.c and reset before dumping.
1008
1009 * lisp.h (reset_image_types): Declare.
1010 [WINDOWSNT] (Vlibrary_cache): Declare.
1011
1012 * image.c (reset_image_types): New function.
1013
1014 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
1015 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
1016 (Fdump_emacs): Reset Vlibrary_cache and image_types.
1017
1018 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
1019 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
1020
1021 * w32.h (Vlibrary_cache): Do not declare.
1022
54d629be
EZ
10232012-09-25 Eli Zaretskii <eliz@gnu.org>
1024
16b22fef
EZ
1025 * w32proc.c (sys_signal): Handle all signals defined by the
1026 MS-Windows runtime, not just SIGCHLD. Actually install the signal
1027 handlers for signals supported by Windows. Don't override
1028 term_ntproc as the handler for SIGABRT.
1029 (sigaction): Rewrite to call sys_signal instead of duplicating its
1030 code.
1031 (sys_kill): Improve commentary.
1032
1033 * w32.c (term_ntproc): Accept (and ignore) one argument, for
1034 consistency with a signature of a signal handler. All callers
1035 changed.
1036 (init_ntproc): Accept an argument DUMPING. If dumping, don't
1037 install term_ntproc as a signal handler for SIGABRT, as that
1038 should be done by the dumped Emacs.
1039
1040 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
1041
1042 * w32select.c (term_w32select): Protect against repeated
1043 invocation by setting clipboard_owner to NULL after calling
1044 DestroyWindow.
1045
1046 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
1047 and term_ntproc to their modified signatures.
1048
54d629be
EZ
1049 * character.c (char_string, string_char): Remove calls to
1050 MAYBE_UNIFY_CHAR. See the discussion starting at
1051 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
1052 for the details.
1053
59f7af81
CY
10542012-09-25 Chong Yidong <cyd@gnu.org>
1055
1056 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
1057
22e8cf4a
SM
10582012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
1061 when encountering an unknown bytecode.
1062
578098f3
PE
10632012-09-24 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 image.c, indent.c: Use bool for booleans.
1066 * dispextern.h (struct image_type): Members valid_p, load, init
1067 now return bool, not int. All uses changed.
1068 * image.c: Omit unnecessary static decls.
1069 (x_create_bitmap_mask, x_build_heuristic_mask):
1070 Return void, not int, since callers don't care about the return value.
1071 (x_create_bitmap_mask, define_image_type, valid_image_p)
1072 (struct image_keyword, parse_image_spec, image_spec_value)
1073 (check_image_size, image_background)
1074 (image_background_transparent, x_clear_image_1)
1075 (postprocess_image, lookup_image, x_check_image_size)
1076 (x_create_x_image_and_pixmap, xbm_image_p)
1077 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
1078 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
1079 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
1080 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
1081 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
1082 (png_image_p, init_png_functions, png_load_body, png_load)
1083 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
1084 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
1085 (init_gif_functions, gif_load, imagemagick_image_p)
1086 (imagemagick_load_image, imagemagick_load, svg_image_p)
1087 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
1088 (gs_load):
1089 * nsimage.m (ns_load_image):
1090 * nsterm.m (ns_defined_color):
1091 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
1092 * xfns.c (x_defined_color):
1093 * xterm.c (x_alloc_lighter_color_for_widget)
1094 (x_alloc_nearest_color_1, x_alloc_nearest_color)
1095 (x_alloc_lighter_color):
1096 * indent.c (disptab_matches_widthtab, current_column)
1097 (scan_for_column, string_display_width, indented_beyond_p)
1098 (compute_motion, vmotion, Fvertical_motion):
1099 Use bool for booleans.
1100
a5f2b6ec
CY
11012012-09-24 Chong Yidong <cyd@gnu.org>
1102
1103 * chartab.c (Fset_char_table_default): Obsolete function removed.
1104
18e27ea8
PE
11052012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1106
afea8a8a
PE
1107 Move pid_t related decls out of lisp.h.
1108 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
1109 (interruptible_wait_for_termination):
1110 Move these decls from lisp.h to syswait.h, since they use pid_t.
1111 Needed on FreeBSD; see Herbert J. Skuhra in
1112 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
1113 * callproc.c: Include syswait.h.
1114
18e27ea8
PE
1115 gnutls.c, gtkutil.c: Use bool for boolean.
1116 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
1117 (emacs_gnutls_handle_error):
1118 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
1119 (xg_hide_tooltip, xg_create_frame_widgets)
1120 (create_dialog, xg_uses_old_file_dialog)
1121 (xg_get_file_with_chooser, xg_get_file_with_selection)
1122 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
1123 (xg_item_label_same_p, xg_update_menubar)
1124 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
1125 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
1126 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
1127 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
1128 (update_frame_tool_bar, free_frame_tool_bar):
1129 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
1130 * nsmenu.m (ns_update_menubar):
1131 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
1132 * xfns.c (Fx_show_tip) [USE_GTK]:
1133 Use bool for boolean.
1134 * gtkutil.c (xg_update_frame_menubar):
1135 * xmenu.c (update_frame_menubar):
1136 Return void, not int, since caller ignores return value.
1137 * gtkutil.c (xg_change_toolbar_position):
1138 Return void, not 1.
1139
af0e9f75
JB
11402012-09-23 Juanma Barranquero <lekktu@gmail.com>
1141
1142 * makefile.w32-in (BLOCKINPUT_H): Remove.
1143 (SYSSIGNAL_H): New macro.
1144 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
1145 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
1146 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
1147 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
1148 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
1149 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
1150 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
1151 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
1152 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
1153 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
1154 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
1155 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
1156 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
1157 ($(BLD)/w32xfns.$(O)): Update dependencies.
1158
5101529e
EZ
11592012-09-23 Eli Zaretskii <eliz@gnu.org>
1160
1161 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
1162 fatal_error_backtrace.
1163
1164 * w32proc.c (sys_kill): Undo last change: don't do anything when
1165 invoked to deliver SIGABRT to our own process. This is now
1166 handled by emacs_raise.
1167
2c3ee0ad
JB
11682012-09-23 Juanma Barranquero <lekktu@gmail.com>
1169
1170 * w32term.c (w32_read_socket): Remove leftover reference to
1171 interrupt_input_pending.
1172
62a1d661
PE
11732012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 Do not use SA_NODEFER.
1176 Problem reported by Dani Moncayo in
1177 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
1178 * alloc.c (die):
1179 * sysdep.c (emacs_abort): Do not reset signal handler.
1180 * emacs.c (terminate_due_to_signal): Reset signal handler here.
1181 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
1182 wanted even on POSIXish hosts, and it doesn't work on Windows.
1183
a0942b9a
JD
11842012-09-23 Jan Djärv <jan.h.d@swipnet.se>
1185
1186 * xterm.c (x_term_init): Call fixup_locale before and after calling
1187 gtk_init (Bug#12392).
1188
d07ff9db
CY
11892012-09-23 Chong Yidong <cyd@gnu.org>
1190
1191 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
1192 Vdynamic_library_alist.
1193
1194 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
1195 (Fgnutls_available_p): Caller changed.
1196
1197 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
1198 (Flibxml_parse_xml_region): Likewise.
1199
1200 * dispextern.h (struct image_type): Remove arg from init function.
1201
1202 * image.c (Finit_image_library, lookup_image_type)
1203 (define_image_type): Remove now-unneeded second arg.
1204 (init_xpm_functions, init_png_functions, init_jpeg_functions)
1205 (init_tiff_functions, init_gif_functions, init_svg_functions):
1206 Arglist and w32_delayed_load calling convention changed.
1207 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 1208 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 1209
4d7e6e51
PE
12102012-09-23 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 Simplify and avoid signal-handling races (Bug#12471).
1213 * alloc.c (die):
1214 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
1215 Avoid recursive loop if there's a fatal error in the function itself.
1216 * atimer.c (pending_atimers):
1217 * blockinput.h: Don't include "atimer.h"; no longer needed.
1218 (interrupt_input_pending): Remove. All uses removed.
1219 pending_signals now counts both atimers and ordinary interrupts.
1220 This is less racy than having three separate pending-signal flags.
1221 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
1222 (input_blocked_p):
1223 Rename from their upper-case counterparts BLOCK_INPUT,
1224 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
1225 INPUT_BLOCKED_P, and turn into functions. All uses changed.
1226 This makes it easier to access volatile variables more accurately.
1227 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
1228 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
1229 that's more reliable if the code is buggy and sets
1230 interrupt_input_blocked to a negative value. All uses changed.
1231 * atimer.c (deliver_alarm_signal):
1232 Remove. No need to deliver this to the parent; any thread can
1233 handle this signal now. All uses replaced by underlying handler.
1234 * atimer.c (turn_on_atimers):
1235 * dispnew.c (handle_window_change_signal):
1236 * emacs.c (handle_danger_signal):
1237 * keyboard.c (kbd_buffer_get_event):
1238 Don't reestablish signal handler; not needed with sigaction.
1239 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
1240 (UNBLOCK_INPUT_TO):
1241 Rework to avoid unnecessary accesses to volatile variables.
1242 (UNBLOCK_INPUT_TO): Now a function.
1243 (totally_unblock_input, unblock_input): New decls.
1244 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
1245 (init_data): Remove. Necessary stuff now done in init_signal.
1246 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
1247 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
1248 (fatal_error_code): Remove; no longer needed.
1249 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
1250 it doesn't always backtrace. All uses changed. No need to reset
1251 signal to default, since sigaction and/or die does that for us now.
1252 Use emacs_raise (FOO), not kill (getpid (), FOO).
1253 (main): Check more-accurately whether we're dumping.
1254 Move fatal-error setup to sysdep.c
1255 * floatfns.c: Do not include "syssignal.h"; no longer needed.
1256 * gtkutil.c (xg_get_file_name, xg_get_font):
1257 Remove no-longer-needed signal-mask manipulation.
1258 * keyboard.c, process.c (POLL_FOR_INPUT):
1259 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
1260 * keyboard.c (read_avail_input): Remove.
1261 All uses replaced by gobble_input.
1262 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
1263 (kbd_buffer_store_event_hold, gobble_input):
1264 (record_asynch_buffer_change) [USABLE_SIGIO]:
1265 (store_user_signal_events):
1266 No need to mess with signal mask.
1267 (gobble_input): If blocking input and there are terminals, simply
1268 set pending_signals to 1 and return. All hooks changed to not
1269 worry about whether input is blocked.
1270 (process_pending_signals): Clear pending_signals before processing
1271 them, in case a signal comes in while we're processing.
1272 By convention callers now test pending_signals before calling us.
1273 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
1274 New functions, to support changes to blockinput.h.
1275 (handle_input_available_signal): Now extern.
1276 (reinvoke_input_signal): Remove. All uses replaced by
1277 handle_async_input.
1278 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
1279 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
1280 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
1281 Clear sigmask reliably, even if Fsignal returns, which it can.
1282 Omit unnecessary accesses to volatile var.
1283 (quit_throw_to_read_char): No need to restore sigmask.
1284 * keyboard.c (gobble_input, handle_user_signal):
1285 * process.c (wait_reading_process_output):
1286 Call signal-handling code rather than killing ourselves.
1287 * lisp.h: Include <float.h>, for...
1288 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
1289 (pending_signals): Now volatile.
1290 (syms_of_data): Now const if IEEE floating point.
1291 (handle_input_available_signal) [USABLE_SIGIO]:
1292 (terminate_due_to_signal, record_child_status_change): New decls.
1293 * process.c (create_process): Avoid disaster if memory is exhausted
1294 while we're processing a vfork, by tightening the critical section
1295 around the vfork.
1296 (send_process_frame, process_sent_to, handle_pipe_signal)
1297 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
1298 ignores SIGPIPE.
1299 (send_process): No need for setjmp/longjmp any more, since the
1300 SIGPIPE stuff is now gone. Instead, report an error if errno
1301 is EPIPE.
1302 (record_child_status_change): Now extern. PID and W are now args.
1303 Return void, not bool. All callers changed.
1304 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
1305 Remove. All uses removed. This bug should be fixed now in a
1306 different way.
1307 (wait_for_termination_1): Use waitpid rather than sigsuspend,
1308 and record the child status change directly. This avoids the
1309 need to futz with the signal mask.
1310 (process_fatal_action): Move here from emacs.c.
1311 (emacs_sigaction_flags): New function, containing
1312 much of what used to be in emacs_sigaction_init.
1313 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
1314 caught by emacs, to make races less likely.
1315 (deliver_process_signal): Rename from handle_on_main_thread.
1316 All uses changed.
1317 (BACKTRACE_LIMIT_MAX): Now at top level.
1318 (thread_backtrace_buffer, threadback_backtrace_pointers):
1319 New static vars.
1320 (deliver_thread_signal, deliver_fatal_thread_signal):
1321 New functions, for more-accurate delivery of thread-specific signals.
1322 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
1323 (deliver_arith_signal): Handle in this thread, not
1324 in the main thread, since it's triggered by this thread.
1325 (maybe_fatal_sig): New function.
1326 (init_signals): New arg DUMPING so that we can be more accurate
1327 about whether we're dumping. Caller changed.
1328 Treat thread-specific signals differently from process-general signals.
1329 Block all signals while handling fatal error; that's safer.
1330 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
1331 on IEEE hosts.
1332 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
1333 Ignore SIGPIPE unless batch.
1334 (emacs_backtrace): Output backtrace for the appropriate thread,
1335 which is not necessarily the main thread.
1336 * syssignal.h: Include <stdbool.h>.
1337 (emacs_raise): New macro.
1338 * xterm.c (x_connection_signal): Remove; no longer needed
1339 now that we use sigaction.
1340 (x_connection_closed): No need to mess with sigmask now.
1341 (x_initialize): No need to reset SIGPIPE handler here, since
1342 init_signals does this for us now.
1343
8f4635e9
JD
13442012-09-23 Jan Djärv <jan.h.d@swipnet.se>
1345
1346 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 1347 background rect may be larger (Bug#12245).
8f4635e9 1348
3296976d
CY
13492012-09-23 Chong Yidong <cyd@gnu.org>
1350
1351 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
1352
d41e491e
PE
13532012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 * .gdbinit: Just stop at fatal_error_backtrace.
1356 See Stefan Monnier's request in
1357 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
1358 Remove no-longer-used query of system type.
1359
c88b867f
CY
13602012-09-22 Chong Yidong <cyd@gnu.org>
1361
1362 * search.c (Freplace_match): Doc fix (Bug#12325).
1363
1364 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
1365
1366 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
1367 (Fline_end_position): Doc fix.
1368
1369 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
1370
bb4d86b4
CY
13712012-09-22 Chong Yidong <cyd@gnu.org>
1372
1373 * dispextern.h (struct image_type): Add new slot, storing a type
1374 initialization function.
1375
1376 * image.c (define_image_type): Call the image initializer function
1377 if it is defined. Arguments and return value changed.
1378 (valid_image_p, make_image): Callers changed.
1379 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
1380 (gif_type, imagemagick_type, svg_type, gs_type):
1381 Add initialization functions.
bb4d86b4
CY
1382 (Finit_image_library): Call lookup_image_type.
1383 (CHECK_LIB_AVAILABLE): Macro deleted.
1384 (lookup_image_type): Call define_image_type here, rather than via
1385 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
1386 (syms_of_image): Move define_image_type calls for xbm_type and
1387 pbm_type to lookup_image_type.
1388
df9685f3
EZ
13892012-09-22 Eli Zaretskii <eliz@gnu.org>
1390
1391 * keyboard.c (timer_check_2): Move calculation of 'timers' and
1392 'idle_timers' from here ...
1393 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
1394 lists, to avoid infloops when the timer does something stupid,
1395 like reinvoke itself with the same or smaller time-out.
1396 (Bug#12447)
1397
8e17c9ba
MR
13982012-09-22 Martin Rudalics <rudalics@gmx.at>
1399
1400 * window.c (Fsplit_window_internal): Handle only Qt value of
1401 Vwindow_combination_limit separately.
1402 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
1403 (Vwindow_combination_limit): New default value.
1404 Rewrite doc-string.
8e17c9ba 1405
589bd69b
EZ
14062012-09-22 Eli Zaretskii <eliz@gnu.org>
1407
1408 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
1409 the new overlay string. (Bug#10159)
1410
01108e3f
PE
14112012-09-22 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
1414 or that fprintf is async-signal-safe. POSIX doesn't require
1415 either assumption.
1416
82f8cd94
CY
14172012-09-22 Chong Yidong <cyd@gnu.org>
1418
1419 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
1420 (Bug#8207).
1421
3cccbd87
KH
14222012-09-22 Kenichi Handa <handa@gnu.org>
1423
1424 * composite.c (composition_reseat_it): Handle the case that a
1425 grapheme cluster is not covered by a single font (Bug#12352).
1426
09c01941
CY
14272012-09-21 Chong Yidong <cyd@gnu.org>
1428
1429 * image.c (define_image_type): Avoid adding duplicate types to
1430 image_types (Bug#12463). Suggested by Jörg Walter.
1431
acfa068f 14322012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
1433
1434 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
1435 (print_load_command_name): Add case LC_DATA_IN_CODE.
1436 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
1437
acfa068f 14382012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
1439
1440 * eval.c (Frun_hook_with_args_until_success)
1441 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
1442
acfa068f 14432012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
1444
1445 * fileio.c (Ffile_selinux_context): Only call freecon when
1446 lgetfilecon succeeded.
1447 (Fset_file_selinux_context): Likewise. (Bug#12444)
1448
acfa068f 14492012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
1450
1451 * xdisp.c (try_window_reusing_current_matrix): Under bidi
1452 reordering, locate the cursor by calling set_cursor_from_row; if
1453 that fails, clear the desired glyph matrix before returning a
1454 failure indication to the caller. Fixes leaving garbled display
1455 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
1456 (compute_stop_pos_backwards): Fix a typo that caused crashes while
1457 scrolling through multibyte text.
aa36e4d2 1458
e99f70c8
SM
14592012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
1460
1461 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
1462 calling mark_vectorlike since that's the one that marks the window.
1463 (mark_discard_killed_buffers): Mark the final cdr.
1464 * window.h (struct window): Move prev/next_buffers to the
1465 non-standard fields.
1466 * window.c (make_window): Initialize prev/next_buffers manually.
1467
f75beb47
PE
14682012-09-20 Paul Eggert <eggert@cs.ucla.edu>
1469
1470 Omit unused arg EXPECTED from socket hooks.
1471 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
1472 * nsterm.m (ns_term_init):
1473 * termhooks.h (struct terminal.read_socket_hook):
1474 * w32inevt.c (w32_console_read_socket):
1475 * w32term.c (w32_read_socket):
1476 * xterm.c (XTread_socket):
1477 Omit unused arg EXPECTED. All callers changed.
1478 (store_user_signal_events): Return void, not int, since callers no
1479 longer care about the return value. All uses changed.
1480
b019b76a
JB
14812012-09-20 Juanma Barranquero <lekktu@gmail.com>
1482
1483 * w32gui.h (XParseGeometry): Do not declare.
1484
05642592
PE
14852012-09-19 Paul Eggert <eggert@cs.ucla.edu>
1486
e4bce92a
PE
1487 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
1488 Ignore 'expected'. See Eli Zaretskii in
1489 <http://bugs.gnu.org/12471#8> (last line).
1490
05642592
PE
1491 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
1492 (XParseGeometry): Now static. Substitute extremal values for
1493 values that are out of range.
1494
e543ae91
JD
14952012-09-19 Jan Djärv <jan.h.d@swipnet.se>
1496
1497 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
1498
1499 * nsfns.m (XParseGeometry): Remove.
1500 (Fx_create_frame): Call x_set_offset to correctly interpret
1501 top_pos in geometry.
1502
3a880af4 1503 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
1504 (Fx_parse_geometry): If there is a space in string, call
1505 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
1506
45ba16c7
EZ
15072012-09-17 Eli Zaretskii <eliz@gnu.org>
1508
c8b9f1bc
EZ
1509 * search.c (scan_buffer): Use character positions in calls to
1510 region_cache_forward and region_cache_backward, not byte
1511 positions. (Bug#12196)
1512
b4c932a2
EZ
1513 * w32term.c (w32_read_socket): Set pending_signals to 1, like
1514 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
1515
45ba16c7
EZ
1516 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
1517 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
1518 emacs_blocked_malloc, now deleted.
1519
eeceac93
PE
15202012-09-17 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
1523 The workaround was for improving performance on Solaris 2.4, but
1524 is getting in the way now. Emacs will still work if someone is
1525 still running Solaris 2.4 in a museum somewhere; Sun dropped
1526 support for Solaris 2.4 in 2003.
1527 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
1528 * process.c (create_process) [HAVE_WORKING_VFORK]:
1529 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
1530 since Emacs no longer uses vfork on that platform.
1531
78f83752
GM
15322012-09-17 Glenn Morris <rgm@gnu.org>
1533
1534 * emacs.c: Use COPYRIGHT.
1535
634b8cac
PE
15362012-09-16 Paul Eggert <eggert@cs.ucla.edu>
1537
0caaedb1
PE
1538 Remove configure's --without-sync-input option (Bug#12450).
1539 When auditing signal-handling in preparation for cleaning it up,
1540 I found that SYNC_INPUT has race conditions and would be a real
1541 pain to fix. Since it's an undocumented and deprecated
1542 configure-time option, now seems like a good time to remove it.
1543 Also see <http://bugs.gnu.org/11080#16>.
1544 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
1545 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
1546 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1547 (malloc_hysteresis):
1548 (check_depth) [XMALLOC_OVERRUN_CHECK]:
1549 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
1550 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
1551 (dont_register_blocks, bytes_used_when_reconsidered)
1552 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
1553 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
1554 [!SYSTEM_MALLOC && !SYNC_INPUT]:
1555 Remove. All uses removed.
1556 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
1557 implementation, one that depends on whether the new macro
1558 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
1559 is defined.
1560 * atimer.c (run_timers, handle_alarm_signal):
1561 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
1562 (handle_async_input, process_pending_signals)
1563 (handle_input_available_signal, init_keyboard):
1564 * nsterm.m (ns_read_socket):
1565 * process.c (wait_reading_process_output):
1566 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
1567 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
1568 (emacs_write):
1569 * xterm.c (XTread_socket):
1570 Assume SYNC_INPUT.
1571 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
1572 * eval.c (handling_signal): Remove. All uses removed.
1573 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
1574 All uses replaced with the SYNC_INPUT version.
1575 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
1576 Remove decls.
1577 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1578 Now static.
1579
634b8cac
PE
1580 * font.c (Ffont_shape_gstring): Remove unused local.
1581
83da1b55
GM
15822012-09-16 Glenn Morris <rgm@gnu.org>
1583
518650a5
GM
1584 * Makefile.in (clean): No longer run nextstep's clean.
1585
83da1b55
GM
1586 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
1587 (ns_frag): Remove.
1588 (ns-app): Move here from ns.mk, and simplify.
1589 (clean): Simplify nextstep entry.
1590 * ns.mk: Remove file.
1591
85a43e2e
KH
15922012-09-17 Kenichi Handa <handa@gnu.org>
1593
1594 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
1595 not covert the last few charactes.
1596
ba13e616 15972012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
1598
1599 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
1600 here, but just check the validity of glyphs in the glyph-string.
1601
a8c729af
MR
16022012-09-16 Martin Rudalics <rudalics@gmx.at>
1603
3a880af4
SM
1604 * window.c (Fwindow_parameter, Fset_window_parameter):
1605 Accept any window as argument (Bug#12452).
a8c729af 1606
c077c059
JD
16072012-09-16 Jan Djärv <jan.h.d@swipnet.se>
1608
1609 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
1610 to ns_term_init to avoid memory leak.
1611
1612 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
1613 explicit retain/release.
1614 (ns_term_init): Only allow one display. Initialize outerpool and
1615 ns_*_types.
1616
39a57ad0
PE
16172012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 Port _setjmp fix to POSIXish hosts as well as Microsoft.
1620 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
1621 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
1622 the Microsoft problem in a different way, by altering ../nt/config.nt.
1623
7105c8cb
EZ
16242012-09-15 Eli Zaretskii <eliz@gnu.org>
1625
1626 * w32xfns.c:
1627 * w32uniscribe.c:
1628 * w32term.c:
1629 * w32select.c:
1630 * w32reg.c:
1631 * w32proc.c:
1632 * w32menu.c:
1633 * w32inevt.c:
1634 * w32heap.c:
1635 * w32font.c:
1636 * w32fns.c:
1637 * w32console.c:
1638 * w32.c:
1639 * w16select.c: Remove inclusion of setjmp.h, as it is now included
1640 by lisp.h. This completes removal of setjmp.h inclusion
1641 erroneously announced in the previous commit. (Bug#12446)
1642
1643 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
1644 more accurate.
1645
1646 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
1647 not defined as a macro. The latter happens on MS-Windows.
1648 (Bug#12446)
1649
0328b6de
PE
16502012-09-15 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 Port better to POSIX hosts lacking _setjmp (Bug#12446).
1653 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 1654 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
1655 only reason for the instance was because "lisp.h" was included.
1656 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
1657 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
1658 and _longjmp with the new symbols. Emacs already uses _setjmp if
1659 available, so this change affects only POSIXish hosts that have
1660 sigsetjmp but not _setjmp, such as some versions of Solaris and
1661 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
1662 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
1663 (png_load_body) [HAVE_PNG]:
1664 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
1665 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
1666 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
1667 since PNG requires jmp_buf. This is the only exception to the
1668 general rule that we now use sys_setjmp and sys_longjmp.
1669 This exception is OK since this code does not change the signal
1670 mask or longjmp out of a signal handler.
1671
2af03429
PE
16722012-09-14 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
1675 Include "syssignal.h", for 'main_thread'.
1676
2f294edf
DA
16772012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
1678
1679 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
1680 * insdel.c (replace_range, replace_range_2):
1681 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
1682 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
1683 Remove redundant check before calling offset_intervals.
1684
6b533e9c
MR
16852012-09-14 Martin Rudalics <rudalics@gmx.at>
1686
1687 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
1688 current buffer (Bug#12387).
1689
2a7931e3
JB
16902012-09-14 Juanma Barranquero <lekktu@gmail.com>
1691
1692 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
1693
c18e885b
PE
16942012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 Use a more backwards-compatible timer format (Bug#12430).
1697 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
1698 vector element, not from the 4th, since PSECS is now at the end.
1699 (Fcurrent_idle_time): Doc fix.
1700
d59a1afb
DA
17012012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
1702
1703 Function to mark objects and remove killed buffers at once.
1704 * alloc.c (discard_killed_buffers): Rename to ...
1705 (mark_discard_killed buffers) ... new name. Add marking
1706 of remaining objects. Fix comment. Adjust users.
1707 (mark_object): Do not touch frame buffer lists here.
1708 * frame.c (delete_frame): Reset frame buffer lists here.
1709
5f0cb45a
PE
17102012-09-13 Paul Eggert <eggert@cs.ucla.edu>
1711
8ea47e3a
PE
1712 Better workaround for GNOME bug when --enable-gcc-warnings.
1713 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
1714 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
1715 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
1716
4a4bbad2
PE
1717 Simplify SIGIO usage (Bug#12408).
1718 The code that dealt with SIGIO was crufty and confusing, e.g., it
1719 played tricks like "#undef SIGIO" but these tricks were not used
1720 consistently. Simplify mostly by not #undeffing standard symbols,
1721 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
1722 or not as we please) rather than "defined SIGIO" (standard symbol
1723 that we probably shouldn't #undef).
1724 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
1725 Modules that need it can include it.
1726 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
1727 * dispextern.h (ignore_sigio): New decl.
1728 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
1729 unconditionally, since it's now a no-op if !USABLE_SIGIO.
1730 * emacs.c (shut_down_emacs):
1731 * keyboard.c (kbd_buffer_store_event_hold):
1732 Use ignore_sigio rather than invoking 'signal' directly.
1733 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
1734 for FIONREAD.
1735 (FIONREAD, SIGIO): Do not #undef.
1736 (tty_read_avail_input): Use #error rather than a syntax error.
1737 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
1738 for I_PIPE, used by SETUP_SLAVE_PTY.
1739 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
1740 * sysdep.c (croak): Remove; no longer needed. This bit of
1741 temporary code, with Fred N. Fish's comment that it's temporary,
1742 has been in Emacs since at least 1992!
1743 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
1744 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
1745 * syssignal.h (croak): Remove decl.
1746 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
1747 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
1748 now that we're termios-only.
1749 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
1750 * term.c (dissociate_if_controlling_tty): Use #error rather than
1751 a run-time error.
1752
5f0cb45a
PE
1753 Work around GCC and GNOME bugs when --enable-gcc-warnings.
1754 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
1755 to work around GNOME bug 683906.
1756 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
1757 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
1758 This works around GCC bug 54561.
1759
40bce90b
PE
17602012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 More fixes for 'volatile' and setjmp/longjmp.
1763 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
1764 * image.c (struct png_load_context) [HAVE_PNG]: New type.
1765 (png_load_body) [HAVE_PNG]:
1766 (jpeg_load_body) [HAVE_JPEG]:
1767 New function, with most of the old parent function's body.
1768 (png_load) [HAVE_PNG]:
1769 (jpeg_load) [HAVE_JPEG]:
1770 Invoke the new function, to avoid longjmp munging our locals.
1771 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
1772 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
1773 longjmp is passed 2, as the C standard doesn't guarantee this.
1774 Instead, store the failure code into mgr->failure_code.
1775
bfeae2cf
SM
17762012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1777
1778 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
1779 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
1780 (syms_of_keyboard): Remove support for unread-command-char.
1781
8099e36b
EZ
17822012-09-12 Eli Zaretskii <eliz@gnu.org>
1783
1784 * w32proc.c (sys_kill): If PID is our process ID and the signal is
1785 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
1786 violation. (Bug#12426)
1787
92547ff9
PE
17882012-09-12 Paul Eggert <eggert@cs.ucla.edu>
1789
1790 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
1791
45b82ad0
SM
17922012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1793
1794 * eval.c: Add `inhibit-debugger'.
1795 (Qinhibit_debugger): New symbol.
1796 (call_debugger): Bind it instead of Qdebug_on_error.
1797 (maybe_call_debugger): Test Vinhibit_debugger.
1798 (syms_of_eval): Define inhibit-debugger.
1799 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
1800 (syms_of_xdisp): Remove inhibit-debug-on-message.
1801
5779a1dc
PE
18022012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1803
50f2e553
PE
1804 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
1805 If a nonvolatile local variable is written before a _longjmp to
1806 the frame containing the variable, and is read after the _longjmp,
1807 the value read is indeterminate. Some local variables of type
1808 'struct handler' and 'struct catchtag' are used in this way, so
1809 mark each of their slots as volatile if the slot can be set before
1810 _longjmp and read afterwards.
1811 * lisp.h (struct handler): var and chosen_clause are now volatile.
1812 (struct catchtag): val, next, and pdlcount are now volatile.
1813
ae1d87e2
PE
1814 * bidi.c (bidi_push_it, bidi_pop_it):
1815 * fns.c (copy_hash_table):
1816 * image.c (define_image_type):
1817 * keyboard.c (kbd_buffer_store_event_hold):
1818 * process.c (Fprocess_send_eof):
1819 * xfaces.c (x_create_gc) [HAVE_NS]:
1820 * xgselect.c (xg_select):
1821 Prefer assignment to memcpy when either will do.
1822
5779a1dc
PE
1823 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
1824 Use pointer-to-a-pointer to simplify and avoid a NILP check each
1825 time an item is removed. No need to mark this function 'inline';
1826 the compiler knows better than we do.
1827
c4c9756b
JD
18282012-09-11 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
1831 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
1832 to change_frame_size (Bug#12388).
1833 (windowDidResize:): Pass YES to updateFrameSize.
1834
1835 * nsterm.h: Add delay parameter to updateFrameSize.
1836
d73e321c
DA
18372012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1838
1839 Discard killed buffers from deleted window and frame objects.
1840 This reduces an amount of references to killed buffers and
1841 helps GC to reclaim them faster.
1842 * alloc.c (discard_killed_buffers): New function.
1843 (mark_object): Use it for deleted windows and frames.
1844 (mark_object): If symbol's value is set up for a killed buffer
1845 or deleted frame, restore it's global binding.
1846 * data.c (swap_in_global_binding): Add GC notice.
1847 (swap_in_symval_forwarding): Use convenient set_blv_where.
1848 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
1849 * window.h: ... to here.
1850
e578f381
DA
18512012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1852
1853 Convenient macro to check whether the buffer is live.
1854 * buffer.h (BUFFER_LIVE_P): New macro.
1855 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
1856 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
1857
3057e615
YM
18582012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1859
1860 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
1861 composition cases (Bug#12364).
1862
1863 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
1864 overhang of succeeding glyphs overlapping box cursor.
1865
1866 * w32term.c (x_draw_glyph_string): Likewise.
1867
6fda35f2
PE
18682012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1869
c990426a
PE
1870 Simplify, document, and port floating-point (Bug#12381).
1871 The porting part of this patch fixes bugs on non-IEEE platforms
1872 with frexp, ldexp, logb.
1873 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
1874 Now static.
1875 * floatfns.c: Simplify discussion of functions that Emacs doesn't
1876 support, by removing commented-out code and briefly listing the
1877 C89 functions excluded. The commented-out stuff was confusing
1878 maintenance, e.g., we thought we needed cbrt but it was commented out.
1879 (logb): Remove decl; no longer needed.
1880 (isfinite): New macro, if not already supplied.
1881 (isnan): Don't replace any existing macro.
1882 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
1883 are present on all C89 platforms.
1884 (Ffrexp): Do not special-case zero, as frexp does the right thing
1885 for that case.
1886 (Flogb): Do not use logb, as it doesn't have the desired meaning
1887 on hosts that use non-base-2 floating point. Instead, stick with
1888 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
1889 frexp, to avoid getting an unspecified result.
1890
6fda35f2
PE
1891 * xdisp.c (Qinhibit_debug_on_message): Now static.
1892
16130a58
JD
18932012-09-10 Jan Djärv <jan.h.d@swipnet.se>
1894
1895 * nsterm.m (ns_update_begin): Set clip path to whole view by using
1896 NSBezierPath (Bug#12131).
1897
d105a573
CY
18982012-09-10 Chong Yidong <cyd@gnu.org>
1899
1900 * fns.c (Fdelq, Fdelete): Doc fix.
1901
ff55dfe8
PE
19022012-09-10 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
1905 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
1906
e7032e7c
SM
19072012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
1908
1909 * lisp.h (make_lisp_ptr): New macro to replace XSET.
1910 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
1911 Use it.
1912
e9957956
EZ
19132012-09-09 Eli Zaretskii <eliz@gnu.org>
1914
aba05ce9
EZ
1915 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1916 left fringe if the window has a left margin. This avoids leaving
1917 traces of the cursor because its leftmost pixel is not drawn over.
1918
e9957956
EZ
1919 * dispnew.c (update_window_line): When the left margin area of a
1920 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1921 that screen line. (Bug#12277)
1922
f6196b87
PE
19232012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 Assume C89 or later for math functions (Bug#12381).
1926 This simplifies the code, and makes it a bit smaller and faster,
1927 and (most important) makes it easier to clean up signal handling
1928 since we can stop worring about floating-point exceptions in
1929 library code. That was a problem before C89, but the problem
1930 went away many years ago on all practical Emacs targets.
1931 * data.c, image.c, lread.c, print.c:
1932 Don't include <math.h>; no longer needed.
1933 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1934 might be autoconfigured, as that never happens.
1935 * data.c (fmod):
1936 * doprnt.c (DBL_MAX_10_EXP):
1937 * print.c (DBL_DIG):
1938 Remove. C89 or later always defines these.
1939 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1940 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1941 (arith_error, domain_error, domain_error2):
1942 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1943 no longer needed -- we simply return what C returns. All uses removed.
1944 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1945 the wrapped code.
1946 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1947 Remove. All uses expanded, as these macros are no longer used
1948 more than once and are now more trouble than they're worth.
1949 (Ftan): Use tan, not sin / cos.
1950 (Flogb): Assume C89 frexp.
1951 (fmod_float): Assume C89 fmod.
1952 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1953 (init_floatfns): Remove. All uses removed.
1954
9d7f1863
JD
19552012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1956
1957 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1958 compositeToPoint for OSX < 10.6 (Bug#12390).
1959
eabf0404
PE
19602012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1963 This produces more-accurate results.
1964
0b3b1d23
JD
19652012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1966
1967 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1968 changes (Bug#12088).
1969
6dcef6ec
CY
19702012-09-08 Chong Yidong <cyd@gnu.org>
1971
1972 * syntax.c (Fstring_to_syntax): Doc fix.
1973
aa7d57c5
JD
19742012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1975
1976 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1977 in the internal border.
1978 (x_set_window_size): Remove static variables and their usage.
1979 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1980 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1981 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1982 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1983 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1984 (ns_fix_rect_ibw): Remove.
1985 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1986 (ns_dumpglyphs_box_or_relief): Ditto.
1987 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1988 adjustment.
1989 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1990 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1991 border adjustment.
1992 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1993 their usage. Add fringe_extended_p and its use as in other terms.
1994 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1995 scroll bar was removed.
1996 (updateFrameSize): New function.
1997 (windowDidResize): Move code to updateFrameSize and call it.
1998
1999 * nsterm.h (EmacsView): Add updateFrameSize.
2000
1a5432bc
CY
20012012-09-07 Chong Yidong <cyd@gnu.org>
2002
b4f5313e
CY
2003 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
2004
1a5432bc
CY
2005 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
2006
1a4f1e9b
PE
20072012-09-07 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
2010 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
2011 Problem introduced when merging patches. Noted by Eli Zaretskii in
2012 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
2013 * floatfns.c: Comment fix.
2014 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
2015 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
2016 and anyway the declaration is harmless even if SIGDANGER is not defined.
2017 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
2018 defined BROKEN_FIONREAD). systty.h formerly did this, but other
2019 source files not surprisingly expected syssignal.h to define, or
2020 not define, SIGIO, and it's cleaner to do it that way, for consistency.
2021 Include <sys/ioctl.h>, for FIONREAD.
2022 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
2023 This eliminates a problem whereby other files mysteriously had
2024 to include "syssignal.h" before including "systty.h" if they
2025 wanted to use "#ifdef SIGIO".
2026
bc8000ff
EZ
20272012-09-07 Eli Zaretskii <eliz@gnu.org>
2028
3e6d6928
EZ
2029 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
2030
2031 * w32.c (sigemptyset): Empty the set.
2032 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
2033
bc8000ff
EZ
2034 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
2035
b4fa72f2
DA
20362012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
2037
2038 * alloc.c (mark_buffer): Revert unsafe marking optimization.
2039 (mark_object): Likewise for frame objects.
2040
30730c93
PE
20412012-09-07 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 * syssignal.h (handle_on_main_thread): Always declare,
2044 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
2045 This ports to platforms without HAVE_PTHREAD.
2046
2fe28299
PE
20472012-09-06 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 Signal-handler cleanup (Bug#12327).
2050 Emacs's signal handlers were written in the old 4.2BSD style with
2051 sigblock and sigmask and so forth, and this led to some
2052 inefficiencies and confusion. Rewrite these to use
2053 pthread_sigmask etc. without copying signal sets around. Also,
2054 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
2055 'signal', and instead use functions that do not attempt to take
2056 over the system name space. This patch causes Emacs's text
2057 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
2058 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
2059 Do not include <signal.h> or "syssignal.h", as these
2060 modules do not use signals.
2061 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
2062 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
2063 Do not include <signal.h>, as "syssignal.h" does that for us now.
2064 * atimer.c (sigmask_atimers): New function.
2065 (block_atimers, unblock_atimers): New functions,
2066 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
2067 All uses replaced.
2068 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
2069 no longer needed here.
2070 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 2071 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
2072 * sysdep.c (struct save_signal): New member 'action', replacing
2073 old member 'handler'.
2074 (save_signal_handlers, restore_signal_handlers):
2075 Use sigaction instead of 'signal' to save and restore.
2076 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
2077 New function. All users of 'signal' modified to use set_sighandler
2078 if they're writeonly, and to use sys_signal if they're read+write.
2079 (emacs_sigaction_init, forwarded_signal): New functions.
2080 (sys_signal): Remove. All uses replaced by calls to sigaction
2081 and emacs_sigaction_init, or by direct calls to 'signal'.
2082 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
2083 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
2084 all uses replaced by pthread_sigmask etc. calls.
2085 * syssignal.h: Include <signal.h>.
2086 (emacs_sigaction_init, forwarded_signal): New decls.
2087 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
2088 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
2089 (sigmask, sys_sigmask): Remove; no longer needed.
2090 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
2091 (sigblock, sigunblock, sigfree):
2092 (sigsetmask) [!defined sigsetmask]:
2093 Remove. All uses replaced by pthread_sigmask.
2094 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
2095 no longer need to be replaced, and its typical old uses
2096 are now done via emacs_sigaction_init and sigaction.
2097 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
2098 (sys_sigdel): Remove; unused.
2099 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
2100
0216c128
EZ
21012012-09-06 Eli Zaretskii <eliz@gnu.org>
2102
2103 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
2104 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
2105
c752cfa9
DA
21062012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
2107
2108 Explicitly mark buffer_defaults and buffer_local_symbols.
2109 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
2110 mark_local_symbols here.
2111 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
2112 since special buffers aren't marked here any more.
2113 (allocate_buffer): Chain new buffer with all_buffers here...
2114 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
2115 not here.
2116 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
2117 (syms_of_buffer): Remove staticpro of the above.
2118 (init_buffer_once): Set names for buffer_defaults and
2119 buffer_local_symbols.
2120
a864ef14
PE
21212012-09-06 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 Use bool for booleans in font-related modules.
2124 * font.c (font_intern_prop, font_style_to_value)
2125 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
2126 (generate_otf_features, font_check_otf_features, font_check_otf)
2127 (font_match_p, font_list_entities, font_at):
2128 * fontset.c (fontset_id_valid_p, reorder_font_vector
2129 (fontset_find_font, Fset_fontset_font)
2130 (face_suitable_for_char_p) [0]:
2131 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
2132 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
2133 (m17n_flt_initialized, ftfont_shape_by_flt):
2134 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
2135 * nsfont.m (nsfont_draw):
2136 * w32font.c (w32font_draw):
2137 * w32term.c (x_draw_glyphless_glyph_string_foreground):
2138 Use bool for booleans.
2139 * font.h: Adjust to above API changes.
2140 (struct font, struct font_driver, struct font_driver_list):
2141 Use bool for booleans.
2142 (struct font): Remove useless member encoding_type.
2143 All users removed.
2144 * fontset.c, xftfont.c: Omit unnecessary static decls.
2145
0699fc18
DA
21462012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
2147
2148 * alloc.c (mark_object): Revert window marking code
2149 since it's unsafe for the Fset_window_configuration.
2150
20ef56db
PE
21512012-09-05 Paul Eggert <eggert@cs.ucla.edu>
2152
2fe28299 2153 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
2154 Be more systematic about preserving errno whenever a signal
2155 handler returns, even if it's not in the main thread. Do this by
2156 renaming signal handlers to distinguish between signal delivery
2157 and signal handling. All uses changed.
2158 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
2159 * data.c (deliver_arith_signal): Rename from arith_error.
2160 * dispnew.c (deliver_window_change_signal): Rename from
2161 window_change_signal.
2162 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
2163 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
2164 * keyboard.c (deliver_input_available_signal): Rename from
2165 input_available_signal.
2166 (deliver_user_signal): Rename from handle_user_signal.
2167 (deliver_interrupt_signal): Rename from interrupt_signal.
2168 * process.c (deliver_pipe_signal): Rename from send_process_trap.
2169 (deliver_child_signal): Rename from sigchld_handler.
2170 * atimer.c (handle_alarm_signal):
2171 * data.c (handle_arith_signal):
2172 * dispnew.c (handle_window_change_signal):
2173 * emacs.c (handle_fatal_signal, handle_danger_signal):
2174 * keyboard.c (handle_input_available_signal):
2175 * keyboard.c (handle_user_signal, handle_interrupt_signal):
2176 * process.c (handle_pipe_signal, handle_child_signal):
2177 New functions, with the actual signal-handling code taken from the
2178 original respective signal handlers, sans the sporadic attempts to
2179 preserve errno, since that's now done by handle_on_main_thread.
2180 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
2181 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
2182 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2183 Move to sysdep.c.
2184 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2185 Move initialization of main_thread to sysdep.c's init_signals.
2186 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
2187 our usage, and simplifies the mainline code.
2188 (record_child_status_change): New static function, as a helper
2189 for handle_child_signal, and with most of the old child handler's
2190 contents.
2191 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
2192 (handle_child_signal): Use the above.
2193 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
2194 Moved here from emacs.c.
2195 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
2196 code moved here from emacs.c's main function.
2197 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
2198 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
2199 This lets callers save and restore errno properly.
20ef56db 2200
e3ccf108
DA
22012012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2202
2203 Remove redundant or unused things here and there.
2204 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
2205 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
2206 * editfns.c (Fcompare_buffer_substrings): Likewise.
2207 * frame.h (struct terminal, struct font_driver_list):
2208 Remove redundant declarations.
2209 * window.h (Qleft, Qright): Likewise.
2210
697e1e39
DA
22112012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2212
2213 Do not mark objects from deleted buffers, windows and frames.
2214 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
2215 (mark_object): Likewise for windows and frames.
2216
c1ca42ca
DA
22172012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
2218
2219 * alloc.c (valid_lisp_object_p): Treat killed buffers,
2220 buffer_defaults and buffer_local_symbols as valid objects.
2221 Return special value to denote them.
2222
014d93be
PE
22232012-09-05 Paul Eggert <eggert@cs.ucla.edu>
2224
f75d7a91
PE
2225 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
2226 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
2227 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
2228 (file_name_absolute_p, Fsubstitute_in_file_name):
2229 (check_executable, check_writable, Ffile_accessible_directory_p)
2230 (Fset_file_selinux_context, Fdefault_file_modes)
2231 (Finsert_file_contents, choose_write_coding_system)
2232 (Fwrite_region, build_annotations, a_write, e_write)
2233 (Fdo_auto_save):
2234 * filelock.c (boot_time_initialized, get_boot_time)
2235 (get_boot_time_1, lock_file_1, within_one_second):
2236 * floatfns.c (in_float):
2237 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
2238 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
2239 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
2240 * lisp.h (struct Lisp_Hash_Table.cmpfn):
2241 * window.c (compare_window_configurations):
2242 Use bool for booleans.
2243 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
2244 (Fdefault_file_modes): Now mode_t, not int, for modes.
2245 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
2246 (internal_delete_file): Now returns void, not a (boolean) int,
2247 since nobody was looking at the return value.
2248 * lisp.h, window.h: Adjust to above API changes.
2249
014d93be
PE
2250 * xdisp.c (set_message): Simplify and reindent last change.
2251
776f29e1
JB
22522012-09-05 Juanma Barranquero <lekktu@gmail.com>
2253
2254 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
2255
7f7e0167
LI
22562012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
2257
2258 * eval.c (call_debugger): Make the function non-static so that we
2259 can call it from set_message.
2260
2261 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
2262 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
2263
cf29dd84
PE
22642012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2265
2266 Give more-useful info on a fatal error (Bug#12328).
2267 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
2268 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
2269 of doing the work ourselves.
2270 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
2271 do most of the work.
2272 (fatal_error_backtrace): New function, taken from the guts
2273 of the old fatal_error_signal, but with a new option to output
2274 a backtrace.
2275 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
2276 info about the signal than just its number.
2277 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
2278 * sysdep.c: Include <execinfo.h>
2279 (emacs_backtrace): New function, taken partly from the previous
2280 code of the 'die' function.
2281 (emacs_abort): Call fatal_error_backtrace rather than abort.
2282
972debf2
SM
22832012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
2284
2285 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
2286 eager (load-time) macro-expansion.
2287 * lisp.mk (lisp): Add macroexp.
2288
1088b922
PE
22892012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2290
2291 Simplify redefinition of 'abort' (Bug#12316).
2292 Do not try to redefine the 'abort' function. Instead, redo
2293 the code so that it calls 'emacs_abort' rather than 'abort'.
2294 This removes the need for the NO_ABORT configure-time macro
2295 and makes it easier to change the abort code to do a backtrace.
2296 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
2297 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
2298 Remove; sysdep.c's emacs_abort now takes its place.
2299 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
2300 'abort' changed to use 'emacs_abort'.
2301 * msdos.c (dos_abort) [defined abort]: Remove; not used.
2302 (abort) [!defined abort]: Rename to ...
2303 (emacs_abort): ... new name.
2304 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
2305 the place of the old 'abort' in emacs.c.
2306 * w32.c, w32fns.c (abort): Do not #undef.
2307 * w32.c (emacs_abort): Rename from w32_abort.
2308
30934d33
EZ
23092012-09-04 Eli Zaretskii <eliz@gnu.org>
2310
2311 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
2312 offsets[j].dv, since the y axis of the screen coordinates points
2313 down, while the y axis of the font definition coordinates points
2314 up. This fixes display of Arabic diacritics such as KASRA and
2315 KASRATAN. (Bug#11860)
2316
af26b72c
PE
23172012-09-04 Paul Eggert <eggert@cs.ucla.edu>
2318
2319 Be more systematic about _setjmp vs setjmp.
2320 * alloc.c (test_setjmp, mark_stack):
2321 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
2322 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
2323 (png_load, my_error_exit, jpeg_load):
2324 * process.c (send_process_trap, send_process):
2325 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
2326 The underscored versions are up to 30x faster on some hosts.
2327 Formerly, the code used setjmp+longjmp sometimes and
2328 _setjmp+_longjmp at other times, with no particular reason to
2329 prefer setjmp+longjmp.
2330
26d4541d
PE
23312012-09-03 Paul Eggert <eggert@cs.ucla.edu>
2332
d42f4f0f 2333 Fix minor problem found by static checking.
26d4541d 2334 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 2335
c5e28e39
MR
23362012-09-03 Martin Rudalics <rudalics@gmx.at>
2337
2338 * buffer.c (Fdelete_all_overlays): New function.
2339
3eab3ca9
CY
23402012-09-03 Chong Yidong <cyd@gnu.org>
2341
2342 * gtkutil.c: Add extern decl for Qxft.
2343
c04889f8
PE
23442012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2345
1882aa38
PE
2346 * emacs.c, eval.c: Use bool for boolean.
2347 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
2348 (malloc_using_checking) [DOUG_LEA_MALLOC]:
2349 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
2350 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
2351 (main, decode_env_path, Fdaemon_initialized):
2352 * eval.c (call_debugger, Finteractive_p, interactive_p):
2353 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
2354 (maybe_call_debugger, Fbacktrace):
2355 * process.c (read_process_output, exec_sentinel):
2356 Use bool for booleans.
2357 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
2358 All callers changed.
2359 * eval.c (interactive_p): Omit always-true boolean argument
2360 EXCLUDE_SUBRS_P. All callers changed.
2361 * dispextern.h, lisp.h: Reflect above API changes.
2362 * firstfile.c (dummy): Use the address of 'main', whose signature
2363 won't change, instead of the address of 'initialize', whose
2364 signature just changed from int to bool.
2365 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
2366 * msdos.c (fatal_error_in_progress): ... from here.
2367 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
2368 of incrementing it.
2369 (redisplay_internal, unwind_redisplay): Simply clear
2370 REDISPLAYING_P when unwinding, instead of saving its previous,
2371 always-false value and then restoring it.
2372
a411ac43
PE
2373 Clean up some extern decls.
2374 Mostly, this hoists extern decls out of .c files and into .h files.
2375 That way, we're more likely to catch errors if the interfaces change.
2376 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
2377 declare xg_mark_data.
2378 * dispextern.h (x_frame_parm_handlers):
2379 * font.h (Qxft):
2380 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
2381 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
2382 (Qultra_bold, Qoblique, Qitalic):
2383 Move extern decl here from .c file.
2384 * alloc.c (xg_mark_data) [USE_GTK]:
2385 * doc.c (Qclosure):
2386 * eval.c (Qlexical_binding):
2387 * fns.c (time) [!HAVE_UNISTD_H]:
2388 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
2389 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
2390 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
2391 * lread.c (Qinternal_interpreter_environment):
2392 * minibuf.c (Qbuffer):
2393 * process.c (QCfamily, QCfilter):
2394 * widget.c (free_frame_faces):
2395 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
2396 * xfont.c (x_clear_errors):
2397 * xterm.c (x_frame_parm_handlers):
2398 Remove now-redundant extern decls.
2399 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
2400 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
2401 Now static.
2402 * xfaces.c: Remove unnecessary static decls.
2403 * xterm.c (updating_frame): Remove decl of nonexistent object.
2404
c04889f8
PE
2405 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
2406 when building globals.h, as the objects that are not built on
2407 this host are not needed to compile C files on this host.
2408
8b339673
JD
24092012-09-02 Jan Djärv <jan.h.d@swipnet.se>
2410
2411 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
2412
2413 * frame.h: Add missing prototype for x_wm_set_size_hint.
2414
a08d4ba7
PE
24152012-09-02 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
2418 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
2419 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
2420 (Fsubstitute_command_keys):
2421 * editfns.c (region_limit, find_field, Fconstrain_to_field)
2422 (save_excursion_save, save_excursion_restore)
2423 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
2424 (format_time_string, general_insert_function)
2425 (make_buffer_string, make_buffer_string_both)
2426 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
2427 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
2428 (copy_text, insert_1, insert_1_both, insert_from_string)
2429 (insert_from_string_before_markers, insert_from_string_1)
2430 (insert_from_buffer, insert_from_buffer_1, replace_range)
2431 (replace_range_2, del_range_1, del_range_byte, del_range_both)
2432 (del_range_2, modify_region):
2433 * intervals.c (intervals_equal, balance_possible_root_interval)
2434 (adjust_intervals_for_insertion, merge_properties_sticky)
2435 (graft_intervals_into_buffer, lookup_char_property)
2436 (adjust_for_invis_intang, set_point_both)
2437 (get_property_and_range, compare_string_intervals)
2438 (set_intervals_multibyte_1, set_intervals_multibyte):
2439 * keyboard.c (decode_timer):
2440 Use bool for boolean.
2441 * intervals.h, lisp.h, systime.h: Reflect above API changes.
2442 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
2443
48c948de
CY
24442012-09-02 Chong Yidong <cyd@gnu.org>
2445
2446 * keymap.c (push_key_description): Print M-TAB as C-M-i
2447 (Bug#11758).
2448
6c49a40b
JB
24492012-09-02 Juanma Barranquero <lekktu@gmail.com>
2450
2451 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
2452 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
2453 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
2454 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
2455 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
2456 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
2457 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2458
4dfbd238
EZ
24592012-09-01 Eli Zaretskii <eliz@gnu.org>
2460
7e510e28
EZ
2461 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
2462 more than one grapheme cluster passed to the shaper: compute the
2463 offset adjustment values separately for each cluster. (Bug#11860)
2464
4dfbd238
EZ
2465 * image.c: Restore mistakenly removed inclusion of w32.h. Without
2466 it, GCC doesn't see prototypes of w32_delayed_load, and complains
2467 about implicit conversions from integer to pointer.
2468
86571ae0
DC
24692012-09-01 Daniel Colascione <dancol@dancol.org>
2470
2471 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
2472 system used too early.
2473
0e23ef9d
PE
24742012-09-01 Paul Eggert <eggert@cs.ucla.edu>
2475
2476 Better seed support for (random).
2477 * emacs.c (main): Call init_random.
2478 * fns.c (Frandom): Set the seed from a string argument, if given.
2479 Remove long-obsolete Gentzel cruft.
2480 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
2481 (init_random): New function.
2482
17a2cbbd
DC
24832012-09-01 Daniel Colascione <dancol@dancol.org>
2484
2485 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
2486 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
2487 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
2488 x_wm_set_size_hint, x_query_colors, x_real_positions,
2489 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
2490 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
2491 all of which have been moved to common code.
2492
2493 * xfaces.c: Include TERM_HEADER instead of listing all possible
2494 window-system headers.
2495
2496 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
2497 to match header.
2498
2499 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
2500 directly accessing frame internals.
2501
f18cbb28 2502 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
2503 globals_of_w32font.
2504
2505 * process.c: Include TERM_HEADER instead of listing all possible
2506 window-system headers.
2507
3a880af4
SM
2508 * nsterm.h: Remove declarations now in frame.h.
2509 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
2510
2511 * menu.c: Include TERM_HEADER instead of listing all possible
2512 window-system headers.
2513
2514 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
2515 window system.
2516
2517 * keyboard.c: Include TERM_HEADER instead of listing all possible
2518 window-system headers.
2519
2520 * image.c: Include TERM_HEADER instead of listing all possible
2521 window-system headers. Declare Vlibrary_cache when compiling for
2522 Windows.
2523
2524 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
2525 window system declarations.
2526
2527 * frame.h: Move common functions here: set_frame_menubar,
2528 x_set_window_size, x_sync, x_get_focus_frame,
2529 x_set_mouse_position, x_set_mouse_pixel_position,
2530 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
2531 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
2532 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
2533 x_activate_menubar, x_real_positions, x_bitmap_icon,
2534 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
2535 and x_query_colors.
2536
2537 * frame.c: Include TERM_HEADER instead of listing all possible
2538 window-system headers.
2539
2540 * font.c: Include TERM_HEADER instead of listing all possible
2541 window-system headers.
2542
2543 * emacs.c: Include TERM_HEADER.
2544
f18cbb28
EZ
2545 * dispnew.c: Include TERM_HEADER instead of listing all possible
2546 window-system headers.
17a2cbbd 2547
f18cbb28 2548 * ccl.h: Include character.h.
17a2cbbd
DC
2549
2550 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
2551 the current window system; include in list of objects to link into
2552 Emacs.
2553
c650a5de
DA
25542012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2555
2556 Remove mark_ttys function and fix tty_display_info initialization.
2557 * lisp.h (mark_ttys): Remove prototype.
2558 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
2559 to mark_ttys because all possible values of 'top_frame' slot are
2560 the frames which are reachable from Vframe_list.
2561 * term.c (mark_ttys): Remove.
2562 (init_tty): Safely initialize 'top_frame' slot with Qnil.
2563
4e0f6479
DA
25642012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2565
2566 Change struct frame bitfields from unsigned char to unsigned.
2567 * frame.h (struct frame): Change type of 'display_preempted',
2568 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
2569 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
2570 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
2571 bitfields from unsigned char to unsigned.
2572
8b96a52c
DA
25732012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2574
2575 Remove unused member of struct x_output and struct w32_output.
2576 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
2577 * w32term.h (struct w32_output): Likewise.
2578
b4444c8a
JD
25792012-08-30 Jan Djärv <jan.h.d@swipnet.se>
2580
2581 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
2582 does not become zero (Bug#12234).
2583
b98521db
PE
25842012-08-30 Paul Eggert <eggert@cs.ucla.edu>
2585
2586 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
2587 for GCC 4.7.1 x86-64.
2588
31d02438
GM
25892012-08-30 Glenn Morris <rgm@gnu.org>
2590
2591 * lread.c (init_lread): For out-of-tree builds, only add the
2592 source directory's site-lisp dir to the load-path if it exists,
2593 consistent with in-tree builds. (Bug#12302)
2594
7f8941d8
JD
25952012-08-28 Jan Djärv <jan.h.d@swipnet.se>
2596
2597 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 2598 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
2599 (windowShouldClose:): Set window_closed.
2600 (dealloc): New member, free button_values.
fc0c31f8
JB
2601 (process_dialog:): Make member function. Remove window argument,
2602 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
2603 in button_values.
2604 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 2605 with tag. Remove return self, declare return value as void.
7f8941d8
JD
2606 (addString:row:): Remove return self, declare return value as void.
2607 (addSplit): Remove return self, declare return value as void.
2608 (clicked:): Remove return self, declare return value as void.
fc0c31f8 2609 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
2610 (initFromContents:isQuestion:): Adjust call to process_dialog.
2611 Code formatting change.
2612 (timeout_handler:): Set timer_fired to YES.
2613 (runDialogAt:): Set timer_fired to NO.
2614 Handle click on close button as quit.
2615
2616 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
2617 Add window_closed and button_values. Add void as return value for
2618 add(Button|String|Split). addButton takes int instead of Lisp_Object.
2619 Add process_dialog as new member.
2620
eada0861 26212012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 2622
eada0861
GM
2623 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
2624 is not one of the heaps we manage. (Bug#12242)
2625
26262012-08-28 Glenn Morris <rgm@gnu.org>
2627
2628 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
2629
457294dd
MR
26302012-08-28 Martin Rudalics <rudalics@gmx.at>
2631
2632 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
2633 auto-buffer-name window parameter. Install revision of reverted
2634 fix.
457294dd 2635
4f2daf31
DA
26362012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2637
2638 Do not allow to set major mode for a dead buffer.
2639 * buffer.c (Fset_buffer_major_mode): Signal an error
2640 if the buffer is dead.
2641 (Fother_buffer, other_buffer_safely): Remove redundant
2642 nested declaration.
2643
66322887
DA
26442012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2645
2646 Always use set_buffer_if_live to restore original buffer at unwind.
2647 * buffer.h (record_unwind_current_buffer): New function.
2648 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
2649 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
2650 * undo.c, window.c: Adjust users.
2651 * buffer.c (set_buffer_if_live): Fix comment.
2652
a3d794a1
DA
26532012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
2654
2655 Fix usage of set_buffer_internal.
2656 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
2657 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
2658 * coding.c (decode_coding): Omit redundant test.
2659 * fileio.c (decide_coding_unwind): Likewise.
2660 * fns.c (secure_hash): Likewise.
2661 * insdel.c (modify_region): Likewise.
2662 * keyboard.c (command_loop_1): Likewise.
2663 * print.c (PRINTFINISH): Likewise.
2664 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
2665
59ea14cd
PE
26662012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 * dispnew.c: Use bool for boolean.
2669 (frame_garbaged, display_completed, delayed_size_change)
2670 (fonts_changed_p, add_window_display_history)
2671 (add_frame_display_history, verify_row_hash)
2672 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
2673 (row_equal_p, realloc_glyph_pool)
2674 (allocate_matrices_for_frame_redisplay)
2675 (showing_window_margins_p)
2676 (adjust_frame_glyphs_for_frame_redisplay)
2677 (build_frame_matrix_from_leaf_window, make_current)
2678 (mirrored_line_dance, mirror_line_dance, update_frame)
2679 (update_window_tree, update_single_window)
2680 (check_current_matrix_flags, update_window, update_text_area)
2681 (update_window_line, set_window_update_flags, scrolling_window)
2682 (update_frame_1, scrolling, buffer_posn_from_coords)
2683 (do_pending_window_change, change_frame_size)
2684 (change_frame_size_1, sit_for):
2685 Use bool for boolean.
2686 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
2687 and remove last int (actually boolean) argument, which was always 0.
2688 All callers changed.
2689 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
2690 * dispextern.h (struct composition_it): Use bool for boolean.
2691 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
2692 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
2693 * dired.c (file_name_completion):
2694 Use bool for boolean. (This was missed in an earlier change.)
2695
95072a94
MR
26962012-08-27 Martin Rudalics <rudalics@gmx.at>
2697
2698 * window.c (Fset_window_configuration): Revert first part of
2699 last change.
2700
0f19feff
JD
27012012-08-27 Jan Djärv <jan.h.d@swipnet.se>
2702
2703 * nsterm.h (NSPanel): New class variable dialog_return.
2704
3a880af4
SM
2705 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
2706 Initialize dialog_return.
0f19feff
JD
2707 (windowShouldClose:): Use stop instead of stopModalWithCode.
2708 (clicked:): Ditto, and also set dialog_return (Bug#12258).
2709 (timeout_handler:): Use stop instead of abortModal. Send a dummy
2710 event.
2711 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
2712 modal loop returns.
2713
f10fe38f
PE
27142012-08-27 Paul Eggert <eggert@cs.ucla.edu>
2715
de1339b0
PE
2716 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
2717 * composite.c (find_composition, composition_gstring_p)
2718 (composition_reseat_it, find_automatic_composition):
2719 * data.c (let_shadows_buffer_binding_p)
2720 (let_shadows_global_binding_p, set_internal, make_blv)
2721 (Fmake_variable_buffer_local, Fmake_local_variable)
2722 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
2723 (cons_to_signed, arith_driver):
2724 * dbusbind.c (xd_in_read_queued_messages):
2725 * dired.c (directory_files_internal, file_name_completion):
2726 Use bool for booleans.
2727 * dired.c (file_name_completion):
2728 * process.h (fd_callback):
2729 Omit int (actually boolean) argument. It wasn't being used.
2730 All uses changed.
2731 * composite.h, lisp.h: Reflect above API changes.
2732
f10fe38f
PE
2733 * cmds.c, coding.c: Use bool for booleans.
2734 * cmds.c (move_point, Fself_insert_command):
2735 * coding.h (struct composition status, struct coding_system):
2736 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
2737 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
2738 (emacs_mule_char, decode_coding_emacs_mule)
2739 (encode_coding_emacs_mule, detect_coding_iso_2022)
2740 (decode_coding_iso_2022, encode_invocation_designation)
2741 (encode_designation_at_bol, encode_coding_iso_2022)
2742 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
2743 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
2744 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
2745 (encode_coding_raw_text, detect_coding_charset)
2746 (decode_coding_charset, encode_coding_charset, detect_eol)
2747 (detect_coding, get_translation_table, produce_chars)
2748 (consume_chars, reused_workbuf_in_use)
2749 (make_conversion_work_buffer, code_conversion_save)
2750 (decode_coding_object, encode_coding_object)
2751 (detect_coding_system, char_encodable_p)
2752 (Funencodable_char_position, code_convert_region)
2753 (code_convert_string, code_convert_string_norecord)
2754 (Fset_coding_system_priority):
2755 * fileio.c (Finsert_file_contents):
2756 Use bool for booleans.
2757 * coding.h, lisp.h: Reflect above API changes.
2758 * coding.c: Remove unnecessary static function decls.
2759 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
2760 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
2761 not a boolean 'int', since callers never look at the return value.
2762 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
2763 * coding.h (decoding_buffer_size, encoding_buffer_size)
2764 (emacs_mule_string_char): Remove unused extern decls.
2765 (struct iso_2022_spec, struct coding_system):
2766 Use 'unsigned int : 1' for boolean fields, since there's more than one.
2767 (struct emacs_mule_spec): Remove unused field 'full_support'.
2768 All initializations removed.
2769 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
2770
5474c384
DA
27712012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2772
f10fe38f 2773 Fix spare memory change (Bug#12286).
5474c384
DA
2774 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
2775 (valid_lisp_object_p): Likewise.
2776
c4b6914d
MR
27772012-08-27 Martin Rudalics <rudalics@gmx.at>
2778
2779 * window.c (Fset_window_configuration): Record any window's old
2780 buffer if it's replaced (see Bug#8789). If the new current
2781 buffer doesn't appear in the selected window, go to its old
2782 point (Bug#12208).
2783
35aaa1ea
DA
27842012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
2785
2786 Special MEM_TYPE_SPARE to denote reserved memory.
2787 * alloc.c (enum mem_type): New memory type.
2788 (refill_memory_reserve): Use new type for spare memory.
2789 This prevents live_cons_p and live_string_p from incorrect
2790 detection of uninitialized objects from spare memory as live.
2791
6af64513
PE
27922012-08-26 Paul Eggert <eggert@cs.ucla.edu>
2793
8b2e00a3
PE
2794 Spelling fixes.
2795 * Makefile.in (.PHONY): versioclean -> versionclean.
2796
b52d6985
PE
2797 Remove unused external symbols.
2798 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
2799 * window.c (Qwindow_valid_p, decode_valid_window):
2800 Now static, not extern.
2801 * data.c (Qinterval): Remove; unused.
2802 (syms_of_data): Do not define 'interval'.
2803 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
2804 * window.h (decode_valid_window):
2805 Remove decls.
2806
d5172d4f
PE
2807 * character.c, charset.c, chartab.c: Use bool for booleans.
2808 * character.c (lisp_string_width, string_count_byte8)
2809 (string_escape_byte8):
2810 * charset.c (charset_map_loaded, load_charset_map, read_hex):
2811 (load_charset_map_from_file, map_charset_chars)
2812 (Fdefine_charset_internal, define_charset_internal)
2813 (Fdeclare_equiv_charset, find_charsets_in_text)
2814 (Ffind_charset_region, char_charset, Fiso_charset):
2815 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
2816 (sub_char_table_set, sub_char_table_set_range)
2817 (char_table_set_range, optimize_sub_char_table)
2818 (map_sub_char_table):
2819 Use bool for boolean.
2820 * character.c (str_to_unibyte): Omit last boolean argument; it was
2821 always 0. All callers changed.
2822 * character.h, charset.h: Adjust to match previous changes.
2823 * character.h (char_printable_p): Remove decl of nonexistent function.
2824 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
2825 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
2826 are all boolean, so make them single-bit bitfields.
2827
6af64513
PE
2828 * lisp.h (ASET): Remove attempt to detect side effects.
2829 It was meant to be temporary and it often doesn't work,
2830 because when IDX has side effects the behavior of IDX==IDX
2831 is undefined. See Stefan Monnier in
2832 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
2833
e1f29348
BR
28342012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2835
2836 * lisp.h (functionp): New function (extracted from Ffunctionp).
2837 (FUNCTIONP): Use it.
2838 * eval.c (Ffunctionp): Use it.
2839
17c05d74
PE
28402012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2841
0f46bc75
PE
2842 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
2843 as that's faster and simpler than static storage. Don't bother
2844 with the g_main_context_query overhead if g_main_context_pending
2845 says no events are pending.
2846 (gfds, gfds_size): Remove these static vars.
2847 (xgselect_initialize): Remove; no longer needed.
2848 All uses and decls removed.
2849
ee4c0f69
PE
2850 * emacs.c (fatal_error_signal_hook): Remove.
2851 All uses removed. This leftover from old code was always 0.
2852
17c05d74
PE
2853 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
2854 * casefiddle.c (casify_object, casify_region):
2855 * casetab.c (set_case_table):
2856 * category.c, category.h (word_boundary_p):
2857 * category.h (CHAR_HAS_CATEGORY):
2858 Use bool for booleans, instead of int.
2859
391ceac5
EZ
28602012-08-25 Eli Zaretskii <eliz@gnu.org>
2861
2862 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
2863
2f221583
PE
28642012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2865
f4a681b0
PE
2866 On assertion failure, print backtrace if available.
2867 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
2868 (die) [ENABLE_CHECKING]: Print a backtrace if available.
2869 * Makefile.in (LIB_EXECINFO): New macro.
2870 (LIBES): Use it.
2871
2f221583
PE
2872 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
2873 * bytecode.c (exec_byte_code):
2874 * callint.c (check_mark, Fcall_interactively):
2875 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
2876 (getenv_internal, sync_process_alive, call_process_exited):
2877 * lisp.h (USE_SAFE_ALLOCA):
2878 Use bool for booleans, instead of int.
2879 * lisp.h, process.h: Adjust prototypes to match above changes.
2880 * callint.c (Fcall_interactively): Don't assume the mark's
2881 offset fits in 'int'.
2882
37ef52bb
PE
28832012-08-24 Paul Eggert <eggert@cs.ucla.edu>
2884
2885 * buffer.c, buffer.h: Use bool for boolean.
2886 * buffer.c (reset_buffer_local_variables)
2887 (buffer_lisp_local_variables, Fset_buffer_modified_p)
2888 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
2889 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
2890 (overlay_touches_p, overlay_strings, Foverlay_put)
2891 (report_overlay_modification, call_overlay_mod_hooks):
2892 (mmap_enlarge, mmap_set_vars):
2893 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
2894 Use bool for booleans, instead of int.
2895 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
2896 since the 1-or-0 return value is always ignored anyway.
2897 (mmap_initialized_p):
2898 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
2899 * buffer.h, lisp.h: Adjust prototypes to match above changes.
2900
2cc21167
PE
29012012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2902
2903 * bidi.c: Use bool for boolean.
2904 This is a bit more readable, and makes the text segment of bidi.o
2905 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
2906 Presumably it's faster too.
2907 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
2908 Now bool.
2909 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2910 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
2911 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
2912 (bidi_explicit_dir_char, bidi_level_of_next_char)
2913 (bidi_find_other_level_edge, bidi_move_to_visually_next):
2914 Use bool for booleans, instead of int.
2915 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2916 (bidi_unshelve_cache): Adjust decls to match code.
2917
7db4ddf4
MR
29182012-08-23 Martin Rudalics <rudalics@gmx.at>
2919
2920 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2921 argument.
2922
b1bb8011
PE
29232012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2924
2925 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2926 * atimer.h: Include <stdbool.h>.
2927
ff687885
DN
29282012-08-22 Dan Nicolaescu <dann@gnu.org>
2929
2930 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2931 compile time tests instead of run time tests on systems that do
2932 not use them.
2933 (FRAME_MAC_P): Remove leftover from deleted code.
2934 * frame.c (syms_of_frame): Remove leftover from deleted code.
2935
4ce7a138
JD
29362012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2937
2938 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2939
d733ec6d
PE
29402012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2941
2942 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2943 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2944 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2945 (fontset_add): Return void, for FONTSET_ADD.
2946
d0d2d26f
PE
29472012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2948
fce31d69
PE
2949 * alloc.c: Use bool for booleans.
2950 (gc_in_progress, abort_on_gc)
2951 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2952 (dont_register_blocks) [GC_MALLOC_CHECK]:
2953 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2954 (check_string_bytes, make_specified_string, memory_full)
2955 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2956 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2957 (mark_stack, valid_pointer_p, make_pure_string)
2958 (Fgarbage_collect, survives_gc_p, gc_sweep):
2959 Use bool for booleans, instead of int.
2960 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2961 Remove unused local.
2962 * alloc.c (PURE_POINTER_P):
2963 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2964 * editfns.c (Fformat):
2965 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2966 (Fdo_auto_save):
2967 * fns.c (sweep_weak_table):
2968 * lisp.h (suppress_checking, push_message, survives_gc_p)
2969 (make_pure_string, gc_in_progress, abort_on_gc):
2970 * lread.c (readchar, read1):
2971 * print.c (Fprin1_to_string):
2972 * xdisp.c (push_message):
2973 Use bool for booleans affected directly or indirectly by
2974 alloc.c's changes.
2975
d0d2d26f
PE
2976 Make recently-introduced setters macros.
2977 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2978 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2979 (set_fontset_default, set_fontset_fallback): Rename from their
2980 upper-case counterparts, and make them functions rather than macros.
2981 This is more consistent with the other recently-introduced setters.
2982 These don't need to be inline, since they're local.
2983
d18e2bb6
JD
29842012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2985
2986 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2987 the loop (Bug#12247).
2988
1b9d9d16
PE
29892012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * lisp.h (vcopy): Use memcpy rather than our own loop.
2992 This fixes a performance regression introduced by the recent
2993 addition of vcopy. This means 'vcopy' will need to be modified
2994 for a copying collector, but that's OK. Also, tighten the
2995 checking in the assertion.
2996
b2f09701
EZ
29972012-08-21 Eli Zaretskii <eliz@gnu.org>
2998
2999 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
3000 components for RTL text (Bug#11860). Adjust X-OFFSET of each
3001 non-base glyph for the width of the base character, according to
e1f29348
BR
3002 what x_draw_composite_glyph_string_foreground expects.
3003 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
3004 expectations, to produce correct width of the composed character.
3005 Reverse the sign of the DU offset produced by ScriptPlace.
3006
9b994fed
PE
30072012-08-21 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
3010
086ca913
DA
30112012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
3012
3013 Avoid direct writes to contents member of struct Lisp_Vector.
3014 * lisp.h (vcopy): New function to copy data into vector.
3015 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
3016 * fns.c (Ffillarray): Use ASET.
3017 * keyboard.c (timer_check_2): Use AREF and ASET.
3018 (append_tool_bar_item, Frecent_keys): Use vcopy.
3019 * lread.c (read_vector): Use ASET.
3020 * msdos.c (Frecent_doskeys): Use vcopy.
3021 * xface.c (Finternal_copy_lisp_face): Use vcopy.
3022 (Finternal_merge_in_global_face): Use ASET and vcopy.
3023 * xfont.c (xfont_list_pattern): Likewise.
3024
5481664a
MR
30252012-08-21 Martin Rudalics <rudalics@gmx.at>
3026
3027 * window.c (Fwindow_point): For the selected window always return
3028 the position of its buffer's point.
3029 (Fset_window_point): For the selected window always go in its
3030 buffer to the specified position.
3031
6d470bdd
DA
30322012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
3033
3034 Setter macros for fontsets.
3035 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
3036 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
3037 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
3038 Adjust users.
3039
24564fe1
GM
30402012-08-20 Glenn Morris <rgm@gnu.org>
3041
3042 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3043 Don't assume that `ln -f' works.
3044
0a05a035
EZ
30452012-08-20 Eli Zaretskii <eliz@gnu.org>
3046
3047 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
3048 and later about non-assignments with no effect. See discussion at
3049 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
3050 details.
3051
e46f2325
DA
30522012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3053
3054 Inline setter functions for Lisp_Objects slots of struct specbinding.
3055 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
3056 Adjust users.
3057
734fbd86
MR
30582012-08-20 Martin Rudalics <rudalics@gmx.at>
3059
3060 * window.c (select_window): Always make selected window's buffer
3061 current.
3062
f1a95992
DA
30632012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3064
3065 Use AREF and ASET for docstrings of category tables.
3066 * category.h (CATEGORY_DOCSTRING): Use AREF.
3067 (SET_CATEGORY_DOCSTRING): Use ASET.
3068 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
3069
e83064be
DA
30702012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3071
3072 Inline setter functions for hash table members.
3073 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
3074 (set_hash_hash, set_hash_index): Rename with _slot suffix.
3075 (set_hash_key_and_value, set_hash_index, set_hash_next)
3076 (set_hash_hash): New functions.
3077 * charset.c, fns.c: Adjust users.
3078
4ce60d2e
DA
30792012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
3080
3081 Inline getter and setter functions for per-buffer values.
3082 * buffer.h (per_buffer_default, set_per_buffer_default)
3083 (per_buffer_value, set_per_buffer_value): New functions.
3084 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
3085 * buffer.c, data.c: Adjust users.
3086
c06c9690
JB
30872012-08-20 Juanma Barranquero <lekktu@gmail.com>
3088
3089 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
3090
32bd4250
PE
30912012-08-19 Paul Eggert <eggert@cs.ucla.edu>
3092
bad03192 3093 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
3094 as gnulib does this if the system doesn't.
3095 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
3096 Remove declaration. MS-Windows declares it on stdlib.h which is
3097 included by conf_post.h.
b69a6d22
PE
3098 * emacs.c (environ) [DOUG_LEA_MALLOC]:
3099 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
3100 * vm-limit.c: Include <unistd.h>, for 'environ'.
3101
22d7feb2
PE
3102 * unexaix.c, unexcoff.c: Include "mem-limits.h".
3103 (start_of_data): Remove decl; mem-limits.h provides it.
3104
32bd4250
PE
3105 * xdisp.c (handle_invisible_prop): Make it a bit faster
3106 and avoid a gcc -Wmaybe-uninitialized diagnostic.
3107
450809af
CY
31082012-08-19 Chong Yidong <cyd@gnu.org>
3109
3110 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
3111 ends (Bug#3874).
3112
9e677988
AS
31132012-08-19 Andreas Schwab <schwab@linux-m68k.org>
3114
6b1319ce
AS
3115 * .gdbinit: Use call instead of set when calling a function in the
3116 inferior.
3117
9e677988
AS
3118 * data.c (set_internal): Don't use set_blv_found.
3119 (Fkill_local_variable): Likewise.
3120
d7191076
AA
31212012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
3122
3123 * nsfont.m (ns_ascii_average_width): Ensure the string
3124 ascii_printable is initialized with a null-terminated character
3125 array. Otherwise, it can contain undesired extra characters.
3126
e757f1c6
PE
31272012-08-18 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 port new setting code to Sun C 5.8 2005/10/13
3130 * chartab.c, lisp.h (char_table_set, char_table_set_range):
3131 Return void, not Lisp_Object. Otherwise, the compiler
3132 complains about (A?B:C) where B is void and C is Lisp_Object
3133 when compiling CHAR_TABLE_SET, due to the recent change to
3134 the API of sub_char_table_set_contents.
3135
a999ce26
CY
31362012-08-18 Chong Yidong <cyd@gnu.org>
3137
3138 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
3139 for the string case (Bug#3874).
3140
3f22b86f
PE
31412012-08-18 Paul Eggert <eggert@cs.ucla.edu>
3142
39eb03f1
PE
3143 * buffer.h (BSET): Remove (Bug#12215).
3144 Replace all uses with calls to new setter functions.
3145 (bset_bidi_paragraph_direction, bset_case_canon_table)
3146 (bset_case_eqv_table, bset_directory, bset_display_count)
3147 (bset_display_time, bset_downcase_table)
3148 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
3149 (bset_last_selected_window, bset_local_var_alist)
3150 (bset_mark_active, bset_point_before_scroll, bset_read_only)
3151 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
3152 (bset_width_table):
3153 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
3154 (bset_auto_fill_function, bset_auto_save_file_format)
3155 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
3156 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
3157 (bset_cache_long_line_scans, bset_case_fold_search)
3158 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
3159 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
3160 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
3161 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
3162 (bset_header_line_format, bset_indicate_buffer_boundaries)
3163 (bset_indicate_empty_lines, bset_invisibility_spec)
3164 (bset_left_fringe_width, bset_major_mode, bset_mark)
3165 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
3166 (bset_name, bset_overwrite_mode, bset_pt_marker)
3167 (bset_right_fringe_width, bset_save_length)
3168 (bset_scroll_bar_width, bset_scroll_down_aggressively)
3169 (bset_scroll_up_aggressively, bset_selective_display)
3170 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
3171 (bset_word_wrap, bset_zv_marker):
3172 * category.c (bset_category_table):
3173 * syntax.c (bset_syntax_table):
3174 New setter functions.
3175
6a09a33b
PE
3176 * process.h (PSET): Remove (Bug#12215).
3177 Replace all uses with calls to new setter functions.
3178 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3179 (PROCESS_INLINE): New macro.
3180 (pset_childp): New setter function.
3181 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
3182 * process.c (PROCESS_INLINE):
3183 Define to EXTERN_INLINE, so that the corresponding functions
3184 are compiled into code.
3185 (pset_buffer, pset_command, pset_decode_coding_system)
3186 (pset_decoding_buf, pset_encode_coding_system)
3187 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
3188 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
3189 (pset_type, pset_write_queue): New setter functions.
3190
e8c17b81
PE
3191 * window.h (WSET): Remove (Bug#12215).
3192 Replace all uses with calls to new setter functions.
3193 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3194 (WINDOW_INLINE): New macro.
3195 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
3196 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
3197 (wset_total_lines, wset_vertical_scroll_bar)
3198 (wset_window_end_pos, wset_window_end_valid)
3199 (wset_window_end_vpos): New setter functions.
3200 * window.c (WINDOW_INLINE):
3201 Define to EXTERN_INLINE, so that the corresponding functions
3202 are compiled into code.
3203 (wset_combination_limit, wset_dedicated, wset_display_table)
3204 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
3205 (wset_new_normal, wset_new_total, wset_next_buffers)
3206 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
3207 (wset_prev_buffers, wset_right_fringe_width)
3208 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
3209 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
3210 (wset_window_parameters):
3211 * xdisp.c (wset_base_line_number, wset_base_line_pos)
3212 (wset_column_number_displayed, wset_region_showing):
3213 New setter functions.
3214
3f22b86f
PE
3215 * termhooks.h (TSET): Remove (Bug#12215).
3216 Replace all uses with calls to new setter functions.
3217 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3218 (TERMHOOKS_INLINE): New macro.
3219 (tset_charset_list, tset_selection_alist): New setter functions.
3220 * terminal.c (TERMHOOKS_INLINE):
3221 Define to EXTERN_INLINE, so that the corresponding functions
3222 are compiled into code.
3223 (tset_param_alist): New setter function.
3224
742af32f
PE
32252012-08-17 Paul Eggert <eggert@cs.ucla.edu>
3226
15dbb4d6
PE
3227 * keyboard.h (KSET): Remove (Bug#12215).
3228 Replace all uses with calls to new setter functions.
3229 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3230 (KEYBOARD_INLINE): New macro.
3231 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
3232 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
3233 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
3234 New setter functions.
3235 * keyboard.c (KEYBOARD_INLINE):
3236 Define to EXTERN_INLINE, so that the corresponding functions
3237 are compiled into code.
3238 (kset_echo_string, kset_kbd_queue)
3239 (kset_keyboard_translate_table, kset_last_prefix_arg)
3240 (kset_last_repeatable_command, kset_local_function_key_map)
3241 (kset_overriding_terminal_local_map, kset_real_last_command)
3242 (kset_system_key_syms): New setter functions.
3243
f00af5b1
PE
3244 * frame.h (FSET): Remove (Bug#12215).
3245 Replace all uses with calls to new setter functions.
3246 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3247 (FRAME_INLINE): New macro.
3248 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
3249 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
3250 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
3251 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
3252 (fset_param_alist, fset_root_window, fset_scroll_bars)
3253 (fset_selected_window, fset_title, fset_tool_bar_items)
3254 (fset_tool_bar_position, fset_tool_bar_window): New functions.
3255 * frame.c (FRAME_INLINE):
3256 Define to EXTERN_INLINE, so that the corresponding functions
3257 are compiled into code.
3258 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
3259
0c94c8d6
PE
3260 A few more naming-convention fixes for getters and setters.
3261 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
3262 and rename from buffer_overlays_set_before.
3263 (set_buffer_overlays_after): Move here from buffer.h, and rename
3264 from buffer_overlays_set_after.
3265 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
3266 All uses changed.
3267 (set_buffer_intervals): Rename from buffer_set_intervals.
3268 * intervals.c (set_interval_object): Move here from intervals.h,
3269 and rename from interval_set_object.
3270 (set_interval_left): Move here from intervals.h, and rename from
3271 interval_set_left.
3272 (set_interval_right): Move here from intervals.h, and rename from
3273 interval_set_right.
3274 (copy_interval_parent): Move here from intervals.h, and rename from
3275 interval_copy_parent.
3276 * intervals.h (set_interval_parent): Rename from interval_set_parent.
3277 (set_interval_plist): Rename from interval_set_plist.
3278 Return void, not Lisp_Object, since no caller uses the result.
3279 * lisp.h (string_intervals): Rename from string_get_intervals.
3280 (set_string_intervals): Rename from string_set_intervals.
3281
34dabdb7
PE
3282 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
3283 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 3284 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
3285 All uses changed. See the end of
3286 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
3287
742af32f
PE
3288 * lisp.h (CSET): Remove (Bug#12215).
3289 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
3290 (set_char_table_purpose): New functions,
3291 replacing CSET. All uses changed. For example, replace
3292 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 3293 "set_char_table_parent (char_table, parent);".
742af32f
PE
3294 The old version was confusing because it used the same name
3295 'parent' for two different things.
3296
a04e2c62
DA
32972012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
3298
3299 Functions to get and set Lisp_Object fields of buffer-local variables.
3300 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
3301 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
3302 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
3303 * data.c, eval.c, frame.c: Adjust users.
3304
383dcbf9
CY
33052012-08-17 Chong Yidong <cyd@gnu.org>
3306
3307 * xfaces.c (merge_face_vectors): If the target font specfies a
3308 font spec, make the font's attributes take precedence over
3309 directly-specified attributes.
3310 (merge_face_ref): Recognize :font.
3311
44386687
DA
33122012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
3313
3314 Do not use memcpy for copying intervals.
3315 * intervals.c (reproduce_interval): New function.
3316 (reproduce_tree, reproduce_tree_obj): Use it.
3317 (reproduce_tree_obj): Remove prototype.
3318
927c7216
PE
33192012-08-17 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * lisp.h (duration_to_sec_usec): Remove unused decl.
3322
93044f7b
AA
33232012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
3324
3325 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
3326 to an allocated instance of NSString, not to the class itself.
3327
9851e4a5
JB
33282012-08-17 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * makefile.w32-in (C_CTYPE_H): New macro.
3331 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
3332 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
3333 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
3334
620f13b0
PE
33352012-08-16 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 Use ASCII tests for character types.
3338 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
3339 * xfns.c, xterm.c:
3340 Don't include <ctype.h>; was not needed.
3341 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
3342 * sysdep.c, xfaces.c:
3343 Include <c-ctype.h> instead of <ctype.h>.
3344 * nsterm.m: Include <c-ctype.h>.
3345 * charset.c (read_hex):
3346 * doc.c (Fsnarf_documentation):
3347 * fileio.c (IS_DRIVE) [WINDOWSNT]:
3348 (DRIVE_LETTER) [DOS_NT]:
3349 (Ffile_name_directory, Fexpand_file_name)
3350 (Fsubstitute_in_file_name):
3351 * font.c (font_parse_xlfd, font_parse_fcname):
3352 * frame.c (x_set_font_backend):
3353 * gtkutil.c (xg_get_font):
3354 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
3355 * nsimage.m (hexchar):
3356 * nsterm.m (ns_xlfd_to_fontname):
3357 * sysdep.c (system_process_attributes):
3358 * xfaces.c (hash_string_case_insensitive):
3359 Use C-locale tests instead of locale-specific tests for character
3360 types, since we want the ASCII interpretation here, not the
3361 interpretation suitable for whatever happens to be the current locale.
3362
52162052
MR
33632012-08-16 Martin Rudalics <rudalics@gmx.at>
3364
3365 Consistently check windows for validity/liveness
3366 (Bug#11984, Bug#12025, Bug#12026).
3367 * lisp.h (CHECK_VALID_WINDOW): New macro.
3368 * window.c (decode_window): Rename to decode_live_window.
3369 (decode_valid_window, Fwindow_valid_p): New functions.
3370 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
3371 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
3372 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
3373 (Fwindow_prev_sibling, Fwindow_combination_limit)
3374 (Fset_window_combination_limit, Fwindow_use_time)
3375 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
3376 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
3377 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
3378 (Fwindow_hscroll, Fset_window_hscroll)
3379 (Fwindow_redisplay_end_trigger)
3380 (Fset_window_redisplay_end_trigger, Fwindow_edges)
3381 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
3382 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3383 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
3384 (Fwindow_end, Fset_window_point, Fset_window_start)
3385 (Fpos_visible_in_window_p, Fwindow_line_height)
3386 (Fwindow_dedicated_p, Fset_window_dedicated_p)
3387 (Fwindow_prev_buffers, Fset_window_prev_buffers)
3388 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
3389 (Fset_window_parameter, Fwindow_display_table)
3390 (Fset_window_display_table, Fdelete_other_windows_internal)
3391 (Fset_window_buffer, Fset_window_new_total)
3392 (Fset_window_new_normal, Fdelete_window_internal)
3393 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
3394 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
3395 (Fwindow_scroll_bars): Check whether argument window is a valid or
3396 live window. Update doc-strings.
3397 (syms_of_window): New symbol Qwindow_valid_p.
3398 * keyboard.c (Fposn_at_x_y): Check whether argument
3399 frame_or_window denotes a valid window.
3400
2751c80f
DA
34012012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3402
3403 Fix previous char table change.
3404 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
3405 * chartab.c (optimize_sub_char_table): Likewise.
3406
032a42c8
CY
34072012-08-16 Chong Yidong <cyd@gnu.org>
3408
a2d19368
CY
3409 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
3410
032a42c8
CY
3411 * xfont.c (xfont_open):
3412 * xftfont.c (xftfont_open): Set the font's max_width field.
3413
3414 * nsfont.m (nsfont_open): Similar to the Xft backend, set
3415 min_width to space_width and average_width to the average over
3416 printable ASCII characters.
3417 (ns_char_width): Code cleanup.
3418 (ns_ascii_average_width): New utility function.
3419
3420 * font.h (struct font): Update comments.
3421
a098c930
DA
34222012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
3423
032a42c8 3424 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
3425 * lisp.h (CSET): New macro.
3426 (char_table_set_extras, char_table_set_contents)
3427 (sub_char_table_set_contents): New function.
3428 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
3429 * syntax.c: Adjust users.
3430
8be3a09c
SM
34312012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
3432
3433 * eval.c (eval_sub): Bind lexical-binding.
3434 * lread.c (Qlexical_binding): Make non-static.
3435
ac4845a6
JD
34362012-08-15 Jan Djärv <jan.h.d@swipnet.se>
3437
ddee6515
JD
3438 * nsmenu.m (popupSession): Remove.
3439 (pop_down_menu): Remove endModalSession.
3440 (timeout_handler:): New method.
3441 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
3442 Call runModalForWindow. Check timer_fired when it returns.
3443 If not set, cancel timer and break out of loop.
3444 Otherwise loop again, with a new timeout.
3445
3446 * nsterm.m: Include fcntl.h if present.
3447 (fd_entry, t_readfds, inNsSelect): Remove.
3448 (select_writefds, select_valid, select_timeout, selfds)
3449 (select_mutex, apploopnr): Add.
3450 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
3451 Otherwise call kbd_buffer_store_event.
3452 (ns_send_appdefined): Remove release of fd_entry.
3453 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
3454 Increment and decrement apploopnr.
3455 (ns_select): If no file descriptors, just do a NSTimer.
3456 Otherwise copy read/write masks and start select thread (fd_handler).
3457 Start main loop and wait for application defined event.
3458 Inform select thread to stop selecting after main loop is exited.
3459 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 3460 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
3461 (fd_handler:): Loop forever, wait for info from the main thread
3462 to either start or stop selecting. When select returns, send
3463 and appdefined event.
3464 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
3465 If not call kbd_buffer_store_event.
3466
3467 * nsterm.h (EmacsApp): fd_handler takes id argument.
3468 (EmacsDialogPanel): Add timer_fired and timeout_handler.
3469
ac4845a6
JD
3470 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
3471
eb424fe3
EZ
34722012-08-15 Eli Zaretskii <eliz@gnu.org>
3473
3474 * region-cache.c (move_cache_gap): Update gap_len using the actual
3475 growth of the boundaries array. Do not change cache_len.
3476 (Bug#12196)
3477
4e6a86c6
DA
34782012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3479
3480 Generalize and cleanup font subsystem checks.
3481 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
3482 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
3483 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 3484
5bf192ca
DA
34852012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
3486
3487 * gtkutil.c (xg_get_font): Use pango_units_to_double.
3488
f2045622
CY
34892012-08-15 Chong Yidong <cyd@gnu.org>
3490
8be3a09c
SM
3491 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
3492 When using the new font chooser, use gtk_font_chooser_get_font_desc to
3493 extract the font descriptor instead of just the font name.
3494 In that case, return a font spec instead of a string.
f2045622
CY
3495 (x_last_font_name): Move to this file from xfns.c.
3496
3497 * xfns.c (Fx_select_font): The return value can also be a font
3498 spec. Move x_last_font_name management to gtkutil.c.
3499
3500 * xfaces.c: Make font weight and style symbols non-static.
3501
7f6feb56
SM
35022012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
3503
3504 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
3505 (bug#12117).
3506
fecbd8ff
SM
35072012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
3508
3509 * alloc.c (Fgarbage_collect): Use plural form consistently.
3510
9b8d5165
EZ
35112012-08-14 Eli Zaretskii <eliz@gnu.org>
3512
3513 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
3514 iteration through the command loop. Fixes a problem whereby mouse
3515 movements are ignored until the first mouse click.
3516
f5d9e83a
PE
35172012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 Use bool, not int, for Lisp booleans.
3520 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
3521 makes Emacs a bit smaller and presumably a bit faster.
3522 * lisp.h: Include <stdbool.h>.
3523 (struct Lisp_Boolfwd, defvar_bool):
3524 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
3525 * regex.c [!emacs]: Include <stdbool.h>.
3526 (false, true): Remove; <stdbool.h> does this for us now.
3527
55802e4a
CY
35282012-08-14 Chong Yidong <cyd@gnu.org>
3529
4abcdac8
CY
3530 * character.c (Fcharacterp): Doc fix (Bug#12076).
3531
3532 * data.c (Findirect_variable): Doc fix (Bug#11040).
3533
55802e4a
CY
3534 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
3535
3536 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 3537 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 3538
8e99d072
BR
35392012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3540
3541 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
3542 (bug#12022).
3543
08908aca
MR
35442012-08-14 Martin Rudalics <rudalics@gmx.at>
3545
3546 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
3547 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
3548 * minibuf.c (choose_minibuf_frame, read_minibuf):
3549 * w32fns.c (x_create_tip_frame):
3550 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
3551 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
3552
56120d6f
PE
35532012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 * intervals.c (offset_intervals): Remove obsolete comment.
3556
67b77c0b
AS
35572012-08-14 Andreas Schwab <schwab@linux-m68k.org>
3558
3559 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
3560
f48b82fd
GR
35612012-08-14 Gergely Risko <gergely@risko.hu>
3562
3563 * coding.c (decode_coding): Record buffer modification before
3564 disabling undo_list (Bug#11773).
3565
fd318b54
DA
35662012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3567
3568 Revert and cleanup some recent overlay changes.
3569 * buffer.h (enum overlay_type): Remove.
3570 (buffer_get_overlays, buffer_set_overlays): Likewise.
3571 (buffer_set_overlays_before, buffer_set_overlays_after):
3572 New function. Adjust users.
3573 (unchain_both): Add eassert.
3574
41a62dd9
DA
35752012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
3576
3577 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
3578
5884c324
PE
35792012-08-14 Paul Eggert <eggert@cs.ucla.edu>
3580
3581 * gtkutil.c (xg_mark_data): Don't assume C99.
3582
ca06f160
JD
35832012-08-13 Jan Djärv <jan.h.d@swipnet.se>
3584
3585 * gtkutil.c (xg_frame_tb_info): New struct.
3586 (TB_INFO_KEY): New define.
3587 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
3588 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
3589 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
3590 if not present.
3591 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 3592 is up to date. Otherwise store new data.
ca06f160
JD
3593 (free_frame_tool_bar): Free xg_frame_tb_info if present.
3594
7864a3f7
DA
35952012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3596
3597 Use KSET for write access to Lisp_Object members of struct kboard.
3598 * keyboard.h (KSET): New macro.
3599 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
3600 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
3601 * xterm.c: Adjust users.
3602
4c31be61
DA
36032012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
3604
3605 Use BSET for write access to Lisp_Object members of struct buffer.
3606 * buffer.h (BSET): New macro.
3607 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
3608 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
3609 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
3610 * window.c, xdisp.c, xfns.c: Adjust users.
3611
14ae4239
BT
36122012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
3613
3614 * lread.c (syms_of_lread): Initialize Vlexical_binding.
3615
32bcadb4
JD
36162012-08-11 Jan Djärv <jan.h.d@swipnet.se>
3617
3d29b2ce 3618 * nsterm.m (not_in_argv): New function.
fc0c31f8 3619 (application:openFile, application:openTempFile:):
3d29b2ce
JD
3620 (application:openFileWithoutUI:, application:openFiles:): Open file
3621 if not_in_argv returns non-zero (bug#12171).
3622
32bcadb4 3623 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
3624 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
3625 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
3626 (xg_get_font_name): Use those functions/macros here.
3627 Reported by Frans Oilinki <moilinki@gmail.com>.
3628
9ff9402d 36292012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
3630
3631 * unexmacosx.c (copy_data_segment): Copy initialized data in
3632 statically linked libraries from input file rather than memory.
3633
db74a5fc
YM
3634 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
3635 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
3636 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
3637
25e65510
GM
36382012-08-10 Glenn Morris <rgm@gnu.org>
3639
3640 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
3641 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
3642
7961135c
DA
36432012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3644
3645 Fix last change to allow compilation with low optimization levels.
3646 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
3647 Reported by Jan Djärv <jan.h.d@swipnet.se>.
3648
42b3a444
DA
36492012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3650
3651 Use common inline syntax in intervals.h.
3652 * intervals.h (INTERVALS_INLINE): New macro.
3653 Change all users from LISP_INLINE.
3654
9fb0c957
DA
36552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3656
3657 Define Qnone once for all platforms.
3658 * frame.c (Qnone): Define here.
3659 (syms_of_frame): DEFSYM it.
3660 * lisp.h (Qnone): New declaration.
3661 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
3662 * xfns.c: Remove duplication. Adjust users.
3663
65e8ee52
DA
36642012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
3665
3666 Remove unused macros from intervals.h.
3667 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
3668 * intervals.c: Adjust comment.
3669
9b855fd6
EZ
36702012-08-10 Eli Zaretskii <eliz@gnu.org>
3671
3672 * w32fns.c <w32_unicode_gui>: New static variable.
3673 (globals_of_w32fns): Initialize it according to os_subtype.
3674 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
3675 testing os_subtype.
3676
39cb9e56 36772012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
3678 Eli Zaretskii <eliz@gnu.org>
3679
3680 Fix bug #10299 with Unicode characters sent by customized
3681 keyboards created by MSKLC.
3682 * w32fns.c (INIT_WINDOW_CLASS): New macro.
3683 (w32_init_class): Use it to initialize the Emacs class with either
3684 ANSI or Unicode API calls.
3685 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
3686 later.
3687 (w32_wnd_proc): If the character code sent by WM_CHAR or
3688 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
3689 original message. Call DefWindowProcW on NT and later.
3690
9374581a
GM
36912012-08-10 Glenn Morris <rgm@gnu.org>
3692
4b94e8cf
GM
3693 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
3694
9374581a
GM
3695 * lisp.h (DIRECTORY_SEP): Let configure set it.
3696
a2752828
DA
36972012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
3698
3699 Use TSET for write access to Lisp_Object slots of struct terminal.
3700 * termhooks.h (TSET): New macro.
3701 * coding.c, terminal.c, xselect.c: Adjust users.
3702
cc92c454
SM
37032012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
3704
3705 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
3706 the failing expression, include them in the error message.
3707 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
3708 * lisp.h (internal_condition_case_n): Update declaration.
3709
4cb3e6b3
DA
37102012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3711
3712 Inline functions to examine and change buffer overlays.
3713 * buffer.c (unchain_both): New function.
3714 * buffer.h (buffer_get_overlays, buffer_set_overlays):
3715 (buffer_has_overlays): New function.
3716 (enum overlay_type): New enum.
3717 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
3718 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
3719
8707c1e5
DA
37202012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3721
3722 Inline functions to examine and change buffer intervals.
3723 * alloc.c (mark_interval_tree): Remove.
3724 (MARK_INTERVAL_TREE): Simplify.
3725 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
3726 * intervals.c (buffer_balance_intervals): New function.
3727 (graft_intervals_into_buffer): Adjust indentation.
3728 (set_intervals_multibyte): Simplify.
3729 * buffer.h (BUF_INTERVALS): Remove.
3730 (buffer_get_intervals, buffer_set_intervals): New function.
3731 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
3732 * intervals.c, textprop.c: Adjust users.
3733
ad8c997f
DA
37342012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3735
3736 Inline functions to examine and change string intervals.
3737 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
3738 (string_get_intervals, string_set_intervals): New function.
3739 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3740 * lread.c, print.c, textprop.c: Adjust users.
3741
32ac3a6b
GM
37422012-08-08 Glenn Morris <rgm@gnu.org>
3743
3744 * lisp.mk (lisp): Remove language/persian.elc.
3745
77c7bcb1
DA
37462012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3747
3748 Cleanup intervals.
3749 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
3750 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
3751 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
3752 Adjust comment. Move under #if 0.
77c7bcb1
DA
3753 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
3754 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
3755
9c08a8d4
DA
37562012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
3757
3758 Check total length of intervals with eassert.
3759 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
3760 * intervals.c: Change all users to eassert.
3761
26d16b35
EZ
37622012-08-07 Eli Zaretskii <eliz@gnu.org>
3763
14ae4239
BT
3764 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
3765 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
3766 INTERNAL_FIELD in Lisp_Cons.
3767
c644523b
DA
37682012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3769
3770 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
3771 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
3772 name since all xname users are fixed long time ago. Do not
3773 use INTERNAL_FIELD.
3774 (set_symbol_name, set_symbol_function, set_symbol_plist):
3775 (set_symbol_next, set_overlay_plist): New function.
3776 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
3777 (struct Lisp_Overlay): Likewise.
3778 (CVAR, MVAR, SVAR): Remove.
3779 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
3780 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
3781 * xterm.c: Adjust users.
3782 * .gdbinit: Change to use name field of struct Lisp_Symbol
3783 where appropriate.
3784
6a3d20cc
DA
37852012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3786
3787 Basic functions to set Lisp_Object and pointer slots of intervals.
3788 * intervals.h (interval_set_parent, interval_set_object):
3789 (interval_set_left, interval_set_right, interval_set_plist):
3790 (interval_copy_parent): New function.
3791 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
3792 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
3793 Adjust indentation.
6a3d20cc
DA
3794 (INTERVAL_SIZE): Remove. Adjust users.
3795 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
3796
4d2b044c
DA
37972012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3798
3799 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
3800 * process.h (PGET): Remove.
3801 (struct Lisp_Process): Do not use INTERNAL_FIELD.
3802 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3803
d3d50620
DA
38042012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3805
3806 Drop WGET and revert read access to Lisp_Objects slots of struct window.
3807 * window.h (WGET): Remove.
3808 (struct window): Do not use INTERNAL_FIELD.
3809 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3810 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3811 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3812 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3813 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3814 Adjust users.
3815
d10a51dc
CY
38162012-08-07 Chong Yidong <cyd@gnu.org>
3817
3818 * window.c (Fwindow_edges, Fwindow_pixel_edges)
3819 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
3820 (Fdelete_window_internal): Signal an error if the window is not on
3821 a live frame (Bug#12025).
3822
e69b0960
DA
38232012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
3824
3825 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
3826 * frame.h (FGET): Remove.
3827 (struct frame): Do not use INTERNAL_FIELD.
3828 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3829 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3830 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3831 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3832
25a20a3a
JB
38332012-08-06 Juanma Barranquero <lekktu@gmail.com>
3834
3835 * w32.c: Silence compiler warnings.
3836 (map_w32_filename): Remove unused variable `is_fat'.
3837 (chase_symlinks): Add parentheses around expression.
3838
1c6f11f4
GM
38392012-08-06 Glenn Morris <rgm@gnu.org>
3840
1db4583a
GM
3841 * sysdep.c: Respect BROKEN_GETWD.
3842
1c6f11f4
GM
3843 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
3844 Let configure handle it.
3845 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
3846
2b90362b
DA
38472012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3848
3849 Use GCALIGNMENT where appropriate.
3850 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
3851 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
3852 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
3853
5f50daf2
EZ
38542012-08-06 Eli Zaretskii <eliz@gnu.org>
3855
14ae4239
BT
3856 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
3857 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 3858
cbcc7007
SM
38592012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
3860
3861 * buffer.h (struct buffer): Revert `indirections' to a simple int;
3862 that should be sufficient for everyone.
3863
4d365fa4
JD
38642012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3865
3866 * keyboard.c (timer_check_2): Add break so timer_check returns next
3867 timeout.
3868
dd86bd82
DA
38692012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3870
3871 Fix Windows build errors introduced after converting to WGET and WSET.
3872 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
3873 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3874
054e1668
JD
38752012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3876
3877 * nsterm.m (ns_frame_rehighlight): Use FSET.
3878
3879 * nsmenu.m (ns_update_menubar): Use FSET.
3880
21238f11
DA
38812012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3882
3883 Separate read and write access to Lisp_Object slots of Lisp_Process.
3884 * process.h (PGET, PSET): New macros similar to AREF and ASET.
3885 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3886
077288cf
DA
38872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3888
3889 Separate read and write access to Lisp_Object slots of struct window.
3890 * window.h (WGET, WSET): New macros similar to AREF and ASET.
3891 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3892 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3893 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3894 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3895 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3896 Adjust users.
3897
71688bd7
DA
38982012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3899
3900 Fix Windows build errors introduced after converting to FGET and FSET.
3901 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
3902 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
3903 (w32_judge_scroll_bars): Change to use FSET.
3904 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3905
f99bac93
DA
39062012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3907
3908 Fix replacement typo.
3909 * window.c (replace_window): Set root_window instead of
3910 selected_window. This fixes a total window subsystem
3911 malfunction reported by Bastien Guerry <bzg@gnu.org>.
3912
8c2a0f2d
GM
39132012-08-06 Glenn Morris <rgm@gnu.org>
3914
3915 * lisp.mk (lisp): Add language/persian.elc.
3916
edd74c35
DA
39172012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3918
3919 Separate read and write access to Lisp_Object slots of struct frame.
3920 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3921 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3922 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3923 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3924 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3925
8671676c
AS
39262012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3927
3928 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3929
663e2b3f
DA
39302012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3931
3932 Generalize common compile-time constants.
3933 * lisp.h (header_size, bool_header_size, word_size): Now here.
3934 (struct Lisp_Vector): Add comment.
3935 (struct Lisp_Bool_Vector): Move up to define handy constants.
3936 (VECSIZE, PSEUDOVECSIZE): Simplify.
3937 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3938 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3939 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3940 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3941 * xfont.c, xmenu.c: Use word_size where appropriate.
3942
d32e47af
LM
39432012-08-05 Lawrence Mitchell <wence@gmx.li>
3944
3945 * search.c (Freplace_match): Treat \? in the replacement text
3946 literally (Bug#8161).
3947
e5d9c0d1
CY
39482012-08-05 Chong Yidong <cyd@gnu.org>
3949
3950 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3951 * frame.c (Vdelete_frame_functions):
3952 * emacs.c (Vkill_emacs_hook): Doc fix.
3953
8da0576b
EZ
39542012-08-04 Eli Zaretskii <eliz@gnu.org>
3955
3956 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3957 --with-x-toolkit=no builds.
3958 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3959
02676e5d
CY
39602012-08-04 Chong Yidong <cyd@gnu.org>
3961
3962 * syntax.c (Fmodify_syntax_entry): Doc fix.
3963
97147da9
EZ
39642012-08-04 Eli Zaretskii <eliz@gnu.org>
3965
76151e2c
EZ
3966 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3967 * w32.c (init_environment): Change the default values of many
3968 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3969 them into environment when they were not already defined.
3970 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3971 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3972 (check_windows_init_file): Now external, not static.
3973 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3974 called when Vload_path is already set up.
3975
3976 * w32.h (check_windows_init_file): Add prototype.
3977
3978 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3979 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3980 compatibility with Posix platforms.
3981 (main): Move the call to check_windows_init_file to here from
3982 w32.c.
3983 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3984 any, in the DEFALT argument into the root of the Emacs build or
3985 installation tree, as appropriate.
3986
3987 * callproc.c (init_callproc_1): Call decode_env_path instead of
3988 doing its equivalent by hand.
3989 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3990 the code that sets Vexec_path run on MS-Windows.
3991
3992 * lread.c (init_lread): Add comments to #ifdef's.
3993
97147da9
EZ
3994 * msdos.c (dos_set_window_size, IT_update_begin)
3995 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3996 instead of direct references.
3997
185ee146
PE
39982012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3999
4000 Export DEFAULT_REHASH_* to GDB.
4001 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
4002 Now constants, not macros.
4003
8834c57a
PE
40042012-08-03 Paul Eggert <eggert@cs.ucla.edu>
4005
98c6f1e3
PE
4006 Remove unnecessary casts involving pointers.
4007 These casts are no longer needed now that we assume C89 or later,
4008 since they involve casting to or from void *.
4009 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
4010 (make_pure_float, make_pure_vector):
4011 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
4012 * macros.c (Fstart_kbd_macro):
4013 * menu.c (find_and_return_menu_selection):
4014 * minibuf.c (read_minibuf_noninteractive):
4015 * sysdep.c (closedir):
4016 * xdisp.c (x_produce_glyphs):
4017 * xfaces.c (compare_fonts_by_sort_order):
4018 * xfns.c (x_real_positions, select_visual):
4019 * xselect.c (x_stop_queuing_selection_requests)
4020 (x_get_window_property, x_get_window_property_as_lisp_data):
4021 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
4022 Remove unnecessary pointer casts.
4023 * alloc.c (record_xmalloc): New function.
4024 * lisp.h (record_xmalloc): New decl.
4025 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
4026 more like a function. This is because the pointer cast is not
4027 needed. All uses changed.
4028 * print.c (print_string, print_error_message): Avoid length recalc.
4029
8834c57a
PE
4030 Improve fix for macroexp crash with debugging (Bug#12118).
4031 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
4032 ARRAY_MARK_FLAG when checking subscripts, because ASET is
4033 not supposed to be invoked from the garbage collector.
4034 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
4035 (gc_aset): New function, which is like ASET but can be
4036 used in the garbage collector.
4037 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
4038 (set_hash_index): Use it instead of ASET.
4039
6dad7178
EZ
40402012-08-03 Eli Zaretskii <eliz@gnu.org>
4041
4042 Support symlinks on latest versions of MS-Windows.
4043 * w32.c: Include winioctl.h and aclapi.h.
4044 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
4045 (revert_to_self): Forward declarations of static functions.
4046 <static BOOL g_b_init_get_security_info>:
4047 <g_b_init_create_symbolic_link>: New static flags.
4048 (globals_of_w32): Initialize them to zero.
4049 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
4050 (map_w32_filename): Improve commentary. Simplify switch.
4051 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
4052 headers (most versions of MinGW w32api don't).
4053 (get_security_info, create_symbolic_link)
4054 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
4055 New functions.
4056 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
4057 in the argument file name.
4058 (sys_access): Call unc_volume_file_attributes only if
4059 GetFileAttributes fails with network-related error codes.
4060 (sys_rename): Diagnose renaming of a symlink when the user doesn't
4061 have the required privileges.
14ae4239 4062 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
4063 get_file_security_desc.
4064 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
4065 with addition of handling of symlinks and support for 'lstat'.
4066 If possible, get file's attributes and security information by
6dad7178
EZ
4067 handle, not by name. Produce S_IFLNK bit for symlinks, when
4068 called from 'lstat'.
4069 (stat, lstat): New functions, call 'stat_worker'.
4070 (symlink, readlink, careadlinkat): Rewritten to create and resolve
4071 symlinks when the underlying filesystem supports them.
4072
f162bcc3
PE
40732012-08-02 Paul Eggert <eggert@cs.ucla.edu>
4074
79ea6c20
PE
4075 Fix macroexp crash on Windows with debugging (Bug#12118).
4076 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
4077 checking subscripts; problem introduced with the recent
4078 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
4079 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
4080 since it's used in non-static inline functions now.
4081
c0ce93fd
PE
4082 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
4083 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 4084
f162bcc3
PE
4085 Use C99-style 'extern inline' if available.
4086 * buffer.h (BUFFER_INLINE):
4087 * category.h (CATEGORY_INLINE):
4088 * character.h (CHARACTER_INLINE):
4089 * charset.h (CHARSET_INLINE):
4090 * composite.h (COMPOSITE_INLINE):
4091 * dispextern.h (DISPEXTERN_INLINE):
4092 * lisp.h (LISP_INLINE):
4093 * systime.h (SYSTIME_INLINE):
4094 New macro, replacing 'static inline' in this header.
4095 * buffer.h, category.h, character.h, charset.h, composite.h:
4096 * dispextern.h, lisp.h, systime.h:
4097 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
4098 * alloc.c (LISP_INLINE):
4099 * buffer.c (BUFFER_INLINE):
4100 * category.c (CATEGORY_INLINE):
4101 * character.c (CHARACTER_INLINE):
4102 * charset.c (CHARSET_INLINE):
4103 * composite.c (COMPOSITE_INLINE):
4104 * dispnew.c (DISPEXTERN_INLINE):
4105 * sysdep.c (SYSTIME_INLINE):
4106 Define to EXTERN_INLINE, so that the corresponding functions
4107 are compiled into code.
4108 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
4109 (INLINE_HEADER_END): New macros.
4110 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
4111 since it's used in non-static inline functions now.
a8333d03 4112 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 4113
837b365b
GM
41142012-08-02 Glenn Morris <rgm@gnu.org>
4115
d66b744d
GM
4116 * s/: Remove empty directory.
4117
837b365b
GM
4118 * s/ms-w32.h: Move to ../nt/inc.
4119 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
4120 Update for new ms-w32.h location.
4121
13294f95
PE
41222012-08-02 Paul Eggert <eggert@cs.ucla.edu>
4123
4124 Port to Solaris 8.
4125 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
4126
90df0db3
GM
41272012-08-02 Glenn Morris <rgm@gnu.org>
4128
4129 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
4130 hard-coding the path separator.
4131
4939150c
PE
41322012-08-01 Paul Eggert <eggert@cs.ucla.edu>
4133
4134 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
4135 This how ASET and AREF are supposed to work, and makes
4136 it easier to think about future improvements. See
4137 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
4138 * charset.h (set_charset_attr): New function.
4139 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
4140 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
4141 (aref_addr): New function. All uses of &AREF(...) changed.
4142 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
4143 (set_hash_index): New functions. All lvalue-style uses of
4144 HASH_KEY etc. changed.
4145 * keyboard.c (set_prop): New function. All lvalue-style uses
4146 of PROP changed.
4147
947b2afd
AA
41482012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
4149
4150 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
4151 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
4152 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
4153 * nsfns.m (ns_set_name_as_filename): Likewise.
4154 * nsmenu.m (ns_update_menubar): Likewise.
4155 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
4156
4f5d0325
EZ
41572012-08-01 Eli Zaretskii <eliz@gnu.org>
4158
2008beae
EZ
4159 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
4160 Adapt to latest changes in field names of the corresponding Lisp
288479f6 4161 objects.
2008beae 4162
4f5d0325
EZ
4163 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
4164
fe3cc771
GM
41652012-08-01 Glenn Morris <rgm@gnu.org>
4166
4167 * s/msdos.h: Remove file.
4168 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
4169 * Makefile.in (S_FILE): Remove.
4170 (config_h): Remove S_FILE.
4171
c90acc54
JB
41722012-08-01 Juanma Barranquero <lekktu@gmail.com>
4173
4174 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
4175 Remove; moved to nt/config.nt.
4176
d8a05828
DA
41772012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4178
4179 Use INTERNAL_FIELD for conses and overlays.
4180 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
4181 Remove obsolete comment.
4182 (MVAR): New macro.
4183 (struct Lisp_Overlay): Use INTERNAL_FIELD.
4184 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
4185
8271d590
DA
41862012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4187
4188 Use INTERNAL_FIELD for symbols.
4189 * lisp.h (SVAR): New macro. Adjust users.
4190 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
4191 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
4192
3193acd2
DA
41932012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4194
4195 Use INTERNAL_FIELD for processes.
4196 * process.h (PVAR): New macro. Adjust style.
4197 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
4198 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
4199
3a45383a
DA
42002012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
4201
4202 Use INTERNAL_FIELD for windows.
4203 * window.h (WVAR): New macro.
4204 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
4205 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
4206 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
4207 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
4208 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
4209 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
4210
c1dbc63c
PE
42112012-08-01 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
4214
5c0c0e8a
GM
42152012-08-01 Glenn Morris <rgm@gnu.org>
4216
4217 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
4218 Move to configure.ac.
4219
552a99b4
JB
42202012-08-01 Juanma Barranquero <lekktu@gmail.com>
4221
4222 * makefile.w32-in (CONFIG_H): Update dependencies.
4223 (CONF_POST_H): New macro.
4224
4225 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
4226
8d8e2dfe
GM
42272012-07-31 Glenn Morris <rgm@gnu.org>
4228
bc96620a
GM
4229 * Makefile.in (S_FILE): No longer set by configure.
4230
476b1b2d
GM
4231 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
4232 is available.
4233 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
4234
b2c7a106
GM
4235 * process.h (NULL_DEVICE):
4236 * emacs.c (SEPCHAR):
4237 * editfns.c (USER_FULL_NAME): Let configure set them.
4238
d53d062a
GM
4239 * s/README, s/template.h: Remove files.
4240
4515017f
GM
4241 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
4242
8d8e2dfe
GM
4243 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
4244 Move to configure.ac.
4245
5b20b3cc
EZ
42462012-07-31 Eli Zaretskii <eliz@gnu.org>
4247
1e0afd9a
EZ
4248 * .gdbinit (xframe): Adapt to introduction of FVAR and the
4249 resulting renaming of 'struct frame' members.
4250
5b20b3cc
EZ
4251 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
4252
4253 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
4254 after introduction of FVAR.
4255
f1310128
JD
42562012-07-31 Jan Djärv <jan.h.d@swipnet.se>
4257
79e721e0
JD
4258 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
4259
4260 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
4261 instead of compositeToPoint.
4262 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
4263
8d7c7eed 4264 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 4265
e34f7f79
DA
42662012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
4267
4268 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
4269 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 4270 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
4271 (BVAR): Change to use INTERNAL_FIELD.
4272 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
4273 (KVAR): Change to use INTERNAL_FIELD.
4274 * frame.h (FVAR): New macro.
4275 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
4276 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
4277 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
4278 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
4279 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
4280
c09bfb2f
DA
42812012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
4282
4283 Miscellaneous fixes for non-default X toolkits.
4284 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
4285 * xterm.c (x_frame_of_widget): Remove redundant prototype.
4286 Move under #ifdef USE_LUCID.
4287 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
4288 definition and usage to avoid warnings.
4289
14c114ae
JD
42902012-07-31 Jan Djärv <jan.h.d@swipnet.se>
4291
4292 * nsterm.m (openFiles): Fix previous checkin.
4293
3bd21e82
PE
42942012-07-31 Paul Eggert <eggert@cs.ucla.edu>
4295
4296 * indent.c (compute_motion): Remove unused local.
4297
c1529ded
GM
42982012-07-31 Glenn Morris <rgm@gnu.org>
4299
400d5621
GM
4300 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
4301
268e2432
GM
4302 * conf_post.h [USG5_4]:
4303 Move remaining contents of s/usg5-4-common.h here.
4304 * s/usg5-4-common.h: Remove file.
4305
7552f3ee
GM
4306 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
4307 * s/irix6-5.h: Remove file.
4308
6a381852
GM
4309 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
4310 * s/darwin.h: Remove file.
4311
c1529ded
GM
4312 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
4313 * s/hpux10-20.h: Remove file, which is now empty.
4314
b429a4ee
GM
43152012-07-30 Glenn Morris <rgm@gnu.org>
4316
4317 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
4318 * Makefile.in (config_h): Add conf_post.h.
4319 * makefile.w32-in (CONFIG_H): Add conf_post.h.
4320
adff3182
JD
43212012-07-30 Jan Djärv <jan.h.d@swipnet.se>
4322
4323 * nsterm.m (ns_do_open_file): New variable.
b9031d69 4324 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
4325 (openFile, openTempFile, openFileWithoutUI, openFiles):
4326 Open files only if ns_do_open_file.
adff3182 4327
c32af1e4
PE
43282012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4329
7393bcbb
PE
4330 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
4331 This no-op macro hasn't been needed for many years.
4332 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
4333
c32af1e4
PE
4334 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
4335 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
4336 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
4337 gdb_make_enums_visible.
4338 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
4339 (DIRECTORY_SEP): Now a constant, not a macro.
4340
302fc036
EZ
43412012-07-30 Eli Zaretskii <eliz@gnu.org>
4342
4343 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
4344 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
4345
4346 * w32term.c <w32_keyboard_codepage>: Renamed from
4347 keyboard_codepage and now external. All users changed.
4348
4349 * w32term.h: Add declaration of w32_keyboard_codepage.
4350
4351 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
4352 the codepage to translate keys to Unicode. If this argument is
4353 -1, use the value returned by GetConsoleCP. All callers changed.
4354
88fb40b4
PE
43552012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4356
0aee6912
PE
4357 Update .PHONY listings in makefiles.
4358 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
4359 bootstrap-clean, distclean, maintainer-clean, versioclean,
4360 extraclean, frc.
4361
88fb40b4
PE
4362 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
4363 This is a bit clearer. Fix some commentary typos.
4364
0a763bd1
GM
43652012-07-30 Glenn Morris <rgm@gnu.org>
4366
32bac6d6
GM
4367 * s/netbsd.h: Let configure include signal.h if needed.
4368 Remove file, which is now empty.
4369
b65e7c46
GM
4370 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
4371 Let configure set them.
4372 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
4373 No more need to undefine.
0a763bd1 4374
169304bd
AS
43752012-07-30 Andreas Schwab <schwab@linux-m68k.org>
4376
4377 * keymap.c (Fkey_description): Don't remove 0x80 bit from
4378 non-single-byte char when adding meta modifier. (Bug#12090)
4379
6cd7a139
DA
43802012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4381
4382 Convert safe_call to use variable number of arguments.
4383 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
4384 (safe_call2): Fix comment.
4385 * lisp.h (safe_call): Adjust prototype.
4386 * coding.c (encode_coding_object): Change to use safe_call2.
4387 * xfaces.c (merge_face_heights): Change to use safe_call1.
4388
d34d6ffc
GM
43892012-07-30 Glenn Morris <rgm@gnu.org>
4390
7b8a48e4 4391 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 4392 does that unconditionally. Remove file, which is now empty.
7b8a48e4 4393
d34d6ffc
GM
4394 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
4395 Remove empty files.
4396
03a660a6
PE
43972012-07-30 Paul Eggert <eggert@cs.ucla.edu>
4398
4399 Export to GDB most of lisp.h's remaining object-like macros.
4400 * lisp.h (min, max): Move earlier, because they're used earlier now.
4401 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
4402 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
4403 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
4404 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
4405 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
4406 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
4407 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
4408 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
4409 Now constants, for GDB. They need not be macros.
4410 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
4411 Now constants, for GDB, as well as macros, for static initializers.
4412 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
4413 Move to after the definition of struct Lisp_Char_Table,
4414 since the former now needs that type defined.
4415 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
4416 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
4417 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
4418 New enums, for gdb_make_enums_visible.
4419 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 4420 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
4421 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
4422 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
4423 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
4424 enum maxargs, enum MAX_ALLOCA.
4425 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
4426 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
4427 no longer needed, now that they are done in lisp.h.
4428
e499d0ee
DA
44292012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
4430
4431 Cleanup string bytes checking.
4432 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
4433 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
4434 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
4435 (check_sblock, compact_small_strings): Simplify.
4436
d5040d2d
PE
44372012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
4440 These macros are confusing and no longer need to be defined, as
4441 the enum values now suffice. All uses replaced with definiens.
4442 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
4443
7f259ae6
JB
44442012-07-29 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
4447 ($(BLD)/w32console.$(O)): Update dependencies.
4448
7e63e0c3
DA
44492012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4450
4451 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
4452 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
4453 time. Adjust users.
4454 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
4455
ffd817eb
JD
44562012-07-29 Jan Djärv <jan.h.d@swipnet.se>
4457
4458 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
4459 setting sitelisp (Bug#12010).
4460
417a7a0e
EZ
44612012-07-29 Eli Zaretskii <eliz@gnu.org>
4462
14ae4239 4463 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
4464
4465 * w32heap.c (cache_system_info):
4466 * w32.c (sys_rename):
4467 * w32proc.c (find_child_console, sys_kill): All users changed.
4468
387d4d92
PE
44692012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4470
4471 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
4472
55a6cca6
EZ
44732012-07-29 Eli Zaretskii <eliz@gnu.org>
4474
4475 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
4476
dbcf001c
DA
44772012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4478
4479 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
4480 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
4481 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 4482
e2688e4a
DA
44832012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
4484
4485 Generalize marker debugging code under MARKER_DEBUG and use eassert.
4486 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
4487 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
4488 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
4489 (replace_range, replace_range_2, del_range_2): Change to eassert.
4490 * marker.c (byte_char_debug_check): Adjust style.
4491
b46a6a83
PE
44922012-07-29 Paul Eggert <eggert@cs.ucla.edu>
4493
4494 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
4495 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
4496 long-ago-commented-out code that talks about "WIN32".
4497 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
4498 All uses changed.
4499
e32a5799
PE
45002012-07-28 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 Use Gnulib stdalign module (Bug#9772, Bug#9960).
4503 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
4504 Simplify by using alignof.
4505 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
4506 * lisp.h: Include <stdalign.h>.
4507 (GCALIGNMENT): New macro and constant.
4508 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
4509 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
4510 (stdalign): New macro, if not already defined.
4511
df81cd29
EZ
45122012-07-28 Eli Zaretskii <eliz@gnu.org>
4513
01bd1b0d
EZ
4514 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
4515 * w32inevt.c: Include w32inevt.h.
4516 (w32_read_console_input): New inline function, calls either
4517 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
4518 w32_console_unicode_input.
4519 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
4520 (w32_kbd_patch_key, key_event): Use the codepage returned by
4521 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
4522 (key_event): use uChar.UnicodeChar only if
4523 w32_console_unicode_input is non-zero.
4524
4525 * w32console.c: Include w32heap.h.
4526 <w32_console_unicode_input>: New global variable.
4527 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
4528 family of Windows, zero otherwise.
4529
4530 * w32inevt.h: Declare w32_console_unicode_input.
4531
df81cd29
EZ
4532 * xdisp.c (init_iterator): Don't reference tip_frame in a build
4533 --without-x. (Bug#11742)
4534
c20fdd9e
PE
45352012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4536
4537 Adjust GDB to reflect pvec_type changes (Bug#12036).
4538 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
4539 2012-07-04 changes to pseudovector representation.
4540 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 4541
32770973 45422012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
4543
4544 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
4545 bus address.
4546 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
4547
3438fe21
EZ
45482012-07-27 Eli Zaretskii <eliz@gnu.org>
4549
bcfbc9de
EZ
4550 * alloc.c (listn): Fix the order the arguments are consed onto the
4551 list.
4552
3438fe21
EZ
4553 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
4554 enumeration constants, as PURE and HEAP are too general, and clash
4555 with other headers and sources, such as gmalloc.c and the
4556 MS-Windows system headers. All users changed.
4557
eeaea515
DA
45582012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4559
4560 Revert last save_excursion_save and save_excursion_restore changes.
4561 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
4562 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
4563
073c88c2
DA
45642012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4565
4566 Fix recently-introduced typos in Windows port.
4567 Reported by Martin Rudalics <rudalics@gmx.at>.
4568 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 4569 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 4570
4706125e
PE
45712012-07-27 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 Improve GDB symbol export (Bug#12036).
4574 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
4575 arms of an 'if', not using conditional expressions; otherwise GDB
4576 complains about the types in the unevaluated arm when the argument
4577 is an integer literal.
4578 (xgetint): Simplify expression.
4579 * alloc.c (gdb_make_enums_visible): New constant. This ports to
4580 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
4581 Zaretskii in <http://bugs.gnu.org/12036#13>.
4582 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
4583 needed now that we have gdb_make_enums_visible.
4584 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
4585 (enum enum_USE_LSB_TAG):
4586 New enum types, packaging up enums that need to be exported to GDB.
4587
694b6c97
DA
45882012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4589
4590 Utility function to make a list from specified amount of objects.
4591 * lisp.h (enum constype): New datatype.
4592 (listn): New prototype.
4593 * alloc.c (listn): New function.
4594 (Fmemory_use_count, syms_of_alloc): Use it.
4595 * buffer.c (syms_of_buffer): Likewise.
4596 * callint.c (syms_of_callint): Likewise.
4597 * charset.c (define_charset_internal): Likewise.
4598 * coding.c (syms_of_coding): Likewise.
4599 * keymap.c (syms_of_keymap): Likewise.
4600 * search.c (syms_of_search): Likewise.
4601 * syntax.c (syms_of_syntax): Likewise.
4602 * w32.c (init_environment): Likewise.
4603 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
4604 * xdisp.c (syms_of_xdisp): Likewise.
4605 * xfns.c (syms_of_xfns): Likewise.
4606
6195f384
DA
46072012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
4608
4609 Fast save_excursion_save and save_excursion_restore.
4610 * lisp.h (struct Lisp_Excursion): New data type.
4611 (PVEC_EXCURSION): New pseudovector type.
4612 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
4613 to deal with it. Adjust comments.
4614 (init_marker, attach_marker): New prototype.
4615 (unchain_marker): Adjust prototype.
4616 * marker.c (attach_marker): Change to global.
4617 (init_marker): New function.
4618 * alloc.c (Fmake_marker, build_marker): Use it.
4619 (build_marker): More easserts.
4620 (mark_object): Handle struct Lisp_Excursion.
4621 * editfns.c (save_excursion_save, save_excursion_restore):
4622 Reimplement to use struct Lisp_Excursion. Add comments.
4623
5eceb8fb
PE
46242012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4625
4626 Fix export of symbols to GDB (Bug#12036).
4627 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
4628 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
4629 emacs.c, as this is a more-suitable home. Had this been done earlier
4630 the fix for 12036 would have avoided some of the problems noted in
4631 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
4632 would have been more obvious.
562157c8
PE
4633 * emacs.c: Do not include <verify.h>; no longer needed.
4634 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
4635 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
4636 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4637 Remove; now done in lisp.h.
4638 * lisp.h (PUBLISH_TO_GDB): New macro.
4639 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
4640 (DATA_SEG_BITS): Use it.
4641 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
4642 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
4643 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
4644 not be usable in #if. This simplifies things.
4645
d6749401
JB
46462012-07-26 Juanma Barranquero <lekktu@gmail.com>
4647
4648 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
4649
1781b9e9
PE
46502012-07-26 Paul Eggert <eggert@cs.ucla.edu>
4651
d89518db 4652 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
4653 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
4654 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
4655 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
4656 Adjust to changes in lisp.h and emacs.c, by using
4657 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
4658 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
4659 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
4660 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
4661 instead of gdb_valbits.
4662 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
4663 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
4664 instead of gdb_array_mark_flag.
4665 (xboolvector): Get size from $->size, not $->header.size.
4666 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
4667 (xreload, hook-run, hookpost-run): Remove.
4668 * emacs.c: Include <verify.h>.
4669 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
4670 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
4671 Remove.
4672 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
4673 (gdb_USE_LSB_TAG): New enum constants.
4674 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
4675 Also define these as enum constants, so they're visible to GDB.
4676 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
4677 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
4678 as constants, so they're visible to GDB.
4679 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
4680 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
4681 Now enum constants, not macros, so they're visible to GDB.
4682 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
4683 more convenient now. All uses changed.
4684 (VALMASK) [USE_LSB_TAG]: Also define in this case.
4685 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
4686
3628596a
DA
46872012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
4688
4689 Explicitly free restriction data that are not needed anymore.
4690 * editfns.c (save_restriction_restore): Free restriction data.
4691
7abaf5cc
SM
46922012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
4693
4694 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
4695 add argument, tune behavior, and adjust all callers.
4696
71f88e00
PE
46972012-07-25 Paul Eggert <eggert@cs.ucla.edu>
4698
4699 Use typedef for EMACS_INT, EMACS_UINT.
4700 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
4701 than macros. This simplifies debugging in the usual case, since
4702 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
4703 and it allows expressions involving EMACS_INT casts.
4704 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
4705
57ec3034
JD
47062012-07-25 Jan Djärv <jan.h.d@swipnet.se>
4707
4708 * nsterm.m (ns_read_socket): Return early if there is a modal
4709 window (Bug#12043).
4710
8137e7b3
MR
47112012-07-25 Martin Rudalics <rudalics@gmx.at>
4712
4713 * frame.c (Fredirect_frame_focus): In doc-string don't mention
4714 that FOCUS-FRAME can be omitted.
4715
04e9897c
DA
47162012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
4717
4718 Adjust buffer text indirection counters at the end of Fkill_buffer.
4719 * buffer.c (Fkill_buffer): Adjust indirection counters when the
4720 buffer is definitely dead. This should really fix an issue reported
4721 by Christoph Scholtes again. (Bug#12007).
4722 (init_buffer_once): Initialize indirection counters of
4723 buffer_defaults and buffer_local_symbols (for sanity and safety).
4724
8a0484e1
EZ
47252012-07-24 Eli Zaretskii <eliz@gnu.org>
4726
4727 * xdisp.c (init_iterator): Don't compute dimensions of truncation
4728 and continuation glyphs on tooltip frames, leave them at zero.
4729 Avoids continued lines in tooltips. (Bug#11832)
4730
fa691a83
DA
47312012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
4732
4733 Simplify copy_overlay.
04e9897c 4734 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
4735 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
4736
436bc8e0
EZ
47372012-07-23 Eli Zaretskii <eliz@gnu.org>
4738
4739 * print.c (print_object): Don't crash when a frame's name is nil
4740 or invalid. (Bug#12025)
4741
4742 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
4743 it signals an error when a tooltip frame is being created.
4744
d7a7fda3
DA
47452012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
4746
4747 Cleanup miscellaneous objects allocation and initialization.
4748 * alloc.c (allocate_misc): Change to static. Add argument to
4749 specify the subtype. Adjust comment and users.
4750 (build_overlay): New function.
4751 * buffer.c (copy_overlays, Fmake_overlay): Use it.
4752 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
4753 (allocate_misc): Remove prototype.
4754 (build_overlay): Add prototype.
4755
47562012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
4757
4758 Swap buffer text indirection counters in Fbuffer_swap_text.
4759 * buffer.c (Fbuffer_swap_text): Swap indirections too.
4760 This avoids crash reported by Christoph Scholtes at
4761 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
4762
9d7fa573
JD
47632012-07-22 Jan Djärv <jan.h.d@swipnet.se>
4764
4765 * nsmenu.m (Popdown_data): New struct.
4766 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
4767 free Popdown_data.
4768 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
4769 (initWithContentRect): Make imgView and contentView non-static
4770 and autorelease them. Also autorelease img and matrix (Bug#12005).
4771 (dealloc): Remove (Bug#12005).
4772
0dd6d66d
DA
47732012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4774
4775 Adjust consing_since_gc when objects are explicitly freed.
4776 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
4777 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
4778 (free_cons, free_misc): Subtract object size from consing_since_gc.
4779
d36d71df
DA
47802012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
4781
4782 Simplify and cleanup markers positioning code.
4783 * marker.c (attach_marker): More useful eassert.
4784 (live_buffer, set_marker_internal): New function.
4785 (Fset_marker, set_marker_restricted): Use set_marker_internal.
4786 (set_marker_both, set_marker_restricted_both): Use live_buffer.
4787
fb9ea40f
PE
47882012-07-22 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
4791 as it's limited by the amount of memory, not by INT_MAX.
4792
2d5c5f7d
EZ
47932012-07-21 Eli Zaretskii <eliz@gnu.org>
4794
07fb592e
EZ
4795 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
4796 in special-event-map. See the discussion at
4797 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
4798 for the reasons.
4799
37a9eac8 4800 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
4801 info.dwItemData. Fixes crashes on 64-bit Windows.
4802 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 4803
c4328746
JD
48042012-07-21 Jan Djärv <jan.h.d@swipnet.se>
4805
fc0c31f8 4806 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 4807 (conversationIdentifier): Return value is NSInteger.
784051c4 4808 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 4809
6e5d1c12
CY
48102012-07-21 Chong Yidong <cyd@gnu.org>
4811
4812 * window.c (decode_any_window): Signal an error if the window is
4813 on a dead frame (Bug#11984).
4814
9928463d
DA
48152012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4816
4817 Add indirection counting to speed up Fkill_buffer.
4818 * buffer.h (struct buffer): New member.
4819 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
4820 (Fmake_indirect_buffer): Set indirection counter to -1, increment
4821 base buffer indirection counter.
4822 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
4823 (Fkill_buffer): Adjust indirection counters as needed, don't walk
4824 through buffer list if indirection counter is 0.
4825
f8643a6b
DA
48262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4827
4828 Extend the value returned by Fgarbage_collect with heap statistics.
4829 * alloc.c (Qheap): New symbol.
4830 (syms_of_alloc): DEFSYM it.
4831 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
4832 (Fmemory_free): Remove.
4833 (syms_of_alloc): Don't defsubr it.
4834 * buffer.c (Fcompact_buffer): Remove.
4835 (syms_of_buffer): Don't defsubr it.
4836
dac616ff
DA
48372012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4838
4839 Make maybe_gc inline.
4840 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
4841 * lisp.h (consing_since_gc, gc_relative_threshold)
4842 (memory_full_cons_threshold): Revert declaration.
4843 (maybe_gc): Remove prototype, define as inline.
4844 * alloc.c: Remove old commented-out code.
4845 (consing_since_gc, gc_relative_threshold)
4846 (memory_full_cons_threshold): Revert to global.
4847 (maybe_gc): Remove.
4848
d7ea76b4
DA
48492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4850
4851 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4852 * lisp.h (build_unibyte_string): New function.
4853 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
4854 * sysdep.c, w32fns.c, xfns.c: Use it.
4855 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
4856 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
4857 Adjust users accordingly.
4858 * font.h (font_open_by_name): Adjust prototype.
4859
765e61e3
DA
48602012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4861
4862 Cleanup calls to Fgarbage_collect.
4863 * lisp.h (maybe_gc): New prototype.
4864 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4865 Remove declarations.
4866 * alloc.c (maybe_gc): New function.
4867 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4868 Make them static.
4869 * bytecode.c (MAYBE_GC): Use maybe_gc.
4870 * eval.c (eval_sub, Ffuncall): Likewise.
4871 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
4872 to avoid dependency from auto-save feature.
4873
52b852c7
PE
48742012-07-19 Paul Eggert <eggert@cs.ucla.edu>
4875
4876 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
4877 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
4878 'for_each_per_buffer_object_at'.
4879 All uses changed. It's better to use upper-case for macros that
4880 cannot be implemented as functions, to give the reader a clue
4881 that they're special.
4882
5db81e33
SM
48832012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
4884
4885 * alloc.c (Fgarbage_collect): Tweak docstring.
4886
5b835e1d
DA
48872012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4888
4889 Tweak the value returned from Fgarbage_collect again.
4890 * alloc.c (Fgarbage_collect): New return value, as confirmed in
4891 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
4892 Adjust documentation.
4893 (total_vector_bytes): Rename to total_vector_slots, adjust
4894 accounting.
4895 (total_free_vector_bytes): Rename to total_free_vector_slots,
4896 adjust accounting.
4897 (Qstring_bytes, Qvector_slots): New symbols.
4898 (syms_of_alloc): DEFSYM them.
4899
9cd47b72
DA
49002012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4901
4902 Buffer compaction primitive which may be used from Lisp.
4903 * buffer.c (compact_buffer, Fcompact_buffer): New function.
4904 (syms_of_buffer): Register Fcompact_buffer.
4905 * alloc.c (Fgarbage_collect): Use compact_buffer.
4906 * buffer.h (compact_buffer): New prototype.
4907 (struct buffer_text): New member.
4908
d17337e5
DA
49092012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4910
4911 New macro to iterate over all buffers, miscellaneous cleanups.
4912 * lisp.h (all_buffers): Remove declaration.
4913 * buffer.h (all_buffers): Add declaration, with comment.
4914 (for_each_buffer): New macro.
4915 * alloc.c (Fgarbage_collect, mark_object): Use it.
4916 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4917 (init_buffer): Likewise.
4918 * data.c (Fset_default): Likewise.
4919 * coding.c (code_conversion_restore): Remove redundant check
4920 for dead buffer.
4921 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4922
60cfd278
AS
49232012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4924
4925 Fix bug that created negative-length intervals.
4926 * intervals.c (merge_interval_right, merge_interval_left):
4927 Do not zero out this interval if it is absorbed by its children,
4928 as this interval's total length doesn't change in that case. See
4929 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4930
d06714cb
PE
49312012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4932
83713154
PE
4933 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4934 when invoking (make-bool-vector N t) and N is a positive
4935 multiple of 8 -- the last 8 bits were mistakenly cleared.
4936
d06714cb
PE
4937 Remove some struct layout assumptions in bool vectors.
4938 * alloc.c (bool_header_size): New constant.
4939 (header_size, word_size): Move earlier, as they're now used earlier.
4940 Use 'word_size' in a few more places, where it's appropriate.
4941 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4942 padding before the data member of a bool vector.
4943 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4944 than doing the check by hand with an abort ().
4945
464d5a5e
SM
49462012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4947
5fbc0409
SM
4948 * eval.c (Fdefvar): Don't check constants since we only set the var if
4949 it's not yet defined anyway (bug#11904).
4950
464d5a5e
SM
4951 * lisp.h (last_undo_boundary): Declare new var.
4952 * keyboard.c (command_loop_1): Set it.
4953 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4954 were auto-added by the command loop (bug#11774).
4955
8dc2e44a
AS
49562012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4957
4958 * w32font.c (Qsymbol): Remove local definition.
4959 (syms_of_w32font): Don't DEFSYM it.
4960
169925ec
DA
49612012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4962
4963 Fix sweep_vectors to handle large bool vectors correctly.
4964 * alloc.c (sweep_vectors): Account total_vector_bytes for
4965 bool vectors larger than VBLOCK_BYTES_MAX.
4966
5fbfb018
CY
49672012-07-18 Chong Yidong <cyd@gnu.org>
4968
4969 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4970 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4971
3ab6e069
DA
49722012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4973
4974 Return more descriptive data from Fgarbage_collect.
4975 Suggested by Stefan Monnier in
4976 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4977 * alloc.c (bounded_number): New function.
4978 (total_buffers, total_vectors): New variable.
4979 (total_string_size): Rename to total_string_bytes, adjust users.
4980 (total_vector_size): Rename to total_vector_bytes, adjust users.
4981 (sweep_vectors): Account total_vectors and total_vector_bytes.
4982 (Fgarbage_collect): New return value. Adjust documentation.
4983 (gc_sweep): Account total_buffers.
4984 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4985 (VECTOR_SIZE): Remove.
4986 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4987 (Qinterval, Qmisc): New symbols.
4988 (syms_of_data): Initialize them.
4989 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4990 (Qcons, Qbuffer): New declarations.
4991
6d02fe5b
PE
49922012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4993
4994 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4995 Round up, not down. Improve doc.
4996
b7ffe040
DA
49972012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4998
4999 Restore old code in allocate_string_data to avoid Faset breakage.
5000 Reported by Julien Danjou <julien@danjou.info> in
5001 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
5002 * alloc.c (allocate_string_data): Restore old code with minor
5003 adjustments, fix comment to explain this subtle issue.
5004
4dc7c8d5
SM
50052012-07-17 Eli Zaretskii <eliz@gnu.org>
5006
5007 Remove FILE_SYSTEM_CASE.
5008 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
5009
5010 * fileio.c (FILE_SYSTEM_CASE): Don't define.
5011 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
5012 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
5013 call-process-region passes it through expand-file-name.
5014
5015 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
5016
50172012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5018
5019 Fix crash when creating indirect buffer (Bug#11917)
5020 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
5021 Don't handle unbound variables specially if non-zero.
5022 (Fbuffer_local_variables): Pass zero.
5023 (clone_per_buffer_values): Pass non-zero.
5024
50252012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5026
5027 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
5028 to make the loop interruptible.
5029
50302012-07-17 Andreas Schwab <schwab@linux-m68k.org>
5031
5032 * gnutls.c (emacs_gnutls_handshake): Only retry if
5033 GNUTLS_E_INTERRUPTED.
5034
cce7fefc
DA
50352012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5036
5037 Cleanup and convert miscellaneous checks to eassert.
5038 * alloc.c (mark_interval): Fix comment, partially rephrase
5039 old comment from intervals.h (see below).
5040 * intervals.c (find_interval, adjust_intervals_for_insertion)
5041 (delete_interval, adjust_intervals_for_deletion)
5042 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
5043 Convert to eassert.
5044 (adjust_intervals_for_insertion, make_new_interval):
5045 Remove obsolete and unused code.
5046 * intervals.h (struct interval): Remove obsolete comment.
5047 * textprotp.c (erase_properties): Remove unused code.
5048 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
5049 (Fremove_list_of_text_properties): Convert to eassert.
5050
9ea10cc3
CY
50512012-07-17 Chong Yidong <cyd@gnu.org>
5052
5053 * editfns.c (Finsert_char): Doc fix.
5054
3900d5de
DA
50552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5056
5057 Fix previous change to make Fmemory_free always accurate.
5058 * alloc.c (make_interval): Update total_free_intervals.
5059 (make_float): Likewise for total_free_floats.
5060 (free_cons, Fcons): Likewise for total_free_conses.
5061 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
5062 Likewise for total_free_vector_bytes.
5063 (Fmake_symbol): Likewise for total_free_symbols.
5064 (bytes_free): Remove.
5065
7098646f
DA
50662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5067
5068 Simple free memory accounting feature.
5069 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
5070 (sweep_vectors): Accumulate size of free vectors.
5071 (Fgarbage_collect): Setup bytes_free.
5072 (Fmemory_free): New function.
5073 (syms_of_alloc): Register it.
5074
22657b40
DA
50752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
5076
5077 Cleanup overlays checking.
5078 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
5079 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
5080 eassert and OVERLAYP.
5081 (sort_overlays): Change to use OVERLAYP.
5082
ddfc8813
RK
50832012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
5084
5085 * editfns.c (Finsert_char): Make it interactive, and make the
5086 second arg optional. Copy interactive spec and docstring from
5087 ucs-insert.
5088
7c26cf3c
PE
50892012-07-17 Paul Eggert <eggert@cs.ucla.edu>
5090
5091 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
5092 Unlike the other wrapped functions, fabs has an unspecified
5093 effect on errno.
5094
5d127af9
JD
50952012-07-16 Jan Djärv <jan.h.d@swipnet.se>
5096
5097 * nsterm.m (keyDown): Interpret flags without left/right bits
5098 as the left key (Bug#11670).
5099
6a0dd1d7
DA
51002012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
5101
5102 Remove empty and useless init functions.
5103 * lisp.h (init_character_once, init_fns, init_image)
5104 (init_filelock, init_sound): Remove prototype.
5105 * character.c (init_character_once): Remove.
5106 * filelock.c (init_filelock): Likewise.
5107 * fns.c (init_fns): Likewise.
5108 * image.c (init_image): Likewise.
5109 * sound.c (init_sound): Likewise.
5110 * emacs.c (main): Adjust accordingly.
5111
7a6136fd
DA
51122012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
5113
5114 * gtkutil.h: Tiny cleanups.
5115 (use_old_gtk_file_dialog): Remove useless declaration.
5116 (xg_uses_old_file_dialog): Add suggested const attribute.
5117
ce811ad9
EZ
51182012-07-15 Eli Zaretskii <eliz@gnu.org>
5119
5120 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
5121 (bidi_paragraph_init): Use it to limit search forward for a strong
5122 directional character in abnormally large paragraphs full of
5123 neutral or weak characters. (Bug#11943)
5124
c9adfeaa
SF
51252012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
5126
5127 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
5128 the toolbar (Bug#9451).
5129 (xg_make_tool_item): Give the widget event box a transparent
5130 background.
5131
fff62aa9
DA
51322012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
5133
5134 Cleanup basic allocation variables and functions.
5135 * alloc.c (ignore_warnings, init_intervals, init_float)
5136 (init_cons, init_symbol, init_marker): Remove.
5137 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
5138 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
5139 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
5140 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
5141 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
5142 (staticidx, init_alloc_once, init_strings, free_ablock):
5143 Remove redundant initialization.
5144 * fns.c (init_weak_hash_tables): Remove.
5145 * lisp.h (init_weak_hash_tables): Remove prototype.
5146
9730daca
DA
51472012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
5148
5149 Use zero_vector where appropriate.
5150 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
5151 accordingly.
5152 * lisp.h (zero_vector): New declaration.
5153 * font.c (null_vector): Remove.
5154 (syms_of_font): Remove initialization and staticpro.
5155 (font_list_entities, font_find_for_lface): Change to use zero_vector.
5156 * keymap.c (Faccessible_keymaps): Likewise.
5157
2e2d2a13
LL
51582012-07-15 Leo Liu <sdl.web@gmail.com>
5159
5160 * fringe.c: Fix typo in comments.
5161
cd276f6e
LL
51622012-07-14 Leo Liu <sdl.web@gmail.com>
5163
5164 * fringe.c: Add a new bitmap exclamation-mark.
5165
5a1131d9
EZ
51662012-07-14 Eli Zaretskii <eliz@gnu.org>
5167
5168 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
5169
5170 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
5171 (HAVE_MENUS): Don't define, defined by editing config.in with
5172 msdos/sed2v2.inp.
5173 (GMALLOC_INHIBIT_VALLOC): Don't define.
5174 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
5175
22e983b7
JB
51762012-07-14 Juanma Barranquero <lekktu@gmail.com>
5177
5178 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
5179
5b3f250f
GM
51802012-07-14 Glenn Morris <rgm@gnu.org>
5181
5182 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
5183 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
5184 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
5185
33d63ff4
GM
51862012-07-13 Glenn Morris <rgm@gnu.org>
5187
5b633342
GM
5188 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
5189
33d63ff4
GM
5190 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
5191 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
5192
b55b9f85
JD
51932012-07-13 Jan Djärv <jan.h.d@swipnet.se>
5194
0dc8cf50
JD
5195 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
5196 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
5197 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
5198 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
5199 where appropriate.
5200 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
5201 as boolean expression.
5202 (x_set_window_size): Remove unused variable toolbar.
5203 (ns_get_color_default, ns_mod_to_lisp): Remove.
5204 (ns_mouse_position): Remove unused variables xchar and ychar.
5205 (ns_compute_glyph_string_overhangs): Remove unused variable face.
5206 (ns_set_vertical_scroll_bar): Remove unused variable count.
5207 (ns_delete_terminal): Remove unused variable i.
5208 (ns_term_init): Remove unused variables r, g and b.
5209 (mouseDown): Remove unused variable window.
5210 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
5211 (initFrameFromEmacs): Remove unused variable vbextra.
5212 (mouseEntered): Remove unused variables p and dpyinfo.
5213 (mouseExited): Remove unused variables p and r.
5214 (ns_define_frame_cursor, ns_clear_frame_area)
5215 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
5216 (menuDown): Assign [sender tag] to variable and cast the variable.
5217
5218 * nsterm.h (menuDown): Add id as type to argument sender.
5219 (ns_display_info_for_name): Add Lisp_Object argument.
5220 (ns_term_init): Add Lisp_Object argument.
5221 (ns_map_event_to_object): Add void argument.
5222 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
5223 prototype with arguments and only declare if __OBJC__.
5224 (nxatoms_of_nsselect): Add void argument.
5225 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
5226 (ns_alloc_autorelease_pool): Add void argument.
5227 (ns_release_autorelease_pool): Add void* argument.
5228 (ns_get_defaults_value): Add const char* argument.
5229
5230 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
5231 (initFromContents): Use SSDATA where appropriate.
5232 (ns_update_menubar): Add braces to ambigous if-else.
5233 (initWithTitle): Put () around assignment in if statement.
5234 (ns_menu_show): Remove unused variables window and keymap.
5235 (update_frame_tool_bar): Remove unused variable selected_p.
5236 (initWithContentRect): Remove unused variable this_cmd_name.
5237
5238 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
5239 appropriate.
5240 (setXBMColor): Remove unused variable len.
5241 (setPixmapData): Put () around assignment in loop statement.
5242
5243 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
5244 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
5245 where appropriate.
5246 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
5247 around assignment in loop statement.
5248 (nsfont_open): Remove unused variable i.
5249 (nsfont_open): Remove unused variable len.
5250 (nsfont_draw): Remove unused variable cs.
5251
5252 * nsfns.m (x_set_icon_name, ns_set_name_internal)
5253 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
5254 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
5255 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
5256 (Fns_font_name, Fns_perform_service)
5257 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
5258 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
5259 (ns_set_name): Remove unused variable view.
5260 (x_set_menu_bar_lines): Remove unused variable olines.
5261 (x_set_tool_bar_lines): Remove unused variable root_window.
5262 (Fns_list_colors): Put () around assignment in while statement.
5263 (Fns_perform_service): Remove unused variable len.
5264 (Fns_display_usable_bounds): Remove unused variable top.
5265 (syms_of_nsfns): Remove unused variable i.
5266
b55b9f85
JD
5267 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
5268 memcpy (Bug#11907).
5269
ed9265fc 52702012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
5271
5272 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
5273 and free it with DestroyExceptionInfo (Bug#11558).
5274
ef099b57
JB
52752012-07-13 Juanma Barranquero <lekktu@gmail.com>
5276
5277 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
5278 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
5279 Set here, not in nt/config.nt.
5280
ea814a5d
EZ
52812012-07-13 Eli Zaretskii <eliz@gnu.org>
5282
5283 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
5284 cursor overflow into the last glyph on display line when the right
5285 fringe is off. (Bug#11832)
5286
1a952767
PE
52872012-07-13 Paul Eggert <eggert@cs.ucla.edu>
5288
5289 * xdisp.c (produce_special_glyphs): Now static.
5290 * dispextern.h (produce_special_glyphs): Remove decl.
5291
983188fd
GM
52922012-07-13 Glenn Morris <rgm@gnu.org>
5293
8d7c7eed 5294 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
5295 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
5296
983188fd
GM
5297 * s/usg5-4-common.h (USG, USG5):
5298 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
5299 * s/sol2-6.h (SOLARIS2):
5300 * s/irix6-5.h (IRIX6_5):
5301 * s/hpux10-20.h (USG, USG5, HPUX):
5302 * s/gnu-linux.h (USG, GNU_LINUX):
5303 * s/freebsd.h (BSD_SYSTEM):
5304 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
5305 * s/cygwin.h (CYGWIN):
5306 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
5307 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
5308
d1e68667 53092012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
5310
5311 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 5312
6de0e799
GM
53132012-07-13 Glenn Morris <rgm@gnu.org>
5314
739ae010
GM
5315 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
5316
dbee5793
GM
5317 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
5318
6de0e799
GM
5319 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
5320 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
5321
b82da769
GM
53222012-07-12 Glenn Morris <rgm@gnu.org>
5323
4fae5a7a 5324 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
5325
5326 * process.c (init_process_emacs): Rename from init_process.
5327 The old name is also the name of a Mach system call.
5328 * lisp.h, emacs.c: Update for this name change.
5329 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
5330 longer needed.
5331
5a979817
EZ
53322012-07-12 Eli Zaretskii <eliz@gnu.org>
5333
5334 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
5335 memmove call that removes glyphs covered by the left truncation
5336 glyph. Improve commentary.
5337 (display_line): Fix display of continuation glyphs on GUI frames
5338 when the right fringe is turned off and variable-size fonts are
5339 used in the window. Move the code that appends a stretch glyph to
5340 produce_special_glyphs, so that it could be used for truncation
5341 and continuation glyphs alike.
5342 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
5343 glyph of a suitably computed width, to align the special glyphs at
5344 the window margin. Code moved from display_line. (Bug#11832)
5345
3e91a053
GM
53462012-07-12 Glenn Morris <rgm@gnu.org>
5347
ba9e4b84
GM
5348 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
5349
5350 * s/gnu-linux.h, s/hpux10-20.h:
5351 Do not unconditionally define HAVE_XRMSETDATABASE.
5352
3e91a053
GM
5353 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
5354
b300b1f4
PE
53552012-07-12 Paul Eggert <eggert@cs.ucla.edu>
5356
5357 Fix typos that broke OS X build.
5358 Reported by Randal L. Schwartz in
5359 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
5360 * nsterm.m (ns_timeout): Add missing local decl.
5361 (ns_get_color): snprintf -> sprintf, to fix typo.
5362
6e777848
GM
53632012-07-12 Glenn Morris <rgm@gnu.org>
5364
3f922c37
GM
5365 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
5366 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
5367 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
5368 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
5369
0ab7b23a
GM
5370 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
5371 Move PTY_OPEN to configure.
5372
6e777848
GM
5373 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5374 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
5375 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
5376
4a7edc24
DA
53772012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
5378
5379 Use empty_unibyte_string where applicable.
5380 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
5381 * lread.c (read1): Likewise.
5382 * xsettings.c (syms_of_xsettings): Likewise.
5383
308aab79
GM
53842012-07-12 Glenn Morris <rgm@gnu.org>
5385
42bd1719
GM
5386 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
5387 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
5388 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
5389 * s/hpux10-20.h (RUN_TIME_REMAP):
5390 * s/bsd-common.h (TABDLY): Move to configure.
5391
5392 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
5393
5394 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
5395
ea0bbd17 5396 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 5397 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
5398
5399 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 5400
308aab79
GM
5401 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
5402 * s/template.h: Move NARROWPROTO to configure.
5403
ee1cf5cf
GM
54042012-07-11 Glenn Morris <rgm@gnu.org>
5405
30fe9bf4
GM
5406 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
5407 unused since 2011-01-17 change to systty.h.
5408
ee1cf5cf
GM
5409 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
5410 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5411 Move HAVE_PTYS and HAVE_SOCKETS to configure.
5412
63e47e07
PE
54132012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5414
5415 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
5416
c43fb4c3
GM
54172012-07-11 Glenn Morris <rgm@gnu.org>
5418
5419 * s/darwin.h, s/gnu-linux.h, s/template.h:
5420 Move INTERRUPT_INPUT to configure.
5421
e8df9267
DA
54222012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5423
5424 Minor adjustments to interning code.
5425 * lisp.h (intern, intern_c_string): Redefine as static inline
5426 wrappers for intern_1 and intern_c_string_1, respectively.
5427 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
5428 * lread.c (intern_1, intern_c_string_1, oblookup):
5429 Simplify Vobarray checking.
e8df9267
DA
5430 * font.c (font_intern_prop): Likewise. Adjust comment.
5431 * w32font.c (intern_font_name): Likewise.
5432
34348bd4
AS
54332012-07-11 Andreas Schwab <schwab@linux-m68k.org>
5434
d96a1e0c
AS
5435 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
5436
34348bd4
AS
5437 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
5438 of Fcar/Fcdr if possible.
5439 * font.c (check_otf_features): Likewise.
5440 * fontset.c (Fnew_fontset): Likewise.
5441 * gnutls.c (Fgnutls_boot): Likewise.
5442 * minibuf.c (read_minibuf): Likewise.
5443 * msdos.c (IT_set_frame_parameters): Likewise.
5444 * xmenu.c (Fx_popup_dialog): Likewise.
5445 * w32menu.c (Fx_popup_dialog): Likewise.
5446
c8add24e
GM
54472012-07-11 Glenn Morris <rgm@gnu.org>
5448
4b575b3c
GM
5449 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
5450 since nothing has defined it on these platforms.
5451
09f4e3b0
GM
5452 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
5453 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
5454
172bedef
GM
5455 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
5456 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
5457 Move CLASH_DETECTION to configure.
5458
249685df
GM
5459 * s/gnu.h: Remove file, which is now empty.
5460
c8add24e
GM
5461 * s/gnu.h, s/gnu-linux.h:
5462 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
5463
b41253a3
JW
54642012-07-11 John Wiegley <johnw@newartisans.com>
5465
5466 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
5467 function attribute, so we only use it if it exists in the
5468 compiler.
5469
d923b542
DA
54702012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5471
5472 Avoid call to strlen in fast_c_string_match_ignore_case.
5473 * search.c (fast_c_string_match_ignore_case): Change to use
5474 length argument. Adjust users accordingly.
5475 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
5476
5ebbef1d
PE
54772012-07-11 Paul Eggert <eggert@cs.ucla.edu>
5478
bb352260
PE
5479 Assume mkdir, rmdir.
5480 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
5481 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
5482
57054ddd
PE
5483 Assume rename.
5484 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
5485
b747d3f7
PE
5486 Assume perror.
5487 * s/hpux10-20.h (HAVE_PERROR): Remove.
5488 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
5489 Remove dummy definition, as this problem was obsolete long ago.
5490
5ebbef1d
PE
5491 Assume strerror.
5492 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
5493
984e7f30
DA
54942012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
5495
5496 Avoid calls to strlen in font processing functions.
5497 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
5498 (font_open_by_name): Change to use length argument.
5499 Adjust users accordingly.
d923b542
DA
5500 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
5501 Adjust prototypes.
5502 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
5503 Change to return ptrdiff_t.
984e7f30
DA
5504 (xfont_list_pattern, xfont_match): Use length returned by
5505 xfont_decode_coding_xlfd.
5506 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
5507
20e94fdd
GM
55082012-07-11 Glenn Morris <rgm@gnu.org>
5509
9d596af3
GM
5510 * s/darwin.h, s/freebsd.h, s/netbsd.h:
5511 Move DONT_REOPEN_PTY to configure.
5512
20e94fdd
GM
5513 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
5514 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
5515
e99a530f
PE
55162012-07-10 Paul Eggert <eggert@cs.ucla.edu>
5517
22ffb973
PE
5518 Remove "#define unix" that is no longer needed (Bug#11905).
5519 * s/aix4-2.h (unix): Remove; no longer needed.
5520
e9a9ae03
PE
5521 EMACS_TIME simplification (Bug#11875).
5522 This replaces macros (which typically do not work in GDB)
5523 with functions, typedefs and enums, making the code easier to debug.
5524 The functional style also makes code easier to read and maintain.
5525 * systime.h: Include <sys/time.h> on all hosts, not just if
5526 WINDOWSNT, since 'struct timeval' is needed in general.
5527 (EMACS_TIME): Now a typedef, not a macro.
5528 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
5529 not macros.
5530 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
5531 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
5532 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
5533 (EMACS_TIME_LE): Now functions, not macros.
5534 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
5535 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
5536 which are not functions. All uses rewritten to use:
5537 (make_emacs_time): New function.
5538 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
5539 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
5540 not functions. All uses rewritten to use the following, respectively:
5541 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
5542 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 5543 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
5544 * fileio.c (Fcopy_file):
5545 * xterm.c (XTflash): Get the current time closer to when it's used.
5546 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
5547
ffacb126
PE
5548 * bytecode.c (targets): Suppress -Woverride-init warnings.
5549
e99a530f
PE
5550 Simplify by avoiding confusing use of strncpy etc.
5551 * doc.c (Fsnarf_documentation):
5552 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
5553 * frame.c (Fmake_terminal_frame):
5554 * gtkutil.c (get_utf8_string):
5555 * lread.c (openp):
5556 * nsmenu.m (ns_update_menubar):
5557 * regex.c (regerror):
5558 Prefer memcpy to strncpy and strncat when either will do.
5559 * fileio.c (Fsubstitute_in_file_name):
5560 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
5561 (menu_separator_name_p):
5562 * nsmenu.m (ns_update_menubar):
5563 Prefer memcmp to strncmp when either will do.
5564 * nsterm.m: Include <ftoastr.h>.
5565 (ns_get_color):
5566 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
5567 Prefer snprintf to strncpy.
5568 * nsterm.m (ns_term_init):
5569 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
5570 * nsterm.m (ns_term_init):
5571 Avoid the need for strncpy, by using build_string or
5572 make_unibyte_string directly. Use dtoastr, not snprintf.
5573 * process.c (Fmake_network_process): Diagnose service names that
5574 are too long, rather than silently truncating them or creating
5575 non-null-terminated names.
5576 (Fnetwork_interface_info): Likewise, for interface names.
5577 * sysdep.c (system_process_attributes) [GNU_LINUX]:
5578 Prefer sprintf to strncat.
5579 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
5580 Prefer vsnprintf to vsprintf + strncpy.
5581
c59592b3
GM
55822012-07-10 Glenn Morris <rgm@gnu.org>
5583
5584 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
5585 Clarify fallback case.
5586
7d7bbefd
DA
55872012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5588
5589 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
5590 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
5591 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 5592 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
5593 where argument type is known to be a Lisp_Cons.
5594
3a4c8000
TT
55952012-07-10 Tom Tromey <tromey@redhat.com>
5596
5597 * bytecode.c (BYTE_CODE_THREADED): New macro.
5598 (BYTE_CODES): New macro. Replaces all old byte-code defines.
5599 (enum byte_code_op): New type.
5600 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
5601 (exec_byte_code): Use them. Use token threading when applicable.
5602
2a0213a6
DA
56032012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5604
5605 Optimize pure C strings initialization.
5606 * lisp.h (make_pure_string): Fix prototype.
5607 (build_pure_c_string): New function, defined as static inline. This
5608 provides a better opportunity to optimize away calls to strlen when
5609 the function is called with compile-time constant argument.
5610 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
5611 argument, adjust users accordingly. Use build_pure_c_string where
5612 appropriate.
5613 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
5614 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
5615 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
5616
cb1caeaf
DA
56172012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5618
5619 Avoid calls to strlen in miscellaneous functions.
5620 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
5621 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
5622 * lread.c (openp): Likewise.
5623
c293e30c
DA
56242012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
5625
5626 Avoid calls to strlen in path processing functions.
5627 * fileio.c (file_name_as_directory): Add comment. Change to add
5628 srclen argument and return the length of result. Adjust users
5629 accordingly.
5630 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
5631 swap 1st and 2nd arguments to obey the common convention.
5632 Adjust users accordingly.
c293e30c
DA
5633 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
5634
9e059e3f
GM
56352012-07-10 Glenn Morris <rgm@gnu.org>
5636
d02eb359
GM
5637 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
5638 Move PENDING_OUTPUT_COUNT definition to configure.
5639
882cf227
GM
5640 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
5641 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
5642 * s/gnu.h (DATA_START): Move definitions to configure.
5643
af6e839f
GM
5644 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
5645 We include usg5-4-common.h, which defines them both.
5646
40289a12
GM
5647 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
5648 O_RDONLY already includes it).
5649
9e059e3f
GM
5650 Stop ns builds setting the EMACSLOADPATH environment variable.
5651 * nsterm.m (ns_load_path): Rename from ns_init_paths.
5652 Now it does not set EMACSLOADPATH, just returns the load-path string.
5653 * nsterm.h: Update accordingly.
5654 * lread.c [HAVE_NS]: Include nsterm.h.
5655 (init_lread) [HAVE_NS]: Use ns_load_path.
5656 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
5657
7c4e8ec0
GM
56582012-07-09 Glenn Morris <rgm@gnu.org>
5659
d4f600ff
GM
5660 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
5661 since the included bsd-common.h does so.
5662
cbb31951
GM
5663 Stop ns builds setting the EMACSPATH environment variable.
5664 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
5665 (ns_init_paths): Do not set EMACSPATH.
5666 * nsterm.h (ns_exec_path): Add it.
5667 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
5668 Use ns_exec_path.
5669
7c4e8ec0
GM
5670 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
5671
26bccfae
PE
56722012-07-09 Paul Eggert <eggert@cs.ucla.edu>
5673
a0bee46f
PE
5674 * process.c (wait_reading_process_output): 'waitchannels' was unset
5675 when read_kbd || !NILP (wait_for_cell); fix this.
5676
5994c183
PE
5677 Add GCC-style 'const' attribute to functions that can use it.
5678 * character.h (char_resolve_modifier_mask):
5679 * keyboard.h (make_ctrl_char):
5680 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
5681 (init_character_once, next_almost_prime, init_fns, init_image)
5682 (flush_pending_output, init_sound):
5683 * mem-limits.h (start_of_data):
5684 * menu.h (finish_menu_items):
5685 Add ATTRIBUTE_CONST.
5686 * emacs.c (DEFINE_DUMMY_FUNCTION):
5687 Declare the dummy function with ATTRIBUTE_CONST.
5688 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
5689 Add decls with ATTRIBUTE_CONST.
5690
26bccfae
PE
5691 Minor improvements to make_formatted_string.
5692 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
5693 where int is good enough, as vsprintf returns an int.
5694 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
5695
a8290ec3
DA
56962012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5697
5698 Use make_formatted_string to avoid double length calculation.
5699 * lisp.h (make_formatted_string): New prototype.
5700 * alloc.c (make_formatted_string): New function.
5701 * buffer.c (Fgenerate_new_buffer_name): Use it.
5702 * dbus.c (syms_of_dbusbind): Likewise.
5703 * editfns.c (Fcurrent_time_zone): Likewise.
5704 * filelock.c (get_boot_time): Likewise.
5705 * frame.c (make_terminal_frame, set_term_frame_name)
5706 (x_report_frame_params): Likewise.
5707 * image.c (gs_load): Likewise.
5708 * minibuf.c (get_minibuffer): Likewise.
5709 * msdos.c (dos_set_window_size): Likewise.
5710 * process.c (make_process): Likewise.
5711 * xdisp.c (ensure_echo_area_buffers): Likewise.
5712 * xsettings.c (apply_xft_settings): Likewise.
5713
d01ba2f1
GM
57142012-07-09 Glenn Morris <rgm@gnu.org>
5715
5716 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
5717 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
5718 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
5719 * nsterm.h (ns_etc_directory): Add it.
5720 * callproc.c [HAVE_NS]: Include nsterm.h.
5721 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
5722
f1f924b6
DA
57232012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
5724
5725 Move marker debugging code under MARKER_DEBUG.
5726 * marker.c (MARKER_DEBUG): Move marker debugging code under
5727 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
5728 for bootstrap with --enable-checking (~3x slowdown reported
5729 by Juanma Barranquero <lekktu@gmail.com>).
5730 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
5731
ab531b66
PE
57322012-07-08 Paul Eggert <eggert@cs.ucla.edu>
5733
5734 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
5735 See <http://bugs.gnu.org/11825#29>.
5736
c4b3bc8a
EZ
57372012-07-08 Eli Zaretskii <eliz@gnu.org>
5738
5739 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
5740 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
5741 (display_line): Add commentary about displaying truncation glyphs
5742 on GUI frames.
5743 (produce_special_glyphs): Move here from term.c.
5744
5745 * term.c (produce_special_glyphs): Move to xdisp.c.
5746
5747 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
5748 section.
c4b3bc8a 5749
b676b881
AS
57502012-07-07 Andreas Schwab <schwab@linux-m68k.org>
5751
f17c5273
AS
5752 * xdisp.c (display_line): Avoid warning about implicit declaration
5753 of FRAME_FONT.
5754
298819b9
AS
5755 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
5756
b676b881
AS
5757 * lisp.h: Remove empty conditional.
5758
6045c4fd
PE
57592012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5760
b3350bf9
PE
5761 * lread.c (load_path_check): Now static.
5762
6045c4fd
PE
5763 Fix some minor --with-ns problems found by static checking.
5764 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
5765 (x_set_font) [!HAVE_X_WINDOWS]:
5766 * image.c (xpm_load_image) [HAVE_NS]:
5767 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
5768 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
5769 Remove unused local.
5770 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
5771 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
5772 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
5773 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
5774 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
5775 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
5776 Fix pointer signedness problem.
5777 * xfaces.c (FRAME_X_FONT_TABLE):
5778 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
5779
929e7845
GM
57802012-07-07 Glenn Morris <rgm@gnu.org>
5781
5782 * lread.c (load_path_check): New function, split from init_lread.
5783 (init_lread): Reorganize. Motivation:
5784 If EMACSLOADPATH is set, check/warn about that rather than the
5785 defaults, which we are not going to use. Hence we can remove
5786 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
5787 Don't warn if site-lisp directories are missing.
5788 If not installed, start from a blank load-path, since
5789 PATH_LOADSEARCH refers to the eventual installation directories.
5790
58dd0aa4
EZ
57912012-07-07 Eli Zaretskii <eliz@gnu.org>
5792
5793 Support truncation and continuation glyphs on GUI frames, when
5794 fringes are disabled. (Bug#11832)
5795 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
5796 continuation glyphs even if on GUI frames.
5797 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
5798 or both, are absent.
5799 (start_display, move_it_in_display_line_to): Handle the case of a
5800 GUI frame without a fringe to display continuation or truncation
5801 glyphs.
5802 (insert_left_trunc_glyphs): Support GUI frames: make sure
5803 truncation glyphs overwrite enough glyphs from the current line to
5804 have sufficient space in pixels.
5805 (display_line): Support truncation and continuation glyphs on GUI
5806 frames. If some spare pixels are left on the line after inserting
5807 the truncation glyphs, fill that space with a stretch glyph of a
5808 suitably computed width.
5809
5810 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
5811 produce_glyphs, to support GUI sessions.
5812
31571fd7
PE
58132012-07-07 Paul Eggert <eggert@cs.ucla.edu>
5814
5a16b9bc
PE
5815 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
5816
f3047c75
PE
5817 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
5818
31571fd7
PE
5819 Do not require float-time's arg to fit in time_t (Bug#11825).
5820 This works better on hosts where time_t is unsigned, and where
5821 float-time is applied to the (negative) difference between two times.
5822 * editfns.c (decode_time_components): Last arg is now double *,
5823 not int *, and means to store all the result as a double, without
5824 worrying about whether the seconds part fits in time_t.
5825 All callers changed.
5826 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
5827 All callers changed.
5828 (Ffloat_time): Do not fail merely because the specified time falls
5829 outside of time_t range.
5830
4516fbef
GM
58312012-07-07 Glenn Morris <rgm@gnu.org>
5832
5833 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
5834 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
5835 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
5836
07adc2c6
JB
58372012-07-07 Juanma Barranquero <lekktu@gmail.com>
5838
5839 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
5840 Update dependencies.
5841
5842 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
5843
fd573f31
PE
58442012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5845
fee5959d
PE
5846 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
5847 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5848 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
5849 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
5850 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
5851 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
5852
fd573f31
PE
5853 * xfont.c (compare_font_names): Redo to omit the need for casts.
5854
ddadbc0e
AS
58552012-07-06 Andreas Schwab <schwab@linux-m68k.org>
5856
fca8d6b6
AS
5857 * xfns.c (Fx_change_window_property): Doc fix.
5858 * w32fns.c (Fx_change_window_property): Doc fix.
5859
ddadbc0e
AS
5860 * w32fns.c (Fx_window_property): Accept the same arguments as the
5861 X Windows version. Doc fix.
5862 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
5863
ed9265fc 58642012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
5865 Eli Zaretskii <eliz@gnu.org>
5866
5867 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
5868 Windows-specific code from nt/config.nt moved here.
5869 Obsolete settings removed.
5870
216ee680
PE
58712012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5872
5873 * process.c: Avoid unnecessary calls to gettime.
5874 (wait_reading_process_output): Don't get the time of day
5875 when gobbling data immediately and not waiting, as there's no need
5876 for it in that case. This removes a FIXME.
5877
bdd091e4
JD
58782012-07-06 Jan Djärv <jan.h.d@swipnet.se>
5879
5880 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
5881 is defined (Bug#11768).
5882
9d44f8ce
DA
58832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5884
5885 Fix marker debugging code.
5886 * marker.c (byte_char_debug_check): Do not perform the check
5887 if buffer is not multibyte.
090bd7cb
JB
5888 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5889 Call byte_char_debug_check with correct arguments.
9d44f8ce 5890
90fc4786
DA
58912012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5892
5893 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
5894 * marker.c (byte_char_debug_check, count_markers):
5895 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
5896 (byte_debug_flag): Remove.
5897 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5898 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
5899
7b7ae965
DA
59002012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5901
4e57b342
DA
5902 Avoid code repetition in marker-related functions.
5903 * marker.c (attach_marker): New function.
5904 (Fset_marker, set_marker_restricted, set_marker_both)
5905 (set_marker_restricted_both): Use it.
5906 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
5907 Consistently rename charno to charpos.
5908 (marker_position): Add eassert.
5909 (marker_byte_position): Convert to eassert.
5910
59112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5912
5913 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 5914 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 5915 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5916
657924ff
DA
59172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5918
5919 Introduce fast path for the widely used marker operation.
5920 * alloc.c (build_marker): New function.
5921 * lisp.h (build_marker): New prototype.
5922 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5923 * composite.c (autocmp_chars): Likewise.
5924 * editfns.c (buildmark): Remove.
5925 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5926 (save_restriction_save): Use build_marker.
5927 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5928 * window.c (save_window_save): Likewise.
5929
041a49a6
DA
59302012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5931
5932 Do not use Fdelete_overlay in delete_all_overlays
5933 to avoid redundant calls to unchain_overlay.
5934 * buffer.c (drop_overlay): New function.
5935 (delete_all_overlays, Fdelete_overlay): Use it.
5936 * minibuf.c (get_minibuffer): Fix comment.
5937
7dca65a4
PE
59382012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5939
5940 Port to OpenBSD 5.1 amd64.
5941 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5942 This is needed for OpenBSD, and should be harmless on all BSD systems.
5943 Also, include <sys/sysctl.h>, as it should be available on all
5944 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5945 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5946 use p_pid member, not kp_proc.pid.
5947
8eb876e2
GM
59482012-07-06 Glenn Morris <rgm@gnu.org>
5949
5950 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5951
38182d90
PE
59522012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5953
5954 More xmalloc and related cleanup.
5955 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5956 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5957 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5958 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5959 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5960 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5961 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5962 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5963 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5964 * xterm.c:
5965 Omit needless casts involving void * pointers and allocation.
5966 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5967 as the former is more robust if P's type is changed.
5968 Prefer xzalloc to xmalloc + memset 0.
5969 Simplify malloc-or-realloc to realloc.
5970 Don't worry about xmalloc returning a null pointer.
5971 Prefer xstrdup to xmalloc + strcpy.
5972 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5973 growing it.
5974 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5975 alloca of a constant.
5976
6dd5a677
EZ
59772012-07-05 Eli Zaretskii <eliz@gnu.org>
5978
5979 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5980 hscroll is larger than the line width. Fixes long and futile
5981 looping inside extend_face_to_end_of_line (on a TTY) producing
5982 glyphs that are not needed and thrown away.
5983
6b312f0f
DA
59842012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5985
5986 * marker.c (set_marker_restricted_both): Simplify by using
5987 clip_to_bounds.
5988
f520ef9b
PE
59892012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5990
5991 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5992
383b7c95
JD
59932012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5994
5995 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5996 not defined (Bug#11768).
5997 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5998 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5999 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
6000 followed by gtk_box_set_homogeneous (Bug#11768).
6001 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
6002 (update_theme_scrollbar_width, xg_create_scroll_bar):
6003 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
6004 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
6005 (is_box_type): New function (Bug#11768).
6006 (xg_tool_item_stale_p): Call is_box_type.
5293d758 6007 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
6008 with default display (Bug#11768).
6009
d6e7bf45
EZ
60102012-07-05 Eli Zaretskii <eliz@gnu.org>
6011
6012 * xdisp.c (window_hscroll_limited): New function.
6013 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
6014 coordinates when window's hscroll is set to insanely large
6015 values. (Bug#11857)
6016
431391ec
JB
60172012-07-05 Juanma Barranquero <lekktu@gmail.com>
6018
6019 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
6020 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
6021
23f86fce
DA
60222012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
6023
6024 Cleanup xmalloc.
6025 * lisp.h (xzalloc): New prototype. Omit needless casts.
6026 * alloc.c (xzalloc): New function. Omit needless casts.
6027 * charset.c: Omit needless casts. Convert all calls to
6028 xmalloc with following memset to xzalloc.
6029 * dispnew.c: Likewise.
6030 * fringe.c: Likewise.
6031 * image.c: Likewise.
6032 * sound.c: Likewise.
6033 * term.c: Likewise.
6034 * w32fns.c: Likewise.
6035 * w32font.c: Likewise.
6036 * w32term.c: Likewise.
6037 * xfaces.c: Likewise.
6038 * xfns.c: Likewise.
6039 * xterm.c: Likewise.
6040 * atimer.c: Omit needless casts.
6041 * buffer.c: Likewise.
6042 * callproc.c: Likewise.
6043 * ccl.c: Likewise.
6044 * coding.c: Likewise.
6045 * composite.c: Likewise.
6046 * doc.c: Likewise.
6047 * doprnt.c: Likewise.
6048 * editfns.c: Likewise.
6049 * emacs.c: Likewise.
6050 * eval.c: Likewise.
6051 * filelock.c: Likewise.
6052 * fns.c: Likewise.
6053 * gtkutil.c: Likewise.
6054 * keyboard.c: Likewise.
6055 * lisp.h: Likewise.
6056 * lread.c: Likewise.
6057 * minibuf.c: Likewise.
6058 * msdos.c: Likewise.
6059 * print.c: Likewise.
6060 * process.c: Likewise.
6061 * region-cache.c: Likewise.
6062 * search.c: Likewise.
6063 * sysdep.c: Likewise.
6064 * termcap.c: Likewise.
6065 * terminal.c: Likewise.
6066 * tparam.c: Likewise.
6067 * w16select.c: Likewise.
6068 * w32.c: Likewise.
6069 * w32reg.c: Likewise.
6070 * w32select.c: Likewise.
6071 * w32uniscribe.c: Likewise.
6072 * widget.c: Likewise.
6073 * xdisp.c: Likewise.
6074 * xmenu.c: Likewise.
6075 * xrdb.c: Likewise.
6076 * xselect.c: Likewise.
6077
0497dc44
PE
60782012-07-05 Paul Eggert <eggert@cs.ucla.edu>
6079
6080 * fileio.c (time_error_value): Check the right error number.
6081 Problem reported by Troels Nielsen in
6082 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
6083
356e7178
PE
60842012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6085
4e71fd89
PE
6086 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
6087 This should be fixed in a better way; see Eli Zaretskii in
6088 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
6089 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
6090
f0941253
PE
6091 * fileio.c (time_error_value): Rename from special_mtime.
6092 The old name's problems were noted by Eli Zaretskii in
6093 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
6094
065c9eb4
PE
6095 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
6096 This variable's comment says Emacs needs at least one GDB-visible
6097 symbol of type enum pvec_type, to work around GDB problems.
6098 The symbol's value doesn't matter.
6099
356e7178
PE
6100 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
6101 that causes compilation to fail on pre-C99 compilers.
6102
ed9265fc 61032012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
6104
6105 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
6106 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
6107
3884d954
DA
61082012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6109
d209e2fb 6110 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
6111 headers for buffer_defaults and buffer_local_symbols.
6112 Reported by Juanma Barranquero <lekktu@gmail.com>.
6113
ee28be33
SM
61142012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6115
6116 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
6117 * lisp.h (enum pvec_type): Use fewer bits.
6118 (PSEUDOVECTOR_SIZE_BITS): New constant.
6119 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
6120 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
6121 change in pvec_type.
6122 (PSEUDOVECTOR_TYPEP): New macro.
6123 (TYPED_PSEUDOVECTORP): Use it.
6124 * fns.c (internal_equal): Adapt code to extract pvectype.
6125 * emacs.c (gdb_pvec_type): Update type.
6126 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
6127 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
6128 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
6129 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
6130 (sweep_vectors): Use it. Use local var `total_bytes' instead of
6131 abusing vector->header.next.nbytes.
6132 (live_vector_p): Use PVEC_TYPE.
6133 (mark_object): Adapt code to extract pvectype. Use switch.
6134
c7f2cd7f
PE
61352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6136
6137 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
6138 Tighten new eassert a bit.
6139
8ce70ed2
DA
61402012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6141
6142 Fix compilation with --enable-gcc-warnings and -O1
6143 optimization level.
6144 * doprnt.c (doprnt): Change type of tem to int, initialize
6145 to avoid compiler warning. Add eassert.
6146 * search.c (simple_search): Initialize match_byte to avoid
6147 compiler warning. Add eassert.
6148
dea7f1e5
PE
61492012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6150
24a212eb
PE
6151 Avoid weird behavior with large horizontal scrolls.
6152 Without this change, for example, large hscroll values would
6153 mess up Emacs's display on Fedora 15 x86, presumably due to
6154 overflows in int calculations in the display code.
6155 Also, if buffers had long lines, Emacs would freeze.
6156 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
6157 (set_window_hscroll): New function, containing the old guts of
6158 Fset_window_hscroll. Return the clipped value.
6159 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
6160 This avoids the need to check against PTRDIFF_MAX.
6161
dea7f1e5
PE
6162 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
6163
76046526
DA
61642012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
6165
6166 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
6167
39adff0d
PE
61682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
6169
63807d47
PE
6170 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
6171 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
6172 since GCC 4.4.6 issues a bogus warning for them.
6173
39adff0d
PE
6174 Fix bugs in file timestamp newness comparisons.
6175 * fileio.c (Ffile_newer_than_file_p):
6176 * lread.c (Fload): Use full timestamp resolution of files,
6177 not just the 1-second resolution, so that files that are only
6178 slightly newer still count as newer.
6179 * fileio.c (Ffile_newer_than_file_p): Don't assume file
6180 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
6181
dbeed9a6
PE
61822012-07-03 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 * fileio.c: Improve handling of file time marker. (Bug#11852)
6185 (special_mtime): New function.
6186 (Finsert_file_contents, Fverify_visited_file_modtime):
6187 Use it to set special mtime values consistently.
6188
636334d6
AS
61892012-07-03 Andreas Schwab <schwab@linux-m68k.org>
6190
6191 * fileio.c (Finsert_file_contents): Properly handle st_mtime
6192 marker for non-existing file. (Bug#11852)
6193
e2017fe2
GM
61942012-07-03 Glenn Morris <rgm@gnu.org>
6195
6196 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
6197 and did not make it into globals.h).
6198
404dbd37
TT
61992012-07-03 Tom Tromey <tromey@redhat.com>
6200
6201 * window.c (Fset_window_margins, Fset_window_fringes)
6202 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
6203 * textprop.c (Fprevious_property_change): No longer static.
6204 * syntax.c (Fsyntax_table_p): No longer static.
6205 * process.c (Fget_process, Fprocess_datagram_address): No longer
6206 static.
6207 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
6208 * keyboard.c (Fcommand_execute): No longer static.
6209 Remove EXFUN.
6210 * insdel.c (Fcombine_after_change_execute): No longer static.
6211 * image.c (Finit_image_library): No longer static.
6212 * fileio.c (Fmake_symbolic_link): No longer static.
6213 * eval.c (Ffetch_bytecode): No longer static.
6214 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
6215 * doc.c (Fdocumentation_property, Fsnarf_documentation):
6216 No longer static.
404dbd37
TT
6217 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
6218 static.
6219 * dired.c (Ffile_attributes): No longer static.
6220 * composite.c (Fcomposition_get_gstring): No longer static.
6221 * callproc.c (Fgetenv_internal): No longer static.
6222
6223 * ccl.h: Remove EXFUNs.
6224 * buffer.h: Remove EXFUNs.
6225 * dispextern.h: Remove EXFUNs.
6226 * intervals.h: Remove EXFUNs.
6227 * fontset.h: Remove EXFUN.
6228 * font.h: Remove EXFUNs.
6229 * dosfns.c (system_process_attributes): Remove EXFUN.
6230 * keymap.h: Remove EXFUNs.
6231 * lisp.h: Remove EXFUNs.
6232 * w32term.h: Remove EXFUNs.
6233 * window.h: Remove EXFUNs.
6234 * xsettings.h: Remove EXFUN.
6235 * xterm.h: Remove EXFUN.
6236
8e4fd1e1
GM
62372012-07-03 Glenn Morris <rgm@gnu.org>
6238
6239 * lisp.h (Frandom): Make it visible to C.
6240 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
6241 buffer for invisible buffers. (Bug#1229)
6242
ca95b3eb
DA
62432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6244
6245 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
6246 values which aren't power of 2.
14ae4239
BT
6247 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
6248 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
6249 accordingly.
6250
7555c33f
SM
62512012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
6252
6253 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
6254
6255 * alloc.c (mark_object): Revert part of last patch to use `switch'.
6256
d12e8f5a
DA
62572012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6258
6259 * alloc.c (allocate_vector_block): Remove redundant
6260 calls to mallopt if DOUG_LEA_MALLOC is defined.
6261 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
6262 avoid calls to mallopt if zero_vector is returned.
6263
296094c3
DA
62642012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6265
6266 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
6267 is enabled, avoid dereferencing NULL current_sblock if
6268 running undumped.
6269
36429c89
DA
62702012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
6271
6272 Cleanup basic buffer management.
6273 * buffer.h (struct buffer): Change layout to use generic vector
6274 marking code. Fix some comments. Change type of 'clip_changed'
6275 to bitfield. Remove unused #ifndef old.
6276 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
6277 (GET_OVERLAYS_AT): Fix indentation.
6278 (for_each_per_buffer_object_at): New macro.
6279 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
6280 (Fbuffer_local_variables): Use it.
6281 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
6282 * alloc.c (allocate_buffer): Adjust to match new layout of
6283 struct buffer. Fix comment.
6284 (mark_overlay): New function.
6285 (mark_buffer): Use it. Use mark_vectorlike to mark normal
6286 Lisp area of struct buffer.
6287 (mark_object): Use it. Adjust marking of misc objects
6288 and related comments.
6289
3b3e4cac
PE
62902012-07-02 Paul Eggert <eggert@cs.ucla.edu>
6291
6292 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
6293 wrapper that is not needed because the wrapped code is a no-op (zero
6294 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
6295 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
6296
cf5c0175
DA
62972012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
6298
6299 * alloc.c (mark_buffer): Simplify. Remove prototype.
6300 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 6301 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
6302 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
6303 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 6304
ca26824c
GM
63052012-06-30 Glenn Morris <rgm@gnu.org>
6306
2e4c5312
GM
6307 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
6308
ca26824c
GM
6309 * epaths.in (PATH_SITELOADSEARCH): New.
6310 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
6311 This is rather than relying on --enable-locallisppath elements
6312 having "site-lisp" in their names. (Bug#10208#25, 11658)
6313
0d23c240
EZ
63142012-06-30 Eli Zaretskii <eliz@gnu.org>
6315
c9240d7a
EZ
6316 * w32proc.c (sys_select): Accept and ignore one more argument.
6317
6318 * w32.c (emacs_gnutls_pull): Call select with one more argument.
6319
0d23c240 6320 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 6321 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
6322
6323 * sysdep.c: Don't include dos.h and dosfns.h.
6324
6325 * process.c (sys_select):
6326 * msdos.c (sys_select): Accept one more argument and ignore it.
6327
6328 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
6329 adapt data types and code to that.
6330
6331 * dosfns.c:
6332 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
6333 which clashes with the gnulib function of the same name.
6334
af5a5a98
AS
63352012-06-30 Andreas Schwab <schwab@linux-m68k.org>
6336
c5e4379c
AS
6337 * font.c (font_style_to_value, font_style_symbolic)
6338 (font_prop_validate_style): Add type checks for values in
6339 font_style_table.
6340
af5a5a98
AS
6341 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
6342 argument.
6343 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
6344 uses.
6345
8d38f461
EZ
63462012-06-29 Eli Zaretskii <eliz@gnu.org>
6347
2e5a6631
EZ
6348 * xdisp.c (try_window_id): Undo last change.
6349
8d38f461
EZ
6350 * w32.c (getwd): Adjust commentary about startup_dir.
6351 (init_environment): Always call sys_access, even in non-MSVC
6352 builds. Don't chdir to the directory of the Emacs executable.
6353 This undoes code from 1997 which was justified by the need to
6354 "avoid conflicts when removing and renaming directories". But its
6355 downside was that every relative file name was being interpreted
6356 relative to the directory of the Emacs executable, which can never
6357 be TRT. In particular, it broke sys_access when called with
6358 relative file names.
6359 (sys_access): Map GetLastError to errno.
6360
2af3565e
DA
63612012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6362
6363 * window.h (struct window): Change type of 'fringes_outside_margins'
6364 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 6365 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
6366 Adjust comment.
6367 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
6368 to ptrdiff_t.
6369
c8d3a25c 63702012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 6371
c8d3a25c
GM
6372 * gnutls.c (emacs_gnutls_handshake):
6373 Add QUIT to make the loop interruptible.
57570cd3 6374
c8d3a25c 63752012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 6376
c8d3a25c
GM
6377 * charset.c (init_charset): Make lack of etc/charsets fatal.
6378
3e984ee8
DA
63792012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6380
6381 * editfns.c (region_limit): Fix type mismatch.
6382
ef884f23
DA
63832012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
6384
6385 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
6386 undefined. Convert from xassert to eassert.
6387 * nsmenu.m: Convert from xassert to eassert.
6388 * nsterm.m: Likewise.
6389
7d7e0027
SM
63902012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
6391
6392 * editfns.c (region_limit): Clip to narrowing (bug#11770).
6393
aa754e6a
PE
63942012-06-28 Paul Eggert <eggert@cs.ucla.edu>
6395
6396 Avoid integer overflow on scroll-left and scroll-right.
6397 * window.c (HSCROLL_MAX): New macro.
6398 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
6399 overflow when requested scroll falls outside ptrdiff_t range.
6400
80b00b08
DA
64012012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6402
6403 * window.h (struct window): Change type of 'hscroll',
6404 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
6405 'last_modified' and 'last_overlay_modified' to EMACS_INT.
6406 Adjust users accordingly.
6407 * xdisp.c (try_cursor_movement): Replace type check with eassert.
6408 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
6409 from EMACS_INT to ptrdiff_t.
6410 (make_window): Omit redundant initialization.
6411
62b2bcf6
JB
64122012-06-28 Juanma Barranquero <lekktu@gmail.com>
6413
6414 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
6415
45942c7d
DA
64162012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6417
6418 * window.h (struct window): Change type of 'use_time' and
6419 'sequence_number' from Lisp_Object to int.
6420 * frame.c (make_frame): Adjust users accordingly.
6421 * print.c (print_object): Likewise.
6422 * window.c (select_window, Fwindow_use_time, make_parent_window)
6423 (make_window): Likewise.
6424
e509cfa6
DA
64252012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6426
6427 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
6428 enabled with --enable-checking=[all,glyphs] configure option.
6429 Fix GLYPH_DEBUG usage assuming that it may be undefined,
6430 adjust comments accordingly.
6431 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
6432 undefined, adjust comments accordingly.
6433 * image.c: Likewise.
6434 * scroll.c: Likewise.
6435 * w32fns.c: Likewise.
6436 * w32term.c: Likewise.
6437 * xdisp.c: Likewise.
6438 * xfaces.c: Likewise.
6439 * xfns.c: Likewise.
6440 * xterm.c: Likewise.
6441
a54e2c05
DA
64422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
6443
6444 Generalize run-time debugging checks.
6445 * dispextern.h (XASSERTS): Remove.
6446 * fontset.c (xassert): Remove.
6447 Convert from xassert to eassert.
6448 * alloc.c: Convert from xassert to eassert.
6449 * bidi.c: Likewise.
6450 * dispnew.c: Likewise.
6451 * fns.c: Likewise.
6452 * fringe.c: Likewise.
6453 * ftfont.c: Likewise.
6454 * gtkutil.c: Likewise.
6455 * image.c: Likewise.
6456 * keyboard.c: Likewise.
6457 * menu.c: Likewise.
6458 * process.c: Likewise.
6459 * scroll.c: Likewise.
6460 * sound.c: Likewise.
6461 * term.c: Likewise.
6462 * w32console.c: Likewise.
6463 * w32fns.c: Likewise.
6464 * w32term.c: Likewise.
6465 * window.c: Likewise.
6466 * xdisp.c: Likewise.
6467 * xfaces.c: Likewise.
6468 * xfns.c: Likewise.
6469 * xselect.c: Likewise.
6470 * xterm.c: Likewise.
6471
1ec4b7b2
SM
64722012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
6473
6474 * fns.c (maybe_resize_hash_table): Output message when growing the
6475 purify-hashtable.
6476
2014308a
DA
64772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6478
6479 * alloc.c (allocate_string_data): Remove dead code.
6480 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
6481 avoid GCC warning about unused macro.
6482
246155eb
DA
64832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6484
6485 * alloc.c (allocate_string): Omit intervals initialization.
6486 * alloc.c (make_uninit_multibyte_string): Initialize intervals
6487 as in make_pure_string and make_pure_c_string.
6488
43184b7b
DA
64892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6490
d209e2fb 6491 * alloc.c (allocate_string): Fix last change.
43184b7b 6492
3fe6dd74
DA
64932012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
6494
d209e2fb 6495 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
6496 to memset, add explicit initialization where appropriate.
6497
1ba6038a
GM
64982012-06-27 Glenn Morris <rgm@gnu.org>
6499
6500 * lisp.mk (lisp): Remove paths.elc.
6501
c89926a5
CY
65022012-06-27 Chong Yidong <cyd@gnu.org>
6503
6504 * doc.c (Fsubstitute_command_keys): Fix punctuation.
6505
ed6b3510
JW
65062012-06-26 John Wiegley <johnw@newartisans.com>
6507
1ec4b7b2 6508 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
6509 on Mac OS X Lion: __mod_init_func and __mod_term_func.
6510
ed6b3510
JW
6511 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
6512 when building with Clang.
6513
8edd4a2b
SM
65142012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
6515
6516 * eval.c (Fapply): Allow calling it with a single argument.
6517
f6f62d1b
EZ
65182012-06-26 Eli Zaretskii <eliz@gnu.org>
6519
6520 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
6521 _stricmp and _strnicmp.
6522 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
6523
62efea5e
DA
65242012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6525
6526 * alloc.c (allocate_window): Zero out non-Lisp part of newly
6527 allocated window.
6528 (allocate_process): Likewise for new process.
8edd4a2b 6529 (allocate_terminal): Change to use offsetof.
62efea5e
DA
6530 (allocate_frame): Likewise.
6531 * frame.c (make_frame): Omit redundant initialization.
6532 * window.c (make_parent_window): Use memset.
6533 (make_window): Omit redundant initialization.
6534 * process.c (make_process): Omit redundant initialization.
6535 * terminal.c (create_terminal): Likewise.
6536
42997f4d
DA
65372012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6538
6539 * term.c (delete_tty): Remove redundant call to memset.
6540
1130ecfc
DA
65412012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
6542
6543 * alloc.c: Remove build_string.
6544 * lisp.h: Define build_string as static inline. This provides
6545 a better opportunity to optimize away calls to strlen when the
6546 function is called with compile-time constant argument.
6547 * image.c (imagemagick_error): Convert to build_string.
6548 * w32proc.c (sys_spawnve): Likewise.
6549 * xterm.c (x_term_init): Likewise.
6550
cf38a720
PE
65512012-06-26 Paul Eggert <eggert@cs.ucla.edu>
6552
99027bdd
PE
6553 Use sprintf return value instead of invoking strlen on result.
6554 In the old days this wasn't portable, since some sprintf
6555 implementations returned char *. But they died out years ago and
6556 Emacs already assumes sprintf returns int.
6557 Similarly for float_to_string.
6558 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
6559 * ccl.c (ccl_driver):
6560 * character.c (string_escape_byte8):
6561 * data.c (Fnumber_to_string):
6562 * doprnt.c (doprnt):
6563 * print.c (print_object):
6564 * xdisp.c (message_dolog):
6565 * xfns.c (syms_of_xfns):
6566 Use sprintf or float_to_string result to avoid need to call strlen.
6567 * data.c (Fnumber_to_string):
6568 Use make_unibyte_string, since the string must be ASCII.
6569 * lisp.h, print.c (float_to_string): Now returns int length.
6570 * term.c (produce_glyphless_glyph):
6571 Use sprintf result rather than recomputing it.
6572
cf38a720
PE
6573 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
6574 * Makefile.in (ALL_CFLAGS):
6575 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
6576 * gmalloc.c, regex.c: Include <config.h> unconditionally.
6577
3511c784
DA
65782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6579
0a08eb21 6580 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
6581 strcasecmp if available.
6582 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
6583
fb7da12e
AS
65842012-06-25 Andreas Schwab <schwab@linux-m68k.org>
6585
6586 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
6587 Avoid comma operator.
6588 * menu.c (push_submenu_start, push_submenu_end)
6589 (push_left_right_boundary, push_menu_pane): Likewise.
6590 * msdos.c (dos_rawgetc): Likewise.
6591
afa2ffd8
DA
65922012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6593
6594 * xfns.c (xic_create_fontsetname): Remove redundant calls
6595 to memset.
6596
b3b4476b
PE
65972012-06-25 Paul Eggert <eggert@cs.ucla.edu>
6598
4495ff38
PE
6599 * gtkutil.c (get_utf8_string): Remove redundant assignment.
6600 sprintf already null-terminates its output.
6601
b3b4476b
PE
6602 * xfns.c (x_window): Remove redundant cast.
6603
b00876c9
DA
66042012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
6605
6606 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
6607 `const char *' to `char *' to avoid compiler warning.
6608
d188e26b
PE
66092012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6610
885d1d74
PE
6611 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
6612 instead of truncating it to 63 (admittedly a generous limit).
6613
d188e26b
PE
6614 * process.c: Fix spelling and caps in comments.
6615
e2f560b1
DN
66162012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
6617
e86db54b 6618 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
6619 * sysdep.c (setpgrp): Remove definition, not used in this file.
6620
7583a3a1
JB
66212012-06-24 Juanma Barranquero <lekktu@gmail.com>
6622
6623 * makefile.w32-in: Update dependencies.
6624
696056c2
EZ
66252012-06-24 Eli Zaretskii <eliz@gnu.org>
6626
6627 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
6628 (SYSTIME_H): Add nt/inc/sys/time.h.
6629
6630 * systime.h [WINDOWSNT]: Include sys/time.h.
6631
6632 * s/ms-w32.h (struct timespec): Definition moved from
6633 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
6634
845ca893
PE
66352012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6636
6637 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
6638 * buffer.h (buffer_slot_type_mismatch):
6639 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6640 * eval.c (unwind_to_catch):
6641 * image.c (my_png_error, my_error_exit):
6642 * keyboard.c (quit_throw_to_read_char, user_error)
6643 (Fexit_recursive_edit, Fabort_recursive_edit):
6644 * lisp.h (die, args_out_of_range, args_out_of_range_3)
6645 (wrong_type_argument, buffer_overflow, __executable_start)
6646 (memory_full, buffer_memory_full, string_overflow, Fthrow)
6647 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
6648 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
6649 (fatal):
6650 (child_setup) [!DOS_NT]:
6651 * lread.c (end_of_file_error, invalid_syntax):
6652 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
6653 * puresize.h (pure_write_error):
6654 * search.c (matcher_overflow):
6655 * sound.c (sound_perror, alsa_sound_perror):
6656 * sysdep.c, syssignal.h (croak):
6657 * term.c (maybe_fatal, vfatal):
6658 * textprop.c (text_read_only):
6659 * undo.c (user_error):
6660 * unexmacosx.c (unexec_error):
6661 * xterm.c (x_ins_del_lines, x_delete_glyphs):
6662 Use _Noreturn rather than NO_RETURN.
6663 No need for separate decl merely because of _Noreturn.
6664 * sound.c (sound_warning, parse_sound):
6665 Remove unnecessary forward decls.
6666
f1dd8073
PE
66672012-06-24 Paul Eggert <eggert@cs.ucla.edu>
6668
6669 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
6670 * lisp.h (WAIT_READING_MAX): New macro.
6671 * dispnew.c (Fsleep_for, sit_for):
6672 * keyboard.c (kbd_buffer_get_event):
6673 * process.c (Faccept_process_output):
6674 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
6675 This improves on the previous patch, which introduced a bug
6676 when time_t is unsigned and as wide as intmax_t.
6677 See <http://bugs.gnu.org/9000#51>.
6678
b82c1755
EZ
66792012-06-23 Eli Zaretskii <eliz@gnu.org>
6680
6681 * dispnew.c (sit_for, Fsleep_for):
6682 * keyboard.c (kbd_buffer_get_event):
6683 * process.c (Faccept_process_output): Avoid compiler warnings when
6684 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
6685
ca300656
JB
66862012-06-23 Juanma Barranquero <lekktu@gmail.com>
6687
049ec95b
JB
6688 * makefile.w32-in: Update dependencies.
6689
ca300656
JB
6690 * w32.c (ltime): Add return type and declare static.
6691 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
6692
db7b8d06
PE
66932012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6694
6695 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
6696 Privately reported by Herbert J. Skuhra.
6697 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
6698 All uses changed.
6699 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
6700 not make_lisp_timeval, when the argument is of type EMACS_TIME.
6701
0bd8297f
EZ
67022012-06-23 Eli Zaretskii <eliz@gnu.org>
6703
96512555
EZ
6704 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
6705 last argument of make_unibyte_string.
6706
0bd8297f
EZ
6707 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
6708 language ID in the event parameters.
6709
6710 * w32term.c (w32_read_socket): Put the new keyboard codepage into
6711 event.code, not the obscure "character set ID".
6712
63def6b6
CY
67132012-06-23 Chong Yidong <cyd@gnu.org>
6714
6715 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
6716
e8a02204
EZ
67172012-06-23 Eli Zaretskii <eliz@gnu.org>
6718
388cdec0
EZ
6719 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
6720 * w32.c (fdutimens): New function.
6721
6722 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
6723
6724 * s/ms-w32.h (pselect): Redirect to sys_select.
6725
6726 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
6727
e8a02204
EZ
6728 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
6729 in the logic of incrementing and decrementing the value of
6730 use_relocatable_buffers.
6731
d054f3fb
PE
67322012-06-23 Paul Eggert <eggert@cs.ucla.edu>
6733
6734 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
6735 Privately reported by Herbert J. Skuhra.
6736 [__FreeBSD__]: Remove "*/" typo after "#include".
6737 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
6738 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
6739 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
6740 Don't assume EMACS_TIME and struct timeval are the same type.
6741
d35af63c
PE
67422012-06-22 Paul Eggert <eggert@cs.ucla.edu>
6743
6744 Support higher-resolution time stamps (Bug#9000).
6745 The time stamps are only nanosecond-resolution at the C level,
6746 since that's the best that any real-world system supports now.
6747 But they are picosecond-resolution at the Lisp level, as that's
6748 easy, and leaves room for future OS improvements.
6749
6750 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
6751 (LIBES): Use it.
6752
6753 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
6754 Don't get current time unless it's needed.
6755
6756 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
6757 now provides it if it's absent.
6758 (start_atimer): Port to higher-res time stamps.
6759 Check for time stamp overflow. Don't get current time more
6760 often than is needed.
6761
6762 * buffer.h (struct buffer): Buffer modtime now has high resolution.
6763 Include systime.h, not time.h.
6764 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
6765
6766 * dired.c: Include stat-time.h.
6767 (Ffile-attributes): File times now have higher resolution.
6768
6769 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
6770 (struct image): Timestamp now has higher resolution.
6771
6772 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
6773 has at least microseconds now. All uses removed.
6774 (update_frame, update_single_window, update_window, update_frame_1)
6775 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 6776 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
6777
6778 * editfns.c (time_overflow): Now extern.
6779 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
6780 (float-time, Fformat_time_string, Fcurrent_time_string)
6781 (Fcurrent_time_zone): Accept and generate higher-resolution
6782 time stamps.
6783 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
6784 (decode_time_components, lisp_seconds_argument): New functions.
6785 (make_time): Now static.
6786 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
6787 Report an error if the time is invalid, rather than having the caller
6788 do that.
6789
6790 * fileio.c: Include <stat-time.h>
6791 (Fcopy_file): Copy higher-resolution time stamps.
6792 Prefer to set the time stamp via a file descriptor if that works.
6793 (Fset_file_times, Finsert_file_contents, Fwrite_region)
6794 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
6795 (Fvisited_file_modtime, Fset_visited_file_modtime):
6796 Support higher-resolution time stamps.
6797
6798 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
6799
6800 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
6801
6802 * image.c (prepare_image_for_display, clear_image_cache)
6803 (lookup_image): Port to higer-resolution time stamps.
6804
6805 * keyboard.c (start_polling, bind_polling_period):
6806 Check for time stamp overflow.
6807 (read_char, kbd_buffer_get_event, timer_start_idle)
6808 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
6809 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
6810 Port to higher-resolution time stamps. Do not assume time_t is signed.
6811 (decode_timer): New function. Timers are now vectors of length 9,
6812 not 8, to accommodate the picosecond component.
6813 (timer_check_2): Use it.
6814
6815 * nsterm.m (select_timeout, timeval_subtract): Remove.
6816 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
6817 as they're a bit more accurate and handle overflow better.
6818 (ns_select): Change prototype to be compatible with pselect.
6819 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
6820 * nsterm.h (ns_select): Adjust prototype.
6821
6822 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
6823 us-resolution time stamps.
6824 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
6825
6826 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
6827
6828 * lisp.h (time_overflow): New decl.
6829 (wait_reading_process_output): First arg is now intmax_t, not int,
6830 to accommodate larger waits.
6831
6832 * process.h (struct Lisp_Process.read_output_delay):
6833 Now counts nanoseconds, not microseconds.
6834 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
6835 EMACS_HAS_USECS.
6836 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
6837 (wait_reading_process_output):
6838 Port to ns-resolution time stamps.
6839 (Faccept_process_output, wait_reading_process_output):
6840 Check for time stamp overflow. Do not assume time_t is signed.
6841 (select_wrapper): Remove; we now use pselect.
6842 (Fprocess_attributes): Now generates ns-resolution time stamps.
6843
6844 * sysdep.c: Include utimens.h. Don't include utime.h
6845 or worry about struct utimbuf; gnulib does that for us now.
6846 (gettimeofday): Remove; gnulib provides a substitute.
6847 (make_timeval): New function.
6848 (set_file_times): Now sets ns-resolution time stamps.
6849 New arg FD; all uses changed.
6850 (time_from_jiffies, ltime_from_jiffies, get_up_time)
6851 (system_process_attributes):
6852 Now returns ns-resolution time stamp. All uses changed.
6853 Check for time stamp overflow.
6854
6855 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
6856 provides a substitute now.
6857
6858 * systime.h: Include timespec.h rather than sys/time.h and time.h,
6859 since it guarantees struct timespec.
6860 (EMACS_TIME): Now struct timespec, so that we can support
6861 ns-resolution time stamps.
6862 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
6863 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
6864 (EMACS_USECS): Remove.
6865 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
6866 so multiply the arg by 1000 before storing it.
6867 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
6868 New macros.
6869 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
6870 Port to ns-resolution time stamps.
6871 (EMACS_TIME_NEG_P): Remove; replaced by....
6872 (EMACS_TIME_SIGN): New macro.
6873 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
6874 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
6875 (set_file_times, make_time, lisp_time_argument): Adjust signature.
6876 (make_timeval, make_lisp_time, decode_time_components): New decls.
6877 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
6878 that it mishandled time_t overflow. You can't compare by subtracting!
6879 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
6880 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
6881
6882 * term.c: Include <sys/time.h>.
6883 (timeval_to_Time): New function, for proper overflow wraparound.
6884 (term_mouse_position, term_mouse_click): Use it.
6885
6886 * undo.c (record_first_change): Support higher-resolution time stamps
6887 in the undo buffer.
6888 (Fprimitive_undo): Use them when restoring time stamps.
6889
6890 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
6891 (w32_get_internal_run_time):
6892 Port to higher-resolution Emacs time stamps.
6893 (ltime): Now accepts single 64-bit integer, as that's more convenient
6894 for callers.
6895
6896 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
6897
6898 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
6899 for compatibility with pselect. Support ns-resolution time stamps.
6900
6901 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
6902
6903 * xselect.c (wait_for_property_change, x_get_foreign_selection):
6904 Check for time stamp overflow, and support ns-resolution time stamps.
6905
6906 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
6907 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
6908 (timeval_subtract): Remove; no longer needed.
6909 (XTflash, XTring_bell, x_wait_for_event):
6910 Port to ns-resolution time stamps. Don't assume time_t is signed.
6911
b6a92dfe
CY
69122012-06-22 Chong Yidong <cyd@gnu.org>
6913
6914 * xdisp.c (x_consider_frame_title): Revert last change.
6915
d251c37c
EZ
69162012-06-22 Eli Zaretskii <eliz@gnu.org>
6917
6918 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6919 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6920 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6921 staticidx goes up to 1597 out of 1600 = 0x640.)
6922
f10deafb
PE
69232012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6924
6925 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6926 Otherwise, the umask might be mistakenly 0 while handling input signals.
6927
ec6de1e2
SM
69282012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6929
6930 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6931
28be1ada
DA
69322012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6933
6934 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6935 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6936 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6937 access to `contents' member of Lisp_Vector objects with AREF and ASET
6938 where appropriate.
6939
c6bf3022
CY
69402012-06-19 Chong Yidong <cyd@gnu.org>
6941
6942 * frame.c (delete_frame): When selecting a frame on a different
6943 text terminal, do not alter the terminal's top-frame.
6944
6945 * xdisp.c (format_mode_line_unwind_data): Record the target
6946 frame's selected window and its terminal's top-frame.
6947 (unwind_format_mode_line): Restore them.
6948 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6949 Callers changed.
6950 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6951 since tty frames can be explicitly named.
6952 (prepare_menu_bars): Likewise.
6953
6954 * term.c (Ftty_top_frame): New function.
6955
defd4196
PE
69562012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6957
6958 Port byte-code-meter to modern targets.
6959 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6960 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6961 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6962 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6963 (METER_1, METER_2): Simplify.
6964
1053a871
SM
69652012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6966
6967 * data.c (Fdefalias): Return `symbol' (bug#11686).
6968
b7e8d081
MR
69692012-06-18 Martin Rudalics <rudalics@gmx.at>
6970
6971 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6972 gets killed during executing of this function (Bug#11665).
6973 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6974 (Vkill_buffer_query_functions): In doc-string say that functions
6975 run by this hook should not change the current buffer.
6976
7ea2b339
PE
69772012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6978
6979 Fix recently-introduced process.c problems found by static checking.
6980 * process.c (write_queue_push, write_queue_pop, send_process):
6981 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6982 (write_queue_pop): Fix pointer signedness problem.
6983 (send_process): Remove unused local.
6984
96a313a1
CY
69852012-06-17 Chong Yidong <cyd@gnu.org>
6986
6987 * xdisp.c (redisplay_internal): No need to redisplay terminal
6988 frames that are not on top.
6989
20ca2e94
TN
69902012-06-17 Troels Nielsen <bn.troels@gmail.com>
6991
6992 * process.c (make_process): Initialize write_queue.
6993 (write_queue_push, write_queue_pop): New functions.
6994 (send_process): Use them to maintain correct ordering of process
6995 writes (Bug#10815).
6996
9a900ca9
PE
69972012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6998
310fbfa8
PE
6999 * lisp.h (eassert): Assume C89 or later.
7000 This removes the need for CHECK.
7001 (CHECK): Remove. Its comments about always evaluating its
7002 argument were confusing, as 'eassert' typically does not evaluate
7003 its argument.
7004
27bb1ca4
PE
7005 * coding.c (produce_chars): Use ptrdiff_t, not int.
7006
9a900ca9
PE
7007 * xterm.c (x_draw_underwave): Check for integer overflow.
7008 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
7009
41b7f8bc 70102012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
7011
7012 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
7013 referenced (Bug#11583).
7014
9b0e3eba
AA
70152012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
7016
7017 Implement wave-style variant of underlining.
7018 * dispextern.h (face_underline_type): New enum.
7019 (face): Add field for underline type.
7020 * nsterm.m (ns_draw_underwave): New function.
7021 (ns_draw_text_decoration): Use it.
7022 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
7023 New functions.
7024 (x_draw_glyph_string): Use them.
7025 * xfaces.c (Qline, Qwave): New Lisp objects.
7026 (check_lface_attrs, merge_face_ref)
1053a871
SM
7027 (Finternal_set_lisp_face_attribute, realize_x_face):
7028 Handle wave-style underline face attributes.
9b0e3eba
AA
7029 * xterm.c (x_draw_underwave): New function.
7030 (x_draw_glyph_string): Use it.
7031
0fb52f11
JB
70322012-06-16 Juanma Barranquero <lekktu@gmail.com>
7033
7034 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
7035 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
7036 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
7037 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
7038 ($(BLD)/w32select.$(O)): Update dependencies.
7039
e5560ff7
AS
70402012-06-16 Andreas Schwab <schwab@linux-m68k.org>
7041
7042 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
7043 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
7044 * character.c (_fetch_multibyte_char_p): Remove.
7045 * alloc.c: Include "character.h" before "buffer.h".
7046 * bidi.c: Likewise.
7047 * buffer.c: Likewise.
7048 * bytecode.c: Likewise.
7049 * callint.c: Likewise.
7050 * callproc.c: Likewise.
7051 * casefiddle.c: Likewise.
7052 * casetab.c: Likewise.
7053 * category.c: Likewise.
7054 * cmds.c: Likewise.
7055 * coding.c: Likewise.
7056 * composite.c: Likewise.
7057 * dired.c: Likewise.
7058 * dispnew.c: Likewise.
7059 * doc.c: Likewise.
7060 * dosfns.c: Likewise.
7061 * editfns.c: Likewise.
7062 * emacs.c: Likewise.
7063 * fileio.c: Likewise.
7064 * filelock.c: Likewise.
7065 * font.c: Likewise.
7066 * fontset.c: Likewise.
7067 * fringe.c: Likewise.
7068 * indent.c: Likewise.
7069 * insdel.c: Likewise.
7070 * intervals.c: Likewise.
7071 * keyboard.c: Likewise.
7072 * keymap.c: Likewise.
7073 * lread.c: Likewise.
7074 * macros.c: Likewise.
7075 * marker.c: Likewise.
7076 * minibuf.c: Likewise.
7077 * nsfns.m: Likewise.
7078 * nsmenu.m: Likewise.
7079 * print.c: Likewise.
7080 * process.c: Likewise.
7081 * regex.c: Likewise.
7082 * region-cache.c: Likewise.
7083 * search.c: Likewise.
7084 * syntax.c: Likewise.
7085 * term.c: Likewise.
7086 * textprop.c: Likewise.
7087 * undo.c: Likewise.
7088 * unexsol.c: Likewise.
7089 * w16select.c: Likewise.
7090 * w32fns.c: Likewise.
7091 * w32menu.c: Likewise.
7092 * window.c: Likewise.
7093 * xdisp.c: Likewise.
7094 * xfns.c: Likewise.
7095 * xmenu.c: Likewise.
7096 * xml.c: Likewise.
7097 * xselect.c: Likewise.
7098
2f07e6af
EZ
70992012-06-16 Eli Zaretskii <eliz@gnu.org>
7100
1053a871
SM
7101 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
7102 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 7103 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
7104 row.
7105 (handle_face_prop): Use chunk-relative overlay string index when
7106 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
7107 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
7108 the rightmost. (Bug#11720)
2f07e6af 7109
29b83cec
AS
71102012-06-16 Andreas Schwab <schwab@linux-m68k.org>
7111
7112 * category.h (CHAR_HAS_CATEGORY): Define as inline.
7113 (CATEGORY_MEMBER): Enforce 1/0 value.
7114 * category.c (_temp_category_set): Remove.
7115
4c5501e9
EZ
71162012-06-16 Eli Zaretskii <eliz@gnu.org>
7117
7118 * window.c (Fdelete_other_windows_internal)
7119 (Fdelete_window_internal): Don't access frame's mouse highlight
7120 info of the initial frame. (Bug#11677)
7121
2b570124
PE
71222012-06-14 Paul Eggert <eggert@cs.ucla.edu>
7123
e93864f9
PE
7124 * .gdbinit (xgetint): Fix recently-introduced paren typo.
7125 Assume USE_2_TAGS_FOR_INTS.
7126 (xreload): Adjust $tagmask width to match recent lisp.h change.
7127
2b570124
PE
7128 Simplify lisp.h in minor ways that should not affect code.
7129 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
7130 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
7131 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
7132 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
7133 (INTTYPEBITS): New macro, for clarity.
7134 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
7135 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
7136 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
7137 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
7138 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
7139
81755f69
JB
71402012-06-13 Juanma Barranquero <lekktu@gmail.com>
7141
7142 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
7143
16192a57
GM
71442012-06-13 Glenn Morris <rgm@gnu.org>
7145
7146 * s/bsd-common.h (BSD4_3):
7147 * s/usg5-4-common.h (USG5_4): No longer define; unused.
7148
646b5f55
AS
71492012-06-13 Andreas Schwab <schwab@linux-m68k.org>
7150
7151 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
7152 instead of union.
7153 (XLI, XIL): Define.
1053a871
SM
7154 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
7155 Use them.
7156 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 7157 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 7158 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
7159 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
7160 * frame.c (delete_frame): Remove outdated comment.
7161 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
7162 USE_LISP_UNION_TYPE.
7163 (Fw32_unregister_hot_key): Likewise.
7164 (Fw32_toggle_lock_key): Likewise.
7165 * w32menu.c (add_menu_item): Likewise.
7166 (w32_menu_display_help): Use XIL instead of checking
7167 USE_LISP_UNION_TYPE.
7168 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
7169 (init_heap): Likewise.
7170 * w32term.c (w32_read_socket): Update comment.
7171
1d3823c9
GM
71722012-06-13 Glenn Morris <rgm@gnu.org>
7173
c62ff706
GM
7174 * s/usg5-4-common.h, src/s/unixware.h:
7175 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
7176
1d3823c9
GM
7177 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
7178
bfe3e0a2
PE
71792012-06-13 Paul Eggert <eggert@cs.ucla.edu>
7180
7181 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
7182 * alloc.c (make_number) [!defined make_number]:
7183 Remove, as lisp.h always defines this now.
7184 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
7185 (roundup_size): Verify that it is a power of 2.
7186 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
7187 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
7188 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
7189 -DUSE_LSB_TAG=0, to override the automatically-selected default.
7190 USE_LSB_TAG now is always defined to be either 0 or 1.
7191 All uses changed.
7192 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
7193 code works fine either way, and efficiency is not a concern here,
7194 as the union type is for debugging, not for production.
7195 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
7196 Use an inline function on all platforms when using the union type,
7197 since this is simpler and 'static inline' can be used portably
7198 within Emacs now.
7199 (LISP_INITIALLY_ZERO): New macro.
7200 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
7201 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
7202
45fa9c0f
GM
72032012-06-12 Glenn Morris <rgm@gnu.org>
7204
b4492cba
GM
7205 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
7206
7207 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 7208
45fa9c0f
GM
7209 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
7210 Move BROKEN_SIGIO to configure.
7211
7212 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
7213 Move NO_TERMIO to configure.
7214
0e25d334
CY
72152012-06-12 Chong Yidong <cyd@gnu.org>
7216
7217 * image.c (imagemagick_load_image): Use MagickFlattenImage if
7218 MagickMergeImageLayers is undefined. Use pixel pusher loop if
7219 MagickExportImagePixels is undefined.
7220
43682bb6
PE
72212012-06-12 Paul Eggert <eggert@cs.ucla.edu>
7222
7223 * image.c (imagemagick_load_image): Remove unused label.
7224
a9be7d2b
GM
72252012-06-11 Glenn Morris <rgm@gnu.org>
7226
7227 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
7228 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
7229 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
7230 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
7231
3017f87f
SM
72322012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
7233
7234 * alloc.c (make_byte_code): New function.
7235 (Fmake_byte_code): Use it. Don't purify here.
7236 * lread.c (read1): Use it as well to avoid extra allocation.
7237
1b9b4cf4
CY
72382012-06-11 Chong Yidong <cyd@gnu.org>
7239
7240 * image.c (imagemagick_load_image): Implement transparency.
7241
95988fcf
AS
72422012-06-10 Andreas Schwab <schwab@linux-m68k.org>
7243
7244 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
7245 account for preceding backslashes. (Bug#11663)
7246
cd4eb164
CY
72472012-06-09 Chong Yidong <cyd@gnu.org>
7248
7249 * term.c: Support italics in capable terminals (Bug#9652).
7250 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
7251 (turn_on_face): Output using TS_enter_italic_mode if available.
7252 Don't handle unused blinking and alt-charset cases.
7253 (turn_off_face): Handle italic case; discard unused tty_blinking_p
7254 and tty_alt_charset_p cases.
7255 (tty_capable_p, init_tty): Support italics.
7256
7257 * termchar.h (struct tty_display_info): Add field for italics.
7258 Remove unused blink field.
7259
7260 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
7261 Handle slant.
7262
7263 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
7264 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
7265 tty_alt_charset_p. Add tty_italic_p.
7266
ff88beb8
MA
72672012-06-09 Michael Albinus <michael.albinus@gmx.de>
7268
7269 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
7270 dbus_type_is_basic if available.
7271 (xd_extract_signed, xd_extract_unsigned): Rename from
7272 extract_signed and extract_unsigned, respectively. Adapt callers.
7273
44286096
CY
72742012-06-09 Chong Yidong <cyd@gnu.org>
7275
1682701f
CY
7276 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
7277
44286096
CY
7278 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
7279 case (Bug#9752).
7280
d86feb17
PE
72812012-06-08 Paul Eggert <eggert@cs.ucla.edu>
7282
7283 * xdisp.c (vmessage): Treat frame message as multibyte.
7284 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
7285 would generate the diagnostic "Making \302\247 buffer-local while
7286 let-bound!".
7287
d5c20fe8
EZ
72882012-06-08 Eli Zaretskii <eliz@gnu.org>
7289
7290 * dispnew.c (showing_window_margins_p): Undo last change, which
7291 was done due to an inadvertent commit.
7292 (adjust_frame_glyphs_for_frame_redisplay): Do call
7293 showing_window_margins_p.
7294
513749ee
SM
72952012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
7296
7297 * eval.c (Fmake_var_non_special): New primitive.
7298 (syms_of_eval): Defsubr it.
7299 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
7300
d4a8f5c1
JB
73012012-06-08 Juanma Barranquero <lekktu@gmail.com>
7302
7303 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
7304 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
7305
8bbbc977
EZ
73062012-06-08 Eli Zaretskii <eliz@gnu.org>
7307
7308 * alloc.c (allocate_vectorlike): Fix last change.
7309
f3372c87
DA
73102012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
7311
7312 Block-based vector allocation of small vectors.
7313 * lisp.h (struct vectorlike_header): New field `nbytes',
7314 adjust comment accordingly.
7315 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 7316 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
7317 mark_maybe_pointer, valid_lisp_object_p) accordingly.
7318 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
7319 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
7320 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
7321 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
7322 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
7323 (roundup_size): New constant.
7324 (struct vector_block): New data type.
7325 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 7326 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
7327 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
7328 (sweep_vectors): New functions.
7329 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 7330 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
7331 or equal to VBLOCK_BYTES_MAX.
7332 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
7333 (init_alloc_once): Add call to init_vectors.
7334
4f18a4ed
SM
73352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
7336
7337 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
7338
86f158bc
PE
73392012-06-07 Paul Eggert <eggert@cs.ucla.edu>
7340
7341 * doprnt.c (doprnt): Truncate multibyte char correctly.
7342 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
7343 would mishandle a string argument "Xc" if X was a multibyte
7344 character of length 2: it would truncate after X's first byte
7345 rather than including all of X.
7346
c5cfcbe0
CY
73472012-06-06 Chong Yidong <cyd@gnu.org>
7348
7349 * buffer.c (word_wrap): Doc fix.
7350
c05cf390
PE
73512012-06-04 Paul Eggert <eggert@cs.ucla.edu>
7352
7353 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
7354
0c3461de
GM
73552012-06-03 Glenn Morris <rgm@gnu.org>
7356
7357 * xdisp.c (tool-bar-style): Doc fix.
7358
c71232db
UM
73592012-06-03 Ulrich Müller <ulm@gentoo.org>
7360
7361 * Makefile.in (PAXCTL): Define.
7362 (temacs$(EXEEXT)): Disable memory randomization for the temacs
7363 binary via PaX flags if the paxctl utility is available.
7364 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
7365 Restore PaX flags to their default. (Bug#11398)
7366
383f7350
CY
73672012-06-03 Chong Yidong <cyd@gnu.org>
7368
7369 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
7370 buffer (Bug#11226).
7371
5f2c76c6
CY
73722012-06-03 Chong Yidong <cyd@gnu.org>
7373
7374 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
7375 (note_mode_line_or_margin_highlight): If there is no help echo,
7376 use mode-line-default-help-echo. Handle the case where the mouse
7377 position is past the end of the mode line string.
7378
7379 * buffer.c (buffer_local_value_1): New function, split from
7380 Fbuffer_local_value; can return Qunbound.
7381 (Fbuffer_local_value): Use it.
7382 (Vmode_line_format): Docstring tweaks.
7383
773d47f6
PE
73842012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7385
7386 * sysdep.c (system_process_attributes): Improve comment.
7387
f2d6a3df
SM
73882012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
7389
7390 * keyboard.c: Export real-this-command to Elisp.
7391 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
7392 and DEFVAR it. Update all users.
7393
63810350
PE
73942012-06-02 Paul Eggert <eggert@cs.ucla.edu>
7395
7bd5c1f4
PE
7396 * minibuf.c (Fassoc_string): Remove duplicate declaration.
7397
63810350
PE
7398 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
7399 Convert pctcpu and pctmem to Lisp float properly.
7400 Let the compiler fold better, as 100.0/0x8000 is exact.
7401
a2821611
AS
74022012-06-02 Andreas Schwab <schwab@linux-m68k.org>
7403
7404 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
7405 cons_block.
7406
5fceba1d
PE
74072012-06-01 Paul Eggert <eggert@cs.ucla.edu>
7408
7409 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
7410
c98ff5dd
DA
74112012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
7412
7413 For a 'struct window', replace some Lisp_Object fields to
7414 bitfields where appropriate, remove unused fields.
7415 * window.h (struct window): Remove unused 'last_mark_x' and
7416 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
7417 change it's type from Lisp_Object to bitfield.
7418 Change type of 'force_start', 'optional_new_start',
7419 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 7420 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 7421
ca34e0be
PE
74222012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7423
7424 Pacify gcc -Wdouble-precision when using Xaw.
7425 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
7426 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
7427 Use 'float' consistently, rather than 'float' in most places
7428 and 'double' in a couple of places.
7429
efc00ab1 74302012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
7431
7432 * xdisp.c (handle_stop): Detect whether we have overlay strings
7433 loaded by testing it->current.overlay_string_index to be
7434 non-negative, instead of checking whether n_overlay_strings is
7435 positive. (Bug#11587)
7436
efc00ab1 74372012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
7438
7439 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
7440
7441 * doc.c (Fsubstitute_command_keys): Doc fix.
7442
efc00ab1 74432012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
7444
7445 * search.c (search_buffer): Remove calls to
7446 r_alloc_inhibit_buffer_relocation, as it is now called by
7447 maybe_unify_char, which was the cause of relocation of buffer text
7448 in bug#11519.
7449
efc00ab1 74502012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
7451
7452 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
7453 for the duration of call to load_charset, to avoid problems with
7454 callers of maybe_unify_char that access buffer text through C
7455 pointers.
7456
7457 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
7458 decrement the inhibition flag, instead of just setting or
7459 resetting it.
7460
ba93a187
PE
74612012-05-31 Paul Eggert <eggert@cs.ucla.edu>
7462
7463 Remove obsolete '#define static' cruft.
7464 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
7465 This #undef was "temporary" in 2000; it is no longer needed
7466 now that '#define static' has gone away.
7467 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
7468 (gray_bitmap_bits): Remove; no longer needed.
7469 All uses replaced with definiens.
7470 * xterm.c: Include "bitmaps/gray.xbm".
7471
9e4bf381
PE
74722012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7473
7474 Clean up __executable_start, monstartup when --enable-profiling.
7475 The following changes affect the code only when profiling.
7476 * dispnew.c (__executable_start): Rename from safe_bcopy.
7477 Define only on platforms that need it.
7478 * emacs.c: Include <sys/gmon.h> when profiling.
7479 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
7480 (__executable_start): Remove decl, since lisp.h does it now.
7481 (safe_bcopy): Remove decl; no longer has that name.
7482 (main): Coalesce #if into single bit of code, for simplicity.
7483 Cast pointers to uintptr_t, since standard libraries want integers
7484 and not pointers.
7485 * lisp.h (__executable_start): New decl.
7486
32d72c2f
GM
74872012-05-31 Glenn Morris <rgm@gnu.org>
7488
7489 * image.c (Fimagemagick_types): Doc fix.
7490
baac5bc7
JM
74912012-05-30 Jim Meyering <meyering@redhat.com>
7492
7493 * callproc.c (Fcall_process_region): Include directory component
7494 in mkstemp error message (Bug#11586).
7495
72cb32cf
PE
74962012-05-30 Paul Eggert <eggert@cs.ucla.edu>
7497
7498 * alloc.c, lisp.h (make_pure_vector): Now static.
7499
61b108cc
SM
75002012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
7501
7502 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
7503 Move to byte-run.el.
7504 (Fautoload): Do the hash-doc more carefully.
7505 * data.c (Fdefalias): Purify definition, except for keymaps.
7506 (Qdefun): Move from eval.c.
7507 * lisp.h (Qdefun): Remove.
7508 * lread.c (read1): Tiny simplification.
7509
471fe23d
TN
75102012-05-29 Troels Nielsen <bn.troels@gmail.com>
7511
934f3f58 7512 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
7513 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
7514 Bug#9642, but explicitly check that the buffer the overlay would
7515 be moved to is live and rearrange lines to make sure that errors
7516 will not put the overlay in an inconsistent state.
7517 (Fdelete_overlay): Cosmetics.
7518
85d0efd1
EZ
75192012-05-28 Eli Zaretskii <eliz@gnu.org>
7520
7521 * w32term.c (my_bring_window_to_top): New function.
7522 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
7523 could be different from the original one.
7524 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
7525 (Bug#11513)
7526
7527 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
7528 by calling BringWindowToTop.
7529
7530 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
7531 (WM_EMACS_END): Increase by one.
7532
da92a98c
PE
75332012-05-28 Paul Eggert <eggert@cs.ucla.edu>
7534
7535 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
7536 This avoids undefined behavior that might cause the eassert
7537 to not catch an out-of-range value.
7538
74d1f848
JB
75392012-05-28 Juanma Barranquero <lekktu@gmail.com>
7540
7541 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
7542 Update dependencies.
7543
9e1a06fc
EZ
75442012-05-27 Eli Zaretskii <eliz@gnu.org>
7545
7546 * bidi.c (bidi_mirror_char): Fix last change.
7547
f3dd7312
AS
75482012-05-27 Andreas Schwab <schwab@linux-m68k.org>
7549
7550 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
7551 when referring to sectname field in printf format.
7552
81899c91
PE
75532012-05-27 Paul Eggert <eggert@cs.ucla.edu>
7554
57b81a9f
PE
7555 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
7556 Only r_alloc_inhibit_buffer_relocation needed to be added;
7557 the others were already declared.
7558
81899c91
PE
7559 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
7560 before checking whether it's out of range. Put the check inside
7561 eassert. See
7562 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
7563
33017faf 75642012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
7565
7566 * callproc.c (Fcall_process): Restore a line that was accidentally
7567 commented out in the 2011-02-13 change (bug#11547).
7568
33017faf 75692012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
7570
7571 * lisp.h [REL_ALLOC]: Add prototypes for external functions
7572 defined on ralloc.c.
7573
7574 * buffer.c [REL_ALLOC]: Remove prototypes of
7575 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
7576 they are now on lisp.h.
7577
7578 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
7579
7580 * search.c (search_buffer): Use it to inhibit relocation of buffer
7581 text while re_search_2 is doing its job, because re_search_2 is
7582 passed C pointers to buffer text. (Bug#11519)
7583
23415acf
EZ
7584 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
7585 Update value to 24.
7586
44e27368
EZ
7587 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
7588 state after an additional call to move_it_in_display_line_to, keep
7589 the values of it->max_ascent and it->max_descent found for the
7590 entire line.
7591 (pos_visible_p): Revert the comparison against bottom_y to what it
7592 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
7593 (Bug#11464)
7594
c1892f11
PE
75952012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7596
7597 Fix coding-related core dumps with gcc -ftrapv.
7598 The code was computing A - B, where A and B are pointers, and B is
7599 random garbage. This can lead to core dumps on platforms that
7600 have special pointer registers, and it also leads to core dumps on
7601 x86-64 when compiled with gcc -ftrapv. The fix is to compute
7602 A - B only when B is initialized properly.
7603 * coding.c (coding_set_source, coding_set_destination): Return void.
7604 (coding_change_source, coding_change_destinations): New functions,
7605 with the old behaviors of coding_set_source and coding_set_destination.
7606 All callers that need an offset changed to use these new functions.
7607
eb7afdad
GM
76082012-05-26 Glenn Morris <rgm@gnu.org>
7609
7610 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
7611
f12fdf02
EZ
76122012-05-26 Eli Zaretskii <eliz@gnu.org>
7613
53a63be6 7614 Extend mouse support on W32 text-mode console.
61b108cc
SM
7615 * xdisp.c (draw_row_with_mouse_face):
7616 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 7617
eb3f6f01 7618 * w32console.c: Include window.h.
61b108cc
SM
7619 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
7620 New functions.
eb3f6f01
EZ
7621 (initialize_w32_display): Initialize mouse-highlight data.
7622
53a63be6
EZ
7623 * w32inevt.c: Include termchar.h and window.h.
7624 (do_mouse_event): Support mouse-autoselect-window. When the mouse
7625 moves, call note_mouse_highlight. If help_echo changed, call
7626 gen_help_event to produce help-echo message in the echo area.
7627 Call clear_mouse_face if mouse_face_hidden is set in the mouse
7628 highlight info.
7629
4cfd81f6
PE
76302012-05-26 Paul Eggert <eggert@cs.ucla.edu>
7631
7632 * lread.c (read1): Simplify slightly to avoid an overflow warning
7633 with GCC 4.7.0 on x86-64.
7634
4446092a
EZ
76352012-05-26 Eli Zaretskii <eliz@gnu.org>
7636
7637 * bidi.c (bidi_mirror_char): Revert last change: an int is
7638 definitely wide enough here.
7639
42b2a986 76402012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 7641
42b2a986 7642 Fix integer width and related bugs (Bug#9874).
eb106a49 7643 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
7644 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
7645 (string_bytes, check_sblock, allocate_string_data):
7646 (compact_small_strings, Fmake_bool_vector, make_string)
7647 (make_unibyte_string, make_multibyte_string)
7648 (make_string_from_bytes, make_specified_string)
7649 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
7650 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
7651 (mark_vectorlike):
7652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7653 (allocate_pseudovector):
7654 Use int, not EMACS_INT, where int is wide enough.
7655 (inhibit_garbage_collection, Fgarbage_collect):
7656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7657 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
7658 int might not be wide enough.
7659 (bidi_cache_search, bidi_cache_find, bidi_init_it)
7660 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
7661 (bidi_at_paragraph_end, bidi_find_paragraph_start)
7662 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7663 (bidi_level_of_next_char, bidi_move_to_visually_next):
7664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7665 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
7666 (Fkill_buffer, Fset_buffer_major_mode)
7667 (advance_to_char_boundary, Fbuffer_swap_text)
7668 (Fset_buffer_multibyte, overlays_at, overlays_in)
7669 (overlay_touches_p, struct sortvec, record_overlay_string)
7670 (overlay_strings, recenter_overlay_lists)
7671 (adjust_overlays_for_insert, adjust_overlays_for_delete)
7672 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
7673 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
7674 (Foverlay_recenter, last_overlay_modification_hooks_used)
7675 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
7676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
7677 (validate_region): Omit unnecessary test for b <= e,
7678 since that's guaranteed by the previous test.
d311d28c
PE
7679 (adjust_overlays_for_delete): Avoid pos + length overflow.
7680 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
7681 (report_overlay_modification):
7682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7683 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
7684 Omit pointer cast, which isn't needed anyway, and doesn't work
7685 after the EMACS_INT -> ptrdiff_t change.
02481186 7686 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
7687 * buffer.h: Adjust decls to match defn changes elsewhere.
7688 (struct buffer_text, struct buffer):
7689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7690 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
7691 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
7692 not int, to avoid needless 32-bit limit on 64-bit hosts.
7693 (exec_byte_code): Use tighter memory-full test, one that checks
7694 for alloca overflow. Don't compute the address of the object just
7695 before an array, as that's not portable. Use EMACS_INT, not
7696 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
7697 * callint.c (Fcall_interactively):
7698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7699 * callproc.c (call_process_kill, Fcall_process):
7700 Don't assume pid_t fits into an Emacs fixnum.
7701 (call_process_cleanup, Fcall_process, child_setup):
7702 Don't assume pid_t fits into int.
7703 (call_process_cleanup, Fcall_process, delete_temp_file)
7704 (Fcall_process_region):
7705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7706 (Fcall_process): Simplify handling of volatile integers.
7707 Use int, not EMACS_INT, where int will do.
7708 * casefiddle.c (casify_object, casify_region, operate_on_word)
7709 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
7710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7711 (casify_object): Avoid integer overflow when overallocating buffer.
7712 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 7713 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
7714 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
7715 * category.h (CATEGORYP): Don't assume arg is nonnegative.
7716 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
7717 integers are now checked earlier. All uses replaced with XINT.
7718 (ccl_driver):
7719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7720 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
7721 (ccl_driver, Fregister_code_conversion_map):
7722 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
7723 (resolve_symbol_ccl_program): Check that vector header is in range.
7724 Always copy the vector, so that we can check its contents reliably
7725 now rather than having to recheck each instruction as it's being
7726 executed. Check that vector words fit in 'int'.
7727 (ccl_get_compiled_code, Fregister_ccl_program)
7728 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
7729 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
7730 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
7731 contents are in range.
7732 (Fccl_execute_on_string): Check that status is in range.
7733 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
7734 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
7735 Accept and return EMACS_INT, not int, because callers can pass values
7736 out of 'int' range.
7737 (c_string_width, strwidth, lisp_string_width, chars_in_text)
7738 (multibyte_chars_in_text, parse_str_as_multibyte)
7739 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
7740 (str_as_unibyte, str_to_unibyte, string_count_byte8)
7741 (string_escape_byte8, Fget_byte):
7742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 7743 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
7744 avoid mishandling large integers.
7745 * character.h: Adjust decls to match defn changes elsewhere.
7746 * charset.c (load_charset_map_from_file, find_charsets_in_text)
7747 (Ffind_charset_region):
7748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7749 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
7750 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 7751 Don't assume fixnum fits in int.
d311d28c
PE
7752 (load_charset_map_from_vector, Fmap_charset_chars):
7753 Remove now-unnecessary CHECK_NATNUMs.
7754 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
7755 Don't rely on undefined behavior with signed left shift overflow.
7756 Don't assume unsigned int fits into fixnum, or that fixnum fits
7757 into unsigned int. Don't require max_code to be a valid fixnum;
7758 that's not true for gb10830 4-byte on a 32-bit host. Allow
7759 invalid_code to be a cons, for the same reason. Require code_offset
7760 to be a character. Avoid int overflow if max_char is close
7761 to INT_MAX.
7762 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
7763 this is intended anyway and avoids some undefined behavior.
7764 (load_charset_map): Pass unsigned, not int, as 2nd arg of
7765 INDEX_TO_CODE_POINT, as that's what it expects.
7766 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
7767 * charset.h (DECODE_CHAR): Return int, not unsigned;
7768 this is what was intended anyway, and it avoids undefined behavior.
7769 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
7770 integer-overflow issues.
7771 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
7772 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
7773 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
7774 * chartab.c (Fmake_char_table, Fset_char_table_range)
7775 (uniprop_get_decoder, uniprop_get_encoder):
7776 Don't assume fixnum fits in int.
7777 * cmds.c (move_point): New function, that does the gist of
7778 Fforward_char and Fbackward_char, but does so while checking
7779 for integer overflow more accurately.
c96e5d6a 7780 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
7781 (Fforward_line, Fend_of_line, internal_self_insert)
7782 (internal_self_insert):
7783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7784 Fix a FIXME, by checking for integer overflow when calculating
7785 target_clm and actual_clm.
7786 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 7787 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
7788 (ASSURE_DESTINATION, coding_alloc_by_realloc)
7789 (coding_alloc_by_making_gap, alloc_destination)
7790 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
7791 (encode_coding_utf_16, detect_coding_emacs_mule)
7792 (decode_coding_emacs_mule, encode_coding_emacs_mule)
7793 (detect_coding_iso_2022, decode_coding_iso_2022)
7794 (encode_invocation_designation, encode_designation_at_bol)
7795 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7796 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
7797 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
7798 (encode_coding_ccl, encode_coding_raw_text)
7799 (detect_coding_charset, decode_coding_charset)
7800 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
7801 (produce_composition, produce_charset, produce_annotation)
7802 (decode_coding, handle_composition_annotation)
7803 (handle_charset_annotation, consume_chars, decode_coding_gap)
7804 (decode_coding_object, encode_coding_object, detect_coding_system)
7805 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
7806 (code_convert_region, code_convert_string)
8f50130c
PE
7807 (Fdefine_coding_system_internal)
7808 (coding_set_source, coding_set_destination):
d311d28c
PE
7809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7810 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
7811 (Fdefine_coding_system_internal):
7812 Don't assume fixnums fit in int.
7813 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 7814 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
7815 (Funencodable_char_position, Fcheck_coding_systems_region)
7816 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 7817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 7818 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 7819 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 7820 Don't access memory outside of the args array.
d311d28c 7821 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
7822 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
7823 result of ENCODE_CHAR.
d311d28c
PE
7824 * coding.h: Adjust decls to match defn changes elsewhere.
7825 (struct coding_system):
7826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7827 * composite.c (get_composition_id, find_composition)
7828 (run_composition_function, update_compositions)
7829 (compose_text, composition_gstring_put_cache)
7830 (composition_gstring_p, composition_gstring_width)
7831 (fill_gstring_header, fill_gstring_body, autocmp_chars)
7832 (composition_compute_stop_pos, composition_reseat_it)
7833 (composition_update_it, struct position_record)
7834 (find_automatic_composition, composition_adjust_point)
7835 (Fcomposition_get_gstring, Ffind_composition_internal):
7836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7837 (update_compositions):
7838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7839 * composite.h: Adjust decls to match defn changes elsewhere.
7840 (struct composition):
7841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7842 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
7843 Do not attempt to compute the address of the object just before a
7844 buffer; this is not portable.
7845 (Faref, Faset):
7846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7847 (Faset): Use int, not EMACS_INT, where int is wide enough.
7848 (Fstring_to_number): Don't assume fixnums fit in int.
7849 (Frem): Don't assume arg is nonnegative.
7850 * dbusbind.c (xd_append_arg): Check for integers out of range.
7851 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 7852 (extract_signed, extract_unsigned): New functions.
243e0530
PE
7853 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
7854 (xd_get_connection_references): Return ptrdiff_t, not int.
7855 All uses changed.
7856 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
7857 (xd_read_message_1):
7858 Use int, not unsigned, where the dbus API uses int.
7859 (Fdbus_message_internal): Don't overflow mtype.
7860 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
7861 * dired.c (directory_files_internal, file_name_completion, scmp)
7862 (file_name_completion_stat):
7863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7864 (file_name_completion): Don't overflow matchcount.
7865 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
7866 * dispextern.h: Adjust decls to match defn changes elsewhere.
7867 (struct text_pos, struct glyph, struct bidi_saved_info)
7868 (struct bidi_string_data, struct bidi_it, struct composition_it)
7869 (struct it):
7870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7871 (struct display_pos, struct composition_it, struct it):
7872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7873 * dispnew.c (increment_matrix_positions)
7874 (increment_row_positions, mode_line_string)
7875 (marginal_area_string):
7876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 7877 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
7878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7879 (duration_to_sec_usec): New function, to check for overflow better.
7880 (Fsleep_for, sit_for): Use it.
7881 * doc.c (get_doc_string, store_function_docstring):
7882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7883 (get_doc_string, Fsnarf_documentation):
7884 Use int, not EMACS_INT, where int is wide enough.
7885 (get_doc_string):
7886 Use SAFE_ALLOCA, not alloca.
7887 Check for overflow when converting EMACS_INT to off_t.
7888 * doprnt.c (doprnt):
7889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7890 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
7891 Don't assume uid_t fits into fixnum.
7892 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
7893 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
7894 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
7895 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
7896 (general_insert_function)
7897 (Finsert_char, make_buffer_string, make_buffer_string_both)
7898 (update_buffer_properties, Fbuffer_substring)
7899 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
7900 (Fsubst_char_in_region, check_translation)
7901 (Ftranslate_region_internal, save_restriction_restore, Fformat)
7902 (transpose_markers, Ftranspose_regions):
7903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7904 (clip_to_bounds): Move to lisp.h as an inline function).
7905 (Fconstrain_to_field): Don't assume integers are nonnegative.
7906 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
7907 (Fsubst_char_in_region, Fsave_restriction):
7908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7909 (Femacs_pid): Don't assume pid_t fits into fixnum.
7910 (lo_time): Use int, not EMACS_INT, when int suffices.
7911 (lisp_time_argument): Check for usec out of range.
7912 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
7913 (Fuser_login_name, Fuser_full_name): Signal an error
7914 if a uid argument is out of range, rather than relying on
7915 undefined behavior.
c8d5c857
PE
7916 (Fformat_time_string): Remove now-unnecessary check.
7917 lisp_time_argument checks for out-of-range usec now.
243e0530 7918 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7919 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7920 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7921 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7922 (init_cmdargs, Fdump_emacs):
7923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7924 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7925 the bottom (typically) 32 bits of the fixnum.
7926 * eval.c (specpdl_size, call_debugger):
7927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7928 (when_entered_debugger, Fbacktrace_debug):
7929 Don't assume fixnum can fit in int.
7930 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7931 the object just before a buffer; this is not portable.
7932 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7933 (grow_specpdl, unbind_to):
7934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7935 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7936 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7937 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7938 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7939 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7941 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7942 (a_write, e_write):
7943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7944 (Fcopy_file, non_regular_nbytes, read_non_regular)
7945 (Finsert_file_contents):
7946 Use int, not EMACS_INT, where int is wide enough.
7947 (READ_BUF_SIZE): Verify that it fits in int.
7948 (Finsert_file_contents): Check that counts are in proper range,
7949 rather than assuming fixnums fit into ptrdiff_t etc.
7950 Don't assume fixnums fit into int.
125b3835 7951 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7952 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7953 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7954 (string_char_to_byte, string_byte_to_char)
7955 (string_make_multibyte, string_to_multibyte)
7956 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7957 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7958 (substring_both, Fdelete, internal_equal, Ffillarray)
7959 (Fclear_string, mapcar1)
7960 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7961 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7962 (larger_vector, make_hash_table, maybe_resize_hash_table)
7963 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7964 (Fmaphash, secure_hash):
7965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7966 (concat): Check for string index and length overflow.
7967 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7968 (Frequire):
7969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7970 (larger_vector): New API (vec, incr_min, size_max) replaces old
7971 one (vec, new_size, init). This catches size overflow.
7972 INIT was removed because it was always Qnil.
7973 All callers changed.
7974 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7975 the upper bound on a hash table index size.
7976 (make_hash_table, maybe_resize_hash_table): Use it.
7977 (secure_hash): Computer start_byte and end_byte only after
7978 they're known to be in ptrdiff_t range.
7979 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7980 (Ffont_get_glyphs, Ffont_at):
7981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7982 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7983 (Flist_fonts, Fopen_font):
7984 Don't assume fixnum can fit in int.
7985 (check_gstring): Don't assume index can fit in int.
7986 (font_match_p): Check that fixnum is a character, not a nonnegative
7987 fixnum, since the later code needs to stuff it into an int.
7988 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7989 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7990 conversion overflow issues.
7991 (Fopen_font): Check for integer out of range.
7992 (Ffont_get_glyphs): Don't assume index can fit in int.
7993 * font.h: Adjust decls to match defn changes elsewhere.
7994 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7995 integer overflow.
7996 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7997 printmax_t, where ptrdiff_t is wide enough.
7998 (Finternal_char_font):
7999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8000 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
8001 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
8002 (Fset_frame_position, x_set_frame_parameters)
8003 (x_set_line_spacing, x_set_border_width)
8004 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
8005 Check that fixnums are in proper range for system types.
8006 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
8007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8008 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
8009 Use SAFE_ALLOCA_LISP, not alloca.
8010 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
8011 intptr_t is wide enough.
8012 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
8013 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
8014 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
8015 Check for fixnum out of range.
8016 * ftfont.c (ftfont_list): Don't assume index fits in int.
8017 Check that fixnums are in proper range for system types.
8018 (ftfont_shape_by_flt):
8019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
8020 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8022 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
8023 Check that fixnums are in proper range for system types.
8024 * gnutls.h: Adjust decls to match defn changes elsewhere.
8025 * gtkutil.c (xg_dialog_run):
8026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8027 (update_frame_tool_bar):
8028 Check that fixnums are in proper range for system types.
8029 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 8030 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
8031 * indent.c (last_known_column, last_known_column_point):
8032 (current_column_bol_cache):
8033 (skip_invisible, current_column, check_display_width):
8034 (check_display_width, scan_for_column, current_column_1)
8035 (Findent_to, Fcurrent_indentation, position_indentation)
8036 (indented_beyond_p, Fmove_to_column, compute_motion):
8037 (Fcompute_motion, Fvertical_motion):
8038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8039 (last_known_column_modified): Use EMACS_INT, not int.
8040 (check_display_width):
8041 (Fcompute_motion):
8042 Check that fixnums and floats are in proper range for system types.
8043 (compute_motion): Don't assume index or fixnum fits in int.
8044 (compute_motion, Fcompute_motion):
8045 Use int, not EMACS_INT, when it is wide enough.
8046 (vmotion): Omit local var start_hpos that is always 0; that way
8047 we don't need to worry about overflow in expressions involving it.
8048 * indent.h: Adjust decls to match defn changes elsewhere.
8049 (struct position):
8050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8051 Use int, not EMACS_INT, where int is wide enough.
8052 Remove unused members ovstring_chars_done and tab_offset;
8053 all uses removed.
8054 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
8055 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
8056 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
8057 (make_gap, copy_text, insert, insert_and_inherit)
8058 (insert_before_markers, insert_before_markers_and_inherit)
8059 (insert_1, count_combining_before, count_combining_after)
8060 (insert_1_both, insert_from_string)
8061 (insert_from_string_before_markers, insert_from_string_1)
8062 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
8063 (adjust_after_replace, adjust_after_insert, replace_range)
8064 (replace_range_2, del_range, del_range_1, del_range_byte)
8065 (del_range_both, del_range_2, modify_region)
8066 (prepare_to_modify_buffer, signal_before_change)
8067 (signal_after_change, Fcombine_after_change_execute):
8068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8069 * intervals.c (traverse_intervals, rotate_right, rotate_left)
8070 (balance_an_interval, split_interval_right, split_interval_left)
8071 (find_interval, next_interval, update_interval)
8072 (adjust_intervals_for_insertion, delete_node, delete_interval)
8073 (interval_deletion_adjustment, adjust_intervals_for_deletion)
8074 (static_offset_intervals, offset_intervals)
8075 (merge_interval_right, merge_interval_left, make_new_interval)
8076 (graft_intervals_into_buffer, temp_set_point_both)
8077 (temp_set_point, set_point, adjust_for_invis_intang)
8078 (set_point_both, move_if_not_intangible, get_property_and_range)
8079 (get_local_map, copy_intervals, copy_intervals_to_string)
8080 (compare_string_intervals, set_intervals_multibyte_1):
8081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8082 * intervals.h: Adjust decls to match defn changes elsewhere.
8083 (struct interval):
8084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8085 * keyboard.c (this_command_key_count, this_single_command_key_start)
8086 (before_command_key_count, before_command_echo_length, echo_now)
8087 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
8088 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
8089 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
8090 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
8091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8092 (last_non_minibuf_size, last_point_position, echo_truncate)
8093 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
8094 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
8095 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
8096 (stuff_buffered_input):
8097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8098 (last_auto_save, command_loop_1, read_char):
8099 Use EMACS_INT, not int, to avoid integer overflow.
8100 (record_char): Avoid overflow in total_keys computation.
8101 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
8102 * keyboard.h: Adjust decls to match defn changes elsewhere.
8103 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
8104 (Fkey_description, Fdescribe_vector, Flookup_key):
8105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8106 (click_position): New function, to check that positions are in range.
8107 (Fcurrent_active_maps):
8108 (describe_command):
8109 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8110 (Faccessible_keymaps, Fkey_description):
8111 (preferred_sequence_p):
8112 Don't assume fixnum can fit into int.
8113 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
8114 Check for integer overflow in size calculations.
8115 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
8116 avoid mishandling large integers.
8117 * lisp.h: Adjust decls to match defn changes elsewhere.
8118 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
8119 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
8120 (struct Lisp_Marker):
8121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8122 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
8123 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
8124 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
8125 All callers changed.
8126 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
8127 Assume the arg has valid form, since it always does.
8128 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
8129 unsigned integer system type.
8130 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
8131 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
8132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8133 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
8134 (duration_to_sec_usec): New decl.
8135 * lread.c (read_from_string_index, read_from_string_index_byte)
8136 (read_from_string_limit, readchar, unreadchar, openp)
8137 (read_internal_start, read1, oblookup):
8138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8139 (Fload, readevalloop, Feval_buffer, Feval_region):
8140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8141 (openp): Check for out-of-range argument to 'access'.
8142 (read1): Use int, not EMACS_INT, where int is wide enough.
8143 Don't assume fixnum fits into int.
6efdadfd 8144 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
8145 (read_filtered_event): Use duration_to_sec_usec
8146 to do proper overflow checking on durations.
d311d28c
PE
8147 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
8148 in size calculation.
8149 (Fexecute_kbd_macro):
8150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8151 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
8152 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
8153 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
8154 (set_marker_both, set_marker_restricted_both, marker_position)
8155 (marker_byte_position, Fbuffer_has_markers_at):
8156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8157 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 8158 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
8159 It now merely ensures that the menu is large enough, without
8160 necessarily growing it, as this avoids some integer overflow issues.
8161 All callers changed.
8162 (keymap_panes, parse_single_submenu, Fx_popup_menu):
8163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8164 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
8165 Use SAFE_ALLOCA_LISP, not alloca.
8166 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
8167 to EMACS_INT. Check that fixnums are in proper range for system types.
8168 * minibuf.c (minibuf_prompt_width, string_to_object)
8169 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
8170 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
8171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8172 (get_minibuffer, read_minibuf_unwind):
8173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8174 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
8175 this simplifies overflow checking. All callers changed.
8176 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
8177 (Ftest_completion):
8178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8179 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
8180 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
8181 Check that fixnums are in proper range for system types.
8182 (Fx_create_frame, Fx_show_tip):
8183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8184 * nsfont.m (ns_findfonts, nsfont_list_family):
8185 Don't assume fixnum fits in long.
8186 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
8187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8188 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
8189 wide enough.
17fdb222 8190 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
8191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8192 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
8193 (PRINTDECLARE, PRINTPREPARE):
8194 (strout, print_string):
8195 (print, print_preprocess, print_check_string_charset_prop)
8196 (print_object):
8197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8198 (PRINTDECLARE):
8199 (temp_output_buffer_setup, Fprin1_to_string, print_object):
8200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8201 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 8202 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 8203 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
8204 (print_error_message): Use SAFE_ALLOCA, not alloca.
8205 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
8206 (print_depth, new_backquote_output, print_number_index):
8207 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
8208 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
8209 (Fset_process_window_size, Fformat_network_address)
8210 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 8211 (sigchld_handler):
d311d28c 8212 Check that fixnums are in proper range for system types.
d44287d4 8213 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
8214 Check for process-ids out of pid_t range rather than relying on
8215 undefined behavior.
e4d81efc 8216 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
8217 (Fformat_network_address, read_process_output, send_process)
8218 (Fprocess_send_region, status_notify):
8219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8220 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
8221 (wait_reading_process_output, read_process_output, exec_sentinel):
8222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8223 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
8224 (Faccept_process_output): Use duration_to_sec_usec to do proper
8225 overflow checking on durations.
dde14581
PE
8226 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
8227 Don't assume pid_t fits in int.
02481186
PE
8228 * process.h (struct Lisp_Process): Members tick and update_tick
8229 are now of type EMACS_INT, not int.
b62b53e8
PE
8230 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
8231 configured --with-wide-int.
d311d28c
PE
8232 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
8233 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
8234 * search.c (looking_at_1, string_match_1):
8235 (fast_string_match, fast_c_string_match_ignore_case)
8236 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
8237 (scan_newline, find_before_next_newline, search_command)
8238 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
8239 (set_search_regs, wordify):
8240 (Freplace_match):
8241 (Fmatch_data):
8242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8243 (string_match_1, search_buffer, set_search_regs):
8244 (Fmatch_data):
8245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8246 (wordify): Check for overflow in size calculation.
8247 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
8248 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
8249 Check that fixnums are in proper range for system types.
8250 * sound.c (struct sound_device)
8251 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
8252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8253 (Fplay_sound_internal):
8254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 8255 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
8256 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
8257 (Fparse_partial_sexp):
8258 Don't assume fixnums can fit in int.
8259 (struct lisp_parse_state, find_start_pos, find_start_value)
8260 (find_start_value_byte, find_start_begv)
8261 (update_syntax_table, char_quoted, dec_bytepos)
8262 (find_defun_start, prev_char_comend_first, back_comment):
8263 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
8264 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
8265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8266 (Finternal_describe_syntax_value): Check that match_lisp is a
8267 character, not an integer, since the code stuffs it into int.
8268 (scan_words, scan_sexps_forward):
8269 Check that fixnums are in proper range for system types.
8270 (Fforward_word):
8271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8272 (scan_sexps_forward):
8273 Use CHARACTERP, not INTEGERP, since the value must fit into int.
8274 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
8275 * syntax.h: Adjust decls to match defn changes elsewhere.
8276 (struct gl_state_s):
8277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
8278 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
8279 MOST_POSITIVE_FIXNUM.
d311d28c
PE
8280 * sysdep.c (wait_for_termination_1, wait_for_termination)
8281 (interruptible_wait_for_termination, mkdir):
8282 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
8283 (emacs_read, emacs_write):
8284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
8285 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
8286 and double all fit in int.
d311d28c
PE
8287 * term.c (set_tty_color_mode):
8288 Check that fixnums are in proper range for system types.
8289 * termhooks.h (struct input_event):
8290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8291 * textprop.c (validate_interval_range, interval_of)
8292 (Fadd_text_properties, set_text_properties_1)
8293 (Fremove_text_properties, Fremove_list_of_text_properties)
8294 (Ftext_property_any, Ftext_property_not_all)
8295 (copy_text_properties, text_property_list, extend_property_ranges)
8296 (verify_interval_modification):
8297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8298 (Fnext_single_char_property_change)
8299 (Fprevious_single_char_property_change):
8300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
8301 (copy_text_properties):
8302 Check for integer overflow in index calculation.
d311d28c
PE
8303 * undo.c (last_boundary_position, record_point, record_insert)
8304 (record_delete, record_marker_adjustment, record_change)
8305 (record_property_change):
8306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8307 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
8308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8309 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
8310 (Fx_hide_tip, Fx_file_dialog):
8311 * w32menu.c (set_frame_menubar):
8312 Use ptrdiff_t, not int, for consistency with rest of code.
8313 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
8314 (select_window, Fdelete_other_windows_internal)
8315 (window_scroll_pixel_based, window_scroll_line_based)
8316 (Frecenter, Fset_window_configuration):
8317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8318 (Fset_window_hscroll, run_window_configuration_change_hook)
8319 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 8320 (Fscroll_other_window, Frecenter):
d311d28c
PE
8321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8322 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
8323 Don't assume fixnum fits in int.
8324 (Fset_window_scroll_bars):
8325 Check that fixnums are in proper range for system types.
8326 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
8327 (string_pos, c_string_pos, number_of_chars, init_iterator)
8328 (in_ellipses_for_invisible_text_p, init_from_display_pos)
8329 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
8330 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
8331 (face_before_or_after_it_pos, handle_invisible_prop)
8332 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
8333 (display_prop_intangible_p, string_buffer_position_lim)
8334 (string_buffer_position, handle_composition_prop, load_overlay_strings)
8335 (get_overlay_strings_1, get_overlay_strings)
8336 (iterate_out_of_display_property, forward_to_next_line_start)
8337 (back_to_previous_visible_line_start, reseat, reseat_to_string)
8338 (get_next_display_element, set_iterator_to_next)
8339 (get_visually_first_element, compute_stop_pos_backwards)
8340 (handle_stop_backwards, next_element_from_buffer)
8341 (move_it_in_display_line_to, move_it_in_display_line)
8342 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8343 (add_to_log, message_dolog, message_log_check_duplicate)
8344 (message2, message2_nolog, message3, message3_nolog
8345 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
8346 (current_message_1, truncate_echo_area, truncate_message_1)
8347 (set_message, set_message_1, store_mode_line_noprop)
8348 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
8349 (text_outside_line_unchanged_p, check_point_in_composition)
8350 (reconsider_clip_changes)
8351 (redisplay_internal, set_cursor_from_row, try_scrolling)
8352 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
8353 (redisplay_window, find_last_unchanged_at_beg_row)
8354 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
8355 (trailing_whitespace_p, find_row_edges, display_line)
8356 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
8357 (display_mode_element, store_mode_line_string)
8358 (pint2str, pint2hrstr, decode_mode_spec)
8359 (display_count_lines, display_string, draw_glyphs)
8360 (x_produce_glyphs, x_insert_glyphs)
8361 (rows_from_pos_range, mouse_face_from_buffer_pos)
8362 (fast_find_string_pos, mouse_face_from_string_pos)
8363 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8365 (safe_call, init_from_display_pos, handle_fontified_prop)
8366 (handle_single_display_spec, load_overlay_strings)
8367 (with_echo_area_buffer, setup_echo_area_for_printing)
8368 (display_echo_area, echo_area_display)
8369 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
8370 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
8371 (redisplay_window, dump_glyph_row, display_mode_line)
8372 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 8373 (handle_display_spec, display_prop_string_p):
d311d28c
PE
8374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8375 (handle_single_display_spec, build_desired_tool_bar_string)
8376 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
8377 (get_specified_cursor_type):
8378 Check that fixnums are in proper range for system types.
8379 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
8380 (Flookup_image_map):
8381 Don't assume fixnums fit in int.
8382 (compare_overlay_entries):
8383 Avoid mishandling comparisons due to subtraction overflow.
8384 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
8385 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
8386 (handle_tool_bar_click):
8387 Use int, not unsigned, since we prefer signed and the signedness
8388 doesn't matter here.
8389 (get_next_display_element, next_element_from_display_vector):
8390 Use int, not EMACS_INT, when int is wide enough.
8391 (start_hourglass): Use duration_to_sec_usec to do proper
8392 overflow checking on durations.
8393 * xfaces.c (Fbitmap_spec_p):
8394 Check that fixnums are in proper range for system types.
8395 (compare_fonts_by_sort_order):
8396 Avoid mishandling comparisons due to subtraction overflow.
8397 (Fx_family_fonts, realize_basic_faces):
8398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8399 (Fx_family_fonts):
8400 Don't assume fixnum fits in int.
8401 Use SAFE_ALLOCA_LISP, not alloca.
8402 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
8403 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
8404 (face_at_buffer_position, face_for_overlay_string)
8405 (face_at_string_position):
8406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8407 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
8408 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
8409 (Fx_show_tip):
8410 Check that fixnums are in proper range for system types.
8411 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
8412 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
8413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8414 (Fx_change_window_property): Don't assume fixnums fit in int.
8415 * xfont.c (xfont_chars_supported):
8416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8417 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
8418 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
8419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8420 * xml.c (parse_region):
8421 * xrdb.c (magic_file_p):
8422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
8423 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
8424 (x_get_local_selection, x_reply_selection_request)
8425 (x_handle_selection_request, wait_for_property_change):
8426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8427 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
8428 short is wide enough.
8429 (x_send_client_event): Don't assume fixnum fits in int.
8430 * xterm.c (x_x_to_emacs_modifiers):
8431 Don't assume EMACS_INT overflows nicely into int.
8432 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
8433 may come from Lisp.
8434 (handle_one_xevent): NATNUMP can eval its arg twice.
8435 (x_connection_closed):
8436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
8437 * xterm.h: Adjust decls to match defn changes elsewhere.
8438 (struct scroll_bar): Use struct vectorlike_header
8439 rather than rolling our own approximation.
8440 (SCROLL_BAR_VEC_SIZE): Remove; not used.
8441
c6574eb5
GM
84422012-05-25 Glenn Morris <rgm@gnu.org>
8443
8444 * lisp.mk (lisp): Update for more files being compiled now.
8445
e8d32c7e
SM
84462012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
8447
48def666
SM
8448 * lread.c: Remove `read_pure' which makes no difference.
8449 (read_pure): Remove var.
8450 (unreadpure): Remove function.
8451 (readevalloop): Don't call read_list with -1 flag.
8452 (read1, read_vector): Don't test read_pure any more.
8453 (read_list): Simplify.
8454
e8d32c7e
SM
8455 * fileio.c, character.h: Minor style tweaks.
8456
4b2addb7
DA
84572012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
8458
8459 * window.h (clip_changed): Remove useless declaration.
8460
584461b2
JB
84612012-05-22 Juanma Barranquero <lekktu@gmail.com>
8462
8463 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
8464 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
8465
34374650
PE
84662012-05-22 Paul Eggert <eggert@cs.ucla.edu>
8467
8468 Remove src/m/*.
8469 This directory predates autoconf and is no longer needed nowadays.
8470 Move its few remaining bits of functionality to where they're needed.
8471 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
8472 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
8473 * m/template.h: Remove.
8474 * Makefile.in (M_FILE): Remove. All uses removed.
8475 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
8476 * lisp.h (USE_LSB_TAG):
8477 * mem-limits.h (EXCEEDS_LISP_PTR):
8478 Use VAL_MAX, not VALBITS, in #if.
8479 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
8480 (EMACS_UINT): Define unconditionally now.
8481 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
8482 (BITS_PER_EMACS_INT): New constants, replacing
8483 what used to be in config.h, but not useful in #if.
8484 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
8485 define them any more.
8486 (VAL_MAX): New macro.
8487 (VALMASK): Use it.
8488 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
8489 BITS_PER_EMACS_INT, in #if.
8490 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
8491 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
8492 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
8493 * s/ms-w32.h (DATA_START):
8494 Move here from removed file m/intel386.h.
8495 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
8496 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
8497
261cb4bb
PE
84982012-05-21 Paul Eggert <eggert@cs.ucla.edu>
8499
8500 Assume C89 or later.
8501 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
8502 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
8503 (xrealloc):
8504 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
8505 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
8506 * textprop.c, tparam.c (NULL): Remove.
8507 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
8508 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
8509 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
8510 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
8511 * xterm.c (input_signal_count): Assume volatile works.
8512
ff23cd9f
KB
85132012-05-21 Ken Brown <kbrown@cornell.edu>
8514
8515 * xgselect.c (xg_select): Fix first argument in call to 'select'
8516 (bug#11508).
8517
1b170bc6
KB
85182012-05-20 Ken Brown <kbrown@cornell.edu>
8519
8520 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 8521 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 8522
b2f4d39f
KB
85232012-05-19 Ken Brown <kbrown@cornell.edu>
8524
8525 * xfns.c (x_in_use): Remove `static' qualifier.
8526 * xterm.h (x_in_use): Declare.
8527 * xgselect.c: Include xterm.h.
8528 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
8529 and `display_arg' (bug#9754).
8530
003fdae2
PE
85312012-05-19 Paul Eggert <eggert@cs.ucla.edu>
8532
9232a6d9
PE
8533 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
8534
003fdae2
PE
8535 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
8536 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
8537
784b56e2
EZ
85382012-05-18 Eli Zaretskii <eliz@gnu.org>
8539
8540 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
8541
8542 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 8543 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
8544
8545 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
8546 reference to image_cache->refcount.
8547 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
8548
a0a79cde
JL
85492012-05-17 Juri Linkov <juri@jurta.org>
8550
8551 * search.c (Fword_search_regexp, Fword_search_backward)
8552 (Fword_search_forward, Fword_search_backward_lax)
8553 (Fword_search_forward_lax): Move functions to isearch.el
8554 (bug#10145, bug#11381).
8555
b0572523
PE
85562012-05-16 Paul Eggert <eggert@cs.ucla.edu>
8557
8558 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
8559
9660f5fc
SM
85602012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
8561
8562 * lread.c (init_obarray): Declare Qt and Qnil as special.
8563
4374de83
GM
85642012-05-14 Glenn Morris <rgm@gnu.org>
8565
8566 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 8567 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 8568
dc44c39a
PE
85692012-05-14 Paul Eggert <eggert@cs.ucla.edu>
8570
078c97cb
PE
8571 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
8572
dc44c39a
PE
8573 * unexaix.c: Port to more-recent AIX compilers.
8574 (report_error, report_error_1, make_hdr, copy_sym)
8575 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
8576 Make arguments const char *, not char *, to avoid violations of C
8577 standard and to fix some AIX warnings reported by Gilles Pion.
8578
e18afed7 85792012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
8580
8581 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
8582 already have overlays loaded.
8583 (handle_single_display_spec): Before returning without displaying
8584 fringe bitmap, synchronize the bidi iterator with the main display
8585 iterator, by calling iterate_out_of_display_property.
8586 (iterate_out_of_display_property): Detect buffer iteration by
8587 testing that it->string is a Lisp string.
8588 (get_next_display_element): When the current object is exhausted,
8589 and there's something on it->stack, call set_iterator_to_next to
8590 proceed with what's on the stack, instead of returning zero.
8591 (set_iterator_to_next): If called at the end of a Lisp string,
8592 proceed to consider_string_end without incrementing string
8593 position. Don't increment display vector index past the end of
8594 the display vector. (Bug#11417)
c8fb9dc6
EZ
8595 (pos_visible_p): Don't report a position visible when move_it_to
8596 stopped at the last line of window, which happens to be scanned
8597 backwards by the bidi iteration. (Bug#11464)
ac268e67 8598
e18afed7 85992012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
8600
8601 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
8602 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
8603 are on a TTY, and thus unable to display on the fringes.
8604 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
8605 so we need to signal to the caller that this is a "replacing"
8606 display spec. This fixes display when the spec is invalid or we
8607 are on a TTY.
8608
e18afed7 86092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
8610
8611 * unexaix.c (make_hdr): Fix typo in prototype.
8612 This bug broke the build on AIX. Problem reported by Gilles Pion.
8613
9d0a235a
MA
86142012-05-14 Michael Albinus <michael.albinus@gmx.de>
8615
8616 * keyboard.c (kbd_buffer_get_event): Read special events also in
8617 batch mode. (Bug#11415)
8618
9e6b06ed
GM
86192012-05-12 Glenn Morris <rgm@gnu.org>
8620
8621 * ns.mk: Update for ns_appbindir no longer having trailing "/".
8622
c1a1d7a3
EZ
86232012-05-12 Eli Zaretskii <eliz@gnu.org>
8624
8625 * lisp.mk (lisp): Add newcomment.elc.
8626
3fe7cdc8
GM
86272012-05-12 Glenn Morris <rgm@gnu.org>
8628
8629 * Makefile.in (MKDIR_P): New, set by configure.
8630 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
8631
53f7d2c0
PE
86322012-05-11 Paul Eggert <eggert@cs.ucla.edu>
8633
8634 Remove unused function hourglass_started.
8635 * dispextern.h (hourglass_started):
8636 * w32fns.c (hourglass_started):
8637 * xdisp.c (hourglass_started): Remove.
8638
75aafb17
JB
86392012-05-10 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
8642 Update dependencies.
8643
12959e8e
PE
86442012-05-10 Paul Eggert <eggert@cs.ucla.edu>
8645
97107e2e
PE
8646 * xgselect.c (xg_select): Put maxfds+1 into a var.
8647 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
8648
12959e8e
PE
8649 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
8650
836d29b3
DA
86512012-05-10 Dave Abrahams <dave@boostpro.com>
8652
8653 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
8654 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
8655
5cb67954
MA
86562012-05-09 Michael Albinus <michael.albinus@gmx.de>
8657
8658 * dbusbind.c (xd_registered_buses): New internal Lisp object.
8659 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
8660 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
8661 Initialize xd_registered_buses.
8662
3478ec45
PE
86632012-05-09 Paul Eggert <eggert@cs.ucla.edu>
8664
b263a6b0
PE
8665 Untag more efficiently if USE_LSB_TAG.
8666 This is based on a proposal by YAMAMOTO Mitsuharu in
8667 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
8668 For an admittedly artificial (nth 8000 longlist) benchmark on
8669 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
8670 Emacs's overall text size by 1%.
8671 * lisp.h (XUNTAG): New macro.
8672 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
8673 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
8674 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
8675 * eval.c (Fautoload):
8676 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
8677 * frame.h (XFRAME): Use XUNTAG.
8678
3478ec45
PE
8679 Port recent dbusbind.c changes to 32-bit --with-wide-int.
8680 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
8681 Remove unportable assumptions about print widths of types like
8682 dbus_uint32_t.
8683 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
8684 intptr_t when converting between pointer and integer, to avoid GCC
8685 warnings about wrong width.
8686
666b903b 86872012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
8688
8689 * w32proc.c (new_child): Force Windows to reserve only 64KB of
8690 stack for each reader_thread, instead of defaulting to 8MB
8691 determined by the linker. This avoids failures in creating
8692 subprocesses on Windows 7, see the discussion in this thread:
8693 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
8694
b120cc17
JC
86952012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
8696
8697 Fix up display of the *Minibuf-0* buffer in the mini window.
8698 * keyboard.c (read_char): Don't clear the echo area if there's no
8699 message to clear.
8700 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 8701 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 8702
9a4b36f8
MA
87032012-05-07 Michael Albinus <michael.albinus@gmx.de>
8704
8705 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
8706 batch mode.
8707
e5f9458f
CY
87082012-05-06 Chong Yidong <cyd@gnu.org>
8709
8710 * lisp.mk (lisp): Update.
8711
eceeb5fc 87122012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
8713
8714 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
8715
71873e2b
SM
87162012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
8717
8718 * data.c (PUT_ERROR): New macro.
8719 (syms_of_data): Use it. Add new error type `user-error'.
8720 * undo.c (user_error): New function.
8721 (Fprimitive_undo): Use it.
8722 * print.c (print_error_message): Adjust print style for `user-error'.
8723 * keyboard.c (user_error): New function.
8724 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
8725
ab0fa4e4
PE
87262012-05-03 Paul Eggert <eggert@cs.ucla.edu>
8727
8728 Do not limit current-time-string to years 1000..9999.
8729 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
8730 (Fcurrent_time_string): Support any year that is supported by the
8731 underlying localtime representation. Don't use asctime, as it
8732 has undefined behavior for years outside the range -999..9999.
8733
7ed806a7
PE
87342012-05-02 Paul Eggert <eggert@cs.ucla.edu>
8735
8736 Fix race conditions involving setenv, gmtime, localtime, asctime.
8737 Without this fix, interrupts could mess up code that uses these
8738 nonreentrant functions, since setting TZ invalidates existing
8739 tm_zone or tzname values, and since most of these functions return
8740 pointers to static storage.
8741 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
8742 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
8743 Grow the critical sections to include not just invoking
8744 localtime/gmtime, but also accessing these functions' results
8745 including their tm_zone values if any, and any related TZ setting.
8746 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
8747 so that the struct tm is saved in the critical section.
8748 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
8749 motivated by the fact that memory allocation needs to be outside
8750 the critical section.
8751
0c16dfed
DA
87522012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
8753
8754 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
8755 with RESET_INTERVAL.
8756
8757 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8758 Remove duplicated buffer name initialization.
8759
3f83ace8
JM
87602012-05-02 Jim Meyering <jim@meyering.net>
8761
8762 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
8763
c7b8541e
JM
8764 * xfns.c (x_window): Use xstrdup (Bug#11375).
8765
90207a15 87662012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
8767
8768 * xdisp.c (pos_visible_p): If already at a newline from the
8769 display string before the 'while' loop, don't walk back the glyphs
8770 from it3.glyph_row. Solves assertion violation when the display
8771 string begins with a newline (egg.el). (Bug#11367)
8772
b593d6a9
AH
87732012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
8774
8775 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
8776 Move to simple.el.
8777
4737362e
GM
87782012-05-01 Glenn Morris <rgm@gnu.org>
8779
99cf43f9
GM
8780 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
8781 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
8782 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
8783 All were removed before 23.1.
8784
9311dcff
GM
8785 * dispnew.c: Remove HAVE_LIBNCURSES test;
8786 it is always true on relevant platforms.
8787
4d5c6349
GM
8788 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
8789 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
8790
4737362e
GM
8791 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
8792
74dd3a6b
AS
87932012-04-30 Andreas Schwab <schwab@linux-m68k.org>
8794
8795 * .gdbinit (xpr): Remove checks for no longer existing misc types.
8796 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
8797 Remove.
8798
13c379ee
PE
87992012-04-28 Paul Eggert <eggert@cs.ucla.edu>
8800
8801 Do not avoid creating empty evaporating overlays (Bug#9642).
8802 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
8803 That is, do not delete an evaporating overlay if it becomes
8804 empty after its bounds are adjusted to fit within its buffer.
8805 This fix caused other problems, and I'm reverting it until we get
8806 to the bottom of them.
8807
a8e7d6d7 88082012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
8809
8810 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
8811
a8e7d6d7 88122012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
8813
8814 * xdisp.c (pos_visible_p): If the window start position is beyond
8815 ZV, start the display from buffer beginning. Prevents assertion
8816 violation in init_iterator when the minibuffer window is scrolled
8817 via the scroll bar.
8818
8819 * window.c (window_scroll_pixel_based): Likewise.
8820
a8e7d6d7 88212012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
8822
8823 * keymap.c (where_is_internal): Doc fix (Bug#10872).
8824
a8e7d6d7 88252012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
8826
8827 * fileio.c (Fcopy_file, Fset_file_selinux_context):
8828 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
8829
a8e7d6d7 88302012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 8831
b593d6a9
AH
8832 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
8833 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 8834
1c6900d9
EZ
88352012-04-26 Eli Zaretskii <eliz@gnu.org>
8836
4c3fa1d9
EZ
8837 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
8838 display element, check also the underlying string or buffer
8839 character. (Bug#11341)
8840
1c6900d9
EZ
8841 * w32menu.c: Include w32heap.h.
8842 (add_menu_item): If the call to AppendMenuW (via
8843 unicode_append_menu) fails, disable Unicode menus only if we are
8844 running on Windows 9X/Me.
8845
42bf8205
AS
88462012-04-24 Andreas Schwab <schwab@linux-m68k.org>
8847
8848 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
8849 (xgetint): Add missing shift for LSB tags.
8850
b1bac16e
MR
88512012-04-24 Martin Rudalics <rudalics@gmx.at>
8852
8853 * keyboard.c (read_char): Don't wipe echo area for select window
8854 events: These might get delayed via `mouse-autoselect-window'
8855 (Bug#11304).
8856
d69621cc
JB
88572012-04-24 Juanma Barranquero <lekktu@gmail.com>
8858
8859 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
8860 manipulation of :loaded-from data.
8861
02fd101b
JB
88622012-04-23 Juanma Barranquero <lekktu@gmail.com>
8863
8864 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
8865 now a cons (bug#11311).
8866
888bec30
PE
88672012-04-23 Paul Eggert <eggert@cs.ucla.edu>
8868
89a438bd
PE
8869 Do not create empty overlays with the evaporate property (Bug#9642).
8870 * buffer.c (Fmove_overlay): Delete an evaporating overlay
8871 if it becomes empty after its bounds are adjusted to fit within
8872 its buffer. Without this fix, in a nonempty buffer (let ((o
8873 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8874 yields an empty overlay that has the evaporate property, which is
8875 not supposed to happen.
8876
1068fe4d
PE
8877 Fix minor GTK3 problems found by static checking.
8878 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8879 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8880 (struct _EmacsFixedClass, emacs_fixed_get_type):
8881 Move decls here from emacsgtkfixed.h, since they needn't be public.
8882 (emacs_fixed_get_type): Now static.
8883 (emacs_fixed_class_init): Omit unused local.
8884 (emacs_fixed_child_type): Remove; unused.
8885 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8886 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8887 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
8888 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
8889 (EMACS_FIXED_GET_CLASS): Remove; unused.
8890 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
8891
888bec30
PE
8892 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
8893 Problem reported by Juanma Barranquero for Windows -Wunused-function.
8894
de85e130
PE
88952012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8896
d0baac98 8897 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 8898 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
8899 (__malloc_size_t, __malloc_ptrdiff_t):
8900 Remove. All uses removed, replaced by the definiens if needed,
8901 since we can assume C89 or better now.
8902 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
8903 (protect_malloc_state, align, get_contiguous_space)
8904 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
8905 (malloc_atfork_handler_child, malloc_enable_thread)
8906 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
8907 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
8908 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
8909 (special_realloc, _realloc_internal_nolock, _realloc_internal)
8910 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
8911 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
8912 Define using prototypes, not old style.
8913 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
8914 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
8915 (align): Don't assume that signed integer overflow wraps around.
8916 Omit unused local var.
8917 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8918 (_free_internal_nolock, memalign, mallochook, reallochook):
8919 Omit no-longer-needed casts.
8920 (valloc): Use getpagesize, not __getpagesize.
8921 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8922 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8923
de85e130
PE
8924 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8925
dcbf5805
MA
89262012-04-22 Michael Albinus <michael.albinus@gmx.de>
8927
8928 Move functions from C to Lisp. Make non-blocking method calls
8929 the default. Implement further D-Bus standard interfaces.
8930
8931 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8932 (QCdbus_request_name_allow_replacement)
8933 (QCdbus_request_name_replace_existing)
8934 (QCdbus_request_name_do_not_queue)
8935 (QCdbus_request_name_reply_primary_owner)
8936 (QCdbus_request_name_reply_in_queue)
8937 (QCdbus_request_name_reply_exists)
8938 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8939 (QCdbus_registered_serial, QCdbus_registered_method)
8940 (QCdbus_registered_signal): New Lisp objects.
8941 (XD_DEBUG_MESSAGE): Use sizeof.
8942 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8943 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8944 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8945 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8946 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8947 (xd_signature, xd_append_arg): Allow float for integer types.
8948 (xd_get_connection_references): New function.
b593d6a9
AH
8949 (xd_get_connection_address): Rename from xd_initialize.
8950 Return cached address.
dcbf5805
MA
8951 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8952 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8953 level.
8954 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8955 Return number of refcounts.
dcbf5805
MA
8956 (Fdbus_get_unique_name): Make stronger parameter check.
8957 (Fdbus_message_internal): New defun.
8958 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8959 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8960 (Fdbus_send_signal, Fdbus_register_service)
8961 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8962 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8963 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8964 (Vdbus_compiled_version, Vdbus_runtime_version)
8965 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8966 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8967 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8968 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8969 Adapt docstring.
dcbf5805 8970
52828e02
PE
89712012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8972
da05bc4c
PE
8973 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8974 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8975 Do not assume ptrdiff_t is the same width as 'int'.
8976
52828e02
PE
8977 * alloc.c: Handle unusual debugging option combinations.
8978 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8979 since the two debugging options are incompatible.
8980 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8981 is defined.
8982 (mem_init, mem_insert, mem_insert_fixup):
8983 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8984 (NEED_MEM_INSERT): Remove; no longer needed.
8985
f01769f9
LL
89862012-04-22 Leo Liu <sdl.web@gmail.com>
8987
8988 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8989
5790543d
PE
89902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8991
8992 * sysdep.c [__FreeBSD__]: Minor cleanups.
8993 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8994 Use Emacs indenting style more consistently. Avoid some casts.
8995 Use 'double' consistently rather than mixing 'float' and 'double'.
8996
b91b7e4d
EW
89972012-04-21 Eduard Wiebe <usenet@pusto.de>
8998
b593d6a9
AH
8999 * sysdep.c (list_system_processes, system_process_attributes):
9000 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 9001
6114eb15
AS
90022012-04-21 Andreas Schwab <schwab@linux-m68k.org>
9003
9004 * lisp.mk (lisp): Update.
9005
2f38dff7
PE
90062012-04-20 Paul Eggert <eggert@cs.ucla.edu>
9007
9008 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
9009 It is never used otherwise.
9010
4ae29f89
SM
90112012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
9012
9013 * print.c (print_preprocess): Only check print_depth if print-circle
9014 is nil.
9015 (print_object): Check for cycles even when print-circle is nil and
9016 print-gensym is t, but only check print_depth if print-circle is nil.
9017
f30d612a
CY
90182012-04-20 Chong Yidong <cyd@gnu.org>
9019
9020 * process.c (wait_reading_process_output): If EIO occurs on a pty,
9021 set the status to "failed" and ensure that sentinel is run.
9022
c07a4c0b 90232012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
9024
9025 * process.c (Fset_process_inherit_coding_system_flag)
9026 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 9027 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 9028
c07a4c0b 90292012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
9030
9031 * xdisp.c (string_buffer_position_lim): Limit starting position to
9032 BEGV.
9033 (set_cursor_from_row): If called for a mode-line or header-line
9034 row, return zero immediately.
9035 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
9036 farther than the first row after the header line, if any.
9037 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
9038 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
9039
c07a4c0b 90402012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 9041
4ae29f89
SM
9042 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
9043 (bug#11238).
ad3a2b41 9044
c07a4c0b 90452012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 90462012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
9047
9048 configure: new option --enable-gcc-warnings (Bug#11207)
9049 * Makefile.in (C_WARNINGS_SWITCH): Remove.
9050 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
9051 (ALL_CFLAGS): Use new macros rather than old.
9052 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
9053 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
9054 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
9055 -Wunused-result, -Wunused-variable. This should go away once
9056 the Emacs and Gnulib regex code is merged.
9057 (xmalloc, xrealloc): Now static.
9058
aba027e8
PE
90592012-04-17 Paul Eggert <eggert@cs.ucla.edu>
9060
9061 * dired.c (Fsystem_groups): Remove unused local.
9062
e5a36063
GM
90632012-04-17 Glenn Morris <rgm@gnu.org>
9064
9065 * dired.c (Fsystem_users): Doc fix.
9066
316411f0
DA
90672012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
9068
9069 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
9070 (syms_of_dired): Add them.
9071
9426aba4
PE
90722012-04-16 Paul Eggert <eggert@cs.ucla.edu>
9073
b62a57be
PE
9074 Fix minor alloc.c problems found by static checking.
9075 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
9076 New extern decls, to avoid calling undeclared functions.
9077 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
9078 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
9079 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
9080 (NEED_MEM_INSERT): New macro.
9081 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 9082 Remove one incorrect comment and fix another.
b62a57be 9083
3539f31f
PE
9084 Fix minor ralloc.c problems found by static checking.
9085 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
9086 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
9087 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
9088 (r_alloc_sbrk): Now static.
9089
a041960a
PE
9090 Improve ralloc.c interface checking.
9091 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
9092 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
9093 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
9094 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
9095 [REL_ALLOC]: ... to here, to check interface.
9096 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
9097 Remove decls. This fixes an "It stinks!".
9098
9426aba4
PE
9099 * alloc.c (which_symbols): Fix alignment issue / type clash.
9100
d55c12ed
AS
91012012-04-15 Andreas Schwab <schwab@linux-m68k.org>
9102
9103 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
9104 (struct Lisp_Misc_Any): Likewise.
9105 (struct Lisp_Free): Likewise.
9106 * alloc.c (union aligned_Lisp_Symbol): Define.
9107 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
9108 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
9109 (union aligned_Lisp_Misc): Define.
9110 (MARKER_BLOCK_SIZE, struct marker_block): Use union
9111 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 9112 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 9113
b948ce8b
PE
91142012-04-14 Paul Eggert <eggert@cs.ucla.edu>
9115
9116 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
9117 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
9118 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
9119 * s/netbsd.h, s/sol2-6.h:
9120 Remove definition of GC_MARK_STACK, since the default now works.
9121 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
9122 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
9123 no longer the default.
9124 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
9125
35dc09a1 91262012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 9127
35dc09a1
GM
9128 * lread.c (lisp_file_lexically_bound_p):
9129 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 9130
35dc09a1
GM
91312012-04-14 Eli Zaretskii <eliz@gnu.org>
9132
9133 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
9134 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
9135
91362012-04-14 Jan Djärv <jan.h.d@swipnet.se>
9137
9138 * nsterm.m (constrainFrameRect): Always constrain when there is only
9139 one screen (Bug#10962).
9140
bcd86815
KB
91412012-04-13 Ken Brown <kbrown@cornell.edu>
9142
9143 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
9144
c25df26e
RT
91452012-04-13 Reuben Thomas <rrt@sc3d.org>
9146
9147 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
9148
0fc59f1e
DC
91492012-04-11 Daniel Colascione <dancol@dancol.org>
9150
9151 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
9152 against is gone. It's better to use vfork now so that when Cygwin
9153 gains a new, working vfork, we use it automatically (bug#10398).
9154
de8c03dc
SM
91552012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
9156
9157 * window.c (save_window_save): Obey window-point-insertion-type.
9158
2f097256
GM
91592012-04-11 Glenn Morris <rgm@gnu.org>
9160
9161 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
9162
453b951e
SM
91632012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
9164
9165 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
9166
75f1671a 91672012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
9168
9169 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
9170 (force_quit_count): New var.
9171 (handle_interrupt): Use it.
9172
2a8ce227
JB
91732012-04-10 Juanma Barranquero <lekktu@gmail.com>
9174
9175 * w32.c (w32_delayed_load): Record the full path of the library
9176 being loaded (bug#10424).
9177
935396c0
GM
91782012-04-09 Glenn Morris <rgm@gnu.org>
9179
05920a43
GM
9180 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
9181 not just in the obarray, before snarfing them. (Bug#11036)
9182
935396c0
GM
9183 * Makefile.in ($(leimdir)/leim-list.el):
9184 Pass EMACS rather than BUILT_EMACS.
9185
a18ecafa
TZ
91862012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
9187
9188 * process.c (make_process):
9189 * process.h: Add integer `gnutls_handshakes_tried' member to
9190 process struct.
9191
6bbef4e5
JC
9192 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
9193 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
9194
9195 * gnutls.c (gnutls_log_function2i): Convenience log function.
9196 (emacs_gnutls_read): Use new log functions,
9197 `gnutls_handshakes_tried' process member, and
9198 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
9199 attempts per process (connection).
9200
b4d3bc10
CY
92012012-04-09 Chong Yidong <cyd@gnu.org>
9202
9203 * eval.c (Fuser_variable_p, user_variable_p_eh)
9204 (lisp_indirect_variable): Functions deleted.
9205 (Fdefvar): Caller changed.
9206
9207 * callint.c (Finteractive, Fcall_interactively):
9208 * minibuf.c (Fread_variable): Callers changed.
9209
70f4d973
EZ
92102012-04-09 Eli Zaretskii <eliz@gnu.org>
9211
9212 * xdisp.c (set_cursor_from_row): If the display string appears in
9213 the buffer at position that is closer to point than the position
9214 after the display string, display the cursor on the first glyph of
9215 the display string. Fixes cursor display when a 'display' text
9216 property immediately follows invisible text. (Bug#11094)
9217
cb3c2e3e
PE
92182012-04-09 Paul Eggert <eggert@cs.ucla.edu>
9219
9220 composite.c: use 'double' consistently
9221 * composite.c (get_composition_id): Use 'double' consistently
9222 instead of converting 'float' to 'double' and vice versa; this is
9223 easier to understand and avoids a GCC warning.
9224
fd06db5d
GM
92252012-04-09 Glenn Morris <rgm@gnu.org>
9226
50fe702a
GM
9227 * Makefile.in: Generate leim-list with bootstrap-emacs, in
9228 preparation for dumping it with emacs. (Bug#4789)
9229 (leimdir): New variable.
9230 ($(leimdir)/leim-list.el): New rule.
9231 (emacs$(EXEEXT)): Depend on leim-list.el.
9232
fd06db5d
GM
9233 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
9234 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
9235 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
9236
55c131ee
AS
92372012-04-08 Andreas Schwab <schwab@linux-m68k.org>
9238
9239 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
9240 proper alignment.
9241
9209588f
JB
92422012-04-07 Juanma Barranquero <lekktu@gmail.com>
9243
9244 * xml.c (init_libxml2_functions) [WINDOWSNT]:
9245 Remove unused local variable.
9246
e3fb2efb
PE
92472012-04-07 Paul Eggert <eggert@cs.ucla.edu>
9248
9249 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
9250 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
9251 (mark_memory): Mark Lisp_Objects only if pointers might hide in
9252 objects, as mark_maybe_pointer will catch them otherwise.
9253 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
9254 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
9255
b5385551
PE
92562012-04-07 Paul Eggert <eggert@cs.ucla.edu>
9257
9258 Fix typo that broke non-Windows builds.
9259 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
9260
9078ead6
EZ
92612012-04-07 Eli Zaretskii <eliz@gnu.org>
9262
9263 Support building on MS-Windows with libxml2.
9264
9265 * makefile.w32-in (OBJ2): Add xml.$(O).
9266 (GLOBAL_SOURCES): Add xml.c.
9267 ($(BLD)/xml.$(O)): New dependency list.
9268
9269 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
9270 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
9271 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
9272 [!WINDOWSNT]: New macros.
9273 (init_libxml2_functions, libxml2_loaded_p): New functions.
9274 (parse_region): Call fn_xmlCheckVersion instead of using the macro
9275 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
9276 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
9277 Calls xmlCleanupParser only if libxml2 was loaded (or statically
9278 linked in).
6bbef4e5
JC
9279 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
9280 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
9281 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
9282
9283 * emacs.c: Don't include libxml/parser.h.
9284 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
9285 xmlCleanupParser directly.
9286
9287 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
9288
3811fdf3
EZ
92892012-04-07 Eli Zaretskii <eliz@gnu.org>
9290
9291 * indent.c (Fvertical_motion): If there is a display string at
9292 point, use it.vpos to compute how many lines to backtrack after
9293 move_it_to point. (Bug#11133)
9294
2f8e16b2
EZ
92952012-04-06 Eli Zaretskii <eliz@gnu.org>
9296
9297 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
9298 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
9299 about subtle differences between FETCH_CHAR* and STRING_CHAR*
9300 macros related to unification of CJK characters. For the details,
9301 see the discussion following the message here:
9302 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
9303
3d439cd1
CY
93042012-04-04 Chong Yidong <cyd@gnu.org>
9305
9306 * keyboard.c (Vdelayed_warnings_list): Doc fix.
9307
8bc53d00
EZ
93082012-04-01 Eli Zaretskii <eliz@gnu.org>
9309
9310 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
9311 instead of alloca. (Bug#11138)
9312
3b0512a3
AS
93132012-04-01 Andreas Schwab <schwab@linux-m68k.org>
9314
9315 * w32menu.c (is_simple_dialog): Properly check lisp types.
9316 (Bug#11141)
9317
8427ddd2
EZ
93182012-03-31 Eli Zaretskii <eliz@gnu.org>
9319
979022ef
EZ
9320 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
9321 position we get to after a call to move_it_to fails the
9322 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
9323 only if we wind up in a string from display property. (Bug#11063)
9324
a6b1c7cc
EZ
9325 * window.c (Fdelete_other_windows_internal): Invalidate the row
9326 and column information about mouse highlight, so that redisplay
9327 restores it after reallocating the glyph matrices. (Bug#7464)
9328
8427ddd2
EZ
9329 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
9330 string comes from a `display' text property, use the buffer
9331 position of that property as if we actually saw that position in
9332 the row's glyphs.
697ba24b
EZ
9333 (move_it_by_lines): Remove the assertion that
9334 "it->current_x == 0 && it->hpos == 0" which can be legitimately
9335 violated when there's a before-string at the beginning of a line.
9336 (Bug#11063)
8427ddd2 9337
65a0a738
EZ
93382012-03-30 Eli Zaretskii <eliz@gnu.org>
9339
9340 * xdisp.c (append_space_for_newline): If the default face was
9341 remapped, use the remapped face for the appended newline.
9342 (extend_face_to_end_of_line): Use the remapped default face for
9343 extending the face to the end of the line.
9344 (display_line): Call extend_face_to_end_of_line when the default
9345 face was remapped. (Bug#11068)
9346
581355cc
EZ
93472012-03-29 Eli Zaretskii <eliz@gnu.org>
9348
9349 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
9350
e8fc049f
SM
93512012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9352
9353 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
9354
4fb9a543
GM
93552012-03-27 Glenn Morris <rgm@gnu.org>
9356
9357 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
9358 Doc fixes.
9359
679910f1
KH
93602012-03-26 Kenichi Handa <handa@m17n.org>
9361
9362 * dispextern.h (struct glyph): Fix previous change. Change the
9363 bit length of glyphless.ch to 25 (Bug#11082).
9364
90d49b7f
CY
93652012-03-26 Chong Yidong <cyd@gnu.org>
9366
9367 * keyboard.c (Vselection_inhibit_update_commands): New variable.
9368 (command_loop_1): Use it; inhibit selection update for
9369 handle-select-window too (Bug#8996).
9370
f514f6f0
FP
93712012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
9372
e8fc049f 9373 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 9374
bf43fa51
KH
93752012-03-25 Kenichi Handa <handa@m17n.org>
9376
9377 * dispextern.h (struct glyph): Change the bit length of
9378 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
9379
8a0c01dd
EZ
93802012-03-24 Eli Zaretskii <eliz@gnu.org>
9381
9382 * s/ms-w32.h (tzname): Include time.h before redirecting to
9383 _tzname. Fixes the MSVC build. (Bug#9960)
9384
7d1c3a76
AS
93852012-03-24 Andreas Schwab <schwab@linux-m68k.org>
9386
8ed79523
AS
9387 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
9388 characters.
9389
7d1c3a76
AS
9390 * xterm.c (XTread_socket): Only modify handling_signal if
9391 !SYNC_INPUT. (Bug#11080)
9392
e99a9b8b
EZ
93932012-03-23 Eli Zaretskii <eliz@gnu.org>
9394
9395 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
9396 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
9397 when fetching a multibyte character consumes more bytes than
9398 CHAR_BYTES returns, due to unification of CJK characters in
9399 string_char. (Bug#11073)
9400
5063c0e1
TN
94012012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
9402
9403 * process.c (wait_reading_process_output): Handle pty disconnect
9404 by refraining from sending oneself a SIGCHLD (bug#10933).
9405
9f851fbd
CY
94062012-03-22 Chong Yidong <cyd@gnu.org>
9407
9408 * dispextern.h (struct it): New member string_from_prefix_prop_p.
9409
5063c0e1 9410 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
9411 Mark string as coming from a prefix property.
9412 (handle_face_prop): Use default face for prefix strings (Bug#4281).
9413 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
9414
fb5b8aca
CY
94152012-03-21 Chong Yidong <cyd@gnu.org>
9416
9417 * xfaces.c (Vface_remapping_alist): Doc fix.
9418
62356a1b
EZ
94192012-03-20 Eli Zaretskii <eliz@gnu.org>
9420
9421 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
9422 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
9423 Doc fixes.
62356a1b 9424
025de85b
CY
94252012-03-20 Chong Yidong <cyd@gnu.org>
9426
9427 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
9428 to reflect default non-nil value of redisplay-dont-pause.
9429
4827f94e
KH
94302012-03-19 Kenichi Handa <handa@m17n.org>
9431
9432 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
9433 it fit in a valid range (Bug#11003).
9434
e50a24a2
EZ
94352012-03-18 Eli Zaretskii <eliz@gnu.org>
9436
9437 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
9438 that is not from display property, accept the row as a "cursor
9439 row" if one of the string's character has a non-nil `cursor'
9440 property. Fixes cursor positioning when there are newlines in
9441 overlay strings, e.g. in icomplete.el. (Bug#11035)
9442
9af5ed87
PE
94432012-03-12 Paul Eggert <eggert@cs.ucla.edu>
9444
9445 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
9446
d1f55f16
CY
94472012-03-12 Chong Yidong <cyd@gnu.org>
9448
9449 * eval.c (inhibit_lisp_code): Rename from
9450 inhibit_window_configuration_change_hook; move from window.c.
9451
9452 * xfns.c (unwind_create_frame_1, Fx_create_frame):
9453 * window.c (run_window_configuration_change_hook)
9454 (syms_of_window): Callers changed.
9455
66c5eebd
CY
94562012-03-11 Chong Yidong <cyd@gnu.org>
9457
413df973
CY
9458 * keymap.c (Fkey_description): Doc fix (Bug#9700).
9459
66c5eebd
CY
9460 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
9461
1de11f56
CY
94622012-03-10 Chong Yidong <cyd@gnu.org>
9463
9464 * frame.c (other_visible_frames): Don't assume the selected frame
9465 is visible (Bug#10955).
9466
cae07000
SM
94672012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
9468
9469 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
9470
89c94350
JD
94712012-03-08 Jan Djärv <jan.h.d@swipnet.se>
9472
9473 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
9474 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
9475 zero (Bug#10954).
9476
999dd333
GM
94772012-03-03 Glenn Morris <rgm@gnu.org>
9478
01a6dcc8 9479 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 9480
de0100f2
EZ
94812012-03-02 Eli Zaretskii <eliz@gnu.org>
9482
9483 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
9484 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
9485 (redisplay_window, next_element_from_string): Fix typos in
9486 comments.
3e441275
EZ
9487 (redisplay_window): Pass to move_it_vertically the margin in
9488 pixels, not in screen lines.
de0100f2 9489
96a72ee9
GM
94902012-03-02 Glenn Morris <rgm@gnu.org>
9491
9492 * buffer.c (buffer-list-update-hook): Doc fix.
9493
312508d7
EZ
94942012-02-29 Eli Zaretskii <eliz@gnu.org>
9495
9496 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
9497 push_it before setting up the iterator for the first overlay
9498 string, even if we have an empty string loaded.
9499 (next_overlay_string): If there's an empty string on the iterator
9500 stack, pop the stack. (Bug#10903)
9501
27f3c637
PE
95022012-02-25 Paul Eggert <eggert@cs.ucla.edu>
9503
9504 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
9505 Suggested by Stefan Monnier in
9506 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
9507 * alloc.c (widen_to_Lisp_Object): New static function.
9508 (mark_memory): Also mark Lisp_Objects by fetching pointer words
9509 and widening them to Lisp_Objects. This would work even if
9510 USE_LSB_TAG is defined and wide integers are used, which might
9511 happen in a future version of Emacs.
9512
3c9dfce6
CY
95132012-02-25 Chong Yidong <cyd@gnu.org>
9514
fa74b241
CY
9515 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
9516 Doc fix.
9517
3c9dfce6
CY
9518 * xselect.c (Fx_selection_exists_p): Doc fix.
9519 (x_clipboard_manager_save_all): Print an informative message
9520 before saving to clipboard manager.
9521
9486df08
CY
95222012-02-24 Chong Yidong <cyd@gnu.org>
9523
9524 * keyboard.c (process_special_events): Handle all X selection
9525 requests in kbd_buffer, not just the next one (Bug#8869).
9526
f01d3321
CY
95272012-02-23 Chong Yidong <cyd@gnu.org>
9528
9529 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
9530 call when setting menu-bar-lines and tool-bar-lines parameters.
9531 (unwind_create_frame_1): New helper function.
9532
9533 * window.c (inhibit_window_configuration_change_hook): New var.
9534 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 9535 (syms_of_window): Initialize it.
f01d3321 9536
86b847b6
CY
95372012-02-22 Chong Yidong <cyd@gnu.org>
9538
9539 * xterm.c (x_draw_image_relief): Add missing type check for
9540 Vtool_bar_button_margin (Bug#10743).
9541
a59225b1
CY
95422012-02-21 Chong Yidong <cyd@gnu.org>
9543
9544 * fileio.c (Vfile_name_handler_alist): Doc fix.
9545
9546 * buffer.c (Fget_file_buffer): Protect against invalid file
9547 handler return value.
9548
310f5bd4
PE
95492012-02-20 Paul Eggert <eggert@cs.ucla.edu>
9550
cb3a28cc
PE
9551 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
9552 when computing $valmask.
9553
310f5bd4
PE
9554 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
9555 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
9556 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
9557 It's useless in that case, and it can cause problems on hosts
9558 that allocate halves of EMACS_INT values separately.
9559 Reported by Dan Horák. Diagnosed by Andreas Schwab in
9560 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
9561 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
9562 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
9563 it avoids undefined behavior on hosts where shifting right by more
9564 than the word width has undefined behavior.
9565
2375c96a
CY
95662012-02-19 Chong Yidong <cyd@gnu.org>
9567
9568 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
9569 (Funhandled_file_name_directory, Ffile_name_as_directory)
9570 (Fdirectory_file_name, Fexpand_file_name)
9571 (Fsubstitute_in_file_name): Protect against invalid file handler
9572 return values (Bug#10845).
9573
3eb49e71
EZ
95742012-02-18 Eli Zaretskii <eliz@gnu.org>
9575
9576 * .gdbinit (pitx): Fix incorrect references to fields of the
9577 iterator stack.
9578
7b926f3f
CY
95792012-02-17 Chong Yidong <cyd@gnu.org>
9580
9581 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
9582
11273115
PE
95832012-02-15 Paul Eggert <eggert@cs.ucla.edu>
9584
9585 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
9586 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
9587
c3a70e2b
CY
95882012-02-15 Chong Yidong <cyd@gnu.org>
9589
9590 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
9591 marked as special. Also, starting docstrings with * is obsolete.
9592
0ca43699
AS
95932012-02-13 Andreas Schwab <schwab@linux-m68k.org>
9594
9595 * gnutls.c (emacs_gnutls_write): Fix last change.
9596
2e8f3c56
LI
95972012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
9598
9599 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
9600 send_process.
9601
af70074f
SM
96022012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
9603
9604 * keymap.c (Fsingle_key_description): Handle char ranges.
9605
95986d52
CY
96062012-02-12 Chong Yidong <cyd@gnu.org>
9607
afd83bd1
CY
9608 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
9609 as that creates a dangerous corner case.
9610
95986d52
CY
9611 * window.c (Fdelete_window_internal): Invalidate the mouse
9612 highlight (Bug#9904).
9613
bd7da63e
GM
96142012-02-12 Glenn Morris <rgm@gnu.org>
9615
9616 * xselect.c (Fx_own_selection_internal)
9617 (Fx_get_selection_internal, Fx_disown_selection_internal)
9618 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
9619 * nsselect.m (Fx_own_selection_internal)
9620 (Fx_disown_selection_internal, Fx_selection_exists_p)
9621 (Fx_selection_owner_p, Fx_get_selection_internal):
9622 Sync docs and argument specs with the xselect.c versions.
9623
77abcbc2
LI
96242012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
9625
9626 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
9627
90b671e2
EZ
96282012-02-11 Eli Zaretskii <eliz@gnu.org>
9629
1c0ca0b7
EZ
9630 * w32select.c (Fx_selection_exists_p): Sync doc string and
9631 argument list with xselect.c. (Bug#10783)
9632
9633 * w16select.c (Fx_selection_exists_p): Sync doc string and
9634 argument list with xselect.c. (Bug#10783)
90b671e2 9635
49241268
GM
96362012-02-10 Glenn Morris <rgm@gnu.org>
9637
9638 * fns.c (Fsecure_hash): Doc fix.
9639
f998bbe7 96402012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
9641
9642 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
9643
0992bd9c
CY
96442012-02-07 Chong Yidong <cyd@gnu.org>
9645
9646 * buffer.c (Fbuffer_local_variables)
9647 (buffer_lisp_local_variables): Handle unbound vars correctly;
9648 don't let Qunbound leak into Lisp.
9649
af008560
GM
96502012-02-07 Glenn Morris <rgm@gnu.org>
9651
dd605cc4
GM
9652 * image.c (Fimagemagick_types): Doc fix.
9653
af008560
GM
9654 * image.c (imagemagick-render-type): Change it from a lisp object
9655 to an integer. Move the doc here from the lisp manual.
9656 Treat all values not equal to 0 the same.
9657
1449fa1d
CY
96582012-02-06 Chong Yidong <cyd@gnu.org>
9659
9660 * doc.c (store_function_docstring): Avoid applying docstring of
9661 alias to base function (Bug#2603).
9662
3723ec07
AS
96632012-02-04 Andreas Schwab <schwab@linux-m68k.org>
9664
9665 * .gdbinit (pp1, pv1): Remove redundant defines.
9666 (pr): Use pp.
9667
79c1cc1e
CY
96682012-02-04 Chong Yidong <cyd@gnu.org>
9669
9670 * nsterm.m: Declare a global (Bug#10694).
9671
d7f29f8e
EZ
96722012-02-04 Eli Zaretskii <eliz@gnu.org>
9673
cae07000
SM
9674 * w32.c (get_emacs_configuration_options):
9675 Include --enable-checking, if specified, in the return value.
d7f29f8e 9676
3b95a6f9
MR
96772012-02-04 Martin Rudalics <rudalics@gmx.at>
9678
9679 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
9680 after rounding frame sizes. (Bug#9723)
9681
d6fa96a6
EZ
96822012-02-04 Eli Zaretskii <eliz@gnu.org>
9683
9684 * keyboard.c (adjust_point_for_property): Don't position point
9685 before BEGV. (Bug#10696)
9686
df0b2940
PE
96872012-02-03 Paul Eggert <eggert@cs.ucla.edu>
9688
9689 Handle overflow when computing char display width (Bug#9496).
9690 * character.c (char_width): Return EMACS_INT, not int.
9691 (char_width, c_string_width): Check for overflow when
9692 computing the width; this is possible now that individual
9693 characters can have unbounded width. Problem introduced
9694 by merge from Emacs 23 on 2012-01-19.
9695
6bee44d6
MA
96962012-02-02 Michael Albinus <michael.albinus@gmx.de>
9697
9698 * dbusbind.c (Fdbus_register_method): Mention the return value
9699 :ignore in the docstring.
9700
44f92739
GM
97012012-02-02 Glenn Morris <rgm@gnu.org>
9702
1b9f60cc
GM
9703 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
9704
44f92739
GM
9705 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9706 Unconditionally set to t. (Bug#10673)
9707 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
9708 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
9709 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
9710
c5d3843c
KH
97112012-02-02 Kenichi Handa <handa@m17n.org>
9712
9713 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
9714 0, do not call append_composite_glyph.
9715
159462d4 97162012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
9717
9718 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
9719 NULL (Bug#6988).
9720 (x_produce_glyphs): If the component of a composition is a null
9721 string, set it->pixel_width to 1 to avoid zero-width glyph.
9722
78cef877
EZ
97232012-02-01 Eli Zaretskii <eliz@gnu.org>
9724
9725 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
9726 first 2 arguments are identical. This makes inserting large
9727 output from a subprocess an order of magnitude faster on
9728 MS-Windows, where all sbrk'ed memory is always contiguous.
9729
97897668
GM
97302012-01-31 Glenn Morris <rgm@gnu.org>
9731
9732 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 9733 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
9734 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
9735
31fd3586
GM
97362012-01-29 Glenn Morris <rgm@gnu.org>
9737
9738 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
9739
0e24a8b2
CY
97402012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
9741
9742 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
9743
cc0adcb0
CY
97442012-01-28 Chong Yidong <cyd@gnu.org>
9745
9746 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
9747
acc28cb9
CY
97482012-01-26 Chong Yidong <cyd@gnu.org>
9749
9c69cfb7
CY
9750 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
9751
acc28cb9
CY
9752 * search.c (Fsearch_forward, Fsearch_backward): Document negative
9753 repeat counts (Bug#10507).
9754
48da7392
GM
97552012-01-26 Glenn Morris <rgm@gnu.org>
9756
9757 * lread.c (syms_of_lread): Doc fix.
9758
14af5f7f
CY
97592012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
9760
9761 * coding.c (encode_designation_at_bol): Change return value to
9762 EMACS_INT.
9763
0b21c100
CY
97642012-01-25 Chong Yidong <cyd@gnu.org>
9765
9766 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
9767
3c2907f7
CY
97682012-01-21 Chong Yidong <cyd@gnu.org>
9769
9770 * floatfns.c (Fcopysign): Make the second argument non-optional,
9771 since nil is not allowed anyway.
9772
959ad23f
AS
97732012-01-21 Andreas Schwab <schwab@linux-m68k.org>
9774
9775 * process.c (read_process_output): Use p instead of XPROCESS (proc).
9776 (send_process): Likewise.
9777
34a02f46
MR
97782012-01-19 Martin Rudalics <rudalics@gmx.at>
9779
9780 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
9781 (Vwindow_persistent_parameters): Do not use Qstate.
9782 Rewrite doc-strings.
34a02f46 9783
1259009a 97842012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
9785
9786 * character.c (char_width): New function.
70d4fdf6
GM
9787 (Fchar_width, c_string_width, lisp_string_width):
9788 Use char_width (Bug#9496).
25ed9e61 9789
6a6ee00d
MR
97902012-01-16 Martin Rudalics <rudalics@gmx.at>
9791
9792 * window.c (Vwindow_persistent_parameters): New variable.
9793 (Fset_window_configuration, save_window_save): Handle persistent
9794 window parameters.
9795
c85efaf7
EZ
97962012-01-14 Eli Zaretskii <eliz@gnu.org>
9797
9798 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
9799 thrashing the stack of the thread. (Bug#9087)
9800
5944709e
PE
98012012-01-12 Paul Eggert <eggert@cs.ucla.edu>
9802
9803 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
9804
e71f5d99
EZ
98052012-01-11 Eli Zaretskii <eliz@gnu.org>
9806
9807 * xdisp.c (rows_from_pos_range): Handle the case where the
9808 highlight ends on a newline. (Bug#10464)
9809 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
9810 he end column for display of highlight that ends on a newline
9811 before a R2L line.
9812
ce316182
GM
98132012-01-11 Glenn Morris <rgm@gnu.org>
9814
9815 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
9816 from load-path also when installation-directory is nil. (Bug#10208)
9817
5b43da69
GM
98182012-01-10 Glenn Morris <rgm@gnu.org>
9819
74cc8ff9
GM
9820 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
9821
7d8d6e4e
GM
9822 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
9823 Update template values to be closer to their typical values these days.
5b43da69 9824
a0db8d43
EZ
98252012-01-09 Eli Zaretskii <eliz@gnu.org>
9826
9827 * xdisp.c (rows_from_pos_range): Accept additional argument
9828 DISP_STRING, and accept any glyph in a row whose object is that
9829 string as eligible for mouse highlight. Fixes mouse highlight of
9830 display strings from overlays. (Bug#10464)
9831
9a0115ab 98322012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 9833
b9110d6a 9834 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
9835 * fileio.c (auto_saving_dir_umask): New static var.
9836 (Fmake_directory_internal): Use it.
9837 (do_auto_save_make_dir): Set it, instead of invoking chmod after
9838 creating the directory. The old code temporarily assigns
9839 too-generous permissions to the directory.
9840 (do_auto_save_eh): Clear it.
b9110d6a 9841 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
9842 that the var is always cleared.
9843
6c1bd3f3
EZ
98442012-01-07 Eli Zaretskii <eliz@gnu.org>
9845
9846 * search.c (scan_buffer): Pass character positions to
9847 know_region_cache, not byte positions. (Bug#6540)
9848
069d2b50
L
98492012-01-07 LynX <_LynX@bk.ru> (tiny change)
9850
9851 * w32.c (sys_rename): Report EXDEV when rename of a directory
9852 fails because the target is on another logical disk. (Bug#10284)
9853
75bf0d33
DB
98542012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
9855
9856 * xterm.c (x_embed_request_focus): New function.
9857
9858 * xterm.h: Add prototype.
9859
9860 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
9861
1c6e5a32
GM
98622012-01-05 Glenn Morris <rgm@gnu.org>
9863
9864 * emacs.c (emacs_copyright): Update short copyright year to 2012.
9865
651e947e
EZ
98662012-01-01 Eli Zaretskii <eliz@gnu.org>
9867
9868 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
9869 Load gnutls_transport_set_lowat only if GnuTLS version is below
9870 2.11.1.
9871 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
9872 GnuTLS versions below 2.11.1.
9873
3778cdd8
AL
98742011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
9875
9876 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
9877 to the doc string advising against its use for altering the way
9878 windows are scrolled.
9879
0e5317f7
KH
98802011-12-28 Kenichi Handa <handa@m17n.org>
9881
9882 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
9883 coding-system ASCII compatible only when it does not produce BOM
9884 on encoding (Bug#10383).
9885
93d5ca1f
JD
98862011-12-26 Jan Djärv <jan.h.d@swipnet.se>
9887
9888 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
9889 can scroll.
9890 (create_and_show_popup_menu): Always use menu_position_func for
9891 Gtk3 (Bug#10361).
9892
ca22b785
AS
98932011-12-24 Andreas Schwab <schwab@linux-m68k.org>
9894
9895 * callint.c (Fcall_interactively): Don't truncate prompt string.
9896
d048e1e6
EZ
98972011-12-23 Eli Zaretskii <eliz@gnu.org>
9898
9899 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
9900 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9901 resumed from there (after widening). (Bug#10360)
d048e1e6 9902
5ccaba1f
JD
99032011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9904
9905 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
9906
204ee57f
JD
99072011-12-21 Jan Djärv <jan.h.d@swipnet.se>
9908
b81d40f0
JB
9909 * nsterm.m (x_free_frame_resources):
9910 Release f->output_data.ns->miniimage.
204ee57f
JD
9911 (ns_index_color): Fix indentation. Do not retain
9912 color_table->colors[i].
9913
9914 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
9915 before returning.
9916
9917 * nsfns.m (x_set_background_color): Assign return value from
9918 ns_index_color to face-background instead of NSColor*.
9919 (ns_implicitly_set_icon_type): Fix indentation.
9920 Change assignment in for loop to comparison.
9921
9922 * emacs.c (ns_pool): New variable.
9923 (main): Assign ns_pool.
9924 (Fkill_emacs): Call ns_release_autorelease_pool.
9925
9926 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9927 autorelease fdesc, release fdAttrs and tdict.
9928 (ns_get_covering_families): Release charset.
9929 (ns_findfonts): Release NSFontDescriptor created with new.
9930 (ns_uni_to_glyphs): Fix indentation.
9931 (setString): Release attrStr before assigning new value.
9932
c803b2b7
JD
99332011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9934
678f4426
JD
9935 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9936 and NS_IMPL_COCOA.
9937 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9938 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9939
cd394be1 99402011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9941
5fecd5fc
JD
9942 * nsterm.m (ns_term_init): Subscribe for notifications
9943 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9944 to method trackingNotification in EmacsMenu.
9945
9946 * nsmenu.m (trackingMenu): New variable.
3771cb17 9947 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9948 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9949 from Aquamacs (Bug#7030).
678f4426
JD
9950
99512011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9952
c803b2b7
JD
9953 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9954 (symbol_to_nsstring): Fix indentation.
9955 (ns_symbol_to_pb): New function.
cae07000
SM
9956 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9957 (Fns_rotate_cut_buffers_internal): Remove.
9958 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9959 Fns_store_cut_buffer_internal.
9960 (ns_get_foreign_selection, Fx_own_selection_internal)
9961 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9962 (Fns_get_selection_internal, Fns_store_selection_internal):
9963 Use ns_symbol_to_pb and check if return value is nil.
9964 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9965 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9966 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9967 renamed to Sns_store_selection_internal.
9968 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9969 and remove this function.
9970 (ns_handle_selection_clear): Remove, never used.
9971 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9972 here.
9973
e1b01a3a
KB
99742011-12-17 Ken Brown <kbrown@cornell.edu>
9975
9976 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9977 GID is unknown (Bug#10257).
9978
2adb6e85
PE
99792011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9980
9981 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9982 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9983 which caused a build failure on GNU/Linux IA-64. This problem was
9984 introduced by my 2011-10-07 patch.
9985
d1d7b339
JL
99862011-12-15 Juri Linkov <juri@jurta.org>
9987
9988 * image.c (imagemagick_error): New function. (Bug#10112)
9989 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9990 Use `imagemagick_error' where ImageMagick functions return
9991 `MagickFalse'.
9992 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9993 proper order.
9994
100d5755
KH
99952011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9996
9997 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9998 fill background (Bug#8992).
9999
454592a6
MR
100002011-12-13 Martin Rudalics <rudalics@gmx.at>
10001
10002 * window.c (Vwindow_combination_resize)
10003 (Vwindow_combination_limit): Use t instead of non-nil in
10004 doc-strings.
61d4b438
MR
10005 (Vrecenter_redisplay): Add first sentence of doc-string on
10006 separate line.
53524d93 10007 (Frecenter): Fix doc-string typo.
454592a6 10008
3633e3aa
KH
100092011-12-11 Kenichi Handa <handa@m17n.org>
10010
10011 * coding.c (Funencodable_char_position): Pay attention to the
10012 buffer text relocation (Bug#9389).
10013
7b9d523a 100142011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 10015
7b9d523a
JD
10016 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
10017 gtk_init (Bug#10100).
10018
b73189c6
EZ
100192011-12-10 Eli Zaretskii <eliz@gnu.org>
10020
10021 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
10022 IT->string is nil. (Bug#10263)
10023
f7dfe5d6
JD
100242011-12-10 Jan Djärv <jan.h.d@swipnet.se>
10025
83faebb4
JD
10026 * nsterm.h (x_free_frame_resources): Declare.
10027
f7dfe5d6
JD
10028 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
10029 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
10030
10031 * nsterm.h (ns_get_defaults_value): Declare.
10032
10033 * nsterm.m (ns_default): Call ns_get_defaults_value.
10034
7cd4e72c
EZ
100352011-12-09 Eli Zaretskii <eliz@gnu.org>
10036
10037 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
10038 (Bug#10170)
10039
b34d7317
YM
100402011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10041
10042 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
10043 that where the value of an _OBJC_* symbol points to is in the .bss
10044 section (Bug#10240).
10045
76470ad1
KH
100462011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10047
10048 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 10049 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 10050
745fff94
KH
100512011-12-08 Kenichi Handa <handa@m17n.org>
10052
10053 * ftfont.c (get_adstyle_property): Fix previous change
10054 (Bug#10233).
10055
6e44397c
JB
100562011-12-07 Juanma Barranquero <lekktu@gmail.com>
10057
10058 * w32.c (init_environment): If no_site_lisp, remove site-lisp
10059 dirs from the default value of EMACSLOADPATH (bug#10208).
10060
7efa6272
GM
100612011-12-07 Glenn Morris <rgm@gnu.org>
10062
10063 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
10064 installation and source directories as well. (Bug#10208)
10065
f6fc4d87
CY
100662011-12-06 Chong Yidong <cyd@gnu.org>
10067
10068 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
10069
2bf26180
GM
100702011-12-06 Glenn Morris <rgm@gnu.org>
10071
10072 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
10073 as an error, not just -1. (Bug#10217)
10074
3a6ad4f0
CY
100752011-12-05 Chong Yidong <cyd@gnu.org>
10076
10077 * keyboard.c (process_special_events): New function.
10078 (swallow_events, Finput_pending_p): Use it (Bug#10195).
10079
75a3b399
PE
100802011-12-05 Paul Eggert <eggert@cs.ucla.edu>
10081
10082 * coding.c (encode_designation_at_bol): Don't use uninitialized
10083 local variable (Bug#9318).
10084
c3c9e25e
KH
100852011-12-05 Kenichi Handa <handa@m17n.org>
10086
10087 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
10088 return Qnil (Bug#8046, Bug#10193).
10089
5eb05ea3
KH
100902011-12-05 Kenichi Handa <handa@m17n.org>
10091
10092 * coding.c (encode_designation_at_bol): New args charbuf_end and
10093 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
10094 (coding_set_source): Return how many bytes coding->source was
10095 relocated.
10096 (coding_set_destination): Return how many bytes
10097 coding->destination was relocated.
10098 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 10099 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
10100
101012011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
10102
10103 * coding.c (CODING_CHAR_CHARSET_P): New macro.
10104 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
10105 macro (Bug#9318).
10106
101072011-12-05 Andreas Schwab <schwab@linux-m68k.org>
10108
10109 The following changes are to fix Bug#9318.
10110
a79703f5 10111 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
10112 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
10113 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 10114 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 10115
7dbda6df
JB
101162011-12-05 Juanma Barranquero <lekktu@gmail.com>
10117
10118 * lisp.h (process_quit_flag): Fix external declaration.
10119
6d5eb5b0
SM
101202011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
10121
10122 Don't macro-inline non-performance-critical code.
10123 * eval.c (process_quit_flag): New function.
10124 * lisp.h (QUIT): Use it.
10125
a0c3fad0
JD
101262011-12-04 Jan Djärv <jan.h.d@swipnet.se>
10127
10128 * nsfns.m (get_geometry_from_preferences): New function.
10129 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
10130
6c07aac2
AS
101312011-12-04 Andreas Schwab <schwab@linux-m68k.org>
10132
10133 * emacs.c (Qkill_emacs): Define.
10134 (syms_of_emacs): Initialize it.
10135 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
10136 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
10137 (quit_throw_to_read_char): Add parameter `from_signal'.
10138 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
10139 * lisp.h (QUIT): Call Fkill_emacs if requested.
10140
c052ead4
JD
101412011-12-03 Jan Djärv <jan.h.d@swipnet.se>
10142
10143 * widget.c (update_wm_hints): Return if wmshell is null.
10144 (widget_update_wm_size_hints): New function.
10145
10146 * widget.h (widget_update_wm_size_hints): Declare.
10147
10148 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
10149 widget_update_wm_size_hints (Bug#10104).
10150
9e49252b
EZ
101512011-12-03 Eli Zaretskii <eliz@gnu.org>
10152
10153 * xdisp.c (handle_invisible_prop): If the invisible text ends just
10154 before a newline, prepare the bidi iterator for consuming the
10155 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 10156 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 10157
02b16839
JL
101582011-12-02 Juri Linkov <juri@jurta.org>
10159
10160 * search.c (Fword_search_regexp): New Lisp function created from
10161 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
10162 (Fword_search_backward, Fword_search_forward)
10163 (Fword_search_backward_lax, Fword_search_forward_lax):
10164 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
10165 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
10166
0068070e
SM
101672011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
10168
10169 * fileio.c (Finsert_file_contents): Move after-change-function call
10170 to before the "handled:" label, since all "goto handled" appear in
10171 cases where the *-change-functions have already been properly called
10172 (bug#10117).
10173
3360a3fc
AS
101742011-12-01 Andreas Schwab <schwab@linux-m68k.org>
10175
10176 * keyboard.c (interrupt_signal): Don't call kill-emacs when
10177 waiting for input. (Bug#10169)
10178
73d6c093
EZ
101792011-11-30 Eli Zaretskii <eliz@gnu.org>
10180
10181 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
10182 verifies glyph row's hash code--we have just reallocated the
10183 glyphs, so their contents can be complete garbage. (Bug#10164)
10184
febe6bea
JB
101852011-11-30 Juanma Barranquero <lekktu@gmail.com>
10186
10187 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
10188
801a4313
EZ
101892011-11-30 Eli Zaretskii <eliz@gnu.org>
10190
10191 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
10192 attributes are tested _before_ calling verify_row_hash, to protect
10193 against GCC re-ordering of the tests. (Bug#10164)
10194
2b56b87e
JD
101952011-11-29 Jan Djärv <jan.h.d@swipnet.se>
10196
10197 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
10198
10199 * xterm.c (handle_one_xevent): Only set async_visible and friends
10200 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 10201 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
10202 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
10203
dbf31225
PE
102042011-11-28 Paul Eggert <eggert@cs.ucla.edu>
10205
10206 Remove GCPRO-related macros that exist only to avoid shadowing locals.
10207 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
10208 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
10209 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
10210 All uses changed to use GCPRO1 etc.
10211 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
10212 Revert to old implementation (i.e., before 2011-03-11).
10213
1305621b
YM
102142011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10215
10216 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
10217 of scroll runs so as to avoid assigning disabled bogus rows and
10218 unnecessary graphics copy operations.
10219
8c9afb46
EZ
102202011-11-27 Eli Zaretskii <eliz@gnu.org>
10221
10222 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
10223 (snprintf) [_MSC_VER]: Redirect to _snprintf.
10224 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
10225 (malloc, free, realloc, calloc): Redirect to e_* only when
10226 compiling Emacs.
10227
10228 * lisp.h (GCTYPEBITS): Move before first use.
10229 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
10230 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
10231 this macro definition.
10232
10233 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
10234 _MSC_VER.
10235
54e9e3bf
JD
102362011-11-27 Jan Djärv <jan.h.d@swipnet.se>
10237
6d5eb5b0
SM
10238 * gtkutil.c (xg_create_frame_widgets):
10239 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
10240 present with Gtk+ 2.0.
10241
83aca1cb
PE
102422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
10243
10244 * fileio.c (Finsert_file_contents): Undo previous change; see
10245 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
10246
5b76caa4
PE
102472011-11-26 Paul Eggert <eggert@cs.ucla.edu>
10248
10249 Rename locals to avoid shadowing.
10250 * fileio.c (Finsert_file_contents):
10251 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
10252 * process.c (wait_reading_process_output):
10253 Rename inner 'proc' to 'p' to avoid shadowing.
10254 Indent for consistency with usual Emacs style.
10255
8c535114
EZ
102562011-11-25 Eli Zaretskii <eliz@gnu.org>
10257
10258 * xdisp.c (redisplay_window): If cursor row is not fully visible
10259 after recentering, and scroll-conservatively is set to a large
10260 number, scroll window by a few more lines to make the cursor fully
10261 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
10262 (start_display): Don't move to the next line if the display should
10263 start at a newline that is part of a display vector or an overlay
10264 string. (Bug#10119)
8c535114 10265
fa4fdb5c
JL
102662011-11-24 Juri Linkov <juri@jurta.org>
10267
10268 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
10269 after the `MagickPingImage' call. (Bug#10112)
10270
90ec88df
CY
102712011-11-23 Chong Yidong <cyd@gnu.org>
10272
10273 * window.c (Fcoordinates_in_window_p): Accept only live windows.
10274
56e2e794
MR
102752011-11-23 Martin Rudalics <rudalics@gmx.at>
10276
10277 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
10278 making another buffer current. (Bug#10114)
10279
b6e64c41
GM
102802011-11-23 Glenn Morris <rgm@gnu.org>
10281
10282 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
10283
6b21de18
CY
102842011-11-23 Chong Yidong <cyd@gnu.org>
10285
10286 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
10287 using it (Bug#5984).
10288
b12cd789
EZ
102892011-11-22 Eli Zaretskii <eliz@gnu.org>
10290
10291 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
10292 and header-lines, as they don't have one computed for them.
10293 (Bug#10098)
10294
10295 * .gdbinit (prow): Make displayed values more self-explaining.
10296 Add row's hash code.
10297
261b6fd4
LMI
102982011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
10299
10300 * process.c (wait_reading_process_output): Fix asynchrounous
10301 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 10302 (wait_reading_process_output): Add comment and URL.
261b6fd4 10303
e7cfd277
JD
103042011-11-21 Jan Djärv <jan.h.d@swipnet.se>
10305
10306 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
10307
a9b9b7f5
CY
103082011-11-21 Chong Yidong <cyd@gnu.org>
10309
10310 * window.c (Fnext_window, Fprevious_window): Doc fix.
10311
b0d15b4f
SM
103122011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10313
10314 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
10315
fe7a3057
JB
103162011-11-20 Juanma Barranquero <lekktu@gmail.com>
10317
10318 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
10319
d2999b1a
MR
103202011-11-20 Martin Rudalics <rudalics@gmx.at>
10321
10322 * window.c (Fset_window_combination_limit): Rename argument
10323 STATUS to LIMIT.
10324 (Vwindow_combination_limit): Remove "status" from doc-string.
10325
d5ff9cd0
AS
103262011-11-20 Andreas Schwab <schwab@linux-m68k.org>
10327
10328 * m/ibms390.h: Remove.
10329 * m/ibms390x.h: Don't include "ibms390.h".
10330
a5bb9bd3
SM
103312011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
10332
10333 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
10334 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
10335
cd1181db
JB
103362011-11-20 Juanma Barranquero <lekktu@gmail.com>
10337
10338 * casetab.c (Fset_case_table):
10339 * charset.c (Fcharset_after): Fix typos.
10340
615a3b8d 103412011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 10342
17e845af
PE
10343 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
10344 Otherwise, valgrind does not work on some platforms.
10345 Problem reported by Andreas Schwab in
6a0bf43d
PE
10346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
10347 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
10348 is set, removing the need for VIRT_ADDRESS_VARIES.
10349 (PURE_P): Use a more-efficient implementation that needs just one
10350 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
10351 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
10352 to 4 (xorl, subq, cmpq, setbe).
10353 * alloc.c (pure): Always extern now, since that's the
10354 VIRT_ADDR_VARIES behavior.
10355 (PURE_POINTER_P): Use a single comparison, not two, for
10356 consistency with the new puresize.h.
10357 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
10358 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
10359 Remove VIRT_ADDR_VARIES no longer needed.
10360
f8fe6f96
EZ
103612011-11-19 Eli Zaretskii <eliz@gnu.org>
10362
10363 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
10364 (erase_phys_cursor, update_window_cursor, show_mouse_face)
10365 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
10366 behave as if the cursor position were at the window margin.
10367
10368 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
10369 and the cursor position is out of bounds, behave as if the cursor
10370 position were at the window margin. (Bug#10075)
10371
df05a53c
CY
103722011-11-18 Chong Yidong <cyd@gnu.org>
10373
10374 * window.c (Fwindow_combination_limit): Make first argument
10375 non-optional, since it is meaningless for live windows like the
10376 selected window.
61ccba97 10377
2071918e
DA
103782011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
10379
10380 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
10381
b50a28de
SM
103822011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
10383
10384 * intervals.c: Fix grafting over the whole buffer (bug#10071).
10385 (graft_intervals_into_buffer): Simplify.
10386
015137db
EZ
103872011-11-18 Eli Zaretskii <eliz@gnu.org>
10388
10389 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
10390 hash values of the two rows.
10391 (copy_row_except_pointers): Preserve the used[] arrays and the
10392 hash values of the two rows. (Bug#10035)
68c95424 10393 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
10394
10395 * xdisp.c (row_hash): New function, body extracted from
10396 compute_line_metrics.
10397 (compute_line_metrics): Call row_hash, instead of computing the
10398 hash code inline.
10399
10400 * dispnew.c (verify_row_hash): Call row_hash for computing the
10401 hash code of a row, instead of duplicating code from xdisp.c.
10402
10403 * dispextern.h (row_hash): Add prototype.
10404
a2addb04
TH
104052011-11-18 Tassilo Horn <tassilo@member.fsf.org>
10406
10407 * frame.c (delete_frame): Don't delete the terminal when the last
10408 X frame is closed if emacs is built with GTK toolkit.
10409
df85d315
JB
104102011-11-17 Juanma Barranquero <lekktu@gmail.com>
10411
10412 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
10413
a0c2d0ae
MR
104142011-11-17 Martin Rudalics <rudalics@gmx.at>
10415
10416 * window.c (Vwindow_splits): Rename to
10417 Vwindow_combination_resize. Suggested by Juri Linkov.
10418 (Fsplit_window_internal): Use Vwindow_combination_resize instead
10419 of Vwindow_splits.
10420
58179cce
JB
104212011-11-16 Juanma Barranquero <lekktu@gmail.com>
10422
7877f373
JB
10423 * nsfns.m (Fns_font_name):
10424 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 10425
b6f67890
MR
104262011-11-16 Martin Rudalics <rudalics@gmx.at>
10427
10428 * window.h (window): Rename slot "nest" to "combination_limit".
10429 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
10430 (Fset_window_nest): Rename to Fset_window_combination_limit.
10431 (Vwindow_nest): Rename to Vwindow_combination_limit.
10432 (recombine_windows, make_parent_window, make_window)
10433 (Fsplit_window_internal, saved_window)
10434 (Fset_window_configuration, save_window_save): Rename all
10435 occurrences of window_nest to window_combination_limit.
10436
c7015153
JB
104372011-11-15 Juanma Barranquero <lekktu@gmail.com>
10438
10439 * image.c (imagemagick_load_image): Fix typo.
10440
322ad6ec
EZ
104412011-11-14 Eli Zaretskii <eliz@gnu.org>
10442
10443 * xdisp.c (display_line): Move the call to
10444 highlight_trailing_whitespace before the call to
10445 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
10446 faces of all the glyphs to compute ROW's hash value.
10447 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 10448
f067b8ec
JB
104492011-11-14 Juanma Barranquero <lekktu@gmail.com>
10450
10451 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
10452 just return (bug#10044).
10453
1e5b2111
EZ
104542011-11-12 Eli Zaretskii <eliz@gnu.org>
10455
7ef3cbd5
EZ
10456 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
10457 with user-defined heap size. Bump the default size of the temacs
10458 heap to 27MB, to avoid memory warning when running temacs.
10459 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
10460
1e5b2111
EZ
10461 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
10462 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
10463 (verify_row_hash) [XASSERTS]: New function.
10464 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
10465 that the hash value of glyph rows is correct.
1e5b2111 10466
89d61221
MR
104672011-11-12 Martin Rudalics <rudalics@gmx.at>
10468
10469 * window.h (window): Remove splits slot.
10470 * window.c (Fwindow_splits, Fset_window_splits): Remove.
10471 (Fdelete_other_windows_internal, make_parent_window)
10472 (make_window, Fsplit_window_internal, Fdelete_window_internal)
10473 (Fset_window_configuration, save_window_save): Don't deal with
10474 split status of windows.
10475 (saved_window): Remove splits slot.
10476 (Vwindow_splits): Rewrite doc-string.
10477
97f18cc8
JD
104782011-11-11 Jan Djärv <jan.h.d@swipnet.se>
10479
10480 * xfns.c (unwind_create_frame):
10481 * nsfns.m (unwind_create_frame):
10482 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
10483 Vframe_list (Bug#9999).
10484
22a648b4
DA
104852011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
10486
0b381c7e 10487 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 10488
659afede
KH
104892011-11-11 Kenichi Handa <handa@m17n.org>
10490
10491 * callproc.c (Fcall_process): Set the member dst_multibyte of
10492 process_coding.
10493
9ac0394b
KH
104942011-11-11 Johan Bockgård <bojohan@gnu.org>
10495
10496 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
10497 avoid a crash (bug#9496).
10498
2fbdc249
CY
104992011-11-09 Chong Yidong <cyd@gnu.org>
10500
10501 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
10502 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
10503
ac6b1f81
PE
105042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10505
10506 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
10507
09db192c
PE
105082011-11-08 Paul Eggert <eggert@cs.ucla.edu>
10509
10510 Avoid some portability problems by eschewing 'extern inline' functions.
10511 The trivial performance wins aren't worth the portability hassles; see
10512 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
10513 et seq.
10514 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10515 (window_box_width, window_box_left, window_box_left_offset)
10516 (window_box_right, window_box_right_offset): Undo previous change,
10517 by removing the "extern"s.
10518 * intervals.c (adjust_intervals_for_insertion)
10519 (adjust_intervals_for_deletion): Undo previous change,
10520 making these static again.
10521 (offset_intervals, temp_set_point_both, temp_set_point)
10522 (copy_intervals_to_string): No longer inline.
10523 * xdisp.c (window_text_bottom_y, window_box_width)
10524 (window_box_height, window_box_left_offset)
10525 (window_box_right_offset, window_box_left, window_box_right)
10526 (window_box): No longer inline.
10527
105216ed
CY
105282011-11-08 Chong Yidong <cyd@gnu.org>
10529
10530 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
10531 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
10532 Signal an error if not a live window.
105216ed
CY
10533 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
10534 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
10535
ae9e237f
JB
105362011-11-07 Juanma Barranquero <lekktu@gmail.com>
10537
10538 * lisp.h (syms_of_abbrev): Remove declaration.
10539 Reported by CHENG Gao <chenggao@royau.me>.
10540
c7aa8333
EZ
105412011-11-07 Eli Zaretskii <eliz@gnu.org>
10542
10543 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
10544 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
10545 of temacs in GUI mode.
10546
be7f5545
MR
105472011-11-07 Martin Rudalics <rudalics@gmx.at>
10548
10549 * window.h: Declare delete_all_child_windows instead of
10550 delete_all_subwindows.
10551 * window.c (Fwindow_nest, Fset_window_nest)
10552 (Fset_window_new_total, Fset_window_new_normal)
10553 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
10554 (delete_all_subwindows): Rename to delete_all_child_windows.
10555 (Fdelete_other_windows_internal, Fset_window_configuration):
10556 Call delete_all_child_windows instead of delete_all_subwindows.
10557 * frame.c (delete_frame): Call delete_all_child_windows instead
10558 of delete_all_subwindows.
10559
ca78dc43
PE
105602011-11-07 Paul Eggert <eggert@cs.ucla.edu>
10561
10562 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
10563 This is also needed for porting to any host where GC_MARK_STACK is
10564 not GC_MAKE_GCPROS_NOOPS.
10565 (which_symbols): Use it.
10566
a0241d01
KH
105672011-11-07 Kenichi Handa <handa@m17n.org>
10568
10569 * coding.c (coding_set_destination): Check coding->src_pos only
10570 when coding->src_object is a buffer (bug#9910).
10571
10572 * process.c (send_process): Set the member src_multibyte of coding
10573 to 0 (bug#9911) when sending a unibyte text.
10574
10575 * callproc.c (Fcall_process): Set the member src_multibyte of
10576 process_coding to 0 (bug#9912).
10577
a64bfdfa 105782011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
10579
10580 * xmenu.c (cleanup_widget_value_tree): New function.
10581 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
10582 calling free_menubar_widget_value_tree directly (Bug#9830).
10583
cb41b32a
PE
105842011-11-06 Paul Eggert <eggert@cs.ucla.edu>
10585
10586 Fix some portability problems with 'inline'.
10587 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
10588 (window_box_width, window_box_left, window_box_left_offset)
10589 (window_box_right, window_box_right_offset): Declare extern.
10590 Otherwise, these inline functions do not conform to C99 and
10591 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
10592 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
10593 * intervals.c (adjust_intervals_for_insertion)
10594 (adjust_intervals_for_deletion): Now extern, because otherwise the
10595 extern inline functions 'offset_intervals' couldn't refer to it.
10596 (static_offset_intervals): Remove.
10597 (offset_intervals): Rewrite using the old contents of
10598 static_offset_intervals. The old version didn't conform to C99
10599 because an extern inline function contained a reference to an
10600 identifier with static linkage.
10601
b7041366
AS
106022011-11-06 Andreas Schwab <schwab@linux-m68k.org>
10603
10604 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
10605 GC.
10606
88a37c4d
EZ
106072011-11-06 Eli Zaretskii <eliz@gnu.org>
10608
10609 * xdisp.c (init_iterator, reseat_to_string): Don't set the
10610 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
10611 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
10612 return Qleft_to_right.
10613
49745b39
CY
106142011-11-06 Chong Yidong <cyd@gnu.org>
10615
10616 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
10617 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
10618 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
10619 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
10620 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
10621 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
10622 (Fwindow_vscroll): Doc fix.
10623 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
10624 argument, since it makes no sense to pass a live window and for
10625 consistency with window-child.
10626
1f05cd82
CS
106272011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
10628
10629 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
10630 support MSVC.
10631
22610910
JR
106322011-11-05 Jason Rumney <jasonr@gnu.org>
10633
10634 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
10635 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
10636 fonts (Bug#6029).
10637 (add_font_entity_to_list): Fix logic errors in mixed boolean and
10638 bitwise arithmetic preventing use of unicode-sip and non-truetype
10639 opentype fonts.
10640
a06776b2
EZ
106412011-11-05 Eli Zaretskii <eliz@gnu.org>
10642
3ad924ba
EZ
10643 * s/ms-w32.h (fstat, stat, utime): Move redirections to
10644 "emacs"-only part.
10645
a06776b2
EZ
10646 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
10647 initialization code to keep similarity to xfns.c after changes
10648 from 2011-11-05.
10649
c9e7db78
JD
106502011-11-05 Jan Djärv <jan.h.d@swipnet.se>
10651
a97f8f3f
JD
10652 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
10653 (unwind_create_frame): New function (Bug#9943).
10654 (Fx_create_frame): Restructure code to be more similar to the one in
10655 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
10656 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
10657 Move terminal->reference_count++ just before making the frame official
10658 (Bug#9943).
10659
10660 * nsterm.m (x_free_frame_resources): New function.
10661 (x_destroy_window): Move code to x_free_frame_resources.
10662
c9e7db78 10663 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
10664 (Fx_create_frame, x_create_tip_frame):
10665 Move terminal->reference_count++ just before making the frame
75f1671a 10666 official. Move initialization of image_cache_refcount and
c9e7db78
JD
10667 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
10668
a6fc3b5c
EZ
106692011-11-05 Eli Zaretskii <eliz@gnu.org>
10670
10671 Support MSVC build with newer versions of Visual Studio.
10672 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
10673 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
10674 nt/gmake.defs.
10675
10676 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
10677 which are not supported by MSVC.
10678 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
10679 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
10680 bitfields.
10681 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
10682 types in bitfields.
10683 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
10684
10685 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
10686
58179cce 106872011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
10688
10689 Support MSVC build with newer versions of Visual Studio.
10690 * w32.c: Don't include w32api.h for MSVC.
10691 (init_environment) [_MSC_VER]: Call sys_access, not _access.
10692
10693 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
10694 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
10695 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
10696 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
10697 e_* cousins.
10698 (alloca) [_MSC_VER]: Define to _alloca.
10699
10700 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
10701
10702 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
10703
a58c13ed
EZ
107042011-11-04 Eli Zaretskii <eliz@gnu.org>
10705
10706 * xdisp.c (note_mouse_highlight): If either of
10707 previous/next-single-property-change returns nil, treat that as
10708 the beginning or the end of the buffer. (Bug#9955)
10709
fe0b6370
JD
107102011-11-04 Jan Djärv <jan.h.d@swipnet.se>
10711
a58c13ed 10712 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
10713 label is not null (Bug#9951).
10714 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
10715 may be NULL.
10716
89bd5ee1
EZ
107172011-11-04 Eli Zaretskii <eliz@gnu.org>
10718
10719 * window.c (Fwindow_body_size): Mention in the doc string that the
10720 return value is in frame's canonical units. (Bug#9949)
10721
84c3edb9
EZ
107222011-11-03 Eli Zaretskii <eliz@gnu.org>
10723
4e2fb5c7
EZ
10724 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
10725
84c3edb9 10726 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 10727 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 10728 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 10729
bc17a887
EZ
107302011-11-01 Eli Zaretskii <eliz@gnu.org>
10731
10732 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
10733 Don't stop backward scan on the continuation glyph, even though
10734 its CHARPOS is positive.
6d5eb5b0
SM
10735 (mouse_face_from_buffer_pos, note_mouse_highlight):
10736 Rename cover_string to disp_string.
bc17a887 10737
4ee88440
MR
107382011-11-01 Martin Rudalics <rudalics@gmx.at>
10739
10740 * window.c (temp_output_buffer_show): Don't use
10741 Vtemp_buffer_show_specifiers.
10742 (Vtemp_buffer_show_specifiers): Remove unused variable.
10743
c2ff3c02
EZ
107442011-10-30 Eli Zaretskii <eliz@gnu.org>
10745
10746 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
10747 past the beginning of the current glyph matrix.
10748
58179cce 107492011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
10750
10751 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
10752 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
10753 HAVE_GTK3 (Bug#9869).
b77a6a7f 10754
3b574623
JD
10755 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
10756 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
10757
b77a6a7f
JD
10758 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
10759
10760 * xterm.c: Declare x_handle_net_wm_state to return int.
10761 (handle_one_xevent): Check if we are iconified but don't have
10762 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
10763 (get_current_wm_state): Return non-zero if not hidden,
10764 check for _NET_WM_STATE_HIDDEN (Bug#9893).
10765 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
10766 (x_handle_net_wm_state): Return what get_current_wm_state returns.
10767 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
10768
196e41e4
PE
107692011-10-29 Paul Eggert <eggert@cs.ucla.edu>
10770
10771 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
10772 so that this new function doesn't get optimized away by a
10773 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
10774
021f2e1a
AS
107752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10776
10777 * frame.h (MOUSE_HL_INFO): Remove excess parens.
10778
8b058d44
EZ
107792011-10-29 Eli Zaretskii <eliz@gnu.org>
10780
10781 Fix the `xbytecode' command.
10782 * .gdbinit (xprintbytestr): New command.
b50a28de 10783 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
10784 (xbytecode): Print the byte-code string as well.
10785
4452fb80
EZ
107862011-10-29 Kim Storm <storm@cua.dk>
10787
8b058d44
EZ
10788 * alloc.c (which_symbols): New function.
10789
21b72067
AS
107902011-10-29 Andreas Schwab <schwab@linux-m68k.org>
10791
10792 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
10793 line. (Bug#9903)
10794
83ed7b5c
GM
107952011-10-29 Glenn Morris <rgm@gnu.org>
10796
10797 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
10798 Not clear what it was for, and it causes various bugs. (Bug#9839)
10799
5a7a728b
EZ
108002011-10-28 Eli Zaretskii <eliz@gnu.org>
10801
10802 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
10803 possible random value that matches one of those tested as
10804 condition to clear the mouse face.
10805
d3d0842f
CY
108062011-10-28 Chong Yidong <cyd@gnu.org>
10807
10808 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
10809
31b39d13
DN
108102011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
10811
10812 * window.c (make_window): Initialize phys_cursor_on_p.
10813
9aba6043
SM
108142011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
10815
10816 * lisp.h (struct Lisp_Symbol): Update comments.
10817
c20992f4
JB
108182011-10-28 Juanma Barranquero <lekktu@gmail.com>
10819
10820 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
10821
db4f02f2
EZ
108222011-10-28 Eli Zaretskii <eliz@gnu.org>
10823
10824 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
10825 <oslsachem@gmail.com> for helping to debug this.
10826
10827 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
10828 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
10829 (g_b_init_get_glyph_outline_w): New static variables.
10830 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
10831 (GetGlyphOutlineW_Proc): New typedefs.
10832 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
10833 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
10834 New functions.
10835 (w32font_open_internal, compute_metrics):
10836 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
10837 instead of calling the "wide" APIs directly.
10838
10839 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
10840
10841 * w32.h (syms_of_w32font): Add prototype.
10842
87e68db4
JB
108432011-10-27 Juanma Barranquero <lekktu@gmail.com>
10844
10845 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
10846 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
10847 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
10848 (Fmove_to_window_line): Doc fix.
10849
435c1d67
CY
108502011-10-27 Chong Yidong <cyd@gnu.org>
10851
10852 * process.c (make_process): Set gnutls_state to NULL.
10853
10854 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
10855 non-NULL, regardless of GNUTLS_INITSTAGE.
10856 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
10857 an error. Set process slots as soon as we allocate them.
10858
10859 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
10860
9c6c6f49
CY
108612011-10-27 Chong Yidong <cyd@gnu.org>
10862
9aba6043
SM
10863 * gnutls.c (emacs_gnutls_deinit): New function.
10864 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
10865 (Fgnutls_deinit, Fgnutls_boot): Use it.
10866
10867 * process.c (make_process): Initialize GnuTLS credentials to NULL.
10868 (deactivate_process): Call emacs_gnutls_deinit.
10869
657d08d3
JB
108702011-10-27 Juanma Barranquero <lekktu@gmail.com>
10871
10872 * image.c (x_create_x_image_and_pixmap):
10873 * w32.c (sys_rename, w32_delayed_load):
10874 * w32font.c (fill_in_logfont):
10875 * w32reg.c (x_get_string_resource): Silence compiler warnings.
10876
5430d399
JB
108772011-10-26 Juanma Barranquero <lekktu@gmail.com>
10878
10879 * w32fns.c (w32_default_color_map): New function,
10880 extracted from Fw32_default_color_map.
a7ef684b 10881 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 10882
fe0055fa
PE
108832011-10-25 Paul Eggert <eggert@cs.ucla.edu>
10884
10885 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10886
e6346438
SM
108872011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
10888
10889 * keyboard.c (test_undefined): New function (bug#9751).
10890 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
10891
e112cc37
ET
108922011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
10893
10894 * sysdep.c (init_sys_modes): Fix the check for the controlling
10895 terminal (Bug#6649).
10896
7b5d6677
EZ
108972011-10-20 Eli Zaretskii <eliz@gnu.org>
10898
10899 * dispextern.h (struct bidi_it): New member next_en_type.
10900
10901 * bidi.c (bidi_line_init): Initialize the next_en_type member.
10902 (bidi_resolve_explicit_1): When next_en_pos is valid for the
10903 current character, check also for next_en_type being WEAK_EN.
10904 (bidi_resolve_weak): Don't enter the expensive loop if the current
10905 position is before next_en_pos. Record the bidi type of the first
10906 non-ET, non-BN character we find, in addition to its position.
10907 (bidi_level_of_next_char): Invalidate next_en_type when
10908 next_en_pos is over-stepped.
10909
7da0b018
PE
109102011-10-20 Paul Eggert <eggert@cs.ucla.edu>
10911
10912 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
10913 * editfns.c: Rewrite current-time-zone so that it invokes
10914 the equivalent of (format-time-string "%Z") to get the time zone name.
10915 This fixes a bug when the time zone name contains characters that
10916 need converting from the system time locale to Emacs internal format.
10917 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10918 that patch fixed format-time-string to do the conversion, but
10919 I forgot to fix current-time-zone.
10920 (format_time_string): New function, containing most of
10921 what Fformat_time_string used to contain.
10922 (Fformat_time_string): Rewrite in terms of format_time_string.
10923 This doesn't change this function's behavior.
10924 (current-time-zone): Rewrite to use format_time_string.
10925 This fixes the bug reported by Michael Schierl in
10926 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10927 Jason Rumney's 2007-06-07 change worked around this bug, but
10928 didn't fix it.
10929 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10930
8547b010
EZ
109312011-10-19 Eli Zaretskii <eliz@gnu.org>
10932
10933 * xdisp.c (start_display): If the character at POS is displayed
10934 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10935 (try_window_reusing_current_matrix): If a line ends in a display
10936 vector or the next line starts in a display vector, continue
10937 redrawing the window even though the character position of
10938 start_row was reached.
8547b010
EZ
10939 (Bug#9771, part 2)
10940
4e948d15
CY
109412011-10-18 Chong Yidong <cyd@gnu.org>
10942
10943 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10944 with nobreak-char-display too.
10945
4787455f
EZ
109462011-10-18 Eli Zaretskii <eliz@gnu.org>
10947
10948 Fix part 3 of bug#9771.
10949 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10950 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10951 non-neutral characters if the current character is a paragraph
10952 separator (a.k.a. Newline). This avoids running the same
10953 expensive loop twice, once when we consume the preceding newline
10954 and the other time when the line actually needs to be displayed.
10955 Avoid the loop when we see neutrals on the base embedding level
10956 following a character whose directionality is the same as the
10957 paragraph's. This avoids running the expensive loop when a line
10958 ends in a long sequence of neutrals, like control characters.
10959 Add assertion against STRONG_AL type. Slightly rearrange code
10960 that determines the type of a neutral given the first non-neutral
10961 that follows it.
10962 (bidi_level_of_next_char): Set next_en_pos to zero when
10963 invalidating its info.
10964
2c91f553
EZ
109652011-10-17 Eli Zaretskii <eliz@gnu.org>
10966
10967 * xdisp.c (push_display_prop): Determine whether to record string
10968 or buffer position by IT->string, not by IT->method. Allow
10969 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10970 (move_it_vertically_backward): Don't look for character position
10971 immediately after the newline when in a continuation line.
10972 (Bug#9771, part 1)
2c91f553 10973
c7b08b0d
MR
109742011-10-15 Martin Rudalics <rudalics@gmx.at>
10975
10976 * window.c (coordinates_in_window): Rewrite and delabelize
10977 vertical border check. (Bug#5357) (Bug#9618)
10978
6b02f655
SM
109792011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10980
10981 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10982 errors in XSetWindowBorder (bug#9310).
10983
81d40c92
DA
109842011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10985
10986 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10987 avoid crash when xmalloc overrun checking is enabled.
10988
d4172c3b
EZ
109892011-10-13 Eli Zaretskii <eliz@gnu.org>
10990
10991 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10992 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10993 cursor motion with <left> and <right> arrow keys.
10994
10995 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10996 some callers set that themselves.
10997
b00eea75
EZ
109982011-10-12 Eli Zaretskii <eliz@gnu.org>
10999
11000 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
11001 display string and the previous row comes from the same string and
11002 is empty. (Bug#9739) (Bug#9738)
11003
8fe012c4
SM
110042011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
11005
11006 * doc.c (get_doc_string): Encode file name (bug#9735).
11007
0074aef2
EZ
110082011-10-12 Eli Zaretskii <eliz@gnu.org>
11009
79beb178
EZ
11010 * bidi.c (bidi_level_of_next_char):
11011 * xdisp.c (get_visually_first_element): Remove old incorrect
11012 comments regarding the Unicode Line Separator character.
11013
0074aef2
EZ
11014 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
11015
6e4b3fbe
DA
110162011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
11017
11018 * alloc.c (Fgc_status): Do not access beyond zombies array
11019 boundary if nzombies > MAX_ZOMBIES.
11020 * alloc.c (dump_zombies): Add missing format specifier.
11021
0324f3af
PE
110222011-10-12 Paul Eggert <eggert@cs.ucla.edu>
11023
b5525cac
PE
11024 * xdisp.c (set_cursor_from_row): Simplify conditionals,
11025 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
11026
0324f3af
PE
11027 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
11028 Some packages use them to denote characters with modifiers.
11029
e9b5f888
AS
110302011-10-11 Andreas Schwab <schwab@linux-m68k.org>
11031
11032 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
11033 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
11034 matching a pp-number. Rename parameter var to var1.
11035
127827c0
SM
110362011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
11037
11038 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
11039
c8fd3bd0
GM
110402011-10-08 Glenn Morris <rgm@gnu.org>
11041
11042 * callint.c (Fcall_interactively): Give a more explicit error for the
11043 'c' case with a non-character input. (Bug#8479)
11044
352ec8ff
EZ
110452011-10-08 Eli Zaretskii <eliz@gnu.org>
11046
03669ccb
EZ
11047 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
11048 lines.
7061c986
EZ
11049 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
11050 lines that are hscrolled on the left.
03669ccb 11051
352ec8ff
EZ
11052 * dispnew.c (buffer_posn_from_coords): Account for a possible
11053 presence of header-line. (Bug#4426)
11054
a66cfb1c
SM
110552011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
11056
6b02f655
SM
11057 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
11058 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 11059
7c5ee88e
PE
110602011-10-07 Paul Eggert <eggert@cs.ucla.edu>
11061
11062 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
11063 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
11064 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
11065 this makes Emacs dump core during garbage collection on rare
11066 occasions. sizeof is obviously inferior to offsetof here, so
11067 stick with offsetof.
11068 (GC_POINTER_ALIGNMENT): New macro.
11069 (mark_memory): Omit 3rd (offset) arg; caller changed.
11070 Don't assume EMACS_INT alignment is the same as pointer alignment.
11071
df1bbe5b
SM
110722011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
11073
11074 * keyboard.c (read_key_sequence_remapped): New var.
11075 (read_key_sequence): Compute remapping in the right buffer.
11076 (command_loop_1): Use read_key_sequence's remapping directly.
11077
51553db6
SM
110782011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
11079
32c1fffd
SM
11080 * dired.c (file_name_completion): Don't expand file name.
11081 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
11082 before checking file name handler.
11083
51553db6
SM
11084 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
11085 they've been requested explicitly (bug#9591).
11086
b6bd1599 110872011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
11088
11089 * keymap.c (Fsingle_key_description): Use make_specified_string
11090 instead of build_string to build string from push_key_description.
11091 (Bug#5193)
11092
f701dc2a
PE
110932011-09-30 Paul Eggert <eggert@cs.ucla.edu>
11094
4222c55d
PE
11095 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
11096 This fixes a Y2038 bug on 64-bit hosts.
11097 * buffer.c (reset_buffer):
11098 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
11099 (Fclear_buffer_auto_save_failure):
11100 Use 0, not -1, to represent an unset failure time, since time_t
11101 might not be signed.
11102
f701dc2a
PE
11103 Remove dependency on glibc malloc internals.
11104 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11105 Move back here from lisp.h, but with their new implementations.
11106 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11107 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
11108 * charset.c (charset_table_init): New static var.
11109 (syms_of_charset): Use it instead of xmalloc. This removes a
11110 dependency on glibc malloc internals. See Eli Zaretskii's comment in
11111 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
11112 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11113 Move back to alloc.c.
11114 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11115 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
11116
9ceebf39
JD
111172011-09-30 Jan Djärv <jan.h.d@swipnet.se>
11118
11119 * nsterm.m (windowDidResize): Call x_set_window_size only when
11120 ns_in_resize is true. Otherwise set pixelwidth/height and
11121 call change_frame_size (Bug#9628).
11122
cb993c58
PE
111232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
11124
3930c88b
PE
11125 Port --enable-checking=all to Fedora 14 x86-64.
11126 * charset.c (syms_of_charset): Also account for glibc malloc's
11127 internal overhead when calculating the initial malloc maximum.
11128
cb993c58
PE
11129 Port --enable-checking=all to Fedora 14 x86.
11130 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11131 Move to lisp.h.
11132 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
11133 (overrun_check_realloc, overrun_check_free):
11134 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
11135 That way, xmalloc returns a properly-aligned pointer even if
11136 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
11137 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
11138 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
11139 into account when calculating the initial malloc maximum.
11140 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
11141 Move here from alloc.c, so that charset.c can use it too.
11142 Properly align; the old code wasn't right for common 32-bit hosts
11143 when configured with --enable-checking=all.
11144 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
11145 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
11146
31bed486
EZ
111472011-09-29 Eli Zaretskii <eliz@gnu.org>
11148
04c70788 11149 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
11150 use EDOM.
11151
fbcaa2f3
EZ
111522011-09-28 Eli Zaretskii <eliz@gnu.org>
11153
11154 * xdisp.c (compute_display_string_end): If there's no display
11155 string at CHARPOS, return -1.
11156
11157 * bidi.c (bidi_fetch_char): When compute_display_string_end
11158 returns a negative value, treat the character as a normal
11159 character not covered by a display string. (Bug#9624)
11160
a239d4e9
JB
111612011-09-28 Juanma Barranquero <lekktu@gmail.com>
11162
11163 * lread.c (Fread_from_string): Fix typo in docstring.
11164
88652fd5
EZ
111652011-09-27 Eli Zaretskii <eliz@gnu.org>
11166
11167 * xdisp.c (handle_invisible_prop): If invisible text ends on a
11168 newline, reseat the iterator instead of bidi-iterating there one
11169 character at a time. (Bug#9610)
32c1fffd
SM
11170 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
11171 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 11172
ed497dd4
AS
111732011-09-27 Andreas Schwab <schwab@linux-m68k.org>
11174
11175 * lread.c (readevalloop): Use correct code for NBSP.
11176 (read1): Likewise. (Bug#9608)
11177
b2bf61aa
MA
111782011-09-25 Michael Albinus <michael.albinus@gmx.de>
11179
11180 * dbusbind.c (Fdbus_register_signal): When service is not
11181 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
11182
32bbb17c
GM
111832011-09-25 Glenn Morris <rgm@gnu.org>
11184
11185 * buffer.c (truncate-lines): Doc fix.
11186
94e0933e
CY
111872011-09-24 Chong Yidong <cyd@stupidchicken.com>
11188
11189 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
11190 (Fset_window_next_buffers): Doc fix.
11191
cddde921
GM
111922011-09-24 Glenn Morris <rgm@gnu.org>
11193
11194 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
11195
1260aef1
PE
111962011-09-24 Paul Eggert <eggert@cs.ucla.edu>
11197
25b4bfa0
PE
11198 Fix minor problems found by static checking.
11199 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
11200 * indent.c (Fvertical_motion): Fix == vs = typo.
11201
e3cbd34b
EZ
112022011-09-24 Eli Zaretskii <eliz@gnu.org>
11203
a66cfb1c
SM
11204 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
11205 Default value is now t. Doc fix.
6bf7006f 11206
e3cbd34b 11207 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 11208 logic when moving up, not only when moving down. Fix the
e3cbd34b 11209 confusing name and values of the it_overshoot_expected variable;
32c1fffd 11210 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
11211
11212 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
11213 CHARPOS is covered by a display string which includes newlines.
11214 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
11215 is covered by a display string with embedded newlines.
11216
a3de0cbd
MA
112172011-09-24 Michael Albinus <michael.albinus@gmx.de>
11218
11219 * dbusbind.c (Fdbus_register_signal): Add match rule to
11220 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
11221 (Fdbus_register_method, Vdbus_registered_objects_table):
11222 Fix docstring.
a3de0cbd 11223
b260039d
JM
112242011-09-24 Jim Meyering <meyering@redhat.com>
11225
32c1fffd 11226 do not ignore write error for any output size
b260039d
JM
11227 The previous change was incomplete.
11228 While it makes emacs --batch detect the vast majority of stdout
11229 write failures, errors were still ignored whenever the output size is
11230 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
11231 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
11232 && echo FAIL: ignored write error
11233 FAIL: ignored write error
11234 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
11235 && echo FAIL: ignored write error
11236 FAIL: ignored write error
11237 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
11238
8eca8a7c
AS
112392011-09-23 Andreas Schwab <schwab@linux-m68k.org>
11240
11241 * emacs.c (Fkill_emacs): In noninteractive mode exit
11242 non-successfully if a write error occurred on stdout. (Bug#9574)
11243
3341db62
EZ
112442011-09-21 Eli Zaretskii <eliz@gnu.org>
11245
11246 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
11247 the xassert test.
11248
11249 * dispextern.h (struct it): Update the comment documenting what
11250 can it->OBJECT be.
11251
8c203dbf
EZ
112522011-09-20 Eli Zaretskii <eliz@gnu.org>
11253
11254 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
11255 a display string, extend search for cursor position to end of row.
11256 (find_row_edges): If the row ends in a newline from a display
11257 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
11258 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
11259 (Fcurrent_bidi_paragraph_direction): Fix search for previous
11260 non-empty line. Fixes confusing cursor motion with arrow keys at
11261 the beginning of a line that starts with whitespace.
8c203dbf 11262
a4824228
LMI
112632011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11264
11265 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
11266 (bug#9493).
11267
33ed493b
CY
112682011-09-18 Chong Yidong <cyd@stupidchicken.com>
11269
11270 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
11271 boolean (Bug#9154).
11272
56cd55c8
EZ
112732011-09-18 Eli Zaretskii <eliz@gnu.org>
11274
11275 * xdisp.c (display_line): Record maximum and minimum buffer
11276 positions even if no glyphs were produced (e.g., by a zero-width
11277 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
11278 buffer positions that will be removed from the glyph row because
11279 they don't fit.
c02dcedf
EZ
11280 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
11281 column is beyond frame width: don't subtract 1 "pixel" when
11282 computing width of the stretch.
3e62b7e0
EZ
11283 (reseat_at_next_visible_line_start): Undo the change made on
11284 2011-09-17 that saved paragraph information and restored it after
11285 the call to `reseat'. (Bug#9545)
56cd55c8 11286
5ed99d36 112872011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
11288
11289 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
11290 and turn window cursor on if cleared (Bug#9415).
11291
5ed99d36 112922011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
11293
11294 * search.c (boyer_moore): Take unibyte characters from pattern
11295 literally. (Bug#9458)
11296
9bade7b2
EZ
112972011-09-18 Eli Zaretskii <eliz@gnu.org>
11298
11299 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
11300
e5e9d610
PE
113012011-09-18 Paul Eggert <eggert@cs.ucla.edu>
11302
87e4427a
PE
11303 Fix minor problem found by static checking.
11304 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
11305 initialized, to pacify gcc -Wuninitialized.
11306
e5e9d610
PE
11307 * fileio.c: Report proper errno when syscall falls.
11308 (Finsert_file_contents): Save and restore errno,
11309 so that report_file_error outputs the correct diagnostic.
11310 (Fwrite_region) [CLASH_DETECTION]: Likewise.
11311
a1674f0b
EZ
113122011-09-18 Eli Zaretskii <eliz@gnu.org>
11313
11314 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
11315
fbfb6dd4
EZ
113162011-09-17 Eli Zaretskii <eliz@gnu.org>
11317
11318 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
11319 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
11320
bb187662
EZ
113212011-09-17 Eli Zaretskii <eliz@gnu.org>
11322
1137e8b8 11323 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 11324 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
11325
11326 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
11327 (bidi_find_paragraph_start): Search back for paragraph beginning
11328 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
11329 (bidi_move_to_visually_next): Only trigger paragraph-related
11330 computations when the last character is a newline or at EOB, not
11331 just any NEUTRAL_B. (Bug#9470)
11332
bb187662
EZ
11333 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
11334 truncated lines if point is covered by a display string. (Bug#9524)
11335
2e621251
PE
113362011-09-16 Paul Eggert <eggert@cs.ucla.edu>
11337
11338 * xselect.c: Relax test for outgoing X longs (Bug#9498).
11339 (cons_to_x_long): New function.
11340 (lisp_data_to_selection_data): Use it. Correct the test for
11341 short-versus-long data; it was negated. Break out of vector
11342 loop, for efficiency, when a long datum is discovered.
11343
91a15bc6
SM
113442011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
11345
11346 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
11347
b41c3a35
EZ
113482011-09-16 Eli Zaretskii <eliz@gnu.org>
11349
11350 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
11351 GCC PR/17406) by declaring this function with external scope.
11352
7812ba2d
PE
113532011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11354
11355 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
11356 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
11357
cf7edc2a
AS
113582011-09-15 Andreas Schwab <schwab@linux-m68k.org>
11359
11360 * editfns.c (Fformat): Correctly handle text properties on "%%".
11361
bd01620e
EZ
113622011-09-15 Eli Zaretskii <eliz@gnu.org>
11363
11364 * xterm.c (x_draw_composite_glyph_string_foreground):
11365 * w32term.c (x_draw_composite_glyph_string_foreground):
11366 * term.c (encode_terminal_code):
11367 * composite.c (composition_update_it, get_composition_id):
11368 * xdisp.c (get_next_display_element)
11369 (fill_composite_glyph_string): Add comments about special meaning
11370 of TAB characters in a composition.
11371
a02719a3
PE
113722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
11373
11374 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
11375 This occurs when processing a multibyte format.
11376 Problem reported by Wolfgang Jenker.
a02719a3 11377
72589a3c
JB
113782011-09-15 Johan Bockgård <bojohan@gnu.org>
11379
11380 * xdisp.c (try_cursor_movement): Only check for exact match if
11381 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
11382
1c14176c
PE
113832011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11384
11385 Remove unused external symbols.
11386 * dispextern.h (calc_pixel_width_or_height): Remove decl.
11387 * xdisp.c (calc_pixel_width_or_height): Now static.
11388 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
11389 * indent.c (check_display_width):
11390 * w32term.c: Fix comment to match code.
11391 * xterm.c, xterm.h (x_catching_errors): Remove.
11392
d2eea5b5
PE
113932011-09-14 Paul Eggert <eggert@cs.ucla.edu>
11394
11395 * xselect.c: Use signed conversions more consistently (Bug#9498).
11396 (selection_data_to_lisp_data): Assume incoming selection data are
11397 signed integers, not unsigned. This is to be consistent with
11398 outgoing selection data, which was modified to use signed integers
11399 in as part of the fix to Bug#9196 in response to Jan D.'s comment
11400 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
11401 expects long, not unsigned long.
11402
46888499
EZ
114032011-09-14 Eli Zaretskii <eliz@gnu.org>
11404
11405 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
11406 computation of loop end. Reported by Johan Bockgård
11407 <bojohan@gnu.org>.
11408
ef8ef9fb
CY
114092011-09-13 Chong Yidong <cyd@stupidchicken.com>
11410
11411 * frame.c (Fother_visible_frames_p): Function deleted.
11412
fa819fed
EZ
114132011-09-12 Eli Zaretskii <eliz@gnu.org>
11414
11415 * indent.c (compute_motion): Process display vector front to back
11416 rather than the other way around. (Bug#2496)
11417
2ba8e008
SM
114182011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
11419
11420 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
11421
20f53c69
CY
114222011-09-11 Chong Yidong <cyd@stupidchicken.com>
11423
11424 * minibuf.c (Fread_from_minibuffer): Doc fix.
11425
d562d7a4
EZ
114262011-09-11 Eli Zaretskii <eliz@gnu.org>
11427
11428 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
11429 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
11430
1c4d7f3d
LMI
114312011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
11432
11433 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
11434 value for non-existent files.
11435
b885bf36
EZ
114362011-09-11 Eli Zaretskii <eliz@gnu.org>
11437
11438 * fileio.c (Finsert_file_contents): If the file cannot be opened,
11439 set its "size" to -1. This will set the modtime_size field of
11440 the corresponding buffer to -1, which is what
11441 verify-visited-file-modtime expects for files that do not exist.
11442 (Bug#9139)
11443
6612f0bf
PE
114442011-09-11 Paul Eggert <eggert@cs.ucla.edu>
11445
11446 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
11447 here ...
11448 * lisp.h: ... from here. push_key_description is no longer
11449 defined in keyboard.c, so its declaration should not be in
11450 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
11451 logically belongs with push_key_description.
11452
dfb3f755
PE
114532011-09-10 Paul Eggert <eggert@cs.ucla.edu>
11454
11455 * buffer.h: Include <sys/types.h> instead of <time.h>.
11456 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
11457 Problem reported by Herbert J. Skuhra.
11458
3134906c
LMI
114592011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
11460
11461 * xml.c (parse_region): Make the parsing work for
11462 non-comment-starting XML files again (bug#9144).
11463
8d903f4e
AS
114642011-09-10 Andreas Schwab <schwab@linux-m68k.org>
11465
11466 * image.c (gif_load): Fix calculation of bottom and right corner.
11467 (Bug#9468)
11468
80ad64f4
EZ
114692011-09-10 Eli Zaretskii <eliz@gnu.org>
11470
11471 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
11472 redisplay in small windows.
11473
208a048d
EZ
114742011-09-09 Eli Zaretskii <eliz@gnu.org>
11475
11476 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
11477
9b1c252e
MR
114782011-09-08 Martin Rudalics <rudalics@gmx.at>
11479
11480 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
11481 Operate on live windows only.
11482
2949f33b
JB
114832011-09-08 Juanma Barranquero <lekktu@gmail.com>
11484
11485 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
11486
e08dcafd
EZ
114872011-09-07 Eli Zaretskii <eliz@gnu.org>
11488
11489 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
11490 only under bidi iteration.
11491
115b96bd
JD
114922011-09-07 Jan Djärv <jan.h.d@swipnet.se>
11493
11494 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
11495
c8199d0f
PE
114962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
11497
11498 isnan: Fix porting problem to Solaris 10 with bundled gcc.
11499 Without this fix, the command to link temacs failed due to an
11500 undefined symbol __builtin_isnan. This is because
11501 /usr/include/iso/math_c99.h #defines isnan(x) to
11502 __builtin_isnan(x), but the bundled gcc, which identifies itself
11503 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
11504 a __builtin_isnan.
11505 * floatfns.c (isnan): #undef, and then #define to a clone of
11506 what's in data.c.
11507 (Fisnan): Always define, since it's always available now.
11508 (syms_of_floatfns): Always define isnan at the Lisp level.
11509
e39b275c 115102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
11511
11512 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
11513
b2db44d9 115142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 11515
f4af5137 11516 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
11517 The previous code assumed that file offsets (off_t values) fit in
11518 EMACS_INT variables, which is not true on typical 32-bit hosts.
11519 The code messed up by falsely reporting buffer overflow in cases
11520 such as (insert-file-contents "big" nil 1 2) into an empty buffer
11521 when "big" contains more than 2**29 bytes, even though this
11522 inserts just one byte and does not overflow the buffer.
11523 (Finsert_file_contents): Store file offsets as off_t
11524 values, not as EMACS_INT values. Check for overflow when
11525 converting between EMACS_INT and off_t. When checking for
11526 buffer overflow or for overlap, take the offsets into account.
11527 Don't use EMACS_INT for small values where int suffices.
11528 When checking for overlap, fix a typo: ZV was used where
11529 ZV_BYTE was intended.
11530 (Fwrite_region): Don't assume off_t fits into 'long'.
11531 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
11532
ecfc0a49
MA
115332011-09-05 Michael Albinus <michael.albinus@gmx.de>
11534
11535 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
11536
6511acf2 115372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 11538
0999621a 11539 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
11540
11541 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 11542 (esprintf, exprintf, evxprintf): New functions.
62f19c19 11543 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 11544 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
11545 (modify_event_symbol): Do not assume that the length of
11546 name_alist_or_stem is safe to alloca and fits in int.
11547 (Fexecute_extended_command): Likewise for function name and binding.
11548 (Frecursion_depth): Wrap around reliably on integer overflow.
11549 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
11550 since some callers pass EMACS_INT values.
11551 (Fsingle_key_description): Don't crash if symbol name contains more
11552 than MAX_ALLOCA bytes.
11553 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
11554 (get_minibuffer): Arg is now EMACS_INT, not int.
11555 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 11556 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
11557 * window.h (command_loop_level, minibuf_level): Reflect API changes.
11558
2be7d702
PE
11559 * dbusbind.c (signature_cat): New function.
11560 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
11561 Do not overrun buffer; instead, report string overflow.
11562
9d1df220
PE
11563 * dispnew.c (add_window_display_history): Don't overrun buffer.
11564 Truncate instead; this is OK since it's just a log.
11565
33ef5c64
PE
11566 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
11567 even if the time zone offset is outlandishly large.
11568 Don't mishandle offset == INT_MIN.
11569
66c6fdd5
PE
11570 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
11571 when creating daemon; the previous buffer-overflow check was incorrect.
11572
d749b01b
PE
11573 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
11574 which has the guts of the old verror function.
11575
b5cd1905
PE
11576 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
11577 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
11578
6e1a67fb
PE
11579 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
11580 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 11581 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 11582 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
11583 length of string rather than counting it via multiple sprintfs;
11584 that's simpler and more reliable.
c21721cc
PE
11585 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
11586 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
11587 sprintf, in case result does not fit in int.
11588
c57b67fc
PE
11589 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
11590 (fontset_from_font): Print it.
11591
8a401434
PE
11592 * frame.c (tty_frame_count): Now printmax_t, not int.
11593 (make_terminal_frame, set_term_frame_name): Print it.
11594 (x_report_frame_params): In X, window IDs are unsigned long,
11595 not signed long, so print them as unsigned.
11596 (validate_x_resource_name): Check for implausibly long names,
11597 and don't assume name length fits in 'int'.
11598 (x_get_resource_string): Don't blindly alloca invocation name;
11599 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
11600 not fit in int.
11601
6e1a67fb
PE
11602 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
11603 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
11604 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
11605
0df02bf3
PE
11606 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
11607 Use esprintf, not sprintf, in case result does not fit in int.
11608
48e30793
PE
11609 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11610 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
11611 it as a large positive number.
11612 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
11613 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
11614
a66ff6d8
PE
11615 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
11616 in case result does not fit in int.
11617
aca216ff
PE
11618 * print.c (float_to_string): Detect width overflow more reliably.
11619 (print_object): Make sprintf buffer a bit bigger, to avoid potential
11620 buffer overrun. Don't assume list length fits in 'int'. Treat
11621 print length of 0 as 0, not as infinity; to be consistent with other
11622 uses of print length in this function. Don't overflow print length
11623 index. Don't assume hash table size fits in 'long', or that
11624 vectorlike size fits in 'unsigned long'.
11625
31c286f7
PE
11626 * process.c (make_process): Use printmax_t, not int, to format
11627 process-name gensyms.
11628
55e5faa1
PE
11629 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
11630
80f2e268
PE
11631 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
11632 to avoid potential buffer overrun.
11633
670741ab
PE
11634 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
11635 if X resource line is longer than 512 bytes.
11636
b7163a50
PE
11637 * xfns.c (x_window): Make sprintf buffer a bit bigger
11638 to avoid potential buffer overrun.
11639
ae58ff1f
PE
11640 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
11641
c43c8a6a
PE
11642 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
11643
3f8236f4
PE
116442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
11645
53e9fe90 11646 Integer overflow fixes for scrolling, etc.
6511acf2
PE
11647 Without these, Emacs silently mishandles large integers sometimes.
11648 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
11649 it were "C-u 1 M-x recenter" on a typical 64-bit host.
11650
6511acf2
PE
11651 * xdisp.c (try_window_id): Check Emacs fixnum range before
11652 converting to 'int'.
806add1d 11653
6511acf2 11654 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
11655 Check that an Emacs fixnum is in range before assigning it to 'int'.
11656 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
11657 values converted from Emacs fixnums.
11658 (Frecenter): Don't wrap around a line count if it is out of 'int'
11659 range; instead, treat it as an extreme value.
11660 (Fset_window_configuration, compare_window_configurations):
11661 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
11662
6511acf2
PE
11663 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
11664 that can exceed INT_MAX. Check that EMACS_INT value is in range
11665 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
11666 (match_limit): Don't assume that a fixnum can fit in 'int'.
11667
6511acf2 11668 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
11669 exceed INT_MAX.
11670
6511acf2 11671 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
11672 (Fvertical_motion): Don't wrap around LINES values that don't fit
11673 in 'int'. Instead, treat them as extreme values. This is good
11674 enough for windows, which can't have more than INT_MAX lines anyway.
11675
fcb901a7
LMI
116762011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11677
0f2f6b6d
LMI
11678 * Require libxml/parser.h to avoid compilation warning.
11679
fcb901a7
LMI
11680 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
11681
11682 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
11683 since this reportedly can destroy thread storage.
11684
6e20a0d4
CY
116852011-08-30 Chong Yidong <cyd@stupidchicken.com>
11686
11687 * syntax.c (find_defun_start): Update all cache variables if
11688 exiting early (Bug#9401).
11689
148ae00e
EZ
116902011-08-30 Eli Zaretskii <eliz@gnu.org>
11691
f6cfbd8f
EZ
11692 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
11693
148ae00e
EZ
11694 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
11695 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
11696 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
11697
11698 * term.c (tty_append_glyph): New function.
11699 (produce_stretch_glyph): Static function and its prototype deleted.
11700
a66cfb1c
SM
11701 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
11702 Add prototypes.
148ae00e 11703
c4a07a4c
PE
117042011-08-29 Paul Eggert <eggert@cs.ucla.edu>
11705
11706 * image.c (parse_image_spec): Check for nonnegative, not for positive,
11707 when checking :margin (Bug#9390).
11708 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 11709 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
11710 so that the name doesn't mislead. All uses changed.
11711
6bc8cd65
JB
117122011-08-28 Johan Bockgård <bojohan@gnu.org>
11713
11714 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
11715 set_tty_hooks.
11716
dca4927e
EZ
117172011-08-27 Eli Zaretskii <eliz@gnu.org>
11718
11719 * xdisp.c (move_it_to): Don't bail out early when reaching
11720 position beyond to_charpos, if we are scanning backwards.
11721 (move_it_vertically_backward): When DY == 0, make sure we get to
11722 the first character in the line after the newline.
11723
f2cad773
PE
117242011-08-27 Paul Eggert <eggert@cs.ucla.edu>
11725
11726 * ccl.c: Improve and simplify overflow checking (Bug#9196).
11727 (ccl_driver): Do not generate an out-of-range pointer.
11728 (Fccl_execute_on_string): Remove unnecessary check for
11729 integer overflow, noted by Stefan Monnier in
11730 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
11731 Remove a FIXME that didn't need fixing.
11732 Simplify the newly-introduced buffer reallocation code.
11733
0cae2cdb
JB
117342011-08-27 Juanma Barranquero <lekktu@gmail.com>
11735
11736 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
11737
5fc295a4 117382011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 11739
70c60eb2 11740 Integer and memory overflow issues (Bug#9196).
726e0ab1 11741
d31850da
PE
11742 * doc.c (get_doc_string): Rework so that
11743 get_doc_string_buffer_size is the actual buffer size, rather than
11744 being 1 less than the actual buffer size; this makes xpalloc more
11745 convenient.
11746
a69fbedb
PE
11747 * image.c (x_allocate_bitmap_record, cache_image):
11748 * xselect.c (Fx_register_dnd_atom):
11749 Simplify previous changes by using xpalloc.
11750
fe5c5d37
PE
11751 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
11752 since either will do and ptrdiff_t is convenient with xpalloc.
11753
0065d054
PE
11754 * charset.c (charset_table_size)
11755 (struct charset_sort_data.priority): Now ptrdiff_t.
11756 (charset_compare): Don't overflow if priorities differ greatly.
11757 (Fsort_charsets): Don't assume list length fits in int.
11758 Check for size-calculation overflow when allocating sort data.
11759 (syms_of_charset): Allocate an initial charset table that is
11760 just under 64 KiB, to avoid problems with glibc malloc and mmap.
11761
11762 * cmds.c (internal_self_insert): Check for size-calculation overflow.
11763
11764 * composite.h (struct composition.glyph_len): Now int, not unsigned.
11765 The actual value is always <= INT_MAX, and leaving it unsigned made
11766 overflow checking harder.
11767
11768 * dispextern.h (struct glyph_matrix.rows_allocated)
11769 (struct face_cache.size): Now ptrdiff_t, for convenience in use
11770 with xpalloc. The values are still always <= INT_MAX.
11771
11772 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
11773
11774 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
11775 (SAFE_NALLOCA): New macro.
11776
11777 * region-cache.c (struct boundary.pos, find_cache_boundary)
11778 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
11779 (set_cache_region, invalidate_region_cache)
11780 (revalidate_region_cache, know_region_cache, region_cache_forward)
11781 (region_cache_backward, pp_cache):
11782 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
11783 so that ptrdiff_t * can be passed to xpalloc.
11784 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
11785 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
11786 (pp_cache): Don't assume cache_len fits in int.
11787 * region-cache.h: Adjust extern decls to match.
11788
11789 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
11790 EMACS_INT, since either will do, for xpalloc.
11791
11792 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
11793 (xnmalloc, xnrealloc, xpalloc): New functions.
11794
726e0ab1
PE
11795 * bidi.c (bidi_shelve_header_size): New constant.
11796 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
11797 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
11798
51f30bc5 11799 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
11800 * buffer.c (overlays_at, overlays_in, record_overlay_string)
11801 (overlay_strings):
11802 Don't update size of array until after memory allocation succeeds,
11803 because xmalloc/xrealloc may not return.
0065d054
PE
11804 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
11805 now that we have proper integer overflow checking.
11806 (record_overlay_string, overlay_strings): Catch overflows when
11807 calculating size of overlay_str_buf.
726e0ab1 11808
0065d054
PE
11809 * callproc.c (Fcall_process): Check for size overflow when
11810 calculating size of args2.
11811 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
11812 Normally we prefer signed values, but sticking with ptrdiff_t would
11813 require adding more-complicated checks.
726e0ab1
PE
11814
11815 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
11816 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
11817 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 11818 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
11819
11820 * character.c (Fstring): Check for size-calculation overflow.
11821
11822 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
11823 unnecessary integer overflow. Check for size overflow.
11824 (encode_coding_object): Don't update size until xmalloc succeeds.
11825
11826 * composite.c (get_composition_id): Check for overflow in glyph
11827 length calculations.
11828
11829 Integer and memory overflow fixes for display code.
11830 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
11831 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
11832 (scrolling_window): Check for overflow in size calculations.
11833 (line_draw_cost, realloc_glyph_pool, add_row_entry):
11834 Don't assume glyph table len fits in int.
11835 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
11836 (row_table_size): Now ptrdiff_t, not int.
11837 (scrolling_window): Avoid overflow in size calculations.
11838 Don't update size until allocation succeeds.
11839 * fns.c (concat): Check for overflow in size calculations.
11840 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
11841 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11842 (NEXT_ALMOST_PRIME_LIMIT): New constant.
11843
11844 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
11845 (get_doc_string): Check for size calculation overflow.
11846 Don't update size until allocation succeeds.
11847 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
11848 EMACS_INT, where ptrdiff_t will do.
11849 (Fsubstitute_command_keys): Check for string overflow.
11850
11851 * editfns.c (set_time_zone_rule): Don't assume environment length
11852 fits in int.
11853 (message_length): Now ptrdiff_t, not int.
11854 (Fmessage_box): Don't update size until allocation succeeds.
11855 Don't assume message length fits in int.
11856 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11857
0065d054
PE
11858 * emacs.c (main): Do not reallocate argv, since there is a null at
11859 the end that can be overwritten, and this way there's no need to
11860 worry about size-calculation overflow.
11861 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
11862
11863 * eval.c (init_eval_once, grow_specpdl): Don't update size until
11864 alloc succeeds.
11865 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
11866
11867 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
11868 (x_set_scroll_bar_width, x_figure_window_size):
11869 Check for integer overflow.
11870 (x_set_alpha): Do not assume XINT fits in int.
11871
11872 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
11873 This is for the members text_lines, text_cols, total_lines, total_cols,
11874 where the system imposes an 'int' limit.
11875
11876 * fringe.c (Fdefine_fringe_bitmap):
11877 Don't update size until alloc works.
11878
11879 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
11880 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
11881
11882 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
11883 Check for size-calculation overflow.
11884 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
11885 do, as we prefer signed integers.
11886 (id_to_widget.max_size, id_to_widget.used)
11887 (xg_store_widget_in_map, xg_remove_widget_from_map)
11888 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11889 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
11890 Use and return ptrdiff_t, not int.
11891 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
11892 * gtkutil.h: Change prototypes to match the above.
11893
11894 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
11895 are duplicate now that they've been promoted to lisp.h.
11896 (x_allocate_bitmap_record, x_alloc_image_color)
11897 (make_image_cache, cache_image, xpm_load):
11898 Don't update size until alloc is done.
11899 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11900 (x_detect_edges):
3256efce 11901 Check for size calculation overflow.
726e0ab1
PE
11902 (ct_colors_allocated_max): New constant.
11903 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
11904 overflow.
3256efce 11905
726e0ab1
PE
11906 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
11907 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
11908 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
11909 Use ptrdiff_t, not int, to count maps.
11910 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
11911 calculations. Don't update size until allocation succeeds.
11912 Redo calculations to avoid overflow.
726e0ab1
PE
11913 * keyboard.h: Change prototypes to match the above.
11914
11915 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11916 to count maps.
11917 (current_minor_maps): Check for size calculation overflow.
11918 * keymap.h: Change prototypes to match the above.
11919
11920 * lread.c (read1, init_obarray): Don't update size until alloc done.
11921
11922 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11923 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11924
726e0ab1
PE
11925 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11926 Now ptrdiff_t, not int.
11927 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11928 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11929
11930 * process.c (Fnetwork_interface_list): Check for overflow
11931 in size calculation.
11932
11933 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11934
11935 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11936 overflow. Don't bother calling xmalloc when xrealloc will do.
11937
11938 * search.c (Freplace_match): Check for size calculation overflow.
11939 (Fset_match_data): Don't assume list lengths fit in 'int'.
11940
11941 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11942 for command line length. Do not attempt to address one before the
11943 beginning of an array, as that's not portable.
11944
11945 * term.c (max_frame_lines): Remove; unused.
11946 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11947 not int.
11948 (encode_terminal_code, calculate_costs): Check for size
11949 calculation overflow.
11950 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11951 table lengths and related sizes. Don't update size until alloc
11952 done. Redo calculations to avoid overflow.
11953 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11954
11955 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11956 subtracting pointers.
11957 (gobble_line): Check for overflow more carefully. Don't update size
11958 until alloc done.
11959
11960 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11961 Don't update size until alloc done.
11962 Redo size calculations to avoid overflow.
11963 Check for size calculation overflow.
0065d054 11964 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11965
11966 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11967 Use ptrdiff_t, not int, for sizes.
11968 (store_mode_line_noprop_char): Don't update size until alloc done.
11969
0065d054
PE
11970 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11971 Use ptrdiff_t, not int, for sizes.
11972 (Finternal_make_lisp_face, cache_face):
11973 Check for size calculation overflow.
11974 (cache_face): Treat size calculation overflows as if they were
11975 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11976
11977 * xfns.c (x_encode_text, x_set_name_internal)
11978 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11979 sizes, since they can exceed INT_MAX in size. Check for size
11980 calculation overflow.
11981
0065d054
PE
11982 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11983 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11984 Don't update size until alloc done.
11985
0065d054 11986 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11987 as sprintf is limited to int lengths.
1d526e2f 11988
252c5ee1
PE
11989 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11990 (X_LONG_MIN): New macros.
864d7ce7
PE
11991 Use them to make the following changes clearer.
11992 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11993 This change doesn't affect the value now, but it may help remind
11994 future maintainers not to raise the value too much later.
11995 (SELECTION_QUANTUM): Remove, replacing with ...
11996 (selection_quantum): ... new function, which avoids overflow.
11997 All uses changed.
11998 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11999 assumption that selection length fits in 'int'.
12000 (x_reply_selection_request, x_handle_selection_request)
12001 (x_get_window_property, receive_incremental_selection)
12002 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
12003 (lisp_data_to_selection_data, clean_local_selection_data):
12004 Use ptrdiff_t, not int, to record length of selection.
12005 (x_reply_selection_request, x_get_window_property)
12006 (receive_incremental_selection, x_property_data_to_lisp):
12007 Redo calculations to avoid overflow.
12008 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 12009 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
12010 something.
12011 (x_get_window_property, receive_incremental_selection)
12012 (lisp_data_to_selection_data, x_property_data_to_lisp):
12013 Check for size-calculation overflow.
12014 (x_get_window_property, receive_incremental_selection)
12015 (lisp_data_to_selection_data, Fx_register_dnd_atom):
12016 Don't store size until memory allocation succeeds.
12017 (x_get_window_property): Plug memory leak on memory exhaustion.
12018 Don't double-block input; malloc is safe here. Don't assume 2**34
12019 - 4 fits in unsigned long. Add an xassert to check
12020 XGetWindowProperty overflow. Be more careful about overflow
12021 calculations, and distinguish size from memory overflow better.
12022 (receive_incremental_selection): When tracing, don't assume
12023 unsigned int is less than INT_MAX.
12024 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
12025 harmful) conversions of unsigned short to int.
12026 (lisp_data_to_selection_data): Don't assume that integers
12027 in the range -65535 through -1 fit in an X unsigned short.
12028 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
12029 result parameters unless successful. Rely on cons_to_unsigned
12030 to report problems with elements; the old code wasn't right anyway.
12031 (x_check_property_data): Check for int overflow; we cannot use
12032 a wider type due to X limits.
12033 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
12034
726e0ab1 12035 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 12036
0065d054
PE
12037 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
12038 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
12039 (x_color_cells): Don't store size until memory allocation succeeds.
12040 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 12041 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
12042 (x_term_init): Don't assume length fits in int (sprintf is limited
12043 to int size).
bc18e09d 12044
ebfa62c0
PE
12045 Use ptrdiff_t for composition IDs.
12046 * character.c (lisp_string_width):
12047 * composite.c (composition_table_size, n_compositions)
12048 (get_composition_id, composition_gstring_from_id):
12049 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
12050 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
12051 * window.c (Frecenter):
12052 Use ptrdiff_t, not int, for composition IDs.
12053 * composite.c (get_composition_id): Check for integer overflow.
12054 * composite.h: Adjust prototypes to match the above changes.
12055
d3411f89
PE
12056 Use ptrdiff_t for hash table indexes.
12057 * category.c (hash_get_category_set):
12058 * ccl.c (ccl_driver):
12059 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
12060 * coding.c (coding_system_charset_list, detect_coding_system):
12061 * coding.h (struct coding_system.id):
12062 * composite.c (get_composition_id, gstring_lookup_cache):
12063 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
12064 * image.c (xpm_get_color_table_h):
12065 * lisp.h (hash_lookup, hash_put):
12066 * minibuf.c (Ftest_completion):
12067 Use ptrdiff_t for hash table indexes, not int (which is too
12068 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
12069 32-bit --with-wide-int hosts).
12070
e097a6fa
PE
12071 * charset.c (Fdefine_charset_internal): Check for integer overflow.
12072 Add a FIXME comment about memory leaks.
12073 (syms_of_charset): Don't assume xmalloc returns.
12074
5637687f
PE
12075 Don't assume that stated character widths fit in int.
12076 * character.c (Fchar_width, c_string_width, lisp_string_width):
12077 * character.h (CHAR_WIDTH):
12078 * indent.c (MULTIBYTE_BYTES_WIDTH):
12079 Use sanitize_char_width to avoid undefined and/or bad behavior
12080 with outlandish widths.
a66cfb1c 12081 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
12082 now that we have two such functions. All uses changed.
12083 (sanitize_char_width): New inline function.
12084
a2271ba2
PE
12085 Don't assume that tab-width fits in int.
12086 * character.h (sanitize_width): New inline function.
12087 (SANE_TAB_WIDTH): New macro.
12088 (ASCII_CHAR_WIDTH): Use it.
12089 * indent.c (sane_tab_width): Remove. All uses replaced by
12090 SANE_TAB_WIDTH (current_buffer).
12091 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
12092
18c52557
PE
12093 * fileio.c: Integer overflow issues with file modes.
12094 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
12095
caeeedc1
PE
12096 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
12097 Remove unreachable code.
12098 (read_hex, load_charset_map_from_file): Check for integer overflow.
12099
6df6ae42 12100 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
12101 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
12102 (x_send_scroll_bar_event): Likewise. Check that the size does not
12103 exceed limits imposed by XClientMessageEvent, as well as the usual
12104 ptrdiff_t and size_t limits.
12105
b13995db
PE
12106 * keyboard.c: Overflow, signedness and related fixes.
12107 (make_lispy_movement): Use same integer type in forward decl
12108 that is used in the definition.
12109 (read_key_sequence, keyremap_step):
12110 Change bufsize argument back to int, undoing my 2011-03-30 change.
12111 We prefer signed types, and int is wide enough here.
12112 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
12113 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
12114 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
12115 length, not size_t. Use ptrdiff_t for index, not int.
12116 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
12117 possibility of integer overflow.
12118
13464394
PE
12119 Overflow, signedness and related fixes for images.
12120
12121 * dispextern.h (struct it.stack[0].u.image.image_id)
12122 (struct_it.image_id, struct image.id, struct image_cache.size)
12123 (struct image_cache.used, struct image_cache.ref_count):
12124 * gtkutil.c (update_frame_tool_bar):
12125 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
12126 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
12127 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
12128 * nsmenu.m (update_frame_tool_bar):
12129 * xdisp.c (calc_pixel_width_or_height):
12130 * xfns.c (image_cache_refcount):
12131 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
12132 on typical 64-bit hosts.
12133
12134 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
12135 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
12136 Omit unnecessary casts to int.
12137 (parse_image_spec): Check that integers fall into 'int' range
12138 when the callers expect that.
12139 (image_ascent): Redo ascent calculation to avoid int overflow.
12140 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
12141 (lookup_image): Remove unnecessary tests.
12142 (xbm_image_p): Locals are now of int, not EMACS_INT,
12143 since parse_image_check makes sure they fit into int.
12144 (png_load, gif_load, svg_load_image):
12145 Prefer int to unsigned where either will do.
12146 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
12147 old tiff_error_handler and tiff_warning_handler.
12148 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
12149 stack buffer overflows. It uses only the features of vsnprintf
12150 that are common to both POSIX and native Microsoft.
12151 (tiff_error_handler, tiff_warning_handler): Use it.
12152 (tiff_load, gif_load, imagemagick_load_image):
12153 Don't assume :index value fits in 'int'.
12154 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
12155 (imagemagick_load_image): Check that crop parameters fit into
12156 the integer types that MagickCropImage accepts. Don't assume
12157 Vimagemagick_render_type has a nonnegative value. Don't assume
12158 size_t fits in 'long'.
12159 (gs_load): Use printmax_t to print the widest integers possible.
12160 Check for integer overflow when computing image height and width.
12161
c11821d4
EZ
121622011-08-26 Eli Zaretskii <eliz@gnu.org>
12163
12164 * xdisp.c (redisplay_window): Don't force window start if point
12165 will be invisible in the resulting window. (Bug#9324)
12166
0c95fcf7
EZ
121672011-08-25 Eli Zaretskii <eliz@gnu.org>
12168
12169 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
12170 the display spec is of the form `(space ...)'.
12171 (handle_display_spec): Return the value returned by
12172 handle_single_display_spec, not just 1 or zero.
12173 (handle_single_display_spec): If the display spec is of the form
12174 `(space ...)', and specifies display in the text area, return 2
12175 rather than 1.
fee65a97 12176 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
12177 accurately, and prefer exact match for point under bidi.
12178 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
12179
12180 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
12181 into disp_prop; all users changed.
12182
12183 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
12184 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
12185 for the text covered by the display property.
12186
e4ed06f1
CY
121872011-08-25 Chong Yidong <cyd@stupidchicken.com>
12188
12189 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
12190 Change return value to nil.
12191 (Frecord_buffer): Delete unused function.
12192
f67cdd7f
EZ
121932011-08-24 Eli Zaretskii <eliz@gnu.org>
12194
5980d4c6
EZ
12195 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
12196 buffers, return left-to-right.
8610fe8b
EZ
12197 (set_cursor_from_row): Consider candidate row a win if its glyph
12198 represents a newline and point is on that newline. Fixes cursor
12199 positioning on the newline at EOL of R2L text within L2R
12200 paragraph, and vice versa.
12201 (try_cursor_movement): Check continued rows, in addition to
12202 continuation rows. Fixes unwarranted scroll when point enters a
12203 continued line of R2L text within an L2R paragraph, or vice versa.
12204 (cursor_row_p): Consider the case of point being equal to
12205 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
12206 from the end of a short line to the beginning of a continued line
12207 of R2L text within L2R paragraph.
12208 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
12209 composed characters.
5980d4c6 12210
f67cdd7f
EZ
12211 * bidi.c (bidi_check_type): Use xassert.
12212 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
12213 members.
12214
bca633fb
EZ
122152011-08-23 Eli Zaretskii <eliz@gnu.org>
12216
12217 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
12218 a character.
12219
4a5885a7
CY
122202011-08-23 Chong Yidong <cyd@stupidchicken.com>
12221
12222 * nsfont.m (ns_otf_to_script): Fix typo.
12223
0902a04e
KH
122242011-08-22 Kenichi Handa <handa@m17n.org>
12225
12226 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
12227 extra slot even if the purpose is char-code-property-table.
12228
1a2e6670
EZ
122292011-08-23 Eli Zaretskii <eliz@gnu.org>
12230
8ddde651
EZ
12231 * xdisp.c (redisplay_window): When computing centering_position,
12232 account for the height of the header line. (Bug#8874)
12233
425cc014
EZ
12234 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
12235 instead of CHAR_TO_BYTE. Fixes a crash when a completion
12236 candidate is selected by the mouse, and that candidate has a
12237 composed character under the mouse.
12238
1a2e6670
EZ
12239 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
12240 coordinates reported by pos-visible-in-window-p for a composed
12241 character in column zero.
12242
8b76d6f8
SM
122432011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
12244
12245 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
12246
dac347dd
EZ
122472011-08-22 Eli Zaretskii <eliz@gnu.org>
12248
12249 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
12250 consider it a hit if to_charpos is anywhere in the range of the
12251 composed buffer positions.
12252
e013fb34
CY
122532011-08-22 Chong Yidong <cyd@stupidchicken.com>
12254
12255 * image.c (gif_load): Don't assume that each subimage has the same
12256 dimensions as the base image. Handle disposal method that is
12257 "undefined" by the gif spec (Bug#9335).
12258
bd1ba3e8
CY
122592011-08-20 Chong Yidong <cyd@stupidchicken.com>
12260
12261 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 12262 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 12263
54a1215b
EZ
122642011-08-19 Eli Zaretskii <eliz@gnu.org>
12265
823564e5
EZ
12266 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
12267 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
12268 from an Org mode buffer to a Speedbar frame.
12269
54a1215b
EZ
12270 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
12271 a composition, take its buffer position from IT->cmp_it.charpos.
12272 Fixes cursor positioning at the beginning of a line that begins
12273 with a composed character.
12274
9778ebcc
EZ
122752011-08-18 Eli Zaretskii <eliz@gnu.org>
12276
0be6ee06
EZ
12277 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
12278 character bidirectional type, use STRONG_L instead. Fixes crashes
12279 in a buffer produced by `describe-categories'.
12280
9778ebcc
EZ
12281 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
12282 members before the level stack, so they would be saved and
12283 restored when copying iterator state. Fixes incorrect reordering
12284 around TABs covered by display properties.
12285
156bffbe
AS
122862011-08-18 Andreas Schwab <schwab@linux-m68k.org>
12287
6b02f655 12288 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 12289
72ad093b
CY
122902011-08-17 Chong Yidong <cyd@stupidchicken.com>
12291
12292 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
12293 (internal_condition_case_2, internal_condition_case_n):
12294 Remove unnecessary aborts (Bug#9081).
72ad093b 12295
35774242
EZ
122962011-08-17 Eli Zaretskii <eliz@gnu.org>
12297
12298 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
12299 has no `load' handler, try opening the file locally. (Bug#9311)
12300
db76dd85
KB
123012011-08-16 Ken Brown <kbrown@cornell.edu>
12302
12303 * gmalloc.c: Expand comment.
12304
b215eee5
EZ
123052011-08-16 Eli Zaretskii <eliz@gnu.org>
12306
12307 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
12308 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
12309
a4579d33
KB
123102011-08-16 Ken Brown <kbrown@cornell.edu>
12311
12312 Fix memory allocation problems in Cygwin build (Bug#9273).
12313
12314 * unexcw.c ( __malloc_initialized): Declare external variable.
12315 (fixup_executable): Force the dumped emacs to reinitialize malloc.
12316
8b76d6f8
SM
12317 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
12318 New variables.
a4579d33
KB
12319 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
12320 dumped emacs.
12321 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
12322 in the static heap.
12323 [CYGWIN] (special_realloc): New function.
12324 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
12325 requests to realloc storage in the static heap.
12326
3ebec551
PE
123272011-08-15 Paul Eggert <eggert@cs.ucla.edu>
12328
12329 * bidi.c (bidi_initialize): Remove unused local.
12330
9fd8be00
EZ
123312011-08-15 Eli Zaretskii <eliz@gnu.org>
12332
6b02f655
SM
12333 * bidimirror.h:
12334 * biditype.h: Remove file.
12335 * makefile.w32-in ($(BLD)/bidi.$(O)):
12336 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
12337
12338 * dispextern.h: Fix a typo in the comment to bidi_type_t.
12339
12340 * chartab.c: Improve commentary for the uniprop_table API.
12341
32413314
EZ
12342 * bidi.c (bidi_paragraph_init): Support zero value of
12343 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
12344 (bidi_initialize): Use uniprop_table instead of including
12345 biditype.h and bidimirror.h.
32413314 12346
9fd8be00
EZ
12347 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
12348 coordinates of the iterator when restoring from ppos_it.
12349 (Bug#9296)
12350
5cf2b69b
KH
123512011-08-14 Kenichi Handa <handa@m17n.org>
12352
12353 * process.c (create_process): Call setup_process_coding_systems
72ad093b 12354 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 12355
daf17d00
EZ
123562011-08-14 Eli Zaretskii <eliz@gnu.org>
12357
12358 * xdisp.c (move_it_in_display_line_to): Don't invoke
12359 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
12360 ppos_it. Fixes vertical cursor motion when line beginning is
12361 covered by an image. (Bug#9296)
12362
08e3161a
JD
123632011-08-14 Jan Djärv <jan.h.d@swipnet.se>
12364
12365 * nsterm.h (ns_run_ascript): Declare.
12366 (NSAPP_DATA2_RUNASSCRIPT): Define.
12367
12368 * nsfns.m (as_script, as_result, as_status): New static variables.
12369 (ns_run_ascript): New function.
5e617bc2 12370 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
12371 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
12372 the event loop. Get status from as_status (Bug#7276).
12373
12374 * nsterm.m (sendEvent): If event is NSApplicationDefined and
12375 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
12376 the event loop (Bug#7276).
12377
a3720aa2
AS
123782011-08-14 Andreas Schwab <schwab@linux-m68k.org>
12379
12380 * gnutls.c (QCgnutls_bootprop_priority)
12381 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
12382 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
12383 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
12384 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
12385 (QCgnutls_bootprop_verify_hostname_error)
12386 (QCgnutls_bootprop_callbacks_verify): Rename from
12387 Qgnutls_bootprop_..., all uses changed.
12388
12389 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
12390 uses changed.
12391
0a0d27fb
PE
123922011-08-14 Paul Eggert <eggert@cs.ucla.edu>
12393
19d5c50c
PE
12394 * xfaces.c (Qframe_set_background_mode): Now static.
12395 * dispextern.h (Qframe_set_background_mode): Remove decl.
12396
0a0d27fb
PE
12397 * process.c (Fnetwork_interface_info): Declare local only if needed.
12398
377538cb
JD
123992011-08-13 Jan Djärv <jan.h.d@swipnet.se>
12400
12401 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
12402 (Fnetwork_interface_list): Allocate in increments of bytes instead
12403 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
12404 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
12405 sockaddr.
12406 (struct ifflag_def): notrailers is smart on OSX.
12407 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
12408 Get hardware address with getifaddrs if available.
12409
08fff70c
EZ
124102011-08-12 Eli Zaretskii <eliz@gnu.org>
12411
12412 * xdisp.c (iterate_out_of_display_property): xassert that
12413 IT->position is set to within IT->object's boundaries. Break from
12414 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
12415 when IT->position is set up wrongly due to some bug.
12416 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
12417 (push_display_prop): Allow GET_FROM_STRING as IT->method on
12418 entry. Force push_it to save on the stack the current
12419 buffer/string position, to be restored by pop_it. Fix flags in
12420 the iterator structure wrt the object coming from a display
12421 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
12422 properties. (Bug#9284)
12423
7be1c708 124242011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 12425
7be1c708
CY
12426 * fontset.c (fontset_get_font_group): Add proper type checks.
12427 (Bug#9172)
aac0c6e3 12428
7be1c708 124292011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 12430
7be1c708
CY
12431 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
12432 and LC_VERSION_MIN_MACOSX.
12433 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
12434 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 12435
97bb72a6
EZ
124362011-08-08 Eli Zaretskii <eliz@gnu.org>
12437
12438 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
12439 no-display-properties-and-no-overlays under bidi display.
12440 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 12441 properties and overlays.
97bb72a6 12442
d5617611
CY
124432011-08-08 Chong Yidong <cyd@stupidchicken.com>
12444
37e11a63
CY
12445 * editfns.c (Fset_time_zone_rule): Document relationship with the
12446 setenv function.
12447
d5617611
CY
12448 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
12449 the font entity extracted from the cache (Bug#8109).
12450
58872834
CY
124512011-08-07 Chong Yidong <cyd@stupidchicken.com>
12452
12453 * composite.c (autocmp_chars): Don't reset point. That is done by
12454 restore_point_unwind (Bug#5984).
12455
75bfc667
JL
124562011-08-07 Juri Linkov <juri@jurta.org>
12457
12458 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
12459 to show the arg `TIME' instead of `TIMEVAL'.
12460
d1410150
EZ
124612011-08-06 Eli Zaretskii <eliz@gnu.org>
12462
12463 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
12464 display property strides EOL and includes a newline, as in
12465 longlines-mode. (Bug#9254)
75b771e4
EZ
12466 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
12467 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
12468
12469 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
12470 is non-zero, even if the data buffer is NULL. Fixes a crash in
12471 vertical-motion with longlines-mode. (Bug#9254)
12472
35928349
EZ
124732011-08-05 Eli Zaretskii <eliz@gnu.org>
12474
ec7cc85b
EZ
12475 * bidi.c <bidi_cache_total_alloc>: Now static.
12476 (bidi_initialize): Initialize bidi_cache_total_alloc.
12477
8b76d6f8 12478 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
12479 cache. (Bug#9221)
12480
12481 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
12482 amount allocated this far in `bidi_cache_total_alloc'.
12483 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
12484 non-zero, only free the data buffer without restoring the cache
12485 contents. All callers changed.
12486
12487 * dispextern.h (bidi_unshelve_cache): Update prototype.
12488
12489 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
12490 (move_it_in_display_line, move_it_to)
12491 (move_it_vertically_backward, move_it_by_lines): Replace the call
12492 to xfree to an equivalent call to bidi_unshelve_cache.
12493 (move_it_in_display_line_to): Fix logic of returning
412b6358 12494 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 12495
e2e2423b
EZ
124962011-08-05 Eli Zaretskii <eliz@gnu.org>
12497
12498 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
12499 came from a string character with a `cursor' property. (Bug#9229)
12500
ae9e757a
JD
125012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12502
12503 * Makefile.in (LIB_PTHREAD): New variable.
12504 (LIBES): Add LIB_PTHREAD (Bug#9216).
12505
12506 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
12507 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
12508
213bd7f2
AS
125092011-08-04 Andreas Schwab <schwab@linux-m68k.org>
12510
6b02f655 12511 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 12512
99aaf75f
JD
125132011-08-04 Jan Djärv <jan.h.d@swipnet.se>
12514
12515 * xterm.c (x_find_topmost_parent): New function.
12516 (x_set_frame_alpha): Find topmost parent window with
12517 x_find_topmost_parent and set the property there also (bug#9181).
12518 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
12519
c74e9d86
PE
125202011-08-04 Paul Eggert <eggert@cs.ucla.edu>
12521
12522 * callproc.c (Fcall_process): Avoid vfork clobbering
12523 the local vars buffer, coding_systems, current_dir.
12524
640c8776
SM
125252011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
12526
12527 * keymap.c (Fmake_composed_keymap): Move to subr.el.
12528
f26d0e4c
PE
125292011-08-03 Paul Eggert <eggert@cs.ucla.edu>
12530
8a10d76c
PE
12531 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
12532 so that it is not optimized away.
12533
f26d0e4c
PE
12534 * xdisp.c (compute_display_string_pos): Remove unused local.
12535
55439c61
EZ
125362011-08-02 Eli Zaretskii <eliz@gnu.org>
12537
12538 Fix slow cursor motion and scrolling in large buffers with
12539 selective display, like Org Mode buffers. (Bug#9218)
12540
12541 * dispextern.h (struct bidi_it): New member disp_prop_p.
12542
12543 * xdisp.c: Remove one-slot cache of display string positions.
12544 (compute_display_string_pos): Accept an additional argument
5e617bc2 12545 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
12546 for a display string or property. If found, set DISP_PROP_P
12547 non-zero.
12548
12549 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
12550 DISP_PROP_P, and pass it to compute_display_string_pos.
12551 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
12552 non-zero. All callers of bidi_fetch_char changed.
12553
fb33fa43
SM
125542011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
12555
12556 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
12557
b099e063
DM
125582010-12-03 Don March <don@ohspite.net>
12559
12560 * keymap.c (Fdefine_key): Fix non-prefix key error message when
12561 last character M-[char] is translated to ESC [char] (bug#7541).
12562
5cc7f7af
KH
125632011-08-02 Kenichi Handa <handa@m17n.org>
12564
d0fffa3f 12565 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
12566
12567 * chartab.c (uniprop_table): Make it non-static.
12568
525d5e6e
EZ
125692011-08-01 Eli Zaretskii <eliz@gnu.org>
12570
12571 * xdisp.c (forward_to_next_line_start): Accept additional argument
12572 BIDI_IT_PREV, and store into it the state of the bidi iterator had
12573 on the newline.
12574 (reseat_at_next_visible_line_start): Use the bidi iterator state
12575 returned by forward_to_next_line_start to restore the state of
12576 it->bidi_it after backing up to previous newline. (Bug#9212)
12577
31011111
AS
125782011-07-30 Andreas Schwab <schwab@linux-m68k.org>
12579
12580 * regex.c (re_comp): Protoize.
12581 (re_exec): Fix return type.
12582 (regexec): Fix type of `ret'. (Bug#9203)
12583
476371c4
PE
125842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12585
e5d76069
PE
12586 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
12587 This is needed if max-image-size is a floating-point number.
12588
9a79b20c
AS
125892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12590
12591 * print.c (print_object): Print empty symbol as ##.
12592
12593 * lread.c (read1): Read ## as empty symbol.
12594
d8c2fa78
AA
125952011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
12596
12597 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
12598 setting frame foreground color (Bug#9175).
12599 (x_set_background_color): Likewise.
12600
ffe57a7a
AA
12601 * nsmenu.m (-setText): Size tooltip dimensions precisely to
12602 contents (Bug#9176).
12603 (EmacsTooltip -init): Remove bezels and add shadows to
12604 tooltip windows.
12605
bf3492a5
AA
12606 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
12607 or scroll bar (Bug#8470).
12608
d55e9c53
AA
12609 * nsfont.m (nsfont_open): Remove assignment to voffset and
12610 unnecessary vars hshink, expand, hd, full_height, min_height.
12611 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
12612
12613 * nsterm.h (nsfont_info): Remove voffset field.
12614
d8c2fa78 126152011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
12616
12617 Implement strike-through and overline on NextStep (Bug#8863).
12618
12619 * nsfont.m (nsfont_open): Use underline position provided by font,
12620 instead of hard-coded value of 2.
12621 (nsfont_draw): Call ns_draw_text_decoration instead.
12622
12623 * nsterm.h: Add declaration for ns_draw_text_decoration.
12624
12625 * nsterm.m (ns_draw_text_decoration): New function for drawing
12626 underline, overline, and strike-through.
12627 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
12628 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 12629 accommodate underlining, etc.
4843aac3 12630
4cc60b9b
EZ
126312011-07-28 Eli Zaretskii <eliz@gnu.org>
12632
bc7ece87
EZ
12633 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
12634 default.
4cc60b9b 12635
476371c4
PE
126362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12637
66606eea
PE
12638 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
12639 Without this fix, if a signal arrives just after memory fills up,
12640 'malloc' might be invoked reentrantly.
12641
476371c4
PE
12642 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
12643 In other words, assume that every image size is allowed, on non-X
12644 hosts. This assumption is probably wrong, but it lets Emacs compile.
12645
f3fcc40d
AS
126462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12647
12648 * regex.c (re_iswctype): Convert return values to boolean.
12649
350c992f
EZ
126502011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
12651
12652 * xdisp.c (compute_display_string_pos): Don't use cached display
12653 string position if the buffer had its restriction changed.
12654 (Bug#9184)
12655
5266b4bb
PE
126562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
12657
12658 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12659
2573a837 126602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 12661
41f55ccd 12662 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 12663
39e378da
PE
12664 * bidi.c: Integer size and overflow fixes.
12665 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
12666 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
12667 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12668 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
12669 (bidi_find_other_level_edge):
12670 Use ptrdiff_t instead of EMACS_INT where either will do.
12671 This works better on 32-bit hosts configured --with-wide-int.
12672 (bidi_cache_ensure_space): Check for size-calculation overflow.
12673 Use % rather than repeated addition, for better worst-case speed.
12674 Don't set bidi_cache_size until after xrealloc returns, because it
12675 might not return.
12676 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
12677 (bidi_cache_ensure_space): Also check that the bidi cache size
12678 does not exceed that of the largest Lisp string or buffer. See Eli
12679 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 12680
5e927815
PE
12681 * alloc.c (__malloc_size_t): Remove.
12682 All uses replaced by size_t. See Andreas Schwab's note
12683 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
12684
ca4aa935
PE
12685 * image.c: Improve checking for integer overflow.
12686 (check_image_size): Assume that f is nonnull, since
12687 it is always nonnull in practice. This is one less thing to
12688 worry about when checking for integer overflow later.
12689 (x_check_image_size): New function, which checks for integer
12690 overflow issues inside X.
12691 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
12692 This removes the need for a memory_full check.
12693 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
12694 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
12695 (xbm_read_bitmap_data): Change locals back to 'int', since
12696 their values must fit in 'int'.
12697 (xpm_load_image, png_load, tiff_load):
12698 Invoke x_create_x_image_and_pixmap earlier,
12699 to avoid much needless work if the image is too large.
12700 (tiff_load): Treat overly large images as if
12701 x_create_x_image_and_pixmap failed, not as malloc failures.
12702 (gs_load): Use x_check_image_size.
12703
5f8f9cc2
PE
12704 * gtkutil.c: Omit integer casts.
12705 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
12706 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
12707
5adf60bc
PE
12708 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
12709
c8907a93
PE
12710 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
12711 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
12712 would wrongly return t on a 64-bit host.
12713
e3c25c68
PE
12714 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
12715 The plain *_OVERFLOW macros run afoul of GCC bug 49705
12716 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
12717 and therefore cause GCC to emit a bogus diagnostic in some cases.
12718
3f791afe
PE
12719 * image.c: Integer signedness and overflow and related fixes.
12720 This is not an exhaustive set of fixes, but it's time to
12721 record what I've got.
12722 (lookup_pixel_color, check_image_size): Remove redundant decls.
12723 (check_image_size): Don't assume that arbitrary EMACS_INT values
12724 fit in 'int', or that arbitrary 'double' values fit in 'int'.
12725 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
12726 (tiff_load, imagemagick_load_image):
12727 Check for overflow in size calculations.
12728 (x_create_x_image_and_pixmap): Remove unnecessary test for
12729 xmalloc returning NULL; that can't happen.
12730 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
12731 (xpm_color_bucket): Use better integer hashing function.
12732 (xpm_cache_color): Don't possibly over-allocate memory.
12733 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
12734 (gif_memory_source):
12735 Use ptrdiff_t, not int or size_t, to record sizes.
12736 (png_load): Don't assume values greater than 2**31 fit in 'int'.
12737 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
12738 either works, as we prefer signed integers.
12739 (tiff_read_from_memory, tiff_write_from_memory):
12740 Return tsize_t, not size_t, since that's what the TIFF API wants.
12741 (tiff_read_from_memory): Don't fail simply because the read would
12742 go past EOF; instead, return a short read.
12743 (tiff_load): Omit no-longer-needed casts.
12744 (Fimagemagick_types): Don't assume size fits into 'int'.
12745
3cc5a532
PE
12746 Improve hashing quality when configured --with-wide-int.
12747 * fns.c (hash_string): New function, taken from sxhash_string.
12748 Do not discard information about ASCII character case; this
12749 discarding is no longer needed.
12750 (sxhash-string): Use it. Change sig to match it. Caller changed.
12751 * lisp.h: Declare it.
12752 * lread.c (hash_string): Remove, since we now use fns.c's version.
12753 The fns.c version returns a wider integer if --with-wide-int is
12754 specified, so this should help the quality of the hashing a bit.
12755
b312a492
PE
12756 * emacs.c: Integer overflow minor fix.
12757 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
12758 Define only if GNU_LINUX.
12759 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
12760
dfd153ae
PE
12761 * dispnew.c: Integer signedness and overflow fixes.
12762 Remove unnecessary forward decls, that were a maintenance hassle.
12763 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
12764 All uses changed.
12765 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
12766 (scrolling_window): Use ptrdiff_t, not int, for byte count.
12767 (prepare_desired_row, line_draw_cost):
12768 Use int, not unsigned, where either works.
12769 (save_current_matrix, restore_current_matrix):
12770 Use ptrdiff_t, not size_t, where either works.
12771 (init_display): Check for overflow more accurately, and without
12772 relying on undefined behavior.
12773
a81d11a3
PE
12774 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
12775 Remove, replacing with the new symbols in lisp.h. All uses changed.
12776 * fileio.c (make_temp_name):
12777 * filelock.c (lock_file_1, lock_file):
12778 * xdisp.c (message_dolog):
12779 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
12780 Use pMd etc. instead.
12781 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
12782 replacing the pWIDE etc. symbols removed from editfns.c.
12783
3300e6fd
PE
12784 * keyboard.h (num_input_events): Now uintmax_t.
12785 This is (very slightly) less likely to mess up due to wraparound.
12786 All uses changed.
12787
fd05c7e9
PE
12788 * buffer.c: Integer signedness fixes.
12789 (alloc_buffer_text, enlarge_buffer_text):
12790 Use ptrdiff_t rather than size_t when either will do, as we prefer
12791 signed integers.
12792
903fe15d
PE
12793 * alloc.c: Integer signedness and overflow fixes.
12794 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
12795 (__malloc_size_t): Default to size_t, not to int.
12796 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
12797 (Fgarbage_collect, mark_object_loop_halt, mark_object):
12798 Prefer ptrdiff_t to size_t when either would do, as we prefer
12799 signed integers.
12800 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
12801 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
12802 Now const. Initialize with values that are in range even if char
12803 is signed.
12804 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
12805 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
12806 These functions do the right thing with sizes > 2**32.
12807 (check_depth): Now ptrdiff_t, not int.
12808 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
12809 Adjust to new way of storing sizes. Check for size overflow bugs
12810 in rest of code.
12811 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
12812 slightly wrong anyway, as it missed one instance of
12813 XMALLOC_OVERRUN_CHECK_OVERHEAD.
12814 (refill_memory_reserve): Omit needless cast to size_t.
12815 (mark_object_loop_halt): Mark as externally visible.
12816
ac82cc6a
PE
12817 * xselect.c: Integer signedness and overflow fixes.
12818 (Fx_register_dnd_atom, x_handle_dnd_message):
12819 Use ptrdiff_t, not size_t, since we prefer signed.
12820 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
12821 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
12822 x_dnd_atoms_size and x_dnd_atoms_length.
12823
c2d1e36d
PE
12824 * doprnt.c: Prefer signed to unsigned when either works.
12825 * eval.c (verror):
12826 * doprnt.c (doprnt):
12827 * lisp.h (doprnt):
12828 * xdisp.c (vmessage):
12829 Use ptrdiff_t, not size_t, when using or implementing doprnt,
12830 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
12831 prefer signed arithmetic to avoid comparison confusion.
12832 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
12833 but is a bit tricky.
12834
0e926e56
PE
12835 Assume freestanding C89 headers, string.h, stdlib.h.
12836 * data.c, doprnt.c, floatfns.c, print.c:
12837 Include float.h unconditionally.
12838 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
12839 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
12840 * regex.c: Likewise for stddef.h, string.h.
12841 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
12842 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
12843 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12844 (STDC_HEADERS): Remove obsolete defines.
12845 * sysdep.c: Include limits.h unconditionally.
12846
9cfdb3ec
PE
12847 Assume support for memcmp, memcpy, memmove, memset.
12848 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
12849 * regex.c (memcmp, memcpy):
12850 Remove; we assume C89 now.
12851
12852 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
12853 (__malloc_safe_bcopy): Remove; no longer needed.
12854
cf950e6b 12855 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
12856 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
12857 well either way, and we prefer signed to unsigned.
12858
dbf38e02
LMI
128592011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
12860
12861 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
12862 closes the connection while we're reading (bug#9182).
12863
d6f0886c 128642011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 12865
d6f0886c
JD
12866 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
12867 are specified (Bug#9168).
24e0f6b1 12868
2eb1f9e6
PE
128692011-07-25 Paul Eggert <eggert@cs.ucla.edu>
12870
12871 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
12872 Found by GCC static checking and --with-wide-int on a 32-bit host.
12873
22381272 128742011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12875
12876 * xdisp.c (compute_display_string_pos): Fix logic of caching
12877 previous display string position. Initialize cached_prev_pos to
12878 -1. Fixes slow-down at the beginning of a buffer.
12879
f25e39b4
EZ
128802011-07-24 Eli Zaretskii <eliz@gnu.org>
12881
12882 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
12883 for attrs[LFACE_FONTSET_INDEX].
12884
04c4b52e
PE
128852011-07-23 Paul Eggert <eggert@cs.ucla.edu>
12886
12887 * xml.c (parse_region): Remove unused local
12888 that was recently introduced.
12889
c1734fbd
EZ
128902011-07-23 Eli Zaretskii <eliz@gnu.org>
12891
be18c5a5
EZ
12892 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
12893 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
12894
c1734fbd
EZ
12895 * xdisp.c (move_it_in_display_line_to): Record the best matching
12896 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
12897 exit if none of the characters scanned was an exact match.
12898 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
12899 when exact match is impossible due to invisible text, and the
12900 lines are truncated.
12901
a258d627
JD
129022011-07-23 Jan Djärv <jan.h.d@swipnet.se>
12903
12904 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
12905 for OSX >= 10.7.
12906
b6d5a689
EZ
129072011-07-22 Eli Zaretskii <eliz@gnu.org>
12908
0f74f785
EZ
12909 Fix a significant slow-down of cursor motion with C-n, C-p,
12910 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
12911 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 12912 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12913 (next_element_from_buffer): Call compute_stop_pos_backwards to
12914 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
12915 base_level_stop.
12916 (reseat): Don't look for prev_stop, as that could mean a very long
12917 run.
12918 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12919 <cached_disp_overlay_modiff>: Cache for last found display string
12920 position.
551918c1 12921 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12922 about the same buffer in the same area of character positions, and
12923 the buffer wasn't changed since the time the display string
12924 position was cached.
551918c1 12925
b2d0c91a
EZ
129262011-07-22 Eli Zaretskii <eliz@gnu.org>
12927
12928 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12929 is an integer, which is important for empty lines. (Bug#9149)
12930
043604ee
CY
129312011-07-22 Chong Yidong <cyd@stupidchicken.com>
12932
12933 * frame.c (Fmodify_frame_parameters): In tty case, update the
12934 default face if necessary (Bug#4238).
12935
da4adb04
CY
129362011-07-21 Chong Yidong <cyd@stupidchicken.com>
12937
12938 * editfns.c (Fstring_to_char): No need to explain what a character
12939 is in the docstring (Bug#6576).
12940
9abd0532
LMI
129412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12942
12943 * xml.c (parse_region): Make sure we always return a tree.
12944
36881d16
HK
129452011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12946
12947 * xml.c (parse_region): If a document contains only comments,
12948 return that, too.
12949
1e98674d
LMI
129502011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12951
12952 * xml.c (make_dom): Return comments, too.
12953
590bd467
PE
129542011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12955
12956 Port to OpenBSD.
12957 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12958 and the surrounding thread.
12959 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12960 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12961 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12962 timer goes off.
12963 * s/openbsd.h (BROKEN_SIGIO): Define.
12964 * unexelf.c (unexec) [__OpenBSD__]:
12965 Don't update the .mdebug section of the Alpha COFF symbol table.
12966
f41628b2
LMI
129672011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12968
12969 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12970 (bug#8460).
12971
b59b67c5
PE
129722011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12973
15e3a074
PE
12974 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12975 This fixes some race conditions on the permissions of any newly
12976 created file.
12977
41bed37d
PE
12978 * alloc.c (valid_pointer_p): Use pipe, not open.
12979 This fixes some permissions issues when debugging.
12980
b59b67c5
PE
12981 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12982 If fchown fails to set both uid and gid, try to set just gid,
12983 as that is sometimes allowed. Adjust the file's mode to eliminate
12984 setuid or setgid bits that are inappropriate if fchown fails.
12985
925a6be7
SM
129862011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12987
12988 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12989 to compare Lisp_Objects.
12990 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12991 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12992 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12993
52968808
AS
129942011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12995
0a6a104b
AS
12996 * lread.c (read_integer): Unread even EOF character.
12997 (read1): Likewise. Properly record start position of symbol.
12998
52968808
AS
12999 * lread.c (read1): Read `#:' as empty uninterned symbol if no
13000 symbol character follows.
13001
9e381cdd
PE
130022011-07-17 Paul Eggert <eggert@cs.ucla.edu>
13003
13004 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
13005 This works around a problem with the previous change to Fcopy_file.
13006 Recent glibc declares fchown with __attribute__((warn_unused_result)),
13007 and without this change, GCC might complain about discarding
13008 fchown's return value.
13009
b5641435
JB
130102011-07-16 Juanma Barranquero <lekktu@gmail.com>
13011
13012 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
13013
a8031457
PE
130142011-07-16 Paul Eggert <eggert@cs.ucla.edu>
13015
13016 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
13017
dd889327
LMI
130182011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
13019
750c33f7
LMI
13020 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
13021 it's used from the C level.
13022
dd889327
LMI
13023 * process.c: Use the same condition for POLL_FOR_INPUT in both
13024 keyboard.c and process.c (bug#1858).
13025
87e86684
LM
130262011-07-09 Lawrence Mitchell <wence@gmx.li>
13027
13028 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
13029 (Fgnutls_boot): Use it.
13030
64348f40
AS
130312011-07-15 Andreas Schwab <schwab@linux-m68k.org>
13032
13033 * doc.c (Fsubstitute_command_keys): Revert last change.
13034
1d698799
LMI
130352011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
13036
f863868c
LMI
13037 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
13038 quotes the next character, and doesn't affect other longer
13039 sequences (bug#8935).
13040
1d698799
LMI
13041 * lread.c (syms_of_lread): Clarify that is isn't only
13042 `eval-buffer' and `eval-defun' that's affected by
13043 `lexical-binding' (bug#8460).
13044
aa4b6df6
EZ
130452011-07-15 Eli Zaretskii <eliz@gnu.org>
13046
13047 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 13048 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 13049
5d856da6
PE
130502011-07-14 Paul Eggert <eggert@cs.ucla.edu>
13051
ad6042bb
PE
13052 Fix minor problems found by static checking.
13053 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
13054 (elsz): Now a signed constant, not a size_t var. We prefer signed
13055 types to unsigned, to avoid integer comparison confusion. Without
13056 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
13057 "cannot optimize loop, the loop counter may overflow", a symptom
13058 of the confusion.
f00bbb22 13059 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
13060 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
13061
6468f31c
LMI
130622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
13063
49080b10
LMI
13064 * search.c (Fre_search_backward): Mention `case-fold-search' in
13065 all the re_search_* functions (bug#8138).
13066
6468f31c
LMI
13067 * keyboard.c (Fopen_dribble_file): Document when the file is
13068 closed (bug#8056).
13069
c965adc5
EZ
130702011-07-14 Eli Zaretskii <eliz@gnu.org>
13071
df9733bf
EZ
13072 * bidi.c (bidi_dump_cached_states): Fix format of displaying
13073 bidi_cache_idx.
13074
0bb23927
EZ
13075 Support bidi reordering of display and overlay strings.
13076 * xdisp.c (compute_display_string_pos)
13077 (compute_display_string_end): Accept additional argument STRING.
13078 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
13079 (reseat_to_string): Initialize bidi_it->string.s and
13080 bidi_it->string.schars.
13081 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
13082 NULL (avoids a crash in bidi_paragraph_init).
13083 Initialize itb.string.lstring.
0bb23927
EZ
13084 (init_iterator): Call bidi_init_it only of a valid
13085 buffer position was specified. Initialize paragraph_embedding to
13086 L2R.
13087 (reseat_to_string): Initialize the bidi iterator.
13088 (display_string): If we need to ignore text properties of
13089 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
13090 original value of -1 will not work with bidi.)
13091 (compute_display_string_pos): First arg is now struct
13092 `text_pos *'; all callers changed. Support display properties on
13093 Lisp strings.
13094 (compute_display_string_end): Support display properties on Lisp
13095 strings.
13096 (init_iterator, reseat_1, reseat_to_string): Initialize the
13097 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
13098 when iterating on a string not from display properties).
640c8776
SM
13099 (compute_display_string_pos, compute_display_string_end):
13100 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
13101 arrow keys.
13102 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
13103 base_level_stop; instead, set base_level_stop to BEGV.
13104 Fixes crashes in vertical-motion.
0bb23927
EZ
13105 (next_element_from_buffer): Improve commentary for when
13106 the iterator is before prev_stop.
13107 (init_iterator): Initialize bidi_p from the default value of
13108 bidi-display-reordering, not from buffer-local value. Use the
13109 buffer-local value only if initializing for buffer iteration.
13110 (handle_invisible_prop): Support invisible properties on strings
13111 that are being bidi-reordered.
13112 (set_iterator_to_next): Support bidi reordering of C strings and
13113 Lisp strings.
13114 (next_element_from_string): Support bidi reordering of Lisp
13115 strings.
13116 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
13117 (display_string): Support display of R2L glyph rows.
13118 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
13119 (init_iterator): Don't initialize it->bidi_p for strings
13120 here.
13121 (reseat_to_string): Initialize it->bidi_p for strings here.
13122 (next_element_from_string, next_element_from_c_string)
13123 (next_element_from_buffer): Add xassert's for correspondence
13124 between IT's object being iterated and it->bidi_it.string
13125 structure.
13126 (face_before_or_after_it_pos): Support bidi iteration.
13127 (next_element_from_c_string): Handle the case of the first string
13128 character that is not the first one in the visual order.
13129 (get_visually_first_element): New function, refactored from common
13130 parts of next_element_from_buffer, next_element_from_string, and
13131 next_element_from_c_string.
13132 (tool_bar_lines_needed, redisplay_tool_bar)
13133 (display_menu_bar): Force left-to-right direction. Add a FIXME
13134 comment for making that be controlled by a user option.
13135 (push_it, pop_it): Save and restore the state of the
13136 bidi iterator. Save and restore the bidi_p flag.
13137 (pop_it): Iterate out of display property for string iteration as
13138 well.
13139 (iterate_out_of_display_property): Support iteration over strings.
13140 (handle_single_display_spec): Set up it->bidi_it for iteration
13141 over a display string, and call bidi_init_it.
13142 (handle_single_display_spec, next_overlay_string)
13143 (get_overlay_strings_1, push_display_prop): Set up the bidi
13144 iterator for displaying display or overlay strings.
13145 (forward_to_next_line_start): Don't use the shortcut if
13146 bidi-iterating.
13147 (back_to_previous_visible_line_start): If handle_display_prop
13148 pushed the iterator stack, restore the internal state of the bidi
13149 iterator by calling bidi_pop_it same number of times.
13150 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
13151 and we are bidi-iterating, don't decrement the iterator position;
13152 instead, set the first_elt flag in the bidi iterator, to produce
13153 the same effect.
13154 (reseat_1): Remove redundant setting of string_from_display_prop_p.
13155 (push_display_prop): xassert that we are iterating a buffer.
13156 (push_it, pop_it): Save and restore paragraph_embedding member.
13157 (handle_single_display_spec, next_overlay_string)
13158 (get_overlay_strings_1, reseat_1, reseat_to_string)
13159 (push_display_prop): Set up the `unibyte' member of bidi_it.string
13160 correctly. Don't assume unibyte strings are not bidi-reordered.
13161 (compute_display_string_pos)
13162 (compute_display_string_end): Fix handling the case of C string.
13163 (push_it, pop_it): Save and restore from_disp_prop_p.
13164 (handle_single_display_spec, push_display_prop): Set the
13165 from_disp_prop_p flag.
13166 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
13167 (pop_it): Call iterate_out_of_display_property only if we are
13168 popping after iteration over a string that came from a display
13169 property. Fix a typo in popping stretch info. Add an assertion
13170 for verifying that the iterator position is in sync with the bidi
13171 iterator.
13172 (handle_single_display_spec, get_overlay_strings_1)
13173 (push_display_prop): Fix initialization of paragraph direction for
13174 string when that of the parent object is not yet determined.
13175 (reseat_1): Call bidi_init_it to resync the bidi
13176 iterator with IT's position. (Bug#7616)
13177 (find_row_edges): If ROW->start.pos gives position
13178 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
13179 (handle_stop, back_to_previous_visible_line_start, reseat_1):
13180 Reset the from_disp_prop_p flag.
13181 (SAVE_IT, RESTORE_IT): New macros.
13182 (pos_visible_p, face_before_or_after_it_pos)
13183 (back_to_previous_visible_line_start)
13184 (move_it_in_display_line_to, move_it_in_display_line)
13185 (move_it_to, move_it_vertically_backward, move_it_by_lines)
13186 (try_scrolling, redisplay_window, display_line): Use them when
13187 saving a temporary copy of the iterator and restoring it back.
13188 (back_to_previous_visible_line_start, reseat_1)
13189 (init_iterator): Empty the bidi cache "stack".
13190 (move_it_in_display_line_to): If iterator ended up at
13191 EOL, but we never saw any buffer positions smaller than
13192 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
13193 motion in bidi-reordered lines.
13194 (move_it_in_display_line_to): Record prev_method and prev_pos
13195 immediately before the call to set_iterator_to_next. Fixes cursor
13196 motion in bidi-reordered lines with stretch glyphs and strings
13197 displayed in margins. (Bug#8133) (Bug#8867)
13198 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
13199 TO_CHARPOS.
640c8776
SM
13200 (pos_visible_p): Support positions in bidi-reordered lines.
13201 Save and restore bidi cache.
0bb23927
EZ
13202
13203 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
13204 (bidi_paragraph_info): Delete unused struct.
13205 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
13206 (bidi_cache_start): New variable.
13207 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
13208 to zero.
13209 (bidi_cache_fetch_state, bidi_cache_search)
13210 (bidi_cache_find_level_change, bidi_cache_iterator_state)
13211 (bidi_cache_find, bidi_peek_at_next_level)
13212 (bidi_level_of_next_char, bidi_find_other_level_edge)
13213 (bidi_move_to_visually_next): Compare cache index with
13214 bidi_cache_start rather than with zero.
13215 (bidi_fetch_char): Accept new argument STRING; all callers
13216 changed. Support iteration over a string. Support strings with
13217 display properties. Support unibyte strings. Fix the type of
13218 `len' according to what STRING_CHAR_AND_LENGTH expects.
13219 (bidi_paragraph_init, bidi_resolve_explicit_1)
13220 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
13221 (bidi_level_of_next_char, bidi_move_to_visually_next):
13222 Support iteration over a string.
0bb23927
EZ
13223 (bidi_set_sor_type, bidi_resolve_explicit_1)
13224 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
13225 can now be zero (for strings); special values 0 and -1 were
13226 changed to -1 and -2, respectively.
13227 (bidi_char_at_pos): New function.
13228 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
13229 Call it instead of FETCH_MULTIBYTE_CHAR.
13230 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
13231 initialized to valid values.
13232 (bidi_init_it): Don't initialize charpos and bytepos with invalid
13233 values.
13234 (bidi_level_of_next_char): Allow the sentinel "position" to pass
13235 the test for valid cached positions. Fix the logic for looking up
13236 the sentinel state in the cache. GCPRO the Lisp string we are
13237 iterating.
13238 (bidi_push_it, bidi_pop_it): New functions.
13239 (bidi_initialize): Initialize the bidi cache start stack pointer.
13240 (bidi_cache_ensure_space): New function, refactored from part of
13241 bidi_cache_iterator_state. Don't assume the required size is just
13242 one BIDI_CACHE_CHUNK away.
13243 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
13244 (bidi_count_bytes, bidi_char_at_pos): New functions.
13245 (bidi_cache_search): Don't assume bidi_cache_last_idx is
13246 always valid if bidi_cache_idx is valid.
13247 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
13248 is valid if it's going to be used.
13249 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
13250 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
13251 (bidi_cache_find_level_change, bidi_cache_ensure_space)
13252 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
13253 (bidi_find_other_level_edge, bidi_cache_start_stack):
13254 All variables related to cache indices are now EMACS_INT.
c965adc5 13255
0bb23927
EZ
13256 * dispextern.h (struct bidi_string_data): New structure.
13257 (struct bidi_it): New member `string'. Make flag members be 1-bit
13258 fields, and put them last in the struct.
640c8776
SM
13259 (compute_display_string_pos, compute_display_string_end):
13260 Update prototypes.
0bb23927
EZ
13261 (bidi_push_it, bidi_pop_it): Add prototypes.
13262 (struct iterator_stack_entry): New members bidi_p,
13263 paragraph_embedding, and from_disp_prop_p.
13264 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
13265 (bidi_shelve_cache, bidi_unshelve_cache):
13266 Declare prototypes.
0bb23927
EZ
13267
13268 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
13269 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
13270 and vector-like objects.
13271
13272 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
13273 cache around display iteration.
13274
13275 * window.c (Fwindow_end, window_scroll_pixel_based)
13276 (displayed_window_lines, Frecenter): Save and restore the bidi
13277 cache around display iteration.
13278
3bbd2265
LMI
132792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
13280
13281 * editfns.c (Fdelete_region): Clarify the use of the named
13282 parameters (bug#6788).
13283
adc47434
MR
132842011-07-14 Martin Rudalics <rudalics@gmx.at>
13285
13286 * indent.c (Fvertical_motion): Set and restore w->pointm when
13287 saving and restoring the window's buffer (Bug#9006).
13288
837c31f8
LMI
132892011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
13290
13291 * editfns.c (Fstring_to_char): Clarify just what is returned
13292 (bug#6576). Text by Eli Zaretskii.
13293
ac389d0c
JB
132942011-07-13 Juanma Barranquero <lekktu@gmail.com>
13295
13296 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
13297
0be0ce47
EZ
132982011-07-13 Eli Zaretskii <eliz@gnu.org>
13299
13300 * buffer.c (mmap_find): Fix a typo.
13301
cd18e7e3
JB
133022011-07-13 Johan Bockgård <bojohan@gnu.org>
13303
13304 Fix execution of x selection hooks.
13305 * xselect.c (Qx_lost_selection_functions)
13306 (Qx_sent_selection_functions): New vars.
13307 (syms_of_xselect): DEFSYM them.
13308 (x_handle_selection_request): Pass Qx_sent_selection_functions
13309 rather than Vx_sent_selection_functions to Frun_hook_with_args.
13310 (x_handle_selection_clear,x_clear_frame_selections):
13311 Pass Qx_lost_selection_functions rather than
13312 Vx_lost_selection_functions to Frun_hook_with_args.
13313
47ea7f44
PE
133142011-07-13 Paul Eggert <eggert@cs.ucla.edu>
13315
ac389d0c 13316 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
13317 The old code sometimes used this field without initializing it.
13318
47ea7f44
PE
13319 * alloc.c (gc_sweep): Don't read past end of array.
13320 In theory, the old code could also have corrupted Emacs internals,
13321 though it'd be very unlikely.
13322
bc985c87
AS
133232011-07-12 Andreas Schwab <schwab@linux-m68k.org>
13324
13325 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 13326 argument. (Bug#4026)
bc985c87 13327
0cf34688
LMI
133282011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
13329
b3dadd76
LMI
13330 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
13331 key" (bug#4257).
13332
0cf34688
LMI
13333 * window.c (Fset_window_start): Doc fix (bug#4199).
13334 (Fset_window_hscroll): Ditto.
13335
270768cd
PE
133362011-07-12 Paul Eggert <eggert@cs.ucla.edu>
13337
077e3dda 13338 Fix minor new problems caught by GCC 4.6.1.
270768cd 13339 * term.c (init_tty): Remove unused local.
490011a6 13340 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 13341 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 13342 not used otherwise.
270768cd 13343
b1f58454
CY
133442011-07-12 Chong Yidong <cyd@stupidchicken.com>
13345
13346 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
13347
22b9578d
LMI
133482011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
13349
6e70ab07
LMI
13350 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
13351 are the mini-buffer and the echo area (bug#3320).
13352
22b9578d
LMI
13353 * term.c (init_tty): Remove support for supdup, c10 and perq
13354 terminals, which are no longer supported (bug#1482).
13355
8974cc9f
JB
133562011-07-10 Johan Bockgård <bojohan@gnu.org>
13357
13358 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
13359
a560d974
JD
133602011-07-10 Jan Djärv <jan.h.d@swipnet.se>
13361
13362 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
13363 for non-popups (Bug#3642).
13364
1dae0f0a
AS
133652011-07-10 Andreas Schwab <schwab@linux-m68k.org>
13366
268c2c36 13367 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 13368 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
13369 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
13370 * cm.c (losecursor): Likewise.
1dae0f0a
AS
13371 * data.c (fmod): Likewise.
13372 * dispnew.c (swap_glyphs_in_rows): Likewise.
13373 * emacs.c (memory_warning_signal): Likewise.
13374 * floatfns.c (float_error): Likewise.
13375 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
13376 (otf_open, font_otf_capability, generate_otf_features)
13377 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
13378 Likewise.
13379 * image.c (pbm_read_file): Likewise.
13380 * indent.c (string_display_width): Likewise.
13381 * intervals.c (check_for_interval, search_for_interval)
13382 (inc_interval_count, count_intervals, root_interval)
13383 (adjust_intervals_for_insertion, make_new_interval): Likewise.
13384 * lread.c (defalias): Likewise.
268c2c36 13385 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
13386 * regex.c (set_image_of_range_1, set_image_of_range)
13387 (regex_grow_registers): Likewise.
13388 * sysdep.c (strerror): Likewise.
13389 * termcap.c (valid_filename_p, tprint, main): Likewise.
13390 * tparam.c (main): Likewise.
13391 * unexhp9k800.c (run_time_remap, save_data_space)
13392 (update_file_ptrs, read_header, write_header, calculate_checksum)
13393 (copy_file, copy_rest, display_header): Likewise.
13394 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
13395 Likewise.
13396 * xdisp.c (check_it): Likewise.
13397 * xfaces.c (register_color, unregister_color, unregister_colors):
13398 Likewise.
13399 * xfns.c (print_fontset_result): Likewise.
13400 * xrdb.c (member, fatal, main): Likewise.
13401
99033785
PE
134022011-07-10 Paul Eggert <eggert@cs.ucla.edu>
13403
13404 Fix minor problems found by static checking (Bug#9031).
13405 * chartab.c (char_table_set_range, map_sub_char_table):
13406 Remove unused locals.
13407 (uniprop_table): Now static.
13408 * composite.c (_work_char): Remove unused static var.
13409
9cb2ac56
JB
134102011-07-09 Juanma Barranquero <lekktu@gmail.com>
13411
13412 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
13413
f25661f0
JD
134142011-07-09 Jan Djärv <jan.h.d@swipnet.se>
13415
13416 * gtkutil.c (qttip_cb): Remove code without function.
13417
8278c4fe
EZ
134182011-07-09 Eli Zaretskii <eliz@gnu.org>
13419
13420 * w32.c (pthread_sigmask): New stub.
13421
1692ae2d 134222011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 13423
8a6ebd58 13424 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
13425 sigprocmask is portable only for single-threaded applications, and
13426 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
13427 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
13428 (LIBES): Use it.
13429 * callproc.c (Fcall_process):
13430 * process.c (create_process):
13431 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
13432 Use pthread_sigmask, not sigprocmask.
123403e4 13433
1b854618
JD
134342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13435
13436 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
13437 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
13438 wrong (Bug#8591).
13439
3fe4b549
JD
134402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13441
0ce7e563
JD
13442 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
13443 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
13444 (xg_hide_tooltip): Fix comment.
13445
3fe4b549
JD
13446 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
13447 in registerServicesMenuSendTypes.
13448 (validRequestorForSendType): Don't check ns_return_types.
13449
13450 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
13451 ns_return_type.
13452
5df75e47
JR
134532011-07-08 Jason Rumney <jasonr@gnu.org>
13454
22610910
JR
13455 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
13456 SH_SHOW for hidden windows (Bug#5482).
13457
5df75e47
JR
13458 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
13459 frame struct members of non-existent frames (Bug#6284).
13460
699c10bd
JD
134612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
13462
4393663b
JD
13463 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
13464 variable firstTime not needed on OSX >= 10.6.
13465 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
13466 >= 10.5. Use setKnobProportion, setDoubleValue.
13467
13468 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
13469 (MAC_OS_X_VERSION_10_5): Define if not defined.
13470 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
13471 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
13472 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
13473
13474 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 13475 cString and lossyCString on OSX >= 10.4.
4393663b 13476
58179cce 13477 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
13478 sizeToFit on OSX >= 10.2.
13479
13480 * nsimage.m (allocInitFromFile): Don't use deprecated method
13481 bestRepresentationForDevice on OSX >= 10.6.
13482
13483 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
13484 to avoid warning.
13485
13486 * emacs.c: Declare unexec_init_emacs_zone.
13487
a63e0781
JD
13488 * nsgui.h: Fix compiler warning about gnulib redefining verify.
13489
699c10bd
JD
13490 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
13491
13492 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
13493 on svcsMenu (Bug#8842).
13494
13495 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
13496 ns_return_types.
13497 (Fns_list_services): Just return Qnil on 10.6, code not working there.
13498
13499 * nsterm.m (QUTF8_STRING): Declare.
13500 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
13501 (validRequestorForSendType): Return type is (id).
13502 Change indexOfObjectIdenticalTo to indexOfObject.
13503 Check if we have local selection before returning self (Bug#8842).
13504 (writeSelectionToPasteboard): Put local selection into paste board
13505 if we have a local selection (Bug#8842).
13506 (syms_of_nsterm): DEFSYM QUTF8_STRING.
13507
13508 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
13509 (ns_get_local_selection): Declare.
13510
54e10184
LMI
135112011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
13512
9888ff71
LMI
13513 * keymap.c (describe_map_tree): Don't insert a double newline at
13514 the end of the buffer (bug#1169) and return whether we inserted
13515 something.
13516
54e10184
LMI
13517 * callint.c (Fcall_interactively): Change "reading args" to
13518 "providing args" to try to clarify what it does (bug#1010).
13519
15fa4783
KH
135202011-07-07 Kenichi Handa <handa@m17n.org>
13521
13522 * composite.c (composition_compute_stop_pos): Ignore a static
13523 composition starting before CHARPOS (Bug#8915).
13524
13525 * xdisp.c (handle_composition_prop): Likewise.
13526
a8815b00
EZ
135272011-07-07 Eli Zaretskii <eliz@gnu.org>
13528
13529 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
13530 (Bug#9015)
13531
ef7b981d 135322011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
13533
13534 * character.h (unicode_category_t): New enum type.
13535
13536 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
13537 (Qchar_code_property_table): New variable.
13538 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
13539 (UNIPROP_COMPRESSED_FORM_P): New macros.
13540 (char_table_ascii): Uncompress the compressed values.
13541 (sub_char_table_ref): New arg is_uniprop. Callers changed.
13542 Uncompress the compressed values.
ac389d0c 13543 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
13544 (char_table_ref_and_range): Uncompress the compressed values.
13545 (sub_char_table_set): New arg is_uniprop. Callers changed.
13546 Uncompress the compressed values.
13547 (sub_char_table_set_range): Args changed. Callers changed.
13548 (char_table_set_range): Adjuted for the above change.
13549 (map_sub_char_table): Delete args default_val and parent. Add arg
13550 top. Give decoded values to a Lisp function.
640c8776 13551 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
13552 values to a Lisp function. Gcpro more variables.
13553 (uniprop_table_uncompress)
13554 (uniprop_decode_value_run_length): New functions.
13555 (uniprop_decoder, uniprop_decoder_count): New variables.
13556 (uniprop_get_decoder, uniprop_encode_value_character)
13557 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
13558 New functions.
13559 (uniprop_encoder, uniprop_encoder_count): New variables.
13560 (uniprop_get_encoder, uniprop_table)
13561 (Funicode_property_table_internal, Fget_unicode_property_internal)
13562 (Fput_unicode_property_internal): New functions.
13563 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
13564 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 13565 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
13566 char-code-property-alist.
13567
640c8776 13568 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
13569 Vunicode_category_table.
13570
640c8776 13571 * font.c (font_range): Adjust for the change of
c805dec0
KH
13572 Vunicode_category_table.
13573
76b397fb
DN
135742011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
13575
13576 * m/iris4d.h: Remove file, move contents ...
13577 * s/irix6-5.h: ... here.
13578
22b4128e
PE
135792011-07-06 Paul Eggert <eggert@cs.ucla.edu>
13580
13581 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
13582 * alloc.c (mark_buffer):
13583 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
13584 (clone_per_buffer_values): Don't assume that
22b4128e
PE
13585 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
13586 This isn't true in general, and it's particularly not true
13587 if Emacs is configured with --with-wide-int.
13588 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
13589 New macros, used in the buffer.c change.
13590
869795d6
JD
135912011-07-05 Jan Djärv <jan.h.d@swipnet.se>
13592
13593 * xsettings.c: Use both GConf and GSettings if both are available.
13594 (store_config_changed_event): Add comment.
13595 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
13596 (store_tool_bar_style_changed): New functions.
5e617bc2 13597 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
13598 (struct xsettings): Move font inside HAVE_XFT.
13599 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 13600 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 13601 Move inside HAVE_XFT.
640c8776 13602 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
13603 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
13604 also.
13605 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 13606 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 13607 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
13608 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
13609 (parse_settings): Move check for font inside HAVE_XFT.
13610 (read_settings, apply_xft_settings): Add comment.
13611 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
13612 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
13613 call store_font_name_changed.
13614 (xft_settings_event): Add comment.
13615 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
13616 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
13617 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
13618 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
13619 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
13620 (xsettings_get_system_font, xsettings_get_system_normal_font):
13621 Add comment.
869795d6 13622
d8ed26bd
PE
136232011-07-05 Paul Eggert <eggert@cs.ucla.edu>
13624
13625 Random fixes. E.g., (random) never returned negative values.
13626 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
13627 subseconds part to the entropy, as that's a bit more random.
13628 Prefer signed to unsigned, since the signedness doesn't matter and
13629 in general we prefer signed. When given a limit, use a
13630 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
13631 latter isn't right if USE_2_TAGS_FOR_INTS.
13632 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
13633 not 0..VALMASK. Don't discard "excess" bits that random () returns.
13634
cabf1cac
SM
136352011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
13636
13637 * textprop.c (text_property_stickiness):
13638 Obey Vtext_property_default_nonsticky.
13639 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
13640 * w32fns.c (syms_of_w32fns):
13641 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
13642
6e9b2be9
PE
136432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13644
13645 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
13646 This is more efficient than Ffile_directory_p and avoids a minor race.
13647
90186c68
LMI
136482011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
13649
7c301272
LMI
13650 * buffer.c (Foverlay_put): Say what the return value is
13651 (bug#7835).
13652
c4f2d8d4
LMI
13653 * fileio.c (barf_or_query_if_file_exists): Check first if the file
13654 is a directory before asking whether to use the file name
13655 (bug#7564).
ad637907
LMI
13656 (barf_or_query_if_file_exists): Make the "File is a directory"
13657 error be more correct.
c4f2d8d4 13658
90186c68
LMI
13659 * fns.c (Frequire): Remove the mention of the .gz files, since
13660 that's installation-specific, but keep the mention of
13661 `get-load-suffixes'.
13662
da64016e
PE
136632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13664
13665 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
13666 Report string overflow if the output is too long.
13667
7d47b580
JB
136682011-07-04 Juanma Barranquero <lekktu@gmail.com>
13669
a555cb87
JB
13670 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
13671 (syms_of_gnutls): Remove duplicate DEFSYM for
13672 Qgnutls_bootprop_verify_hostname_error, an error for
13673 Qgnutls_bootprop_verify_error (which is no longer used).
13674
7d47b580
JB
13675 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
13676 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
13677 Also (re)move comments that are misplaced or no longer relevant.
13678
1e49bfab
LMI
136792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13680
13681 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
13682
1485f4c0
CY
136832011-07-03 Chong Yidong <cyd@stupidchicken.com>
13684
13685 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
13686 and background color parameters if they have been changed.
13687
a9ab721e
LMI
136882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
13689
13690 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
13691
cf7cff57
PE
136922011-07-03 Paul Eggert <eggert@cs.ucla.edu>
13693
2e13213d
PE
13694 * xsettings.c (SYSTEM_FONT): Define only when used.
13695 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
13696
cf7cff57
PE
13697 * keymap.c (access_keymap_1): Now static.
13698
7a8e04f7
CY
136992011-07-02 Chong Yidong <cyd@stupidchicken.com>
13700
13701 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
13702 leave any prefix arg for the up event (Bug#1586).
13703
61352f62
LMI
137042011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
13705
69bb1ef7
LMI
13706 * lread.c (syms_of_lread): Mention single symbols defined by
13707 `defvar' or `defconst' (bug#7154).
13708
61352f62 13709 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 13710 (Frequire): Mention get-load-suffixes.
61352f62 13711
28545e04
MR
137122011-07-02 Martin Rudalics <rudalics@gmx.at>
13713
13714 * window.h (window): Remove clone_number slot.
13715 * window.c (Fwindow_clone_number, Fset_window_clone_number):
13716 Remove.
13717 (make_parent_window, make_window, saved_window)
13718 (Fset_window_configuration, save_window_save): Don't deal with
13719 clone numbers.
13720 * buffer.c (Qclone_number): Remove declaration.
13721 (sort_overlays, overlay_strings): Don't deal with clone numbers.
13722
3349e122
SM
137232011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
13724
13725 Add multiple inheritance to keymaps.
13726 * keymap.c (Fmake_composed_keymap): New function.
13727 (Fset_keymap_parent): Simplify.
13728 (fix_submap_inheritance): Remove.
13729 (access_keymap_1): New function extracted from access_keymap to handle
13730 embedded parents and handle lists of maps.
13731 (access_keymap): Use it.
13732 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
13733 (Fcopy_keymap): Handle embedded parents.
13734 (Fcommand_remapping, define_as_prefix): Simplify.
13735 (Fkey_binding): Simplify.
13736 (syms_of_keymap): Move minibuffer-local-completion-map,
13737 minibuffer-local-filename-completion-map,
13738 minibuffer-local-must-match-map, and
13739 minibuffer-local-filename-must-match-map to Elisp.
13740 (syms_of_keymap): Defsubr make-composed-keymap.
13741 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
13742 (parse_menu_item): Trivial simplification.
13743
3279eb87
GM
137442011-07-01 Glenn Morris <rgm@gnu.org>
13745
13746 * Makefile.in (SETTINGS_LIBS): Fix typo.
13747
39cb9e56 137482011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
13749
13750 * coding.c (Fencode_coding_string): Record the last coding system
13751 used, as the function doc string says (bug#8738).
13752
0949d2b6
JD
137532011-07-01 Jan Djärv <jan.h.d@swipnet.se>
13754
13755 * xsettings.c (store_monospaced_changed): Take new font as arg and
13756 check for change against current_mono_font.
13757 (EMACS_TYPE_SETTINGS): Remove this and related defines.
13758 (emacs_settings_constructor, emacs_settings_get_property)
13759 (emacs_settings_set_property, emacs_settings_class_init)
13760 (emacs_settings_init, gsettings_obj): Remove.
13761 (something_changedCB): New function for HAVE_GSETTINGS.
13762 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
13763 with value as argument.
13764 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
13765 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 13766 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
13767 "changed".
13768
13769 * xgselect.c: Add defined (HAVE_GSETTINGS).
13770 (xgselect_initialize): Ditto.
13771
13772 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
13773 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
13774 xg_select.
13775
bbc6b304
PE
137762011-07-01 Paul Eggert <eggert@cs.ucla.edu>
13777
13778 * eval.c (struct backtrace): Simplify and port the data structure.
13779 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
13780 signed bit field, as this assumption is not portable and it makes
13781 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
13782 "char debug_on_exit : 1" as this is not portable either; instead,
13783 use the portable "unsigned int debug_on_exit : 1". Remove unused
13784 member evalargs. Remove obsolete comments about cc bombing out.
13785
9851bfc5
JD
137862011-06-30 Jan Djärv <jan.h.d@swipnet.se>
13787
51bb811f 13788 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
13789 Let HAVE_GSETTINGS override HAVE_GCONF.
13790 (store_monospaced_changed): New function.
13791 (EMACS_SETTINGS): A new type derived from GObject to handle
13792 GSettings notifications.
13793 (emacs_settings_constructor, emacs_settings_get_property)
13794 (emacs_settings_set_property, emacs_settings_class_init):
13795 New functions.
13796 (gsettings_client, gsettings_obj): New variables.
13797 (GSETTINGS_SCHEMA): New define.
13798 (something_changedCB): Call store_monospaced_changed.
13799 (init_gsettings): New function.
13800 (xsettings_initialize): Call init_gsettings.
13801 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
13802 to NULL.
13803
640c8776 13804 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
13805 GCONF_CFLAGS/LIBS.
13806
5386012d
MR
138072011-06-29 Martin Rudalics <rudalics@gmx.at>
13808
13809 * window.c (resize_root_window, grow_mini_window)
13810 (shrink_mini_window): Rename Qresize_root_window to
13811 Qwindow_resize_root_window and Qresize_root_window_vertically to
13812 Qwindow_resize_root_window_vertically.
13813
f13e0b08
PE
138142011-06-28 Paul Eggert <eggert@cs.ucla.edu>
13815
13816 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
13817
94515237
JB
138182011-06-27 Juanma Barranquero <lekktu@gmail.com>
13819
13820 * makefile.w32-in: Redesign dependencies so they reflect more
13821 clearly which files are directly included by each source file,
13822 and not through other includes.
13823
e43b6e43
MR
138242011-06-27 Martin Rudalics <rudalics@gmx.at>
13825
13826 * buffer.c (Qclone_number): Declare static and DEFSYM it.
13827 (sort_overlays, overlay_strings): When an overlay's clone number
13828 matches the window's clone number process the overlay even if
13829 the overlay's window property doesn't match the current window.
13830
d68443dc
MR
13831 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
13832 (Fwindow_hchild): Rename to Fwindow_left_child.
13833 (Fwindow_next): Rename to Fwindow_next_sibling.
13834 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
13835 (resize_window_check): Rename to window_resize_check.
13836 (resize_window_apply): Rename to window_resize_apply.
13837 (Fresize_window_apply): Rename to Fwindow_resize_apply.
13838 (Fdelete_other_windows_internal, resize_frame_windows)
13839 (Fsplit_window_internal, Fdelete_window_internal)
13840 (grow_mini_window, shrink_mini_window)
13841 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 13842
c7e73be5
JD
138432011-06-26 Jan Djärv <jan.h.d@swipnet.se>
13844
13845 * emacsgtkfixed.h: State that this is only used with Gtk+3.
13846 (emacs_fixed_set_min_size): Remove.
13847 (emacs_fixed_new): Take frame as argument.
13848
13849 * emacsgtkfixed.c: State that this is only used with Gtk+3.
13850 (_EmacsFixedPrivate): Remove minwidth/height.
13851 Add struct frame *f.
13852 (emacs_fixed_init): Initialize priv->f.
13853 (get_parent_class, emacs_fixed_set_min_size): Remove.
13854 (emacs_fixed_new): Set priv->f to argument.
13855 (emacs_fixed_get_preferred_width)
13856 (emacs_fixed_get_preferred_height): Use min_width/height from
13857 frames size_hint to set minimum and natural (Bug#8919).
13858 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
13859 and use min_width/height from frames size_hint to set
13860 min_width/height (Bug#8919).
13861
13862 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
13863 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
13864 Fix indentation.
c7e73be5 13865
cf99dcf8
EZ
138662011-06-26 Eli Zaretskii <eliz@gnu.org>
13867
13868 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
13869 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
13870 called at ZV.
13871
029529ac
CY
138722011-06-26 Chong Yidong <cyd@stupidchicken.com>
13873
13874 * process.c (wait_reading_process_output): Bypass select if
13875 waiting for a cell while ignoring keyboard input, and input is
13876 pending. Suggested by Jan Djärv (Bug#8869).
13877
7a7ef429
PE
138782011-06-25 Paul Eggert <eggert@cs.ucla.edu>
13879
13880 Use gnulib's dup2 module instead of rolling our own.
13881 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
13882
11fdef7d 138832011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
13884
13885 * dispnew.c (scrolling_window): Before scrolling, turn off a
13886 mouse-highlight in the window being scrolled.
13887
cd3520a4
JB
138882011-06-24 Juanma Barranquero <lekktu@gmail.com>
13889
13890 Move DEFSYM to lisp.h and use everywhere.
13891
13892 * character.h (DEFSYM): Move declaration...
13893 * lisp.h (DEFSYM): ...here.
13894
13895 * gnutls.c:
13896 * minibuf.c:
13897 * w32menu.c:
13898 * w32proc.c:
13899 * w32select.c: Don't include character.h.
13900
13901 * alloc.c (syms_of_alloc):
13902 * buffer.c (syms_of_buffer):
13903 * bytecode.c (syms_of_bytecode):
13904 * callint.c (syms_of_callint):
13905 * casefiddle.c (syms_of_casefiddle):
13906 * casetab.c (init_casetab_once):
13907 * category.c (init_category_once, syms_of_category):
13908 * ccl.c (syms_of_ccl):
13909 * cmds.c (syms_of_cmds):
13910 * composite.c (syms_of_composite):
13911 * dbusbind.c (syms_of_dbusbind):
13912 * dired.c (syms_of_dired):
13913 * dispnew.c (syms_of_display):
13914 * doc.c (syms_of_doc):
13915 * editfns.c (syms_of_editfns):
13916 * emacs.c (syms_of_emacs):
13917 * eval.c (syms_of_eval):
13918 * fileio.c (syms_of_fileio):
13919 * fns.c (syms_of_fns):
13920 * frame.c (syms_of_frame):
13921 * fringe.c (syms_of_fringe):
13922 * insdel.c (syms_of_insdel):
13923 * keymap.c (syms_of_keymap):
13924 * lread.c (init_obarray, syms_of_lread):
13925 * macros.c (syms_of_macros):
13926 * msdos.c (syms_of_msdos):
13927 * print.c (syms_of_print):
13928 * process.c (syms_of_process):
13929 * search.c (syms_of_search):
13930 * sound.c (syms_of_sound):
13931 * syntax.c (init_syntax_once, syms_of_syntax):
13932 * terminal.c (syms_of_terminal):
13933 * textprop.c (syms_of_textprop):
13934 * undo.c (syms_of_undo):
13935 * w32.c (globals_of_w32):
13936 * window.c (syms_of_window):
13937 * xdisp.c (syms_of_xdisp):
13938 * xfaces.c (syms_of_xfaces):
13939 * xfns.c (syms_of_xfns):
13940 * xmenu.c (syms_of_xmenu):
13941 * xsettings.c (syms_of_xsettings):
13942 * xterm.c (syms_of_xterm): Use DEFSYM.
13943
4228cf16
TZ
139442011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13945
cd3520a4 13946 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13947
7fcccf1e
PE
139482011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13949
7efb4e0e
PE
13950 Integer and buffer overflow fixes (Bug#8873).
13951
ff5844ad
PE
13952 * print.c (printchar, strout): Check for string overflow.
13953 (PRINTPREPARE, printchar, strout):
13954 Don't set size unless allocation succeeds.
13955
90532f02
PE
13956 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13957 for sizes. Check for string overflow more accurately.
13958 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13959
6d84508d
PE
13960 * macros.c: Integer and buffer overflow fixes.
13961 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13962 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13963 Use ptrdiff_t, not int, for sizes.
13964 Don't increment bufsize until after realloc succeeds.
13965 Check for size-calculation overflow.
13966 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13967
437b2cb4
PE
13968 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13969
8b9ac8b4
PE
13970 * lread.c: Integer overflow fixes.
13971 (read_integer): Radix is now EMACS_INT, not int,
13972 to improve quality of diagnostics for out-of-range radices.
13973 Calculate buffer size correctly for out-of-range radices.
13974 (read1): Check for integer overflow in radices, and in
13975 read-circle numbers.
82cb60d3
PE
13976 (read_escape): Avoid int overflow.
13977 (Fload, openp, read_buffer_size, read1)
13978 (substitute_object_recurse, read_vector, read_list, map_obarray):
13979 Use ptrdiff_t, not int, for sizes.
13980 (read1): Use EMACS_INT, not int, for sizes.
20270765 13981 Check for size overflow.
8b9ac8b4 13982
7fcccf1e
PE
13983 * image.c (cache_image): Check for size arithmetic overflow.
13984
bfbbd7e7
PE
13985 * lread.c: Integer overflow issues.
13986 (saved_doc_string_size, saved_doc_string_length)
13987 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13988 Now ptrdiff_t, not int.
13989 (read1): Don't assume doc string length fits in int. Check for
13990 out-of-range doc string lengths.
13991 (read_list): Don't assume file position fits in int.
39019e54 13992 (read_escape): Check for hex character overflow.
bfbbd7e7 13993
4e323265
LL
139942011-06-22 Leo Liu <sdl.web@gmail.com>
13995
13996 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13997 Move to minibuffer.el.
13998
85fece3e
PE
139992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
14000
20b84ce9 14001 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
14002 The following patches are for when GLYPH_DEBUG && !XASSERT.
14003 * dispextern.h (trace_redisplay_p, dump_glyph_string):
14004 * dispnew.c (flush_stdout):
14005 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
14006 Mark as externally visible.
14007 * dispnew.c (check_window_matrix_pointers): Now static.
14008 * dispnew.c (window_to_frame_vpos):
14009 * xfns.c (unwind_create_frame):
14010 * xterm.c (x_check_font): Remove unused local.
14011 * scroll.c (CHECK_BOUNDS):
14012 * xfaces.c (cache_fache): Rename local to avoid shadowing.
14013 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
14014 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
14015 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
14016 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
14017 Now static.
14018 (debug_method_add): Use va_list and vsprintf rather than relying
14019 on undefined behavior with wrong number of arguments.
14020 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
14021 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
14022 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
14023 since we're not interested in debugging glyphs with old libraries.
14024 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
14025 GCC 4.6.0's static checking.
14026
0766b489
PE
140272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
14028
31fd4b32
PE
14029 Integer overflow and signedness fixes (Bug#8873).
14030 A few related buffer overrun fixes, too.
14031
b79e8648
PE
14032 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
14033
0766b489
PE
14034 * dispextern.h (struct face.stipple):
14035 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
14036 (x_bitmap_mask, x_allocate_bitmap_record)
14037 (x_create_bitmap_from_data, x_create_bitmap_from_file)
14038 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
14039 (x_create_bitmap_from_xpm_data):
14040 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
14041 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
14042 (.bitmaps_last):
14043 * xfaces.c (load_pixmap):
14044 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
14045 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
14046 (.bitmaps_last, struct x_output.icon_bitmap):
14047 Use ptrdiff_t, not int, for bitmap indexes.
14048 (x_allocate_bitmap_record): Check for size overflow.
14049 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
14050
b081724f
PE
14051 Use ptrdiff_t, not int, for overlay counts.
14052 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
14053 * editfns.c (overlays_around, get_pos_property):
14054 * textprop.c (get_char_property_and_overlay):
14055 * xdisp.c (next_overlay_change, note_mouse_highlight):
14056 * xfaces.c (face_at_buffer_position):
21514da7
PE
14057 * buffer.c (OVERLAY_COUNT_MAX): New macro.
14058 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
14059 (Fnext_overlay_change, Fprevious_overlay_change)
14060 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 14061 Use ptrdiff_t, not int, for sizes.
21514da7 14062 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 14063
3de73e5e
PE
14064 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
14065
2606c57b
PE
14066 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
14067 (x_session_initialize): Do not assume string length fits in int.
14068
aaafe47a
PE
14069 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
14070 This is unlikely, but can occur if DPI is outlandish.
14071
2674ddc8 14072 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
14073 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
14074
28154962
PE
14075 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
14076 * xrdb.c (magic_file_p, search_magic_path):
14077 Omit last arg SUFFIX; it was always 0. All callers changed.
14078 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
14079
7de51af5
PE
14080 * xfont.c (xfont_match): Avoid need for strlen.
14081
25ed6cc3
PE
14082 * xfns.c: Don't assume strlen fits in int.
14083 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
14084
4eab31dd
PE
14085 * xdisp.c (message_log_check_duplicate): Return intmax_t,
14086 not unsigned long, as we prefer signed integers. All callers changed.
14087 Detect integer overflow in repeat count.
14088 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 14089 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 14090
171e2a58
PE
14091 * termcap.c: Don't assume sizes fit in int and never overflow.
14092 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
14093 (gobble_line): Check for size-calculation overflow.
14094
ad39faca 14095 * minibuf.c (Fread_buffer):
6e5bb2dc 14096 * lread.c (intern, intern_c_string):
74ca2eb3
PE
14097 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
14098 Don't assume string length fits in int.
14099
52c61c22 14100 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
14101 * gtkutil.c (style_changed_cb): Avoid need for strlen.
14102
b5b8c9e5
PE
14103 * font.c: Don't assume string length fits in int.
14104 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
14105 Use ptrdiff_t, not int.
ccd6111c
PE
14106 (font_intern_prop): Don't assume string length fits in int.
14107 Don't assume integer property fits in fixnum.
14108 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 14109
882f0d81 14110 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 14111 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
14112 Reformulate so as not to need the command string.
14113 Invoke gzip -cd rather than gunzip, as it's more portable.
14114 (lock_info_type, lock_file_1, lock_file):
14115 Don't assume pid_t and time_t fit in unsigned long.
14116 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
14117 (current_lock_owner): Prefer signed type for sizes.
14118 Use memcpy, not strncpy, where memcpy is what is really wanted.
14119 Don't assume (via atoi) that time_t and pid_t fit in int.
14120 Check for time_t and/or pid_t out of range, e.g., via a network share.
14121 Don't alloca where an auto var works fine.
14122
93f4cf88
PE
14123 * fileio.c: Fix some integer overflow issues.
14124 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
14125 Don't assume string length fits in int.
14126 (directory_file_name): Don't assume string length fits in long.
14127 (make_temp_name): Don't assume pid fits in int, or that its print
14128 length is less than 20.
14129
f3e92b69
PE
14130 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
14131
1bfdaf10
PE
14132 * coding.c (make_subsidiaries): Don't assume string length fits in int.
14133
35016e9a
PE
14134 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
14135
3d1e65a1
PE
14136 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
14137 We prefer signed integers, even for size calculations.
14138
0b963a93
PE
14139 * emacs.c: Don't assume string length fits in 'int'.
14140 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
14141 (main): Don't invoke strlen when not needed.
14142
573f4b54
PE
14143 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
14144 (XD_DEBUG_MESSAGE): Don't waste a byte.
14145
989f33ba
PE
14146 * callproc.c (getenv_internal_1, getenv_internal)
14147 (Fgetenv_internal):
965d34eb
PE
14148 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
14149
e4d29b33
PE
14150 * lread.c (invalid_syntax): Omit length argument.
14151 All uses changed. This doesn't fix a bug, but it simplifies the
14152 code away from its former Hollerith-constant appearance, and it's
14153 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 14154 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 14155
eb49b136
PE
14156 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
14157 This didn't break anything, but it didn't help either.
14158 It's confusing to put a bogus integer in a place where the actual
14159 value does not matter.
9f62aeb1 14160 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 14161 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 14162
15375a22
PE
14163 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
14164 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
14165 implementation.
b61cc01c
PE
14166 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
14167 We prefer signed types, and the value cannot exceed the EMACS_INT
14168 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
14169 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
14170 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
14171 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 14172
53b2623d
PE
14173 * indent.c (sane_tab_width): New function.
14174 (current_column, scan_for_column, Findent_to, position_indentation)
14175 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 14176 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 14177
51cab52b 14178 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 14179
f2ed8a70
PE
14180 * lisp.h (lint_assume): New macro.
14181 * composite.c (composition_gstring_put_cache):
14182 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
14183
abe80cc6
PE
14184 * editfns.c, insdel.c:
14185 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 14186
b02c740e
PE
14187 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
14188
ebc96716
PE
14189 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
14190
b4e50fa0 14191 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 14192 Use much-faster test for byte-length change.
311d5d7c 14193 Don't assume string byte-length fits in 'int'.
a4cf38e4 14194 Check that character arg fits in 'int'.
85461888 14195 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 14196
c0c1ee9f
PE
14197 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
14198
a498d7f4
PE
14199 * fns.c (concat): Catch string overflow earlier.
14200 Do not rely on integer wraparound.
14201
51cab52b
PE
14202 * dispextern.h (struct it.overlay_strings_charpos)
14203 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
14204 * xdisp.c (forward_to_next_line_start)
14205 (back_to_previous_visible_line_start)
14206 (reseat_at_next_visible_line_start, next_element_from_buffer):
14207 Don't arbitrarily truncate the value of 'selective' to int.
14208
76031fad
PE
14209 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
14210
5eb55db9
PE
14211 * composite.c: Don't truncate sizes to 'int'.
14212 (composition_gstring_p, composition_reseat_it)
14213 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
14214 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
14215 not EMACS_UINT, for indexes.
5eb55db9 14216
0703a717
PE
14217 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
14218
d6202519
PE
14219 * buffer.c: Include <verify.h>.
14220 (struct sortvec.priority, struct sortstr.priority):
8961a454 14221 Now EMACS_INT, not int.
c20998a7 14222 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
14223 (struct sortstr.size, record_overlay_string)
14224 (struct sortstrlist.size, struct sortlist.used):
14225 Don't truncate size to int.
14226 (record_overlay_string): Check for size-calculation overflow.
d6202519 14227 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 14228
d5a19415
JM
142292011-06-22 Jim Meyering <meyering@redhat.com>
14230
029529ac 14231 Don't leak an XBM-image-sized buffer
d5a19415
JM
14232 * image.c (xbm_load): Free the image buffer after using it.
14233
a9041e6c
PE
142342011-06-21 Paul Eggert <eggert@cs.ucla.edu>
14235
14236 Port to Sun C.
14237 * composite.c (find_automatic_composition): Omit needless 'return 0;'
14238 that Sun C diagnosed.
14239 * fns.c (secure_hash): Fix pointer signedness issue.
14240 * intervals.c (static_offset_intervals): New function.
14241 (offset_intervals): Use it.
14242
7f3f739f
LL
142432011-06-21 Leo Liu <sdl.web@gmail.com>
14244
14245 * deps.mk (fns.o):
14246 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
14247 sha512.h.
14248
14249 * fns.c (secure_hash): Rename from crypto_hash_function and change
14250 the first arg to accept symbols.
5b66d427 14251 (Fsecure_hash): New primitive.
7f3f739f
LL
14252 (syms_of_fns): New symbols.
14253
76147d94
DD
142542011-06-20 Deniz Dogan <deniz@dogan.se>
14255
14256 * process.c (Fset_process_buffer): Clarify return value in
14257 docstring.
14258
7d7d0045
CY
142592011-06-18 Chong Yidong <cyd@stupidchicken.com>
14260
14261 * dispnew.c (add_window_display_history): Use BVAR.
14262
14263 * xdisp.c (debug_method_add): Use BVAR.
14264 (check_window_end, dump_glyph_matrix, dump_glyph)
14265 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
14266
14267 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
14268 Likewise.
14269
14270 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
14271 check till after the cache is created in init_frame_faces.
14272
ff2bc410
SM
142732011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
14274
14275 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
14276
28177add
PE
142772011-06-16 Paul Eggert <eggert@cs.ucla.edu>
14278
dd3482fe
PE
14279 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
14280 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
14281 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
14282
393d71f3 14283 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
14284 * fileio.c (Finsert_file_contents):
14285 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
14286 Remove the old (too-loose) buffer overflow checks.
14287 They weren't needed, since make_gap checks for buffer overflow.
14288 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
14289 The old code merely checked for Emacs fixnum overflow, and relied
14290 on undefined (wraparound) behavior. The new code avoids undefined
14291 behavior, and also checks for ptrdiff_t and/or size_t overflow.
14292
2e6813b0 14293 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
14294 Tune. Don't use wider integers than needed. Don't use alloca.
14295 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 14296
599a9e4f
PE
14297 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
14298
99561444
PE
14299 * insdel.c, lisp.h (buffer_overflow): New function.
14300 (insert_from_buffer_1, replace_range, replace_range_2):
14301 * insdel.c (make_gap_larger):
14302 * editfns.c (Finsert_char):
14303 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
14304
28177add
PE
14305 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
14306
e69dafad
PE
143072011-06-15 Paul Eggert <eggert@cs.ucla.edu>
14308
4baa020d 14309 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 14310
b1c46f02
PE
14311 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
14312 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
14313
e69dafad
PE
14314 * fileio.c: Don't assume EMACS_INT fits in off_t.
14315 (emacs_lseek): New static function.
14316 (Finsert_file_contents, Fwrite_region): Use it.
14317 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
14318
566684ea
PE
14319 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
14320
e6966cd6
PE
14321 * fns.c: Don't overflow int when computing a list length.
14322 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
14323 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
14324 truncation on 64-bit hosts. Check for QUIT every
14325 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
14326 faster and is responsive enough.
14327 (Flength): Report an error instead of overflowing an integer.
14328 (Fsafe_length): Return a float if the value is not representable
14329 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 14330 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 14331 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 14332
dd0b0efb
PE
14333 * alloc.c: Check that resized vectors' lengths fit in fixnums.
14334 (header_size, word_size): New constants.
14335 (allocate_vectorlike): Don't check size overflow here.
14336 (allocate_vector): Check it here instead, since this is the only
14337 caller of allocate_vectorlike that could cause overflow.
14338 Check that the new vector's length is representable as a fixnum.
14339
86fe5cfe
PE
14340 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
14341 The previous code was bogus. For example, next_almost_prime (32)
14342 returned 39, which is undesirable as it is a multiple of 3; and
14343 next_almost_prime (24) returned 25, which is a multiple of 5 so
14344 why was the code bothering to check for multiples of 7?
14345
80e88859
PE
14346 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
14347
4a2f0ad6
PE
14348 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
14349
f66c7cf8
PE
14350 Variadic C functions now count arguments with ptrdiff_t.
14351 This partly undoes my 2011-03-30 change, which replaced int with size_t.
14352 Back then I didn't know that the Emacs coding style prefers signed int.
14353 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
14354 were being counted with int, which may truncate counts on 64-bit
14355 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
14356 * lisp.h (struct Lisp_Subr.function.aMANY)
14357 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
14358 Arg counts are now ptrdiff_t, not size_t.
14359 All variadic functions and their callers changed accordingly.
14360 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
14361 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
14362 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
14363 * callint.c (Fcall_interactively): Check arg count for overflow,
14364 to avoid potential buffer overrun. Use signed char, not 'int',
14365 for 'varies' array, so that we needn't bother to check its size
14366 calculation for overflow.
14367 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
14368 * eval.c (apply_lambda):
14369 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
14370 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
14371 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
14372
a1759b76
PE
14373 * callint.c (Fcall_interactively): Don't use index var as event count.
14374
d96be9fc
PE
14375 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
14376 * mem-limits.h (SIZE): Remove; no longer used.
14377
a690a978 14378 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 14379
578c21e6
PE
14380 Remove unnecessary casts.
14381 * xterm.c (x_term_init):
14382 * xfns.c (x_set_border_pixel):
14383 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
14384 These aren't needed now that we assume ANSI C.
14385
96f53c6c
PE
14386 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
14387 It's more likely to cause problems (due to unsigned overflow)
14388 than to cure them.
14389
83c77d31
PE
14390 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
14391
ee2079f1
PE
14392 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
14393
6da65536
PE
14394 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
14395
7147c4a4
PE
14396 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
14397
193e32d9
PE
14398 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
14399
e5533da6
PE
14400 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
14401
9910e595
PE
14402 GLYPH_CODE_FACE returns EMACS_INT, not int.
14403 * dispextern.h (merge_faces):
14404 * xfaces.c (merge_faces):
01103c44
PE
14405 * xdisp.c (get_next_display_element, next_element_from_display_vector):
14406 Don't assume EMACS_INT fits in int.
9910e595 14407
2638320e
PE
14408 * character.h (CHAR_VALID_P): Remove unused parameter.
14409 * fontset.c, lisp.h, xdisp.c: All uses changed.
14410
045eb8d9
PE
14411 * editfns.c (Ftranslate_region_internal): Omit redundant test.
14412
c1f134b5
PE
14413 * fns.c (concat): Minor tuning based on overflow analysis.
14414 This doesn't fix any bugs. Use int to hold character, instead
14415 of constantly refetching from Emacs object. Use XFASTINT, not
14416 XINT, for value known to be a character. Don't bother comparing
14417 a single byte to 0400, as it's always less.
14418
395fcb93 14419 * floatfns.c (Fexpt):
327eeec8
PE
14420 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
14421
abbd3d23
PE
14422 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
14423 for characters.
14424
684a03ef
PE
14425 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
14426
0fed43f3
PE
14427 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
14428 Without this fix, on a 64-bit host (aset S 0 4294967386) would
14429 incorrectly succeed when S was a string, because 4294967386 was
14430 truncated before it was used.
14431
8fd02eb7
PE
14432 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
14433 Otherwise, an out-of-range integer could cause undefined behavior
14434 on a 64-bit host.
14435
f8c86b69
PE
14436 * composite.c: Use int, not EMACS_INT, for characters.
14437 (fill_gstring_body, composition_compute_stop_pos): Use int, not
14438 EMACS_INT, for values that are known to be in character range.
14439 This doesn't fix any bugs but is the usual style inside Emacs and
14440 may generate better code on 32-bit machines.
14441
34206dd2
PE
14442 Make sure a 64-bit char is never passed to ENCODE_CHAR.
14443 This is for reasons similar to the recent CHAR_STRING fix.
14444 * charset.c (Fencode_char): Check that character arg is actually
14445 a character. Pass an int to ENCODE_CHAR.
14446 * charset.h (ENCODE_CHAR): Verify that the character argument is no
14447 wider than 'int', as a compile-time check to prevent future regressions
14448 in this area.
14449
c5958d4c 14450 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
14451
14452 Make sure a 64-bit char is never passed to CHAR_STRING.
14453 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
14454 by silently ignoring the top 32 bits, allowing some values
14455 that were far too large to be valid characters.
14456 * character.h: Include <verify.h>.
14457 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
14458 arguments are no wider than unsigned, as a compile-time check
14459 to prevent future regressions in this area.
14460 * data.c (Faset):
01103c44 14461 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
14462 (Fsubst_char_in_region):
14463 * fns.c (concat):
14464 * xdisp.c (decode_mode_spec_coding):
14465 Adjust to CHAR_STRING's new requirement.
14466 * editfns.c (Finsert_char, Fsubst_char_in_region):
14467 * fns.c (concat): Check that character args are actually
14468 characters. Without this test, these functions did the wrong
14469 thing with wildly out-of-range values on 64-bit hosts.
14470
d37ca623
PE
14471 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
14472 These casts should not be needed on 32-bit hosts, either.
14473 * keyboard.c (read_char):
14474 * lread.c (Fload): Remove casts to unsigned.
14475
ea204efb
PE
14476 * lisp.h (UNSIGNED_CMP): New macro.
14477 This fixes comparison bugs on 64-bit hosts.
14478 (ASCII_CHAR_P): Use it.
14479 * casefiddle.c (casify_object):
01103c44 14480 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
14481 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
14482 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
14483 * dispextern.h (FACE_FROM_ID):
14484 * keyboard.c (read_char): Use UNSIGNED_CMP.
14485
41cb286c
PE
14486 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
14487 not to EMACS_INT, to avoid GCC warning.
14488
4a1b9832
PE
14489 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
14490
55daad71
PE
14491 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
14492 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
14493 isn't needed on 32-bit machines.
8f95c75c 14494
01103c44
PE
14495 * buffer.c (Fgenerate_new_buffer_name):
14496 Use EMACS_INT for count, not int.
0ceccced 14497 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
14498
14499 * data.c (Qcompiled_function): Now static.
14500
c6f072e7
PE
14501 * window.c (window_body_lines): Now static.
14502
20ce5912
PE
14503 * image.c (gif_load): Rename local to avoid shadowing.
14504
9c4c5f81
PE
14505 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
14506 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
14507 * alloc.c (make_save_value): Integer argument is now of type
14508 ptrdiff_t, not int.
14509 (mark_object): Use ptrdiff_t, not int.
14510 * lisp.h (pD): New macro.
14511 * print.c (print_object): Use it.
14512
c0c5c8ae
PE
14513 * alloc.c: Use EMACS_INT, not int, to count objects.
14514 (total_conses, total_markers, total_symbols, total_vector_size)
14515 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
14516 (total_free_floats, total_floats, total_free_intervals)
14517 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
14518 Now EMACS_INT, not int. All uses changed.
14519 (Fgarbage_collect): Compute overall total using a double, so that
14520 integer overflow is less likely to be a problem. Check for overflow
14521 when converting back to an integer.
5a25e253
PE
14522 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
14523 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14524 These were 'int' variables that could overflow on 64-bit hosts;
14525 they were never used, so remove them instead of repairing them.
211a0b2a 14526 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
14527 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
14528 Previously, this ceilinged at INT_MAX, but that doesn't work on
14529 64-bit machines.
e46bb31a 14530 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 14531
c78baabf 14532 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 14533 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
14534 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
14535 when a (possibly-narrower) signed value would do just as well.
14536 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 14537
c9d624c6
PE
14538 * alloc.c: Catch some string size overflows that we were missing.
14539 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
14540 for convenience in STRING_BYTES_MAX.
14541 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
14542 The definition here is exact; the one in lisp.h was approximate.
14543 (allocate_string_data): Check for string overflow. This catches
14544 some instances we weren't catching before. Also, it catches
14545 size_t overflow on (unusual) hosts where SIZE_MAX <= min
14546 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
14547 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 14548
c9d624c6
PE
14549 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
14550 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 14551 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 14552
353032ce
PE
14553 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
14554
2bccce07
PE
14555 * alloc.c (Fmake_string): Check for out-of-range init.
14556
0ac30604
SM
145572011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
14558
14559 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
14560
c195f2de
JD
145612011-06-14 Jan Djärv <jan.h.d@swipnet.se>
14562
14563 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
14564 xg_get_default_scrollbar_width.
14565
14566 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
14567 (int_gtk_range_get_value): Move to the scroll bar part of the file.
14568 (style_changed_cb): Call update_theme_scrollbar_width and call
14569 x_set_scroll_bar_default_width and xg_frame_set_char_size for
14570 all frames (Bug#8505).
14571 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
14572 Call gtk_window_set_resizable if HAVE_GTK3.
14573 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
14574 and height if HAVE_GTK3 (Bug#8505).
14575 (scroll_bar_width_for_theme): New variable.
14576 (update_theme_scrollbar_width): New function.
14577 (xg_get_default_scrollbar_width): Move code to
14578 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
14579 (xg_initialize): Call update_theme_scrollbar_width.
14580
14581 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
14582
14583 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
14584
e10ac9f1
MR
145852011-06-12 Martin Rudalics <rudalics@gmx.at>
14586
14587 * frame.c (make_frame): Call other_buffer_safely instead of
14588 other_buffer.
14589
14590 * window.c (temp_output_buffer_show): Call display_buffer with
14591 second argument Vtemp_buffer_show_specifiers and reset latter
14592 immediately after the call.
14593 (Vtemp_buffer_show_specifiers): New variable.
14594 (auto_window_vscroll_p, next_screen_context_lines)
14595 (Vscroll_preserve_screen_position): Remove leading asterisks from
14596 doc-strings.
14597
2d3c217e 145982011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 14599
7b7f97e8 14600 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
14601 * buffer.c (Qclone_number): Remove for now, as it's unused.
14602 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
14603 (record_buffer): Remove unused local.
14604 * frame.c (other_visible_frames, frame_buffer_list): Now static.
14605 (set_frame_buffer_list): Remove; unused.
14606 * frame.h (other_visible_frames): Remove decl.
14607 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
14608 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
14609 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
14610 if HAVE_GPM.
14611 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
14612 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
14613 Define only if HAVE_GPM.
14614 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
14615 (update_hints_inhibit): Remove; never set. All uses removed.
14616 * widgetprv.h (emacsFrameClassRec): Remove decl.
14617 * window.c (delete_deletable_window): Now returns void, since it
14618 wasn't returning anything.
14619 (compare_window_configurations): Remove unused locals.
14620 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
14621 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
14622 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
14623 the same widths as pointers. This follows up on the 2011-05-06 patch.
14624 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
14625 * xterm.h: Likewise.
14626 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
14627
1384b89e
JB
146282011-06-12 Juanma Barranquero <lekktu@gmail.com>
14629
14630 * makefile.w32-in: Update dependencies.
14631 (LISP_H): Add lib/intprops.h.
14632
1100a63c
CY
146332011-06-11 Chong Yidong <cyd@stupidchicken.com>
14634
14635 * image.c (gif_load): Add animation frame delay to the metadata.
14636 (syms_of_image): Use DEFSYM. New symbol `delay'.
14637
6198ccd0
MR
146382011-06-11 Martin Rudalics <rudalics@gmx.at>
14639
14640 * window.c (delete_deletable_window): Re-add.
14641 (Fset_window_configuration): Rewrite to handle dead buffers and
14642 consequently deletable windows.
14643 (window_tree, Fwindow_tree): Remove. Supply functionality in
14644 window.el.
14645 (compare_window_configurations): Simplify code.
14646
b6e3633c
AS
146472011-06-11 Andreas Schwab <schwab@linux-m68k.org>
14648
1ab0dee5
AS
14649 * image.c (imagemagick_load_image): Fix type mismatch.
14650 (Fimagemagick_types): Likewise.
14651
b6e3633c
AS
14652 * window.h (replace_buffer_in_windows): Declare.
14653
9397e56f
MR
146542011-06-11 Martin Rudalics <rudalics@gmx.at>
14655
14656 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
14657 Qclone_number. Remove external declaration of Qdelete_window.
14658 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
14659 code.
640c8776
SM
14660 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
14661 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
14662 (Fother_buffer): Rewrite doc-string. Major rewrite for new
14663 buffer list implementation.
14664 (other_buffer_safely): New function.
14665 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
14666 calls to replace_buffer_in_windows and
14667 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
14668 if allowed.
14669 (record_buffer): Inhibit quitting and rewrite using quittable
14670 functions. Run Qbuffer_list_update_hook if allowed.
14671 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
14672 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
14673 Move switch-to-buffer to window.el.
9397e56f
MR
14674 (bury-buffer): Move to window.el.
14675 (Vbuffer_list_update_hook): New variable.
14676
14677 * lisp.h (other_buffer_safely): Add prototype in buffer.c
14678 section.
14679
14680 * window.h (resize_frame_windows): Move up in code.
14681 (Fwindow_frame): Remove EXFUN.
14682 (replace_buffer_in_all_windows): Remove prototype.
14683 (replace_buffer_in_windows_safely): Add prototype.
14684
14685 * window.c: Declare Qdelete_window static again. Move down
14686 declaration of select_count.
14687 (Fnext_window, Fprevious_window): Rewrite doc-strings.
14688 (Fother_window): Move to window.el.
14689 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
14690 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
14691 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
14692 window.el.
14693 (replace_buffer_in_windows): Implement by calling
14694 Qreplace_buffer_in_windows.
14695 (replace_buffer_in_all_windows): Remove with some functionality
14696 moved into replace_buffer_in_windows_safely.
14697 (replace_buffer_in_windows_safely): New function.
14698 (select_window_norecord, select_frame_norecord): Move in front
14699 of run_window_configuration_change_hook. Remove now obsolete
14700 declarations.
640c8776
SM
14701 (Fset_window_buffer): Rewrite doc-string.
14702 Call Qrecord_window_buffer.
9397e56f
MR
14703 (keys_of_window): Move binding for other-window to window.el.
14704
b50691aa
CY
147052011-06-11 Chong Yidong <cyd@stupidchicken.com>
14706
14707 * dispextern.h (struct image): Replace data member, whose int_val
14708 and ptr_val fields were not used by anything, with a single
14709 lisp_val object.
14710
14711 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
14712 (gif_clear_image, gif_load, imagemagick_load_image)
14713 (gs_clear_image, gs_load): Callers changed.
14714
3f754b86
PE
147152011-06-10 Paul Eggert <eggert@cs.ucla.edu>
14716
cca69397
PE
14717 * buffer.h: Include <time.h>, for time_t.
14718 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
14719
109e28d0
PE
14720 Fix minor problems found by static checking.
14721
60737f02
PE
14722 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
14723
4b66faf3
PE
14724 Make identifiers static if they are not used in other modules.
14725 * data.c (Qcompiled_function, Qframe, Qvector):
14726 * image.c (QimageMagick, Qsvg):
14727 * minibuf.c (Qmetadata):
14728 * window.c (resize_window_check, resize_root_window): Now static.
14729 * window.h (resize_window_check, resize_root_window): Remove decls.
14730
109e28d0
PE
14731 * window.c (window_deletion_count, delete_deletable_window):
14732 Remove; unused.
46a4ce9e
PE
14733 (window_body_lines): Now static.
14734 (Fdelete_other_windows_internal): Mark vars as initialized.
14735 Make sure 'resize_failed' is initialized.
14736 (run_window_configuration_change_hook): Rename local to avoid shadowing.
14737 (resize_window_apply): Remove unused local.
14738 * window.h (delete_deletable_window): Remove decl.
14739
109e28d0 14740 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
14741 (imagemagick_load_image): Fix pointer signedness problem by changing
14742 last arg from unsigned char * to char *. All uses changed.
14743 Also, fix a local for similar reasons.
14744 Remove unused locals. Remove locals to avoid shadowing.
14745 (fn_rsvg_handle_free): Remove; unused.
14746 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 14747 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 14748
3f754b86
PE
14749 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
14750
2547adb1
CY
147512011-06-10 Chong Yidong <cyd@stupidchicken.com>
14752
14753 * image.c (gif_load): Fix omitted cast error introduced by
14754 2011-06-06 change.
14755
2c8e37d4
MR
147562011-06-10 Martin Rudalics <rudalics@gmx.at>
14757
14758 * window.h (resize_proportionally, orig_total_lines)
14759 (orig_top_line): Remove from window structure.
14760 (set_window_height, set_window_width, change_window_heights)
14761 (Fdelete_window): Remove prototypes.
14762 (resize_frame_windows): Remove duplicate declaration.
14763
440a42e3
EZ
147642011-06-10 Eli Zaretskii <eliz@gnu.org>
14765
14766 * window.h (resize_frame_windows, resize_window_check)
14767 (delete_deletable_window, resize_root_window)
14768 (resize_frame_windows): Declare prototypes.
14769
14770 * window.c (resize_window_apply): Make definition be "static" to
14771 match the prototype.
14772
562dd5e9
MR
147732011-06-10 Martin Rudalics <rudalics@gmx.at>
14774
14775 * window.c: Remove declarations of Qwindow_size_fixed,
14776 window_min_size_1, window_min_size_2, window_min_size,
14777 size_window, window_fixed_size_p, enlarge_window, delete_window.
14778 Remove static from declaration of Qdelete_window, it's
14779 temporarily needed by Fbury_buffer.
14780 (replace_window): Don't assign orig_top_line and
14781 orig_total_lines.
14782 (Fdelete_window, delete_window): Remove. Window deletion is
14783 handled by window.el.
640c8776
SM
14784 (window_loop): Remove DELETE_OTHER_WINDOWS case.
14785 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
14786 (Fdelete_other_windows): Remove. Deleting other windows is
14787 handled by window.el.
14788 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
14789 handled in window.el.
14790 (window_min_size_2, window_min_size_1, window_min_size): Remove.
14791 Window minimum sizes are handled in window.el.
14792 (shrink_windows, size_window, set_window_height)
14793 (set_window_width, change_window_heights, window_height)
14794 (window_width, CURBEG, CURSIZE, enlarge_window)
14795 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
14796 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
14797 handled in window.el.
14798 (make_dummy_parent): Rename to make_parent_window and give it a
14799 second argument horflag.
14800 (make_window): Don't set resize_proportionally any more.
14801 (Fsplit_window): Remove. Windows are split in window.el.
14802 (save_restore_action, save_restore_orig_size)
14803 (shrink_window_lowest_first, save_restore_orig_size): Remove.
14804 Resize mini windows in window.el.
14805 (grow_mini_window, shrink_mini_window): Implement by calling
14806 Qresize_root_window_vertically, resize_window_check and
14807 resize_window_apply.
640c8776
SM
14808 (saved_window, Fset_window_configuration, save_window_save):
14809 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
14810 resize_proportionally.
14811 (window_min_height, window_min_width): Move to window.el.
14812 (keys_of_window): Move bindings for delete-other-windows,
14813 split-window, delete-window and enlarge-window to window.el.
14814
14815 * buffer.c: Temporarily extern Qdelete_window.
14816 (Fbury_buffer): Temporarily call Qdelete_window instead of
14817 Fdelete_window (Fbury_buffer will move to window.el soon).
14818
14819 * frame.c (set_menu_bar_lines_1): Remove code handling
14820 orig_top_line and orig_total_lines.
14821
14822 * dispnew.c (adjust_frame_glyphs_initially): Don't use
14823 set_window_height but set heights directly.
14824 (change_frame_size_1): Use resize_frame_windows.
14825
14826 * xdisp.c (init_xdisp): Don't use set_window_height but set
14827 heights directly.
14828
640c8776
SM
14829 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
14830 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
14831 run_window_configuration_change_hook.
14832
14833 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
14834 instead of change_window_heights and run
14835 run_window_configuration_change_hook.
14836
1a13852e
MR
148372011-06-09 Martin Rudalics <rudalics@gmx.at>
14838
14839 * window.c (replace_window): Rename second argument REPLACEMENT to
14840 NEW. New third argument SETFLAG. Rewrite.
14841 (delete_window, make_dummy_parent): Call replace_window with
14842 third argument 1.
14843 (window_list_1): Move down in code.
14844 (run_window_configuration_change_hook): Move set_buffer part
14845 before select_frame_norecord part in order to unwind correctly.
14846 Rename count1 to count.
14847 (recombine_windows, delete_deletable_window, resize_root_window)
14848 (Fdelete_other_windows_internal)
14849 (Frun_window_configuration_change_hook, make_parent_window)
14850 (resize_window_check, resize_window_apply, Fresize_window_apply)
14851 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
14852 (Fdelete_window_internal, Fresize_mini_window_internal):
14853 New functions.
1a13852e
MR
14854 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
14855
f3d1777e
MR
148562011-06-08 Martin Rudalics <rudalics@gmx.at>
14857
496e208e
MR
14858 * window.h (window): Add some new members to window structure -
14859 normal_lines, normal_cols, new_total, new_normal, clone_number,
14860 splits, nest, prev_buffers, next_buffers.
14861 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 14862 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 14863
f3d1777e
MR
14864 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
14865 Remove.
496e208e
MR
14866 (make_dummy_parent): Set new members of windows structure.
14867 (make_window): Move down in code. Handle new members of window
14868 structure.
14869 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
14870 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
14871 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
14872 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
14873 (Fset_window_next_buffers, Fset_window_clone_number):
14874 New functions.
496e208e
MR
14875 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
14876 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
14877 Doc-string fixes.
14878 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
14879 Argument WINDOW can be now internal window too.
14880 (Fwindow_use_time): Move up in code.
14881 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
14882 Rewrite doc-string.
14883 (Fset_window_configuration, saved_window)
14884 (Fcurrent_window_configuration, save_window_save): Handle new
14885 members of window structure.
b9e809c2
MR
14886 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
14887 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
14888 (syms_of_window): New Lisp objects Qrecord_window_buffer,
14889 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
14890 Qget_mru_window, Qresize_root_window,
14891 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
14892 Qauto_buffer_name; staticpro them.
f3d1777e 14893
abde8f8c
MR
148942011-06-07 Martin Rudalics <rudalics@gmx.at>
14895
14896 * window.c (Fwindow_total_size, Fwindow_left_column)
14897 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
14898 (Fwindow_list_1): New functions.
14899 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
14900 (Fwindow_width, Fscroll_left, Fscroll_right):
14901 Use window_body_cols instead of window_box_text_cols.
14902 (delete_window, Fset_window_configuration):
14903 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
14904 (delete_all_subwindows): Take a window as argument and not a
14905 structure. Rewrite.
190b47e6
MR
14906 (window_loop): Remove handling of GET_LRU_WINDOW and
14907 GET_LARGEST_WINDOW.
14908 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
14909
14910 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
14911 window_box_text_cols. delete_all_subwindows now takes a
14912 Lisp_Object as argument.
abde8f8c 14913
640c8776
SM
14914 * indent.c (compute_motion, Fcompute_motion):
14915 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14916
fa8a67e6
MR
14917 * frame.c (delete_frame): Call delete_all_subwindows with root
14918 window as argument.
14919
a54e3482
DC
149202011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14921
14922 * fns.c (Fputhash): Document return value.
14923
60002bf5
CY
149242011-06-06 Chong Yidong <cyd@stupidchicken.com>
14925
14926 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14927
0c671da6 149282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14929
b862a52a 14930 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14931
be44ca6c
PE
14932 Check for overflow when converting integer to cons and back.
14933 * charset.c (Fdefine_charset_internal, Fdecode_char):
14934 Use cons_to_unsigned to catch overflow.
14935 (Fencode_char): Use INTEGER_TO_CONS.
14936 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14937 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14938 * data.c (long_to_cons, cons_to_long): Remove.
14939 (cons_to_unsigned, cons_to_signed): New functions.
14940 These signal an error for invalid or out-of-range values.
14941 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14942 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14943 * font.c (Ffont_variation_glyphs):
14944 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14945 * lisp.h: Include <intprops.h>.
14946 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14947 (cons_to_signed, cons_to_unsigned): New decls.
14948 (long_to_cons, cons_to_long): Remove decls.
14949 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14950 (Fprimitive_undo): Use CONS_TO_INTEGER.
14951 * xfns.c (Fx_window_property): Likewise.
14952 * xselect.c: Include <limits.h>.
14953 (x_own_selection, selection_data_to_lisp_data):
14954 Use INTEGER_TO_CONS.
14955 (x_handle_selection_request, x_handle_selection_clear)
14956 (x_get_foreign_selection, Fx_disown_selection_internal)
14957 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14958 (lisp_data_to_selection_data): Use cons_to_unsigned.
14959 (x_fill_property_data): Use cons_to_signed.
14960 Report values out of range.
14961
d1f3d2af
PE
14962 Check for buffer and string overflow more precisely.
14963 * buffer.h (BUF_BYTES_MAX): New macro.
14964 * lisp.h (STRING_BYTES_MAX): New macro.
14965 * alloc.c (Fmake_string):
14966 * character.c (string_escape_byte8):
14967 * coding.c (coding_alloc_by_realloc):
14968 * doprnt.c (doprnt):
14969 * editfns.c (Fformat):
14970 * eval.c (verror):
14971 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14972 since they may not be the same number.
14973 * editfns.c (Finsert_char):
14974 * fileio.c (Finsert_file_contents):
14975 Likewise for BUF_BYTES_MAX.
14976
dd52fcea
PE
14977 * image.c: Use ptrdiff_t, not int, for sizes.
14978 (slurp_file): Switch from int to ptrdiff_t.
14979 All uses changed.
14980 (slurp_file): Check that file size fits in both size_t (for
14981 malloc) and ptrdiff_t (for sanity and safety).
14982
7f9bbdbb
PE
14983 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14984 if b->modtime has its maximal value.
14985
dfe18f82
PE
14986 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14987
84acfcf0
PE
14988 Don't assume time_t can fit into int.
14989 * buffer.h (struct buffer.modtime): Now time_t, not int.
14990 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14991 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14992
ccd9a01a
PE
14993 Minor fixes for signed vs unsigned integers.
14994 * character.h (MAYBE_UNIFY_CHAR):
14995 * charset.c (maybe_unify_char):
14996 * keyboard.c (read_char, reorder_modifiers):
14997 XINT -> XFASTINT, since the integer must be nonnegative.
14998 * ftfont.c (ftfont_spec_pattern):
14999 * keymap.c (access_keymap, silly_event_symbol_error):
15000 XUINT -> XFASTINT, since the integer must be nonnegative.
15001 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
15002 since it makes no difference and we prefer signed.
15003 * keyboard.c (record_char): Use XUINT when all the neighbors do.
15004 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
15005 nonnegative.
15006
d6d100dd
SM
150072011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
15008
15009 * window.h (Fwindow_frame): Declare.
15010
2b6148e4
PE
150112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
15012
15013 * alloc.c: Simplify handling of large-request failures (Bug#8800).
15014 (SPARE_MEMORY): Always define.
15015 (LARGE_REQUEST): Remove.
15016 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
15017
f230ecc9
MR
150182011-06-06 Martin Rudalics <rudalics@gmx.at>
15019
727e958e
MR
15020 * lisp.h: Move EXFUNS for Fframe_root_window,
15021 Fframe_first_window and Fset_frame_selected_window to window.h.
15022
15023 * window.h: Move EXFUNS for Fframe_root_window,
15024 Fframe_first_window and Fset_frame_selected_window here from
15025 lisp.h.
15026
15027 * frame.c (Fwindow_frame, Fframe_first_window)
15028 (Fframe_root_window, Fframe_selected_window)
15029 (Fset_frame_selected_window): Move to window.c.
15030 (Factive_minibuffer_window): Move to minibuf.c.
15031 (Fother_visible_frames_p): New function.
15032
15033 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
15034
f230ecc9
MR
15035 * window.c (decode_window, decode_any_window): Move up in code.
15036 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
15037 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
15038 (Fwindow_buffer): Move up and rewrite doc-string.
15039 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
15040 (Fwindow_prev): New functions.
727e958e
MR
15041 (Fwindow_frame): Move here from frame.c. Accept any window as
15042 argument.
15043 (Fframe_root_window, Fframe_first_window)
15044 (Fframe_selected_window): Move here from frame.c. Accept frame
15045 or arbitrary window as argument. Update doc-strings.
15046 (Fminibuffer_window): Move up in code.
15047 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
15048 (Fset_frame_selected_window): Move here from frame.c.
15049 Marginal rewrite.
727e958e
MR
15050 (Fselected_window, select_window, Fselect_window): Move up in
15051 code. Minor doc-string fixes.
f230ecc9 15052
4d09bcf6
PE
150532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
15054
15055 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
15056 Do not assume that spare memory exists; that assumption is valid
15057 only if SYSTEM_MALLOC.
15058 (LARGE_REQUEST): New macro, so that the issue of large requests
15059 is separated from the issue of spare memory.
15060
810928a2
AS
150612011-06-05 Andreas Schwab <schwab@linux-m68k.org>
15062
172418ad
AS
15063 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
15064 format. (Bug#8806)
15065
43f862f7
AS
15066 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
15067
810928a2
AS
15068 * xfns.c (x_set_scroll_bar_default_width): Move declarations
15069 before statements.
15070
a059fe24
JD
150712011-06-05 Jan Djärv <jan.h.d@swipnet.se>
15072
15073 * gtkutil.c (xg_get_default_scrollbar_width): New function.
15074
15075 * gtkutil.h: Declare xg_get_default_scrollbar_width.
15076
15077 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
15078 min width by calling x_set_scroll_bar_default_width (Bug#8505).
15079
989bf368
JB
150802011-06-05 Juanma Barranquero <lekktu@gmail.com>
15081
15082 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
15083
4b80f674
CY
150842011-06-04 Chong Yidong <cyd@stupidchicken.com>
15085
15086 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
15087 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
15088 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
15089 New error handlers.
4b80f674
CY
15090 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
15091 Obey Vx_select_enable_clipboard_manager. Catch errors in
15092 x_clipboard_manager_save (Bug#8779).
15093 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 15094 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 15095
99a33b77 150962011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
15097
15098 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
15099
99a33b77 151002011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
15101
15102 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
15103 in the current matrix if keep_current_p is non-zero.
15104
8264569d
EZ
151052011-06-04 Eli Zaretskii <eliz@gnu.org>
15106
15107 * bidi.c (bidi_level_of_next_char): Fix last change.
15108
57f97249
EZ
151092011-06-03 Eli Zaretskii <eliz@gnu.org>
15110
fec2107c 15111 Support bidi reordering of text covered by display properties.
57f97249 15112
fec2107c
EZ
15113 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
15114 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
15115 (bidi_cache_search, bidi_cache_iterator_state)
15116 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
15117 (bidi_level_of_next_char, bidi_move_to_visually_next):
15118 Support character positions inside a run of characters covered by a
fec2107c
EZ
15119 display string.
15120 (bidi_paragraph_init, bidi_resolve_explicit_1)
15121 (bidi_level_of_next_char): Call bidi_fetch_char and
15122 bidi_fetch_char_advance instead of FETCH_CHAR and
15123 FETCH_CHAR_ADVANCE.
15124 (bidi_init_it): Initialize new members.
15125 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
15126 definitions.
15127 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
15128 instead of using explicit *_CHAR codes.
d6d100dd
SM
15129 (bidi_resolve_explicit, bidi_resolve_weak):
15130 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
15131 bidirectional text is supported only in multibyte buffers.
15132 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
15133 it to initialize the frame_window_p member of struct bidi_it.
15134 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
15135 (bidi_resolve_explicit, bidi_resolve_weak)
15136 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
15137 bidi_it->nchars is non-positive.
15138 (bidi_level_of_next_char): Don't try to lookup the cache for the
15139 next/previous character if nothing is cached there yet, or if we
15140 were just reseat()'ed to a new position.
c40e2fb2 15141
0e14fe90
EZ
15142 * xdisp.c (set_cursor_from_row): Set start and stop points
15143 according to the row's direction when priming the loop that looks
15144 for the glyph on which to display cursor.
15145 (single_display_spec_intangible_p): Function deleted.
15146 (display_prop_intangible_p): Reimplement to call
15147 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
15148 Accept 3 additional arguments needed by handle_display_spec.
15149 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
15150 values: lists, `(when COND...)' forms, etc.
15151 (single_display_spec_string_p): Support property values that are
15152 lists with the argument STRING its top-level element.
15153 (display_prop_string_p): Fix the condition for processing a
15154 property that is a list to be consistent with handle_display_spec.
fec2107c 15155 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
15156 last portion of handle_display_prop.
15157 (compute_display_string_pos): Accept additional argument
15158 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
15159 value of a `display' property is a "replacing spec".
15160 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
15161 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
15162 the display property, but just return a value indicating whether
15163 the display property will replace the characters it covers.
15164 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
15165 frame_window_p members of struct bidi_it.
d6d100dd
SM
15166 (compute_display_string_pos, compute_display_string_end):
15167 New functions.
fec2107c
EZ
15168 (push_it): Accept second argument POSITION, where pop_it should
15169 jump to continue iteration.
15170 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 15171
fec2107c
EZ
15172 * keyboard.c (adjust_point_for_property): Adjust the call to
15173 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
15174
15175 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
15176 (bidi_init_it): Update prototypes.
15177 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
15178 (compute_display_string_pos, compute_display_string_end):
15179 Declare prototypes.
fec2107c
EZ
15180 (struct bidi_it): New members nchars and disp_pos. ch_len is now
15181 EMACS_INT.
fc6f18ce 15182
40087514 151832011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 15184
57f53182
PE
15185 Malloc failure behavior now depends on size of allocation.
15186 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
15187 * lisp.h: Change signatures accordingly.
15188 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
15189 All callers changed. (Bug#8762)
15190
15191 * gnutls.c: Use Emacs's memory allocators.
15192 Without this change, the gnutls library would invoke malloc etc.
15193 directly, which causes problems on non-SYNC_INPUT hosts, and which
15194 runs afoul of improving memory_full behavior. (Bug#8761)
15195 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
15196 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
15197 xfree instead of the default malloc, realloc, free.
15198 (Fgnutls_boot): No need to check for memory allocation failure,
15199 since xmalloc does that for us.
15200
ac32cd99 15201 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
15202 * category.c (hash_get_category_set):
15203 * ccl.c (ccl_driver):
15204 * charset.c (Fdefine_charset_internal):
15205 * charset.h (struct charset.hash_index):
15206 * composite.c (get_composition_id, gstring_lookup_cache)
15207 (composition_gstring_put_cache):
15208 * composite.h (struct composition.hash_index):
15209 * dispextern.h (struct image.hash):
15210 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
15211 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
15212 (hashfn_equal, hashfn_user_defined, make_hash_table)
15213 (maybe_resize_hash_table, hash_lookup, hash_put)
15214 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
15215 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
15216 (Fsxhash, Fgethash, Fputhash, Fmaphash):
15217 * image.c (make_image, search_image_cache, lookup_image)
15218 (xpm_put_color_table_h):
15219 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 15220 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 15221 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 15222 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
15223 * alloc.c (allocate_vectorlike):
15224 Check for overflow in vector size calculations.
15225 * ccl.c (ccl_driver):
15226 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
15227 * fns.c, image.c: Remove unnecessary static decls that would otherwise
15228 need to be updated by these changes.
40087514
PE
15229 * fns.c (make_hash_table, maybe_resize_hash_table):
15230 Check for integer overflow with large hash tables.
0de4bb68
PE
15231 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
15232 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
15233 (SXHASH_REDUCE): New macro.
15234 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
15235 Use it instead of discarding useful hash info with large hash values.
15236 (sxhash_float): New function.
15237 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
15238 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
15239 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
15240 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
15241 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
15242 Adjust signatures to match updated version of code.
15243 (consing_since_gc): Now EMACS_INT, since a single hash table can
15244 use more than INT_MAX bytes.
15245
698d32e2
DN
152462011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
15247
15248 Make it possible to build with GCC-4.6+ -O2 -flto.
15249
15250 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
15251
fd6fa53f
SM
152522011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
15253
15254 * minibuf.c (get_minibuffer, read_minibuf_unwind):
15255 Call minibuffer-inactive-mode.
15256
864db017
JB
152572011-05-31 Juanma Barranquero <lekktu@gmail.com>
15258
15259 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
15260 Update dependencies.
15261
2ad0baf4
DN
152622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15263
15264 * data.c (init_data): Remove code for UTS, this system is not
15265 supported anymore.
15266
4fcc2638
DN
152672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15268
15269 Don't force ./temacs to start in terminal mode.
15270
15271 * frame.c (make_initial_frame): Initialize faces in all cases, not
15272 only when CANNOT_DUMP is defined.
15273 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
15274
c56e0fd5
DN
152752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15276
15277 * dispnew.c (add_window_display_history): Use const for the string
15278 pointer. Remove declaration, not needed.
15279
333d54da 152802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 15281
55d4c1b2 15282 Use 'inline', not 'INLINE'.
333d54da 15283 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
15284 * alloc.c, fontset.c (INLINE): Remove.
15285 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
15286 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
15287 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
15288 * gmalloc.c (register_heapinfo): Use inline unconditionally.
15289 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
15290
738db178
DN
152912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
15292
15293 Make it possible to run ./temacs.
15294
15295 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
15296 syms_of_callproc does the same thing. Remove test for
15297 "initialized", do it in the caller.
15298 * emacs.c (main): Avoid calling set_initial_environment when dumping.
15299
620c53a6
SM
153002011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
15301
15302 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
15303 (read_minibuf): Use get_minibuffer.
15304 (syms_of_minibuf): Use DEFSYM.
15305 (Qmetadata): New var.
15306 * data.c (Qbuffer): Don't make it static.
15307 (syms_of_data): Use DEFSYM.
15308
e003a292
PE
153092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
15310
15311 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
15312 (CCL_CODE_MIN): New macro.
15313
ed008a6d
PE
153142011-05-30 Paul Eggert <eggert@cs.ucla.edu>
15315
3687c2ef
PE
15316 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
15317
ed008a6d
PE
15318 * eval.c (Qdebug): Now static.
15319 * lisp.h (Qdebug): Remove decl. This reverts a part of the
15320 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
15321 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
15322
d66c4c7c
CY
153232011-05-29 Chong Yidong <cyd@stupidchicken.com>
15324
15325 * image.c: Various fixes to ImageMagick code comments.
15326 (Fimagemagick_types): Doc fix.
15327
5fbc2025
PE
153282011-05-29 Paul Eggert <eggert@cs.ucla.edu>
15329
0196f88a
PE
15330 Minor fixes prompted by GCC 4.6.0 warnings.
15331
15332 * xselect.c (converted_selections, conversion_fail_tag): Now static.
15333
5fbc2025
PE
15334 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
15335 (x_clipboard_manager_save_all): Move extern decl to ...
15336 * xterm.h: ... here, so that it can be checked for consistency.
15337
1dd3c2d9
CY
153382011-05-29 Chong Yidong <cyd@stupidchicken.com>
15339
15340 * xselect.c (x_clipboard_manager_save_frame)
15341 (x_clipboard_manager_save_all): New functions.
15342 (Fx_clipboard_manager_save): Lisp function deleted.
15343
15344 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
15345 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
15346
15347 * xterm.h: Update prototype.
15348
5ba6571d
WX
153492011-05-28 William Xu <william.xwl@gmail.com>
15350
15351 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
15352 exiting (Bug#8239).
15353
3eaff834
JM
153542011-05-28 Jim Meyering <meyering@redhat.com>
15355
e1900994 15356 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
15357 * fns.c (to_uchar): Define.
15358 (crypto_hash_function): Use it to convert some newly-signed
15359 variables to unsigned, to avoid sign-extension bugs. For example,
15360 without this change, (md5 "truc") would evaluate to
15361 45723a2aff78ff4fff7fff1114760e62 rather than the expected
15362 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 15363 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 15364
0f6990a7
PE
153652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15366
15367 Integer overflow fixes.
c8a9ca5a 15368
08686060
PE
15369 * dbusbind.c: Serial number integer overflow fixes.
15370 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
15371 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
15372 to hold a serial number that is too large for a fixnum.
15373 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15374 Check for serial numbers out of range. Decode any serial number
59568bf0 15375 that was so large that it became a float. (Bug#8722)
08686060 15376
2d1fc3c7
PE
15377 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
15378 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15379 Use XFASTINT rather than XUINT when numbers are nonnegative.
15380 (xd_append_arg, Fdbus_method_return_internal):
15381 (Fdbus_method_error_internal): Likewise. Also, for unsigned
15382 arguments, check that Lisp number is nonnegative, rather than
59568bf0 15383 silently wrapping negative numbers around. (Bug#8722)
30217ff0 15384 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 15385 (Bug#8722)
2d1fc3c7 15386
c8a9ca5a
PE
15387 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
15388
519e1d69
PE
15389 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
15390
6df6ae42 15391 ccl: Add integer overflow checks.
30569699
PE
15392 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
15393 (IN_INT_RANGE): New macros.
15394 (ccl_driver): Use them to check for integer overflow when
15395 decoding a CCL program. Many of the new checks are whether XINT (x)
15396 fits in int; it doesn't always, on 64-bit hosts. The new version
15397 doesn't catch all possible integer overflows, but it's an
847044ea 15398 improvement. (Bug#8719)
30569699 15399
c11285dc
PE
15400 * alloc.c (make_event_array): Use XINT, not XUINT.
15401 There's no need for unsigned here.
15402
fdccd48e
PE
15403 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
15404 This follows up to the 2011-05-06 change that substituted uintptr_t
15405 for EMACS_INT. This case wasn't caught back then.
15406
37910ab2
PE
15407 Rework Fformat to avoid integer overflow issues.
15408 * editfns.c: Include <float.h> unconditionally, as it's everywhere
15409 now (part of C89). Include <verify.h>.
15410 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
15411 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
15412 (Fformat): Avoid the prepass trying to compute sizes; it was only
15413 approximate and thus did not catch overflow reliably. Instead, walk
15414 through the format just once, formatting and computing sizes as we go,
15415 checking for integer overflow at every step, and allocating a larger
15416 buffer as needed. Keep track separately whether the format is
15417 multibyte. Keep only the most-recently calculated precision, rather
15418 than them all. Record whether each argument has been converted to
15419 string. Use EMACS_INT, not int, for byte and char and arg counts.
15420 Support field widths and precisions larger than INT_MAX. Avoid
15421 sprintf's undefined behavior with conversion specifications such as %#d
15422 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
15423 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
15424 formatting out-of-range floating point numbers with int
9173deec 15425 formats. (Bug#8668)
37910ab2 15426
2e6578fb
PE
15427 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
15428
0ae6bdee
PE
15429 * data.c: Avoid integer truncation in expressions involving floats.
15430 * data.c: Include <intprops.h>.
15431 (arith_driver): When there's an integer overflow in an expression
15432 involving floating point, convert the integers to floating point
15433 so that the resulting value does not suffer from catastrophic
15434 integer truncation. For example, on a 64-bit host (* 4
15435 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
15436 Do not rely on undefined behavior after integer overflow.
15437
de883a70
PE
15438 merge count_size_as_multibyte, parse_str_to_multibyte
15439 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 15440 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
15441 Check for integer overflow.
15442 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
15443 since it's now a duplicate of the other. This is more of
15444 a character than a buffer op, so better that it's in character.c.
15445 * fns.c, print.c: Adjust to above changes.
15446
2ff916cb
PE
154472011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
15448
15449 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
15450
f1b54466
PE
154512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
15452
fb1ac845
PE
15453 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15454 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
15455 (x_clipboard_manager_save): Now static.
15456 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
15457
f1b54466
PE
15458 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
15459 (crypto_hash_function): Now static.
15460 Fix pointer signedness problems. Avoid unnecessary initializations.
15461
a9f737ee
CY
154622011-05-27 Chong Yidong <cyd@stupidchicken.com>
15463
15464 * termhooks.h (Vselection_alist): Make it terminal-local.
15465
15466 * terminal.c (create_terminal): Initialize it.
15467
15468 * xselect.c: Support for clipboard managers.
15469 (Vselection_alist): Move to termhooks.h as terminal-local var.
15470 (LOCAL_SELECTION): New macro.
15471 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
15472 (symbol_to_x_atom): Remove gratuitous arg.
15473 (x_handle_selection_request, lisp_data_to_selection_data)
15474 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
15475 (x_own_selection, x_get_local_selection, x_convert_selection):
15476 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
15477 (some_frame_on_display): Delete unused function.
15478 (Fx_own_selection_internal, Fx_get_selection_internal)
15479 (Fx_disown_selection_internal, Fx_selection_owner_p)
15480 (Fx_selection_exists_p): New optional frame arg.
15481 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
15482 (x_handle_selection_clear): Don't treat other terminals with the
15483 same keyboard specially. Use the terminal-local Vselection_alist.
15484 (x_clear_frame_selections): Use Frun_hook_with_args.
15485
15486 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
15487
15488 * xterm.h: Add support for those atoms.
15489
e067f0c1
CY
154902011-05-26 Chong Yidong <cyd@stupidchicken.com>
15491
15492 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
15493 (converted_selections, conversion_fail_tag): New global variables.
15494 (x_selection_request_lisp_error): Free the above.
15495 (x_get_local_selection): Remove unnecessary code.
15496 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
15497 of converted selections stored in converted_selections.
15498 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
15499 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
15500 (x_convert_selection): New function.
15501 (x_handle_selection_event): Simplify.
15502 (x_get_foreign_selection): Don't ignore incoming requests while
15503 waiting for an answer; this will fail when we implement
15504 SAVE_TARGETS, and seems unnecessary anyway.
15505 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
15506 (Vx_sent_selection_functions): Doc fix.
15507
0f4aebc0
LL
155082011-05-26 Leo Liu <sdl.web@gmail.com>
15509
15510 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
15511
e61124cd
YM
155122011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15513
15514 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
15515
15516 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
15517 for fringe update if it has periodic bitmap.
ac389d0c 15518 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
15519 and fringe_bitmap_periodic_p.
15520
15521 * fringe.c (get_fringe_bitmap_data): New function.
15522 (draw_fringe_bitmap_1, update_window_fringes): Use it.
15523 (update_window_fringes): Record periodicity of fringe bitmap in glyph
15524 row. Mark glyph row for fringe update if periodicity changed.
15525
15526 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
15527 for fringe update unless it has periodic bitmap.
15528
f16d9837
KH
155292011-05-25 Kenichi Handa <handa@m17n.org>
15530
15531 * xdisp.c (get_next_display_element): Set correct it->face_id for
15532 a static composition.
15533
e1b90ef6
LL
155342011-05-24 Leo Liu <sdl.web@gmail.com>
15535
15536 * deps.mk (fns.o):
15537 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
15538
15539 * fns.c (crypto_hash_function, Fsha1): New function.
15540 (Fmd5): Use crypto_hash_function.
15541 (syms_of_fns): Add Ssha1.
15542
7400048f
PE
155432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15544
15545 * gnutls.c: Remove unused macros.
15546 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
15547 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
15548 Remove macros that are defined and never used.
15549 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
15550
abb71cf4
CY
155512011-05-22 Chong Yidong <cyd@stupidchicken.com>
15552
15553 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
15554 (Fx_get_selection_internal): Minor cleanup.
15555 (Fx_own_selection_internal): Rename arguments for consistency with
15556 select.el.
15557
6307db39
PE
155582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
15559
15560 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
15561
f3d4e0a4
CY
155622011-05-22 Chong Yidong <cyd@stupidchicken.com>
15563
15564 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
15565
4d8ade89
YM
155662011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
15567
15568 * dispnew.c (scrolling_window): Don't exclude the case that the
15569 last enabled row in the desired matrix touches the bottom boundary.
15570
32078c8d
GM
155712011-05-21 Glenn Morris <rgm@gnu.org>
15572
15573 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
15574 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
15575 and add some more files.
32078c8d 15576
7285dc67
EZ
155772011-05-20 Eli Zaretskii <eliz@gnu.org>
15578
15579 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
15580 report_file_error introduced by the change from 2011-05-07.
15581
89d1bd22
PE
155822011-05-20 Paul Eggert <eggert@cs.ucla.edu>
15583
15584 * systime.h (Time): Define only if emacs is defined.
15585 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
15586 where the include path doesn't have X11/X.h by default. See
15587 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
15588
cd394be1 155892011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
15590
15591 * composite.c (find_automatic_composition): Fix previous change.
15592
b9704ad9
GM
155932011-05-20 Glenn Morris <rgm@gnu.org>
15594
15595 * lisp.mk: New file, split from Makefile.in.
15596 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
15597 (shortlisp): Remove.
15598 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
15599
4a720484
GM
156002011-05-19 Glenn Morris <rgm@gnu.org>
15601
15602 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
15603 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
15604 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
15605 (lisp): Set the order to that of loadup.el.
15606 (shortlisp): Make it a copy of $lisp.
15607 (SOME_MACHINE_LISP): Remove.
15608 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
15609 Use just $shortlisp, not $SOME_MACHINE_LISP too.
15610
a28d4396
KH
156112011-05-18 Kenichi Handa <handa@m17n.org>
15612
15613 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
15614 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
15615 (find_automatic_composition): Mostly rewrite for efficiency.
15616
a2b1fa8e
JB
156172011-05-18 Juanma Barranquero <lekktu@gmail.com>
15618
15619 * makefile.w32-in: Update dependencies.
15620
8e1f5610
CS
156212011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
15622
15623 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 15624 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 15625
7025ee00 156262011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 15627
cdfa6eab
PE
15628 Fix some integer overflow issues, such as string length overflow.
15629
06d6db33
PE
15630 * insdel.c (count_size_as_multibyte): Check for string overflow.
15631
2b4560a8
PE
15632 * character.c (lisp_string_width): Check for string overflow.
15633 Use EMACS_INT, not int, for string indexes and lengths; in
15634 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
15635 the resulting string length overflows an EMACS_INT; instead,
15636 report a string overflow if no precision given. When checking for
15637 precision exhaustion, use a check that cannot possibly have
15638 integer overflow. (Bug#8675)
15639 * character.h (lisp_string_width): Adjust to new signature.
15640
cb93f9be
PE
15641 * alloc.c (string_overflow): New function.
15642 (Fmake_string): Use it. This doesn't change behavior, but saves
15643 a few bytes and will simplify future changes.
15644 * character.c (string_escape_byte8): Likewise.
15645 * lisp.h (string_overflow): New decl.
15646
1a1f3366
PE
15647 Fixups, following up to the user-interface timestamp change.
15648 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
15649 for UI timestamps, instead of unsigned long.
9fbd6841
PE
15650 * msdos.c (mouse_get_pos): Likewise.
15651 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
15652 * w32gui.h (Time): Define by including "systime.h" rather than by
15653 declaring it ourselves. (Bug#8664)
15654
d4e3e4d3
PE
15655 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
15656 * image.c (clear_image_cache): Likewise.
15657
f6a24d19
PE
15658 * term.c (term_mouse_position): Don't assume time_t wraparound.
15659
08dc5ae6
PE
15660 Be more systematic about user-interface timestamps.
15661 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
15662 and sometimes 'EMACS_UINT', to represent these timestamps.
15663 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
15664 This makes the code easier to follow, and makes it easier to catch
15665 integer overflow bugs such as Bug#8664.
15666 * frame.c (Fmouse_position, Fmouse_pixel_position):
15667 Use Time, not unsigned long, for user-interface timestamps.
15668 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
15669 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
15670 * keyboard.h (last_event_timestamp): Likewise.
15671 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
15672 * menu.h (xmenu_show): Likewise.
15673 * term.c (term_mouse_position): Likewise.
15674 * termhooks.h (struct input_event.timestamp): Likewise.
15675 (struct terminal.mouse_position_hook): Likewise.
15676 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
15677 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
15678 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
15679 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
15680 what it was before.
15681 * menu.h, termhooks.h: Include "systime.h", for Time.
15682
8e55734a
PE
15683 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
15684 Don't assume that the difference between two unsigned long values
15685 can fit into an integer. At this point, we know button_down_time
15686 <= event->timestamp, so the difference must be nonnegative, so
15687 there's no need to cast the result if double-click-time is
15688 nonnegative, as it should be; check that it's nonnegative, just in
15689 case. This bug is triggered when events are more than 2**31 ms
86db42d2 15690 apart (about 25 days). (Bug#8664)
8e55734a 15691
841f1b75 15692 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 15693 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 15694
3e26f69c
PE
15695 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
15696 that always fit in int. Use a sentinel instead of a counter, to
15697 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
15698 * frame.h (struct frame): Use int for menu_bar_items_used
15699 instead of EMACS_INT, since it always fits in int.
3e26f69c 15700
5cc152c0
PE
15701 * menu.c (grow_menu_items): Check for int overflow.
15702
d89eb65e
PE
15703 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
15704
5235bd3e
PE
15705 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
15706 Before, the code was not consistent. These values cannot exceed
15707 2**31 - 1 so there's no need to make them unsigned.
15708 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
15709 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
15710 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
15711 as modifiers.
15712 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
15713
bc827e23
PE
15714 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
15715 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
15716 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
15717 presumably because the widths might not match.
15718
78eb494e
PE
15719 * window.c (size_window): Avoid needless test at loop start.
15720
04f2d78b
CB
157212011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
15722
15723 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
15724
d2fc7e3d 157252011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
15726
15727 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
15728
d2fc7e3d 157292011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
15730
15731 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
15732 `width' to `bar_area_x' and `bar_area_width', respectively.
15733 (x_scroll_run): Take account of fringe background extension.
15734
04f2d78b
CB
15735 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
15736 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
15737 `bar_area_width', respectively.
15738 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
15739 background extension.
15740
79b70037
GM
157412011-05-10 Jim Meyering <meyering@redhat.com>
15742
15743 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
15744
2f142cc5
JB
157452011-05-10 Juanma Barranquero <lekktu@gmail.com>
15746
15747 * image.c (Finit_image_library): Return t for built-in image types,
15748 like pbm and xbm. (Bug#8640)
15749
57679c86
AS
157502011-05-09 Andreas Schwab <schwab@linux-m68k.org>
15751
15752 * w32menu.c (set_frame_menubar): Fix submenu allocation.
15753
888c9e86
EZ
157542011-05-07 Eli Zaretskii <eliz@gnu.org>
15755
b0512a1d
EZ
15756 * w32console.c (Fset_screen_color): Doc fix.
15757 (Fget_screen_color): New function.
15758 (syms_of_ntterm): Defsubr it.
15759
7285dc67
EZ
15760 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
15761 unlink the temporary file if Fcall_process didn't create it in the
15762 first place.
15763 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
15764 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
15765 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
15766 cue to call_process_cleanup not to close that handle.
15767
4d3fcc8e
BK
157682011-05-07 Ben Key <bkey76@gmail.com>
15769
15770 * makefile.w32-in: The bootstrap-temacs rule now makes use of
15771 one of two shell specific rules, either bootstrap-temacs-CMD or
15772 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
15773 to the previous implementation of the bootstrap-temacs rule.
15774 The bootstrap-temacs-CMD rule is similar to the previous
15775 implementation of the bootstrap-temacs rule except that it
15776 makes use of the ESC_CFLAGS variable instead of the CFLAGS
15777 variable.
15778
15779 These changes, along with some changes to nt/configure.bat,
15780 nt/gmake.defs, and nt/nmake.defs, are required to extend my
15781 earlier fix to add support for --cflags and --ldflags options
15782 that include quotes so that it works whether make uses cmd or
15783 sh as the shell.
15784
b4289b64
MA
157852011-05-06 Michael Albinus <michael.albinus@gmx.de>
15786
15787 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
15788 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
15789 is a constant.
15790 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
15791 a string. Handle both cases.
15792 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
15793 (Fdbus_register_method): Use Qinvalid_function.
15794
af4c0e28
JB
157952011-05-06 Juanma Barranquero <lekktu@gmail.com>
15796
15797 * makefile.w32-in: Update dependencies.
15798 (LISP_H): Add inttypes.h and stdin.h.
15799 (PROCESS_H): Add unistd.h.
15800
c51453d9
EZ
158012011-05-06 Eli Zaretskii <eliz@gnu.org>
15802
15803 * lread.c: Include limits.h (fixes the MS-Windows build broken by
15804 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
15805
8ff0ac3c 158062011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 15807
4c4b566b
PE
15808 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
15809
aab2b9b5
PE
15810 * term.c (vfatal): Remove stray call to va_end.
15811 It's not needed and the C Standard doesn't allow it here anyway.
15812
c378da0b
PE
15813 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
15814 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
15815
288b08c7
PE
15816 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
15817 bytes.
15818
e3601888
PE
15819 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
15820
db6c0e74
PE
15821 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
15822
dd5963ea
PE
15823 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
15824
88c9450f
PE
15825 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
15826
2f9442b8
PE
15827 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
15828
c032b5f8
PE
15829 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
15830 * charset.c (Fdefine_charset_internal): Don't initialize
15831 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 15832 32-bit int (Bug#8600).
a108c10b
PE
15833
15834 * lread.c (read_integer): Be more consistent with string-to-number.
15835 Use string_to_number to do the actual conversion; this avoids
15836 rounding errors and fixes some other screwups. Without this fix,
15837 for example, #x1fffffffffffffff was misread as -2305843009213693952.
15838 (digit_to_number): Move earlier, for benefit of read_integer.
15839 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 15840 not a digit in any supported base. (Bug#8602)
a108c10b 15841
ad5f9eea
PE
15842 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
15843
aec1708a
PE
15844 * dispnew.c (scrolling_window): Return 1 if we scrolled,
15845 to match comment at start of function. This also removes a
15846 GCC warning about overflow in a 32+64-bit port.
15847
47be4ab5
PE
15848 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
15849
371cac43
PE
15850 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
15851 Reported by Stefan Monnier in
15852 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
15853 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15854 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 15855
d01a7826
PE
15856 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
15857 (EMACS_UINTPTR): Likewise, with uintptr_t.
15858
7fd47d5c
PE
15859 * lisp.h: Prefer 64-bit EMACS_INT if available.
15860 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
15861 on 32-bit hosts that have 64-bit int, so that they can access
15862 large files.
122b0c86
PE
15863 However, temporarily disable this change unless the temporary
15864 symbol WIDE_EMACS_INT is defined.
7fd47d5c 15865
8727937b
PE
15866 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
15867
8ac068ac
PE
15868 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
15869 This removes an assumption that EMACS_INT and long are the same
15870 width as pointers. The assumption is true for Emacs porting targets
15871 now, but we want to make other targets possible.
15872 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15873 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
15874 In the rest of the code, change types of integers that hold casted
15875 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
15876 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
15877 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
15878 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
15879 No need to cast type when ORing.
15880 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
15881 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
15882 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
15883 assume EMACS_INT is the same width as char *.
15884 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
15885 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
15886 Remove no-longer-needed casts.
15887 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
15888 (xg_tool_bar_help_callback, xg_make_tool_item):
15889 Use EMACS_INTPTR to hold an integer
15890 that will be cast to void *; this can avoid a GCC warning
15891 if EMACS_INT is not the same width as void *.
15892 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
15893 * xdisp.c (display_echo_area_1, resize_mini_window_1):
15894 (current_message_1, set_message_1):
15895 Use a local to convert to proper width without a cast.
15896 * xmenu.c (dialog_selection_callback): Likewise.
15897
ede49d71
PE
15898 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
15899 Also, don't assume VALBITS / RAND_BITS is less than 5,
15900 and don't rely on undefined behavior when shifting a 1 left into
15901 the sign bit.
15902 * lisp.h (get_random): Change signature to match.
15903
2f30ecd0
PE
15904 * lread.c (hash_string): Use size_t, not int, for hash computation.
15905 Normally we prefer signed values; but hashing is special, because
15906 it's better to use unsigned division on hash table sizes so that
15907 the remainder is nonnegative. Also, size_t is the natural width
15908 for hashing into memory. The previous code used 'int', which doesn't
15909 retain enough info to hash well into very large tables.
15910 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
15911
2a866e7b
PE
15912 * dbusbind.c: Don't possibly lose pointer info when converting.
15913 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15914 Use XPNTR rather than XHASH, so that the high-order bits of
15915 the pointer aren't lost when converting through void *.
15916
51639eac
PE
15917 * eval.c (Fautoload): Don't double-shift a pointer.
15918
92394119
PE
15919 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15920
dbdb9a7c
JB
159212011-05-06 Juanma Barranquero <lekktu@gmail.com>
15922
15923 * gnutls.c (DEF_GNUTLS_FN):
15924 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15925
db7a0b4f
AS
159262011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15927
15928 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15929 marker. (Bug#8610)
15930
cd394be1 159312011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15932
15933 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15934 New version that can reserve upto 2GB of heap space.
15935
f7ff1b0f 159362011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15937
15938 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15939
639c109b
TZ
159402011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15941
15942 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15943 `gnutls_certificate_set_x509_key_file'.
15944
d2127135
JB
159452011-05-05 Juanma Barranquero <lekktu@gmail.com>
15946
15947 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15948 Update dependencies.
15949
e968f4f3
JB
159502011-05-04 Juanma Barranquero <lekktu@gmail.com>
15951
15952 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15953 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15954 Remove unused parameter `fildes'.
15955 * process.c (read_process_output, send_process): Don't pass it.
15956
84d358f0
JB
159572011-05-04 Juanma Barranquero <lekktu@gmail.com>
15958
15959 Fix previous change: the library cache is defined in w32.c.
15960 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15961 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15962
0898ca10
JB
159632011-05-04 Juanma Barranquero <lekktu@gmail.com>
15964
15965 Implement dynamic loading of GnuTLS on Windows.
15966
15967 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15968 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15969 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15970 Declare.
15971
15972 * gnutls.c (Qgnutls_dll): Define.
15973 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15974 (gnutls_*): Declare function pointers.
15975 (init_gnutls_functions): New function to initialize function pointers.
15976 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15977 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15978 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15979 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15980 (emacs_gnutls_write, emacs_gnutls_read)
15981 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15982 (Fgnutls_available_p): New function.
15983 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15984 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15985 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15986
15987 * image.c: Include w32.h.
15988 (Vimage_type_cache): Delete.
15989 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15990 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15991 (w32_delayed_load): Move to w32.c.
15992
15993 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15994
15995 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15996 (w32_delayed_load): Move from image.c. When loading a library, record
15997 its filename in the :loaded-from property of the library id.
15998 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15999 Initialize and staticpro them.
16000 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
16001
16002 * process.c: Include lisp.h before w32.h, not after.
16003 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
16004 instead of gnutls_record_check_pending.
16005
16006 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
16007
ff4de4aa
TZ
160082011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
16009
16010 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
16011 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
16012 as passed in.
16013
abe95abb
JD
160142011-05-03 Jan Djärv <jan.h.d@swipnet.se>
16015
16016 * xterm.c (x_set_frame_alpha): Do not set property on anything
16017 else than FRAME_X_OUTER_WINDOW (Bug#8608).
16018
e16e55d4
JB
160192011-05-02 Juanma Barranquero <lekktu@gmail.com>
16020
16021 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
16022
bafcf6a5
JB
160232011-05-02 Juanma Barranquero <lekktu@gmail.com>
16024
16025 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
16026 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
16027 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
16028 (gnutls_global_initialized, Qgnutls_bootprop_priority)
16029 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
16030 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
16031 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
16032 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
16033 (Qgnutls_bootprop_callbacks_verify): Make static.
16034
e7a6747f
AS
160352011-05-01 Andreas Schwab <schwab@linux-m68k.org>
16036
19ed11ba
AS
16037 * callproc.c: Indentation fixup.
16038
e7a6747f 16039 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
16040 (wait_for_termination, interruptible_wait_for_termination):
16041 Move after wait_for_termination_1.
e7a6747f 16042
1ef14cb4
LMI
160432011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
16044
16045 * sysdep.c (interruptible_wait_for_termination): New function
16046 which is like wait_for_termination, but allows keyboard
16047 interruptions.
16048
16049 * callproc.c (Fcall_process): Add (:file "file") as an option for
16050 the STDOUT buffer.
16051 (Fcall_process_region): Ditto.
16052
330d880c
EZ
160532011-04-30 Eli Zaretskii <eliz@gnu.org>
16054
8db90b73
EZ
16055 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
16056 rather than `XVECTOR (FOO)->size'.
16057
330d880c
EZ
16058 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
16059 inttypes.h, as a gnulib replacement is used if it not available in
16060 system headers.
16061
15cbd324
EZ
160622011-04-21 Eli Zaretskii <eliz@gnu.org>
16063
16064 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
16065 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
16066 of MOST_POSITIVE_FIXNUM. (Bug#8528)
16067
16068 * coding.c (coding_alloc_by_realloc): Error out if destination
16069 will grow beyond MOST_POSITIVE_FIXNUM.
16070 (decode_coding_emacs_mule): Abort if there isn't enough place in
16071 charbuf for the composition carryover bytes. Reserve an extra
16072 space for up to 2 characters produced in a loop.
16073 (decode_coding_iso_2022): Abort if there isn't enough place in
16074 charbuf for the composition carryover bytes.
16075
160762011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 16077
ae940cca
EZ
16078 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
16079 aborting when %lld or %lll format is passed.
16080 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
16081 %llo or %llx format is passed. (Bug#8545)
16082
03ab8921
EZ
16083 * window.c (window_scroll_line_based): Use a marker instead of
16084 simple variables to record original value of point. (Bug#7952)
16085
afda1437
EZ
16086 * doprnt.c (doprnt): Fix the case where a multibyte sequence
16087 produced by %s or %c overflows available buffer space. (Bug#8545)
16088
f76dee0c
PE
160892011-04-28 Paul Eggert <eggert@cs.ucla.edu>
16090
16091 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 16092 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 16093
fdc5744d
JB
160942011-04-28 Juanma Barranquero <lekktu@gmail.com>
16095
16096 * w32.c (init_environment): Warn about defaulting HOME to C:\.
16097
638f053a
JB
160982011-04-28 Juanma Barranquero <lekktu@gmail.com>
16099
16100 * keyboard.c (Qdelayed_warnings_hook): Define.
16101 (command_loop_1): Run `delayed-warnings-hook'
16102 if Vdelayed_warnings_list is non-nil.
16103 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
16104 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
16105
d178f871
EZ
161062011-04-28 Eli Zaretskii <eliz@gnu.org>
16107
16108 * doprnt.c (doprnt): Don't return value smaller than the buffer
16109 size if the message was truncated. (Bug#8545).
16110
b124fd93
JB
161112011-04-28 Juanma Barranquero <lekktu@gmail.com>
16112
16113 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
16114 (Fx_window_property): #if-0 the whole functions, not just the bodies.
16115
e810457d
PE
161162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
16117
16118 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
16119
ea51cceb
JB
161202011-04-27 Juanma Barranquero <lekktu@gmail.com>
16121
16122 * makefile.w32-in: Update dependencies.
16123
94dcfacf
EZ
161242011-04-27 Eli Zaretskii <eliz@gnu.org>
16125
16126 Improve `doprnt' and its usage. (Bug#8545)
16127 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
16128 `format_end'. Remove support for %l as a conversion specifier.
16129 Don't use xrealloc. Improve diagnostics when the %l size modifier
16130 is used. Update the commentary.
16131
16132 * eval.c (verror): Simplify calculation of size_t.
16133
16134 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
16135 messages.
16136
f61f41d7
PE
161372011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
16138
16139 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
16140 change.
16141
96fb4434
PE
161422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
16143
16144 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
16145 This makes this file independent of the recent pseudovector change.
16146
671875da 161472011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 16148
69e9b5a3
PE
16149 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
16150
b5f869a7 16151 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 16152 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 16153 Remove unused local.
c8926152 16154 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 16155
841a1577 16156 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
16157 GCC 4.6.0 optimizes based on type-based alias analysis.
16158 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
16159 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
16160 != &v->size, and therefore "v->size = 1; b->size = 2; return
16161 v->size;" must therefore return 1. This assumption is incorrect
16162 for Emacs, since it type-puns struct Lisp_Vector * with many other
16163 types. To fix this problem, this patch adds a new type struct
f904488f 16164 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
16165 and pseudovectors, and helps optimizing compilers not get fooled
16166 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
16167 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
16168 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
16169 the size member.
eab3844f
PE
16170 (XSETPVECTYPE): Rewrite in terms of new macro.
16171 (XSETPVECTYPESIZE): New macro, specifying both type and size.
16172 This is a bit clearer, and further avoids the possibility of
16173 undesirable aliasing.
16174 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 16175 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
16176 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
16177 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
16178 (ASIZE): Now uses header.size rather than size.
16179 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
16180 to avoid the hassle of writing XVECTOR (foo)->header.size.
16181 (struct vectorlike_header): New type.
eab3844f
PE
16182 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
16183 object, to help avoid aliasing.
16184 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
16185 (SUBRP): Likewise, since Lisp_Subr is a special case.
16186 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
16187 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
16188 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 16189 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
16190 changed to be "header.size" and "header.next".
16191 * buffer.h (struct buffer): Likewise.
16192 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
16193 * frame.h (struct frame): Likewise.
16194 * process.h (struct Lisp_Process): Likewise.
16195 * termhooks.h (struct terminal): Likewise.
16196 * window.c (struct save_window_data, struct saved_window): Likewise.
16197 * window.h (struct window): Likewise.
16198 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
16199 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
16200 * buffer.c (init_buffer_once): Likewise.
16201 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
16202 special case.
16203 * process.c (Fformat_network_address): Use local var for size,
16204 for brevity.
16205
0df1eac5
PE
16206 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
16207
847ab9d1 16208 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
16209 * data.c (atof): Remove decl; no longer used or needed.
16210 (digit_to_number): Move to lread.c.
16211 (Fstring_to_number): Use new string_to_number function, to be
16212 consistent with how the Lisp reader treats infinities and NaNs.
16213 Do not assume that floating-point numbers represent EMACS_INT
16214 without losing information; this is not true on most 64-bit hosts.
16215 Avoid double-rounding errors, by insisting on integers when
16216 parsing non-base-10 numbers, as the documentation specifies.
16217 * lisp.h (string_to_number): New decl, replacing ...
16218 (isfloat_string): Remove.
bc0a5c13 16219 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 16220 (read1): Do not accept +. and -. as integers; this
452f4150
PE
16221 appears to have been a coding error. Similarly, do not accept
16222 strings like +-1e0 as floating point numbers. Do not report
16223 overflow for integer overflows unless the base is not 10 which
16224 means we have no simple and reliable way to continue.
16225 Break out the floating-point parsing into a new
16226 function string_to_number, so that Fstring_to_number parses
16227 floating point numbers consistently with the Lisp reader.
04f2d78b 16228 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
16229 (E_CHAR, EXP_INT): Remove, replacing with ...
16230 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
16231 (string_to_number): New function, replacing isfloat_string.
16232 This function checks for valid syntax and produces the resulting
16233 Lisp float number too. Rework it so that string-to-number
bc0a5c13 16234 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
16235 so that overflow for non-base-10 numbers is reported only when
16236 there's no portable and simple way to convert to floating point.
452f4150 16237
67769ffc
PE
16238 * textprop.c (set_text_properties_1): Rewrite for clarity,
16239 and to avoid GCC warning about integer overflow.
16240
c20db43f
PE
16241 * intervals.h (struct interval): Use EMACS_INT for members
16242 where EMACS_UINT might cause problems. See
16243 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
16244 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
16245 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
16246 All uses changed.
37aa2f85
PE
16247 (offset_intervals): Tell GCC not to worry about length overflow
16248 when negating a negative length.
c20db43f 16249
2538aa2f
PE
16250 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
16251 (overrun_check_free): Likewise.
16252
f2d3008d
PE
16253 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
16254 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
16255 word size.
16256
ec8df744
PE
16257 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
16258 (gnutls_make_error): Rename local to avoid shadowing.
16259 (gnutls_emacs_global_deinit): ifdef out; not used.
16260 (Fgnutls_boot): Use const for pointer to readonly storage.
16261 Comment out unused local. Fix pointer signedness problems.
16262
640ee02d
PE
16263 * lread.c (openp): Don't stuff size_t into an 'int'.
16264 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
16265 about possible signed overflow.
16266
6048fb2a
PE
16267 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
16268 (GDK_KEY_g): Don't define if already defined.
16269 (xg_prepare_tooltip): Avoid pointer signedness problem.
16270 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
16271
fa3c87e1
PE
16272 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
16273 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
16274
2172544b
PE
16275 * xfns.c (Fx_window_property): Simplify a bit,
16276 to make a bit faster and to avoid GCC 4.6.0 warning.
16277 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
16278
9b821a21
PE
16279 * fns.c (internal_equal): Don't assume size_t fits in int.
16280
3c616cfa
PE
16281 * alloc.c (compact_small_strings): Tighten assertion a little.
16282
c2982e87
PE
16283 Replace pEd with more-general pI, and fix some printf arg casts.
16284 * lisp.h (pI): New macro, generalizing old pEd macro to other
16285 conversion specifiers. For example, use "...%"pI"d..." rather
16286 than "...%"pEd"...".
16287 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 16288 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
16289 * alloc.c (check_pure_size): Don't overflow by converting size to int.
16290 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
16291 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
16292 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
16293 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
16294 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
16295 64-bit hosts.
16296 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
16297 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
16298 * print.c (safe_debug_print, print_object): Likewise.
16299 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
16300 to int.
6f04d126
PE
16301 Use pI instead of if-then-else-abort. Use %p to avoid casts,
16302 avoiding the 0 flag, which is not portable.
c2982e87
PE
16303 * process.c (Fmake_network_process): Use pI to avoid cast.
16304 * region-cache.c (pp_cache): Likewise.
16305 * xdisp.c (decode_mode_spec): Likewise.
16306 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
16307 behavior on 64-bit hosts with printf arg.
6f04d126 16308 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
16309 (x_stop_queuing_selection_requests): Likewise.
16310 (x_get_window_property): Don't truncate byte count to an 'int'
16311 when tracing.
0b432f21 16312
5e073ec7
PE
16313 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
16314 here, since it parses constructs like leading '-' and spaces,
16315 which are not wanted; and it overflows with large numbers.
16316 Instead, simply match F[0-9]+, which is what is wanted anyway.
16317
36372bf9
PE
16318 * alloc.c: Remove unportable assumptions about struct layout.
16319 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
16320 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
16321 (allocate_vectorlike, make_pure_vector): Use the new macros,
16322 plus offsetof, to remove unportable assumptions about struct layout.
16323 These assumptions hold on all porting targets that I know of, but
16324 they are not guaranteed, they're easy to remove, and removing them
16325 makes further changes easier.
16326
0b432f21
PE
16327 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
16328 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
16329 (string_overrun_cookie): Now const. Use initializers that
16330 don't formally overflow signed char, to avoid warnings.
000098c1
PE
16331 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
16332 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
16333 (allocate_buffer): Don't assume sizeof (struct buffer) is a
16334 multiple of sizeof (EMACS_INT); it need not be, if
16335 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 16336 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 16337
895009e1
JB
163382011-04-26 Juanma Barranquero <lekktu@gmail.com>
16339
16340 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
16341
6a7a1b0b
TZ
163422011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
16343
16344 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 16345 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
16346 Reported by Paul Eggert <eggert@cs.ucla.edu>.
16347
841a1577 163482011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
16349
16350 * lisp.h (Qdebug): List symbol.
895009e1 16351 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
16352 * keyboard.c (debug-on-event): New variable.
16353 (handle_user_signal): Break into debugger when debug-on-event
16354 matches the current signal symbol.
16355
f2d3ba6f
DN
163562011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
16357
16358 * alloc.c (check_sblock, check_string_bytes)
16359 (check_string_free_list): Convert to standard C.
16360
42ce4c63
TZ
163612011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
16362
16363 * w32.c (emacs_gnutls_push): Fix typo.
16364
825cd63c
EZ
163652011-04-25 Eli Zaretskii <eliz@gnu.org>
16366
fb11d64d
EZ
16367 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
16368 "cast to pointer from integer of different size".
16369
825cd63c
EZ
16370 Improve doprnt and its use in verror. (Bug#8545)
16371 * doprnt.c (doprnt): Document the set of format control sequences
16372 supported by the function. Use SAFE_ALLOCA instead of always
16373 using `alloca'.
16374
16375 * eval.c (verror): Don't limit the buffer size at size_max-1, that
16376 is one byte too soon. Don't use xrealloc; instead xfree and
16377 xmalloc anew.
16378
e061a11b
TZ
163792011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
16380
16381 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
16382 callbacks stage.
16383
16384 * gnutls.c: Renamed global_initialized to
16385 gnutls_global_initialized. Added internals for the
16386 :verify-hostname-error, :verify-error, and :verify-flags
16387 parameters of `gnutls-boot' and documented those parameters in the
16388 docstring. Start callback support.
9173deec
JB
16389 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
16390 unless a fatal error occurred. Call gnutls_alert_send_appropriate
16391 on error. Return error code.
e061a11b
TZ
16392 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
16393 (emacs_gnutls_read): Likewise.
16394 (Fgnutls_boot): Return handshake error code.
16395 (emacs_gnutls_handle_error): New function.
16396 (wsaerror_to_errno): Likewise.
16397
16398 * w32.h (emacs_gnutls_pull): Add prototype.
16399 (emacs_gnutls_push): Likewise.
16400
16401 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
16402 (emacs_gnutls_push): Likewise.
16403
164042011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
16405
16406 * process.c (wait_reading_process_output): Check if GnuTLS
16407 buffered some data internally if no FDs are set for TLS
16408 connections.
16409
16410 * makefile.w32-in (OBJ2): Add gnutls.$(O).
16411 (LIBS): Link to USER_LIBS.
16412 ($(BLD)/gnutls.$(0)): New target.
16413
fa6996bc
EZ
164142011-04-24 Eli Zaretskii <eliz@gnu.org>
16415
eb35682e
EZ
16416 * xdisp.c (handle_single_display_spec): Rename the
16417 display_replaced_before_p argument into display_replaced_p, to
16418 make it consistent with the commentary. Fix typos in the
16419 commentary.
16420
e2ad650c
EZ
16421 * textprop.c (syms_of_textprop): Remove dead code.
16422 (copy_text_properties): Delete obsolete commentary about an
16423 interface that was deleted long ago. Fix typos in the description
16424 of arguments.
16425
1b2de274
EZ
16426 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
16427 to changes in oldXMenu/XMenu.h from 2011-04-16.
16428 <menu_help_message, prev_menu_help_message>: Constify.
16429 (IT_menu_make_room): menu->help_text is now `const char **';
16430 adjust.
16431
16432 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
16433 to changes in oldXMenu/XMenu.h from 2011-04-16.
16434 (struct XMenu): Declare `help_text' `const char **'.
16435
16436 * xfaces.c <Qunspecified>: Make extern again.
16437
16438 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 16439 required by POSIX.
1b2de274 16440
762b15be
EZ
16441 * doc.c (get_doc_string): Improve the format passed to `error'.
16442
16443 * doprnt.c (doprnt): Improve commentary.
16444
16445 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
16446
16447 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
16448 them with etags.
16449
f1052e5d
EZ
16450 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
16451 changes in globals.h immediately force recompilation.
762b15be
EZ
16452 (TAGS): Depend on $(CURDIR)/m/intel386.h and
16453 $(CURDIR)/s/ms-w32.h.
16454 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 16455
fa6996bc
EZ
16456 * character.c (Fchar_direction): Function deleted.
16457 (syms_of_character): Don't defsubr it.
16458 <char-direction-table>: Deleted.
16459
e6c3da20
EZ
164602011-04-23 Eli Zaretskii <eliz@gnu.org>
16461
16462 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
16463 * doprnt.c: Include limits.h.
16464 (SIZE_MAX): New macro.
04f2d78b
CB
16465 (doprnt): Return a size_t value. 2nd arg is now size_t.
16466 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
16467 Improve overflow protection. Support `l' modifier for integer
16468 conversions. Support %l conversion. Don't assume an EMACS_INT
16469 argument for integer conversions and for %c.
16470
16471 * lisp.h (doprnt): Restore prototype.
16472
16473 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
16474 $(SRC)/character.h.
16475
16476 * Makefile.in (base_obj): Add back doprnt.o.
16477
16478 * deps.mk (doprnt.o): Add back prerequisites.
16479 (callint.o): Depend on character.h.
16480
16481 * eval.c (internal_lisp_condition_case): Include the handler
16482 representation in the error message.
16483 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
16484 when breaking from the loop.
16485
16486 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
16487
16488 * callint.c (Fcall_interactively): When displaying error message
16489 about invalid control letter, pass the character's codepoint, not
16490 a pointer to its multibyte form. Improve display of the character
16491 in octal and display also its hex code.
16492
16493 * character.c (char_string): Use %x to display the (unsigned)
16494 codepoint of an invalid character, to avoid displaying a bogus
16495 negative value.
16496
16497 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
16498 `error', not SYMBOL_NAME itself.
16499
16500 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
16501 character arguments to `error'.
16502
16503 * charset.c (check_iso_charset_parameter): Fix incorrect argument
16504 to `error' in error message about FINAL_CHAR argument. Make sure
16505 FINAL_CHAR is a character, and use %c when it is passed as
16506 argument to `error'.
16507
4ffd0d6b 165082011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
16509
16510 * s/ms-w32.h (localtime): Redirect to sys_localtime.
16511
16512 * w32.c: Include <time.h>.
16513 (sys_localtime): New function.
16514
4ffd0d6b 165152011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
16516
16517 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
16518
4ffd0d6b 16519 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 16520
4ffd0d6b 165212011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 16522
4ffd0d6b
GM
16523 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
16524 zombies (Bug#8467).
aac0c6e3 16525
04c56954
EZ
165262011-04-19 Eli Zaretskii <eliz@gnu.org>
16527
16528 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
16529 gl_state.e_property when gl_state.object is Qt.
16530
16531 * insdel.c (make_gap_larger): Remove limitation of buffer size
16532 to <= INT_MAX.
16533
16a43933
CY
165342011-04-18 Chong Yidong <cyd@stupidchicken.com>
16535
16536 * xdisp.c (lookup_glyphless_char_display)
16537 (produce_glyphless_glyph): Handle cons cell entry in
16538 glyphless-char-display.
16539 (Vglyphless_char_display): Document it.
16540
16541 * term.c (produce_glyphless_glyph): Handle cons cell entry in
16542 glyphless-char-display.
16543
4581706e
CY
165442011-04-17 Chong Yidong <cyd@stupidchicken.com>
16545
16546 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
16547
16548 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
16549
16550 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
16551 definition for no-X builds.
16552
4887c6e2 165532011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 16554
fd35b6f9
PE
16555 Static checks with GCC 4.6.0 and non-default toolkits.
16556
5c1ccb01
PE
16557 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
16558
006c5daa
PE
16559 * process.c (keyboard_bit_set): Define only if SIGIO.
16560 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
16561 (send_process): Repair possible setjmp clobbering.
16562
efc736d3
PE
16563 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
16564
4e2fe2e6
PE
16565 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
16566
f97334a2
PE
16567 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
16568
4e75f29d
PE
16569 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
16570 Define only if needed.
16571
90efadd1
PE
16572 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
16573 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 16574 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 16575
3c647824
PE
16576 * dispextern.h (struct redisplay_interface): Rename param
16577 to avoid shadowing.
e264f262 16578 * termhooks.h (struct terminal): Likewise.
761383f4 16579 * xterm.c (xembed_send_message): Likewise.
3c647824 16580
b58c5c4a
PE
16581 * insdel.c (make_gap_smaller): Define only if
16582 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
16583
cad59032
PE
16584 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
16585 it.
16586
c339dc2e
PE
16587 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
16588 so that we aren't warned about unused symbols.
16589
91a3e27b
PE
16590 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
16591
399c71d3 16592 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 16593
8ffc96f5
PE
16594 * xfns.c (x_real_positions): Mark locals as initialized.
16595
eef9bc79
PE
16596 * xmenu.c (xmenu_show): Don't use uninitialized vars.
16597
098db9dd
PE
16598 * xterm.c: Fix problems found by static analysis with other toolkits.
16599 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
16600 (x_dispatch_event): Declare static if USE_GTK, and
16601 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 16602 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 16603 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
16604 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
16605 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 16606
eb18f6cc
PE
16607 * xmenu.c (menu_help_callback): Pointer type fixes.
16608 Use const pointers when pointing at readonly data. Avoid pointer
16609 signedness clashes.
16610 (FALSE): Remove unused macro.
16611 (update_frame_menubar): Remove unused decl.
16612
1fe72bf8
PE
16613 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
16614
60d9e1db
PE
16615 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
16616 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
16617 (single_menu_item): Rename local to avoid shadowing.
16618
39261c26
PE
16619 * keyboard.c (make_lispy_event): Remove unused local var.
16620
018c5e19
PE
16621 * frame.c, frame.h (x_get_resource_string): Bring this back, but
16622 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
16623
63d2b86e
PE
16624 * bitmaps: Change bitmaps from unsigned char back to the X11
16625 compatible char. Avoid the old compiler warnings about
16626 out-of-range initializers by using, for example, '\xab' rather
16627 than 0xab.
16628
aefd87e1
PE
16629 * xgselect.c (xgselect_initialize): Check vs interface
16630 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
16631
bf501fb9
PE
16632 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
16633
e9829fdf
PE
16634 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
16635 to read-only memory.
16636
1086c095
PE
16637 * fns.c (vector): Remove; this old hack is no longer needed.
16638
2baccd04 16639 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 16640 Remove unused var.
dde42981 16641 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 16642
72391843 16643 * xrdb.c (x_load_resources): Omit unused local.
3565b346 16644
436c16df 16645 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 16646 (x_window): Rename locals to avoid shadowing.
dc5ddd85 16647 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 16648
92bb796d 16649 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 16650 (x_term_init): Remove local to avoid shadowing.
92bb796d 16651
764430a3 16652 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
16653
16654 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
16655 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
16656
d1dfb56c
EZ
166572011-04-16 Eli Zaretskii <eliz@gnu.org>
16658
c4354cb4
EZ
16659 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
16660
d1dfb56c
EZ
16661 Fix regex.c, syntax.c and friends for buffers > 2GB.
16662 * syntax.h (struct gl_state_s): Declare character position members
16663 EMACS_INT.
16664
16665 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
16666
04f2d78b
CB
16667 * textprop.c (verify_interval_modification, interval_of):
16668 Declare arguments EMACS_INT.
d1dfb56c
EZ
16669
16670 * intervals.c (adjust_intervals_for_insertion): Declare arguments
16671 EMACS_INT.
16672
16673 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
16674
16675 * indent.c (Fvertical_motion): Local variable it_start is now
16676 EMACS_INT.
16677
16678 * regex.c (re_match, re_match_2, re_match_2_internal)
16679 (bcmp_translate, regcomp, regexec, print_double_string)
16680 (group_in_compile_stack, re_search, re_search_2, regex_compile)
16681 (re_compile_pattern, re_exec): Declare arguments and local
16682 variables `size_t' and `ssize_t' and return values `regoff_t', as
16683 appropriate.
16684 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
16685 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
16686 <compile_stack_type>: `size' and `avail' are now `size_t'.
16687
16688 * regex.h <regoff_t>: Use ssize_t, not int.
16689 (re_search, re_search_2, re_match, re_match_2): Arguments that
16690 specify buffer/string position and length are now ssize_t and
16691 size_t. Return type is regoff_t.
16692
613052cd
BK
166932011-04-16 Ben Key <bkey76@gmail.com>
16694
16695 * nsfont.m: Fixed bugs in ns_get_family and
16696 ns_descriptor_to_entity that were caused by using free to
16697 deallocate memory blocks that were allocated by xmalloc (via
16698 xstrdup). This caused Emacs to crash when compiled with
16699 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
16700 --enable-checking=xmallocoverrun). xfree is now used to
16701 deallocate these memory blocks.
16702
4170f62f 167032011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 16704
71b41406
PE
16705 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
16706
9587a89d
PE
16707 emacs_write: Accept and return EMACS_INT for sizes.
16708 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
16709 et seq.
16710 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
16711 Accept and return EMACS_INT.
16712 (emacs_gnutls_write): Return the number of bytes written on
16713 partial writes.
16714 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
16715 (emacs_read, emacs_write): Remove check for negative size, as the
16716 Emacs source code has been audited now.
9587a89d
PE
16717 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
16718 (emacs_read, emacs_write): Use it.
273a5f82
PE
16719 * process.c (send_process): Adjust to the new signatures of
16720 emacs_write and emacs_gnutls_write. Do not attempt to store
16721 a byte offset into an 'int'; it might overflow.
9587a89d 16722 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 16723
3e047f51
PE
16724 * sound.c: Don't assume sizes fit in 'int'.
16725 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 16726 Return EMACS_INT, not int.
3e047f51 16727 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
16728 Accept EMACS_INT, not int.
16729 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
16730 record read return values.
16731
cc39a9db
BK
167322011-04-15 Ben Key <bkey76@gmail.com>
16733
c9d0ec6d
JB
16734 * keyboard.c (Qundefined): Don't declare static since it is used
16735 in nsfns.m.
16736 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
16737 static since they are used in nsfont.m.
cc39a9db 16738
6c60eb9f
SM
167392011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
16740
16741 * process.c (Qprocessp): Don't declare static.
16742 * lisp.h (Qprocessp): Declare again.
16743
7990b61a
JB
167442011-04-15 Juanma Barranquero <lekktu@gmail.com>
16745
16746 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
16747
5d4cb038
PE
167482011-04-14 Paul Eggert <eggert@cs.ucla.edu>
16749
8bd7b830 16750 Improve C-level modularity by making more things 'static'.
cd64ea1d 16751
e3b27b31
PE
16752 Don't publish debugger-only interfaces to other modules.
16753 * lisp.h (safe_debug_print, debug_output_compilation_hack):
16754 (verify_bytepos, count_markers): Move decls to the only modules
16755 that need them.
16756 * region-cache.h (pp_cache): Likewise.
16757 * window.h (check_all_windows): Likewise.
16758 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
16759
5d4cb038
PE
16760 * sysdep.c (croak): Now static, if
16761 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
16762 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
16763
16764 * alloc.c (refill_memory_reserve): Now static if
16765 !defined REL_ALLOC || defined SYSTEM_MALLOC.
16766 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 16767
e87b6180
PE
16768 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
16769 Define only if USE_LUCID.
16770
ac64929e
PE
16771 * xrdb.c (x_customization_string, x_rm_string): Now static.
16772
6f37259d
PE
16773 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
16774 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
16775
1683e3ab
PE
16776 * xdisp.c (draw_row_with_mouse_face): Now static.
16777 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
16778
de9c2632
PE
16779 * window.h (check_all_windows): Mark externally visible.
16780
2b96acb7
PE
16781 * window.c (window_deletion_count): Now static.
16782
16783 * undo.c: Make symbols static if they're not exported.
16784 (last_undo_buffer, last_boundary_position, pending_boundary):
16785 Now static.
16786
50436f33
PE
16787 * textprop.c (interval_insert_behind_hooks): Now static.
16788 (interval_insert_in_front_hooks): Likewise.
16789
64520e5c
PE
16790 * term.c: Make symbols static if they're not exported.
16791 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
16792 (max_frame_lines, tty_set_terminal_modes):
16793 (tty_reset_terminal_modes, tty_turn_off_highlight):
16794 (get_tty_terminal): Now static.
16795 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
16796 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 16797 HAVE_WINDOW_SYSTEM.
64520e5c
PE
16798 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
16799 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
16800
1fa53021
PE
16801 * sysdep.c: Make symbols static if they're not exported.
16802 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
16803 Now static.
16804 (sigprocmask_set, full_mask): Remove; unused.
16805 (wait_debugging): Mark as visible.
16806 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
16807 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
16808
d4b43b22
PE
16809 * syntax.c (syntax_temp): Define only if !__GNUC__.
16810
b7c513d0
PE
16811 * sound.c (current_sound_device, current_sound): Now static.
16812
989b29ad
PE
16813 * search.c (searchbufs, searchbuf_head): Now static.
16814
13a55a78
PE
16815 * scroll.c (scroll_cost): Remove; unused.
16816 * dispextern.h (scroll_cost): Remove decl.
16817
de68a1fc
PE
16818 * region-cache.h (pp_cache): Mark as externally visible.
16819
40ccffa6
PE
16820 * process.c: Make symbols static if they're not exported.
16821 (process_tick, update_tick, create_process, chan_process):
16822 (Vprocess_alist, proc_buffered_char, datagram_access):
16823 (fd_callback_data, send_process_frame, process_sent_to): Now static.
16824 (deactivate_process): Mark defn as static, as well as decl.
16825 * lisp.h (create_process): Remove decl.
16826 * process.h (chan_process, Vprocess_alist): Remove decls.
16827
ad64fc97
PE
16828 * print.c: Make symbols static if they're not exported.
16829 (print_depth, new_backquote_output, being_printed, print_buffer):
16830 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
16831 (print_interval, print_number_index, initial_stderr_stream):
16832 Now static.
16833 * lisp.h (Fprinc): Remove decl.
16834 (debug_output_compilation_hack): Mark as externally visible.
16835
adddb265
PE
16836 * sysdep.c (croak): Move decl from here to syssignal.h.
16837 * syssignal.h (croak): Put it here, so the API can be checked when
16838 'croak' is called from dissociate_if_controlling_tty.
16839
1717ede2
PE
16840 * minibuf.c: Make symbols static if they're not exported.
16841 (minibuf_save_list, choose_minibuf_frame): Now static.
16842 * lisp.h (choose_minibuf_frame): Remove decl.
16843
fa5fb2bc
PE
16844 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
16845
1e3890d1
PE
16846 * lread.c: Make symbols static if they're not exported.
16847 (read_objects, initial_obarray, oblookup_last_bucket_number):
16848 Now static.
16849 (make_symbol): Remove; unused.
16850 * lisp.h (initial_obarray, make_symbol): Remove decls.
16851
8a1414fa
PE
16852 * keyboard.c: Make symbols static if they're not exported.
16853 (single_kboard, recent_keys_index, total_keys, recent_keys):
16854 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
16855 (this_single_command_key_start, echoing, last_auto_save):
16856 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
16857 (command_loop, echo_now, keyboard_init_hook, help_char_p):
16858 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16859 (Vlispy_mouse_stem, double_click_count):
16860 Now static.
16861 (force_auto_save_soon): Define only if SIGDANGER.
16862 (ignore_mouse_drag_p): Now static if
16863 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
16864 (print_help): Remove; unused.
16865 (stop_character, last_timer_event): Mark as externally visible.
16866 * keyboard.h (ignore_mouse_drag_p): Declare only if
16867 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
16868 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
16869 * lisp.h (echoing): Remove decl.
16870 (force_auto_save_soon): Declare only if SIGDANGER.
16871 * xdisp.c (redisplay_window): Simplify code, to make it more
16872 obvious that ignore_mouse_drag_p is not accessed if !defined
16873 USE_GTK && !defined HAVE_NS.
16874
93ea6e8f
PE
16875 * intervals.c: Make symbols static if they're not exported.
16876 (merge_properties_sticky, merge_interval_right, delete_interval):
16877 Now static.
16878 * intervals.h (merge_interval_right, delete_interval): Remove decls.
16879
77382fcc
PE
16880 * insdel.c: Make symbols static if they're not exported.
16881 However, leave prepare_to_modify_buffer alone. It's never
16882 called from outside this function, but that appears to be a bug.
16883 (combine_after_change_list, combine_after_change_buffer):
4889fc82 16884 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
16885 (adjust_after_replace_noundo): Remove; unused.
16886 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 16887 (signal_before_change): Remove decls.
77382fcc 16888
9306c32e
PE
16889 * indent.c (val_compute_motion, val_vmotion): Now static.
16890
cd44d2eb
PE
16891 * image.c: Make symbols static if they're not exported.
16892 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
16893 if USE_GTK.
16894 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
16895 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
16896
ad9a7a06
PE
16897 * fringe.c (standard_bitmaps): Now static.
16898 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
16899
81626931
PE
16900 * frame.c: Make symbols static if they're not exported.
16901 (x_report_frame_params, make_terminal_frame): Now static.
16902 (get_frame_param): Now static, unless HAVE_NS.
16903 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16904 (x_get_resource_string): Remove; not used.
16905 * frame.h (make_terminal_frame, x_report_frame_params):
16906 (x_get_resource_string); Remove decls.
16907 (x_fullscreen_adjust): Declare only if WINDOWSNT.
16908 * lisp.h (get_frame_param): Declare only if HAVE_NS.
16909
239f9db9
PE
16910 * font.c, fontset.c: Make symbols static if they're not exported.
16911 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
16912 (FACE_SUITABLE_FOR_CHAR_P): Use it.
16913 * font.c (font_close_object): Now static.
16914 * font.h (font_close_object): Remove.
16915 * fontset.c (FONTSET_OBJLIST): Remove.
16916 (free_realized_fontset) #if-0 the body, which does nothing.
16917 (face_suitable_for_char_p): #if-0, as it's never called.
16918 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16919 * xfaces.c (face_at_string_position):
16920 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16921 since 0 is always ASCII.
16922
dfcf3579
PE
16923 * fns.c (weak_hash_tables): Now static.
16924
5045092b
PE
16925 * fileio.c: Make symbols static if they're not exported.
16926 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16927 (Vwrite_region_annotation_buffers): Now static.
16928
57a96f5c
PE
16929 * eval.c: Make symbols static if they're not exported.
16930 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16931 * lisp.h (backtrace_list): Remove decl.
16932
35f08c38
PE
16933 * emacs.c: Make symbols static if they're not exported.
16934 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16935 (fatal_error_code, fatal_error_signal_hook, standard_args):
16936 Now static.
16937 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16938 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16939 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16940 * lisp.h (fatal_error_signal_hook): Remove decl.
16941 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16942
f44bd759
PE
16943 * editfns.c: Move a (normally-unused) function to its only use.
16944 * editfns.c, lisp.h (get_operating_system_release): Remove.
16945 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16946 worth the hassle of breaking this out.
16947
b532497d
PE
16948 * xterm.c: Make symbols static if they're not exported.
16949 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16950 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16951 (x_destroy_window, x_delete_display):
16952 Now static.
16953 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16954 (x_mouse_leave): Remove; unused.
16955 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16956 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16957 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16958 Remove decls.
16959 (x_mouse_leave): Declare only if WINDOWSNT.
16960 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16961 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16962 USE_X_TOOLKIT.
16963
1675728f
PE
16964 * ftxfont.c: Make symbols static if they're not exported.
16965 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16966 HAVE_FREETYPE.
16967 * font.h (ftxfont_driver): Likewise.
16968
e4cebfca
PE
16969 * xfns.c: Make symbols static if they're not exported.
16970 (x_last_font_name, x_display_info_for_name):
16971 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16972 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16973 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16974 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16975 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16976 (last_show_tip_args): Now static.
16977 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16978 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16979 (x_screen_planes): Remove; unused.
16980 * dispextern.h (x_screen_planes): Remove decl.
16981
5bf46f05
PE
16982 * dispnew.c: Make symbols static if they're not exported.
16983 * dispextern.h (redraw_garbaged_frames, scrolling):
16984 (increment_row_positions): Remove.
16985 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16986 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16987 Now static.
16988 (redraw_garbaged_frames): Remove; unused.
16989
435f4c28
PE
16990 * xfaces.c: Make symbols static if they're not exported.
16991 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16992 Remove decls.
16993 * xterm.h (defined_color): Remove decls.
16994 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16995 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16996 (menu_face_changed_default, defined_color, free_realized_face):
16997 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16998 (ascii_face_of_lisp_face): Remove; unused.
16999
8524aef3
PE
17000 * xdisp.c: Make symbols static if they're not exported.
17001 * dispextern.h (scratch_glyph_row, window_box_edges):
17002 (glyph_to_pixel_coords, set_cursor_from_row):
17003 (get_next_display_element, set_iterator_to_next):
17004 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
17005 (show_mouse_face): Remove decls
17006 * frame.h (message_buf_print): Likewise.
17007 * lisp.h (pop_message, set_message, check_point_in_composition):
17008 Likewise.
17009 * xterm.h (set_vertical_scroll_bar): Likewise.
17010 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
17011 (message_buf_print, scratch_glyph_row, displayed_buffer):
17012 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
17013 (get_next_display_element, show_mouse_face, window_box_edges):
17014 (frame_to_window_pixel_xy, check_point_in_composition):
17015 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
17016 (glyph_to_pixel_coords): Remove; unused.
17017
16390cd2
PE
17018 * dired.c (file_name_completion): Now static.
17019
17020 * dbusbind.c (xd_in_read_queued_messages): Now static.
17021
a25f4dfa
PE
17022 * lisp.h (circular_list_error, FOREACH): Remove; unused.
17023 * data.c (circular_list_error): Remove.
17024
14a9c8df
PE
17025 * commands.h (last_point_position, last_point_position_buffer):
17026 (last_point_position_window): Remove decls.
17027 * keyboard.c: Make these variables static.
17028
04f2d78b
CB
17029 * coding.h (coding, code_convert_region, encode_coding_gap):
17030 Remove decls.
74ab6df5
PE
17031 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
17032 (iso_code_class, detect_coding, code_convert_region): Now static.
17033 (encode_coding_gap): Remove; unused.
17034
38dfbee1
PE
17035 * chartab.c (chartab_chars, chartab_bits): Now static.
17036
a2cb4e63
PE
17037 * charset.h (charset_iso_8859_1): Remove decl.
17038 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
17039 Now static.
17040
127198fd
PE
17041 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
17042 * ccl.c (Vccl_program_table): Now static.
17043 (check_ccl_update): Remove; unused.
17044
d85b608f
PE
17045 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
17046 * category.h: ... from here.
17047 * category.c (check_category_table, set_category_set): Now static.
17048
31cd66f3
PE
17049 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
17050 * lisp.h: Remove these decls.
17051
c358e587
PE
17052 * buffer.c (buffer_count): Remove unused var.
17053
e78aecca
PE
17054 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
17055 so that it's not optimized away.
17056 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
17057 * dispextern.h (bidi_dump_cached_states): Remove, since it's
17058 exported only to the debugger.
17059
e192d7d3 17060 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 17061 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 17062
92470028
PE
17063 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
17064 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
17065 was inaccessible from Lisp.
17066 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
17067 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
17068
244ed907
PE
17069 alloc.c: Import and export fewer symbols, and remove unused items.
17070 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
17071 is defined.
17072 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
17073 it's not optimized away by whole-program optimization.
17074 (message_enable_multibyte, free_misc): Remove.
17075 (catchlist, handlerlist, mark_backtrace):
17076 Declare only if BYTE_MARK_STACK.
17077 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
17078 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
17079 (message_enable_multibyte): Remove decl.
17080 (free_misc, interval_free_list, float_block, float_block_index):
17081 (n_float_blocks, float_free_list, cons_block, cons_block_index):
17082 (cons_free_list, last_marked_index):
17083 Now static.
17084 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
17085 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
17086 (mark_backtrace): Define only if BYTE_MARK_STACK.
17087 * xdisp.c (message_enable_multibyte): Now static.
17088
61c2b50e 17089 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
17090 This makes it easier for human readers (and static analyzers)
17091 to see whether these variables are used from other modules.
17092 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
17093 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
17094 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
17095 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
17096 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
17097 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
17098 * xmenu.c, xselect.c:
17099 Declare Q* vars static if they are not used in other modules.
17100 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
17101 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
17102 Remove decls of unexported vars.
17103 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
17104
95c82688
PE
17105 * lisp.h (DEFINE_FUNC): Make sname 'static'.
17106
16a97296
PE
17107 Make Emacs functions such as Fatom 'static' by default.
17108 This makes it easier for human readers (and static analyzers)
17109 to see whether these functions can be called from other modules.
17110 DEFUN now defines a static function. To make the function external
17111 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
17112 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
17113 (Finit_image_library):
16a97296
PE
17114 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
17115 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
17116 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
17117 Remove decls, since these functions are now static.
17118 (Funintern, Fget_internal_run_time): New decls, since these functions
17119 were already external.
95c82688 17120
16a97296
PE
17121 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
17122 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
17123 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
17124 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
17125 * keyboard.c, keymap.c, lread.c:
17126 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
17127 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
17128 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
17129 Mark functions with DEFUE instead of DEFUN,
17130 if they are used in other modules.
17131 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
17132 decls for now-static functions.
17133 * buffer.h (Fdelete_overlay): Remove decl.
17134 * callproc.c (Fgetenv_internal): Mark as internal.
17135 * composite.c (Fremove_list_of_text_properties): Remove decl.
17136 (Fcomposition_get_gstring): New forward static decl.
17137 * composite.h (Fcomposite_get_gstring): Remove decl.
17138 * dired.c (Ffile_attributes): New forward static decl.
17139 * doc.c (Fdocumntation_property): New forward static decl.
17140 * eval.c (Ffetch_bytecode): New forward static decl.
17141 (Funintern): Remove extern decl; now in .h file where it belongs.
17142 * fileio.c (Fmake_symbolic_link): New forward static decl.
17143 * image.c (Finit_image_library): New forward static decl.
17144 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
17145 * intervals.h (Fprevious_property_change):
17146 (Fremove_list_of_text_properties): Remove decls.
17147 * keyboard.c (Fthis_command_keys): Remove decl.
17148 (Fcommand_execute): New forward static decl.
17149 * keymap.c (Flookup_key): New forward static decl.
17150 (Fcopy_keymap): Now static.
17151 * keymap.h (Flookup_key): Remove decl.
17152 * process.c (Fget_process): New forward static decl.
17153 (Fprocess_datagram_address): Mark as internal.
17154 * syntax.c (Fsyntax_table_p): New forward static decl.
17155 (skip_chars): Remove duplicate decl.
17156 * textprop.c (Fprevious_property_change): New forward static decl.
17157 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
17158 Now internal.
17159 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
17160 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
17161
785bbd42
PE
17162 * editfns.c (Fformat): Remove unreachable code.
17163
8b913b57
AS
171642011-04-14 Andreas Schwab <schwab@linux-m68k.org>
17165
17166 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
17167 change. (Bug#8496)
17168
a6744a35
EZ
171692011-04-13 Eli Zaretskii <eliz@gnu.org>
17170
17171 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
17172 when at ZV. (Bug#8487)
17173
e7974947
AS
171742011-04-12 Andreas Schwab <schwab@linux-m68k.org>
17175
baad03f0
AS
17176 * charset.c (Fclear_charset_maps): Use xfree instead of free.
17177 (Bug#8437)
17178 * keyboard.c (parse_tool_bar_item): Likewise.
17179 * sound.c (sound_cleanup, alsa_close): Likewise.
17180 * termcap.c (tgetent): Likewise.
17181 * xfns.c (x_default_font_parameter): Likewise.
17182 * xsettings.c (read_and_apply_settings): Likewise.
17183
e7974947
AS
17184 * alloc.c (overrun_check_malloc, overrun_check_realloc)
17185 (overrun_check_free): Protoize.
17186
28272684
PE
171872011-04-12 Paul Eggert <eggert@cs.ucla.edu>
17188
17189 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
17190 since callers should never pass a negative size.
17191 Change the signature to match that of plain 'read' and 'write'; see
17192 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
17193 * lisp.h: Update prototypes of emacs_write and emacs_read.
17194
11997c76
EZ
171952011-04-11 Eli Zaretskii <eliz@gnu.org>
17196
17197 * xdisp.c (redisplay_window): Don't try to determine the character
17198 position of the scroll margin if the window start point w->startp
e896f03c 17199 is outside the buffer's accessible region. (Bug#8468)
11997c76 17200
8a2cbd72
EZ
172012011-04-10 Eli Zaretskii <eliz@gnu.org>
17202
17203 Fix write-region and its subroutines for buffers > 2GB.
17204 * fileio.c (a_write, e_write): Modify declaration of arguments and
17205 local variables to support buffers larger than 2GB.
17206 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
17207
17208 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
17209 argument, local variables, and return value.
17210
17211 * lisp.h: Update prototypes of emacs_write and emacs_read.
17212
17213 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
17214
4073e537 172152011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 17216
1ebfdcb6
PE
17217 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
17218
b2ded58d
PE
17219 Fix more problems found by GCC 4.6.0's static checks.
17220
7d66342c
PE
17221 * xdisp.c (vmessage): Use a better test for character truncation.
17222
bbf47d44
PE
17223 * charset.c (load_charset_map): <, not <=, for optimization,
17224 and to avoid potential problems with integer overflow.
9248994d 17225 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 17226 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 17227 * editfns.c (Fformat): Likewise.
1e69125e 17228 * syntax.c (skip_chars): Likewise.
3befa583 17229
e3019616
PE
17230 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
17231 This also lets GCC 4.6.0 generate slightly better loop code.
17232
becfa255
PE
17233 * callint.c (Fcall_interactively): <, not <=, for optimization.
17234 (Fcall_interactively): Count the number of arguments produced,
17235 not the number of arguments given. This is simpler and lets GCC
17236 4.6.0 generate slightly better code.
17237
dae0cd48
PE
17238 * ftfont.c: Distingish more carefully between FcChar8 and char.
17239 The previous code passed unsigned char * to a functions like
17240 strlen and xstrcasecmp that expect char *, which does not
17241 conform to the C standard.
17242 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
17243 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
17244 char * when the C standard requires it.
17245
76032d70
PE
17246 * keyboard.c (read_char): Remove unused var.
17247
eb3f1cc8
PE
17248 * eval.c: Port to Windows vsnprintf (Bug#8435).
17249 Include <limits.h>.
17250 (SIZE_MAX): Define if the headers do not.
17251 (verror): Do not give up if vsnprintf returns a negative count.
17252 Instead, grow the buffer. This ports to Windows vsnprintf, which
17253 does not conform to C99. Problem reported by Eli Zaretskii.
17254 Also, simplify the allocation scheme, by avoiding the need for
17255 calling realloc, and removing the ALLOCATED variable.
17256
70476b54
PE
17257 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
17258
12020a9e
PE
17259 Remove invocations of doprnt, as Emacs now uses vsnprintf.
17260 But keep the doprint source code for now, as we might revamp it
17261 and use it again (Bug#8435).
ea6c7ae6
PE
17262 * lisp.h (doprnt): Remove.
17263 * Makefile.in (base_obj): Remove doprnt.o.
17264 * deps.mk (doprnt.o): Remove.
17265
5fdb398c
PE
17266 error: Print 32- and 64-bit integers portably (Bug#8435).
17267 Without this change, on typical 64-bit hosts error ("...%d...", N)
17268 was used to print both 32- and 64-bit integers N, which relied on
17269 undefined behavior.
61bdb816 17270 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
17271 * lisp.h (error, verror): Mark as printf-like functions.
17272 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
17273 Report overflow in size calculations when allocating printf buffer.
17274 Do not truncate output string at its first null byte.
17275 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
17276 Truncate the output at a character boundary, since vsnprintf does not
17277 do that.
17278 * charset.c (check_iso_charset_parameter): Convert internal
17279 character to string before calling 'error', since %c now has the
17280 printf meaning.
17281 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
17282 overflow when computing char to be passed to 'error'. Do not
17283 pass Lisp_Object to 'error'; pass the integer instead.
17284 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
17285 formatted with plain %d.
17286
b189fa66
PE
17287 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
17288
bff87ef0
PE
17289 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
17290
7e2cac20
PE
17291 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
17292
ce4d90b5
PE
17293 * xterm.c (x_catch_errors): Remove duplicate declaration.
17294
266c9547
PE
17295 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
17296
79c49ad2
PE
17297 * xdisp.c, lisp.h (message_nolog): Remove; unused.
17298
368f4090
JM
172992011-04-10 Jim Meyering <meyering@redhat.com>
17300
17301 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
17302 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
17303 return ssize_t not "int", and use size_t as the buffer length.
17304 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
17305 * gnutls.h: Update declarations.
17306 * process.c (read_process_output): Use ssize_t, to match.
17307 (send_process): Likewise.
17308
a32d4040
CY
173092011-04-09 Chong Yidong <cyd@stupidchicken.com>
17310
17311 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
17312
8546720e 173132011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 17314
04f2d78b
CB
17315 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
17316 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 17317
8546720e
GM
17318 * xterm.c (handle_one_xevent):
17319 * xmenu.c (create_and_show_popup_menu):
17320 * xselect.c (x_decline_selection_request)
17321 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 17322
0a2f5c1a 173232011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
17324
17325 Fix some uses of `int' instead of EMACS_INT.
17326 * search.c (string_match_1, fast_string_match)
17327 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
17328 (scan_buffer, find_next_newline_no_quit)
17329 (find_before_next_newline, search_command, Freplace_match)
17330 (Fmatch_data): Make some `int' variables be EMACS_INT.
17331
17332 * xdisp.c (display_count_lines): 3rd argument and return value now
17333 EMACS_INT. All callers changed.
17334 (pint2hrstr): Last argument is now EMACS_INT.
17335
17336 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
17337 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
17338 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
17339 (decode_coding_utf_16, decode_coding_emacs_mule)
17340 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
17341 (decode_coding_ccl, decode_coding_charset)
17342 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
17343 (decode_coding_iso_2022, decode_coding_emacs_mule)
17344 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
17345 <char_offset, last_offset>: Declare EMACS_INT.
17346 (encode_coding_utf_8, encode_coding_utf_16)
17347 (encode_coding_emacs_mule, encode_invocation_designation)
17348 (encode_designation_at_bol, encode_coding_iso_2022)
17349 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
17350 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
17351 Declare EMACS_INT.
17352 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
17353 (encode_invocation_designation): Last argument P_NCHARS is now
17354 EMACS_INT.
17355 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
17356 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
17357
17358 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
17359 All users changed.
17360
17361 * ccl.c (Fccl_execute_on_string): Declare some variables
17362 EMACS_INT.
17363
8546720e 173642011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
17365
17366 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
17367
4e19a977
CS
173682011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
17369
17370 * process.c (Fformat_network_address): Doc fix.
17371
87302331
R
173722011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
17373
ee7683eb 17374 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 17375
cbb59342
CY
173762011-04-08 Chong Yidong <cyd@stupidchicken.com>
17377
17378 * keyboard.c (read_char): Call Lisp function help-form-show,
17379 instead of using internal_with_output_to_temp_buffer.
17380 (Qhelp_form_show): New var.
e0d38eeb 17381 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
17382
17383 * print.c (internal_with_output_to_temp_buffer): Function deleted.
17384
17385 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
17386
e67a13ab
CY
173872011-04-06 Chong Yidong <cyd@stupidchicken.com>
17388
04f2d78b
CB
17389 * process.c (Flist_processes): Remove to Lisp.
17390 (list_processes_1): Delete.
e67a13ab 17391
973f782d
EZ
173922011-04-06 Eli Zaretskii <eliz@gnu.org>
17393
7c106b1e
EZ
17394 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
17395
973f782d
EZ
17396 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
17397
41cf7d1a 173982011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 17399
ca23cc88
PE
17400 Fix more problems found by GCC 4.6.0's static checks.
17401
f390e2d5
PE
17402 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
17403
42eea0d0
PE
17404 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
17405
b69769da 17406 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 17407
f9541e84
PE
17408 * xdisp.c (vmessage): Mark as a printf-like function.
17409
13841b55
PE
17410 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
17411
c136c10f
PE
17412 * sound.c (sound_warning): Don't crash if arg contains a printf format.
17413
5e2d4a30
PE
17414 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
17415 printf-like functions.
17416 (tiff_load): Add casts to remove these marks before passing them
17417 to system-supplied API.
17418
583f48b9
PE
17419 * eval.c (Fsignal): Remove excess argument to 'fatal'.
17420
b25d760e
PE
17421 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
17422 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
17423 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
17424 directly, rather than having caller test rule sign. This avoids
17425 some unnecessary tests.
17426 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
17427 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
17428 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 17429
bc7b6697 17430 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 17431 (xfont_open): Avoid unnecessary tests.
bc7b6697 17432
27ccc379
PE
17433 * composite.c (composition_gstring_put_cache): Use unsigned integer.
17434
dcd5c89a
PE
17435 * composite.h, composite.c (composition_gstring_put_cache):
17436 Use EMACS_INT, not int, for length.
17437
b13a45c6
PE
17438 * composite.h (COMPOSITION_DECODE_REFS): New macro,
17439 breaking out part of COMPOSITION_DECODE_RULE.
17440 (COMPOSITION_DECODE_RULE): Use it.
17441 * composite.c (get_composition_id): Remove unused local vars,
17442 by using the new macro.
17443
1e792e4d
PE
17444 * textprop.c (set_text_properties_1): Change while to do-while,
17445 since the condition is always true at first.
17446
dc6c6455 17447 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
17448 (interval_deletion_adjustment): Return unsigned value.
17449 All uses changed.
dc6c6455 17450
aba7731a
PE
17451 * process.c (list_processes_1, create_pty, read_process_output):
17452 (exec_sentinel): Remove vars that were set but not used.
afd4052b 17453 (create_pty): Remove unnecessary "volatile"s.
bc57d757 17454 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 17455 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 17456 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 17457
fdfc4bf3
PE
17458 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
17459
fca8fe46 17460 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 17461 (update_syntax_table): Use unsigned instead of int.
fca8fe46 17462
06a0259a 17463 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 17464 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 17465 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 17466
e7b9e80f
PE
17467 * print.c (print_error_message): Avoid int overflow.
17468
56201685
PE
17469 * font.c (font_list_entities): Redo for clarity,
17470 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
17471
78834453 17472 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 17473 (font_score): Avoid potential overflow in diff calculation.
78834453 17474
0bc0b309 17475 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 17476 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 17477
e610eaca
PE
17478 * eval.c (funcall_lambda): Rename local to avoid shadowing.
17479
b895abce
PE
17480 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
17481 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
17482 can always succeed if overflow has undefined behavior.
17483
1f1d9321 17484 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 17485 (wordify): Omit three unnecessary tests.
1f1d9321 17486
c59478bc
PE
17487 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
17488 All callers changed. This avoids the need for an unused var.
17489
79b73827
PE
17490 * casefiddle.c (casify_region): Remove var that is set but not used.
17491
a4db5dfe
PE
17492 * dired.c (file_name_completion): Remove var that is set but not used.
17493
43aae36e
PE
17494 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
17495
2a47c44d 17496 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 17497 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 17498
a37c69bf
PE
17499 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
17500 Check for integer overflow on size calculations.
17501
328ab8e7
PE
17502 * buffer.c (Fprevious_overlay_change): Remove var that is set
17503 but not used.
17504
e5a2a5cb
PE
17505 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
17506 Remove vars that are set but not used.
8d84a6eb 17507 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 17508 (timer_check_2): Mark vars as initialized.
e5a2a5cb 17509
a60e5f68
PE
17510 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
17511
f661cb61 17512 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 17513 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 17514
f0397f5a
PE
17515 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
17516 that are set but not used.
17517
8664db06 17518 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 17519 if XCreateBitmapFromData fails (Bug#8410).
8664db06 17520
6abdaa4a
PE
17521 * xselect.c (x_get_local_selection, x_handle_property_notify):
17522 Remove vars that are set but not used.
17523
0ce7538d 17524 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 17525 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 17526
9ae848fc
PE
17527 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
17528 Remove var that is set but not used.
0b918413
PE
17529 (scroll_bar_windows_size): Now size_t, not int.
17530 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
17531 Check for overflow.
9ae848fc 17532
a5a62657
PE
17533 * xfaces.c (realize_named_face): Remove vars that are set but not used.
17534 (map_tty_color) [!defined MSDOS]: Likewise.
17535
5c5cdd39
PE
17536 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
17537
66ebf983
PE
17538 * coding.c: Remove vars that are set but not used.
17539 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
17540 All callers changed.
17541 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
17542 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
17543 (decode_coding_charset): Remove vars that are set but not used.
17544
1be4d761
PE
17545 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
17546 that is set but not used.
17547
47553fa8
PE
17548 * print.c (print_object): Remove var that is set but not used.
17549
1f7196bf 17550 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
17551 The gnulib version avoids calling malloc in the usual case,
17552 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
17553 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
17554 * filelock.c (current_lock_owner): Likewise.
17555 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
17556 * sysdep.c: Include allocator.h, careadlinkat.h.
17557 (emacs_no_realloc_allocator): New static constant.
17558 (emacs_readlink): New function.
fdb61804
PE
17559 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
17560 ../lib/careadlinkat.h.
d1fdcab7 17561
f84c17c7
SM
175622011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
17563
17564 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
17565 first non-nil return value).
17566
ef3862ad
JD
175672011-04-03 Jan Djärv <jan.h.d@swipnet.se>
17568
17569 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
17570 if not defined (Bug#8403).
17571
376a7006
JB
175722011-04-02 Juanma Barranquero <lekktu@gmail.com>
17573
17574 * xdisp.c (display_count_lines): Remove parameter `start',
17575 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17576 (get_char_face_and_encoding): Remove parameter `multibyte_p',
17577 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17578 (fill_stretch_glyph_string): Remove parameters `row' and `area',
17579 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
17580 and thereabouts. All callers changed.
17581 (get_per_char_metric): Remove parameter `f', unused since
17582 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
17583
6ca3801d
JM
175842011-04-02 Jim Meyering <meyering@redhat.com>
17585
17586 do not dereference NULL upon failed strdup
17587 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
17588 (ns_get_family): Likewise.
17589
d8e2b5ba
JB
175902011-04-02 Juanma Barranquero <lekktu@gmail.com>
17591
17592 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
17593
8c74fcbd
JD
175942011-04-02 Jan Djärv <jan.h.d@swipnet.se>
17595
17596 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
17597 later (Bug#8403).
17598
7200d79c
SM
175992011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
17600
03408648 17601 Add lexical binding.
7200d79c 17602
03408648
SM
17603 * window.c (Ftemp_output_buffer_show): New fun.
17604 (Fsave_window_excursion):
17605 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
17606
17607 * lread.c (lisp_file_lexically_bound_p): New function.
17608 (Fload): Bind Qlexical_binding.
17609 (readevalloop): Remove `evalfun' arg.
17610 Bind Qinternal_interpreter_environment.
17611 (Feval_buffer): Bind Qlexical_binding.
17612 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
17613 Mark as dynamic.
17614 (syms_of_lread): Declare `lexical-binding'.
17615
17616 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
17617
17618 * keyboard.c (eval_dyn): New fun.
17619 (menu_item_eval_property): Use it.
ca105506
SM
17620
17621 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 17622
03408648
SM
17623 * fns.c (concat, mapcar1): Accept byte-code-functions.
17624
17625 * eval.c (Fsetq): Handle lexical vars.
17626 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
17627 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
17628 (FletX, Flet): Obey lexical binding.
17629 (Fcommandp): Handle closures.
17630 (Feval): New `lexical' arg.
17631 (eval_sub): New function extracted from Feval. Use it almost
17632 everywhere where Feval was used. Look up vars in lexical env.
17633 Handle closures.
17634 (Ffunctionp): Move from subr.el.
17635 (Ffuncall): Handle closures.
17636 (apply_lambda): Remove `eval_flags'.
17637 (funcall_lambda): Handle closures and new byte-code-functions.
17638 (Fspecial_variable_p): New function.
17639 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
17640 but without exporting it to Lisp.
23aba0ea 17641
23aba0ea 17642 * doc.c (Fdocumentation, store_function_docstring):
03408648 17643 * data.c (Finteractive_form): Handle closures.
23aba0ea 17644
03408648
SM
17645 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
17646 interactive spec.
ba83908c 17647
04f2d78b
CB
17648 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
17649 New byte-codes.
03408648
SM
17650 (exec_byte_code): New function extracted from Fbyte_code to handle new
17651 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 17652
03408648 17653 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 17654
03408648 17655 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 17656
e2abce01
JB
176572011-03-31 Juanma Barranquero <lekktu@gmail.com>
17658
17659 * xdisp.c (redisplay_internal): Fix prototype.
17660
63696a73 176612011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 17662
63696a73 17663 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
17664 (try_scrolling): Use it when setting scroll_limit.
17665 Limit scrolling to 100 screen lines.
63696a73
EZ
17666 (redisplay_window): Even when falling back on "recentering",
17667 position point in the window according to scroll-conservatively,
17668 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
17669
17670 (try_scrolling): When point is above the window, allow searching
17671 as far as scroll_max, or one screenful, to compute vertical
17672 distance from PT to the scroll margin position. This prevents
17673 try_scrolling from unnecessarily failing when
17674 scroll-conservatively is set to a value slightly larger than the
17675 window height. Clean up the case of PT below the margin at bottom
17676 of window: scroll_max can no longer be INT_MAX. When aggressive
17677 scrolling is in use, don't let point enter the opposite scroll
17678 margin as result of the scroll.
17679 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
17680 threshold of 100 lines for never-recentering scrolling.
17681
e4cc2dfc
JB
176822011-03-31 Juanma Barranquero <lekktu@gmail.com>
17683
17684 * dispextern.h (move_it_by_lines):
17685 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
17686 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
17687 (message_log_check_duplicate): Remove parameters `prev_bol' and
17688 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
17689 (redisplay_internal): Remove parameter `preserve_echo_area',
17690 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
17691
17692 * indent.c (Fvertical_motion):
17693 * window.c (window_scroll_pixel_based, Frecenter):
17694 Don't pass `need_y_p' to `move_it_by_lines'.
17695
1c470562
SM
176962011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
17697
44f230aa
SM
17698 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
17699 steal a few bits to be more compact.
17700 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
17701 Remove unneeded casts.
17702
1c470562
SM
17703 * bytecode.c (Fbyte_code): CAR and CDR can GC.
17704
888adce9
ZK
177052011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
17706
17707 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
17708 binding" message (bug#7967).
17709
f838ed7b
PE
177102011-03-30 Paul Eggert <eggert@cs.ucla.edu>
17711
77861b95
PE
17712 Fix more problems found by GCC 4.6.0's static checks.
17713
de6dbc14
PE
17714 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
17715 Remove unused local var.
17716
f838ed7b
PE
17717 * editfns.c (Fmessage_box): Remove unused local var.
17718
792c7b2b
PE
17719 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
17720 (note_mode_line_or_margin_highlight, note_mouse_highlight):
17721 Omit unused local vars.
c499e557 17722 * window.c (shrink_windows): Omit unused local var.
b01a1c29 17723 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
17724 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
17725 Omit unused local var.
17726
ba0165e1
PE
17727 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
17728 Don't assume string length fits in int.
32ad8845 17729 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 17730 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 17731
3c59b4c9
PE
17732 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
17733 instead of alloca (Bug#8344).
17734
a3eed478 17735 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 17736 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 17737
eb4d412d
PE
17738 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
17739
1658b401
PE
17740 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
17741 concerns.
17742
17743 * term.c (produce_glyphless_glyph): Remove unnecessary test.
17744
17745 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 17746
9a2c6e05
PE
17747 * keyboard.c (syms_of_keyboard): Use the same style as later
17748 in this function when indexing through an array. This also
17749 works around GCC bug 48267.
17750
03d0a109
PE
17751 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
17752
44f730c8
PE
17753 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
17754
fe75f926
PE
17755 * chartab.c (sub_char_table_ref_and_range): Redo for slight
17756 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
17757
ffa8c828
PE
17758 * keyboard.c, keyboard.h (num_input_events): Now size_t.
17759 This avoids undefined behavior on integer overflow, and is a bit
17760 more convenient anyway since it is compared to a size_t variable.
17761
c5101a77
PE
17762 Variadic C functions now count arguments with size_t, not int.
17763 This avoids an unnecessary limitation on 64-bit machines, which
17764 caused (substring ...) to crash on large vectors (Bug#8344).
17765 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
17766 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 17767 All variadic functions and their callers changed accordingly.
c5101a77
PE
17768 (struct gcpro.nvars): Now size_t, not int. All uses changed.
17769 * data.c (arith_driver, float_arith_driver): Likewise.
17770 * editfns.c (general_insert_function): Likewise.
17771 * eval.c (struct backtrace.nargs, interactive_p)
17772 (internal_condition_case_n, run_hook_with_args, apply_lambda)
17773 (funcall_lambda, mark_backtrace): Likewise.
17774 * fns.c (concat): Likewise.
17775 * frame.c (x_set_frame_parameters): Likewise.
17776 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
17777 0 if not found, not -1. All callers changed.
17778
dd3f25f7
PE
17779 * alloc.c (garbage_collect): Don't assume stack size fits in int.
17780 (stack_copy_size): Now size_t, not int.
17781 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
17782
461c2ab9
JB
177832011-03-28 Juanma Barranquero <lekktu@gmail.com>
17784
17785 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
17786 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17787 All callers changed.
17788
17789 * lisp.h (multibyte_char_to_unibyte):
17790 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
17791 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
17792 * character.h (CHAR_TO_BYTE8):
17793 * cmds.c (internal_self_insert):
17794 * editfns.c (general_insert_function):
17795 * keymap.c (push_key_description):
17796 * search.c (Freplace_match):
17797 * xdisp.c (message_dolog, set_message_1): All callers changed.
17798
f6d62986
SM
177992011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
17800
17801 * keyboard.c (safe_run_hook_funcall): New function.
17802 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
17803 don't set the hook to nil, but remove the offending function instead.
17804 (Qcommand_hook_internal): Remove, unused.
17805 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
17806 Vcommand_hook_internal.
17807
17808 * eval.c (enum run_hooks_condition): Remove.
17809 (funcall_nil, funcall_not): New functions.
17810 (run_hook_with_args): Call each function through a `funcall' argument.
17811 Remove `cond' argument, now redundant.
17812 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
17813 (Frun_hook_with_args_until_failure): Adjust accordingly.
17814 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
17815
1db5b1ad
JB
178162011-03-28 Juanma Barranquero <lekktu@gmail.com>
17817
17818 * dispextern.h (string_buffer_position): Remove declaration.
17819
17820 * print.c (strout): Remove parameter `multibyte', unused since
17821 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
17822
17823 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
17824 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
17825 All callers changed.
17826
17827 * w32.c (_wsa_errlist): Use braces for struct initializers.
17828
17829 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
17830 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
17831 All callers changed.
17832 (string_buffer_position): Likewise. Also, make static (it's never
17833 used outside xdisp.c).
17834 (cursor_row_p): Remove parameter `w', unused since
17835 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
17836 (decode_mode_spec): Remove parameter `precision', introduced during
17837 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
17838 All callers changed.
17839
5ffb62aa
JD
178402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17841
17842 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
17843
461c2ab9 178442011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
17845
17846 * nsterm.m (ns_menu_bar_is_hidden): New variable.
17847 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
17848 (ns_update_auto_hide_menu_bar): New functions.
17849 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
17850 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
17851 ns_constrain_all_frames.
17852 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
17853 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
17854
5c380ffb
JD
178552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17856
17857 * nsmenu.m (runDialogAt): Remove argument to timer_check.
17858
9af30bdf
GM
178592011-03-27 Glenn Morris <rgm@gnu.org>
17860
17861 * syssignal.h: Replace RETSIGTYPE with void.
17862 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
17863 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
17864 Replace SIGTYPE with void everywhere.
17865 * s/usg5-4-common.h (SIGTYPE): Remove definition.
17866 * s/template.h (SIGTYPE): Remove commented out definition.
17867
e2abce01
JB
178682011-03-26 Eli Zaretskii <eliz@gnu.org>
17869
17870 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
17871 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
17872
f868cd8a
JB
178732011-03-26 Juanma Barranquero <lekktu@gmail.com>
17874
59eb0929
JB
17875 * w32.c (read_unc_volume): Use parameter `henum', instead of
17876 global variable `wget_enum_handle'.
17877
17878 * keymap.c (describe_vector): Remove parameters `indices' and
17879 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
17880 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
17881
f868cd8a
JB
17882 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
17883
17884 * keyboard.c (timer_check): Remove parameter `do_it_now',
17885 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
17886 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
17887 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
17888
17889 * keyboard.c (read_char):
17890 * w32menu.c (w32_menu_display_help):
17891 * xmenu.c (show_help_event, menu_help_callback):
17892 Adjust calls to `show_help_echo'.
17893
17894 * gtkutil.c (xg_maybe_add_timer):
17895 * keyboard.c (readable_events):
17896 * process.c (wait_reading_process_output):
17897 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
17898
17899 * insdel.c (adjust_markers_gap_motion):
17900 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
17901 (gap_left, gap_right): Don't call it.
17902
2ecf6fdb
CY
179032011-03-25 Chong Yidong <cyd@stupidchicken.com>
17904
17905 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
17906 incurred during fontification.
17907
6b1f9ba4
JB
179082011-03-25 Juanma Barranquero <lekktu@gmail.com>
17909
17910 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
17911 (DEFVAR_PER_BUFFER): Don't pass it.
17912
17913 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
17914 (scrolling_window): Don't pass it.
17915
0f4a96b5
JB
179162011-03-25 Juanma Barranquero <lekktu@gmail.com>
17917
17918 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17919
17920 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17921 and `suffix'.
17922 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17923 of variables specific to SELinux and computation of `encoded_absname'.
17924
17925 * image.c (XPutPixel): Remove unused variable `height'.
17926
17927 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17928
17929 * unexw32.c (get_section_info): Remove unused variable `section'.
17930
17931 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17932 (system_process_attributes): Remove unused variable `sess'.
17933 (sys_read): Remove unused variable `err'.
17934
17935 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17936 (w32_wnd_proc): Remove unused variable `isdead'.
17937 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17938 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17939 (x_create_tip_frame): Remove unused variable `tem'.
17940
17941 * w32inevt.c (w32_console_read_socket):
17942 Remove unused variable `no_events'.
17943
17944 * w32term.c (x_draw_composite_glyph_string_foreground):
17945 Remove unused variable `width'.
17946
1149507c
JB
179472011-03-24 Juanma Barranquero <lekktu@gmail.com>
17948
17949 * w32term.c (x_set_glyph_string_clipping):
17950 Don't pass uninitialized region to CombineRgn.
17951
9c88f339
JB
179522011-03-23 Juanma Barranquero <lekktu@gmail.com>
17953
17954 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17955 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17956 (Fx_close_connection): Remove unused variable `i'.
17957
17958 * w32font.c (w32font_draw): Return number of glyphs.
17959 (w32font_open_internal): Remove unused variable `i'.
17960 (w32font_driver): Add missing initializer.
17961
17962 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17963 (fill_in_menu): Remove unused variable `items_added'.
17964
17965 * w32term.c (last_mouse_press_frame): Remove static global variable.
17966 (w32_clip_to_row): Remove unused variable `f'.
17967 (x_delete_terminal): Remove unused variable `i'.
17968
17969 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17970 (NOTHING): Remove unused static global variable.
17971 (uniscribe_check_otf): Remove unused variable `table'.
17972 (uniscribe_font_driver): Add missing initializers.
17973
dee091a3
JD
179742011-03-23 Julien Danjou <julien@danjou.info>
17975
17976 * term.c (Fsuspend_tty, Fresume_tty):
17977 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17978 * window.c (temp_output_buffer_show):
17979 * insdel.c (signal_before_change):
17980 * frame.c (Fhandle_switch_frame):
17981 * fileio.c (Fdo_auto_save):
17982 * emacs.c (Fkill_emacs):
17983 * editfns.c (save_excursion_restore):
17984 * cmds.c (internal_self_insert):
17985 * callint.c (Fcall_interactively):
17986 * buffer.c (Fkill_all_local_variables):
17987 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17988 Use Frun_hooks.
0f4a96b5 17989 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17990 unconditionally since it does the check itself.
dee091a3 17991
2c520ab5 179922011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17993
c9c49752
PE
17994 Fix more problems found by GCC 4.5.2's static checks.
17995
8abc3f12
PE
17996 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17997 the first time through the loop, since we know p0 < p1 then.
17998 This also avoids a gcc -Wstrict-overflow warning.
17999
a2d26660
PE
18000 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
18001 leading to a memory leak, possible in functions like
18002 load_charset_map_from_file that can allocate an unbounded number
b12ef411 18003 of objects (Bug#8318).
a2d26660 18004
916c72e9
PE
18005 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
18006 that could (at least in theory) be that large.
18007
19ab8a18
PE
18008 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
18009 This is less likely to overflow, and avoids undefined behavior if
18010 overflow does occur. All callers changed. Use strtoul to scan
18011 for the unsigned long integer.
b7cbbd6f
PE
18012 (pint2hrstr): Simplify and tune code slightly.
18013 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 18014
f0641eff
PE
18015 * scroll.c (do_scrolling): Work around GCC bug 48228.
18016 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
18017
7f650bb9
PE
18018 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
18019 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
18020 (validate_x_resource_name): Simplify count usage.
18021 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 18022
37dd57d1
PE
18023 * fileio.c (Fcopy_file): Report error if fchown or fchmod
18024 fail (Bug#8306).
81e56e61 18025
699979fc 18026 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 18027
401bf9b4
PE
18028 * process.c (Fmake_network_process): Use socklen_t, not int,
18029 where POSIX says socklen_t is required in portable programs.
18030 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 18031 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
18032 (Fmake_network_process, server_accept_connection):
18033 (wait_reading_process_output, read_process_output):
18034 Likewise.
18035
b93aacde
PE
18036 * process.c: Rename or move locals to avoid shadowing.
18037 (list_processes_1, Fmake_network_process):
18038 (read_process_output_error_handler, exec_sentinel_error_handler):
18039 Rename or move locals.
4dc343ee 18040 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 18041 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 18042 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 18043 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 18044 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 18045
af8a867c 18046 Make tparam.h and terminfo.c consistent.
44f230aa
SM
18047 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
18048 Include tparam.h instead, since it declares them.
af8a867c
PE
18049 * cm.h (PC): Remove extern decl; tparam.h now does this.
18050 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
18051 * terminfo.c: Include tparam.h, to check interfaces.
18052 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
18053 (tparam): Adjust signature to match interface in tparam.h;
18054 this removes some undefined behavior. Check that outstring and len
18055 are zero, which they always are with Emacs.
18056 * tparam.h (PC, BC, UP): New extern decls.
18057
0248044d 18058 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 18059 (xftfont_open): Rename locals to avoid shadowing.
0248044d 18060
8ff096c1 18061 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
18062 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
18063 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 18064 (ftfont_list): Remove unused local.
49eaafba
PE
18065 (get_adstyle_property, ftfont_pattern_entity):
18066 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
18067 Rename locals to avoid shadowing.
8ff096c1 18068
e2be39f6
PE
18069 * xfont.c (xfont_list_family): Mark var as initialized.
18070
c9735e30
PE
18071 * xml.c (make_dom): Now static.
18072
8f5201ae
PE
18073 * composite.c (composition_compute_stop_pos): Rename local to
18074 avoid shadowing.
b246f932
PE
18075 (composition_reseat_it): Remove unused locals.
18076 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 18077 (composition_update_it): Mark var as initialized.
11b61122
PE
18078 (find_automatic_composition): Mark vars as initialized,
18079 with a FIXME (Bug#8290).
8f5201ae 18080
760fbc2c
PE
18081 character.h: Rename locals to avoid shadowing.
18082 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
18083 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
18084 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
18085 (BUF_DEC_POS): Be more systematic about renaming local temporaries
18086 to avoid shadowing.
18087
ff08eb85
PE
18088 * textprop.c (property_change_between_p): Remove; unused.
18089
fc7bf025
PE
18090 * intervals.c (interval_start_pos): Now static.
18091
235d7abc
PE
18092 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
18093
44f230aa
SM
18094 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
18095 Rename locals to avoid shadowing.
3e7d6594 18096
50060332
PE
18097 * sound.c (wav_play, au_play, Fplay_sound_internal):
18098 Fix pointer signedness.
d01f234b 18099 (alsa_choose_format): Remove unused local var.
c83b8872
PE
18100 (wav_play): Initialize a variable to 0, to prevent undefined
18101 behavior (Bug#8278).
50060332 18102
c4fc4e30
PE
18103 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
18104
918436ed
PE
18105 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
18106
c939f91b
PE
18107 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
18108 clobbering (Bug#8298).
b9c7f648
PE
18109 * sysdep.c (sys_subshell): Likewise.
18110 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 18111
6bd8c144
PE
18112 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
18113 This should get cleaned up, so that child_setup has the
18114 same signature on all platforms.
18115
7710357c 18116 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 18117 (relocate_fd): Rename locals to avoid shadowing.
7710357c 18118
c59da222
CY
181192011-03-22 Chong Yidong <cyd@stupidchicken.com>
18120
18121 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
18122 not to be necessary, and produces flickering.
18123
66b87493
GM
181242011-03-20 Glenn Morris <rgm@gnu.org>
18125
18126 * config.in: Remove file.
18127
45b6f6d5
JB
181282011-03-20 Juanma Barranquero <lekktu@gmail.com>
18129
18130 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
18131 are now in src/globals.h.
18132 (syms_of_minibuf): Remove spurious & from previous change.
18133
cd394be1 181342011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
18135
18136 * minibuf.c (completing-read-function): New variable.
18137 (completing-read-default): Rename from completing-read.
18138 (completing-read): Call completing-read-function.
18139
b14e3e21
CY
181402011-03-19 Juanma Barranquero <lekktu@gmail.com>
18141
18142 * xfaces.c (Fx_load_color_file):
18143 Read color file from absolute filename (bug#8250).
18144
f2b726e6
JB
181452011-03-19 Juanma Barranquero <lekktu@gmail.com>
18146
18147 * makefile.w32-in: Update dependencies.
18148
09f6ff02
EZ
181492011-03-17 Eli Zaretskii <eliz@gnu.org>
18150
18151 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
18152
29a6015a
PE
181532011-03-17 Paul Eggert <eggert@cs.ucla.edu>
18154
a3a6c54e
PE
18155 Fix more problems found by GCC 4.5.2's static checks.
18156
b766f867
PE
18157 * process.c (make_serial_process_unwind, send_process_trap):
18158 (sigchld_handler): Now static.
18159
be02381c
PE
18160 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
18161 That way, the code declares only the vars that it needs.
18162 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
18163 * s/cygwin.h (PTY_ITERATION): Likewise.
18164 * s/darwin.h (PTY_ITERATION): Likewise.
18165 * s/gnu-linux.h (PTY_ITERATION): Likewise.
18166
57048744
PE
18167 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
18168 * process.c (allocate_pty): Don't declare stb unless it's needed.
18169
7914961c 18170 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
18171 (CONSTANTLIM): Remove; unused.
18172 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
18173 Define only if needed.
7914961c 18174
b3967b18
PE
18175 * unexelf.c (unexec): Name an expression,
18176 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
18177 Use a different way to cause a compilation error if anyone uses
18178 n rather than nn, a way that does not involve shadowing.
73366a00 18179 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 18180
29a6015a
PE
18181 * deps.mk (unexalpha.o): Remove; unused.
18182
43cfc33e 18183 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 18184 * unexec.h: New file.
ce701a33
PE
18185 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
18186 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
18187 Depend on unexec.h.
18188 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
18189 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
18190 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 18191 Change as necessary to match prototype in unexec.h.
ce701a33 18192
01f44d5a
PE
18193 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
18194 shadowing.
4f63c6bb 18195 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 18196
a6670b0b
PE
18197 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
18198 Rename locals to avoid shadowing.
18199
cef2010d 18200 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 18201 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 18202
d4d7173a
PE
18203 * print.c (Fredirect_debugging_output): Fix pointer signedess.
18204
f08b802a
PE
18205 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
18206 warning when compiling print.c.
18207
3ddb0639
PE
18208 * font.c (font_unparse_fcname): Abort in an "impossible" situation
18209 instead of using an uninitialized var.
5ad03b97 18210 (font_sort_entities): Mark var as initialized.
3ddb0639 18211
170a2692
PE
18212 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
18213
e663c700
PE
18214 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
18215 pointers to constants.
89bc529a 18216 (font_parse_fcname): Remove unused vars.
7b81e2d0 18217 (font_delete_unmatched): Now static.
ea838e10 18218 (font_get_spec): Remove; unused.
13a547c6
PE
18219 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
18220 (font_update_drivers, Ffont_get_glyphs, font_add_log):
18221 Rename or move locals to avoid shadowing.
e663c700 18222
2a80c887 18223 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 18224 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 18225
1384fa33 18226 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 18227 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 18228
8b2c52e9
PE
18229 * alloc.c (mark_backtrace): Move decl from here ...
18230 * lisp.h: ... to here, so that it can be checked.
18231
475545b5 18232 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 18233 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
18234 (lisp_indirect_variable): Name an expression,
18235 to avoid gcc -Wbad-function-cast warning.
1faed8ae 18236 (Fdefvar): Rename locals to avoid shadowing.
475545b5 18237
b1349114 18238 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 18239 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 18240 Use const pointer when appropriate.
b1349114 18241
a2928364
PE
18242 * lisp.h (get_system_name, get_operating_system_release):
18243 Move decls here, to check interfaces.
18244 * process.c (get_operating_system_release): Move decl to lisp.h.
18245 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
18246 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
18247 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
18248 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
18249 (Fformat_time_string, Fencode_time, Finsert_char):
18250 (Ftranslate_region_internal, Fformat):
18251 Rename or remove local vars to avoid shadowing.
9710023e 18252 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 18253
a415e694
PE
18254 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
18255 avoid shadowing.
18256
8ef4622d
PE
18257 * lisp.h (eassert): Check that the argument compiles, even if
18258 ENABLE_CHECKING is not defined.
18259
946f9a5b
PE
18260 * data.c (Findirect_variable): Name an expression, to avoid
18261 gcc -Wbad-function-cast warning.
112396d6 18262 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 18263 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
18264 (Fmake_variable_buffer_local, Fmake_local_variable):
18265 Mark variables as initialized.
52746918 18266 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 18267
e5aab7e7 18268 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
18269 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
18270 Rename locals to avoid shadowing.
dff45157
PE
18271 (mark_stack): Move local variables into the #ifdef region where
18272 they're used.
7bc26fdb
PE
18273 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
18274 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
18275 needed otherwise.
18276 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
18277 (GC_STRING_CHARS): Remove; not used.
d40d4be1 18278 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 18279
e5aab7e7
PE
18280 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
18281 avoids undefined behavior in theory.
18282
4da60324
PE
18283 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
18284
88043301
PE
18285 Use functions, not macros, for up- and down-casing (Bug#8254).
18286 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
18287 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
18288 to use the following functions instead of these macros.
18289 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
18290 EMACS_INT, since callers assume the returned value fits in int.
18291 (upcase1): Likewise, for UPCASE_TABLE.
18292 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 18293 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 18294 the race-condition problem in the old DOWNCASE.
88043301 18295
19ed5445
PE
18296 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
18297 Rename locals to avoid shadowing.
18298 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
18299 (regex_compile, re_search_2, re_match_2_internal):
18300 Remove unused local vars.
952db0d7
PE
18301 (FREE_VAR): Rewrite so as not to use empty "else",
18302 which gcc can warn about.
da053e48 18303 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
18304 (RETALLOC_IF): Define only if needed.
18305 (WORDCHAR_P): Likewise. This one is never needed, but is used
18306 only in a comment talking about a compiler bug, so put inside
18307 the #if 0 of that comment.
18308 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
18309 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
18310 Remove; unused.
19ed5445 18311
1f3561e4 18312 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
18313 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
18314 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 18315
ded6f8f7
PE
18316 * search.c (simple_search): Remove unused var.
18317
dbd37a95
PE
18318 * dired.c (compile_pattern): Move decl from here ...
18319 * lisp.h: ... to here, so that it can be checked.
18320 (struct re_registers): New forward decl.
18321
7e47afad
PE
18322 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
18323
85f24f61
PE
18324 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
18325 All uses changed.
18326 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
18327 Rename locals to avoid shadowing.
5671df8f 18328 (Fvertical_motion): Mark locals as initialized.
85f24f61 18329
181aa2be 18330 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 18331 (casify_region): Mark local as initialized.
181aa2be 18332
930d429c
PE
18333 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
18334
7082eac6
PE
18335 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
18336 New macros, so that the caller can use some names other than
18337 gcpro1, gcpro2, etc.
18338 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
18339 of the new macros.
18340 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
18341 argument, for consistency with GCPRO2_VAR, etc: it is now the
18342 prefix of the variable, not the variable itself. All uses
18343 changed.
38b2c076
PE
18344 * dired.c (directory_files_internal, file_name_completion):
18345 Rename locals to avoid shadowing.
18346
15206ed9
PE
18347 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
18348 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
18349 dired.c's scmp function, had undefined behavior.
18350 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
18351 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
18352 * buffer.h: ... to here, because these macros use current_buffer,
18353 and the new implementation with inline functions needs to have
18354 current_buffer in scope now, rather than later when the macros
18355 are used.
18356 (downcase, upcase1): New static inline functions.
18357 (DOWNCASE, UPCASE1): Reimplement using these functions.
18358 This avoids undefined behavior in expressions like
18359 DOWNCASE (x) == DOWNCASE (y), which previously suffered
18360 from race conditions in accessing the global variables
18361 case_temp1 and case_temp2.
18362 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
18363 * lisp.h (case_temp1, case_temp2): Remove their decls.
18364 * character.h (ASCII_CHAR_P): Move from here ...
18365 * lisp.h: ... to here, so that the inline functions mentioned
18366 above can use them.
18367
4a6bea26
PE
18368 * dired.c (directory_files_internal_unwind): Now static.
18369
f14b7e14
PE
18370 * fileio.c (file_name_as_directory, directory_file_name):
18371 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
18372 Now static.
2893f146
PE
18373 (file_name_as_directory): Use const pointers when appropriate.
18374 (Fexpand_file_name): Likewise. In particular, newdir might
18375 point at constant storage, so make it a const pointer.
fd4ead52 18376 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
18377 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
18378 signedness issues.
f839df0c
PE
18379 (Fset_file_times, Finsert_file_contents, auto_save_error):
18380 Rename locals to avoid shadowing.
f14b7e14 18381
5716756e 18382 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
18383 (Ftry_completion, Fall_completions): Rename or remove locals
18384 to avoid shadowing.
5716756e 18385
b4c3046a
PE
18386 * marker.c (bytepos_to_charpos): Remove; unused.
18387
b45db522
PE
18388 * lisp.h (verify_bytepos, count_markers): New decls,
18389 so that gcc does not warn that these functions aren't declared.
18390
85876d07
PE
18391 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
18392 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 18393 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 18394 (copy_text): Remove unused local var.
85876d07 18395
03d78a21 18396 * filelock.c (within_one_second): Now static.
b3dd38ab 18397 (lock_file_1): Rename local to avoid shadowing.
03d78a21 18398
5df8f01b
PE
18399 * buffer.c (fix_overlays_before): Mark locals as initialized.
18400 (fix_start_end_in_overlays): Likewise. This function should be
18401 simplified by using pointers-to-pointers, but that's a different
18402 matter.
b1d876f1 18403 (switch_to_buffer_1): Now static.
8f54f30a
PE
18404 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
18405 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 18406
a70072c9 18407 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 18408 Fix pointer signedness issue.
edced198
PE
18409 (sys_subshell): Mark local as volatile if checking for lint,
18410 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 18411 (MAXPATHLEN): Define only if needed.
a70072c9 18412
a0977c44
PE
18413 * process.c (serial_open, serial_configure): Move decls from here ...
18414 * systty.h: ... to here, so that they can be checked.
18415
a884fdcc
PE
18416 * fns.c (get_random, seed_random): Move extern decls from here ...
18417 * lisp.h: ... to here, so that they can be checked.
18418
604efe86 18419 * sysdep.c (reset_io): Now static.
b8950c94 18420 (wait_for_termination_signal): Remove; unused.
604efe86 18421
38fc62d9
PE
18422 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
18423 (copy_keymap_item, append_key, push_text_char_description):
18424 Now static.
1004a21a 18425 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 18426 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
18427 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
18428 (describe_map_tree):
18429 Rename locals to avoid shadowing.
38fc62d9 18430
2f2650da
PE
18431 * keyboard.c: Declare functions static if they are not used elsewhere.
18432 (echo_char, echo_dash, cmd_error, top_level_2):
18433 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
18434 (read_char, kbd_buffer_get_event, make_lispy_position):
18435 (make_lispy_event, make_lispy_movement, apply_modifiers):
18436 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
18437 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
18438 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 18439 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 18440 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 18441
a053e86c 18442 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
18443 (mark_kboards): Move decl here ...
18444 * alloc.c (mark_kboards): ... from here.
a053e86c 18445
4752793e
PE
18446 * lisp.h (force_auto_save_soon): New decl.
18447
74f10ca7 18448 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
18449 (DEFINE_DUMMY_FUNCTION): New macro.
18450 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
18451 Use it.
c03cd23f
PE
18452 (main): Add casts to avoid warnings
18453 if GCC considers string literals to be constants.
74f10ca7 18454
022e70d4
PE
18455 * lisp.h (fatal_error_signal): Add decl, since it's exported.
18456
59d6fe83
PE
18457 * dbusbind.c: Pointer signedness fixes.
18458 (xd_signature, xd_append_arg, xd_initialize):
18459 (Fdbus_call_method, Fdbus_call_method_asynchronously):
18460 (Fdbus_method_return_internal, Fdbus_method_error_internal):
18461 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
18462 (Fdbus_register_signal): Use SSDATA when the context wants char *.
18463
78320123
PE
18464 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
18465 if GCC considers string literals to be constants.
49cebcca 18466 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 18467
35ac2a97
SM
184682011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
18469
fb103ca9
SM
18470 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
18471 (print_preprocess, print_object): New macro to fix last change.
18472
35ac2a97
SM
18473 * print.c (print_preprocess): Don't forget font objects.
18474
62973b41
JB
184752011-03-16 Juanma Barranquero <lekktu@gmail.com>
18476
18477 * emacs.c (USAGE3): Doc fixes.
18478
0e48bb22
AS
184792011-03-15 Andreas Schwab <schwab@linux-m68k.org>
18480
18481 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
18482 structure.
18483
7684e57b
JB
184842011-03-14 Juanma Barranquero <lekktu@gmail.com>
18485
18486 * lisp.h (VWindow_system, Qfile_name_history):
18487 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
18488 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
18489 (w32_system_caret_x, w32_system_caret_y): Declare extern.
18490
18491 * w32select.c: Don't #include "keyboard.h".
c96bbc66 18492 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
18493
18494 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
18495 * w32console.c (detect_input_pending, read_input_pending)
18496 (encode_terminal_code):
18497 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
18498 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
18499 (w32_system_caret_y, Qfile_name_history):
18500 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
18501 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
18502 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
18503 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
18504 * w32proc.c (Qlocal, report_file_error):
18505 * w32term.c (Vwindow_system, updating_frame):
18506 * w32uniscribe.c (initialized, uniscribe_font_driver):
18507 Remove unneeded extern declarations.
18508
2aa46d6c
CY
185092011-03-14 Chong Yidong <cyd@stupidchicken.com>
18510
c96bbc66 18511 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 18512
cffc6f3b
CY
185132011-03-13 Chong Yidong <cyd@stupidchicken.com>
18514
18515 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
18516 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
18517 These macros can no longer be used for assignment.
18518
44f230aa
SM
18519 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
18520 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
18521 (record_buffer_markers, fetch_buffer_markers): New functions for
18522 recording and fetching special buffer markers.
18523 (set_buffer_internal_1, set_buffer_temp): Use them.
18524
18525 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
18526
18527 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
18528
18529 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
18530 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
18531
18532 * xdisp.c (hscroll_window_tree):
18533 (reconsider_clip_changes): Use PT instead of BUF_PT.
18534
d251f04b
EZ
185352011-03-13 Eli Zaretskii <eliz@gnu.org>
18536
18537 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
18538 $(EMACS_ROOT)/lib/intprops.h.
18539
f0c77cd1
PE
185402011-03-13 Paul Eggert <eggert@cs.ucla.edu>
18541
3eca4629
PE
18542 Fix more problems found by GCC 4.5.2's static checks.
18543
7c86ee98
PE
18544 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
18545 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
18546 (xg_free_frame_widgets): Make it clear that a local variable is
18547 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
18548 (gdk_window_get_screen): Make it clear that this macro is needed
18549 only if USE_GTK_TOOLTIP.
1e5524e7
PE
18550 (int_gtk_range_get_value): New function, which avoids a diagnostic
18551 from gcc -Wbad-function-cast.
18552 (xg_set_toolkit_scroll_bar_thumb): Use it.
18553 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
18554 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
18555 (get_utf8_string, xg_get_file_with_chooser):
18556 Rename locals to avoid shadowing.
18557 (create_dialog): Move locals to avoid shadowing.
7c86ee98 18558
41729b81
PE
18559 * xgselect.c (xg_select): Remove unused var.
18560
f0c77cd1
PE
18561 * image.c (four_corners_best): Mark locals as initialized.
18562 (gif_load): Initialize transparent_p to zero (Bug#8238).
18563 Mark another local as initialized.
ec6cf4c6 18564 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 18565
ce0ad53d 18566 * image.c (clear_image_cache): Now static.
d5d5a617 18567 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 18568 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
18569 (x_edge_detection): Remove unnecessary cast that
18570 gcc -Wbad-function-cast diagnoses.
2037898d 18571 (gif_load): Fix pointer signedness.
6ae141d6
PE
18572 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
18573 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 18574
33383987 185752011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 18576
d32df629
PE
18577 Improve quality of tests for time stamp overflow.
18578 For example, without this patch (encode-time 0 0 0 1 1
18579 1152921504606846976) returns the obviously-bogus value (-948597
18580 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
18581 reports time overflow. See
18582 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
18583 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
18584 * editfns.c: Include limits.h and intprops.h.
18585 (TIME_T_MIN, TIME_T_MAX): New macros.
18586 (time_overflow): Move earlier, to before first use.
18587 (hi_time, lo_time): New functions, for an accurate test for
18588 out-of-range times.
18589 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
18590 (Fget_internal_run_time): Don't assume time_t fits in int.
18591 (make_time): Use list2 instead of Fcons twice.
18592 (Fdecode_time): More accurate test for out-of-range times.
18593 (check_tm_member): New function.
18594 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
18595 (lisp_time_argument): Don't rely on undefined left-shift and
18596 right-shift behavior when checking for time stamp overflow.
8be6f318 18597
fe31d94c
PE
18598 * editfns.c (time_overflow): New function, refactoring common code.
18599 (Fformat_time_string, Fdecode_time, Fencode_time):
18600 (Fcurrent_time_string): Use it.
18601
8be6f318
PE
18602 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
18603 * dired.c (make_time): Move to ...
18604 * editfns.c (make_time): ... here.
18605 * systime.h: Note the move.
18606
09d9db2c 186072011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 18608
126bc0dc
YM
18609 * fringe.c (update_window_fringes): Remove unused variables.
18610
c47cbdfd
YM
18611 * unexmacosx.c (copy_data_segment): Also copy __got section.
18612 (Bug#8223)
18613
7ac80be9
EZ
186142011-03-12 Eli Zaretskii <eliz@gnu.org>
18615
c96bbc66 18616 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
18617 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
18618 Constify `char *' arguments and their references according to
18619 prototypes in tparam.h.
18620
ecb0f94d 18621 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 18622
7ac80be9
EZ
18623 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
18624 Adapt all references accordingly.
18625
18626 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
18627
ef1fd07e
TT
186282011-03-11 Tom Tromey <tromey@redhat.com>
18629
18630 * buffer.c (syms_of_buffer): Remove obsolete comment.
18631
7ef4b50c
EZ
186322011-03-11 Eli Zaretskii <eliz@gnu.org>
18633
18634 * termhooks.h (encode_terminal_code): Declare prototype.
18635
18636 * msdos.c (encode_terminal_code): Don't declare prototype.
18637
18638 * term.c (encode_terminal_code): Now external again, used by
18639 w32console.c and msdos.c.
18640
44f230aa
SM
18641 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
18642 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 18643
4b1ec863 186442011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 18645
1714f52b 18646 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 18647
4b1ec863
PE
18648 * fringe.c (update_window_fringes): Mark locals as initialized
18649 (Bug#8227).
18650 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 18651
524c7aa6
PE
18652 * alloc.c (mark_fringe_data): Move decl from here ...
18653 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
18654 to check its interface.
18655 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
18656
a5c0af81 18657 * fontset.c (free_realized_fontset): Now static.
7519b8cd 18658 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 18659 (fontset_font): Mark local as initialized.
a9a06e0b 18660 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 18661
b4716021
PE
18662 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
18663
811e9bac 18664 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 18665 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
18666 (x_own_selection, Fx_disown_selection_internal): Rename locals
18667 to avoid shadowing.
18668 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 18669
7e3ab302
PE
18670 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
18671 so that the caller can use some name other than gcpro1.
18672 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
18673 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18674 (Fx_backspace_delete_keys_p):
18675 Use them to avoid shadowing, and rename vars to avoid shadowing.
18676 (x_decode_color, x_set_name, x_window): Now static.
6b437900 18677 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 18678 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
18679 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
18680 Remove unused locals.
7e3ab302
PE
18681 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
18682 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
18683 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
18684 macros.
f78faa98 18685
e2b13473
PE
18686 * xterm.h (x_mouse_leave): New decl.
18687
77f23912
PE
18688 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
18689 Remove unused functions.
cdf4ba58
PE
18690 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
18691 (x_calc_absolute_position): Now static.
7411c686 18692 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 18693 Don't declare local "event" unless it's used.
ed7bf3a5
PE
18694 (x_iconify_frame, x_free_frame_resources): Don't declare locals
18695 unless they are used.
38d0b34a
PE
18696 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
18697 (x_fatal_error_signal): Remove; not used.
a6067996
PE
18698 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
18699 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
18700 (x_error_catcher, x_connection_closed, x_error_handler):
18701 (x_error_quitter, xembed_send_message, x_iconify_frame):
18702 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 18703 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 18704 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 18705
44f230aa
SM
18706 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
18707 Rename or move locals to avoid shadowing.
6b463e58 18708 (tty_defined_color, merge_face_heights): Now static.
5967d051 18709 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
18710 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
18711 does not deduce is never used uninitialized.
73719eba
PE
18712 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
18713 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 18714
426994c3 18715 * terminal.c (store_terminal_param): Now static.
5489860b 18716
032f1620 18717 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 18718 (set_frame_menubar): Remove unused local.
d4323972 18719 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
18720 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
18721 since they might point to immutable storage.
281585b0
PE
18722 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
18723 since it's unused otherwise.
032f1620 18724
367c19e5 18725 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 18726 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
18727 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
18728 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 18729 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
18730 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
18731 does not deduce are never used uninitialized.
70739cbe 18732
07b48fa9
PE
18733 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
18734
8868a238 18735 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
18736 * window.c (window_loop, size_window):
18737 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 18738
7e5cf297 18739 * window.c (display_buffer): Now static.
d6550a9f
PE
18740 (size_window): Mark variables that gcc -Wuninitialized
18741 does not deduce are never used uninitialized.
a586633d
PE
18742 * window.h (check_all_windows): New decl, to forestall
18743 gcc -Wmissing-prototypes diagnostic.
5b555da1 18744 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 18745
f6095868
PE
18746 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
18747 shadowing.
18748 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
18749 Include <limits.h>.
18750 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
18751 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
18752 (load_charset_map): Mark variables that gcc -Wuninitialized
18753 does not deduce are never used uninitialized.
53df7c11 18754 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 18755
f38b440c
PE
18756 * coding.c (coding_set_source, coding_set_destination):
18757 Use "else { /* comment */ }" rather than "else /* comment */;"
18758 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
18759 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
18760 a block, when the outer 'i' will do.
18761 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
18762 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
18763 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
18764 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
18765 (Fdecode_sjis_char, Fdefine_coding_system_internal):
18766 Rename locals to avoid shadowing.
18767 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
18768 * coding.c (emacs_mule_char, encode_invocation_designation):
18769 Now static, since they're not used elsewhere.
413bb2db 18770 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 18771 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
18772 (decode_coding_emacs_mule): Mark variables that gcc
18773 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
18774 (detect_coding_iso_2022): Initialize a local variable that might
18775 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 18776 this initialization is needed. (Bug#8211)
5f58e762
PE
18777 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
18778 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
18779 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
18780 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
18781 Remove unused macros.
f38b440c 18782
232b38b9 18783 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 18784 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 18785 * character.c (string_count_byte8): Likewise.
232b38b9 18786
fb90da1b
PE
18787 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
18788 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
18789
fb93dbc2
PE
18790 * chartab.c (copy_sub_char_table): Now static, since it's not used
18791 elsewhere.
5c156ace
PE
18792 (sub_char_table_ref_and_range, char_table_ref_and_range):
18793 Rename locals to avoid shadowing.
bbcd0949 18794 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 18795
7d3b3862 18796 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 18797 (BIDI_BOB): Remove unused macro.
7d3b3862 18798
6be7d3da
PE
18799 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
18800 deduce are never used uninitialized.
c2ed9c8b 18801 * term.c (encode_terminal_code): Likewise.
6be7d3da 18802
75f8807f 18803 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 18804
50938595
PE
18805 * tparam.h: New file.
18806 * term.c, tparam.h: Include it.
18807 * deps.mk (term.o, tparam.o): Depend on tparam.h.
18808 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
18809 Move these decls to tparam.h, and make them agree with what
18810 is actually in tparam.c. The previous trick of using incompatible
18811 decls in different modules does not conform to the C standard.
18812 All callers of tparam changed to use tparam's actual API.
18813 * tparam.c (tparam1, tparam, tgoto):
18814 Use const pointers where appropriate.
18815
fbceeba2
PE
18816 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
18817 * cm.h (struct cm): Likewise.
18818 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
18819 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
18820 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
18821 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
18822 (turn_on_face, init_tty): Likewise.
18823 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 18824
7f3f1250
PE
18825 * term.c (term_mouse_position): Rename local to avoid shadowing.
18826
e6ca6543
PE
18827 * alloc.c (mark_ttys): Move decl from here ...
18828 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
18829
c40f8d15
AS
188302011-03-11 Andreas Schwab <schwab@linux-m68k.org>
18831
18832 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
18833
cfe0661d
JB
188342011-03-09 Juanma Barranquero <lekktu@gmail.com>
18835
18836 * search.c (compile_pattern_1): Remove argument regp, unused since
18837 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
18838 (compile_pattern): Don't pass it.
18839
0afb4571
J
188402011-03-08 Jan Djärv <jan.h.d@swipnet.se>
18841
18842 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
18843 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
18844 for ! HAVE_GTK3.
18845 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
18846
18847 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
18848
18849 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
18850 gdk_window_get_screen, gdk_window_get_geometry,
18851 gdk_x11_window_lookup_for_display and GDK_KEY_g.
18852 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
18853 (xg_get_pixbuf_from_pixmap): New function.
18854 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
18855 to Pixmap, take frame as parameter, remove GdkColormap parameter.
18856 Call xg_get_pixbuf_from_pixmap instead of
18857 gdk_pixbuf_get_from_drawable.
18858 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
18859 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
18860 (xg_check_special_colors): Use GtkStyleContext and its functions
18861 for HAVE_GTK3.
18862 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
18863 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
18864 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
18865 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
18866 Call gtk_widget_get_preferred_size.
0afb4571
J
18867 (xg_frame_resized): gdk_window_get_geometry only takes 5
18868 parameters.
44f230aa
SM
18869 (xg_win_to_widget, xg_event_is_for_menubar):
18870 Call gdk_x11_window_lookup_for_display.
0afb4571
J
18871 (xg_set_widget_bg): New function.
18872 (delete_cb): New function.
895009e1 18873 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 18874 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
18875 (xg_set_background_color): Call xg_set_widget_bg.
18876 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
18877 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
18878 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
18879 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
18880 if ! HAVE_GTK3.
18881 (update_frame_tool_bar): Call gtk_widget_hide.
18882 (xg_initialize): Use GDK_KEY_g.
18883
18884 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
18885 if ! HAVE_GTK3
18886 (x_session_initialize): Call gdk_x11_set_sm_client_id.
18887
18888 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
18889 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
18890 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
18891
1c2cc4ef
JB
188922011-03-08 Juanma Barranquero <lekktu@gmail.com>
18893
18894 * w32xfns.c (select_palette): Check success of RealizePalette against
18895 GDI_ERROR, not zero.
18896
33383987 18897See ChangeLog.11 for earlier changes.
aac0c6e3
MR
18898
18899;; Local Variables:
18900;; coding: utf-8
aac0c6e3
MR
18901;; End:
18902
2f097256 18903 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
18904
18905 This file is part of GNU Emacs.
18906
18907 GNU Emacs is free software: you can redistribute it and/or modify
18908 it under the terms of the GNU General Public License as published by
18909 the Free Software Foundation, either version 3 of the License, or
18910 (at your option) any later version.
18911
18912 GNU Emacs is distributed in the hope that it will be useful,
18913 but WITHOUT ANY WARRANTY; without even the implied warranty of
18914 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18915 GNU General Public License for more details.
18916
18917 You should have received a copy of the GNU General Public License
18918 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.