Merge from mainline.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6307db39
PE
12011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4
f3d4e0a4
CY
52011-05-22 Chong Yidong <cyd@stupidchicken.com>
6
7 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8
4d8ade89
YM
92011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10
11 * dispnew.c (scrolling_window): Don't exclude the case that the
12 last enabled row in the desired matrix touches the bottom boundary.
13
32078c8d
GM
142011-05-21 Glenn Morris <rgm@gnu.org>
15
16 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
17 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
18 and add some more files.
32078c8d 19
7285dc67
EZ
202011-05-20 Eli Zaretskii <eliz@gnu.org>
21
22 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
23 report_file_error introduced by the change from 2011-05-07.
24
89d1bd22
PE
252011-05-20 Paul Eggert <eggert@cs.ucla.edu>
26
27 * systime.h (Time): Define only if emacs is defined.
28 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
29 where the include path doesn't have X11/X.h by default. See
30 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
31
e23640bb 322011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
33
34 * composite.c (find_automatic_composition): Fix previous change.
35
b9704ad9
GM
362011-05-20 Glenn Morris <rgm@gnu.org>
37
38 * lisp.mk: New file, split from Makefile.in.
39 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
40 (shortlisp): Remove.
41 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
42
4a720484
GM
432011-05-19 Glenn Morris <rgm@gnu.org>
44
45 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
46 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
47 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
48 (lisp): Set the order to that of loadup.el.
49 (shortlisp): Make it a copy of $lisp.
50 (SOME_MACHINE_LISP): Remove.
51 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
52 Use just $shortlisp, not $SOME_MACHINE_LISP too.
53
a28d4396
KH
542011-05-18 Kenichi Handa <handa@m17n.org>
55
56 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
57 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
58 (find_automatic_composition): Mostly rewrite for efficiency.
59
a2b1fa8e
JB
602011-05-18 Juanma Barranquero <lekktu@gmail.com>
61
62 * makefile.w32-in: Update dependencies.
63
8e1f5610
CS
642011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
65
66 * menu.c: Include limits.h (fixes the MS-Windows build broken by
67 revision 104625).
68
7025ee00 692011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 70
cdfa6eab
PE
71 Fix some integer overflow issues, such as string length overflow.
72
06d6db33
PE
73 * insdel.c (count_size_as_multibyte): Check for string overflow.
74
2b4560a8
PE
75 * character.c (lisp_string_width): Check for string overflow.
76 Use EMACS_INT, not int, for string indexes and lengths; in
77 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
78 the resulting string length overflows an EMACS_INT; instead,
79 report a string overflow if no precision given. When checking for
80 precision exhaustion, use a check that cannot possibly have
81 integer overflow. (Bug#8675)
82 * character.h (lisp_string_width): Adjust to new signature.
83
cb93f9be
PE
84 * alloc.c (string_overflow): New function.
85 (Fmake_string): Use it. This doesn't change behavior, but saves
86 a few bytes and will simplify future changes.
87 * character.c (string_escape_byte8): Likewise.
88 * lisp.h (string_overflow): New decl.
89
1a1f3366
PE
90 Fixups, following up to the user-interface timestamp change.
91 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
92 for UI timestamps, instead of unsigned long.
9fbd6841
PE
93 * msdos.c (mouse_get_pos): Likewise.
94 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
95 * w32gui.h (Time): Define by including "systime.h" rather than by
96 declaring it ourselves. (Bug#8664)
97
d4e3e4d3
PE
98 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
99 * image.c (clear_image_cache): Likewise.
100
f6a24d19
PE
101 * term.c (term_mouse_position): Don't assume time_t wraparound.
102
08dc5ae6
PE
103 Be more systematic about user-interface timestamps.
104 Before, the code sometimes used 'Time', sometimes 'unsigned long',
105 and sometimes 'EMACS_UINT', to represent these timestamps. This
106 change causes it to use 'Time' uniformly, as that's what X uses.
107 This makes the code easier to follow, and makes it easier to catch
108 integer overflow bugs such as Bug#8664.
109 * frame.c (Fmouse_position, Fmouse_pixel_position):
110 Use Time, not unsigned long, for user-interface timestamps.
111 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
112 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
113 * keyboard.h (last_event_timestamp): Likewise.
114 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
115 * menu.h (xmenu_show): Likewise.
116 * term.c (term_mouse_position): Likewise.
117 * termhooks.h (struct input_event.timestamp): Likewise.
118 (struct terminal.mouse_position_hook): Likewise.
119 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
120 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
121 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
122 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
123 what it was before.
124 * menu.h, termhooks.h: Include "systime.h", for Time.
125
8e55734a
PE
126 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
127 Don't assume that the difference between two unsigned long values
128 can fit into an integer. At this point, we know button_down_time
129 <= event->timestamp, so the difference must be nonnegative, so
130 there's no need to cast the result if double-click-time is
131 nonnegative, as it should be; check that it's nonnegative, just in
132 case. This bug is triggered when events are more than 2**31 ms
86db42d2 133 apart (about 25 days). (Bug#8664)
8e55734a 134
841f1b75 135 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 136 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 137
3e26f69c
PE
138 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
139 that always fit in int. Use a sentinel instead of a counter, to
140 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
141 * frame.h (struct frame): Use int for menu_bar_items_used
142 instead of EMACS_INT, since it always fits in int.
3e26f69c 143
5cc152c0
PE
144 * menu.c (grow_menu_items): Check for int overflow.
145
d89eb65e
PE
146 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
147
5235bd3e
PE
148 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
149 Before, the code was not consistent. These values cannot exceed
150 2**31 - 1 so there's no need to make them unsigned.
151 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
152 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
153 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
154 as modifiers.
155 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
156
bc827e23
PE
157 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
158 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
159 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
160 presumably because the widths might not match.
161
78eb494e
PE
162 * window.c (size_window): Avoid needless test at loop start.
163
04f2d78b
CB
1642011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
165
166 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
167
d2fc7e3d 1682011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
169
170 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
171
d2fc7e3d 1722011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
173
174 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
175 `width' to `bar_area_x' and `bar_area_width', respectively.
176 (x_scroll_run): Take account of fringe background extension.
177
04f2d78b
CB
178 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
179 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
180 `bar_area_width', respectively.
181 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
182 background extension.
183
79b70037
GM
1842011-05-10 Jim Meyering <meyering@redhat.com>
185
186 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
187
2f142cc5
JB
1882011-05-10 Juanma Barranquero <lekktu@gmail.com>
189
190 * image.c (Finit_image_library): Return t for built-in image types,
191 like pbm and xbm. (Bug#8640)
192
57679c86
AS
1932011-05-09 Andreas Schwab <schwab@linux-m68k.org>
194
195 * w32menu.c (set_frame_menubar): Fix submenu allocation.
196
888c9e86
EZ
1972011-05-07 Eli Zaretskii <eliz@gnu.org>
198
b0512a1d
EZ
199 * w32console.c (Fset_screen_color): Doc fix.
200 (Fget_screen_color): New function.
201 (syms_of_ntterm): Defsubr it.
202
7285dc67
EZ
203 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
204 unlink the temporary file if Fcall_process didn't create it in the
205 first place.
206 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
207 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
208 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
209 cue to call_process_cleanup not to close that handle.
210
4d3fcc8e
BK
2112011-05-07 Ben Key <bkey76@gmail.com>
212
213 * makefile.w32-in: The bootstrap-temacs rule now makes use of
214 one of two shell specific rules, either bootstrap-temacs-CMD or
215 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
216 to the previous implementation of the bootstrap-temacs rule.
217 The bootstrap-temacs-CMD rule is similar to the previous
218 implementation of the bootstrap-temacs rule except that it
219 makes use of the ESC_CFLAGS variable instead of the CFLAGS
220 variable.
221
222 These changes, along with some changes to nt/configure.bat,
223 nt/gmake.defs, and nt/nmake.defs, are required to extend my
224 earlier fix to add support for --cflags and --ldflags options
225 that include quotes so that it works whether make uses cmd or
226 sh as the shell.
227
b4289b64
MA
2282011-05-06 Michael Albinus <michael.albinus@gmx.de>
229
230 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
231 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
232 is a constant.
233 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
234 a string. Handle both cases.
235 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
236 (Fdbus_register_method): Use Qinvalid_function.
237
af4c0e28
JB
2382011-05-06 Juanma Barranquero <lekktu@gmail.com>
239
240 * makefile.w32-in: Update dependencies.
241 (LISP_H): Add inttypes.h and stdin.h.
242 (PROCESS_H): Add unistd.h.
243
c51453d9
EZ
2442011-05-06 Eli Zaretskii <eliz@gnu.org>
245
246 * lread.c: Include limits.h (fixes the MS-Windows build broken by
247 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
248
8ff0ac3c 2492011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 250
4c4b566b
PE
251 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
252
aab2b9b5
PE
253 * term.c (vfatal): Remove stray call to va_end.
254 It's not needed and the C Standard doesn't allow it here anyway.
255
c378da0b
PE
256 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
257 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
258
288b08c7
PE
259 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
260 bytes.
261
e3601888
PE
262 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
263
db6c0e74
PE
264 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
265
dd5963ea
PE
266 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
267
88c9450f
PE
268 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
269
2f9442b8
PE
270 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
271
c032b5f8
PE
272 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
273 * charset.c (Fdefine_charset_internal): Don't initialize
274 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 275 32-bit int (Bug#8600).
a108c10b
PE
276
277 * lread.c (read_integer): Be more consistent with string-to-number.
278 Use string_to_number to do the actual conversion; this avoids
279 rounding errors and fixes some other screwups. Without this fix,
280 for example, #x1fffffffffffffff was misread as -2305843009213693952.
281 (digit_to_number): Move earlier, for benefit of read_integer.
282 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 283 not a digit in any supported base. (Bug#8602)
a108c10b 284
ad5f9eea
PE
285 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
286
aec1708a
PE
287 * dispnew.c (scrolling_window): Return 1 if we scrolled,
288 to match comment at start of function. This also removes a
289 GCC warning about overflow in a 32+64-bit port.
290
47be4ab5
PE
291 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
292
371cac43
PE
293 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
294 Reported by Stefan Monnier in
295 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
296 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
297 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 298
d01a7826
PE
299 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
300 (EMACS_UINTPTR): Likewise, with uintptr_t.
301
7fd47d5c
PE
302 * lisp.h: Prefer 64-bit EMACS_INT if available.
303 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
304 on 32-bit hosts that have 64-bit int, so that they can access
305 large files.
122b0c86
PE
306 However, temporarily disable this change unless the temporary
307 symbol WIDE_EMACS_INT is defined.
7fd47d5c 308
8727937b
PE
309 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
310
8ac068ac
PE
311 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
312 This removes an assumption that EMACS_INT and long are the same
313 width as pointers. The assumption is true for Emacs porting targets
314 now, but we want to make other targets possible.
315 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
316 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
317 In the rest of the code, change types of integers that hold casted
318 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
319 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
320 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
321 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
322 No need to cast type when ORing.
323 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
324 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
325 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
326 assume EMACS_INT is the same width as char *.
327 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
328 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
329 Remove no-longer-needed casts.
330 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
331 (xg_tool_bar_help_callback, xg_make_tool_item):
332 Use EMACS_INTPTR to hold an integer
333 that will be cast to void *; this can avoid a GCC warning
334 if EMACS_INT is not the same width as void *.
335 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
336 * xdisp.c (display_echo_area_1, resize_mini_window_1):
337 (current_message_1, set_message_1):
338 Use a local to convert to proper width without a cast.
339 * xmenu.c (dialog_selection_callback): Likewise.
340
ede49d71
PE
341 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
342 Also, don't assume VALBITS / RAND_BITS is less than 5,
343 and don't rely on undefined behavior when shifting a 1 left into
344 the sign bit.
345 * lisp.h (get_random): Change signature to match.
346
2f30ecd0
PE
347 * lread.c (hash_string): Use size_t, not int, for hash computation.
348 Normally we prefer signed values; but hashing is special, because
349 it's better to use unsigned division on hash table sizes so that
350 the remainder is nonnegative. Also, size_t is the natural width
351 for hashing into memory. The previous code used 'int', which doesn't
352 retain enough info to hash well into very large tables.
353 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
354
2a866e7b
PE
355 * dbusbind.c: Don't possibly lose pointer info when converting.
356 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
357 Use XPNTR rather than XHASH, so that the high-order bits of
358 the pointer aren't lost when converting through void *.
359
51639eac
PE
360 * eval.c (Fautoload): Don't double-shift a pointer.
361
92394119
PE
362 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
363
dbdb9a7c
JB
3642011-05-06 Juanma Barranquero <lekktu@gmail.com>
365
366 * gnutls.c (DEF_GNUTLS_FN):
367 * image.c (DEF_IMGLIB_FN): Make function pointers static.
368
db7a0b4f
AS
3692011-05-05 Andreas Schwab <schwab@linux-m68k.org>
370
371 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
372 marker. (Bug#8610)
373
f7ff1b0f 3742011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
375
376 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
377 New version that can reserve upto 2GB of heap space.
378
f7ff1b0f 3792011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
380
381 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
382
639c109b
TZ
3832011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
384
385 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
386 `gnutls_certificate_set_x509_key_file'.
387
d2127135
JB
3882011-05-05 Juanma Barranquero <lekktu@gmail.com>
389
390 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
391 Update dependencies.
392
e968f4f3
JB
3932011-05-04 Juanma Barranquero <lekktu@gmail.com>
394
395 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
396 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
397 Remove unused parameter `fildes'.
398 * process.c (read_process_output, send_process): Don't pass it.
399
84d358f0
JB
4002011-05-04 Juanma Barranquero <lekktu@gmail.com>
401
402 Fix previous change: the library cache is defined in w32.c.
403 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
404 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
405
0898ca10
JB
4062011-05-04 Juanma Barranquero <lekktu@gmail.com>
407
408 Implement dynamic loading of GnuTLS on Windows.
409
410 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
411 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
412 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
413 Declare.
414
415 * gnutls.c (Qgnutls_dll): Define.
416 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
417 (gnutls_*): Declare function pointers.
418 (init_gnutls_functions): New function to initialize function pointers.
419 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
420 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
421 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
422 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
423 (emacs_gnutls_write, emacs_gnutls_read)
424 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
425 (Fgnutls_available_p): New function.
426 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
427 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
428 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
429
430 * image.c: Include w32.h.
431 (Vimage_type_cache): Delete.
432 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
433 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
434 (w32_delayed_load): Move to w32.c.
435
436 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
437
438 * w32.c (QCloaded_from, Vlibrary_cache): Define.
439 (w32_delayed_load): Move from image.c. When loading a library, record
440 its filename in the :loaded-from property of the library id.
441 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
442 Initialize and staticpro them.
443 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
444
445 * process.c: Include lisp.h before w32.h, not after.
446 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
447 instead of gnutls_record_check_pending.
448
449 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
450
ff4de4aa
TZ
4512011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
452
453 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
454 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
455 as passed in.
456
abe95abb
JD
4572011-05-03 Jan Djärv <jan.h.d@swipnet.se>
458
459 * xterm.c (x_set_frame_alpha): Do not set property on anything
460 else than FRAME_X_OUTER_WINDOW (Bug#8608).
461
e16e55d4
JB
4622011-05-02 Juanma Barranquero <lekktu@gmail.com>
463
464 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
465
bafcf6a5
JB
4662011-05-02 Juanma Barranquero <lekktu@gmail.com>
467
468 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
469 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
470 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
471 (gnutls_global_initialized, Qgnutls_bootprop_priority)
472 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
473 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
474 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
475 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
476 (Qgnutls_bootprop_callbacks_verify): Make static.
477
e7a6747f
AS
4782011-05-01 Andreas Schwab <schwab@linux-m68k.org>
479
19ed11ba
AS
480 * callproc.c: Indentation fixup.
481
e7a6747f 482 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
483 (wait_for_termination, interruptible_wait_for_termination):
484 Move after wait_for_termination_1.
e7a6747f 485
1ef14cb4
LMI
4862011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
487
488 * sysdep.c (interruptible_wait_for_termination): New function
489 which is like wait_for_termination, but allows keyboard
490 interruptions.
491
492 * callproc.c (Fcall_process): Add (:file "file") as an option for
493 the STDOUT buffer.
494 (Fcall_process_region): Ditto.
495
330d880c
EZ
4962011-04-30 Eli Zaretskii <eliz@gnu.org>
497
8db90b73
EZ
498 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
499 rather than `XVECTOR (FOO)->size'.
500
330d880c
EZ
501 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
502 inttypes.h, as a gnulib replacement is used if it not available in
503 system headers.
504
15cbd324
EZ
5052011-04-21 Eli Zaretskii <eliz@gnu.org>
506
507 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
508 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
509 of MOST_POSITIVE_FIXNUM. (Bug#8528)
510
511 * coding.c (coding_alloc_by_realloc): Error out if destination
512 will grow beyond MOST_POSITIVE_FIXNUM.
513 (decode_coding_emacs_mule): Abort if there isn't enough place in
514 charbuf for the composition carryover bytes. Reserve an extra
515 space for up to 2 characters produced in a loop.
516 (decode_coding_iso_2022): Abort if there isn't enough place in
517 charbuf for the composition carryover bytes.
518
5192011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 520
ae940cca
EZ
521 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
522 aborting when %lld or %lll format is passed.
523 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
524 %llo or %llx format is passed. (Bug#8545)
525
03ab8921
EZ
526 * window.c (window_scroll_line_based): Use a marker instead of
527 simple variables to record original value of point. (Bug#7952)
528
afda1437
EZ
529 * doprnt.c (doprnt): Fix the case where a multibyte sequence
530 produced by %s or %c overflows available buffer space. (Bug#8545)
531
f76dee0c
PE
5322011-04-28 Paul Eggert <eggert@cs.ucla.edu>
533
534 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 535 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 536
fdc5744d
JB
5372011-04-28 Juanma Barranquero <lekktu@gmail.com>
538
539 * w32.c (init_environment): Warn about defaulting HOME to C:\.
540
638f053a
JB
5412011-04-28 Juanma Barranquero <lekktu@gmail.com>
542
543 * keyboard.c (Qdelayed_warnings_hook): Define.
544 (command_loop_1): Run `delayed-warnings-hook'
545 if Vdelayed_warnings_list is non-nil.
546 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
547 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
548
d178f871
EZ
5492011-04-28 Eli Zaretskii <eliz@gnu.org>
550
551 * doprnt.c (doprnt): Don't return value smaller than the buffer
552 size if the message was truncated. (Bug#8545).
553
b124fd93
JB
5542011-04-28 Juanma Barranquero <lekktu@gmail.com>
555
556 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
557 (Fx_window_property): #if-0 the whole functions, not just the bodies.
558
e810457d
PE
5592011-04-27 Paul Eggert <eggert@cs.ucla.edu>
560
561 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
562
ea51cceb
JB
5632011-04-27 Juanma Barranquero <lekktu@gmail.com>
564
565 * makefile.w32-in: Update dependencies.
566
94dcfacf
EZ
5672011-04-27 Eli Zaretskii <eliz@gnu.org>
568
569 Improve `doprnt' and its usage. (Bug#8545)
570 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
571 `format_end'. Remove support for %l as a conversion specifier.
572 Don't use xrealloc. Improve diagnostics when the %l size modifier
573 is used. Update the commentary.
574
575 * eval.c (verror): Simplify calculation of size_t.
576
577 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
578 messages.
579
f61f41d7
PE
5802011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
581
582 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
583 change.
584
96fb4434
PE
5852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
586
587 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
588 This makes this file independent of the recent pseudovector change.
589
671875da 5902011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 591
69e9b5a3
PE
592 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
593
b5f869a7 594 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 595 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 596 Remove unused local.
c8926152 597 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 598
841a1577 599 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
600 GCC 4.6.0 optimizes based on type-based alias analysis.
601 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
602 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
603 != &v->size, and therefore "v->size = 1; b->size = 2; return
604 v->size;" must therefore return 1. This assumption is incorrect
605 for Emacs, since it type-puns struct Lisp_Vector * with many other
606 types. To fix this problem, this patch adds a new type struct
f904488f 607 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
608 and pseudovectors, and helps optimizing compilers not get fooled
609 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
610 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
611 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
612 the size member.
eab3844f
PE
613 (XSETPVECTYPE): Rewrite in terms of new macro.
614 (XSETPVECTYPESIZE): New macro, specifying both type and size.
615 This is a bit clearer, and further avoids the possibility of
616 undesirable aliasing.
617 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 618 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
619 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
620 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
621 (ASIZE): Now uses header.size rather than size.
622 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
623 to avoid the hassle of writing XVECTOR (foo)->header.size.
624 (struct vectorlike_header): New type.
eab3844f
PE
625 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
626 object, to help avoid aliasing.
627 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
628 (SUBRP): Likewise, since Lisp_Subr is a special case.
629 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
630 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
631 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 632 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
633 changed to be "header.size" and "header.next".
634 * buffer.h (struct buffer): Likewise.
635 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
636 * frame.h (struct frame): Likewise.
637 * process.h (struct Lisp_Process): Likewise.
638 * termhooks.h (struct terminal): Likewise.
639 * window.c (struct save_window_data, struct saved_window): Likewise.
640 * window.h (struct window): Likewise.
641 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
642 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
643 * buffer.c (init_buffer_once): Likewise.
644 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
645 special case.
646 * process.c (Fformat_network_address): Use local var for size,
647 for brevity.
648
0df1eac5
PE
649 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
650
847ab9d1 651 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
652 * data.c (atof): Remove decl; no longer used or needed.
653 (digit_to_number): Move to lread.c.
654 (Fstring_to_number): Use new string_to_number function, to be
655 consistent with how the Lisp reader treats infinities and NaNs.
656 Do not assume that floating-point numbers represent EMACS_INT
657 without losing information; this is not true on most 64-bit hosts.
658 Avoid double-rounding errors, by insisting on integers when
659 parsing non-base-10 numbers, as the documentation specifies.
660 * lisp.h (string_to_number): New decl, replacing ...
661 (isfloat_string): Remove.
bc0a5c13 662 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 663 (read1): Do not accept +. and -. as integers; this
452f4150
PE
664 appears to have been a coding error. Similarly, do not accept
665 strings like +-1e0 as floating point numbers. Do not report
666 overflow for integer overflows unless the base is not 10 which
667 means we have no simple and reliable way to continue.
668 Break out the floating-point parsing into a new
669 function string_to_number, so that Fstring_to_number parses
670 floating point numbers consistently with the Lisp reader.
04f2d78b 671 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
672 (E_CHAR, EXP_INT): Remove, replacing with ...
673 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
674 (string_to_number): New function, replacing isfloat_string.
675 This function checks for valid syntax and produces the resulting
676 Lisp float number too. Rework it so that string-to-number
bc0a5c13 677 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
678 so that overflow for non-base-10 numbers is reported only when
679 there's no portable and simple way to convert to floating point.
452f4150 680
67769ffc
PE
681 * textprop.c (set_text_properties_1): Rewrite for clarity,
682 and to avoid GCC warning about integer overflow.
683
c20db43f
PE
684 * intervals.h (struct interval): Use EMACS_INT for members
685 where EMACS_UINT might cause problems. See
686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
687 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
688 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
689 All uses changed.
37aa2f85
PE
690 (offset_intervals): Tell GCC not to worry about length overflow
691 when negating a negative length.
c20db43f 692
2538aa2f
PE
693 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
694 (overrun_check_free): Likewise.
695
f2d3008d
PE
696 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
697 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
698 word size.
699
ec8df744
PE
700 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
701 (gnutls_make_error): Rename local to avoid shadowing.
702 (gnutls_emacs_global_deinit): ifdef out; not used.
703 (Fgnutls_boot): Use const for pointer to readonly storage.
704 Comment out unused local. Fix pointer signedness problems.
705
640ee02d
PE
706 * lread.c (openp): Don't stuff size_t into an 'int'.
707 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
708 about possible signed overflow.
709
6048fb2a
PE
710 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
711 (GDK_KEY_g): Don't define if already defined.
712 (xg_prepare_tooltip): Avoid pointer signedness problem.
713 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
714
fa3c87e1
PE
715 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
716 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
717
2172544b
PE
718 * xfns.c (Fx_window_property): Simplify a bit,
719 to make a bit faster and to avoid GCC 4.6.0 warning.
720 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
721
9b821a21
PE
722 * fns.c (internal_equal): Don't assume size_t fits in int.
723
3c616cfa
PE
724 * alloc.c (compact_small_strings): Tighten assertion a little.
725
c2982e87
PE
726 Replace pEd with more-general pI, and fix some printf arg casts.
727 * lisp.h (pI): New macro, generalizing old pEd macro to other
728 conversion specifiers. For example, use "...%"pI"d..." rather
729 than "...%"pEd"...".
730 (pEd): Remove. All uses replaced with similar uses of pI.
731 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
732 * alloc.c (check_pure_size): Don't overflow by converting size to int.
733 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
734 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
735 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
736 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
737 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
738 64-bit hosts.
739 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
740 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
741 * print.c (safe_debug_print, print_object): Likewise.
742 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
743 to int.
6f04d126
PE
744 Use pI instead of if-then-else-abort. Use %p to avoid casts,
745 avoiding the 0 flag, which is not portable.
c2982e87
PE
746 * process.c (Fmake_network_process): Use pI to avoid cast.
747 * region-cache.c (pp_cache): Likewise.
748 * xdisp.c (decode_mode_spec): Likewise.
749 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
750 behavior on 64-bit hosts with printf arg.
6f04d126 751 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
752 (x_stop_queuing_selection_requests): Likewise.
753 (x_get_window_property): Don't truncate byte count to an 'int'
754 when tracing.
0b432f21 755
5e073ec7
PE
756 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
757 here, since it parses constructs like leading '-' and spaces,
758 which are not wanted; and it overflows with large numbers.
759 Instead, simply match F[0-9]+, which is what is wanted anyway.
760
36372bf9
PE
761 * alloc.c: Remove unportable assumptions about struct layout.
762 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
763 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
764 (allocate_vectorlike, make_pure_vector): Use the new macros,
765 plus offsetof, to remove unportable assumptions about struct layout.
766 These assumptions hold on all porting targets that I know of, but
767 they are not guaranteed, they're easy to remove, and removing them
768 makes further changes easier.
769
0b432f21
PE
770 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
771 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
772 (string_overrun_cookie): Now const. Use initializers that
773 don't formally overflow signed char, to avoid warnings.
000098c1
PE
774 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
775 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
776 (allocate_buffer): Don't assume sizeof (struct buffer) is a
777 multiple of sizeof (EMACS_INT); it need not be, if
778 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 779 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 780
895009e1
JB
7812011-04-26 Juanma Barranquero <lekktu@gmail.com>
782
783 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
784
6a7a1b0b
TZ
7852011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
786
787 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 788 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
789 Reported by Paul Eggert <eggert@cs.ucla.edu>.
790
841a1577 7912011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
792
793 * lisp.h (Qdebug): List symbol.
895009e1 794 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
795 * keyboard.c (debug-on-event): New variable.
796 (handle_user_signal): Break into debugger when debug-on-event
797 matches the current signal symbol.
798
f2d3ba6f
DN
7992011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
800
801 * alloc.c (check_sblock, check_string_bytes)
802 (check_string_free_list): Convert to standard C.
803
42ce4c63
TZ
8042011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
805
806 * w32.c (emacs_gnutls_push): Fix typo.
807
825cd63c
EZ
8082011-04-25 Eli Zaretskii <eliz@gnu.org>
809
fb11d64d
EZ
810 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
811 "cast to pointer from integer of different size".
812
825cd63c
EZ
813 Improve doprnt and its use in verror. (Bug#8545)
814 * doprnt.c (doprnt): Document the set of format control sequences
815 supported by the function. Use SAFE_ALLOCA instead of always
816 using `alloca'.
817
818 * eval.c (verror): Don't limit the buffer size at size_max-1, that
819 is one byte too soon. Don't use xrealloc; instead xfree and
820 xmalloc anew.
821
e061a11b
TZ
8222011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
823
824 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
825 callbacks stage.
826
827 * gnutls.c: Renamed global_initialized to
828 gnutls_global_initialized. Added internals for the
829 :verify-hostname-error, :verify-error, and :verify-flags
830 parameters of `gnutls-boot' and documented those parameters in the
831 docstring. Start callback support.
832 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
833 unless a fatal error occured. Call gnutls_alert_send_appropriate
834 on error. Return error code.
835 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
836 (emacs_gnutls_read): Likewise.
837 (Fgnutls_boot): Return handshake error code.
838 (emacs_gnutls_handle_error): New function.
839 (wsaerror_to_errno): Likewise.
840
841 * w32.h (emacs_gnutls_pull): Add prototype.
842 (emacs_gnutls_push): Likewise.
843
844 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
845 (emacs_gnutls_push): Likewise.
846
8472011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
848
849 * process.c (wait_reading_process_output): Check if GnuTLS
850 buffered some data internally if no FDs are set for TLS
851 connections.
852
853 * makefile.w32-in (OBJ2): Add gnutls.$(O).
854 (LIBS): Link to USER_LIBS.
855 ($(BLD)/gnutls.$(0)): New target.
856
fa6996bc
EZ
8572011-04-24 Eli Zaretskii <eliz@gnu.org>
858
eb35682e
EZ
859 * xdisp.c (handle_single_display_spec): Rename the
860 display_replaced_before_p argument into display_replaced_p, to
861 make it consistent with the commentary. Fix typos in the
862 commentary.
863
e2ad650c
EZ
864 * textprop.c (syms_of_textprop): Remove dead code.
865 (copy_text_properties): Delete obsolete commentary about an
866 interface that was deleted long ago. Fix typos in the description
867 of arguments.
868
1b2de274
EZ
869 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
870 to changes in oldXMenu/XMenu.h from 2011-04-16.
871 <menu_help_message, prev_menu_help_message>: Constify.
872 (IT_menu_make_room): menu->help_text is now `const char **';
873 adjust.
874
875 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
876 to changes in oldXMenu/XMenu.h from 2011-04-16.
877 (struct XMenu): Declare `help_text' `const char **'.
878
879 * xfaces.c <Qunspecified>: Make extern again.
880
881 * syntax.c: Include sys/types.h before including regex.h, as
882 required by Posix.
883
762b15be
EZ
884 * doc.c (get_doc_string): Improve the format passed to `error'.
885
886 * doprnt.c (doprnt): Improve commentary.
887
888 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
889
890 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
891 them with etags.
892
f1052e5d
EZ
893 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
894 changes in globals.h immediately force recompilation.
762b15be
EZ
895 (TAGS): Depend on $(CURDIR)/m/intel386.h and
896 $(CURDIR)/s/ms-w32.h.
897 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 898
fa6996bc
EZ
899 * character.c (Fchar_direction): Function deleted.
900 (syms_of_character): Don't defsubr it.
901 <char-direction-table>: Deleted.
902
e6c3da20
EZ
9032011-04-23 Eli Zaretskii <eliz@gnu.org>
904
905 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
906 * doprnt.c: Include limits.h.
907 (SIZE_MAX): New macro.
04f2d78b
CB
908 (doprnt): Return a size_t value. 2nd arg is now size_t.
909 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
910 Improve overflow protection. Support `l' modifier for integer
911 conversions. Support %l conversion. Don't assume an EMACS_INT
912 argument for integer conversions and for %c.
913
914 * lisp.h (doprnt): Restore prototype.
915
916 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
917 $(SRC)/character.h.
918
919 * Makefile.in (base_obj): Add back doprnt.o.
920
921 * deps.mk (doprnt.o): Add back prerequisites.
922 (callint.o): Depend on character.h.
923
924 * eval.c (internal_lisp_condition_case): Include the handler
925 representation in the error message.
926 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
927 when breaking from the loop.
928
929 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
930
931 * callint.c (Fcall_interactively): When displaying error message
932 about invalid control letter, pass the character's codepoint, not
933 a pointer to its multibyte form. Improve display of the character
934 in octal and display also its hex code.
935
936 * character.c (char_string): Use %x to display the (unsigned)
937 codepoint of an invalid character, to avoid displaying a bogus
938 negative value.
939
940 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
941 `error', not SYMBOL_NAME itself.
942
943 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
944 character arguments to `error'.
945
946 * charset.c (check_iso_charset_parameter): Fix incorrect argument
947 to `error' in error message about FINAL_CHAR argument. Make sure
948 FINAL_CHAR is a character, and use %c when it is passed as
949 argument to `error'.
950
4ffd0d6b 9512011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
952
953 * s/ms-w32.h (localtime): Redirect to sys_localtime.
954
955 * w32.c: Include <time.h>.
956 (sys_localtime): New function.
957
4ffd0d6b 9582011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
959
960 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
961
4ffd0d6b 962 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 963
4ffd0d6b 9642011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 965
4ffd0d6b
GM
966 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
967 zombies (Bug#8467).
aac0c6e3 968
04c56954
EZ
9692011-04-19 Eli Zaretskii <eliz@gnu.org>
970
971 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
972 gl_state.e_property when gl_state.object is Qt.
973
974 * insdel.c (make_gap_larger): Remove limitation of buffer size
975 to <= INT_MAX.
976
16a43933
CY
9772011-04-18 Chong Yidong <cyd@stupidchicken.com>
978
979 * xdisp.c (lookup_glyphless_char_display)
980 (produce_glyphless_glyph): Handle cons cell entry in
981 glyphless-char-display.
982 (Vglyphless_char_display): Document it.
983
984 * term.c (produce_glyphless_glyph): Handle cons cell entry in
985 glyphless-char-display.
986
4581706e
CY
9872011-04-17 Chong Yidong <cyd@stupidchicken.com>
988
989 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
990
991 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
992
993 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
994 definition for no-X builds.
995
4887c6e2 9962011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 997
fd35b6f9
PE
998 Static checks with GCC 4.6.0 and non-default toolkits.
999
5c1ccb01
PE
1000 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1001
006c5daa
PE
1002 * process.c (keyboard_bit_set): Define only if SIGIO.
1003 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1004 (send_process): Repair possible setjmp clobbering.
1005
efc736d3
PE
1006 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1007
4e2fe2e6
PE
1008 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1009
f97334a2
PE
1010 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1011
4e75f29d
PE
1012 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1013 Define only if needed.
1014
90efadd1
PE
1015 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1016 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1017 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1018
3c647824
PE
1019 * dispextern.h (struct redisplay_interface): Rename param
1020 to avoid shadowing.
e264f262 1021 * termhooks.h (struct terminal): Likewise.
761383f4 1022 * xterm.c (xembed_send_message): Likewise.
3c647824 1023
b58c5c4a
PE
1024 * insdel.c (make_gap_smaller): Define only if
1025 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1026
cad59032
PE
1027 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1028 it.
1029
c339dc2e
PE
1030 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1031 so that we aren't warned about unused symbols.
1032
91a3e27b
PE
1033 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1034
399c71d3 1035 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1036
8ffc96f5
PE
1037 * xfns.c (x_real_positions): Mark locals as initialized.
1038
eef9bc79
PE
1039 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1040
098db9dd
PE
1041 * xterm.c: Fix problems found by static analysis with other toolkits.
1042 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1043 (x_dispatch_event): Declare static if USE_GTK, and
1044 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1045 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1046 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1047 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1048 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1049
eb18f6cc
PE
1050 * xmenu.c (menu_help_callback): Pointer type fixes.
1051 Use const pointers when pointing at readonly data. Avoid pointer
1052 signedness clashes.
1053 (FALSE): Remove unused macro.
1054 (update_frame_menubar): Remove unused decl.
1055
1fe72bf8
PE
1056 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1057
60d9e1db
PE
1058 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1059 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1060 (single_menu_item): Rename local to avoid shadowing.
1061
39261c26
PE
1062 * keyboard.c (make_lispy_event): Remove unused local var.
1063
018c5e19
PE
1064 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1065 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1066
63d2b86e
PE
1067 * bitmaps: Change bitmaps from unsigned char back to the X11
1068 compatible char. Avoid the old compiler warnings about
1069 out-of-range initializers by using, for example, '\xab' rather
1070 than 0xab.
1071
aefd87e1
PE
1072 * xgselect.c (xgselect_initialize): Check vs interface
1073 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1074
bf501fb9
PE
1075 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1076
e9829fdf
PE
1077 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1078 to read-only memory.
1079
1086c095
PE
1080 * fns.c (vector): Remove; this old hack is no longer needed.
1081
2baccd04 1082 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1083 Remove unused var.
dde42981 1084 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1085
72391843 1086 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1087
436c16df 1088 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1089 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1090 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1091
92bb796d 1092 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1093 (x_term_init): Remove local to avoid shadowing.
92bb796d 1094
764430a3 1095 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1096
1097 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1098 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1099
d1dfb56c
EZ
11002011-04-16 Eli Zaretskii <eliz@gnu.org>
1101
c4354cb4
EZ
1102 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1103
d1dfb56c
EZ
1104 Fix regex.c, syntax.c and friends for buffers > 2GB.
1105 * syntax.h (struct gl_state_s): Declare character position members
1106 EMACS_INT.
1107
1108 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1109
04f2d78b
CB
1110 * textprop.c (verify_interval_modification, interval_of):
1111 Declare arguments EMACS_INT.
d1dfb56c
EZ
1112
1113 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1114 EMACS_INT.
1115
1116 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1117
1118 * indent.c (Fvertical_motion): Local variable it_start is now
1119 EMACS_INT.
1120
1121 * regex.c (re_match, re_match_2, re_match_2_internal)
1122 (bcmp_translate, regcomp, regexec, print_double_string)
1123 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1124 (re_compile_pattern, re_exec): Declare arguments and local
1125 variables `size_t' and `ssize_t' and return values `regoff_t', as
1126 appropriate.
1127 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1128 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1129 <compile_stack_type>: `size' and `avail' are now `size_t'.
1130
1131 * regex.h <regoff_t>: Use ssize_t, not int.
1132 (re_search, re_search_2, re_match, re_match_2): Arguments that
1133 specify buffer/string position and length are now ssize_t and
1134 size_t. Return type is regoff_t.
1135
613052cd
BK
11362011-04-16 Ben Key <bkey76@gmail.com>
1137
1138 * nsfont.m: Fixed bugs in ns_get_family and
1139 ns_descriptor_to_entity that were caused by using free to
1140 deallocate memory blocks that were allocated by xmalloc (via
1141 xstrdup). This caused Emacs to crash when compiled with
1142 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1143 --enable-checking=xmallocoverrun). xfree is now used to
1144 deallocate these memory blocks.
1145
4170f62f 11462011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1147
71b41406
PE
1148 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1149
9587a89d
PE
1150 emacs_write: Accept and return EMACS_INT for sizes.
1151 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1152 et seq.
1153 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1154 Accept and return EMACS_INT.
1155 (emacs_gnutls_write): Return the number of bytes written on
1156 partial writes.
1157 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1158 (emacs_read, emacs_write): Remove check for negative size, as the
1159 Emacs source code has been audited now.
9587a89d
PE
1160 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1161 (emacs_read, emacs_write): Use it.
273a5f82
PE
1162 * process.c (send_process): Adjust to the new signatures of
1163 emacs_write and emacs_gnutls_write. Do not attempt to store
1164 a byte offset into an 'int'; it might overflow.
9587a89d 1165 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1166
3e047f51
PE
1167 * sound.c: Don't assume sizes fit in 'int'.
1168 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1169 Return EMACS_INT, not int.
3e047f51 1170 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1171 Accept EMACS_INT, not int.
1172 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1173 record read return values.
1174
cc39a9db
BK
11752011-04-15 Ben Key <bkey76@gmail.com>
1176
c9d0ec6d
JB
1177 * keyboard.c (Qundefined): Don't declare static since it is used
1178 in nsfns.m.
1179 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1180 static since they are used in nsfont.m.
cc39a9db 1181
6c60eb9f
SM
11822011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1183
1184 * process.c (Qprocessp): Don't declare static.
1185 * lisp.h (Qprocessp): Declare again.
1186
7990b61a
JB
11872011-04-15 Juanma Barranquero <lekktu@gmail.com>
1188
1189 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1190
5d4cb038
PE
11912011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1192
8bd7b830 1193 Improve C-level modularity by making more things 'static'.
cd64ea1d 1194
e3b27b31
PE
1195 Don't publish debugger-only interfaces to other modules.
1196 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1197 (verify_bytepos, count_markers): Move decls to the only modules
1198 that need them.
1199 * region-cache.h (pp_cache): Likewise.
1200 * window.h (check_all_windows): Likewise.
1201 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1202
5d4cb038
PE
1203 * sysdep.c (croak): Now static, if
1204 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1205 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1206
1207 * alloc.c (refill_memory_reserve): Now static if
1208 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1209 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1210
e87b6180
PE
1211 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1212 Define only if USE_LUCID.
1213
ac64929e
PE
1214 * xrdb.c (x_customization_string, x_rm_string): Now static.
1215
6f37259d
PE
1216 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1217 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1218
1683e3ab
PE
1219 * xdisp.c (draw_row_with_mouse_face): Now static.
1220 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1221
de9c2632
PE
1222 * window.h (check_all_windows): Mark externally visible.
1223
2b96acb7
PE
1224 * window.c (window_deletion_count): Now static.
1225
1226 * undo.c: Make symbols static if they're not exported.
1227 (last_undo_buffer, last_boundary_position, pending_boundary):
1228 Now static.
1229
50436f33
PE
1230 * textprop.c (interval_insert_behind_hooks): Now static.
1231 (interval_insert_in_front_hooks): Likewise.
1232
64520e5c
PE
1233 * term.c: Make symbols static if they're not exported.
1234 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1235 (max_frame_lines, tty_set_terminal_modes):
1236 (tty_reset_terminal_modes, tty_turn_off_highlight):
1237 (get_tty_terminal): Now static.
1238 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1239 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1240 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1241 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1242 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1243
1fa53021
PE
1244 * sysdep.c: Make symbols static if they're not exported.
1245 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1246 Now static.
1247 (sigprocmask_set, full_mask): Remove; unused.
1248 (wait_debugging): Mark as visible.
1249 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1250 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1251
d4b43b22
PE
1252 * syntax.c (syntax_temp): Define only if !__GNUC__.
1253
b7c513d0
PE
1254 * sound.c (current_sound_device, current_sound): Now static.
1255
989b29ad
PE
1256 * search.c (searchbufs, searchbuf_head): Now static.
1257
13a55a78
PE
1258 * scroll.c (scroll_cost): Remove; unused.
1259 * dispextern.h (scroll_cost): Remove decl.
1260
de68a1fc
PE
1261 * region-cache.h (pp_cache): Mark as externally visible.
1262
40ccffa6
PE
1263 * process.c: Make symbols static if they're not exported.
1264 (process_tick, update_tick, create_process, chan_process):
1265 (Vprocess_alist, proc_buffered_char, datagram_access):
1266 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1267 (deactivate_process): Mark defn as static, as well as decl.
1268 * lisp.h (create_process): Remove decl.
1269 * process.h (chan_process, Vprocess_alist): Remove decls.
1270
ad64fc97
PE
1271 * print.c: Make symbols static if they're not exported.
1272 (print_depth, new_backquote_output, being_printed, print_buffer):
1273 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1274 (print_interval, print_number_index, initial_stderr_stream):
1275 Now static.
1276 * lisp.h (Fprinc): Remove decl.
1277 (debug_output_compilation_hack): Mark as externally visible.
1278
adddb265
PE
1279 * sysdep.c (croak): Move decl from here to syssignal.h.
1280 * syssignal.h (croak): Put it here, so the API can be checked when
1281 'croak' is called from dissociate_if_controlling_tty.
1282
1717ede2
PE
1283 * minibuf.c: Make symbols static if they're not exported.
1284 (minibuf_save_list, choose_minibuf_frame): Now static.
1285 * lisp.h (choose_minibuf_frame): Remove decl.
1286
fa5fb2bc
PE
1287 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1288
1e3890d1
PE
1289 * lread.c: Make symbols static if they're not exported.
1290 (read_objects, initial_obarray, oblookup_last_bucket_number):
1291 Now static.
1292 (make_symbol): Remove; unused.
1293 * lisp.h (initial_obarray, make_symbol): Remove decls.
1294
8a1414fa
PE
1295 * keyboard.c: Make symbols static if they're not exported.
1296 (single_kboard, recent_keys_index, total_keys, recent_keys):
1297 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1298 (this_single_command_key_start, echoing, last_auto_save):
1299 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1300 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1301 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1302 (Vlispy_mouse_stem, double_click_count):
1303 Now static.
1304 (force_auto_save_soon): Define only if SIGDANGER.
1305 (ignore_mouse_drag_p): Now static if
1306 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1307 (print_help): Remove; unused.
1308 (stop_character, last_timer_event): Mark as externally visible.
1309 * keyboard.h (ignore_mouse_drag_p): Declare only if
1310 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1311 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1312 * lisp.h (echoing): Remove decl.
1313 (force_auto_save_soon): Declare only if SIGDANGER.
1314 * xdisp.c (redisplay_window): Simplify code, to make it more
1315 obvious that ignore_mouse_drag_p is not accessed if !defined
1316 USE_GTK && !defined HAVE_NS.
1317
93ea6e8f
PE
1318 * intervals.c: Make symbols static if they're not exported.
1319 (merge_properties_sticky, merge_interval_right, delete_interval):
1320 Now static.
1321 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1322
77382fcc
PE
1323 * insdel.c: Make symbols static if they're not exported.
1324 However, leave prepare_to_modify_buffer alone. It's never
1325 called from outside this function, but that appears to be a bug.
1326 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1327 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1328 (adjust_after_replace_noundo): Remove; unused.
1329 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1330 (signal_before_change): Remove decls.
77382fcc 1331
9306c32e
PE
1332 * indent.c (val_compute_motion, val_vmotion): Now static.
1333
cd44d2eb
PE
1334 * image.c: Make symbols static if they're not exported.
1335 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1336 if USE_GTK.
1337 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1338 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1339
ad9a7a06
PE
1340 * fringe.c (standard_bitmaps): Now static.
1341 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1342
81626931
PE
1343 * frame.c: Make symbols static if they're not exported.
1344 (x_report_frame_params, make_terminal_frame): Now static.
1345 (get_frame_param): Now static, unless HAVE_NS.
1346 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1347 (x_get_resource_string): Remove; not used.
1348 * frame.h (make_terminal_frame, x_report_frame_params):
1349 (x_get_resource_string); Remove decls.
1350 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1351 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1352
239f9db9
PE
1353 * font.c, fontset.c: Make symbols static if they're not exported.
1354 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1355 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1356 * font.c (font_close_object): Now static.
1357 * font.h (font_close_object): Remove.
1358 * fontset.c (FONTSET_OBJLIST): Remove.
1359 (free_realized_fontset) #if-0 the body, which does nothing.
1360 (face_suitable_for_char_p): #if-0, as it's never called.
1361 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1362 * xfaces.c (face_at_string_position):
1363 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1364 since 0 is always ASCII.
1365
dfcf3579
PE
1366 * fns.c (weak_hash_tables): Now static.
1367
5045092b
PE
1368 * fileio.c: Make symbols static if they're not exported.
1369 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1370 (Vwrite_region_annotation_buffers): Now static.
1371
57a96f5c
PE
1372 * eval.c: Make symbols static if they're not exported.
1373 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1374 * lisp.h (backtrace_list): Remove decl.
1375
35f08c38
PE
1376 * emacs.c: Make symbols static if they're not exported.
1377 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1378 (fatal_error_code, fatal_error_signal_hook, standard_args):
1379 Now static.
1380 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1381 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1382 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1383 * lisp.h (fatal_error_signal_hook): Remove decl.
1384 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1385
f44bd759
PE
1386 * editfns.c: Move a (normally-unused) function to its only use.
1387 * editfns.c, lisp.h (get_operating_system_release): Remove.
1388 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1389 worth the hassle of breaking this out.
1390
b532497d
PE
1391 * xterm.c: Make symbols static if they're not exported.
1392 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1393 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1394 (x_destroy_window, x_delete_display):
1395 Now static.
1396 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1397 (x_mouse_leave): Remove; unused.
1398 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1399 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1400 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1401 Remove decls.
1402 (x_mouse_leave): Declare only if WINDOWSNT.
1403 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1404 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1405 USE_X_TOOLKIT.
1406
1675728f
PE
1407 * ftxfont.c: Make symbols static if they're not exported.
1408 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1409 HAVE_FREETYPE.
1410 * font.h (ftxfont_driver): Likewise.
1411
e4cebfca
PE
1412 * xfns.c: Make symbols static if they're not exported.
1413 (x_last_font_name, x_display_info_for_name):
1414 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1415 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1416 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1417 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1418 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1419 (last_show_tip_args): Now static.
1420 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1421 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1422 (x_screen_planes): Remove; unused.
1423 * dispextern.h (x_screen_planes): Remove decl.
1424
5bf46f05
PE
1425 * dispnew.c: Make symbols static if they're not exported.
1426 * dispextern.h (redraw_garbaged_frames, scrolling):
1427 (increment_row_positions): Remove.
1428 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1429 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1430 Now static.
1431 (redraw_garbaged_frames): Remove; unused.
1432
435f4c28
PE
1433 * xfaces.c: Make symbols static if they're not exported.
1434 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1435 Remove decls.
1436 * xterm.h (defined_color): Remove decls.
1437 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1438 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1439 (menu_face_changed_default, defined_color, free_realized_face):
1440 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1441 (ascii_face_of_lisp_face): Remove; unused.
1442
8524aef3
PE
1443 * xdisp.c: Make symbols static if they're not exported.
1444 * dispextern.h (scratch_glyph_row, window_box_edges):
1445 (glyph_to_pixel_coords, set_cursor_from_row):
1446 (get_next_display_element, set_iterator_to_next):
1447 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1448 (show_mouse_face): Remove decls
1449 * frame.h (message_buf_print): Likewise.
1450 * lisp.h (pop_message, set_message, check_point_in_composition):
1451 Likewise.
1452 * xterm.h (set_vertical_scroll_bar): Likewise.
1453 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1454 (message_buf_print, scratch_glyph_row, displayed_buffer):
1455 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1456 (get_next_display_element, show_mouse_face, window_box_edges):
1457 (frame_to_window_pixel_xy, check_point_in_composition):
1458 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1459 (glyph_to_pixel_coords): Remove; unused.
1460
16390cd2
PE
1461 * dired.c (file_name_completion): Now static.
1462
1463 * dbusbind.c (xd_in_read_queued_messages): Now static.
1464
a25f4dfa
PE
1465 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1466 * data.c (circular_list_error): Remove.
1467
14a9c8df
PE
1468 * commands.h (last_point_position, last_point_position_buffer):
1469 (last_point_position_window): Remove decls.
1470 * keyboard.c: Make these variables static.
1471
04f2d78b
CB
1472 * coding.h (coding, code_convert_region, encode_coding_gap):
1473 Remove decls.
74ab6df5
PE
1474 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1475 (iso_code_class, detect_coding, code_convert_region): Now static.
1476 (encode_coding_gap): Remove; unused.
1477
38dfbee1
PE
1478 * chartab.c (chartab_chars, chartab_bits): Now static.
1479
a2cb4e63
PE
1480 * charset.h (charset_iso_8859_1): Remove decl.
1481 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1482 Now static.
1483
127198fd
PE
1484 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1485 * ccl.c (Vccl_program_table): Now static.
1486 (check_ccl_update): Remove; unused.
1487
d85b608f
PE
1488 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1489 * category.h: ... from here.
1490 * category.c (check_category_table, set_category_set): Now static.
1491
31cd66f3
PE
1492 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1493 * lisp.h: Remove these decls.
1494
c358e587
PE
1495 * buffer.c (buffer_count): Remove unused var.
1496
e78aecca
PE
1497 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1498 so that it's not optimized away.
1499 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1500 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1501 exported only to the debugger.
1502
e192d7d3 1503 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1504 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1505
92470028
PE
1506 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1507 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1508 was inaccessible from Lisp.
1509 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1510 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1511
244ed907
PE
1512 alloc.c: Import and export fewer symbols, and remove unused items.
1513 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1514 is defined.
1515 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1516 it's not optimized away by whole-program optimization.
1517 (message_enable_multibyte, free_misc): Remove.
1518 (catchlist, handlerlist, mark_backtrace):
1519 Declare only if BYTE_MARK_STACK.
1520 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1521 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1522 (message_enable_multibyte): Remove decl.
1523 (free_misc, interval_free_list, float_block, float_block_index):
1524 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1525 (cons_free_list, last_marked_index):
1526 Now static.
1527 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1528 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1529 (mark_backtrace): Define only if BYTE_MARK_STACK.
1530 * xdisp.c (message_enable_multibyte): Now static.
1531
61c2b50e 1532 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1533 This makes it easier for human readers (and static analyzers)
1534 to see whether these variables are used from other modules.
1535 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1536 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1537 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1538 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1539 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1540 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1541 * xmenu.c, xselect.c:
1542 Declare Q* vars static if they are not used in other modules.
1543 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1544 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1545 Remove decls of unexported vars.
1546 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1547
95c82688
PE
1548 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1549
16a97296
PE
1550 Make Emacs functions such as Fatom 'static' by default.
1551 This makes it easier for human readers (and static analyzers)
1552 to see whether these functions can be called from other modules.
1553 DEFUN now defines a static function. To make the function external
1554 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1555 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1556 (Finit_image_library):
16a97296
PE
1557 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1558 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1559 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1560 Remove decls, since these functions are now static.
1561 (Funintern, Fget_internal_run_time): New decls, since these functions
1562 were already external.
95c82688 1563
16a97296
PE
1564 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1565 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1566 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1567 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1568 * keyboard.c, keymap.c, lread.c:
1569 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1570 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1571 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1572 Mark functions with DEFUE instead of DEFUN,
1573 if they are used in other modules.
1574 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1575 decls for now-static functions.
1576 * buffer.h (Fdelete_overlay): Remove decl.
1577 * callproc.c (Fgetenv_internal): Mark as internal.
1578 * composite.c (Fremove_list_of_text_properties): Remove decl.
1579 (Fcomposition_get_gstring): New forward static decl.
1580 * composite.h (Fcomposite_get_gstring): Remove decl.
1581 * dired.c (Ffile_attributes): New forward static decl.
1582 * doc.c (Fdocumntation_property): New forward static decl.
1583 * eval.c (Ffetch_bytecode): New forward static decl.
1584 (Funintern): Remove extern decl; now in .h file where it belongs.
1585 * fileio.c (Fmake_symbolic_link): New forward static decl.
1586 * image.c (Finit_image_library): New forward static decl.
1587 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1588 * intervals.h (Fprevious_property_change):
1589 (Fremove_list_of_text_properties): Remove decls.
1590 * keyboard.c (Fthis_command_keys): Remove decl.
1591 (Fcommand_execute): New forward static decl.
1592 * keymap.c (Flookup_key): New forward static decl.
1593 (Fcopy_keymap): Now static.
1594 * keymap.h (Flookup_key): Remove decl.
1595 * process.c (Fget_process): New forward static decl.
1596 (Fprocess_datagram_address): Mark as internal.
1597 * syntax.c (Fsyntax_table_p): New forward static decl.
1598 (skip_chars): Remove duplicate decl.
1599 * textprop.c (Fprevious_property_change): New forward static decl.
1600 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1601 Now internal.
1602 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1603 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1604
785bbd42
PE
1605 * editfns.c (Fformat): Remove unreachable code.
1606
8b913b57
AS
16072011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1608
1609 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1610 change. (Bug#8496)
1611
a6744a35
EZ
16122011-04-13 Eli Zaretskii <eliz@gnu.org>
1613
1614 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1615 when at ZV. (Bug#8487)
1616
e7974947
AS
16172011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1618
baad03f0
AS
1619 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1620 (Bug#8437)
1621 * keyboard.c (parse_tool_bar_item): Likewise.
1622 * sound.c (sound_cleanup, alsa_close): Likewise.
1623 * termcap.c (tgetent): Likewise.
1624 * xfns.c (x_default_font_parameter): Likewise.
1625 * xsettings.c (read_and_apply_settings): Likewise.
1626
e7974947
AS
1627 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1628 (overrun_check_free): Protoize.
1629
28272684
PE
16302011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1633 since callers should never pass a negative size.
1634 Change the signature to match that of plain 'read' and 'write'; see
1635 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1636 * lisp.h: Update prototypes of emacs_write and emacs_read.
1637
11997c76
EZ
16382011-04-11 Eli Zaretskii <eliz@gnu.org>
1639
1640 * xdisp.c (redisplay_window): Don't try to determine the character
1641 position of the scroll margin if the window start point w->startp
e896f03c 1642 is outside the buffer's accessible region. (Bug#8468)
11997c76 1643
8a2cbd72
EZ
16442011-04-10 Eli Zaretskii <eliz@gnu.org>
1645
1646 Fix write-region and its subroutines for buffers > 2GB.
1647 * fileio.c (a_write, e_write): Modify declaration of arguments and
1648 local variables to support buffers larger than 2GB.
1649 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1650
1651 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1652 argument, local variables, and return value.
1653
1654 * lisp.h: Update prototypes of emacs_write and emacs_read.
1655
1656 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1657
4073e537 16582011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1659
1ebfdcb6
PE
1660 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1661
b2ded58d
PE
1662 Fix more problems found by GCC 4.6.0's static checks.
1663
7d66342c
PE
1664 * xdisp.c (vmessage): Use a better test for character truncation.
1665
bbf47d44
PE
1666 * charset.c (load_charset_map): <, not <=, for optimization,
1667 and to avoid potential problems with integer overflow.
9248994d 1668 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1669 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1670 * editfns.c (Fformat): Likewise.
1e69125e 1671 * syntax.c (skip_chars): Likewise.
3befa583 1672
e3019616
PE
1673 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1674 This also lets GCC 4.6.0 generate slightly better loop code.
1675
becfa255
PE
1676 * callint.c (Fcall_interactively): <, not <=, for optimization.
1677 (Fcall_interactively): Count the number of arguments produced,
1678 not the number of arguments given. This is simpler and lets GCC
1679 4.6.0 generate slightly better code.
1680
dae0cd48
PE
1681 * ftfont.c: Distingish more carefully between FcChar8 and char.
1682 The previous code passed unsigned char * to a functions like
1683 strlen and xstrcasecmp that expect char *, which does not
1684 conform to the C standard.
1685 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1686 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1687 char * when the C standard requires it.
1688
76032d70
PE
1689 * keyboard.c (read_char): Remove unused var.
1690
eb3f1cc8
PE
1691 * eval.c: Port to Windows vsnprintf (Bug#8435).
1692 Include <limits.h>.
1693 (SIZE_MAX): Define if the headers do not.
1694 (verror): Do not give up if vsnprintf returns a negative count.
1695 Instead, grow the buffer. This ports to Windows vsnprintf, which
1696 does not conform to C99. Problem reported by Eli Zaretskii.
1697 Also, simplify the allocation scheme, by avoiding the need for
1698 calling realloc, and removing the ALLOCATED variable.
1699
70476b54
PE
1700 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1701
12020a9e
PE
1702 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1703 But keep the doprint source code for now, as we might revamp it
1704 and use it again (Bug#8435).
ea6c7ae6
PE
1705 * lisp.h (doprnt): Remove.
1706 * Makefile.in (base_obj): Remove doprnt.o.
1707 * deps.mk (doprnt.o): Remove.
1708
5fdb398c
PE
1709 error: Print 32- and 64-bit integers portably (Bug#8435).
1710 Without this change, on typical 64-bit hosts error ("...%d...", N)
1711 was used to print both 32- and 64-bit integers N, which relied on
1712 undefined behavior.
1713 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1714 New macro.
1715 * lisp.h (error, verror): Mark as printf-like functions.
1716 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1717 Report overflow in size calculations when allocating printf buffer.
1718 Do not truncate output string at its first null byte.
1719 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1720 Truncate the output at a character boundary, since vsnprintf does not
1721 do that.
1722 * charset.c (check_iso_charset_parameter): Convert internal
1723 character to string before calling 'error', since %c now has the
1724 printf meaning.
1725 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1726 overflow when computing char to be passed to 'error'. Do not
1727 pass Lisp_Object to 'error'; pass the integer instead.
1728 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1729 formatted with plain %d.
1730
b189fa66
PE
1731 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1732
bff87ef0
PE
1733 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1734
7e2cac20
PE
1735 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1736
ce4d90b5
PE
1737 * xterm.c (x_catch_errors): Remove duplicate declaration.
1738
266c9547
PE
1739 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1740
79c49ad2
PE
1741 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1742
368f4090
JM
17432011-04-10 Jim Meyering <meyering@redhat.com>
1744
1745 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1746 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1747 return ssize_t not "int", and use size_t as the buffer length.
1748 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1749 * gnutls.h: Update declarations.
1750 * process.c (read_process_output): Use ssize_t, to match.
1751 (send_process): Likewise.
1752
a32d4040
CY
17532011-04-09 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1756
8546720e 17572011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1758
04f2d78b
CB
1759 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1760 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1761
8546720e
GM
1762 * xterm.c (handle_one_xevent):
1763 * xmenu.c (create_and_show_popup_menu):
1764 * xselect.c (x_decline_selection_request)
1765 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1766
0a2f5c1a 17672011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1768
1769 Fix some uses of `int' instead of EMACS_INT.
1770 * search.c (string_match_1, fast_string_match)
1771 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1772 (scan_buffer, find_next_newline_no_quit)
1773 (find_before_next_newline, search_command, Freplace_match)
1774 (Fmatch_data): Make some `int' variables be EMACS_INT.
1775
1776 * xdisp.c (display_count_lines): 3rd argument and return value now
1777 EMACS_INT. All callers changed.
1778 (pint2hrstr): Last argument is now EMACS_INT.
1779
1780 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1781 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1782 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1783 (decode_coding_utf_16, decode_coding_emacs_mule)
1784 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1785 (decode_coding_ccl, decode_coding_charset)
1786 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1787 (decode_coding_iso_2022, decode_coding_emacs_mule)
1788 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1789 <char_offset, last_offset>: Declare EMACS_INT.
1790 (encode_coding_utf_8, encode_coding_utf_16)
1791 (encode_coding_emacs_mule, encode_invocation_designation)
1792 (encode_designation_at_bol, encode_coding_iso_2022)
1793 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1794 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1795 Declare EMACS_INT.
1796 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1797 (encode_invocation_designation): Last argument P_NCHARS is now
1798 EMACS_INT.
1799 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1800 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1801
1802 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1803 All users changed.
1804
1805 * ccl.c (Fccl_execute_on_string): Declare some variables
1806 EMACS_INT.
1807
8546720e 18082011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1809
1810 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1811
4e19a977
CS
18122011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1813
1814 * process.c (Fformat_network_address): Doc fix.
1815
87302331
R
18162011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1817
1818 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1819
cbb59342
CY
18202011-04-08 Chong Yidong <cyd@stupidchicken.com>
1821
1822 * keyboard.c (read_char): Call Lisp function help-form-show,
1823 instead of using internal_with_output_to_temp_buffer.
1824 (Qhelp_form_show): New var.
e0d38eeb 1825 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1826
1827 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1828
1829 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1830
e67a13ab
CY
18312011-04-06 Chong Yidong <cyd@stupidchicken.com>
1832
04f2d78b
CB
1833 * process.c (Flist_processes): Remove to Lisp.
1834 (list_processes_1): Delete.
e67a13ab 1835
973f782d
EZ
18362011-04-06 Eli Zaretskii <eliz@gnu.org>
1837
7c106b1e
EZ
1838 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1839
973f782d
EZ
1840 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1841
41cf7d1a 18422011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1843
ca23cc88
PE
1844 Fix more problems found by GCC 4.6.0's static checks.
1845
f390e2d5
PE
1846 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1847
42eea0d0
PE
1848 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1849
b69769da 1850 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1851
f9541e84
PE
1852 * xdisp.c (vmessage): Mark as a printf-like function.
1853
13841b55
PE
1854 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1855
c136c10f
PE
1856 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1857
5e2d4a30
PE
1858 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1859 printf-like functions.
1860 (tiff_load): Add casts to remove these marks before passing them
1861 to system-supplied API.
1862
583f48b9
PE
1863 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1864
b25d760e
PE
1865 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1866 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1867 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1868 directly, rather than having caller test rule sign. This avoids
1869 some unnecessary tests.
1870 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1871 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1872 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1873
bc7b6697 1874 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1875 (xfont_open): Avoid unnecessary tests.
bc7b6697 1876
27ccc379
PE
1877 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1878
dcd5c89a
PE
1879 * composite.h, composite.c (composition_gstring_put_cache):
1880 Use EMACS_INT, not int, for length.
1881
b13a45c6
PE
1882 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1883 breaking out part of COMPOSITION_DECODE_RULE.
1884 (COMPOSITION_DECODE_RULE): Use it.
1885 * composite.c (get_composition_id): Remove unused local vars,
1886 by using the new macro.
1887
1e792e4d
PE
1888 * textprop.c (set_text_properties_1): Change while to do-while,
1889 since the condition is always true at first.
1890
dc6c6455 1891 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1892 (interval_deletion_adjustment): Return unsigned value.
1893 All uses changed.
dc6c6455 1894
aba7731a
PE
1895 * process.c (list_processes_1, create_pty, read_process_output):
1896 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1897 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1898 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1899 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1900 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1901
fdfc4bf3
PE
1902 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1903
fca8fe46 1904 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1905 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1906
06a0259a 1907 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1908 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1909 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1910
e7b9e80f
PE
1911 * print.c (print_error_message): Avoid int overflow.
1912
56201685
PE
1913 * font.c (font_list_entities): Redo for clarity,
1914 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1915
78834453 1916 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1917 (font_score): Avoid potential overflow in diff calculation.
78834453 1918
0bc0b309 1919 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1920 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1921
e610eaca
PE
1922 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1923
b895abce
PE
1924 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1925 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1926 can always succeed if overflow has undefined behavior.
1927
1f1d9321 1928 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1929 (wordify): Omit three unnecessary tests.
1f1d9321 1930
c59478bc
PE
1931 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1932 All callers changed. This avoids the need for an unused var.
1933
79b73827
PE
1934 * casefiddle.c (casify_region): Remove var that is set but not used.
1935
a4db5dfe
PE
1936 * dired.c (file_name_completion): Remove var that is set but not used.
1937
43aae36e
PE
1938 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1939
2a47c44d 1940 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1941 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1942
a37c69bf
PE
1943 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1944 Check for integer overflow on size calculations.
1945
328ab8e7
PE
1946 * buffer.c (Fprevious_overlay_change): Remove var that is set
1947 but not used.
1948
e5a2a5cb
PE
1949 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1950 Remove vars that are set but not used.
8d84a6eb 1951 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1952 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1953
a60e5f68
PE
1954 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1955
f661cb61 1956 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1957 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1958
f0397f5a
PE
1959 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1960 that are set but not used.
1961
8664db06 1962 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1963 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1964
6abdaa4a
PE
1965 * xselect.c (x_get_local_selection, x_handle_property_notify):
1966 Remove vars that are set but not used.
1967
0ce7538d 1968 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1969 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1970
9ae848fc
PE
1971 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1972 Remove var that is set but not used.
0b918413
PE
1973 (scroll_bar_windows_size): Now size_t, not int.
1974 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1975 Check for overflow.
9ae848fc 1976
a5a62657
PE
1977 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1978 (map_tty_color) [!defined MSDOS]: Likewise.
1979
5c5cdd39
PE
1980 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1981
66ebf983
PE
1982 * coding.c: Remove vars that are set but not used.
1983 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1984 All callers changed.
1985 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1986 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1987 (decode_coding_charset): Remove vars that are set but not used.
1988
1be4d761
PE
1989 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1990 that is set but not used.
1991
47553fa8
PE
1992 * print.c (print_object): Remove var that is set but not used.
1993
1f7196bf 1994 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1995 The gnulib version avoids calling malloc in the usual case,
1996 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1997 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1998 * filelock.c (current_lock_owner): Likewise.
1999 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2000 * sysdep.c: Include allocator.h, careadlinkat.h.
2001 (emacs_no_realloc_allocator): New static constant.
2002 (emacs_readlink): New function.
fdb61804
PE
2003 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2004 ../lib/careadlinkat.h.
d1fdcab7 2005
f84c17c7
SM
20062011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2007
2008 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2009 first non-nil return value).
2010
ef3862ad
JD
20112011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2012
2013 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2014 if not defined (Bug#8403).
2015
376a7006
JB
20162011-04-02 Juanma Barranquero <lekktu@gmail.com>
2017
2018 * xdisp.c (display_count_lines): Remove parameter `start',
2019 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2020 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2021 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2022 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2023 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2024 and thereabouts. All callers changed.
2025 (get_per_char_metric): Remove parameter `f', unused since
2026 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2027
6ca3801d
JM
20282011-04-02 Jim Meyering <meyering@redhat.com>
2029
2030 do not dereference NULL upon failed strdup
2031 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2032 (ns_get_family): Likewise.
2033
d8e2b5ba
JB
20342011-04-02 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2037
8c74fcbd
JD
20382011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2039
2040 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2041 later (Bug#8403).
2042
7200d79c
SM
20432011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2044
03408648 2045 Add lexical binding.
7200d79c 2046
03408648
SM
2047 * window.c (Ftemp_output_buffer_show): New fun.
2048 (Fsave_window_excursion):
2049 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2050
2051 * lread.c (lisp_file_lexically_bound_p): New function.
2052 (Fload): Bind Qlexical_binding.
2053 (readevalloop): Remove `evalfun' arg.
2054 Bind Qinternal_interpreter_environment.
2055 (Feval_buffer): Bind Qlexical_binding.
2056 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2057 Mark as dynamic.
2058 (syms_of_lread): Declare `lexical-binding'.
2059
2060 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2061
2062 * keyboard.c (eval_dyn): New fun.
2063 (menu_item_eval_property): Use it.
ca105506
SM
2064
2065 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2066
03408648
SM
2067 * fns.c (concat, mapcar1): Accept byte-code-functions.
2068
2069 * eval.c (Fsetq): Handle lexical vars.
2070 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2071 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2072 (FletX, Flet): Obey lexical binding.
2073 (Fcommandp): Handle closures.
2074 (Feval): New `lexical' arg.
2075 (eval_sub): New function extracted from Feval. Use it almost
2076 everywhere where Feval was used. Look up vars in lexical env.
2077 Handle closures.
2078 (Ffunctionp): Move from subr.el.
2079 (Ffuncall): Handle closures.
2080 (apply_lambda): Remove `eval_flags'.
2081 (funcall_lambda): Handle closures and new byte-code-functions.
2082 (Fspecial_variable_p): New function.
2083 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2084 but without exporting it to Lisp.
23aba0ea 2085
23aba0ea 2086 * doc.c (Fdocumentation, store_function_docstring):
03408648 2087 * data.c (Finteractive_form): Handle closures.
23aba0ea 2088
03408648
SM
2089 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2090 interactive spec.
ba83908c 2091
04f2d78b
CB
2092 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2093 New byte-codes.
03408648
SM
2094 (exec_byte_code): New function extracted from Fbyte_code to handle new
2095 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2096
03408648 2097 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2098
03408648 2099 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2100
e2abce01
JB
21012011-03-31 Juanma Barranquero <lekktu@gmail.com>
2102
2103 * xdisp.c (redisplay_internal): Fix prototype.
2104
63696a73 21052011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2106
63696a73 2107 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2108 (try_scrolling): Use it when setting scroll_limit.
2109 Limit scrolling to 100 screen lines.
63696a73
EZ
2110 (redisplay_window): Even when falling back on "recentering",
2111 position point in the window according to scroll-conservatively,
2112 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2113
2114 (try_scrolling): When point is above the window, allow searching
2115 as far as scroll_max, or one screenful, to compute vertical
2116 distance from PT to the scroll margin position. This prevents
2117 try_scrolling from unnecessarily failing when
2118 scroll-conservatively is set to a value slightly larger than the
2119 window height. Clean up the case of PT below the margin at bottom
2120 of window: scroll_max can no longer be INT_MAX. When aggressive
2121 scrolling is in use, don't let point enter the opposite scroll
2122 margin as result of the scroll.
2123 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2124 threshold of 100 lines for never-recentering scrolling.
2125
e4cc2dfc
JB
21262011-03-31 Juanma Barranquero <lekktu@gmail.com>
2127
2128 * dispextern.h (move_it_by_lines):
2129 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2130 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2131 (message_log_check_duplicate): Remove parameters `prev_bol' and
2132 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2133 (redisplay_internal): Remove parameter `preserve_echo_area',
2134 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2135
2136 * indent.c (Fvertical_motion):
2137 * window.c (window_scroll_pixel_based, Frecenter):
2138 Don't pass `need_y_p' to `move_it_by_lines'.
2139
1c470562
SM
21402011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2141
44f230aa
SM
2142 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2143 steal a few bits to be more compact.
2144 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2145 Remove unneeded casts.
2146
1c470562
SM
2147 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2148
888adce9
ZK
21492011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2150
2151 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2152 binding" message (bug#7967).
2153
f838ed7b
PE
21542011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2155
77861b95
PE
2156 Fix more problems found by GCC 4.6.0's static checks.
2157
de6dbc14
PE
2158 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2159 Remove unused local var.
2160
f838ed7b
PE
2161 * editfns.c (Fmessage_box): Remove unused local var.
2162
792c7b2b
PE
2163 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2164 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2165 Omit unused local vars.
c499e557 2166 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2167 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2168 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2169 Omit unused local var.
2170
ba0165e1
PE
2171 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2172 Don't assume string length fits in int.
32ad8845 2173 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2174 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2175
3c59b4c9
PE
2176 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2177 instead of alloca (Bug#8344).
2178
a3eed478 2179 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2180 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2181
eb4d412d
PE
2182 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2183
1658b401
PE
2184 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2185 concerns.
2186
2187 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2188
2189 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2190
9a2c6e05
PE
2191 * keyboard.c (syms_of_keyboard): Use the same style as later
2192 in this function when indexing through an array. This also
2193 works around GCC bug 48267.
2194
03d0a109
PE
2195 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2196
44f730c8
PE
2197 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2198
fe75f926
PE
2199 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2200 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2201
ffa8c828
PE
2202 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2203 This avoids undefined behavior on integer overflow, and is a bit
2204 more convenient anyway since it is compared to a size_t variable.
2205
c5101a77
PE
2206 Variadic C functions now count arguments with size_t, not int.
2207 This avoids an unnecessary limitation on 64-bit machines, which
2208 caused (substring ...) to crash on large vectors (Bug#8344).
2209 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2210 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2211 All variadic functions and their callers changed accordingly.
c5101a77
PE
2212 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2213 * data.c (arith_driver, float_arith_driver): Likewise.
2214 * editfns.c (general_insert_function): Likewise.
2215 * eval.c (struct backtrace.nargs, interactive_p)
2216 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2217 (funcall_lambda, mark_backtrace): Likewise.
2218 * fns.c (concat): Likewise.
2219 * frame.c (x_set_frame_parameters): Likewise.
2220 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2221 0 if not found, not -1. All callers changed.
2222
dd3f25f7
PE
2223 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2224 (stack_copy_size): Now size_t, not int.
2225 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2226
461c2ab9
JB
22272011-03-28 Juanma Barranquero <lekktu@gmail.com>
2228
2229 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2230 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2231 All callers changed.
2232
2233 * lisp.h (multibyte_char_to_unibyte):
2234 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2235 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2236 * character.h (CHAR_TO_BYTE8):
2237 * cmds.c (internal_self_insert):
2238 * editfns.c (general_insert_function):
2239 * keymap.c (push_key_description):
2240 * search.c (Freplace_match):
2241 * xdisp.c (message_dolog, set_message_1): All callers changed.
2242
f6d62986
SM
22432011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2244
2245 * keyboard.c (safe_run_hook_funcall): New function.
2246 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2247 don't set the hook to nil, but remove the offending function instead.
2248 (Qcommand_hook_internal): Remove, unused.
2249 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2250 Vcommand_hook_internal.
2251
2252 * eval.c (enum run_hooks_condition): Remove.
2253 (funcall_nil, funcall_not): New functions.
2254 (run_hook_with_args): Call each function through a `funcall' argument.
2255 Remove `cond' argument, now redundant.
2256 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2257 (Frun_hook_with_args_until_failure): Adjust accordingly.
2258 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2259
1db5b1ad
JB
22602011-03-28 Juanma Barranquero <lekktu@gmail.com>
2261
2262 * dispextern.h (string_buffer_position): Remove declaration.
2263
2264 * print.c (strout): Remove parameter `multibyte', unused since
2265 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2266
2267 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2268 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2269 All callers changed.
2270
2271 * w32.c (_wsa_errlist): Use braces for struct initializers.
2272
2273 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2274 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2275 All callers changed.
2276 (string_buffer_position): Likewise. Also, make static (it's never
2277 used outside xdisp.c).
2278 (cursor_row_p): Remove parameter `w', unused since
2279 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2280 (decode_mode_spec): Remove parameter `precision', introduced during
2281 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2282 All callers changed.
2283
5ffb62aa
JD
22842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2285
2286 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2287
461c2ab9 22882011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2289
2290 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2291 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2292 (ns_update_auto_hide_menu_bar): New functions.
2293 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2294 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2295 ns_constrain_all_frames.
2296 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2297 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2298
5c380ffb
JD
22992011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2300
2301 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2302
9af30bdf
GM
23032011-03-27 Glenn Morris <rgm@gnu.org>
2304
2305 * syssignal.h: Replace RETSIGTYPE with void.
2306 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2307 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2308 Replace SIGTYPE with void everywhere.
2309 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2310 * s/template.h (SIGTYPE): Remove commented out definition.
2311
e2abce01
JB
23122011-03-26 Eli Zaretskii <eliz@gnu.org>
2313
2314 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2315 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2316
f868cd8a
JB
23172011-03-26 Juanma Barranquero <lekktu@gmail.com>
2318
59eb0929
JB
2319 * w32.c (read_unc_volume): Use parameter `henum', instead of
2320 global variable `wget_enum_handle'.
2321
2322 * keymap.c (describe_vector): Remove parameters `indices' and
2323 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2324 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2325
f868cd8a
JB
2326 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2327
2328 * keyboard.c (timer_check): Remove parameter `do_it_now',
2329 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2330 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2331 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2332
2333 * keyboard.c (read_char):
2334 * w32menu.c (w32_menu_display_help):
2335 * xmenu.c (show_help_event, menu_help_callback):
2336 Adjust calls to `show_help_echo'.
2337
2338 * gtkutil.c (xg_maybe_add_timer):
2339 * keyboard.c (readable_events):
2340 * process.c (wait_reading_process_output):
2341 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2342
2343 * insdel.c (adjust_markers_gap_motion):
2344 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2345 (gap_left, gap_right): Don't call it.
2346
2ecf6fdb
CY
23472011-03-25 Chong Yidong <cyd@stupidchicken.com>
2348
2349 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2350 incurred during fontification.
2351
6b1f9ba4
JB
23522011-03-25 Juanma Barranquero <lekktu@gmail.com>
2353
2354 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2355 (DEFVAR_PER_BUFFER): Don't pass it.
2356
2357 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2358 (scrolling_window): Don't pass it.
2359
0f4a96b5
JB
23602011-03-25 Juanma Barranquero <lekktu@gmail.com>
2361
2362 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2363
2364 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2365 and `suffix'.
2366 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2367 of variables specific to SELinux and computation of `encoded_absname'.
2368
2369 * image.c (XPutPixel): Remove unused variable `height'.
2370
2371 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2372
2373 * unexw32.c (get_section_info): Remove unused variable `section'.
2374
2375 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2376 (system_process_attributes): Remove unused variable `sess'.
2377 (sys_read): Remove unused variable `err'.
2378
2379 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2380 (w32_wnd_proc): Remove unused variable `isdead'.
2381 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2382 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2383 (x_create_tip_frame): Remove unused variable `tem'.
2384
2385 * w32inevt.c (w32_console_read_socket):
2386 Remove unused variable `no_events'.
2387
2388 * w32term.c (x_draw_composite_glyph_string_foreground):
2389 Remove unused variable `width'.
2390
1149507c
JB
23912011-03-24 Juanma Barranquero <lekktu@gmail.com>
2392
2393 * w32term.c (x_set_glyph_string_clipping):
2394 Don't pass uninitialized region to CombineRgn.
2395
9c88f339
JB
23962011-03-23 Juanma Barranquero <lekktu@gmail.com>
2397
2398 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2399 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2400 (Fx_close_connection): Remove unused variable `i'.
2401
2402 * w32font.c (w32font_draw): Return number of glyphs.
2403 (w32font_open_internal): Remove unused variable `i'.
2404 (w32font_driver): Add missing initializer.
2405
2406 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2407 (fill_in_menu): Remove unused variable `items_added'.
2408
2409 * w32term.c (last_mouse_press_frame): Remove static global variable.
2410 (w32_clip_to_row): Remove unused variable `f'.
2411 (x_delete_terminal): Remove unused variable `i'.
2412
2413 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2414 (NOTHING): Remove unused static global variable.
2415 (uniscribe_check_otf): Remove unused variable `table'.
2416 (uniscribe_font_driver): Add missing initializers.
2417
dee091a3
JD
24182011-03-23 Julien Danjou <julien@danjou.info>
2419
2420 * term.c (Fsuspend_tty, Fresume_tty):
2421 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2422 * window.c (temp_output_buffer_show):
2423 * insdel.c (signal_before_change):
2424 * frame.c (Fhandle_switch_frame):
2425 * fileio.c (Fdo_auto_save):
2426 * emacs.c (Fkill_emacs):
2427 * editfns.c (save_excursion_restore):
2428 * cmds.c (internal_self_insert):
2429 * callint.c (Fcall_interactively):
2430 * buffer.c (Fkill_all_local_variables):
2431 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2432 Use Frun_hooks.
0f4a96b5 2433 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2434 unconditionnaly since it does the check itself.
2435
2c520ab5 24362011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2437
c9c49752
PE
2438 Fix more problems found by GCC 4.5.2's static checks.
2439
8abc3f12
PE
2440 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2441 the first time through the loop, since we know p0 < p1 then.
2442 This also avoids a gcc -Wstrict-overflow warning.
2443
a2d26660
PE
2444 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2445 leading to a memory leak, possible in functions like
2446 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2447 of objects (Bug#8318).
a2d26660 2448
916c72e9
PE
2449 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2450 that could (at least in theory) be that large.
2451
19ab8a18
PE
2452 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2453 This is less likely to overflow, and avoids undefined behavior if
2454 overflow does occur. All callers changed. Use strtoul to scan
2455 for the unsigned long integer.
b7cbbd6f
PE
2456 (pint2hrstr): Simplify and tune code slightly.
2457 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2458
f0641eff
PE
2459 * scroll.c (do_scrolling): Work around GCC bug 48228.
2460 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2461
7f650bb9
PE
2462 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2463 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2464 (validate_x_resource_name): Simplify count usage.
2465 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2466
37dd57d1
PE
2467 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2468 fail (Bug#8306).
81e56e61 2469
699979fc 2470 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2471
401bf9b4
PE
2472 * process.c (Fmake_network_process): Use socklen_t, not int,
2473 where POSIX says socklen_t is required in portable programs.
2474 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2475 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2476 (Fmake_network_process, server_accept_connection):
2477 (wait_reading_process_output, read_process_output):
2478 Likewise.
2479
b93aacde
PE
2480 * process.c: Rename or move locals to avoid shadowing.
2481 (list_processes_1, Fmake_network_process):
2482 (read_process_output_error_handler, exec_sentinel_error_handler):
2483 Rename or move locals.
4dc343ee 2484 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2485 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2486 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2487 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2488 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2489
af8a867c 2490 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2491 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2492 Include tparam.h instead, since it declares them.
af8a867c
PE
2493 * cm.h (PC): Remove extern decl; tparam.h now does this.
2494 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2495 * terminfo.c: Include tparam.h, to check interfaces.
2496 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2497 (tparam): Adjust signature to match interface in tparam.h;
2498 this removes some undefined behavior. Check that outstring and len
2499 are zero, which they always are with Emacs.
2500 * tparam.h (PC, BC, UP): New extern decls.
2501
0248044d 2502 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2503 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2504
8ff096c1 2505 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2506 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2507 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2508 (ftfont_list): Remove unused local.
49eaafba
PE
2509 (get_adstyle_property, ftfont_pattern_entity):
2510 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2511 Rename locals to avoid shadowing.
8ff096c1 2512
e2be39f6
PE
2513 * xfont.c (xfont_list_family): Mark var as initialized.
2514
c9735e30
PE
2515 * xml.c (make_dom): Now static.
2516
8f5201ae
PE
2517 * composite.c (composition_compute_stop_pos): Rename local to
2518 avoid shadowing.
b246f932
PE
2519 (composition_reseat_it): Remove unused locals.
2520 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2521 (composition_update_it): Mark var as initialized.
11b61122
PE
2522 (find_automatic_composition): Mark vars as initialized,
2523 with a FIXME (Bug#8290).
8f5201ae 2524
760fbc2c
PE
2525 character.h: Rename locals to avoid shadowing.
2526 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2527 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2528 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2529 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2530 to avoid shadowing.
2531
ff08eb85
PE
2532 * textprop.c (property_change_between_p): Remove; unused.
2533
fc7bf025
PE
2534 * intervals.c (interval_start_pos): Now static.
2535
235d7abc
PE
2536 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2537
44f230aa
SM
2538 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2539 Rename locals to avoid shadowing.
3e7d6594 2540
50060332
PE
2541 * sound.c (wav_play, au_play, Fplay_sound_internal):
2542 Fix pointer signedness.
d01f234b 2543 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2544 (wav_play): Initialize a variable to 0, to prevent undefined
2545 behavior (Bug#8278).
50060332 2546
c4fc4e30
PE
2547 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2548
918436ed
PE
2549 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2550
c939f91b
PE
2551 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2552 clobbering (Bug#8298).
b9c7f648
PE
2553 * sysdep.c (sys_subshell): Likewise.
2554 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2555
6bd8c144
PE
2556 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2557 This should get cleaned up, so that child_setup has the
2558 same signature on all platforms.
2559
7710357c 2560 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2561 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2562
c59da222
CY
25632011-03-22 Chong Yidong <cyd@stupidchicken.com>
2564
2565 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2566 not to be necessary, and produces flickering.
2567
66b87493
GM
25682011-03-20 Glenn Morris <rgm@gnu.org>
2569
2570 * config.in: Remove file.
2571
45b6f6d5
JB
25722011-03-20 Juanma Barranquero <lekktu@gmail.com>
2573
2574 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2575 are now in src/globals.h.
2576 (syms_of_minibuf): Remove spurious & from previous change.
2577
3ec03f7e
LL
25782011-03-20 Leo <sdl.web@gmail.com>
2579
2580 * minibuf.c (completing-read-function): New variable.
2581 (completing-read-default): Rename from completing-read.
2582 (completing-read): Call completing-read-function.
2583
b14e3e21
CY
25842011-03-19 Juanma Barranquero <lekktu@gmail.com>
2585
2586 * xfaces.c (Fx_load_color_file):
2587 Read color file from absolute filename (bug#8250).
2588
f2b726e6
JB
25892011-03-19 Juanma Barranquero <lekktu@gmail.com>
2590
2591 * makefile.w32-in: Update dependencies.
2592
09f6ff02
EZ
25932011-03-17 Eli Zaretskii <eliz@gnu.org>
2594
2595 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2596
29a6015a
PE
25972011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2598
a3a6c54e
PE
2599 Fix more problems found by GCC 4.5.2's static checks.
2600
b766f867
PE
2601 * process.c (make_serial_process_unwind, send_process_trap):
2602 (sigchld_handler): Now static.
2603
be02381c
PE
2604 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2605 That way, the code declares only the vars that it needs.
2606 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2607 * s/cygwin.h (PTY_ITERATION): Likewise.
2608 * s/darwin.h (PTY_ITERATION): Likewise.
2609 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2610
57048744
PE
2611 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2612 * process.c (allocate_pty): Don't declare stb unless it's needed.
2613
7914961c 2614 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2615 (CONSTANTLIM): Remove; unused.
2616 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2617 Define only if needed.
7914961c 2618
b3967b18
PE
2619 * unexelf.c (unexec): Name an expression,
2620 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2621 Use a different way to cause a compilation error if anyone uses
2622 n rather than nn, a way that does not involve shadowing.
73366a00 2623 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2624
29a6015a
PE
2625 * deps.mk (unexalpha.o): Remove; unused.
2626
43cfc33e 2627 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2628 * unexec.h: New file.
ce701a33
PE
2629 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2630 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2631 Depend on unexec.h.
2632 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2633 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2634 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2635 Change as necessary to match prototype in unexec.h.
ce701a33 2636
01f44d5a
PE
2637 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2638 shadowing.
4f63c6bb 2639 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2640
a6670b0b
PE
2641 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2642 Rename locals to avoid shadowing.
2643
cef2010d 2644 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2645 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2646
d4d7173a
PE
2647 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2648
f08b802a
PE
2649 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2650 warning when compiling print.c.
2651
3ddb0639
PE
2652 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2653 instead of using an uninitialized var.
5ad03b97 2654 (font_sort_entities): Mark var as initialized.
3ddb0639 2655
170a2692
PE
2656 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2657
e663c700
PE
2658 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2659 pointers to constants.
89bc529a 2660 (font_parse_fcname): Remove unused vars.
7b81e2d0 2661 (font_delete_unmatched): Now static.
ea838e10 2662 (font_get_spec): Remove; unused.
13a547c6
PE
2663 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2664 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2665 Rename or move locals to avoid shadowing.
e663c700 2666
2a80c887 2667 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2668 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2669
1384fa33 2670 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2671 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2672
8b2c52e9
PE
2673 * alloc.c (mark_backtrace): Move decl from here ...
2674 * lisp.h: ... to here, so that it can be checked.
2675
475545b5 2676 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2677 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2678 (lisp_indirect_variable): Name an expression,
2679 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2680 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2681
b1349114 2682 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2683 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2684 Use const pointer when appropriate.
b1349114 2685
a2928364
PE
2686 * lisp.h (get_system_name, get_operating_system_release):
2687 Move decls here, to check interfaces.
2688 * process.c (get_operating_system_release): Move decl to lisp.h.
2689 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2690 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2691 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2692 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2693 (Fformat_time_string, Fencode_time, Finsert_char):
2694 (Ftranslate_region_internal, Fformat):
2695 Rename or remove local vars to avoid shadowing.
9710023e 2696 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2697
a415e694
PE
2698 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2699 avoid shadowing.
2700
8ef4622d
PE
2701 * lisp.h (eassert): Check that the argument compiles, even if
2702 ENABLE_CHECKING is not defined.
2703
946f9a5b
PE
2704 * data.c (Findirect_variable): Name an expression, to avoid
2705 gcc -Wbad-function-cast warning.
112396d6 2706 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2707 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2708 (Fmake_variable_buffer_local, Fmake_local_variable):
2709 Mark variables as initialized.
52746918 2710 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2711
e5aab7e7 2712 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2713 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2714 Rename locals to avoid shadowing.
dff45157
PE
2715 (mark_stack): Move local variables into the #ifdef region where
2716 they're used.
7bc26fdb
PE
2717 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2718 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2719 needed otherwise.
2720 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2721 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2722 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2723
e5aab7e7
PE
2724 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2725 avoids undefined behavior in theory.
2726
4da60324
PE
2727 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2728
88043301
PE
2729 Use functions, not macros, for up- and down-casing (Bug#8254).
2730 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2731 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2732 to use the following functions instead of these macros.
2733 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2734 EMACS_INT, since callers assume the returned value fits in int.
2735 (upcase1): Likewise, for UPCASE_TABLE.
2736 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2737 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2738 the race-condition problem in the old DOWNCASE.
88043301 2739
19ed5445
PE
2740 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2741 Rename locals to avoid shadowing.
2742 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2743 (regex_compile, re_search_2, re_match_2_internal):
2744 Remove unused local vars.
952db0d7
PE
2745 (FREE_VAR): Rewrite so as not to use empty "else",
2746 which gcc can warn about.
da053e48 2747 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2748 (RETALLOC_IF): Define only if needed.
2749 (WORDCHAR_P): Likewise. This one is never needed, but is used
2750 only in a comment talking about a compiler bug, so put inside
2751 the #if 0 of that comment.
2752 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2753 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2754 Remove; unused.
19ed5445 2755
1f3561e4 2756 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2757 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2758 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2759
ded6f8f7
PE
2760 * search.c (simple_search): Remove unused var.
2761
dbd37a95
PE
2762 * dired.c (compile_pattern): Move decl from here ...
2763 * lisp.h: ... to here, so that it can be checked.
2764 (struct re_registers): New forward decl.
2765
7e47afad
PE
2766 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2767
85f24f61
PE
2768 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2769 All uses changed.
2770 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2771 Rename locals to avoid shadowing.
5671df8f 2772 (Fvertical_motion): Mark locals as initialized.
85f24f61 2773
181aa2be 2774 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2775 (casify_region): Mark local as initialized.
181aa2be 2776
930d429c
PE
2777 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2778
7082eac6
PE
2779 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2780 New macros, so that the caller can use some names other than
2781 gcpro1, gcpro2, etc.
2782 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2783 of the new macros.
2784 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2785 argument, for consistency with GCPRO2_VAR, etc: it is now the
2786 prefix of the variable, not the variable itself. All uses
2787 changed.
38b2c076
PE
2788 * dired.c (directory_files_internal, file_name_completion):
2789 Rename locals to avoid shadowing.
2790
15206ed9
PE
2791 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2792 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2793 dired.c's scmp function, had undefined behavior.
2794 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2795 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2796 * buffer.h: ... to here, because these macros use current_buffer,
2797 and the new implementation with inline functions needs to have
2798 current_buffer in scope now, rather than later when the macros
2799 are used.
2800 (downcase, upcase1): New static inline functions.
2801 (DOWNCASE, UPCASE1): Reimplement using these functions.
2802 This avoids undefined behavior in expressions like
2803 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2804 from race conditions in accessing the global variables
2805 case_temp1 and case_temp2.
2806 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2807 * lisp.h (case_temp1, case_temp2): Remove their decls.
2808 * character.h (ASCII_CHAR_P): Move from here ...
2809 * lisp.h: ... to here, so that the inline functions mentioned
2810 above can use them.
2811
4a6bea26
PE
2812 * dired.c (directory_files_internal_unwind): Now static.
2813
f14b7e14
PE
2814 * fileio.c (file_name_as_directory, directory_file_name):
2815 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2816 Now static.
2893f146
PE
2817 (file_name_as_directory): Use const pointers when appropriate.
2818 (Fexpand_file_name): Likewise. In particular, newdir might
2819 point at constant storage, so make it a const pointer.
fd4ead52 2820 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2821 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2822 signedness issues.
f839df0c
PE
2823 (Fset_file_times, Finsert_file_contents, auto_save_error):
2824 Rename locals to avoid shadowing.
f14b7e14 2825
5716756e 2826 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2827 (Ftry_completion, Fall_completions): Rename or remove locals
2828 to avoid shadowing.
5716756e 2829
b4c3046a
PE
2830 * marker.c (bytepos_to_charpos): Remove; unused.
2831
b45db522
PE
2832 * lisp.h (verify_bytepos, count_markers): New decls,
2833 so that gcc does not warn that these functions aren't declared.
2834
85876d07
PE
2835 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2836 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2837 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2838 (copy_text): Remove unused local var.
85876d07 2839
03d78a21 2840 * filelock.c (within_one_second): Now static.
b3dd38ab 2841 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2842
5df8f01b
PE
2843 * buffer.c (fix_overlays_before): Mark locals as initialized.
2844 (fix_start_end_in_overlays): Likewise. This function should be
2845 simplified by using pointers-to-pointers, but that's a different
2846 matter.
b1d876f1 2847 (switch_to_buffer_1): Now static.
8f54f30a
PE
2848 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2849 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2850
a70072c9 2851 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2852 Fix pointer signedness issue.
edced198
PE
2853 (sys_subshell): Mark local as volatile if checking for lint,
2854 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2855 (MAXPATHLEN): Define only if needed.
a70072c9 2856
a0977c44
PE
2857 * process.c (serial_open, serial_configure): Move decls from here ...
2858 * systty.h: ... to here, so that they can be checked.
2859
a884fdcc
PE
2860 * fns.c (get_random, seed_random): Move extern decls from here ...
2861 * lisp.h: ... to here, so that they can be checked.
2862
604efe86 2863 * sysdep.c (reset_io): Now static.
b8950c94 2864 (wait_for_termination_signal): Remove; unused.
604efe86 2865
38fc62d9
PE
2866 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2867 (copy_keymap_item, append_key, push_text_char_description):
2868 Now static.
1004a21a 2869 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2870 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2871 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2872 (describe_map_tree):
2873 Rename locals to avoid shadowing.
38fc62d9 2874
2f2650da
PE
2875 * keyboard.c: Declare functions static if they are not used elsewhere.
2876 (echo_char, echo_dash, cmd_error, top_level_2):
2877 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2878 (read_char, kbd_buffer_get_event, make_lispy_position):
2879 (make_lispy_event, make_lispy_movement, apply_modifiers):
2880 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2881 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2882 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2883 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2884 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2885
a053e86c 2886 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2887 (mark_kboards): Move decl here ...
2888 * alloc.c (mark_kboards): ... from here.
a053e86c 2889
4752793e
PE
2890 * lisp.h (force_auto_save_soon): New decl.
2891
74f10ca7 2892 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2893 (DEFINE_DUMMY_FUNCTION): New macro.
2894 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2895 Use it.
c03cd23f
PE
2896 (main): Add casts to avoid warnings
2897 if GCC considers string literals to be constants.
74f10ca7 2898
022e70d4
PE
2899 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2900
59d6fe83
PE
2901 * dbusbind.c: Pointer signedness fixes.
2902 (xd_signature, xd_append_arg, xd_initialize):
2903 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2904 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2905 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2906 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2907
78320123
PE
2908 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2909 if GCC considers string literals to be constants.
49cebcca 2910 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2911
35ac2a97
SM
29122011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2913
fb103ca9
SM
2914 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2915 (print_preprocess, print_object): New macro to fix last change.
2916
35ac2a97
SM
2917 * print.c (print_preprocess): Don't forget font objects.
2918
62973b41
JB
29192011-03-16 Juanma Barranquero <lekktu@gmail.com>
2920
2921 * emacs.c (USAGE3): Doc fixes.
2922
0e48bb22
AS
29232011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2924
2925 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2926 structure.
2927
7684e57b
JB
29282011-03-14 Juanma Barranquero <lekktu@gmail.com>
2929
2930 * lisp.h (VWindow_system, Qfile_name_history):
2931 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2932 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2933 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2934
2935 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2936 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2937
2938 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2939 * w32console.c (detect_input_pending, read_input_pending)
2940 (encode_terminal_code):
2941 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2942 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2943 (w32_system_caret_y, Qfile_name_history):
2944 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2945 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2946 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2947 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2948 * w32proc.c (Qlocal, report_file_error):
2949 * w32term.c (Vwindow_system, updating_frame):
2950 * w32uniscribe.c (initialized, uniscribe_font_driver):
2951 Remove unneeded extern declarations.
2952
2aa46d6c
CY
29532011-03-14 Chong Yidong <cyd@stupidchicken.com>
2954
c96bbc66 2955 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2956
cffc6f3b
CY
29572011-03-13 Chong Yidong <cyd@stupidchicken.com>
2958
2959 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2960 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2961 These macros can no longer be used for assignment.
2962
44f230aa
SM
2963 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2964 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2965 (record_buffer_markers, fetch_buffer_markers): New functions for
2966 recording and fetching special buffer markers.
2967 (set_buffer_internal_1, set_buffer_temp): Use them.
2968
2969 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2970
2971 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2972
2973 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2974 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2975
2976 * xdisp.c (hscroll_window_tree):
2977 (reconsider_clip_changes): Use PT instead of BUF_PT.
2978
d251f04b
EZ
29792011-03-13 Eli Zaretskii <eliz@gnu.org>
2980
2981 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2982 $(EMACS_ROOT)/lib/intprops.h.
2983
f0c77cd1
PE
29842011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2985
3eca4629
PE
2986 Fix more problems found by GCC 4.5.2's static checks.
2987
7c86ee98
PE
2988 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2989 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2990 (xg_free_frame_widgets): Make it clear that a local variable is
2991 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2992 (gdk_window_get_screen): Make it clear that this macro is needed
2993 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2994 (int_gtk_range_get_value): New function, which avoids a diagnostic
2995 from gcc -Wbad-function-cast.
2996 (xg_set_toolkit_scroll_bar_thumb): Use it.
2997 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2998 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2999 (get_utf8_string, xg_get_file_with_chooser):
3000 Rename locals to avoid shadowing.
3001 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3002
41729b81
PE
3003 * xgselect.c (xg_select): Remove unused var.
3004
f0c77cd1
PE
3005 * image.c (four_corners_best): Mark locals as initialized.
3006 (gif_load): Initialize transparent_p to zero (Bug#8238).
3007 Mark another local as initialized.
ec6cf4c6 3008 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3009
ce0ad53d 3010 * image.c (clear_image_cache): Now static.
d5d5a617 3011 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3012 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3013 (x_edge_detection): Remove unnecessary cast that
3014 gcc -Wbad-function-cast diagnoses.
2037898d 3015 (gif_load): Fix pointer signedness.
6ae141d6
PE
3016 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3017 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3018
33383987 30192011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3020
d32df629
PE
3021 Improve quality of tests for time stamp overflow.
3022 For example, without this patch (encode-time 0 0 0 1 1
3023 1152921504606846976) returns the obviously-bogus value (-948597
3024 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3025 reports time overflow. See
3026 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3027 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3028 * editfns.c: Include limits.h and intprops.h.
3029 (TIME_T_MIN, TIME_T_MAX): New macros.
3030 (time_overflow): Move earlier, to before first use.
3031 (hi_time, lo_time): New functions, for an accurate test for
3032 out-of-range times.
3033 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3034 (Fget_internal_run_time): Don't assume time_t fits in int.
3035 (make_time): Use list2 instead of Fcons twice.
3036 (Fdecode_time): More accurate test for out-of-range times.
3037 (check_tm_member): New function.
3038 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3039 (lisp_time_argument): Don't rely on undefined left-shift and
3040 right-shift behavior when checking for time stamp overflow.
8be6f318 3041
fe31d94c
PE
3042 * editfns.c (time_overflow): New function, refactoring common code.
3043 (Fformat_time_string, Fdecode_time, Fencode_time):
3044 (Fcurrent_time_string): Use it.
3045
8be6f318
PE
3046 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3047 * dired.c (make_time): Move to ...
3048 * editfns.c (make_time): ... here.
3049 * systime.h: Note the move.
3050
09d9db2c 30512011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3052
126bc0dc
YM
3053 * fringe.c (update_window_fringes): Remove unused variables.
3054
c47cbdfd
YM
3055 * unexmacosx.c (copy_data_segment): Also copy __got section.
3056 (Bug#8223)
3057
7ac80be9
EZ
30582011-03-12 Eli Zaretskii <eliz@gnu.org>
3059
c96bbc66 3060 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3061 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3062 Constify `char *' arguments and their references according to
3063 prototypes in tparam.h.
3064
ecb0f94d 3065 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3066
7ac80be9
EZ
3067 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3068 Adapt all references accordingly.
3069
3070 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3071
ef1fd07e
TT
30722011-03-11 Tom Tromey <tromey@redhat.com>
3073
3074 * buffer.c (syms_of_buffer): Remove obsolete comment.
3075
7ef4b50c
EZ
30762011-03-11 Eli Zaretskii <eliz@gnu.org>
3077
3078 * termhooks.h (encode_terminal_code): Declare prototype.
3079
3080 * msdos.c (encode_terminal_code): Don't declare prototype.
3081
3082 * term.c (encode_terminal_code): Now external again, used by
3083 w32console.c and msdos.c.
3084
44f230aa
SM
3085 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3086 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3087
4b1ec863 30882011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3089
1714f52b 3090 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3091
4b1ec863
PE
3092 * fringe.c (update_window_fringes): Mark locals as initialized
3093 (Bug#8227).
3094 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3095
524c7aa6
PE
3096 * alloc.c (mark_fringe_data): Move decl from here ...
3097 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3098 to check its interface.
3099 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3100
a5c0af81 3101 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3102 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3103 (fontset_font): Mark local as initialized.
a9a06e0b 3104 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3105
b4716021
PE
3106 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3107
811e9bac 3108 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3109 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3110 (x_own_selection, Fx_disown_selection_internal): Rename locals
3111 to avoid shadowing.
3112 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3113
7e3ab302
PE
3114 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3115 so that the caller can use some name other than gcpro1.
3116 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3117 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3118 (Fx_backspace_delete_keys_p):
3119 Use them to avoid shadowing, and rename vars to avoid shadowing.
3120 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3121 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3122 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3123 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3124 Remove unused locals.
7e3ab302
PE
3125 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3126 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3127 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3128 macros.
f78faa98 3129
e2b13473
PE
3130 * xterm.h (x_mouse_leave): New decl.
3131
77f23912
PE
3132 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3133 Remove unused functions.
cdf4ba58
PE
3134 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3135 (x_calc_absolute_position): Now static.
7411c686 3136 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3137 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3138 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3139 unless they are used.
38d0b34a
PE
3140 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3141 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3142 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3143 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3144 (x_error_catcher, x_connection_closed, x_error_handler):
3145 (x_error_quitter, xembed_send_message, x_iconify_frame):
3146 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3147 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3148 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3149
44f230aa
SM
3150 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3151 Rename or move locals to avoid shadowing.
6b463e58 3152 (tty_defined_color, merge_face_heights): Now static.
5967d051 3153 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3154 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3155 does not deduce is never used uninitialized.
73719eba
PE
3156 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3157 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3158
426994c3 3159 * terminal.c (store_terminal_param): Now static.
5489860b 3160
032f1620 3161 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3162 (set_frame_menubar): Remove unused local.
d4323972 3163 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3164 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3165 since they might point to immutable storage.
281585b0
PE
3166 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3167 since it's unused otherwise.
032f1620 3168
367c19e5 3169 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3170 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3171 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3172 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3173 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3174 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3175 does not deduce are never used uninitialized.
70739cbe 3176
07b48fa9
PE
3177 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3178
8868a238 3179 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3180 * window.c (window_loop, size_window):
3181 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3182
7e5cf297 3183 * window.c (display_buffer): Now static.
d6550a9f
PE
3184 (size_window): Mark variables that gcc -Wuninitialized
3185 does not deduce are never used uninitialized.
a586633d
PE
3186 * window.h (check_all_windows): New decl, to forestall
3187 gcc -Wmissing-prototypes diagnostic.
5b555da1 3188 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3189
f6095868
PE
3190 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3191 shadowing.
3192 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3193 Include <limits.h>.
3194 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3195 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3196 (load_charset_map): Mark variables that gcc -Wuninitialized
3197 does not deduce are never used uninitialized.
53df7c11 3198 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3199
f38b440c
PE
3200 * coding.c (coding_set_source, coding_set_destination):
3201 Use "else { /* comment */ }" rather than "else /* comment */;"
3202 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3203 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3204 a block, when the outer 'i' will do.
3205 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3206 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3207 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3208 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3209 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3210 Rename locals to avoid shadowing.
3211 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3212 * coding.c (emacs_mule_char, encode_invocation_designation):
3213 Now static, since they're not used elsewhere.
413bb2db 3214 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3215 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3216 (decode_coding_emacs_mule): Mark variables that gcc
3217 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3218 (detect_coding_iso_2022): Initialize a local variable that might
3219 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3220 this initialization is needed. (Bug#8211)
5f58e762
PE
3221 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3222 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3223 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3224 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3225 Remove unused macros.
f38b440c 3226
232b38b9 3227 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3228 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3229 * character.c (string_count_byte8): Likewise.
232b38b9 3230
fb90da1b
PE
3231 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3232 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3233
fb93dbc2
PE
3234 * chartab.c (copy_sub_char_table): Now static, since it's not used
3235 elsewhere.
5c156ace
PE
3236 (sub_char_table_ref_and_range, char_table_ref_and_range):
3237 Rename locals to avoid shadowing.
bbcd0949 3238 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3239
7d3b3862 3240 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3241 (BIDI_BOB): Remove unused macro.
7d3b3862 3242
6be7d3da
PE
3243 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3244 deduce are never used uninitialized.
c2ed9c8b 3245 * term.c (encode_terminal_code): Likewise.
6be7d3da 3246
75f8807f 3247 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3248
50938595
PE
3249 * tparam.h: New file.
3250 * term.c, tparam.h: Include it.
3251 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3252 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3253 Move these decls to tparam.h, and make them agree with what
3254 is actually in tparam.c. The previous trick of using incompatible
3255 decls in different modules does not conform to the C standard.
3256 All callers of tparam changed to use tparam's actual API.
3257 * tparam.c (tparam1, tparam, tgoto):
3258 Use const pointers where appropriate.
3259
fbceeba2
PE
3260 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3261 * cm.h (struct cm): Likewise.
3262 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3263 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3264 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3265 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3266 (turn_on_face, init_tty): Likewise.
3267 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3268
7f3f1250
PE
3269 * term.c (term_mouse_position): Rename local to avoid shadowing.
3270
e6ca6543
PE
3271 * alloc.c (mark_ttys): Move decl from here ...
3272 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3273
c40f8d15
AS
32742011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3275
3276 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3277
cfe0661d
JB
32782011-03-09 Juanma Barranquero <lekktu@gmail.com>
3279
3280 * search.c (compile_pattern_1): Remove argument regp, unused since
3281 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3282 (compile_pattern): Don't pass it.
3283
0afb4571
J
32842011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3285
3286 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3287 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3288 for ! HAVE_GTK3.
3289 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3290
3291 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3292
3293 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3294 gdk_window_get_screen, gdk_window_get_geometry,
3295 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3296 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3297 (xg_get_pixbuf_from_pixmap): New function.
3298 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3299 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3300 Call xg_get_pixbuf_from_pixmap instead of
3301 gdk_pixbuf_get_from_drawable.
3302 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3303 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3304 (xg_check_special_colors): Use GtkStyleContext and its functions
3305 for HAVE_GTK3.
3306 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3307 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3308 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3309 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3310 Call gtk_widget_get_preferred_size.
0afb4571
J
3311 (xg_frame_resized): gdk_window_get_geometry only takes 5
3312 parameters.
44f230aa
SM
3313 (xg_win_to_widget, xg_event_is_for_menubar):
3314 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3315 (xg_set_widget_bg): New function.
3316 (delete_cb): New function.
895009e1 3317 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3318 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3319 (xg_set_background_color): Call xg_set_widget_bg.
3320 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3321 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3322 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3323 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3324 if ! HAVE_GTK3.
3325 (update_frame_tool_bar): Call gtk_widget_hide.
3326 (xg_initialize): Use GDK_KEY_g.
3327
3328 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3329 if ! HAVE_GTK3
3330 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3331
3332 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3333 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3334 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3335
1c2cc4ef
JB
33362011-03-08 Juanma Barranquero <lekktu@gmail.com>
3337
3338 * w32xfns.c (select_palette): Check success of RealizePalette against
3339 GDI_ERROR, not zero.
3340
33383987 3341See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3342
3343;; Local Variables:
3344;; coding: utf-8
aac0c6e3
MR
3345;; End:
3346
33383987 3347 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3348
3349 This file is part of GNU Emacs.
3350
3351 GNU Emacs is free software: you can redistribute it and/or modify
3352 it under the terms of the GNU General Public License as published by
3353 the Free Software Foundation, either version 3 of the License, or
3354 (at your option) any later version.
3355
3356 GNU Emacs is distributed in the hope that it will be useful,
3357 but WITHOUT ANY WARRANTY; without even the implied warranty of
3358 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3359 GNU General Public License for more details.
3360
3361 You should have received a copy of the GNU General Public License
3362 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.