* lisp/minibuffer.el (completion-file-name-table): Complete user names.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4ae29f89
SM
12012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * print.c (print_preprocess): Only check print_depth if print-circle
4 is nil.
5 (print_object): Check for cycles even when print-circle is nil and
6 print-gensym is t, but only check print_depth if print-circle is nil.
7
f30d612a
CY
82012-04-20 Chong Yidong <cyd@gnu.org>
9
10 * process.c (wait_reading_process_output): If EIO occurs on a pty,
11 set the status to "failed" and ensure that sentinel is run.
12
c07a4c0b 132012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
14
15 * process.c (Fset_process_inherit_coding_system_flag)
16 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 17 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 18
c07a4c0b 192012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
20
21 * xdisp.c (string_buffer_position_lim): Limit starting position to
22 BEGV.
23 (set_cursor_from_row): If called for a mode-line or header-line
24 row, return zero immediately.
25 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
26 farther than the first row after the header line, if any.
27 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
28 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
29
c07a4c0b 302012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 31
4ae29f89
SM
32 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
33 (bug#11238).
ad3a2b41 34
c07a4c0b 352012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 362012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
37
38 configure: new option --enable-gcc-warnings (Bug#11207)
39 * Makefile.in (C_WARNINGS_SWITCH): Remove.
40 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
41 (ALL_CFLAGS): Use new macros rather than old.
42 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
43 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
44 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
45 -Wunused-result, -Wunused-variable. This should go away once
46 the Emacs and Gnulib regex code is merged.
47 (xmalloc, xrealloc): Now static.
48
aba027e8
PE
492012-04-17 Paul Eggert <eggert@cs.ucla.edu>
50
51 * dired.c (Fsystem_groups): Remove unused local.
52
e5a36063
GM
532012-04-17 Glenn Morris <rgm@gnu.org>
54
55 * dired.c (Fsystem_users): Doc fix.
56
316411f0
DA
572012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
58
59 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
60 (syms_of_dired): Add them.
61
9426aba4
PE
622012-04-16 Paul Eggert <eggert@cs.ucla.edu>
63
b62a57be
PE
64 Fix minor alloc.c problems found by static checking.
65 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
66 New extern decls, to avoid calling undeclared functions.
67 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
68 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
69 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
70 (NEED_MEM_INSERT): New macro.
71 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 72 Remove one incorrect comment and fix another.
b62a57be 73
3539f31f
PE
74 Fix minor ralloc.c problems found by static checking.
75 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
76 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
77 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
78 (r_alloc_sbrk): Now static.
79
a041960a
PE
80 Improve ralloc.c interface checking.
81 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
82 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
83 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
84 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
85 [REL_ALLOC]: ... to here, to check interface.
86 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
87 Remove decls. This fixes an "It stinks!".
88
9426aba4
PE
89 * alloc.c (which_symbols): Fix alignment issue / type clash.
90
d55c12ed
AS
912012-04-15 Andreas Schwab <schwab@linux-m68k.org>
92
93 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
94 (struct Lisp_Misc_Any): Likewise.
95 (struct Lisp_Free): Likewise.
96 * alloc.c (union aligned_Lisp_Symbol): Define.
97 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
98 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
99 (union aligned_Lisp_Misc): Define.
100 (MARKER_BLOCK_SIZE, struct marker_block): Use union
101 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 102 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 103
b948ce8b
PE
1042012-04-14 Paul Eggert <eggert@cs.ucla.edu>
105
106 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
107 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
108 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
109 * s/netbsd.h, s/sol2-6.h:
110 Remove definition of GC_MARK_STACK, since the default now works.
111 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
112 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
113 no longer the default.
114 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
115
35dc09a1 1162012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 117
35dc09a1
GM
118 * lread.c (lisp_file_lexically_bound_p):
119 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 120
35dc09a1
GM
1212012-04-14 Eli Zaretskii <eliz@gnu.org>
122
123 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
124 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
125
1262012-04-14 Jan Djärv <jan.h.d@swipnet.se>
127
128 * nsterm.m (constrainFrameRect): Always constrain when there is only
129 one screen (Bug#10962).
130
bcd86815
KB
1312012-04-13 Ken Brown <kbrown@cornell.edu>
132
133 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
134
c25df26e
RT
1352012-04-13 Reuben Thomas <rrt@sc3d.org>
136
137 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
138
0fc59f1e
DC
1392012-04-11 Daniel Colascione <dancol@dancol.org>
140
141 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
142 against is gone. It's better to use vfork now so that when Cygwin
143 gains a new, working vfork, we use it automatically (bug#10398).
144
de8c03dc
SM
1452012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
146
147 * window.c (save_window_save): Obey window-point-insertion-type.
148
2f097256
GM
1492012-04-11 Glenn Morris <rgm@gnu.org>
150
151 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
152
453b951e
SM
1532012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
154
155 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
156
75f1671a 1572012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
158
159 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
160 (force_quit_count): New var.
161 (handle_interrupt): Use it.
162
2a8ce227
JB
1632012-04-10 Juanma Barranquero <lekktu@gmail.com>
164
165 * w32.c (w32_delayed_load): Record the full path of the library
166 being loaded (bug#10424).
167
935396c0
GM
1682012-04-09 Glenn Morris <rgm@gnu.org>
169
05920a43
GM
170 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
171 not just in the obarray, before snarfing them. (Bug#11036)
172
935396c0
GM
173 * Makefile.in ($(leimdir)/leim-list.el):
174 Pass EMACS rather than BUILT_EMACS.
175
a18ecafa
TZ
1762012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
177
178 * process.c (make_process):
179 * process.h: Add integer `gnutls_handshakes_tried' member to
180 process struct.
181
6bbef4e5
JC
182 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
183 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
184
185 * gnutls.c (gnutls_log_function2i): Convenience log function.
186 (emacs_gnutls_read): Use new log functions,
187 `gnutls_handshakes_tried' process member, and
188 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
189 attempts per process (connection).
190
b4d3bc10
CY
1912012-04-09 Chong Yidong <cyd@gnu.org>
192
193 * eval.c (Fuser_variable_p, user_variable_p_eh)
194 (lisp_indirect_variable): Functions deleted.
195 (Fdefvar): Caller changed.
196
197 * callint.c (Finteractive, Fcall_interactively):
198 * minibuf.c (Fread_variable): Callers changed.
199
70f4d973
EZ
2002012-04-09 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (set_cursor_from_row): If the display string appears in
203 the buffer at position that is closer to point than the position
204 after the display string, display the cursor on the first glyph of
205 the display string. Fixes cursor display when a 'display' text
206 property immediately follows invisible text. (Bug#11094)
207
cb3c2e3e
PE
2082012-04-09 Paul Eggert <eggert@cs.ucla.edu>
209
210 composite.c: use 'double' consistently
211 * composite.c (get_composition_id): Use 'double' consistently
212 instead of converting 'float' to 'double' and vice versa; this is
213 easier to understand and avoids a GCC warning.
214
fd06db5d
GM
2152012-04-09 Glenn Morris <rgm@gnu.org>
216
50fe702a
GM
217 * Makefile.in: Generate leim-list with bootstrap-emacs, in
218 preparation for dumping it with emacs. (Bug#4789)
219 (leimdir): New variable.
220 ($(leimdir)/leim-list.el): New rule.
221 (emacs$(EXEEXT)): Depend on leim-list.el.
222
fd06db5d
GM
223 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
224 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
225 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
226
55c131ee
AS
2272012-04-08 Andreas Schwab <schwab@linux-m68k.org>
228
229 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
230 proper alignment.
231
9209588f
JB
2322012-04-07 Juanma Barranquero <lekktu@gmail.com>
233
234 * xml.c (init_libxml2_functions) [WINDOWSNT]:
235 Remove unused local variable.
236
e3fb2efb
PE
2372012-04-07 Paul Eggert <eggert@cs.ucla.edu>
238
239 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
240 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
241 (mark_memory): Mark Lisp_Objects only if pointers might hide in
242 objects, as mark_maybe_pointer will catch them otherwise.
243 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
244 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
245
b5385551
PE
2462012-04-07 Paul Eggert <eggert@cs.ucla.edu>
247
248 Fix typo that broke non-Windows builds.
249 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
250
9078ead6
EZ
2512012-04-07 Eli Zaretskii <eliz@gnu.org>
252
253 Support building on MS-Windows with libxml2.
254
255 * makefile.w32-in (OBJ2): Add xml.$(O).
256 (GLOBAL_SOURCES): Add xml.c.
257 ($(BLD)/xml.$(O)): New dependency list.
258
259 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
260 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
261 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
262 [!WINDOWSNT]: New macros.
263 (init_libxml2_functions, libxml2_loaded_p): New functions.
264 (parse_region): Call fn_xmlCheckVersion instead of using the macro
265 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
266 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
267 Calls xmlCleanupParser only if libxml2 was loaded (or statically
268 linked in).
6bbef4e5
JC
269 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
270 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
271 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
272
273 * emacs.c: Don't include libxml/parser.h.
274 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
275 xmlCleanupParser directly.
276
277 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
278
3811fdf3
EZ
2792012-04-07 Eli Zaretskii <eliz@gnu.org>
280
281 * indent.c (Fvertical_motion): If there is a display string at
282 point, use it.vpos to compute how many lines to backtrack after
283 move_it_to point. (Bug#11133)
284
2f8e16b2
EZ
2852012-04-06 Eli Zaretskii <eliz@gnu.org>
286
287 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
288 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
289 about subtle differences between FETCH_CHAR* and STRING_CHAR*
290 macros related to unification of CJK characters. For the details,
291 see the discussion following the message here:
292 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
293
3d439cd1
CY
2942012-04-04 Chong Yidong <cyd@gnu.org>
295
296 * keyboard.c (Vdelayed_warnings_list): Doc fix.
297
8bc53d00
EZ
2982012-04-01 Eli Zaretskii <eliz@gnu.org>
299
300 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
301 instead of alloca. (Bug#11138)
302
3b0512a3
AS
3032012-04-01 Andreas Schwab <schwab@linux-m68k.org>
304
305 * w32menu.c (is_simple_dialog): Properly check lisp types.
306 (Bug#11141)
307
8427ddd2
EZ
3082012-03-31 Eli Zaretskii <eliz@gnu.org>
309
979022ef
EZ
310 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
311 position we get to after a call to move_it_to fails the
312 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
313 only if we wind up in a string from display property. (Bug#11063)
314
a6b1c7cc
EZ
315 * window.c (Fdelete_other_windows_internal): Invalidate the row
316 and column information about mouse highlight, so that redisplay
317 restores it after reallocating the glyph matrices. (Bug#7464)
318
8427ddd2
EZ
319 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
320 string comes from a `display' text property, use the buffer
321 position of that property as if we actually saw that position in
322 the row's glyphs.
697ba24b
EZ
323 (move_it_by_lines): Remove the assertion that
324 "it->current_x == 0 && it->hpos == 0" which can be legitimately
325 violated when there's a before-string at the beginning of a line.
326 (Bug#11063)
8427ddd2 327
65a0a738
EZ
3282012-03-30 Eli Zaretskii <eliz@gnu.org>
329
330 * xdisp.c (append_space_for_newline): If the default face was
331 remapped, use the remapped face for the appended newline.
332 (extend_face_to_end_of_line): Use the remapped default face for
333 extending the face to the end of the line.
334 (display_line): Call extend_face_to_end_of_line when the default
335 face was remapped. (Bug#11068)
336
581355cc
EZ
3372012-03-29 Eli Zaretskii <eliz@gnu.org>
338
339 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
340
e8fc049f
SM
3412012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
342
343 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
344
4fb9a543
GM
3452012-03-27 Glenn Morris <rgm@gnu.org>
346
347 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
348 Doc fixes.
349
679910f1
KH
3502012-03-26 Kenichi Handa <handa@m17n.org>
351
352 * dispextern.h (struct glyph): Fix previous change. Change the
353 bit length of glyphless.ch to 25 (Bug#11082).
354
90d49b7f
CY
3552012-03-26 Chong Yidong <cyd@gnu.org>
356
357 * keyboard.c (Vselection_inhibit_update_commands): New variable.
358 (command_loop_1): Use it; inhibit selection update for
359 handle-select-window too (Bug#8996).
360
f514f6f0
FP
3612012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
362
e8fc049f 363 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 364
bf43fa51
KH
3652012-03-25 Kenichi Handa <handa@m17n.org>
366
367 * dispextern.h (struct glyph): Change the bit length of
368 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
369
8a0c01dd
EZ
3702012-03-24 Eli Zaretskii <eliz@gnu.org>
371
372 * s/ms-w32.h (tzname): Include time.h before redirecting to
373 _tzname. Fixes the MSVC build. (Bug#9960)
374
7d1c3a76
AS
3752012-03-24 Andreas Schwab <schwab@linux-m68k.org>
376
8ed79523
AS
377 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
378 characters.
379
7d1c3a76
AS
380 * xterm.c (XTread_socket): Only modify handling_signal if
381 !SYNC_INPUT. (Bug#11080)
382
e99a9b8b
EZ
3832012-03-23 Eli Zaretskii <eliz@gnu.org>
384
385 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
386 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
387 when fetching a multibyte character consumes more bytes than
388 CHAR_BYTES returns, due to unification of CJK characters in
389 string_char. (Bug#11073)
390
5063c0e1
TN
3912012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
392
393 * process.c (wait_reading_process_output): Handle pty disconnect
394 by refraining from sending oneself a SIGCHLD (bug#10933).
395
9f851fbd
CY
3962012-03-22 Chong Yidong <cyd@gnu.org>
397
398 * dispextern.h (struct it): New member string_from_prefix_prop_p.
399
5063c0e1 400 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
401 Mark string as coming from a prefix property.
402 (handle_face_prop): Use default face for prefix strings (Bug#4281).
403 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
404
fb5b8aca
CY
4052012-03-21 Chong Yidong <cyd@gnu.org>
406
407 * xfaces.c (Vface_remapping_alist): Doc fix.
408
62356a1b
EZ
4092012-03-20 Eli Zaretskii <eliz@gnu.org>
410
411 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
412 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
413 Doc fixes.
62356a1b 414
025de85b
CY
4152012-03-20 Chong Yidong <cyd@gnu.org>
416
417 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
418 to reflect default non-nil value of redisplay-dont-pause.
419
4827f94e
KH
4202012-03-19 Kenichi Handa <handa@m17n.org>
421
422 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
423 it fit in a valid range (Bug#11003).
424
e50a24a2
EZ
4252012-03-18 Eli Zaretskii <eliz@gnu.org>
426
427 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
428 that is not from display property, accept the row as a "cursor
429 row" if one of the string's character has a non-nil `cursor'
430 property. Fixes cursor positioning when there are newlines in
431 overlay strings, e.g. in icomplete.el. (Bug#11035)
432
9af5ed87
PE
4332012-03-12 Paul Eggert <eggert@cs.ucla.edu>
434
435 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
436
d1f55f16
CY
4372012-03-12 Chong Yidong <cyd@gnu.org>
438
439 * eval.c (inhibit_lisp_code): Rename from
440 inhibit_window_configuration_change_hook; move from window.c.
441
442 * xfns.c (unwind_create_frame_1, Fx_create_frame):
443 * window.c (run_window_configuration_change_hook)
444 (syms_of_window): Callers changed.
445
66c5eebd
CY
4462012-03-11 Chong Yidong <cyd@gnu.org>
447
413df973
CY
448 * keymap.c (Fkey_description): Doc fix (Bug#9700).
449
66c5eebd
CY
450 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
451
1de11f56
CY
4522012-03-10 Chong Yidong <cyd@gnu.org>
453
454 * frame.c (other_visible_frames): Don't assume the selected frame
455 is visible (Bug#10955).
456
cae07000
SM
4572012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
458
459 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
460
89c94350
JD
4612012-03-08 Jan Djärv <jan.h.d@swipnet.se>
462
463 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
464 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
465 zero (Bug#10954).
466
999dd333
GM
4672012-03-03 Glenn Morris <rgm@gnu.org>
468
01a6dcc8 469 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 470
de0100f2
EZ
4712012-03-02 Eli Zaretskii <eliz@gnu.org>
472
473 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
474 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
475 (redisplay_window, next_element_from_string): Fix typos in
476 comments.
3e441275
EZ
477 (redisplay_window): Pass to move_it_vertically the margin in
478 pixels, not in screen lines.
de0100f2 479
96a72ee9
GM
4802012-03-02 Glenn Morris <rgm@gnu.org>
481
482 * buffer.c (buffer-list-update-hook): Doc fix.
483
312508d7
EZ
4842012-02-29 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
487 push_it before setting up the iterator for the first overlay
488 string, even if we have an empty string loaded.
489 (next_overlay_string): If there's an empty string on the iterator
490 stack, pop the stack. (Bug#10903)
491
27f3c637
PE
4922012-02-25 Paul Eggert <eggert@cs.ucla.edu>
493
494 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
495 Suggested by Stefan Monnier in
496 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
497 * alloc.c (widen_to_Lisp_Object): New static function.
498 (mark_memory): Also mark Lisp_Objects by fetching pointer words
499 and widening them to Lisp_Objects. This would work even if
500 USE_LSB_TAG is defined and wide integers are used, which might
501 happen in a future version of Emacs.
502
3c9dfce6
CY
5032012-02-25 Chong Yidong <cyd@gnu.org>
504
fa74b241
CY
505 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
506 Doc fix.
507
3c9dfce6
CY
508 * xselect.c (Fx_selection_exists_p): Doc fix.
509 (x_clipboard_manager_save_all): Print an informative message
510 before saving to clipboard manager.
511
9486df08
CY
5122012-02-24 Chong Yidong <cyd@gnu.org>
513
514 * keyboard.c (process_special_events): Handle all X selection
515 requests in kbd_buffer, not just the next one (Bug#8869).
516
f01d3321
CY
5172012-02-23 Chong Yidong <cyd@gnu.org>
518
519 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
520 call when setting menu-bar-lines and tool-bar-lines parameters.
521 (unwind_create_frame_1): New helper function.
522
523 * window.c (inhibit_window_configuration_change_hook): New var.
524 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 525 (syms_of_window): Initialize it.
f01d3321 526
86b847b6
CY
5272012-02-22 Chong Yidong <cyd@gnu.org>
528
529 * xterm.c (x_draw_image_relief): Add missing type check for
530 Vtool_bar_button_margin (Bug#10743).
531
a59225b1
CY
5322012-02-21 Chong Yidong <cyd@gnu.org>
533
534 * fileio.c (Vfile_name_handler_alist): Doc fix.
535
536 * buffer.c (Fget_file_buffer): Protect against invalid file
537 handler return value.
538
310f5bd4
PE
5392012-02-20 Paul Eggert <eggert@cs.ucla.edu>
540
cb3a28cc
PE
541 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
542 when computing $valmask.
543
310f5bd4
PE
544 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
545 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
546 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
547 It's useless in that case, and it can cause problems on hosts
548 that allocate halves of EMACS_INT values separately.
549 Reported by Dan Horák. Diagnosed by Andreas Schwab in
550 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
551 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
552 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
553 it avoids undefined behavior on hosts where shifting right by more
554 than the word width has undefined behavior.
555
2375c96a
CY
5562012-02-19 Chong Yidong <cyd@gnu.org>
557
558 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
559 (Funhandled_file_name_directory, Ffile_name_as_directory)
560 (Fdirectory_file_name, Fexpand_file_name)
561 (Fsubstitute_in_file_name): Protect against invalid file handler
562 return values (Bug#10845).
563
3eb49e71
EZ
5642012-02-18 Eli Zaretskii <eliz@gnu.org>
565
566 * .gdbinit (pitx): Fix incorrect references to fields of the
567 iterator stack.
568
7b926f3f
CY
5692012-02-17 Chong Yidong <cyd@gnu.org>
570
571 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
572
11273115
PE
5732012-02-15 Paul Eggert <eggert@cs.ucla.edu>
574
575 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
576 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
577
c3a70e2b
CY
5782012-02-15 Chong Yidong <cyd@gnu.org>
579
580 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
581 marked as special. Also, starting docstrings with * is obsolete.
582
0ca43699
AS
5832012-02-13 Andreas Schwab <schwab@linux-m68k.org>
584
585 * gnutls.c (emacs_gnutls_write): Fix last change.
586
2e8f3c56
LI
5872012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
588
589 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
590 send_process.
591
af70074f
SM
5922012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
593
594 * keymap.c (Fsingle_key_description): Handle char ranges.
595
95986d52
CY
5962012-02-12 Chong Yidong <cyd@gnu.org>
597
afd83bd1
CY
598 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
599 as that creates a dangerous corner case.
600
95986d52
CY
601 * window.c (Fdelete_window_internal): Invalidate the mouse
602 highlight (Bug#9904).
603
bd7da63e
GM
6042012-02-12 Glenn Morris <rgm@gnu.org>
605
606 * xselect.c (Fx_own_selection_internal)
607 (Fx_get_selection_internal, Fx_disown_selection_internal)
608 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
609 * nsselect.m (Fx_own_selection_internal)
610 (Fx_disown_selection_internal, Fx_selection_exists_p)
611 (Fx_selection_owner_p, Fx_get_selection_internal):
612 Sync docs and argument specs with the xselect.c versions.
613
77abcbc2
LI
6142012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
615
616 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
617
90b671e2
EZ
6182012-02-11 Eli Zaretskii <eliz@gnu.org>
619
1c0ca0b7
EZ
620 * w32select.c (Fx_selection_exists_p): Sync doc string and
621 argument list with xselect.c. (Bug#10783)
622
623 * w16select.c (Fx_selection_exists_p): Sync doc string and
624 argument list with xselect.c. (Bug#10783)
90b671e2 625
49241268
GM
6262012-02-10 Glenn Morris <rgm@gnu.org>
627
628 * fns.c (Fsecure_hash): Doc fix.
629
f998bbe7 6302012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
631
632 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
633
0992bd9c
CY
6342012-02-07 Chong Yidong <cyd@gnu.org>
635
636 * buffer.c (Fbuffer_local_variables)
637 (buffer_lisp_local_variables): Handle unbound vars correctly;
638 don't let Qunbound leak into Lisp.
639
af008560
GM
6402012-02-07 Glenn Morris <rgm@gnu.org>
641
dd605cc4
GM
642 * image.c (Fimagemagick_types): Doc fix.
643
af008560
GM
644 * image.c (imagemagick-render-type): Change it from a lisp object
645 to an integer. Move the doc here from the lisp manual.
646 Treat all values not equal to 0 the same.
647
1449fa1d
CY
6482012-02-06 Chong Yidong <cyd@gnu.org>
649
650 * doc.c (store_function_docstring): Avoid applying docstring of
651 alias to base function (Bug#2603).
652
3723ec07
AS
6532012-02-04 Andreas Schwab <schwab@linux-m68k.org>
654
655 * .gdbinit (pp1, pv1): Remove redundant defines.
656 (pr): Use pp.
657
79c1cc1e
CY
6582012-02-04 Chong Yidong <cyd@gnu.org>
659
660 * nsterm.m: Declare a global (Bug#10694).
661
d7f29f8e
EZ
6622012-02-04 Eli Zaretskii <eliz@gnu.org>
663
cae07000
SM
664 * w32.c (get_emacs_configuration_options):
665 Include --enable-checking, if specified, in the return value.
d7f29f8e 666
3b95a6f9
MR
6672012-02-04 Martin Rudalics <rudalics@gmx.at>
668
669 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
670 after rounding frame sizes. (Bug#9723)
671
d6fa96a6
EZ
6722012-02-04 Eli Zaretskii <eliz@gnu.org>
673
674 * keyboard.c (adjust_point_for_property): Don't position point
675 before BEGV. (Bug#10696)
676
df0b2940
PE
6772012-02-03 Paul Eggert <eggert@cs.ucla.edu>
678
679 Handle overflow when computing char display width (Bug#9496).
680 * character.c (char_width): Return EMACS_INT, not int.
681 (char_width, c_string_width): Check for overflow when
682 computing the width; this is possible now that individual
683 characters can have unbounded width. Problem introduced
684 by merge from Emacs 23 on 2012-01-19.
685
6bee44d6
MA
6862012-02-02 Michael Albinus <michael.albinus@gmx.de>
687
688 * dbusbind.c (Fdbus_register_method): Mention the return value
689 :ignore in the docstring.
690
44f92739
GM
6912012-02-02 Glenn Morris <rgm@gnu.org>
692
1b9f60cc
GM
693 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
694
44f92739
GM
695 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
696 Unconditionally set to t. (Bug#10673)
697 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
698 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
699 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
700
c5d3843c
KH
7012012-02-02 Kenichi Handa <handa@m17n.org>
702
703 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
704 0, do not call append_composite_glyph.
705
159462d4 7062012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
707
708 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
709 NULL (Bug#6988).
710 (x_produce_glyphs): If the component of a composition is a null
711 string, set it->pixel_width to 1 to avoid zero-width glyph.
712
78cef877
EZ
7132012-02-01 Eli Zaretskii <eliz@gnu.org>
714
715 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
716 first 2 arguments are identical. This makes inserting large
717 output from a subprocess an order of magnitude faster on
718 MS-Windows, where all sbrk'ed memory is always contiguous.
719
97897668
GM
7202012-01-31 Glenn Morris <rgm@gnu.org>
721
722 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 723 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
724 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
725
31fd3586
GM
7262012-01-29 Glenn Morris <rgm@gnu.org>
727
728 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
729
0e24a8b2
CY
7302012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
731
732 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
733
cc0adcb0
CY
7342012-01-28 Chong Yidong <cyd@gnu.org>
735
736 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
737
acc28cb9
CY
7382012-01-26 Chong Yidong <cyd@gnu.org>
739
9c69cfb7
CY
740 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
741
acc28cb9
CY
742 * search.c (Fsearch_forward, Fsearch_backward): Document negative
743 repeat counts (Bug#10507).
744
48da7392
GM
7452012-01-26 Glenn Morris <rgm@gnu.org>
746
747 * lread.c (syms_of_lread): Doc fix.
748
14af5f7f
CY
7492012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
750
751 * coding.c (encode_designation_at_bol): Change return value to
752 EMACS_INT.
753
0b21c100
CY
7542012-01-25 Chong Yidong <cyd@gnu.org>
755
756 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
757
3c2907f7
CY
7582012-01-21 Chong Yidong <cyd@gnu.org>
759
760 * floatfns.c (Fcopysign): Make the second argument non-optional,
761 since nil is not allowed anyway.
762
959ad23f
AS
7632012-01-21 Andreas Schwab <schwab@linux-m68k.org>
764
765 * process.c (read_process_output): Use p instead of XPROCESS (proc).
766 (send_process): Likewise.
767
34a02f46
MR
7682012-01-19 Martin Rudalics <rudalics@gmx.at>
769
770 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
771 (Vwindow_persistent_parameters): Do not use Qstate.
772 Rewrite doc-strings.
34a02f46 773
1259009a 7742012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
775
776 * character.c (char_width): New function.
70d4fdf6
GM
777 (Fchar_width, c_string_width, lisp_string_width):
778 Use char_width (Bug#9496).
25ed9e61 779
6a6ee00d
MR
7802012-01-16 Martin Rudalics <rudalics@gmx.at>
781
782 * window.c (Vwindow_persistent_parameters): New variable.
783 (Fset_window_configuration, save_window_save): Handle persistent
784 window parameters.
785
c85efaf7
EZ
7862012-01-14 Eli Zaretskii <eliz@gnu.org>
787
788 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
789 thrashing the stack of the thread. (Bug#9087)
790
5944709e
PE
7912012-01-12 Paul Eggert <eggert@cs.ucla.edu>
792
793 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
794
e71f5d99
EZ
7952012-01-11 Eli Zaretskii <eliz@gnu.org>
796
797 * xdisp.c (rows_from_pos_range): Handle the case where the
798 highlight ends on a newline. (Bug#10464)
799 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
800 he end column for display of highlight that ends on a newline
801 before a R2L line.
802
ce316182
GM
8032012-01-11 Glenn Morris <rgm@gnu.org>
804
805 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
806 from load-path also when installation-directory is nil. (Bug#10208)
807
5b43da69
GM
8082012-01-10 Glenn Morris <rgm@gnu.org>
809
74cc8ff9
GM
810 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
811
7d8d6e4e
GM
812 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
813 Update template values to be closer to their typical values these days.
5b43da69 814
a0db8d43
EZ
8152012-01-09 Eli Zaretskii <eliz@gnu.org>
816
817 * xdisp.c (rows_from_pos_range): Accept additional argument
818 DISP_STRING, and accept any glyph in a row whose object is that
819 string as eligible for mouse highlight. Fixes mouse highlight of
820 display strings from overlays. (Bug#10464)
821
9a0115ab 8222012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 823
b9110d6a 824 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
825 * fileio.c (auto_saving_dir_umask): New static var.
826 (Fmake_directory_internal): Use it.
827 (do_auto_save_make_dir): Set it, instead of invoking chmod after
828 creating the directory. The old code temporarily assigns
829 too-generous permissions to the directory.
830 (do_auto_save_eh): Clear it.
b9110d6a 831 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
832 that the var is always cleared.
833
6c1bd3f3
EZ
8342012-01-07 Eli Zaretskii <eliz@gnu.org>
835
836 * search.c (scan_buffer): Pass character positions to
837 know_region_cache, not byte positions. (Bug#6540)
838
069d2b50
L
8392012-01-07 LynX <_LynX@bk.ru> (tiny change)
840
841 * w32.c (sys_rename): Report EXDEV when rename of a directory
842 fails because the target is on another logical disk. (Bug#10284)
843
75bf0d33
DB
8442012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
845
846 * xterm.c (x_embed_request_focus): New function.
847
848 * xterm.h: Add prototype.
849
850 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
851
1c6e5a32
GM
8522012-01-05 Glenn Morris <rgm@gnu.org>
853
854 * emacs.c (emacs_copyright): Update short copyright year to 2012.
855
651e947e
EZ
8562012-01-01 Eli Zaretskii <eliz@gnu.org>
857
858 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
859 Load gnutls_transport_set_lowat only if GnuTLS version is below
860 2.11.1.
861 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
862 GnuTLS versions below 2.11.1.
863
3778cdd8
AL
8642011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
865
866 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
867 to the doc string advising against its use for altering the way
868 windows are scrolled.
869
0e5317f7
KH
8702011-12-28 Kenichi Handa <handa@m17n.org>
871
872 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
873 coding-system ASCII compatible only when it does not produce BOM
874 on encoding (Bug#10383).
875
93d5ca1f
JD
8762011-12-26 Jan Djärv <jan.h.d@swipnet.se>
877
878 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
879 can scroll.
880 (create_and_show_popup_menu): Always use menu_position_func for
881 Gtk3 (Bug#10361).
882
ca22b785
AS
8832011-12-24 Andreas Schwab <schwab@linux-m68k.org>
884
885 * callint.c (Fcall_interactively): Don't truncate prompt string.
886
d048e1e6
EZ
8872011-12-23 Eli Zaretskii <eliz@gnu.org>
888
889 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
890 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 891 resumed from there (after widening). (Bug#10360)
d048e1e6 892
5ccaba1f
JD
8932011-12-22 Jan Djärv <jan.h.d@swipnet.se>
894
895 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
896
204ee57f
JD
8972011-12-21 Jan Djärv <jan.h.d@swipnet.se>
898
b81d40f0
JB
899 * nsterm.m (x_free_frame_resources):
900 Release f->output_data.ns->miniimage.
204ee57f
JD
901 (ns_index_color): Fix indentation. Do not retain
902 color_table->colors[i].
903
904 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
905 before returning.
906
907 * nsfns.m (x_set_background_color): Assign return value from
908 ns_index_color to face-background instead of NSColor*.
909 (ns_implicitly_set_icon_type): Fix indentation.
910 Change assignment in for loop to comparison.
911
912 * emacs.c (ns_pool): New variable.
913 (main): Assign ns_pool.
914 (Fkill_emacs): Call ns_release_autorelease_pool.
915
916 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
917 autorelease fdesc, release fdAttrs and tdict.
918 (ns_get_covering_families): Release charset.
919 (ns_findfonts): Release NSFontDescriptor created with new.
920 (ns_uni_to_glyphs): Fix indentation.
921 (setString): Release attrStr before assigning new value.
922
c803b2b7
JD
9232011-12-18 Jan Djärv <jan.h.d@swipnet.se>
924
678f4426
JD
925 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
926 and NS_IMPL_COCOA.
927 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
928 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
929
cd394be1 9302011-12-18 David Reitter <reitter@cmu.edu>
678f4426 931
5fecd5fc
JD
932 * nsterm.m (ns_term_init): Subscribe for notifications
933 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
934 to method trackingNotification in EmacsMenu.
935
936 * nsmenu.m (trackingMenu): New variable.
3771cb17 937 (trackingNotification): New method (from Aquamacs).
5fecd5fc 938 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 939 from Aquamacs (Bug#7030).
678f4426
JD
940
9412011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 942
c803b2b7
JD
943 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
944 (symbol_to_nsstring): Fix indentation.
945 (ns_symbol_to_pb): New function.
cae07000
SM
946 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
947 (Fns_rotate_cut_buffers_internal): Remove.
948 (Fns_store_selection_internal): Rename from
c803b2b7
JD
949 Fns_store_cut_buffer_internal.
950 (ns_get_foreign_selection, Fx_own_selection_internal)
951 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
952 (Fns_get_selection_internal, Fns_store_selection_internal):
953 Use ns_symbol_to_pb and check if return value is nil.
954 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
955 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
956 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
957 renamed to Sns_store_selection_internal.
958 (ns_handle_selection_request): Move code to Fx_own_selection_internal
959 and remove this function.
960 (ns_handle_selection_clear): Remove, never used.
961 (Fx_own_selection_internal): Move code from ns_handle_selection_request
962 here.
963
e1b01a3a
KB
9642011-12-17 Ken Brown <kbrown@cornell.edu>
965
966 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
967 GID is unknown (Bug#10257).
968
2adb6e85
PE
9692011-12-17 Paul Eggert <eggert@cs.ucla.edu>
970
971 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
972 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
973 which caused a build failure on GNU/Linux IA-64. This problem was
974 introduced by my 2011-10-07 patch.
975
d1d7b339
JL
9762011-12-15 Juri Linkov <juri@jurta.org>
977
978 * image.c (imagemagick_error): New function. (Bug#10112)
979 (imagemagick_load_image): Comment out `MagickSetResolution' call.
980 Use `imagemagick_error' where ImageMagick functions return
981 `MagickFalse'.
982 (Fimagemagick_types): Add `Fnreverse' to return the list in the
983 proper order.
984
100d5755
KH
9852011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
986
987 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
988 fill background (Bug#8992).
989
454592a6
MR
9902011-12-13 Martin Rudalics <rudalics@gmx.at>
991
992 * window.c (Vwindow_combination_resize)
993 (Vwindow_combination_limit): Use t instead of non-nil in
994 doc-strings.
61d4b438
MR
995 (Vrecenter_redisplay): Add first sentence of doc-string on
996 separate line.
53524d93 997 (Frecenter): Fix doc-string typo.
454592a6 998
3633e3aa
KH
9992011-12-11 Kenichi Handa <handa@m17n.org>
1000
1001 * coding.c (Funencodable_char_position): Pay attention to the
1002 buffer text relocation (Bug#9389).
1003
7b9d523a
JD
10042011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1005
1006 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1007 gtk_init (Bug#10100).
1008
b73189c6
EZ
10092011-12-10 Eli Zaretskii <eliz@gnu.org>
1010
1011 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1012 IT->string is nil. (Bug#10263)
1013
f7dfe5d6
JD
10142011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1015
83faebb4
JD
1016 * nsterm.h (x_free_frame_resources): Declare.
1017
f7dfe5d6
JD
1018 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1019 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1020
1021 * nsterm.h (ns_get_defaults_value): Declare.
1022
1023 * nsterm.m (ns_default): Call ns_get_defaults_value.
1024
7cd4e72c
EZ
10252011-12-09 Eli Zaretskii <eliz@gnu.org>
1026
1027 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1028 (Bug#10170)
1029
b34d7317
YM
10302011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1031
1032 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1033 that where the value of an _OBJC_* symbol points to is in the .bss
1034 section (Bug#10240).
1035
76470ad1
KH
10362011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1037
1038 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1039 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1040
745fff94
KH
10412011-12-08 Kenichi Handa <handa@m17n.org>
1042
1043 * ftfont.c (get_adstyle_property): Fix previous change
1044 (Bug#10233).
1045
6e44397c
JB
10462011-12-07 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1049 dirs from the default value of EMACSLOADPATH (bug#10208).
1050
7efa6272
GM
10512011-12-07 Glenn Morris <rgm@gnu.org>
1052
1053 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1054 installation and source directories as well. (Bug#10208)
1055
f6fc4d87
CY
10562011-12-06 Chong Yidong <cyd@gnu.org>
1057
1058 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1059
2bf26180
GM
10602011-12-06 Glenn Morris <rgm@gnu.org>
1061
1062 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1063 as an error, not just -1. (Bug#10217)
1064
3a6ad4f0
CY
10652011-12-05 Chong Yidong <cyd@gnu.org>
1066
1067 * keyboard.c (process_special_events): New function.
1068 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1069
75a3b399
PE
10702011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1071
1072 * coding.c (encode_designation_at_bol): Don't use uninitialized
1073 local variable (Bug#9318).
1074
c3c9e25e
KH
10752011-12-05 Kenichi Handa <handa@m17n.org>
1076
1077 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1078 return Qnil (Bug#8046, Bug#10193).
1079
5eb05ea3
KH
10802011-12-05 Kenichi Handa <handa@m17n.org>
1081
1082 * coding.c (encode_designation_at_bol): New args charbuf_end and
1083 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1084 (coding_set_source): Return how many bytes coding->source was
1085 relocated.
1086 (coding_set_destination): Return how many bytes
1087 coding->destination was relocated.
1088 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1089 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1090
10912011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1092
1093 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1094 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1095 macro (Bug#9318).
1096
10972011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1098
1099 The following changes are to fix Bug#9318.
1100
a79703f5 1101 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1102 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1103 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1104 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1105
7dbda6df
JB
11062011-12-05 Juanma Barranquero <lekktu@gmail.com>
1107
1108 * lisp.h (process_quit_flag): Fix external declaration.
1109
6d5eb5b0
SM
11102011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1111
1112 Don't macro-inline non-performance-critical code.
1113 * eval.c (process_quit_flag): New function.
1114 * lisp.h (QUIT): Use it.
1115
a0c3fad0
JD
11162011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1117
1118 * nsfns.m (get_geometry_from_preferences): New function.
1119 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1120
6c07aac2
AS
11212011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1122
1123 * emacs.c (Qkill_emacs): Define.
1124 (syms_of_emacs): Initialize it.
1125 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1126 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1127 (quit_throw_to_read_char): Add parameter `from_signal'.
1128 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1129 * lisp.h (QUIT): Call Fkill_emacs if requested.
1130
c052ead4
JD
11312011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1132
1133 * widget.c (update_wm_hints): Return if wmshell is null.
1134 (widget_update_wm_size_hints): New function.
1135
1136 * widget.h (widget_update_wm_size_hints): Declare.
1137
1138 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1139 widget_update_wm_size_hints (Bug#10104).
1140
9e49252b
EZ
11412011-12-03 Eli Zaretskii <eliz@gnu.org>
1142
1143 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1144 before a newline, prepare the bidi iterator for consuming the
1145 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1146 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1147
02b16839
JL
11482011-12-02 Juri Linkov <juri@jurta.org>
1149
1150 * search.c (Fword_search_regexp): New Lisp function created from
1151 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1152 (Fword_search_backward, Fword_search_forward)
1153 (Fword_search_backward_lax, Fword_search_forward_lax):
1154 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1155 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1156
0068070e
SM
11572011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1158
1159 * fileio.c (Finsert_file_contents): Move after-change-function call
1160 to before the "handled:" label, since all "goto handled" appear in
1161 cases where the *-change-functions have already been properly called
1162 (bug#10117).
1163
3360a3fc
AS
11642011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1165
1166 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1167 waiting for input. (Bug#10169)
1168
73d6c093
EZ
11692011-11-30 Eli Zaretskii <eliz@gnu.org>
1170
1171 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1172 verifies glyph row's hash code--we have just reallocated the
1173 glyphs, so their contents can be complete garbage. (Bug#10164)
1174
febe6bea
JB
11752011-11-30 Juanma Barranquero <lekktu@gmail.com>
1176
1177 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1178
801a4313
EZ
11792011-11-30 Eli Zaretskii <eliz@gnu.org>
1180
1181 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1182 attributes are tested _before_ calling verify_row_hash, to protect
1183 against GCC re-ordering of the tests. (Bug#10164)
1184
2b56b87e
JD
11852011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1186
1187 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1188
1189 * xterm.c (handle_one_xevent): Only set async_visible and friends
1190 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1191 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1192 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1193
dbf31225
PE
11942011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1195
1196 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1197 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1198 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1199 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1200 All uses changed to use GCPRO1 etc.
1201 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1202 Revert to old implementation (i.e., before 2011-03-11).
1203
1305621b
YM
12042011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1205
1206 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1207 of scroll runs so as to avoid assigning disabled bogus rows and
1208 unnecessary graphics copy operations.
1209
8c9afb46
EZ
12102011-11-27 Eli Zaretskii <eliz@gnu.org>
1211
1212 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1213 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1214 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1215 (malloc, free, realloc, calloc): Redirect to e_* only when
1216 compiling Emacs.
1217
1218 * lisp.h (GCTYPEBITS): Move before first use.
1219 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1220 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1221 this macro definition.
1222
1223 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1224 _MSC_VER.
1225
54e9e3bf
JD
12262011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1227
6d5eb5b0
SM
1228 * gtkutil.c (xg_create_frame_widgets):
1229 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1230 present with Gtk+ 2.0.
1231
83aca1cb
PE
12322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 * fileio.c (Finsert_file_contents): Undo previous change; see
1235 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1236
5b76caa4
PE
12372011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 Rename locals to avoid shadowing.
1240 * fileio.c (Finsert_file_contents):
1241 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1242 * process.c (wait_reading_process_output):
1243 Rename inner 'proc' to 'p' to avoid shadowing.
1244 Indent for consistency with usual Emacs style.
1245
8c535114
EZ
12462011-11-25 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (redisplay_window): If cursor row is not fully visible
1249 after recentering, and scroll-conservatively is set to a large
1250 number, scroll window by a few more lines to make the cursor fully
1251 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1252 (start_display): Don't move to the next line if the display should
1253 start at a newline that is part of a display vector or an overlay
1254 string. (Bug#10119)
8c535114 1255
fa4fdb5c
JL
12562011-11-24 Juri Linkov <juri@jurta.org>
1257
1258 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1259 after the `MagickPingImage' call. (Bug#10112)
1260
90ec88df
CY
12612011-11-23 Chong Yidong <cyd@gnu.org>
1262
1263 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1264
56e2e794
MR
12652011-11-23 Martin Rudalics <rudalics@gmx.at>
1266
1267 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1268 making another buffer current. (Bug#10114)
1269
b6e64c41
GM
12702011-11-23 Glenn Morris <rgm@gnu.org>
1271
1272 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1273
6b21de18
CY
12742011-11-23 Chong Yidong <cyd@gnu.org>
1275
1276 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1277 using it (Bug#5984).
1278
b12cd789
EZ
12792011-11-22 Eli Zaretskii <eliz@gnu.org>
1280
1281 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1282 and header-lines, as they don't have one computed for them.
1283 (Bug#10098)
1284
1285 * .gdbinit (prow): Make displayed values more self-explaining.
1286 Add row's hash code.
1287
261b6fd4
LMI
12882011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1289
1290 * process.c (wait_reading_process_output): Fix asynchrounous
1291 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1292 (wait_reading_process_output): Add comment and URL.
261b6fd4 1293
e7cfd277
JD
12942011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1295
1296 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1297
a9b9b7f5
CY
12982011-11-21 Chong Yidong <cyd@gnu.org>
1299
1300 * window.c (Fnext_window, Fprevious_window): Doc fix.
1301
b0d15b4f
SM
13022011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1303
1304 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1305
fe7a3057
JB
13062011-11-20 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1309
d2999b1a
MR
13102011-11-20 Martin Rudalics <rudalics@gmx.at>
1311
1312 * window.c (Fset_window_combination_limit): Rename argument
1313 STATUS to LIMIT.
1314 (Vwindow_combination_limit): Remove "status" from doc-string.
1315
d5ff9cd0
AS
13162011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1317
1318 * m/ibms390.h: Remove.
1319 * m/ibms390x.h: Don't include "ibms390.h".
1320
a5bb9bd3
SM
13212011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1322
1323 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1324 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1325
cd1181db
JB
13262011-11-20 Juanma Barranquero <lekktu@gmail.com>
1327
1328 * casetab.c (Fset_case_table):
1329 * charset.c (Fcharset_after): Fix typos.
1330
615a3b8d 13312011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1332
17e845af
PE
1333 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1334 Otherwise, valgrind does not work on some platforms.
1335 Problem reported by Andreas Schwab in
6a0bf43d
PE
1336 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1337 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1338 is set, removing the need for VIRT_ADDRESS_VARIES.
1339 (PURE_P): Use a more-efficient implementation that needs just one
1340 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1341 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1342 to 4 (xorl, subq, cmpq, setbe).
1343 * alloc.c (pure): Always extern now, since that's the
1344 VIRT_ADDR_VARIES behavior.
1345 (PURE_POINTER_P): Use a single comparison, not two, for
1346 consistency with the new puresize.h.
1347 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1348 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1349 Remove VIRT_ADDR_VARIES no longer needed.
1350
f8fe6f96
EZ
13512011-11-19 Eli Zaretskii <eliz@gnu.org>
1352
1353 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1354 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1355 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1356 behave as if the cursor position were at the window margin.
1357
1358 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1359 and the cursor position is out of bounds, behave as if the cursor
1360 position were at the window margin. (Bug#10075)
1361
df05a53c
CY
13622011-11-18 Chong Yidong <cyd@gnu.org>
1363
1364 * window.c (Fwindow_combination_limit): Make first argument
1365 non-optional, since it is meaningless for live windows like the
1366 selected window.
1367
2071918e
DA
13682011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1369
1370 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1371
b50a28de
SM
13722011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1373
1374 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1375 (graft_intervals_into_buffer): Simplify.
1376
015137db
EZ
13772011-11-18 Eli Zaretskii <eliz@gnu.org>
1378
1379 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1380 hash values of the two rows.
1381 (copy_row_except_pointers): Preserve the used[] arrays and the
1382 hash values of the two rows. (Bug#10035)
68c95424 1383 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1384
1385 * xdisp.c (row_hash): New function, body extracted from
1386 compute_line_metrics.
1387 (compute_line_metrics): Call row_hash, instead of computing the
1388 hash code inline.
1389
1390 * dispnew.c (verify_row_hash): Call row_hash for computing the
1391 hash code of a row, instead of duplicating code from xdisp.c.
1392
1393 * dispextern.h (row_hash): Add prototype.
1394
a2addb04
TH
13952011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1396
1397 * frame.c (delete_frame): Don't delete the terminal when the last
1398 X frame is closed if emacs is built with GTK toolkit.
1399
df85d315
JB
14002011-11-17 Juanma Barranquero <lekktu@gmail.com>
1401
1402 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1403
a0c2d0ae
MR
14042011-11-17 Martin Rudalics <rudalics@gmx.at>
1405
1406 * window.c (Vwindow_splits): Rename to
1407 Vwindow_combination_resize. Suggested by Juri Linkov.
1408 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1409 of Vwindow_splits.
1410
58179cce
JB
14112011-11-16 Juanma Barranquero <lekktu@gmail.com>
1412
7877f373
JB
1413 * nsfns.m (Fns_font_name):
1414 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1415
b6f67890
MR
14162011-11-16 Martin Rudalics <rudalics@gmx.at>
1417
1418 * window.h (window): Rename slot "nest" to "combination_limit".
1419 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1420 (Fset_window_nest): Rename to Fset_window_combination_limit.
1421 (Vwindow_nest): Rename to Vwindow_combination_limit.
1422 (recombine_windows, make_parent_window, make_window)
1423 (Fsplit_window_internal, saved_window)
1424 (Fset_window_configuration, save_window_save): Rename all
1425 occurrences of window_nest to window_combination_limit.
1426
c7015153
JB
14272011-11-15 Juanma Barranquero <lekktu@gmail.com>
1428
1429 * image.c (imagemagick_load_image): Fix typo.
1430
322ad6ec
EZ
14312011-11-14 Eli Zaretskii <eliz@gnu.org>
1432
1433 * xdisp.c (display_line): Move the call to
1434 highlight_trailing_whitespace before the call to
1435 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1436 faces of all the glyphs to compute ROW's hash value.
1437 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1438
f067b8ec
JB
14392011-11-14 Juanma Barranquero <lekktu@gmail.com>
1440
1441 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1442 just return (bug#10044).
1443
1e5b2111
EZ
14442011-11-12 Eli Zaretskii <eliz@gnu.org>
1445
7ef3cbd5
EZ
1446 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1447 with user-defined heap size. Bump the default size of the temacs
1448 heap to 27MB, to avoid memory warning when running temacs.
1449 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1450
1e5b2111
EZ
1451 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1452 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1453 (verify_row_hash) [XASSERTS]: New function.
1454 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1455 that the hash value of glyph rows is correct.
1e5b2111 1456
89d61221
MR
14572011-11-12 Martin Rudalics <rudalics@gmx.at>
1458
1459 * window.h (window): Remove splits slot.
1460 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1461 (Fdelete_other_windows_internal, make_parent_window)
1462 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1463 (Fset_window_configuration, save_window_save): Don't deal with
1464 split status of windows.
1465 (saved_window): Remove splits slot.
1466 (Vwindow_splits): Rewrite doc-string.
1467
97f18cc8
JD
14682011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1469
1470 * xfns.c (unwind_create_frame):
1471 * nsfns.m (unwind_create_frame):
1472 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1473 Vframe_list (Bug#9999).
1474
22a648b4
DA
14752011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1476
0b381c7e 1477 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1478
659afede
KH
14792011-11-11 Kenichi Handa <handa@m17n.org>
1480
1481 * callproc.c (Fcall_process): Set the member dst_multibyte of
1482 process_coding.
1483
9ac0394b
KH
14842011-11-11 Johan Bockgård <bojohan@gnu.org>
1485
1486 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1487 avoid a crash (bug#9496).
1488
2fbdc249
CY
14892011-11-09 Chong Yidong <cyd@gnu.org>
1490
1491 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1492 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1493
ac6b1f81
PE
14942011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1497
09db192c
PE
14982011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 Avoid some portability problems by eschewing 'extern inline' functions.
1501 The trivial performance wins aren't worth the portability hassles; see
1502 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1503 et seq.
1504 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1505 (window_box_width, window_box_left, window_box_left_offset)
1506 (window_box_right, window_box_right_offset): Undo previous change,
1507 by removing the "extern"s.
1508 * intervals.c (adjust_intervals_for_insertion)
1509 (adjust_intervals_for_deletion): Undo previous change,
1510 making these static again.
1511 (offset_intervals, temp_set_point_both, temp_set_point)
1512 (copy_intervals_to_string): No longer inline.
1513 * xdisp.c (window_text_bottom_y, window_box_width)
1514 (window_box_height, window_box_left_offset)
1515 (window_box_right_offset, window_box_left, window_box_right)
1516 (window_box): No longer inline.
1517
105216ed
CY
15182011-11-08 Chong Yidong <cyd@gnu.org>
1519
1520 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1521 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1522 Signal an error if not a live window.
105216ed
CY
1523 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1524 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1525
ae9e237f
JB
15262011-11-07 Juanma Barranquero <lekktu@gmail.com>
1527
1528 * lisp.h (syms_of_abbrev): Remove declaration.
1529 Reported by CHENG Gao <chenggao@royau.me>.
1530
c7aa8333
EZ
15312011-11-07 Eli Zaretskii <eliz@gnu.org>
1532
1533 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1534 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1535 of temacs in GUI mode.
1536
be7f5545
MR
15372011-11-07 Martin Rudalics <rudalics@gmx.at>
1538
1539 * window.h: Declare delete_all_child_windows instead of
1540 delete_all_subwindows.
1541 * window.c (Fwindow_nest, Fset_window_nest)
1542 (Fset_window_new_total, Fset_window_new_normal)
1543 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1544 (delete_all_subwindows): Rename to delete_all_child_windows.
1545 (Fdelete_other_windows_internal, Fset_window_configuration):
1546 Call delete_all_child_windows instead of delete_all_subwindows.
1547 * frame.c (delete_frame): Call delete_all_child_windows instead
1548 of delete_all_subwindows.
1549
ca78dc43
PE
15502011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1551
1552 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1553 This is also needed for porting to any host where GC_MARK_STACK is
1554 not GC_MAKE_GCPROS_NOOPS.
1555 (which_symbols): Use it.
1556
a0241d01
KH
15572011-11-07 Kenichi Handa <handa@m17n.org>
1558
1559 * coding.c (coding_set_destination): Check coding->src_pos only
1560 when coding->src_object is a buffer (bug#9910).
1561
1562 * process.c (send_process): Set the member src_multibyte of coding
1563 to 0 (bug#9911) when sending a unibyte text.
1564
1565 * callproc.c (Fcall_process): Set the member src_multibyte of
1566 process_coding to 0 (bug#9912).
1567
a64bfdfa 15682011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1569
1570 * xmenu.c (cleanup_widget_value_tree): New function.
1571 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1572 calling free_menubar_widget_value_tree directly (Bug#9830).
1573
cb41b32a
PE
15742011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1575
1576 Fix some portability problems with 'inline'.
1577 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1578 (window_box_width, window_box_left, window_box_left_offset)
1579 (window_box_right, window_box_right_offset): Declare extern.
1580 Otherwise, these inline functions do not conform to C99 and
1581 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1582 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1583 * intervals.c (adjust_intervals_for_insertion)
1584 (adjust_intervals_for_deletion): Now extern, because otherwise the
1585 extern inline functions 'offset_intervals' couldn't refer to it.
1586 (static_offset_intervals): Remove.
1587 (offset_intervals): Rewrite using the old contents of
1588 static_offset_intervals. The old version didn't conform to C99
1589 because an extern inline function contained a reference to an
1590 identifier with static linkage.
1591
b7041366
AS
15922011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1593
1594 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1595 GC.
1596
88a37c4d
EZ
15972011-11-06 Eli Zaretskii <eliz@gnu.org>
1598
1599 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1600 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1601 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1602 return Qleft_to_right.
1603
49745b39
CY
16042011-11-06 Chong Yidong <cyd@gnu.org>
1605
1606 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1607 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1608 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1609 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1610 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1611 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1612 (Fwindow_vscroll): Doc fix.
1613 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1614 argument, since it makes no sense to pass a live window and for
1615 consistency with window-child.
1616
1f05cd82
CS
16172011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1618
1619 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1620 support MSVC.
1621
22610910
JR
16222011-11-05 Jason Rumney <jasonr@gnu.org>
1623
1624 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1625 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1626 fonts (Bug#6029).
1627 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1628 bitwise arithmetic preventing use of unicode-sip and non-truetype
1629 opentype fonts.
1630
a06776b2
EZ
16312011-11-05 Eli Zaretskii <eliz@gnu.org>
1632
3ad924ba
EZ
1633 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1634 "emacs"-only part.
1635
a06776b2
EZ
1636 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1637 initialization code to keep similarity to xfns.c after changes
1638 from 2011-11-05.
1639
c9e7db78
JD
16402011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1641
a97f8f3f
JD
1642 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1643 (unwind_create_frame): New function (Bug#9943).
1644 (Fx_create_frame): Restructure code to be more similar to the one in
1645 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1646 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1647 Move terminal->reference_count++ just before making the frame official
1648 (Bug#9943).
1649
1650 * nsterm.m (x_free_frame_resources): New function.
1651 (x_destroy_window): Move code to x_free_frame_resources.
1652
c9e7db78 1653 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1654 (Fx_create_frame, x_create_tip_frame):
1655 Move terminal->reference_count++ just before making the frame
75f1671a 1656 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1657 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1658
a6fc3b5c
EZ
16592011-11-05 Eli Zaretskii <eliz@gnu.org>
1660
1661 Support MSVC build with newer versions of Visual Studio.
1662 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1663 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1664 nt/gmake.defs.
1665
1666 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1667 which are not supported by MSVC.
1668 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1669 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1670 bitfields.
1671 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1672 types in bitfields.
1673 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1674
1675 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1676
58179cce 16772011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1678
1679 Support MSVC build with newer versions of Visual Studio.
1680 * w32.c: Don't include w32api.h for MSVC.
1681 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1682
1683 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1684 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1685 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1686 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1687 e_* cousins.
1688 (alloca) [_MSC_VER]: Define to _alloca.
1689
1690 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1691
1692 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1693
a58c13ed
EZ
16942011-11-04 Eli Zaretskii <eliz@gnu.org>
1695
1696 * xdisp.c (note_mouse_highlight): If either of
1697 previous/next-single-property-change returns nil, treat that as
1698 the beginning or the end of the buffer. (Bug#9955)
1699
fe0b6370
JD
17002011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1701
a58c13ed 1702 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1703 label is not null (Bug#9951).
1704 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1705 may be NULL.
1706
89bd5ee1
EZ
17072011-11-04 Eli Zaretskii <eliz@gnu.org>
1708
1709 * window.c (Fwindow_body_size): Mention in the doc string that the
1710 return value is in frame's canonical units. (Bug#9949)
1711
84c3edb9
EZ
17122011-11-03 Eli Zaretskii <eliz@gnu.org>
1713
4e2fb5c7
EZ
1714 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1715
84c3edb9 1716 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1717 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1718 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1719
bc17a887
EZ
17202011-11-01 Eli Zaretskii <eliz@gnu.org>
1721
1722 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1723 Don't stop backward scan on the continuation glyph, even though
1724 its CHARPOS is positive.
6d5eb5b0
SM
1725 (mouse_face_from_buffer_pos, note_mouse_highlight):
1726 Rename cover_string to disp_string.
bc17a887 1727
4ee88440
MR
17282011-11-01 Martin Rudalics <rudalics@gmx.at>
1729
1730 * window.c (temp_output_buffer_show): Don't use
1731 Vtemp_buffer_show_specifiers.
1732 (Vtemp_buffer_show_specifiers): Remove unused variable.
1733
c2ff3c02
EZ
17342011-10-30 Eli Zaretskii <eliz@gnu.org>
1735
1736 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1737 past the beginning of the current glyph matrix.
1738
58179cce 17392011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1740
1741 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1742 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1743 HAVE_GTK3 (Bug#9869).
b77a6a7f 1744
3b574623
JD
1745 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1746 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1747
b77a6a7f
JD
1748 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1749
1750 * xterm.c: Declare x_handle_net_wm_state to return int.
1751 (handle_one_xevent): Check if we are iconified but don't have
1752 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1753 (get_current_wm_state): Return non-zero if not hidden,
1754 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1755 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1756 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1757 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1758
196e41e4
PE
17592011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1762 so that this new function doesn't get optimized away by a
1763 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1764
021f2e1a
AS
17652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1766
1767 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1768
8b058d44
EZ
17692011-10-29 Eli Zaretskii <eliz@gnu.org>
1770
1771 Fix the `xbytecode' command.
1772 * .gdbinit (xprintbytestr): New command.
b50a28de 1773 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1774 (xbytecode): Print the byte-code string as well.
1775
4452fb80
EZ
17762011-10-29 Kim Storm <storm@cua.dk>
1777
8b058d44
EZ
1778 * alloc.c (which_symbols): New function.
1779
21b72067
AS
17802011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1781
1782 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1783 line. (Bug#9903)
1784
83ed7b5c
GM
17852011-10-29 Glenn Morris <rgm@gnu.org>
1786
1787 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1788 Not clear what it was for, and it causes various bugs. (Bug#9839)
1789
5a7a728b
EZ
17902011-10-28 Eli Zaretskii <eliz@gnu.org>
1791
1792 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1793 possible random value that matches one of those tested as
1794 condition to clear the mouse face.
1795
d3d0842f
CY
17962011-10-28 Chong Yidong <cyd@gnu.org>
1797
1798 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1799
31b39d13
DN
18002011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1801
1802 * window.c (make_window): Initialize phys_cursor_on_p.
1803
9aba6043
SM
18042011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1805
1806 * lisp.h (struct Lisp_Symbol): Update comments.
1807
c20992f4
JB
18082011-10-28 Juanma Barranquero <lekktu@gmail.com>
1809
1810 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1811
db4f02f2
EZ
18122011-10-28 Eli Zaretskii <eliz@gnu.org>
1813
1814 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1815 <oslsachem@gmail.com> for helping to debug this.
1816
1817 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1818 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1819 (g_b_init_get_glyph_outline_w): New static variables.
1820 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1821 (GetGlyphOutlineW_Proc): New typedefs.
1822 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1823 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1824 New functions.
1825 (w32font_open_internal, compute_metrics):
1826 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1827 instead of calling the "wide" APIs directly.
1828
1829 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1830
1831 * w32.h (syms_of_w32font): Add prototype.
1832
87e68db4
JB
18332011-10-27 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1836 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1837 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1838 (Fmove_to_window_line): Doc fix.
1839
435c1d67
CY
18402011-10-27 Chong Yidong <cyd@gnu.org>
1841
1842 * process.c (make_process): Set gnutls_state to NULL.
1843
1844 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1845 non-NULL, regardless of GNUTLS_INITSTAGE.
1846 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1847 an error. Set process slots as soon as we allocate them.
1848
1849 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1850
9c6c6f49
CY
18512011-10-27 Chong Yidong <cyd@gnu.org>
1852
9aba6043
SM
1853 * gnutls.c (emacs_gnutls_deinit): New function.
1854 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1855 (Fgnutls_deinit, Fgnutls_boot): Use it.
1856
1857 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1858 (deactivate_process): Call emacs_gnutls_deinit.
1859
657d08d3
JB
18602011-10-27 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * image.c (x_create_x_image_and_pixmap):
1863 * w32.c (sys_rename, w32_delayed_load):
1864 * w32font.c (fill_in_logfont):
1865 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1866
5430d399
JB
18672011-10-26 Juanma Barranquero <lekktu@gmail.com>
1868
1869 * w32fns.c (w32_default_color_map): New function,
1870 extracted from Fw32_default_color_map.
a7ef684b 1871 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1872
fe0055fa
PE
18732011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1876
e6346438
SM
18772011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1878
1879 * keyboard.c (test_undefined): New function (bug#9751).
1880 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1881
e112cc37
ET
18822011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1883
1884 * sysdep.c (init_sys_modes): Fix the check for the controlling
1885 terminal (Bug#6649).
1886
7b5d6677
EZ
18872011-10-20 Eli Zaretskii <eliz@gnu.org>
1888
1889 * dispextern.h (struct bidi_it): New member next_en_type.
1890
1891 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1892 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1893 current character, check also for next_en_type being WEAK_EN.
1894 (bidi_resolve_weak): Don't enter the expensive loop if the current
1895 position is before next_en_pos. Record the bidi type of the first
1896 non-ET, non-BN character we find, in addition to its position.
1897 (bidi_level_of_next_char): Invalidate next_en_type when
1898 next_en_pos is over-stepped.
1899
7da0b018
PE
19002011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1903 * editfns.c: Rewrite current-time-zone so that it invokes
1904 the equivalent of (format-time-string "%Z") to get the time zone name.
1905 This fixes a bug when the time zone name contains characters that
1906 need converting from the system time locale to Emacs internal format.
1907 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1908 that patch fixed format-time-string to do the conversion, but
1909 I forgot to fix current-time-zone.
1910 (format_time_string): New function, containing most of
1911 what Fformat_time_string used to contain.
1912 (Fformat_time_string): Rewrite in terms of format_time_string.
1913 This doesn't change this function's behavior.
1914 (current-time-zone): Rewrite to use format_time_string.
1915 This fixes the bug reported by Michael Schierl in
1916 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1917 Jason Rumney's 2007-06-07 change worked around this bug, but
1918 didn't fix it.
1919 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1920
8547b010
EZ
19212011-10-19 Eli Zaretskii <eliz@gnu.org>
1922
1923 * xdisp.c (start_display): If the character at POS is displayed
1924 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1925 (try_window_reusing_current_matrix): If a line ends in a display
1926 vector or the next line starts in a display vector, continue
1927 redrawing the window even though the character position of
1928 start_row was reached.
8547b010
EZ
1929 (Bug#9771, part 2)
1930
4e948d15
CY
19312011-10-18 Chong Yidong <cyd@gnu.org>
1932
1933 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1934 with nobreak-char-display too.
1935
4787455f
EZ
19362011-10-18 Eli Zaretskii <eliz@gnu.org>
1937
1938 Fix part 3 of bug#9771.
1939 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1940 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1941 non-neutral characters if the current character is a paragraph
1942 separator (a.k.a. Newline). This avoids running the same
1943 expensive loop twice, once when we consume the preceding newline
1944 and the other time when the line actually needs to be displayed.
1945 Avoid the loop when we see neutrals on the base embedding level
1946 following a character whose directionality is the same as the
1947 paragraph's. This avoids running the expensive loop when a line
1948 ends in a long sequence of neutrals, like control characters.
1949 Add assertion against STRONG_AL type. Slightly rearrange code
1950 that determines the type of a neutral given the first non-neutral
1951 that follows it.
1952 (bidi_level_of_next_char): Set next_en_pos to zero when
1953 invalidating its info.
1954
2c91f553
EZ
19552011-10-17 Eli Zaretskii <eliz@gnu.org>
1956
1957 * xdisp.c (push_display_prop): Determine whether to record string
1958 or buffer position by IT->string, not by IT->method. Allow
1959 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1960 (move_it_vertically_backward): Don't look for character position
1961 immediately after the newline when in a continuation line.
1962 (Bug#9771, part 1)
2c91f553 1963
c7b08b0d
MR
19642011-10-15 Martin Rudalics <rudalics@gmx.at>
1965
1966 * window.c (coordinates_in_window): Rewrite and delabelize
1967 vertical border check. (Bug#5357) (Bug#9618)
1968
6b02f655
SM
19692011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1970
1971 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1972 errors in XSetWindowBorder (bug#9310).
1973
81d40c92
DA
19742011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1975
1976 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1977 avoid crash when xmalloc overrun checking is enabled.
1978
d4172c3b
EZ
19792011-10-13 Eli Zaretskii <eliz@gnu.org>
1980
1981 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1982 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1983 cursor motion with <left> and <right> arrow keys.
1984
1985 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1986 some callers set that themselves.
1987
b00eea75
EZ
19882011-10-12 Eli Zaretskii <eliz@gnu.org>
1989
1990 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1991 display string and the previous row comes from the same string and
1992 is empty. (Bug#9739) (Bug#9738)
1993
8fe012c4
SM
19942011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1995
1996 * doc.c (get_doc_string): Encode file name (bug#9735).
1997
0074aef2
EZ
19982011-10-12 Eli Zaretskii <eliz@gnu.org>
1999
79beb178
EZ
2000 * bidi.c (bidi_level_of_next_char):
2001 * xdisp.c (get_visually_first_element): Remove old incorrect
2002 comments regarding the Unicode Line Separator character.
2003
0074aef2
EZ
2004 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2005
6e4b3fbe
DA
20062011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2007
2008 * alloc.c (Fgc_status): Do not access beyond zombies array
2009 boundary if nzombies > MAX_ZOMBIES.
2010 * alloc.c (dump_zombies): Add missing format specifier.
2011
0324f3af
PE
20122011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2013
b5525cac
PE
2014 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2015 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2016
0324f3af
PE
2017 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2018 Some packages use them to denote characters with modifiers.
2019
e9b5f888
AS
20202011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2021
2022 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2023 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2024 matching a pp-number. Rename parameter var to var1.
2025
127827c0
SM
20262011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2027
2028 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2029
c8fd3bd0
GM
20302011-10-08 Glenn Morris <rgm@gnu.org>
2031
2032 * callint.c (Fcall_interactively): Give a more explicit error for the
2033 'c' case with a non-character input. (Bug#8479)
2034
352ec8ff
EZ
20352011-10-08 Eli Zaretskii <eliz@gnu.org>
2036
03669ccb
EZ
2037 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2038 lines.
7061c986
EZ
2039 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2040 lines that are hscrolled on the left.
03669ccb 2041
352ec8ff
EZ
2042 * dispnew.c (buffer_posn_from_coords): Account for a possible
2043 presence of header-line. (Bug#4426)
2044
a66cfb1c
SM
20452011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2046
6b02f655
SM
2047 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2048 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2049
7c5ee88e
PE
20502011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2053 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2054 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2055 this makes Emacs dump core during garbage collection on rare
2056 occasions. sizeof is obviously inferior to offsetof here, so
2057 stick with offsetof.
2058 (GC_POINTER_ALIGNMENT): New macro.
2059 (mark_memory): Omit 3rd (offset) arg; caller changed.
2060 Don't assume EMACS_INT alignment is the same as pointer alignment.
2061
df1bbe5b
SM
20622011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2063
2064 * keyboard.c (read_key_sequence_remapped): New var.
2065 (read_key_sequence): Compute remapping in the right buffer.
2066 (command_loop_1): Use read_key_sequence's remapping directly.
2067
51553db6
SM
20682011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2069
32c1fffd
SM
2070 * dired.c (file_name_completion): Don't expand file name.
2071 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2072 before checking file name handler.
2073
51553db6
SM
2074 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2075 they've been requested explicitly (bug#9591).
2076
b6bd1599 20772011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2078
2079 * keymap.c (Fsingle_key_description): Use make_specified_string
2080 instead of build_string to build string from push_key_description.
2081 (Bug#5193)
2082
f701dc2a
PE
20832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2084
4222c55d
PE
2085 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2086 This fixes a Y2038 bug on 64-bit hosts.
2087 * buffer.c (reset_buffer):
2088 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2089 (Fclear_buffer_auto_save_failure):
2090 Use 0, not -1, to represent an unset failure time, since time_t
2091 might not be signed.
2092
f701dc2a
PE
2093 Remove dependency on glibc malloc internals.
2094 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2095 Move back here from lisp.h, but with their new implementations.
2096 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2097 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2098 * charset.c (charset_table_init): New static var.
2099 (syms_of_charset): Use it instead of xmalloc. This removes a
2100 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2101 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2102 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2103 Move back to alloc.c.
2104 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2105 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2106
9ceebf39
JD
21072011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2108
2109 * nsterm.m (windowDidResize): Call x_set_window_size only when
2110 ns_in_resize is true. Otherwise set pixelwidth/height and
2111 call change_frame_size (Bug#9628).
2112
cb993c58
PE
21132011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2114
3930c88b
PE
2115 Port --enable-checking=all to Fedora 14 x86-64.
2116 * charset.c (syms_of_charset): Also account for glibc malloc's
2117 internal overhead when calculating the initial malloc maximum.
2118
cb993c58
PE
2119 Port --enable-checking=all to Fedora 14 x86.
2120 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2121 Move to lisp.h.
2122 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2123 (overrun_check_realloc, overrun_check_free):
2124 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2125 That way, xmalloc returns a properly-aligned pointer even if
2126 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2127 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2128 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2129 into account when calculating the initial malloc maximum.
2130 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2131 Move here from alloc.c, so that charset.c can use it too.
2132 Properly align; the old code wasn't right for common 32-bit hosts
2133 when configured with --enable-checking=all.
2134 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2135 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2136
31bed486
EZ
21372011-09-29 Eli Zaretskii <eliz@gnu.org>
2138
04c70788 2139 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2140 use EDOM.
2141
fbcaa2f3
EZ
21422011-09-28 Eli Zaretskii <eliz@gnu.org>
2143
2144 * xdisp.c (compute_display_string_end): If there's no display
2145 string at CHARPOS, return -1.
2146
2147 * bidi.c (bidi_fetch_char): When compute_display_string_end
2148 returns a negative value, treat the character as a normal
2149 character not covered by a display string. (Bug#9624)
2150
a239d4e9
JB
21512011-09-28 Juanma Barranquero <lekktu@gmail.com>
2152
2153 * lread.c (Fread_from_string): Fix typo in docstring.
2154
88652fd5
EZ
21552011-09-27 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2158 newline, reseat the iterator instead of bidi-iterating there one
2159 character at a time. (Bug#9610)
32c1fffd
SM
2160 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2161 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2162
ed497dd4
AS
21632011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2164
2165 * lread.c (readevalloop): Use correct code for NBSP.
2166 (read1): Likewise. (Bug#9608)
2167
b2bf61aa
MA
21682011-09-25 Michael Albinus <michael.albinus@gmx.de>
2169
2170 * dbusbind.c (Fdbus_register_signal): When service is not
2171 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2172
32bbb17c
GM
21732011-09-25 Glenn Morris <rgm@gnu.org>
2174
2175 * buffer.c (truncate-lines): Doc fix.
2176
94e0933e
CY
21772011-09-24 Chong Yidong <cyd@stupidchicken.com>
2178
2179 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2180 (Fset_window_next_buffers): Doc fix.
2181
cddde921
GM
21822011-09-24 Glenn Morris <rgm@gnu.org>
2183
2184 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2185
1260aef1
PE
21862011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2187
25b4bfa0
PE
2188 Fix minor problems found by static checking.
2189 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2190 * indent.c (Fvertical_motion): Fix == vs = typo.
2191
e3cbd34b
EZ
21922011-09-24 Eli Zaretskii <eliz@gnu.org>
2193
a66cfb1c
SM
2194 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2195 Default value is now t. Doc fix.
6bf7006f 2196
e3cbd34b 2197 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2198 logic when moving up, not only when moving down. Fix the
e3cbd34b 2199 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2200 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2201
2202 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2203 CHARPOS is covered by a display string which includes newlines.
2204 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2205 is covered by a display string with embedded newlines.
2206
a3de0cbd
MA
22072011-09-24 Michael Albinus <michael.albinus@gmx.de>
2208
2209 * dbusbind.c (Fdbus_register_signal): Add match rule to
2210 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2211 (Fdbus_register_method, Vdbus_registered_objects_table):
2212 Fix docstring.
a3de0cbd 2213
b260039d
JM
22142011-09-24 Jim Meyering <meyering@redhat.com>
2215
32c1fffd 2216 do not ignore write error for any output size
b260039d
JM
2217 The previous change was incomplete.
2218 While it makes emacs --batch detect the vast majority of stdout
2219 write failures, errors were still ignored whenever the output size is
2220 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2221 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2222 && echo FAIL: ignored write error
2223 FAIL: ignored write error
2224 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2225 && echo FAIL: ignored write error
2226 FAIL: ignored write error
2227 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2228
8eca8a7c
AS
22292011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2230
2231 * emacs.c (Fkill_emacs): In noninteractive mode exit
2232 non-successfully if a write error occurred on stdout. (Bug#9574)
2233
3341db62
EZ
22342011-09-21 Eli Zaretskii <eliz@gnu.org>
2235
2236 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2237 the xassert test.
2238
2239 * dispextern.h (struct it): Update the comment documenting what
2240 can it->OBJECT be.
2241
8c203dbf
EZ
22422011-09-20 Eli Zaretskii <eliz@gnu.org>
2243
2244 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2245 a display string, extend search for cursor position to end of row.
2246 (find_row_edges): If the row ends in a newline from a display
2247 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2248 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2249 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2250 non-empty line. Fixes confusing cursor motion with arrow keys at
2251 the beginning of a line that starts with whitespace.
8c203dbf 2252
a4824228
LMI
22532011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2254
2255 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2256 (bug#9493).
2257
33ed493b
CY
22582011-09-18 Chong Yidong <cyd@stupidchicken.com>
2259
2260 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2261 boolean (Bug#9154).
2262
56cd55c8
EZ
22632011-09-18 Eli Zaretskii <eliz@gnu.org>
2264
2265 * xdisp.c (display_line): Record maximum and minimum buffer
2266 positions even if no glyphs were produced (e.g., by a zero-width
2267 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2268 buffer positions that will be removed from the glyph row because
2269 they don't fit.
c02dcedf
EZ
2270 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2271 column is beyond frame width: don't subtract 1 "pixel" when
2272 computing width of the stretch.
3e62b7e0
EZ
2273 (reseat_at_next_visible_line_start): Undo the change made on
2274 2011-09-17 that saved paragraph information and restored it after
2275 the call to `reseat'. (Bug#9545)
56cd55c8 2276
5ed99d36 22772011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2278
2279 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2280 and turn window cursor on if cleared (Bug#9415).
2281
5ed99d36 22822011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2283
2284 * search.c (boyer_moore): Take unibyte characters from pattern
2285 literally. (Bug#9458)
2286
9bade7b2
EZ
22872011-09-18 Eli Zaretskii <eliz@gnu.org>
2288
2289 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2290
e5e9d610
PE
22912011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2292
87e4427a
PE
2293 Fix minor problem found by static checking.
2294 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2295 initialized, to pacify gcc -Wuninitialized.
2296
e5e9d610
PE
2297 * fileio.c: Report proper errno when syscall falls.
2298 (Finsert_file_contents): Save and restore errno,
2299 so that report_file_error outputs the correct diagnostic.
2300 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2301
a1674f0b
EZ
23022011-09-18 Eli Zaretskii <eliz@gnu.org>
2303
2304 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2305
fbfb6dd4
EZ
23062011-09-17 Eli Zaretskii <eliz@gnu.org>
2307
2308 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2309 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2310
bb187662
EZ
23112011-09-17 Eli Zaretskii <eliz@gnu.org>
2312
1137e8b8 2313 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2314 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2315
2316 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2317 (bidi_find_paragraph_start): Search back for paragraph beginning
2318 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2319 (bidi_move_to_visually_next): Only trigger paragraph-related
2320 computations when the last character is a newline or at EOB, not
2321 just any NEUTRAL_B. (Bug#9470)
2322
bb187662
EZ
2323 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2324 truncated lines if point is covered by a display string. (Bug#9524)
2325
2e621251
PE
23262011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2327
2328 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2329 (cons_to_x_long): New function.
2330 (lisp_data_to_selection_data): Use it. Correct the test for
2331 short-versus-long data; it was negated. Break out of vector
2332 loop, for efficiency, when a long datum is discovered.
2333
91a15bc6
SM
23342011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2335
2336 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2337
b41c3a35
EZ
23382011-09-16 Eli Zaretskii <eliz@gnu.org>
2339
2340 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2341 GCC PR/17406) by declaring this function with external scope.
2342
7812ba2d
PE
23432011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2344
2345 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2346 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2347
cf7edc2a
AS
23482011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2349
2350 * editfns.c (Fformat): Correctly handle text properties on "%%".
2351
bd01620e
EZ
23522011-09-15 Eli Zaretskii <eliz@gnu.org>
2353
2354 * xterm.c (x_draw_composite_glyph_string_foreground):
2355 * w32term.c (x_draw_composite_glyph_string_foreground):
2356 * term.c (encode_terminal_code):
2357 * composite.c (composition_update_it, get_composition_id):
2358 * xdisp.c (get_next_display_element)
2359 (fill_composite_glyph_string): Add comments about special meaning
2360 of TAB characters in a composition.
2361
a02719a3
PE
23622011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2365 This occurs when processing a multibyte format.
2366 Problem reported by Wolfgang Jenker.
a02719a3 2367
72589a3c
JB
23682011-09-15 Johan Bockgård <bojohan@gnu.org>
2369
2370 * xdisp.c (try_cursor_movement): Only check for exact match if
2371 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2372
1c14176c
PE
23732011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 Remove unused external symbols.
2376 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2377 * xdisp.c (calc_pixel_width_or_height): Now static.
2378 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2379 * indent.c (check_display_width):
2380 * w32term.c: Fix comment to match code.
2381 * xterm.c, xterm.h (x_catching_errors): Remove.
2382
d2eea5b5
PE
23832011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 * xselect.c: Use signed conversions more consistently (Bug#9498).
2386 (selection_data_to_lisp_data): Assume incoming selection data are
2387 signed integers, not unsigned. This is to be consistent with
2388 outgoing selection data, which was modified to use signed integers
2389 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2390 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2391 expects long, not unsigned long.
2392
46888499
EZ
23932011-09-14 Eli Zaretskii <eliz@gnu.org>
2394
2395 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2396 computation of loop end. Reported by Johan Bockgård
2397 <bojohan@gnu.org>.
2398
ef8ef9fb
CY
23992011-09-13 Chong Yidong <cyd@stupidchicken.com>
2400
2401 * frame.c (Fother_visible_frames_p): Function deleted.
2402
fa819fed
EZ
24032011-09-12 Eli Zaretskii <eliz@gnu.org>
2404
2405 * indent.c (compute_motion): Process display vector front to back
2406 rather than the other way around. (Bug#2496)
2407
2ba8e008
SM
24082011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2409
2410 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2411
20f53c69
CY
24122011-09-11 Chong Yidong <cyd@stupidchicken.com>
2413
2414 * minibuf.c (Fread_from_minibuffer): Doc fix.
2415
d562d7a4
EZ
24162011-09-11 Eli Zaretskii <eliz@gnu.org>
2417
2418 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2419 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2420
1c4d7f3d
LMI
24212011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2422
2423 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2424 value for non-existent files.
2425
b885bf36
EZ
24262011-09-11 Eli Zaretskii <eliz@gnu.org>
2427
2428 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2429 set its "size" to -1. This will set the modtime_size field of
2430 the corresponding buffer to -1, which is what
2431 verify-visited-file-modtime expects for files that do not exist.
2432 (Bug#9139)
2433
6612f0bf
PE
24342011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2437 here ...
2438 * lisp.h: ... from here. push_key_description is no longer
2439 defined in keyboard.c, so its declaration should not be in
2440 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2441 logically belongs with push_key_description.
2442
dfb3f755
PE
24432011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * buffer.h: Include <sys/types.h> instead of <time.h>.
2446 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2447 Problem reported by Herbert J. Skuhra.
2448
3134906c
LMI
24492011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2450
2451 * xml.c (parse_region): Make the parsing work for
2452 non-comment-starting XML files again (bug#9144).
2453
8d903f4e
AS
24542011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2455
2456 * image.c (gif_load): Fix calculation of bottom and right corner.
2457 (Bug#9468)
2458
80ad64f4
EZ
24592011-09-10 Eli Zaretskii <eliz@gnu.org>
2460
2461 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2462 redisplay in small windows.
2463
208a048d
EZ
24642011-09-09 Eli Zaretskii <eliz@gnu.org>
2465
2466 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2467
9b1c252e
MR
24682011-09-08 Martin Rudalics <rudalics@gmx.at>
2469
2470 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2471 Operate on live windows only.
2472
2949f33b
JB
24732011-09-08 Juanma Barranquero <lekktu@gmail.com>
2474
2475 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2476
e08dcafd
EZ
24772011-09-07 Eli Zaretskii <eliz@gnu.org>
2478
2479 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2480 only under bidi iteration.
2481
115b96bd
JD
24822011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2483
2484 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2485
c8199d0f
PE
24862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2489 Without this fix, the command to link temacs failed due to an
2490 undefined symbol __builtin_isnan. This is because
2491 /usr/include/iso/math_c99.h #defines isnan(x) to
2492 __builtin_isnan(x), but the bundled gcc, which identifies itself
2493 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2494 a __builtin_isnan.
2495 * floatfns.c (isnan): #undef, and then #define to a clone of
2496 what's in data.c.
2497 (Fisnan): Always define, since it's always available now.
2498 (syms_of_floatfns): Always define isnan at the Lisp level.
2499
e39b275c 25002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2501
2502 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2503
b2db44d9 25042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2505
f4af5137 2506 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2507 The previous code assumed that file offsets (off_t values) fit in
2508 EMACS_INT variables, which is not true on typical 32-bit hosts.
2509 The code messed up by falsely reporting buffer overflow in cases
2510 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2511 when "big" contains more than 2**29 bytes, even though this
2512 inserts just one byte and does not overflow the buffer.
2513 (Finsert_file_contents): Store file offsets as off_t
2514 values, not as EMACS_INT values. Check for overflow when
2515 converting between EMACS_INT and off_t. When checking for
2516 buffer overflow or for overlap, take the offsets into account.
2517 Don't use EMACS_INT for small values where int suffices.
2518 When checking for overlap, fix a typo: ZV was used where
2519 ZV_BYTE was intended.
2520 (Fwrite_region): Don't assume off_t fits into 'long'.
2521 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2522
ecfc0a49
MA
25232011-09-05 Michael Albinus <michael.albinus@gmx.de>
2524
2525 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2526
6511acf2 25272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2528
0999621a 2529 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2530
2531 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2532 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2533 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2534 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2535 (modify_event_symbol): Do not assume that the length of
2536 name_alist_or_stem is safe to alloca and fits in int.
2537 (Fexecute_extended_command): Likewise for function name and binding.
2538 (Frecursion_depth): Wrap around reliably on integer overflow.
2539 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2540 since some callers pass EMACS_INT values.
2541 (Fsingle_key_description): Don't crash if symbol name contains more
2542 than MAX_ALLOCA bytes.
2543 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2544 (get_minibuffer): Arg is now EMACS_INT, not int.
2545 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2546 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2547 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2548
2be7d702
PE
2549 * dbusbind.c (signature_cat): New function.
2550 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2551 Do not overrun buffer; instead, report string overflow.
2552
9d1df220
PE
2553 * dispnew.c (add_window_display_history): Don't overrun buffer.
2554 Truncate instead; this is OK since it's just a log.
2555
33ef5c64
PE
2556 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2557 even if the time zone offset is outlandishly large.
2558 Don't mishandle offset == INT_MIN.
2559
66c6fdd5
PE
2560 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2561 when creating daemon; the previous buffer-overflow check was incorrect.
2562
d749b01b
PE
2563 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2564 which has the guts of the old verror function.
2565
b5cd1905
PE
2566 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2567 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2568
6e1a67fb
PE
2569 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2570 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2571 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2572 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2573 length of string rather than counting it via multiple sprintfs;
2574 that's simpler and more reliable.
c21721cc
PE
2575 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2576 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2577 sprintf, in case result does not fit in int.
2578
c57b67fc
PE
2579 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2580 (fontset_from_font): Print it.
2581
8a401434
PE
2582 * frame.c (tty_frame_count): Now printmax_t, not int.
2583 (make_terminal_frame, set_term_frame_name): Print it.
2584 (x_report_frame_params): In X, window IDs are unsigned long,
2585 not signed long, so print them as unsigned.
2586 (validate_x_resource_name): Check for implausibly long names,
2587 and don't assume name length fits in 'int'.
2588 (x_get_resource_string): Don't blindly alloca invocation name;
2589 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2590 not fit in int.
2591
6e1a67fb
PE
2592 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2593 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2594 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2595
0df02bf3
PE
2596 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2597 Use esprintf, not sprintf, in case result does not fit in int.
2598
48e30793
PE
2599 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2600 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2601 it as a large positive number.
2602 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2603 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2604
a66ff6d8
PE
2605 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2606 in case result does not fit in int.
2607
aca216ff
PE
2608 * print.c (float_to_string): Detect width overflow more reliably.
2609 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2610 buffer overrun. Don't assume list length fits in 'int'. Treat
2611 print length of 0 as 0, not as infinity; to be consistent with other
2612 uses of print length in this function. Don't overflow print length
2613 index. Don't assume hash table size fits in 'long', or that
2614 vectorlike size fits in 'unsigned long'.
2615
31c286f7
PE
2616 * process.c (make_process): Use printmax_t, not int, to format
2617 process-name gensyms.
2618
55e5faa1
PE
2619 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2620
80f2e268
PE
2621 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2622 to avoid potential buffer overrun.
2623
670741ab
PE
2624 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2625 if X resource line is longer than 512 bytes.
2626
b7163a50
PE
2627 * xfns.c (x_window): Make sprintf buffer a bit bigger
2628 to avoid potential buffer overrun.
2629
ae58ff1f
PE
2630 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2631
c43c8a6a
PE
2632 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2633
3f8236f4
PE
26342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2635
53e9fe90 2636 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2637 Without these, Emacs silently mishandles large integers sometimes.
2638 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2639 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2640
6511acf2
PE
2641 * xdisp.c (try_window_id): Check Emacs fixnum range before
2642 converting to 'int'.
806add1d 2643
6511acf2 2644 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2645 Check that an Emacs fixnum is in range before assigning it to 'int'.
2646 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2647 values converted from Emacs fixnums.
2648 (Frecenter): Don't wrap around a line count if it is out of 'int'
2649 range; instead, treat it as an extreme value.
2650 (Fset_window_configuration, compare_window_configurations):
2651 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2652
6511acf2
PE
2653 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2654 that can exceed INT_MAX. Check that EMACS_INT value is in range
2655 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2656 (match_limit): Don't assume that a fixnum can fit in 'int'.
2657
6511acf2 2658 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2659 exceed INT_MAX.
2660
6511acf2 2661 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2662 (Fvertical_motion): Don't wrap around LINES values that don't fit
2663 in 'int'. Instead, treat them as extreme values. This is good
2664 enough for windows, which can't have more than INT_MAX lines anyway.
2665
fcb901a7
LMI
26662011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2667
0f2f6b6d
LMI
2668 * Require libxml/parser.h to avoid compilation warning.
2669
fcb901a7
LMI
2670 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2671
2672 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2673 since this reportedly can destroy thread storage.
2674
6e20a0d4
CY
26752011-08-30 Chong Yidong <cyd@stupidchicken.com>
2676
2677 * syntax.c (find_defun_start): Update all cache variables if
2678 exiting early (Bug#9401).
2679
148ae00e
EZ
26802011-08-30 Eli Zaretskii <eliz@gnu.org>
2681
f6cfbd8f
EZ
2682 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2683
148ae00e
EZ
2684 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2685 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2686 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2687
2688 * term.c (tty_append_glyph): New function.
2689 (produce_stretch_glyph): Static function and its prototype deleted.
2690
a66cfb1c
SM
2691 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2692 Add prototypes.
148ae00e 2693
c4a07a4c
PE
26942011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2695
2696 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2697 when checking :margin (Bug#9390).
2698 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2699 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2700 so that the name doesn't mislead. All uses changed.
2701
6bc8cd65
JB
27022011-08-28 Johan Bockgård <bojohan@gnu.org>
2703
2704 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2705 set_tty_hooks.
2706
dca4927e
EZ
27072011-08-27 Eli Zaretskii <eliz@gnu.org>
2708
2709 * xdisp.c (move_it_to): Don't bail out early when reaching
2710 position beyond to_charpos, if we are scanning backwards.
2711 (move_it_vertically_backward): When DY == 0, make sure we get to
2712 the first character in the line after the newline.
2713
f2cad773
PE
27142011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2717 (ccl_driver): Do not generate an out-of-range pointer.
2718 (Fccl_execute_on_string): Remove unnecessary check for
2719 integer overflow, noted by Stefan Monnier in
2720 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2721 Remove a FIXME that didn't need fixing.
2722 Simplify the newly-introduced buffer reallocation code.
2723
0cae2cdb
JB
27242011-08-27 Juanma Barranquero <lekktu@gmail.com>
2725
2726 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2727
5fc295a4 27282011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2729
70c60eb2 2730 Integer and memory overflow issues (Bug#9196).
726e0ab1 2731
d31850da
PE
2732 * doc.c (get_doc_string): Rework so that
2733 get_doc_string_buffer_size is the actual buffer size, rather than
2734 being 1 less than the actual buffer size; this makes xpalloc more
2735 convenient.
2736
a69fbedb
PE
2737 * image.c (x_allocate_bitmap_record, cache_image):
2738 * xselect.c (Fx_register_dnd_atom):
2739 Simplify previous changes by using xpalloc.
2740
fe5c5d37
PE
2741 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2742 since either will do and ptrdiff_t is convenient with xpalloc.
2743
0065d054
PE
2744 * charset.c (charset_table_size)
2745 (struct charset_sort_data.priority): Now ptrdiff_t.
2746 (charset_compare): Don't overflow if priorities differ greatly.
2747 (Fsort_charsets): Don't assume list length fits in int.
2748 Check for size-calculation overflow when allocating sort data.
2749 (syms_of_charset): Allocate an initial charset table that is
2750 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2751
2752 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2753
2754 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2755 The actual value is always <= INT_MAX, and leaving it unsigned made
2756 overflow checking harder.
2757
2758 * dispextern.h (struct glyph_matrix.rows_allocated)
2759 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2760 with xpalloc. The values are still always <= INT_MAX.
2761
2762 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2763
2764 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2765 (SAFE_NALLOCA): New macro.
2766
2767 * region-cache.c (struct boundary.pos, find_cache_boundary)
2768 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2769 (set_cache_region, invalidate_region_cache)
2770 (revalidate_region_cache, know_region_cache, region_cache_forward)
2771 (region_cache_backward, pp_cache):
2772 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2773 so that ptrdiff_t * can be passed to xpalloc.
2774 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2775 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2776 (pp_cache): Don't assume cache_len fits in int.
2777 * region-cache.h: Adjust extern decls to match.
2778
2779 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2780 EMACS_INT, since either will do, for xpalloc.
2781
2782 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2783 (xnmalloc, xnrealloc, xpalloc): New functions.
2784
726e0ab1
PE
2785 * bidi.c (bidi_shelve_header_size): New constant.
2786 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2787 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2788
51f30bc5 2789 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2790 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2791 (overlay_strings):
2792 Don't update size of array until after memory allocation succeeds,
2793 because xmalloc/xrealloc may not return.
0065d054
PE
2794 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2795 now that we have proper integer overflow checking.
2796 (record_overlay_string, overlay_strings): Catch overflows when
2797 calculating size of overlay_str_buf.
726e0ab1 2798
0065d054
PE
2799 * callproc.c (Fcall_process): Check for size overflow when
2800 calculating size of args2.
2801 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2802 Normally we prefer signed values, but sticking with ptrdiff_t would
2803 require adding more-complicated checks.
726e0ab1
PE
2804
2805 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2806 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2807 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2808 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2809
2810 * character.c (Fstring): Check for size-calculation overflow.
2811
2812 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2813 unnecessary integer overflow. Check for size overflow.
2814 (encode_coding_object): Don't update size until xmalloc succeeds.
2815
2816 * composite.c (get_composition_id): Check for overflow in glyph
2817 length calculations.
2818
2819 Integer and memory overflow fixes for display code.
2820 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2821 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2822 (scrolling_window): Check for overflow in size calculations.
2823 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2824 Don't assume glyph table len fits in int.
2825 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2826 (row_table_size): Now ptrdiff_t, not int.
2827 (scrolling_window): Avoid overflow in size calculations.
2828 Don't update size until allocation succeeds.
2829 * fns.c (concat): Check for overflow in size calculations.
2830 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2831 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2832 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2833
2834 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2835 (get_doc_string): Check for size calculation overflow.
2836 Don't update size until allocation succeeds.
2837 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2838 EMACS_INT, where ptrdiff_t will do.
2839 (Fsubstitute_command_keys): Check for string overflow.
2840
2841 * editfns.c (set_time_zone_rule): Don't assume environment length
2842 fits in int.
2843 (message_length): Now ptrdiff_t, not int.
2844 (Fmessage_box): Don't update size until allocation succeeds.
2845 Don't assume message length fits in int.
2846 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2847
0065d054
PE
2848 * emacs.c (main): Do not reallocate argv, since there is a null at
2849 the end that can be overwritten, and this way there's no need to
2850 worry about size-calculation overflow.
2851 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2852
2853 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2854 alloc succeeds.
2855 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2856
2857 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2858 (x_set_scroll_bar_width, x_figure_window_size):
2859 Check for integer overflow.
2860 (x_set_alpha): Do not assume XINT fits in int.
2861
2862 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2863 This is for the members text_lines, text_cols, total_lines, total_cols,
2864 where the system imposes an 'int' limit.
2865
2866 * fringe.c (Fdefine_fringe_bitmap):
2867 Don't update size until alloc works.
2868
2869 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2870 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2871
2872 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2873 Check for size-calculation overflow.
2874 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2875 do, as we prefer signed integers.
2876 (id_to_widget.max_size, id_to_widget.used)
2877 (xg_store_widget_in_map, xg_remove_widget_from_map)
2878 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2879 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2880 Use and return ptrdiff_t, not int.
2881 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2882 * gtkutil.h: Change prototypes to match the above.
2883
2884 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2885 are duplicate now that they've been promoted to lisp.h.
2886 (x_allocate_bitmap_record, x_alloc_image_color)
2887 (make_image_cache, cache_image, xpm_load):
2888 Don't update size until alloc is done.
2889 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2890 (x_detect_edges):
3256efce 2891 Check for size calculation overflow.
726e0ab1
PE
2892 (ct_colors_allocated_max): New constant.
2893 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2894 overflow.
3256efce 2895
726e0ab1
PE
2896 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2897 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2898 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2899 Use ptrdiff_t, not int, to count maps.
2900 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2901 calculations. Don't update size until allocation succeeds.
2902 Redo calculations to avoid overflow.
726e0ab1
PE
2903 * keyboard.h: Change prototypes to match the above.
2904
2905 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2906 to count maps.
2907 (current_minor_maps): Check for size calculation overflow.
2908 * keymap.h: Change prototypes to match the above.
2909
2910 * lread.c (read1, init_obarray): Don't update size until alloc done.
2911
2912 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2913 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2914
726e0ab1
PE
2915 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2916 Now ptrdiff_t, not int.
2917 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2918 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2919
2920 * process.c (Fnetwork_interface_list): Check for overflow
2921 in size calculation.
2922
2923 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2924
2925 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2926 overflow. Don't bother calling xmalloc when xrealloc will do.
2927
2928 * search.c (Freplace_match): Check for size calculation overflow.
2929 (Fset_match_data): Don't assume list lengths fit in 'int'.
2930
2931 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2932 for command line length. Do not attempt to address one before the
2933 beginning of an array, as that's not portable.
2934
2935 * term.c (max_frame_lines): Remove; unused.
2936 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2937 not int.
2938 (encode_terminal_code, calculate_costs): Check for size
2939 calculation overflow.
2940 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2941 table lengths and related sizes. Don't update size until alloc
2942 done. Redo calculations to avoid overflow.
2943 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2944
2945 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2946 subtracting pointers.
2947 (gobble_line): Check for overflow more carefully. Don't update size
2948 until alloc done.
2949
2950 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2951 Don't update size until alloc done.
2952 Redo size calculations to avoid overflow.
2953 Check for size calculation overflow.
0065d054 2954 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2955
2956 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2957 Use ptrdiff_t, not int, for sizes.
2958 (store_mode_line_noprop_char): Don't update size until alloc done.
2959
0065d054
PE
2960 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2961 Use ptrdiff_t, not int, for sizes.
2962 (Finternal_make_lisp_face, cache_face):
2963 Check for size calculation overflow.
2964 (cache_face): Treat size calculation overflows as if they were
2965 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2966
2967 * xfns.c (x_encode_text, x_set_name_internal)
2968 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2969 sizes, since they can exceed INT_MAX in size. Check for size
2970 calculation overflow.
2971
0065d054
PE
2972 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2973 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2974 Don't update size until alloc done.
2975
0065d054 2976 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2977 as sprintf is limited to int lengths.
1d526e2f 2978
252c5ee1
PE
2979 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2980 (X_LONG_MIN): New macros.
864d7ce7
PE
2981 Use them to make the following changes clearer.
2982 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2983 This change doesn't affect the value now, but it may help remind
2984 future maintainers not to raise the value too much later.
2985 (SELECTION_QUANTUM): Remove, replacing with ...
2986 (selection_quantum): ... new function, which avoids overflow.
2987 All uses changed.
2988 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2989 assumption that selection length fits in 'int'.
2990 (x_reply_selection_request, x_handle_selection_request)
2991 (x_get_window_property, receive_incremental_selection)
2992 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2993 (lisp_data_to_selection_data, clean_local_selection_data):
2994 Use ptrdiff_t, not int, to record length of selection.
2995 (x_reply_selection_request, x_get_window_property)
2996 (receive_incremental_selection, x_property_data_to_lisp):
2997 Redo calculations to avoid overflow.
2998 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2999 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3000 something.
3001 (x_get_window_property, receive_incremental_selection)
3002 (lisp_data_to_selection_data, x_property_data_to_lisp):
3003 Check for size-calculation overflow.
3004 (x_get_window_property, receive_incremental_selection)
3005 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3006 Don't store size until memory allocation succeeds.
3007 (x_get_window_property): Plug memory leak on memory exhaustion.
3008 Don't double-block input; malloc is safe here. Don't assume 2**34
3009 - 4 fits in unsigned long. Add an xassert to check
3010 XGetWindowProperty overflow. Be more careful about overflow
3011 calculations, and distinguish size from memory overflow better.
3012 (receive_incremental_selection): When tracing, don't assume
3013 unsigned int is less than INT_MAX.
3014 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3015 harmful) conversions of unsigned short to int.
3016 (lisp_data_to_selection_data): Don't assume that integers
3017 in the range -65535 through -1 fit in an X unsigned short.
3018 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3019 result parameters unless successful. Rely on cons_to_unsigned
3020 to report problems with elements; the old code wasn't right anyway.
3021 (x_check_property_data): Check for int overflow; we cannot use
3022 a wider type due to X limits.
3023 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3024
726e0ab1 3025 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3026
0065d054
PE
3027 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3028 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3029 (x_color_cells): Don't store size until memory allocation succeeds.
3030 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3031 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3032 (x_term_init): Don't assume length fits in int (sprintf is limited
3033 to int size).
bc18e09d 3034
ebfa62c0
PE
3035 Use ptrdiff_t for composition IDs.
3036 * character.c (lisp_string_width):
3037 * composite.c (composition_table_size, n_compositions)
3038 (get_composition_id, composition_gstring_from_id):
3039 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3040 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3041 * window.c (Frecenter):
3042 Use ptrdiff_t, not int, for composition IDs.
3043 * composite.c (get_composition_id): Check for integer overflow.
3044 * composite.h: Adjust prototypes to match the above changes.
3045
d3411f89
PE
3046 Use ptrdiff_t for hash table indexes.
3047 * category.c (hash_get_category_set):
3048 * ccl.c (ccl_driver):
3049 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3050 * coding.c (coding_system_charset_list, detect_coding_system):
3051 * coding.h (struct coding_system.id):
3052 * composite.c (get_composition_id, gstring_lookup_cache):
3053 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3054 * image.c (xpm_get_color_table_h):
3055 * lisp.h (hash_lookup, hash_put):
3056 * minibuf.c (Ftest_completion):
3057 Use ptrdiff_t for hash table indexes, not int (which is too
3058 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3059 32-bit --with-wide-int hosts).
3060
e097a6fa
PE
3061 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3062 Add a FIXME comment about memory leaks.
3063 (syms_of_charset): Don't assume xmalloc returns.
3064
5637687f
PE
3065 Don't assume that stated character widths fit in int.
3066 * character.c (Fchar_width, c_string_width, lisp_string_width):
3067 * character.h (CHAR_WIDTH):
3068 * indent.c (MULTIBYTE_BYTES_WIDTH):
3069 Use sanitize_char_width to avoid undefined and/or bad behavior
3070 with outlandish widths.
a66cfb1c 3071 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3072 now that we have two such functions. All uses changed.
3073 (sanitize_char_width): New inline function.
3074
a2271ba2
PE
3075 Don't assume that tab-width fits in int.
3076 * character.h (sanitize_width): New inline function.
3077 (SANE_TAB_WIDTH): New macro.
3078 (ASCII_CHAR_WIDTH): Use it.
3079 * indent.c (sane_tab_width): Remove. All uses replaced by
3080 SANE_TAB_WIDTH (current_buffer).
3081 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3082
18c52557
PE
3083 * fileio.c: Integer overflow issues with file modes.
3084 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3085
caeeedc1
PE
3086 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3087 Remove unreachable code.
3088 (read_hex, load_charset_map_from_file): Check for integer overflow.
3089
6df6ae42 3090 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3091 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3092 (x_send_scroll_bar_event): Likewise. Check that the size does not
3093 exceed limits imposed by XClientMessageEvent, as well as the usual
3094 ptrdiff_t and size_t limits.
3095
b13995db
PE
3096 * keyboard.c: Overflow, signedness and related fixes.
3097 (make_lispy_movement): Use same integer type in forward decl
3098 that is used in the definition.
3099 (read_key_sequence, keyremap_step):
3100 Change bufsize argument back to int, undoing my 2011-03-30 change.
3101 We prefer signed types, and int is wide enough here.
3102 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3103 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3104 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3105 length, not size_t. Use ptrdiff_t for index, not int.
3106 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3107 possibility of integer overflow.
3108
13464394
PE
3109 Overflow, signedness and related fixes for images.
3110
3111 * dispextern.h (struct it.stack[0].u.image.image_id)
3112 (struct_it.image_id, struct image.id, struct image_cache.size)
3113 (struct image_cache.used, struct image_cache.ref_count):
3114 * gtkutil.c (update_frame_tool_bar):
3115 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3116 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3117 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3118 * nsmenu.m (update_frame_tool_bar):
3119 * xdisp.c (calc_pixel_width_or_height):
3120 * xfns.c (image_cache_refcount):
3121 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3122 on typical 64-bit hosts.
3123
3124 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3125 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3126 Omit unnecessary casts to int.
3127 (parse_image_spec): Check that integers fall into 'int' range
3128 when the callers expect that.
3129 (image_ascent): Redo ascent calculation to avoid int overflow.
3130 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3131 (lookup_image): Remove unnecessary tests.
3132 (xbm_image_p): Locals are now of int, not EMACS_INT,
3133 since parse_image_check makes sure they fit into int.
3134 (png_load, gif_load, svg_load_image):
3135 Prefer int to unsigned where either will do.
3136 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3137 old tiff_error_handler and tiff_warning_handler.
3138 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3139 stack buffer overflows. It uses only the features of vsnprintf
3140 that are common to both POSIX and native Microsoft.
3141 (tiff_error_handler, tiff_warning_handler): Use it.
3142 (tiff_load, gif_load, imagemagick_load_image):
3143 Don't assume :index value fits in 'int'.
3144 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3145 (imagemagick_load_image): Check that crop parameters fit into
3146 the integer types that MagickCropImage accepts. Don't assume
3147 Vimagemagick_render_type has a nonnegative value. Don't assume
3148 size_t fits in 'long'.
3149 (gs_load): Use printmax_t to print the widest integers possible.
3150 Check for integer overflow when computing image height and width.
3151
c11821d4
EZ
31522011-08-26 Eli Zaretskii <eliz@gnu.org>
3153
3154 * xdisp.c (redisplay_window): Don't force window start if point
3155 will be invisible in the resulting window. (Bug#9324)
3156
0c95fcf7
EZ
31572011-08-25 Eli Zaretskii <eliz@gnu.org>
3158
3159 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3160 the display spec is of the form `(space ...)'.
3161 (handle_display_spec): Return the value returned by
3162 handle_single_display_spec, not just 1 or zero.
3163 (handle_single_display_spec): If the display spec is of the form
3164 `(space ...)', and specifies display in the text area, return 2
3165 rather than 1.
fee65a97 3166 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3167 accurately, and prefer exact match for point under bidi.
3168 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3169
3170 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3171 into disp_prop; all users changed.
3172
3173 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3174 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3175 for the text covered by the display property.
3176
e4ed06f1
CY
31772011-08-25 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3180 Change return value to nil.
3181 (Frecord_buffer): Delete unused function.
3182
f67cdd7f
EZ
31832011-08-24 Eli Zaretskii <eliz@gnu.org>
3184
5980d4c6
EZ
3185 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3186 buffers, return left-to-right.
8610fe8b
EZ
3187 (set_cursor_from_row): Consider candidate row a win if its glyph
3188 represents a newline and point is on that newline. Fixes cursor
3189 positioning on the newline at EOL of R2L text within L2R
3190 paragraph, and vice versa.
3191 (try_cursor_movement): Check continued rows, in addition to
3192 continuation rows. Fixes unwarranted scroll when point enters a
3193 continued line of R2L text within an L2R paragraph, or vice versa.
3194 (cursor_row_p): Consider the case of point being equal to
3195 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3196 from the end of a short line to the beginning of a continued line
3197 of R2L text within L2R paragraph.
3198 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3199 composed characters.
5980d4c6 3200
f67cdd7f
EZ
3201 * bidi.c (bidi_check_type): Use xassert.
3202 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3203 members.
3204
bca633fb
EZ
32052011-08-23 Eli Zaretskii <eliz@gnu.org>
3206
3207 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3208 a character.
3209
4a5885a7
CY
32102011-08-23 Chong Yidong <cyd@stupidchicken.com>
3211
3212 * nsfont.m (ns_otf_to_script): Fix typo.
3213
0902a04e
KH
32142011-08-22 Kenichi Handa <handa@m17n.org>
3215
3216 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3217 extra slot even if the purpose is char-code-property-table.
3218
1a2e6670
EZ
32192011-08-23 Eli Zaretskii <eliz@gnu.org>
3220
8ddde651
EZ
3221 * xdisp.c (redisplay_window): When computing centering_position,
3222 account for the height of the header line. (Bug#8874)
3223
425cc014
EZ
3224 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3225 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3226 candidate is selected by the mouse, and that candidate has a
3227 composed character under the mouse.
3228
1a2e6670
EZ
3229 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3230 coordinates reported by pos-visible-in-window-p for a composed
3231 character in column zero.
3232
8b76d6f8
SM
32332011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3234
3235 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3236
dac347dd
EZ
32372011-08-22 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3240 consider it a hit if to_charpos is anywhere in the range of the
3241 composed buffer positions.
3242
e013fb34
CY
32432011-08-22 Chong Yidong <cyd@stupidchicken.com>
3244
3245 * image.c (gif_load): Don't assume that each subimage has the same
3246 dimensions as the base image. Handle disposal method that is
3247 "undefined" by the gif spec (Bug#9335).
3248
bd1ba3e8
CY
32492011-08-20 Chong Yidong <cyd@stupidchicken.com>
3250
3251 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3252 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3253
54a1215b
EZ
32542011-08-19 Eli Zaretskii <eliz@gnu.org>
3255
823564e5
EZ
3256 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3257 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3258 from an Org mode buffer to a Speedbar frame.
3259
54a1215b
EZ
3260 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3261 a composition, take its buffer position from IT->cmp_it.charpos.
3262 Fixes cursor positioning at the beginning of a line that begins
3263 with a composed character.
3264
9778ebcc
EZ
32652011-08-18 Eli Zaretskii <eliz@gnu.org>
3266
0be6ee06
EZ
3267 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3268 character bidirectional type, use STRONG_L instead. Fixes crashes
3269 in a buffer produced by `describe-categories'.
3270
9778ebcc
EZ
3271 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3272 members before the level stack, so they would be saved and
3273 restored when copying iterator state. Fixes incorrect reordering
3274 around TABs covered by display properties.
3275
156bffbe
AS
32762011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3277
6b02f655 3278 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3279
72ad093b
CY
32802011-08-17 Chong Yidong <cyd@stupidchicken.com>
3281
3282 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3283 (internal_condition_case_2, internal_condition_case_n):
3284 Remove unnecessary aborts (Bug#9081).
72ad093b 3285
35774242
EZ
32862011-08-17 Eli Zaretskii <eliz@gnu.org>
3287
3288 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3289 has no `load' handler, try opening the file locally. (Bug#9311)
3290
db76dd85
KB
32912011-08-16 Ken Brown <kbrown@cornell.edu>
3292
3293 * gmalloc.c: Expand comment.
3294
b215eee5
EZ
32952011-08-16 Eli Zaretskii <eliz@gnu.org>
3296
3297 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3298 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3299
a4579d33
KB
33002011-08-16 Ken Brown <kbrown@cornell.edu>
3301
3302 Fix memory allocation problems in Cygwin build (Bug#9273).
3303
3304 * unexcw.c ( __malloc_initialized): Declare external variable.
3305 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3306
8b76d6f8
SM
3307 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3308 New variables.
a4579d33
KB
3309 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3310 dumped emacs.
3311 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3312 in the static heap.
3313 [CYGWIN] (special_realloc): New function.
3314 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3315 requests to realloc storage in the static heap.
3316
3ebec551
PE
33172011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 * bidi.c (bidi_initialize): Remove unused local.
3320
9fd8be00
EZ
33212011-08-15 Eli Zaretskii <eliz@gnu.org>
3322
6b02f655
SM
3323 * bidimirror.h:
3324 * biditype.h: Remove file.
3325 * makefile.w32-in ($(BLD)/bidi.$(O)):
3326 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3327
3328 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3329
3330 * chartab.c: Improve commentary for the uniprop_table API.
3331
32413314
EZ
3332 * bidi.c (bidi_paragraph_init): Support zero value of
3333 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3334 (bidi_initialize): Use uniprop_table instead of including
3335 biditype.h and bidimirror.h.
32413314 3336
9fd8be00
EZ
3337 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3338 coordinates of the iterator when restoring from ppos_it.
3339 (Bug#9296)
3340
5cf2b69b
KH
33412011-08-14 Kenichi Handa <handa@m17n.org>
3342
3343 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3344 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3345
daf17d00
EZ
33462011-08-14 Eli Zaretskii <eliz@gnu.org>
3347
3348 * xdisp.c (move_it_in_display_line_to): Don't invoke
3349 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3350 ppos_it. Fixes vertical cursor motion when line beginning is
3351 covered by an image. (Bug#9296)
3352
08e3161a
JD
33532011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3354
3355 * nsterm.h (ns_run_ascript): Declare.
3356 (NSAPP_DATA2_RUNASSCRIPT): Define.
3357
3358 * nsfns.m (as_script, as_result, as_status): New static variables.
3359 (ns_run_ascript): New function.
5e617bc2 3360 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3361 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3362 the event loop. Get status from as_status (Bug#7276).
3363
3364 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3365 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3366 the event loop (Bug#7276).
3367
a3720aa2
AS
33682011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3369
3370 * gnutls.c (QCgnutls_bootprop_priority)
3371 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3372 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3373 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3374 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3375 (QCgnutls_bootprop_verify_hostname_error)
3376 (QCgnutls_bootprop_callbacks_verify): Rename from
3377 Qgnutls_bootprop_..., all uses changed.
3378
3379 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3380 uses changed.
3381
0a0d27fb
PE
33822011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3383
19d5c50c
PE
3384 * xfaces.c (Qframe_set_background_mode): Now static.
3385 * dispextern.h (Qframe_set_background_mode): Remove decl.
3386
0a0d27fb
PE
3387 * process.c (Fnetwork_interface_info): Declare local only if needed.
3388
377538cb
JD
33892011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3390
3391 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3392 (Fnetwork_interface_list): Allocate in increments of bytes instead
3393 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3394 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3395 sockaddr.
3396 (struct ifflag_def): notrailers is smart on OSX.
3397 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3398 Get hardware address with getifaddrs if available.
3399
08fff70c
EZ
34002011-08-12 Eli Zaretskii <eliz@gnu.org>
3401
3402 * xdisp.c (iterate_out_of_display_property): xassert that
3403 IT->position is set to within IT->object's boundaries. Break from
3404 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3405 when IT->position is set up wrongly due to some bug.
3406 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3407 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3408 entry. Force push_it to save on the stack the current
3409 buffer/string position, to be restored by pop_it. Fix flags in
3410 the iterator structure wrt the object coming from a display
3411 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3412 properties. (Bug#9284)
3413
7be1c708 34142011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3415
7be1c708
CY
3416 * fontset.c (fontset_get_font_group): Add proper type checks.
3417 (Bug#9172)
aac0c6e3 3418
7be1c708 34192011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3420
7be1c708
CY
3421 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3422 and LC_VERSION_MIN_MACOSX.
3423 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3424 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3425
97bb72a6
EZ
34262011-08-08 Eli Zaretskii <eliz@gnu.org>
3427
3428 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3429 no-display-properties-and-no-overlays under bidi display.
3430 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3431 properties and overlays.
97bb72a6 3432
d5617611
CY
34332011-08-08 Chong Yidong <cyd@stupidchicken.com>
3434
37e11a63
CY
3435 * editfns.c (Fset_time_zone_rule): Document relationship with the
3436 setenv function.
3437
d5617611
CY
3438 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3439 the font entity extracted from the cache (Bug#8109).
3440
58872834
CY
34412011-08-07 Chong Yidong <cyd@stupidchicken.com>
3442
3443 * composite.c (autocmp_chars): Don't reset point. That is done by
3444 restore_point_unwind (Bug#5984).
3445
75bfc667
JL
34462011-08-07 Juri Linkov <juri@jurta.org>
3447
3448 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3449 to show the arg `TIME' instead of `TIMEVAL'.
3450
d1410150
EZ
34512011-08-06 Eli Zaretskii <eliz@gnu.org>
3452
3453 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3454 display property strides EOL and includes a newline, as in
3455 longlines-mode. (Bug#9254)
75b771e4
EZ
3456 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3457 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3458
3459 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3460 is non-zero, even if the data buffer is NULL. Fixes a crash in
3461 vertical-motion with longlines-mode. (Bug#9254)
3462
35928349
EZ
34632011-08-05 Eli Zaretskii <eliz@gnu.org>
3464
ec7cc85b
EZ
3465 * bidi.c <bidi_cache_total_alloc>: Now static.
3466 (bidi_initialize): Initialize bidi_cache_total_alloc.
3467
8b76d6f8 3468 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3469 cache. (Bug#9221)
3470
3471 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3472 amount allocated this far in `bidi_cache_total_alloc'.
3473 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3474 non-zero, only free the data buffer without restoring the cache
3475 contents. All callers changed.
3476
3477 * dispextern.h (bidi_unshelve_cache): Update prototype.
3478
3479 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3480 (move_it_in_display_line, move_it_to)
3481 (move_it_vertically_backward, move_it_by_lines): Replace the call
3482 to xfree to an equivalent call to bidi_unshelve_cache.
3483 (move_it_in_display_line_to): Fix logic of returning
412b6358 3484 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3485
e2e2423b
EZ
34862011-08-05 Eli Zaretskii <eliz@gnu.org>
3487
3488 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3489 came from a string character with a `cursor' property. (Bug#9229)
3490
ae9e757a
JD
34912011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3492
3493 * Makefile.in (LIB_PTHREAD): New variable.
3494 (LIBES): Add LIB_PTHREAD (Bug#9216).
3495
3496 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3497 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3498
213bd7f2
AS
34992011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3500
6b02f655 3501 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3502
99aaf75f
JD
35032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3504
3505 * xterm.c (x_find_topmost_parent): New function.
3506 (x_set_frame_alpha): Find topmost parent window with
3507 x_find_topmost_parent and set the property there also (bug#9181).
3508 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3509
c74e9d86
PE
35102011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3511
3512 * callproc.c (Fcall_process): Avoid vfork clobbering
3513 the local vars buffer, coding_systems, current_dir.
3514
640c8776
SM
35152011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3516
3517 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3518
f26d0e4c
PE
35192011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3520
8a10d76c
PE
3521 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3522 so that it is not optimized away.
3523
f26d0e4c
PE
3524 * xdisp.c (compute_display_string_pos): Remove unused local.
3525
55439c61
EZ
35262011-08-02 Eli Zaretskii <eliz@gnu.org>
3527
3528 Fix slow cursor motion and scrolling in large buffers with
3529 selective display, like Org Mode buffers. (Bug#9218)
3530
3531 * dispextern.h (struct bidi_it): New member disp_prop_p.
3532
3533 * xdisp.c: Remove one-slot cache of display string positions.
3534 (compute_display_string_pos): Accept an additional argument
5e617bc2 3535 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3536 for a display string or property. If found, set DISP_PROP_P
3537 non-zero.
3538
3539 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3540 DISP_PROP_P, and pass it to compute_display_string_pos.
3541 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3542 non-zero. All callers of bidi_fetch_char changed.
3543
fb33fa43
SM
35442011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3545
3546 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3547
b099e063
DM
35482010-12-03 Don March <don@ohspite.net>
3549
3550 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3551 last character M-[char] is translated to ESC [char] (bug#7541).
3552
5cc7f7af
KH
35532011-08-02 Kenichi Handa <handa@m17n.org>
3554
d0fffa3f 3555 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3556
3557 * chartab.c (uniprop_table): Make it non-static.
3558
525d5e6e
EZ
35592011-08-01 Eli Zaretskii <eliz@gnu.org>
3560
3561 * xdisp.c (forward_to_next_line_start): Accept additional argument
3562 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3563 on the newline.
3564 (reseat_at_next_visible_line_start): Use the bidi iterator state
3565 returned by forward_to_next_line_start to restore the state of
3566 it->bidi_it after backing up to previous newline. (Bug#9212)
3567
31011111
AS
35682011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3569
3570 * regex.c (re_comp): Protoize.
3571 (re_exec): Fix return type.
3572 (regexec): Fix type of `ret'. (Bug#9203)
3573
476371c4
PE
35742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3575
e5d76069
PE
3576 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3577 This is needed if max-image-size is a floating-point number.
3578
9a79b20c
AS
35792011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3580
3581 * print.c (print_object): Print empty symbol as ##.
3582
3583 * lread.c (read1): Read ## as empty symbol.
3584
d8c2fa78
AA
35852011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3586
3587 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3588 setting frame foreground color (Bug#9175).
3589 (x_set_background_color): Likewise.
3590
ffe57a7a
AA
3591 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3592 contents (Bug#9176).
3593 (EmacsTooltip -init): Remove bezels and add shadows to
3594 tooltip windows.
3595
bf3492a5
AA
3596 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3597 or scroll bar (Bug#8470).
3598
d55e9c53
AA
3599 * nsfont.m (nsfont_open): Remove assignment to voffset and
3600 unnecessary vars hshink, expand, hd, full_height, min_height.
3601 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3602
3603 * nsterm.h (nsfont_info): Remove voffset field.
3604
d8c2fa78 36052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3606
3607 Implement strike-through and overline on NextStep (Bug#8863).
3608
3609 * nsfont.m (nsfont_open): Use underline position provided by font,
3610 instead of hard-coded value of 2.
3611 (nsfont_draw): Call ns_draw_text_decoration instead.
3612
3613 * nsterm.h: Add declaration for ns_draw_text_decoration.
3614
3615 * nsterm.m (ns_draw_text_decoration): New function for drawing
3616 underline, overline, and strike-through.
3617 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3618 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3619 accommodate underlining, etc.
4843aac3 3620
4cc60b9b
EZ
36212011-07-28 Eli Zaretskii <eliz@gnu.org>
3622
bc7ece87
EZ
3623 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3624 default.
4cc60b9b 3625
476371c4
PE
36262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3627
66606eea
PE
3628 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3629 Without this fix, if a signal arrives just after memory fills up,
3630 'malloc' might be invoked reentrantly.
3631
476371c4
PE
3632 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3633 In other words, assume that every image size is allowed, on non-X
3634 hosts. This assumption is probably wrong, but it lets Emacs compile.
3635
f3fcc40d
AS
36362011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3637
3638 * regex.c (re_iswctype): Convert return values to boolean.
3639
350c992f
EZ
36402011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3641
3642 * xdisp.c (compute_display_string_pos): Don't use cached display
3643 string position if the buffer had its restriction changed.
3644 (Bug#9184)
3645
5266b4bb
PE
36462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3649
2573a837 36502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3651
41f55ccd 3652 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3653
39e378da
PE
3654 * bidi.c: Integer size and overflow fixes.
3655 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3656 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3657 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3658 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3659 (bidi_find_other_level_edge):
3660 Use ptrdiff_t instead of EMACS_INT where either will do.
3661 This works better on 32-bit hosts configured --with-wide-int.
3662 (bidi_cache_ensure_space): Check for size-calculation overflow.
3663 Use % rather than repeated addition, for better worst-case speed.
3664 Don't set bidi_cache_size until after xrealloc returns, because it
3665 might not return.
3666 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3667 (bidi_cache_ensure_space): Also check that the bidi cache size
3668 does not exceed that of the largest Lisp string or buffer. See Eli
3669 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3670
5e927815
PE
3671 * alloc.c (__malloc_size_t): Remove.
3672 All uses replaced by size_t. See Andreas Schwab's note
3673 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3674
ca4aa935
PE
3675 * image.c: Improve checking for integer overflow.
3676 (check_image_size): Assume that f is nonnull, since
3677 it is always nonnull in practice. This is one less thing to
3678 worry about when checking for integer overflow later.
3679 (x_check_image_size): New function, which checks for integer
3680 overflow issues inside X.
3681 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3682 This removes the need for a memory_full check.
3683 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3684 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3685 (xbm_read_bitmap_data): Change locals back to 'int', since
3686 their values must fit in 'int'.
3687 (xpm_load_image, png_load, tiff_load):
3688 Invoke x_create_x_image_and_pixmap earlier,
3689 to avoid much needless work if the image is too large.
3690 (tiff_load): Treat overly large images as if
3691 x_create_x_image_and_pixmap failed, not as malloc failures.
3692 (gs_load): Use x_check_image_size.
3693
5f8f9cc2
PE
3694 * gtkutil.c: Omit integer casts.
3695 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3696 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3697
5adf60bc
PE
3698 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3699
c8907a93
PE
3700 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3701 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3702 would wrongly return t on a 64-bit host.
3703
e3c25c68
PE
3704 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3705 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3706 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3707 and therefore cause GCC to emit a bogus diagnostic in some cases.
3708
3f791afe
PE
3709 * image.c: Integer signedness and overflow and related fixes.
3710 This is not an exhaustive set of fixes, but it's time to
3711 record what I've got.
3712 (lookup_pixel_color, check_image_size): Remove redundant decls.
3713 (check_image_size): Don't assume that arbitrary EMACS_INT values
3714 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3715 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3716 (tiff_load, imagemagick_load_image):
3717 Check for overflow in size calculations.
3718 (x_create_x_image_and_pixmap): Remove unnecessary test for
3719 xmalloc returning NULL; that can't happen.
3720 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3721 (xpm_color_bucket): Use better integer hashing function.
3722 (xpm_cache_color): Don't possibly over-allocate memory.
3723 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3724 (gif_memory_source):
3725 Use ptrdiff_t, not int or size_t, to record sizes.
3726 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3727 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3728 either works, as we prefer signed integers.
3729 (tiff_read_from_memory, tiff_write_from_memory):
3730 Return tsize_t, not size_t, since that's what the TIFF API wants.
3731 (tiff_read_from_memory): Don't fail simply because the read would
3732 go past EOF; instead, return a short read.
3733 (tiff_load): Omit no-longer-needed casts.
3734 (Fimagemagick_types): Don't assume size fits into 'int'.
3735
3cc5a532
PE
3736 Improve hashing quality when configured --with-wide-int.
3737 * fns.c (hash_string): New function, taken from sxhash_string.
3738 Do not discard information about ASCII character case; this
3739 discarding is no longer needed.
3740 (sxhash-string): Use it. Change sig to match it. Caller changed.
3741 * lisp.h: Declare it.
3742 * lread.c (hash_string): Remove, since we now use fns.c's version.
3743 The fns.c version returns a wider integer if --with-wide-int is
3744 specified, so this should help the quality of the hashing a bit.
3745
b312a492
PE
3746 * emacs.c: Integer overflow minor fix.
3747 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3748 Define only if GNU_LINUX.
3749 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3750
dfd153ae
PE
3751 * dispnew.c: Integer signedness and overflow fixes.
3752 Remove unnecessary forward decls, that were a maintenance hassle.
3753 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3754 All uses changed.
3755 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3756 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3757 (prepare_desired_row, line_draw_cost):
3758 Use int, not unsigned, where either works.
3759 (save_current_matrix, restore_current_matrix):
3760 Use ptrdiff_t, not size_t, where either works.
3761 (init_display): Check for overflow more accurately, and without
3762 relying on undefined behavior.
3763
a81d11a3
PE
3764 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3765 Remove, replacing with the new symbols in lisp.h. All uses changed.
3766 * fileio.c (make_temp_name):
3767 * filelock.c (lock_file_1, lock_file):
3768 * xdisp.c (message_dolog):
3769 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3770 Use pMd etc. instead.
3771 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3772 replacing the pWIDE etc. symbols removed from editfns.c.
3773
3300e6fd
PE
3774 * keyboard.h (num_input_events): Now uintmax_t.
3775 This is (very slightly) less likely to mess up due to wraparound.
3776 All uses changed.
3777
fd05c7e9
PE
3778 * buffer.c: Integer signedness fixes.
3779 (alloc_buffer_text, enlarge_buffer_text):
3780 Use ptrdiff_t rather than size_t when either will do, as we prefer
3781 signed integers.
3782
903fe15d
PE
3783 * alloc.c: Integer signedness and overflow fixes.
3784 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3785 (__malloc_size_t): Default to size_t, not to int.
3786 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3787 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3788 Prefer ptrdiff_t to size_t when either would do, as we prefer
3789 signed integers.
3790 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3791 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3792 Now const. Initialize with values that are in range even if char
3793 is signed.
3794 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3795 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3796 These functions do the right thing with sizes > 2**32.
3797 (check_depth): Now ptrdiff_t, not int.
3798 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3799 Adjust to new way of storing sizes. Check for size overflow bugs
3800 in rest of code.
3801 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3802 slightly wrong anyway, as it missed one instance of
3803 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3804 (refill_memory_reserve): Omit needless cast to size_t.
3805 (mark_object_loop_halt): Mark as externally visible.
3806
ac82cc6a
PE
3807 * xselect.c: Integer signedness and overflow fixes.
3808 (Fx_register_dnd_atom, x_handle_dnd_message):
3809 Use ptrdiff_t, not size_t, since we prefer signed.
3810 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3811 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3812 x_dnd_atoms_size and x_dnd_atoms_length.
3813
c2d1e36d
PE
3814 * doprnt.c: Prefer signed to unsigned when either works.
3815 * eval.c (verror):
3816 * doprnt.c (doprnt):
3817 * lisp.h (doprnt):
3818 * xdisp.c (vmessage):
3819 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3820 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3821 prefer signed arithmetic to avoid comparison confusion.
3822 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3823 but is a bit tricky.
3824
0e926e56
PE
3825 Assume freestanding C89 headers, string.h, stdlib.h.
3826 * data.c, doprnt.c, floatfns.c, print.c:
3827 Include float.h unconditionally.
3828 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3829 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3830 * regex.c: Likewise for stddef.h, string.h.
3831 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3832 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3833 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3834 (STDC_HEADERS): Remove obsolete defines.
3835 * sysdep.c: Include limits.h unconditionally.
3836
9cfdb3ec
PE
3837 Assume support for memcmp, memcpy, memmove, memset.
3838 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3839 * regex.c (memcmp, memcpy):
3840 Remove; we assume C89 now.
3841
3842 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3843 (__malloc_safe_bcopy): Remove; no longer needed.
3844
cf950e6b 3845 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3846 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3847 well either way, and we prefer signed to unsigned.
3848
dbf38e02
LMI
38492011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3850
3851 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3852 closes the connection while we're reading (bug#9182).
3853
d6f0886c 38542011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3855
d6f0886c
JD
3856 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3857 are specified (Bug#9168).
24e0f6b1 3858
2eb1f9e6
PE
38592011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3860
3861 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3862 Found by GCC static checking and --with-wide-int on a 32-bit host.
3863
22381272 38642011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3865
3866 * xdisp.c (compute_display_string_pos): Fix logic of caching
3867 previous display string position. Initialize cached_prev_pos to
3868 -1. Fixes slow-down at the beginning of a buffer.
3869
f25e39b4
EZ
38702011-07-24 Eli Zaretskii <eliz@gnu.org>
3871
3872 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3873 for attrs[LFACE_FONTSET_INDEX].
3874
04c4b52e
PE
38752011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 * xml.c (parse_region): Remove unused local
3878 that was recently introduced.
3879
c1734fbd
EZ
38802011-07-23 Eli Zaretskii <eliz@gnu.org>
3881
be18c5a5
EZ
3882 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3883 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3884
c1734fbd
EZ
3885 * xdisp.c (move_it_in_display_line_to): Record the best matching
3886 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3887 exit if none of the characters scanned was an exact match.
3888 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3889 when exact match is impossible due to invisible text, and the
3890 lines are truncated.
3891
a258d627
JD
38922011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3893
3894 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3895 for OSX >= 10.7.
3896
b6d5a689
EZ
38972011-07-22 Eli Zaretskii <eliz@gnu.org>
3898
0f74f785
EZ
3899 Fix a significant slow-down of cursor motion with C-n, C-p,
3900 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3901 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3902 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3903 (next_element_from_buffer): Call compute_stop_pos_backwards to
3904 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3905 base_level_stop.
3906 (reseat): Don't look for prev_stop, as that could mean a very long
3907 run.
3908 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3909 <cached_disp_overlay_modiff>: Cache for last found display string
3910 position.
551918c1 3911 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3912 about the same buffer in the same area of character positions, and
3913 the buffer wasn't changed since the time the display string
3914 position was cached.
551918c1 3915
b2d0c91a
EZ
39162011-07-22 Eli Zaretskii <eliz@gnu.org>
3917
3918 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3919 is an integer, which is important for empty lines. (Bug#9149)
3920
043604ee
CY
39212011-07-22 Chong Yidong <cyd@stupidchicken.com>
3922
3923 * frame.c (Fmodify_frame_parameters): In tty case, update the
3924 default face if necessary (Bug#4238).
3925
da4adb04
CY
39262011-07-21 Chong Yidong <cyd@stupidchicken.com>
3927
3928 * editfns.c (Fstring_to_char): No need to explain what a character
3929 is in the docstring (Bug#6576).
3930
9abd0532
LMI
39312011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3932
3933 * xml.c (parse_region): Make sure we always return a tree.
3934
36881d16
HK
39352011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3936
3937 * xml.c (parse_region): If a document contains only comments,
3938 return that, too.
3939
1e98674d
LMI
39402011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3941
3942 * xml.c (make_dom): Return comments, too.
3943
590bd467
PE
39442011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 Port to OpenBSD.
3947 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3948 and the surrounding thread.
3949 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3950 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3951 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3952 timer goes off.
3953 * s/openbsd.h (BROKEN_SIGIO): Define.
3954 * unexelf.c (unexec) [__OpenBSD__]:
3955 Don't update the .mdebug section of the Alpha COFF symbol table.
3956
f41628b2
LMI
39572011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3958
3959 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3960 (bug#8460).
3961
b59b67c5
PE
39622011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3963
15e3a074
PE
3964 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3965 This fixes some race conditions on the permissions of any newly
3966 created file.
3967
41bed37d
PE
3968 * alloc.c (valid_pointer_p): Use pipe, not open.
3969 This fixes some permissions issues when debugging.
3970
b59b67c5
PE
3971 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3972 If fchown fails to set both uid and gid, try to set just gid,
3973 as that is sometimes allowed. Adjust the file's mode to eliminate
3974 setuid or setgid bits that are inappropriate if fchown fails.
3975
925a6be7
SM
39762011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3977
3978 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3979 to compare Lisp_Objects.
3980 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3981 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3982 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3983
52968808
AS
39842011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3985
0a6a104b
AS
3986 * lread.c (read_integer): Unread even EOF character.
3987 (read1): Likewise. Properly record start position of symbol.
3988
52968808
AS
3989 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3990 symbol character follows.
3991
9e381cdd
PE
39922011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3993
3994 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3995 This works around a problem with the previous change to Fcopy_file.
3996 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3997 and without this change, GCC might complain about discarding
3998 fchown's return value.
3999
b5641435
JB
40002011-07-16 Juanma Barranquero <lekktu@gmail.com>
4001
4002 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4003
a8031457
PE
40042011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4005
4006 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4007
dd889327
LMI
40082011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4009
750c33f7
LMI
4010 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4011 it's used from the C level.
4012
dd889327
LMI
4013 * process.c: Use the same condition for POLL_FOR_INPUT in both
4014 keyboard.c and process.c (bug#1858).
4015
87e86684
LM
40162011-07-09 Lawrence Mitchell <wence@gmx.li>
4017
4018 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4019 (Fgnutls_boot): Use it.
4020
64348f40
AS
40212011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4022
4023 * doc.c (Fsubstitute_command_keys): Revert last change.
4024
1d698799
LMI
40252011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4026
f863868c
LMI
4027 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4028 quotes the next character, and doesn't affect other longer
4029 sequences (bug#8935).
4030
1d698799
LMI
4031 * lread.c (syms_of_lread): Clarify that is isn't only
4032 `eval-buffer' and `eval-defun' that's affected by
4033 `lexical-binding' (bug#8460).
4034
aa4b6df6
EZ
40352011-07-15 Eli Zaretskii <eliz@gnu.org>
4036
4037 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4038 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4039
5d856da6
PE
40402011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4041
ad6042bb
PE
4042 Fix minor problems found by static checking.
4043 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4044 (elsz): Now a signed constant, not a size_t var. We prefer signed
4045 types to unsigned, to avoid integer comparison confusion. Without
4046 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4047 "cannot optimize loop, the loop counter may overflow", a symptom
4048 of the confusion.
f00bbb22 4049 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4050 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4051
6468f31c
LMI
40522011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4053
49080b10
LMI
4054 * search.c (Fre_search_backward): Mention `case-fold-search' in
4055 all the re_search_* functions (bug#8138).
4056
6468f31c
LMI
4057 * keyboard.c (Fopen_dribble_file): Document when the file is
4058 closed (bug#8056).
4059
c965adc5
EZ
40602011-07-14 Eli Zaretskii <eliz@gnu.org>
4061
df9733bf
EZ
4062 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4063 bidi_cache_idx.
4064
0bb23927
EZ
4065 Support bidi reordering of display and overlay strings.
4066 * xdisp.c (compute_display_string_pos)
4067 (compute_display_string_end): Accept additional argument STRING.
4068 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4069 (reseat_to_string): Initialize bidi_it->string.s and
4070 bidi_it->string.schars.
4071 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4072 NULL (avoids a crash in bidi_paragraph_init).
4073 Initialize itb.string.lstring.
0bb23927
EZ
4074 (init_iterator): Call bidi_init_it only of a valid
4075 buffer position was specified. Initialize paragraph_embedding to
4076 L2R.
4077 (reseat_to_string): Initialize the bidi iterator.
4078 (display_string): If we need to ignore text properties of
4079 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4080 original value of -1 will not work with bidi.)
4081 (compute_display_string_pos): First arg is now struct
4082 `text_pos *'; all callers changed. Support display properties on
4083 Lisp strings.
4084 (compute_display_string_end): Support display properties on Lisp
4085 strings.
4086 (init_iterator, reseat_1, reseat_to_string): Initialize the
4087 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4088 when iterating on a string not from display properties).
640c8776
SM
4089 (compute_display_string_pos, compute_display_string_end):
4090 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4091 arrow keys.
4092 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4093 base_level_stop; instead, set base_level_stop to BEGV.
4094 Fixes crashes in vertical-motion.
0bb23927
EZ
4095 (next_element_from_buffer): Improve commentary for when
4096 the iterator is before prev_stop.
4097 (init_iterator): Initialize bidi_p from the default value of
4098 bidi-display-reordering, not from buffer-local value. Use the
4099 buffer-local value only if initializing for buffer iteration.
4100 (handle_invisible_prop): Support invisible properties on strings
4101 that are being bidi-reordered.
4102 (set_iterator_to_next): Support bidi reordering of C strings and
4103 Lisp strings.
4104 (next_element_from_string): Support bidi reordering of Lisp
4105 strings.
4106 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4107 (display_string): Support display of R2L glyph rows.
4108 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4109 (init_iterator): Don't initialize it->bidi_p for strings
4110 here.
4111 (reseat_to_string): Initialize it->bidi_p for strings here.
4112 (next_element_from_string, next_element_from_c_string)
4113 (next_element_from_buffer): Add xassert's for correspondence
4114 between IT's object being iterated and it->bidi_it.string
4115 structure.
4116 (face_before_or_after_it_pos): Support bidi iteration.
4117 (next_element_from_c_string): Handle the case of the first string
4118 character that is not the first one in the visual order.
4119 (get_visually_first_element): New function, refactored from common
4120 parts of next_element_from_buffer, next_element_from_string, and
4121 next_element_from_c_string.
4122 (tool_bar_lines_needed, redisplay_tool_bar)
4123 (display_menu_bar): Force left-to-right direction. Add a FIXME
4124 comment for making that be controlled by a user option.
4125 (push_it, pop_it): Save and restore the state of the
4126 bidi iterator. Save and restore the bidi_p flag.
4127 (pop_it): Iterate out of display property for string iteration as
4128 well.
4129 (iterate_out_of_display_property): Support iteration over strings.
4130 (handle_single_display_spec): Set up it->bidi_it for iteration
4131 over a display string, and call bidi_init_it.
4132 (handle_single_display_spec, next_overlay_string)
4133 (get_overlay_strings_1, push_display_prop): Set up the bidi
4134 iterator for displaying display or overlay strings.
4135 (forward_to_next_line_start): Don't use the shortcut if
4136 bidi-iterating.
4137 (back_to_previous_visible_line_start): If handle_display_prop
4138 pushed the iterator stack, restore the internal state of the bidi
4139 iterator by calling bidi_pop_it same number of times.
4140 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4141 and we are bidi-iterating, don't decrement the iterator position;
4142 instead, set the first_elt flag in the bidi iterator, to produce
4143 the same effect.
4144 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4145 (push_display_prop): xassert that we are iterating a buffer.
4146 (push_it, pop_it): Save and restore paragraph_embedding member.
4147 (handle_single_display_spec, next_overlay_string)
4148 (get_overlay_strings_1, reseat_1, reseat_to_string)
4149 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4150 correctly. Don't assume unibyte strings are not bidi-reordered.
4151 (compute_display_string_pos)
4152 (compute_display_string_end): Fix handling the case of C string.
4153 (push_it, pop_it): Save and restore from_disp_prop_p.
4154 (handle_single_display_spec, push_display_prop): Set the
4155 from_disp_prop_p flag.
4156 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4157 (pop_it): Call iterate_out_of_display_property only if we are
4158 popping after iteration over a string that came from a display
4159 property. Fix a typo in popping stretch info. Add an assertion
4160 for verifying that the iterator position is in sync with the bidi
4161 iterator.
4162 (handle_single_display_spec, get_overlay_strings_1)
4163 (push_display_prop): Fix initialization of paragraph direction for
4164 string when that of the parent object is not yet determined.
4165 (reseat_1): Call bidi_init_it to resync the bidi
4166 iterator with IT's position. (Bug#7616)
4167 (find_row_edges): If ROW->start.pos gives position
4168 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4169 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4170 Reset the from_disp_prop_p flag.
4171 (SAVE_IT, RESTORE_IT): New macros.
4172 (pos_visible_p, face_before_or_after_it_pos)
4173 (back_to_previous_visible_line_start)
4174 (move_it_in_display_line_to, move_it_in_display_line)
4175 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4176 (try_scrolling, redisplay_window, display_line): Use them when
4177 saving a temporary copy of the iterator and restoring it back.
4178 (back_to_previous_visible_line_start, reseat_1)
4179 (init_iterator): Empty the bidi cache "stack".
4180 (move_it_in_display_line_to): If iterator ended up at
4181 EOL, but we never saw any buffer positions smaller than
4182 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4183 motion in bidi-reordered lines.
4184 (move_it_in_display_line_to): Record prev_method and prev_pos
4185 immediately before the call to set_iterator_to_next. Fixes cursor
4186 motion in bidi-reordered lines with stretch glyphs and strings
4187 displayed in margins. (Bug#8133) (Bug#8867)
4188 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4189 TO_CHARPOS.
640c8776
SM
4190 (pos_visible_p): Support positions in bidi-reordered lines.
4191 Save and restore bidi cache.
0bb23927
EZ
4192
4193 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4194 (bidi_paragraph_info): Delete unused struct.
4195 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4196 (bidi_cache_start): New variable.
4197 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4198 to zero.
4199 (bidi_cache_fetch_state, bidi_cache_search)
4200 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4201 (bidi_cache_find, bidi_peek_at_next_level)
4202 (bidi_level_of_next_char, bidi_find_other_level_edge)
4203 (bidi_move_to_visually_next): Compare cache index with
4204 bidi_cache_start rather than with zero.
4205 (bidi_fetch_char): Accept new argument STRING; all callers
4206 changed. Support iteration over a string. Support strings with
4207 display properties. Support unibyte strings. Fix the type of
4208 `len' according to what STRING_CHAR_AND_LENGTH expects.
4209 (bidi_paragraph_init, bidi_resolve_explicit_1)
4210 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4211 (bidi_level_of_next_char, bidi_move_to_visually_next):
4212 Support iteration over a string.
0bb23927
EZ
4213 (bidi_set_sor_type, bidi_resolve_explicit_1)
4214 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4215 can now be zero (for strings); special values 0 and -1 were
4216 changed to -1 and -2, respectively.
4217 (bidi_char_at_pos): New function.
4218 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4219 Call it instead of FETCH_MULTIBYTE_CHAR.
4220 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4221 initialized to valid values.
4222 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4223 values.
4224 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4225 the test for valid cached positions. Fix the logic for looking up
4226 the sentinel state in the cache. GCPRO the Lisp string we are
4227 iterating.
4228 (bidi_push_it, bidi_pop_it): New functions.
4229 (bidi_initialize): Initialize the bidi cache start stack pointer.
4230 (bidi_cache_ensure_space): New function, refactored from part of
4231 bidi_cache_iterator_state. Don't assume the required size is just
4232 one BIDI_CACHE_CHUNK away.
4233 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4234 (bidi_count_bytes, bidi_char_at_pos): New functions.
4235 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4236 always valid if bidi_cache_idx is valid.
4237 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4238 is valid if it's going to be used.
4239 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4240 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4241 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4242 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4243 (bidi_find_other_level_edge, bidi_cache_start_stack):
4244 All variables related to cache indices are now EMACS_INT.
c965adc5 4245
0bb23927
EZ
4246 * dispextern.h (struct bidi_string_data): New structure.
4247 (struct bidi_it): New member `string'. Make flag members be 1-bit
4248 fields, and put them last in the struct.
640c8776
SM
4249 (compute_display_string_pos, compute_display_string_end):
4250 Update prototypes.
0bb23927
EZ
4251 (bidi_push_it, bidi_pop_it): Add prototypes.
4252 (struct iterator_stack_entry): New members bidi_p,
4253 paragraph_embedding, and from_disp_prop_p.
4254 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4255 (bidi_shelve_cache, bidi_unshelve_cache):
4256 Declare prototypes.
0bb23927
EZ
4257
4258 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4259 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4260 and vector-like objects.
4261
4262 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4263 cache around display iteration.
4264
4265 * window.c (Fwindow_end, window_scroll_pixel_based)
4266 (displayed_window_lines, Frecenter): Save and restore the bidi
4267 cache around display iteration.
4268
3bbd2265
LMI
42692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4270
4271 * editfns.c (Fdelete_region): Clarify the use of the named
4272 parameters (bug#6788).
4273
adc47434
MR
42742011-07-14 Martin Rudalics <rudalics@gmx.at>
4275
4276 * indent.c (Fvertical_motion): Set and restore w->pointm when
4277 saving and restoring the window's buffer (Bug#9006).
4278
837c31f8
LMI
42792011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4280
4281 * editfns.c (Fstring_to_char): Clarify just what is returned
4282 (bug#6576). Text by Eli Zaretskii.
4283
ac389d0c
JB
42842011-07-13 Juanma Barranquero <lekktu@gmail.com>
4285
4286 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4287
0be0ce47
EZ
42882011-07-13 Eli Zaretskii <eliz@gnu.org>
4289
4290 * buffer.c (mmap_find): Fix a typo.
4291
cd18e7e3
JB
42922011-07-13 Johan Bockgård <bojohan@gnu.org>
4293
4294 Fix execution of x selection hooks.
4295 * xselect.c (Qx_lost_selection_functions)
4296 (Qx_sent_selection_functions): New vars.
4297 (syms_of_xselect): DEFSYM them.
4298 (x_handle_selection_request): Pass Qx_sent_selection_functions
4299 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4300 (x_handle_selection_clear,x_clear_frame_selections):
4301 Pass Qx_lost_selection_functions rather than
4302 Vx_lost_selection_functions to Frun_hook_with_args.
4303
47ea7f44
PE
43042011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4305
ac389d0c 4306 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4307 The old code sometimes used this field without initializing it.
4308
47ea7f44
PE
4309 * alloc.c (gc_sweep): Don't read past end of array.
4310 In theory, the old code could also have corrupted Emacs internals,
4311 though it'd be very unlikely.
4312
bc985c87
AS
43132011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4314
4315 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4316 argument. (Bug#4026)
bc985c87 4317
0cf34688
LMI
43182011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4319
b3dadd76
LMI
4320 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4321 key" (bug#4257).
4322
0cf34688
LMI
4323 * window.c (Fset_window_start): Doc fix (bug#4199).
4324 (Fset_window_hscroll): Ditto.
4325
270768cd
PE
43262011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4327
077e3dda 4328 Fix minor new problems caught by GCC 4.6.1.
270768cd 4329 * term.c (init_tty): Remove unused local.
490011a6 4330 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4331 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4332 not used otherwise.
270768cd 4333
b1f58454
CY
43342011-07-12 Chong Yidong <cyd@stupidchicken.com>
4335
4336 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4337
22b9578d
LMI
43382011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339
6e70ab07
LMI
4340 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4341 are the mini-buffer and the echo area (bug#3320).
4342
22b9578d
LMI
4343 * term.c (init_tty): Remove support for supdup, c10 and perq
4344 terminals, which are no longer supported (bug#1482).
4345
8974cc9f
JB
43462011-07-10 Johan Bockgård <bojohan@gnu.org>
4347
4348 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4349
a560d974
JD
43502011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4351
4352 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4353 for non-popups (Bug#3642).
4354
1dae0f0a
AS
43552011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4356
268c2c36 4357 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4358 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4359 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4360 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4361 * data.c (fmod): Likewise.
4362 * dispnew.c (swap_glyphs_in_rows): Likewise.
4363 * emacs.c (memory_warning_signal): Likewise.
4364 * floatfns.c (float_error): Likewise.
4365 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4366 (otf_open, font_otf_capability, generate_otf_features)
4367 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4368 Likewise.
4369 * image.c (pbm_read_file): Likewise.
4370 * indent.c (string_display_width): Likewise.
4371 * intervals.c (check_for_interval, search_for_interval)
4372 (inc_interval_count, count_intervals, root_interval)
4373 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4374 * lread.c (defalias): Likewise.
268c2c36 4375 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4376 * regex.c (set_image_of_range_1, set_image_of_range)
4377 (regex_grow_registers): Likewise.
4378 * sysdep.c (strerror): Likewise.
4379 * termcap.c (valid_filename_p, tprint, main): Likewise.
4380 * tparam.c (main): Likewise.
4381 * unexhp9k800.c (run_time_remap, save_data_space)
4382 (update_file_ptrs, read_header, write_header, calculate_checksum)
4383 (copy_file, copy_rest, display_header): Likewise.
4384 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4385 Likewise.
4386 * xdisp.c (check_it): Likewise.
4387 * xfaces.c (register_color, unregister_color, unregister_colors):
4388 Likewise.
4389 * xfns.c (print_fontset_result): Likewise.
4390 * xrdb.c (member, fatal, main): Likewise.
4391
99033785
PE
43922011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4393
4394 Fix minor problems found by static checking (Bug#9031).
4395 * chartab.c (char_table_set_range, map_sub_char_table):
4396 Remove unused locals.
4397 (uniprop_table): Now static.
4398 * composite.c (_work_char): Remove unused static var.
4399
9cb2ac56
JB
44002011-07-09 Juanma Barranquero <lekktu@gmail.com>
4401
4402 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4403
f25661f0
JD
44042011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4405
4406 * gtkutil.c (qttip_cb): Remove code without function.
4407
8278c4fe
EZ
44082011-07-09 Eli Zaretskii <eliz@gnu.org>
4409
4410 * w32.c (pthread_sigmask): New stub.
4411
1692ae2d 44122011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4413
8a6ebd58 4414 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4415 sigprocmask is portable only for single-threaded applications, and
4416 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4417 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4418 (LIBES): Use it.
4419 * callproc.c (Fcall_process):
4420 * process.c (create_process):
4421 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4422 Use pthread_sigmask, not sigprocmask.
123403e4 4423
1b854618
JD
44242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4425
4426 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4427 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4428 wrong (Bug#8591).
4429
3fe4b549
JD
44302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4431
0ce7e563
JD
4432 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4433 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4434 (xg_hide_tooltip): Fix comment.
4435
3fe4b549
JD
4436 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4437 in registerServicesMenuSendTypes.
4438 (validRequestorForSendType): Don't check ns_return_types.
4439
4440 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4441 ns_return_type.
4442
5df75e47
JR
44432011-07-08 Jason Rumney <jasonr@gnu.org>
4444
22610910
JR
4445 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4446 SH_SHOW for hidden windows (Bug#5482).
4447
5df75e47
JR
4448 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4449 frame struct members of non-existent frames (Bug#6284).
4450
699c10bd
JD
44512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4452
4393663b
JD
4453 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4454 variable firstTime not needed on OSX >= 10.6.
4455 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4456 >= 10.5. Use setKnobProportion, setDoubleValue.
4457
4458 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4459 (MAC_OS_X_VERSION_10_5): Define if not defined.
4460 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4461 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4462 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4463
4464 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4465 cString and lossyCString on OSX >= 10.4
4466
58179cce 4467 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4468 sizeToFit on OSX >= 10.2.
4469
4470 * nsimage.m (allocInitFromFile): Don't use deprecated method
4471 bestRepresentationForDevice on OSX >= 10.6.
4472
4473 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4474 to avoid warning.
4475
4476 * emacs.c: Declare unexec_init_emacs_zone.
4477
a63e0781
JD
4478 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4479
699c10bd
JD
4480 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4481
4482 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4483 on svcsMenu (Bug#8842).
4484
4485 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4486 ns_return_types.
4487 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4488
4489 * nsterm.m (QUTF8_STRING): Declare.
4490 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4491 (validRequestorForSendType): Return type is (id).
4492 Change indexOfObjectIdenticalTo to indexOfObject.
4493 Check if we have local selection before returning self (Bug#8842).
4494 (writeSelectionToPasteboard): Put local selection into paste board
4495 if we have a local selection (Bug#8842).
4496 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4497
4498 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4499 (ns_get_local_selection): Declare.
4500
54e10184
LMI
45012011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4502
9888ff71
LMI
4503 * keymap.c (describe_map_tree): Don't insert a double newline at
4504 the end of the buffer (bug#1169) and return whether we inserted
4505 something.
4506
54e10184
LMI
4507 * callint.c (Fcall_interactively): Change "reading args" to
4508 "providing args" to try to clarify what it does (bug#1010).
4509
15fa4783
KH
45102011-07-07 Kenichi Handa <handa@m17n.org>
4511
4512 * composite.c (composition_compute_stop_pos): Ignore a static
4513 composition starting before CHARPOS (Bug#8915).
4514
4515 * xdisp.c (handle_composition_prop): Likewise.
4516
a8815b00
EZ
45172011-07-07 Eli Zaretskii <eliz@gnu.org>
4518
4519 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4520 (Bug#9015)
4521
ef7b981d 45222011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4523
4524 * character.h (unicode_category_t): New enum type.
4525
4526 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4527 (Qchar_code_property_table): New variable.
4528 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4529 (UNIPROP_COMPRESSED_FORM_P): New macros.
4530 (char_table_ascii): Uncompress the compressed values.
4531 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4532 Uncompress the compressed values.
ac389d0c 4533 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4534 (char_table_ref_and_range): Uncompress the compressed values.
4535 (sub_char_table_set): New arg is_uniprop. Callers changed.
4536 Uncompress the compressed values.
4537 (sub_char_table_set_range): Args changed. Callers changed.
4538 (char_table_set_range): Adjuted for the above change.
4539 (map_sub_char_table): Delete args default_val and parent. Add arg
4540 top. Give decoded values to a Lisp function.
640c8776 4541 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4542 values to a Lisp function. Gcpro more variables.
4543 (uniprop_table_uncompress)
4544 (uniprop_decode_value_run_length): New functions.
4545 (uniprop_decoder, uniprop_decoder_count): New variables.
4546 (uniprop_get_decoder, uniprop_encode_value_character)
4547 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4548 New functions.
4549 (uniprop_encoder, uniprop_encoder_count): New variables.
4550 (uniprop_get_encoder, uniprop_table)
4551 (Funicode_property_table_internal, Fget_unicode_property_internal)
4552 (Fput_unicode_property_internal): New functions.
4553 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4554 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4555 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4556 char-code-property-alist.
4557
640c8776 4558 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4559 Vunicode_category_table.
4560
640c8776 4561 * font.c (font_range): Adjust for the change of
c805dec0
KH
4562 Vunicode_category_table.
4563
76b397fb
DN
45642011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4565
4566 * m/iris4d.h: Remove file, move contents ...
4567 * s/irix6-5.h: ... here.
4568
22b4128e
PE
45692011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4572 * alloc.c (mark_buffer):
4573 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4574 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4575 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4576 This isn't true in general, and it's particularly not true
4577 if Emacs is configured with --with-wide-int.
4578 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4579 New macros, used in the buffer.c change.
4580
869795d6
JD
45812011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4582
4583 * xsettings.c: Use both GConf and GSettings if both are available.
4584 (store_config_changed_event): Add comment.
4585 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4586 (store_tool_bar_style_changed): New functions.
5e617bc2 4587 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4588 (struct xsettings): Move font inside HAVE_XFT.
4589 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4590 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4591 Move inside HAVE_XFT.
640c8776 4592 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4593 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4594 also.
4595 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4596 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4597 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4598 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4599 (parse_settings): Move check for font inside HAVE_XFT.
4600 (read_settings, apply_xft_settings): Add comment.
4601 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4602 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4603 call store_font_name_changed.
4604 (xft_settings_event): Add comment.
4605 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4606 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4607 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4608 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4609 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4610 (xsettings_get_system_font, xsettings_get_system_normal_font):
4611 Add comment.
869795d6 4612
d8ed26bd
PE
46132011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4614
4615 Random fixes. E.g., (random) never returned negative values.
4616 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4617 subseconds part to the entropy, as that's a bit more random.
4618 Prefer signed to unsigned, since the signedness doesn't matter and
4619 in general we prefer signed. When given a limit, use a
4620 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4621 latter isn't right if USE_2_TAGS_FOR_INTS.
4622 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4623 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4624
cabf1cac
SM
46252011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4626
4627 * textprop.c (text_property_stickiness):
4628 Obey Vtext_property_default_nonsticky.
4629 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4630 * w32fns.c (syms_of_w32fns):
4631 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4632
6e9b2be9
PE
46332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4636 This is more efficient than Ffile_directory_p and avoids a minor race.
4637
90186c68
LMI
46382011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4639
7c301272
LMI
4640 * buffer.c (Foverlay_put): Say what the return value is
4641 (bug#7835).
4642
c4f2d8d4
LMI
4643 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4644 is a directory before asking whether to use the file name
4645 (bug#7564).
ad637907
LMI
4646 (barf_or_query_if_file_exists): Make the "File is a directory"
4647 error be more correct.
c4f2d8d4 4648
90186c68
LMI
4649 * fns.c (Frequire): Remove the mention of the .gz files, since
4650 that's installation-specific, but keep the mention of
4651 `get-load-suffixes'.
4652
da64016e
PE
46532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4654
4655 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4656 Report string overflow if the output is too long.
4657
7d47b580
JB
46582011-07-04 Juanma Barranquero <lekktu@gmail.com>
4659
a555cb87
JB
4660 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4661 (syms_of_gnutls): Remove duplicate DEFSYM for
4662 Qgnutls_bootprop_verify_hostname_error, an error for
4663 Qgnutls_bootprop_verify_error (which is no longer used).
4664
7d47b580
JB
4665 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4666 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4667 Also (re)move comments that are misplaced or no longer relevant.
4668
1e49bfab
LMI
46692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4670
4671 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4672
1485f4c0
CY
46732011-07-03 Chong Yidong <cyd@stupidchicken.com>
4674
4675 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4676 and background color parameters if they have been changed.
4677
a9ab721e
LMI
46782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4679
4680 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4681
cf7cff57
PE
46822011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4683
2e13213d
PE
4684 * xsettings.c (SYSTEM_FONT): Define only when used.
4685 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4686
cf7cff57
PE
4687 * keymap.c (access_keymap_1): Now static.
4688
7a8e04f7
CY
46892011-07-02 Chong Yidong <cyd@stupidchicken.com>
4690
4691 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4692 leave any prefix arg for the up event (Bug#1586).
4693
61352f62
LMI
46942011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4695
69bb1ef7
LMI
4696 * lread.c (syms_of_lread): Mention single symbols defined by
4697 `defvar' or `defconst' (bug#7154).
4698
61352f62 4699 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4700 (Frequire): Mention get-load-suffixes.
61352f62 4701
28545e04
MR
47022011-07-02 Martin Rudalics <rudalics@gmx.at>
4703
4704 * window.h (window): Remove clone_number slot.
4705 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4706 Remove.
4707 (make_parent_window, make_window, saved_window)
4708 (Fset_window_configuration, save_window_save): Don't deal with
4709 clone numbers.
4710 * buffer.c (Qclone_number): Remove declaration.
4711 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4712
3349e122
SM
47132011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4714
4715 Add multiple inheritance to keymaps.
4716 * keymap.c (Fmake_composed_keymap): New function.
4717 (Fset_keymap_parent): Simplify.
4718 (fix_submap_inheritance): Remove.
4719 (access_keymap_1): New function extracted from access_keymap to handle
4720 embedded parents and handle lists of maps.
4721 (access_keymap): Use it.
4722 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4723 (Fcopy_keymap): Handle embedded parents.
4724 (Fcommand_remapping, define_as_prefix): Simplify.
4725 (Fkey_binding): Simplify.
4726 (syms_of_keymap): Move minibuffer-local-completion-map,
4727 minibuffer-local-filename-completion-map,
4728 minibuffer-local-must-match-map, and
4729 minibuffer-local-filename-must-match-map to Elisp.
4730 (syms_of_keymap): Defsubr make-composed-keymap.
4731 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4732 (parse_menu_item): Trivial simplification.
4733
3279eb87
GM
47342011-07-01 Glenn Morris <rgm@gnu.org>
4735
4736 * Makefile.in (SETTINGS_LIBS): Fix typo.
4737
4550efdf
KI
47382011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4739
4740 * coding.c (Fencode_coding_string): Record the last coding system
4741 used, as the function doc string says (bug#8738).
4742
0949d2b6
JD
47432011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4744
4745 * xsettings.c (store_monospaced_changed): Take new font as arg and
4746 check for change against current_mono_font.
4747 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4748 (emacs_settings_constructor, emacs_settings_get_property)
4749 (emacs_settings_set_property, emacs_settings_class_init)
4750 (emacs_settings_init, gsettings_obj): Remove.
4751 (something_changedCB): New function for HAVE_GSETTINGS.
4752 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4753 with value as argument.
4754 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4755 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4756 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4757 "changed".
4758
4759 * xgselect.c: Add defined (HAVE_GSETTINGS).
4760 (xgselect_initialize): Ditto.
4761
4762 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4763 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4764 xg_select.
4765
bbc6b304
PE
47662011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4767
4768 * eval.c (struct backtrace): Simplify and port the data structure.
4769 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4770 signed bit field, as this assumption is not portable and it makes
4771 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4772 "char debug_on_exit : 1" as this is not portable either; instead,
4773 use the portable "unsigned int debug_on_exit : 1". Remove unused
4774 member evalargs. Remove obsolete comments about cc bombing out.
4775
9851bfc5
JD
47762011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4777
51bb811f 4778 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4779 Let HAVE_GSETTINGS override HAVE_GCONF.
4780 (store_monospaced_changed): New function.
4781 (EMACS_SETTINGS): A new type derived from GObject to handle
4782 GSettings notifications.
4783 (emacs_settings_constructor, emacs_settings_get_property)
4784 (emacs_settings_set_property, emacs_settings_class_init):
4785 New functions.
4786 (gsettings_client, gsettings_obj): New variables.
4787 (GSETTINGS_SCHEMA): New define.
4788 (something_changedCB): Call store_monospaced_changed.
4789 (init_gsettings): New function.
4790 (xsettings_initialize): Call init_gsettings.
4791 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4792 to NULL.
4793
640c8776 4794 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4795 GCONF_CFLAGS/LIBS.
4796
5386012d
MR
47972011-06-29 Martin Rudalics <rudalics@gmx.at>
4798
4799 * window.c (resize_root_window, grow_mini_window)
4800 (shrink_mini_window): Rename Qresize_root_window to
4801 Qwindow_resize_root_window and Qresize_root_window_vertically to
4802 Qwindow_resize_root_window_vertically.
4803
f13e0b08
PE
48042011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4805
4806 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4807
94515237
JB
48082011-06-27 Juanma Barranquero <lekktu@gmail.com>
4809
4810 * makefile.w32-in: Redesign dependencies so they reflect more
4811 clearly which files are directly included by each source file,
4812 and not through other includes.
4813
e43b6e43
MR
48142011-06-27 Martin Rudalics <rudalics@gmx.at>
4815
4816 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4817 (sort_overlays, overlay_strings): When an overlay's clone number
4818 matches the window's clone number process the overlay even if
4819 the overlay's window property doesn't match the current window.
4820
d68443dc
MR
4821 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4822 (Fwindow_hchild): Rename to Fwindow_left_child.
4823 (Fwindow_next): Rename to Fwindow_next_sibling.
4824 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4825 (resize_window_check): Rename to window_resize_check.
4826 (resize_window_apply): Rename to window_resize_apply.
4827 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4828 (Fdelete_other_windows_internal, resize_frame_windows)
4829 (Fsplit_window_internal, Fdelete_window_internal)
4830 (grow_mini_window, shrink_mini_window)
4831 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4832
c7e73be5
JD
48332011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4834
4835 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4836 (emacs_fixed_set_min_size): Remove.
4837 (emacs_fixed_new): Take frame as argument.
4838
4839 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4840 (_EmacsFixedPrivate): Remove minwidth/height.
4841 Add struct frame *f.
4842 (emacs_fixed_init): Initialize priv->f.
4843 (get_parent_class, emacs_fixed_set_min_size): Remove.
4844 (emacs_fixed_new): Set priv->f to argument.
4845 (emacs_fixed_get_preferred_width)
4846 (emacs_fixed_get_preferred_height): Use min_width/height from
4847 frames size_hint to set minimum and natural (Bug#8919).
4848 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4849 and use min_width/height from frames size_hint to set
4850 min_width/height (Bug#8919).
4851
4852 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4853 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4854 Fix indentation.
c7e73be5 4855
cf99dcf8
EZ
48562011-06-26 Eli Zaretskii <eliz@gnu.org>
4857
4858 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4859 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4860 called at ZV.
4861
029529ac
CY
48622011-06-26 Chong Yidong <cyd@stupidchicken.com>
4863
4864 * process.c (wait_reading_process_output): Bypass select if
4865 waiting for a cell while ignoring keyboard input, and input is
4866 pending. Suggested by Jan Djärv (Bug#8869).
4867
7a7ef429
PE
48682011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4869
4870 Use gnulib's dup2 module instead of rolling our own.
4871 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4872
11fdef7d 48732011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4874
4875 * dispnew.c (scrolling_window): Before scrolling, turn off a
4876 mouse-highlight in the window being scrolled.
4877
cd3520a4
JB
48782011-06-24 Juanma Barranquero <lekktu@gmail.com>
4879
4880 Move DEFSYM to lisp.h and use everywhere.
4881
4882 * character.h (DEFSYM): Move declaration...
4883 * lisp.h (DEFSYM): ...here.
4884
4885 * gnutls.c:
4886 * minibuf.c:
4887 * w32menu.c:
4888 * w32proc.c:
4889 * w32select.c: Don't include character.h.
4890
4891 * alloc.c (syms_of_alloc):
4892 * buffer.c (syms_of_buffer):
4893 * bytecode.c (syms_of_bytecode):
4894 * callint.c (syms_of_callint):
4895 * casefiddle.c (syms_of_casefiddle):
4896 * casetab.c (init_casetab_once):
4897 * category.c (init_category_once, syms_of_category):
4898 * ccl.c (syms_of_ccl):
4899 * cmds.c (syms_of_cmds):
4900 * composite.c (syms_of_composite):
4901 * dbusbind.c (syms_of_dbusbind):
4902 * dired.c (syms_of_dired):
4903 * dispnew.c (syms_of_display):
4904 * doc.c (syms_of_doc):
4905 * editfns.c (syms_of_editfns):
4906 * emacs.c (syms_of_emacs):
4907 * eval.c (syms_of_eval):
4908 * fileio.c (syms_of_fileio):
4909 * fns.c (syms_of_fns):
4910 * frame.c (syms_of_frame):
4911 * fringe.c (syms_of_fringe):
4912 * insdel.c (syms_of_insdel):
4913 * keymap.c (syms_of_keymap):
4914 * lread.c (init_obarray, syms_of_lread):
4915 * macros.c (syms_of_macros):
4916 * msdos.c (syms_of_msdos):
4917 * print.c (syms_of_print):
4918 * process.c (syms_of_process):
4919 * search.c (syms_of_search):
4920 * sound.c (syms_of_sound):
4921 * syntax.c (init_syntax_once, syms_of_syntax):
4922 * terminal.c (syms_of_terminal):
4923 * textprop.c (syms_of_textprop):
4924 * undo.c (syms_of_undo):
4925 * w32.c (globals_of_w32):
4926 * window.c (syms_of_window):
4927 * xdisp.c (syms_of_xdisp):
4928 * xfaces.c (syms_of_xfaces):
4929 * xfns.c (syms_of_xfns):
4930 * xmenu.c (syms_of_xmenu):
4931 * xsettings.c (syms_of_xsettings):
4932 * xterm.c (syms_of_xterm): Use DEFSYM.
4933
4228cf16
TZ
49342011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4935
cd3520a4 4936 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4937
7fcccf1e
PE
49382011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4939
7efb4e0e
PE
4940 Integer and buffer overflow fixes (Bug#8873).
4941
ff5844ad
PE
4942 * print.c (printchar, strout): Check for string overflow.
4943 (PRINTPREPARE, printchar, strout):
4944 Don't set size unless allocation succeeds.
4945
90532f02
PE
4946 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4947 for sizes. Check for string overflow more accurately.
4948 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4949
6d84508d
PE
4950 * macros.c: Integer and buffer overflow fixes.
4951 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4952 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4953 Use ptrdiff_t, not int, for sizes.
4954 Don't increment bufsize until after realloc succeeds.
4955 Check for size-calculation overflow.
4956 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4957
437b2cb4
PE
4958 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4959
8b9ac8b4
PE
4960 * lread.c: Integer overflow fixes.
4961 (read_integer): Radix is now EMACS_INT, not int,
4962 to improve quality of diagnostics for out-of-range radices.
4963 Calculate buffer size correctly for out-of-range radices.
4964 (read1): Check for integer overflow in radices, and in
4965 read-circle numbers.
82cb60d3
PE
4966 (read_escape): Avoid int overflow.
4967 (Fload, openp, read_buffer_size, read1)
4968 (substitute_object_recurse, read_vector, read_list, map_obarray):
4969 Use ptrdiff_t, not int, for sizes.
4970 (read1): Use EMACS_INT, not int, for sizes.
20270765 4971 Check for size overflow.
8b9ac8b4 4972
7fcccf1e
PE
4973 * image.c (cache_image): Check for size arithmetic overflow.
4974
bfbbd7e7
PE
4975 * lread.c: Integer overflow issues.
4976 (saved_doc_string_size, saved_doc_string_length)
4977 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4978 Now ptrdiff_t, not int.
4979 (read1): Don't assume doc string length fits in int. Check for
4980 out-of-range doc string lengths.
4981 (read_list): Don't assume file position fits in int.
39019e54 4982 (read_escape): Check for hex character overflow.
bfbbd7e7 4983
4e323265
LL
49842011-06-22 Leo Liu <sdl.web@gmail.com>
4985
4986 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4987 Move to minibuffer.el.
4988
85fece3e
PE
49892011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4990
20b84ce9 4991 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4992 The following patches are for when GLYPH_DEBUG && !XASSERT.
4993 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4994 * dispnew.c (flush_stdout):
4995 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4996 Mark as externally visible.
4997 * dispnew.c (check_window_matrix_pointers): Now static.
4998 * dispnew.c (window_to_frame_vpos):
4999 * xfns.c (unwind_create_frame):
5000 * xterm.c (x_check_font): Remove unused local.
5001 * scroll.c (CHECK_BOUNDS):
5002 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5003 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5004 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5005 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5006 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5007 Now static.
5008 (debug_method_add): Use va_list and vsprintf rather than relying
5009 on undefined behavior with wrong number of arguments.
5010 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5011 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5012 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5013 since we're not interested in debugging glyphs with old libraries.
5014 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5015 GCC 4.6.0's static checking.
5016
0766b489
PE
50172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5018
31fd4b32
PE
5019 Integer overflow and signedness fixes (Bug#8873).
5020 A few related buffer overrun fixes, too.
5021
b79e8648
PE
5022 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5023
0766b489
PE
5024 * dispextern.h (struct face.stipple):
5025 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5026 (x_bitmap_mask, x_allocate_bitmap_record)
5027 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5028 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5029 (x_create_bitmap_from_xpm_data):
5030 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5031 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5032 (.bitmaps_last):
5033 * xfaces.c (load_pixmap):
5034 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5035 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5036 (.bitmaps_last, struct x_output.icon_bitmap):
5037 Use ptrdiff_t, not int, for bitmap indexes.
5038 (x_allocate_bitmap_record): Check for size overflow.
5039 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5040
b081724f
PE
5041 Use ptrdiff_t, not int, for overlay counts.
5042 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5043 * editfns.c (overlays_around, get_pos_property):
5044 * textprop.c (get_char_property_and_overlay):
5045 * xdisp.c (next_overlay_change, note_mouse_highlight):
5046 * xfaces.c (face_at_buffer_position):
21514da7
PE
5047 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5048 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5049 (Fnext_overlay_change, Fprevious_overlay_change)
5050 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5051 Use ptrdiff_t, not int, for sizes.
21514da7 5052 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5053
3de73e5e
PE
5054 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5055
2606c57b
PE
5056 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5057 (x_session_initialize): Do not assume string length fits in int.
5058
aaafe47a
PE
5059 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5060 This is unlikely, but can occur if DPI is outlandish.
5061
2674ddc8 5062 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5063 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5064
28154962
PE
5065 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5066 * xrdb.c (magic_file_p, search_magic_path):
5067 Omit last arg SUFFIX; it was always 0. All callers changed.
5068 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5069
7de51af5
PE
5070 * xfont.c (xfont_match): Avoid need for strlen.
5071
25ed6cc3
PE
5072 * xfns.c: Don't assume strlen fits in int.
5073 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5074
4eab31dd
PE
5075 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5076 not unsigned long, as we prefer signed integers. All callers changed.
5077 Detect integer overflow in repeat count.
5078 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5079 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5080
171e2a58
PE
5081 * termcap.c: Don't assume sizes fit in int and never overflow.
5082 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5083 (gobble_line): Check for size-calculation overflow.
5084
ad39faca 5085 * minibuf.c (Fread_buffer):
6e5bb2dc 5086 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5087 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5088 Don't assume string length fits in int.
5089
52c61c22 5090 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5091 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5092
b5b8c9e5
PE
5093 * font.c: Don't assume string length fits in int.
5094 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5095 Use ptrdiff_t, not int.
ccd6111c
PE
5096 (font_intern_prop): Don't assume string length fits in int.
5097 Don't assume integer property fits in fixnum.
5098 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5099
882f0d81 5100 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5101 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5102 Reformulate so as not to need the command string.
5103 Invoke gzip -cd rather than gunzip, as it's more portable.
5104 (lock_info_type, lock_file_1, lock_file):
5105 Don't assume pid_t and time_t fit in unsigned long.
5106 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5107 (current_lock_owner): Prefer signed type for sizes.
5108 Use memcpy, not strncpy, where memcpy is what is really wanted.
5109 Don't assume (via atoi) that time_t and pid_t fit in int.
5110 Check for time_t and/or pid_t out of range, e.g., via a network share.
5111 Don't alloca where an auto var works fine.
5112
93f4cf88
PE
5113 * fileio.c: Fix some integer overflow issues.
5114 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5115 Don't assume string length fits in int.
5116 (directory_file_name): Don't assume string length fits in long.
5117 (make_temp_name): Don't assume pid fits in int, or that its print
5118 length is less than 20.
5119
f3e92b69
PE
5120 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5121
1bfdaf10
PE
5122 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5123
35016e9a
PE
5124 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5125
3d1e65a1
PE
5126 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5127 We prefer signed integers, even for size calculations.
5128
0b963a93
PE
5129 * emacs.c: Don't assume string length fits in 'int'.
5130 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5131 (main): Don't invoke strlen when not needed.
5132
573f4b54
PE
5133 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5134 (XD_DEBUG_MESSAGE): Don't waste a byte.
5135
989f33ba
PE
5136 * callproc.c (getenv_internal_1, getenv_internal)
5137 (Fgetenv_internal):
965d34eb
PE
5138 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5139
e4d29b33
PE
5140 * lread.c (invalid_syntax): Omit length argument.
5141 All uses changed. This doesn't fix a bug, but it simplifies the
5142 code away from its former Hollerith-constant appearance, and it's
5143 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5144 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5145
eb49b136
PE
5146 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5147 This didn't break anything, but it didn't help either.
5148 It's confusing to put a bogus integer in a place where the actual
5149 value does not matter.
9f62aeb1 5150 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5151 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5152
15375a22
PE
5153 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5154 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5155 implementation.
b61cc01c
PE
5156 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5157 We prefer signed types, and the value cannot exceed the EMACS_INT
5158 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5159 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5160 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5161 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5162
53b2623d
PE
5163 * indent.c (sane_tab_width): New function.
5164 (current_column, scan_for_column, Findent_to, position_indentation)
5165 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5166 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5167
51cab52b 5168 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5169
f2ed8a70
PE
5170 * lisp.h (lint_assume): New macro.
5171 * composite.c (composition_gstring_put_cache):
5172 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5173
abe80cc6
PE
5174 * editfns.c, insdel.c:
5175 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5176
b02c740e
PE
5177 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5178
ebc96716
PE
5179 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5180
b4e50fa0 5181 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5182 Use much-faster test for byte-length change.
311d5d7c 5183 Don't assume string byte-length fits in 'int'.
a4cf38e4 5184 Check that character arg fits in 'int'.
85461888 5185 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5186
c0c1ee9f
PE
5187 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5188
a498d7f4
PE
5189 * fns.c (concat): Catch string overflow earlier.
5190 Do not rely on integer wraparound.
5191
51cab52b
PE
5192 * dispextern.h (struct it.overlay_strings_charpos)
5193 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5194 * xdisp.c (forward_to_next_line_start)
5195 (back_to_previous_visible_line_start)
5196 (reseat_at_next_visible_line_start, next_element_from_buffer):
5197 Don't arbitrarily truncate the value of 'selective' to int.
5198
76031fad
PE
5199 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5200
5eb55db9
PE
5201 * composite.c: Don't truncate sizes to 'int'.
5202 (composition_gstring_p, composition_reseat_it)
5203 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5204 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5205 not EMACS_UINT, for indexes.
5eb55db9 5206
0703a717
PE
5207 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5208
d6202519
PE
5209 * buffer.c: Include <verify.h>.
5210 (struct sortvec.priority, struct sortstr.priority):
8961a454 5211 Now EMACS_INT, not int.
c20998a7 5212 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5213 (struct sortstr.size, record_overlay_string)
5214 (struct sortstrlist.size, struct sortlist.used):
5215 Don't truncate size to int.
5216 (record_overlay_string): Check for size-calculation overflow.
d6202519 5217 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5218
d5a19415
JM
52192011-06-22 Jim Meyering <meyering@redhat.com>
5220
029529ac 5221 Don't leak an XBM-image-sized buffer
d5a19415
JM
5222 * image.c (xbm_load): Free the image buffer after using it.
5223
a9041e6c
PE
52242011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5225
5226 Port to Sun C.
5227 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5228 that Sun C diagnosed.
5229 * fns.c (secure_hash): Fix pointer signedness issue.
5230 * intervals.c (static_offset_intervals): New function.
5231 (offset_intervals): Use it.
5232
7f3f739f
LL
52332011-06-21 Leo Liu <sdl.web@gmail.com>
5234
5235 * deps.mk (fns.o):
5236 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5237 sha512.h.
5238
5239 * fns.c (secure_hash): Rename from crypto_hash_function and change
5240 the first arg to accept symbols.
5b66d427 5241 (Fsecure_hash): New primitive.
7f3f739f
LL
5242 (syms_of_fns): New symbols.
5243
76147d94
DD
52442011-06-20 Deniz Dogan <deniz@dogan.se>
5245
5246 * process.c (Fset_process_buffer): Clarify return value in
5247 docstring.
5248
7d7d0045
CY
52492011-06-18 Chong Yidong <cyd@stupidchicken.com>
5250
5251 * dispnew.c (add_window_display_history): Use BVAR.
5252
5253 * xdisp.c (debug_method_add): Use BVAR.
5254 (check_window_end, dump_glyph_matrix, dump_glyph)
5255 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5256
5257 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5258 Likewise.
5259
5260 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5261 check till after the cache is created in init_frame_faces.
5262
ff2bc410
SM
52632011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5264
5265 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5266
28177add
PE
52672011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5268
dd3482fe
PE
5269 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5270 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5271 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5272
393d71f3 5273 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5274 * fileio.c (Finsert_file_contents):
5275 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5276 Remove the old (too-loose) buffer overflow checks.
5277 They weren't needed, since make_gap checks for buffer overflow.
5278 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5279 The old code merely checked for Emacs fixnum overflow, and relied
5280 on undefined (wraparound) behavior. The new code avoids undefined
5281 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5282
2e6813b0 5283 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5284 Tune. Don't use wider integers than needed. Don't use alloca.
5285 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5286
599a9e4f
PE
5287 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5288
99561444
PE
5289 * insdel.c, lisp.h (buffer_overflow): New function.
5290 (insert_from_buffer_1, replace_range, replace_range_2):
5291 * insdel.c (make_gap_larger):
5292 * editfns.c (Finsert_char):
5293 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5294
28177add
PE
5295 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5296
e69dafad
PE
52972011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5298
4baa020d 5299 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5300
b1c46f02
PE
5301 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5302 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5303
e69dafad
PE
5304 * fileio.c: Don't assume EMACS_INT fits in off_t.
5305 (emacs_lseek): New static function.
5306 (Finsert_file_contents, Fwrite_region): Use it.
5307 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5308
566684ea
PE
5309 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5310
e6966cd6
PE
5311 * fns.c: Don't overflow int when computing a list length.
5312 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5313 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5314 truncation on 64-bit hosts. Check for QUIT every
5315 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5316 faster and is responsive enough.
5317 (Flength): Report an error instead of overflowing an integer.
5318 (Fsafe_length): Return a float if the value is not representable
5319 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5320 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5321 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5322
dd0b0efb
PE
5323 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5324 (header_size, word_size): New constants.
5325 (allocate_vectorlike): Don't check size overflow here.
5326 (allocate_vector): Check it here instead, since this is the only
5327 caller of allocate_vectorlike that could cause overflow.
5328 Check that the new vector's length is representable as a fixnum.
5329
86fe5cfe
PE
5330 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5331 The previous code was bogus. For example, next_almost_prime (32)
5332 returned 39, which is undesirable as it is a multiple of 3; and
5333 next_almost_prime (24) returned 25, which is a multiple of 5 so
5334 why was the code bothering to check for multiples of 7?
5335
80e88859
PE
5336 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5337
4a2f0ad6
PE
5338 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5339
f66c7cf8
PE
5340 Variadic C functions now count arguments with ptrdiff_t.
5341 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5342 Back then I didn't know that the Emacs coding style prefers signed int.
5343 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5344 were being counted with int, which may truncate counts on 64-bit
5345 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5346 * lisp.h (struct Lisp_Subr.function.aMANY)
5347 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5348 Arg counts are now ptrdiff_t, not size_t.
5349 All variadic functions and their callers changed accordingly.
5350 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5351 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5352 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5353 * callint.c (Fcall_interactively): Check arg count for overflow,
5354 to avoid potential buffer overrun. Use signed char, not 'int',
5355 for 'varies' array, so that we needn't bother to check its size
5356 calculation for overflow.
5357 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5358 * eval.c (apply_lambda):
5359 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5360 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5361 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5362
a1759b76
PE
5363 * callint.c (Fcall_interactively): Don't use index var as event count.
5364
d96be9fc
PE
5365 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5366 * mem-limits.h (SIZE): Remove; no longer used.
5367
a690a978 5368 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5369
578c21e6
PE
5370 Remove unnecessary casts.
5371 * xterm.c (x_term_init):
5372 * xfns.c (x_set_border_pixel):
5373 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5374 These aren't needed now that we assume ANSI C.
5375
96f53c6c
PE
5376 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5377 It's more likely to cause problems (due to unsigned overflow)
5378 than to cure them.
5379
83c77d31
PE
5380 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5381
ee2079f1
PE
5382 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5383
6da65536
PE
5384 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5385
7147c4a4
PE
5386 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5387
193e32d9
PE
5388 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5389
e5533da6
PE
5390 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5391
9910e595
PE
5392 GLYPH_CODE_FACE returns EMACS_INT, not int.
5393 * dispextern.h (merge_faces):
5394 * xfaces.c (merge_faces):
01103c44
PE
5395 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5396 Don't assume EMACS_INT fits in int.
9910e595 5397
2638320e
PE
5398 * character.h (CHAR_VALID_P): Remove unused parameter.
5399 * fontset.c, lisp.h, xdisp.c: All uses changed.
5400
045eb8d9
PE
5401 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5402
c1f134b5
PE
5403 * fns.c (concat): Minor tuning based on overflow analysis.
5404 This doesn't fix any bugs. Use int to hold character, instead
5405 of constantly refetching from Emacs object. Use XFASTINT, not
5406 XINT, for value known to be a character. Don't bother comparing
5407 a single byte to 0400, as it's always less.
5408
395fcb93 5409 * floatfns.c (Fexpt):
327eeec8
PE
5410 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5411
abbd3d23
PE
5412 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5413 for characters.
5414
684a03ef
PE
5415 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5416
0fed43f3
PE
5417 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5418 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5419 incorrectly succeed when S was a string, because 4294967386 was
5420 truncated before it was used.
5421
8fd02eb7
PE
5422 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5423 Otherwise, an out-of-range integer could cause undefined behavior
5424 on a 64-bit host.
5425
f8c86b69
PE
5426 * composite.c: Use int, not EMACS_INT, for characters.
5427 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5428 EMACS_INT, for values that are known to be in character range.
5429 This doesn't fix any bugs but is the usual style inside Emacs and
5430 may generate better code on 32-bit machines.
5431
34206dd2
PE
5432 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5433 This is for reasons similar to the recent CHAR_STRING fix.
5434 * charset.c (Fencode_char): Check that character arg is actually
5435 a character. Pass an int to ENCODE_CHAR.
5436 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5437 wider than 'int', as a compile-time check to prevent future regressions
5438 in this area.
5439
c5958d4c 5440 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5441
5442 Make sure a 64-bit char is never passed to CHAR_STRING.
5443 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5444 by silently ignoring the top 32 bits, allowing some values
5445 that were far too large to be valid characters.
5446 * character.h: Include <verify.h>.
5447 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5448 arguments are no wider than unsigned, as a compile-time check
5449 to prevent future regressions in this area.
5450 * data.c (Faset):
01103c44 5451 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5452 (Fsubst_char_in_region):
5453 * fns.c (concat):
5454 * xdisp.c (decode_mode_spec_coding):
5455 Adjust to CHAR_STRING's new requirement.
5456 * editfns.c (Finsert_char, Fsubst_char_in_region):
5457 * fns.c (concat): Check that character args are actually
5458 characters. Without this test, these functions did the wrong
5459 thing with wildly out-of-range values on 64-bit hosts.
5460
d37ca623
PE
5461 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5462 These casts should not be needed on 32-bit hosts, either.
5463 * keyboard.c (read_char):
5464 * lread.c (Fload): Remove casts to unsigned.
5465
ea204efb
PE
5466 * lisp.h (UNSIGNED_CMP): New macro.
5467 This fixes comparison bugs on 64-bit hosts.
5468 (ASCII_CHAR_P): Use it.
5469 * casefiddle.c (casify_object):
01103c44 5470 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5471 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5472 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5473 * dispextern.h (FACE_FROM_ID):
5474 * keyboard.c (read_char): Use UNSIGNED_CMP.
5475
41cb286c
PE
5476 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5477 not to EMACS_INT, to avoid GCC warning.
5478
4a1b9832
PE
5479 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5480
55daad71
PE
5481 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5482 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5483 isn't needed on 32-bit machines.
8f95c75c 5484
01103c44
PE
5485 * buffer.c (Fgenerate_new_buffer_name):
5486 Use EMACS_INT for count, not int.
0ceccced 5487 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5488
5489 * data.c (Qcompiled_function): Now static.
5490
c6f072e7
PE
5491 * window.c (window_body_lines): Now static.
5492
20ce5912
PE
5493 * image.c (gif_load): Rename local to avoid shadowing.
5494
9c4c5f81
PE
5495 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5496 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5497 * alloc.c (make_save_value): Integer argument is now of type
5498 ptrdiff_t, not int.
5499 (mark_object): Use ptrdiff_t, not int.
5500 * lisp.h (pD): New macro.
5501 * print.c (print_object): Use it.
5502
c0c5c8ae
PE
5503 * alloc.c: Use EMACS_INT, not int, to count objects.
5504 (total_conses, total_markers, total_symbols, total_vector_size)
5505 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5506 (total_free_floats, total_floats, total_free_intervals)
5507 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5508 Now EMACS_INT, not int. All uses changed.
5509 (Fgarbage_collect): Compute overall total using a double, so that
5510 integer overflow is less likely to be a problem. Check for overflow
5511 when converting back to an integer.
5a25e253
PE
5512 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5513 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5514 These were 'int' variables that could overflow on 64-bit hosts;
5515 they were never used, so remove them instead of repairing them.
211a0b2a 5516 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5517 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5518 Previously, this ceilinged at INT_MAX, but that doesn't work on
5519 64-bit machines.
e46bb31a 5520 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5521
c78baabf 5522 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5523 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5524 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5525 when a (possibly-narrower) signed value would do just as well.
5526 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5527
c9d624c6
PE
5528 * alloc.c: Catch some string size overflows that we were missing.
5529 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5530 for convenience in STRING_BYTES_MAX.
5531 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5532 The definition here is exact; the one in lisp.h was approximate.
5533 (allocate_string_data): Check for string overflow. This catches
5534 some instances we weren't catching before. Also, it catches
5535 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5536 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5537 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5538
c9d624c6
PE
5539 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5540 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5541 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5542
353032ce
PE
5543 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5544
2bccce07
PE
5545 * alloc.c (Fmake_string): Check for out-of-range init.
5546
0ac30604
SM
55472011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5548
5549 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5550
c195f2de
JD
55512011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5552
5553 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5554 xg_get_default_scrollbar_width.
5555
5556 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5557 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5558 (style_changed_cb): Call update_theme_scrollbar_width and call
5559 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5560 all frames (Bug#8505).
5561 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5562 Call gtk_window_set_resizable if HAVE_GTK3.
5563 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5564 and height if HAVE_GTK3 (Bug#8505).
5565 (scroll_bar_width_for_theme): New variable.
5566 (update_theme_scrollbar_width): New function.
5567 (xg_get_default_scrollbar_width): Move code to
5568 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5569 (xg_initialize): Call update_theme_scrollbar_width.
5570
5571 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5572
5573 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5574
e10ac9f1
MR
55752011-06-12 Martin Rudalics <rudalics@gmx.at>
5576
5577 * frame.c (make_frame): Call other_buffer_safely instead of
5578 other_buffer.
5579
5580 * window.c (temp_output_buffer_show): Call display_buffer with
5581 second argument Vtemp_buffer_show_specifiers and reset latter
5582 immediately after the call.
5583 (Vtemp_buffer_show_specifiers): New variable.
5584 (auto_window_vscroll_p, next_screen_context_lines)
5585 (Vscroll_preserve_screen_position): Remove leading asterisks from
5586 doc-strings.
5587
2d3c217e 55882011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5589
7b7f97e8 5590 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5591 * buffer.c (Qclone_number): Remove for now, as it's unused.
5592 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5593 (record_buffer): Remove unused local.
5594 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5595 (set_frame_buffer_list): Remove; unused.
5596 * frame.h (other_visible_frames): Remove decl.
5597 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5598 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5599 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5600 if HAVE_GPM.
5601 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5602 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5603 Define only if HAVE_GPM.
5604 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5605 (update_hints_inhibit): Remove; never set. All uses removed.
5606 * widgetprv.h (emacsFrameClassRec): Remove decl.
5607 * window.c (delete_deletable_window): Now returns void, since it
5608 wasn't returning anything.
5609 (compare_window_configurations): Remove unused locals.
5610 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5611 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5612 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5613 the same widths as pointers. This follows up on the 2011-05-06 patch.
5614 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5615 * xterm.h: Likewise.
5616 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5617
1384b89e
JB
56182011-06-12 Juanma Barranquero <lekktu@gmail.com>
5619
5620 * makefile.w32-in: Update dependencies.
5621 (LISP_H): Add lib/intprops.h.
5622
1100a63c
CY
56232011-06-11 Chong Yidong <cyd@stupidchicken.com>
5624
5625 * image.c (gif_load): Add animation frame delay to the metadata.
5626 (syms_of_image): Use DEFSYM. New symbol `delay'.
5627
6198ccd0
MR
56282011-06-11 Martin Rudalics <rudalics@gmx.at>
5629
5630 * window.c (delete_deletable_window): Re-add.
5631 (Fset_window_configuration): Rewrite to handle dead buffers and
5632 consequently deletable windows.
5633 (window_tree, Fwindow_tree): Remove. Supply functionality in
5634 window.el.
5635 (compare_window_configurations): Simplify code.
5636
b6e3633c
AS
56372011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5638
1ab0dee5
AS
5639 * image.c (imagemagick_load_image): Fix type mismatch.
5640 (Fimagemagick_types): Likewise.
5641
b6e3633c
AS
5642 * window.h (replace_buffer_in_windows): Declare.
5643
9397e56f
MR
56442011-06-11 Martin Rudalics <rudalics@gmx.at>
5645
5646 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5647 Qclone_number. Remove external declaration of Qdelete_window.
5648 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5649 code.
640c8776
SM
5650 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5651 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5652 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5653 buffer list implementation.
5654 (other_buffer_safely): New function.
5655 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5656 calls to replace_buffer_in_windows and
5657 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5658 if allowed.
5659 (record_buffer): Inhibit quitting and rewrite using quittable
5660 functions. Run Qbuffer_list_update_hook if allowed.
5661 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5662 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5663 Move switch-to-buffer to window.el.
9397e56f
MR
5664 (bury-buffer): Move to window.el.
5665 (Vbuffer_list_update_hook): New variable.
5666
5667 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5668 section.
5669
5670 * window.h (resize_frame_windows): Move up in code.
5671 (Fwindow_frame): Remove EXFUN.
5672 (replace_buffer_in_all_windows): Remove prototype.
5673 (replace_buffer_in_windows_safely): Add prototype.
5674
5675 * window.c: Declare Qdelete_window static again. Move down
5676 declaration of select_count.
5677 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5678 (Fother_window): Move to window.el.
5679 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5680 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5681 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5682 window.el.
5683 (replace_buffer_in_windows): Implement by calling
5684 Qreplace_buffer_in_windows.
5685 (replace_buffer_in_all_windows): Remove with some functionality
5686 moved into replace_buffer_in_windows_safely.
5687 (replace_buffer_in_windows_safely): New function.
5688 (select_window_norecord, select_frame_norecord): Move in front
5689 of run_window_configuration_change_hook. Remove now obsolete
5690 declarations.
640c8776
SM
5691 (Fset_window_buffer): Rewrite doc-string.
5692 Call Qrecord_window_buffer.
9397e56f
MR
5693 (keys_of_window): Move binding for other-window to window.el.
5694
b50691aa
CY
56952011-06-11 Chong Yidong <cyd@stupidchicken.com>
5696
5697 * dispextern.h (struct image): Replace data member, whose int_val
5698 and ptr_val fields were not used by anything, with a single
5699 lisp_val object.
5700
5701 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5702 (gif_clear_image, gif_load, imagemagick_load_image)
5703 (gs_clear_image, gs_load): Callers changed.
5704
3f754b86
PE
57052011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5706
cca69397
PE
5707 * buffer.h: Include <time.h>, for time_t.
5708 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5709
109e28d0
PE
5710 Fix minor problems found by static checking.
5711
60737f02
PE
5712 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5713
4b66faf3
PE
5714 Make identifiers static if they are not used in other modules.
5715 * data.c (Qcompiled_function, Qframe, Qvector):
5716 * image.c (QimageMagick, Qsvg):
5717 * minibuf.c (Qmetadata):
5718 * window.c (resize_window_check, resize_root_window): Now static.
5719 * window.h (resize_window_check, resize_root_window): Remove decls.
5720
109e28d0
PE
5721 * window.c (window_deletion_count, delete_deletable_window):
5722 Remove; unused.
46a4ce9e
PE
5723 (window_body_lines): Now static.
5724 (Fdelete_other_windows_internal): Mark vars as initialized.
5725 Make sure 'resize_failed' is initialized.
5726 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5727 (resize_window_apply): Remove unused local.
5728 * window.h (delete_deletable_window): Remove decl.
5729
109e28d0 5730 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5731 (imagemagick_load_image): Fix pointer signedness problem by changing
5732 last arg from unsigned char * to char *. All uses changed.
5733 Also, fix a local for similar reasons.
5734 Remove unused locals. Remove locals to avoid shadowing.
5735 (fn_rsvg_handle_free): Remove; unused.
5736 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5737 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5738
3f754b86
PE
5739 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5740
2547adb1
CY
57412011-06-10 Chong Yidong <cyd@stupidchicken.com>
5742
5743 * image.c (gif_load): Fix omitted cast error introduced by
5744 2011-06-06 change.
5745
2c8e37d4
MR
57462011-06-10 Martin Rudalics <rudalics@gmx.at>
5747
5748 * window.h (resize_proportionally, orig_total_lines)
5749 (orig_top_line): Remove from window structure.
5750 (set_window_height, set_window_width, change_window_heights)
5751 (Fdelete_window): Remove prototypes.
5752 (resize_frame_windows): Remove duplicate declaration.
5753
440a42e3
EZ
57542011-06-10 Eli Zaretskii <eliz@gnu.org>
5755
5756 * window.h (resize_frame_windows, resize_window_check)
5757 (delete_deletable_window, resize_root_window)
5758 (resize_frame_windows): Declare prototypes.
5759
5760 * window.c (resize_window_apply): Make definition be "static" to
5761 match the prototype.
5762
562dd5e9
MR
57632011-06-10 Martin Rudalics <rudalics@gmx.at>
5764
5765 * window.c: Remove declarations of Qwindow_size_fixed,
5766 window_min_size_1, window_min_size_2, window_min_size,
5767 size_window, window_fixed_size_p, enlarge_window, delete_window.
5768 Remove static from declaration of Qdelete_window, it's
5769 temporarily needed by Fbury_buffer.
5770 (replace_window): Don't assign orig_top_line and
5771 orig_total_lines.
5772 (Fdelete_window, delete_window): Remove. Window deletion is
5773 handled by window.el.
640c8776
SM
5774 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5775 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5776 (Fdelete_other_windows): Remove. Deleting other windows is
5777 handled by window.el.
5778 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5779 handled in window.el.
5780 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5781 Window minimum sizes are handled in window.el.
5782 (shrink_windows, size_window, set_window_height)
5783 (set_window_width, change_window_heights, window_height)
5784 (window_width, CURBEG, CURSIZE, enlarge_window)
5785 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5786 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5787 handled in window.el.
5788 (make_dummy_parent): Rename to make_parent_window and give it a
5789 second argument horflag.
5790 (make_window): Don't set resize_proportionally any more.
5791 (Fsplit_window): Remove. Windows are split in window.el.
5792 (save_restore_action, save_restore_orig_size)
5793 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5794 Resize mini windows in window.el.
5795 (grow_mini_window, shrink_mini_window): Implement by calling
5796 Qresize_root_window_vertically, resize_window_check and
5797 resize_window_apply.
640c8776
SM
5798 (saved_window, Fset_window_configuration, save_window_save):
5799 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5800 resize_proportionally.
5801 (window_min_height, window_min_width): Move to window.el.
5802 (keys_of_window): Move bindings for delete-other-windows,
5803 split-window, delete-window and enlarge-window to window.el.
5804
5805 * buffer.c: Temporarily extern Qdelete_window.
5806 (Fbury_buffer): Temporarily call Qdelete_window instead of
5807 Fdelete_window (Fbury_buffer will move to window.el soon).
5808
5809 * frame.c (set_menu_bar_lines_1): Remove code handling
5810 orig_top_line and orig_total_lines.
5811
5812 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5813 set_window_height but set heights directly.
5814 (change_frame_size_1): Use resize_frame_windows.
5815
5816 * xdisp.c (init_xdisp): Don't use set_window_height but set
5817 heights directly.
5818
640c8776
SM
5819 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5820 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5821 run_window_configuration_change_hook.
5822
5823 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5824 instead of change_window_heights and run
5825 run_window_configuration_change_hook.
5826
1a13852e
MR
58272011-06-09 Martin Rudalics <rudalics@gmx.at>
5828
5829 * window.c (replace_window): Rename second argument REPLACEMENT to
5830 NEW. New third argument SETFLAG. Rewrite.
5831 (delete_window, make_dummy_parent): Call replace_window with
5832 third argument 1.
5833 (window_list_1): Move down in code.
5834 (run_window_configuration_change_hook): Move set_buffer part
5835 before select_frame_norecord part in order to unwind correctly.
5836 Rename count1 to count.
5837 (recombine_windows, delete_deletable_window, resize_root_window)
5838 (Fdelete_other_windows_internal)
5839 (Frun_window_configuration_change_hook, make_parent_window)
5840 (resize_window_check, resize_window_apply, Fresize_window_apply)
5841 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5842 (Fdelete_window_internal, Fresize_mini_window_internal):
5843 New functions.
1a13852e
MR
5844 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5845
f3d1777e
MR
58462011-06-08 Martin Rudalics <rudalics@gmx.at>
5847
496e208e
MR
5848 * window.h (window): Add some new members to window structure -
5849 normal_lines, normal_cols, new_total, new_normal, clone_number,
5850 splits, nest, prev_buffers, next_buffers.
5851 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5852 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5853
f3d1777e
MR
5854 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5855 Remove.
496e208e
MR
5856 (make_dummy_parent): Set new members of windows structure.
5857 (make_window): Move down in code. Handle new members of window
5858 structure.
5859 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5860 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5861 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5862 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5863 (Fset_window_next_buffers, Fset_window_clone_number):
5864 New functions.
496e208e
MR
5865 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5866 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5867 Doc-string fixes.
5868 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5869 Argument WINDOW can be now internal window too.
5870 (Fwindow_use_time): Move up in code.
5871 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5872 Rewrite doc-string.
5873 (Fset_window_configuration, saved_window)
5874 (Fcurrent_window_configuration, save_window_save): Handle new
5875 members of window structure.
b9e809c2
MR
5876 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5877 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5878 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5879 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5880 Qget_mru_window, Qresize_root_window,
5881 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5882 Qauto_buffer_name; staticpro them.
f3d1777e 5883
abde8f8c
MR
58842011-06-07 Martin Rudalics <rudalics@gmx.at>
5885
5886 * window.c (Fwindow_total_size, Fwindow_left_column)
5887 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5888 (Fwindow_list_1): New functions.
5889 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5890 (Fwindow_width, Fscroll_left, Fscroll_right):
5891 Use window_body_cols instead of window_box_text_cols.
5892 (delete_window, Fset_window_configuration):
5893 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5894 (delete_all_subwindows): Take a window as argument and not a
5895 structure. Rewrite.
190b47e6
MR
5896 (window_loop): Remove handling of GET_LRU_WINDOW and
5897 GET_LARGEST_WINDOW.
5898 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5899
5900 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5901 window_box_text_cols. delete_all_subwindows now takes a
5902 Lisp_Object as argument.
abde8f8c 5903
640c8776
SM
5904 * indent.c (compute_motion, Fcompute_motion):
5905 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5906
fa8a67e6
MR
5907 * frame.c (delete_frame): Call delete_all_subwindows with root
5908 window as argument.
5909
a54e3482
DC
59102011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5911
5912 * fns.c (Fputhash): Document return value.
5913
60002bf5
CY
59142011-06-06 Chong Yidong <cyd@stupidchicken.com>
5915
5916 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5917
0c671da6 59182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5919
b862a52a 5920 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5921
be44ca6c
PE
5922 Check for overflow when converting integer to cons and back.
5923 * charset.c (Fdefine_charset_internal, Fdecode_char):
5924 Use cons_to_unsigned to catch overflow.
5925 (Fencode_char): Use INTEGER_TO_CONS.
5926 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5927 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5928 * data.c (long_to_cons, cons_to_long): Remove.
5929 (cons_to_unsigned, cons_to_signed): New functions.
5930 These signal an error for invalid or out-of-range values.
5931 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5932 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5933 * font.c (Ffont_variation_glyphs):
5934 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5935 * lisp.h: Include <intprops.h>.
5936 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5937 (cons_to_signed, cons_to_unsigned): New decls.
5938 (long_to_cons, cons_to_long): Remove decls.
5939 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5940 (Fprimitive_undo): Use CONS_TO_INTEGER.
5941 * xfns.c (Fx_window_property): Likewise.
5942 * xselect.c: Include <limits.h>.
5943 (x_own_selection, selection_data_to_lisp_data):
5944 Use INTEGER_TO_CONS.
5945 (x_handle_selection_request, x_handle_selection_clear)
5946 (x_get_foreign_selection, Fx_disown_selection_internal)
5947 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5948 (lisp_data_to_selection_data): Use cons_to_unsigned.
5949 (x_fill_property_data): Use cons_to_signed.
5950 Report values out of range.
5951
d1f3d2af
PE
5952 Check for buffer and string overflow more precisely.
5953 * buffer.h (BUF_BYTES_MAX): New macro.
5954 * lisp.h (STRING_BYTES_MAX): New macro.
5955 * alloc.c (Fmake_string):
5956 * character.c (string_escape_byte8):
5957 * coding.c (coding_alloc_by_realloc):
5958 * doprnt.c (doprnt):
5959 * editfns.c (Fformat):
5960 * eval.c (verror):
5961 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5962 since they may not be the same number.
5963 * editfns.c (Finsert_char):
5964 * fileio.c (Finsert_file_contents):
5965 Likewise for BUF_BYTES_MAX.
5966
dd52fcea
PE
5967 * image.c: Use ptrdiff_t, not int, for sizes.
5968 (slurp_file): Switch from int to ptrdiff_t.
5969 All uses changed.
5970 (slurp_file): Check that file size fits in both size_t (for
5971 malloc) and ptrdiff_t (for sanity and safety).
5972
7f9bbdbb
PE
5973 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5974 if b->modtime has its maximal value.
5975
dfe18f82
PE
5976 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5977
84acfcf0
PE
5978 Don't assume time_t can fit into int.
5979 * buffer.h (struct buffer.modtime): Now time_t, not int.
5980 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5981 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5982
ccd9a01a
PE
5983 Minor fixes for signed vs unsigned integers.
5984 * character.h (MAYBE_UNIFY_CHAR):
5985 * charset.c (maybe_unify_char):
5986 * keyboard.c (read_char, reorder_modifiers):
5987 XINT -> XFASTINT, since the integer must be nonnegative.
5988 * ftfont.c (ftfont_spec_pattern):
5989 * keymap.c (access_keymap, silly_event_symbol_error):
5990 XUINT -> XFASTINT, since the integer must be nonnegative.
5991 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5992 since it makes no difference and we prefer signed.
5993 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5994 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5995 nonnegative.
5996
d6d100dd
SM
59972011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5998
5999 * window.h (Fwindow_frame): Declare.
6000
2b6148e4
PE
60012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6002
6003 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6004 (SPARE_MEMORY): Always define.
6005 (LARGE_REQUEST): Remove.
6006 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6007
f230ecc9
MR
60082011-06-06 Martin Rudalics <rudalics@gmx.at>
6009
727e958e
MR
6010 * lisp.h: Move EXFUNS for Fframe_root_window,
6011 Fframe_first_window and Fset_frame_selected_window to window.h.
6012
6013 * window.h: Move EXFUNS for Fframe_root_window,
6014 Fframe_first_window and Fset_frame_selected_window here from
6015 lisp.h.
6016
6017 * frame.c (Fwindow_frame, Fframe_first_window)
6018 (Fframe_root_window, Fframe_selected_window)
6019 (Fset_frame_selected_window): Move to window.c.
6020 (Factive_minibuffer_window): Move to minibuf.c.
6021 (Fother_visible_frames_p): New function.
6022
6023 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6024
f230ecc9
MR
6025 * window.c (decode_window, decode_any_window): Move up in code.
6026 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6027 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6028 (Fwindow_buffer): Move up and rewrite doc-string.
6029 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6030 (Fwindow_prev): New functions.
727e958e
MR
6031 (Fwindow_frame): Move here from frame.c. Accept any window as
6032 argument.
6033 (Fframe_root_window, Fframe_first_window)
6034 (Fframe_selected_window): Move here from frame.c. Accept frame
6035 or arbitrary window as argument. Update doc-strings.
6036 (Fminibuffer_window): Move up in code.
6037 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6038 (Fset_frame_selected_window): Move here from frame.c.
6039 Marginal rewrite.
727e958e
MR
6040 (Fselected_window, select_window, Fselect_window): Move up in
6041 code. Minor doc-string fixes.
f230ecc9 6042
4d09bcf6
PE
60432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6044
6045 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6046 Do not assume that spare memory exists; that assumption is valid
6047 only if SYSTEM_MALLOC.
6048 (LARGE_REQUEST): New macro, so that the issue of large requests
6049 is separated from the issue of spare memory.
6050
810928a2
AS
60512011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6052
172418ad
AS
6053 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6054 format. (Bug#8806)
6055
43f862f7
AS
6056 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6057
810928a2
AS
6058 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6059 before statements.
6060
a059fe24
JD
60612011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6062
6063 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6064
6065 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6066
6067 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6068 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6069
989bf368
JB
60702011-06-05 Juanma Barranquero <lekktu@gmail.com>
6071
6072 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6073
4b80f674
CY
60742011-06-04 Chong Yidong <cyd@stupidchicken.com>
6075
6076 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6077 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6078 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6079 New error handlers.
4b80f674
CY
6080 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6081 Obey Vx_select_enable_clipboard_manager. Catch errors in
6082 x_clipboard_manager_save (Bug#8779).
6083 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6084 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6085
99a33b77 60862011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6087
6088 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6089
99a33b77 60902011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6091
6092 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6093 in the current matrix if keep_current_p is non-zero.
6094
8264569d
EZ
60952011-06-04 Eli Zaretskii <eliz@gnu.org>
6096
6097 * bidi.c (bidi_level_of_next_char): Fix last change.
6098
57f97249
EZ
60992011-06-03 Eli Zaretskii <eliz@gnu.org>
6100
fec2107c 6101 Support bidi reordering of text covered by display properties.
57f97249 6102
fec2107c
EZ
6103 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6104 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6105 (bidi_cache_search, bidi_cache_iterator_state)
6106 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6107 (bidi_level_of_next_char, bidi_move_to_visually_next):
6108 Support character positions inside a run of characters covered by a
fec2107c
EZ
6109 display string.
6110 (bidi_paragraph_init, bidi_resolve_explicit_1)
6111 (bidi_level_of_next_char): Call bidi_fetch_char and
6112 bidi_fetch_char_advance instead of FETCH_CHAR and
6113 FETCH_CHAR_ADVANCE.
6114 (bidi_init_it): Initialize new members.
6115 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6116 definitions.
6117 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6118 instead of using explicit *_CHAR codes.
d6d100dd
SM
6119 (bidi_resolve_explicit, bidi_resolve_weak):
6120 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6121 bidirectional text is supported only in multibyte buffers.
6122 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6123 it to initialize the frame_window_p member of struct bidi_it.
6124 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6125 (bidi_resolve_explicit, bidi_resolve_weak)
6126 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6127 bidi_it->nchars is non-positive.
6128 (bidi_level_of_next_char): Don't try to lookup the cache for the
6129 next/previous character if nothing is cached there yet, or if we
6130 were just reseat()'ed to a new position.
c40e2fb2 6131
0e14fe90
EZ
6132 * xdisp.c (set_cursor_from_row): Set start and stop points
6133 according to the row's direction when priming the loop that looks
6134 for the glyph on which to display cursor.
6135 (single_display_spec_intangible_p): Function deleted.
6136 (display_prop_intangible_p): Reimplement to call
6137 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6138 Accept 3 additional arguments needed by handle_display_spec.
6139 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6140 values: lists, `(when COND...)' forms, etc.
6141 (single_display_spec_string_p): Support property values that are
6142 lists with the argument STRING its top-level element.
6143 (display_prop_string_p): Fix the condition for processing a
6144 property that is a list to be consistent with handle_display_spec.
fec2107c 6145 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6146 last portion of handle_display_prop.
6147 (compute_display_string_pos): Accept additional argument
6148 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6149 value of a `display' property is a "replacing spec".
6150 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6151 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6152 the display property, but just return a value indicating whether
6153 the display property will replace the characters it covers.
6154 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6155 frame_window_p members of struct bidi_it.
d6d100dd
SM
6156 (compute_display_string_pos, compute_display_string_end):
6157 New functions.
fec2107c
EZ
6158 (push_it): Accept second argument POSITION, where pop_it should
6159 jump to continue iteration.
6160 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6161
fec2107c
EZ
6162 * keyboard.c (adjust_point_for_property): Adjust the call to
6163 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6164
6165 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6166 (bidi_init_it): Update prototypes.
6167 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6168 (compute_display_string_pos, compute_display_string_end):
6169 Declare prototypes.
fec2107c
EZ
6170 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6171 EMACS_INT.
fc6f18ce 6172
40087514 61732011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6174
57f53182
PE
6175 Malloc failure behavior now depends on size of allocation.
6176 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6177 * lisp.h: Change signatures accordingly.
6178 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6179 All callers changed. (Bug#8762)
6180
6181 * gnutls.c: Use Emacs's memory allocators.
6182 Without this change, the gnutls library would invoke malloc etc.
6183 directly, which causes problems on non-SYNC_INPUT hosts, and which
6184 runs afoul of improving memory_full behavior. (Bug#8761)
6185 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6186 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6187 xfree instead of the default malloc, realloc, free.
6188 (Fgnutls_boot): No need to check for memory allocation failure,
6189 since xmalloc does that for us.
6190
ac32cd99 6191 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6192 * category.c (hash_get_category_set):
6193 * ccl.c (ccl_driver):
6194 * charset.c (Fdefine_charset_internal):
6195 * charset.h (struct charset.hash_index):
6196 * composite.c (get_composition_id, gstring_lookup_cache)
6197 (composition_gstring_put_cache):
6198 * composite.h (struct composition.hash_index):
6199 * dispextern.h (struct image.hash):
6200 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6201 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6202 (hashfn_equal, hashfn_user_defined, make_hash_table)
6203 (maybe_resize_hash_table, hash_lookup, hash_put)
6204 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6205 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6206 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6207 * image.c (make_image, search_image_cache, lookup_image)
6208 (xpm_put_color_table_h):
6209 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6210 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6211 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6212 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6213 * alloc.c (allocate_vectorlike):
6214 Check for overflow in vector size calculations.
6215 * ccl.c (ccl_driver):
6216 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6217 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6218 need to be updated by these changes.
40087514
PE
6219 * fns.c (make_hash_table, maybe_resize_hash_table):
6220 Check for integer overflow with large hash tables.
0de4bb68
PE
6221 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6222 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6223 (SXHASH_REDUCE): New macro.
6224 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6225 Use it instead of discarding useful hash info with large hash values.
6226 (sxhash_float): New function.
6227 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6228 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6229 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6230 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6231 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6232 Adjust signatures to match updated version of code.
6233 (consing_since_gc): Now EMACS_INT, since a single hash table can
6234 use more than INT_MAX bytes.
6235
698d32e2
DN
62362011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6237
6238 Make it possible to build with GCC-4.6+ -O2 -flto.
6239
6240 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6241
fd6fa53f
SM
62422011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6243
6244 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6245 Call minibuffer-inactive-mode.
6246
864db017
JB
62472011-05-31 Juanma Barranquero <lekktu@gmail.com>
6248
6249 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6250 Update dependencies.
6251
2ad0baf4
DN
62522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6253
6254 * data.c (init_data): Remove code for UTS, this system is not
6255 supported anymore.
6256
4fcc2638
DN
62572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6258
6259 Don't force ./temacs to start in terminal mode.
6260
6261 * frame.c (make_initial_frame): Initialize faces in all cases, not
6262 only when CANNOT_DUMP is defined.
6263 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6264
c56e0fd5
DN
62652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6266
6267 * dispnew.c (add_window_display_history): Use const for the string
6268 pointer. Remove declaration, not needed.
6269
333d54da 62702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6271
55d4c1b2 6272 Use 'inline', not 'INLINE'.
333d54da 6273 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6274 * alloc.c, fontset.c (INLINE): Remove.
6275 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6276 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6277 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6278 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6279 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6280
738db178
DN
62812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6282
6283 Make it possible to run ./temacs.
6284
6285 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6286 syms_of_callproc does the same thing. Remove test for
6287 "initialized", do it in the caller.
6288 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6289
620c53a6
SM
62902011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6291
6292 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6293 (read_minibuf): Use get_minibuffer.
6294 (syms_of_minibuf): Use DEFSYM.
6295 (Qmetadata): New var.
6296 * data.c (Qbuffer): Don't make it static.
6297 (syms_of_data): Use DEFSYM.
6298
e003a292
PE
62992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6300
6301 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6302 (CCL_CODE_MIN): New macro.
6303
ed008a6d
PE
63042011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6305
3687c2ef
PE
6306 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6307
ed008a6d
PE
6308 * eval.c (Qdebug): Now static.
6309 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6310 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6311 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6312
d66c4c7c
CY
63132011-05-29 Chong Yidong <cyd@stupidchicken.com>
6314
6315 * image.c: Various fixes to ImageMagick code comments.
6316 (Fimagemagick_types): Doc fix.
6317
5fbc2025
PE
63182011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6319
0196f88a
PE
6320 Minor fixes prompted by GCC 4.6.0 warnings.
6321
6322 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6323
5fbc2025
PE
6324 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6325 (x_clipboard_manager_save_all): Move extern decl to ...
6326 * xterm.h: ... here, so that it can be checked for consistency.
6327
1dd3c2d9
CY
63282011-05-29 Chong Yidong <cyd@stupidchicken.com>
6329
6330 * xselect.c (x_clipboard_manager_save_frame)
6331 (x_clipboard_manager_save_all): New functions.
6332 (Fx_clipboard_manager_save): Lisp function deleted.
6333
6334 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6335 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6336
6337 * xterm.h: Update prototype.
6338
5ba6571d
WX
63392011-05-28 William Xu <william.xwl@gmail.com>
6340
6341 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6342 exiting (Bug#8239).
6343
3eaff834
JM
63442011-05-28 Jim Meyering <meyering@redhat.com>
6345
e1900994 6346 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6347 * fns.c (to_uchar): Define.
6348 (crypto_hash_function): Use it to convert some newly-signed
6349 variables to unsigned, to avoid sign-extension bugs. For example,
6350 without this change, (md5 "truc") would evaluate to
6351 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6352 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6353 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6354
0f6990a7
PE
63552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6356
6357 Integer overflow fixes.
c8a9ca5a 6358
08686060
PE
6359 * dbusbind.c: Serial number integer overflow fixes.
6360 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6361 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6362 to hold a serial number that is too large for a fixnum.
6363 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6364 Check for serial numbers out of range. Decode any serial number
59568bf0 6365 that was so large that it became a float. (Bug#8722)
08686060 6366
2d1fc3c7
PE
6367 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6368 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6369 Use XFASTINT rather than XUINT when numbers are nonnegative.
6370 (xd_append_arg, Fdbus_method_return_internal):
6371 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6372 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6373 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6374 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6375 (Bug#8722)
2d1fc3c7 6376
c8a9ca5a
PE
6377 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6378
519e1d69
PE
6379 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6380
6df6ae42 6381 ccl: Add integer overflow checks.
30569699
PE
6382 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6383 (IN_INT_RANGE): New macros.
6384 (ccl_driver): Use them to check for integer overflow when
6385 decoding a CCL program. Many of the new checks are whether XINT (x)
6386 fits in int; it doesn't always, on 64-bit hosts. The new version
6387 doesn't catch all possible integer overflows, but it's an
847044ea 6388 improvement. (Bug#8719)
30569699 6389
c11285dc
PE
6390 * alloc.c (make_event_array): Use XINT, not XUINT.
6391 There's no need for unsigned here.
6392
fdccd48e
PE
6393 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6394 This follows up to the 2011-05-06 change that substituted uintptr_t
6395 for EMACS_INT. This case wasn't caught back then.
6396
37910ab2
PE
6397 Rework Fformat to avoid integer overflow issues.
6398 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6399 now (part of C89). Include <verify.h>.
6400 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6401 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6402 (Fformat): Avoid the prepass trying to compute sizes; it was only
6403 approximate and thus did not catch overflow reliably. Instead, walk
6404 through the format just once, formatting and computing sizes as we go,
6405 checking for integer overflow at every step, and allocating a larger
6406 buffer as needed. Keep track separately whether the format is
6407 multibyte. Keep only the most-recently calculated precision, rather
6408 than them all. Record whether each argument has been converted to
6409 string. Use EMACS_INT, not int, for byte and char and arg counts.
6410 Support field widths and precisions larger than INT_MAX. Avoid
6411 sprintf's undefined behavior with conversion specifications such as %#d
6412 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6413 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6414 formatting out-of-range floating point numbers with int
9173deec 6415 formats. (Bug#8668)
37910ab2 6416
2e6578fb
PE
6417 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6418
0ae6bdee
PE
6419 * data.c: Avoid integer truncation in expressions involving floats.
6420 * data.c: Include <intprops.h>.
6421 (arith_driver): When there's an integer overflow in an expression
6422 involving floating point, convert the integers to floating point
6423 so that the resulting value does not suffer from catastrophic
6424 integer truncation. For example, on a 64-bit host (* 4
6425 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6426 Do not rely on undefined behavior after integer overflow.
6427
de883a70
PE
6428 merge count_size_as_multibyte, parse_str_to_multibyte
6429 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6430 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6431 Check for integer overflow.
6432 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6433 since it's now a duplicate of the other. This is more of
6434 a character than a buffer op, so better that it's in character.c.
6435 * fns.c, print.c: Adjust to above changes.
6436
2ff916cb
PE
64372011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6438
6439 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6440
f1b54466
PE
64412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6442
fb1ac845
PE
6443 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6444 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6445 (x_clipboard_manager_save): Now static.
6446 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6447
f1b54466
PE
6448 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6449 (crypto_hash_function): Now static.
6450 Fix pointer signedness problems. Avoid unnecessary initializations.
6451
a9f737ee
CY
64522011-05-27 Chong Yidong <cyd@stupidchicken.com>
6453
6454 * termhooks.h (Vselection_alist): Make it terminal-local.
6455
6456 * terminal.c (create_terminal): Initialize it.
6457
6458 * xselect.c: Support for clipboard managers.
6459 (Vselection_alist): Move to termhooks.h as terminal-local var.
6460 (LOCAL_SELECTION): New macro.
6461 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6462 (symbol_to_x_atom): Remove gratuitous arg.
6463 (x_handle_selection_request, lisp_data_to_selection_data)
6464 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6465 (x_own_selection, x_get_local_selection, x_convert_selection):
6466 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6467 (some_frame_on_display): Delete unused function.
6468 (Fx_own_selection_internal, Fx_get_selection_internal)
6469 (Fx_disown_selection_internal, Fx_selection_owner_p)
6470 (Fx_selection_exists_p): New optional frame arg.
6471 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6472 (x_handle_selection_clear): Don't treat other terminals with the
6473 same keyboard specially. Use the terminal-local Vselection_alist.
6474 (x_clear_frame_selections): Use Frun_hook_with_args.
6475
6476 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6477
6478 * xterm.h: Add support for those atoms.
6479
e067f0c1
CY
64802011-05-26 Chong Yidong <cyd@stupidchicken.com>
6481
6482 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6483 (converted_selections, conversion_fail_tag): New global variables.
6484 (x_selection_request_lisp_error): Free the above.
6485 (x_get_local_selection): Remove unnecessary code.
6486 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6487 of converted selections stored in converted_selections.
6488 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6489 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6490 (x_convert_selection): New function.
6491 (x_handle_selection_event): Simplify.
6492 (x_get_foreign_selection): Don't ignore incoming requests while
6493 waiting for an answer; this will fail when we implement
6494 SAVE_TARGETS, and seems unnecessary anyway.
6495 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6496 (Vx_sent_selection_functions): Doc fix.
6497
0f4aebc0
LL
64982011-05-26 Leo Liu <sdl.web@gmail.com>
6499
6500 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6501
e61124cd
YM
65022011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6503
6504 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6505
6506 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6507 for fringe update if it has periodic bitmap.
ac389d0c 6508 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6509 and fringe_bitmap_periodic_p.
6510
6511 * fringe.c (get_fringe_bitmap_data): New function.
6512 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6513 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6514 row. Mark glyph row for fringe update if periodicity changed.
6515
6516 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6517 for fringe update unless it has periodic bitmap.
6518
f16d9837
KH
65192011-05-25 Kenichi Handa <handa@m17n.org>
6520
6521 * xdisp.c (get_next_display_element): Set correct it->face_id for
6522 a static composition.
6523
e1b90ef6
LL
65242011-05-24 Leo Liu <sdl.web@gmail.com>
6525
6526 * deps.mk (fns.o):
6527 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6528
6529 * fns.c (crypto_hash_function, Fsha1): New function.
6530 (Fmd5): Use crypto_hash_function.
6531 (syms_of_fns): Add Ssha1.
6532
7400048f
PE
65332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6534
6535 * gnutls.c: Remove unused macros.
6536 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6537 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6538 Remove macros that are defined and never used.
6539 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6540
abb71cf4
CY
65412011-05-22 Chong Yidong <cyd@stupidchicken.com>
6542
6543 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6544 (Fx_get_selection_internal): Minor cleanup.
6545 (Fx_own_selection_internal): Rename arguments for consistency with
6546 select.el.
6547
6307db39
PE
65482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6551
f3d4e0a4
CY
65522011-05-22 Chong Yidong <cyd@stupidchicken.com>
6553
6554 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6555
4d8ade89
YM
65562011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6557
6558 * dispnew.c (scrolling_window): Don't exclude the case that the
6559 last enabled row in the desired matrix touches the bottom boundary.
6560
32078c8d
GM
65612011-05-21 Glenn Morris <rgm@gnu.org>
6562
6563 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6564 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6565 and add some more files.
32078c8d 6566
7285dc67
EZ
65672011-05-20 Eli Zaretskii <eliz@gnu.org>
6568
6569 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6570 report_file_error introduced by the change from 2011-05-07.
6571
89d1bd22
PE
65722011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6573
6574 * systime.h (Time): Define only if emacs is defined.
6575 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6576 where the include path doesn't have X11/X.h by default. See
6577 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6578
cd394be1 65792011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6580
6581 * composite.c (find_automatic_composition): Fix previous change.
6582
b9704ad9
GM
65832011-05-20 Glenn Morris <rgm@gnu.org>
6584
6585 * lisp.mk: New file, split from Makefile.in.
6586 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6587 (shortlisp): Remove.
6588 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6589
4a720484
GM
65902011-05-19 Glenn Morris <rgm@gnu.org>
6591
6592 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6593 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6594 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6595 (lisp): Set the order to that of loadup.el.
6596 (shortlisp): Make it a copy of $lisp.
6597 (SOME_MACHINE_LISP): Remove.
6598 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6599 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6600
a28d4396
KH
66012011-05-18 Kenichi Handa <handa@m17n.org>
6602
6603 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6604 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6605 (find_automatic_composition): Mostly rewrite for efficiency.
6606
a2b1fa8e
JB
66072011-05-18 Juanma Barranquero <lekktu@gmail.com>
6608
6609 * makefile.w32-in: Update dependencies.
6610
8e1f5610
CS
66112011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6612
6613 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6614 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6615
7025ee00 66162011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6617
cdfa6eab
PE
6618 Fix some integer overflow issues, such as string length overflow.
6619
06d6db33
PE
6620 * insdel.c (count_size_as_multibyte): Check for string overflow.
6621
2b4560a8
PE
6622 * character.c (lisp_string_width): Check for string overflow.
6623 Use EMACS_INT, not int, for string indexes and lengths; in
6624 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6625 the resulting string length overflows an EMACS_INT; instead,
6626 report a string overflow if no precision given. When checking for
6627 precision exhaustion, use a check that cannot possibly have
6628 integer overflow. (Bug#8675)
6629 * character.h (lisp_string_width): Adjust to new signature.
6630
cb93f9be
PE
6631 * alloc.c (string_overflow): New function.
6632 (Fmake_string): Use it. This doesn't change behavior, but saves
6633 a few bytes and will simplify future changes.
6634 * character.c (string_escape_byte8): Likewise.
6635 * lisp.h (string_overflow): New decl.
6636
1a1f3366
PE
6637 Fixups, following up to the user-interface timestamp change.
6638 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6639 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6640 * msdos.c (mouse_get_pos): Likewise.
6641 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6642 * w32gui.h (Time): Define by including "systime.h" rather than by
6643 declaring it ourselves. (Bug#8664)
6644
d4e3e4d3
PE
6645 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6646 * image.c (clear_image_cache): Likewise.
6647
f6a24d19
PE
6648 * term.c (term_mouse_position): Don't assume time_t wraparound.
6649
08dc5ae6
PE
6650 Be more systematic about user-interface timestamps.
6651 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6652 and sometimes 'EMACS_UINT', to represent these timestamps.
6653 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6654 This makes the code easier to follow, and makes it easier to catch
6655 integer overflow bugs such as Bug#8664.
6656 * frame.c (Fmouse_position, Fmouse_pixel_position):
6657 Use Time, not unsigned long, for user-interface timestamps.
6658 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6659 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6660 * keyboard.h (last_event_timestamp): Likewise.
6661 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6662 * menu.h (xmenu_show): Likewise.
6663 * term.c (term_mouse_position): Likewise.
6664 * termhooks.h (struct input_event.timestamp): Likewise.
6665 (struct terminal.mouse_position_hook): Likewise.
6666 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6667 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6668 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6669 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6670 what it was before.
6671 * menu.h, termhooks.h: Include "systime.h", for Time.
6672
8e55734a
PE
6673 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6674 Don't assume that the difference between two unsigned long values
6675 can fit into an integer. At this point, we know button_down_time
6676 <= event->timestamp, so the difference must be nonnegative, so
6677 there's no need to cast the result if double-click-time is
6678 nonnegative, as it should be; check that it's nonnegative, just in
6679 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6680 apart (about 25 days). (Bug#8664)
8e55734a 6681
841f1b75 6682 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6683 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6684
3e26f69c
PE
6685 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6686 that always fit in int. Use a sentinel instead of a counter, to
6687 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6688 * frame.h (struct frame): Use int for menu_bar_items_used
6689 instead of EMACS_INT, since it always fits in int.
3e26f69c 6690
5cc152c0
PE
6691 * menu.c (grow_menu_items): Check for int overflow.
6692
d89eb65e
PE
6693 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6694
5235bd3e
PE
6695 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6696 Before, the code was not consistent. These values cannot exceed
6697 2**31 - 1 so there's no need to make them unsigned.
6698 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6699 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6700 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6701 as modifiers.
6702 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6703
bc827e23
PE
6704 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6705 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6706 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6707 presumably because the widths might not match.
6708
78eb494e
PE
6709 * window.c (size_window): Avoid needless test at loop start.
6710
04f2d78b
CB
67112011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6712
6713 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6714
d2fc7e3d 67152011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6716
6717 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6718
d2fc7e3d 67192011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6720
6721 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6722 `width' to `bar_area_x' and `bar_area_width', respectively.
6723 (x_scroll_run): Take account of fringe background extension.
6724
04f2d78b
CB
6725 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6726 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6727 `bar_area_width', respectively.
6728 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6729 background extension.
6730
79b70037
GM
67312011-05-10 Jim Meyering <meyering@redhat.com>
6732
6733 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6734
2f142cc5
JB
67352011-05-10 Juanma Barranquero <lekktu@gmail.com>
6736
6737 * image.c (Finit_image_library): Return t for built-in image types,
6738 like pbm and xbm. (Bug#8640)
6739
57679c86
AS
67402011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6741
6742 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6743
888c9e86
EZ
67442011-05-07 Eli Zaretskii <eliz@gnu.org>
6745
b0512a1d
EZ
6746 * w32console.c (Fset_screen_color): Doc fix.
6747 (Fget_screen_color): New function.
6748 (syms_of_ntterm): Defsubr it.
6749
7285dc67
EZ
6750 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6751 unlink the temporary file if Fcall_process didn't create it in the
6752 first place.
6753 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6754 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6755 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6756 cue to call_process_cleanup not to close that handle.
6757
4d3fcc8e
BK
67582011-05-07 Ben Key <bkey76@gmail.com>
6759
6760 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6761 one of two shell specific rules, either bootstrap-temacs-CMD or
6762 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6763 to the previous implementation of the bootstrap-temacs rule.
6764 The bootstrap-temacs-CMD rule is similar to the previous
6765 implementation of the bootstrap-temacs rule except that it
6766 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6767 variable.
6768
6769 These changes, along with some changes to nt/configure.bat,
6770 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6771 earlier fix to add support for --cflags and --ldflags options
6772 that include quotes so that it works whether make uses cmd or
6773 sh as the shell.
6774
b4289b64
MA
67752011-05-06 Michael Albinus <michael.albinus@gmx.de>
6776
6777 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6778 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6779 is a constant.
6780 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6781 a string. Handle both cases.
6782 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6783 (Fdbus_register_method): Use Qinvalid_function.
6784
af4c0e28
JB
67852011-05-06 Juanma Barranquero <lekktu@gmail.com>
6786
6787 * makefile.w32-in: Update dependencies.
6788 (LISP_H): Add inttypes.h and stdin.h.
6789 (PROCESS_H): Add unistd.h.
6790
c51453d9
EZ
67912011-05-06 Eli Zaretskii <eliz@gnu.org>
6792
6793 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6794 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6795
8ff0ac3c 67962011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6797
4c4b566b
PE
6798 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6799
aab2b9b5
PE
6800 * term.c (vfatal): Remove stray call to va_end.
6801 It's not needed and the C Standard doesn't allow it here anyway.
6802
c378da0b
PE
6803 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6804 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6805
288b08c7
PE
6806 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6807 bytes.
6808
e3601888
PE
6809 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6810
db6c0e74
PE
6811 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6812
dd5963ea
PE
6813 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6814
88c9450f
PE
6815 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6816
2f9442b8
PE
6817 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6818
c032b5f8
PE
6819 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6820 * charset.c (Fdefine_charset_internal): Don't initialize
6821 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6822 32-bit int (Bug#8600).
a108c10b
PE
6823
6824 * lread.c (read_integer): Be more consistent with string-to-number.
6825 Use string_to_number to do the actual conversion; this avoids
6826 rounding errors and fixes some other screwups. Without this fix,
6827 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6828 (digit_to_number): Move earlier, for benefit of read_integer.
6829 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6830 not a digit in any supported base. (Bug#8602)
a108c10b 6831
ad5f9eea
PE
6832 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6833
aec1708a
PE
6834 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6835 to match comment at start of function. This also removes a
6836 GCC warning about overflow in a 32+64-bit port.
6837
47be4ab5
PE
6838 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6839
371cac43
PE
6840 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6841 Reported by Stefan Monnier in
6842 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6843 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6844 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6845
d01a7826
PE
6846 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6847 (EMACS_UINTPTR): Likewise, with uintptr_t.
6848
7fd47d5c
PE
6849 * lisp.h: Prefer 64-bit EMACS_INT if available.
6850 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6851 on 32-bit hosts that have 64-bit int, so that they can access
6852 large files.
122b0c86
PE
6853 However, temporarily disable this change unless the temporary
6854 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6855
8727937b
PE
6856 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6857
8ac068ac
PE
6858 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6859 This removes an assumption that EMACS_INT and long are the same
6860 width as pointers. The assumption is true for Emacs porting targets
6861 now, but we want to make other targets possible.
6862 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6863 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6864 In the rest of the code, change types of integers that hold casted
6865 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6866 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6867 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6868 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6869 No need to cast type when ORing.
6870 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6871 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6872 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6873 assume EMACS_INT is the same width as char *.
6874 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6875 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6876 Remove no-longer-needed casts.
6877 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6878 (xg_tool_bar_help_callback, xg_make_tool_item):
6879 Use EMACS_INTPTR to hold an integer
6880 that will be cast to void *; this can avoid a GCC warning
6881 if EMACS_INT is not the same width as void *.
6882 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6883 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6884 (current_message_1, set_message_1):
6885 Use a local to convert to proper width without a cast.
6886 * xmenu.c (dialog_selection_callback): Likewise.
6887
ede49d71
PE
6888 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6889 Also, don't assume VALBITS / RAND_BITS is less than 5,
6890 and don't rely on undefined behavior when shifting a 1 left into
6891 the sign bit.
6892 * lisp.h (get_random): Change signature to match.
6893
2f30ecd0
PE
6894 * lread.c (hash_string): Use size_t, not int, for hash computation.
6895 Normally we prefer signed values; but hashing is special, because
6896 it's better to use unsigned division on hash table sizes so that
6897 the remainder is nonnegative. Also, size_t is the natural width
6898 for hashing into memory. The previous code used 'int', which doesn't
6899 retain enough info to hash well into very large tables.
6900 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6901
2a866e7b
PE
6902 * dbusbind.c: Don't possibly lose pointer info when converting.
6903 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6904 Use XPNTR rather than XHASH, so that the high-order bits of
6905 the pointer aren't lost when converting through void *.
6906
51639eac
PE
6907 * eval.c (Fautoload): Don't double-shift a pointer.
6908
92394119
PE
6909 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6910
dbdb9a7c
JB
69112011-05-06 Juanma Barranquero <lekktu@gmail.com>
6912
6913 * gnutls.c (DEF_GNUTLS_FN):
6914 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6915
db7a0b4f
AS
69162011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6917
6918 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6919 marker. (Bug#8610)
6920
cd394be1 69212011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6922
6923 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6924 New version that can reserve upto 2GB of heap space.
6925
f7ff1b0f 69262011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6927
6928 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6929
639c109b
TZ
69302011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6931
6932 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6933 `gnutls_certificate_set_x509_key_file'.
6934
d2127135
JB
69352011-05-05 Juanma Barranquero <lekktu@gmail.com>
6936
6937 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6938 Update dependencies.
6939
e968f4f3
JB
69402011-05-04 Juanma Barranquero <lekktu@gmail.com>
6941
6942 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6943 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6944 Remove unused parameter `fildes'.
6945 * process.c (read_process_output, send_process): Don't pass it.
6946
84d358f0
JB
69472011-05-04 Juanma Barranquero <lekktu@gmail.com>
6948
6949 Fix previous change: the library cache is defined in w32.c.
6950 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6951 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6952
0898ca10
JB
69532011-05-04 Juanma Barranquero <lekktu@gmail.com>
6954
6955 Implement dynamic loading of GnuTLS on Windows.
6956
6957 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6958 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6959 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6960 Declare.
6961
6962 * gnutls.c (Qgnutls_dll): Define.
6963 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6964 (gnutls_*): Declare function pointers.
6965 (init_gnutls_functions): New function to initialize function pointers.
6966 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6967 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6968 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6969 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6970 (emacs_gnutls_write, emacs_gnutls_read)
6971 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6972 (Fgnutls_available_p): New function.
6973 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6974 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6975 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6976
6977 * image.c: Include w32.h.
6978 (Vimage_type_cache): Delete.
6979 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6980 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6981 (w32_delayed_load): Move to w32.c.
6982
6983 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6984
6985 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6986 (w32_delayed_load): Move from image.c. When loading a library, record
6987 its filename in the :loaded-from property of the library id.
6988 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6989 Initialize and staticpro them.
6990 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6991
6992 * process.c: Include lisp.h before w32.h, not after.
6993 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6994 instead of gnutls_record_check_pending.
6995
6996 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6997
ff4de4aa
TZ
69982011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6999
7000 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7001 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7002 as passed in.
7003
abe95abb
JD
70042011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7005
7006 * xterm.c (x_set_frame_alpha): Do not set property on anything
7007 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7008
e16e55d4
JB
70092011-05-02 Juanma Barranquero <lekktu@gmail.com>
7010
7011 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7012
bafcf6a5
JB
70132011-05-02 Juanma Barranquero <lekktu@gmail.com>
7014
7015 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7016 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7017 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7018 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7019 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7020 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7021 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7022 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7023 (Qgnutls_bootprop_callbacks_verify): Make static.
7024
e7a6747f
AS
70252011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7026
19ed11ba
AS
7027 * callproc.c: Indentation fixup.
7028
e7a6747f 7029 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7030 (wait_for_termination, interruptible_wait_for_termination):
7031 Move after wait_for_termination_1.
e7a6747f 7032
1ef14cb4
LMI
70332011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7034
7035 * sysdep.c (interruptible_wait_for_termination): New function
7036 which is like wait_for_termination, but allows keyboard
7037 interruptions.
7038
7039 * callproc.c (Fcall_process): Add (:file "file") as an option for
7040 the STDOUT buffer.
7041 (Fcall_process_region): Ditto.
7042
330d880c
EZ
70432011-04-30 Eli Zaretskii <eliz@gnu.org>
7044
8db90b73
EZ
7045 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7046 rather than `XVECTOR (FOO)->size'.
7047
330d880c
EZ
7048 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7049 inttypes.h, as a gnulib replacement is used if it not available in
7050 system headers.
7051
15cbd324
EZ
70522011-04-21 Eli Zaretskii <eliz@gnu.org>
7053
7054 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7055 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7056 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7057
7058 * coding.c (coding_alloc_by_realloc): Error out if destination
7059 will grow beyond MOST_POSITIVE_FIXNUM.
7060 (decode_coding_emacs_mule): Abort if there isn't enough place in
7061 charbuf for the composition carryover bytes. Reserve an extra
7062 space for up to 2 characters produced in a loop.
7063 (decode_coding_iso_2022): Abort if there isn't enough place in
7064 charbuf for the composition carryover bytes.
7065
70662011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7067
ae940cca
EZ
7068 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7069 aborting when %lld or %lll format is passed.
7070 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7071 %llo or %llx format is passed. (Bug#8545)
7072
03ab8921
EZ
7073 * window.c (window_scroll_line_based): Use a marker instead of
7074 simple variables to record original value of point. (Bug#7952)
7075
afda1437
EZ
7076 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7077 produced by %s or %c overflows available buffer space. (Bug#8545)
7078
f76dee0c
PE
70792011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7080
7081 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7082 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7083
fdc5744d
JB
70842011-04-28 Juanma Barranquero <lekktu@gmail.com>
7085
7086 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7087
638f053a
JB
70882011-04-28 Juanma Barranquero <lekktu@gmail.com>
7089
7090 * keyboard.c (Qdelayed_warnings_hook): Define.
7091 (command_loop_1): Run `delayed-warnings-hook'
7092 if Vdelayed_warnings_list is non-nil.
7093 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7094 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7095
d178f871
EZ
70962011-04-28 Eli Zaretskii <eliz@gnu.org>
7097
7098 * doprnt.c (doprnt): Don't return value smaller than the buffer
7099 size if the message was truncated. (Bug#8545).
7100
b124fd93
JB
71012011-04-28 Juanma Barranquero <lekktu@gmail.com>
7102
7103 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7104 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7105
e810457d
PE
71062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7107
7108 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7109
ea51cceb
JB
71102011-04-27 Juanma Barranquero <lekktu@gmail.com>
7111
7112 * makefile.w32-in: Update dependencies.
7113
94dcfacf
EZ
71142011-04-27 Eli Zaretskii <eliz@gnu.org>
7115
7116 Improve `doprnt' and its usage. (Bug#8545)
7117 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7118 `format_end'. Remove support for %l as a conversion specifier.
7119 Don't use xrealloc. Improve diagnostics when the %l size modifier
7120 is used. Update the commentary.
7121
7122 * eval.c (verror): Simplify calculation of size_t.
7123
7124 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7125 messages.
7126
f61f41d7
PE
71272011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7128
7129 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7130 change.
7131
96fb4434
PE
71322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7133
7134 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7135 This makes this file independent of the recent pseudovector change.
7136
671875da 71372011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7138
69e9b5a3
PE
7139 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7140
b5f869a7 7141 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7142 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7143 Remove unused local.
c8926152 7144 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7145
841a1577 7146 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7147 GCC 4.6.0 optimizes based on type-based alias analysis.
7148 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7149 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7150 != &v->size, and therefore "v->size = 1; b->size = 2; return
7151 v->size;" must therefore return 1. This assumption is incorrect
7152 for Emacs, since it type-puns struct Lisp_Vector * with many other
7153 types. To fix this problem, this patch adds a new type struct
f904488f 7154 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7155 and pseudovectors, and helps optimizing compilers not get fooled
7156 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7157 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7158 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7159 the size member.
eab3844f
PE
7160 (XSETPVECTYPE): Rewrite in terms of new macro.
7161 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7162 This is a bit clearer, and further avoids the possibility of
7163 undesirable aliasing.
7164 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7165 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7166 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7167 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7168 (ASIZE): Now uses header.size rather than size.
7169 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7170 to avoid the hassle of writing XVECTOR (foo)->header.size.
7171 (struct vectorlike_header): New type.
eab3844f
PE
7172 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7173 object, to help avoid aliasing.
7174 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7175 (SUBRP): Likewise, since Lisp_Subr is a special case.
7176 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7177 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7178 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7179 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7180 changed to be "header.size" and "header.next".
7181 * buffer.h (struct buffer): Likewise.
7182 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7183 * frame.h (struct frame): Likewise.
7184 * process.h (struct Lisp_Process): Likewise.
7185 * termhooks.h (struct terminal): Likewise.
7186 * window.c (struct save_window_data, struct saved_window): Likewise.
7187 * window.h (struct window): Likewise.
7188 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7189 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7190 * buffer.c (init_buffer_once): Likewise.
7191 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7192 special case.
7193 * process.c (Fformat_network_address): Use local var for size,
7194 for brevity.
7195
0df1eac5
PE
7196 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7197
847ab9d1 7198 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7199 * data.c (atof): Remove decl; no longer used or needed.
7200 (digit_to_number): Move to lread.c.
7201 (Fstring_to_number): Use new string_to_number function, to be
7202 consistent with how the Lisp reader treats infinities and NaNs.
7203 Do not assume that floating-point numbers represent EMACS_INT
7204 without losing information; this is not true on most 64-bit hosts.
7205 Avoid double-rounding errors, by insisting on integers when
7206 parsing non-base-10 numbers, as the documentation specifies.
7207 * lisp.h (string_to_number): New decl, replacing ...
7208 (isfloat_string): Remove.
bc0a5c13 7209 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7210 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7211 appears to have been a coding error. Similarly, do not accept
7212 strings like +-1e0 as floating point numbers. Do not report
7213 overflow for integer overflows unless the base is not 10 which
7214 means we have no simple and reliable way to continue.
7215 Break out the floating-point parsing into a new
7216 function string_to_number, so that Fstring_to_number parses
7217 floating point numbers consistently with the Lisp reader.
04f2d78b 7218 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7219 (E_CHAR, EXP_INT): Remove, replacing with ...
7220 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7221 (string_to_number): New function, replacing isfloat_string.
7222 This function checks for valid syntax and produces the resulting
7223 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7224 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7225 so that overflow for non-base-10 numbers is reported only when
7226 there's no portable and simple way to convert to floating point.
452f4150 7227
67769ffc
PE
7228 * textprop.c (set_text_properties_1): Rewrite for clarity,
7229 and to avoid GCC warning about integer overflow.
7230
c20db43f
PE
7231 * intervals.h (struct interval): Use EMACS_INT for members
7232 where EMACS_UINT might cause problems. See
7233 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7234 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7235 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7236 All uses changed.
37aa2f85
PE
7237 (offset_intervals): Tell GCC not to worry about length overflow
7238 when negating a negative length.
c20db43f 7239
2538aa2f
PE
7240 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7241 (overrun_check_free): Likewise.
7242
f2d3008d
PE
7243 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7244 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7245 word size.
7246
ec8df744
PE
7247 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7248 (gnutls_make_error): Rename local to avoid shadowing.
7249 (gnutls_emacs_global_deinit): ifdef out; not used.
7250 (Fgnutls_boot): Use const for pointer to readonly storage.
7251 Comment out unused local. Fix pointer signedness problems.
7252
640ee02d
PE
7253 * lread.c (openp): Don't stuff size_t into an 'int'.
7254 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7255 about possible signed overflow.
7256
6048fb2a
PE
7257 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7258 (GDK_KEY_g): Don't define if already defined.
7259 (xg_prepare_tooltip): Avoid pointer signedness problem.
7260 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7261
fa3c87e1
PE
7262 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7263 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7264
2172544b
PE
7265 * xfns.c (Fx_window_property): Simplify a bit,
7266 to make a bit faster and to avoid GCC 4.6.0 warning.
7267 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7268
9b821a21
PE
7269 * fns.c (internal_equal): Don't assume size_t fits in int.
7270
3c616cfa
PE
7271 * alloc.c (compact_small_strings): Tighten assertion a little.
7272
c2982e87
PE
7273 Replace pEd with more-general pI, and fix some printf arg casts.
7274 * lisp.h (pI): New macro, generalizing old pEd macro to other
7275 conversion specifiers. For example, use "...%"pI"d..." rather
7276 than "...%"pEd"...".
7277 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7278 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7279 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7280 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7281 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7282 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7283 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7284 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7285 64-bit hosts.
7286 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7287 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7288 * print.c (safe_debug_print, print_object): Likewise.
7289 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7290 to int.
6f04d126
PE
7291 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7292 avoiding the 0 flag, which is not portable.
c2982e87
PE
7293 * process.c (Fmake_network_process): Use pI to avoid cast.
7294 * region-cache.c (pp_cache): Likewise.
7295 * xdisp.c (decode_mode_spec): Likewise.
7296 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7297 behavior on 64-bit hosts with printf arg.
6f04d126 7298 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7299 (x_stop_queuing_selection_requests): Likewise.
7300 (x_get_window_property): Don't truncate byte count to an 'int'
7301 when tracing.
0b432f21 7302
5e073ec7
PE
7303 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7304 here, since it parses constructs like leading '-' and spaces,
7305 which are not wanted; and it overflows with large numbers.
7306 Instead, simply match F[0-9]+, which is what is wanted anyway.
7307
36372bf9
PE
7308 * alloc.c: Remove unportable assumptions about struct layout.
7309 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7310 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7311 (allocate_vectorlike, make_pure_vector): Use the new macros,
7312 plus offsetof, to remove unportable assumptions about struct layout.
7313 These assumptions hold on all porting targets that I know of, but
7314 they are not guaranteed, they're easy to remove, and removing them
7315 makes further changes easier.
7316
0b432f21
PE
7317 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7318 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7319 (string_overrun_cookie): Now const. Use initializers that
7320 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7321 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7322 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7323 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7324 multiple of sizeof (EMACS_INT); it need not be, if
7325 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7326 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7327
895009e1
JB
73282011-04-26 Juanma Barranquero <lekktu@gmail.com>
7329
7330 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7331
6a7a1b0b
TZ
73322011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7333
7334 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7335 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7336 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7337
841a1577 73382011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7339
7340 * lisp.h (Qdebug): List symbol.
895009e1 7341 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7342 * keyboard.c (debug-on-event): New variable.
7343 (handle_user_signal): Break into debugger when debug-on-event
7344 matches the current signal symbol.
7345
f2d3ba6f
DN
73462011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7347
7348 * alloc.c (check_sblock, check_string_bytes)
7349 (check_string_free_list): Convert to standard C.
7350
42ce4c63
TZ
73512011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7352
7353 * w32.c (emacs_gnutls_push): Fix typo.
7354
825cd63c
EZ
73552011-04-25 Eli Zaretskii <eliz@gnu.org>
7356
fb11d64d
EZ
7357 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7358 "cast to pointer from integer of different size".
7359
825cd63c
EZ
7360 Improve doprnt and its use in verror. (Bug#8545)
7361 * doprnt.c (doprnt): Document the set of format control sequences
7362 supported by the function. Use SAFE_ALLOCA instead of always
7363 using `alloca'.
7364
7365 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7366 is one byte too soon. Don't use xrealloc; instead xfree and
7367 xmalloc anew.
7368
e061a11b
TZ
73692011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7370
7371 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7372 callbacks stage.
7373
7374 * gnutls.c: Renamed global_initialized to
7375 gnutls_global_initialized. Added internals for the
7376 :verify-hostname-error, :verify-error, and :verify-flags
7377 parameters of `gnutls-boot' and documented those parameters in the
7378 docstring. Start callback support.
9173deec
JB
7379 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7380 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7381 on error. Return error code.
e061a11b
TZ
7382 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7383 (emacs_gnutls_read): Likewise.
7384 (Fgnutls_boot): Return handshake error code.
7385 (emacs_gnutls_handle_error): New function.
7386 (wsaerror_to_errno): Likewise.
7387
7388 * w32.h (emacs_gnutls_pull): Add prototype.
7389 (emacs_gnutls_push): Likewise.
7390
7391 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7392 (emacs_gnutls_push): Likewise.
7393
73942011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7395
7396 * process.c (wait_reading_process_output): Check if GnuTLS
7397 buffered some data internally if no FDs are set for TLS
7398 connections.
7399
7400 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7401 (LIBS): Link to USER_LIBS.
7402 ($(BLD)/gnutls.$(0)): New target.
7403
fa6996bc
EZ
74042011-04-24 Eli Zaretskii <eliz@gnu.org>
7405
eb35682e
EZ
7406 * xdisp.c (handle_single_display_spec): Rename the
7407 display_replaced_before_p argument into display_replaced_p, to
7408 make it consistent with the commentary. Fix typos in the
7409 commentary.
7410
e2ad650c
EZ
7411 * textprop.c (syms_of_textprop): Remove dead code.
7412 (copy_text_properties): Delete obsolete commentary about an
7413 interface that was deleted long ago. Fix typos in the description
7414 of arguments.
7415
1b2de274
EZ
7416 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7417 to changes in oldXMenu/XMenu.h from 2011-04-16.
7418 <menu_help_message, prev_menu_help_message>: Constify.
7419 (IT_menu_make_room): menu->help_text is now `const char **';
7420 adjust.
7421
7422 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7423 to changes in oldXMenu/XMenu.h from 2011-04-16.
7424 (struct XMenu): Declare `help_text' `const char **'.
7425
7426 * xfaces.c <Qunspecified>: Make extern again.
7427
7428 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7429 required by POSIX.
1b2de274 7430
762b15be
EZ
7431 * doc.c (get_doc_string): Improve the format passed to `error'.
7432
7433 * doprnt.c (doprnt): Improve commentary.
7434
7435 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7436
7437 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7438 them with etags.
7439
f1052e5d
EZ
7440 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7441 changes in globals.h immediately force recompilation.
762b15be
EZ
7442 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7443 $(CURDIR)/s/ms-w32.h.
7444 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7445
fa6996bc
EZ
7446 * character.c (Fchar_direction): Function deleted.
7447 (syms_of_character): Don't defsubr it.
7448 <char-direction-table>: Deleted.
7449
e6c3da20
EZ
74502011-04-23 Eli Zaretskii <eliz@gnu.org>
7451
7452 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7453 * doprnt.c: Include limits.h.
7454 (SIZE_MAX): New macro.
04f2d78b
CB
7455 (doprnt): Return a size_t value. 2nd arg is now size_t.
7456 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7457 Improve overflow protection. Support `l' modifier for integer
7458 conversions. Support %l conversion. Don't assume an EMACS_INT
7459 argument for integer conversions and for %c.
7460
7461 * lisp.h (doprnt): Restore prototype.
7462
7463 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7464 $(SRC)/character.h.
7465
7466 * Makefile.in (base_obj): Add back doprnt.o.
7467
7468 * deps.mk (doprnt.o): Add back prerequisites.
7469 (callint.o): Depend on character.h.
7470
7471 * eval.c (internal_lisp_condition_case): Include the handler
7472 representation in the error message.
7473 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7474 when breaking from the loop.
7475
7476 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7477
7478 * callint.c (Fcall_interactively): When displaying error message
7479 about invalid control letter, pass the character's codepoint, not
7480 a pointer to its multibyte form. Improve display of the character
7481 in octal and display also its hex code.
7482
7483 * character.c (char_string): Use %x to display the (unsigned)
7484 codepoint of an invalid character, to avoid displaying a bogus
7485 negative value.
7486
7487 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7488 `error', not SYMBOL_NAME itself.
7489
7490 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7491 character arguments to `error'.
7492
7493 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7494 to `error' in error message about FINAL_CHAR argument. Make sure
7495 FINAL_CHAR is a character, and use %c when it is passed as
7496 argument to `error'.
7497
4ffd0d6b 74982011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7499
7500 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7501
7502 * w32.c: Include <time.h>.
7503 (sys_localtime): New function.
7504
4ffd0d6b 75052011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7506
7507 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7508
4ffd0d6b 7509 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7510
4ffd0d6b 75112011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7512
4ffd0d6b
GM
7513 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7514 zombies (Bug#8467).
aac0c6e3 7515
04c56954
EZ
75162011-04-19 Eli Zaretskii <eliz@gnu.org>
7517
7518 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7519 gl_state.e_property when gl_state.object is Qt.
7520
7521 * insdel.c (make_gap_larger): Remove limitation of buffer size
7522 to <= INT_MAX.
7523
16a43933
CY
75242011-04-18 Chong Yidong <cyd@stupidchicken.com>
7525
7526 * xdisp.c (lookup_glyphless_char_display)
7527 (produce_glyphless_glyph): Handle cons cell entry in
7528 glyphless-char-display.
7529 (Vglyphless_char_display): Document it.
7530
7531 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7532 glyphless-char-display.
7533
4581706e
CY
75342011-04-17 Chong Yidong <cyd@stupidchicken.com>
7535
7536 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7537
7538 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7539
7540 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7541 definition for no-X builds.
7542
4887c6e2 75432011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7544
fd35b6f9
PE
7545 Static checks with GCC 4.6.0 and non-default toolkits.
7546
5c1ccb01
PE
7547 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7548
006c5daa
PE
7549 * process.c (keyboard_bit_set): Define only if SIGIO.
7550 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7551 (send_process): Repair possible setjmp clobbering.
7552
efc736d3
PE
7553 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7554
4e2fe2e6
PE
7555 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7556
f97334a2
PE
7557 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7558
4e75f29d
PE
7559 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7560 Define only if needed.
7561
90efadd1
PE
7562 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7563 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7564 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7565
3c647824
PE
7566 * dispextern.h (struct redisplay_interface): Rename param
7567 to avoid shadowing.
e264f262 7568 * termhooks.h (struct terminal): Likewise.
761383f4 7569 * xterm.c (xembed_send_message): Likewise.
3c647824 7570
b58c5c4a
PE
7571 * insdel.c (make_gap_smaller): Define only if
7572 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7573
cad59032
PE
7574 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7575 it.
7576
c339dc2e
PE
7577 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7578 so that we aren't warned about unused symbols.
7579
91a3e27b
PE
7580 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7581
399c71d3 7582 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7583
8ffc96f5
PE
7584 * xfns.c (x_real_positions): Mark locals as initialized.
7585
eef9bc79
PE
7586 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7587
098db9dd
PE
7588 * xterm.c: Fix problems found by static analysis with other toolkits.
7589 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7590 (x_dispatch_event): Declare static if USE_GTK, and
7591 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7592 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7593 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7594 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7595 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7596
eb18f6cc
PE
7597 * xmenu.c (menu_help_callback): Pointer type fixes.
7598 Use const pointers when pointing at readonly data. Avoid pointer
7599 signedness clashes.
7600 (FALSE): Remove unused macro.
7601 (update_frame_menubar): Remove unused decl.
7602
1fe72bf8
PE
7603 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7604
60d9e1db
PE
7605 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7606 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7607 (single_menu_item): Rename local to avoid shadowing.
7608
39261c26
PE
7609 * keyboard.c (make_lispy_event): Remove unused local var.
7610
018c5e19
PE
7611 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7612 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7613
63d2b86e
PE
7614 * bitmaps: Change bitmaps from unsigned char back to the X11
7615 compatible char. Avoid the old compiler warnings about
7616 out-of-range initializers by using, for example, '\xab' rather
7617 than 0xab.
7618
aefd87e1
PE
7619 * xgselect.c (xgselect_initialize): Check vs interface
7620 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7621
bf501fb9
PE
7622 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7623
e9829fdf
PE
7624 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7625 to read-only memory.
7626
1086c095
PE
7627 * fns.c (vector): Remove; this old hack is no longer needed.
7628
2baccd04 7629 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7630 Remove unused var.
dde42981 7631 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7632
72391843 7633 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7634
436c16df 7635 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7636 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7637 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7638
92bb796d 7639 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7640 (x_term_init): Remove local to avoid shadowing.
92bb796d 7641
764430a3 7642 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7643
7644 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7645 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7646
d1dfb56c
EZ
76472011-04-16 Eli Zaretskii <eliz@gnu.org>
7648
c4354cb4
EZ
7649 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7650
d1dfb56c
EZ
7651 Fix regex.c, syntax.c and friends for buffers > 2GB.
7652 * syntax.h (struct gl_state_s): Declare character position members
7653 EMACS_INT.
7654
7655 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7656
04f2d78b
CB
7657 * textprop.c (verify_interval_modification, interval_of):
7658 Declare arguments EMACS_INT.
d1dfb56c
EZ
7659
7660 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7661 EMACS_INT.
7662
7663 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7664
7665 * indent.c (Fvertical_motion): Local variable it_start is now
7666 EMACS_INT.
7667
7668 * regex.c (re_match, re_match_2, re_match_2_internal)
7669 (bcmp_translate, regcomp, regexec, print_double_string)
7670 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7671 (re_compile_pattern, re_exec): Declare arguments and local
7672 variables `size_t' and `ssize_t' and return values `regoff_t', as
7673 appropriate.
7674 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7675 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7676 <compile_stack_type>: `size' and `avail' are now `size_t'.
7677
7678 * regex.h <regoff_t>: Use ssize_t, not int.
7679 (re_search, re_search_2, re_match, re_match_2): Arguments that
7680 specify buffer/string position and length are now ssize_t and
7681 size_t. Return type is regoff_t.
7682
613052cd
BK
76832011-04-16 Ben Key <bkey76@gmail.com>
7684
7685 * nsfont.m: Fixed bugs in ns_get_family and
7686 ns_descriptor_to_entity that were caused by using free to
7687 deallocate memory blocks that were allocated by xmalloc (via
7688 xstrdup). This caused Emacs to crash when compiled with
7689 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7690 --enable-checking=xmallocoverrun). xfree is now used to
7691 deallocate these memory blocks.
7692
4170f62f 76932011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7694
71b41406
PE
7695 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7696
9587a89d
PE
7697 emacs_write: Accept and return EMACS_INT for sizes.
7698 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7699 et seq.
7700 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7701 Accept and return EMACS_INT.
7702 (emacs_gnutls_write): Return the number of bytes written on
7703 partial writes.
7704 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7705 (emacs_read, emacs_write): Remove check for negative size, as the
7706 Emacs source code has been audited now.
9587a89d
PE
7707 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7708 (emacs_read, emacs_write): Use it.
273a5f82
PE
7709 * process.c (send_process): Adjust to the new signatures of
7710 emacs_write and emacs_gnutls_write. Do not attempt to store
7711 a byte offset into an 'int'; it might overflow.
9587a89d 7712 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7713
3e047f51
PE
7714 * sound.c: Don't assume sizes fit in 'int'.
7715 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7716 Return EMACS_INT, not int.
3e047f51 7717 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7718 Accept EMACS_INT, not int.
7719 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7720 record read return values.
7721
cc39a9db
BK
77222011-04-15 Ben Key <bkey76@gmail.com>
7723
c9d0ec6d
JB
7724 * keyboard.c (Qundefined): Don't declare static since it is used
7725 in nsfns.m.
7726 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7727 static since they are used in nsfont.m.
cc39a9db 7728
6c60eb9f
SM
77292011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7730
7731 * process.c (Qprocessp): Don't declare static.
7732 * lisp.h (Qprocessp): Declare again.
7733
7990b61a
JB
77342011-04-15 Juanma Barranquero <lekktu@gmail.com>
7735
7736 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7737
5d4cb038
PE
77382011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7739
8bd7b830 7740 Improve C-level modularity by making more things 'static'.
cd64ea1d 7741
e3b27b31
PE
7742 Don't publish debugger-only interfaces to other modules.
7743 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7744 (verify_bytepos, count_markers): Move decls to the only modules
7745 that need them.
7746 * region-cache.h (pp_cache): Likewise.
7747 * window.h (check_all_windows): Likewise.
7748 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7749
5d4cb038
PE
7750 * sysdep.c (croak): Now static, if
7751 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7752 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7753
7754 * alloc.c (refill_memory_reserve): Now static if
7755 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7756 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7757
e87b6180
PE
7758 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7759 Define only if USE_LUCID.
7760
ac64929e
PE
7761 * xrdb.c (x_customization_string, x_rm_string): Now static.
7762
6f37259d
PE
7763 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7764 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7765
1683e3ab
PE
7766 * xdisp.c (draw_row_with_mouse_face): Now static.
7767 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7768
de9c2632
PE
7769 * window.h (check_all_windows): Mark externally visible.
7770
2b96acb7
PE
7771 * window.c (window_deletion_count): Now static.
7772
7773 * undo.c: Make symbols static if they're not exported.
7774 (last_undo_buffer, last_boundary_position, pending_boundary):
7775 Now static.
7776
50436f33
PE
7777 * textprop.c (interval_insert_behind_hooks): Now static.
7778 (interval_insert_in_front_hooks): Likewise.
7779
64520e5c
PE
7780 * term.c: Make symbols static if they're not exported.
7781 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7782 (max_frame_lines, tty_set_terminal_modes):
7783 (tty_reset_terminal_modes, tty_turn_off_highlight):
7784 (get_tty_terminal): Now static.
7785 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7786 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7787 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7788 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7789 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7790
1fa53021
PE
7791 * sysdep.c: Make symbols static if they're not exported.
7792 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7793 Now static.
7794 (sigprocmask_set, full_mask): Remove; unused.
7795 (wait_debugging): Mark as visible.
7796 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7797 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7798
d4b43b22
PE
7799 * syntax.c (syntax_temp): Define only if !__GNUC__.
7800
b7c513d0
PE
7801 * sound.c (current_sound_device, current_sound): Now static.
7802
989b29ad
PE
7803 * search.c (searchbufs, searchbuf_head): Now static.
7804
13a55a78
PE
7805 * scroll.c (scroll_cost): Remove; unused.
7806 * dispextern.h (scroll_cost): Remove decl.
7807
de68a1fc
PE
7808 * region-cache.h (pp_cache): Mark as externally visible.
7809
40ccffa6
PE
7810 * process.c: Make symbols static if they're not exported.
7811 (process_tick, update_tick, create_process, chan_process):
7812 (Vprocess_alist, proc_buffered_char, datagram_access):
7813 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7814 (deactivate_process): Mark defn as static, as well as decl.
7815 * lisp.h (create_process): Remove decl.
7816 * process.h (chan_process, Vprocess_alist): Remove decls.
7817
ad64fc97
PE
7818 * print.c: Make symbols static if they're not exported.
7819 (print_depth, new_backquote_output, being_printed, print_buffer):
7820 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7821 (print_interval, print_number_index, initial_stderr_stream):
7822 Now static.
7823 * lisp.h (Fprinc): Remove decl.
7824 (debug_output_compilation_hack): Mark as externally visible.
7825
adddb265
PE
7826 * sysdep.c (croak): Move decl from here to syssignal.h.
7827 * syssignal.h (croak): Put it here, so the API can be checked when
7828 'croak' is called from dissociate_if_controlling_tty.
7829
1717ede2
PE
7830 * minibuf.c: Make symbols static if they're not exported.
7831 (minibuf_save_list, choose_minibuf_frame): Now static.
7832 * lisp.h (choose_minibuf_frame): Remove decl.
7833
fa5fb2bc
PE
7834 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7835
1e3890d1
PE
7836 * lread.c: Make symbols static if they're not exported.
7837 (read_objects, initial_obarray, oblookup_last_bucket_number):
7838 Now static.
7839 (make_symbol): Remove; unused.
7840 * lisp.h (initial_obarray, make_symbol): Remove decls.
7841
8a1414fa
PE
7842 * keyboard.c: Make symbols static if they're not exported.
7843 (single_kboard, recent_keys_index, total_keys, recent_keys):
7844 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7845 (this_single_command_key_start, echoing, last_auto_save):
7846 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7847 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7848 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7849 (Vlispy_mouse_stem, double_click_count):
7850 Now static.
7851 (force_auto_save_soon): Define only if SIGDANGER.
7852 (ignore_mouse_drag_p): Now static if
7853 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7854 (print_help): Remove; unused.
7855 (stop_character, last_timer_event): Mark as externally visible.
7856 * keyboard.h (ignore_mouse_drag_p): Declare only if
7857 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7858 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7859 * lisp.h (echoing): Remove decl.
7860 (force_auto_save_soon): Declare only if SIGDANGER.
7861 * xdisp.c (redisplay_window): Simplify code, to make it more
7862 obvious that ignore_mouse_drag_p is not accessed if !defined
7863 USE_GTK && !defined HAVE_NS.
7864
93ea6e8f
PE
7865 * intervals.c: Make symbols static if they're not exported.
7866 (merge_properties_sticky, merge_interval_right, delete_interval):
7867 Now static.
7868 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7869
77382fcc
PE
7870 * insdel.c: Make symbols static if they're not exported.
7871 However, leave prepare_to_modify_buffer alone. It's never
7872 called from outside this function, but that appears to be a bug.
7873 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7874 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7875 (adjust_after_replace_noundo): Remove; unused.
7876 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7877 (signal_before_change): Remove decls.
77382fcc 7878
9306c32e
PE
7879 * indent.c (val_compute_motion, val_vmotion): Now static.
7880
cd44d2eb
PE
7881 * image.c: Make symbols static if they're not exported.
7882 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7883 if USE_GTK.
7884 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7885 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7886
ad9a7a06
PE
7887 * fringe.c (standard_bitmaps): Now static.
7888 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7889
81626931
PE
7890 * frame.c: Make symbols static if they're not exported.
7891 (x_report_frame_params, make_terminal_frame): Now static.
7892 (get_frame_param): Now static, unless HAVE_NS.
7893 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7894 (x_get_resource_string): Remove; not used.
7895 * frame.h (make_terminal_frame, x_report_frame_params):
7896 (x_get_resource_string); Remove decls.
7897 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7898 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7899
239f9db9
PE
7900 * font.c, fontset.c: Make symbols static if they're not exported.
7901 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7902 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7903 * font.c (font_close_object): Now static.
7904 * font.h (font_close_object): Remove.
7905 * fontset.c (FONTSET_OBJLIST): Remove.
7906 (free_realized_fontset) #if-0 the body, which does nothing.
7907 (face_suitable_for_char_p): #if-0, as it's never called.
7908 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7909 * xfaces.c (face_at_string_position):
7910 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7911 since 0 is always ASCII.
7912
dfcf3579
PE
7913 * fns.c (weak_hash_tables): Now static.
7914
5045092b
PE
7915 * fileio.c: Make symbols static if they're not exported.
7916 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7917 (Vwrite_region_annotation_buffers): Now static.
7918
57a96f5c
PE
7919 * eval.c: Make symbols static if they're not exported.
7920 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7921 * lisp.h (backtrace_list): Remove decl.
7922
35f08c38
PE
7923 * emacs.c: Make symbols static if they're not exported.
7924 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7925 (fatal_error_code, fatal_error_signal_hook, standard_args):
7926 Now static.
7927 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7928 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7929 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7930 * lisp.h (fatal_error_signal_hook): Remove decl.
7931 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7932
f44bd759
PE
7933 * editfns.c: Move a (normally-unused) function to its only use.
7934 * editfns.c, lisp.h (get_operating_system_release): Remove.
7935 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7936 worth the hassle of breaking this out.
7937
b532497d
PE
7938 * xterm.c: Make symbols static if they're not exported.
7939 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7940 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7941 (x_destroy_window, x_delete_display):
7942 Now static.
7943 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7944 (x_mouse_leave): Remove; unused.
7945 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7946 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7947 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7948 Remove decls.
7949 (x_mouse_leave): Declare only if WINDOWSNT.
7950 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7951 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7952 USE_X_TOOLKIT.
7953
1675728f
PE
7954 * ftxfont.c: Make symbols static if they're not exported.
7955 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7956 HAVE_FREETYPE.
7957 * font.h (ftxfont_driver): Likewise.
7958
e4cebfca
PE
7959 * xfns.c: Make symbols static if they're not exported.
7960 (x_last_font_name, x_display_info_for_name):
7961 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7962 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7963 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7964 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7965 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7966 (last_show_tip_args): Now static.
7967 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7968 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7969 (x_screen_planes): Remove; unused.
7970 * dispextern.h (x_screen_planes): Remove decl.
7971
5bf46f05
PE
7972 * dispnew.c: Make symbols static if they're not exported.
7973 * dispextern.h (redraw_garbaged_frames, scrolling):
7974 (increment_row_positions): Remove.
7975 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7976 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7977 Now static.
7978 (redraw_garbaged_frames): Remove; unused.
7979
435f4c28
PE
7980 * xfaces.c: Make symbols static if they're not exported.
7981 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7982 Remove decls.
7983 * xterm.h (defined_color): Remove decls.
7984 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7985 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7986 (menu_face_changed_default, defined_color, free_realized_face):
7987 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7988 (ascii_face_of_lisp_face): Remove; unused.
7989
8524aef3
PE
7990 * xdisp.c: Make symbols static if they're not exported.
7991 * dispextern.h (scratch_glyph_row, window_box_edges):
7992 (glyph_to_pixel_coords, set_cursor_from_row):
7993 (get_next_display_element, set_iterator_to_next):
7994 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7995 (show_mouse_face): Remove decls
7996 * frame.h (message_buf_print): Likewise.
7997 * lisp.h (pop_message, set_message, check_point_in_composition):
7998 Likewise.
7999 * xterm.h (set_vertical_scroll_bar): Likewise.
8000 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8001 (message_buf_print, scratch_glyph_row, displayed_buffer):
8002 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8003 (get_next_display_element, show_mouse_face, window_box_edges):
8004 (frame_to_window_pixel_xy, check_point_in_composition):
8005 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8006 (glyph_to_pixel_coords): Remove; unused.
8007
16390cd2
PE
8008 * dired.c (file_name_completion): Now static.
8009
8010 * dbusbind.c (xd_in_read_queued_messages): Now static.
8011
a25f4dfa
PE
8012 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8013 * data.c (circular_list_error): Remove.
8014
14a9c8df
PE
8015 * commands.h (last_point_position, last_point_position_buffer):
8016 (last_point_position_window): Remove decls.
8017 * keyboard.c: Make these variables static.
8018
04f2d78b
CB
8019 * coding.h (coding, code_convert_region, encode_coding_gap):
8020 Remove decls.
74ab6df5
PE
8021 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8022 (iso_code_class, detect_coding, code_convert_region): Now static.
8023 (encode_coding_gap): Remove; unused.
8024
38dfbee1
PE
8025 * chartab.c (chartab_chars, chartab_bits): Now static.
8026
a2cb4e63
PE
8027 * charset.h (charset_iso_8859_1): Remove decl.
8028 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8029 Now static.
8030
127198fd
PE
8031 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8032 * ccl.c (Vccl_program_table): Now static.
8033 (check_ccl_update): Remove; unused.
8034
d85b608f
PE
8035 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8036 * category.h: ... from here.
8037 * category.c (check_category_table, set_category_set): Now static.
8038
31cd66f3
PE
8039 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8040 * lisp.h: Remove these decls.
8041
c358e587
PE
8042 * buffer.c (buffer_count): Remove unused var.
8043
e78aecca
PE
8044 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8045 so that it's not optimized away.
8046 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8047 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8048 exported only to the debugger.
8049
e192d7d3 8050 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8051 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8052
92470028
PE
8053 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8054 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8055 was inaccessible from Lisp.
8056 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8057 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8058
244ed907
PE
8059 alloc.c: Import and export fewer symbols, and remove unused items.
8060 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8061 is defined.
8062 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8063 it's not optimized away by whole-program optimization.
8064 (message_enable_multibyte, free_misc): Remove.
8065 (catchlist, handlerlist, mark_backtrace):
8066 Declare only if BYTE_MARK_STACK.
8067 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8068 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8069 (message_enable_multibyte): Remove decl.
8070 (free_misc, interval_free_list, float_block, float_block_index):
8071 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8072 (cons_free_list, last_marked_index):
8073 Now static.
8074 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8075 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8076 (mark_backtrace): Define only if BYTE_MARK_STACK.
8077 * xdisp.c (message_enable_multibyte): Now static.
8078
61c2b50e 8079 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8080 This makes it easier for human readers (and static analyzers)
8081 to see whether these variables are used from other modules.
8082 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8083 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8084 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8085 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8086 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8087 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8088 * xmenu.c, xselect.c:
8089 Declare Q* vars static if they are not used in other modules.
8090 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8091 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8092 Remove decls of unexported vars.
8093 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8094
95c82688
PE
8095 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8096
16a97296
PE
8097 Make Emacs functions such as Fatom 'static' by default.
8098 This makes it easier for human readers (and static analyzers)
8099 to see whether these functions can be called from other modules.
8100 DEFUN now defines a static function. To make the function external
8101 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8102 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8103 (Finit_image_library):
16a97296
PE
8104 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8105 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8106 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8107 Remove decls, since these functions are now static.
8108 (Funintern, Fget_internal_run_time): New decls, since these functions
8109 were already external.
95c82688 8110
16a97296
PE
8111 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8112 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8113 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8114 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8115 * keyboard.c, keymap.c, lread.c:
8116 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8117 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8118 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8119 Mark functions with DEFUE instead of DEFUN,
8120 if they are used in other modules.
8121 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8122 decls for now-static functions.
8123 * buffer.h (Fdelete_overlay): Remove decl.
8124 * callproc.c (Fgetenv_internal): Mark as internal.
8125 * composite.c (Fremove_list_of_text_properties): Remove decl.
8126 (Fcomposition_get_gstring): New forward static decl.
8127 * composite.h (Fcomposite_get_gstring): Remove decl.
8128 * dired.c (Ffile_attributes): New forward static decl.
8129 * doc.c (Fdocumntation_property): New forward static decl.
8130 * eval.c (Ffetch_bytecode): New forward static decl.
8131 (Funintern): Remove extern decl; now in .h file where it belongs.
8132 * fileio.c (Fmake_symbolic_link): New forward static decl.
8133 * image.c (Finit_image_library): New forward static decl.
8134 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8135 * intervals.h (Fprevious_property_change):
8136 (Fremove_list_of_text_properties): Remove decls.
8137 * keyboard.c (Fthis_command_keys): Remove decl.
8138 (Fcommand_execute): New forward static decl.
8139 * keymap.c (Flookup_key): New forward static decl.
8140 (Fcopy_keymap): Now static.
8141 * keymap.h (Flookup_key): Remove decl.
8142 * process.c (Fget_process): New forward static decl.
8143 (Fprocess_datagram_address): Mark as internal.
8144 * syntax.c (Fsyntax_table_p): New forward static decl.
8145 (skip_chars): Remove duplicate decl.
8146 * textprop.c (Fprevious_property_change): New forward static decl.
8147 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8148 Now internal.
8149 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8150 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8151
785bbd42
PE
8152 * editfns.c (Fformat): Remove unreachable code.
8153
8b913b57
AS
81542011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8155
8156 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8157 change. (Bug#8496)
8158
a6744a35
EZ
81592011-04-13 Eli Zaretskii <eliz@gnu.org>
8160
8161 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8162 when at ZV. (Bug#8487)
8163
e7974947
AS
81642011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8165
baad03f0
AS
8166 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8167 (Bug#8437)
8168 * keyboard.c (parse_tool_bar_item): Likewise.
8169 * sound.c (sound_cleanup, alsa_close): Likewise.
8170 * termcap.c (tgetent): Likewise.
8171 * xfns.c (x_default_font_parameter): Likewise.
8172 * xsettings.c (read_and_apply_settings): Likewise.
8173
e7974947
AS
8174 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8175 (overrun_check_free): Protoize.
8176
28272684
PE
81772011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8178
8179 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8180 since callers should never pass a negative size.
8181 Change the signature to match that of plain 'read' and 'write'; see
8182 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8183 * lisp.h: Update prototypes of emacs_write and emacs_read.
8184
11997c76
EZ
81852011-04-11 Eli Zaretskii <eliz@gnu.org>
8186
8187 * xdisp.c (redisplay_window): Don't try to determine the character
8188 position of the scroll margin if the window start point w->startp
e896f03c 8189 is outside the buffer's accessible region. (Bug#8468)
11997c76 8190
8a2cbd72
EZ
81912011-04-10 Eli Zaretskii <eliz@gnu.org>
8192
8193 Fix write-region and its subroutines for buffers > 2GB.
8194 * fileio.c (a_write, e_write): Modify declaration of arguments and
8195 local variables to support buffers larger than 2GB.
8196 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8197
8198 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8199 argument, local variables, and return value.
8200
8201 * lisp.h: Update prototypes of emacs_write and emacs_read.
8202
8203 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8204
4073e537 82052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8206
1ebfdcb6
PE
8207 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8208
b2ded58d
PE
8209 Fix more problems found by GCC 4.6.0's static checks.
8210
7d66342c
PE
8211 * xdisp.c (vmessage): Use a better test for character truncation.
8212
bbf47d44
PE
8213 * charset.c (load_charset_map): <, not <=, for optimization,
8214 and to avoid potential problems with integer overflow.
9248994d 8215 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8216 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8217 * editfns.c (Fformat): Likewise.
1e69125e 8218 * syntax.c (skip_chars): Likewise.
3befa583 8219
e3019616
PE
8220 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8221 This also lets GCC 4.6.0 generate slightly better loop code.
8222
becfa255
PE
8223 * callint.c (Fcall_interactively): <, not <=, for optimization.
8224 (Fcall_interactively): Count the number of arguments produced,
8225 not the number of arguments given. This is simpler and lets GCC
8226 4.6.0 generate slightly better code.
8227
dae0cd48
PE
8228 * ftfont.c: Distingish more carefully between FcChar8 and char.
8229 The previous code passed unsigned char * to a functions like
8230 strlen and xstrcasecmp that expect char *, which does not
8231 conform to the C standard.
8232 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8233 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8234 char * when the C standard requires it.
8235
76032d70
PE
8236 * keyboard.c (read_char): Remove unused var.
8237
eb3f1cc8
PE
8238 * eval.c: Port to Windows vsnprintf (Bug#8435).
8239 Include <limits.h>.
8240 (SIZE_MAX): Define if the headers do not.
8241 (verror): Do not give up if vsnprintf returns a negative count.
8242 Instead, grow the buffer. This ports to Windows vsnprintf, which
8243 does not conform to C99. Problem reported by Eli Zaretskii.
8244 Also, simplify the allocation scheme, by avoiding the need for
8245 calling realloc, and removing the ALLOCATED variable.
8246
70476b54
PE
8247 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8248
12020a9e
PE
8249 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8250 But keep the doprint source code for now, as we might revamp it
8251 and use it again (Bug#8435).
ea6c7ae6
PE
8252 * lisp.h (doprnt): Remove.
8253 * Makefile.in (base_obj): Remove doprnt.o.
8254 * deps.mk (doprnt.o): Remove.
8255
5fdb398c
PE
8256 error: Print 32- and 64-bit integers portably (Bug#8435).
8257 Without this change, on typical 64-bit hosts error ("...%d...", N)
8258 was used to print both 32- and 64-bit integers N, which relied on
8259 undefined behavior.
61bdb816 8260 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8261 * lisp.h (error, verror): Mark as printf-like functions.
8262 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8263 Report overflow in size calculations when allocating printf buffer.
8264 Do not truncate output string at its first null byte.
8265 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8266 Truncate the output at a character boundary, since vsnprintf does not
8267 do that.
8268 * charset.c (check_iso_charset_parameter): Convert internal
8269 character to string before calling 'error', since %c now has the
8270 printf meaning.
8271 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8272 overflow when computing char to be passed to 'error'. Do not
8273 pass Lisp_Object to 'error'; pass the integer instead.
8274 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8275 formatted with plain %d.
8276
b189fa66
PE
8277 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8278
bff87ef0
PE
8279 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8280
7e2cac20
PE
8281 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8282
ce4d90b5
PE
8283 * xterm.c (x_catch_errors): Remove duplicate declaration.
8284
266c9547
PE
8285 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8286
79c49ad2
PE
8287 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8288
368f4090
JM
82892011-04-10 Jim Meyering <meyering@redhat.com>
8290
8291 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8292 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8293 return ssize_t not "int", and use size_t as the buffer length.
8294 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8295 * gnutls.h: Update declarations.
8296 * process.c (read_process_output): Use ssize_t, to match.
8297 (send_process): Likewise.
8298
a32d4040
CY
82992011-04-09 Chong Yidong <cyd@stupidchicken.com>
8300
8301 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8302
8546720e 83032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8304
04f2d78b
CB
8305 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8306 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8307
8546720e
GM
8308 * xterm.c (handle_one_xevent):
8309 * xmenu.c (create_and_show_popup_menu):
8310 * xselect.c (x_decline_selection_request)
8311 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8312
0a2f5c1a 83132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8314
8315 Fix some uses of `int' instead of EMACS_INT.
8316 * search.c (string_match_1, fast_string_match)
8317 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8318 (scan_buffer, find_next_newline_no_quit)
8319 (find_before_next_newline, search_command, Freplace_match)
8320 (Fmatch_data): Make some `int' variables be EMACS_INT.
8321
8322 * xdisp.c (display_count_lines): 3rd argument and return value now
8323 EMACS_INT. All callers changed.
8324 (pint2hrstr): Last argument is now EMACS_INT.
8325
8326 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8327 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8328 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8329 (decode_coding_utf_16, decode_coding_emacs_mule)
8330 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8331 (decode_coding_ccl, decode_coding_charset)
8332 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8333 (decode_coding_iso_2022, decode_coding_emacs_mule)
8334 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8335 <char_offset, last_offset>: Declare EMACS_INT.
8336 (encode_coding_utf_8, encode_coding_utf_16)
8337 (encode_coding_emacs_mule, encode_invocation_designation)
8338 (encode_designation_at_bol, encode_coding_iso_2022)
8339 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8340 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8341 Declare EMACS_INT.
8342 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8343 (encode_invocation_designation): Last argument P_NCHARS is now
8344 EMACS_INT.
8345 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8346 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8347
8348 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8349 All users changed.
8350
8351 * ccl.c (Fccl_execute_on_string): Declare some variables
8352 EMACS_INT.
8353
8546720e 83542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8355
8356 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8357
4e19a977
CS
83582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8359
8360 * process.c (Fformat_network_address): Doc fix.
8361
87302331
R
83622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8363
ee7683eb 8364 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8365
cbb59342
CY
83662011-04-08 Chong Yidong <cyd@stupidchicken.com>
8367
8368 * keyboard.c (read_char): Call Lisp function help-form-show,
8369 instead of using internal_with_output_to_temp_buffer.
8370 (Qhelp_form_show): New var.
e0d38eeb 8371 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8372
8373 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8374
8375 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8376
e67a13ab
CY
83772011-04-06 Chong Yidong <cyd@stupidchicken.com>
8378
04f2d78b
CB
8379 * process.c (Flist_processes): Remove to Lisp.
8380 (list_processes_1): Delete.
e67a13ab 8381
973f782d
EZ
83822011-04-06 Eli Zaretskii <eliz@gnu.org>
8383
7c106b1e
EZ
8384 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8385
973f782d
EZ
8386 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8387
41cf7d1a 83882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8389
ca23cc88
PE
8390 Fix more problems found by GCC 4.6.0's static checks.
8391
f390e2d5
PE
8392 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8393
42eea0d0
PE
8394 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8395
b69769da 8396 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8397
f9541e84
PE
8398 * xdisp.c (vmessage): Mark as a printf-like function.
8399
13841b55
PE
8400 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8401
c136c10f
PE
8402 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8403
5e2d4a30
PE
8404 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8405 printf-like functions.
8406 (tiff_load): Add casts to remove these marks before passing them
8407 to system-supplied API.
8408
583f48b9
PE
8409 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8410
b25d760e
PE
8411 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8412 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8413 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8414 directly, rather than having caller test rule sign. This avoids
8415 some unnecessary tests.
8416 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8417 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8418 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8419
bc7b6697 8420 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8421 (xfont_open): Avoid unnecessary tests.
bc7b6697 8422
27ccc379
PE
8423 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8424
dcd5c89a
PE
8425 * composite.h, composite.c (composition_gstring_put_cache):
8426 Use EMACS_INT, not int, for length.
8427
b13a45c6
PE
8428 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8429 breaking out part of COMPOSITION_DECODE_RULE.
8430 (COMPOSITION_DECODE_RULE): Use it.
8431 * composite.c (get_composition_id): Remove unused local vars,
8432 by using the new macro.
8433
1e792e4d
PE
8434 * textprop.c (set_text_properties_1): Change while to do-while,
8435 since the condition is always true at first.
8436
dc6c6455 8437 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8438 (interval_deletion_adjustment): Return unsigned value.
8439 All uses changed.
dc6c6455 8440
aba7731a
PE
8441 * process.c (list_processes_1, create_pty, read_process_output):
8442 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8443 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8444 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8445 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8446 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8447
fdfc4bf3
PE
8448 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8449
fca8fe46 8450 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8451 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8452
06a0259a 8453 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8454 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8455 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8456
e7b9e80f
PE
8457 * print.c (print_error_message): Avoid int overflow.
8458
56201685
PE
8459 * font.c (font_list_entities): Redo for clarity,
8460 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8461
78834453 8462 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8463 (font_score): Avoid potential overflow in diff calculation.
78834453 8464
0bc0b309 8465 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8466 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8467
e610eaca
PE
8468 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8469
b895abce
PE
8470 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8471 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8472 can always succeed if overflow has undefined behavior.
8473
1f1d9321 8474 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8475 (wordify): Omit three unnecessary tests.
1f1d9321 8476
c59478bc
PE
8477 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8478 All callers changed. This avoids the need for an unused var.
8479
79b73827
PE
8480 * casefiddle.c (casify_region): Remove var that is set but not used.
8481
a4db5dfe
PE
8482 * dired.c (file_name_completion): Remove var that is set but not used.
8483
43aae36e
PE
8484 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8485
2a47c44d 8486 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8487 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8488
a37c69bf
PE
8489 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8490 Check for integer overflow on size calculations.
8491
328ab8e7
PE
8492 * buffer.c (Fprevious_overlay_change): Remove var that is set
8493 but not used.
8494
e5a2a5cb
PE
8495 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8496 Remove vars that are set but not used.
8d84a6eb 8497 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8498 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8499
a60e5f68
PE
8500 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8501
f661cb61 8502 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8503 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8504
f0397f5a
PE
8505 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8506 that are set but not used.
8507
8664db06 8508 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8509 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8510
6abdaa4a
PE
8511 * xselect.c (x_get_local_selection, x_handle_property_notify):
8512 Remove vars that are set but not used.
8513
0ce7538d 8514 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8515 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8516
9ae848fc
PE
8517 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8518 Remove var that is set but not used.
0b918413
PE
8519 (scroll_bar_windows_size): Now size_t, not int.
8520 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8521 Check for overflow.
9ae848fc 8522
a5a62657
PE
8523 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8524 (map_tty_color) [!defined MSDOS]: Likewise.
8525
5c5cdd39
PE
8526 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8527
66ebf983
PE
8528 * coding.c: Remove vars that are set but not used.
8529 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8530 All callers changed.
8531 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8532 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8533 (decode_coding_charset): Remove vars that are set but not used.
8534
1be4d761
PE
8535 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8536 that is set but not used.
8537
47553fa8
PE
8538 * print.c (print_object): Remove var that is set but not used.
8539
1f7196bf 8540 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8541 The gnulib version avoids calling malloc in the usual case,
8542 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8543 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8544 * filelock.c (current_lock_owner): Likewise.
8545 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8546 * sysdep.c: Include allocator.h, careadlinkat.h.
8547 (emacs_no_realloc_allocator): New static constant.
8548 (emacs_readlink): New function.
fdb61804
PE
8549 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8550 ../lib/careadlinkat.h.
d1fdcab7 8551
f84c17c7
SM
85522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8553
8554 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8555 first non-nil return value).
8556
ef3862ad
JD
85572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8558
8559 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8560 if not defined (Bug#8403).
8561
376a7006
JB
85622011-04-02 Juanma Barranquero <lekktu@gmail.com>
8563
8564 * xdisp.c (display_count_lines): Remove parameter `start',
8565 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8566 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8567 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8568 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8569 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8570 and thereabouts. All callers changed.
8571 (get_per_char_metric): Remove parameter `f', unused since
8572 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8573
6ca3801d
JM
85742011-04-02 Jim Meyering <meyering@redhat.com>
8575
8576 do not dereference NULL upon failed strdup
8577 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8578 (ns_get_family): Likewise.
8579
d8e2b5ba
JB
85802011-04-02 Juanma Barranquero <lekktu@gmail.com>
8581
8582 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8583
8c74fcbd
JD
85842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8585
8586 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8587 later (Bug#8403).
8588
7200d79c
SM
85892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8590
03408648 8591 Add lexical binding.
7200d79c 8592
03408648
SM
8593 * window.c (Ftemp_output_buffer_show): New fun.
8594 (Fsave_window_excursion):
8595 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8596
8597 * lread.c (lisp_file_lexically_bound_p): New function.
8598 (Fload): Bind Qlexical_binding.
8599 (readevalloop): Remove `evalfun' arg.
8600 Bind Qinternal_interpreter_environment.
8601 (Feval_buffer): Bind Qlexical_binding.
8602 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8603 Mark as dynamic.
8604 (syms_of_lread): Declare `lexical-binding'.
8605
8606 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8607
8608 * keyboard.c (eval_dyn): New fun.
8609 (menu_item_eval_property): Use it.
ca105506
SM
8610
8611 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8612
03408648
SM
8613 * fns.c (concat, mapcar1): Accept byte-code-functions.
8614
8615 * eval.c (Fsetq): Handle lexical vars.
8616 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8617 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8618 (FletX, Flet): Obey lexical binding.
8619 (Fcommandp): Handle closures.
8620 (Feval): New `lexical' arg.
8621 (eval_sub): New function extracted from Feval. Use it almost
8622 everywhere where Feval was used. Look up vars in lexical env.
8623 Handle closures.
8624 (Ffunctionp): Move from subr.el.
8625 (Ffuncall): Handle closures.
8626 (apply_lambda): Remove `eval_flags'.
8627 (funcall_lambda): Handle closures and new byte-code-functions.
8628 (Fspecial_variable_p): New function.
8629 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8630 but without exporting it to Lisp.
23aba0ea 8631
23aba0ea 8632 * doc.c (Fdocumentation, store_function_docstring):
03408648 8633 * data.c (Finteractive_form): Handle closures.
23aba0ea 8634
03408648
SM
8635 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8636 interactive spec.
ba83908c 8637
04f2d78b
CB
8638 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8639 New byte-codes.
03408648
SM
8640 (exec_byte_code): New function extracted from Fbyte_code to handle new
8641 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8642
03408648 8643 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8644
03408648 8645 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8646
e2abce01
JB
86472011-03-31 Juanma Barranquero <lekktu@gmail.com>
8648
8649 * xdisp.c (redisplay_internal): Fix prototype.
8650
63696a73 86512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8652
63696a73 8653 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8654 (try_scrolling): Use it when setting scroll_limit.
8655 Limit scrolling to 100 screen lines.
63696a73
EZ
8656 (redisplay_window): Even when falling back on "recentering",
8657 position point in the window according to scroll-conservatively,
8658 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8659
8660 (try_scrolling): When point is above the window, allow searching
8661 as far as scroll_max, or one screenful, to compute vertical
8662 distance from PT to the scroll margin position. This prevents
8663 try_scrolling from unnecessarily failing when
8664 scroll-conservatively is set to a value slightly larger than the
8665 window height. Clean up the case of PT below the margin at bottom
8666 of window: scroll_max can no longer be INT_MAX. When aggressive
8667 scrolling is in use, don't let point enter the opposite scroll
8668 margin as result of the scroll.
8669 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8670 threshold of 100 lines for never-recentering scrolling.
8671
e4cc2dfc
JB
86722011-03-31 Juanma Barranquero <lekktu@gmail.com>
8673
8674 * dispextern.h (move_it_by_lines):
8675 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8676 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8677 (message_log_check_duplicate): Remove parameters `prev_bol' and
8678 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8679 (redisplay_internal): Remove parameter `preserve_echo_area',
8680 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8681
8682 * indent.c (Fvertical_motion):
8683 * window.c (window_scroll_pixel_based, Frecenter):
8684 Don't pass `need_y_p' to `move_it_by_lines'.
8685
1c470562
SM
86862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8687
44f230aa
SM
8688 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8689 steal a few bits to be more compact.
8690 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8691 Remove unneeded casts.
8692
1c470562
SM
8693 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8694
888adce9
ZK
86952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8696
8697 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8698 binding" message (bug#7967).
8699
f838ed7b
PE
87002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8701
77861b95
PE
8702 Fix more problems found by GCC 4.6.0's static checks.
8703
de6dbc14
PE
8704 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8705 Remove unused local var.
8706
f838ed7b
PE
8707 * editfns.c (Fmessage_box): Remove unused local var.
8708
792c7b2b
PE
8709 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8710 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8711 Omit unused local vars.
c499e557 8712 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8713 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8714 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8715 Omit unused local var.
8716
ba0165e1
PE
8717 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8718 Don't assume string length fits in int.
32ad8845 8719 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8720 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8721
3c59b4c9
PE
8722 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8723 instead of alloca (Bug#8344).
8724
a3eed478 8725 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8726 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8727
eb4d412d
PE
8728 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8729
1658b401
PE
8730 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8731 concerns.
8732
8733 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8734
8735 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8736
9a2c6e05
PE
8737 * keyboard.c (syms_of_keyboard): Use the same style as later
8738 in this function when indexing through an array. This also
8739 works around GCC bug 48267.
8740
03d0a109
PE
8741 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8742
44f730c8
PE
8743 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8744
fe75f926
PE
8745 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8746 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8747
ffa8c828
PE
8748 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8749 This avoids undefined behavior on integer overflow, and is a bit
8750 more convenient anyway since it is compared to a size_t variable.
8751
c5101a77
PE
8752 Variadic C functions now count arguments with size_t, not int.
8753 This avoids an unnecessary limitation on 64-bit machines, which
8754 caused (substring ...) to crash on large vectors (Bug#8344).
8755 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8756 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8757 All variadic functions and their callers changed accordingly.
c5101a77
PE
8758 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8759 * data.c (arith_driver, float_arith_driver): Likewise.
8760 * editfns.c (general_insert_function): Likewise.
8761 * eval.c (struct backtrace.nargs, interactive_p)
8762 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8763 (funcall_lambda, mark_backtrace): Likewise.
8764 * fns.c (concat): Likewise.
8765 * frame.c (x_set_frame_parameters): Likewise.
8766 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8767 0 if not found, not -1. All callers changed.
8768
dd3f25f7
PE
8769 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8770 (stack_copy_size): Now size_t, not int.
8771 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8772
461c2ab9
JB
87732011-03-28 Juanma Barranquero <lekktu@gmail.com>
8774
8775 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8776 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8777 All callers changed.
8778
8779 * lisp.h (multibyte_char_to_unibyte):
8780 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8781 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8782 * character.h (CHAR_TO_BYTE8):
8783 * cmds.c (internal_self_insert):
8784 * editfns.c (general_insert_function):
8785 * keymap.c (push_key_description):
8786 * search.c (Freplace_match):
8787 * xdisp.c (message_dolog, set_message_1): All callers changed.
8788
f6d62986
SM
87892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8790
8791 * keyboard.c (safe_run_hook_funcall): New function.
8792 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8793 don't set the hook to nil, but remove the offending function instead.
8794 (Qcommand_hook_internal): Remove, unused.
8795 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8796 Vcommand_hook_internal.
8797
8798 * eval.c (enum run_hooks_condition): Remove.
8799 (funcall_nil, funcall_not): New functions.
8800 (run_hook_with_args): Call each function through a `funcall' argument.
8801 Remove `cond' argument, now redundant.
8802 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8803 (Frun_hook_with_args_until_failure): Adjust accordingly.
8804 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8805
1db5b1ad
JB
88062011-03-28 Juanma Barranquero <lekktu@gmail.com>
8807
8808 * dispextern.h (string_buffer_position): Remove declaration.
8809
8810 * print.c (strout): Remove parameter `multibyte', unused since
8811 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8812
8813 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8814 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8815 All callers changed.
8816
8817 * w32.c (_wsa_errlist): Use braces for struct initializers.
8818
8819 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8820 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8821 All callers changed.
8822 (string_buffer_position): Likewise. Also, make static (it's never
8823 used outside xdisp.c).
8824 (cursor_row_p): Remove parameter `w', unused since
8825 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8826 (decode_mode_spec): Remove parameter `precision', introduced during
8827 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8828 All callers changed.
8829
5ffb62aa
JD
88302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8831
8832 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8833
461c2ab9 88342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8835
8836 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8837 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8838 (ns_update_auto_hide_menu_bar): New functions.
8839 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8840 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8841 ns_constrain_all_frames.
8842 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8843 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8844
5c380ffb
JD
88452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8846
8847 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8848
9af30bdf
GM
88492011-03-27 Glenn Morris <rgm@gnu.org>
8850
8851 * syssignal.h: Replace RETSIGTYPE with void.
8852 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8853 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8854 Replace SIGTYPE with void everywhere.
8855 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8856 * s/template.h (SIGTYPE): Remove commented out definition.
8857
e2abce01
JB
88582011-03-26 Eli Zaretskii <eliz@gnu.org>
8859
8860 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8861 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8862
f868cd8a
JB
88632011-03-26 Juanma Barranquero <lekktu@gmail.com>
8864
59eb0929
JB
8865 * w32.c (read_unc_volume): Use parameter `henum', instead of
8866 global variable `wget_enum_handle'.
8867
8868 * keymap.c (describe_vector): Remove parameters `indices' and
8869 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8870 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8871
f868cd8a
JB
8872 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8873
8874 * keyboard.c (timer_check): Remove parameter `do_it_now',
8875 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8876 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8877 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8878
8879 * keyboard.c (read_char):
8880 * w32menu.c (w32_menu_display_help):
8881 * xmenu.c (show_help_event, menu_help_callback):
8882 Adjust calls to `show_help_echo'.
8883
8884 * gtkutil.c (xg_maybe_add_timer):
8885 * keyboard.c (readable_events):
8886 * process.c (wait_reading_process_output):
8887 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8888
8889 * insdel.c (adjust_markers_gap_motion):
8890 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8891 (gap_left, gap_right): Don't call it.
8892
2ecf6fdb
CY
88932011-03-25 Chong Yidong <cyd@stupidchicken.com>
8894
8895 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8896 incurred during fontification.
8897
6b1f9ba4
JB
88982011-03-25 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8901 (DEFVAR_PER_BUFFER): Don't pass it.
8902
8903 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8904 (scrolling_window): Don't pass it.
8905
0f4a96b5
JB
89062011-03-25 Juanma Barranquero <lekktu@gmail.com>
8907
8908 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8909
8910 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8911 and `suffix'.
8912 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8913 of variables specific to SELinux and computation of `encoded_absname'.
8914
8915 * image.c (XPutPixel): Remove unused variable `height'.
8916
8917 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8918
8919 * unexw32.c (get_section_info): Remove unused variable `section'.
8920
8921 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8922 (system_process_attributes): Remove unused variable `sess'.
8923 (sys_read): Remove unused variable `err'.
8924
8925 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8926 (w32_wnd_proc): Remove unused variable `isdead'.
8927 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8928 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8929 (x_create_tip_frame): Remove unused variable `tem'.
8930
8931 * w32inevt.c (w32_console_read_socket):
8932 Remove unused variable `no_events'.
8933
8934 * w32term.c (x_draw_composite_glyph_string_foreground):
8935 Remove unused variable `width'.
8936
1149507c
JB
89372011-03-24 Juanma Barranquero <lekktu@gmail.com>
8938
8939 * w32term.c (x_set_glyph_string_clipping):
8940 Don't pass uninitialized region to CombineRgn.
8941
9c88f339
JB
89422011-03-23 Juanma Barranquero <lekktu@gmail.com>
8943
8944 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8945 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8946 (Fx_close_connection): Remove unused variable `i'.
8947
8948 * w32font.c (w32font_draw): Return number of glyphs.
8949 (w32font_open_internal): Remove unused variable `i'.
8950 (w32font_driver): Add missing initializer.
8951
8952 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8953 (fill_in_menu): Remove unused variable `items_added'.
8954
8955 * w32term.c (last_mouse_press_frame): Remove static global variable.
8956 (w32_clip_to_row): Remove unused variable `f'.
8957 (x_delete_terminal): Remove unused variable `i'.
8958
8959 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8960 (NOTHING): Remove unused static global variable.
8961 (uniscribe_check_otf): Remove unused variable `table'.
8962 (uniscribe_font_driver): Add missing initializers.
8963
dee091a3
JD
89642011-03-23 Julien Danjou <julien@danjou.info>
8965
8966 * term.c (Fsuspend_tty, Fresume_tty):
8967 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8968 * window.c (temp_output_buffer_show):
8969 * insdel.c (signal_before_change):
8970 * frame.c (Fhandle_switch_frame):
8971 * fileio.c (Fdo_auto_save):
8972 * emacs.c (Fkill_emacs):
8973 * editfns.c (save_excursion_restore):
8974 * cmds.c (internal_self_insert):
8975 * callint.c (Fcall_interactively):
8976 * buffer.c (Fkill_all_local_variables):
8977 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8978 Use Frun_hooks.
0f4a96b5 8979 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8980 unconditionally since it does the check itself.
dee091a3 8981
2c520ab5 89822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8983
c9c49752
PE
8984 Fix more problems found by GCC 4.5.2's static checks.
8985
8abc3f12
PE
8986 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8987 the first time through the loop, since we know p0 < p1 then.
8988 This also avoids a gcc -Wstrict-overflow warning.
8989
a2d26660
PE
8990 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8991 leading to a memory leak, possible in functions like
8992 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8993 of objects (Bug#8318).
a2d26660 8994
916c72e9
PE
8995 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8996 that could (at least in theory) be that large.
8997
19ab8a18
PE
8998 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8999 This is less likely to overflow, and avoids undefined behavior if
9000 overflow does occur. All callers changed. Use strtoul to scan
9001 for the unsigned long integer.
b7cbbd6f
PE
9002 (pint2hrstr): Simplify and tune code slightly.
9003 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9004
f0641eff
PE
9005 * scroll.c (do_scrolling): Work around GCC bug 48228.
9006 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9007
7f650bb9
PE
9008 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9009 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9010 (validate_x_resource_name): Simplify count usage.
9011 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9012
37dd57d1
PE
9013 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9014 fail (Bug#8306).
81e56e61 9015
699979fc 9016 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9017
401bf9b4
PE
9018 * process.c (Fmake_network_process): Use socklen_t, not int,
9019 where POSIX says socklen_t is required in portable programs.
9020 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9021 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9022 (Fmake_network_process, server_accept_connection):
9023 (wait_reading_process_output, read_process_output):
9024 Likewise.
9025
b93aacde
PE
9026 * process.c: Rename or move locals to avoid shadowing.
9027 (list_processes_1, Fmake_network_process):
9028 (read_process_output_error_handler, exec_sentinel_error_handler):
9029 Rename or move locals.
4dc343ee 9030 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9031 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9032 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9033 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9034 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9035
af8a867c 9036 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9037 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9038 Include tparam.h instead, since it declares them.
af8a867c
PE
9039 * cm.h (PC): Remove extern decl; tparam.h now does this.
9040 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9041 * terminfo.c: Include tparam.h, to check interfaces.
9042 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9043 (tparam): Adjust signature to match interface in tparam.h;
9044 this removes some undefined behavior. Check that outstring and len
9045 are zero, which they always are with Emacs.
9046 * tparam.h (PC, BC, UP): New extern decls.
9047
0248044d 9048 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9049 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9050
8ff096c1 9051 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9052 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9053 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9054 (ftfont_list): Remove unused local.
49eaafba
PE
9055 (get_adstyle_property, ftfont_pattern_entity):
9056 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9057 Rename locals to avoid shadowing.
8ff096c1 9058
e2be39f6
PE
9059 * xfont.c (xfont_list_family): Mark var as initialized.
9060
c9735e30
PE
9061 * xml.c (make_dom): Now static.
9062
8f5201ae
PE
9063 * composite.c (composition_compute_stop_pos): Rename local to
9064 avoid shadowing.
b246f932
PE
9065 (composition_reseat_it): Remove unused locals.
9066 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9067 (composition_update_it): Mark var as initialized.
11b61122
PE
9068 (find_automatic_composition): Mark vars as initialized,
9069 with a FIXME (Bug#8290).
8f5201ae 9070
760fbc2c
PE
9071 character.h: Rename locals to avoid shadowing.
9072 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9073 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9074 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9075 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9076 to avoid shadowing.
9077
ff08eb85
PE
9078 * textprop.c (property_change_between_p): Remove; unused.
9079
fc7bf025
PE
9080 * intervals.c (interval_start_pos): Now static.
9081
235d7abc
PE
9082 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9083
44f230aa
SM
9084 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9085 Rename locals to avoid shadowing.
3e7d6594 9086
50060332
PE
9087 * sound.c (wav_play, au_play, Fplay_sound_internal):
9088 Fix pointer signedness.
d01f234b 9089 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9090 (wav_play): Initialize a variable to 0, to prevent undefined
9091 behavior (Bug#8278).
50060332 9092
c4fc4e30
PE
9093 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9094
918436ed
PE
9095 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9096
c939f91b
PE
9097 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9098 clobbering (Bug#8298).
b9c7f648
PE
9099 * sysdep.c (sys_subshell): Likewise.
9100 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9101
6bd8c144
PE
9102 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9103 This should get cleaned up, so that child_setup has the
9104 same signature on all platforms.
9105
7710357c 9106 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9107 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9108
c59da222
CY
91092011-03-22 Chong Yidong <cyd@stupidchicken.com>
9110
9111 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9112 not to be necessary, and produces flickering.
9113
66b87493
GM
91142011-03-20 Glenn Morris <rgm@gnu.org>
9115
9116 * config.in: Remove file.
9117
45b6f6d5
JB
91182011-03-20 Juanma Barranquero <lekktu@gmail.com>
9119
9120 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9121 are now in src/globals.h.
9122 (syms_of_minibuf): Remove spurious & from previous change.
9123
cd394be1 91242011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9125
9126 * minibuf.c (completing-read-function): New variable.
9127 (completing-read-default): Rename from completing-read.
9128 (completing-read): Call completing-read-function.
9129
b14e3e21
CY
91302011-03-19 Juanma Barranquero <lekktu@gmail.com>
9131
9132 * xfaces.c (Fx_load_color_file):
9133 Read color file from absolute filename (bug#8250).
9134
f2b726e6
JB
91352011-03-19 Juanma Barranquero <lekktu@gmail.com>
9136
9137 * makefile.w32-in: Update dependencies.
9138
09f6ff02
EZ
91392011-03-17 Eli Zaretskii <eliz@gnu.org>
9140
9141 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9142
29a6015a
PE
91432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9144
a3a6c54e
PE
9145 Fix more problems found by GCC 4.5.2's static checks.
9146
b766f867
PE
9147 * process.c (make_serial_process_unwind, send_process_trap):
9148 (sigchld_handler): Now static.
9149
be02381c
PE
9150 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9151 That way, the code declares only the vars that it needs.
9152 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9153 * s/cygwin.h (PTY_ITERATION): Likewise.
9154 * s/darwin.h (PTY_ITERATION): Likewise.
9155 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9156
57048744
PE
9157 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9158 * process.c (allocate_pty): Don't declare stb unless it's needed.
9159
7914961c 9160 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9161 (CONSTANTLIM): Remove; unused.
9162 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9163 Define only if needed.
7914961c 9164
b3967b18
PE
9165 * unexelf.c (unexec): Name an expression,
9166 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9167 Use a different way to cause a compilation error if anyone uses
9168 n rather than nn, a way that does not involve shadowing.
73366a00 9169 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9170
29a6015a
PE
9171 * deps.mk (unexalpha.o): Remove; unused.
9172
43cfc33e 9173 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9174 * unexec.h: New file.
ce701a33
PE
9175 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9176 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9177 Depend on unexec.h.
9178 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9179 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9180 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9181 Change as necessary to match prototype in unexec.h.
ce701a33 9182
01f44d5a
PE
9183 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9184 shadowing.
4f63c6bb 9185 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9186
a6670b0b
PE
9187 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9188 Rename locals to avoid shadowing.
9189
cef2010d 9190 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9191 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9192
d4d7173a
PE
9193 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9194
f08b802a
PE
9195 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9196 warning when compiling print.c.
9197
3ddb0639
PE
9198 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9199 instead of using an uninitialized var.
5ad03b97 9200 (font_sort_entities): Mark var as initialized.
3ddb0639 9201
170a2692
PE
9202 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9203
e663c700
PE
9204 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9205 pointers to constants.
89bc529a 9206 (font_parse_fcname): Remove unused vars.
7b81e2d0 9207 (font_delete_unmatched): Now static.
ea838e10 9208 (font_get_spec): Remove; unused.
13a547c6
PE
9209 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9210 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9211 Rename or move locals to avoid shadowing.
e663c700 9212
2a80c887 9213 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9214 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9215
1384fa33 9216 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9217 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9218
8b2c52e9
PE
9219 * alloc.c (mark_backtrace): Move decl from here ...
9220 * lisp.h: ... to here, so that it can be checked.
9221
475545b5 9222 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9223 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9224 (lisp_indirect_variable): Name an expression,
9225 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9226 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9227
b1349114 9228 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9229 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9230 Use const pointer when appropriate.
b1349114 9231
a2928364
PE
9232 * lisp.h (get_system_name, get_operating_system_release):
9233 Move decls here, to check interfaces.
9234 * process.c (get_operating_system_release): Move decl to lisp.h.
9235 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9236 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9237 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9238 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9239 (Fformat_time_string, Fencode_time, Finsert_char):
9240 (Ftranslate_region_internal, Fformat):
9241 Rename or remove local vars to avoid shadowing.
9710023e 9242 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9243
a415e694
PE
9244 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9245 avoid shadowing.
9246
8ef4622d
PE
9247 * lisp.h (eassert): Check that the argument compiles, even if
9248 ENABLE_CHECKING is not defined.
9249
946f9a5b
PE
9250 * data.c (Findirect_variable): Name an expression, to avoid
9251 gcc -Wbad-function-cast warning.
112396d6 9252 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9253 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9254 (Fmake_variable_buffer_local, Fmake_local_variable):
9255 Mark variables as initialized.
52746918 9256 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9257
e5aab7e7 9258 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9259 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9260 Rename locals to avoid shadowing.
dff45157
PE
9261 (mark_stack): Move local variables into the #ifdef region where
9262 they're used.
7bc26fdb
PE
9263 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9264 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9265 needed otherwise.
9266 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9267 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9268 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9269
e5aab7e7
PE
9270 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9271 avoids undefined behavior in theory.
9272
4da60324
PE
9273 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9274
88043301
PE
9275 Use functions, not macros, for up- and down-casing (Bug#8254).
9276 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9277 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9278 to use the following functions instead of these macros.
9279 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9280 EMACS_INT, since callers assume the returned value fits in int.
9281 (upcase1): Likewise, for UPCASE_TABLE.
9282 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9283 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9284 the race-condition problem in the old DOWNCASE.
88043301 9285
19ed5445
PE
9286 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9287 Rename locals to avoid shadowing.
9288 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9289 (regex_compile, re_search_2, re_match_2_internal):
9290 Remove unused local vars.
952db0d7
PE
9291 (FREE_VAR): Rewrite so as not to use empty "else",
9292 which gcc can warn about.
da053e48 9293 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9294 (RETALLOC_IF): Define only if needed.
9295 (WORDCHAR_P): Likewise. This one is never needed, but is used
9296 only in a comment talking about a compiler bug, so put inside
9297 the #if 0 of that comment.
9298 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9299 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9300 Remove; unused.
19ed5445 9301
1f3561e4 9302 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9303 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9304 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9305
ded6f8f7
PE
9306 * search.c (simple_search): Remove unused var.
9307
dbd37a95
PE
9308 * dired.c (compile_pattern): Move decl from here ...
9309 * lisp.h: ... to here, so that it can be checked.
9310 (struct re_registers): New forward decl.
9311
7e47afad
PE
9312 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9313
85f24f61
PE
9314 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9315 All uses changed.
9316 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9317 Rename locals to avoid shadowing.
5671df8f 9318 (Fvertical_motion): Mark locals as initialized.
85f24f61 9319
181aa2be 9320 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9321 (casify_region): Mark local as initialized.
181aa2be 9322
930d429c
PE
9323 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9324
7082eac6
PE
9325 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9326 New macros, so that the caller can use some names other than
9327 gcpro1, gcpro2, etc.
9328 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9329 of the new macros.
9330 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9331 argument, for consistency with GCPRO2_VAR, etc: it is now the
9332 prefix of the variable, not the variable itself. All uses
9333 changed.
38b2c076
PE
9334 * dired.c (directory_files_internal, file_name_completion):
9335 Rename locals to avoid shadowing.
9336
15206ed9
PE
9337 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9338 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9339 dired.c's scmp function, had undefined behavior.
9340 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9341 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9342 * buffer.h: ... to here, because these macros use current_buffer,
9343 and the new implementation with inline functions needs to have
9344 current_buffer in scope now, rather than later when the macros
9345 are used.
9346 (downcase, upcase1): New static inline functions.
9347 (DOWNCASE, UPCASE1): Reimplement using these functions.
9348 This avoids undefined behavior in expressions like
9349 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9350 from race conditions in accessing the global variables
9351 case_temp1 and case_temp2.
9352 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9353 * lisp.h (case_temp1, case_temp2): Remove their decls.
9354 * character.h (ASCII_CHAR_P): Move from here ...
9355 * lisp.h: ... to here, so that the inline functions mentioned
9356 above can use them.
9357
4a6bea26
PE
9358 * dired.c (directory_files_internal_unwind): Now static.
9359
f14b7e14
PE
9360 * fileio.c (file_name_as_directory, directory_file_name):
9361 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9362 Now static.
2893f146
PE
9363 (file_name_as_directory): Use const pointers when appropriate.
9364 (Fexpand_file_name): Likewise. In particular, newdir might
9365 point at constant storage, so make it a const pointer.
fd4ead52 9366 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9367 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9368 signedness issues.
f839df0c
PE
9369 (Fset_file_times, Finsert_file_contents, auto_save_error):
9370 Rename locals to avoid shadowing.
f14b7e14 9371
5716756e 9372 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9373 (Ftry_completion, Fall_completions): Rename or remove locals
9374 to avoid shadowing.
5716756e 9375
b4c3046a
PE
9376 * marker.c (bytepos_to_charpos): Remove; unused.
9377
b45db522
PE
9378 * lisp.h (verify_bytepos, count_markers): New decls,
9379 so that gcc does not warn that these functions aren't declared.
9380
85876d07
PE
9381 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9382 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9383 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9384 (copy_text): Remove unused local var.
85876d07 9385
03d78a21 9386 * filelock.c (within_one_second): Now static.
b3dd38ab 9387 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9388
5df8f01b
PE
9389 * buffer.c (fix_overlays_before): Mark locals as initialized.
9390 (fix_start_end_in_overlays): Likewise. This function should be
9391 simplified by using pointers-to-pointers, but that's a different
9392 matter.
b1d876f1 9393 (switch_to_buffer_1): Now static.
8f54f30a
PE
9394 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9395 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9396
a70072c9 9397 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9398 Fix pointer signedness issue.
edced198
PE
9399 (sys_subshell): Mark local as volatile if checking for lint,
9400 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9401 (MAXPATHLEN): Define only if needed.
a70072c9 9402
a0977c44
PE
9403 * process.c (serial_open, serial_configure): Move decls from here ...
9404 * systty.h: ... to here, so that they can be checked.
9405
a884fdcc
PE
9406 * fns.c (get_random, seed_random): Move extern decls from here ...
9407 * lisp.h: ... to here, so that they can be checked.
9408
604efe86 9409 * sysdep.c (reset_io): Now static.
b8950c94 9410 (wait_for_termination_signal): Remove; unused.
604efe86 9411
38fc62d9
PE
9412 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9413 (copy_keymap_item, append_key, push_text_char_description):
9414 Now static.
1004a21a 9415 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9416 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9417 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9418 (describe_map_tree):
9419 Rename locals to avoid shadowing.
38fc62d9 9420
2f2650da
PE
9421 * keyboard.c: Declare functions static if they are not used elsewhere.
9422 (echo_char, echo_dash, cmd_error, top_level_2):
9423 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9424 (read_char, kbd_buffer_get_event, make_lispy_position):
9425 (make_lispy_event, make_lispy_movement, apply_modifiers):
9426 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9427 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9428 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9429 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9430 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9431
a053e86c 9432 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9433 (mark_kboards): Move decl here ...
9434 * alloc.c (mark_kboards): ... from here.
a053e86c 9435
4752793e
PE
9436 * lisp.h (force_auto_save_soon): New decl.
9437
74f10ca7 9438 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9439 (DEFINE_DUMMY_FUNCTION): New macro.
9440 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9441 Use it.
c03cd23f
PE
9442 (main): Add casts to avoid warnings
9443 if GCC considers string literals to be constants.
74f10ca7 9444
022e70d4
PE
9445 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9446
59d6fe83
PE
9447 * dbusbind.c: Pointer signedness fixes.
9448 (xd_signature, xd_append_arg, xd_initialize):
9449 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9450 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9451 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9452 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9453
78320123
PE
9454 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9455 if GCC considers string literals to be constants.
49cebcca 9456 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9457
35ac2a97
SM
94582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9459
fb103ca9
SM
9460 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9461 (print_preprocess, print_object): New macro to fix last change.
9462
35ac2a97
SM
9463 * print.c (print_preprocess): Don't forget font objects.
9464
62973b41
JB
94652011-03-16 Juanma Barranquero <lekktu@gmail.com>
9466
9467 * emacs.c (USAGE3): Doc fixes.
9468
0e48bb22
AS
94692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9470
9471 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9472 structure.
9473
7684e57b
JB
94742011-03-14 Juanma Barranquero <lekktu@gmail.com>
9475
9476 * lisp.h (VWindow_system, Qfile_name_history):
9477 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9478 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9479 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9480
9481 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9482 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9483
9484 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9485 * w32console.c (detect_input_pending, read_input_pending)
9486 (encode_terminal_code):
9487 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9488 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9489 (w32_system_caret_y, Qfile_name_history):
9490 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9491 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9492 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9493 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9494 * w32proc.c (Qlocal, report_file_error):
9495 * w32term.c (Vwindow_system, updating_frame):
9496 * w32uniscribe.c (initialized, uniscribe_font_driver):
9497 Remove unneeded extern declarations.
9498
2aa46d6c
CY
94992011-03-14 Chong Yidong <cyd@stupidchicken.com>
9500
c96bbc66 9501 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9502
cffc6f3b
CY
95032011-03-13 Chong Yidong <cyd@stupidchicken.com>
9504
9505 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9506 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9507 These macros can no longer be used for assignment.
9508
44f230aa
SM
9509 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9510 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9511 (record_buffer_markers, fetch_buffer_markers): New functions for
9512 recording and fetching special buffer markers.
9513 (set_buffer_internal_1, set_buffer_temp): Use them.
9514
9515 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9516
9517 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9518
9519 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9520 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9521
9522 * xdisp.c (hscroll_window_tree):
9523 (reconsider_clip_changes): Use PT instead of BUF_PT.
9524
d251f04b
EZ
95252011-03-13 Eli Zaretskii <eliz@gnu.org>
9526
9527 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9528 $(EMACS_ROOT)/lib/intprops.h.
9529
f0c77cd1
PE
95302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9531
3eca4629
PE
9532 Fix more problems found by GCC 4.5.2's static checks.
9533
7c86ee98
PE
9534 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9535 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9536 (xg_free_frame_widgets): Make it clear that a local variable is
9537 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9538 (gdk_window_get_screen): Make it clear that this macro is needed
9539 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9540 (int_gtk_range_get_value): New function, which avoids a diagnostic
9541 from gcc -Wbad-function-cast.
9542 (xg_set_toolkit_scroll_bar_thumb): Use it.
9543 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9544 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9545 (get_utf8_string, xg_get_file_with_chooser):
9546 Rename locals to avoid shadowing.
9547 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9548
41729b81
PE
9549 * xgselect.c (xg_select): Remove unused var.
9550
f0c77cd1
PE
9551 * image.c (four_corners_best): Mark locals as initialized.
9552 (gif_load): Initialize transparent_p to zero (Bug#8238).
9553 Mark another local as initialized.
ec6cf4c6 9554 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9555
ce0ad53d 9556 * image.c (clear_image_cache): Now static.
d5d5a617 9557 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9558 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9559 (x_edge_detection): Remove unnecessary cast that
9560 gcc -Wbad-function-cast diagnoses.
2037898d 9561 (gif_load): Fix pointer signedness.
6ae141d6
PE
9562 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9563 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9564
33383987 95652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9566
d32df629
PE
9567 Improve quality of tests for time stamp overflow.
9568 For example, without this patch (encode-time 0 0 0 1 1
9569 1152921504606846976) returns the obviously-bogus value (-948597
9570 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9571 reports time overflow. See
9572 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9573 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9574 * editfns.c: Include limits.h and intprops.h.
9575 (TIME_T_MIN, TIME_T_MAX): New macros.
9576 (time_overflow): Move earlier, to before first use.
9577 (hi_time, lo_time): New functions, for an accurate test for
9578 out-of-range times.
9579 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9580 (Fget_internal_run_time): Don't assume time_t fits in int.
9581 (make_time): Use list2 instead of Fcons twice.
9582 (Fdecode_time): More accurate test for out-of-range times.
9583 (check_tm_member): New function.
9584 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9585 (lisp_time_argument): Don't rely on undefined left-shift and
9586 right-shift behavior when checking for time stamp overflow.
8be6f318 9587
fe31d94c
PE
9588 * editfns.c (time_overflow): New function, refactoring common code.
9589 (Fformat_time_string, Fdecode_time, Fencode_time):
9590 (Fcurrent_time_string): Use it.
9591
8be6f318
PE
9592 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9593 * dired.c (make_time): Move to ...
9594 * editfns.c (make_time): ... here.
9595 * systime.h: Note the move.
9596
09d9db2c 95972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9598
126bc0dc
YM
9599 * fringe.c (update_window_fringes): Remove unused variables.
9600
c47cbdfd
YM
9601 * unexmacosx.c (copy_data_segment): Also copy __got section.
9602 (Bug#8223)
9603
7ac80be9
EZ
96042011-03-12 Eli Zaretskii <eliz@gnu.org>
9605
c96bbc66 9606 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9607 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9608 Constify `char *' arguments and their references according to
9609 prototypes in tparam.h.
9610
ecb0f94d 9611 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9612
7ac80be9
EZ
9613 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9614 Adapt all references accordingly.
9615
9616 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9617
ef1fd07e
TT
96182011-03-11 Tom Tromey <tromey@redhat.com>
9619
9620 * buffer.c (syms_of_buffer): Remove obsolete comment.
9621
7ef4b50c
EZ
96222011-03-11 Eli Zaretskii <eliz@gnu.org>
9623
9624 * termhooks.h (encode_terminal_code): Declare prototype.
9625
9626 * msdos.c (encode_terminal_code): Don't declare prototype.
9627
9628 * term.c (encode_terminal_code): Now external again, used by
9629 w32console.c and msdos.c.
9630
44f230aa
SM
9631 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9632 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9633
4b1ec863 96342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9635
1714f52b 9636 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9637
4b1ec863
PE
9638 * fringe.c (update_window_fringes): Mark locals as initialized
9639 (Bug#8227).
9640 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9641
524c7aa6
PE
9642 * alloc.c (mark_fringe_data): Move decl from here ...
9643 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9644 to check its interface.
9645 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9646
a5c0af81 9647 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9648 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9649 (fontset_font): Mark local as initialized.
a9a06e0b 9650 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9651
b4716021
PE
9652 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9653
811e9bac 9654 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9655 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9656 (x_own_selection, Fx_disown_selection_internal): Rename locals
9657 to avoid shadowing.
9658 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9659
7e3ab302
PE
9660 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9661 so that the caller can use some name other than gcpro1.
9662 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9663 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9664 (Fx_backspace_delete_keys_p):
9665 Use them to avoid shadowing, and rename vars to avoid shadowing.
9666 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9667 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9668 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9669 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9670 Remove unused locals.
7e3ab302
PE
9671 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9672 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9673 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9674 macros.
f78faa98 9675
e2b13473
PE
9676 * xterm.h (x_mouse_leave): New decl.
9677
77f23912
PE
9678 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9679 Remove unused functions.
cdf4ba58
PE
9680 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9681 (x_calc_absolute_position): Now static.
7411c686 9682 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9683 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9684 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9685 unless they are used.
38d0b34a
PE
9686 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9687 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9688 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9689 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9690 (x_error_catcher, x_connection_closed, x_error_handler):
9691 (x_error_quitter, xembed_send_message, x_iconify_frame):
9692 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9693 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9694 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9695
44f230aa
SM
9696 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9697 Rename or move locals to avoid shadowing.
6b463e58 9698 (tty_defined_color, merge_face_heights): Now static.
5967d051 9699 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9700 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9701 does not deduce is never used uninitialized.
73719eba
PE
9702 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9703 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9704
426994c3 9705 * terminal.c (store_terminal_param): Now static.
5489860b 9706
032f1620 9707 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9708 (set_frame_menubar): Remove unused local.
d4323972 9709 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9710 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9711 since they might point to immutable storage.
281585b0
PE
9712 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9713 since it's unused otherwise.
032f1620 9714
367c19e5 9715 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9716 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9717 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9718 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9719 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9720 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9721 does not deduce are never used uninitialized.
70739cbe 9722
07b48fa9
PE
9723 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9724
8868a238 9725 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9726 * window.c (window_loop, size_window):
9727 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9728
7e5cf297 9729 * window.c (display_buffer): Now static.
d6550a9f
PE
9730 (size_window): Mark variables that gcc -Wuninitialized
9731 does not deduce are never used uninitialized.
a586633d
PE
9732 * window.h (check_all_windows): New decl, to forestall
9733 gcc -Wmissing-prototypes diagnostic.
5b555da1 9734 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9735
f6095868
PE
9736 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9737 shadowing.
9738 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9739 Include <limits.h>.
9740 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9741 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9742 (load_charset_map): Mark variables that gcc -Wuninitialized
9743 does not deduce are never used uninitialized.
53df7c11 9744 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9745
f38b440c
PE
9746 * coding.c (coding_set_source, coding_set_destination):
9747 Use "else { /* comment */ }" rather than "else /* comment */;"
9748 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9749 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9750 a block, when the outer 'i' will do.
9751 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9752 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9753 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9754 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9755 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9756 Rename locals to avoid shadowing.
9757 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9758 * coding.c (emacs_mule_char, encode_invocation_designation):
9759 Now static, since they're not used elsewhere.
413bb2db 9760 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9761 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9762 (decode_coding_emacs_mule): Mark variables that gcc
9763 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9764 (detect_coding_iso_2022): Initialize a local variable that might
9765 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9766 this initialization is needed. (Bug#8211)
5f58e762
PE
9767 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9768 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9769 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9770 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9771 Remove unused macros.
f38b440c 9772
232b38b9 9773 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9774 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9775 * character.c (string_count_byte8): Likewise.
232b38b9 9776
fb90da1b
PE
9777 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9778 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9779
fb93dbc2
PE
9780 * chartab.c (copy_sub_char_table): Now static, since it's not used
9781 elsewhere.
5c156ace
PE
9782 (sub_char_table_ref_and_range, char_table_ref_and_range):
9783 Rename locals to avoid shadowing.
bbcd0949 9784 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9785
7d3b3862 9786 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9787 (BIDI_BOB): Remove unused macro.
7d3b3862 9788
6be7d3da
PE
9789 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9790 deduce are never used uninitialized.
c2ed9c8b 9791 * term.c (encode_terminal_code): Likewise.
6be7d3da 9792
75f8807f 9793 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9794
50938595
PE
9795 * tparam.h: New file.
9796 * term.c, tparam.h: Include it.
9797 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9798 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9799 Move these decls to tparam.h, and make them agree with what
9800 is actually in tparam.c. The previous trick of using incompatible
9801 decls in different modules does not conform to the C standard.
9802 All callers of tparam changed to use tparam's actual API.
9803 * tparam.c (tparam1, tparam, tgoto):
9804 Use const pointers where appropriate.
9805
fbceeba2
PE
9806 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9807 * cm.h (struct cm): Likewise.
9808 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9809 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9810 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9811 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9812 (turn_on_face, init_tty): Likewise.
9813 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9814
7f3f1250
PE
9815 * term.c (term_mouse_position): Rename local to avoid shadowing.
9816
e6ca6543
PE
9817 * alloc.c (mark_ttys): Move decl from here ...
9818 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9819
c40f8d15
AS
98202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9821
9822 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9823
cfe0661d
JB
98242011-03-09 Juanma Barranquero <lekktu@gmail.com>
9825
9826 * search.c (compile_pattern_1): Remove argument regp, unused since
9827 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9828 (compile_pattern): Don't pass it.
9829
0afb4571
J
98302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9831
9832 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9833 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9834 for ! HAVE_GTK3.
9835 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9836
9837 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9838
9839 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9840 gdk_window_get_screen, gdk_window_get_geometry,
9841 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9842 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9843 (xg_get_pixbuf_from_pixmap): New function.
9844 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9845 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9846 Call xg_get_pixbuf_from_pixmap instead of
9847 gdk_pixbuf_get_from_drawable.
9848 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9849 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9850 (xg_check_special_colors): Use GtkStyleContext and its functions
9851 for HAVE_GTK3.
9852 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9853 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9854 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9855 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9856 Call gtk_widget_get_preferred_size.
0afb4571
J
9857 (xg_frame_resized): gdk_window_get_geometry only takes 5
9858 parameters.
44f230aa
SM
9859 (xg_win_to_widget, xg_event_is_for_menubar):
9860 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9861 (xg_set_widget_bg): New function.
9862 (delete_cb): New function.
895009e1 9863 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9864 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9865 (xg_set_background_color): Call xg_set_widget_bg.
9866 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9867 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9868 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9869 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9870 if ! HAVE_GTK3.
9871 (update_frame_tool_bar): Call gtk_widget_hide.
9872 (xg_initialize): Use GDK_KEY_g.
9873
9874 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9875 if ! HAVE_GTK3
9876 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9877
9878 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9879 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9880 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9881
1c2cc4ef
JB
98822011-03-08 Juanma Barranquero <lekktu@gmail.com>
9883
9884 * w32xfns.c (select_palette): Check success of RealizePalette against
9885 GDI_ERROR, not zero.
9886
33383987 9887See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9888
9889;; Local Variables:
9890;; coding: utf-8
aac0c6e3
MR
9891;; End:
9892
2f097256 9893 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9894
9895 This file is part of GNU Emacs.
9896
9897 GNU Emacs is free software: you can redistribute it and/or modify
9898 it under the terms of the GNU General Public License as published by
9899 the Free Software Foundation, either version 3 of the License, or
9900 (at your option) any later version.
9901
9902 GNU Emacs is distributed in the hope that it will be useful,
9903 but WITHOUT ANY WARRANTY; without even the implied warranty of
9904 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9905 GNU General Public License for more details.
9906
9907 You should have received a copy of the GNU General Public License
9908 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.