Restore accidental change to insert-register
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1692ae2d 12011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2
8a6ebd58 3 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4 sigprocmask is portable only for single-threaded applications, and
5 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7 (LIBES): Use it.
8 * callproc.c (Fcall_process):
9 * process.c (create_process):
10 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
11 Use pthread_sigmask, not sigprocmask.
123403e4 12
1b854618
JD
132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
14
15 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
16 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
17 wrong (Bug#8591).
18
3fe4b549
JD
192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
20
0ce7e563
JD
21 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
22 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
23 (xg_hide_tooltip): Fix comment.
24
3fe4b549
JD
25 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
26 in registerServicesMenuSendTypes.
27 (validRequestorForSendType): Don't check ns_return_types.
28
29 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
30 ns_return_type.
31
5df75e47
JR
322011-07-08 Jason Rumney <jasonr@gnu.org>
33
34 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
35 frame struct members of non-existent frames (Bug#6284).
36
699c10bd
JD
372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
38
4393663b
JD
39 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
40 variable firstTime not needed on OSX >= 10.6.
41 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
42 >= 10.5. Use setKnobProportion, setDoubleValue.
43
44 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
45 (MAC_OS_X_VERSION_10_5): Define if not defined.
46 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
47 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
48 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
49
50 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
51 cString and lossyCString on OSX >= 10.4
52
53 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
54 sizeToFit on OSX >= 10.2.
55
56 * nsimage.m (allocInitFromFile): Don't use deprecated method
57 bestRepresentationForDevice on OSX >= 10.6.
58
59 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
60 to avoid warning.
61
62 * emacs.c: Declare unexec_init_emacs_zone.
63
a63e0781
JD
64 * nsgui.h: Fix compiler warning about gnulib redefining verify.
65
699c10bd
JD
66 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
67
68 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
69 on svcsMenu (Bug#8842).
70
71 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
72 ns_return_types.
73 (Fns_list_services): Just return Qnil on 10.6, code not working there.
74
75 * nsterm.m (QUTF8_STRING): Declare.
76 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
77 (validRequestorForSendType): Return type is (id).
78 Change indexOfObjectIdenticalTo to indexOfObject.
79 Check if we have local selection before returning self (Bug#8842).
80 (writeSelectionToPasteboard): Put local selection into paste board
81 if we have a local selection (Bug#8842).
82 (syms_of_nsterm): DEFSYM QUTF8_STRING.
83
84 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
85 (ns_get_local_selection): Declare.
86
54e10184
LMI
872011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
88
9888ff71
LMI
89 * keymap.c (describe_map_tree): Don't insert a double newline at
90 the end of the buffer (bug#1169) and return whether we inserted
91 something.
92
54e10184
LMI
93 * callint.c (Fcall_interactively): Change "reading args" to
94 "providing args" to try to clarify what it does (bug#1010).
95
15fa4783
KH
962011-07-07 Kenichi Handa <handa@m17n.org>
97
98 * composite.c (composition_compute_stop_pos): Ignore a static
99 composition starting before CHARPOS (Bug#8915).
100
101 * xdisp.c (handle_composition_prop): Likewise.
102
a8815b00
EZ
1032011-07-07 Eli Zaretskii <eliz@gnu.org>
104
105 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
106 (Bug#9015)
107
ef7b981d 1082011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
109
110 * character.h (unicode_category_t): New enum type.
111
112 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
113 (Qchar_code_property_table): New variable.
114 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
115 (UNIPROP_COMPRESSED_FORM_P): New macros.
116 (char_table_ascii): Uncompress the compressed values.
117 (sub_char_table_ref): New arg is_uniprop. Callers changed.
118 Uncompress the compressed values.
119 (sub_char_table_ref_and_range): Likewise.
120 (char_table_ref_and_range): Uncompress the compressed values.
121 (sub_char_table_set): New arg is_uniprop. Callers changed.
122 Uncompress the compressed values.
123 (sub_char_table_set_range): Args changed. Callers changed.
124 (char_table_set_range): Adjuted for the above change.
125 (map_sub_char_table): Delete args default_val and parent. Add arg
126 top. Give decoded values to a Lisp function.
127 (map_char_table): Adjusted for the above change. Give decoded
128 values to a Lisp function. Gcpro more variables.
129 (uniprop_table_uncompress)
130 (uniprop_decode_value_run_length): New functions.
131 (uniprop_decoder, uniprop_decoder_count): New variables.
132 (uniprop_get_decoder, uniprop_encode_value_character)
133 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
134 New functions.
135 (uniprop_encoder, uniprop_encoder_count): New variables.
136 (uniprop_get_encoder, uniprop_table)
137 (Funicode_property_table_internal, Fget_unicode_property_internal)
138 (Fput_unicode_property_internal): New functions.
139 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
140 Sunicode_property_table_internal, Sget_unicode_property_internal,
141 and Sput_unicode_property_internal. Defvar_lisp
142 char-code-property-alist.
143
144 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
145 Vunicode_category_table.
146
147 * font.c (font_range): Adjusted for the change of
148 Vunicode_category_table.
149
76b397fb
DN
1502011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
151
152 * m/iris4d.h: Remove file, move contents ...
153 * s/irix6-5.h: ... here.
154
22b4128e
PE
1552011-07-06 Paul Eggert <eggert@cs.ucla.edu>
156
157 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
158 * alloc.c (mark_buffer):
159 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
160 (clone_per_buffer_values): Don't assume that
22b4128e
PE
161 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
162 This isn't true in general, and it's particularly not true
163 if Emacs is configured with --with-wide-int.
164 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
165 New macros, used in the buffer.c change.
166
869795d6
JD
1672011-07-05 Jan Djärv <jan.h.d@swipnet.se>
168
169 * xsettings.c: Use both GConf and GSettings if both are available.
170 (store_config_changed_event): Add comment.
171 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
172 (store_tool_bar_style_changed): New functions.
173 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
174 (struct xsettings): Move font inside HAVE_XFT.
175 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
176 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
177 Move inside HAVE_XFT.
178 (something_changed_gsettingsCB): Renamed from something_changedCB.
179 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
180 also.
181 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
182 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
183 (something_changed_gconfCB): Renamed from something_changedCB.
184 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
185 (parse_settings): Move check for font inside HAVE_XFT.
186 (read_settings, apply_xft_settings): Add comment.
187 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
188 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
189 call store_font_name_changed.
190 (xft_settings_event): Add comment.
191 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
192 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
193 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
194 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
195 (xsettings_initialize): Call init_gsettings last.
196 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
197 comment.
198
d8ed26bd
PE
1992011-07-05 Paul Eggert <eggert@cs.ucla.edu>
200
201 Random fixes. E.g., (random) never returned negative values.
202 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
203 subseconds part to the entropy, as that's a bit more random.
204 Prefer signed to unsigned, since the signedness doesn't matter and
205 in general we prefer signed. When given a limit, use a
206 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
207 latter isn't right if USE_2_TAGS_FOR_INTS.
208 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
209 not 0..VALMASK. Don't discard "excess" bits that random () returns.
210
cabf1cac
SM
2112011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
212
213 * textprop.c (text_property_stickiness):
214 Obey Vtext_property_default_nonsticky.
215 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
216 * w32fns.c (syms_of_w32fns):
217 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
218
6e9b2be9
PE
2192011-07-04 Paul Eggert <eggert@cs.ucla.edu>
220
221 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
222 This is more efficient than Ffile_directory_p and avoids a minor race.
223
90186c68
LMI
2242011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
225
7c301272
LMI
226 * buffer.c (Foverlay_put): Say what the return value is
227 (bug#7835).
228
c4f2d8d4
LMI
229 * fileio.c (barf_or_query_if_file_exists): Check first if the file
230 is a directory before asking whether to use the file name
231 (bug#7564).
ad637907
LMI
232 (barf_or_query_if_file_exists): Make the "File is a directory"
233 error be more correct.
c4f2d8d4 234
90186c68
LMI
235 * fns.c (Frequire): Remove the mention of the .gz files, since
236 that's installation-specific, but keep the mention of
237 `get-load-suffixes'.
238
da64016e
PE
2392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
240
241 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
242 Report string overflow if the output is too long.
243
7d47b580
JB
2442011-07-04 Juanma Barranquero <lekktu@gmail.com>
245
a555cb87
JB
246 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
247 (syms_of_gnutls): Remove duplicate DEFSYM for
248 Qgnutls_bootprop_verify_hostname_error, an error for
249 Qgnutls_bootprop_verify_error (which is no longer used).
250
7d47b580
JB
251 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
252 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
253 Also (re)move comments that are misplaced or no longer relevant.
254
1e49bfab
LMI
2552011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
256
257 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
258
1485f4c0
CY
2592011-07-03 Chong Yidong <cyd@stupidchicken.com>
260
261 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
262 and background color parameters if they have been changed.
263
a9ab721e
LMI
2642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
265
266 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
267
cf7cff57
PE
2682011-07-03 Paul Eggert <eggert@cs.ucla.edu>
269
2e13213d
PE
270 * xsettings.c (SYSTEM_FONT): Define only when used.
271 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
272
cf7cff57
PE
273 * keymap.c (access_keymap_1): Now static.
274
7a8e04f7
CY
2752011-07-02 Chong Yidong <cyd@stupidchicken.com>
276
277 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
278 leave any prefix arg for the up event (Bug#1586).
279
61352f62
LMI
2802011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
281
69bb1ef7
LMI
282 * lread.c (syms_of_lread): Mention single symbols defined by
283 `defvar' or `defconst' (bug#7154).
284
61352f62 285 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 286 (Frequire): Mention get-load-suffixes.
61352f62 287
28545e04
MR
2882011-07-02 Martin Rudalics <rudalics@gmx.at>
289
290 * window.h (window): Remove clone_number slot.
291 * window.c (Fwindow_clone_number, Fset_window_clone_number):
292 Remove.
293 (make_parent_window, make_window, saved_window)
294 (Fset_window_configuration, save_window_save): Don't deal with
295 clone numbers.
296 * buffer.c (Qclone_number): Remove declaration.
297 (sort_overlays, overlay_strings): Don't deal with clone numbers.
298
3349e122
SM
2992011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
300
301 Add multiple inheritance to keymaps.
302 * keymap.c (Fmake_composed_keymap): New function.
303 (Fset_keymap_parent): Simplify.
304 (fix_submap_inheritance): Remove.
305 (access_keymap_1): New function extracted from access_keymap to handle
306 embedded parents and handle lists of maps.
307 (access_keymap): Use it.
308 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
309 (Fcopy_keymap): Handle embedded parents.
310 (Fcommand_remapping, define_as_prefix): Simplify.
311 (Fkey_binding): Simplify.
312 (syms_of_keymap): Move minibuffer-local-completion-map,
313 minibuffer-local-filename-completion-map,
314 minibuffer-local-must-match-map, and
315 minibuffer-local-filename-must-match-map to Elisp.
316 (syms_of_keymap): Defsubr make-composed-keymap.
317 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
318 (parse_menu_item): Trivial simplification.
319
3279eb87
GM
3202011-07-01 Glenn Morris <rgm@gnu.org>
321
322 * Makefile.in (SETTINGS_LIBS): Fix typo.
323
4550efdf
KI
3242011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
325
326 * coding.c (Fencode_coding_string): Record the last coding system
327 used, as the function doc string says (bug#8738).
328
0949d2b6
JD
3292011-07-01 Jan Djärv <jan.h.d@swipnet.se>
330
331 * xsettings.c (store_monospaced_changed): Take new font as arg and
332 check for change against current_mono_font.
333 (EMACS_TYPE_SETTINGS): Remove this and related defines.
334 (emacs_settings_constructor, emacs_settings_get_property)
335 (emacs_settings_set_property, emacs_settings_class_init)
336 (emacs_settings_init, gsettings_obj): Remove.
337 (something_changedCB): New function for HAVE_GSETTINGS.
338 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
339 with value as argument.
340 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
341 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 342 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
343 "changed".
344
345 * xgselect.c: Add defined (HAVE_GSETTINGS).
346 (xgselect_initialize): Ditto.
347
348 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
349 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
350 xg_select.
351
bbc6b304
PE
3522011-07-01 Paul Eggert <eggert@cs.ucla.edu>
353
354 * eval.c (struct backtrace): Simplify and port the data structure.
355 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
356 signed bit field, as this assumption is not portable and it makes
357 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
358 "char debug_on_exit : 1" as this is not portable either; instead,
359 use the portable "unsigned int debug_on_exit : 1". Remove unused
360 member evalargs. Remove obsolete comments about cc bombing out.
361
9851bfc5
JD
3622011-06-30 Jan Djärv <jan.h.d@swipnet.se>
363
51bb811f 364 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
365 Let HAVE_GSETTINGS override HAVE_GCONF.
366 (store_monospaced_changed): New function.
367 (EMACS_SETTINGS): A new type derived from GObject to handle
368 GSettings notifications.
369 (emacs_settings_constructor, emacs_settings_get_property)
370 (emacs_settings_set_property, emacs_settings_class_init):
371 New functions.
372 (gsettings_client, gsettings_obj): New variables.
373 (GSETTINGS_SCHEMA): New define.
374 (something_changedCB): Call store_monospaced_changed.
375 (init_gsettings): New function.
376 (xsettings_initialize): Call init_gsettings.
377 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
378 to NULL.
379
380 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
381 GCONF_CFLAGS/LIBS.
382
5386012d
MR
3832011-06-29 Martin Rudalics <rudalics@gmx.at>
384
385 * window.c (resize_root_window, grow_mini_window)
386 (shrink_mini_window): Rename Qresize_root_window to
387 Qwindow_resize_root_window and Qresize_root_window_vertically to
388 Qwindow_resize_root_window_vertically.
389
f13e0b08
PE
3902011-06-28 Paul Eggert <eggert@cs.ucla.edu>
391
392 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
393
94515237
JB
3942011-06-27 Juanma Barranquero <lekktu@gmail.com>
395
396 * makefile.w32-in: Redesign dependencies so they reflect more
397 clearly which files are directly included by each source file,
398 and not through other includes.
399
e43b6e43
MR
4002011-06-27 Martin Rudalics <rudalics@gmx.at>
401
402 * buffer.c (Qclone_number): Declare static and DEFSYM it.
403 (sort_overlays, overlay_strings): When an overlay's clone number
404 matches the window's clone number process the overlay even if
405 the overlay's window property doesn't match the current window.
406
d68443dc
MR
407 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
408 (Fwindow_hchild): Rename to Fwindow_left_child.
409 (Fwindow_next): Rename to Fwindow_next_sibling.
410 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
411 (resize_window_check): Rename to window_resize_check.
412 (resize_window_apply): Rename to window_resize_apply.
413 (Fresize_window_apply): Rename to Fwindow_resize_apply.
414 (Fdelete_other_windows_internal, resize_frame_windows)
415 (Fsplit_window_internal, Fdelete_window_internal)
416 (grow_mini_window, shrink_mini_window)
417 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 418
c7e73be5
JD
4192011-06-26 Jan Djärv <jan.h.d@swipnet.se>
420
421 * emacsgtkfixed.h: State that this is only used with Gtk+3.
422 (emacs_fixed_set_min_size): Remove.
423 (emacs_fixed_new): Take frame as argument.
424
425 * emacsgtkfixed.c: State that this is only used with Gtk+3.
426 (_EmacsFixedPrivate): Remove minwidth/height.
427 Add struct frame *f.
428 (emacs_fixed_init): Initialize priv->f.
429 (get_parent_class, emacs_fixed_set_min_size): Remove.
430 (emacs_fixed_new): Set priv->f to argument.
431 (emacs_fixed_get_preferred_width)
432 (emacs_fixed_get_preferred_height): Use min_width/height from
433 frames size_hint to set minimum and natural (Bug#8919).
434 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
435 and use min_width/height from frames size_hint to set
436 min_width/height (Bug#8919).
437
438 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
439 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
440 Fix indentation.
c7e73be5 441
cf99dcf8
EZ
4422011-06-26 Eli Zaretskii <eliz@gnu.org>
443
444 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
445 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
446 called at ZV.
447
029529ac
CY
4482011-06-26 Chong Yidong <cyd@stupidchicken.com>
449
450 * process.c (wait_reading_process_output): Bypass select if
451 waiting for a cell while ignoring keyboard input, and input is
452 pending. Suggested by Jan Djärv (Bug#8869).
453
7a7ef429
PE
4542011-06-25 Paul Eggert <eggert@cs.ucla.edu>
455
456 Use gnulib's dup2 module instead of rolling our own.
457 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
458
11fdef7d 4592011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
460
461 * dispnew.c (scrolling_window): Before scrolling, turn off a
462 mouse-highlight in the window being scrolled.
463
cd3520a4
JB
4642011-06-24 Juanma Barranquero <lekktu@gmail.com>
465
466 Move DEFSYM to lisp.h and use everywhere.
467
468 * character.h (DEFSYM): Move declaration...
469 * lisp.h (DEFSYM): ...here.
470
471 * gnutls.c:
472 * minibuf.c:
473 * w32menu.c:
474 * w32proc.c:
475 * w32select.c: Don't include character.h.
476
477 * alloc.c (syms_of_alloc):
478 * buffer.c (syms_of_buffer):
479 * bytecode.c (syms_of_bytecode):
480 * callint.c (syms_of_callint):
481 * casefiddle.c (syms_of_casefiddle):
482 * casetab.c (init_casetab_once):
483 * category.c (init_category_once, syms_of_category):
484 * ccl.c (syms_of_ccl):
485 * cmds.c (syms_of_cmds):
486 * composite.c (syms_of_composite):
487 * dbusbind.c (syms_of_dbusbind):
488 * dired.c (syms_of_dired):
489 * dispnew.c (syms_of_display):
490 * doc.c (syms_of_doc):
491 * editfns.c (syms_of_editfns):
492 * emacs.c (syms_of_emacs):
493 * eval.c (syms_of_eval):
494 * fileio.c (syms_of_fileio):
495 * fns.c (syms_of_fns):
496 * frame.c (syms_of_frame):
497 * fringe.c (syms_of_fringe):
498 * insdel.c (syms_of_insdel):
499 * keymap.c (syms_of_keymap):
500 * lread.c (init_obarray, syms_of_lread):
501 * macros.c (syms_of_macros):
502 * msdos.c (syms_of_msdos):
503 * print.c (syms_of_print):
504 * process.c (syms_of_process):
505 * search.c (syms_of_search):
506 * sound.c (syms_of_sound):
507 * syntax.c (init_syntax_once, syms_of_syntax):
508 * terminal.c (syms_of_terminal):
509 * textprop.c (syms_of_textprop):
510 * undo.c (syms_of_undo):
511 * w32.c (globals_of_w32):
512 * window.c (syms_of_window):
513 * xdisp.c (syms_of_xdisp):
514 * xfaces.c (syms_of_xfaces):
515 * xfns.c (syms_of_xfns):
516 * xmenu.c (syms_of_xmenu):
517 * xsettings.c (syms_of_xsettings):
518 * xterm.c (syms_of_xterm): Use DEFSYM.
519
4228cf16
TZ
5202011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
521
cd3520a4 522 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 523
7fcccf1e
PE
5242011-06-23 Paul Eggert <eggert@cs.ucla.edu>
525
7efb4e0e
PE
526 Integer and buffer overflow fixes (Bug#8873).
527
ff5844ad
PE
528 * print.c (printchar, strout): Check for string overflow.
529 (PRINTPREPARE, printchar, strout):
530 Don't set size unless allocation succeeds.
531
90532f02
PE
532 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
533 for sizes. Check for string overflow more accurately.
534 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
535
6d84508d
PE
536 * macros.c: Integer and buffer overflow fixes.
537 * keyboard.h (struct keyboard.kbd_macro_bufsize):
538 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
539 Use ptrdiff_t, not int, for sizes.
540 Don't increment bufsize until after realloc succeeds.
541 Check for size-calculation overflow.
542 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
543
437b2cb4
PE
544 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
545
8b9ac8b4
PE
546 * lread.c: Integer overflow fixes.
547 (read_integer): Radix is now EMACS_INT, not int,
548 to improve quality of diagnostics for out-of-range radices.
549 Calculate buffer size correctly for out-of-range radices.
550 (read1): Check for integer overflow in radices, and in
551 read-circle numbers.
82cb60d3
PE
552 (read_escape): Avoid int overflow.
553 (Fload, openp, read_buffer_size, read1)
554 (substitute_object_recurse, read_vector, read_list, map_obarray):
555 Use ptrdiff_t, not int, for sizes.
556 (read1): Use EMACS_INT, not int, for sizes.
20270765 557 Check for size overflow.
8b9ac8b4 558
7fcccf1e
PE
559 * image.c (cache_image): Check for size arithmetic overflow.
560
bfbbd7e7
PE
561 * lread.c: Integer overflow issues.
562 (saved_doc_string_size, saved_doc_string_length)
563 (prev_saved_doc_string_size, prev_saved_doc_string_length):
564 Now ptrdiff_t, not int.
565 (read1): Don't assume doc string length fits in int. Check for
566 out-of-range doc string lengths.
567 (read_list): Don't assume file position fits in int.
39019e54 568 (read_escape): Check for hex character overflow.
bfbbd7e7 569
4e323265
LL
5702011-06-22 Leo Liu <sdl.web@gmail.com>
571
572 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
573 Move to minibuffer.el.
574
85fece3e
PE
5752011-06-22 Paul Eggert <eggert@cs.ucla.edu>
576
20b84ce9 577 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
578 The following patches are for when GLYPH_DEBUG && !XASSERT.
579 * dispextern.h (trace_redisplay_p, dump_glyph_string):
580 * dispnew.c (flush_stdout):
581 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
582 Mark as externally visible.
583 * dispnew.c (check_window_matrix_pointers): Now static.
584 * dispnew.c (window_to_frame_vpos):
585 * xfns.c (unwind_create_frame):
586 * xterm.c (x_check_font): Remove unused local.
587 * scroll.c (CHECK_BOUNDS):
588 * xfaces.c (cache_fache): Rename local to avoid shadowing.
589 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
590 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
591 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
592 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
593 Now static.
594 (debug_method_add): Use va_list and vsprintf rather than relying
595 on undefined behavior with wrong number of arguments.
596 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
597 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
598 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
599 since we're not interested in debugging glyphs with old libraries.
600 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
601 GCC 4.6.0's static checking.
602
0766b489
PE
6032011-06-22 Paul Eggert <eggert@cs.ucla.edu>
604
31fd4b32
PE
605 Integer overflow and signedness fixes (Bug#8873).
606 A few related buffer overrun fixes, too.
607
b79e8648
PE
608 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
609
0766b489
PE
610 * dispextern.h (struct face.stipple):
611 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
612 (x_bitmap_mask, x_allocate_bitmap_record)
613 (x_create_bitmap_from_data, x_create_bitmap_from_file)
614 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
615 (x_create_bitmap_from_xpm_data):
616 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
617 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
618 (.bitmaps_last):
619 * xfaces.c (load_pixmap):
620 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
621 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
622 (.bitmaps_last, struct x_output.icon_bitmap):
623 Use ptrdiff_t, not int, for bitmap indexes.
624 (x_allocate_bitmap_record): Check for size overflow.
625 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
626
b081724f
PE
627 Use ptrdiff_t, not int, for overlay counts.
628 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
629 * editfns.c (overlays_around, get_pos_property):
630 * textprop.c (get_char_property_and_overlay):
631 * xdisp.c (next_overlay_change, note_mouse_highlight):
632 * xfaces.c (face_at_buffer_position):
21514da7
PE
633 * buffer.c (OVERLAY_COUNT_MAX): New macro.
634 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
635 (Fnext_overlay_change, Fprevious_overlay_change)
636 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 637 Use ptrdiff_t, not int, for sizes.
21514da7 638 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 639
3de73e5e
PE
640 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
641
2606c57b
PE
642 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
643 (x_session_initialize): Do not assume string length fits in int.
644
aaafe47a
PE
645 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
646 This is unlikely, but can occur if DPI is outlandish.
647
2674ddc8 648 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
649 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
650
28154962
PE
651 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
652 * xrdb.c (magic_file_p, search_magic_path):
653 Omit last arg SUFFIX; it was always 0. All callers changed.
654 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
655
7de51af5
PE
656 * xfont.c (xfont_match): Avoid need for strlen.
657
25ed6cc3
PE
658 * xfns.c: Don't assume strlen fits in int.
659 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
660
4eab31dd
PE
661 * xdisp.c (message_log_check_duplicate): Return intmax_t,
662 not unsigned long, as we prefer signed integers. All callers changed.
663 Detect integer overflow in repeat count.
664 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 665 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 666
171e2a58
PE
667 * termcap.c: Don't assume sizes fit in int and never overflow.
668 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
669 (gobble_line): Check for size-calculation overflow.
670
ad39faca 671 * minibuf.c (Fread_buffer):
6e5bb2dc 672 * lread.c (intern, intern_c_string):
74ca2eb3
PE
673 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
674 Don't assume string length fits in int.
675
52c61c22 676 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
677 * gtkutil.c (style_changed_cb): Avoid need for strlen.
678
b5b8c9e5
PE
679 * font.c: Don't assume string length fits in int.
680 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
681 Use ptrdiff_t, not int.
ccd6111c
PE
682 (font_intern_prop): Don't assume string length fits in int.
683 Don't assume integer property fits in fixnum.
684 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 685
882f0d81 686 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 687 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
688 Reformulate so as not to need the command string.
689 Invoke gzip -cd rather than gunzip, as it's more portable.
690 (lock_info_type, lock_file_1, lock_file):
691 Don't assume pid_t and time_t fit in unsigned long.
692 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
693 (current_lock_owner): Prefer signed type for sizes.
694 Use memcpy, not strncpy, where memcpy is what is really wanted.
695 Don't assume (via atoi) that time_t and pid_t fit in int.
696 Check for time_t and/or pid_t out of range, e.g., via a network share.
697 Don't alloca where an auto var works fine.
698
93f4cf88
PE
699 * fileio.c: Fix some integer overflow issues.
700 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
701 Don't assume string length fits in int.
702 (directory_file_name): Don't assume string length fits in long.
703 (make_temp_name): Don't assume pid fits in int, or that its print
704 length is less than 20.
705
f3e92b69
PE
706 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
707
1bfdaf10
PE
708 * coding.c (make_subsidiaries): Don't assume string length fits in int.
709
35016e9a
PE
710 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
711
3d1e65a1
PE
712 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
713 We prefer signed integers, even for size calculations.
714
0b963a93
PE
715 * emacs.c: Don't assume string length fits in 'int'.
716 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
717 (main): Don't invoke strlen when not needed.
718
573f4b54
PE
719 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
720 (XD_DEBUG_MESSAGE): Don't waste a byte.
721
989f33ba
PE
722 * callproc.c (getenv_internal_1, getenv_internal)
723 (Fgetenv_internal):
965d34eb
PE
724 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
725
e4d29b33
PE
726 * lread.c (invalid_syntax): Omit length argument.
727 All uses changed. This doesn't fix a bug, but it simplifies the
728 code away from its former Hollerith-constant appearance, and it's
729 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 730 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 731
eb49b136
PE
732 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
733 This didn't break anything, but it didn't help either.
734 It's confusing to put a bogus integer in a place where the actual
735 value does not matter.
9f62aeb1 736 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 737 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 738
15375a22
PE
739 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
740 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
741 implementation.
b61cc01c
PE
742 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
743 We prefer signed types, and the value cannot exceed the EMACS_INT
744 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
745 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
746 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
747 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 748
53b2623d
PE
749 * indent.c (sane_tab_width): New function.
750 (current_column, scan_for_column, Findent_to, position_indentation)
751 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 752 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 753
51cab52b 754 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 755
f2ed8a70
PE
756 * lisp.h (lint_assume): New macro.
757 * composite.c (composition_gstring_put_cache):
758 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
759
abe80cc6
PE
760 * editfns.c, insdel.c:
761 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 762
b02c740e
PE
763 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
764
ebc96716
PE
765 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
766
b4e50fa0 767 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 768 Use much-faster test for byte-length change.
311d5d7c 769 Don't assume string byte-length fits in 'int'.
a4cf38e4 770 Check that character arg fits in 'int'.
85461888 771 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 772
c0c1ee9f
PE
773 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
774
a498d7f4
PE
775 * fns.c (concat): Catch string overflow earlier.
776 Do not rely on integer wraparound.
777
51cab52b
PE
778 * dispextern.h (struct it.overlay_strings_charpos)
779 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
780 * xdisp.c (forward_to_next_line_start)
781 (back_to_previous_visible_line_start)
782 (reseat_at_next_visible_line_start, next_element_from_buffer):
783 Don't arbitrarily truncate the value of 'selective' to int.
784
76031fad
PE
785 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
786
5eb55db9
PE
787 * composite.c: Don't truncate sizes to 'int'.
788 (composition_gstring_p, composition_reseat_it)
789 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
790 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
791 not EMACS_UINT, for indexes.
5eb55db9 792
0703a717
PE
793 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
794
d6202519
PE
795 * buffer.c: Include <verify.h>.
796 (struct sortvec.priority, struct sortstr.priority):
8961a454 797 Now EMACS_INT, not int.
c20998a7 798 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
799 (struct sortstr.size, record_overlay_string)
800 (struct sortstrlist.size, struct sortlist.used):
801 Don't truncate size to int.
802 (record_overlay_string): Check for size-calculation overflow.
d6202519 803 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 804
d5a19415
JM
8052011-06-22 Jim Meyering <meyering@redhat.com>
806
029529ac 807 Don't leak an XBM-image-sized buffer
d5a19415
JM
808 * image.c (xbm_load): Free the image buffer after using it.
809
a9041e6c
PE
8102011-06-21 Paul Eggert <eggert@cs.ucla.edu>
811
812 Port to Sun C.
813 * composite.c (find_automatic_composition): Omit needless 'return 0;'
814 that Sun C diagnosed.
815 * fns.c (secure_hash): Fix pointer signedness issue.
816 * intervals.c (static_offset_intervals): New function.
817 (offset_intervals): Use it.
818
7f3f739f
LL
8192011-06-21 Leo Liu <sdl.web@gmail.com>
820
821 * deps.mk (fns.o):
822 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
823 sha512.h.
824
825 * fns.c (secure_hash): Rename from crypto_hash_function and change
826 the first arg to accept symbols.
5b66d427 827 (Fsecure_hash): New primitive.
7f3f739f
LL
828 (syms_of_fns): New symbols.
829
76147d94
DD
8302011-06-20 Deniz Dogan <deniz@dogan.se>
831
832 * process.c (Fset_process_buffer): Clarify return value in
833 docstring.
834
7d7d0045
CY
8352011-06-18 Chong Yidong <cyd@stupidchicken.com>
836
837 * dispnew.c (add_window_display_history): Use BVAR.
838
839 * xdisp.c (debug_method_add): Use BVAR.
840 (check_window_end, dump_glyph_matrix, dump_glyph)
841 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
842
843 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
844 Likewise.
845
846 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
847 check till after the cache is created in init_frame_faces.
848
ff2bc410
SM
8492011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
850
851 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
852
28177add
PE
8532011-06-16 Paul Eggert <eggert@cs.ucla.edu>
854
dd3482fe
PE
855 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
856 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
857 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
858
393d71f3 859 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
860 * fileio.c (Finsert_file_contents):
861 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
862 Remove the old (too-loose) buffer overflow checks.
863 They weren't needed, since make_gap checks for buffer overflow.
864 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
865 The old code merely checked for Emacs fixnum overflow, and relied
866 on undefined (wraparound) behavior. The new code avoids undefined
867 behavior, and also checks for ptrdiff_t and/or size_t overflow.
868
2e6813b0 869 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
870 Tune. Don't use wider integers than needed. Don't use alloca.
871 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 872
599a9e4f
PE
873 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
874
99561444
PE
875 * insdel.c, lisp.h (buffer_overflow): New function.
876 (insert_from_buffer_1, replace_range, replace_range_2):
877 * insdel.c (make_gap_larger):
878 * editfns.c (Finsert_char):
879 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
880
28177add
PE
881 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
882
e69dafad
PE
8832011-06-15 Paul Eggert <eggert@cs.ucla.edu>
884
a7af7fde 885 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 886
b1c46f02
PE
887 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
888 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
889
e69dafad
PE
890 * fileio.c: Don't assume EMACS_INT fits in off_t.
891 (emacs_lseek): New static function.
892 (Finsert_file_contents, Fwrite_region): Use it.
893 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
894
566684ea
PE
895 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
896
e6966cd6
PE
897 * fns.c: Don't overflow int when computing a list length.
898 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
899 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
900 truncation on 64-bit hosts. Check for QUIT every
901 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
902 faster and is responsive enough.
903 (Flength): Report an error instead of overflowing an integer.
904 (Fsafe_length): Return a float if the value is not representable
905 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 906 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 907 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 908
dd0b0efb
PE
909 * alloc.c: Check that resized vectors' lengths fit in fixnums.
910 (header_size, word_size): New constants.
911 (allocate_vectorlike): Don't check size overflow here.
912 (allocate_vector): Check it here instead, since this is the only
913 caller of allocate_vectorlike that could cause overflow.
914 Check that the new vector's length is representable as a fixnum.
915
86fe5cfe
PE
916 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
917 The previous code was bogus. For example, next_almost_prime (32)
918 returned 39, which is undesirable as it is a multiple of 3; and
919 next_almost_prime (24) returned 25, which is a multiple of 5 so
920 why was the code bothering to check for multiples of 7?
921
80e88859
PE
922 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
923
4a2f0ad6
PE
924 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
925
f66c7cf8
PE
926 Variadic C functions now count arguments with ptrdiff_t.
927 This partly undoes my 2011-03-30 change, which replaced int with size_t.
928 Back then I didn't know that the Emacs coding style prefers signed int.
929 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
930 were being counted with int, which may truncate counts on 64-bit
931 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
932 * lisp.h (struct Lisp_Subr.function.aMANY)
933 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
934 Arg counts are now ptrdiff_t, not size_t.
935 All variadic functions and their callers changed accordingly.
936 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
937 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
938 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
939 * callint.c (Fcall_interactively): Check arg count for overflow,
940 to avoid potential buffer overrun. Use signed char, not 'int',
941 for 'varies' array, so that we needn't bother to check its size
942 calculation for overflow.
943 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
944 * eval.c (apply_lambda):
945 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
946 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
947 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
948
a1759b76
PE
949 * callint.c (Fcall_interactively): Don't use index var as event count.
950
d96be9fc
PE
951 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
952 * mem-limits.h (SIZE): Remove; no longer used.
953
a690a978 954 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 955
578c21e6
PE
956 Remove unnecessary casts.
957 * xterm.c (x_term_init):
958 * xfns.c (x_set_border_pixel):
959 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
960 These aren't needed now that we assume ANSI C.
961
96f53c6c
PE
962 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
963 It's more likely to cause problems (due to unsigned overflow)
964 than to cure them.
965
83c77d31
PE
966 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
967
ee2079f1
PE
968 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
969
6da65536
PE
970 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
971
7147c4a4
PE
972 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
973
193e32d9
PE
974 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
975
e5533da6
PE
976 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
977
9910e595
PE
978 GLYPH_CODE_FACE returns EMACS_INT, not int.
979 * dispextern.h (merge_faces):
980 * xfaces.c (merge_faces):
01103c44
PE
981 * xdisp.c (get_next_display_element, next_element_from_display_vector):
982 Don't assume EMACS_INT fits in int.
9910e595 983
2638320e
PE
984 * character.h (CHAR_VALID_P): Remove unused parameter.
985 * fontset.c, lisp.h, xdisp.c: All uses changed.
986
045eb8d9
PE
987 * editfns.c (Ftranslate_region_internal): Omit redundant test.
988
c1f134b5
PE
989 * fns.c (concat): Minor tuning based on overflow analysis.
990 This doesn't fix any bugs. Use int to hold character, instead
991 of constantly refetching from Emacs object. Use XFASTINT, not
992 XINT, for value known to be a character. Don't bother comparing
993 a single byte to 0400, as it's always less.
994
395fcb93 995 * floatfns.c (Fexpt):
327eeec8
PE
996 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
997
abbd3d23
PE
998 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
999 for characters.
1000
684a03ef
PE
1001 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1002
0fed43f3
PE
1003 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1004 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1005 incorrectly succeed when S was a string, because 4294967386 was
1006 truncated before it was used.
1007
8fd02eb7
PE
1008 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1009 Otherwise, an out-of-range integer could cause undefined behavior
1010 on a 64-bit host.
1011
f8c86b69
PE
1012 * composite.c: Use int, not EMACS_INT, for characters.
1013 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1014 EMACS_INT, for values that are known to be in character range.
1015 This doesn't fix any bugs but is the usual style inside Emacs and
1016 may generate better code on 32-bit machines.
1017
34206dd2
PE
1018 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1019 This is for reasons similar to the recent CHAR_STRING fix.
1020 * charset.c (Fencode_char): Check that character arg is actually
1021 a character. Pass an int to ENCODE_CHAR.
1022 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1023 wider than 'int', as a compile-time check to prevent future regressions
1024 in this area.
1025
c5958d4c 1026 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1027
1028 Make sure a 64-bit char is never passed to CHAR_STRING.
1029 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1030 by silently ignoring the top 32 bits, allowing some values
1031 that were far too large to be valid characters.
1032 * character.h: Include <verify.h>.
1033 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1034 arguments are no wider than unsigned, as a compile-time check
1035 to prevent future regressions in this area.
1036 * data.c (Faset):
01103c44 1037 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1038 (Fsubst_char_in_region):
1039 * fns.c (concat):
1040 * xdisp.c (decode_mode_spec_coding):
1041 Adjust to CHAR_STRING's new requirement.
1042 * editfns.c (Finsert_char, Fsubst_char_in_region):
1043 * fns.c (concat): Check that character args are actually
1044 characters. Without this test, these functions did the wrong
1045 thing with wildly out-of-range values on 64-bit hosts.
1046
d37ca623
PE
1047 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1048 These casts should not be needed on 32-bit hosts, either.
1049 * keyboard.c (read_char):
1050 * lread.c (Fload): Remove casts to unsigned.
1051
ea204efb
PE
1052 * lisp.h (UNSIGNED_CMP): New macro.
1053 This fixes comparison bugs on 64-bit hosts.
1054 (ASCII_CHAR_P): Use it.
1055 * casefiddle.c (casify_object):
01103c44 1056 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1057 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1058 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1059 * dispextern.h (FACE_FROM_ID):
1060 * keyboard.c (read_char): Use UNSIGNED_CMP.
1061
41cb286c
PE
1062 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1063 not to EMACS_INT, to avoid GCC warning.
1064
4a1b9832
PE
1065 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1066
55daad71
PE
1067 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1068 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1069 isn't needed on 32-bit machines.
8f95c75c 1070
01103c44
PE
1071 * buffer.c (Fgenerate_new_buffer_name):
1072 Use EMACS_INT for count, not int.
0ceccced 1073 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1074
1075 * data.c (Qcompiled_function): Now static.
1076
c6f072e7
PE
1077 * window.c (window_body_lines): Now static.
1078
20ce5912
PE
1079 * image.c (gif_load): Rename local to avoid shadowing.
1080
9c4c5f81
PE
1081 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1082 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1083 * alloc.c (make_save_value): Integer argument is now of type
1084 ptrdiff_t, not int.
1085 (mark_object): Use ptrdiff_t, not int.
1086 * lisp.h (pD): New macro.
1087 * print.c (print_object): Use it.
1088
c0c5c8ae
PE
1089 * alloc.c: Use EMACS_INT, not int, to count objects.
1090 (total_conses, total_markers, total_symbols, total_vector_size)
1091 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1092 (total_free_floats, total_floats, total_free_intervals)
1093 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1094 Now EMACS_INT, not int. All uses changed.
1095 (Fgarbage_collect): Compute overall total using a double, so that
1096 integer overflow is less likely to be a problem. Check for overflow
1097 when converting back to an integer.
5a25e253
PE
1098 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1099 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1100 These were 'int' variables that could overflow on 64-bit hosts;
1101 they were never used, so remove them instead of repairing them.
211a0b2a 1102 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1103 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1104 Previously, this ceilinged at INT_MAX, but that doesn't work on
1105 64-bit machines.
e46bb31a 1106 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1107
c78baabf 1108 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1109 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1110 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1111 when a (possibly-narrower) signed value would do just as well.
1112 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1113
c9d624c6
PE
1114 * alloc.c: Catch some string size overflows that we were missing.
1115 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1116 for convenience in STRING_BYTES_MAX.
1117 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1118 The definition here is exact; the one in lisp.h was approximate.
1119 (allocate_string_data): Check for string overflow. This catches
1120 some instances we weren't catching before. Also, it catches
1121 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1122 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1123 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1124
c9d624c6
PE
1125 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1126 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1127 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1128
353032ce
PE
1129 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1130
2bccce07
PE
1131 * alloc.c (Fmake_string): Check for out-of-range init.
1132
0ac30604
SM
11332011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1134
1135 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1136
c195f2de
JD
11372011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1138
1139 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1140 xg_get_default_scrollbar_width.
1141
1142 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1143 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1144 (style_changed_cb): Call update_theme_scrollbar_width and call
1145 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1146 all frames (Bug#8505).
1147 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1148 Call gtk_window_set_resizable if HAVE_GTK3.
1149 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1150 and height if HAVE_GTK3 (Bug#8505).
1151 (scroll_bar_width_for_theme): New variable.
1152 (update_theme_scrollbar_width): New function.
1153 (xg_get_default_scrollbar_width): Move code to
1154 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1155 (xg_initialize): Call update_theme_scrollbar_width.
1156
1157 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1158
1159 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1160
e10ac9f1
MR
11612011-06-12 Martin Rudalics <rudalics@gmx.at>
1162
1163 * frame.c (make_frame): Call other_buffer_safely instead of
1164 other_buffer.
1165
1166 * window.c (temp_output_buffer_show): Call display_buffer with
1167 second argument Vtemp_buffer_show_specifiers and reset latter
1168 immediately after the call.
1169 (Vtemp_buffer_show_specifiers): New variable.
1170 (auto_window_vscroll_p, next_screen_context_lines)
1171 (Vscroll_preserve_screen_position): Remove leading asterisks from
1172 doc-strings.
1173
2d3c217e 11742011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1175
7b7f97e8 1176 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1177 * buffer.c (Qclone_number): Remove for now, as it's unused.
1178 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1179 (record_buffer): Remove unused local.
1180 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1181 (set_frame_buffer_list): Remove; unused.
1182 * frame.h (other_visible_frames): Remove decl.
1183 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1184 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1185 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1186 if HAVE_GPM.
1187 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1188 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1189 Define only if HAVE_GPM.
1190 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1191 (update_hints_inhibit): Remove; never set. All uses removed.
1192 * widgetprv.h (emacsFrameClassRec): Remove decl.
1193 * window.c (delete_deletable_window): Now returns void, since it
1194 wasn't returning anything.
1195 (compare_window_configurations): Remove unused locals.
1196 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1197 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1198 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1199 the same widths as pointers. This follows up on the 2011-05-06 patch.
1200 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1201 * xterm.h: Likewise.
1202 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1203
1384b89e
JB
12042011-06-12 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * makefile.w32-in: Update dependencies.
1207 (LISP_H): Add lib/intprops.h.
1208
1100a63c
CY
12092011-06-11 Chong Yidong <cyd@stupidchicken.com>
1210
1211 * image.c (gif_load): Add animation frame delay to the metadata.
1212 (syms_of_image): Use DEFSYM. New symbol `delay'.
1213
6198ccd0
MR
12142011-06-11 Martin Rudalics <rudalics@gmx.at>
1215
1216 * window.c (delete_deletable_window): Re-add.
1217 (Fset_window_configuration): Rewrite to handle dead buffers and
1218 consequently deletable windows.
1219 (window_tree, Fwindow_tree): Remove. Supply functionality in
1220 window.el.
1221 (compare_window_configurations): Simplify code.
1222
b6e3633c
AS
12232011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1224
1ab0dee5
AS
1225 * image.c (imagemagick_load_image): Fix type mismatch.
1226 (Fimagemagick_types): Likewise.
1227
b6e3633c
AS
1228 * window.h (replace_buffer_in_windows): Declare.
1229
9397e56f
MR
12302011-06-11 Martin Rudalics <rudalics@gmx.at>
1231
1232 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1233 Qclone_number. Remove external declaration of Qdelete_window.
1234 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1235 code.
1236 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1237 Qbuffer_list_update_hook if allowed.
1238 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1239 buffer list implementation.
1240 (other_buffer_safely): New function.
1241 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1242 calls to replace_buffer_in_windows and
1243 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1244 if allowed.
1245 (record_buffer): Inhibit quitting and rewrite using quittable
1246 functions. Run Qbuffer_list_update_hook if allowed.
1247 (Frecord_buffer, Funrecord_buffer): New functions.
1248 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1249 switch-to-buffer to window.el.
1250 (bury-buffer): Move to window.el.
1251 (Vbuffer_list_update_hook): New variable.
1252
1253 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1254 section.
1255
1256 * window.h (resize_frame_windows): Move up in code.
1257 (Fwindow_frame): Remove EXFUN.
1258 (replace_buffer_in_all_windows): Remove prototype.
1259 (replace_buffer_in_windows_safely): Add prototype.
1260
1261 * window.c: Declare Qdelete_window static again. Move down
1262 declaration of select_count.
1263 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1264 (Fother_window): Move to window.el.
1265 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1266 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1267 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1268 window.el.
1269 (replace_buffer_in_windows): Implement by calling
1270 Qreplace_buffer_in_windows.
1271 (replace_buffer_in_all_windows): Remove with some functionality
1272 moved into replace_buffer_in_windows_safely.
1273 (replace_buffer_in_windows_safely): New function.
1274 (select_window_norecord, select_frame_norecord): Move in front
1275 of run_window_configuration_change_hook. Remove now obsolete
1276 declarations.
1277 (Fset_window_buffer): Rewrite doc-string. Call
1278 Qrecord_window_buffer.
1279 (keys_of_window): Move binding for other-window to window.el.
1280
b50691aa
CY
12812011-06-11 Chong Yidong <cyd@stupidchicken.com>
1282
1283 * dispextern.h (struct image): Replace data member, whose int_val
1284 and ptr_val fields were not used by anything, with a single
1285 lisp_val object.
1286
1287 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1288 (gif_clear_image, gif_load, imagemagick_load_image)
1289 (gs_clear_image, gs_load): Callers changed.
1290
3f754b86
PE
12912011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1292
cca69397
PE
1293 * buffer.h: Include <time.h>, for time_t.
1294 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1295
109e28d0
PE
1296 Fix minor problems found by static checking.
1297
60737f02
PE
1298 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1299
4b66faf3
PE
1300 Make identifiers static if they are not used in other modules.
1301 * data.c (Qcompiled_function, Qframe, Qvector):
1302 * image.c (QimageMagick, Qsvg):
1303 * minibuf.c (Qmetadata):
1304 * window.c (resize_window_check, resize_root_window): Now static.
1305 * window.h (resize_window_check, resize_root_window): Remove decls.
1306
109e28d0
PE
1307 * window.c (window_deletion_count, delete_deletable_window):
1308 Remove; unused.
46a4ce9e
PE
1309 (window_body_lines): Now static.
1310 (Fdelete_other_windows_internal): Mark vars as initialized.
1311 Make sure 'resize_failed' is initialized.
1312 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1313 (resize_window_apply): Remove unused local.
1314 * window.h (delete_deletable_window): Remove decl.
1315
109e28d0 1316 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1317 (imagemagick_load_image): Fix pointer signedness problem by changing
1318 last arg from unsigned char * to char *. All uses changed.
1319 Also, fix a local for similar reasons.
1320 Remove unused locals. Remove locals to avoid shadowing.
1321 (fn_rsvg_handle_free): Remove; unused.
1322 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1323 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1324
3f754b86
PE
1325 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1326
2547adb1
CY
13272011-06-10 Chong Yidong <cyd@stupidchicken.com>
1328
1329 * image.c (gif_load): Fix omitted cast error introduced by
1330 2011-06-06 change.
1331
2c8e37d4
MR
13322011-06-10 Martin Rudalics <rudalics@gmx.at>
1333
1334 * window.h (resize_proportionally, orig_total_lines)
1335 (orig_top_line): Remove from window structure.
1336 (set_window_height, set_window_width, change_window_heights)
1337 (Fdelete_window): Remove prototypes.
1338 (resize_frame_windows): Remove duplicate declaration.
1339
440a42e3
EZ
13402011-06-10 Eli Zaretskii <eliz@gnu.org>
1341
1342 * window.h (resize_frame_windows, resize_window_check)
1343 (delete_deletable_window, resize_root_window)
1344 (resize_frame_windows): Declare prototypes.
1345
1346 * window.c (resize_window_apply): Make definition be "static" to
1347 match the prototype.
1348
562dd5e9
MR
13492011-06-10 Martin Rudalics <rudalics@gmx.at>
1350
1351 * window.c: Remove declarations of Qwindow_size_fixed,
1352 window_min_size_1, window_min_size_2, window_min_size,
1353 size_window, window_fixed_size_p, enlarge_window, delete_window.
1354 Remove static from declaration of Qdelete_window, it's
1355 temporarily needed by Fbury_buffer.
1356 (replace_window): Don't assign orig_top_line and
1357 orig_total_lines.
1358 (Fdelete_window, delete_window): Remove. Window deletion is
1359 handled by window.el.
1360 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1361 Fdelete_window calls with calls to Qdelete_window.
1362 (Fdelete_other_windows): Remove. Deleting other windows is
1363 handled by window.el.
1364 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1365 handled in window.el.
1366 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1367 Window minimum sizes are handled in window.el.
1368 (shrink_windows, size_window, set_window_height)
1369 (set_window_width, change_window_heights, window_height)
1370 (window_width, CURBEG, CURSIZE, enlarge_window)
1371 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1372 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1373 handled in window.el.
1374 (make_dummy_parent): Rename to make_parent_window and give it a
1375 second argument horflag.
1376 (make_window): Don't set resize_proportionally any more.
1377 (Fsplit_window): Remove. Windows are split in window.el.
1378 (save_restore_action, save_restore_orig_size)
1379 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1380 Resize mini windows in window.el.
1381 (grow_mini_window, shrink_mini_window): Implement by calling
1382 Qresize_root_window_vertically, resize_window_check and
1383 resize_window_apply.
1384 (saved_window, Fset_window_configuration, save_window_save): Do
1385 not handle orig_top_line, orig_total_lines, and
1386 resize_proportionally.
1387 (window_min_height, window_min_width): Move to window.el.
1388 (keys_of_window): Move bindings for delete-other-windows,
1389 split-window, delete-window and enlarge-window to window.el.
1390
1391 * buffer.c: Temporarily extern Qdelete_window.
1392 (Fbury_buffer): Temporarily call Qdelete_window instead of
1393 Fdelete_window (Fbury_buffer will move to window.el soon).
1394
1395 * frame.c (set_menu_bar_lines_1): Remove code handling
1396 orig_top_line and orig_total_lines.
1397
1398 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1399 set_window_height but set heights directly.
1400 (change_frame_size_1): Use resize_frame_windows.
1401
1402 * xdisp.c (init_xdisp): Don't use set_window_height but set
1403 heights directly.
1404
1405 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1406 resize_frame_windows instead of change_window_heights and run
1407 run_window_configuration_change_hook.
1408
1409 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1410 instead of change_window_heights and run
1411 run_window_configuration_change_hook.
1412
1a13852e
MR
14132011-06-09 Martin Rudalics <rudalics@gmx.at>
1414
1415 * window.c (replace_window): Rename second argument REPLACEMENT to
1416 NEW. New third argument SETFLAG. Rewrite.
1417 (delete_window, make_dummy_parent): Call replace_window with
1418 third argument 1.
1419 (window_list_1): Move down in code.
1420 (run_window_configuration_change_hook): Move set_buffer part
1421 before select_frame_norecord part in order to unwind correctly.
1422 Rename count1 to count.
1423 (recombine_windows, delete_deletable_window, resize_root_window)
1424 (Fdelete_other_windows_internal)
1425 (Frun_window_configuration_change_hook, make_parent_window)
1426 (resize_window_check, resize_window_apply, Fresize_window_apply)
1427 (resize_frame_windows, Fsplit_window_internal)
1428 (Fdelete_window_internal, Fresize_mini_window_internal): New
1429 functions.
1430 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1431
f3d1777e
MR
14322011-06-08 Martin Rudalics <rudalics@gmx.at>
1433
496e208e
MR
1434 * window.h (window): Add some new members to window structure -
1435 normal_lines, normal_cols, new_total, new_normal, clone_number,
1436 splits, nest, prev_buffers, next_buffers.
1437 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1438 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1439
f3d1777e
MR
1440 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1441 Remove.
496e208e
MR
1442 (make_dummy_parent): Set new members of windows structure.
1443 (make_window): Move down in code. Handle new members of window
1444 structure.
1445 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1446 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1447 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1448 (Fset_window_prev_buffers, Fwindow_next_buffers)
1449 (Fset_window_next_buffers, Fset_window_clone_number): New
1450 functions.
1451 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1452 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1453 Doc-string fixes.
1454 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1455 Argument WINDOW can be now internal window too.
1456 (Fwindow_use_time): Move up in code.
1457 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1458 Rewrite doc-string.
1459 (Fset_window_configuration, saved_window)
1460 (Fcurrent_window_configuration, save_window_save): Handle new
1461 members of window structure.
b9e809c2
MR
1462 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1463 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1464 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1465 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1466 Qget_mru_window, Qresize_root_window,
1467 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1468 Qauto_buffer_name; staticpro them.
f3d1777e 1469
abde8f8c
MR
14702011-06-07 Martin Rudalics <rudalics@gmx.at>
1471
1472 * window.c (Fwindow_total_size, Fwindow_left_column)
1473 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1474 (Fwindow_list_1): New functions.
1475 (window_box_text_cols): Replace with window_body_cols.
1476 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1477 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1478 (delete_window, Fset_window_configuration): Call
1479 delete_all_subwindows with window as argument.
1480 (delete_all_subwindows): Take a window as argument and not a
1481 structure. Rewrite.
190b47e6
MR
1482 (window_loop): Remove handling of GET_LRU_WINDOW and
1483 GET_LARGEST_WINDOW.
1484 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1485
1486 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1487 window_box_text_cols. delete_all_subwindows now takes a
1488 Lisp_Object as argument.
abde8f8c
MR
1489
1490 * indent.c (compute_motion, Fcompute_motion): Use
1491 window_body_cols instead of window_box_text_cols.
1492
fa8a67e6
MR
1493 * frame.c (delete_frame): Call delete_all_subwindows with root
1494 window as argument.
1495
a54e3482
DC
14962011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1497
1498 * fns.c (Fputhash): Document return value.
1499
60002bf5
CY
15002011-06-06 Chong Yidong <cyd@stupidchicken.com>
1501
1502 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1503
0c671da6 15042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1505
b862a52a 1506 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1507
be44ca6c
PE
1508 Check for overflow when converting integer to cons and back.
1509 * charset.c (Fdefine_charset_internal, Fdecode_char):
1510 Use cons_to_unsigned to catch overflow.
1511 (Fencode_char): Use INTEGER_TO_CONS.
1512 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1513 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1514 * data.c (long_to_cons, cons_to_long): Remove.
1515 (cons_to_unsigned, cons_to_signed): New functions.
1516 These signal an error for invalid or out-of-range values.
1517 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1518 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1519 * font.c (Ffont_variation_glyphs):
1520 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1521 * lisp.h: Include <intprops.h>.
1522 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1523 (cons_to_signed, cons_to_unsigned): New decls.
1524 (long_to_cons, cons_to_long): Remove decls.
1525 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1526 (Fprimitive_undo): Use CONS_TO_INTEGER.
1527 * xfns.c (Fx_window_property): Likewise.
1528 * xselect.c: Include <limits.h>.
1529 (x_own_selection, selection_data_to_lisp_data):
1530 Use INTEGER_TO_CONS.
1531 (x_handle_selection_request, x_handle_selection_clear)
1532 (x_get_foreign_selection, Fx_disown_selection_internal)
1533 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1534 (lisp_data_to_selection_data): Use cons_to_unsigned.
1535 (x_fill_property_data): Use cons_to_signed.
1536 Report values out of range.
1537
d1f3d2af
PE
1538 Check for buffer and string overflow more precisely.
1539 * buffer.h (BUF_BYTES_MAX): New macro.
1540 * lisp.h (STRING_BYTES_MAX): New macro.
1541 * alloc.c (Fmake_string):
1542 * character.c (string_escape_byte8):
1543 * coding.c (coding_alloc_by_realloc):
1544 * doprnt.c (doprnt):
1545 * editfns.c (Fformat):
1546 * eval.c (verror):
1547 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1548 since they may not be the same number.
1549 * editfns.c (Finsert_char):
1550 * fileio.c (Finsert_file_contents):
1551 Likewise for BUF_BYTES_MAX.
1552
dd52fcea
PE
1553 * image.c: Use ptrdiff_t, not int, for sizes.
1554 (slurp_file): Switch from int to ptrdiff_t.
1555 All uses changed.
1556 (slurp_file): Check that file size fits in both size_t (for
1557 malloc) and ptrdiff_t (for sanity and safety).
1558
7f9bbdbb
PE
1559 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1560 if b->modtime has its maximal value.
1561
dfe18f82
PE
1562 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1563
84acfcf0
PE
1564 Don't assume time_t can fit into int.
1565 * buffer.h (struct buffer.modtime): Now time_t, not int.
1566 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1567 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1568
ccd9a01a
PE
1569 Minor fixes for signed vs unsigned integers.
1570 * character.h (MAYBE_UNIFY_CHAR):
1571 * charset.c (maybe_unify_char):
1572 * keyboard.c (read_char, reorder_modifiers):
1573 XINT -> XFASTINT, since the integer must be nonnegative.
1574 * ftfont.c (ftfont_spec_pattern):
1575 * keymap.c (access_keymap, silly_event_symbol_error):
1576 XUINT -> XFASTINT, since the integer must be nonnegative.
1577 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1578 since it makes no difference and we prefer signed.
1579 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1580 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1581 nonnegative.
1582
d6d100dd
SM
15832011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1584
1585 * window.h (Fwindow_frame): Declare.
1586
2b6148e4
PE
15872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1590 (SPARE_MEMORY): Always define.
1591 (LARGE_REQUEST): Remove.
1592 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1593
f230ecc9
MR
15942011-06-06 Martin Rudalics <rudalics@gmx.at>
1595
727e958e
MR
1596 * lisp.h: Move EXFUNS for Fframe_root_window,
1597 Fframe_first_window and Fset_frame_selected_window to window.h.
1598
1599 * window.h: Move EXFUNS for Fframe_root_window,
1600 Fframe_first_window and Fset_frame_selected_window here from
1601 lisp.h.
1602
1603 * frame.c (Fwindow_frame, Fframe_first_window)
1604 (Fframe_root_window, Fframe_selected_window)
1605 (Fset_frame_selected_window): Move to window.c.
1606 (Factive_minibuffer_window): Move to minibuf.c.
1607 (Fother_visible_frames_p): New function.
1608
1609 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1610
f230ecc9
MR
1611 * window.c (decode_window, decode_any_window): Move up in code.
1612 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1613 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1614 (Fwindow_buffer): Move up and rewrite doc-string.
1615 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1616 (Fwindow_prev): New functions.
727e958e
MR
1617 (Fwindow_frame): Move here from frame.c. Accept any window as
1618 argument.
1619 (Fframe_root_window, Fframe_first_window)
1620 (Fframe_selected_window): Move here from frame.c. Accept frame
1621 or arbitrary window as argument. Update doc-strings.
1622 (Fminibuffer_window): Move up in code.
1623 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1624 (Fset_frame_selected_window): Move here from frame.c.
1625 Marginal rewrite.
727e958e
MR
1626 (Fselected_window, select_window, Fselect_window): Move up in
1627 code. Minor doc-string fixes.
f230ecc9 1628
4d09bcf6
PE
16292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1632 Do not assume that spare memory exists; that assumption is valid
1633 only if SYSTEM_MALLOC.
1634 (LARGE_REQUEST): New macro, so that the issue of large requests
1635 is separated from the issue of spare memory.
1636
810928a2
AS
16372011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1638
172418ad
AS
1639 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1640 format. (Bug#8806)
1641
43f862f7
AS
1642 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1643
810928a2
AS
1644 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1645 before statements.
1646
a059fe24
JD
16472011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1648
1649 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1650
1651 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1652
1653 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1654 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1655
989bf368
JB
16562011-06-05 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1659
4b80f674
CY
16602011-06-04 Chong Yidong <cyd@stupidchicken.com>
1661
1662 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1663 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1664 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1665 New error handlers.
4b80f674
CY
1666 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1667 Obey Vx_select_enable_clipboard_manager. Catch errors in
1668 x_clipboard_manager_save (Bug#8779).
1669 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1670 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1671
99a33b77 16722011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1673
1674 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1675
99a33b77 16762011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1677
1678 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1679 in the current matrix if keep_current_p is non-zero.
1680
8264569d
EZ
16812011-06-04 Eli Zaretskii <eliz@gnu.org>
1682
1683 * bidi.c (bidi_level_of_next_char): Fix last change.
1684
57f97249
EZ
16852011-06-03 Eli Zaretskii <eliz@gnu.org>
1686
fec2107c 1687 Support bidi reordering of text covered by display properties.
57f97249 1688
fec2107c
EZ
1689 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1690 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1691 (bidi_cache_search, bidi_cache_iterator_state)
1692 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1693 (bidi_level_of_next_char, bidi_move_to_visually_next):
1694 Support character positions inside a run of characters covered by a
fec2107c
EZ
1695 display string.
1696 (bidi_paragraph_init, bidi_resolve_explicit_1)
1697 (bidi_level_of_next_char): Call bidi_fetch_char and
1698 bidi_fetch_char_advance instead of FETCH_CHAR and
1699 FETCH_CHAR_ADVANCE.
1700 (bidi_init_it): Initialize new members.
1701 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1702 definitions.
1703 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1704 instead of using explicit *_CHAR codes.
d6d100dd
SM
1705 (bidi_resolve_explicit, bidi_resolve_weak):
1706 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1707 bidirectional text is supported only in multibyte buffers.
1708 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1709 it to initialize the frame_window_p member of struct bidi_it.
1710 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1711 (bidi_resolve_explicit, bidi_resolve_weak)
1712 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1713 bidi_it->nchars is non-positive.
1714 (bidi_level_of_next_char): Don't try to lookup the cache for the
1715 next/previous character if nothing is cached there yet, or if we
1716 were just reseat()'ed to a new position.
c40e2fb2 1717
0e14fe90
EZ
1718 * xdisp.c (set_cursor_from_row): Set start and stop points
1719 according to the row's direction when priming the loop that looks
1720 for the glyph on which to display cursor.
1721 (single_display_spec_intangible_p): Function deleted.
1722 (display_prop_intangible_p): Reimplement to call
1723 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1724 Accept 3 additional arguments needed by handle_display_spec.
1725 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1726 values: lists, `(when COND...)' forms, etc.
1727 (single_display_spec_string_p): Support property values that are
1728 lists with the argument STRING its top-level element.
1729 (display_prop_string_p): Fix the condition for processing a
1730 property that is a list to be consistent with handle_display_spec.
fec2107c 1731 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1732 last portion of handle_display_prop.
1733 (compute_display_string_pos): Accept additional argument
1734 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1735 value of a `display' property is a "replacing spec".
1736 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1737 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1738 the display property, but just return a value indicating whether
1739 the display property will replace the characters it covers.
1740 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1741 frame_window_p members of struct bidi_it.
d6d100dd
SM
1742 (compute_display_string_pos, compute_display_string_end):
1743 New functions.
fec2107c
EZ
1744 (push_it): Accept second argument POSITION, where pop_it should
1745 jump to continue iteration.
1746 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1747
fec2107c
EZ
1748 * keyboard.c (adjust_point_for_property): Adjust the call to
1749 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1750
1751 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1752 (bidi_init_it): Update prototypes.
1753 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1754 (compute_display_string_pos, compute_display_string_end):
1755 Declare prototypes.
fec2107c
EZ
1756 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1757 EMACS_INT.
fc6f18ce 1758
40087514 17592011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1760
57f53182
PE
1761 Malloc failure behavior now depends on size of allocation.
1762 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1763 * lisp.h: Change signatures accordingly.
1764 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1765 All callers changed. (Bug#8762)
1766
1767 * gnutls.c: Use Emacs's memory allocators.
1768 Without this change, the gnutls library would invoke malloc etc.
1769 directly, which causes problems on non-SYNC_INPUT hosts, and which
1770 runs afoul of improving memory_full behavior. (Bug#8761)
1771 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1772 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1773 xfree instead of the default malloc, realloc, free.
1774 (Fgnutls_boot): No need to check for memory allocation failure,
1775 since xmalloc does that for us.
1776
ac32cd99 1777 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1778 * category.c (hash_get_category_set):
1779 * ccl.c (ccl_driver):
1780 * charset.c (Fdefine_charset_internal):
1781 * charset.h (struct charset.hash_index):
1782 * composite.c (get_composition_id, gstring_lookup_cache)
1783 (composition_gstring_put_cache):
1784 * composite.h (struct composition.hash_index):
1785 * dispextern.h (struct image.hash):
1786 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1787 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1788 (hashfn_equal, hashfn_user_defined, make_hash_table)
1789 (maybe_resize_hash_table, hash_lookup, hash_put)
1790 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1791 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1792 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1793 * image.c (make_image, search_image_cache, lookup_image)
1794 (xpm_put_color_table_h):
1795 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1796 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1797 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1798 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1799 * alloc.c (allocate_vectorlike):
1800 Check for overflow in vector size calculations.
1801 * ccl.c (ccl_driver):
1802 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1803 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1804 need to be updated by these changes.
40087514
PE
1805 * fns.c (make_hash_table, maybe_resize_hash_table):
1806 Check for integer overflow with large hash tables.
0de4bb68
PE
1807 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1808 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1809 (SXHASH_REDUCE): New macro.
1810 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1811 Use it instead of discarding useful hash info with large hash values.
1812 (sxhash_float): New function.
1813 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1814 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1815 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1816 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1817 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1818 Adjust signatures to match updated version of code.
1819 (consing_since_gc): Now EMACS_INT, since a single hash table can
1820 use more than INT_MAX bytes.
1821
698d32e2
DN
18222011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1823
1824 Make it possible to build with GCC-4.6+ -O2 -flto.
1825
1826 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1827
fd6fa53f
SM
18282011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1829
1830 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1831 Call minibuffer-inactive-mode.
1832
864db017
JB
18332011-05-31 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1836 Update dependencies.
1837
2ad0baf4
DN
18382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1839
1840 * data.c (init_data): Remove code for UTS, this system is not
1841 supported anymore.
1842
4fcc2638
DN
18432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1844
1845 Don't force ./temacs to start in terminal mode.
1846
1847 * frame.c (make_initial_frame): Initialize faces in all cases, not
1848 only when CANNOT_DUMP is defined.
1849 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1850
c56e0fd5
DN
18512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1852
1853 * dispnew.c (add_window_display_history): Use const for the string
1854 pointer. Remove declaration, not needed.
1855
333d54da 18562011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1857
55d4c1b2 1858 Use 'inline', not 'INLINE'.
333d54da 1859 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1860 * alloc.c, fontset.c (INLINE): Remove.
1861 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1862 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1863 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1864 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1865 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1866
738db178
DN
18672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1868
1869 Make it possible to run ./temacs.
1870
1871 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1872 syms_of_callproc does the same thing. Remove test for
1873 "initialized", do it in the caller.
1874 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1875
620c53a6
SM
18762011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1877
1878 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1879 (read_minibuf): Use get_minibuffer.
1880 (syms_of_minibuf): Use DEFSYM.
1881 (Qmetadata): New var.
1882 * data.c (Qbuffer): Don't make it static.
1883 (syms_of_data): Use DEFSYM.
1884
e003a292
PE
18852011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1886
1887 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1888 (CCL_CODE_MIN): New macro.
1889
ed008a6d
PE
18902011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1891
3687c2ef
PE
1892 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1893
ed008a6d
PE
1894 * eval.c (Qdebug): Now static.
1895 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1896 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1897 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1898
d66c4c7c
CY
18992011-05-29 Chong Yidong <cyd@stupidchicken.com>
1900
1901 * image.c: Various fixes to ImageMagick code comments.
1902 (Fimagemagick_types): Doc fix.
1903
5fbc2025
PE
19042011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1905
0196f88a
PE
1906 Minor fixes prompted by GCC 4.6.0 warnings.
1907
1908 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1909
5fbc2025
PE
1910 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1911 (x_clipboard_manager_save_all): Move extern decl to ...
1912 * xterm.h: ... here, so that it can be checked for consistency.
1913
1dd3c2d9
CY
19142011-05-29 Chong Yidong <cyd@stupidchicken.com>
1915
1916 * xselect.c (x_clipboard_manager_save_frame)
1917 (x_clipboard_manager_save_all): New functions.
1918 (Fx_clipboard_manager_save): Lisp function deleted.
1919
1920 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1921 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1922
1923 * xterm.h: Update prototype.
1924
5ba6571d
WX
19252011-05-28 William Xu <william.xwl@gmail.com>
1926
1927 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1928 exiting (Bug#8239).
1929
3eaff834
JM
19302011-05-28 Jim Meyering <meyering@redhat.com>
1931
e1900994 1932 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1933 * fns.c (to_uchar): Define.
1934 (crypto_hash_function): Use it to convert some newly-signed
1935 variables to unsigned, to avoid sign-extension bugs. For example,
1936 without this change, (md5 "truc") would evaluate to
1937 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1938 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1939 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1940
0f6990a7
PE
19412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 Integer overflow fixes.
c8a9ca5a 1944
08686060
PE
1945 * dbusbind.c: Serial number integer overflow fixes.
1946 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1947 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1948 to hold a serial number that is too large for a fixnum.
1949 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1950 Check for serial numbers out of range. Decode any serial number
59568bf0 1951 that was so large that it became a float. (Bug#8722)
08686060 1952
2d1fc3c7
PE
1953 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1954 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1955 Use XFASTINT rather than XUINT when numbers are nonnegative.
1956 (xd_append_arg, Fdbus_method_return_internal):
1957 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1958 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1959 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1960 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1961 (Bug#8722)
2d1fc3c7 1962
c8a9ca5a
PE
1963 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1964
519e1d69
PE
1965 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1966
30569699
PE
1967 ccl: add integer overflow checks
1968 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1969 (IN_INT_RANGE): New macros.
1970 (ccl_driver): Use them to check for integer overflow when
1971 decoding a CCL program. Many of the new checks are whether XINT (x)
1972 fits in int; it doesn't always, on 64-bit hosts. The new version
1973 doesn't catch all possible integer overflows, but it's an
847044ea 1974 improvement. (Bug#8719)
30569699 1975
c11285dc
PE
1976 * alloc.c (make_event_array): Use XINT, not XUINT.
1977 There's no need for unsigned here.
1978
fdccd48e
PE
1979 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1980 This follows up to the 2011-05-06 change that substituted uintptr_t
1981 for EMACS_INT. This case wasn't caught back then.
1982
37910ab2
PE
1983 Rework Fformat to avoid integer overflow issues.
1984 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1985 now (part of C89). Include <verify.h>.
1986 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1987 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1988 (Fformat): Avoid the prepass trying to compute sizes; it was only
1989 approximate and thus did not catch overflow reliably. Instead, walk
1990 through the format just once, formatting and computing sizes as we go,
1991 checking for integer overflow at every step, and allocating a larger
1992 buffer as needed. Keep track separately whether the format is
1993 multibyte. Keep only the most-recently calculated precision, rather
1994 than them all. Record whether each argument has been converted to
1995 string. Use EMACS_INT, not int, for byte and char and arg counts.
1996 Support field widths and precisions larger than INT_MAX. Avoid
1997 sprintf's undefined behavior with conversion specifications such as %#d
1998 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1999 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2000 formatting out-of-range floating point numbers with int
9173deec 2001 formats. (Bug#8668)
37910ab2 2002
2e6578fb
PE
2003 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2004
0ae6bdee
PE
2005 * data.c: Avoid integer truncation in expressions involving floats.
2006 * data.c: Include <intprops.h>.
2007 (arith_driver): When there's an integer overflow in an expression
2008 involving floating point, convert the integers to floating point
2009 so that the resulting value does not suffer from catastrophic
2010 integer truncation. For example, on a 64-bit host (* 4
2011 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2012 Do not rely on undefined behavior after integer overflow.
2013
de883a70
PE
2014 merge count_size_as_multibyte, parse_str_to_multibyte
2015 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2016 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2017 Check for integer overflow.
2018 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2019 since it's now a duplicate of the other. This is more of
2020 a character than a buffer op, so better that it's in character.c.
2021 * fns.c, print.c: Adjust to above changes.
2022
2ff916cb
PE
20232011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2024
2025 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2026
f1b54466
PE
20272011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2028
fb1ac845
PE
2029 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2030 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2031 (x_clipboard_manager_save): Now static.
2032 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2033
f1b54466
PE
2034 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2035 (crypto_hash_function): Now static.
2036 Fix pointer signedness problems. Avoid unnecessary initializations.
2037
a9f737ee
CY
20382011-05-27 Chong Yidong <cyd@stupidchicken.com>
2039
2040 * termhooks.h (Vselection_alist): Make it terminal-local.
2041
2042 * terminal.c (create_terminal): Initialize it.
2043
2044 * xselect.c: Support for clipboard managers.
2045 (Vselection_alist): Move to termhooks.h as terminal-local var.
2046 (LOCAL_SELECTION): New macro.
2047 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2048 (symbol_to_x_atom): Remove gratuitous arg.
2049 (x_handle_selection_request, lisp_data_to_selection_data)
2050 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2051 (x_own_selection, x_get_local_selection, x_convert_selection):
2052 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2053 (some_frame_on_display): Delete unused function.
2054 (Fx_own_selection_internal, Fx_get_selection_internal)
2055 (Fx_disown_selection_internal, Fx_selection_owner_p)
2056 (Fx_selection_exists_p): New optional frame arg.
2057 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2058 (x_handle_selection_clear): Don't treat other terminals with the
2059 same keyboard specially. Use the terminal-local Vselection_alist.
2060 (x_clear_frame_selections): Use Frun_hook_with_args.
2061
2062 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2063
2064 * xterm.h: Add support for those atoms.
2065
e067f0c1
CY
20662011-05-26 Chong Yidong <cyd@stupidchicken.com>
2067
2068 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2069 (converted_selections, conversion_fail_tag): New global variables.
2070 (x_selection_request_lisp_error): Free the above.
2071 (x_get_local_selection): Remove unnecessary code.
2072 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2073 of converted selections stored in converted_selections.
2074 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2075 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2076 (x_convert_selection): New function.
2077 (x_handle_selection_event): Simplify.
2078 (x_get_foreign_selection): Don't ignore incoming requests while
2079 waiting for an answer; this will fail when we implement
2080 SAVE_TARGETS, and seems unnecessary anyway.
2081 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2082 (Vx_sent_selection_functions): Doc fix.
2083
0f4aebc0
LL
20842011-05-26 Leo Liu <sdl.web@gmail.com>
2085
2086 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2087
e61124cd
YM
20882011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2089
2090 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2091
2092 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2093 for fringe update if it has periodic bitmap.
2094 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2095 and fringe_bitmap_periodic_p.
2096
2097 * fringe.c (get_fringe_bitmap_data): New function.
2098 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2099 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2100 row. Mark glyph row for fringe update if periodicity changed.
2101
2102 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2103 for fringe update unless it has periodic bitmap.
2104
f16d9837
KH
21052011-05-25 Kenichi Handa <handa@m17n.org>
2106
2107 * xdisp.c (get_next_display_element): Set correct it->face_id for
2108 a static composition.
2109
e1b90ef6
LL
21102011-05-24 Leo Liu <sdl.web@gmail.com>
2111
2112 * deps.mk (fns.o):
2113 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2114
2115 * fns.c (crypto_hash_function, Fsha1): New function.
2116 (Fmd5): Use crypto_hash_function.
2117 (syms_of_fns): Add Ssha1.
2118
7400048f
PE
21192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 * gnutls.c: Remove unused macros.
2122 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2123 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2124 Remove macros that are defined and never used.
2125 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2126
abb71cf4
CY
21272011-05-22 Chong Yidong <cyd@stupidchicken.com>
2128
2129 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2130 (Fx_get_selection_internal): Minor cleanup.
2131 (Fx_own_selection_internal): Rename arguments for consistency with
2132 select.el.
2133
6307db39
PE
21342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2137
f3d4e0a4
CY
21382011-05-22 Chong Yidong <cyd@stupidchicken.com>
2139
2140 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2141
4d8ade89
YM
21422011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2143
2144 * dispnew.c (scrolling_window): Don't exclude the case that the
2145 last enabled row in the desired matrix touches the bottom boundary.
2146
32078c8d
GM
21472011-05-21 Glenn Morris <rgm@gnu.org>
2148
2149 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2150 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2151 and add some more files.
32078c8d 2152
7285dc67
EZ
21532011-05-20 Eli Zaretskii <eliz@gnu.org>
2154
2155 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2156 report_file_error introduced by the change from 2011-05-07.
2157
89d1bd22
PE
21582011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2159
2160 * systime.h (Time): Define only if emacs is defined.
2161 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2162 where the include path doesn't have X11/X.h by default. See
2163 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2164
e23640bb 21652011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2166
2167 * composite.c (find_automatic_composition): Fix previous change.
2168
b9704ad9
GM
21692011-05-20 Glenn Morris <rgm@gnu.org>
2170
2171 * lisp.mk: New file, split from Makefile.in.
2172 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2173 (shortlisp): Remove.
2174 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2175
4a720484
GM
21762011-05-19 Glenn Morris <rgm@gnu.org>
2177
2178 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2179 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2180 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2181 (lisp): Set the order to that of loadup.el.
2182 (shortlisp): Make it a copy of $lisp.
2183 (SOME_MACHINE_LISP): Remove.
2184 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2185 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2186
a28d4396
KH
21872011-05-18 Kenichi Handa <handa@m17n.org>
2188
2189 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2190 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2191 (find_automatic_composition): Mostly rewrite for efficiency.
2192
a2b1fa8e
JB
21932011-05-18 Juanma Barranquero <lekktu@gmail.com>
2194
2195 * makefile.w32-in: Update dependencies.
2196
8e1f5610
CS
21972011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2198
2199 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2200 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2201
7025ee00 22022011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2203
cdfa6eab
PE
2204 Fix some integer overflow issues, such as string length overflow.
2205
06d6db33
PE
2206 * insdel.c (count_size_as_multibyte): Check for string overflow.
2207
2b4560a8
PE
2208 * character.c (lisp_string_width): Check for string overflow.
2209 Use EMACS_INT, not int, for string indexes and lengths; in
2210 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2211 the resulting string length overflows an EMACS_INT; instead,
2212 report a string overflow if no precision given. When checking for
2213 precision exhaustion, use a check that cannot possibly have
2214 integer overflow. (Bug#8675)
2215 * character.h (lisp_string_width): Adjust to new signature.
2216
cb93f9be
PE
2217 * alloc.c (string_overflow): New function.
2218 (Fmake_string): Use it. This doesn't change behavior, but saves
2219 a few bytes and will simplify future changes.
2220 * character.c (string_escape_byte8): Likewise.
2221 * lisp.h (string_overflow): New decl.
2222
1a1f3366
PE
2223 Fixups, following up to the user-interface timestamp change.
2224 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2225 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2226 * msdos.c (mouse_get_pos): Likewise.
2227 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2228 * w32gui.h (Time): Define by including "systime.h" rather than by
2229 declaring it ourselves. (Bug#8664)
2230
d4e3e4d3
PE
2231 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2232 * image.c (clear_image_cache): Likewise.
2233
f6a24d19
PE
2234 * term.c (term_mouse_position): Don't assume time_t wraparound.
2235
08dc5ae6
PE
2236 Be more systematic about user-interface timestamps.
2237 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2238 and sometimes 'EMACS_UINT', to represent these timestamps.
2239 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2240 This makes the code easier to follow, and makes it easier to catch
2241 integer overflow bugs such as Bug#8664.
2242 * frame.c (Fmouse_position, Fmouse_pixel_position):
2243 Use Time, not unsigned long, for user-interface timestamps.
2244 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2245 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2246 * keyboard.h (last_event_timestamp): Likewise.
2247 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2248 * menu.h (xmenu_show): Likewise.
2249 * term.c (term_mouse_position): Likewise.
2250 * termhooks.h (struct input_event.timestamp): Likewise.
2251 (struct terminal.mouse_position_hook): Likewise.
2252 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2253 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2254 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2255 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2256 what it was before.
2257 * menu.h, termhooks.h: Include "systime.h", for Time.
2258
8e55734a
PE
2259 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2260 Don't assume that the difference between two unsigned long values
2261 can fit into an integer. At this point, we know button_down_time
2262 <= event->timestamp, so the difference must be nonnegative, so
2263 there's no need to cast the result if double-click-time is
2264 nonnegative, as it should be; check that it's nonnegative, just in
2265 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2266 apart (about 25 days). (Bug#8664)
8e55734a 2267
841f1b75 2268 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2269 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2270
3e26f69c
PE
2271 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2272 that always fit in int. Use a sentinel instead of a counter, to
2273 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2274 * frame.h (struct frame): Use int for menu_bar_items_used
2275 instead of EMACS_INT, since it always fits in int.
3e26f69c 2276
5cc152c0
PE
2277 * menu.c (grow_menu_items): Check for int overflow.
2278
d89eb65e
PE
2279 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2280
5235bd3e
PE
2281 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2282 Before, the code was not consistent. These values cannot exceed
2283 2**31 - 1 so there's no need to make them unsigned.
2284 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2285 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2286 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2287 as modifiers.
2288 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2289
bc827e23
PE
2290 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2291 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2292 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2293 presumably because the widths might not match.
2294
78eb494e
PE
2295 * window.c (size_window): Avoid needless test at loop start.
2296
04f2d78b
CB
22972011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2298
2299 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2300
d2fc7e3d 23012011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2302
2303 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2304
d2fc7e3d 23052011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2306
2307 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2308 `width' to `bar_area_x' and `bar_area_width', respectively.
2309 (x_scroll_run): Take account of fringe background extension.
2310
04f2d78b
CB
2311 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2312 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2313 `bar_area_width', respectively.
2314 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2315 background extension.
2316
79b70037
GM
23172011-05-10 Jim Meyering <meyering@redhat.com>
2318
2319 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2320
2f142cc5
JB
23212011-05-10 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * image.c (Finit_image_library): Return t for built-in image types,
2324 like pbm and xbm. (Bug#8640)
2325
57679c86
AS
23262011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2327
2328 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2329
888c9e86
EZ
23302011-05-07 Eli Zaretskii <eliz@gnu.org>
2331
b0512a1d
EZ
2332 * w32console.c (Fset_screen_color): Doc fix.
2333 (Fget_screen_color): New function.
2334 (syms_of_ntterm): Defsubr it.
2335
7285dc67
EZ
2336 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2337 unlink the temporary file if Fcall_process didn't create it in the
2338 first place.
2339 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2340 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2341 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2342 cue to call_process_cleanup not to close that handle.
2343
4d3fcc8e
BK
23442011-05-07 Ben Key <bkey76@gmail.com>
2345
2346 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2347 one of two shell specific rules, either bootstrap-temacs-CMD or
2348 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2349 to the previous implementation of the bootstrap-temacs rule.
2350 The bootstrap-temacs-CMD rule is similar to the previous
2351 implementation of the bootstrap-temacs rule except that it
2352 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2353 variable.
2354
2355 These changes, along with some changes to nt/configure.bat,
2356 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2357 earlier fix to add support for --cflags and --ldflags options
2358 that include quotes so that it works whether make uses cmd or
2359 sh as the shell.
2360
b4289b64
MA
23612011-05-06 Michael Albinus <michael.albinus@gmx.de>
2362
2363 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2364 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2365 is a constant.
2366 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2367 a string. Handle both cases.
2368 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2369 (Fdbus_register_method): Use Qinvalid_function.
2370
af4c0e28
JB
23712011-05-06 Juanma Barranquero <lekktu@gmail.com>
2372
2373 * makefile.w32-in: Update dependencies.
2374 (LISP_H): Add inttypes.h and stdin.h.
2375 (PROCESS_H): Add unistd.h.
2376
c51453d9
EZ
23772011-05-06 Eli Zaretskii <eliz@gnu.org>
2378
2379 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2380 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2381
8ff0ac3c 23822011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2383
4c4b566b
PE
2384 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2385
aab2b9b5
PE
2386 * term.c (vfatal): Remove stray call to va_end.
2387 It's not needed and the C Standard doesn't allow it here anyway.
2388
c378da0b
PE
2389 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2390 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2391
288b08c7
PE
2392 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2393 bytes.
2394
e3601888
PE
2395 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2396
db6c0e74
PE
2397 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2398
dd5963ea
PE
2399 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2400
88c9450f
PE
2401 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2402
2f9442b8
PE
2403 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2404
c032b5f8
PE
2405 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2406 * charset.c (Fdefine_charset_internal): Don't initialize
2407 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2408 32-bit int (Bug#8600).
a108c10b
PE
2409
2410 * lread.c (read_integer): Be more consistent with string-to-number.
2411 Use string_to_number to do the actual conversion; this avoids
2412 rounding errors and fixes some other screwups. Without this fix,
2413 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2414 (digit_to_number): Move earlier, for benefit of read_integer.
2415 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2416 not a digit in any supported base. (Bug#8602)
a108c10b 2417
ad5f9eea
PE
2418 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2419
aec1708a
PE
2420 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2421 to match comment at start of function. This also removes a
2422 GCC warning about overflow in a 32+64-bit port.
2423
47be4ab5
PE
2424 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2425
371cac43
PE
2426 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2427 Reported by Stefan Monnier in
2428 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2429 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2430 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2431
d01a7826
PE
2432 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2433 (EMACS_UINTPTR): Likewise, with uintptr_t.
2434
7fd47d5c
PE
2435 * lisp.h: Prefer 64-bit EMACS_INT if available.
2436 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2437 on 32-bit hosts that have 64-bit int, so that they can access
2438 large files.
122b0c86
PE
2439 However, temporarily disable this change unless the temporary
2440 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2441
8727937b
PE
2442 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2443
8ac068ac
PE
2444 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2445 This removes an assumption that EMACS_INT and long are the same
2446 width as pointers. The assumption is true for Emacs porting targets
2447 now, but we want to make other targets possible.
2448 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2449 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2450 In the rest of the code, change types of integers that hold casted
2451 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2452 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2453 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2454 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2455 No need to cast type when ORing.
2456 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2457 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2458 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2459 assume EMACS_INT is the same width as char *.
2460 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2461 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2462 Remove no-longer-needed casts.
2463 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2464 (xg_tool_bar_help_callback, xg_make_tool_item):
2465 Use EMACS_INTPTR to hold an integer
2466 that will be cast to void *; this can avoid a GCC warning
2467 if EMACS_INT is not the same width as void *.
2468 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2469 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2470 (current_message_1, set_message_1):
2471 Use a local to convert to proper width without a cast.
2472 * xmenu.c (dialog_selection_callback): Likewise.
2473
ede49d71
PE
2474 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2475 Also, don't assume VALBITS / RAND_BITS is less than 5,
2476 and don't rely on undefined behavior when shifting a 1 left into
2477 the sign bit.
2478 * lisp.h (get_random): Change signature to match.
2479
2f30ecd0
PE
2480 * lread.c (hash_string): Use size_t, not int, for hash computation.
2481 Normally we prefer signed values; but hashing is special, because
2482 it's better to use unsigned division on hash table sizes so that
2483 the remainder is nonnegative. Also, size_t is the natural width
2484 for hashing into memory. The previous code used 'int', which doesn't
2485 retain enough info to hash well into very large tables.
2486 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2487
2a866e7b
PE
2488 * dbusbind.c: Don't possibly lose pointer info when converting.
2489 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2490 Use XPNTR rather than XHASH, so that the high-order bits of
2491 the pointer aren't lost when converting through void *.
2492
51639eac
PE
2493 * eval.c (Fautoload): Don't double-shift a pointer.
2494
92394119
PE
2495 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2496
dbdb9a7c
JB
24972011-05-06 Juanma Barranquero <lekktu@gmail.com>
2498
2499 * gnutls.c (DEF_GNUTLS_FN):
2500 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2501
db7a0b4f
AS
25022011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2503
2504 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2505 marker. (Bug#8610)
2506
f7ff1b0f 25072011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2508
2509 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2510 New version that can reserve upto 2GB of heap space.
2511
f7ff1b0f 25122011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2513
2514 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2515
639c109b
TZ
25162011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2517
2518 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2519 `gnutls_certificate_set_x509_key_file'.
2520
d2127135
JB
25212011-05-05 Juanma Barranquero <lekktu@gmail.com>
2522
2523 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2524 Update dependencies.
2525
e968f4f3
JB
25262011-05-04 Juanma Barranquero <lekktu@gmail.com>
2527
2528 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2529 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2530 Remove unused parameter `fildes'.
2531 * process.c (read_process_output, send_process): Don't pass it.
2532
84d358f0
JB
25332011-05-04 Juanma Barranquero <lekktu@gmail.com>
2534
2535 Fix previous change: the library cache is defined in w32.c.
2536 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2537 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2538
0898ca10
JB
25392011-05-04 Juanma Barranquero <lekktu@gmail.com>
2540
2541 Implement dynamic loading of GnuTLS on Windows.
2542
2543 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2544 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2545 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2546 Declare.
2547
2548 * gnutls.c (Qgnutls_dll): Define.
2549 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2550 (gnutls_*): Declare function pointers.
2551 (init_gnutls_functions): New function to initialize function pointers.
2552 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2553 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2554 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2555 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2556 (emacs_gnutls_write, emacs_gnutls_read)
2557 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2558 (Fgnutls_available_p): New function.
2559 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2560 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2561 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2562
2563 * image.c: Include w32.h.
2564 (Vimage_type_cache): Delete.
2565 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2566 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2567 (w32_delayed_load): Move to w32.c.
2568
2569 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2570
2571 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2572 (w32_delayed_load): Move from image.c. When loading a library, record
2573 its filename in the :loaded-from property of the library id.
2574 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2575 Initialize and staticpro them.
2576 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2577
2578 * process.c: Include lisp.h before w32.h, not after.
2579 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2580 instead of gnutls_record_check_pending.
2581
2582 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2583
ff4de4aa
TZ
25842011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2585
2586 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2587 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2588 as passed in.
2589
abe95abb
JD
25902011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2591
2592 * xterm.c (x_set_frame_alpha): Do not set property on anything
2593 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2594
e16e55d4
JB
25952011-05-02 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2598
bafcf6a5
JB
25992011-05-02 Juanma Barranquero <lekktu@gmail.com>
2600
2601 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2602 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2603 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2604 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2605 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2606 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2607 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2608 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2609 (Qgnutls_bootprop_callbacks_verify): Make static.
2610
e7a6747f
AS
26112011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2612
19ed11ba
AS
2613 * callproc.c: Indentation fixup.
2614
e7a6747f 2615 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2616 (wait_for_termination, interruptible_wait_for_termination):
2617 Move after wait_for_termination_1.
e7a6747f 2618
1ef14cb4
LMI
26192011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2620
2621 * sysdep.c (interruptible_wait_for_termination): New function
2622 which is like wait_for_termination, but allows keyboard
2623 interruptions.
2624
2625 * callproc.c (Fcall_process): Add (:file "file") as an option for
2626 the STDOUT buffer.
2627 (Fcall_process_region): Ditto.
2628
330d880c
EZ
26292011-04-30 Eli Zaretskii <eliz@gnu.org>
2630
8db90b73
EZ
2631 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2632 rather than `XVECTOR (FOO)->size'.
2633
330d880c
EZ
2634 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2635 inttypes.h, as a gnulib replacement is used if it not available in
2636 system headers.
2637
15cbd324
EZ
26382011-04-21 Eli Zaretskii <eliz@gnu.org>
2639
2640 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2641 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2642 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2643
2644 * coding.c (coding_alloc_by_realloc): Error out if destination
2645 will grow beyond MOST_POSITIVE_FIXNUM.
2646 (decode_coding_emacs_mule): Abort if there isn't enough place in
2647 charbuf for the composition carryover bytes. Reserve an extra
2648 space for up to 2 characters produced in a loop.
2649 (decode_coding_iso_2022): Abort if there isn't enough place in
2650 charbuf for the composition carryover bytes.
2651
26522011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2653
ae940cca
EZ
2654 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2655 aborting when %lld or %lll format is passed.
2656 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2657 %llo or %llx format is passed. (Bug#8545)
2658
03ab8921
EZ
2659 * window.c (window_scroll_line_based): Use a marker instead of
2660 simple variables to record original value of point. (Bug#7952)
2661
afda1437
EZ
2662 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2663 produced by %s or %c overflows available buffer space. (Bug#8545)
2664
f76dee0c
PE
26652011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2666
2667 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2668 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2669
fdc5744d
JB
26702011-04-28 Juanma Barranquero <lekktu@gmail.com>
2671
2672 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2673
638f053a
JB
26742011-04-28 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * keyboard.c (Qdelayed_warnings_hook): Define.
2677 (command_loop_1): Run `delayed-warnings-hook'
2678 if Vdelayed_warnings_list is non-nil.
2679 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2680 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2681
d178f871
EZ
26822011-04-28 Eli Zaretskii <eliz@gnu.org>
2683
2684 * doprnt.c (doprnt): Don't return value smaller than the buffer
2685 size if the message was truncated. (Bug#8545).
2686
b124fd93
JB
26872011-04-28 Juanma Barranquero <lekktu@gmail.com>
2688
2689 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2690 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2691
e810457d
PE
26922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2693
2694 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2695
ea51cceb
JB
26962011-04-27 Juanma Barranquero <lekktu@gmail.com>
2697
2698 * makefile.w32-in: Update dependencies.
2699
94dcfacf
EZ
27002011-04-27 Eli Zaretskii <eliz@gnu.org>
2701
2702 Improve `doprnt' and its usage. (Bug#8545)
2703 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2704 `format_end'. Remove support for %l as a conversion specifier.
2705 Don't use xrealloc. Improve diagnostics when the %l size modifier
2706 is used. Update the commentary.
2707
2708 * eval.c (verror): Simplify calculation of size_t.
2709
2710 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2711 messages.
2712
f61f41d7
PE
27132011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2714
2715 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2716 change.
2717
96fb4434
PE
27182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2721 This makes this file independent of the recent pseudovector change.
2722
671875da 27232011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2724
69e9b5a3
PE
2725 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2726
b5f869a7 2727 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2728 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2729 Remove unused local.
c8926152 2730 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2731
841a1577 2732 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2733 GCC 4.6.0 optimizes based on type-based alias analysis.
2734 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2735 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2736 != &v->size, and therefore "v->size = 1; b->size = 2; return
2737 v->size;" must therefore return 1. This assumption is incorrect
2738 for Emacs, since it type-puns struct Lisp_Vector * with many other
2739 types. To fix this problem, this patch adds a new type struct
f904488f 2740 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2741 and pseudovectors, and helps optimizing compilers not get fooled
2742 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2743 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2744 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2745 the size member.
eab3844f
PE
2746 (XSETPVECTYPE): Rewrite in terms of new macro.
2747 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2748 This is a bit clearer, and further avoids the possibility of
2749 undesirable aliasing.
2750 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2751 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2752 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2753 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2754 (ASIZE): Now uses header.size rather than size.
2755 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2756 to avoid the hassle of writing XVECTOR (foo)->header.size.
2757 (struct vectorlike_header): New type.
eab3844f
PE
2758 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2759 object, to help avoid aliasing.
2760 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2761 (SUBRP): Likewise, since Lisp_Subr is a special case.
2762 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2763 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2764 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2765 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2766 changed to be "header.size" and "header.next".
2767 * buffer.h (struct buffer): Likewise.
2768 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2769 * frame.h (struct frame): Likewise.
2770 * process.h (struct Lisp_Process): Likewise.
2771 * termhooks.h (struct terminal): Likewise.
2772 * window.c (struct save_window_data, struct saved_window): Likewise.
2773 * window.h (struct window): Likewise.
2774 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2775 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2776 * buffer.c (init_buffer_once): Likewise.
2777 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2778 special case.
2779 * process.c (Fformat_network_address): Use local var for size,
2780 for brevity.
2781
0df1eac5
PE
2782 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2783
847ab9d1 2784 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2785 * data.c (atof): Remove decl; no longer used or needed.
2786 (digit_to_number): Move to lread.c.
2787 (Fstring_to_number): Use new string_to_number function, to be
2788 consistent with how the Lisp reader treats infinities and NaNs.
2789 Do not assume that floating-point numbers represent EMACS_INT
2790 without losing information; this is not true on most 64-bit hosts.
2791 Avoid double-rounding errors, by insisting on integers when
2792 parsing non-base-10 numbers, as the documentation specifies.
2793 * lisp.h (string_to_number): New decl, replacing ...
2794 (isfloat_string): Remove.
bc0a5c13 2795 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2796 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2797 appears to have been a coding error. Similarly, do not accept
2798 strings like +-1e0 as floating point numbers. Do not report
2799 overflow for integer overflows unless the base is not 10 which
2800 means we have no simple and reliable way to continue.
2801 Break out the floating-point parsing into a new
2802 function string_to_number, so that Fstring_to_number parses
2803 floating point numbers consistently with the Lisp reader.
04f2d78b 2804 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2805 (E_CHAR, EXP_INT): Remove, replacing with ...
2806 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2807 (string_to_number): New function, replacing isfloat_string.
2808 This function checks for valid syntax and produces the resulting
2809 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2810 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2811 so that overflow for non-base-10 numbers is reported only when
2812 there's no portable and simple way to convert to floating point.
452f4150 2813
67769ffc
PE
2814 * textprop.c (set_text_properties_1): Rewrite for clarity,
2815 and to avoid GCC warning about integer overflow.
2816
c20db43f
PE
2817 * intervals.h (struct interval): Use EMACS_INT for members
2818 where EMACS_UINT might cause problems. See
2819 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2820 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2821 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2822 All uses changed.
37aa2f85
PE
2823 (offset_intervals): Tell GCC not to worry about length overflow
2824 when negating a negative length.
c20db43f 2825
2538aa2f
PE
2826 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2827 (overrun_check_free): Likewise.
2828
f2d3008d
PE
2829 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2830 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2831 word size.
2832
ec8df744
PE
2833 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2834 (gnutls_make_error): Rename local to avoid shadowing.
2835 (gnutls_emacs_global_deinit): ifdef out; not used.
2836 (Fgnutls_boot): Use const for pointer to readonly storage.
2837 Comment out unused local. Fix pointer signedness problems.
2838
640ee02d
PE
2839 * lread.c (openp): Don't stuff size_t into an 'int'.
2840 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2841 about possible signed overflow.
2842
6048fb2a
PE
2843 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2844 (GDK_KEY_g): Don't define if already defined.
2845 (xg_prepare_tooltip): Avoid pointer signedness problem.
2846 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2847
fa3c87e1
PE
2848 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2849 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2850
2172544b
PE
2851 * xfns.c (Fx_window_property): Simplify a bit,
2852 to make a bit faster and to avoid GCC 4.6.0 warning.
2853 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2854
9b821a21
PE
2855 * fns.c (internal_equal): Don't assume size_t fits in int.
2856
3c616cfa
PE
2857 * alloc.c (compact_small_strings): Tighten assertion a little.
2858
c2982e87
PE
2859 Replace pEd with more-general pI, and fix some printf arg casts.
2860 * lisp.h (pI): New macro, generalizing old pEd macro to other
2861 conversion specifiers. For example, use "...%"pI"d..." rather
2862 than "...%"pEd"...".
2863 (pEd): Remove. All uses replaced with similar uses of pI.
2864 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2865 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2866 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2867 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2868 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2869 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2870 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2871 64-bit hosts.
2872 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2873 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2874 * print.c (safe_debug_print, print_object): Likewise.
2875 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2876 to int.
6f04d126
PE
2877 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2878 avoiding the 0 flag, which is not portable.
c2982e87
PE
2879 * process.c (Fmake_network_process): Use pI to avoid cast.
2880 * region-cache.c (pp_cache): Likewise.
2881 * xdisp.c (decode_mode_spec): Likewise.
2882 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2883 behavior on 64-bit hosts with printf arg.
6f04d126 2884 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2885 (x_stop_queuing_selection_requests): Likewise.
2886 (x_get_window_property): Don't truncate byte count to an 'int'
2887 when tracing.
0b432f21 2888
5e073ec7
PE
2889 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2890 here, since it parses constructs like leading '-' and spaces,
2891 which are not wanted; and it overflows with large numbers.
2892 Instead, simply match F[0-9]+, which is what is wanted anyway.
2893
36372bf9
PE
2894 * alloc.c: Remove unportable assumptions about struct layout.
2895 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2896 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2897 (allocate_vectorlike, make_pure_vector): Use the new macros,
2898 plus offsetof, to remove unportable assumptions about struct layout.
2899 These assumptions hold on all porting targets that I know of, but
2900 they are not guaranteed, they're easy to remove, and removing them
2901 makes further changes easier.
2902
0b432f21
PE
2903 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2904 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2905 (string_overrun_cookie): Now const. Use initializers that
2906 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2907 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2908 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2909 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2910 multiple of sizeof (EMACS_INT); it need not be, if
2911 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2912 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2913
895009e1
JB
29142011-04-26 Juanma Barranquero <lekktu@gmail.com>
2915
2916 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2917
6a7a1b0b
TZ
29182011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2919
2920 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2921 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2922 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2923
841a1577 29242011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2925
2926 * lisp.h (Qdebug): List symbol.
895009e1 2927 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2928 * keyboard.c (debug-on-event): New variable.
2929 (handle_user_signal): Break into debugger when debug-on-event
2930 matches the current signal symbol.
2931
f2d3ba6f
DN
29322011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2933
2934 * alloc.c (check_sblock, check_string_bytes)
2935 (check_string_free_list): Convert to standard C.
2936
42ce4c63
TZ
29372011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2938
2939 * w32.c (emacs_gnutls_push): Fix typo.
2940
825cd63c
EZ
29412011-04-25 Eli Zaretskii <eliz@gnu.org>
2942
fb11d64d
EZ
2943 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2944 "cast to pointer from integer of different size".
2945
825cd63c
EZ
2946 Improve doprnt and its use in verror. (Bug#8545)
2947 * doprnt.c (doprnt): Document the set of format control sequences
2948 supported by the function. Use SAFE_ALLOCA instead of always
2949 using `alloca'.
2950
2951 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2952 is one byte too soon. Don't use xrealloc; instead xfree and
2953 xmalloc anew.
2954
e061a11b
TZ
29552011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2956
2957 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2958 callbacks stage.
2959
2960 * gnutls.c: Renamed global_initialized to
2961 gnutls_global_initialized. Added internals for the
2962 :verify-hostname-error, :verify-error, and :verify-flags
2963 parameters of `gnutls-boot' and documented those parameters in the
2964 docstring. Start callback support.
9173deec
JB
2965 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2966 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2967 on error. Return error code.
e061a11b
TZ
2968 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2969 (emacs_gnutls_read): Likewise.
2970 (Fgnutls_boot): Return handshake error code.
2971 (emacs_gnutls_handle_error): New function.
2972 (wsaerror_to_errno): Likewise.
2973
2974 * w32.h (emacs_gnutls_pull): Add prototype.
2975 (emacs_gnutls_push): Likewise.
2976
2977 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2978 (emacs_gnutls_push): Likewise.
2979
29802011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2981
2982 * process.c (wait_reading_process_output): Check if GnuTLS
2983 buffered some data internally if no FDs are set for TLS
2984 connections.
2985
2986 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2987 (LIBS): Link to USER_LIBS.
2988 ($(BLD)/gnutls.$(0)): New target.
2989
fa6996bc
EZ
29902011-04-24 Eli Zaretskii <eliz@gnu.org>
2991
eb35682e
EZ
2992 * xdisp.c (handle_single_display_spec): Rename the
2993 display_replaced_before_p argument into display_replaced_p, to
2994 make it consistent with the commentary. Fix typos in the
2995 commentary.
2996
e2ad650c
EZ
2997 * textprop.c (syms_of_textprop): Remove dead code.
2998 (copy_text_properties): Delete obsolete commentary about an
2999 interface that was deleted long ago. Fix typos in the description
3000 of arguments.
3001
1b2de274
EZ
3002 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3003 to changes in oldXMenu/XMenu.h from 2011-04-16.
3004 <menu_help_message, prev_menu_help_message>: Constify.
3005 (IT_menu_make_room): menu->help_text is now `const char **';
3006 adjust.
3007
3008 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3009 to changes in oldXMenu/XMenu.h from 2011-04-16.
3010 (struct XMenu): Declare `help_text' `const char **'.
3011
3012 * xfaces.c <Qunspecified>: Make extern again.
3013
3014 * syntax.c: Include sys/types.h before including regex.h, as
3015 required by Posix.
3016
762b15be
EZ
3017 * doc.c (get_doc_string): Improve the format passed to `error'.
3018
3019 * doprnt.c (doprnt): Improve commentary.
3020
3021 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3022
3023 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3024 them with etags.
3025
f1052e5d
EZ
3026 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3027 changes in globals.h immediately force recompilation.
762b15be
EZ
3028 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3029 $(CURDIR)/s/ms-w32.h.
3030 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3031
fa6996bc
EZ
3032 * character.c (Fchar_direction): Function deleted.
3033 (syms_of_character): Don't defsubr it.
3034 <char-direction-table>: Deleted.
3035
e6c3da20
EZ
30362011-04-23 Eli Zaretskii <eliz@gnu.org>
3037
3038 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3039 * doprnt.c: Include limits.h.
3040 (SIZE_MAX): New macro.
04f2d78b
CB
3041 (doprnt): Return a size_t value. 2nd arg is now size_t.
3042 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3043 Improve overflow protection. Support `l' modifier for integer
3044 conversions. Support %l conversion. Don't assume an EMACS_INT
3045 argument for integer conversions and for %c.
3046
3047 * lisp.h (doprnt): Restore prototype.
3048
3049 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3050 $(SRC)/character.h.
3051
3052 * Makefile.in (base_obj): Add back doprnt.o.
3053
3054 * deps.mk (doprnt.o): Add back prerequisites.
3055 (callint.o): Depend on character.h.
3056
3057 * eval.c (internal_lisp_condition_case): Include the handler
3058 representation in the error message.
3059 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3060 when breaking from the loop.
3061
3062 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3063
3064 * callint.c (Fcall_interactively): When displaying error message
3065 about invalid control letter, pass the character's codepoint, not
3066 a pointer to its multibyte form. Improve display of the character
3067 in octal and display also its hex code.
3068
3069 * character.c (char_string): Use %x to display the (unsigned)
3070 codepoint of an invalid character, to avoid displaying a bogus
3071 negative value.
3072
3073 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3074 `error', not SYMBOL_NAME itself.
3075
3076 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3077 character arguments to `error'.
3078
3079 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3080 to `error' in error message about FINAL_CHAR argument. Make sure
3081 FINAL_CHAR is a character, and use %c when it is passed as
3082 argument to `error'.
3083
4ffd0d6b 30842011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3085
3086 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3087
3088 * w32.c: Include <time.h>.
3089 (sys_localtime): New function.
3090
4ffd0d6b 30912011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3092
3093 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3094
4ffd0d6b 3095 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3096
4ffd0d6b 30972011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3098
4ffd0d6b
GM
3099 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3100 zombies (Bug#8467).
aac0c6e3 3101
04c56954
EZ
31022011-04-19 Eli Zaretskii <eliz@gnu.org>
3103
3104 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3105 gl_state.e_property when gl_state.object is Qt.
3106
3107 * insdel.c (make_gap_larger): Remove limitation of buffer size
3108 to <= INT_MAX.
3109
16a43933
CY
31102011-04-18 Chong Yidong <cyd@stupidchicken.com>
3111
3112 * xdisp.c (lookup_glyphless_char_display)
3113 (produce_glyphless_glyph): Handle cons cell entry in
3114 glyphless-char-display.
3115 (Vglyphless_char_display): Document it.
3116
3117 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3118 glyphless-char-display.
3119
4581706e
CY
31202011-04-17 Chong Yidong <cyd@stupidchicken.com>
3121
3122 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3123
3124 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3125
3126 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3127 definition for no-X builds.
3128
4887c6e2 31292011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3130
fd35b6f9
PE
3131 Static checks with GCC 4.6.0 and non-default toolkits.
3132
5c1ccb01
PE
3133 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3134
006c5daa
PE
3135 * process.c (keyboard_bit_set): Define only if SIGIO.
3136 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3137 (send_process): Repair possible setjmp clobbering.
3138
efc736d3
PE
3139 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3140
4e2fe2e6
PE
3141 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3142
f97334a2
PE
3143 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3144
4e75f29d
PE
3145 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3146 Define only if needed.
3147
90efadd1
PE
3148 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3149 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3150 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3151
3c647824
PE
3152 * dispextern.h (struct redisplay_interface): Rename param
3153 to avoid shadowing.
e264f262 3154 * termhooks.h (struct terminal): Likewise.
761383f4 3155 * xterm.c (xembed_send_message): Likewise.
3c647824 3156
b58c5c4a
PE
3157 * insdel.c (make_gap_smaller): Define only if
3158 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3159
cad59032
PE
3160 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3161 it.
3162
c339dc2e
PE
3163 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3164 so that we aren't warned about unused symbols.
3165
91a3e27b
PE
3166 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3167
399c71d3 3168 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3169
8ffc96f5
PE
3170 * xfns.c (x_real_positions): Mark locals as initialized.
3171
eef9bc79
PE
3172 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3173
098db9dd
PE
3174 * xterm.c: Fix problems found by static analysis with other toolkits.
3175 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3176 (x_dispatch_event): Declare static if USE_GTK, and
3177 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3178 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3179 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3180 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3181 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3182
eb18f6cc
PE
3183 * xmenu.c (menu_help_callback): Pointer type fixes.
3184 Use const pointers when pointing at readonly data. Avoid pointer
3185 signedness clashes.
3186 (FALSE): Remove unused macro.
3187 (update_frame_menubar): Remove unused decl.
3188
1fe72bf8
PE
3189 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3190
60d9e1db
PE
3191 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3192 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3193 (single_menu_item): Rename local to avoid shadowing.
3194
39261c26
PE
3195 * keyboard.c (make_lispy_event): Remove unused local var.
3196
018c5e19
PE
3197 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3198 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3199
63d2b86e
PE
3200 * bitmaps: Change bitmaps from unsigned char back to the X11
3201 compatible char. Avoid the old compiler warnings about
3202 out-of-range initializers by using, for example, '\xab' rather
3203 than 0xab.
3204
aefd87e1
PE
3205 * xgselect.c (xgselect_initialize): Check vs interface
3206 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3207
bf501fb9
PE
3208 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3209
e9829fdf
PE
3210 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3211 to read-only memory.
3212
1086c095
PE
3213 * fns.c (vector): Remove; this old hack is no longer needed.
3214
2baccd04 3215 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3216 Remove unused var.
dde42981 3217 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3218
72391843 3219 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3220
436c16df 3221 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3222 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3223 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3224
92bb796d 3225 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3226 (x_term_init): Remove local to avoid shadowing.
92bb796d 3227
764430a3 3228 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3229
3230 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3231 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3232
d1dfb56c
EZ
32332011-04-16 Eli Zaretskii <eliz@gnu.org>
3234
c4354cb4
EZ
3235 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3236
d1dfb56c
EZ
3237 Fix regex.c, syntax.c and friends for buffers > 2GB.
3238 * syntax.h (struct gl_state_s): Declare character position members
3239 EMACS_INT.
3240
3241 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3242
04f2d78b
CB
3243 * textprop.c (verify_interval_modification, interval_of):
3244 Declare arguments EMACS_INT.
d1dfb56c
EZ
3245
3246 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3247 EMACS_INT.
3248
3249 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3250
3251 * indent.c (Fvertical_motion): Local variable it_start is now
3252 EMACS_INT.
3253
3254 * regex.c (re_match, re_match_2, re_match_2_internal)
3255 (bcmp_translate, regcomp, regexec, print_double_string)
3256 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3257 (re_compile_pattern, re_exec): Declare arguments and local
3258 variables `size_t' and `ssize_t' and return values `regoff_t', as
3259 appropriate.
3260 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3261 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3262 <compile_stack_type>: `size' and `avail' are now `size_t'.
3263
3264 * regex.h <regoff_t>: Use ssize_t, not int.
3265 (re_search, re_search_2, re_match, re_match_2): Arguments that
3266 specify buffer/string position and length are now ssize_t and
3267 size_t. Return type is regoff_t.
3268
613052cd
BK
32692011-04-16 Ben Key <bkey76@gmail.com>
3270
3271 * nsfont.m: Fixed bugs in ns_get_family and
3272 ns_descriptor_to_entity that were caused by using free to
3273 deallocate memory blocks that were allocated by xmalloc (via
3274 xstrdup). This caused Emacs to crash when compiled with
3275 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3276 --enable-checking=xmallocoverrun). xfree is now used to
3277 deallocate these memory blocks.
3278
4170f62f 32792011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3280
71b41406
PE
3281 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3282
9587a89d
PE
3283 emacs_write: Accept and return EMACS_INT for sizes.
3284 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3285 et seq.
3286 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3287 Accept and return EMACS_INT.
3288 (emacs_gnutls_write): Return the number of bytes written on
3289 partial writes.
3290 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3291 (emacs_read, emacs_write): Remove check for negative size, as the
3292 Emacs source code has been audited now.
9587a89d
PE
3293 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3294 (emacs_read, emacs_write): Use it.
273a5f82
PE
3295 * process.c (send_process): Adjust to the new signatures of
3296 emacs_write and emacs_gnutls_write. Do not attempt to store
3297 a byte offset into an 'int'; it might overflow.
9587a89d 3298 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3299
3e047f51
PE
3300 * sound.c: Don't assume sizes fit in 'int'.
3301 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3302 Return EMACS_INT, not int.
3e047f51 3303 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3304 Accept EMACS_INT, not int.
3305 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3306 record read return values.
3307
cc39a9db
BK
33082011-04-15 Ben Key <bkey76@gmail.com>
3309
c9d0ec6d
JB
3310 * keyboard.c (Qundefined): Don't declare static since it is used
3311 in nsfns.m.
3312 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3313 static since they are used in nsfont.m.
cc39a9db 3314
6c60eb9f
SM
33152011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3316
3317 * process.c (Qprocessp): Don't declare static.
3318 * lisp.h (Qprocessp): Declare again.
3319
7990b61a
JB
33202011-04-15 Juanma Barranquero <lekktu@gmail.com>
3321
3322 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3323
5d4cb038
PE
33242011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3325
8bd7b830 3326 Improve C-level modularity by making more things 'static'.
cd64ea1d 3327
e3b27b31
PE
3328 Don't publish debugger-only interfaces to other modules.
3329 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3330 (verify_bytepos, count_markers): Move decls to the only modules
3331 that need them.
3332 * region-cache.h (pp_cache): Likewise.
3333 * window.h (check_all_windows): Likewise.
3334 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3335
5d4cb038
PE
3336 * sysdep.c (croak): Now static, if
3337 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3338 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3339
3340 * alloc.c (refill_memory_reserve): Now static if
3341 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3342 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3343
e87b6180
PE
3344 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3345 Define only if USE_LUCID.
3346
ac64929e
PE
3347 * xrdb.c (x_customization_string, x_rm_string): Now static.
3348
6f37259d
PE
3349 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3350 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3351
1683e3ab
PE
3352 * xdisp.c (draw_row_with_mouse_face): Now static.
3353 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3354
de9c2632
PE
3355 * window.h (check_all_windows): Mark externally visible.
3356
2b96acb7
PE
3357 * window.c (window_deletion_count): Now static.
3358
3359 * undo.c: Make symbols static if they're not exported.
3360 (last_undo_buffer, last_boundary_position, pending_boundary):
3361 Now static.
3362
50436f33
PE
3363 * textprop.c (interval_insert_behind_hooks): Now static.
3364 (interval_insert_in_front_hooks): Likewise.
3365
64520e5c
PE
3366 * term.c: Make symbols static if they're not exported.
3367 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3368 (max_frame_lines, tty_set_terminal_modes):
3369 (tty_reset_terminal_modes, tty_turn_off_highlight):
3370 (get_tty_terminal): Now static.
3371 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3372 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3373 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3374 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3375 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3376
1fa53021
PE
3377 * sysdep.c: Make symbols static if they're not exported.
3378 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3379 Now static.
3380 (sigprocmask_set, full_mask): Remove; unused.
3381 (wait_debugging): Mark as visible.
3382 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3383 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3384
d4b43b22
PE
3385 * syntax.c (syntax_temp): Define only if !__GNUC__.
3386
b7c513d0
PE
3387 * sound.c (current_sound_device, current_sound): Now static.
3388
989b29ad
PE
3389 * search.c (searchbufs, searchbuf_head): Now static.
3390
13a55a78
PE
3391 * scroll.c (scroll_cost): Remove; unused.
3392 * dispextern.h (scroll_cost): Remove decl.
3393
de68a1fc
PE
3394 * region-cache.h (pp_cache): Mark as externally visible.
3395
40ccffa6
PE
3396 * process.c: Make symbols static if they're not exported.
3397 (process_tick, update_tick, create_process, chan_process):
3398 (Vprocess_alist, proc_buffered_char, datagram_access):
3399 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3400 (deactivate_process): Mark defn as static, as well as decl.
3401 * lisp.h (create_process): Remove decl.
3402 * process.h (chan_process, Vprocess_alist): Remove decls.
3403
ad64fc97
PE
3404 * print.c: Make symbols static if they're not exported.
3405 (print_depth, new_backquote_output, being_printed, print_buffer):
3406 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3407 (print_interval, print_number_index, initial_stderr_stream):
3408 Now static.
3409 * lisp.h (Fprinc): Remove decl.
3410 (debug_output_compilation_hack): Mark as externally visible.
3411
adddb265
PE
3412 * sysdep.c (croak): Move decl from here to syssignal.h.
3413 * syssignal.h (croak): Put it here, so the API can be checked when
3414 'croak' is called from dissociate_if_controlling_tty.
3415
1717ede2
PE
3416 * minibuf.c: Make symbols static if they're not exported.
3417 (minibuf_save_list, choose_minibuf_frame): Now static.
3418 * lisp.h (choose_minibuf_frame): Remove decl.
3419
fa5fb2bc
PE
3420 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3421
1e3890d1
PE
3422 * lread.c: Make symbols static if they're not exported.
3423 (read_objects, initial_obarray, oblookup_last_bucket_number):
3424 Now static.
3425 (make_symbol): Remove; unused.
3426 * lisp.h (initial_obarray, make_symbol): Remove decls.
3427
8a1414fa
PE
3428 * keyboard.c: Make symbols static if they're not exported.
3429 (single_kboard, recent_keys_index, total_keys, recent_keys):
3430 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3431 (this_single_command_key_start, echoing, last_auto_save):
3432 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3433 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3434 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3435 (Vlispy_mouse_stem, double_click_count):
3436 Now static.
3437 (force_auto_save_soon): Define only if SIGDANGER.
3438 (ignore_mouse_drag_p): Now static if
3439 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3440 (print_help): Remove; unused.
3441 (stop_character, last_timer_event): Mark as externally visible.
3442 * keyboard.h (ignore_mouse_drag_p): Declare only if
3443 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3444 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3445 * lisp.h (echoing): Remove decl.
3446 (force_auto_save_soon): Declare only if SIGDANGER.
3447 * xdisp.c (redisplay_window): Simplify code, to make it more
3448 obvious that ignore_mouse_drag_p is not accessed if !defined
3449 USE_GTK && !defined HAVE_NS.
3450
93ea6e8f
PE
3451 * intervals.c: Make symbols static if they're not exported.
3452 (merge_properties_sticky, merge_interval_right, delete_interval):
3453 Now static.
3454 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3455
77382fcc
PE
3456 * insdel.c: Make symbols static if they're not exported.
3457 However, leave prepare_to_modify_buffer alone. It's never
3458 called from outside this function, but that appears to be a bug.
3459 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3460 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3461 (adjust_after_replace_noundo): Remove; unused.
3462 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3463 (signal_before_change): Remove decls.
77382fcc 3464
9306c32e
PE
3465 * indent.c (val_compute_motion, val_vmotion): Now static.
3466
cd44d2eb
PE
3467 * image.c: Make symbols static if they're not exported.
3468 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3469 if USE_GTK.
3470 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3471 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3472
ad9a7a06
PE
3473 * fringe.c (standard_bitmaps): Now static.
3474 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3475
81626931
PE
3476 * frame.c: Make symbols static if they're not exported.
3477 (x_report_frame_params, make_terminal_frame): Now static.
3478 (get_frame_param): Now static, unless HAVE_NS.
3479 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3480 (x_get_resource_string): Remove; not used.
3481 * frame.h (make_terminal_frame, x_report_frame_params):
3482 (x_get_resource_string); Remove decls.
3483 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3484 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3485
239f9db9
PE
3486 * font.c, fontset.c: Make symbols static if they're not exported.
3487 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3488 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3489 * font.c (font_close_object): Now static.
3490 * font.h (font_close_object): Remove.
3491 * fontset.c (FONTSET_OBJLIST): Remove.
3492 (free_realized_fontset) #if-0 the body, which does nothing.
3493 (face_suitable_for_char_p): #if-0, as it's never called.
3494 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3495 * xfaces.c (face_at_string_position):
3496 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3497 since 0 is always ASCII.
3498
dfcf3579
PE
3499 * fns.c (weak_hash_tables): Now static.
3500
5045092b
PE
3501 * fileio.c: Make symbols static if they're not exported.
3502 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3503 (Vwrite_region_annotation_buffers): Now static.
3504
57a96f5c
PE
3505 * eval.c: Make symbols static if they're not exported.
3506 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3507 * lisp.h (backtrace_list): Remove decl.
3508
35f08c38
PE
3509 * emacs.c: Make symbols static if they're not exported.
3510 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3511 (fatal_error_code, fatal_error_signal_hook, standard_args):
3512 Now static.
3513 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3514 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3515 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3516 * lisp.h (fatal_error_signal_hook): Remove decl.
3517 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3518
f44bd759
PE
3519 * editfns.c: Move a (normally-unused) function to its only use.
3520 * editfns.c, lisp.h (get_operating_system_release): Remove.
3521 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3522 worth the hassle of breaking this out.
3523
b532497d
PE
3524 * xterm.c: Make symbols static if they're not exported.
3525 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3526 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3527 (x_destroy_window, x_delete_display):
3528 Now static.
3529 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3530 (x_mouse_leave): Remove; unused.
3531 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3532 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3533 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3534 Remove decls.
3535 (x_mouse_leave): Declare only if WINDOWSNT.
3536 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3537 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3538 USE_X_TOOLKIT.
3539
1675728f
PE
3540 * ftxfont.c: Make symbols static if they're not exported.
3541 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3542 HAVE_FREETYPE.
3543 * font.h (ftxfont_driver): Likewise.
3544
e4cebfca
PE
3545 * xfns.c: Make symbols static if they're not exported.
3546 (x_last_font_name, x_display_info_for_name):
3547 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3548 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3549 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3550 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3551 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3552 (last_show_tip_args): Now static.
3553 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3554 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3555 (x_screen_planes): Remove; unused.
3556 * dispextern.h (x_screen_planes): Remove decl.
3557
5bf46f05
PE
3558 * dispnew.c: Make symbols static if they're not exported.
3559 * dispextern.h (redraw_garbaged_frames, scrolling):
3560 (increment_row_positions): Remove.
3561 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3562 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3563 Now static.
3564 (redraw_garbaged_frames): Remove; unused.
3565
435f4c28
PE
3566 * xfaces.c: Make symbols static if they're not exported.
3567 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3568 Remove decls.
3569 * xterm.h (defined_color): Remove decls.
3570 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3571 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3572 (menu_face_changed_default, defined_color, free_realized_face):
3573 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3574 (ascii_face_of_lisp_face): Remove; unused.
3575
8524aef3
PE
3576 * xdisp.c: Make symbols static if they're not exported.
3577 * dispextern.h (scratch_glyph_row, window_box_edges):
3578 (glyph_to_pixel_coords, set_cursor_from_row):
3579 (get_next_display_element, set_iterator_to_next):
3580 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3581 (show_mouse_face): Remove decls
3582 * frame.h (message_buf_print): Likewise.
3583 * lisp.h (pop_message, set_message, check_point_in_composition):
3584 Likewise.
3585 * xterm.h (set_vertical_scroll_bar): Likewise.
3586 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3587 (message_buf_print, scratch_glyph_row, displayed_buffer):
3588 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3589 (get_next_display_element, show_mouse_face, window_box_edges):
3590 (frame_to_window_pixel_xy, check_point_in_composition):
3591 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3592 (glyph_to_pixel_coords): Remove; unused.
3593
16390cd2
PE
3594 * dired.c (file_name_completion): Now static.
3595
3596 * dbusbind.c (xd_in_read_queued_messages): Now static.
3597
a25f4dfa
PE
3598 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3599 * data.c (circular_list_error): Remove.
3600
14a9c8df
PE
3601 * commands.h (last_point_position, last_point_position_buffer):
3602 (last_point_position_window): Remove decls.
3603 * keyboard.c: Make these variables static.
3604
04f2d78b
CB
3605 * coding.h (coding, code_convert_region, encode_coding_gap):
3606 Remove decls.
74ab6df5
PE
3607 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3608 (iso_code_class, detect_coding, code_convert_region): Now static.
3609 (encode_coding_gap): Remove; unused.
3610
38dfbee1
PE
3611 * chartab.c (chartab_chars, chartab_bits): Now static.
3612
a2cb4e63
PE
3613 * charset.h (charset_iso_8859_1): Remove decl.
3614 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3615 Now static.
3616
127198fd
PE
3617 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3618 * ccl.c (Vccl_program_table): Now static.
3619 (check_ccl_update): Remove; unused.
3620
d85b608f
PE
3621 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3622 * category.h: ... from here.
3623 * category.c (check_category_table, set_category_set): Now static.
3624
31cd66f3
PE
3625 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3626 * lisp.h: Remove these decls.
3627
c358e587
PE
3628 * buffer.c (buffer_count): Remove unused var.
3629
e78aecca
PE
3630 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3631 so that it's not optimized away.
3632 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3633 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3634 exported only to the debugger.
3635
e192d7d3 3636 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3637 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3638
92470028
PE
3639 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3640 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3641 was inaccessible from Lisp.
3642 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3643 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3644
244ed907
PE
3645 alloc.c: Import and export fewer symbols, and remove unused items.
3646 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3647 is defined.
3648 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3649 it's not optimized away by whole-program optimization.
3650 (message_enable_multibyte, free_misc): Remove.
3651 (catchlist, handlerlist, mark_backtrace):
3652 Declare only if BYTE_MARK_STACK.
3653 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3654 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3655 (message_enable_multibyte): Remove decl.
3656 (free_misc, interval_free_list, float_block, float_block_index):
3657 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3658 (cons_free_list, last_marked_index):
3659 Now static.
3660 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3661 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3662 (mark_backtrace): Define only if BYTE_MARK_STACK.
3663 * xdisp.c (message_enable_multibyte): Now static.
3664
61c2b50e 3665 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3666 This makes it easier for human readers (and static analyzers)
3667 to see whether these variables are used from other modules.
3668 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3669 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3670 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3671 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3672 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3673 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3674 * xmenu.c, xselect.c:
3675 Declare Q* vars static if they are not used in other modules.
3676 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3677 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3678 Remove decls of unexported vars.
3679 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3680
95c82688
PE
3681 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3682
16a97296
PE
3683 Make Emacs functions such as Fatom 'static' by default.
3684 This makes it easier for human readers (and static analyzers)
3685 to see whether these functions can be called from other modules.
3686 DEFUN now defines a static function. To make the function external
3687 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3688 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3689 (Finit_image_library):
16a97296
PE
3690 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3691 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3692 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3693 Remove decls, since these functions are now static.
3694 (Funintern, Fget_internal_run_time): New decls, since these functions
3695 were already external.
95c82688 3696
16a97296
PE
3697 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3698 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3699 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3700 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3701 * keyboard.c, keymap.c, lread.c:
3702 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3703 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3704 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3705 Mark functions with DEFUE instead of DEFUN,
3706 if they are used in other modules.
3707 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3708 decls for now-static functions.
3709 * buffer.h (Fdelete_overlay): Remove decl.
3710 * callproc.c (Fgetenv_internal): Mark as internal.
3711 * composite.c (Fremove_list_of_text_properties): Remove decl.
3712 (Fcomposition_get_gstring): New forward static decl.
3713 * composite.h (Fcomposite_get_gstring): Remove decl.
3714 * dired.c (Ffile_attributes): New forward static decl.
3715 * doc.c (Fdocumntation_property): New forward static decl.
3716 * eval.c (Ffetch_bytecode): New forward static decl.
3717 (Funintern): Remove extern decl; now in .h file where it belongs.
3718 * fileio.c (Fmake_symbolic_link): New forward static decl.
3719 * image.c (Finit_image_library): New forward static decl.
3720 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3721 * intervals.h (Fprevious_property_change):
3722 (Fremove_list_of_text_properties): Remove decls.
3723 * keyboard.c (Fthis_command_keys): Remove decl.
3724 (Fcommand_execute): New forward static decl.
3725 * keymap.c (Flookup_key): New forward static decl.
3726 (Fcopy_keymap): Now static.
3727 * keymap.h (Flookup_key): Remove decl.
3728 * process.c (Fget_process): New forward static decl.
3729 (Fprocess_datagram_address): Mark as internal.
3730 * syntax.c (Fsyntax_table_p): New forward static decl.
3731 (skip_chars): Remove duplicate decl.
3732 * textprop.c (Fprevious_property_change): New forward static decl.
3733 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3734 Now internal.
3735 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3736 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3737
785bbd42
PE
3738 * editfns.c (Fformat): Remove unreachable code.
3739
8b913b57
AS
37402011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3741
3742 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3743 change. (Bug#8496)
3744
a6744a35
EZ
37452011-04-13 Eli Zaretskii <eliz@gnu.org>
3746
3747 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3748 when at ZV. (Bug#8487)
3749
e7974947
AS
37502011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3751
baad03f0
AS
3752 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3753 (Bug#8437)
3754 * keyboard.c (parse_tool_bar_item): Likewise.
3755 * sound.c (sound_cleanup, alsa_close): Likewise.
3756 * termcap.c (tgetent): Likewise.
3757 * xfns.c (x_default_font_parameter): Likewise.
3758 * xsettings.c (read_and_apply_settings): Likewise.
3759
e7974947
AS
3760 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3761 (overrun_check_free): Protoize.
3762
28272684
PE
37632011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3764
3765 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3766 since callers should never pass a negative size.
3767 Change the signature to match that of plain 'read' and 'write'; see
3768 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3769 * lisp.h: Update prototypes of emacs_write and emacs_read.
3770
11997c76
EZ
37712011-04-11 Eli Zaretskii <eliz@gnu.org>
3772
3773 * xdisp.c (redisplay_window): Don't try to determine the character
3774 position of the scroll margin if the window start point w->startp
e896f03c 3775 is outside the buffer's accessible region. (Bug#8468)
11997c76 3776
8a2cbd72
EZ
37772011-04-10 Eli Zaretskii <eliz@gnu.org>
3778
3779 Fix write-region and its subroutines for buffers > 2GB.
3780 * fileio.c (a_write, e_write): Modify declaration of arguments and
3781 local variables to support buffers larger than 2GB.
3782 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3783
3784 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3785 argument, local variables, and return value.
3786
3787 * lisp.h: Update prototypes of emacs_write and emacs_read.
3788
3789 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3790
4073e537 37912011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3792
1ebfdcb6
PE
3793 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3794
b2ded58d
PE
3795 Fix more problems found by GCC 4.6.0's static checks.
3796
7d66342c
PE
3797 * xdisp.c (vmessage): Use a better test for character truncation.
3798
bbf47d44
PE
3799 * charset.c (load_charset_map): <, not <=, for optimization,
3800 and to avoid potential problems with integer overflow.
9248994d 3801 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3802 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3803 * editfns.c (Fformat): Likewise.
1e69125e 3804 * syntax.c (skip_chars): Likewise.
3befa583 3805
e3019616
PE
3806 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3807 This also lets GCC 4.6.0 generate slightly better loop code.
3808
becfa255
PE
3809 * callint.c (Fcall_interactively): <, not <=, for optimization.
3810 (Fcall_interactively): Count the number of arguments produced,
3811 not the number of arguments given. This is simpler and lets GCC
3812 4.6.0 generate slightly better code.
3813
dae0cd48
PE
3814 * ftfont.c: Distingish more carefully between FcChar8 and char.
3815 The previous code passed unsigned char * to a functions like
3816 strlen and xstrcasecmp that expect char *, which does not
3817 conform to the C standard.
3818 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3819 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3820 char * when the C standard requires it.
3821
76032d70
PE
3822 * keyboard.c (read_char): Remove unused var.
3823
eb3f1cc8
PE
3824 * eval.c: Port to Windows vsnprintf (Bug#8435).
3825 Include <limits.h>.
3826 (SIZE_MAX): Define if the headers do not.
3827 (verror): Do not give up if vsnprintf returns a negative count.
3828 Instead, grow the buffer. This ports to Windows vsnprintf, which
3829 does not conform to C99. Problem reported by Eli Zaretskii.
3830 Also, simplify the allocation scheme, by avoiding the need for
3831 calling realloc, and removing the ALLOCATED variable.
3832
70476b54
PE
3833 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3834
12020a9e
PE
3835 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3836 But keep the doprint source code for now, as we might revamp it
3837 and use it again (Bug#8435).
ea6c7ae6
PE
3838 * lisp.h (doprnt): Remove.
3839 * Makefile.in (base_obj): Remove doprnt.o.
3840 * deps.mk (doprnt.o): Remove.
3841
5fdb398c
PE
3842 error: Print 32- and 64-bit integers portably (Bug#8435).
3843 Without this change, on typical 64-bit hosts error ("...%d...", N)
3844 was used to print both 32- and 64-bit integers N, which relied on
3845 undefined behavior.
3846 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3847 New macro.
3848 * lisp.h (error, verror): Mark as printf-like functions.
3849 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3850 Report overflow in size calculations when allocating printf buffer.
3851 Do not truncate output string at its first null byte.
3852 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3853 Truncate the output at a character boundary, since vsnprintf does not
3854 do that.
3855 * charset.c (check_iso_charset_parameter): Convert internal
3856 character to string before calling 'error', since %c now has the
3857 printf meaning.
3858 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3859 overflow when computing char to be passed to 'error'. Do not
3860 pass Lisp_Object to 'error'; pass the integer instead.
3861 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3862 formatted with plain %d.
3863
b189fa66
PE
3864 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3865
bff87ef0
PE
3866 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3867
7e2cac20
PE
3868 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3869
ce4d90b5
PE
3870 * xterm.c (x_catch_errors): Remove duplicate declaration.
3871
266c9547
PE
3872 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3873
79c49ad2
PE
3874 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3875
368f4090
JM
38762011-04-10 Jim Meyering <meyering@redhat.com>
3877
3878 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3879 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3880 return ssize_t not "int", and use size_t as the buffer length.
3881 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3882 * gnutls.h: Update declarations.
3883 * process.c (read_process_output): Use ssize_t, to match.
3884 (send_process): Likewise.
3885
a32d4040
CY
38862011-04-09 Chong Yidong <cyd@stupidchicken.com>
3887
3888 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3889
8546720e 38902011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3891
04f2d78b
CB
3892 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3893 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3894
8546720e
GM
3895 * xterm.c (handle_one_xevent):
3896 * xmenu.c (create_and_show_popup_menu):
3897 * xselect.c (x_decline_selection_request)
3898 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3899
0a2f5c1a 39002011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3901
3902 Fix some uses of `int' instead of EMACS_INT.
3903 * search.c (string_match_1, fast_string_match)
3904 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3905 (scan_buffer, find_next_newline_no_quit)
3906 (find_before_next_newline, search_command, Freplace_match)
3907 (Fmatch_data): Make some `int' variables be EMACS_INT.
3908
3909 * xdisp.c (display_count_lines): 3rd argument and return value now
3910 EMACS_INT. All callers changed.
3911 (pint2hrstr): Last argument is now EMACS_INT.
3912
3913 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3914 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3915 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3916 (decode_coding_utf_16, decode_coding_emacs_mule)
3917 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3918 (decode_coding_ccl, decode_coding_charset)
3919 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3920 (decode_coding_iso_2022, decode_coding_emacs_mule)
3921 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3922 <char_offset, last_offset>: Declare EMACS_INT.
3923 (encode_coding_utf_8, encode_coding_utf_16)
3924 (encode_coding_emacs_mule, encode_invocation_designation)
3925 (encode_designation_at_bol, encode_coding_iso_2022)
3926 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3927 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3928 Declare EMACS_INT.
3929 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3930 (encode_invocation_designation): Last argument P_NCHARS is now
3931 EMACS_INT.
3932 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3933 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3934
3935 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3936 All users changed.
3937
3938 * ccl.c (Fccl_execute_on_string): Declare some variables
3939 EMACS_INT.
3940
8546720e 39412011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3942
3943 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3944
4e19a977
CS
39452011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3946
3947 * process.c (Fformat_network_address): Doc fix.
3948
87302331
R
39492011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3950
3951 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3952
cbb59342
CY
39532011-04-08 Chong Yidong <cyd@stupidchicken.com>
3954
3955 * keyboard.c (read_char): Call Lisp function help-form-show,
3956 instead of using internal_with_output_to_temp_buffer.
3957 (Qhelp_form_show): New var.
e0d38eeb 3958 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3959
3960 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3961
3962 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3963
e67a13ab
CY
39642011-04-06 Chong Yidong <cyd@stupidchicken.com>
3965
04f2d78b
CB
3966 * process.c (Flist_processes): Remove to Lisp.
3967 (list_processes_1): Delete.
e67a13ab 3968
973f782d
EZ
39692011-04-06 Eli Zaretskii <eliz@gnu.org>
3970
7c106b1e
EZ
3971 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3972
973f782d
EZ
3973 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3974
41cf7d1a 39752011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3976
ca23cc88
PE
3977 Fix more problems found by GCC 4.6.0's static checks.
3978
f390e2d5
PE
3979 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3980
42eea0d0
PE
3981 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3982
b69769da 3983 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3984
f9541e84
PE
3985 * xdisp.c (vmessage): Mark as a printf-like function.
3986
13841b55
PE
3987 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3988
c136c10f
PE
3989 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3990
5e2d4a30
PE
3991 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3992 printf-like functions.
3993 (tiff_load): Add casts to remove these marks before passing them
3994 to system-supplied API.
3995
583f48b9
PE
3996 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3997
b25d760e
PE
3998 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3999 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4000 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4001 directly, rather than having caller test rule sign. This avoids
4002 some unnecessary tests.
4003 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4004 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4005 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4006
bc7b6697 4007 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4008 (xfont_open): Avoid unnecessary tests.
bc7b6697 4009
27ccc379
PE
4010 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4011
dcd5c89a
PE
4012 * composite.h, composite.c (composition_gstring_put_cache):
4013 Use EMACS_INT, not int, for length.
4014
b13a45c6
PE
4015 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4016 breaking out part of COMPOSITION_DECODE_RULE.
4017 (COMPOSITION_DECODE_RULE): Use it.
4018 * composite.c (get_composition_id): Remove unused local vars,
4019 by using the new macro.
4020
1e792e4d
PE
4021 * textprop.c (set_text_properties_1): Change while to do-while,
4022 since the condition is always true at first.
4023
dc6c6455 4024 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4025 (interval_deletion_adjustment): Return unsigned value.
4026 All uses changed.
dc6c6455 4027
aba7731a
PE
4028 * process.c (list_processes_1, create_pty, read_process_output):
4029 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4030 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4031 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4032 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4033 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4034
fdfc4bf3
PE
4035 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4036
fca8fe46 4037 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4038 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4039
06a0259a 4040 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4041 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4042 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4043
e7b9e80f
PE
4044 * print.c (print_error_message): Avoid int overflow.
4045
56201685
PE
4046 * font.c (font_list_entities): Redo for clarity,
4047 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4048
78834453 4049 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4050 (font_score): Avoid potential overflow in diff calculation.
78834453 4051
0bc0b309 4052 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4053 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4054
e610eaca
PE
4055 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4056
b895abce
PE
4057 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4058 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4059 can always succeed if overflow has undefined behavior.
4060
1f1d9321 4061 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4062 (wordify): Omit three unnecessary tests.
1f1d9321 4063
c59478bc
PE
4064 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4065 All callers changed. This avoids the need for an unused var.
4066
79b73827
PE
4067 * casefiddle.c (casify_region): Remove var that is set but not used.
4068
a4db5dfe
PE
4069 * dired.c (file_name_completion): Remove var that is set but not used.
4070
43aae36e
PE
4071 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4072
2a47c44d 4073 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4074 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4075
a37c69bf
PE
4076 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4077 Check for integer overflow on size calculations.
4078
328ab8e7
PE
4079 * buffer.c (Fprevious_overlay_change): Remove var that is set
4080 but not used.
4081
e5a2a5cb
PE
4082 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4083 Remove vars that are set but not used.
8d84a6eb 4084 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4085 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4086
a60e5f68
PE
4087 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4088
f661cb61 4089 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4090 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4091
f0397f5a
PE
4092 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4093 that are set but not used.
4094
8664db06 4095 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4096 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4097
6abdaa4a
PE
4098 * xselect.c (x_get_local_selection, x_handle_property_notify):
4099 Remove vars that are set but not used.
4100
0ce7538d 4101 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4102 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4103
9ae848fc
PE
4104 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4105 Remove var that is set but not used.
0b918413
PE
4106 (scroll_bar_windows_size): Now size_t, not int.
4107 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4108 Check for overflow.
9ae848fc 4109
a5a62657
PE
4110 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4111 (map_tty_color) [!defined MSDOS]: Likewise.
4112
5c5cdd39
PE
4113 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4114
66ebf983
PE
4115 * coding.c: Remove vars that are set but not used.
4116 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4117 All callers changed.
4118 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4119 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4120 (decode_coding_charset): Remove vars that are set but not used.
4121
1be4d761
PE
4122 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4123 that is set but not used.
4124
47553fa8
PE
4125 * print.c (print_object): Remove var that is set but not used.
4126
1f7196bf 4127 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4128 The gnulib version avoids calling malloc in the usual case,
4129 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4130 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4131 * filelock.c (current_lock_owner): Likewise.
4132 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4133 * sysdep.c: Include allocator.h, careadlinkat.h.
4134 (emacs_no_realloc_allocator): New static constant.
4135 (emacs_readlink): New function.
fdb61804
PE
4136 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4137 ../lib/careadlinkat.h.
d1fdcab7 4138
f84c17c7
SM
41392011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4140
4141 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4142 first non-nil return value).
4143
ef3862ad
JD
41442011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4145
4146 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4147 if not defined (Bug#8403).
4148
376a7006
JB
41492011-04-02 Juanma Barranquero <lekktu@gmail.com>
4150
4151 * xdisp.c (display_count_lines): Remove parameter `start',
4152 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4153 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4154 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4155 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4156 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4157 and thereabouts. All callers changed.
4158 (get_per_char_metric): Remove parameter `f', unused since
4159 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4160
6ca3801d
JM
41612011-04-02 Jim Meyering <meyering@redhat.com>
4162
4163 do not dereference NULL upon failed strdup
4164 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4165 (ns_get_family): Likewise.
4166
d8e2b5ba
JB
41672011-04-02 Juanma Barranquero <lekktu@gmail.com>
4168
4169 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4170
8c74fcbd
JD
41712011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4172
4173 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4174 later (Bug#8403).
4175
7200d79c
SM
41762011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4177
03408648 4178 Add lexical binding.
7200d79c 4179
03408648
SM
4180 * window.c (Ftemp_output_buffer_show): New fun.
4181 (Fsave_window_excursion):
4182 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4183
4184 * lread.c (lisp_file_lexically_bound_p): New function.
4185 (Fload): Bind Qlexical_binding.
4186 (readevalloop): Remove `evalfun' arg.
4187 Bind Qinternal_interpreter_environment.
4188 (Feval_buffer): Bind Qlexical_binding.
4189 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4190 Mark as dynamic.
4191 (syms_of_lread): Declare `lexical-binding'.
4192
4193 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4194
4195 * keyboard.c (eval_dyn): New fun.
4196 (menu_item_eval_property): Use it.
ca105506
SM
4197
4198 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4199
03408648
SM
4200 * fns.c (concat, mapcar1): Accept byte-code-functions.
4201
4202 * eval.c (Fsetq): Handle lexical vars.
4203 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4204 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4205 (FletX, Flet): Obey lexical binding.
4206 (Fcommandp): Handle closures.
4207 (Feval): New `lexical' arg.
4208 (eval_sub): New function extracted from Feval. Use it almost
4209 everywhere where Feval was used. Look up vars in lexical env.
4210 Handle closures.
4211 (Ffunctionp): Move from subr.el.
4212 (Ffuncall): Handle closures.
4213 (apply_lambda): Remove `eval_flags'.
4214 (funcall_lambda): Handle closures and new byte-code-functions.
4215 (Fspecial_variable_p): New function.
4216 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4217 but without exporting it to Lisp.
23aba0ea 4218
23aba0ea 4219 * doc.c (Fdocumentation, store_function_docstring):
03408648 4220 * data.c (Finteractive_form): Handle closures.
23aba0ea 4221
03408648
SM
4222 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4223 interactive spec.
ba83908c 4224
04f2d78b
CB
4225 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4226 New byte-codes.
03408648
SM
4227 (exec_byte_code): New function extracted from Fbyte_code to handle new
4228 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4229
03408648 4230 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4231
03408648 4232 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4233
e2abce01
JB
42342011-03-31 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * xdisp.c (redisplay_internal): Fix prototype.
4237
63696a73 42382011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4239
63696a73 4240 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4241 (try_scrolling): Use it when setting scroll_limit.
4242 Limit scrolling to 100 screen lines.
63696a73
EZ
4243 (redisplay_window): Even when falling back on "recentering",
4244 position point in the window according to scroll-conservatively,
4245 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4246
4247 (try_scrolling): When point is above the window, allow searching
4248 as far as scroll_max, or one screenful, to compute vertical
4249 distance from PT to the scroll margin position. This prevents
4250 try_scrolling from unnecessarily failing when
4251 scroll-conservatively is set to a value slightly larger than the
4252 window height. Clean up the case of PT below the margin at bottom
4253 of window: scroll_max can no longer be INT_MAX. When aggressive
4254 scrolling is in use, don't let point enter the opposite scroll
4255 margin as result of the scroll.
4256 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4257 threshold of 100 lines for never-recentering scrolling.
4258
e4cc2dfc
JB
42592011-03-31 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * dispextern.h (move_it_by_lines):
4262 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4263 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4264 (message_log_check_duplicate): Remove parameters `prev_bol' and
4265 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4266 (redisplay_internal): Remove parameter `preserve_echo_area',
4267 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4268
4269 * indent.c (Fvertical_motion):
4270 * window.c (window_scroll_pixel_based, Frecenter):
4271 Don't pass `need_y_p' to `move_it_by_lines'.
4272
1c470562
SM
42732011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4274
44f230aa
SM
4275 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4276 steal a few bits to be more compact.
4277 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4278 Remove unneeded casts.
4279
1c470562
SM
4280 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4281
888adce9
ZK
42822011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4283
4284 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4285 binding" message (bug#7967).
4286
f838ed7b
PE
42872011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4288
77861b95
PE
4289 Fix more problems found by GCC 4.6.0's static checks.
4290
de6dbc14
PE
4291 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4292 Remove unused local var.
4293
f838ed7b
PE
4294 * editfns.c (Fmessage_box): Remove unused local var.
4295
792c7b2b
PE
4296 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4297 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4298 Omit unused local vars.
c499e557 4299 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4300 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4301 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4302 Omit unused local var.
4303
ba0165e1
PE
4304 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4305 Don't assume string length fits in int.
32ad8845 4306 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4307 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4308
3c59b4c9
PE
4309 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4310 instead of alloca (Bug#8344).
4311
a3eed478 4312 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4313 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4314
eb4d412d
PE
4315 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4316
1658b401
PE
4317 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4318 concerns.
4319
4320 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4321
4322 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4323
9a2c6e05
PE
4324 * keyboard.c (syms_of_keyboard): Use the same style as later
4325 in this function when indexing through an array. This also
4326 works around GCC bug 48267.
4327
03d0a109
PE
4328 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4329
44f730c8
PE
4330 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4331
fe75f926
PE
4332 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4333 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4334
ffa8c828
PE
4335 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4336 This avoids undefined behavior on integer overflow, and is a bit
4337 more convenient anyway since it is compared to a size_t variable.
4338
c5101a77
PE
4339 Variadic C functions now count arguments with size_t, not int.
4340 This avoids an unnecessary limitation on 64-bit machines, which
4341 caused (substring ...) to crash on large vectors (Bug#8344).
4342 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4343 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4344 All variadic functions and their callers changed accordingly.
c5101a77
PE
4345 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4346 * data.c (arith_driver, float_arith_driver): Likewise.
4347 * editfns.c (general_insert_function): Likewise.
4348 * eval.c (struct backtrace.nargs, interactive_p)
4349 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4350 (funcall_lambda, mark_backtrace): Likewise.
4351 * fns.c (concat): Likewise.
4352 * frame.c (x_set_frame_parameters): Likewise.
4353 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4354 0 if not found, not -1. All callers changed.
4355
dd3f25f7
PE
4356 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4357 (stack_copy_size): Now size_t, not int.
4358 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4359
461c2ab9
JB
43602011-03-28 Juanma Barranquero <lekktu@gmail.com>
4361
4362 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4363 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4364 All callers changed.
4365
4366 * lisp.h (multibyte_char_to_unibyte):
4367 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4368 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4369 * character.h (CHAR_TO_BYTE8):
4370 * cmds.c (internal_self_insert):
4371 * editfns.c (general_insert_function):
4372 * keymap.c (push_key_description):
4373 * search.c (Freplace_match):
4374 * xdisp.c (message_dolog, set_message_1): All callers changed.
4375
f6d62986
SM
43762011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4377
4378 * keyboard.c (safe_run_hook_funcall): New function.
4379 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4380 don't set the hook to nil, but remove the offending function instead.
4381 (Qcommand_hook_internal): Remove, unused.
4382 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4383 Vcommand_hook_internal.
4384
4385 * eval.c (enum run_hooks_condition): Remove.
4386 (funcall_nil, funcall_not): New functions.
4387 (run_hook_with_args): Call each function through a `funcall' argument.
4388 Remove `cond' argument, now redundant.
4389 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4390 (Frun_hook_with_args_until_failure): Adjust accordingly.
4391 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4392
1db5b1ad
JB
43932011-03-28 Juanma Barranquero <lekktu@gmail.com>
4394
4395 * dispextern.h (string_buffer_position): Remove declaration.
4396
4397 * print.c (strout): Remove parameter `multibyte', unused since
4398 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4399
4400 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4401 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4402 All callers changed.
4403
4404 * w32.c (_wsa_errlist): Use braces for struct initializers.
4405
4406 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4407 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4408 All callers changed.
4409 (string_buffer_position): Likewise. Also, make static (it's never
4410 used outside xdisp.c).
4411 (cursor_row_p): Remove parameter `w', unused since
4412 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4413 (decode_mode_spec): Remove parameter `precision', introduced during
4414 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4415 All callers changed.
4416
5ffb62aa
JD
44172011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4418
4419 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4420
461c2ab9 44212011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4422
4423 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4424 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4425 (ns_update_auto_hide_menu_bar): New functions.
4426 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4427 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4428 ns_constrain_all_frames.
4429 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4430 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4431
5c380ffb
JD
44322011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4433
4434 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4435
9af30bdf
GM
44362011-03-27 Glenn Morris <rgm@gnu.org>
4437
4438 * syssignal.h: Replace RETSIGTYPE with void.
4439 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4440 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4441 Replace SIGTYPE with void everywhere.
4442 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4443 * s/template.h (SIGTYPE): Remove commented out definition.
4444
e2abce01
JB
44452011-03-26 Eli Zaretskii <eliz@gnu.org>
4446
4447 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4448 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4449
f868cd8a
JB
44502011-03-26 Juanma Barranquero <lekktu@gmail.com>
4451
59eb0929
JB
4452 * w32.c (read_unc_volume): Use parameter `henum', instead of
4453 global variable `wget_enum_handle'.
4454
4455 * keymap.c (describe_vector): Remove parameters `indices' and
4456 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4457 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4458
f868cd8a
JB
4459 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4460
4461 * keyboard.c (timer_check): Remove parameter `do_it_now',
4462 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4463 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4464 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4465
4466 * keyboard.c (read_char):
4467 * w32menu.c (w32_menu_display_help):
4468 * xmenu.c (show_help_event, menu_help_callback):
4469 Adjust calls to `show_help_echo'.
4470
4471 * gtkutil.c (xg_maybe_add_timer):
4472 * keyboard.c (readable_events):
4473 * process.c (wait_reading_process_output):
4474 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4475
4476 * insdel.c (adjust_markers_gap_motion):
4477 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4478 (gap_left, gap_right): Don't call it.
4479
2ecf6fdb
CY
44802011-03-25 Chong Yidong <cyd@stupidchicken.com>
4481
4482 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4483 incurred during fontification.
4484
6b1f9ba4
JB
44852011-03-25 Juanma Barranquero <lekktu@gmail.com>
4486
4487 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4488 (DEFVAR_PER_BUFFER): Don't pass it.
4489
4490 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4491 (scrolling_window): Don't pass it.
4492
0f4a96b5
JB
44932011-03-25 Juanma Barranquero <lekktu@gmail.com>
4494
4495 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4496
4497 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4498 and `suffix'.
4499 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4500 of variables specific to SELinux and computation of `encoded_absname'.
4501
4502 * image.c (XPutPixel): Remove unused variable `height'.
4503
4504 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4505
4506 * unexw32.c (get_section_info): Remove unused variable `section'.
4507
4508 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4509 (system_process_attributes): Remove unused variable `sess'.
4510 (sys_read): Remove unused variable `err'.
4511
4512 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4513 (w32_wnd_proc): Remove unused variable `isdead'.
4514 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4515 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4516 (x_create_tip_frame): Remove unused variable `tem'.
4517
4518 * w32inevt.c (w32_console_read_socket):
4519 Remove unused variable `no_events'.
4520
4521 * w32term.c (x_draw_composite_glyph_string_foreground):
4522 Remove unused variable `width'.
4523
1149507c
JB
45242011-03-24 Juanma Barranquero <lekktu@gmail.com>
4525
4526 * w32term.c (x_set_glyph_string_clipping):
4527 Don't pass uninitialized region to CombineRgn.
4528
9c88f339
JB
45292011-03-23 Juanma Barranquero <lekktu@gmail.com>
4530
4531 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4532 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4533 (Fx_close_connection): Remove unused variable `i'.
4534
4535 * w32font.c (w32font_draw): Return number of glyphs.
4536 (w32font_open_internal): Remove unused variable `i'.
4537 (w32font_driver): Add missing initializer.
4538
4539 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4540 (fill_in_menu): Remove unused variable `items_added'.
4541
4542 * w32term.c (last_mouse_press_frame): Remove static global variable.
4543 (w32_clip_to_row): Remove unused variable `f'.
4544 (x_delete_terminal): Remove unused variable `i'.
4545
4546 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4547 (NOTHING): Remove unused static global variable.
4548 (uniscribe_check_otf): Remove unused variable `table'.
4549 (uniscribe_font_driver): Add missing initializers.
4550
dee091a3
JD
45512011-03-23 Julien Danjou <julien@danjou.info>
4552
4553 * term.c (Fsuspend_tty, Fresume_tty):
4554 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4555 * window.c (temp_output_buffer_show):
4556 * insdel.c (signal_before_change):
4557 * frame.c (Fhandle_switch_frame):
4558 * fileio.c (Fdo_auto_save):
4559 * emacs.c (Fkill_emacs):
4560 * editfns.c (save_excursion_restore):
4561 * cmds.c (internal_self_insert):
4562 * callint.c (Fcall_interactively):
4563 * buffer.c (Fkill_all_local_variables):
4564 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4565 Use Frun_hooks.
0f4a96b5 4566 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4567 unconditionnaly since it does the check itself.
4568
2c520ab5 45692011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4570
c9c49752
PE
4571 Fix more problems found by GCC 4.5.2's static checks.
4572
8abc3f12
PE
4573 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4574 the first time through the loop, since we know p0 < p1 then.
4575 This also avoids a gcc -Wstrict-overflow warning.
4576
a2d26660
PE
4577 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4578 leading to a memory leak, possible in functions like
4579 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4580 of objects (Bug#8318).
a2d26660 4581
916c72e9
PE
4582 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4583 that could (at least in theory) be that large.
4584
19ab8a18
PE
4585 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4586 This is less likely to overflow, and avoids undefined behavior if
4587 overflow does occur. All callers changed. Use strtoul to scan
4588 for the unsigned long integer.
b7cbbd6f
PE
4589 (pint2hrstr): Simplify and tune code slightly.
4590 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4591
f0641eff
PE
4592 * scroll.c (do_scrolling): Work around GCC bug 48228.
4593 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4594
7f650bb9
PE
4595 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4596 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4597 (validate_x_resource_name): Simplify count usage.
4598 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4599
37dd57d1
PE
4600 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4601 fail (Bug#8306).
81e56e61 4602
699979fc 4603 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4604
401bf9b4
PE
4605 * process.c (Fmake_network_process): Use socklen_t, not int,
4606 where POSIX says socklen_t is required in portable programs.
4607 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4608 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4609 (Fmake_network_process, server_accept_connection):
4610 (wait_reading_process_output, read_process_output):
4611 Likewise.
4612
b93aacde
PE
4613 * process.c: Rename or move locals to avoid shadowing.
4614 (list_processes_1, Fmake_network_process):
4615 (read_process_output_error_handler, exec_sentinel_error_handler):
4616 Rename or move locals.
4dc343ee 4617 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4618 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4619 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4620 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4621 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4622
af8a867c 4623 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4624 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4625 Include tparam.h instead, since it declares them.
af8a867c
PE
4626 * cm.h (PC): Remove extern decl; tparam.h now does this.
4627 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4628 * terminfo.c: Include tparam.h, to check interfaces.
4629 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4630 (tparam): Adjust signature to match interface in tparam.h;
4631 this removes some undefined behavior. Check that outstring and len
4632 are zero, which they always are with Emacs.
4633 * tparam.h (PC, BC, UP): New extern decls.
4634
0248044d 4635 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4636 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4637
8ff096c1 4638 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4639 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4640 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4641 (ftfont_list): Remove unused local.
49eaafba
PE
4642 (get_adstyle_property, ftfont_pattern_entity):
4643 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4644 Rename locals to avoid shadowing.
8ff096c1 4645
e2be39f6
PE
4646 * xfont.c (xfont_list_family): Mark var as initialized.
4647
c9735e30
PE
4648 * xml.c (make_dom): Now static.
4649
8f5201ae
PE
4650 * composite.c (composition_compute_stop_pos): Rename local to
4651 avoid shadowing.
b246f932
PE
4652 (composition_reseat_it): Remove unused locals.
4653 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4654 (composition_update_it): Mark var as initialized.
11b61122
PE
4655 (find_automatic_composition): Mark vars as initialized,
4656 with a FIXME (Bug#8290).
8f5201ae 4657
760fbc2c
PE
4658 character.h: Rename locals to avoid shadowing.
4659 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4660 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4661 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4662 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4663 to avoid shadowing.
4664
ff08eb85
PE
4665 * textprop.c (property_change_between_p): Remove; unused.
4666
fc7bf025
PE
4667 * intervals.c (interval_start_pos): Now static.
4668
235d7abc
PE
4669 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4670
44f230aa
SM
4671 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4672 Rename locals to avoid shadowing.
3e7d6594 4673
50060332
PE
4674 * sound.c (wav_play, au_play, Fplay_sound_internal):
4675 Fix pointer signedness.
d01f234b 4676 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4677 (wav_play): Initialize a variable to 0, to prevent undefined
4678 behavior (Bug#8278).
50060332 4679
c4fc4e30
PE
4680 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4681
918436ed
PE
4682 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4683
c939f91b
PE
4684 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4685 clobbering (Bug#8298).
b9c7f648
PE
4686 * sysdep.c (sys_subshell): Likewise.
4687 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4688
6bd8c144
PE
4689 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4690 This should get cleaned up, so that child_setup has the
4691 same signature on all platforms.
4692
7710357c 4693 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4694 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4695
c59da222
CY
46962011-03-22 Chong Yidong <cyd@stupidchicken.com>
4697
4698 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4699 not to be necessary, and produces flickering.
4700
66b87493
GM
47012011-03-20 Glenn Morris <rgm@gnu.org>
4702
4703 * config.in: Remove file.
4704
45b6f6d5
JB
47052011-03-20 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4708 are now in src/globals.h.
4709 (syms_of_minibuf): Remove spurious & from previous change.
4710
3ec03f7e
LL
47112011-03-20 Leo <sdl.web@gmail.com>
4712
4713 * minibuf.c (completing-read-function): New variable.
4714 (completing-read-default): Rename from completing-read.
4715 (completing-read): Call completing-read-function.
4716
b14e3e21
CY
47172011-03-19 Juanma Barranquero <lekktu@gmail.com>
4718
4719 * xfaces.c (Fx_load_color_file):
4720 Read color file from absolute filename (bug#8250).
4721
f2b726e6
JB
47222011-03-19 Juanma Barranquero <lekktu@gmail.com>
4723
4724 * makefile.w32-in: Update dependencies.
4725
09f6ff02
EZ
47262011-03-17 Eli Zaretskii <eliz@gnu.org>
4727
4728 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4729
29a6015a
PE
47302011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4731
a3a6c54e
PE
4732 Fix more problems found by GCC 4.5.2's static checks.
4733
b766f867
PE
4734 * process.c (make_serial_process_unwind, send_process_trap):
4735 (sigchld_handler): Now static.
4736
be02381c
PE
4737 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4738 That way, the code declares only the vars that it needs.
4739 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4740 * s/cygwin.h (PTY_ITERATION): Likewise.
4741 * s/darwin.h (PTY_ITERATION): Likewise.
4742 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4743
57048744
PE
4744 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4745 * process.c (allocate_pty): Don't declare stb unless it's needed.
4746
7914961c 4747 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4748 (CONSTANTLIM): Remove; unused.
4749 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4750 Define only if needed.
7914961c 4751
b3967b18
PE
4752 * unexelf.c (unexec): Name an expression,
4753 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4754 Use a different way to cause a compilation error if anyone uses
4755 n rather than nn, a way that does not involve shadowing.
73366a00 4756 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4757
29a6015a
PE
4758 * deps.mk (unexalpha.o): Remove; unused.
4759
43cfc33e 4760 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4761 * unexec.h: New file.
ce701a33
PE
4762 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4763 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4764 Depend on unexec.h.
4765 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4766 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4767 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4768 Change as necessary to match prototype in unexec.h.
ce701a33 4769
01f44d5a
PE
4770 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4771 shadowing.
4f63c6bb 4772 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4773
a6670b0b
PE
4774 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4775 Rename locals to avoid shadowing.
4776
cef2010d 4777 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4778 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4779
d4d7173a
PE
4780 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4781
f08b802a
PE
4782 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4783 warning when compiling print.c.
4784
3ddb0639
PE
4785 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4786 instead of using an uninitialized var.
5ad03b97 4787 (font_sort_entities): Mark var as initialized.
3ddb0639 4788
170a2692
PE
4789 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4790
e663c700
PE
4791 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4792 pointers to constants.
89bc529a 4793 (font_parse_fcname): Remove unused vars.
7b81e2d0 4794 (font_delete_unmatched): Now static.
ea838e10 4795 (font_get_spec): Remove; unused.
13a547c6
PE
4796 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4797 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4798 Rename or move locals to avoid shadowing.
e663c700 4799
2a80c887 4800 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4801 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4802
1384fa33 4803 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4804 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4805
8b2c52e9
PE
4806 * alloc.c (mark_backtrace): Move decl from here ...
4807 * lisp.h: ... to here, so that it can be checked.
4808
475545b5 4809 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4810 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4811 (lisp_indirect_variable): Name an expression,
4812 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4813 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4814
b1349114 4815 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4816 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4817 Use const pointer when appropriate.
b1349114 4818
a2928364
PE
4819 * lisp.h (get_system_name, get_operating_system_release):
4820 Move decls here, to check interfaces.
4821 * process.c (get_operating_system_release): Move decl to lisp.h.
4822 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4823 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4824 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4825 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4826 (Fformat_time_string, Fencode_time, Finsert_char):
4827 (Ftranslate_region_internal, Fformat):
4828 Rename or remove local vars to avoid shadowing.
9710023e 4829 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4830
a415e694
PE
4831 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4832 avoid shadowing.
4833
8ef4622d
PE
4834 * lisp.h (eassert): Check that the argument compiles, even if
4835 ENABLE_CHECKING is not defined.
4836
946f9a5b
PE
4837 * data.c (Findirect_variable): Name an expression, to avoid
4838 gcc -Wbad-function-cast warning.
112396d6 4839 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4840 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4841 (Fmake_variable_buffer_local, Fmake_local_variable):
4842 Mark variables as initialized.
52746918 4843 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4844
e5aab7e7 4845 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4846 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4847 Rename locals to avoid shadowing.
dff45157
PE
4848 (mark_stack): Move local variables into the #ifdef region where
4849 they're used.
7bc26fdb
PE
4850 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4851 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4852 needed otherwise.
4853 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4854 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4855 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4856
e5aab7e7
PE
4857 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4858 avoids undefined behavior in theory.
4859
4da60324
PE
4860 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4861
88043301
PE
4862 Use functions, not macros, for up- and down-casing (Bug#8254).
4863 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4864 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4865 to use the following functions instead of these macros.
4866 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4867 EMACS_INT, since callers assume the returned value fits in int.
4868 (upcase1): Likewise, for UPCASE_TABLE.
4869 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4870 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4871 the race-condition problem in the old DOWNCASE.
88043301 4872
19ed5445
PE
4873 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4874 Rename locals to avoid shadowing.
4875 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4876 (regex_compile, re_search_2, re_match_2_internal):
4877 Remove unused local vars.
952db0d7
PE
4878 (FREE_VAR): Rewrite so as not to use empty "else",
4879 which gcc can warn about.
da053e48 4880 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4881 (RETALLOC_IF): Define only if needed.
4882 (WORDCHAR_P): Likewise. This one is never needed, but is used
4883 only in a comment talking about a compiler bug, so put inside
4884 the #if 0 of that comment.
4885 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4886 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4887 Remove; unused.
19ed5445 4888
1f3561e4 4889 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4890 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4891 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4892
ded6f8f7
PE
4893 * search.c (simple_search): Remove unused var.
4894
dbd37a95
PE
4895 * dired.c (compile_pattern): Move decl from here ...
4896 * lisp.h: ... to here, so that it can be checked.
4897 (struct re_registers): New forward decl.
4898
7e47afad
PE
4899 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4900
85f24f61
PE
4901 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4902 All uses changed.
4903 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4904 Rename locals to avoid shadowing.
5671df8f 4905 (Fvertical_motion): Mark locals as initialized.
85f24f61 4906
181aa2be 4907 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4908 (casify_region): Mark local as initialized.
181aa2be 4909
930d429c
PE
4910 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4911
7082eac6
PE
4912 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4913 New macros, so that the caller can use some names other than
4914 gcpro1, gcpro2, etc.
4915 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4916 of the new macros.
4917 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4918 argument, for consistency with GCPRO2_VAR, etc: it is now the
4919 prefix of the variable, not the variable itself. All uses
4920 changed.
38b2c076
PE
4921 * dired.c (directory_files_internal, file_name_completion):
4922 Rename locals to avoid shadowing.
4923
15206ed9
PE
4924 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4925 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4926 dired.c's scmp function, had undefined behavior.
4927 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4928 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4929 * buffer.h: ... to here, because these macros use current_buffer,
4930 and the new implementation with inline functions needs to have
4931 current_buffer in scope now, rather than later when the macros
4932 are used.
4933 (downcase, upcase1): New static inline functions.
4934 (DOWNCASE, UPCASE1): Reimplement using these functions.
4935 This avoids undefined behavior in expressions like
4936 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4937 from race conditions in accessing the global variables
4938 case_temp1 and case_temp2.
4939 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4940 * lisp.h (case_temp1, case_temp2): Remove their decls.
4941 * character.h (ASCII_CHAR_P): Move from here ...
4942 * lisp.h: ... to here, so that the inline functions mentioned
4943 above can use them.
4944
4a6bea26
PE
4945 * dired.c (directory_files_internal_unwind): Now static.
4946
f14b7e14
PE
4947 * fileio.c (file_name_as_directory, directory_file_name):
4948 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4949 Now static.
2893f146
PE
4950 (file_name_as_directory): Use const pointers when appropriate.
4951 (Fexpand_file_name): Likewise. In particular, newdir might
4952 point at constant storage, so make it a const pointer.
fd4ead52 4953 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4954 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4955 signedness issues.
f839df0c
PE
4956 (Fset_file_times, Finsert_file_contents, auto_save_error):
4957 Rename locals to avoid shadowing.
f14b7e14 4958
5716756e 4959 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4960 (Ftry_completion, Fall_completions): Rename or remove locals
4961 to avoid shadowing.
5716756e 4962
b4c3046a
PE
4963 * marker.c (bytepos_to_charpos): Remove; unused.
4964
b45db522
PE
4965 * lisp.h (verify_bytepos, count_markers): New decls,
4966 so that gcc does not warn that these functions aren't declared.
4967
85876d07
PE
4968 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4969 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4970 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4971 (copy_text): Remove unused local var.
85876d07 4972
03d78a21 4973 * filelock.c (within_one_second): Now static.
b3dd38ab 4974 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4975
5df8f01b
PE
4976 * buffer.c (fix_overlays_before): Mark locals as initialized.
4977 (fix_start_end_in_overlays): Likewise. This function should be
4978 simplified by using pointers-to-pointers, but that's a different
4979 matter.
b1d876f1 4980 (switch_to_buffer_1): Now static.
8f54f30a
PE
4981 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4982 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4983
a70072c9 4984 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4985 Fix pointer signedness issue.
edced198
PE
4986 (sys_subshell): Mark local as volatile if checking for lint,
4987 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4988 (MAXPATHLEN): Define only if needed.
a70072c9 4989
a0977c44
PE
4990 * process.c (serial_open, serial_configure): Move decls from here ...
4991 * systty.h: ... to here, so that they can be checked.
4992
a884fdcc
PE
4993 * fns.c (get_random, seed_random): Move extern decls from here ...
4994 * lisp.h: ... to here, so that they can be checked.
4995
604efe86 4996 * sysdep.c (reset_io): Now static.
b8950c94 4997 (wait_for_termination_signal): Remove; unused.
604efe86 4998
38fc62d9
PE
4999 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5000 (copy_keymap_item, append_key, push_text_char_description):
5001 Now static.
1004a21a 5002 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5003 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5004 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5005 (describe_map_tree):
5006 Rename locals to avoid shadowing.
38fc62d9 5007
2f2650da
PE
5008 * keyboard.c: Declare functions static if they are not used elsewhere.
5009 (echo_char, echo_dash, cmd_error, top_level_2):
5010 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5011 (read_char, kbd_buffer_get_event, make_lispy_position):
5012 (make_lispy_event, make_lispy_movement, apply_modifiers):
5013 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5014 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5015 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5016 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5017 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5018
a053e86c 5019 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5020 (mark_kboards): Move decl here ...
5021 * alloc.c (mark_kboards): ... from here.
a053e86c 5022
4752793e
PE
5023 * lisp.h (force_auto_save_soon): New decl.
5024
74f10ca7 5025 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5026 (DEFINE_DUMMY_FUNCTION): New macro.
5027 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5028 Use it.
c03cd23f
PE
5029 (main): Add casts to avoid warnings
5030 if GCC considers string literals to be constants.
74f10ca7 5031
022e70d4
PE
5032 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5033
59d6fe83
PE
5034 * dbusbind.c: Pointer signedness fixes.
5035 (xd_signature, xd_append_arg, xd_initialize):
5036 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5037 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5038 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5039 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5040
78320123
PE
5041 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5042 if GCC considers string literals to be constants.
49cebcca 5043 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5044
35ac2a97
SM
50452011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5046
fb103ca9
SM
5047 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5048 (print_preprocess, print_object): New macro to fix last change.
5049
35ac2a97
SM
5050 * print.c (print_preprocess): Don't forget font objects.
5051
62973b41
JB
50522011-03-16 Juanma Barranquero <lekktu@gmail.com>
5053
5054 * emacs.c (USAGE3): Doc fixes.
5055
0e48bb22
AS
50562011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5057
5058 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5059 structure.
5060
7684e57b
JB
50612011-03-14 Juanma Barranquero <lekktu@gmail.com>
5062
5063 * lisp.h (VWindow_system, Qfile_name_history):
5064 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5065 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5066 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5067
5068 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5069 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5070
5071 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5072 * w32console.c (detect_input_pending, read_input_pending)
5073 (encode_terminal_code):
5074 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5075 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5076 (w32_system_caret_y, Qfile_name_history):
5077 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5078 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5079 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5080 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5081 * w32proc.c (Qlocal, report_file_error):
5082 * w32term.c (Vwindow_system, updating_frame):
5083 * w32uniscribe.c (initialized, uniscribe_font_driver):
5084 Remove unneeded extern declarations.
5085
2aa46d6c
CY
50862011-03-14 Chong Yidong <cyd@stupidchicken.com>
5087
c96bbc66 5088 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5089
cffc6f3b
CY
50902011-03-13 Chong Yidong <cyd@stupidchicken.com>
5091
5092 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5093 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5094 These macros can no longer be used for assignment.
5095
44f230aa
SM
5096 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5097 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5098 (record_buffer_markers, fetch_buffer_markers): New functions for
5099 recording and fetching special buffer markers.
5100 (set_buffer_internal_1, set_buffer_temp): Use them.
5101
5102 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5103
5104 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5105
5106 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5107 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5108
5109 * xdisp.c (hscroll_window_tree):
5110 (reconsider_clip_changes): Use PT instead of BUF_PT.
5111
d251f04b
EZ
51122011-03-13 Eli Zaretskii <eliz@gnu.org>
5113
5114 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5115 $(EMACS_ROOT)/lib/intprops.h.
5116
f0c77cd1
PE
51172011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5118
3eca4629
PE
5119 Fix more problems found by GCC 4.5.2's static checks.
5120
7c86ee98
PE
5121 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5122 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5123 (xg_free_frame_widgets): Make it clear that a local variable is
5124 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5125 (gdk_window_get_screen): Make it clear that this macro is needed
5126 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5127 (int_gtk_range_get_value): New function, which avoids a diagnostic
5128 from gcc -Wbad-function-cast.
5129 (xg_set_toolkit_scroll_bar_thumb): Use it.
5130 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5131 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5132 (get_utf8_string, xg_get_file_with_chooser):
5133 Rename locals to avoid shadowing.
5134 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5135
41729b81
PE
5136 * xgselect.c (xg_select): Remove unused var.
5137
f0c77cd1
PE
5138 * image.c (four_corners_best): Mark locals as initialized.
5139 (gif_load): Initialize transparent_p to zero (Bug#8238).
5140 Mark another local as initialized.
ec6cf4c6 5141 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5142
ce0ad53d 5143 * image.c (clear_image_cache): Now static.
d5d5a617 5144 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5145 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5146 (x_edge_detection): Remove unnecessary cast that
5147 gcc -Wbad-function-cast diagnoses.
2037898d 5148 (gif_load): Fix pointer signedness.
6ae141d6
PE
5149 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5150 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5151
33383987 51522011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5153
d32df629
PE
5154 Improve quality of tests for time stamp overflow.
5155 For example, without this patch (encode-time 0 0 0 1 1
5156 1152921504606846976) returns the obviously-bogus value (-948597
5157 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5158 reports time overflow. See
5159 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5160 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5161 * editfns.c: Include limits.h and intprops.h.
5162 (TIME_T_MIN, TIME_T_MAX): New macros.
5163 (time_overflow): Move earlier, to before first use.
5164 (hi_time, lo_time): New functions, for an accurate test for
5165 out-of-range times.
5166 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5167 (Fget_internal_run_time): Don't assume time_t fits in int.
5168 (make_time): Use list2 instead of Fcons twice.
5169 (Fdecode_time): More accurate test for out-of-range times.
5170 (check_tm_member): New function.
5171 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5172 (lisp_time_argument): Don't rely on undefined left-shift and
5173 right-shift behavior when checking for time stamp overflow.
8be6f318 5174
fe31d94c
PE
5175 * editfns.c (time_overflow): New function, refactoring common code.
5176 (Fformat_time_string, Fdecode_time, Fencode_time):
5177 (Fcurrent_time_string): Use it.
5178
8be6f318
PE
5179 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5180 * dired.c (make_time): Move to ...
5181 * editfns.c (make_time): ... here.
5182 * systime.h: Note the move.
5183
09d9db2c 51842011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5185
126bc0dc
YM
5186 * fringe.c (update_window_fringes): Remove unused variables.
5187
c47cbdfd
YM
5188 * unexmacosx.c (copy_data_segment): Also copy __got section.
5189 (Bug#8223)
5190
7ac80be9
EZ
51912011-03-12 Eli Zaretskii <eliz@gnu.org>
5192
c96bbc66 5193 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5194 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5195 Constify `char *' arguments and their references according to
5196 prototypes in tparam.h.
5197
ecb0f94d 5198 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5199
7ac80be9
EZ
5200 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5201 Adapt all references accordingly.
5202
5203 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5204
ef1fd07e
TT
52052011-03-11 Tom Tromey <tromey@redhat.com>
5206
5207 * buffer.c (syms_of_buffer): Remove obsolete comment.
5208
7ef4b50c
EZ
52092011-03-11 Eli Zaretskii <eliz@gnu.org>
5210
5211 * termhooks.h (encode_terminal_code): Declare prototype.
5212
5213 * msdos.c (encode_terminal_code): Don't declare prototype.
5214
5215 * term.c (encode_terminal_code): Now external again, used by
5216 w32console.c and msdos.c.
5217
44f230aa
SM
5218 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5219 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5220
4b1ec863 52212011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5222
1714f52b 5223 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5224
4b1ec863
PE
5225 * fringe.c (update_window_fringes): Mark locals as initialized
5226 (Bug#8227).
5227 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5228
524c7aa6
PE
5229 * alloc.c (mark_fringe_data): Move decl from here ...
5230 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5231 to check its interface.
5232 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5233
a5c0af81 5234 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5235 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5236 (fontset_font): Mark local as initialized.
a9a06e0b 5237 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5238
b4716021
PE
5239 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5240
811e9bac 5241 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5242 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5243 (x_own_selection, Fx_disown_selection_internal): Rename locals
5244 to avoid shadowing.
5245 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5246
7e3ab302
PE
5247 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5248 so that the caller can use some name other than gcpro1.
5249 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5250 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5251 (Fx_backspace_delete_keys_p):
5252 Use them to avoid shadowing, and rename vars to avoid shadowing.
5253 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5254 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5255 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5256 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5257 Remove unused locals.
7e3ab302
PE
5258 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5259 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5260 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5261 macros.
f78faa98 5262
e2b13473
PE
5263 * xterm.h (x_mouse_leave): New decl.
5264
77f23912
PE
5265 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5266 Remove unused functions.
cdf4ba58
PE
5267 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5268 (x_calc_absolute_position): Now static.
7411c686 5269 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5270 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5271 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5272 unless they are used.
38d0b34a
PE
5273 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5274 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5275 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5276 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5277 (x_error_catcher, x_connection_closed, x_error_handler):
5278 (x_error_quitter, xembed_send_message, x_iconify_frame):
5279 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5280 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5281 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5282
44f230aa
SM
5283 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5284 Rename or move locals to avoid shadowing.
6b463e58 5285 (tty_defined_color, merge_face_heights): Now static.
5967d051 5286 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5287 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5288 does not deduce is never used uninitialized.
73719eba
PE
5289 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5290 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5291
426994c3 5292 * terminal.c (store_terminal_param): Now static.
5489860b 5293
032f1620 5294 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5295 (set_frame_menubar): Remove unused local.
d4323972 5296 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5297 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5298 since they might point to immutable storage.
281585b0
PE
5299 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5300 since it's unused otherwise.
032f1620 5301
367c19e5 5302 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5303 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5304 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5305 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5306 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5307 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5308 does not deduce are never used uninitialized.
70739cbe 5309
07b48fa9
PE
5310 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5311
8868a238 5312 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5313 * window.c (window_loop, size_window):
5314 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5315
7e5cf297 5316 * window.c (display_buffer): Now static.
d6550a9f
PE
5317 (size_window): Mark variables that gcc -Wuninitialized
5318 does not deduce are never used uninitialized.
a586633d
PE
5319 * window.h (check_all_windows): New decl, to forestall
5320 gcc -Wmissing-prototypes diagnostic.
5b555da1 5321 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5322
f6095868
PE
5323 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5324 shadowing.
5325 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5326 Include <limits.h>.
5327 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5328 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5329 (load_charset_map): Mark variables that gcc -Wuninitialized
5330 does not deduce are never used uninitialized.
53df7c11 5331 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5332
f38b440c
PE
5333 * coding.c (coding_set_source, coding_set_destination):
5334 Use "else { /* comment */ }" rather than "else /* comment */;"
5335 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5336 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5337 a block, when the outer 'i' will do.
5338 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5339 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5340 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5341 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5342 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5343 Rename locals to avoid shadowing.
5344 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5345 * coding.c (emacs_mule_char, encode_invocation_designation):
5346 Now static, since they're not used elsewhere.
413bb2db 5347 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5348 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5349 (decode_coding_emacs_mule): Mark variables that gcc
5350 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5351 (detect_coding_iso_2022): Initialize a local variable that might
5352 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5353 this initialization is needed. (Bug#8211)
5f58e762
PE
5354 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5355 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5356 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5357 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5358 Remove unused macros.
f38b440c 5359
232b38b9 5360 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5361 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5362 * character.c (string_count_byte8): Likewise.
232b38b9 5363
fb90da1b
PE
5364 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5365 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5366
fb93dbc2
PE
5367 * chartab.c (copy_sub_char_table): Now static, since it's not used
5368 elsewhere.
5c156ace
PE
5369 (sub_char_table_ref_and_range, char_table_ref_and_range):
5370 Rename locals to avoid shadowing.
bbcd0949 5371 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5372
7d3b3862 5373 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5374 (BIDI_BOB): Remove unused macro.
7d3b3862 5375
6be7d3da
PE
5376 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5377 deduce are never used uninitialized.
c2ed9c8b 5378 * term.c (encode_terminal_code): Likewise.
6be7d3da 5379
75f8807f 5380 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5381
50938595
PE
5382 * tparam.h: New file.
5383 * term.c, tparam.h: Include it.
5384 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5385 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5386 Move these decls to tparam.h, and make them agree with what
5387 is actually in tparam.c. The previous trick of using incompatible
5388 decls in different modules does not conform to the C standard.
5389 All callers of tparam changed to use tparam's actual API.
5390 * tparam.c (tparam1, tparam, tgoto):
5391 Use const pointers where appropriate.
5392
fbceeba2
PE
5393 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5394 * cm.h (struct cm): Likewise.
5395 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5396 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5397 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5398 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5399 (turn_on_face, init_tty): Likewise.
5400 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5401
7f3f1250
PE
5402 * term.c (term_mouse_position): Rename local to avoid shadowing.
5403
e6ca6543
PE
5404 * alloc.c (mark_ttys): Move decl from here ...
5405 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5406
c40f8d15
AS
54072011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5408
5409 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5410
cfe0661d
JB
54112011-03-09 Juanma Barranquero <lekktu@gmail.com>
5412
5413 * search.c (compile_pattern_1): Remove argument regp, unused since
5414 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5415 (compile_pattern): Don't pass it.
5416
0afb4571
J
54172011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5418
5419 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5420 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5421 for ! HAVE_GTK3.
5422 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5423
5424 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5425
5426 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5427 gdk_window_get_screen, gdk_window_get_geometry,
5428 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5429 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5430 (xg_get_pixbuf_from_pixmap): New function.
5431 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5432 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5433 Call xg_get_pixbuf_from_pixmap instead of
5434 gdk_pixbuf_get_from_drawable.
5435 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5436 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5437 (xg_check_special_colors): Use GtkStyleContext and its functions
5438 for HAVE_GTK3.
5439 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5440 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5441 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5442 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5443 Call gtk_widget_get_preferred_size.
0afb4571
J
5444 (xg_frame_resized): gdk_window_get_geometry only takes 5
5445 parameters.
44f230aa
SM
5446 (xg_win_to_widget, xg_event_is_for_menubar):
5447 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5448 (xg_set_widget_bg): New function.
5449 (delete_cb): New function.
895009e1 5450 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5451 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5452 (xg_set_background_color): Call xg_set_widget_bg.
5453 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5454 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5455 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5456 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5457 if ! HAVE_GTK3.
5458 (update_frame_tool_bar): Call gtk_widget_hide.
5459 (xg_initialize): Use GDK_KEY_g.
5460
5461 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5462 if ! HAVE_GTK3
5463 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5464
5465 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5466 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5467 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5468
1c2cc4ef
JB
54692011-03-08 Juanma Barranquero <lekktu@gmail.com>
5470
5471 * w32xfns.c (select_palette): Check success of RealizePalette against
5472 GDI_ERROR, not zero.
5473
33383987 5474See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5475
5476;; Local Variables:
5477;; coding: utf-8
aac0c6e3
MR
5478;; End:
5479
33383987 5480 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5481
5482 This file is part of GNU Emacs.
5483
5484 GNU Emacs is free software: you can redistribute it and/or modify
5485 it under the terms of the GNU General Public License as published by
5486 the Free Software Foundation, either version 3 of the License, or
5487 (at your option) any later version.
5488
5489 GNU Emacs is distributed in the hope that it will be useful,
5490 but WITHOUT ANY WARRANTY; without even the implied warranty of
5491 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5492 GNU General Public License for more details.
5493
5494 You should have received a copy of the GNU General Public License
5495 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.