Fix gdb-mi.el bug#9853, bug#9858, and bug#9878.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2b56b87e
JD
12011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2
3 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4
5 * xterm.c (handle_one_xevent): Only set async_visible and friends
6 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
8 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9
dbf31225
PE
102011-11-28 Paul Eggert <eggert@cs.ucla.edu>
11
12 Remove GCPRO-related macros that exist only to avoid shadowing locals.
13 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
14 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
15 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
16 All uses changed to use GCPRO1 etc.
17 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
18 Revert to old implementation (i.e., before 2011-03-11).
19
1305621b
YM
202011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
21
22 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
23 of scroll runs so as to avoid assigning disabled bogus rows and
24 unnecessary graphics copy operations.
25
8c9afb46
EZ
262011-11-27 Eli Zaretskii <eliz@gnu.org>
27
28 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
29 (snprintf) [_MSC_VER]: Redirect to _snprintf.
30 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
31 (malloc, free, realloc, calloc): Redirect to e_* only when
32 compiling Emacs.
33
34 * lisp.h (GCTYPEBITS): Move before first use.
35 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
36 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
37 this macro definition.
38
39 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
40 _MSC_VER.
41
54e9e3bf
JD
422011-11-27 Jan Djärv <jan.h.d@swipnet.se>
43
44 * gtkutil.c (xg_create_frame_widgets): Call
45 gtk_window_set_has_resize_grip (FALSE) if that function is
46 present with Gtk+ 2.0.
47
83aca1cb
PE
482011-11-26 Paul Eggert <eggert@cs.ucla.edu>
49
50 * fileio.c (Finsert_file_contents): Undo previous change; see
51 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
52
5b76caa4
PE
532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
54
55 Rename locals to avoid shadowing.
56 * fileio.c (Finsert_file_contents):
57 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
58 * process.c (wait_reading_process_output):
59 Rename inner 'proc' to 'p' to avoid shadowing.
60 Indent for consistency with usual Emacs style.
61
8c535114
EZ
622011-11-25 Eli Zaretskii <eliz@gnu.org>
63
64 * xdisp.c (redisplay_window): If cursor row is not fully visible
65 after recentering, and scroll-conservatively is set to a large
66 number, scroll window by a few more lines to make the cursor fully
67 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
68 (start_display): Don't move to the next line if the display should
69 start at a newline that is part of a display vector or an overlay
70 string. (Bug#10119)
8c535114 71
fa4fdb5c
JL
722011-11-24 Juri Linkov <juri@jurta.org>
73
74 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
75 after the `MagickPingImage' call. (Bug#10112)
76
90ec88df
CY
772011-11-23 Chong Yidong <cyd@gnu.org>
78
79 * window.c (Fcoordinates_in_window_p): Accept only live windows.
80
56e2e794
MR
812011-11-23 Martin Rudalics <rudalics@gmx.at>
82
83 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
84 making another buffer current. (Bug#10114)
85
b6e64c41
GM
862011-11-23 Glenn Morris <rgm@gnu.org>
87
88 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
89
6b21de18
CY
902011-11-23 Chong Yidong <cyd@gnu.org>
91
92 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
93 using it (Bug#5984).
94
b12cd789
EZ
952011-11-22 Eli Zaretskii <eliz@gnu.org>
96
97 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
98 and header-lines, as they don't have one computed for them.
99 (Bug#10098)
100
101 * .gdbinit (prow): Make displayed values more self-explaining.
102 Add row's hash code.
103
261b6fd4
LMI
1042011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
105
106 * process.c (wait_reading_process_output): Fix asynchrounous
107 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 108 (wait_reading_process_output): Add comment and URL.
261b6fd4 109
e7cfd277
JD
1102011-11-21 Jan Djärv <jan.h.d@swipnet.se>
111
112 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
113
a9b9b7f5
CY
1142011-11-21 Chong Yidong <cyd@gnu.org>
115
116 * window.c (Fnext_window, Fprevious_window): Doc fix.
117
b0d15b4f
SM
1182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
119
120 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
121
fe7a3057
JB
1222011-11-20 Juanma Barranquero <lekktu@gmail.com>
123
124 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
125
d2999b1a
MR
1262011-11-20 Martin Rudalics <rudalics@gmx.at>
127
128 * window.c (Fset_window_combination_limit): Rename argument
129 STATUS to LIMIT.
130 (Vwindow_combination_limit): Remove "status" from doc-string.
131
d5ff9cd0
AS
1322011-11-20 Andreas Schwab <schwab@linux-m68k.org>
133
134 * m/ibms390.h: Remove.
135 * m/ibms390x.h: Don't include "ibms390.h".
136
a5bb9bd3
SM
1372011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
138
139 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
140 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
141
cd1181db
JB
1422011-11-20 Juanma Barranquero <lekktu@gmail.com>
143
144 * casetab.c (Fset_case_table):
145 * charset.c (Fcharset_after): Fix typos.
146
615a3b8d 1472011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 148
17e845af
PE
149 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
150 Otherwise, valgrind does not work on some platforms.
151 Problem reported by Andreas Schwab in
6a0bf43d
PE
152 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
153 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
154 is set, removing the need for VIRT_ADDRESS_VARIES.
155 (PURE_P): Use a more-efficient implementation that needs just one
156 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
157 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
158 to 4 (xorl, subq, cmpq, setbe).
159 * alloc.c (pure): Always extern now, since that's the
160 VIRT_ADDR_VARIES behavior.
161 (PURE_POINTER_P): Use a single comparison, not two, for
162 consistency with the new puresize.h.
163 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
164 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
165 Remove VIRT_ADDR_VARIES no longer needed.
166
f8fe6f96
EZ
1672011-11-19 Eli Zaretskii <eliz@gnu.org>
168
169 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
170 (erase_phys_cursor, update_window_cursor, show_mouse_face)
171 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
172 behave as if the cursor position were at the window margin.
173
174 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
175 and the cursor position is out of bounds, behave as if the cursor
176 position were at the window margin. (Bug#10075)
177
df05a53c
CY
1782011-11-18 Chong Yidong <cyd@gnu.org>
179
180 * window.c (Fwindow_combination_limit): Make first argument
181 non-optional, since it is meaningless for live windows like the
182 selected window.
183
2071918e
DA
1842011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
185
186 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
187
b50a28de
SM
1882011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
189
190 * intervals.c: Fix grafting over the whole buffer (bug#10071).
191 (graft_intervals_into_buffer): Simplify.
192
015137db
EZ
1932011-11-18 Eli Zaretskii <eliz@gnu.org>
194
195 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
196 hash values of the two rows.
197 (copy_row_except_pointers): Preserve the used[] arrays and the
198 hash values of the two rows. (Bug#10035)
68c95424 199 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
200
201 * xdisp.c (row_hash): New function, body extracted from
202 compute_line_metrics.
203 (compute_line_metrics): Call row_hash, instead of computing the
204 hash code inline.
205
206 * dispnew.c (verify_row_hash): Call row_hash for computing the
207 hash code of a row, instead of duplicating code from xdisp.c.
208
209 * dispextern.h (row_hash): Add prototype.
210
a2addb04
TH
2112011-11-18 Tassilo Horn <tassilo@member.fsf.org>
212
213 * frame.c (delete_frame): Don't delete the terminal when the last
214 X frame is closed if emacs is built with GTK toolkit.
215
df85d315
JB
2162011-11-17 Juanma Barranquero <lekktu@gmail.com>
217
218 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
219
a0c2d0ae
MR
2202011-11-17 Martin Rudalics <rudalics@gmx.at>
221
222 * window.c (Vwindow_splits): Rename to
223 Vwindow_combination_resize. Suggested by Juri Linkov.
224 (Fsplit_window_internal): Use Vwindow_combination_resize instead
225 of Vwindow_splits.
226
58179cce
JB
2272011-11-16 Juanma Barranquero <lekktu@gmail.com>
228
7877f373
JB
229 * nsfns.m (Fns_font_name):
230 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 231
b6f67890
MR
2322011-11-16 Martin Rudalics <rudalics@gmx.at>
233
234 * window.h (window): Rename slot "nest" to "combination_limit".
235 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
236 (Fset_window_nest): Rename to Fset_window_combination_limit.
237 (Vwindow_nest): Rename to Vwindow_combination_limit.
238 (recombine_windows, make_parent_window, make_window)
239 (Fsplit_window_internal, saved_window)
240 (Fset_window_configuration, save_window_save): Rename all
241 occurrences of window_nest to window_combination_limit.
242
c7015153
JB
2432011-11-15 Juanma Barranquero <lekktu@gmail.com>
244
245 * image.c (imagemagick_load_image): Fix typo.
246
322ad6ec
EZ
2472011-11-14 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (display_line): Move the call to
250 highlight_trailing_whitespace before the call to
251 compute_line_metrics, since the latter needs to see the final
252 faces of all the glyphs to compute ROW's hash value. Fixes
253 assertion violations in row_equal_p. (Bug#10035)
254
f067b8ec
JB
2552011-11-14 Juanma Barranquero <lekktu@gmail.com>
256
257 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
258 just return (bug#10044).
259
1e5b2111
EZ
2602011-11-12 Eli Zaretskii <eliz@gnu.org>
261
7ef3cbd5
EZ
262 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
263 with user-defined heap size. Bump the default size of the temacs
264 heap to 27MB, to avoid memory warning when running temacs.
265 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
266
1e5b2111
EZ
267 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
268 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
269 (verify_row_hash) [XASSERTS]: New function.
270 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
271 that the hash value of glyph rows is correct.
1e5b2111 272
89d61221
MR
2732011-11-12 Martin Rudalics <rudalics@gmx.at>
274
275 * window.h (window): Remove splits slot.
276 * window.c (Fwindow_splits, Fset_window_splits): Remove.
277 (Fdelete_other_windows_internal, make_parent_window)
278 (make_window, Fsplit_window_internal, Fdelete_window_internal)
279 (Fset_window_configuration, save_window_save): Don't deal with
280 split status of windows.
281 (saved_window): Remove splits slot.
282 (Vwindow_splits): Rewrite doc-string.
283
97f18cc8
JD
2842011-11-11 Jan Djärv <jan.h.d@swipnet.se>
285
286 * xfns.c (unwind_create_frame):
287 * nsfns.m (unwind_create_frame):
288 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
289 Vframe_list (Bug#9999).
290
22a648b4
DA
2912011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
292
0b381c7e 293 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 294
659afede
KH
2952011-11-11 Kenichi Handa <handa@m17n.org>
296
297 * callproc.c (Fcall_process): Set the member dst_multibyte of
298 process_coding.
299
9ac0394b
KH
3002011-11-11 Johan Bockgård <bojohan@gnu.org>
301
302 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
303 avoid a crash (bug#9496).
304
2fbdc249
CY
3052011-11-09 Chong Yidong <cyd@gnu.org>
306
307 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
308 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
309
ac6b1f81
PE
3102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
311
312 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
313
09db192c
PE
3142011-11-08 Paul Eggert <eggert@cs.ucla.edu>
315
316 Avoid some portability problems by eschewing 'extern inline' functions.
317 The trivial performance wins aren't worth the portability hassles; see
318 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
319 et seq.
320 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
321 (window_box_width, window_box_left, window_box_left_offset)
322 (window_box_right, window_box_right_offset): Undo previous change,
323 by removing the "extern"s.
324 * intervals.c (adjust_intervals_for_insertion)
325 (adjust_intervals_for_deletion): Undo previous change,
326 making these static again.
327 (offset_intervals, temp_set_point_both, temp_set_point)
328 (copy_intervals_to_string): No longer inline.
329 * xdisp.c (window_text_bottom_y, window_box_width)
330 (window_box_height, window_box_left_offset)
331 (window_box_right_offset, window_box_left, window_box_right)
332 (window_box): No longer inline.
333
105216ed
CY
3342011-11-08 Chong Yidong <cyd@gnu.org>
335
336 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
337 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
338 an error if not a live window.
339 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
340 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
341
ae9e237f
JB
3422011-11-07 Juanma Barranquero <lekktu@gmail.com>
343
344 * lisp.h (syms_of_abbrev): Remove declaration.
345 Reported by CHENG Gao <chenggao@royau.me>.
346
c7aa8333
EZ
3472011-11-07 Eli Zaretskii <eliz@gnu.org>
348
349 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
350 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
351 of temacs in GUI mode.
352
be7f5545
MR
3532011-11-07 Martin Rudalics <rudalics@gmx.at>
354
355 * window.h: Declare delete_all_child_windows instead of
356 delete_all_subwindows.
357 * window.c (Fwindow_nest, Fset_window_nest)
358 (Fset_window_new_total, Fset_window_new_normal)
359 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
360 (delete_all_subwindows): Rename to delete_all_child_windows.
361 (Fdelete_other_windows_internal, Fset_window_configuration):
362 Call delete_all_child_windows instead of delete_all_subwindows.
363 * frame.c (delete_frame): Call delete_all_child_windows instead
364 of delete_all_subwindows.
365
ca78dc43
PE
3662011-11-07 Paul Eggert <eggert@cs.ucla.edu>
367
368 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
369 This is also needed for porting to any host where GC_MARK_STACK is
370 not GC_MAKE_GCPROS_NOOPS.
371 (which_symbols): Use it.
372
a0241d01
KH
3732011-11-07 Kenichi Handa <handa@m17n.org>
374
375 * coding.c (coding_set_destination): Check coding->src_pos only
376 when coding->src_object is a buffer (bug#9910).
377
378 * process.c (send_process): Set the member src_multibyte of coding
379 to 0 (bug#9911) when sending a unibyte text.
380
381 * callproc.c (Fcall_process): Set the member src_multibyte of
382 process_coding to 0 (bug#9912).
383
a64bfdfa 3842011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
385
386 * xmenu.c (cleanup_widget_value_tree): New function.
387 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
388 calling free_menubar_widget_value_tree directly (Bug#9830).
389
cb41b32a
PE
3902011-11-06 Paul Eggert <eggert@cs.ucla.edu>
391
392 Fix some portability problems with 'inline'.
393 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
394 (window_box_width, window_box_left, window_box_left_offset)
395 (window_box_right, window_box_right_offset): Declare extern.
396 Otherwise, these inline functions do not conform to C99 and
397 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
398 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
399 * intervals.c (adjust_intervals_for_insertion)
400 (adjust_intervals_for_deletion): Now extern, because otherwise the
401 extern inline functions 'offset_intervals' couldn't refer to it.
402 (static_offset_intervals): Remove.
403 (offset_intervals): Rewrite using the old contents of
404 static_offset_intervals. The old version didn't conform to C99
405 because an extern inline function contained a reference to an
406 identifier with static linkage.
407
b7041366
AS
4082011-11-06 Andreas Schwab <schwab@linux-m68k.org>
409
410 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
411 GC.
412
88a37c4d
EZ
4132011-11-06 Eli Zaretskii <eliz@gnu.org>
414
415 * xdisp.c (init_iterator, reseat_to_string): Don't set the
416 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
417 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
418 return Qleft_to_right.
419
49745b39
CY
4202011-11-06 Chong Yidong <cyd@gnu.org>
421
422 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
423 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
424 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
425 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
426 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
427 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
428 (Fwindow_vscroll): Doc fix.
429 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
430 argument, since it makes no sense to pass a live window and for
431 consistency with window-child.
432
1f05cd82
CS
4332011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
434
435 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
436 support MSVC.
437
22610910
JR
4382011-11-05 Jason Rumney <jasonr@gnu.org>
439
440 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
441 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
442 fonts (Bug#6029).
443 (add_font_entity_to_list): Fix logic errors in mixed boolean and
444 bitwise arithmetic preventing use of unicode-sip and non-truetype
445 opentype fonts.
446
a06776b2
EZ
4472011-11-05 Eli Zaretskii <eliz@gnu.org>
448
3ad924ba
EZ
449 * s/ms-w32.h (fstat, stat, utime): Move redirections to
450 "emacs"-only part.
451
a06776b2
EZ
452 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
453 initialization code to keep similarity to xfns.c after changes
454 from 2011-11-05.
455
c9e7db78
JD
4562011-11-05 Jan Djärv <jan.h.d@swipnet.se>
457
a97f8f3f
JD
458 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
459 (unwind_create_frame): New function (Bug#9943).
460 (Fx_create_frame): Restructure code to be more similar to the one in
461 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
462 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
463 Move terminal->reference_count++ just before making the frame official
464 (Bug#9943).
465
466 * nsterm.m (x_free_frame_resources): New function.
467 (x_destroy_window): Move code to x_free_frame_resources.
468
c9e7db78
JD
469 * xfns.c (unwind_create_frame): Fix comment.
470 (Fx_create_frame, x_create_tip_frame): Move
471 terminal->reference_count++ just before making the frame
472 official. Move initialization of image_cache_refcount and
473 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
474
a6fc3b5c
EZ
4752011-11-05 Eli Zaretskii <eliz@gnu.org>
476
477 Support MSVC build with newer versions of Visual Studio.
478 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
479 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
480 nt/gmake.defs.
481
482 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
483 which are not supported by MSVC.
484 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
485 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
486 bitfields.
487 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
488 types in bitfields.
489 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
490
491 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
492
58179cce 4932011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
494
495 Support MSVC build with newer versions of Visual Studio.
496 * w32.c: Don't include w32api.h for MSVC.
497 (init_environment) [_MSC_VER]: Call sys_access, not _access.
498
499 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
500 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
501 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
502 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
503 e_* cousins.
504 (alloca) [_MSC_VER]: Define to _alloca.
505
506 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
507
508 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
509
a58c13ed
EZ
5102011-11-04 Eli Zaretskii <eliz@gnu.org>
511
512 * xdisp.c (note_mouse_highlight): If either of
513 previous/next-single-property-change returns nil, treat that as
514 the beginning or the end of the buffer. (Bug#9955)
515
fe0b6370
JD
5162011-11-04 Jan Djärv <jan.h.d@swipnet.se>
517
a58c13ed 518 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
519 label is not null (Bug#9951).
520 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
521 may be NULL.
522
89bd5ee1
EZ
5232011-11-04 Eli Zaretskii <eliz@gnu.org>
524
525 * window.c (Fwindow_body_size): Mention in the doc string that the
526 return value is in frame's canonical units. (Bug#9949)
527
84c3edb9
EZ
5282011-11-03 Eli Zaretskii <eliz@gnu.org>
529
4e2fb5c7
EZ
530 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
531
84c3edb9 532 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 533 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 534 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 535
bc17a887
EZ
5362011-11-01 Eli Zaretskii <eliz@gnu.org>
537
538 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
539 Don't stop backward scan on the continuation glyph, even though
540 its CHARPOS is positive.
26b46e51
EZ
541 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
542 cover_string to disp_string.
bc17a887 543
4ee88440
MR
5442011-11-01 Martin Rudalics <rudalics@gmx.at>
545
546 * window.c (temp_output_buffer_show): Don't use
547 Vtemp_buffer_show_specifiers.
548 (Vtemp_buffer_show_specifiers): Remove unused variable.
549
c2ff3c02
EZ
5502011-10-30 Eli Zaretskii <eliz@gnu.org>
551
552 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
553 past the beginning of the current glyph matrix.
554
58179cce 5552011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
556
557 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
558 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
559 HAVE_GTK3 (Bug#9869).
b77a6a7f 560
3b574623
JD
561 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
562 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
563
b77a6a7f
JD
564 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
565
566 * xterm.c: Declare x_handle_net_wm_state to return int.
567 (handle_one_xevent): Check if we are iconified but don't have
568 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
569 (get_current_wm_state): Return non-zero if not hidden,
570 check for _NET_WM_STATE_HIDDEN (Bug#9893).
571 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
572 (x_handle_net_wm_state): Return what get_current_wm_state returns.
573 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
574
196e41e4
PE
5752011-10-29 Paul Eggert <eggert@cs.ucla.edu>
576
577 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
578 so that this new function doesn't get optimized away by a
579 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
580
021f2e1a
AS
5812011-10-29 Andreas Schwab <schwab@linux-m68k.org>
582
583 * frame.h (MOUSE_HL_INFO): Remove excess parens.
584
8b058d44
EZ
5852011-10-29 Eli Zaretskii <eliz@gnu.org>
586
587 Fix the `xbytecode' command.
588 * .gdbinit (xprintbytestr): New command.
b50a28de 589 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
590 (xbytecode): Print the byte-code string as well.
591
4452fb80
EZ
5922011-10-29 Kim Storm <storm@cua.dk>
593
8b058d44
EZ
594 * alloc.c (which_symbols): New function.
595
21b72067
AS
5962011-10-29 Andreas Schwab <schwab@linux-m68k.org>
597
598 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
599 line. (Bug#9903)
600
83ed7b5c
GM
6012011-10-29 Glenn Morris <rgm@gnu.org>
602
603 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
604 Not clear what it was for, and it causes various bugs. (Bug#9839)
605
5a7a728b
EZ
6062011-10-28 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
609 possible random value that matches one of those tested as
610 condition to clear the mouse face.
611
d3d0842f
CY
6122011-10-28 Chong Yidong <cyd@gnu.org>
613
614 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
615
31b39d13
DN
6162011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
617
618 * window.c (make_window): Initialize phys_cursor_on_p.
619
9aba6043
SM
6202011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
621
622 * lisp.h (struct Lisp_Symbol): Update comments.
623
c20992f4
JB
6242011-10-28 Juanma Barranquero <lekktu@gmail.com>
625
626 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
627
db4f02f2
EZ
6282011-10-28 Eli Zaretskii <eliz@gnu.org>
629
630 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
631 <oslsachem@gmail.com> for helping to debug this.
632
633 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
634 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
635 (g_b_init_get_glyph_outline_w): New static variables.
636 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
637 (GetGlyphOutlineW_Proc): New typedefs.
638 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
639 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
640 New functions.
641 (w32font_open_internal, compute_metrics):
642 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
643 instead of calling the "wide" APIs directly.
644
645 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
646
647 * w32.h (syms_of_w32font): Add prototype.
648
87e68db4
JB
6492011-10-27 Juanma Barranquero <lekktu@gmail.com>
650
651 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
652 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
653 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
654 (Fmove_to_window_line): Doc fix.
655
435c1d67
CY
6562011-10-27 Chong Yidong <cyd@gnu.org>
657
658 * process.c (make_process): Set gnutls_state to NULL.
659
660 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
661 non-NULL, regardless of GNUTLS_INITSTAGE.
662 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
663 an error. Set process slots as soon as we allocate them.
664
665 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
666
9c6c6f49
CY
6672011-10-27 Chong Yidong <cyd@gnu.org>
668
9aba6043
SM
669 * gnutls.c (emacs_gnutls_deinit): New function.
670 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
671 (Fgnutls_deinit, Fgnutls_boot): Use it.
672
673 * process.c (make_process): Initialize GnuTLS credentials to NULL.
674 (deactivate_process): Call emacs_gnutls_deinit.
675
657d08d3
JB
6762011-10-27 Juanma Barranquero <lekktu@gmail.com>
677
678 * image.c (x_create_x_image_and_pixmap):
679 * w32.c (sys_rename, w32_delayed_load):
680 * w32font.c (fill_in_logfont):
681 * w32reg.c (x_get_string_resource): Silence compiler warnings.
682
5430d399
JB
6832011-10-26 Juanma Barranquero <lekktu@gmail.com>
684
685 * w32fns.c (w32_default_color_map): New function,
686 extracted from Fw32_default_color_map.
a7ef684b 687 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 688
fe0055fa
PE
6892011-10-25 Paul Eggert <eggert@cs.ucla.edu>
690
691 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
692
e6346438
SM
6932011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
694
695 * keyboard.c (test_undefined): New function (bug#9751).
696 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
697
e112cc37
ET
6982011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
699
700 * sysdep.c (init_sys_modes): Fix the check for the controlling
701 terminal (Bug#6649).
702
7b5d6677
EZ
7032011-10-20 Eli Zaretskii <eliz@gnu.org>
704
705 * dispextern.h (struct bidi_it): New member next_en_type.
706
707 * bidi.c (bidi_line_init): Initialize the next_en_type member.
708 (bidi_resolve_explicit_1): When next_en_pos is valid for the
709 current character, check also for next_en_type being WEAK_EN.
710 (bidi_resolve_weak): Don't enter the expensive loop if the current
711 position is before next_en_pos. Record the bidi type of the first
712 non-ET, non-BN character we find, in addition to its position.
713 (bidi_level_of_next_char): Invalidate next_en_type when
714 next_en_pos is over-stepped.
715
7da0b018
PE
7162011-10-20 Paul Eggert <eggert@cs.ucla.edu>
717
718 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
719 * editfns.c: Rewrite current-time-zone so that it invokes
720 the equivalent of (format-time-string "%Z") to get the time zone name.
721 This fixes a bug when the time zone name contains characters that
722 need converting from the system time locale to Emacs internal format.
723 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
724 that patch fixed format-time-string to do the conversion, but
725 I forgot to fix current-time-zone.
726 (format_time_string): New function, containing most of
727 what Fformat_time_string used to contain.
728 (Fformat_time_string): Rewrite in terms of format_time_string.
729 This doesn't change this function's behavior.
730 (current-time-zone): Rewrite to use format_time_string.
731 This fixes the bug reported by Michael Schierl in
732 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
733 Jason Rumney's 2007-06-07 change worked around this bug, but
734 didn't fix it.
735 * systime.h (tzname, timezone): Remove no-longer-used declarations.
736
8547b010
EZ
7372011-10-19 Eli Zaretskii <eliz@gnu.org>
738
739 * xdisp.c (start_display): If the character at POS is displayed
740 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
741 (try_window_reusing_current_matrix): If a line ends in a display
742 vector or the next line starts in a display vector, continue
743 redrawing the window even though the character position of
744 start_row was reached.
8547b010
EZ
745 (Bug#9771, part 2)
746
4e948d15
CY
7472011-10-18 Chong Yidong <cyd@gnu.org>
748
749 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
750 with nobreak-char-display too.
751
4787455f
EZ
7522011-10-18 Eli Zaretskii <eliz@gnu.org>
753
754 Fix part 3 of bug#9771.
755 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
756 (bidi_resolve_neutral): Don't enter the expensive loop looking for
757 non-neutral characters if the current character is a paragraph
758 separator (a.k.a. Newline). This avoids running the same
759 expensive loop twice, once when we consume the preceding newline
760 and the other time when the line actually needs to be displayed.
761 Avoid the loop when we see neutrals on the base embedding level
762 following a character whose directionality is the same as the
763 paragraph's. This avoids running the expensive loop when a line
764 ends in a long sequence of neutrals, like control characters.
765 Add assertion against STRONG_AL type. Slightly rearrange code
766 that determines the type of a neutral given the first non-neutral
767 that follows it.
768 (bidi_level_of_next_char): Set next_en_pos to zero when
769 invalidating its info.
770
2c91f553
EZ
7712011-10-17 Eli Zaretskii <eliz@gnu.org>
772
773 * xdisp.c (push_display_prop): Determine whether to record string
774 or buffer position by IT->string, not by IT->method. Allow
775 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
776 (move_it_vertically_backward): Don't look for character position
777 immediately after the newline when in a continuation line.
778 (Bug#9771, part 1)
2c91f553 779
c7b08b0d
MR
7802011-10-15 Martin Rudalics <rudalics@gmx.at>
781
782 * window.c (coordinates_in_window): Rewrite and delabelize
783 vertical border check. (Bug#5357) (Bug#9618)
784
6b02f655
SM
7852011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
786
787 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
788 errors in XSetWindowBorder (bug#9310).
789
81d40c92
DA
7902011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
791
792 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
793 avoid crash when xmalloc overrun checking is enabled.
794
d4172c3b
EZ
7952011-10-13 Eli Zaretskii <eliz@gnu.org>
796
797 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
798 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
799 cursor motion with <left> and <right> arrow keys.
800
801 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
802 some callers set that themselves.
803
b00eea75
EZ
8042011-10-12 Eli Zaretskii <eliz@gnu.org>
805
806 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
807 display string and the previous row comes from the same string and
808 is empty. (Bug#9739) (Bug#9738)
809
8fe012c4
SM
8102011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
811
812 * doc.c (get_doc_string): Encode file name (bug#9735).
813
0074aef2
EZ
8142011-10-12 Eli Zaretskii <eliz@gnu.org>
815
79beb178
EZ
816 * bidi.c (bidi_level_of_next_char):
817 * xdisp.c (get_visually_first_element): Remove old incorrect
818 comments regarding the Unicode Line Separator character.
819
0074aef2
EZ
820 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
821
6e4b3fbe
DA
8222011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
823
824 * alloc.c (Fgc_status): Do not access beyond zombies array
825 boundary if nzombies > MAX_ZOMBIES.
826 * alloc.c (dump_zombies): Add missing format specifier.
827
0324f3af
PE
8282011-10-12 Paul Eggert <eggert@cs.ucla.edu>
829
b5525cac
PE
830 * xdisp.c (set_cursor_from_row): Simplify conditionals,
831 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
832
0324f3af
PE
833 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
834 Some packages use them to denote characters with modifiers.
835
e9b5f888
AS
8362011-10-11 Andreas Schwab <schwab@linux-m68k.org>
837
838 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
839 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
840 matching a pp-number. Rename parameter var to var1.
841
127827c0
SM
8422011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
843
844 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
845
c8fd3bd0
GM
8462011-10-08 Glenn Morris <rgm@gnu.org>
847
848 * callint.c (Fcall_interactively): Give a more explicit error for the
849 'c' case with a non-character input. (Bug#8479)
850
352ec8ff
EZ
8512011-10-08 Eli Zaretskii <eliz@gnu.org>
852
03669ccb
EZ
853 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
854 lines.
7061c986
EZ
855 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
856 lines that are hscrolled on the left.
03669ccb 857
352ec8ff
EZ
858 * dispnew.c (buffer_posn_from_coords): Account for a possible
859 presence of header-line. (Bug#4426)
860
a66cfb1c
SM
8612011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
862
6b02f655
SM
863 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
864 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 865
7c5ee88e
PE
8662011-10-07 Paul Eggert <eggert@cs.ucla.edu>
867
868 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
869 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
870 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
871 this makes Emacs dump core during garbage collection on rare
872 occasions. sizeof is obviously inferior to offsetof here, so
873 stick with offsetof.
874 (GC_POINTER_ALIGNMENT): New macro.
875 (mark_memory): Omit 3rd (offset) arg; caller changed.
876 Don't assume EMACS_INT alignment is the same as pointer alignment.
877
df1bbe5b
SM
8782011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
879
880 * keyboard.c (read_key_sequence_remapped): New var.
881 (read_key_sequence): Compute remapping in the right buffer.
882 (command_loop_1): Use read_key_sequence's remapping directly.
883
51553db6
SM
8842011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
885
32c1fffd
SM
886 * dired.c (file_name_completion): Don't expand file name.
887 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
888 before checking file name handler.
889
51553db6
SM
890 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
891 they've been requested explicitly (bug#9591).
892
b6bd1599 8932011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
894
895 * keymap.c (Fsingle_key_description): Use make_specified_string
896 instead of build_string to build string from push_key_description.
897 (Bug#5193)
898
f701dc2a
PE
8992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
900
4222c55d
PE
901 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
902 This fixes a Y2038 bug on 64-bit hosts.
903 * buffer.c (reset_buffer):
904 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
905 (Fclear_buffer_auto_save_failure):
906 Use 0, not -1, to represent an unset failure time, since time_t
907 might not be signed.
908
f701dc2a
PE
909 Remove dependency on glibc malloc internals.
910 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
911 Move back here from lisp.h, but with their new implementations.
912 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
913 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
914 * charset.c (charset_table_init): New static var.
915 (syms_of_charset): Use it instead of xmalloc. This removes a
916 dependency on glibc malloc internals. See Eli Zaretskii's comment in
917 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
918 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
919 Move back to alloc.c.
920 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
921 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
922
9ceebf39
JD
9232011-09-30 Jan Djärv <jan.h.d@swipnet.se>
924
925 * nsterm.m (windowDidResize): Call x_set_window_size only when
926 ns_in_resize is true. Otherwise set pixelwidth/height and
927 call change_frame_size (Bug#9628).
928
cb993c58
PE
9292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
930
3930c88b
PE
931 Port --enable-checking=all to Fedora 14 x86-64.
932 * charset.c (syms_of_charset): Also account for glibc malloc's
933 internal overhead when calculating the initial malloc maximum.
934
cb993c58
PE
935 Port --enable-checking=all to Fedora 14 x86.
936 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
937 Move to lisp.h.
938 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
939 (overrun_check_realloc, overrun_check_free):
940 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
941 That way, xmalloc returns a properly-aligned pointer even if
942 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
943 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
944 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
945 into account when calculating the initial malloc maximum.
946 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
947 Move here from alloc.c, so that charset.c can use it too.
948 Properly align; the old code wasn't right for common 32-bit hosts
949 when configured with --enable-checking=all.
950 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
951 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
952
31bed486
EZ
9532011-09-29 Eli Zaretskii <eliz@gnu.org>
954
04c70788 955 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
956 use EDOM.
957
fbcaa2f3
EZ
9582011-09-28 Eli Zaretskii <eliz@gnu.org>
959
960 * xdisp.c (compute_display_string_end): If there's no display
961 string at CHARPOS, return -1.
962
963 * bidi.c (bidi_fetch_char): When compute_display_string_end
964 returns a negative value, treat the character as a normal
965 character not covered by a display string. (Bug#9624)
966
a239d4e9
JB
9672011-09-28 Juanma Barranquero <lekktu@gmail.com>
968
969 * lread.c (Fread_from_string): Fix typo in docstring.
970
88652fd5
EZ
9712011-09-27 Eli Zaretskii <eliz@gnu.org>
972
973 * xdisp.c (handle_invisible_prop): If invisible text ends on a
974 newline, reseat the iterator instead of bidi-iterating there one
975 character at a time. (Bug#9610)
32c1fffd
SM
976 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
977 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 978
ed497dd4
AS
9792011-09-27 Andreas Schwab <schwab@linux-m68k.org>
980
981 * lread.c (readevalloop): Use correct code for NBSP.
982 (read1): Likewise. (Bug#9608)
983
b2bf61aa
MA
9842011-09-25 Michael Albinus <michael.albinus@gmx.de>
985
986 * dbusbind.c (Fdbus_register_signal): When service is not
987 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
988
32bbb17c
GM
9892011-09-25 Glenn Morris <rgm@gnu.org>
990
991 * buffer.c (truncate-lines): Doc fix.
992
94e0933e
CY
9932011-09-24 Chong Yidong <cyd@stupidchicken.com>
994
995 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
996 (Fset_window_next_buffers): Doc fix.
997
cddde921
GM
9982011-09-24 Glenn Morris <rgm@gnu.org>
999
1000 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1001
1260aef1
PE
10022011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1003
25b4bfa0
PE
1004 Fix minor problems found by static checking.
1005 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1006 * indent.c (Fvertical_motion): Fix == vs = typo.
1007
e3cbd34b
EZ
10082011-09-24 Eli Zaretskii <eliz@gnu.org>
1009
a66cfb1c
SM
1010 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1011 Default value is now t. Doc fix.
6bf7006f 1012
e3cbd34b 1013 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1014 logic when moving up, not only when moving down. Fix the
e3cbd34b 1015 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1016 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1017
1018 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1019 CHARPOS is covered by a display string which includes newlines.
1020 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1021 is covered by a display string with embedded newlines.
1022
a3de0cbd
MA
10232011-09-24 Michael Albinus <michael.albinus@gmx.de>
1024
1025 * dbusbind.c (Fdbus_register_signal): Add match rule to
1026 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1027 (Fdbus_register_method, Vdbus_registered_objects_table):
1028 Fix docstring.
a3de0cbd 1029
b260039d
JM
10302011-09-24 Jim Meyering <meyering@redhat.com>
1031
32c1fffd 1032 do not ignore write error for any output size
b260039d
JM
1033 The previous change was incomplete.
1034 While it makes emacs --batch detect the vast majority of stdout
1035 write failures, errors were still ignored whenever the output size is
1036 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1037 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1038 && echo FAIL: ignored write error
1039 FAIL: ignored write error
1040 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1041 && echo FAIL: ignored write error
1042 FAIL: ignored write error
1043 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1044
8eca8a7c
AS
10452011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1046
1047 * emacs.c (Fkill_emacs): In noninteractive mode exit
1048 non-successfully if a write error occurred on stdout. (Bug#9574)
1049
3341db62
EZ
10502011-09-21 Eli Zaretskii <eliz@gnu.org>
1051
1052 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1053 the xassert test.
1054
1055 * dispextern.h (struct it): Update the comment documenting what
1056 can it->OBJECT be.
1057
8c203dbf
EZ
10582011-09-20 Eli Zaretskii <eliz@gnu.org>
1059
1060 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1061 a display string, extend search for cursor position to end of row.
1062 (find_row_edges): If the row ends in a newline from a display
1063 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1064 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1065 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1066 non-empty line. Fixes confusing cursor motion with arrow keys at
1067 the beginning of a line that starts with whitespace.
8c203dbf 1068
a4824228
LMI
10692011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1070
1071 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1072 (bug#9493).
1073
33ed493b
CY
10742011-09-18 Chong Yidong <cyd@stupidchicken.com>
1075
1076 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1077 boolean (Bug#9154).
1078
56cd55c8
EZ
10792011-09-18 Eli Zaretskii <eliz@gnu.org>
1080
1081 * xdisp.c (display_line): Record maximum and minimum buffer
1082 positions even if no glyphs were produced (e.g., by a zero-width
1083 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1084 buffer positions that will be removed from the glyph row because
1085 they don't fit.
c02dcedf
EZ
1086 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1087 column is beyond frame width: don't subtract 1 "pixel" when
1088 computing width of the stretch.
3e62b7e0
EZ
1089 (reseat_at_next_visible_line_start): Undo the change made on
1090 2011-09-17 that saved paragraph information and restored it after
1091 the call to `reseat'. (Bug#9545)
56cd55c8 1092
5ed99d36 10932011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1094
1095 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1096 and turn window cursor on if cleared (Bug#9415).
1097
5ed99d36 10982011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1099
1100 * search.c (boyer_moore): Take unibyte characters from pattern
1101 literally. (Bug#9458)
1102
9bade7b2
EZ
11032011-09-18 Eli Zaretskii <eliz@gnu.org>
1104
1105 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1106
e5e9d610
PE
11072011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1108
87e4427a
PE
1109 Fix minor problem found by static checking.
1110 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1111 initialized, to pacify gcc -Wuninitialized.
1112
e5e9d610
PE
1113 * fileio.c: Report proper errno when syscall falls.
1114 (Finsert_file_contents): Save and restore errno,
1115 so that report_file_error outputs the correct diagnostic.
1116 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1117
a1674f0b
EZ
11182011-09-18 Eli Zaretskii <eliz@gnu.org>
1119
1120 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1121
fbfb6dd4
EZ
11222011-09-17 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1125 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1126
bb187662
EZ
11272011-09-17 Eli Zaretskii <eliz@gnu.org>
1128
1137e8b8 1129 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1130 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1131
1132 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1133 (bidi_find_paragraph_start): Search back for paragraph beginning
1134 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1135 (bidi_move_to_visually_next): Only trigger paragraph-related
1136 computations when the last character is a newline or at EOB, not
1137 just any NEUTRAL_B. (Bug#9470)
1138
bb187662
EZ
1139 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1140 truncated lines if point is covered by a display string. (Bug#9524)
1141
2e621251
PE
11422011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1145 (cons_to_x_long): New function.
1146 (lisp_data_to_selection_data): Use it. Correct the test for
1147 short-versus-long data; it was negated. Break out of vector
1148 loop, for efficiency, when a long datum is discovered.
1149
91a15bc6
SM
11502011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1151
1152 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1153
b41c3a35
EZ
11542011-09-16 Eli Zaretskii <eliz@gnu.org>
1155
1156 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1157 GCC PR/17406) by declaring this function with external scope.
1158
7812ba2d
PE
11592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1160
1161 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1162 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1163
cf7edc2a
AS
11642011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1165
1166 * editfns.c (Fformat): Correctly handle text properties on "%%".
1167
bd01620e
EZ
11682011-09-15 Eli Zaretskii <eliz@gnu.org>
1169
1170 * xterm.c (x_draw_composite_glyph_string_foreground):
1171 * w32term.c (x_draw_composite_glyph_string_foreground):
1172 * term.c (encode_terminal_code):
1173 * composite.c (composition_update_it, get_composition_id):
1174 * xdisp.c (get_next_display_element)
1175 (fill_composite_glyph_string): Add comments about special meaning
1176 of TAB characters in a composition.
1177
a02719a3
PE
11782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1179
1180 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1181 This occurs when processing a multibyte format.
1182 Problem reported by Wolfgang Jenker.
a02719a3 1183
72589a3c
JB
11842011-09-15 Johan Bockgård <bojohan@gnu.org>
1185
1186 * xdisp.c (try_cursor_movement): Only check for exact match if
1187 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1188
1c14176c
PE
11892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 Remove unused external symbols.
1192 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1193 * xdisp.c (calc_pixel_width_or_height): Now static.
1194 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1195 * indent.c (check_display_width):
1196 * w32term.c: Fix comment to match code.
1197 * xterm.c, xterm.h (x_catching_errors): Remove.
1198
d2eea5b5
PE
11992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * xselect.c: Use signed conversions more consistently (Bug#9498).
1202 (selection_data_to_lisp_data): Assume incoming selection data are
1203 signed integers, not unsigned. This is to be consistent with
1204 outgoing selection data, which was modified to use signed integers
1205 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1206 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1207 expects long, not unsigned long.
1208
46888499
EZ
12092011-09-14 Eli Zaretskii <eliz@gnu.org>
1210
1211 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1212 computation of loop end. Reported by Johan Bockgård
1213 <bojohan@gnu.org>.
1214
ef8ef9fb
CY
12152011-09-13 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * frame.c (Fother_visible_frames_p): Function deleted.
1218
fa819fed
EZ
12192011-09-12 Eli Zaretskii <eliz@gnu.org>
1220
1221 * indent.c (compute_motion): Process display vector front to back
1222 rather than the other way around. (Bug#2496)
1223
2ba8e008
SM
12242011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1225
1226 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1227
20f53c69
CY
12282011-09-11 Chong Yidong <cyd@stupidchicken.com>
1229
1230 * minibuf.c (Fread_from_minibuffer): Doc fix.
1231
d562d7a4
EZ
12322011-09-11 Eli Zaretskii <eliz@gnu.org>
1233
1234 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1235 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1236
1c4d7f3d
LMI
12372011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1238
1239 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1240 value for non-existent files.
1241
b885bf36
EZ
12422011-09-11 Eli Zaretskii <eliz@gnu.org>
1243
1244 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1245 set its "size" to -1. This will set the modtime_size field of
1246 the corresponding buffer to -1, which is what
1247 verify-visited-file-modtime expects for files that do not exist.
1248 (Bug#9139)
1249
6612f0bf
PE
12502011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1253 here ...
1254 * lisp.h: ... from here. push_key_description is no longer
1255 defined in keyboard.c, so its declaration should not be in
1256 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1257 logically belongs with push_key_description.
1258
dfb3f755
PE
12592011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * buffer.h: Include <sys/types.h> instead of <time.h>.
1262 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1263 Problem reported by Herbert J. Skuhra.
1264
3134906c
LMI
12652011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1266
1267 * xml.c (parse_region): Make the parsing work for
1268 non-comment-starting XML files again (bug#9144).
1269
8d903f4e
AS
12702011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1271
1272 * image.c (gif_load): Fix calculation of bottom and right corner.
1273 (Bug#9468)
1274
80ad64f4
EZ
12752011-09-10 Eli Zaretskii <eliz@gnu.org>
1276
1277 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1278 redisplay in small windows.
1279
208a048d
EZ
12802011-09-09 Eli Zaretskii <eliz@gnu.org>
1281
1282 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1283
9b1c252e
MR
12842011-09-08 Martin Rudalics <rudalics@gmx.at>
1285
1286 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1287 Operate on live windows only.
1288
2949f33b
JB
12892011-09-08 Juanma Barranquero <lekktu@gmail.com>
1290
1291 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1292
e08dcafd
EZ
12932011-09-07 Eli Zaretskii <eliz@gnu.org>
1294
1295 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1296 only under bidi iteration.
1297
115b96bd
JD
12982011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1299
1300 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1301
c8199d0f
PE
13022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1305 Without this fix, the command to link temacs failed due to an
1306 undefined symbol __builtin_isnan. This is because
1307 /usr/include/iso/math_c99.h #defines isnan(x) to
1308 __builtin_isnan(x), but the bundled gcc, which identifies itself
1309 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1310 a __builtin_isnan.
1311 * floatfns.c (isnan): #undef, and then #define to a clone of
1312 what's in data.c.
1313 (Fisnan): Always define, since it's always available now.
1314 (syms_of_floatfns): Always define isnan at the Lisp level.
1315
e39b275c 13162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1317
1318 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1319
b2db44d9 13202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1321
f4af5137 1322 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1323 The previous code assumed that file offsets (off_t values) fit in
1324 EMACS_INT variables, which is not true on typical 32-bit hosts.
1325 The code messed up by falsely reporting buffer overflow in cases
1326 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1327 when "big" contains more than 2**29 bytes, even though this
1328 inserts just one byte and does not overflow the buffer.
1329 (Finsert_file_contents): Store file offsets as off_t
1330 values, not as EMACS_INT values. Check for overflow when
1331 converting between EMACS_INT and off_t. When checking for
1332 buffer overflow or for overlap, take the offsets into account.
1333 Don't use EMACS_INT for small values where int suffices.
1334 When checking for overlap, fix a typo: ZV was used where
1335 ZV_BYTE was intended.
1336 (Fwrite_region): Don't assume off_t fits into 'long'.
1337 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1338
ecfc0a49
MA
13392011-09-05 Michael Albinus <michael.albinus@gmx.de>
1340
1341 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1342
6511acf2 13432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1344
0999621a 1345 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1346
1347 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1348 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1349 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1350 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1351 (modify_event_symbol): Do not assume that the length of
1352 name_alist_or_stem is safe to alloca and fits in int.
1353 (Fexecute_extended_command): Likewise for function name and binding.
1354 (Frecursion_depth): Wrap around reliably on integer overflow.
1355 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1356 since some callers pass EMACS_INT values.
1357 (Fsingle_key_description): Don't crash if symbol name contains more
1358 than MAX_ALLOCA bytes.
1359 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1360 (get_minibuffer): Arg is now EMACS_INT, not int.
1361 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1362 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1363 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1364
2be7d702
PE
1365 * dbusbind.c (signature_cat): New function.
1366 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1367 Do not overrun buffer; instead, report string overflow.
1368
9d1df220
PE
1369 * dispnew.c (add_window_display_history): Don't overrun buffer.
1370 Truncate instead; this is OK since it's just a log.
1371
33ef5c64
PE
1372 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1373 even if the time zone offset is outlandishly large.
1374 Don't mishandle offset == INT_MIN.
1375
66c6fdd5
PE
1376 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1377 when creating daemon; the previous buffer-overflow check was incorrect.
1378
d749b01b
PE
1379 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1380 which has the guts of the old verror function.
1381
b5cd1905
PE
1382 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1383 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1384
6e1a67fb
PE
1385 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1386 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1387 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1388 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1389 length of string rather than counting it via multiple sprintfs;
1390 that's simpler and more reliable.
c21721cc
PE
1391 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1392 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1393 sprintf, in case result does not fit in int.
1394
c57b67fc
PE
1395 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1396 (fontset_from_font): Print it.
1397
8a401434
PE
1398 * frame.c (tty_frame_count): Now printmax_t, not int.
1399 (make_terminal_frame, set_term_frame_name): Print it.
1400 (x_report_frame_params): In X, window IDs are unsigned long,
1401 not signed long, so print them as unsigned.
1402 (validate_x_resource_name): Check for implausibly long names,
1403 and don't assume name length fits in 'int'.
1404 (x_get_resource_string): Don't blindly alloca invocation name;
1405 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1406 not fit in int.
1407
6e1a67fb
PE
1408 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1409 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1410 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1411
0df02bf3
PE
1412 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1413 Use esprintf, not sprintf, in case result does not fit in int.
1414
48e30793
PE
1415 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1416 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1417 it as a large positive number.
1418 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1419 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1420
a66ff6d8
PE
1421 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1422 in case result does not fit in int.
1423
aca216ff
PE
1424 * print.c (float_to_string): Detect width overflow more reliably.
1425 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1426 buffer overrun. Don't assume list length fits in 'int'. Treat
1427 print length of 0 as 0, not as infinity; to be consistent with other
1428 uses of print length in this function. Don't overflow print length
1429 index. Don't assume hash table size fits in 'long', or that
1430 vectorlike size fits in 'unsigned long'.
1431
31c286f7
PE
1432 * process.c (make_process): Use printmax_t, not int, to format
1433 process-name gensyms.
1434
55e5faa1
PE
1435 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1436
80f2e268
PE
1437 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1438 to avoid potential buffer overrun.
1439
670741ab
PE
1440 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1441 if X resource line is longer than 512 bytes.
1442
b7163a50
PE
1443 * xfns.c (x_window): Make sprintf buffer a bit bigger
1444 to avoid potential buffer overrun.
1445
ae58ff1f
PE
1446 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1447
c43c8a6a
PE
1448 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1449
3f8236f4
PE
14502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1451
53e9fe90 1452 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1453 Without these, Emacs silently mishandles large integers sometimes.
1454 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1455 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1456
6511acf2
PE
1457 * xdisp.c (try_window_id): Check Emacs fixnum range before
1458 converting to 'int'.
806add1d 1459
6511acf2 1460 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1461 Check that an Emacs fixnum is in range before assigning it to 'int'.
1462 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1463 values converted from Emacs fixnums.
1464 (Frecenter): Don't wrap around a line count if it is out of 'int'
1465 range; instead, treat it as an extreme value.
1466 (Fset_window_configuration, compare_window_configurations):
1467 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1468
6511acf2
PE
1469 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1470 that can exceed INT_MAX. Check that EMACS_INT value is in range
1471 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1472 (match_limit): Don't assume that a fixnum can fit in 'int'.
1473
6511acf2 1474 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1475 exceed INT_MAX.
1476
6511acf2 1477 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1478 (Fvertical_motion): Don't wrap around LINES values that don't fit
1479 in 'int'. Instead, treat them as extreme values. This is good
1480 enough for windows, which can't have more than INT_MAX lines anyway.
1481
fcb901a7
LMI
14822011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1483
0f2f6b6d
LMI
1484 * Require libxml/parser.h to avoid compilation warning.
1485
fcb901a7
LMI
1486 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1487
1488 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1489 since this reportedly can destroy thread storage.
1490
6e20a0d4
CY
14912011-08-30 Chong Yidong <cyd@stupidchicken.com>
1492
1493 * syntax.c (find_defun_start): Update all cache variables if
1494 exiting early (Bug#9401).
1495
148ae00e
EZ
14962011-08-30 Eli Zaretskii <eliz@gnu.org>
1497
f6cfbd8f
EZ
1498 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1499
148ae00e
EZ
1500 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1501 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1502 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1503
1504 * term.c (tty_append_glyph): New function.
1505 (produce_stretch_glyph): Static function and its prototype deleted.
1506
a66cfb1c
SM
1507 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1508 Add prototypes.
148ae00e 1509
c4a07a4c
PE
15102011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1513 when checking :margin (Bug#9390).
1514 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1515 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1516 so that the name doesn't mislead. All uses changed.
1517
6bc8cd65
JB
15182011-08-28 Johan Bockgård <bojohan@gnu.org>
1519
1520 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1521 set_tty_hooks.
1522
dca4927e
EZ
15232011-08-27 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (move_it_to): Don't bail out early when reaching
1526 position beyond to_charpos, if we are scanning backwards.
1527 (move_it_vertically_backward): When DY == 0, make sure we get to
1528 the first character in the line after the newline.
1529
f2cad773
PE
15302011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1531
1532 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1533 (ccl_driver): Do not generate an out-of-range pointer.
1534 (Fccl_execute_on_string): Remove unnecessary check for
1535 integer overflow, noted by Stefan Monnier in
1536 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1537 Remove a FIXME that didn't need fixing.
1538 Simplify the newly-introduced buffer reallocation code.
1539
0cae2cdb
JB
15402011-08-27 Juanma Barranquero <lekktu@gmail.com>
1541
1542 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1543
5fc295a4 15442011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1545
70c60eb2 1546 Integer and memory overflow issues (Bug#9196).
726e0ab1 1547
d31850da
PE
1548 * doc.c (get_doc_string): Rework so that
1549 get_doc_string_buffer_size is the actual buffer size, rather than
1550 being 1 less than the actual buffer size; this makes xpalloc more
1551 convenient.
1552
a69fbedb
PE
1553 * image.c (x_allocate_bitmap_record, cache_image):
1554 * xselect.c (Fx_register_dnd_atom):
1555 Simplify previous changes by using xpalloc.
1556
fe5c5d37
PE
1557 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1558 since either will do and ptrdiff_t is convenient with xpalloc.
1559
0065d054
PE
1560 * charset.c (charset_table_size)
1561 (struct charset_sort_data.priority): Now ptrdiff_t.
1562 (charset_compare): Don't overflow if priorities differ greatly.
1563 (Fsort_charsets): Don't assume list length fits in int.
1564 Check for size-calculation overflow when allocating sort data.
1565 (syms_of_charset): Allocate an initial charset table that is
1566 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1567
1568 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1569
1570 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1571 The actual value is always <= INT_MAX, and leaving it unsigned made
1572 overflow checking harder.
1573
1574 * dispextern.h (struct glyph_matrix.rows_allocated)
1575 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1576 with xpalloc. The values are still always <= INT_MAX.
1577
1578 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1579
1580 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1581 (SAFE_NALLOCA): New macro.
1582
1583 * region-cache.c (struct boundary.pos, find_cache_boundary)
1584 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1585 (set_cache_region, invalidate_region_cache)
1586 (revalidate_region_cache, know_region_cache, region_cache_forward)
1587 (region_cache_backward, pp_cache):
1588 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1589 so that ptrdiff_t * can be passed to xpalloc.
1590 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1591 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1592 (pp_cache): Don't assume cache_len fits in int.
1593 * region-cache.h: Adjust extern decls to match.
1594
1595 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1596 EMACS_INT, since either will do, for xpalloc.
1597
1598 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1599 (xnmalloc, xnrealloc, xpalloc): New functions.
1600
726e0ab1
PE
1601 * bidi.c (bidi_shelve_header_size): New constant.
1602 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1603 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1604
51f30bc5 1605 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1606 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1607 (overlay_strings):
1608 Don't update size of array until after memory allocation succeeds,
1609 because xmalloc/xrealloc may not return.
0065d054
PE
1610 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1611 now that we have proper integer overflow checking.
1612 (record_overlay_string, overlay_strings): Catch overflows when
1613 calculating size of overlay_str_buf.
726e0ab1 1614
0065d054
PE
1615 * callproc.c (Fcall_process): Check for size overflow when
1616 calculating size of args2.
1617 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1618 Normally we prefer signed values, but sticking with ptrdiff_t would
1619 require adding more-complicated checks.
726e0ab1
PE
1620
1621 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1622 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1623 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1624 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1625
1626 * character.c (Fstring): Check for size-calculation overflow.
1627
1628 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1629 unnecessary integer overflow. Check for size overflow.
1630 (encode_coding_object): Don't update size until xmalloc succeeds.
1631
1632 * composite.c (get_composition_id): Check for overflow in glyph
1633 length calculations.
1634
1635 Integer and memory overflow fixes for display code.
1636 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1637 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1638 (scrolling_window): Check for overflow in size calculations.
1639 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1640 Don't assume glyph table len fits in int.
1641 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1642 (row_table_size): Now ptrdiff_t, not int.
1643 (scrolling_window): Avoid overflow in size calculations.
1644 Don't update size until allocation succeeds.
1645 * fns.c (concat): Check for overflow in size calculations.
1646 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1647 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1648 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1649
1650 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1651 (get_doc_string): Check for size calculation overflow.
1652 Don't update size until allocation succeeds.
1653 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1654 EMACS_INT, where ptrdiff_t will do.
1655 (Fsubstitute_command_keys): Check for string overflow.
1656
1657 * editfns.c (set_time_zone_rule): Don't assume environment length
1658 fits in int.
1659 (message_length): Now ptrdiff_t, not int.
1660 (Fmessage_box): Don't update size until allocation succeeds.
1661 Don't assume message length fits in int.
1662 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1663
0065d054
PE
1664 * emacs.c (main): Do not reallocate argv, since there is a null at
1665 the end that can be overwritten, and this way there's no need to
1666 worry about size-calculation overflow.
1667 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1668
1669 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1670 alloc succeeds.
1671 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1672
1673 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1674 (x_set_scroll_bar_width, x_figure_window_size):
1675 Check for integer overflow.
1676 (x_set_alpha): Do not assume XINT fits in int.
1677
1678 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1679 This is for the members text_lines, text_cols, total_lines, total_cols,
1680 where the system imposes an 'int' limit.
1681
1682 * fringe.c (Fdefine_fringe_bitmap):
1683 Don't update size until alloc works.
1684
1685 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1686 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1687
1688 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1689 Check for size-calculation overflow.
1690 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1691 do, as we prefer signed integers.
1692 (id_to_widget.max_size, id_to_widget.used)
1693 (xg_store_widget_in_map, xg_remove_widget_from_map)
1694 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1695 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1696 Use and return ptrdiff_t, not int.
1697 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1698 * gtkutil.h: Change prototypes to match the above.
1699
1700 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1701 are duplicate now that they've been promoted to lisp.h.
1702 (x_allocate_bitmap_record, x_alloc_image_color)
1703 (make_image_cache, cache_image, xpm_load):
1704 Don't update size until alloc is done.
1705 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1706 (x_detect_edges):
3256efce 1707 Check for size calculation overflow.
726e0ab1
PE
1708 (ct_colors_allocated_max): New constant.
1709 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1710 overflow.
3256efce 1711
726e0ab1
PE
1712 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1713 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1714 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1715 Use ptrdiff_t, not int, to count maps.
1716 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1717 calculations. Don't update size until allocation succeeds.
1718 Redo calculations to avoid overflow.
726e0ab1
PE
1719 * keyboard.h: Change prototypes to match the above.
1720
1721 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1722 to count maps.
1723 (current_minor_maps): Check for size calculation overflow.
1724 * keymap.h: Change prototypes to match the above.
1725
1726 * lread.c (read1, init_obarray): Don't update size until alloc done.
1727
1728 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1729 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1730
726e0ab1
PE
1731 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1732 Now ptrdiff_t, not int.
1733 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1734 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1735
1736 * process.c (Fnetwork_interface_list): Check for overflow
1737 in size calculation.
1738
1739 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1740
1741 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1742 overflow. Don't bother calling xmalloc when xrealloc will do.
1743
1744 * search.c (Freplace_match): Check for size calculation overflow.
1745 (Fset_match_data): Don't assume list lengths fit in 'int'.
1746
1747 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1748 for command line length. Do not attempt to address one before the
1749 beginning of an array, as that's not portable.
1750
1751 * term.c (max_frame_lines): Remove; unused.
1752 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1753 not int.
1754 (encode_terminal_code, calculate_costs): Check for size
1755 calculation overflow.
1756 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1757 table lengths and related sizes. Don't update size until alloc
1758 done. Redo calculations to avoid overflow.
1759 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1760
1761 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1762 subtracting pointers.
1763 (gobble_line): Check for overflow more carefully. Don't update size
1764 until alloc done.
1765
1766 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1767 Don't update size until alloc done.
1768 Redo size calculations to avoid overflow.
1769 Check for size calculation overflow.
0065d054 1770 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1771
1772 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1773 Use ptrdiff_t, not int, for sizes.
1774 (store_mode_line_noprop_char): Don't update size until alloc done.
1775
0065d054
PE
1776 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1777 Use ptrdiff_t, not int, for sizes.
1778 (Finternal_make_lisp_face, cache_face):
1779 Check for size calculation overflow.
1780 (cache_face): Treat size calculation overflows as if they were
1781 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1782
1783 * xfns.c (x_encode_text, x_set_name_internal)
1784 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1785 sizes, since they can exceed INT_MAX in size. Check for size
1786 calculation overflow.
1787
0065d054
PE
1788 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1789 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1790 Don't update size until alloc done.
1791
0065d054 1792 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1793 as sprintf is limited to int lengths.
1d526e2f 1794
252c5ee1
PE
1795 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1796 (X_LONG_MIN): New macros.
864d7ce7
PE
1797 Use them to make the following changes clearer.
1798 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1799 This change doesn't affect the value now, but it may help remind
1800 future maintainers not to raise the value too much later.
1801 (SELECTION_QUANTUM): Remove, replacing with ...
1802 (selection_quantum): ... new function, which avoids overflow.
1803 All uses changed.
1804 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1805 assumption that selection length fits in 'int'.
1806 (x_reply_selection_request, x_handle_selection_request)
1807 (x_get_window_property, receive_incremental_selection)
1808 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1809 (lisp_data_to_selection_data, clean_local_selection_data):
1810 Use ptrdiff_t, not int, to record length of selection.
1811 (x_reply_selection_request, x_get_window_property)
1812 (receive_incremental_selection, x_property_data_to_lisp):
1813 Redo calculations to avoid overflow.
1814 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1815 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1816 something.
1817 (x_get_window_property, receive_incremental_selection)
1818 (lisp_data_to_selection_data, x_property_data_to_lisp):
1819 Check for size-calculation overflow.
1820 (x_get_window_property, receive_incremental_selection)
1821 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1822 Don't store size until memory allocation succeeds.
1823 (x_get_window_property): Plug memory leak on memory exhaustion.
1824 Don't double-block input; malloc is safe here. Don't assume 2**34
1825 - 4 fits in unsigned long. Add an xassert to check
1826 XGetWindowProperty overflow. Be more careful about overflow
1827 calculations, and distinguish size from memory overflow better.
1828 (receive_incremental_selection): When tracing, don't assume
1829 unsigned int is less than INT_MAX.
1830 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1831 harmful) conversions of unsigned short to int.
1832 (lisp_data_to_selection_data): Don't assume that integers
1833 in the range -65535 through -1 fit in an X unsigned short.
1834 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1835 result parameters unless successful. Rely on cons_to_unsigned
1836 to report problems with elements; the old code wasn't right anyway.
1837 (x_check_property_data): Check for int overflow; we cannot use
1838 a wider type due to X limits.
1839 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1840
726e0ab1 1841 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1842
0065d054
PE
1843 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1844 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1845 (x_color_cells): Don't store size until memory allocation succeeds.
1846 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1847 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1848 (x_term_init): Don't assume length fits in int (sprintf is limited
1849 to int size).
bc18e09d 1850
ebfa62c0
PE
1851 Use ptrdiff_t for composition IDs.
1852 * character.c (lisp_string_width):
1853 * composite.c (composition_table_size, n_compositions)
1854 (get_composition_id, composition_gstring_from_id):
1855 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1856 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1857 * window.c (Frecenter):
1858 Use ptrdiff_t, not int, for composition IDs.
1859 * composite.c (get_composition_id): Check for integer overflow.
1860 * composite.h: Adjust prototypes to match the above changes.
1861
d3411f89
PE
1862 Use ptrdiff_t for hash table indexes.
1863 * category.c (hash_get_category_set):
1864 * ccl.c (ccl_driver):
1865 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1866 * coding.c (coding_system_charset_list, detect_coding_system):
1867 * coding.h (struct coding_system.id):
1868 * composite.c (get_composition_id, gstring_lookup_cache):
1869 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1870 * image.c (xpm_get_color_table_h):
1871 * lisp.h (hash_lookup, hash_put):
1872 * minibuf.c (Ftest_completion):
1873 Use ptrdiff_t for hash table indexes, not int (which is too
1874 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1875 32-bit --with-wide-int hosts).
1876
e097a6fa
PE
1877 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1878 Add a FIXME comment about memory leaks.
1879 (syms_of_charset): Don't assume xmalloc returns.
1880
5637687f
PE
1881 Don't assume that stated character widths fit in int.
1882 * character.c (Fchar_width, c_string_width, lisp_string_width):
1883 * character.h (CHAR_WIDTH):
1884 * indent.c (MULTIBYTE_BYTES_WIDTH):
1885 Use sanitize_char_width to avoid undefined and/or bad behavior
1886 with outlandish widths.
a66cfb1c 1887 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1888 now that we have two such functions. All uses changed.
1889 (sanitize_char_width): New inline function.
1890
a2271ba2
PE
1891 Don't assume that tab-width fits in int.
1892 * character.h (sanitize_width): New inline function.
1893 (SANE_TAB_WIDTH): New macro.
1894 (ASCII_CHAR_WIDTH): Use it.
1895 * indent.c (sane_tab_width): Remove. All uses replaced by
1896 SANE_TAB_WIDTH (current_buffer).
1897 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1898
18c52557
PE
1899 * fileio.c: Integer overflow issues with file modes.
1900 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1901
caeeedc1
PE
1902 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1903 Remove unreachable code.
1904 (read_hex, load_charset_map_from_file): Check for integer overflow.
1905
50849c52
PE
1906 * xterm.c: don't go over XClientMessageEvent limit
1907 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1908 (x_send_scroll_bar_event): Likewise. Check that the size does not
1909 exceed limits imposed by XClientMessageEvent, as well as the usual
1910 ptrdiff_t and size_t limits.
1911
b13995db
PE
1912 * keyboard.c: Overflow, signedness and related fixes.
1913 (make_lispy_movement): Use same integer type in forward decl
1914 that is used in the definition.
1915 (read_key_sequence, keyremap_step):
1916 Change bufsize argument back to int, undoing my 2011-03-30 change.
1917 We prefer signed types, and int is wide enough here.
1918 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1919 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1920 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1921 length, not size_t. Use ptrdiff_t for index, not int.
1922 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1923 possibility of integer overflow.
1924
13464394
PE
1925 Overflow, signedness and related fixes for images.
1926
1927 * dispextern.h (struct it.stack[0].u.image.image_id)
1928 (struct_it.image_id, struct image.id, struct image_cache.size)
1929 (struct image_cache.used, struct image_cache.ref_count):
1930 * gtkutil.c (update_frame_tool_bar):
1931 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1932 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1933 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1934 * nsmenu.m (update_frame_tool_bar):
1935 * xdisp.c (calc_pixel_width_or_height):
1936 * xfns.c (image_cache_refcount):
1937 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1938 on typical 64-bit hosts.
1939
1940 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1941 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1942 Omit unnecessary casts to int.
1943 (parse_image_spec): Check that integers fall into 'int' range
1944 when the callers expect that.
1945 (image_ascent): Redo ascent calculation to avoid int overflow.
1946 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1947 (lookup_image): Remove unnecessary tests.
1948 (xbm_image_p): Locals are now of int, not EMACS_INT,
1949 since parse_image_check makes sure they fit into int.
1950 (png_load, gif_load, svg_load_image):
1951 Prefer int to unsigned where either will do.
1952 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1953 old tiff_error_handler and tiff_warning_handler.
1954 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1955 stack buffer overflows. It uses only the features of vsnprintf
1956 that are common to both POSIX and native Microsoft.
1957 (tiff_error_handler, tiff_warning_handler): Use it.
1958 (tiff_load, gif_load, imagemagick_load_image):
1959 Don't assume :index value fits in 'int'.
1960 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1961 (imagemagick_load_image): Check that crop parameters fit into
1962 the integer types that MagickCropImage accepts. Don't assume
1963 Vimagemagick_render_type has a nonnegative value. Don't assume
1964 size_t fits in 'long'.
1965 (gs_load): Use printmax_t to print the widest integers possible.
1966 Check for integer overflow when computing image height and width.
1967
c11821d4
EZ
19682011-08-26 Eli Zaretskii <eliz@gnu.org>
1969
1970 * xdisp.c (redisplay_window): Don't force window start if point
1971 will be invisible in the resulting window. (Bug#9324)
1972
0c95fcf7
EZ
19732011-08-25 Eli Zaretskii <eliz@gnu.org>
1974
1975 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1976 the display spec is of the form `(space ...)'.
1977 (handle_display_spec): Return the value returned by
1978 handle_single_display_spec, not just 1 or zero.
1979 (handle_single_display_spec): If the display spec is of the form
1980 `(space ...)', and specifies display in the text area, return 2
1981 rather than 1.
fee65a97 1982 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1983 accurately, and prefer exact match for point under bidi.
1984 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1985
1986 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1987 into disp_prop; all users changed.
1988
1989 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1990 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1991 for the text covered by the display property.
1992
e4ed06f1
CY
19932011-08-25 Chong Yidong <cyd@stupidchicken.com>
1994
1995 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1996 Change return value to nil.
1997 (Frecord_buffer): Delete unused function.
1998
f67cdd7f
EZ
19992011-08-24 Eli Zaretskii <eliz@gnu.org>
2000
5980d4c6
EZ
2001 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2002 buffers, return left-to-right.
8610fe8b
EZ
2003 (set_cursor_from_row): Consider candidate row a win if its glyph
2004 represents a newline and point is on that newline. Fixes cursor
2005 positioning on the newline at EOL of R2L text within L2R
2006 paragraph, and vice versa.
2007 (try_cursor_movement): Check continued rows, in addition to
2008 continuation rows. Fixes unwarranted scroll when point enters a
2009 continued line of R2L text within an L2R paragraph, or vice versa.
2010 (cursor_row_p): Consider the case of point being equal to
2011 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2012 from the end of a short line to the beginning of a continued line
2013 of R2L text within L2R paragraph.
2014 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2015 composed characters.
5980d4c6 2016
f67cdd7f
EZ
2017 * bidi.c (bidi_check_type): Use xassert.
2018 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2019 members.
2020
bca633fb
EZ
20212011-08-23 Eli Zaretskii <eliz@gnu.org>
2022
2023 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2024 a character.
2025
4a5885a7
CY
20262011-08-23 Chong Yidong <cyd@stupidchicken.com>
2027
2028 * nsfont.m (ns_otf_to_script): Fix typo.
2029
0902a04e
KH
20302011-08-22 Kenichi Handa <handa@m17n.org>
2031
2032 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2033 extra slot even if the purpose is char-code-property-table.
2034
1a2e6670
EZ
20352011-08-23 Eli Zaretskii <eliz@gnu.org>
2036
8ddde651
EZ
2037 * xdisp.c (redisplay_window): When computing centering_position,
2038 account for the height of the header line. (Bug#8874)
2039
425cc014
EZ
2040 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2041 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2042 candidate is selected by the mouse, and that candidate has a
2043 composed character under the mouse.
2044
1a2e6670
EZ
2045 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2046 coordinates reported by pos-visible-in-window-p for a composed
2047 character in column zero.
2048
8b76d6f8
SM
20492011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2050
2051 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2052
dac347dd
EZ
20532011-08-22 Eli Zaretskii <eliz@gnu.org>
2054
2055 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2056 consider it a hit if to_charpos is anywhere in the range of the
2057 composed buffer positions.
2058
e013fb34
CY
20592011-08-22 Chong Yidong <cyd@stupidchicken.com>
2060
2061 * image.c (gif_load): Don't assume that each subimage has the same
2062 dimensions as the base image. Handle disposal method that is
2063 "undefined" by the gif spec (Bug#9335).
2064
bd1ba3e8
CY
20652011-08-20 Chong Yidong <cyd@stupidchicken.com>
2066
2067 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2068 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2069
54a1215b
EZ
20702011-08-19 Eli Zaretskii <eliz@gnu.org>
2071
823564e5
EZ
2072 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2073 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2074 from an Org mode buffer to a Speedbar frame.
2075
54a1215b
EZ
2076 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2077 a composition, take its buffer position from IT->cmp_it.charpos.
2078 Fixes cursor positioning at the beginning of a line that begins
2079 with a composed character.
2080
9778ebcc
EZ
20812011-08-18 Eli Zaretskii <eliz@gnu.org>
2082
0be6ee06
EZ
2083 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2084 character bidirectional type, use STRONG_L instead. Fixes crashes
2085 in a buffer produced by `describe-categories'.
2086
9778ebcc
EZ
2087 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2088 members before the level stack, so they would be saved and
2089 restored when copying iterator state. Fixes incorrect reordering
2090 around TABs covered by display properties.
2091
156bffbe
AS
20922011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2093
6b02f655 2094 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2095
72ad093b
CY
20962011-08-17 Chong Yidong <cyd@stupidchicken.com>
2097
2098 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2099 (internal_condition_case_2, internal_condition_case_n):
2100 Remove unnecessary aborts (Bug#9081).
72ad093b 2101
35774242
EZ
21022011-08-17 Eli Zaretskii <eliz@gnu.org>
2103
2104 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2105 has no `load' handler, try opening the file locally. (Bug#9311)
2106
db76dd85
KB
21072011-08-16 Ken Brown <kbrown@cornell.edu>
2108
2109 * gmalloc.c: Expand comment.
2110
b215eee5
EZ
21112011-08-16 Eli Zaretskii <eliz@gnu.org>
2112
2113 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2114 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2115
a4579d33
KB
21162011-08-16 Ken Brown <kbrown@cornell.edu>
2117
2118 Fix memory allocation problems in Cygwin build (Bug#9273).
2119
2120 * unexcw.c ( __malloc_initialized): Declare external variable.
2121 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2122
8b76d6f8
SM
2123 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2124 New variables.
a4579d33
KB
2125 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2126 dumped emacs.
2127 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2128 in the static heap.
2129 [CYGWIN] (special_realloc): New function.
2130 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2131 requests to realloc storage in the static heap.
2132
3ebec551
PE
21332011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2134
2135 * bidi.c (bidi_initialize): Remove unused local.
2136
9fd8be00
EZ
21372011-08-15 Eli Zaretskii <eliz@gnu.org>
2138
6b02f655
SM
2139 * bidimirror.h:
2140 * biditype.h: Remove file.
2141 * makefile.w32-in ($(BLD)/bidi.$(O)):
2142 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2143
2144 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2145
2146 * chartab.c: Improve commentary for the uniprop_table API.
2147
32413314
EZ
2148 * bidi.c (bidi_paragraph_init): Support zero value of
2149 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2150 (bidi_initialize): Use uniprop_table instead of including
2151 biditype.h and bidimirror.h.
32413314 2152
9fd8be00
EZ
2153 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2154 coordinates of the iterator when restoring from ppos_it.
2155 (Bug#9296)
2156
5cf2b69b
KH
21572011-08-14 Kenichi Handa <handa@m17n.org>
2158
2159 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2160 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2161
daf17d00
EZ
21622011-08-14 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (move_it_in_display_line_to): Don't invoke
2165 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2166 ppos_it. Fixes vertical cursor motion when line beginning is
2167 covered by an image. (Bug#9296)
2168
08e3161a
JD
21692011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2170
2171 * nsterm.h (ns_run_ascript): Declare.
2172 (NSAPP_DATA2_RUNASSCRIPT): Define.
2173
2174 * nsfns.m (as_script, as_result, as_status): New static variables.
2175 (ns_run_ascript): New function.
5e617bc2 2176 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2177 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2178 the event loop. Get status from as_status (Bug#7276).
2179
2180 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2181 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2182 the event loop (Bug#7276).
2183
a3720aa2
AS
21842011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2185
2186 * gnutls.c (QCgnutls_bootprop_priority)
2187 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2188 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2189 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2190 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2191 (QCgnutls_bootprop_verify_hostname_error)
2192 (QCgnutls_bootprop_callbacks_verify): Rename from
2193 Qgnutls_bootprop_..., all uses changed.
2194
2195 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2196 uses changed.
2197
0a0d27fb
PE
21982011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2199
19d5c50c
PE
2200 * xfaces.c (Qframe_set_background_mode): Now static.
2201 * dispextern.h (Qframe_set_background_mode): Remove decl.
2202
0a0d27fb
PE
2203 * process.c (Fnetwork_interface_info): Declare local only if needed.
2204
377538cb
JD
22052011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2206
2207 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2208 (Fnetwork_interface_list): Allocate in increments of bytes instead
2209 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2210 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2211 sockaddr.
2212 (struct ifflag_def): notrailers is smart on OSX.
2213 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2214 Get hardware address with getifaddrs if available.
2215
08fff70c
EZ
22162011-08-12 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (iterate_out_of_display_property): xassert that
2219 IT->position is set to within IT->object's boundaries. Break from
2220 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2221 when IT->position is set up wrongly due to some bug.
2222 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2223 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2224 entry. Force push_it to save on the stack the current
2225 buffer/string position, to be restored by pop_it. Fix flags in
2226 the iterator structure wrt the object coming from a display
2227 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2228 properties. (Bug#9284)
2229
7be1c708 22302011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2231
7be1c708
CY
2232 * fontset.c (fontset_get_font_group): Add proper type checks.
2233 (Bug#9172)
aac0c6e3 2234
7be1c708 22352011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2236
7be1c708
CY
2237 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2238 and LC_VERSION_MIN_MACOSX.
2239 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2240 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2241
97bb72a6
EZ
22422011-08-08 Eli Zaretskii <eliz@gnu.org>
2243
2244 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2245 no-display-properties-and-no-overlays under bidi display.
2246 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2247 properties and overlays.
97bb72a6 2248
d5617611
CY
22492011-08-08 Chong Yidong <cyd@stupidchicken.com>
2250
37e11a63
CY
2251 * editfns.c (Fset_time_zone_rule): Document relationship with the
2252 setenv function.
2253
d5617611
CY
2254 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2255 the font entity extracted from the cache (Bug#8109).
2256
58872834
CY
22572011-08-07 Chong Yidong <cyd@stupidchicken.com>
2258
2259 * composite.c (autocmp_chars): Don't reset point. That is done by
2260 restore_point_unwind (Bug#5984).
2261
75bfc667
JL
22622011-08-07 Juri Linkov <juri@jurta.org>
2263
2264 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2265 to show the arg `TIME' instead of `TIMEVAL'.
2266
d1410150
EZ
22672011-08-06 Eli Zaretskii <eliz@gnu.org>
2268
2269 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2270 display property strides EOL and includes a newline, as in
2271 longlines-mode. (Bug#9254)
75b771e4
EZ
2272 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2273 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2274
2275 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2276 is non-zero, even if the data buffer is NULL. Fixes a crash in
2277 vertical-motion with longlines-mode. (Bug#9254)
2278
35928349
EZ
22792011-08-05 Eli Zaretskii <eliz@gnu.org>
2280
ec7cc85b
EZ
2281 * bidi.c <bidi_cache_total_alloc>: Now static.
2282 (bidi_initialize): Initialize bidi_cache_total_alloc.
2283
8b76d6f8 2284 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2285 cache. (Bug#9221)
2286
2287 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2288 amount allocated this far in `bidi_cache_total_alloc'.
2289 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2290 non-zero, only free the data buffer without restoring the cache
2291 contents. All callers changed.
2292
2293 * dispextern.h (bidi_unshelve_cache): Update prototype.
2294
2295 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2296 (move_it_in_display_line, move_it_to)
2297 (move_it_vertically_backward, move_it_by_lines): Replace the call
2298 to xfree to an equivalent call to bidi_unshelve_cache.
2299 (move_it_in_display_line_to): Fix logic of returning
412b6358 2300 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2301
e2e2423b
EZ
23022011-08-05 Eli Zaretskii <eliz@gnu.org>
2303
2304 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2305 came from a string character with a `cursor' property. (Bug#9229)
2306
ae9e757a
JD
23072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2308
2309 * Makefile.in (LIB_PTHREAD): New variable.
2310 (LIBES): Add LIB_PTHREAD (Bug#9216).
2311
2312 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2313 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2314
213bd7f2
AS
23152011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2316
6b02f655 2317 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2318
99aaf75f
JD
23192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2320
2321 * xterm.c (x_find_topmost_parent): New function.
2322 (x_set_frame_alpha): Find topmost parent window with
2323 x_find_topmost_parent and set the property there also (bug#9181).
2324 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2325
c74e9d86
PE
23262011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2327
2328 * callproc.c (Fcall_process): Avoid vfork clobbering
2329 the local vars buffer, coding_systems, current_dir.
2330
640c8776
SM
23312011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2332
2333 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2334
f26d0e4c
PE
23352011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2336
8a10d76c
PE
2337 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2338 so that it is not optimized away.
2339
f26d0e4c
PE
2340 * xdisp.c (compute_display_string_pos): Remove unused local.
2341
55439c61
EZ
23422011-08-02 Eli Zaretskii <eliz@gnu.org>
2343
2344 Fix slow cursor motion and scrolling in large buffers with
2345 selective display, like Org Mode buffers. (Bug#9218)
2346
2347 * dispextern.h (struct bidi_it): New member disp_prop_p.
2348
2349 * xdisp.c: Remove one-slot cache of display string positions.
2350 (compute_display_string_pos): Accept an additional argument
5e617bc2 2351 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2352 for a display string or property. If found, set DISP_PROP_P
2353 non-zero.
2354
2355 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2356 DISP_PROP_P, and pass it to compute_display_string_pos.
2357 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2358 non-zero. All callers of bidi_fetch_char changed.
2359
fb33fa43
SM
23602011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2361
2362 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2363
b099e063
DM
23642010-12-03 Don March <don@ohspite.net>
2365
2366 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2367 last character M-[char] is translated to ESC [char] (bug#7541).
2368
5cc7f7af
KH
23692011-08-02 Kenichi Handa <handa@m17n.org>
2370
d0fffa3f 2371 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2372
2373 * chartab.c (uniprop_table): Make it non-static.
2374
525d5e6e
EZ
23752011-08-01 Eli Zaretskii <eliz@gnu.org>
2376
2377 * xdisp.c (forward_to_next_line_start): Accept additional argument
2378 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2379 on the newline.
2380 (reseat_at_next_visible_line_start): Use the bidi iterator state
2381 returned by forward_to_next_line_start to restore the state of
2382 it->bidi_it after backing up to previous newline. (Bug#9212)
2383
31011111
AS
23842011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2385
2386 * regex.c (re_comp): Protoize.
2387 (re_exec): Fix return type.
2388 (regexec): Fix type of `ret'. (Bug#9203)
2389
476371c4
PE
23902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2391
e5d76069
PE
2392 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2393 This is needed if max-image-size is a floating-point number.
2394
9a79b20c
AS
23952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2396
2397 * print.c (print_object): Print empty symbol as ##.
2398
2399 * lread.c (read1): Read ## as empty symbol.
2400
d8c2fa78
AA
24012011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2402
2403 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2404 setting frame foreground color (Bug#9175).
2405 (x_set_background_color): Likewise.
2406
ffe57a7a
AA
2407 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2408 contents (Bug#9176).
2409 (EmacsTooltip -init): Remove bezels and add shadows to
2410 tooltip windows.
2411
bf3492a5
AA
2412 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2413 or scroll bar (Bug#8470).
2414
d55e9c53
AA
2415 * nsfont.m (nsfont_open): Remove assignment to voffset and
2416 unnecessary vars hshink, expand, hd, full_height, min_height.
2417 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2418
2419 * nsterm.h (nsfont_info): Remove voffset field.
2420
d8c2fa78 24212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2422
2423 Implement strike-through and overline on NextStep (Bug#8863).
2424
2425 * nsfont.m (nsfont_open): Use underline position provided by font,
2426 instead of hard-coded value of 2.
2427 (nsfont_draw): Call ns_draw_text_decoration instead.
2428
2429 * nsterm.h: Add declaration for ns_draw_text_decoration.
2430
2431 * nsterm.m (ns_draw_text_decoration): New function for drawing
2432 underline, overline, and strike-through.
2433 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2434 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2435 accommodate underlining, etc.
4843aac3 2436
4cc60b9b
EZ
24372011-07-28 Eli Zaretskii <eliz@gnu.org>
2438
bc7ece87
EZ
2439 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2440 default.
4cc60b9b 2441
476371c4
PE
24422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2443
66606eea
PE
2444 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2445 Without this fix, if a signal arrives just after memory fills up,
2446 'malloc' might be invoked reentrantly.
2447
476371c4
PE
2448 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2449 In other words, assume that every image size is allowed, on non-X
2450 hosts. This assumption is probably wrong, but it lets Emacs compile.
2451
f3fcc40d
AS
24522011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2453
2454 * regex.c (re_iswctype): Convert return values to boolean.
2455
350c992f
EZ
24562011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2457
2458 * xdisp.c (compute_display_string_pos): Don't use cached display
2459 string position if the buffer had its restriction changed.
2460 (Bug#9184)
2461
5266b4bb
PE
24622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2465
2573a837 24662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2467
41f55ccd 2468 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2469
39e378da
PE
2470 * bidi.c: Integer size and overflow fixes.
2471 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2472 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2473 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2474 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2475 (bidi_find_other_level_edge):
2476 Use ptrdiff_t instead of EMACS_INT where either will do.
2477 This works better on 32-bit hosts configured --with-wide-int.
2478 (bidi_cache_ensure_space): Check for size-calculation overflow.
2479 Use % rather than repeated addition, for better worst-case speed.
2480 Don't set bidi_cache_size until after xrealloc returns, because it
2481 might not return.
2482 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2483 (bidi_cache_ensure_space): Also check that the bidi cache size
2484 does not exceed that of the largest Lisp string or buffer. See Eli
2485 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2486
5e927815
PE
2487 * alloc.c (__malloc_size_t): Remove.
2488 All uses replaced by size_t. See Andreas Schwab's note
2489 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2490
ca4aa935
PE
2491 * image.c: Improve checking for integer overflow.
2492 (check_image_size): Assume that f is nonnull, since
2493 it is always nonnull in practice. This is one less thing to
2494 worry about when checking for integer overflow later.
2495 (x_check_image_size): New function, which checks for integer
2496 overflow issues inside X.
2497 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2498 This removes the need for a memory_full check.
2499 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2500 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2501 (xbm_read_bitmap_data): Change locals back to 'int', since
2502 their values must fit in 'int'.
2503 (xpm_load_image, png_load, tiff_load):
2504 Invoke x_create_x_image_and_pixmap earlier,
2505 to avoid much needless work if the image is too large.
2506 (tiff_load): Treat overly large images as if
2507 x_create_x_image_and_pixmap failed, not as malloc failures.
2508 (gs_load): Use x_check_image_size.
2509
5f8f9cc2
PE
2510 * gtkutil.c: Omit integer casts.
2511 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2512 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2513
5adf60bc
PE
2514 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2515
c8907a93
PE
2516 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2517 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2518 would wrongly return t on a 64-bit host.
2519
e3c25c68
PE
2520 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2521 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2522 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2523 and therefore cause GCC to emit a bogus diagnostic in some cases.
2524
3f791afe
PE
2525 * image.c: Integer signedness and overflow and related fixes.
2526 This is not an exhaustive set of fixes, but it's time to
2527 record what I've got.
2528 (lookup_pixel_color, check_image_size): Remove redundant decls.
2529 (check_image_size): Don't assume that arbitrary EMACS_INT values
2530 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2531 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2532 (tiff_load, imagemagick_load_image):
2533 Check for overflow in size calculations.
2534 (x_create_x_image_and_pixmap): Remove unnecessary test for
2535 xmalloc returning NULL; that can't happen.
2536 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2537 (xpm_color_bucket): Use better integer hashing function.
2538 (xpm_cache_color): Don't possibly over-allocate memory.
2539 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2540 (gif_memory_source):
2541 Use ptrdiff_t, not int or size_t, to record sizes.
2542 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2543 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2544 either works, as we prefer signed integers.
2545 (tiff_read_from_memory, tiff_write_from_memory):
2546 Return tsize_t, not size_t, since that's what the TIFF API wants.
2547 (tiff_read_from_memory): Don't fail simply because the read would
2548 go past EOF; instead, return a short read.
2549 (tiff_load): Omit no-longer-needed casts.
2550 (Fimagemagick_types): Don't assume size fits into 'int'.
2551
3cc5a532
PE
2552 Improve hashing quality when configured --with-wide-int.
2553 * fns.c (hash_string): New function, taken from sxhash_string.
2554 Do not discard information about ASCII character case; this
2555 discarding is no longer needed.
2556 (sxhash-string): Use it. Change sig to match it. Caller changed.
2557 * lisp.h: Declare it.
2558 * lread.c (hash_string): Remove, since we now use fns.c's version.
2559 The fns.c version returns a wider integer if --with-wide-int is
2560 specified, so this should help the quality of the hashing a bit.
2561
b312a492
PE
2562 * emacs.c: Integer overflow minor fix.
2563 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2564 Define only if GNU_LINUX.
2565 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2566
dfd153ae
PE
2567 * dispnew.c: Integer signedness and overflow fixes.
2568 Remove unnecessary forward decls, that were a maintenance hassle.
2569 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2570 All uses changed.
2571 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2572 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2573 (prepare_desired_row, line_draw_cost):
2574 Use int, not unsigned, where either works.
2575 (save_current_matrix, restore_current_matrix):
2576 Use ptrdiff_t, not size_t, where either works.
2577 (init_display): Check for overflow more accurately, and without
2578 relying on undefined behavior.
2579
a81d11a3
PE
2580 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2581 Remove, replacing with the new symbols in lisp.h. All uses changed.
2582 * fileio.c (make_temp_name):
2583 * filelock.c (lock_file_1, lock_file):
2584 * xdisp.c (message_dolog):
2585 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2586 Use pMd etc. instead.
2587 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2588 replacing the pWIDE etc. symbols removed from editfns.c.
2589
3300e6fd
PE
2590 * keyboard.h (num_input_events): Now uintmax_t.
2591 This is (very slightly) less likely to mess up due to wraparound.
2592 All uses changed.
2593
fd05c7e9
PE
2594 * buffer.c: Integer signedness fixes.
2595 (alloc_buffer_text, enlarge_buffer_text):
2596 Use ptrdiff_t rather than size_t when either will do, as we prefer
2597 signed integers.
2598
903fe15d
PE
2599 * alloc.c: Integer signedness and overflow fixes.
2600 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2601 (__malloc_size_t): Default to size_t, not to int.
2602 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2603 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2604 Prefer ptrdiff_t to size_t when either would do, as we prefer
2605 signed integers.
2606 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2607 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2608 Now const. Initialize with values that are in range even if char
2609 is signed.
2610 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2611 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2612 These functions do the right thing with sizes > 2**32.
2613 (check_depth): Now ptrdiff_t, not int.
2614 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2615 Adjust to new way of storing sizes. Check for size overflow bugs
2616 in rest of code.
2617 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2618 slightly wrong anyway, as it missed one instance of
2619 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2620 (refill_memory_reserve): Omit needless cast to size_t.
2621 (mark_object_loop_halt): Mark as externally visible.
2622
ac82cc6a
PE
2623 * xselect.c: Integer signedness and overflow fixes.
2624 (Fx_register_dnd_atom, x_handle_dnd_message):
2625 Use ptrdiff_t, not size_t, since we prefer signed.
2626 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2627 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2628 x_dnd_atoms_size and x_dnd_atoms_length.
2629
c2d1e36d
PE
2630 * doprnt.c: Prefer signed to unsigned when either works.
2631 * eval.c (verror):
2632 * doprnt.c (doprnt):
2633 * lisp.h (doprnt):
2634 * xdisp.c (vmessage):
2635 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2636 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2637 prefer signed arithmetic to avoid comparison confusion.
2638 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2639 but is a bit tricky.
2640
0e926e56
PE
2641 Assume freestanding C89 headers, string.h, stdlib.h.
2642 * data.c, doprnt.c, floatfns.c, print.c:
2643 Include float.h unconditionally.
2644 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2645 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2646 * regex.c: Likewise for stddef.h, string.h.
2647 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2648 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2649 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2650 (STDC_HEADERS): Remove obsolete defines.
2651 * sysdep.c: Include limits.h unconditionally.
2652
9cfdb3ec
PE
2653 Assume support for memcmp, memcpy, memmove, memset.
2654 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2655 * regex.c (memcmp, memcpy):
2656 Remove; we assume C89 now.
2657
2658 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2659 (__malloc_safe_bcopy): Remove; no longer needed.
2660
cf950e6b 2661 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2662 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2663 well either way, and we prefer signed to unsigned.
2664
dbf38e02
LMI
26652011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2666
2667 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2668 closes the connection while we're reading (bug#9182).
2669
d6f0886c 26702011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2671
d6f0886c
JD
2672 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2673 are specified (Bug#9168).
24e0f6b1 2674
2eb1f9e6
PE
26752011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2676
2677 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2678 Found by GCC static checking and --with-wide-int on a 32-bit host.
2679
22381272 26802011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2681
2682 * xdisp.c (compute_display_string_pos): Fix logic of caching
2683 previous display string position. Initialize cached_prev_pos to
2684 -1. Fixes slow-down at the beginning of a buffer.
2685
f25e39b4
EZ
26862011-07-24 Eli Zaretskii <eliz@gnu.org>
2687
2688 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2689 for attrs[LFACE_FONTSET_INDEX].
2690
04c4b52e
PE
26912011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 * xml.c (parse_region): Remove unused local
2694 that was recently introduced.
2695
c1734fbd
EZ
26962011-07-23 Eli Zaretskii <eliz@gnu.org>
2697
be18c5a5
EZ
2698 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2699 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2700
c1734fbd
EZ
2701 * xdisp.c (move_it_in_display_line_to): Record the best matching
2702 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2703 exit if none of the characters scanned was an exact match.
2704 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2705 when exact match is impossible due to invisible text, and the
2706 lines are truncated.
2707
a258d627
JD
27082011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2709
2710 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2711 for OSX >= 10.7.
2712
b6d5a689
EZ
27132011-07-22 Eli Zaretskii <eliz@gnu.org>
2714
0f74f785
EZ
2715 Fix a significant slow-down of cursor motion with C-n, C-p,
2716 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2717 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2718 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2719 (next_element_from_buffer): Call compute_stop_pos_backwards to
2720 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2721 base_level_stop.
2722 (reseat): Don't look for prev_stop, as that could mean a very long
2723 run.
2724 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2725 <cached_disp_overlay_modiff>: Cache for last found display string
2726 position.
551918c1 2727 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2728 about the same buffer in the same area of character positions, and
2729 the buffer wasn't changed since the time the display string
2730 position was cached.
551918c1 2731
b2d0c91a
EZ
27322011-07-22 Eli Zaretskii <eliz@gnu.org>
2733
2734 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2735 is an integer, which is important for empty lines. (Bug#9149)
2736
043604ee
CY
27372011-07-22 Chong Yidong <cyd@stupidchicken.com>
2738
2739 * frame.c (Fmodify_frame_parameters): In tty case, update the
2740 default face if necessary (Bug#4238).
2741
da4adb04
CY
27422011-07-21 Chong Yidong <cyd@stupidchicken.com>
2743
2744 * editfns.c (Fstring_to_char): No need to explain what a character
2745 is in the docstring (Bug#6576).
2746
9abd0532
LMI
27472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2748
2749 * xml.c (parse_region): Make sure we always return a tree.
2750
36881d16
HK
27512011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2752
2753 * xml.c (parse_region): If a document contains only comments,
2754 return that, too.
2755
1e98674d
LMI
27562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2757
2758 * xml.c (make_dom): Return comments, too.
2759
590bd467
PE
27602011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 Port to OpenBSD.
2763 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2764 and the surrounding thread.
2765 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2766 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2767 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2768 timer goes off.
2769 * s/openbsd.h (BROKEN_SIGIO): Define.
2770 * unexelf.c (unexec) [__OpenBSD__]:
2771 Don't update the .mdebug section of the Alpha COFF symbol table.
2772
f41628b2
LMI
27732011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2774
2775 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2776 (bug#8460).
2777
b59b67c5
PE
27782011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2779
15e3a074
PE
2780 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2781 This fixes some race conditions on the permissions of any newly
2782 created file.
2783
41bed37d
PE
2784 * alloc.c (valid_pointer_p): Use pipe, not open.
2785 This fixes some permissions issues when debugging.
2786
b59b67c5
PE
2787 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2788 If fchown fails to set both uid and gid, try to set just gid,
2789 as that is sometimes allowed. Adjust the file's mode to eliminate
2790 setuid or setgid bits that are inappropriate if fchown fails.
2791
925a6be7
SM
27922011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2793
2794 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2795 to compare Lisp_Objects.
2796 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2797 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2798 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2799
52968808
AS
28002011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2801
0a6a104b
AS
2802 * lread.c (read_integer): Unread even EOF character.
2803 (read1): Likewise. Properly record start position of symbol.
2804
52968808
AS
2805 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2806 symbol character follows.
2807
9e381cdd
PE
28082011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2811 This works around a problem with the previous change to Fcopy_file.
2812 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2813 and without this change, GCC might complain about discarding
2814 fchown's return value.
2815
b5641435
JB
28162011-07-16 Juanma Barranquero <lekktu@gmail.com>
2817
2818 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2819
a8031457
PE
28202011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2823
dd889327
LMI
28242011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2825
750c33f7
LMI
2826 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2827 it's used from the C level.
2828
dd889327
LMI
2829 * process.c: Use the same condition for POLL_FOR_INPUT in both
2830 keyboard.c and process.c (bug#1858).
2831
87e86684
LM
28322011-07-09 Lawrence Mitchell <wence@gmx.li>
2833
2834 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2835 (Fgnutls_boot): Use it.
2836
64348f40
AS
28372011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2838
2839 * doc.c (Fsubstitute_command_keys): Revert last change.
2840
1d698799
LMI
28412011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2842
f863868c
LMI
2843 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2844 quotes the next character, and doesn't affect other longer
2845 sequences (bug#8935).
2846
1d698799
LMI
2847 * lread.c (syms_of_lread): Clarify that is isn't only
2848 `eval-buffer' and `eval-defun' that's affected by
2849 `lexical-binding' (bug#8460).
2850
aa4b6df6
EZ
28512011-07-15 Eli Zaretskii <eliz@gnu.org>
2852
2853 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2854 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2855
5d856da6
PE
28562011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2857
ad6042bb
PE
2858 Fix minor problems found by static checking.
2859 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2860 (elsz): Now a signed constant, not a size_t var. We prefer signed
2861 types to unsigned, to avoid integer comparison confusion. Without
2862 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2863 "cannot optimize loop, the loop counter may overflow", a symptom
2864 of the confusion.
f00bbb22 2865 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2866 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2867
6468f31c
LMI
28682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2869
49080b10
LMI
2870 * search.c (Fre_search_backward): Mention `case-fold-search' in
2871 all the re_search_* functions (bug#8138).
2872
6468f31c
LMI
2873 * keyboard.c (Fopen_dribble_file): Document when the file is
2874 closed (bug#8056).
2875
c965adc5
EZ
28762011-07-14 Eli Zaretskii <eliz@gnu.org>
2877
df9733bf
EZ
2878 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2879 bidi_cache_idx.
2880
0bb23927
EZ
2881 Support bidi reordering of display and overlay strings.
2882 * xdisp.c (compute_display_string_pos)
2883 (compute_display_string_end): Accept additional argument STRING.
2884 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2885 (reseat_to_string): Initialize bidi_it->string.s and
2886 bidi_it->string.schars.
2887 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2888 NULL (avoids a crash in bidi_paragraph_init).
2889 Initialize itb.string.lstring.
0bb23927
EZ
2890 (init_iterator): Call bidi_init_it only of a valid
2891 buffer position was specified. Initialize paragraph_embedding to
2892 L2R.
2893 (reseat_to_string): Initialize the bidi iterator.
2894 (display_string): If we need to ignore text properties of
2895 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2896 original value of -1 will not work with bidi.)
2897 (compute_display_string_pos): First arg is now struct
2898 `text_pos *'; all callers changed. Support display properties on
2899 Lisp strings.
2900 (compute_display_string_end): Support display properties on Lisp
2901 strings.
2902 (init_iterator, reseat_1, reseat_to_string): Initialize the
2903 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2904 when iterating on a string not from display properties).
640c8776
SM
2905 (compute_display_string_pos, compute_display_string_end):
2906 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2907 arrow keys.
2908 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2909 base_level_stop; instead, set base_level_stop to BEGV.
2910 Fixes crashes in vertical-motion.
0bb23927
EZ
2911 (next_element_from_buffer): Improve commentary for when
2912 the iterator is before prev_stop.
2913 (init_iterator): Initialize bidi_p from the default value of
2914 bidi-display-reordering, not from buffer-local value. Use the
2915 buffer-local value only if initializing for buffer iteration.
2916 (handle_invisible_prop): Support invisible properties on strings
2917 that are being bidi-reordered.
2918 (set_iterator_to_next): Support bidi reordering of C strings and
2919 Lisp strings.
2920 (next_element_from_string): Support bidi reordering of Lisp
2921 strings.
2922 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2923 (display_string): Support display of R2L glyph rows.
2924 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2925 (init_iterator): Don't initialize it->bidi_p for strings
2926 here.
2927 (reseat_to_string): Initialize it->bidi_p for strings here.
2928 (next_element_from_string, next_element_from_c_string)
2929 (next_element_from_buffer): Add xassert's for correspondence
2930 between IT's object being iterated and it->bidi_it.string
2931 structure.
2932 (face_before_or_after_it_pos): Support bidi iteration.
2933 (next_element_from_c_string): Handle the case of the first string
2934 character that is not the first one in the visual order.
2935 (get_visually_first_element): New function, refactored from common
2936 parts of next_element_from_buffer, next_element_from_string, and
2937 next_element_from_c_string.
2938 (tool_bar_lines_needed, redisplay_tool_bar)
2939 (display_menu_bar): Force left-to-right direction. Add a FIXME
2940 comment for making that be controlled by a user option.
2941 (push_it, pop_it): Save and restore the state of the
2942 bidi iterator. Save and restore the bidi_p flag.
2943 (pop_it): Iterate out of display property for string iteration as
2944 well.
2945 (iterate_out_of_display_property): Support iteration over strings.
2946 (handle_single_display_spec): Set up it->bidi_it for iteration
2947 over a display string, and call bidi_init_it.
2948 (handle_single_display_spec, next_overlay_string)
2949 (get_overlay_strings_1, push_display_prop): Set up the bidi
2950 iterator for displaying display or overlay strings.
2951 (forward_to_next_line_start): Don't use the shortcut if
2952 bidi-iterating.
2953 (back_to_previous_visible_line_start): If handle_display_prop
2954 pushed the iterator stack, restore the internal state of the bidi
2955 iterator by calling bidi_pop_it same number of times.
2956 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2957 and we are bidi-iterating, don't decrement the iterator position;
2958 instead, set the first_elt flag in the bidi iterator, to produce
2959 the same effect.
2960 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2961 (push_display_prop): xassert that we are iterating a buffer.
2962 (push_it, pop_it): Save and restore paragraph_embedding member.
2963 (handle_single_display_spec, next_overlay_string)
2964 (get_overlay_strings_1, reseat_1, reseat_to_string)
2965 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2966 correctly. Don't assume unibyte strings are not bidi-reordered.
2967 (compute_display_string_pos)
2968 (compute_display_string_end): Fix handling the case of C string.
2969 (push_it, pop_it): Save and restore from_disp_prop_p.
2970 (handle_single_display_spec, push_display_prop): Set the
2971 from_disp_prop_p flag.
2972 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2973 (pop_it): Call iterate_out_of_display_property only if we are
2974 popping after iteration over a string that came from a display
2975 property. Fix a typo in popping stretch info. Add an assertion
2976 for verifying that the iterator position is in sync with the bidi
2977 iterator.
2978 (handle_single_display_spec, get_overlay_strings_1)
2979 (push_display_prop): Fix initialization of paragraph direction for
2980 string when that of the parent object is not yet determined.
2981 (reseat_1): Call bidi_init_it to resync the bidi
2982 iterator with IT's position. (Bug#7616)
2983 (find_row_edges): If ROW->start.pos gives position
2984 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2985 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2986 Reset the from_disp_prop_p flag.
2987 (SAVE_IT, RESTORE_IT): New macros.
2988 (pos_visible_p, face_before_or_after_it_pos)
2989 (back_to_previous_visible_line_start)
2990 (move_it_in_display_line_to, move_it_in_display_line)
2991 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2992 (try_scrolling, redisplay_window, display_line): Use them when
2993 saving a temporary copy of the iterator and restoring it back.
2994 (back_to_previous_visible_line_start, reseat_1)
2995 (init_iterator): Empty the bidi cache "stack".
2996 (move_it_in_display_line_to): If iterator ended up at
2997 EOL, but we never saw any buffer positions smaller than
2998 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2999 motion in bidi-reordered lines.
3000 (move_it_in_display_line_to): Record prev_method and prev_pos
3001 immediately before the call to set_iterator_to_next. Fixes cursor
3002 motion in bidi-reordered lines with stretch glyphs and strings
3003 displayed in margins. (Bug#8133) (Bug#8867)
3004 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3005 TO_CHARPOS.
640c8776
SM
3006 (pos_visible_p): Support positions in bidi-reordered lines.
3007 Save and restore bidi cache.
0bb23927
EZ
3008
3009 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3010 (bidi_paragraph_info): Delete unused struct.
3011 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3012 (bidi_cache_start): New variable.
3013 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3014 to zero.
3015 (bidi_cache_fetch_state, bidi_cache_search)
3016 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3017 (bidi_cache_find, bidi_peek_at_next_level)
3018 (bidi_level_of_next_char, bidi_find_other_level_edge)
3019 (bidi_move_to_visually_next): Compare cache index with
3020 bidi_cache_start rather than with zero.
3021 (bidi_fetch_char): Accept new argument STRING; all callers
3022 changed. Support iteration over a string. Support strings with
3023 display properties. Support unibyte strings. Fix the type of
3024 `len' according to what STRING_CHAR_AND_LENGTH expects.
3025 (bidi_paragraph_init, bidi_resolve_explicit_1)
3026 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3027 (bidi_level_of_next_char, bidi_move_to_visually_next):
3028 Support iteration over a string.
0bb23927
EZ
3029 (bidi_set_sor_type, bidi_resolve_explicit_1)
3030 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3031 can now be zero (for strings); special values 0 and -1 were
3032 changed to -1 and -2, respectively.
3033 (bidi_char_at_pos): New function.
3034 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3035 Call it instead of FETCH_MULTIBYTE_CHAR.
3036 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3037 initialized to valid values.
3038 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3039 values.
3040 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3041 the test for valid cached positions. Fix the logic for looking up
3042 the sentinel state in the cache. GCPRO the Lisp string we are
3043 iterating.
3044 (bidi_push_it, bidi_pop_it): New functions.
3045 (bidi_initialize): Initialize the bidi cache start stack pointer.
3046 (bidi_cache_ensure_space): New function, refactored from part of
3047 bidi_cache_iterator_state. Don't assume the required size is just
3048 one BIDI_CACHE_CHUNK away.
3049 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3050 (bidi_count_bytes, bidi_char_at_pos): New functions.
3051 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3052 always valid if bidi_cache_idx is valid.
3053 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3054 is valid if it's going to be used.
3055 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3056 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3057 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3058 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3059 (bidi_find_other_level_edge, bidi_cache_start_stack):
3060 All variables related to cache indices are now EMACS_INT.
c965adc5 3061
0bb23927
EZ
3062 * dispextern.h (struct bidi_string_data): New structure.
3063 (struct bidi_it): New member `string'. Make flag members be 1-bit
3064 fields, and put them last in the struct.
640c8776
SM
3065 (compute_display_string_pos, compute_display_string_end):
3066 Update prototypes.
0bb23927
EZ
3067 (bidi_push_it, bidi_pop_it): Add prototypes.
3068 (struct iterator_stack_entry): New members bidi_p,
3069 paragraph_embedding, and from_disp_prop_p.
3070 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3071 (bidi_shelve_cache, bidi_unshelve_cache):
3072 Declare prototypes.
0bb23927
EZ
3073
3074 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3075 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3076 and vector-like objects.
3077
3078 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3079 cache around display iteration.
3080
3081 * window.c (Fwindow_end, window_scroll_pixel_based)
3082 (displayed_window_lines, Frecenter): Save and restore the bidi
3083 cache around display iteration.
3084
3bbd2265
LMI
30852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3086
3087 * editfns.c (Fdelete_region): Clarify the use of the named
3088 parameters (bug#6788).
3089
adc47434
MR
30902011-07-14 Martin Rudalics <rudalics@gmx.at>
3091
3092 * indent.c (Fvertical_motion): Set and restore w->pointm when
3093 saving and restoring the window's buffer (Bug#9006).
3094
837c31f8
LMI
30952011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3096
3097 * editfns.c (Fstring_to_char): Clarify just what is returned
3098 (bug#6576). Text by Eli Zaretskii.
3099
ac389d0c
JB
31002011-07-13 Juanma Barranquero <lekktu@gmail.com>
3101
3102 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3103
0be0ce47
EZ
31042011-07-13 Eli Zaretskii <eliz@gnu.org>
3105
3106 * buffer.c (mmap_find): Fix a typo.
3107
cd18e7e3
JB
31082011-07-13 Johan Bockgård <bojohan@gnu.org>
3109
3110 Fix execution of x selection hooks.
3111 * xselect.c (Qx_lost_selection_functions)
3112 (Qx_sent_selection_functions): New vars.
3113 (syms_of_xselect): DEFSYM them.
3114 (x_handle_selection_request): Pass Qx_sent_selection_functions
3115 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3116 (x_handle_selection_clear,x_clear_frame_selections):
3117 Pass Qx_lost_selection_functions rather than
3118 Vx_lost_selection_functions to Frun_hook_with_args.
3119
47ea7f44
PE
31202011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3121
ac389d0c 3122 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3123 The old code sometimes used this field without initializing it.
3124
47ea7f44
PE
3125 * alloc.c (gc_sweep): Don't read past end of array.
3126 In theory, the old code could also have corrupted Emacs internals,
3127 though it'd be very unlikely.
3128
bc985c87
AS
31292011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3130
3131 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3132 argument. (Bug#4026)
bc985c87 3133
0cf34688
LMI
31342011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3135
b3dadd76
LMI
3136 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3137 key" (bug#4257).
3138
0cf34688
LMI
3139 * window.c (Fset_window_start): Doc fix (bug#4199).
3140 (Fset_window_hscroll): Ditto.
3141
270768cd
PE
31422011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3143
077e3dda 3144 Fix minor new problems caught by GCC 4.6.1.
270768cd 3145 * term.c (init_tty): Remove unused local.
490011a6 3146 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3147 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3148 not used otherwise.
270768cd 3149
b1f58454
CY
31502011-07-12 Chong Yidong <cyd@stupidchicken.com>
3151
3152 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3153
22b9578d
LMI
31542011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3155
6e70ab07
LMI
3156 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3157 are the mini-buffer and the echo area (bug#3320).
3158
22b9578d
LMI
3159 * term.c (init_tty): Remove support for supdup, c10 and perq
3160 terminals, which are no longer supported (bug#1482).
3161
8974cc9f
JB
31622011-07-10 Johan Bockgård <bojohan@gnu.org>
3163
3164 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3165
a560d974
JD
31662011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3167
3168 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3169 for non-popups (Bug#3642).
3170
1dae0f0a
AS
31712011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3172
268c2c36 3173 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3174 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3175 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3176 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3177 * data.c (fmod): Likewise.
3178 * dispnew.c (swap_glyphs_in_rows): Likewise.
3179 * emacs.c (memory_warning_signal): Likewise.
3180 * floatfns.c (float_error): Likewise.
3181 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3182 (otf_open, font_otf_capability, generate_otf_features)
3183 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3184 Likewise.
3185 * image.c (pbm_read_file): Likewise.
3186 * indent.c (string_display_width): Likewise.
3187 * intervals.c (check_for_interval, search_for_interval)
3188 (inc_interval_count, count_intervals, root_interval)
3189 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3190 * lread.c (defalias): Likewise.
268c2c36 3191 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3192 * regex.c (set_image_of_range_1, set_image_of_range)
3193 (regex_grow_registers): Likewise.
3194 * sysdep.c (strerror): Likewise.
3195 * termcap.c (valid_filename_p, tprint, main): Likewise.
3196 * tparam.c (main): Likewise.
3197 * unexhp9k800.c (run_time_remap, save_data_space)
3198 (update_file_ptrs, read_header, write_header, calculate_checksum)
3199 (copy_file, copy_rest, display_header): Likewise.
3200 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3201 Likewise.
3202 * xdisp.c (check_it): Likewise.
3203 * xfaces.c (register_color, unregister_color, unregister_colors):
3204 Likewise.
3205 * xfns.c (print_fontset_result): Likewise.
3206 * xrdb.c (member, fatal, main): Likewise.
3207
99033785
PE
32082011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3209
3210 Fix minor problems found by static checking (Bug#9031).
3211 * chartab.c (char_table_set_range, map_sub_char_table):
3212 Remove unused locals.
3213 (uniprop_table): Now static.
3214 * composite.c (_work_char): Remove unused static var.
3215
9cb2ac56
JB
32162011-07-09 Juanma Barranquero <lekktu@gmail.com>
3217
3218 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3219
f25661f0
JD
32202011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3221
3222 * gtkutil.c (qttip_cb): Remove code without function.
3223
8278c4fe
EZ
32242011-07-09 Eli Zaretskii <eliz@gnu.org>
3225
3226 * w32.c (pthread_sigmask): New stub.
3227
1692ae2d 32282011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3229
8a6ebd58 3230 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3231 sigprocmask is portable only for single-threaded applications, and
3232 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3233 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3234 (LIBES): Use it.
3235 * callproc.c (Fcall_process):
3236 * process.c (create_process):
3237 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3238 Use pthread_sigmask, not sigprocmask.
123403e4 3239
1b854618
JD
32402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3241
3242 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3243 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3244 wrong (Bug#8591).
3245
3fe4b549
JD
32462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3247
0ce7e563
JD
3248 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3249 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3250 (xg_hide_tooltip): Fix comment.
3251
3fe4b549
JD
3252 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3253 in registerServicesMenuSendTypes.
3254 (validRequestorForSendType): Don't check ns_return_types.
3255
3256 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3257 ns_return_type.
3258
5df75e47
JR
32592011-07-08 Jason Rumney <jasonr@gnu.org>
3260
22610910
JR
3261 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3262 SH_SHOW for hidden windows (Bug#5482).
3263
5df75e47
JR
3264 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3265 frame struct members of non-existent frames (Bug#6284).
3266
699c10bd
JD
32672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3268
4393663b
JD
3269 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3270 variable firstTime not needed on OSX >= 10.6.
3271 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3272 >= 10.5. Use setKnobProportion, setDoubleValue.
3273
3274 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3275 (MAC_OS_X_VERSION_10_5): Define if not defined.
3276 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3277 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3278 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3279
3280 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3281 cString and lossyCString on OSX >= 10.4
3282
58179cce 3283 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3284 sizeToFit on OSX >= 10.2.
3285
3286 * nsimage.m (allocInitFromFile): Don't use deprecated method
3287 bestRepresentationForDevice on OSX >= 10.6.
3288
3289 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3290 to avoid warning.
3291
3292 * emacs.c: Declare unexec_init_emacs_zone.
3293
a63e0781
JD
3294 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3295
699c10bd
JD
3296 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3297
3298 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3299 on svcsMenu (Bug#8842).
3300
3301 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3302 ns_return_types.
3303 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3304
3305 * nsterm.m (QUTF8_STRING): Declare.
3306 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3307 (validRequestorForSendType): Return type is (id).
3308 Change indexOfObjectIdenticalTo to indexOfObject.
3309 Check if we have local selection before returning self (Bug#8842).
3310 (writeSelectionToPasteboard): Put local selection into paste board
3311 if we have a local selection (Bug#8842).
3312 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3313
3314 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3315 (ns_get_local_selection): Declare.
3316
54e10184
LMI
33172011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3318
9888ff71
LMI
3319 * keymap.c (describe_map_tree): Don't insert a double newline at
3320 the end of the buffer (bug#1169) and return whether we inserted
3321 something.
3322
54e10184
LMI
3323 * callint.c (Fcall_interactively): Change "reading args" to
3324 "providing args" to try to clarify what it does (bug#1010).
3325
15fa4783
KH
33262011-07-07 Kenichi Handa <handa@m17n.org>
3327
3328 * composite.c (composition_compute_stop_pos): Ignore a static
3329 composition starting before CHARPOS (Bug#8915).
3330
3331 * xdisp.c (handle_composition_prop): Likewise.
3332
a8815b00
EZ
33332011-07-07 Eli Zaretskii <eliz@gnu.org>
3334
3335 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3336 (Bug#9015)
3337
ef7b981d 33382011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3339
3340 * character.h (unicode_category_t): New enum type.
3341
3342 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3343 (Qchar_code_property_table): New variable.
3344 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3345 (UNIPROP_COMPRESSED_FORM_P): New macros.
3346 (char_table_ascii): Uncompress the compressed values.
3347 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3348 Uncompress the compressed values.
ac389d0c 3349 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3350 (char_table_ref_and_range): Uncompress the compressed values.
3351 (sub_char_table_set): New arg is_uniprop. Callers changed.
3352 Uncompress the compressed values.
3353 (sub_char_table_set_range): Args changed. Callers changed.
3354 (char_table_set_range): Adjuted for the above change.
3355 (map_sub_char_table): Delete args default_val and parent. Add arg
3356 top. Give decoded values to a Lisp function.
640c8776 3357 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3358 values to a Lisp function. Gcpro more variables.
3359 (uniprop_table_uncompress)
3360 (uniprop_decode_value_run_length): New functions.
3361 (uniprop_decoder, uniprop_decoder_count): New variables.
3362 (uniprop_get_decoder, uniprop_encode_value_character)
3363 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3364 New functions.
3365 (uniprop_encoder, uniprop_encoder_count): New variables.
3366 (uniprop_get_encoder, uniprop_table)
3367 (Funicode_property_table_internal, Fget_unicode_property_internal)
3368 (Fput_unicode_property_internal): New functions.
3369 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3370 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3371 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3372 char-code-property-alist.
3373
640c8776 3374 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3375 Vunicode_category_table.
3376
640c8776 3377 * font.c (font_range): Adjust for the change of
c805dec0
KH
3378 Vunicode_category_table.
3379
76b397fb
DN
33802011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3381
3382 * m/iris4d.h: Remove file, move contents ...
3383 * s/irix6-5.h: ... here.
3384
22b4128e
PE
33852011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3388 * alloc.c (mark_buffer):
3389 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3390 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3391 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3392 This isn't true in general, and it's particularly not true
3393 if Emacs is configured with --with-wide-int.
3394 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3395 New macros, used in the buffer.c change.
3396
869795d6
JD
33972011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3398
3399 * xsettings.c: Use both GConf and GSettings if both are available.
3400 (store_config_changed_event): Add comment.
3401 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3402 (store_tool_bar_style_changed): New functions.
5e617bc2 3403 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3404 (struct xsettings): Move font inside HAVE_XFT.
3405 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3406 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3407 Move inside HAVE_XFT.
640c8776 3408 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3409 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3410 also.
3411 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3412 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3413 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3414 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3415 (parse_settings): Move check for font inside HAVE_XFT.
3416 (read_settings, apply_xft_settings): Add comment.
3417 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3418 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3419 call store_font_name_changed.
3420 (xft_settings_event): Add comment.
3421 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3422 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3423 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3424 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3425 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3426 (xsettings_get_system_font, xsettings_get_system_normal_font):
3427 Add comment.
869795d6 3428
d8ed26bd
PE
34292011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3430
3431 Random fixes. E.g., (random) never returned negative values.
3432 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3433 subseconds part to the entropy, as that's a bit more random.
3434 Prefer signed to unsigned, since the signedness doesn't matter and
3435 in general we prefer signed. When given a limit, use a
3436 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3437 latter isn't right if USE_2_TAGS_FOR_INTS.
3438 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3439 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3440
cabf1cac
SM
34412011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3442
3443 * textprop.c (text_property_stickiness):
3444 Obey Vtext_property_default_nonsticky.
3445 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3446 * w32fns.c (syms_of_w32fns):
3447 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3448
6e9b2be9
PE
34492011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3450
3451 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3452 This is more efficient than Ffile_directory_p and avoids a minor race.
3453
90186c68
LMI
34542011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3455
7c301272
LMI
3456 * buffer.c (Foverlay_put): Say what the return value is
3457 (bug#7835).
3458
c4f2d8d4
LMI
3459 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3460 is a directory before asking whether to use the file name
3461 (bug#7564).
ad637907
LMI
3462 (barf_or_query_if_file_exists): Make the "File is a directory"
3463 error be more correct.
c4f2d8d4 3464
90186c68
LMI
3465 * fns.c (Frequire): Remove the mention of the .gz files, since
3466 that's installation-specific, but keep the mention of
3467 `get-load-suffixes'.
3468
da64016e
PE
34692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3470
3471 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3472 Report string overflow if the output is too long.
3473
7d47b580
JB
34742011-07-04 Juanma Barranquero <lekktu@gmail.com>
3475
a555cb87
JB
3476 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3477 (syms_of_gnutls): Remove duplicate DEFSYM for
3478 Qgnutls_bootprop_verify_hostname_error, an error for
3479 Qgnutls_bootprop_verify_error (which is no longer used).
3480
7d47b580
JB
3481 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3482 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3483 Also (re)move comments that are misplaced or no longer relevant.
3484
1e49bfab
LMI
34852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3486
3487 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3488
1485f4c0
CY
34892011-07-03 Chong Yidong <cyd@stupidchicken.com>
3490
3491 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3492 and background color parameters if they have been changed.
3493
a9ab721e
LMI
34942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3495
3496 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3497
cf7cff57
PE
34982011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3499
2e13213d
PE
3500 * xsettings.c (SYSTEM_FONT): Define only when used.
3501 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3502
cf7cff57
PE
3503 * keymap.c (access_keymap_1): Now static.
3504
7a8e04f7
CY
35052011-07-02 Chong Yidong <cyd@stupidchicken.com>
3506
3507 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3508 leave any prefix arg for the up event (Bug#1586).
3509
61352f62
LMI
35102011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3511
69bb1ef7
LMI
3512 * lread.c (syms_of_lread): Mention single symbols defined by
3513 `defvar' or `defconst' (bug#7154).
3514
61352f62 3515 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3516 (Frequire): Mention get-load-suffixes.
61352f62 3517
28545e04
MR
35182011-07-02 Martin Rudalics <rudalics@gmx.at>
3519
3520 * window.h (window): Remove clone_number slot.
3521 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3522 Remove.
3523 (make_parent_window, make_window, saved_window)
3524 (Fset_window_configuration, save_window_save): Don't deal with
3525 clone numbers.
3526 * buffer.c (Qclone_number): Remove declaration.
3527 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3528
3349e122
SM
35292011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3530
3531 Add multiple inheritance to keymaps.
3532 * keymap.c (Fmake_composed_keymap): New function.
3533 (Fset_keymap_parent): Simplify.
3534 (fix_submap_inheritance): Remove.
3535 (access_keymap_1): New function extracted from access_keymap to handle
3536 embedded parents and handle lists of maps.
3537 (access_keymap): Use it.
3538 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3539 (Fcopy_keymap): Handle embedded parents.
3540 (Fcommand_remapping, define_as_prefix): Simplify.
3541 (Fkey_binding): Simplify.
3542 (syms_of_keymap): Move minibuffer-local-completion-map,
3543 minibuffer-local-filename-completion-map,
3544 minibuffer-local-must-match-map, and
3545 minibuffer-local-filename-must-match-map to Elisp.
3546 (syms_of_keymap): Defsubr make-composed-keymap.
3547 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3548 (parse_menu_item): Trivial simplification.
3549
3279eb87
GM
35502011-07-01 Glenn Morris <rgm@gnu.org>
3551
3552 * Makefile.in (SETTINGS_LIBS): Fix typo.
3553
4550efdf
KI
35542011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3555
3556 * coding.c (Fencode_coding_string): Record the last coding system
3557 used, as the function doc string says (bug#8738).
3558
0949d2b6
JD
35592011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3560
3561 * xsettings.c (store_monospaced_changed): Take new font as arg and
3562 check for change against current_mono_font.
3563 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3564 (emacs_settings_constructor, emacs_settings_get_property)
3565 (emacs_settings_set_property, emacs_settings_class_init)
3566 (emacs_settings_init, gsettings_obj): Remove.
3567 (something_changedCB): New function for HAVE_GSETTINGS.
3568 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3569 with value as argument.
3570 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3571 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3572 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3573 "changed".
3574
3575 * xgselect.c: Add defined (HAVE_GSETTINGS).
3576 (xgselect_initialize): Ditto.
3577
3578 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3579 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3580 xg_select.
3581
bbc6b304
PE
35822011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3583
3584 * eval.c (struct backtrace): Simplify and port the data structure.
3585 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3586 signed bit field, as this assumption is not portable and it makes
3587 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3588 "char debug_on_exit : 1" as this is not portable either; instead,
3589 use the portable "unsigned int debug_on_exit : 1". Remove unused
3590 member evalargs. Remove obsolete comments about cc bombing out.
3591
9851bfc5
JD
35922011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3593
51bb811f 3594 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3595 Let HAVE_GSETTINGS override HAVE_GCONF.
3596 (store_monospaced_changed): New function.
3597 (EMACS_SETTINGS): A new type derived from GObject to handle
3598 GSettings notifications.
3599 (emacs_settings_constructor, emacs_settings_get_property)
3600 (emacs_settings_set_property, emacs_settings_class_init):
3601 New functions.
3602 (gsettings_client, gsettings_obj): New variables.
3603 (GSETTINGS_SCHEMA): New define.
3604 (something_changedCB): Call store_monospaced_changed.
3605 (init_gsettings): New function.
3606 (xsettings_initialize): Call init_gsettings.
3607 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3608 to NULL.
3609
640c8776 3610 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3611 GCONF_CFLAGS/LIBS.
3612
5386012d
MR
36132011-06-29 Martin Rudalics <rudalics@gmx.at>
3614
3615 * window.c (resize_root_window, grow_mini_window)
3616 (shrink_mini_window): Rename Qresize_root_window to
3617 Qwindow_resize_root_window and Qresize_root_window_vertically to
3618 Qwindow_resize_root_window_vertically.
3619
f13e0b08
PE
36202011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3623
94515237
JB
36242011-06-27 Juanma Barranquero <lekktu@gmail.com>
3625
3626 * makefile.w32-in: Redesign dependencies so they reflect more
3627 clearly which files are directly included by each source file,
3628 and not through other includes.
3629
e43b6e43
MR
36302011-06-27 Martin Rudalics <rudalics@gmx.at>
3631
3632 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3633 (sort_overlays, overlay_strings): When an overlay's clone number
3634 matches the window's clone number process the overlay even if
3635 the overlay's window property doesn't match the current window.
3636
d68443dc
MR
3637 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3638 (Fwindow_hchild): Rename to Fwindow_left_child.
3639 (Fwindow_next): Rename to Fwindow_next_sibling.
3640 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3641 (resize_window_check): Rename to window_resize_check.
3642 (resize_window_apply): Rename to window_resize_apply.
3643 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3644 (Fdelete_other_windows_internal, resize_frame_windows)
3645 (Fsplit_window_internal, Fdelete_window_internal)
3646 (grow_mini_window, shrink_mini_window)
3647 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3648
c7e73be5
JD
36492011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3650
3651 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3652 (emacs_fixed_set_min_size): Remove.
3653 (emacs_fixed_new): Take frame as argument.
3654
3655 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3656 (_EmacsFixedPrivate): Remove minwidth/height.
3657 Add struct frame *f.
3658 (emacs_fixed_init): Initialize priv->f.
3659 (get_parent_class, emacs_fixed_set_min_size): Remove.
3660 (emacs_fixed_new): Set priv->f to argument.
3661 (emacs_fixed_get_preferred_width)
3662 (emacs_fixed_get_preferred_height): Use min_width/height from
3663 frames size_hint to set minimum and natural (Bug#8919).
3664 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3665 and use min_width/height from frames size_hint to set
3666 min_width/height (Bug#8919).
3667
3668 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3669 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3670 Fix indentation.
c7e73be5 3671
cf99dcf8
EZ
36722011-06-26 Eli Zaretskii <eliz@gnu.org>
3673
3674 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3675 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3676 called at ZV.
3677
029529ac
CY
36782011-06-26 Chong Yidong <cyd@stupidchicken.com>
3679
3680 * process.c (wait_reading_process_output): Bypass select if
3681 waiting for a cell while ignoring keyboard input, and input is
3682 pending. Suggested by Jan Djärv (Bug#8869).
3683
7a7ef429
PE
36842011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3685
3686 Use gnulib's dup2 module instead of rolling our own.
3687 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3688
11fdef7d 36892011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3690
3691 * dispnew.c (scrolling_window): Before scrolling, turn off a
3692 mouse-highlight in the window being scrolled.
3693
cd3520a4
JB
36942011-06-24 Juanma Barranquero <lekktu@gmail.com>
3695
3696 Move DEFSYM to lisp.h and use everywhere.
3697
3698 * character.h (DEFSYM): Move declaration...
3699 * lisp.h (DEFSYM): ...here.
3700
3701 * gnutls.c:
3702 * minibuf.c:
3703 * w32menu.c:
3704 * w32proc.c:
3705 * w32select.c: Don't include character.h.
3706
3707 * alloc.c (syms_of_alloc):
3708 * buffer.c (syms_of_buffer):
3709 * bytecode.c (syms_of_bytecode):
3710 * callint.c (syms_of_callint):
3711 * casefiddle.c (syms_of_casefiddle):
3712 * casetab.c (init_casetab_once):
3713 * category.c (init_category_once, syms_of_category):
3714 * ccl.c (syms_of_ccl):
3715 * cmds.c (syms_of_cmds):
3716 * composite.c (syms_of_composite):
3717 * dbusbind.c (syms_of_dbusbind):
3718 * dired.c (syms_of_dired):
3719 * dispnew.c (syms_of_display):
3720 * doc.c (syms_of_doc):
3721 * editfns.c (syms_of_editfns):
3722 * emacs.c (syms_of_emacs):
3723 * eval.c (syms_of_eval):
3724 * fileio.c (syms_of_fileio):
3725 * fns.c (syms_of_fns):
3726 * frame.c (syms_of_frame):
3727 * fringe.c (syms_of_fringe):
3728 * insdel.c (syms_of_insdel):
3729 * keymap.c (syms_of_keymap):
3730 * lread.c (init_obarray, syms_of_lread):
3731 * macros.c (syms_of_macros):
3732 * msdos.c (syms_of_msdos):
3733 * print.c (syms_of_print):
3734 * process.c (syms_of_process):
3735 * search.c (syms_of_search):
3736 * sound.c (syms_of_sound):
3737 * syntax.c (init_syntax_once, syms_of_syntax):
3738 * terminal.c (syms_of_terminal):
3739 * textprop.c (syms_of_textprop):
3740 * undo.c (syms_of_undo):
3741 * w32.c (globals_of_w32):
3742 * window.c (syms_of_window):
3743 * xdisp.c (syms_of_xdisp):
3744 * xfaces.c (syms_of_xfaces):
3745 * xfns.c (syms_of_xfns):
3746 * xmenu.c (syms_of_xmenu):
3747 * xsettings.c (syms_of_xsettings):
3748 * xterm.c (syms_of_xterm): Use DEFSYM.
3749
4228cf16
TZ
37502011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3751
cd3520a4 3752 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3753
7fcccf1e
PE
37542011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3755
7efb4e0e
PE
3756 Integer and buffer overflow fixes (Bug#8873).
3757
ff5844ad
PE
3758 * print.c (printchar, strout): Check for string overflow.
3759 (PRINTPREPARE, printchar, strout):
3760 Don't set size unless allocation succeeds.
3761
90532f02
PE
3762 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3763 for sizes. Check for string overflow more accurately.
3764 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3765
6d84508d
PE
3766 * macros.c: Integer and buffer overflow fixes.
3767 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3768 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3769 Use ptrdiff_t, not int, for sizes.
3770 Don't increment bufsize until after realloc succeeds.
3771 Check for size-calculation overflow.
3772 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3773
437b2cb4
PE
3774 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3775
8b9ac8b4
PE
3776 * lread.c: Integer overflow fixes.
3777 (read_integer): Radix is now EMACS_INT, not int,
3778 to improve quality of diagnostics for out-of-range radices.
3779 Calculate buffer size correctly for out-of-range radices.
3780 (read1): Check for integer overflow in radices, and in
3781 read-circle numbers.
82cb60d3
PE
3782 (read_escape): Avoid int overflow.
3783 (Fload, openp, read_buffer_size, read1)
3784 (substitute_object_recurse, read_vector, read_list, map_obarray):
3785 Use ptrdiff_t, not int, for sizes.
3786 (read1): Use EMACS_INT, not int, for sizes.
20270765 3787 Check for size overflow.
8b9ac8b4 3788
7fcccf1e
PE
3789 * image.c (cache_image): Check for size arithmetic overflow.
3790
bfbbd7e7
PE
3791 * lread.c: Integer overflow issues.
3792 (saved_doc_string_size, saved_doc_string_length)
3793 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3794 Now ptrdiff_t, not int.
3795 (read1): Don't assume doc string length fits in int. Check for
3796 out-of-range doc string lengths.
3797 (read_list): Don't assume file position fits in int.
39019e54 3798 (read_escape): Check for hex character overflow.
bfbbd7e7 3799
4e323265
LL
38002011-06-22 Leo Liu <sdl.web@gmail.com>
3801
3802 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3803 Move to minibuffer.el.
3804
85fece3e
PE
38052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3806
20b84ce9 3807 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3808 The following patches are for when GLYPH_DEBUG && !XASSERT.
3809 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3810 * dispnew.c (flush_stdout):
3811 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3812 Mark as externally visible.
3813 * dispnew.c (check_window_matrix_pointers): Now static.
3814 * dispnew.c (window_to_frame_vpos):
3815 * xfns.c (unwind_create_frame):
3816 * xterm.c (x_check_font): Remove unused local.
3817 * scroll.c (CHECK_BOUNDS):
3818 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3819 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3820 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3821 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3822 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3823 Now static.
3824 (debug_method_add): Use va_list and vsprintf rather than relying
3825 on undefined behavior with wrong number of arguments.
3826 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3827 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3828 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3829 since we're not interested in debugging glyphs with old libraries.
3830 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3831 GCC 4.6.0's static checking.
3832
0766b489
PE
38332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3834
31fd4b32
PE
3835 Integer overflow and signedness fixes (Bug#8873).
3836 A few related buffer overrun fixes, too.
3837
b79e8648
PE
3838 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3839
0766b489
PE
3840 * dispextern.h (struct face.stipple):
3841 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3842 (x_bitmap_mask, x_allocate_bitmap_record)
3843 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3844 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3845 (x_create_bitmap_from_xpm_data):
3846 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3847 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3848 (.bitmaps_last):
3849 * xfaces.c (load_pixmap):
3850 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3851 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3852 (.bitmaps_last, struct x_output.icon_bitmap):
3853 Use ptrdiff_t, not int, for bitmap indexes.
3854 (x_allocate_bitmap_record): Check for size overflow.
3855 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3856
b081724f
PE
3857 Use ptrdiff_t, not int, for overlay counts.
3858 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3859 * editfns.c (overlays_around, get_pos_property):
3860 * textprop.c (get_char_property_and_overlay):
3861 * xdisp.c (next_overlay_change, note_mouse_highlight):
3862 * xfaces.c (face_at_buffer_position):
21514da7
PE
3863 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3864 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3865 (Fnext_overlay_change, Fprevious_overlay_change)
3866 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3867 Use ptrdiff_t, not int, for sizes.
21514da7 3868 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3869
3de73e5e
PE
3870 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3871
2606c57b
PE
3872 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3873 (x_session_initialize): Do not assume string length fits in int.
3874
aaafe47a
PE
3875 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3876 This is unlikely, but can occur if DPI is outlandish.
3877
2674ddc8 3878 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3879 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3880
28154962
PE
3881 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3882 * xrdb.c (magic_file_p, search_magic_path):
3883 Omit last arg SUFFIX; it was always 0. All callers changed.
3884 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3885
7de51af5
PE
3886 * xfont.c (xfont_match): Avoid need for strlen.
3887
25ed6cc3
PE
3888 * xfns.c: Don't assume strlen fits in int.
3889 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3890
4eab31dd
PE
3891 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3892 not unsigned long, as we prefer signed integers. All callers changed.
3893 Detect integer overflow in repeat count.
3894 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3895 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3896
171e2a58
PE
3897 * termcap.c: Don't assume sizes fit in int and never overflow.
3898 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3899 (gobble_line): Check for size-calculation overflow.
3900
ad39faca 3901 * minibuf.c (Fread_buffer):
6e5bb2dc 3902 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3903 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3904 Don't assume string length fits in int.
3905
52c61c22 3906 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3907 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3908
b5b8c9e5
PE
3909 * font.c: Don't assume string length fits in int.
3910 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3911 Use ptrdiff_t, not int.
ccd6111c
PE
3912 (font_intern_prop): Don't assume string length fits in int.
3913 Don't assume integer property fits in fixnum.
3914 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3915
882f0d81 3916 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3917 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3918 Reformulate so as not to need the command string.
3919 Invoke gzip -cd rather than gunzip, as it's more portable.
3920 (lock_info_type, lock_file_1, lock_file):
3921 Don't assume pid_t and time_t fit in unsigned long.
3922 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3923 (current_lock_owner): Prefer signed type for sizes.
3924 Use memcpy, not strncpy, where memcpy is what is really wanted.
3925 Don't assume (via atoi) that time_t and pid_t fit in int.
3926 Check for time_t and/or pid_t out of range, e.g., via a network share.
3927 Don't alloca where an auto var works fine.
3928
93f4cf88
PE
3929 * fileio.c: Fix some integer overflow issues.
3930 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3931 Don't assume string length fits in int.
3932 (directory_file_name): Don't assume string length fits in long.
3933 (make_temp_name): Don't assume pid fits in int, or that its print
3934 length is less than 20.
3935
f3e92b69
PE
3936 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3937
1bfdaf10
PE
3938 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3939
35016e9a
PE
3940 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3941
3d1e65a1
PE
3942 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3943 We prefer signed integers, even for size calculations.
3944
0b963a93
PE
3945 * emacs.c: Don't assume string length fits in 'int'.
3946 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3947 (main): Don't invoke strlen when not needed.
3948
573f4b54
PE
3949 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3950 (XD_DEBUG_MESSAGE): Don't waste a byte.
3951
989f33ba
PE
3952 * callproc.c (getenv_internal_1, getenv_internal)
3953 (Fgetenv_internal):
965d34eb
PE
3954 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3955
e4d29b33
PE
3956 * lread.c (invalid_syntax): Omit length argument.
3957 All uses changed. This doesn't fix a bug, but it simplifies the
3958 code away from its former Hollerith-constant appearance, and it's
3959 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3960 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3961
eb49b136
PE
3962 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3963 This didn't break anything, but it didn't help either.
3964 It's confusing to put a bogus integer in a place where the actual
3965 value does not matter.
9f62aeb1 3966 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3967 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3968
15375a22
PE
3969 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3970 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3971 implementation.
b61cc01c
PE
3972 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3973 We prefer signed types, and the value cannot exceed the EMACS_INT
3974 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3975 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3976 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3977 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3978
53b2623d
PE
3979 * indent.c (sane_tab_width): New function.
3980 (current_column, scan_for_column, Findent_to, position_indentation)
3981 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3982 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3983
51cab52b 3984 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3985
f2ed8a70
PE
3986 * lisp.h (lint_assume): New macro.
3987 * composite.c (composition_gstring_put_cache):
3988 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3989
abe80cc6
PE
3990 * editfns.c, insdel.c:
3991 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3992
b02c740e
PE
3993 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3994
ebc96716
PE
3995 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3996
b4e50fa0 3997 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3998 Use much-faster test for byte-length change.
311d5d7c 3999 Don't assume string byte-length fits in 'int'.
a4cf38e4 4000 Check that character arg fits in 'int'.
85461888 4001 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4002
c0c1ee9f
PE
4003 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4004
a498d7f4
PE
4005 * fns.c (concat): Catch string overflow earlier.
4006 Do not rely on integer wraparound.
4007
51cab52b
PE
4008 * dispextern.h (struct it.overlay_strings_charpos)
4009 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4010 * xdisp.c (forward_to_next_line_start)
4011 (back_to_previous_visible_line_start)
4012 (reseat_at_next_visible_line_start, next_element_from_buffer):
4013 Don't arbitrarily truncate the value of 'selective' to int.
4014
76031fad
PE
4015 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4016
5eb55db9
PE
4017 * composite.c: Don't truncate sizes to 'int'.
4018 (composition_gstring_p, composition_reseat_it)
4019 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4020 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4021 not EMACS_UINT, for indexes.
5eb55db9 4022
0703a717
PE
4023 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4024
d6202519
PE
4025 * buffer.c: Include <verify.h>.
4026 (struct sortvec.priority, struct sortstr.priority):
8961a454 4027 Now EMACS_INT, not int.
c20998a7 4028 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4029 (struct sortstr.size, record_overlay_string)
4030 (struct sortstrlist.size, struct sortlist.used):
4031 Don't truncate size to int.
4032 (record_overlay_string): Check for size-calculation overflow.
d6202519 4033 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4034
d5a19415
JM
40352011-06-22 Jim Meyering <meyering@redhat.com>
4036
029529ac 4037 Don't leak an XBM-image-sized buffer
d5a19415
JM
4038 * image.c (xbm_load): Free the image buffer after using it.
4039
a9041e6c
PE
40402011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 Port to Sun C.
4043 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4044 that Sun C diagnosed.
4045 * fns.c (secure_hash): Fix pointer signedness issue.
4046 * intervals.c (static_offset_intervals): New function.
4047 (offset_intervals): Use it.
4048
7f3f739f
LL
40492011-06-21 Leo Liu <sdl.web@gmail.com>
4050
4051 * deps.mk (fns.o):
4052 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4053 sha512.h.
4054
4055 * fns.c (secure_hash): Rename from crypto_hash_function and change
4056 the first arg to accept symbols.
5b66d427 4057 (Fsecure_hash): New primitive.
7f3f739f
LL
4058 (syms_of_fns): New symbols.
4059
76147d94
DD
40602011-06-20 Deniz Dogan <deniz@dogan.se>
4061
4062 * process.c (Fset_process_buffer): Clarify return value in
4063 docstring.
4064
7d7d0045
CY
40652011-06-18 Chong Yidong <cyd@stupidchicken.com>
4066
4067 * dispnew.c (add_window_display_history): Use BVAR.
4068
4069 * xdisp.c (debug_method_add): Use BVAR.
4070 (check_window_end, dump_glyph_matrix, dump_glyph)
4071 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4072
4073 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4074 Likewise.
4075
4076 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4077 check till after the cache is created in init_frame_faces.
4078
ff2bc410
SM
40792011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4080
4081 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4082
28177add
PE
40832011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4084
dd3482fe
PE
4085 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4086 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4087 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4088
393d71f3 4089 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4090 * fileio.c (Finsert_file_contents):
4091 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4092 Remove the old (too-loose) buffer overflow checks.
4093 They weren't needed, since make_gap checks for buffer overflow.
4094 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4095 The old code merely checked for Emacs fixnum overflow, and relied
4096 on undefined (wraparound) behavior. The new code avoids undefined
4097 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4098
2e6813b0 4099 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4100 Tune. Don't use wider integers than needed. Don't use alloca.
4101 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4102
599a9e4f
PE
4103 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4104
99561444
PE
4105 * insdel.c, lisp.h (buffer_overflow): New function.
4106 (insert_from_buffer_1, replace_range, replace_range_2):
4107 * insdel.c (make_gap_larger):
4108 * editfns.c (Finsert_char):
4109 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4110
28177add
PE
4111 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4112
e69dafad
PE
41132011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4114
a7af7fde 4115 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4116
b1c46f02
PE
4117 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4118 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4119
e69dafad
PE
4120 * fileio.c: Don't assume EMACS_INT fits in off_t.
4121 (emacs_lseek): New static function.
4122 (Finsert_file_contents, Fwrite_region): Use it.
4123 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4124
566684ea
PE
4125 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4126
e6966cd6
PE
4127 * fns.c: Don't overflow int when computing a list length.
4128 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4129 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4130 truncation on 64-bit hosts. Check for QUIT every
4131 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4132 faster and is responsive enough.
4133 (Flength): Report an error instead of overflowing an integer.
4134 (Fsafe_length): Return a float if the value is not representable
4135 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4136 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4137 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4138
dd0b0efb
PE
4139 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4140 (header_size, word_size): New constants.
4141 (allocate_vectorlike): Don't check size overflow here.
4142 (allocate_vector): Check it here instead, since this is the only
4143 caller of allocate_vectorlike that could cause overflow.
4144 Check that the new vector's length is representable as a fixnum.
4145
86fe5cfe
PE
4146 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4147 The previous code was bogus. For example, next_almost_prime (32)
4148 returned 39, which is undesirable as it is a multiple of 3; and
4149 next_almost_prime (24) returned 25, which is a multiple of 5 so
4150 why was the code bothering to check for multiples of 7?
4151
80e88859
PE
4152 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4153
4a2f0ad6
PE
4154 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4155
f66c7cf8
PE
4156 Variadic C functions now count arguments with ptrdiff_t.
4157 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4158 Back then I didn't know that the Emacs coding style prefers signed int.
4159 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4160 were being counted with int, which may truncate counts on 64-bit
4161 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4162 * lisp.h (struct Lisp_Subr.function.aMANY)
4163 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4164 Arg counts are now ptrdiff_t, not size_t.
4165 All variadic functions and their callers changed accordingly.
4166 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4167 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4168 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4169 * callint.c (Fcall_interactively): Check arg count for overflow,
4170 to avoid potential buffer overrun. Use signed char, not 'int',
4171 for 'varies' array, so that we needn't bother to check its size
4172 calculation for overflow.
4173 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4174 * eval.c (apply_lambda):
4175 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4176 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4177 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4178
a1759b76
PE
4179 * callint.c (Fcall_interactively): Don't use index var as event count.
4180
d96be9fc
PE
4181 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4182 * mem-limits.h (SIZE): Remove; no longer used.
4183
a690a978 4184 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4185
578c21e6
PE
4186 Remove unnecessary casts.
4187 * xterm.c (x_term_init):
4188 * xfns.c (x_set_border_pixel):
4189 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4190 These aren't needed now that we assume ANSI C.
4191
96f53c6c
PE
4192 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4193 It's more likely to cause problems (due to unsigned overflow)
4194 than to cure them.
4195
83c77d31
PE
4196 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4197
ee2079f1
PE
4198 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4199
6da65536
PE
4200 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4201
7147c4a4
PE
4202 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4203
193e32d9
PE
4204 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4205
e5533da6
PE
4206 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4207
9910e595
PE
4208 GLYPH_CODE_FACE returns EMACS_INT, not int.
4209 * dispextern.h (merge_faces):
4210 * xfaces.c (merge_faces):
01103c44
PE
4211 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4212 Don't assume EMACS_INT fits in int.
9910e595 4213
2638320e
PE
4214 * character.h (CHAR_VALID_P): Remove unused parameter.
4215 * fontset.c, lisp.h, xdisp.c: All uses changed.
4216
045eb8d9
PE
4217 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4218
c1f134b5
PE
4219 * fns.c (concat): Minor tuning based on overflow analysis.
4220 This doesn't fix any bugs. Use int to hold character, instead
4221 of constantly refetching from Emacs object. Use XFASTINT, not
4222 XINT, for value known to be a character. Don't bother comparing
4223 a single byte to 0400, as it's always less.
4224
395fcb93 4225 * floatfns.c (Fexpt):
327eeec8
PE
4226 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4227
abbd3d23
PE
4228 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4229 for characters.
4230
684a03ef
PE
4231 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4232
0fed43f3
PE
4233 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4234 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4235 incorrectly succeed when S was a string, because 4294967386 was
4236 truncated before it was used.
4237
8fd02eb7
PE
4238 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4239 Otherwise, an out-of-range integer could cause undefined behavior
4240 on a 64-bit host.
4241
f8c86b69
PE
4242 * composite.c: Use int, not EMACS_INT, for characters.
4243 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4244 EMACS_INT, for values that are known to be in character range.
4245 This doesn't fix any bugs but is the usual style inside Emacs and
4246 may generate better code on 32-bit machines.
4247
34206dd2
PE
4248 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4249 This is for reasons similar to the recent CHAR_STRING fix.
4250 * charset.c (Fencode_char): Check that character arg is actually
4251 a character. Pass an int to ENCODE_CHAR.
4252 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4253 wider than 'int', as a compile-time check to prevent future regressions
4254 in this area.
4255
c5958d4c 4256 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4257
4258 Make sure a 64-bit char is never passed to CHAR_STRING.
4259 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4260 by silently ignoring the top 32 bits, allowing some values
4261 that were far too large to be valid characters.
4262 * character.h: Include <verify.h>.
4263 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4264 arguments are no wider than unsigned, as a compile-time check
4265 to prevent future regressions in this area.
4266 * data.c (Faset):
01103c44 4267 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4268 (Fsubst_char_in_region):
4269 * fns.c (concat):
4270 * xdisp.c (decode_mode_spec_coding):
4271 Adjust to CHAR_STRING's new requirement.
4272 * editfns.c (Finsert_char, Fsubst_char_in_region):
4273 * fns.c (concat): Check that character args are actually
4274 characters. Without this test, these functions did the wrong
4275 thing with wildly out-of-range values on 64-bit hosts.
4276
d37ca623
PE
4277 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4278 These casts should not be needed on 32-bit hosts, either.
4279 * keyboard.c (read_char):
4280 * lread.c (Fload): Remove casts to unsigned.
4281
ea204efb
PE
4282 * lisp.h (UNSIGNED_CMP): New macro.
4283 This fixes comparison bugs on 64-bit hosts.
4284 (ASCII_CHAR_P): Use it.
4285 * casefiddle.c (casify_object):
01103c44 4286 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4287 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4288 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4289 * dispextern.h (FACE_FROM_ID):
4290 * keyboard.c (read_char): Use UNSIGNED_CMP.
4291
41cb286c
PE
4292 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4293 not to EMACS_INT, to avoid GCC warning.
4294
4a1b9832
PE
4295 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4296
55daad71
PE
4297 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4298 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4299 isn't needed on 32-bit machines.
8f95c75c 4300
01103c44
PE
4301 * buffer.c (Fgenerate_new_buffer_name):
4302 Use EMACS_INT for count, not int.
0ceccced 4303 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4304
4305 * data.c (Qcompiled_function): Now static.
4306
c6f072e7
PE
4307 * window.c (window_body_lines): Now static.
4308
20ce5912
PE
4309 * image.c (gif_load): Rename local to avoid shadowing.
4310
9c4c5f81
PE
4311 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4312 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4313 * alloc.c (make_save_value): Integer argument is now of type
4314 ptrdiff_t, not int.
4315 (mark_object): Use ptrdiff_t, not int.
4316 * lisp.h (pD): New macro.
4317 * print.c (print_object): Use it.
4318
c0c5c8ae
PE
4319 * alloc.c: Use EMACS_INT, not int, to count objects.
4320 (total_conses, total_markers, total_symbols, total_vector_size)
4321 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4322 (total_free_floats, total_floats, total_free_intervals)
4323 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4324 Now EMACS_INT, not int. All uses changed.
4325 (Fgarbage_collect): Compute overall total using a double, so that
4326 integer overflow is less likely to be a problem. Check for overflow
4327 when converting back to an integer.
5a25e253
PE
4328 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4329 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4330 These were 'int' variables that could overflow on 64-bit hosts;
4331 they were never used, so remove them instead of repairing them.
211a0b2a 4332 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4333 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4334 Previously, this ceilinged at INT_MAX, but that doesn't work on
4335 64-bit machines.
e46bb31a 4336 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4337
c78baabf 4338 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4339 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4340 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4341 when a (possibly-narrower) signed value would do just as well.
4342 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4343
c9d624c6
PE
4344 * alloc.c: Catch some string size overflows that we were missing.
4345 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4346 for convenience in STRING_BYTES_MAX.
4347 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4348 The definition here is exact; the one in lisp.h was approximate.
4349 (allocate_string_data): Check for string overflow. This catches
4350 some instances we weren't catching before. Also, it catches
4351 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4352 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4353 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4354
c9d624c6
PE
4355 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4356 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4357 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4358
353032ce
PE
4359 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4360
2bccce07
PE
4361 * alloc.c (Fmake_string): Check for out-of-range init.
4362
0ac30604
SM
43632011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4364
4365 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4366
c195f2de
JD
43672011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4368
4369 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4370 xg_get_default_scrollbar_width.
4371
4372 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4373 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4374 (style_changed_cb): Call update_theme_scrollbar_width and call
4375 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4376 all frames (Bug#8505).
4377 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4378 Call gtk_window_set_resizable if HAVE_GTK3.
4379 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4380 and height if HAVE_GTK3 (Bug#8505).
4381 (scroll_bar_width_for_theme): New variable.
4382 (update_theme_scrollbar_width): New function.
4383 (xg_get_default_scrollbar_width): Move code to
4384 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4385 (xg_initialize): Call update_theme_scrollbar_width.
4386
4387 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4388
4389 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4390
e10ac9f1
MR
43912011-06-12 Martin Rudalics <rudalics@gmx.at>
4392
4393 * frame.c (make_frame): Call other_buffer_safely instead of
4394 other_buffer.
4395
4396 * window.c (temp_output_buffer_show): Call display_buffer with
4397 second argument Vtemp_buffer_show_specifiers and reset latter
4398 immediately after the call.
4399 (Vtemp_buffer_show_specifiers): New variable.
4400 (auto_window_vscroll_p, next_screen_context_lines)
4401 (Vscroll_preserve_screen_position): Remove leading asterisks from
4402 doc-strings.
4403
2d3c217e 44042011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4405
7b7f97e8 4406 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4407 * buffer.c (Qclone_number): Remove for now, as it's unused.
4408 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4409 (record_buffer): Remove unused local.
4410 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4411 (set_frame_buffer_list): Remove; unused.
4412 * frame.h (other_visible_frames): Remove decl.
4413 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4414 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4415 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4416 if HAVE_GPM.
4417 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4418 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4419 Define only if HAVE_GPM.
4420 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4421 (update_hints_inhibit): Remove; never set. All uses removed.
4422 * widgetprv.h (emacsFrameClassRec): Remove decl.
4423 * window.c (delete_deletable_window): Now returns void, since it
4424 wasn't returning anything.
4425 (compare_window_configurations): Remove unused locals.
4426 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4427 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4428 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4429 the same widths as pointers. This follows up on the 2011-05-06 patch.
4430 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4431 * xterm.h: Likewise.
4432 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4433
1384b89e
JB
44342011-06-12 Juanma Barranquero <lekktu@gmail.com>
4435
4436 * makefile.w32-in: Update dependencies.
4437 (LISP_H): Add lib/intprops.h.
4438
1100a63c
CY
44392011-06-11 Chong Yidong <cyd@stupidchicken.com>
4440
4441 * image.c (gif_load): Add animation frame delay to the metadata.
4442 (syms_of_image): Use DEFSYM. New symbol `delay'.
4443
6198ccd0
MR
44442011-06-11 Martin Rudalics <rudalics@gmx.at>
4445
4446 * window.c (delete_deletable_window): Re-add.
4447 (Fset_window_configuration): Rewrite to handle dead buffers and
4448 consequently deletable windows.
4449 (window_tree, Fwindow_tree): Remove. Supply functionality in
4450 window.el.
4451 (compare_window_configurations): Simplify code.
4452
b6e3633c
AS
44532011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4454
1ab0dee5
AS
4455 * image.c (imagemagick_load_image): Fix type mismatch.
4456 (Fimagemagick_types): Likewise.
4457
b6e3633c
AS
4458 * window.h (replace_buffer_in_windows): Declare.
4459
9397e56f
MR
44602011-06-11 Martin Rudalics <rudalics@gmx.at>
4461
4462 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4463 Qclone_number. Remove external declaration of Qdelete_window.
4464 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4465 code.
640c8776
SM
4466 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4467 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4468 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4469 buffer list implementation.
4470 (other_buffer_safely): New function.
4471 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4472 calls to replace_buffer_in_windows and
4473 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4474 if allowed.
4475 (record_buffer): Inhibit quitting and rewrite using quittable
4476 functions. Run Qbuffer_list_update_hook if allowed.
4477 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4478 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4479 Move switch-to-buffer to window.el.
9397e56f
MR
4480 (bury-buffer): Move to window.el.
4481 (Vbuffer_list_update_hook): New variable.
4482
4483 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4484 section.
4485
4486 * window.h (resize_frame_windows): Move up in code.
4487 (Fwindow_frame): Remove EXFUN.
4488 (replace_buffer_in_all_windows): Remove prototype.
4489 (replace_buffer_in_windows_safely): Add prototype.
4490
4491 * window.c: Declare Qdelete_window static again. Move down
4492 declaration of select_count.
4493 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4494 (Fother_window): Move to window.el.
4495 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4496 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4497 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4498 window.el.
4499 (replace_buffer_in_windows): Implement by calling
4500 Qreplace_buffer_in_windows.
4501 (replace_buffer_in_all_windows): Remove with some functionality
4502 moved into replace_buffer_in_windows_safely.
4503 (replace_buffer_in_windows_safely): New function.
4504 (select_window_norecord, select_frame_norecord): Move in front
4505 of run_window_configuration_change_hook. Remove now obsolete
4506 declarations.
640c8776
SM
4507 (Fset_window_buffer): Rewrite doc-string.
4508 Call Qrecord_window_buffer.
9397e56f
MR
4509 (keys_of_window): Move binding for other-window to window.el.
4510
b50691aa
CY
45112011-06-11 Chong Yidong <cyd@stupidchicken.com>
4512
4513 * dispextern.h (struct image): Replace data member, whose int_val
4514 and ptr_val fields were not used by anything, with a single
4515 lisp_val object.
4516
4517 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4518 (gif_clear_image, gif_load, imagemagick_load_image)
4519 (gs_clear_image, gs_load): Callers changed.
4520
3f754b86
PE
45212011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4522
cca69397
PE
4523 * buffer.h: Include <time.h>, for time_t.
4524 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4525
109e28d0
PE
4526 Fix minor problems found by static checking.
4527
60737f02
PE
4528 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4529
4b66faf3
PE
4530 Make identifiers static if they are not used in other modules.
4531 * data.c (Qcompiled_function, Qframe, Qvector):
4532 * image.c (QimageMagick, Qsvg):
4533 * minibuf.c (Qmetadata):
4534 * window.c (resize_window_check, resize_root_window): Now static.
4535 * window.h (resize_window_check, resize_root_window): Remove decls.
4536
109e28d0
PE
4537 * window.c (window_deletion_count, delete_deletable_window):
4538 Remove; unused.
46a4ce9e
PE
4539 (window_body_lines): Now static.
4540 (Fdelete_other_windows_internal): Mark vars as initialized.
4541 Make sure 'resize_failed' is initialized.
4542 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4543 (resize_window_apply): Remove unused local.
4544 * window.h (delete_deletable_window): Remove decl.
4545
109e28d0 4546 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4547 (imagemagick_load_image): Fix pointer signedness problem by changing
4548 last arg from unsigned char * to char *. All uses changed.
4549 Also, fix a local for similar reasons.
4550 Remove unused locals. Remove locals to avoid shadowing.
4551 (fn_rsvg_handle_free): Remove; unused.
4552 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4553 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4554
3f754b86
PE
4555 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4556
2547adb1
CY
45572011-06-10 Chong Yidong <cyd@stupidchicken.com>
4558
4559 * image.c (gif_load): Fix omitted cast error introduced by
4560 2011-06-06 change.
4561
2c8e37d4
MR
45622011-06-10 Martin Rudalics <rudalics@gmx.at>
4563
4564 * window.h (resize_proportionally, orig_total_lines)
4565 (orig_top_line): Remove from window structure.
4566 (set_window_height, set_window_width, change_window_heights)
4567 (Fdelete_window): Remove prototypes.
4568 (resize_frame_windows): Remove duplicate declaration.
4569
440a42e3
EZ
45702011-06-10 Eli Zaretskii <eliz@gnu.org>
4571
4572 * window.h (resize_frame_windows, resize_window_check)
4573 (delete_deletable_window, resize_root_window)
4574 (resize_frame_windows): Declare prototypes.
4575
4576 * window.c (resize_window_apply): Make definition be "static" to
4577 match the prototype.
4578
562dd5e9
MR
45792011-06-10 Martin Rudalics <rudalics@gmx.at>
4580
4581 * window.c: Remove declarations of Qwindow_size_fixed,
4582 window_min_size_1, window_min_size_2, window_min_size,
4583 size_window, window_fixed_size_p, enlarge_window, delete_window.
4584 Remove static from declaration of Qdelete_window, it's
4585 temporarily needed by Fbury_buffer.
4586 (replace_window): Don't assign orig_top_line and
4587 orig_total_lines.
4588 (Fdelete_window, delete_window): Remove. Window deletion is
4589 handled by window.el.
640c8776
SM
4590 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4591 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4592 (Fdelete_other_windows): Remove. Deleting other windows is
4593 handled by window.el.
4594 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4595 handled in window.el.
4596 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4597 Window minimum sizes are handled in window.el.
4598 (shrink_windows, size_window, set_window_height)
4599 (set_window_width, change_window_heights, window_height)
4600 (window_width, CURBEG, CURSIZE, enlarge_window)
4601 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4602 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4603 handled in window.el.
4604 (make_dummy_parent): Rename to make_parent_window and give it a
4605 second argument horflag.
4606 (make_window): Don't set resize_proportionally any more.
4607 (Fsplit_window): Remove. Windows are split in window.el.
4608 (save_restore_action, save_restore_orig_size)
4609 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4610 Resize mini windows in window.el.
4611 (grow_mini_window, shrink_mini_window): Implement by calling
4612 Qresize_root_window_vertically, resize_window_check and
4613 resize_window_apply.
640c8776
SM
4614 (saved_window, Fset_window_configuration, save_window_save):
4615 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4616 resize_proportionally.
4617 (window_min_height, window_min_width): Move to window.el.
4618 (keys_of_window): Move bindings for delete-other-windows,
4619 split-window, delete-window and enlarge-window to window.el.
4620
4621 * buffer.c: Temporarily extern Qdelete_window.
4622 (Fbury_buffer): Temporarily call Qdelete_window instead of
4623 Fdelete_window (Fbury_buffer will move to window.el soon).
4624
4625 * frame.c (set_menu_bar_lines_1): Remove code handling
4626 orig_top_line and orig_total_lines.
4627
4628 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4629 set_window_height but set heights directly.
4630 (change_frame_size_1): Use resize_frame_windows.
4631
4632 * xdisp.c (init_xdisp): Don't use set_window_height but set
4633 heights directly.
4634
640c8776
SM
4635 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4636 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4637 run_window_configuration_change_hook.
4638
4639 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4640 instead of change_window_heights and run
4641 run_window_configuration_change_hook.
4642
1a13852e
MR
46432011-06-09 Martin Rudalics <rudalics@gmx.at>
4644
4645 * window.c (replace_window): Rename second argument REPLACEMENT to
4646 NEW. New third argument SETFLAG. Rewrite.
4647 (delete_window, make_dummy_parent): Call replace_window with
4648 third argument 1.
4649 (window_list_1): Move down in code.
4650 (run_window_configuration_change_hook): Move set_buffer part
4651 before select_frame_norecord part in order to unwind correctly.
4652 Rename count1 to count.
4653 (recombine_windows, delete_deletable_window, resize_root_window)
4654 (Fdelete_other_windows_internal)
4655 (Frun_window_configuration_change_hook, make_parent_window)
4656 (resize_window_check, resize_window_apply, Fresize_window_apply)
4657 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4658 (Fdelete_window_internal, Fresize_mini_window_internal):
4659 New functions.
1a13852e
MR
4660 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4661
f3d1777e
MR
46622011-06-08 Martin Rudalics <rudalics@gmx.at>
4663
496e208e
MR
4664 * window.h (window): Add some new members to window structure -
4665 normal_lines, normal_cols, new_total, new_normal, clone_number,
4666 splits, nest, prev_buffers, next_buffers.
4667 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4668 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4669
f3d1777e
MR
4670 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4671 Remove.
496e208e
MR
4672 (make_dummy_parent): Set new members of windows structure.
4673 (make_window): Move down in code. Handle new members of window
4674 structure.
4675 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4676 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4677 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4678 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4679 (Fset_window_next_buffers, Fset_window_clone_number):
4680 New functions.
496e208e
MR
4681 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4682 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4683 Doc-string fixes.
4684 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4685 Argument WINDOW can be now internal window too.
4686 (Fwindow_use_time): Move up in code.
4687 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4688 Rewrite doc-string.
4689 (Fset_window_configuration, saved_window)
4690 (Fcurrent_window_configuration, save_window_save): Handle new
4691 members of window structure.
b9e809c2
MR
4692 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4693 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4694 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4695 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4696 Qget_mru_window, Qresize_root_window,
4697 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4698 Qauto_buffer_name; staticpro them.
f3d1777e 4699
abde8f8c
MR
47002011-06-07 Martin Rudalics <rudalics@gmx.at>
4701
4702 * window.c (Fwindow_total_size, Fwindow_left_column)
4703 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4704 (Fwindow_list_1): New functions.
4705 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4706 (Fwindow_width, Fscroll_left, Fscroll_right):
4707 Use window_body_cols instead of window_box_text_cols.
4708 (delete_window, Fset_window_configuration):
4709 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4710 (delete_all_subwindows): Take a window as argument and not a
4711 structure. Rewrite.
190b47e6
MR
4712 (window_loop): Remove handling of GET_LRU_WINDOW and
4713 GET_LARGEST_WINDOW.
4714 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4715
4716 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4717 window_box_text_cols. delete_all_subwindows now takes a
4718 Lisp_Object as argument.
abde8f8c 4719
640c8776
SM
4720 * indent.c (compute_motion, Fcompute_motion):
4721 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4722
fa8a67e6
MR
4723 * frame.c (delete_frame): Call delete_all_subwindows with root
4724 window as argument.
4725
a54e3482
DC
47262011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4727
4728 * fns.c (Fputhash): Document return value.
4729
60002bf5
CY
47302011-06-06 Chong Yidong <cyd@stupidchicken.com>
4731
4732 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4733
0c671da6 47342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4735
b862a52a 4736 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4737
be44ca6c
PE
4738 Check for overflow when converting integer to cons and back.
4739 * charset.c (Fdefine_charset_internal, Fdecode_char):
4740 Use cons_to_unsigned to catch overflow.
4741 (Fencode_char): Use INTEGER_TO_CONS.
4742 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4743 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4744 * data.c (long_to_cons, cons_to_long): Remove.
4745 (cons_to_unsigned, cons_to_signed): New functions.
4746 These signal an error for invalid or out-of-range values.
4747 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4748 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4749 * font.c (Ffont_variation_glyphs):
4750 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4751 * lisp.h: Include <intprops.h>.
4752 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4753 (cons_to_signed, cons_to_unsigned): New decls.
4754 (long_to_cons, cons_to_long): Remove decls.
4755 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4756 (Fprimitive_undo): Use CONS_TO_INTEGER.
4757 * xfns.c (Fx_window_property): Likewise.
4758 * xselect.c: Include <limits.h>.
4759 (x_own_selection, selection_data_to_lisp_data):
4760 Use INTEGER_TO_CONS.
4761 (x_handle_selection_request, x_handle_selection_clear)
4762 (x_get_foreign_selection, Fx_disown_selection_internal)
4763 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4764 (lisp_data_to_selection_data): Use cons_to_unsigned.
4765 (x_fill_property_data): Use cons_to_signed.
4766 Report values out of range.
4767
d1f3d2af
PE
4768 Check for buffer and string overflow more precisely.
4769 * buffer.h (BUF_BYTES_MAX): New macro.
4770 * lisp.h (STRING_BYTES_MAX): New macro.
4771 * alloc.c (Fmake_string):
4772 * character.c (string_escape_byte8):
4773 * coding.c (coding_alloc_by_realloc):
4774 * doprnt.c (doprnt):
4775 * editfns.c (Fformat):
4776 * eval.c (verror):
4777 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4778 since they may not be the same number.
4779 * editfns.c (Finsert_char):
4780 * fileio.c (Finsert_file_contents):
4781 Likewise for BUF_BYTES_MAX.
4782
dd52fcea
PE
4783 * image.c: Use ptrdiff_t, not int, for sizes.
4784 (slurp_file): Switch from int to ptrdiff_t.
4785 All uses changed.
4786 (slurp_file): Check that file size fits in both size_t (for
4787 malloc) and ptrdiff_t (for sanity and safety).
4788
7f9bbdbb
PE
4789 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4790 if b->modtime has its maximal value.
4791
dfe18f82
PE
4792 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4793
84acfcf0
PE
4794 Don't assume time_t can fit into int.
4795 * buffer.h (struct buffer.modtime): Now time_t, not int.
4796 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4797 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4798
ccd9a01a
PE
4799 Minor fixes for signed vs unsigned integers.
4800 * character.h (MAYBE_UNIFY_CHAR):
4801 * charset.c (maybe_unify_char):
4802 * keyboard.c (read_char, reorder_modifiers):
4803 XINT -> XFASTINT, since the integer must be nonnegative.
4804 * ftfont.c (ftfont_spec_pattern):
4805 * keymap.c (access_keymap, silly_event_symbol_error):
4806 XUINT -> XFASTINT, since the integer must be nonnegative.
4807 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4808 since it makes no difference and we prefer signed.
4809 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4810 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4811 nonnegative.
4812
d6d100dd
SM
48132011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4814
4815 * window.h (Fwindow_frame): Declare.
4816
2b6148e4
PE
48172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4818
4819 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4820 (SPARE_MEMORY): Always define.
4821 (LARGE_REQUEST): Remove.
4822 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4823
f230ecc9
MR
48242011-06-06 Martin Rudalics <rudalics@gmx.at>
4825
727e958e
MR
4826 * lisp.h: Move EXFUNS for Fframe_root_window,
4827 Fframe_first_window and Fset_frame_selected_window to window.h.
4828
4829 * window.h: Move EXFUNS for Fframe_root_window,
4830 Fframe_first_window and Fset_frame_selected_window here from
4831 lisp.h.
4832
4833 * frame.c (Fwindow_frame, Fframe_first_window)
4834 (Fframe_root_window, Fframe_selected_window)
4835 (Fset_frame_selected_window): Move to window.c.
4836 (Factive_minibuffer_window): Move to minibuf.c.
4837 (Fother_visible_frames_p): New function.
4838
4839 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4840
f230ecc9
MR
4841 * window.c (decode_window, decode_any_window): Move up in code.
4842 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4843 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4844 (Fwindow_buffer): Move up and rewrite doc-string.
4845 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4846 (Fwindow_prev): New functions.
727e958e
MR
4847 (Fwindow_frame): Move here from frame.c. Accept any window as
4848 argument.
4849 (Fframe_root_window, Fframe_first_window)
4850 (Fframe_selected_window): Move here from frame.c. Accept frame
4851 or arbitrary window as argument. Update doc-strings.
4852 (Fminibuffer_window): Move up in code.
4853 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4854 (Fset_frame_selected_window): Move here from frame.c.
4855 Marginal rewrite.
727e958e
MR
4856 (Fselected_window, select_window, Fselect_window): Move up in
4857 code. Minor doc-string fixes.
f230ecc9 4858
4d09bcf6
PE
48592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4860
4861 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4862 Do not assume that spare memory exists; that assumption is valid
4863 only if SYSTEM_MALLOC.
4864 (LARGE_REQUEST): New macro, so that the issue of large requests
4865 is separated from the issue of spare memory.
4866
810928a2
AS
48672011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4868
172418ad
AS
4869 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4870 format. (Bug#8806)
4871
43f862f7
AS
4872 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4873
810928a2
AS
4874 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4875 before statements.
4876
a059fe24
JD
48772011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4878
4879 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4880
4881 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4882
4883 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4884 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4885
989bf368
JB
48862011-06-05 Juanma Barranquero <lekktu@gmail.com>
4887
4888 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4889
4b80f674
CY
48902011-06-04 Chong Yidong <cyd@stupidchicken.com>
4891
4892 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4893 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4894 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4895 New error handlers.
4b80f674
CY
4896 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4897 Obey Vx_select_enable_clipboard_manager. Catch errors in
4898 x_clipboard_manager_save (Bug#8779).
4899 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4900 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4901
99a33b77 49022011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4903
4904 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4905
99a33b77 49062011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4907
4908 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4909 in the current matrix if keep_current_p is non-zero.
4910
8264569d
EZ
49112011-06-04 Eli Zaretskii <eliz@gnu.org>
4912
4913 * bidi.c (bidi_level_of_next_char): Fix last change.
4914
57f97249
EZ
49152011-06-03 Eli Zaretskii <eliz@gnu.org>
4916
fec2107c 4917 Support bidi reordering of text covered by display properties.
57f97249 4918
fec2107c
EZ
4919 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4920 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4921 (bidi_cache_search, bidi_cache_iterator_state)
4922 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4923 (bidi_level_of_next_char, bidi_move_to_visually_next):
4924 Support character positions inside a run of characters covered by a
fec2107c
EZ
4925 display string.
4926 (bidi_paragraph_init, bidi_resolve_explicit_1)
4927 (bidi_level_of_next_char): Call bidi_fetch_char and
4928 bidi_fetch_char_advance instead of FETCH_CHAR and
4929 FETCH_CHAR_ADVANCE.
4930 (bidi_init_it): Initialize new members.
4931 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4932 definitions.
4933 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4934 instead of using explicit *_CHAR codes.
d6d100dd
SM
4935 (bidi_resolve_explicit, bidi_resolve_weak):
4936 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4937 bidirectional text is supported only in multibyte buffers.
4938 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4939 it to initialize the frame_window_p member of struct bidi_it.
4940 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4941 (bidi_resolve_explicit, bidi_resolve_weak)
4942 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4943 bidi_it->nchars is non-positive.
4944 (bidi_level_of_next_char): Don't try to lookup the cache for the
4945 next/previous character if nothing is cached there yet, or if we
4946 were just reseat()'ed to a new position.
c40e2fb2 4947
0e14fe90
EZ
4948 * xdisp.c (set_cursor_from_row): Set start and stop points
4949 according to the row's direction when priming the loop that looks
4950 for the glyph on which to display cursor.
4951 (single_display_spec_intangible_p): Function deleted.
4952 (display_prop_intangible_p): Reimplement to call
4953 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4954 Accept 3 additional arguments needed by handle_display_spec.
4955 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4956 values: lists, `(when COND...)' forms, etc.
4957 (single_display_spec_string_p): Support property values that are
4958 lists with the argument STRING its top-level element.
4959 (display_prop_string_p): Fix the condition for processing a
4960 property that is a list to be consistent with handle_display_spec.
fec2107c 4961 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4962 last portion of handle_display_prop.
4963 (compute_display_string_pos): Accept additional argument
4964 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4965 value of a `display' property is a "replacing spec".
4966 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4967 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4968 the display property, but just return a value indicating whether
4969 the display property will replace the characters it covers.
4970 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4971 frame_window_p members of struct bidi_it.
d6d100dd
SM
4972 (compute_display_string_pos, compute_display_string_end):
4973 New functions.
fec2107c
EZ
4974 (push_it): Accept second argument POSITION, where pop_it should
4975 jump to continue iteration.
4976 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4977
fec2107c
EZ
4978 * keyboard.c (adjust_point_for_property): Adjust the call to
4979 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4980
4981 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4982 (bidi_init_it): Update prototypes.
4983 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4984 (compute_display_string_pos, compute_display_string_end):
4985 Declare prototypes.
fec2107c
EZ
4986 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4987 EMACS_INT.
fc6f18ce 4988
40087514 49892011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4990
57f53182
PE
4991 Malloc failure behavior now depends on size of allocation.
4992 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4993 * lisp.h: Change signatures accordingly.
4994 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4995 All callers changed. (Bug#8762)
4996
4997 * gnutls.c: Use Emacs's memory allocators.
4998 Without this change, the gnutls library would invoke malloc etc.
4999 directly, which causes problems on non-SYNC_INPUT hosts, and which
5000 runs afoul of improving memory_full behavior. (Bug#8761)
5001 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5002 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5003 xfree instead of the default malloc, realloc, free.
5004 (Fgnutls_boot): No need to check for memory allocation failure,
5005 since xmalloc does that for us.
5006
ac32cd99 5007 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5008 * category.c (hash_get_category_set):
5009 * ccl.c (ccl_driver):
5010 * charset.c (Fdefine_charset_internal):
5011 * charset.h (struct charset.hash_index):
5012 * composite.c (get_composition_id, gstring_lookup_cache)
5013 (composition_gstring_put_cache):
5014 * composite.h (struct composition.hash_index):
5015 * dispextern.h (struct image.hash):
5016 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5017 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5018 (hashfn_equal, hashfn_user_defined, make_hash_table)
5019 (maybe_resize_hash_table, hash_lookup, hash_put)
5020 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5021 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5022 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5023 * image.c (make_image, search_image_cache, lookup_image)
5024 (xpm_put_color_table_h):
5025 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5026 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5027 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5028 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5029 * alloc.c (allocate_vectorlike):
5030 Check for overflow in vector size calculations.
5031 * ccl.c (ccl_driver):
5032 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5033 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5034 need to be updated by these changes.
40087514
PE
5035 * fns.c (make_hash_table, maybe_resize_hash_table):
5036 Check for integer overflow with large hash tables.
0de4bb68
PE
5037 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5038 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5039 (SXHASH_REDUCE): New macro.
5040 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5041 Use it instead of discarding useful hash info with large hash values.
5042 (sxhash_float): New function.
5043 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5044 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5045 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5046 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5047 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5048 Adjust signatures to match updated version of code.
5049 (consing_since_gc): Now EMACS_INT, since a single hash table can
5050 use more than INT_MAX bytes.
5051
698d32e2
DN
50522011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5053
5054 Make it possible to build with GCC-4.6+ -O2 -flto.
5055
5056 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5057
fd6fa53f
SM
50582011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5059
5060 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5061 Call minibuffer-inactive-mode.
5062
864db017
JB
50632011-05-31 Juanma Barranquero <lekktu@gmail.com>
5064
5065 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5066 Update dependencies.
5067
2ad0baf4
DN
50682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5069
5070 * data.c (init_data): Remove code for UTS, this system is not
5071 supported anymore.
5072
4fcc2638
DN
50732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5074
5075 Don't force ./temacs to start in terminal mode.
5076
5077 * frame.c (make_initial_frame): Initialize faces in all cases, not
5078 only when CANNOT_DUMP is defined.
5079 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5080
c56e0fd5
DN
50812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5082
5083 * dispnew.c (add_window_display_history): Use const for the string
5084 pointer. Remove declaration, not needed.
5085
333d54da 50862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5087
55d4c1b2 5088 Use 'inline', not 'INLINE'.
333d54da 5089 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5090 * alloc.c, fontset.c (INLINE): Remove.
5091 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5092 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5093 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5094 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5095 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5096
738db178
DN
50972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5098
5099 Make it possible to run ./temacs.
5100
5101 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5102 syms_of_callproc does the same thing. Remove test for
5103 "initialized", do it in the caller.
5104 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5105
620c53a6
SM
51062011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5107
5108 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5109 (read_minibuf): Use get_minibuffer.
5110 (syms_of_minibuf): Use DEFSYM.
5111 (Qmetadata): New var.
5112 * data.c (Qbuffer): Don't make it static.
5113 (syms_of_data): Use DEFSYM.
5114
e003a292
PE
51152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5118 (CCL_CODE_MIN): New macro.
5119
ed008a6d
PE
51202011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5121
3687c2ef
PE
5122 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5123
ed008a6d
PE
5124 * eval.c (Qdebug): Now static.
5125 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5126 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5127 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5128
d66c4c7c
CY
51292011-05-29 Chong Yidong <cyd@stupidchicken.com>
5130
5131 * image.c: Various fixes to ImageMagick code comments.
5132 (Fimagemagick_types): Doc fix.
5133
5fbc2025
PE
51342011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5135
0196f88a
PE
5136 Minor fixes prompted by GCC 4.6.0 warnings.
5137
5138 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5139
5fbc2025
PE
5140 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5141 (x_clipboard_manager_save_all): Move extern decl to ...
5142 * xterm.h: ... here, so that it can be checked for consistency.
5143
1dd3c2d9
CY
51442011-05-29 Chong Yidong <cyd@stupidchicken.com>
5145
5146 * xselect.c (x_clipboard_manager_save_frame)
5147 (x_clipboard_manager_save_all): New functions.
5148 (Fx_clipboard_manager_save): Lisp function deleted.
5149
5150 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5151 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5152
5153 * xterm.h: Update prototype.
5154
5ba6571d
WX
51552011-05-28 William Xu <william.xwl@gmail.com>
5156
5157 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5158 exiting (Bug#8239).
5159
3eaff834
JM
51602011-05-28 Jim Meyering <meyering@redhat.com>
5161
e1900994 5162 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5163 * fns.c (to_uchar): Define.
5164 (crypto_hash_function): Use it to convert some newly-signed
5165 variables to unsigned, to avoid sign-extension bugs. For example,
5166 without this change, (md5 "truc") would evaluate to
5167 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5168 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5169 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5170
0f6990a7
PE
51712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 Integer overflow fixes.
c8a9ca5a 5174
08686060
PE
5175 * dbusbind.c: Serial number integer overflow fixes.
5176 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5177 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5178 to hold a serial number that is too large for a fixnum.
5179 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5180 Check for serial numbers out of range. Decode any serial number
59568bf0 5181 that was so large that it became a float. (Bug#8722)
08686060 5182
2d1fc3c7
PE
5183 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5184 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5185 Use XFASTINT rather than XUINT when numbers are nonnegative.
5186 (xd_append_arg, Fdbus_method_return_internal):
5187 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5188 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5189 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5190 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5191 (Bug#8722)
2d1fc3c7 5192
c8a9ca5a
PE
5193 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5194
519e1d69
PE
5195 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5196
30569699
PE
5197 ccl: add integer overflow checks
5198 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5199 (IN_INT_RANGE): New macros.
5200 (ccl_driver): Use them to check for integer overflow when
5201 decoding a CCL program. Many of the new checks are whether XINT (x)
5202 fits in int; it doesn't always, on 64-bit hosts. The new version
5203 doesn't catch all possible integer overflows, but it's an
847044ea 5204 improvement. (Bug#8719)
30569699 5205
c11285dc
PE
5206 * alloc.c (make_event_array): Use XINT, not XUINT.
5207 There's no need for unsigned here.
5208
fdccd48e
PE
5209 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5210 This follows up to the 2011-05-06 change that substituted uintptr_t
5211 for EMACS_INT. This case wasn't caught back then.
5212
37910ab2
PE
5213 Rework Fformat to avoid integer overflow issues.
5214 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5215 now (part of C89). Include <verify.h>.
5216 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5217 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5218 (Fformat): Avoid the prepass trying to compute sizes; it was only
5219 approximate and thus did not catch overflow reliably. Instead, walk
5220 through the format just once, formatting and computing sizes as we go,
5221 checking for integer overflow at every step, and allocating a larger
5222 buffer as needed. Keep track separately whether the format is
5223 multibyte. Keep only the most-recently calculated precision, rather
5224 than them all. Record whether each argument has been converted to
5225 string. Use EMACS_INT, not int, for byte and char and arg counts.
5226 Support field widths and precisions larger than INT_MAX. Avoid
5227 sprintf's undefined behavior with conversion specifications such as %#d
5228 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5229 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5230 formatting out-of-range floating point numbers with int
9173deec 5231 formats. (Bug#8668)
37910ab2 5232
2e6578fb
PE
5233 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5234
0ae6bdee
PE
5235 * data.c: Avoid integer truncation in expressions involving floats.
5236 * data.c: Include <intprops.h>.
5237 (arith_driver): When there's an integer overflow in an expression
5238 involving floating point, convert the integers to floating point
5239 so that the resulting value does not suffer from catastrophic
5240 integer truncation. For example, on a 64-bit host (* 4
5241 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5242 Do not rely on undefined behavior after integer overflow.
5243
de883a70
PE
5244 merge count_size_as_multibyte, parse_str_to_multibyte
5245 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5246 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5247 Check for integer overflow.
5248 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5249 since it's now a duplicate of the other. This is more of
5250 a character than a buffer op, so better that it's in character.c.
5251 * fns.c, print.c: Adjust to above changes.
5252
2ff916cb
PE
52532011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5254
5255 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5256
f1b54466
PE
52572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5258
fb1ac845
PE
5259 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5260 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5261 (x_clipboard_manager_save): Now static.
5262 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5263
f1b54466
PE
5264 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5265 (crypto_hash_function): Now static.
5266 Fix pointer signedness problems. Avoid unnecessary initializations.
5267
a9f737ee
CY
52682011-05-27 Chong Yidong <cyd@stupidchicken.com>
5269
5270 * termhooks.h (Vselection_alist): Make it terminal-local.
5271
5272 * terminal.c (create_terminal): Initialize it.
5273
5274 * xselect.c: Support for clipboard managers.
5275 (Vselection_alist): Move to termhooks.h as terminal-local var.
5276 (LOCAL_SELECTION): New macro.
5277 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5278 (symbol_to_x_atom): Remove gratuitous arg.
5279 (x_handle_selection_request, lisp_data_to_selection_data)
5280 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5281 (x_own_selection, x_get_local_selection, x_convert_selection):
5282 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5283 (some_frame_on_display): Delete unused function.
5284 (Fx_own_selection_internal, Fx_get_selection_internal)
5285 (Fx_disown_selection_internal, Fx_selection_owner_p)
5286 (Fx_selection_exists_p): New optional frame arg.
5287 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5288 (x_handle_selection_clear): Don't treat other terminals with the
5289 same keyboard specially. Use the terminal-local Vselection_alist.
5290 (x_clear_frame_selections): Use Frun_hook_with_args.
5291
5292 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5293
5294 * xterm.h: Add support for those atoms.
5295
e067f0c1
CY
52962011-05-26 Chong Yidong <cyd@stupidchicken.com>
5297
5298 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5299 (converted_selections, conversion_fail_tag): New global variables.
5300 (x_selection_request_lisp_error): Free the above.
5301 (x_get_local_selection): Remove unnecessary code.
5302 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5303 of converted selections stored in converted_selections.
5304 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5305 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5306 (x_convert_selection): New function.
5307 (x_handle_selection_event): Simplify.
5308 (x_get_foreign_selection): Don't ignore incoming requests while
5309 waiting for an answer; this will fail when we implement
5310 SAVE_TARGETS, and seems unnecessary anyway.
5311 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5312 (Vx_sent_selection_functions): Doc fix.
5313
0f4aebc0
LL
53142011-05-26 Leo Liu <sdl.web@gmail.com>
5315
5316 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5317
e61124cd
YM
53182011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5319
5320 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5321
5322 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5323 for fringe update if it has periodic bitmap.
ac389d0c 5324 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5325 and fringe_bitmap_periodic_p.
5326
5327 * fringe.c (get_fringe_bitmap_data): New function.
5328 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5329 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5330 row. Mark glyph row for fringe update if periodicity changed.
5331
5332 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5333 for fringe update unless it has periodic bitmap.
5334
f16d9837
KH
53352011-05-25 Kenichi Handa <handa@m17n.org>
5336
5337 * xdisp.c (get_next_display_element): Set correct it->face_id for
5338 a static composition.
5339
e1b90ef6
LL
53402011-05-24 Leo Liu <sdl.web@gmail.com>
5341
5342 * deps.mk (fns.o):
5343 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5344
5345 * fns.c (crypto_hash_function, Fsha1): New function.
5346 (Fmd5): Use crypto_hash_function.
5347 (syms_of_fns): Add Ssha1.
5348
7400048f
PE
53492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5350
5351 * gnutls.c: Remove unused macros.
5352 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5353 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5354 Remove macros that are defined and never used.
5355 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5356
abb71cf4
CY
53572011-05-22 Chong Yidong <cyd@stupidchicken.com>
5358
5359 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5360 (Fx_get_selection_internal): Minor cleanup.
5361 (Fx_own_selection_internal): Rename arguments for consistency with
5362 select.el.
5363
6307db39
PE
53642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5365
5366 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5367
f3d4e0a4
CY
53682011-05-22 Chong Yidong <cyd@stupidchicken.com>
5369
5370 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5371
4d8ade89
YM
53722011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5373
5374 * dispnew.c (scrolling_window): Don't exclude the case that the
5375 last enabled row in the desired matrix touches the bottom boundary.
5376
32078c8d
GM
53772011-05-21 Glenn Morris <rgm@gnu.org>
5378
5379 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5380 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5381 and add some more files.
32078c8d 5382
7285dc67
EZ
53832011-05-20 Eli Zaretskii <eliz@gnu.org>
5384
5385 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5386 report_file_error introduced by the change from 2011-05-07.
5387
89d1bd22
PE
53882011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5389
5390 * systime.h (Time): Define only if emacs is defined.
5391 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5392 where the include path doesn't have X11/X.h by default. See
5393 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5394
e23640bb 53952011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5396
5397 * composite.c (find_automatic_composition): Fix previous change.
5398
b9704ad9
GM
53992011-05-20 Glenn Morris <rgm@gnu.org>
5400
5401 * lisp.mk: New file, split from Makefile.in.
5402 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5403 (shortlisp): Remove.
5404 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5405
4a720484
GM
54062011-05-19 Glenn Morris <rgm@gnu.org>
5407
5408 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5409 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5410 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5411 (lisp): Set the order to that of loadup.el.
5412 (shortlisp): Make it a copy of $lisp.
5413 (SOME_MACHINE_LISP): Remove.
5414 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5415 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5416
a28d4396
KH
54172011-05-18 Kenichi Handa <handa@m17n.org>
5418
5419 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5420 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5421 (find_automatic_composition): Mostly rewrite for efficiency.
5422
a2b1fa8e
JB
54232011-05-18 Juanma Barranquero <lekktu@gmail.com>
5424
5425 * makefile.w32-in: Update dependencies.
5426
8e1f5610
CS
54272011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5428
5429 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5430 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5431
7025ee00 54322011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5433
cdfa6eab
PE
5434 Fix some integer overflow issues, such as string length overflow.
5435
06d6db33
PE
5436 * insdel.c (count_size_as_multibyte): Check for string overflow.
5437
2b4560a8
PE
5438 * character.c (lisp_string_width): Check for string overflow.
5439 Use EMACS_INT, not int, for string indexes and lengths; in
5440 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5441 the resulting string length overflows an EMACS_INT; instead,
5442 report a string overflow if no precision given. When checking for
5443 precision exhaustion, use a check that cannot possibly have
5444 integer overflow. (Bug#8675)
5445 * character.h (lisp_string_width): Adjust to new signature.
5446
cb93f9be
PE
5447 * alloc.c (string_overflow): New function.
5448 (Fmake_string): Use it. This doesn't change behavior, but saves
5449 a few bytes and will simplify future changes.
5450 * character.c (string_escape_byte8): Likewise.
5451 * lisp.h (string_overflow): New decl.
5452
1a1f3366
PE
5453 Fixups, following up to the user-interface timestamp change.
5454 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5455 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5456 * msdos.c (mouse_get_pos): Likewise.
5457 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5458 * w32gui.h (Time): Define by including "systime.h" rather than by
5459 declaring it ourselves. (Bug#8664)
5460
d4e3e4d3
PE
5461 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5462 * image.c (clear_image_cache): Likewise.
5463
f6a24d19
PE
5464 * term.c (term_mouse_position): Don't assume time_t wraparound.
5465
08dc5ae6
PE
5466 Be more systematic about user-interface timestamps.
5467 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5468 and sometimes 'EMACS_UINT', to represent these timestamps.
5469 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5470 This makes the code easier to follow, and makes it easier to catch
5471 integer overflow bugs such as Bug#8664.
5472 * frame.c (Fmouse_position, Fmouse_pixel_position):
5473 Use Time, not unsigned long, for user-interface timestamps.
5474 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5475 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5476 * keyboard.h (last_event_timestamp): Likewise.
5477 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5478 * menu.h (xmenu_show): Likewise.
5479 * term.c (term_mouse_position): Likewise.
5480 * termhooks.h (struct input_event.timestamp): Likewise.
5481 (struct terminal.mouse_position_hook): Likewise.
5482 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5483 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5484 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5485 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5486 what it was before.
5487 * menu.h, termhooks.h: Include "systime.h", for Time.
5488
8e55734a
PE
5489 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5490 Don't assume that the difference between two unsigned long values
5491 can fit into an integer. At this point, we know button_down_time
5492 <= event->timestamp, so the difference must be nonnegative, so
5493 there's no need to cast the result if double-click-time is
5494 nonnegative, as it should be; check that it's nonnegative, just in
5495 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5496 apart (about 25 days). (Bug#8664)
8e55734a 5497
841f1b75 5498 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5499 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5500
3e26f69c
PE
5501 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5502 that always fit in int. Use a sentinel instead of a counter, to
5503 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5504 * frame.h (struct frame): Use int for menu_bar_items_used
5505 instead of EMACS_INT, since it always fits in int.
3e26f69c 5506
5cc152c0
PE
5507 * menu.c (grow_menu_items): Check for int overflow.
5508
d89eb65e
PE
5509 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5510
5235bd3e
PE
5511 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5512 Before, the code was not consistent. These values cannot exceed
5513 2**31 - 1 so there's no need to make them unsigned.
5514 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5515 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5516 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5517 as modifiers.
5518 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5519
bc827e23
PE
5520 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5521 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5522 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5523 presumably because the widths might not match.
5524
78eb494e
PE
5525 * window.c (size_window): Avoid needless test at loop start.
5526
04f2d78b
CB
55272011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5528
5529 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5530
d2fc7e3d 55312011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5532
5533 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5534
d2fc7e3d 55352011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5536
5537 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5538 `width' to `bar_area_x' and `bar_area_width', respectively.
5539 (x_scroll_run): Take account of fringe background extension.
5540
04f2d78b
CB
5541 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5542 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5543 `bar_area_width', respectively.
5544 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5545 background extension.
5546
79b70037
GM
55472011-05-10 Jim Meyering <meyering@redhat.com>
5548
5549 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5550
2f142cc5
JB
55512011-05-10 Juanma Barranquero <lekktu@gmail.com>
5552
5553 * image.c (Finit_image_library): Return t for built-in image types,
5554 like pbm and xbm. (Bug#8640)
5555
57679c86
AS
55562011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5557
5558 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5559
888c9e86
EZ
55602011-05-07 Eli Zaretskii <eliz@gnu.org>
5561
b0512a1d
EZ
5562 * w32console.c (Fset_screen_color): Doc fix.
5563 (Fget_screen_color): New function.
5564 (syms_of_ntterm): Defsubr it.
5565
7285dc67
EZ
5566 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5567 unlink the temporary file if Fcall_process didn't create it in the
5568 first place.
5569 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5570 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5571 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5572 cue to call_process_cleanup not to close that handle.
5573
4d3fcc8e
BK
55742011-05-07 Ben Key <bkey76@gmail.com>
5575
5576 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5577 one of two shell specific rules, either bootstrap-temacs-CMD or
5578 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5579 to the previous implementation of the bootstrap-temacs rule.
5580 The bootstrap-temacs-CMD rule is similar to the previous
5581 implementation of the bootstrap-temacs rule except that it
5582 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5583 variable.
5584
5585 These changes, along with some changes to nt/configure.bat,
5586 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5587 earlier fix to add support for --cflags and --ldflags options
5588 that include quotes so that it works whether make uses cmd or
5589 sh as the shell.
5590
b4289b64
MA
55912011-05-06 Michael Albinus <michael.albinus@gmx.de>
5592
5593 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5594 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5595 is a constant.
5596 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5597 a string. Handle both cases.
5598 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5599 (Fdbus_register_method): Use Qinvalid_function.
5600
af4c0e28
JB
56012011-05-06 Juanma Barranquero <lekktu@gmail.com>
5602
5603 * makefile.w32-in: Update dependencies.
5604 (LISP_H): Add inttypes.h and stdin.h.
5605 (PROCESS_H): Add unistd.h.
5606
c51453d9
EZ
56072011-05-06 Eli Zaretskii <eliz@gnu.org>
5608
5609 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5610 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5611
8ff0ac3c 56122011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5613
4c4b566b
PE
5614 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5615
aab2b9b5
PE
5616 * term.c (vfatal): Remove stray call to va_end.
5617 It's not needed and the C Standard doesn't allow it here anyway.
5618
c378da0b
PE
5619 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5620 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5621
288b08c7
PE
5622 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5623 bytes.
5624
e3601888
PE
5625 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5626
db6c0e74
PE
5627 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5628
dd5963ea
PE
5629 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5630
88c9450f
PE
5631 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5632
2f9442b8
PE
5633 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5634
c032b5f8
PE
5635 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5636 * charset.c (Fdefine_charset_internal): Don't initialize
5637 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5638 32-bit int (Bug#8600).
a108c10b
PE
5639
5640 * lread.c (read_integer): Be more consistent with string-to-number.
5641 Use string_to_number to do the actual conversion; this avoids
5642 rounding errors and fixes some other screwups. Without this fix,
5643 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5644 (digit_to_number): Move earlier, for benefit of read_integer.
5645 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5646 not a digit in any supported base. (Bug#8602)
a108c10b 5647
ad5f9eea
PE
5648 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5649
aec1708a
PE
5650 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5651 to match comment at start of function. This also removes a
5652 GCC warning about overflow in a 32+64-bit port.
5653
47be4ab5
PE
5654 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5655
371cac43
PE
5656 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5657 Reported by Stefan Monnier in
5658 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5659 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5660 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5661
d01a7826
PE
5662 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5663 (EMACS_UINTPTR): Likewise, with uintptr_t.
5664
7fd47d5c
PE
5665 * lisp.h: Prefer 64-bit EMACS_INT if available.
5666 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5667 on 32-bit hosts that have 64-bit int, so that they can access
5668 large files.
122b0c86
PE
5669 However, temporarily disable this change unless the temporary
5670 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5671
8727937b
PE
5672 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5673
8ac068ac
PE
5674 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5675 This removes an assumption that EMACS_INT and long are the same
5676 width as pointers. The assumption is true for Emacs porting targets
5677 now, but we want to make other targets possible.
5678 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5679 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5680 In the rest of the code, change types of integers that hold casted
5681 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5682 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5683 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5684 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5685 No need to cast type when ORing.
5686 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5687 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5688 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5689 assume EMACS_INT is the same width as char *.
5690 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5691 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5692 Remove no-longer-needed casts.
5693 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5694 (xg_tool_bar_help_callback, xg_make_tool_item):
5695 Use EMACS_INTPTR to hold an integer
5696 that will be cast to void *; this can avoid a GCC warning
5697 if EMACS_INT is not the same width as void *.
5698 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5699 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5700 (current_message_1, set_message_1):
5701 Use a local to convert to proper width without a cast.
5702 * xmenu.c (dialog_selection_callback): Likewise.
5703
ede49d71
PE
5704 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5705 Also, don't assume VALBITS / RAND_BITS is less than 5,
5706 and don't rely on undefined behavior when shifting a 1 left into
5707 the sign bit.
5708 * lisp.h (get_random): Change signature to match.
5709
2f30ecd0
PE
5710 * lread.c (hash_string): Use size_t, not int, for hash computation.
5711 Normally we prefer signed values; but hashing is special, because
5712 it's better to use unsigned division on hash table sizes so that
5713 the remainder is nonnegative. Also, size_t is the natural width
5714 for hashing into memory. The previous code used 'int', which doesn't
5715 retain enough info to hash well into very large tables.
5716 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5717
2a866e7b
PE
5718 * dbusbind.c: Don't possibly lose pointer info when converting.
5719 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5720 Use XPNTR rather than XHASH, so that the high-order bits of
5721 the pointer aren't lost when converting through void *.
5722
51639eac
PE
5723 * eval.c (Fautoload): Don't double-shift a pointer.
5724
92394119
PE
5725 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5726
dbdb9a7c
JB
57272011-05-06 Juanma Barranquero <lekktu@gmail.com>
5728
5729 * gnutls.c (DEF_GNUTLS_FN):
5730 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5731
db7a0b4f
AS
57322011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5733
5734 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5735 marker. (Bug#8610)
5736
f7ff1b0f 57372011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5738
5739 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5740 New version that can reserve upto 2GB of heap space.
5741
f7ff1b0f 57422011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5743
5744 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5745
639c109b
TZ
57462011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5747
5748 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5749 `gnutls_certificate_set_x509_key_file'.
5750
d2127135
JB
57512011-05-05 Juanma Barranquero <lekktu@gmail.com>
5752
5753 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5754 Update dependencies.
5755
e968f4f3
JB
57562011-05-04 Juanma Barranquero <lekktu@gmail.com>
5757
5758 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5759 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5760 Remove unused parameter `fildes'.
5761 * process.c (read_process_output, send_process): Don't pass it.
5762
84d358f0
JB
57632011-05-04 Juanma Barranquero <lekktu@gmail.com>
5764
5765 Fix previous change: the library cache is defined in w32.c.
5766 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5767 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5768
0898ca10
JB
57692011-05-04 Juanma Barranquero <lekktu@gmail.com>
5770
5771 Implement dynamic loading of GnuTLS on Windows.
5772
5773 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5774 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5775 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5776 Declare.
5777
5778 * gnutls.c (Qgnutls_dll): Define.
5779 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5780 (gnutls_*): Declare function pointers.
5781 (init_gnutls_functions): New function to initialize function pointers.
5782 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5783 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5784 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5785 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5786 (emacs_gnutls_write, emacs_gnutls_read)
5787 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5788 (Fgnutls_available_p): New function.
5789 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5790 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5791 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5792
5793 * image.c: Include w32.h.
5794 (Vimage_type_cache): Delete.
5795 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5796 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5797 (w32_delayed_load): Move to w32.c.
5798
5799 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5800
5801 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5802 (w32_delayed_load): Move from image.c. When loading a library, record
5803 its filename in the :loaded-from property of the library id.
5804 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5805 Initialize and staticpro them.
5806 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5807
5808 * process.c: Include lisp.h before w32.h, not after.
5809 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5810 instead of gnutls_record_check_pending.
5811
5812 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5813
ff4de4aa
TZ
58142011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5815
5816 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5817 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5818 as passed in.
5819
abe95abb
JD
58202011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5821
5822 * xterm.c (x_set_frame_alpha): Do not set property on anything
5823 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5824
e16e55d4
JB
58252011-05-02 Juanma Barranquero <lekktu@gmail.com>
5826
5827 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5828
bafcf6a5
JB
58292011-05-02 Juanma Barranquero <lekktu@gmail.com>
5830
5831 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5832 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5833 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5834 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5835 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5836 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5837 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5838 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5839 (Qgnutls_bootprop_callbacks_verify): Make static.
5840
e7a6747f
AS
58412011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5842
19ed11ba
AS
5843 * callproc.c: Indentation fixup.
5844
e7a6747f 5845 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5846 (wait_for_termination, interruptible_wait_for_termination):
5847 Move after wait_for_termination_1.
e7a6747f 5848
1ef14cb4
LMI
58492011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5850
5851 * sysdep.c (interruptible_wait_for_termination): New function
5852 which is like wait_for_termination, but allows keyboard
5853 interruptions.
5854
5855 * callproc.c (Fcall_process): Add (:file "file") as an option for
5856 the STDOUT buffer.
5857 (Fcall_process_region): Ditto.
5858
330d880c
EZ
58592011-04-30 Eli Zaretskii <eliz@gnu.org>
5860
8db90b73
EZ
5861 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5862 rather than `XVECTOR (FOO)->size'.
5863
330d880c
EZ
5864 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5865 inttypes.h, as a gnulib replacement is used if it not available in
5866 system headers.
5867
15cbd324
EZ
58682011-04-21 Eli Zaretskii <eliz@gnu.org>
5869
5870 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5871 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5872 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5873
5874 * coding.c (coding_alloc_by_realloc): Error out if destination
5875 will grow beyond MOST_POSITIVE_FIXNUM.
5876 (decode_coding_emacs_mule): Abort if there isn't enough place in
5877 charbuf for the composition carryover bytes. Reserve an extra
5878 space for up to 2 characters produced in a loop.
5879 (decode_coding_iso_2022): Abort if there isn't enough place in
5880 charbuf for the composition carryover bytes.
5881
58822011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5883
ae940cca
EZ
5884 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5885 aborting when %lld or %lll format is passed.
5886 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5887 %llo or %llx format is passed. (Bug#8545)
5888
03ab8921
EZ
5889 * window.c (window_scroll_line_based): Use a marker instead of
5890 simple variables to record original value of point. (Bug#7952)
5891
afda1437
EZ
5892 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5893 produced by %s or %c overflows available buffer space. (Bug#8545)
5894
f76dee0c
PE
58952011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5896
5897 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5898 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5899
fdc5744d
JB
59002011-04-28 Juanma Barranquero <lekktu@gmail.com>
5901
5902 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5903
638f053a
JB
59042011-04-28 Juanma Barranquero <lekktu@gmail.com>
5905
5906 * keyboard.c (Qdelayed_warnings_hook): Define.
5907 (command_loop_1): Run `delayed-warnings-hook'
5908 if Vdelayed_warnings_list is non-nil.
5909 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5910 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5911
d178f871
EZ
59122011-04-28 Eli Zaretskii <eliz@gnu.org>
5913
5914 * doprnt.c (doprnt): Don't return value smaller than the buffer
5915 size if the message was truncated. (Bug#8545).
5916
b124fd93
JB
59172011-04-28 Juanma Barranquero <lekktu@gmail.com>
5918
5919 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5920 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5921
e810457d
PE
59222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5923
5924 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5925
ea51cceb
JB
59262011-04-27 Juanma Barranquero <lekktu@gmail.com>
5927
5928 * makefile.w32-in: Update dependencies.
5929
94dcfacf
EZ
59302011-04-27 Eli Zaretskii <eliz@gnu.org>
5931
5932 Improve `doprnt' and its usage. (Bug#8545)
5933 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5934 `format_end'. Remove support for %l as a conversion specifier.
5935 Don't use xrealloc. Improve diagnostics when the %l size modifier
5936 is used. Update the commentary.
5937
5938 * eval.c (verror): Simplify calculation of size_t.
5939
5940 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5941 messages.
5942
f61f41d7
PE
59432011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5944
5945 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5946 change.
5947
96fb4434
PE
59482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5949
5950 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5951 This makes this file independent of the recent pseudovector change.
5952
671875da 59532011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5954
69e9b5a3
PE
5955 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5956
b5f869a7 5957 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5958 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5959 Remove unused local.
c8926152 5960 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5961
841a1577 5962 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5963 GCC 4.6.0 optimizes based on type-based alias analysis.
5964 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5965 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5966 != &v->size, and therefore "v->size = 1; b->size = 2; return
5967 v->size;" must therefore return 1. This assumption is incorrect
5968 for Emacs, since it type-puns struct Lisp_Vector * with many other
5969 types. To fix this problem, this patch adds a new type struct
f904488f 5970 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5971 and pseudovectors, and helps optimizing compilers not get fooled
5972 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5973 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5974 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5975 the size member.
eab3844f
PE
5976 (XSETPVECTYPE): Rewrite in terms of new macro.
5977 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5978 This is a bit clearer, and further avoids the possibility of
5979 undesirable aliasing.
5980 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5981 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5982 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5983 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5984 (ASIZE): Now uses header.size rather than size.
5985 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5986 to avoid the hassle of writing XVECTOR (foo)->header.size.
5987 (struct vectorlike_header): New type.
eab3844f
PE
5988 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5989 object, to help avoid aliasing.
5990 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5991 (SUBRP): Likewise, since Lisp_Subr is a special case.
5992 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5993 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5994 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5995 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5996 changed to be "header.size" and "header.next".
5997 * buffer.h (struct buffer): Likewise.
5998 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5999 * frame.h (struct frame): Likewise.
6000 * process.h (struct Lisp_Process): Likewise.
6001 * termhooks.h (struct terminal): Likewise.
6002 * window.c (struct save_window_data, struct saved_window): Likewise.
6003 * window.h (struct window): Likewise.
6004 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6005 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6006 * buffer.c (init_buffer_once): Likewise.
6007 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6008 special case.
6009 * process.c (Fformat_network_address): Use local var for size,
6010 for brevity.
6011
0df1eac5
PE
6012 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6013
847ab9d1 6014 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6015 * data.c (atof): Remove decl; no longer used or needed.
6016 (digit_to_number): Move to lread.c.
6017 (Fstring_to_number): Use new string_to_number function, to be
6018 consistent with how the Lisp reader treats infinities and NaNs.
6019 Do not assume that floating-point numbers represent EMACS_INT
6020 without losing information; this is not true on most 64-bit hosts.
6021 Avoid double-rounding errors, by insisting on integers when
6022 parsing non-base-10 numbers, as the documentation specifies.
6023 * lisp.h (string_to_number): New decl, replacing ...
6024 (isfloat_string): Remove.
bc0a5c13 6025 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6026 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6027 appears to have been a coding error. Similarly, do not accept
6028 strings like +-1e0 as floating point numbers. Do not report
6029 overflow for integer overflows unless the base is not 10 which
6030 means we have no simple and reliable way to continue.
6031 Break out the floating-point parsing into a new
6032 function string_to_number, so that Fstring_to_number parses
6033 floating point numbers consistently with the Lisp reader.
04f2d78b 6034 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6035 (E_CHAR, EXP_INT): Remove, replacing with ...
6036 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6037 (string_to_number): New function, replacing isfloat_string.
6038 This function checks for valid syntax and produces the resulting
6039 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6040 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6041 so that overflow for non-base-10 numbers is reported only when
6042 there's no portable and simple way to convert to floating point.
452f4150 6043
67769ffc
PE
6044 * textprop.c (set_text_properties_1): Rewrite for clarity,
6045 and to avoid GCC warning about integer overflow.
6046
c20db43f
PE
6047 * intervals.h (struct interval): Use EMACS_INT for members
6048 where EMACS_UINT might cause problems. See
6049 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6050 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6051 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6052 All uses changed.
37aa2f85
PE
6053 (offset_intervals): Tell GCC not to worry about length overflow
6054 when negating a negative length.
c20db43f 6055
2538aa2f
PE
6056 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6057 (overrun_check_free): Likewise.
6058
f2d3008d
PE
6059 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6060 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6061 word size.
6062
ec8df744
PE
6063 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6064 (gnutls_make_error): Rename local to avoid shadowing.
6065 (gnutls_emacs_global_deinit): ifdef out; not used.
6066 (Fgnutls_boot): Use const for pointer to readonly storage.
6067 Comment out unused local. Fix pointer signedness problems.
6068
640ee02d
PE
6069 * lread.c (openp): Don't stuff size_t into an 'int'.
6070 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6071 about possible signed overflow.
6072
6048fb2a
PE
6073 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6074 (GDK_KEY_g): Don't define if already defined.
6075 (xg_prepare_tooltip): Avoid pointer signedness problem.
6076 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6077
fa3c87e1
PE
6078 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6079 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6080
2172544b
PE
6081 * xfns.c (Fx_window_property): Simplify a bit,
6082 to make a bit faster and to avoid GCC 4.6.0 warning.
6083 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6084
9b821a21
PE
6085 * fns.c (internal_equal): Don't assume size_t fits in int.
6086
3c616cfa
PE
6087 * alloc.c (compact_small_strings): Tighten assertion a little.
6088
c2982e87
PE
6089 Replace pEd with more-general pI, and fix some printf arg casts.
6090 * lisp.h (pI): New macro, generalizing old pEd macro to other
6091 conversion specifiers. For example, use "...%"pI"d..." rather
6092 than "...%"pEd"...".
6093 (pEd): Remove. All uses replaced with similar uses of pI.
6094 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6095 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6096 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6097 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6098 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6099 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6100 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6101 64-bit hosts.
6102 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6103 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6104 * print.c (safe_debug_print, print_object): Likewise.
6105 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6106 to int.
6f04d126
PE
6107 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6108 avoiding the 0 flag, which is not portable.
c2982e87
PE
6109 * process.c (Fmake_network_process): Use pI to avoid cast.
6110 * region-cache.c (pp_cache): Likewise.
6111 * xdisp.c (decode_mode_spec): Likewise.
6112 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6113 behavior on 64-bit hosts with printf arg.
6f04d126 6114 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6115 (x_stop_queuing_selection_requests): Likewise.
6116 (x_get_window_property): Don't truncate byte count to an 'int'
6117 when tracing.
0b432f21 6118
5e073ec7
PE
6119 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6120 here, since it parses constructs like leading '-' and spaces,
6121 which are not wanted; and it overflows with large numbers.
6122 Instead, simply match F[0-9]+, which is what is wanted anyway.
6123
36372bf9
PE
6124 * alloc.c: Remove unportable assumptions about struct layout.
6125 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6126 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6127 (allocate_vectorlike, make_pure_vector): Use the new macros,
6128 plus offsetof, to remove unportable assumptions about struct layout.
6129 These assumptions hold on all porting targets that I know of, but
6130 they are not guaranteed, they're easy to remove, and removing them
6131 makes further changes easier.
6132
0b432f21
PE
6133 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6134 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6135 (string_overrun_cookie): Now const. Use initializers that
6136 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6137 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6138 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6139 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6140 multiple of sizeof (EMACS_INT); it need not be, if
6141 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6142 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6143
895009e1
JB
61442011-04-26 Juanma Barranquero <lekktu@gmail.com>
6145
6146 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6147
6a7a1b0b
TZ
61482011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6149
6150 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6151 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6152 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6153
841a1577 61542011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6155
6156 * lisp.h (Qdebug): List symbol.
895009e1 6157 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6158 * keyboard.c (debug-on-event): New variable.
6159 (handle_user_signal): Break into debugger when debug-on-event
6160 matches the current signal symbol.
6161
f2d3ba6f
DN
61622011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6163
6164 * alloc.c (check_sblock, check_string_bytes)
6165 (check_string_free_list): Convert to standard C.
6166
42ce4c63
TZ
61672011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6168
6169 * w32.c (emacs_gnutls_push): Fix typo.
6170
825cd63c
EZ
61712011-04-25 Eli Zaretskii <eliz@gnu.org>
6172
fb11d64d
EZ
6173 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6174 "cast to pointer from integer of different size".
6175
825cd63c
EZ
6176 Improve doprnt and its use in verror. (Bug#8545)
6177 * doprnt.c (doprnt): Document the set of format control sequences
6178 supported by the function. Use SAFE_ALLOCA instead of always
6179 using `alloca'.
6180
6181 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6182 is one byte too soon. Don't use xrealloc; instead xfree and
6183 xmalloc anew.
6184
e061a11b
TZ
61852011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6186
6187 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6188 callbacks stage.
6189
6190 * gnutls.c: Renamed global_initialized to
6191 gnutls_global_initialized. Added internals for the
6192 :verify-hostname-error, :verify-error, and :verify-flags
6193 parameters of `gnutls-boot' and documented those parameters in the
6194 docstring. Start callback support.
9173deec
JB
6195 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6196 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6197 on error. Return error code.
e061a11b
TZ
6198 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6199 (emacs_gnutls_read): Likewise.
6200 (Fgnutls_boot): Return handshake error code.
6201 (emacs_gnutls_handle_error): New function.
6202 (wsaerror_to_errno): Likewise.
6203
6204 * w32.h (emacs_gnutls_pull): Add prototype.
6205 (emacs_gnutls_push): Likewise.
6206
6207 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6208 (emacs_gnutls_push): Likewise.
6209
62102011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6211
6212 * process.c (wait_reading_process_output): Check if GnuTLS
6213 buffered some data internally if no FDs are set for TLS
6214 connections.
6215
6216 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6217 (LIBS): Link to USER_LIBS.
6218 ($(BLD)/gnutls.$(0)): New target.
6219
fa6996bc
EZ
62202011-04-24 Eli Zaretskii <eliz@gnu.org>
6221
eb35682e
EZ
6222 * xdisp.c (handle_single_display_spec): Rename the
6223 display_replaced_before_p argument into display_replaced_p, to
6224 make it consistent with the commentary. Fix typos in the
6225 commentary.
6226
e2ad650c
EZ
6227 * textprop.c (syms_of_textprop): Remove dead code.
6228 (copy_text_properties): Delete obsolete commentary about an
6229 interface that was deleted long ago. Fix typos in the description
6230 of arguments.
6231
1b2de274
EZ
6232 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6233 to changes in oldXMenu/XMenu.h from 2011-04-16.
6234 <menu_help_message, prev_menu_help_message>: Constify.
6235 (IT_menu_make_room): menu->help_text is now `const char **';
6236 adjust.
6237
6238 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6239 to changes in oldXMenu/XMenu.h from 2011-04-16.
6240 (struct XMenu): Declare `help_text' `const char **'.
6241
6242 * xfaces.c <Qunspecified>: Make extern again.
6243
6244 * syntax.c: Include sys/types.h before including regex.h, as
6245 required by Posix.
6246
762b15be
EZ
6247 * doc.c (get_doc_string): Improve the format passed to `error'.
6248
6249 * doprnt.c (doprnt): Improve commentary.
6250
6251 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6252
6253 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6254 them with etags.
6255
f1052e5d
EZ
6256 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6257 changes in globals.h immediately force recompilation.
762b15be
EZ
6258 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6259 $(CURDIR)/s/ms-w32.h.
6260 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6261
fa6996bc
EZ
6262 * character.c (Fchar_direction): Function deleted.
6263 (syms_of_character): Don't defsubr it.
6264 <char-direction-table>: Deleted.
6265
e6c3da20
EZ
62662011-04-23 Eli Zaretskii <eliz@gnu.org>
6267
6268 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6269 * doprnt.c: Include limits.h.
6270 (SIZE_MAX): New macro.
04f2d78b
CB
6271 (doprnt): Return a size_t value. 2nd arg is now size_t.
6272 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6273 Improve overflow protection. Support `l' modifier for integer
6274 conversions. Support %l conversion. Don't assume an EMACS_INT
6275 argument for integer conversions and for %c.
6276
6277 * lisp.h (doprnt): Restore prototype.
6278
6279 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6280 $(SRC)/character.h.
6281
6282 * Makefile.in (base_obj): Add back doprnt.o.
6283
6284 * deps.mk (doprnt.o): Add back prerequisites.
6285 (callint.o): Depend on character.h.
6286
6287 * eval.c (internal_lisp_condition_case): Include the handler
6288 representation in the error message.
6289 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6290 when breaking from the loop.
6291
6292 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6293
6294 * callint.c (Fcall_interactively): When displaying error message
6295 about invalid control letter, pass the character's codepoint, not
6296 a pointer to its multibyte form. Improve display of the character
6297 in octal and display also its hex code.
6298
6299 * character.c (char_string): Use %x to display the (unsigned)
6300 codepoint of an invalid character, to avoid displaying a bogus
6301 negative value.
6302
6303 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6304 `error', not SYMBOL_NAME itself.
6305
6306 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6307 character arguments to `error'.
6308
6309 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6310 to `error' in error message about FINAL_CHAR argument. Make sure
6311 FINAL_CHAR is a character, and use %c when it is passed as
6312 argument to `error'.
6313
4ffd0d6b 63142011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6315
6316 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6317
6318 * w32.c: Include <time.h>.
6319 (sys_localtime): New function.
6320
4ffd0d6b 63212011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6322
6323 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6324
4ffd0d6b 6325 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6326
4ffd0d6b 63272011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6328
4ffd0d6b
GM
6329 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6330 zombies (Bug#8467).
aac0c6e3 6331
04c56954
EZ
63322011-04-19 Eli Zaretskii <eliz@gnu.org>
6333
6334 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6335 gl_state.e_property when gl_state.object is Qt.
6336
6337 * insdel.c (make_gap_larger): Remove limitation of buffer size
6338 to <= INT_MAX.
6339
16a43933
CY
63402011-04-18 Chong Yidong <cyd@stupidchicken.com>
6341
6342 * xdisp.c (lookup_glyphless_char_display)
6343 (produce_glyphless_glyph): Handle cons cell entry in
6344 glyphless-char-display.
6345 (Vglyphless_char_display): Document it.
6346
6347 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6348 glyphless-char-display.
6349
4581706e
CY
63502011-04-17 Chong Yidong <cyd@stupidchicken.com>
6351
6352 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6353
6354 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6355
6356 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6357 definition for no-X builds.
6358
4887c6e2 63592011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6360
fd35b6f9
PE
6361 Static checks with GCC 4.6.0 and non-default toolkits.
6362
5c1ccb01
PE
6363 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6364
006c5daa
PE
6365 * process.c (keyboard_bit_set): Define only if SIGIO.
6366 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6367 (send_process): Repair possible setjmp clobbering.
6368
efc736d3
PE
6369 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6370
4e2fe2e6
PE
6371 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6372
f97334a2
PE
6373 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6374
4e75f29d
PE
6375 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6376 Define only if needed.
6377
90efadd1
PE
6378 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6379 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6380 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6381
3c647824
PE
6382 * dispextern.h (struct redisplay_interface): Rename param
6383 to avoid shadowing.
e264f262 6384 * termhooks.h (struct terminal): Likewise.
761383f4 6385 * xterm.c (xembed_send_message): Likewise.
3c647824 6386
b58c5c4a
PE
6387 * insdel.c (make_gap_smaller): Define only if
6388 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6389
cad59032
PE
6390 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6391 it.
6392
c339dc2e
PE
6393 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6394 so that we aren't warned about unused symbols.
6395
91a3e27b
PE
6396 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6397
399c71d3 6398 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6399
8ffc96f5
PE
6400 * xfns.c (x_real_positions): Mark locals as initialized.
6401
eef9bc79
PE
6402 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6403
098db9dd
PE
6404 * xterm.c: Fix problems found by static analysis with other toolkits.
6405 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6406 (x_dispatch_event): Declare static if USE_GTK, and
6407 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6408 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6409 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6410 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6411 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6412
eb18f6cc
PE
6413 * xmenu.c (menu_help_callback): Pointer type fixes.
6414 Use const pointers when pointing at readonly data. Avoid pointer
6415 signedness clashes.
6416 (FALSE): Remove unused macro.
6417 (update_frame_menubar): Remove unused decl.
6418
1fe72bf8
PE
6419 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6420
60d9e1db
PE
6421 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6422 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6423 (single_menu_item): Rename local to avoid shadowing.
6424
39261c26
PE
6425 * keyboard.c (make_lispy_event): Remove unused local var.
6426
018c5e19
PE
6427 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6428 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6429
63d2b86e
PE
6430 * bitmaps: Change bitmaps from unsigned char back to the X11
6431 compatible char. Avoid the old compiler warnings about
6432 out-of-range initializers by using, for example, '\xab' rather
6433 than 0xab.
6434
aefd87e1
PE
6435 * xgselect.c (xgselect_initialize): Check vs interface
6436 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6437
bf501fb9
PE
6438 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6439
e9829fdf
PE
6440 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6441 to read-only memory.
6442
1086c095
PE
6443 * fns.c (vector): Remove; this old hack is no longer needed.
6444
2baccd04 6445 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6446 Remove unused var.
dde42981 6447 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6448
72391843 6449 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6450
436c16df 6451 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6452 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6453 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6454
92bb796d 6455 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6456 (x_term_init): Remove local to avoid shadowing.
92bb796d 6457
764430a3 6458 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6459
6460 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6461 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6462
d1dfb56c
EZ
64632011-04-16 Eli Zaretskii <eliz@gnu.org>
6464
c4354cb4
EZ
6465 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6466
d1dfb56c
EZ
6467 Fix regex.c, syntax.c and friends for buffers > 2GB.
6468 * syntax.h (struct gl_state_s): Declare character position members
6469 EMACS_INT.
6470
6471 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6472
04f2d78b
CB
6473 * textprop.c (verify_interval_modification, interval_of):
6474 Declare arguments EMACS_INT.
d1dfb56c
EZ
6475
6476 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6477 EMACS_INT.
6478
6479 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6480
6481 * indent.c (Fvertical_motion): Local variable it_start is now
6482 EMACS_INT.
6483
6484 * regex.c (re_match, re_match_2, re_match_2_internal)
6485 (bcmp_translate, regcomp, regexec, print_double_string)
6486 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6487 (re_compile_pattern, re_exec): Declare arguments and local
6488 variables `size_t' and `ssize_t' and return values `regoff_t', as
6489 appropriate.
6490 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6491 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6492 <compile_stack_type>: `size' and `avail' are now `size_t'.
6493
6494 * regex.h <regoff_t>: Use ssize_t, not int.
6495 (re_search, re_search_2, re_match, re_match_2): Arguments that
6496 specify buffer/string position and length are now ssize_t and
6497 size_t. Return type is regoff_t.
6498
613052cd
BK
64992011-04-16 Ben Key <bkey76@gmail.com>
6500
6501 * nsfont.m: Fixed bugs in ns_get_family and
6502 ns_descriptor_to_entity that were caused by using free to
6503 deallocate memory blocks that were allocated by xmalloc (via
6504 xstrdup). This caused Emacs to crash when compiled with
6505 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6506 --enable-checking=xmallocoverrun). xfree is now used to
6507 deallocate these memory blocks.
6508
4170f62f 65092011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6510
71b41406
PE
6511 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6512
9587a89d
PE
6513 emacs_write: Accept and return EMACS_INT for sizes.
6514 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6515 et seq.
6516 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6517 Accept and return EMACS_INT.
6518 (emacs_gnutls_write): Return the number of bytes written on
6519 partial writes.
6520 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6521 (emacs_read, emacs_write): Remove check for negative size, as the
6522 Emacs source code has been audited now.
9587a89d
PE
6523 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6524 (emacs_read, emacs_write): Use it.
273a5f82
PE
6525 * process.c (send_process): Adjust to the new signatures of
6526 emacs_write and emacs_gnutls_write. Do not attempt to store
6527 a byte offset into an 'int'; it might overflow.
9587a89d 6528 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6529
3e047f51
PE
6530 * sound.c: Don't assume sizes fit in 'int'.
6531 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6532 Return EMACS_INT, not int.
3e047f51 6533 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6534 Accept EMACS_INT, not int.
6535 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6536 record read return values.
6537
cc39a9db
BK
65382011-04-15 Ben Key <bkey76@gmail.com>
6539
c9d0ec6d
JB
6540 * keyboard.c (Qundefined): Don't declare static since it is used
6541 in nsfns.m.
6542 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6543 static since they are used in nsfont.m.
cc39a9db 6544
6c60eb9f
SM
65452011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6546
6547 * process.c (Qprocessp): Don't declare static.
6548 * lisp.h (Qprocessp): Declare again.
6549
7990b61a
JB
65502011-04-15 Juanma Barranquero <lekktu@gmail.com>
6551
6552 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6553
5d4cb038
PE
65542011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6555
8bd7b830 6556 Improve C-level modularity by making more things 'static'.
cd64ea1d 6557
e3b27b31
PE
6558 Don't publish debugger-only interfaces to other modules.
6559 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6560 (verify_bytepos, count_markers): Move decls to the only modules
6561 that need them.
6562 * region-cache.h (pp_cache): Likewise.
6563 * window.h (check_all_windows): Likewise.
6564 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6565
5d4cb038
PE
6566 * sysdep.c (croak): Now static, if
6567 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6568 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6569
6570 * alloc.c (refill_memory_reserve): Now static if
6571 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6572 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6573
e87b6180
PE
6574 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6575 Define only if USE_LUCID.
6576
ac64929e
PE
6577 * xrdb.c (x_customization_string, x_rm_string): Now static.
6578
6f37259d
PE
6579 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6580 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6581
1683e3ab
PE
6582 * xdisp.c (draw_row_with_mouse_face): Now static.
6583 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6584
de9c2632
PE
6585 * window.h (check_all_windows): Mark externally visible.
6586
2b96acb7
PE
6587 * window.c (window_deletion_count): Now static.
6588
6589 * undo.c: Make symbols static if they're not exported.
6590 (last_undo_buffer, last_boundary_position, pending_boundary):
6591 Now static.
6592
50436f33
PE
6593 * textprop.c (interval_insert_behind_hooks): Now static.
6594 (interval_insert_in_front_hooks): Likewise.
6595
64520e5c
PE
6596 * term.c: Make symbols static if they're not exported.
6597 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6598 (max_frame_lines, tty_set_terminal_modes):
6599 (tty_reset_terminal_modes, tty_turn_off_highlight):
6600 (get_tty_terminal): Now static.
6601 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6602 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6603 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6604 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6605 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6606
1fa53021
PE
6607 * sysdep.c: Make symbols static if they're not exported.
6608 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6609 Now static.
6610 (sigprocmask_set, full_mask): Remove; unused.
6611 (wait_debugging): Mark as visible.
6612 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6613 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6614
d4b43b22
PE
6615 * syntax.c (syntax_temp): Define only if !__GNUC__.
6616
b7c513d0
PE
6617 * sound.c (current_sound_device, current_sound): Now static.
6618
989b29ad
PE
6619 * search.c (searchbufs, searchbuf_head): Now static.
6620
13a55a78
PE
6621 * scroll.c (scroll_cost): Remove; unused.
6622 * dispextern.h (scroll_cost): Remove decl.
6623
de68a1fc
PE
6624 * region-cache.h (pp_cache): Mark as externally visible.
6625
40ccffa6
PE
6626 * process.c: Make symbols static if they're not exported.
6627 (process_tick, update_tick, create_process, chan_process):
6628 (Vprocess_alist, proc_buffered_char, datagram_access):
6629 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6630 (deactivate_process): Mark defn as static, as well as decl.
6631 * lisp.h (create_process): Remove decl.
6632 * process.h (chan_process, Vprocess_alist): Remove decls.
6633
ad64fc97
PE
6634 * print.c: Make symbols static if they're not exported.
6635 (print_depth, new_backquote_output, being_printed, print_buffer):
6636 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6637 (print_interval, print_number_index, initial_stderr_stream):
6638 Now static.
6639 * lisp.h (Fprinc): Remove decl.
6640 (debug_output_compilation_hack): Mark as externally visible.
6641
adddb265
PE
6642 * sysdep.c (croak): Move decl from here to syssignal.h.
6643 * syssignal.h (croak): Put it here, so the API can be checked when
6644 'croak' is called from dissociate_if_controlling_tty.
6645
1717ede2
PE
6646 * minibuf.c: Make symbols static if they're not exported.
6647 (minibuf_save_list, choose_minibuf_frame): Now static.
6648 * lisp.h (choose_minibuf_frame): Remove decl.
6649
fa5fb2bc
PE
6650 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6651
1e3890d1
PE
6652 * lread.c: Make symbols static if they're not exported.
6653 (read_objects, initial_obarray, oblookup_last_bucket_number):
6654 Now static.
6655 (make_symbol): Remove; unused.
6656 * lisp.h (initial_obarray, make_symbol): Remove decls.
6657
8a1414fa
PE
6658 * keyboard.c: Make symbols static if they're not exported.
6659 (single_kboard, recent_keys_index, total_keys, recent_keys):
6660 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6661 (this_single_command_key_start, echoing, last_auto_save):
6662 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6663 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6664 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6665 (Vlispy_mouse_stem, double_click_count):
6666 Now static.
6667 (force_auto_save_soon): Define only if SIGDANGER.
6668 (ignore_mouse_drag_p): Now static if
6669 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6670 (print_help): Remove; unused.
6671 (stop_character, last_timer_event): Mark as externally visible.
6672 * keyboard.h (ignore_mouse_drag_p): Declare only if
6673 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6674 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6675 * lisp.h (echoing): Remove decl.
6676 (force_auto_save_soon): Declare only if SIGDANGER.
6677 * xdisp.c (redisplay_window): Simplify code, to make it more
6678 obvious that ignore_mouse_drag_p is not accessed if !defined
6679 USE_GTK && !defined HAVE_NS.
6680
93ea6e8f
PE
6681 * intervals.c: Make symbols static if they're not exported.
6682 (merge_properties_sticky, merge_interval_right, delete_interval):
6683 Now static.
6684 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6685
77382fcc
PE
6686 * insdel.c: Make symbols static if they're not exported.
6687 However, leave prepare_to_modify_buffer alone. It's never
6688 called from outside this function, but that appears to be a bug.
6689 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6690 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6691 (adjust_after_replace_noundo): Remove; unused.
6692 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6693 (signal_before_change): Remove decls.
77382fcc 6694
9306c32e
PE
6695 * indent.c (val_compute_motion, val_vmotion): Now static.
6696
cd44d2eb
PE
6697 * image.c: Make symbols static if they're not exported.
6698 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6699 if USE_GTK.
6700 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6701 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6702
ad9a7a06
PE
6703 * fringe.c (standard_bitmaps): Now static.
6704 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6705
81626931
PE
6706 * frame.c: Make symbols static if they're not exported.
6707 (x_report_frame_params, make_terminal_frame): Now static.
6708 (get_frame_param): Now static, unless HAVE_NS.
6709 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6710 (x_get_resource_string): Remove; not used.
6711 * frame.h (make_terminal_frame, x_report_frame_params):
6712 (x_get_resource_string); Remove decls.
6713 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6714 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6715
239f9db9
PE
6716 * font.c, fontset.c: Make symbols static if they're not exported.
6717 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6718 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6719 * font.c (font_close_object): Now static.
6720 * font.h (font_close_object): Remove.
6721 * fontset.c (FONTSET_OBJLIST): Remove.
6722 (free_realized_fontset) #if-0 the body, which does nothing.
6723 (face_suitable_for_char_p): #if-0, as it's never called.
6724 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6725 * xfaces.c (face_at_string_position):
6726 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6727 since 0 is always ASCII.
6728
dfcf3579
PE
6729 * fns.c (weak_hash_tables): Now static.
6730
5045092b
PE
6731 * fileio.c: Make symbols static if they're not exported.
6732 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6733 (Vwrite_region_annotation_buffers): Now static.
6734
57a96f5c
PE
6735 * eval.c: Make symbols static if they're not exported.
6736 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6737 * lisp.h (backtrace_list): Remove decl.
6738
35f08c38
PE
6739 * emacs.c: Make symbols static if they're not exported.
6740 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6741 (fatal_error_code, fatal_error_signal_hook, standard_args):
6742 Now static.
6743 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6744 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6745 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6746 * lisp.h (fatal_error_signal_hook): Remove decl.
6747 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6748
f44bd759
PE
6749 * editfns.c: Move a (normally-unused) function to its only use.
6750 * editfns.c, lisp.h (get_operating_system_release): Remove.
6751 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6752 worth the hassle of breaking this out.
6753
b532497d
PE
6754 * xterm.c: Make symbols static if they're not exported.
6755 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6756 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6757 (x_destroy_window, x_delete_display):
6758 Now static.
6759 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6760 (x_mouse_leave): Remove; unused.
6761 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6762 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6763 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6764 Remove decls.
6765 (x_mouse_leave): Declare only if WINDOWSNT.
6766 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6767 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6768 USE_X_TOOLKIT.
6769
1675728f
PE
6770 * ftxfont.c: Make symbols static if they're not exported.
6771 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6772 HAVE_FREETYPE.
6773 * font.h (ftxfont_driver): Likewise.
6774
e4cebfca
PE
6775 * xfns.c: Make symbols static if they're not exported.
6776 (x_last_font_name, x_display_info_for_name):
6777 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6778 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6779 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6780 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6781 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6782 (last_show_tip_args): Now static.
6783 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6784 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6785 (x_screen_planes): Remove; unused.
6786 * dispextern.h (x_screen_planes): Remove decl.
6787
5bf46f05
PE
6788 * dispnew.c: Make symbols static if they're not exported.
6789 * dispextern.h (redraw_garbaged_frames, scrolling):
6790 (increment_row_positions): Remove.
6791 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6792 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6793 Now static.
6794 (redraw_garbaged_frames): Remove; unused.
6795
435f4c28
PE
6796 * xfaces.c: Make symbols static if they're not exported.
6797 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6798 Remove decls.
6799 * xterm.h (defined_color): Remove decls.
6800 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6801 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6802 (menu_face_changed_default, defined_color, free_realized_face):
6803 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6804 (ascii_face_of_lisp_face): Remove; unused.
6805
8524aef3
PE
6806 * xdisp.c: Make symbols static if they're not exported.
6807 * dispextern.h (scratch_glyph_row, window_box_edges):
6808 (glyph_to_pixel_coords, set_cursor_from_row):
6809 (get_next_display_element, set_iterator_to_next):
6810 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6811 (show_mouse_face): Remove decls
6812 * frame.h (message_buf_print): Likewise.
6813 * lisp.h (pop_message, set_message, check_point_in_composition):
6814 Likewise.
6815 * xterm.h (set_vertical_scroll_bar): Likewise.
6816 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6817 (message_buf_print, scratch_glyph_row, displayed_buffer):
6818 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6819 (get_next_display_element, show_mouse_face, window_box_edges):
6820 (frame_to_window_pixel_xy, check_point_in_composition):
6821 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6822 (glyph_to_pixel_coords): Remove; unused.
6823
16390cd2
PE
6824 * dired.c (file_name_completion): Now static.
6825
6826 * dbusbind.c (xd_in_read_queued_messages): Now static.
6827
a25f4dfa
PE
6828 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6829 * data.c (circular_list_error): Remove.
6830
14a9c8df
PE
6831 * commands.h (last_point_position, last_point_position_buffer):
6832 (last_point_position_window): Remove decls.
6833 * keyboard.c: Make these variables static.
6834
04f2d78b
CB
6835 * coding.h (coding, code_convert_region, encode_coding_gap):
6836 Remove decls.
74ab6df5
PE
6837 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6838 (iso_code_class, detect_coding, code_convert_region): Now static.
6839 (encode_coding_gap): Remove; unused.
6840
38dfbee1
PE
6841 * chartab.c (chartab_chars, chartab_bits): Now static.
6842
a2cb4e63
PE
6843 * charset.h (charset_iso_8859_1): Remove decl.
6844 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6845 Now static.
6846
127198fd
PE
6847 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6848 * ccl.c (Vccl_program_table): Now static.
6849 (check_ccl_update): Remove; unused.
6850
d85b608f
PE
6851 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6852 * category.h: ... from here.
6853 * category.c (check_category_table, set_category_set): Now static.
6854
31cd66f3
PE
6855 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6856 * lisp.h: Remove these decls.
6857
c358e587
PE
6858 * buffer.c (buffer_count): Remove unused var.
6859
e78aecca
PE
6860 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6861 so that it's not optimized away.
6862 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6863 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6864 exported only to the debugger.
6865
e192d7d3 6866 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6867 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6868
92470028
PE
6869 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6870 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6871 was inaccessible from Lisp.
6872 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6873 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6874
244ed907
PE
6875 alloc.c: Import and export fewer symbols, and remove unused items.
6876 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6877 is defined.
6878 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6879 it's not optimized away by whole-program optimization.
6880 (message_enable_multibyte, free_misc): Remove.
6881 (catchlist, handlerlist, mark_backtrace):
6882 Declare only if BYTE_MARK_STACK.
6883 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6884 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6885 (message_enable_multibyte): Remove decl.
6886 (free_misc, interval_free_list, float_block, float_block_index):
6887 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6888 (cons_free_list, last_marked_index):
6889 Now static.
6890 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6891 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6892 (mark_backtrace): Define only if BYTE_MARK_STACK.
6893 * xdisp.c (message_enable_multibyte): Now static.
6894
61c2b50e 6895 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6896 This makes it easier for human readers (and static analyzers)
6897 to see whether these variables are used from other modules.
6898 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6899 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6900 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6901 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6902 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6903 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6904 * xmenu.c, xselect.c:
6905 Declare Q* vars static if they are not used in other modules.
6906 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6907 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6908 Remove decls of unexported vars.
6909 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6910
95c82688
PE
6911 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6912
16a97296
PE
6913 Make Emacs functions such as Fatom 'static' by default.
6914 This makes it easier for human readers (and static analyzers)
6915 to see whether these functions can be called from other modules.
6916 DEFUN now defines a static function. To make the function external
6917 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6918 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6919 (Finit_image_library):
16a97296
PE
6920 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6921 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6922 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6923 Remove decls, since these functions are now static.
6924 (Funintern, Fget_internal_run_time): New decls, since these functions
6925 were already external.
95c82688 6926
16a97296
PE
6927 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6928 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6929 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6930 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6931 * keyboard.c, keymap.c, lread.c:
6932 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6933 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6934 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6935 Mark functions with DEFUE instead of DEFUN,
6936 if they are used in other modules.
6937 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6938 decls for now-static functions.
6939 * buffer.h (Fdelete_overlay): Remove decl.
6940 * callproc.c (Fgetenv_internal): Mark as internal.
6941 * composite.c (Fremove_list_of_text_properties): Remove decl.
6942 (Fcomposition_get_gstring): New forward static decl.
6943 * composite.h (Fcomposite_get_gstring): Remove decl.
6944 * dired.c (Ffile_attributes): New forward static decl.
6945 * doc.c (Fdocumntation_property): New forward static decl.
6946 * eval.c (Ffetch_bytecode): New forward static decl.
6947 (Funintern): Remove extern decl; now in .h file where it belongs.
6948 * fileio.c (Fmake_symbolic_link): New forward static decl.
6949 * image.c (Finit_image_library): New forward static decl.
6950 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6951 * intervals.h (Fprevious_property_change):
6952 (Fremove_list_of_text_properties): Remove decls.
6953 * keyboard.c (Fthis_command_keys): Remove decl.
6954 (Fcommand_execute): New forward static decl.
6955 * keymap.c (Flookup_key): New forward static decl.
6956 (Fcopy_keymap): Now static.
6957 * keymap.h (Flookup_key): Remove decl.
6958 * process.c (Fget_process): New forward static decl.
6959 (Fprocess_datagram_address): Mark as internal.
6960 * syntax.c (Fsyntax_table_p): New forward static decl.
6961 (skip_chars): Remove duplicate decl.
6962 * textprop.c (Fprevious_property_change): New forward static decl.
6963 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6964 Now internal.
6965 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6966 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6967
785bbd42
PE
6968 * editfns.c (Fformat): Remove unreachable code.
6969
8b913b57
AS
69702011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6971
6972 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6973 change. (Bug#8496)
6974
a6744a35
EZ
69752011-04-13 Eli Zaretskii <eliz@gnu.org>
6976
6977 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6978 when at ZV. (Bug#8487)
6979
e7974947
AS
69802011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6981
baad03f0
AS
6982 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6983 (Bug#8437)
6984 * keyboard.c (parse_tool_bar_item): Likewise.
6985 * sound.c (sound_cleanup, alsa_close): Likewise.
6986 * termcap.c (tgetent): Likewise.
6987 * xfns.c (x_default_font_parameter): Likewise.
6988 * xsettings.c (read_and_apply_settings): Likewise.
6989
e7974947
AS
6990 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6991 (overrun_check_free): Protoize.
6992
28272684
PE
69932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6994
6995 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6996 since callers should never pass a negative size.
6997 Change the signature to match that of plain 'read' and 'write'; see
6998 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6999 * lisp.h: Update prototypes of emacs_write and emacs_read.
7000
11997c76
EZ
70012011-04-11 Eli Zaretskii <eliz@gnu.org>
7002
7003 * xdisp.c (redisplay_window): Don't try to determine the character
7004 position of the scroll margin if the window start point w->startp
e896f03c 7005 is outside the buffer's accessible region. (Bug#8468)
11997c76 7006
8a2cbd72
EZ
70072011-04-10 Eli Zaretskii <eliz@gnu.org>
7008
7009 Fix write-region and its subroutines for buffers > 2GB.
7010 * fileio.c (a_write, e_write): Modify declaration of arguments and
7011 local variables to support buffers larger than 2GB.
7012 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7013
7014 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7015 argument, local variables, and return value.
7016
7017 * lisp.h: Update prototypes of emacs_write and emacs_read.
7018
7019 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7020
4073e537 70212011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7022
1ebfdcb6
PE
7023 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7024
b2ded58d
PE
7025 Fix more problems found by GCC 4.6.0's static checks.
7026
7d66342c
PE
7027 * xdisp.c (vmessage): Use a better test for character truncation.
7028
bbf47d44
PE
7029 * charset.c (load_charset_map): <, not <=, for optimization,
7030 and to avoid potential problems with integer overflow.
9248994d 7031 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7032 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7033 * editfns.c (Fformat): Likewise.
1e69125e 7034 * syntax.c (skip_chars): Likewise.
3befa583 7035
e3019616
PE
7036 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7037 This also lets GCC 4.6.0 generate slightly better loop code.
7038
becfa255
PE
7039 * callint.c (Fcall_interactively): <, not <=, for optimization.
7040 (Fcall_interactively): Count the number of arguments produced,
7041 not the number of arguments given. This is simpler and lets GCC
7042 4.6.0 generate slightly better code.
7043
dae0cd48
PE
7044 * ftfont.c: Distingish more carefully between FcChar8 and char.
7045 The previous code passed unsigned char * to a functions like
7046 strlen and xstrcasecmp that expect char *, which does not
7047 conform to the C standard.
7048 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7049 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7050 char * when the C standard requires it.
7051
76032d70
PE
7052 * keyboard.c (read_char): Remove unused var.
7053
eb3f1cc8
PE
7054 * eval.c: Port to Windows vsnprintf (Bug#8435).
7055 Include <limits.h>.
7056 (SIZE_MAX): Define if the headers do not.
7057 (verror): Do not give up if vsnprintf returns a negative count.
7058 Instead, grow the buffer. This ports to Windows vsnprintf, which
7059 does not conform to C99. Problem reported by Eli Zaretskii.
7060 Also, simplify the allocation scheme, by avoiding the need for
7061 calling realloc, and removing the ALLOCATED variable.
7062
70476b54
PE
7063 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7064
12020a9e
PE
7065 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7066 But keep the doprint source code for now, as we might revamp it
7067 and use it again (Bug#8435).
ea6c7ae6
PE
7068 * lisp.h (doprnt): Remove.
7069 * Makefile.in (base_obj): Remove doprnt.o.
7070 * deps.mk (doprnt.o): Remove.
7071
5fdb398c
PE
7072 error: Print 32- and 64-bit integers portably (Bug#8435).
7073 Without this change, on typical 64-bit hosts error ("...%d...", N)
7074 was used to print both 32- and 64-bit integers N, which relied on
7075 undefined behavior.
7076 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7077 New macro.
7078 * lisp.h (error, verror): Mark as printf-like functions.
7079 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7080 Report overflow in size calculations when allocating printf buffer.
7081 Do not truncate output string at its first null byte.
7082 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7083 Truncate the output at a character boundary, since vsnprintf does not
7084 do that.
7085 * charset.c (check_iso_charset_parameter): Convert internal
7086 character to string before calling 'error', since %c now has the
7087 printf meaning.
7088 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7089 overflow when computing char to be passed to 'error'. Do not
7090 pass Lisp_Object to 'error'; pass the integer instead.
7091 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7092 formatted with plain %d.
7093
b189fa66
PE
7094 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7095
bff87ef0
PE
7096 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7097
7e2cac20
PE
7098 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7099
ce4d90b5
PE
7100 * xterm.c (x_catch_errors): Remove duplicate declaration.
7101
266c9547
PE
7102 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7103
79c49ad2
PE
7104 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7105
368f4090
JM
71062011-04-10 Jim Meyering <meyering@redhat.com>
7107
7108 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7109 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7110 return ssize_t not "int", and use size_t as the buffer length.
7111 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7112 * gnutls.h: Update declarations.
7113 * process.c (read_process_output): Use ssize_t, to match.
7114 (send_process): Likewise.
7115
a32d4040
CY
71162011-04-09 Chong Yidong <cyd@stupidchicken.com>
7117
7118 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7119
8546720e 71202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7121
04f2d78b
CB
7122 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7123 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7124
8546720e
GM
7125 * xterm.c (handle_one_xevent):
7126 * xmenu.c (create_and_show_popup_menu):
7127 * xselect.c (x_decline_selection_request)
7128 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7129
0a2f5c1a 71302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7131
7132 Fix some uses of `int' instead of EMACS_INT.
7133 * search.c (string_match_1, fast_string_match)
7134 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7135 (scan_buffer, find_next_newline_no_quit)
7136 (find_before_next_newline, search_command, Freplace_match)
7137 (Fmatch_data): Make some `int' variables be EMACS_INT.
7138
7139 * xdisp.c (display_count_lines): 3rd argument and return value now
7140 EMACS_INT. All callers changed.
7141 (pint2hrstr): Last argument is now EMACS_INT.
7142
7143 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7144 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7145 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7146 (decode_coding_utf_16, decode_coding_emacs_mule)
7147 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7148 (decode_coding_ccl, decode_coding_charset)
7149 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7150 (decode_coding_iso_2022, decode_coding_emacs_mule)
7151 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7152 <char_offset, last_offset>: Declare EMACS_INT.
7153 (encode_coding_utf_8, encode_coding_utf_16)
7154 (encode_coding_emacs_mule, encode_invocation_designation)
7155 (encode_designation_at_bol, encode_coding_iso_2022)
7156 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7157 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7158 Declare EMACS_INT.
7159 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7160 (encode_invocation_designation): Last argument P_NCHARS is now
7161 EMACS_INT.
7162 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7163 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7164
7165 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7166 All users changed.
7167
7168 * ccl.c (Fccl_execute_on_string): Declare some variables
7169 EMACS_INT.
7170
8546720e 71712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7172
7173 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7174
4e19a977
CS
71752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7176
7177 * process.c (Fformat_network_address): Doc fix.
7178
87302331
R
71792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7180
ee7683eb 7181 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7182
cbb59342
CY
71832011-04-08 Chong Yidong <cyd@stupidchicken.com>
7184
7185 * keyboard.c (read_char): Call Lisp function help-form-show,
7186 instead of using internal_with_output_to_temp_buffer.
7187 (Qhelp_form_show): New var.
e0d38eeb 7188 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7189
7190 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7191
7192 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7193
e67a13ab
CY
71942011-04-06 Chong Yidong <cyd@stupidchicken.com>
7195
04f2d78b
CB
7196 * process.c (Flist_processes): Remove to Lisp.
7197 (list_processes_1): Delete.
e67a13ab 7198
973f782d
EZ
71992011-04-06 Eli Zaretskii <eliz@gnu.org>
7200
7c106b1e
EZ
7201 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7202
973f782d
EZ
7203 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7204
41cf7d1a 72052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7206
ca23cc88
PE
7207 Fix more problems found by GCC 4.6.0's static checks.
7208
f390e2d5
PE
7209 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7210
42eea0d0
PE
7211 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7212
b69769da 7213 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7214
f9541e84
PE
7215 * xdisp.c (vmessage): Mark as a printf-like function.
7216
13841b55
PE
7217 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7218
c136c10f
PE
7219 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7220
5e2d4a30
PE
7221 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7222 printf-like functions.
7223 (tiff_load): Add casts to remove these marks before passing them
7224 to system-supplied API.
7225
583f48b9
PE
7226 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7227
b25d760e
PE
7228 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7229 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7230 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7231 directly, rather than having caller test rule sign. This avoids
7232 some unnecessary tests.
7233 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7234 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7235 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7236
bc7b6697 7237 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7238 (xfont_open): Avoid unnecessary tests.
bc7b6697 7239
27ccc379
PE
7240 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7241
dcd5c89a
PE
7242 * composite.h, composite.c (composition_gstring_put_cache):
7243 Use EMACS_INT, not int, for length.
7244
b13a45c6
PE
7245 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7246 breaking out part of COMPOSITION_DECODE_RULE.
7247 (COMPOSITION_DECODE_RULE): Use it.
7248 * composite.c (get_composition_id): Remove unused local vars,
7249 by using the new macro.
7250
1e792e4d
PE
7251 * textprop.c (set_text_properties_1): Change while to do-while,
7252 since the condition is always true at first.
7253
dc6c6455 7254 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7255 (interval_deletion_adjustment): Return unsigned value.
7256 All uses changed.
dc6c6455 7257
aba7731a
PE
7258 * process.c (list_processes_1, create_pty, read_process_output):
7259 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7260 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7261 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7262 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7263 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7264
fdfc4bf3
PE
7265 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7266
fca8fe46 7267 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7268 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7269
06a0259a 7270 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7271 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7272 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7273
e7b9e80f
PE
7274 * print.c (print_error_message): Avoid int overflow.
7275
56201685
PE
7276 * font.c (font_list_entities): Redo for clarity,
7277 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7278
78834453 7279 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7280 (font_score): Avoid potential overflow in diff calculation.
78834453 7281
0bc0b309 7282 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7283 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7284
e610eaca
PE
7285 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7286
b895abce
PE
7287 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7288 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7289 can always succeed if overflow has undefined behavior.
7290
1f1d9321 7291 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7292 (wordify): Omit three unnecessary tests.
1f1d9321 7293
c59478bc
PE
7294 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7295 All callers changed. This avoids the need for an unused var.
7296
79b73827
PE
7297 * casefiddle.c (casify_region): Remove var that is set but not used.
7298
a4db5dfe
PE
7299 * dired.c (file_name_completion): Remove var that is set but not used.
7300
43aae36e
PE
7301 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7302
2a47c44d 7303 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7304 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7305
a37c69bf
PE
7306 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7307 Check for integer overflow on size calculations.
7308
328ab8e7
PE
7309 * buffer.c (Fprevious_overlay_change): Remove var that is set
7310 but not used.
7311
e5a2a5cb
PE
7312 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7313 Remove vars that are set but not used.
8d84a6eb 7314 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7315 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7316
a60e5f68
PE
7317 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7318
f661cb61 7319 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7320 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7321
f0397f5a
PE
7322 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7323 that are set but not used.
7324
8664db06 7325 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7326 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7327
6abdaa4a
PE
7328 * xselect.c (x_get_local_selection, x_handle_property_notify):
7329 Remove vars that are set but not used.
7330
0ce7538d 7331 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7332 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7333
9ae848fc
PE
7334 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7335 Remove var that is set but not used.
0b918413
PE
7336 (scroll_bar_windows_size): Now size_t, not int.
7337 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7338 Check for overflow.
9ae848fc 7339
a5a62657
PE
7340 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7341 (map_tty_color) [!defined MSDOS]: Likewise.
7342
5c5cdd39
PE
7343 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7344
66ebf983
PE
7345 * coding.c: Remove vars that are set but not used.
7346 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7347 All callers changed.
7348 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7349 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7350 (decode_coding_charset): Remove vars that are set but not used.
7351
1be4d761
PE
7352 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7353 that is set but not used.
7354
47553fa8
PE
7355 * print.c (print_object): Remove var that is set but not used.
7356
1f7196bf 7357 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7358 The gnulib version avoids calling malloc in the usual case,
7359 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7360 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7361 * filelock.c (current_lock_owner): Likewise.
7362 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7363 * sysdep.c: Include allocator.h, careadlinkat.h.
7364 (emacs_no_realloc_allocator): New static constant.
7365 (emacs_readlink): New function.
fdb61804
PE
7366 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7367 ../lib/careadlinkat.h.
d1fdcab7 7368
f84c17c7
SM
73692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7370
7371 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7372 first non-nil return value).
7373
ef3862ad
JD
73742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7375
7376 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7377 if not defined (Bug#8403).
7378
376a7006
JB
73792011-04-02 Juanma Barranquero <lekktu@gmail.com>
7380
7381 * xdisp.c (display_count_lines): Remove parameter `start',
7382 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7383 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7384 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7385 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7386 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7387 and thereabouts. All callers changed.
7388 (get_per_char_metric): Remove parameter `f', unused since
7389 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7390
6ca3801d
JM
73912011-04-02 Jim Meyering <meyering@redhat.com>
7392
7393 do not dereference NULL upon failed strdup
7394 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7395 (ns_get_family): Likewise.
7396
d8e2b5ba
JB
73972011-04-02 Juanma Barranquero <lekktu@gmail.com>
7398
7399 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7400
8c74fcbd
JD
74012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7402
7403 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7404 later (Bug#8403).
7405
7200d79c
SM
74062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7407
03408648 7408 Add lexical binding.
7200d79c 7409
03408648
SM
7410 * window.c (Ftemp_output_buffer_show): New fun.
7411 (Fsave_window_excursion):
7412 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7413
7414 * lread.c (lisp_file_lexically_bound_p): New function.
7415 (Fload): Bind Qlexical_binding.
7416 (readevalloop): Remove `evalfun' arg.
7417 Bind Qinternal_interpreter_environment.
7418 (Feval_buffer): Bind Qlexical_binding.
7419 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7420 Mark as dynamic.
7421 (syms_of_lread): Declare `lexical-binding'.
7422
7423 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7424
7425 * keyboard.c (eval_dyn): New fun.
7426 (menu_item_eval_property): Use it.
ca105506
SM
7427
7428 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7429
03408648
SM
7430 * fns.c (concat, mapcar1): Accept byte-code-functions.
7431
7432 * eval.c (Fsetq): Handle lexical vars.
7433 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7434 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7435 (FletX, Flet): Obey lexical binding.
7436 (Fcommandp): Handle closures.
7437 (Feval): New `lexical' arg.
7438 (eval_sub): New function extracted from Feval. Use it almost
7439 everywhere where Feval was used. Look up vars in lexical env.
7440 Handle closures.
7441 (Ffunctionp): Move from subr.el.
7442 (Ffuncall): Handle closures.
7443 (apply_lambda): Remove `eval_flags'.
7444 (funcall_lambda): Handle closures and new byte-code-functions.
7445 (Fspecial_variable_p): New function.
7446 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7447 but without exporting it to Lisp.
23aba0ea 7448
23aba0ea 7449 * doc.c (Fdocumentation, store_function_docstring):
03408648 7450 * data.c (Finteractive_form): Handle closures.
23aba0ea 7451
03408648
SM
7452 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7453 interactive spec.
ba83908c 7454
04f2d78b
CB
7455 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7456 New byte-codes.
03408648
SM
7457 (exec_byte_code): New function extracted from Fbyte_code to handle new
7458 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7459
03408648 7460 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7461
03408648 7462 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7463
e2abce01
JB
74642011-03-31 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * xdisp.c (redisplay_internal): Fix prototype.
7467
63696a73 74682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7469
63696a73 7470 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7471 (try_scrolling): Use it when setting scroll_limit.
7472 Limit scrolling to 100 screen lines.
63696a73
EZ
7473 (redisplay_window): Even when falling back on "recentering",
7474 position point in the window according to scroll-conservatively,
7475 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7476
7477 (try_scrolling): When point is above the window, allow searching
7478 as far as scroll_max, or one screenful, to compute vertical
7479 distance from PT to the scroll margin position. This prevents
7480 try_scrolling from unnecessarily failing when
7481 scroll-conservatively is set to a value slightly larger than the
7482 window height. Clean up the case of PT below the margin at bottom
7483 of window: scroll_max can no longer be INT_MAX. When aggressive
7484 scrolling is in use, don't let point enter the opposite scroll
7485 margin as result of the scroll.
7486 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7487 threshold of 100 lines for never-recentering scrolling.
7488
e4cc2dfc
JB
74892011-03-31 Juanma Barranquero <lekktu@gmail.com>
7490
7491 * dispextern.h (move_it_by_lines):
7492 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7493 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7494 (message_log_check_duplicate): Remove parameters `prev_bol' and
7495 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7496 (redisplay_internal): Remove parameter `preserve_echo_area',
7497 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7498
7499 * indent.c (Fvertical_motion):
7500 * window.c (window_scroll_pixel_based, Frecenter):
7501 Don't pass `need_y_p' to `move_it_by_lines'.
7502
1c470562
SM
75032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7504
44f230aa
SM
7505 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7506 steal a few bits to be more compact.
7507 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7508 Remove unneeded casts.
7509
1c470562
SM
7510 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7511
888adce9
ZK
75122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7513
7514 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7515 binding" message (bug#7967).
7516
f838ed7b
PE
75172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7518
77861b95
PE
7519 Fix more problems found by GCC 4.6.0's static checks.
7520
de6dbc14
PE
7521 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7522 Remove unused local var.
7523
f838ed7b
PE
7524 * editfns.c (Fmessage_box): Remove unused local var.
7525
792c7b2b
PE
7526 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7527 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7528 Omit unused local vars.
c499e557 7529 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7530 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7531 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7532 Omit unused local var.
7533
ba0165e1
PE
7534 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7535 Don't assume string length fits in int.
32ad8845 7536 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7537 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7538
3c59b4c9
PE
7539 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7540 instead of alloca (Bug#8344).
7541
a3eed478 7542 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7543 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7544
eb4d412d
PE
7545 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7546
1658b401
PE
7547 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7548 concerns.
7549
7550 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7551
7552 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7553
9a2c6e05
PE
7554 * keyboard.c (syms_of_keyboard): Use the same style as later
7555 in this function when indexing through an array. This also
7556 works around GCC bug 48267.
7557
03d0a109
PE
7558 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7559
44f730c8
PE
7560 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7561
fe75f926
PE
7562 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7563 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7564
ffa8c828
PE
7565 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7566 This avoids undefined behavior on integer overflow, and is a bit
7567 more convenient anyway since it is compared to a size_t variable.
7568
c5101a77
PE
7569 Variadic C functions now count arguments with size_t, not int.
7570 This avoids an unnecessary limitation on 64-bit machines, which
7571 caused (substring ...) to crash on large vectors (Bug#8344).
7572 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7573 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7574 All variadic functions and their callers changed accordingly.
c5101a77
PE
7575 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7576 * data.c (arith_driver, float_arith_driver): Likewise.
7577 * editfns.c (general_insert_function): Likewise.
7578 * eval.c (struct backtrace.nargs, interactive_p)
7579 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7580 (funcall_lambda, mark_backtrace): Likewise.
7581 * fns.c (concat): Likewise.
7582 * frame.c (x_set_frame_parameters): Likewise.
7583 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7584 0 if not found, not -1. All callers changed.
7585
dd3f25f7
PE
7586 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7587 (stack_copy_size): Now size_t, not int.
7588 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7589
461c2ab9
JB
75902011-03-28 Juanma Barranquero <lekktu@gmail.com>
7591
7592 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7593 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7594 All callers changed.
7595
7596 * lisp.h (multibyte_char_to_unibyte):
7597 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7598 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7599 * character.h (CHAR_TO_BYTE8):
7600 * cmds.c (internal_self_insert):
7601 * editfns.c (general_insert_function):
7602 * keymap.c (push_key_description):
7603 * search.c (Freplace_match):
7604 * xdisp.c (message_dolog, set_message_1): All callers changed.
7605
f6d62986
SM
76062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7607
7608 * keyboard.c (safe_run_hook_funcall): New function.
7609 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7610 don't set the hook to nil, but remove the offending function instead.
7611 (Qcommand_hook_internal): Remove, unused.
7612 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7613 Vcommand_hook_internal.
7614
7615 * eval.c (enum run_hooks_condition): Remove.
7616 (funcall_nil, funcall_not): New functions.
7617 (run_hook_with_args): Call each function through a `funcall' argument.
7618 Remove `cond' argument, now redundant.
7619 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7620 (Frun_hook_with_args_until_failure): Adjust accordingly.
7621 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7622
1db5b1ad
JB
76232011-03-28 Juanma Barranquero <lekktu@gmail.com>
7624
7625 * dispextern.h (string_buffer_position): Remove declaration.
7626
7627 * print.c (strout): Remove parameter `multibyte', unused since
7628 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7629
7630 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7631 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7632 All callers changed.
7633
7634 * w32.c (_wsa_errlist): Use braces for struct initializers.
7635
7636 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7637 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7638 All callers changed.
7639 (string_buffer_position): Likewise. Also, make static (it's never
7640 used outside xdisp.c).
7641 (cursor_row_p): Remove parameter `w', unused since
7642 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7643 (decode_mode_spec): Remove parameter `precision', introduced during
7644 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7645 All callers changed.
7646
5ffb62aa
JD
76472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7648
7649 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7650
461c2ab9 76512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7652
7653 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7654 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7655 (ns_update_auto_hide_menu_bar): New functions.
7656 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7657 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7658 ns_constrain_all_frames.
7659 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7660 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7661
5c380ffb
JD
76622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7663
7664 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7665
9af30bdf
GM
76662011-03-27 Glenn Morris <rgm@gnu.org>
7667
7668 * syssignal.h: Replace RETSIGTYPE with void.
7669 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7670 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7671 Replace SIGTYPE with void everywhere.
7672 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7673 * s/template.h (SIGTYPE): Remove commented out definition.
7674
e2abce01
JB
76752011-03-26 Eli Zaretskii <eliz@gnu.org>
7676
7677 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7678 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7679
f868cd8a
JB
76802011-03-26 Juanma Barranquero <lekktu@gmail.com>
7681
59eb0929
JB
7682 * w32.c (read_unc_volume): Use parameter `henum', instead of
7683 global variable `wget_enum_handle'.
7684
7685 * keymap.c (describe_vector): Remove parameters `indices' and
7686 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7687 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7688
f868cd8a
JB
7689 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7690
7691 * keyboard.c (timer_check): Remove parameter `do_it_now',
7692 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7693 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7694 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7695
7696 * keyboard.c (read_char):
7697 * w32menu.c (w32_menu_display_help):
7698 * xmenu.c (show_help_event, menu_help_callback):
7699 Adjust calls to `show_help_echo'.
7700
7701 * gtkutil.c (xg_maybe_add_timer):
7702 * keyboard.c (readable_events):
7703 * process.c (wait_reading_process_output):
7704 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7705
7706 * insdel.c (adjust_markers_gap_motion):
7707 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7708 (gap_left, gap_right): Don't call it.
7709
2ecf6fdb
CY
77102011-03-25 Chong Yidong <cyd@stupidchicken.com>
7711
7712 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7713 incurred during fontification.
7714
6b1f9ba4
JB
77152011-03-25 Juanma Barranquero <lekktu@gmail.com>
7716
7717 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7718 (DEFVAR_PER_BUFFER): Don't pass it.
7719
7720 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7721 (scrolling_window): Don't pass it.
7722
0f4a96b5
JB
77232011-03-25 Juanma Barranquero <lekktu@gmail.com>
7724
7725 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7726
7727 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7728 and `suffix'.
7729 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7730 of variables specific to SELinux and computation of `encoded_absname'.
7731
7732 * image.c (XPutPixel): Remove unused variable `height'.
7733
7734 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7735
7736 * unexw32.c (get_section_info): Remove unused variable `section'.
7737
7738 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7739 (system_process_attributes): Remove unused variable `sess'.
7740 (sys_read): Remove unused variable `err'.
7741
7742 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7743 (w32_wnd_proc): Remove unused variable `isdead'.
7744 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7745 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7746 (x_create_tip_frame): Remove unused variable `tem'.
7747
7748 * w32inevt.c (w32_console_read_socket):
7749 Remove unused variable `no_events'.
7750
7751 * w32term.c (x_draw_composite_glyph_string_foreground):
7752 Remove unused variable `width'.
7753
1149507c
JB
77542011-03-24 Juanma Barranquero <lekktu@gmail.com>
7755
7756 * w32term.c (x_set_glyph_string_clipping):
7757 Don't pass uninitialized region to CombineRgn.
7758
9c88f339
JB
77592011-03-23 Juanma Barranquero <lekktu@gmail.com>
7760
7761 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7762 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7763 (Fx_close_connection): Remove unused variable `i'.
7764
7765 * w32font.c (w32font_draw): Return number of glyphs.
7766 (w32font_open_internal): Remove unused variable `i'.
7767 (w32font_driver): Add missing initializer.
7768
7769 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7770 (fill_in_menu): Remove unused variable `items_added'.
7771
7772 * w32term.c (last_mouse_press_frame): Remove static global variable.
7773 (w32_clip_to_row): Remove unused variable `f'.
7774 (x_delete_terminal): Remove unused variable `i'.
7775
7776 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7777 (NOTHING): Remove unused static global variable.
7778 (uniscribe_check_otf): Remove unused variable `table'.
7779 (uniscribe_font_driver): Add missing initializers.
7780
dee091a3
JD
77812011-03-23 Julien Danjou <julien@danjou.info>
7782
7783 * term.c (Fsuspend_tty, Fresume_tty):
7784 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7785 * window.c (temp_output_buffer_show):
7786 * insdel.c (signal_before_change):
7787 * frame.c (Fhandle_switch_frame):
7788 * fileio.c (Fdo_auto_save):
7789 * emacs.c (Fkill_emacs):
7790 * editfns.c (save_excursion_restore):
7791 * cmds.c (internal_self_insert):
7792 * callint.c (Fcall_interactively):
7793 * buffer.c (Fkill_all_local_variables):
7794 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7795 Use Frun_hooks.
0f4a96b5 7796 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7797 unconditionally since it does the check itself.
dee091a3 7798
2c520ab5 77992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7800
c9c49752
PE
7801 Fix more problems found by GCC 4.5.2's static checks.
7802
8abc3f12
PE
7803 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7804 the first time through the loop, since we know p0 < p1 then.
7805 This also avoids a gcc -Wstrict-overflow warning.
7806
a2d26660
PE
7807 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7808 leading to a memory leak, possible in functions like
7809 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7810 of objects (Bug#8318).
a2d26660 7811
916c72e9
PE
7812 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7813 that could (at least in theory) be that large.
7814
19ab8a18
PE
7815 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7816 This is less likely to overflow, and avoids undefined behavior if
7817 overflow does occur. All callers changed. Use strtoul to scan
7818 for the unsigned long integer.
b7cbbd6f
PE
7819 (pint2hrstr): Simplify and tune code slightly.
7820 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7821
f0641eff
PE
7822 * scroll.c (do_scrolling): Work around GCC bug 48228.
7823 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7824
7f650bb9
PE
7825 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7826 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7827 (validate_x_resource_name): Simplify count usage.
7828 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7829
37dd57d1
PE
7830 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7831 fail (Bug#8306).
81e56e61 7832
699979fc 7833 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7834
401bf9b4
PE
7835 * process.c (Fmake_network_process): Use socklen_t, not int,
7836 where POSIX says socklen_t is required in portable programs.
7837 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7838 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7839 (Fmake_network_process, server_accept_connection):
7840 (wait_reading_process_output, read_process_output):
7841 Likewise.
7842
b93aacde
PE
7843 * process.c: Rename or move locals to avoid shadowing.
7844 (list_processes_1, Fmake_network_process):
7845 (read_process_output_error_handler, exec_sentinel_error_handler):
7846 Rename or move locals.
4dc343ee 7847 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7848 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7849 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7850 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7851 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7852
af8a867c 7853 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7854 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7855 Include tparam.h instead, since it declares them.
af8a867c
PE
7856 * cm.h (PC): Remove extern decl; tparam.h now does this.
7857 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7858 * terminfo.c: Include tparam.h, to check interfaces.
7859 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7860 (tparam): Adjust signature to match interface in tparam.h;
7861 this removes some undefined behavior. Check that outstring and len
7862 are zero, which they always are with Emacs.
7863 * tparam.h (PC, BC, UP): New extern decls.
7864
0248044d 7865 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7866 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7867
8ff096c1 7868 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7869 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7870 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7871 (ftfont_list): Remove unused local.
49eaafba
PE
7872 (get_adstyle_property, ftfont_pattern_entity):
7873 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7874 Rename locals to avoid shadowing.
8ff096c1 7875
e2be39f6
PE
7876 * xfont.c (xfont_list_family): Mark var as initialized.
7877
c9735e30
PE
7878 * xml.c (make_dom): Now static.
7879
8f5201ae
PE
7880 * composite.c (composition_compute_stop_pos): Rename local to
7881 avoid shadowing.
b246f932
PE
7882 (composition_reseat_it): Remove unused locals.
7883 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7884 (composition_update_it): Mark var as initialized.
11b61122
PE
7885 (find_automatic_composition): Mark vars as initialized,
7886 with a FIXME (Bug#8290).
8f5201ae 7887
760fbc2c
PE
7888 character.h: Rename locals to avoid shadowing.
7889 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7890 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7891 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7892 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7893 to avoid shadowing.
7894
ff08eb85
PE
7895 * textprop.c (property_change_between_p): Remove; unused.
7896
fc7bf025
PE
7897 * intervals.c (interval_start_pos): Now static.
7898
235d7abc
PE
7899 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7900
44f230aa
SM
7901 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7902 Rename locals to avoid shadowing.
3e7d6594 7903
50060332
PE
7904 * sound.c (wav_play, au_play, Fplay_sound_internal):
7905 Fix pointer signedness.
d01f234b 7906 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7907 (wav_play): Initialize a variable to 0, to prevent undefined
7908 behavior (Bug#8278).
50060332 7909
c4fc4e30
PE
7910 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7911
918436ed
PE
7912 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7913
c939f91b
PE
7914 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7915 clobbering (Bug#8298).
b9c7f648
PE
7916 * sysdep.c (sys_subshell): Likewise.
7917 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7918
6bd8c144
PE
7919 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7920 This should get cleaned up, so that child_setup has the
7921 same signature on all platforms.
7922
7710357c 7923 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7924 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7925
c59da222
CY
79262011-03-22 Chong Yidong <cyd@stupidchicken.com>
7927
7928 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7929 not to be necessary, and produces flickering.
7930
66b87493
GM
79312011-03-20 Glenn Morris <rgm@gnu.org>
7932
7933 * config.in: Remove file.
7934
45b6f6d5
JB
79352011-03-20 Juanma Barranquero <lekktu@gmail.com>
7936
7937 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7938 are now in src/globals.h.
7939 (syms_of_minibuf): Remove spurious & from previous change.
7940
3ec03f7e
LL
79412011-03-20 Leo <sdl.web@gmail.com>
7942
7943 * minibuf.c (completing-read-function): New variable.
7944 (completing-read-default): Rename from completing-read.
7945 (completing-read): Call completing-read-function.
7946
b14e3e21
CY
79472011-03-19 Juanma Barranquero <lekktu@gmail.com>
7948
7949 * xfaces.c (Fx_load_color_file):
7950 Read color file from absolute filename (bug#8250).
7951
f2b726e6
JB
79522011-03-19 Juanma Barranquero <lekktu@gmail.com>
7953
7954 * makefile.w32-in: Update dependencies.
7955
09f6ff02
EZ
79562011-03-17 Eli Zaretskii <eliz@gnu.org>
7957
7958 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7959
29a6015a
PE
79602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7961
a3a6c54e
PE
7962 Fix more problems found by GCC 4.5.2's static checks.
7963
b766f867
PE
7964 * process.c (make_serial_process_unwind, send_process_trap):
7965 (sigchld_handler): Now static.
7966
be02381c
PE
7967 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7968 That way, the code declares only the vars that it needs.
7969 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7970 * s/cygwin.h (PTY_ITERATION): Likewise.
7971 * s/darwin.h (PTY_ITERATION): Likewise.
7972 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7973
57048744
PE
7974 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7975 * process.c (allocate_pty): Don't declare stb unless it's needed.
7976
7914961c 7977 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7978 (CONSTANTLIM): Remove; unused.
7979 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7980 Define only if needed.
7914961c 7981
b3967b18
PE
7982 * unexelf.c (unexec): Name an expression,
7983 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7984 Use a different way to cause a compilation error if anyone uses
7985 n rather than nn, a way that does not involve shadowing.
73366a00 7986 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7987
29a6015a
PE
7988 * deps.mk (unexalpha.o): Remove; unused.
7989
43cfc33e 7990 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7991 * unexec.h: New file.
ce701a33
PE
7992 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7993 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7994 Depend on unexec.h.
7995 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7996 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7997 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7998 Change as necessary to match prototype in unexec.h.
ce701a33 7999
01f44d5a
PE
8000 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8001 shadowing.
4f63c6bb 8002 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8003
a6670b0b
PE
8004 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8005 Rename locals to avoid shadowing.
8006
cef2010d 8007 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8008 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8009
d4d7173a
PE
8010 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8011
f08b802a
PE
8012 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8013 warning when compiling print.c.
8014
3ddb0639
PE
8015 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8016 instead of using an uninitialized var.
5ad03b97 8017 (font_sort_entities): Mark var as initialized.
3ddb0639 8018
170a2692
PE
8019 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8020
e663c700
PE
8021 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8022 pointers to constants.
89bc529a 8023 (font_parse_fcname): Remove unused vars.
7b81e2d0 8024 (font_delete_unmatched): Now static.
ea838e10 8025 (font_get_spec): Remove; unused.
13a547c6
PE
8026 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8027 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8028 Rename or move locals to avoid shadowing.
e663c700 8029
2a80c887 8030 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8031 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8032
1384fa33 8033 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8034 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8035
8b2c52e9
PE
8036 * alloc.c (mark_backtrace): Move decl from here ...
8037 * lisp.h: ... to here, so that it can be checked.
8038
475545b5 8039 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8040 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8041 (lisp_indirect_variable): Name an expression,
8042 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8043 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8044
b1349114 8045 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8046 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8047 Use const pointer when appropriate.
b1349114 8048
a2928364
PE
8049 * lisp.h (get_system_name, get_operating_system_release):
8050 Move decls here, to check interfaces.
8051 * process.c (get_operating_system_release): Move decl to lisp.h.
8052 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8053 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8054 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8055 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8056 (Fformat_time_string, Fencode_time, Finsert_char):
8057 (Ftranslate_region_internal, Fformat):
8058 Rename or remove local vars to avoid shadowing.
9710023e 8059 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8060
a415e694
PE
8061 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8062 avoid shadowing.
8063
8ef4622d
PE
8064 * lisp.h (eassert): Check that the argument compiles, even if
8065 ENABLE_CHECKING is not defined.
8066
946f9a5b
PE
8067 * data.c (Findirect_variable): Name an expression, to avoid
8068 gcc -Wbad-function-cast warning.
112396d6 8069 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8070 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8071 (Fmake_variable_buffer_local, Fmake_local_variable):
8072 Mark variables as initialized.
52746918 8073 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8074
e5aab7e7 8075 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8076 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8077 Rename locals to avoid shadowing.
dff45157
PE
8078 (mark_stack): Move local variables into the #ifdef region where
8079 they're used.
7bc26fdb
PE
8080 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8081 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8082 needed otherwise.
8083 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8084 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8085 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8086
e5aab7e7
PE
8087 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8088 avoids undefined behavior in theory.
8089
4da60324
PE
8090 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8091
88043301
PE
8092 Use functions, not macros, for up- and down-casing (Bug#8254).
8093 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8095 to use the following functions instead of these macros.
8096 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8097 EMACS_INT, since callers assume the returned value fits in int.
8098 (upcase1): Likewise, for UPCASE_TABLE.
8099 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8100 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8101 the race-condition problem in the old DOWNCASE.
88043301 8102
19ed5445
PE
8103 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8104 Rename locals to avoid shadowing.
8105 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8106 (regex_compile, re_search_2, re_match_2_internal):
8107 Remove unused local vars.
952db0d7
PE
8108 (FREE_VAR): Rewrite so as not to use empty "else",
8109 which gcc can warn about.
da053e48 8110 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8111 (RETALLOC_IF): Define only if needed.
8112 (WORDCHAR_P): Likewise. This one is never needed, but is used
8113 only in a comment talking about a compiler bug, so put inside
8114 the #if 0 of that comment.
8115 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8116 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8117 Remove; unused.
19ed5445 8118
1f3561e4 8119 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8120 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8121 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8122
ded6f8f7
PE
8123 * search.c (simple_search): Remove unused var.
8124
dbd37a95
PE
8125 * dired.c (compile_pattern): Move decl from here ...
8126 * lisp.h: ... to here, so that it can be checked.
8127 (struct re_registers): New forward decl.
8128
7e47afad
PE
8129 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8130
85f24f61
PE
8131 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8132 All uses changed.
8133 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8134 Rename locals to avoid shadowing.
5671df8f 8135 (Fvertical_motion): Mark locals as initialized.
85f24f61 8136
181aa2be 8137 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8138 (casify_region): Mark local as initialized.
181aa2be 8139
930d429c
PE
8140 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8141
7082eac6
PE
8142 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8143 New macros, so that the caller can use some names other than
8144 gcpro1, gcpro2, etc.
8145 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8146 of the new macros.
8147 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8148 argument, for consistency with GCPRO2_VAR, etc: it is now the
8149 prefix of the variable, not the variable itself. All uses
8150 changed.
38b2c076
PE
8151 * dired.c (directory_files_internal, file_name_completion):
8152 Rename locals to avoid shadowing.
8153
15206ed9
PE
8154 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8155 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8156 dired.c's scmp function, had undefined behavior.
8157 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8158 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8159 * buffer.h: ... to here, because these macros use current_buffer,
8160 and the new implementation with inline functions needs to have
8161 current_buffer in scope now, rather than later when the macros
8162 are used.
8163 (downcase, upcase1): New static inline functions.
8164 (DOWNCASE, UPCASE1): Reimplement using these functions.
8165 This avoids undefined behavior in expressions like
8166 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8167 from race conditions in accessing the global variables
8168 case_temp1 and case_temp2.
8169 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8170 * lisp.h (case_temp1, case_temp2): Remove their decls.
8171 * character.h (ASCII_CHAR_P): Move from here ...
8172 * lisp.h: ... to here, so that the inline functions mentioned
8173 above can use them.
8174
4a6bea26
PE
8175 * dired.c (directory_files_internal_unwind): Now static.
8176
f14b7e14
PE
8177 * fileio.c (file_name_as_directory, directory_file_name):
8178 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8179 Now static.
2893f146
PE
8180 (file_name_as_directory): Use const pointers when appropriate.
8181 (Fexpand_file_name): Likewise. In particular, newdir might
8182 point at constant storage, so make it a const pointer.
fd4ead52 8183 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8184 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8185 signedness issues.
f839df0c
PE
8186 (Fset_file_times, Finsert_file_contents, auto_save_error):
8187 Rename locals to avoid shadowing.
f14b7e14 8188
5716756e 8189 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8190 (Ftry_completion, Fall_completions): Rename or remove locals
8191 to avoid shadowing.
5716756e 8192
b4c3046a
PE
8193 * marker.c (bytepos_to_charpos): Remove; unused.
8194
b45db522
PE
8195 * lisp.h (verify_bytepos, count_markers): New decls,
8196 so that gcc does not warn that these functions aren't declared.
8197
85876d07
PE
8198 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8199 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8200 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8201 (copy_text): Remove unused local var.
85876d07 8202
03d78a21 8203 * filelock.c (within_one_second): Now static.
b3dd38ab 8204 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8205
5df8f01b
PE
8206 * buffer.c (fix_overlays_before): Mark locals as initialized.
8207 (fix_start_end_in_overlays): Likewise. This function should be
8208 simplified by using pointers-to-pointers, but that's a different
8209 matter.
b1d876f1 8210 (switch_to_buffer_1): Now static.
8f54f30a
PE
8211 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8212 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8213
a70072c9 8214 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8215 Fix pointer signedness issue.
edced198
PE
8216 (sys_subshell): Mark local as volatile if checking for lint,
8217 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8218 (MAXPATHLEN): Define only if needed.
a70072c9 8219
a0977c44
PE
8220 * process.c (serial_open, serial_configure): Move decls from here ...
8221 * systty.h: ... to here, so that they can be checked.
8222
a884fdcc
PE
8223 * fns.c (get_random, seed_random): Move extern decls from here ...
8224 * lisp.h: ... to here, so that they can be checked.
8225
604efe86 8226 * sysdep.c (reset_io): Now static.
b8950c94 8227 (wait_for_termination_signal): Remove; unused.
604efe86 8228
38fc62d9
PE
8229 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8230 (copy_keymap_item, append_key, push_text_char_description):
8231 Now static.
1004a21a 8232 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8233 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8234 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8235 (describe_map_tree):
8236 Rename locals to avoid shadowing.
38fc62d9 8237
2f2650da
PE
8238 * keyboard.c: Declare functions static if they are not used elsewhere.
8239 (echo_char, echo_dash, cmd_error, top_level_2):
8240 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8241 (read_char, kbd_buffer_get_event, make_lispy_position):
8242 (make_lispy_event, make_lispy_movement, apply_modifiers):
8243 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8244 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8245 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8246 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8247 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8248
a053e86c 8249 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8250 (mark_kboards): Move decl here ...
8251 * alloc.c (mark_kboards): ... from here.
a053e86c 8252
4752793e
PE
8253 * lisp.h (force_auto_save_soon): New decl.
8254
74f10ca7 8255 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8256 (DEFINE_DUMMY_FUNCTION): New macro.
8257 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8258 Use it.
c03cd23f
PE
8259 (main): Add casts to avoid warnings
8260 if GCC considers string literals to be constants.
74f10ca7 8261
022e70d4
PE
8262 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8263
59d6fe83
PE
8264 * dbusbind.c: Pointer signedness fixes.
8265 (xd_signature, xd_append_arg, xd_initialize):
8266 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8267 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8268 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8269 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8270
78320123
PE
8271 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8272 if GCC considers string literals to be constants.
49cebcca 8273 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8274
35ac2a97
SM
82752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8276
fb103ca9
SM
8277 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8278 (print_preprocess, print_object): New macro to fix last change.
8279
35ac2a97
SM
8280 * print.c (print_preprocess): Don't forget font objects.
8281
62973b41
JB
82822011-03-16 Juanma Barranquero <lekktu@gmail.com>
8283
8284 * emacs.c (USAGE3): Doc fixes.
8285
0e48bb22
AS
82862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8287
8288 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8289 structure.
8290
7684e57b
JB
82912011-03-14 Juanma Barranquero <lekktu@gmail.com>
8292
8293 * lisp.h (VWindow_system, Qfile_name_history):
8294 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8295 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8296 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8297
8298 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8299 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8300
8301 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8302 * w32console.c (detect_input_pending, read_input_pending)
8303 (encode_terminal_code):
8304 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8305 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8306 (w32_system_caret_y, Qfile_name_history):
8307 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8308 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8309 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8310 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8311 * w32proc.c (Qlocal, report_file_error):
8312 * w32term.c (Vwindow_system, updating_frame):
8313 * w32uniscribe.c (initialized, uniscribe_font_driver):
8314 Remove unneeded extern declarations.
8315
2aa46d6c
CY
83162011-03-14 Chong Yidong <cyd@stupidchicken.com>
8317
c96bbc66 8318 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8319
cffc6f3b
CY
83202011-03-13 Chong Yidong <cyd@stupidchicken.com>
8321
8322 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8323 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8324 These macros can no longer be used for assignment.
8325
44f230aa
SM
8326 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8327 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8328 (record_buffer_markers, fetch_buffer_markers): New functions for
8329 recording and fetching special buffer markers.
8330 (set_buffer_internal_1, set_buffer_temp): Use them.
8331
8332 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8333
8334 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8335
8336 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8337 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8338
8339 * xdisp.c (hscroll_window_tree):
8340 (reconsider_clip_changes): Use PT instead of BUF_PT.
8341
d251f04b
EZ
83422011-03-13 Eli Zaretskii <eliz@gnu.org>
8343
8344 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8345 $(EMACS_ROOT)/lib/intprops.h.
8346
f0c77cd1
PE
83472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8348
3eca4629
PE
8349 Fix more problems found by GCC 4.5.2's static checks.
8350
7c86ee98
PE
8351 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8352 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8353 (xg_free_frame_widgets): Make it clear that a local variable is
8354 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8355 (gdk_window_get_screen): Make it clear that this macro is needed
8356 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8357 (int_gtk_range_get_value): New function, which avoids a diagnostic
8358 from gcc -Wbad-function-cast.
8359 (xg_set_toolkit_scroll_bar_thumb): Use it.
8360 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8361 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8362 (get_utf8_string, xg_get_file_with_chooser):
8363 Rename locals to avoid shadowing.
8364 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8365
41729b81
PE
8366 * xgselect.c (xg_select): Remove unused var.
8367
f0c77cd1
PE
8368 * image.c (four_corners_best): Mark locals as initialized.
8369 (gif_load): Initialize transparent_p to zero (Bug#8238).
8370 Mark another local as initialized.
ec6cf4c6 8371 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8372
ce0ad53d 8373 * image.c (clear_image_cache): Now static.
d5d5a617 8374 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8375 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8376 (x_edge_detection): Remove unnecessary cast that
8377 gcc -Wbad-function-cast diagnoses.
2037898d 8378 (gif_load): Fix pointer signedness.
6ae141d6
PE
8379 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8380 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8381
33383987 83822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8383
d32df629
PE
8384 Improve quality of tests for time stamp overflow.
8385 For example, without this patch (encode-time 0 0 0 1 1
8386 1152921504606846976) returns the obviously-bogus value (-948597
8387 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8388 reports time overflow. See
8389 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8390 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8391 * editfns.c: Include limits.h and intprops.h.
8392 (TIME_T_MIN, TIME_T_MAX): New macros.
8393 (time_overflow): Move earlier, to before first use.
8394 (hi_time, lo_time): New functions, for an accurate test for
8395 out-of-range times.
8396 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8397 (Fget_internal_run_time): Don't assume time_t fits in int.
8398 (make_time): Use list2 instead of Fcons twice.
8399 (Fdecode_time): More accurate test for out-of-range times.
8400 (check_tm_member): New function.
8401 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8402 (lisp_time_argument): Don't rely on undefined left-shift and
8403 right-shift behavior when checking for time stamp overflow.
8be6f318 8404
fe31d94c
PE
8405 * editfns.c (time_overflow): New function, refactoring common code.
8406 (Fformat_time_string, Fdecode_time, Fencode_time):
8407 (Fcurrent_time_string): Use it.
8408
8be6f318
PE
8409 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8410 * dired.c (make_time): Move to ...
8411 * editfns.c (make_time): ... here.
8412 * systime.h: Note the move.
8413
09d9db2c 84142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8415
126bc0dc
YM
8416 * fringe.c (update_window_fringes): Remove unused variables.
8417
c47cbdfd
YM
8418 * unexmacosx.c (copy_data_segment): Also copy __got section.
8419 (Bug#8223)
8420
7ac80be9
EZ
84212011-03-12 Eli Zaretskii <eliz@gnu.org>
8422
c96bbc66 8423 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8424 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8425 Constify `char *' arguments and their references according to
8426 prototypes in tparam.h.
8427
ecb0f94d 8428 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8429
7ac80be9
EZ
8430 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8431 Adapt all references accordingly.
8432
8433 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8434
ef1fd07e
TT
84352011-03-11 Tom Tromey <tromey@redhat.com>
8436
8437 * buffer.c (syms_of_buffer): Remove obsolete comment.
8438
7ef4b50c
EZ
84392011-03-11 Eli Zaretskii <eliz@gnu.org>
8440
8441 * termhooks.h (encode_terminal_code): Declare prototype.
8442
8443 * msdos.c (encode_terminal_code): Don't declare prototype.
8444
8445 * term.c (encode_terminal_code): Now external again, used by
8446 w32console.c and msdos.c.
8447
44f230aa
SM
8448 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8449 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8450
4b1ec863 84512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8452
1714f52b 8453 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8454
4b1ec863
PE
8455 * fringe.c (update_window_fringes): Mark locals as initialized
8456 (Bug#8227).
8457 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8458
524c7aa6
PE
8459 * alloc.c (mark_fringe_data): Move decl from here ...
8460 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8461 to check its interface.
8462 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8463
a5c0af81 8464 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8465 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8466 (fontset_font): Mark local as initialized.
a9a06e0b 8467 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8468
b4716021
PE
8469 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8470
811e9bac 8471 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8472 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8473 (x_own_selection, Fx_disown_selection_internal): Rename locals
8474 to avoid shadowing.
8475 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8476
7e3ab302
PE
8477 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8478 so that the caller can use some name other than gcpro1.
8479 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8480 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8481 (Fx_backspace_delete_keys_p):
8482 Use them to avoid shadowing, and rename vars to avoid shadowing.
8483 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8484 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8485 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8486 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8487 Remove unused locals.
7e3ab302
PE
8488 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8489 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8490 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8491 macros.
f78faa98 8492
e2b13473
PE
8493 * xterm.h (x_mouse_leave): New decl.
8494
77f23912
PE
8495 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8496 Remove unused functions.
cdf4ba58
PE
8497 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8498 (x_calc_absolute_position): Now static.
7411c686 8499 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8500 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8501 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8502 unless they are used.
38d0b34a
PE
8503 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8504 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8505 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8506 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8507 (x_error_catcher, x_connection_closed, x_error_handler):
8508 (x_error_quitter, xembed_send_message, x_iconify_frame):
8509 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8510 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8511 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8512
44f230aa
SM
8513 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8514 Rename or move locals to avoid shadowing.
6b463e58 8515 (tty_defined_color, merge_face_heights): Now static.
5967d051 8516 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8517 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8518 does not deduce is never used uninitialized.
73719eba
PE
8519 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8520 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8521
426994c3 8522 * terminal.c (store_terminal_param): Now static.
5489860b 8523
032f1620 8524 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8525 (set_frame_menubar): Remove unused local.
d4323972 8526 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8527 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8528 since they might point to immutable storage.
281585b0
PE
8529 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8530 since it's unused otherwise.
032f1620 8531
367c19e5 8532 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8533 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8534 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8535 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8536 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8537 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8538 does not deduce are never used uninitialized.
70739cbe 8539
07b48fa9
PE
8540 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8541
8868a238 8542 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8543 * window.c (window_loop, size_window):
8544 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8545
7e5cf297 8546 * window.c (display_buffer): Now static.
d6550a9f
PE
8547 (size_window): Mark variables that gcc -Wuninitialized
8548 does not deduce are never used uninitialized.
a586633d
PE
8549 * window.h (check_all_windows): New decl, to forestall
8550 gcc -Wmissing-prototypes diagnostic.
5b555da1 8551 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8552
f6095868
PE
8553 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8554 shadowing.
8555 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8556 Include <limits.h>.
8557 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8558 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8559 (load_charset_map): Mark variables that gcc -Wuninitialized
8560 does not deduce are never used uninitialized.
53df7c11 8561 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8562
f38b440c
PE
8563 * coding.c (coding_set_source, coding_set_destination):
8564 Use "else { /* comment */ }" rather than "else /* comment */;"
8565 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8566 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8567 a block, when the outer 'i' will do.
8568 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8569 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8570 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8571 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8572 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8573 Rename locals to avoid shadowing.
8574 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8575 * coding.c (emacs_mule_char, encode_invocation_designation):
8576 Now static, since they're not used elsewhere.
413bb2db 8577 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8578 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8579 (decode_coding_emacs_mule): Mark variables that gcc
8580 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8581 (detect_coding_iso_2022): Initialize a local variable that might
8582 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8583 this initialization is needed. (Bug#8211)
5f58e762
PE
8584 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8585 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8586 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8587 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8588 Remove unused macros.
f38b440c 8589
232b38b9 8590 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8591 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8592 * character.c (string_count_byte8): Likewise.
232b38b9 8593
fb90da1b
PE
8594 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8595 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8596
fb93dbc2
PE
8597 * chartab.c (copy_sub_char_table): Now static, since it's not used
8598 elsewhere.
5c156ace
PE
8599 (sub_char_table_ref_and_range, char_table_ref_and_range):
8600 Rename locals to avoid shadowing.
bbcd0949 8601 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8602
7d3b3862 8603 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8604 (BIDI_BOB): Remove unused macro.
7d3b3862 8605
6be7d3da
PE
8606 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8607 deduce are never used uninitialized.
c2ed9c8b 8608 * term.c (encode_terminal_code): Likewise.
6be7d3da 8609
75f8807f 8610 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8611
50938595
PE
8612 * tparam.h: New file.
8613 * term.c, tparam.h: Include it.
8614 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8615 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8616 Move these decls to tparam.h, and make them agree with what
8617 is actually in tparam.c. The previous trick of using incompatible
8618 decls in different modules does not conform to the C standard.
8619 All callers of tparam changed to use tparam's actual API.
8620 * tparam.c (tparam1, tparam, tgoto):
8621 Use const pointers where appropriate.
8622
fbceeba2
PE
8623 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8624 * cm.h (struct cm): Likewise.
8625 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8626 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8627 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8628 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8629 (turn_on_face, init_tty): Likewise.
8630 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8631
7f3f1250
PE
8632 * term.c (term_mouse_position): Rename local to avoid shadowing.
8633
e6ca6543
PE
8634 * alloc.c (mark_ttys): Move decl from here ...
8635 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8636
c40f8d15
AS
86372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8638
8639 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8640
cfe0661d
JB
86412011-03-09 Juanma Barranquero <lekktu@gmail.com>
8642
8643 * search.c (compile_pattern_1): Remove argument regp, unused since
8644 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8645 (compile_pattern): Don't pass it.
8646
0afb4571
J
86472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8648
8649 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8650 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8651 for ! HAVE_GTK3.
8652 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8653
8654 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8655
8656 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8657 gdk_window_get_screen, gdk_window_get_geometry,
8658 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8659 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8660 (xg_get_pixbuf_from_pixmap): New function.
8661 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8662 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8663 Call xg_get_pixbuf_from_pixmap instead of
8664 gdk_pixbuf_get_from_drawable.
8665 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8666 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8667 (xg_check_special_colors): Use GtkStyleContext and its functions
8668 for HAVE_GTK3.
8669 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8670 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8671 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8672 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8673 Call gtk_widget_get_preferred_size.
0afb4571
J
8674 (xg_frame_resized): gdk_window_get_geometry only takes 5
8675 parameters.
44f230aa
SM
8676 (xg_win_to_widget, xg_event_is_for_menubar):
8677 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8678 (xg_set_widget_bg): New function.
8679 (delete_cb): New function.
895009e1 8680 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8681 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8682 (xg_set_background_color): Call xg_set_widget_bg.
8683 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8684 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8685 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8686 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8687 if ! HAVE_GTK3.
8688 (update_frame_tool_bar): Call gtk_widget_hide.
8689 (xg_initialize): Use GDK_KEY_g.
8690
8691 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8692 if ! HAVE_GTK3
8693 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8694
8695 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8696 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8697 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8698
1c2cc4ef
JB
86992011-03-08 Juanma Barranquero <lekktu@gmail.com>
8700
8701 * w32xfns.c (select_palette): Check success of RealizePalette against
8702 GDI_ERROR, not zero.
8703
33383987 8704See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8705
8706;; Local Variables:
8707;; coding: utf-8
aac0c6e3
MR
8708;; End:
8709
33383987 8710 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8711
8712 This file is part of GNU Emacs.
8713
8714 GNU Emacs is free software: you can redistribute it and/or modify
8715 it under the terms of the GNU General Public License as published by
8716 the Free Software Foundation, either version 3 of the License, or
8717 (at your option) any later version.
8718
8719 GNU Emacs is distributed in the hope that it will be useful,
8720 but WITHOUT ANY WARRANTY; without even the implied warranty of
8721 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8722 GNU General Public License for more details.
8723
8724 You should have received a copy of the GNU General Public License
8725 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.