* sysdep.c (system_process_attributes): Use CONS_TO_INTEGER in new FreeBSD code,...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c62c46f3 12012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2
2121662f 3 Fix integer width and related bugs (Bug#9874).
eb106a49 4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
d311d28c
PE
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
d311d28c
PE
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 117 Don't assume fixnum fits in int.
d311d28c
PE
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
c96e5d6a 146 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 153 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
154 (ASSURE_DESTINATION, coding_alloc_by_realloc)
155 (coding_alloc_by_making_gap, alloc_destination)
156 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
157 (encode_coding_utf_16, detect_coding_emacs_mule)
158 (decode_coding_emacs_mule, encode_coding_emacs_mule)
159 (detect_coding_iso_2022, decode_coding_iso_2022)
160 (encode_invocation_designation, encode_designation_at_bol)
161 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
162 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
163 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
164 (encode_coding_ccl, encode_coding_raw_text)
165 (detect_coding_charset, decode_coding_charset)
166 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
167 (produce_composition, produce_charset, produce_annotation)
168 (decode_coding, handle_composition_annotation)
169 (handle_charset_annotation, consume_chars, decode_coding_gap)
170 (decode_coding_object, encode_coding_object, detect_coding_system)
171 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
172 (code_convert_region, code_convert_string)
8f50130c
PE
173 (Fdefine_coding_system_internal)
174 (coding_set_source, coding_set_destination):
d311d28c
PE
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
177 (Fdefine_coding_system_internal):
178 Don't assume fixnums fit in int.
179 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 180 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
181 (Funencodable_char_position, Fcheck_coding_systems_region)
182 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 184 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 185 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 186 Don't access memory outside of the args array.
d311d28c 187 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
188 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
189 result of ENCODE_CHAR.
d311d28c
PE
190 * coding.h: Adjust decls to match defn changes elsewhere.
191 (struct coding_system):
192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
193 * composite.c (get_composition_id, find_composition)
194 (run_composition_function, update_compositions)
195 (compose_text, composition_gstring_put_cache)
196 (composition_gstring_p, composition_gstring_width)
197 (fill_gstring_header, fill_gstring_body, autocmp_chars)
198 (composition_compute_stop_pos, composition_reseat_it)
199 (composition_update_it, struct position_record)
200 (find_automatic_composition, composition_adjust_point)
201 (Fcomposition_get_gstring, Ffind_composition_internal):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (update_compositions):
204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
205 * composite.h: Adjust decls to match defn changes elsewhere.
206 (struct composition):
207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
208 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
209 Do not attempt to compute the address of the object just before a
210 buffer; this is not portable.
211 (Faref, Faset):
212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
213 (Faset): Use int, not EMACS_INT, where int is wide enough.
214 (Fstring_to_number): Don't assume fixnums fit in int.
215 (Frem): Don't assume arg is nonnegative.
216 * dbusbind.c (xd_append_arg): Check for integers out of range.
217 (Fdbus_call_method): Don't overflow the timeout int.
218 * dired.c (directory_files_internal, file_name_completion, scmp)
219 (file_name_completion_stat):
220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
221 (file_name_completion): Don't overflow matchcount.
222 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
223 * dispextern.h: Adjust decls to match defn changes elsewhere.
224 (struct text_pos, struct glyph, struct bidi_saved_info)
225 (struct bidi_string_data, struct bidi_it, struct composition_it)
226 (struct it):
227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
228 (struct display_pos, struct composition_it, struct it):
229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
230 * dispnew.c (increment_matrix_positions)
231 (increment_row_positions, mode_line_string)
232 (marginal_area_string):
233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 234 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
236 (duration_to_sec_usec): New function, to check for overflow better.
237 (Fsleep_for, sit_for): Use it.
238 * doc.c (get_doc_string, store_function_docstring):
239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
240 (get_doc_string, Fsnarf_documentation):
241 Use int, not EMACS_INT, where int is wide enough.
242 (get_doc_string):
243 Use SAFE_ALLOCA, not alloca.
244 Check for overflow when converting EMACS_INT to off_t.
245 * doprnt.c (doprnt):
246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
247 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
248 Don't assume uid_t fits into fixnum.
249 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
250 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
251 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
252 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
253 (general_insert_function)
254 (Finsert_char, make_buffer_string, make_buffer_string_both)
255 (update_buffer_properties, Fbuffer_substring)
256 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
257 (Fsubst_char_in_region, check_translation)
258 (Ftranslate_region_internal, save_restriction_restore, Fformat)
259 (transpose_markers, Ftranspose_regions):
260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
261 (clip_to_bounds): Move to lisp.h as an inline function).
262 (Fconstrain_to_field): Don't assume integers are nonnegative.
263 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
264 (Fsubst_char_in_region, Fsave_restriction):
265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
266 (Femacs_pid): Don't assume pid_t fits into fixnum.
267 (lo_time): Use int, not EMACS_INT, when int suffices.
268 (lisp_time_argument): Check for usec out of range.
269 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
270 (Fuser_login_name, Fuser_full_name): Signal an error
271 if a uid argument is out of range, rather than relying on
272 undefined behavior.
c8d5c857
PE
273 (Fformat_time_string): Remove now-unnecessary check.
274 lisp_time_argument checks for out-of-range usec now.
d311d28c
PE
275 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
276 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
277 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
278 (init_cmdargs, Fdump_emacs):
279 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
280 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
281 the bottom (typically) 32 bits of the fixnum.
282 * eval.c (specpdl_size, call_debugger):
283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
284 (when_entered_debugger, Fbacktrace_debug):
285 Don't assume fixnum can fit in int.
286 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
287 the object just before a buffer; this is not portable.
288 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
289 (grow_specpdl, unbind_to):
290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
291 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
292 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 293 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
294 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
295 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
297 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
298 (a_write, e_write):
299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
300 (Fcopy_file, non_regular_nbytes, read_non_regular)
301 (Finsert_file_contents):
302 Use int, not EMACS_INT, where int is wide enough.
303 (READ_BUF_SIZE): Verify that it fits in int.
304 (Finsert_file_contents): Check that counts are in proper range,
305 rather than assuming fixnums fit into ptrdiff_t etc.
306 Don't assume fixnums fit into int.
125b3835 307 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
308 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
309 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
310 (string_char_to_byte, string_byte_to_char)
311 (string_make_multibyte, string_to_multibyte)
312 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
313 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
314 (substring_both, Fdelete, internal_equal, Ffillarray)
315 (Fclear_string, mapcar1)
316 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
317 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
318 (larger_vector, make_hash_table, maybe_resize_hash_table)
319 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
320 (Fmaphash, secure_hash):
321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
322 (concat): Check for string index and length overflow.
323 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
324 (Frequire):
325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
326 (larger_vector): New API (vec, incr_min, size_max) replaces old
327 one (vec, new_size, init). This catches size overflow.
328 INIT was removed because it was always Qnil.
329 All callers changed.
330 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
331 the upper bound on a hash table index size.
332 (make_hash_table, maybe_resize_hash_table): Use it.
333 (secure_hash): Computer start_byte and end_byte only after
334 they're known to be in ptrdiff_t range.
335 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
336 (Ffont_get_glyphs, Ffont_at):
337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
338 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
339 (Flist_fonts, Fopen_font):
340 Don't assume fixnum can fit in int.
341 (check_gstring): Don't assume index can fit in int.
342 (font_match_p): Check that fixnum is a character, not a nonnegative
343 fixnum, since the later code needs to stuff it into an int.
344 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
345 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
346 conversion overflow issues.
347 (Fopen_font): Check for integer out of range.
348 (Ffont_get_glyphs): Don't assume index can fit in int.
349 * font.h: Adjust decls to match defn changes elsewhere.
350 * fontset.c (reorder_font_vector): Redo score calculation to avoid
351 integer overflow.
352 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
353 printmax_t, where ptrdiff_t is wide enough.
354 (Finternal_char_font):
355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
356 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
357 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
358 (Fset_frame_position, x_set_frame_parameters)
359 (x_set_line_spacing, x_set_border_width)
360 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
361 Check that fixnums are in proper range for system types.
362 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
364 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
365 Use SAFE_ALLOCA_LISP, not alloca.
366 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
367 intptr_t is wide enough.
368 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
369 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
370 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
371 Check for fixnum out of range.
372 * ftfont.c (ftfont_list): Don't assume index fits in int.
373 Check that fixnums are in proper range for system types.
374 (ftfont_shape_by_flt):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
376 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
378 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
379 Check that fixnums are in proper range for system types.
380 * gnutls.h: Adjust decls to match defn changes elsewhere.
381 * gtkutil.c (xg_dialog_run):
382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
383 (update_frame_tool_bar):
384 Check that fixnums are in proper range for system types.
385 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 386 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
387 * indent.c (last_known_column, last_known_column_point):
388 (current_column_bol_cache):
389 (skip_invisible, current_column, check_display_width):
390 (check_display_width, scan_for_column, current_column_1)
391 (Findent_to, Fcurrent_indentation, position_indentation)
392 (indented_beyond_p, Fmove_to_column, compute_motion):
393 (Fcompute_motion, Fvertical_motion):
394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
395 (last_known_column_modified): Use EMACS_INT, not int.
396 (check_display_width):
397 (Fcompute_motion):
398 Check that fixnums and floats are in proper range for system types.
399 (compute_motion): Don't assume index or fixnum fits in int.
400 (compute_motion, Fcompute_motion):
401 Use int, not EMACS_INT, when it is wide enough.
402 (vmotion): Omit local var start_hpos that is always 0; that way
403 we don't need to worry about overflow in expressions involving it.
404 * indent.h: Adjust decls to match defn changes elsewhere.
405 (struct position):
406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
407 Use int, not EMACS_INT, where int is wide enough.
408 Remove unused members ovstring_chars_done and tab_offset;
409 all uses removed.
410 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
411 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
412 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
413 (make_gap, copy_text, insert, insert_and_inherit)
414 (insert_before_markers, insert_before_markers_and_inherit)
415 (insert_1, count_combining_before, count_combining_after)
416 (insert_1_both, insert_from_string)
417 (insert_from_string_before_markers, insert_from_string_1)
418 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
419 (adjust_after_replace, adjust_after_insert, replace_range)
420 (replace_range_2, del_range, del_range_1, del_range_byte)
421 (del_range_both, del_range_2, modify_region)
422 (prepare_to_modify_buffer, signal_before_change)
423 (signal_after_change, Fcombine_after_change_execute):
424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
425 * intervals.c (traverse_intervals, rotate_right, rotate_left)
426 (balance_an_interval, split_interval_right, split_interval_left)
427 (find_interval, next_interval, update_interval)
428 (adjust_intervals_for_insertion, delete_node, delete_interval)
429 (interval_deletion_adjustment, adjust_intervals_for_deletion)
430 (static_offset_intervals, offset_intervals)
431 (merge_interval_right, merge_interval_left, make_new_interval)
432 (graft_intervals_into_buffer, temp_set_point_both)
433 (temp_set_point, set_point, adjust_for_invis_intang)
434 (set_point_both, move_if_not_intangible, get_property_and_range)
435 (get_local_map, copy_intervals, copy_intervals_to_string)
436 (compare_string_intervals, set_intervals_multibyte_1):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 * intervals.h: Adjust decls to match defn changes elsewhere.
439 (struct interval):
440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
441 * keyboard.c (this_command_key_count, this_single_command_key_start)
442 (before_command_key_count, before_command_echo_length, echo_now)
443 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
444 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
445 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
446 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
448 (last_non_minibuf_size, last_point_position, echo_truncate)
449 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
450 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
451 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
452 (stuff_buffered_input):
453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
454 (last_auto_save, command_loop_1, read_char):
455 Use EMACS_INT, not int, to avoid integer overflow.
456 (record_char): Avoid overflow in total_keys computation.
457 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
458 * keyboard.h: Adjust decls to match defn changes elsewhere.
459 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
460 (Fkey_description, Fdescribe_vector, Flookup_key):
461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
462 (click_position): New function, to check that positions are in range.
463 (Fcurrent_active_maps):
464 (describe_command):
465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
466 (Faccessible_keymaps, Fkey_description):
467 (preferred_sequence_p):
468 Don't assume fixnum can fit into int.
469 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
470 Check for integer overflow in size calculations.
471 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
472 avoid mishandling large integers.
473 * lisp.h: Adjust decls to match defn changes elsewhere.
474 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
475 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
476 (struct Lisp_Marker):
477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
478 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
479 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
480 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
481 All callers changed.
482 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
483 Assume the arg has valid form, since it always does.
484 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
485 unsigned integer system type.
486 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
487 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
489 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
490 (duration_to_sec_usec): New decl.
491 * lread.c (read_from_string_index, read_from_string_index_byte)
492 (read_from_string_limit, readchar, unreadchar, openp)
493 (read_internal_start, read1, oblookup):
494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
495 (Fload, readevalloop, Feval_buffer, Feval_region):
496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
497 (openp): Check for out-of-range argument to 'access'.
498 (read1): Use int, not EMACS_INT, where int is wide enough.
499 Don't assume fixnum fits into int.
6efdadfd 500 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
501 (read_filtered_event): Use duration_to_sec_usec
502 to do proper overflow checking on durations.
d311d28c
PE
503 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
504 in size calculation.
505 (Fexecute_kbd_macro):
506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
507 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
508 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
509 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
510 (set_marker_both, set_marker_restricted_both, marker_position)
511 (marker_byte_position, Fbuffer_has_markers_at):
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
514 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
515 It now merely ensures that the menu is large enough, without
516 necessarily growing it, as this avoids some integer overflow issues.
517 All callers changed.
518 (keymap_panes, parse_single_submenu, Fx_popup_menu):
519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
520 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
521 Use SAFE_ALLOCA_LISP, not alloca.
522 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
523 to EMACS_INT. Check that fixnums are in proper range for system types.
524 * minibuf.c (minibuf_prompt_width, string_to_object)
525 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
526 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
528 (get_minibuffer, read_minibuf_unwind):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
531 this simplifies overflow checking. All callers changed.
532 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
533 (Ftest_completion):
534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
535 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
536 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
537 Check that fixnums are in proper range for system types.
538 (Fx_create_frame, Fx_show_tip):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 * nsfont.m (ns_findfonts, nsfont_list_family):
541 Don't assume fixnum fits in long.
542 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
544 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
545 wide enough.
17fdb222 546 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
548 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
549 (PRINTDECLARE, PRINTPREPARE):
550 (strout, print_string):
551 (print, print_preprocess, print_check_string_charset_prop)
552 (print_object):
553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
554 (PRINTDECLARE):
555 (temp_output_buffer_setup, Fprin1_to_string, print_object):
556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
557 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 558 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 559 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
560 (print_error_message): Use SAFE_ALLOCA, not alloca.
561 (print_object): Use int, not EMACS_INT, where int is wide enough.
562 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
563 (Fset_process_window_size, Fformat_network_address)
564 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 565 (sigchld_handler):
d311d28c 566 Check that fixnums are in proper range for system types.
d44287d4 567 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
568 Check for process-ids out of pid_t range rather than relying on
569 undefined behavior.
d311d28c
PE
570 (Fformat_network_address, read_process_output, send_process)
571 (Fprocess_send_region, status_notify):
572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
573 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
574 (wait_reading_process_output, read_process_output, exec_sentinel):
575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
576 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
577 (Faccept_process_output): Use duration_to_sec_usec to do proper
578 overflow checking on durations.
dde14581
PE
579 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
580 Don't assume pid_t fits in int.
b62b53e8
PE
581 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
582 configured --with-wide-int.
d311d28c
PE
583 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
584 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
585 * search.c (looking_at_1, string_match_1):
586 (fast_string_match, fast_c_string_match_ignore_case)
587 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
588 (scan_newline, find_before_next_newline, search_command)
589 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
590 (set_search_regs, wordify):
591 (Freplace_match):
592 (Fmatch_data):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 (string_match_1, search_buffer, set_search_regs):
595 (Fmatch_data):
596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
597 (wordify): Check for overflow in size calculation.
598 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
599 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
600 Check that fixnums are in proper range for system types.
601 * sound.c (struct sound_device)
602 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
604 (Fplay_sound_internal):
605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 606 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
607 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
608 (Fparse_partial_sexp):
609 Don't assume fixnums can fit in int.
610 (struct lisp_parse_state, find_start_pos, find_start_value)
611 (find_start_value_byte, find_start_begv)
612 (update_syntax_table, char_quoted, dec_bytepos)
613 (find_defun_start, prev_char_comend_first, back_comment):
614 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
615 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 (Finternal_describe_syntax_value): Check that match_lisp is a
618 character, not an integer, since the code stuffs it into int.
619 (scan_words, scan_sexps_forward):
620 Check that fixnums are in proper range for system types.
621 (Fforward_word):
622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
623 (scan_sexps_forward):
624 Use CHARACTERP, not INTEGERP, since the value must fit into int.
625 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
626 * syntax.h: Adjust decls to match defn changes elsewhere.
627 (struct gl_state_s):
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
629 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
630 MOST_POSITIVE_FIXNUM.
d311d28c
PE
631 * sysdep.c (wait_for_termination_1, wait_for_termination)
632 (interruptible_wait_for_termination, mkdir):
633 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
634 (emacs_read, emacs_write):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
636 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
637 and double all fit in int.
d311d28c
PE
638 * term.c (set_tty_color_mode):
639 Check that fixnums are in proper range for system types.
640 * termhooks.h (struct input_event):
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
642 * textprop.c (validate_interval_range, interval_of)
643 (Fadd_text_properties, set_text_properties_1)
644 (Fremove_text_properties, Fremove_list_of_text_properties)
645 (Ftext_property_any, Ftext_property_not_all)
646 (copy_text_properties, text_property_list, extend_property_ranges)
647 (verify_interval_modification):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 (Fnext_single_char_property_change)
650 (Fprevious_single_char_property_change):
651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
652 (copy_text_properties):
653 Check for integer overflow in index calculation.
d311d28c
PE
654 * undo.c (last_boundary_position, record_point, record_insert)
655 (record_delete, record_marker_adjustment, record_change)
656 (record_property_change):
657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
658 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
660 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
661 (Fx_hide_tip, Fx_file_dialog):
662 * w32menu.c (set_frame_menubar):
663 Use ptrdiff_t, not int, for consistency with rest of code.
664 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
665 (select_window, Fdelete_other_windows_internal)
666 (window_scroll_pixel_based, window_scroll_line_based)
667 (Frecenter, Fset_window_configuration):
668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
669 (Fset_window_hscroll, run_window_configuration_change_hook)
670 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 671 (Fscroll_other_window, Frecenter):
d311d28c
PE
672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
673 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
674 Don't assume fixnum fits in int.
675 (Fset_window_scroll_bars):
676 Check that fixnums are in proper range for system types.
677 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
678 (string_pos, c_string_pos, number_of_chars, init_iterator)
679 (in_ellipses_for_invisible_text_p, init_from_display_pos)
680 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
681 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
682 (face_before_or_after_it_pos, handle_invisible_prop)
683 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
684 (display_prop_intangible_p, string_buffer_position_lim)
685 (string_buffer_position, handle_composition_prop, load_overlay_strings)
686 (get_overlay_strings_1, get_overlay_strings)
687 (iterate_out_of_display_property, forward_to_next_line_start)
688 (back_to_previous_visible_line_start, reseat, reseat_to_string)
689 (get_next_display_element, set_iterator_to_next)
690 (get_visually_first_element, compute_stop_pos_backwards)
691 (handle_stop_backwards, next_element_from_buffer)
692 (move_it_in_display_line_to, move_it_in_display_line)
693 (move_it_to, move_it_vertically_backward, move_it_by_lines)
694 (add_to_log, message_dolog, message_log_check_duplicate)
695 (message2, message2_nolog, message3, message3_nolog
696 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
697 (current_message_1, truncate_echo_area, truncate_message_1)
698 (set_message, set_message_1, store_mode_line_noprop)
699 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
700 (text_outside_line_unchanged_p, check_point_in_composition)
701 (reconsider_clip_changes)
702 (redisplay_internal, set_cursor_from_row, try_scrolling)
703 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
704 (redisplay_window, find_last_unchanged_at_beg_row)
705 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
706 (trailing_whitespace_p, find_row_edges, display_line)
707 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
708 (display_mode_element, store_mode_line_string)
709 (pint2str, pint2hrstr, decode_mode_spec)
710 (display_count_lines, display_string, draw_glyphs)
711 (x_produce_glyphs, x_insert_glyphs)
712 (rows_from_pos_range, mouse_face_from_buffer_pos)
713 (fast_find_string_pos, mouse_face_from_string_pos)
714 (note_mode_line_or_margin_highlight, note_mouse_highlight):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 (safe_call, init_from_display_pos, handle_fontified_prop)
717 (handle_single_display_spec, load_overlay_strings)
718 (with_echo_area_buffer, setup_echo_area_for_printing)
719 (display_echo_area, echo_area_display)
720 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
721 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
722 (redisplay_window, dump_glyph_row, display_mode_line)
723 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 724 (handle_display_spec, display_prop_string_p):
d311d28c
PE
725 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
726 (handle_single_display_spec, build_desired_tool_bar_string)
727 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
728 (get_specified_cursor_type):
729 Check that fixnums are in proper range for system types.
730 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
731 (Flookup_image_map):
732 Don't assume fixnums fit in int.
733 (compare_overlay_entries):
734 Avoid mishandling comparisons due to subtraction overflow.
735 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
736 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
737 (handle_tool_bar_click):
738 Use int, not unsigned, since we prefer signed and the signedness
739 doesn't matter here.
740 (get_next_display_element, next_element_from_display_vector):
741 Use int, not EMACS_INT, when int is wide enough.
742 (start_hourglass): Use duration_to_sec_usec to do proper
743 overflow checking on durations.
744 * xfaces.c (Fbitmap_spec_p):
745 Check that fixnums are in proper range for system types.
746 (compare_fonts_by_sort_order):
747 Avoid mishandling comparisons due to subtraction overflow.
748 (Fx_family_fonts, realize_basic_faces):
749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
750 (Fx_family_fonts):
751 Don't assume fixnum fits in int.
752 Use SAFE_ALLOCA_LISP, not alloca.
753 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
754 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
755 (face_at_buffer_position, face_for_overlay_string)
756 (face_at_string_position):
757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
758 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
759 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
760 (Fx_show_tip):
761 Check that fixnums are in proper range for system types.
762 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
763 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 (Fx_change_window_property): Don't assume fixnums fit in int.
766 * xfont.c (xfont_chars_supported):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
769 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
771 * xml.c (parse_region):
772 * xrdb.c (magic_file_p):
773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
774 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
775 (x_get_local_selection, x_reply_selection_request)
776 (x_handle_selection_request, wait_for_property_change):
777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
778 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
779 short is wide enough.
780 (x_send_client_event): Don't assume fixnum fits in int.
781 * xterm.c (x_x_to_emacs_modifiers):
782 Don't assume EMACS_INT overflows nicely into int.
783 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
784 may come from Lisp.
785 (handle_one_xevent): NATNUMP can eval its arg twice.
786 (x_connection_closed):
787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
788 * xterm.h: Adjust decls to match defn changes elsewhere.
789 (struct scroll_bar): Use struct vectorlike_header
790 rather than rolling our own approximation.
791 (SCROLL_BAR_VEC_SIZE): Remove; not used.
792
f01769f9
LL
7932012-04-22 Leo Liu <sdl.web@gmail.com>
794
795 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
796
5790543d
PE
7972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
798
799 * sysdep.c [__FreeBSD__]: Minor cleanups.
800 (list_system_processes, system_process_attributes) [__FreeBSD__]:
801 Use Emacs indenting style more consistently. Avoid some casts.
802 Use 'double' consistently rather than mixing 'float' and 'double'.
803
b91b7e4d
EW
8042012-04-21 Eduard Wiebe <usenet@pusto.de>
805
806 * sysdep.c (list_system_processes, system_process_attributes): Add
807 implementation for FreeBSD (Bug#5243).
808
6114eb15
AS
8092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
810
811 * lisp.mk (lisp): Update.
812
2f38dff7
PE
8132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
814
815 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
816 It is never used otherwise.
817
4ae29f89
SM
8182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
819
820 * print.c (print_preprocess): Only check print_depth if print-circle
821 is nil.
822 (print_object): Check for cycles even when print-circle is nil and
823 print-gensym is t, but only check print_depth if print-circle is nil.
824
f30d612a
CY
8252012-04-20 Chong Yidong <cyd@gnu.org>
826
827 * process.c (wait_reading_process_output): If EIO occurs on a pty,
828 set the status to "failed" and ensure that sentinel is run.
829
c07a4c0b 8302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
831
832 * process.c (Fset_process_inherit_coding_system_flag)
833 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 834 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 835
c07a4c0b 8362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
837
838 * xdisp.c (string_buffer_position_lim): Limit starting position to
839 BEGV.
840 (set_cursor_from_row): If called for a mode-line or header-line
841 row, return zero immediately.
842 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
843 farther than the first row after the header line, if any.
844 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
845 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
846
c07a4c0b 8472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 848
4ae29f89
SM
849 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
850 (bug#11238).
ad3a2b41 851
c07a4c0b 8522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 8532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
854
855 configure: new option --enable-gcc-warnings (Bug#11207)
856 * Makefile.in (C_WARNINGS_SWITCH): Remove.
857 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
858 (ALL_CFLAGS): Use new macros rather than old.
859 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
860 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
861 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
862 -Wunused-result, -Wunused-variable. This should go away once
863 the Emacs and Gnulib regex code is merged.
864 (xmalloc, xrealloc): Now static.
865
aba027e8
PE
8662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
867
868 * dired.c (Fsystem_groups): Remove unused local.
869
e5a36063
GM
8702012-04-17 Glenn Morris <rgm@gnu.org>
871
872 * dired.c (Fsystem_users): Doc fix.
873
316411f0
DA
8742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
875
876 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
877 (syms_of_dired): Add them.
878
9426aba4
PE
8792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
880
b62a57be
PE
881 Fix minor alloc.c problems found by static checking.
882 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
883 New extern decls, to avoid calling undeclared functions.
884 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
885 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
886 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
887 (NEED_MEM_INSERT): New macro.
888 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 889 Remove one incorrect comment and fix another.
b62a57be 890
3539f31f
PE
891 Fix minor ralloc.c problems found by static checking.
892 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
893 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
894 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
895 (r_alloc_sbrk): Now static.
896
a041960a
PE
897 Improve ralloc.c interface checking.
898 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
899 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
900 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
901 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
902 [REL_ALLOC]: ... to here, to check interface.
903 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
904 Remove decls. This fixes an "It stinks!".
905
9426aba4
PE
906 * alloc.c (which_symbols): Fix alignment issue / type clash.
907
d55c12ed
AS
9082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
909
910 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
911 (struct Lisp_Misc_Any): Likewise.
912 (struct Lisp_Free): Likewise.
913 * alloc.c (union aligned_Lisp_Symbol): Define.
914 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
915 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
916 (union aligned_Lisp_Misc): Define.
917 (MARKER_BLOCK_SIZE, struct marker_block): Use union
918 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 919 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 920
b948ce8b
PE
9212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
922
923 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
924 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
925 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
926 * s/netbsd.h, s/sol2-6.h:
927 Remove definition of GC_MARK_STACK, since the default now works.
928 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
929 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
930 no longer the default.
931 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
932
35dc09a1 9332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 934
35dc09a1
GM
935 * lread.c (lisp_file_lexically_bound_p):
936 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 937
35dc09a1
GM
9382012-04-14 Eli Zaretskii <eliz@gnu.org>
939
940 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
941 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
942
9432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
944
945 * nsterm.m (constrainFrameRect): Always constrain when there is only
946 one screen (Bug#10962).
947
bcd86815
KB
9482012-04-13 Ken Brown <kbrown@cornell.edu>
949
950 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
951
c25df26e
RT
9522012-04-13 Reuben Thomas <rrt@sc3d.org>
953
954 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
955
0fc59f1e
DC
9562012-04-11 Daniel Colascione <dancol@dancol.org>
957
958 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
959 against is gone. It's better to use vfork now so that when Cygwin
960 gains a new, working vfork, we use it automatically (bug#10398).
961
de8c03dc
SM
9622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
963
964 * window.c (save_window_save): Obey window-point-insertion-type.
965
2f097256
GM
9662012-04-11 Glenn Morris <rgm@gnu.org>
967
968 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
969
453b951e
SM
9702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
971
972 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
973
75f1671a 9742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
975
976 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
977 (force_quit_count): New var.
978 (handle_interrupt): Use it.
979
2a8ce227
JB
9802012-04-10 Juanma Barranquero <lekktu@gmail.com>
981
982 * w32.c (w32_delayed_load): Record the full path of the library
983 being loaded (bug#10424).
984
935396c0
GM
9852012-04-09 Glenn Morris <rgm@gnu.org>
986
05920a43
GM
987 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
988 not just in the obarray, before snarfing them. (Bug#11036)
989
935396c0
GM
990 * Makefile.in ($(leimdir)/leim-list.el):
991 Pass EMACS rather than BUILT_EMACS.
992
a18ecafa
TZ
9932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
994
995 * process.c (make_process):
996 * process.h: Add integer `gnutls_handshakes_tried' member to
997 process struct.
998
6bbef4e5
JC
999 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1000 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1001
1002 * gnutls.c (gnutls_log_function2i): Convenience log function.
1003 (emacs_gnutls_read): Use new log functions,
1004 `gnutls_handshakes_tried' process member, and
1005 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1006 attempts per process (connection).
1007
b4d3bc10
CY
10082012-04-09 Chong Yidong <cyd@gnu.org>
1009
1010 * eval.c (Fuser_variable_p, user_variable_p_eh)
1011 (lisp_indirect_variable): Functions deleted.
1012 (Fdefvar): Caller changed.
1013
1014 * callint.c (Finteractive, Fcall_interactively):
1015 * minibuf.c (Fread_variable): Callers changed.
1016
70f4d973
EZ
10172012-04-09 Eli Zaretskii <eliz@gnu.org>
1018
1019 * xdisp.c (set_cursor_from_row): If the display string appears in
1020 the buffer at position that is closer to point than the position
1021 after the display string, display the cursor on the first glyph of
1022 the display string. Fixes cursor display when a 'display' text
1023 property immediately follows invisible text. (Bug#11094)
1024
cb3c2e3e
PE
10252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 composite.c: use 'double' consistently
1028 * composite.c (get_composition_id): Use 'double' consistently
1029 instead of converting 'float' to 'double' and vice versa; this is
1030 easier to understand and avoids a GCC warning.
1031
fd06db5d
GM
10322012-04-09 Glenn Morris <rgm@gnu.org>
1033
50fe702a
GM
1034 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1035 preparation for dumping it with emacs. (Bug#4789)
1036 (leimdir): New variable.
1037 ($(leimdir)/leim-list.el): New rule.
1038 (emacs$(EXEEXT)): Depend on leim-list.el.
1039
fd06db5d
GM
1040 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1041 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1042 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1043
55c131ee
AS
10442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1045
1046 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1047 proper alignment.
1048
9209588f
JB
10492012-04-07 Juanma Barranquero <lekktu@gmail.com>
1050
1051 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1052 Remove unused local variable.
1053
e3fb2efb
PE
10542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1057 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1058 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1059 objects, as mark_maybe_pointer will catch them otherwise.
1060 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1061 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1062
b5385551
PE
10632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 Fix typo that broke non-Windows builds.
1066 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1067
9078ead6
EZ
10682012-04-07 Eli Zaretskii <eliz@gnu.org>
1069
1070 Support building on MS-Windows with libxml2.
1071
1072 * makefile.w32-in (OBJ2): Add xml.$(O).
1073 (GLOBAL_SOURCES): Add xml.c.
1074 ($(BLD)/xml.$(O)): New dependency list.
1075
1076 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1077 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1078 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1079 [!WINDOWSNT]: New macros.
1080 (init_libxml2_functions, libxml2_loaded_p): New functions.
1081 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1082 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1083 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1084 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1085 linked in).
6bbef4e5
JC
1086 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1087 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1088 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1089
1090 * emacs.c: Don't include libxml/parser.h.
1091 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1092 xmlCleanupParser directly.
1093
1094 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1095
3811fdf3
EZ
10962012-04-07 Eli Zaretskii <eliz@gnu.org>
1097
1098 * indent.c (Fvertical_motion): If there is a display string at
1099 point, use it.vpos to compute how many lines to backtrack after
1100 move_it_to point. (Bug#11133)
1101
2f8e16b2
EZ
11022012-04-06 Eli Zaretskii <eliz@gnu.org>
1103
1104 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1105 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1106 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1107 macros related to unification of CJK characters. For the details,
1108 see the discussion following the message here:
1109 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1110
3d439cd1
CY
11112012-04-04 Chong Yidong <cyd@gnu.org>
1112
1113 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1114
8bc53d00
EZ
11152012-04-01 Eli Zaretskii <eliz@gnu.org>
1116
1117 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1118 instead of alloca. (Bug#11138)
1119
3b0512a3
AS
11202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1121
1122 * w32menu.c (is_simple_dialog): Properly check lisp types.
1123 (Bug#11141)
1124
8427ddd2
EZ
11252012-03-31 Eli Zaretskii <eliz@gnu.org>
1126
979022ef
EZ
1127 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1128 position we get to after a call to move_it_to fails the
1129 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1130 only if we wind up in a string from display property. (Bug#11063)
1131
a6b1c7cc
EZ
1132 * window.c (Fdelete_other_windows_internal): Invalidate the row
1133 and column information about mouse highlight, so that redisplay
1134 restores it after reallocating the glyph matrices. (Bug#7464)
1135
8427ddd2
EZ
1136 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1137 string comes from a `display' text property, use the buffer
1138 position of that property as if we actually saw that position in
1139 the row's glyphs.
697ba24b
EZ
1140 (move_it_by_lines): Remove the assertion that
1141 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1142 violated when there's a before-string at the beginning of a line.
1143 (Bug#11063)
8427ddd2 1144
65a0a738
EZ
11452012-03-30 Eli Zaretskii <eliz@gnu.org>
1146
1147 * xdisp.c (append_space_for_newline): If the default face was
1148 remapped, use the remapped face for the appended newline.
1149 (extend_face_to_end_of_line): Use the remapped default face for
1150 extending the face to the end of the line.
1151 (display_line): Call extend_face_to_end_of_line when the default
1152 face was remapped. (Bug#11068)
1153
581355cc
EZ
11542012-03-29 Eli Zaretskii <eliz@gnu.org>
1155
1156 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1157
e8fc049f
SM
11582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1159
1160 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1161
4fb9a543
GM
11622012-03-27 Glenn Morris <rgm@gnu.org>
1163
1164 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1165 Doc fixes.
1166
679910f1
KH
11672012-03-26 Kenichi Handa <handa@m17n.org>
1168
1169 * dispextern.h (struct glyph): Fix previous change. Change the
1170 bit length of glyphless.ch to 25 (Bug#11082).
1171
90d49b7f
CY
11722012-03-26 Chong Yidong <cyd@gnu.org>
1173
1174 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1175 (command_loop_1): Use it; inhibit selection update for
1176 handle-select-window too (Bug#8996).
1177
f514f6f0
FP
11782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1179
e8fc049f 1180 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1181
bf43fa51
KH
11822012-03-25 Kenichi Handa <handa@m17n.org>
1183
1184 * dispextern.h (struct glyph): Change the bit length of
1185 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1186
8a0c01dd
EZ
11872012-03-24 Eli Zaretskii <eliz@gnu.org>
1188
1189 * s/ms-w32.h (tzname): Include time.h before redirecting to
1190 _tzname. Fixes the MSVC build. (Bug#9960)
1191
7d1c3a76
AS
11922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1193
8ed79523
AS
1194 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1195 characters.
1196
7d1c3a76
AS
1197 * xterm.c (XTread_socket): Only modify handling_signal if
1198 !SYNC_INPUT. (Bug#11080)
1199
e99a9b8b
EZ
12002012-03-23 Eli Zaretskii <eliz@gnu.org>
1201
1202 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1203 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1204 when fetching a multibyte character consumes more bytes than
1205 CHAR_BYTES returns, due to unification of CJK characters in
1206 string_char. (Bug#11073)
1207
5063c0e1
TN
12082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1209
1210 * process.c (wait_reading_process_output): Handle pty disconnect
1211 by refraining from sending oneself a SIGCHLD (bug#10933).
1212
9f851fbd
CY
12132012-03-22 Chong Yidong <cyd@gnu.org>
1214
1215 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1216
5063c0e1 1217 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1218 Mark string as coming from a prefix property.
1219 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1220 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1221
fb5b8aca
CY
12222012-03-21 Chong Yidong <cyd@gnu.org>
1223
1224 * xfaces.c (Vface_remapping_alist): Doc fix.
1225
62356a1b
EZ
12262012-03-20 Eli Zaretskii <eliz@gnu.org>
1227
1228 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
1229 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1230 Doc fixes.
62356a1b 1231
025de85b
CY
12322012-03-20 Chong Yidong <cyd@gnu.org>
1233
1234 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1235 to reflect default non-nil value of redisplay-dont-pause.
1236
4827f94e
KH
12372012-03-19 Kenichi Handa <handa@m17n.org>
1238
1239 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1240 it fit in a valid range (Bug#11003).
1241
e50a24a2
EZ
12422012-03-18 Eli Zaretskii <eliz@gnu.org>
1243
1244 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1245 that is not from display property, accept the row as a "cursor
1246 row" if one of the string's character has a non-nil `cursor'
1247 property. Fixes cursor positioning when there are newlines in
1248 overlay strings, e.g. in icomplete.el. (Bug#11035)
1249
9af5ed87
PE
12502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1253
d1f55f16
CY
12542012-03-12 Chong Yidong <cyd@gnu.org>
1255
1256 * eval.c (inhibit_lisp_code): Rename from
1257 inhibit_window_configuration_change_hook; move from window.c.
1258
1259 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1260 * window.c (run_window_configuration_change_hook)
1261 (syms_of_window): Callers changed.
1262
66c5eebd
CY
12632012-03-11 Chong Yidong <cyd@gnu.org>
1264
413df973
CY
1265 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1266
66c5eebd
CY
1267 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1268
1de11f56
CY
12692012-03-10 Chong Yidong <cyd@gnu.org>
1270
1271 * frame.c (other_visible_frames): Don't assume the selected frame
1272 is visible (Bug#10955).
1273
cae07000
SM
12742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1275
1276 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1277
89c94350
JD
12782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1279
1280 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1281 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1282 zero (Bug#10954).
1283
999dd333
GM
12842012-03-03 Glenn Morris <rgm@gnu.org>
1285
01a6dcc8 1286 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1287
de0100f2
EZ
12882012-03-02 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1291 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1292 (redisplay_window, next_element_from_string): Fix typos in
1293 comments.
3e441275
EZ
1294 (redisplay_window): Pass to move_it_vertically the margin in
1295 pixels, not in screen lines.
de0100f2 1296
96a72ee9
GM
12972012-03-02 Glenn Morris <rgm@gnu.org>
1298
1299 * buffer.c (buffer-list-update-hook): Doc fix.
1300
312508d7
EZ
13012012-02-29 Eli Zaretskii <eliz@gnu.org>
1302
1303 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1304 push_it before setting up the iterator for the first overlay
1305 string, even if we have an empty string loaded.
1306 (next_overlay_string): If there's an empty string on the iterator
1307 stack, pop the stack. (Bug#10903)
1308
27f3c637
PE
13092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1310
1311 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1312 Suggested by Stefan Monnier in
1313 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1314 * alloc.c (widen_to_Lisp_Object): New static function.
1315 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1316 and widening them to Lisp_Objects. This would work even if
1317 USE_LSB_TAG is defined and wide integers are used, which might
1318 happen in a future version of Emacs.
1319
3c9dfce6
CY
13202012-02-25 Chong Yidong <cyd@gnu.org>
1321
fa74b241
CY
1322 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1323 Doc fix.
1324
3c9dfce6
CY
1325 * xselect.c (Fx_selection_exists_p): Doc fix.
1326 (x_clipboard_manager_save_all): Print an informative message
1327 before saving to clipboard manager.
1328
9486df08
CY
13292012-02-24 Chong Yidong <cyd@gnu.org>
1330
1331 * keyboard.c (process_special_events): Handle all X selection
1332 requests in kbd_buffer, not just the next one (Bug#8869).
1333
f01d3321
CY
13342012-02-23 Chong Yidong <cyd@gnu.org>
1335
1336 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1337 call when setting menu-bar-lines and tool-bar-lines parameters.
1338 (unwind_create_frame_1): New helper function.
1339
1340 * window.c (inhibit_window_configuration_change_hook): New var.
1341 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1342 (syms_of_window): Initialize it.
f01d3321 1343
86b847b6
CY
13442012-02-22 Chong Yidong <cyd@gnu.org>
1345
1346 * xterm.c (x_draw_image_relief): Add missing type check for
1347 Vtool_bar_button_margin (Bug#10743).
1348
a59225b1
CY
13492012-02-21 Chong Yidong <cyd@gnu.org>
1350
1351 * fileio.c (Vfile_name_handler_alist): Doc fix.
1352
1353 * buffer.c (Fget_file_buffer): Protect against invalid file
1354 handler return value.
1355
310f5bd4
PE
13562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1357
cb3a28cc
PE
1358 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1359 when computing $valmask.
1360
310f5bd4
PE
1361 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1362 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1363 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1364 It's useless in that case, and it can cause problems on hosts
1365 that allocate halves of EMACS_INT values separately.
1366 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1367 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1368 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1369 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1370 it avoids undefined behavior on hosts where shifting right by more
1371 than the word width has undefined behavior.
1372
2375c96a
CY
13732012-02-19 Chong Yidong <cyd@gnu.org>
1374
1375 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1376 (Funhandled_file_name_directory, Ffile_name_as_directory)
1377 (Fdirectory_file_name, Fexpand_file_name)
1378 (Fsubstitute_in_file_name): Protect against invalid file handler
1379 return values (Bug#10845).
1380
3eb49e71
EZ
13812012-02-18 Eli Zaretskii <eliz@gnu.org>
1382
1383 * .gdbinit (pitx): Fix incorrect references to fields of the
1384 iterator stack.
1385
7b926f3f
CY
13862012-02-17 Chong Yidong <cyd@gnu.org>
1387
1388 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1389
11273115
PE
13902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1391
1392 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1393 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1394
c3a70e2b
CY
13952012-02-15 Chong Yidong <cyd@gnu.org>
1396
1397 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1398 marked as special. Also, starting docstrings with * is obsolete.
1399
0ca43699
AS
14002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1401
1402 * gnutls.c (emacs_gnutls_write): Fix last change.
1403
2e8f3c56
LI
14042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1405
1406 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1407 send_process.
1408
af70074f
SM
14092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1410
1411 * keymap.c (Fsingle_key_description): Handle char ranges.
1412
95986d52
CY
14132012-02-12 Chong Yidong <cyd@gnu.org>
1414
afd83bd1
CY
1415 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1416 as that creates a dangerous corner case.
1417
95986d52
CY
1418 * window.c (Fdelete_window_internal): Invalidate the mouse
1419 highlight (Bug#9904).
1420
bd7da63e
GM
14212012-02-12 Glenn Morris <rgm@gnu.org>
1422
1423 * xselect.c (Fx_own_selection_internal)
1424 (Fx_get_selection_internal, Fx_disown_selection_internal)
1425 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1426 * nsselect.m (Fx_own_selection_internal)
1427 (Fx_disown_selection_internal, Fx_selection_exists_p)
1428 (Fx_selection_owner_p, Fx_get_selection_internal):
1429 Sync docs and argument specs with the xselect.c versions.
1430
77abcbc2
LI
14312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1432
1433 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1434
90b671e2
EZ
14352012-02-11 Eli Zaretskii <eliz@gnu.org>
1436
1c0ca0b7
EZ
1437 * w32select.c (Fx_selection_exists_p): Sync doc string and
1438 argument list with xselect.c. (Bug#10783)
1439
1440 * w16select.c (Fx_selection_exists_p): Sync doc string and
1441 argument list with xselect.c. (Bug#10783)
90b671e2 1442
49241268
GM
14432012-02-10 Glenn Morris <rgm@gnu.org>
1444
1445 * fns.c (Fsecure_hash): Doc fix.
1446
f998bbe7 14472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1448
1449 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1450
0992bd9c
CY
14512012-02-07 Chong Yidong <cyd@gnu.org>
1452
1453 * buffer.c (Fbuffer_local_variables)
1454 (buffer_lisp_local_variables): Handle unbound vars correctly;
1455 don't let Qunbound leak into Lisp.
1456
af008560
GM
14572012-02-07 Glenn Morris <rgm@gnu.org>
1458
dd605cc4
GM
1459 * image.c (Fimagemagick_types): Doc fix.
1460
af008560
GM
1461 * image.c (imagemagick-render-type): Change it from a lisp object
1462 to an integer. Move the doc here from the lisp manual.
1463 Treat all values not equal to 0 the same.
1464
1449fa1d
CY
14652012-02-06 Chong Yidong <cyd@gnu.org>
1466
1467 * doc.c (store_function_docstring): Avoid applying docstring of
1468 alias to base function (Bug#2603).
1469
3723ec07
AS
14702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1471
1472 * .gdbinit (pp1, pv1): Remove redundant defines.
1473 (pr): Use pp.
1474
79c1cc1e
CY
14752012-02-04 Chong Yidong <cyd@gnu.org>
1476
1477 * nsterm.m: Declare a global (Bug#10694).
1478
d7f29f8e
EZ
14792012-02-04 Eli Zaretskii <eliz@gnu.org>
1480
cae07000
SM
1481 * w32.c (get_emacs_configuration_options):
1482 Include --enable-checking, if specified, in the return value.
d7f29f8e 1483
3b95a6f9
MR
14842012-02-04 Martin Rudalics <rudalics@gmx.at>
1485
1486 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1487 after rounding frame sizes. (Bug#9723)
1488
d6fa96a6
EZ
14892012-02-04 Eli Zaretskii <eliz@gnu.org>
1490
1491 * keyboard.c (adjust_point_for_property): Don't position point
1492 before BEGV. (Bug#10696)
1493
df0b2940
PE
14942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1495
1496 Handle overflow when computing char display width (Bug#9496).
1497 * character.c (char_width): Return EMACS_INT, not int.
1498 (char_width, c_string_width): Check for overflow when
1499 computing the width; this is possible now that individual
1500 characters can have unbounded width. Problem introduced
1501 by merge from Emacs 23 on 2012-01-19.
1502
6bee44d6
MA
15032012-02-02 Michael Albinus <michael.albinus@gmx.de>
1504
1505 * dbusbind.c (Fdbus_register_method): Mention the return value
1506 :ignore in the docstring.
1507
44f92739
GM
15082012-02-02 Glenn Morris <rgm@gnu.org>
1509
1b9f60cc
GM
1510 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1511
44f92739
GM
1512 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1513 Unconditionally set to t. (Bug#10673)
1514 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1515 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1516 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1517
c5d3843c
KH
15182012-02-02 Kenichi Handa <handa@m17n.org>
1519
1520 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1521 0, do not call append_composite_glyph.
1522
159462d4 15232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1524
1525 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1526 NULL (Bug#6988).
1527 (x_produce_glyphs): If the component of a composition is a null
1528 string, set it->pixel_width to 1 to avoid zero-width glyph.
1529
78cef877
EZ
15302012-02-01 Eli Zaretskii <eliz@gnu.org>
1531
1532 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1533 first 2 arguments are identical. This makes inserting large
1534 output from a subprocess an order of magnitude faster on
1535 MS-Windows, where all sbrk'ed memory is always contiguous.
1536
97897668
GM
15372012-01-31 Glenn Morris <rgm@gnu.org>
1538
1539 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1540 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1541 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1542
31fd3586
GM
15432012-01-29 Glenn Morris <rgm@gnu.org>
1544
1545 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1546
0e24a8b2
CY
15472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1548
1549 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1550
cc0adcb0
CY
15512012-01-28 Chong Yidong <cyd@gnu.org>
1552
1553 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1554
acc28cb9
CY
15552012-01-26 Chong Yidong <cyd@gnu.org>
1556
9c69cfb7
CY
1557 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1558
acc28cb9
CY
1559 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1560 repeat counts (Bug#10507).
1561
48da7392
GM
15622012-01-26 Glenn Morris <rgm@gnu.org>
1563
1564 * lread.c (syms_of_lread): Doc fix.
1565
14af5f7f
CY
15662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1567
1568 * coding.c (encode_designation_at_bol): Change return value to
1569 EMACS_INT.
1570
0b21c100
CY
15712012-01-25 Chong Yidong <cyd@gnu.org>
1572
1573 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1574
3c2907f7
CY
15752012-01-21 Chong Yidong <cyd@gnu.org>
1576
1577 * floatfns.c (Fcopysign): Make the second argument non-optional,
1578 since nil is not allowed anyway.
1579
959ad23f
AS
15802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1581
1582 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1583 (send_process): Likewise.
1584
34a02f46
MR
15852012-01-19 Martin Rudalics <rudalics@gmx.at>
1586
1587 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1588 (Vwindow_persistent_parameters): Do not use Qstate.
1589 Rewrite doc-strings.
34a02f46 1590
1259009a 15912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1592
1593 * character.c (char_width): New function.
70d4fdf6
GM
1594 (Fchar_width, c_string_width, lisp_string_width):
1595 Use char_width (Bug#9496).
25ed9e61 1596
6a6ee00d
MR
15972012-01-16 Martin Rudalics <rudalics@gmx.at>
1598
1599 * window.c (Vwindow_persistent_parameters): New variable.
1600 (Fset_window_configuration, save_window_save): Handle persistent
1601 window parameters.
1602
c85efaf7
EZ
16032012-01-14 Eli Zaretskii <eliz@gnu.org>
1604
1605 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1606 thrashing the stack of the thread. (Bug#9087)
1607
5944709e
PE
16082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1609
1610 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1611
e71f5d99
EZ
16122012-01-11 Eli Zaretskii <eliz@gnu.org>
1613
1614 * xdisp.c (rows_from_pos_range): Handle the case where the
1615 highlight ends on a newline. (Bug#10464)
1616 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1617 he end column for display of highlight that ends on a newline
1618 before a R2L line.
1619
ce316182
GM
16202012-01-11 Glenn Morris <rgm@gnu.org>
1621
1622 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1623 from load-path also when installation-directory is nil. (Bug#10208)
1624
5b43da69
GM
16252012-01-10 Glenn Morris <rgm@gnu.org>
1626
74cc8ff9
GM
1627 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1628
7d8d6e4e
GM
1629 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1630 Update template values to be closer to their typical values these days.
5b43da69 1631
a0db8d43
EZ
16322012-01-09 Eli Zaretskii <eliz@gnu.org>
1633
1634 * xdisp.c (rows_from_pos_range): Accept additional argument
1635 DISP_STRING, and accept any glyph in a row whose object is that
1636 string as eligible for mouse highlight. Fixes mouse highlight of
1637 display strings from overlays. (Bug#10464)
1638
9a0115ab 16392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1640
b9110d6a 1641 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1642 * fileio.c (auto_saving_dir_umask): New static var.
1643 (Fmake_directory_internal): Use it.
1644 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1645 creating the directory. The old code temporarily assigns
1646 too-generous permissions to the directory.
1647 (do_auto_save_eh): Clear it.
b9110d6a 1648 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1649 that the var is always cleared.
1650
6c1bd3f3
EZ
16512012-01-07 Eli Zaretskii <eliz@gnu.org>
1652
1653 * search.c (scan_buffer): Pass character positions to
1654 know_region_cache, not byte positions. (Bug#6540)
1655
069d2b50
L
16562012-01-07 LynX <_LynX@bk.ru> (tiny change)
1657
1658 * w32.c (sys_rename): Report EXDEV when rename of a directory
1659 fails because the target is on another logical disk. (Bug#10284)
1660
75bf0d33
DB
16612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1662
1663 * xterm.c (x_embed_request_focus): New function.
1664
1665 * xterm.h: Add prototype.
1666
1667 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1668
1c6e5a32
GM
16692012-01-05 Glenn Morris <rgm@gnu.org>
1670
1671 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1672
651e947e
EZ
16732012-01-01 Eli Zaretskii <eliz@gnu.org>
1674
1675 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1676 Load gnutls_transport_set_lowat only if GnuTLS version is below
1677 2.11.1.
1678 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1679 GnuTLS versions below 2.11.1.
1680
3778cdd8
AL
16812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1682
1683 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1684 to the doc string advising against its use for altering the way
1685 windows are scrolled.
1686
0e5317f7
KH
16872011-12-28 Kenichi Handa <handa@m17n.org>
1688
1689 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1690 coding-system ASCII compatible only when it does not produce BOM
1691 on encoding (Bug#10383).
1692
93d5ca1f
JD
16932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1694
1695 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1696 can scroll.
1697 (create_and_show_popup_menu): Always use menu_position_func for
1698 Gtk3 (Bug#10361).
1699
ca22b785
AS
17002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1701
1702 * callint.c (Fcall_interactively): Don't truncate prompt string.
1703
d048e1e6
EZ
17042011-12-23 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1707 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1708 resumed from there (after widening). (Bug#10360)
d048e1e6 1709
5ccaba1f
JD
17102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1711
1712 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1713
204ee57f
JD
17142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1715
b81d40f0
JB
1716 * nsterm.m (x_free_frame_resources):
1717 Release f->output_data.ns->miniimage.
204ee57f
JD
1718 (ns_index_color): Fix indentation. Do not retain
1719 color_table->colors[i].
1720
1721 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1722 before returning.
1723
1724 * nsfns.m (x_set_background_color): Assign return value from
1725 ns_index_color to face-background instead of NSColor*.
1726 (ns_implicitly_set_icon_type): Fix indentation.
1727 Change assignment in for loop to comparison.
1728
1729 * emacs.c (ns_pool): New variable.
1730 (main): Assign ns_pool.
1731 (Fkill_emacs): Call ns_release_autorelease_pool.
1732
1733 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1734 autorelease fdesc, release fdAttrs and tdict.
1735 (ns_get_covering_families): Release charset.
1736 (ns_findfonts): Release NSFontDescriptor created with new.
1737 (ns_uni_to_glyphs): Fix indentation.
1738 (setString): Release attrStr before assigning new value.
1739
c803b2b7
JD
17402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1741
678f4426
JD
1742 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1743 and NS_IMPL_COCOA.
1744 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1745 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1746
cd394be1 17472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1748
5fecd5fc
JD
1749 * nsterm.m (ns_term_init): Subscribe for notifications
1750 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1751 to method trackingNotification in EmacsMenu.
1752
1753 * nsmenu.m (trackingMenu): New variable.
3771cb17 1754 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1755 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1756 from Aquamacs (Bug#7030).
678f4426
JD
1757
17582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1759
c803b2b7
JD
1760 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1761 (symbol_to_nsstring): Fix indentation.
1762 (ns_symbol_to_pb): New function.
cae07000
SM
1763 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1764 (Fns_rotate_cut_buffers_internal): Remove.
1765 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1766 Fns_store_cut_buffer_internal.
1767 (ns_get_foreign_selection, Fx_own_selection_internal)
1768 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1769 (Fns_get_selection_internal, Fns_store_selection_internal):
1770 Use ns_symbol_to_pb and check if return value is nil.
1771 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1772 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1773 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1774 renamed to Sns_store_selection_internal.
1775 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1776 and remove this function.
1777 (ns_handle_selection_clear): Remove, never used.
1778 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1779 here.
1780
e1b01a3a
KB
17812011-12-17 Ken Brown <kbrown@cornell.edu>
1782
1783 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1784 GID is unknown (Bug#10257).
1785
2adb6e85
PE
17862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1789 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1790 which caused a build failure on GNU/Linux IA-64. This problem was
1791 introduced by my 2011-10-07 patch.
1792
d1d7b339
JL
17932011-12-15 Juri Linkov <juri@jurta.org>
1794
1795 * image.c (imagemagick_error): New function. (Bug#10112)
1796 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1797 Use `imagemagick_error' where ImageMagick functions return
1798 `MagickFalse'.
1799 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1800 proper order.
1801
100d5755
KH
18022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1803
1804 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1805 fill background (Bug#8992).
1806
454592a6
MR
18072011-12-13 Martin Rudalics <rudalics@gmx.at>
1808
1809 * window.c (Vwindow_combination_resize)
1810 (Vwindow_combination_limit): Use t instead of non-nil in
1811 doc-strings.
61d4b438
MR
1812 (Vrecenter_redisplay): Add first sentence of doc-string on
1813 separate line.
53524d93 1814 (Frecenter): Fix doc-string typo.
454592a6 1815
3633e3aa
KH
18162011-12-11 Kenichi Handa <handa@m17n.org>
1817
1818 * coding.c (Funencodable_char_position): Pay attention to the
1819 buffer text relocation (Bug#9389).
1820
7b9d523a 18212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 1822
7b9d523a
JD
1823 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1824 gtk_init (Bug#10100).
1825
b73189c6
EZ
18262011-12-10 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1829 IT->string is nil. (Bug#10263)
1830
f7dfe5d6
JD
18312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1832
83faebb4
JD
1833 * nsterm.h (x_free_frame_resources): Declare.
1834
f7dfe5d6
JD
1835 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1836 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1837
1838 * nsterm.h (ns_get_defaults_value): Declare.
1839
1840 * nsterm.m (ns_default): Call ns_get_defaults_value.
1841
7cd4e72c
EZ
18422011-12-09 Eli Zaretskii <eliz@gnu.org>
1843
1844 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1845 (Bug#10170)
1846
b34d7317
YM
18472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1848
1849 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1850 that where the value of an _OBJC_* symbol points to is in the .bss
1851 section (Bug#10240).
1852
76470ad1
KH
18532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1854
1855 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1856 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1857
745fff94
KH
18582011-12-08 Kenichi Handa <handa@m17n.org>
1859
1860 * ftfont.c (get_adstyle_property): Fix previous change
1861 (Bug#10233).
1862
6e44397c
JB
18632011-12-07 Juanma Barranquero <lekktu@gmail.com>
1864
1865 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1866 dirs from the default value of EMACSLOADPATH (bug#10208).
1867
7efa6272
GM
18682011-12-07 Glenn Morris <rgm@gnu.org>
1869
1870 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1871 installation and source directories as well. (Bug#10208)
1872
f6fc4d87
CY
18732011-12-06 Chong Yidong <cyd@gnu.org>
1874
1875 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1876
2bf26180
GM
18772011-12-06 Glenn Morris <rgm@gnu.org>
1878
1879 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1880 as an error, not just -1. (Bug#10217)
1881
3a6ad4f0
CY
18822011-12-05 Chong Yidong <cyd@gnu.org>
1883
1884 * keyboard.c (process_special_events): New function.
1885 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1886
75a3b399
PE
18872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1888
1889 * coding.c (encode_designation_at_bol): Don't use uninitialized
1890 local variable (Bug#9318).
1891
c3c9e25e
KH
18922011-12-05 Kenichi Handa <handa@m17n.org>
1893
1894 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1895 return Qnil (Bug#8046, Bug#10193).
1896
5eb05ea3
KH
18972011-12-05 Kenichi Handa <handa@m17n.org>
1898
1899 * coding.c (encode_designation_at_bol): New args charbuf_end and
1900 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1901 (coding_set_source): Return how many bytes coding->source was
1902 relocated.
1903 (coding_set_destination): Return how many bytes
1904 coding->destination was relocated.
1905 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1906 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1907
19082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1909
1910 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1911 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1912 macro (Bug#9318).
1913
19142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1915
1916 The following changes are to fix Bug#9318.
1917
a79703f5 1918 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1919 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1920 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1921 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1922
7dbda6df
JB
19232011-12-05 Juanma Barranquero <lekktu@gmail.com>
1924
1925 * lisp.h (process_quit_flag): Fix external declaration.
1926
6d5eb5b0
SM
19272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1928
1929 Don't macro-inline non-performance-critical code.
1930 * eval.c (process_quit_flag): New function.
1931 * lisp.h (QUIT): Use it.
1932
a0c3fad0
JD
19332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1934
1935 * nsfns.m (get_geometry_from_preferences): New function.
1936 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1937
6c07aac2
AS
19382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1939
1940 * emacs.c (Qkill_emacs): Define.
1941 (syms_of_emacs): Initialize it.
1942 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1943 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1944 (quit_throw_to_read_char): Add parameter `from_signal'.
1945 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1946 * lisp.h (QUIT): Call Fkill_emacs if requested.
1947
c052ead4
JD
19482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1949
1950 * widget.c (update_wm_hints): Return if wmshell is null.
1951 (widget_update_wm_size_hints): New function.
1952
1953 * widget.h (widget_update_wm_size_hints): Declare.
1954
1955 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1956 widget_update_wm_size_hints (Bug#10104).
1957
9e49252b
EZ
19582011-12-03 Eli Zaretskii <eliz@gnu.org>
1959
1960 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1961 before a newline, prepare the bidi iterator for consuming the
1962 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1963 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1964
02b16839
JL
19652011-12-02 Juri Linkov <juri@jurta.org>
1966
1967 * search.c (Fword_search_regexp): New Lisp function created from
1968 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1969 (Fword_search_backward, Fword_search_forward)
1970 (Fword_search_backward_lax, Fword_search_forward_lax):
1971 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1972 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1973
0068070e
SM
19742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1975
1976 * fileio.c (Finsert_file_contents): Move after-change-function call
1977 to before the "handled:" label, since all "goto handled" appear in
1978 cases where the *-change-functions have already been properly called
1979 (bug#10117).
1980
3360a3fc
AS
19812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1982
1983 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1984 waiting for input. (Bug#10169)
1985
73d6c093
EZ
19862011-11-30 Eli Zaretskii <eliz@gnu.org>
1987
1988 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1989 verifies glyph row's hash code--we have just reallocated the
1990 glyphs, so their contents can be complete garbage. (Bug#10164)
1991
febe6bea
JB
19922011-11-30 Juanma Barranquero <lekktu@gmail.com>
1993
1994 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1995
801a4313
EZ
19962011-11-30 Eli Zaretskii <eliz@gnu.org>
1997
1998 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1999 attributes are tested _before_ calling verify_row_hash, to protect
2000 against GCC re-ordering of the tests. (Bug#10164)
2001
2b56b87e
JD
20022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2003
2004 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2005
2006 * xterm.c (handle_one_xevent): Only set async_visible and friends
2007 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2008 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2009 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2010
dbf31225
PE
20112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2014 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2015 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2016 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2017 All uses changed to use GCPRO1 etc.
2018 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2019 Revert to old implementation (i.e., before 2011-03-11).
2020
1305621b
YM
20212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2022
2023 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2024 of scroll runs so as to avoid assigning disabled bogus rows and
2025 unnecessary graphics copy operations.
2026
8c9afb46
EZ
20272011-11-27 Eli Zaretskii <eliz@gnu.org>
2028
2029 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2030 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2031 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2032 (malloc, free, realloc, calloc): Redirect to e_* only when
2033 compiling Emacs.
2034
2035 * lisp.h (GCTYPEBITS): Move before first use.
2036 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2037 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2038 this macro definition.
2039
2040 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2041 _MSC_VER.
2042
54e9e3bf
JD
20432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2044
6d5eb5b0
SM
2045 * gtkutil.c (xg_create_frame_widgets):
2046 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2047 present with Gtk+ 2.0.
2048
83aca1cb
PE
20492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2050
2051 * fileio.c (Finsert_file_contents): Undo previous change; see
2052 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2053
5b76caa4
PE
20542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Rename locals to avoid shadowing.
2057 * fileio.c (Finsert_file_contents):
2058 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2059 * process.c (wait_reading_process_output):
2060 Rename inner 'proc' to 'p' to avoid shadowing.
2061 Indent for consistency with usual Emacs style.
2062
8c535114
EZ
20632011-11-25 Eli Zaretskii <eliz@gnu.org>
2064
2065 * xdisp.c (redisplay_window): If cursor row is not fully visible
2066 after recentering, and scroll-conservatively is set to a large
2067 number, scroll window by a few more lines to make the cursor fully
2068 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2069 (start_display): Don't move to the next line if the display should
2070 start at a newline that is part of a display vector or an overlay
2071 string. (Bug#10119)
8c535114 2072
fa4fdb5c
JL
20732011-11-24 Juri Linkov <juri@jurta.org>
2074
2075 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2076 after the `MagickPingImage' call. (Bug#10112)
2077
90ec88df
CY
20782011-11-23 Chong Yidong <cyd@gnu.org>
2079
2080 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2081
56e2e794
MR
20822011-11-23 Martin Rudalics <rudalics@gmx.at>
2083
2084 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2085 making another buffer current. (Bug#10114)
2086
b6e64c41
GM
20872011-11-23 Glenn Morris <rgm@gnu.org>
2088
2089 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2090
6b21de18
CY
20912011-11-23 Chong Yidong <cyd@gnu.org>
2092
2093 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2094 using it (Bug#5984).
2095
b12cd789
EZ
20962011-11-22 Eli Zaretskii <eliz@gnu.org>
2097
2098 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2099 and header-lines, as they don't have one computed for them.
2100 (Bug#10098)
2101
2102 * .gdbinit (prow): Make displayed values more self-explaining.
2103 Add row's hash code.
2104
261b6fd4
LMI
21052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2106
2107 * process.c (wait_reading_process_output): Fix asynchrounous
2108 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2109 (wait_reading_process_output): Add comment and URL.
261b6fd4 2110
e7cfd277
JD
21112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2112
2113 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2114
a9b9b7f5
CY
21152011-11-21 Chong Yidong <cyd@gnu.org>
2116
2117 * window.c (Fnext_window, Fprevious_window): Doc fix.
2118
b0d15b4f
SM
21192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2120
2121 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2122
fe7a3057
JB
21232011-11-20 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2126
d2999b1a
MR
21272011-11-20 Martin Rudalics <rudalics@gmx.at>
2128
2129 * window.c (Fset_window_combination_limit): Rename argument
2130 STATUS to LIMIT.
2131 (Vwindow_combination_limit): Remove "status" from doc-string.
2132
d5ff9cd0
AS
21332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2134
2135 * m/ibms390.h: Remove.
2136 * m/ibms390x.h: Don't include "ibms390.h".
2137
a5bb9bd3
SM
21382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2139
2140 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2141 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2142
cd1181db
JB
21432011-11-20 Juanma Barranquero <lekktu@gmail.com>
2144
2145 * casetab.c (Fset_case_table):
2146 * charset.c (Fcharset_after): Fix typos.
2147
615a3b8d 21482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2149
17e845af
PE
2150 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2151 Otherwise, valgrind does not work on some platforms.
2152 Problem reported by Andreas Schwab in
6a0bf43d
PE
2153 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2154 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2155 is set, removing the need for VIRT_ADDRESS_VARIES.
2156 (PURE_P): Use a more-efficient implementation that needs just one
2157 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2158 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2159 to 4 (xorl, subq, cmpq, setbe).
2160 * alloc.c (pure): Always extern now, since that's the
2161 VIRT_ADDR_VARIES behavior.
2162 (PURE_POINTER_P): Use a single comparison, not two, for
2163 consistency with the new puresize.h.
2164 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2165 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2166 Remove VIRT_ADDR_VARIES no longer needed.
2167
f8fe6f96
EZ
21682011-11-19 Eli Zaretskii <eliz@gnu.org>
2169
2170 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2171 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2172 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2173 behave as if the cursor position were at the window margin.
2174
2175 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2176 and the cursor position is out of bounds, behave as if the cursor
2177 position were at the window margin. (Bug#10075)
2178
df05a53c
CY
21792011-11-18 Chong Yidong <cyd@gnu.org>
2180
2181 * window.c (Fwindow_combination_limit): Make first argument
2182 non-optional, since it is meaningless for live windows like the
2183 selected window.
61ccba97 2184
2071918e
DA
21852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2186
2187 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2188
b50a28de
SM
21892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2190
2191 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2192 (graft_intervals_into_buffer): Simplify.
2193
015137db
EZ
21942011-11-18 Eli Zaretskii <eliz@gnu.org>
2195
2196 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2197 hash values of the two rows.
2198 (copy_row_except_pointers): Preserve the used[] arrays and the
2199 hash values of the two rows. (Bug#10035)
68c95424 2200 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2201
2202 * xdisp.c (row_hash): New function, body extracted from
2203 compute_line_metrics.
2204 (compute_line_metrics): Call row_hash, instead of computing the
2205 hash code inline.
2206
2207 * dispnew.c (verify_row_hash): Call row_hash for computing the
2208 hash code of a row, instead of duplicating code from xdisp.c.
2209
2210 * dispextern.h (row_hash): Add prototype.
2211
a2addb04
TH
22122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2213
2214 * frame.c (delete_frame): Don't delete the terminal when the last
2215 X frame is closed if emacs is built with GTK toolkit.
2216
df85d315
JB
22172011-11-17 Juanma Barranquero <lekktu@gmail.com>
2218
2219 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2220
a0c2d0ae
MR
22212011-11-17 Martin Rudalics <rudalics@gmx.at>
2222
2223 * window.c (Vwindow_splits): Rename to
2224 Vwindow_combination_resize. Suggested by Juri Linkov.
2225 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2226 of Vwindow_splits.
2227
58179cce
JB
22282011-11-16 Juanma Barranquero <lekktu@gmail.com>
2229
7877f373
JB
2230 * nsfns.m (Fns_font_name):
2231 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 2232
b6f67890
MR
22332011-11-16 Martin Rudalics <rudalics@gmx.at>
2234
2235 * window.h (window): Rename slot "nest" to "combination_limit".
2236 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2237 (Fset_window_nest): Rename to Fset_window_combination_limit.
2238 (Vwindow_nest): Rename to Vwindow_combination_limit.
2239 (recombine_windows, make_parent_window, make_window)
2240 (Fsplit_window_internal, saved_window)
2241 (Fset_window_configuration, save_window_save): Rename all
2242 occurrences of window_nest to window_combination_limit.
2243
c7015153
JB
22442011-11-15 Juanma Barranquero <lekktu@gmail.com>
2245
2246 * image.c (imagemagick_load_image): Fix typo.
2247
322ad6ec
EZ
22482011-11-14 Eli Zaretskii <eliz@gnu.org>
2249
2250 * xdisp.c (display_line): Move the call to
2251 highlight_trailing_whitespace before the call to
2252 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
2253 faces of all the glyphs to compute ROW's hash value.
2254 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 2255
f067b8ec
JB
22562011-11-14 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2259 just return (bug#10044).
2260
1e5b2111
EZ
22612011-11-12 Eli Zaretskii <eliz@gnu.org>
2262
7ef3cbd5
EZ
2263 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2264 with user-defined heap size. Bump the default size of the temacs
2265 heap to 27MB, to avoid memory warning when running temacs.
2266 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2267
1e5b2111
EZ
2268 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2269 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2270 (verify_row_hash) [XASSERTS]: New function.
2271 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2272 that the hash value of glyph rows is correct.
1e5b2111 2273
89d61221
MR
22742011-11-12 Martin Rudalics <rudalics@gmx.at>
2275
2276 * window.h (window): Remove splits slot.
2277 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2278 (Fdelete_other_windows_internal, make_parent_window)
2279 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2280 (Fset_window_configuration, save_window_save): Don't deal with
2281 split status of windows.
2282 (saved_window): Remove splits slot.
2283 (Vwindow_splits): Rewrite doc-string.
2284
97f18cc8
JD
22852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2286
2287 * xfns.c (unwind_create_frame):
2288 * nsfns.m (unwind_create_frame):
2289 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2290 Vframe_list (Bug#9999).
2291
22a648b4
DA
22922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2293
0b381c7e 2294 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2295
659afede
KH
22962011-11-11 Kenichi Handa <handa@m17n.org>
2297
2298 * callproc.c (Fcall_process): Set the member dst_multibyte of
2299 process_coding.
2300
9ac0394b
KH
23012011-11-11 Johan Bockgård <bojohan@gnu.org>
2302
2303 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2304 avoid a crash (bug#9496).
2305
2fbdc249
CY
23062011-11-09 Chong Yidong <cyd@gnu.org>
2307
2308 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2309 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2310
ac6b1f81
PE
23112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2314
09db192c
PE
23152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2316
2317 Avoid some portability problems by eschewing 'extern inline' functions.
2318 The trivial performance wins aren't worth the portability hassles; see
2319 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2320 et seq.
2321 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2322 (window_box_width, window_box_left, window_box_left_offset)
2323 (window_box_right, window_box_right_offset): Undo previous change,
2324 by removing the "extern"s.
2325 * intervals.c (adjust_intervals_for_insertion)
2326 (adjust_intervals_for_deletion): Undo previous change,
2327 making these static again.
2328 (offset_intervals, temp_set_point_both, temp_set_point)
2329 (copy_intervals_to_string): No longer inline.
2330 * xdisp.c (window_text_bottom_y, window_box_width)
2331 (window_box_height, window_box_left_offset)
2332 (window_box_right_offset, window_box_left, window_box_right)
2333 (window_box): No longer inline.
2334
105216ed
CY
23352011-11-08 Chong Yidong <cyd@gnu.org>
2336
2337 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2338 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2339 Signal an error if not a live window.
105216ed
CY
2340 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2341 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2342
ae9e237f
JB
23432011-11-07 Juanma Barranquero <lekktu@gmail.com>
2344
2345 * lisp.h (syms_of_abbrev): Remove declaration.
2346 Reported by CHENG Gao <chenggao@royau.me>.
2347
c7aa8333
EZ
23482011-11-07 Eli Zaretskii <eliz@gnu.org>
2349
2350 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2351 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2352 of temacs in GUI mode.
2353
be7f5545
MR
23542011-11-07 Martin Rudalics <rudalics@gmx.at>
2355
2356 * window.h: Declare delete_all_child_windows instead of
2357 delete_all_subwindows.
2358 * window.c (Fwindow_nest, Fset_window_nest)
2359 (Fset_window_new_total, Fset_window_new_normal)
2360 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2361 (delete_all_subwindows): Rename to delete_all_child_windows.
2362 (Fdelete_other_windows_internal, Fset_window_configuration):
2363 Call delete_all_child_windows instead of delete_all_subwindows.
2364 * frame.c (delete_frame): Call delete_all_child_windows instead
2365 of delete_all_subwindows.
2366
ca78dc43
PE
23672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2370 This is also needed for porting to any host where GC_MARK_STACK is
2371 not GC_MAKE_GCPROS_NOOPS.
2372 (which_symbols): Use it.
2373
a0241d01
KH
23742011-11-07 Kenichi Handa <handa@m17n.org>
2375
2376 * coding.c (coding_set_destination): Check coding->src_pos only
2377 when coding->src_object is a buffer (bug#9910).
2378
2379 * process.c (send_process): Set the member src_multibyte of coding
2380 to 0 (bug#9911) when sending a unibyte text.
2381
2382 * callproc.c (Fcall_process): Set the member src_multibyte of
2383 process_coding to 0 (bug#9912).
2384
a64bfdfa 23852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2386
2387 * xmenu.c (cleanup_widget_value_tree): New function.
2388 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2389 calling free_menubar_widget_value_tree directly (Bug#9830).
2390
cb41b32a
PE
23912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 Fix some portability problems with 'inline'.
2394 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2395 (window_box_width, window_box_left, window_box_left_offset)
2396 (window_box_right, window_box_right_offset): Declare extern.
2397 Otherwise, these inline functions do not conform to C99 and
2398 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2399 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2400 * intervals.c (adjust_intervals_for_insertion)
2401 (adjust_intervals_for_deletion): Now extern, because otherwise the
2402 extern inline functions 'offset_intervals' couldn't refer to it.
2403 (static_offset_intervals): Remove.
2404 (offset_intervals): Rewrite using the old contents of
2405 static_offset_intervals. The old version didn't conform to C99
2406 because an extern inline function contained a reference to an
2407 identifier with static linkage.
2408
b7041366
AS
24092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2410
2411 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2412 GC.
2413
88a37c4d
EZ
24142011-11-06 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2417 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2418 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2419 return Qleft_to_right.
2420
49745b39
CY
24212011-11-06 Chong Yidong <cyd@gnu.org>
2422
2423 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2424 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2425 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2426 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2427 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2428 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2429 (Fwindow_vscroll): Doc fix.
2430 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2431 argument, since it makes no sense to pass a live window and for
2432 consistency with window-child.
2433
1f05cd82
CS
24342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2435
2436 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2437 support MSVC.
2438
22610910
JR
24392011-11-05 Jason Rumney <jasonr@gnu.org>
2440
2441 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2442 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2443 fonts (Bug#6029).
2444 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2445 bitwise arithmetic preventing use of unicode-sip and non-truetype
2446 opentype fonts.
2447
a06776b2
EZ
24482011-11-05 Eli Zaretskii <eliz@gnu.org>
2449
3ad924ba
EZ
2450 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2451 "emacs"-only part.
2452
a06776b2
EZ
2453 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2454 initialization code to keep similarity to xfns.c after changes
2455 from 2011-11-05.
2456
c9e7db78
JD
24572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2458
a97f8f3f
JD
2459 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2460 (unwind_create_frame): New function (Bug#9943).
2461 (Fx_create_frame): Restructure code to be more similar to the one in
2462 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2463 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2464 Move terminal->reference_count++ just before making the frame official
2465 (Bug#9943).
2466
2467 * nsterm.m (x_free_frame_resources): New function.
2468 (x_destroy_window): Move code to x_free_frame_resources.
2469
c9e7db78 2470 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2471 (Fx_create_frame, x_create_tip_frame):
2472 Move terminal->reference_count++ just before making the frame
75f1671a 2473 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2474 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2475
a6fc3b5c
EZ
24762011-11-05 Eli Zaretskii <eliz@gnu.org>
2477
2478 Support MSVC build with newer versions of Visual Studio.
2479 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2480 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2481 nt/gmake.defs.
2482
2483 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2484 which are not supported by MSVC.
2485 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2486 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2487 bitfields.
2488 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2489 types in bitfields.
2490 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2491
2492 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2493
58179cce 24942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2495
2496 Support MSVC build with newer versions of Visual Studio.
2497 * w32.c: Don't include w32api.h for MSVC.
2498 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2499
2500 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2501 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2502 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2503 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2504 e_* cousins.
2505 (alloca) [_MSC_VER]: Define to _alloca.
2506
2507 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2508
2509 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2510
a58c13ed
EZ
25112011-11-04 Eli Zaretskii <eliz@gnu.org>
2512
2513 * xdisp.c (note_mouse_highlight): If either of
2514 previous/next-single-property-change returns nil, treat that as
2515 the beginning or the end of the buffer. (Bug#9955)
2516
fe0b6370
JD
25172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2518
a58c13ed 2519 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2520 label is not null (Bug#9951).
2521 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2522 may be NULL.
2523
89bd5ee1
EZ
25242011-11-04 Eli Zaretskii <eliz@gnu.org>
2525
2526 * window.c (Fwindow_body_size): Mention in the doc string that the
2527 return value is in frame's canonical units. (Bug#9949)
2528
84c3edb9
EZ
25292011-11-03 Eli Zaretskii <eliz@gnu.org>
2530
4e2fb5c7
EZ
2531 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2532
84c3edb9 2533 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2534 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2535 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2536
bc17a887
EZ
25372011-11-01 Eli Zaretskii <eliz@gnu.org>
2538
2539 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2540 Don't stop backward scan on the continuation glyph, even though
2541 its CHARPOS is positive.
6d5eb5b0
SM
2542 (mouse_face_from_buffer_pos, note_mouse_highlight):
2543 Rename cover_string to disp_string.
bc17a887 2544
4ee88440
MR
25452011-11-01 Martin Rudalics <rudalics@gmx.at>
2546
2547 * window.c (temp_output_buffer_show): Don't use
2548 Vtemp_buffer_show_specifiers.
2549 (Vtemp_buffer_show_specifiers): Remove unused variable.
2550
c2ff3c02
EZ
25512011-10-30 Eli Zaretskii <eliz@gnu.org>
2552
2553 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2554 past the beginning of the current glyph matrix.
2555
58179cce 25562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2557
2558 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2559 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2560 HAVE_GTK3 (Bug#9869).
b77a6a7f 2561
3b574623
JD
2562 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2563 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2564
b77a6a7f
JD
2565 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2566
2567 * xterm.c: Declare x_handle_net_wm_state to return int.
2568 (handle_one_xevent): Check if we are iconified but don't have
2569 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2570 (get_current_wm_state): Return non-zero if not hidden,
2571 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2572 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2573 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2574 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2575
196e41e4
PE
25762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2579 so that this new function doesn't get optimized away by a
2580 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2581
021f2e1a
AS
25822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2583
2584 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2585
8b058d44
EZ
25862011-10-29 Eli Zaretskii <eliz@gnu.org>
2587
2588 Fix the `xbytecode' command.
2589 * .gdbinit (xprintbytestr): New command.
b50a28de 2590 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2591 (xbytecode): Print the byte-code string as well.
2592
4452fb80
EZ
25932011-10-29 Kim Storm <storm@cua.dk>
2594
8b058d44
EZ
2595 * alloc.c (which_symbols): New function.
2596
21b72067
AS
25972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2598
2599 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2600 line. (Bug#9903)
2601
83ed7b5c
GM
26022011-10-29 Glenn Morris <rgm@gnu.org>
2603
2604 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2605 Not clear what it was for, and it causes various bugs. (Bug#9839)
2606
5a7a728b
EZ
26072011-10-28 Eli Zaretskii <eliz@gnu.org>
2608
2609 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2610 possible random value that matches one of those tested as
2611 condition to clear the mouse face.
2612
d3d0842f
CY
26132011-10-28 Chong Yidong <cyd@gnu.org>
2614
2615 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2616
31b39d13
DN
26172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2618
2619 * window.c (make_window): Initialize phys_cursor_on_p.
2620
9aba6043
SM
26212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2622
2623 * lisp.h (struct Lisp_Symbol): Update comments.
2624
c20992f4
JB
26252011-10-28 Juanma Barranquero <lekktu@gmail.com>
2626
2627 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2628
db4f02f2
EZ
26292011-10-28 Eli Zaretskii <eliz@gnu.org>
2630
2631 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2632 <oslsachem@gmail.com> for helping to debug this.
2633
2634 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2635 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2636 (g_b_init_get_glyph_outline_w): New static variables.
2637 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2638 (GetGlyphOutlineW_Proc): New typedefs.
2639 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2640 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2641 New functions.
2642 (w32font_open_internal, compute_metrics):
2643 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2644 instead of calling the "wide" APIs directly.
2645
2646 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2647
2648 * w32.h (syms_of_w32font): Add prototype.
2649
87e68db4
JB
26502011-10-27 Juanma Barranquero <lekktu@gmail.com>
2651
2652 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2653 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2654 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2655 (Fmove_to_window_line): Doc fix.
2656
435c1d67
CY
26572011-10-27 Chong Yidong <cyd@gnu.org>
2658
2659 * process.c (make_process): Set gnutls_state to NULL.
2660
2661 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2662 non-NULL, regardless of GNUTLS_INITSTAGE.
2663 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2664 an error. Set process slots as soon as we allocate them.
2665
2666 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2667
9c6c6f49
CY
26682011-10-27 Chong Yidong <cyd@gnu.org>
2669
9aba6043
SM
2670 * gnutls.c (emacs_gnutls_deinit): New function.
2671 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2672 (Fgnutls_deinit, Fgnutls_boot): Use it.
2673
2674 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2675 (deactivate_process): Call emacs_gnutls_deinit.
2676
657d08d3
JB
26772011-10-27 Juanma Barranquero <lekktu@gmail.com>
2678
2679 * image.c (x_create_x_image_and_pixmap):
2680 * w32.c (sys_rename, w32_delayed_load):
2681 * w32font.c (fill_in_logfont):
2682 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2683
5430d399
JB
26842011-10-26 Juanma Barranquero <lekktu@gmail.com>
2685
2686 * w32fns.c (w32_default_color_map): New function,
2687 extracted from Fw32_default_color_map.
a7ef684b 2688 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2689
fe0055fa
PE
26902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2691
2692 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2693
e6346438
SM
26942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2695
2696 * keyboard.c (test_undefined): New function (bug#9751).
2697 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2698
e112cc37
ET
26992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2700
2701 * sysdep.c (init_sys_modes): Fix the check for the controlling
2702 terminal (Bug#6649).
2703
7b5d6677
EZ
27042011-10-20 Eli Zaretskii <eliz@gnu.org>
2705
2706 * dispextern.h (struct bidi_it): New member next_en_type.
2707
2708 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2709 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2710 current character, check also for next_en_type being WEAK_EN.
2711 (bidi_resolve_weak): Don't enter the expensive loop if the current
2712 position is before next_en_pos. Record the bidi type of the first
2713 non-ET, non-BN character we find, in addition to its position.
2714 (bidi_level_of_next_char): Invalidate next_en_type when
2715 next_en_pos is over-stepped.
2716
7da0b018
PE
27172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2720 * editfns.c: Rewrite current-time-zone so that it invokes
2721 the equivalent of (format-time-string "%Z") to get the time zone name.
2722 This fixes a bug when the time zone name contains characters that
2723 need converting from the system time locale to Emacs internal format.
2724 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2725 that patch fixed format-time-string to do the conversion, but
2726 I forgot to fix current-time-zone.
2727 (format_time_string): New function, containing most of
2728 what Fformat_time_string used to contain.
2729 (Fformat_time_string): Rewrite in terms of format_time_string.
2730 This doesn't change this function's behavior.
2731 (current-time-zone): Rewrite to use format_time_string.
2732 This fixes the bug reported by Michael Schierl in
2733 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2734 Jason Rumney's 2007-06-07 change worked around this bug, but
2735 didn't fix it.
2736 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2737
8547b010
EZ
27382011-10-19 Eli Zaretskii <eliz@gnu.org>
2739
2740 * xdisp.c (start_display): If the character at POS is displayed
2741 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2742 (try_window_reusing_current_matrix): If a line ends in a display
2743 vector or the next line starts in a display vector, continue
2744 redrawing the window even though the character position of
2745 start_row was reached.
8547b010
EZ
2746 (Bug#9771, part 2)
2747
4e948d15
CY
27482011-10-18 Chong Yidong <cyd@gnu.org>
2749
2750 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2751 with nobreak-char-display too.
2752
4787455f
EZ
27532011-10-18 Eli Zaretskii <eliz@gnu.org>
2754
2755 Fix part 3 of bug#9771.
2756 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2757 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2758 non-neutral characters if the current character is a paragraph
2759 separator (a.k.a. Newline). This avoids running the same
2760 expensive loop twice, once when we consume the preceding newline
2761 and the other time when the line actually needs to be displayed.
2762 Avoid the loop when we see neutrals on the base embedding level
2763 following a character whose directionality is the same as the
2764 paragraph's. This avoids running the expensive loop when a line
2765 ends in a long sequence of neutrals, like control characters.
2766 Add assertion against STRONG_AL type. Slightly rearrange code
2767 that determines the type of a neutral given the first non-neutral
2768 that follows it.
2769 (bidi_level_of_next_char): Set next_en_pos to zero when
2770 invalidating its info.
2771
2c91f553
EZ
27722011-10-17 Eli Zaretskii <eliz@gnu.org>
2773
2774 * xdisp.c (push_display_prop): Determine whether to record string
2775 or buffer position by IT->string, not by IT->method. Allow
2776 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2777 (move_it_vertically_backward): Don't look for character position
2778 immediately after the newline when in a continuation line.
2779 (Bug#9771, part 1)
2c91f553 2780
c7b08b0d
MR
27812011-10-15 Martin Rudalics <rudalics@gmx.at>
2782
2783 * window.c (coordinates_in_window): Rewrite and delabelize
2784 vertical border check. (Bug#5357) (Bug#9618)
2785
6b02f655
SM
27862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2787
2788 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2789 errors in XSetWindowBorder (bug#9310).
2790
81d40c92
DA
27912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2792
2793 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2794 avoid crash when xmalloc overrun checking is enabled.
2795
d4172c3b
EZ
27962011-10-13 Eli Zaretskii <eliz@gnu.org>
2797
2798 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2799 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2800 cursor motion with <left> and <right> arrow keys.
2801
2802 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2803 some callers set that themselves.
2804
b00eea75
EZ
28052011-10-12 Eli Zaretskii <eliz@gnu.org>
2806
2807 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2808 display string and the previous row comes from the same string and
2809 is empty. (Bug#9739) (Bug#9738)
2810
8fe012c4
SM
28112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2812
2813 * doc.c (get_doc_string): Encode file name (bug#9735).
2814
0074aef2
EZ
28152011-10-12 Eli Zaretskii <eliz@gnu.org>
2816
79beb178
EZ
2817 * bidi.c (bidi_level_of_next_char):
2818 * xdisp.c (get_visually_first_element): Remove old incorrect
2819 comments regarding the Unicode Line Separator character.
2820
0074aef2
EZ
2821 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2822
6e4b3fbe
DA
28232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * alloc.c (Fgc_status): Do not access beyond zombies array
2826 boundary if nzombies > MAX_ZOMBIES.
2827 * alloc.c (dump_zombies): Add missing format specifier.
2828
0324f3af
PE
28292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2830
b5525cac
PE
2831 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2832 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2833
0324f3af
PE
2834 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2835 Some packages use them to denote characters with modifiers.
2836
e9b5f888
AS
28372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2838
2839 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2840 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2841 matching a pp-number. Rename parameter var to var1.
2842
127827c0
SM
28432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2844
2845 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2846
c8fd3bd0
GM
28472011-10-08 Glenn Morris <rgm@gnu.org>
2848
2849 * callint.c (Fcall_interactively): Give a more explicit error for the
2850 'c' case with a non-character input. (Bug#8479)
2851
352ec8ff
EZ
28522011-10-08 Eli Zaretskii <eliz@gnu.org>
2853
03669ccb
EZ
2854 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2855 lines.
7061c986
EZ
2856 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2857 lines that are hscrolled on the left.
03669ccb 2858
352ec8ff
EZ
2859 * dispnew.c (buffer_posn_from_coords): Account for a possible
2860 presence of header-line. (Bug#4426)
2861
a66cfb1c
SM
28622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2863
6b02f655
SM
2864 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2865 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2866
7c5ee88e
PE
28672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2868
2869 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2870 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2871 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2872 this makes Emacs dump core during garbage collection on rare
2873 occasions. sizeof is obviously inferior to offsetof here, so
2874 stick with offsetof.
2875 (GC_POINTER_ALIGNMENT): New macro.
2876 (mark_memory): Omit 3rd (offset) arg; caller changed.
2877 Don't assume EMACS_INT alignment is the same as pointer alignment.
2878
df1bbe5b
SM
28792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2880
2881 * keyboard.c (read_key_sequence_remapped): New var.
2882 (read_key_sequence): Compute remapping in the right buffer.
2883 (command_loop_1): Use read_key_sequence's remapping directly.
2884
51553db6
SM
28852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2886
32c1fffd
SM
2887 * dired.c (file_name_completion): Don't expand file name.
2888 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2889 before checking file name handler.
2890
51553db6
SM
2891 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2892 they've been requested explicitly (bug#9591).
2893
b6bd1599 28942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2895
2896 * keymap.c (Fsingle_key_description): Use make_specified_string
2897 instead of build_string to build string from push_key_description.
2898 (Bug#5193)
2899
f701dc2a
PE
29002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2901
4222c55d
PE
2902 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2903 This fixes a Y2038 bug on 64-bit hosts.
2904 * buffer.c (reset_buffer):
2905 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2906 (Fclear_buffer_auto_save_failure):
2907 Use 0, not -1, to represent an unset failure time, since time_t
2908 might not be signed.
2909
f701dc2a
PE
2910 Remove dependency on glibc malloc internals.
2911 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2912 Move back here from lisp.h, but with their new implementations.
2913 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2914 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2915 * charset.c (charset_table_init): New static var.
2916 (syms_of_charset): Use it instead of xmalloc. This removes a
2917 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2918 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2919 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2920 Move back to alloc.c.
2921 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2922 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2923
9ceebf39
JD
29242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2925
2926 * nsterm.m (windowDidResize): Call x_set_window_size only when
2927 ns_in_resize is true. Otherwise set pixelwidth/height and
2928 call change_frame_size (Bug#9628).
2929
cb993c58
PE
29302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2931
3930c88b
PE
2932 Port --enable-checking=all to Fedora 14 x86-64.
2933 * charset.c (syms_of_charset): Also account for glibc malloc's
2934 internal overhead when calculating the initial malloc maximum.
2935
cb993c58
PE
2936 Port --enable-checking=all to Fedora 14 x86.
2937 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2938 Move to lisp.h.
2939 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2940 (overrun_check_realloc, overrun_check_free):
2941 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2942 That way, xmalloc returns a properly-aligned pointer even if
2943 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2944 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2945 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2946 into account when calculating the initial malloc maximum.
2947 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2948 Move here from alloc.c, so that charset.c can use it too.
2949 Properly align; the old code wasn't right for common 32-bit hosts
2950 when configured with --enable-checking=all.
2951 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2952 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2953
31bed486
EZ
29542011-09-29 Eli Zaretskii <eliz@gnu.org>
2955
04c70788 2956 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2957 use EDOM.
2958
fbcaa2f3
EZ
29592011-09-28 Eli Zaretskii <eliz@gnu.org>
2960
2961 * xdisp.c (compute_display_string_end): If there's no display
2962 string at CHARPOS, return -1.
2963
2964 * bidi.c (bidi_fetch_char): When compute_display_string_end
2965 returns a negative value, treat the character as a normal
2966 character not covered by a display string. (Bug#9624)
2967
a239d4e9
JB
29682011-09-28 Juanma Barranquero <lekktu@gmail.com>
2969
2970 * lread.c (Fread_from_string): Fix typo in docstring.
2971
88652fd5
EZ
29722011-09-27 Eli Zaretskii <eliz@gnu.org>
2973
2974 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2975 newline, reseat the iterator instead of bidi-iterating there one
2976 character at a time. (Bug#9610)
32c1fffd
SM
2977 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2978 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2979
ed497dd4
AS
29802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2981
2982 * lread.c (readevalloop): Use correct code for NBSP.
2983 (read1): Likewise. (Bug#9608)
2984
b2bf61aa
MA
29852011-09-25 Michael Albinus <michael.albinus@gmx.de>
2986
2987 * dbusbind.c (Fdbus_register_signal): When service is not
2988 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2989
32bbb17c
GM
29902011-09-25 Glenn Morris <rgm@gnu.org>
2991
2992 * buffer.c (truncate-lines): Doc fix.
2993
94e0933e
CY
29942011-09-24 Chong Yidong <cyd@stupidchicken.com>
2995
2996 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2997 (Fset_window_next_buffers): Doc fix.
2998
cddde921
GM
29992011-09-24 Glenn Morris <rgm@gnu.org>
3000
3001 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3002
1260aef1
PE
30032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3004
25b4bfa0
PE
3005 Fix minor problems found by static checking.
3006 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3007 * indent.c (Fvertical_motion): Fix == vs = typo.
3008
e3cbd34b
EZ
30092011-09-24 Eli Zaretskii <eliz@gnu.org>
3010
a66cfb1c
SM
3011 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3012 Default value is now t. Doc fix.
6bf7006f 3013
e3cbd34b 3014 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3015 logic when moving up, not only when moving down. Fix the
e3cbd34b 3016 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3017 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3018
3019 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3020 CHARPOS is covered by a display string which includes newlines.
3021 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3022 is covered by a display string with embedded newlines.
3023
a3de0cbd
MA
30242011-09-24 Michael Albinus <michael.albinus@gmx.de>
3025
3026 * dbusbind.c (Fdbus_register_signal): Add match rule to
3027 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3028 (Fdbus_register_method, Vdbus_registered_objects_table):
3029 Fix docstring.
a3de0cbd 3030
b260039d
JM
30312011-09-24 Jim Meyering <meyering@redhat.com>
3032
32c1fffd 3033 do not ignore write error for any output size
b260039d
JM
3034 The previous change was incomplete.
3035 While it makes emacs --batch detect the vast majority of stdout
3036 write failures, errors were still ignored whenever the output size is
3037 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3038 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3039 && echo FAIL: ignored write error
3040 FAIL: ignored write error
3041 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3042 && echo FAIL: ignored write error
3043 FAIL: ignored write error
3044 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3045
8eca8a7c
AS
30462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3047
3048 * emacs.c (Fkill_emacs): In noninteractive mode exit
3049 non-successfully if a write error occurred on stdout. (Bug#9574)
3050
3341db62
EZ
30512011-09-21 Eli Zaretskii <eliz@gnu.org>
3052
3053 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3054 the xassert test.
3055
3056 * dispextern.h (struct it): Update the comment documenting what
3057 can it->OBJECT be.
3058
8c203dbf
EZ
30592011-09-20 Eli Zaretskii <eliz@gnu.org>
3060
3061 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3062 a display string, extend search for cursor position to end of row.
3063 (find_row_edges): If the row ends in a newline from a display
3064 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3065 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3066 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3067 non-empty line. Fixes confusing cursor motion with arrow keys at
3068 the beginning of a line that starts with whitespace.
8c203dbf 3069
a4824228
LMI
30702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3071
3072 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3073 (bug#9493).
3074
33ed493b
CY
30752011-09-18 Chong Yidong <cyd@stupidchicken.com>
3076
3077 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3078 boolean (Bug#9154).
3079
56cd55c8
EZ
30802011-09-18 Eli Zaretskii <eliz@gnu.org>
3081
3082 * xdisp.c (display_line): Record maximum and minimum buffer
3083 positions even if no glyphs were produced (e.g., by a zero-width
3084 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3085 buffer positions that will be removed from the glyph row because
3086 they don't fit.
c02dcedf
EZ
3087 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3088 column is beyond frame width: don't subtract 1 "pixel" when
3089 computing width of the stretch.
3e62b7e0
EZ
3090 (reseat_at_next_visible_line_start): Undo the change made on
3091 2011-09-17 that saved paragraph information and restored it after
3092 the call to `reseat'. (Bug#9545)
56cd55c8 3093
5ed99d36 30942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3095
3096 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3097 and turn window cursor on if cleared (Bug#9415).
3098
5ed99d36 30992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3100
3101 * search.c (boyer_moore): Take unibyte characters from pattern
3102 literally. (Bug#9458)
3103
9bade7b2
EZ
31042011-09-18 Eli Zaretskii <eliz@gnu.org>
3105
3106 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3107
e5e9d610
PE
31082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3109
87e4427a
PE
3110 Fix minor problem found by static checking.
3111 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3112 initialized, to pacify gcc -Wuninitialized.
3113
e5e9d610
PE
3114 * fileio.c: Report proper errno when syscall falls.
3115 (Finsert_file_contents): Save and restore errno,
3116 so that report_file_error outputs the correct diagnostic.
3117 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3118
a1674f0b
EZ
31192011-09-18 Eli Zaretskii <eliz@gnu.org>
3120
3121 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3122
fbfb6dd4
EZ
31232011-09-17 Eli Zaretskii <eliz@gnu.org>
3124
3125 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3126 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3127
bb187662
EZ
31282011-09-17 Eli Zaretskii <eliz@gnu.org>
3129
1137e8b8 3130 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3131 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3132
3133 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3134 (bidi_find_paragraph_start): Search back for paragraph beginning
3135 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3136 (bidi_move_to_visually_next): Only trigger paragraph-related
3137 computations when the last character is a newline or at EOB, not
3138 just any NEUTRAL_B. (Bug#9470)
3139
bb187662
EZ
3140 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3141 truncated lines if point is covered by a display string. (Bug#9524)
3142
2e621251
PE
31432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3144
3145 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3146 (cons_to_x_long): New function.
3147 (lisp_data_to_selection_data): Use it. Correct the test for
3148 short-versus-long data; it was negated. Break out of vector
3149 loop, for efficiency, when a long datum is discovered.
3150
91a15bc6
SM
31512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3152
3153 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3154
b41c3a35
EZ
31552011-09-16 Eli Zaretskii <eliz@gnu.org>
3156
3157 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3158 GCC PR/17406) by declaring this function with external scope.
3159
7812ba2d
PE
31602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3161
3162 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3163 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3164
cf7edc2a
AS
31652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3166
3167 * editfns.c (Fformat): Correctly handle text properties on "%%".
3168
bd01620e
EZ
31692011-09-15 Eli Zaretskii <eliz@gnu.org>
3170
3171 * xterm.c (x_draw_composite_glyph_string_foreground):
3172 * w32term.c (x_draw_composite_glyph_string_foreground):
3173 * term.c (encode_terminal_code):
3174 * composite.c (composition_update_it, get_composition_id):
3175 * xdisp.c (get_next_display_element)
3176 (fill_composite_glyph_string): Add comments about special meaning
3177 of TAB characters in a composition.
3178
a02719a3
PE
31792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3182 This occurs when processing a multibyte format.
3183 Problem reported by Wolfgang Jenker.
a02719a3 3184
72589a3c
JB
31852011-09-15 Johan Bockgård <bojohan@gnu.org>
3186
3187 * xdisp.c (try_cursor_movement): Only check for exact match if
3188 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3189
1c14176c
PE
31902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 Remove unused external symbols.
3193 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3194 * xdisp.c (calc_pixel_width_or_height): Now static.
3195 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3196 * indent.c (check_display_width):
3197 * w32term.c: Fix comment to match code.
3198 * xterm.c, xterm.h (x_catching_errors): Remove.
3199
d2eea5b5
PE
32002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 * xselect.c: Use signed conversions more consistently (Bug#9498).
3203 (selection_data_to_lisp_data): Assume incoming selection data are
3204 signed integers, not unsigned. This is to be consistent with
3205 outgoing selection data, which was modified to use signed integers
3206 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3207 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3208 expects long, not unsigned long.
3209
46888499
EZ
32102011-09-14 Eli Zaretskii <eliz@gnu.org>
3211
3212 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3213 computation of loop end. Reported by Johan Bockgård
3214 <bojohan@gnu.org>.
3215
ef8ef9fb
CY
32162011-09-13 Chong Yidong <cyd@stupidchicken.com>
3217
3218 * frame.c (Fother_visible_frames_p): Function deleted.
3219
fa819fed
EZ
32202011-09-12 Eli Zaretskii <eliz@gnu.org>
3221
3222 * indent.c (compute_motion): Process display vector front to back
3223 rather than the other way around. (Bug#2496)
3224
2ba8e008
SM
32252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3226
3227 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3228
20f53c69
CY
32292011-09-11 Chong Yidong <cyd@stupidchicken.com>
3230
3231 * minibuf.c (Fread_from_minibuffer): Doc fix.
3232
d562d7a4
EZ
32332011-09-11 Eli Zaretskii <eliz@gnu.org>
3234
3235 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3236 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3237
1c4d7f3d
LMI
32382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3239
3240 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3241 value for non-existent files.
3242
b885bf36
EZ
32432011-09-11 Eli Zaretskii <eliz@gnu.org>
3244
3245 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3246 set its "size" to -1. This will set the modtime_size field of
3247 the corresponding buffer to -1, which is what
3248 verify-visited-file-modtime expects for files that do not exist.
3249 (Bug#9139)
3250
6612f0bf
PE
32512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3254 here ...
3255 * lisp.h: ... from here. push_key_description is no longer
3256 defined in keyboard.c, so its declaration should not be in
3257 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3258 logically belongs with push_key_description.
3259
dfb3f755
PE
32602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 * buffer.h: Include <sys/types.h> instead of <time.h>.
3263 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3264 Problem reported by Herbert J. Skuhra.
3265
3134906c
LMI
32662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3267
3268 * xml.c (parse_region): Make the parsing work for
3269 non-comment-starting XML files again (bug#9144).
3270
8d903f4e
AS
32712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3272
3273 * image.c (gif_load): Fix calculation of bottom and right corner.
3274 (Bug#9468)
3275
80ad64f4
EZ
32762011-09-10 Eli Zaretskii <eliz@gnu.org>
3277
3278 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3279 redisplay in small windows.
3280
208a048d
EZ
32812011-09-09 Eli Zaretskii <eliz@gnu.org>
3282
3283 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3284
9b1c252e
MR
32852011-09-08 Martin Rudalics <rudalics@gmx.at>
3286
3287 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3288 Operate on live windows only.
3289
2949f33b
JB
32902011-09-08 Juanma Barranquero <lekktu@gmail.com>
3291
3292 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3293
e08dcafd
EZ
32942011-09-07 Eli Zaretskii <eliz@gnu.org>
3295
3296 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3297 only under bidi iteration.
3298
115b96bd
JD
32992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3300
3301 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3302
c8199d0f
PE
33032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3306 Without this fix, the command to link temacs failed due to an
3307 undefined symbol __builtin_isnan. This is because
3308 /usr/include/iso/math_c99.h #defines isnan(x) to
3309 __builtin_isnan(x), but the bundled gcc, which identifies itself
3310 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3311 a __builtin_isnan.
3312 * floatfns.c (isnan): #undef, and then #define to a clone of
3313 what's in data.c.
3314 (Fisnan): Always define, since it's always available now.
3315 (syms_of_floatfns): Always define isnan at the Lisp level.
3316
e39b275c 33172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3318
3319 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3320
b2db44d9 33212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3322
f4af5137 3323 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3324 The previous code assumed that file offsets (off_t values) fit in
3325 EMACS_INT variables, which is not true on typical 32-bit hosts.
3326 The code messed up by falsely reporting buffer overflow in cases
3327 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3328 when "big" contains more than 2**29 bytes, even though this
3329 inserts just one byte and does not overflow the buffer.
3330 (Finsert_file_contents): Store file offsets as off_t
3331 values, not as EMACS_INT values. Check for overflow when
3332 converting between EMACS_INT and off_t. When checking for
3333 buffer overflow or for overlap, take the offsets into account.
3334 Don't use EMACS_INT for small values where int suffices.
3335 When checking for overlap, fix a typo: ZV was used where
3336 ZV_BYTE was intended.
3337 (Fwrite_region): Don't assume off_t fits into 'long'.
3338 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3339
ecfc0a49
MA
33402011-09-05 Michael Albinus <michael.albinus@gmx.de>
3341
3342 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3343
6511acf2 33442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3345
0999621a 3346 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3347
3348 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3349 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3350 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3351 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3352 (modify_event_symbol): Do not assume that the length of
3353 name_alist_or_stem is safe to alloca and fits in int.
3354 (Fexecute_extended_command): Likewise for function name and binding.
3355 (Frecursion_depth): Wrap around reliably on integer overflow.
3356 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3357 since some callers pass EMACS_INT values.
3358 (Fsingle_key_description): Don't crash if symbol name contains more
3359 than MAX_ALLOCA bytes.
3360 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3361 (get_minibuffer): Arg is now EMACS_INT, not int.
3362 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3363 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3364 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3365
2be7d702
PE
3366 * dbusbind.c (signature_cat): New function.
3367 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3368 Do not overrun buffer; instead, report string overflow.
3369
9d1df220
PE
3370 * dispnew.c (add_window_display_history): Don't overrun buffer.
3371 Truncate instead; this is OK since it's just a log.
3372
33ef5c64
PE
3373 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3374 even if the time zone offset is outlandishly large.
3375 Don't mishandle offset == INT_MIN.
3376
66c6fdd5
PE
3377 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3378 when creating daemon; the previous buffer-overflow check was incorrect.
3379
d749b01b
PE
3380 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3381 which has the guts of the old verror function.
3382
b5cd1905
PE
3383 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3384 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3385
6e1a67fb
PE
3386 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3387 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3388 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3389 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3390 length of string rather than counting it via multiple sprintfs;
3391 that's simpler and more reliable.
c21721cc
PE
3392 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3393 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3394 sprintf, in case result does not fit in int.
3395
c57b67fc
PE
3396 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3397 (fontset_from_font): Print it.
3398
8a401434
PE
3399 * frame.c (tty_frame_count): Now printmax_t, not int.
3400 (make_terminal_frame, set_term_frame_name): Print it.
3401 (x_report_frame_params): In X, window IDs are unsigned long,
3402 not signed long, so print them as unsigned.
3403 (validate_x_resource_name): Check for implausibly long names,
3404 and don't assume name length fits in 'int'.
3405 (x_get_resource_string): Don't blindly alloca invocation name;
3406 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3407 not fit in int.
3408
6e1a67fb
PE
3409 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3410 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3411 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3412
0df02bf3
PE
3413 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3414 Use esprintf, not sprintf, in case result does not fit in int.
3415
48e30793
PE
3416 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3417 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3418 it as a large positive number.
3419 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3420 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3421
a66ff6d8
PE
3422 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3423 in case result does not fit in int.
3424
aca216ff
PE
3425 * print.c (float_to_string): Detect width overflow more reliably.
3426 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3427 buffer overrun. Don't assume list length fits in 'int'. Treat
3428 print length of 0 as 0, not as infinity; to be consistent with other
3429 uses of print length in this function. Don't overflow print length
3430 index. Don't assume hash table size fits in 'long', or that
3431 vectorlike size fits in 'unsigned long'.
3432
31c286f7
PE
3433 * process.c (make_process): Use printmax_t, not int, to format
3434 process-name gensyms.
3435
55e5faa1
PE
3436 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3437
80f2e268
PE
3438 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3439 to avoid potential buffer overrun.
3440
670741ab
PE
3441 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3442 if X resource line is longer than 512 bytes.
3443
b7163a50
PE
3444 * xfns.c (x_window): Make sprintf buffer a bit bigger
3445 to avoid potential buffer overrun.
3446
ae58ff1f
PE
3447 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3448
c43c8a6a
PE
3449 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3450
3f8236f4
PE
34512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3452
53e9fe90 3453 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3454 Without these, Emacs silently mishandles large integers sometimes.
3455 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3456 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3457
6511acf2
PE
3458 * xdisp.c (try_window_id): Check Emacs fixnum range before
3459 converting to 'int'.
806add1d 3460
6511acf2 3461 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3462 Check that an Emacs fixnum is in range before assigning it to 'int'.
3463 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3464 values converted from Emacs fixnums.
3465 (Frecenter): Don't wrap around a line count if it is out of 'int'
3466 range; instead, treat it as an extreme value.
3467 (Fset_window_configuration, compare_window_configurations):
3468 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3469
6511acf2
PE
3470 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3471 that can exceed INT_MAX. Check that EMACS_INT value is in range
3472 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3473 (match_limit): Don't assume that a fixnum can fit in 'int'.
3474
6511acf2 3475 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3476 exceed INT_MAX.
3477
6511acf2 3478 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3479 (Fvertical_motion): Don't wrap around LINES values that don't fit
3480 in 'int'. Instead, treat them as extreme values. This is good
3481 enough for windows, which can't have more than INT_MAX lines anyway.
3482
fcb901a7
LMI
34832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3484
0f2f6b6d
LMI
3485 * Require libxml/parser.h to avoid compilation warning.
3486
fcb901a7
LMI
3487 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3488
3489 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3490 since this reportedly can destroy thread storage.
3491
6e20a0d4
CY
34922011-08-30 Chong Yidong <cyd@stupidchicken.com>
3493
3494 * syntax.c (find_defun_start): Update all cache variables if
3495 exiting early (Bug#9401).
3496
148ae00e
EZ
34972011-08-30 Eli Zaretskii <eliz@gnu.org>
3498
f6cfbd8f
EZ
3499 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3500
148ae00e
EZ
3501 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3502 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3503 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3504
3505 * term.c (tty_append_glyph): New function.
3506 (produce_stretch_glyph): Static function and its prototype deleted.
3507
a66cfb1c
SM
3508 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3509 Add prototypes.
148ae00e 3510
c4a07a4c
PE
35112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3512
3513 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3514 when checking :margin (Bug#9390).
3515 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3516 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3517 so that the name doesn't mislead. All uses changed.
3518
6bc8cd65
JB
35192011-08-28 Johan Bockgård <bojohan@gnu.org>
3520
3521 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3522 set_tty_hooks.
3523
dca4927e
EZ
35242011-08-27 Eli Zaretskii <eliz@gnu.org>
3525
3526 * xdisp.c (move_it_to): Don't bail out early when reaching
3527 position beyond to_charpos, if we are scanning backwards.
3528 (move_it_vertically_backward): When DY == 0, make sure we get to
3529 the first character in the line after the newline.
3530
f2cad773
PE
35312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3534 (ccl_driver): Do not generate an out-of-range pointer.
3535 (Fccl_execute_on_string): Remove unnecessary check for
3536 integer overflow, noted by Stefan Monnier in
3537 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3538 Remove a FIXME that didn't need fixing.
3539 Simplify the newly-introduced buffer reallocation code.
3540
0cae2cdb
JB
35412011-08-27 Juanma Barranquero <lekktu@gmail.com>
3542
3543 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3544
5fc295a4 35452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3546
70c60eb2 3547 Integer and memory overflow issues (Bug#9196).
726e0ab1 3548
d31850da
PE
3549 * doc.c (get_doc_string): Rework so that
3550 get_doc_string_buffer_size is the actual buffer size, rather than
3551 being 1 less than the actual buffer size; this makes xpalloc more
3552 convenient.
3553
a69fbedb
PE
3554 * image.c (x_allocate_bitmap_record, cache_image):
3555 * xselect.c (Fx_register_dnd_atom):
3556 Simplify previous changes by using xpalloc.
3557
fe5c5d37
PE
3558 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3559 since either will do and ptrdiff_t is convenient with xpalloc.
3560
0065d054
PE
3561 * charset.c (charset_table_size)
3562 (struct charset_sort_data.priority): Now ptrdiff_t.
3563 (charset_compare): Don't overflow if priorities differ greatly.
3564 (Fsort_charsets): Don't assume list length fits in int.
3565 Check for size-calculation overflow when allocating sort data.
3566 (syms_of_charset): Allocate an initial charset table that is
3567 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3568
3569 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3570
3571 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3572 The actual value is always <= INT_MAX, and leaving it unsigned made
3573 overflow checking harder.
3574
3575 * dispextern.h (struct glyph_matrix.rows_allocated)
3576 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3577 with xpalloc. The values are still always <= INT_MAX.
3578
3579 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3580
3581 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3582 (SAFE_NALLOCA): New macro.
3583
3584 * region-cache.c (struct boundary.pos, find_cache_boundary)
3585 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3586 (set_cache_region, invalidate_region_cache)
3587 (revalidate_region_cache, know_region_cache, region_cache_forward)
3588 (region_cache_backward, pp_cache):
3589 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3590 so that ptrdiff_t * can be passed to xpalloc.
3591 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3592 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3593 (pp_cache): Don't assume cache_len fits in int.
3594 * region-cache.h: Adjust extern decls to match.
3595
3596 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3597 EMACS_INT, since either will do, for xpalloc.
3598
3599 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3600 (xnmalloc, xnrealloc, xpalloc): New functions.
3601
726e0ab1
PE
3602 * bidi.c (bidi_shelve_header_size): New constant.
3603 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3604 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3605
51f30bc5 3606 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3607 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3608 (overlay_strings):
3609 Don't update size of array until after memory allocation succeeds,
3610 because xmalloc/xrealloc may not return.
0065d054
PE
3611 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3612 now that we have proper integer overflow checking.
3613 (record_overlay_string, overlay_strings): Catch overflows when
3614 calculating size of overlay_str_buf.
726e0ab1 3615
0065d054
PE
3616 * callproc.c (Fcall_process): Check for size overflow when
3617 calculating size of args2.
3618 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3619 Normally we prefer signed values, but sticking with ptrdiff_t would
3620 require adding more-complicated checks.
726e0ab1
PE
3621
3622 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3623 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3624 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3625 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3626
3627 * character.c (Fstring): Check for size-calculation overflow.
3628
3629 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3630 unnecessary integer overflow. Check for size overflow.
3631 (encode_coding_object): Don't update size until xmalloc succeeds.
3632
3633 * composite.c (get_composition_id): Check for overflow in glyph
3634 length calculations.
3635
3636 Integer and memory overflow fixes for display code.
3637 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3638 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3639 (scrolling_window): Check for overflow in size calculations.
3640 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3641 Don't assume glyph table len fits in int.
3642 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3643 (row_table_size): Now ptrdiff_t, not int.
3644 (scrolling_window): Avoid overflow in size calculations.
3645 Don't update size until allocation succeeds.
3646 * fns.c (concat): Check for overflow in size calculations.
3647 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3648 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3649 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3650
3651 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3652 (get_doc_string): Check for size calculation overflow.
3653 Don't update size until allocation succeeds.
3654 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3655 EMACS_INT, where ptrdiff_t will do.
3656 (Fsubstitute_command_keys): Check for string overflow.
3657
3658 * editfns.c (set_time_zone_rule): Don't assume environment length
3659 fits in int.
3660 (message_length): Now ptrdiff_t, not int.
3661 (Fmessage_box): Don't update size until allocation succeeds.
3662 Don't assume message length fits in int.
3663 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3664
0065d054
PE
3665 * emacs.c (main): Do not reallocate argv, since there is a null at
3666 the end that can be overwritten, and this way there's no need to
3667 worry about size-calculation overflow.
3668 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3669
3670 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3671 alloc succeeds.
3672 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3673
3674 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3675 (x_set_scroll_bar_width, x_figure_window_size):
3676 Check for integer overflow.
3677 (x_set_alpha): Do not assume XINT fits in int.
3678
3679 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3680 This is for the members text_lines, text_cols, total_lines, total_cols,
3681 where the system imposes an 'int' limit.
3682
3683 * fringe.c (Fdefine_fringe_bitmap):
3684 Don't update size until alloc works.
3685
3686 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3687 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3688
3689 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3690 Check for size-calculation overflow.
3691 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3692 do, as we prefer signed integers.
3693 (id_to_widget.max_size, id_to_widget.used)
3694 (xg_store_widget_in_map, xg_remove_widget_from_map)
3695 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3696 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3697 Use and return ptrdiff_t, not int.
3698 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3699 * gtkutil.h: Change prototypes to match the above.
3700
3701 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3702 are duplicate now that they've been promoted to lisp.h.
3703 (x_allocate_bitmap_record, x_alloc_image_color)
3704 (make_image_cache, cache_image, xpm_load):
3705 Don't update size until alloc is done.
3706 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3707 (x_detect_edges):
3256efce 3708 Check for size calculation overflow.
726e0ab1
PE
3709 (ct_colors_allocated_max): New constant.
3710 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3711 overflow.
3256efce 3712
726e0ab1
PE
3713 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3714 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3715 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3716 Use ptrdiff_t, not int, to count maps.
3717 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3718 calculations. Don't update size until allocation succeeds.
3719 Redo calculations to avoid overflow.
726e0ab1
PE
3720 * keyboard.h: Change prototypes to match the above.
3721
3722 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3723 to count maps.
3724 (current_minor_maps): Check for size calculation overflow.
3725 * keymap.h: Change prototypes to match the above.
3726
3727 * lread.c (read1, init_obarray): Don't update size until alloc done.
3728
3729 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3730 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3731
726e0ab1
PE
3732 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3733 Now ptrdiff_t, not int.
3734 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3735 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3736
3737 * process.c (Fnetwork_interface_list): Check for overflow
3738 in size calculation.
3739
3740 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3741
3742 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3743 overflow. Don't bother calling xmalloc when xrealloc will do.
3744
3745 * search.c (Freplace_match): Check for size calculation overflow.
3746 (Fset_match_data): Don't assume list lengths fit in 'int'.
3747
3748 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3749 for command line length. Do not attempt to address one before the
3750 beginning of an array, as that's not portable.
3751
3752 * term.c (max_frame_lines): Remove; unused.
3753 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3754 not int.
3755 (encode_terminal_code, calculate_costs): Check for size
3756 calculation overflow.
3757 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3758 table lengths and related sizes. Don't update size until alloc
3759 done. Redo calculations to avoid overflow.
3760 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3761
3762 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3763 subtracting pointers.
3764 (gobble_line): Check for overflow more carefully. Don't update size
3765 until alloc done.
3766
3767 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3768 Don't update size until alloc done.
3769 Redo size calculations to avoid overflow.
3770 Check for size calculation overflow.
0065d054 3771 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3772
3773 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3774 Use ptrdiff_t, not int, for sizes.
3775 (store_mode_line_noprop_char): Don't update size until alloc done.
3776
0065d054
PE
3777 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3778 Use ptrdiff_t, not int, for sizes.
3779 (Finternal_make_lisp_face, cache_face):
3780 Check for size calculation overflow.
3781 (cache_face): Treat size calculation overflows as if they were
3782 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3783
3784 * xfns.c (x_encode_text, x_set_name_internal)
3785 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3786 sizes, since they can exceed INT_MAX in size. Check for size
3787 calculation overflow.
3788
0065d054
PE
3789 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3790 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3791 Don't update size until alloc done.
3792
0065d054 3793 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3794 as sprintf is limited to int lengths.
1d526e2f 3795
252c5ee1
PE
3796 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3797 (X_LONG_MIN): New macros.
864d7ce7
PE
3798 Use them to make the following changes clearer.
3799 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3800 This change doesn't affect the value now, but it may help remind
3801 future maintainers not to raise the value too much later.
3802 (SELECTION_QUANTUM): Remove, replacing with ...
3803 (selection_quantum): ... new function, which avoids overflow.
3804 All uses changed.
3805 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3806 assumption that selection length fits in 'int'.
3807 (x_reply_selection_request, x_handle_selection_request)
3808 (x_get_window_property, receive_incremental_selection)
3809 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3810 (lisp_data_to_selection_data, clean_local_selection_data):
3811 Use ptrdiff_t, not int, to record length of selection.
3812 (x_reply_selection_request, x_get_window_property)
3813 (receive_incremental_selection, x_property_data_to_lisp):
3814 Redo calculations to avoid overflow.
3815 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3816 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3817 something.
3818 (x_get_window_property, receive_incremental_selection)
3819 (lisp_data_to_selection_data, x_property_data_to_lisp):
3820 Check for size-calculation overflow.
3821 (x_get_window_property, receive_incremental_selection)
3822 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3823 Don't store size until memory allocation succeeds.
3824 (x_get_window_property): Plug memory leak on memory exhaustion.
3825 Don't double-block input; malloc is safe here. Don't assume 2**34
3826 - 4 fits in unsigned long. Add an xassert to check
3827 XGetWindowProperty overflow. Be more careful about overflow
3828 calculations, and distinguish size from memory overflow better.
3829 (receive_incremental_selection): When tracing, don't assume
3830 unsigned int is less than INT_MAX.
3831 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3832 harmful) conversions of unsigned short to int.
3833 (lisp_data_to_selection_data): Don't assume that integers
3834 in the range -65535 through -1 fit in an X unsigned short.
3835 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3836 result parameters unless successful. Rely on cons_to_unsigned
3837 to report problems with elements; the old code wasn't right anyway.
3838 (x_check_property_data): Check for int overflow; we cannot use
3839 a wider type due to X limits.
3840 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3841
726e0ab1 3842 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3843
0065d054
PE
3844 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3845 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3846 (x_color_cells): Don't store size until memory allocation succeeds.
3847 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3848 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3849 (x_term_init): Don't assume length fits in int (sprintf is limited
3850 to int size).
bc18e09d 3851
ebfa62c0
PE
3852 Use ptrdiff_t for composition IDs.
3853 * character.c (lisp_string_width):
3854 * composite.c (composition_table_size, n_compositions)
3855 (get_composition_id, composition_gstring_from_id):
3856 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3857 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3858 * window.c (Frecenter):
3859 Use ptrdiff_t, not int, for composition IDs.
3860 * composite.c (get_composition_id): Check for integer overflow.
3861 * composite.h: Adjust prototypes to match the above changes.
3862
d3411f89
PE
3863 Use ptrdiff_t for hash table indexes.
3864 * category.c (hash_get_category_set):
3865 * ccl.c (ccl_driver):
3866 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3867 * coding.c (coding_system_charset_list, detect_coding_system):
3868 * coding.h (struct coding_system.id):
3869 * composite.c (get_composition_id, gstring_lookup_cache):
3870 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3871 * image.c (xpm_get_color_table_h):
3872 * lisp.h (hash_lookup, hash_put):
3873 * minibuf.c (Ftest_completion):
3874 Use ptrdiff_t for hash table indexes, not int (which is too
3875 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3876 32-bit --with-wide-int hosts).
3877
e097a6fa
PE
3878 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3879 Add a FIXME comment about memory leaks.
3880 (syms_of_charset): Don't assume xmalloc returns.
3881
5637687f
PE
3882 Don't assume that stated character widths fit in int.
3883 * character.c (Fchar_width, c_string_width, lisp_string_width):
3884 * character.h (CHAR_WIDTH):
3885 * indent.c (MULTIBYTE_BYTES_WIDTH):
3886 Use sanitize_char_width to avoid undefined and/or bad behavior
3887 with outlandish widths.
a66cfb1c 3888 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3889 now that we have two such functions. All uses changed.
3890 (sanitize_char_width): New inline function.
3891
a2271ba2
PE
3892 Don't assume that tab-width fits in int.
3893 * character.h (sanitize_width): New inline function.
3894 (SANE_TAB_WIDTH): New macro.
3895 (ASCII_CHAR_WIDTH): Use it.
3896 * indent.c (sane_tab_width): Remove. All uses replaced by
3897 SANE_TAB_WIDTH (current_buffer).
3898 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3899
18c52557
PE
3900 * fileio.c: Integer overflow issues with file modes.
3901 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3902
caeeedc1
PE
3903 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3904 Remove unreachable code.
3905 (read_hex, load_charset_map_from_file): Check for integer overflow.
3906
6df6ae42 3907 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3908 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3909 (x_send_scroll_bar_event): Likewise. Check that the size does not
3910 exceed limits imposed by XClientMessageEvent, as well as the usual
3911 ptrdiff_t and size_t limits.
3912
b13995db
PE
3913 * keyboard.c: Overflow, signedness and related fixes.
3914 (make_lispy_movement): Use same integer type in forward decl
3915 that is used in the definition.
3916 (read_key_sequence, keyremap_step):
3917 Change bufsize argument back to int, undoing my 2011-03-30 change.
3918 We prefer signed types, and int is wide enough here.
3919 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3920 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3921 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3922 length, not size_t. Use ptrdiff_t for index, not int.
3923 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3924 possibility of integer overflow.
3925
13464394
PE
3926 Overflow, signedness and related fixes for images.
3927
3928 * dispextern.h (struct it.stack[0].u.image.image_id)
3929 (struct_it.image_id, struct image.id, struct image_cache.size)
3930 (struct image_cache.used, struct image_cache.ref_count):
3931 * gtkutil.c (update_frame_tool_bar):
3932 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3933 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3934 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3935 * nsmenu.m (update_frame_tool_bar):
3936 * xdisp.c (calc_pixel_width_or_height):
3937 * xfns.c (image_cache_refcount):
3938 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3939 on typical 64-bit hosts.
3940
3941 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3942 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3943 Omit unnecessary casts to int.
3944 (parse_image_spec): Check that integers fall into 'int' range
3945 when the callers expect that.
3946 (image_ascent): Redo ascent calculation to avoid int overflow.
3947 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3948 (lookup_image): Remove unnecessary tests.
3949 (xbm_image_p): Locals are now of int, not EMACS_INT,
3950 since parse_image_check makes sure they fit into int.
3951 (png_load, gif_load, svg_load_image):
3952 Prefer int to unsigned where either will do.
3953 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3954 old tiff_error_handler and tiff_warning_handler.
3955 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3956 stack buffer overflows. It uses only the features of vsnprintf
3957 that are common to both POSIX and native Microsoft.
3958 (tiff_error_handler, tiff_warning_handler): Use it.
3959 (tiff_load, gif_load, imagemagick_load_image):
3960 Don't assume :index value fits in 'int'.
3961 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3962 (imagemagick_load_image): Check that crop parameters fit into
3963 the integer types that MagickCropImage accepts. Don't assume
3964 Vimagemagick_render_type has a nonnegative value. Don't assume
3965 size_t fits in 'long'.
3966 (gs_load): Use printmax_t to print the widest integers possible.
3967 Check for integer overflow when computing image height and width.
3968
c11821d4
EZ
39692011-08-26 Eli Zaretskii <eliz@gnu.org>
3970
3971 * xdisp.c (redisplay_window): Don't force window start if point
3972 will be invisible in the resulting window. (Bug#9324)
3973
0c95fcf7
EZ
39742011-08-25 Eli Zaretskii <eliz@gnu.org>
3975
3976 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3977 the display spec is of the form `(space ...)'.
3978 (handle_display_spec): Return the value returned by
3979 handle_single_display_spec, not just 1 or zero.
3980 (handle_single_display_spec): If the display spec is of the form
3981 `(space ...)', and specifies display in the text area, return 2
3982 rather than 1.
fee65a97 3983 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3984 accurately, and prefer exact match for point under bidi.
3985 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3986
3987 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3988 into disp_prop; all users changed.
3989
3990 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3991 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3992 for the text covered by the display property.
3993
e4ed06f1
CY
39942011-08-25 Chong Yidong <cyd@stupidchicken.com>
3995
3996 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3997 Change return value to nil.
3998 (Frecord_buffer): Delete unused function.
3999
f67cdd7f
EZ
40002011-08-24 Eli Zaretskii <eliz@gnu.org>
4001
5980d4c6
EZ
4002 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4003 buffers, return left-to-right.
8610fe8b
EZ
4004 (set_cursor_from_row): Consider candidate row a win if its glyph
4005 represents a newline and point is on that newline. Fixes cursor
4006 positioning on the newline at EOL of R2L text within L2R
4007 paragraph, and vice versa.
4008 (try_cursor_movement): Check continued rows, in addition to
4009 continuation rows. Fixes unwarranted scroll when point enters a
4010 continued line of R2L text within an L2R paragraph, or vice versa.
4011 (cursor_row_p): Consider the case of point being equal to
4012 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4013 from the end of a short line to the beginning of a continued line
4014 of R2L text within L2R paragraph.
4015 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4016 composed characters.
5980d4c6 4017
f67cdd7f
EZ
4018 * bidi.c (bidi_check_type): Use xassert.
4019 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4020 members.
4021
bca633fb
EZ
40222011-08-23 Eli Zaretskii <eliz@gnu.org>
4023
4024 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4025 a character.
4026
4a5885a7
CY
40272011-08-23 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * nsfont.m (ns_otf_to_script): Fix typo.
4030
0902a04e
KH
40312011-08-22 Kenichi Handa <handa@m17n.org>
4032
4033 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4034 extra slot even if the purpose is char-code-property-table.
4035
1a2e6670
EZ
40362011-08-23 Eli Zaretskii <eliz@gnu.org>
4037
8ddde651
EZ
4038 * xdisp.c (redisplay_window): When computing centering_position,
4039 account for the height of the header line. (Bug#8874)
4040
425cc014
EZ
4041 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4042 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4043 candidate is selected by the mouse, and that candidate has a
4044 composed character under the mouse.
4045
1a2e6670
EZ
4046 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4047 coordinates reported by pos-visible-in-window-p for a composed
4048 character in column zero.
4049
8b76d6f8
SM
40502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4051
4052 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4053
dac347dd
EZ
40542011-08-22 Eli Zaretskii <eliz@gnu.org>
4055
4056 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4057 consider it a hit if to_charpos is anywhere in the range of the
4058 composed buffer positions.
4059
e013fb34
CY
40602011-08-22 Chong Yidong <cyd@stupidchicken.com>
4061
4062 * image.c (gif_load): Don't assume that each subimage has the same
4063 dimensions as the base image. Handle disposal method that is
4064 "undefined" by the gif spec (Bug#9335).
4065
bd1ba3e8
CY
40662011-08-20 Chong Yidong <cyd@stupidchicken.com>
4067
4068 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4069 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4070
54a1215b
EZ
40712011-08-19 Eli Zaretskii <eliz@gnu.org>
4072
823564e5
EZ
4073 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4074 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4075 from an Org mode buffer to a Speedbar frame.
4076
54a1215b
EZ
4077 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4078 a composition, take its buffer position from IT->cmp_it.charpos.
4079 Fixes cursor positioning at the beginning of a line that begins
4080 with a composed character.
4081
9778ebcc
EZ
40822011-08-18 Eli Zaretskii <eliz@gnu.org>
4083
0be6ee06
EZ
4084 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4085 character bidirectional type, use STRONG_L instead. Fixes crashes
4086 in a buffer produced by `describe-categories'.
4087
9778ebcc
EZ
4088 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4089 members before the level stack, so they would be saved and
4090 restored when copying iterator state. Fixes incorrect reordering
4091 around TABs covered by display properties.
4092
156bffbe
AS
40932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4094
6b02f655 4095 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4096
72ad093b
CY
40972011-08-17 Chong Yidong <cyd@stupidchicken.com>
4098
4099 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4100 (internal_condition_case_2, internal_condition_case_n):
4101 Remove unnecessary aborts (Bug#9081).
72ad093b 4102
35774242
EZ
41032011-08-17 Eli Zaretskii <eliz@gnu.org>
4104
4105 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4106 has no `load' handler, try opening the file locally. (Bug#9311)
4107
db76dd85
KB
41082011-08-16 Ken Brown <kbrown@cornell.edu>
4109
4110 * gmalloc.c: Expand comment.
4111
b215eee5
EZ
41122011-08-16 Eli Zaretskii <eliz@gnu.org>
4113
4114 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4115 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4116
a4579d33
KB
41172011-08-16 Ken Brown <kbrown@cornell.edu>
4118
4119 Fix memory allocation problems in Cygwin build (Bug#9273).
4120
4121 * unexcw.c ( __malloc_initialized): Declare external variable.
4122 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4123
8b76d6f8
SM
4124 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4125 New variables.
a4579d33
KB
4126 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4127 dumped emacs.
4128 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4129 in the static heap.
4130 [CYGWIN] (special_realloc): New function.
4131 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4132 requests to realloc storage in the static heap.
4133
3ebec551
PE
41342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 * bidi.c (bidi_initialize): Remove unused local.
4137
9fd8be00
EZ
41382011-08-15 Eli Zaretskii <eliz@gnu.org>
4139
6b02f655
SM
4140 * bidimirror.h:
4141 * biditype.h: Remove file.
4142 * makefile.w32-in ($(BLD)/bidi.$(O)):
4143 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4144
4145 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4146
4147 * chartab.c: Improve commentary for the uniprop_table API.
4148
32413314
EZ
4149 * bidi.c (bidi_paragraph_init): Support zero value of
4150 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4151 (bidi_initialize): Use uniprop_table instead of including
4152 biditype.h and bidimirror.h.
32413314 4153
9fd8be00
EZ
4154 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4155 coordinates of the iterator when restoring from ppos_it.
4156 (Bug#9296)
4157
5cf2b69b
KH
41582011-08-14 Kenichi Handa <handa@m17n.org>
4159
4160 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4161 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4162
daf17d00
EZ
41632011-08-14 Eli Zaretskii <eliz@gnu.org>
4164
4165 * xdisp.c (move_it_in_display_line_to): Don't invoke
4166 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4167 ppos_it. Fixes vertical cursor motion when line beginning is
4168 covered by an image. (Bug#9296)
4169
08e3161a
JD
41702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4171
4172 * nsterm.h (ns_run_ascript): Declare.
4173 (NSAPP_DATA2_RUNASSCRIPT): Define.
4174
4175 * nsfns.m (as_script, as_result, as_status): New static variables.
4176 (ns_run_ascript): New function.
5e617bc2 4177 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4178 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4179 the event loop. Get status from as_status (Bug#7276).
4180
4181 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4182 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4183 the event loop (Bug#7276).
4184
a3720aa2
AS
41852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4186
4187 * gnutls.c (QCgnutls_bootprop_priority)
4188 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4189 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4190 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4191 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4192 (QCgnutls_bootprop_verify_hostname_error)
4193 (QCgnutls_bootprop_callbacks_verify): Rename from
4194 Qgnutls_bootprop_..., all uses changed.
4195
4196 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4197 uses changed.
4198
0a0d27fb
PE
41992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4200
19d5c50c
PE
4201 * xfaces.c (Qframe_set_background_mode): Now static.
4202 * dispextern.h (Qframe_set_background_mode): Remove decl.
4203
0a0d27fb
PE
4204 * process.c (Fnetwork_interface_info): Declare local only if needed.
4205
377538cb
JD
42062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4207
4208 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4209 (Fnetwork_interface_list): Allocate in increments of bytes instead
4210 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4211 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4212 sockaddr.
4213 (struct ifflag_def): notrailers is smart on OSX.
4214 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4215 Get hardware address with getifaddrs if available.
4216
08fff70c
EZ
42172011-08-12 Eli Zaretskii <eliz@gnu.org>
4218
4219 * xdisp.c (iterate_out_of_display_property): xassert that
4220 IT->position is set to within IT->object's boundaries. Break from
4221 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4222 when IT->position is set up wrongly due to some bug.
4223 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4224 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4225 entry. Force push_it to save on the stack the current
4226 buffer/string position, to be restored by pop_it. Fix flags in
4227 the iterator structure wrt the object coming from a display
4228 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4229 properties. (Bug#9284)
4230
7be1c708 42312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 4232
7be1c708
CY
4233 * fontset.c (fontset_get_font_group): Add proper type checks.
4234 (Bug#9172)
aac0c6e3 4235
7be1c708 42362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 4237
7be1c708
CY
4238 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4239 and LC_VERSION_MIN_MACOSX.
4240 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4241 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 4242
97bb72a6
EZ
42432011-08-08 Eli Zaretskii <eliz@gnu.org>
4244
4245 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
4246 no-display-properties-and-no-overlays under bidi display.
4247 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 4248 properties and overlays.
97bb72a6 4249
d5617611
CY
42502011-08-08 Chong Yidong <cyd@stupidchicken.com>
4251
37e11a63
CY
4252 * editfns.c (Fset_time_zone_rule): Document relationship with the
4253 setenv function.
4254
d5617611
CY
4255 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4256 the font entity extracted from the cache (Bug#8109).
4257
58872834
CY
42582011-08-07 Chong Yidong <cyd@stupidchicken.com>
4259
4260 * composite.c (autocmp_chars): Don't reset point. That is done by
4261 restore_point_unwind (Bug#5984).
4262
75bfc667
JL
42632011-08-07 Juri Linkov <juri@jurta.org>
4264
4265 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4266 to show the arg `TIME' instead of `TIMEVAL'.
4267
d1410150
EZ
42682011-08-06 Eli Zaretskii <eliz@gnu.org>
4269
4270 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4271 display property strides EOL and includes a newline, as in
4272 longlines-mode. (Bug#9254)
75b771e4
EZ
4273 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4274 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4275
4276 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4277 is non-zero, even if the data buffer is NULL. Fixes a crash in
4278 vertical-motion with longlines-mode. (Bug#9254)
4279
35928349
EZ
42802011-08-05 Eli Zaretskii <eliz@gnu.org>
4281
ec7cc85b
EZ
4282 * bidi.c <bidi_cache_total_alloc>: Now static.
4283 (bidi_initialize): Initialize bidi_cache_total_alloc.
4284
8b76d6f8 4285 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4286 cache. (Bug#9221)
4287
4288 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4289 amount allocated this far in `bidi_cache_total_alloc'.
4290 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4291 non-zero, only free the data buffer without restoring the cache
4292 contents. All callers changed.
4293
4294 * dispextern.h (bidi_unshelve_cache): Update prototype.
4295
4296 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4297 (move_it_in_display_line, move_it_to)
4298 (move_it_vertically_backward, move_it_by_lines): Replace the call
4299 to xfree to an equivalent call to bidi_unshelve_cache.
4300 (move_it_in_display_line_to): Fix logic of returning
412b6358 4301 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4302
e2e2423b
EZ
43032011-08-05 Eli Zaretskii <eliz@gnu.org>
4304
4305 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4306 came from a string character with a `cursor' property. (Bug#9229)
4307
ae9e757a
JD
43082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4309
4310 * Makefile.in (LIB_PTHREAD): New variable.
4311 (LIBES): Add LIB_PTHREAD (Bug#9216).
4312
4313 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4314 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4315
213bd7f2
AS
43162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4317
6b02f655 4318 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4319
99aaf75f
JD
43202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4321
4322 * xterm.c (x_find_topmost_parent): New function.
4323 (x_set_frame_alpha): Find topmost parent window with
4324 x_find_topmost_parent and set the property there also (bug#9181).
4325 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4326
c74e9d86
PE
43272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 * callproc.c (Fcall_process): Avoid vfork clobbering
4330 the local vars buffer, coding_systems, current_dir.
4331
640c8776
SM
43322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4333
4334 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4335
f26d0e4c
PE
43362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4337
8a10d76c
PE
4338 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4339 so that it is not optimized away.
4340
f26d0e4c
PE
4341 * xdisp.c (compute_display_string_pos): Remove unused local.
4342
55439c61
EZ
43432011-08-02 Eli Zaretskii <eliz@gnu.org>
4344
4345 Fix slow cursor motion and scrolling in large buffers with
4346 selective display, like Org Mode buffers. (Bug#9218)
4347
4348 * dispextern.h (struct bidi_it): New member disp_prop_p.
4349
4350 * xdisp.c: Remove one-slot cache of display string positions.
4351 (compute_display_string_pos): Accept an additional argument
5e617bc2 4352 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4353 for a display string or property. If found, set DISP_PROP_P
4354 non-zero.
4355
4356 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4357 DISP_PROP_P, and pass it to compute_display_string_pos.
4358 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4359 non-zero. All callers of bidi_fetch_char changed.
4360
fb33fa43
SM
43612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4362
4363 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4364
b099e063
DM
43652010-12-03 Don March <don@ohspite.net>
4366
4367 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4368 last character M-[char] is translated to ESC [char] (bug#7541).
4369
5cc7f7af
KH
43702011-08-02 Kenichi Handa <handa@m17n.org>
4371
d0fffa3f 4372 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4373
4374 * chartab.c (uniprop_table): Make it non-static.
4375
525d5e6e
EZ
43762011-08-01 Eli Zaretskii <eliz@gnu.org>
4377
4378 * xdisp.c (forward_to_next_line_start): Accept additional argument
4379 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4380 on the newline.
4381 (reseat_at_next_visible_line_start): Use the bidi iterator state
4382 returned by forward_to_next_line_start to restore the state of
4383 it->bidi_it after backing up to previous newline. (Bug#9212)
4384
31011111
AS
43852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4386
4387 * regex.c (re_comp): Protoize.
4388 (re_exec): Fix return type.
4389 (regexec): Fix type of `ret'. (Bug#9203)
4390
476371c4
PE
43912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4392
e5d76069
PE
4393 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4394 This is needed if max-image-size is a floating-point number.
4395
9a79b20c
AS
43962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4397
4398 * print.c (print_object): Print empty symbol as ##.
4399
4400 * lread.c (read1): Read ## as empty symbol.
4401
d8c2fa78
AA
44022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4403
4404 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4405 setting frame foreground color (Bug#9175).
4406 (x_set_background_color): Likewise.
4407
ffe57a7a
AA
4408 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4409 contents (Bug#9176).
4410 (EmacsTooltip -init): Remove bezels and add shadows to
4411 tooltip windows.
4412
bf3492a5
AA
4413 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4414 or scroll bar (Bug#8470).
4415
d55e9c53
AA
4416 * nsfont.m (nsfont_open): Remove assignment to voffset and
4417 unnecessary vars hshink, expand, hd, full_height, min_height.
4418 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4419
4420 * nsterm.h (nsfont_info): Remove voffset field.
4421
d8c2fa78 44222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4423
4424 Implement strike-through and overline on NextStep (Bug#8863).
4425
4426 * nsfont.m (nsfont_open): Use underline position provided by font,
4427 instead of hard-coded value of 2.
4428 (nsfont_draw): Call ns_draw_text_decoration instead.
4429
4430 * nsterm.h: Add declaration for ns_draw_text_decoration.
4431
4432 * nsterm.m (ns_draw_text_decoration): New function for drawing
4433 underline, overline, and strike-through.
4434 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4435 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4436 accommodate underlining, etc.
4843aac3 4437
4cc60b9b
EZ
44382011-07-28 Eli Zaretskii <eliz@gnu.org>
4439
bc7ece87
EZ
4440 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4441 default.
4cc60b9b 4442
476371c4
PE
44432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4444
66606eea
PE
4445 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4446 Without this fix, if a signal arrives just after memory fills up,
4447 'malloc' might be invoked reentrantly.
4448
476371c4
PE
4449 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4450 In other words, assume that every image size is allowed, on non-X
4451 hosts. This assumption is probably wrong, but it lets Emacs compile.
4452
f3fcc40d
AS
44532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4454
4455 * regex.c (re_iswctype): Convert return values to boolean.
4456
350c992f
EZ
44572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4458
4459 * xdisp.c (compute_display_string_pos): Don't use cached display
4460 string position if the buffer had its restriction changed.
4461 (Bug#9184)
4462
5266b4bb
PE
44632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4464
4465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4466
2573a837 44672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4468
41f55ccd 4469 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4470
39e378da
PE
4471 * bidi.c: Integer size and overflow fixes.
4472 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4473 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4474 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4475 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4476 (bidi_find_other_level_edge):
4477 Use ptrdiff_t instead of EMACS_INT where either will do.
4478 This works better on 32-bit hosts configured --with-wide-int.
4479 (bidi_cache_ensure_space): Check for size-calculation overflow.
4480 Use % rather than repeated addition, for better worst-case speed.
4481 Don't set bidi_cache_size until after xrealloc returns, because it
4482 might not return.
4483 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4484 (bidi_cache_ensure_space): Also check that the bidi cache size
4485 does not exceed that of the largest Lisp string or buffer. See Eli
4486 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4487
5e927815
PE
4488 * alloc.c (__malloc_size_t): Remove.
4489 All uses replaced by size_t. See Andreas Schwab's note
4490 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4491
ca4aa935
PE
4492 * image.c: Improve checking for integer overflow.
4493 (check_image_size): Assume that f is nonnull, since
4494 it is always nonnull in practice. This is one less thing to
4495 worry about when checking for integer overflow later.
4496 (x_check_image_size): New function, which checks for integer
4497 overflow issues inside X.
4498 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4499 This removes the need for a memory_full check.
4500 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4501 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4502 (xbm_read_bitmap_data): Change locals back to 'int', since
4503 their values must fit in 'int'.
4504 (xpm_load_image, png_load, tiff_load):
4505 Invoke x_create_x_image_and_pixmap earlier,
4506 to avoid much needless work if the image is too large.
4507 (tiff_load): Treat overly large images as if
4508 x_create_x_image_and_pixmap failed, not as malloc failures.
4509 (gs_load): Use x_check_image_size.
4510
5f8f9cc2
PE
4511 * gtkutil.c: Omit integer casts.
4512 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4513 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4514
5adf60bc
PE
4515 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4516
c8907a93
PE
4517 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4518 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4519 would wrongly return t on a 64-bit host.
4520
e3c25c68
PE
4521 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4522 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4523 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4524 and therefore cause GCC to emit a bogus diagnostic in some cases.
4525
3f791afe
PE
4526 * image.c: Integer signedness and overflow and related fixes.
4527 This is not an exhaustive set of fixes, but it's time to
4528 record what I've got.
4529 (lookup_pixel_color, check_image_size): Remove redundant decls.
4530 (check_image_size): Don't assume that arbitrary EMACS_INT values
4531 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4532 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4533 (tiff_load, imagemagick_load_image):
4534 Check for overflow in size calculations.
4535 (x_create_x_image_and_pixmap): Remove unnecessary test for
4536 xmalloc returning NULL; that can't happen.
4537 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4538 (xpm_color_bucket): Use better integer hashing function.
4539 (xpm_cache_color): Don't possibly over-allocate memory.
4540 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4541 (gif_memory_source):
4542 Use ptrdiff_t, not int or size_t, to record sizes.
4543 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4544 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4545 either works, as we prefer signed integers.
4546 (tiff_read_from_memory, tiff_write_from_memory):
4547 Return tsize_t, not size_t, since that's what the TIFF API wants.
4548 (tiff_read_from_memory): Don't fail simply because the read would
4549 go past EOF; instead, return a short read.
4550 (tiff_load): Omit no-longer-needed casts.
4551 (Fimagemagick_types): Don't assume size fits into 'int'.
4552
3cc5a532
PE
4553 Improve hashing quality when configured --with-wide-int.
4554 * fns.c (hash_string): New function, taken from sxhash_string.
4555 Do not discard information about ASCII character case; this
4556 discarding is no longer needed.
4557 (sxhash-string): Use it. Change sig to match it. Caller changed.
4558 * lisp.h: Declare it.
4559 * lread.c (hash_string): Remove, since we now use fns.c's version.
4560 The fns.c version returns a wider integer if --with-wide-int is
4561 specified, so this should help the quality of the hashing a bit.
4562
b312a492
PE
4563 * emacs.c: Integer overflow minor fix.
4564 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4565 Define only if GNU_LINUX.
4566 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4567
dfd153ae
PE
4568 * dispnew.c: Integer signedness and overflow fixes.
4569 Remove unnecessary forward decls, that were a maintenance hassle.
4570 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4571 All uses changed.
4572 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4573 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4574 (prepare_desired_row, line_draw_cost):
4575 Use int, not unsigned, where either works.
4576 (save_current_matrix, restore_current_matrix):
4577 Use ptrdiff_t, not size_t, where either works.
4578 (init_display): Check for overflow more accurately, and without
4579 relying on undefined behavior.
4580
a81d11a3
PE
4581 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4582 Remove, replacing with the new symbols in lisp.h. All uses changed.
4583 * fileio.c (make_temp_name):
4584 * filelock.c (lock_file_1, lock_file):
4585 * xdisp.c (message_dolog):
4586 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4587 Use pMd etc. instead.
4588 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4589 replacing the pWIDE etc. symbols removed from editfns.c.
4590
3300e6fd
PE
4591 * keyboard.h (num_input_events): Now uintmax_t.
4592 This is (very slightly) less likely to mess up due to wraparound.
4593 All uses changed.
4594
fd05c7e9
PE
4595 * buffer.c: Integer signedness fixes.
4596 (alloc_buffer_text, enlarge_buffer_text):
4597 Use ptrdiff_t rather than size_t when either will do, as we prefer
4598 signed integers.
4599
903fe15d
PE
4600 * alloc.c: Integer signedness and overflow fixes.
4601 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4602 (__malloc_size_t): Default to size_t, not to int.
4603 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4604 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4605 Prefer ptrdiff_t to size_t when either would do, as we prefer
4606 signed integers.
4607 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4608 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4609 Now const. Initialize with values that are in range even if char
4610 is signed.
4611 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4612 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4613 These functions do the right thing with sizes > 2**32.
4614 (check_depth): Now ptrdiff_t, not int.
4615 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4616 Adjust to new way of storing sizes. Check for size overflow bugs
4617 in rest of code.
4618 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4619 slightly wrong anyway, as it missed one instance of
4620 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4621 (refill_memory_reserve): Omit needless cast to size_t.
4622 (mark_object_loop_halt): Mark as externally visible.
4623
ac82cc6a
PE
4624 * xselect.c: Integer signedness and overflow fixes.
4625 (Fx_register_dnd_atom, x_handle_dnd_message):
4626 Use ptrdiff_t, not size_t, since we prefer signed.
4627 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4628 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4629 x_dnd_atoms_size and x_dnd_atoms_length.
4630
c2d1e36d
PE
4631 * doprnt.c: Prefer signed to unsigned when either works.
4632 * eval.c (verror):
4633 * doprnt.c (doprnt):
4634 * lisp.h (doprnt):
4635 * xdisp.c (vmessage):
4636 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4637 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4638 prefer signed arithmetic to avoid comparison confusion.
4639 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4640 but is a bit tricky.
4641
0e926e56
PE
4642 Assume freestanding C89 headers, string.h, stdlib.h.
4643 * data.c, doprnt.c, floatfns.c, print.c:
4644 Include float.h unconditionally.
4645 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4646 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4647 * regex.c: Likewise for stddef.h, string.h.
4648 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4649 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4650 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4651 (STDC_HEADERS): Remove obsolete defines.
4652 * sysdep.c: Include limits.h unconditionally.
4653
9cfdb3ec
PE
4654 Assume support for memcmp, memcpy, memmove, memset.
4655 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4656 * regex.c (memcmp, memcpy):
4657 Remove; we assume C89 now.
4658
4659 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4660 (__malloc_safe_bcopy): Remove; no longer needed.
4661
cf950e6b 4662 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4663 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4664 well either way, and we prefer signed to unsigned.
4665
dbf38e02
LMI
46662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4667
4668 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4669 closes the connection while we're reading (bug#9182).
4670
d6f0886c 46712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4672
d6f0886c
JD
4673 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4674 are specified (Bug#9168).
24e0f6b1 4675
2eb1f9e6
PE
46762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4679 Found by GCC static checking and --with-wide-int on a 32-bit host.
4680
22381272 46812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4682
4683 * xdisp.c (compute_display_string_pos): Fix logic of caching
4684 previous display string position. Initialize cached_prev_pos to
4685 -1. Fixes slow-down at the beginning of a buffer.
4686
f25e39b4
EZ
46872011-07-24 Eli Zaretskii <eliz@gnu.org>
4688
4689 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4690 for attrs[LFACE_FONTSET_INDEX].
4691
04c4b52e
PE
46922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4693
4694 * xml.c (parse_region): Remove unused local
4695 that was recently introduced.
4696
c1734fbd
EZ
46972011-07-23 Eli Zaretskii <eliz@gnu.org>
4698
be18c5a5
EZ
4699 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4700 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4701
c1734fbd
EZ
4702 * xdisp.c (move_it_in_display_line_to): Record the best matching
4703 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4704 exit if none of the characters scanned was an exact match.
4705 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4706 when exact match is impossible due to invisible text, and the
4707 lines are truncated.
4708
a258d627
JD
47092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4710
4711 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4712 for OSX >= 10.7.
4713
b6d5a689
EZ
47142011-07-22 Eli Zaretskii <eliz@gnu.org>
4715
0f74f785
EZ
4716 Fix a significant slow-down of cursor motion with C-n, C-p,
4717 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4718 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4719 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4720 (next_element_from_buffer): Call compute_stop_pos_backwards to
4721 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4722 base_level_stop.
4723 (reseat): Don't look for prev_stop, as that could mean a very long
4724 run.
4725 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4726 <cached_disp_overlay_modiff>: Cache for last found display string
4727 position.
551918c1 4728 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4729 about the same buffer in the same area of character positions, and
4730 the buffer wasn't changed since the time the display string
4731 position was cached.
551918c1 4732
b2d0c91a
EZ
47332011-07-22 Eli Zaretskii <eliz@gnu.org>
4734
4735 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4736 is an integer, which is important for empty lines. (Bug#9149)
4737
043604ee
CY
47382011-07-22 Chong Yidong <cyd@stupidchicken.com>
4739
4740 * frame.c (Fmodify_frame_parameters): In tty case, update the
4741 default face if necessary (Bug#4238).
4742
da4adb04
CY
47432011-07-21 Chong Yidong <cyd@stupidchicken.com>
4744
4745 * editfns.c (Fstring_to_char): No need to explain what a character
4746 is in the docstring (Bug#6576).
4747
9abd0532
LMI
47482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4749
4750 * xml.c (parse_region): Make sure we always return a tree.
4751
36881d16
HK
47522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4753
4754 * xml.c (parse_region): If a document contains only comments,
4755 return that, too.
4756
1e98674d
LMI
47572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4758
4759 * xml.c (make_dom): Return comments, too.
4760
590bd467
PE
47612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4762
4763 Port to OpenBSD.
4764 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4765 and the surrounding thread.
4766 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4767 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4768 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4769 timer goes off.
4770 * s/openbsd.h (BROKEN_SIGIO): Define.
4771 * unexelf.c (unexec) [__OpenBSD__]:
4772 Don't update the .mdebug section of the Alpha COFF symbol table.
4773
f41628b2
LMI
47742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4775
4776 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4777 (bug#8460).
4778
b59b67c5
PE
47792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4780
15e3a074
PE
4781 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4782 This fixes some race conditions on the permissions of any newly
4783 created file.
4784
41bed37d
PE
4785 * alloc.c (valid_pointer_p): Use pipe, not open.
4786 This fixes some permissions issues when debugging.
4787
b59b67c5
PE
4788 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4789 If fchown fails to set both uid and gid, try to set just gid,
4790 as that is sometimes allowed. Adjust the file's mode to eliminate
4791 setuid or setgid bits that are inappropriate if fchown fails.
4792
925a6be7
SM
47932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4794
4795 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4796 to compare Lisp_Objects.
4797 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4798 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4799 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4800
52968808
AS
48012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4802
0a6a104b
AS
4803 * lread.c (read_integer): Unread even EOF character.
4804 (read1): Likewise. Properly record start position of symbol.
4805
52968808
AS
4806 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4807 symbol character follows.
4808
9e381cdd
PE
48092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4812 This works around a problem with the previous change to Fcopy_file.
4813 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4814 and without this change, GCC might complain about discarding
4815 fchown's return value.
4816
b5641435
JB
48172011-07-16 Juanma Barranquero <lekktu@gmail.com>
4818
4819 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4820
a8031457
PE
48212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4822
4823 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4824
dd889327
LMI
48252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4826
750c33f7
LMI
4827 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4828 it's used from the C level.
4829
dd889327
LMI
4830 * process.c: Use the same condition for POLL_FOR_INPUT in both
4831 keyboard.c and process.c (bug#1858).
4832
87e86684
LM
48332011-07-09 Lawrence Mitchell <wence@gmx.li>
4834
4835 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4836 (Fgnutls_boot): Use it.
4837
64348f40
AS
48382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4839
4840 * doc.c (Fsubstitute_command_keys): Revert last change.
4841
1d698799
LMI
48422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4843
f863868c
LMI
4844 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4845 quotes the next character, and doesn't affect other longer
4846 sequences (bug#8935).
4847
1d698799
LMI
4848 * lread.c (syms_of_lread): Clarify that is isn't only
4849 `eval-buffer' and `eval-defun' that's affected by
4850 `lexical-binding' (bug#8460).
4851
aa4b6df6
EZ
48522011-07-15 Eli Zaretskii <eliz@gnu.org>
4853
4854 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4855 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4856
5d856da6
PE
48572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4858
ad6042bb
PE
4859 Fix minor problems found by static checking.
4860 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4861 (elsz): Now a signed constant, not a size_t var. We prefer signed
4862 types to unsigned, to avoid integer comparison confusion. Without
4863 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4864 "cannot optimize loop, the loop counter may overflow", a symptom
4865 of the confusion.
f00bbb22 4866 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4867 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4868
6468f31c
LMI
48692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4870
49080b10
LMI
4871 * search.c (Fre_search_backward): Mention `case-fold-search' in
4872 all the re_search_* functions (bug#8138).
4873
6468f31c
LMI
4874 * keyboard.c (Fopen_dribble_file): Document when the file is
4875 closed (bug#8056).
4876
c965adc5
EZ
48772011-07-14 Eli Zaretskii <eliz@gnu.org>
4878
df9733bf
EZ
4879 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4880 bidi_cache_idx.
4881
0bb23927
EZ
4882 Support bidi reordering of display and overlay strings.
4883 * xdisp.c (compute_display_string_pos)
4884 (compute_display_string_end): Accept additional argument STRING.
4885 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4886 (reseat_to_string): Initialize bidi_it->string.s and
4887 bidi_it->string.schars.
4888 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4889 NULL (avoids a crash in bidi_paragraph_init).
4890 Initialize itb.string.lstring.
0bb23927
EZ
4891 (init_iterator): Call bidi_init_it only of a valid
4892 buffer position was specified. Initialize paragraph_embedding to
4893 L2R.
4894 (reseat_to_string): Initialize the bidi iterator.
4895 (display_string): If we need to ignore text properties of
4896 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4897 original value of -1 will not work with bidi.)
4898 (compute_display_string_pos): First arg is now struct
4899 `text_pos *'; all callers changed. Support display properties on
4900 Lisp strings.
4901 (compute_display_string_end): Support display properties on Lisp
4902 strings.
4903 (init_iterator, reseat_1, reseat_to_string): Initialize the
4904 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4905 when iterating on a string not from display properties).
640c8776
SM
4906 (compute_display_string_pos, compute_display_string_end):
4907 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4908 arrow keys.
4909 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4910 base_level_stop; instead, set base_level_stop to BEGV.
4911 Fixes crashes in vertical-motion.
0bb23927
EZ
4912 (next_element_from_buffer): Improve commentary for when
4913 the iterator is before prev_stop.
4914 (init_iterator): Initialize bidi_p from the default value of
4915 bidi-display-reordering, not from buffer-local value. Use the
4916 buffer-local value only if initializing for buffer iteration.
4917 (handle_invisible_prop): Support invisible properties on strings
4918 that are being bidi-reordered.
4919 (set_iterator_to_next): Support bidi reordering of C strings and
4920 Lisp strings.
4921 (next_element_from_string): Support bidi reordering of Lisp
4922 strings.
4923 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4924 (display_string): Support display of R2L glyph rows.
4925 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4926 (init_iterator): Don't initialize it->bidi_p for strings
4927 here.
4928 (reseat_to_string): Initialize it->bidi_p for strings here.
4929 (next_element_from_string, next_element_from_c_string)
4930 (next_element_from_buffer): Add xassert's for correspondence
4931 between IT's object being iterated and it->bidi_it.string
4932 structure.
4933 (face_before_or_after_it_pos): Support bidi iteration.
4934 (next_element_from_c_string): Handle the case of the first string
4935 character that is not the first one in the visual order.
4936 (get_visually_first_element): New function, refactored from common
4937 parts of next_element_from_buffer, next_element_from_string, and
4938 next_element_from_c_string.
4939 (tool_bar_lines_needed, redisplay_tool_bar)
4940 (display_menu_bar): Force left-to-right direction. Add a FIXME
4941 comment for making that be controlled by a user option.
4942 (push_it, pop_it): Save and restore the state of the
4943 bidi iterator. Save and restore the bidi_p flag.
4944 (pop_it): Iterate out of display property for string iteration as
4945 well.
4946 (iterate_out_of_display_property): Support iteration over strings.
4947 (handle_single_display_spec): Set up it->bidi_it for iteration
4948 over a display string, and call bidi_init_it.
4949 (handle_single_display_spec, next_overlay_string)
4950 (get_overlay_strings_1, push_display_prop): Set up the bidi
4951 iterator for displaying display or overlay strings.
4952 (forward_to_next_line_start): Don't use the shortcut if
4953 bidi-iterating.
4954 (back_to_previous_visible_line_start): If handle_display_prop
4955 pushed the iterator stack, restore the internal state of the bidi
4956 iterator by calling bidi_pop_it same number of times.
4957 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4958 and we are bidi-iterating, don't decrement the iterator position;
4959 instead, set the first_elt flag in the bidi iterator, to produce
4960 the same effect.
4961 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4962 (push_display_prop): xassert that we are iterating a buffer.
4963 (push_it, pop_it): Save and restore paragraph_embedding member.
4964 (handle_single_display_spec, next_overlay_string)
4965 (get_overlay_strings_1, reseat_1, reseat_to_string)
4966 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4967 correctly. Don't assume unibyte strings are not bidi-reordered.
4968 (compute_display_string_pos)
4969 (compute_display_string_end): Fix handling the case of C string.
4970 (push_it, pop_it): Save and restore from_disp_prop_p.
4971 (handle_single_display_spec, push_display_prop): Set the
4972 from_disp_prop_p flag.
4973 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4974 (pop_it): Call iterate_out_of_display_property only if we are
4975 popping after iteration over a string that came from a display
4976 property. Fix a typo in popping stretch info. Add an assertion
4977 for verifying that the iterator position is in sync with the bidi
4978 iterator.
4979 (handle_single_display_spec, get_overlay_strings_1)
4980 (push_display_prop): Fix initialization of paragraph direction for
4981 string when that of the parent object is not yet determined.
4982 (reseat_1): Call bidi_init_it to resync the bidi
4983 iterator with IT's position. (Bug#7616)
4984 (find_row_edges): If ROW->start.pos gives position
4985 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4986 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4987 Reset the from_disp_prop_p flag.
4988 (SAVE_IT, RESTORE_IT): New macros.
4989 (pos_visible_p, face_before_or_after_it_pos)
4990 (back_to_previous_visible_line_start)
4991 (move_it_in_display_line_to, move_it_in_display_line)
4992 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4993 (try_scrolling, redisplay_window, display_line): Use them when
4994 saving a temporary copy of the iterator and restoring it back.
4995 (back_to_previous_visible_line_start, reseat_1)
4996 (init_iterator): Empty the bidi cache "stack".
4997 (move_it_in_display_line_to): If iterator ended up at
4998 EOL, but we never saw any buffer positions smaller than
4999 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5000 motion in bidi-reordered lines.
5001 (move_it_in_display_line_to): Record prev_method and prev_pos
5002 immediately before the call to set_iterator_to_next. Fixes cursor
5003 motion in bidi-reordered lines with stretch glyphs and strings
5004 displayed in margins. (Bug#8133) (Bug#8867)
5005 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5006 TO_CHARPOS.
640c8776
SM
5007 (pos_visible_p): Support positions in bidi-reordered lines.
5008 Save and restore bidi cache.
0bb23927
EZ
5009
5010 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5011 (bidi_paragraph_info): Delete unused struct.
5012 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5013 (bidi_cache_start): New variable.
5014 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5015 to zero.
5016 (bidi_cache_fetch_state, bidi_cache_search)
5017 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5018 (bidi_cache_find, bidi_peek_at_next_level)
5019 (bidi_level_of_next_char, bidi_find_other_level_edge)
5020 (bidi_move_to_visually_next): Compare cache index with
5021 bidi_cache_start rather than with zero.
5022 (bidi_fetch_char): Accept new argument STRING; all callers
5023 changed. Support iteration over a string. Support strings with
5024 display properties. Support unibyte strings. Fix the type of
5025 `len' according to what STRING_CHAR_AND_LENGTH expects.
5026 (bidi_paragraph_init, bidi_resolve_explicit_1)
5027 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5028 (bidi_level_of_next_char, bidi_move_to_visually_next):
5029 Support iteration over a string.
0bb23927
EZ
5030 (bidi_set_sor_type, bidi_resolve_explicit_1)
5031 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5032 can now be zero (for strings); special values 0 and -1 were
5033 changed to -1 and -2, respectively.
5034 (bidi_char_at_pos): New function.
5035 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5036 Call it instead of FETCH_MULTIBYTE_CHAR.
5037 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5038 initialized to valid values.
5039 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5040 values.
5041 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5042 the test for valid cached positions. Fix the logic for looking up
5043 the sentinel state in the cache. GCPRO the Lisp string we are
5044 iterating.
5045 (bidi_push_it, bidi_pop_it): New functions.
5046 (bidi_initialize): Initialize the bidi cache start stack pointer.
5047 (bidi_cache_ensure_space): New function, refactored from part of
5048 bidi_cache_iterator_state. Don't assume the required size is just
5049 one BIDI_CACHE_CHUNK away.
5050 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5051 (bidi_count_bytes, bidi_char_at_pos): New functions.
5052 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5053 always valid if bidi_cache_idx is valid.
5054 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5055 is valid if it's going to be used.
5056 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5057 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5058 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5059 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5060 (bidi_find_other_level_edge, bidi_cache_start_stack):
5061 All variables related to cache indices are now EMACS_INT.
c965adc5 5062
0bb23927
EZ
5063 * dispextern.h (struct bidi_string_data): New structure.
5064 (struct bidi_it): New member `string'. Make flag members be 1-bit
5065 fields, and put them last in the struct.
640c8776
SM
5066 (compute_display_string_pos, compute_display_string_end):
5067 Update prototypes.
0bb23927
EZ
5068 (bidi_push_it, bidi_pop_it): Add prototypes.
5069 (struct iterator_stack_entry): New members bidi_p,
5070 paragraph_embedding, and from_disp_prop_p.
5071 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5072 (bidi_shelve_cache, bidi_unshelve_cache):
5073 Declare prototypes.
0bb23927
EZ
5074
5075 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5076 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5077 and vector-like objects.
5078
5079 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5080 cache around display iteration.
5081
5082 * window.c (Fwindow_end, window_scroll_pixel_based)
5083 (displayed_window_lines, Frecenter): Save and restore the bidi
5084 cache around display iteration.
5085
3bbd2265
LMI
50862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5087
5088 * editfns.c (Fdelete_region): Clarify the use of the named
5089 parameters (bug#6788).
5090
adc47434
MR
50912011-07-14 Martin Rudalics <rudalics@gmx.at>
5092
5093 * indent.c (Fvertical_motion): Set and restore w->pointm when
5094 saving and restoring the window's buffer (Bug#9006).
5095
837c31f8
LMI
50962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5097
5098 * editfns.c (Fstring_to_char): Clarify just what is returned
5099 (bug#6576). Text by Eli Zaretskii.
5100
ac389d0c
JB
51012011-07-13 Juanma Barranquero <lekktu@gmail.com>
5102
5103 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5104
0be0ce47
EZ
51052011-07-13 Eli Zaretskii <eliz@gnu.org>
5106
5107 * buffer.c (mmap_find): Fix a typo.
5108
cd18e7e3
JB
51092011-07-13 Johan Bockgård <bojohan@gnu.org>
5110
5111 Fix execution of x selection hooks.
5112 * xselect.c (Qx_lost_selection_functions)
5113 (Qx_sent_selection_functions): New vars.
5114 (syms_of_xselect): DEFSYM them.
5115 (x_handle_selection_request): Pass Qx_sent_selection_functions
5116 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5117 (x_handle_selection_clear,x_clear_frame_selections):
5118 Pass Qx_lost_selection_functions rather than
5119 Vx_lost_selection_functions to Frun_hook_with_args.
5120
47ea7f44
PE
51212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5122
ac389d0c 5123 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5124 The old code sometimes used this field without initializing it.
5125
47ea7f44
PE
5126 * alloc.c (gc_sweep): Don't read past end of array.
5127 In theory, the old code could also have corrupted Emacs internals,
5128 though it'd be very unlikely.
5129
bc985c87
AS
51302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5131
5132 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5133 argument. (Bug#4026)
bc985c87 5134
0cf34688
LMI
51352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5136
b3dadd76
LMI
5137 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5138 key" (bug#4257).
5139
0cf34688
LMI
5140 * window.c (Fset_window_start): Doc fix (bug#4199).
5141 (Fset_window_hscroll): Ditto.
5142
270768cd
PE
51432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5144
077e3dda 5145 Fix minor new problems caught by GCC 4.6.1.
270768cd 5146 * term.c (init_tty): Remove unused local.
490011a6 5147 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5148 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5149 not used otherwise.
270768cd 5150
b1f58454
CY
51512011-07-12 Chong Yidong <cyd@stupidchicken.com>
5152
5153 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5154
22b9578d
LMI
51552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5156
6e70ab07
LMI
5157 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5158 are the mini-buffer and the echo area (bug#3320).
5159
22b9578d
LMI
5160 * term.c (init_tty): Remove support for supdup, c10 and perq
5161 terminals, which are no longer supported (bug#1482).
5162
8974cc9f
JB
51632011-07-10 Johan Bockgård <bojohan@gnu.org>
5164
5165 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5166
a560d974
JD
51672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5168
5169 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5170 for non-popups (Bug#3642).
5171
1dae0f0a
AS
51722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5173
268c2c36 5174 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5175 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5176 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5177 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5178 * data.c (fmod): Likewise.
5179 * dispnew.c (swap_glyphs_in_rows): Likewise.
5180 * emacs.c (memory_warning_signal): Likewise.
5181 * floatfns.c (float_error): Likewise.
5182 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5183 (otf_open, font_otf_capability, generate_otf_features)
5184 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5185 Likewise.
5186 * image.c (pbm_read_file): Likewise.
5187 * indent.c (string_display_width): Likewise.
5188 * intervals.c (check_for_interval, search_for_interval)
5189 (inc_interval_count, count_intervals, root_interval)
5190 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5191 * lread.c (defalias): Likewise.
268c2c36 5192 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5193 * regex.c (set_image_of_range_1, set_image_of_range)
5194 (regex_grow_registers): Likewise.
5195 * sysdep.c (strerror): Likewise.
5196 * termcap.c (valid_filename_p, tprint, main): Likewise.
5197 * tparam.c (main): Likewise.
5198 * unexhp9k800.c (run_time_remap, save_data_space)
5199 (update_file_ptrs, read_header, write_header, calculate_checksum)
5200 (copy_file, copy_rest, display_header): Likewise.
5201 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5202 Likewise.
5203 * xdisp.c (check_it): Likewise.
5204 * xfaces.c (register_color, unregister_color, unregister_colors):
5205 Likewise.
5206 * xfns.c (print_fontset_result): Likewise.
5207 * xrdb.c (member, fatal, main): Likewise.
5208
99033785
PE
52092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5210
5211 Fix minor problems found by static checking (Bug#9031).
5212 * chartab.c (char_table_set_range, map_sub_char_table):
5213 Remove unused locals.
5214 (uniprop_table): Now static.
5215 * composite.c (_work_char): Remove unused static var.
5216
9cb2ac56
JB
52172011-07-09 Juanma Barranquero <lekktu@gmail.com>
5218
5219 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5220
f25661f0
JD
52212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5222
5223 * gtkutil.c (qttip_cb): Remove code without function.
5224
8278c4fe
EZ
52252011-07-09 Eli Zaretskii <eliz@gnu.org>
5226
5227 * w32.c (pthread_sigmask): New stub.
5228
1692ae2d 52292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 5230
8a6ebd58 5231 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
5232 sigprocmask is portable only for single-threaded applications, and
5233 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
5234 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5235 (LIBES): Use it.
5236 * callproc.c (Fcall_process):
5237 * process.c (create_process):
5238 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5239 Use pthread_sigmask, not sigprocmask.
123403e4 5240
1b854618
JD
52412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5242
5243 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5244 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5245 wrong (Bug#8591).
5246
3fe4b549
JD
52472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5248
0ce7e563
JD
5249 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5250 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5251 (xg_hide_tooltip): Fix comment.
5252
3fe4b549
JD
5253 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5254 in registerServicesMenuSendTypes.
5255 (validRequestorForSendType): Don't check ns_return_types.
5256
5257 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5258 ns_return_type.
5259
5df75e47
JR
52602011-07-08 Jason Rumney <jasonr@gnu.org>
5261
22610910
JR
5262 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5263 SH_SHOW for hidden windows (Bug#5482).
5264
5df75e47
JR
5265 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5266 frame struct members of non-existent frames (Bug#6284).
5267
699c10bd
JD
52682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5269
4393663b
JD
5270 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5271 variable firstTime not needed on OSX >= 10.6.
5272 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5273 >= 10.5. Use setKnobProportion, setDoubleValue.
5274
5275 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5276 (MAC_OS_X_VERSION_10_5): Define if not defined.
5277 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5278 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5279 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5280
5281 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5282 cString and lossyCString on OSX >= 10.4
5283
58179cce 5284 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5285 sizeToFit on OSX >= 10.2.
5286
5287 * nsimage.m (allocInitFromFile): Don't use deprecated method
5288 bestRepresentationForDevice on OSX >= 10.6.
5289
5290 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5291 to avoid warning.
5292
5293 * emacs.c: Declare unexec_init_emacs_zone.
5294
a63e0781
JD
5295 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5296
699c10bd
JD
5297 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5298
5299 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5300 on svcsMenu (Bug#8842).
5301
5302 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5303 ns_return_types.
5304 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5305
5306 * nsterm.m (QUTF8_STRING): Declare.
5307 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5308 (validRequestorForSendType): Return type is (id).
5309 Change indexOfObjectIdenticalTo to indexOfObject.
5310 Check if we have local selection before returning self (Bug#8842).
5311 (writeSelectionToPasteboard): Put local selection into paste board
5312 if we have a local selection (Bug#8842).
5313 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5314
5315 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5316 (ns_get_local_selection): Declare.
5317
54e10184
LMI
53182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5319
9888ff71
LMI
5320 * keymap.c (describe_map_tree): Don't insert a double newline at
5321 the end of the buffer (bug#1169) and return whether we inserted
5322 something.
5323
54e10184
LMI
5324 * callint.c (Fcall_interactively): Change "reading args" to
5325 "providing args" to try to clarify what it does (bug#1010).
5326
15fa4783
KH
53272011-07-07 Kenichi Handa <handa@m17n.org>
5328
5329 * composite.c (composition_compute_stop_pos): Ignore a static
5330 composition starting before CHARPOS (Bug#8915).
5331
5332 * xdisp.c (handle_composition_prop): Likewise.
5333
a8815b00
EZ
53342011-07-07 Eli Zaretskii <eliz@gnu.org>
5335
5336 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5337 (Bug#9015)
5338
ef7b981d 53392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5340
5341 * character.h (unicode_category_t): New enum type.
5342
5343 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5344 (Qchar_code_property_table): New variable.
5345 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5346 (UNIPROP_COMPRESSED_FORM_P): New macros.
5347 (char_table_ascii): Uncompress the compressed values.
5348 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5349 Uncompress the compressed values.
ac389d0c 5350 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5351 (char_table_ref_and_range): Uncompress the compressed values.
5352 (sub_char_table_set): New arg is_uniprop. Callers changed.
5353 Uncompress the compressed values.
5354 (sub_char_table_set_range): Args changed. Callers changed.
5355 (char_table_set_range): Adjuted for the above change.
5356 (map_sub_char_table): Delete args default_val and parent. Add arg
5357 top. Give decoded values to a Lisp function.
640c8776 5358 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5359 values to a Lisp function. Gcpro more variables.
5360 (uniprop_table_uncompress)
5361 (uniprop_decode_value_run_length): New functions.
5362 (uniprop_decoder, uniprop_decoder_count): New variables.
5363 (uniprop_get_decoder, uniprop_encode_value_character)
5364 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5365 New functions.
5366 (uniprop_encoder, uniprop_encoder_count): New variables.
5367 (uniprop_get_encoder, uniprop_table)
5368 (Funicode_property_table_internal, Fget_unicode_property_internal)
5369 (Fput_unicode_property_internal): New functions.
5370 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5371 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5372 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5373 char-code-property-alist.
5374
640c8776 5375 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5376 Vunicode_category_table.
5377
640c8776 5378 * font.c (font_range): Adjust for the change of
c805dec0
KH
5379 Vunicode_category_table.
5380
76b397fb
DN
53812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5382
5383 * m/iris4d.h: Remove file, move contents ...
5384 * s/irix6-5.h: ... here.
5385
22b4128e
PE
53862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5387
5388 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5389 * alloc.c (mark_buffer):
5390 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5391 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5392 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5393 This isn't true in general, and it's particularly not true
5394 if Emacs is configured with --with-wide-int.
5395 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5396 New macros, used in the buffer.c change.
5397
869795d6
JD
53982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5399
5400 * xsettings.c: Use both GConf and GSettings if both are available.
5401 (store_config_changed_event): Add comment.
5402 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5403 (store_tool_bar_style_changed): New functions.
5e617bc2 5404 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5405 (struct xsettings): Move font inside HAVE_XFT.
5406 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5407 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5408 Move inside HAVE_XFT.
640c8776 5409 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5410 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5411 also.
5412 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5413 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5414 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5415 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5416 (parse_settings): Move check for font inside HAVE_XFT.
5417 (read_settings, apply_xft_settings): Add comment.
5418 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5419 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5420 call store_font_name_changed.
5421 (xft_settings_event): Add comment.
5422 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5423 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5424 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5425 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5426 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5427 (xsettings_get_system_font, xsettings_get_system_normal_font):
5428 Add comment.
869795d6 5429
d8ed26bd
PE
54302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5431
5432 Random fixes. E.g., (random) never returned negative values.
5433 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5434 subseconds part to the entropy, as that's a bit more random.
5435 Prefer signed to unsigned, since the signedness doesn't matter and
5436 in general we prefer signed. When given a limit, use a
5437 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5438 latter isn't right if USE_2_TAGS_FOR_INTS.
5439 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5440 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5441
cabf1cac
SM
54422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5443
5444 * textprop.c (text_property_stickiness):
5445 Obey Vtext_property_default_nonsticky.
5446 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5447 * w32fns.c (syms_of_w32fns):
5448 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5449
6e9b2be9
PE
54502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5451
5452 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5453 This is more efficient than Ffile_directory_p and avoids a minor race.
5454
90186c68
LMI
54552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5456
7c301272
LMI
5457 * buffer.c (Foverlay_put): Say what the return value is
5458 (bug#7835).
5459
c4f2d8d4
LMI
5460 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5461 is a directory before asking whether to use the file name
5462 (bug#7564).
ad637907
LMI
5463 (barf_or_query_if_file_exists): Make the "File is a directory"
5464 error be more correct.
c4f2d8d4 5465
90186c68
LMI
5466 * fns.c (Frequire): Remove the mention of the .gz files, since
5467 that's installation-specific, but keep the mention of
5468 `get-load-suffixes'.
5469
da64016e
PE
54702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5471
5472 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5473 Report string overflow if the output is too long.
5474
7d47b580
JB
54752011-07-04 Juanma Barranquero <lekktu@gmail.com>
5476
a555cb87
JB
5477 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5478 (syms_of_gnutls): Remove duplicate DEFSYM for
5479 Qgnutls_bootprop_verify_hostname_error, an error for
5480 Qgnutls_bootprop_verify_error (which is no longer used).
5481
7d47b580
JB
5482 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5483 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5484 Also (re)move comments that are misplaced or no longer relevant.
5485
1e49bfab
LMI
54862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5487
5488 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5489
1485f4c0
CY
54902011-07-03 Chong Yidong <cyd@stupidchicken.com>
5491
5492 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5493 and background color parameters if they have been changed.
5494
a9ab721e
LMI
54952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5496
5497 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5498
cf7cff57
PE
54992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5500
2e13213d
PE
5501 * xsettings.c (SYSTEM_FONT): Define only when used.
5502 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5503
cf7cff57
PE
5504 * keymap.c (access_keymap_1): Now static.
5505
7a8e04f7
CY
55062011-07-02 Chong Yidong <cyd@stupidchicken.com>
5507
5508 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5509 leave any prefix arg for the up event (Bug#1586).
5510
61352f62
LMI
55112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5512
69bb1ef7
LMI
5513 * lread.c (syms_of_lread): Mention single symbols defined by
5514 `defvar' or `defconst' (bug#7154).
5515
61352f62 5516 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5517 (Frequire): Mention get-load-suffixes.
61352f62 5518
28545e04
MR
55192011-07-02 Martin Rudalics <rudalics@gmx.at>
5520
5521 * window.h (window): Remove clone_number slot.
5522 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5523 Remove.
5524 (make_parent_window, make_window, saved_window)
5525 (Fset_window_configuration, save_window_save): Don't deal with
5526 clone numbers.
5527 * buffer.c (Qclone_number): Remove declaration.
5528 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5529
3349e122
SM
55302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5531
5532 Add multiple inheritance to keymaps.
5533 * keymap.c (Fmake_composed_keymap): New function.
5534 (Fset_keymap_parent): Simplify.
5535 (fix_submap_inheritance): Remove.
5536 (access_keymap_1): New function extracted from access_keymap to handle
5537 embedded parents and handle lists of maps.
5538 (access_keymap): Use it.
5539 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5540 (Fcopy_keymap): Handle embedded parents.
5541 (Fcommand_remapping, define_as_prefix): Simplify.
5542 (Fkey_binding): Simplify.
5543 (syms_of_keymap): Move minibuffer-local-completion-map,
5544 minibuffer-local-filename-completion-map,
5545 minibuffer-local-must-match-map, and
5546 minibuffer-local-filename-must-match-map to Elisp.
5547 (syms_of_keymap): Defsubr make-composed-keymap.
5548 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5549 (parse_menu_item): Trivial simplification.
5550
3279eb87
GM
55512011-07-01 Glenn Morris <rgm@gnu.org>
5552
5553 * Makefile.in (SETTINGS_LIBS): Fix typo.
5554
4550efdf
KI
55552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5556
5557 * coding.c (Fencode_coding_string): Record the last coding system
5558 used, as the function doc string says (bug#8738).
5559
0949d2b6
JD
55602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5561
5562 * xsettings.c (store_monospaced_changed): Take new font as arg and
5563 check for change against current_mono_font.
5564 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5565 (emacs_settings_constructor, emacs_settings_get_property)
5566 (emacs_settings_set_property, emacs_settings_class_init)
5567 (emacs_settings_init, gsettings_obj): Remove.
5568 (something_changedCB): New function for HAVE_GSETTINGS.
5569 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5570 with value as argument.
5571 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5572 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5573 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5574 "changed".
5575
5576 * xgselect.c: Add defined (HAVE_GSETTINGS).
5577 (xgselect_initialize): Ditto.
5578
5579 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5580 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5581 xg_select.
5582
bbc6b304
PE
55832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5584
5585 * eval.c (struct backtrace): Simplify and port the data structure.
5586 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5587 signed bit field, as this assumption is not portable and it makes
5588 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5589 "char debug_on_exit : 1" as this is not portable either; instead,
5590 use the portable "unsigned int debug_on_exit : 1". Remove unused
5591 member evalargs. Remove obsolete comments about cc bombing out.
5592
9851bfc5
JD
55932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5594
51bb811f 5595 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5596 Let HAVE_GSETTINGS override HAVE_GCONF.
5597 (store_monospaced_changed): New function.
5598 (EMACS_SETTINGS): A new type derived from GObject to handle
5599 GSettings notifications.
5600 (emacs_settings_constructor, emacs_settings_get_property)
5601 (emacs_settings_set_property, emacs_settings_class_init):
5602 New functions.
5603 (gsettings_client, gsettings_obj): New variables.
5604 (GSETTINGS_SCHEMA): New define.
5605 (something_changedCB): Call store_monospaced_changed.
5606 (init_gsettings): New function.
5607 (xsettings_initialize): Call init_gsettings.
5608 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5609 to NULL.
5610
640c8776 5611 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5612 GCONF_CFLAGS/LIBS.
5613
5386012d
MR
56142011-06-29 Martin Rudalics <rudalics@gmx.at>
5615
5616 * window.c (resize_root_window, grow_mini_window)
5617 (shrink_mini_window): Rename Qresize_root_window to
5618 Qwindow_resize_root_window and Qresize_root_window_vertically to
5619 Qwindow_resize_root_window_vertically.
5620
f13e0b08
PE
56212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5622
5623 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5624
94515237
JB
56252011-06-27 Juanma Barranquero <lekktu@gmail.com>
5626
5627 * makefile.w32-in: Redesign dependencies so they reflect more
5628 clearly which files are directly included by each source file,
5629 and not through other includes.
5630
e43b6e43
MR
56312011-06-27 Martin Rudalics <rudalics@gmx.at>
5632
5633 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5634 (sort_overlays, overlay_strings): When an overlay's clone number
5635 matches the window's clone number process the overlay even if
5636 the overlay's window property doesn't match the current window.
5637
d68443dc
MR
5638 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5639 (Fwindow_hchild): Rename to Fwindow_left_child.
5640 (Fwindow_next): Rename to Fwindow_next_sibling.
5641 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5642 (resize_window_check): Rename to window_resize_check.
5643 (resize_window_apply): Rename to window_resize_apply.
5644 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5645 (Fdelete_other_windows_internal, resize_frame_windows)
5646 (Fsplit_window_internal, Fdelete_window_internal)
5647 (grow_mini_window, shrink_mini_window)
5648 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5649
c7e73be5
JD
56502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5651
5652 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5653 (emacs_fixed_set_min_size): Remove.
5654 (emacs_fixed_new): Take frame as argument.
5655
5656 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5657 (_EmacsFixedPrivate): Remove minwidth/height.
5658 Add struct frame *f.
5659 (emacs_fixed_init): Initialize priv->f.
5660 (get_parent_class, emacs_fixed_set_min_size): Remove.
5661 (emacs_fixed_new): Set priv->f to argument.
5662 (emacs_fixed_get_preferred_width)
5663 (emacs_fixed_get_preferred_height): Use min_width/height from
5664 frames size_hint to set minimum and natural (Bug#8919).
5665 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5666 and use min_width/height from frames size_hint to set
5667 min_width/height (Bug#8919).
5668
5669 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5670 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5671 Fix indentation.
c7e73be5 5672
cf99dcf8
EZ
56732011-06-26 Eli Zaretskii <eliz@gnu.org>
5674
5675 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5676 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5677 called at ZV.
5678
029529ac
CY
56792011-06-26 Chong Yidong <cyd@stupidchicken.com>
5680
5681 * process.c (wait_reading_process_output): Bypass select if
5682 waiting for a cell while ignoring keyboard input, and input is
5683 pending. Suggested by Jan Djärv (Bug#8869).
5684
7a7ef429
PE
56852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 Use gnulib's dup2 module instead of rolling our own.
5688 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5689
11fdef7d 56902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5691
5692 * dispnew.c (scrolling_window): Before scrolling, turn off a
5693 mouse-highlight in the window being scrolled.
5694
cd3520a4
JB
56952011-06-24 Juanma Barranquero <lekktu@gmail.com>
5696
5697 Move DEFSYM to lisp.h and use everywhere.
5698
5699 * character.h (DEFSYM): Move declaration...
5700 * lisp.h (DEFSYM): ...here.
5701
5702 * gnutls.c:
5703 * minibuf.c:
5704 * w32menu.c:
5705 * w32proc.c:
5706 * w32select.c: Don't include character.h.
5707
5708 * alloc.c (syms_of_alloc):
5709 * buffer.c (syms_of_buffer):
5710 * bytecode.c (syms_of_bytecode):
5711 * callint.c (syms_of_callint):
5712 * casefiddle.c (syms_of_casefiddle):
5713 * casetab.c (init_casetab_once):
5714 * category.c (init_category_once, syms_of_category):
5715 * ccl.c (syms_of_ccl):
5716 * cmds.c (syms_of_cmds):
5717 * composite.c (syms_of_composite):
5718 * dbusbind.c (syms_of_dbusbind):
5719 * dired.c (syms_of_dired):
5720 * dispnew.c (syms_of_display):
5721 * doc.c (syms_of_doc):
5722 * editfns.c (syms_of_editfns):
5723 * emacs.c (syms_of_emacs):
5724 * eval.c (syms_of_eval):
5725 * fileio.c (syms_of_fileio):
5726 * fns.c (syms_of_fns):
5727 * frame.c (syms_of_frame):
5728 * fringe.c (syms_of_fringe):
5729 * insdel.c (syms_of_insdel):
5730 * keymap.c (syms_of_keymap):
5731 * lread.c (init_obarray, syms_of_lread):
5732 * macros.c (syms_of_macros):
5733 * msdos.c (syms_of_msdos):
5734 * print.c (syms_of_print):
5735 * process.c (syms_of_process):
5736 * search.c (syms_of_search):
5737 * sound.c (syms_of_sound):
5738 * syntax.c (init_syntax_once, syms_of_syntax):
5739 * terminal.c (syms_of_terminal):
5740 * textprop.c (syms_of_textprop):
5741 * undo.c (syms_of_undo):
5742 * w32.c (globals_of_w32):
5743 * window.c (syms_of_window):
5744 * xdisp.c (syms_of_xdisp):
5745 * xfaces.c (syms_of_xfaces):
5746 * xfns.c (syms_of_xfns):
5747 * xmenu.c (syms_of_xmenu):
5748 * xsettings.c (syms_of_xsettings):
5749 * xterm.c (syms_of_xterm): Use DEFSYM.
5750
4228cf16
TZ
57512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5752
cd3520a4 5753 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5754
7fcccf1e
PE
57552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5756
7efb4e0e
PE
5757 Integer and buffer overflow fixes (Bug#8873).
5758
ff5844ad
PE
5759 * print.c (printchar, strout): Check for string overflow.
5760 (PRINTPREPARE, printchar, strout):
5761 Don't set size unless allocation succeeds.
5762
90532f02
PE
5763 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5764 for sizes. Check for string overflow more accurately.
5765 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5766
6d84508d
PE
5767 * macros.c: Integer and buffer overflow fixes.
5768 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5769 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5770 Use ptrdiff_t, not int, for sizes.
5771 Don't increment bufsize until after realloc succeeds.
5772 Check for size-calculation overflow.
5773 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5774
437b2cb4
PE
5775 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5776
8b9ac8b4
PE
5777 * lread.c: Integer overflow fixes.
5778 (read_integer): Radix is now EMACS_INT, not int,
5779 to improve quality of diagnostics for out-of-range radices.
5780 Calculate buffer size correctly for out-of-range radices.
5781 (read1): Check for integer overflow in radices, and in
5782 read-circle numbers.
82cb60d3
PE
5783 (read_escape): Avoid int overflow.
5784 (Fload, openp, read_buffer_size, read1)
5785 (substitute_object_recurse, read_vector, read_list, map_obarray):
5786 Use ptrdiff_t, not int, for sizes.
5787 (read1): Use EMACS_INT, not int, for sizes.
20270765 5788 Check for size overflow.
8b9ac8b4 5789
7fcccf1e
PE
5790 * image.c (cache_image): Check for size arithmetic overflow.
5791
bfbbd7e7
PE
5792 * lread.c: Integer overflow issues.
5793 (saved_doc_string_size, saved_doc_string_length)
5794 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5795 Now ptrdiff_t, not int.
5796 (read1): Don't assume doc string length fits in int. Check for
5797 out-of-range doc string lengths.
5798 (read_list): Don't assume file position fits in int.
39019e54 5799 (read_escape): Check for hex character overflow.
bfbbd7e7 5800
4e323265
LL
58012011-06-22 Leo Liu <sdl.web@gmail.com>
5802
5803 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5804 Move to minibuffer.el.
5805
85fece3e
PE
58062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5807
20b84ce9 5808 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5809 The following patches are for when GLYPH_DEBUG && !XASSERT.
5810 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5811 * dispnew.c (flush_stdout):
5812 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5813 Mark as externally visible.
5814 * dispnew.c (check_window_matrix_pointers): Now static.
5815 * dispnew.c (window_to_frame_vpos):
5816 * xfns.c (unwind_create_frame):
5817 * xterm.c (x_check_font): Remove unused local.
5818 * scroll.c (CHECK_BOUNDS):
5819 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5820 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5821 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5822 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5823 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5824 Now static.
5825 (debug_method_add): Use va_list and vsprintf rather than relying
5826 on undefined behavior with wrong number of arguments.
5827 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5828 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5829 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5830 since we're not interested in debugging glyphs with old libraries.
5831 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5832 GCC 4.6.0's static checking.
5833
0766b489
PE
58342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5835
31fd4b32
PE
5836 Integer overflow and signedness fixes (Bug#8873).
5837 A few related buffer overrun fixes, too.
5838
b79e8648
PE
5839 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5840
0766b489
PE
5841 * dispextern.h (struct face.stipple):
5842 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5843 (x_bitmap_mask, x_allocate_bitmap_record)
5844 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5845 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5846 (x_create_bitmap_from_xpm_data):
5847 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5848 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5849 (.bitmaps_last):
5850 * xfaces.c (load_pixmap):
5851 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5852 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5853 (.bitmaps_last, struct x_output.icon_bitmap):
5854 Use ptrdiff_t, not int, for bitmap indexes.
5855 (x_allocate_bitmap_record): Check for size overflow.
5856 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5857
b081724f
PE
5858 Use ptrdiff_t, not int, for overlay counts.
5859 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5860 * editfns.c (overlays_around, get_pos_property):
5861 * textprop.c (get_char_property_and_overlay):
5862 * xdisp.c (next_overlay_change, note_mouse_highlight):
5863 * xfaces.c (face_at_buffer_position):
21514da7
PE
5864 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5865 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5866 (Fnext_overlay_change, Fprevious_overlay_change)
5867 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5868 Use ptrdiff_t, not int, for sizes.
21514da7 5869 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5870
3de73e5e
PE
5871 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5872
2606c57b
PE
5873 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5874 (x_session_initialize): Do not assume string length fits in int.
5875
aaafe47a
PE
5876 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5877 This is unlikely, but can occur if DPI is outlandish.
5878
2674ddc8 5879 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5880 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5881
28154962
PE
5882 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5883 * xrdb.c (magic_file_p, search_magic_path):
5884 Omit last arg SUFFIX; it was always 0. All callers changed.
5885 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5886
7de51af5
PE
5887 * xfont.c (xfont_match): Avoid need for strlen.
5888
25ed6cc3
PE
5889 * xfns.c: Don't assume strlen fits in int.
5890 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5891
4eab31dd
PE
5892 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5893 not unsigned long, as we prefer signed integers. All callers changed.
5894 Detect integer overflow in repeat count.
5895 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5896 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5897
171e2a58
PE
5898 * termcap.c: Don't assume sizes fit in int and never overflow.
5899 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5900 (gobble_line): Check for size-calculation overflow.
5901
ad39faca 5902 * minibuf.c (Fread_buffer):
6e5bb2dc 5903 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5904 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5905 Don't assume string length fits in int.
5906
52c61c22 5907 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5908 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5909
b5b8c9e5
PE
5910 * font.c: Don't assume string length fits in int.
5911 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5912 Use ptrdiff_t, not int.
ccd6111c
PE
5913 (font_intern_prop): Don't assume string length fits in int.
5914 Don't assume integer property fits in fixnum.
5915 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5916
882f0d81 5917 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5918 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5919 Reformulate so as not to need the command string.
5920 Invoke gzip -cd rather than gunzip, as it's more portable.
5921 (lock_info_type, lock_file_1, lock_file):
5922 Don't assume pid_t and time_t fit in unsigned long.
5923 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5924 (current_lock_owner): Prefer signed type for sizes.
5925 Use memcpy, not strncpy, where memcpy is what is really wanted.
5926 Don't assume (via atoi) that time_t and pid_t fit in int.
5927 Check for time_t and/or pid_t out of range, e.g., via a network share.
5928 Don't alloca where an auto var works fine.
5929
93f4cf88
PE
5930 * fileio.c: Fix some integer overflow issues.
5931 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5932 Don't assume string length fits in int.
5933 (directory_file_name): Don't assume string length fits in long.
5934 (make_temp_name): Don't assume pid fits in int, or that its print
5935 length is less than 20.
5936
f3e92b69
PE
5937 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5938
1bfdaf10
PE
5939 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5940
35016e9a
PE
5941 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5942
3d1e65a1
PE
5943 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5944 We prefer signed integers, even for size calculations.
5945
0b963a93
PE
5946 * emacs.c: Don't assume string length fits in 'int'.
5947 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5948 (main): Don't invoke strlen when not needed.
5949
573f4b54
PE
5950 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5951 (XD_DEBUG_MESSAGE): Don't waste a byte.
5952
989f33ba
PE
5953 * callproc.c (getenv_internal_1, getenv_internal)
5954 (Fgetenv_internal):
965d34eb
PE
5955 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5956
e4d29b33
PE
5957 * lread.c (invalid_syntax): Omit length argument.
5958 All uses changed. This doesn't fix a bug, but it simplifies the
5959 code away from its former Hollerith-constant appearance, and it's
5960 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5961 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5962
eb49b136
PE
5963 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5964 This didn't break anything, but it didn't help either.
5965 It's confusing to put a bogus integer in a place where the actual
5966 value does not matter.
9f62aeb1 5967 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5968 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5969
15375a22
PE
5970 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5971 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5972 implementation.
b61cc01c
PE
5973 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5974 We prefer signed types, and the value cannot exceed the EMACS_INT
5975 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5976 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5977 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5978 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5979
53b2623d
PE
5980 * indent.c (sane_tab_width): New function.
5981 (current_column, scan_for_column, Findent_to, position_indentation)
5982 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5983 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5984
51cab52b 5985 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5986
f2ed8a70
PE
5987 * lisp.h (lint_assume): New macro.
5988 * composite.c (composition_gstring_put_cache):
5989 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5990
abe80cc6
PE
5991 * editfns.c, insdel.c:
5992 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5993
b02c740e
PE
5994 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5995
ebc96716
PE
5996 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5997
b4e50fa0 5998 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5999 Use much-faster test for byte-length change.
311d5d7c 6000 Don't assume string byte-length fits in 'int'.
a4cf38e4 6001 Check that character arg fits in 'int'.
85461888 6002 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6003
c0c1ee9f
PE
6004 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6005
a498d7f4
PE
6006 * fns.c (concat): Catch string overflow earlier.
6007 Do not rely on integer wraparound.
6008
51cab52b
PE
6009 * dispextern.h (struct it.overlay_strings_charpos)
6010 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6011 * xdisp.c (forward_to_next_line_start)
6012 (back_to_previous_visible_line_start)
6013 (reseat_at_next_visible_line_start, next_element_from_buffer):
6014 Don't arbitrarily truncate the value of 'selective' to int.
6015
76031fad
PE
6016 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6017
5eb55db9
PE
6018 * composite.c: Don't truncate sizes to 'int'.
6019 (composition_gstring_p, composition_reseat_it)
6020 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6021 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6022 not EMACS_UINT, for indexes.
5eb55db9 6023
0703a717
PE
6024 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6025
d6202519
PE
6026 * buffer.c: Include <verify.h>.
6027 (struct sortvec.priority, struct sortstr.priority):
8961a454 6028 Now EMACS_INT, not int.
c20998a7 6029 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6030 (struct sortstr.size, record_overlay_string)
6031 (struct sortstrlist.size, struct sortlist.used):
6032 Don't truncate size to int.
6033 (record_overlay_string): Check for size-calculation overflow.
d6202519 6034 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6035
d5a19415
JM
60362011-06-22 Jim Meyering <meyering@redhat.com>
6037
029529ac 6038 Don't leak an XBM-image-sized buffer
d5a19415
JM
6039 * image.c (xbm_load): Free the image buffer after using it.
6040
a9041e6c
PE
60412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6042
6043 Port to Sun C.
6044 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6045 that Sun C diagnosed.
6046 * fns.c (secure_hash): Fix pointer signedness issue.
6047 * intervals.c (static_offset_intervals): New function.
6048 (offset_intervals): Use it.
6049
7f3f739f
LL
60502011-06-21 Leo Liu <sdl.web@gmail.com>
6051
6052 * deps.mk (fns.o):
6053 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6054 sha512.h.
6055
6056 * fns.c (secure_hash): Rename from crypto_hash_function and change
6057 the first arg to accept symbols.
5b66d427 6058 (Fsecure_hash): New primitive.
7f3f739f
LL
6059 (syms_of_fns): New symbols.
6060
76147d94
DD
60612011-06-20 Deniz Dogan <deniz@dogan.se>
6062
6063 * process.c (Fset_process_buffer): Clarify return value in
6064 docstring.
6065
7d7d0045
CY
60662011-06-18 Chong Yidong <cyd@stupidchicken.com>
6067
6068 * dispnew.c (add_window_display_history): Use BVAR.
6069
6070 * xdisp.c (debug_method_add): Use BVAR.
6071 (check_window_end, dump_glyph_matrix, dump_glyph)
6072 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6073
6074 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6075 Likewise.
6076
6077 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6078 check till after the cache is created in init_frame_faces.
6079
ff2bc410
SM
60802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6081
6082 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6083
28177add
PE
60842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6085
dd3482fe
PE
6086 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6087 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6088 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6089
393d71f3 6090 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6091 * fileio.c (Finsert_file_contents):
6092 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6093 Remove the old (too-loose) buffer overflow checks.
6094 They weren't needed, since make_gap checks for buffer overflow.
6095 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6096 The old code merely checked for Emacs fixnum overflow, and relied
6097 on undefined (wraparound) behavior. The new code avoids undefined
6098 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6099
2e6813b0 6100 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6101 Tune. Don't use wider integers than needed. Don't use alloca.
6102 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6103
599a9e4f
PE
6104 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6105
99561444
PE
6106 * insdel.c, lisp.h (buffer_overflow): New function.
6107 (insert_from_buffer_1, replace_range, replace_range_2):
6108 * insdel.c (make_gap_larger):
6109 * editfns.c (Finsert_char):
6110 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6111
28177add
PE
6112 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6113
e69dafad
PE
61142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6115
4baa020d 6116 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6117
b1c46f02
PE
6118 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6119 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6120
e69dafad
PE
6121 * fileio.c: Don't assume EMACS_INT fits in off_t.
6122 (emacs_lseek): New static function.
6123 (Finsert_file_contents, Fwrite_region): Use it.
6124 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6125
566684ea
PE
6126 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6127
e6966cd6
PE
6128 * fns.c: Don't overflow int when computing a list length.
6129 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6130 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6131 truncation on 64-bit hosts. Check for QUIT every
6132 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6133 faster and is responsive enough.
6134 (Flength): Report an error instead of overflowing an integer.
6135 (Fsafe_length): Return a float if the value is not representable
6136 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6137 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6138 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6139
dd0b0efb
PE
6140 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6141 (header_size, word_size): New constants.
6142 (allocate_vectorlike): Don't check size overflow here.
6143 (allocate_vector): Check it here instead, since this is the only
6144 caller of allocate_vectorlike that could cause overflow.
6145 Check that the new vector's length is representable as a fixnum.
6146
86fe5cfe
PE
6147 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6148 The previous code was bogus. For example, next_almost_prime (32)
6149 returned 39, which is undesirable as it is a multiple of 3; and
6150 next_almost_prime (24) returned 25, which is a multiple of 5 so
6151 why was the code bothering to check for multiples of 7?
6152
80e88859
PE
6153 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6154
4a2f0ad6
PE
6155 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6156
f66c7cf8
PE
6157 Variadic C functions now count arguments with ptrdiff_t.
6158 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6159 Back then I didn't know that the Emacs coding style prefers signed int.
6160 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6161 were being counted with int, which may truncate counts on 64-bit
6162 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6163 * lisp.h (struct Lisp_Subr.function.aMANY)
6164 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6165 Arg counts are now ptrdiff_t, not size_t.
6166 All variadic functions and their callers changed accordingly.
6167 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6168 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6169 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6170 * callint.c (Fcall_interactively): Check arg count for overflow,
6171 to avoid potential buffer overrun. Use signed char, not 'int',
6172 for 'varies' array, so that we needn't bother to check its size
6173 calculation for overflow.
6174 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6175 * eval.c (apply_lambda):
6176 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6177 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6178 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6179
a1759b76
PE
6180 * callint.c (Fcall_interactively): Don't use index var as event count.
6181
d96be9fc
PE
6182 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6183 * mem-limits.h (SIZE): Remove; no longer used.
6184
a690a978 6185 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6186
578c21e6
PE
6187 Remove unnecessary casts.
6188 * xterm.c (x_term_init):
6189 * xfns.c (x_set_border_pixel):
6190 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6191 These aren't needed now that we assume ANSI C.
6192
96f53c6c
PE
6193 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6194 It's more likely to cause problems (due to unsigned overflow)
6195 than to cure them.
6196
83c77d31
PE
6197 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6198
ee2079f1
PE
6199 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6200
6da65536
PE
6201 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6202
7147c4a4
PE
6203 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6204
193e32d9
PE
6205 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6206
e5533da6
PE
6207 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6208
9910e595
PE
6209 GLYPH_CODE_FACE returns EMACS_INT, not int.
6210 * dispextern.h (merge_faces):
6211 * xfaces.c (merge_faces):
01103c44
PE
6212 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6213 Don't assume EMACS_INT fits in int.
9910e595 6214
2638320e
PE
6215 * character.h (CHAR_VALID_P): Remove unused parameter.
6216 * fontset.c, lisp.h, xdisp.c: All uses changed.
6217
045eb8d9
PE
6218 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6219
c1f134b5
PE
6220 * fns.c (concat): Minor tuning based on overflow analysis.
6221 This doesn't fix any bugs. Use int to hold character, instead
6222 of constantly refetching from Emacs object. Use XFASTINT, not
6223 XINT, for value known to be a character. Don't bother comparing
6224 a single byte to 0400, as it's always less.
6225
395fcb93 6226 * floatfns.c (Fexpt):
327eeec8
PE
6227 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6228
abbd3d23
PE
6229 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6230 for characters.
6231
684a03ef
PE
6232 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6233
0fed43f3
PE
6234 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6235 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6236 incorrectly succeed when S was a string, because 4294967386 was
6237 truncated before it was used.
6238
8fd02eb7
PE
6239 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6240 Otherwise, an out-of-range integer could cause undefined behavior
6241 on a 64-bit host.
6242
f8c86b69
PE
6243 * composite.c: Use int, not EMACS_INT, for characters.
6244 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6245 EMACS_INT, for values that are known to be in character range.
6246 This doesn't fix any bugs but is the usual style inside Emacs and
6247 may generate better code on 32-bit machines.
6248
34206dd2
PE
6249 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6250 This is for reasons similar to the recent CHAR_STRING fix.
6251 * charset.c (Fencode_char): Check that character arg is actually
6252 a character. Pass an int to ENCODE_CHAR.
6253 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6254 wider than 'int', as a compile-time check to prevent future regressions
6255 in this area.
6256
c5958d4c 6257 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
6258
6259 Make sure a 64-bit char is never passed to CHAR_STRING.
6260 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6261 by silently ignoring the top 32 bits, allowing some values
6262 that were far too large to be valid characters.
6263 * character.h: Include <verify.h>.
6264 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6265 arguments are no wider than unsigned, as a compile-time check
6266 to prevent future regressions in this area.
6267 * data.c (Faset):
01103c44 6268 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6269 (Fsubst_char_in_region):
6270 * fns.c (concat):
6271 * xdisp.c (decode_mode_spec_coding):
6272 Adjust to CHAR_STRING's new requirement.
6273 * editfns.c (Finsert_char, Fsubst_char_in_region):
6274 * fns.c (concat): Check that character args are actually
6275 characters. Without this test, these functions did the wrong
6276 thing with wildly out-of-range values on 64-bit hosts.
6277
d37ca623
PE
6278 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6279 These casts should not be needed on 32-bit hosts, either.
6280 * keyboard.c (read_char):
6281 * lread.c (Fload): Remove casts to unsigned.
6282
ea204efb
PE
6283 * lisp.h (UNSIGNED_CMP): New macro.
6284 This fixes comparison bugs on 64-bit hosts.
6285 (ASCII_CHAR_P): Use it.
6286 * casefiddle.c (casify_object):
01103c44 6287 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6288 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6289 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6290 * dispextern.h (FACE_FROM_ID):
6291 * keyboard.c (read_char): Use UNSIGNED_CMP.
6292
41cb286c
PE
6293 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6294 not to EMACS_INT, to avoid GCC warning.
6295
4a1b9832
PE
6296 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6297
55daad71
PE
6298 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6299 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6300 isn't needed on 32-bit machines.
8f95c75c 6301
01103c44
PE
6302 * buffer.c (Fgenerate_new_buffer_name):
6303 Use EMACS_INT for count, not int.
0ceccced 6304 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6305
6306 * data.c (Qcompiled_function): Now static.
6307
c6f072e7
PE
6308 * window.c (window_body_lines): Now static.
6309
20ce5912
PE
6310 * image.c (gif_load): Rename local to avoid shadowing.
6311
9c4c5f81
PE
6312 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6313 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6314 * alloc.c (make_save_value): Integer argument is now of type
6315 ptrdiff_t, not int.
6316 (mark_object): Use ptrdiff_t, not int.
6317 * lisp.h (pD): New macro.
6318 * print.c (print_object): Use it.
6319
c0c5c8ae
PE
6320 * alloc.c: Use EMACS_INT, not int, to count objects.
6321 (total_conses, total_markers, total_symbols, total_vector_size)
6322 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6323 (total_free_floats, total_floats, total_free_intervals)
6324 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6325 Now EMACS_INT, not int. All uses changed.
6326 (Fgarbage_collect): Compute overall total using a double, so that
6327 integer overflow is less likely to be a problem. Check for overflow
6328 when converting back to an integer.
5a25e253
PE
6329 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6330 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6331 These were 'int' variables that could overflow on 64-bit hosts;
6332 they were never used, so remove them instead of repairing them.
211a0b2a 6333 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6334 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6335 Previously, this ceilinged at INT_MAX, but that doesn't work on
6336 64-bit machines.
e46bb31a 6337 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6338
c78baabf 6339 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6340 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6341 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6342 when a (possibly-narrower) signed value would do just as well.
6343 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6344
c9d624c6
PE
6345 * alloc.c: Catch some string size overflows that we were missing.
6346 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6347 for convenience in STRING_BYTES_MAX.
6348 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6349 The definition here is exact; the one in lisp.h was approximate.
6350 (allocate_string_data): Check for string overflow. This catches
6351 some instances we weren't catching before. Also, it catches
6352 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6353 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6354 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6355
c9d624c6
PE
6356 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6357 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6358 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6359
353032ce
PE
6360 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6361
2bccce07
PE
6362 * alloc.c (Fmake_string): Check for out-of-range init.
6363
0ac30604
SM
63642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6365
6366 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6367
c195f2de
JD
63682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6369
6370 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6371 xg_get_default_scrollbar_width.
6372
6373 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6374 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6375 (style_changed_cb): Call update_theme_scrollbar_width and call
6376 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6377 all frames (Bug#8505).
6378 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6379 Call gtk_window_set_resizable if HAVE_GTK3.
6380 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6381 and height if HAVE_GTK3 (Bug#8505).
6382 (scroll_bar_width_for_theme): New variable.
6383 (update_theme_scrollbar_width): New function.
6384 (xg_get_default_scrollbar_width): Move code to
6385 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6386 (xg_initialize): Call update_theme_scrollbar_width.
6387
6388 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6389
6390 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6391
e10ac9f1
MR
63922011-06-12 Martin Rudalics <rudalics@gmx.at>
6393
6394 * frame.c (make_frame): Call other_buffer_safely instead of
6395 other_buffer.
6396
6397 * window.c (temp_output_buffer_show): Call display_buffer with
6398 second argument Vtemp_buffer_show_specifiers and reset latter
6399 immediately after the call.
6400 (Vtemp_buffer_show_specifiers): New variable.
6401 (auto_window_vscroll_p, next_screen_context_lines)
6402 (Vscroll_preserve_screen_position): Remove leading asterisks from
6403 doc-strings.
6404
2d3c217e 64052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6406
7b7f97e8 6407 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6408 * buffer.c (Qclone_number): Remove for now, as it's unused.
6409 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6410 (record_buffer): Remove unused local.
6411 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6412 (set_frame_buffer_list): Remove; unused.
6413 * frame.h (other_visible_frames): Remove decl.
6414 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6415 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6416 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6417 if HAVE_GPM.
6418 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6419 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6420 Define only if HAVE_GPM.
6421 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6422 (update_hints_inhibit): Remove; never set. All uses removed.
6423 * widgetprv.h (emacsFrameClassRec): Remove decl.
6424 * window.c (delete_deletable_window): Now returns void, since it
6425 wasn't returning anything.
6426 (compare_window_configurations): Remove unused locals.
6427 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6428 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6429 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6430 the same widths as pointers. This follows up on the 2011-05-06 patch.
6431 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6432 * xterm.h: Likewise.
6433 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6434
1384b89e
JB
64352011-06-12 Juanma Barranquero <lekktu@gmail.com>
6436
6437 * makefile.w32-in: Update dependencies.
6438 (LISP_H): Add lib/intprops.h.
6439
1100a63c
CY
64402011-06-11 Chong Yidong <cyd@stupidchicken.com>
6441
6442 * image.c (gif_load): Add animation frame delay to the metadata.
6443 (syms_of_image): Use DEFSYM. New symbol `delay'.
6444
6198ccd0
MR
64452011-06-11 Martin Rudalics <rudalics@gmx.at>
6446
6447 * window.c (delete_deletable_window): Re-add.
6448 (Fset_window_configuration): Rewrite to handle dead buffers and
6449 consequently deletable windows.
6450 (window_tree, Fwindow_tree): Remove. Supply functionality in
6451 window.el.
6452 (compare_window_configurations): Simplify code.
6453
b6e3633c
AS
64542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6455
1ab0dee5
AS
6456 * image.c (imagemagick_load_image): Fix type mismatch.
6457 (Fimagemagick_types): Likewise.
6458
b6e3633c
AS
6459 * window.h (replace_buffer_in_windows): Declare.
6460
9397e56f
MR
64612011-06-11 Martin Rudalics <rudalics@gmx.at>
6462
6463 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6464 Qclone_number. Remove external declaration of Qdelete_window.
6465 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6466 code.
640c8776
SM
6467 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6468 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6469 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6470 buffer list implementation.
6471 (other_buffer_safely): New function.
6472 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6473 calls to replace_buffer_in_windows and
6474 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6475 if allowed.
6476 (record_buffer): Inhibit quitting and rewrite using quittable
6477 functions. Run Qbuffer_list_update_hook if allowed.
6478 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6479 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6480 Move switch-to-buffer to window.el.
9397e56f
MR
6481 (bury-buffer): Move to window.el.
6482 (Vbuffer_list_update_hook): New variable.
6483
6484 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6485 section.
6486
6487 * window.h (resize_frame_windows): Move up in code.
6488 (Fwindow_frame): Remove EXFUN.
6489 (replace_buffer_in_all_windows): Remove prototype.
6490 (replace_buffer_in_windows_safely): Add prototype.
6491
6492 * window.c: Declare Qdelete_window static again. Move down
6493 declaration of select_count.
6494 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6495 (Fother_window): Move to window.el.
6496 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6497 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6498 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6499 window.el.
6500 (replace_buffer_in_windows): Implement by calling
6501 Qreplace_buffer_in_windows.
6502 (replace_buffer_in_all_windows): Remove with some functionality
6503 moved into replace_buffer_in_windows_safely.
6504 (replace_buffer_in_windows_safely): New function.
6505 (select_window_norecord, select_frame_norecord): Move in front
6506 of run_window_configuration_change_hook. Remove now obsolete
6507 declarations.
640c8776
SM
6508 (Fset_window_buffer): Rewrite doc-string.
6509 Call Qrecord_window_buffer.
9397e56f
MR
6510 (keys_of_window): Move binding for other-window to window.el.
6511
b50691aa
CY
65122011-06-11 Chong Yidong <cyd@stupidchicken.com>
6513
6514 * dispextern.h (struct image): Replace data member, whose int_val
6515 and ptr_val fields were not used by anything, with a single
6516 lisp_val object.
6517
6518 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6519 (gif_clear_image, gif_load, imagemagick_load_image)
6520 (gs_clear_image, gs_load): Callers changed.
6521
3f754b86
PE
65222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6523
cca69397
PE
6524 * buffer.h: Include <time.h>, for time_t.
6525 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6526
109e28d0
PE
6527 Fix minor problems found by static checking.
6528
60737f02
PE
6529 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6530
4b66faf3
PE
6531 Make identifiers static if they are not used in other modules.
6532 * data.c (Qcompiled_function, Qframe, Qvector):
6533 * image.c (QimageMagick, Qsvg):
6534 * minibuf.c (Qmetadata):
6535 * window.c (resize_window_check, resize_root_window): Now static.
6536 * window.h (resize_window_check, resize_root_window): Remove decls.
6537
109e28d0
PE
6538 * window.c (window_deletion_count, delete_deletable_window):
6539 Remove; unused.
46a4ce9e
PE
6540 (window_body_lines): Now static.
6541 (Fdelete_other_windows_internal): Mark vars as initialized.
6542 Make sure 'resize_failed' is initialized.
6543 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6544 (resize_window_apply): Remove unused local.
6545 * window.h (delete_deletable_window): Remove decl.
6546
109e28d0 6547 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6548 (imagemagick_load_image): Fix pointer signedness problem by changing
6549 last arg from unsigned char * to char *. All uses changed.
6550 Also, fix a local for similar reasons.
6551 Remove unused locals. Remove locals to avoid shadowing.
6552 (fn_rsvg_handle_free): Remove; unused.
6553 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6554 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6555
3f754b86
PE
6556 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6557
2547adb1
CY
65582011-06-10 Chong Yidong <cyd@stupidchicken.com>
6559
6560 * image.c (gif_load): Fix omitted cast error introduced by
6561 2011-06-06 change.
6562
2c8e37d4
MR
65632011-06-10 Martin Rudalics <rudalics@gmx.at>
6564
6565 * window.h (resize_proportionally, orig_total_lines)
6566 (orig_top_line): Remove from window structure.
6567 (set_window_height, set_window_width, change_window_heights)
6568 (Fdelete_window): Remove prototypes.
6569 (resize_frame_windows): Remove duplicate declaration.
6570
440a42e3
EZ
65712011-06-10 Eli Zaretskii <eliz@gnu.org>
6572
6573 * window.h (resize_frame_windows, resize_window_check)
6574 (delete_deletable_window, resize_root_window)
6575 (resize_frame_windows): Declare prototypes.
6576
6577 * window.c (resize_window_apply): Make definition be "static" to
6578 match the prototype.
6579
562dd5e9
MR
65802011-06-10 Martin Rudalics <rudalics@gmx.at>
6581
6582 * window.c: Remove declarations of Qwindow_size_fixed,
6583 window_min_size_1, window_min_size_2, window_min_size,
6584 size_window, window_fixed_size_p, enlarge_window, delete_window.
6585 Remove static from declaration of Qdelete_window, it's
6586 temporarily needed by Fbury_buffer.
6587 (replace_window): Don't assign orig_top_line and
6588 orig_total_lines.
6589 (Fdelete_window, delete_window): Remove. Window deletion is
6590 handled by window.el.
640c8776
SM
6591 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6592 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6593 (Fdelete_other_windows): Remove. Deleting other windows is
6594 handled by window.el.
6595 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6596 handled in window.el.
6597 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6598 Window minimum sizes are handled in window.el.
6599 (shrink_windows, size_window, set_window_height)
6600 (set_window_width, change_window_heights, window_height)
6601 (window_width, CURBEG, CURSIZE, enlarge_window)
6602 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6603 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6604 handled in window.el.
6605 (make_dummy_parent): Rename to make_parent_window and give it a
6606 second argument horflag.
6607 (make_window): Don't set resize_proportionally any more.
6608 (Fsplit_window): Remove. Windows are split in window.el.
6609 (save_restore_action, save_restore_orig_size)
6610 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6611 Resize mini windows in window.el.
6612 (grow_mini_window, shrink_mini_window): Implement by calling
6613 Qresize_root_window_vertically, resize_window_check and
6614 resize_window_apply.
640c8776
SM
6615 (saved_window, Fset_window_configuration, save_window_save):
6616 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6617 resize_proportionally.
6618 (window_min_height, window_min_width): Move to window.el.
6619 (keys_of_window): Move bindings for delete-other-windows,
6620 split-window, delete-window and enlarge-window to window.el.
6621
6622 * buffer.c: Temporarily extern Qdelete_window.
6623 (Fbury_buffer): Temporarily call Qdelete_window instead of
6624 Fdelete_window (Fbury_buffer will move to window.el soon).
6625
6626 * frame.c (set_menu_bar_lines_1): Remove code handling
6627 orig_top_line and orig_total_lines.
6628
6629 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6630 set_window_height but set heights directly.
6631 (change_frame_size_1): Use resize_frame_windows.
6632
6633 * xdisp.c (init_xdisp): Don't use set_window_height but set
6634 heights directly.
6635
640c8776
SM
6636 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6637 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6638 run_window_configuration_change_hook.
6639
6640 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6641 instead of change_window_heights and run
6642 run_window_configuration_change_hook.
6643
1a13852e
MR
66442011-06-09 Martin Rudalics <rudalics@gmx.at>
6645
6646 * window.c (replace_window): Rename second argument REPLACEMENT to
6647 NEW. New third argument SETFLAG. Rewrite.
6648 (delete_window, make_dummy_parent): Call replace_window with
6649 third argument 1.
6650 (window_list_1): Move down in code.
6651 (run_window_configuration_change_hook): Move set_buffer part
6652 before select_frame_norecord part in order to unwind correctly.
6653 Rename count1 to count.
6654 (recombine_windows, delete_deletable_window, resize_root_window)
6655 (Fdelete_other_windows_internal)
6656 (Frun_window_configuration_change_hook, make_parent_window)
6657 (resize_window_check, resize_window_apply, Fresize_window_apply)
6658 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6659 (Fdelete_window_internal, Fresize_mini_window_internal):
6660 New functions.
1a13852e
MR
6661 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6662
f3d1777e
MR
66632011-06-08 Martin Rudalics <rudalics@gmx.at>
6664
496e208e
MR
6665 * window.h (window): Add some new members to window structure -
6666 normal_lines, normal_cols, new_total, new_normal, clone_number,
6667 splits, nest, prev_buffers, next_buffers.
6668 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6669 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6670
f3d1777e
MR
6671 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6672 Remove.
496e208e
MR
6673 (make_dummy_parent): Set new members of windows structure.
6674 (make_window): Move down in code. Handle new members of window
6675 structure.
6676 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6677 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6678 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6679 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6680 (Fset_window_next_buffers, Fset_window_clone_number):
6681 New functions.
496e208e
MR
6682 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6683 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6684 Doc-string fixes.
6685 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6686 Argument WINDOW can be now internal window too.
6687 (Fwindow_use_time): Move up in code.
6688 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6689 Rewrite doc-string.
6690 (Fset_window_configuration, saved_window)
6691 (Fcurrent_window_configuration, save_window_save): Handle new
6692 members of window structure.
b9e809c2
MR
6693 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6694 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6695 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6696 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6697 Qget_mru_window, Qresize_root_window,
6698 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6699 Qauto_buffer_name; staticpro them.
f3d1777e 6700
abde8f8c
MR
67012011-06-07 Martin Rudalics <rudalics@gmx.at>
6702
6703 * window.c (Fwindow_total_size, Fwindow_left_column)
6704 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6705 (Fwindow_list_1): New functions.
6706 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6707 (Fwindow_width, Fscroll_left, Fscroll_right):
6708 Use window_body_cols instead of window_box_text_cols.
6709 (delete_window, Fset_window_configuration):
6710 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6711 (delete_all_subwindows): Take a window as argument and not a
6712 structure. Rewrite.
190b47e6
MR
6713 (window_loop): Remove handling of GET_LRU_WINDOW and
6714 GET_LARGEST_WINDOW.
6715 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6716
6717 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6718 window_box_text_cols. delete_all_subwindows now takes a
6719 Lisp_Object as argument.
abde8f8c 6720
640c8776
SM
6721 * indent.c (compute_motion, Fcompute_motion):
6722 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6723
fa8a67e6
MR
6724 * frame.c (delete_frame): Call delete_all_subwindows with root
6725 window as argument.
6726
a54e3482
DC
67272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6728
6729 * fns.c (Fputhash): Document return value.
6730
60002bf5
CY
67312011-06-06 Chong Yidong <cyd@stupidchicken.com>
6732
6733 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6734
0c671da6 67352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6736
b862a52a 6737 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6738
be44ca6c
PE
6739 Check for overflow when converting integer to cons and back.
6740 * charset.c (Fdefine_charset_internal, Fdecode_char):
6741 Use cons_to_unsigned to catch overflow.
6742 (Fencode_char): Use INTEGER_TO_CONS.
6743 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6744 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6745 * data.c (long_to_cons, cons_to_long): Remove.
6746 (cons_to_unsigned, cons_to_signed): New functions.
6747 These signal an error for invalid or out-of-range values.
6748 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6749 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6750 * font.c (Ffont_variation_glyphs):
6751 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6752 * lisp.h: Include <intprops.h>.
6753 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6754 (cons_to_signed, cons_to_unsigned): New decls.
6755 (long_to_cons, cons_to_long): Remove decls.
6756 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6757 (Fprimitive_undo): Use CONS_TO_INTEGER.
6758 * xfns.c (Fx_window_property): Likewise.
6759 * xselect.c: Include <limits.h>.
6760 (x_own_selection, selection_data_to_lisp_data):
6761 Use INTEGER_TO_CONS.
6762 (x_handle_selection_request, x_handle_selection_clear)
6763 (x_get_foreign_selection, Fx_disown_selection_internal)
6764 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6765 (lisp_data_to_selection_data): Use cons_to_unsigned.
6766 (x_fill_property_data): Use cons_to_signed.
6767 Report values out of range.
6768
d1f3d2af
PE
6769 Check for buffer and string overflow more precisely.
6770 * buffer.h (BUF_BYTES_MAX): New macro.
6771 * lisp.h (STRING_BYTES_MAX): New macro.
6772 * alloc.c (Fmake_string):
6773 * character.c (string_escape_byte8):
6774 * coding.c (coding_alloc_by_realloc):
6775 * doprnt.c (doprnt):
6776 * editfns.c (Fformat):
6777 * eval.c (verror):
6778 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6779 since they may not be the same number.
6780 * editfns.c (Finsert_char):
6781 * fileio.c (Finsert_file_contents):
6782 Likewise for BUF_BYTES_MAX.
6783
dd52fcea
PE
6784 * image.c: Use ptrdiff_t, not int, for sizes.
6785 (slurp_file): Switch from int to ptrdiff_t.
6786 All uses changed.
6787 (slurp_file): Check that file size fits in both size_t (for
6788 malloc) and ptrdiff_t (for sanity and safety).
6789
7f9bbdbb
PE
6790 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6791 if b->modtime has its maximal value.
6792
dfe18f82
PE
6793 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6794
84acfcf0
PE
6795 Don't assume time_t can fit into int.
6796 * buffer.h (struct buffer.modtime): Now time_t, not int.
6797 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6798 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6799
ccd9a01a
PE
6800 Minor fixes for signed vs unsigned integers.
6801 * character.h (MAYBE_UNIFY_CHAR):
6802 * charset.c (maybe_unify_char):
6803 * keyboard.c (read_char, reorder_modifiers):
6804 XINT -> XFASTINT, since the integer must be nonnegative.
6805 * ftfont.c (ftfont_spec_pattern):
6806 * keymap.c (access_keymap, silly_event_symbol_error):
6807 XUINT -> XFASTINT, since the integer must be nonnegative.
6808 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6809 since it makes no difference and we prefer signed.
6810 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6811 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6812 nonnegative.
6813
d6d100dd
SM
68142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6815
6816 * window.h (Fwindow_frame): Declare.
6817
2b6148e4
PE
68182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6819
6820 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6821 (SPARE_MEMORY): Always define.
6822 (LARGE_REQUEST): Remove.
6823 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6824
f230ecc9
MR
68252011-06-06 Martin Rudalics <rudalics@gmx.at>
6826
727e958e
MR
6827 * lisp.h: Move EXFUNS for Fframe_root_window,
6828 Fframe_first_window and Fset_frame_selected_window to window.h.
6829
6830 * window.h: Move EXFUNS for Fframe_root_window,
6831 Fframe_first_window and Fset_frame_selected_window here from
6832 lisp.h.
6833
6834 * frame.c (Fwindow_frame, Fframe_first_window)
6835 (Fframe_root_window, Fframe_selected_window)
6836 (Fset_frame_selected_window): Move to window.c.
6837 (Factive_minibuffer_window): Move to minibuf.c.
6838 (Fother_visible_frames_p): New function.
6839
6840 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6841
f230ecc9
MR
6842 * window.c (decode_window, decode_any_window): Move up in code.
6843 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6844 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6845 (Fwindow_buffer): Move up and rewrite doc-string.
6846 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6847 (Fwindow_prev): New functions.
727e958e
MR
6848 (Fwindow_frame): Move here from frame.c. Accept any window as
6849 argument.
6850 (Fframe_root_window, Fframe_first_window)
6851 (Fframe_selected_window): Move here from frame.c. Accept frame
6852 or arbitrary window as argument. Update doc-strings.
6853 (Fminibuffer_window): Move up in code.
6854 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6855 (Fset_frame_selected_window): Move here from frame.c.
6856 Marginal rewrite.
727e958e
MR
6857 (Fselected_window, select_window, Fselect_window): Move up in
6858 code. Minor doc-string fixes.
f230ecc9 6859
4d09bcf6
PE
68602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6861
6862 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6863 Do not assume that spare memory exists; that assumption is valid
6864 only if SYSTEM_MALLOC.
6865 (LARGE_REQUEST): New macro, so that the issue of large requests
6866 is separated from the issue of spare memory.
6867
810928a2
AS
68682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6869
172418ad
AS
6870 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6871 format. (Bug#8806)
6872
43f862f7
AS
6873 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6874
810928a2
AS
6875 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6876 before statements.
6877
a059fe24
JD
68782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6879
6880 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6881
6882 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6883
6884 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6885 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6886
989bf368
JB
68872011-06-05 Juanma Barranquero <lekktu@gmail.com>
6888
6889 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6890
4b80f674
CY
68912011-06-04 Chong Yidong <cyd@stupidchicken.com>
6892
6893 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6894 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6895 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6896 New error handlers.
4b80f674
CY
6897 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6898 Obey Vx_select_enable_clipboard_manager. Catch errors in
6899 x_clipboard_manager_save (Bug#8779).
6900 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6901 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6902
99a33b77 69032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6904
6905 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6906
99a33b77 69072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6908
6909 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6910 in the current matrix if keep_current_p is non-zero.
6911
8264569d
EZ
69122011-06-04 Eli Zaretskii <eliz@gnu.org>
6913
6914 * bidi.c (bidi_level_of_next_char): Fix last change.
6915
57f97249
EZ
69162011-06-03 Eli Zaretskii <eliz@gnu.org>
6917
fec2107c 6918 Support bidi reordering of text covered by display properties.
57f97249 6919
fec2107c
EZ
6920 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6921 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6922 (bidi_cache_search, bidi_cache_iterator_state)
6923 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6924 (bidi_level_of_next_char, bidi_move_to_visually_next):
6925 Support character positions inside a run of characters covered by a
fec2107c
EZ
6926 display string.
6927 (bidi_paragraph_init, bidi_resolve_explicit_1)
6928 (bidi_level_of_next_char): Call bidi_fetch_char and
6929 bidi_fetch_char_advance instead of FETCH_CHAR and
6930 FETCH_CHAR_ADVANCE.
6931 (bidi_init_it): Initialize new members.
6932 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6933 definitions.
6934 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6935 instead of using explicit *_CHAR codes.
d6d100dd
SM
6936 (bidi_resolve_explicit, bidi_resolve_weak):
6937 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6938 bidirectional text is supported only in multibyte buffers.
6939 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6940 it to initialize the frame_window_p member of struct bidi_it.
6941 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6942 (bidi_resolve_explicit, bidi_resolve_weak)
6943 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6944 bidi_it->nchars is non-positive.
6945 (bidi_level_of_next_char): Don't try to lookup the cache for the
6946 next/previous character if nothing is cached there yet, or if we
6947 were just reseat()'ed to a new position.
c40e2fb2 6948
0e14fe90
EZ
6949 * xdisp.c (set_cursor_from_row): Set start and stop points
6950 according to the row's direction when priming the loop that looks
6951 for the glyph on which to display cursor.
6952 (single_display_spec_intangible_p): Function deleted.
6953 (display_prop_intangible_p): Reimplement to call
6954 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6955 Accept 3 additional arguments needed by handle_display_spec.
6956 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6957 values: lists, `(when COND...)' forms, etc.
6958 (single_display_spec_string_p): Support property values that are
6959 lists with the argument STRING its top-level element.
6960 (display_prop_string_p): Fix the condition for processing a
6961 property that is a list to be consistent with handle_display_spec.
fec2107c 6962 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6963 last portion of handle_display_prop.
6964 (compute_display_string_pos): Accept additional argument
6965 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6966 value of a `display' property is a "replacing spec".
6967 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6968 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6969 the display property, but just return a value indicating whether
6970 the display property will replace the characters it covers.
6971 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6972 frame_window_p members of struct bidi_it.
d6d100dd
SM
6973 (compute_display_string_pos, compute_display_string_end):
6974 New functions.
fec2107c
EZ
6975 (push_it): Accept second argument POSITION, where pop_it should
6976 jump to continue iteration.
6977 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6978
fec2107c
EZ
6979 * keyboard.c (adjust_point_for_property): Adjust the call to
6980 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6981
6982 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6983 (bidi_init_it): Update prototypes.
6984 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6985 (compute_display_string_pos, compute_display_string_end):
6986 Declare prototypes.
fec2107c
EZ
6987 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6988 EMACS_INT.
fc6f18ce 6989
40087514 69902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6991
57f53182
PE
6992 Malloc failure behavior now depends on size of allocation.
6993 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6994 * lisp.h: Change signatures accordingly.
6995 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6996 All callers changed. (Bug#8762)
6997
6998 * gnutls.c: Use Emacs's memory allocators.
6999 Without this change, the gnutls library would invoke malloc etc.
7000 directly, which causes problems on non-SYNC_INPUT hosts, and which
7001 runs afoul of improving memory_full behavior. (Bug#8761)
7002 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7003 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7004 xfree instead of the default malloc, realloc, free.
7005 (Fgnutls_boot): No need to check for memory allocation failure,
7006 since xmalloc does that for us.
7007
ac32cd99 7008 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7009 * category.c (hash_get_category_set):
7010 * ccl.c (ccl_driver):
7011 * charset.c (Fdefine_charset_internal):
7012 * charset.h (struct charset.hash_index):
7013 * composite.c (get_composition_id, gstring_lookup_cache)
7014 (composition_gstring_put_cache):
7015 * composite.h (struct composition.hash_index):
7016 * dispextern.h (struct image.hash):
7017 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7018 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7019 (hashfn_equal, hashfn_user_defined, make_hash_table)
7020 (maybe_resize_hash_table, hash_lookup, hash_put)
7021 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7022 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7023 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7024 * image.c (make_image, search_image_cache, lookup_image)
7025 (xpm_put_color_table_h):
7026 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7027 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7028 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7029 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7030 * alloc.c (allocate_vectorlike):
7031 Check for overflow in vector size calculations.
7032 * ccl.c (ccl_driver):
7033 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7034 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7035 need to be updated by these changes.
40087514
PE
7036 * fns.c (make_hash_table, maybe_resize_hash_table):
7037 Check for integer overflow with large hash tables.
0de4bb68
PE
7038 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7039 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7040 (SXHASH_REDUCE): New macro.
7041 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7042 Use it instead of discarding useful hash info with large hash values.
7043 (sxhash_float): New function.
7044 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7045 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7046 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7047 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7048 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7049 Adjust signatures to match updated version of code.
7050 (consing_since_gc): Now EMACS_INT, since a single hash table can
7051 use more than INT_MAX bytes.
7052
698d32e2
DN
70532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7054
7055 Make it possible to build with GCC-4.6+ -O2 -flto.
7056
7057 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7058
fd6fa53f
SM
70592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7060
7061 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7062 Call minibuffer-inactive-mode.
7063
864db017
JB
70642011-05-31 Juanma Barranquero <lekktu@gmail.com>
7065
7066 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7067 Update dependencies.
7068
2ad0baf4
DN
70692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7070
7071 * data.c (init_data): Remove code for UTS, this system is not
7072 supported anymore.
7073
4fcc2638
DN
70742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7075
7076 Don't force ./temacs to start in terminal mode.
7077
7078 * frame.c (make_initial_frame): Initialize faces in all cases, not
7079 only when CANNOT_DUMP is defined.
7080 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7081
c56e0fd5
DN
70822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7083
7084 * dispnew.c (add_window_display_history): Use const for the string
7085 pointer. Remove declaration, not needed.
7086
333d54da 70872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7088
55d4c1b2 7089 Use 'inline', not 'INLINE'.
333d54da 7090 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7091 * alloc.c, fontset.c (INLINE): Remove.
7092 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7093 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7094 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7095 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7096 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7097
738db178
DN
70982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7099
7100 Make it possible to run ./temacs.
7101
7102 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7103 syms_of_callproc does the same thing. Remove test for
7104 "initialized", do it in the caller.
7105 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7106
620c53a6
SM
71072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7108
7109 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7110 (read_minibuf): Use get_minibuffer.
7111 (syms_of_minibuf): Use DEFSYM.
7112 (Qmetadata): New var.
7113 * data.c (Qbuffer): Don't make it static.
7114 (syms_of_data): Use DEFSYM.
7115
e003a292
PE
71162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7117
7118 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7119 (CCL_CODE_MIN): New macro.
7120
ed008a6d
PE
71212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7122
3687c2ef
PE
7123 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7124
ed008a6d
PE
7125 * eval.c (Qdebug): Now static.
7126 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7127 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7128 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7129
d66c4c7c
CY
71302011-05-29 Chong Yidong <cyd@stupidchicken.com>
7131
7132 * image.c: Various fixes to ImageMagick code comments.
7133 (Fimagemagick_types): Doc fix.
7134
5fbc2025
PE
71352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7136
0196f88a
PE
7137 Minor fixes prompted by GCC 4.6.0 warnings.
7138
7139 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7140
5fbc2025
PE
7141 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7142 (x_clipboard_manager_save_all): Move extern decl to ...
7143 * xterm.h: ... here, so that it can be checked for consistency.
7144
1dd3c2d9
CY
71452011-05-29 Chong Yidong <cyd@stupidchicken.com>
7146
7147 * xselect.c (x_clipboard_manager_save_frame)
7148 (x_clipboard_manager_save_all): New functions.
7149 (Fx_clipboard_manager_save): Lisp function deleted.
7150
7151 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7152 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7153
7154 * xterm.h: Update prototype.
7155
5ba6571d
WX
71562011-05-28 William Xu <william.xwl@gmail.com>
7157
7158 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7159 exiting (Bug#8239).
7160
3eaff834
JM
71612011-05-28 Jim Meyering <meyering@redhat.com>
7162
e1900994 7163 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7164 * fns.c (to_uchar): Define.
7165 (crypto_hash_function): Use it to convert some newly-signed
7166 variables to unsigned, to avoid sign-extension bugs. For example,
7167 without this change, (md5 "truc") would evaluate to
7168 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7169 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7170 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7171
0f6990a7
PE
71722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7173
7174 Integer overflow fixes.
c8a9ca5a 7175
08686060
PE
7176 * dbusbind.c: Serial number integer overflow fixes.
7177 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7178 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7179 to hold a serial number that is too large for a fixnum.
7180 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7181 Check for serial numbers out of range. Decode any serial number
59568bf0 7182 that was so large that it became a float. (Bug#8722)
08686060 7183
2d1fc3c7
PE
7184 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7185 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7186 Use XFASTINT rather than XUINT when numbers are nonnegative.
7187 (xd_append_arg, Fdbus_method_return_internal):
7188 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7189 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7190 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7191 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7192 (Bug#8722)
2d1fc3c7 7193
c8a9ca5a
PE
7194 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7195
519e1d69
PE
7196 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7197
6df6ae42 7198 ccl: Add integer overflow checks.
30569699
PE
7199 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7200 (IN_INT_RANGE): New macros.
7201 (ccl_driver): Use them to check for integer overflow when
7202 decoding a CCL program. Many of the new checks are whether XINT (x)
7203 fits in int; it doesn't always, on 64-bit hosts. The new version
7204 doesn't catch all possible integer overflows, but it's an
847044ea 7205 improvement. (Bug#8719)
30569699 7206
c11285dc
PE
7207 * alloc.c (make_event_array): Use XINT, not XUINT.
7208 There's no need for unsigned here.
7209
fdccd48e
PE
7210 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7211 This follows up to the 2011-05-06 change that substituted uintptr_t
7212 for EMACS_INT. This case wasn't caught back then.
7213
37910ab2
PE
7214 Rework Fformat to avoid integer overflow issues.
7215 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7216 now (part of C89). Include <verify.h>.
7217 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7218 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7219 (Fformat): Avoid the prepass trying to compute sizes; it was only
7220 approximate and thus did not catch overflow reliably. Instead, walk
7221 through the format just once, formatting and computing sizes as we go,
7222 checking for integer overflow at every step, and allocating a larger
7223 buffer as needed. Keep track separately whether the format is
7224 multibyte. Keep only the most-recently calculated precision, rather
7225 than them all. Record whether each argument has been converted to
7226 string. Use EMACS_INT, not int, for byte and char and arg counts.
7227 Support field widths and precisions larger than INT_MAX. Avoid
7228 sprintf's undefined behavior with conversion specifications such as %#d
7229 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7230 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7231 formatting out-of-range floating point numbers with int
9173deec 7232 formats. (Bug#8668)
37910ab2 7233
2e6578fb
PE
7234 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7235
0ae6bdee
PE
7236 * data.c: Avoid integer truncation in expressions involving floats.
7237 * data.c: Include <intprops.h>.
7238 (arith_driver): When there's an integer overflow in an expression
7239 involving floating point, convert the integers to floating point
7240 so that the resulting value does not suffer from catastrophic
7241 integer truncation. For example, on a 64-bit host (* 4
7242 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7243 Do not rely on undefined behavior after integer overflow.
7244
de883a70
PE
7245 merge count_size_as_multibyte, parse_str_to_multibyte
7246 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 7247 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
7248 Check for integer overflow.
7249 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7250 since it's now a duplicate of the other. This is more of
7251 a character than a buffer op, so better that it's in character.c.
7252 * fns.c, print.c: Adjust to above changes.
7253
2ff916cb
PE
72542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7255
7256 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7257
f1b54466
PE
72582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7259
fb1ac845
PE
7260 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7261 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7262 (x_clipboard_manager_save): Now static.
7263 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7264
f1b54466
PE
7265 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7266 (crypto_hash_function): Now static.
7267 Fix pointer signedness problems. Avoid unnecessary initializations.
7268
a9f737ee
CY
72692011-05-27 Chong Yidong <cyd@stupidchicken.com>
7270
7271 * termhooks.h (Vselection_alist): Make it terminal-local.
7272
7273 * terminal.c (create_terminal): Initialize it.
7274
7275 * xselect.c: Support for clipboard managers.
7276 (Vselection_alist): Move to termhooks.h as terminal-local var.
7277 (LOCAL_SELECTION): New macro.
7278 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7279 (symbol_to_x_atom): Remove gratuitous arg.
7280 (x_handle_selection_request, lisp_data_to_selection_data)
7281 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7282 (x_own_selection, x_get_local_selection, x_convert_selection):
7283 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7284 (some_frame_on_display): Delete unused function.
7285 (Fx_own_selection_internal, Fx_get_selection_internal)
7286 (Fx_disown_selection_internal, Fx_selection_owner_p)
7287 (Fx_selection_exists_p): New optional frame arg.
7288 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7289 (x_handle_selection_clear): Don't treat other terminals with the
7290 same keyboard specially. Use the terminal-local Vselection_alist.
7291 (x_clear_frame_selections): Use Frun_hook_with_args.
7292
7293 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7294
7295 * xterm.h: Add support for those atoms.
7296
e067f0c1
CY
72972011-05-26 Chong Yidong <cyd@stupidchicken.com>
7298
7299 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7300 (converted_selections, conversion_fail_tag): New global variables.
7301 (x_selection_request_lisp_error): Free the above.
7302 (x_get_local_selection): Remove unnecessary code.
7303 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7304 of converted selections stored in converted_selections.
7305 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7306 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7307 (x_convert_selection): New function.
7308 (x_handle_selection_event): Simplify.
7309 (x_get_foreign_selection): Don't ignore incoming requests while
7310 waiting for an answer; this will fail when we implement
7311 SAVE_TARGETS, and seems unnecessary anyway.
7312 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7313 (Vx_sent_selection_functions): Doc fix.
7314
0f4aebc0
LL
73152011-05-26 Leo Liu <sdl.web@gmail.com>
7316
7317 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7318
e61124cd
YM
73192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7320
7321 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7322
7323 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7324 for fringe update if it has periodic bitmap.
ac389d0c 7325 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7326 and fringe_bitmap_periodic_p.
7327
7328 * fringe.c (get_fringe_bitmap_data): New function.
7329 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7330 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7331 row. Mark glyph row for fringe update if periodicity changed.
7332
7333 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7334 for fringe update unless it has periodic bitmap.
7335
f16d9837
KH
73362011-05-25 Kenichi Handa <handa@m17n.org>
7337
7338 * xdisp.c (get_next_display_element): Set correct it->face_id for
7339 a static composition.
7340
e1b90ef6
LL
73412011-05-24 Leo Liu <sdl.web@gmail.com>
7342
7343 * deps.mk (fns.o):
7344 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7345
7346 * fns.c (crypto_hash_function, Fsha1): New function.
7347 (Fmd5): Use crypto_hash_function.
7348 (syms_of_fns): Add Ssha1.
7349
7400048f
PE
73502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7351
7352 * gnutls.c: Remove unused macros.
7353 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7354 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7355 Remove macros that are defined and never used.
7356 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7357
abb71cf4
CY
73582011-05-22 Chong Yidong <cyd@stupidchicken.com>
7359
7360 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7361 (Fx_get_selection_internal): Minor cleanup.
7362 (Fx_own_selection_internal): Rename arguments for consistency with
7363 select.el.
7364
6307db39
PE
73652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7366
7367 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7368
f3d4e0a4
CY
73692011-05-22 Chong Yidong <cyd@stupidchicken.com>
7370
7371 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7372
4d8ade89
YM
73732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7374
7375 * dispnew.c (scrolling_window): Don't exclude the case that the
7376 last enabled row in the desired matrix touches the bottom boundary.
7377
32078c8d
GM
73782011-05-21 Glenn Morris <rgm@gnu.org>
7379
7380 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7381 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7382 and add some more files.
32078c8d 7383
7285dc67
EZ
73842011-05-20 Eli Zaretskii <eliz@gnu.org>
7385
7386 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7387 report_file_error introduced by the change from 2011-05-07.
7388
89d1bd22
PE
73892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7390
7391 * systime.h (Time): Define only if emacs is defined.
7392 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7393 where the include path doesn't have X11/X.h by default. See
7394 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7395
cd394be1 73962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7397
7398 * composite.c (find_automatic_composition): Fix previous change.
7399
b9704ad9
GM
74002011-05-20 Glenn Morris <rgm@gnu.org>
7401
7402 * lisp.mk: New file, split from Makefile.in.
7403 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7404 (shortlisp): Remove.
7405 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7406
4a720484
GM
74072011-05-19 Glenn Morris <rgm@gnu.org>
7408
7409 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7410 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7411 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7412 (lisp): Set the order to that of loadup.el.
7413 (shortlisp): Make it a copy of $lisp.
7414 (SOME_MACHINE_LISP): Remove.
7415 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7416 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7417
a28d4396
KH
74182011-05-18 Kenichi Handa <handa@m17n.org>
7419
7420 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7421 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7422 (find_automatic_composition): Mostly rewrite for efficiency.
7423
a2b1fa8e
JB
74242011-05-18 Juanma Barranquero <lekktu@gmail.com>
7425
7426 * makefile.w32-in: Update dependencies.
7427
8e1f5610
CS
74282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7429
7430 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7431 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7432
7025ee00 74332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7434
cdfa6eab
PE
7435 Fix some integer overflow issues, such as string length overflow.
7436
06d6db33
PE
7437 * insdel.c (count_size_as_multibyte): Check for string overflow.
7438
2b4560a8
PE
7439 * character.c (lisp_string_width): Check for string overflow.
7440 Use EMACS_INT, not int, for string indexes and lengths; in
7441 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7442 the resulting string length overflows an EMACS_INT; instead,
7443 report a string overflow if no precision given. When checking for
7444 precision exhaustion, use a check that cannot possibly have
7445 integer overflow. (Bug#8675)
7446 * character.h (lisp_string_width): Adjust to new signature.
7447
cb93f9be
PE
7448 * alloc.c (string_overflow): New function.
7449 (Fmake_string): Use it. This doesn't change behavior, but saves
7450 a few bytes and will simplify future changes.
7451 * character.c (string_escape_byte8): Likewise.
7452 * lisp.h (string_overflow): New decl.
7453
1a1f3366
PE
7454 Fixups, following up to the user-interface timestamp change.
7455 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7456 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7457 * msdos.c (mouse_get_pos): Likewise.
7458 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7459 * w32gui.h (Time): Define by including "systime.h" rather than by
7460 declaring it ourselves. (Bug#8664)
7461
d4e3e4d3
PE
7462 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7463 * image.c (clear_image_cache): Likewise.
7464
f6a24d19
PE
7465 * term.c (term_mouse_position): Don't assume time_t wraparound.
7466
08dc5ae6
PE
7467 Be more systematic about user-interface timestamps.
7468 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7469 and sometimes 'EMACS_UINT', to represent these timestamps.
7470 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7471 This makes the code easier to follow, and makes it easier to catch
7472 integer overflow bugs such as Bug#8664.
7473 * frame.c (Fmouse_position, Fmouse_pixel_position):
7474 Use Time, not unsigned long, for user-interface timestamps.
7475 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7476 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7477 * keyboard.h (last_event_timestamp): Likewise.
7478 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7479 * menu.h (xmenu_show): Likewise.
7480 * term.c (term_mouse_position): Likewise.
7481 * termhooks.h (struct input_event.timestamp): Likewise.
7482 (struct terminal.mouse_position_hook): Likewise.
7483 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7484 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7485 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7486 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7487 what it was before.
7488 * menu.h, termhooks.h: Include "systime.h", for Time.
7489
8e55734a
PE
7490 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7491 Don't assume that the difference between two unsigned long values
7492 can fit into an integer. At this point, we know button_down_time
7493 <= event->timestamp, so the difference must be nonnegative, so
7494 there's no need to cast the result if double-click-time is
7495 nonnegative, as it should be; check that it's nonnegative, just in
7496 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7497 apart (about 25 days). (Bug#8664)
8e55734a 7498
841f1b75 7499 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7500 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7501
3e26f69c
PE
7502 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7503 that always fit in int. Use a sentinel instead of a counter, to
7504 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7505 * frame.h (struct frame): Use int for menu_bar_items_used
7506 instead of EMACS_INT, since it always fits in int.
3e26f69c 7507
5cc152c0
PE
7508 * menu.c (grow_menu_items): Check for int overflow.
7509
d89eb65e
PE
7510 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7511
5235bd3e
PE
7512 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7513 Before, the code was not consistent. These values cannot exceed
7514 2**31 - 1 so there's no need to make them unsigned.
7515 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7516 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7517 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7518 as modifiers.
7519 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7520
bc827e23
PE
7521 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7522 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7523 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7524 presumably because the widths might not match.
7525
78eb494e
PE
7526 * window.c (size_window): Avoid needless test at loop start.
7527
04f2d78b
CB
75282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7529
7530 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7531
d2fc7e3d 75322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7533
7534 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7535
d2fc7e3d 75362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7537
7538 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7539 `width' to `bar_area_x' and `bar_area_width', respectively.
7540 (x_scroll_run): Take account of fringe background extension.
7541
04f2d78b
CB
7542 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7543 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7544 `bar_area_width', respectively.
7545 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7546 background extension.
7547
79b70037
GM
75482011-05-10 Jim Meyering <meyering@redhat.com>
7549
7550 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7551
2f142cc5
JB
75522011-05-10 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * image.c (Finit_image_library): Return t for built-in image types,
7555 like pbm and xbm. (Bug#8640)
7556
57679c86
AS
75572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7558
7559 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7560
888c9e86
EZ
75612011-05-07 Eli Zaretskii <eliz@gnu.org>
7562
b0512a1d
EZ
7563 * w32console.c (Fset_screen_color): Doc fix.
7564 (Fget_screen_color): New function.
7565 (syms_of_ntterm): Defsubr it.
7566
7285dc67
EZ
7567 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7568 unlink the temporary file if Fcall_process didn't create it in the
7569 first place.
7570 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7571 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7572 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7573 cue to call_process_cleanup not to close that handle.
7574
4d3fcc8e
BK
75752011-05-07 Ben Key <bkey76@gmail.com>
7576
7577 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7578 one of two shell specific rules, either bootstrap-temacs-CMD or
7579 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7580 to the previous implementation of the bootstrap-temacs rule.
7581 The bootstrap-temacs-CMD rule is similar to the previous
7582 implementation of the bootstrap-temacs rule except that it
7583 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7584 variable.
7585
7586 These changes, along with some changes to nt/configure.bat,
7587 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7588 earlier fix to add support for --cflags and --ldflags options
7589 that include quotes so that it works whether make uses cmd or
7590 sh as the shell.
7591
b4289b64
MA
75922011-05-06 Michael Albinus <michael.albinus@gmx.de>
7593
7594 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7595 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7596 is a constant.
7597 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7598 a string. Handle both cases.
7599 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7600 (Fdbus_register_method): Use Qinvalid_function.
7601
af4c0e28
JB
76022011-05-06 Juanma Barranquero <lekktu@gmail.com>
7603
7604 * makefile.w32-in: Update dependencies.
7605 (LISP_H): Add inttypes.h and stdin.h.
7606 (PROCESS_H): Add unistd.h.
7607
c51453d9
EZ
76082011-05-06 Eli Zaretskii <eliz@gnu.org>
7609
7610 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7611 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7612
8ff0ac3c 76132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7614
4c4b566b
PE
7615 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7616
aab2b9b5
PE
7617 * term.c (vfatal): Remove stray call to va_end.
7618 It's not needed and the C Standard doesn't allow it here anyway.
7619
c378da0b
PE
7620 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7621 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7622
288b08c7
PE
7623 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7624 bytes.
7625
e3601888
PE
7626 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7627
db6c0e74
PE
7628 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7629
dd5963ea
PE
7630 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7631
88c9450f
PE
7632 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7633
2f9442b8
PE
7634 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7635
c032b5f8
PE
7636 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7637 * charset.c (Fdefine_charset_internal): Don't initialize
7638 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7639 32-bit int (Bug#8600).
a108c10b
PE
7640
7641 * lread.c (read_integer): Be more consistent with string-to-number.
7642 Use string_to_number to do the actual conversion; this avoids
7643 rounding errors and fixes some other screwups. Without this fix,
7644 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7645 (digit_to_number): Move earlier, for benefit of read_integer.
7646 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7647 not a digit in any supported base. (Bug#8602)
a108c10b 7648
ad5f9eea
PE
7649 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7650
aec1708a
PE
7651 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7652 to match comment at start of function. This also removes a
7653 GCC warning about overflow in a 32+64-bit port.
7654
47be4ab5
PE
7655 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7656
371cac43
PE
7657 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7658 Reported by Stefan Monnier in
7659 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7660 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7661 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7662
d01a7826
PE
7663 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7664 (EMACS_UINTPTR): Likewise, with uintptr_t.
7665
7fd47d5c
PE
7666 * lisp.h: Prefer 64-bit EMACS_INT if available.
7667 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7668 on 32-bit hosts that have 64-bit int, so that they can access
7669 large files.
122b0c86
PE
7670 However, temporarily disable this change unless the temporary
7671 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7672
8727937b
PE
7673 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7674
8ac068ac
PE
7675 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7676 This removes an assumption that EMACS_INT and long are the same
7677 width as pointers. The assumption is true for Emacs porting targets
7678 now, but we want to make other targets possible.
7679 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7680 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7681 In the rest of the code, change types of integers that hold casted
7682 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7683 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7684 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7685 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7686 No need to cast type when ORing.
7687 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7688 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7689 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7690 assume EMACS_INT is the same width as char *.
7691 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7692 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7693 Remove no-longer-needed casts.
7694 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7695 (xg_tool_bar_help_callback, xg_make_tool_item):
7696 Use EMACS_INTPTR to hold an integer
7697 that will be cast to void *; this can avoid a GCC warning
7698 if EMACS_INT is not the same width as void *.
7699 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7700 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7701 (current_message_1, set_message_1):
7702 Use a local to convert to proper width without a cast.
7703 * xmenu.c (dialog_selection_callback): Likewise.
7704
ede49d71
PE
7705 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7706 Also, don't assume VALBITS / RAND_BITS is less than 5,
7707 and don't rely on undefined behavior when shifting a 1 left into
7708 the sign bit.
7709 * lisp.h (get_random): Change signature to match.
7710
2f30ecd0
PE
7711 * lread.c (hash_string): Use size_t, not int, for hash computation.
7712 Normally we prefer signed values; but hashing is special, because
7713 it's better to use unsigned division on hash table sizes so that
7714 the remainder is nonnegative. Also, size_t is the natural width
7715 for hashing into memory. The previous code used 'int', which doesn't
7716 retain enough info to hash well into very large tables.
7717 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7718
2a866e7b
PE
7719 * dbusbind.c: Don't possibly lose pointer info when converting.
7720 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7721 Use XPNTR rather than XHASH, so that the high-order bits of
7722 the pointer aren't lost when converting through void *.
7723
51639eac
PE
7724 * eval.c (Fautoload): Don't double-shift a pointer.
7725
92394119
PE
7726 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7727
dbdb9a7c
JB
77282011-05-06 Juanma Barranquero <lekktu@gmail.com>
7729
7730 * gnutls.c (DEF_GNUTLS_FN):
7731 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7732
db7a0b4f
AS
77332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7734
7735 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7736 marker. (Bug#8610)
7737
cd394be1 77382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7739
7740 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7741 New version that can reserve upto 2GB of heap space.
7742
f7ff1b0f 77432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7744
7745 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7746
639c109b
TZ
77472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7748
7749 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7750 `gnutls_certificate_set_x509_key_file'.
7751
d2127135
JB
77522011-05-05 Juanma Barranquero <lekktu@gmail.com>
7753
7754 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7755 Update dependencies.
7756
e968f4f3
JB
77572011-05-04 Juanma Barranquero <lekktu@gmail.com>
7758
7759 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7760 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7761 Remove unused parameter `fildes'.
7762 * process.c (read_process_output, send_process): Don't pass it.
7763
84d358f0
JB
77642011-05-04 Juanma Barranquero <lekktu@gmail.com>
7765
7766 Fix previous change: the library cache is defined in w32.c.
7767 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7768 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7769
0898ca10
JB
77702011-05-04 Juanma Barranquero <lekktu@gmail.com>
7771
7772 Implement dynamic loading of GnuTLS on Windows.
7773
7774 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7775 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7776 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7777 Declare.
7778
7779 * gnutls.c (Qgnutls_dll): Define.
7780 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7781 (gnutls_*): Declare function pointers.
7782 (init_gnutls_functions): New function to initialize function pointers.
7783 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7784 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7785 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7786 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7787 (emacs_gnutls_write, emacs_gnutls_read)
7788 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7789 (Fgnutls_available_p): New function.
7790 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7791 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7792 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7793
7794 * image.c: Include w32.h.
7795 (Vimage_type_cache): Delete.
7796 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7797 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7798 (w32_delayed_load): Move to w32.c.
7799
7800 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7801
7802 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7803 (w32_delayed_load): Move from image.c. When loading a library, record
7804 its filename in the :loaded-from property of the library id.
7805 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7806 Initialize and staticpro them.
7807 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7808
7809 * process.c: Include lisp.h before w32.h, not after.
7810 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7811 instead of gnutls_record_check_pending.
7812
7813 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7814
ff4de4aa
TZ
78152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7816
7817 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7818 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7819 as passed in.
7820
abe95abb
JD
78212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7822
7823 * xterm.c (x_set_frame_alpha): Do not set property on anything
7824 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7825
e16e55d4
JB
78262011-05-02 Juanma Barranquero <lekktu@gmail.com>
7827
7828 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7829
bafcf6a5
JB
78302011-05-02 Juanma Barranquero <lekktu@gmail.com>
7831
7832 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7833 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7834 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7835 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7836 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7837 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7838 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7839 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7840 (Qgnutls_bootprop_callbacks_verify): Make static.
7841
e7a6747f
AS
78422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7843
19ed11ba
AS
7844 * callproc.c: Indentation fixup.
7845
e7a6747f 7846 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7847 (wait_for_termination, interruptible_wait_for_termination):
7848 Move after wait_for_termination_1.
e7a6747f 7849
1ef14cb4
LMI
78502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7851
7852 * sysdep.c (interruptible_wait_for_termination): New function
7853 which is like wait_for_termination, but allows keyboard
7854 interruptions.
7855
7856 * callproc.c (Fcall_process): Add (:file "file") as an option for
7857 the STDOUT buffer.
7858 (Fcall_process_region): Ditto.
7859
330d880c
EZ
78602011-04-30 Eli Zaretskii <eliz@gnu.org>
7861
8db90b73
EZ
7862 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7863 rather than `XVECTOR (FOO)->size'.
7864
330d880c
EZ
7865 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7866 inttypes.h, as a gnulib replacement is used if it not available in
7867 system headers.
7868
15cbd324
EZ
78692011-04-21 Eli Zaretskii <eliz@gnu.org>
7870
7871 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7872 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7873 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7874
7875 * coding.c (coding_alloc_by_realloc): Error out if destination
7876 will grow beyond MOST_POSITIVE_FIXNUM.
7877 (decode_coding_emacs_mule): Abort if there isn't enough place in
7878 charbuf for the composition carryover bytes. Reserve an extra
7879 space for up to 2 characters produced in a loop.
7880 (decode_coding_iso_2022): Abort if there isn't enough place in
7881 charbuf for the composition carryover bytes.
7882
78832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7884
ae940cca
EZ
7885 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7886 aborting when %lld or %lll format is passed.
7887 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7888 %llo or %llx format is passed. (Bug#8545)
7889
03ab8921
EZ
7890 * window.c (window_scroll_line_based): Use a marker instead of
7891 simple variables to record original value of point. (Bug#7952)
7892
afda1437
EZ
7893 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7894 produced by %s or %c overflows available buffer space. (Bug#8545)
7895
f76dee0c
PE
78962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7897
7898 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7899 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7900
fdc5744d
JB
79012011-04-28 Juanma Barranquero <lekktu@gmail.com>
7902
7903 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7904
638f053a
JB
79052011-04-28 Juanma Barranquero <lekktu@gmail.com>
7906
7907 * keyboard.c (Qdelayed_warnings_hook): Define.
7908 (command_loop_1): Run `delayed-warnings-hook'
7909 if Vdelayed_warnings_list is non-nil.
7910 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7911 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7912
d178f871
EZ
79132011-04-28 Eli Zaretskii <eliz@gnu.org>
7914
7915 * doprnt.c (doprnt): Don't return value smaller than the buffer
7916 size if the message was truncated. (Bug#8545).
7917
b124fd93
JB
79182011-04-28 Juanma Barranquero <lekktu@gmail.com>
7919
7920 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7921 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7922
e810457d
PE
79232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7924
7925 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7926
ea51cceb
JB
79272011-04-27 Juanma Barranquero <lekktu@gmail.com>
7928
7929 * makefile.w32-in: Update dependencies.
7930
94dcfacf
EZ
79312011-04-27 Eli Zaretskii <eliz@gnu.org>
7932
7933 Improve `doprnt' and its usage. (Bug#8545)
7934 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7935 `format_end'. Remove support for %l as a conversion specifier.
7936 Don't use xrealloc. Improve diagnostics when the %l size modifier
7937 is used. Update the commentary.
7938
7939 * eval.c (verror): Simplify calculation of size_t.
7940
7941 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7942 messages.
7943
f61f41d7
PE
79442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7945
7946 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7947 change.
7948
96fb4434
PE
79492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7950
7951 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7952 This makes this file independent of the recent pseudovector change.
7953
671875da 79542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7955
69e9b5a3
PE
7956 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7957
b5f869a7 7958 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7959 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7960 Remove unused local.
c8926152 7961 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7962
841a1577 7963 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7964 GCC 4.6.0 optimizes based on type-based alias analysis.
7965 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7966 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7967 != &v->size, and therefore "v->size = 1; b->size = 2; return
7968 v->size;" must therefore return 1. This assumption is incorrect
7969 for Emacs, since it type-puns struct Lisp_Vector * with many other
7970 types. To fix this problem, this patch adds a new type struct
f904488f 7971 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7972 and pseudovectors, and helps optimizing compilers not get fooled
7973 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7974 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7975 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7976 the size member.
eab3844f
PE
7977 (XSETPVECTYPE): Rewrite in terms of new macro.
7978 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7979 This is a bit clearer, and further avoids the possibility of
7980 undesirable aliasing.
7981 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7982 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7983 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7984 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7985 (ASIZE): Now uses header.size rather than size.
7986 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7987 to avoid the hassle of writing XVECTOR (foo)->header.size.
7988 (struct vectorlike_header): New type.
eab3844f
PE
7989 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7990 object, to help avoid aliasing.
7991 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7992 (SUBRP): Likewise, since Lisp_Subr is a special case.
7993 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7994 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7995 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7996 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7997 changed to be "header.size" and "header.next".
7998 * buffer.h (struct buffer): Likewise.
7999 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8000 * frame.h (struct frame): Likewise.
8001 * process.h (struct Lisp_Process): Likewise.
8002 * termhooks.h (struct terminal): Likewise.
8003 * window.c (struct save_window_data, struct saved_window): Likewise.
8004 * window.h (struct window): Likewise.
8005 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8006 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8007 * buffer.c (init_buffer_once): Likewise.
8008 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8009 special case.
8010 * process.c (Fformat_network_address): Use local var for size,
8011 for brevity.
8012
0df1eac5
PE
8013 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8014
847ab9d1 8015 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8016 * data.c (atof): Remove decl; no longer used or needed.
8017 (digit_to_number): Move to lread.c.
8018 (Fstring_to_number): Use new string_to_number function, to be
8019 consistent with how the Lisp reader treats infinities and NaNs.
8020 Do not assume that floating-point numbers represent EMACS_INT
8021 without losing information; this is not true on most 64-bit hosts.
8022 Avoid double-rounding errors, by insisting on integers when
8023 parsing non-base-10 numbers, as the documentation specifies.
8024 * lisp.h (string_to_number): New decl, replacing ...
8025 (isfloat_string): Remove.
bc0a5c13 8026 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8027 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8028 appears to have been a coding error. Similarly, do not accept
8029 strings like +-1e0 as floating point numbers. Do not report
8030 overflow for integer overflows unless the base is not 10 which
8031 means we have no simple and reliable way to continue.
8032 Break out the floating-point parsing into a new
8033 function string_to_number, so that Fstring_to_number parses
8034 floating point numbers consistently with the Lisp reader.
04f2d78b 8035 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8036 (E_CHAR, EXP_INT): Remove, replacing with ...
8037 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8038 (string_to_number): New function, replacing isfloat_string.
8039 This function checks for valid syntax and produces the resulting
8040 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8041 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8042 so that overflow for non-base-10 numbers is reported only when
8043 there's no portable and simple way to convert to floating point.
452f4150 8044
67769ffc
PE
8045 * textprop.c (set_text_properties_1): Rewrite for clarity,
8046 and to avoid GCC warning about integer overflow.
8047
c20db43f
PE
8048 * intervals.h (struct interval): Use EMACS_INT for members
8049 where EMACS_UINT might cause problems. See
8050 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8051 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8052 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8053 All uses changed.
37aa2f85
PE
8054 (offset_intervals): Tell GCC not to worry about length overflow
8055 when negating a negative length.
c20db43f 8056
2538aa2f
PE
8057 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8058 (overrun_check_free): Likewise.
8059
f2d3008d
PE
8060 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8061 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8062 word size.
8063
ec8df744
PE
8064 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8065 (gnutls_make_error): Rename local to avoid shadowing.
8066 (gnutls_emacs_global_deinit): ifdef out; not used.
8067 (Fgnutls_boot): Use const for pointer to readonly storage.
8068 Comment out unused local. Fix pointer signedness problems.
8069
640ee02d
PE
8070 * lread.c (openp): Don't stuff size_t into an 'int'.
8071 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8072 about possible signed overflow.
8073
6048fb2a
PE
8074 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8075 (GDK_KEY_g): Don't define if already defined.
8076 (xg_prepare_tooltip): Avoid pointer signedness problem.
8077 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8078
fa3c87e1
PE
8079 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8080 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8081
2172544b
PE
8082 * xfns.c (Fx_window_property): Simplify a bit,
8083 to make a bit faster and to avoid GCC 4.6.0 warning.
8084 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8085
9b821a21
PE
8086 * fns.c (internal_equal): Don't assume size_t fits in int.
8087
3c616cfa
PE
8088 * alloc.c (compact_small_strings): Tighten assertion a little.
8089
c2982e87
PE
8090 Replace pEd with more-general pI, and fix some printf arg casts.
8091 * lisp.h (pI): New macro, generalizing old pEd macro to other
8092 conversion specifiers. For example, use "...%"pI"d..." rather
8093 than "...%"pEd"...".
8094 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8095 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8096 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8097 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8098 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8099 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8100 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8101 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8102 64-bit hosts.
8103 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8104 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8105 * print.c (safe_debug_print, print_object): Likewise.
8106 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8107 to int.
6f04d126
PE
8108 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8109 avoiding the 0 flag, which is not portable.
c2982e87
PE
8110 * process.c (Fmake_network_process): Use pI to avoid cast.
8111 * region-cache.c (pp_cache): Likewise.
8112 * xdisp.c (decode_mode_spec): Likewise.
8113 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8114 behavior on 64-bit hosts with printf arg.
6f04d126 8115 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8116 (x_stop_queuing_selection_requests): Likewise.
8117 (x_get_window_property): Don't truncate byte count to an 'int'
8118 when tracing.
0b432f21 8119
5e073ec7
PE
8120 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8121 here, since it parses constructs like leading '-' and spaces,
8122 which are not wanted; and it overflows with large numbers.
8123 Instead, simply match F[0-9]+, which is what is wanted anyway.
8124
36372bf9
PE
8125 * alloc.c: Remove unportable assumptions about struct layout.
8126 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8127 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8128 (allocate_vectorlike, make_pure_vector): Use the new macros,
8129 plus offsetof, to remove unportable assumptions about struct layout.
8130 These assumptions hold on all porting targets that I know of, but
8131 they are not guaranteed, they're easy to remove, and removing them
8132 makes further changes easier.
8133
0b432f21
PE
8134 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8135 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8136 (string_overrun_cookie): Now const. Use initializers that
8137 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8138 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8139 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8140 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8141 multiple of sizeof (EMACS_INT); it need not be, if
8142 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8143 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8144
895009e1
JB
81452011-04-26 Juanma Barranquero <lekktu@gmail.com>
8146
8147 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8148
6a7a1b0b
TZ
81492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8150
8151 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8152 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8153 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8154
841a1577 81552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8156
8157 * lisp.h (Qdebug): List symbol.
895009e1 8158 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8159 * keyboard.c (debug-on-event): New variable.
8160 (handle_user_signal): Break into debugger when debug-on-event
8161 matches the current signal symbol.
8162
f2d3ba6f
DN
81632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8164
8165 * alloc.c (check_sblock, check_string_bytes)
8166 (check_string_free_list): Convert to standard C.
8167
42ce4c63
TZ
81682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8169
8170 * w32.c (emacs_gnutls_push): Fix typo.
8171
825cd63c
EZ
81722011-04-25 Eli Zaretskii <eliz@gnu.org>
8173
fb11d64d
EZ
8174 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8175 "cast to pointer from integer of different size".
8176
825cd63c
EZ
8177 Improve doprnt and its use in verror. (Bug#8545)
8178 * doprnt.c (doprnt): Document the set of format control sequences
8179 supported by the function. Use SAFE_ALLOCA instead of always
8180 using `alloca'.
8181
8182 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8183 is one byte too soon. Don't use xrealloc; instead xfree and
8184 xmalloc anew.
8185
e061a11b
TZ
81862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8187
8188 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8189 callbacks stage.
8190
8191 * gnutls.c: Renamed global_initialized to
8192 gnutls_global_initialized. Added internals for the
8193 :verify-hostname-error, :verify-error, and :verify-flags
8194 parameters of `gnutls-boot' and documented those parameters in the
8195 docstring. Start callback support.
9173deec
JB
8196 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8197 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8198 on error. Return error code.
e061a11b
TZ
8199 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8200 (emacs_gnutls_read): Likewise.
8201 (Fgnutls_boot): Return handshake error code.
8202 (emacs_gnutls_handle_error): New function.
8203 (wsaerror_to_errno): Likewise.
8204
8205 * w32.h (emacs_gnutls_pull): Add prototype.
8206 (emacs_gnutls_push): Likewise.
8207
8208 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8209 (emacs_gnutls_push): Likewise.
8210
82112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8212
8213 * process.c (wait_reading_process_output): Check if GnuTLS
8214 buffered some data internally if no FDs are set for TLS
8215 connections.
8216
8217 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8218 (LIBS): Link to USER_LIBS.
8219 ($(BLD)/gnutls.$(0)): New target.
8220
fa6996bc
EZ
82212011-04-24 Eli Zaretskii <eliz@gnu.org>
8222
eb35682e
EZ
8223 * xdisp.c (handle_single_display_spec): Rename the
8224 display_replaced_before_p argument into display_replaced_p, to
8225 make it consistent with the commentary. Fix typos in the
8226 commentary.
8227
e2ad650c
EZ
8228 * textprop.c (syms_of_textprop): Remove dead code.
8229 (copy_text_properties): Delete obsolete commentary about an
8230 interface that was deleted long ago. Fix typos in the description
8231 of arguments.
8232
1b2de274
EZ
8233 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8234 to changes in oldXMenu/XMenu.h from 2011-04-16.
8235 <menu_help_message, prev_menu_help_message>: Constify.
8236 (IT_menu_make_room): menu->help_text is now `const char **';
8237 adjust.
8238
8239 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8240 to changes in oldXMenu/XMenu.h from 2011-04-16.
8241 (struct XMenu): Declare `help_text' `const char **'.
8242
8243 * xfaces.c <Qunspecified>: Make extern again.
8244
8245 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 8246 required by POSIX.
1b2de274 8247
762b15be
EZ
8248 * doc.c (get_doc_string): Improve the format passed to `error'.
8249
8250 * doprnt.c (doprnt): Improve commentary.
8251
8252 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8253
8254 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8255 them with etags.
8256
f1052e5d
EZ
8257 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8258 changes in globals.h immediately force recompilation.
762b15be
EZ
8259 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8260 $(CURDIR)/s/ms-w32.h.
8261 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8262
fa6996bc
EZ
8263 * character.c (Fchar_direction): Function deleted.
8264 (syms_of_character): Don't defsubr it.
8265 <char-direction-table>: Deleted.
8266
e6c3da20
EZ
82672011-04-23 Eli Zaretskii <eliz@gnu.org>
8268
8269 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8270 * doprnt.c: Include limits.h.
8271 (SIZE_MAX): New macro.
04f2d78b
CB
8272 (doprnt): Return a size_t value. 2nd arg is now size_t.
8273 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8274 Improve overflow protection. Support `l' modifier for integer
8275 conversions. Support %l conversion. Don't assume an EMACS_INT
8276 argument for integer conversions and for %c.
8277
8278 * lisp.h (doprnt): Restore prototype.
8279
8280 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8281 $(SRC)/character.h.
8282
8283 * Makefile.in (base_obj): Add back doprnt.o.
8284
8285 * deps.mk (doprnt.o): Add back prerequisites.
8286 (callint.o): Depend on character.h.
8287
8288 * eval.c (internal_lisp_condition_case): Include the handler
8289 representation in the error message.
8290 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8291 when breaking from the loop.
8292
8293 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8294
8295 * callint.c (Fcall_interactively): When displaying error message
8296 about invalid control letter, pass the character's codepoint, not
8297 a pointer to its multibyte form. Improve display of the character
8298 in octal and display also its hex code.
8299
8300 * character.c (char_string): Use %x to display the (unsigned)
8301 codepoint of an invalid character, to avoid displaying a bogus
8302 negative value.
8303
8304 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8305 `error', not SYMBOL_NAME itself.
8306
8307 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8308 character arguments to `error'.
8309
8310 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8311 to `error' in error message about FINAL_CHAR argument. Make sure
8312 FINAL_CHAR is a character, and use %c when it is passed as
8313 argument to `error'.
8314
4ffd0d6b 83152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8316
8317 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8318
8319 * w32.c: Include <time.h>.
8320 (sys_localtime): New function.
8321
4ffd0d6b 83222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8323
8324 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8325
4ffd0d6b 8326 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8327
4ffd0d6b 83282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8329
4ffd0d6b
GM
8330 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8331 zombies (Bug#8467).
aac0c6e3 8332
04c56954
EZ
83332011-04-19 Eli Zaretskii <eliz@gnu.org>
8334
8335 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8336 gl_state.e_property when gl_state.object is Qt.
8337
8338 * insdel.c (make_gap_larger): Remove limitation of buffer size
8339 to <= INT_MAX.
8340
16a43933
CY
83412011-04-18 Chong Yidong <cyd@stupidchicken.com>
8342
8343 * xdisp.c (lookup_glyphless_char_display)
8344 (produce_glyphless_glyph): Handle cons cell entry in
8345 glyphless-char-display.
8346 (Vglyphless_char_display): Document it.
8347
8348 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8349 glyphless-char-display.
8350
4581706e
CY
83512011-04-17 Chong Yidong <cyd@stupidchicken.com>
8352
8353 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8354
8355 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8356
8357 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8358 definition for no-X builds.
8359
4887c6e2 83602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8361
fd35b6f9
PE
8362 Static checks with GCC 4.6.0 and non-default toolkits.
8363
5c1ccb01
PE
8364 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8365
006c5daa
PE
8366 * process.c (keyboard_bit_set): Define only if SIGIO.
8367 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8368 (send_process): Repair possible setjmp clobbering.
8369
efc736d3
PE
8370 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8371
4e2fe2e6
PE
8372 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8373
f97334a2
PE
8374 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8375
4e75f29d
PE
8376 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8377 Define only if needed.
8378
90efadd1
PE
8379 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8380 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8381 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8382
3c647824
PE
8383 * dispextern.h (struct redisplay_interface): Rename param
8384 to avoid shadowing.
e264f262 8385 * termhooks.h (struct terminal): Likewise.
761383f4 8386 * xterm.c (xembed_send_message): Likewise.
3c647824 8387
b58c5c4a
PE
8388 * insdel.c (make_gap_smaller): Define only if
8389 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8390
cad59032
PE
8391 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8392 it.
8393
c339dc2e
PE
8394 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8395 so that we aren't warned about unused symbols.
8396
91a3e27b
PE
8397 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8398
399c71d3 8399 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8400
8ffc96f5
PE
8401 * xfns.c (x_real_positions): Mark locals as initialized.
8402
eef9bc79
PE
8403 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8404
098db9dd
PE
8405 * xterm.c: Fix problems found by static analysis with other toolkits.
8406 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8407 (x_dispatch_event): Declare static if USE_GTK, and
8408 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8409 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8410 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8411 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8412 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8413
eb18f6cc
PE
8414 * xmenu.c (menu_help_callback): Pointer type fixes.
8415 Use const pointers when pointing at readonly data. Avoid pointer
8416 signedness clashes.
8417 (FALSE): Remove unused macro.
8418 (update_frame_menubar): Remove unused decl.
8419
1fe72bf8
PE
8420 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8421
60d9e1db
PE
8422 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8423 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8424 (single_menu_item): Rename local to avoid shadowing.
8425
39261c26
PE
8426 * keyboard.c (make_lispy_event): Remove unused local var.
8427
018c5e19
PE
8428 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8429 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8430
63d2b86e
PE
8431 * bitmaps: Change bitmaps from unsigned char back to the X11
8432 compatible char. Avoid the old compiler warnings about
8433 out-of-range initializers by using, for example, '\xab' rather
8434 than 0xab.
8435
aefd87e1
PE
8436 * xgselect.c (xgselect_initialize): Check vs interface
8437 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8438
bf501fb9
PE
8439 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8440
e9829fdf
PE
8441 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8442 to read-only memory.
8443
1086c095
PE
8444 * fns.c (vector): Remove; this old hack is no longer needed.
8445
2baccd04 8446 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8447 Remove unused var.
dde42981 8448 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8449
72391843 8450 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8451
436c16df 8452 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8453 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8454 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8455
92bb796d 8456 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8457 (x_term_init): Remove local to avoid shadowing.
92bb796d 8458
764430a3 8459 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8460
8461 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8462 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8463
d1dfb56c
EZ
84642011-04-16 Eli Zaretskii <eliz@gnu.org>
8465
c4354cb4
EZ
8466 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8467
d1dfb56c
EZ
8468 Fix regex.c, syntax.c and friends for buffers > 2GB.
8469 * syntax.h (struct gl_state_s): Declare character position members
8470 EMACS_INT.
8471
8472 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8473
04f2d78b
CB
8474 * textprop.c (verify_interval_modification, interval_of):
8475 Declare arguments EMACS_INT.
d1dfb56c
EZ
8476
8477 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8478 EMACS_INT.
8479
8480 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8481
8482 * indent.c (Fvertical_motion): Local variable it_start is now
8483 EMACS_INT.
8484
8485 * regex.c (re_match, re_match_2, re_match_2_internal)
8486 (bcmp_translate, regcomp, regexec, print_double_string)
8487 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8488 (re_compile_pattern, re_exec): Declare arguments and local
8489 variables `size_t' and `ssize_t' and return values `regoff_t', as
8490 appropriate.
8491 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8492 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8493 <compile_stack_type>: `size' and `avail' are now `size_t'.
8494
8495 * regex.h <regoff_t>: Use ssize_t, not int.
8496 (re_search, re_search_2, re_match, re_match_2): Arguments that
8497 specify buffer/string position and length are now ssize_t and
8498 size_t. Return type is regoff_t.
8499
613052cd
BK
85002011-04-16 Ben Key <bkey76@gmail.com>
8501
8502 * nsfont.m: Fixed bugs in ns_get_family and
8503 ns_descriptor_to_entity that were caused by using free to
8504 deallocate memory blocks that were allocated by xmalloc (via
8505 xstrdup). This caused Emacs to crash when compiled with
8506 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8507 --enable-checking=xmallocoverrun). xfree is now used to
8508 deallocate these memory blocks.
8509
4170f62f 85102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8511
71b41406
PE
8512 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8513
9587a89d
PE
8514 emacs_write: Accept and return EMACS_INT for sizes.
8515 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8516 et seq.
8517 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8518 Accept and return EMACS_INT.
8519 (emacs_gnutls_write): Return the number of bytes written on
8520 partial writes.
8521 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8522 (emacs_read, emacs_write): Remove check for negative size, as the
8523 Emacs source code has been audited now.
9587a89d
PE
8524 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8525 (emacs_read, emacs_write): Use it.
273a5f82
PE
8526 * process.c (send_process): Adjust to the new signatures of
8527 emacs_write and emacs_gnutls_write. Do not attempt to store
8528 a byte offset into an 'int'; it might overflow.
9587a89d 8529 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8530
3e047f51
PE
8531 * sound.c: Don't assume sizes fit in 'int'.
8532 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8533 Return EMACS_INT, not int.
3e047f51 8534 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8535 Accept EMACS_INT, not int.
8536 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8537 record read return values.
8538
cc39a9db
BK
85392011-04-15 Ben Key <bkey76@gmail.com>
8540
c9d0ec6d
JB
8541 * keyboard.c (Qundefined): Don't declare static since it is used
8542 in nsfns.m.
8543 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8544 static since they are used in nsfont.m.
cc39a9db 8545
6c60eb9f
SM
85462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8547
8548 * process.c (Qprocessp): Don't declare static.
8549 * lisp.h (Qprocessp): Declare again.
8550
7990b61a
JB
85512011-04-15 Juanma Barranquero <lekktu@gmail.com>
8552
8553 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8554
5d4cb038
PE
85552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8556
8bd7b830 8557 Improve C-level modularity by making more things 'static'.
cd64ea1d 8558
e3b27b31
PE
8559 Don't publish debugger-only interfaces to other modules.
8560 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8561 (verify_bytepos, count_markers): Move decls to the only modules
8562 that need them.
8563 * region-cache.h (pp_cache): Likewise.
8564 * window.h (check_all_windows): Likewise.
8565 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8566
5d4cb038
PE
8567 * sysdep.c (croak): Now static, if
8568 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8569 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8570
8571 * alloc.c (refill_memory_reserve): Now static if
8572 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8573 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8574
e87b6180
PE
8575 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8576 Define only if USE_LUCID.
8577
ac64929e
PE
8578 * xrdb.c (x_customization_string, x_rm_string): Now static.
8579
6f37259d
PE
8580 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8581 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8582
1683e3ab
PE
8583 * xdisp.c (draw_row_with_mouse_face): Now static.
8584 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8585
de9c2632
PE
8586 * window.h (check_all_windows): Mark externally visible.
8587
2b96acb7
PE
8588 * window.c (window_deletion_count): Now static.
8589
8590 * undo.c: Make symbols static if they're not exported.
8591 (last_undo_buffer, last_boundary_position, pending_boundary):
8592 Now static.
8593
50436f33
PE
8594 * textprop.c (interval_insert_behind_hooks): Now static.
8595 (interval_insert_in_front_hooks): Likewise.
8596
64520e5c
PE
8597 * term.c: Make symbols static if they're not exported.
8598 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8599 (max_frame_lines, tty_set_terminal_modes):
8600 (tty_reset_terminal_modes, tty_turn_off_highlight):
8601 (get_tty_terminal): Now static.
8602 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8603 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8604 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8605 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8606 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8607
1fa53021
PE
8608 * sysdep.c: Make symbols static if they're not exported.
8609 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8610 Now static.
8611 (sigprocmask_set, full_mask): Remove; unused.
8612 (wait_debugging): Mark as visible.
8613 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8614 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8615
d4b43b22
PE
8616 * syntax.c (syntax_temp): Define only if !__GNUC__.
8617
b7c513d0
PE
8618 * sound.c (current_sound_device, current_sound): Now static.
8619
989b29ad
PE
8620 * search.c (searchbufs, searchbuf_head): Now static.
8621
13a55a78
PE
8622 * scroll.c (scroll_cost): Remove; unused.
8623 * dispextern.h (scroll_cost): Remove decl.
8624
de68a1fc
PE
8625 * region-cache.h (pp_cache): Mark as externally visible.
8626
40ccffa6
PE
8627 * process.c: Make symbols static if they're not exported.
8628 (process_tick, update_tick, create_process, chan_process):
8629 (Vprocess_alist, proc_buffered_char, datagram_access):
8630 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8631 (deactivate_process): Mark defn as static, as well as decl.
8632 * lisp.h (create_process): Remove decl.
8633 * process.h (chan_process, Vprocess_alist): Remove decls.
8634
ad64fc97
PE
8635 * print.c: Make symbols static if they're not exported.
8636 (print_depth, new_backquote_output, being_printed, print_buffer):
8637 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8638 (print_interval, print_number_index, initial_stderr_stream):
8639 Now static.
8640 * lisp.h (Fprinc): Remove decl.
8641 (debug_output_compilation_hack): Mark as externally visible.
8642
adddb265
PE
8643 * sysdep.c (croak): Move decl from here to syssignal.h.
8644 * syssignal.h (croak): Put it here, so the API can be checked when
8645 'croak' is called from dissociate_if_controlling_tty.
8646
1717ede2
PE
8647 * minibuf.c: Make symbols static if they're not exported.
8648 (minibuf_save_list, choose_minibuf_frame): Now static.
8649 * lisp.h (choose_minibuf_frame): Remove decl.
8650
fa5fb2bc
PE
8651 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8652
1e3890d1
PE
8653 * lread.c: Make symbols static if they're not exported.
8654 (read_objects, initial_obarray, oblookup_last_bucket_number):
8655 Now static.
8656 (make_symbol): Remove; unused.
8657 * lisp.h (initial_obarray, make_symbol): Remove decls.
8658
8a1414fa
PE
8659 * keyboard.c: Make symbols static if they're not exported.
8660 (single_kboard, recent_keys_index, total_keys, recent_keys):
8661 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8662 (this_single_command_key_start, echoing, last_auto_save):
8663 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8664 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8665 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8666 (Vlispy_mouse_stem, double_click_count):
8667 Now static.
8668 (force_auto_save_soon): Define only if SIGDANGER.
8669 (ignore_mouse_drag_p): Now static if
8670 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8671 (print_help): Remove; unused.
8672 (stop_character, last_timer_event): Mark as externally visible.
8673 * keyboard.h (ignore_mouse_drag_p): Declare only if
8674 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8675 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8676 * lisp.h (echoing): Remove decl.
8677 (force_auto_save_soon): Declare only if SIGDANGER.
8678 * xdisp.c (redisplay_window): Simplify code, to make it more
8679 obvious that ignore_mouse_drag_p is not accessed if !defined
8680 USE_GTK && !defined HAVE_NS.
8681
93ea6e8f
PE
8682 * intervals.c: Make symbols static if they're not exported.
8683 (merge_properties_sticky, merge_interval_right, delete_interval):
8684 Now static.
8685 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8686
77382fcc
PE
8687 * insdel.c: Make symbols static if they're not exported.
8688 However, leave prepare_to_modify_buffer alone. It's never
8689 called from outside this function, but that appears to be a bug.
8690 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8691 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8692 (adjust_after_replace_noundo): Remove; unused.
8693 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8694 (signal_before_change): Remove decls.
77382fcc 8695
9306c32e
PE
8696 * indent.c (val_compute_motion, val_vmotion): Now static.
8697
cd44d2eb
PE
8698 * image.c: Make symbols static if they're not exported.
8699 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8700 if USE_GTK.
8701 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8702 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8703
ad9a7a06
PE
8704 * fringe.c (standard_bitmaps): Now static.
8705 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8706
81626931
PE
8707 * frame.c: Make symbols static if they're not exported.
8708 (x_report_frame_params, make_terminal_frame): Now static.
8709 (get_frame_param): Now static, unless HAVE_NS.
8710 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8711 (x_get_resource_string): Remove; not used.
8712 * frame.h (make_terminal_frame, x_report_frame_params):
8713 (x_get_resource_string); Remove decls.
8714 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8715 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8716
239f9db9
PE
8717 * font.c, fontset.c: Make symbols static if they're not exported.
8718 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8719 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8720 * font.c (font_close_object): Now static.
8721 * font.h (font_close_object): Remove.
8722 * fontset.c (FONTSET_OBJLIST): Remove.
8723 (free_realized_fontset) #if-0 the body, which does nothing.
8724 (face_suitable_for_char_p): #if-0, as it's never called.
8725 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8726 * xfaces.c (face_at_string_position):
8727 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8728 since 0 is always ASCII.
8729
dfcf3579
PE
8730 * fns.c (weak_hash_tables): Now static.
8731
5045092b
PE
8732 * fileio.c: Make symbols static if they're not exported.
8733 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8734 (Vwrite_region_annotation_buffers): Now static.
8735
57a96f5c
PE
8736 * eval.c: Make symbols static if they're not exported.
8737 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8738 * lisp.h (backtrace_list): Remove decl.
8739
35f08c38
PE
8740 * emacs.c: Make symbols static if they're not exported.
8741 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8742 (fatal_error_code, fatal_error_signal_hook, standard_args):
8743 Now static.
8744 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8745 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8746 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8747 * lisp.h (fatal_error_signal_hook): Remove decl.
8748 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8749
f44bd759
PE
8750 * editfns.c: Move a (normally-unused) function to its only use.
8751 * editfns.c, lisp.h (get_operating_system_release): Remove.
8752 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8753 worth the hassle of breaking this out.
8754
b532497d
PE
8755 * xterm.c: Make symbols static if they're not exported.
8756 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8757 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8758 (x_destroy_window, x_delete_display):
8759 Now static.
8760 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8761 (x_mouse_leave): Remove; unused.
8762 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8763 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8764 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8765 Remove decls.
8766 (x_mouse_leave): Declare only if WINDOWSNT.
8767 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8768 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8769 USE_X_TOOLKIT.
8770
1675728f
PE
8771 * ftxfont.c: Make symbols static if they're not exported.
8772 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8773 HAVE_FREETYPE.
8774 * font.h (ftxfont_driver): Likewise.
8775
e4cebfca
PE
8776 * xfns.c: Make symbols static if they're not exported.
8777 (x_last_font_name, x_display_info_for_name):
8778 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8779 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8780 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8781 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8782 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8783 (last_show_tip_args): Now static.
8784 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8785 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8786 (x_screen_planes): Remove; unused.
8787 * dispextern.h (x_screen_planes): Remove decl.
8788
5bf46f05
PE
8789 * dispnew.c: Make symbols static if they're not exported.
8790 * dispextern.h (redraw_garbaged_frames, scrolling):
8791 (increment_row_positions): Remove.
8792 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8793 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8794 Now static.
8795 (redraw_garbaged_frames): Remove; unused.
8796
435f4c28
PE
8797 * xfaces.c: Make symbols static if they're not exported.
8798 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8799 Remove decls.
8800 * xterm.h (defined_color): Remove decls.
8801 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8802 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8803 (menu_face_changed_default, defined_color, free_realized_face):
8804 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8805 (ascii_face_of_lisp_face): Remove; unused.
8806
8524aef3
PE
8807 * xdisp.c: Make symbols static if they're not exported.
8808 * dispextern.h (scratch_glyph_row, window_box_edges):
8809 (glyph_to_pixel_coords, set_cursor_from_row):
8810 (get_next_display_element, set_iterator_to_next):
8811 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8812 (show_mouse_face): Remove decls
8813 * frame.h (message_buf_print): Likewise.
8814 * lisp.h (pop_message, set_message, check_point_in_composition):
8815 Likewise.
8816 * xterm.h (set_vertical_scroll_bar): Likewise.
8817 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8818 (message_buf_print, scratch_glyph_row, displayed_buffer):
8819 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8820 (get_next_display_element, show_mouse_face, window_box_edges):
8821 (frame_to_window_pixel_xy, check_point_in_composition):
8822 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8823 (glyph_to_pixel_coords): Remove; unused.
8824
16390cd2
PE
8825 * dired.c (file_name_completion): Now static.
8826
8827 * dbusbind.c (xd_in_read_queued_messages): Now static.
8828
a25f4dfa
PE
8829 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8830 * data.c (circular_list_error): Remove.
8831
14a9c8df
PE
8832 * commands.h (last_point_position, last_point_position_buffer):
8833 (last_point_position_window): Remove decls.
8834 * keyboard.c: Make these variables static.
8835
04f2d78b
CB
8836 * coding.h (coding, code_convert_region, encode_coding_gap):
8837 Remove decls.
74ab6df5
PE
8838 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8839 (iso_code_class, detect_coding, code_convert_region): Now static.
8840 (encode_coding_gap): Remove; unused.
8841
38dfbee1
PE
8842 * chartab.c (chartab_chars, chartab_bits): Now static.
8843
a2cb4e63
PE
8844 * charset.h (charset_iso_8859_1): Remove decl.
8845 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8846 Now static.
8847
127198fd
PE
8848 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8849 * ccl.c (Vccl_program_table): Now static.
8850 (check_ccl_update): Remove; unused.
8851
d85b608f
PE
8852 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8853 * category.h: ... from here.
8854 * category.c (check_category_table, set_category_set): Now static.
8855
31cd66f3
PE
8856 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8857 * lisp.h: Remove these decls.
8858
c358e587
PE
8859 * buffer.c (buffer_count): Remove unused var.
8860
e78aecca
PE
8861 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8862 so that it's not optimized away.
8863 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8864 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8865 exported only to the debugger.
8866
e192d7d3 8867 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8868 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8869
92470028
PE
8870 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8871 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8872 was inaccessible from Lisp.
8873 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8874 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8875
244ed907
PE
8876 alloc.c: Import and export fewer symbols, and remove unused items.
8877 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8878 is defined.
8879 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8880 it's not optimized away by whole-program optimization.
8881 (message_enable_multibyte, free_misc): Remove.
8882 (catchlist, handlerlist, mark_backtrace):
8883 Declare only if BYTE_MARK_STACK.
8884 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8885 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8886 (message_enable_multibyte): Remove decl.
8887 (free_misc, interval_free_list, float_block, float_block_index):
8888 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8889 (cons_free_list, last_marked_index):
8890 Now static.
8891 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8892 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8893 (mark_backtrace): Define only if BYTE_MARK_STACK.
8894 * xdisp.c (message_enable_multibyte): Now static.
8895
61c2b50e 8896 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8897 This makes it easier for human readers (and static analyzers)
8898 to see whether these variables are used from other modules.
8899 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8900 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8901 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8902 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8903 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8904 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8905 * xmenu.c, xselect.c:
8906 Declare Q* vars static if they are not used in other modules.
8907 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8908 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8909 Remove decls of unexported vars.
8910 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8911
95c82688
PE
8912 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8913
16a97296
PE
8914 Make Emacs functions such as Fatom 'static' by default.
8915 This makes it easier for human readers (and static analyzers)
8916 to see whether these functions can be called from other modules.
8917 DEFUN now defines a static function. To make the function external
8918 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8919 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8920 (Finit_image_library):
16a97296
PE
8921 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8922 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8923 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8924 Remove decls, since these functions are now static.
8925 (Funintern, Fget_internal_run_time): New decls, since these functions
8926 were already external.
95c82688 8927
16a97296
PE
8928 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8929 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8930 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8931 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8932 * keyboard.c, keymap.c, lread.c:
8933 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8934 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8935 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8936 Mark functions with DEFUE instead of DEFUN,
8937 if they are used in other modules.
8938 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8939 decls for now-static functions.
8940 * buffer.h (Fdelete_overlay): Remove decl.
8941 * callproc.c (Fgetenv_internal): Mark as internal.
8942 * composite.c (Fremove_list_of_text_properties): Remove decl.
8943 (Fcomposition_get_gstring): New forward static decl.
8944 * composite.h (Fcomposite_get_gstring): Remove decl.
8945 * dired.c (Ffile_attributes): New forward static decl.
8946 * doc.c (Fdocumntation_property): New forward static decl.
8947 * eval.c (Ffetch_bytecode): New forward static decl.
8948 (Funintern): Remove extern decl; now in .h file where it belongs.
8949 * fileio.c (Fmake_symbolic_link): New forward static decl.
8950 * image.c (Finit_image_library): New forward static decl.
8951 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8952 * intervals.h (Fprevious_property_change):
8953 (Fremove_list_of_text_properties): Remove decls.
8954 * keyboard.c (Fthis_command_keys): Remove decl.
8955 (Fcommand_execute): New forward static decl.
8956 * keymap.c (Flookup_key): New forward static decl.
8957 (Fcopy_keymap): Now static.
8958 * keymap.h (Flookup_key): Remove decl.
8959 * process.c (Fget_process): New forward static decl.
8960 (Fprocess_datagram_address): Mark as internal.
8961 * syntax.c (Fsyntax_table_p): New forward static decl.
8962 (skip_chars): Remove duplicate decl.
8963 * textprop.c (Fprevious_property_change): New forward static decl.
8964 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8965 Now internal.
8966 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8967 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8968
785bbd42
PE
8969 * editfns.c (Fformat): Remove unreachable code.
8970
8b913b57
AS
89712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8972
8973 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8974 change. (Bug#8496)
8975
a6744a35
EZ
89762011-04-13 Eli Zaretskii <eliz@gnu.org>
8977
8978 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8979 when at ZV. (Bug#8487)
8980
e7974947
AS
89812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8982
baad03f0
AS
8983 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8984 (Bug#8437)
8985 * keyboard.c (parse_tool_bar_item): Likewise.
8986 * sound.c (sound_cleanup, alsa_close): Likewise.
8987 * termcap.c (tgetent): Likewise.
8988 * xfns.c (x_default_font_parameter): Likewise.
8989 * xsettings.c (read_and_apply_settings): Likewise.
8990
e7974947
AS
8991 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8992 (overrun_check_free): Protoize.
8993
28272684
PE
89942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8995
8996 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8997 since callers should never pass a negative size.
8998 Change the signature to match that of plain 'read' and 'write'; see
8999 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9000 * lisp.h: Update prototypes of emacs_write and emacs_read.
9001
11997c76
EZ
90022011-04-11 Eli Zaretskii <eliz@gnu.org>
9003
9004 * xdisp.c (redisplay_window): Don't try to determine the character
9005 position of the scroll margin if the window start point w->startp
e896f03c 9006 is outside the buffer's accessible region. (Bug#8468)
11997c76 9007
8a2cbd72
EZ
90082011-04-10 Eli Zaretskii <eliz@gnu.org>
9009
9010 Fix write-region and its subroutines for buffers > 2GB.
9011 * fileio.c (a_write, e_write): Modify declaration of arguments and
9012 local variables to support buffers larger than 2GB.
9013 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9014
9015 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9016 argument, local variables, and return value.
9017
9018 * lisp.h: Update prototypes of emacs_write and emacs_read.
9019
9020 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9021
4073e537 90222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9023
1ebfdcb6
PE
9024 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9025
b2ded58d
PE
9026 Fix more problems found by GCC 4.6.0's static checks.
9027
7d66342c
PE
9028 * xdisp.c (vmessage): Use a better test for character truncation.
9029
bbf47d44
PE
9030 * charset.c (load_charset_map): <, not <=, for optimization,
9031 and to avoid potential problems with integer overflow.
9248994d 9032 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9033 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9034 * editfns.c (Fformat): Likewise.
1e69125e 9035 * syntax.c (skip_chars): Likewise.
3befa583 9036
e3019616
PE
9037 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9038 This also lets GCC 4.6.0 generate slightly better loop code.
9039
becfa255
PE
9040 * callint.c (Fcall_interactively): <, not <=, for optimization.
9041 (Fcall_interactively): Count the number of arguments produced,
9042 not the number of arguments given. This is simpler and lets GCC
9043 4.6.0 generate slightly better code.
9044
dae0cd48
PE
9045 * ftfont.c: Distingish more carefully between FcChar8 and char.
9046 The previous code passed unsigned char * to a functions like
9047 strlen and xstrcasecmp that expect char *, which does not
9048 conform to the C standard.
9049 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9050 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9051 char * when the C standard requires it.
9052
76032d70
PE
9053 * keyboard.c (read_char): Remove unused var.
9054
eb3f1cc8
PE
9055 * eval.c: Port to Windows vsnprintf (Bug#8435).
9056 Include <limits.h>.
9057 (SIZE_MAX): Define if the headers do not.
9058 (verror): Do not give up if vsnprintf returns a negative count.
9059 Instead, grow the buffer. This ports to Windows vsnprintf, which
9060 does not conform to C99. Problem reported by Eli Zaretskii.
9061 Also, simplify the allocation scheme, by avoiding the need for
9062 calling realloc, and removing the ALLOCATED variable.
9063
70476b54
PE
9064 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9065
12020a9e
PE
9066 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9067 But keep the doprint source code for now, as we might revamp it
9068 and use it again (Bug#8435).
ea6c7ae6
PE
9069 * lisp.h (doprnt): Remove.
9070 * Makefile.in (base_obj): Remove doprnt.o.
9071 * deps.mk (doprnt.o): Remove.
9072
5fdb398c
PE
9073 error: Print 32- and 64-bit integers portably (Bug#8435).
9074 Without this change, on typical 64-bit hosts error ("...%d...", N)
9075 was used to print both 32- and 64-bit integers N, which relied on
9076 undefined behavior.
61bdb816 9077 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9078 * lisp.h (error, verror): Mark as printf-like functions.
9079 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9080 Report overflow in size calculations when allocating printf buffer.
9081 Do not truncate output string at its first null byte.
9082 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9083 Truncate the output at a character boundary, since vsnprintf does not
9084 do that.
9085 * charset.c (check_iso_charset_parameter): Convert internal
9086 character to string before calling 'error', since %c now has the
9087 printf meaning.
9088 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9089 overflow when computing char to be passed to 'error'. Do not
9090 pass Lisp_Object to 'error'; pass the integer instead.
9091 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9092 formatted with plain %d.
9093
b189fa66
PE
9094 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9095
bff87ef0
PE
9096 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9097
7e2cac20
PE
9098 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9099
ce4d90b5
PE
9100 * xterm.c (x_catch_errors): Remove duplicate declaration.
9101
266c9547
PE
9102 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9103
79c49ad2
PE
9104 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9105
368f4090
JM
91062011-04-10 Jim Meyering <meyering@redhat.com>
9107
9108 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9109 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9110 return ssize_t not "int", and use size_t as the buffer length.
9111 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9112 * gnutls.h: Update declarations.
9113 * process.c (read_process_output): Use ssize_t, to match.
9114 (send_process): Likewise.
9115
a32d4040
CY
91162011-04-09 Chong Yidong <cyd@stupidchicken.com>
9117
9118 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9119
8546720e 91202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9121
04f2d78b
CB
9122 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9123 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9124
8546720e
GM
9125 * xterm.c (handle_one_xevent):
9126 * xmenu.c (create_and_show_popup_menu):
9127 * xselect.c (x_decline_selection_request)
9128 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9129
0a2f5c1a 91302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9131
9132 Fix some uses of `int' instead of EMACS_INT.
9133 * search.c (string_match_1, fast_string_match)
9134 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9135 (scan_buffer, find_next_newline_no_quit)
9136 (find_before_next_newline, search_command, Freplace_match)
9137 (Fmatch_data): Make some `int' variables be EMACS_INT.
9138
9139 * xdisp.c (display_count_lines): 3rd argument and return value now
9140 EMACS_INT. All callers changed.
9141 (pint2hrstr): Last argument is now EMACS_INT.
9142
9143 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9144 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9145 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9146 (decode_coding_utf_16, decode_coding_emacs_mule)
9147 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9148 (decode_coding_ccl, decode_coding_charset)
9149 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9150 (decode_coding_iso_2022, decode_coding_emacs_mule)
9151 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9152 <char_offset, last_offset>: Declare EMACS_INT.
9153 (encode_coding_utf_8, encode_coding_utf_16)
9154 (encode_coding_emacs_mule, encode_invocation_designation)
9155 (encode_designation_at_bol, encode_coding_iso_2022)
9156 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9157 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9158 Declare EMACS_INT.
9159 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9160 (encode_invocation_designation): Last argument P_NCHARS is now
9161 EMACS_INT.
9162 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9163 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9164
9165 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9166 All users changed.
9167
9168 * ccl.c (Fccl_execute_on_string): Declare some variables
9169 EMACS_INT.
9170
8546720e 91712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9172
9173 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9174
4e19a977
CS
91752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9176
9177 * process.c (Fformat_network_address): Doc fix.
9178
87302331
R
91792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9180
ee7683eb 9181 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9182
cbb59342
CY
91832011-04-08 Chong Yidong <cyd@stupidchicken.com>
9184
9185 * keyboard.c (read_char): Call Lisp function help-form-show,
9186 instead of using internal_with_output_to_temp_buffer.
9187 (Qhelp_form_show): New var.
e0d38eeb 9188 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9189
9190 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9191
9192 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9193
e67a13ab
CY
91942011-04-06 Chong Yidong <cyd@stupidchicken.com>
9195
04f2d78b
CB
9196 * process.c (Flist_processes): Remove to Lisp.
9197 (list_processes_1): Delete.
e67a13ab 9198
973f782d
EZ
91992011-04-06 Eli Zaretskii <eliz@gnu.org>
9200
7c106b1e
EZ
9201 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9202
973f782d
EZ
9203 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9204
41cf7d1a 92052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9206
ca23cc88
PE
9207 Fix more problems found by GCC 4.6.0's static checks.
9208
f390e2d5
PE
9209 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9210
42eea0d0
PE
9211 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9212
b69769da 9213 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9214
f9541e84
PE
9215 * xdisp.c (vmessage): Mark as a printf-like function.
9216
13841b55
PE
9217 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9218
c136c10f
PE
9219 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9220
5e2d4a30
PE
9221 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9222 printf-like functions.
9223 (tiff_load): Add casts to remove these marks before passing them
9224 to system-supplied API.
9225
583f48b9
PE
9226 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9227
b25d760e
PE
9228 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9229 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
9230 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9231 directly, rather than having caller test rule sign. This avoids
9232 some unnecessary tests.
9233 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9234 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9235 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 9236
bc7b6697 9237 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 9238 (xfont_open): Avoid unnecessary tests.
bc7b6697 9239
27ccc379
PE
9240 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9241
dcd5c89a
PE
9242 * composite.h, composite.c (composition_gstring_put_cache):
9243 Use EMACS_INT, not int, for length.
9244
b13a45c6
PE
9245 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9246 breaking out part of COMPOSITION_DECODE_RULE.
9247 (COMPOSITION_DECODE_RULE): Use it.
9248 * composite.c (get_composition_id): Remove unused local vars,
9249 by using the new macro.
9250
1e792e4d
PE
9251 * textprop.c (set_text_properties_1): Change while to do-while,
9252 since the condition is always true at first.
9253
dc6c6455 9254 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
9255 (interval_deletion_adjustment): Return unsigned value.
9256 All uses changed.
dc6c6455 9257
aba7731a
PE
9258 * process.c (list_processes_1, create_pty, read_process_output):
9259 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9260 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9261 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9262 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9263 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9264
fdfc4bf3
PE
9265 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9266
fca8fe46 9267 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9268 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9269
06a0259a 9270 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9271 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9272 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9273
e7b9e80f
PE
9274 * print.c (print_error_message): Avoid int overflow.
9275
56201685
PE
9276 * font.c (font_list_entities): Redo for clarity,
9277 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9278
78834453 9279 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9280 (font_score): Avoid potential overflow in diff calculation.
78834453 9281
0bc0b309 9282 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9283 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9284
e610eaca
PE
9285 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9286
b895abce
PE
9287 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9288 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9289 can always succeed if overflow has undefined behavior.
9290
1f1d9321 9291 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9292 (wordify): Omit three unnecessary tests.
1f1d9321 9293
c59478bc
PE
9294 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9295 All callers changed. This avoids the need for an unused var.
9296
79b73827
PE
9297 * casefiddle.c (casify_region): Remove var that is set but not used.
9298
a4db5dfe
PE
9299 * dired.c (file_name_completion): Remove var that is set but not used.
9300
43aae36e
PE
9301 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9302
2a47c44d 9303 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9304 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9305
a37c69bf
PE
9306 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9307 Check for integer overflow on size calculations.
9308
328ab8e7
PE
9309 * buffer.c (Fprevious_overlay_change): Remove var that is set
9310 but not used.
9311
e5a2a5cb
PE
9312 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9313 Remove vars that are set but not used.
8d84a6eb 9314 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9315 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9316
a60e5f68
PE
9317 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9318
f661cb61 9319 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9320 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9321
f0397f5a
PE
9322 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9323 that are set but not used.
9324
8664db06 9325 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9326 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9327
6abdaa4a
PE
9328 * xselect.c (x_get_local_selection, x_handle_property_notify):
9329 Remove vars that are set but not used.
9330
0ce7538d 9331 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9332 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9333
9ae848fc
PE
9334 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9335 Remove var that is set but not used.
0b918413
PE
9336 (scroll_bar_windows_size): Now size_t, not int.
9337 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9338 Check for overflow.
9ae848fc 9339
a5a62657
PE
9340 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9341 (map_tty_color) [!defined MSDOS]: Likewise.
9342
5c5cdd39
PE
9343 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9344
66ebf983
PE
9345 * coding.c: Remove vars that are set but not used.
9346 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9347 All callers changed.
9348 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9349 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9350 (decode_coding_charset): Remove vars that are set but not used.
9351
1be4d761
PE
9352 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9353 that is set but not used.
9354
47553fa8
PE
9355 * print.c (print_object): Remove var that is set but not used.
9356
1f7196bf 9357 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9358 The gnulib version avoids calling malloc in the usual case,
9359 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9360 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9361 * filelock.c (current_lock_owner): Likewise.
9362 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9363 * sysdep.c: Include allocator.h, careadlinkat.h.
9364 (emacs_no_realloc_allocator): New static constant.
9365 (emacs_readlink): New function.
fdb61804
PE
9366 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9367 ../lib/careadlinkat.h.
d1fdcab7 9368
f84c17c7
SM
93692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9370
9371 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9372 first non-nil return value).
9373
ef3862ad
JD
93742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9375
9376 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9377 if not defined (Bug#8403).
9378
376a7006
JB
93792011-04-02 Juanma Barranquero <lekktu@gmail.com>
9380
9381 * xdisp.c (display_count_lines): Remove parameter `start',
9382 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9383 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9384 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9385 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9386 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9387 and thereabouts. All callers changed.
9388 (get_per_char_metric): Remove parameter `f', unused since
9389 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9390
6ca3801d
JM
93912011-04-02 Jim Meyering <meyering@redhat.com>
9392
9393 do not dereference NULL upon failed strdup
9394 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9395 (ns_get_family): Likewise.
9396
d8e2b5ba
JB
93972011-04-02 Juanma Barranquero <lekktu@gmail.com>
9398
9399 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9400
8c74fcbd
JD
94012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9402
9403 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9404 later (Bug#8403).
9405
7200d79c
SM
94062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9407
03408648 9408 Add lexical binding.
7200d79c 9409
03408648
SM
9410 * window.c (Ftemp_output_buffer_show): New fun.
9411 (Fsave_window_excursion):
9412 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9413
9414 * lread.c (lisp_file_lexically_bound_p): New function.
9415 (Fload): Bind Qlexical_binding.
9416 (readevalloop): Remove `evalfun' arg.
9417 Bind Qinternal_interpreter_environment.
9418 (Feval_buffer): Bind Qlexical_binding.
9419 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9420 Mark as dynamic.
9421 (syms_of_lread): Declare `lexical-binding'.
9422
9423 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9424
9425 * keyboard.c (eval_dyn): New fun.
9426 (menu_item_eval_property): Use it.
ca105506
SM
9427
9428 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9429
03408648
SM
9430 * fns.c (concat, mapcar1): Accept byte-code-functions.
9431
9432 * eval.c (Fsetq): Handle lexical vars.
9433 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9434 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9435 (FletX, Flet): Obey lexical binding.
9436 (Fcommandp): Handle closures.
9437 (Feval): New `lexical' arg.
9438 (eval_sub): New function extracted from Feval. Use it almost
9439 everywhere where Feval was used. Look up vars in lexical env.
9440 Handle closures.
9441 (Ffunctionp): Move from subr.el.
9442 (Ffuncall): Handle closures.
9443 (apply_lambda): Remove `eval_flags'.
9444 (funcall_lambda): Handle closures and new byte-code-functions.
9445 (Fspecial_variable_p): New function.
9446 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9447 but without exporting it to Lisp.
23aba0ea 9448
23aba0ea 9449 * doc.c (Fdocumentation, store_function_docstring):
03408648 9450 * data.c (Finteractive_form): Handle closures.
23aba0ea 9451
03408648
SM
9452 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9453 interactive spec.
ba83908c 9454
04f2d78b
CB
9455 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9456 New byte-codes.
03408648
SM
9457 (exec_byte_code): New function extracted from Fbyte_code to handle new
9458 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9459
03408648 9460 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9461
03408648 9462 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9463
e2abce01
JB
94642011-03-31 Juanma Barranquero <lekktu@gmail.com>
9465
9466 * xdisp.c (redisplay_internal): Fix prototype.
9467
63696a73 94682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9469
63696a73 9470 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9471 (try_scrolling): Use it when setting scroll_limit.
9472 Limit scrolling to 100 screen lines.
63696a73
EZ
9473 (redisplay_window): Even when falling back on "recentering",
9474 position point in the window according to scroll-conservatively,
9475 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9476
9477 (try_scrolling): When point is above the window, allow searching
9478 as far as scroll_max, or one screenful, to compute vertical
9479 distance from PT to the scroll margin position. This prevents
9480 try_scrolling from unnecessarily failing when
9481 scroll-conservatively is set to a value slightly larger than the
9482 window height. Clean up the case of PT below the margin at bottom
9483 of window: scroll_max can no longer be INT_MAX. When aggressive
9484 scrolling is in use, don't let point enter the opposite scroll
9485 margin as result of the scroll.
9486 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9487 threshold of 100 lines for never-recentering scrolling.
9488
e4cc2dfc
JB
94892011-03-31 Juanma Barranquero <lekktu@gmail.com>
9490
9491 * dispextern.h (move_it_by_lines):
9492 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9493 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9494 (message_log_check_duplicate): Remove parameters `prev_bol' and
9495 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9496 (redisplay_internal): Remove parameter `preserve_echo_area',
9497 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9498
9499 * indent.c (Fvertical_motion):
9500 * window.c (window_scroll_pixel_based, Frecenter):
9501 Don't pass `need_y_p' to `move_it_by_lines'.
9502
1c470562
SM
95032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9504
44f230aa
SM
9505 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9506 steal a few bits to be more compact.
9507 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9508 Remove unneeded casts.
9509
1c470562
SM
9510 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9511
888adce9
ZK
95122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9513
9514 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9515 binding" message (bug#7967).
9516
f838ed7b
PE
95172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9518
77861b95
PE
9519 Fix more problems found by GCC 4.6.0's static checks.
9520
de6dbc14
PE
9521 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9522 Remove unused local var.
9523
f838ed7b
PE
9524 * editfns.c (Fmessage_box): Remove unused local var.
9525
792c7b2b
PE
9526 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9527 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9528 Omit unused local vars.
c499e557 9529 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9530 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9531 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9532 Omit unused local var.
9533
ba0165e1
PE
9534 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9535 Don't assume string length fits in int.
32ad8845 9536 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9537 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9538
3c59b4c9
PE
9539 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9540 instead of alloca (Bug#8344).
9541
a3eed478 9542 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9543 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9544
eb4d412d
PE
9545 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9546
1658b401
PE
9547 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9548 concerns.
9549
9550 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9551
9552 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9553
9a2c6e05
PE
9554 * keyboard.c (syms_of_keyboard): Use the same style as later
9555 in this function when indexing through an array. This also
9556 works around GCC bug 48267.
9557
03d0a109
PE
9558 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9559
44f730c8
PE
9560 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9561
fe75f926
PE
9562 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9563 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9564
ffa8c828
PE
9565 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9566 This avoids undefined behavior on integer overflow, and is a bit
9567 more convenient anyway since it is compared to a size_t variable.
9568
c5101a77
PE
9569 Variadic C functions now count arguments with size_t, not int.
9570 This avoids an unnecessary limitation on 64-bit machines, which
9571 caused (substring ...) to crash on large vectors (Bug#8344).
9572 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9573 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9574 All variadic functions and their callers changed accordingly.
c5101a77
PE
9575 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9576 * data.c (arith_driver, float_arith_driver): Likewise.
9577 * editfns.c (general_insert_function): Likewise.
9578 * eval.c (struct backtrace.nargs, interactive_p)
9579 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9580 (funcall_lambda, mark_backtrace): Likewise.
9581 * fns.c (concat): Likewise.
9582 * frame.c (x_set_frame_parameters): Likewise.
9583 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9584 0 if not found, not -1. All callers changed.
9585
dd3f25f7
PE
9586 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9587 (stack_copy_size): Now size_t, not int.
9588 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9589
461c2ab9
JB
95902011-03-28 Juanma Barranquero <lekktu@gmail.com>
9591
9592 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9593 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9594 All callers changed.
9595
9596 * lisp.h (multibyte_char_to_unibyte):
9597 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9598 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9599 * character.h (CHAR_TO_BYTE8):
9600 * cmds.c (internal_self_insert):
9601 * editfns.c (general_insert_function):
9602 * keymap.c (push_key_description):
9603 * search.c (Freplace_match):
9604 * xdisp.c (message_dolog, set_message_1): All callers changed.
9605
f6d62986
SM
96062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9607
9608 * keyboard.c (safe_run_hook_funcall): New function.
9609 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9610 don't set the hook to nil, but remove the offending function instead.
9611 (Qcommand_hook_internal): Remove, unused.
9612 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9613 Vcommand_hook_internal.
9614
9615 * eval.c (enum run_hooks_condition): Remove.
9616 (funcall_nil, funcall_not): New functions.
9617 (run_hook_with_args): Call each function through a `funcall' argument.
9618 Remove `cond' argument, now redundant.
9619 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9620 (Frun_hook_with_args_until_failure): Adjust accordingly.
9621 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9622
1db5b1ad
JB
96232011-03-28 Juanma Barranquero <lekktu@gmail.com>
9624
9625 * dispextern.h (string_buffer_position): Remove declaration.
9626
9627 * print.c (strout): Remove parameter `multibyte', unused since
9628 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9629
9630 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9631 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9632 All callers changed.
9633
9634 * w32.c (_wsa_errlist): Use braces for struct initializers.
9635
9636 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9637 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9638 All callers changed.
9639 (string_buffer_position): Likewise. Also, make static (it's never
9640 used outside xdisp.c).
9641 (cursor_row_p): Remove parameter `w', unused since
9642 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9643 (decode_mode_spec): Remove parameter `precision', introduced during
9644 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9645 All callers changed.
9646
5ffb62aa
JD
96472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9648
9649 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9650
461c2ab9 96512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9652
9653 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9654 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9655 (ns_update_auto_hide_menu_bar): New functions.
9656 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9657 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9658 ns_constrain_all_frames.
9659 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9660 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9661
5c380ffb
JD
96622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9663
9664 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9665
9af30bdf
GM
96662011-03-27 Glenn Morris <rgm@gnu.org>
9667
9668 * syssignal.h: Replace RETSIGTYPE with void.
9669 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9670 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9671 Replace SIGTYPE with void everywhere.
9672 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9673 * s/template.h (SIGTYPE): Remove commented out definition.
9674
e2abce01
JB
96752011-03-26 Eli Zaretskii <eliz@gnu.org>
9676
9677 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9678 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9679
f868cd8a
JB
96802011-03-26 Juanma Barranquero <lekktu@gmail.com>
9681
59eb0929
JB
9682 * w32.c (read_unc_volume): Use parameter `henum', instead of
9683 global variable `wget_enum_handle'.
9684
9685 * keymap.c (describe_vector): Remove parameters `indices' and
9686 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9687 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9688
f868cd8a
JB
9689 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9690
9691 * keyboard.c (timer_check): Remove parameter `do_it_now',
9692 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9693 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9694 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9695
9696 * keyboard.c (read_char):
9697 * w32menu.c (w32_menu_display_help):
9698 * xmenu.c (show_help_event, menu_help_callback):
9699 Adjust calls to `show_help_echo'.
9700
9701 * gtkutil.c (xg_maybe_add_timer):
9702 * keyboard.c (readable_events):
9703 * process.c (wait_reading_process_output):
9704 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9705
9706 * insdel.c (adjust_markers_gap_motion):
9707 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9708 (gap_left, gap_right): Don't call it.
9709
2ecf6fdb
CY
97102011-03-25 Chong Yidong <cyd@stupidchicken.com>
9711
9712 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9713 incurred during fontification.
9714
6b1f9ba4
JB
97152011-03-25 Juanma Barranquero <lekktu@gmail.com>
9716
9717 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9718 (DEFVAR_PER_BUFFER): Don't pass it.
9719
9720 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9721 (scrolling_window): Don't pass it.
9722
0f4a96b5
JB
97232011-03-25 Juanma Barranquero <lekktu@gmail.com>
9724
9725 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9726
9727 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9728 and `suffix'.
9729 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9730 of variables specific to SELinux and computation of `encoded_absname'.
9731
9732 * image.c (XPutPixel): Remove unused variable `height'.
9733
9734 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9735
9736 * unexw32.c (get_section_info): Remove unused variable `section'.
9737
9738 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9739 (system_process_attributes): Remove unused variable `sess'.
9740 (sys_read): Remove unused variable `err'.
9741
9742 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9743 (w32_wnd_proc): Remove unused variable `isdead'.
9744 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9745 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9746 (x_create_tip_frame): Remove unused variable `tem'.
9747
9748 * w32inevt.c (w32_console_read_socket):
9749 Remove unused variable `no_events'.
9750
9751 * w32term.c (x_draw_composite_glyph_string_foreground):
9752 Remove unused variable `width'.
9753
1149507c
JB
97542011-03-24 Juanma Barranquero <lekktu@gmail.com>
9755
9756 * w32term.c (x_set_glyph_string_clipping):
9757 Don't pass uninitialized region to CombineRgn.
9758
9c88f339
JB
97592011-03-23 Juanma Barranquero <lekktu@gmail.com>
9760
9761 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9762 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9763 (Fx_close_connection): Remove unused variable `i'.
9764
9765 * w32font.c (w32font_draw): Return number of glyphs.
9766 (w32font_open_internal): Remove unused variable `i'.
9767 (w32font_driver): Add missing initializer.
9768
9769 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9770 (fill_in_menu): Remove unused variable `items_added'.
9771
9772 * w32term.c (last_mouse_press_frame): Remove static global variable.
9773 (w32_clip_to_row): Remove unused variable `f'.
9774 (x_delete_terminal): Remove unused variable `i'.
9775
9776 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9777 (NOTHING): Remove unused static global variable.
9778 (uniscribe_check_otf): Remove unused variable `table'.
9779 (uniscribe_font_driver): Add missing initializers.
9780
dee091a3
JD
97812011-03-23 Julien Danjou <julien@danjou.info>
9782
9783 * term.c (Fsuspend_tty, Fresume_tty):
9784 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9785 * window.c (temp_output_buffer_show):
9786 * insdel.c (signal_before_change):
9787 * frame.c (Fhandle_switch_frame):
9788 * fileio.c (Fdo_auto_save):
9789 * emacs.c (Fkill_emacs):
9790 * editfns.c (save_excursion_restore):
9791 * cmds.c (internal_self_insert):
9792 * callint.c (Fcall_interactively):
9793 * buffer.c (Fkill_all_local_variables):
9794 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9795 Use Frun_hooks.
0f4a96b5 9796 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9797 unconditionally since it does the check itself.
dee091a3 9798
2c520ab5 97992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9800
c9c49752
PE
9801 Fix more problems found by GCC 4.5.2's static checks.
9802
8abc3f12
PE
9803 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9804 the first time through the loop, since we know p0 < p1 then.
9805 This also avoids a gcc -Wstrict-overflow warning.
9806
a2d26660
PE
9807 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9808 leading to a memory leak, possible in functions like
9809 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9810 of objects (Bug#8318).
a2d26660 9811
916c72e9
PE
9812 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9813 that could (at least in theory) be that large.
9814
19ab8a18
PE
9815 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9816 This is less likely to overflow, and avoids undefined behavior if
9817 overflow does occur. All callers changed. Use strtoul to scan
9818 for the unsigned long integer.
b7cbbd6f
PE
9819 (pint2hrstr): Simplify and tune code slightly.
9820 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9821
f0641eff
PE
9822 * scroll.c (do_scrolling): Work around GCC bug 48228.
9823 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9824
7f650bb9
PE
9825 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9826 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9827 (validate_x_resource_name): Simplify count usage.
9828 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9829
37dd57d1
PE
9830 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9831 fail (Bug#8306).
81e56e61 9832
699979fc 9833 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9834
401bf9b4
PE
9835 * process.c (Fmake_network_process): Use socklen_t, not int,
9836 where POSIX says socklen_t is required in portable programs.
9837 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9838 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9839 (Fmake_network_process, server_accept_connection):
9840 (wait_reading_process_output, read_process_output):
9841 Likewise.
9842
b93aacde
PE
9843 * process.c: Rename or move locals to avoid shadowing.
9844 (list_processes_1, Fmake_network_process):
9845 (read_process_output_error_handler, exec_sentinel_error_handler):
9846 Rename or move locals.
4dc343ee 9847 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9848 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9849 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9850 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9851 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9852
af8a867c 9853 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9854 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9855 Include tparam.h instead, since it declares them.
af8a867c
PE
9856 * cm.h (PC): Remove extern decl; tparam.h now does this.
9857 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9858 * terminfo.c: Include tparam.h, to check interfaces.
9859 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9860 (tparam): Adjust signature to match interface in tparam.h;
9861 this removes some undefined behavior. Check that outstring and len
9862 are zero, which they always are with Emacs.
9863 * tparam.h (PC, BC, UP): New extern decls.
9864
0248044d 9865 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9866 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9867
8ff096c1 9868 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9869 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9870 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9871 (ftfont_list): Remove unused local.
49eaafba
PE
9872 (get_adstyle_property, ftfont_pattern_entity):
9873 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9874 Rename locals to avoid shadowing.
8ff096c1 9875
e2be39f6
PE
9876 * xfont.c (xfont_list_family): Mark var as initialized.
9877
c9735e30
PE
9878 * xml.c (make_dom): Now static.
9879
8f5201ae
PE
9880 * composite.c (composition_compute_stop_pos): Rename local to
9881 avoid shadowing.
b246f932
PE
9882 (composition_reseat_it): Remove unused locals.
9883 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9884 (composition_update_it): Mark var as initialized.
11b61122
PE
9885 (find_automatic_composition): Mark vars as initialized,
9886 with a FIXME (Bug#8290).
8f5201ae 9887
760fbc2c
PE
9888 character.h: Rename locals to avoid shadowing.
9889 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9890 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9891 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9892 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9893 to avoid shadowing.
9894
ff08eb85
PE
9895 * textprop.c (property_change_between_p): Remove; unused.
9896
fc7bf025
PE
9897 * intervals.c (interval_start_pos): Now static.
9898
235d7abc
PE
9899 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9900
44f230aa
SM
9901 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9902 Rename locals to avoid shadowing.
3e7d6594 9903
50060332
PE
9904 * sound.c (wav_play, au_play, Fplay_sound_internal):
9905 Fix pointer signedness.
d01f234b 9906 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9907 (wav_play): Initialize a variable to 0, to prevent undefined
9908 behavior (Bug#8278).
50060332 9909
c4fc4e30
PE
9910 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9911
918436ed
PE
9912 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9913
c939f91b
PE
9914 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9915 clobbering (Bug#8298).
b9c7f648
PE
9916 * sysdep.c (sys_subshell): Likewise.
9917 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9918
6bd8c144
PE
9919 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9920 This should get cleaned up, so that child_setup has the
9921 same signature on all platforms.
9922
7710357c 9923 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9924 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9925
c59da222
CY
99262011-03-22 Chong Yidong <cyd@stupidchicken.com>
9927
9928 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9929 not to be necessary, and produces flickering.
9930
66b87493
GM
99312011-03-20 Glenn Morris <rgm@gnu.org>
9932
9933 * config.in: Remove file.
9934
45b6f6d5
JB
99352011-03-20 Juanma Barranquero <lekktu@gmail.com>
9936
9937 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9938 are now in src/globals.h.
9939 (syms_of_minibuf): Remove spurious & from previous change.
9940
cd394be1 99412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9942
9943 * minibuf.c (completing-read-function): New variable.
9944 (completing-read-default): Rename from completing-read.
9945 (completing-read): Call completing-read-function.
9946
b14e3e21
CY
99472011-03-19 Juanma Barranquero <lekktu@gmail.com>
9948
9949 * xfaces.c (Fx_load_color_file):
9950 Read color file from absolute filename (bug#8250).
9951
f2b726e6
JB
99522011-03-19 Juanma Barranquero <lekktu@gmail.com>
9953
9954 * makefile.w32-in: Update dependencies.
9955
09f6ff02
EZ
99562011-03-17 Eli Zaretskii <eliz@gnu.org>
9957
9958 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9959
29a6015a
PE
99602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9961
a3a6c54e
PE
9962 Fix more problems found by GCC 4.5.2's static checks.
9963
b766f867
PE
9964 * process.c (make_serial_process_unwind, send_process_trap):
9965 (sigchld_handler): Now static.
9966
be02381c
PE
9967 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9968 That way, the code declares only the vars that it needs.
9969 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9970 * s/cygwin.h (PTY_ITERATION): Likewise.
9971 * s/darwin.h (PTY_ITERATION): Likewise.
9972 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9973
57048744
PE
9974 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9975 * process.c (allocate_pty): Don't declare stb unless it's needed.
9976
7914961c 9977 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9978 (CONSTANTLIM): Remove; unused.
9979 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9980 Define only if needed.
7914961c 9981
b3967b18
PE
9982 * unexelf.c (unexec): Name an expression,
9983 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9984 Use a different way to cause a compilation error if anyone uses
9985 n rather than nn, a way that does not involve shadowing.
73366a00 9986 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9987
29a6015a
PE
9988 * deps.mk (unexalpha.o): Remove; unused.
9989
43cfc33e 9990 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9991 * unexec.h: New file.
ce701a33
PE
9992 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9993 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9994 Depend on unexec.h.
9995 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9996 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9997 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9998 Change as necessary to match prototype in unexec.h.
ce701a33 9999
01f44d5a
PE
10000 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10001 shadowing.
4f63c6bb 10002 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10003
a6670b0b
PE
10004 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10005 Rename locals to avoid shadowing.
10006
cef2010d 10007 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10008 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10009
d4d7173a
PE
10010 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10011
f08b802a
PE
10012 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10013 warning when compiling print.c.
10014
3ddb0639
PE
10015 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10016 instead of using an uninitialized var.
5ad03b97 10017 (font_sort_entities): Mark var as initialized.
3ddb0639 10018
170a2692
PE
10019 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10020
e663c700
PE
10021 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10022 pointers to constants.
89bc529a 10023 (font_parse_fcname): Remove unused vars.
7b81e2d0 10024 (font_delete_unmatched): Now static.
ea838e10 10025 (font_get_spec): Remove; unused.
13a547c6
PE
10026 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10027 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10028 Rename or move locals to avoid shadowing.
e663c700 10029
2a80c887 10030 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10031 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10032
1384fa33 10033 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10034 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10035
8b2c52e9
PE
10036 * alloc.c (mark_backtrace): Move decl from here ...
10037 * lisp.h: ... to here, so that it can be checked.
10038
475545b5 10039 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10040 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10041 (lisp_indirect_variable): Name an expression,
10042 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10043 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10044
b1349114 10045 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10046 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10047 Use const pointer when appropriate.
b1349114 10048
a2928364
PE
10049 * lisp.h (get_system_name, get_operating_system_release):
10050 Move decls here, to check interfaces.
10051 * process.c (get_operating_system_release): Move decl to lisp.h.
10052 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10053 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10054 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10055 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10056 (Fformat_time_string, Fencode_time, Finsert_char):
10057 (Ftranslate_region_internal, Fformat):
10058 Rename or remove local vars to avoid shadowing.
9710023e 10059 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10060
a415e694
PE
10061 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10062 avoid shadowing.
10063
8ef4622d
PE
10064 * lisp.h (eassert): Check that the argument compiles, even if
10065 ENABLE_CHECKING is not defined.
10066
946f9a5b
PE
10067 * data.c (Findirect_variable): Name an expression, to avoid
10068 gcc -Wbad-function-cast warning.
112396d6 10069 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10070 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10071 (Fmake_variable_buffer_local, Fmake_local_variable):
10072 Mark variables as initialized.
52746918 10073 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10074
e5aab7e7 10075 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10076 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10077 Rename locals to avoid shadowing.
dff45157
PE
10078 (mark_stack): Move local variables into the #ifdef region where
10079 they're used.
7bc26fdb
PE
10080 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10081 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10082 needed otherwise.
10083 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10084 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10085 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10086
e5aab7e7
PE
10087 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10088 avoids undefined behavior in theory.
10089
4da60324
PE
10090 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10091
88043301
PE
10092 Use functions, not macros, for up- and down-casing (Bug#8254).
10093 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10095 to use the following functions instead of these macros.
10096 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10097 EMACS_INT, since callers assume the returned value fits in int.
10098 (upcase1): Likewise, for UPCASE_TABLE.
10099 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10100 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10101 the race-condition problem in the old DOWNCASE.
88043301 10102
19ed5445
PE
10103 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10104 Rename locals to avoid shadowing.
10105 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10106 (regex_compile, re_search_2, re_match_2_internal):
10107 Remove unused local vars.
952db0d7
PE
10108 (FREE_VAR): Rewrite so as not to use empty "else",
10109 which gcc can warn about.
da053e48 10110 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10111 (RETALLOC_IF): Define only if needed.
10112 (WORDCHAR_P): Likewise. This one is never needed, but is used
10113 only in a comment talking about a compiler bug, so put inside
10114 the #if 0 of that comment.
10115 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10116 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10117 Remove; unused.
19ed5445 10118
1f3561e4 10119 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10120 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10121 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10122
ded6f8f7
PE
10123 * search.c (simple_search): Remove unused var.
10124
dbd37a95
PE
10125 * dired.c (compile_pattern): Move decl from here ...
10126 * lisp.h: ... to here, so that it can be checked.
10127 (struct re_registers): New forward decl.
10128
7e47afad
PE
10129 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10130
85f24f61
PE
10131 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10132 All uses changed.
10133 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10134 Rename locals to avoid shadowing.
5671df8f 10135 (Fvertical_motion): Mark locals as initialized.
85f24f61 10136
181aa2be 10137 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10138 (casify_region): Mark local as initialized.
181aa2be 10139
930d429c
PE
10140 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10141
7082eac6
PE
10142 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10143 New macros, so that the caller can use some names other than
10144 gcpro1, gcpro2, etc.
10145 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10146 of the new macros.
10147 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10148 argument, for consistency with GCPRO2_VAR, etc: it is now the
10149 prefix of the variable, not the variable itself. All uses
10150 changed.
38b2c076
PE
10151 * dired.c (directory_files_internal, file_name_completion):
10152 Rename locals to avoid shadowing.
10153
15206ed9
PE
10154 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10155 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10156 dired.c's scmp function, had undefined behavior.
10157 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10158 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10159 * buffer.h: ... to here, because these macros use current_buffer,
10160 and the new implementation with inline functions needs to have
10161 current_buffer in scope now, rather than later when the macros
10162 are used.
10163 (downcase, upcase1): New static inline functions.
10164 (DOWNCASE, UPCASE1): Reimplement using these functions.
10165 This avoids undefined behavior in expressions like
10166 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10167 from race conditions in accessing the global variables
10168 case_temp1 and case_temp2.
10169 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10170 * lisp.h (case_temp1, case_temp2): Remove their decls.
10171 * character.h (ASCII_CHAR_P): Move from here ...
10172 * lisp.h: ... to here, so that the inline functions mentioned
10173 above can use them.
10174
4a6bea26
PE
10175 * dired.c (directory_files_internal_unwind): Now static.
10176
f14b7e14
PE
10177 * fileio.c (file_name_as_directory, directory_file_name):
10178 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10179 Now static.
2893f146
PE
10180 (file_name_as_directory): Use const pointers when appropriate.
10181 (Fexpand_file_name): Likewise. In particular, newdir might
10182 point at constant storage, so make it a const pointer.
fd4ead52 10183 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10184 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10185 signedness issues.
f839df0c
PE
10186 (Fset_file_times, Finsert_file_contents, auto_save_error):
10187 Rename locals to avoid shadowing.
f14b7e14 10188
5716756e 10189 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10190 (Ftry_completion, Fall_completions): Rename or remove locals
10191 to avoid shadowing.
5716756e 10192
b4c3046a
PE
10193 * marker.c (bytepos_to_charpos): Remove; unused.
10194
b45db522
PE
10195 * lisp.h (verify_bytepos, count_markers): New decls,
10196 so that gcc does not warn that these functions aren't declared.
10197
85876d07
PE
10198 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10199 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10200 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10201 (copy_text): Remove unused local var.
85876d07 10202
03d78a21 10203 * filelock.c (within_one_second): Now static.
b3dd38ab 10204 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10205
5df8f01b
PE
10206 * buffer.c (fix_overlays_before): Mark locals as initialized.
10207 (fix_start_end_in_overlays): Likewise. This function should be
10208 simplified by using pointers-to-pointers, but that's a different
10209 matter.
b1d876f1 10210 (switch_to_buffer_1): Now static.
8f54f30a
PE
10211 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10212 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10213
a70072c9 10214 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10215 Fix pointer signedness issue.
edced198
PE
10216 (sys_subshell): Mark local as volatile if checking for lint,
10217 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10218 (MAXPATHLEN): Define only if needed.
a70072c9 10219
a0977c44
PE
10220 * process.c (serial_open, serial_configure): Move decls from here ...
10221 * systty.h: ... to here, so that they can be checked.
10222
a884fdcc
PE
10223 * fns.c (get_random, seed_random): Move extern decls from here ...
10224 * lisp.h: ... to here, so that they can be checked.
10225
604efe86 10226 * sysdep.c (reset_io): Now static.
b8950c94 10227 (wait_for_termination_signal): Remove; unused.
604efe86 10228
38fc62d9
PE
10229 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10230 (copy_keymap_item, append_key, push_text_char_description):
10231 Now static.
1004a21a 10232 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 10233 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
10234 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10235 (describe_map_tree):
10236 Rename locals to avoid shadowing.
38fc62d9 10237
2f2650da
PE
10238 * keyboard.c: Declare functions static if they are not used elsewhere.
10239 (echo_char, echo_dash, cmd_error, top_level_2):
10240 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
10241 (read_char, kbd_buffer_get_event, make_lispy_position):
10242 (make_lispy_event, make_lispy_movement, apply_modifiers):
10243 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10244 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10245 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 10246 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 10247 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 10248
a053e86c 10249 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
10250 (mark_kboards): Move decl here ...
10251 * alloc.c (mark_kboards): ... from here.
a053e86c 10252
4752793e
PE
10253 * lisp.h (force_auto_save_soon): New decl.
10254
74f10ca7 10255 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
10256 (DEFINE_DUMMY_FUNCTION): New macro.
10257 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10258 Use it.
c03cd23f
PE
10259 (main): Add casts to avoid warnings
10260 if GCC considers string literals to be constants.
74f10ca7 10261
022e70d4
PE
10262 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10263
59d6fe83
PE
10264 * dbusbind.c: Pointer signedness fixes.
10265 (xd_signature, xd_append_arg, xd_initialize):
10266 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10267 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10268 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10269 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10270
78320123
PE
10271 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10272 if GCC considers string literals to be constants.
49cebcca 10273 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10274
35ac2a97
SM
102752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10276
fb103ca9
SM
10277 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10278 (print_preprocess, print_object): New macro to fix last change.
10279
35ac2a97
SM
10280 * print.c (print_preprocess): Don't forget font objects.
10281
62973b41
JB
102822011-03-16 Juanma Barranquero <lekktu@gmail.com>
10283
10284 * emacs.c (USAGE3): Doc fixes.
10285
0e48bb22
AS
102862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10287
10288 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10289 structure.
10290
7684e57b
JB
102912011-03-14 Juanma Barranquero <lekktu@gmail.com>
10292
10293 * lisp.h (VWindow_system, Qfile_name_history):
10294 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10295 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10296 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10297
10298 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10299 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10300
10301 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10302 * w32console.c (detect_input_pending, read_input_pending)
10303 (encode_terminal_code):
10304 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10305 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10306 (w32_system_caret_y, Qfile_name_history):
10307 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10308 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10309 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10310 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10311 * w32proc.c (Qlocal, report_file_error):
10312 * w32term.c (Vwindow_system, updating_frame):
10313 * w32uniscribe.c (initialized, uniscribe_font_driver):
10314 Remove unneeded extern declarations.
10315
2aa46d6c
CY
103162011-03-14 Chong Yidong <cyd@stupidchicken.com>
10317
c96bbc66 10318 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10319
cffc6f3b
CY
103202011-03-13 Chong Yidong <cyd@stupidchicken.com>
10321
10322 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10323 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10324 These macros can no longer be used for assignment.
10325
44f230aa
SM
10326 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10327 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10328 (record_buffer_markers, fetch_buffer_markers): New functions for
10329 recording and fetching special buffer markers.
10330 (set_buffer_internal_1, set_buffer_temp): Use them.
10331
10332 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10333
10334 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10335
10336 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10337 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10338
10339 * xdisp.c (hscroll_window_tree):
10340 (reconsider_clip_changes): Use PT instead of BUF_PT.
10341
d251f04b
EZ
103422011-03-13 Eli Zaretskii <eliz@gnu.org>
10343
10344 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10345 $(EMACS_ROOT)/lib/intprops.h.
10346
f0c77cd1
PE
103472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10348
3eca4629
PE
10349 Fix more problems found by GCC 4.5.2's static checks.
10350
7c86ee98
PE
10351 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10352 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10353 (xg_free_frame_widgets): Make it clear that a local variable is
10354 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10355 (gdk_window_get_screen): Make it clear that this macro is needed
10356 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10357 (int_gtk_range_get_value): New function, which avoids a diagnostic
10358 from gcc -Wbad-function-cast.
10359 (xg_set_toolkit_scroll_bar_thumb): Use it.
10360 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10361 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10362 (get_utf8_string, xg_get_file_with_chooser):
10363 Rename locals to avoid shadowing.
10364 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10365
41729b81
PE
10366 * xgselect.c (xg_select): Remove unused var.
10367
f0c77cd1
PE
10368 * image.c (four_corners_best): Mark locals as initialized.
10369 (gif_load): Initialize transparent_p to zero (Bug#8238).
10370 Mark another local as initialized.
ec6cf4c6 10371 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10372
ce0ad53d 10373 * image.c (clear_image_cache): Now static.
d5d5a617 10374 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10375 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10376 (x_edge_detection): Remove unnecessary cast that
10377 gcc -Wbad-function-cast diagnoses.
2037898d 10378 (gif_load): Fix pointer signedness.
6ae141d6
PE
10379 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10380 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10381
33383987 103822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10383
d32df629
PE
10384 Improve quality of tests for time stamp overflow.
10385 For example, without this patch (encode-time 0 0 0 1 1
10386 1152921504606846976) returns the obviously-bogus value (-948597
10387 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10388 reports time overflow. See
10389 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10390 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10391 * editfns.c: Include limits.h and intprops.h.
10392 (TIME_T_MIN, TIME_T_MAX): New macros.
10393 (time_overflow): Move earlier, to before first use.
10394 (hi_time, lo_time): New functions, for an accurate test for
10395 out-of-range times.
10396 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10397 (Fget_internal_run_time): Don't assume time_t fits in int.
10398 (make_time): Use list2 instead of Fcons twice.
10399 (Fdecode_time): More accurate test for out-of-range times.
10400 (check_tm_member): New function.
10401 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10402 (lisp_time_argument): Don't rely on undefined left-shift and
10403 right-shift behavior when checking for time stamp overflow.
8be6f318 10404
fe31d94c
PE
10405 * editfns.c (time_overflow): New function, refactoring common code.
10406 (Fformat_time_string, Fdecode_time, Fencode_time):
10407 (Fcurrent_time_string): Use it.
10408
8be6f318
PE
10409 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10410 * dired.c (make_time): Move to ...
10411 * editfns.c (make_time): ... here.
10412 * systime.h: Note the move.
10413
09d9db2c 104142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10415
126bc0dc
YM
10416 * fringe.c (update_window_fringes): Remove unused variables.
10417
c47cbdfd
YM
10418 * unexmacosx.c (copy_data_segment): Also copy __got section.
10419 (Bug#8223)
10420
7ac80be9
EZ
104212011-03-12 Eli Zaretskii <eliz@gnu.org>
10422
c96bbc66 10423 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10424 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10425 Constify `char *' arguments and their references according to
10426 prototypes in tparam.h.
10427
ecb0f94d 10428 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10429
7ac80be9
EZ
10430 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10431 Adapt all references accordingly.
10432
10433 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10434
ef1fd07e
TT
104352011-03-11 Tom Tromey <tromey@redhat.com>
10436
10437 * buffer.c (syms_of_buffer): Remove obsolete comment.
10438
7ef4b50c
EZ
104392011-03-11 Eli Zaretskii <eliz@gnu.org>
10440
10441 * termhooks.h (encode_terminal_code): Declare prototype.
10442
10443 * msdos.c (encode_terminal_code): Don't declare prototype.
10444
10445 * term.c (encode_terminal_code): Now external again, used by
10446 w32console.c and msdos.c.
10447
44f230aa
SM
10448 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10449 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10450
4b1ec863 104512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10452
1714f52b 10453 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10454
4b1ec863
PE
10455 * fringe.c (update_window_fringes): Mark locals as initialized
10456 (Bug#8227).
10457 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10458
524c7aa6
PE
10459 * alloc.c (mark_fringe_data): Move decl from here ...
10460 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10461 to check its interface.
10462 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10463
a5c0af81 10464 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10465 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10466 (fontset_font): Mark local as initialized.
a9a06e0b 10467 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10468
b4716021
PE
10469 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10470
811e9bac 10471 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10472 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10473 (x_own_selection, Fx_disown_selection_internal): Rename locals
10474 to avoid shadowing.
10475 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10476
7e3ab302
PE
10477 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10478 so that the caller can use some name other than gcpro1.
10479 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10480 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10481 (Fx_backspace_delete_keys_p):
10482 Use them to avoid shadowing, and rename vars to avoid shadowing.
10483 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10484 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10485 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10486 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10487 Remove unused locals.
7e3ab302
PE
10488 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10489 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10490 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10491 macros.
f78faa98 10492
e2b13473
PE
10493 * xterm.h (x_mouse_leave): New decl.
10494
77f23912
PE
10495 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10496 Remove unused functions.
cdf4ba58
PE
10497 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10498 (x_calc_absolute_position): Now static.
7411c686 10499 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10500 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10501 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10502 unless they are used.
38d0b34a
PE
10503 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10504 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10505 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10506 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10507 (x_error_catcher, x_connection_closed, x_error_handler):
10508 (x_error_quitter, xembed_send_message, x_iconify_frame):
10509 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10510 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10511 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10512
44f230aa
SM
10513 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10514 Rename or move locals to avoid shadowing.
6b463e58 10515 (tty_defined_color, merge_face_heights): Now static.
5967d051 10516 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10517 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10518 does not deduce is never used uninitialized.
73719eba
PE
10519 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10520 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10521
426994c3 10522 * terminal.c (store_terminal_param): Now static.
5489860b 10523
032f1620 10524 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10525 (set_frame_menubar): Remove unused local.
d4323972 10526 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10527 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10528 since they might point to immutable storage.
281585b0
PE
10529 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10530 since it's unused otherwise.
032f1620 10531
367c19e5 10532 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10533 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10534 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10535 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10536 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10537 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10538 does not deduce are never used uninitialized.
70739cbe 10539
07b48fa9
PE
10540 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10541
8868a238 10542 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10543 * window.c (window_loop, size_window):
10544 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10545
7e5cf297 10546 * window.c (display_buffer): Now static.
d6550a9f
PE
10547 (size_window): Mark variables that gcc -Wuninitialized
10548 does not deduce are never used uninitialized.
a586633d
PE
10549 * window.h (check_all_windows): New decl, to forestall
10550 gcc -Wmissing-prototypes diagnostic.
5b555da1 10551 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10552
f6095868
PE
10553 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10554 shadowing.
10555 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10556 Include <limits.h>.
10557 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10558 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10559 (load_charset_map): Mark variables that gcc -Wuninitialized
10560 does not deduce are never used uninitialized.
53df7c11 10561 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10562
f38b440c
PE
10563 * coding.c (coding_set_source, coding_set_destination):
10564 Use "else { /* comment */ }" rather than "else /* comment */;"
10565 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10566 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10567 a block, when the outer 'i' will do.
10568 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10569 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10570 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10571 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10572 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10573 Rename locals to avoid shadowing.
10574 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10575 * coding.c (emacs_mule_char, encode_invocation_designation):
10576 Now static, since they're not used elsewhere.
413bb2db 10577 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10578 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10579 (decode_coding_emacs_mule): Mark variables that gcc
10580 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10581 (detect_coding_iso_2022): Initialize a local variable that might
10582 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10583 this initialization is needed. (Bug#8211)
5f58e762
PE
10584 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10585 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10586 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10587 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10588 Remove unused macros.
f38b440c 10589
232b38b9 10590 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10591 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10592 * character.c (string_count_byte8): Likewise.
232b38b9 10593
fb90da1b
PE
10594 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10595 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10596
fb93dbc2
PE
10597 * chartab.c (copy_sub_char_table): Now static, since it's not used
10598 elsewhere.
5c156ace
PE
10599 (sub_char_table_ref_and_range, char_table_ref_and_range):
10600 Rename locals to avoid shadowing.
bbcd0949 10601 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10602
7d3b3862 10603 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10604 (BIDI_BOB): Remove unused macro.
7d3b3862 10605
6be7d3da
PE
10606 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10607 deduce are never used uninitialized.
c2ed9c8b 10608 * term.c (encode_terminal_code): Likewise.
6be7d3da 10609
75f8807f 10610 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10611
50938595
PE
10612 * tparam.h: New file.
10613 * term.c, tparam.h: Include it.
10614 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10615 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10616 Move these decls to tparam.h, and make them agree with what
10617 is actually in tparam.c. The previous trick of using incompatible
10618 decls in different modules does not conform to the C standard.
10619 All callers of tparam changed to use tparam's actual API.
10620 * tparam.c (tparam1, tparam, tgoto):
10621 Use const pointers where appropriate.
10622
fbceeba2
PE
10623 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10624 * cm.h (struct cm): Likewise.
10625 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10626 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10627 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10628 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10629 (turn_on_face, init_tty): Likewise.
10630 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10631
7f3f1250
PE
10632 * term.c (term_mouse_position): Rename local to avoid shadowing.
10633
e6ca6543
PE
10634 * alloc.c (mark_ttys): Move decl from here ...
10635 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10636
c40f8d15
AS
106372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10638
10639 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10640
cfe0661d
JB
106412011-03-09 Juanma Barranquero <lekktu@gmail.com>
10642
10643 * search.c (compile_pattern_1): Remove argument regp, unused since
10644 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10645 (compile_pattern): Don't pass it.
10646
0afb4571
J
106472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10648
10649 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10650 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10651 for ! HAVE_GTK3.
10652 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10653
10654 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10655
10656 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10657 gdk_window_get_screen, gdk_window_get_geometry,
10658 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10659 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10660 (xg_get_pixbuf_from_pixmap): New function.
10661 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10662 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10663 Call xg_get_pixbuf_from_pixmap instead of
10664 gdk_pixbuf_get_from_drawable.
10665 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10666 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10667 (xg_check_special_colors): Use GtkStyleContext and its functions
10668 for HAVE_GTK3.
10669 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10670 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10671 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10672 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10673 Call gtk_widget_get_preferred_size.
0afb4571
J
10674 (xg_frame_resized): gdk_window_get_geometry only takes 5
10675 parameters.
44f230aa
SM
10676 (xg_win_to_widget, xg_event_is_for_menubar):
10677 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10678 (xg_set_widget_bg): New function.
10679 (delete_cb): New function.
895009e1 10680 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10681 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10682 (xg_set_background_color): Call xg_set_widget_bg.
10683 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10684 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10685 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10686 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10687 if ! HAVE_GTK3.
10688 (update_frame_tool_bar): Call gtk_widget_hide.
10689 (xg_initialize): Use GDK_KEY_g.
10690
10691 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10692 if ! HAVE_GTK3
10693 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10694
10695 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10696 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10697 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10698
1c2cc4ef
JB
106992011-03-08 Juanma Barranquero <lekktu@gmail.com>
10700
10701 * w32xfns.c (select_palette): Check success of RealizePalette against
10702 GDI_ERROR, not zero.
10703
33383987 10704See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10705
10706;; Local Variables:
10707;; coding: utf-8
aac0c6e3
MR
10708;; End:
10709
2f097256 10710 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10711
10712 This file is part of GNU Emacs.
10713
10714 GNU Emacs is free software: you can redistribute it and/or modify
10715 it under the terms of the GNU General Public License as published by
10716 the Free Software Foundation, either version 3 of the License, or
10717 (at your option) any later version.
10718
10719 GNU Emacs is distributed in the hope that it will be useful,
10720 but WITHOUT ANY WARRANTY; without even the implied warranty of
10721 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10722 GNU General Public License for more details.
10723
10724 You should have received a copy of the GNU General Public License
10725 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.