Bump version to 24.0.92.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
febe6bea
JB
12011-11-30 Juanma Barranquero <lekktu@gmail.com>
2
3 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4
801a4313
EZ
52011-11-30 Eli Zaretskii <eliz@gnu.org>
6
7 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
8 attributes are tested _before_ calling verify_row_hash, to protect
9 against GCC re-ordering of the tests. (Bug#10164)
10
2b56b87e
JD
112011-11-29 Jan Djärv <jan.h.d@swipnet.se>
12
13 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
14
15 * xterm.c (handle_one_xevent): Only set async_visible and friends
16 if net_wm_state_hidden_seen is non-zero (Bug#10002)
17 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
18 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
19
dbf31225
PE
202011-11-28 Paul Eggert <eggert@cs.ucla.edu>
21
22 Remove GCPRO-related macros that exist only to avoid shadowing locals.
23 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
24 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
25 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
26 All uses changed to use GCPRO1 etc.
27 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
28 Revert to old implementation (i.e., before 2011-03-11).
29
1305621b
YM
302011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
31
32 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
33 of scroll runs so as to avoid assigning disabled bogus rows and
34 unnecessary graphics copy operations.
35
8c9afb46
EZ
362011-11-27 Eli Zaretskii <eliz@gnu.org>
37
38 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
39 (snprintf) [_MSC_VER]: Redirect to _snprintf.
40 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
41 (malloc, free, realloc, calloc): Redirect to e_* only when
42 compiling Emacs.
43
44 * lisp.h (GCTYPEBITS): Move before first use.
45 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
46 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
47 this macro definition.
48
49 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
50 _MSC_VER.
51
54e9e3bf
JD
522011-11-27 Jan Djärv <jan.h.d@swipnet.se>
53
54 * gtkutil.c (xg_create_frame_widgets): Call
55 gtk_window_set_has_resize_grip (FALSE) if that function is
56 present with Gtk+ 2.0.
57
83aca1cb
PE
582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
59
60 * fileio.c (Finsert_file_contents): Undo previous change; see
61 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
62
5b76caa4
PE
632011-11-26 Paul Eggert <eggert@cs.ucla.edu>
64
65 Rename locals to avoid shadowing.
66 * fileio.c (Finsert_file_contents):
67 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
68 * process.c (wait_reading_process_output):
69 Rename inner 'proc' to 'p' to avoid shadowing.
70 Indent for consistency with usual Emacs style.
71
8c535114
EZ
722011-11-25 Eli Zaretskii <eliz@gnu.org>
73
74 * xdisp.c (redisplay_window): If cursor row is not fully visible
75 after recentering, and scroll-conservatively is set to a large
76 number, scroll window by a few more lines to make the cursor fully
77 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
78 (start_display): Don't move to the next line if the display should
79 start at a newline that is part of a display vector or an overlay
80 string. (Bug#10119)
8c535114 81
fa4fdb5c
JL
822011-11-24 Juri Linkov <juri@jurta.org>
83
84 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
85 after the `MagickPingImage' call. (Bug#10112)
86
90ec88df
CY
872011-11-23 Chong Yidong <cyd@gnu.org>
88
89 * window.c (Fcoordinates_in_window_p): Accept only live windows.
90
56e2e794
MR
912011-11-23 Martin Rudalics <rudalics@gmx.at>
92
93 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
94 making another buffer current. (Bug#10114)
95
b6e64c41
GM
962011-11-23 Glenn Morris <rgm@gnu.org>
97
98 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
99
6b21de18
CY
1002011-11-23 Chong Yidong <cyd@gnu.org>
101
102 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
103 using it (Bug#5984).
104
b12cd789
EZ
1052011-11-22 Eli Zaretskii <eliz@gnu.org>
106
107 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
108 and header-lines, as they don't have one computed for them.
109 (Bug#10098)
110
111 * .gdbinit (prow): Make displayed values more self-explaining.
112 Add row's hash code.
113
261b6fd4
LMI
1142011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
115
116 * process.c (wait_reading_process_output): Fix asynchrounous
117 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 118 (wait_reading_process_output): Add comment and URL.
261b6fd4 119
e7cfd277
JD
1202011-11-21 Jan Djärv <jan.h.d@swipnet.se>
121
122 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
123
a9b9b7f5
CY
1242011-11-21 Chong Yidong <cyd@gnu.org>
125
126 * window.c (Fnext_window, Fprevious_window): Doc fix.
127
b0d15b4f
SM
1282011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
129
130 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
131
fe7a3057
JB
1322011-11-20 Juanma Barranquero <lekktu@gmail.com>
133
134 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
135
d2999b1a
MR
1362011-11-20 Martin Rudalics <rudalics@gmx.at>
137
138 * window.c (Fset_window_combination_limit): Rename argument
139 STATUS to LIMIT.
140 (Vwindow_combination_limit): Remove "status" from doc-string.
141
d5ff9cd0
AS
1422011-11-20 Andreas Schwab <schwab@linux-m68k.org>
143
144 * m/ibms390.h: Remove.
145 * m/ibms390x.h: Don't include "ibms390.h".
146
a5bb9bd3
SM
1472011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
148
149 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
150 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
151
cd1181db
JB
1522011-11-20 Juanma Barranquero <lekktu@gmail.com>
153
154 * casetab.c (Fset_case_table):
155 * charset.c (Fcharset_after): Fix typos.
156
615a3b8d 1572011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 158
17e845af
PE
159 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
160 Otherwise, valgrind does not work on some platforms.
161 Problem reported by Andreas Schwab in
6a0bf43d
PE
162 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
163 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
164 is set, removing the need for VIRT_ADDRESS_VARIES.
165 (PURE_P): Use a more-efficient implementation that needs just one
166 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
167 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
168 to 4 (xorl, subq, cmpq, setbe).
169 * alloc.c (pure): Always extern now, since that's the
170 VIRT_ADDR_VARIES behavior.
171 (PURE_POINTER_P): Use a single comparison, not two, for
172 consistency with the new puresize.h.
173 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
174 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
175 Remove VIRT_ADDR_VARIES no longer needed.
176
f8fe6f96
EZ
1772011-11-19 Eli Zaretskii <eliz@gnu.org>
178
179 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
180 (erase_phys_cursor, update_window_cursor, show_mouse_face)
181 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
182 behave as if the cursor position were at the window margin.
183
184 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
185 and the cursor position is out of bounds, behave as if the cursor
186 position were at the window margin. (Bug#10075)
187
df05a53c
CY
1882011-11-18 Chong Yidong <cyd@gnu.org>
189
190 * window.c (Fwindow_combination_limit): Make first argument
191 non-optional, since it is meaningless for live windows like the
192 selected window.
193
2071918e
DA
1942011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
195
196 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
197
b50a28de
SM
1982011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
199
200 * intervals.c: Fix grafting over the whole buffer (bug#10071).
201 (graft_intervals_into_buffer): Simplify.
202
015137db
EZ
2032011-11-18 Eli Zaretskii <eliz@gnu.org>
204
205 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
206 hash values of the two rows.
207 (copy_row_except_pointers): Preserve the used[] arrays and the
208 hash values of the two rows. (Bug#10035)
68c95424 209 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
210
211 * xdisp.c (row_hash): New function, body extracted from
212 compute_line_metrics.
213 (compute_line_metrics): Call row_hash, instead of computing the
214 hash code inline.
215
216 * dispnew.c (verify_row_hash): Call row_hash for computing the
217 hash code of a row, instead of duplicating code from xdisp.c.
218
219 * dispextern.h (row_hash): Add prototype.
220
a2addb04
TH
2212011-11-18 Tassilo Horn <tassilo@member.fsf.org>
222
223 * frame.c (delete_frame): Don't delete the terminal when the last
224 X frame is closed if emacs is built with GTK toolkit.
225
df85d315
JB
2262011-11-17 Juanma Barranquero <lekktu@gmail.com>
227
228 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
229
a0c2d0ae
MR
2302011-11-17 Martin Rudalics <rudalics@gmx.at>
231
232 * window.c (Vwindow_splits): Rename to
233 Vwindow_combination_resize. Suggested by Juri Linkov.
234 (Fsplit_window_internal): Use Vwindow_combination_resize instead
235 of Vwindow_splits.
236
58179cce
JB
2372011-11-16 Juanma Barranquero <lekktu@gmail.com>
238
7877f373
JB
239 * nsfns.m (Fns_font_name):
240 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 241
b6f67890
MR
2422011-11-16 Martin Rudalics <rudalics@gmx.at>
243
244 * window.h (window): Rename slot "nest" to "combination_limit".
245 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
246 (Fset_window_nest): Rename to Fset_window_combination_limit.
247 (Vwindow_nest): Rename to Vwindow_combination_limit.
248 (recombine_windows, make_parent_window, make_window)
249 (Fsplit_window_internal, saved_window)
250 (Fset_window_configuration, save_window_save): Rename all
251 occurrences of window_nest to window_combination_limit.
252
c7015153
JB
2532011-11-15 Juanma Barranquero <lekktu@gmail.com>
254
255 * image.c (imagemagick_load_image): Fix typo.
256
322ad6ec
EZ
2572011-11-14 Eli Zaretskii <eliz@gnu.org>
258
259 * xdisp.c (display_line): Move the call to
260 highlight_trailing_whitespace before the call to
261 compute_line_metrics, since the latter needs to see the final
262 faces of all the glyphs to compute ROW's hash value. Fixes
263 assertion violations in row_equal_p. (Bug#10035)
264
f067b8ec
JB
2652011-11-14 Juanma Barranquero <lekktu@gmail.com>
266
267 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
268 just return (bug#10044).
269
1e5b2111
EZ
2702011-11-12 Eli Zaretskii <eliz@gnu.org>
271
7ef3cbd5
EZ
272 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
273 with user-defined heap size. Bump the default size of the temacs
274 heap to 27MB, to avoid memory warning when running temacs.
275 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
276
1e5b2111
EZ
277 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
278 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
279 (verify_row_hash) [XASSERTS]: New function.
280 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
281 that the hash value of glyph rows is correct.
1e5b2111 282
89d61221
MR
2832011-11-12 Martin Rudalics <rudalics@gmx.at>
284
285 * window.h (window): Remove splits slot.
286 * window.c (Fwindow_splits, Fset_window_splits): Remove.
287 (Fdelete_other_windows_internal, make_parent_window)
288 (make_window, Fsplit_window_internal, Fdelete_window_internal)
289 (Fset_window_configuration, save_window_save): Don't deal with
290 split status of windows.
291 (saved_window): Remove splits slot.
292 (Vwindow_splits): Rewrite doc-string.
293
97f18cc8
JD
2942011-11-11 Jan Djärv <jan.h.d@swipnet.se>
295
296 * xfns.c (unwind_create_frame):
297 * nsfns.m (unwind_create_frame):
298 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
299 Vframe_list (Bug#9999).
300
22a648b4
DA
3012011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
302
0b381c7e 303 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 304
659afede
KH
3052011-11-11 Kenichi Handa <handa@m17n.org>
306
307 * callproc.c (Fcall_process): Set the member dst_multibyte of
308 process_coding.
309
9ac0394b
KH
3102011-11-11 Johan Bockgård <bojohan@gnu.org>
311
312 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
313 avoid a crash (bug#9496).
314
2fbdc249
CY
3152011-11-09 Chong Yidong <cyd@gnu.org>
316
317 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
318 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
319
ac6b1f81
PE
3202011-11-08 Paul Eggert <eggert@cs.ucla.edu>
321
322 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
323
09db192c
PE
3242011-11-08 Paul Eggert <eggert@cs.ucla.edu>
325
326 Avoid some portability problems by eschewing 'extern inline' functions.
327 The trivial performance wins aren't worth the portability hassles; see
328 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
329 et seq.
330 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
331 (window_box_width, window_box_left, window_box_left_offset)
332 (window_box_right, window_box_right_offset): Undo previous change,
333 by removing the "extern"s.
334 * intervals.c (adjust_intervals_for_insertion)
335 (adjust_intervals_for_deletion): Undo previous change,
336 making these static again.
337 (offset_intervals, temp_set_point_both, temp_set_point)
338 (copy_intervals_to_string): No longer inline.
339 * xdisp.c (window_text_bottom_y, window_box_width)
340 (window_box_height, window_box_left_offset)
341 (window_box_right_offset, window_box_left, window_box_right)
342 (window_box): No longer inline.
343
105216ed
CY
3442011-11-08 Chong Yidong <cyd@gnu.org>
345
346 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
347 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
348 an error if not a live window.
349 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
350 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
351
ae9e237f
JB
3522011-11-07 Juanma Barranquero <lekktu@gmail.com>
353
354 * lisp.h (syms_of_abbrev): Remove declaration.
355 Reported by CHENG Gao <chenggao@royau.me>.
356
c7aa8333
EZ
3572011-11-07 Eli Zaretskii <eliz@gnu.org>
358
359 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
360 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
361 of temacs in GUI mode.
362
be7f5545
MR
3632011-11-07 Martin Rudalics <rudalics@gmx.at>
364
365 * window.h: Declare delete_all_child_windows instead of
366 delete_all_subwindows.
367 * window.c (Fwindow_nest, Fset_window_nest)
368 (Fset_window_new_total, Fset_window_new_normal)
369 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
370 (delete_all_subwindows): Rename to delete_all_child_windows.
371 (Fdelete_other_windows_internal, Fset_window_configuration):
372 Call delete_all_child_windows instead of delete_all_subwindows.
373 * frame.c (delete_frame): Call delete_all_child_windows instead
374 of delete_all_subwindows.
375
ca78dc43
PE
3762011-11-07 Paul Eggert <eggert@cs.ucla.edu>
377
378 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
379 This is also needed for porting to any host where GC_MARK_STACK is
380 not GC_MAKE_GCPROS_NOOPS.
381 (which_symbols): Use it.
382
a0241d01
KH
3832011-11-07 Kenichi Handa <handa@m17n.org>
384
385 * coding.c (coding_set_destination): Check coding->src_pos only
386 when coding->src_object is a buffer (bug#9910).
387
388 * process.c (send_process): Set the member src_multibyte of coding
389 to 0 (bug#9911) when sending a unibyte text.
390
391 * callproc.c (Fcall_process): Set the member src_multibyte of
392 process_coding to 0 (bug#9912).
393
a64bfdfa 3942011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
395
396 * xmenu.c (cleanup_widget_value_tree): New function.
397 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
398 calling free_menubar_widget_value_tree directly (Bug#9830).
399
cb41b32a
PE
4002011-11-06 Paul Eggert <eggert@cs.ucla.edu>
401
402 Fix some portability problems with 'inline'.
403 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
404 (window_box_width, window_box_left, window_box_left_offset)
405 (window_box_right, window_box_right_offset): Declare extern.
406 Otherwise, these inline functions do not conform to C99 and
407 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
408 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
409 * intervals.c (adjust_intervals_for_insertion)
410 (adjust_intervals_for_deletion): Now extern, because otherwise the
411 extern inline functions 'offset_intervals' couldn't refer to it.
412 (static_offset_intervals): Remove.
413 (offset_intervals): Rewrite using the old contents of
414 static_offset_intervals. The old version didn't conform to C99
415 because an extern inline function contained a reference to an
416 identifier with static linkage.
417
b7041366
AS
4182011-11-06 Andreas Schwab <schwab@linux-m68k.org>
419
420 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
421 GC.
422
88a37c4d
EZ
4232011-11-06 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (init_iterator, reseat_to_string): Don't set the
426 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
427 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
428 return Qleft_to_right.
429
49745b39
CY
4302011-11-06 Chong Yidong <cyd@gnu.org>
431
432 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
433 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
434 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
435 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
436 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
437 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
438 (Fwindow_vscroll): Doc fix.
439 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
440 argument, since it makes no sense to pass a live window and for
441 consistency with window-child.
442
1f05cd82
CS
4432011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
444
445 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
446 support MSVC.
447
22610910
JR
4482011-11-05 Jason Rumney <jasonr@gnu.org>
449
450 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
451 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
452 fonts (Bug#6029).
453 (add_font_entity_to_list): Fix logic errors in mixed boolean and
454 bitwise arithmetic preventing use of unicode-sip and non-truetype
455 opentype fonts.
456
a06776b2
EZ
4572011-11-05 Eli Zaretskii <eliz@gnu.org>
458
3ad924ba
EZ
459 * s/ms-w32.h (fstat, stat, utime): Move redirections to
460 "emacs"-only part.
461
a06776b2
EZ
462 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
463 initialization code to keep similarity to xfns.c after changes
464 from 2011-11-05.
465
c9e7db78
JD
4662011-11-05 Jan Djärv <jan.h.d@swipnet.se>
467
a97f8f3f
JD
468 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
469 (unwind_create_frame): New function (Bug#9943).
470 (Fx_create_frame): Restructure code to be more similar to the one in
471 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
472 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
473 Move terminal->reference_count++ just before making the frame official
474 (Bug#9943).
475
476 * nsterm.m (x_free_frame_resources): New function.
477 (x_destroy_window): Move code to x_free_frame_resources.
478
c9e7db78
JD
479 * xfns.c (unwind_create_frame): Fix comment.
480 (Fx_create_frame, x_create_tip_frame): Move
481 terminal->reference_count++ just before making the frame
482 official. Move initialization of image_cache_refcount and
483 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
484
a6fc3b5c
EZ
4852011-11-05 Eli Zaretskii <eliz@gnu.org>
486
487 Support MSVC build with newer versions of Visual Studio.
488 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
489 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
490 nt/gmake.defs.
491
492 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
493 which are not supported by MSVC.
494 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
495 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
496 bitfields.
497 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
498 types in bitfields.
499 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
500
501 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
502
58179cce 5032011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
504
505 Support MSVC build with newer versions of Visual Studio.
506 * w32.c: Don't include w32api.h for MSVC.
507 (init_environment) [_MSC_VER]: Call sys_access, not _access.
508
509 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
510 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
511 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
512 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
513 e_* cousins.
514 (alloca) [_MSC_VER]: Define to _alloca.
515
516 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
517
518 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
519
a58c13ed
EZ
5202011-11-04 Eli Zaretskii <eliz@gnu.org>
521
522 * xdisp.c (note_mouse_highlight): If either of
523 previous/next-single-property-change returns nil, treat that as
524 the beginning or the end of the buffer. (Bug#9955)
525
fe0b6370
JD
5262011-11-04 Jan Djärv <jan.h.d@swipnet.se>
527
a58c13ed 528 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
529 label is not null (Bug#9951).
530 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
531 may be NULL.
532
89bd5ee1
EZ
5332011-11-04 Eli Zaretskii <eliz@gnu.org>
534
535 * window.c (Fwindow_body_size): Mention in the doc string that the
536 return value is in frame's canonical units. (Bug#9949)
537
84c3edb9
EZ
5382011-11-03 Eli Zaretskii <eliz@gnu.org>
539
4e2fb5c7
EZ
540 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
541
84c3edb9 542 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 543 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 544 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 545
bc17a887
EZ
5462011-11-01 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
549 Don't stop backward scan on the continuation glyph, even though
550 its CHARPOS is positive.
26b46e51
EZ
551 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
552 cover_string to disp_string.
bc17a887 553
4ee88440
MR
5542011-11-01 Martin Rudalics <rudalics@gmx.at>
555
556 * window.c (temp_output_buffer_show): Don't use
557 Vtemp_buffer_show_specifiers.
558 (Vtemp_buffer_show_specifiers): Remove unused variable.
559
c2ff3c02
EZ
5602011-10-30 Eli Zaretskii <eliz@gnu.org>
561
562 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
563 past the beginning of the current glyph matrix.
564
58179cce 5652011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
566
567 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
568 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
569 HAVE_GTK3 (Bug#9869).
b77a6a7f 570
3b574623
JD
571 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
572 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
573
b77a6a7f
JD
574 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
575
576 * xterm.c: Declare x_handle_net_wm_state to return int.
577 (handle_one_xevent): Check if we are iconified but don't have
578 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
579 (get_current_wm_state): Return non-zero if not hidden,
580 check for _NET_WM_STATE_HIDDEN (Bug#9893).
581 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
582 (x_handle_net_wm_state): Return what get_current_wm_state returns.
583 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
584
196e41e4
PE
5852011-10-29 Paul Eggert <eggert@cs.ucla.edu>
586
587 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
588 so that this new function doesn't get optimized away by a
589 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
590
021f2e1a
AS
5912011-10-29 Andreas Schwab <schwab@linux-m68k.org>
592
593 * frame.h (MOUSE_HL_INFO): Remove excess parens.
594
8b058d44
EZ
5952011-10-29 Eli Zaretskii <eliz@gnu.org>
596
597 Fix the `xbytecode' command.
598 * .gdbinit (xprintbytestr): New command.
b50a28de 599 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
600 (xbytecode): Print the byte-code string as well.
601
4452fb80
EZ
6022011-10-29 Kim Storm <storm@cua.dk>
603
8b058d44
EZ
604 * alloc.c (which_symbols): New function.
605
21b72067
AS
6062011-10-29 Andreas Schwab <schwab@linux-m68k.org>
607
608 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
609 line. (Bug#9903)
610
83ed7b5c
GM
6112011-10-29 Glenn Morris <rgm@gnu.org>
612
613 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
614 Not clear what it was for, and it causes various bugs. (Bug#9839)
615
5a7a728b
EZ
6162011-10-28 Eli Zaretskii <eliz@gnu.org>
617
618 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
619 possible random value that matches one of those tested as
620 condition to clear the mouse face.
621
d3d0842f
CY
6222011-10-28 Chong Yidong <cyd@gnu.org>
623
624 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
625
31b39d13
DN
6262011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
627
628 * window.c (make_window): Initialize phys_cursor_on_p.
629
9aba6043
SM
6302011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
631
632 * lisp.h (struct Lisp_Symbol): Update comments.
633
c20992f4
JB
6342011-10-28 Juanma Barranquero <lekktu@gmail.com>
635
636 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
637
db4f02f2
EZ
6382011-10-28 Eli Zaretskii <eliz@gnu.org>
639
640 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
641 <oslsachem@gmail.com> for helping to debug this.
642
643 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
644 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
645 (g_b_init_get_glyph_outline_w): New static variables.
646 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
647 (GetGlyphOutlineW_Proc): New typedefs.
648 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
649 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
650 New functions.
651 (w32font_open_internal, compute_metrics):
652 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
653 instead of calling the "wide" APIs directly.
654
655 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
656
657 * w32.h (syms_of_w32font): Add prototype.
658
87e68db4
JB
6592011-10-27 Juanma Barranquero <lekktu@gmail.com>
660
661 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
662 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
663 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
664 (Fmove_to_window_line): Doc fix.
665
435c1d67
CY
6662011-10-27 Chong Yidong <cyd@gnu.org>
667
668 * process.c (make_process): Set gnutls_state to NULL.
669
670 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
671 non-NULL, regardless of GNUTLS_INITSTAGE.
672 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
673 an error. Set process slots as soon as we allocate them.
674
675 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
676
9c6c6f49
CY
6772011-10-27 Chong Yidong <cyd@gnu.org>
678
9aba6043
SM
679 * gnutls.c (emacs_gnutls_deinit): New function.
680 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
681 (Fgnutls_deinit, Fgnutls_boot): Use it.
682
683 * process.c (make_process): Initialize GnuTLS credentials to NULL.
684 (deactivate_process): Call emacs_gnutls_deinit.
685
657d08d3
JB
6862011-10-27 Juanma Barranquero <lekktu@gmail.com>
687
688 * image.c (x_create_x_image_and_pixmap):
689 * w32.c (sys_rename, w32_delayed_load):
690 * w32font.c (fill_in_logfont):
691 * w32reg.c (x_get_string_resource): Silence compiler warnings.
692
5430d399
JB
6932011-10-26 Juanma Barranquero <lekktu@gmail.com>
694
695 * w32fns.c (w32_default_color_map): New function,
696 extracted from Fw32_default_color_map.
a7ef684b 697 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 698
fe0055fa
PE
6992011-10-25 Paul Eggert <eggert@cs.ucla.edu>
700
701 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
702
e6346438
SM
7032011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
704
705 * keyboard.c (test_undefined): New function (bug#9751).
706 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
707
e112cc37
ET
7082011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
709
710 * sysdep.c (init_sys_modes): Fix the check for the controlling
711 terminal (Bug#6649).
712
7b5d6677
EZ
7132011-10-20 Eli Zaretskii <eliz@gnu.org>
714
715 * dispextern.h (struct bidi_it): New member next_en_type.
716
717 * bidi.c (bidi_line_init): Initialize the next_en_type member.
718 (bidi_resolve_explicit_1): When next_en_pos is valid for the
719 current character, check also for next_en_type being WEAK_EN.
720 (bidi_resolve_weak): Don't enter the expensive loop if the current
721 position is before next_en_pos. Record the bidi type of the first
722 non-ET, non-BN character we find, in addition to its position.
723 (bidi_level_of_next_char): Invalidate next_en_type when
724 next_en_pos is over-stepped.
725
7da0b018
PE
7262011-10-20 Paul Eggert <eggert@cs.ucla.edu>
727
728 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
729 * editfns.c: Rewrite current-time-zone so that it invokes
730 the equivalent of (format-time-string "%Z") to get the time zone name.
731 This fixes a bug when the time zone name contains characters that
732 need converting from the system time locale to Emacs internal format.
733 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
734 that patch fixed format-time-string to do the conversion, but
735 I forgot to fix current-time-zone.
736 (format_time_string): New function, containing most of
737 what Fformat_time_string used to contain.
738 (Fformat_time_string): Rewrite in terms of format_time_string.
739 This doesn't change this function's behavior.
740 (current-time-zone): Rewrite to use format_time_string.
741 This fixes the bug reported by Michael Schierl in
742 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
743 Jason Rumney's 2007-06-07 change worked around this bug, but
744 didn't fix it.
745 * systime.h (tzname, timezone): Remove no-longer-used declarations.
746
8547b010
EZ
7472011-10-19 Eli Zaretskii <eliz@gnu.org>
748
749 * xdisp.c (start_display): If the character at POS is displayed
750 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
751 (try_window_reusing_current_matrix): If a line ends in a display
752 vector or the next line starts in a display vector, continue
753 redrawing the window even though the character position of
754 start_row was reached.
8547b010
EZ
755 (Bug#9771, part 2)
756
4e948d15
CY
7572011-10-18 Chong Yidong <cyd@gnu.org>
758
759 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
760 with nobreak-char-display too.
761
4787455f
EZ
7622011-10-18 Eli Zaretskii <eliz@gnu.org>
763
764 Fix part 3 of bug#9771.
765 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
766 (bidi_resolve_neutral): Don't enter the expensive loop looking for
767 non-neutral characters if the current character is a paragraph
768 separator (a.k.a. Newline). This avoids running the same
769 expensive loop twice, once when we consume the preceding newline
770 and the other time when the line actually needs to be displayed.
771 Avoid the loop when we see neutrals on the base embedding level
772 following a character whose directionality is the same as the
773 paragraph's. This avoids running the expensive loop when a line
774 ends in a long sequence of neutrals, like control characters.
775 Add assertion against STRONG_AL type. Slightly rearrange code
776 that determines the type of a neutral given the first non-neutral
777 that follows it.
778 (bidi_level_of_next_char): Set next_en_pos to zero when
779 invalidating its info.
780
2c91f553
EZ
7812011-10-17 Eli Zaretskii <eliz@gnu.org>
782
783 * xdisp.c (push_display_prop): Determine whether to record string
784 or buffer position by IT->string, not by IT->method. Allow
785 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
786 (move_it_vertically_backward): Don't look for character position
787 immediately after the newline when in a continuation line.
788 (Bug#9771, part 1)
2c91f553 789
c7b08b0d
MR
7902011-10-15 Martin Rudalics <rudalics@gmx.at>
791
792 * window.c (coordinates_in_window): Rewrite and delabelize
793 vertical border check. (Bug#5357) (Bug#9618)
794
6b02f655
SM
7952011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
798 errors in XSetWindowBorder (bug#9310).
799
81d40c92
DA
8002011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
801
802 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
803 avoid crash when xmalloc overrun checking is enabled.
804
d4172c3b
EZ
8052011-10-13 Eli Zaretskii <eliz@gnu.org>
806
807 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
808 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
809 cursor motion with <left> and <right> arrow keys.
810
811 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
812 some callers set that themselves.
813
b00eea75
EZ
8142011-10-12 Eli Zaretskii <eliz@gnu.org>
815
816 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
817 display string and the previous row comes from the same string and
818 is empty. (Bug#9739) (Bug#9738)
819
8fe012c4
SM
8202011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
821
822 * doc.c (get_doc_string): Encode file name (bug#9735).
823
0074aef2
EZ
8242011-10-12 Eli Zaretskii <eliz@gnu.org>
825
79beb178
EZ
826 * bidi.c (bidi_level_of_next_char):
827 * xdisp.c (get_visually_first_element): Remove old incorrect
828 comments regarding the Unicode Line Separator character.
829
0074aef2
EZ
830 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
831
6e4b3fbe
DA
8322011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
833
834 * alloc.c (Fgc_status): Do not access beyond zombies array
835 boundary if nzombies > MAX_ZOMBIES.
836 * alloc.c (dump_zombies): Add missing format specifier.
837
0324f3af
PE
8382011-10-12 Paul Eggert <eggert@cs.ucla.edu>
839
b5525cac
PE
840 * xdisp.c (set_cursor_from_row): Simplify conditionals,
841 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
842
0324f3af
PE
843 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
844 Some packages use them to denote characters with modifiers.
845
e9b5f888
AS
8462011-10-11 Andreas Schwab <schwab@linux-m68k.org>
847
848 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
849 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
850 matching a pp-number. Rename parameter var to var1.
851
127827c0
SM
8522011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
853
854 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
855
c8fd3bd0
GM
8562011-10-08 Glenn Morris <rgm@gnu.org>
857
858 * callint.c (Fcall_interactively): Give a more explicit error for the
859 'c' case with a non-character input. (Bug#8479)
860
352ec8ff
EZ
8612011-10-08 Eli Zaretskii <eliz@gnu.org>
862
03669ccb
EZ
863 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
864 lines.
7061c986
EZ
865 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
866 lines that are hscrolled on the left.
03669ccb 867
352ec8ff
EZ
868 * dispnew.c (buffer_posn_from_coords): Account for a possible
869 presence of header-line. (Bug#4426)
870
a66cfb1c
SM
8712011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
872
6b02f655
SM
873 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
874 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 875
7c5ee88e
PE
8762011-10-07 Paul Eggert <eggert@cs.ucla.edu>
877
878 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
879 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
880 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
881 this makes Emacs dump core during garbage collection on rare
882 occasions. sizeof is obviously inferior to offsetof here, so
883 stick with offsetof.
884 (GC_POINTER_ALIGNMENT): New macro.
885 (mark_memory): Omit 3rd (offset) arg; caller changed.
886 Don't assume EMACS_INT alignment is the same as pointer alignment.
887
df1bbe5b
SM
8882011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
889
890 * keyboard.c (read_key_sequence_remapped): New var.
891 (read_key_sequence): Compute remapping in the right buffer.
892 (command_loop_1): Use read_key_sequence's remapping directly.
893
51553db6
SM
8942011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
895
32c1fffd
SM
896 * dired.c (file_name_completion): Don't expand file name.
897 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
898 before checking file name handler.
899
51553db6
SM
900 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
901 they've been requested explicitly (bug#9591).
902
b6bd1599 9032011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
904
905 * keymap.c (Fsingle_key_description): Use make_specified_string
906 instead of build_string to build string from push_key_description.
907 (Bug#5193)
908
f701dc2a
PE
9092011-09-30 Paul Eggert <eggert@cs.ucla.edu>
910
4222c55d
PE
911 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
912 This fixes a Y2038 bug on 64-bit hosts.
913 * buffer.c (reset_buffer):
914 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
915 (Fclear_buffer_auto_save_failure):
916 Use 0, not -1, to represent an unset failure time, since time_t
917 might not be signed.
918
f701dc2a
PE
919 Remove dependency on glibc malloc internals.
920 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
921 Move back here from lisp.h, but with their new implementations.
922 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
923 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
924 * charset.c (charset_table_init): New static var.
925 (syms_of_charset): Use it instead of xmalloc. This removes a
926 dependency on glibc malloc internals. See Eli Zaretskii's comment in
927 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
928 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
929 Move back to alloc.c.
930 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
931 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
932
9ceebf39
JD
9332011-09-30 Jan Djärv <jan.h.d@swipnet.se>
934
935 * nsterm.m (windowDidResize): Call x_set_window_size only when
936 ns_in_resize is true. Otherwise set pixelwidth/height and
937 call change_frame_size (Bug#9628).
938
cb993c58
PE
9392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
940
3930c88b
PE
941 Port --enable-checking=all to Fedora 14 x86-64.
942 * charset.c (syms_of_charset): Also account for glibc malloc's
943 internal overhead when calculating the initial malloc maximum.
944
cb993c58
PE
945 Port --enable-checking=all to Fedora 14 x86.
946 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
947 Move to lisp.h.
948 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
949 (overrun_check_realloc, overrun_check_free):
950 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
951 That way, xmalloc returns a properly-aligned pointer even if
952 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
953 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
954 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
955 into account when calculating the initial malloc maximum.
956 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
957 Move here from alloc.c, so that charset.c can use it too.
958 Properly align; the old code wasn't right for common 32-bit hosts
959 when configured with --enable-checking=all.
960 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
961 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
962
31bed486
EZ
9632011-09-29 Eli Zaretskii <eliz@gnu.org>
964
04c70788 965 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
966 use EDOM.
967
fbcaa2f3
EZ
9682011-09-28 Eli Zaretskii <eliz@gnu.org>
969
970 * xdisp.c (compute_display_string_end): If there's no display
971 string at CHARPOS, return -1.
972
973 * bidi.c (bidi_fetch_char): When compute_display_string_end
974 returns a negative value, treat the character as a normal
975 character not covered by a display string. (Bug#9624)
976
a239d4e9
JB
9772011-09-28 Juanma Barranquero <lekktu@gmail.com>
978
979 * lread.c (Fread_from_string): Fix typo in docstring.
980
88652fd5
EZ
9812011-09-27 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (handle_invisible_prop): If invisible text ends on a
984 newline, reseat the iterator instead of bidi-iterating there one
985 character at a time. (Bug#9610)
32c1fffd
SM
986 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
987 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 988
ed497dd4
AS
9892011-09-27 Andreas Schwab <schwab@linux-m68k.org>
990
991 * lread.c (readevalloop): Use correct code for NBSP.
992 (read1): Likewise. (Bug#9608)
993
b2bf61aa
MA
9942011-09-25 Michael Albinus <michael.albinus@gmx.de>
995
996 * dbusbind.c (Fdbus_register_signal): When service is not
997 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
998
32bbb17c
GM
9992011-09-25 Glenn Morris <rgm@gnu.org>
1000
1001 * buffer.c (truncate-lines): Doc fix.
1002
94e0933e
CY
10032011-09-24 Chong Yidong <cyd@stupidchicken.com>
1004
1005 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1006 (Fset_window_next_buffers): Doc fix.
1007
cddde921
GM
10082011-09-24 Glenn Morris <rgm@gnu.org>
1009
1010 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1011
1260aef1
PE
10122011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1013
25b4bfa0
PE
1014 Fix minor problems found by static checking.
1015 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1016 * indent.c (Fvertical_motion): Fix == vs = typo.
1017
e3cbd34b
EZ
10182011-09-24 Eli Zaretskii <eliz@gnu.org>
1019
a66cfb1c
SM
1020 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1021 Default value is now t. Doc fix.
6bf7006f 1022
e3cbd34b 1023 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1024 logic when moving up, not only when moving down. Fix the
e3cbd34b 1025 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1026 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1027
1028 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1029 CHARPOS is covered by a display string which includes newlines.
1030 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1031 is covered by a display string with embedded newlines.
1032
a3de0cbd
MA
10332011-09-24 Michael Albinus <michael.albinus@gmx.de>
1034
1035 * dbusbind.c (Fdbus_register_signal): Add match rule to
1036 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1037 (Fdbus_register_method, Vdbus_registered_objects_table):
1038 Fix docstring.
a3de0cbd 1039
b260039d
JM
10402011-09-24 Jim Meyering <meyering@redhat.com>
1041
32c1fffd 1042 do not ignore write error for any output size
b260039d
JM
1043 The previous change was incomplete.
1044 While it makes emacs --batch detect the vast majority of stdout
1045 write failures, errors were still ignored whenever the output size is
1046 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1047 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1048 && echo FAIL: ignored write error
1049 FAIL: ignored write error
1050 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1051 && echo FAIL: ignored write error
1052 FAIL: ignored write error
1053 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1054
8eca8a7c
AS
10552011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1056
1057 * emacs.c (Fkill_emacs): In noninteractive mode exit
1058 non-successfully if a write error occurred on stdout. (Bug#9574)
1059
3341db62
EZ
10602011-09-21 Eli Zaretskii <eliz@gnu.org>
1061
1062 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1063 the xassert test.
1064
1065 * dispextern.h (struct it): Update the comment documenting what
1066 can it->OBJECT be.
1067
8c203dbf
EZ
10682011-09-20 Eli Zaretskii <eliz@gnu.org>
1069
1070 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1071 a display string, extend search for cursor position to end of row.
1072 (find_row_edges): If the row ends in a newline from a display
1073 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1074 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1075 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1076 non-empty line. Fixes confusing cursor motion with arrow keys at
1077 the beginning of a line that starts with whitespace.
8c203dbf 1078
a4824228
LMI
10792011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1080
1081 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1082 (bug#9493).
1083
33ed493b
CY
10842011-09-18 Chong Yidong <cyd@stupidchicken.com>
1085
1086 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1087 boolean (Bug#9154).
1088
56cd55c8
EZ
10892011-09-18 Eli Zaretskii <eliz@gnu.org>
1090
1091 * xdisp.c (display_line): Record maximum and minimum buffer
1092 positions even if no glyphs were produced (e.g., by a zero-width
1093 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1094 buffer positions that will be removed from the glyph row because
1095 they don't fit.
c02dcedf
EZ
1096 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1097 column is beyond frame width: don't subtract 1 "pixel" when
1098 computing width of the stretch.
3e62b7e0
EZ
1099 (reseat_at_next_visible_line_start): Undo the change made on
1100 2011-09-17 that saved paragraph information and restored it after
1101 the call to `reseat'. (Bug#9545)
56cd55c8 1102
5ed99d36 11032011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1104
1105 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1106 and turn window cursor on if cleared (Bug#9415).
1107
5ed99d36 11082011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1109
1110 * search.c (boyer_moore): Take unibyte characters from pattern
1111 literally. (Bug#9458)
1112
9bade7b2
EZ
11132011-09-18 Eli Zaretskii <eliz@gnu.org>
1114
1115 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1116
e5e9d610
PE
11172011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1118
87e4427a
PE
1119 Fix minor problem found by static checking.
1120 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1121 initialized, to pacify gcc -Wuninitialized.
1122
e5e9d610
PE
1123 * fileio.c: Report proper errno when syscall falls.
1124 (Finsert_file_contents): Save and restore errno,
1125 so that report_file_error outputs the correct diagnostic.
1126 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1127
a1674f0b
EZ
11282011-09-18 Eli Zaretskii <eliz@gnu.org>
1129
1130 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1131
fbfb6dd4
EZ
11322011-09-17 Eli Zaretskii <eliz@gnu.org>
1133
1134 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1135 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1136
bb187662
EZ
11372011-09-17 Eli Zaretskii <eliz@gnu.org>
1138
1137e8b8 1139 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1140 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1141
1142 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1143 (bidi_find_paragraph_start): Search back for paragraph beginning
1144 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1145 (bidi_move_to_visually_next): Only trigger paragraph-related
1146 computations when the last character is a newline or at EOB, not
1147 just any NEUTRAL_B. (Bug#9470)
1148
bb187662
EZ
1149 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1150 truncated lines if point is covered by a display string. (Bug#9524)
1151
2e621251
PE
11522011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1155 (cons_to_x_long): New function.
1156 (lisp_data_to_selection_data): Use it. Correct the test for
1157 short-versus-long data; it was negated. Break out of vector
1158 loop, for efficiency, when a long datum is discovered.
1159
91a15bc6
SM
11602011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1161
1162 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1163
b41c3a35
EZ
11642011-09-16 Eli Zaretskii <eliz@gnu.org>
1165
1166 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1167 GCC PR/17406) by declaring this function with external scope.
1168
7812ba2d
PE
11692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1172 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1173
cf7edc2a
AS
11742011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1175
1176 * editfns.c (Fformat): Correctly handle text properties on "%%".
1177
bd01620e
EZ
11782011-09-15 Eli Zaretskii <eliz@gnu.org>
1179
1180 * xterm.c (x_draw_composite_glyph_string_foreground):
1181 * w32term.c (x_draw_composite_glyph_string_foreground):
1182 * term.c (encode_terminal_code):
1183 * composite.c (composition_update_it, get_composition_id):
1184 * xdisp.c (get_next_display_element)
1185 (fill_composite_glyph_string): Add comments about special meaning
1186 of TAB characters in a composition.
1187
a02719a3
PE
11882011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1191 This occurs when processing a multibyte format.
1192 Problem reported by Wolfgang Jenker.
a02719a3 1193
72589a3c
JB
11942011-09-15 Johan Bockgård <bojohan@gnu.org>
1195
1196 * xdisp.c (try_cursor_movement): Only check for exact match if
1197 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1198
1c14176c
PE
11992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 Remove unused external symbols.
1202 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1203 * xdisp.c (calc_pixel_width_or_height): Now static.
1204 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1205 * indent.c (check_display_width):
1206 * w32term.c: Fix comment to match code.
1207 * xterm.c, xterm.h (x_catching_errors): Remove.
1208
d2eea5b5
PE
12092011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1210
1211 * xselect.c: Use signed conversions more consistently (Bug#9498).
1212 (selection_data_to_lisp_data): Assume incoming selection data are
1213 signed integers, not unsigned. This is to be consistent with
1214 outgoing selection data, which was modified to use signed integers
1215 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1216 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1217 expects long, not unsigned long.
1218
46888499
EZ
12192011-09-14 Eli Zaretskii <eliz@gnu.org>
1220
1221 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1222 computation of loop end. Reported by Johan Bockgård
1223 <bojohan@gnu.org>.
1224
ef8ef9fb
CY
12252011-09-13 Chong Yidong <cyd@stupidchicken.com>
1226
1227 * frame.c (Fother_visible_frames_p): Function deleted.
1228
fa819fed
EZ
12292011-09-12 Eli Zaretskii <eliz@gnu.org>
1230
1231 * indent.c (compute_motion): Process display vector front to back
1232 rather than the other way around. (Bug#2496)
1233
2ba8e008
SM
12342011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1235
1236 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1237
20f53c69
CY
12382011-09-11 Chong Yidong <cyd@stupidchicken.com>
1239
1240 * minibuf.c (Fread_from_minibuffer): Doc fix.
1241
d562d7a4
EZ
12422011-09-11 Eli Zaretskii <eliz@gnu.org>
1243
1244 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1245 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1246
1c4d7f3d
LMI
12472011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1248
1249 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1250 value for non-existent files.
1251
b885bf36
EZ
12522011-09-11 Eli Zaretskii <eliz@gnu.org>
1253
1254 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1255 set its "size" to -1. This will set the modtime_size field of
1256 the corresponding buffer to -1, which is what
1257 verify-visited-file-modtime expects for files that do not exist.
1258 (Bug#9139)
1259
6612f0bf
PE
12602011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1263 here ...
1264 * lisp.h: ... from here. push_key_description is no longer
1265 defined in keyboard.c, so its declaration should not be in
1266 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1267 logically belongs with push_key_description.
1268
dfb3f755
PE
12692011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1270
1271 * buffer.h: Include <sys/types.h> instead of <time.h>.
1272 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1273 Problem reported by Herbert J. Skuhra.
1274
3134906c
LMI
12752011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1276
1277 * xml.c (parse_region): Make the parsing work for
1278 non-comment-starting XML files again (bug#9144).
1279
8d903f4e
AS
12802011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1281
1282 * image.c (gif_load): Fix calculation of bottom and right corner.
1283 (Bug#9468)
1284
80ad64f4
EZ
12852011-09-10 Eli Zaretskii <eliz@gnu.org>
1286
1287 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1288 redisplay in small windows.
1289
208a048d
EZ
12902011-09-09 Eli Zaretskii <eliz@gnu.org>
1291
1292 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1293
9b1c252e
MR
12942011-09-08 Martin Rudalics <rudalics@gmx.at>
1295
1296 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1297 Operate on live windows only.
1298
2949f33b
JB
12992011-09-08 Juanma Barranquero <lekktu@gmail.com>
1300
1301 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1302
e08dcafd
EZ
13032011-09-07 Eli Zaretskii <eliz@gnu.org>
1304
1305 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1306 only under bidi iteration.
1307
115b96bd
JD
13082011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1309
1310 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1311
c8199d0f
PE
13122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1315 Without this fix, the command to link temacs failed due to an
1316 undefined symbol __builtin_isnan. This is because
1317 /usr/include/iso/math_c99.h #defines isnan(x) to
1318 __builtin_isnan(x), but the bundled gcc, which identifies itself
1319 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1320 a __builtin_isnan.
1321 * floatfns.c (isnan): #undef, and then #define to a clone of
1322 what's in data.c.
1323 (Fisnan): Always define, since it's always available now.
1324 (syms_of_floatfns): Always define isnan at the Lisp level.
1325
e39b275c 13262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1327
1328 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1329
b2db44d9 13302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1331
f4af5137 1332 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1333 The previous code assumed that file offsets (off_t values) fit in
1334 EMACS_INT variables, which is not true on typical 32-bit hosts.
1335 The code messed up by falsely reporting buffer overflow in cases
1336 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1337 when "big" contains more than 2**29 bytes, even though this
1338 inserts just one byte and does not overflow the buffer.
1339 (Finsert_file_contents): Store file offsets as off_t
1340 values, not as EMACS_INT values. Check for overflow when
1341 converting between EMACS_INT and off_t. When checking for
1342 buffer overflow or for overlap, take the offsets into account.
1343 Don't use EMACS_INT for small values where int suffices.
1344 When checking for overlap, fix a typo: ZV was used where
1345 ZV_BYTE was intended.
1346 (Fwrite_region): Don't assume off_t fits into 'long'.
1347 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1348
ecfc0a49
MA
13492011-09-05 Michael Albinus <michael.albinus@gmx.de>
1350
1351 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1352
6511acf2 13532011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1354
0999621a 1355 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1356
1357 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1358 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1359 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1360 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1361 (modify_event_symbol): Do not assume that the length of
1362 name_alist_or_stem is safe to alloca and fits in int.
1363 (Fexecute_extended_command): Likewise for function name and binding.
1364 (Frecursion_depth): Wrap around reliably on integer overflow.
1365 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1366 since some callers pass EMACS_INT values.
1367 (Fsingle_key_description): Don't crash if symbol name contains more
1368 than MAX_ALLOCA bytes.
1369 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1370 (get_minibuffer): Arg is now EMACS_INT, not int.
1371 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1372 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1373 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1374
2be7d702
PE
1375 * dbusbind.c (signature_cat): New function.
1376 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1377 Do not overrun buffer; instead, report string overflow.
1378
9d1df220
PE
1379 * dispnew.c (add_window_display_history): Don't overrun buffer.
1380 Truncate instead; this is OK since it's just a log.
1381
33ef5c64
PE
1382 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1383 even if the time zone offset is outlandishly large.
1384 Don't mishandle offset == INT_MIN.
1385
66c6fdd5
PE
1386 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1387 when creating daemon; the previous buffer-overflow check was incorrect.
1388
d749b01b
PE
1389 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1390 which has the guts of the old verror function.
1391
b5cd1905
PE
1392 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1393 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1394
6e1a67fb
PE
1395 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1396 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1397 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1398 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1399 length of string rather than counting it via multiple sprintfs;
1400 that's simpler and more reliable.
c21721cc
PE
1401 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1402 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1403 sprintf, in case result does not fit in int.
1404
c57b67fc
PE
1405 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1406 (fontset_from_font): Print it.
1407
8a401434
PE
1408 * frame.c (tty_frame_count): Now printmax_t, not int.
1409 (make_terminal_frame, set_term_frame_name): Print it.
1410 (x_report_frame_params): In X, window IDs are unsigned long,
1411 not signed long, so print them as unsigned.
1412 (validate_x_resource_name): Check for implausibly long names,
1413 and don't assume name length fits in 'int'.
1414 (x_get_resource_string): Don't blindly alloca invocation name;
1415 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1416 not fit in int.
1417
6e1a67fb
PE
1418 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1419 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1420 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1421
0df02bf3
PE
1422 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1423 Use esprintf, not sprintf, in case result does not fit in int.
1424
48e30793
PE
1425 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1426 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1427 it as a large positive number.
1428 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1429 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1430
a66ff6d8
PE
1431 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1432 in case result does not fit in int.
1433
aca216ff
PE
1434 * print.c (float_to_string): Detect width overflow more reliably.
1435 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1436 buffer overrun. Don't assume list length fits in 'int'. Treat
1437 print length of 0 as 0, not as infinity; to be consistent with other
1438 uses of print length in this function. Don't overflow print length
1439 index. Don't assume hash table size fits in 'long', or that
1440 vectorlike size fits in 'unsigned long'.
1441
31c286f7
PE
1442 * process.c (make_process): Use printmax_t, not int, to format
1443 process-name gensyms.
1444
55e5faa1
PE
1445 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1446
80f2e268
PE
1447 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1448 to avoid potential buffer overrun.
1449
670741ab
PE
1450 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1451 if X resource line is longer than 512 bytes.
1452
b7163a50
PE
1453 * xfns.c (x_window): Make sprintf buffer a bit bigger
1454 to avoid potential buffer overrun.
1455
ae58ff1f
PE
1456 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1457
c43c8a6a
PE
1458 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1459
3f8236f4
PE
14602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1461
53e9fe90 1462 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1463 Without these, Emacs silently mishandles large integers sometimes.
1464 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1465 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1466
6511acf2
PE
1467 * xdisp.c (try_window_id): Check Emacs fixnum range before
1468 converting to 'int'.
806add1d 1469
6511acf2 1470 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1471 Check that an Emacs fixnum is in range before assigning it to 'int'.
1472 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1473 values converted from Emacs fixnums.
1474 (Frecenter): Don't wrap around a line count if it is out of 'int'
1475 range; instead, treat it as an extreme value.
1476 (Fset_window_configuration, compare_window_configurations):
1477 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1478
6511acf2
PE
1479 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1480 that can exceed INT_MAX. Check that EMACS_INT value is in range
1481 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1482 (match_limit): Don't assume that a fixnum can fit in 'int'.
1483
6511acf2 1484 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1485 exceed INT_MAX.
1486
6511acf2 1487 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1488 (Fvertical_motion): Don't wrap around LINES values that don't fit
1489 in 'int'. Instead, treat them as extreme values. This is good
1490 enough for windows, which can't have more than INT_MAX lines anyway.
1491
fcb901a7
LMI
14922011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1493
0f2f6b6d
LMI
1494 * Require libxml/parser.h to avoid compilation warning.
1495
fcb901a7
LMI
1496 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1497
1498 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1499 since this reportedly can destroy thread storage.
1500
6e20a0d4
CY
15012011-08-30 Chong Yidong <cyd@stupidchicken.com>
1502
1503 * syntax.c (find_defun_start): Update all cache variables if
1504 exiting early (Bug#9401).
1505
148ae00e
EZ
15062011-08-30 Eli Zaretskii <eliz@gnu.org>
1507
f6cfbd8f
EZ
1508 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1509
148ae00e
EZ
1510 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1511 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1512 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1513
1514 * term.c (tty_append_glyph): New function.
1515 (produce_stretch_glyph): Static function and its prototype deleted.
1516
a66cfb1c
SM
1517 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1518 Add prototypes.
148ae00e 1519
c4a07a4c
PE
15202011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1523 when checking :margin (Bug#9390).
1524 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1525 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1526 so that the name doesn't mislead. All uses changed.
1527
6bc8cd65
JB
15282011-08-28 Johan Bockgård <bojohan@gnu.org>
1529
1530 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1531 set_tty_hooks.
1532
dca4927e
EZ
15332011-08-27 Eli Zaretskii <eliz@gnu.org>
1534
1535 * xdisp.c (move_it_to): Don't bail out early when reaching
1536 position beyond to_charpos, if we are scanning backwards.
1537 (move_it_vertically_backward): When DY == 0, make sure we get to
1538 the first character in the line after the newline.
1539
f2cad773
PE
15402011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1543 (ccl_driver): Do not generate an out-of-range pointer.
1544 (Fccl_execute_on_string): Remove unnecessary check for
1545 integer overflow, noted by Stefan Monnier in
1546 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1547 Remove a FIXME that didn't need fixing.
1548 Simplify the newly-introduced buffer reallocation code.
1549
0cae2cdb
JB
15502011-08-27 Juanma Barranquero <lekktu@gmail.com>
1551
1552 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1553
5fc295a4 15542011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1555
70c60eb2 1556 Integer and memory overflow issues (Bug#9196).
726e0ab1 1557
d31850da
PE
1558 * doc.c (get_doc_string): Rework so that
1559 get_doc_string_buffer_size is the actual buffer size, rather than
1560 being 1 less than the actual buffer size; this makes xpalloc more
1561 convenient.
1562
a69fbedb
PE
1563 * image.c (x_allocate_bitmap_record, cache_image):
1564 * xselect.c (Fx_register_dnd_atom):
1565 Simplify previous changes by using xpalloc.
1566
fe5c5d37
PE
1567 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1568 since either will do and ptrdiff_t is convenient with xpalloc.
1569
0065d054
PE
1570 * charset.c (charset_table_size)
1571 (struct charset_sort_data.priority): Now ptrdiff_t.
1572 (charset_compare): Don't overflow if priorities differ greatly.
1573 (Fsort_charsets): Don't assume list length fits in int.
1574 Check for size-calculation overflow when allocating sort data.
1575 (syms_of_charset): Allocate an initial charset table that is
1576 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1577
1578 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1579
1580 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1581 The actual value is always <= INT_MAX, and leaving it unsigned made
1582 overflow checking harder.
1583
1584 * dispextern.h (struct glyph_matrix.rows_allocated)
1585 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1586 with xpalloc. The values are still always <= INT_MAX.
1587
1588 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1589
1590 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1591 (SAFE_NALLOCA): New macro.
1592
1593 * region-cache.c (struct boundary.pos, find_cache_boundary)
1594 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1595 (set_cache_region, invalidate_region_cache)
1596 (revalidate_region_cache, know_region_cache, region_cache_forward)
1597 (region_cache_backward, pp_cache):
1598 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1599 so that ptrdiff_t * can be passed to xpalloc.
1600 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1601 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1602 (pp_cache): Don't assume cache_len fits in int.
1603 * region-cache.h: Adjust extern decls to match.
1604
1605 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1606 EMACS_INT, since either will do, for xpalloc.
1607
1608 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1609 (xnmalloc, xnrealloc, xpalloc): New functions.
1610
726e0ab1
PE
1611 * bidi.c (bidi_shelve_header_size): New constant.
1612 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1613 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1614
51f30bc5 1615 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1616 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1617 (overlay_strings):
1618 Don't update size of array until after memory allocation succeeds,
1619 because xmalloc/xrealloc may not return.
0065d054
PE
1620 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1621 now that we have proper integer overflow checking.
1622 (record_overlay_string, overlay_strings): Catch overflows when
1623 calculating size of overlay_str_buf.
726e0ab1 1624
0065d054
PE
1625 * callproc.c (Fcall_process): Check for size overflow when
1626 calculating size of args2.
1627 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1628 Normally we prefer signed values, but sticking with ptrdiff_t would
1629 require adding more-complicated checks.
726e0ab1
PE
1630
1631 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1632 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1633 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1634 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1635
1636 * character.c (Fstring): Check for size-calculation overflow.
1637
1638 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1639 unnecessary integer overflow. Check for size overflow.
1640 (encode_coding_object): Don't update size until xmalloc succeeds.
1641
1642 * composite.c (get_composition_id): Check for overflow in glyph
1643 length calculations.
1644
1645 Integer and memory overflow fixes for display code.
1646 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1647 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1648 (scrolling_window): Check for overflow in size calculations.
1649 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1650 Don't assume glyph table len fits in int.
1651 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1652 (row_table_size): Now ptrdiff_t, not int.
1653 (scrolling_window): Avoid overflow in size calculations.
1654 Don't update size until allocation succeeds.
1655 * fns.c (concat): Check for overflow in size calculations.
1656 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1657 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1658 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1659
1660 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1661 (get_doc_string): Check for size calculation overflow.
1662 Don't update size until allocation succeeds.
1663 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1664 EMACS_INT, where ptrdiff_t will do.
1665 (Fsubstitute_command_keys): Check for string overflow.
1666
1667 * editfns.c (set_time_zone_rule): Don't assume environment length
1668 fits in int.
1669 (message_length): Now ptrdiff_t, not int.
1670 (Fmessage_box): Don't update size until allocation succeeds.
1671 Don't assume message length fits in int.
1672 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1673
0065d054
PE
1674 * emacs.c (main): Do not reallocate argv, since there is a null at
1675 the end that can be overwritten, and this way there's no need to
1676 worry about size-calculation overflow.
1677 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1678
1679 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1680 alloc succeeds.
1681 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1682
1683 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1684 (x_set_scroll_bar_width, x_figure_window_size):
1685 Check for integer overflow.
1686 (x_set_alpha): Do not assume XINT fits in int.
1687
1688 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1689 This is for the members text_lines, text_cols, total_lines, total_cols,
1690 where the system imposes an 'int' limit.
1691
1692 * fringe.c (Fdefine_fringe_bitmap):
1693 Don't update size until alloc works.
1694
1695 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1696 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1697
1698 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1699 Check for size-calculation overflow.
1700 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1701 do, as we prefer signed integers.
1702 (id_to_widget.max_size, id_to_widget.used)
1703 (xg_store_widget_in_map, xg_remove_widget_from_map)
1704 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1705 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1706 Use and return ptrdiff_t, not int.
1707 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1708 * gtkutil.h: Change prototypes to match the above.
1709
1710 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1711 are duplicate now that they've been promoted to lisp.h.
1712 (x_allocate_bitmap_record, x_alloc_image_color)
1713 (make_image_cache, cache_image, xpm_load):
1714 Don't update size until alloc is done.
1715 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1716 (x_detect_edges):
3256efce 1717 Check for size calculation overflow.
726e0ab1
PE
1718 (ct_colors_allocated_max): New constant.
1719 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1720 overflow.
3256efce 1721
726e0ab1
PE
1722 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1723 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1724 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1725 Use ptrdiff_t, not int, to count maps.
1726 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1727 calculations. Don't update size until allocation succeeds.
1728 Redo calculations to avoid overflow.
726e0ab1
PE
1729 * keyboard.h: Change prototypes to match the above.
1730
1731 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1732 to count maps.
1733 (current_minor_maps): Check for size calculation overflow.
1734 * keymap.h: Change prototypes to match the above.
1735
1736 * lread.c (read1, init_obarray): Don't update size until alloc done.
1737
1738 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1739 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1740
726e0ab1
PE
1741 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1742 Now ptrdiff_t, not int.
1743 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1744 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1745
1746 * process.c (Fnetwork_interface_list): Check for overflow
1747 in size calculation.
1748
1749 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1750
1751 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1752 overflow. Don't bother calling xmalloc when xrealloc will do.
1753
1754 * search.c (Freplace_match): Check for size calculation overflow.
1755 (Fset_match_data): Don't assume list lengths fit in 'int'.
1756
1757 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1758 for command line length. Do not attempt to address one before the
1759 beginning of an array, as that's not portable.
1760
1761 * term.c (max_frame_lines): Remove; unused.
1762 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1763 not int.
1764 (encode_terminal_code, calculate_costs): Check for size
1765 calculation overflow.
1766 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1767 table lengths and related sizes. Don't update size until alloc
1768 done. Redo calculations to avoid overflow.
1769 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1770
1771 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1772 subtracting pointers.
1773 (gobble_line): Check for overflow more carefully. Don't update size
1774 until alloc done.
1775
1776 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1777 Don't update size until alloc done.
1778 Redo size calculations to avoid overflow.
1779 Check for size calculation overflow.
0065d054 1780 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1781
1782 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1783 Use ptrdiff_t, not int, for sizes.
1784 (store_mode_line_noprop_char): Don't update size until alloc done.
1785
0065d054
PE
1786 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1787 Use ptrdiff_t, not int, for sizes.
1788 (Finternal_make_lisp_face, cache_face):
1789 Check for size calculation overflow.
1790 (cache_face): Treat size calculation overflows as if they were
1791 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1792
1793 * xfns.c (x_encode_text, x_set_name_internal)
1794 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1795 sizes, since they can exceed INT_MAX in size. Check for size
1796 calculation overflow.
1797
0065d054
PE
1798 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1799 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1800 Don't update size until alloc done.
1801
0065d054 1802 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1803 as sprintf is limited to int lengths.
1d526e2f 1804
252c5ee1
PE
1805 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1806 (X_LONG_MIN): New macros.
864d7ce7
PE
1807 Use them to make the following changes clearer.
1808 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1809 This change doesn't affect the value now, but it may help remind
1810 future maintainers not to raise the value too much later.
1811 (SELECTION_QUANTUM): Remove, replacing with ...
1812 (selection_quantum): ... new function, which avoids overflow.
1813 All uses changed.
1814 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1815 assumption that selection length fits in 'int'.
1816 (x_reply_selection_request, x_handle_selection_request)
1817 (x_get_window_property, receive_incremental_selection)
1818 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1819 (lisp_data_to_selection_data, clean_local_selection_data):
1820 Use ptrdiff_t, not int, to record length of selection.
1821 (x_reply_selection_request, x_get_window_property)
1822 (receive_incremental_selection, x_property_data_to_lisp):
1823 Redo calculations to avoid overflow.
1824 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1825 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1826 something.
1827 (x_get_window_property, receive_incremental_selection)
1828 (lisp_data_to_selection_data, x_property_data_to_lisp):
1829 Check for size-calculation overflow.
1830 (x_get_window_property, receive_incremental_selection)
1831 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1832 Don't store size until memory allocation succeeds.
1833 (x_get_window_property): Plug memory leak on memory exhaustion.
1834 Don't double-block input; malloc is safe here. Don't assume 2**34
1835 - 4 fits in unsigned long. Add an xassert to check
1836 XGetWindowProperty overflow. Be more careful about overflow
1837 calculations, and distinguish size from memory overflow better.
1838 (receive_incremental_selection): When tracing, don't assume
1839 unsigned int is less than INT_MAX.
1840 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1841 harmful) conversions of unsigned short to int.
1842 (lisp_data_to_selection_data): Don't assume that integers
1843 in the range -65535 through -1 fit in an X unsigned short.
1844 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1845 result parameters unless successful. Rely on cons_to_unsigned
1846 to report problems with elements; the old code wasn't right anyway.
1847 (x_check_property_data): Check for int overflow; we cannot use
1848 a wider type due to X limits.
1849 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1850
726e0ab1 1851 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1852
0065d054
PE
1853 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1854 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1855 (x_color_cells): Don't store size until memory allocation succeeds.
1856 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1857 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1858 (x_term_init): Don't assume length fits in int (sprintf is limited
1859 to int size).
bc18e09d 1860
ebfa62c0
PE
1861 Use ptrdiff_t for composition IDs.
1862 * character.c (lisp_string_width):
1863 * composite.c (composition_table_size, n_compositions)
1864 (get_composition_id, composition_gstring_from_id):
1865 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1866 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1867 * window.c (Frecenter):
1868 Use ptrdiff_t, not int, for composition IDs.
1869 * composite.c (get_composition_id): Check for integer overflow.
1870 * composite.h: Adjust prototypes to match the above changes.
1871
d3411f89
PE
1872 Use ptrdiff_t for hash table indexes.
1873 * category.c (hash_get_category_set):
1874 * ccl.c (ccl_driver):
1875 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1876 * coding.c (coding_system_charset_list, detect_coding_system):
1877 * coding.h (struct coding_system.id):
1878 * composite.c (get_composition_id, gstring_lookup_cache):
1879 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1880 * image.c (xpm_get_color_table_h):
1881 * lisp.h (hash_lookup, hash_put):
1882 * minibuf.c (Ftest_completion):
1883 Use ptrdiff_t for hash table indexes, not int (which is too
1884 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1885 32-bit --with-wide-int hosts).
1886
e097a6fa
PE
1887 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1888 Add a FIXME comment about memory leaks.
1889 (syms_of_charset): Don't assume xmalloc returns.
1890
5637687f
PE
1891 Don't assume that stated character widths fit in int.
1892 * character.c (Fchar_width, c_string_width, lisp_string_width):
1893 * character.h (CHAR_WIDTH):
1894 * indent.c (MULTIBYTE_BYTES_WIDTH):
1895 Use sanitize_char_width to avoid undefined and/or bad behavior
1896 with outlandish widths.
a66cfb1c 1897 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1898 now that we have two such functions. All uses changed.
1899 (sanitize_char_width): New inline function.
1900
a2271ba2
PE
1901 Don't assume that tab-width fits in int.
1902 * character.h (sanitize_width): New inline function.
1903 (SANE_TAB_WIDTH): New macro.
1904 (ASCII_CHAR_WIDTH): Use it.
1905 * indent.c (sane_tab_width): Remove. All uses replaced by
1906 SANE_TAB_WIDTH (current_buffer).
1907 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1908
18c52557
PE
1909 * fileio.c: Integer overflow issues with file modes.
1910 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1911
caeeedc1
PE
1912 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1913 Remove unreachable code.
1914 (read_hex, load_charset_map_from_file): Check for integer overflow.
1915
50849c52
PE
1916 * xterm.c: don't go over XClientMessageEvent limit
1917 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1918 (x_send_scroll_bar_event): Likewise. Check that the size does not
1919 exceed limits imposed by XClientMessageEvent, as well as the usual
1920 ptrdiff_t and size_t limits.
1921
b13995db
PE
1922 * keyboard.c: Overflow, signedness and related fixes.
1923 (make_lispy_movement): Use same integer type in forward decl
1924 that is used in the definition.
1925 (read_key_sequence, keyremap_step):
1926 Change bufsize argument back to int, undoing my 2011-03-30 change.
1927 We prefer signed types, and int is wide enough here.
1928 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1929 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1930 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1931 length, not size_t. Use ptrdiff_t for index, not int.
1932 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1933 possibility of integer overflow.
1934
13464394
PE
1935 Overflow, signedness and related fixes for images.
1936
1937 * dispextern.h (struct it.stack[0].u.image.image_id)
1938 (struct_it.image_id, struct image.id, struct image_cache.size)
1939 (struct image_cache.used, struct image_cache.ref_count):
1940 * gtkutil.c (update_frame_tool_bar):
1941 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1942 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1943 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1944 * nsmenu.m (update_frame_tool_bar):
1945 * xdisp.c (calc_pixel_width_or_height):
1946 * xfns.c (image_cache_refcount):
1947 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1948 on typical 64-bit hosts.
1949
1950 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1951 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1952 Omit unnecessary casts to int.
1953 (parse_image_spec): Check that integers fall into 'int' range
1954 when the callers expect that.
1955 (image_ascent): Redo ascent calculation to avoid int overflow.
1956 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1957 (lookup_image): Remove unnecessary tests.
1958 (xbm_image_p): Locals are now of int, not EMACS_INT,
1959 since parse_image_check makes sure they fit into int.
1960 (png_load, gif_load, svg_load_image):
1961 Prefer int to unsigned where either will do.
1962 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1963 old tiff_error_handler and tiff_warning_handler.
1964 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1965 stack buffer overflows. It uses only the features of vsnprintf
1966 that are common to both POSIX and native Microsoft.
1967 (tiff_error_handler, tiff_warning_handler): Use it.
1968 (tiff_load, gif_load, imagemagick_load_image):
1969 Don't assume :index value fits in 'int'.
1970 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1971 (imagemagick_load_image): Check that crop parameters fit into
1972 the integer types that MagickCropImage accepts. Don't assume
1973 Vimagemagick_render_type has a nonnegative value. Don't assume
1974 size_t fits in 'long'.
1975 (gs_load): Use printmax_t to print the widest integers possible.
1976 Check for integer overflow when computing image height and width.
1977
c11821d4
EZ
19782011-08-26 Eli Zaretskii <eliz@gnu.org>
1979
1980 * xdisp.c (redisplay_window): Don't force window start if point
1981 will be invisible in the resulting window. (Bug#9324)
1982
0c95fcf7
EZ
19832011-08-25 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1986 the display spec is of the form `(space ...)'.
1987 (handle_display_spec): Return the value returned by
1988 handle_single_display_spec, not just 1 or zero.
1989 (handle_single_display_spec): If the display spec is of the form
1990 `(space ...)', and specifies display in the text area, return 2
1991 rather than 1.
fee65a97 1992 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1993 accurately, and prefer exact match for point under bidi.
1994 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1995
1996 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1997 into disp_prop; all users changed.
1998
1999 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2000 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2001 for the text covered by the display property.
2002
e4ed06f1
CY
20032011-08-25 Chong Yidong <cyd@stupidchicken.com>
2004
2005 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2006 Change return value to nil.
2007 (Frecord_buffer): Delete unused function.
2008
f67cdd7f
EZ
20092011-08-24 Eli Zaretskii <eliz@gnu.org>
2010
5980d4c6
EZ
2011 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2012 buffers, return left-to-right.
8610fe8b
EZ
2013 (set_cursor_from_row): Consider candidate row a win if its glyph
2014 represents a newline and point is on that newline. Fixes cursor
2015 positioning on the newline at EOL of R2L text within L2R
2016 paragraph, and vice versa.
2017 (try_cursor_movement): Check continued rows, in addition to
2018 continuation rows. Fixes unwarranted scroll when point enters a
2019 continued line of R2L text within an L2R paragraph, or vice versa.
2020 (cursor_row_p): Consider the case of point being equal to
2021 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2022 from the end of a short line to the beginning of a continued line
2023 of R2L text within L2R paragraph.
2024 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2025 composed characters.
5980d4c6 2026
f67cdd7f
EZ
2027 * bidi.c (bidi_check_type): Use xassert.
2028 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2029 members.
2030
bca633fb
EZ
20312011-08-23 Eli Zaretskii <eliz@gnu.org>
2032
2033 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2034 a character.
2035
4a5885a7
CY
20362011-08-23 Chong Yidong <cyd@stupidchicken.com>
2037
2038 * nsfont.m (ns_otf_to_script): Fix typo.
2039
0902a04e
KH
20402011-08-22 Kenichi Handa <handa@m17n.org>
2041
2042 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2043 extra slot even if the purpose is char-code-property-table.
2044
1a2e6670
EZ
20452011-08-23 Eli Zaretskii <eliz@gnu.org>
2046
8ddde651
EZ
2047 * xdisp.c (redisplay_window): When computing centering_position,
2048 account for the height of the header line. (Bug#8874)
2049
425cc014
EZ
2050 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2051 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2052 candidate is selected by the mouse, and that candidate has a
2053 composed character under the mouse.
2054
1a2e6670
EZ
2055 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2056 coordinates reported by pos-visible-in-window-p for a composed
2057 character in column zero.
2058
8b76d6f8
SM
20592011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2062
dac347dd
EZ
20632011-08-22 Eli Zaretskii <eliz@gnu.org>
2064
2065 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2066 consider it a hit if to_charpos is anywhere in the range of the
2067 composed buffer positions.
2068
e013fb34
CY
20692011-08-22 Chong Yidong <cyd@stupidchicken.com>
2070
2071 * image.c (gif_load): Don't assume that each subimage has the same
2072 dimensions as the base image. Handle disposal method that is
2073 "undefined" by the gif spec (Bug#9335).
2074
bd1ba3e8
CY
20752011-08-20 Chong Yidong <cyd@stupidchicken.com>
2076
2077 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2078 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2079
54a1215b
EZ
20802011-08-19 Eli Zaretskii <eliz@gnu.org>
2081
823564e5
EZ
2082 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2083 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2084 from an Org mode buffer to a Speedbar frame.
2085
54a1215b
EZ
2086 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2087 a composition, take its buffer position from IT->cmp_it.charpos.
2088 Fixes cursor positioning at the beginning of a line that begins
2089 with a composed character.
2090
9778ebcc
EZ
20912011-08-18 Eli Zaretskii <eliz@gnu.org>
2092
0be6ee06
EZ
2093 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2094 character bidirectional type, use STRONG_L instead. Fixes crashes
2095 in a buffer produced by `describe-categories'.
2096
9778ebcc
EZ
2097 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2098 members before the level stack, so they would be saved and
2099 restored when copying iterator state. Fixes incorrect reordering
2100 around TABs covered by display properties.
2101
156bffbe
AS
21022011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2103
6b02f655 2104 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2105
72ad093b
CY
21062011-08-17 Chong Yidong <cyd@stupidchicken.com>
2107
2108 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2109 (internal_condition_case_2, internal_condition_case_n):
2110 Remove unnecessary aborts (Bug#9081).
72ad093b 2111
35774242
EZ
21122011-08-17 Eli Zaretskii <eliz@gnu.org>
2113
2114 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2115 has no `load' handler, try opening the file locally. (Bug#9311)
2116
db76dd85
KB
21172011-08-16 Ken Brown <kbrown@cornell.edu>
2118
2119 * gmalloc.c: Expand comment.
2120
b215eee5
EZ
21212011-08-16 Eli Zaretskii <eliz@gnu.org>
2122
2123 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2124 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2125
a4579d33
KB
21262011-08-16 Ken Brown <kbrown@cornell.edu>
2127
2128 Fix memory allocation problems in Cygwin build (Bug#9273).
2129
2130 * unexcw.c ( __malloc_initialized): Declare external variable.
2131 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2132
8b76d6f8
SM
2133 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2134 New variables.
a4579d33
KB
2135 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2136 dumped emacs.
2137 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2138 in the static heap.
2139 [CYGWIN] (special_realloc): New function.
2140 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2141 requests to realloc storage in the static heap.
2142
3ebec551
PE
21432011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2144
2145 * bidi.c (bidi_initialize): Remove unused local.
2146
9fd8be00
EZ
21472011-08-15 Eli Zaretskii <eliz@gnu.org>
2148
6b02f655
SM
2149 * bidimirror.h:
2150 * biditype.h: Remove file.
2151 * makefile.w32-in ($(BLD)/bidi.$(O)):
2152 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2153
2154 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2155
2156 * chartab.c: Improve commentary for the uniprop_table API.
2157
32413314
EZ
2158 * bidi.c (bidi_paragraph_init): Support zero value of
2159 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2160 (bidi_initialize): Use uniprop_table instead of including
2161 biditype.h and bidimirror.h.
32413314 2162
9fd8be00
EZ
2163 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2164 coordinates of the iterator when restoring from ppos_it.
2165 (Bug#9296)
2166
5cf2b69b
KH
21672011-08-14 Kenichi Handa <handa@m17n.org>
2168
2169 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2170 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2171
daf17d00
EZ
21722011-08-14 Eli Zaretskii <eliz@gnu.org>
2173
2174 * xdisp.c (move_it_in_display_line_to): Don't invoke
2175 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2176 ppos_it. Fixes vertical cursor motion when line beginning is
2177 covered by an image. (Bug#9296)
2178
08e3161a
JD
21792011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2180
2181 * nsterm.h (ns_run_ascript): Declare.
2182 (NSAPP_DATA2_RUNASSCRIPT): Define.
2183
2184 * nsfns.m (as_script, as_result, as_status): New static variables.
2185 (ns_run_ascript): New function.
5e617bc2 2186 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2187 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2188 the event loop. Get status from as_status (Bug#7276).
2189
2190 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2191 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2192 the event loop (Bug#7276).
2193
a3720aa2
AS
21942011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2195
2196 * gnutls.c (QCgnutls_bootprop_priority)
2197 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2198 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2199 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2200 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2201 (QCgnutls_bootprop_verify_hostname_error)
2202 (QCgnutls_bootprop_callbacks_verify): Rename from
2203 Qgnutls_bootprop_..., all uses changed.
2204
2205 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2206 uses changed.
2207
0a0d27fb
PE
22082011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2209
19d5c50c
PE
2210 * xfaces.c (Qframe_set_background_mode): Now static.
2211 * dispextern.h (Qframe_set_background_mode): Remove decl.
2212
0a0d27fb
PE
2213 * process.c (Fnetwork_interface_info): Declare local only if needed.
2214
377538cb
JD
22152011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2216
2217 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2218 (Fnetwork_interface_list): Allocate in increments of bytes instead
2219 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2220 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2221 sockaddr.
2222 (struct ifflag_def): notrailers is smart on OSX.
2223 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2224 Get hardware address with getifaddrs if available.
2225
08fff70c
EZ
22262011-08-12 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (iterate_out_of_display_property): xassert that
2229 IT->position is set to within IT->object's boundaries. Break from
2230 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2231 when IT->position is set up wrongly due to some bug.
2232 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2233 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2234 entry. Force push_it to save on the stack the current
2235 buffer/string position, to be restored by pop_it. Fix flags in
2236 the iterator structure wrt the object coming from a display
2237 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2238 properties. (Bug#9284)
2239
7be1c708 22402011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2241
7be1c708
CY
2242 * fontset.c (fontset_get_font_group): Add proper type checks.
2243 (Bug#9172)
aac0c6e3 2244
7be1c708 22452011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2246
7be1c708
CY
2247 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2248 and LC_VERSION_MIN_MACOSX.
2249 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2250 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2251
97bb72a6
EZ
22522011-08-08 Eli Zaretskii <eliz@gnu.org>
2253
2254 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2255 no-display-properties-and-no-overlays under bidi display.
2256 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2257 properties and overlays.
97bb72a6 2258
d5617611
CY
22592011-08-08 Chong Yidong <cyd@stupidchicken.com>
2260
37e11a63
CY
2261 * editfns.c (Fset_time_zone_rule): Document relationship with the
2262 setenv function.
2263
d5617611
CY
2264 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2265 the font entity extracted from the cache (Bug#8109).
2266
58872834
CY
22672011-08-07 Chong Yidong <cyd@stupidchicken.com>
2268
2269 * composite.c (autocmp_chars): Don't reset point. That is done by
2270 restore_point_unwind (Bug#5984).
2271
75bfc667
JL
22722011-08-07 Juri Linkov <juri@jurta.org>
2273
2274 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2275 to show the arg `TIME' instead of `TIMEVAL'.
2276
d1410150
EZ
22772011-08-06 Eli Zaretskii <eliz@gnu.org>
2278
2279 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2280 display property strides EOL and includes a newline, as in
2281 longlines-mode. (Bug#9254)
75b771e4
EZ
2282 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2283 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2284
2285 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2286 is non-zero, even if the data buffer is NULL. Fixes a crash in
2287 vertical-motion with longlines-mode. (Bug#9254)
2288
35928349
EZ
22892011-08-05 Eli Zaretskii <eliz@gnu.org>
2290
ec7cc85b
EZ
2291 * bidi.c <bidi_cache_total_alloc>: Now static.
2292 (bidi_initialize): Initialize bidi_cache_total_alloc.
2293
8b76d6f8 2294 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2295 cache. (Bug#9221)
2296
2297 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2298 amount allocated this far in `bidi_cache_total_alloc'.
2299 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2300 non-zero, only free the data buffer without restoring the cache
2301 contents. All callers changed.
2302
2303 * dispextern.h (bidi_unshelve_cache): Update prototype.
2304
2305 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2306 (move_it_in_display_line, move_it_to)
2307 (move_it_vertically_backward, move_it_by_lines): Replace the call
2308 to xfree to an equivalent call to bidi_unshelve_cache.
2309 (move_it_in_display_line_to): Fix logic of returning
412b6358 2310 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2311
e2e2423b
EZ
23122011-08-05 Eli Zaretskii <eliz@gnu.org>
2313
2314 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2315 came from a string character with a `cursor' property. (Bug#9229)
2316
ae9e757a
JD
23172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2318
2319 * Makefile.in (LIB_PTHREAD): New variable.
2320 (LIBES): Add LIB_PTHREAD (Bug#9216).
2321
2322 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2323 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2324
213bd7f2
AS
23252011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2326
6b02f655 2327 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2328
99aaf75f
JD
23292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2330
2331 * xterm.c (x_find_topmost_parent): New function.
2332 (x_set_frame_alpha): Find topmost parent window with
2333 x_find_topmost_parent and set the property there also (bug#9181).
2334 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2335
c74e9d86
PE
23362011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2337
2338 * callproc.c (Fcall_process): Avoid vfork clobbering
2339 the local vars buffer, coding_systems, current_dir.
2340
640c8776
SM
23412011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2342
2343 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2344
f26d0e4c
PE
23452011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2346
8a10d76c
PE
2347 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2348 so that it is not optimized away.
2349
f26d0e4c
PE
2350 * xdisp.c (compute_display_string_pos): Remove unused local.
2351
55439c61
EZ
23522011-08-02 Eli Zaretskii <eliz@gnu.org>
2353
2354 Fix slow cursor motion and scrolling in large buffers with
2355 selective display, like Org Mode buffers. (Bug#9218)
2356
2357 * dispextern.h (struct bidi_it): New member disp_prop_p.
2358
2359 * xdisp.c: Remove one-slot cache of display string positions.
2360 (compute_display_string_pos): Accept an additional argument
5e617bc2 2361 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2362 for a display string or property. If found, set DISP_PROP_P
2363 non-zero.
2364
2365 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2366 DISP_PROP_P, and pass it to compute_display_string_pos.
2367 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2368 non-zero. All callers of bidi_fetch_char changed.
2369
fb33fa43
SM
23702011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2373
b099e063
DM
23742010-12-03 Don March <don@ohspite.net>
2375
2376 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2377 last character M-[char] is translated to ESC [char] (bug#7541).
2378
5cc7f7af
KH
23792011-08-02 Kenichi Handa <handa@m17n.org>
2380
d0fffa3f 2381 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2382
2383 * chartab.c (uniprop_table): Make it non-static.
2384
525d5e6e
EZ
23852011-08-01 Eli Zaretskii <eliz@gnu.org>
2386
2387 * xdisp.c (forward_to_next_line_start): Accept additional argument
2388 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2389 on the newline.
2390 (reseat_at_next_visible_line_start): Use the bidi iterator state
2391 returned by forward_to_next_line_start to restore the state of
2392 it->bidi_it after backing up to previous newline. (Bug#9212)
2393
31011111
AS
23942011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2395
2396 * regex.c (re_comp): Protoize.
2397 (re_exec): Fix return type.
2398 (regexec): Fix type of `ret'. (Bug#9203)
2399
476371c4
PE
24002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2401
e5d76069
PE
2402 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2403 This is needed if max-image-size is a floating-point number.
2404
9a79b20c
AS
24052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2406
2407 * print.c (print_object): Print empty symbol as ##.
2408
2409 * lread.c (read1): Read ## as empty symbol.
2410
d8c2fa78
AA
24112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2412
2413 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2414 setting frame foreground color (Bug#9175).
2415 (x_set_background_color): Likewise.
2416
ffe57a7a
AA
2417 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2418 contents (Bug#9176).
2419 (EmacsTooltip -init): Remove bezels and add shadows to
2420 tooltip windows.
2421
bf3492a5
AA
2422 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2423 or scroll bar (Bug#8470).
2424
d55e9c53
AA
2425 * nsfont.m (nsfont_open): Remove assignment to voffset and
2426 unnecessary vars hshink, expand, hd, full_height, min_height.
2427 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2428
2429 * nsterm.h (nsfont_info): Remove voffset field.
2430
d8c2fa78 24312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2432
2433 Implement strike-through and overline on NextStep (Bug#8863).
2434
2435 * nsfont.m (nsfont_open): Use underline position provided by font,
2436 instead of hard-coded value of 2.
2437 (nsfont_draw): Call ns_draw_text_decoration instead.
2438
2439 * nsterm.h: Add declaration for ns_draw_text_decoration.
2440
2441 * nsterm.m (ns_draw_text_decoration): New function for drawing
2442 underline, overline, and strike-through.
2443 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2444 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2445 accommodate underlining, etc.
4843aac3 2446
4cc60b9b
EZ
24472011-07-28 Eli Zaretskii <eliz@gnu.org>
2448
bc7ece87
EZ
2449 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2450 default.
4cc60b9b 2451
476371c4
PE
24522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2453
66606eea
PE
2454 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2455 Without this fix, if a signal arrives just after memory fills up,
2456 'malloc' might be invoked reentrantly.
2457
476371c4
PE
2458 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2459 In other words, assume that every image size is allowed, on non-X
2460 hosts. This assumption is probably wrong, but it lets Emacs compile.
2461
f3fcc40d
AS
24622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * regex.c (re_iswctype): Convert return values to boolean.
2465
350c992f
EZ
24662011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2467
2468 * xdisp.c (compute_display_string_pos): Don't use cached display
2469 string position if the buffer had its restriction changed.
2470 (Bug#9184)
2471
5266b4bb
PE
24722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2475
2573a837 24762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2477
41f55ccd 2478 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2479
39e378da
PE
2480 * bidi.c: Integer size and overflow fixes.
2481 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2482 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2483 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2484 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2485 (bidi_find_other_level_edge):
2486 Use ptrdiff_t instead of EMACS_INT where either will do.
2487 This works better on 32-bit hosts configured --with-wide-int.
2488 (bidi_cache_ensure_space): Check for size-calculation overflow.
2489 Use % rather than repeated addition, for better worst-case speed.
2490 Don't set bidi_cache_size until after xrealloc returns, because it
2491 might not return.
2492 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2493 (bidi_cache_ensure_space): Also check that the bidi cache size
2494 does not exceed that of the largest Lisp string or buffer. See Eli
2495 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2496
5e927815
PE
2497 * alloc.c (__malloc_size_t): Remove.
2498 All uses replaced by size_t. See Andreas Schwab's note
2499 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2500
ca4aa935
PE
2501 * image.c: Improve checking for integer overflow.
2502 (check_image_size): Assume that f is nonnull, since
2503 it is always nonnull in practice. This is one less thing to
2504 worry about when checking for integer overflow later.
2505 (x_check_image_size): New function, which checks for integer
2506 overflow issues inside X.
2507 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2508 This removes the need for a memory_full check.
2509 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2510 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2511 (xbm_read_bitmap_data): Change locals back to 'int', since
2512 their values must fit in 'int'.
2513 (xpm_load_image, png_load, tiff_load):
2514 Invoke x_create_x_image_and_pixmap earlier,
2515 to avoid much needless work if the image is too large.
2516 (tiff_load): Treat overly large images as if
2517 x_create_x_image_and_pixmap failed, not as malloc failures.
2518 (gs_load): Use x_check_image_size.
2519
5f8f9cc2
PE
2520 * gtkutil.c: Omit integer casts.
2521 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2522 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2523
5adf60bc
PE
2524 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2525
c8907a93
PE
2526 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2527 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2528 would wrongly return t on a 64-bit host.
2529
e3c25c68
PE
2530 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2531 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2532 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2533 and therefore cause GCC to emit a bogus diagnostic in some cases.
2534
3f791afe
PE
2535 * image.c: Integer signedness and overflow and related fixes.
2536 This is not an exhaustive set of fixes, but it's time to
2537 record what I've got.
2538 (lookup_pixel_color, check_image_size): Remove redundant decls.
2539 (check_image_size): Don't assume that arbitrary EMACS_INT values
2540 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2541 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2542 (tiff_load, imagemagick_load_image):
2543 Check for overflow in size calculations.
2544 (x_create_x_image_and_pixmap): Remove unnecessary test for
2545 xmalloc returning NULL; that can't happen.
2546 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2547 (xpm_color_bucket): Use better integer hashing function.
2548 (xpm_cache_color): Don't possibly over-allocate memory.
2549 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2550 (gif_memory_source):
2551 Use ptrdiff_t, not int or size_t, to record sizes.
2552 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2553 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2554 either works, as we prefer signed integers.
2555 (tiff_read_from_memory, tiff_write_from_memory):
2556 Return tsize_t, not size_t, since that's what the TIFF API wants.
2557 (tiff_read_from_memory): Don't fail simply because the read would
2558 go past EOF; instead, return a short read.
2559 (tiff_load): Omit no-longer-needed casts.
2560 (Fimagemagick_types): Don't assume size fits into 'int'.
2561
3cc5a532
PE
2562 Improve hashing quality when configured --with-wide-int.
2563 * fns.c (hash_string): New function, taken from sxhash_string.
2564 Do not discard information about ASCII character case; this
2565 discarding is no longer needed.
2566 (sxhash-string): Use it. Change sig to match it. Caller changed.
2567 * lisp.h: Declare it.
2568 * lread.c (hash_string): Remove, since we now use fns.c's version.
2569 The fns.c version returns a wider integer if --with-wide-int is
2570 specified, so this should help the quality of the hashing a bit.
2571
b312a492
PE
2572 * emacs.c: Integer overflow minor fix.
2573 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2574 Define only if GNU_LINUX.
2575 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2576
dfd153ae
PE
2577 * dispnew.c: Integer signedness and overflow fixes.
2578 Remove unnecessary forward decls, that were a maintenance hassle.
2579 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2580 All uses changed.
2581 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2582 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2583 (prepare_desired_row, line_draw_cost):
2584 Use int, not unsigned, where either works.
2585 (save_current_matrix, restore_current_matrix):
2586 Use ptrdiff_t, not size_t, where either works.
2587 (init_display): Check for overflow more accurately, and without
2588 relying on undefined behavior.
2589
a81d11a3
PE
2590 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2591 Remove, replacing with the new symbols in lisp.h. All uses changed.
2592 * fileio.c (make_temp_name):
2593 * filelock.c (lock_file_1, lock_file):
2594 * xdisp.c (message_dolog):
2595 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2596 Use pMd etc. instead.
2597 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2598 replacing the pWIDE etc. symbols removed from editfns.c.
2599
3300e6fd
PE
2600 * keyboard.h (num_input_events): Now uintmax_t.
2601 This is (very slightly) less likely to mess up due to wraparound.
2602 All uses changed.
2603
fd05c7e9
PE
2604 * buffer.c: Integer signedness fixes.
2605 (alloc_buffer_text, enlarge_buffer_text):
2606 Use ptrdiff_t rather than size_t when either will do, as we prefer
2607 signed integers.
2608
903fe15d
PE
2609 * alloc.c: Integer signedness and overflow fixes.
2610 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2611 (__malloc_size_t): Default to size_t, not to int.
2612 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2613 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2614 Prefer ptrdiff_t to size_t when either would do, as we prefer
2615 signed integers.
2616 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2617 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2618 Now const. Initialize with values that are in range even if char
2619 is signed.
2620 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2621 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2622 These functions do the right thing with sizes > 2**32.
2623 (check_depth): Now ptrdiff_t, not int.
2624 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2625 Adjust to new way of storing sizes. Check for size overflow bugs
2626 in rest of code.
2627 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2628 slightly wrong anyway, as it missed one instance of
2629 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2630 (refill_memory_reserve): Omit needless cast to size_t.
2631 (mark_object_loop_halt): Mark as externally visible.
2632
ac82cc6a
PE
2633 * xselect.c: Integer signedness and overflow fixes.
2634 (Fx_register_dnd_atom, x_handle_dnd_message):
2635 Use ptrdiff_t, not size_t, since we prefer signed.
2636 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2637 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2638 x_dnd_atoms_size and x_dnd_atoms_length.
2639
c2d1e36d
PE
2640 * doprnt.c: Prefer signed to unsigned when either works.
2641 * eval.c (verror):
2642 * doprnt.c (doprnt):
2643 * lisp.h (doprnt):
2644 * xdisp.c (vmessage):
2645 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2646 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2647 prefer signed arithmetic to avoid comparison confusion.
2648 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2649 but is a bit tricky.
2650
0e926e56
PE
2651 Assume freestanding C89 headers, string.h, stdlib.h.
2652 * data.c, doprnt.c, floatfns.c, print.c:
2653 Include float.h unconditionally.
2654 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2655 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2656 * regex.c: Likewise for stddef.h, string.h.
2657 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2658 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2659 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2660 (STDC_HEADERS): Remove obsolete defines.
2661 * sysdep.c: Include limits.h unconditionally.
2662
9cfdb3ec
PE
2663 Assume support for memcmp, memcpy, memmove, memset.
2664 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2665 * regex.c (memcmp, memcpy):
2666 Remove; we assume C89 now.
2667
2668 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2669 (__malloc_safe_bcopy): Remove; no longer needed.
2670
cf950e6b 2671 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2672 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2673 well either way, and we prefer signed to unsigned.
2674
dbf38e02
LMI
26752011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2676
2677 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2678 closes the connection while we're reading (bug#9182).
2679
d6f0886c 26802011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2681
d6f0886c
JD
2682 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2683 are specified (Bug#9168).
24e0f6b1 2684
2eb1f9e6
PE
26852011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2688 Found by GCC static checking and --with-wide-int on a 32-bit host.
2689
22381272 26902011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2691
2692 * xdisp.c (compute_display_string_pos): Fix logic of caching
2693 previous display string position. Initialize cached_prev_pos to
2694 -1. Fixes slow-down at the beginning of a buffer.
2695
f25e39b4
EZ
26962011-07-24 Eli Zaretskii <eliz@gnu.org>
2697
2698 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2699 for attrs[LFACE_FONTSET_INDEX].
2700
04c4b52e
PE
27012011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * xml.c (parse_region): Remove unused local
2704 that was recently introduced.
2705
c1734fbd
EZ
27062011-07-23 Eli Zaretskii <eliz@gnu.org>
2707
be18c5a5
EZ
2708 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2709 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2710
c1734fbd
EZ
2711 * xdisp.c (move_it_in_display_line_to): Record the best matching
2712 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2713 exit if none of the characters scanned was an exact match.
2714 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2715 when exact match is impossible due to invisible text, and the
2716 lines are truncated.
2717
a258d627
JD
27182011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2719
2720 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2721 for OSX >= 10.7.
2722
b6d5a689
EZ
27232011-07-22 Eli Zaretskii <eliz@gnu.org>
2724
0f74f785
EZ
2725 Fix a significant slow-down of cursor motion with C-n, C-p,
2726 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2727 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2728 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2729 (next_element_from_buffer): Call compute_stop_pos_backwards to
2730 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2731 base_level_stop.
2732 (reseat): Don't look for prev_stop, as that could mean a very long
2733 run.
2734 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2735 <cached_disp_overlay_modiff>: Cache for last found display string
2736 position.
551918c1 2737 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2738 about the same buffer in the same area of character positions, and
2739 the buffer wasn't changed since the time the display string
2740 position was cached.
551918c1 2741
b2d0c91a
EZ
27422011-07-22 Eli Zaretskii <eliz@gnu.org>
2743
2744 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2745 is an integer, which is important for empty lines. (Bug#9149)
2746
043604ee
CY
27472011-07-22 Chong Yidong <cyd@stupidchicken.com>
2748
2749 * frame.c (Fmodify_frame_parameters): In tty case, update the
2750 default face if necessary (Bug#4238).
2751
da4adb04
CY
27522011-07-21 Chong Yidong <cyd@stupidchicken.com>
2753
2754 * editfns.c (Fstring_to_char): No need to explain what a character
2755 is in the docstring (Bug#6576).
2756
9abd0532
LMI
27572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2758
2759 * xml.c (parse_region): Make sure we always return a tree.
2760
36881d16
HK
27612011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2762
2763 * xml.c (parse_region): If a document contains only comments,
2764 return that, too.
2765
1e98674d
LMI
27662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2767
2768 * xml.c (make_dom): Return comments, too.
2769
590bd467
PE
27702011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 Port to OpenBSD.
2773 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2774 and the surrounding thread.
2775 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2776 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2777 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2778 timer goes off.
2779 * s/openbsd.h (BROKEN_SIGIO): Define.
2780 * unexelf.c (unexec) [__OpenBSD__]:
2781 Don't update the .mdebug section of the Alpha COFF symbol table.
2782
f41628b2
LMI
27832011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2784
2785 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2786 (bug#8460).
2787
b59b67c5
PE
27882011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2789
15e3a074
PE
2790 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2791 This fixes some race conditions on the permissions of any newly
2792 created file.
2793
41bed37d
PE
2794 * alloc.c (valid_pointer_p): Use pipe, not open.
2795 This fixes some permissions issues when debugging.
2796
b59b67c5
PE
2797 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2798 If fchown fails to set both uid and gid, try to set just gid,
2799 as that is sometimes allowed. Adjust the file's mode to eliminate
2800 setuid or setgid bits that are inappropriate if fchown fails.
2801
925a6be7
SM
28022011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2803
2804 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2805 to compare Lisp_Objects.
2806 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2807 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2808 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2809
52968808
AS
28102011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2811
0a6a104b
AS
2812 * lread.c (read_integer): Unread even EOF character.
2813 (read1): Likewise. Properly record start position of symbol.
2814
52968808
AS
2815 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2816 symbol character follows.
2817
9e381cdd
PE
28182011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2819
2820 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2821 This works around a problem with the previous change to Fcopy_file.
2822 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2823 and without this change, GCC might complain about discarding
2824 fchown's return value.
2825
b5641435
JB
28262011-07-16 Juanma Barranquero <lekktu@gmail.com>
2827
2828 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2829
a8031457
PE
28302011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2831
2832 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2833
dd889327
LMI
28342011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2835
750c33f7
LMI
2836 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2837 it's used from the C level.
2838
dd889327
LMI
2839 * process.c: Use the same condition for POLL_FOR_INPUT in both
2840 keyboard.c and process.c (bug#1858).
2841
87e86684
LM
28422011-07-09 Lawrence Mitchell <wence@gmx.li>
2843
2844 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2845 (Fgnutls_boot): Use it.
2846
64348f40
AS
28472011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2848
2849 * doc.c (Fsubstitute_command_keys): Revert last change.
2850
1d698799
LMI
28512011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2852
f863868c
LMI
2853 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2854 quotes the next character, and doesn't affect other longer
2855 sequences (bug#8935).
2856
1d698799
LMI
2857 * lread.c (syms_of_lread): Clarify that is isn't only
2858 `eval-buffer' and `eval-defun' that's affected by
2859 `lexical-binding' (bug#8460).
2860
aa4b6df6
EZ
28612011-07-15 Eli Zaretskii <eliz@gnu.org>
2862
2863 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2864 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2865
5d856da6
PE
28662011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2867
ad6042bb
PE
2868 Fix minor problems found by static checking.
2869 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2870 (elsz): Now a signed constant, not a size_t var. We prefer signed
2871 types to unsigned, to avoid integer comparison confusion. Without
2872 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2873 "cannot optimize loop, the loop counter may overflow", a symptom
2874 of the confusion.
f00bbb22 2875 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2876 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2877
6468f31c
LMI
28782011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2879
49080b10
LMI
2880 * search.c (Fre_search_backward): Mention `case-fold-search' in
2881 all the re_search_* functions (bug#8138).
2882
6468f31c
LMI
2883 * keyboard.c (Fopen_dribble_file): Document when the file is
2884 closed (bug#8056).
2885
c965adc5
EZ
28862011-07-14 Eli Zaretskii <eliz@gnu.org>
2887
df9733bf
EZ
2888 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2889 bidi_cache_idx.
2890
0bb23927
EZ
2891 Support bidi reordering of display and overlay strings.
2892 * xdisp.c (compute_display_string_pos)
2893 (compute_display_string_end): Accept additional argument STRING.
2894 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2895 (reseat_to_string): Initialize bidi_it->string.s and
2896 bidi_it->string.schars.
2897 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2898 NULL (avoids a crash in bidi_paragraph_init).
2899 Initialize itb.string.lstring.
0bb23927
EZ
2900 (init_iterator): Call bidi_init_it only of a valid
2901 buffer position was specified. Initialize paragraph_embedding to
2902 L2R.
2903 (reseat_to_string): Initialize the bidi iterator.
2904 (display_string): If we need to ignore text properties of
2905 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2906 original value of -1 will not work with bidi.)
2907 (compute_display_string_pos): First arg is now struct
2908 `text_pos *'; all callers changed. Support display properties on
2909 Lisp strings.
2910 (compute_display_string_end): Support display properties on Lisp
2911 strings.
2912 (init_iterator, reseat_1, reseat_to_string): Initialize the
2913 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2914 when iterating on a string not from display properties).
640c8776
SM
2915 (compute_display_string_pos, compute_display_string_end):
2916 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2917 arrow keys.
2918 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2919 base_level_stop; instead, set base_level_stop to BEGV.
2920 Fixes crashes in vertical-motion.
0bb23927
EZ
2921 (next_element_from_buffer): Improve commentary for when
2922 the iterator is before prev_stop.
2923 (init_iterator): Initialize bidi_p from the default value of
2924 bidi-display-reordering, not from buffer-local value. Use the
2925 buffer-local value only if initializing for buffer iteration.
2926 (handle_invisible_prop): Support invisible properties on strings
2927 that are being bidi-reordered.
2928 (set_iterator_to_next): Support bidi reordering of C strings and
2929 Lisp strings.
2930 (next_element_from_string): Support bidi reordering of Lisp
2931 strings.
2932 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2933 (display_string): Support display of R2L glyph rows.
2934 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2935 (init_iterator): Don't initialize it->bidi_p for strings
2936 here.
2937 (reseat_to_string): Initialize it->bidi_p for strings here.
2938 (next_element_from_string, next_element_from_c_string)
2939 (next_element_from_buffer): Add xassert's for correspondence
2940 between IT's object being iterated and it->bidi_it.string
2941 structure.
2942 (face_before_or_after_it_pos): Support bidi iteration.
2943 (next_element_from_c_string): Handle the case of the first string
2944 character that is not the first one in the visual order.
2945 (get_visually_first_element): New function, refactored from common
2946 parts of next_element_from_buffer, next_element_from_string, and
2947 next_element_from_c_string.
2948 (tool_bar_lines_needed, redisplay_tool_bar)
2949 (display_menu_bar): Force left-to-right direction. Add a FIXME
2950 comment for making that be controlled by a user option.
2951 (push_it, pop_it): Save and restore the state of the
2952 bidi iterator. Save and restore the bidi_p flag.
2953 (pop_it): Iterate out of display property for string iteration as
2954 well.
2955 (iterate_out_of_display_property): Support iteration over strings.
2956 (handle_single_display_spec): Set up it->bidi_it for iteration
2957 over a display string, and call bidi_init_it.
2958 (handle_single_display_spec, next_overlay_string)
2959 (get_overlay_strings_1, push_display_prop): Set up the bidi
2960 iterator for displaying display or overlay strings.
2961 (forward_to_next_line_start): Don't use the shortcut if
2962 bidi-iterating.
2963 (back_to_previous_visible_line_start): If handle_display_prop
2964 pushed the iterator stack, restore the internal state of the bidi
2965 iterator by calling bidi_pop_it same number of times.
2966 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2967 and we are bidi-iterating, don't decrement the iterator position;
2968 instead, set the first_elt flag in the bidi iterator, to produce
2969 the same effect.
2970 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2971 (push_display_prop): xassert that we are iterating a buffer.
2972 (push_it, pop_it): Save and restore paragraph_embedding member.
2973 (handle_single_display_spec, next_overlay_string)
2974 (get_overlay_strings_1, reseat_1, reseat_to_string)
2975 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2976 correctly. Don't assume unibyte strings are not bidi-reordered.
2977 (compute_display_string_pos)
2978 (compute_display_string_end): Fix handling the case of C string.
2979 (push_it, pop_it): Save and restore from_disp_prop_p.
2980 (handle_single_display_spec, push_display_prop): Set the
2981 from_disp_prop_p flag.
2982 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2983 (pop_it): Call iterate_out_of_display_property only if we are
2984 popping after iteration over a string that came from a display
2985 property. Fix a typo in popping stretch info. Add an assertion
2986 for verifying that the iterator position is in sync with the bidi
2987 iterator.
2988 (handle_single_display_spec, get_overlay_strings_1)
2989 (push_display_prop): Fix initialization of paragraph direction for
2990 string when that of the parent object is not yet determined.
2991 (reseat_1): Call bidi_init_it to resync the bidi
2992 iterator with IT's position. (Bug#7616)
2993 (find_row_edges): If ROW->start.pos gives position
2994 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2995 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2996 Reset the from_disp_prop_p flag.
2997 (SAVE_IT, RESTORE_IT): New macros.
2998 (pos_visible_p, face_before_or_after_it_pos)
2999 (back_to_previous_visible_line_start)
3000 (move_it_in_display_line_to, move_it_in_display_line)
3001 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3002 (try_scrolling, redisplay_window, display_line): Use them when
3003 saving a temporary copy of the iterator and restoring it back.
3004 (back_to_previous_visible_line_start, reseat_1)
3005 (init_iterator): Empty the bidi cache "stack".
3006 (move_it_in_display_line_to): If iterator ended up at
3007 EOL, but we never saw any buffer positions smaller than
3008 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3009 motion in bidi-reordered lines.
3010 (move_it_in_display_line_to): Record prev_method and prev_pos
3011 immediately before the call to set_iterator_to_next. Fixes cursor
3012 motion in bidi-reordered lines with stretch glyphs and strings
3013 displayed in margins. (Bug#8133) (Bug#8867)
3014 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3015 TO_CHARPOS.
640c8776
SM
3016 (pos_visible_p): Support positions in bidi-reordered lines.
3017 Save and restore bidi cache.
0bb23927
EZ
3018
3019 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3020 (bidi_paragraph_info): Delete unused struct.
3021 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3022 (bidi_cache_start): New variable.
3023 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3024 to zero.
3025 (bidi_cache_fetch_state, bidi_cache_search)
3026 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3027 (bidi_cache_find, bidi_peek_at_next_level)
3028 (bidi_level_of_next_char, bidi_find_other_level_edge)
3029 (bidi_move_to_visually_next): Compare cache index with
3030 bidi_cache_start rather than with zero.
3031 (bidi_fetch_char): Accept new argument STRING; all callers
3032 changed. Support iteration over a string. Support strings with
3033 display properties. Support unibyte strings. Fix the type of
3034 `len' according to what STRING_CHAR_AND_LENGTH expects.
3035 (bidi_paragraph_init, bidi_resolve_explicit_1)
3036 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3037 (bidi_level_of_next_char, bidi_move_to_visually_next):
3038 Support iteration over a string.
0bb23927
EZ
3039 (bidi_set_sor_type, bidi_resolve_explicit_1)
3040 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3041 can now be zero (for strings); special values 0 and -1 were
3042 changed to -1 and -2, respectively.
3043 (bidi_char_at_pos): New function.
3044 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3045 Call it instead of FETCH_MULTIBYTE_CHAR.
3046 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3047 initialized to valid values.
3048 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3049 values.
3050 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3051 the test for valid cached positions. Fix the logic for looking up
3052 the sentinel state in the cache. GCPRO the Lisp string we are
3053 iterating.
3054 (bidi_push_it, bidi_pop_it): New functions.
3055 (bidi_initialize): Initialize the bidi cache start stack pointer.
3056 (bidi_cache_ensure_space): New function, refactored from part of
3057 bidi_cache_iterator_state. Don't assume the required size is just
3058 one BIDI_CACHE_CHUNK away.
3059 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3060 (bidi_count_bytes, bidi_char_at_pos): New functions.
3061 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3062 always valid if bidi_cache_idx is valid.
3063 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3064 is valid if it's going to be used.
3065 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3066 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3067 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3068 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3069 (bidi_find_other_level_edge, bidi_cache_start_stack):
3070 All variables related to cache indices are now EMACS_INT.
c965adc5 3071
0bb23927
EZ
3072 * dispextern.h (struct bidi_string_data): New structure.
3073 (struct bidi_it): New member `string'. Make flag members be 1-bit
3074 fields, and put them last in the struct.
640c8776
SM
3075 (compute_display_string_pos, compute_display_string_end):
3076 Update prototypes.
0bb23927
EZ
3077 (bidi_push_it, bidi_pop_it): Add prototypes.
3078 (struct iterator_stack_entry): New members bidi_p,
3079 paragraph_embedding, and from_disp_prop_p.
3080 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3081 (bidi_shelve_cache, bidi_unshelve_cache):
3082 Declare prototypes.
0bb23927
EZ
3083
3084 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3085 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3086 and vector-like objects.
3087
3088 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3089 cache around display iteration.
3090
3091 * window.c (Fwindow_end, window_scroll_pixel_based)
3092 (displayed_window_lines, Frecenter): Save and restore the bidi
3093 cache around display iteration.
3094
3bbd2265
LMI
30952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3096
3097 * editfns.c (Fdelete_region): Clarify the use of the named
3098 parameters (bug#6788).
3099
adc47434
MR
31002011-07-14 Martin Rudalics <rudalics@gmx.at>
3101
3102 * indent.c (Fvertical_motion): Set and restore w->pointm when
3103 saving and restoring the window's buffer (Bug#9006).
3104
837c31f8
LMI
31052011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3106
3107 * editfns.c (Fstring_to_char): Clarify just what is returned
3108 (bug#6576). Text by Eli Zaretskii.
3109
ac389d0c
JB
31102011-07-13 Juanma Barranquero <lekktu@gmail.com>
3111
3112 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3113
0be0ce47
EZ
31142011-07-13 Eli Zaretskii <eliz@gnu.org>
3115
3116 * buffer.c (mmap_find): Fix a typo.
3117
cd18e7e3
JB
31182011-07-13 Johan Bockgård <bojohan@gnu.org>
3119
3120 Fix execution of x selection hooks.
3121 * xselect.c (Qx_lost_selection_functions)
3122 (Qx_sent_selection_functions): New vars.
3123 (syms_of_xselect): DEFSYM them.
3124 (x_handle_selection_request): Pass Qx_sent_selection_functions
3125 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3126 (x_handle_selection_clear,x_clear_frame_selections):
3127 Pass Qx_lost_selection_functions rather than
3128 Vx_lost_selection_functions to Frun_hook_with_args.
3129
47ea7f44
PE
31302011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3131
ac389d0c 3132 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3133 The old code sometimes used this field without initializing it.
3134
47ea7f44
PE
3135 * alloc.c (gc_sweep): Don't read past end of array.
3136 In theory, the old code could also have corrupted Emacs internals,
3137 though it'd be very unlikely.
3138
bc985c87
AS
31392011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3140
3141 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3142 argument. (Bug#4026)
bc985c87 3143
0cf34688
LMI
31442011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3145
b3dadd76
LMI
3146 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3147 key" (bug#4257).
3148
0cf34688
LMI
3149 * window.c (Fset_window_start): Doc fix (bug#4199).
3150 (Fset_window_hscroll): Ditto.
3151
270768cd
PE
31522011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3153
077e3dda 3154 Fix minor new problems caught by GCC 4.6.1.
270768cd 3155 * term.c (init_tty): Remove unused local.
490011a6 3156 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3157 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3158 not used otherwise.
270768cd 3159
b1f58454
CY
31602011-07-12 Chong Yidong <cyd@stupidchicken.com>
3161
3162 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3163
22b9578d
LMI
31642011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3165
6e70ab07
LMI
3166 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3167 are the mini-buffer and the echo area (bug#3320).
3168
22b9578d
LMI
3169 * term.c (init_tty): Remove support for supdup, c10 and perq
3170 terminals, which are no longer supported (bug#1482).
3171
8974cc9f
JB
31722011-07-10 Johan Bockgård <bojohan@gnu.org>
3173
3174 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3175
a560d974
JD
31762011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3177
3178 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3179 for non-popups (Bug#3642).
3180
1dae0f0a
AS
31812011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3182
268c2c36 3183 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3184 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3185 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3186 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3187 * data.c (fmod): Likewise.
3188 * dispnew.c (swap_glyphs_in_rows): Likewise.
3189 * emacs.c (memory_warning_signal): Likewise.
3190 * floatfns.c (float_error): Likewise.
3191 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3192 (otf_open, font_otf_capability, generate_otf_features)
3193 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3194 Likewise.
3195 * image.c (pbm_read_file): Likewise.
3196 * indent.c (string_display_width): Likewise.
3197 * intervals.c (check_for_interval, search_for_interval)
3198 (inc_interval_count, count_intervals, root_interval)
3199 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3200 * lread.c (defalias): Likewise.
268c2c36 3201 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3202 * regex.c (set_image_of_range_1, set_image_of_range)
3203 (regex_grow_registers): Likewise.
3204 * sysdep.c (strerror): Likewise.
3205 * termcap.c (valid_filename_p, tprint, main): Likewise.
3206 * tparam.c (main): Likewise.
3207 * unexhp9k800.c (run_time_remap, save_data_space)
3208 (update_file_ptrs, read_header, write_header, calculate_checksum)
3209 (copy_file, copy_rest, display_header): Likewise.
3210 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3211 Likewise.
3212 * xdisp.c (check_it): Likewise.
3213 * xfaces.c (register_color, unregister_color, unregister_colors):
3214 Likewise.
3215 * xfns.c (print_fontset_result): Likewise.
3216 * xrdb.c (member, fatal, main): Likewise.
3217
99033785
PE
32182011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 Fix minor problems found by static checking (Bug#9031).
3221 * chartab.c (char_table_set_range, map_sub_char_table):
3222 Remove unused locals.
3223 (uniprop_table): Now static.
3224 * composite.c (_work_char): Remove unused static var.
3225
9cb2ac56
JB
32262011-07-09 Juanma Barranquero <lekktu@gmail.com>
3227
3228 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3229
f25661f0
JD
32302011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3231
3232 * gtkutil.c (qttip_cb): Remove code without function.
3233
8278c4fe
EZ
32342011-07-09 Eli Zaretskii <eliz@gnu.org>
3235
3236 * w32.c (pthread_sigmask): New stub.
3237
1692ae2d 32382011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3239
8a6ebd58 3240 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3241 sigprocmask is portable only for single-threaded applications, and
3242 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3243 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3244 (LIBES): Use it.
3245 * callproc.c (Fcall_process):
3246 * process.c (create_process):
3247 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3248 Use pthread_sigmask, not sigprocmask.
123403e4 3249
1b854618
JD
32502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3251
3252 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3253 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3254 wrong (Bug#8591).
3255
3fe4b549
JD
32562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3257
0ce7e563
JD
3258 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3259 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3260 (xg_hide_tooltip): Fix comment.
3261
3fe4b549
JD
3262 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3263 in registerServicesMenuSendTypes.
3264 (validRequestorForSendType): Don't check ns_return_types.
3265
3266 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3267 ns_return_type.
3268
5df75e47
JR
32692011-07-08 Jason Rumney <jasonr@gnu.org>
3270
22610910
JR
3271 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3272 SH_SHOW for hidden windows (Bug#5482).
3273
5df75e47
JR
3274 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3275 frame struct members of non-existent frames (Bug#6284).
3276
699c10bd
JD
32772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3278
4393663b
JD
3279 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3280 variable firstTime not needed on OSX >= 10.6.
3281 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3282 >= 10.5. Use setKnobProportion, setDoubleValue.
3283
3284 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3285 (MAC_OS_X_VERSION_10_5): Define if not defined.
3286 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3287 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3288 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3289
3290 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3291 cString and lossyCString on OSX >= 10.4
3292
58179cce 3293 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3294 sizeToFit on OSX >= 10.2.
3295
3296 * nsimage.m (allocInitFromFile): Don't use deprecated method
3297 bestRepresentationForDevice on OSX >= 10.6.
3298
3299 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3300 to avoid warning.
3301
3302 * emacs.c: Declare unexec_init_emacs_zone.
3303
a63e0781
JD
3304 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3305
699c10bd
JD
3306 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3307
3308 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3309 on svcsMenu (Bug#8842).
3310
3311 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3312 ns_return_types.
3313 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3314
3315 * nsterm.m (QUTF8_STRING): Declare.
3316 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3317 (validRequestorForSendType): Return type is (id).
3318 Change indexOfObjectIdenticalTo to indexOfObject.
3319 Check if we have local selection before returning self (Bug#8842).
3320 (writeSelectionToPasteboard): Put local selection into paste board
3321 if we have a local selection (Bug#8842).
3322 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3323
3324 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3325 (ns_get_local_selection): Declare.
3326
54e10184
LMI
33272011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3328
9888ff71
LMI
3329 * keymap.c (describe_map_tree): Don't insert a double newline at
3330 the end of the buffer (bug#1169) and return whether we inserted
3331 something.
3332
54e10184
LMI
3333 * callint.c (Fcall_interactively): Change "reading args" to
3334 "providing args" to try to clarify what it does (bug#1010).
3335
15fa4783
KH
33362011-07-07 Kenichi Handa <handa@m17n.org>
3337
3338 * composite.c (composition_compute_stop_pos): Ignore a static
3339 composition starting before CHARPOS (Bug#8915).
3340
3341 * xdisp.c (handle_composition_prop): Likewise.
3342
a8815b00
EZ
33432011-07-07 Eli Zaretskii <eliz@gnu.org>
3344
3345 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3346 (Bug#9015)
3347
ef7b981d 33482011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3349
3350 * character.h (unicode_category_t): New enum type.
3351
3352 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3353 (Qchar_code_property_table): New variable.
3354 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3355 (UNIPROP_COMPRESSED_FORM_P): New macros.
3356 (char_table_ascii): Uncompress the compressed values.
3357 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3358 Uncompress the compressed values.
ac389d0c 3359 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3360 (char_table_ref_and_range): Uncompress the compressed values.
3361 (sub_char_table_set): New arg is_uniprop. Callers changed.
3362 Uncompress the compressed values.
3363 (sub_char_table_set_range): Args changed. Callers changed.
3364 (char_table_set_range): Adjuted for the above change.
3365 (map_sub_char_table): Delete args default_val and parent. Add arg
3366 top. Give decoded values to a Lisp function.
640c8776 3367 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3368 values to a Lisp function. Gcpro more variables.
3369 (uniprop_table_uncompress)
3370 (uniprop_decode_value_run_length): New functions.
3371 (uniprop_decoder, uniprop_decoder_count): New variables.
3372 (uniprop_get_decoder, uniprop_encode_value_character)
3373 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3374 New functions.
3375 (uniprop_encoder, uniprop_encoder_count): New variables.
3376 (uniprop_get_encoder, uniprop_table)
3377 (Funicode_property_table_internal, Fget_unicode_property_internal)
3378 (Fput_unicode_property_internal): New functions.
3379 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3380 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3381 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3382 char-code-property-alist.
3383
640c8776 3384 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3385 Vunicode_category_table.
3386
640c8776 3387 * font.c (font_range): Adjust for the change of
c805dec0
KH
3388 Vunicode_category_table.
3389
76b397fb
DN
33902011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3391
3392 * m/iris4d.h: Remove file, move contents ...
3393 * s/irix6-5.h: ... here.
3394
22b4128e
PE
33952011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3398 * alloc.c (mark_buffer):
3399 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3400 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3401 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3402 This isn't true in general, and it's particularly not true
3403 if Emacs is configured with --with-wide-int.
3404 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3405 New macros, used in the buffer.c change.
3406
869795d6
JD
34072011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3408
3409 * xsettings.c: Use both GConf and GSettings if both are available.
3410 (store_config_changed_event): Add comment.
3411 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3412 (store_tool_bar_style_changed): New functions.
5e617bc2 3413 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3414 (struct xsettings): Move font inside HAVE_XFT.
3415 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3416 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3417 Move inside HAVE_XFT.
640c8776 3418 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3419 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3420 also.
3421 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3422 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3423 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3424 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3425 (parse_settings): Move check for font inside HAVE_XFT.
3426 (read_settings, apply_xft_settings): Add comment.
3427 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3428 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3429 call store_font_name_changed.
3430 (xft_settings_event): Add comment.
3431 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3432 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3433 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3434 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3435 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3436 (xsettings_get_system_font, xsettings_get_system_normal_font):
3437 Add comment.
869795d6 3438
d8ed26bd
PE
34392011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 Random fixes. E.g., (random) never returned negative values.
3442 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3443 subseconds part to the entropy, as that's a bit more random.
3444 Prefer signed to unsigned, since the signedness doesn't matter and
3445 in general we prefer signed. When given a limit, use a
3446 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3447 latter isn't right if USE_2_TAGS_FOR_INTS.
3448 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3449 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3450
cabf1cac
SM
34512011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3452
3453 * textprop.c (text_property_stickiness):
3454 Obey Vtext_property_default_nonsticky.
3455 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3456 * w32fns.c (syms_of_w32fns):
3457 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3458
6e9b2be9
PE
34592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3462 This is more efficient than Ffile_directory_p and avoids a minor race.
3463
90186c68
LMI
34642011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3465
7c301272
LMI
3466 * buffer.c (Foverlay_put): Say what the return value is
3467 (bug#7835).
3468
c4f2d8d4
LMI
3469 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3470 is a directory before asking whether to use the file name
3471 (bug#7564).
ad637907
LMI
3472 (barf_or_query_if_file_exists): Make the "File is a directory"
3473 error be more correct.
c4f2d8d4 3474
90186c68
LMI
3475 * fns.c (Frequire): Remove the mention of the .gz files, since
3476 that's installation-specific, but keep the mention of
3477 `get-load-suffixes'.
3478
da64016e
PE
34792011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3480
3481 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3482 Report string overflow if the output is too long.
3483
7d47b580
JB
34842011-07-04 Juanma Barranquero <lekktu@gmail.com>
3485
a555cb87
JB
3486 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3487 (syms_of_gnutls): Remove duplicate DEFSYM for
3488 Qgnutls_bootprop_verify_hostname_error, an error for
3489 Qgnutls_bootprop_verify_error (which is no longer used).
3490
7d47b580
JB
3491 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3492 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3493 Also (re)move comments that are misplaced or no longer relevant.
3494
1e49bfab
LMI
34952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3496
3497 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3498
1485f4c0
CY
34992011-07-03 Chong Yidong <cyd@stupidchicken.com>
3500
3501 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3502 and background color parameters if they have been changed.
3503
a9ab721e
LMI
35042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3505
3506 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3507
cf7cff57
PE
35082011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3509
2e13213d
PE
3510 * xsettings.c (SYSTEM_FONT): Define only when used.
3511 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3512
cf7cff57
PE
3513 * keymap.c (access_keymap_1): Now static.
3514
7a8e04f7
CY
35152011-07-02 Chong Yidong <cyd@stupidchicken.com>
3516
3517 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3518 leave any prefix arg for the up event (Bug#1586).
3519
61352f62
LMI
35202011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3521
69bb1ef7
LMI
3522 * lread.c (syms_of_lread): Mention single symbols defined by
3523 `defvar' or `defconst' (bug#7154).
3524
61352f62 3525 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3526 (Frequire): Mention get-load-suffixes.
61352f62 3527
28545e04
MR
35282011-07-02 Martin Rudalics <rudalics@gmx.at>
3529
3530 * window.h (window): Remove clone_number slot.
3531 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3532 Remove.
3533 (make_parent_window, make_window, saved_window)
3534 (Fset_window_configuration, save_window_save): Don't deal with
3535 clone numbers.
3536 * buffer.c (Qclone_number): Remove declaration.
3537 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3538
3349e122
SM
35392011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3540
3541 Add multiple inheritance to keymaps.
3542 * keymap.c (Fmake_composed_keymap): New function.
3543 (Fset_keymap_parent): Simplify.
3544 (fix_submap_inheritance): Remove.
3545 (access_keymap_1): New function extracted from access_keymap to handle
3546 embedded parents and handle lists of maps.
3547 (access_keymap): Use it.
3548 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3549 (Fcopy_keymap): Handle embedded parents.
3550 (Fcommand_remapping, define_as_prefix): Simplify.
3551 (Fkey_binding): Simplify.
3552 (syms_of_keymap): Move minibuffer-local-completion-map,
3553 minibuffer-local-filename-completion-map,
3554 minibuffer-local-must-match-map, and
3555 minibuffer-local-filename-must-match-map to Elisp.
3556 (syms_of_keymap): Defsubr make-composed-keymap.
3557 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3558 (parse_menu_item): Trivial simplification.
3559
3279eb87
GM
35602011-07-01 Glenn Morris <rgm@gnu.org>
3561
3562 * Makefile.in (SETTINGS_LIBS): Fix typo.
3563
4550efdf
KI
35642011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3565
3566 * coding.c (Fencode_coding_string): Record the last coding system
3567 used, as the function doc string says (bug#8738).
3568
0949d2b6
JD
35692011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3570
3571 * xsettings.c (store_monospaced_changed): Take new font as arg and
3572 check for change against current_mono_font.
3573 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3574 (emacs_settings_constructor, emacs_settings_get_property)
3575 (emacs_settings_set_property, emacs_settings_class_init)
3576 (emacs_settings_init, gsettings_obj): Remove.
3577 (something_changedCB): New function for HAVE_GSETTINGS.
3578 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3579 with value as argument.
3580 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3581 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3582 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3583 "changed".
3584
3585 * xgselect.c: Add defined (HAVE_GSETTINGS).
3586 (xgselect_initialize): Ditto.
3587
3588 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3589 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3590 xg_select.
3591
bbc6b304
PE
35922011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3593
3594 * eval.c (struct backtrace): Simplify and port the data structure.
3595 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3596 signed bit field, as this assumption is not portable and it makes
3597 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3598 "char debug_on_exit : 1" as this is not portable either; instead,
3599 use the portable "unsigned int debug_on_exit : 1". Remove unused
3600 member evalargs. Remove obsolete comments about cc bombing out.
3601
9851bfc5
JD
36022011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3603
51bb811f 3604 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3605 Let HAVE_GSETTINGS override HAVE_GCONF.
3606 (store_monospaced_changed): New function.
3607 (EMACS_SETTINGS): A new type derived from GObject to handle
3608 GSettings notifications.
3609 (emacs_settings_constructor, emacs_settings_get_property)
3610 (emacs_settings_set_property, emacs_settings_class_init):
3611 New functions.
3612 (gsettings_client, gsettings_obj): New variables.
3613 (GSETTINGS_SCHEMA): New define.
3614 (something_changedCB): Call store_monospaced_changed.
3615 (init_gsettings): New function.
3616 (xsettings_initialize): Call init_gsettings.
3617 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3618 to NULL.
3619
640c8776 3620 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3621 GCONF_CFLAGS/LIBS.
3622
5386012d
MR
36232011-06-29 Martin Rudalics <rudalics@gmx.at>
3624
3625 * window.c (resize_root_window, grow_mini_window)
3626 (shrink_mini_window): Rename Qresize_root_window to
3627 Qwindow_resize_root_window and Qresize_root_window_vertically to
3628 Qwindow_resize_root_window_vertically.
3629
f13e0b08
PE
36302011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3633
94515237
JB
36342011-06-27 Juanma Barranquero <lekktu@gmail.com>
3635
3636 * makefile.w32-in: Redesign dependencies so they reflect more
3637 clearly which files are directly included by each source file,
3638 and not through other includes.
3639
e43b6e43
MR
36402011-06-27 Martin Rudalics <rudalics@gmx.at>
3641
3642 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3643 (sort_overlays, overlay_strings): When an overlay's clone number
3644 matches the window's clone number process the overlay even if
3645 the overlay's window property doesn't match the current window.
3646
d68443dc
MR
3647 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3648 (Fwindow_hchild): Rename to Fwindow_left_child.
3649 (Fwindow_next): Rename to Fwindow_next_sibling.
3650 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3651 (resize_window_check): Rename to window_resize_check.
3652 (resize_window_apply): Rename to window_resize_apply.
3653 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3654 (Fdelete_other_windows_internal, resize_frame_windows)
3655 (Fsplit_window_internal, Fdelete_window_internal)
3656 (grow_mini_window, shrink_mini_window)
3657 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3658
c7e73be5
JD
36592011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3660
3661 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3662 (emacs_fixed_set_min_size): Remove.
3663 (emacs_fixed_new): Take frame as argument.
3664
3665 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3666 (_EmacsFixedPrivate): Remove minwidth/height.
3667 Add struct frame *f.
3668 (emacs_fixed_init): Initialize priv->f.
3669 (get_parent_class, emacs_fixed_set_min_size): Remove.
3670 (emacs_fixed_new): Set priv->f to argument.
3671 (emacs_fixed_get_preferred_width)
3672 (emacs_fixed_get_preferred_height): Use min_width/height from
3673 frames size_hint to set minimum and natural (Bug#8919).
3674 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3675 and use min_width/height from frames size_hint to set
3676 min_width/height (Bug#8919).
3677
3678 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3679 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3680 Fix indentation.
c7e73be5 3681
cf99dcf8
EZ
36822011-06-26 Eli Zaretskii <eliz@gnu.org>
3683
3684 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3685 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3686 called at ZV.
3687
029529ac
CY
36882011-06-26 Chong Yidong <cyd@stupidchicken.com>
3689
3690 * process.c (wait_reading_process_output): Bypass select if
3691 waiting for a cell while ignoring keyboard input, and input is
3692 pending. Suggested by Jan Djärv (Bug#8869).
3693
7a7ef429
PE
36942011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 Use gnulib's dup2 module instead of rolling our own.
3697 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3698
11fdef7d 36992011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3700
3701 * dispnew.c (scrolling_window): Before scrolling, turn off a
3702 mouse-highlight in the window being scrolled.
3703
cd3520a4
JB
37042011-06-24 Juanma Barranquero <lekktu@gmail.com>
3705
3706 Move DEFSYM to lisp.h and use everywhere.
3707
3708 * character.h (DEFSYM): Move declaration...
3709 * lisp.h (DEFSYM): ...here.
3710
3711 * gnutls.c:
3712 * minibuf.c:
3713 * w32menu.c:
3714 * w32proc.c:
3715 * w32select.c: Don't include character.h.
3716
3717 * alloc.c (syms_of_alloc):
3718 * buffer.c (syms_of_buffer):
3719 * bytecode.c (syms_of_bytecode):
3720 * callint.c (syms_of_callint):
3721 * casefiddle.c (syms_of_casefiddle):
3722 * casetab.c (init_casetab_once):
3723 * category.c (init_category_once, syms_of_category):
3724 * ccl.c (syms_of_ccl):
3725 * cmds.c (syms_of_cmds):
3726 * composite.c (syms_of_composite):
3727 * dbusbind.c (syms_of_dbusbind):
3728 * dired.c (syms_of_dired):
3729 * dispnew.c (syms_of_display):
3730 * doc.c (syms_of_doc):
3731 * editfns.c (syms_of_editfns):
3732 * emacs.c (syms_of_emacs):
3733 * eval.c (syms_of_eval):
3734 * fileio.c (syms_of_fileio):
3735 * fns.c (syms_of_fns):
3736 * frame.c (syms_of_frame):
3737 * fringe.c (syms_of_fringe):
3738 * insdel.c (syms_of_insdel):
3739 * keymap.c (syms_of_keymap):
3740 * lread.c (init_obarray, syms_of_lread):
3741 * macros.c (syms_of_macros):
3742 * msdos.c (syms_of_msdos):
3743 * print.c (syms_of_print):
3744 * process.c (syms_of_process):
3745 * search.c (syms_of_search):
3746 * sound.c (syms_of_sound):
3747 * syntax.c (init_syntax_once, syms_of_syntax):
3748 * terminal.c (syms_of_terminal):
3749 * textprop.c (syms_of_textprop):
3750 * undo.c (syms_of_undo):
3751 * w32.c (globals_of_w32):
3752 * window.c (syms_of_window):
3753 * xdisp.c (syms_of_xdisp):
3754 * xfaces.c (syms_of_xfaces):
3755 * xfns.c (syms_of_xfns):
3756 * xmenu.c (syms_of_xmenu):
3757 * xsettings.c (syms_of_xsettings):
3758 * xterm.c (syms_of_xterm): Use DEFSYM.
3759
4228cf16
TZ
37602011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3761
cd3520a4 3762 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3763
7fcccf1e
PE
37642011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3765
7efb4e0e
PE
3766 Integer and buffer overflow fixes (Bug#8873).
3767
ff5844ad
PE
3768 * print.c (printchar, strout): Check for string overflow.
3769 (PRINTPREPARE, printchar, strout):
3770 Don't set size unless allocation succeeds.
3771
90532f02
PE
3772 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3773 for sizes. Check for string overflow more accurately.
3774 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3775
6d84508d
PE
3776 * macros.c: Integer and buffer overflow fixes.
3777 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3778 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3779 Use ptrdiff_t, not int, for sizes.
3780 Don't increment bufsize until after realloc succeeds.
3781 Check for size-calculation overflow.
3782 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3783
437b2cb4
PE
3784 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3785
8b9ac8b4
PE
3786 * lread.c: Integer overflow fixes.
3787 (read_integer): Radix is now EMACS_INT, not int,
3788 to improve quality of diagnostics for out-of-range radices.
3789 Calculate buffer size correctly for out-of-range radices.
3790 (read1): Check for integer overflow in radices, and in
3791 read-circle numbers.
82cb60d3
PE
3792 (read_escape): Avoid int overflow.
3793 (Fload, openp, read_buffer_size, read1)
3794 (substitute_object_recurse, read_vector, read_list, map_obarray):
3795 Use ptrdiff_t, not int, for sizes.
3796 (read1): Use EMACS_INT, not int, for sizes.
20270765 3797 Check for size overflow.
8b9ac8b4 3798
7fcccf1e
PE
3799 * image.c (cache_image): Check for size arithmetic overflow.
3800
bfbbd7e7
PE
3801 * lread.c: Integer overflow issues.
3802 (saved_doc_string_size, saved_doc_string_length)
3803 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3804 Now ptrdiff_t, not int.
3805 (read1): Don't assume doc string length fits in int. Check for
3806 out-of-range doc string lengths.
3807 (read_list): Don't assume file position fits in int.
39019e54 3808 (read_escape): Check for hex character overflow.
bfbbd7e7 3809
4e323265
LL
38102011-06-22 Leo Liu <sdl.web@gmail.com>
3811
3812 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3813 Move to minibuffer.el.
3814
85fece3e
PE
38152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3816
20b84ce9 3817 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3818 The following patches are for when GLYPH_DEBUG && !XASSERT.
3819 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3820 * dispnew.c (flush_stdout):
3821 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3822 Mark as externally visible.
3823 * dispnew.c (check_window_matrix_pointers): Now static.
3824 * dispnew.c (window_to_frame_vpos):
3825 * xfns.c (unwind_create_frame):
3826 * xterm.c (x_check_font): Remove unused local.
3827 * scroll.c (CHECK_BOUNDS):
3828 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3829 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3830 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3831 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3832 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3833 Now static.
3834 (debug_method_add): Use va_list and vsprintf rather than relying
3835 on undefined behavior with wrong number of arguments.
3836 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3837 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3838 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3839 since we're not interested in debugging glyphs with old libraries.
3840 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3841 GCC 4.6.0's static checking.
3842
0766b489
PE
38432011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3844
31fd4b32
PE
3845 Integer overflow and signedness fixes (Bug#8873).
3846 A few related buffer overrun fixes, too.
3847
b79e8648
PE
3848 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3849
0766b489
PE
3850 * dispextern.h (struct face.stipple):
3851 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3852 (x_bitmap_mask, x_allocate_bitmap_record)
3853 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3854 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3855 (x_create_bitmap_from_xpm_data):
3856 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3857 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3858 (.bitmaps_last):
3859 * xfaces.c (load_pixmap):
3860 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3861 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3862 (.bitmaps_last, struct x_output.icon_bitmap):
3863 Use ptrdiff_t, not int, for bitmap indexes.
3864 (x_allocate_bitmap_record): Check for size overflow.
3865 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3866
b081724f
PE
3867 Use ptrdiff_t, not int, for overlay counts.
3868 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3869 * editfns.c (overlays_around, get_pos_property):
3870 * textprop.c (get_char_property_and_overlay):
3871 * xdisp.c (next_overlay_change, note_mouse_highlight):
3872 * xfaces.c (face_at_buffer_position):
21514da7
PE
3873 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3874 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3875 (Fnext_overlay_change, Fprevious_overlay_change)
3876 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3877 Use ptrdiff_t, not int, for sizes.
21514da7 3878 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3879
3de73e5e
PE
3880 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3881
2606c57b
PE
3882 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3883 (x_session_initialize): Do not assume string length fits in int.
3884
aaafe47a
PE
3885 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3886 This is unlikely, but can occur if DPI is outlandish.
3887
2674ddc8 3888 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3889 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3890
28154962
PE
3891 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3892 * xrdb.c (magic_file_p, search_magic_path):
3893 Omit last arg SUFFIX; it was always 0. All callers changed.
3894 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3895
7de51af5
PE
3896 * xfont.c (xfont_match): Avoid need for strlen.
3897
25ed6cc3
PE
3898 * xfns.c: Don't assume strlen fits in int.
3899 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3900
4eab31dd
PE
3901 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3902 not unsigned long, as we prefer signed integers. All callers changed.
3903 Detect integer overflow in repeat count.
3904 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3905 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3906
171e2a58
PE
3907 * termcap.c: Don't assume sizes fit in int and never overflow.
3908 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3909 (gobble_line): Check for size-calculation overflow.
3910
ad39faca 3911 * minibuf.c (Fread_buffer):
6e5bb2dc 3912 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3913 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3914 Don't assume string length fits in int.
3915
52c61c22 3916 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3917 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3918
b5b8c9e5
PE
3919 * font.c: Don't assume string length fits in int.
3920 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3921 Use ptrdiff_t, not int.
ccd6111c
PE
3922 (font_intern_prop): Don't assume string length fits in int.
3923 Don't assume integer property fits in fixnum.
3924 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3925
882f0d81 3926 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3927 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3928 Reformulate so as not to need the command string.
3929 Invoke gzip -cd rather than gunzip, as it's more portable.
3930 (lock_info_type, lock_file_1, lock_file):
3931 Don't assume pid_t and time_t fit in unsigned long.
3932 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3933 (current_lock_owner): Prefer signed type for sizes.
3934 Use memcpy, not strncpy, where memcpy is what is really wanted.
3935 Don't assume (via atoi) that time_t and pid_t fit in int.
3936 Check for time_t and/or pid_t out of range, e.g., via a network share.
3937 Don't alloca where an auto var works fine.
3938
93f4cf88
PE
3939 * fileio.c: Fix some integer overflow issues.
3940 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3941 Don't assume string length fits in int.
3942 (directory_file_name): Don't assume string length fits in long.
3943 (make_temp_name): Don't assume pid fits in int, or that its print
3944 length is less than 20.
3945
f3e92b69
PE
3946 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3947
1bfdaf10
PE
3948 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3949
35016e9a
PE
3950 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3951
3d1e65a1
PE
3952 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3953 We prefer signed integers, even for size calculations.
3954
0b963a93
PE
3955 * emacs.c: Don't assume string length fits in 'int'.
3956 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3957 (main): Don't invoke strlen when not needed.
3958
573f4b54
PE
3959 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3960 (XD_DEBUG_MESSAGE): Don't waste a byte.
3961
989f33ba
PE
3962 * callproc.c (getenv_internal_1, getenv_internal)
3963 (Fgetenv_internal):
965d34eb
PE
3964 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3965
e4d29b33
PE
3966 * lread.c (invalid_syntax): Omit length argument.
3967 All uses changed. This doesn't fix a bug, but it simplifies the
3968 code away from its former Hollerith-constant appearance, and it's
3969 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3970 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3971
eb49b136
PE
3972 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3973 This didn't break anything, but it didn't help either.
3974 It's confusing to put a bogus integer in a place where the actual
3975 value does not matter.
9f62aeb1 3976 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3977 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3978
15375a22
PE
3979 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3980 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3981 implementation.
b61cc01c
PE
3982 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3983 We prefer signed types, and the value cannot exceed the EMACS_INT
3984 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3985 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3986 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3987 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3988
53b2623d
PE
3989 * indent.c (sane_tab_width): New function.
3990 (current_column, scan_for_column, Findent_to, position_indentation)
3991 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3992 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3993
51cab52b 3994 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3995
f2ed8a70
PE
3996 * lisp.h (lint_assume): New macro.
3997 * composite.c (composition_gstring_put_cache):
3998 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3999
abe80cc6
PE
4000 * editfns.c, insdel.c:
4001 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4002
b02c740e
PE
4003 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4004
ebc96716
PE
4005 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4006
b4e50fa0 4007 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4008 Use much-faster test for byte-length change.
311d5d7c 4009 Don't assume string byte-length fits in 'int'.
a4cf38e4 4010 Check that character arg fits in 'int'.
85461888 4011 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4012
c0c1ee9f
PE
4013 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4014
a498d7f4
PE
4015 * fns.c (concat): Catch string overflow earlier.
4016 Do not rely on integer wraparound.
4017
51cab52b
PE
4018 * dispextern.h (struct it.overlay_strings_charpos)
4019 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4020 * xdisp.c (forward_to_next_line_start)
4021 (back_to_previous_visible_line_start)
4022 (reseat_at_next_visible_line_start, next_element_from_buffer):
4023 Don't arbitrarily truncate the value of 'selective' to int.
4024
76031fad
PE
4025 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4026
5eb55db9
PE
4027 * composite.c: Don't truncate sizes to 'int'.
4028 (composition_gstring_p, composition_reseat_it)
4029 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4030 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4031 not EMACS_UINT, for indexes.
5eb55db9 4032
0703a717
PE
4033 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4034
d6202519
PE
4035 * buffer.c: Include <verify.h>.
4036 (struct sortvec.priority, struct sortstr.priority):
8961a454 4037 Now EMACS_INT, not int.
c20998a7 4038 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4039 (struct sortstr.size, record_overlay_string)
4040 (struct sortstrlist.size, struct sortlist.used):
4041 Don't truncate size to int.
4042 (record_overlay_string): Check for size-calculation overflow.
d6202519 4043 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4044
d5a19415
JM
40452011-06-22 Jim Meyering <meyering@redhat.com>
4046
029529ac 4047 Don't leak an XBM-image-sized buffer
d5a19415
JM
4048 * image.c (xbm_load): Free the image buffer after using it.
4049
a9041e6c
PE
40502011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4051
4052 Port to Sun C.
4053 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4054 that Sun C diagnosed.
4055 * fns.c (secure_hash): Fix pointer signedness issue.
4056 * intervals.c (static_offset_intervals): New function.
4057 (offset_intervals): Use it.
4058
7f3f739f
LL
40592011-06-21 Leo Liu <sdl.web@gmail.com>
4060
4061 * deps.mk (fns.o):
4062 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4063 sha512.h.
4064
4065 * fns.c (secure_hash): Rename from crypto_hash_function and change
4066 the first arg to accept symbols.
5b66d427 4067 (Fsecure_hash): New primitive.
7f3f739f
LL
4068 (syms_of_fns): New symbols.
4069
76147d94
DD
40702011-06-20 Deniz Dogan <deniz@dogan.se>
4071
4072 * process.c (Fset_process_buffer): Clarify return value in
4073 docstring.
4074
7d7d0045
CY
40752011-06-18 Chong Yidong <cyd@stupidchicken.com>
4076
4077 * dispnew.c (add_window_display_history): Use BVAR.
4078
4079 * xdisp.c (debug_method_add): Use BVAR.
4080 (check_window_end, dump_glyph_matrix, dump_glyph)
4081 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4082
4083 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4084 Likewise.
4085
4086 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4087 check till after the cache is created in init_frame_faces.
4088
ff2bc410
SM
40892011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4090
4091 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4092
28177add
PE
40932011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4094
dd3482fe
PE
4095 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4096 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4097 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4098
393d71f3 4099 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4100 * fileio.c (Finsert_file_contents):
4101 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4102 Remove the old (too-loose) buffer overflow checks.
4103 They weren't needed, since make_gap checks for buffer overflow.
4104 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4105 The old code merely checked for Emacs fixnum overflow, and relied
4106 on undefined (wraparound) behavior. The new code avoids undefined
4107 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4108
2e6813b0 4109 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4110 Tune. Don't use wider integers than needed. Don't use alloca.
4111 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4112
599a9e4f
PE
4113 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4114
99561444
PE
4115 * insdel.c, lisp.h (buffer_overflow): New function.
4116 (insert_from_buffer_1, replace_range, replace_range_2):
4117 * insdel.c (make_gap_larger):
4118 * editfns.c (Finsert_char):
4119 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4120
28177add
PE
4121 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4122
e69dafad
PE
41232011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4124
a7af7fde 4125 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4126
b1c46f02
PE
4127 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4128 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4129
e69dafad
PE
4130 * fileio.c: Don't assume EMACS_INT fits in off_t.
4131 (emacs_lseek): New static function.
4132 (Finsert_file_contents, Fwrite_region): Use it.
4133 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4134
566684ea
PE
4135 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4136
e6966cd6
PE
4137 * fns.c: Don't overflow int when computing a list length.
4138 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4139 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4140 truncation on 64-bit hosts. Check for QUIT every
4141 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4142 faster and is responsive enough.
4143 (Flength): Report an error instead of overflowing an integer.
4144 (Fsafe_length): Return a float if the value is not representable
4145 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4146 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4147 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4148
dd0b0efb
PE
4149 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4150 (header_size, word_size): New constants.
4151 (allocate_vectorlike): Don't check size overflow here.
4152 (allocate_vector): Check it here instead, since this is the only
4153 caller of allocate_vectorlike that could cause overflow.
4154 Check that the new vector's length is representable as a fixnum.
4155
86fe5cfe
PE
4156 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4157 The previous code was bogus. For example, next_almost_prime (32)
4158 returned 39, which is undesirable as it is a multiple of 3; and
4159 next_almost_prime (24) returned 25, which is a multiple of 5 so
4160 why was the code bothering to check for multiples of 7?
4161
80e88859
PE
4162 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4163
4a2f0ad6
PE
4164 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4165
f66c7cf8
PE
4166 Variadic C functions now count arguments with ptrdiff_t.
4167 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4168 Back then I didn't know that the Emacs coding style prefers signed int.
4169 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4170 were being counted with int, which may truncate counts on 64-bit
4171 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4172 * lisp.h (struct Lisp_Subr.function.aMANY)
4173 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4174 Arg counts are now ptrdiff_t, not size_t.
4175 All variadic functions and their callers changed accordingly.
4176 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4177 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4178 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4179 * callint.c (Fcall_interactively): Check arg count for overflow,
4180 to avoid potential buffer overrun. Use signed char, not 'int',
4181 for 'varies' array, so that we needn't bother to check its size
4182 calculation for overflow.
4183 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4184 * eval.c (apply_lambda):
4185 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4186 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4187 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4188
a1759b76
PE
4189 * callint.c (Fcall_interactively): Don't use index var as event count.
4190
d96be9fc
PE
4191 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4192 * mem-limits.h (SIZE): Remove; no longer used.
4193
a690a978 4194 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4195
578c21e6
PE
4196 Remove unnecessary casts.
4197 * xterm.c (x_term_init):
4198 * xfns.c (x_set_border_pixel):
4199 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4200 These aren't needed now that we assume ANSI C.
4201
96f53c6c
PE
4202 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4203 It's more likely to cause problems (due to unsigned overflow)
4204 than to cure them.
4205
83c77d31
PE
4206 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4207
ee2079f1
PE
4208 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4209
6da65536
PE
4210 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4211
7147c4a4
PE
4212 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4213
193e32d9
PE
4214 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4215
e5533da6
PE
4216 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4217
9910e595
PE
4218 GLYPH_CODE_FACE returns EMACS_INT, not int.
4219 * dispextern.h (merge_faces):
4220 * xfaces.c (merge_faces):
01103c44
PE
4221 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4222 Don't assume EMACS_INT fits in int.
9910e595 4223
2638320e
PE
4224 * character.h (CHAR_VALID_P): Remove unused parameter.
4225 * fontset.c, lisp.h, xdisp.c: All uses changed.
4226
045eb8d9
PE
4227 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4228
c1f134b5
PE
4229 * fns.c (concat): Minor tuning based on overflow analysis.
4230 This doesn't fix any bugs. Use int to hold character, instead
4231 of constantly refetching from Emacs object. Use XFASTINT, not
4232 XINT, for value known to be a character. Don't bother comparing
4233 a single byte to 0400, as it's always less.
4234
395fcb93 4235 * floatfns.c (Fexpt):
327eeec8
PE
4236 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4237
abbd3d23
PE
4238 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4239 for characters.
4240
684a03ef
PE
4241 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4242
0fed43f3
PE
4243 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4244 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4245 incorrectly succeed when S was a string, because 4294967386 was
4246 truncated before it was used.
4247
8fd02eb7
PE
4248 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4249 Otherwise, an out-of-range integer could cause undefined behavior
4250 on a 64-bit host.
4251
f8c86b69
PE
4252 * composite.c: Use int, not EMACS_INT, for characters.
4253 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4254 EMACS_INT, for values that are known to be in character range.
4255 This doesn't fix any bugs but is the usual style inside Emacs and
4256 may generate better code on 32-bit machines.
4257
34206dd2
PE
4258 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4259 This is for reasons similar to the recent CHAR_STRING fix.
4260 * charset.c (Fencode_char): Check that character arg is actually
4261 a character. Pass an int to ENCODE_CHAR.
4262 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4263 wider than 'int', as a compile-time check to prevent future regressions
4264 in this area.
4265
c5958d4c 4266 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4267
4268 Make sure a 64-bit char is never passed to CHAR_STRING.
4269 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4270 by silently ignoring the top 32 bits, allowing some values
4271 that were far too large to be valid characters.
4272 * character.h: Include <verify.h>.
4273 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4274 arguments are no wider than unsigned, as a compile-time check
4275 to prevent future regressions in this area.
4276 * data.c (Faset):
01103c44 4277 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4278 (Fsubst_char_in_region):
4279 * fns.c (concat):
4280 * xdisp.c (decode_mode_spec_coding):
4281 Adjust to CHAR_STRING's new requirement.
4282 * editfns.c (Finsert_char, Fsubst_char_in_region):
4283 * fns.c (concat): Check that character args are actually
4284 characters. Without this test, these functions did the wrong
4285 thing with wildly out-of-range values on 64-bit hosts.
4286
d37ca623
PE
4287 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4288 These casts should not be needed on 32-bit hosts, either.
4289 * keyboard.c (read_char):
4290 * lread.c (Fload): Remove casts to unsigned.
4291
ea204efb
PE
4292 * lisp.h (UNSIGNED_CMP): New macro.
4293 This fixes comparison bugs on 64-bit hosts.
4294 (ASCII_CHAR_P): Use it.
4295 * casefiddle.c (casify_object):
01103c44 4296 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4297 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4298 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4299 * dispextern.h (FACE_FROM_ID):
4300 * keyboard.c (read_char): Use UNSIGNED_CMP.
4301
41cb286c
PE
4302 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4303 not to EMACS_INT, to avoid GCC warning.
4304
4a1b9832
PE
4305 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4306
55daad71
PE
4307 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4308 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4309 isn't needed on 32-bit machines.
8f95c75c 4310
01103c44
PE
4311 * buffer.c (Fgenerate_new_buffer_name):
4312 Use EMACS_INT for count, not int.
0ceccced 4313 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4314
4315 * data.c (Qcompiled_function): Now static.
4316
c6f072e7
PE
4317 * window.c (window_body_lines): Now static.
4318
20ce5912
PE
4319 * image.c (gif_load): Rename local to avoid shadowing.
4320
9c4c5f81
PE
4321 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4322 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4323 * alloc.c (make_save_value): Integer argument is now of type
4324 ptrdiff_t, not int.
4325 (mark_object): Use ptrdiff_t, not int.
4326 * lisp.h (pD): New macro.
4327 * print.c (print_object): Use it.
4328
c0c5c8ae
PE
4329 * alloc.c: Use EMACS_INT, not int, to count objects.
4330 (total_conses, total_markers, total_symbols, total_vector_size)
4331 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4332 (total_free_floats, total_floats, total_free_intervals)
4333 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4334 Now EMACS_INT, not int. All uses changed.
4335 (Fgarbage_collect): Compute overall total using a double, so that
4336 integer overflow is less likely to be a problem. Check for overflow
4337 when converting back to an integer.
5a25e253
PE
4338 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4339 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4340 These were 'int' variables that could overflow on 64-bit hosts;
4341 they were never used, so remove them instead of repairing them.
211a0b2a 4342 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4343 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4344 Previously, this ceilinged at INT_MAX, but that doesn't work on
4345 64-bit machines.
e46bb31a 4346 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4347
c78baabf 4348 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4349 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4350 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4351 when a (possibly-narrower) signed value would do just as well.
4352 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4353
c9d624c6
PE
4354 * alloc.c: Catch some string size overflows that we were missing.
4355 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4356 for convenience in STRING_BYTES_MAX.
4357 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4358 The definition here is exact; the one in lisp.h was approximate.
4359 (allocate_string_data): Check for string overflow. This catches
4360 some instances we weren't catching before. Also, it catches
4361 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4362 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4363 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4364
c9d624c6
PE
4365 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4366 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4367 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4368
353032ce
PE
4369 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4370
2bccce07
PE
4371 * alloc.c (Fmake_string): Check for out-of-range init.
4372
0ac30604
SM
43732011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4374
4375 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4376
c195f2de
JD
43772011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4378
4379 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4380 xg_get_default_scrollbar_width.
4381
4382 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4383 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4384 (style_changed_cb): Call update_theme_scrollbar_width and call
4385 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4386 all frames (Bug#8505).
4387 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4388 Call gtk_window_set_resizable if HAVE_GTK3.
4389 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4390 and height if HAVE_GTK3 (Bug#8505).
4391 (scroll_bar_width_for_theme): New variable.
4392 (update_theme_scrollbar_width): New function.
4393 (xg_get_default_scrollbar_width): Move code to
4394 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4395 (xg_initialize): Call update_theme_scrollbar_width.
4396
4397 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4398
4399 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4400
e10ac9f1
MR
44012011-06-12 Martin Rudalics <rudalics@gmx.at>
4402
4403 * frame.c (make_frame): Call other_buffer_safely instead of
4404 other_buffer.
4405
4406 * window.c (temp_output_buffer_show): Call display_buffer with
4407 second argument Vtemp_buffer_show_specifiers and reset latter
4408 immediately after the call.
4409 (Vtemp_buffer_show_specifiers): New variable.
4410 (auto_window_vscroll_p, next_screen_context_lines)
4411 (Vscroll_preserve_screen_position): Remove leading asterisks from
4412 doc-strings.
4413
2d3c217e 44142011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4415
7b7f97e8 4416 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4417 * buffer.c (Qclone_number): Remove for now, as it's unused.
4418 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4419 (record_buffer): Remove unused local.
4420 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4421 (set_frame_buffer_list): Remove; unused.
4422 * frame.h (other_visible_frames): Remove decl.
4423 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4424 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4425 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4426 if HAVE_GPM.
4427 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4428 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4429 Define only if HAVE_GPM.
4430 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4431 (update_hints_inhibit): Remove; never set. All uses removed.
4432 * widgetprv.h (emacsFrameClassRec): Remove decl.
4433 * window.c (delete_deletable_window): Now returns void, since it
4434 wasn't returning anything.
4435 (compare_window_configurations): Remove unused locals.
4436 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4437 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4438 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4439 the same widths as pointers. This follows up on the 2011-05-06 patch.
4440 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4441 * xterm.h: Likewise.
4442 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4443
1384b89e
JB
44442011-06-12 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * makefile.w32-in: Update dependencies.
4447 (LISP_H): Add lib/intprops.h.
4448
1100a63c
CY
44492011-06-11 Chong Yidong <cyd@stupidchicken.com>
4450
4451 * image.c (gif_load): Add animation frame delay to the metadata.
4452 (syms_of_image): Use DEFSYM. New symbol `delay'.
4453
6198ccd0
MR
44542011-06-11 Martin Rudalics <rudalics@gmx.at>
4455
4456 * window.c (delete_deletable_window): Re-add.
4457 (Fset_window_configuration): Rewrite to handle dead buffers and
4458 consequently deletable windows.
4459 (window_tree, Fwindow_tree): Remove. Supply functionality in
4460 window.el.
4461 (compare_window_configurations): Simplify code.
4462
b6e3633c
AS
44632011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4464
1ab0dee5
AS
4465 * image.c (imagemagick_load_image): Fix type mismatch.
4466 (Fimagemagick_types): Likewise.
4467
b6e3633c
AS
4468 * window.h (replace_buffer_in_windows): Declare.
4469
9397e56f
MR
44702011-06-11 Martin Rudalics <rudalics@gmx.at>
4471
4472 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4473 Qclone_number. Remove external declaration of Qdelete_window.
4474 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4475 code.
640c8776
SM
4476 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4477 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4478 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4479 buffer list implementation.
4480 (other_buffer_safely): New function.
4481 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4482 calls to replace_buffer_in_windows and
4483 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4484 if allowed.
4485 (record_buffer): Inhibit quitting and rewrite using quittable
4486 functions. Run Qbuffer_list_update_hook if allowed.
4487 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4488 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4489 Move switch-to-buffer to window.el.
9397e56f
MR
4490 (bury-buffer): Move to window.el.
4491 (Vbuffer_list_update_hook): New variable.
4492
4493 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4494 section.
4495
4496 * window.h (resize_frame_windows): Move up in code.
4497 (Fwindow_frame): Remove EXFUN.
4498 (replace_buffer_in_all_windows): Remove prototype.
4499 (replace_buffer_in_windows_safely): Add prototype.
4500
4501 * window.c: Declare Qdelete_window static again. Move down
4502 declaration of select_count.
4503 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4504 (Fother_window): Move to window.el.
4505 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4506 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4507 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4508 window.el.
4509 (replace_buffer_in_windows): Implement by calling
4510 Qreplace_buffer_in_windows.
4511 (replace_buffer_in_all_windows): Remove with some functionality
4512 moved into replace_buffer_in_windows_safely.
4513 (replace_buffer_in_windows_safely): New function.
4514 (select_window_norecord, select_frame_norecord): Move in front
4515 of run_window_configuration_change_hook. Remove now obsolete
4516 declarations.
640c8776
SM
4517 (Fset_window_buffer): Rewrite doc-string.
4518 Call Qrecord_window_buffer.
9397e56f
MR
4519 (keys_of_window): Move binding for other-window to window.el.
4520
b50691aa
CY
45212011-06-11 Chong Yidong <cyd@stupidchicken.com>
4522
4523 * dispextern.h (struct image): Replace data member, whose int_val
4524 and ptr_val fields were not used by anything, with a single
4525 lisp_val object.
4526
4527 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4528 (gif_clear_image, gif_load, imagemagick_load_image)
4529 (gs_clear_image, gs_load): Callers changed.
4530
3f754b86
PE
45312011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4532
cca69397
PE
4533 * buffer.h: Include <time.h>, for time_t.
4534 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4535
109e28d0
PE
4536 Fix minor problems found by static checking.
4537
60737f02
PE
4538 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4539
4b66faf3
PE
4540 Make identifiers static if they are not used in other modules.
4541 * data.c (Qcompiled_function, Qframe, Qvector):
4542 * image.c (QimageMagick, Qsvg):
4543 * minibuf.c (Qmetadata):
4544 * window.c (resize_window_check, resize_root_window): Now static.
4545 * window.h (resize_window_check, resize_root_window): Remove decls.
4546
109e28d0
PE
4547 * window.c (window_deletion_count, delete_deletable_window):
4548 Remove; unused.
46a4ce9e
PE
4549 (window_body_lines): Now static.
4550 (Fdelete_other_windows_internal): Mark vars as initialized.
4551 Make sure 'resize_failed' is initialized.
4552 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4553 (resize_window_apply): Remove unused local.
4554 * window.h (delete_deletable_window): Remove decl.
4555
109e28d0 4556 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4557 (imagemagick_load_image): Fix pointer signedness problem by changing
4558 last arg from unsigned char * to char *. All uses changed.
4559 Also, fix a local for similar reasons.
4560 Remove unused locals. Remove locals to avoid shadowing.
4561 (fn_rsvg_handle_free): Remove; unused.
4562 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4563 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4564
3f754b86
PE
4565 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4566
2547adb1
CY
45672011-06-10 Chong Yidong <cyd@stupidchicken.com>
4568
4569 * image.c (gif_load): Fix omitted cast error introduced by
4570 2011-06-06 change.
4571
2c8e37d4
MR
45722011-06-10 Martin Rudalics <rudalics@gmx.at>
4573
4574 * window.h (resize_proportionally, orig_total_lines)
4575 (orig_top_line): Remove from window structure.
4576 (set_window_height, set_window_width, change_window_heights)
4577 (Fdelete_window): Remove prototypes.
4578 (resize_frame_windows): Remove duplicate declaration.
4579
440a42e3
EZ
45802011-06-10 Eli Zaretskii <eliz@gnu.org>
4581
4582 * window.h (resize_frame_windows, resize_window_check)
4583 (delete_deletable_window, resize_root_window)
4584 (resize_frame_windows): Declare prototypes.
4585
4586 * window.c (resize_window_apply): Make definition be "static" to
4587 match the prototype.
4588
562dd5e9
MR
45892011-06-10 Martin Rudalics <rudalics@gmx.at>
4590
4591 * window.c: Remove declarations of Qwindow_size_fixed,
4592 window_min_size_1, window_min_size_2, window_min_size,
4593 size_window, window_fixed_size_p, enlarge_window, delete_window.
4594 Remove static from declaration of Qdelete_window, it's
4595 temporarily needed by Fbury_buffer.
4596 (replace_window): Don't assign orig_top_line and
4597 orig_total_lines.
4598 (Fdelete_window, delete_window): Remove. Window deletion is
4599 handled by window.el.
640c8776
SM
4600 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4601 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4602 (Fdelete_other_windows): Remove. Deleting other windows is
4603 handled by window.el.
4604 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4605 handled in window.el.
4606 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4607 Window minimum sizes are handled in window.el.
4608 (shrink_windows, size_window, set_window_height)
4609 (set_window_width, change_window_heights, window_height)
4610 (window_width, CURBEG, CURSIZE, enlarge_window)
4611 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4612 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4613 handled in window.el.
4614 (make_dummy_parent): Rename to make_parent_window and give it a
4615 second argument horflag.
4616 (make_window): Don't set resize_proportionally any more.
4617 (Fsplit_window): Remove. Windows are split in window.el.
4618 (save_restore_action, save_restore_orig_size)
4619 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4620 Resize mini windows in window.el.
4621 (grow_mini_window, shrink_mini_window): Implement by calling
4622 Qresize_root_window_vertically, resize_window_check and
4623 resize_window_apply.
640c8776
SM
4624 (saved_window, Fset_window_configuration, save_window_save):
4625 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4626 resize_proportionally.
4627 (window_min_height, window_min_width): Move to window.el.
4628 (keys_of_window): Move bindings for delete-other-windows,
4629 split-window, delete-window and enlarge-window to window.el.
4630
4631 * buffer.c: Temporarily extern Qdelete_window.
4632 (Fbury_buffer): Temporarily call Qdelete_window instead of
4633 Fdelete_window (Fbury_buffer will move to window.el soon).
4634
4635 * frame.c (set_menu_bar_lines_1): Remove code handling
4636 orig_top_line and orig_total_lines.
4637
4638 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4639 set_window_height but set heights directly.
4640 (change_frame_size_1): Use resize_frame_windows.
4641
4642 * xdisp.c (init_xdisp): Don't use set_window_height but set
4643 heights directly.
4644
640c8776
SM
4645 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4646 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4647 run_window_configuration_change_hook.
4648
4649 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4650 instead of change_window_heights and run
4651 run_window_configuration_change_hook.
4652
1a13852e
MR
46532011-06-09 Martin Rudalics <rudalics@gmx.at>
4654
4655 * window.c (replace_window): Rename second argument REPLACEMENT to
4656 NEW. New third argument SETFLAG. Rewrite.
4657 (delete_window, make_dummy_parent): Call replace_window with
4658 third argument 1.
4659 (window_list_1): Move down in code.
4660 (run_window_configuration_change_hook): Move set_buffer part
4661 before select_frame_norecord part in order to unwind correctly.
4662 Rename count1 to count.
4663 (recombine_windows, delete_deletable_window, resize_root_window)
4664 (Fdelete_other_windows_internal)
4665 (Frun_window_configuration_change_hook, make_parent_window)
4666 (resize_window_check, resize_window_apply, Fresize_window_apply)
4667 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4668 (Fdelete_window_internal, Fresize_mini_window_internal):
4669 New functions.
1a13852e
MR
4670 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4671
f3d1777e
MR
46722011-06-08 Martin Rudalics <rudalics@gmx.at>
4673
496e208e
MR
4674 * window.h (window): Add some new members to window structure -
4675 normal_lines, normal_cols, new_total, new_normal, clone_number,
4676 splits, nest, prev_buffers, next_buffers.
4677 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4678 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4679
f3d1777e
MR
4680 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4681 Remove.
496e208e
MR
4682 (make_dummy_parent): Set new members of windows structure.
4683 (make_window): Move down in code. Handle new members of window
4684 structure.
4685 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4686 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4687 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4688 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4689 (Fset_window_next_buffers, Fset_window_clone_number):
4690 New functions.
496e208e
MR
4691 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4692 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4693 Doc-string fixes.
4694 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4695 Argument WINDOW can be now internal window too.
4696 (Fwindow_use_time): Move up in code.
4697 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4698 Rewrite doc-string.
4699 (Fset_window_configuration, saved_window)
4700 (Fcurrent_window_configuration, save_window_save): Handle new
4701 members of window structure.
b9e809c2
MR
4702 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4703 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4704 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4705 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4706 Qget_mru_window, Qresize_root_window,
4707 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4708 Qauto_buffer_name; staticpro them.
f3d1777e 4709
abde8f8c
MR
47102011-06-07 Martin Rudalics <rudalics@gmx.at>
4711
4712 * window.c (Fwindow_total_size, Fwindow_left_column)
4713 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4714 (Fwindow_list_1): New functions.
4715 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4716 (Fwindow_width, Fscroll_left, Fscroll_right):
4717 Use window_body_cols instead of window_box_text_cols.
4718 (delete_window, Fset_window_configuration):
4719 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4720 (delete_all_subwindows): Take a window as argument and not a
4721 structure. Rewrite.
190b47e6
MR
4722 (window_loop): Remove handling of GET_LRU_WINDOW and
4723 GET_LARGEST_WINDOW.
4724 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4725
4726 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4727 window_box_text_cols. delete_all_subwindows now takes a
4728 Lisp_Object as argument.
abde8f8c 4729
640c8776
SM
4730 * indent.c (compute_motion, Fcompute_motion):
4731 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4732
fa8a67e6
MR
4733 * frame.c (delete_frame): Call delete_all_subwindows with root
4734 window as argument.
4735
a54e3482
DC
47362011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4737
4738 * fns.c (Fputhash): Document return value.
4739
60002bf5
CY
47402011-06-06 Chong Yidong <cyd@stupidchicken.com>
4741
4742 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4743
0c671da6 47442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4745
b862a52a 4746 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4747
be44ca6c
PE
4748 Check for overflow when converting integer to cons and back.
4749 * charset.c (Fdefine_charset_internal, Fdecode_char):
4750 Use cons_to_unsigned to catch overflow.
4751 (Fencode_char): Use INTEGER_TO_CONS.
4752 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4753 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4754 * data.c (long_to_cons, cons_to_long): Remove.
4755 (cons_to_unsigned, cons_to_signed): New functions.
4756 These signal an error for invalid or out-of-range values.
4757 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4758 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4759 * font.c (Ffont_variation_glyphs):
4760 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4761 * lisp.h: Include <intprops.h>.
4762 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4763 (cons_to_signed, cons_to_unsigned): New decls.
4764 (long_to_cons, cons_to_long): Remove decls.
4765 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4766 (Fprimitive_undo): Use CONS_TO_INTEGER.
4767 * xfns.c (Fx_window_property): Likewise.
4768 * xselect.c: Include <limits.h>.
4769 (x_own_selection, selection_data_to_lisp_data):
4770 Use INTEGER_TO_CONS.
4771 (x_handle_selection_request, x_handle_selection_clear)
4772 (x_get_foreign_selection, Fx_disown_selection_internal)
4773 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4774 (lisp_data_to_selection_data): Use cons_to_unsigned.
4775 (x_fill_property_data): Use cons_to_signed.
4776 Report values out of range.
4777
d1f3d2af
PE
4778 Check for buffer and string overflow more precisely.
4779 * buffer.h (BUF_BYTES_MAX): New macro.
4780 * lisp.h (STRING_BYTES_MAX): New macro.
4781 * alloc.c (Fmake_string):
4782 * character.c (string_escape_byte8):
4783 * coding.c (coding_alloc_by_realloc):
4784 * doprnt.c (doprnt):
4785 * editfns.c (Fformat):
4786 * eval.c (verror):
4787 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4788 since they may not be the same number.
4789 * editfns.c (Finsert_char):
4790 * fileio.c (Finsert_file_contents):
4791 Likewise for BUF_BYTES_MAX.
4792
dd52fcea
PE
4793 * image.c: Use ptrdiff_t, not int, for sizes.
4794 (slurp_file): Switch from int to ptrdiff_t.
4795 All uses changed.
4796 (slurp_file): Check that file size fits in both size_t (for
4797 malloc) and ptrdiff_t (for sanity and safety).
4798
7f9bbdbb
PE
4799 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4800 if b->modtime has its maximal value.
4801
dfe18f82
PE
4802 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4803
84acfcf0
PE
4804 Don't assume time_t can fit into int.
4805 * buffer.h (struct buffer.modtime): Now time_t, not int.
4806 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4807 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4808
ccd9a01a
PE
4809 Minor fixes for signed vs unsigned integers.
4810 * character.h (MAYBE_UNIFY_CHAR):
4811 * charset.c (maybe_unify_char):
4812 * keyboard.c (read_char, reorder_modifiers):
4813 XINT -> XFASTINT, since the integer must be nonnegative.
4814 * ftfont.c (ftfont_spec_pattern):
4815 * keymap.c (access_keymap, silly_event_symbol_error):
4816 XUINT -> XFASTINT, since the integer must be nonnegative.
4817 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4818 since it makes no difference and we prefer signed.
4819 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4820 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4821 nonnegative.
4822
d6d100dd
SM
48232011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4824
4825 * window.h (Fwindow_frame): Declare.
4826
2b6148e4
PE
48272011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4828
4829 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4830 (SPARE_MEMORY): Always define.
4831 (LARGE_REQUEST): Remove.
4832 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4833
f230ecc9
MR
48342011-06-06 Martin Rudalics <rudalics@gmx.at>
4835
727e958e
MR
4836 * lisp.h: Move EXFUNS for Fframe_root_window,
4837 Fframe_first_window and Fset_frame_selected_window to window.h.
4838
4839 * window.h: Move EXFUNS for Fframe_root_window,
4840 Fframe_first_window and Fset_frame_selected_window here from
4841 lisp.h.
4842
4843 * frame.c (Fwindow_frame, Fframe_first_window)
4844 (Fframe_root_window, Fframe_selected_window)
4845 (Fset_frame_selected_window): Move to window.c.
4846 (Factive_minibuffer_window): Move to minibuf.c.
4847 (Fother_visible_frames_p): New function.
4848
4849 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4850
f230ecc9
MR
4851 * window.c (decode_window, decode_any_window): Move up in code.
4852 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4853 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4854 (Fwindow_buffer): Move up and rewrite doc-string.
4855 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4856 (Fwindow_prev): New functions.
727e958e
MR
4857 (Fwindow_frame): Move here from frame.c. Accept any window as
4858 argument.
4859 (Fframe_root_window, Fframe_first_window)
4860 (Fframe_selected_window): Move here from frame.c. Accept frame
4861 or arbitrary window as argument. Update doc-strings.
4862 (Fminibuffer_window): Move up in code.
4863 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4864 (Fset_frame_selected_window): Move here from frame.c.
4865 Marginal rewrite.
727e958e
MR
4866 (Fselected_window, select_window, Fselect_window): Move up in
4867 code. Minor doc-string fixes.
f230ecc9 4868
4d09bcf6
PE
48692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4870
4871 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4872 Do not assume that spare memory exists; that assumption is valid
4873 only if SYSTEM_MALLOC.
4874 (LARGE_REQUEST): New macro, so that the issue of large requests
4875 is separated from the issue of spare memory.
4876
810928a2
AS
48772011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4878
172418ad
AS
4879 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4880 format. (Bug#8806)
4881
43f862f7
AS
4882 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4883
810928a2
AS
4884 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4885 before statements.
4886
a059fe24
JD
48872011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4888
4889 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4890
4891 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4892
4893 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4894 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4895
989bf368
JB
48962011-06-05 Juanma Barranquero <lekktu@gmail.com>
4897
4898 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4899
4b80f674
CY
49002011-06-04 Chong Yidong <cyd@stupidchicken.com>
4901
4902 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4903 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4904 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4905 New error handlers.
4b80f674
CY
4906 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4907 Obey Vx_select_enable_clipboard_manager. Catch errors in
4908 x_clipboard_manager_save (Bug#8779).
4909 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4910 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4911
99a33b77 49122011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4913
4914 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4915
99a33b77 49162011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4917
4918 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4919 in the current matrix if keep_current_p is non-zero.
4920
8264569d
EZ
49212011-06-04 Eli Zaretskii <eliz@gnu.org>
4922
4923 * bidi.c (bidi_level_of_next_char): Fix last change.
4924
57f97249
EZ
49252011-06-03 Eli Zaretskii <eliz@gnu.org>
4926
fec2107c 4927 Support bidi reordering of text covered by display properties.
57f97249 4928
fec2107c
EZ
4929 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4930 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4931 (bidi_cache_search, bidi_cache_iterator_state)
4932 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4933 (bidi_level_of_next_char, bidi_move_to_visually_next):
4934 Support character positions inside a run of characters covered by a
fec2107c
EZ
4935 display string.
4936 (bidi_paragraph_init, bidi_resolve_explicit_1)
4937 (bidi_level_of_next_char): Call bidi_fetch_char and
4938 bidi_fetch_char_advance instead of FETCH_CHAR and
4939 FETCH_CHAR_ADVANCE.
4940 (bidi_init_it): Initialize new members.
4941 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4942 definitions.
4943 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4944 instead of using explicit *_CHAR codes.
d6d100dd
SM
4945 (bidi_resolve_explicit, bidi_resolve_weak):
4946 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4947 bidirectional text is supported only in multibyte buffers.
4948 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4949 it to initialize the frame_window_p member of struct bidi_it.
4950 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4951 (bidi_resolve_explicit, bidi_resolve_weak)
4952 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4953 bidi_it->nchars is non-positive.
4954 (bidi_level_of_next_char): Don't try to lookup the cache for the
4955 next/previous character if nothing is cached there yet, or if we
4956 were just reseat()'ed to a new position.
c40e2fb2 4957
0e14fe90
EZ
4958 * xdisp.c (set_cursor_from_row): Set start and stop points
4959 according to the row's direction when priming the loop that looks
4960 for the glyph on which to display cursor.
4961 (single_display_spec_intangible_p): Function deleted.
4962 (display_prop_intangible_p): Reimplement to call
4963 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4964 Accept 3 additional arguments needed by handle_display_spec.
4965 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4966 values: lists, `(when COND...)' forms, etc.
4967 (single_display_spec_string_p): Support property values that are
4968 lists with the argument STRING its top-level element.
4969 (display_prop_string_p): Fix the condition for processing a
4970 property that is a list to be consistent with handle_display_spec.
fec2107c 4971 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4972 last portion of handle_display_prop.
4973 (compute_display_string_pos): Accept additional argument
4974 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4975 value of a `display' property is a "replacing spec".
4976 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4977 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4978 the display property, but just return a value indicating whether
4979 the display property will replace the characters it covers.
4980 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4981 frame_window_p members of struct bidi_it.
d6d100dd
SM
4982 (compute_display_string_pos, compute_display_string_end):
4983 New functions.
fec2107c
EZ
4984 (push_it): Accept second argument POSITION, where pop_it should
4985 jump to continue iteration.
4986 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4987
fec2107c
EZ
4988 * keyboard.c (adjust_point_for_property): Adjust the call to
4989 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4990
4991 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4992 (bidi_init_it): Update prototypes.
4993 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4994 (compute_display_string_pos, compute_display_string_end):
4995 Declare prototypes.
fec2107c
EZ
4996 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4997 EMACS_INT.
fc6f18ce 4998
40087514 49992011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5000
57f53182
PE
5001 Malloc failure behavior now depends on size of allocation.
5002 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5003 * lisp.h: Change signatures accordingly.
5004 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5005 All callers changed. (Bug#8762)
5006
5007 * gnutls.c: Use Emacs's memory allocators.
5008 Without this change, the gnutls library would invoke malloc etc.
5009 directly, which causes problems on non-SYNC_INPUT hosts, and which
5010 runs afoul of improving memory_full behavior. (Bug#8761)
5011 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5012 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5013 xfree instead of the default malloc, realloc, free.
5014 (Fgnutls_boot): No need to check for memory allocation failure,
5015 since xmalloc does that for us.
5016
ac32cd99 5017 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5018 * category.c (hash_get_category_set):
5019 * ccl.c (ccl_driver):
5020 * charset.c (Fdefine_charset_internal):
5021 * charset.h (struct charset.hash_index):
5022 * composite.c (get_composition_id, gstring_lookup_cache)
5023 (composition_gstring_put_cache):
5024 * composite.h (struct composition.hash_index):
5025 * dispextern.h (struct image.hash):
5026 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5027 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5028 (hashfn_equal, hashfn_user_defined, make_hash_table)
5029 (maybe_resize_hash_table, hash_lookup, hash_put)
5030 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5031 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5032 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5033 * image.c (make_image, search_image_cache, lookup_image)
5034 (xpm_put_color_table_h):
5035 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5036 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5037 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5038 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5039 * alloc.c (allocate_vectorlike):
5040 Check for overflow in vector size calculations.
5041 * ccl.c (ccl_driver):
5042 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5043 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5044 need to be updated by these changes.
40087514
PE
5045 * fns.c (make_hash_table, maybe_resize_hash_table):
5046 Check for integer overflow with large hash tables.
0de4bb68
PE
5047 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5048 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5049 (SXHASH_REDUCE): New macro.
5050 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5051 Use it instead of discarding useful hash info with large hash values.
5052 (sxhash_float): New function.
5053 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5054 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5055 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5056 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5057 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5058 Adjust signatures to match updated version of code.
5059 (consing_since_gc): Now EMACS_INT, since a single hash table can
5060 use more than INT_MAX bytes.
5061
698d32e2
DN
50622011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5063
5064 Make it possible to build with GCC-4.6+ -O2 -flto.
5065
5066 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5067
fd6fa53f
SM
50682011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5069
5070 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5071 Call minibuffer-inactive-mode.
5072
864db017
JB
50732011-05-31 Juanma Barranquero <lekktu@gmail.com>
5074
5075 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5076 Update dependencies.
5077
2ad0baf4
DN
50782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5079
5080 * data.c (init_data): Remove code for UTS, this system is not
5081 supported anymore.
5082
4fcc2638
DN
50832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5084
5085 Don't force ./temacs to start in terminal mode.
5086
5087 * frame.c (make_initial_frame): Initialize faces in all cases, not
5088 only when CANNOT_DUMP is defined.
5089 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5090
c56e0fd5
DN
50912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5092
5093 * dispnew.c (add_window_display_history): Use const for the string
5094 pointer. Remove declaration, not needed.
5095
333d54da 50962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5097
55d4c1b2 5098 Use 'inline', not 'INLINE'.
333d54da 5099 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5100 * alloc.c, fontset.c (INLINE): Remove.
5101 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5102 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5103 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5104 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5105 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5106
738db178
DN
51072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5108
5109 Make it possible to run ./temacs.
5110
5111 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5112 syms_of_callproc does the same thing. Remove test for
5113 "initialized", do it in the caller.
5114 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5115
620c53a6
SM
51162011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5117
5118 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5119 (read_minibuf): Use get_minibuffer.
5120 (syms_of_minibuf): Use DEFSYM.
5121 (Qmetadata): New var.
5122 * data.c (Qbuffer): Don't make it static.
5123 (syms_of_data): Use DEFSYM.
5124
e003a292
PE
51252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5126
5127 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5128 (CCL_CODE_MIN): New macro.
5129
ed008a6d
PE
51302011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5131
3687c2ef
PE
5132 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5133
ed008a6d
PE
5134 * eval.c (Qdebug): Now static.
5135 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5136 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5137 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5138
d66c4c7c
CY
51392011-05-29 Chong Yidong <cyd@stupidchicken.com>
5140
5141 * image.c: Various fixes to ImageMagick code comments.
5142 (Fimagemagick_types): Doc fix.
5143
5fbc2025
PE
51442011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5145
0196f88a
PE
5146 Minor fixes prompted by GCC 4.6.0 warnings.
5147
5148 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5149
5fbc2025
PE
5150 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5151 (x_clipboard_manager_save_all): Move extern decl to ...
5152 * xterm.h: ... here, so that it can be checked for consistency.
5153
1dd3c2d9
CY
51542011-05-29 Chong Yidong <cyd@stupidchicken.com>
5155
5156 * xselect.c (x_clipboard_manager_save_frame)
5157 (x_clipboard_manager_save_all): New functions.
5158 (Fx_clipboard_manager_save): Lisp function deleted.
5159
5160 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5161 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5162
5163 * xterm.h: Update prototype.
5164
5ba6571d
WX
51652011-05-28 William Xu <william.xwl@gmail.com>
5166
5167 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5168 exiting (Bug#8239).
5169
3eaff834
JM
51702011-05-28 Jim Meyering <meyering@redhat.com>
5171
e1900994 5172 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5173 * fns.c (to_uchar): Define.
5174 (crypto_hash_function): Use it to convert some newly-signed
5175 variables to unsigned, to avoid sign-extension bugs. For example,
5176 without this change, (md5 "truc") would evaluate to
5177 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5178 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5179 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5180
0f6990a7
PE
51812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5182
5183 Integer overflow fixes.
c8a9ca5a 5184
08686060
PE
5185 * dbusbind.c: Serial number integer overflow fixes.
5186 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5187 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5188 to hold a serial number that is too large for a fixnum.
5189 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5190 Check for serial numbers out of range. Decode any serial number
59568bf0 5191 that was so large that it became a float. (Bug#8722)
08686060 5192
2d1fc3c7
PE
5193 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5194 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5195 Use XFASTINT rather than XUINT when numbers are nonnegative.
5196 (xd_append_arg, Fdbus_method_return_internal):
5197 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5198 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5199 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5200 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5201 (Bug#8722)
2d1fc3c7 5202
c8a9ca5a
PE
5203 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5204
519e1d69
PE
5205 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5206
30569699
PE
5207 ccl: add integer overflow checks
5208 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5209 (IN_INT_RANGE): New macros.
5210 (ccl_driver): Use them to check for integer overflow when
5211 decoding a CCL program. Many of the new checks are whether XINT (x)
5212 fits in int; it doesn't always, on 64-bit hosts. The new version
5213 doesn't catch all possible integer overflows, but it's an
847044ea 5214 improvement. (Bug#8719)
30569699 5215
c11285dc
PE
5216 * alloc.c (make_event_array): Use XINT, not XUINT.
5217 There's no need for unsigned here.
5218
fdccd48e
PE
5219 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5220 This follows up to the 2011-05-06 change that substituted uintptr_t
5221 for EMACS_INT. This case wasn't caught back then.
5222
37910ab2
PE
5223 Rework Fformat to avoid integer overflow issues.
5224 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5225 now (part of C89). Include <verify.h>.
5226 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5227 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5228 (Fformat): Avoid the prepass trying to compute sizes; it was only
5229 approximate and thus did not catch overflow reliably. Instead, walk
5230 through the format just once, formatting and computing sizes as we go,
5231 checking for integer overflow at every step, and allocating a larger
5232 buffer as needed. Keep track separately whether the format is
5233 multibyte. Keep only the most-recently calculated precision, rather
5234 than them all. Record whether each argument has been converted to
5235 string. Use EMACS_INT, not int, for byte and char and arg counts.
5236 Support field widths and precisions larger than INT_MAX. Avoid
5237 sprintf's undefined behavior with conversion specifications such as %#d
5238 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5239 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5240 formatting out-of-range floating point numbers with int
9173deec 5241 formats. (Bug#8668)
37910ab2 5242
2e6578fb
PE
5243 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5244
0ae6bdee
PE
5245 * data.c: Avoid integer truncation in expressions involving floats.
5246 * data.c: Include <intprops.h>.
5247 (arith_driver): When there's an integer overflow in an expression
5248 involving floating point, convert the integers to floating point
5249 so that the resulting value does not suffer from catastrophic
5250 integer truncation. For example, on a 64-bit host (* 4
5251 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5252 Do not rely on undefined behavior after integer overflow.
5253
de883a70
PE
5254 merge count_size_as_multibyte, parse_str_to_multibyte
5255 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5256 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5257 Check for integer overflow.
5258 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5259 since it's now a duplicate of the other. This is more of
5260 a character than a buffer op, so better that it's in character.c.
5261 * fns.c, print.c: Adjust to above changes.
5262
2ff916cb
PE
52632011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5264
5265 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5266
f1b54466
PE
52672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5268
fb1ac845
PE
5269 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5270 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5271 (x_clipboard_manager_save): Now static.
5272 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5273
f1b54466
PE
5274 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5275 (crypto_hash_function): Now static.
5276 Fix pointer signedness problems. Avoid unnecessary initializations.
5277
a9f737ee
CY
52782011-05-27 Chong Yidong <cyd@stupidchicken.com>
5279
5280 * termhooks.h (Vselection_alist): Make it terminal-local.
5281
5282 * terminal.c (create_terminal): Initialize it.
5283
5284 * xselect.c: Support for clipboard managers.
5285 (Vselection_alist): Move to termhooks.h as terminal-local var.
5286 (LOCAL_SELECTION): New macro.
5287 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5288 (symbol_to_x_atom): Remove gratuitous arg.
5289 (x_handle_selection_request, lisp_data_to_selection_data)
5290 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5291 (x_own_selection, x_get_local_selection, x_convert_selection):
5292 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5293 (some_frame_on_display): Delete unused function.
5294 (Fx_own_selection_internal, Fx_get_selection_internal)
5295 (Fx_disown_selection_internal, Fx_selection_owner_p)
5296 (Fx_selection_exists_p): New optional frame arg.
5297 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5298 (x_handle_selection_clear): Don't treat other terminals with the
5299 same keyboard specially. Use the terminal-local Vselection_alist.
5300 (x_clear_frame_selections): Use Frun_hook_with_args.
5301
5302 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5303
5304 * xterm.h: Add support for those atoms.
5305
e067f0c1
CY
53062011-05-26 Chong Yidong <cyd@stupidchicken.com>
5307
5308 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5309 (converted_selections, conversion_fail_tag): New global variables.
5310 (x_selection_request_lisp_error): Free the above.
5311 (x_get_local_selection): Remove unnecessary code.
5312 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5313 of converted selections stored in converted_selections.
5314 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5315 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5316 (x_convert_selection): New function.
5317 (x_handle_selection_event): Simplify.
5318 (x_get_foreign_selection): Don't ignore incoming requests while
5319 waiting for an answer; this will fail when we implement
5320 SAVE_TARGETS, and seems unnecessary anyway.
5321 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5322 (Vx_sent_selection_functions): Doc fix.
5323
0f4aebc0
LL
53242011-05-26 Leo Liu <sdl.web@gmail.com>
5325
5326 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5327
e61124cd
YM
53282011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5329
5330 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5331
5332 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5333 for fringe update if it has periodic bitmap.
ac389d0c 5334 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5335 and fringe_bitmap_periodic_p.
5336
5337 * fringe.c (get_fringe_bitmap_data): New function.
5338 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5339 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5340 row. Mark glyph row for fringe update if periodicity changed.
5341
5342 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5343 for fringe update unless it has periodic bitmap.
5344
f16d9837
KH
53452011-05-25 Kenichi Handa <handa@m17n.org>
5346
5347 * xdisp.c (get_next_display_element): Set correct it->face_id for
5348 a static composition.
5349
e1b90ef6
LL
53502011-05-24 Leo Liu <sdl.web@gmail.com>
5351
5352 * deps.mk (fns.o):
5353 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5354
5355 * fns.c (crypto_hash_function, Fsha1): New function.
5356 (Fmd5): Use crypto_hash_function.
5357 (syms_of_fns): Add Ssha1.
5358
7400048f
PE
53592011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5360
5361 * gnutls.c: Remove unused macros.
5362 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5363 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5364 Remove macros that are defined and never used.
5365 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5366
abb71cf4
CY
53672011-05-22 Chong Yidong <cyd@stupidchicken.com>
5368
5369 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5370 (Fx_get_selection_internal): Minor cleanup.
5371 (Fx_own_selection_internal): Rename arguments for consistency with
5372 select.el.
5373
6307db39
PE
53742011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5375
5376 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5377
f3d4e0a4
CY
53782011-05-22 Chong Yidong <cyd@stupidchicken.com>
5379
5380 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5381
4d8ade89
YM
53822011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5383
5384 * dispnew.c (scrolling_window): Don't exclude the case that the
5385 last enabled row in the desired matrix touches the bottom boundary.
5386
32078c8d
GM
53872011-05-21 Glenn Morris <rgm@gnu.org>
5388
5389 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5390 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5391 and add some more files.
32078c8d 5392
7285dc67
EZ
53932011-05-20 Eli Zaretskii <eliz@gnu.org>
5394
5395 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5396 report_file_error introduced by the change from 2011-05-07.
5397
89d1bd22
PE
53982011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5399
5400 * systime.h (Time): Define only if emacs is defined.
5401 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5402 where the include path doesn't have X11/X.h by default. See
5403 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5404
e23640bb 54052011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5406
5407 * composite.c (find_automatic_composition): Fix previous change.
5408
b9704ad9
GM
54092011-05-20 Glenn Morris <rgm@gnu.org>
5410
5411 * lisp.mk: New file, split from Makefile.in.
5412 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5413 (shortlisp): Remove.
5414 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5415
4a720484
GM
54162011-05-19 Glenn Morris <rgm@gnu.org>
5417
5418 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5419 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5420 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5421 (lisp): Set the order to that of loadup.el.
5422 (shortlisp): Make it a copy of $lisp.
5423 (SOME_MACHINE_LISP): Remove.
5424 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5425 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5426
a28d4396
KH
54272011-05-18 Kenichi Handa <handa@m17n.org>
5428
5429 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5430 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5431 (find_automatic_composition): Mostly rewrite for efficiency.
5432
a2b1fa8e
JB
54332011-05-18 Juanma Barranquero <lekktu@gmail.com>
5434
5435 * makefile.w32-in: Update dependencies.
5436
8e1f5610
CS
54372011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5438
5439 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5440 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5441
7025ee00 54422011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5443
cdfa6eab
PE
5444 Fix some integer overflow issues, such as string length overflow.
5445
06d6db33
PE
5446 * insdel.c (count_size_as_multibyte): Check for string overflow.
5447
2b4560a8
PE
5448 * character.c (lisp_string_width): Check for string overflow.
5449 Use EMACS_INT, not int, for string indexes and lengths; in
5450 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5451 the resulting string length overflows an EMACS_INT; instead,
5452 report a string overflow if no precision given. When checking for
5453 precision exhaustion, use a check that cannot possibly have
5454 integer overflow. (Bug#8675)
5455 * character.h (lisp_string_width): Adjust to new signature.
5456
cb93f9be
PE
5457 * alloc.c (string_overflow): New function.
5458 (Fmake_string): Use it. This doesn't change behavior, but saves
5459 a few bytes and will simplify future changes.
5460 * character.c (string_escape_byte8): Likewise.
5461 * lisp.h (string_overflow): New decl.
5462
1a1f3366
PE
5463 Fixups, following up to the user-interface timestamp change.
5464 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5465 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5466 * msdos.c (mouse_get_pos): Likewise.
5467 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5468 * w32gui.h (Time): Define by including "systime.h" rather than by
5469 declaring it ourselves. (Bug#8664)
5470
d4e3e4d3
PE
5471 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5472 * image.c (clear_image_cache): Likewise.
5473
f6a24d19
PE
5474 * term.c (term_mouse_position): Don't assume time_t wraparound.
5475
08dc5ae6
PE
5476 Be more systematic about user-interface timestamps.
5477 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5478 and sometimes 'EMACS_UINT', to represent these timestamps.
5479 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5480 This makes the code easier to follow, and makes it easier to catch
5481 integer overflow bugs such as Bug#8664.
5482 * frame.c (Fmouse_position, Fmouse_pixel_position):
5483 Use Time, not unsigned long, for user-interface timestamps.
5484 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5485 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5486 * keyboard.h (last_event_timestamp): Likewise.
5487 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5488 * menu.h (xmenu_show): Likewise.
5489 * term.c (term_mouse_position): Likewise.
5490 * termhooks.h (struct input_event.timestamp): Likewise.
5491 (struct terminal.mouse_position_hook): Likewise.
5492 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5493 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5494 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5495 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5496 what it was before.
5497 * menu.h, termhooks.h: Include "systime.h", for Time.
5498
8e55734a
PE
5499 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5500 Don't assume that the difference between two unsigned long values
5501 can fit into an integer. At this point, we know button_down_time
5502 <= event->timestamp, so the difference must be nonnegative, so
5503 there's no need to cast the result if double-click-time is
5504 nonnegative, as it should be; check that it's nonnegative, just in
5505 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5506 apart (about 25 days). (Bug#8664)
8e55734a 5507
841f1b75 5508 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5509 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5510
3e26f69c
PE
5511 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5512 that always fit in int. Use a sentinel instead of a counter, to
5513 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5514 * frame.h (struct frame): Use int for menu_bar_items_used
5515 instead of EMACS_INT, since it always fits in int.
3e26f69c 5516
5cc152c0
PE
5517 * menu.c (grow_menu_items): Check for int overflow.
5518
d89eb65e
PE
5519 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5520
5235bd3e
PE
5521 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5522 Before, the code was not consistent. These values cannot exceed
5523 2**31 - 1 so there's no need to make them unsigned.
5524 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5525 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5526 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5527 as modifiers.
5528 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5529
bc827e23
PE
5530 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5531 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5532 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5533 presumably because the widths might not match.
5534
78eb494e
PE
5535 * window.c (size_window): Avoid needless test at loop start.
5536
04f2d78b
CB
55372011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5538
5539 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5540
d2fc7e3d 55412011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5542
5543 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5544
d2fc7e3d 55452011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5546
5547 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5548 `width' to `bar_area_x' and `bar_area_width', respectively.
5549 (x_scroll_run): Take account of fringe background extension.
5550
04f2d78b
CB
5551 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5552 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5553 `bar_area_width', respectively.
5554 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5555 background extension.
5556
79b70037
GM
55572011-05-10 Jim Meyering <meyering@redhat.com>
5558
5559 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5560
2f142cc5
JB
55612011-05-10 Juanma Barranquero <lekktu@gmail.com>
5562
5563 * image.c (Finit_image_library): Return t for built-in image types,
5564 like pbm and xbm. (Bug#8640)
5565
57679c86
AS
55662011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5567
5568 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5569
888c9e86
EZ
55702011-05-07 Eli Zaretskii <eliz@gnu.org>
5571
b0512a1d
EZ
5572 * w32console.c (Fset_screen_color): Doc fix.
5573 (Fget_screen_color): New function.
5574 (syms_of_ntterm): Defsubr it.
5575
7285dc67
EZ
5576 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5577 unlink the temporary file if Fcall_process didn't create it in the
5578 first place.
5579 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5580 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5581 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5582 cue to call_process_cleanup not to close that handle.
5583
4d3fcc8e
BK
55842011-05-07 Ben Key <bkey76@gmail.com>
5585
5586 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5587 one of two shell specific rules, either bootstrap-temacs-CMD or
5588 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5589 to the previous implementation of the bootstrap-temacs rule.
5590 The bootstrap-temacs-CMD rule is similar to the previous
5591 implementation of the bootstrap-temacs rule except that it
5592 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5593 variable.
5594
5595 These changes, along with some changes to nt/configure.bat,
5596 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5597 earlier fix to add support for --cflags and --ldflags options
5598 that include quotes so that it works whether make uses cmd or
5599 sh as the shell.
5600
b4289b64
MA
56012011-05-06 Michael Albinus <michael.albinus@gmx.de>
5602
5603 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5604 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5605 is a constant.
5606 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5607 a string. Handle both cases.
5608 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5609 (Fdbus_register_method): Use Qinvalid_function.
5610
af4c0e28
JB
56112011-05-06 Juanma Barranquero <lekktu@gmail.com>
5612
5613 * makefile.w32-in: Update dependencies.
5614 (LISP_H): Add inttypes.h and stdin.h.
5615 (PROCESS_H): Add unistd.h.
5616
c51453d9
EZ
56172011-05-06 Eli Zaretskii <eliz@gnu.org>
5618
5619 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5620 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5621
8ff0ac3c 56222011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5623
4c4b566b
PE
5624 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5625
aab2b9b5
PE
5626 * term.c (vfatal): Remove stray call to va_end.
5627 It's not needed and the C Standard doesn't allow it here anyway.
5628
c378da0b
PE
5629 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5630 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5631
288b08c7
PE
5632 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5633 bytes.
5634
e3601888
PE
5635 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5636
db6c0e74
PE
5637 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5638
dd5963ea
PE
5639 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5640
88c9450f
PE
5641 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5642
2f9442b8
PE
5643 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5644
c032b5f8
PE
5645 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5646 * charset.c (Fdefine_charset_internal): Don't initialize
5647 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5648 32-bit int (Bug#8600).
a108c10b
PE
5649
5650 * lread.c (read_integer): Be more consistent with string-to-number.
5651 Use string_to_number to do the actual conversion; this avoids
5652 rounding errors and fixes some other screwups. Without this fix,
5653 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5654 (digit_to_number): Move earlier, for benefit of read_integer.
5655 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5656 not a digit in any supported base. (Bug#8602)
a108c10b 5657
ad5f9eea
PE
5658 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5659
aec1708a
PE
5660 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5661 to match comment at start of function. This also removes a
5662 GCC warning about overflow in a 32+64-bit port.
5663
47be4ab5
PE
5664 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5665
371cac43
PE
5666 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5667 Reported by Stefan Monnier in
5668 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5669 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5670 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5671
d01a7826
PE
5672 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5673 (EMACS_UINTPTR): Likewise, with uintptr_t.
5674
7fd47d5c
PE
5675 * lisp.h: Prefer 64-bit EMACS_INT if available.
5676 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5677 on 32-bit hosts that have 64-bit int, so that they can access
5678 large files.
122b0c86
PE
5679 However, temporarily disable this change unless the temporary
5680 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5681
8727937b
PE
5682 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5683
8ac068ac
PE
5684 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5685 This removes an assumption that EMACS_INT and long are the same
5686 width as pointers. The assumption is true for Emacs porting targets
5687 now, but we want to make other targets possible.
5688 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5689 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5690 In the rest of the code, change types of integers that hold casted
5691 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5692 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5693 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5694 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5695 No need to cast type when ORing.
5696 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5697 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5698 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5699 assume EMACS_INT is the same width as char *.
5700 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5701 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5702 Remove no-longer-needed casts.
5703 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5704 (xg_tool_bar_help_callback, xg_make_tool_item):
5705 Use EMACS_INTPTR to hold an integer
5706 that will be cast to void *; this can avoid a GCC warning
5707 if EMACS_INT is not the same width as void *.
5708 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5709 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5710 (current_message_1, set_message_1):
5711 Use a local to convert to proper width without a cast.
5712 * xmenu.c (dialog_selection_callback): Likewise.
5713
ede49d71
PE
5714 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5715 Also, don't assume VALBITS / RAND_BITS is less than 5,
5716 and don't rely on undefined behavior when shifting a 1 left into
5717 the sign bit.
5718 * lisp.h (get_random): Change signature to match.
5719
2f30ecd0
PE
5720 * lread.c (hash_string): Use size_t, not int, for hash computation.
5721 Normally we prefer signed values; but hashing is special, because
5722 it's better to use unsigned division on hash table sizes so that
5723 the remainder is nonnegative. Also, size_t is the natural width
5724 for hashing into memory. The previous code used 'int', which doesn't
5725 retain enough info to hash well into very large tables.
5726 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5727
2a866e7b
PE
5728 * dbusbind.c: Don't possibly lose pointer info when converting.
5729 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5730 Use XPNTR rather than XHASH, so that the high-order bits of
5731 the pointer aren't lost when converting through void *.
5732
51639eac
PE
5733 * eval.c (Fautoload): Don't double-shift a pointer.
5734
92394119
PE
5735 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5736
dbdb9a7c
JB
57372011-05-06 Juanma Barranquero <lekktu@gmail.com>
5738
5739 * gnutls.c (DEF_GNUTLS_FN):
5740 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5741
db7a0b4f
AS
57422011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5743
5744 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5745 marker. (Bug#8610)
5746
f7ff1b0f 57472011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5748
5749 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5750 New version that can reserve upto 2GB of heap space.
5751
f7ff1b0f 57522011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5753
5754 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5755
639c109b
TZ
57562011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5757
5758 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5759 `gnutls_certificate_set_x509_key_file'.
5760
d2127135
JB
57612011-05-05 Juanma Barranquero <lekktu@gmail.com>
5762
5763 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5764 Update dependencies.
5765
e968f4f3
JB
57662011-05-04 Juanma Barranquero <lekktu@gmail.com>
5767
5768 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5769 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5770 Remove unused parameter `fildes'.
5771 * process.c (read_process_output, send_process): Don't pass it.
5772
84d358f0
JB
57732011-05-04 Juanma Barranquero <lekktu@gmail.com>
5774
5775 Fix previous change: the library cache is defined in w32.c.
5776 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5777 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5778
0898ca10
JB
57792011-05-04 Juanma Barranquero <lekktu@gmail.com>
5780
5781 Implement dynamic loading of GnuTLS on Windows.
5782
5783 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5784 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5785 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5786 Declare.
5787
5788 * gnutls.c (Qgnutls_dll): Define.
5789 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5790 (gnutls_*): Declare function pointers.
5791 (init_gnutls_functions): New function to initialize function pointers.
5792 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5793 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5794 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5795 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5796 (emacs_gnutls_write, emacs_gnutls_read)
5797 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5798 (Fgnutls_available_p): New function.
5799 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5800 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5801 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5802
5803 * image.c: Include w32.h.
5804 (Vimage_type_cache): Delete.
5805 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5806 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5807 (w32_delayed_load): Move to w32.c.
5808
5809 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5810
5811 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5812 (w32_delayed_load): Move from image.c. When loading a library, record
5813 its filename in the :loaded-from property of the library id.
5814 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5815 Initialize and staticpro them.
5816 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5817
5818 * process.c: Include lisp.h before w32.h, not after.
5819 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5820 instead of gnutls_record_check_pending.
5821
5822 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5823
ff4de4aa
TZ
58242011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5825
5826 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5827 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5828 as passed in.
5829
abe95abb
JD
58302011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5831
5832 * xterm.c (x_set_frame_alpha): Do not set property on anything
5833 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5834
e16e55d4
JB
58352011-05-02 Juanma Barranquero <lekktu@gmail.com>
5836
5837 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5838
bafcf6a5
JB
58392011-05-02 Juanma Barranquero <lekktu@gmail.com>
5840
5841 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5842 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5843 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5844 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5845 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5846 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5847 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5848 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5849 (Qgnutls_bootprop_callbacks_verify): Make static.
5850
e7a6747f
AS
58512011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5852
19ed11ba
AS
5853 * callproc.c: Indentation fixup.
5854
e7a6747f 5855 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5856 (wait_for_termination, interruptible_wait_for_termination):
5857 Move after wait_for_termination_1.
e7a6747f 5858
1ef14cb4
LMI
58592011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5860
5861 * sysdep.c (interruptible_wait_for_termination): New function
5862 which is like wait_for_termination, but allows keyboard
5863 interruptions.
5864
5865 * callproc.c (Fcall_process): Add (:file "file") as an option for
5866 the STDOUT buffer.
5867 (Fcall_process_region): Ditto.
5868
330d880c
EZ
58692011-04-30 Eli Zaretskii <eliz@gnu.org>
5870
8db90b73
EZ
5871 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5872 rather than `XVECTOR (FOO)->size'.
5873
330d880c
EZ
5874 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5875 inttypes.h, as a gnulib replacement is used if it not available in
5876 system headers.
5877
15cbd324
EZ
58782011-04-21 Eli Zaretskii <eliz@gnu.org>
5879
5880 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5881 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5882 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5883
5884 * coding.c (coding_alloc_by_realloc): Error out if destination
5885 will grow beyond MOST_POSITIVE_FIXNUM.
5886 (decode_coding_emacs_mule): Abort if there isn't enough place in
5887 charbuf for the composition carryover bytes. Reserve an extra
5888 space for up to 2 characters produced in a loop.
5889 (decode_coding_iso_2022): Abort if there isn't enough place in
5890 charbuf for the composition carryover bytes.
5891
58922011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5893
ae940cca
EZ
5894 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5895 aborting when %lld or %lll format is passed.
5896 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5897 %llo or %llx format is passed. (Bug#8545)
5898
03ab8921
EZ
5899 * window.c (window_scroll_line_based): Use a marker instead of
5900 simple variables to record original value of point. (Bug#7952)
5901
afda1437
EZ
5902 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5903 produced by %s or %c overflows available buffer space. (Bug#8545)
5904
f76dee0c
PE
59052011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5906
5907 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5908 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5909
fdc5744d
JB
59102011-04-28 Juanma Barranquero <lekktu@gmail.com>
5911
5912 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5913
638f053a
JB
59142011-04-28 Juanma Barranquero <lekktu@gmail.com>
5915
5916 * keyboard.c (Qdelayed_warnings_hook): Define.
5917 (command_loop_1): Run `delayed-warnings-hook'
5918 if Vdelayed_warnings_list is non-nil.
5919 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5920 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5921
d178f871
EZ
59222011-04-28 Eli Zaretskii <eliz@gnu.org>
5923
5924 * doprnt.c (doprnt): Don't return value smaller than the buffer
5925 size if the message was truncated. (Bug#8545).
5926
b124fd93
JB
59272011-04-28 Juanma Barranquero <lekktu@gmail.com>
5928
5929 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5930 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5931
e810457d
PE
59322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5933
5934 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5935
ea51cceb
JB
59362011-04-27 Juanma Barranquero <lekktu@gmail.com>
5937
5938 * makefile.w32-in: Update dependencies.
5939
94dcfacf
EZ
59402011-04-27 Eli Zaretskii <eliz@gnu.org>
5941
5942 Improve `doprnt' and its usage. (Bug#8545)
5943 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5944 `format_end'. Remove support for %l as a conversion specifier.
5945 Don't use xrealloc. Improve diagnostics when the %l size modifier
5946 is used. Update the commentary.
5947
5948 * eval.c (verror): Simplify calculation of size_t.
5949
5950 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5951 messages.
5952
f61f41d7
PE
59532011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5954
5955 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5956 change.
5957
96fb4434
PE
59582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5959
5960 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5961 This makes this file independent of the recent pseudovector change.
5962
671875da 59632011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5964
69e9b5a3
PE
5965 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5966
b5f869a7 5967 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5968 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5969 Remove unused local.
c8926152 5970 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5971
841a1577 5972 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5973 GCC 4.6.0 optimizes based on type-based alias analysis.
5974 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5975 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5976 != &v->size, and therefore "v->size = 1; b->size = 2; return
5977 v->size;" must therefore return 1. This assumption is incorrect
5978 for Emacs, since it type-puns struct Lisp_Vector * with many other
5979 types. To fix this problem, this patch adds a new type struct
f904488f 5980 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5981 and pseudovectors, and helps optimizing compilers not get fooled
5982 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5983 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5984 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5985 the size member.
eab3844f
PE
5986 (XSETPVECTYPE): Rewrite in terms of new macro.
5987 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5988 This is a bit clearer, and further avoids the possibility of
5989 undesirable aliasing.
5990 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5991 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5992 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5993 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5994 (ASIZE): Now uses header.size rather than size.
5995 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5996 to avoid the hassle of writing XVECTOR (foo)->header.size.
5997 (struct vectorlike_header): New type.
eab3844f
PE
5998 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5999 object, to help avoid aliasing.
6000 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6001 (SUBRP): Likewise, since Lisp_Subr is a special case.
6002 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6003 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6004 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6005 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6006 changed to be "header.size" and "header.next".
6007 * buffer.h (struct buffer): Likewise.
6008 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6009 * frame.h (struct frame): Likewise.
6010 * process.h (struct Lisp_Process): Likewise.
6011 * termhooks.h (struct terminal): Likewise.
6012 * window.c (struct save_window_data, struct saved_window): Likewise.
6013 * window.h (struct window): Likewise.
6014 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6015 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6016 * buffer.c (init_buffer_once): Likewise.
6017 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6018 special case.
6019 * process.c (Fformat_network_address): Use local var for size,
6020 for brevity.
6021
0df1eac5
PE
6022 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6023
847ab9d1 6024 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6025 * data.c (atof): Remove decl; no longer used or needed.
6026 (digit_to_number): Move to lread.c.
6027 (Fstring_to_number): Use new string_to_number function, to be
6028 consistent with how the Lisp reader treats infinities and NaNs.
6029 Do not assume that floating-point numbers represent EMACS_INT
6030 without losing information; this is not true on most 64-bit hosts.
6031 Avoid double-rounding errors, by insisting on integers when
6032 parsing non-base-10 numbers, as the documentation specifies.
6033 * lisp.h (string_to_number): New decl, replacing ...
6034 (isfloat_string): Remove.
bc0a5c13 6035 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6036 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6037 appears to have been a coding error. Similarly, do not accept
6038 strings like +-1e0 as floating point numbers. Do not report
6039 overflow for integer overflows unless the base is not 10 which
6040 means we have no simple and reliable way to continue.
6041 Break out the floating-point parsing into a new
6042 function string_to_number, so that Fstring_to_number parses
6043 floating point numbers consistently with the Lisp reader.
04f2d78b 6044 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6045 (E_CHAR, EXP_INT): Remove, replacing with ...
6046 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6047 (string_to_number): New function, replacing isfloat_string.
6048 This function checks for valid syntax and produces the resulting
6049 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6050 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6051 so that overflow for non-base-10 numbers is reported only when
6052 there's no portable and simple way to convert to floating point.
452f4150 6053
67769ffc
PE
6054 * textprop.c (set_text_properties_1): Rewrite for clarity,
6055 and to avoid GCC warning about integer overflow.
6056
c20db43f
PE
6057 * intervals.h (struct interval): Use EMACS_INT for members
6058 where EMACS_UINT might cause problems. See
6059 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6060 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6061 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6062 All uses changed.
37aa2f85
PE
6063 (offset_intervals): Tell GCC not to worry about length overflow
6064 when negating a negative length.
c20db43f 6065
2538aa2f
PE
6066 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6067 (overrun_check_free): Likewise.
6068
f2d3008d
PE
6069 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6070 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6071 word size.
6072
ec8df744
PE
6073 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6074 (gnutls_make_error): Rename local to avoid shadowing.
6075 (gnutls_emacs_global_deinit): ifdef out; not used.
6076 (Fgnutls_boot): Use const for pointer to readonly storage.
6077 Comment out unused local. Fix pointer signedness problems.
6078
640ee02d
PE
6079 * lread.c (openp): Don't stuff size_t into an 'int'.
6080 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6081 about possible signed overflow.
6082
6048fb2a
PE
6083 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6084 (GDK_KEY_g): Don't define if already defined.
6085 (xg_prepare_tooltip): Avoid pointer signedness problem.
6086 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6087
fa3c87e1
PE
6088 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6089 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6090
2172544b
PE
6091 * xfns.c (Fx_window_property): Simplify a bit,
6092 to make a bit faster and to avoid GCC 4.6.0 warning.
6093 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6094
9b821a21
PE
6095 * fns.c (internal_equal): Don't assume size_t fits in int.
6096
3c616cfa
PE
6097 * alloc.c (compact_small_strings): Tighten assertion a little.
6098
c2982e87
PE
6099 Replace pEd with more-general pI, and fix some printf arg casts.
6100 * lisp.h (pI): New macro, generalizing old pEd macro to other
6101 conversion specifiers. For example, use "...%"pI"d..." rather
6102 than "...%"pEd"...".
6103 (pEd): Remove. All uses replaced with similar uses of pI.
6104 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6105 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6106 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6107 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6108 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6109 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6110 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6111 64-bit hosts.
6112 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6113 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6114 * print.c (safe_debug_print, print_object): Likewise.
6115 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6116 to int.
6f04d126
PE
6117 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6118 avoiding the 0 flag, which is not portable.
c2982e87
PE
6119 * process.c (Fmake_network_process): Use pI to avoid cast.
6120 * region-cache.c (pp_cache): Likewise.
6121 * xdisp.c (decode_mode_spec): Likewise.
6122 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6123 behavior on 64-bit hosts with printf arg.
6f04d126 6124 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6125 (x_stop_queuing_selection_requests): Likewise.
6126 (x_get_window_property): Don't truncate byte count to an 'int'
6127 when tracing.
0b432f21 6128
5e073ec7
PE
6129 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6130 here, since it parses constructs like leading '-' and spaces,
6131 which are not wanted; and it overflows with large numbers.
6132 Instead, simply match F[0-9]+, which is what is wanted anyway.
6133
36372bf9
PE
6134 * alloc.c: Remove unportable assumptions about struct layout.
6135 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6136 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6137 (allocate_vectorlike, make_pure_vector): Use the new macros,
6138 plus offsetof, to remove unportable assumptions about struct layout.
6139 These assumptions hold on all porting targets that I know of, but
6140 they are not guaranteed, they're easy to remove, and removing them
6141 makes further changes easier.
6142
0b432f21
PE
6143 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6144 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6145 (string_overrun_cookie): Now const. Use initializers that
6146 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6147 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6148 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6149 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6150 multiple of sizeof (EMACS_INT); it need not be, if
6151 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6152 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6153
895009e1
JB
61542011-04-26 Juanma Barranquero <lekktu@gmail.com>
6155
6156 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6157
6a7a1b0b
TZ
61582011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6159
6160 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6161 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6162 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6163
841a1577 61642011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6165
6166 * lisp.h (Qdebug): List symbol.
895009e1 6167 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6168 * keyboard.c (debug-on-event): New variable.
6169 (handle_user_signal): Break into debugger when debug-on-event
6170 matches the current signal symbol.
6171
f2d3ba6f
DN
61722011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6173
6174 * alloc.c (check_sblock, check_string_bytes)
6175 (check_string_free_list): Convert to standard C.
6176
42ce4c63
TZ
61772011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6178
6179 * w32.c (emacs_gnutls_push): Fix typo.
6180
825cd63c
EZ
61812011-04-25 Eli Zaretskii <eliz@gnu.org>
6182
fb11d64d
EZ
6183 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6184 "cast to pointer from integer of different size".
6185
825cd63c
EZ
6186 Improve doprnt and its use in verror. (Bug#8545)
6187 * doprnt.c (doprnt): Document the set of format control sequences
6188 supported by the function. Use SAFE_ALLOCA instead of always
6189 using `alloca'.
6190
6191 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6192 is one byte too soon. Don't use xrealloc; instead xfree and
6193 xmalloc anew.
6194
e061a11b
TZ
61952011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6196
6197 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6198 callbacks stage.
6199
6200 * gnutls.c: Renamed global_initialized to
6201 gnutls_global_initialized. Added internals for the
6202 :verify-hostname-error, :verify-error, and :verify-flags
6203 parameters of `gnutls-boot' and documented those parameters in the
6204 docstring. Start callback support.
9173deec
JB
6205 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6206 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6207 on error. Return error code.
e061a11b
TZ
6208 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6209 (emacs_gnutls_read): Likewise.
6210 (Fgnutls_boot): Return handshake error code.
6211 (emacs_gnutls_handle_error): New function.
6212 (wsaerror_to_errno): Likewise.
6213
6214 * w32.h (emacs_gnutls_pull): Add prototype.
6215 (emacs_gnutls_push): Likewise.
6216
6217 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6218 (emacs_gnutls_push): Likewise.
6219
62202011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6221
6222 * process.c (wait_reading_process_output): Check if GnuTLS
6223 buffered some data internally if no FDs are set for TLS
6224 connections.
6225
6226 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6227 (LIBS): Link to USER_LIBS.
6228 ($(BLD)/gnutls.$(0)): New target.
6229
fa6996bc
EZ
62302011-04-24 Eli Zaretskii <eliz@gnu.org>
6231
eb35682e
EZ
6232 * xdisp.c (handle_single_display_spec): Rename the
6233 display_replaced_before_p argument into display_replaced_p, to
6234 make it consistent with the commentary. Fix typos in the
6235 commentary.
6236
e2ad650c
EZ
6237 * textprop.c (syms_of_textprop): Remove dead code.
6238 (copy_text_properties): Delete obsolete commentary about an
6239 interface that was deleted long ago. Fix typos in the description
6240 of arguments.
6241
1b2de274
EZ
6242 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6243 to changes in oldXMenu/XMenu.h from 2011-04-16.
6244 <menu_help_message, prev_menu_help_message>: Constify.
6245 (IT_menu_make_room): menu->help_text is now `const char **';
6246 adjust.
6247
6248 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6249 to changes in oldXMenu/XMenu.h from 2011-04-16.
6250 (struct XMenu): Declare `help_text' `const char **'.
6251
6252 * xfaces.c <Qunspecified>: Make extern again.
6253
6254 * syntax.c: Include sys/types.h before including regex.h, as
6255 required by Posix.
6256
762b15be
EZ
6257 * doc.c (get_doc_string): Improve the format passed to `error'.
6258
6259 * doprnt.c (doprnt): Improve commentary.
6260
6261 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6262
6263 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6264 them with etags.
6265
f1052e5d
EZ
6266 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6267 changes in globals.h immediately force recompilation.
762b15be
EZ
6268 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6269 $(CURDIR)/s/ms-w32.h.
6270 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6271
fa6996bc
EZ
6272 * character.c (Fchar_direction): Function deleted.
6273 (syms_of_character): Don't defsubr it.
6274 <char-direction-table>: Deleted.
6275
e6c3da20
EZ
62762011-04-23 Eli Zaretskii <eliz@gnu.org>
6277
6278 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6279 * doprnt.c: Include limits.h.
6280 (SIZE_MAX): New macro.
04f2d78b
CB
6281 (doprnt): Return a size_t value. 2nd arg is now size_t.
6282 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6283 Improve overflow protection. Support `l' modifier for integer
6284 conversions. Support %l conversion. Don't assume an EMACS_INT
6285 argument for integer conversions and for %c.
6286
6287 * lisp.h (doprnt): Restore prototype.
6288
6289 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6290 $(SRC)/character.h.
6291
6292 * Makefile.in (base_obj): Add back doprnt.o.
6293
6294 * deps.mk (doprnt.o): Add back prerequisites.
6295 (callint.o): Depend on character.h.
6296
6297 * eval.c (internal_lisp_condition_case): Include the handler
6298 representation in the error message.
6299 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6300 when breaking from the loop.
6301
6302 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6303
6304 * callint.c (Fcall_interactively): When displaying error message
6305 about invalid control letter, pass the character's codepoint, not
6306 a pointer to its multibyte form. Improve display of the character
6307 in octal and display also its hex code.
6308
6309 * character.c (char_string): Use %x to display the (unsigned)
6310 codepoint of an invalid character, to avoid displaying a bogus
6311 negative value.
6312
6313 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6314 `error', not SYMBOL_NAME itself.
6315
6316 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6317 character arguments to `error'.
6318
6319 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6320 to `error' in error message about FINAL_CHAR argument. Make sure
6321 FINAL_CHAR is a character, and use %c when it is passed as
6322 argument to `error'.
6323
4ffd0d6b 63242011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6325
6326 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6327
6328 * w32.c: Include <time.h>.
6329 (sys_localtime): New function.
6330
4ffd0d6b 63312011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6332
6333 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6334
4ffd0d6b 6335 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6336
4ffd0d6b 63372011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6338
4ffd0d6b
GM
6339 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6340 zombies (Bug#8467).
aac0c6e3 6341
04c56954
EZ
63422011-04-19 Eli Zaretskii <eliz@gnu.org>
6343
6344 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6345 gl_state.e_property when gl_state.object is Qt.
6346
6347 * insdel.c (make_gap_larger): Remove limitation of buffer size
6348 to <= INT_MAX.
6349
16a43933
CY
63502011-04-18 Chong Yidong <cyd@stupidchicken.com>
6351
6352 * xdisp.c (lookup_glyphless_char_display)
6353 (produce_glyphless_glyph): Handle cons cell entry in
6354 glyphless-char-display.
6355 (Vglyphless_char_display): Document it.
6356
6357 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6358 glyphless-char-display.
6359
4581706e
CY
63602011-04-17 Chong Yidong <cyd@stupidchicken.com>
6361
6362 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6363
6364 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6365
6366 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6367 definition for no-X builds.
6368
4887c6e2 63692011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6370
fd35b6f9
PE
6371 Static checks with GCC 4.6.0 and non-default toolkits.
6372
5c1ccb01
PE
6373 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6374
006c5daa
PE
6375 * process.c (keyboard_bit_set): Define only if SIGIO.
6376 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6377 (send_process): Repair possible setjmp clobbering.
6378
efc736d3
PE
6379 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6380
4e2fe2e6
PE
6381 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6382
f97334a2
PE
6383 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6384
4e75f29d
PE
6385 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6386 Define only if needed.
6387
90efadd1
PE
6388 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6389 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6390 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6391
3c647824
PE
6392 * dispextern.h (struct redisplay_interface): Rename param
6393 to avoid shadowing.
e264f262 6394 * termhooks.h (struct terminal): Likewise.
761383f4 6395 * xterm.c (xembed_send_message): Likewise.
3c647824 6396
b58c5c4a
PE
6397 * insdel.c (make_gap_smaller): Define only if
6398 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6399
cad59032
PE
6400 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6401 it.
6402
c339dc2e
PE
6403 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6404 so that we aren't warned about unused symbols.
6405
91a3e27b
PE
6406 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6407
399c71d3 6408 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6409
8ffc96f5
PE
6410 * xfns.c (x_real_positions): Mark locals as initialized.
6411
eef9bc79
PE
6412 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6413
098db9dd
PE
6414 * xterm.c: Fix problems found by static analysis with other toolkits.
6415 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6416 (x_dispatch_event): Declare static if USE_GTK, and
6417 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6418 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6419 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6420 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6421 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6422
eb18f6cc
PE
6423 * xmenu.c (menu_help_callback): Pointer type fixes.
6424 Use const pointers when pointing at readonly data. Avoid pointer
6425 signedness clashes.
6426 (FALSE): Remove unused macro.
6427 (update_frame_menubar): Remove unused decl.
6428
1fe72bf8
PE
6429 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6430
60d9e1db
PE
6431 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6432 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6433 (single_menu_item): Rename local to avoid shadowing.
6434
39261c26
PE
6435 * keyboard.c (make_lispy_event): Remove unused local var.
6436
018c5e19
PE
6437 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6438 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6439
63d2b86e
PE
6440 * bitmaps: Change bitmaps from unsigned char back to the X11
6441 compatible char. Avoid the old compiler warnings about
6442 out-of-range initializers by using, for example, '\xab' rather
6443 than 0xab.
6444
aefd87e1
PE
6445 * xgselect.c (xgselect_initialize): Check vs interface
6446 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6447
bf501fb9
PE
6448 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6449
e9829fdf
PE
6450 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6451 to read-only memory.
6452
1086c095
PE
6453 * fns.c (vector): Remove; this old hack is no longer needed.
6454
2baccd04 6455 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6456 Remove unused var.
dde42981 6457 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6458
72391843 6459 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6460
436c16df 6461 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6462 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6463 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6464
92bb796d 6465 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6466 (x_term_init): Remove local to avoid shadowing.
92bb796d 6467
764430a3 6468 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6469
6470 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6471 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6472
d1dfb56c
EZ
64732011-04-16 Eli Zaretskii <eliz@gnu.org>
6474
c4354cb4
EZ
6475 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6476
d1dfb56c
EZ
6477 Fix regex.c, syntax.c and friends for buffers > 2GB.
6478 * syntax.h (struct gl_state_s): Declare character position members
6479 EMACS_INT.
6480
6481 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6482
04f2d78b
CB
6483 * textprop.c (verify_interval_modification, interval_of):
6484 Declare arguments EMACS_INT.
d1dfb56c
EZ
6485
6486 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6487 EMACS_INT.
6488
6489 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6490
6491 * indent.c (Fvertical_motion): Local variable it_start is now
6492 EMACS_INT.
6493
6494 * regex.c (re_match, re_match_2, re_match_2_internal)
6495 (bcmp_translate, regcomp, regexec, print_double_string)
6496 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6497 (re_compile_pattern, re_exec): Declare arguments and local
6498 variables `size_t' and `ssize_t' and return values `regoff_t', as
6499 appropriate.
6500 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6501 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6502 <compile_stack_type>: `size' and `avail' are now `size_t'.
6503
6504 * regex.h <regoff_t>: Use ssize_t, not int.
6505 (re_search, re_search_2, re_match, re_match_2): Arguments that
6506 specify buffer/string position and length are now ssize_t and
6507 size_t. Return type is regoff_t.
6508
613052cd
BK
65092011-04-16 Ben Key <bkey76@gmail.com>
6510
6511 * nsfont.m: Fixed bugs in ns_get_family and
6512 ns_descriptor_to_entity that were caused by using free to
6513 deallocate memory blocks that were allocated by xmalloc (via
6514 xstrdup). This caused Emacs to crash when compiled with
6515 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6516 --enable-checking=xmallocoverrun). xfree is now used to
6517 deallocate these memory blocks.
6518
4170f62f 65192011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6520
71b41406
PE
6521 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6522
9587a89d
PE
6523 emacs_write: Accept and return EMACS_INT for sizes.
6524 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6525 et seq.
6526 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6527 Accept and return EMACS_INT.
6528 (emacs_gnutls_write): Return the number of bytes written on
6529 partial writes.
6530 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6531 (emacs_read, emacs_write): Remove check for negative size, as the
6532 Emacs source code has been audited now.
9587a89d
PE
6533 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6534 (emacs_read, emacs_write): Use it.
273a5f82
PE
6535 * process.c (send_process): Adjust to the new signatures of
6536 emacs_write and emacs_gnutls_write. Do not attempt to store
6537 a byte offset into an 'int'; it might overflow.
9587a89d 6538 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6539
3e047f51
PE
6540 * sound.c: Don't assume sizes fit in 'int'.
6541 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6542 Return EMACS_INT, not int.
3e047f51 6543 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6544 Accept EMACS_INT, not int.
6545 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6546 record read return values.
6547
cc39a9db
BK
65482011-04-15 Ben Key <bkey76@gmail.com>
6549
c9d0ec6d
JB
6550 * keyboard.c (Qundefined): Don't declare static since it is used
6551 in nsfns.m.
6552 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6553 static since they are used in nsfont.m.
cc39a9db 6554
6c60eb9f
SM
65552011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6556
6557 * process.c (Qprocessp): Don't declare static.
6558 * lisp.h (Qprocessp): Declare again.
6559
7990b61a
JB
65602011-04-15 Juanma Barranquero <lekktu@gmail.com>
6561
6562 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6563
5d4cb038
PE
65642011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6565
8bd7b830 6566 Improve C-level modularity by making more things 'static'.
cd64ea1d 6567
e3b27b31
PE
6568 Don't publish debugger-only interfaces to other modules.
6569 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6570 (verify_bytepos, count_markers): Move decls to the only modules
6571 that need them.
6572 * region-cache.h (pp_cache): Likewise.
6573 * window.h (check_all_windows): Likewise.
6574 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6575
5d4cb038
PE
6576 * sysdep.c (croak): Now static, if
6577 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6578 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6579
6580 * alloc.c (refill_memory_reserve): Now static if
6581 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6582 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6583
e87b6180
PE
6584 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6585 Define only if USE_LUCID.
6586
ac64929e
PE
6587 * xrdb.c (x_customization_string, x_rm_string): Now static.
6588
6f37259d
PE
6589 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6590 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6591
1683e3ab
PE
6592 * xdisp.c (draw_row_with_mouse_face): Now static.
6593 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6594
de9c2632
PE
6595 * window.h (check_all_windows): Mark externally visible.
6596
2b96acb7
PE
6597 * window.c (window_deletion_count): Now static.
6598
6599 * undo.c: Make symbols static if they're not exported.
6600 (last_undo_buffer, last_boundary_position, pending_boundary):
6601 Now static.
6602
50436f33
PE
6603 * textprop.c (interval_insert_behind_hooks): Now static.
6604 (interval_insert_in_front_hooks): Likewise.
6605
64520e5c
PE
6606 * term.c: Make symbols static if they're not exported.
6607 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6608 (max_frame_lines, tty_set_terminal_modes):
6609 (tty_reset_terminal_modes, tty_turn_off_highlight):
6610 (get_tty_terminal): Now static.
6611 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6612 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6613 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6614 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6615 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6616
1fa53021
PE
6617 * sysdep.c: Make symbols static if they're not exported.
6618 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6619 Now static.
6620 (sigprocmask_set, full_mask): Remove; unused.
6621 (wait_debugging): Mark as visible.
6622 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6623 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6624
d4b43b22
PE
6625 * syntax.c (syntax_temp): Define only if !__GNUC__.
6626
b7c513d0
PE
6627 * sound.c (current_sound_device, current_sound): Now static.
6628
989b29ad
PE
6629 * search.c (searchbufs, searchbuf_head): Now static.
6630
13a55a78
PE
6631 * scroll.c (scroll_cost): Remove; unused.
6632 * dispextern.h (scroll_cost): Remove decl.
6633
de68a1fc
PE
6634 * region-cache.h (pp_cache): Mark as externally visible.
6635
40ccffa6
PE
6636 * process.c: Make symbols static if they're not exported.
6637 (process_tick, update_tick, create_process, chan_process):
6638 (Vprocess_alist, proc_buffered_char, datagram_access):
6639 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6640 (deactivate_process): Mark defn as static, as well as decl.
6641 * lisp.h (create_process): Remove decl.
6642 * process.h (chan_process, Vprocess_alist): Remove decls.
6643
ad64fc97
PE
6644 * print.c: Make symbols static if they're not exported.
6645 (print_depth, new_backquote_output, being_printed, print_buffer):
6646 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6647 (print_interval, print_number_index, initial_stderr_stream):
6648 Now static.
6649 * lisp.h (Fprinc): Remove decl.
6650 (debug_output_compilation_hack): Mark as externally visible.
6651
adddb265
PE
6652 * sysdep.c (croak): Move decl from here to syssignal.h.
6653 * syssignal.h (croak): Put it here, so the API can be checked when
6654 'croak' is called from dissociate_if_controlling_tty.
6655
1717ede2
PE
6656 * minibuf.c: Make symbols static if they're not exported.
6657 (minibuf_save_list, choose_minibuf_frame): Now static.
6658 * lisp.h (choose_minibuf_frame): Remove decl.
6659
fa5fb2bc
PE
6660 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6661
1e3890d1
PE
6662 * lread.c: Make symbols static if they're not exported.
6663 (read_objects, initial_obarray, oblookup_last_bucket_number):
6664 Now static.
6665 (make_symbol): Remove; unused.
6666 * lisp.h (initial_obarray, make_symbol): Remove decls.
6667
8a1414fa
PE
6668 * keyboard.c: Make symbols static if they're not exported.
6669 (single_kboard, recent_keys_index, total_keys, recent_keys):
6670 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6671 (this_single_command_key_start, echoing, last_auto_save):
6672 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6673 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6674 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6675 (Vlispy_mouse_stem, double_click_count):
6676 Now static.
6677 (force_auto_save_soon): Define only if SIGDANGER.
6678 (ignore_mouse_drag_p): Now static if
6679 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6680 (print_help): Remove; unused.
6681 (stop_character, last_timer_event): Mark as externally visible.
6682 * keyboard.h (ignore_mouse_drag_p): Declare only if
6683 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6684 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6685 * lisp.h (echoing): Remove decl.
6686 (force_auto_save_soon): Declare only if SIGDANGER.
6687 * xdisp.c (redisplay_window): Simplify code, to make it more
6688 obvious that ignore_mouse_drag_p is not accessed if !defined
6689 USE_GTK && !defined HAVE_NS.
6690
93ea6e8f
PE
6691 * intervals.c: Make symbols static if they're not exported.
6692 (merge_properties_sticky, merge_interval_right, delete_interval):
6693 Now static.
6694 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6695
77382fcc
PE
6696 * insdel.c: Make symbols static if they're not exported.
6697 However, leave prepare_to_modify_buffer alone. It's never
6698 called from outside this function, but that appears to be a bug.
6699 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6700 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6701 (adjust_after_replace_noundo): Remove; unused.
6702 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6703 (signal_before_change): Remove decls.
77382fcc 6704
9306c32e
PE
6705 * indent.c (val_compute_motion, val_vmotion): Now static.
6706
cd44d2eb
PE
6707 * image.c: Make symbols static if they're not exported.
6708 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6709 if USE_GTK.
6710 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6711 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6712
ad9a7a06
PE
6713 * fringe.c (standard_bitmaps): Now static.
6714 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6715
81626931
PE
6716 * frame.c: Make symbols static if they're not exported.
6717 (x_report_frame_params, make_terminal_frame): Now static.
6718 (get_frame_param): Now static, unless HAVE_NS.
6719 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6720 (x_get_resource_string): Remove; not used.
6721 * frame.h (make_terminal_frame, x_report_frame_params):
6722 (x_get_resource_string); Remove decls.
6723 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6724 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6725
239f9db9
PE
6726 * font.c, fontset.c: Make symbols static if they're not exported.
6727 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6728 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6729 * font.c (font_close_object): Now static.
6730 * font.h (font_close_object): Remove.
6731 * fontset.c (FONTSET_OBJLIST): Remove.
6732 (free_realized_fontset) #if-0 the body, which does nothing.
6733 (face_suitable_for_char_p): #if-0, as it's never called.
6734 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6735 * xfaces.c (face_at_string_position):
6736 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6737 since 0 is always ASCII.
6738
dfcf3579
PE
6739 * fns.c (weak_hash_tables): Now static.
6740
5045092b
PE
6741 * fileio.c: Make symbols static if they're not exported.
6742 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6743 (Vwrite_region_annotation_buffers): Now static.
6744
57a96f5c
PE
6745 * eval.c: Make symbols static if they're not exported.
6746 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6747 * lisp.h (backtrace_list): Remove decl.
6748
35f08c38
PE
6749 * emacs.c: Make symbols static if they're not exported.
6750 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6751 (fatal_error_code, fatal_error_signal_hook, standard_args):
6752 Now static.
6753 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6754 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6755 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6756 * lisp.h (fatal_error_signal_hook): Remove decl.
6757 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6758
f44bd759
PE
6759 * editfns.c: Move a (normally-unused) function to its only use.
6760 * editfns.c, lisp.h (get_operating_system_release): Remove.
6761 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6762 worth the hassle of breaking this out.
6763
b532497d
PE
6764 * xterm.c: Make symbols static if they're not exported.
6765 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6766 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6767 (x_destroy_window, x_delete_display):
6768 Now static.
6769 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6770 (x_mouse_leave): Remove; unused.
6771 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6772 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6773 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6774 Remove decls.
6775 (x_mouse_leave): Declare only if WINDOWSNT.
6776 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6777 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6778 USE_X_TOOLKIT.
6779
1675728f
PE
6780 * ftxfont.c: Make symbols static if they're not exported.
6781 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6782 HAVE_FREETYPE.
6783 * font.h (ftxfont_driver): Likewise.
6784
e4cebfca
PE
6785 * xfns.c: Make symbols static if they're not exported.
6786 (x_last_font_name, x_display_info_for_name):
6787 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6788 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6789 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6790 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6791 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6792 (last_show_tip_args): Now static.
6793 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6794 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6795 (x_screen_planes): Remove; unused.
6796 * dispextern.h (x_screen_planes): Remove decl.
6797
5bf46f05
PE
6798 * dispnew.c: Make symbols static if they're not exported.
6799 * dispextern.h (redraw_garbaged_frames, scrolling):
6800 (increment_row_positions): Remove.
6801 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6802 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6803 Now static.
6804 (redraw_garbaged_frames): Remove; unused.
6805
435f4c28
PE
6806 * xfaces.c: Make symbols static if they're not exported.
6807 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6808 Remove decls.
6809 * xterm.h (defined_color): Remove decls.
6810 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6811 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6812 (menu_face_changed_default, defined_color, free_realized_face):
6813 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6814 (ascii_face_of_lisp_face): Remove; unused.
6815
8524aef3
PE
6816 * xdisp.c: Make symbols static if they're not exported.
6817 * dispextern.h (scratch_glyph_row, window_box_edges):
6818 (glyph_to_pixel_coords, set_cursor_from_row):
6819 (get_next_display_element, set_iterator_to_next):
6820 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6821 (show_mouse_face): Remove decls
6822 * frame.h (message_buf_print): Likewise.
6823 * lisp.h (pop_message, set_message, check_point_in_composition):
6824 Likewise.
6825 * xterm.h (set_vertical_scroll_bar): Likewise.
6826 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6827 (message_buf_print, scratch_glyph_row, displayed_buffer):
6828 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6829 (get_next_display_element, show_mouse_face, window_box_edges):
6830 (frame_to_window_pixel_xy, check_point_in_composition):
6831 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6832 (glyph_to_pixel_coords): Remove; unused.
6833
16390cd2
PE
6834 * dired.c (file_name_completion): Now static.
6835
6836 * dbusbind.c (xd_in_read_queued_messages): Now static.
6837
a25f4dfa
PE
6838 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6839 * data.c (circular_list_error): Remove.
6840
14a9c8df
PE
6841 * commands.h (last_point_position, last_point_position_buffer):
6842 (last_point_position_window): Remove decls.
6843 * keyboard.c: Make these variables static.
6844
04f2d78b
CB
6845 * coding.h (coding, code_convert_region, encode_coding_gap):
6846 Remove decls.
74ab6df5
PE
6847 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6848 (iso_code_class, detect_coding, code_convert_region): Now static.
6849 (encode_coding_gap): Remove; unused.
6850
38dfbee1
PE
6851 * chartab.c (chartab_chars, chartab_bits): Now static.
6852
a2cb4e63
PE
6853 * charset.h (charset_iso_8859_1): Remove decl.
6854 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6855 Now static.
6856
127198fd
PE
6857 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6858 * ccl.c (Vccl_program_table): Now static.
6859 (check_ccl_update): Remove; unused.
6860
d85b608f
PE
6861 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6862 * category.h: ... from here.
6863 * category.c (check_category_table, set_category_set): Now static.
6864
31cd66f3
PE
6865 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6866 * lisp.h: Remove these decls.
6867
c358e587
PE
6868 * buffer.c (buffer_count): Remove unused var.
6869
e78aecca
PE
6870 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6871 so that it's not optimized away.
6872 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6873 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6874 exported only to the debugger.
6875
e192d7d3 6876 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6877 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6878
92470028
PE
6879 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6880 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6881 was inaccessible from Lisp.
6882 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6883 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6884
244ed907
PE
6885 alloc.c: Import and export fewer symbols, and remove unused items.
6886 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6887 is defined.
6888 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6889 it's not optimized away by whole-program optimization.
6890 (message_enable_multibyte, free_misc): Remove.
6891 (catchlist, handlerlist, mark_backtrace):
6892 Declare only if BYTE_MARK_STACK.
6893 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6894 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6895 (message_enable_multibyte): Remove decl.
6896 (free_misc, interval_free_list, float_block, float_block_index):
6897 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6898 (cons_free_list, last_marked_index):
6899 Now static.
6900 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6901 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6902 (mark_backtrace): Define only if BYTE_MARK_STACK.
6903 * xdisp.c (message_enable_multibyte): Now static.
6904
61c2b50e 6905 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6906 This makes it easier for human readers (and static analyzers)
6907 to see whether these variables are used from other modules.
6908 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6909 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6910 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6911 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6912 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6913 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6914 * xmenu.c, xselect.c:
6915 Declare Q* vars static if they are not used in other modules.
6916 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6917 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6918 Remove decls of unexported vars.
6919 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6920
95c82688
PE
6921 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6922
16a97296
PE
6923 Make Emacs functions such as Fatom 'static' by default.
6924 This makes it easier for human readers (and static analyzers)
6925 to see whether these functions can be called from other modules.
6926 DEFUN now defines a static function. To make the function external
6927 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6928 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6929 (Finit_image_library):
16a97296
PE
6930 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6931 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6932 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6933 Remove decls, since these functions are now static.
6934 (Funintern, Fget_internal_run_time): New decls, since these functions
6935 were already external.
95c82688 6936
16a97296
PE
6937 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6938 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6939 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6940 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6941 * keyboard.c, keymap.c, lread.c:
6942 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6943 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6944 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6945 Mark functions with DEFUE instead of DEFUN,
6946 if they are used in other modules.
6947 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6948 decls for now-static functions.
6949 * buffer.h (Fdelete_overlay): Remove decl.
6950 * callproc.c (Fgetenv_internal): Mark as internal.
6951 * composite.c (Fremove_list_of_text_properties): Remove decl.
6952 (Fcomposition_get_gstring): New forward static decl.
6953 * composite.h (Fcomposite_get_gstring): Remove decl.
6954 * dired.c (Ffile_attributes): New forward static decl.
6955 * doc.c (Fdocumntation_property): New forward static decl.
6956 * eval.c (Ffetch_bytecode): New forward static decl.
6957 (Funintern): Remove extern decl; now in .h file where it belongs.
6958 * fileio.c (Fmake_symbolic_link): New forward static decl.
6959 * image.c (Finit_image_library): New forward static decl.
6960 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6961 * intervals.h (Fprevious_property_change):
6962 (Fremove_list_of_text_properties): Remove decls.
6963 * keyboard.c (Fthis_command_keys): Remove decl.
6964 (Fcommand_execute): New forward static decl.
6965 * keymap.c (Flookup_key): New forward static decl.
6966 (Fcopy_keymap): Now static.
6967 * keymap.h (Flookup_key): Remove decl.
6968 * process.c (Fget_process): New forward static decl.
6969 (Fprocess_datagram_address): Mark as internal.
6970 * syntax.c (Fsyntax_table_p): New forward static decl.
6971 (skip_chars): Remove duplicate decl.
6972 * textprop.c (Fprevious_property_change): New forward static decl.
6973 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6974 Now internal.
6975 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6976 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6977
785bbd42
PE
6978 * editfns.c (Fformat): Remove unreachable code.
6979
8b913b57
AS
69802011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6981
6982 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6983 change. (Bug#8496)
6984
a6744a35
EZ
69852011-04-13 Eli Zaretskii <eliz@gnu.org>
6986
6987 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6988 when at ZV. (Bug#8487)
6989
e7974947
AS
69902011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6991
baad03f0
AS
6992 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6993 (Bug#8437)
6994 * keyboard.c (parse_tool_bar_item): Likewise.
6995 * sound.c (sound_cleanup, alsa_close): Likewise.
6996 * termcap.c (tgetent): Likewise.
6997 * xfns.c (x_default_font_parameter): Likewise.
6998 * xsettings.c (read_and_apply_settings): Likewise.
6999
e7974947
AS
7000 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7001 (overrun_check_free): Protoize.
7002
28272684
PE
70032011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7004
7005 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7006 since callers should never pass a negative size.
7007 Change the signature to match that of plain 'read' and 'write'; see
7008 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7009 * lisp.h: Update prototypes of emacs_write and emacs_read.
7010
11997c76
EZ
70112011-04-11 Eli Zaretskii <eliz@gnu.org>
7012
7013 * xdisp.c (redisplay_window): Don't try to determine the character
7014 position of the scroll margin if the window start point w->startp
e896f03c 7015 is outside the buffer's accessible region. (Bug#8468)
11997c76 7016
8a2cbd72
EZ
70172011-04-10 Eli Zaretskii <eliz@gnu.org>
7018
7019 Fix write-region and its subroutines for buffers > 2GB.
7020 * fileio.c (a_write, e_write): Modify declaration of arguments and
7021 local variables to support buffers larger than 2GB.
7022 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7023
7024 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7025 argument, local variables, and return value.
7026
7027 * lisp.h: Update prototypes of emacs_write and emacs_read.
7028
7029 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7030
4073e537 70312011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7032
1ebfdcb6
PE
7033 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7034
b2ded58d
PE
7035 Fix more problems found by GCC 4.6.0's static checks.
7036
7d66342c
PE
7037 * xdisp.c (vmessage): Use a better test for character truncation.
7038
bbf47d44
PE
7039 * charset.c (load_charset_map): <, not <=, for optimization,
7040 and to avoid potential problems with integer overflow.
9248994d 7041 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7042 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7043 * editfns.c (Fformat): Likewise.
1e69125e 7044 * syntax.c (skip_chars): Likewise.
3befa583 7045
e3019616
PE
7046 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7047 This also lets GCC 4.6.0 generate slightly better loop code.
7048
becfa255
PE
7049 * callint.c (Fcall_interactively): <, not <=, for optimization.
7050 (Fcall_interactively): Count the number of arguments produced,
7051 not the number of arguments given. This is simpler and lets GCC
7052 4.6.0 generate slightly better code.
7053
dae0cd48
PE
7054 * ftfont.c: Distingish more carefully between FcChar8 and char.
7055 The previous code passed unsigned char * to a functions like
7056 strlen and xstrcasecmp that expect char *, which does not
7057 conform to the C standard.
7058 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7059 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7060 char * when the C standard requires it.
7061
76032d70
PE
7062 * keyboard.c (read_char): Remove unused var.
7063
eb3f1cc8
PE
7064 * eval.c: Port to Windows vsnprintf (Bug#8435).
7065 Include <limits.h>.
7066 (SIZE_MAX): Define if the headers do not.
7067 (verror): Do not give up if vsnprintf returns a negative count.
7068 Instead, grow the buffer. This ports to Windows vsnprintf, which
7069 does not conform to C99. Problem reported by Eli Zaretskii.
7070 Also, simplify the allocation scheme, by avoiding the need for
7071 calling realloc, and removing the ALLOCATED variable.
7072
70476b54
PE
7073 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7074
12020a9e
PE
7075 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7076 But keep the doprint source code for now, as we might revamp it
7077 and use it again (Bug#8435).
ea6c7ae6
PE
7078 * lisp.h (doprnt): Remove.
7079 * Makefile.in (base_obj): Remove doprnt.o.
7080 * deps.mk (doprnt.o): Remove.
7081
5fdb398c
PE
7082 error: Print 32- and 64-bit integers portably (Bug#8435).
7083 Without this change, on typical 64-bit hosts error ("...%d...", N)
7084 was used to print both 32- and 64-bit integers N, which relied on
7085 undefined behavior.
7086 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7087 New macro.
7088 * lisp.h (error, verror): Mark as printf-like functions.
7089 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7090 Report overflow in size calculations when allocating printf buffer.
7091 Do not truncate output string at its first null byte.
7092 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7093 Truncate the output at a character boundary, since vsnprintf does not
7094 do that.
7095 * charset.c (check_iso_charset_parameter): Convert internal
7096 character to string before calling 'error', since %c now has the
7097 printf meaning.
7098 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7099 overflow when computing char to be passed to 'error'. Do not
7100 pass Lisp_Object to 'error'; pass the integer instead.
7101 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7102 formatted with plain %d.
7103
b189fa66
PE
7104 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7105
bff87ef0
PE
7106 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7107
7e2cac20
PE
7108 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7109
ce4d90b5
PE
7110 * xterm.c (x_catch_errors): Remove duplicate declaration.
7111
266c9547
PE
7112 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7113
79c49ad2
PE
7114 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7115
368f4090
JM
71162011-04-10 Jim Meyering <meyering@redhat.com>
7117
7118 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7119 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7120 return ssize_t not "int", and use size_t as the buffer length.
7121 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7122 * gnutls.h: Update declarations.
7123 * process.c (read_process_output): Use ssize_t, to match.
7124 (send_process): Likewise.
7125
a32d4040
CY
71262011-04-09 Chong Yidong <cyd@stupidchicken.com>
7127
7128 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7129
8546720e 71302011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7131
04f2d78b
CB
7132 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7133 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7134
8546720e
GM
7135 * xterm.c (handle_one_xevent):
7136 * xmenu.c (create_and_show_popup_menu):
7137 * xselect.c (x_decline_selection_request)
7138 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7139
0a2f5c1a 71402011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7141
7142 Fix some uses of `int' instead of EMACS_INT.
7143 * search.c (string_match_1, fast_string_match)
7144 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7145 (scan_buffer, find_next_newline_no_quit)
7146 (find_before_next_newline, search_command, Freplace_match)
7147 (Fmatch_data): Make some `int' variables be EMACS_INT.
7148
7149 * xdisp.c (display_count_lines): 3rd argument and return value now
7150 EMACS_INT. All callers changed.
7151 (pint2hrstr): Last argument is now EMACS_INT.
7152
7153 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7154 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7155 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7156 (decode_coding_utf_16, decode_coding_emacs_mule)
7157 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7158 (decode_coding_ccl, decode_coding_charset)
7159 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7160 (decode_coding_iso_2022, decode_coding_emacs_mule)
7161 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7162 <char_offset, last_offset>: Declare EMACS_INT.
7163 (encode_coding_utf_8, encode_coding_utf_16)
7164 (encode_coding_emacs_mule, encode_invocation_designation)
7165 (encode_designation_at_bol, encode_coding_iso_2022)
7166 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7167 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7168 Declare EMACS_INT.
7169 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7170 (encode_invocation_designation): Last argument P_NCHARS is now
7171 EMACS_INT.
7172 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7173 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7174
7175 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7176 All users changed.
7177
7178 * ccl.c (Fccl_execute_on_string): Declare some variables
7179 EMACS_INT.
7180
8546720e 71812011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7182
7183 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7184
4e19a977
CS
71852011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7186
7187 * process.c (Fformat_network_address): Doc fix.
7188
87302331
R
71892011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7190
ee7683eb 7191 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7192
cbb59342
CY
71932011-04-08 Chong Yidong <cyd@stupidchicken.com>
7194
7195 * keyboard.c (read_char): Call Lisp function help-form-show,
7196 instead of using internal_with_output_to_temp_buffer.
7197 (Qhelp_form_show): New var.
e0d38eeb 7198 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7199
7200 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7201
7202 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7203
e67a13ab
CY
72042011-04-06 Chong Yidong <cyd@stupidchicken.com>
7205
04f2d78b
CB
7206 * process.c (Flist_processes): Remove to Lisp.
7207 (list_processes_1): Delete.
e67a13ab 7208
973f782d
EZ
72092011-04-06 Eli Zaretskii <eliz@gnu.org>
7210
7c106b1e
EZ
7211 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7212
973f782d
EZ
7213 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7214
41cf7d1a 72152011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7216
ca23cc88
PE
7217 Fix more problems found by GCC 4.6.0's static checks.
7218
f390e2d5
PE
7219 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7220
42eea0d0
PE
7221 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7222
b69769da 7223 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7224
f9541e84
PE
7225 * xdisp.c (vmessage): Mark as a printf-like function.
7226
13841b55
PE
7227 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7228
c136c10f
PE
7229 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7230
5e2d4a30
PE
7231 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7232 printf-like functions.
7233 (tiff_load): Add casts to remove these marks before passing them
7234 to system-supplied API.
7235
583f48b9
PE
7236 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7237
b25d760e
PE
7238 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7239 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7240 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7241 directly, rather than having caller test rule sign. This avoids
7242 some unnecessary tests.
7243 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7244 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7245 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7246
bc7b6697 7247 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7248 (xfont_open): Avoid unnecessary tests.
bc7b6697 7249
27ccc379
PE
7250 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7251
dcd5c89a
PE
7252 * composite.h, composite.c (composition_gstring_put_cache):
7253 Use EMACS_INT, not int, for length.
7254
b13a45c6
PE
7255 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7256 breaking out part of COMPOSITION_DECODE_RULE.
7257 (COMPOSITION_DECODE_RULE): Use it.
7258 * composite.c (get_composition_id): Remove unused local vars,
7259 by using the new macro.
7260
1e792e4d
PE
7261 * textprop.c (set_text_properties_1): Change while to do-while,
7262 since the condition is always true at first.
7263
dc6c6455 7264 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7265 (interval_deletion_adjustment): Return unsigned value.
7266 All uses changed.
dc6c6455 7267
aba7731a
PE
7268 * process.c (list_processes_1, create_pty, read_process_output):
7269 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7270 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7271 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7272 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7273 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7274
fdfc4bf3
PE
7275 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7276
fca8fe46 7277 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7278 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7279
06a0259a 7280 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7281 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7282 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7283
e7b9e80f
PE
7284 * print.c (print_error_message): Avoid int overflow.
7285
56201685
PE
7286 * font.c (font_list_entities): Redo for clarity,
7287 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7288
78834453 7289 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7290 (font_score): Avoid potential overflow in diff calculation.
78834453 7291
0bc0b309 7292 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7293 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7294
e610eaca
PE
7295 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7296
b895abce
PE
7297 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7298 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7299 can always succeed if overflow has undefined behavior.
7300
1f1d9321 7301 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7302 (wordify): Omit three unnecessary tests.
1f1d9321 7303
c59478bc
PE
7304 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7305 All callers changed. This avoids the need for an unused var.
7306
79b73827
PE
7307 * casefiddle.c (casify_region): Remove var that is set but not used.
7308
a4db5dfe
PE
7309 * dired.c (file_name_completion): Remove var that is set but not used.
7310
43aae36e
PE
7311 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7312
2a47c44d 7313 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7314 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7315
a37c69bf
PE
7316 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7317 Check for integer overflow on size calculations.
7318
328ab8e7
PE
7319 * buffer.c (Fprevious_overlay_change): Remove var that is set
7320 but not used.
7321
e5a2a5cb
PE
7322 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7323 Remove vars that are set but not used.
8d84a6eb 7324 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7325 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7326
a60e5f68
PE
7327 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7328
f661cb61 7329 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7330 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7331
f0397f5a
PE
7332 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7333 that are set but not used.
7334
8664db06 7335 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7336 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7337
6abdaa4a
PE
7338 * xselect.c (x_get_local_selection, x_handle_property_notify):
7339 Remove vars that are set but not used.
7340
0ce7538d 7341 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7342 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7343
9ae848fc
PE
7344 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7345 Remove var that is set but not used.
0b918413
PE
7346 (scroll_bar_windows_size): Now size_t, not int.
7347 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7348 Check for overflow.
9ae848fc 7349
a5a62657
PE
7350 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7351 (map_tty_color) [!defined MSDOS]: Likewise.
7352
5c5cdd39
PE
7353 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7354
66ebf983
PE
7355 * coding.c: Remove vars that are set but not used.
7356 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7357 All callers changed.
7358 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7359 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7360 (decode_coding_charset): Remove vars that are set but not used.
7361
1be4d761
PE
7362 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7363 that is set but not used.
7364
47553fa8
PE
7365 * print.c (print_object): Remove var that is set but not used.
7366
1f7196bf 7367 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7368 The gnulib version avoids calling malloc in the usual case,
7369 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7370 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7371 * filelock.c (current_lock_owner): Likewise.
7372 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7373 * sysdep.c: Include allocator.h, careadlinkat.h.
7374 (emacs_no_realloc_allocator): New static constant.
7375 (emacs_readlink): New function.
fdb61804
PE
7376 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7377 ../lib/careadlinkat.h.
d1fdcab7 7378
f84c17c7
SM
73792011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7380
7381 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7382 first non-nil return value).
7383
ef3862ad
JD
73842011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7385
7386 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7387 if not defined (Bug#8403).
7388
376a7006
JB
73892011-04-02 Juanma Barranquero <lekktu@gmail.com>
7390
7391 * xdisp.c (display_count_lines): Remove parameter `start',
7392 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7393 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7394 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7395 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7396 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7397 and thereabouts. All callers changed.
7398 (get_per_char_metric): Remove parameter `f', unused since
7399 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7400
6ca3801d
JM
74012011-04-02 Jim Meyering <meyering@redhat.com>
7402
7403 do not dereference NULL upon failed strdup
7404 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7405 (ns_get_family): Likewise.
7406
d8e2b5ba
JB
74072011-04-02 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7410
8c74fcbd
JD
74112011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7412
7413 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7414 later (Bug#8403).
7415
7200d79c
SM
74162011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7417
03408648 7418 Add lexical binding.
7200d79c 7419
03408648
SM
7420 * window.c (Ftemp_output_buffer_show): New fun.
7421 (Fsave_window_excursion):
7422 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7423
7424 * lread.c (lisp_file_lexically_bound_p): New function.
7425 (Fload): Bind Qlexical_binding.
7426 (readevalloop): Remove `evalfun' arg.
7427 Bind Qinternal_interpreter_environment.
7428 (Feval_buffer): Bind Qlexical_binding.
7429 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7430 Mark as dynamic.
7431 (syms_of_lread): Declare `lexical-binding'.
7432
7433 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7434
7435 * keyboard.c (eval_dyn): New fun.
7436 (menu_item_eval_property): Use it.
ca105506
SM
7437
7438 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7439
03408648
SM
7440 * fns.c (concat, mapcar1): Accept byte-code-functions.
7441
7442 * eval.c (Fsetq): Handle lexical vars.
7443 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7444 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7445 (FletX, Flet): Obey lexical binding.
7446 (Fcommandp): Handle closures.
7447 (Feval): New `lexical' arg.
7448 (eval_sub): New function extracted from Feval. Use it almost
7449 everywhere where Feval was used. Look up vars in lexical env.
7450 Handle closures.
7451 (Ffunctionp): Move from subr.el.
7452 (Ffuncall): Handle closures.
7453 (apply_lambda): Remove `eval_flags'.
7454 (funcall_lambda): Handle closures and new byte-code-functions.
7455 (Fspecial_variable_p): New function.
7456 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7457 but without exporting it to Lisp.
23aba0ea 7458
23aba0ea 7459 * doc.c (Fdocumentation, store_function_docstring):
03408648 7460 * data.c (Finteractive_form): Handle closures.
23aba0ea 7461
03408648
SM
7462 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7463 interactive spec.
ba83908c 7464
04f2d78b
CB
7465 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7466 New byte-codes.
03408648
SM
7467 (exec_byte_code): New function extracted from Fbyte_code to handle new
7468 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7469
03408648 7470 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7471
03408648 7472 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7473
e2abce01
JB
74742011-03-31 Juanma Barranquero <lekktu@gmail.com>
7475
7476 * xdisp.c (redisplay_internal): Fix prototype.
7477
63696a73 74782011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7479
63696a73 7480 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7481 (try_scrolling): Use it when setting scroll_limit.
7482 Limit scrolling to 100 screen lines.
63696a73
EZ
7483 (redisplay_window): Even when falling back on "recentering",
7484 position point in the window according to scroll-conservatively,
7485 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7486
7487 (try_scrolling): When point is above the window, allow searching
7488 as far as scroll_max, or one screenful, to compute vertical
7489 distance from PT to the scroll margin position. This prevents
7490 try_scrolling from unnecessarily failing when
7491 scroll-conservatively is set to a value slightly larger than the
7492 window height. Clean up the case of PT below the margin at bottom
7493 of window: scroll_max can no longer be INT_MAX. When aggressive
7494 scrolling is in use, don't let point enter the opposite scroll
7495 margin as result of the scroll.
7496 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7497 threshold of 100 lines for never-recentering scrolling.
7498
e4cc2dfc
JB
74992011-03-31 Juanma Barranquero <lekktu@gmail.com>
7500
7501 * dispextern.h (move_it_by_lines):
7502 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7503 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7504 (message_log_check_duplicate): Remove parameters `prev_bol' and
7505 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7506 (redisplay_internal): Remove parameter `preserve_echo_area',
7507 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7508
7509 * indent.c (Fvertical_motion):
7510 * window.c (window_scroll_pixel_based, Frecenter):
7511 Don't pass `need_y_p' to `move_it_by_lines'.
7512
1c470562
SM
75132011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7514
44f230aa
SM
7515 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7516 steal a few bits to be more compact.
7517 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7518 Remove unneeded casts.
7519
1c470562
SM
7520 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7521
888adce9
ZK
75222011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7523
7524 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7525 binding" message (bug#7967).
7526
f838ed7b
PE
75272011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7528
77861b95
PE
7529 Fix more problems found by GCC 4.6.0's static checks.
7530
de6dbc14
PE
7531 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7532 Remove unused local var.
7533
f838ed7b
PE
7534 * editfns.c (Fmessage_box): Remove unused local var.
7535
792c7b2b
PE
7536 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7537 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7538 Omit unused local vars.
c499e557 7539 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7540 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7541 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7542 Omit unused local var.
7543
ba0165e1
PE
7544 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7545 Don't assume string length fits in int.
32ad8845 7546 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7547 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7548
3c59b4c9
PE
7549 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7550 instead of alloca (Bug#8344).
7551
a3eed478 7552 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7553 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7554
eb4d412d
PE
7555 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7556
1658b401
PE
7557 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7558 concerns.
7559
7560 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7561
7562 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7563
9a2c6e05
PE
7564 * keyboard.c (syms_of_keyboard): Use the same style as later
7565 in this function when indexing through an array. This also
7566 works around GCC bug 48267.
7567
03d0a109
PE
7568 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7569
44f730c8
PE
7570 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7571
fe75f926
PE
7572 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7573 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7574
ffa8c828
PE
7575 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7576 This avoids undefined behavior on integer overflow, and is a bit
7577 more convenient anyway since it is compared to a size_t variable.
7578
c5101a77
PE
7579 Variadic C functions now count arguments with size_t, not int.
7580 This avoids an unnecessary limitation on 64-bit machines, which
7581 caused (substring ...) to crash on large vectors (Bug#8344).
7582 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7583 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7584 All variadic functions and their callers changed accordingly.
c5101a77
PE
7585 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7586 * data.c (arith_driver, float_arith_driver): Likewise.
7587 * editfns.c (general_insert_function): Likewise.
7588 * eval.c (struct backtrace.nargs, interactive_p)
7589 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7590 (funcall_lambda, mark_backtrace): Likewise.
7591 * fns.c (concat): Likewise.
7592 * frame.c (x_set_frame_parameters): Likewise.
7593 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7594 0 if not found, not -1. All callers changed.
7595
dd3f25f7
PE
7596 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7597 (stack_copy_size): Now size_t, not int.
7598 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7599
461c2ab9
JB
76002011-03-28 Juanma Barranquero <lekktu@gmail.com>
7601
7602 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7603 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7604 All callers changed.
7605
7606 * lisp.h (multibyte_char_to_unibyte):
7607 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7608 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7609 * character.h (CHAR_TO_BYTE8):
7610 * cmds.c (internal_self_insert):
7611 * editfns.c (general_insert_function):
7612 * keymap.c (push_key_description):
7613 * search.c (Freplace_match):
7614 * xdisp.c (message_dolog, set_message_1): All callers changed.
7615
f6d62986
SM
76162011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7617
7618 * keyboard.c (safe_run_hook_funcall): New function.
7619 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7620 don't set the hook to nil, but remove the offending function instead.
7621 (Qcommand_hook_internal): Remove, unused.
7622 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7623 Vcommand_hook_internal.
7624
7625 * eval.c (enum run_hooks_condition): Remove.
7626 (funcall_nil, funcall_not): New functions.
7627 (run_hook_with_args): Call each function through a `funcall' argument.
7628 Remove `cond' argument, now redundant.
7629 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7630 (Frun_hook_with_args_until_failure): Adjust accordingly.
7631 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7632
1db5b1ad
JB
76332011-03-28 Juanma Barranquero <lekktu@gmail.com>
7634
7635 * dispextern.h (string_buffer_position): Remove declaration.
7636
7637 * print.c (strout): Remove parameter `multibyte', unused since
7638 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7639
7640 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7641 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7642 All callers changed.
7643
7644 * w32.c (_wsa_errlist): Use braces for struct initializers.
7645
7646 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7647 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7648 All callers changed.
7649 (string_buffer_position): Likewise. Also, make static (it's never
7650 used outside xdisp.c).
7651 (cursor_row_p): Remove parameter `w', unused since
7652 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7653 (decode_mode_spec): Remove parameter `precision', introduced during
7654 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7655 All callers changed.
7656
5ffb62aa
JD
76572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7658
7659 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7660
461c2ab9 76612011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7662
7663 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7664 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7665 (ns_update_auto_hide_menu_bar): New functions.
7666 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7667 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7668 ns_constrain_all_frames.
7669 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7670 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7671
5c380ffb
JD
76722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7673
7674 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7675
9af30bdf
GM
76762011-03-27 Glenn Morris <rgm@gnu.org>
7677
7678 * syssignal.h: Replace RETSIGTYPE with void.
7679 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7680 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7681 Replace SIGTYPE with void everywhere.
7682 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7683 * s/template.h (SIGTYPE): Remove commented out definition.
7684
e2abce01
JB
76852011-03-26 Eli Zaretskii <eliz@gnu.org>
7686
7687 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7688 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7689
f868cd8a
JB
76902011-03-26 Juanma Barranquero <lekktu@gmail.com>
7691
59eb0929
JB
7692 * w32.c (read_unc_volume): Use parameter `henum', instead of
7693 global variable `wget_enum_handle'.
7694
7695 * keymap.c (describe_vector): Remove parameters `indices' and
7696 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7697 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7698
f868cd8a
JB
7699 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7700
7701 * keyboard.c (timer_check): Remove parameter `do_it_now',
7702 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7703 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7704 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7705
7706 * keyboard.c (read_char):
7707 * w32menu.c (w32_menu_display_help):
7708 * xmenu.c (show_help_event, menu_help_callback):
7709 Adjust calls to `show_help_echo'.
7710
7711 * gtkutil.c (xg_maybe_add_timer):
7712 * keyboard.c (readable_events):
7713 * process.c (wait_reading_process_output):
7714 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7715
7716 * insdel.c (adjust_markers_gap_motion):
7717 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7718 (gap_left, gap_right): Don't call it.
7719
2ecf6fdb
CY
77202011-03-25 Chong Yidong <cyd@stupidchicken.com>
7721
7722 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7723 incurred during fontification.
7724
6b1f9ba4
JB
77252011-03-25 Juanma Barranquero <lekktu@gmail.com>
7726
7727 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7728 (DEFVAR_PER_BUFFER): Don't pass it.
7729
7730 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7731 (scrolling_window): Don't pass it.
7732
0f4a96b5
JB
77332011-03-25 Juanma Barranquero <lekktu@gmail.com>
7734
7735 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7736
7737 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7738 and `suffix'.
7739 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7740 of variables specific to SELinux and computation of `encoded_absname'.
7741
7742 * image.c (XPutPixel): Remove unused variable `height'.
7743
7744 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7745
7746 * unexw32.c (get_section_info): Remove unused variable `section'.
7747
7748 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7749 (system_process_attributes): Remove unused variable `sess'.
7750 (sys_read): Remove unused variable `err'.
7751
7752 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7753 (w32_wnd_proc): Remove unused variable `isdead'.
7754 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7755 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7756 (x_create_tip_frame): Remove unused variable `tem'.
7757
7758 * w32inevt.c (w32_console_read_socket):
7759 Remove unused variable `no_events'.
7760
7761 * w32term.c (x_draw_composite_glyph_string_foreground):
7762 Remove unused variable `width'.
7763
1149507c
JB
77642011-03-24 Juanma Barranquero <lekktu@gmail.com>
7765
7766 * w32term.c (x_set_glyph_string_clipping):
7767 Don't pass uninitialized region to CombineRgn.
7768
9c88f339
JB
77692011-03-23 Juanma Barranquero <lekktu@gmail.com>
7770
7771 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7772 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7773 (Fx_close_connection): Remove unused variable `i'.
7774
7775 * w32font.c (w32font_draw): Return number of glyphs.
7776 (w32font_open_internal): Remove unused variable `i'.
7777 (w32font_driver): Add missing initializer.
7778
7779 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7780 (fill_in_menu): Remove unused variable `items_added'.
7781
7782 * w32term.c (last_mouse_press_frame): Remove static global variable.
7783 (w32_clip_to_row): Remove unused variable `f'.
7784 (x_delete_terminal): Remove unused variable `i'.
7785
7786 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7787 (NOTHING): Remove unused static global variable.
7788 (uniscribe_check_otf): Remove unused variable `table'.
7789 (uniscribe_font_driver): Add missing initializers.
7790
dee091a3
JD
77912011-03-23 Julien Danjou <julien@danjou.info>
7792
7793 * term.c (Fsuspend_tty, Fresume_tty):
7794 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7795 * window.c (temp_output_buffer_show):
7796 * insdel.c (signal_before_change):
7797 * frame.c (Fhandle_switch_frame):
7798 * fileio.c (Fdo_auto_save):
7799 * emacs.c (Fkill_emacs):
7800 * editfns.c (save_excursion_restore):
7801 * cmds.c (internal_self_insert):
7802 * callint.c (Fcall_interactively):
7803 * buffer.c (Fkill_all_local_variables):
7804 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7805 Use Frun_hooks.
0f4a96b5 7806 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7807 unconditionally since it does the check itself.
dee091a3 7808
2c520ab5 78092011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7810
c9c49752
PE
7811 Fix more problems found by GCC 4.5.2's static checks.
7812
8abc3f12
PE
7813 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7814 the first time through the loop, since we know p0 < p1 then.
7815 This also avoids a gcc -Wstrict-overflow warning.
7816
a2d26660
PE
7817 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7818 leading to a memory leak, possible in functions like
7819 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7820 of objects (Bug#8318).
a2d26660 7821
916c72e9
PE
7822 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7823 that could (at least in theory) be that large.
7824
19ab8a18
PE
7825 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7826 This is less likely to overflow, and avoids undefined behavior if
7827 overflow does occur. All callers changed. Use strtoul to scan
7828 for the unsigned long integer.
b7cbbd6f
PE
7829 (pint2hrstr): Simplify and tune code slightly.
7830 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7831
f0641eff
PE
7832 * scroll.c (do_scrolling): Work around GCC bug 48228.
7833 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7834
7f650bb9
PE
7835 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7836 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7837 (validate_x_resource_name): Simplify count usage.
7838 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7839
37dd57d1
PE
7840 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7841 fail (Bug#8306).
81e56e61 7842
699979fc 7843 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7844
401bf9b4
PE
7845 * process.c (Fmake_network_process): Use socklen_t, not int,
7846 where POSIX says socklen_t is required in portable programs.
7847 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7848 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7849 (Fmake_network_process, server_accept_connection):
7850 (wait_reading_process_output, read_process_output):
7851 Likewise.
7852
b93aacde
PE
7853 * process.c: Rename or move locals to avoid shadowing.
7854 (list_processes_1, Fmake_network_process):
7855 (read_process_output_error_handler, exec_sentinel_error_handler):
7856 Rename or move locals.
4dc343ee 7857 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7858 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7859 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7860 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7861 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7862
af8a867c 7863 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7864 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7865 Include tparam.h instead, since it declares them.
af8a867c
PE
7866 * cm.h (PC): Remove extern decl; tparam.h now does this.
7867 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7868 * terminfo.c: Include tparam.h, to check interfaces.
7869 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7870 (tparam): Adjust signature to match interface in tparam.h;
7871 this removes some undefined behavior. Check that outstring and len
7872 are zero, which they always are with Emacs.
7873 * tparam.h (PC, BC, UP): New extern decls.
7874
0248044d 7875 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7876 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7877
8ff096c1 7878 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7879 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7880 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7881 (ftfont_list): Remove unused local.
49eaafba
PE
7882 (get_adstyle_property, ftfont_pattern_entity):
7883 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7884 Rename locals to avoid shadowing.
8ff096c1 7885
e2be39f6
PE
7886 * xfont.c (xfont_list_family): Mark var as initialized.
7887
c9735e30
PE
7888 * xml.c (make_dom): Now static.
7889
8f5201ae
PE
7890 * composite.c (composition_compute_stop_pos): Rename local to
7891 avoid shadowing.
b246f932
PE
7892 (composition_reseat_it): Remove unused locals.
7893 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7894 (composition_update_it): Mark var as initialized.
11b61122
PE
7895 (find_automatic_composition): Mark vars as initialized,
7896 with a FIXME (Bug#8290).
8f5201ae 7897
760fbc2c
PE
7898 character.h: Rename locals to avoid shadowing.
7899 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7900 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7901 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7902 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7903 to avoid shadowing.
7904
ff08eb85
PE
7905 * textprop.c (property_change_between_p): Remove; unused.
7906
fc7bf025
PE
7907 * intervals.c (interval_start_pos): Now static.
7908
235d7abc
PE
7909 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7910
44f230aa
SM
7911 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7912 Rename locals to avoid shadowing.
3e7d6594 7913
50060332
PE
7914 * sound.c (wav_play, au_play, Fplay_sound_internal):
7915 Fix pointer signedness.
d01f234b 7916 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7917 (wav_play): Initialize a variable to 0, to prevent undefined
7918 behavior (Bug#8278).
50060332 7919
c4fc4e30
PE
7920 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7921
918436ed
PE
7922 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7923
c939f91b
PE
7924 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7925 clobbering (Bug#8298).
b9c7f648
PE
7926 * sysdep.c (sys_subshell): Likewise.
7927 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7928
6bd8c144
PE
7929 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7930 This should get cleaned up, so that child_setup has the
7931 same signature on all platforms.
7932
7710357c 7933 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7934 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7935
c59da222
CY
79362011-03-22 Chong Yidong <cyd@stupidchicken.com>
7937
7938 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7939 not to be necessary, and produces flickering.
7940
66b87493
GM
79412011-03-20 Glenn Morris <rgm@gnu.org>
7942
7943 * config.in: Remove file.
7944
45b6f6d5
JB
79452011-03-20 Juanma Barranquero <lekktu@gmail.com>
7946
7947 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7948 are now in src/globals.h.
7949 (syms_of_minibuf): Remove spurious & from previous change.
7950
3ec03f7e
LL
79512011-03-20 Leo <sdl.web@gmail.com>
7952
7953 * minibuf.c (completing-read-function): New variable.
7954 (completing-read-default): Rename from completing-read.
7955 (completing-read): Call completing-read-function.
7956
b14e3e21
CY
79572011-03-19 Juanma Barranquero <lekktu@gmail.com>
7958
7959 * xfaces.c (Fx_load_color_file):
7960 Read color file from absolute filename (bug#8250).
7961
f2b726e6
JB
79622011-03-19 Juanma Barranquero <lekktu@gmail.com>
7963
7964 * makefile.w32-in: Update dependencies.
7965
09f6ff02
EZ
79662011-03-17 Eli Zaretskii <eliz@gnu.org>
7967
7968 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7969
29a6015a
PE
79702011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7971
a3a6c54e
PE
7972 Fix more problems found by GCC 4.5.2's static checks.
7973
b766f867
PE
7974 * process.c (make_serial_process_unwind, send_process_trap):
7975 (sigchld_handler): Now static.
7976
be02381c
PE
7977 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7978 That way, the code declares only the vars that it needs.
7979 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7980 * s/cygwin.h (PTY_ITERATION): Likewise.
7981 * s/darwin.h (PTY_ITERATION): Likewise.
7982 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7983
57048744
PE
7984 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7985 * process.c (allocate_pty): Don't declare stb unless it's needed.
7986
7914961c 7987 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7988 (CONSTANTLIM): Remove; unused.
7989 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7990 Define only if needed.
7914961c 7991
b3967b18
PE
7992 * unexelf.c (unexec): Name an expression,
7993 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7994 Use a different way to cause a compilation error if anyone uses
7995 n rather than nn, a way that does not involve shadowing.
73366a00 7996 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7997
29a6015a
PE
7998 * deps.mk (unexalpha.o): Remove; unused.
7999
43cfc33e 8000 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8001 * unexec.h: New file.
ce701a33
PE
8002 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8003 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8004 Depend on unexec.h.
8005 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8006 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8007 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8008 Change as necessary to match prototype in unexec.h.
ce701a33 8009
01f44d5a
PE
8010 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8011 shadowing.
4f63c6bb 8012 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8013
a6670b0b
PE
8014 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8015 Rename locals to avoid shadowing.
8016
cef2010d 8017 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8018 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8019
d4d7173a
PE
8020 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8021
f08b802a
PE
8022 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8023 warning when compiling print.c.
8024
3ddb0639
PE
8025 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8026 instead of using an uninitialized var.
5ad03b97 8027 (font_sort_entities): Mark var as initialized.
3ddb0639 8028
170a2692
PE
8029 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8030
e663c700
PE
8031 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8032 pointers to constants.
89bc529a 8033 (font_parse_fcname): Remove unused vars.
7b81e2d0 8034 (font_delete_unmatched): Now static.
ea838e10 8035 (font_get_spec): Remove; unused.
13a547c6
PE
8036 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8037 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8038 Rename or move locals to avoid shadowing.
e663c700 8039
2a80c887 8040 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8041 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8042
1384fa33 8043 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8044 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8045
8b2c52e9
PE
8046 * alloc.c (mark_backtrace): Move decl from here ...
8047 * lisp.h: ... to here, so that it can be checked.
8048
475545b5 8049 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8050 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8051 (lisp_indirect_variable): Name an expression,
8052 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8053 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8054
b1349114 8055 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8056 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8057 Use const pointer when appropriate.
b1349114 8058
a2928364
PE
8059 * lisp.h (get_system_name, get_operating_system_release):
8060 Move decls here, to check interfaces.
8061 * process.c (get_operating_system_release): Move decl to lisp.h.
8062 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8063 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8064 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8065 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8066 (Fformat_time_string, Fencode_time, Finsert_char):
8067 (Ftranslate_region_internal, Fformat):
8068 Rename or remove local vars to avoid shadowing.
9710023e 8069 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8070
a415e694
PE
8071 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8072 avoid shadowing.
8073
8ef4622d
PE
8074 * lisp.h (eassert): Check that the argument compiles, even if
8075 ENABLE_CHECKING is not defined.
8076
946f9a5b
PE
8077 * data.c (Findirect_variable): Name an expression, to avoid
8078 gcc -Wbad-function-cast warning.
112396d6 8079 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8080 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8081 (Fmake_variable_buffer_local, Fmake_local_variable):
8082 Mark variables as initialized.
52746918 8083 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8084
e5aab7e7 8085 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8086 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8087 Rename locals to avoid shadowing.
dff45157
PE
8088 (mark_stack): Move local variables into the #ifdef region where
8089 they're used.
7bc26fdb
PE
8090 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8091 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8092 needed otherwise.
8093 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8094 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8095 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8096
e5aab7e7
PE
8097 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8098 avoids undefined behavior in theory.
8099
4da60324
PE
8100 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8101
88043301
PE
8102 Use functions, not macros, for up- and down-casing (Bug#8254).
8103 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8104 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8105 to use the following functions instead of these macros.
8106 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8107 EMACS_INT, since callers assume the returned value fits in int.
8108 (upcase1): Likewise, for UPCASE_TABLE.
8109 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8110 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8111 the race-condition problem in the old DOWNCASE.
88043301 8112
19ed5445
PE
8113 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8114 Rename locals to avoid shadowing.
8115 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8116 (regex_compile, re_search_2, re_match_2_internal):
8117 Remove unused local vars.
952db0d7
PE
8118 (FREE_VAR): Rewrite so as not to use empty "else",
8119 which gcc can warn about.
da053e48 8120 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8121 (RETALLOC_IF): Define only if needed.
8122 (WORDCHAR_P): Likewise. This one is never needed, but is used
8123 only in a comment talking about a compiler bug, so put inside
8124 the #if 0 of that comment.
8125 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8126 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8127 Remove; unused.
19ed5445 8128
1f3561e4 8129 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8130 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8131 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8132
ded6f8f7
PE
8133 * search.c (simple_search): Remove unused var.
8134
dbd37a95
PE
8135 * dired.c (compile_pattern): Move decl from here ...
8136 * lisp.h: ... to here, so that it can be checked.
8137 (struct re_registers): New forward decl.
8138
7e47afad
PE
8139 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8140
85f24f61
PE
8141 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8142 All uses changed.
8143 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8144 Rename locals to avoid shadowing.
5671df8f 8145 (Fvertical_motion): Mark locals as initialized.
85f24f61 8146
181aa2be 8147 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8148 (casify_region): Mark local as initialized.
181aa2be 8149
930d429c
PE
8150 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8151
7082eac6
PE
8152 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8153 New macros, so that the caller can use some names other than
8154 gcpro1, gcpro2, etc.
8155 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8156 of the new macros.
8157 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8158 argument, for consistency with GCPRO2_VAR, etc: it is now the
8159 prefix of the variable, not the variable itself. All uses
8160 changed.
38b2c076
PE
8161 * dired.c (directory_files_internal, file_name_completion):
8162 Rename locals to avoid shadowing.
8163
15206ed9
PE
8164 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8165 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8166 dired.c's scmp function, had undefined behavior.
8167 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8168 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8169 * buffer.h: ... to here, because these macros use current_buffer,
8170 and the new implementation with inline functions needs to have
8171 current_buffer in scope now, rather than later when the macros
8172 are used.
8173 (downcase, upcase1): New static inline functions.
8174 (DOWNCASE, UPCASE1): Reimplement using these functions.
8175 This avoids undefined behavior in expressions like
8176 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8177 from race conditions in accessing the global variables
8178 case_temp1 and case_temp2.
8179 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8180 * lisp.h (case_temp1, case_temp2): Remove their decls.
8181 * character.h (ASCII_CHAR_P): Move from here ...
8182 * lisp.h: ... to here, so that the inline functions mentioned
8183 above can use them.
8184
4a6bea26
PE
8185 * dired.c (directory_files_internal_unwind): Now static.
8186
f14b7e14
PE
8187 * fileio.c (file_name_as_directory, directory_file_name):
8188 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8189 Now static.
2893f146
PE
8190 (file_name_as_directory): Use const pointers when appropriate.
8191 (Fexpand_file_name): Likewise. In particular, newdir might
8192 point at constant storage, so make it a const pointer.
fd4ead52 8193 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8194 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8195 signedness issues.
f839df0c
PE
8196 (Fset_file_times, Finsert_file_contents, auto_save_error):
8197 Rename locals to avoid shadowing.
f14b7e14 8198
5716756e 8199 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8200 (Ftry_completion, Fall_completions): Rename or remove locals
8201 to avoid shadowing.
5716756e 8202
b4c3046a
PE
8203 * marker.c (bytepos_to_charpos): Remove; unused.
8204
b45db522
PE
8205 * lisp.h (verify_bytepos, count_markers): New decls,
8206 so that gcc does not warn that these functions aren't declared.
8207
85876d07
PE
8208 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8209 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8210 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8211 (copy_text): Remove unused local var.
85876d07 8212
03d78a21 8213 * filelock.c (within_one_second): Now static.
b3dd38ab 8214 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8215
5df8f01b
PE
8216 * buffer.c (fix_overlays_before): Mark locals as initialized.
8217 (fix_start_end_in_overlays): Likewise. This function should be
8218 simplified by using pointers-to-pointers, but that's a different
8219 matter.
b1d876f1 8220 (switch_to_buffer_1): Now static.
8f54f30a
PE
8221 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8222 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8223
a70072c9 8224 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8225 Fix pointer signedness issue.
edced198
PE
8226 (sys_subshell): Mark local as volatile if checking for lint,
8227 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8228 (MAXPATHLEN): Define only if needed.
a70072c9 8229
a0977c44
PE
8230 * process.c (serial_open, serial_configure): Move decls from here ...
8231 * systty.h: ... to here, so that they can be checked.
8232
a884fdcc
PE
8233 * fns.c (get_random, seed_random): Move extern decls from here ...
8234 * lisp.h: ... to here, so that they can be checked.
8235
604efe86 8236 * sysdep.c (reset_io): Now static.
b8950c94 8237 (wait_for_termination_signal): Remove; unused.
604efe86 8238
38fc62d9
PE
8239 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8240 (copy_keymap_item, append_key, push_text_char_description):
8241 Now static.
1004a21a 8242 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8243 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8244 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8245 (describe_map_tree):
8246 Rename locals to avoid shadowing.
38fc62d9 8247
2f2650da
PE
8248 * keyboard.c: Declare functions static if they are not used elsewhere.
8249 (echo_char, echo_dash, cmd_error, top_level_2):
8250 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8251 (read_char, kbd_buffer_get_event, make_lispy_position):
8252 (make_lispy_event, make_lispy_movement, apply_modifiers):
8253 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8254 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8255 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8256 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8257 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8258
a053e86c 8259 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8260 (mark_kboards): Move decl here ...
8261 * alloc.c (mark_kboards): ... from here.
a053e86c 8262
4752793e
PE
8263 * lisp.h (force_auto_save_soon): New decl.
8264
74f10ca7 8265 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8266 (DEFINE_DUMMY_FUNCTION): New macro.
8267 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8268 Use it.
c03cd23f
PE
8269 (main): Add casts to avoid warnings
8270 if GCC considers string literals to be constants.
74f10ca7 8271
022e70d4
PE
8272 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8273
59d6fe83
PE
8274 * dbusbind.c: Pointer signedness fixes.
8275 (xd_signature, xd_append_arg, xd_initialize):
8276 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8277 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8278 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8279 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8280
78320123
PE
8281 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8282 if GCC considers string literals to be constants.
49cebcca 8283 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8284
35ac2a97
SM
82852011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8286
fb103ca9
SM
8287 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8288 (print_preprocess, print_object): New macro to fix last change.
8289
35ac2a97
SM
8290 * print.c (print_preprocess): Don't forget font objects.
8291
62973b41
JB
82922011-03-16 Juanma Barranquero <lekktu@gmail.com>
8293
8294 * emacs.c (USAGE3): Doc fixes.
8295
0e48bb22
AS
82962011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8297
8298 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8299 structure.
8300
7684e57b
JB
83012011-03-14 Juanma Barranquero <lekktu@gmail.com>
8302
8303 * lisp.h (VWindow_system, Qfile_name_history):
8304 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8305 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8306 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8307
8308 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8309 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8310
8311 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8312 * w32console.c (detect_input_pending, read_input_pending)
8313 (encode_terminal_code):
8314 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8315 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8316 (w32_system_caret_y, Qfile_name_history):
8317 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8318 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8319 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8320 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8321 * w32proc.c (Qlocal, report_file_error):
8322 * w32term.c (Vwindow_system, updating_frame):
8323 * w32uniscribe.c (initialized, uniscribe_font_driver):
8324 Remove unneeded extern declarations.
8325
2aa46d6c
CY
83262011-03-14 Chong Yidong <cyd@stupidchicken.com>
8327
c96bbc66 8328 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8329
cffc6f3b
CY
83302011-03-13 Chong Yidong <cyd@stupidchicken.com>
8331
8332 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8333 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8334 These macros can no longer be used for assignment.
8335
44f230aa
SM
8336 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8337 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8338 (record_buffer_markers, fetch_buffer_markers): New functions for
8339 recording and fetching special buffer markers.
8340 (set_buffer_internal_1, set_buffer_temp): Use them.
8341
8342 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8343
8344 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8345
8346 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8347 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8348
8349 * xdisp.c (hscroll_window_tree):
8350 (reconsider_clip_changes): Use PT instead of BUF_PT.
8351
d251f04b
EZ
83522011-03-13 Eli Zaretskii <eliz@gnu.org>
8353
8354 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8355 $(EMACS_ROOT)/lib/intprops.h.
8356
f0c77cd1
PE
83572011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8358
3eca4629
PE
8359 Fix more problems found by GCC 4.5.2's static checks.
8360
7c86ee98
PE
8361 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8362 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8363 (xg_free_frame_widgets): Make it clear that a local variable is
8364 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8365 (gdk_window_get_screen): Make it clear that this macro is needed
8366 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8367 (int_gtk_range_get_value): New function, which avoids a diagnostic
8368 from gcc -Wbad-function-cast.
8369 (xg_set_toolkit_scroll_bar_thumb): Use it.
8370 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8371 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8372 (get_utf8_string, xg_get_file_with_chooser):
8373 Rename locals to avoid shadowing.
8374 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8375
41729b81
PE
8376 * xgselect.c (xg_select): Remove unused var.
8377
f0c77cd1
PE
8378 * image.c (four_corners_best): Mark locals as initialized.
8379 (gif_load): Initialize transparent_p to zero (Bug#8238).
8380 Mark another local as initialized.
ec6cf4c6 8381 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8382
ce0ad53d 8383 * image.c (clear_image_cache): Now static.
d5d5a617 8384 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8385 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8386 (x_edge_detection): Remove unnecessary cast that
8387 gcc -Wbad-function-cast diagnoses.
2037898d 8388 (gif_load): Fix pointer signedness.
6ae141d6
PE
8389 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8390 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8391
33383987 83922011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8393
d32df629
PE
8394 Improve quality of tests for time stamp overflow.
8395 For example, without this patch (encode-time 0 0 0 1 1
8396 1152921504606846976) returns the obviously-bogus value (-948597
8397 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8398 reports time overflow. See
8399 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8400 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8401 * editfns.c: Include limits.h and intprops.h.
8402 (TIME_T_MIN, TIME_T_MAX): New macros.
8403 (time_overflow): Move earlier, to before first use.
8404 (hi_time, lo_time): New functions, for an accurate test for
8405 out-of-range times.
8406 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8407 (Fget_internal_run_time): Don't assume time_t fits in int.
8408 (make_time): Use list2 instead of Fcons twice.
8409 (Fdecode_time): More accurate test for out-of-range times.
8410 (check_tm_member): New function.
8411 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8412 (lisp_time_argument): Don't rely on undefined left-shift and
8413 right-shift behavior when checking for time stamp overflow.
8be6f318 8414
fe31d94c
PE
8415 * editfns.c (time_overflow): New function, refactoring common code.
8416 (Fformat_time_string, Fdecode_time, Fencode_time):
8417 (Fcurrent_time_string): Use it.
8418
8be6f318
PE
8419 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8420 * dired.c (make_time): Move to ...
8421 * editfns.c (make_time): ... here.
8422 * systime.h: Note the move.
8423
09d9db2c 84242011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8425
126bc0dc
YM
8426 * fringe.c (update_window_fringes): Remove unused variables.
8427
c47cbdfd
YM
8428 * unexmacosx.c (copy_data_segment): Also copy __got section.
8429 (Bug#8223)
8430
7ac80be9
EZ
84312011-03-12 Eli Zaretskii <eliz@gnu.org>
8432
c96bbc66 8433 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8434 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8435 Constify `char *' arguments and their references according to
8436 prototypes in tparam.h.
8437
ecb0f94d 8438 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8439
7ac80be9
EZ
8440 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8441 Adapt all references accordingly.
8442
8443 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8444
ef1fd07e
TT
84452011-03-11 Tom Tromey <tromey@redhat.com>
8446
8447 * buffer.c (syms_of_buffer): Remove obsolete comment.
8448
7ef4b50c
EZ
84492011-03-11 Eli Zaretskii <eliz@gnu.org>
8450
8451 * termhooks.h (encode_terminal_code): Declare prototype.
8452
8453 * msdos.c (encode_terminal_code): Don't declare prototype.
8454
8455 * term.c (encode_terminal_code): Now external again, used by
8456 w32console.c and msdos.c.
8457
44f230aa
SM
8458 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8459 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8460
4b1ec863 84612011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8462
1714f52b 8463 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8464
4b1ec863
PE
8465 * fringe.c (update_window_fringes): Mark locals as initialized
8466 (Bug#8227).
8467 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8468
524c7aa6
PE
8469 * alloc.c (mark_fringe_data): Move decl from here ...
8470 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8471 to check its interface.
8472 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8473
a5c0af81 8474 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8475 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8476 (fontset_font): Mark local as initialized.
a9a06e0b 8477 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8478
b4716021
PE
8479 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8480
811e9bac 8481 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8482 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8483 (x_own_selection, Fx_disown_selection_internal): Rename locals
8484 to avoid shadowing.
8485 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8486
7e3ab302
PE
8487 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8488 so that the caller can use some name other than gcpro1.
8489 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8490 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8491 (Fx_backspace_delete_keys_p):
8492 Use them to avoid shadowing, and rename vars to avoid shadowing.
8493 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8494 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8495 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8496 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8497 Remove unused locals.
7e3ab302
PE
8498 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8499 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8500 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8501 macros.
f78faa98 8502
e2b13473
PE
8503 * xterm.h (x_mouse_leave): New decl.
8504
77f23912
PE
8505 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8506 Remove unused functions.
cdf4ba58
PE
8507 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8508 (x_calc_absolute_position): Now static.
7411c686 8509 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8510 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8511 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8512 unless they are used.
38d0b34a
PE
8513 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8514 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8515 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8516 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8517 (x_error_catcher, x_connection_closed, x_error_handler):
8518 (x_error_quitter, xembed_send_message, x_iconify_frame):
8519 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8520 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8521 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8522
44f230aa
SM
8523 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8524 Rename or move locals to avoid shadowing.
6b463e58 8525 (tty_defined_color, merge_face_heights): Now static.
5967d051 8526 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8527 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8528 does not deduce is never used uninitialized.
73719eba
PE
8529 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8530 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8531
426994c3 8532 * terminal.c (store_terminal_param): Now static.
5489860b 8533
032f1620 8534 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8535 (set_frame_menubar): Remove unused local.
d4323972 8536 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8537 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8538 since they might point to immutable storage.
281585b0
PE
8539 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8540 since it's unused otherwise.
032f1620 8541
367c19e5 8542 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8543 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8544 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8545 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8546 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8547 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8548 does not deduce are never used uninitialized.
70739cbe 8549
07b48fa9
PE
8550 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8551
8868a238 8552 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8553 * window.c (window_loop, size_window):
8554 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8555
7e5cf297 8556 * window.c (display_buffer): Now static.
d6550a9f
PE
8557 (size_window): Mark variables that gcc -Wuninitialized
8558 does not deduce are never used uninitialized.
a586633d
PE
8559 * window.h (check_all_windows): New decl, to forestall
8560 gcc -Wmissing-prototypes diagnostic.
5b555da1 8561 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8562
f6095868
PE
8563 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8564 shadowing.
8565 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8566 Include <limits.h>.
8567 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8568 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8569 (load_charset_map): Mark variables that gcc -Wuninitialized
8570 does not deduce are never used uninitialized.
53df7c11 8571 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8572
f38b440c
PE
8573 * coding.c (coding_set_source, coding_set_destination):
8574 Use "else { /* comment */ }" rather than "else /* comment */;"
8575 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8576 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8577 a block, when the outer 'i' will do.
8578 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8579 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8580 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8581 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8582 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8583 Rename locals to avoid shadowing.
8584 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8585 * coding.c (emacs_mule_char, encode_invocation_designation):
8586 Now static, since they're not used elsewhere.
413bb2db 8587 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8588 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8589 (decode_coding_emacs_mule): Mark variables that gcc
8590 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8591 (detect_coding_iso_2022): Initialize a local variable that might
8592 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8593 this initialization is needed. (Bug#8211)
5f58e762
PE
8594 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8595 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8596 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8597 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8598 Remove unused macros.
f38b440c 8599
232b38b9 8600 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8601 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8602 * character.c (string_count_byte8): Likewise.
232b38b9 8603
fb90da1b
PE
8604 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8605 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8606
fb93dbc2
PE
8607 * chartab.c (copy_sub_char_table): Now static, since it's not used
8608 elsewhere.
5c156ace
PE
8609 (sub_char_table_ref_and_range, char_table_ref_and_range):
8610 Rename locals to avoid shadowing.
bbcd0949 8611 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8612
7d3b3862 8613 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8614 (BIDI_BOB): Remove unused macro.
7d3b3862 8615
6be7d3da
PE
8616 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8617 deduce are never used uninitialized.
c2ed9c8b 8618 * term.c (encode_terminal_code): Likewise.
6be7d3da 8619
75f8807f 8620 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8621
50938595
PE
8622 * tparam.h: New file.
8623 * term.c, tparam.h: Include it.
8624 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8625 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8626 Move these decls to tparam.h, and make them agree with what
8627 is actually in tparam.c. The previous trick of using incompatible
8628 decls in different modules does not conform to the C standard.
8629 All callers of tparam changed to use tparam's actual API.
8630 * tparam.c (tparam1, tparam, tgoto):
8631 Use const pointers where appropriate.
8632
fbceeba2
PE
8633 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8634 * cm.h (struct cm): Likewise.
8635 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8636 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8637 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8638 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8639 (turn_on_face, init_tty): Likewise.
8640 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8641
7f3f1250
PE
8642 * term.c (term_mouse_position): Rename local to avoid shadowing.
8643
e6ca6543
PE
8644 * alloc.c (mark_ttys): Move decl from here ...
8645 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8646
c40f8d15
AS
86472011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8648
8649 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8650
cfe0661d
JB
86512011-03-09 Juanma Barranquero <lekktu@gmail.com>
8652
8653 * search.c (compile_pattern_1): Remove argument regp, unused since
8654 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8655 (compile_pattern): Don't pass it.
8656
0afb4571
J
86572011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8658
8659 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8660 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8661 for ! HAVE_GTK3.
8662 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8663
8664 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8665
8666 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8667 gdk_window_get_screen, gdk_window_get_geometry,
8668 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8669 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8670 (xg_get_pixbuf_from_pixmap): New function.
8671 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8672 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8673 Call xg_get_pixbuf_from_pixmap instead of
8674 gdk_pixbuf_get_from_drawable.
8675 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8676 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8677 (xg_check_special_colors): Use GtkStyleContext and its functions
8678 for HAVE_GTK3.
8679 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8680 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8681 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8682 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8683 Call gtk_widget_get_preferred_size.
0afb4571
J
8684 (xg_frame_resized): gdk_window_get_geometry only takes 5
8685 parameters.
44f230aa
SM
8686 (xg_win_to_widget, xg_event_is_for_menubar):
8687 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8688 (xg_set_widget_bg): New function.
8689 (delete_cb): New function.
895009e1 8690 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8691 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8692 (xg_set_background_color): Call xg_set_widget_bg.
8693 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8694 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8695 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8696 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8697 if ! HAVE_GTK3.
8698 (update_frame_tool_bar): Call gtk_widget_hide.
8699 (xg_initialize): Use GDK_KEY_g.
8700
8701 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8702 if ! HAVE_GTK3
8703 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8704
8705 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8706 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8707 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8708
1c2cc4ef
JB
87092011-03-08 Juanma Barranquero <lekktu@gmail.com>
8710
8711 * w32xfns.c (select_palette): Check success of RealizePalette against
8712 GDI_ERROR, not zero.
8713
33383987 8714See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8715
8716;; Local Variables:
8717;; coding: utf-8
aac0c6e3
MR
8718;; End:
8719
33383987 8720 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8721
8722 This file is part of GNU Emacs.
8723
8724 GNU Emacs is free software: you can redistribute it and/or modify
8725 it under the terms of the GNU General Public License as published by
8726 the Free Software Foundation, either version 3 of the License, or
8727 (at your option) any later version.
8728
8729 GNU Emacs is distributed in the hope that it will be useful,
8730 but WITHOUT ANY WARRANTY; without even the implied warranty of
8731 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8732 GNU General Public License for more details.
8733
8734 You should have received a copy of the GNU General Public License
8735 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.