Add Bug#.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ca4aa935
PE
12011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2
41f55ccd 3 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4
ca4aa935
PE
5 * image.c: Improve checking for integer overflow.
6 (check_image_size): Assume that f is nonnull, since
7 it is always nonnull in practice. This is one less thing to
8 worry about when checking for integer overflow later.
9 (x_check_image_size): New function, which checks for integer
10 overflow issues inside X.
11 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
12 This removes the need for a memory_full check.
13 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
14 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
15 (xbm_read_bitmap_data): Change locals back to 'int', since
16 their values must fit in 'int'.
17 (xpm_load_image, png_load, tiff_load):
18 Invoke x_create_x_image_and_pixmap earlier,
19 to avoid much needless work if the image is too large.
20 (tiff_load): Treat overly large images as if
21 x_create_x_image_and_pixmap failed, not as malloc failures.
22 (gs_load): Use x_check_image_size.
23
5f8f9cc2
PE
24 * gtkutil.c: Omit integer casts.
25 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
26 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
27
5adf60bc
PE
28 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
29
82d66f4e
PE
30 * bidi.c (bidi_dump_cached_states): Use pD to print ptrdiff_t.
31
c8907a93
PE
32 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
33 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
34 would wrongly return t on a 64-bit host.
35
e3c25c68
PE
36 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
37 The plain *_OVERFLOW macros run afoul of GCC bug 49705
38 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
39 and therefore cause GCC to emit a bogus diagnostic in some cases.
40
3f791afe
PE
41 * image.c: Integer signedness and overflow and related fixes.
42 This is not an exhaustive set of fixes, but it's time to
43 record what I've got.
44 (lookup_pixel_color, check_image_size): Remove redundant decls.
45 (check_image_size): Don't assume that arbitrary EMACS_INT values
46 fit in 'int', or that arbitrary 'double' values fit in 'int'.
47 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
48 (tiff_load, imagemagick_load_image):
49 Check for overflow in size calculations.
50 (x_create_x_image_and_pixmap): Remove unnecessary test for
51 xmalloc returning NULL; that can't happen.
52 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
53 (xpm_color_bucket): Use better integer hashing function.
54 (xpm_cache_color): Don't possibly over-allocate memory.
55 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
56 (gif_memory_source):
57 Use ptrdiff_t, not int or size_t, to record sizes.
58 (png_load): Don't assume values greater than 2**31 fit in 'int'.
59 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
60 either works, as we prefer signed integers.
61 (tiff_read_from_memory, tiff_write_from_memory):
62 Return tsize_t, not size_t, since that's what the TIFF API wants.
63 (tiff_read_from_memory): Don't fail simply because the read would
64 go past EOF; instead, return a short read.
65 (tiff_load): Omit no-longer-needed casts.
66 (Fimagemagick_types): Don't assume size fits into 'int'.
67
3cc5a532
PE
68 Improve hashing quality when configured --with-wide-int.
69 * fns.c (hash_string): New function, taken from sxhash_string.
70 Do not discard information about ASCII character case; this
71 discarding is no longer needed.
72 (sxhash-string): Use it. Change sig to match it. Caller changed.
73 * lisp.h: Declare it.
74 * lread.c (hash_string): Remove, since we now use fns.c's version.
75 The fns.c version returns a wider integer if --with-wide-int is
76 specified, so this should help the quality of the hashing a bit.
77
b312a492
PE
78 * emacs.c: Integer overflow minor fix.
79 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
80 Define only if GNU_LINUX.
81 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
82
dfd153ae
PE
83 * dispnew.c: Integer signedness and overflow fixes.
84 Remove unnecessary forward decls, that were a maintenance hassle.
85 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
86 All uses changed.
87 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
88 (scrolling_window): Use ptrdiff_t, not int, for byte count.
89 (prepare_desired_row, line_draw_cost):
90 Use int, not unsigned, where either works.
91 (save_current_matrix, restore_current_matrix):
92 Use ptrdiff_t, not size_t, where either works.
93 (init_display): Check for overflow more accurately, and without
94 relying on undefined behavior.
95
a81d11a3
PE
96 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
97 Remove, replacing with the new symbols in lisp.h. All uses changed.
98 * fileio.c (make_temp_name):
99 * filelock.c (lock_file_1, lock_file):
100 * xdisp.c (message_dolog):
101 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
102 Use pMd etc. instead.
103 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
104 replacing the pWIDE etc. symbols removed from editfns.c.
105
3300e6fd
PE
106 * keyboard.h (num_input_events): Now uintmax_t.
107 This is (very slightly) less likely to mess up due to wraparound.
108 All uses changed.
109
fd05c7e9
PE
110 * buffer.c: Integer signedness fixes.
111 (alloc_buffer_text, enlarge_buffer_text):
112 Use ptrdiff_t rather than size_t when either will do, as we prefer
113 signed integers.
114
5b8ffbdd
PE
115 * bidi.c: Integer signedness and overflow fixes.
116 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
117 (bidi_cache_search, bidi_cache_find_level_change)
cf950e6b 118p (bidi_cache_iterator_state, bidi_cache_find)
89bfafe5 119 (bidi_find_other_level_edge, bidi_dump_cached_states):
5b8ffbdd
PE
120 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
121 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
122 signed integers.
123 (elsz): Make it a (signed) constant.
124 (bidi_cache_iterator_state): Check for size-calculation overflow.
125
903fe15d
PE
126 * alloc.c: Integer signedness and overflow fixes.
127 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
128 (__malloc_size_t): Default to size_t, not to int.
129 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
130 (Fgarbage_collect, mark_object_loop_halt, mark_object):
131 Prefer ptrdiff_t to size_t when either would do, as we prefer
132 signed integers.
133 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
134 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
135 Now const. Initialize with values that are in range even if char
136 is signed.
137 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
138 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
139 These functions do the right thing with sizes > 2**32.
140 (check_depth): Now ptrdiff_t, not int.
141 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
142 Adjust to new way of storing sizes. Check for size overflow bugs
143 in rest of code.
144 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
145 slightly wrong anyway, as it missed one instance of
146 XMALLOC_OVERRUN_CHECK_OVERHEAD.
147 (refill_memory_reserve): Omit needless cast to size_t.
148 (mark_object_loop_halt): Mark as externally visible.
149
ac82cc6a
PE
150 * xselect.c: Integer signedness and overflow fixes.
151 (Fx_register_dnd_atom, x_handle_dnd_message):
152 Use ptrdiff_t, not size_t, since we prefer signed.
153 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
154 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
155 x_dnd_atoms_size and x_dnd_atoms_length.
156
c2d1e36d
PE
157 * doprnt.c: Prefer signed to unsigned when either works.
158 * eval.c (verror):
159 * doprnt.c (doprnt):
160 * lisp.h (doprnt):
161 * xdisp.c (vmessage):
162 Use ptrdiff_t, not size_t, when using or implementing doprnt,
163 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
164 prefer signed arithmetic to avoid comparison confusion.
165 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
166 but is a bit tricky.
167
0e926e56
PE
168 Assume freestanding C89 headers, string.h, stdlib.h.
169 * data.c, doprnt.c, floatfns.c, print.c:
170 Include float.h unconditionally.
171 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
172 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
173 * regex.c: Likewise for stddef.h, string.h.
174 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
175 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
176 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
177 (STDC_HEADERS): Remove obsolete defines.
178 * sysdep.c: Include limits.h unconditionally.
179
9cfdb3ec
PE
180 Assume support for memcmp, memcpy, memmove, memset.
181 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
182 * regex.c (memcmp, memcpy):
183 Remove; we assume C89 now.
184
185 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
186 (__malloc_safe_bcopy): Remove; no longer needed.
187
cf950e6b 188 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
189 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
190 well either way, and we prefer signed to unsigned.
191
837c31f8
LMI
1922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
193
194 * editfns.c (Fstring_to_char): Clarify just what is returned
195 (bug#6576). Text by Eli Zaretskii.
196
ac389d0c
JB
1972011-07-13 Juanma Barranquero <lekktu@gmail.com>
198
199 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
200
0be0ce47
EZ
2012011-07-13 Eli Zaretskii <eliz@gnu.org>
202
203 * buffer.c (mmap_find): Fix a typo.
204
cd18e7e3
JB
2052011-07-13 Johan Bockgård <bojohan@gnu.org>
206
207 Fix execution of x selection hooks.
208 * xselect.c (Qx_lost_selection_functions)
209 (Qx_sent_selection_functions): New vars.
210 (syms_of_xselect): DEFSYM them.
211 (x_handle_selection_request): Pass Qx_sent_selection_functions
212 rather than Vx_sent_selection_functions to Frun_hook_with_args.
213 (x_handle_selection_clear,x_clear_frame_selections):
214 Pass Qx_lost_selection_functions rather than
215 Vx_lost_selection_functions to Frun_hook_with_args.
216
47ea7f44
PE
2172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
218
ac389d0c 219 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
220 The old code sometimes used this field without initializing it.
221
47ea7f44
PE
222 * alloc.c (gc_sweep): Don't read past end of array.
223 In theory, the old code could also have corrupted Emacs internals,
224 though it'd be very unlikely.
225
bc985c87
AS
2262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
227
228 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 229 argument. (Bug#4026)
bc985c87 230
0cf34688
LMI
2312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
232
b3dadd76
LMI
233 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
234 key" (bug#4257).
235
0cf34688
LMI
236 * window.c (Fset_window_start): Doc fix (bug#4199).
237 (Fset_window_hscroll): Ditto.
238
270768cd
PE
2392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
240
077e3dda 241 Fix minor new problems caught by GCC 4.6.1.
270768cd 242 * term.c (init_tty): Remove unused local.
490011a6 243 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 244 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 245 not used otherwise.
270768cd 246
b1f58454
CY
2472011-07-12 Chong Yidong <cyd@stupidchicken.com>
248
249 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
250
22b9578d
LMI
2512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
252
6e70ab07
LMI
253 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
254 are the mini-buffer and the echo area (bug#3320).
255
22b9578d
LMI
256 * term.c (init_tty): Remove support for supdup, c10 and perq
257 terminals, which are no longer supported (bug#1482).
258
8974cc9f
JB
2592011-07-10 Johan Bockgård <bojohan@gnu.org>
260
261 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
262
a560d974
JD
2632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
264
265 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
266 for non-popups (Bug#3642).
267
1dae0f0a
AS
2682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
269
268c2c36 270 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 271 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
272 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
273 * cm.c (losecursor): Likewise.
1dae0f0a
AS
274 * data.c (fmod): Likewise.
275 * dispnew.c (swap_glyphs_in_rows): Likewise.
276 * emacs.c (memory_warning_signal): Likewise.
277 * floatfns.c (float_error): Likewise.
278 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
279 (otf_open, font_otf_capability, generate_otf_features)
280 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
281 Likewise.
282 * image.c (pbm_read_file): Likewise.
283 * indent.c (string_display_width): Likewise.
284 * intervals.c (check_for_interval, search_for_interval)
285 (inc_interval_count, count_intervals, root_interval)
286 (adjust_intervals_for_insertion, make_new_interval): Likewise.
287 * lread.c (defalias): Likewise.
268c2c36 288 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
289 * regex.c (set_image_of_range_1, set_image_of_range)
290 (regex_grow_registers): Likewise.
291 * sysdep.c (strerror): Likewise.
292 * termcap.c (valid_filename_p, tprint, main): Likewise.
293 * tparam.c (main): Likewise.
294 * unexhp9k800.c (run_time_remap, save_data_space)
295 (update_file_ptrs, read_header, write_header, calculate_checksum)
296 (copy_file, copy_rest, display_header): Likewise.
297 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
298 Likewise.
299 * xdisp.c (check_it): Likewise.
300 * xfaces.c (register_color, unregister_color, unregister_colors):
301 Likewise.
302 * xfns.c (print_fontset_result): Likewise.
303 * xrdb.c (member, fatal, main): Likewise.
304
99033785
PE
3052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
306
307 Fix minor problems found by static checking (Bug#9031).
308 * chartab.c (char_table_set_range, map_sub_char_table):
309 Remove unused locals.
310 (uniprop_table): Now static.
311 * composite.c (_work_char): Remove unused static var.
312
9cb2ac56
JB
3132011-07-09 Juanma Barranquero <lekktu@gmail.com>
314
315 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
316
f25661f0
JD
3172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
318
319 * gtkutil.c (qttip_cb): Remove code without function.
320
8278c4fe
EZ
3212011-07-09 Eli Zaretskii <eliz@gnu.org>
322
323 * w32.c (pthread_sigmask): New stub.
324
1692ae2d 3252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 326
8a6ebd58 327 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
328 sigprocmask is portable only for single-threaded applications, and
329 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
330 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
331 (LIBES): Use it.
332 * callproc.c (Fcall_process):
333 * process.c (create_process):
334 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
335 Use pthread_sigmask, not sigprocmask.
123403e4 336
1b854618
JD
3372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
338
339 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
340 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
341 wrong (Bug#8591).
342
3fe4b549
JD
3432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
344
0ce7e563
JD
345 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
346 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
347 (xg_hide_tooltip): Fix comment.
348
3fe4b549
JD
349 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
350 in registerServicesMenuSendTypes.
351 (validRequestorForSendType): Don't check ns_return_types.
352
353 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
354 ns_return_type.
355
5df75e47
JR
3562011-07-08 Jason Rumney <jasonr@gnu.org>
357
358 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
359 frame struct members of non-existent frames (Bug#6284).
360
699c10bd
JD
3612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
362
4393663b
JD
363 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
364 variable firstTime not needed on OSX >= 10.6.
365 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
366 >= 10.5. Use setKnobProportion, setDoubleValue.
367
368 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
369 (MAC_OS_X_VERSION_10_5): Define if not defined.
370 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
371 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
372 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
373
374 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
375 cString and lossyCString on OSX >= 10.4
376
377 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
378 sizeToFit on OSX >= 10.2.
379
380 * nsimage.m (allocInitFromFile): Don't use deprecated method
381 bestRepresentationForDevice on OSX >= 10.6.
382
383 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
384 to avoid warning.
385
386 * emacs.c: Declare unexec_init_emacs_zone.
387
a63e0781
JD
388 * nsgui.h: Fix compiler warning about gnulib redefining verify.
389
699c10bd
JD
390 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
391
392 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
393 on svcsMenu (Bug#8842).
394
395 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
396 ns_return_types.
397 (Fns_list_services): Just return Qnil on 10.6, code not working there.
398
399 * nsterm.m (QUTF8_STRING): Declare.
400 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
401 (validRequestorForSendType): Return type is (id).
402 Change indexOfObjectIdenticalTo to indexOfObject.
403 Check if we have local selection before returning self (Bug#8842).
404 (writeSelectionToPasteboard): Put local selection into paste board
405 if we have a local selection (Bug#8842).
406 (syms_of_nsterm): DEFSYM QUTF8_STRING.
407
408 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
409 (ns_get_local_selection): Declare.
410
54e10184
LMI
4112011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
412
9888ff71
LMI
413 * keymap.c (describe_map_tree): Don't insert a double newline at
414 the end of the buffer (bug#1169) and return whether we inserted
415 something.
416
54e10184
LMI
417 * callint.c (Fcall_interactively): Change "reading args" to
418 "providing args" to try to clarify what it does (bug#1010).
419
15fa4783
KH
4202011-07-07 Kenichi Handa <handa@m17n.org>
421
422 * composite.c (composition_compute_stop_pos): Ignore a static
423 composition starting before CHARPOS (Bug#8915).
424
425 * xdisp.c (handle_composition_prop): Likewise.
426
a8815b00
EZ
4272011-07-07 Eli Zaretskii <eliz@gnu.org>
428
429 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
430 (Bug#9015)
431
ef7b981d 4322011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
433
434 * character.h (unicode_category_t): New enum type.
435
436 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
437 (Qchar_code_property_table): New variable.
438 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
439 (UNIPROP_COMPRESSED_FORM_P): New macros.
440 (char_table_ascii): Uncompress the compressed values.
441 (sub_char_table_ref): New arg is_uniprop. Callers changed.
442 Uncompress the compressed values.
ac389d0c 443 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
444 (char_table_ref_and_range): Uncompress the compressed values.
445 (sub_char_table_set): New arg is_uniprop. Callers changed.
446 Uncompress the compressed values.
447 (sub_char_table_set_range): Args changed. Callers changed.
448 (char_table_set_range): Adjuted for the above change.
449 (map_sub_char_table): Delete args default_val and parent. Add arg
450 top. Give decoded values to a Lisp function.
451 (map_char_table): Adjusted for the above change. Give decoded
452 values to a Lisp function. Gcpro more variables.
453 (uniprop_table_uncompress)
454 (uniprop_decode_value_run_length): New functions.
455 (uniprop_decoder, uniprop_decoder_count): New variables.
456 (uniprop_get_decoder, uniprop_encode_value_character)
457 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
458 New functions.
459 (uniprop_encoder, uniprop_encoder_count): New variables.
460 (uniprop_get_encoder, uniprop_table)
461 (Funicode_property_table_internal, Fget_unicode_property_internal)
462 (Fput_unicode_property_internal): New functions.
463 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
464 Sunicode_property_table_internal, Sget_unicode_property_internal,
465 and Sput_unicode_property_internal. Defvar_lisp
466 char-code-property-alist.
467
468 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
469 Vunicode_category_table.
470
471 * font.c (font_range): Adjusted for the change of
472 Vunicode_category_table.
473
76b397fb
DN
4742011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
475
476 * m/iris4d.h: Remove file, move contents ...
477 * s/irix6-5.h: ... here.
478
22b4128e
PE
4792011-07-06 Paul Eggert <eggert@cs.ucla.edu>
480
481 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
482 * alloc.c (mark_buffer):
483 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
484 (clone_per_buffer_values): Don't assume that
22b4128e
PE
485 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
486 This isn't true in general, and it's particularly not true
487 if Emacs is configured with --with-wide-int.
488 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
489 New macros, used in the buffer.c change.
490
869795d6
JD
4912011-07-05 Jan Djärv <jan.h.d@swipnet.se>
492
493 * xsettings.c: Use both GConf and GSettings if both are available.
494 (store_config_changed_event): Add comment.
495 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
496 (store_tool_bar_style_changed): New functions.
497 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
498 (struct xsettings): Move font inside HAVE_XFT.
499 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
500 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
501 Move inside HAVE_XFT.
502 (something_changed_gsettingsCB): Renamed from something_changedCB.
503 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
504 also.
505 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
506 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
507 (something_changed_gconfCB): Renamed from something_changedCB.
508 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
509 (parse_settings): Move check for font inside HAVE_XFT.
510 (read_settings, apply_xft_settings): Add comment.
511 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
512 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
513 call store_font_name_changed.
514 (xft_settings_event): Add comment.
515 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
516 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
517 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
518 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
519 (xsettings_initialize): Call init_gsettings last.
520 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
521 comment.
522
d8ed26bd
PE
5232011-07-05 Paul Eggert <eggert@cs.ucla.edu>
524
525 Random fixes. E.g., (random) never returned negative values.
526 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
527 subseconds part to the entropy, as that's a bit more random.
528 Prefer signed to unsigned, since the signedness doesn't matter and
529 in general we prefer signed. When given a limit, use a
530 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
531 latter isn't right if USE_2_TAGS_FOR_INTS.
532 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
533 not 0..VALMASK. Don't discard "excess" bits that random () returns.
534
cabf1cac
SM
5352011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
536
537 * textprop.c (text_property_stickiness):
538 Obey Vtext_property_default_nonsticky.
539 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
540 * w32fns.c (syms_of_w32fns):
541 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
542
6e9b2be9
PE
5432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
544
545 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
546 This is more efficient than Ffile_directory_p and avoids a minor race.
547
90186c68
LMI
5482011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
549
7c301272
LMI
550 * buffer.c (Foverlay_put): Say what the return value is
551 (bug#7835).
552
c4f2d8d4
LMI
553 * fileio.c (barf_or_query_if_file_exists): Check first if the file
554 is a directory before asking whether to use the file name
555 (bug#7564).
ad637907
LMI
556 (barf_or_query_if_file_exists): Make the "File is a directory"
557 error be more correct.
c4f2d8d4 558
90186c68
LMI
559 * fns.c (Frequire): Remove the mention of the .gz files, since
560 that's installation-specific, but keep the mention of
561 `get-load-suffixes'.
562
da64016e
PE
5632011-07-04 Paul Eggert <eggert@cs.ucla.edu>
564
565 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
566 Report string overflow if the output is too long.
567
7d47b580
JB
5682011-07-04 Juanma Barranquero <lekktu@gmail.com>
569
a555cb87
JB
570 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
571 (syms_of_gnutls): Remove duplicate DEFSYM for
572 Qgnutls_bootprop_verify_hostname_error, an error for
573 Qgnutls_bootprop_verify_error (which is no longer used).
574
7d47b580
JB
575 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
576 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
577 Also (re)move comments that are misplaced or no longer relevant.
578
1e49bfab
LMI
5792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
580
581 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
582
1485f4c0
CY
5832011-07-03 Chong Yidong <cyd@stupidchicken.com>
584
585 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
586 and background color parameters if they have been changed.
587
a9ab721e
LMI
5882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
589
590 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
591
cf7cff57
PE
5922011-07-03 Paul Eggert <eggert@cs.ucla.edu>
593
2e13213d
PE
594 * xsettings.c (SYSTEM_FONT): Define only when used.
595 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
596
cf7cff57
PE
597 * keymap.c (access_keymap_1): Now static.
598
7a8e04f7
CY
5992011-07-02 Chong Yidong <cyd@stupidchicken.com>
600
601 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
602 leave any prefix arg for the up event (Bug#1586).
603
61352f62
LMI
6042011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
605
69bb1ef7
LMI
606 * lread.c (syms_of_lread): Mention single symbols defined by
607 `defvar' or `defconst' (bug#7154).
608
61352f62 609 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 610 (Frequire): Mention get-load-suffixes.
61352f62 611
28545e04
MR
6122011-07-02 Martin Rudalics <rudalics@gmx.at>
613
614 * window.h (window): Remove clone_number slot.
615 * window.c (Fwindow_clone_number, Fset_window_clone_number):
616 Remove.
617 (make_parent_window, make_window, saved_window)
618 (Fset_window_configuration, save_window_save): Don't deal with
619 clone numbers.
620 * buffer.c (Qclone_number): Remove declaration.
621 (sort_overlays, overlay_strings): Don't deal with clone numbers.
622
3349e122
SM
6232011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 Add multiple inheritance to keymaps.
626 * keymap.c (Fmake_composed_keymap): New function.
627 (Fset_keymap_parent): Simplify.
628 (fix_submap_inheritance): Remove.
629 (access_keymap_1): New function extracted from access_keymap to handle
630 embedded parents and handle lists of maps.
631 (access_keymap): Use it.
632 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
633 (Fcopy_keymap): Handle embedded parents.
634 (Fcommand_remapping, define_as_prefix): Simplify.
635 (Fkey_binding): Simplify.
636 (syms_of_keymap): Move minibuffer-local-completion-map,
637 minibuffer-local-filename-completion-map,
638 minibuffer-local-must-match-map, and
639 minibuffer-local-filename-must-match-map to Elisp.
640 (syms_of_keymap): Defsubr make-composed-keymap.
641 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
642 (parse_menu_item): Trivial simplification.
643
3279eb87
GM
6442011-07-01 Glenn Morris <rgm@gnu.org>
645
646 * Makefile.in (SETTINGS_LIBS): Fix typo.
647
4550efdf
KI
6482011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
649
650 * coding.c (Fencode_coding_string): Record the last coding system
651 used, as the function doc string says (bug#8738).
652
0949d2b6
JD
6532011-07-01 Jan Djärv <jan.h.d@swipnet.se>
654
655 * xsettings.c (store_monospaced_changed): Take new font as arg and
656 check for change against current_mono_font.
657 (EMACS_TYPE_SETTINGS): Remove this and related defines.
658 (emacs_settings_constructor, emacs_settings_get_property)
659 (emacs_settings_set_property, emacs_settings_class_init)
660 (emacs_settings_init, gsettings_obj): Remove.
661 (something_changedCB): New function for HAVE_GSETTINGS.
662 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
663 with value as argument.
664 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
665 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 666 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
667 "changed".
668
669 * xgselect.c: Add defined (HAVE_GSETTINGS).
670 (xgselect_initialize): Ditto.
671
672 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
673 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
674 xg_select.
675
bbc6b304
PE
6762011-07-01 Paul Eggert <eggert@cs.ucla.edu>
677
678 * eval.c (struct backtrace): Simplify and port the data structure.
679 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
680 signed bit field, as this assumption is not portable and it makes
681 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
682 "char debug_on_exit : 1" as this is not portable either; instead,
683 use the portable "unsigned int debug_on_exit : 1". Remove unused
684 member evalargs. Remove obsolete comments about cc bombing out.
685
9851bfc5
JD
6862011-06-30 Jan Djärv <jan.h.d@swipnet.se>
687
51bb811f 688 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
689 Let HAVE_GSETTINGS override HAVE_GCONF.
690 (store_monospaced_changed): New function.
691 (EMACS_SETTINGS): A new type derived from GObject to handle
692 GSettings notifications.
693 (emacs_settings_constructor, emacs_settings_get_property)
694 (emacs_settings_set_property, emacs_settings_class_init):
695 New functions.
696 (gsettings_client, gsettings_obj): New variables.
697 (GSETTINGS_SCHEMA): New define.
698 (something_changedCB): Call store_monospaced_changed.
699 (init_gsettings): New function.
700 (xsettings_initialize): Call init_gsettings.
701 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
702 to NULL.
703
704 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
705 GCONF_CFLAGS/LIBS.
706
5386012d
MR
7072011-06-29 Martin Rudalics <rudalics@gmx.at>
708
709 * window.c (resize_root_window, grow_mini_window)
710 (shrink_mini_window): Rename Qresize_root_window to
711 Qwindow_resize_root_window and Qresize_root_window_vertically to
712 Qwindow_resize_root_window_vertically.
713
f13e0b08
PE
7142011-06-28 Paul Eggert <eggert@cs.ucla.edu>
715
716 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
717
94515237
JB
7182011-06-27 Juanma Barranquero <lekktu@gmail.com>
719
720 * makefile.w32-in: Redesign dependencies so they reflect more
721 clearly which files are directly included by each source file,
722 and not through other includes.
723
e43b6e43
MR
7242011-06-27 Martin Rudalics <rudalics@gmx.at>
725
726 * buffer.c (Qclone_number): Declare static and DEFSYM it.
727 (sort_overlays, overlay_strings): When an overlay's clone number
728 matches the window's clone number process the overlay even if
729 the overlay's window property doesn't match the current window.
730
d68443dc
MR
731 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
732 (Fwindow_hchild): Rename to Fwindow_left_child.
733 (Fwindow_next): Rename to Fwindow_next_sibling.
734 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
735 (resize_window_check): Rename to window_resize_check.
736 (resize_window_apply): Rename to window_resize_apply.
737 (Fresize_window_apply): Rename to Fwindow_resize_apply.
738 (Fdelete_other_windows_internal, resize_frame_windows)
739 (Fsplit_window_internal, Fdelete_window_internal)
740 (grow_mini_window, shrink_mini_window)
741 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 742
c7e73be5
JD
7432011-06-26 Jan Djärv <jan.h.d@swipnet.se>
744
745 * emacsgtkfixed.h: State that this is only used with Gtk+3.
746 (emacs_fixed_set_min_size): Remove.
747 (emacs_fixed_new): Take frame as argument.
748
749 * emacsgtkfixed.c: State that this is only used with Gtk+3.
750 (_EmacsFixedPrivate): Remove minwidth/height.
751 Add struct frame *f.
752 (emacs_fixed_init): Initialize priv->f.
753 (get_parent_class, emacs_fixed_set_min_size): Remove.
754 (emacs_fixed_new): Set priv->f to argument.
755 (emacs_fixed_get_preferred_width)
756 (emacs_fixed_get_preferred_height): Use min_width/height from
757 frames size_hint to set minimum and natural (Bug#8919).
758 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
759 and use min_width/height from frames size_hint to set
760 min_width/height (Bug#8919).
761
762 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
763 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
764 Fix indentation.
c7e73be5 765
cf99dcf8
EZ
7662011-06-26 Eli Zaretskii <eliz@gnu.org>
767
768 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
769 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
770 called at ZV.
771
029529ac
CY
7722011-06-26 Chong Yidong <cyd@stupidchicken.com>
773
774 * process.c (wait_reading_process_output): Bypass select if
775 waiting for a cell while ignoring keyboard input, and input is
776 pending. Suggested by Jan Djärv (Bug#8869).
777
7a7ef429
PE
7782011-06-25 Paul Eggert <eggert@cs.ucla.edu>
779
780 Use gnulib's dup2 module instead of rolling our own.
781 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
782
11fdef7d 7832011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
784
785 * dispnew.c (scrolling_window): Before scrolling, turn off a
786 mouse-highlight in the window being scrolled.
787
cd3520a4
JB
7882011-06-24 Juanma Barranquero <lekktu@gmail.com>
789
790 Move DEFSYM to lisp.h and use everywhere.
791
792 * character.h (DEFSYM): Move declaration...
793 * lisp.h (DEFSYM): ...here.
794
795 * gnutls.c:
796 * minibuf.c:
797 * w32menu.c:
798 * w32proc.c:
799 * w32select.c: Don't include character.h.
800
801 * alloc.c (syms_of_alloc):
802 * buffer.c (syms_of_buffer):
803 * bytecode.c (syms_of_bytecode):
804 * callint.c (syms_of_callint):
805 * casefiddle.c (syms_of_casefiddle):
806 * casetab.c (init_casetab_once):
807 * category.c (init_category_once, syms_of_category):
808 * ccl.c (syms_of_ccl):
809 * cmds.c (syms_of_cmds):
810 * composite.c (syms_of_composite):
811 * dbusbind.c (syms_of_dbusbind):
812 * dired.c (syms_of_dired):
813 * dispnew.c (syms_of_display):
814 * doc.c (syms_of_doc):
815 * editfns.c (syms_of_editfns):
816 * emacs.c (syms_of_emacs):
817 * eval.c (syms_of_eval):
818 * fileio.c (syms_of_fileio):
819 * fns.c (syms_of_fns):
820 * frame.c (syms_of_frame):
821 * fringe.c (syms_of_fringe):
822 * insdel.c (syms_of_insdel):
823 * keymap.c (syms_of_keymap):
824 * lread.c (init_obarray, syms_of_lread):
825 * macros.c (syms_of_macros):
826 * msdos.c (syms_of_msdos):
827 * print.c (syms_of_print):
828 * process.c (syms_of_process):
829 * search.c (syms_of_search):
830 * sound.c (syms_of_sound):
831 * syntax.c (init_syntax_once, syms_of_syntax):
832 * terminal.c (syms_of_terminal):
833 * textprop.c (syms_of_textprop):
834 * undo.c (syms_of_undo):
835 * w32.c (globals_of_w32):
836 * window.c (syms_of_window):
837 * xdisp.c (syms_of_xdisp):
838 * xfaces.c (syms_of_xfaces):
839 * xfns.c (syms_of_xfns):
840 * xmenu.c (syms_of_xmenu):
841 * xsettings.c (syms_of_xsettings):
842 * xterm.c (syms_of_xterm): Use DEFSYM.
843
4228cf16
TZ
8442011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
845
cd3520a4 846 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 847
7fcccf1e
PE
8482011-06-23 Paul Eggert <eggert@cs.ucla.edu>
849
7efb4e0e
PE
850 Integer and buffer overflow fixes (Bug#8873).
851
ff5844ad
PE
852 * print.c (printchar, strout): Check for string overflow.
853 (PRINTPREPARE, printchar, strout):
854 Don't set size unless allocation succeeds.
855
90532f02
PE
856 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
857 for sizes. Check for string overflow more accurately.
858 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
859
6d84508d
PE
860 * macros.c: Integer and buffer overflow fixes.
861 * keyboard.h (struct keyboard.kbd_macro_bufsize):
862 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
863 Use ptrdiff_t, not int, for sizes.
864 Don't increment bufsize until after realloc succeeds.
865 Check for size-calculation overflow.
866 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
867
437b2cb4
PE
868 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
869
8b9ac8b4
PE
870 * lread.c: Integer overflow fixes.
871 (read_integer): Radix is now EMACS_INT, not int,
872 to improve quality of diagnostics for out-of-range radices.
873 Calculate buffer size correctly for out-of-range radices.
874 (read1): Check for integer overflow in radices, and in
875 read-circle numbers.
82cb60d3
PE
876 (read_escape): Avoid int overflow.
877 (Fload, openp, read_buffer_size, read1)
878 (substitute_object_recurse, read_vector, read_list, map_obarray):
879 Use ptrdiff_t, not int, for sizes.
880 (read1): Use EMACS_INT, not int, for sizes.
20270765 881 Check for size overflow.
8b9ac8b4 882
7fcccf1e
PE
883 * image.c (cache_image): Check for size arithmetic overflow.
884
bfbbd7e7
PE
885 * lread.c: Integer overflow issues.
886 (saved_doc_string_size, saved_doc_string_length)
887 (prev_saved_doc_string_size, prev_saved_doc_string_length):
888 Now ptrdiff_t, not int.
889 (read1): Don't assume doc string length fits in int. Check for
890 out-of-range doc string lengths.
891 (read_list): Don't assume file position fits in int.
39019e54 892 (read_escape): Check for hex character overflow.
bfbbd7e7 893
4e323265
LL
8942011-06-22 Leo Liu <sdl.web@gmail.com>
895
896 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
897 Move to minibuffer.el.
898
85fece3e
PE
8992011-06-22 Paul Eggert <eggert@cs.ucla.edu>
900
20b84ce9 901 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
902 The following patches are for when GLYPH_DEBUG && !XASSERT.
903 * dispextern.h (trace_redisplay_p, dump_glyph_string):
904 * dispnew.c (flush_stdout):
905 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
906 Mark as externally visible.
907 * dispnew.c (check_window_matrix_pointers): Now static.
908 * dispnew.c (window_to_frame_vpos):
909 * xfns.c (unwind_create_frame):
910 * xterm.c (x_check_font): Remove unused local.
911 * scroll.c (CHECK_BOUNDS):
912 * xfaces.c (cache_fache): Rename local to avoid shadowing.
913 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
914 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
915 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
916 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
917 Now static.
918 (debug_method_add): Use va_list and vsprintf rather than relying
919 on undefined behavior with wrong number of arguments.
920 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
921 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
922 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
923 since we're not interested in debugging glyphs with old libraries.
924 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
925 GCC 4.6.0's static checking.
926
0766b489
PE
9272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
928
31fd4b32
PE
929 Integer overflow and signedness fixes (Bug#8873).
930 A few related buffer overrun fixes, too.
931
b79e8648
PE
932 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
933
0766b489
PE
934 * dispextern.h (struct face.stipple):
935 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
936 (x_bitmap_mask, x_allocate_bitmap_record)
937 (x_create_bitmap_from_data, x_create_bitmap_from_file)
938 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
939 (x_create_bitmap_from_xpm_data):
940 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
941 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
942 (.bitmaps_last):
943 * xfaces.c (load_pixmap):
944 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
945 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
946 (.bitmaps_last, struct x_output.icon_bitmap):
947 Use ptrdiff_t, not int, for bitmap indexes.
948 (x_allocate_bitmap_record): Check for size overflow.
949 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
950
b081724f
PE
951 Use ptrdiff_t, not int, for overlay counts.
952 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
953 * editfns.c (overlays_around, get_pos_property):
954 * textprop.c (get_char_property_and_overlay):
955 * xdisp.c (next_overlay_change, note_mouse_highlight):
956 * xfaces.c (face_at_buffer_position):
21514da7
PE
957 * buffer.c (OVERLAY_COUNT_MAX): New macro.
958 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
959 (Fnext_overlay_change, Fprevious_overlay_change)
960 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 961 Use ptrdiff_t, not int, for sizes.
21514da7 962 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 963
3de73e5e
PE
964 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
965
2606c57b
PE
966 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
967 (x_session_initialize): Do not assume string length fits in int.
968
aaafe47a
PE
969 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
970 This is unlikely, but can occur if DPI is outlandish.
971
2674ddc8 972 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
973 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
974
28154962
PE
975 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
976 * xrdb.c (magic_file_p, search_magic_path):
977 Omit last arg SUFFIX; it was always 0. All callers changed.
978 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
979
7de51af5
PE
980 * xfont.c (xfont_match): Avoid need for strlen.
981
25ed6cc3
PE
982 * xfns.c: Don't assume strlen fits in int.
983 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
984
4eab31dd
PE
985 * xdisp.c (message_log_check_duplicate): Return intmax_t,
986 not unsigned long, as we prefer signed integers. All callers changed.
987 Detect integer overflow in repeat count.
988 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 989 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 990
171e2a58
PE
991 * termcap.c: Don't assume sizes fit in int and never overflow.
992 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
993 (gobble_line): Check for size-calculation overflow.
994
ad39faca 995 * minibuf.c (Fread_buffer):
6e5bb2dc 996 * lread.c (intern, intern_c_string):
74ca2eb3
PE
997 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
998 Don't assume string length fits in int.
999
52c61c22 1000 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1001 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1002
b5b8c9e5
PE
1003 * font.c: Don't assume string length fits in int.
1004 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1005 Use ptrdiff_t, not int.
ccd6111c
PE
1006 (font_intern_prop): Don't assume string length fits in int.
1007 Don't assume integer property fits in fixnum.
1008 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1009
882f0d81 1010 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1011 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1012 Reformulate so as not to need the command string.
1013 Invoke gzip -cd rather than gunzip, as it's more portable.
1014 (lock_info_type, lock_file_1, lock_file):
1015 Don't assume pid_t and time_t fit in unsigned long.
1016 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1017 (current_lock_owner): Prefer signed type for sizes.
1018 Use memcpy, not strncpy, where memcpy is what is really wanted.
1019 Don't assume (via atoi) that time_t and pid_t fit in int.
1020 Check for time_t and/or pid_t out of range, e.g., via a network share.
1021 Don't alloca where an auto var works fine.
1022
93f4cf88
PE
1023 * fileio.c: Fix some integer overflow issues.
1024 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1025 Don't assume string length fits in int.
1026 (directory_file_name): Don't assume string length fits in long.
1027 (make_temp_name): Don't assume pid fits in int, or that its print
1028 length is less than 20.
1029
f3e92b69
PE
1030 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1031
1bfdaf10
PE
1032 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1033
35016e9a
PE
1034 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1035
3d1e65a1
PE
1036 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1037 We prefer signed integers, even for size calculations.
1038
0b963a93
PE
1039 * emacs.c: Don't assume string length fits in 'int'.
1040 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1041 (main): Don't invoke strlen when not needed.
1042
573f4b54
PE
1043 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1044 (XD_DEBUG_MESSAGE): Don't waste a byte.
1045
989f33ba
PE
1046 * callproc.c (getenv_internal_1, getenv_internal)
1047 (Fgetenv_internal):
965d34eb
PE
1048 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1049
e4d29b33
PE
1050 * lread.c (invalid_syntax): Omit length argument.
1051 All uses changed. This doesn't fix a bug, but it simplifies the
1052 code away from its former Hollerith-constant appearance, and it's
1053 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1054 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1055
eb49b136
PE
1056 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1057 This didn't break anything, but it didn't help either.
1058 It's confusing to put a bogus integer in a place where the actual
1059 value does not matter.
9f62aeb1 1060 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1061 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1062
15375a22
PE
1063 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1064 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1065 implementation.
b61cc01c
PE
1066 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1067 We prefer signed types, and the value cannot exceed the EMACS_INT
1068 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1069 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1070 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1071 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1072
53b2623d
PE
1073 * indent.c (sane_tab_width): New function.
1074 (current_column, scan_for_column, Findent_to, position_indentation)
1075 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1076 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1077
51cab52b 1078 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1079
f2ed8a70
PE
1080 * lisp.h (lint_assume): New macro.
1081 * composite.c (composition_gstring_put_cache):
1082 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1083
abe80cc6
PE
1084 * editfns.c, insdel.c:
1085 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1086
b02c740e
PE
1087 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1088
ebc96716
PE
1089 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1090
b4e50fa0 1091 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1092 Use much-faster test for byte-length change.
311d5d7c 1093 Don't assume string byte-length fits in 'int'.
a4cf38e4 1094 Check that character arg fits in 'int'.
85461888 1095 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1096
c0c1ee9f
PE
1097 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1098
a498d7f4
PE
1099 * fns.c (concat): Catch string overflow earlier.
1100 Do not rely on integer wraparound.
1101
51cab52b
PE
1102 * dispextern.h (struct it.overlay_strings_charpos)
1103 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1104 * xdisp.c (forward_to_next_line_start)
1105 (back_to_previous_visible_line_start)
1106 (reseat_at_next_visible_line_start, next_element_from_buffer):
1107 Don't arbitrarily truncate the value of 'selective' to int.
1108
76031fad
PE
1109 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1110
5eb55db9
PE
1111 * composite.c: Don't truncate sizes to 'int'.
1112 (composition_gstring_p, composition_reseat_it)
1113 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1114 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1115 not EMACS_UINT, for indexes.
5eb55db9 1116
0703a717
PE
1117 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1118
d6202519
PE
1119 * buffer.c: Include <verify.h>.
1120 (struct sortvec.priority, struct sortstr.priority):
8961a454 1121 Now EMACS_INT, not int.
c20998a7 1122 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1123 (struct sortstr.size, record_overlay_string)
1124 (struct sortstrlist.size, struct sortlist.used):
1125 Don't truncate size to int.
1126 (record_overlay_string): Check for size-calculation overflow.
d6202519 1127 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1128
d5a19415
JM
11292011-06-22 Jim Meyering <meyering@redhat.com>
1130
029529ac 1131 Don't leak an XBM-image-sized buffer
d5a19415
JM
1132 * image.c (xbm_load): Free the image buffer after using it.
1133
a9041e6c
PE
11342011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1135
1136 Port to Sun C.
1137 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1138 that Sun C diagnosed.
1139 * fns.c (secure_hash): Fix pointer signedness issue.
1140 * intervals.c (static_offset_intervals): New function.
1141 (offset_intervals): Use it.
1142
7f3f739f
LL
11432011-06-21 Leo Liu <sdl.web@gmail.com>
1144
1145 * deps.mk (fns.o):
1146 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1147 sha512.h.
1148
1149 * fns.c (secure_hash): Rename from crypto_hash_function and change
1150 the first arg to accept symbols.
5b66d427 1151 (Fsecure_hash): New primitive.
7f3f739f
LL
1152 (syms_of_fns): New symbols.
1153
76147d94
DD
11542011-06-20 Deniz Dogan <deniz@dogan.se>
1155
1156 * process.c (Fset_process_buffer): Clarify return value in
1157 docstring.
1158
7d7d0045
CY
11592011-06-18 Chong Yidong <cyd@stupidchicken.com>
1160
1161 * dispnew.c (add_window_display_history): Use BVAR.
1162
1163 * xdisp.c (debug_method_add): Use BVAR.
1164 (check_window_end, dump_glyph_matrix, dump_glyph)
1165 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1166
1167 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1168 Likewise.
1169
1170 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1171 check till after the cache is created in init_frame_faces.
1172
ff2bc410
SM
11732011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1174
1175 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1176
28177add
PE
11772011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1178
dd3482fe
PE
1179 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1180 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1181 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1182
393d71f3 1183 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1184 * fileio.c (Finsert_file_contents):
1185 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1186 Remove the old (too-loose) buffer overflow checks.
1187 They weren't needed, since make_gap checks for buffer overflow.
1188 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1189 The old code merely checked for Emacs fixnum overflow, and relied
1190 on undefined (wraparound) behavior. The new code avoids undefined
1191 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1192
2e6813b0 1193 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1194 Tune. Don't use wider integers than needed. Don't use alloca.
1195 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1196
599a9e4f
PE
1197 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1198
99561444
PE
1199 * insdel.c, lisp.h (buffer_overflow): New function.
1200 (insert_from_buffer_1, replace_range, replace_range_2):
1201 * insdel.c (make_gap_larger):
1202 * editfns.c (Finsert_char):
1203 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1204
28177add
PE
1205 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1206
e69dafad
PE
12072011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1208
a7af7fde 1209 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1210
b1c46f02
PE
1211 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1212 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1213
e69dafad
PE
1214 * fileio.c: Don't assume EMACS_INT fits in off_t.
1215 (emacs_lseek): New static function.
1216 (Finsert_file_contents, Fwrite_region): Use it.
1217 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1218
566684ea
PE
1219 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1220
e6966cd6
PE
1221 * fns.c: Don't overflow int when computing a list length.
1222 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1223 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1224 truncation on 64-bit hosts. Check for QUIT every
1225 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1226 faster and is responsive enough.
1227 (Flength): Report an error instead of overflowing an integer.
1228 (Fsafe_length): Return a float if the value is not representable
1229 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1230 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1231 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1232
dd0b0efb
PE
1233 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1234 (header_size, word_size): New constants.
1235 (allocate_vectorlike): Don't check size overflow here.
1236 (allocate_vector): Check it here instead, since this is the only
1237 caller of allocate_vectorlike that could cause overflow.
1238 Check that the new vector's length is representable as a fixnum.
1239
86fe5cfe
PE
1240 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1241 The previous code was bogus. For example, next_almost_prime (32)
1242 returned 39, which is undesirable as it is a multiple of 3; and
1243 next_almost_prime (24) returned 25, which is a multiple of 5 so
1244 why was the code bothering to check for multiples of 7?
1245
80e88859
PE
1246 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1247
4a2f0ad6
PE
1248 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1249
f66c7cf8
PE
1250 Variadic C functions now count arguments with ptrdiff_t.
1251 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1252 Back then I didn't know that the Emacs coding style prefers signed int.
1253 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1254 were being counted with int, which may truncate counts on 64-bit
1255 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1256 * lisp.h (struct Lisp_Subr.function.aMANY)
1257 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1258 Arg counts are now ptrdiff_t, not size_t.
1259 All variadic functions and their callers changed accordingly.
1260 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1261 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1262 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1263 * callint.c (Fcall_interactively): Check arg count for overflow,
1264 to avoid potential buffer overrun. Use signed char, not 'int',
1265 for 'varies' array, so that we needn't bother to check its size
1266 calculation for overflow.
1267 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1268 * eval.c (apply_lambda):
1269 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1270 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1271 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1272
a1759b76
PE
1273 * callint.c (Fcall_interactively): Don't use index var as event count.
1274
d96be9fc
PE
1275 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1276 * mem-limits.h (SIZE): Remove; no longer used.
1277
a690a978 1278 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1279
578c21e6
PE
1280 Remove unnecessary casts.
1281 * xterm.c (x_term_init):
1282 * xfns.c (x_set_border_pixel):
1283 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1284 These aren't needed now that we assume ANSI C.
1285
96f53c6c
PE
1286 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1287 It's more likely to cause problems (due to unsigned overflow)
1288 than to cure them.
1289
83c77d31
PE
1290 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1291
ee2079f1
PE
1292 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1293
6da65536
PE
1294 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1295
7147c4a4
PE
1296 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1297
193e32d9
PE
1298 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1299
e5533da6
PE
1300 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1301
9910e595
PE
1302 GLYPH_CODE_FACE returns EMACS_INT, not int.
1303 * dispextern.h (merge_faces):
1304 * xfaces.c (merge_faces):
01103c44
PE
1305 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1306 Don't assume EMACS_INT fits in int.
9910e595 1307
2638320e
PE
1308 * character.h (CHAR_VALID_P): Remove unused parameter.
1309 * fontset.c, lisp.h, xdisp.c: All uses changed.
1310
045eb8d9
PE
1311 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1312
c1f134b5
PE
1313 * fns.c (concat): Minor tuning based on overflow analysis.
1314 This doesn't fix any bugs. Use int to hold character, instead
1315 of constantly refetching from Emacs object. Use XFASTINT, not
1316 XINT, for value known to be a character. Don't bother comparing
1317 a single byte to 0400, as it's always less.
1318
395fcb93 1319 * floatfns.c (Fexpt):
327eeec8
PE
1320 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1321
abbd3d23
PE
1322 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1323 for characters.
1324
684a03ef
PE
1325 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1326
0fed43f3
PE
1327 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1328 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1329 incorrectly succeed when S was a string, because 4294967386 was
1330 truncated before it was used.
1331
8fd02eb7
PE
1332 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1333 Otherwise, an out-of-range integer could cause undefined behavior
1334 on a 64-bit host.
1335
f8c86b69
PE
1336 * composite.c: Use int, not EMACS_INT, for characters.
1337 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1338 EMACS_INT, for values that are known to be in character range.
1339 This doesn't fix any bugs but is the usual style inside Emacs and
1340 may generate better code on 32-bit machines.
1341
34206dd2
PE
1342 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1343 This is for reasons similar to the recent CHAR_STRING fix.
1344 * charset.c (Fencode_char): Check that character arg is actually
1345 a character. Pass an int to ENCODE_CHAR.
1346 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1347 wider than 'int', as a compile-time check to prevent future regressions
1348 in this area.
1349
c5958d4c 1350 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1351
1352 Make sure a 64-bit char is never passed to CHAR_STRING.
1353 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1354 by silently ignoring the top 32 bits, allowing some values
1355 that were far too large to be valid characters.
1356 * character.h: Include <verify.h>.
1357 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1358 arguments are no wider than unsigned, as a compile-time check
1359 to prevent future regressions in this area.
1360 * data.c (Faset):
01103c44 1361 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1362 (Fsubst_char_in_region):
1363 * fns.c (concat):
1364 * xdisp.c (decode_mode_spec_coding):
1365 Adjust to CHAR_STRING's new requirement.
1366 * editfns.c (Finsert_char, Fsubst_char_in_region):
1367 * fns.c (concat): Check that character args are actually
1368 characters. Without this test, these functions did the wrong
1369 thing with wildly out-of-range values on 64-bit hosts.
1370
d37ca623
PE
1371 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1372 These casts should not be needed on 32-bit hosts, either.
1373 * keyboard.c (read_char):
1374 * lread.c (Fload): Remove casts to unsigned.
1375
ea204efb
PE
1376 * lisp.h (UNSIGNED_CMP): New macro.
1377 This fixes comparison bugs on 64-bit hosts.
1378 (ASCII_CHAR_P): Use it.
1379 * casefiddle.c (casify_object):
01103c44 1380 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1381 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1382 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1383 * dispextern.h (FACE_FROM_ID):
1384 * keyboard.c (read_char): Use UNSIGNED_CMP.
1385
41cb286c
PE
1386 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1387 not to EMACS_INT, to avoid GCC warning.
1388
4a1b9832
PE
1389 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1390
55daad71
PE
1391 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1392 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1393 isn't needed on 32-bit machines.
8f95c75c 1394
01103c44
PE
1395 * buffer.c (Fgenerate_new_buffer_name):
1396 Use EMACS_INT for count, not int.
0ceccced 1397 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1398
1399 * data.c (Qcompiled_function): Now static.
1400
c6f072e7
PE
1401 * window.c (window_body_lines): Now static.
1402
20ce5912
PE
1403 * image.c (gif_load): Rename local to avoid shadowing.
1404
9c4c5f81
PE
1405 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1406 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1407 * alloc.c (make_save_value): Integer argument is now of type
1408 ptrdiff_t, not int.
1409 (mark_object): Use ptrdiff_t, not int.
1410 * lisp.h (pD): New macro.
1411 * print.c (print_object): Use it.
1412
c0c5c8ae
PE
1413 * alloc.c: Use EMACS_INT, not int, to count objects.
1414 (total_conses, total_markers, total_symbols, total_vector_size)
1415 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1416 (total_free_floats, total_floats, total_free_intervals)
1417 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1418 Now EMACS_INT, not int. All uses changed.
1419 (Fgarbage_collect): Compute overall total using a double, so that
1420 integer overflow is less likely to be a problem. Check for overflow
1421 when converting back to an integer.
5a25e253
PE
1422 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1423 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1424 These were 'int' variables that could overflow on 64-bit hosts;
1425 they were never used, so remove them instead of repairing them.
211a0b2a 1426 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1427 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1428 Previously, this ceilinged at INT_MAX, but that doesn't work on
1429 64-bit machines.
e46bb31a 1430 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1431
c78baabf 1432 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1433 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1434 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1435 when a (possibly-narrower) signed value would do just as well.
1436 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1437
c9d624c6
PE
1438 * alloc.c: Catch some string size overflows that we were missing.
1439 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1440 for convenience in STRING_BYTES_MAX.
1441 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1442 The definition here is exact; the one in lisp.h was approximate.
1443 (allocate_string_data): Check for string overflow. This catches
1444 some instances we weren't catching before. Also, it catches
1445 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1446 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1447 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1448
c9d624c6
PE
1449 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1450 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1451 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1452
353032ce
PE
1453 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1454
2bccce07
PE
1455 * alloc.c (Fmake_string): Check for out-of-range init.
1456
0ac30604
SM
14572011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1458
1459 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1460
c195f2de
JD
14612011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1462
1463 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1464 xg_get_default_scrollbar_width.
1465
1466 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1467 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1468 (style_changed_cb): Call update_theme_scrollbar_width and call
1469 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1470 all frames (Bug#8505).
1471 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1472 Call gtk_window_set_resizable if HAVE_GTK3.
1473 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1474 and height if HAVE_GTK3 (Bug#8505).
1475 (scroll_bar_width_for_theme): New variable.
1476 (update_theme_scrollbar_width): New function.
1477 (xg_get_default_scrollbar_width): Move code to
1478 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1479 (xg_initialize): Call update_theme_scrollbar_width.
1480
1481 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1482
1483 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1484
e10ac9f1
MR
14852011-06-12 Martin Rudalics <rudalics@gmx.at>
1486
1487 * frame.c (make_frame): Call other_buffer_safely instead of
1488 other_buffer.
1489
1490 * window.c (temp_output_buffer_show): Call display_buffer with
1491 second argument Vtemp_buffer_show_specifiers and reset latter
1492 immediately after the call.
1493 (Vtemp_buffer_show_specifiers): New variable.
1494 (auto_window_vscroll_p, next_screen_context_lines)
1495 (Vscroll_preserve_screen_position): Remove leading asterisks from
1496 doc-strings.
1497
2d3c217e 14982011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1499
7b7f97e8 1500 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1501 * buffer.c (Qclone_number): Remove for now, as it's unused.
1502 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1503 (record_buffer): Remove unused local.
1504 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1505 (set_frame_buffer_list): Remove; unused.
1506 * frame.h (other_visible_frames): Remove decl.
1507 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1508 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1509 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1510 if HAVE_GPM.
1511 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1512 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1513 Define only if HAVE_GPM.
1514 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1515 (update_hints_inhibit): Remove; never set. All uses removed.
1516 * widgetprv.h (emacsFrameClassRec): Remove decl.
1517 * window.c (delete_deletable_window): Now returns void, since it
1518 wasn't returning anything.
1519 (compare_window_configurations): Remove unused locals.
1520 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1521 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1522 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1523 the same widths as pointers. This follows up on the 2011-05-06 patch.
1524 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1525 * xterm.h: Likewise.
1526 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1527
1384b89e
JB
15282011-06-12 Juanma Barranquero <lekktu@gmail.com>
1529
1530 * makefile.w32-in: Update dependencies.
1531 (LISP_H): Add lib/intprops.h.
1532
1100a63c
CY
15332011-06-11 Chong Yidong <cyd@stupidchicken.com>
1534
1535 * image.c (gif_load): Add animation frame delay to the metadata.
1536 (syms_of_image): Use DEFSYM. New symbol `delay'.
1537
6198ccd0
MR
15382011-06-11 Martin Rudalics <rudalics@gmx.at>
1539
1540 * window.c (delete_deletable_window): Re-add.
1541 (Fset_window_configuration): Rewrite to handle dead buffers and
1542 consequently deletable windows.
1543 (window_tree, Fwindow_tree): Remove. Supply functionality in
1544 window.el.
1545 (compare_window_configurations): Simplify code.
1546
b6e3633c
AS
15472011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1548
1ab0dee5
AS
1549 * image.c (imagemagick_load_image): Fix type mismatch.
1550 (Fimagemagick_types): Likewise.
1551
b6e3633c
AS
1552 * window.h (replace_buffer_in_windows): Declare.
1553
9397e56f
MR
15542011-06-11 Martin Rudalics <rudalics@gmx.at>
1555
1556 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1557 Qclone_number. Remove external declaration of Qdelete_window.
1558 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1559 code.
1560 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1561 Qbuffer_list_update_hook if allowed.
1562 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1563 buffer list implementation.
1564 (other_buffer_safely): New function.
1565 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1566 calls to replace_buffer_in_windows and
1567 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1568 if allowed.
1569 (record_buffer): Inhibit quitting and rewrite using quittable
1570 functions. Run Qbuffer_list_update_hook if allowed.
1571 (Frecord_buffer, Funrecord_buffer): New functions.
1572 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1573 switch-to-buffer to window.el.
1574 (bury-buffer): Move to window.el.
1575 (Vbuffer_list_update_hook): New variable.
1576
1577 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1578 section.
1579
1580 * window.h (resize_frame_windows): Move up in code.
1581 (Fwindow_frame): Remove EXFUN.
1582 (replace_buffer_in_all_windows): Remove prototype.
1583 (replace_buffer_in_windows_safely): Add prototype.
1584
1585 * window.c: Declare Qdelete_window static again. Move down
1586 declaration of select_count.
1587 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1588 (Fother_window): Move to window.el.
1589 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1590 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1591 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1592 window.el.
1593 (replace_buffer_in_windows): Implement by calling
1594 Qreplace_buffer_in_windows.
1595 (replace_buffer_in_all_windows): Remove with some functionality
1596 moved into replace_buffer_in_windows_safely.
1597 (replace_buffer_in_windows_safely): New function.
1598 (select_window_norecord, select_frame_norecord): Move in front
1599 of run_window_configuration_change_hook. Remove now obsolete
1600 declarations.
1601 (Fset_window_buffer): Rewrite doc-string. Call
1602 Qrecord_window_buffer.
1603 (keys_of_window): Move binding for other-window to window.el.
1604
b50691aa
CY
16052011-06-11 Chong Yidong <cyd@stupidchicken.com>
1606
1607 * dispextern.h (struct image): Replace data member, whose int_val
1608 and ptr_val fields were not used by anything, with a single
1609 lisp_val object.
1610
1611 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1612 (gif_clear_image, gif_load, imagemagick_load_image)
1613 (gs_clear_image, gs_load): Callers changed.
1614
3f754b86
PE
16152011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1616
cca69397
PE
1617 * buffer.h: Include <time.h>, for time_t.
1618 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1619
109e28d0
PE
1620 Fix minor problems found by static checking.
1621
60737f02
PE
1622 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1623
4b66faf3
PE
1624 Make identifiers static if they are not used in other modules.
1625 * data.c (Qcompiled_function, Qframe, Qvector):
1626 * image.c (QimageMagick, Qsvg):
1627 * minibuf.c (Qmetadata):
1628 * window.c (resize_window_check, resize_root_window): Now static.
1629 * window.h (resize_window_check, resize_root_window): Remove decls.
1630
109e28d0
PE
1631 * window.c (window_deletion_count, delete_deletable_window):
1632 Remove; unused.
46a4ce9e
PE
1633 (window_body_lines): Now static.
1634 (Fdelete_other_windows_internal): Mark vars as initialized.
1635 Make sure 'resize_failed' is initialized.
1636 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1637 (resize_window_apply): Remove unused local.
1638 * window.h (delete_deletable_window): Remove decl.
1639
109e28d0 1640 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1641 (imagemagick_load_image): Fix pointer signedness problem by changing
1642 last arg from unsigned char * to char *. All uses changed.
1643 Also, fix a local for similar reasons.
1644 Remove unused locals. Remove locals to avoid shadowing.
1645 (fn_rsvg_handle_free): Remove; unused.
1646 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1647 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1648
3f754b86
PE
1649 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1650
2547adb1
CY
16512011-06-10 Chong Yidong <cyd@stupidchicken.com>
1652
1653 * image.c (gif_load): Fix omitted cast error introduced by
1654 2011-06-06 change.
1655
2c8e37d4
MR
16562011-06-10 Martin Rudalics <rudalics@gmx.at>
1657
1658 * window.h (resize_proportionally, orig_total_lines)
1659 (orig_top_line): Remove from window structure.
1660 (set_window_height, set_window_width, change_window_heights)
1661 (Fdelete_window): Remove prototypes.
1662 (resize_frame_windows): Remove duplicate declaration.
1663
440a42e3
EZ
16642011-06-10 Eli Zaretskii <eliz@gnu.org>
1665
1666 * window.h (resize_frame_windows, resize_window_check)
1667 (delete_deletable_window, resize_root_window)
1668 (resize_frame_windows): Declare prototypes.
1669
1670 * window.c (resize_window_apply): Make definition be "static" to
1671 match the prototype.
1672
562dd5e9
MR
16732011-06-10 Martin Rudalics <rudalics@gmx.at>
1674
1675 * window.c: Remove declarations of Qwindow_size_fixed,
1676 window_min_size_1, window_min_size_2, window_min_size,
1677 size_window, window_fixed_size_p, enlarge_window, delete_window.
1678 Remove static from declaration of Qdelete_window, it's
1679 temporarily needed by Fbury_buffer.
1680 (replace_window): Don't assign orig_top_line and
1681 orig_total_lines.
1682 (Fdelete_window, delete_window): Remove. Window deletion is
1683 handled by window.el.
1684 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1685 Fdelete_window calls with calls to Qdelete_window.
1686 (Fdelete_other_windows): Remove. Deleting other windows is
1687 handled by window.el.
1688 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1689 handled in window.el.
1690 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1691 Window minimum sizes are handled in window.el.
1692 (shrink_windows, size_window, set_window_height)
1693 (set_window_width, change_window_heights, window_height)
1694 (window_width, CURBEG, CURSIZE, enlarge_window)
1695 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1696 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1697 handled in window.el.
1698 (make_dummy_parent): Rename to make_parent_window and give it a
1699 second argument horflag.
1700 (make_window): Don't set resize_proportionally any more.
1701 (Fsplit_window): Remove. Windows are split in window.el.
1702 (save_restore_action, save_restore_orig_size)
1703 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1704 Resize mini windows in window.el.
1705 (grow_mini_window, shrink_mini_window): Implement by calling
1706 Qresize_root_window_vertically, resize_window_check and
1707 resize_window_apply.
1708 (saved_window, Fset_window_configuration, save_window_save): Do
1709 not handle orig_top_line, orig_total_lines, and
1710 resize_proportionally.
1711 (window_min_height, window_min_width): Move to window.el.
1712 (keys_of_window): Move bindings for delete-other-windows,
1713 split-window, delete-window and enlarge-window to window.el.
1714
1715 * buffer.c: Temporarily extern Qdelete_window.
1716 (Fbury_buffer): Temporarily call Qdelete_window instead of
1717 Fdelete_window (Fbury_buffer will move to window.el soon).
1718
1719 * frame.c (set_menu_bar_lines_1): Remove code handling
1720 orig_top_line and orig_total_lines.
1721
1722 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1723 set_window_height but set heights directly.
1724 (change_frame_size_1): Use resize_frame_windows.
1725
1726 * xdisp.c (init_xdisp): Don't use set_window_height but set
1727 heights directly.
1728
1729 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1730 resize_frame_windows instead of change_window_heights and run
1731 run_window_configuration_change_hook.
1732
1733 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1734 instead of change_window_heights and run
1735 run_window_configuration_change_hook.
1736
1a13852e
MR
17372011-06-09 Martin Rudalics <rudalics@gmx.at>
1738
1739 * window.c (replace_window): Rename second argument REPLACEMENT to
1740 NEW. New third argument SETFLAG. Rewrite.
1741 (delete_window, make_dummy_parent): Call replace_window with
1742 third argument 1.
1743 (window_list_1): Move down in code.
1744 (run_window_configuration_change_hook): Move set_buffer part
1745 before select_frame_norecord part in order to unwind correctly.
1746 Rename count1 to count.
1747 (recombine_windows, delete_deletable_window, resize_root_window)
1748 (Fdelete_other_windows_internal)
1749 (Frun_window_configuration_change_hook, make_parent_window)
1750 (resize_window_check, resize_window_apply, Fresize_window_apply)
1751 (resize_frame_windows, Fsplit_window_internal)
1752 (Fdelete_window_internal, Fresize_mini_window_internal): New
1753 functions.
1754 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1755
f3d1777e
MR
17562011-06-08 Martin Rudalics <rudalics@gmx.at>
1757
496e208e
MR
1758 * window.h (window): Add some new members to window structure -
1759 normal_lines, normal_cols, new_total, new_normal, clone_number,
1760 splits, nest, prev_buffers, next_buffers.
1761 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1762 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1763
f3d1777e
MR
1764 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1765 Remove.
496e208e
MR
1766 (make_dummy_parent): Set new members of windows structure.
1767 (make_window): Move down in code. Handle new members of window
1768 structure.
1769 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1770 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1771 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1772 (Fset_window_prev_buffers, Fwindow_next_buffers)
1773 (Fset_window_next_buffers, Fset_window_clone_number): New
1774 functions.
1775 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1776 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1777 Doc-string fixes.
1778 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1779 Argument WINDOW can be now internal window too.
1780 (Fwindow_use_time): Move up in code.
1781 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1782 Rewrite doc-string.
1783 (Fset_window_configuration, saved_window)
1784 (Fcurrent_window_configuration, save_window_save): Handle new
1785 members of window structure.
b9e809c2
MR
1786 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1787 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1788 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1789 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1790 Qget_mru_window, Qresize_root_window,
1791 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1792 Qauto_buffer_name; staticpro them.
f3d1777e 1793
abde8f8c
MR
17942011-06-07 Martin Rudalics <rudalics@gmx.at>
1795
1796 * window.c (Fwindow_total_size, Fwindow_left_column)
1797 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1798 (Fwindow_list_1): New functions.
1799 (window_box_text_cols): Replace with window_body_cols.
1800 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1801 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1802 (delete_window, Fset_window_configuration): Call
1803 delete_all_subwindows with window as argument.
1804 (delete_all_subwindows): Take a window as argument and not a
1805 structure. Rewrite.
190b47e6
MR
1806 (window_loop): Remove handling of GET_LRU_WINDOW and
1807 GET_LARGEST_WINDOW.
1808 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1809
1810 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1811 window_box_text_cols. delete_all_subwindows now takes a
1812 Lisp_Object as argument.
abde8f8c
MR
1813
1814 * indent.c (compute_motion, Fcompute_motion): Use
1815 window_body_cols instead of window_box_text_cols.
1816
fa8a67e6
MR
1817 * frame.c (delete_frame): Call delete_all_subwindows with root
1818 window as argument.
1819
a54e3482
DC
18202011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1821
1822 * fns.c (Fputhash): Document return value.
1823
60002bf5
CY
18242011-06-06 Chong Yidong <cyd@stupidchicken.com>
1825
1826 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1827
0c671da6 18282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1829
b862a52a 1830 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1831
be44ca6c
PE
1832 Check for overflow when converting integer to cons and back.
1833 * charset.c (Fdefine_charset_internal, Fdecode_char):
1834 Use cons_to_unsigned to catch overflow.
1835 (Fencode_char): Use INTEGER_TO_CONS.
1836 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1837 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1838 * data.c (long_to_cons, cons_to_long): Remove.
1839 (cons_to_unsigned, cons_to_signed): New functions.
1840 These signal an error for invalid or out-of-range values.
1841 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1842 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1843 * font.c (Ffont_variation_glyphs):
1844 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1845 * lisp.h: Include <intprops.h>.
1846 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1847 (cons_to_signed, cons_to_unsigned): New decls.
1848 (long_to_cons, cons_to_long): Remove decls.
1849 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1850 (Fprimitive_undo): Use CONS_TO_INTEGER.
1851 * xfns.c (Fx_window_property): Likewise.
1852 * xselect.c: Include <limits.h>.
1853 (x_own_selection, selection_data_to_lisp_data):
1854 Use INTEGER_TO_CONS.
1855 (x_handle_selection_request, x_handle_selection_clear)
1856 (x_get_foreign_selection, Fx_disown_selection_internal)
1857 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1858 (lisp_data_to_selection_data): Use cons_to_unsigned.
1859 (x_fill_property_data): Use cons_to_signed.
1860 Report values out of range.
1861
d1f3d2af
PE
1862 Check for buffer and string overflow more precisely.
1863 * buffer.h (BUF_BYTES_MAX): New macro.
1864 * lisp.h (STRING_BYTES_MAX): New macro.
1865 * alloc.c (Fmake_string):
1866 * character.c (string_escape_byte8):
1867 * coding.c (coding_alloc_by_realloc):
1868 * doprnt.c (doprnt):
1869 * editfns.c (Fformat):
1870 * eval.c (verror):
1871 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1872 since they may not be the same number.
1873 * editfns.c (Finsert_char):
1874 * fileio.c (Finsert_file_contents):
1875 Likewise for BUF_BYTES_MAX.
1876
dd52fcea
PE
1877 * image.c: Use ptrdiff_t, not int, for sizes.
1878 (slurp_file): Switch from int to ptrdiff_t.
1879 All uses changed.
1880 (slurp_file): Check that file size fits in both size_t (for
1881 malloc) and ptrdiff_t (for sanity and safety).
1882
7f9bbdbb
PE
1883 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1884 if b->modtime has its maximal value.
1885
dfe18f82
PE
1886 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1887
84acfcf0
PE
1888 Don't assume time_t can fit into int.
1889 * buffer.h (struct buffer.modtime): Now time_t, not int.
1890 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1891 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1892
ccd9a01a
PE
1893 Minor fixes for signed vs unsigned integers.
1894 * character.h (MAYBE_UNIFY_CHAR):
1895 * charset.c (maybe_unify_char):
1896 * keyboard.c (read_char, reorder_modifiers):
1897 XINT -> XFASTINT, since the integer must be nonnegative.
1898 * ftfont.c (ftfont_spec_pattern):
1899 * keymap.c (access_keymap, silly_event_symbol_error):
1900 XUINT -> XFASTINT, since the integer must be nonnegative.
1901 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1902 since it makes no difference and we prefer signed.
1903 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1904 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1905 nonnegative.
1906
d6d100dd
SM
19072011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1908
1909 * window.h (Fwindow_frame): Declare.
1910
2b6148e4
PE
19112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1914 (SPARE_MEMORY): Always define.
1915 (LARGE_REQUEST): Remove.
1916 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1917
f230ecc9
MR
19182011-06-06 Martin Rudalics <rudalics@gmx.at>
1919
727e958e
MR
1920 * lisp.h: Move EXFUNS for Fframe_root_window,
1921 Fframe_first_window and Fset_frame_selected_window to window.h.
1922
1923 * window.h: Move EXFUNS for Fframe_root_window,
1924 Fframe_first_window and Fset_frame_selected_window here from
1925 lisp.h.
1926
1927 * frame.c (Fwindow_frame, Fframe_first_window)
1928 (Fframe_root_window, Fframe_selected_window)
1929 (Fset_frame_selected_window): Move to window.c.
1930 (Factive_minibuffer_window): Move to minibuf.c.
1931 (Fother_visible_frames_p): New function.
1932
1933 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1934
f230ecc9
MR
1935 * window.c (decode_window, decode_any_window): Move up in code.
1936 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1937 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1938 (Fwindow_buffer): Move up and rewrite doc-string.
1939 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1940 (Fwindow_prev): New functions.
727e958e
MR
1941 (Fwindow_frame): Move here from frame.c. Accept any window as
1942 argument.
1943 (Fframe_root_window, Fframe_first_window)
1944 (Fframe_selected_window): Move here from frame.c. Accept frame
1945 or arbitrary window as argument. Update doc-strings.
1946 (Fminibuffer_window): Move up in code.
1947 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1948 (Fset_frame_selected_window): Move here from frame.c.
1949 Marginal rewrite.
727e958e
MR
1950 (Fselected_window, select_window, Fselect_window): Move up in
1951 code. Minor doc-string fixes.
f230ecc9 1952
4d09bcf6
PE
19532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1956 Do not assume that spare memory exists; that assumption is valid
1957 only if SYSTEM_MALLOC.
1958 (LARGE_REQUEST): New macro, so that the issue of large requests
1959 is separated from the issue of spare memory.
1960
810928a2
AS
19612011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1962
172418ad
AS
1963 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1964 format. (Bug#8806)
1965
43f862f7
AS
1966 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1967
810928a2
AS
1968 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1969 before statements.
1970
a059fe24
JD
19712011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1972
1973 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1974
1975 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1976
1977 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1978 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1979
989bf368
JB
19802011-06-05 Juanma Barranquero <lekktu@gmail.com>
1981
1982 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1983
4b80f674
CY
19842011-06-04 Chong Yidong <cyd@stupidchicken.com>
1985
1986 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1987 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1988 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1989 New error handlers.
4b80f674
CY
1990 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1991 Obey Vx_select_enable_clipboard_manager. Catch errors in
1992 x_clipboard_manager_save (Bug#8779).
1993 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1994 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1995
99a33b77 19962011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1997
1998 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1999
99a33b77 20002011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2001
2002 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2003 in the current matrix if keep_current_p is non-zero.
2004
8264569d
EZ
20052011-06-04 Eli Zaretskii <eliz@gnu.org>
2006
2007 * bidi.c (bidi_level_of_next_char): Fix last change.
2008
57f97249
EZ
20092011-06-03 Eli Zaretskii <eliz@gnu.org>
2010
fec2107c 2011 Support bidi reordering of text covered by display properties.
57f97249 2012
fec2107c
EZ
2013 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2014 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2015 (bidi_cache_search, bidi_cache_iterator_state)
2016 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2017 (bidi_level_of_next_char, bidi_move_to_visually_next):
2018 Support character positions inside a run of characters covered by a
fec2107c
EZ
2019 display string.
2020 (bidi_paragraph_init, bidi_resolve_explicit_1)
2021 (bidi_level_of_next_char): Call bidi_fetch_char and
2022 bidi_fetch_char_advance instead of FETCH_CHAR and
2023 FETCH_CHAR_ADVANCE.
2024 (bidi_init_it): Initialize new members.
2025 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2026 definitions.
2027 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2028 instead of using explicit *_CHAR codes.
d6d100dd
SM
2029 (bidi_resolve_explicit, bidi_resolve_weak):
2030 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2031 bidirectional text is supported only in multibyte buffers.
2032 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2033 it to initialize the frame_window_p member of struct bidi_it.
2034 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2035 (bidi_resolve_explicit, bidi_resolve_weak)
2036 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2037 bidi_it->nchars is non-positive.
2038 (bidi_level_of_next_char): Don't try to lookup the cache for the
2039 next/previous character if nothing is cached there yet, or if we
2040 were just reseat()'ed to a new position.
c40e2fb2 2041
0e14fe90
EZ
2042 * xdisp.c (set_cursor_from_row): Set start and stop points
2043 according to the row's direction when priming the loop that looks
2044 for the glyph on which to display cursor.
2045 (single_display_spec_intangible_p): Function deleted.
2046 (display_prop_intangible_p): Reimplement to call
2047 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2048 Accept 3 additional arguments needed by handle_display_spec.
2049 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2050 values: lists, `(when COND...)' forms, etc.
2051 (single_display_spec_string_p): Support property values that are
2052 lists with the argument STRING its top-level element.
2053 (display_prop_string_p): Fix the condition for processing a
2054 property that is a list to be consistent with handle_display_spec.
fec2107c 2055 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2056 last portion of handle_display_prop.
2057 (compute_display_string_pos): Accept additional argument
2058 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2059 value of a `display' property is a "replacing spec".
2060 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2061 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2062 the display property, but just return a value indicating whether
2063 the display property will replace the characters it covers.
2064 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2065 frame_window_p members of struct bidi_it.
d6d100dd
SM
2066 (compute_display_string_pos, compute_display_string_end):
2067 New functions.
fec2107c
EZ
2068 (push_it): Accept second argument POSITION, where pop_it should
2069 jump to continue iteration.
2070 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2071
fec2107c
EZ
2072 * keyboard.c (adjust_point_for_property): Adjust the call to
2073 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2074
2075 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2076 (bidi_init_it): Update prototypes.
2077 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2078 (compute_display_string_pos, compute_display_string_end):
2079 Declare prototypes.
fec2107c
EZ
2080 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2081 EMACS_INT.
fc6f18ce 2082
40087514 20832011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2084
57f53182
PE
2085 Malloc failure behavior now depends on size of allocation.
2086 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2087 * lisp.h: Change signatures accordingly.
2088 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2089 All callers changed. (Bug#8762)
2090
2091 * gnutls.c: Use Emacs's memory allocators.
2092 Without this change, the gnutls library would invoke malloc etc.
2093 directly, which causes problems on non-SYNC_INPUT hosts, and which
2094 runs afoul of improving memory_full behavior. (Bug#8761)
2095 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2096 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2097 xfree instead of the default malloc, realloc, free.
2098 (Fgnutls_boot): No need to check for memory allocation failure,
2099 since xmalloc does that for us.
2100
ac32cd99 2101 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2102 * category.c (hash_get_category_set):
2103 * ccl.c (ccl_driver):
2104 * charset.c (Fdefine_charset_internal):
2105 * charset.h (struct charset.hash_index):
2106 * composite.c (get_composition_id, gstring_lookup_cache)
2107 (composition_gstring_put_cache):
2108 * composite.h (struct composition.hash_index):
2109 * dispextern.h (struct image.hash):
2110 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2111 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2112 (hashfn_equal, hashfn_user_defined, make_hash_table)
2113 (maybe_resize_hash_table, hash_lookup, hash_put)
2114 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2115 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2116 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2117 * image.c (make_image, search_image_cache, lookup_image)
2118 (xpm_put_color_table_h):
2119 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2120 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2121 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2122 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2123 * alloc.c (allocate_vectorlike):
2124 Check for overflow in vector size calculations.
2125 * ccl.c (ccl_driver):
2126 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2127 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2128 need to be updated by these changes.
40087514
PE
2129 * fns.c (make_hash_table, maybe_resize_hash_table):
2130 Check for integer overflow with large hash tables.
0de4bb68
PE
2131 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2132 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2133 (SXHASH_REDUCE): New macro.
2134 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2135 Use it instead of discarding useful hash info with large hash values.
2136 (sxhash_float): New function.
2137 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2138 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2139 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2140 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2141 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2142 Adjust signatures to match updated version of code.
2143 (consing_since_gc): Now EMACS_INT, since a single hash table can
2144 use more than INT_MAX bytes.
2145
698d32e2
DN
21462011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2147
2148 Make it possible to build with GCC-4.6+ -O2 -flto.
2149
2150 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2151
fd6fa53f
SM
21522011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2153
2154 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2155 Call minibuffer-inactive-mode.
2156
864db017
JB
21572011-05-31 Juanma Barranquero <lekktu@gmail.com>
2158
2159 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2160 Update dependencies.
2161
2ad0baf4
DN
21622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2163
2164 * data.c (init_data): Remove code for UTS, this system is not
2165 supported anymore.
2166
4fcc2638
DN
21672011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2168
2169 Don't force ./temacs to start in terminal mode.
2170
2171 * frame.c (make_initial_frame): Initialize faces in all cases, not
2172 only when CANNOT_DUMP is defined.
2173 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2174
c56e0fd5
DN
21752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2176
2177 * dispnew.c (add_window_display_history): Use const for the string
2178 pointer. Remove declaration, not needed.
2179
333d54da 21802011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2181
55d4c1b2 2182 Use 'inline', not 'INLINE'.
333d54da 2183 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2184 * alloc.c, fontset.c (INLINE): Remove.
2185 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2186 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2187 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2188 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2189 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2190
738db178
DN
21912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2192
2193 Make it possible to run ./temacs.
2194
2195 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2196 syms_of_callproc does the same thing. Remove test for
2197 "initialized", do it in the caller.
2198 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2199
620c53a6
SM
22002011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2201
2202 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2203 (read_minibuf): Use get_minibuffer.
2204 (syms_of_minibuf): Use DEFSYM.
2205 (Qmetadata): New var.
2206 * data.c (Qbuffer): Don't make it static.
2207 (syms_of_data): Use DEFSYM.
2208
e003a292
PE
22092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2212 (CCL_CODE_MIN): New macro.
2213
ed008a6d
PE
22142011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2215
3687c2ef
PE
2216 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2217
ed008a6d
PE
2218 * eval.c (Qdebug): Now static.
2219 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2220 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2221 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2222
d66c4c7c
CY
22232011-05-29 Chong Yidong <cyd@stupidchicken.com>
2224
2225 * image.c: Various fixes to ImageMagick code comments.
2226 (Fimagemagick_types): Doc fix.
2227
5fbc2025
PE
22282011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2229
0196f88a
PE
2230 Minor fixes prompted by GCC 4.6.0 warnings.
2231
2232 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2233
5fbc2025
PE
2234 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2235 (x_clipboard_manager_save_all): Move extern decl to ...
2236 * xterm.h: ... here, so that it can be checked for consistency.
2237
1dd3c2d9
CY
22382011-05-29 Chong Yidong <cyd@stupidchicken.com>
2239
2240 * xselect.c (x_clipboard_manager_save_frame)
2241 (x_clipboard_manager_save_all): New functions.
2242 (Fx_clipboard_manager_save): Lisp function deleted.
2243
2244 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2245 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2246
2247 * xterm.h: Update prototype.
2248
5ba6571d
WX
22492011-05-28 William Xu <william.xwl@gmail.com>
2250
2251 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2252 exiting (Bug#8239).
2253
3eaff834
JM
22542011-05-28 Jim Meyering <meyering@redhat.com>
2255
e1900994 2256 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2257 * fns.c (to_uchar): Define.
2258 (crypto_hash_function): Use it to convert some newly-signed
2259 variables to unsigned, to avoid sign-extension bugs. For example,
2260 without this change, (md5 "truc") would evaluate to
2261 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2262 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2263 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2264
0f6990a7
PE
22652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 Integer overflow fixes.
c8a9ca5a 2268
08686060
PE
2269 * dbusbind.c: Serial number integer overflow fixes.
2270 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2271 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2272 to hold a serial number that is too large for a fixnum.
2273 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2274 Check for serial numbers out of range. Decode any serial number
59568bf0 2275 that was so large that it became a float. (Bug#8722)
08686060 2276
2d1fc3c7
PE
2277 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2278 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2279 Use XFASTINT rather than XUINT when numbers are nonnegative.
2280 (xd_append_arg, Fdbus_method_return_internal):
2281 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2282 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2283 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2284 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2285 (Bug#8722)
2d1fc3c7 2286
c8a9ca5a
PE
2287 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2288
519e1d69
PE
2289 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2290
30569699
PE
2291 ccl: add integer overflow checks
2292 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2293 (IN_INT_RANGE): New macros.
2294 (ccl_driver): Use them to check for integer overflow when
2295 decoding a CCL program. Many of the new checks are whether XINT (x)
2296 fits in int; it doesn't always, on 64-bit hosts. The new version
2297 doesn't catch all possible integer overflows, but it's an
847044ea 2298 improvement. (Bug#8719)
30569699 2299
c11285dc
PE
2300 * alloc.c (make_event_array): Use XINT, not XUINT.
2301 There's no need for unsigned here.
2302
fdccd48e
PE
2303 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2304 This follows up to the 2011-05-06 change that substituted uintptr_t
2305 for EMACS_INT. This case wasn't caught back then.
2306
37910ab2
PE
2307 Rework Fformat to avoid integer overflow issues.
2308 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2309 now (part of C89). Include <verify.h>.
2310 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2311 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2312 (Fformat): Avoid the prepass trying to compute sizes; it was only
2313 approximate and thus did not catch overflow reliably. Instead, walk
2314 through the format just once, formatting and computing sizes as we go,
2315 checking for integer overflow at every step, and allocating a larger
2316 buffer as needed. Keep track separately whether the format is
2317 multibyte. Keep only the most-recently calculated precision, rather
2318 than them all. Record whether each argument has been converted to
2319 string. Use EMACS_INT, not int, for byte and char and arg counts.
2320 Support field widths and precisions larger than INT_MAX. Avoid
2321 sprintf's undefined behavior with conversion specifications such as %#d
2322 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2323 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2324 formatting out-of-range floating point numbers with int
9173deec 2325 formats. (Bug#8668)
37910ab2 2326
2e6578fb
PE
2327 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2328
0ae6bdee
PE
2329 * data.c: Avoid integer truncation in expressions involving floats.
2330 * data.c: Include <intprops.h>.
2331 (arith_driver): When there's an integer overflow in an expression
2332 involving floating point, convert the integers to floating point
2333 so that the resulting value does not suffer from catastrophic
2334 integer truncation. For example, on a 64-bit host (* 4
2335 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2336 Do not rely on undefined behavior after integer overflow.
2337
de883a70
PE
2338 merge count_size_as_multibyte, parse_str_to_multibyte
2339 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2340 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2341 Check for integer overflow.
2342 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2343 since it's now a duplicate of the other. This is more of
2344 a character than a buffer op, so better that it's in character.c.
2345 * fns.c, print.c: Adjust to above changes.
2346
2ff916cb
PE
23472011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2348
2349 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2350
f1b54466
PE
23512011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2352
fb1ac845
PE
2353 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2354 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2355 (x_clipboard_manager_save): Now static.
2356 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2357
f1b54466
PE
2358 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2359 (crypto_hash_function): Now static.
2360 Fix pointer signedness problems. Avoid unnecessary initializations.
2361
a9f737ee
CY
23622011-05-27 Chong Yidong <cyd@stupidchicken.com>
2363
2364 * termhooks.h (Vselection_alist): Make it terminal-local.
2365
2366 * terminal.c (create_terminal): Initialize it.
2367
2368 * xselect.c: Support for clipboard managers.
2369 (Vselection_alist): Move to termhooks.h as terminal-local var.
2370 (LOCAL_SELECTION): New macro.
2371 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2372 (symbol_to_x_atom): Remove gratuitous arg.
2373 (x_handle_selection_request, lisp_data_to_selection_data)
2374 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2375 (x_own_selection, x_get_local_selection, x_convert_selection):
2376 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2377 (some_frame_on_display): Delete unused function.
2378 (Fx_own_selection_internal, Fx_get_selection_internal)
2379 (Fx_disown_selection_internal, Fx_selection_owner_p)
2380 (Fx_selection_exists_p): New optional frame arg.
2381 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2382 (x_handle_selection_clear): Don't treat other terminals with the
2383 same keyboard specially. Use the terminal-local Vselection_alist.
2384 (x_clear_frame_selections): Use Frun_hook_with_args.
2385
2386 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2387
2388 * xterm.h: Add support for those atoms.
2389
e067f0c1
CY
23902011-05-26 Chong Yidong <cyd@stupidchicken.com>
2391
2392 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2393 (converted_selections, conversion_fail_tag): New global variables.
2394 (x_selection_request_lisp_error): Free the above.
2395 (x_get_local_selection): Remove unnecessary code.
2396 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2397 of converted selections stored in converted_selections.
2398 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2399 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2400 (x_convert_selection): New function.
2401 (x_handle_selection_event): Simplify.
2402 (x_get_foreign_selection): Don't ignore incoming requests while
2403 waiting for an answer; this will fail when we implement
2404 SAVE_TARGETS, and seems unnecessary anyway.
2405 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2406 (Vx_sent_selection_functions): Doc fix.
2407
0f4aebc0
LL
24082011-05-26 Leo Liu <sdl.web@gmail.com>
2409
2410 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2411
e61124cd
YM
24122011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2413
2414 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2415
2416 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2417 for fringe update if it has periodic bitmap.
ac389d0c 2418 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2419 and fringe_bitmap_periodic_p.
2420
2421 * fringe.c (get_fringe_bitmap_data): New function.
2422 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2423 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2424 row. Mark glyph row for fringe update if periodicity changed.
2425
2426 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2427 for fringe update unless it has periodic bitmap.
2428
f16d9837
KH
24292011-05-25 Kenichi Handa <handa@m17n.org>
2430
2431 * xdisp.c (get_next_display_element): Set correct it->face_id for
2432 a static composition.
2433
e1b90ef6
LL
24342011-05-24 Leo Liu <sdl.web@gmail.com>
2435
2436 * deps.mk (fns.o):
2437 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2438
2439 * fns.c (crypto_hash_function, Fsha1): New function.
2440 (Fmd5): Use crypto_hash_function.
2441 (syms_of_fns): Add Ssha1.
2442
7400048f
PE
24432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * gnutls.c: Remove unused macros.
2446 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2447 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2448 Remove macros that are defined and never used.
2449 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2450
abb71cf4
CY
24512011-05-22 Chong Yidong <cyd@stupidchicken.com>
2452
2453 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2454 (Fx_get_selection_internal): Minor cleanup.
2455 (Fx_own_selection_internal): Rename arguments for consistency with
2456 select.el.
2457
6307db39
PE
24582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2461
f3d4e0a4
CY
24622011-05-22 Chong Yidong <cyd@stupidchicken.com>
2463
2464 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2465
4d8ade89
YM
24662011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2467
2468 * dispnew.c (scrolling_window): Don't exclude the case that the
2469 last enabled row in the desired matrix touches the bottom boundary.
2470
32078c8d
GM
24712011-05-21 Glenn Morris <rgm@gnu.org>
2472
2473 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2474 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2475 and add some more files.
32078c8d 2476
7285dc67
EZ
24772011-05-20 Eli Zaretskii <eliz@gnu.org>
2478
2479 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2480 report_file_error introduced by the change from 2011-05-07.
2481
89d1bd22
PE
24822011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 * systime.h (Time): Define only if emacs is defined.
2485 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2486 where the include path doesn't have X11/X.h by default. See
2487 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2488
e23640bb 24892011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2490
2491 * composite.c (find_automatic_composition): Fix previous change.
2492
b9704ad9
GM
24932011-05-20 Glenn Morris <rgm@gnu.org>
2494
2495 * lisp.mk: New file, split from Makefile.in.
2496 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2497 (shortlisp): Remove.
2498 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2499
4a720484
GM
25002011-05-19 Glenn Morris <rgm@gnu.org>
2501
2502 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2503 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2504 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2505 (lisp): Set the order to that of loadup.el.
2506 (shortlisp): Make it a copy of $lisp.
2507 (SOME_MACHINE_LISP): Remove.
2508 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2509 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2510
a28d4396
KH
25112011-05-18 Kenichi Handa <handa@m17n.org>
2512
2513 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2514 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2515 (find_automatic_composition): Mostly rewrite for efficiency.
2516
a2b1fa8e
JB
25172011-05-18 Juanma Barranquero <lekktu@gmail.com>
2518
2519 * makefile.w32-in: Update dependencies.
2520
8e1f5610
CS
25212011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2522
2523 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2524 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2525
7025ee00 25262011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2527
cdfa6eab
PE
2528 Fix some integer overflow issues, such as string length overflow.
2529
06d6db33
PE
2530 * insdel.c (count_size_as_multibyte): Check for string overflow.
2531
2b4560a8
PE
2532 * character.c (lisp_string_width): Check for string overflow.
2533 Use EMACS_INT, not int, for string indexes and lengths; in
2534 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2535 the resulting string length overflows an EMACS_INT; instead,
2536 report a string overflow if no precision given. When checking for
2537 precision exhaustion, use a check that cannot possibly have
2538 integer overflow. (Bug#8675)
2539 * character.h (lisp_string_width): Adjust to new signature.
2540
cb93f9be
PE
2541 * alloc.c (string_overflow): New function.
2542 (Fmake_string): Use it. This doesn't change behavior, but saves
2543 a few bytes and will simplify future changes.
2544 * character.c (string_escape_byte8): Likewise.
2545 * lisp.h (string_overflow): New decl.
2546
1a1f3366
PE
2547 Fixups, following up to the user-interface timestamp change.
2548 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2549 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2550 * msdos.c (mouse_get_pos): Likewise.
2551 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2552 * w32gui.h (Time): Define by including "systime.h" rather than by
2553 declaring it ourselves. (Bug#8664)
2554
d4e3e4d3
PE
2555 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2556 * image.c (clear_image_cache): Likewise.
2557
f6a24d19
PE
2558 * term.c (term_mouse_position): Don't assume time_t wraparound.
2559
08dc5ae6
PE
2560 Be more systematic about user-interface timestamps.
2561 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2562 and sometimes 'EMACS_UINT', to represent these timestamps.
2563 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2564 This makes the code easier to follow, and makes it easier to catch
2565 integer overflow bugs such as Bug#8664.
2566 * frame.c (Fmouse_position, Fmouse_pixel_position):
2567 Use Time, not unsigned long, for user-interface timestamps.
2568 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2569 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2570 * keyboard.h (last_event_timestamp): Likewise.
2571 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2572 * menu.h (xmenu_show): Likewise.
2573 * term.c (term_mouse_position): Likewise.
2574 * termhooks.h (struct input_event.timestamp): Likewise.
2575 (struct terminal.mouse_position_hook): Likewise.
2576 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2577 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2578 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2579 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2580 what it was before.
2581 * menu.h, termhooks.h: Include "systime.h", for Time.
2582
8e55734a
PE
2583 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2584 Don't assume that the difference between two unsigned long values
2585 can fit into an integer. At this point, we know button_down_time
2586 <= event->timestamp, so the difference must be nonnegative, so
2587 there's no need to cast the result if double-click-time is
2588 nonnegative, as it should be; check that it's nonnegative, just in
2589 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2590 apart (about 25 days). (Bug#8664)
8e55734a 2591
841f1b75 2592 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2593 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2594
3e26f69c
PE
2595 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2596 that always fit in int. Use a sentinel instead of a counter, to
2597 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2598 * frame.h (struct frame): Use int for menu_bar_items_used
2599 instead of EMACS_INT, since it always fits in int.
3e26f69c 2600
5cc152c0
PE
2601 * menu.c (grow_menu_items): Check for int overflow.
2602
d89eb65e
PE
2603 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2604
5235bd3e
PE
2605 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2606 Before, the code was not consistent. These values cannot exceed
2607 2**31 - 1 so there's no need to make them unsigned.
2608 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2609 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2610 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2611 as modifiers.
2612 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2613
bc827e23
PE
2614 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2615 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2616 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2617 presumably because the widths might not match.
2618
78eb494e
PE
2619 * window.c (size_window): Avoid needless test at loop start.
2620
04f2d78b
CB
26212011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2622
2623 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2624
d2fc7e3d 26252011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2626
2627 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2628
d2fc7e3d 26292011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2630
2631 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2632 `width' to `bar_area_x' and `bar_area_width', respectively.
2633 (x_scroll_run): Take account of fringe background extension.
2634
04f2d78b
CB
2635 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2636 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2637 `bar_area_width', respectively.
2638 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2639 background extension.
2640
79b70037
GM
26412011-05-10 Jim Meyering <meyering@redhat.com>
2642
2643 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2644
2f142cc5
JB
26452011-05-10 Juanma Barranquero <lekktu@gmail.com>
2646
2647 * image.c (Finit_image_library): Return t for built-in image types,
2648 like pbm and xbm. (Bug#8640)
2649
57679c86
AS
26502011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2651
2652 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2653
888c9e86
EZ
26542011-05-07 Eli Zaretskii <eliz@gnu.org>
2655
b0512a1d
EZ
2656 * w32console.c (Fset_screen_color): Doc fix.
2657 (Fget_screen_color): New function.
2658 (syms_of_ntterm): Defsubr it.
2659
7285dc67
EZ
2660 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2661 unlink the temporary file if Fcall_process didn't create it in the
2662 first place.
2663 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2664 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2665 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2666 cue to call_process_cleanup not to close that handle.
2667
4d3fcc8e
BK
26682011-05-07 Ben Key <bkey76@gmail.com>
2669
2670 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2671 one of two shell specific rules, either bootstrap-temacs-CMD or
2672 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2673 to the previous implementation of the bootstrap-temacs rule.
2674 The bootstrap-temacs-CMD rule is similar to the previous
2675 implementation of the bootstrap-temacs rule except that it
2676 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2677 variable.
2678
2679 These changes, along with some changes to nt/configure.bat,
2680 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2681 earlier fix to add support for --cflags and --ldflags options
2682 that include quotes so that it works whether make uses cmd or
2683 sh as the shell.
2684
b4289b64
MA
26852011-05-06 Michael Albinus <michael.albinus@gmx.de>
2686
2687 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2688 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2689 is a constant.
2690 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2691 a string. Handle both cases.
2692 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2693 (Fdbus_register_method): Use Qinvalid_function.
2694
af4c0e28
JB
26952011-05-06 Juanma Barranquero <lekktu@gmail.com>
2696
2697 * makefile.w32-in: Update dependencies.
2698 (LISP_H): Add inttypes.h and stdin.h.
2699 (PROCESS_H): Add unistd.h.
2700
c51453d9
EZ
27012011-05-06 Eli Zaretskii <eliz@gnu.org>
2702
2703 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2704 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2705
8ff0ac3c 27062011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2707
4c4b566b
PE
2708 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2709
aab2b9b5
PE
2710 * term.c (vfatal): Remove stray call to va_end.
2711 It's not needed and the C Standard doesn't allow it here anyway.
2712
c378da0b
PE
2713 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2714 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2715
288b08c7
PE
2716 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2717 bytes.
2718
e3601888
PE
2719 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2720
db6c0e74
PE
2721 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2722
dd5963ea
PE
2723 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2724
88c9450f
PE
2725 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2726
2f9442b8
PE
2727 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2728
c032b5f8
PE
2729 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2730 * charset.c (Fdefine_charset_internal): Don't initialize
2731 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2732 32-bit int (Bug#8600).
a108c10b
PE
2733
2734 * lread.c (read_integer): Be more consistent with string-to-number.
2735 Use string_to_number to do the actual conversion; this avoids
2736 rounding errors and fixes some other screwups. Without this fix,
2737 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2738 (digit_to_number): Move earlier, for benefit of read_integer.
2739 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2740 not a digit in any supported base. (Bug#8602)
a108c10b 2741
ad5f9eea
PE
2742 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2743
aec1708a
PE
2744 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2745 to match comment at start of function. This also removes a
2746 GCC warning about overflow in a 32+64-bit port.
2747
47be4ab5
PE
2748 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2749
371cac43
PE
2750 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2751 Reported by Stefan Monnier in
2752 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2753 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2754 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2755
d01a7826
PE
2756 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2757 (EMACS_UINTPTR): Likewise, with uintptr_t.
2758
7fd47d5c
PE
2759 * lisp.h: Prefer 64-bit EMACS_INT if available.
2760 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2761 on 32-bit hosts that have 64-bit int, so that they can access
2762 large files.
122b0c86
PE
2763 However, temporarily disable this change unless the temporary
2764 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2765
8727937b
PE
2766 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2767
8ac068ac
PE
2768 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2769 This removes an assumption that EMACS_INT and long are the same
2770 width as pointers. The assumption is true for Emacs porting targets
2771 now, but we want to make other targets possible.
2772 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2773 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2774 In the rest of the code, change types of integers that hold casted
2775 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2776 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2777 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2778 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2779 No need to cast type when ORing.
2780 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2781 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2782 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2783 assume EMACS_INT is the same width as char *.
2784 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2785 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2786 Remove no-longer-needed casts.
2787 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2788 (xg_tool_bar_help_callback, xg_make_tool_item):
2789 Use EMACS_INTPTR to hold an integer
2790 that will be cast to void *; this can avoid a GCC warning
2791 if EMACS_INT is not the same width as void *.
2792 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2793 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2794 (current_message_1, set_message_1):
2795 Use a local to convert to proper width without a cast.
2796 * xmenu.c (dialog_selection_callback): Likewise.
2797
ede49d71
PE
2798 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2799 Also, don't assume VALBITS / RAND_BITS is less than 5,
2800 and don't rely on undefined behavior when shifting a 1 left into
2801 the sign bit.
2802 * lisp.h (get_random): Change signature to match.
2803
2f30ecd0
PE
2804 * lread.c (hash_string): Use size_t, not int, for hash computation.
2805 Normally we prefer signed values; but hashing is special, because
2806 it's better to use unsigned division on hash table sizes so that
2807 the remainder is nonnegative. Also, size_t is the natural width
2808 for hashing into memory. The previous code used 'int', which doesn't
2809 retain enough info to hash well into very large tables.
2810 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2811
2a866e7b
PE
2812 * dbusbind.c: Don't possibly lose pointer info when converting.
2813 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2814 Use XPNTR rather than XHASH, so that the high-order bits of
2815 the pointer aren't lost when converting through void *.
2816
51639eac
PE
2817 * eval.c (Fautoload): Don't double-shift a pointer.
2818
92394119
PE
2819 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2820
dbdb9a7c
JB
28212011-05-06 Juanma Barranquero <lekktu@gmail.com>
2822
2823 * gnutls.c (DEF_GNUTLS_FN):
2824 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2825
db7a0b4f
AS
28262011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2827
2828 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2829 marker. (Bug#8610)
2830
f7ff1b0f 28312011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2832
2833 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2834 New version that can reserve upto 2GB of heap space.
2835
f7ff1b0f 28362011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2837
2838 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2839
639c109b
TZ
28402011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2841
2842 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2843 `gnutls_certificate_set_x509_key_file'.
2844
d2127135
JB
28452011-05-05 Juanma Barranquero <lekktu@gmail.com>
2846
2847 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2848 Update dependencies.
2849
e968f4f3
JB
28502011-05-04 Juanma Barranquero <lekktu@gmail.com>
2851
2852 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2853 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2854 Remove unused parameter `fildes'.
2855 * process.c (read_process_output, send_process): Don't pass it.
2856
84d358f0
JB
28572011-05-04 Juanma Barranquero <lekktu@gmail.com>
2858
2859 Fix previous change: the library cache is defined in w32.c.
2860 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2861 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2862
0898ca10
JB
28632011-05-04 Juanma Barranquero <lekktu@gmail.com>
2864
2865 Implement dynamic loading of GnuTLS on Windows.
2866
2867 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2868 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2869 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2870 Declare.
2871
2872 * gnutls.c (Qgnutls_dll): Define.
2873 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2874 (gnutls_*): Declare function pointers.
2875 (init_gnutls_functions): New function to initialize function pointers.
2876 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2877 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2878 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2879 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2880 (emacs_gnutls_write, emacs_gnutls_read)
2881 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2882 (Fgnutls_available_p): New function.
2883 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2884 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2885 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2886
2887 * image.c: Include w32.h.
2888 (Vimage_type_cache): Delete.
2889 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2890 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2891 (w32_delayed_load): Move to w32.c.
2892
2893 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2894
2895 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2896 (w32_delayed_load): Move from image.c. When loading a library, record
2897 its filename in the :loaded-from property of the library id.
2898 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2899 Initialize and staticpro them.
2900 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2901
2902 * process.c: Include lisp.h before w32.h, not after.
2903 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2904 instead of gnutls_record_check_pending.
2905
2906 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2907
ff4de4aa
TZ
29082011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2909
2910 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2911 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2912 as passed in.
2913
abe95abb
JD
29142011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2915
2916 * xterm.c (x_set_frame_alpha): Do not set property on anything
2917 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2918
e16e55d4
JB
29192011-05-02 Juanma Barranquero <lekktu@gmail.com>
2920
2921 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2922
bafcf6a5
JB
29232011-05-02 Juanma Barranquero <lekktu@gmail.com>
2924
2925 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2926 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2927 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2928 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2929 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2930 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2931 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2932 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2933 (Qgnutls_bootprop_callbacks_verify): Make static.
2934
e7a6747f
AS
29352011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2936
19ed11ba
AS
2937 * callproc.c: Indentation fixup.
2938
e7a6747f 2939 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2940 (wait_for_termination, interruptible_wait_for_termination):
2941 Move after wait_for_termination_1.
e7a6747f 2942
1ef14cb4
LMI
29432011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2944
2945 * sysdep.c (interruptible_wait_for_termination): New function
2946 which is like wait_for_termination, but allows keyboard
2947 interruptions.
2948
2949 * callproc.c (Fcall_process): Add (:file "file") as an option for
2950 the STDOUT buffer.
2951 (Fcall_process_region): Ditto.
2952
330d880c
EZ
29532011-04-30 Eli Zaretskii <eliz@gnu.org>
2954
8db90b73
EZ
2955 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2956 rather than `XVECTOR (FOO)->size'.
2957
330d880c
EZ
2958 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2959 inttypes.h, as a gnulib replacement is used if it not available in
2960 system headers.
2961
15cbd324
EZ
29622011-04-21 Eli Zaretskii <eliz@gnu.org>
2963
2964 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2965 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2966 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2967
2968 * coding.c (coding_alloc_by_realloc): Error out if destination
2969 will grow beyond MOST_POSITIVE_FIXNUM.
2970 (decode_coding_emacs_mule): Abort if there isn't enough place in
2971 charbuf for the composition carryover bytes. Reserve an extra
2972 space for up to 2 characters produced in a loop.
2973 (decode_coding_iso_2022): Abort if there isn't enough place in
2974 charbuf for the composition carryover bytes.
2975
29762011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2977
ae940cca
EZ
2978 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2979 aborting when %lld or %lll format is passed.
2980 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2981 %llo or %llx format is passed. (Bug#8545)
2982
03ab8921
EZ
2983 * window.c (window_scroll_line_based): Use a marker instead of
2984 simple variables to record original value of point. (Bug#7952)
2985
afda1437
EZ
2986 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2987 produced by %s or %c overflows available buffer space. (Bug#8545)
2988
f76dee0c
PE
29892011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2992 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2993
fdc5744d
JB
29942011-04-28 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2997
638f053a
JB
29982011-04-28 Juanma Barranquero <lekktu@gmail.com>
2999
3000 * keyboard.c (Qdelayed_warnings_hook): Define.
3001 (command_loop_1): Run `delayed-warnings-hook'
3002 if Vdelayed_warnings_list is non-nil.
3003 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3004 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3005
d178f871
EZ
30062011-04-28 Eli Zaretskii <eliz@gnu.org>
3007
3008 * doprnt.c (doprnt): Don't return value smaller than the buffer
3009 size if the message was truncated. (Bug#8545).
3010
b124fd93
JB
30112011-04-28 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3014 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3015
e810457d
PE
30162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3017
3018 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3019
ea51cceb
JB
30202011-04-27 Juanma Barranquero <lekktu@gmail.com>
3021
3022 * makefile.w32-in: Update dependencies.
3023
94dcfacf
EZ
30242011-04-27 Eli Zaretskii <eliz@gnu.org>
3025
3026 Improve `doprnt' and its usage. (Bug#8545)
3027 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3028 `format_end'. Remove support for %l as a conversion specifier.
3029 Don't use xrealloc. Improve diagnostics when the %l size modifier
3030 is used. Update the commentary.
3031
3032 * eval.c (verror): Simplify calculation of size_t.
3033
3034 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3035 messages.
3036
f61f41d7
PE
30372011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3038
3039 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3040 change.
3041
96fb4434
PE
30422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3045 This makes this file independent of the recent pseudovector change.
3046
671875da 30472011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3048
69e9b5a3
PE
3049 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3050
b5f869a7 3051 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3052 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3053 Remove unused local.
c8926152 3054 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3055
841a1577 3056 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3057 GCC 4.6.0 optimizes based on type-based alias analysis.
3058 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3059 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3060 != &v->size, and therefore "v->size = 1; b->size = 2; return
3061 v->size;" must therefore return 1. This assumption is incorrect
3062 for Emacs, since it type-puns struct Lisp_Vector * with many other
3063 types. To fix this problem, this patch adds a new type struct
f904488f 3064 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3065 and pseudovectors, and helps optimizing compilers not get fooled
3066 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3067 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3068 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3069 the size member.
eab3844f
PE
3070 (XSETPVECTYPE): Rewrite in terms of new macro.
3071 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3072 This is a bit clearer, and further avoids the possibility of
3073 undesirable aliasing.
3074 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3075 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3076 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3077 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3078 (ASIZE): Now uses header.size rather than size.
3079 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3080 to avoid the hassle of writing XVECTOR (foo)->header.size.
3081 (struct vectorlike_header): New type.
eab3844f
PE
3082 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3083 object, to help avoid aliasing.
3084 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3085 (SUBRP): Likewise, since Lisp_Subr is a special case.
3086 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3087 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3088 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3089 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3090 changed to be "header.size" and "header.next".
3091 * buffer.h (struct buffer): Likewise.
3092 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3093 * frame.h (struct frame): Likewise.
3094 * process.h (struct Lisp_Process): Likewise.
3095 * termhooks.h (struct terminal): Likewise.
3096 * window.c (struct save_window_data, struct saved_window): Likewise.
3097 * window.h (struct window): Likewise.
3098 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3099 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3100 * buffer.c (init_buffer_once): Likewise.
3101 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3102 special case.
3103 * process.c (Fformat_network_address): Use local var for size,
3104 for brevity.
3105
0df1eac5
PE
3106 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3107
847ab9d1 3108 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3109 * data.c (atof): Remove decl; no longer used or needed.
3110 (digit_to_number): Move to lread.c.
3111 (Fstring_to_number): Use new string_to_number function, to be
3112 consistent with how the Lisp reader treats infinities and NaNs.
3113 Do not assume that floating-point numbers represent EMACS_INT
3114 without losing information; this is not true on most 64-bit hosts.
3115 Avoid double-rounding errors, by insisting on integers when
3116 parsing non-base-10 numbers, as the documentation specifies.
3117 * lisp.h (string_to_number): New decl, replacing ...
3118 (isfloat_string): Remove.
bc0a5c13 3119 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3120 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3121 appears to have been a coding error. Similarly, do not accept
3122 strings like +-1e0 as floating point numbers. Do not report
3123 overflow for integer overflows unless the base is not 10 which
3124 means we have no simple and reliable way to continue.
3125 Break out the floating-point parsing into a new
3126 function string_to_number, so that Fstring_to_number parses
3127 floating point numbers consistently with the Lisp reader.
04f2d78b 3128 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3129 (E_CHAR, EXP_INT): Remove, replacing with ...
3130 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3131 (string_to_number): New function, replacing isfloat_string.
3132 This function checks for valid syntax and produces the resulting
3133 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3134 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3135 so that overflow for non-base-10 numbers is reported only when
3136 there's no portable and simple way to convert to floating point.
452f4150 3137
67769ffc
PE
3138 * textprop.c (set_text_properties_1): Rewrite for clarity,
3139 and to avoid GCC warning about integer overflow.
3140
c20db43f
PE
3141 * intervals.h (struct interval): Use EMACS_INT for members
3142 where EMACS_UINT might cause problems. See
3143 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3144 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3145 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3146 All uses changed.
37aa2f85
PE
3147 (offset_intervals): Tell GCC not to worry about length overflow
3148 when negating a negative length.
c20db43f 3149
2538aa2f
PE
3150 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3151 (overrun_check_free): Likewise.
3152
f2d3008d
PE
3153 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3154 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3155 word size.
3156
ec8df744
PE
3157 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3158 (gnutls_make_error): Rename local to avoid shadowing.
3159 (gnutls_emacs_global_deinit): ifdef out; not used.
3160 (Fgnutls_boot): Use const for pointer to readonly storage.
3161 Comment out unused local. Fix pointer signedness problems.
3162
640ee02d
PE
3163 * lread.c (openp): Don't stuff size_t into an 'int'.
3164 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3165 about possible signed overflow.
3166
6048fb2a
PE
3167 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3168 (GDK_KEY_g): Don't define if already defined.
3169 (xg_prepare_tooltip): Avoid pointer signedness problem.
3170 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3171
fa3c87e1
PE
3172 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3173 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3174
2172544b
PE
3175 * xfns.c (Fx_window_property): Simplify a bit,
3176 to make a bit faster and to avoid GCC 4.6.0 warning.
3177 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3178
9b821a21
PE
3179 * fns.c (internal_equal): Don't assume size_t fits in int.
3180
3c616cfa
PE
3181 * alloc.c (compact_small_strings): Tighten assertion a little.
3182
c2982e87
PE
3183 Replace pEd with more-general pI, and fix some printf arg casts.
3184 * lisp.h (pI): New macro, generalizing old pEd macro to other
3185 conversion specifiers. For example, use "...%"pI"d..." rather
3186 than "...%"pEd"...".
3187 (pEd): Remove. All uses replaced with similar uses of pI.
3188 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3189 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3190 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3191 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3192 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3193 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3194 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3195 64-bit hosts.
3196 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3197 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3198 * print.c (safe_debug_print, print_object): Likewise.
3199 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3200 to int.
6f04d126
PE
3201 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3202 avoiding the 0 flag, which is not portable.
c2982e87
PE
3203 * process.c (Fmake_network_process): Use pI to avoid cast.
3204 * region-cache.c (pp_cache): Likewise.
3205 * xdisp.c (decode_mode_spec): Likewise.
3206 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3207 behavior on 64-bit hosts with printf arg.
6f04d126 3208 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3209 (x_stop_queuing_selection_requests): Likewise.
3210 (x_get_window_property): Don't truncate byte count to an 'int'
3211 when tracing.
0b432f21 3212
5e073ec7
PE
3213 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3214 here, since it parses constructs like leading '-' and spaces,
3215 which are not wanted; and it overflows with large numbers.
3216 Instead, simply match F[0-9]+, which is what is wanted anyway.
3217
36372bf9
PE
3218 * alloc.c: Remove unportable assumptions about struct layout.
3219 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3220 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3221 (allocate_vectorlike, make_pure_vector): Use the new macros,
3222 plus offsetof, to remove unportable assumptions about struct layout.
3223 These assumptions hold on all porting targets that I know of, but
3224 they are not guaranteed, they're easy to remove, and removing them
3225 makes further changes easier.
3226
0b432f21
PE
3227 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3228 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3229 (string_overrun_cookie): Now const. Use initializers that
3230 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3231 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3232 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3233 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3234 multiple of sizeof (EMACS_INT); it need not be, if
3235 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3236 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3237
895009e1
JB
32382011-04-26 Juanma Barranquero <lekktu@gmail.com>
3239
3240 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3241
6a7a1b0b
TZ
32422011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3243
3244 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3245 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3246 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3247
841a1577 32482011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3249
3250 * lisp.h (Qdebug): List symbol.
895009e1 3251 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3252 * keyboard.c (debug-on-event): New variable.
3253 (handle_user_signal): Break into debugger when debug-on-event
3254 matches the current signal symbol.
3255
f2d3ba6f
DN
32562011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3257
3258 * alloc.c (check_sblock, check_string_bytes)
3259 (check_string_free_list): Convert to standard C.
3260
42ce4c63
TZ
32612011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3262
3263 * w32.c (emacs_gnutls_push): Fix typo.
3264
825cd63c
EZ
32652011-04-25 Eli Zaretskii <eliz@gnu.org>
3266
fb11d64d
EZ
3267 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3268 "cast to pointer from integer of different size".
3269
825cd63c
EZ
3270 Improve doprnt and its use in verror. (Bug#8545)
3271 * doprnt.c (doprnt): Document the set of format control sequences
3272 supported by the function. Use SAFE_ALLOCA instead of always
3273 using `alloca'.
3274
3275 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3276 is one byte too soon. Don't use xrealloc; instead xfree and
3277 xmalloc anew.
3278
e061a11b
TZ
32792011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3280
3281 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3282 callbacks stage.
3283
3284 * gnutls.c: Renamed global_initialized to
3285 gnutls_global_initialized. Added internals for the
3286 :verify-hostname-error, :verify-error, and :verify-flags
3287 parameters of `gnutls-boot' and documented those parameters in the
3288 docstring. Start callback support.
9173deec
JB
3289 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3290 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3291 on error. Return error code.
e061a11b
TZ
3292 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3293 (emacs_gnutls_read): Likewise.
3294 (Fgnutls_boot): Return handshake error code.
3295 (emacs_gnutls_handle_error): New function.
3296 (wsaerror_to_errno): Likewise.
3297
3298 * w32.h (emacs_gnutls_pull): Add prototype.
3299 (emacs_gnutls_push): Likewise.
3300
3301 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3302 (emacs_gnutls_push): Likewise.
3303
33042011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3305
3306 * process.c (wait_reading_process_output): Check if GnuTLS
3307 buffered some data internally if no FDs are set for TLS
3308 connections.
3309
3310 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3311 (LIBS): Link to USER_LIBS.
3312 ($(BLD)/gnutls.$(0)): New target.
3313
fa6996bc
EZ
33142011-04-24 Eli Zaretskii <eliz@gnu.org>
3315
eb35682e
EZ
3316 * xdisp.c (handle_single_display_spec): Rename the
3317 display_replaced_before_p argument into display_replaced_p, to
3318 make it consistent with the commentary. Fix typos in the
3319 commentary.
3320
e2ad650c
EZ
3321 * textprop.c (syms_of_textprop): Remove dead code.
3322 (copy_text_properties): Delete obsolete commentary about an
3323 interface that was deleted long ago. Fix typos in the description
3324 of arguments.
3325
1b2de274
EZ
3326 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3327 to changes in oldXMenu/XMenu.h from 2011-04-16.
3328 <menu_help_message, prev_menu_help_message>: Constify.
3329 (IT_menu_make_room): menu->help_text is now `const char **';
3330 adjust.
3331
3332 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3333 to changes in oldXMenu/XMenu.h from 2011-04-16.
3334 (struct XMenu): Declare `help_text' `const char **'.
3335
3336 * xfaces.c <Qunspecified>: Make extern again.
3337
3338 * syntax.c: Include sys/types.h before including regex.h, as
3339 required by Posix.
3340
762b15be
EZ
3341 * doc.c (get_doc_string): Improve the format passed to `error'.
3342
3343 * doprnt.c (doprnt): Improve commentary.
3344
3345 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3346
3347 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3348 them with etags.
3349
f1052e5d
EZ
3350 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3351 changes in globals.h immediately force recompilation.
762b15be
EZ
3352 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3353 $(CURDIR)/s/ms-w32.h.
3354 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3355
fa6996bc
EZ
3356 * character.c (Fchar_direction): Function deleted.
3357 (syms_of_character): Don't defsubr it.
3358 <char-direction-table>: Deleted.
3359
e6c3da20
EZ
33602011-04-23 Eli Zaretskii <eliz@gnu.org>
3361
3362 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3363 * doprnt.c: Include limits.h.
3364 (SIZE_MAX): New macro.
04f2d78b
CB
3365 (doprnt): Return a size_t value. 2nd arg is now size_t.
3366 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3367 Improve overflow protection. Support `l' modifier for integer
3368 conversions. Support %l conversion. Don't assume an EMACS_INT
3369 argument for integer conversions and for %c.
3370
3371 * lisp.h (doprnt): Restore prototype.
3372
3373 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3374 $(SRC)/character.h.
3375
3376 * Makefile.in (base_obj): Add back doprnt.o.
3377
3378 * deps.mk (doprnt.o): Add back prerequisites.
3379 (callint.o): Depend on character.h.
3380
3381 * eval.c (internal_lisp_condition_case): Include the handler
3382 representation in the error message.
3383 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3384 when breaking from the loop.
3385
3386 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3387
3388 * callint.c (Fcall_interactively): When displaying error message
3389 about invalid control letter, pass the character's codepoint, not
3390 a pointer to its multibyte form. Improve display of the character
3391 in octal and display also its hex code.
3392
3393 * character.c (char_string): Use %x to display the (unsigned)
3394 codepoint of an invalid character, to avoid displaying a bogus
3395 negative value.
3396
3397 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3398 `error', not SYMBOL_NAME itself.
3399
3400 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3401 character arguments to `error'.
3402
3403 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3404 to `error' in error message about FINAL_CHAR argument. Make sure
3405 FINAL_CHAR is a character, and use %c when it is passed as
3406 argument to `error'.
3407
4ffd0d6b 34082011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3409
3410 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3411
3412 * w32.c: Include <time.h>.
3413 (sys_localtime): New function.
3414
4ffd0d6b 34152011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3416
3417 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3418
4ffd0d6b 3419 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3420
4ffd0d6b 34212011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3422
4ffd0d6b
GM
3423 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3424 zombies (Bug#8467).
aac0c6e3 3425
04c56954
EZ
34262011-04-19 Eli Zaretskii <eliz@gnu.org>
3427
3428 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3429 gl_state.e_property when gl_state.object is Qt.
3430
3431 * insdel.c (make_gap_larger): Remove limitation of buffer size
3432 to <= INT_MAX.
3433
16a43933
CY
34342011-04-18 Chong Yidong <cyd@stupidchicken.com>
3435
3436 * xdisp.c (lookup_glyphless_char_display)
3437 (produce_glyphless_glyph): Handle cons cell entry in
3438 glyphless-char-display.
3439 (Vglyphless_char_display): Document it.
3440
3441 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3442 glyphless-char-display.
3443
4581706e
CY
34442011-04-17 Chong Yidong <cyd@stupidchicken.com>
3445
3446 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3447
3448 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3449
3450 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3451 definition for no-X builds.
3452
4887c6e2 34532011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3454
fd35b6f9
PE
3455 Static checks with GCC 4.6.0 and non-default toolkits.
3456
5c1ccb01
PE
3457 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3458
006c5daa
PE
3459 * process.c (keyboard_bit_set): Define only if SIGIO.
3460 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3461 (send_process): Repair possible setjmp clobbering.
3462
efc736d3
PE
3463 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3464
4e2fe2e6
PE
3465 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3466
f97334a2
PE
3467 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3468
4e75f29d
PE
3469 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3470 Define only if needed.
3471
90efadd1
PE
3472 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3473 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3474 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3475
3c647824
PE
3476 * dispextern.h (struct redisplay_interface): Rename param
3477 to avoid shadowing.
e264f262 3478 * termhooks.h (struct terminal): Likewise.
761383f4 3479 * xterm.c (xembed_send_message): Likewise.
3c647824 3480
b58c5c4a
PE
3481 * insdel.c (make_gap_smaller): Define only if
3482 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3483
cad59032
PE
3484 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3485 it.
3486
c339dc2e
PE
3487 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3488 so that we aren't warned about unused symbols.
3489
91a3e27b
PE
3490 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3491
399c71d3 3492 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3493
8ffc96f5
PE
3494 * xfns.c (x_real_positions): Mark locals as initialized.
3495
eef9bc79
PE
3496 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3497
098db9dd
PE
3498 * xterm.c: Fix problems found by static analysis with other toolkits.
3499 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3500 (x_dispatch_event): Declare static if USE_GTK, and
3501 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3502 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3503 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3504 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3505 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3506
eb18f6cc
PE
3507 * xmenu.c (menu_help_callback): Pointer type fixes.
3508 Use const pointers when pointing at readonly data. Avoid pointer
3509 signedness clashes.
3510 (FALSE): Remove unused macro.
3511 (update_frame_menubar): Remove unused decl.
3512
1fe72bf8
PE
3513 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3514
60d9e1db
PE
3515 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3516 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3517 (single_menu_item): Rename local to avoid shadowing.
3518
39261c26
PE
3519 * keyboard.c (make_lispy_event): Remove unused local var.
3520
018c5e19
PE
3521 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3522 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3523
63d2b86e
PE
3524 * bitmaps: Change bitmaps from unsigned char back to the X11
3525 compatible char. Avoid the old compiler warnings about
3526 out-of-range initializers by using, for example, '\xab' rather
3527 than 0xab.
3528
aefd87e1
PE
3529 * xgselect.c (xgselect_initialize): Check vs interface
3530 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3531
bf501fb9
PE
3532 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3533
e9829fdf
PE
3534 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3535 to read-only memory.
3536
1086c095
PE
3537 * fns.c (vector): Remove; this old hack is no longer needed.
3538
2baccd04 3539 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3540 Remove unused var.
dde42981 3541 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3542
72391843 3543 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3544
436c16df 3545 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3546 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3547 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3548
92bb796d 3549 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3550 (x_term_init): Remove local to avoid shadowing.
92bb796d 3551
764430a3 3552 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3553
3554 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3555 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3556
d1dfb56c
EZ
35572011-04-16 Eli Zaretskii <eliz@gnu.org>
3558
c4354cb4
EZ
3559 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3560
d1dfb56c
EZ
3561 Fix regex.c, syntax.c and friends for buffers > 2GB.
3562 * syntax.h (struct gl_state_s): Declare character position members
3563 EMACS_INT.
3564
3565 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3566
04f2d78b
CB
3567 * textprop.c (verify_interval_modification, interval_of):
3568 Declare arguments EMACS_INT.
d1dfb56c
EZ
3569
3570 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3571 EMACS_INT.
3572
3573 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3574
3575 * indent.c (Fvertical_motion): Local variable it_start is now
3576 EMACS_INT.
3577
3578 * regex.c (re_match, re_match_2, re_match_2_internal)
3579 (bcmp_translate, regcomp, regexec, print_double_string)
3580 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3581 (re_compile_pattern, re_exec): Declare arguments and local
3582 variables `size_t' and `ssize_t' and return values `regoff_t', as
3583 appropriate.
3584 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3585 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3586 <compile_stack_type>: `size' and `avail' are now `size_t'.
3587
3588 * regex.h <regoff_t>: Use ssize_t, not int.
3589 (re_search, re_search_2, re_match, re_match_2): Arguments that
3590 specify buffer/string position and length are now ssize_t and
3591 size_t. Return type is regoff_t.
3592
613052cd
BK
35932011-04-16 Ben Key <bkey76@gmail.com>
3594
3595 * nsfont.m: Fixed bugs in ns_get_family and
3596 ns_descriptor_to_entity that were caused by using free to
3597 deallocate memory blocks that were allocated by xmalloc (via
3598 xstrdup). This caused Emacs to crash when compiled with
3599 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3600 --enable-checking=xmallocoverrun). xfree is now used to
3601 deallocate these memory blocks.
3602
4170f62f 36032011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3604
71b41406
PE
3605 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3606
9587a89d
PE
3607 emacs_write: Accept and return EMACS_INT for sizes.
3608 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3609 et seq.
3610 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3611 Accept and return EMACS_INT.
3612 (emacs_gnutls_write): Return the number of bytes written on
3613 partial writes.
3614 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3615 (emacs_read, emacs_write): Remove check for negative size, as the
3616 Emacs source code has been audited now.
9587a89d
PE
3617 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3618 (emacs_read, emacs_write): Use it.
273a5f82
PE
3619 * process.c (send_process): Adjust to the new signatures of
3620 emacs_write and emacs_gnutls_write. Do not attempt to store
3621 a byte offset into an 'int'; it might overflow.
9587a89d 3622 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3623
3e047f51
PE
3624 * sound.c: Don't assume sizes fit in 'int'.
3625 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3626 Return EMACS_INT, not int.
3e047f51 3627 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3628 Accept EMACS_INT, not int.
3629 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3630 record read return values.
3631
cc39a9db
BK
36322011-04-15 Ben Key <bkey76@gmail.com>
3633
c9d0ec6d
JB
3634 * keyboard.c (Qundefined): Don't declare static since it is used
3635 in nsfns.m.
3636 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3637 static since they are used in nsfont.m.
cc39a9db 3638
6c60eb9f
SM
36392011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3640
3641 * process.c (Qprocessp): Don't declare static.
3642 * lisp.h (Qprocessp): Declare again.
3643
7990b61a
JB
36442011-04-15 Juanma Barranquero <lekktu@gmail.com>
3645
3646 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3647
5d4cb038
PE
36482011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3649
8bd7b830 3650 Improve C-level modularity by making more things 'static'.
cd64ea1d 3651
e3b27b31
PE
3652 Don't publish debugger-only interfaces to other modules.
3653 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3654 (verify_bytepos, count_markers): Move decls to the only modules
3655 that need them.
3656 * region-cache.h (pp_cache): Likewise.
3657 * window.h (check_all_windows): Likewise.
3658 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3659
5d4cb038
PE
3660 * sysdep.c (croak): Now static, if
3661 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3662 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3663
3664 * alloc.c (refill_memory_reserve): Now static if
3665 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3666 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3667
e87b6180
PE
3668 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3669 Define only if USE_LUCID.
3670
ac64929e
PE
3671 * xrdb.c (x_customization_string, x_rm_string): Now static.
3672
6f37259d
PE
3673 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3674 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3675
1683e3ab
PE
3676 * xdisp.c (draw_row_with_mouse_face): Now static.
3677 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3678
de9c2632
PE
3679 * window.h (check_all_windows): Mark externally visible.
3680
2b96acb7
PE
3681 * window.c (window_deletion_count): Now static.
3682
3683 * undo.c: Make symbols static if they're not exported.
3684 (last_undo_buffer, last_boundary_position, pending_boundary):
3685 Now static.
3686
50436f33
PE
3687 * textprop.c (interval_insert_behind_hooks): Now static.
3688 (interval_insert_in_front_hooks): Likewise.
3689
64520e5c
PE
3690 * term.c: Make symbols static if they're not exported.
3691 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3692 (max_frame_lines, tty_set_terminal_modes):
3693 (tty_reset_terminal_modes, tty_turn_off_highlight):
3694 (get_tty_terminal): Now static.
3695 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3696 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3697 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3698 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3699 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3700
1fa53021
PE
3701 * sysdep.c: Make symbols static if they're not exported.
3702 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3703 Now static.
3704 (sigprocmask_set, full_mask): Remove; unused.
3705 (wait_debugging): Mark as visible.
3706 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3707 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3708
d4b43b22
PE
3709 * syntax.c (syntax_temp): Define only if !__GNUC__.
3710
b7c513d0
PE
3711 * sound.c (current_sound_device, current_sound): Now static.
3712
989b29ad
PE
3713 * search.c (searchbufs, searchbuf_head): Now static.
3714
13a55a78
PE
3715 * scroll.c (scroll_cost): Remove; unused.
3716 * dispextern.h (scroll_cost): Remove decl.
3717
de68a1fc
PE
3718 * region-cache.h (pp_cache): Mark as externally visible.
3719
40ccffa6
PE
3720 * process.c: Make symbols static if they're not exported.
3721 (process_tick, update_tick, create_process, chan_process):
3722 (Vprocess_alist, proc_buffered_char, datagram_access):
3723 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3724 (deactivate_process): Mark defn as static, as well as decl.
3725 * lisp.h (create_process): Remove decl.
3726 * process.h (chan_process, Vprocess_alist): Remove decls.
3727
ad64fc97
PE
3728 * print.c: Make symbols static if they're not exported.
3729 (print_depth, new_backquote_output, being_printed, print_buffer):
3730 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3731 (print_interval, print_number_index, initial_stderr_stream):
3732 Now static.
3733 * lisp.h (Fprinc): Remove decl.
3734 (debug_output_compilation_hack): Mark as externally visible.
3735
adddb265
PE
3736 * sysdep.c (croak): Move decl from here to syssignal.h.
3737 * syssignal.h (croak): Put it here, so the API can be checked when
3738 'croak' is called from dissociate_if_controlling_tty.
3739
1717ede2
PE
3740 * minibuf.c: Make symbols static if they're not exported.
3741 (minibuf_save_list, choose_minibuf_frame): Now static.
3742 * lisp.h (choose_minibuf_frame): Remove decl.
3743
fa5fb2bc
PE
3744 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3745
1e3890d1
PE
3746 * lread.c: Make symbols static if they're not exported.
3747 (read_objects, initial_obarray, oblookup_last_bucket_number):
3748 Now static.
3749 (make_symbol): Remove; unused.
3750 * lisp.h (initial_obarray, make_symbol): Remove decls.
3751
8a1414fa
PE
3752 * keyboard.c: Make symbols static if they're not exported.
3753 (single_kboard, recent_keys_index, total_keys, recent_keys):
3754 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3755 (this_single_command_key_start, echoing, last_auto_save):
3756 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3757 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3758 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3759 (Vlispy_mouse_stem, double_click_count):
3760 Now static.
3761 (force_auto_save_soon): Define only if SIGDANGER.
3762 (ignore_mouse_drag_p): Now static if
3763 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3764 (print_help): Remove; unused.
3765 (stop_character, last_timer_event): Mark as externally visible.
3766 * keyboard.h (ignore_mouse_drag_p): Declare only if
3767 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3768 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3769 * lisp.h (echoing): Remove decl.
3770 (force_auto_save_soon): Declare only if SIGDANGER.
3771 * xdisp.c (redisplay_window): Simplify code, to make it more
3772 obvious that ignore_mouse_drag_p is not accessed if !defined
3773 USE_GTK && !defined HAVE_NS.
3774
93ea6e8f
PE
3775 * intervals.c: Make symbols static if they're not exported.
3776 (merge_properties_sticky, merge_interval_right, delete_interval):
3777 Now static.
3778 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3779
77382fcc
PE
3780 * insdel.c: Make symbols static if they're not exported.
3781 However, leave prepare_to_modify_buffer alone. It's never
3782 called from outside this function, but that appears to be a bug.
3783 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3784 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3785 (adjust_after_replace_noundo): Remove; unused.
3786 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3787 (signal_before_change): Remove decls.
77382fcc 3788
9306c32e
PE
3789 * indent.c (val_compute_motion, val_vmotion): Now static.
3790
cd44d2eb
PE
3791 * image.c: Make symbols static if they're not exported.
3792 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3793 if USE_GTK.
3794 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3795 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3796
ad9a7a06
PE
3797 * fringe.c (standard_bitmaps): Now static.
3798 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3799
81626931
PE
3800 * frame.c: Make symbols static if they're not exported.
3801 (x_report_frame_params, make_terminal_frame): Now static.
3802 (get_frame_param): Now static, unless HAVE_NS.
3803 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3804 (x_get_resource_string): Remove; not used.
3805 * frame.h (make_terminal_frame, x_report_frame_params):
3806 (x_get_resource_string); Remove decls.
3807 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3808 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3809
239f9db9
PE
3810 * font.c, fontset.c: Make symbols static if they're not exported.
3811 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3812 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3813 * font.c (font_close_object): Now static.
3814 * font.h (font_close_object): Remove.
3815 * fontset.c (FONTSET_OBJLIST): Remove.
3816 (free_realized_fontset) #if-0 the body, which does nothing.
3817 (face_suitable_for_char_p): #if-0, as it's never called.
3818 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3819 * xfaces.c (face_at_string_position):
3820 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3821 since 0 is always ASCII.
3822
dfcf3579
PE
3823 * fns.c (weak_hash_tables): Now static.
3824
5045092b
PE
3825 * fileio.c: Make symbols static if they're not exported.
3826 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3827 (Vwrite_region_annotation_buffers): Now static.
3828
57a96f5c
PE
3829 * eval.c: Make symbols static if they're not exported.
3830 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3831 * lisp.h (backtrace_list): Remove decl.
3832
35f08c38
PE
3833 * emacs.c: Make symbols static if they're not exported.
3834 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3835 (fatal_error_code, fatal_error_signal_hook, standard_args):
3836 Now static.
3837 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3838 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3839 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3840 * lisp.h (fatal_error_signal_hook): Remove decl.
3841 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3842
f44bd759
PE
3843 * editfns.c: Move a (normally-unused) function to its only use.
3844 * editfns.c, lisp.h (get_operating_system_release): Remove.
3845 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3846 worth the hassle of breaking this out.
3847
b532497d
PE
3848 * xterm.c: Make symbols static if they're not exported.
3849 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3850 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3851 (x_destroy_window, x_delete_display):
3852 Now static.
3853 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3854 (x_mouse_leave): Remove; unused.
3855 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3856 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3857 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3858 Remove decls.
3859 (x_mouse_leave): Declare only if WINDOWSNT.
3860 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3861 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3862 USE_X_TOOLKIT.
3863
1675728f
PE
3864 * ftxfont.c: Make symbols static if they're not exported.
3865 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3866 HAVE_FREETYPE.
3867 * font.h (ftxfont_driver): Likewise.
3868
e4cebfca
PE
3869 * xfns.c: Make symbols static if they're not exported.
3870 (x_last_font_name, x_display_info_for_name):
3871 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3872 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3873 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3874 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3875 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3876 (last_show_tip_args): Now static.
3877 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3878 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3879 (x_screen_planes): Remove; unused.
3880 * dispextern.h (x_screen_planes): Remove decl.
3881
5bf46f05
PE
3882 * dispnew.c: Make symbols static if they're not exported.
3883 * dispextern.h (redraw_garbaged_frames, scrolling):
3884 (increment_row_positions): Remove.
3885 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3886 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3887 Now static.
3888 (redraw_garbaged_frames): Remove; unused.
3889
435f4c28
PE
3890 * xfaces.c: Make symbols static if they're not exported.
3891 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3892 Remove decls.
3893 * xterm.h (defined_color): Remove decls.
3894 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3895 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3896 (menu_face_changed_default, defined_color, free_realized_face):
3897 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3898 (ascii_face_of_lisp_face): Remove; unused.
3899
8524aef3
PE
3900 * xdisp.c: Make symbols static if they're not exported.
3901 * dispextern.h (scratch_glyph_row, window_box_edges):
3902 (glyph_to_pixel_coords, set_cursor_from_row):
3903 (get_next_display_element, set_iterator_to_next):
3904 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3905 (show_mouse_face): Remove decls
3906 * frame.h (message_buf_print): Likewise.
3907 * lisp.h (pop_message, set_message, check_point_in_composition):
3908 Likewise.
3909 * xterm.h (set_vertical_scroll_bar): Likewise.
3910 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3911 (message_buf_print, scratch_glyph_row, displayed_buffer):
3912 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3913 (get_next_display_element, show_mouse_face, window_box_edges):
3914 (frame_to_window_pixel_xy, check_point_in_composition):
3915 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3916 (glyph_to_pixel_coords): Remove; unused.
3917
16390cd2
PE
3918 * dired.c (file_name_completion): Now static.
3919
3920 * dbusbind.c (xd_in_read_queued_messages): Now static.
3921
a25f4dfa
PE
3922 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3923 * data.c (circular_list_error): Remove.
3924
14a9c8df
PE
3925 * commands.h (last_point_position, last_point_position_buffer):
3926 (last_point_position_window): Remove decls.
3927 * keyboard.c: Make these variables static.
3928
04f2d78b
CB
3929 * coding.h (coding, code_convert_region, encode_coding_gap):
3930 Remove decls.
74ab6df5
PE
3931 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3932 (iso_code_class, detect_coding, code_convert_region): Now static.
3933 (encode_coding_gap): Remove; unused.
3934
38dfbee1
PE
3935 * chartab.c (chartab_chars, chartab_bits): Now static.
3936
a2cb4e63
PE
3937 * charset.h (charset_iso_8859_1): Remove decl.
3938 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3939 Now static.
3940
127198fd
PE
3941 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3942 * ccl.c (Vccl_program_table): Now static.
3943 (check_ccl_update): Remove; unused.
3944
d85b608f
PE
3945 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3946 * category.h: ... from here.
3947 * category.c (check_category_table, set_category_set): Now static.
3948
31cd66f3
PE
3949 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3950 * lisp.h: Remove these decls.
3951
c358e587
PE
3952 * buffer.c (buffer_count): Remove unused var.
3953
e78aecca
PE
3954 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3955 so that it's not optimized away.
3956 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3957 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3958 exported only to the debugger.
3959
e192d7d3 3960 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3961 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3962
92470028
PE
3963 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3964 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3965 was inaccessible from Lisp.
3966 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3967 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3968
244ed907
PE
3969 alloc.c: Import and export fewer symbols, and remove unused items.
3970 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3971 is defined.
3972 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3973 it's not optimized away by whole-program optimization.
3974 (message_enable_multibyte, free_misc): Remove.
3975 (catchlist, handlerlist, mark_backtrace):
3976 Declare only if BYTE_MARK_STACK.
3977 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3978 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3979 (message_enable_multibyte): Remove decl.
3980 (free_misc, interval_free_list, float_block, float_block_index):
3981 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3982 (cons_free_list, last_marked_index):
3983 Now static.
3984 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3985 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3986 (mark_backtrace): Define only if BYTE_MARK_STACK.
3987 * xdisp.c (message_enable_multibyte): Now static.
3988
61c2b50e 3989 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3990 This makes it easier for human readers (and static analyzers)
3991 to see whether these variables are used from other modules.
3992 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3993 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3994 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3995 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3996 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3997 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3998 * xmenu.c, xselect.c:
3999 Declare Q* vars static if they are not used in other modules.
4000 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4001 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4002 Remove decls of unexported vars.
4003 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4004
95c82688
PE
4005 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4006
16a97296
PE
4007 Make Emacs functions such as Fatom 'static' by default.
4008 This makes it easier for human readers (and static analyzers)
4009 to see whether these functions can be called from other modules.
4010 DEFUN now defines a static function. To make the function external
4011 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4012 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4013 (Finit_image_library):
16a97296
PE
4014 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4015 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4016 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4017 Remove decls, since these functions are now static.
4018 (Funintern, Fget_internal_run_time): New decls, since these functions
4019 were already external.
95c82688 4020
16a97296
PE
4021 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4022 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4023 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4024 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4025 * keyboard.c, keymap.c, lread.c:
4026 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4027 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4028 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4029 Mark functions with DEFUE instead of DEFUN,
4030 if they are used in other modules.
4031 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4032 decls for now-static functions.
4033 * buffer.h (Fdelete_overlay): Remove decl.
4034 * callproc.c (Fgetenv_internal): Mark as internal.
4035 * composite.c (Fremove_list_of_text_properties): Remove decl.
4036 (Fcomposition_get_gstring): New forward static decl.
4037 * composite.h (Fcomposite_get_gstring): Remove decl.
4038 * dired.c (Ffile_attributes): New forward static decl.
4039 * doc.c (Fdocumntation_property): New forward static decl.
4040 * eval.c (Ffetch_bytecode): New forward static decl.
4041 (Funintern): Remove extern decl; now in .h file where it belongs.
4042 * fileio.c (Fmake_symbolic_link): New forward static decl.
4043 * image.c (Finit_image_library): New forward static decl.
4044 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4045 * intervals.h (Fprevious_property_change):
4046 (Fremove_list_of_text_properties): Remove decls.
4047 * keyboard.c (Fthis_command_keys): Remove decl.
4048 (Fcommand_execute): New forward static decl.
4049 * keymap.c (Flookup_key): New forward static decl.
4050 (Fcopy_keymap): Now static.
4051 * keymap.h (Flookup_key): Remove decl.
4052 * process.c (Fget_process): New forward static decl.
4053 (Fprocess_datagram_address): Mark as internal.
4054 * syntax.c (Fsyntax_table_p): New forward static decl.
4055 (skip_chars): Remove duplicate decl.
4056 * textprop.c (Fprevious_property_change): New forward static decl.
4057 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4058 Now internal.
4059 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4060 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4061
785bbd42
PE
4062 * editfns.c (Fformat): Remove unreachable code.
4063
8b913b57
AS
40642011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4065
4066 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4067 change. (Bug#8496)
4068
a6744a35
EZ
40692011-04-13 Eli Zaretskii <eliz@gnu.org>
4070
4071 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4072 when at ZV. (Bug#8487)
4073
e7974947
AS
40742011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4075
baad03f0
AS
4076 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4077 (Bug#8437)
4078 * keyboard.c (parse_tool_bar_item): Likewise.
4079 * sound.c (sound_cleanup, alsa_close): Likewise.
4080 * termcap.c (tgetent): Likewise.
4081 * xfns.c (x_default_font_parameter): Likewise.
4082 * xsettings.c (read_and_apply_settings): Likewise.
4083
e7974947
AS
4084 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4085 (overrun_check_free): Protoize.
4086
28272684
PE
40872011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4090 since callers should never pass a negative size.
4091 Change the signature to match that of plain 'read' and 'write'; see
4092 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4093 * lisp.h: Update prototypes of emacs_write and emacs_read.
4094
11997c76
EZ
40952011-04-11 Eli Zaretskii <eliz@gnu.org>
4096
4097 * xdisp.c (redisplay_window): Don't try to determine the character
4098 position of the scroll margin if the window start point w->startp
e896f03c 4099 is outside the buffer's accessible region. (Bug#8468)
11997c76 4100
8a2cbd72
EZ
41012011-04-10 Eli Zaretskii <eliz@gnu.org>
4102
4103 Fix write-region and its subroutines for buffers > 2GB.
4104 * fileio.c (a_write, e_write): Modify declaration of arguments and
4105 local variables to support buffers larger than 2GB.
4106 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4107
4108 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4109 argument, local variables, and return value.
4110
4111 * lisp.h: Update prototypes of emacs_write and emacs_read.
4112
4113 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4114
4073e537 41152011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4116
1ebfdcb6
PE
4117 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4118
b2ded58d
PE
4119 Fix more problems found by GCC 4.6.0's static checks.
4120
7d66342c
PE
4121 * xdisp.c (vmessage): Use a better test for character truncation.
4122
bbf47d44
PE
4123 * charset.c (load_charset_map): <, not <=, for optimization,
4124 and to avoid potential problems with integer overflow.
9248994d 4125 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4126 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4127 * editfns.c (Fformat): Likewise.
1e69125e 4128 * syntax.c (skip_chars): Likewise.
3befa583 4129
e3019616
PE
4130 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4131 This also lets GCC 4.6.0 generate slightly better loop code.
4132
becfa255
PE
4133 * callint.c (Fcall_interactively): <, not <=, for optimization.
4134 (Fcall_interactively): Count the number of arguments produced,
4135 not the number of arguments given. This is simpler and lets GCC
4136 4.6.0 generate slightly better code.
4137
dae0cd48
PE
4138 * ftfont.c: Distingish more carefully between FcChar8 and char.
4139 The previous code passed unsigned char * to a functions like
4140 strlen and xstrcasecmp that expect char *, which does not
4141 conform to the C standard.
4142 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4143 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4144 char * when the C standard requires it.
4145
76032d70
PE
4146 * keyboard.c (read_char): Remove unused var.
4147
eb3f1cc8
PE
4148 * eval.c: Port to Windows vsnprintf (Bug#8435).
4149 Include <limits.h>.
4150 (SIZE_MAX): Define if the headers do not.
4151 (verror): Do not give up if vsnprintf returns a negative count.
4152 Instead, grow the buffer. This ports to Windows vsnprintf, which
4153 does not conform to C99. Problem reported by Eli Zaretskii.
4154 Also, simplify the allocation scheme, by avoiding the need for
4155 calling realloc, and removing the ALLOCATED variable.
4156
70476b54
PE
4157 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4158
12020a9e
PE
4159 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4160 But keep the doprint source code for now, as we might revamp it
4161 and use it again (Bug#8435).
ea6c7ae6
PE
4162 * lisp.h (doprnt): Remove.
4163 * Makefile.in (base_obj): Remove doprnt.o.
4164 * deps.mk (doprnt.o): Remove.
4165
5fdb398c
PE
4166 error: Print 32- and 64-bit integers portably (Bug#8435).
4167 Without this change, on typical 64-bit hosts error ("...%d...", N)
4168 was used to print both 32- and 64-bit integers N, which relied on
4169 undefined behavior.
4170 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4171 New macro.
4172 * lisp.h (error, verror): Mark as printf-like functions.
4173 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4174 Report overflow in size calculations when allocating printf buffer.
4175 Do not truncate output string at its first null byte.
4176 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4177 Truncate the output at a character boundary, since vsnprintf does not
4178 do that.
4179 * charset.c (check_iso_charset_parameter): Convert internal
4180 character to string before calling 'error', since %c now has the
4181 printf meaning.
4182 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4183 overflow when computing char to be passed to 'error'. Do not
4184 pass Lisp_Object to 'error'; pass the integer instead.
4185 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4186 formatted with plain %d.
4187
b189fa66
PE
4188 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4189
bff87ef0
PE
4190 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4191
7e2cac20
PE
4192 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4193
ce4d90b5
PE
4194 * xterm.c (x_catch_errors): Remove duplicate declaration.
4195
266c9547
PE
4196 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4197
79c49ad2
PE
4198 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4199
368f4090
JM
42002011-04-10 Jim Meyering <meyering@redhat.com>
4201
4202 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4203 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4204 return ssize_t not "int", and use size_t as the buffer length.
4205 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4206 * gnutls.h: Update declarations.
4207 * process.c (read_process_output): Use ssize_t, to match.
4208 (send_process): Likewise.
4209
a32d4040
CY
42102011-04-09 Chong Yidong <cyd@stupidchicken.com>
4211
4212 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4213
8546720e 42142011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4215
04f2d78b
CB
4216 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4217 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4218
8546720e
GM
4219 * xterm.c (handle_one_xevent):
4220 * xmenu.c (create_and_show_popup_menu):
4221 * xselect.c (x_decline_selection_request)
4222 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4223
0a2f5c1a 42242011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4225
4226 Fix some uses of `int' instead of EMACS_INT.
4227 * search.c (string_match_1, fast_string_match)
4228 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4229 (scan_buffer, find_next_newline_no_quit)
4230 (find_before_next_newline, search_command, Freplace_match)
4231 (Fmatch_data): Make some `int' variables be EMACS_INT.
4232
4233 * xdisp.c (display_count_lines): 3rd argument and return value now
4234 EMACS_INT. All callers changed.
4235 (pint2hrstr): Last argument is now EMACS_INT.
4236
4237 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4238 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4239 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4240 (decode_coding_utf_16, decode_coding_emacs_mule)
4241 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4242 (decode_coding_ccl, decode_coding_charset)
4243 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4244 (decode_coding_iso_2022, decode_coding_emacs_mule)
4245 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4246 <char_offset, last_offset>: Declare EMACS_INT.
4247 (encode_coding_utf_8, encode_coding_utf_16)
4248 (encode_coding_emacs_mule, encode_invocation_designation)
4249 (encode_designation_at_bol, encode_coding_iso_2022)
4250 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4251 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4252 Declare EMACS_INT.
4253 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4254 (encode_invocation_designation): Last argument P_NCHARS is now
4255 EMACS_INT.
4256 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4257 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4258
4259 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4260 All users changed.
4261
4262 * ccl.c (Fccl_execute_on_string): Declare some variables
4263 EMACS_INT.
4264
8546720e 42652011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4266
4267 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4268
4e19a977
CS
42692011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4270
4271 * process.c (Fformat_network_address): Doc fix.
4272
87302331
R
42732011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4274
4275 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4276
cbb59342
CY
42772011-04-08 Chong Yidong <cyd@stupidchicken.com>
4278
4279 * keyboard.c (read_char): Call Lisp function help-form-show,
4280 instead of using internal_with_output_to_temp_buffer.
4281 (Qhelp_form_show): New var.
e0d38eeb 4282 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4283
4284 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4285
4286 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4287
e67a13ab
CY
42882011-04-06 Chong Yidong <cyd@stupidchicken.com>
4289
04f2d78b
CB
4290 * process.c (Flist_processes): Remove to Lisp.
4291 (list_processes_1): Delete.
e67a13ab 4292
973f782d
EZ
42932011-04-06 Eli Zaretskii <eliz@gnu.org>
4294
7c106b1e
EZ
4295 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4296
973f782d
EZ
4297 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4298
41cf7d1a 42992011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4300
ca23cc88
PE
4301 Fix more problems found by GCC 4.6.0's static checks.
4302
f390e2d5
PE
4303 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4304
42eea0d0
PE
4305 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4306
b69769da 4307 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4308
f9541e84
PE
4309 * xdisp.c (vmessage): Mark as a printf-like function.
4310
13841b55
PE
4311 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4312
c136c10f
PE
4313 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4314
5e2d4a30
PE
4315 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4316 printf-like functions.
4317 (tiff_load): Add casts to remove these marks before passing them
4318 to system-supplied API.
4319
583f48b9
PE
4320 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4321
b25d760e
PE
4322 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4323 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4324 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4325 directly, rather than having caller test rule sign. This avoids
4326 some unnecessary tests.
4327 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4328 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4329 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4330
bc7b6697 4331 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4332 (xfont_open): Avoid unnecessary tests.
bc7b6697 4333
27ccc379
PE
4334 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4335
dcd5c89a
PE
4336 * composite.h, composite.c (composition_gstring_put_cache):
4337 Use EMACS_INT, not int, for length.
4338
b13a45c6
PE
4339 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4340 breaking out part of COMPOSITION_DECODE_RULE.
4341 (COMPOSITION_DECODE_RULE): Use it.
4342 * composite.c (get_composition_id): Remove unused local vars,
4343 by using the new macro.
4344
1e792e4d
PE
4345 * textprop.c (set_text_properties_1): Change while to do-while,
4346 since the condition is always true at first.
4347
dc6c6455 4348 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4349 (interval_deletion_adjustment): Return unsigned value.
4350 All uses changed.
dc6c6455 4351
aba7731a
PE
4352 * process.c (list_processes_1, create_pty, read_process_output):
4353 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4354 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4355 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4356 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4357 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4358
fdfc4bf3
PE
4359 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4360
fca8fe46 4361 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4362 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4363
06a0259a 4364 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4365 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4366 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4367
e7b9e80f
PE
4368 * print.c (print_error_message): Avoid int overflow.
4369
56201685
PE
4370 * font.c (font_list_entities): Redo for clarity,
4371 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4372
78834453 4373 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4374 (font_score): Avoid potential overflow in diff calculation.
78834453 4375
0bc0b309 4376 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4377 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4378
e610eaca
PE
4379 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4380
b895abce
PE
4381 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4382 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4383 can always succeed if overflow has undefined behavior.
4384
1f1d9321 4385 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4386 (wordify): Omit three unnecessary tests.
1f1d9321 4387
c59478bc
PE
4388 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4389 All callers changed. This avoids the need for an unused var.
4390
79b73827
PE
4391 * casefiddle.c (casify_region): Remove var that is set but not used.
4392
a4db5dfe
PE
4393 * dired.c (file_name_completion): Remove var that is set but not used.
4394
43aae36e
PE
4395 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4396
2a47c44d 4397 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4398 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4399
a37c69bf
PE
4400 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4401 Check for integer overflow on size calculations.
4402
328ab8e7
PE
4403 * buffer.c (Fprevious_overlay_change): Remove var that is set
4404 but not used.
4405
e5a2a5cb
PE
4406 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4407 Remove vars that are set but not used.
8d84a6eb 4408 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4409 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4410
a60e5f68
PE
4411 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4412
f661cb61 4413 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4414 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4415
f0397f5a
PE
4416 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4417 that are set but not used.
4418
8664db06 4419 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4420 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4421
6abdaa4a
PE
4422 * xselect.c (x_get_local_selection, x_handle_property_notify):
4423 Remove vars that are set but not used.
4424
0ce7538d 4425 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4426 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4427
9ae848fc
PE
4428 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4429 Remove var that is set but not used.
0b918413
PE
4430 (scroll_bar_windows_size): Now size_t, not int.
4431 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4432 Check for overflow.
9ae848fc 4433
a5a62657
PE
4434 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4435 (map_tty_color) [!defined MSDOS]: Likewise.
4436
5c5cdd39
PE
4437 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4438
66ebf983
PE
4439 * coding.c: Remove vars that are set but not used.
4440 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4441 All callers changed.
4442 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4443 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4444 (decode_coding_charset): Remove vars that are set but not used.
4445
1be4d761
PE
4446 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4447 that is set but not used.
4448
47553fa8
PE
4449 * print.c (print_object): Remove var that is set but not used.
4450
1f7196bf 4451 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4452 The gnulib version avoids calling malloc in the usual case,
4453 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4454 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4455 * filelock.c (current_lock_owner): Likewise.
4456 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4457 * sysdep.c: Include allocator.h, careadlinkat.h.
4458 (emacs_no_realloc_allocator): New static constant.
4459 (emacs_readlink): New function.
fdb61804
PE
4460 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4461 ../lib/careadlinkat.h.
d1fdcab7 4462
f84c17c7
SM
44632011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4464
4465 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4466 first non-nil return value).
4467
ef3862ad
JD
44682011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4469
4470 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4471 if not defined (Bug#8403).
4472
376a7006
JB
44732011-04-02 Juanma Barranquero <lekktu@gmail.com>
4474
4475 * xdisp.c (display_count_lines): Remove parameter `start',
4476 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4477 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4478 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4479 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4480 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4481 and thereabouts. All callers changed.
4482 (get_per_char_metric): Remove parameter `f', unused since
4483 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4484
6ca3801d
JM
44852011-04-02 Jim Meyering <meyering@redhat.com>
4486
4487 do not dereference NULL upon failed strdup
4488 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4489 (ns_get_family): Likewise.
4490
d8e2b5ba
JB
44912011-04-02 Juanma Barranquero <lekktu@gmail.com>
4492
4493 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4494
8c74fcbd
JD
44952011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4496
4497 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4498 later (Bug#8403).
4499
7200d79c
SM
45002011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4501
03408648 4502 Add lexical binding.
7200d79c 4503
03408648
SM
4504 * window.c (Ftemp_output_buffer_show): New fun.
4505 (Fsave_window_excursion):
4506 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4507
4508 * lread.c (lisp_file_lexically_bound_p): New function.
4509 (Fload): Bind Qlexical_binding.
4510 (readevalloop): Remove `evalfun' arg.
4511 Bind Qinternal_interpreter_environment.
4512 (Feval_buffer): Bind Qlexical_binding.
4513 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4514 Mark as dynamic.
4515 (syms_of_lread): Declare `lexical-binding'.
4516
4517 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4518
4519 * keyboard.c (eval_dyn): New fun.
4520 (menu_item_eval_property): Use it.
ca105506
SM
4521
4522 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4523
03408648
SM
4524 * fns.c (concat, mapcar1): Accept byte-code-functions.
4525
4526 * eval.c (Fsetq): Handle lexical vars.
4527 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4528 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4529 (FletX, Flet): Obey lexical binding.
4530 (Fcommandp): Handle closures.
4531 (Feval): New `lexical' arg.
4532 (eval_sub): New function extracted from Feval. Use it almost
4533 everywhere where Feval was used. Look up vars in lexical env.
4534 Handle closures.
4535 (Ffunctionp): Move from subr.el.
4536 (Ffuncall): Handle closures.
4537 (apply_lambda): Remove `eval_flags'.
4538 (funcall_lambda): Handle closures and new byte-code-functions.
4539 (Fspecial_variable_p): New function.
4540 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4541 but without exporting it to Lisp.
23aba0ea 4542
23aba0ea 4543 * doc.c (Fdocumentation, store_function_docstring):
03408648 4544 * data.c (Finteractive_form): Handle closures.
23aba0ea 4545
03408648
SM
4546 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4547 interactive spec.
ba83908c 4548
04f2d78b
CB
4549 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4550 New byte-codes.
03408648
SM
4551 (exec_byte_code): New function extracted from Fbyte_code to handle new
4552 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4553
03408648 4554 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4555
03408648 4556 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4557
e2abce01
JB
45582011-03-31 Juanma Barranquero <lekktu@gmail.com>
4559
4560 * xdisp.c (redisplay_internal): Fix prototype.
4561
63696a73 45622011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4563
63696a73 4564 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4565 (try_scrolling): Use it when setting scroll_limit.
4566 Limit scrolling to 100 screen lines.
63696a73
EZ
4567 (redisplay_window): Even when falling back on "recentering",
4568 position point in the window according to scroll-conservatively,
4569 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4570
4571 (try_scrolling): When point is above the window, allow searching
4572 as far as scroll_max, or one screenful, to compute vertical
4573 distance from PT to the scroll margin position. This prevents
4574 try_scrolling from unnecessarily failing when
4575 scroll-conservatively is set to a value slightly larger than the
4576 window height. Clean up the case of PT below the margin at bottom
4577 of window: scroll_max can no longer be INT_MAX. When aggressive
4578 scrolling is in use, don't let point enter the opposite scroll
4579 margin as result of the scroll.
4580 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4581 threshold of 100 lines for never-recentering scrolling.
4582
e4cc2dfc
JB
45832011-03-31 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * dispextern.h (move_it_by_lines):
4586 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4587 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4588 (message_log_check_duplicate): Remove parameters `prev_bol' and
4589 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4590 (redisplay_internal): Remove parameter `preserve_echo_area',
4591 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4592
4593 * indent.c (Fvertical_motion):
4594 * window.c (window_scroll_pixel_based, Frecenter):
4595 Don't pass `need_y_p' to `move_it_by_lines'.
4596
1c470562
SM
45972011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4598
44f230aa
SM
4599 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4600 steal a few bits to be more compact.
4601 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4602 Remove unneeded casts.
4603
1c470562
SM
4604 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4605
888adce9
ZK
46062011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4607
4608 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4609 binding" message (bug#7967).
4610
f838ed7b
PE
46112011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4612
77861b95
PE
4613 Fix more problems found by GCC 4.6.0's static checks.
4614
de6dbc14
PE
4615 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4616 Remove unused local var.
4617
f838ed7b
PE
4618 * editfns.c (Fmessage_box): Remove unused local var.
4619
792c7b2b
PE
4620 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4621 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4622 Omit unused local vars.
c499e557 4623 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4624 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4625 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4626 Omit unused local var.
4627
ba0165e1
PE
4628 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4629 Don't assume string length fits in int.
32ad8845 4630 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4631 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4632
3c59b4c9
PE
4633 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4634 instead of alloca (Bug#8344).
4635
a3eed478 4636 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4637 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4638
eb4d412d
PE
4639 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4640
1658b401
PE
4641 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4642 concerns.
4643
4644 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4645
4646 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4647
9a2c6e05
PE
4648 * keyboard.c (syms_of_keyboard): Use the same style as later
4649 in this function when indexing through an array. This also
4650 works around GCC bug 48267.
4651
03d0a109
PE
4652 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4653
44f730c8
PE
4654 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4655
fe75f926
PE
4656 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4657 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4658
ffa8c828
PE
4659 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4660 This avoids undefined behavior on integer overflow, and is a bit
4661 more convenient anyway since it is compared to a size_t variable.
4662
c5101a77
PE
4663 Variadic C functions now count arguments with size_t, not int.
4664 This avoids an unnecessary limitation on 64-bit machines, which
4665 caused (substring ...) to crash on large vectors (Bug#8344).
4666 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4667 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4668 All variadic functions and their callers changed accordingly.
c5101a77
PE
4669 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4670 * data.c (arith_driver, float_arith_driver): Likewise.
4671 * editfns.c (general_insert_function): Likewise.
4672 * eval.c (struct backtrace.nargs, interactive_p)
4673 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4674 (funcall_lambda, mark_backtrace): Likewise.
4675 * fns.c (concat): Likewise.
4676 * frame.c (x_set_frame_parameters): Likewise.
4677 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4678 0 if not found, not -1. All callers changed.
4679
dd3f25f7
PE
4680 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4681 (stack_copy_size): Now size_t, not int.
4682 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4683
461c2ab9
JB
46842011-03-28 Juanma Barranquero <lekktu@gmail.com>
4685
4686 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4687 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4688 All callers changed.
4689
4690 * lisp.h (multibyte_char_to_unibyte):
4691 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4692 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4693 * character.h (CHAR_TO_BYTE8):
4694 * cmds.c (internal_self_insert):
4695 * editfns.c (general_insert_function):
4696 * keymap.c (push_key_description):
4697 * search.c (Freplace_match):
4698 * xdisp.c (message_dolog, set_message_1): All callers changed.
4699
f6d62986
SM
47002011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4701
4702 * keyboard.c (safe_run_hook_funcall): New function.
4703 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4704 don't set the hook to nil, but remove the offending function instead.
4705 (Qcommand_hook_internal): Remove, unused.
4706 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4707 Vcommand_hook_internal.
4708
4709 * eval.c (enum run_hooks_condition): Remove.
4710 (funcall_nil, funcall_not): New functions.
4711 (run_hook_with_args): Call each function through a `funcall' argument.
4712 Remove `cond' argument, now redundant.
4713 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4714 (Frun_hook_with_args_until_failure): Adjust accordingly.
4715 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4716
1db5b1ad
JB
47172011-03-28 Juanma Barranquero <lekktu@gmail.com>
4718
4719 * dispextern.h (string_buffer_position): Remove declaration.
4720
4721 * print.c (strout): Remove parameter `multibyte', unused since
4722 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4723
4724 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4725 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4726 All callers changed.
4727
4728 * w32.c (_wsa_errlist): Use braces for struct initializers.
4729
4730 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4731 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4732 All callers changed.
4733 (string_buffer_position): Likewise. Also, make static (it's never
4734 used outside xdisp.c).
4735 (cursor_row_p): Remove parameter `w', unused since
4736 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4737 (decode_mode_spec): Remove parameter `precision', introduced during
4738 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4739 All callers changed.
4740
5ffb62aa
JD
47412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4742
4743 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4744
461c2ab9 47452011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4746
4747 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4748 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4749 (ns_update_auto_hide_menu_bar): New functions.
4750 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4751 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4752 ns_constrain_all_frames.
4753 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4754 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4755
5c380ffb
JD
47562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4757
4758 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4759
9af30bdf
GM
47602011-03-27 Glenn Morris <rgm@gnu.org>
4761
4762 * syssignal.h: Replace RETSIGTYPE with void.
4763 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4764 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4765 Replace SIGTYPE with void everywhere.
4766 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4767 * s/template.h (SIGTYPE): Remove commented out definition.
4768
e2abce01
JB
47692011-03-26 Eli Zaretskii <eliz@gnu.org>
4770
4771 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4772 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4773
f868cd8a
JB
47742011-03-26 Juanma Barranquero <lekktu@gmail.com>
4775
59eb0929
JB
4776 * w32.c (read_unc_volume): Use parameter `henum', instead of
4777 global variable `wget_enum_handle'.
4778
4779 * keymap.c (describe_vector): Remove parameters `indices' and
4780 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4781 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4782
f868cd8a
JB
4783 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4784
4785 * keyboard.c (timer_check): Remove parameter `do_it_now',
4786 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4787 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4788 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4789
4790 * keyboard.c (read_char):
4791 * w32menu.c (w32_menu_display_help):
4792 * xmenu.c (show_help_event, menu_help_callback):
4793 Adjust calls to `show_help_echo'.
4794
4795 * gtkutil.c (xg_maybe_add_timer):
4796 * keyboard.c (readable_events):
4797 * process.c (wait_reading_process_output):
4798 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4799
4800 * insdel.c (adjust_markers_gap_motion):
4801 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4802 (gap_left, gap_right): Don't call it.
4803
2ecf6fdb
CY
48042011-03-25 Chong Yidong <cyd@stupidchicken.com>
4805
4806 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4807 incurred during fontification.
4808
6b1f9ba4
JB
48092011-03-25 Juanma Barranquero <lekktu@gmail.com>
4810
4811 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4812 (DEFVAR_PER_BUFFER): Don't pass it.
4813
4814 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4815 (scrolling_window): Don't pass it.
4816
0f4a96b5
JB
48172011-03-25 Juanma Barranquero <lekktu@gmail.com>
4818
4819 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4820
4821 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4822 and `suffix'.
4823 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4824 of variables specific to SELinux and computation of `encoded_absname'.
4825
4826 * image.c (XPutPixel): Remove unused variable `height'.
4827
4828 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4829
4830 * unexw32.c (get_section_info): Remove unused variable `section'.
4831
4832 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4833 (system_process_attributes): Remove unused variable `sess'.
4834 (sys_read): Remove unused variable `err'.
4835
4836 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4837 (w32_wnd_proc): Remove unused variable `isdead'.
4838 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4839 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4840 (x_create_tip_frame): Remove unused variable `tem'.
4841
4842 * w32inevt.c (w32_console_read_socket):
4843 Remove unused variable `no_events'.
4844
4845 * w32term.c (x_draw_composite_glyph_string_foreground):
4846 Remove unused variable `width'.
4847
1149507c
JB
48482011-03-24 Juanma Barranquero <lekktu@gmail.com>
4849
4850 * w32term.c (x_set_glyph_string_clipping):
4851 Don't pass uninitialized region to CombineRgn.
4852
9c88f339
JB
48532011-03-23 Juanma Barranquero <lekktu@gmail.com>
4854
4855 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4856 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4857 (Fx_close_connection): Remove unused variable `i'.
4858
4859 * w32font.c (w32font_draw): Return number of glyphs.
4860 (w32font_open_internal): Remove unused variable `i'.
4861 (w32font_driver): Add missing initializer.
4862
4863 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4864 (fill_in_menu): Remove unused variable `items_added'.
4865
4866 * w32term.c (last_mouse_press_frame): Remove static global variable.
4867 (w32_clip_to_row): Remove unused variable `f'.
4868 (x_delete_terminal): Remove unused variable `i'.
4869
4870 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4871 (NOTHING): Remove unused static global variable.
4872 (uniscribe_check_otf): Remove unused variable `table'.
4873 (uniscribe_font_driver): Add missing initializers.
4874
dee091a3
JD
48752011-03-23 Julien Danjou <julien@danjou.info>
4876
4877 * term.c (Fsuspend_tty, Fresume_tty):
4878 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4879 * window.c (temp_output_buffer_show):
4880 * insdel.c (signal_before_change):
4881 * frame.c (Fhandle_switch_frame):
4882 * fileio.c (Fdo_auto_save):
4883 * emacs.c (Fkill_emacs):
4884 * editfns.c (save_excursion_restore):
4885 * cmds.c (internal_self_insert):
4886 * callint.c (Fcall_interactively):
4887 * buffer.c (Fkill_all_local_variables):
4888 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4889 Use Frun_hooks.
0f4a96b5 4890 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4891 unconditionnaly since it does the check itself.
4892
2c520ab5 48932011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4894
c9c49752
PE
4895 Fix more problems found by GCC 4.5.2's static checks.
4896
8abc3f12
PE
4897 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4898 the first time through the loop, since we know p0 < p1 then.
4899 This also avoids a gcc -Wstrict-overflow warning.
4900
a2d26660
PE
4901 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4902 leading to a memory leak, possible in functions like
4903 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4904 of objects (Bug#8318).
a2d26660 4905
916c72e9
PE
4906 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4907 that could (at least in theory) be that large.
4908
19ab8a18
PE
4909 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4910 This is less likely to overflow, and avoids undefined behavior if
4911 overflow does occur. All callers changed. Use strtoul to scan
4912 for the unsigned long integer.
b7cbbd6f
PE
4913 (pint2hrstr): Simplify and tune code slightly.
4914 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4915
f0641eff
PE
4916 * scroll.c (do_scrolling): Work around GCC bug 48228.
4917 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4918
7f650bb9
PE
4919 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4920 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4921 (validate_x_resource_name): Simplify count usage.
4922 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4923
37dd57d1
PE
4924 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4925 fail (Bug#8306).
81e56e61 4926
699979fc 4927 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4928
401bf9b4
PE
4929 * process.c (Fmake_network_process): Use socklen_t, not int,
4930 where POSIX says socklen_t is required in portable programs.
4931 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4932 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4933 (Fmake_network_process, server_accept_connection):
4934 (wait_reading_process_output, read_process_output):
4935 Likewise.
4936
b93aacde
PE
4937 * process.c: Rename or move locals to avoid shadowing.
4938 (list_processes_1, Fmake_network_process):
4939 (read_process_output_error_handler, exec_sentinel_error_handler):
4940 Rename or move locals.
4dc343ee 4941 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4942 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4943 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4944 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4945 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4946
af8a867c 4947 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4948 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4949 Include tparam.h instead, since it declares them.
af8a867c
PE
4950 * cm.h (PC): Remove extern decl; tparam.h now does this.
4951 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4952 * terminfo.c: Include tparam.h, to check interfaces.
4953 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4954 (tparam): Adjust signature to match interface in tparam.h;
4955 this removes some undefined behavior. Check that outstring and len
4956 are zero, which they always are with Emacs.
4957 * tparam.h (PC, BC, UP): New extern decls.
4958
0248044d 4959 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4960 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4961
8ff096c1 4962 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4963 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4964 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4965 (ftfont_list): Remove unused local.
49eaafba
PE
4966 (get_adstyle_property, ftfont_pattern_entity):
4967 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4968 Rename locals to avoid shadowing.
8ff096c1 4969
e2be39f6
PE
4970 * xfont.c (xfont_list_family): Mark var as initialized.
4971
c9735e30
PE
4972 * xml.c (make_dom): Now static.
4973
8f5201ae
PE
4974 * composite.c (composition_compute_stop_pos): Rename local to
4975 avoid shadowing.
b246f932
PE
4976 (composition_reseat_it): Remove unused locals.
4977 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4978 (composition_update_it): Mark var as initialized.
11b61122
PE
4979 (find_automatic_composition): Mark vars as initialized,
4980 with a FIXME (Bug#8290).
8f5201ae 4981
760fbc2c
PE
4982 character.h: Rename locals to avoid shadowing.
4983 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4984 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4985 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4986 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4987 to avoid shadowing.
4988
ff08eb85
PE
4989 * textprop.c (property_change_between_p): Remove; unused.
4990
fc7bf025
PE
4991 * intervals.c (interval_start_pos): Now static.
4992
235d7abc
PE
4993 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4994
44f230aa
SM
4995 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4996 Rename locals to avoid shadowing.
3e7d6594 4997
50060332
PE
4998 * sound.c (wav_play, au_play, Fplay_sound_internal):
4999 Fix pointer signedness.
d01f234b 5000 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5001 (wav_play): Initialize a variable to 0, to prevent undefined
5002 behavior (Bug#8278).
50060332 5003
c4fc4e30
PE
5004 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5005
918436ed
PE
5006 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5007
c939f91b
PE
5008 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5009 clobbering (Bug#8298).
b9c7f648
PE
5010 * sysdep.c (sys_subshell): Likewise.
5011 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5012
6bd8c144
PE
5013 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5014 This should get cleaned up, so that child_setup has the
5015 same signature on all platforms.
5016
7710357c 5017 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5018 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5019
c59da222
CY
50202011-03-22 Chong Yidong <cyd@stupidchicken.com>
5021
5022 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5023 not to be necessary, and produces flickering.
5024
66b87493
GM
50252011-03-20 Glenn Morris <rgm@gnu.org>
5026
5027 * config.in: Remove file.
5028
45b6f6d5
JB
50292011-03-20 Juanma Barranquero <lekktu@gmail.com>
5030
5031 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5032 are now in src/globals.h.
5033 (syms_of_minibuf): Remove spurious & from previous change.
5034
3ec03f7e
LL
50352011-03-20 Leo <sdl.web@gmail.com>
5036
5037 * minibuf.c (completing-read-function): New variable.
5038 (completing-read-default): Rename from completing-read.
5039 (completing-read): Call completing-read-function.
5040
b14e3e21
CY
50412011-03-19 Juanma Barranquero <lekktu@gmail.com>
5042
5043 * xfaces.c (Fx_load_color_file):
5044 Read color file from absolute filename (bug#8250).
5045
f2b726e6
JB
50462011-03-19 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * makefile.w32-in: Update dependencies.
5049
09f6ff02
EZ
50502011-03-17 Eli Zaretskii <eliz@gnu.org>
5051
5052 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5053
29a6015a
PE
50542011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5055
a3a6c54e
PE
5056 Fix more problems found by GCC 4.5.2's static checks.
5057
b766f867
PE
5058 * process.c (make_serial_process_unwind, send_process_trap):
5059 (sigchld_handler): Now static.
5060
be02381c
PE
5061 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5062 That way, the code declares only the vars that it needs.
5063 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5064 * s/cygwin.h (PTY_ITERATION): Likewise.
5065 * s/darwin.h (PTY_ITERATION): Likewise.
5066 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5067
57048744
PE
5068 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5069 * process.c (allocate_pty): Don't declare stb unless it's needed.
5070
7914961c 5071 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5072 (CONSTANTLIM): Remove; unused.
5073 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5074 Define only if needed.
7914961c 5075
b3967b18
PE
5076 * unexelf.c (unexec): Name an expression,
5077 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5078 Use a different way to cause a compilation error if anyone uses
5079 n rather than nn, a way that does not involve shadowing.
73366a00 5080 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5081
29a6015a
PE
5082 * deps.mk (unexalpha.o): Remove; unused.
5083
43cfc33e 5084 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5085 * unexec.h: New file.
ce701a33
PE
5086 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5087 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5088 Depend on unexec.h.
5089 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5090 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5091 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5092 Change as necessary to match prototype in unexec.h.
ce701a33 5093
01f44d5a
PE
5094 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5095 shadowing.
4f63c6bb 5096 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5097
a6670b0b
PE
5098 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5099 Rename locals to avoid shadowing.
5100
cef2010d 5101 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5102 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5103
d4d7173a
PE
5104 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5105
f08b802a
PE
5106 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5107 warning when compiling print.c.
5108
3ddb0639
PE
5109 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5110 instead of using an uninitialized var.
5ad03b97 5111 (font_sort_entities): Mark var as initialized.
3ddb0639 5112
170a2692
PE
5113 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5114
e663c700
PE
5115 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5116 pointers to constants.
89bc529a 5117 (font_parse_fcname): Remove unused vars.
7b81e2d0 5118 (font_delete_unmatched): Now static.
ea838e10 5119 (font_get_spec): Remove; unused.
13a547c6
PE
5120 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5121 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5122 Rename or move locals to avoid shadowing.
e663c700 5123
2a80c887 5124 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5125 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5126
1384fa33 5127 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5128 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5129
8b2c52e9
PE
5130 * alloc.c (mark_backtrace): Move decl from here ...
5131 * lisp.h: ... to here, so that it can be checked.
5132
475545b5 5133 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5134 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5135 (lisp_indirect_variable): Name an expression,
5136 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5137 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5138
b1349114 5139 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5140 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5141 Use const pointer when appropriate.
b1349114 5142
a2928364
PE
5143 * lisp.h (get_system_name, get_operating_system_release):
5144 Move decls here, to check interfaces.
5145 * process.c (get_operating_system_release): Move decl to lisp.h.
5146 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5147 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5148 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5149 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5150 (Fformat_time_string, Fencode_time, Finsert_char):
5151 (Ftranslate_region_internal, Fformat):
5152 Rename or remove local vars to avoid shadowing.
9710023e 5153 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5154
a415e694
PE
5155 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5156 avoid shadowing.
5157
8ef4622d
PE
5158 * lisp.h (eassert): Check that the argument compiles, even if
5159 ENABLE_CHECKING is not defined.
5160
946f9a5b
PE
5161 * data.c (Findirect_variable): Name an expression, to avoid
5162 gcc -Wbad-function-cast warning.
112396d6 5163 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5164 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5165 (Fmake_variable_buffer_local, Fmake_local_variable):
5166 Mark variables as initialized.
52746918 5167 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5168
e5aab7e7 5169 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5170 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5171 Rename locals to avoid shadowing.
dff45157
PE
5172 (mark_stack): Move local variables into the #ifdef region where
5173 they're used.
7bc26fdb
PE
5174 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5175 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5176 needed otherwise.
5177 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5178 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5179 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5180
e5aab7e7
PE
5181 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5182 avoids undefined behavior in theory.
5183
4da60324
PE
5184 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5185
88043301
PE
5186 Use functions, not macros, for up- and down-casing (Bug#8254).
5187 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5188 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5189 to use the following functions instead of these macros.
5190 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5191 EMACS_INT, since callers assume the returned value fits in int.
5192 (upcase1): Likewise, for UPCASE_TABLE.
5193 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5194 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5195 the race-condition problem in the old DOWNCASE.
88043301 5196
19ed5445
PE
5197 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5198 Rename locals to avoid shadowing.
5199 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5200 (regex_compile, re_search_2, re_match_2_internal):
5201 Remove unused local vars.
952db0d7
PE
5202 (FREE_VAR): Rewrite so as not to use empty "else",
5203 which gcc can warn about.
da053e48 5204 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5205 (RETALLOC_IF): Define only if needed.
5206 (WORDCHAR_P): Likewise. This one is never needed, but is used
5207 only in a comment talking about a compiler bug, so put inside
5208 the #if 0 of that comment.
5209 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5210 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5211 Remove; unused.
19ed5445 5212
1f3561e4 5213 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5214 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5215 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5216
ded6f8f7
PE
5217 * search.c (simple_search): Remove unused var.
5218
dbd37a95
PE
5219 * dired.c (compile_pattern): Move decl from here ...
5220 * lisp.h: ... to here, so that it can be checked.
5221 (struct re_registers): New forward decl.
5222
7e47afad
PE
5223 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5224
85f24f61
PE
5225 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5226 All uses changed.
5227 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5228 Rename locals to avoid shadowing.
5671df8f 5229 (Fvertical_motion): Mark locals as initialized.
85f24f61 5230
181aa2be 5231 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5232 (casify_region): Mark local as initialized.
181aa2be 5233
930d429c
PE
5234 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5235
7082eac6
PE
5236 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5237 New macros, so that the caller can use some names other than
5238 gcpro1, gcpro2, etc.
5239 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5240 of the new macros.
5241 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5242 argument, for consistency with GCPRO2_VAR, etc: it is now the
5243 prefix of the variable, not the variable itself. All uses
5244 changed.
38b2c076
PE
5245 * dired.c (directory_files_internal, file_name_completion):
5246 Rename locals to avoid shadowing.
5247
15206ed9
PE
5248 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5249 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5250 dired.c's scmp function, had undefined behavior.
5251 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5252 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5253 * buffer.h: ... to here, because these macros use current_buffer,
5254 and the new implementation with inline functions needs to have
5255 current_buffer in scope now, rather than later when the macros
5256 are used.
5257 (downcase, upcase1): New static inline functions.
5258 (DOWNCASE, UPCASE1): Reimplement using these functions.
5259 This avoids undefined behavior in expressions like
5260 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5261 from race conditions in accessing the global variables
5262 case_temp1 and case_temp2.
5263 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5264 * lisp.h (case_temp1, case_temp2): Remove their decls.
5265 * character.h (ASCII_CHAR_P): Move from here ...
5266 * lisp.h: ... to here, so that the inline functions mentioned
5267 above can use them.
5268
4a6bea26
PE
5269 * dired.c (directory_files_internal_unwind): Now static.
5270
f14b7e14
PE
5271 * fileio.c (file_name_as_directory, directory_file_name):
5272 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5273 Now static.
2893f146
PE
5274 (file_name_as_directory): Use const pointers when appropriate.
5275 (Fexpand_file_name): Likewise. In particular, newdir might
5276 point at constant storage, so make it a const pointer.
fd4ead52 5277 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5278 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5279 signedness issues.
f839df0c
PE
5280 (Fset_file_times, Finsert_file_contents, auto_save_error):
5281 Rename locals to avoid shadowing.
f14b7e14 5282
5716756e 5283 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5284 (Ftry_completion, Fall_completions): Rename or remove locals
5285 to avoid shadowing.
5716756e 5286
b4c3046a
PE
5287 * marker.c (bytepos_to_charpos): Remove; unused.
5288
b45db522
PE
5289 * lisp.h (verify_bytepos, count_markers): New decls,
5290 so that gcc does not warn that these functions aren't declared.
5291
85876d07
PE
5292 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5293 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5294 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5295 (copy_text): Remove unused local var.
85876d07 5296
03d78a21 5297 * filelock.c (within_one_second): Now static.
b3dd38ab 5298 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5299
5df8f01b
PE
5300 * buffer.c (fix_overlays_before): Mark locals as initialized.
5301 (fix_start_end_in_overlays): Likewise. This function should be
5302 simplified by using pointers-to-pointers, but that's a different
5303 matter.
b1d876f1 5304 (switch_to_buffer_1): Now static.
8f54f30a
PE
5305 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5306 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5307
a70072c9 5308 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5309 Fix pointer signedness issue.
edced198
PE
5310 (sys_subshell): Mark local as volatile if checking for lint,
5311 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5312 (MAXPATHLEN): Define only if needed.
a70072c9 5313
a0977c44
PE
5314 * process.c (serial_open, serial_configure): Move decls from here ...
5315 * systty.h: ... to here, so that they can be checked.
5316
a884fdcc
PE
5317 * fns.c (get_random, seed_random): Move extern decls from here ...
5318 * lisp.h: ... to here, so that they can be checked.
5319
604efe86 5320 * sysdep.c (reset_io): Now static.
b8950c94 5321 (wait_for_termination_signal): Remove; unused.
604efe86 5322
38fc62d9
PE
5323 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5324 (copy_keymap_item, append_key, push_text_char_description):
5325 Now static.
1004a21a 5326 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5327 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5328 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5329 (describe_map_tree):
5330 Rename locals to avoid shadowing.
38fc62d9 5331
2f2650da
PE
5332 * keyboard.c: Declare functions static if they are not used elsewhere.
5333 (echo_char, echo_dash, cmd_error, top_level_2):
5334 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5335 (read_char, kbd_buffer_get_event, make_lispy_position):
5336 (make_lispy_event, make_lispy_movement, apply_modifiers):
5337 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5338 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5339 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5340 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5341 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5342
a053e86c 5343 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5344 (mark_kboards): Move decl here ...
5345 * alloc.c (mark_kboards): ... from here.
a053e86c 5346
4752793e
PE
5347 * lisp.h (force_auto_save_soon): New decl.
5348
74f10ca7 5349 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5350 (DEFINE_DUMMY_FUNCTION): New macro.
5351 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5352 Use it.
c03cd23f
PE
5353 (main): Add casts to avoid warnings
5354 if GCC considers string literals to be constants.
74f10ca7 5355
022e70d4
PE
5356 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5357
59d6fe83
PE
5358 * dbusbind.c: Pointer signedness fixes.
5359 (xd_signature, xd_append_arg, xd_initialize):
5360 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5361 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5362 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5363 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5364
78320123
PE
5365 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5366 if GCC considers string literals to be constants.
49cebcca 5367 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5368
35ac2a97
SM
53692011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5370
fb103ca9
SM
5371 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5372 (print_preprocess, print_object): New macro to fix last change.
5373
35ac2a97
SM
5374 * print.c (print_preprocess): Don't forget font objects.
5375
62973b41
JB
53762011-03-16 Juanma Barranquero <lekktu@gmail.com>
5377
5378 * emacs.c (USAGE3): Doc fixes.
5379
0e48bb22
AS
53802011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5381
5382 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5383 structure.
5384
7684e57b
JB
53852011-03-14 Juanma Barranquero <lekktu@gmail.com>
5386
5387 * lisp.h (VWindow_system, Qfile_name_history):
5388 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5389 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5390 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5391
5392 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5393 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5394
5395 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5396 * w32console.c (detect_input_pending, read_input_pending)
5397 (encode_terminal_code):
5398 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5399 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5400 (w32_system_caret_y, Qfile_name_history):
5401 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5402 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5403 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5404 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5405 * w32proc.c (Qlocal, report_file_error):
5406 * w32term.c (Vwindow_system, updating_frame):
5407 * w32uniscribe.c (initialized, uniscribe_font_driver):
5408 Remove unneeded extern declarations.
5409
2aa46d6c
CY
54102011-03-14 Chong Yidong <cyd@stupidchicken.com>
5411
c96bbc66 5412 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5413
cffc6f3b
CY
54142011-03-13 Chong Yidong <cyd@stupidchicken.com>
5415
5416 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5417 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5418 These macros can no longer be used for assignment.
5419
44f230aa
SM
5420 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5421 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5422 (record_buffer_markers, fetch_buffer_markers): New functions for
5423 recording and fetching special buffer markers.
5424 (set_buffer_internal_1, set_buffer_temp): Use them.
5425
5426 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5427
5428 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5429
5430 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5431 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5432
5433 * xdisp.c (hscroll_window_tree):
5434 (reconsider_clip_changes): Use PT instead of BUF_PT.
5435
d251f04b
EZ
54362011-03-13 Eli Zaretskii <eliz@gnu.org>
5437
5438 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5439 $(EMACS_ROOT)/lib/intprops.h.
5440
f0c77cd1
PE
54412011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5442
3eca4629
PE
5443 Fix more problems found by GCC 4.5.2's static checks.
5444
7c86ee98
PE
5445 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5446 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5447 (xg_free_frame_widgets): Make it clear that a local variable is
5448 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5449 (gdk_window_get_screen): Make it clear that this macro is needed
5450 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5451 (int_gtk_range_get_value): New function, which avoids a diagnostic
5452 from gcc -Wbad-function-cast.
5453 (xg_set_toolkit_scroll_bar_thumb): Use it.
5454 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5455 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5456 (get_utf8_string, xg_get_file_with_chooser):
5457 Rename locals to avoid shadowing.
5458 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5459
41729b81
PE
5460 * xgselect.c (xg_select): Remove unused var.
5461
f0c77cd1
PE
5462 * image.c (four_corners_best): Mark locals as initialized.
5463 (gif_load): Initialize transparent_p to zero (Bug#8238).
5464 Mark another local as initialized.
ec6cf4c6 5465 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5466
ce0ad53d 5467 * image.c (clear_image_cache): Now static.
d5d5a617 5468 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5469 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5470 (x_edge_detection): Remove unnecessary cast that
5471 gcc -Wbad-function-cast diagnoses.
2037898d 5472 (gif_load): Fix pointer signedness.
6ae141d6
PE
5473 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5474 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5475
33383987 54762011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5477
d32df629
PE
5478 Improve quality of tests for time stamp overflow.
5479 For example, without this patch (encode-time 0 0 0 1 1
5480 1152921504606846976) returns the obviously-bogus value (-948597
5481 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5482 reports time overflow. See
5483 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5484 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5485 * editfns.c: Include limits.h and intprops.h.
5486 (TIME_T_MIN, TIME_T_MAX): New macros.
5487 (time_overflow): Move earlier, to before first use.
5488 (hi_time, lo_time): New functions, for an accurate test for
5489 out-of-range times.
5490 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5491 (Fget_internal_run_time): Don't assume time_t fits in int.
5492 (make_time): Use list2 instead of Fcons twice.
5493 (Fdecode_time): More accurate test for out-of-range times.
5494 (check_tm_member): New function.
5495 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5496 (lisp_time_argument): Don't rely on undefined left-shift and
5497 right-shift behavior when checking for time stamp overflow.
8be6f318 5498
fe31d94c
PE
5499 * editfns.c (time_overflow): New function, refactoring common code.
5500 (Fformat_time_string, Fdecode_time, Fencode_time):
5501 (Fcurrent_time_string): Use it.
5502
8be6f318
PE
5503 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5504 * dired.c (make_time): Move to ...
5505 * editfns.c (make_time): ... here.
5506 * systime.h: Note the move.
5507
09d9db2c 55082011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5509
126bc0dc
YM
5510 * fringe.c (update_window_fringes): Remove unused variables.
5511
c47cbdfd
YM
5512 * unexmacosx.c (copy_data_segment): Also copy __got section.
5513 (Bug#8223)
5514
7ac80be9
EZ
55152011-03-12 Eli Zaretskii <eliz@gnu.org>
5516
c96bbc66 5517 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5518 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5519 Constify `char *' arguments and their references according to
5520 prototypes in tparam.h.
5521
ecb0f94d 5522 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5523
7ac80be9
EZ
5524 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5525 Adapt all references accordingly.
5526
5527 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5528
ef1fd07e
TT
55292011-03-11 Tom Tromey <tromey@redhat.com>
5530
5531 * buffer.c (syms_of_buffer): Remove obsolete comment.
5532
7ef4b50c
EZ
55332011-03-11 Eli Zaretskii <eliz@gnu.org>
5534
5535 * termhooks.h (encode_terminal_code): Declare prototype.
5536
5537 * msdos.c (encode_terminal_code): Don't declare prototype.
5538
5539 * term.c (encode_terminal_code): Now external again, used by
5540 w32console.c and msdos.c.
5541
44f230aa
SM
5542 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5543 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5544
4b1ec863 55452011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5546
1714f52b 5547 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5548
4b1ec863
PE
5549 * fringe.c (update_window_fringes): Mark locals as initialized
5550 (Bug#8227).
5551 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5552
524c7aa6
PE
5553 * alloc.c (mark_fringe_data): Move decl from here ...
5554 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5555 to check its interface.
5556 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5557
a5c0af81 5558 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5559 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5560 (fontset_font): Mark local as initialized.
a9a06e0b 5561 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5562
b4716021
PE
5563 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5564
811e9bac 5565 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5566 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5567 (x_own_selection, Fx_disown_selection_internal): Rename locals
5568 to avoid shadowing.
5569 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5570
7e3ab302
PE
5571 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5572 so that the caller can use some name other than gcpro1.
5573 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5574 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5575 (Fx_backspace_delete_keys_p):
5576 Use them to avoid shadowing, and rename vars to avoid shadowing.
5577 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5578 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5579 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5580 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5581 Remove unused locals.
7e3ab302
PE
5582 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5583 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5584 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5585 macros.
f78faa98 5586
e2b13473
PE
5587 * xterm.h (x_mouse_leave): New decl.
5588
77f23912
PE
5589 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5590 Remove unused functions.
cdf4ba58
PE
5591 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5592 (x_calc_absolute_position): Now static.
7411c686 5593 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5594 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5595 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5596 unless they are used.
38d0b34a
PE
5597 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5598 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5599 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5600 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5601 (x_error_catcher, x_connection_closed, x_error_handler):
5602 (x_error_quitter, xembed_send_message, x_iconify_frame):
5603 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5604 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5605 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5606
44f230aa
SM
5607 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5608 Rename or move locals to avoid shadowing.
6b463e58 5609 (tty_defined_color, merge_face_heights): Now static.
5967d051 5610 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5611 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5612 does not deduce is never used uninitialized.
73719eba
PE
5613 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5614 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5615
426994c3 5616 * terminal.c (store_terminal_param): Now static.
5489860b 5617
032f1620 5618 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5619 (set_frame_menubar): Remove unused local.
d4323972 5620 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5621 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5622 since they might point to immutable storage.
281585b0
PE
5623 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5624 since it's unused otherwise.
032f1620 5625
367c19e5 5626 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5627 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5628 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5629 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5630 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5631 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5632 does not deduce are never used uninitialized.
70739cbe 5633
07b48fa9
PE
5634 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5635
8868a238 5636 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5637 * window.c (window_loop, size_window):
5638 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5639
7e5cf297 5640 * window.c (display_buffer): Now static.
d6550a9f
PE
5641 (size_window): Mark variables that gcc -Wuninitialized
5642 does not deduce are never used uninitialized.
a586633d
PE
5643 * window.h (check_all_windows): New decl, to forestall
5644 gcc -Wmissing-prototypes diagnostic.
5b555da1 5645 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5646
f6095868
PE
5647 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5648 shadowing.
5649 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5650 Include <limits.h>.
5651 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5652 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5653 (load_charset_map): Mark variables that gcc -Wuninitialized
5654 does not deduce are never used uninitialized.
53df7c11 5655 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5656
f38b440c
PE
5657 * coding.c (coding_set_source, coding_set_destination):
5658 Use "else { /* comment */ }" rather than "else /* comment */;"
5659 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5660 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5661 a block, when the outer 'i' will do.
5662 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5663 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5664 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5665 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5666 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5667 Rename locals to avoid shadowing.
5668 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5669 * coding.c (emacs_mule_char, encode_invocation_designation):
5670 Now static, since they're not used elsewhere.
413bb2db 5671 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5672 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5673 (decode_coding_emacs_mule): Mark variables that gcc
5674 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5675 (detect_coding_iso_2022): Initialize a local variable that might
5676 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5677 this initialization is needed. (Bug#8211)
5f58e762
PE
5678 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5679 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5680 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5681 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5682 Remove unused macros.
f38b440c 5683
232b38b9 5684 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5685 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5686 * character.c (string_count_byte8): Likewise.
232b38b9 5687
fb90da1b
PE
5688 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5689 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5690
fb93dbc2
PE
5691 * chartab.c (copy_sub_char_table): Now static, since it's not used
5692 elsewhere.
5c156ace
PE
5693 (sub_char_table_ref_and_range, char_table_ref_and_range):
5694 Rename locals to avoid shadowing.
bbcd0949 5695 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5696
7d3b3862 5697 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5698 (BIDI_BOB): Remove unused macro.
7d3b3862 5699
6be7d3da
PE
5700 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5701 deduce are never used uninitialized.
c2ed9c8b 5702 * term.c (encode_terminal_code): Likewise.
6be7d3da 5703
75f8807f 5704 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5705
50938595
PE
5706 * tparam.h: New file.
5707 * term.c, tparam.h: Include it.
5708 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5709 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5710 Move these decls to tparam.h, and make them agree with what
5711 is actually in tparam.c. The previous trick of using incompatible
5712 decls in different modules does not conform to the C standard.
5713 All callers of tparam changed to use tparam's actual API.
5714 * tparam.c (tparam1, tparam, tgoto):
5715 Use const pointers where appropriate.
5716
fbceeba2
PE
5717 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5718 * cm.h (struct cm): Likewise.
5719 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5720 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5721 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5722 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5723 (turn_on_face, init_tty): Likewise.
5724 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5725
7f3f1250
PE
5726 * term.c (term_mouse_position): Rename local to avoid shadowing.
5727
e6ca6543
PE
5728 * alloc.c (mark_ttys): Move decl from here ...
5729 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5730
c40f8d15
AS
57312011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5732
5733 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5734
cfe0661d
JB
57352011-03-09 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * search.c (compile_pattern_1): Remove argument regp, unused since
5738 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5739 (compile_pattern): Don't pass it.
5740
0afb4571
J
57412011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5742
5743 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5744 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5745 for ! HAVE_GTK3.
5746 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5747
5748 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5749
5750 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5751 gdk_window_get_screen, gdk_window_get_geometry,
5752 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5753 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5754 (xg_get_pixbuf_from_pixmap): New function.
5755 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5756 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5757 Call xg_get_pixbuf_from_pixmap instead of
5758 gdk_pixbuf_get_from_drawable.
5759 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5760 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5761 (xg_check_special_colors): Use GtkStyleContext and its functions
5762 for HAVE_GTK3.
5763 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5764 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5765 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5766 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5767 Call gtk_widget_get_preferred_size.
0afb4571
J
5768 (xg_frame_resized): gdk_window_get_geometry only takes 5
5769 parameters.
44f230aa
SM
5770 (xg_win_to_widget, xg_event_is_for_menubar):
5771 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5772 (xg_set_widget_bg): New function.
5773 (delete_cb): New function.
895009e1 5774 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5775 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5776 (xg_set_background_color): Call xg_set_widget_bg.
5777 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5778 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5779 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5780 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5781 if ! HAVE_GTK3.
5782 (update_frame_tool_bar): Call gtk_widget_hide.
5783 (xg_initialize): Use GDK_KEY_g.
5784
5785 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5786 if ! HAVE_GTK3
5787 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5788
5789 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5790 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5791 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5792
1c2cc4ef
JB
57932011-03-08 Juanma Barranquero <lekktu@gmail.com>
5794
5795 * w32xfns.c (select_palette): Check success of RealizePalette against
5796 GDI_ERROR, not zero.
5797
33383987 5798See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5799
5800;; Local Variables:
5801;; coding: utf-8
aac0c6e3
MR
5802;; End:
5803
33383987 5804 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5805
5806 This file is part of GNU Emacs.
5807
5808 GNU Emacs is free software: you can redistribute it and/or modify
5809 it under the terms of the GNU General Public License as published by
5810 the Free Software Foundation, either version 3 of the License, or
5811 (at your option) any later version.
5812
5813 GNU Emacs is distributed in the hope that it will be useful,
5814 but WITHOUT ANY WARRANTY; without even the implied warranty of
5815 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5816 GNU General Public License for more details.
5817
5818 You should have received a copy of the GNU General Public License
5819 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.