Switch from NO_RETURN to C11's _Noreturn.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
696056c2
EZ
12012-06-24 Eli Zaretskii <eliz@gnu.org>
2
3 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4 (SYSTIME_H): Add nt/inc/sys/time.h.
5
6 * systime.h [WINDOWSNT]: Include sys/time.h.
7
8 * s/ms-w32.h (struct timespec): Definition moved from
9 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
10
845ca893
PE
112012-06-24 Paul Eggert <eggert@cs.ucla.edu>
12
13 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
14 * buffer.h (buffer_slot_type_mismatch):
15 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
16 * eval.c (unwind_to_catch):
17 * image.c (my_png_error, my_error_exit):
18 * keyboard.c (quit_throw_to_read_char, user_error)
19 (Fexit_recursive_edit, Fabort_recursive_edit):
20 * lisp.h (die, args_out_of_range, args_out_of_range_3)
21 (wrong_type_argument, buffer_overflow, __executable_start)
22 (memory_full, buffer_memory_full, string_overflow, Fthrow)
23 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
24 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
25 (fatal):
26 (child_setup) [!DOS_NT]:
27 * lread.c (end_of_file_error, invalid_syntax):
28 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
29 * puresize.h (pure_write_error):
30 * search.c (matcher_overflow):
31 * sound.c (sound_perror, alsa_sound_perror):
32 * sysdep.c, syssignal.h (croak):
33 * term.c (maybe_fatal, vfatal):
34 * textprop.c (text_read_only):
35 * undo.c (user_error):
36 * unexmacosx.c (unexec_error):
37 * xterm.c (x_ins_del_lines, x_delete_glyphs):
38 Use _Noreturn rather than NO_RETURN.
39 No need for separate decl merely because of _Noreturn.
40 * sound.c (sound_warning, parse_sound):
41 Remove unnecessary forward decls.
42
f1dd8073
PE
432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
44
45 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
46 * lisp.h (WAIT_READING_MAX): New macro.
47 * dispnew.c (Fsleep_for, sit_for):
48 * keyboard.c (kbd_buffer_get_event):
49 * process.c (Faccept_process_output):
50 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
51 This improves on the previous patch, which introduced a bug
52 when time_t is unsigned and as wide as intmax_t.
53 See <http://bugs.gnu.org/9000#51>.
54
b82c1755
EZ
552012-06-23 Eli Zaretskii <eliz@gnu.org>
56
57 * dispnew.c (sit_for, Fsleep_for):
58 * keyboard.c (kbd_buffer_get_event):
59 * process.c (Faccept_process_output): Avoid compiler warnings when
60 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
61
ca300656
JB
622012-06-23 Juanma Barranquero <lekktu@gmail.com>
63
049ec95b
JB
64 * makefile.w32-in: Update dependencies.
65
ca300656
JB
66 * w32.c (ltime): Add return type and declare static.
67 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
68
db7b8d06
PE
692012-06-23 Paul Eggert <eggert@cs.ucla.edu>
70
71 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
72 Privately reported by Herbert J. Skuhra.
73 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
74 All uses changed.
75 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
76 not make_lisp_timeval, when the argument is of type EMACS_TIME.
77
0bd8297f
EZ
782012-06-23 Eli Zaretskii <eliz@gnu.org>
79
96512555
EZ
80 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
81 last argument of make_unibyte_string.
82
0bd8297f
EZ
83 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
84 language ID in the event parameters.
85
86 * w32term.c (w32_read_socket): Put the new keyboard codepage into
87 event.code, not the obscure "character set ID".
88
63def6b6
CY
892012-06-23 Chong Yidong <cyd@gnu.org>
90
91 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
92
e8a02204
EZ
932012-06-23 Eli Zaretskii <eliz@gnu.org>
94
388cdec0
EZ
95 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
96 * w32.c (fdutimens): New function.
97
98 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
99
100 * s/ms-w32.h (pselect): Redirect to sys_select.
101
102 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
103
e8a02204
EZ
104 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
105 in the logic of incrementing and decrementing the value of
106 use_relocatable_buffers.
107
d054f3fb
PE
1082012-06-23 Paul Eggert <eggert@cs.ucla.edu>
109
110 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
111 Privately reported by Herbert J. Skuhra.
112 [__FreeBSD__]: Remove "*/" typo after "#include".
113 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
114 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
115 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
116 Don't assume EMACS_TIME and struct timeval are the same type.
117
d35af63c
PE
1182012-06-22 Paul Eggert <eggert@cs.ucla.edu>
119
120 Support higher-resolution time stamps (Bug#9000).
121 The time stamps are only nanosecond-resolution at the C level,
122 since that's the best that any real-world system supports now.
123 But they are picosecond-resolution at the Lisp level, as that's
124 easy, and leaves room for future OS improvements.
125
126 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
127 (LIBES): Use it.
128
129 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
130 Don't get current time unless it's needed.
131
132 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
133 now provides it if it's absent.
134 (start_atimer): Port to higher-res time stamps.
135 Check for time stamp overflow. Don't get current time more
136 often than is needed.
137
138 * buffer.h (struct buffer): Buffer modtime now has high resolution.
139 Include systime.h, not time.h.
140 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
141
142 * dired.c: Include stat-time.h.
143 (Ffile-attributes): File times now have higher resolution.
144
145 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
146 (struct image): Timestamp now has higher resolution.
147
148 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
149 has at least microseconds now. All uses removed.
150 (update_frame, update_single_window, update_window, update_frame_1)
151 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
152
153 * editfns.c (time_overflow): Now extern.
154 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
155 (float-time, Fformat_time_string, Fcurrent_time_string)
156 (Fcurrent_time_zone): Accept and generate higher-resolution
157 time stamps.
158 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
159 (decode_time_components, lisp_seconds_argument): New functions.
160 (make_time): Now static.
161 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
162 Report an error if the time is invalid, rather than having the caller
163 do that.
164
165 * fileio.c: Include <stat-time.h>
166 (Fcopy_file): Copy higher-resolution time stamps.
167 Prefer to set the time stamp via a file descriptor if that works.
168 (Fset_file_times, Finsert_file_contents, Fwrite_region)
169 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
170 (Fvisited_file_modtime, Fset_visited_file_modtime):
171 Support higher-resolution time stamps.
172
173 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
174
175 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
176
177 * image.c (prepare_image_for_display, clear_image_cache)
178 (lookup_image): Port to higer-resolution time stamps.
179
180 * keyboard.c (start_polling, bind_polling_period):
181 Check for time stamp overflow.
182 (read_char, kbd_buffer_get_event, timer_start_idle)
183 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
184 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
185 Port to higher-resolution time stamps. Do not assume time_t is signed.
186 (decode_timer): New function. Timers are now vectors of length 9,
187 not 8, to accommodate the picosecond component.
188 (timer_check_2): Use it.
189
190 * nsterm.m (select_timeout, timeval_subtract): Remove.
191 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
192 as they're a bit more accurate and handle overflow better.
193 (ns_select): Change prototype to be compatible with pselect.
194 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
195 * nsterm.h (ns_select): Adjust prototype.
196
197 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
198 us-resolution time stamps.
199 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
200
201 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
202
203 * lisp.h (time_overflow): New decl.
204 (wait_reading_process_output): First arg is now intmax_t, not int,
205 to accommodate larger waits.
206
207 * process.h (struct Lisp_Process.read_output_delay):
208 Now counts nanoseconds, not microseconds.
209 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
210 EMACS_HAS_USECS.
211 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
212 (wait_reading_process_output):
213 Port to ns-resolution time stamps.
214 (Faccept_process_output, wait_reading_process_output):
215 Check for time stamp overflow. Do not assume time_t is signed.
216 (select_wrapper): Remove; we now use pselect.
217 (Fprocess_attributes): Now generates ns-resolution time stamps.
218
219 * sysdep.c: Include utimens.h. Don't include utime.h
220 or worry about struct utimbuf; gnulib does that for us now.
221 (gettimeofday): Remove; gnulib provides a substitute.
222 (make_timeval): New function.
223 (set_file_times): Now sets ns-resolution time stamps.
224 New arg FD; all uses changed.
225 (time_from_jiffies, ltime_from_jiffies, get_up_time)
226 (system_process_attributes):
227 Now returns ns-resolution time stamp. All uses changed.
228 Check for time stamp overflow.
229
230 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
231 provides a substitute now.
232
233 * systime.h: Include timespec.h rather than sys/time.h and time.h,
234 since it guarantees struct timespec.
235 (EMACS_TIME): Now struct timespec, so that we can support
236 ns-resolution time stamps.
237 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
238 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
239 (EMACS_USECS): Remove.
240 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
241 so multiply the arg by 1000 before storing it.
242 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
243 New macros.
244 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
245 Port to ns-resolution time stamps.
246 (EMACS_TIME_NEG_P): Remove; replaced by....
247 (EMACS_TIME_SIGN): New macro.
248 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
249 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
250 (set_file_times, make_time, lisp_time_argument): Adjust signature.
251 (make_timeval, make_lisp_time, decode_time_components): New decls.
252 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
253 that it mishandled time_t overflow. You can't compare by subtracting!
254 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
255 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
256
257 * term.c: Include <sys/time.h>.
258 (timeval_to_Time): New function, for proper overflow wraparound.
259 (term_mouse_position, term_mouse_click): Use it.
260
261 * undo.c (record_first_change): Support higher-resolution time stamps
262 in the undo buffer.
263 (Fprimitive_undo): Use them when restoring time stamps.
264
265 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
266 (w32_get_internal_run_time):
267 Port to higher-resolution Emacs time stamps.
268 (ltime): Now accepts single 64-bit integer, as that's more convenient
269 for callers.
270
271 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
272
273 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
274 for compatibility with pselect. Support ns-resolution time stamps.
275
276 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
277
278 * xselect.c (wait_for_property_change, x_get_foreign_selection):
279 Check for time stamp overflow, and support ns-resolution time stamps.
280
281 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
282 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
283 (timeval_subtract): Remove; no longer needed.
284 (XTflash, XTring_bell, x_wait_for_event):
285 Port to ns-resolution time stamps. Don't assume time_t is signed.
286
b6a92dfe
CY
2872012-06-22 Chong Yidong <cyd@gnu.org>
288
289 * xdisp.c (x_consider_frame_title): Revert last change.
290
d251c37c
EZ
2912012-06-22 Eli Zaretskii <eliz@gnu.org>
292
293 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
294 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
295 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
296 staticidx goes up to 1597 out of 1600 = 0x640.)
297
f10deafb
PE
2982012-06-20 Paul Eggert <eggert@cs.ucla.edu>
299
300 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
301 Otherwise, the umask might be mistakenly 0 while handling input signals.
302
ec6de1e2
SM
3032012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
304
305 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
306
28be1ada
DA
3072012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
308
309 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
310 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
311 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
312 access to `contents' member of Lisp_Vector objects with AREF and ASET
313 where appropriate.
314
c6bf3022
CY
3152012-06-19 Chong Yidong <cyd@gnu.org>
316
317 * frame.c (delete_frame): When selecting a frame on a different
318 text terminal, do not alter the terminal's top-frame.
319
320 * xdisp.c (format_mode_line_unwind_data): Record the target
321 frame's selected window and its terminal's top-frame.
322 (unwind_format_mode_line): Restore them.
323 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
324 Callers changed.
325 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
326 since tty frames can be explicitly named.
327 (prepare_menu_bars): Likewise.
328
329 * term.c (Ftty_top_frame): New function.
330
defd4196
PE
3312012-06-18 Paul Eggert <eggert@cs.ucla.edu>
332
333 Port byte-code-meter to modern targets.
334 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
335 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 336 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
337 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
338 (METER_1, METER_2): Simplify.
339
1053a871
SM
3402012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
341
342 * data.c (Fdefalias): Return `symbol' (bug#11686).
343
b7e8d081
MR
3442012-06-18 Martin Rudalics <rudalics@gmx.at>
345
346 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
347 gets killed during executing of this function (Bug#11665).
348 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
349 (Vkill_buffer_query_functions): In doc-string say that functions
350 run by this hook should not change the current buffer.
351
7ea2b339
PE
3522012-06-18 Paul Eggert <eggert@cs.ucla.edu>
353
354 Fix recently-introduced process.c problems found by static checking.
355 * process.c (write_queue_push, write_queue_pop, send_process):
356 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
357 (write_queue_pop): Fix pointer signedness problem.
358 (send_process): Remove unused local.
359
96a313a1
CY
3602012-06-17 Chong Yidong <cyd@gnu.org>
361
362 * xdisp.c (redisplay_internal): No need to redisplay terminal
363 frames that are not on top.
364
20ca2e94
TN
3652012-06-17 Troels Nielsen <bn.troels@gmail.com>
366
367 * process.c (make_process): Initialize write_queue.
368 (write_queue_push, write_queue_pop): New functions.
369 (send_process): Use them to maintain correct ordering of process
370 writes (Bug#10815).
371
9a900ca9
PE
3722012-06-17 Paul Eggert <eggert@cs.ucla.edu>
373
310fbfa8
PE
374 * lisp.h (eassert): Assume C89 or later.
375 This removes the need for CHECK.
376 (CHECK): Remove. Its comments about always evaluating its
377 argument were confusing, as 'eassert' typically does not evaluate
378 its argument.
379
27bb1ca4
PE
380 * coding.c (produce_chars): Use ptrdiff_t, not int.
381
9a900ca9
PE
382 * xterm.c (x_draw_underwave): Check for integer overflow.
383 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
384
41b7f8bc 3852012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
386
387 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
388 referenced (Bug#11583).
389
9b0e3eba
AA
3902012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
391
392 Implement wave-style variant of underlining.
393 * dispextern.h (face_underline_type): New enum.
394 (face): Add field for underline type.
395 * nsterm.m (ns_draw_underwave): New function.
396 (ns_draw_text_decoration): Use it.
397 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
398 New functions.
399 (x_draw_glyph_string): Use them.
400 * xfaces.c (Qline, Qwave): New Lisp objects.
401 (check_lface_attrs, merge_face_ref)
1053a871
SM
402 (Finternal_set_lisp_face_attribute, realize_x_face):
403 Handle wave-style underline face attributes.
9b0e3eba
AA
404 * xterm.c (x_draw_underwave): New function.
405 (x_draw_glyph_string): Use it.
406
0fb52f11
JB
4072012-06-16 Juanma Barranquero <lekktu@gmail.com>
408
409 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
410 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
411 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
412 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
413 ($(BLD)/w32select.$(O)): Update dependencies.
414
e5560ff7
AS
4152012-06-16 Andreas Schwab <schwab@linux-m68k.org>
416
417 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
418 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
419 * character.c (_fetch_multibyte_char_p): Remove.
420 * alloc.c: Include "character.h" before "buffer.h".
421 * bidi.c: Likewise.
422 * buffer.c: Likewise.
423 * bytecode.c: Likewise.
424 * callint.c: Likewise.
425 * callproc.c: Likewise.
426 * casefiddle.c: Likewise.
427 * casetab.c: Likewise.
428 * category.c: Likewise.
429 * cmds.c: Likewise.
430 * coding.c: Likewise.
431 * composite.c: Likewise.
432 * dired.c: Likewise.
433 * dispnew.c: Likewise.
434 * doc.c: Likewise.
435 * dosfns.c: Likewise.
436 * editfns.c: Likewise.
437 * emacs.c: Likewise.
438 * fileio.c: Likewise.
439 * filelock.c: Likewise.
440 * font.c: Likewise.
441 * fontset.c: Likewise.
442 * fringe.c: Likewise.
443 * indent.c: Likewise.
444 * insdel.c: Likewise.
445 * intervals.c: Likewise.
446 * keyboard.c: Likewise.
447 * keymap.c: Likewise.
448 * lread.c: Likewise.
449 * macros.c: Likewise.
450 * marker.c: Likewise.
451 * minibuf.c: Likewise.
452 * nsfns.m: Likewise.
453 * nsmenu.m: Likewise.
454 * print.c: Likewise.
455 * process.c: Likewise.
456 * regex.c: Likewise.
457 * region-cache.c: Likewise.
458 * search.c: Likewise.
459 * syntax.c: Likewise.
460 * term.c: Likewise.
461 * textprop.c: Likewise.
462 * undo.c: Likewise.
463 * unexsol.c: Likewise.
464 * w16select.c: Likewise.
465 * w32fns.c: Likewise.
466 * w32menu.c: Likewise.
467 * window.c: Likewise.
468 * xdisp.c: Likewise.
469 * xfns.c: Likewise.
470 * xmenu.c: Likewise.
471 * xml.c: Likewise.
472 * xselect.c: Likewise.
473
2f07e6af
EZ
4742012-06-16 Eli Zaretskii <eliz@gnu.org>
475
1053a871
SM
476 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
477 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 478 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
479 row.
480 (handle_face_prop): Use chunk-relative overlay string index when
481 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
482 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
483 the rightmost. (Bug#11720)
2f07e6af 484
29b83cec
AS
4852012-06-16 Andreas Schwab <schwab@linux-m68k.org>
486
487 * category.h (CHAR_HAS_CATEGORY): Define as inline.
488 (CATEGORY_MEMBER): Enforce 1/0 value.
489 * category.c (_temp_category_set): Remove.
490
4c5501e9
EZ
4912012-06-16 Eli Zaretskii <eliz@gnu.org>
492
493 * window.c (Fdelete_other_windows_internal)
494 (Fdelete_window_internal): Don't access frame's mouse highlight
495 info of the initial frame. (Bug#11677)
496
2b570124
PE
4972012-06-14 Paul Eggert <eggert@cs.ucla.edu>
498
e93864f9
PE
499 * .gdbinit (xgetint): Fix recently-introduced paren typo.
500 Assume USE_2_TAGS_FOR_INTS.
501 (xreload): Adjust $tagmask width to match recent lisp.h change.
502
2b570124
PE
503 Simplify lisp.h in minor ways that should not affect code.
504 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
505 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
506 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
507 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
508 (INTTYPEBITS): New macro, for clarity.
509 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
510 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
511 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
512 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
513 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
514
81755f69
JB
5152012-06-13 Juanma Barranquero <lekktu@gmail.com>
516
517 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
518
16192a57
GM
5192012-06-13 Glenn Morris <rgm@gnu.org>
520
521 * s/bsd-common.h (BSD4_3):
522 * s/usg5-4-common.h (USG5_4): No longer define; unused.
523
646b5f55
AS
5242012-06-13 Andreas Schwab <schwab@linux-m68k.org>
525
526 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
527 instead of union.
528 (XLI, XIL): Define.
1053a871
SM
529 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
530 Use them.
531 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 532 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 533 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
534 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
535 * frame.c (delete_frame): Remove outdated comment.
536 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
537 USE_LISP_UNION_TYPE.
538 (Fw32_unregister_hot_key): Likewise.
539 (Fw32_toggle_lock_key): Likewise.
540 * w32menu.c (add_menu_item): Likewise.
541 (w32_menu_display_help): Use XIL instead of checking
542 USE_LISP_UNION_TYPE.
543 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
544 (init_heap): Likewise.
545 * w32term.c (w32_read_socket): Update comment.
546
1d3823c9
GM
5472012-06-13 Glenn Morris <rgm@gnu.org>
548
c62ff706
GM
549 * s/usg5-4-common.h, src/s/unixware.h:
550 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
551
1d3823c9
GM
552 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
553
bfe3e0a2
PE
5542012-06-13 Paul Eggert <eggert@cs.ucla.edu>
555
556 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
557 * alloc.c (make_number) [!defined make_number]:
558 Remove, as lisp.h always defines this now.
559 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
560 (roundup_size): Verify that it is a power of 2.
561 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
562 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
563 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
564 -DUSE_LSB_TAG=0, to override the automatically-selected default.
565 USE_LSB_TAG now is always defined to be either 0 or 1.
566 All uses changed.
567 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
568 code works fine either way, and efficiency is not a concern here,
569 as the union type is for debugging, not for production.
570 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
571 Use an inline function on all platforms when using the union type,
572 since this is simpler and 'static inline' can be used portably
573 within Emacs now.
574 (LISP_INITIALLY_ZERO): New macro.
575 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
576 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
577
45fa9c0f
GM
5782012-06-12 Glenn Morris <rgm@gnu.org>
579
b4492cba
GM
580 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
581
582 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 583
45fa9c0f
GM
584 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
585 Move BROKEN_SIGIO to configure.
586
587 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
588 Move NO_TERMIO to configure.
589
0e25d334
CY
5902012-06-12 Chong Yidong <cyd@gnu.org>
591
592 * image.c (imagemagick_load_image): Use MagickFlattenImage if
593 MagickMergeImageLayers is undefined. Use pixel pusher loop if
594 MagickExportImagePixels is undefined.
595
43682bb6
PE
5962012-06-12 Paul Eggert <eggert@cs.ucla.edu>
597
598 * image.c (imagemagick_load_image): Remove unused label.
599
a9be7d2b
GM
6002012-06-11 Glenn Morris <rgm@gnu.org>
601
602 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
603 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
604 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
605 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
606
3017f87f
SM
6072012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
608
609 * alloc.c (make_byte_code): New function.
610 (Fmake_byte_code): Use it. Don't purify here.
611 * lread.c (read1): Use it as well to avoid extra allocation.
612
1b9b4cf4
CY
6132012-06-11 Chong Yidong <cyd@gnu.org>
614
615 * image.c (imagemagick_load_image): Implement transparency.
616
95988fcf
AS
6172012-06-10 Andreas Schwab <schwab@linux-m68k.org>
618
619 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
620 account for preceding backslashes. (Bug#11663)
621
cd4eb164
CY
6222012-06-09 Chong Yidong <cyd@gnu.org>
623
624 * term.c: Support italics in capable terminals (Bug#9652).
625 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
626 (turn_on_face): Output using TS_enter_italic_mode if available.
627 Don't handle unused blinking and alt-charset cases.
628 (turn_off_face): Handle italic case; discard unused tty_blinking_p
629 and tty_alt_charset_p cases.
630 (tty_capable_p, init_tty): Support italics.
631
632 * termchar.h (struct tty_display_info): Add field for italics.
633 Remove unused blink field.
634
635 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
636 Handle slant.
637
638 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
639 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
640 tty_alt_charset_p. Add tty_italic_p.
641
ff88beb8
MA
6422012-06-09 Michael Albinus <michael.albinus@gmx.de>
643
644 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
645 dbus_type_is_basic if available.
646 (xd_extract_signed, xd_extract_unsigned): Rename from
647 extract_signed and extract_unsigned, respectively. Adapt callers.
648
44286096
CY
6492012-06-09 Chong Yidong <cyd@gnu.org>
650
1682701f
CY
651 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
652
44286096
CY
653 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
654 case (Bug#9752).
655
d86feb17
PE
6562012-06-08 Paul Eggert <eggert@cs.ucla.edu>
657
658 * xdisp.c (vmessage): Treat frame message as multibyte.
659 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
660 would generate the diagnostic "Making \302\247 buffer-local while
661 let-bound!".
662
d5c20fe8
EZ
6632012-06-08 Eli Zaretskii <eliz@gnu.org>
664
665 * dispnew.c (showing_window_margins_p): Undo last change, which
666 was done due to an inadvertent commit.
667 (adjust_frame_glyphs_for_frame_redisplay): Do call
668 showing_window_margins_p.
669
513749ee
SM
6702012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
671
672 * eval.c (Fmake_var_non_special): New primitive.
673 (syms_of_eval): Defsubr it.
674 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
675
d4a8f5c1
JB
6762012-06-08 Juanma Barranquero <lekktu@gmail.com>
677
678 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
679 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
680
8bbbc977
EZ
6812012-06-08 Eli Zaretskii <eliz@gnu.org>
682
683 * alloc.c (allocate_vectorlike): Fix last change.
684
f3372c87
DA
6852012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
686
687 Block-based vector allocation of small vectors.
688 * lisp.h (struct vectorlike_header): New field `nbytes',
689 adjust comment accordingly.
690 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
691 to denote vector blocks. Adjust users (live_vector_p,
692 mark_maybe_pointer, valid_lisp_object_p) accordingly.
693 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
694 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
695 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
696 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
697 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
698 (roundup_size): New constant.
699 (struct vector_block): New data type.
700 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 701 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
702 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
703 (sweep_vectors): New functions.
704 (allocate_vectorlike): Return `zero_vector' as the only vector of
705 0 items. Allocate new vector from block if vector size is less than
706 or equal to VBLOCK_BYTES_MAX.
707 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
708 (init_alloc_once): Add call to init_vectors.
709
4f18a4ed
SM
7102012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
711
712 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
713
86f158bc
PE
7142012-06-07 Paul Eggert <eggert@cs.ucla.edu>
715
716 * doprnt.c (doprnt): Truncate multibyte char correctly.
717 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
718 would mishandle a string argument "Xc" if X was a multibyte
719 character of length 2: it would truncate after X's first byte
720 rather than including all of X.
721
c5cfcbe0
CY
7222012-06-06 Chong Yidong <cyd@gnu.org>
723
724 * buffer.c (word_wrap): Doc fix.
725
c05cf390
PE
7262012-06-04 Paul Eggert <eggert@cs.ucla.edu>
727
728 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
729
0c3461de
GM
7302012-06-03 Glenn Morris <rgm@gnu.org>
731
732 * xdisp.c (tool-bar-style): Doc fix.
733
c71232db
UM
7342012-06-03 Ulrich Müller <ulm@gentoo.org>
735
736 * Makefile.in (PAXCTL): Define.
737 (temacs$(EXEEXT)): Disable memory randomization for the temacs
738 binary via PaX flags if the paxctl utility is available.
739 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
740 Restore PaX flags to their default. (Bug#11398)
741
383f7350
CY
7422012-06-03 Chong Yidong <cyd@gnu.org>
743
744 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
745 buffer (Bug#11226).
746
5f2c76c6
CY
7472012-06-03 Chong Yidong <cyd@gnu.org>
748
749 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
750 (note_mode_line_or_margin_highlight): If there is no help echo,
751 use mode-line-default-help-echo. Handle the case where the mouse
752 position is past the end of the mode line string.
753
754 * buffer.c (buffer_local_value_1): New function, split from
755 Fbuffer_local_value; can return Qunbound.
756 (Fbuffer_local_value): Use it.
757 (Vmode_line_format): Docstring tweaks.
758
773d47f6
PE
7592012-06-02 Paul Eggert <eggert@cs.ucla.edu>
760
761 * sysdep.c (system_process_attributes): Improve comment.
762
f2d6a3df
SM
7632012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
764
765 * keyboard.c: Export real-this-command to Elisp.
766 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
767 and DEFVAR it. Update all users.
768
63810350
PE
7692012-06-02 Paul Eggert <eggert@cs.ucla.edu>
770
7bd5c1f4
PE
771 * minibuf.c (Fassoc_string): Remove duplicate declaration.
772
63810350
PE
773 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
774 Convert pctcpu and pctmem to Lisp float properly.
775 Let the compiler fold better, as 100.0/0x8000 is exact.
776
a2821611
AS
7772012-06-02 Andreas Schwab <schwab@linux-m68k.org>
778
779 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
780 cons_block.
781
5fceba1d
PE
7822012-06-01 Paul Eggert <eggert@cs.ucla.edu>
783
784 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
785
c98ff5dd
DA
7862012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
787
788 For a 'struct window', replace some Lisp_Object fields to
789 bitfields where appropriate, remove unused fields.
790 * window.h (struct window): Remove unused 'last_mark_x' and
791 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
792 change it's type from Lisp_Object to bitfield.
793 Change type of 'force_start', 'optional_new_start',
794 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
795 fields from Lisp_Object to bitfield. Adjust users accordingly.
796
ca34e0be
PE
7972012-05-31 Paul Eggert <eggert@cs.ucla.edu>
798
799 Pacify gcc -Wdouble-precision when using Xaw.
800 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
801 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
802 Use 'float' consistently, rather than 'float' in most places
803 and 'double' in a couple of places.
804
efc00ab1 8052012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
806
807 * xdisp.c (handle_stop): Detect whether we have overlay strings
808 loaded by testing it->current.overlay_string_index to be
809 non-negative, instead of checking whether n_overlay_strings is
810 positive. (Bug#11587)
811
efc00ab1 8122012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
813
814 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
815
816 * doc.c (Fsubstitute_command_keys): Doc fix.
817
efc00ab1 8182012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
819
820 * search.c (search_buffer): Remove calls to
821 r_alloc_inhibit_buffer_relocation, as it is now called by
822 maybe_unify_char, which was the cause of relocation of buffer text
823 in bug#11519.
824
efc00ab1 8252012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
826
827 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
828 for the duration of call to load_charset, to avoid problems with
829 callers of maybe_unify_char that access buffer text through C
830 pointers.
831
832 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
833 decrement the inhibition flag, instead of just setting or
834 resetting it.
835
ba93a187
PE
8362012-05-31 Paul Eggert <eggert@cs.ucla.edu>
837
838 Remove obsolete '#define static' cruft.
839 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
840 This #undef was "temporary" in 2000; it is no longer needed
841 now that '#define static' has gone away.
842 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
843 (gray_bitmap_bits): Remove; no longer needed.
844 All uses replaced with definiens.
845 * xterm.c: Include "bitmaps/gray.xbm".
846
9e4bf381
PE
8472012-05-30 Paul Eggert <eggert@cs.ucla.edu>
848
849 Clean up __executable_start, monstartup when --enable-profiling.
850 The following changes affect the code only when profiling.
851 * dispnew.c (__executable_start): Rename from safe_bcopy.
852 Define only on platforms that need it.
853 * emacs.c: Include <sys/gmon.h> when profiling.
854 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
855 (__executable_start): Remove decl, since lisp.h does it now.
856 (safe_bcopy): Remove decl; no longer has that name.
857 (main): Coalesce #if into single bit of code, for simplicity.
858 Cast pointers to uintptr_t, since standard libraries want integers
859 and not pointers.
860 * lisp.h (__executable_start): New decl.
861
32d72c2f
GM
8622012-05-31 Glenn Morris <rgm@gnu.org>
863
864 * image.c (Fimagemagick_types): Doc fix.
865
baac5bc7
JM
8662012-05-30 Jim Meyering <meyering@redhat.com>
867
868 * callproc.c (Fcall_process_region): Include directory component
869 in mkstemp error message (Bug#11586).
870
72cb32cf
PE
8712012-05-30 Paul Eggert <eggert@cs.ucla.edu>
872
873 * alloc.c, lisp.h (make_pure_vector): Now static.
874
61b108cc
SM
8752012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
876
877 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
878 Move to byte-run.el.
879 (Fautoload): Do the hash-doc more carefully.
880 * data.c (Fdefalias): Purify definition, except for keymaps.
881 (Qdefun): Move from eval.c.
882 * lisp.h (Qdefun): Remove.
883 * lread.c (read1): Tiny simplification.
884
471fe23d
TN
8852012-05-29 Troels Nielsen <bn.troels@gmail.com>
886
934f3f58 887 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
888 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
889 Bug#9642, but explicitly check that the buffer the overlay would
890 be moved to is live and rearrange lines to make sure that errors
891 will not put the overlay in an inconsistent state.
892 (Fdelete_overlay): Cosmetics.
893
85d0efd1
EZ
8942012-05-28 Eli Zaretskii <eliz@gnu.org>
895
896 * w32term.c (my_bring_window_to_top): New function.
897 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
898 could be different from the original one.
899 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
900 (Bug#11513)
901
902 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
903 by calling BringWindowToTop.
904
905 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
906 (WM_EMACS_END): Increase by one.
907
da92a98c
PE
9082012-05-28 Paul Eggert <eggert@cs.ucla.edu>
909
910 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
911 This avoids undefined behavior that might cause the eassert
912 to not catch an out-of-range value.
913
74d1f848
JB
9142012-05-28 Juanma Barranquero <lekktu@gmail.com>
915
916 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
917 Update dependencies.
918
9e1a06fc
EZ
9192012-05-27 Eli Zaretskii <eliz@gnu.org>
920
921 * bidi.c (bidi_mirror_char): Fix last change.
922
f3dd7312
AS
9232012-05-27 Andreas Schwab <schwab@linux-m68k.org>
924
925 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
926 when referring to sectname field in printf format.
927
81899c91
PE
9282012-05-27 Paul Eggert <eggert@cs.ucla.edu>
929
57b81a9f
PE
930 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
931 Only r_alloc_inhibit_buffer_relocation needed to be added;
932 the others were already declared.
933
81899c91
PE
934 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
935 before checking whether it's out of range. Put the check inside
936 eassert. See
937 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
938
33017faf 9392012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
940
941 * callproc.c (Fcall_process): Restore a line that was accidentally
942 commented out in the 2011-02-13 change (bug#11547).
943
33017faf 9442012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
945
946 * lisp.h [REL_ALLOC]: Add prototypes for external functions
947 defined on ralloc.c.
948
949 * buffer.c [REL_ALLOC]: Remove prototypes of
950 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
951 they are now on lisp.h.
952
953 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
954
955 * search.c (search_buffer): Use it to inhibit relocation of buffer
956 text while re_search_2 is doing its job, because re_search_2 is
957 passed C pointers to buffer text. (Bug#11519)
958
23415acf
EZ
959 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
960 Update value to 24.
961
44e27368
EZ
962 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
963 state after an additional call to move_it_in_display_line_to, keep
964 the values of it->max_ascent and it->max_descent found for the
965 entire line.
966 (pos_visible_p): Revert the comparison against bottom_y to what it
967 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
968 (Bug#11464)
969
c1892f11
PE
9702012-05-26 Paul Eggert <eggert@cs.ucla.edu>
971
972 Fix coding-related core dumps with gcc -ftrapv.
973 The code was computing A - B, where A and B are pointers, and B is
974 random garbage. This can lead to core dumps on platforms that
975 have special pointer registers, and it also leads to core dumps on
976 x86-64 when compiled with gcc -ftrapv. The fix is to compute
977 A - B only when B is initialized properly.
978 * coding.c (coding_set_source, coding_set_destination): Return void.
979 (coding_change_source, coding_change_destinations): New functions,
980 with the old behaviors of coding_set_source and coding_set_destination.
981 All callers that need an offset changed to use these new functions.
982
eb7afdad
GM
9832012-05-26 Glenn Morris <rgm@gnu.org>
984
985 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
986
f12fdf02
EZ
9872012-05-26 Eli Zaretskii <eliz@gnu.org>
988
53a63be6 989 Extend mouse support on W32 text-mode console.
61b108cc
SM
990 * xdisp.c (draw_row_with_mouse_face):
991 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 992
eb3f6f01 993 * w32console.c: Include window.h.
61b108cc
SM
994 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
995 New functions.
eb3f6f01
EZ
996 (initialize_w32_display): Initialize mouse-highlight data.
997
53a63be6
EZ
998 * w32inevt.c: Include termchar.h and window.h.
999 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1000 moves, call note_mouse_highlight. If help_echo changed, call
1001 gen_help_event to produce help-echo message in the echo area.
1002 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1003 highlight info.
1004
4cfd81f6
PE
10052012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 * lread.c (read1): Simplify slightly to avoid an overflow warning
1008 with GCC 4.7.0 on x86-64.
1009
4446092a
EZ
10102012-05-26 Eli Zaretskii <eliz@gnu.org>
1011
1012 * bidi.c (bidi_mirror_char): Revert last change: an int is
1013 definitely wide enough here.
1014
42b2a986 10152012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1016
42b2a986 1017 Fix integer width and related bugs (Bug#9874).
eb106a49 1018 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1019 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1020 (string_bytes, check_sblock, allocate_string_data):
1021 (compact_small_strings, Fmake_bool_vector, make_string)
1022 (make_unibyte_string, make_multibyte_string)
1023 (make_string_from_bytes, make_specified_string)
1024 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1025 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1026 (mark_vectorlike):
1027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1028 (allocate_pseudovector):
1029 Use int, not EMACS_INT, where int is wide enough.
1030 (inhibit_garbage_collection, Fgarbage_collect):
1031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1032 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1033 int might not be wide enough.
1034 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1035 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1036 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1037 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1038 (bidi_level_of_next_char, bidi_move_to_visually_next):
1039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1040 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1041 (Fkill_buffer, Fset_buffer_major_mode)
1042 (advance_to_char_boundary, Fbuffer_swap_text)
1043 (Fset_buffer_multibyte, overlays_at, overlays_in)
1044 (overlay_touches_p, struct sortvec, record_overlay_string)
1045 (overlay_strings, recenter_overlay_lists)
1046 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1047 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1048 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1049 (Foverlay_recenter, last_overlay_modification_hooks_used)
1050 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1052 (validate_region): Omit unnecessary test for b <= e,
1053 since that's guaranteed by the previous test.
d311d28c
PE
1054 (adjust_overlays_for_delete): Avoid pos + length overflow.
1055 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1056 (report_overlay_modification):
1057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1058 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1059 Omit pointer cast, which isn't needed anyway, and doesn't work
1060 after the EMACS_INT -> ptrdiff_t change.
02481186 1061 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1062 * buffer.h: Adjust decls to match defn changes elsewhere.
1063 (struct buffer_text, struct buffer):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1065 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1066 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1067 not int, to avoid needless 32-bit limit on 64-bit hosts.
1068 (exec_byte_code): Use tighter memory-full test, one that checks
1069 for alloca overflow. Don't compute the address of the object just
1070 before an array, as that's not portable. Use EMACS_INT, not
1071 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1072 * callint.c (Fcall_interactively):
1073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1074 * callproc.c (call_process_kill, Fcall_process):
1075 Don't assume pid_t fits into an Emacs fixnum.
1076 (call_process_cleanup, Fcall_process, child_setup):
1077 Don't assume pid_t fits into int.
1078 (call_process_cleanup, Fcall_process, delete_temp_file)
1079 (Fcall_process_region):
1080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1081 (Fcall_process): Simplify handling of volatile integers.
1082 Use int, not EMACS_INT, where int will do.
1083 * casefiddle.c (casify_object, casify_region, operate_on_word)
1084 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1086 (casify_object): Avoid integer overflow when overallocating buffer.
1087 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1088 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1089 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1090 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1091 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1092 integers are now checked earlier. All uses replaced with XINT.
1093 (ccl_driver):
1094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1095 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1096 (ccl_driver, Fregister_code_conversion_map):
1097 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1098 (resolve_symbol_ccl_program): Check that vector header is in range.
1099 Always copy the vector, so that we can check its contents reliably
1100 now rather than having to recheck each instruction as it's being
1101 executed. Check that vector words fit in 'int'.
1102 (ccl_get_compiled_code, Fregister_ccl_program)
1103 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1104 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1105 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1106 contents are in range.
1107 (Fccl_execute_on_string): Check that status is in range.
1108 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1109 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1110 Accept and return EMACS_INT, not int, because callers can pass values
1111 out of 'int' range.
1112 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1113 (multibyte_chars_in_text, parse_str_as_multibyte)
1114 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1115 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1116 (string_escape_byte8, Fget_byte):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1118 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1119 avoid mishandling large integers.
1120 * character.h: Adjust decls to match defn changes elsewhere.
1121 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1122 (Ffind_charset_region):
1123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1124 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1125 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1126 Don't assume fixnum fits in int.
d311d28c
PE
1127 (load_charset_map_from_vector, Fmap_charset_chars):
1128 Remove now-unnecessary CHECK_NATNUMs.
1129 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1130 Don't rely on undefined behavior with signed left shift overflow.
1131 Don't assume unsigned int fits into fixnum, or that fixnum fits
1132 into unsigned int. Don't require max_code to be a valid fixnum;
1133 that's not true for gb10830 4-byte on a 32-bit host. Allow
1134 invalid_code to be a cons, for the same reason. Require code_offset
1135 to be a character. Avoid int overflow if max_char is close
1136 to INT_MAX.
1137 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1138 this is intended anyway and avoids some undefined behavior.
1139 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1140 INDEX_TO_CODE_POINT, as that's what it expects.
1141 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1142 * charset.h (DECODE_CHAR): Return int, not unsigned;
1143 this is what was intended anyway, and it avoids undefined behavior.
1144 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1145 integer-overflow issues.
1146 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1147 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1148 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1149 * chartab.c (Fmake_char_table, Fset_char_table_range)
1150 (uniprop_get_decoder, uniprop_get_encoder):
1151 Don't assume fixnum fits in int.
1152 * cmds.c (move_point): New function, that does the gist of
1153 Fforward_char and Fbackward_char, but does so while checking
1154 for integer overflow more accurately.
c96e5d6a 1155 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1156 (Fforward_line, Fend_of_line, internal_self_insert)
1157 (internal_self_insert):
1158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1159 Fix a FIXME, by checking for integer overflow when calculating
1160 target_clm and actual_clm.
1161 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1162 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1163 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1164 (coding_alloc_by_making_gap, alloc_destination)
1165 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1166 (encode_coding_utf_16, detect_coding_emacs_mule)
1167 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1168 (detect_coding_iso_2022, decode_coding_iso_2022)
1169 (encode_invocation_designation, encode_designation_at_bol)
1170 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1171 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1172 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1173 (encode_coding_ccl, encode_coding_raw_text)
1174 (detect_coding_charset, decode_coding_charset)
1175 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1176 (produce_composition, produce_charset, produce_annotation)
1177 (decode_coding, handle_composition_annotation)
1178 (handle_charset_annotation, consume_chars, decode_coding_gap)
1179 (decode_coding_object, encode_coding_object, detect_coding_system)
1180 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1181 (code_convert_region, code_convert_string)
8f50130c
PE
1182 (Fdefine_coding_system_internal)
1183 (coding_set_source, coding_set_destination):
d311d28c
PE
1184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1185 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1186 (Fdefine_coding_system_internal):
1187 Don't assume fixnums fit in int.
1188 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1189 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1190 (Funencodable_char_position, Fcheck_coding_systems_region)
1191 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1193 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1194 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1195 Don't access memory outside of the args array.
d311d28c 1196 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1197 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1198 result of ENCODE_CHAR.
d311d28c
PE
1199 * coding.h: Adjust decls to match defn changes elsewhere.
1200 (struct coding_system):
1201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1202 * composite.c (get_composition_id, find_composition)
1203 (run_composition_function, update_compositions)
1204 (compose_text, composition_gstring_put_cache)
1205 (composition_gstring_p, composition_gstring_width)
1206 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1207 (composition_compute_stop_pos, composition_reseat_it)
1208 (composition_update_it, struct position_record)
1209 (find_automatic_composition, composition_adjust_point)
1210 (Fcomposition_get_gstring, Ffind_composition_internal):
1211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1212 (update_compositions):
1213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1214 * composite.h: Adjust decls to match defn changes elsewhere.
1215 (struct composition):
1216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1217 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1218 Do not attempt to compute the address of the object just before a
1219 buffer; this is not portable.
1220 (Faref, Faset):
1221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1222 (Faset): Use int, not EMACS_INT, where int is wide enough.
1223 (Fstring_to_number): Don't assume fixnums fit in int.
1224 (Frem): Don't assume arg is nonnegative.
1225 * dbusbind.c (xd_append_arg): Check for integers out of range.
1226 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1227 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1228 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1229 (xd_get_connection_references): Return ptrdiff_t, not int.
1230 All uses changed.
1231 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1232 (xd_read_message_1):
1233 Use int, not unsigned, where the dbus API uses int.
1234 (Fdbus_message_internal): Don't overflow mtype.
1235 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1236 * dired.c (directory_files_internal, file_name_completion, scmp)
1237 (file_name_completion_stat):
1238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1239 (file_name_completion): Don't overflow matchcount.
1240 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1241 * dispextern.h: Adjust decls to match defn changes elsewhere.
1242 (struct text_pos, struct glyph, struct bidi_saved_info)
1243 (struct bidi_string_data, struct bidi_it, struct composition_it)
1244 (struct it):
1245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1246 (struct display_pos, struct composition_it, struct it):
1247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1248 * dispnew.c (increment_matrix_positions)
1249 (increment_row_positions, mode_line_string)
1250 (marginal_area_string):
1251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1252 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1254 (duration_to_sec_usec): New function, to check for overflow better.
1255 (Fsleep_for, sit_for): Use it.
1256 * doc.c (get_doc_string, store_function_docstring):
1257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1258 (get_doc_string, Fsnarf_documentation):
1259 Use int, not EMACS_INT, where int is wide enough.
1260 (get_doc_string):
1261 Use SAFE_ALLOCA, not alloca.
1262 Check for overflow when converting EMACS_INT to off_t.
1263 * doprnt.c (doprnt):
1264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1265 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1266 Don't assume uid_t fits into fixnum.
1267 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1268 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1269 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1270 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1271 (general_insert_function)
1272 (Finsert_char, make_buffer_string, make_buffer_string_both)
1273 (update_buffer_properties, Fbuffer_substring)
1274 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1275 (Fsubst_char_in_region, check_translation)
1276 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1277 (transpose_markers, Ftranspose_regions):
1278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1279 (clip_to_bounds): Move to lisp.h as an inline function).
1280 (Fconstrain_to_field): Don't assume integers are nonnegative.
1281 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1282 (Fsubst_char_in_region, Fsave_restriction):
1283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1284 (Femacs_pid): Don't assume pid_t fits into fixnum.
1285 (lo_time): Use int, not EMACS_INT, when int suffices.
1286 (lisp_time_argument): Check for usec out of range.
1287 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1288 (Fuser_login_name, Fuser_full_name): Signal an error
1289 if a uid argument is out of range, rather than relying on
1290 undefined behavior.
c8d5c857
PE
1291 (Fformat_time_string): Remove now-unnecessary check.
1292 lisp_time_argument checks for out-of-range usec now.
243e0530 1293 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1294 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1295 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1296 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1297 (init_cmdargs, Fdump_emacs):
1298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1299 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1300 the bottom (typically) 32 bits of the fixnum.
1301 * eval.c (specpdl_size, call_debugger):
1302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1303 (when_entered_debugger, Fbacktrace_debug):
1304 Don't assume fixnum can fit in int.
1305 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1306 the object just before a buffer; this is not portable.
1307 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1308 (grow_specpdl, unbind_to):
1309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1310 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1311 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1312 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1313 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1314 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1316 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1317 (a_write, e_write):
1318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1319 (Fcopy_file, non_regular_nbytes, read_non_regular)
1320 (Finsert_file_contents):
1321 Use int, not EMACS_INT, where int is wide enough.
1322 (READ_BUF_SIZE): Verify that it fits in int.
1323 (Finsert_file_contents): Check that counts are in proper range,
1324 rather than assuming fixnums fit into ptrdiff_t etc.
1325 Don't assume fixnums fit into int.
125b3835 1326 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1327 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1328 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1329 (string_char_to_byte, string_byte_to_char)
1330 (string_make_multibyte, string_to_multibyte)
1331 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1332 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1333 (substring_both, Fdelete, internal_equal, Ffillarray)
1334 (Fclear_string, mapcar1)
1335 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1336 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1337 (larger_vector, make_hash_table, maybe_resize_hash_table)
1338 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1339 (Fmaphash, secure_hash):
1340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1341 (concat): Check for string index and length overflow.
1342 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1343 (Frequire):
1344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1345 (larger_vector): New API (vec, incr_min, size_max) replaces old
1346 one (vec, new_size, init). This catches size overflow.
1347 INIT was removed because it was always Qnil.
1348 All callers changed.
1349 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1350 the upper bound on a hash table index size.
1351 (make_hash_table, maybe_resize_hash_table): Use it.
1352 (secure_hash): Computer start_byte and end_byte only after
1353 they're known to be in ptrdiff_t range.
1354 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1355 (Ffont_get_glyphs, Ffont_at):
1356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1357 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1358 (Flist_fonts, Fopen_font):
1359 Don't assume fixnum can fit in int.
1360 (check_gstring): Don't assume index can fit in int.
1361 (font_match_p): Check that fixnum is a character, not a nonnegative
1362 fixnum, since the later code needs to stuff it into an int.
1363 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1364 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1365 conversion overflow issues.
1366 (Fopen_font): Check for integer out of range.
1367 (Ffont_get_glyphs): Don't assume index can fit in int.
1368 * font.h: Adjust decls to match defn changes elsewhere.
1369 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1370 integer overflow.
1371 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1372 printmax_t, where ptrdiff_t is wide enough.
1373 (Finternal_char_font):
1374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1375 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1376 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1377 (Fset_frame_position, x_set_frame_parameters)
1378 (x_set_line_spacing, x_set_border_width)
1379 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1380 Check that fixnums are in proper range for system types.
1381 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1383 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1384 Use SAFE_ALLOCA_LISP, not alloca.
1385 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1386 intptr_t is wide enough.
1387 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1388 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1389 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1390 Check for fixnum out of range.
1391 * ftfont.c (ftfont_list): Don't assume index fits in int.
1392 Check that fixnums are in proper range for system types.
1393 (ftfont_shape_by_flt):
1394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1395 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1397 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1398 Check that fixnums are in proper range for system types.
1399 * gnutls.h: Adjust decls to match defn changes elsewhere.
1400 * gtkutil.c (xg_dialog_run):
1401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1402 (update_frame_tool_bar):
1403 Check that fixnums are in proper range for system types.
1404 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1405 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1406 * indent.c (last_known_column, last_known_column_point):
1407 (current_column_bol_cache):
1408 (skip_invisible, current_column, check_display_width):
1409 (check_display_width, scan_for_column, current_column_1)
1410 (Findent_to, Fcurrent_indentation, position_indentation)
1411 (indented_beyond_p, Fmove_to_column, compute_motion):
1412 (Fcompute_motion, Fvertical_motion):
1413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1414 (last_known_column_modified): Use EMACS_INT, not int.
1415 (check_display_width):
1416 (Fcompute_motion):
1417 Check that fixnums and floats are in proper range for system types.
1418 (compute_motion): Don't assume index or fixnum fits in int.
1419 (compute_motion, Fcompute_motion):
1420 Use int, not EMACS_INT, when it is wide enough.
1421 (vmotion): Omit local var start_hpos that is always 0; that way
1422 we don't need to worry about overflow in expressions involving it.
1423 * indent.h: Adjust decls to match defn changes elsewhere.
1424 (struct position):
1425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1426 Use int, not EMACS_INT, where int is wide enough.
1427 Remove unused members ovstring_chars_done and tab_offset;
1428 all uses removed.
1429 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1430 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1431 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1432 (make_gap, copy_text, insert, insert_and_inherit)
1433 (insert_before_markers, insert_before_markers_and_inherit)
1434 (insert_1, count_combining_before, count_combining_after)
1435 (insert_1_both, insert_from_string)
1436 (insert_from_string_before_markers, insert_from_string_1)
1437 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1438 (adjust_after_replace, adjust_after_insert, replace_range)
1439 (replace_range_2, del_range, del_range_1, del_range_byte)
1440 (del_range_both, del_range_2, modify_region)
1441 (prepare_to_modify_buffer, signal_before_change)
1442 (signal_after_change, Fcombine_after_change_execute):
1443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1444 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1445 (balance_an_interval, split_interval_right, split_interval_left)
1446 (find_interval, next_interval, update_interval)
1447 (adjust_intervals_for_insertion, delete_node, delete_interval)
1448 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1449 (static_offset_intervals, offset_intervals)
1450 (merge_interval_right, merge_interval_left, make_new_interval)
1451 (graft_intervals_into_buffer, temp_set_point_both)
1452 (temp_set_point, set_point, adjust_for_invis_intang)
1453 (set_point_both, move_if_not_intangible, get_property_and_range)
1454 (get_local_map, copy_intervals, copy_intervals_to_string)
1455 (compare_string_intervals, set_intervals_multibyte_1):
1456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1457 * intervals.h: Adjust decls to match defn changes elsewhere.
1458 (struct interval):
1459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1460 * keyboard.c (this_command_key_count, this_single_command_key_start)
1461 (before_command_key_count, before_command_echo_length, echo_now)
1462 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1463 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1464 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1465 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1467 (last_non_minibuf_size, last_point_position, echo_truncate)
1468 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1469 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1470 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1471 (stuff_buffered_input):
1472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1473 (last_auto_save, command_loop_1, read_char):
1474 Use EMACS_INT, not int, to avoid integer overflow.
1475 (record_char): Avoid overflow in total_keys computation.
1476 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1477 * keyboard.h: Adjust decls to match defn changes elsewhere.
1478 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1479 (Fkey_description, Fdescribe_vector, Flookup_key):
1480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1481 (click_position): New function, to check that positions are in range.
1482 (Fcurrent_active_maps):
1483 (describe_command):
1484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1485 (Faccessible_keymaps, Fkey_description):
1486 (preferred_sequence_p):
1487 Don't assume fixnum can fit into int.
1488 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1489 Check for integer overflow in size calculations.
1490 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1491 avoid mishandling large integers.
1492 * lisp.h: Adjust decls to match defn changes elsewhere.
1493 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1494 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1495 (struct Lisp_Marker):
1496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1497 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1498 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1499 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1500 All callers changed.
1501 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1502 Assume the arg has valid form, since it always does.
1503 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1504 unsigned integer system type.
1505 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1506 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1508 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1509 (duration_to_sec_usec): New decl.
1510 * lread.c (read_from_string_index, read_from_string_index_byte)
1511 (read_from_string_limit, readchar, unreadchar, openp)
1512 (read_internal_start, read1, oblookup):
1513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1514 (Fload, readevalloop, Feval_buffer, Feval_region):
1515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1516 (openp): Check for out-of-range argument to 'access'.
1517 (read1): Use int, not EMACS_INT, where int is wide enough.
1518 Don't assume fixnum fits into int.
6efdadfd 1519 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1520 (read_filtered_event): Use duration_to_sec_usec
1521 to do proper overflow checking on durations.
d311d28c
PE
1522 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1523 in size calculation.
1524 (Fexecute_kbd_macro):
1525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1526 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1527 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1528 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1529 (set_marker_both, set_marker_restricted_both, marker_position)
1530 (marker_byte_position, Fbuffer_has_markers_at):
1531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1532 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1533 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1534 It now merely ensures that the menu is large enough, without
1535 necessarily growing it, as this avoids some integer overflow issues.
1536 All callers changed.
1537 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1539 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1540 Use SAFE_ALLOCA_LISP, not alloca.
1541 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1542 to EMACS_INT. Check that fixnums are in proper range for system types.
1543 * minibuf.c (minibuf_prompt_width, string_to_object)
1544 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1545 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1547 (get_minibuffer, read_minibuf_unwind):
1548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1549 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1550 this simplifies overflow checking. All callers changed.
1551 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1552 (Ftest_completion):
1553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1554 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1555 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1556 Check that fixnums are in proper range for system types.
1557 (Fx_create_frame, Fx_show_tip):
1558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1559 * nsfont.m (ns_findfonts, nsfont_list_family):
1560 Don't assume fixnum fits in long.
1561 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1563 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1564 wide enough.
17fdb222 1565 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1567 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1568 (PRINTDECLARE, PRINTPREPARE):
1569 (strout, print_string):
1570 (print, print_preprocess, print_check_string_charset_prop)
1571 (print_object):
1572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1573 (PRINTDECLARE):
1574 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1576 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1577 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1578 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1579 (print_error_message): Use SAFE_ALLOCA, not alloca.
1580 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1581 (print_depth, new_backquote_output, print_number_index):
1582 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1583 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1584 (Fset_process_window_size, Fformat_network_address)
1585 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1586 (sigchld_handler):
d311d28c 1587 Check that fixnums are in proper range for system types.
d44287d4 1588 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1589 Check for process-ids out of pid_t range rather than relying on
1590 undefined behavior.
e4d81efc 1591 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1592 (Fformat_network_address, read_process_output, send_process)
1593 (Fprocess_send_region, status_notify):
1594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1595 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1596 (wait_reading_process_output, read_process_output, exec_sentinel):
1597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1598 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1599 (Faccept_process_output): Use duration_to_sec_usec to do proper
1600 overflow checking on durations.
dde14581
PE
1601 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1602 Don't assume pid_t fits in int.
02481186
PE
1603 * process.h (struct Lisp_Process): Members tick and update_tick
1604 are now of type EMACS_INT, not int.
b62b53e8
PE
1605 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1606 configured --with-wide-int.
d311d28c
PE
1607 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1608 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1609 * search.c (looking_at_1, string_match_1):
1610 (fast_string_match, fast_c_string_match_ignore_case)
1611 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1612 (scan_newline, find_before_next_newline, search_command)
1613 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1614 (set_search_regs, wordify):
1615 (Freplace_match):
1616 (Fmatch_data):
1617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1618 (string_match_1, search_buffer, set_search_regs):
1619 (Fmatch_data):
1620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1621 (wordify): Check for overflow in size calculation.
1622 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1623 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1624 Check that fixnums are in proper range for system types.
1625 * sound.c (struct sound_device)
1626 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1628 (Fplay_sound_internal):
1629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1630 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1631 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1632 (Fparse_partial_sexp):
1633 Don't assume fixnums can fit in int.
1634 (struct lisp_parse_state, find_start_pos, find_start_value)
1635 (find_start_value_byte, find_start_begv)
1636 (update_syntax_table, char_quoted, dec_bytepos)
1637 (find_defun_start, prev_char_comend_first, back_comment):
1638 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1639 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1641 (Finternal_describe_syntax_value): Check that match_lisp is a
1642 character, not an integer, since the code stuffs it into int.
1643 (scan_words, scan_sexps_forward):
1644 Check that fixnums are in proper range for system types.
1645 (Fforward_word):
1646 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1647 (scan_sexps_forward):
1648 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1649 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1650 * syntax.h: Adjust decls to match defn changes elsewhere.
1651 (struct gl_state_s):
1652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1653 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1654 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1655 * sysdep.c (wait_for_termination_1, wait_for_termination)
1656 (interruptible_wait_for_termination, mkdir):
1657 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1658 (emacs_read, emacs_write):
1659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1660 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1661 and double all fit in int.
d311d28c
PE
1662 * term.c (set_tty_color_mode):
1663 Check that fixnums are in proper range for system types.
1664 * termhooks.h (struct input_event):
1665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1666 * textprop.c (validate_interval_range, interval_of)
1667 (Fadd_text_properties, set_text_properties_1)
1668 (Fremove_text_properties, Fremove_list_of_text_properties)
1669 (Ftext_property_any, Ftext_property_not_all)
1670 (copy_text_properties, text_property_list, extend_property_ranges)
1671 (verify_interval_modification):
1672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1673 (Fnext_single_char_property_change)
1674 (Fprevious_single_char_property_change):
1675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1676 (copy_text_properties):
1677 Check for integer overflow in index calculation.
d311d28c
PE
1678 * undo.c (last_boundary_position, record_point, record_insert)
1679 (record_delete, record_marker_adjustment, record_change)
1680 (record_property_change):
1681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1682 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1684 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1685 (Fx_hide_tip, Fx_file_dialog):
1686 * w32menu.c (set_frame_menubar):
1687 Use ptrdiff_t, not int, for consistency with rest of code.
1688 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1689 (select_window, Fdelete_other_windows_internal)
1690 (window_scroll_pixel_based, window_scroll_line_based)
1691 (Frecenter, Fset_window_configuration):
1692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1693 (Fset_window_hscroll, run_window_configuration_change_hook)
1694 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1695 (Fscroll_other_window, Frecenter):
d311d28c
PE
1696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1697 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1698 Don't assume fixnum fits in int.
1699 (Fset_window_scroll_bars):
1700 Check that fixnums are in proper range for system types.
1701 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1702 (string_pos, c_string_pos, number_of_chars, init_iterator)
1703 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1704 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1705 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1706 (face_before_or_after_it_pos, handle_invisible_prop)
1707 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1708 (display_prop_intangible_p, string_buffer_position_lim)
1709 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1710 (get_overlay_strings_1, get_overlay_strings)
1711 (iterate_out_of_display_property, forward_to_next_line_start)
1712 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1713 (get_next_display_element, set_iterator_to_next)
1714 (get_visually_first_element, compute_stop_pos_backwards)
1715 (handle_stop_backwards, next_element_from_buffer)
1716 (move_it_in_display_line_to, move_it_in_display_line)
1717 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1718 (add_to_log, message_dolog, message_log_check_duplicate)
1719 (message2, message2_nolog, message3, message3_nolog
1720 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1721 (current_message_1, truncate_echo_area, truncate_message_1)
1722 (set_message, set_message_1, store_mode_line_noprop)
1723 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1724 (text_outside_line_unchanged_p, check_point_in_composition)
1725 (reconsider_clip_changes)
1726 (redisplay_internal, set_cursor_from_row, try_scrolling)
1727 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1728 (redisplay_window, find_last_unchanged_at_beg_row)
1729 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1730 (trailing_whitespace_p, find_row_edges, display_line)
1731 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1732 (display_mode_element, store_mode_line_string)
1733 (pint2str, pint2hrstr, decode_mode_spec)
1734 (display_count_lines, display_string, draw_glyphs)
1735 (x_produce_glyphs, x_insert_glyphs)
1736 (rows_from_pos_range, mouse_face_from_buffer_pos)
1737 (fast_find_string_pos, mouse_face_from_string_pos)
1738 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1740 (safe_call, init_from_display_pos, handle_fontified_prop)
1741 (handle_single_display_spec, load_overlay_strings)
1742 (with_echo_area_buffer, setup_echo_area_for_printing)
1743 (display_echo_area, echo_area_display)
1744 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1745 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1746 (redisplay_window, dump_glyph_row, display_mode_line)
1747 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1748 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1750 (handle_single_display_spec, build_desired_tool_bar_string)
1751 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1752 (get_specified_cursor_type):
1753 Check that fixnums are in proper range for system types.
1754 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1755 (Flookup_image_map):
1756 Don't assume fixnums fit in int.
1757 (compare_overlay_entries):
1758 Avoid mishandling comparisons due to subtraction overflow.
1759 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1760 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1761 (handle_tool_bar_click):
1762 Use int, not unsigned, since we prefer signed and the signedness
1763 doesn't matter here.
1764 (get_next_display_element, next_element_from_display_vector):
1765 Use int, not EMACS_INT, when int is wide enough.
1766 (start_hourglass): Use duration_to_sec_usec to do proper
1767 overflow checking on durations.
1768 * xfaces.c (Fbitmap_spec_p):
1769 Check that fixnums are in proper range for system types.
1770 (compare_fonts_by_sort_order):
1771 Avoid mishandling comparisons due to subtraction overflow.
1772 (Fx_family_fonts, realize_basic_faces):
1773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1774 (Fx_family_fonts):
1775 Don't assume fixnum fits in int.
1776 Use SAFE_ALLOCA_LISP, not alloca.
1777 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1778 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1779 (face_at_buffer_position, face_for_overlay_string)
1780 (face_at_string_position):
1781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1782 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1783 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1784 (Fx_show_tip):
1785 Check that fixnums are in proper range for system types.
1786 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1787 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1789 (Fx_change_window_property): Don't assume fixnums fit in int.
1790 * xfont.c (xfont_chars_supported):
1791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1792 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1793 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1795 * xml.c (parse_region):
1796 * xrdb.c (magic_file_p):
1797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1798 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1799 (x_get_local_selection, x_reply_selection_request)
1800 (x_handle_selection_request, wait_for_property_change):
1801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1802 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1803 short is wide enough.
1804 (x_send_client_event): Don't assume fixnum fits in int.
1805 * xterm.c (x_x_to_emacs_modifiers):
1806 Don't assume EMACS_INT overflows nicely into int.
1807 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1808 may come from Lisp.
1809 (handle_one_xevent): NATNUMP can eval its arg twice.
1810 (x_connection_closed):
1811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1812 * xterm.h: Adjust decls to match defn changes elsewhere.
1813 (struct scroll_bar): Use struct vectorlike_header
1814 rather than rolling our own approximation.
1815 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1816
c6574eb5
GM
18172012-05-25 Glenn Morris <rgm@gnu.org>
1818
1819 * lisp.mk (lisp): Update for more files being compiled now.
1820
e8d32c7e
SM
18212012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1822
48def666
SM
1823 * lread.c: Remove `read_pure' which makes no difference.
1824 (read_pure): Remove var.
1825 (unreadpure): Remove function.
1826 (readevalloop): Don't call read_list with -1 flag.
1827 (read1, read_vector): Don't test read_pure any more.
1828 (read_list): Simplify.
1829
e8d32c7e
SM
1830 * fileio.c, character.h: Minor style tweaks.
1831
4b2addb7
DA
18322012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1833
1834 * window.h (clip_changed): Remove useless declaration.
1835
584461b2
JB
18362012-05-22 Juanma Barranquero <lekktu@gmail.com>
1837
1838 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1839 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1840
34374650
PE
18412012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 Remove src/m/*.
1844 This directory predates autoconf and is no longer needed nowadays.
1845 Move its few remaining bits of functionality to where they're needed.
1846 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1847 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1848 * m/template.h: Remove.
1849 * Makefile.in (M_FILE): Remove. All uses removed.
1850 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1851 * lisp.h (USE_LSB_TAG):
1852 * mem-limits.h (EXCEEDS_LISP_PTR):
1853 Use VAL_MAX, not VALBITS, in #if.
1854 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1855 (EMACS_UINT): Define unconditionally now.
1856 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1857 (BITS_PER_EMACS_INT): New constants, replacing
1858 what used to be in config.h, but not useful in #if.
1859 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1860 define them any more.
1861 (VAL_MAX): New macro.
1862 (VALMASK): Use it.
1863 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1864 BITS_PER_EMACS_INT, in #if.
1865 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1866 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1867 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1868 * s/ms-w32.h (DATA_START):
1869 Move here from removed file m/intel386.h.
1870 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1871 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1872
261cb4bb
PE
18732012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 Assume C89 or later.
1876 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1877 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1878 (xrealloc):
1879 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1880 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1881 * textprop.c, tparam.c (NULL): Remove.
1882 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1883 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1884 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1885 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1886 * xterm.c (input_signal_count): Assume volatile works.
1887
ff23cd9f
KB
18882012-05-21 Ken Brown <kbrown@cornell.edu>
1889
1890 * xgselect.c (xg_select): Fix first argument in call to 'select'
1891 (bug#11508).
1892
1b170bc6
KB
18932012-05-20 Ken Brown <kbrown@cornell.edu>
1894
1895 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1896 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1897
b2f4d39f
KB
18982012-05-19 Ken Brown <kbrown@cornell.edu>
1899
1900 * xfns.c (x_in_use): Remove `static' qualifier.
1901 * xterm.h (x_in_use): Declare.
1902 * xgselect.c: Include xterm.h.
1903 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1904 and `display_arg' (bug#9754).
1905
003fdae2
PE
19062012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1907
9232a6d9
PE
1908 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1909
003fdae2
PE
1910 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1911 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1912
784b56e2
EZ
19132012-05-18 Eli Zaretskii <eliz@gnu.org>
1914
1915 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1916
1917 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1918 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1919
1920 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1921 reference to image_cache->refcount.
1922 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1923
a0a79cde
JL
19242012-05-17 Juri Linkov <juri@jurta.org>
1925
1926 * search.c (Fword_search_regexp, Fword_search_backward)
1927 (Fword_search_forward, Fword_search_backward_lax)
1928 (Fword_search_forward_lax): Move functions to isearch.el
1929 (bug#10145, bug#11381).
1930
b0572523
PE
19312012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1934
9660f5fc
SM
19352012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1936
1937 * lread.c (init_obarray): Declare Qt and Qnil as special.
1938
4374de83
GM
19392012-05-14 Glenn Morris <rgm@gnu.org>
1940
1941 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1942 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1943
dc44c39a
PE
19442012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1945
078c97cb
PE
1946 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1947
dc44c39a
PE
1948 * unexaix.c: Port to more-recent AIX compilers.
1949 (report_error, report_error_1, make_hdr, copy_sym)
1950 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1951 Make arguments const char *, not char *, to avoid violations of C
1952 standard and to fix some AIX warnings reported by Gilles Pion.
1953
e18afed7 19542012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1955
1956 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1957 already have overlays loaded.
1958 (handle_single_display_spec): Before returning without displaying
1959 fringe bitmap, synchronize the bidi iterator with the main display
1960 iterator, by calling iterate_out_of_display_property.
1961 (iterate_out_of_display_property): Detect buffer iteration by
1962 testing that it->string is a Lisp string.
1963 (get_next_display_element): When the current object is exhausted,
1964 and there's something on it->stack, call set_iterator_to_next to
1965 proceed with what's on the stack, instead of returning zero.
1966 (set_iterator_to_next): If called at the end of a Lisp string,
1967 proceed to consider_string_end without incrementing string
1968 position. Don't increment display vector index past the end of
1969 the display vector. (Bug#11417)
c8fb9dc6
EZ
1970 (pos_visible_p): Don't report a position visible when move_it_to
1971 stopped at the last line of window, which happens to be scanned
1972 backwards by the bidi iteration. (Bug#11464)
ac268e67 1973
e18afed7 19742012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1975
1976 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1977 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1978 are on a TTY, and thus unable to display on the fringes.
1979 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1980 so we need to signal to the caller that this is a "replacing"
1981 display spec. This fixes display when the spec is invalid or we
1982 are on a TTY.
1983
e18afed7 19842012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1985
1986 * unexaix.c (make_hdr): Fix typo in prototype.
1987 This bug broke the build on AIX. Problem reported by Gilles Pion.
1988
9d0a235a
MA
19892012-05-14 Michael Albinus <michael.albinus@gmx.de>
1990
1991 * keyboard.c (kbd_buffer_get_event): Read special events also in
1992 batch mode. (Bug#11415)
1993
9e6b06ed
GM
19942012-05-12 Glenn Morris <rgm@gnu.org>
1995
1996 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1997
c1a1d7a3
EZ
19982012-05-12 Eli Zaretskii <eliz@gnu.org>
1999
2000 * lisp.mk (lisp): Add newcomment.elc.
2001
3fe7cdc8
GM
20022012-05-12 Glenn Morris <rgm@gnu.org>
2003
2004 * Makefile.in (MKDIR_P): New, set by configure.
2005 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2006
53f7d2c0
PE
20072012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 Remove unused function hourglass_started.
2010 * dispextern.h (hourglass_started):
2011 * w32fns.c (hourglass_started):
2012 * xdisp.c (hourglass_started): Remove.
2013
75aafb17
JB
20142012-05-10 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2017 Update dependencies.
2018
12959e8e
PE
20192012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2020
97107e2e
PE
2021 * xgselect.c (xg_select): Put maxfds+1 into a var.
2022 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2023
12959e8e
PE
2024 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2025
836d29b3
DA
20262012-05-10 Dave Abrahams <dave@boostpro.com>
2027
2028 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2029 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2030
5cb67954
MA
20312012-05-09 Michael Albinus <michael.albinus@gmx.de>
2032
2033 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2034 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2035 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2036 Initialize xd_registered_buses.
2037
3478ec45
PE
20382012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2039
b263a6b0
PE
2040 Untag more efficiently if USE_LSB_TAG.
2041 This is based on a proposal by YAMAMOTO Mitsuharu in
2042 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2043 For an admittedly artificial (nth 8000 longlist) benchmark on
2044 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2045 Emacs's overall text size by 1%.
2046 * lisp.h (XUNTAG): New macro.
2047 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2048 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2049 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2050 * eval.c (Fautoload):
2051 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2052 * frame.h (XFRAME): Use XUNTAG.
2053
3478ec45
PE
2054 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2055 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2056 Remove unportable assumptions about print widths of types like
2057 dbus_uint32_t.
2058 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2059 intptr_t when converting between pointer and integer, to avoid GCC
2060 warnings about wrong width.
2061
666b903b 20622012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2063
2064 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2065 stack for each reader_thread, instead of defaulting to 8MB
2066 determined by the linker. This avoids failures in creating
2067 subprocesses on Windows 7, see the discussion in this thread:
2068 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2069
b120cc17
JC
20702012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2071
2072 Fix up display of the *Minibuf-0* buffer in the mini window.
2073 * keyboard.c (read_char): Don't clear the echo area if there's no
2074 message to clear.
2075 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2076 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2077
9a4b36f8
MA
20782012-05-07 Michael Albinus <michael.albinus@gmx.de>
2079
2080 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2081 batch mode.
2082
e5f9458f
CY
20832012-05-06 Chong Yidong <cyd@gnu.org>
2084
2085 * lisp.mk (lisp): Update.
2086
eceeb5fc 20872012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2088
2089 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2090
71873e2b
SM
20912012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2092
2093 * data.c (PUT_ERROR): New macro.
2094 (syms_of_data): Use it. Add new error type `user-error'.
2095 * undo.c (user_error): New function.
2096 (Fprimitive_undo): Use it.
2097 * print.c (print_error_message): Adjust print style for `user-error'.
2098 * keyboard.c (user_error): New function.
2099 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2100
ab0fa4e4
PE
21012012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2102
2103 Do not limit current-time-string to years 1000..9999.
2104 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2105 (Fcurrent_time_string): Support any year that is supported by the
2106 underlying localtime representation. Don't use asctime, as it
2107 has undefined behavior for years outside the range -999..9999.
2108
7ed806a7
PE
21092012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2110
2111 Fix race conditions involving setenv, gmtime, localtime, asctime.
2112 Without this fix, interrupts could mess up code that uses these
2113 nonreentrant functions, since setting TZ invalidates existing
2114 tm_zone or tzname values, and since most of these functions return
2115 pointers to static storage.
2116 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2117 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2118 Grow the critical sections to include not just invoking
2119 localtime/gmtime, but also accessing these functions' results
2120 including their tm_zone values if any, and any related TZ setting.
2121 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2122 so that the struct tm is saved in the critical section.
2123 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2124 motivated by the fact that memory allocation needs to be outside
2125 the critical section.
2126
0c16dfed
DA
21272012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2128
2129 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2130 with RESET_INTERVAL.
2131
2132 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2133 Remove duplicated buffer name initialization.
2134
3f83ace8
JM
21352012-05-02 Jim Meyering <jim@meyering.net>
2136
2137 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2138
c7b8541e
JM
2139 * xfns.c (x_window): Use xstrdup (Bug#11375).
2140
90207a15 21412012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2142
2143 * xdisp.c (pos_visible_p): If already at a newline from the
2144 display string before the 'while' loop, don't walk back the glyphs
2145 from it3.glyph_row. Solves assertion violation when the display
2146 string begins with a newline (egg.el). (Bug#11367)
2147
b593d6a9
AH
21482012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2149
2150 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2151 Move to simple.el.
2152
4737362e
GM
21532012-05-01 Glenn Morris <rgm@gnu.org>
2154
99cf43f9
GM
2155 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2156 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2157 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2158 All were removed before 23.1.
2159
9311dcff
GM
2160 * dispnew.c: Remove HAVE_LIBNCURSES test;
2161 it is always true on relevant platforms.
2162
4d5c6349
GM
2163 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2164 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2165
4737362e
GM
2166 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2167
74dd3a6b
AS
21682012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2169
2170 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2171 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2172 Remove.
2173
13c379ee
PE
21742012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2175
2176 Do not avoid creating empty evaporating overlays (Bug#9642).
2177 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2178 That is, do not delete an evaporating overlay if it becomes
2179 empty after its bounds are adjusted to fit within its buffer.
2180 This fix caused other problems, and I'm reverting it until we get
2181 to the bottom of them.
2182
a8e7d6d7 21832012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2184
2185 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2186
a8e7d6d7 21872012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2188
2189 * xdisp.c (pos_visible_p): If the window start position is beyond
2190 ZV, start the display from buffer beginning. Prevents assertion
2191 violation in init_iterator when the minibuffer window is scrolled
2192 via the scroll bar.
2193
2194 * window.c (window_scroll_pixel_based): Likewise.
2195
a8e7d6d7 21962012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2197
2198 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2199
a8e7d6d7 22002012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2201
2202 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2203 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2204
a8e7d6d7 22052012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2206
b593d6a9
AH
2207 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2208 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2209
1c6900d9
EZ
22102012-04-26 Eli Zaretskii <eliz@gnu.org>
2211
4c3fa1d9
EZ
2212 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2213 display element, check also the underlying string or buffer
2214 character. (Bug#11341)
2215
1c6900d9
EZ
2216 * w32menu.c: Include w32heap.h.
2217 (add_menu_item): If the call to AppendMenuW (via
2218 unicode_append_menu) fails, disable Unicode menus only if we are
2219 running on Windows 9X/Me.
2220
42bf8205
AS
22212012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2222
2223 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2224 (xgetint): Add missing shift for LSB tags.
2225
b1bac16e
MR
22262012-04-24 Martin Rudalics <rudalics@gmx.at>
2227
2228 * keyboard.c (read_char): Don't wipe echo area for select window
2229 events: These might get delayed via `mouse-autoselect-window'
2230 (Bug#11304).
2231
d69621cc
JB
22322012-04-24 Juanma Barranquero <lekktu@gmail.com>
2233
2234 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2235 manipulation of :loaded-from data.
2236
02fd101b
JB
22372012-04-23 Juanma Barranquero <lekktu@gmail.com>
2238
2239 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2240 now a cons (bug#11311).
2241
888bec30
PE
22422012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2243
89a438bd
PE
2244 Do not create empty overlays with the evaporate property (Bug#9642).
2245 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2246 if it becomes empty after its bounds are adjusted to fit within
2247 its buffer. Without this fix, in a nonempty buffer (let ((o
2248 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2249 yields an empty overlay that has the evaporate property, which is
2250 not supposed to happen.
2251
1068fe4d
PE
2252 Fix minor GTK3 problems found by static checking.
2253 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2254 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2255 (struct _EmacsFixedClass, emacs_fixed_get_type):
2256 Move decls here from emacsgtkfixed.h, since they needn't be public.
2257 (emacs_fixed_get_type): Now static.
2258 (emacs_fixed_class_init): Omit unused local.
2259 (emacs_fixed_child_type): Remove; unused.
2260 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2261 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2262 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2263 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2264 (EMACS_FIXED_GET_CLASS): Remove; unused.
2265 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2266
888bec30
PE
2267 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2268 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2269
de85e130
PE
22702012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2271
d0baac98 2272 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2273 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2274 (__malloc_size_t, __malloc_ptrdiff_t):
2275 Remove. All uses removed, replaced by the definiens if needed,
2276 since we can assume C89 or better now.
2277 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2278 (protect_malloc_state, align, get_contiguous_space)
2279 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2280 (malloc_atfork_handler_child, malloc_enable_thread)
2281 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2282 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2283 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2284 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2285 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2286 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2287 Define using prototypes, not old style.
2288 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2289 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2290 (align): Don't assume that signed integer overflow wraps around.
2291 Omit unused local var.
2292 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2293 (_free_internal_nolock, memalign, mallochook, reallochook):
2294 Omit no-longer-needed casts.
2295 (valloc): Use getpagesize, not __getpagesize.
2296 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2297 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2298
de85e130
PE
2299 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2300
dcbf5805
MA
23012012-04-22 Michael Albinus <michael.albinus@gmx.de>
2302
2303 Move functions from C to Lisp. Make non-blocking method calls
2304 the default. Implement further D-Bus standard interfaces.
2305
2306 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2307 (QCdbus_request_name_allow_replacement)
2308 (QCdbus_request_name_replace_existing)
2309 (QCdbus_request_name_do_not_queue)
2310 (QCdbus_request_name_reply_primary_owner)
2311 (QCdbus_request_name_reply_in_queue)
2312 (QCdbus_request_name_reply_exists)
2313 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2314 (QCdbus_registered_serial, QCdbus_registered_method)
2315 (QCdbus_registered_signal): New Lisp objects.
2316 (XD_DEBUG_MESSAGE): Use sizeof.
2317 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2318 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2319 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2320 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2321 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2322 (xd_signature, xd_append_arg): Allow float for integer types.
2323 (xd_get_connection_references): New function.
b593d6a9
AH
2324 (xd_get_connection_address): Rename from xd_initialize.
2325 Return cached address.
dcbf5805
MA
2326 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2327 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2328 level.
2329 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2330 Return number of refcounts.
dcbf5805
MA
2331 (Fdbus_get_unique_name): Make stronger parameter check.
2332 (Fdbus_message_internal): New defun.
2333 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2334 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2335 (Fdbus_send_signal, Fdbus_register_service)
2336 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2337 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2338 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2339 (Vdbus_compiled_version, Vdbus_runtime_version)
2340 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2341 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2342 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2343 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2344 Adapt docstring.
dcbf5805 2345
52828e02
PE
23462012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2347
da05bc4c
PE
2348 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2349 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2350 Do not assume ptrdiff_t is the same width as 'int'.
2351
52828e02
PE
2352 * alloc.c: Handle unusual debugging option combinations.
2353 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2354 since the two debugging options are incompatible.
2355 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2356 is defined.
2357 (mem_init, mem_insert, mem_insert_fixup):
2358 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2359 (NEED_MEM_INSERT): Remove; no longer needed.
2360
f01769f9
LL
23612012-04-22 Leo Liu <sdl.web@gmail.com>
2362
2363 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2364
5790543d
PE
23652012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 * sysdep.c [__FreeBSD__]: Minor cleanups.
2368 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2369 Use Emacs indenting style more consistently. Avoid some casts.
2370 Use 'double' consistently rather than mixing 'float' and 'double'.
2371
b91b7e4d
EW
23722012-04-21 Eduard Wiebe <usenet@pusto.de>
2373
b593d6a9
AH
2374 * sysdep.c (list_system_processes, system_process_attributes):
2375 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2376
6114eb15
AS
23772012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2378
2379 * lisp.mk (lisp): Update.
2380
2f38dff7
PE
23812012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2384 It is never used otherwise.
2385
4ae29f89
SM
23862012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2387
2388 * print.c (print_preprocess): Only check print_depth if print-circle
2389 is nil.
2390 (print_object): Check for cycles even when print-circle is nil and
2391 print-gensym is t, but only check print_depth if print-circle is nil.
2392
f30d612a
CY
23932012-04-20 Chong Yidong <cyd@gnu.org>
2394
2395 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2396 set the status to "failed" and ensure that sentinel is run.
2397
c07a4c0b 23982012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2399
2400 * process.c (Fset_process_inherit_coding_system_flag)
2401 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2402 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2403
c07a4c0b 24042012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2405
2406 * xdisp.c (string_buffer_position_lim): Limit starting position to
2407 BEGV.
2408 (set_cursor_from_row): If called for a mode-line or header-line
2409 row, return zero immediately.
2410 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2411 farther than the first row after the header line, if any.
2412 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2413 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2414
c07a4c0b 24152012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2416
4ae29f89
SM
2417 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2418 (bug#11238).
ad3a2b41 2419
c07a4c0b 24202012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 24212012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2422
2423 configure: new option --enable-gcc-warnings (Bug#11207)
2424 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2425 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2426 (ALL_CFLAGS): Use new macros rather than old.
2427 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2428 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2429 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2430 -Wunused-result, -Wunused-variable. This should go away once
2431 the Emacs and Gnulib regex code is merged.
2432 (xmalloc, xrealloc): Now static.
2433
aba027e8
PE
24342012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * dired.c (Fsystem_groups): Remove unused local.
2437
e5a36063
GM
24382012-04-17 Glenn Morris <rgm@gnu.org>
2439
2440 * dired.c (Fsystem_users): Doc fix.
2441
316411f0
DA
24422012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2443
2444 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2445 (syms_of_dired): Add them.
2446
9426aba4
PE
24472012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2448
b62a57be
PE
2449 Fix minor alloc.c problems found by static checking.
2450 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2451 New extern decls, to avoid calling undeclared functions.
2452 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2453 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2454 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2455 (NEED_MEM_INSERT): New macro.
2456 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2457 Remove one incorrect comment and fix another.
b62a57be 2458
3539f31f
PE
2459 Fix minor ralloc.c problems found by static checking.
2460 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2461 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2462 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2463 (r_alloc_sbrk): Now static.
2464
a041960a
PE
2465 Improve ralloc.c interface checking.
2466 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2467 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2468 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2469 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2470 [REL_ALLOC]: ... to here, to check interface.
2471 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2472 Remove decls. This fixes an "It stinks!".
2473
9426aba4
PE
2474 * alloc.c (which_symbols): Fix alignment issue / type clash.
2475
d55c12ed
AS
24762012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2477
2478 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2479 (struct Lisp_Misc_Any): Likewise.
2480 (struct Lisp_Free): Likewise.
2481 * alloc.c (union aligned_Lisp_Symbol): Define.
2482 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2483 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2484 (union aligned_Lisp_Misc): Define.
2485 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2486 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2487 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2488
b948ce8b
PE
24892012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2490
2491 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2492 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2493 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2494 * s/netbsd.h, s/sol2-6.h:
2495 Remove definition of GC_MARK_STACK, since the default now works.
2496 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2497 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2498 no longer the default.
2499 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2500
35dc09a1 25012012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2502
35dc09a1
GM
2503 * lread.c (lisp_file_lexically_bound_p):
2504 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2505
35dc09a1
GM
25062012-04-14 Eli Zaretskii <eliz@gnu.org>
2507
2508 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2509 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2510
25112012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2512
2513 * nsterm.m (constrainFrameRect): Always constrain when there is only
2514 one screen (Bug#10962).
2515
bcd86815
KB
25162012-04-13 Ken Brown <kbrown@cornell.edu>
2517
2518 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2519
c25df26e
RT
25202012-04-13 Reuben Thomas <rrt@sc3d.org>
2521
2522 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2523
0fc59f1e
DC
25242012-04-11 Daniel Colascione <dancol@dancol.org>
2525
2526 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2527 against is gone. It's better to use vfork now so that when Cygwin
2528 gains a new, working vfork, we use it automatically (bug#10398).
2529
de8c03dc
SM
25302012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2531
2532 * window.c (save_window_save): Obey window-point-insertion-type.
2533
2f097256
GM
25342012-04-11 Glenn Morris <rgm@gnu.org>
2535
2536 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2537
453b951e
SM
25382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2539
2540 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2541
75f1671a 25422012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2543
2544 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2545 (force_quit_count): New var.
2546 (handle_interrupt): Use it.
2547
2a8ce227
JB
25482012-04-10 Juanma Barranquero <lekktu@gmail.com>
2549
2550 * w32.c (w32_delayed_load): Record the full path of the library
2551 being loaded (bug#10424).
2552
935396c0
GM
25532012-04-09 Glenn Morris <rgm@gnu.org>
2554
05920a43
GM
2555 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2556 not just in the obarray, before snarfing them. (Bug#11036)
2557
935396c0
GM
2558 * Makefile.in ($(leimdir)/leim-list.el):
2559 Pass EMACS rather than BUILT_EMACS.
2560
a18ecafa
TZ
25612012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2562
2563 * process.c (make_process):
2564 * process.h: Add integer `gnutls_handshakes_tried' member to
2565 process struct.
2566
6bbef4e5
JC
2567 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2568 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2569
2570 * gnutls.c (gnutls_log_function2i): Convenience log function.
2571 (emacs_gnutls_read): Use new log functions,
2572 `gnutls_handshakes_tried' process member, and
2573 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2574 attempts per process (connection).
2575
b4d3bc10
CY
25762012-04-09 Chong Yidong <cyd@gnu.org>
2577
2578 * eval.c (Fuser_variable_p, user_variable_p_eh)
2579 (lisp_indirect_variable): Functions deleted.
2580 (Fdefvar): Caller changed.
2581
2582 * callint.c (Finteractive, Fcall_interactively):
2583 * minibuf.c (Fread_variable): Callers changed.
2584
70f4d973
EZ
25852012-04-09 Eli Zaretskii <eliz@gnu.org>
2586
2587 * xdisp.c (set_cursor_from_row): If the display string appears in
2588 the buffer at position that is closer to point than the position
2589 after the display string, display the cursor on the first glyph of
2590 the display string. Fixes cursor display when a 'display' text
2591 property immediately follows invisible text. (Bug#11094)
2592
cb3c2e3e
PE
25932012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2594
2595 composite.c: use 'double' consistently
2596 * composite.c (get_composition_id): Use 'double' consistently
2597 instead of converting 'float' to 'double' and vice versa; this is
2598 easier to understand and avoids a GCC warning.
2599
fd06db5d
GM
26002012-04-09 Glenn Morris <rgm@gnu.org>
2601
50fe702a
GM
2602 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2603 preparation for dumping it with emacs. (Bug#4789)
2604 (leimdir): New variable.
2605 ($(leimdir)/leim-list.el): New rule.
2606 (emacs$(EXEEXT)): Depend on leim-list.el.
2607
fd06db5d
GM
2608 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2609 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2610 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2611
55c131ee
AS
26122012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2613
2614 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2615 proper alignment.
2616
9209588f
JB
26172012-04-07 Juanma Barranquero <lekktu@gmail.com>
2618
2619 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2620 Remove unused local variable.
2621
e3fb2efb
PE
26222012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2623
2624 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2625 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2626 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2627 objects, as mark_maybe_pointer will catch them otherwise.
2628 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2629 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2630
b5385551
PE
26312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2632
2633 Fix typo that broke non-Windows builds.
2634 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2635
9078ead6
EZ
26362012-04-07 Eli Zaretskii <eliz@gnu.org>
2637
2638 Support building on MS-Windows with libxml2.
2639
2640 * makefile.w32-in (OBJ2): Add xml.$(O).
2641 (GLOBAL_SOURCES): Add xml.c.
2642 ($(BLD)/xml.$(O)): New dependency list.
2643
2644 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2645 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2646 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2647 [!WINDOWSNT]: New macros.
2648 (init_libxml2_functions, libxml2_loaded_p): New functions.
2649 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2650 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2651 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2652 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2653 linked in).
6bbef4e5
JC
2654 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2655 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2656 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2657
2658 * emacs.c: Don't include libxml/parser.h.
2659 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2660 xmlCleanupParser directly.
2661
2662 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2663
3811fdf3
EZ
26642012-04-07 Eli Zaretskii <eliz@gnu.org>
2665
2666 * indent.c (Fvertical_motion): If there is a display string at
2667 point, use it.vpos to compute how many lines to backtrack after
2668 move_it_to point. (Bug#11133)
2669
2f8e16b2
EZ
26702012-04-06 Eli Zaretskii <eliz@gnu.org>
2671
2672 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2673 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2674 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2675 macros related to unification of CJK characters. For the details,
2676 see the discussion following the message here:
2677 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2678
3d439cd1
CY
26792012-04-04 Chong Yidong <cyd@gnu.org>
2680
2681 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2682
8bc53d00
EZ
26832012-04-01 Eli Zaretskii <eliz@gnu.org>
2684
2685 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2686 instead of alloca. (Bug#11138)
2687
3b0512a3
AS
26882012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2689
2690 * w32menu.c (is_simple_dialog): Properly check lisp types.
2691 (Bug#11141)
2692
8427ddd2
EZ
26932012-03-31 Eli Zaretskii <eliz@gnu.org>
2694
979022ef
EZ
2695 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2696 position we get to after a call to move_it_to fails the
2697 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2698 only if we wind up in a string from display property. (Bug#11063)
2699
a6b1c7cc
EZ
2700 * window.c (Fdelete_other_windows_internal): Invalidate the row
2701 and column information about mouse highlight, so that redisplay
2702 restores it after reallocating the glyph matrices. (Bug#7464)
2703
8427ddd2
EZ
2704 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2705 string comes from a `display' text property, use the buffer
2706 position of that property as if we actually saw that position in
2707 the row's glyphs.
697ba24b
EZ
2708 (move_it_by_lines): Remove the assertion that
2709 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2710 violated when there's a before-string at the beginning of a line.
2711 (Bug#11063)
8427ddd2 2712
65a0a738
EZ
27132012-03-30 Eli Zaretskii <eliz@gnu.org>
2714
2715 * xdisp.c (append_space_for_newline): If the default face was
2716 remapped, use the remapped face for the appended newline.
2717 (extend_face_to_end_of_line): Use the remapped default face for
2718 extending the face to the end of the line.
2719 (display_line): Call extend_face_to_end_of_line when the default
2720 face was remapped. (Bug#11068)
2721
581355cc
EZ
27222012-03-29 Eli Zaretskii <eliz@gnu.org>
2723
2724 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2725
e8fc049f
SM
27262012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2727
2728 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2729
4fb9a543
GM
27302012-03-27 Glenn Morris <rgm@gnu.org>
2731
2732 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2733 Doc fixes.
2734
679910f1
KH
27352012-03-26 Kenichi Handa <handa@m17n.org>
2736
2737 * dispextern.h (struct glyph): Fix previous change. Change the
2738 bit length of glyphless.ch to 25 (Bug#11082).
2739
90d49b7f
CY
27402012-03-26 Chong Yidong <cyd@gnu.org>
2741
2742 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2743 (command_loop_1): Use it; inhibit selection update for
2744 handle-select-window too (Bug#8996).
2745
f514f6f0
FP
27462012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2747
e8fc049f 2748 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2749
bf43fa51
KH
27502012-03-25 Kenichi Handa <handa@m17n.org>
2751
2752 * dispextern.h (struct glyph): Change the bit length of
2753 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2754
8a0c01dd
EZ
27552012-03-24 Eli Zaretskii <eliz@gnu.org>
2756
2757 * s/ms-w32.h (tzname): Include time.h before redirecting to
2758 _tzname. Fixes the MSVC build. (Bug#9960)
2759
7d1c3a76
AS
27602012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2761
8ed79523
AS
2762 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2763 characters.
2764
7d1c3a76
AS
2765 * xterm.c (XTread_socket): Only modify handling_signal if
2766 !SYNC_INPUT. (Bug#11080)
2767
e99a9b8b
EZ
27682012-03-23 Eli Zaretskii <eliz@gnu.org>
2769
2770 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2771 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2772 when fetching a multibyte character consumes more bytes than
2773 CHAR_BYTES returns, due to unification of CJK characters in
2774 string_char. (Bug#11073)
2775
5063c0e1
TN
27762012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2777
2778 * process.c (wait_reading_process_output): Handle pty disconnect
2779 by refraining from sending oneself a SIGCHLD (bug#10933).
2780
9f851fbd
CY
27812012-03-22 Chong Yidong <cyd@gnu.org>
2782
2783 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2784
5063c0e1 2785 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2786 Mark string as coming from a prefix property.
2787 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2788 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2789
fb5b8aca
CY
27902012-03-21 Chong Yidong <cyd@gnu.org>
2791
2792 * xfaces.c (Vface_remapping_alist): Doc fix.
2793
62356a1b
EZ
27942012-03-20 Eli Zaretskii <eliz@gnu.org>
2795
2796 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2797 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2798 Doc fixes.
62356a1b 2799
025de85b
CY
28002012-03-20 Chong Yidong <cyd@gnu.org>
2801
2802 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2803 to reflect default non-nil value of redisplay-dont-pause.
2804
4827f94e
KH
28052012-03-19 Kenichi Handa <handa@m17n.org>
2806
2807 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2808 it fit in a valid range (Bug#11003).
2809
e50a24a2
EZ
28102012-03-18 Eli Zaretskii <eliz@gnu.org>
2811
2812 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2813 that is not from display property, accept the row as a "cursor
2814 row" if one of the string's character has a non-nil `cursor'
2815 property. Fixes cursor positioning when there are newlines in
2816 overlay strings, e.g. in icomplete.el. (Bug#11035)
2817
9af5ed87
PE
28182012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2819
2820 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2821
d1f55f16
CY
28222012-03-12 Chong Yidong <cyd@gnu.org>
2823
2824 * eval.c (inhibit_lisp_code): Rename from
2825 inhibit_window_configuration_change_hook; move from window.c.
2826
2827 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2828 * window.c (run_window_configuration_change_hook)
2829 (syms_of_window): Callers changed.
2830
66c5eebd
CY
28312012-03-11 Chong Yidong <cyd@gnu.org>
2832
413df973
CY
2833 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2834
66c5eebd
CY
2835 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2836
1de11f56
CY
28372012-03-10 Chong Yidong <cyd@gnu.org>
2838
2839 * frame.c (other_visible_frames): Don't assume the selected frame
2840 is visible (Bug#10955).
2841
cae07000
SM
28422012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2843
2844 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2845
89c94350
JD
28462012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2847
2848 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2849 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2850 zero (Bug#10954).
2851
999dd333
GM
28522012-03-03 Glenn Morris <rgm@gnu.org>
2853
01a6dcc8 2854 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2855
de0100f2
EZ
28562012-03-02 Eli Zaretskii <eliz@gnu.org>
2857
2858 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2859 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2860 (redisplay_window, next_element_from_string): Fix typos in
2861 comments.
3e441275
EZ
2862 (redisplay_window): Pass to move_it_vertically the margin in
2863 pixels, not in screen lines.
de0100f2 2864
96a72ee9
GM
28652012-03-02 Glenn Morris <rgm@gnu.org>
2866
2867 * buffer.c (buffer-list-update-hook): Doc fix.
2868
312508d7
EZ
28692012-02-29 Eli Zaretskii <eliz@gnu.org>
2870
2871 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2872 push_it before setting up the iterator for the first overlay
2873 string, even if we have an empty string loaded.
2874 (next_overlay_string): If there's an empty string on the iterator
2875 stack, pop the stack. (Bug#10903)
2876
27f3c637
PE
28772012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2880 Suggested by Stefan Monnier in
2881 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2882 * alloc.c (widen_to_Lisp_Object): New static function.
2883 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2884 and widening them to Lisp_Objects. This would work even if
2885 USE_LSB_TAG is defined and wide integers are used, which might
2886 happen in a future version of Emacs.
2887
3c9dfce6
CY
28882012-02-25 Chong Yidong <cyd@gnu.org>
2889
fa74b241
CY
2890 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2891 Doc fix.
2892
3c9dfce6
CY
2893 * xselect.c (Fx_selection_exists_p): Doc fix.
2894 (x_clipboard_manager_save_all): Print an informative message
2895 before saving to clipboard manager.
2896
9486df08
CY
28972012-02-24 Chong Yidong <cyd@gnu.org>
2898
2899 * keyboard.c (process_special_events): Handle all X selection
2900 requests in kbd_buffer, not just the next one (Bug#8869).
2901
f01d3321
CY
29022012-02-23 Chong Yidong <cyd@gnu.org>
2903
2904 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2905 call when setting menu-bar-lines and tool-bar-lines parameters.
2906 (unwind_create_frame_1): New helper function.
2907
2908 * window.c (inhibit_window_configuration_change_hook): New var.
2909 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2910 (syms_of_window): Initialize it.
f01d3321 2911
86b847b6
CY
29122012-02-22 Chong Yidong <cyd@gnu.org>
2913
2914 * xterm.c (x_draw_image_relief): Add missing type check for
2915 Vtool_bar_button_margin (Bug#10743).
2916
a59225b1
CY
29172012-02-21 Chong Yidong <cyd@gnu.org>
2918
2919 * fileio.c (Vfile_name_handler_alist): Doc fix.
2920
2921 * buffer.c (Fget_file_buffer): Protect against invalid file
2922 handler return value.
2923
310f5bd4
PE
29242012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2925
cb3a28cc
PE
2926 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2927 when computing $valmask.
2928
310f5bd4
PE
2929 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2930 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2931 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2932 It's useless in that case, and it can cause problems on hosts
2933 that allocate halves of EMACS_INT values separately.
2934 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2935 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2936 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2937 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2938 it avoids undefined behavior on hosts where shifting right by more
2939 than the word width has undefined behavior.
2940
2375c96a
CY
29412012-02-19 Chong Yidong <cyd@gnu.org>
2942
2943 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2944 (Funhandled_file_name_directory, Ffile_name_as_directory)
2945 (Fdirectory_file_name, Fexpand_file_name)
2946 (Fsubstitute_in_file_name): Protect against invalid file handler
2947 return values (Bug#10845).
2948
3eb49e71
EZ
29492012-02-18 Eli Zaretskii <eliz@gnu.org>
2950
2951 * .gdbinit (pitx): Fix incorrect references to fields of the
2952 iterator stack.
2953
7b926f3f
CY
29542012-02-17 Chong Yidong <cyd@gnu.org>
2955
2956 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2957
11273115
PE
29582012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2959
2960 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2961 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2962
c3a70e2b
CY
29632012-02-15 Chong Yidong <cyd@gnu.org>
2964
2965 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2966 marked as special. Also, starting docstrings with * is obsolete.
2967
0ca43699
AS
29682012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2969
2970 * gnutls.c (emacs_gnutls_write): Fix last change.
2971
2e8f3c56
LI
29722012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2973
2974 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2975 send_process.
2976
af70074f
SM
29772012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2978
2979 * keymap.c (Fsingle_key_description): Handle char ranges.
2980
95986d52
CY
29812012-02-12 Chong Yidong <cyd@gnu.org>
2982
afd83bd1
CY
2983 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2984 as that creates a dangerous corner case.
2985
95986d52
CY
2986 * window.c (Fdelete_window_internal): Invalidate the mouse
2987 highlight (Bug#9904).
2988
bd7da63e
GM
29892012-02-12 Glenn Morris <rgm@gnu.org>
2990
2991 * xselect.c (Fx_own_selection_internal)
2992 (Fx_get_selection_internal, Fx_disown_selection_internal)
2993 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2994 * nsselect.m (Fx_own_selection_internal)
2995 (Fx_disown_selection_internal, Fx_selection_exists_p)
2996 (Fx_selection_owner_p, Fx_get_selection_internal):
2997 Sync docs and argument specs with the xselect.c versions.
2998
77abcbc2
LI
29992012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3000
3001 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3002
90b671e2
EZ
30032012-02-11 Eli Zaretskii <eliz@gnu.org>
3004
1c0ca0b7
EZ
3005 * w32select.c (Fx_selection_exists_p): Sync doc string and
3006 argument list with xselect.c. (Bug#10783)
3007
3008 * w16select.c (Fx_selection_exists_p): Sync doc string and
3009 argument list with xselect.c. (Bug#10783)
90b671e2 3010
49241268
GM
30112012-02-10 Glenn Morris <rgm@gnu.org>
3012
3013 * fns.c (Fsecure_hash): Doc fix.
3014
f998bbe7 30152012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3016
3017 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3018
0992bd9c
CY
30192012-02-07 Chong Yidong <cyd@gnu.org>
3020
3021 * buffer.c (Fbuffer_local_variables)
3022 (buffer_lisp_local_variables): Handle unbound vars correctly;
3023 don't let Qunbound leak into Lisp.
3024
af008560
GM
30252012-02-07 Glenn Morris <rgm@gnu.org>
3026
dd605cc4
GM
3027 * image.c (Fimagemagick_types): Doc fix.
3028
af008560
GM
3029 * image.c (imagemagick-render-type): Change it from a lisp object
3030 to an integer. Move the doc here from the lisp manual.
3031 Treat all values not equal to 0 the same.
3032
1449fa1d
CY
30332012-02-06 Chong Yidong <cyd@gnu.org>
3034
3035 * doc.c (store_function_docstring): Avoid applying docstring of
3036 alias to base function (Bug#2603).
3037
3723ec07
AS
30382012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3039
3040 * .gdbinit (pp1, pv1): Remove redundant defines.
3041 (pr): Use pp.
3042
79c1cc1e
CY
30432012-02-04 Chong Yidong <cyd@gnu.org>
3044
3045 * nsterm.m: Declare a global (Bug#10694).
3046
d7f29f8e
EZ
30472012-02-04 Eli Zaretskii <eliz@gnu.org>
3048
cae07000
SM
3049 * w32.c (get_emacs_configuration_options):
3050 Include --enable-checking, if specified, in the return value.
d7f29f8e 3051
3b95a6f9
MR
30522012-02-04 Martin Rudalics <rudalics@gmx.at>
3053
3054 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3055 after rounding frame sizes. (Bug#9723)
3056
d6fa96a6
EZ
30572012-02-04 Eli Zaretskii <eliz@gnu.org>
3058
3059 * keyboard.c (adjust_point_for_property): Don't position point
3060 before BEGV. (Bug#10696)
3061
df0b2940
PE
30622012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 Handle overflow when computing char display width (Bug#9496).
3065 * character.c (char_width): Return EMACS_INT, not int.
3066 (char_width, c_string_width): Check for overflow when
3067 computing the width; this is possible now that individual
3068 characters can have unbounded width. Problem introduced
3069 by merge from Emacs 23 on 2012-01-19.
3070
6bee44d6
MA
30712012-02-02 Michael Albinus <michael.albinus@gmx.de>
3072
3073 * dbusbind.c (Fdbus_register_method): Mention the return value
3074 :ignore in the docstring.
3075
44f92739
GM
30762012-02-02 Glenn Morris <rgm@gnu.org>
3077
1b9f60cc
GM
3078 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3079
44f92739
GM
3080 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3081 Unconditionally set to t. (Bug#10673)
3082 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3083 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3084 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3085
c5d3843c
KH
30862012-02-02 Kenichi Handa <handa@m17n.org>
3087
3088 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3089 0, do not call append_composite_glyph.
3090
159462d4 30912012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3092
3093 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3094 NULL (Bug#6988).
3095 (x_produce_glyphs): If the component of a composition is a null
3096 string, set it->pixel_width to 1 to avoid zero-width glyph.
3097
78cef877
EZ
30982012-02-01 Eli Zaretskii <eliz@gnu.org>
3099
3100 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3101 first 2 arguments are identical. This makes inserting large
3102 output from a subprocess an order of magnitude faster on
3103 MS-Windows, where all sbrk'ed memory is always contiguous.
3104
97897668
GM
31052012-01-31 Glenn Morris <rgm@gnu.org>
3106
3107 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3108 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3109 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3110
31fd3586
GM
31112012-01-29 Glenn Morris <rgm@gnu.org>
3112
3113 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3114
0e24a8b2
CY
31152012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3116
3117 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3118
cc0adcb0
CY
31192012-01-28 Chong Yidong <cyd@gnu.org>
3120
3121 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3122
acc28cb9
CY
31232012-01-26 Chong Yidong <cyd@gnu.org>
3124
9c69cfb7
CY
3125 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3126
acc28cb9
CY
3127 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3128 repeat counts (Bug#10507).
3129
48da7392
GM
31302012-01-26 Glenn Morris <rgm@gnu.org>
3131
3132 * lread.c (syms_of_lread): Doc fix.
3133
14af5f7f
CY
31342012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3135
3136 * coding.c (encode_designation_at_bol): Change return value to
3137 EMACS_INT.
3138
0b21c100
CY
31392012-01-25 Chong Yidong <cyd@gnu.org>
3140
3141 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3142
3c2907f7
CY
31432012-01-21 Chong Yidong <cyd@gnu.org>
3144
3145 * floatfns.c (Fcopysign): Make the second argument non-optional,
3146 since nil is not allowed anyway.
3147
959ad23f
AS
31482012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3149
3150 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3151 (send_process): Likewise.
3152
34a02f46
MR
31532012-01-19 Martin Rudalics <rudalics@gmx.at>
3154
3155 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3156 (Vwindow_persistent_parameters): Do not use Qstate.
3157 Rewrite doc-strings.
34a02f46 3158
1259009a 31592012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3160
3161 * character.c (char_width): New function.
70d4fdf6
GM
3162 (Fchar_width, c_string_width, lisp_string_width):
3163 Use char_width (Bug#9496).
25ed9e61 3164
6a6ee00d
MR
31652012-01-16 Martin Rudalics <rudalics@gmx.at>
3166
3167 * window.c (Vwindow_persistent_parameters): New variable.
3168 (Fset_window_configuration, save_window_save): Handle persistent
3169 window parameters.
3170
c85efaf7
EZ
31712012-01-14 Eli Zaretskii <eliz@gnu.org>
3172
3173 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3174 thrashing the stack of the thread. (Bug#9087)
3175
5944709e
PE
31762012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3177
3178 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3179
e71f5d99
EZ
31802012-01-11 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xdisp.c (rows_from_pos_range): Handle the case where the
3183 highlight ends on a newline. (Bug#10464)
3184 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3185 he end column for display of highlight that ends on a newline
3186 before a R2L line.
3187
ce316182
GM
31882012-01-11 Glenn Morris <rgm@gnu.org>
3189
3190 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3191 from load-path also when installation-directory is nil. (Bug#10208)
3192
5b43da69
GM
31932012-01-10 Glenn Morris <rgm@gnu.org>
3194
74cc8ff9
GM
3195 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3196
7d8d6e4e
GM
3197 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3198 Update template values to be closer to their typical values these days.
5b43da69 3199
a0db8d43
EZ
32002012-01-09 Eli Zaretskii <eliz@gnu.org>
3201
3202 * xdisp.c (rows_from_pos_range): Accept additional argument
3203 DISP_STRING, and accept any glyph in a row whose object is that
3204 string as eligible for mouse highlight. Fixes mouse highlight of
3205 display strings from overlays. (Bug#10464)
3206
9a0115ab 32072012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3208
b9110d6a 3209 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3210 * fileio.c (auto_saving_dir_umask): New static var.
3211 (Fmake_directory_internal): Use it.
3212 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3213 creating the directory. The old code temporarily assigns
3214 too-generous permissions to the directory.
3215 (do_auto_save_eh): Clear it.
b9110d6a 3216 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3217 that the var is always cleared.
3218
6c1bd3f3
EZ
32192012-01-07 Eli Zaretskii <eliz@gnu.org>
3220
3221 * search.c (scan_buffer): Pass character positions to
3222 know_region_cache, not byte positions. (Bug#6540)
3223
069d2b50
L
32242012-01-07 LynX <_LynX@bk.ru> (tiny change)
3225
3226 * w32.c (sys_rename): Report EXDEV when rename of a directory
3227 fails because the target is on another logical disk. (Bug#10284)
3228
75bf0d33
DB
32292012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3230
3231 * xterm.c (x_embed_request_focus): New function.
3232
3233 * xterm.h: Add prototype.
3234
3235 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3236
1c6e5a32
GM
32372012-01-05 Glenn Morris <rgm@gnu.org>
3238
3239 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3240
651e947e
EZ
32412012-01-01 Eli Zaretskii <eliz@gnu.org>
3242
3243 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3244 Load gnutls_transport_set_lowat only if GnuTLS version is below
3245 2.11.1.
3246 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3247 GnuTLS versions below 2.11.1.
3248
3778cdd8
AL
32492011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3250
3251 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3252 to the doc string advising against its use for altering the way
3253 windows are scrolled.
3254
0e5317f7
KH
32552011-12-28 Kenichi Handa <handa@m17n.org>
3256
3257 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3258 coding-system ASCII compatible only when it does not produce BOM
3259 on encoding (Bug#10383).
3260
93d5ca1f
JD
32612011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3262
3263 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3264 can scroll.
3265 (create_and_show_popup_menu): Always use menu_position_func for
3266 Gtk3 (Bug#10361).
3267
ca22b785
AS
32682011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3269
3270 * callint.c (Fcall_interactively): Don't truncate prompt string.
3271
d048e1e6
EZ
32722011-12-23 Eli Zaretskii <eliz@gnu.org>
3273
3274 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3275 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3276 resumed from there (after widening). (Bug#10360)
d048e1e6 3277
5ccaba1f
JD
32782011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3279
3280 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3281
204ee57f
JD
32822011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3283
b81d40f0
JB
3284 * nsterm.m (x_free_frame_resources):
3285 Release f->output_data.ns->miniimage.
204ee57f
JD
3286 (ns_index_color): Fix indentation. Do not retain
3287 color_table->colors[i].
3288
3289 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3290 before returning.
3291
3292 * nsfns.m (x_set_background_color): Assign return value from
3293 ns_index_color to face-background instead of NSColor*.
3294 (ns_implicitly_set_icon_type): Fix indentation.
3295 Change assignment in for loop to comparison.
3296
3297 * emacs.c (ns_pool): New variable.
3298 (main): Assign ns_pool.
3299 (Fkill_emacs): Call ns_release_autorelease_pool.
3300
3301 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3302 autorelease fdesc, release fdAttrs and tdict.
3303 (ns_get_covering_families): Release charset.
3304 (ns_findfonts): Release NSFontDescriptor created with new.
3305 (ns_uni_to_glyphs): Fix indentation.
3306 (setString): Release attrStr before assigning new value.
3307
c803b2b7
JD
33082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3309
678f4426
JD
3310 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3311 and NS_IMPL_COCOA.
3312 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3313 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3314
cd394be1 33152011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3316
5fecd5fc
JD
3317 * nsterm.m (ns_term_init): Subscribe for notifications
3318 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3319 to method trackingNotification in EmacsMenu.
3320
3321 * nsmenu.m (trackingMenu): New variable.
3771cb17 3322 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3323 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3324 from Aquamacs (Bug#7030).
678f4426
JD
3325
33262011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3327
c803b2b7
JD
3328 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3329 (symbol_to_nsstring): Fix indentation.
3330 (ns_symbol_to_pb): New function.
cae07000
SM
3331 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3332 (Fns_rotate_cut_buffers_internal): Remove.
3333 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3334 Fns_store_cut_buffer_internal.
3335 (ns_get_foreign_selection, Fx_own_selection_internal)
3336 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3337 (Fns_get_selection_internal, Fns_store_selection_internal):
3338 Use ns_symbol_to_pb and check if return value is nil.
3339 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3340 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3341 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3342 renamed to Sns_store_selection_internal.
3343 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3344 and remove this function.
3345 (ns_handle_selection_clear): Remove, never used.
3346 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3347 here.
3348
e1b01a3a
KB
33492011-12-17 Ken Brown <kbrown@cornell.edu>
3350
3351 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3352 GID is unknown (Bug#10257).
3353
2adb6e85
PE
33542011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3355
3356 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3357 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3358 which caused a build failure on GNU/Linux IA-64. This problem was
3359 introduced by my 2011-10-07 patch.
3360
d1d7b339
JL
33612011-12-15 Juri Linkov <juri@jurta.org>
3362
3363 * image.c (imagemagick_error): New function. (Bug#10112)
3364 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3365 Use `imagemagick_error' where ImageMagick functions return
3366 `MagickFalse'.
3367 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3368 proper order.
3369
100d5755
KH
33702011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3371
3372 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3373 fill background (Bug#8992).
3374
454592a6
MR
33752011-12-13 Martin Rudalics <rudalics@gmx.at>
3376
3377 * window.c (Vwindow_combination_resize)
3378 (Vwindow_combination_limit): Use t instead of non-nil in
3379 doc-strings.
61d4b438
MR
3380 (Vrecenter_redisplay): Add first sentence of doc-string on
3381 separate line.
53524d93 3382 (Frecenter): Fix doc-string typo.
454592a6 3383
3633e3aa
KH
33842011-12-11 Kenichi Handa <handa@m17n.org>
3385
3386 * coding.c (Funencodable_char_position): Pay attention to the
3387 buffer text relocation (Bug#9389).
3388
7b9d523a 33892011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3390
7b9d523a
JD
3391 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3392 gtk_init (Bug#10100).
3393
b73189c6
EZ
33942011-12-10 Eli Zaretskii <eliz@gnu.org>
3395
3396 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3397 IT->string is nil. (Bug#10263)
3398
f7dfe5d6
JD
33992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3400
83faebb4
JD
3401 * nsterm.h (x_free_frame_resources): Declare.
3402
f7dfe5d6
JD
3403 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3404 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3405
3406 * nsterm.h (ns_get_defaults_value): Declare.
3407
3408 * nsterm.m (ns_default): Call ns_get_defaults_value.
3409
7cd4e72c
EZ
34102011-12-09 Eli Zaretskii <eliz@gnu.org>
3411
3412 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3413 (Bug#10170)
3414
b34d7317
YM
34152011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3416
3417 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3418 that where the value of an _OBJC_* symbol points to is in the .bss
3419 section (Bug#10240).
3420
76470ad1
KH
34212011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3422
3423 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3424 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3425
745fff94
KH
34262011-12-08 Kenichi Handa <handa@m17n.org>
3427
3428 * ftfont.c (get_adstyle_property): Fix previous change
3429 (Bug#10233).
3430
6e44397c
JB
34312011-12-07 Juanma Barranquero <lekktu@gmail.com>
3432
3433 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3434 dirs from the default value of EMACSLOADPATH (bug#10208).
3435
7efa6272
GM
34362011-12-07 Glenn Morris <rgm@gnu.org>
3437
3438 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3439 installation and source directories as well. (Bug#10208)
3440
f6fc4d87
CY
34412011-12-06 Chong Yidong <cyd@gnu.org>
3442
3443 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3444
2bf26180
GM
34452011-12-06 Glenn Morris <rgm@gnu.org>
3446
3447 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3448 as an error, not just -1. (Bug#10217)
3449
3a6ad4f0
CY
34502011-12-05 Chong Yidong <cyd@gnu.org>
3451
3452 * keyboard.c (process_special_events): New function.
3453 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3454
75a3b399
PE
34552011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3456
3457 * coding.c (encode_designation_at_bol): Don't use uninitialized
3458 local variable (Bug#9318).
3459
c3c9e25e
KH
34602011-12-05 Kenichi Handa <handa@m17n.org>
3461
3462 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3463 return Qnil (Bug#8046, Bug#10193).
3464
5eb05ea3
KH
34652011-12-05 Kenichi Handa <handa@m17n.org>
3466
3467 * coding.c (encode_designation_at_bol): New args charbuf_end and
3468 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3469 (coding_set_source): Return how many bytes coding->source was
3470 relocated.
3471 (coding_set_destination): Return how many bytes
3472 coding->destination was relocated.
3473 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3474 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3475
34762011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3477
3478 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3479 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3480 macro (Bug#9318).
3481
34822011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3483
3484 The following changes are to fix Bug#9318.
3485
a79703f5 3486 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3487 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3488 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3489 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3490
7dbda6df
JB
34912011-12-05 Juanma Barranquero <lekktu@gmail.com>
3492
3493 * lisp.h (process_quit_flag): Fix external declaration.
3494
6d5eb5b0
SM
34952011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3496
3497 Don't macro-inline non-performance-critical code.
3498 * eval.c (process_quit_flag): New function.
3499 * lisp.h (QUIT): Use it.
3500
a0c3fad0
JD
35012011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3502
3503 * nsfns.m (get_geometry_from_preferences): New function.
3504 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3505
6c07aac2
AS
35062011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3507
3508 * emacs.c (Qkill_emacs): Define.
3509 (syms_of_emacs): Initialize it.
3510 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3511 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3512 (quit_throw_to_read_char): Add parameter `from_signal'.
3513 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3514 * lisp.h (QUIT): Call Fkill_emacs if requested.
3515
c052ead4
JD
35162011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3517
3518 * widget.c (update_wm_hints): Return if wmshell is null.
3519 (widget_update_wm_size_hints): New function.
3520
3521 * widget.h (widget_update_wm_size_hints): Declare.
3522
3523 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3524 widget_update_wm_size_hints (Bug#10104).
3525
9e49252b
EZ
35262011-12-03 Eli Zaretskii <eliz@gnu.org>
3527
3528 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3529 before a newline, prepare the bidi iterator for consuming the
3530 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3531 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3532
02b16839
JL
35332011-12-02 Juri Linkov <juri@jurta.org>
3534
3535 * search.c (Fword_search_regexp): New Lisp function created from
3536 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3537 (Fword_search_backward, Fword_search_forward)
3538 (Fword_search_backward_lax, Fword_search_forward_lax):
3539 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3540 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3541
0068070e
SM
35422011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3543
3544 * fileio.c (Finsert_file_contents): Move after-change-function call
3545 to before the "handled:" label, since all "goto handled" appear in
3546 cases where the *-change-functions have already been properly called
3547 (bug#10117).
3548
3360a3fc
AS
35492011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3550
3551 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3552 waiting for input. (Bug#10169)
3553
73d6c093
EZ
35542011-11-30 Eli Zaretskii <eliz@gnu.org>
3555
3556 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3557 verifies glyph row's hash code--we have just reallocated the
3558 glyphs, so their contents can be complete garbage. (Bug#10164)
3559
febe6bea
JB
35602011-11-30 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3563
801a4313
EZ
35642011-11-30 Eli Zaretskii <eliz@gnu.org>
3565
3566 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3567 attributes are tested _before_ calling verify_row_hash, to protect
3568 against GCC re-ordering of the tests. (Bug#10164)
3569
2b56b87e
JD
35702011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3573
3574 * xterm.c (handle_one_xevent): Only set async_visible and friends
3575 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3576 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3577 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3578
dbf31225
PE
35792011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3580
3581 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3582 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3583 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3584 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3585 All uses changed to use GCPRO1 etc.
3586 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3587 Revert to old implementation (i.e., before 2011-03-11).
3588
1305621b
YM
35892011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3590
3591 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3592 of scroll runs so as to avoid assigning disabled bogus rows and
3593 unnecessary graphics copy operations.
3594
8c9afb46
EZ
35952011-11-27 Eli Zaretskii <eliz@gnu.org>
3596
3597 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3598 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3599 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3600 (malloc, free, realloc, calloc): Redirect to e_* only when
3601 compiling Emacs.
3602
3603 * lisp.h (GCTYPEBITS): Move before first use.
3604 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3605 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3606 this macro definition.
3607
3608 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3609 _MSC_VER.
3610
54e9e3bf
JD
36112011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3612
6d5eb5b0
SM
3613 * gtkutil.c (xg_create_frame_widgets):
3614 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3615 present with Gtk+ 2.0.
3616
83aca1cb
PE
36172011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3618
3619 * fileio.c (Finsert_file_contents): Undo previous change; see
3620 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3621
5b76caa4
PE
36222011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 Rename locals to avoid shadowing.
3625 * fileio.c (Finsert_file_contents):
3626 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3627 * process.c (wait_reading_process_output):
3628 Rename inner 'proc' to 'p' to avoid shadowing.
3629 Indent for consistency with usual Emacs style.
3630
8c535114
EZ
36312011-11-25 Eli Zaretskii <eliz@gnu.org>
3632
3633 * xdisp.c (redisplay_window): If cursor row is not fully visible
3634 after recentering, and scroll-conservatively is set to a large
3635 number, scroll window by a few more lines to make the cursor fully
3636 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3637 (start_display): Don't move to the next line if the display should
3638 start at a newline that is part of a display vector or an overlay
3639 string. (Bug#10119)
8c535114 3640
fa4fdb5c
JL
36412011-11-24 Juri Linkov <juri@jurta.org>
3642
3643 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3644 after the `MagickPingImage' call. (Bug#10112)
3645
90ec88df
CY
36462011-11-23 Chong Yidong <cyd@gnu.org>
3647
3648 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3649
56e2e794
MR
36502011-11-23 Martin Rudalics <rudalics@gmx.at>
3651
3652 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3653 making another buffer current. (Bug#10114)
3654
b6e64c41
GM
36552011-11-23 Glenn Morris <rgm@gnu.org>
3656
3657 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3658
6b21de18
CY
36592011-11-23 Chong Yidong <cyd@gnu.org>
3660
3661 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3662 using it (Bug#5984).
3663
b12cd789
EZ
36642011-11-22 Eli Zaretskii <eliz@gnu.org>
3665
3666 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3667 and header-lines, as they don't have one computed for them.
3668 (Bug#10098)
3669
3670 * .gdbinit (prow): Make displayed values more self-explaining.
3671 Add row's hash code.
3672
261b6fd4
LMI
36732011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3674
3675 * process.c (wait_reading_process_output): Fix asynchrounous
3676 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3677 (wait_reading_process_output): Add comment and URL.
261b6fd4 3678
e7cfd277
JD
36792011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3680
3681 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3682
a9b9b7f5
CY
36832011-11-21 Chong Yidong <cyd@gnu.org>
3684
3685 * window.c (Fnext_window, Fprevious_window): Doc fix.
3686
b0d15b4f
SM
36872011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3688
3689 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3690
fe7a3057
JB
36912011-11-20 Juanma Barranquero <lekktu@gmail.com>
3692
3693 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3694
d2999b1a
MR
36952011-11-20 Martin Rudalics <rudalics@gmx.at>
3696
3697 * window.c (Fset_window_combination_limit): Rename argument
3698 STATUS to LIMIT.
3699 (Vwindow_combination_limit): Remove "status" from doc-string.
3700
d5ff9cd0
AS
37012011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3702
3703 * m/ibms390.h: Remove.
3704 * m/ibms390x.h: Don't include "ibms390.h".
3705
a5bb9bd3
SM
37062011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3707
3708 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3709 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3710
cd1181db
JB
37112011-11-20 Juanma Barranquero <lekktu@gmail.com>
3712
3713 * casetab.c (Fset_case_table):
3714 * charset.c (Fcharset_after): Fix typos.
3715
615a3b8d 37162011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3717
17e845af
PE
3718 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3719 Otherwise, valgrind does not work on some platforms.
3720 Problem reported by Andreas Schwab in
6a0bf43d
PE
3721 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3722 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3723 is set, removing the need for VIRT_ADDRESS_VARIES.
3724 (PURE_P): Use a more-efficient implementation that needs just one
3725 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3726 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3727 to 4 (xorl, subq, cmpq, setbe).
3728 * alloc.c (pure): Always extern now, since that's the
3729 VIRT_ADDR_VARIES behavior.
3730 (PURE_POINTER_P): Use a single comparison, not two, for
3731 consistency with the new puresize.h.
3732 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3733 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3734 Remove VIRT_ADDR_VARIES no longer needed.
3735
f8fe6f96
EZ
37362011-11-19 Eli Zaretskii <eliz@gnu.org>
3737
3738 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3739 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3740 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3741 behave as if the cursor position were at the window margin.
3742
3743 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3744 and the cursor position is out of bounds, behave as if the cursor
3745 position were at the window margin. (Bug#10075)
3746
df05a53c
CY
37472011-11-18 Chong Yidong <cyd@gnu.org>
3748
3749 * window.c (Fwindow_combination_limit): Make first argument
3750 non-optional, since it is meaningless for live windows like the
3751 selected window.
61ccba97 3752
2071918e
DA
37532011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3754
3755 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3756
b50a28de
SM
37572011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3758
3759 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3760 (graft_intervals_into_buffer): Simplify.
3761
015137db
EZ
37622011-11-18 Eli Zaretskii <eliz@gnu.org>
3763
3764 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3765 hash values of the two rows.
3766 (copy_row_except_pointers): Preserve the used[] arrays and the
3767 hash values of the two rows. (Bug#10035)
68c95424 3768 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3769
3770 * xdisp.c (row_hash): New function, body extracted from
3771 compute_line_metrics.
3772 (compute_line_metrics): Call row_hash, instead of computing the
3773 hash code inline.
3774
3775 * dispnew.c (verify_row_hash): Call row_hash for computing the
3776 hash code of a row, instead of duplicating code from xdisp.c.
3777
3778 * dispextern.h (row_hash): Add prototype.
3779
a2addb04
TH
37802011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3781
3782 * frame.c (delete_frame): Don't delete the terminal when the last
3783 X frame is closed if emacs is built with GTK toolkit.
3784
df85d315
JB
37852011-11-17 Juanma Barranquero <lekktu@gmail.com>
3786
3787 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3788
a0c2d0ae
MR
37892011-11-17 Martin Rudalics <rudalics@gmx.at>
3790
3791 * window.c (Vwindow_splits): Rename to
3792 Vwindow_combination_resize. Suggested by Juri Linkov.
3793 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3794 of Vwindow_splits.
3795
58179cce
JB
37962011-11-16 Juanma Barranquero <lekktu@gmail.com>
3797
7877f373
JB
3798 * nsfns.m (Fns_font_name):
3799 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3800
b6f67890
MR
38012011-11-16 Martin Rudalics <rudalics@gmx.at>
3802
3803 * window.h (window): Rename slot "nest" to "combination_limit".
3804 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3805 (Fset_window_nest): Rename to Fset_window_combination_limit.
3806 (Vwindow_nest): Rename to Vwindow_combination_limit.
3807 (recombine_windows, make_parent_window, make_window)
3808 (Fsplit_window_internal, saved_window)
3809 (Fset_window_configuration, save_window_save): Rename all
3810 occurrences of window_nest to window_combination_limit.
3811
c7015153
JB
38122011-11-15 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * image.c (imagemagick_load_image): Fix typo.
3815
322ad6ec
EZ
38162011-11-14 Eli Zaretskii <eliz@gnu.org>
3817
3818 * xdisp.c (display_line): Move the call to
3819 highlight_trailing_whitespace before the call to
3820 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3821 faces of all the glyphs to compute ROW's hash value.
3822 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3823
f067b8ec
JB
38242011-11-14 Juanma Barranquero <lekktu@gmail.com>
3825
3826 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3827 just return (bug#10044).
3828
1e5b2111
EZ
38292011-11-12 Eli Zaretskii <eliz@gnu.org>
3830
7ef3cbd5
EZ
3831 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3832 with user-defined heap size. Bump the default size of the temacs
3833 heap to 27MB, to avoid memory warning when running temacs.
3834 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3835
1e5b2111
EZ
3836 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3837 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3838 (verify_row_hash) [XASSERTS]: New function.
3839 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3840 that the hash value of glyph rows is correct.
1e5b2111 3841
89d61221
MR
38422011-11-12 Martin Rudalics <rudalics@gmx.at>
3843
3844 * window.h (window): Remove splits slot.
3845 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3846 (Fdelete_other_windows_internal, make_parent_window)
3847 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3848 (Fset_window_configuration, save_window_save): Don't deal with
3849 split status of windows.
3850 (saved_window): Remove splits slot.
3851 (Vwindow_splits): Rewrite doc-string.
3852
97f18cc8
JD
38532011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3854
3855 * xfns.c (unwind_create_frame):
3856 * nsfns.m (unwind_create_frame):
3857 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3858 Vframe_list (Bug#9999).
3859
22a648b4
DA
38602011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3861
0b381c7e 3862 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3863
659afede
KH
38642011-11-11 Kenichi Handa <handa@m17n.org>
3865
3866 * callproc.c (Fcall_process): Set the member dst_multibyte of
3867 process_coding.
3868
9ac0394b
KH
38692011-11-11 Johan Bockgård <bojohan@gnu.org>
3870
3871 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3872 avoid a crash (bug#9496).
3873
2fbdc249
CY
38742011-11-09 Chong Yidong <cyd@gnu.org>
3875
3876 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3877 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3878
ac6b1f81
PE
38792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3882
09db192c
PE
38832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3884
3885 Avoid some portability problems by eschewing 'extern inline' functions.
3886 The trivial performance wins aren't worth the portability hassles; see
3887 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3888 et seq.
3889 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3890 (window_box_width, window_box_left, window_box_left_offset)
3891 (window_box_right, window_box_right_offset): Undo previous change,
3892 by removing the "extern"s.
3893 * intervals.c (adjust_intervals_for_insertion)
3894 (adjust_intervals_for_deletion): Undo previous change,
3895 making these static again.
3896 (offset_intervals, temp_set_point_both, temp_set_point)
3897 (copy_intervals_to_string): No longer inline.
3898 * xdisp.c (window_text_bottom_y, window_box_width)
3899 (window_box_height, window_box_left_offset)
3900 (window_box_right_offset, window_box_left, window_box_right)
3901 (window_box): No longer inline.
3902
105216ed
CY
39032011-11-08 Chong Yidong <cyd@gnu.org>
3904
3905 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3906 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3907 Signal an error if not a live window.
105216ed
CY
3908 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3909 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3910
ae9e237f
JB
39112011-11-07 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * lisp.h (syms_of_abbrev): Remove declaration.
3914 Reported by CHENG Gao <chenggao@royau.me>.
3915
c7aa8333
EZ
39162011-11-07 Eli Zaretskii <eliz@gnu.org>
3917
3918 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3919 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3920 of temacs in GUI mode.
3921
be7f5545
MR
39222011-11-07 Martin Rudalics <rudalics@gmx.at>
3923
3924 * window.h: Declare delete_all_child_windows instead of
3925 delete_all_subwindows.
3926 * window.c (Fwindow_nest, Fset_window_nest)
3927 (Fset_window_new_total, Fset_window_new_normal)
3928 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3929 (delete_all_subwindows): Rename to delete_all_child_windows.
3930 (Fdelete_other_windows_internal, Fset_window_configuration):
3931 Call delete_all_child_windows instead of delete_all_subwindows.
3932 * frame.c (delete_frame): Call delete_all_child_windows instead
3933 of delete_all_subwindows.
3934
ca78dc43
PE
39352011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3938 This is also needed for porting to any host where GC_MARK_STACK is
3939 not GC_MAKE_GCPROS_NOOPS.
3940 (which_symbols): Use it.
3941
a0241d01
KH
39422011-11-07 Kenichi Handa <handa@m17n.org>
3943
3944 * coding.c (coding_set_destination): Check coding->src_pos only
3945 when coding->src_object is a buffer (bug#9910).
3946
3947 * process.c (send_process): Set the member src_multibyte of coding
3948 to 0 (bug#9911) when sending a unibyte text.
3949
3950 * callproc.c (Fcall_process): Set the member src_multibyte of
3951 process_coding to 0 (bug#9912).
3952
a64bfdfa 39532011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3954
3955 * xmenu.c (cleanup_widget_value_tree): New function.
3956 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3957 calling free_menubar_widget_value_tree directly (Bug#9830).
3958
cb41b32a
PE
39592011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3960
3961 Fix some portability problems with 'inline'.
3962 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3963 (window_box_width, window_box_left, window_box_left_offset)
3964 (window_box_right, window_box_right_offset): Declare extern.
3965 Otherwise, these inline functions do not conform to C99 and
3966 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3967 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3968 * intervals.c (adjust_intervals_for_insertion)
3969 (adjust_intervals_for_deletion): Now extern, because otherwise the
3970 extern inline functions 'offset_intervals' couldn't refer to it.
3971 (static_offset_intervals): Remove.
3972 (offset_intervals): Rewrite using the old contents of
3973 static_offset_intervals. The old version didn't conform to C99
3974 because an extern inline function contained a reference to an
3975 identifier with static linkage.
3976
b7041366
AS
39772011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3978
3979 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3980 GC.
3981
88a37c4d
EZ
39822011-11-06 Eli Zaretskii <eliz@gnu.org>
3983
3984 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3985 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3986 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3987 return Qleft_to_right.
3988
49745b39
CY
39892011-11-06 Chong Yidong <cyd@gnu.org>
3990
3991 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3992 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3993 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3994 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3995 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3996 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3997 (Fwindow_vscroll): Doc fix.
3998 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3999 argument, since it makes no sense to pass a live window and for
4000 consistency with window-child.
4001
1f05cd82
CS
40022011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4003
4004 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4005 support MSVC.
4006
22610910
JR
40072011-11-05 Jason Rumney <jasonr@gnu.org>
4008
4009 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4010 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4011 fonts (Bug#6029).
4012 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4013 bitwise arithmetic preventing use of unicode-sip and non-truetype
4014 opentype fonts.
4015
a06776b2
EZ
40162011-11-05 Eli Zaretskii <eliz@gnu.org>
4017
3ad924ba
EZ
4018 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4019 "emacs"-only part.
4020
a06776b2
EZ
4021 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4022 initialization code to keep similarity to xfns.c after changes
4023 from 2011-11-05.
4024
c9e7db78
JD
40252011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4026
a97f8f3f
JD
4027 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4028 (unwind_create_frame): New function (Bug#9943).
4029 (Fx_create_frame): Restructure code to be more similar to the one in
4030 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4031 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4032 Move terminal->reference_count++ just before making the frame official
4033 (Bug#9943).
4034
4035 * nsterm.m (x_free_frame_resources): New function.
4036 (x_destroy_window): Move code to x_free_frame_resources.
4037
c9e7db78 4038 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4039 (Fx_create_frame, x_create_tip_frame):
4040 Move terminal->reference_count++ just before making the frame
75f1671a 4041 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4042 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4043
a6fc3b5c
EZ
40442011-11-05 Eli Zaretskii <eliz@gnu.org>
4045
4046 Support MSVC build with newer versions of Visual Studio.
4047 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4048 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4049 nt/gmake.defs.
4050
4051 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4052 which are not supported by MSVC.
4053 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4054 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4055 bitfields.
4056 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4057 types in bitfields.
4058 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4059
4060 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4061
58179cce 40622011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4063
4064 Support MSVC build with newer versions of Visual Studio.
4065 * w32.c: Don't include w32api.h for MSVC.
4066 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4067
4068 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4069 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4070 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4071 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4072 e_* cousins.
4073 (alloca) [_MSC_VER]: Define to _alloca.
4074
4075 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4076
4077 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4078
a58c13ed
EZ
40792011-11-04 Eli Zaretskii <eliz@gnu.org>
4080
4081 * xdisp.c (note_mouse_highlight): If either of
4082 previous/next-single-property-change returns nil, treat that as
4083 the beginning or the end of the buffer. (Bug#9955)
4084
fe0b6370
JD
40852011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4086
a58c13ed 4087 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4088 label is not null (Bug#9951).
4089 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4090 may be NULL.
4091
89bd5ee1
EZ
40922011-11-04 Eli Zaretskii <eliz@gnu.org>
4093
4094 * window.c (Fwindow_body_size): Mention in the doc string that the
4095 return value is in frame's canonical units. (Bug#9949)
4096
84c3edb9
EZ
40972011-11-03 Eli Zaretskii <eliz@gnu.org>
4098
4e2fb5c7
EZ
4099 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4100
84c3edb9 4101 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4102 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4103 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4104
bc17a887
EZ
41052011-11-01 Eli Zaretskii <eliz@gnu.org>
4106
4107 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4108 Don't stop backward scan on the continuation glyph, even though
4109 its CHARPOS is positive.
6d5eb5b0
SM
4110 (mouse_face_from_buffer_pos, note_mouse_highlight):
4111 Rename cover_string to disp_string.
bc17a887 4112
4ee88440
MR
41132011-11-01 Martin Rudalics <rudalics@gmx.at>
4114
4115 * window.c (temp_output_buffer_show): Don't use
4116 Vtemp_buffer_show_specifiers.
4117 (Vtemp_buffer_show_specifiers): Remove unused variable.
4118
c2ff3c02
EZ
41192011-10-30 Eli Zaretskii <eliz@gnu.org>
4120
4121 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4122 past the beginning of the current glyph matrix.
4123
58179cce 41242011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4125
4126 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4127 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4128 HAVE_GTK3 (Bug#9869).
b77a6a7f 4129
3b574623
JD
4130 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4131 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4132
b77a6a7f
JD
4133 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4134
4135 * xterm.c: Declare x_handle_net_wm_state to return int.
4136 (handle_one_xevent): Check if we are iconified but don't have
4137 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4138 (get_current_wm_state): Return non-zero if not hidden,
4139 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4140 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4141 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4142 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4143
196e41e4
PE
41442011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4147 so that this new function doesn't get optimized away by a
4148 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4149
021f2e1a
AS
41502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4151
4152 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4153
8b058d44
EZ
41542011-10-29 Eli Zaretskii <eliz@gnu.org>
4155
4156 Fix the `xbytecode' command.
4157 * .gdbinit (xprintbytestr): New command.
b50a28de 4158 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4159 (xbytecode): Print the byte-code string as well.
4160
4452fb80
EZ
41612011-10-29 Kim Storm <storm@cua.dk>
4162
8b058d44
EZ
4163 * alloc.c (which_symbols): New function.
4164
21b72067
AS
41652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4166
4167 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4168 line. (Bug#9903)
4169
83ed7b5c
GM
41702011-10-29 Glenn Morris <rgm@gnu.org>
4171
4172 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4173 Not clear what it was for, and it causes various bugs. (Bug#9839)
4174
5a7a728b
EZ
41752011-10-28 Eli Zaretskii <eliz@gnu.org>
4176
4177 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4178 possible random value that matches one of those tested as
4179 condition to clear the mouse face.
4180
d3d0842f
CY
41812011-10-28 Chong Yidong <cyd@gnu.org>
4182
4183 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4184
31b39d13
DN
41852011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4186
4187 * window.c (make_window): Initialize phys_cursor_on_p.
4188
9aba6043
SM
41892011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4190
4191 * lisp.h (struct Lisp_Symbol): Update comments.
4192
c20992f4
JB
41932011-10-28 Juanma Barranquero <lekktu@gmail.com>
4194
4195 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4196
db4f02f2
EZ
41972011-10-28 Eli Zaretskii <eliz@gnu.org>
4198
4199 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4200 <oslsachem@gmail.com> for helping to debug this.
4201
4202 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4203 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4204 (g_b_init_get_glyph_outline_w): New static variables.
4205 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4206 (GetGlyphOutlineW_Proc): New typedefs.
4207 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4208 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4209 New functions.
4210 (w32font_open_internal, compute_metrics):
4211 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4212 instead of calling the "wide" APIs directly.
4213
4214 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4215
4216 * w32.h (syms_of_w32font): Add prototype.
4217
87e68db4
JB
42182011-10-27 Juanma Barranquero <lekktu@gmail.com>
4219
4220 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4221 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4222 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4223 (Fmove_to_window_line): Doc fix.
4224
435c1d67
CY
42252011-10-27 Chong Yidong <cyd@gnu.org>
4226
4227 * process.c (make_process): Set gnutls_state to NULL.
4228
4229 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4230 non-NULL, regardless of GNUTLS_INITSTAGE.
4231 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4232 an error. Set process slots as soon as we allocate them.
4233
4234 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4235
9c6c6f49
CY
42362011-10-27 Chong Yidong <cyd@gnu.org>
4237
9aba6043
SM
4238 * gnutls.c (emacs_gnutls_deinit): New function.
4239 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4240 (Fgnutls_deinit, Fgnutls_boot): Use it.
4241
4242 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4243 (deactivate_process): Call emacs_gnutls_deinit.
4244
657d08d3
JB
42452011-10-27 Juanma Barranquero <lekktu@gmail.com>
4246
4247 * image.c (x_create_x_image_and_pixmap):
4248 * w32.c (sys_rename, w32_delayed_load):
4249 * w32font.c (fill_in_logfont):
4250 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4251
5430d399
JB
42522011-10-26 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * w32fns.c (w32_default_color_map): New function,
4255 extracted from Fw32_default_color_map.
a7ef684b 4256 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4257
fe0055fa
PE
42582011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4261
e6346438
SM
42622011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4263
4264 * keyboard.c (test_undefined): New function (bug#9751).
4265 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4266
e112cc37
ET
42672011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4268
4269 * sysdep.c (init_sys_modes): Fix the check for the controlling
4270 terminal (Bug#6649).
4271
7b5d6677
EZ
42722011-10-20 Eli Zaretskii <eliz@gnu.org>
4273
4274 * dispextern.h (struct bidi_it): New member next_en_type.
4275
4276 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4277 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4278 current character, check also for next_en_type being WEAK_EN.
4279 (bidi_resolve_weak): Don't enter the expensive loop if the current
4280 position is before next_en_pos. Record the bidi type of the first
4281 non-ET, non-BN character we find, in addition to its position.
4282 (bidi_level_of_next_char): Invalidate next_en_type when
4283 next_en_pos is over-stepped.
4284
7da0b018
PE
42852011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4288 * editfns.c: Rewrite current-time-zone so that it invokes
4289 the equivalent of (format-time-string "%Z") to get the time zone name.
4290 This fixes a bug when the time zone name contains characters that
4291 need converting from the system time locale to Emacs internal format.
4292 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4293 that patch fixed format-time-string to do the conversion, but
4294 I forgot to fix current-time-zone.
4295 (format_time_string): New function, containing most of
4296 what Fformat_time_string used to contain.
4297 (Fformat_time_string): Rewrite in terms of format_time_string.
4298 This doesn't change this function's behavior.
4299 (current-time-zone): Rewrite to use format_time_string.
4300 This fixes the bug reported by Michael Schierl in
4301 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4302 Jason Rumney's 2007-06-07 change worked around this bug, but
4303 didn't fix it.
4304 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4305
8547b010
EZ
43062011-10-19 Eli Zaretskii <eliz@gnu.org>
4307
4308 * xdisp.c (start_display): If the character at POS is displayed
4309 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4310 (try_window_reusing_current_matrix): If a line ends in a display
4311 vector or the next line starts in a display vector, continue
4312 redrawing the window even though the character position of
4313 start_row was reached.
8547b010
EZ
4314 (Bug#9771, part 2)
4315
4e948d15
CY
43162011-10-18 Chong Yidong <cyd@gnu.org>
4317
4318 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4319 with nobreak-char-display too.
4320
4787455f
EZ
43212011-10-18 Eli Zaretskii <eliz@gnu.org>
4322
4323 Fix part 3 of bug#9771.
4324 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4325 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4326 non-neutral characters if the current character is a paragraph
4327 separator (a.k.a. Newline). This avoids running the same
4328 expensive loop twice, once when we consume the preceding newline
4329 and the other time when the line actually needs to be displayed.
4330 Avoid the loop when we see neutrals on the base embedding level
4331 following a character whose directionality is the same as the
4332 paragraph's. This avoids running the expensive loop when a line
4333 ends in a long sequence of neutrals, like control characters.
4334 Add assertion against STRONG_AL type. Slightly rearrange code
4335 that determines the type of a neutral given the first non-neutral
4336 that follows it.
4337 (bidi_level_of_next_char): Set next_en_pos to zero when
4338 invalidating its info.
4339
2c91f553
EZ
43402011-10-17 Eli Zaretskii <eliz@gnu.org>
4341
4342 * xdisp.c (push_display_prop): Determine whether to record string
4343 or buffer position by IT->string, not by IT->method. Allow
4344 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4345 (move_it_vertically_backward): Don't look for character position
4346 immediately after the newline when in a continuation line.
4347 (Bug#9771, part 1)
2c91f553 4348
c7b08b0d
MR
43492011-10-15 Martin Rudalics <rudalics@gmx.at>
4350
4351 * window.c (coordinates_in_window): Rewrite and delabelize
4352 vertical border check. (Bug#5357) (Bug#9618)
4353
6b02f655
SM
43542011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4355
4356 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4357 errors in XSetWindowBorder (bug#9310).
4358
81d40c92
DA
43592011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4360
4361 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4362 avoid crash when xmalloc overrun checking is enabled.
4363
d4172c3b
EZ
43642011-10-13 Eli Zaretskii <eliz@gnu.org>
4365
4366 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4367 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4368 cursor motion with <left> and <right> arrow keys.
4369
4370 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4371 some callers set that themselves.
4372
b00eea75
EZ
43732011-10-12 Eli Zaretskii <eliz@gnu.org>
4374
4375 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4376 display string and the previous row comes from the same string and
4377 is empty. (Bug#9739) (Bug#9738)
4378
8fe012c4
SM
43792011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4380
4381 * doc.c (get_doc_string): Encode file name (bug#9735).
4382
0074aef2
EZ
43832011-10-12 Eli Zaretskii <eliz@gnu.org>
4384
79beb178
EZ
4385 * bidi.c (bidi_level_of_next_char):
4386 * xdisp.c (get_visually_first_element): Remove old incorrect
4387 comments regarding the Unicode Line Separator character.
4388
0074aef2
EZ
4389 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4390
6e4b3fbe
DA
43912011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4392
4393 * alloc.c (Fgc_status): Do not access beyond zombies array
4394 boundary if nzombies > MAX_ZOMBIES.
4395 * alloc.c (dump_zombies): Add missing format specifier.
4396
0324f3af
PE
43972011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4398
b5525cac
PE
4399 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4400 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4401
0324f3af
PE
4402 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4403 Some packages use them to denote characters with modifiers.
4404
e9b5f888
AS
44052011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4406
4407 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4408 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4409 matching a pp-number. Rename parameter var to var1.
4410
127827c0
SM
44112011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4412
4413 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4414
c8fd3bd0
GM
44152011-10-08 Glenn Morris <rgm@gnu.org>
4416
4417 * callint.c (Fcall_interactively): Give a more explicit error for the
4418 'c' case with a non-character input. (Bug#8479)
4419
352ec8ff
EZ
44202011-10-08 Eli Zaretskii <eliz@gnu.org>
4421
03669ccb
EZ
4422 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4423 lines.
7061c986
EZ
4424 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4425 lines that are hscrolled on the left.
03669ccb 4426
352ec8ff
EZ
4427 * dispnew.c (buffer_posn_from_coords): Account for a possible
4428 presence of header-line. (Bug#4426)
4429
a66cfb1c
SM
44302011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4431
6b02f655
SM
4432 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4433 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4434
7c5ee88e
PE
44352011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4438 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4439 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4440 this makes Emacs dump core during garbage collection on rare
4441 occasions. sizeof is obviously inferior to offsetof here, so
4442 stick with offsetof.
4443 (GC_POINTER_ALIGNMENT): New macro.
4444 (mark_memory): Omit 3rd (offset) arg; caller changed.
4445 Don't assume EMACS_INT alignment is the same as pointer alignment.
4446
df1bbe5b
SM
44472011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4448
4449 * keyboard.c (read_key_sequence_remapped): New var.
4450 (read_key_sequence): Compute remapping in the right buffer.
4451 (command_loop_1): Use read_key_sequence's remapping directly.
4452
51553db6
SM
44532011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4454
32c1fffd
SM
4455 * dired.c (file_name_completion): Don't expand file name.
4456 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4457 before checking file name handler.
4458
51553db6
SM
4459 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4460 they've been requested explicitly (bug#9591).
4461
b6bd1599 44622011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4463
4464 * keymap.c (Fsingle_key_description): Use make_specified_string
4465 instead of build_string to build string from push_key_description.
4466 (Bug#5193)
4467
f701dc2a
PE
44682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4469
4222c55d
PE
4470 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4471 This fixes a Y2038 bug on 64-bit hosts.
4472 * buffer.c (reset_buffer):
4473 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4474 (Fclear_buffer_auto_save_failure):
4475 Use 0, not -1, to represent an unset failure time, since time_t
4476 might not be signed.
4477
f701dc2a
PE
4478 Remove dependency on glibc malloc internals.
4479 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4480 Move back here from lisp.h, but with their new implementations.
4481 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4482 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4483 * charset.c (charset_table_init): New static var.
4484 (syms_of_charset): Use it instead of xmalloc. This removes a
4485 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4486 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4487 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4488 Move back to alloc.c.
4489 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4490 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4491
9ceebf39
JD
44922011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4493
4494 * nsterm.m (windowDidResize): Call x_set_window_size only when
4495 ns_in_resize is true. Otherwise set pixelwidth/height and
4496 call change_frame_size (Bug#9628).
4497
cb993c58
PE
44982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4499
3930c88b
PE
4500 Port --enable-checking=all to Fedora 14 x86-64.
4501 * charset.c (syms_of_charset): Also account for glibc malloc's
4502 internal overhead when calculating the initial malloc maximum.
4503
cb993c58
PE
4504 Port --enable-checking=all to Fedora 14 x86.
4505 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4506 Move to lisp.h.
4507 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4508 (overrun_check_realloc, overrun_check_free):
4509 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4510 That way, xmalloc returns a properly-aligned pointer even if
4511 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4512 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4513 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4514 into account when calculating the initial malloc maximum.
4515 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4516 Move here from alloc.c, so that charset.c can use it too.
4517 Properly align; the old code wasn't right for common 32-bit hosts
4518 when configured with --enable-checking=all.
4519 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4520 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4521
31bed486
EZ
45222011-09-29 Eli Zaretskii <eliz@gnu.org>
4523
04c70788 4524 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4525 use EDOM.
4526
fbcaa2f3
EZ
45272011-09-28 Eli Zaretskii <eliz@gnu.org>
4528
4529 * xdisp.c (compute_display_string_end): If there's no display
4530 string at CHARPOS, return -1.
4531
4532 * bidi.c (bidi_fetch_char): When compute_display_string_end
4533 returns a negative value, treat the character as a normal
4534 character not covered by a display string. (Bug#9624)
4535
a239d4e9
JB
45362011-09-28 Juanma Barranquero <lekktu@gmail.com>
4537
4538 * lread.c (Fread_from_string): Fix typo in docstring.
4539
88652fd5
EZ
45402011-09-27 Eli Zaretskii <eliz@gnu.org>
4541
4542 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4543 newline, reseat the iterator instead of bidi-iterating there one
4544 character at a time. (Bug#9610)
32c1fffd
SM
4545 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4546 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4547
ed497dd4
AS
45482011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4549
4550 * lread.c (readevalloop): Use correct code for NBSP.
4551 (read1): Likewise. (Bug#9608)
4552
b2bf61aa
MA
45532011-09-25 Michael Albinus <michael.albinus@gmx.de>
4554
4555 * dbusbind.c (Fdbus_register_signal): When service is not
4556 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4557
32bbb17c
GM
45582011-09-25 Glenn Morris <rgm@gnu.org>
4559
4560 * buffer.c (truncate-lines): Doc fix.
4561
94e0933e
CY
45622011-09-24 Chong Yidong <cyd@stupidchicken.com>
4563
4564 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4565 (Fset_window_next_buffers): Doc fix.
4566
cddde921
GM
45672011-09-24 Glenn Morris <rgm@gnu.org>
4568
4569 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4570
1260aef1
PE
45712011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4572
25b4bfa0
PE
4573 Fix minor problems found by static checking.
4574 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4575 * indent.c (Fvertical_motion): Fix == vs = typo.
4576
e3cbd34b
EZ
45772011-09-24 Eli Zaretskii <eliz@gnu.org>
4578
a66cfb1c
SM
4579 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4580 Default value is now t. Doc fix.
6bf7006f 4581
e3cbd34b 4582 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4583 logic when moving up, not only when moving down. Fix the
e3cbd34b 4584 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4585 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4586
4587 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4588 CHARPOS is covered by a display string which includes newlines.
4589 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4590 is covered by a display string with embedded newlines.
4591
a3de0cbd
MA
45922011-09-24 Michael Albinus <michael.albinus@gmx.de>
4593
4594 * dbusbind.c (Fdbus_register_signal): Add match rule to
4595 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4596 (Fdbus_register_method, Vdbus_registered_objects_table):
4597 Fix docstring.
a3de0cbd 4598
b260039d
JM
45992011-09-24 Jim Meyering <meyering@redhat.com>
4600
32c1fffd 4601 do not ignore write error for any output size
b260039d
JM
4602 The previous change was incomplete.
4603 While it makes emacs --batch detect the vast majority of stdout
4604 write failures, errors were still ignored whenever the output size is
4605 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4606 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4607 && echo FAIL: ignored write error
4608 FAIL: ignored write error
4609 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4610 && echo FAIL: ignored write error
4611 FAIL: ignored write error
4612 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4613
8eca8a7c
AS
46142011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4615
4616 * emacs.c (Fkill_emacs): In noninteractive mode exit
4617 non-successfully if a write error occurred on stdout. (Bug#9574)
4618
3341db62
EZ
46192011-09-21 Eli Zaretskii <eliz@gnu.org>
4620
4621 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4622 the xassert test.
4623
4624 * dispextern.h (struct it): Update the comment documenting what
4625 can it->OBJECT be.
4626
8c203dbf
EZ
46272011-09-20 Eli Zaretskii <eliz@gnu.org>
4628
4629 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4630 a display string, extend search for cursor position to end of row.
4631 (find_row_edges): If the row ends in a newline from a display
4632 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4633 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4634 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4635 non-empty line. Fixes confusing cursor motion with arrow keys at
4636 the beginning of a line that starts with whitespace.
8c203dbf 4637
a4824228
LMI
46382011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4639
4640 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4641 (bug#9493).
4642
33ed493b
CY
46432011-09-18 Chong Yidong <cyd@stupidchicken.com>
4644
4645 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4646 boolean (Bug#9154).
4647
56cd55c8
EZ
46482011-09-18 Eli Zaretskii <eliz@gnu.org>
4649
4650 * xdisp.c (display_line): Record maximum and minimum buffer
4651 positions even if no glyphs were produced (e.g., by a zero-width
4652 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4653 buffer positions that will be removed from the glyph row because
4654 they don't fit.
c02dcedf
EZ
4655 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4656 column is beyond frame width: don't subtract 1 "pixel" when
4657 computing width of the stretch.
3e62b7e0
EZ
4658 (reseat_at_next_visible_line_start): Undo the change made on
4659 2011-09-17 that saved paragraph information and restored it after
4660 the call to `reseat'. (Bug#9545)
56cd55c8 4661
5ed99d36 46622011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4663
4664 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4665 and turn window cursor on if cleared (Bug#9415).
4666
5ed99d36 46672011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4668
4669 * search.c (boyer_moore): Take unibyte characters from pattern
4670 literally. (Bug#9458)
4671
9bade7b2
EZ
46722011-09-18 Eli Zaretskii <eliz@gnu.org>
4673
4674 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4675
e5e9d610
PE
46762011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4677
87e4427a
PE
4678 Fix minor problem found by static checking.
4679 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4680 initialized, to pacify gcc -Wuninitialized.
4681
e5e9d610
PE
4682 * fileio.c: Report proper errno when syscall falls.
4683 (Finsert_file_contents): Save and restore errno,
4684 so that report_file_error outputs the correct diagnostic.
4685 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4686
a1674f0b
EZ
46872011-09-18 Eli Zaretskii <eliz@gnu.org>
4688
4689 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4690
fbfb6dd4
EZ
46912011-09-17 Eli Zaretskii <eliz@gnu.org>
4692
4693 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4694 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4695
bb187662
EZ
46962011-09-17 Eli Zaretskii <eliz@gnu.org>
4697
1137e8b8 4698 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4699 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4700
4701 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4702 (bidi_find_paragraph_start): Search back for paragraph beginning
4703 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4704 (bidi_move_to_visually_next): Only trigger paragraph-related
4705 computations when the last character is a newline or at EOB, not
4706 just any NEUTRAL_B. (Bug#9470)
4707
bb187662
EZ
4708 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4709 truncated lines if point is covered by a display string. (Bug#9524)
4710
2e621251
PE
47112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4712
4713 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4714 (cons_to_x_long): New function.
4715 (lisp_data_to_selection_data): Use it. Correct the test for
4716 short-versus-long data; it was negated. Break out of vector
4717 loop, for efficiency, when a long datum is discovered.
4718
91a15bc6
SM
47192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4720
4721 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4722
b41c3a35
EZ
47232011-09-16 Eli Zaretskii <eliz@gnu.org>
4724
4725 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4726 GCC PR/17406) by declaring this function with external scope.
4727
7812ba2d
PE
47282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4729
4730 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4731 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4732
cf7edc2a
AS
47332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4734
4735 * editfns.c (Fformat): Correctly handle text properties on "%%".
4736
bd01620e
EZ
47372011-09-15 Eli Zaretskii <eliz@gnu.org>
4738
4739 * xterm.c (x_draw_composite_glyph_string_foreground):
4740 * w32term.c (x_draw_composite_glyph_string_foreground):
4741 * term.c (encode_terminal_code):
4742 * composite.c (composition_update_it, get_composition_id):
4743 * xdisp.c (get_next_display_element)
4744 (fill_composite_glyph_string): Add comments about special meaning
4745 of TAB characters in a composition.
4746
a02719a3
PE
47472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4748
4749 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4750 This occurs when processing a multibyte format.
4751 Problem reported by Wolfgang Jenker.
a02719a3 4752
72589a3c
JB
47532011-09-15 Johan Bockgård <bojohan@gnu.org>
4754
4755 * xdisp.c (try_cursor_movement): Only check for exact match if
4756 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4757
1c14176c
PE
47582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4759
4760 Remove unused external symbols.
4761 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4762 * xdisp.c (calc_pixel_width_or_height): Now static.
4763 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4764 * indent.c (check_display_width):
4765 * w32term.c: Fix comment to match code.
4766 * xterm.c, xterm.h (x_catching_errors): Remove.
4767
d2eea5b5
PE
47682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4769
4770 * xselect.c: Use signed conversions more consistently (Bug#9498).
4771 (selection_data_to_lisp_data): Assume incoming selection data are
4772 signed integers, not unsigned. This is to be consistent with
4773 outgoing selection data, which was modified to use signed integers
4774 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4775 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4776 expects long, not unsigned long.
4777
46888499
EZ
47782011-09-14 Eli Zaretskii <eliz@gnu.org>
4779
4780 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4781 computation of loop end. Reported by Johan Bockgård
4782 <bojohan@gnu.org>.
4783
ef8ef9fb
CY
47842011-09-13 Chong Yidong <cyd@stupidchicken.com>
4785
4786 * frame.c (Fother_visible_frames_p): Function deleted.
4787
fa819fed
EZ
47882011-09-12 Eli Zaretskii <eliz@gnu.org>
4789
4790 * indent.c (compute_motion): Process display vector front to back
4791 rather than the other way around. (Bug#2496)
4792
2ba8e008
SM
47932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4794
4795 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4796
20f53c69
CY
47972011-09-11 Chong Yidong <cyd@stupidchicken.com>
4798
4799 * minibuf.c (Fread_from_minibuffer): Doc fix.
4800
d562d7a4
EZ
48012011-09-11 Eli Zaretskii <eliz@gnu.org>
4802
4803 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4804 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4805
1c4d7f3d
LMI
48062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4807
4808 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4809 value for non-existent files.
4810
b885bf36
EZ
48112011-09-11 Eli Zaretskii <eliz@gnu.org>
4812
4813 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4814 set its "size" to -1. This will set the modtime_size field of
4815 the corresponding buffer to -1, which is what
4816 verify-visited-file-modtime expects for files that do not exist.
4817 (Bug#9139)
4818
6612f0bf
PE
48192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4820
4821 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4822 here ...
4823 * lisp.h: ... from here. push_key_description is no longer
4824 defined in keyboard.c, so its declaration should not be in
4825 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4826 logically belongs with push_key_description.
4827
dfb3f755
PE
48282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4829
4830 * buffer.h: Include <sys/types.h> instead of <time.h>.
4831 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4832 Problem reported by Herbert J. Skuhra.
4833
3134906c
LMI
48342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4835
4836 * xml.c (parse_region): Make the parsing work for
4837 non-comment-starting XML files again (bug#9144).
4838
8d903f4e
AS
48392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4840
4841 * image.c (gif_load): Fix calculation of bottom and right corner.
4842 (Bug#9468)
4843
80ad64f4
EZ
48442011-09-10 Eli Zaretskii <eliz@gnu.org>
4845
4846 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4847 redisplay in small windows.
4848
208a048d
EZ
48492011-09-09 Eli Zaretskii <eliz@gnu.org>
4850
4851 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4852
9b1c252e
MR
48532011-09-08 Martin Rudalics <rudalics@gmx.at>
4854
4855 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4856 Operate on live windows only.
4857
2949f33b
JB
48582011-09-08 Juanma Barranquero <lekktu@gmail.com>
4859
4860 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4861
e08dcafd
EZ
48622011-09-07 Eli Zaretskii <eliz@gnu.org>
4863
4864 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4865 only under bidi iteration.
4866
115b96bd
JD
48672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4868
4869 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4870
c8199d0f
PE
48712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4872
4873 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4874 Without this fix, the command to link temacs failed due to an
4875 undefined symbol __builtin_isnan. This is because
4876 /usr/include/iso/math_c99.h #defines isnan(x) to
4877 __builtin_isnan(x), but the bundled gcc, which identifies itself
4878 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4879 a __builtin_isnan.
4880 * floatfns.c (isnan): #undef, and then #define to a clone of
4881 what's in data.c.
4882 (Fisnan): Always define, since it's always available now.
4883 (syms_of_floatfns): Always define isnan at the Lisp level.
4884
e39b275c 48852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4886
4887 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4888
b2db44d9 48892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4890
f4af5137 4891 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4892 The previous code assumed that file offsets (off_t values) fit in
4893 EMACS_INT variables, which is not true on typical 32-bit hosts.
4894 The code messed up by falsely reporting buffer overflow in cases
4895 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4896 when "big" contains more than 2**29 bytes, even though this
4897 inserts just one byte and does not overflow the buffer.
4898 (Finsert_file_contents): Store file offsets as off_t
4899 values, not as EMACS_INT values. Check for overflow when
4900 converting between EMACS_INT and off_t. When checking for
4901 buffer overflow or for overlap, take the offsets into account.
4902 Don't use EMACS_INT for small values where int suffices.
4903 When checking for overlap, fix a typo: ZV was used where
4904 ZV_BYTE was intended.
4905 (Fwrite_region): Don't assume off_t fits into 'long'.
4906 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4907
ecfc0a49
MA
49082011-09-05 Michael Albinus <michael.albinus@gmx.de>
4909
4910 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4911
6511acf2 49122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4913
0999621a 4914 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4915
4916 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4917 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4918 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4919 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4920 (modify_event_symbol): Do not assume that the length of
4921 name_alist_or_stem is safe to alloca and fits in int.
4922 (Fexecute_extended_command): Likewise for function name and binding.
4923 (Frecursion_depth): Wrap around reliably on integer overflow.
4924 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4925 since some callers pass EMACS_INT values.
4926 (Fsingle_key_description): Don't crash if symbol name contains more
4927 than MAX_ALLOCA bytes.
4928 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4929 (get_minibuffer): Arg is now EMACS_INT, not int.
4930 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4931 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4932 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4933
2be7d702
PE
4934 * dbusbind.c (signature_cat): New function.
4935 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4936 Do not overrun buffer; instead, report string overflow.
4937
9d1df220
PE
4938 * dispnew.c (add_window_display_history): Don't overrun buffer.
4939 Truncate instead; this is OK since it's just a log.
4940
33ef5c64
PE
4941 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4942 even if the time zone offset is outlandishly large.
4943 Don't mishandle offset == INT_MIN.
4944
66c6fdd5
PE
4945 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4946 when creating daemon; the previous buffer-overflow check was incorrect.
4947
d749b01b
PE
4948 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4949 which has the guts of the old verror function.
4950
b5cd1905
PE
4951 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4952 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4953
6e1a67fb
PE
4954 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4955 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4956 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4957 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4958 length of string rather than counting it via multiple sprintfs;
4959 that's simpler and more reliable.
c21721cc
PE
4960 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4961 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4962 sprintf, in case result does not fit in int.
4963
c57b67fc
PE
4964 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4965 (fontset_from_font): Print it.
4966
8a401434
PE
4967 * frame.c (tty_frame_count): Now printmax_t, not int.
4968 (make_terminal_frame, set_term_frame_name): Print it.
4969 (x_report_frame_params): In X, window IDs are unsigned long,
4970 not signed long, so print them as unsigned.
4971 (validate_x_resource_name): Check for implausibly long names,
4972 and don't assume name length fits in 'int'.
4973 (x_get_resource_string): Don't blindly alloca invocation name;
4974 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4975 not fit in int.
4976
6e1a67fb
PE
4977 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4978 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4979 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4980
0df02bf3
PE
4981 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4982 Use esprintf, not sprintf, in case result does not fit in int.
4983
48e30793
PE
4984 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4985 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4986 it as a large positive number.
4987 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4988 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4989
a66ff6d8
PE
4990 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4991 in case result does not fit in int.
4992
aca216ff
PE
4993 * print.c (float_to_string): Detect width overflow more reliably.
4994 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4995 buffer overrun. Don't assume list length fits in 'int'. Treat
4996 print length of 0 as 0, not as infinity; to be consistent with other
4997 uses of print length in this function. Don't overflow print length
4998 index. Don't assume hash table size fits in 'long', or that
4999 vectorlike size fits in 'unsigned long'.
5000
31c286f7
PE
5001 * process.c (make_process): Use printmax_t, not int, to format
5002 process-name gensyms.
5003
55e5faa1
PE
5004 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5005
80f2e268
PE
5006 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5007 to avoid potential buffer overrun.
5008
670741ab
PE
5009 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5010 if X resource line is longer than 512 bytes.
5011
b7163a50
PE
5012 * xfns.c (x_window): Make sprintf buffer a bit bigger
5013 to avoid potential buffer overrun.
5014
ae58ff1f
PE
5015 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5016
c43c8a6a
PE
5017 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5018
3f8236f4
PE
50192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5020
53e9fe90 5021 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5022 Without these, Emacs silently mishandles large integers sometimes.
5023 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5024 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5025
6511acf2
PE
5026 * xdisp.c (try_window_id): Check Emacs fixnum range before
5027 converting to 'int'.
806add1d 5028
6511acf2 5029 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5030 Check that an Emacs fixnum is in range before assigning it to 'int'.
5031 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5032 values converted from Emacs fixnums.
5033 (Frecenter): Don't wrap around a line count if it is out of 'int'
5034 range; instead, treat it as an extreme value.
5035 (Fset_window_configuration, compare_window_configurations):
5036 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5037
6511acf2
PE
5038 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5039 that can exceed INT_MAX. Check that EMACS_INT value is in range
5040 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5041 (match_limit): Don't assume that a fixnum can fit in 'int'.
5042
6511acf2 5043 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5044 exceed INT_MAX.
5045
6511acf2 5046 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5047 (Fvertical_motion): Don't wrap around LINES values that don't fit
5048 in 'int'. Instead, treat them as extreme values. This is good
5049 enough for windows, which can't have more than INT_MAX lines anyway.
5050
fcb901a7
LMI
50512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5052
0f2f6b6d
LMI
5053 * Require libxml/parser.h to avoid compilation warning.
5054
fcb901a7
LMI
5055 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5056
5057 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5058 since this reportedly can destroy thread storage.
5059
6e20a0d4
CY
50602011-08-30 Chong Yidong <cyd@stupidchicken.com>
5061
5062 * syntax.c (find_defun_start): Update all cache variables if
5063 exiting early (Bug#9401).
5064
148ae00e
EZ
50652011-08-30 Eli Zaretskii <eliz@gnu.org>
5066
f6cfbd8f
EZ
5067 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5068
148ae00e
EZ
5069 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5070 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5071 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5072
5073 * term.c (tty_append_glyph): New function.
5074 (produce_stretch_glyph): Static function and its prototype deleted.
5075
a66cfb1c
SM
5076 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5077 Add prototypes.
148ae00e 5078
c4a07a4c
PE
50792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5080
5081 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5082 when checking :margin (Bug#9390).
5083 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5084 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5085 so that the name doesn't mislead. All uses changed.
5086
6bc8cd65
JB
50872011-08-28 Johan Bockgård <bojohan@gnu.org>
5088
5089 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5090 set_tty_hooks.
5091
dca4927e
EZ
50922011-08-27 Eli Zaretskii <eliz@gnu.org>
5093
5094 * xdisp.c (move_it_to): Don't bail out early when reaching
5095 position beyond to_charpos, if we are scanning backwards.
5096 (move_it_vertically_backward): When DY == 0, make sure we get to
5097 the first character in the line after the newline.
5098
f2cad773
PE
50992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5100
5101 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5102 (ccl_driver): Do not generate an out-of-range pointer.
5103 (Fccl_execute_on_string): Remove unnecessary check for
5104 integer overflow, noted by Stefan Monnier in
5105 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5106 Remove a FIXME that didn't need fixing.
5107 Simplify the newly-introduced buffer reallocation code.
5108
0cae2cdb
JB
51092011-08-27 Juanma Barranquero <lekktu@gmail.com>
5110
5111 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5112
5fc295a4 51132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5114
70c60eb2 5115 Integer and memory overflow issues (Bug#9196).
726e0ab1 5116
d31850da
PE
5117 * doc.c (get_doc_string): Rework so that
5118 get_doc_string_buffer_size is the actual buffer size, rather than
5119 being 1 less than the actual buffer size; this makes xpalloc more
5120 convenient.
5121
a69fbedb
PE
5122 * image.c (x_allocate_bitmap_record, cache_image):
5123 * xselect.c (Fx_register_dnd_atom):
5124 Simplify previous changes by using xpalloc.
5125
fe5c5d37
PE
5126 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5127 since either will do and ptrdiff_t is convenient with xpalloc.
5128
0065d054
PE
5129 * charset.c (charset_table_size)
5130 (struct charset_sort_data.priority): Now ptrdiff_t.
5131 (charset_compare): Don't overflow if priorities differ greatly.
5132 (Fsort_charsets): Don't assume list length fits in int.
5133 Check for size-calculation overflow when allocating sort data.
5134 (syms_of_charset): Allocate an initial charset table that is
5135 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5136
5137 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5138
5139 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5140 The actual value is always <= INT_MAX, and leaving it unsigned made
5141 overflow checking harder.
5142
5143 * dispextern.h (struct glyph_matrix.rows_allocated)
5144 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5145 with xpalloc. The values are still always <= INT_MAX.
5146
5147 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5148
5149 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5150 (SAFE_NALLOCA): New macro.
5151
5152 * region-cache.c (struct boundary.pos, find_cache_boundary)
5153 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5154 (set_cache_region, invalidate_region_cache)
5155 (revalidate_region_cache, know_region_cache, region_cache_forward)
5156 (region_cache_backward, pp_cache):
5157 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5158 so that ptrdiff_t * can be passed to xpalloc.
5159 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5160 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5161 (pp_cache): Don't assume cache_len fits in int.
5162 * region-cache.h: Adjust extern decls to match.
5163
5164 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5165 EMACS_INT, since either will do, for xpalloc.
5166
5167 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5168 (xnmalloc, xnrealloc, xpalloc): New functions.
5169
726e0ab1
PE
5170 * bidi.c (bidi_shelve_header_size): New constant.
5171 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5172 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5173
51f30bc5 5174 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5175 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5176 (overlay_strings):
5177 Don't update size of array until after memory allocation succeeds,
5178 because xmalloc/xrealloc may not return.
0065d054
PE
5179 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5180 now that we have proper integer overflow checking.
5181 (record_overlay_string, overlay_strings): Catch overflows when
5182 calculating size of overlay_str_buf.
726e0ab1 5183
0065d054
PE
5184 * callproc.c (Fcall_process): Check for size overflow when
5185 calculating size of args2.
5186 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5187 Normally we prefer signed values, but sticking with ptrdiff_t would
5188 require adding more-complicated checks.
726e0ab1
PE
5189
5190 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5191 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5192 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5193 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5194
5195 * character.c (Fstring): Check for size-calculation overflow.
5196
5197 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5198 unnecessary integer overflow. Check for size overflow.
5199 (encode_coding_object): Don't update size until xmalloc succeeds.
5200
5201 * composite.c (get_composition_id): Check for overflow in glyph
5202 length calculations.
5203
5204 Integer and memory overflow fixes for display code.
5205 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5206 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5207 (scrolling_window): Check for overflow in size calculations.
5208 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5209 Don't assume glyph table len fits in int.
5210 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5211 (row_table_size): Now ptrdiff_t, not int.
5212 (scrolling_window): Avoid overflow in size calculations.
5213 Don't update size until allocation succeeds.
5214 * fns.c (concat): Check for overflow in size calculations.
5215 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5216 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5217 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5218
5219 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5220 (get_doc_string): Check for size calculation overflow.
5221 Don't update size until allocation succeeds.
5222 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5223 EMACS_INT, where ptrdiff_t will do.
5224 (Fsubstitute_command_keys): Check for string overflow.
5225
5226 * editfns.c (set_time_zone_rule): Don't assume environment length
5227 fits in int.
5228 (message_length): Now ptrdiff_t, not int.
5229 (Fmessage_box): Don't update size until allocation succeeds.
5230 Don't assume message length fits in int.
5231 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5232
0065d054
PE
5233 * emacs.c (main): Do not reallocate argv, since there is a null at
5234 the end that can be overwritten, and this way there's no need to
5235 worry about size-calculation overflow.
5236 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5237
5238 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5239 alloc succeeds.
5240 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5241
5242 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5243 (x_set_scroll_bar_width, x_figure_window_size):
5244 Check for integer overflow.
5245 (x_set_alpha): Do not assume XINT fits in int.
5246
5247 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5248 This is for the members text_lines, text_cols, total_lines, total_cols,
5249 where the system imposes an 'int' limit.
5250
5251 * fringe.c (Fdefine_fringe_bitmap):
5252 Don't update size until alloc works.
5253
5254 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5255 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5256
5257 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5258 Check for size-calculation overflow.
5259 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5260 do, as we prefer signed integers.
5261 (id_to_widget.max_size, id_to_widget.used)
5262 (xg_store_widget_in_map, xg_remove_widget_from_map)
5263 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5264 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5265 Use and return ptrdiff_t, not int.
5266 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5267 * gtkutil.h: Change prototypes to match the above.
5268
5269 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5270 are duplicate now that they've been promoted to lisp.h.
5271 (x_allocate_bitmap_record, x_alloc_image_color)
5272 (make_image_cache, cache_image, xpm_load):
5273 Don't update size until alloc is done.
5274 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5275 (x_detect_edges):
3256efce 5276 Check for size calculation overflow.
726e0ab1
PE
5277 (ct_colors_allocated_max): New constant.
5278 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5279 overflow.
3256efce 5280
726e0ab1
PE
5281 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5282 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5283 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5284 Use ptrdiff_t, not int, to count maps.
5285 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5286 calculations. Don't update size until allocation succeeds.
5287 Redo calculations to avoid overflow.
726e0ab1
PE
5288 * keyboard.h: Change prototypes to match the above.
5289
5290 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5291 to count maps.
5292 (current_minor_maps): Check for size calculation overflow.
5293 * keymap.h: Change prototypes to match the above.
5294
5295 * lread.c (read1, init_obarray): Don't update size until alloc done.
5296
5297 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5298 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5299
726e0ab1
PE
5300 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5301 Now ptrdiff_t, not int.
5302 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5303 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5304
5305 * process.c (Fnetwork_interface_list): Check for overflow
5306 in size calculation.
5307
5308 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5309
5310 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5311 overflow. Don't bother calling xmalloc when xrealloc will do.
5312
5313 * search.c (Freplace_match): Check for size calculation overflow.
5314 (Fset_match_data): Don't assume list lengths fit in 'int'.
5315
5316 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5317 for command line length. Do not attempt to address one before the
5318 beginning of an array, as that's not portable.
5319
5320 * term.c (max_frame_lines): Remove; unused.
5321 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5322 not int.
5323 (encode_terminal_code, calculate_costs): Check for size
5324 calculation overflow.
5325 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5326 table lengths and related sizes. Don't update size until alloc
5327 done. Redo calculations to avoid overflow.
5328 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5329
5330 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5331 subtracting pointers.
5332 (gobble_line): Check for overflow more carefully. Don't update size
5333 until alloc done.
5334
5335 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5336 Don't update size until alloc done.
5337 Redo size calculations to avoid overflow.
5338 Check for size calculation overflow.
0065d054 5339 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5340
5341 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5342 Use ptrdiff_t, not int, for sizes.
5343 (store_mode_line_noprop_char): Don't update size until alloc done.
5344
0065d054
PE
5345 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5346 Use ptrdiff_t, not int, for sizes.
5347 (Finternal_make_lisp_face, cache_face):
5348 Check for size calculation overflow.
5349 (cache_face): Treat size calculation overflows as if they were
5350 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5351
5352 * xfns.c (x_encode_text, x_set_name_internal)
5353 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5354 sizes, since they can exceed INT_MAX in size. Check for size
5355 calculation overflow.
5356
0065d054
PE
5357 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5358 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5359 Don't update size until alloc done.
5360
0065d054 5361 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5362 as sprintf is limited to int lengths.
1d526e2f 5363
252c5ee1
PE
5364 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5365 (X_LONG_MIN): New macros.
864d7ce7
PE
5366 Use them to make the following changes clearer.
5367 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5368 This change doesn't affect the value now, but it may help remind
5369 future maintainers not to raise the value too much later.
5370 (SELECTION_QUANTUM): Remove, replacing with ...
5371 (selection_quantum): ... new function, which avoids overflow.
5372 All uses changed.
5373 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5374 assumption that selection length fits in 'int'.
5375 (x_reply_selection_request, x_handle_selection_request)
5376 (x_get_window_property, receive_incremental_selection)
5377 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5378 (lisp_data_to_selection_data, clean_local_selection_data):
5379 Use ptrdiff_t, not int, to record length of selection.
5380 (x_reply_selection_request, x_get_window_property)
5381 (receive_incremental_selection, x_property_data_to_lisp):
5382 Redo calculations to avoid overflow.
5383 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5384 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5385 something.
5386 (x_get_window_property, receive_incremental_selection)
5387 (lisp_data_to_selection_data, x_property_data_to_lisp):
5388 Check for size-calculation overflow.
5389 (x_get_window_property, receive_incremental_selection)
5390 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5391 Don't store size until memory allocation succeeds.
5392 (x_get_window_property): Plug memory leak on memory exhaustion.
5393 Don't double-block input; malloc is safe here. Don't assume 2**34
5394 - 4 fits in unsigned long. Add an xassert to check
5395 XGetWindowProperty overflow. Be more careful about overflow
5396 calculations, and distinguish size from memory overflow better.
5397 (receive_incremental_selection): When tracing, don't assume
5398 unsigned int is less than INT_MAX.
5399 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5400 harmful) conversions of unsigned short to int.
5401 (lisp_data_to_selection_data): Don't assume that integers
5402 in the range -65535 through -1 fit in an X unsigned short.
5403 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5404 result parameters unless successful. Rely on cons_to_unsigned
5405 to report problems with elements; the old code wasn't right anyway.
5406 (x_check_property_data): Check for int overflow; we cannot use
5407 a wider type due to X limits.
5408 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5409
726e0ab1 5410 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5411
0065d054
PE
5412 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5413 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5414 (x_color_cells): Don't store size until memory allocation succeeds.
5415 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5416 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5417 (x_term_init): Don't assume length fits in int (sprintf is limited
5418 to int size).
bc18e09d 5419
ebfa62c0
PE
5420 Use ptrdiff_t for composition IDs.
5421 * character.c (lisp_string_width):
5422 * composite.c (composition_table_size, n_compositions)
5423 (get_composition_id, composition_gstring_from_id):
5424 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5425 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5426 * window.c (Frecenter):
5427 Use ptrdiff_t, not int, for composition IDs.
5428 * composite.c (get_composition_id): Check for integer overflow.
5429 * composite.h: Adjust prototypes to match the above changes.
5430
d3411f89
PE
5431 Use ptrdiff_t for hash table indexes.
5432 * category.c (hash_get_category_set):
5433 * ccl.c (ccl_driver):
5434 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5435 * coding.c (coding_system_charset_list, detect_coding_system):
5436 * coding.h (struct coding_system.id):
5437 * composite.c (get_composition_id, gstring_lookup_cache):
5438 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5439 * image.c (xpm_get_color_table_h):
5440 * lisp.h (hash_lookup, hash_put):
5441 * minibuf.c (Ftest_completion):
5442 Use ptrdiff_t for hash table indexes, not int (which is too
5443 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5444 32-bit --with-wide-int hosts).
5445
e097a6fa
PE
5446 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5447 Add a FIXME comment about memory leaks.
5448 (syms_of_charset): Don't assume xmalloc returns.
5449
5637687f
PE
5450 Don't assume that stated character widths fit in int.
5451 * character.c (Fchar_width, c_string_width, lisp_string_width):
5452 * character.h (CHAR_WIDTH):
5453 * indent.c (MULTIBYTE_BYTES_WIDTH):
5454 Use sanitize_char_width to avoid undefined and/or bad behavior
5455 with outlandish widths.
a66cfb1c 5456 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5457 now that we have two such functions. All uses changed.
5458 (sanitize_char_width): New inline function.
5459
a2271ba2
PE
5460 Don't assume that tab-width fits in int.
5461 * character.h (sanitize_width): New inline function.
5462 (SANE_TAB_WIDTH): New macro.
5463 (ASCII_CHAR_WIDTH): Use it.
5464 * indent.c (sane_tab_width): Remove. All uses replaced by
5465 SANE_TAB_WIDTH (current_buffer).
5466 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5467
18c52557
PE
5468 * fileio.c: Integer overflow issues with file modes.
5469 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5470
caeeedc1
PE
5471 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5472 Remove unreachable code.
5473 (read_hex, load_charset_map_from_file): Check for integer overflow.
5474
6df6ae42 5475 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5476 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5477 (x_send_scroll_bar_event): Likewise. Check that the size does not
5478 exceed limits imposed by XClientMessageEvent, as well as the usual
5479 ptrdiff_t and size_t limits.
5480
b13995db
PE
5481 * keyboard.c: Overflow, signedness and related fixes.
5482 (make_lispy_movement): Use same integer type in forward decl
5483 that is used in the definition.
5484 (read_key_sequence, keyremap_step):
5485 Change bufsize argument back to int, undoing my 2011-03-30 change.
5486 We prefer signed types, and int is wide enough here.
5487 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5488 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5489 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5490 length, not size_t. Use ptrdiff_t for index, not int.
5491 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5492 possibility of integer overflow.
5493
13464394
PE
5494 Overflow, signedness and related fixes for images.
5495
5496 * dispextern.h (struct it.stack[0].u.image.image_id)
5497 (struct_it.image_id, struct image.id, struct image_cache.size)
5498 (struct image_cache.used, struct image_cache.ref_count):
5499 * gtkutil.c (update_frame_tool_bar):
5500 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5501 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5502 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5503 * nsmenu.m (update_frame_tool_bar):
5504 * xdisp.c (calc_pixel_width_or_height):
5505 * xfns.c (image_cache_refcount):
5506 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5507 on typical 64-bit hosts.
5508
5509 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5510 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5511 Omit unnecessary casts to int.
5512 (parse_image_spec): Check that integers fall into 'int' range
5513 when the callers expect that.
5514 (image_ascent): Redo ascent calculation to avoid int overflow.
5515 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5516 (lookup_image): Remove unnecessary tests.
5517 (xbm_image_p): Locals are now of int, not EMACS_INT,
5518 since parse_image_check makes sure they fit into int.
5519 (png_load, gif_load, svg_load_image):
5520 Prefer int to unsigned where either will do.
5521 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5522 old tiff_error_handler and tiff_warning_handler.
5523 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5524 stack buffer overflows. It uses only the features of vsnprintf
5525 that are common to both POSIX and native Microsoft.
5526 (tiff_error_handler, tiff_warning_handler): Use it.
5527 (tiff_load, gif_load, imagemagick_load_image):
5528 Don't assume :index value fits in 'int'.
5529 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5530 (imagemagick_load_image): Check that crop parameters fit into
5531 the integer types that MagickCropImage accepts. Don't assume
5532 Vimagemagick_render_type has a nonnegative value. Don't assume
5533 size_t fits in 'long'.
5534 (gs_load): Use printmax_t to print the widest integers possible.
5535 Check for integer overflow when computing image height and width.
5536
c11821d4
EZ
55372011-08-26 Eli Zaretskii <eliz@gnu.org>
5538
5539 * xdisp.c (redisplay_window): Don't force window start if point
5540 will be invisible in the resulting window. (Bug#9324)
5541
0c95fcf7
EZ
55422011-08-25 Eli Zaretskii <eliz@gnu.org>
5543
5544 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5545 the display spec is of the form `(space ...)'.
5546 (handle_display_spec): Return the value returned by
5547 handle_single_display_spec, not just 1 or zero.
5548 (handle_single_display_spec): If the display spec is of the form
5549 `(space ...)', and specifies display in the text area, return 2
5550 rather than 1.
fee65a97 5551 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5552 accurately, and prefer exact match for point under bidi.
5553 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5554
5555 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5556 into disp_prop; all users changed.
5557
5558 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5559 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5560 for the text covered by the display property.
5561
e4ed06f1
CY
55622011-08-25 Chong Yidong <cyd@stupidchicken.com>
5563
5564 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5565 Change return value to nil.
5566 (Frecord_buffer): Delete unused function.
5567
f67cdd7f
EZ
55682011-08-24 Eli Zaretskii <eliz@gnu.org>
5569
5980d4c6
EZ
5570 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5571 buffers, return left-to-right.
8610fe8b
EZ
5572 (set_cursor_from_row): Consider candidate row a win if its glyph
5573 represents a newline and point is on that newline. Fixes cursor
5574 positioning on the newline at EOL of R2L text within L2R
5575 paragraph, and vice versa.
5576 (try_cursor_movement): Check continued rows, in addition to
5577 continuation rows. Fixes unwarranted scroll when point enters a
5578 continued line of R2L text within an L2R paragraph, or vice versa.
5579 (cursor_row_p): Consider the case of point being equal to
5580 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5581 from the end of a short line to the beginning of a continued line
5582 of R2L text within L2R paragraph.
5583 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5584 composed characters.
5980d4c6 5585
f67cdd7f
EZ
5586 * bidi.c (bidi_check_type): Use xassert.
5587 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5588 members.
5589
bca633fb
EZ
55902011-08-23 Eli Zaretskii <eliz@gnu.org>
5591
5592 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5593 a character.
5594
4a5885a7
CY
55952011-08-23 Chong Yidong <cyd@stupidchicken.com>
5596
5597 * nsfont.m (ns_otf_to_script): Fix typo.
5598
0902a04e
KH
55992011-08-22 Kenichi Handa <handa@m17n.org>
5600
5601 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5602 extra slot even if the purpose is char-code-property-table.
5603
1a2e6670
EZ
56042011-08-23 Eli Zaretskii <eliz@gnu.org>
5605
8ddde651
EZ
5606 * xdisp.c (redisplay_window): When computing centering_position,
5607 account for the height of the header line. (Bug#8874)
5608
425cc014
EZ
5609 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5610 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5611 candidate is selected by the mouse, and that candidate has a
5612 composed character under the mouse.
5613
1a2e6670
EZ
5614 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5615 coordinates reported by pos-visible-in-window-p for a composed
5616 character in column zero.
5617
8b76d6f8
SM
56182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5619
5620 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5621
dac347dd
EZ
56222011-08-22 Eli Zaretskii <eliz@gnu.org>
5623
5624 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5625 consider it a hit if to_charpos is anywhere in the range of the
5626 composed buffer positions.
5627
e013fb34
CY
56282011-08-22 Chong Yidong <cyd@stupidchicken.com>
5629
5630 * image.c (gif_load): Don't assume that each subimage has the same
5631 dimensions as the base image. Handle disposal method that is
5632 "undefined" by the gif spec (Bug#9335).
5633
bd1ba3e8
CY
56342011-08-20 Chong Yidong <cyd@stupidchicken.com>
5635
5636 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5637 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5638
54a1215b
EZ
56392011-08-19 Eli Zaretskii <eliz@gnu.org>
5640
823564e5
EZ
5641 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5642 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5643 from an Org mode buffer to a Speedbar frame.
5644
54a1215b
EZ
5645 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5646 a composition, take its buffer position from IT->cmp_it.charpos.
5647 Fixes cursor positioning at the beginning of a line that begins
5648 with a composed character.
5649
9778ebcc
EZ
56502011-08-18 Eli Zaretskii <eliz@gnu.org>
5651
0be6ee06
EZ
5652 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5653 character bidirectional type, use STRONG_L instead. Fixes crashes
5654 in a buffer produced by `describe-categories'.
5655
9778ebcc
EZ
5656 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5657 members before the level stack, so they would be saved and
5658 restored when copying iterator state. Fixes incorrect reordering
5659 around TABs covered by display properties.
5660
156bffbe
AS
56612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5662
6b02f655 5663 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5664
72ad093b
CY
56652011-08-17 Chong Yidong <cyd@stupidchicken.com>
5666
5667 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5668 (internal_condition_case_2, internal_condition_case_n):
5669 Remove unnecessary aborts (Bug#9081).
72ad093b 5670
35774242
EZ
56712011-08-17 Eli Zaretskii <eliz@gnu.org>
5672
5673 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5674 has no `load' handler, try opening the file locally. (Bug#9311)
5675
db76dd85
KB
56762011-08-16 Ken Brown <kbrown@cornell.edu>
5677
5678 * gmalloc.c: Expand comment.
5679
b215eee5
EZ
56802011-08-16 Eli Zaretskii <eliz@gnu.org>
5681
5682 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5683 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5684
a4579d33
KB
56852011-08-16 Ken Brown <kbrown@cornell.edu>
5686
5687 Fix memory allocation problems in Cygwin build (Bug#9273).
5688
5689 * unexcw.c ( __malloc_initialized): Declare external variable.
5690 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5691
8b76d6f8
SM
5692 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5693 New variables.
a4579d33
KB
5694 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5695 dumped emacs.
5696 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5697 in the static heap.
5698 [CYGWIN] (special_realloc): New function.
5699 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5700 requests to realloc storage in the static heap.
5701
3ebec551
PE
57022011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 * bidi.c (bidi_initialize): Remove unused local.
5705
9fd8be00
EZ
57062011-08-15 Eli Zaretskii <eliz@gnu.org>
5707
6b02f655
SM
5708 * bidimirror.h:
5709 * biditype.h: Remove file.
5710 * makefile.w32-in ($(BLD)/bidi.$(O)):
5711 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5712
5713 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5714
5715 * chartab.c: Improve commentary for the uniprop_table API.
5716
32413314
EZ
5717 * bidi.c (bidi_paragraph_init): Support zero value of
5718 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5719 (bidi_initialize): Use uniprop_table instead of including
5720 biditype.h and bidimirror.h.
32413314 5721
9fd8be00
EZ
5722 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5723 coordinates of the iterator when restoring from ppos_it.
5724 (Bug#9296)
5725
5cf2b69b
KH
57262011-08-14 Kenichi Handa <handa@m17n.org>
5727
5728 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5729 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5730
daf17d00
EZ
57312011-08-14 Eli Zaretskii <eliz@gnu.org>
5732
5733 * xdisp.c (move_it_in_display_line_to): Don't invoke
5734 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5735 ppos_it. Fixes vertical cursor motion when line beginning is
5736 covered by an image. (Bug#9296)
5737
08e3161a
JD
57382011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5739
5740 * nsterm.h (ns_run_ascript): Declare.
5741 (NSAPP_DATA2_RUNASSCRIPT): Define.
5742
5743 * nsfns.m (as_script, as_result, as_status): New static variables.
5744 (ns_run_ascript): New function.
5e617bc2 5745 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5746 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5747 the event loop. Get status from as_status (Bug#7276).
5748
5749 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5750 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5751 the event loop (Bug#7276).
5752
a3720aa2
AS
57532011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5754
5755 * gnutls.c (QCgnutls_bootprop_priority)
5756 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5757 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5758 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5759 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5760 (QCgnutls_bootprop_verify_hostname_error)
5761 (QCgnutls_bootprop_callbacks_verify): Rename from
5762 Qgnutls_bootprop_..., all uses changed.
5763
5764 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5765 uses changed.
5766
0a0d27fb
PE
57672011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5768
19d5c50c
PE
5769 * xfaces.c (Qframe_set_background_mode): Now static.
5770 * dispextern.h (Qframe_set_background_mode): Remove decl.
5771
0a0d27fb
PE
5772 * process.c (Fnetwork_interface_info): Declare local only if needed.
5773
377538cb
JD
57742011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5775
5776 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5777 (Fnetwork_interface_list): Allocate in increments of bytes instead
5778 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5779 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5780 sockaddr.
5781 (struct ifflag_def): notrailers is smart on OSX.
5782 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5783 Get hardware address with getifaddrs if available.
5784
08fff70c
EZ
57852011-08-12 Eli Zaretskii <eliz@gnu.org>
5786
5787 * xdisp.c (iterate_out_of_display_property): xassert that
5788 IT->position is set to within IT->object's boundaries. Break from
5789 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5790 when IT->position is set up wrongly due to some bug.
5791 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5792 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5793 entry. Force push_it to save on the stack the current
5794 buffer/string position, to be restored by pop_it. Fix flags in
5795 the iterator structure wrt the object coming from a display
5796 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5797 properties. (Bug#9284)
5798
7be1c708 57992011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5800
7be1c708
CY
5801 * fontset.c (fontset_get_font_group): Add proper type checks.
5802 (Bug#9172)
aac0c6e3 5803
7be1c708 58042011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5805
7be1c708
CY
5806 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5807 and LC_VERSION_MIN_MACOSX.
5808 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5809 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5810
97bb72a6
EZ
58112011-08-08 Eli Zaretskii <eliz@gnu.org>
5812
5813 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5814 no-display-properties-and-no-overlays under bidi display.
5815 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5816 properties and overlays.
97bb72a6 5817
d5617611
CY
58182011-08-08 Chong Yidong <cyd@stupidchicken.com>
5819
37e11a63
CY
5820 * editfns.c (Fset_time_zone_rule): Document relationship with the
5821 setenv function.
5822
d5617611
CY
5823 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5824 the font entity extracted from the cache (Bug#8109).
5825
58872834
CY
58262011-08-07 Chong Yidong <cyd@stupidchicken.com>
5827
5828 * composite.c (autocmp_chars): Don't reset point. That is done by
5829 restore_point_unwind (Bug#5984).
5830
75bfc667
JL
58312011-08-07 Juri Linkov <juri@jurta.org>
5832
5833 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5834 to show the arg `TIME' instead of `TIMEVAL'.
5835
d1410150
EZ
58362011-08-06 Eli Zaretskii <eliz@gnu.org>
5837
5838 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5839 display property strides EOL and includes a newline, as in
5840 longlines-mode. (Bug#9254)
75b771e4
EZ
5841 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5842 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5843
5844 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5845 is non-zero, even if the data buffer is NULL. Fixes a crash in
5846 vertical-motion with longlines-mode. (Bug#9254)
5847
35928349
EZ
58482011-08-05 Eli Zaretskii <eliz@gnu.org>
5849
ec7cc85b
EZ
5850 * bidi.c <bidi_cache_total_alloc>: Now static.
5851 (bidi_initialize): Initialize bidi_cache_total_alloc.
5852
8b76d6f8 5853 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5854 cache. (Bug#9221)
5855
5856 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5857 amount allocated this far in `bidi_cache_total_alloc'.
5858 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5859 non-zero, only free the data buffer without restoring the cache
5860 contents. All callers changed.
5861
5862 * dispextern.h (bidi_unshelve_cache): Update prototype.
5863
5864 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5865 (move_it_in_display_line, move_it_to)
5866 (move_it_vertically_backward, move_it_by_lines): Replace the call
5867 to xfree to an equivalent call to bidi_unshelve_cache.
5868 (move_it_in_display_line_to): Fix logic of returning
412b6358 5869 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5870
e2e2423b
EZ
58712011-08-05 Eli Zaretskii <eliz@gnu.org>
5872
5873 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5874 came from a string character with a `cursor' property. (Bug#9229)
5875
ae9e757a
JD
58762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5877
5878 * Makefile.in (LIB_PTHREAD): New variable.
5879 (LIBES): Add LIB_PTHREAD (Bug#9216).
5880
5881 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5882 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5883
213bd7f2
AS
58842011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5885
6b02f655 5886 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5887
99aaf75f
JD
58882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5889
5890 * xterm.c (x_find_topmost_parent): New function.
5891 (x_set_frame_alpha): Find topmost parent window with
5892 x_find_topmost_parent and set the property there also (bug#9181).
5893 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5894
c74e9d86
PE
58952011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5896
5897 * callproc.c (Fcall_process): Avoid vfork clobbering
5898 the local vars buffer, coding_systems, current_dir.
5899
640c8776
SM
59002011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5901
5902 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5903
f26d0e4c
PE
59042011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5905
8a10d76c
PE
5906 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5907 so that it is not optimized away.
5908
f26d0e4c
PE
5909 * xdisp.c (compute_display_string_pos): Remove unused local.
5910
55439c61
EZ
59112011-08-02 Eli Zaretskii <eliz@gnu.org>
5912
5913 Fix slow cursor motion and scrolling in large buffers with
5914 selective display, like Org Mode buffers. (Bug#9218)
5915
5916 * dispextern.h (struct bidi_it): New member disp_prop_p.
5917
5918 * xdisp.c: Remove one-slot cache of display string positions.
5919 (compute_display_string_pos): Accept an additional argument
5e617bc2 5920 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5921 for a display string or property. If found, set DISP_PROP_P
5922 non-zero.
5923
5924 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5925 DISP_PROP_P, and pass it to compute_display_string_pos.
5926 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5927 non-zero. All callers of bidi_fetch_char changed.
5928
fb33fa43
SM
59292011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5930
5931 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5932
b099e063
DM
59332010-12-03 Don March <don@ohspite.net>
5934
5935 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5936 last character M-[char] is translated to ESC [char] (bug#7541).
5937
5cc7f7af
KH
59382011-08-02 Kenichi Handa <handa@m17n.org>
5939
d0fffa3f 5940 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5941
5942 * chartab.c (uniprop_table): Make it non-static.
5943
525d5e6e
EZ
59442011-08-01 Eli Zaretskii <eliz@gnu.org>
5945
5946 * xdisp.c (forward_to_next_line_start): Accept additional argument
5947 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5948 on the newline.
5949 (reseat_at_next_visible_line_start): Use the bidi iterator state
5950 returned by forward_to_next_line_start to restore the state of
5951 it->bidi_it after backing up to previous newline. (Bug#9212)
5952
31011111
AS
59532011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5954
5955 * regex.c (re_comp): Protoize.
5956 (re_exec): Fix return type.
5957 (regexec): Fix type of `ret'. (Bug#9203)
5958
476371c4
PE
59592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5960
e5d76069
PE
5961 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5962 This is needed if max-image-size is a floating-point number.
5963
9a79b20c
AS
59642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5965
5966 * print.c (print_object): Print empty symbol as ##.
5967
5968 * lread.c (read1): Read ## as empty symbol.
5969
d8c2fa78
AA
59702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5971
5972 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5973 setting frame foreground color (Bug#9175).
5974 (x_set_background_color): Likewise.
5975
ffe57a7a
AA
5976 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5977 contents (Bug#9176).
5978 (EmacsTooltip -init): Remove bezels and add shadows to
5979 tooltip windows.
5980
bf3492a5
AA
5981 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5982 or scroll bar (Bug#8470).
5983
d55e9c53
AA
5984 * nsfont.m (nsfont_open): Remove assignment to voffset and
5985 unnecessary vars hshink, expand, hd, full_height, min_height.
5986 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5987
5988 * nsterm.h (nsfont_info): Remove voffset field.
5989
d8c2fa78 59902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5991
5992 Implement strike-through and overline on NextStep (Bug#8863).
5993
5994 * nsfont.m (nsfont_open): Use underline position provided by font,
5995 instead of hard-coded value of 2.
5996 (nsfont_draw): Call ns_draw_text_decoration instead.
5997
5998 * nsterm.h: Add declaration for ns_draw_text_decoration.
5999
6000 * nsterm.m (ns_draw_text_decoration): New function for drawing
6001 underline, overline, and strike-through.
6002 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6003 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6004 accommodate underlining, etc.
4843aac3 6005
4cc60b9b
EZ
60062011-07-28 Eli Zaretskii <eliz@gnu.org>
6007
bc7ece87
EZ
6008 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6009 default.
4cc60b9b 6010
476371c4
PE
60112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6012
66606eea
PE
6013 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6014 Without this fix, if a signal arrives just after memory fills up,
6015 'malloc' might be invoked reentrantly.
6016
476371c4
PE
6017 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6018 In other words, assume that every image size is allowed, on non-X
6019 hosts. This assumption is probably wrong, but it lets Emacs compile.
6020
f3fcc40d
AS
60212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6022
6023 * regex.c (re_iswctype): Convert return values to boolean.
6024
350c992f
EZ
60252011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6026
6027 * xdisp.c (compute_display_string_pos): Don't use cached display
6028 string position if the buffer had its restriction changed.
6029 (Bug#9184)
6030
5266b4bb
PE
60312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6032
6033 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6034
2573a837 60352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6036
41f55ccd 6037 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6038
39e378da
PE
6039 * bidi.c: Integer size and overflow fixes.
6040 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6041 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6042 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6043 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6044 (bidi_find_other_level_edge):
6045 Use ptrdiff_t instead of EMACS_INT where either will do.
6046 This works better on 32-bit hosts configured --with-wide-int.
6047 (bidi_cache_ensure_space): Check for size-calculation overflow.
6048 Use % rather than repeated addition, for better worst-case speed.
6049 Don't set bidi_cache_size until after xrealloc returns, because it
6050 might not return.
6051 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6052 (bidi_cache_ensure_space): Also check that the bidi cache size
6053 does not exceed that of the largest Lisp string or buffer. See Eli
6054 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6055
5e927815
PE
6056 * alloc.c (__malloc_size_t): Remove.
6057 All uses replaced by size_t. See Andreas Schwab's note
6058 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6059
ca4aa935
PE
6060 * image.c: Improve checking for integer overflow.
6061 (check_image_size): Assume that f is nonnull, since
6062 it is always nonnull in practice. This is one less thing to
6063 worry about when checking for integer overflow later.
6064 (x_check_image_size): New function, which checks for integer
6065 overflow issues inside X.
6066 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6067 This removes the need for a memory_full check.
6068 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6069 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6070 (xbm_read_bitmap_data): Change locals back to 'int', since
6071 their values must fit in 'int'.
6072 (xpm_load_image, png_load, tiff_load):
6073 Invoke x_create_x_image_and_pixmap earlier,
6074 to avoid much needless work if the image is too large.
6075 (tiff_load): Treat overly large images as if
6076 x_create_x_image_and_pixmap failed, not as malloc failures.
6077 (gs_load): Use x_check_image_size.
6078
5f8f9cc2
PE
6079 * gtkutil.c: Omit integer casts.
6080 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6081 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6082
5adf60bc
PE
6083 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6084
c8907a93
PE
6085 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6086 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6087 would wrongly return t on a 64-bit host.
6088
e3c25c68
PE
6089 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6090 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6091 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6092 and therefore cause GCC to emit a bogus diagnostic in some cases.
6093
3f791afe
PE
6094 * image.c: Integer signedness and overflow and related fixes.
6095 This is not an exhaustive set of fixes, but it's time to
6096 record what I've got.
6097 (lookup_pixel_color, check_image_size): Remove redundant decls.
6098 (check_image_size): Don't assume that arbitrary EMACS_INT values
6099 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6100 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6101 (tiff_load, imagemagick_load_image):
6102 Check for overflow in size calculations.
6103 (x_create_x_image_and_pixmap): Remove unnecessary test for
6104 xmalloc returning NULL; that can't happen.
6105 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6106 (xpm_color_bucket): Use better integer hashing function.
6107 (xpm_cache_color): Don't possibly over-allocate memory.
6108 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6109 (gif_memory_source):
6110 Use ptrdiff_t, not int or size_t, to record sizes.
6111 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6112 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6113 either works, as we prefer signed integers.
6114 (tiff_read_from_memory, tiff_write_from_memory):
6115 Return tsize_t, not size_t, since that's what the TIFF API wants.
6116 (tiff_read_from_memory): Don't fail simply because the read would
6117 go past EOF; instead, return a short read.
6118 (tiff_load): Omit no-longer-needed casts.
6119 (Fimagemagick_types): Don't assume size fits into 'int'.
6120
3cc5a532
PE
6121 Improve hashing quality when configured --with-wide-int.
6122 * fns.c (hash_string): New function, taken from sxhash_string.
6123 Do not discard information about ASCII character case; this
6124 discarding is no longer needed.
6125 (sxhash-string): Use it. Change sig to match it. Caller changed.
6126 * lisp.h: Declare it.
6127 * lread.c (hash_string): Remove, since we now use fns.c's version.
6128 The fns.c version returns a wider integer if --with-wide-int is
6129 specified, so this should help the quality of the hashing a bit.
6130
b312a492
PE
6131 * emacs.c: Integer overflow minor fix.
6132 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6133 Define only if GNU_LINUX.
6134 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6135
dfd153ae
PE
6136 * dispnew.c: Integer signedness and overflow fixes.
6137 Remove unnecessary forward decls, that were a maintenance hassle.
6138 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6139 All uses changed.
6140 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6141 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6142 (prepare_desired_row, line_draw_cost):
6143 Use int, not unsigned, where either works.
6144 (save_current_matrix, restore_current_matrix):
6145 Use ptrdiff_t, not size_t, where either works.
6146 (init_display): Check for overflow more accurately, and without
6147 relying on undefined behavior.
6148
a81d11a3
PE
6149 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6150 Remove, replacing with the new symbols in lisp.h. All uses changed.
6151 * fileio.c (make_temp_name):
6152 * filelock.c (lock_file_1, lock_file):
6153 * xdisp.c (message_dolog):
6154 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6155 Use pMd etc. instead.
6156 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6157 replacing the pWIDE etc. symbols removed from editfns.c.
6158
3300e6fd
PE
6159 * keyboard.h (num_input_events): Now uintmax_t.
6160 This is (very slightly) less likely to mess up due to wraparound.
6161 All uses changed.
6162
fd05c7e9
PE
6163 * buffer.c: Integer signedness fixes.
6164 (alloc_buffer_text, enlarge_buffer_text):
6165 Use ptrdiff_t rather than size_t when either will do, as we prefer
6166 signed integers.
6167
903fe15d
PE
6168 * alloc.c: Integer signedness and overflow fixes.
6169 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6170 (__malloc_size_t): Default to size_t, not to int.
6171 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6172 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6173 Prefer ptrdiff_t to size_t when either would do, as we prefer
6174 signed integers.
6175 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6176 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6177 Now const. Initialize with values that are in range even if char
6178 is signed.
6179 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6180 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6181 These functions do the right thing with sizes > 2**32.
6182 (check_depth): Now ptrdiff_t, not int.
6183 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6184 Adjust to new way of storing sizes. Check for size overflow bugs
6185 in rest of code.
6186 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6187 slightly wrong anyway, as it missed one instance of
6188 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6189 (refill_memory_reserve): Omit needless cast to size_t.
6190 (mark_object_loop_halt): Mark as externally visible.
6191
ac82cc6a
PE
6192 * xselect.c: Integer signedness and overflow fixes.
6193 (Fx_register_dnd_atom, x_handle_dnd_message):
6194 Use ptrdiff_t, not size_t, since we prefer signed.
6195 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6196 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6197 x_dnd_atoms_size and x_dnd_atoms_length.
6198
c2d1e36d
PE
6199 * doprnt.c: Prefer signed to unsigned when either works.
6200 * eval.c (verror):
6201 * doprnt.c (doprnt):
6202 * lisp.h (doprnt):
6203 * xdisp.c (vmessage):
6204 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6205 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6206 prefer signed arithmetic to avoid comparison confusion.
6207 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6208 but is a bit tricky.
6209
0e926e56
PE
6210 Assume freestanding C89 headers, string.h, stdlib.h.
6211 * data.c, doprnt.c, floatfns.c, print.c:
6212 Include float.h unconditionally.
6213 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6214 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6215 * regex.c: Likewise for stddef.h, string.h.
6216 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6217 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6218 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6219 (STDC_HEADERS): Remove obsolete defines.
6220 * sysdep.c: Include limits.h unconditionally.
6221
9cfdb3ec
PE
6222 Assume support for memcmp, memcpy, memmove, memset.
6223 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6224 * regex.c (memcmp, memcpy):
6225 Remove; we assume C89 now.
6226
6227 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6228 (__malloc_safe_bcopy): Remove; no longer needed.
6229
cf950e6b 6230 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6231 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6232 well either way, and we prefer signed to unsigned.
6233
dbf38e02
LMI
62342011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6235
6236 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6237 closes the connection while we're reading (bug#9182).
6238
d6f0886c 62392011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6240
d6f0886c
JD
6241 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6242 are specified (Bug#9168).
24e0f6b1 6243
2eb1f9e6
PE
62442011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6245
6246 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6247 Found by GCC static checking and --with-wide-int on a 32-bit host.
6248
22381272 62492011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6250
6251 * xdisp.c (compute_display_string_pos): Fix logic of caching
6252 previous display string position. Initialize cached_prev_pos to
6253 -1. Fixes slow-down at the beginning of a buffer.
6254
f25e39b4
EZ
62552011-07-24 Eli Zaretskii <eliz@gnu.org>
6256
6257 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6258 for attrs[LFACE_FONTSET_INDEX].
6259
04c4b52e
PE
62602011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6261
6262 * xml.c (parse_region): Remove unused local
6263 that was recently introduced.
6264
c1734fbd
EZ
62652011-07-23 Eli Zaretskii <eliz@gnu.org>
6266
be18c5a5
EZ
6267 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6268 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6269
c1734fbd
EZ
6270 * xdisp.c (move_it_in_display_line_to): Record the best matching
6271 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6272 exit if none of the characters scanned was an exact match.
6273 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6274 when exact match is impossible due to invisible text, and the
6275 lines are truncated.
6276
a258d627
JD
62772011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6278
6279 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6280 for OSX >= 10.7.
6281
b6d5a689
EZ
62822011-07-22 Eli Zaretskii <eliz@gnu.org>
6283
0f74f785
EZ
6284 Fix a significant slow-down of cursor motion with C-n, C-p,
6285 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6286 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6287 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6288 (next_element_from_buffer): Call compute_stop_pos_backwards to
6289 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6290 base_level_stop.
6291 (reseat): Don't look for prev_stop, as that could mean a very long
6292 run.
6293 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6294 <cached_disp_overlay_modiff>: Cache for last found display string
6295 position.
551918c1 6296 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6297 about the same buffer in the same area of character positions, and
6298 the buffer wasn't changed since the time the display string
6299 position was cached.
551918c1 6300
b2d0c91a
EZ
63012011-07-22 Eli Zaretskii <eliz@gnu.org>
6302
6303 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6304 is an integer, which is important for empty lines. (Bug#9149)
6305
043604ee
CY
63062011-07-22 Chong Yidong <cyd@stupidchicken.com>
6307
6308 * frame.c (Fmodify_frame_parameters): In tty case, update the
6309 default face if necessary (Bug#4238).
6310
da4adb04
CY
63112011-07-21 Chong Yidong <cyd@stupidchicken.com>
6312
6313 * editfns.c (Fstring_to_char): No need to explain what a character
6314 is in the docstring (Bug#6576).
6315
9abd0532
LMI
63162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6317
6318 * xml.c (parse_region): Make sure we always return a tree.
6319
36881d16
HK
63202011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6321
6322 * xml.c (parse_region): If a document contains only comments,
6323 return that, too.
6324
1e98674d
LMI
63252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6326
6327 * xml.c (make_dom): Return comments, too.
6328
590bd467
PE
63292011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6330
6331 Port to OpenBSD.
6332 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6333 and the surrounding thread.
6334 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6335 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6336 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6337 timer goes off.
6338 * s/openbsd.h (BROKEN_SIGIO): Define.
6339 * unexelf.c (unexec) [__OpenBSD__]:
6340 Don't update the .mdebug section of the Alpha COFF symbol table.
6341
f41628b2
LMI
63422011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6343
6344 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6345 (bug#8460).
6346
b59b67c5
PE
63472011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6348
15e3a074
PE
6349 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6350 This fixes some race conditions on the permissions of any newly
6351 created file.
6352
41bed37d
PE
6353 * alloc.c (valid_pointer_p): Use pipe, not open.
6354 This fixes some permissions issues when debugging.
6355
b59b67c5
PE
6356 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6357 If fchown fails to set both uid and gid, try to set just gid,
6358 as that is sometimes allowed. Adjust the file's mode to eliminate
6359 setuid or setgid bits that are inappropriate if fchown fails.
6360
925a6be7
SM
63612011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6362
6363 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6364 to compare Lisp_Objects.
6365 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6366 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6367 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6368
52968808
AS
63692011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6370
0a6a104b
AS
6371 * lread.c (read_integer): Unread even EOF character.
6372 (read1): Likewise. Properly record start position of symbol.
6373
52968808
AS
6374 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6375 symbol character follows.
6376
9e381cdd
PE
63772011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6378
6379 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6380 This works around a problem with the previous change to Fcopy_file.
6381 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6382 and without this change, GCC might complain about discarding
6383 fchown's return value.
6384
b5641435
JB
63852011-07-16 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6388
a8031457
PE
63892011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6390
6391 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6392
dd889327
LMI
63932011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6394
750c33f7
LMI
6395 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6396 it's used from the C level.
6397
dd889327
LMI
6398 * process.c: Use the same condition for POLL_FOR_INPUT in both
6399 keyboard.c and process.c (bug#1858).
6400
87e86684
LM
64012011-07-09 Lawrence Mitchell <wence@gmx.li>
6402
6403 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6404 (Fgnutls_boot): Use it.
6405
64348f40
AS
64062011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6407
6408 * doc.c (Fsubstitute_command_keys): Revert last change.
6409
1d698799
LMI
64102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6411
f863868c
LMI
6412 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6413 quotes the next character, and doesn't affect other longer
6414 sequences (bug#8935).
6415
1d698799
LMI
6416 * lread.c (syms_of_lread): Clarify that is isn't only
6417 `eval-buffer' and `eval-defun' that's affected by
6418 `lexical-binding' (bug#8460).
6419
aa4b6df6
EZ
64202011-07-15 Eli Zaretskii <eliz@gnu.org>
6421
6422 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6423 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6424
5d856da6
PE
64252011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6426
ad6042bb
PE
6427 Fix minor problems found by static checking.
6428 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6429 (elsz): Now a signed constant, not a size_t var. We prefer signed
6430 types to unsigned, to avoid integer comparison confusion. Without
6431 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6432 "cannot optimize loop, the loop counter may overflow", a symptom
6433 of the confusion.
f00bbb22 6434 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6435 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6436
6468f31c
LMI
64372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6438
49080b10
LMI
6439 * search.c (Fre_search_backward): Mention `case-fold-search' in
6440 all the re_search_* functions (bug#8138).
6441
6468f31c
LMI
6442 * keyboard.c (Fopen_dribble_file): Document when the file is
6443 closed (bug#8056).
6444
c965adc5
EZ
64452011-07-14 Eli Zaretskii <eliz@gnu.org>
6446
df9733bf
EZ
6447 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6448 bidi_cache_idx.
6449
0bb23927
EZ
6450 Support bidi reordering of display and overlay strings.
6451 * xdisp.c (compute_display_string_pos)
6452 (compute_display_string_end): Accept additional argument STRING.
6453 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6454 (reseat_to_string): Initialize bidi_it->string.s and
6455 bidi_it->string.schars.
6456 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6457 NULL (avoids a crash in bidi_paragraph_init).
6458 Initialize itb.string.lstring.
0bb23927
EZ
6459 (init_iterator): Call bidi_init_it only of a valid
6460 buffer position was specified. Initialize paragraph_embedding to
6461 L2R.
6462 (reseat_to_string): Initialize the bidi iterator.
6463 (display_string): If we need to ignore text properties of
6464 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6465 original value of -1 will not work with bidi.)
6466 (compute_display_string_pos): First arg is now struct
6467 `text_pos *'; all callers changed. Support display properties on
6468 Lisp strings.
6469 (compute_display_string_end): Support display properties on Lisp
6470 strings.
6471 (init_iterator, reseat_1, reseat_to_string): Initialize the
6472 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6473 when iterating on a string not from display properties).
640c8776
SM
6474 (compute_display_string_pos, compute_display_string_end):
6475 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6476 arrow keys.
6477 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6478 base_level_stop; instead, set base_level_stop to BEGV.
6479 Fixes crashes in vertical-motion.
0bb23927
EZ
6480 (next_element_from_buffer): Improve commentary for when
6481 the iterator is before prev_stop.
6482 (init_iterator): Initialize bidi_p from the default value of
6483 bidi-display-reordering, not from buffer-local value. Use the
6484 buffer-local value only if initializing for buffer iteration.
6485 (handle_invisible_prop): Support invisible properties on strings
6486 that are being bidi-reordered.
6487 (set_iterator_to_next): Support bidi reordering of C strings and
6488 Lisp strings.
6489 (next_element_from_string): Support bidi reordering of Lisp
6490 strings.
6491 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6492 (display_string): Support display of R2L glyph rows.
6493 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6494 (init_iterator): Don't initialize it->bidi_p for strings
6495 here.
6496 (reseat_to_string): Initialize it->bidi_p for strings here.
6497 (next_element_from_string, next_element_from_c_string)
6498 (next_element_from_buffer): Add xassert's for correspondence
6499 between IT's object being iterated and it->bidi_it.string
6500 structure.
6501 (face_before_or_after_it_pos): Support bidi iteration.
6502 (next_element_from_c_string): Handle the case of the first string
6503 character that is not the first one in the visual order.
6504 (get_visually_first_element): New function, refactored from common
6505 parts of next_element_from_buffer, next_element_from_string, and
6506 next_element_from_c_string.
6507 (tool_bar_lines_needed, redisplay_tool_bar)
6508 (display_menu_bar): Force left-to-right direction. Add a FIXME
6509 comment for making that be controlled by a user option.
6510 (push_it, pop_it): Save and restore the state of the
6511 bidi iterator. Save and restore the bidi_p flag.
6512 (pop_it): Iterate out of display property for string iteration as
6513 well.
6514 (iterate_out_of_display_property): Support iteration over strings.
6515 (handle_single_display_spec): Set up it->bidi_it for iteration
6516 over a display string, and call bidi_init_it.
6517 (handle_single_display_spec, next_overlay_string)
6518 (get_overlay_strings_1, push_display_prop): Set up the bidi
6519 iterator for displaying display or overlay strings.
6520 (forward_to_next_line_start): Don't use the shortcut if
6521 bidi-iterating.
6522 (back_to_previous_visible_line_start): If handle_display_prop
6523 pushed the iterator stack, restore the internal state of the bidi
6524 iterator by calling bidi_pop_it same number of times.
6525 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6526 and we are bidi-iterating, don't decrement the iterator position;
6527 instead, set the first_elt flag in the bidi iterator, to produce
6528 the same effect.
6529 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6530 (push_display_prop): xassert that we are iterating a buffer.
6531 (push_it, pop_it): Save and restore paragraph_embedding member.
6532 (handle_single_display_spec, next_overlay_string)
6533 (get_overlay_strings_1, reseat_1, reseat_to_string)
6534 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6535 correctly. Don't assume unibyte strings are not bidi-reordered.
6536 (compute_display_string_pos)
6537 (compute_display_string_end): Fix handling the case of C string.
6538 (push_it, pop_it): Save and restore from_disp_prop_p.
6539 (handle_single_display_spec, push_display_prop): Set the
6540 from_disp_prop_p flag.
6541 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6542 (pop_it): Call iterate_out_of_display_property only if we are
6543 popping after iteration over a string that came from a display
6544 property. Fix a typo in popping stretch info. Add an assertion
6545 for verifying that the iterator position is in sync with the bidi
6546 iterator.
6547 (handle_single_display_spec, get_overlay_strings_1)
6548 (push_display_prop): Fix initialization of paragraph direction for
6549 string when that of the parent object is not yet determined.
6550 (reseat_1): Call bidi_init_it to resync the bidi
6551 iterator with IT's position. (Bug#7616)
6552 (find_row_edges): If ROW->start.pos gives position
6553 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6554 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6555 Reset the from_disp_prop_p flag.
6556 (SAVE_IT, RESTORE_IT): New macros.
6557 (pos_visible_p, face_before_or_after_it_pos)
6558 (back_to_previous_visible_line_start)
6559 (move_it_in_display_line_to, move_it_in_display_line)
6560 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6561 (try_scrolling, redisplay_window, display_line): Use them when
6562 saving a temporary copy of the iterator and restoring it back.
6563 (back_to_previous_visible_line_start, reseat_1)
6564 (init_iterator): Empty the bidi cache "stack".
6565 (move_it_in_display_line_to): If iterator ended up at
6566 EOL, but we never saw any buffer positions smaller than
6567 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6568 motion in bidi-reordered lines.
6569 (move_it_in_display_line_to): Record prev_method and prev_pos
6570 immediately before the call to set_iterator_to_next. Fixes cursor
6571 motion in bidi-reordered lines with stretch glyphs and strings
6572 displayed in margins. (Bug#8133) (Bug#8867)
6573 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6574 TO_CHARPOS.
640c8776
SM
6575 (pos_visible_p): Support positions in bidi-reordered lines.
6576 Save and restore bidi cache.
0bb23927
EZ
6577
6578 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6579 (bidi_paragraph_info): Delete unused struct.
6580 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6581 (bidi_cache_start): New variable.
6582 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6583 to zero.
6584 (bidi_cache_fetch_state, bidi_cache_search)
6585 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6586 (bidi_cache_find, bidi_peek_at_next_level)
6587 (bidi_level_of_next_char, bidi_find_other_level_edge)
6588 (bidi_move_to_visually_next): Compare cache index with
6589 bidi_cache_start rather than with zero.
6590 (bidi_fetch_char): Accept new argument STRING; all callers
6591 changed. Support iteration over a string. Support strings with
6592 display properties. Support unibyte strings. Fix the type of
6593 `len' according to what STRING_CHAR_AND_LENGTH expects.
6594 (bidi_paragraph_init, bidi_resolve_explicit_1)
6595 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6596 (bidi_level_of_next_char, bidi_move_to_visually_next):
6597 Support iteration over a string.
0bb23927
EZ
6598 (bidi_set_sor_type, bidi_resolve_explicit_1)
6599 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6600 can now be zero (for strings); special values 0 and -1 were
6601 changed to -1 and -2, respectively.
6602 (bidi_char_at_pos): New function.
6603 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6604 Call it instead of FETCH_MULTIBYTE_CHAR.
6605 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6606 initialized to valid values.
6607 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6608 values.
6609 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6610 the test for valid cached positions. Fix the logic for looking up
6611 the sentinel state in the cache. GCPRO the Lisp string we are
6612 iterating.
6613 (bidi_push_it, bidi_pop_it): New functions.
6614 (bidi_initialize): Initialize the bidi cache start stack pointer.
6615 (bidi_cache_ensure_space): New function, refactored from part of
6616 bidi_cache_iterator_state. Don't assume the required size is just
6617 one BIDI_CACHE_CHUNK away.
6618 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6619 (bidi_count_bytes, bidi_char_at_pos): New functions.
6620 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6621 always valid if bidi_cache_idx is valid.
6622 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6623 is valid if it's going to be used.
6624 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6625 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6626 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6627 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6628 (bidi_find_other_level_edge, bidi_cache_start_stack):
6629 All variables related to cache indices are now EMACS_INT.
c965adc5 6630
0bb23927
EZ
6631 * dispextern.h (struct bidi_string_data): New structure.
6632 (struct bidi_it): New member `string'. Make flag members be 1-bit
6633 fields, and put them last in the struct.
640c8776
SM
6634 (compute_display_string_pos, compute_display_string_end):
6635 Update prototypes.
0bb23927
EZ
6636 (bidi_push_it, bidi_pop_it): Add prototypes.
6637 (struct iterator_stack_entry): New members bidi_p,
6638 paragraph_embedding, and from_disp_prop_p.
6639 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6640 (bidi_shelve_cache, bidi_unshelve_cache):
6641 Declare prototypes.
0bb23927
EZ
6642
6643 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6644 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6645 and vector-like objects.
6646
6647 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6648 cache around display iteration.
6649
6650 * window.c (Fwindow_end, window_scroll_pixel_based)
6651 (displayed_window_lines, Frecenter): Save and restore the bidi
6652 cache around display iteration.
6653
3bbd2265
LMI
66542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6655
6656 * editfns.c (Fdelete_region): Clarify the use of the named
6657 parameters (bug#6788).
6658
adc47434
MR
66592011-07-14 Martin Rudalics <rudalics@gmx.at>
6660
6661 * indent.c (Fvertical_motion): Set and restore w->pointm when
6662 saving and restoring the window's buffer (Bug#9006).
6663
837c31f8
LMI
66642011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6665
6666 * editfns.c (Fstring_to_char): Clarify just what is returned
6667 (bug#6576). Text by Eli Zaretskii.
6668
ac389d0c
JB
66692011-07-13 Juanma Barranquero <lekktu@gmail.com>
6670
6671 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6672
0be0ce47
EZ
66732011-07-13 Eli Zaretskii <eliz@gnu.org>
6674
6675 * buffer.c (mmap_find): Fix a typo.
6676
cd18e7e3
JB
66772011-07-13 Johan Bockgård <bojohan@gnu.org>
6678
6679 Fix execution of x selection hooks.
6680 * xselect.c (Qx_lost_selection_functions)
6681 (Qx_sent_selection_functions): New vars.
6682 (syms_of_xselect): DEFSYM them.
6683 (x_handle_selection_request): Pass Qx_sent_selection_functions
6684 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6685 (x_handle_selection_clear,x_clear_frame_selections):
6686 Pass Qx_lost_selection_functions rather than
6687 Vx_lost_selection_functions to Frun_hook_with_args.
6688
47ea7f44
PE
66892011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6690
ac389d0c 6691 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6692 The old code sometimes used this field without initializing it.
6693
47ea7f44
PE
6694 * alloc.c (gc_sweep): Don't read past end of array.
6695 In theory, the old code could also have corrupted Emacs internals,
6696 though it'd be very unlikely.
6697
bc985c87
AS
66982011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6699
6700 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6701 argument. (Bug#4026)
bc985c87 6702
0cf34688
LMI
67032011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6704
b3dadd76
LMI
6705 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6706 key" (bug#4257).
6707
0cf34688
LMI
6708 * window.c (Fset_window_start): Doc fix (bug#4199).
6709 (Fset_window_hscroll): Ditto.
6710
270768cd
PE
67112011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6712
077e3dda 6713 Fix minor new problems caught by GCC 4.6.1.
270768cd 6714 * term.c (init_tty): Remove unused local.
490011a6 6715 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6716 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6717 not used otherwise.
270768cd 6718
b1f58454
CY
67192011-07-12 Chong Yidong <cyd@stupidchicken.com>
6720
6721 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6722
22b9578d
LMI
67232011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6724
6e70ab07
LMI
6725 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6726 are the mini-buffer and the echo area (bug#3320).
6727
22b9578d
LMI
6728 * term.c (init_tty): Remove support for supdup, c10 and perq
6729 terminals, which are no longer supported (bug#1482).
6730
8974cc9f
JB
67312011-07-10 Johan Bockgård <bojohan@gnu.org>
6732
6733 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6734
a560d974
JD
67352011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6736
6737 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6738 for non-popups (Bug#3642).
6739
1dae0f0a
AS
67402011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6741
268c2c36 6742 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6743 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6744 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6745 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6746 * data.c (fmod): Likewise.
6747 * dispnew.c (swap_glyphs_in_rows): Likewise.
6748 * emacs.c (memory_warning_signal): Likewise.
6749 * floatfns.c (float_error): Likewise.
6750 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6751 (otf_open, font_otf_capability, generate_otf_features)
6752 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6753 Likewise.
6754 * image.c (pbm_read_file): Likewise.
6755 * indent.c (string_display_width): Likewise.
6756 * intervals.c (check_for_interval, search_for_interval)
6757 (inc_interval_count, count_intervals, root_interval)
6758 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6759 * lread.c (defalias): Likewise.
268c2c36 6760 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6761 * regex.c (set_image_of_range_1, set_image_of_range)
6762 (regex_grow_registers): Likewise.
6763 * sysdep.c (strerror): Likewise.
6764 * termcap.c (valid_filename_p, tprint, main): Likewise.
6765 * tparam.c (main): Likewise.
6766 * unexhp9k800.c (run_time_remap, save_data_space)
6767 (update_file_ptrs, read_header, write_header, calculate_checksum)
6768 (copy_file, copy_rest, display_header): Likewise.
6769 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6770 Likewise.
6771 * xdisp.c (check_it): Likewise.
6772 * xfaces.c (register_color, unregister_color, unregister_colors):
6773 Likewise.
6774 * xfns.c (print_fontset_result): Likewise.
6775 * xrdb.c (member, fatal, main): Likewise.
6776
99033785
PE
67772011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6778
6779 Fix minor problems found by static checking (Bug#9031).
6780 * chartab.c (char_table_set_range, map_sub_char_table):
6781 Remove unused locals.
6782 (uniprop_table): Now static.
6783 * composite.c (_work_char): Remove unused static var.
6784
9cb2ac56
JB
67852011-07-09 Juanma Barranquero <lekktu@gmail.com>
6786
6787 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6788
f25661f0
JD
67892011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6790
6791 * gtkutil.c (qttip_cb): Remove code without function.
6792
8278c4fe
EZ
67932011-07-09 Eli Zaretskii <eliz@gnu.org>
6794
6795 * w32.c (pthread_sigmask): New stub.
6796
1692ae2d 67972011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6798
8a6ebd58 6799 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6800 sigprocmask is portable only for single-threaded applications, and
6801 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6802 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6803 (LIBES): Use it.
6804 * callproc.c (Fcall_process):
6805 * process.c (create_process):
6806 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6807 Use pthread_sigmask, not sigprocmask.
123403e4 6808
1b854618
JD
68092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6810
6811 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6812 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6813 wrong (Bug#8591).
6814
3fe4b549
JD
68152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6816
0ce7e563
JD
6817 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6818 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6819 (xg_hide_tooltip): Fix comment.
6820
3fe4b549
JD
6821 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6822 in registerServicesMenuSendTypes.
6823 (validRequestorForSendType): Don't check ns_return_types.
6824
6825 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6826 ns_return_type.
6827
5df75e47
JR
68282011-07-08 Jason Rumney <jasonr@gnu.org>
6829
22610910
JR
6830 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6831 SH_SHOW for hidden windows (Bug#5482).
6832
5df75e47
JR
6833 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6834 frame struct members of non-existent frames (Bug#6284).
6835
699c10bd
JD
68362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6837
4393663b
JD
6838 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6839 variable firstTime not needed on OSX >= 10.6.
6840 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6841 >= 10.5. Use setKnobProportion, setDoubleValue.
6842
6843 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6844 (MAC_OS_X_VERSION_10_5): Define if not defined.
6845 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6846 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6847 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6848
6849 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6850 cString and lossyCString on OSX >= 10.4
6851
58179cce 6852 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6853 sizeToFit on OSX >= 10.2.
6854
6855 * nsimage.m (allocInitFromFile): Don't use deprecated method
6856 bestRepresentationForDevice on OSX >= 10.6.
6857
6858 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6859 to avoid warning.
6860
6861 * emacs.c: Declare unexec_init_emacs_zone.
6862
a63e0781
JD
6863 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6864
699c10bd
JD
6865 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6866
6867 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6868 on svcsMenu (Bug#8842).
6869
6870 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6871 ns_return_types.
6872 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6873
6874 * nsterm.m (QUTF8_STRING): Declare.
6875 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6876 (validRequestorForSendType): Return type is (id).
6877 Change indexOfObjectIdenticalTo to indexOfObject.
6878 Check if we have local selection before returning self (Bug#8842).
6879 (writeSelectionToPasteboard): Put local selection into paste board
6880 if we have a local selection (Bug#8842).
6881 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6882
6883 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6884 (ns_get_local_selection): Declare.
6885
54e10184
LMI
68862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6887
9888ff71
LMI
6888 * keymap.c (describe_map_tree): Don't insert a double newline at
6889 the end of the buffer (bug#1169) and return whether we inserted
6890 something.
6891
54e10184
LMI
6892 * callint.c (Fcall_interactively): Change "reading args" to
6893 "providing args" to try to clarify what it does (bug#1010).
6894
15fa4783
KH
68952011-07-07 Kenichi Handa <handa@m17n.org>
6896
6897 * composite.c (composition_compute_stop_pos): Ignore a static
6898 composition starting before CHARPOS (Bug#8915).
6899
6900 * xdisp.c (handle_composition_prop): Likewise.
6901
a8815b00
EZ
69022011-07-07 Eli Zaretskii <eliz@gnu.org>
6903
6904 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6905 (Bug#9015)
6906
ef7b981d 69072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6908
6909 * character.h (unicode_category_t): New enum type.
6910
6911 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6912 (Qchar_code_property_table): New variable.
6913 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6914 (UNIPROP_COMPRESSED_FORM_P): New macros.
6915 (char_table_ascii): Uncompress the compressed values.
6916 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6917 Uncompress the compressed values.
ac389d0c 6918 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6919 (char_table_ref_and_range): Uncompress the compressed values.
6920 (sub_char_table_set): New arg is_uniprop. Callers changed.
6921 Uncompress the compressed values.
6922 (sub_char_table_set_range): Args changed. Callers changed.
6923 (char_table_set_range): Adjuted for the above change.
6924 (map_sub_char_table): Delete args default_val and parent. Add arg
6925 top. Give decoded values to a Lisp function.
640c8776 6926 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6927 values to a Lisp function. Gcpro more variables.
6928 (uniprop_table_uncompress)
6929 (uniprop_decode_value_run_length): New functions.
6930 (uniprop_decoder, uniprop_decoder_count): New variables.
6931 (uniprop_get_decoder, uniprop_encode_value_character)
6932 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6933 New functions.
6934 (uniprop_encoder, uniprop_encoder_count): New variables.
6935 (uniprop_get_encoder, uniprop_table)
6936 (Funicode_property_table_internal, Fget_unicode_property_internal)
6937 (Fput_unicode_property_internal): New functions.
6938 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6939 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6940 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6941 char-code-property-alist.
6942
640c8776 6943 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6944 Vunicode_category_table.
6945
640c8776 6946 * font.c (font_range): Adjust for the change of
c805dec0
KH
6947 Vunicode_category_table.
6948
76b397fb
DN
69492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6950
6951 * m/iris4d.h: Remove file, move contents ...
6952 * s/irix6-5.h: ... here.
6953
22b4128e
PE
69542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6955
6956 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6957 * alloc.c (mark_buffer):
6958 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6959 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6960 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6961 This isn't true in general, and it's particularly not true
6962 if Emacs is configured with --with-wide-int.
6963 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6964 New macros, used in the buffer.c change.
6965
869795d6
JD
69662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6967
6968 * xsettings.c: Use both GConf and GSettings if both are available.
6969 (store_config_changed_event): Add comment.
6970 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6971 (store_tool_bar_style_changed): New functions.
5e617bc2 6972 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6973 (struct xsettings): Move font inside HAVE_XFT.
6974 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6975 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6976 Move inside HAVE_XFT.
640c8776 6977 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6978 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6979 also.
6980 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6981 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6982 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6983 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6984 (parse_settings): Move check for font inside HAVE_XFT.
6985 (read_settings, apply_xft_settings): Add comment.
6986 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6987 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6988 call store_font_name_changed.
6989 (xft_settings_event): Add comment.
6990 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6991 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6992 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6993 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6994 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6995 (xsettings_get_system_font, xsettings_get_system_normal_font):
6996 Add comment.
869795d6 6997
d8ed26bd
PE
69982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6999
7000 Random fixes. E.g., (random) never returned negative values.
7001 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7002 subseconds part to the entropy, as that's a bit more random.
7003 Prefer signed to unsigned, since the signedness doesn't matter and
7004 in general we prefer signed. When given a limit, use a
7005 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7006 latter isn't right if USE_2_TAGS_FOR_INTS.
7007 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7008 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7009
cabf1cac
SM
70102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7011
7012 * textprop.c (text_property_stickiness):
7013 Obey Vtext_property_default_nonsticky.
7014 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7015 * w32fns.c (syms_of_w32fns):
7016 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7017
6e9b2be9
PE
70182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7019
7020 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7021 This is more efficient than Ffile_directory_p and avoids a minor race.
7022
90186c68
LMI
70232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7024
7c301272
LMI
7025 * buffer.c (Foverlay_put): Say what the return value is
7026 (bug#7835).
7027
c4f2d8d4
LMI
7028 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7029 is a directory before asking whether to use the file name
7030 (bug#7564).
ad637907
LMI
7031 (barf_or_query_if_file_exists): Make the "File is a directory"
7032 error be more correct.
c4f2d8d4 7033
90186c68
LMI
7034 * fns.c (Frequire): Remove the mention of the .gz files, since
7035 that's installation-specific, but keep the mention of
7036 `get-load-suffixes'.
7037
da64016e
PE
70382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7039
7040 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7041 Report string overflow if the output is too long.
7042
7d47b580
JB
70432011-07-04 Juanma Barranquero <lekktu@gmail.com>
7044
a555cb87
JB
7045 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7046 (syms_of_gnutls): Remove duplicate DEFSYM for
7047 Qgnutls_bootprop_verify_hostname_error, an error for
7048 Qgnutls_bootprop_verify_error (which is no longer used).
7049
7d47b580
JB
7050 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7051 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7052 Also (re)move comments that are misplaced or no longer relevant.
7053
1e49bfab
LMI
70542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7055
7056 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7057
1485f4c0
CY
70582011-07-03 Chong Yidong <cyd@stupidchicken.com>
7059
7060 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7061 and background color parameters if they have been changed.
7062
a9ab721e
LMI
70632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7064
7065 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7066
cf7cff57
PE
70672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7068
2e13213d
PE
7069 * xsettings.c (SYSTEM_FONT): Define only when used.
7070 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7071
cf7cff57
PE
7072 * keymap.c (access_keymap_1): Now static.
7073
7a8e04f7
CY
70742011-07-02 Chong Yidong <cyd@stupidchicken.com>
7075
7076 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7077 leave any prefix arg for the up event (Bug#1586).
7078
61352f62
LMI
70792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7080
69bb1ef7
LMI
7081 * lread.c (syms_of_lread): Mention single symbols defined by
7082 `defvar' or `defconst' (bug#7154).
7083
61352f62 7084 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7085 (Frequire): Mention get-load-suffixes.
61352f62 7086
28545e04
MR
70872011-07-02 Martin Rudalics <rudalics@gmx.at>
7088
7089 * window.h (window): Remove clone_number slot.
7090 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7091 Remove.
7092 (make_parent_window, make_window, saved_window)
7093 (Fset_window_configuration, save_window_save): Don't deal with
7094 clone numbers.
7095 * buffer.c (Qclone_number): Remove declaration.
7096 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7097
3349e122
SM
70982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7099
7100 Add multiple inheritance to keymaps.
7101 * keymap.c (Fmake_composed_keymap): New function.
7102 (Fset_keymap_parent): Simplify.
7103 (fix_submap_inheritance): Remove.
7104 (access_keymap_1): New function extracted from access_keymap to handle
7105 embedded parents and handle lists of maps.
7106 (access_keymap): Use it.
7107 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7108 (Fcopy_keymap): Handle embedded parents.
7109 (Fcommand_remapping, define_as_prefix): Simplify.
7110 (Fkey_binding): Simplify.
7111 (syms_of_keymap): Move minibuffer-local-completion-map,
7112 minibuffer-local-filename-completion-map,
7113 minibuffer-local-must-match-map, and
7114 minibuffer-local-filename-must-match-map to Elisp.
7115 (syms_of_keymap): Defsubr make-composed-keymap.
7116 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7117 (parse_menu_item): Trivial simplification.
7118
3279eb87
GM
71192011-07-01 Glenn Morris <rgm@gnu.org>
7120
7121 * Makefile.in (SETTINGS_LIBS): Fix typo.
7122
4550efdf
KI
71232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7124
7125 * coding.c (Fencode_coding_string): Record the last coding system
7126 used, as the function doc string says (bug#8738).
7127
0949d2b6
JD
71282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7129
7130 * xsettings.c (store_monospaced_changed): Take new font as arg and
7131 check for change against current_mono_font.
7132 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7133 (emacs_settings_constructor, emacs_settings_get_property)
7134 (emacs_settings_set_property, emacs_settings_class_init)
7135 (emacs_settings_init, gsettings_obj): Remove.
7136 (something_changedCB): New function for HAVE_GSETTINGS.
7137 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7138 with value as argument.
7139 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7140 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7141 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7142 "changed".
7143
7144 * xgselect.c: Add defined (HAVE_GSETTINGS).
7145 (xgselect_initialize): Ditto.
7146
7147 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7148 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7149 xg_select.
7150
bbc6b304
PE
71512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7152
7153 * eval.c (struct backtrace): Simplify and port the data structure.
7154 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7155 signed bit field, as this assumption is not portable and it makes
7156 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7157 "char debug_on_exit : 1" as this is not portable either; instead,
7158 use the portable "unsigned int debug_on_exit : 1". Remove unused
7159 member evalargs. Remove obsolete comments about cc bombing out.
7160
9851bfc5
JD
71612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7162
51bb811f 7163 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7164 Let HAVE_GSETTINGS override HAVE_GCONF.
7165 (store_monospaced_changed): New function.
7166 (EMACS_SETTINGS): A new type derived from GObject to handle
7167 GSettings notifications.
7168 (emacs_settings_constructor, emacs_settings_get_property)
7169 (emacs_settings_set_property, emacs_settings_class_init):
7170 New functions.
7171 (gsettings_client, gsettings_obj): New variables.
7172 (GSETTINGS_SCHEMA): New define.
7173 (something_changedCB): Call store_monospaced_changed.
7174 (init_gsettings): New function.
7175 (xsettings_initialize): Call init_gsettings.
7176 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7177 to NULL.
7178
640c8776 7179 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7180 GCONF_CFLAGS/LIBS.
7181
5386012d
MR
71822011-06-29 Martin Rudalics <rudalics@gmx.at>
7183
7184 * window.c (resize_root_window, grow_mini_window)
7185 (shrink_mini_window): Rename Qresize_root_window to
7186 Qwindow_resize_root_window and Qresize_root_window_vertically to
7187 Qwindow_resize_root_window_vertically.
7188
f13e0b08
PE
71892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7190
7191 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7192
94515237
JB
71932011-06-27 Juanma Barranquero <lekktu@gmail.com>
7194
7195 * makefile.w32-in: Redesign dependencies so they reflect more
7196 clearly which files are directly included by each source file,
7197 and not through other includes.
7198
e43b6e43
MR
71992011-06-27 Martin Rudalics <rudalics@gmx.at>
7200
7201 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7202 (sort_overlays, overlay_strings): When an overlay's clone number
7203 matches the window's clone number process the overlay even if
7204 the overlay's window property doesn't match the current window.
7205
d68443dc
MR
7206 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7207 (Fwindow_hchild): Rename to Fwindow_left_child.
7208 (Fwindow_next): Rename to Fwindow_next_sibling.
7209 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7210 (resize_window_check): Rename to window_resize_check.
7211 (resize_window_apply): Rename to window_resize_apply.
7212 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7213 (Fdelete_other_windows_internal, resize_frame_windows)
7214 (Fsplit_window_internal, Fdelete_window_internal)
7215 (grow_mini_window, shrink_mini_window)
7216 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7217
c7e73be5
JD
72182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7219
7220 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7221 (emacs_fixed_set_min_size): Remove.
7222 (emacs_fixed_new): Take frame as argument.
7223
7224 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7225 (_EmacsFixedPrivate): Remove minwidth/height.
7226 Add struct frame *f.
7227 (emacs_fixed_init): Initialize priv->f.
7228 (get_parent_class, emacs_fixed_set_min_size): Remove.
7229 (emacs_fixed_new): Set priv->f to argument.
7230 (emacs_fixed_get_preferred_width)
7231 (emacs_fixed_get_preferred_height): Use min_width/height from
7232 frames size_hint to set minimum and natural (Bug#8919).
7233 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7234 and use min_width/height from frames size_hint to set
7235 min_width/height (Bug#8919).
7236
7237 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7238 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7239 Fix indentation.
c7e73be5 7240
cf99dcf8
EZ
72412011-06-26 Eli Zaretskii <eliz@gnu.org>
7242
7243 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7244 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7245 called at ZV.
7246
029529ac
CY
72472011-06-26 Chong Yidong <cyd@stupidchicken.com>
7248
7249 * process.c (wait_reading_process_output): Bypass select if
7250 waiting for a cell while ignoring keyboard input, and input is
7251 pending. Suggested by Jan Djärv (Bug#8869).
7252
7a7ef429
PE
72532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7254
7255 Use gnulib's dup2 module instead of rolling our own.
7256 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7257
11fdef7d 72582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7259
7260 * dispnew.c (scrolling_window): Before scrolling, turn off a
7261 mouse-highlight in the window being scrolled.
7262
cd3520a4
JB
72632011-06-24 Juanma Barranquero <lekktu@gmail.com>
7264
7265 Move DEFSYM to lisp.h and use everywhere.
7266
7267 * character.h (DEFSYM): Move declaration...
7268 * lisp.h (DEFSYM): ...here.
7269
7270 * gnutls.c:
7271 * minibuf.c:
7272 * w32menu.c:
7273 * w32proc.c:
7274 * w32select.c: Don't include character.h.
7275
7276 * alloc.c (syms_of_alloc):
7277 * buffer.c (syms_of_buffer):
7278 * bytecode.c (syms_of_bytecode):
7279 * callint.c (syms_of_callint):
7280 * casefiddle.c (syms_of_casefiddle):
7281 * casetab.c (init_casetab_once):
7282 * category.c (init_category_once, syms_of_category):
7283 * ccl.c (syms_of_ccl):
7284 * cmds.c (syms_of_cmds):
7285 * composite.c (syms_of_composite):
7286 * dbusbind.c (syms_of_dbusbind):
7287 * dired.c (syms_of_dired):
7288 * dispnew.c (syms_of_display):
7289 * doc.c (syms_of_doc):
7290 * editfns.c (syms_of_editfns):
7291 * emacs.c (syms_of_emacs):
7292 * eval.c (syms_of_eval):
7293 * fileio.c (syms_of_fileio):
7294 * fns.c (syms_of_fns):
7295 * frame.c (syms_of_frame):
7296 * fringe.c (syms_of_fringe):
7297 * insdel.c (syms_of_insdel):
7298 * keymap.c (syms_of_keymap):
7299 * lread.c (init_obarray, syms_of_lread):
7300 * macros.c (syms_of_macros):
7301 * msdos.c (syms_of_msdos):
7302 * print.c (syms_of_print):
7303 * process.c (syms_of_process):
7304 * search.c (syms_of_search):
7305 * sound.c (syms_of_sound):
7306 * syntax.c (init_syntax_once, syms_of_syntax):
7307 * terminal.c (syms_of_terminal):
7308 * textprop.c (syms_of_textprop):
7309 * undo.c (syms_of_undo):
7310 * w32.c (globals_of_w32):
7311 * window.c (syms_of_window):
7312 * xdisp.c (syms_of_xdisp):
7313 * xfaces.c (syms_of_xfaces):
7314 * xfns.c (syms_of_xfns):
7315 * xmenu.c (syms_of_xmenu):
7316 * xsettings.c (syms_of_xsettings):
7317 * xterm.c (syms_of_xterm): Use DEFSYM.
7318
4228cf16
TZ
73192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7320
cd3520a4 7321 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7322
7fcccf1e
PE
73232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7324
7efb4e0e
PE
7325 Integer and buffer overflow fixes (Bug#8873).
7326
ff5844ad
PE
7327 * print.c (printchar, strout): Check for string overflow.
7328 (PRINTPREPARE, printchar, strout):
7329 Don't set size unless allocation succeeds.
7330
90532f02
PE
7331 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7332 for sizes. Check for string overflow more accurately.
7333 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7334
6d84508d
PE
7335 * macros.c: Integer and buffer overflow fixes.
7336 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7337 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7338 Use ptrdiff_t, not int, for sizes.
7339 Don't increment bufsize until after realloc succeeds.
7340 Check for size-calculation overflow.
7341 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7342
437b2cb4
PE
7343 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7344
8b9ac8b4
PE
7345 * lread.c: Integer overflow fixes.
7346 (read_integer): Radix is now EMACS_INT, not int,
7347 to improve quality of diagnostics for out-of-range radices.
7348 Calculate buffer size correctly for out-of-range radices.
7349 (read1): Check for integer overflow in radices, and in
7350 read-circle numbers.
82cb60d3
PE
7351 (read_escape): Avoid int overflow.
7352 (Fload, openp, read_buffer_size, read1)
7353 (substitute_object_recurse, read_vector, read_list, map_obarray):
7354 Use ptrdiff_t, not int, for sizes.
7355 (read1): Use EMACS_INT, not int, for sizes.
20270765 7356 Check for size overflow.
8b9ac8b4 7357
7fcccf1e
PE
7358 * image.c (cache_image): Check for size arithmetic overflow.
7359
bfbbd7e7
PE
7360 * lread.c: Integer overflow issues.
7361 (saved_doc_string_size, saved_doc_string_length)
7362 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7363 Now ptrdiff_t, not int.
7364 (read1): Don't assume doc string length fits in int. Check for
7365 out-of-range doc string lengths.
7366 (read_list): Don't assume file position fits in int.
39019e54 7367 (read_escape): Check for hex character overflow.
bfbbd7e7 7368
4e323265
LL
73692011-06-22 Leo Liu <sdl.web@gmail.com>
7370
7371 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7372 Move to minibuffer.el.
7373
85fece3e
PE
73742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7375
20b84ce9 7376 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7377 The following patches are for when GLYPH_DEBUG && !XASSERT.
7378 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7379 * dispnew.c (flush_stdout):
7380 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7381 Mark as externally visible.
7382 * dispnew.c (check_window_matrix_pointers): Now static.
7383 * dispnew.c (window_to_frame_vpos):
7384 * xfns.c (unwind_create_frame):
7385 * xterm.c (x_check_font): Remove unused local.
7386 * scroll.c (CHECK_BOUNDS):
7387 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7388 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7389 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7390 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7391 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7392 Now static.
7393 (debug_method_add): Use va_list and vsprintf rather than relying
7394 on undefined behavior with wrong number of arguments.
7395 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7396 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7397 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7398 since we're not interested in debugging glyphs with old libraries.
7399 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7400 GCC 4.6.0's static checking.
7401
0766b489
PE
74022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7403
31fd4b32
PE
7404 Integer overflow and signedness fixes (Bug#8873).
7405 A few related buffer overrun fixes, too.
7406
b79e8648
PE
7407 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7408
0766b489
PE
7409 * dispextern.h (struct face.stipple):
7410 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7411 (x_bitmap_mask, x_allocate_bitmap_record)
7412 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7413 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7414 (x_create_bitmap_from_xpm_data):
7415 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7416 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7417 (.bitmaps_last):
7418 * xfaces.c (load_pixmap):
7419 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7420 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7421 (.bitmaps_last, struct x_output.icon_bitmap):
7422 Use ptrdiff_t, not int, for bitmap indexes.
7423 (x_allocate_bitmap_record): Check for size overflow.
7424 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7425
b081724f
PE
7426 Use ptrdiff_t, not int, for overlay counts.
7427 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7428 * editfns.c (overlays_around, get_pos_property):
7429 * textprop.c (get_char_property_and_overlay):
7430 * xdisp.c (next_overlay_change, note_mouse_highlight):
7431 * xfaces.c (face_at_buffer_position):
21514da7
PE
7432 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7433 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7434 (Fnext_overlay_change, Fprevious_overlay_change)
7435 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7436 Use ptrdiff_t, not int, for sizes.
21514da7 7437 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7438
3de73e5e
PE
7439 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7440
2606c57b
PE
7441 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7442 (x_session_initialize): Do not assume string length fits in int.
7443
aaafe47a
PE
7444 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7445 This is unlikely, but can occur if DPI is outlandish.
7446
2674ddc8 7447 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7448 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7449
28154962
PE
7450 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7451 * xrdb.c (magic_file_p, search_magic_path):
7452 Omit last arg SUFFIX; it was always 0. All callers changed.
7453 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7454
7de51af5
PE
7455 * xfont.c (xfont_match): Avoid need for strlen.
7456
25ed6cc3
PE
7457 * xfns.c: Don't assume strlen fits in int.
7458 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7459
4eab31dd
PE
7460 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7461 not unsigned long, as we prefer signed integers. All callers changed.
7462 Detect integer overflow in repeat count.
7463 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7464 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7465
171e2a58
PE
7466 * termcap.c: Don't assume sizes fit in int and never overflow.
7467 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7468 (gobble_line): Check for size-calculation overflow.
7469
ad39faca 7470 * minibuf.c (Fread_buffer):
6e5bb2dc 7471 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7472 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7473 Don't assume string length fits in int.
7474
52c61c22 7475 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7476 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7477
b5b8c9e5
PE
7478 * font.c: Don't assume string length fits in int.
7479 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7480 Use ptrdiff_t, not int.
ccd6111c
PE
7481 (font_intern_prop): Don't assume string length fits in int.
7482 Don't assume integer property fits in fixnum.
7483 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7484
882f0d81 7485 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7486 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7487 Reformulate so as not to need the command string.
7488 Invoke gzip -cd rather than gunzip, as it's more portable.
7489 (lock_info_type, lock_file_1, lock_file):
7490 Don't assume pid_t and time_t fit in unsigned long.
7491 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7492 (current_lock_owner): Prefer signed type for sizes.
7493 Use memcpy, not strncpy, where memcpy is what is really wanted.
7494 Don't assume (via atoi) that time_t and pid_t fit in int.
7495 Check for time_t and/or pid_t out of range, e.g., via a network share.
7496 Don't alloca where an auto var works fine.
7497
93f4cf88
PE
7498 * fileio.c: Fix some integer overflow issues.
7499 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7500 Don't assume string length fits in int.
7501 (directory_file_name): Don't assume string length fits in long.
7502 (make_temp_name): Don't assume pid fits in int, or that its print
7503 length is less than 20.
7504
f3e92b69
PE
7505 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7506
1bfdaf10
PE
7507 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7508
35016e9a
PE
7509 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7510
3d1e65a1
PE
7511 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7512 We prefer signed integers, even for size calculations.
7513
0b963a93
PE
7514 * emacs.c: Don't assume string length fits in 'int'.
7515 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7516 (main): Don't invoke strlen when not needed.
7517
573f4b54
PE
7518 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7519 (XD_DEBUG_MESSAGE): Don't waste a byte.
7520
989f33ba
PE
7521 * callproc.c (getenv_internal_1, getenv_internal)
7522 (Fgetenv_internal):
965d34eb
PE
7523 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7524
e4d29b33
PE
7525 * lread.c (invalid_syntax): Omit length argument.
7526 All uses changed. This doesn't fix a bug, but it simplifies the
7527 code away from its former Hollerith-constant appearance, and it's
7528 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7529 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7530
eb49b136
PE
7531 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7532 This didn't break anything, but it didn't help either.
7533 It's confusing to put a bogus integer in a place where the actual
7534 value does not matter.
9f62aeb1 7535 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7536 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7537
15375a22
PE
7538 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7539 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7540 implementation.
b61cc01c
PE
7541 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7542 We prefer signed types, and the value cannot exceed the EMACS_INT
7543 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7544 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7545 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7546 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7547
53b2623d
PE
7548 * indent.c (sane_tab_width): New function.
7549 (current_column, scan_for_column, Findent_to, position_indentation)
7550 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7551 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7552
51cab52b 7553 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7554
f2ed8a70
PE
7555 * lisp.h (lint_assume): New macro.
7556 * composite.c (composition_gstring_put_cache):
7557 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7558
abe80cc6
PE
7559 * editfns.c, insdel.c:
7560 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7561
b02c740e
PE
7562 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7563
ebc96716
PE
7564 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7565
b4e50fa0 7566 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7567 Use much-faster test for byte-length change.
311d5d7c 7568 Don't assume string byte-length fits in 'int'.
a4cf38e4 7569 Check that character arg fits in 'int'.
85461888 7570 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7571
c0c1ee9f
PE
7572 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7573
a498d7f4
PE
7574 * fns.c (concat): Catch string overflow earlier.
7575 Do not rely on integer wraparound.
7576
51cab52b
PE
7577 * dispextern.h (struct it.overlay_strings_charpos)
7578 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7579 * xdisp.c (forward_to_next_line_start)
7580 (back_to_previous_visible_line_start)
7581 (reseat_at_next_visible_line_start, next_element_from_buffer):
7582 Don't arbitrarily truncate the value of 'selective' to int.
7583
76031fad
PE
7584 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7585
5eb55db9
PE
7586 * composite.c: Don't truncate sizes to 'int'.
7587 (composition_gstring_p, composition_reseat_it)
7588 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7589 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7590 not EMACS_UINT, for indexes.
5eb55db9 7591
0703a717
PE
7592 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7593
d6202519
PE
7594 * buffer.c: Include <verify.h>.
7595 (struct sortvec.priority, struct sortstr.priority):
8961a454 7596 Now EMACS_INT, not int.
c20998a7 7597 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7598 (struct sortstr.size, record_overlay_string)
7599 (struct sortstrlist.size, struct sortlist.used):
7600 Don't truncate size to int.
7601 (record_overlay_string): Check for size-calculation overflow.
d6202519 7602 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7603
d5a19415
JM
76042011-06-22 Jim Meyering <meyering@redhat.com>
7605
029529ac 7606 Don't leak an XBM-image-sized buffer
d5a19415
JM
7607 * image.c (xbm_load): Free the image buffer after using it.
7608
a9041e6c
PE
76092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7610
7611 Port to Sun C.
7612 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7613 that Sun C diagnosed.
7614 * fns.c (secure_hash): Fix pointer signedness issue.
7615 * intervals.c (static_offset_intervals): New function.
7616 (offset_intervals): Use it.
7617
7f3f739f
LL
76182011-06-21 Leo Liu <sdl.web@gmail.com>
7619
7620 * deps.mk (fns.o):
7621 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7622 sha512.h.
7623
7624 * fns.c (secure_hash): Rename from crypto_hash_function and change
7625 the first arg to accept symbols.
5b66d427 7626 (Fsecure_hash): New primitive.
7f3f739f
LL
7627 (syms_of_fns): New symbols.
7628
76147d94
DD
76292011-06-20 Deniz Dogan <deniz@dogan.se>
7630
7631 * process.c (Fset_process_buffer): Clarify return value in
7632 docstring.
7633
7d7d0045
CY
76342011-06-18 Chong Yidong <cyd@stupidchicken.com>
7635
7636 * dispnew.c (add_window_display_history): Use BVAR.
7637
7638 * xdisp.c (debug_method_add): Use BVAR.
7639 (check_window_end, dump_glyph_matrix, dump_glyph)
7640 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7641
7642 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7643 Likewise.
7644
7645 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7646 check till after the cache is created in init_frame_faces.
7647
ff2bc410
SM
76482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7649
7650 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7651
28177add
PE
76522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7653
dd3482fe
PE
7654 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7655 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7656 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7657
393d71f3 7658 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7659 * fileio.c (Finsert_file_contents):
7660 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7661 Remove the old (too-loose) buffer overflow checks.
7662 They weren't needed, since make_gap checks for buffer overflow.
7663 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7664 The old code merely checked for Emacs fixnum overflow, and relied
7665 on undefined (wraparound) behavior. The new code avoids undefined
7666 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7667
2e6813b0 7668 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7669 Tune. Don't use wider integers than needed. Don't use alloca.
7670 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7671
599a9e4f
PE
7672 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7673
99561444
PE
7674 * insdel.c, lisp.h (buffer_overflow): New function.
7675 (insert_from_buffer_1, replace_range, replace_range_2):
7676 * insdel.c (make_gap_larger):
7677 * editfns.c (Finsert_char):
7678 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7679
28177add
PE
7680 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7681
e69dafad
PE
76822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7683
4baa020d 7684 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7685
b1c46f02
PE
7686 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7687 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7688
e69dafad
PE
7689 * fileio.c: Don't assume EMACS_INT fits in off_t.
7690 (emacs_lseek): New static function.
7691 (Finsert_file_contents, Fwrite_region): Use it.
7692 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7693
566684ea
PE
7694 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7695
e6966cd6
PE
7696 * fns.c: Don't overflow int when computing a list length.
7697 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7698 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7699 truncation on 64-bit hosts. Check for QUIT every
7700 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7701 faster and is responsive enough.
7702 (Flength): Report an error instead of overflowing an integer.
7703 (Fsafe_length): Return a float if the value is not representable
7704 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7705 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7706 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7707
dd0b0efb
PE
7708 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7709 (header_size, word_size): New constants.
7710 (allocate_vectorlike): Don't check size overflow here.
7711 (allocate_vector): Check it here instead, since this is the only
7712 caller of allocate_vectorlike that could cause overflow.
7713 Check that the new vector's length is representable as a fixnum.
7714
86fe5cfe
PE
7715 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7716 The previous code was bogus. For example, next_almost_prime (32)
7717 returned 39, which is undesirable as it is a multiple of 3; and
7718 next_almost_prime (24) returned 25, which is a multiple of 5 so
7719 why was the code bothering to check for multiples of 7?
7720
80e88859
PE
7721 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7722
4a2f0ad6
PE
7723 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7724
f66c7cf8
PE
7725 Variadic C functions now count arguments with ptrdiff_t.
7726 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7727 Back then I didn't know that the Emacs coding style prefers signed int.
7728 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7729 were being counted with int, which may truncate counts on 64-bit
7730 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7731 * lisp.h (struct Lisp_Subr.function.aMANY)
7732 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7733 Arg counts are now ptrdiff_t, not size_t.
7734 All variadic functions and their callers changed accordingly.
7735 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7736 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7737 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7738 * callint.c (Fcall_interactively): Check arg count for overflow,
7739 to avoid potential buffer overrun. Use signed char, not 'int',
7740 for 'varies' array, so that we needn't bother to check its size
7741 calculation for overflow.
7742 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7743 * eval.c (apply_lambda):
7744 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7745 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7746 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7747
a1759b76
PE
7748 * callint.c (Fcall_interactively): Don't use index var as event count.
7749
d96be9fc
PE
7750 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7751 * mem-limits.h (SIZE): Remove; no longer used.
7752
a690a978 7753 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7754
578c21e6
PE
7755 Remove unnecessary casts.
7756 * xterm.c (x_term_init):
7757 * xfns.c (x_set_border_pixel):
7758 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7759 These aren't needed now that we assume ANSI C.
7760
96f53c6c
PE
7761 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7762 It's more likely to cause problems (due to unsigned overflow)
7763 than to cure them.
7764
83c77d31
PE
7765 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7766
ee2079f1
PE
7767 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7768
6da65536
PE
7769 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7770
7147c4a4
PE
7771 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7772
193e32d9
PE
7773 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7774
e5533da6
PE
7775 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7776
9910e595
PE
7777 GLYPH_CODE_FACE returns EMACS_INT, not int.
7778 * dispextern.h (merge_faces):
7779 * xfaces.c (merge_faces):
01103c44
PE
7780 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7781 Don't assume EMACS_INT fits in int.
9910e595 7782
2638320e
PE
7783 * character.h (CHAR_VALID_P): Remove unused parameter.
7784 * fontset.c, lisp.h, xdisp.c: All uses changed.
7785
045eb8d9
PE
7786 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7787
c1f134b5
PE
7788 * fns.c (concat): Minor tuning based on overflow analysis.
7789 This doesn't fix any bugs. Use int to hold character, instead
7790 of constantly refetching from Emacs object. Use XFASTINT, not
7791 XINT, for value known to be a character. Don't bother comparing
7792 a single byte to 0400, as it's always less.
7793
395fcb93 7794 * floatfns.c (Fexpt):
327eeec8
PE
7795 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7796
abbd3d23
PE
7797 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7798 for characters.
7799
684a03ef
PE
7800 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7801
0fed43f3
PE
7802 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7803 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7804 incorrectly succeed when S was a string, because 4294967386 was
7805 truncated before it was used.
7806
8fd02eb7
PE
7807 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7808 Otherwise, an out-of-range integer could cause undefined behavior
7809 on a 64-bit host.
7810
f8c86b69
PE
7811 * composite.c: Use int, not EMACS_INT, for characters.
7812 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7813 EMACS_INT, for values that are known to be in character range.
7814 This doesn't fix any bugs but is the usual style inside Emacs and
7815 may generate better code on 32-bit machines.
7816
34206dd2
PE
7817 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7818 This is for reasons similar to the recent CHAR_STRING fix.
7819 * charset.c (Fencode_char): Check that character arg is actually
7820 a character. Pass an int to ENCODE_CHAR.
7821 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7822 wider than 'int', as a compile-time check to prevent future regressions
7823 in this area.
7824
c5958d4c 7825 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7826
7827 Make sure a 64-bit char is never passed to CHAR_STRING.
7828 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7829 by silently ignoring the top 32 bits, allowing some values
7830 that were far too large to be valid characters.
7831 * character.h: Include <verify.h>.
7832 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7833 arguments are no wider than unsigned, as a compile-time check
7834 to prevent future regressions in this area.
7835 * data.c (Faset):
01103c44 7836 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7837 (Fsubst_char_in_region):
7838 * fns.c (concat):
7839 * xdisp.c (decode_mode_spec_coding):
7840 Adjust to CHAR_STRING's new requirement.
7841 * editfns.c (Finsert_char, Fsubst_char_in_region):
7842 * fns.c (concat): Check that character args are actually
7843 characters. Without this test, these functions did the wrong
7844 thing with wildly out-of-range values on 64-bit hosts.
7845
d37ca623
PE
7846 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7847 These casts should not be needed on 32-bit hosts, either.
7848 * keyboard.c (read_char):
7849 * lread.c (Fload): Remove casts to unsigned.
7850
ea204efb
PE
7851 * lisp.h (UNSIGNED_CMP): New macro.
7852 This fixes comparison bugs on 64-bit hosts.
7853 (ASCII_CHAR_P): Use it.
7854 * casefiddle.c (casify_object):
01103c44 7855 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7856 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7857 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7858 * dispextern.h (FACE_FROM_ID):
7859 * keyboard.c (read_char): Use UNSIGNED_CMP.
7860
41cb286c
PE
7861 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7862 not to EMACS_INT, to avoid GCC warning.
7863
4a1b9832
PE
7864 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7865
55daad71
PE
7866 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7867 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7868 isn't needed on 32-bit machines.
8f95c75c 7869
01103c44
PE
7870 * buffer.c (Fgenerate_new_buffer_name):
7871 Use EMACS_INT for count, not int.
0ceccced 7872 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7873
7874 * data.c (Qcompiled_function): Now static.
7875
c6f072e7
PE
7876 * window.c (window_body_lines): Now static.
7877
20ce5912
PE
7878 * image.c (gif_load): Rename local to avoid shadowing.
7879
9c4c5f81
PE
7880 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7881 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7882 * alloc.c (make_save_value): Integer argument is now of type
7883 ptrdiff_t, not int.
7884 (mark_object): Use ptrdiff_t, not int.
7885 * lisp.h (pD): New macro.
7886 * print.c (print_object): Use it.
7887
c0c5c8ae
PE
7888 * alloc.c: Use EMACS_INT, not int, to count objects.
7889 (total_conses, total_markers, total_symbols, total_vector_size)
7890 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7891 (total_free_floats, total_floats, total_free_intervals)
7892 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7893 Now EMACS_INT, not int. All uses changed.
7894 (Fgarbage_collect): Compute overall total using a double, so that
7895 integer overflow is less likely to be a problem. Check for overflow
7896 when converting back to an integer.
5a25e253
PE
7897 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7898 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7899 These were 'int' variables that could overflow on 64-bit hosts;
7900 they were never used, so remove them instead of repairing them.
211a0b2a 7901 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7902 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7903 Previously, this ceilinged at INT_MAX, but that doesn't work on
7904 64-bit machines.
e46bb31a 7905 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7906
c78baabf 7907 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7908 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7909 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7910 when a (possibly-narrower) signed value would do just as well.
7911 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7912
c9d624c6
PE
7913 * alloc.c: Catch some string size overflows that we were missing.
7914 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7915 for convenience in STRING_BYTES_MAX.
7916 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7917 The definition here is exact; the one in lisp.h was approximate.
7918 (allocate_string_data): Check for string overflow. This catches
7919 some instances we weren't catching before. Also, it catches
7920 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7921 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7922 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7923
c9d624c6
PE
7924 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7925 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7926 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7927
353032ce
PE
7928 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7929
2bccce07
PE
7930 * alloc.c (Fmake_string): Check for out-of-range init.
7931
0ac30604
SM
79322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7933
7934 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7935
c195f2de
JD
79362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7937
7938 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7939 xg_get_default_scrollbar_width.
7940
7941 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7942 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7943 (style_changed_cb): Call update_theme_scrollbar_width and call
7944 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7945 all frames (Bug#8505).
7946 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7947 Call gtk_window_set_resizable if HAVE_GTK3.
7948 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7949 and height if HAVE_GTK3 (Bug#8505).
7950 (scroll_bar_width_for_theme): New variable.
7951 (update_theme_scrollbar_width): New function.
7952 (xg_get_default_scrollbar_width): Move code to
7953 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7954 (xg_initialize): Call update_theme_scrollbar_width.
7955
7956 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7957
7958 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7959
e10ac9f1
MR
79602011-06-12 Martin Rudalics <rudalics@gmx.at>
7961
7962 * frame.c (make_frame): Call other_buffer_safely instead of
7963 other_buffer.
7964
7965 * window.c (temp_output_buffer_show): Call display_buffer with
7966 second argument Vtemp_buffer_show_specifiers and reset latter
7967 immediately after the call.
7968 (Vtemp_buffer_show_specifiers): New variable.
7969 (auto_window_vscroll_p, next_screen_context_lines)
7970 (Vscroll_preserve_screen_position): Remove leading asterisks from
7971 doc-strings.
7972
2d3c217e 79732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7974
7b7f97e8 7975 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7976 * buffer.c (Qclone_number): Remove for now, as it's unused.
7977 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7978 (record_buffer): Remove unused local.
7979 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7980 (set_frame_buffer_list): Remove; unused.
7981 * frame.h (other_visible_frames): Remove decl.
7982 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7983 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7984 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7985 if HAVE_GPM.
7986 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7987 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7988 Define only if HAVE_GPM.
7989 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7990 (update_hints_inhibit): Remove; never set. All uses removed.
7991 * widgetprv.h (emacsFrameClassRec): Remove decl.
7992 * window.c (delete_deletable_window): Now returns void, since it
7993 wasn't returning anything.
7994 (compare_window_configurations): Remove unused locals.
7995 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7996 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7997 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7998 the same widths as pointers. This follows up on the 2011-05-06 patch.
7999 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8000 * xterm.h: Likewise.
8001 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8002
1384b89e
JB
80032011-06-12 Juanma Barranquero <lekktu@gmail.com>
8004
8005 * makefile.w32-in: Update dependencies.
8006 (LISP_H): Add lib/intprops.h.
8007
1100a63c
CY
80082011-06-11 Chong Yidong <cyd@stupidchicken.com>
8009
8010 * image.c (gif_load): Add animation frame delay to the metadata.
8011 (syms_of_image): Use DEFSYM. New symbol `delay'.
8012
6198ccd0
MR
80132011-06-11 Martin Rudalics <rudalics@gmx.at>
8014
8015 * window.c (delete_deletable_window): Re-add.
8016 (Fset_window_configuration): Rewrite to handle dead buffers and
8017 consequently deletable windows.
8018 (window_tree, Fwindow_tree): Remove. Supply functionality in
8019 window.el.
8020 (compare_window_configurations): Simplify code.
8021
b6e3633c
AS
80222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8023
1ab0dee5
AS
8024 * image.c (imagemagick_load_image): Fix type mismatch.
8025 (Fimagemagick_types): Likewise.
8026
b6e3633c
AS
8027 * window.h (replace_buffer_in_windows): Declare.
8028
9397e56f
MR
80292011-06-11 Martin Rudalics <rudalics@gmx.at>
8030
8031 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8032 Qclone_number. Remove external declaration of Qdelete_window.
8033 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8034 code.
640c8776
SM
8035 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8036 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8037 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8038 buffer list implementation.
8039 (other_buffer_safely): New function.
8040 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8041 calls to replace_buffer_in_windows and
8042 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8043 if allowed.
8044 (record_buffer): Inhibit quitting and rewrite using quittable
8045 functions. Run Qbuffer_list_update_hook if allowed.
8046 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8047 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8048 Move switch-to-buffer to window.el.
9397e56f
MR
8049 (bury-buffer): Move to window.el.
8050 (Vbuffer_list_update_hook): New variable.
8051
8052 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8053 section.
8054
8055 * window.h (resize_frame_windows): Move up in code.
8056 (Fwindow_frame): Remove EXFUN.
8057 (replace_buffer_in_all_windows): Remove prototype.
8058 (replace_buffer_in_windows_safely): Add prototype.
8059
8060 * window.c: Declare Qdelete_window static again. Move down
8061 declaration of select_count.
8062 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8063 (Fother_window): Move to window.el.
8064 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8065 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8066 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8067 window.el.
8068 (replace_buffer_in_windows): Implement by calling
8069 Qreplace_buffer_in_windows.
8070 (replace_buffer_in_all_windows): Remove with some functionality
8071 moved into replace_buffer_in_windows_safely.
8072 (replace_buffer_in_windows_safely): New function.
8073 (select_window_norecord, select_frame_norecord): Move in front
8074 of run_window_configuration_change_hook. Remove now obsolete
8075 declarations.
640c8776
SM
8076 (Fset_window_buffer): Rewrite doc-string.
8077 Call Qrecord_window_buffer.
9397e56f
MR
8078 (keys_of_window): Move binding for other-window to window.el.
8079
b50691aa
CY
80802011-06-11 Chong Yidong <cyd@stupidchicken.com>
8081
8082 * dispextern.h (struct image): Replace data member, whose int_val
8083 and ptr_val fields were not used by anything, with a single
8084 lisp_val object.
8085
8086 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8087 (gif_clear_image, gif_load, imagemagick_load_image)
8088 (gs_clear_image, gs_load): Callers changed.
8089
3f754b86
PE
80902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8091
cca69397
PE
8092 * buffer.h: Include <time.h>, for time_t.
8093 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8094
109e28d0
PE
8095 Fix minor problems found by static checking.
8096
60737f02
PE
8097 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8098
4b66faf3
PE
8099 Make identifiers static if they are not used in other modules.
8100 * data.c (Qcompiled_function, Qframe, Qvector):
8101 * image.c (QimageMagick, Qsvg):
8102 * minibuf.c (Qmetadata):
8103 * window.c (resize_window_check, resize_root_window): Now static.
8104 * window.h (resize_window_check, resize_root_window): Remove decls.
8105
109e28d0
PE
8106 * window.c (window_deletion_count, delete_deletable_window):
8107 Remove; unused.
46a4ce9e
PE
8108 (window_body_lines): Now static.
8109 (Fdelete_other_windows_internal): Mark vars as initialized.
8110 Make sure 'resize_failed' is initialized.
8111 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8112 (resize_window_apply): Remove unused local.
8113 * window.h (delete_deletable_window): Remove decl.
8114
109e28d0 8115 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8116 (imagemagick_load_image): Fix pointer signedness problem by changing
8117 last arg from unsigned char * to char *. All uses changed.
8118 Also, fix a local for similar reasons.
8119 Remove unused locals. Remove locals to avoid shadowing.
8120 (fn_rsvg_handle_free): Remove; unused.
8121 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8122 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8123
3f754b86
PE
8124 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8125
2547adb1
CY
81262011-06-10 Chong Yidong <cyd@stupidchicken.com>
8127
8128 * image.c (gif_load): Fix omitted cast error introduced by
8129 2011-06-06 change.
8130
2c8e37d4
MR
81312011-06-10 Martin Rudalics <rudalics@gmx.at>
8132
8133 * window.h (resize_proportionally, orig_total_lines)
8134 (orig_top_line): Remove from window structure.
8135 (set_window_height, set_window_width, change_window_heights)
8136 (Fdelete_window): Remove prototypes.
8137 (resize_frame_windows): Remove duplicate declaration.
8138
440a42e3
EZ
81392011-06-10 Eli Zaretskii <eliz@gnu.org>
8140
8141 * window.h (resize_frame_windows, resize_window_check)
8142 (delete_deletable_window, resize_root_window)
8143 (resize_frame_windows): Declare prototypes.
8144
8145 * window.c (resize_window_apply): Make definition be "static" to
8146 match the prototype.
8147
562dd5e9
MR
81482011-06-10 Martin Rudalics <rudalics@gmx.at>
8149
8150 * window.c: Remove declarations of Qwindow_size_fixed,
8151 window_min_size_1, window_min_size_2, window_min_size,
8152 size_window, window_fixed_size_p, enlarge_window, delete_window.
8153 Remove static from declaration of Qdelete_window, it's
8154 temporarily needed by Fbury_buffer.
8155 (replace_window): Don't assign orig_top_line and
8156 orig_total_lines.
8157 (Fdelete_window, delete_window): Remove. Window deletion is
8158 handled by window.el.
640c8776
SM
8159 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8160 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8161 (Fdelete_other_windows): Remove. Deleting other windows is
8162 handled by window.el.
8163 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8164 handled in window.el.
8165 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8166 Window minimum sizes are handled in window.el.
8167 (shrink_windows, size_window, set_window_height)
8168 (set_window_width, change_window_heights, window_height)
8169 (window_width, CURBEG, CURSIZE, enlarge_window)
8170 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8171 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8172 handled in window.el.
8173 (make_dummy_parent): Rename to make_parent_window and give it a
8174 second argument horflag.
8175 (make_window): Don't set resize_proportionally any more.
8176 (Fsplit_window): Remove. Windows are split in window.el.
8177 (save_restore_action, save_restore_orig_size)
8178 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8179 Resize mini windows in window.el.
8180 (grow_mini_window, shrink_mini_window): Implement by calling
8181 Qresize_root_window_vertically, resize_window_check and
8182 resize_window_apply.
640c8776
SM
8183 (saved_window, Fset_window_configuration, save_window_save):
8184 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8185 resize_proportionally.
8186 (window_min_height, window_min_width): Move to window.el.
8187 (keys_of_window): Move bindings for delete-other-windows,
8188 split-window, delete-window and enlarge-window to window.el.
8189
8190 * buffer.c: Temporarily extern Qdelete_window.
8191 (Fbury_buffer): Temporarily call Qdelete_window instead of
8192 Fdelete_window (Fbury_buffer will move to window.el soon).
8193
8194 * frame.c (set_menu_bar_lines_1): Remove code handling
8195 orig_top_line and orig_total_lines.
8196
8197 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8198 set_window_height but set heights directly.
8199 (change_frame_size_1): Use resize_frame_windows.
8200
8201 * xdisp.c (init_xdisp): Don't use set_window_height but set
8202 heights directly.
8203
640c8776
SM
8204 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8205 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8206 run_window_configuration_change_hook.
8207
8208 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8209 instead of change_window_heights and run
8210 run_window_configuration_change_hook.
8211
1a13852e
MR
82122011-06-09 Martin Rudalics <rudalics@gmx.at>
8213
8214 * window.c (replace_window): Rename second argument REPLACEMENT to
8215 NEW. New third argument SETFLAG. Rewrite.
8216 (delete_window, make_dummy_parent): Call replace_window with
8217 third argument 1.
8218 (window_list_1): Move down in code.
8219 (run_window_configuration_change_hook): Move set_buffer part
8220 before select_frame_norecord part in order to unwind correctly.
8221 Rename count1 to count.
8222 (recombine_windows, delete_deletable_window, resize_root_window)
8223 (Fdelete_other_windows_internal)
8224 (Frun_window_configuration_change_hook, make_parent_window)
8225 (resize_window_check, resize_window_apply, Fresize_window_apply)
8226 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8227 (Fdelete_window_internal, Fresize_mini_window_internal):
8228 New functions.
1a13852e
MR
8229 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8230
f3d1777e
MR
82312011-06-08 Martin Rudalics <rudalics@gmx.at>
8232
496e208e
MR
8233 * window.h (window): Add some new members to window structure -
8234 normal_lines, normal_cols, new_total, new_normal, clone_number,
8235 splits, nest, prev_buffers, next_buffers.
8236 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8237 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8238
f3d1777e
MR
8239 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8240 Remove.
496e208e
MR
8241 (make_dummy_parent): Set new members of windows structure.
8242 (make_window): Move down in code. Handle new members of window
8243 structure.
8244 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8245 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8246 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8247 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8248 (Fset_window_next_buffers, Fset_window_clone_number):
8249 New functions.
496e208e
MR
8250 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8251 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8252 Doc-string fixes.
8253 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8254 Argument WINDOW can be now internal window too.
8255 (Fwindow_use_time): Move up in code.
8256 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8257 Rewrite doc-string.
8258 (Fset_window_configuration, saved_window)
8259 (Fcurrent_window_configuration, save_window_save): Handle new
8260 members of window structure.
b9e809c2
MR
8261 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8262 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8263 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8264 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8265 Qget_mru_window, Qresize_root_window,
8266 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8267 Qauto_buffer_name; staticpro them.
f3d1777e 8268
abde8f8c
MR
82692011-06-07 Martin Rudalics <rudalics@gmx.at>
8270
8271 * window.c (Fwindow_total_size, Fwindow_left_column)
8272 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8273 (Fwindow_list_1): New functions.
8274 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8275 (Fwindow_width, Fscroll_left, Fscroll_right):
8276 Use window_body_cols instead of window_box_text_cols.
8277 (delete_window, Fset_window_configuration):
8278 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8279 (delete_all_subwindows): Take a window as argument and not a
8280 structure. Rewrite.
190b47e6
MR
8281 (window_loop): Remove handling of GET_LRU_WINDOW and
8282 GET_LARGEST_WINDOW.
8283 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8284
8285 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8286 window_box_text_cols. delete_all_subwindows now takes a
8287 Lisp_Object as argument.
abde8f8c 8288
640c8776
SM
8289 * indent.c (compute_motion, Fcompute_motion):
8290 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8291
fa8a67e6
MR
8292 * frame.c (delete_frame): Call delete_all_subwindows with root
8293 window as argument.
8294
a54e3482
DC
82952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8296
8297 * fns.c (Fputhash): Document return value.
8298
60002bf5
CY
82992011-06-06 Chong Yidong <cyd@stupidchicken.com>
8300
8301 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8302
0c671da6 83032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8304
b862a52a 8305 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8306
be44ca6c
PE
8307 Check for overflow when converting integer to cons and back.
8308 * charset.c (Fdefine_charset_internal, Fdecode_char):
8309 Use cons_to_unsigned to catch overflow.
8310 (Fencode_char): Use INTEGER_TO_CONS.
8311 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8312 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8313 * data.c (long_to_cons, cons_to_long): Remove.
8314 (cons_to_unsigned, cons_to_signed): New functions.
8315 These signal an error for invalid or out-of-range values.
8316 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8317 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8318 * font.c (Ffont_variation_glyphs):
8319 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8320 * lisp.h: Include <intprops.h>.
8321 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8322 (cons_to_signed, cons_to_unsigned): New decls.
8323 (long_to_cons, cons_to_long): Remove decls.
8324 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8325 (Fprimitive_undo): Use CONS_TO_INTEGER.
8326 * xfns.c (Fx_window_property): Likewise.
8327 * xselect.c: Include <limits.h>.
8328 (x_own_selection, selection_data_to_lisp_data):
8329 Use INTEGER_TO_CONS.
8330 (x_handle_selection_request, x_handle_selection_clear)
8331 (x_get_foreign_selection, Fx_disown_selection_internal)
8332 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8333 (lisp_data_to_selection_data): Use cons_to_unsigned.
8334 (x_fill_property_data): Use cons_to_signed.
8335 Report values out of range.
8336
d1f3d2af
PE
8337 Check for buffer and string overflow more precisely.
8338 * buffer.h (BUF_BYTES_MAX): New macro.
8339 * lisp.h (STRING_BYTES_MAX): New macro.
8340 * alloc.c (Fmake_string):
8341 * character.c (string_escape_byte8):
8342 * coding.c (coding_alloc_by_realloc):
8343 * doprnt.c (doprnt):
8344 * editfns.c (Fformat):
8345 * eval.c (verror):
8346 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8347 since they may not be the same number.
8348 * editfns.c (Finsert_char):
8349 * fileio.c (Finsert_file_contents):
8350 Likewise for BUF_BYTES_MAX.
8351
dd52fcea
PE
8352 * image.c: Use ptrdiff_t, not int, for sizes.
8353 (slurp_file): Switch from int to ptrdiff_t.
8354 All uses changed.
8355 (slurp_file): Check that file size fits in both size_t (for
8356 malloc) and ptrdiff_t (for sanity and safety).
8357
7f9bbdbb
PE
8358 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8359 if b->modtime has its maximal value.
8360
dfe18f82
PE
8361 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8362
84acfcf0
PE
8363 Don't assume time_t can fit into int.
8364 * buffer.h (struct buffer.modtime): Now time_t, not int.
8365 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8366 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8367
ccd9a01a
PE
8368 Minor fixes for signed vs unsigned integers.
8369 * character.h (MAYBE_UNIFY_CHAR):
8370 * charset.c (maybe_unify_char):
8371 * keyboard.c (read_char, reorder_modifiers):
8372 XINT -> XFASTINT, since the integer must be nonnegative.
8373 * ftfont.c (ftfont_spec_pattern):
8374 * keymap.c (access_keymap, silly_event_symbol_error):
8375 XUINT -> XFASTINT, since the integer must be nonnegative.
8376 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8377 since it makes no difference and we prefer signed.
8378 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8379 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8380 nonnegative.
8381
d6d100dd
SM
83822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8383
8384 * window.h (Fwindow_frame): Declare.
8385
2b6148e4
PE
83862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8387
8388 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8389 (SPARE_MEMORY): Always define.
8390 (LARGE_REQUEST): Remove.
8391 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8392
f230ecc9
MR
83932011-06-06 Martin Rudalics <rudalics@gmx.at>
8394
727e958e
MR
8395 * lisp.h: Move EXFUNS for Fframe_root_window,
8396 Fframe_first_window and Fset_frame_selected_window to window.h.
8397
8398 * window.h: Move EXFUNS for Fframe_root_window,
8399 Fframe_first_window and Fset_frame_selected_window here from
8400 lisp.h.
8401
8402 * frame.c (Fwindow_frame, Fframe_first_window)
8403 (Fframe_root_window, Fframe_selected_window)
8404 (Fset_frame_selected_window): Move to window.c.
8405 (Factive_minibuffer_window): Move to minibuf.c.
8406 (Fother_visible_frames_p): New function.
8407
8408 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8409
f230ecc9
MR
8410 * window.c (decode_window, decode_any_window): Move up in code.
8411 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8412 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8413 (Fwindow_buffer): Move up and rewrite doc-string.
8414 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8415 (Fwindow_prev): New functions.
727e958e
MR
8416 (Fwindow_frame): Move here from frame.c. Accept any window as
8417 argument.
8418 (Fframe_root_window, Fframe_first_window)
8419 (Fframe_selected_window): Move here from frame.c. Accept frame
8420 or arbitrary window as argument. Update doc-strings.
8421 (Fminibuffer_window): Move up in code.
8422 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8423 (Fset_frame_selected_window): Move here from frame.c.
8424 Marginal rewrite.
727e958e
MR
8425 (Fselected_window, select_window, Fselect_window): Move up in
8426 code. Minor doc-string fixes.
f230ecc9 8427
4d09bcf6
PE
84282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8429
8430 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8431 Do not assume that spare memory exists; that assumption is valid
8432 only if SYSTEM_MALLOC.
8433 (LARGE_REQUEST): New macro, so that the issue of large requests
8434 is separated from the issue of spare memory.
8435
810928a2
AS
84362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8437
172418ad
AS
8438 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8439 format. (Bug#8806)
8440
43f862f7
AS
8441 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8442
810928a2
AS
8443 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8444 before statements.
8445
a059fe24
JD
84462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8447
8448 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8449
8450 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8451
8452 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8453 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8454
989bf368
JB
84552011-06-05 Juanma Barranquero <lekktu@gmail.com>
8456
8457 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8458
4b80f674
CY
84592011-06-04 Chong Yidong <cyd@stupidchicken.com>
8460
8461 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8462 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8463 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8464 New error handlers.
4b80f674
CY
8465 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8466 Obey Vx_select_enable_clipboard_manager. Catch errors in
8467 x_clipboard_manager_save (Bug#8779).
8468 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8469 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8470
99a33b77 84712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8472
8473 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8474
99a33b77 84752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8476
8477 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8478 in the current matrix if keep_current_p is non-zero.
8479
8264569d
EZ
84802011-06-04 Eli Zaretskii <eliz@gnu.org>
8481
8482 * bidi.c (bidi_level_of_next_char): Fix last change.
8483
57f97249
EZ
84842011-06-03 Eli Zaretskii <eliz@gnu.org>
8485
fec2107c 8486 Support bidi reordering of text covered by display properties.
57f97249 8487
fec2107c
EZ
8488 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8489 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8490 (bidi_cache_search, bidi_cache_iterator_state)
8491 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8492 (bidi_level_of_next_char, bidi_move_to_visually_next):
8493 Support character positions inside a run of characters covered by a
fec2107c
EZ
8494 display string.
8495 (bidi_paragraph_init, bidi_resolve_explicit_1)
8496 (bidi_level_of_next_char): Call bidi_fetch_char and
8497 bidi_fetch_char_advance instead of FETCH_CHAR and
8498 FETCH_CHAR_ADVANCE.
8499 (bidi_init_it): Initialize new members.
8500 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8501 definitions.
8502 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8503 instead of using explicit *_CHAR codes.
d6d100dd
SM
8504 (bidi_resolve_explicit, bidi_resolve_weak):
8505 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8506 bidirectional text is supported only in multibyte buffers.
8507 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8508 it to initialize the frame_window_p member of struct bidi_it.
8509 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8510 (bidi_resolve_explicit, bidi_resolve_weak)
8511 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8512 bidi_it->nchars is non-positive.
8513 (bidi_level_of_next_char): Don't try to lookup the cache for the
8514 next/previous character if nothing is cached there yet, or if we
8515 were just reseat()'ed to a new position.
c40e2fb2 8516
0e14fe90
EZ
8517 * xdisp.c (set_cursor_from_row): Set start and stop points
8518 according to the row's direction when priming the loop that looks
8519 for the glyph on which to display cursor.
8520 (single_display_spec_intangible_p): Function deleted.
8521 (display_prop_intangible_p): Reimplement to call
8522 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8523 Accept 3 additional arguments needed by handle_display_spec.
8524 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8525 values: lists, `(when COND...)' forms, etc.
8526 (single_display_spec_string_p): Support property values that are
8527 lists with the argument STRING its top-level element.
8528 (display_prop_string_p): Fix the condition for processing a
8529 property that is a list to be consistent with handle_display_spec.
fec2107c 8530 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8531 last portion of handle_display_prop.
8532 (compute_display_string_pos): Accept additional argument
8533 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8534 value of a `display' property is a "replacing spec".
8535 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8536 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8537 the display property, but just return a value indicating whether
8538 the display property will replace the characters it covers.
8539 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8540 frame_window_p members of struct bidi_it.
d6d100dd
SM
8541 (compute_display_string_pos, compute_display_string_end):
8542 New functions.
fec2107c
EZ
8543 (push_it): Accept second argument POSITION, where pop_it should
8544 jump to continue iteration.
8545 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8546
fec2107c
EZ
8547 * keyboard.c (adjust_point_for_property): Adjust the call to
8548 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8549
8550 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8551 (bidi_init_it): Update prototypes.
8552 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8553 (compute_display_string_pos, compute_display_string_end):
8554 Declare prototypes.
fec2107c
EZ
8555 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8556 EMACS_INT.
fc6f18ce 8557
40087514 85582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8559
57f53182
PE
8560 Malloc failure behavior now depends on size of allocation.
8561 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8562 * lisp.h: Change signatures accordingly.
8563 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8564 All callers changed. (Bug#8762)
8565
8566 * gnutls.c: Use Emacs's memory allocators.
8567 Without this change, the gnutls library would invoke malloc etc.
8568 directly, which causes problems on non-SYNC_INPUT hosts, and which
8569 runs afoul of improving memory_full behavior. (Bug#8761)
8570 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8571 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8572 xfree instead of the default malloc, realloc, free.
8573 (Fgnutls_boot): No need to check for memory allocation failure,
8574 since xmalloc does that for us.
8575
ac32cd99 8576 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8577 * category.c (hash_get_category_set):
8578 * ccl.c (ccl_driver):
8579 * charset.c (Fdefine_charset_internal):
8580 * charset.h (struct charset.hash_index):
8581 * composite.c (get_composition_id, gstring_lookup_cache)
8582 (composition_gstring_put_cache):
8583 * composite.h (struct composition.hash_index):
8584 * dispextern.h (struct image.hash):
8585 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8586 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8587 (hashfn_equal, hashfn_user_defined, make_hash_table)
8588 (maybe_resize_hash_table, hash_lookup, hash_put)
8589 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8590 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8591 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8592 * image.c (make_image, search_image_cache, lookup_image)
8593 (xpm_put_color_table_h):
8594 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8595 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8596 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8597 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8598 * alloc.c (allocate_vectorlike):
8599 Check for overflow in vector size calculations.
8600 * ccl.c (ccl_driver):
8601 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8602 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8603 need to be updated by these changes.
40087514
PE
8604 * fns.c (make_hash_table, maybe_resize_hash_table):
8605 Check for integer overflow with large hash tables.
0de4bb68
PE
8606 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8607 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8608 (SXHASH_REDUCE): New macro.
8609 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8610 Use it instead of discarding useful hash info with large hash values.
8611 (sxhash_float): New function.
8612 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8613 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8614 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8615 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8616 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8617 Adjust signatures to match updated version of code.
8618 (consing_since_gc): Now EMACS_INT, since a single hash table can
8619 use more than INT_MAX bytes.
8620
698d32e2
DN
86212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8622
8623 Make it possible to build with GCC-4.6+ -O2 -flto.
8624
8625 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8626
fd6fa53f
SM
86272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8628
8629 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8630 Call minibuffer-inactive-mode.
8631
864db017
JB
86322011-05-31 Juanma Barranquero <lekktu@gmail.com>
8633
8634 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8635 Update dependencies.
8636
2ad0baf4
DN
86372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8638
8639 * data.c (init_data): Remove code for UTS, this system is not
8640 supported anymore.
8641
4fcc2638
DN
86422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8643
8644 Don't force ./temacs to start in terminal mode.
8645
8646 * frame.c (make_initial_frame): Initialize faces in all cases, not
8647 only when CANNOT_DUMP is defined.
8648 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8649
c56e0fd5
DN
86502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8651
8652 * dispnew.c (add_window_display_history): Use const for the string
8653 pointer. Remove declaration, not needed.
8654
333d54da 86552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8656
55d4c1b2 8657 Use 'inline', not 'INLINE'.
333d54da 8658 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8659 * alloc.c, fontset.c (INLINE): Remove.
8660 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8661 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8662 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8663 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8664 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8665
738db178
DN
86662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8667
8668 Make it possible to run ./temacs.
8669
8670 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8671 syms_of_callproc does the same thing. Remove test for
8672 "initialized", do it in the caller.
8673 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8674
620c53a6
SM
86752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8676
8677 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8678 (read_minibuf): Use get_minibuffer.
8679 (syms_of_minibuf): Use DEFSYM.
8680 (Qmetadata): New var.
8681 * data.c (Qbuffer): Don't make it static.
8682 (syms_of_data): Use DEFSYM.
8683
e003a292
PE
86842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8685
8686 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8687 (CCL_CODE_MIN): New macro.
8688
ed008a6d
PE
86892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8690
3687c2ef
PE
8691 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8692
ed008a6d
PE
8693 * eval.c (Qdebug): Now static.
8694 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8695 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8696 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8697
d66c4c7c
CY
86982011-05-29 Chong Yidong <cyd@stupidchicken.com>
8699
8700 * image.c: Various fixes to ImageMagick code comments.
8701 (Fimagemagick_types): Doc fix.
8702
5fbc2025
PE
87032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8704
0196f88a
PE
8705 Minor fixes prompted by GCC 4.6.0 warnings.
8706
8707 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8708
5fbc2025
PE
8709 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8710 (x_clipboard_manager_save_all): Move extern decl to ...
8711 * xterm.h: ... here, so that it can be checked for consistency.
8712
1dd3c2d9
CY
87132011-05-29 Chong Yidong <cyd@stupidchicken.com>
8714
8715 * xselect.c (x_clipboard_manager_save_frame)
8716 (x_clipboard_manager_save_all): New functions.
8717 (Fx_clipboard_manager_save): Lisp function deleted.
8718
8719 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8720 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8721
8722 * xterm.h: Update prototype.
8723
5ba6571d
WX
87242011-05-28 William Xu <william.xwl@gmail.com>
8725
8726 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8727 exiting (Bug#8239).
8728
3eaff834
JM
87292011-05-28 Jim Meyering <meyering@redhat.com>
8730
e1900994 8731 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8732 * fns.c (to_uchar): Define.
8733 (crypto_hash_function): Use it to convert some newly-signed
8734 variables to unsigned, to avoid sign-extension bugs. For example,
8735 without this change, (md5 "truc") would evaluate to
8736 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8737 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8738 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8739
0f6990a7
PE
87402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8741
8742 Integer overflow fixes.
c8a9ca5a 8743
08686060
PE
8744 * dbusbind.c: Serial number integer overflow fixes.
8745 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8746 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8747 to hold a serial number that is too large for a fixnum.
8748 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8749 Check for serial numbers out of range. Decode any serial number
59568bf0 8750 that was so large that it became a float. (Bug#8722)
08686060 8751
2d1fc3c7
PE
8752 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8753 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8754 Use XFASTINT rather than XUINT when numbers are nonnegative.
8755 (xd_append_arg, Fdbus_method_return_internal):
8756 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8757 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8758 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8759 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8760 (Bug#8722)
2d1fc3c7 8761
c8a9ca5a
PE
8762 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8763
519e1d69
PE
8764 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8765
6df6ae42 8766 ccl: Add integer overflow checks.
30569699
PE
8767 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8768 (IN_INT_RANGE): New macros.
8769 (ccl_driver): Use them to check for integer overflow when
8770 decoding a CCL program. Many of the new checks are whether XINT (x)
8771 fits in int; it doesn't always, on 64-bit hosts. The new version
8772 doesn't catch all possible integer overflows, but it's an
847044ea 8773 improvement. (Bug#8719)
30569699 8774
c11285dc
PE
8775 * alloc.c (make_event_array): Use XINT, not XUINT.
8776 There's no need for unsigned here.
8777
fdccd48e
PE
8778 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8779 This follows up to the 2011-05-06 change that substituted uintptr_t
8780 for EMACS_INT. This case wasn't caught back then.
8781
37910ab2
PE
8782 Rework Fformat to avoid integer overflow issues.
8783 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8784 now (part of C89). Include <verify.h>.
8785 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8786 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8787 (Fformat): Avoid the prepass trying to compute sizes; it was only
8788 approximate and thus did not catch overflow reliably. Instead, walk
8789 through the format just once, formatting and computing sizes as we go,
8790 checking for integer overflow at every step, and allocating a larger
8791 buffer as needed. Keep track separately whether the format is
8792 multibyte. Keep only the most-recently calculated precision, rather
8793 than them all. Record whether each argument has been converted to
8794 string. Use EMACS_INT, not int, for byte and char and arg counts.
8795 Support field widths and precisions larger than INT_MAX. Avoid
8796 sprintf's undefined behavior with conversion specifications such as %#d
8797 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8798 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8799 formatting out-of-range floating point numbers with int
9173deec 8800 formats. (Bug#8668)
37910ab2 8801
2e6578fb
PE
8802 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8803
0ae6bdee
PE
8804 * data.c: Avoid integer truncation in expressions involving floats.
8805 * data.c: Include <intprops.h>.
8806 (arith_driver): When there's an integer overflow in an expression
8807 involving floating point, convert the integers to floating point
8808 so that the resulting value does not suffer from catastrophic
8809 integer truncation. For example, on a 64-bit host (* 4
8810 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8811 Do not rely on undefined behavior after integer overflow.
8812
de883a70
PE
8813 merge count_size_as_multibyte, parse_str_to_multibyte
8814 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8815 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8816 Check for integer overflow.
8817 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8818 since it's now a duplicate of the other. This is more of
8819 a character than a buffer op, so better that it's in character.c.
8820 * fns.c, print.c: Adjust to above changes.
8821
2ff916cb
PE
88222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8823
8824 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8825
f1b54466
PE
88262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8827
fb1ac845
PE
8828 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8829 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8830 (x_clipboard_manager_save): Now static.
8831 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8832
f1b54466
PE
8833 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8834 (crypto_hash_function): Now static.
8835 Fix pointer signedness problems. Avoid unnecessary initializations.
8836
a9f737ee
CY
88372011-05-27 Chong Yidong <cyd@stupidchicken.com>
8838
8839 * termhooks.h (Vselection_alist): Make it terminal-local.
8840
8841 * terminal.c (create_terminal): Initialize it.
8842
8843 * xselect.c: Support for clipboard managers.
8844 (Vselection_alist): Move to termhooks.h as terminal-local var.
8845 (LOCAL_SELECTION): New macro.
8846 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8847 (symbol_to_x_atom): Remove gratuitous arg.
8848 (x_handle_selection_request, lisp_data_to_selection_data)
8849 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8850 (x_own_selection, x_get_local_selection, x_convert_selection):
8851 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8852 (some_frame_on_display): Delete unused function.
8853 (Fx_own_selection_internal, Fx_get_selection_internal)
8854 (Fx_disown_selection_internal, Fx_selection_owner_p)
8855 (Fx_selection_exists_p): New optional frame arg.
8856 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8857 (x_handle_selection_clear): Don't treat other terminals with the
8858 same keyboard specially. Use the terminal-local Vselection_alist.
8859 (x_clear_frame_selections): Use Frun_hook_with_args.
8860
8861 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8862
8863 * xterm.h: Add support for those atoms.
8864
e067f0c1
CY
88652011-05-26 Chong Yidong <cyd@stupidchicken.com>
8866
8867 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8868 (converted_selections, conversion_fail_tag): New global variables.
8869 (x_selection_request_lisp_error): Free the above.
8870 (x_get_local_selection): Remove unnecessary code.
8871 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8872 of converted selections stored in converted_selections.
8873 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8874 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8875 (x_convert_selection): New function.
8876 (x_handle_selection_event): Simplify.
8877 (x_get_foreign_selection): Don't ignore incoming requests while
8878 waiting for an answer; this will fail when we implement
8879 SAVE_TARGETS, and seems unnecessary anyway.
8880 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8881 (Vx_sent_selection_functions): Doc fix.
8882
0f4aebc0
LL
88832011-05-26 Leo Liu <sdl.web@gmail.com>
8884
8885 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8886
e61124cd
YM
88872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8888
8889 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8890
8891 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8892 for fringe update if it has periodic bitmap.
ac389d0c 8893 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8894 and fringe_bitmap_periodic_p.
8895
8896 * fringe.c (get_fringe_bitmap_data): New function.
8897 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8898 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8899 row. Mark glyph row for fringe update if periodicity changed.
8900
8901 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8902 for fringe update unless it has periodic bitmap.
8903
f16d9837
KH
89042011-05-25 Kenichi Handa <handa@m17n.org>
8905
8906 * xdisp.c (get_next_display_element): Set correct it->face_id for
8907 a static composition.
8908
e1b90ef6
LL
89092011-05-24 Leo Liu <sdl.web@gmail.com>
8910
8911 * deps.mk (fns.o):
8912 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8913
8914 * fns.c (crypto_hash_function, Fsha1): New function.
8915 (Fmd5): Use crypto_hash_function.
8916 (syms_of_fns): Add Ssha1.
8917
7400048f
PE
89182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8919
8920 * gnutls.c: Remove unused macros.
8921 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8922 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8923 Remove macros that are defined and never used.
8924 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8925
abb71cf4
CY
89262011-05-22 Chong Yidong <cyd@stupidchicken.com>
8927
8928 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8929 (Fx_get_selection_internal): Minor cleanup.
8930 (Fx_own_selection_internal): Rename arguments for consistency with
8931 select.el.
8932
6307db39
PE
89332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8934
8935 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8936
f3d4e0a4
CY
89372011-05-22 Chong Yidong <cyd@stupidchicken.com>
8938
8939 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8940
4d8ade89
YM
89412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8942
8943 * dispnew.c (scrolling_window): Don't exclude the case that the
8944 last enabled row in the desired matrix touches the bottom boundary.
8945
32078c8d
GM
89462011-05-21 Glenn Morris <rgm@gnu.org>
8947
8948 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8949 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8950 and add some more files.
32078c8d 8951
7285dc67
EZ
89522011-05-20 Eli Zaretskii <eliz@gnu.org>
8953
8954 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8955 report_file_error introduced by the change from 2011-05-07.
8956
89d1bd22
PE
89572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8958
8959 * systime.h (Time): Define only if emacs is defined.
8960 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8961 where the include path doesn't have X11/X.h by default. See
8962 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8963
cd394be1 89642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8965
8966 * composite.c (find_automatic_composition): Fix previous change.
8967
b9704ad9
GM
89682011-05-20 Glenn Morris <rgm@gnu.org>
8969
8970 * lisp.mk: New file, split from Makefile.in.
8971 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8972 (shortlisp): Remove.
8973 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8974
4a720484
GM
89752011-05-19 Glenn Morris <rgm@gnu.org>
8976
8977 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8978 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8979 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8980 (lisp): Set the order to that of loadup.el.
8981 (shortlisp): Make it a copy of $lisp.
8982 (SOME_MACHINE_LISP): Remove.
8983 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8984 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8985
a28d4396
KH
89862011-05-18 Kenichi Handa <handa@m17n.org>
8987
8988 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8989 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8990 (find_automatic_composition): Mostly rewrite for efficiency.
8991
a2b1fa8e
JB
89922011-05-18 Juanma Barranquero <lekktu@gmail.com>
8993
8994 * makefile.w32-in: Update dependencies.
8995
8e1f5610
CS
89962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8997
8998 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8999 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9000
7025ee00 90012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9002
cdfa6eab
PE
9003 Fix some integer overflow issues, such as string length overflow.
9004
06d6db33
PE
9005 * insdel.c (count_size_as_multibyte): Check for string overflow.
9006
2b4560a8
PE
9007 * character.c (lisp_string_width): Check for string overflow.
9008 Use EMACS_INT, not int, for string indexes and lengths; in
9009 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9010 the resulting string length overflows an EMACS_INT; instead,
9011 report a string overflow if no precision given. When checking for
9012 precision exhaustion, use a check that cannot possibly have
9013 integer overflow. (Bug#8675)
9014 * character.h (lisp_string_width): Adjust to new signature.
9015
cb93f9be
PE
9016 * alloc.c (string_overflow): New function.
9017 (Fmake_string): Use it. This doesn't change behavior, but saves
9018 a few bytes and will simplify future changes.
9019 * character.c (string_escape_byte8): Likewise.
9020 * lisp.h (string_overflow): New decl.
9021
1a1f3366
PE
9022 Fixups, following up to the user-interface timestamp change.
9023 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9024 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9025 * msdos.c (mouse_get_pos): Likewise.
9026 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9027 * w32gui.h (Time): Define by including "systime.h" rather than by
9028 declaring it ourselves. (Bug#8664)
9029
d4e3e4d3
PE
9030 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9031 * image.c (clear_image_cache): Likewise.
9032
f6a24d19
PE
9033 * term.c (term_mouse_position): Don't assume time_t wraparound.
9034
08dc5ae6
PE
9035 Be more systematic about user-interface timestamps.
9036 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9037 and sometimes 'EMACS_UINT', to represent these timestamps.
9038 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9039 This makes the code easier to follow, and makes it easier to catch
9040 integer overflow bugs such as Bug#8664.
9041 * frame.c (Fmouse_position, Fmouse_pixel_position):
9042 Use Time, not unsigned long, for user-interface timestamps.
9043 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9044 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9045 * keyboard.h (last_event_timestamp): Likewise.
9046 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9047 * menu.h (xmenu_show): Likewise.
9048 * term.c (term_mouse_position): Likewise.
9049 * termhooks.h (struct input_event.timestamp): Likewise.
9050 (struct terminal.mouse_position_hook): Likewise.
9051 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9052 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9053 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9054 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9055 what it was before.
9056 * menu.h, termhooks.h: Include "systime.h", for Time.
9057
8e55734a
PE
9058 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9059 Don't assume that the difference between two unsigned long values
9060 can fit into an integer. At this point, we know button_down_time
9061 <= event->timestamp, so the difference must be nonnegative, so
9062 there's no need to cast the result if double-click-time is
9063 nonnegative, as it should be; check that it's nonnegative, just in
9064 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9065 apart (about 25 days). (Bug#8664)
8e55734a 9066
841f1b75 9067 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9068 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9069
3e26f69c
PE
9070 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9071 that always fit in int. Use a sentinel instead of a counter, to
9072 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9073 * frame.h (struct frame): Use int for menu_bar_items_used
9074 instead of EMACS_INT, since it always fits in int.
3e26f69c 9075
5cc152c0
PE
9076 * menu.c (grow_menu_items): Check for int overflow.
9077
d89eb65e
PE
9078 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9079
5235bd3e
PE
9080 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9081 Before, the code was not consistent. These values cannot exceed
9082 2**31 - 1 so there's no need to make them unsigned.
9083 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9084 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9085 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9086 as modifiers.
9087 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9088
bc827e23
PE
9089 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9090 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9091 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9092 presumably because the widths might not match.
9093
78eb494e
PE
9094 * window.c (size_window): Avoid needless test at loop start.
9095
04f2d78b
CB
90962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9097
9098 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9099
d2fc7e3d 91002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9101
9102 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9103
d2fc7e3d 91042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9105
9106 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9107 `width' to `bar_area_x' and `bar_area_width', respectively.
9108 (x_scroll_run): Take account of fringe background extension.
9109
04f2d78b
CB
9110 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9111 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9112 `bar_area_width', respectively.
9113 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9114 background extension.
9115
79b70037
GM
91162011-05-10 Jim Meyering <meyering@redhat.com>
9117
9118 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9119
2f142cc5
JB
91202011-05-10 Juanma Barranquero <lekktu@gmail.com>
9121
9122 * image.c (Finit_image_library): Return t for built-in image types,
9123 like pbm and xbm. (Bug#8640)
9124
57679c86
AS
91252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9126
9127 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9128
888c9e86
EZ
91292011-05-07 Eli Zaretskii <eliz@gnu.org>
9130
b0512a1d
EZ
9131 * w32console.c (Fset_screen_color): Doc fix.
9132 (Fget_screen_color): New function.
9133 (syms_of_ntterm): Defsubr it.
9134
7285dc67
EZ
9135 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9136 unlink the temporary file if Fcall_process didn't create it in the
9137 first place.
9138 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9139 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9140 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9141 cue to call_process_cleanup not to close that handle.
9142
4d3fcc8e
BK
91432011-05-07 Ben Key <bkey76@gmail.com>
9144
9145 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9146 one of two shell specific rules, either bootstrap-temacs-CMD or
9147 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9148 to the previous implementation of the bootstrap-temacs rule.
9149 The bootstrap-temacs-CMD rule is similar to the previous
9150 implementation of the bootstrap-temacs rule except that it
9151 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9152 variable.
9153
9154 These changes, along with some changes to nt/configure.bat,
9155 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9156 earlier fix to add support for --cflags and --ldflags options
9157 that include quotes so that it works whether make uses cmd or
9158 sh as the shell.
9159
b4289b64
MA
91602011-05-06 Michael Albinus <michael.albinus@gmx.de>
9161
9162 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9163 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9164 is a constant.
9165 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9166 a string. Handle both cases.
9167 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9168 (Fdbus_register_method): Use Qinvalid_function.
9169
af4c0e28
JB
91702011-05-06 Juanma Barranquero <lekktu@gmail.com>
9171
9172 * makefile.w32-in: Update dependencies.
9173 (LISP_H): Add inttypes.h and stdin.h.
9174 (PROCESS_H): Add unistd.h.
9175
c51453d9
EZ
91762011-05-06 Eli Zaretskii <eliz@gnu.org>
9177
9178 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9179 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9180
8ff0ac3c 91812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9182
4c4b566b
PE
9183 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9184
aab2b9b5
PE
9185 * term.c (vfatal): Remove stray call to va_end.
9186 It's not needed and the C Standard doesn't allow it here anyway.
9187
c378da0b
PE
9188 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9189 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9190
288b08c7
PE
9191 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9192 bytes.
9193
e3601888
PE
9194 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9195
db6c0e74
PE
9196 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9197
dd5963ea
PE
9198 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9199
88c9450f
PE
9200 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9201
2f9442b8
PE
9202 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9203
c032b5f8
PE
9204 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9205 * charset.c (Fdefine_charset_internal): Don't initialize
9206 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9207 32-bit int (Bug#8600).
a108c10b
PE
9208
9209 * lread.c (read_integer): Be more consistent with string-to-number.
9210 Use string_to_number to do the actual conversion; this avoids
9211 rounding errors and fixes some other screwups. Without this fix,
9212 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9213 (digit_to_number): Move earlier, for benefit of read_integer.
9214 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9215 not a digit in any supported base. (Bug#8602)
a108c10b 9216
ad5f9eea
PE
9217 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9218
aec1708a
PE
9219 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9220 to match comment at start of function. This also removes a
9221 GCC warning about overflow in a 32+64-bit port.
9222
47be4ab5
PE
9223 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9224
371cac43
PE
9225 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9226 Reported by Stefan Monnier in
9227 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9228 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9229 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9230
d01a7826
PE
9231 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9232 (EMACS_UINTPTR): Likewise, with uintptr_t.
9233
7fd47d5c
PE
9234 * lisp.h: Prefer 64-bit EMACS_INT if available.
9235 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9236 on 32-bit hosts that have 64-bit int, so that they can access
9237 large files.
122b0c86
PE
9238 However, temporarily disable this change unless the temporary
9239 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9240
8727937b
PE
9241 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9242
8ac068ac
PE
9243 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9244 This removes an assumption that EMACS_INT and long are the same
9245 width as pointers. The assumption is true for Emacs porting targets
9246 now, but we want to make other targets possible.
9247 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9248 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9249 In the rest of the code, change types of integers that hold casted
9250 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9251 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9252 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9253 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9254 No need to cast type when ORing.
9255 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9256 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9257 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9258 assume EMACS_INT is the same width as char *.
9259 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9260 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9261 Remove no-longer-needed casts.
9262 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9263 (xg_tool_bar_help_callback, xg_make_tool_item):
9264 Use EMACS_INTPTR to hold an integer
9265 that will be cast to void *; this can avoid a GCC warning
9266 if EMACS_INT is not the same width as void *.
9267 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9268 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9269 (current_message_1, set_message_1):
9270 Use a local to convert to proper width without a cast.
9271 * xmenu.c (dialog_selection_callback): Likewise.
9272
ede49d71
PE
9273 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9274 Also, don't assume VALBITS / RAND_BITS is less than 5,
9275 and don't rely on undefined behavior when shifting a 1 left into
9276 the sign bit.
9277 * lisp.h (get_random): Change signature to match.
9278
2f30ecd0
PE
9279 * lread.c (hash_string): Use size_t, not int, for hash computation.
9280 Normally we prefer signed values; but hashing is special, because
9281 it's better to use unsigned division on hash table sizes so that
9282 the remainder is nonnegative. Also, size_t is the natural width
9283 for hashing into memory. The previous code used 'int', which doesn't
9284 retain enough info to hash well into very large tables.
9285 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9286
2a866e7b
PE
9287 * dbusbind.c: Don't possibly lose pointer info when converting.
9288 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9289 Use XPNTR rather than XHASH, so that the high-order bits of
9290 the pointer aren't lost when converting through void *.
9291
51639eac
PE
9292 * eval.c (Fautoload): Don't double-shift a pointer.
9293
92394119
PE
9294 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9295
dbdb9a7c
JB
92962011-05-06 Juanma Barranquero <lekktu@gmail.com>
9297
9298 * gnutls.c (DEF_GNUTLS_FN):
9299 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9300
db7a0b4f
AS
93012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9302
9303 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9304 marker. (Bug#8610)
9305
cd394be1 93062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9307
9308 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9309 New version that can reserve upto 2GB of heap space.
9310
f7ff1b0f 93112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9312
9313 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9314
639c109b
TZ
93152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9316
9317 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9318 `gnutls_certificate_set_x509_key_file'.
9319
d2127135
JB
93202011-05-05 Juanma Barranquero <lekktu@gmail.com>
9321
9322 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9323 Update dependencies.
9324
e968f4f3
JB
93252011-05-04 Juanma Barranquero <lekktu@gmail.com>
9326
9327 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9328 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9329 Remove unused parameter `fildes'.
9330 * process.c (read_process_output, send_process): Don't pass it.
9331
84d358f0
JB
93322011-05-04 Juanma Barranquero <lekktu@gmail.com>
9333
9334 Fix previous change: the library cache is defined in w32.c.
9335 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9336 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9337
0898ca10
JB
93382011-05-04 Juanma Barranquero <lekktu@gmail.com>
9339
9340 Implement dynamic loading of GnuTLS on Windows.
9341
9342 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9343 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9344 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9345 Declare.
9346
9347 * gnutls.c (Qgnutls_dll): Define.
9348 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9349 (gnutls_*): Declare function pointers.
9350 (init_gnutls_functions): New function to initialize function pointers.
9351 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9352 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9353 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9354 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9355 (emacs_gnutls_write, emacs_gnutls_read)
9356 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9357 (Fgnutls_available_p): New function.
9358 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9359 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9360 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9361
9362 * image.c: Include w32.h.
9363 (Vimage_type_cache): Delete.
9364 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9365 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9366 (w32_delayed_load): Move to w32.c.
9367
9368 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9369
9370 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9371 (w32_delayed_load): Move from image.c. When loading a library, record
9372 its filename in the :loaded-from property of the library id.
9373 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9374 Initialize and staticpro them.
9375 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9376
9377 * process.c: Include lisp.h before w32.h, not after.
9378 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9379 instead of gnutls_record_check_pending.
9380
9381 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9382
ff4de4aa
TZ
93832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9384
9385 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9386 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9387 as passed in.
9388
abe95abb
JD
93892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9390
9391 * xterm.c (x_set_frame_alpha): Do not set property on anything
9392 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9393
e16e55d4
JB
93942011-05-02 Juanma Barranquero <lekktu@gmail.com>
9395
9396 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9397
bafcf6a5
JB
93982011-05-02 Juanma Barranquero <lekktu@gmail.com>
9399
9400 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9401 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9402 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9403 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9404 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9405 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9406 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9407 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9408 (Qgnutls_bootprop_callbacks_verify): Make static.
9409
e7a6747f
AS
94102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9411
19ed11ba
AS
9412 * callproc.c: Indentation fixup.
9413
e7a6747f 9414 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9415 (wait_for_termination, interruptible_wait_for_termination):
9416 Move after wait_for_termination_1.
e7a6747f 9417
1ef14cb4
LMI
94182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9419
9420 * sysdep.c (interruptible_wait_for_termination): New function
9421 which is like wait_for_termination, but allows keyboard
9422 interruptions.
9423
9424 * callproc.c (Fcall_process): Add (:file "file") as an option for
9425 the STDOUT buffer.
9426 (Fcall_process_region): Ditto.
9427
330d880c
EZ
94282011-04-30 Eli Zaretskii <eliz@gnu.org>
9429
8db90b73
EZ
9430 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9431 rather than `XVECTOR (FOO)->size'.
9432
330d880c
EZ
9433 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9434 inttypes.h, as a gnulib replacement is used if it not available in
9435 system headers.
9436
15cbd324
EZ
94372011-04-21 Eli Zaretskii <eliz@gnu.org>
9438
9439 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9440 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9441 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9442
9443 * coding.c (coding_alloc_by_realloc): Error out if destination
9444 will grow beyond MOST_POSITIVE_FIXNUM.
9445 (decode_coding_emacs_mule): Abort if there isn't enough place in
9446 charbuf for the composition carryover bytes. Reserve an extra
9447 space for up to 2 characters produced in a loop.
9448 (decode_coding_iso_2022): Abort if there isn't enough place in
9449 charbuf for the composition carryover bytes.
9450
94512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9452
ae940cca
EZ
9453 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9454 aborting when %lld or %lll format is passed.
9455 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9456 %llo or %llx format is passed. (Bug#8545)
9457
03ab8921
EZ
9458 * window.c (window_scroll_line_based): Use a marker instead of
9459 simple variables to record original value of point. (Bug#7952)
9460
afda1437
EZ
9461 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9462 produced by %s or %c overflows available buffer space. (Bug#8545)
9463
f76dee0c
PE
94642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9465
9466 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9467 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9468
fdc5744d
JB
94692011-04-28 Juanma Barranquero <lekktu@gmail.com>
9470
9471 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9472
638f053a
JB
94732011-04-28 Juanma Barranquero <lekktu@gmail.com>
9474
9475 * keyboard.c (Qdelayed_warnings_hook): Define.
9476 (command_loop_1): Run `delayed-warnings-hook'
9477 if Vdelayed_warnings_list is non-nil.
9478 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9479 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9480
d178f871
EZ
94812011-04-28 Eli Zaretskii <eliz@gnu.org>
9482
9483 * doprnt.c (doprnt): Don't return value smaller than the buffer
9484 size if the message was truncated. (Bug#8545).
9485
b124fd93
JB
94862011-04-28 Juanma Barranquero <lekktu@gmail.com>
9487
9488 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9489 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9490
e810457d
PE
94912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9492
9493 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9494
ea51cceb
JB
94952011-04-27 Juanma Barranquero <lekktu@gmail.com>
9496
9497 * makefile.w32-in: Update dependencies.
9498
94dcfacf
EZ
94992011-04-27 Eli Zaretskii <eliz@gnu.org>
9500
9501 Improve `doprnt' and its usage. (Bug#8545)
9502 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9503 `format_end'. Remove support for %l as a conversion specifier.
9504 Don't use xrealloc. Improve diagnostics when the %l size modifier
9505 is used. Update the commentary.
9506
9507 * eval.c (verror): Simplify calculation of size_t.
9508
9509 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9510 messages.
9511
f61f41d7
PE
95122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9513
9514 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9515 change.
9516
96fb4434
PE
95172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9518
9519 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9520 This makes this file independent of the recent pseudovector change.
9521
671875da 95222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9523
69e9b5a3
PE
9524 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9525
b5f869a7 9526 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9527 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9528 Remove unused local.
c8926152 9529 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9530
841a1577 9531 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9532 GCC 4.6.0 optimizes based on type-based alias analysis.
9533 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9534 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9535 != &v->size, and therefore "v->size = 1; b->size = 2; return
9536 v->size;" must therefore return 1. This assumption is incorrect
9537 for Emacs, since it type-puns struct Lisp_Vector * with many other
9538 types. To fix this problem, this patch adds a new type struct
f904488f 9539 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9540 and pseudovectors, and helps optimizing compilers not get fooled
9541 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9542 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9543 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9544 the size member.
eab3844f
PE
9545 (XSETPVECTYPE): Rewrite in terms of new macro.
9546 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9547 This is a bit clearer, and further avoids the possibility of
9548 undesirable aliasing.
9549 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9550 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9551 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9552 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9553 (ASIZE): Now uses header.size rather than size.
9554 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9555 to avoid the hassle of writing XVECTOR (foo)->header.size.
9556 (struct vectorlike_header): New type.
eab3844f
PE
9557 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9558 object, to help avoid aliasing.
9559 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9560 (SUBRP): Likewise, since Lisp_Subr is a special case.
9561 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9562 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9563 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9564 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9565 changed to be "header.size" and "header.next".
9566 * buffer.h (struct buffer): Likewise.
9567 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9568 * frame.h (struct frame): Likewise.
9569 * process.h (struct Lisp_Process): Likewise.
9570 * termhooks.h (struct terminal): Likewise.
9571 * window.c (struct save_window_data, struct saved_window): Likewise.
9572 * window.h (struct window): Likewise.
9573 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9574 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9575 * buffer.c (init_buffer_once): Likewise.
9576 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9577 special case.
9578 * process.c (Fformat_network_address): Use local var for size,
9579 for brevity.
9580
0df1eac5
PE
9581 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9582
847ab9d1 9583 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9584 * data.c (atof): Remove decl; no longer used or needed.
9585 (digit_to_number): Move to lread.c.
9586 (Fstring_to_number): Use new string_to_number function, to be
9587 consistent with how the Lisp reader treats infinities and NaNs.
9588 Do not assume that floating-point numbers represent EMACS_INT
9589 without losing information; this is not true on most 64-bit hosts.
9590 Avoid double-rounding errors, by insisting on integers when
9591 parsing non-base-10 numbers, as the documentation specifies.
9592 * lisp.h (string_to_number): New decl, replacing ...
9593 (isfloat_string): Remove.
bc0a5c13 9594 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9595 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9596 appears to have been a coding error. Similarly, do not accept
9597 strings like +-1e0 as floating point numbers. Do not report
9598 overflow for integer overflows unless the base is not 10 which
9599 means we have no simple and reliable way to continue.
9600 Break out the floating-point parsing into a new
9601 function string_to_number, so that Fstring_to_number parses
9602 floating point numbers consistently with the Lisp reader.
04f2d78b 9603 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9604 (E_CHAR, EXP_INT): Remove, replacing with ...
9605 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9606 (string_to_number): New function, replacing isfloat_string.
9607 This function checks for valid syntax and produces the resulting
9608 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9609 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9610 so that overflow for non-base-10 numbers is reported only when
9611 there's no portable and simple way to convert to floating point.
452f4150 9612
67769ffc
PE
9613 * textprop.c (set_text_properties_1): Rewrite for clarity,
9614 and to avoid GCC warning about integer overflow.
9615
c20db43f
PE
9616 * intervals.h (struct interval): Use EMACS_INT for members
9617 where EMACS_UINT might cause problems. See
9618 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9619 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9620 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9621 All uses changed.
37aa2f85
PE
9622 (offset_intervals): Tell GCC not to worry about length overflow
9623 when negating a negative length.
c20db43f 9624
2538aa2f
PE
9625 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9626 (overrun_check_free): Likewise.
9627
f2d3008d
PE
9628 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9629 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9630 word size.
9631
ec8df744
PE
9632 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9633 (gnutls_make_error): Rename local to avoid shadowing.
9634 (gnutls_emacs_global_deinit): ifdef out; not used.
9635 (Fgnutls_boot): Use const for pointer to readonly storage.
9636 Comment out unused local. Fix pointer signedness problems.
9637
640ee02d
PE
9638 * lread.c (openp): Don't stuff size_t into an 'int'.
9639 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9640 about possible signed overflow.
9641
6048fb2a
PE
9642 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9643 (GDK_KEY_g): Don't define if already defined.
9644 (xg_prepare_tooltip): Avoid pointer signedness problem.
9645 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9646
fa3c87e1
PE
9647 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9648 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9649
2172544b
PE
9650 * xfns.c (Fx_window_property): Simplify a bit,
9651 to make a bit faster and to avoid GCC 4.6.0 warning.
9652 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9653
9b821a21
PE
9654 * fns.c (internal_equal): Don't assume size_t fits in int.
9655
3c616cfa
PE
9656 * alloc.c (compact_small_strings): Tighten assertion a little.
9657
c2982e87
PE
9658 Replace pEd with more-general pI, and fix some printf arg casts.
9659 * lisp.h (pI): New macro, generalizing old pEd macro to other
9660 conversion specifiers. For example, use "...%"pI"d..." rather
9661 than "...%"pEd"...".
9662 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9663 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9664 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9665 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9666 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9667 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9668 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9669 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9670 64-bit hosts.
9671 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9672 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9673 * print.c (safe_debug_print, print_object): Likewise.
9674 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9675 to int.
6f04d126
PE
9676 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9677 avoiding the 0 flag, which is not portable.
c2982e87
PE
9678 * process.c (Fmake_network_process): Use pI to avoid cast.
9679 * region-cache.c (pp_cache): Likewise.
9680 * xdisp.c (decode_mode_spec): Likewise.
9681 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9682 behavior on 64-bit hosts with printf arg.
6f04d126 9683 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9684 (x_stop_queuing_selection_requests): Likewise.
9685 (x_get_window_property): Don't truncate byte count to an 'int'
9686 when tracing.
0b432f21 9687
5e073ec7
PE
9688 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9689 here, since it parses constructs like leading '-' and spaces,
9690 which are not wanted; and it overflows with large numbers.
9691 Instead, simply match F[0-9]+, which is what is wanted anyway.
9692
36372bf9
PE
9693 * alloc.c: Remove unportable assumptions about struct layout.
9694 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9695 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9696 (allocate_vectorlike, make_pure_vector): Use the new macros,
9697 plus offsetof, to remove unportable assumptions about struct layout.
9698 These assumptions hold on all porting targets that I know of, but
9699 they are not guaranteed, they're easy to remove, and removing them
9700 makes further changes easier.
9701
0b432f21
PE
9702 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9703 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9704 (string_overrun_cookie): Now const. Use initializers that
9705 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9706 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9707 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9708 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9709 multiple of sizeof (EMACS_INT); it need not be, if
9710 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9711 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9712
895009e1
JB
97132011-04-26 Juanma Barranquero <lekktu@gmail.com>
9714
9715 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9716
6a7a1b0b
TZ
97172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9718
9719 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9720 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9721 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9722
841a1577 97232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9724
9725 * lisp.h (Qdebug): List symbol.
895009e1 9726 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9727 * keyboard.c (debug-on-event): New variable.
9728 (handle_user_signal): Break into debugger when debug-on-event
9729 matches the current signal symbol.
9730
f2d3ba6f
DN
97312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9732
9733 * alloc.c (check_sblock, check_string_bytes)
9734 (check_string_free_list): Convert to standard C.
9735
42ce4c63
TZ
97362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9737
9738 * w32.c (emacs_gnutls_push): Fix typo.
9739
825cd63c
EZ
97402011-04-25 Eli Zaretskii <eliz@gnu.org>
9741
fb11d64d
EZ
9742 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9743 "cast to pointer from integer of different size".
9744
825cd63c
EZ
9745 Improve doprnt and its use in verror. (Bug#8545)
9746 * doprnt.c (doprnt): Document the set of format control sequences
9747 supported by the function. Use SAFE_ALLOCA instead of always
9748 using `alloca'.
9749
9750 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9751 is one byte too soon. Don't use xrealloc; instead xfree and
9752 xmalloc anew.
9753
e061a11b
TZ
97542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9755
9756 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9757 callbacks stage.
9758
9759 * gnutls.c: Renamed global_initialized to
9760 gnutls_global_initialized. Added internals for the
9761 :verify-hostname-error, :verify-error, and :verify-flags
9762 parameters of `gnutls-boot' and documented those parameters in the
9763 docstring. Start callback support.
9173deec
JB
9764 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9765 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9766 on error. Return error code.
e061a11b
TZ
9767 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9768 (emacs_gnutls_read): Likewise.
9769 (Fgnutls_boot): Return handshake error code.
9770 (emacs_gnutls_handle_error): New function.
9771 (wsaerror_to_errno): Likewise.
9772
9773 * w32.h (emacs_gnutls_pull): Add prototype.
9774 (emacs_gnutls_push): Likewise.
9775
9776 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9777 (emacs_gnutls_push): Likewise.
9778
97792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9780
9781 * process.c (wait_reading_process_output): Check if GnuTLS
9782 buffered some data internally if no FDs are set for TLS
9783 connections.
9784
9785 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9786 (LIBS): Link to USER_LIBS.
9787 ($(BLD)/gnutls.$(0)): New target.
9788
fa6996bc
EZ
97892011-04-24 Eli Zaretskii <eliz@gnu.org>
9790
eb35682e
EZ
9791 * xdisp.c (handle_single_display_spec): Rename the
9792 display_replaced_before_p argument into display_replaced_p, to
9793 make it consistent with the commentary. Fix typos in the
9794 commentary.
9795
e2ad650c
EZ
9796 * textprop.c (syms_of_textprop): Remove dead code.
9797 (copy_text_properties): Delete obsolete commentary about an
9798 interface that was deleted long ago. Fix typos in the description
9799 of arguments.
9800
1b2de274
EZ
9801 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9802 to changes in oldXMenu/XMenu.h from 2011-04-16.
9803 <menu_help_message, prev_menu_help_message>: Constify.
9804 (IT_menu_make_room): menu->help_text is now `const char **';
9805 adjust.
9806
9807 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9808 to changes in oldXMenu/XMenu.h from 2011-04-16.
9809 (struct XMenu): Declare `help_text' `const char **'.
9810
9811 * xfaces.c <Qunspecified>: Make extern again.
9812
9813 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9814 required by POSIX.
1b2de274 9815
762b15be
EZ
9816 * doc.c (get_doc_string): Improve the format passed to `error'.
9817
9818 * doprnt.c (doprnt): Improve commentary.
9819
9820 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9821
9822 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9823 them with etags.
9824
f1052e5d
EZ
9825 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9826 changes in globals.h immediately force recompilation.
762b15be
EZ
9827 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9828 $(CURDIR)/s/ms-w32.h.
9829 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9830
fa6996bc
EZ
9831 * character.c (Fchar_direction): Function deleted.
9832 (syms_of_character): Don't defsubr it.
9833 <char-direction-table>: Deleted.
9834
e6c3da20
EZ
98352011-04-23 Eli Zaretskii <eliz@gnu.org>
9836
9837 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9838 * doprnt.c: Include limits.h.
9839 (SIZE_MAX): New macro.
04f2d78b
CB
9840 (doprnt): Return a size_t value. 2nd arg is now size_t.
9841 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9842 Improve overflow protection. Support `l' modifier for integer
9843 conversions. Support %l conversion. Don't assume an EMACS_INT
9844 argument for integer conversions and for %c.
9845
9846 * lisp.h (doprnt): Restore prototype.
9847
9848 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9849 $(SRC)/character.h.
9850
9851 * Makefile.in (base_obj): Add back doprnt.o.
9852
9853 * deps.mk (doprnt.o): Add back prerequisites.
9854 (callint.o): Depend on character.h.
9855
9856 * eval.c (internal_lisp_condition_case): Include the handler
9857 representation in the error message.
9858 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9859 when breaking from the loop.
9860
9861 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9862
9863 * callint.c (Fcall_interactively): When displaying error message
9864 about invalid control letter, pass the character's codepoint, not
9865 a pointer to its multibyte form. Improve display of the character
9866 in octal and display also its hex code.
9867
9868 * character.c (char_string): Use %x to display the (unsigned)
9869 codepoint of an invalid character, to avoid displaying a bogus
9870 negative value.
9871
9872 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9873 `error', not SYMBOL_NAME itself.
9874
9875 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9876 character arguments to `error'.
9877
9878 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9879 to `error' in error message about FINAL_CHAR argument. Make sure
9880 FINAL_CHAR is a character, and use %c when it is passed as
9881 argument to `error'.
9882
4ffd0d6b 98832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9884
9885 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9886
9887 * w32.c: Include <time.h>.
9888 (sys_localtime): New function.
9889
4ffd0d6b 98902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9891
9892 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9893
4ffd0d6b 9894 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9895
4ffd0d6b 98962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9897
4ffd0d6b
GM
9898 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9899 zombies (Bug#8467).
aac0c6e3 9900
04c56954
EZ
99012011-04-19 Eli Zaretskii <eliz@gnu.org>
9902
9903 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9904 gl_state.e_property when gl_state.object is Qt.
9905
9906 * insdel.c (make_gap_larger): Remove limitation of buffer size
9907 to <= INT_MAX.
9908
16a43933
CY
99092011-04-18 Chong Yidong <cyd@stupidchicken.com>
9910
9911 * xdisp.c (lookup_glyphless_char_display)
9912 (produce_glyphless_glyph): Handle cons cell entry in
9913 glyphless-char-display.
9914 (Vglyphless_char_display): Document it.
9915
9916 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9917 glyphless-char-display.
9918
4581706e
CY
99192011-04-17 Chong Yidong <cyd@stupidchicken.com>
9920
9921 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9922
9923 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9924
9925 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9926 definition for no-X builds.
9927
4887c6e2 99282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9929
fd35b6f9
PE
9930 Static checks with GCC 4.6.0 and non-default toolkits.
9931
5c1ccb01
PE
9932 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9933
006c5daa
PE
9934 * process.c (keyboard_bit_set): Define only if SIGIO.
9935 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9936 (send_process): Repair possible setjmp clobbering.
9937
efc736d3
PE
9938 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9939
4e2fe2e6
PE
9940 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9941
f97334a2
PE
9942 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9943
4e75f29d
PE
9944 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9945 Define only if needed.
9946
90efadd1
PE
9947 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9948 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9949 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9950
3c647824
PE
9951 * dispextern.h (struct redisplay_interface): Rename param
9952 to avoid shadowing.
e264f262 9953 * termhooks.h (struct terminal): Likewise.
761383f4 9954 * xterm.c (xembed_send_message): Likewise.
3c647824 9955
b58c5c4a
PE
9956 * insdel.c (make_gap_smaller): Define only if
9957 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9958
cad59032
PE
9959 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9960 it.
9961
c339dc2e
PE
9962 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9963 so that we aren't warned about unused symbols.
9964
91a3e27b
PE
9965 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9966
399c71d3 9967 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9968
8ffc96f5
PE
9969 * xfns.c (x_real_positions): Mark locals as initialized.
9970
eef9bc79
PE
9971 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9972
098db9dd
PE
9973 * xterm.c: Fix problems found by static analysis with other toolkits.
9974 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9975 (x_dispatch_event): Declare static if USE_GTK, and
9976 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9977 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9978 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9979 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9980 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9981
eb18f6cc
PE
9982 * xmenu.c (menu_help_callback): Pointer type fixes.
9983 Use const pointers when pointing at readonly data. Avoid pointer
9984 signedness clashes.
9985 (FALSE): Remove unused macro.
9986 (update_frame_menubar): Remove unused decl.
9987
1fe72bf8
PE
9988 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9989
60d9e1db
PE
9990 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9991 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9992 (single_menu_item): Rename local to avoid shadowing.
9993
39261c26
PE
9994 * keyboard.c (make_lispy_event): Remove unused local var.
9995
018c5e19
PE
9996 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9997 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9998
63d2b86e
PE
9999 * bitmaps: Change bitmaps from unsigned char back to the X11
10000 compatible char. Avoid the old compiler warnings about
10001 out-of-range initializers by using, for example, '\xab' rather
10002 than 0xab.
10003
aefd87e1
PE
10004 * xgselect.c (xgselect_initialize): Check vs interface
10005 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10006
bf501fb9
PE
10007 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10008
e9829fdf
PE
10009 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10010 to read-only memory.
10011
1086c095
PE
10012 * fns.c (vector): Remove; this old hack is no longer needed.
10013
2baccd04 10014 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10015 Remove unused var.
dde42981 10016 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10017
72391843 10018 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10019
436c16df 10020 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10021 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10022 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10023
92bb796d 10024 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10025 (x_term_init): Remove local to avoid shadowing.
92bb796d 10026
764430a3 10027 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10028
10029 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10030 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10031
d1dfb56c
EZ
100322011-04-16 Eli Zaretskii <eliz@gnu.org>
10033
c4354cb4
EZ
10034 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10035
d1dfb56c
EZ
10036 Fix regex.c, syntax.c and friends for buffers > 2GB.
10037 * syntax.h (struct gl_state_s): Declare character position members
10038 EMACS_INT.
10039
10040 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10041
04f2d78b
CB
10042 * textprop.c (verify_interval_modification, interval_of):
10043 Declare arguments EMACS_INT.
d1dfb56c
EZ
10044
10045 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10046 EMACS_INT.
10047
10048 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10049
10050 * indent.c (Fvertical_motion): Local variable it_start is now
10051 EMACS_INT.
10052
10053 * regex.c (re_match, re_match_2, re_match_2_internal)
10054 (bcmp_translate, regcomp, regexec, print_double_string)
10055 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10056 (re_compile_pattern, re_exec): Declare arguments and local
10057 variables `size_t' and `ssize_t' and return values `regoff_t', as
10058 appropriate.
10059 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10060 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10061 <compile_stack_type>: `size' and `avail' are now `size_t'.
10062
10063 * regex.h <regoff_t>: Use ssize_t, not int.
10064 (re_search, re_search_2, re_match, re_match_2): Arguments that
10065 specify buffer/string position and length are now ssize_t and
10066 size_t. Return type is regoff_t.
10067
613052cd
BK
100682011-04-16 Ben Key <bkey76@gmail.com>
10069
10070 * nsfont.m: Fixed bugs in ns_get_family and
10071 ns_descriptor_to_entity that were caused by using free to
10072 deallocate memory blocks that were allocated by xmalloc (via
10073 xstrdup). This caused Emacs to crash when compiled with
10074 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10075 --enable-checking=xmallocoverrun). xfree is now used to
10076 deallocate these memory blocks.
10077
4170f62f 100782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10079
71b41406
PE
10080 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10081
9587a89d
PE
10082 emacs_write: Accept and return EMACS_INT for sizes.
10083 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10084 et seq.
10085 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10086 Accept and return EMACS_INT.
10087 (emacs_gnutls_write): Return the number of bytes written on
10088 partial writes.
10089 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10090 (emacs_read, emacs_write): Remove check for negative size, as the
10091 Emacs source code has been audited now.
9587a89d
PE
10092 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10093 (emacs_read, emacs_write): Use it.
273a5f82
PE
10094 * process.c (send_process): Adjust to the new signatures of
10095 emacs_write and emacs_gnutls_write. Do not attempt to store
10096 a byte offset into an 'int'; it might overflow.
9587a89d 10097 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10098
3e047f51
PE
10099 * sound.c: Don't assume sizes fit in 'int'.
10100 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10101 Return EMACS_INT, not int.
3e047f51 10102 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10103 Accept EMACS_INT, not int.
10104 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10105 record read return values.
10106
cc39a9db
BK
101072011-04-15 Ben Key <bkey76@gmail.com>
10108
c9d0ec6d
JB
10109 * keyboard.c (Qundefined): Don't declare static since it is used
10110 in nsfns.m.
10111 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10112 static since they are used in nsfont.m.
cc39a9db 10113
6c60eb9f
SM
101142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10115
10116 * process.c (Qprocessp): Don't declare static.
10117 * lisp.h (Qprocessp): Declare again.
10118
7990b61a
JB
101192011-04-15 Juanma Barranquero <lekktu@gmail.com>
10120
10121 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10122
5d4cb038
PE
101232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10124
8bd7b830 10125 Improve C-level modularity by making more things 'static'.
cd64ea1d 10126
e3b27b31
PE
10127 Don't publish debugger-only interfaces to other modules.
10128 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10129 (verify_bytepos, count_markers): Move decls to the only modules
10130 that need them.
10131 * region-cache.h (pp_cache): Likewise.
10132 * window.h (check_all_windows): Likewise.
10133 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10134
5d4cb038
PE
10135 * sysdep.c (croak): Now static, if
10136 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10137 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10138
10139 * alloc.c (refill_memory_reserve): Now static if
10140 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10141 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10142
e87b6180
PE
10143 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10144 Define only if USE_LUCID.
10145
ac64929e
PE
10146 * xrdb.c (x_customization_string, x_rm_string): Now static.
10147
6f37259d
PE
10148 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10149 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10150
1683e3ab
PE
10151 * xdisp.c (draw_row_with_mouse_face): Now static.
10152 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10153
de9c2632
PE
10154 * window.h (check_all_windows): Mark externally visible.
10155
2b96acb7
PE
10156 * window.c (window_deletion_count): Now static.
10157
10158 * undo.c: Make symbols static if they're not exported.
10159 (last_undo_buffer, last_boundary_position, pending_boundary):
10160 Now static.
10161
50436f33
PE
10162 * textprop.c (interval_insert_behind_hooks): Now static.
10163 (interval_insert_in_front_hooks): Likewise.
10164
64520e5c
PE
10165 * term.c: Make symbols static if they're not exported.
10166 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10167 (max_frame_lines, tty_set_terminal_modes):
10168 (tty_reset_terminal_modes, tty_turn_off_highlight):
10169 (get_tty_terminal): Now static.
10170 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10171 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10172 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10173 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10174 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10175
1fa53021
PE
10176 * sysdep.c: Make symbols static if they're not exported.
10177 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10178 Now static.
10179 (sigprocmask_set, full_mask): Remove; unused.
10180 (wait_debugging): Mark as visible.
10181 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10182 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10183
d4b43b22
PE
10184 * syntax.c (syntax_temp): Define only if !__GNUC__.
10185
b7c513d0
PE
10186 * sound.c (current_sound_device, current_sound): Now static.
10187
989b29ad
PE
10188 * search.c (searchbufs, searchbuf_head): Now static.
10189
13a55a78
PE
10190 * scroll.c (scroll_cost): Remove; unused.
10191 * dispextern.h (scroll_cost): Remove decl.
10192
de68a1fc
PE
10193 * region-cache.h (pp_cache): Mark as externally visible.
10194
40ccffa6
PE
10195 * process.c: Make symbols static if they're not exported.
10196 (process_tick, update_tick, create_process, chan_process):
10197 (Vprocess_alist, proc_buffered_char, datagram_access):
10198 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10199 (deactivate_process): Mark defn as static, as well as decl.
10200 * lisp.h (create_process): Remove decl.
10201 * process.h (chan_process, Vprocess_alist): Remove decls.
10202
ad64fc97
PE
10203 * print.c: Make symbols static if they're not exported.
10204 (print_depth, new_backquote_output, being_printed, print_buffer):
10205 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10206 (print_interval, print_number_index, initial_stderr_stream):
10207 Now static.
10208 * lisp.h (Fprinc): Remove decl.
10209 (debug_output_compilation_hack): Mark as externally visible.
10210
adddb265
PE
10211 * sysdep.c (croak): Move decl from here to syssignal.h.
10212 * syssignal.h (croak): Put it here, so the API can be checked when
10213 'croak' is called from dissociate_if_controlling_tty.
10214
1717ede2
PE
10215 * minibuf.c: Make symbols static if they're not exported.
10216 (minibuf_save_list, choose_minibuf_frame): Now static.
10217 * lisp.h (choose_minibuf_frame): Remove decl.
10218
fa5fb2bc
PE
10219 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10220
1e3890d1
PE
10221 * lread.c: Make symbols static if they're not exported.
10222 (read_objects, initial_obarray, oblookup_last_bucket_number):
10223 Now static.
10224 (make_symbol): Remove; unused.
10225 * lisp.h (initial_obarray, make_symbol): Remove decls.
10226
8a1414fa
PE
10227 * keyboard.c: Make symbols static if they're not exported.
10228 (single_kboard, recent_keys_index, total_keys, recent_keys):
10229 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10230 (this_single_command_key_start, echoing, last_auto_save):
10231 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10232 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10233 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10234 (Vlispy_mouse_stem, double_click_count):
10235 Now static.
10236 (force_auto_save_soon): Define only if SIGDANGER.
10237 (ignore_mouse_drag_p): Now static if
10238 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10239 (print_help): Remove; unused.
10240 (stop_character, last_timer_event): Mark as externally visible.
10241 * keyboard.h (ignore_mouse_drag_p): Declare only if
10242 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10243 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10244 * lisp.h (echoing): Remove decl.
10245 (force_auto_save_soon): Declare only if SIGDANGER.
10246 * xdisp.c (redisplay_window): Simplify code, to make it more
10247 obvious that ignore_mouse_drag_p is not accessed if !defined
10248 USE_GTK && !defined HAVE_NS.
10249
93ea6e8f
PE
10250 * intervals.c: Make symbols static if they're not exported.
10251 (merge_properties_sticky, merge_interval_right, delete_interval):
10252 Now static.
10253 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10254
77382fcc
PE
10255 * insdel.c: Make symbols static if they're not exported.
10256 However, leave prepare_to_modify_buffer alone. It's never
10257 called from outside this function, but that appears to be a bug.
10258 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10259 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10260 (adjust_after_replace_noundo): Remove; unused.
10261 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10262 (signal_before_change): Remove decls.
77382fcc 10263
9306c32e
PE
10264 * indent.c (val_compute_motion, val_vmotion): Now static.
10265
cd44d2eb
PE
10266 * image.c: Make symbols static if they're not exported.
10267 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10268 if USE_GTK.
10269 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10270 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10271
ad9a7a06
PE
10272 * fringe.c (standard_bitmaps): Now static.
10273 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10274
81626931
PE
10275 * frame.c: Make symbols static if they're not exported.
10276 (x_report_frame_params, make_terminal_frame): Now static.
10277 (get_frame_param): Now static, unless HAVE_NS.
10278 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10279 (x_get_resource_string): Remove; not used.
10280 * frame.h (make_terminal_frame, x_report_frame_params):
10281 (x_get_resource_string); Remove decls.
10282 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10283 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10284
239f9db9
PE
10285 * font.c, fontset.c: Make symbols static if they're not exported.
10286 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10287 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10288 * font.c (font_close_object): Now static.
10289 * font.h (font_close_object): Remove.
10290 * fontset.c (FONTSET_OBJLIST): Remove.
10291 (free_realized_fontset) #if-0 the body, which does nothing.
10292 (face_suitable_for_char_p): #if-0, as it's never called.
10293 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10294 * xfaces.c (face_at_string_position):
10295 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10296 since 0 is always ASCII.
10297
dfcf3579
PE
10298 * fns.c (weak_hash_tables): Now static.
10299
5045092b
PE
10300 * fileio.c: Make symbols static if they're not exported.
10301 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10302 (Vwrite_region_annotation_buffers): Now static.
10303
57a96f5c
PE
10304 * eval.c: Make symbols static if they're not exported.
10305 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10306 * lisp.h (backtrace_list): Remove decl.
10307
35f08c38
PE
10308 * emacs.c: Make symbols static if they're not exported.
10309 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10310 (fatal_error_code, fatal_error_signal_hook, standard_args):
10311 Now static.
10312 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10313 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10314 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10315 * lisp.h (fatal_error_signal_hook): Remove decl.
10316 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10317
f44bd759
PE
10318 * editfns.c: Move a (normally-unused) function to its only use.
10319 * editfns.c, lisp.h (get_operating_system_release): Remove.
10320 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10321 worth the hassle of breaking this out.
10322
b532497d
PE
10323 * xterm.c: Make symbols static if they're not exported.
10324 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10325 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10326 (x_destroy_window, x_delete_display):
10327 Now static.
10328 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10329 (x_mouse_leave): Remove; unused.
10330 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10331 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10332 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10333 Remove decls.
10334 (x_mouse_leave): Declare only if WINDOWSNT.
10335 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10336 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10337 USE_X_TOOLKIT.
10338
1675728f
PE
10339 * ftxfont.c: Make symbols static if they're not exported.
10340 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10341 HAVE_FREETYPE.
10342 * font.h (ftxfont_driver): Likewise.
10343
e4cebfca
PE
10344 * xfns.c: Make symbols static if they're not exported.
10345 (x_last_font_name, x_display_info_for_name):
10346 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10347 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10348 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10349 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10350 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10351 (last_show_tip_args): Now static.
10352 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10353 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10354 (x_screen_planes): Remove; unused.
10355 * dispextern.h (x_screen_planes): Remove decl.
10356
5bf46f05
PE
10357 * dispnew.c: Make symbols static if they're not exported.
10358 * dispextern.h (redraw_garbaged_frames, scrolling):
10359 (increment_row_positions): Remove.
10360 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10361 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10362 Now static.
10363 (redraw_garbaged_frames): Remove; unused.
10364
435f4c28
PE
10365 * xfaces.c: Make symbols static if they're not exported.
10366 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10367 Remove decls.
10368 * xterm.h (defined_color): Remove decls.
10369 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10370 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10371 (menu_face_changed_default, defined_color, free_realized_face):
10372 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10373 (ascii_face_of_lisp_face): Remove; unused.
10374
8524aef3
PE
10375 * xdisp.c: Make symbols static if they're not exported.
10376 * dispextern.h (scratch_glyph_row, window_box_edges):
10377 (glyph_to_pixel_coords, set_cursor_from_row):
10378 (get_next_display_element, set_iterator_to_next):
10379 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10380 (show_mouse_face): Remove decls
10381 * frame.h (message_buf_print): Likewise.
10382 * lisp.h (pop_message, set_message, check_point_in_composition):
10383 Likewise.
10384 * xterm.h (set_vertical_scroll_bar): Likewise.
10385 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10386 (message_buf_print, scratch_glyph_row, displayed_buffer):
10387 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10388 (get_next_display_element, show_mouse_face, window_box_edges):
10389 (frame_to_window_pixel_xy, check_point_in_composition):
10390 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10391 (glyph_to_pixel_coords): Remove; unused.
10392
16390cd2
PE
10393 * dired.c (file_name_completion): Now static.
10394
10395 * dbusbind.c (xd_in_read_queued_messages): Now static.
10396
a25f4dfa
PE
10397 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10398 * data.c (circular_list_error): Remove.
10399
14a9c8df
PE
10400 * commands.h (last_point_position, last_point_position_buffer):
10401 (last_point_position_window): Remove decls.
10402 * keyboard.c: Make these variables static.
10403
04f2d78b
CB
10404 * coding.h (coding, code_convert_region, encode_coding_gap):
10405 Remove decls.
74ab6df5
PE
10406 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10407 (iso_code_class, detect_coding, code_convert_region): Now static.
10408 (encode_coding_gap): Remove; unused.
10409
38dfbee1
PE
10410 * chartab.c (chartab_chars, chartab_bits): Now static.
10411
a2cb4e63
PE
10412 * charset.h (charset_iso_8859_1): Remove decl.
10413 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10414 Now static.
10415
127198fd
PE
10416 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10417 * ccl.c (Vccl_program_table): Now static.
10418 (check_ccl_update): Remove; unused.
10419
d85b608f
PE
10420 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10421 * category.h: ... from here.
10422 * category.c (check_category_table, set_category_set): Now static.
10423
31cd66f3
PE
10424 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10425 * lisp.h: Remove these decls.
10426
c358e587
PE
10427 * buffer.c (buffer_count): Remove unused var.
10428
e78aecca
PE
10429 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10430 so that it's not optimized away.
10431 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10432 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10433 exported only to the debugger.
10434
e192d7d3 10435 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10436 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10437
92470028
PE
10438 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10439 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10440 was inaccessible from Lisp.
10441 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10442 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10443
244ed907
PE
10444 alloc.c: Import and export fewer symbols, and remove unused items.
10445 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10446 is defined.
10447 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10448 it's not optimized away by whole-program optimization.
10449 (message_enable_multibyte, free_misc): Remove.
10450 (catchlist, handlerlist, mark_backtrace):
10451 Declare only if BYTE_MARK_STACK.
10452 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10453 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10454 (message_enable_multibyte): Remove decl.
10455 (free_misc, interval_free_list, float_block, float_block_index):
10456 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10457 (cons_free_list, last_marked_index):
10458 Now static.
10459 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10460 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10461 (mark_backtrace): Define only if BYTE_MARK_STACK.
10462 * xdisp.c (message_enable_multibyte): Now static.
10463
61c2b50e 10464 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10465 This makes it easier for human readers (and static analyzers)
10466 to see whether these variables are used from other modules.
10467 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10468 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10469 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10470 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10471 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10472 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10473 * xmenu.c, xselect.c:
10474 Declare Q* vars static if they are not used in other modules.
10475 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10476 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10477 Remove decls of unexported vars.
10478 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10479
95c82688
PE
10480 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10481
16a97296
PE
10482 Make Emacs functions such as Fatom 'static' by default.
10483 This makes it easier for human readers (and static analyzers)
10484 to see whether these functions can be called from other modules.
10485 DEFUN now defines a static function. To make the function external
10486 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10487 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10488 (Finit_image_library):
16a97296
PE
10489 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10490 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10491 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10492 Remove decls, since these functions are now static.
10493 (Funintern, Fget_internal_run_time): New decls, since these functions
10494 were already external.
95c82688 10495
16a97296
PE
10496 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10497 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10498 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10499 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10500 * keyboard.c, keymap.c, lread.c:
10501 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10502 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10503 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10504 Mark functions with DEFUE instead of DEFUN,
10505 if they are used in other modules.
10506 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10507 decls for now-static functions.
10508 * buffer.h (Fdelete_overlay): Remove decl.
10509 * callproc.c (Fgetenv_internal): Mark as internal.
10510 * composite.c (Fremove_list_of_text_properties): Remove decl.
10511 (Fcomposition_get_gstring): New forward static decl.
10512 * composite.h (Fcomposite_get_gstring): Remove decl.
10513 * dired.c (Ffile_attributes): New forward static decl.
10514 * doc.c (Fdocumntation_property): New forward static decl.
10515 * eval.c (Ffetch_bytecode): New forward static decl.
10516 (Funintern): Remove extern decl; now in .h file where it belongs.
10517 * fileio.c (Fmake_symbolic_link): New forward static decl.
10518 * image.c (Finit_image_library): New forward static decl.
10519 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10520 * intervals.h (Fprevious_property_change):
10521 (Fremove_list_of_text_properties): Remove decls.
10522 * keyboard.c (Fthis_command_keys): Remove decl.
10523 (Fcommand_execute): New forward static decl.
10524 * keymap.c (Flookup_key): New forward static decl.
10525 (Fcopy_keymap): Now static.
10526 * keymap.h (Flookup_key): Remove decl.
10527 * process.c (Fget_process): New forward static decl.
10528 (Fprocess_datagram_address): Mark as internal.
10529 * syntax.c (Fsyntax_table_p): New forward static decl.
10530 (skip_chars): Remove duplicate decl.
10531 * textprop.c (Fprevious_property_change): New forward static decl.
10532 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10533 Now internal.
10534 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10535 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10536
785bbd42
PE
10537 * editfns.c (Fformat): Remove unreachable code.
10538
8b913b57
AS
105392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10540
10541 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10542 change. (Bug#8496)
10543
a6744a35
EZ
105442011-04-13 Eli Zaretskii <eliz@gnu.org>
10545
10546 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10547 when at ZV. (Bug#8487)
10548
e7974947
AS
105492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10550
baad03f0
AS
10551 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10552 (Bug#8437)
10553 * keyboard.c (parse_tool_bar_item): Likewise.
10554 * sound.c (sound_cleanup, alsa_close): Likewise.
10555 * termcap.c (tgetent): Likewise.
10556 * xfns.c (x_default_font_parameter): Likewise.
10557 * xsettings.c (read_and_apply_settings): Likewise.
10558
e7974947
AS
10559 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10560 (overrun_check_free): Protoize.
10561
28272684
PE
105622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10563
10564 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10565 since callers should never pass a negative size.
10566 Change the signature to match that of plain 'read' and 'write'; see
10567 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10568 * lisp.h: Update prototypes of emacs_write and emacs_read.
10569
11997c76
EZ
105702011-04-11 Eli Zaretskii <eliz@gnu.org>
10571
10572 * xdisp.c (redisplay_window): Don't try to determine the character
10573 position of the scroll margin if the window start point w->startp
e896f03c 10574 is outside the buffer's accessible region. (Bug#8468)
11997c76 10575
8a2cbd72
EZ
105762011-04-10 Eli Zaretskii <eliz@gnu.org>
10577
10578 Fix write-region and its subroutines for buffers > 2GB.
10579 * fileio.c (a_write, e_write): Modify declaration of arguments and
10580 local variables to support buffers larger than 2GB.
10581 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10582
10583 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10584 argument, local variables, and return value.
10585
10586 * lisp.h: Update prototypes of emacs_write and emacs_read.
10587
10588 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10589
4073e537 105902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10591
1ebfdcb6
PE
10592 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10593
b2ded58d
PE
10594 Fix more problems found by GCC 4.6.0's static checks.
10595
7d66342c
PE
10596 * xdisp.c (vmessage): Use a better test for character truncation.
10597
bbf47d44
PE
10598 * charset.c (load_charset_map): <, not <=, for optimization,
10599 and to avoid potential problems with integer overflow.
9248994d 10600 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10601 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10602 * editfns.c (Fformat): Likewise.
1e69125e 10603 * syntax.c (skip_chars): Likewise.
3befa583 10604
e3019616
PE
10605 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10606 This also lets GCC 4.6.0 generate slightly better loop code.
10607
becfa255
PE
10608 * callint.c (Fcall_interactively): <, not <=, for optimization.
10609 (Fcall_interactively): Count the number of arguments produced,
10610 not the number of arguments given. This is simpler and lets GCC
10611 4.6.0 generate slightly better code.
10612
dae0cd48
PE
10613 * ftfont.c: Distingish more carefully between FcChar8 and char.
10614 The previous code passed unsigned char * to a functions like
10615 strlen and xstrcasecmp that expect char *, which does not
10616 conform to the C standard.
10617 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10618 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10619 char * when the C standard requires it.
10620
76032d70
PE
10621 * keyboard.c (read_char): Remove unused var.
10622
eb3f1cc8
PE
10623 * eval.c: Port to Windows vsnprintf (Bug#8435).
10624 Include <limits.h>.
10625 (SIZE_MAX): Define if the headers do not.
10626 (verror): Do not give up if vsnprintf returns a negative count.
10627 Instead, grow the buffer. This ports to Windows vsnprintf, which
10628 does not conform to C99. Problem reported by Eli Zaretskii.
10629 Also, simplify the allocation scheme, by avoiding the need for
10630 calling realloc, and removing the ALLOCATED variable.
10631
70476b54
PE
10632 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10633
12020a9e
PE
10634 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10635 But keep the doprint source code for now, as we might revamp it
10636 and use it again (Bug#8435).
ea6c7ae6
PE
10637 * lisp.h (doprnt): Remove.
10638 * Makefile.in (base_obj): Remove doprnt.o.
10639 * deps.mk (doprnt.o): Remove.
10640
5fdb398c
PE
10641 error: Print 32- and 64-bit integers portably (Bug#8435).
10642 Without this change, on typical 64-bit hosts error ("...%d...", N)
10643 was used to print both 32- and 64-bit integers N, which relied on
10644 undefined behavior.
61bdb816 10645 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10646 * lisp.h (error, verror): Mark as printf-like functions.
10647 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10648 Report overflow in size calculations when allocating printf buffer.
10649 Do not truncate output string at its first null byte.
10650 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10651 Truncate the output at a character boundary, since vsnprintf does not
10652 do that.
10653 * charset.c (check_iso_charset_parameter): Convert internal
10654 character to string before calling 'error', since %c now has the
10655 printf meaning.
10656 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10657 overflow when computing char to be passed to 'error'. Do not
10658 pass Lisp_Object to 'error'; pass the integer instead.
10659 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10660 formatted with plain %d.
10661
b189fa66
PE
10662 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10663
bff87ef0
PE
10664 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10665
7e2cac20
PE
10666 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10667
ce4d90b5
PE
10668 * xterm.c (x_catch_errors): Remove duplicate declaration.
10669
266c9547
PE
10670 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10671
79c49ad2
PE
10672 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10673
368f4090
JM
106742011-04-10 Jim Meyering <meyering@redhat.com>
10675
10676 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10677 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10678 return ssize_t not "int", and use size_t as the buffer length.
10679 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10680 * gnutls.h: Update declarations.
10681 * process.c (read_process_output): Use ssize_t, to match.
10682 (send_process): Likewise.
10683
a32d4040
CY
106842011-04-09 Chong Yidong <cyd@stupidchicken.com>
10685
10686 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10687
8546720e 106882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10689
04f2d78b
CB
10690 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10691 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10692
8546720e
GM
10693 * xterm.c (handle_one_xevent):
10694 * xmenu.c (create_and_show_popup_menu):
10695 * xselect.c (x_decline_selection_request)
10696 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10697
0a2f5c1a 106982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10699
10700 Fix some uses of `int' instead of EMACS_INT.
10701 * search.c (string_match_1, fast_string_match)
10702 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10703 (scan_buffer, find_next_newline_no_quit)
10704 (find_before_next_newline, search_command, Freplace_match)
10705 (Fmatch_data): Make some `int' variables be EMACS_INT.
10706
10707 * xdisp.c (display_count_lines): 3rd argument and return value now
10708 EMACS_INT. All callers changed.
10709 (pint2hrstr): Last argument is now EMACS_INT.
10710
10711 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10712 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10713 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10714 (decode_coding_utf_16, decode_coding_emacs_mule)
10715 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10716 (decode_coding_ccl, decode_coding_charset)
10717 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10718 (decode_coding_iso_2022, decode_coding_emacs_mule)
10719 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10720 <char_offset, last_offset>: Declare EMACS_INT.
10721 (encode_coding_utf_8, encode_coding_utf_16)
10722 (encode_coding_emacs_mule, encode_invocation_designation)
10723 (encode_designation_at_bol, encode_coding_iso_2022)
10724 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10725 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10726 Declare EMACS_INT.
10727 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10728 (encode_invocation_designation): Last argument P_NCHARS is now
10729 EMACS_INT.
10730 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10731 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10732
10733 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10734 All users changed.
10735
10736 * ccl.c (Fccl_execute_on_string): Declare some variables
10737 EMACS_INT.
10738
8546720e 107392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10740
10741 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10742
4e19a977
CS
107432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10744
10745 * process.c (Fformat_network_address): Doc fix.
10746
87302331
R
107472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10748
ee7683eb 10749 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10750
cbb59342
CY
107512011-04-08 Chong Yidong <cyd@stupidchicken.com>
10752
10753 * keyboard.c (read_char): Call Lisp function help-form-show,
10754 instead of using internal_with_output_to_temp_buffer.
10755 (Qhelp_form_show): New var.
e0d38eeb 10756 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10757
10758 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10759
10760 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10761
e67a13ab
CY
107622011-04-06 Chong Yidong <cyd@stupidchicken.com>
10763
04f2d78b
CB
10764 * process.c (Flist_processes): Remove to Lisp.
10765 (list_processes_1): Delete.
e67a13ab 10766
973f782d
EZ
107672011-04-06 Eli Zaretskii <eliz@gnu.org>
10768
7c106b1e
EZ
10769 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10770
973f782d
EZ
10771 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10772
41cf7d1a 107732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10774
ca23cc88
PE
10775 Fix more problems found by GCC 4.6.0's static checks.
10776
f390e2d5
PE
10777 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10778
42eea0d0
PE
10779 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10780
b69769da 10781 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10782
f9541e84
PE
10783 * xdisp.c (vmessage): Mark as a printf-like function.
10784
13841b55
PE
10785 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10786
c136c10f
PE
10787 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10788
5e2d4a30
PE
10789 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10790 printf-like functions.
10791 (tiff_load): Add casts to remove these marks before passing them
10792 to system-supplied API.
10793
583f48b9
PE
10794 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10795
b25d760e
PE
10796 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10797 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10798 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10799 directly, rather than having caller test rule sign. This avoids
10800 some unnecessary tests.
10801 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10802 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10803 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10804
bc7b6697 10805 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10806 (xfont_open): Avoid unnecessary tests.
bc7b6697 10807
27ccc379
PE
10808 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10809
dcd5c89a
PE
10810 * composite.h, composite.c (composition_gstring_put_cache):
10811 Use EMACS_INT, not int, for length.
10812
b13a45c6
PE
10813 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10814 breaking out part of COMPOSITION_DECODE_RULE.
10815 (COMPOSITION_DECODE_RULE): Use it.
10816 * composite.c (get_composition_id): Remove unused local vars,
10817 by using the new macro.
10818
1e792e4d
PE
10819 * textprop.c (set_text_properties_1): Change while to do-while,
10820 since the condition is always true at first.
10821
dc6c6455 10822 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10823 (interval_deletion_adjustment): Return unsigned value.
10824 All uses changed.
dc6c6455 10825
aba7731a
PE
10826 * process.c (list_processes_1, create_pty, read_process_output):
10827 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10828 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10829 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10830 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10831 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10832
fdfc4bf3
PE
10833 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10834
fca8fe46 10835 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10836 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10837
06a0259a 10838 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10839 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10840 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10841
e7b9e80f
PE
10842 * print.c (print_error_message): Avoid int overflow.
10843
56201685
PE
10844 * font.c (font_list_entities): Redo for clarity,
10845 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10846
78834453 10847 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10848 (font_score): Avoid potential overflow in diff calculation.
78834453 10849
0bc0b309 10850 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10851 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10852
e610eaca
PE
10853 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10854
b895abce
PE
10855 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10856 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10857 can always succeed if overflow has undefined behavior.
10858
1f1d9321 10859 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10860 (wordify): Omit three unnecessary tests.
1f1d9321 10861
c59478bc
PE
10862 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10863 All callers changed. This avoids the need for an unused var.
10864
79b73827
PE
10865 * casefiddle.c (casify_region): Remove var that is set but not used.
10866
a4db5dfe
PE
10867 * dired.c (file_name_completion): Remove var that is set but not used.
10868
43aae36e
PE
10869 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10870
2a47c44d 10871 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10872 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10873
a37c69bf
PE
10874 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10875 Check for integer overflow on size calculations.
10876
328ab8e7
PE
10877 * buffer.c (Fprevious_overlay_change): Remove var that is set
10878 but not used.
10879
e5a2a5cb
PE
10880 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10881 Remove vars that are set but not used.
8d84a6eb 10882 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10883 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10884
a60e5f68
PE
10885 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10886
f661cb61 10887 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10888 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10889
f0397f5a
PE
10890 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10891 that are set but not used.
10892
8664db06 10893 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10894 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10895
6abdaa4a
PE
10896 * xselect.c (x_get_local_selection, x_handle_property_notify):
10897 Remove vars that are set but not used.
10898
0ce7538d 10899 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10900 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10901
9ae848fc
PE
10902 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10903 Remove var that is set but not used.
0b918413
PE
10904 (scroll_bar_windows_size): Now size_t, not int.
10905 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10906 Check for overflow.
9ae848fc 10907
a5a62657
PE
10908 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10909 (map_tty_color) [!defined MSDOS]: Likewise.
10910
5c5cdd39
PE
10911 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10912
66ebf983
PE
10913 * coding.c: Remove vars that are set but not used.
10914 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10915 All callers changed.
10916 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10917 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10918 (decode_coding_charset): Remove vars that are set but not used.
10919
1be4d761
PE
10920 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10921 that is set but not used.
10922
47553fa8
PE
10923 * print.c (print_object): Remove var that is set but not used.
10924
1f7196bf 10925 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10926 The gnulib version avoids calling malloc in the usual case,
10927 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10928 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10929 * filelock.c (current_lock_owner): Likewise.
10930 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10931 * sysdep.c: Include allocator.h, careadlinkat.h.
10932 (emacs_no_realloc_allocator): New static constant.
10933 (emacs_readlink): New function.
fdb61804
PE
10934 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10935 ../lib/careadlinkat.h.
d1fdcab7 10936
f84c17c7
SM
109372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10938
10939 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10940 first non-nil return value).
10941
ef3862ad
JD
109422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10943
10944 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10945 if not defined (Bug#8403).
10946
376a7006
JB
109472011-04-02 Juanma Barranquero <lekktu@gmail.com>
10948
10949 * xdisp.c (display_count_lines): Remove parameter `start',
10950 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10951 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10952 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10953 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10954 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10955 and thereabouts. All callers changed.
10956 (get_per_char_metric): Remove parameter `f', unused since
10957 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10958
6ca3801d
JM
109592011-04-02 Jim Meyering <meyering@redhat.com>
10960
10961 do not dereference NULL upon failed strdup
10962 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10963 (ns_get_family): Likewise.
10964
d8e2b5ba
JB
109652011-04-02 Juanma Barranquero <lekktu@gmail.com>
10966
10967 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10968
8c74fcbd
JD
109692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10970
10971 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10972 later (Bug#8403).
10973
7200d79c
SM
109742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10975
03408648 10976 Add lexical binding.
7200d79c 10977
03408648
SM
10978 * window.c (Ftemp_output_buffer_show): New fun.
10979 (Fsave_window_excursion):
10980 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10981
10982 * lread.c (lisp_file_lexically_bound_p): New function.
10983 (Fload): Bind Qlexical_binding.
10984 (readevalloop): Remove `evalfun' arg.
10985 Bind Qinternal_interpreter_environment.
10986 (Feval_buffer): Bind Qlexical_binding.
10987 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10988 Mark as dynamic.
10989 (syms_of_lread): Declare `lexical-binding'.
10990
10991 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10992
10993 * keyboard.c (eval_dyn): New fun.
10994 (menu_item_eval_property): Use it.
ca105506
SM
10995
10996 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10997
03408648
SM
10998 * fns.c (concat, mapcar1): Accept byte-code-functions.
10999
11000 * eval.c (Fsetq): Handle lexical vars.
11001 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11002 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11003 (FletX, Flet): Obey lexical binding.
11004 (Fcommandp): Handle closures.
11005 (Feval): New `lexical' arg.
11006 (eval_sub): New function extracted from Feval. Use it almost
11007 everywhere where Feval was used. Look up vars in lexical env.
11008 Handle closures.
11009 (Ffunctionp): Move from subr.el.
11010 (Ffuncall): Handle closures.
11011 (apply_lambda): Remove `eval_flags'.
11012 (funcall_lambda): Handle closures and new byte-code-functions.
11013 (Fspecial_variable_p): New function.
11014 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11015 but without exporting it to Lisp.
23aba0ea 11016
23aba0ea 11017 * doc.c (Fdocumentation, store_function_docstring):
03408648 11018 * data.c (Finteractive_form): Handle closures.
23aba0ea 11019
03408648
SM
11020 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11021 interactive spec.
ba83908c 11022
04f2d78b
CB
11023 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11024 New byte-codes.
03408648
SM
11025 (exec_byte_code): New function extracted from Fbyte_code to handle new
11026 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11027
03408648 11028 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11029
03408648 11030 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11031
e2abce01
JB
110322011-03-31 Juanma Barranquero <lekktu@gmail.com>
11033
11034 * xdisp.c (redisplay_internal): Fix prototype.
11035
63696a73 110362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11037
63696a73 11038 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11039 (try_scrolling): Use it when setting scroll_limit.
11040 Limit scrolling to 100 screen lines.
63696a73
EZ
11041 (redisplay_window): Even when falling back on "recentering",
11042 position point in the window according to scroll-conservatively,
11043 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11044
11045 (try_scrolling): When point is above the window, allow searching
11046 as far as scroll_max, or one screenful, to compute vertical
11047 distance from PT to the scroll margin position. This prevents
11048 try_scrolling from unnecessarily failing when
11049 scroll-conservatively is set to a value slightly larger than the
11050 window height. Clean up the case of PT below the margin at bottom
11051 of window: scroll_max can no longer be INT_MAX. When aggressive
11052 scrolling is in use, don't let point enter the opposite scroll
11053 margin as result of the scroll.
11054 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11055 threshold of 100 lines for never-recentering scrolling.
11056
e4cc2dfc
JB
110572011-03-31 Juanma Barranquero <lekktu@gmail.com>
11058
11059 * dispextern.h (move_it_by_lines):
11060 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11061 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11062 (message_log_check_duplicate): Remove parameters `prev_bol' and
11063 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11064 (redisplay_internal): Remove parameter `preserve_echo_area',
11065 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11066
11067 * indent.c (Fvertical_motion):
11068 * window.c (window_scroll_pixel_based, Frecenter):
11069 Don't pass `need_y_p' to `move_it_by_lines'.
11070
1c470562
SM
110712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11072
44f230aa
SM
11073 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11074 steal a few bits to be more compact.
11075 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11076 Remove unneeded casts.
11077
1c470562
SM
11078 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11079
888adce9
ZK
110802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11081
11082 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11083 binding" message (bug#7967).
11084
f838ed7b
PE
110852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11086
77861b95
PE
11087 Fix more problems found by GCC 4.6.0's static checks.
11088
de6dbc14
PE
11089 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11090 Remove unused local var.
11091
f838ed7b
PE
11092 * editfns.c (Fmessage_box): Remove unused local var.
11093
792c7b2b
PE
11094 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11095 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11096 Omit unused local vars.
c499e557 11097 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11098 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11099 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11100 Omit unused local var.
11101
ba0165e1
PE
11102 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11103 Don't assume string length fits in int.
32ad8845 11104 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11105 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11106
3c59b4c9
PE
11107 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11108 instead of alloca (Bug#8344).
11109
a3eed478 11110 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11111 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11112
eb4d412d
PE
11113 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11114
1658b401
PE
11115 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11116 concerns.
11117
11118 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11119
11120 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11121
9a2c6e05
PE
11122 * keyboard.c (syms_of_keyboard): Use the same style as later
11123 in this function when indexing through an array. This also
11124 works around GCC bug 48267.
11125
03d0a109
PE
11126 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11127
44f730c8
PE
11128 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11129
fe75f926
PE
11130 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11131 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11132
ffa8c828
PE
11133 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11134 This avoids undefined behavior on integer overflow, and is a bit
11135 more convenient anyway since it is compared to a size_t variable.
11136
c5101a77
PE
11137 Variadic C functions now count arguments with size_t, not int.
11138 This avoids an unnecessary limitation on 64-bit machines, which
11139 caused (substring ...) to crash on large vectors (Bug#8344).
11140 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11141 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11142 All variadic functions and their callers changed accordingly.
c5101a77
PE
11143 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11144 * data.c (arith_driver, float_arith_driver): Likewise.
11145 * editfns.c (general_insert_function): Likewise.
11146 * eval.c (struct backtrace.nargs, interactive_p)
11147 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11148 (funcall_lambda, mark_backtrace): Likewise.
11149 * fns.c (concat): Likewise.
11150 * frame.c (x_set_frame_parameters): Likewise.
11151 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11152 0 if not found, not -1. All callers changed.
11153
dd3f25f7
PE
11154 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11155 (stack_copy_size): Now size_t, not int.
11156 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11157
461c2ab9
JB
111582011-03-28 Juanma Barranquero <lekktu@gmail.com>
11159
11160 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11161 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11162 All callers changed.
11163
11164 * lisp.h (multibyte_char_to_unibyte):
11165 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11166 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11167 * character.h (CHAR_TO_BYTE8):
11168 * cmds.c (internal_self_insert):
11169 * editfns.c (general_insert_function):
11170 * keymap.c (push_key_description):
11171 * search.c (Freplace_match):
11172 * xdisp.c (message_dolog, set_message_1): All callers changed.
11173
f6d62986
SM
111742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11175
11176 * keyboard.c (safe_run_hook_funcall): New function.
11177 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11178 don't set the hook to nil, but remove the offending function instead.
11179 (Qcommand_hook_internal): Remove, unused.
11180 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11181 Vcommand_hook_internal.
11182
11183 * eval.c (enum run_hooks_condition): Remove.
11184 (funcall_nil, funcall_not): New functions.
11185 (run_hook_with_args): Call each function through a `funcall' argument.
11186 Remove `cond' argument, now redundant.
11187 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11188 (Frun_hook_with_args_until_failure): Adjust accordingly.
11189 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11190
1db5b1ad
JB
111912011-03-28 Juanma Barranquero <lekktu@gmail.com>
11192
11193 * dispextern.h (string_buffer_position): Remove declaration.
11194
11195 * print.c (strout): Remove parameter `multibyte', unused since
11196 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11197
11198 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11199 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11200 All callers changed.
11201
11202 * w32.c (_wsa_errlist): Use braces for struct initializers.
11203
11204 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11205 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11206 All callers changed.
11207 (string_buffer_position): Likewise. Also, make static (it's never
11208 used outside xdisp.c).
11209 (cursor_row_p): Remove parameter `w', unused since
11210 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11211 (decode_mode_spec): Remove parameter `precision', introduced during
11212 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11213 All callers changed.
11214
5ffb62aa
JD
112152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11216
11217 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11218
461c2ab9 112192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11220
11221 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11222 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11223 (ns_update_auto_hide_menu_bar): New functions.
11224 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11225 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11226 ns_constrain_all_frames.
11227 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11228 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11229
5c380ffb
JD
112302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11231
11232 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11233
9af30bdf
GM
112342011-03-27 Glenn Morris <rgm@gnu.org>
11235
11236 * syssignal.h: Replace RETSIGTYPE with void.
11237 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11238 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11239 Replace SIGTYPE with void everywhere.
11240 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11241 * s/template.h (SIGTYPE): Remove commented out definition.
11242
e2abce01
JB
112432011-03-26 Eli Zaretskii <eliz@gnu.org>
11244
11245 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11246 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11247
f868cd8a
JB
112482011-03-26 Juanma Barranquero <lekktu@gmail.com>
11249
59eb0929
JB
11250 * w32.c (read_unc_volume): Use parameter `henum', instead of
11251 global variable `wget_enum_handle'.
11252
11253 * keymap.c (describe_vector): Remove parameters `indices' and
11254 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11255 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11256
f868cd8a
JB
11257 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11258
11259 * keyboard.c (timer_check): Remove parameter `do_it_now',
11260 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11261 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11262 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11263
11264 * keyboard.c (read_char):
11265 * w32menu.c (w32_menu_display_help):
11266 * xmenu.c (show_help_event, menu_help_callback):
11267 Adjust calls to `show_help_echo'.
11268
11269 * gtkutil.c (xg_maybe_add_timer):
11270 * keyboard.c (readable_events):
11271 * process.c (wait_reading_process_output):
11272 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11273
11274 * insdel.c (adjust_markers_gap_motion):
11275 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11276 (gap_left, gap_right): Don't call it.
11277
2ecf6fdb
CY
112782011-03-25 Chong Yidong <cyd@stupidchicken.com>
11279
11280 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11281 incurred during fontification.
11282
6b1f9ba4
JB
112832011-03-25 Juanma Barranquero <lekktu@gmail.com>
11284
11285 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11286 (DEFVAR_PER_BUFFER): Don't pass it.
11287
11288 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11289 (scrolling_window): Don't pass it.
11290
0f4a96b5
JB
112912011-03-25 Juanma Barranquero <lekktu@gmail.com>
11292
11293 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11294
11295 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11296 and `suffix'.
11297 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11298 of variables specific to SELinux and computation of `encoded_absname'.
11299
11300 * image.c (XPutPixel): Remove unused variable `height'.
11301
11302 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11303
11304 * unexw32.c (get_section_info): Remove unused variable `section'.
11305
11306 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11307 (system_process_attributes): Remove unused variable `sess'.
11308 (sys_read): Remove unused variable `err'.
11309
11310 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11311 (w32_wnd_proc): Remove unused variable `isdead'.
11312 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11313 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11314 (x_create_tip_frame): Remove unused variable `tem'.
11315
11316 * w32inevt.c (w32_console_read_socket):
11317 Remove unused variable `no_events'.
11318
11319 * w32term.c (x_draw_composite_glyph_string_foreground):
11320 Remove unused variable `width'.
11321
1149507c
JB
113222011-03-24 Juanma Barranquero <lekktu@gmail.com>
11323
11324 * w32term.c (x_set_glyph_string_clipping):
11325 Don't pass uninitialized region to CombineRgn.
11326
9c88f339
JB
113272011-03-23 Juanma Barranquero <lekktu@gmail.com>
11328
11329 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11330 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11331 (Fx_close_connection): Remove unused variable `i'.
11332
11333 * w32font.c (w32font_draw): Return number of glyphs.
11334 (w32font_open_internal): Remove unused variable `i'.
11335 (w32font_driver): Add missing initializer.
11336
11337 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11338 (fill_in_menu): Remove unused variable `items_added'.
11339
11340 * w32term.c (last_mouse_press_frame): Remove static global variable.
11341 (w32_clip_to_row): Remove unused variable `f'.
11342 (x_delete_terminal): Remove unused variable `i'.
11343
11344 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11345 (NOTHING): Remove unused static global variable.
11346 (uniscribe_check_otf): Remove unused variable `table'.
11347 (uniscribe_font_driver): Add missing initializers.
11348
dee091a3
JD
113492011-03-23 Julien Danjou <julien@danjou.info>
11350
11351 * term.c (Fsuspend_tty, Fresume_tty):
11352 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11353 * window.c (temp_output_buffer_show):
11354 * insdel.c (signal_before_change):
11355 * frame.c (Fhandle_switch_frame):
11356 * fileio.c (Fdo_auto_save):
11357 * emacs.c (Fkill_emacs):
11358 * editfns.c (save_excursion_restore):
11359 * cmds.c (internal_self_insert):
11360 * callint.c (Fcall_interactively):
11361 * buffer.c (Fkill_all_local_variables):
11362 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11363 Use Frun_hooks.
0f4a96b5 11364 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11365 unconditionally since it does the check itself.
dee091a3 11366
2c520ab5 113672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11368
c9c49752
PE
11369 Fix more problems found by GCC 4.5.2's static checks.
11370
8abc3f12
PE
11371 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11372 the first time through the loop, since we know p0 < p1 then.
11373 This also avoids a gcc -Wstrict-overflow warning.
11374
a2d26660
PE
11375 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11376 leading to a memory leak, possible in functions like
11377 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11378 of objects (Bug#8318).
a2d26660 11379
916c72e9
PE
11380 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11381 that could (at least in theory) be that large.
11382
19ab8a18
PE
11383 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11384 This is less likely to overflow, and avoids undefined behavior if
11385 overflow does occur. All callers changed. Use strtoul to scan
11386 for the unsigned long integer.
b7cbbd6f
PE
11387 (pint2hrstr): Simplify and tune code slightly.
11388 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11389
f0641eff
PE
11390 * scroll.c (do_scrolling): Work around GCC bug 48228.
11391 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11392
7f650bb9
PE
11393 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11394 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11395 (validate_x_resource_name): Simplify count usage.
11396 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11397
37dd57d1
PE
11398 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11399 fail (Bug#8306).
81e56e61 11400
699979fc 11401 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11402
401bf9b4
PE
11403 * process.c (Fmake_network_process): Use socklen_t, not int,
11404 where POSIX says socklen_t is required in portable programs.
11405 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11406 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11407 (Fmake_network_process, server_accept_connection):
11408 (wait_reading_process_output, read_process_output):
11409 Likewise.
11410
b93aacde
PE
11411 * process.c: Rename or move locals to avoid shadowing.
11412 (list_processes_1, Fmake_network_process):
11413 (read_process_output_error_handler, exec_sentinel_error_handler):
11414 Rename or move locals.
4dc343ee 11415 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11416 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11417 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11418 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11419 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11420
af8a867c 11421 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11422 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11423 Include tparam.h instead, since it declares them.
af8a867c
PE
11424 * cm.h (PC): Remove extern decl; tparam.h now does this.
11425 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11426 * terminfo.c: Include tparam.h, to check interfaces.
11427 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11428 (tparam): Adjust signature to match interface in tparam.h;
11429 this removes some undefined behavior. Check that outstring and len
11430 are zero, which they always are with Emacs.
11431 * tparam.h (PC, BC, UP): New extern decls.
11432
0248044d 11433 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11434 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11435
8ff096c1 11436 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11437 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11438 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11439 (ftfont_list): Remove unused local.
49eaafba
PE
11440 (get_adstyle_property, ftfont_pattern_entity):
11441 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11442 Rename locals to avoid shadowing.
8ff096c1 11443
e2be39f6
PE
11444 * xfont.c (xfont_list_family): Mark var as initialized.
11445
c9735e30
PE
11446 * xml.c (make_dom): Now static.
11447
8f5201ae
PE
11448 * composite.c (composition_compute_stop_pos): Rename local to
11449 avoid shadowing.
b246f932
PE
11450 (composition_reseat_it): Remove unused locals.
11451 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11452 (composition_update_it): Mark var as initialized.
11b61122
PE
11453 (find_automatic_composition): Mark vars as initialized,
11454 with a FIXME (Bug#8290).
8f5201ae 11455
760fbc2c
PE
11456 character.h: Rename locals to avoid shadowing.
11457 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11458 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11459 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11460 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11461 to avoid shadowing.
11462
ff08eb85
PE
11463 * textprop.c (property_change_between_p): Remove; unused.
11464
fc7bf025
PE
11465 * intervals.c (interval_start_pos): Now static.
11466
235d7abc
PE
11467 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11468
44f230aa
SM
11469 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11470 Rename locals to avoid shadowing.
3e7d6594 11471
50060332
PE
11472 * sound.c (wav_play, au_play, Fplay_sound_internal):
11473 Fix pointer signedness.
d01f234b 11474 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11475 (wav_play): Initialize a variable to 0, to prevent undefined
11476 behavior (Bug#8278).
50060332 11477
c4fc4e30
PE
11478 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11479
918436ed
PE
11480 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11481
c939f91b
PE
11482 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11483 clobbering (Bug#8298).
b9c7f648
PE
11484 * sysdep.c (sys_subshell): Likewise.
11485 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11486
6bd8c144
PE
11487 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11488 This should get cleaned up, so that child_setup has the
11489 same signature on all platforms.
11490
7710357c 11491 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11492 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11493
c59da222
CY
114942011-03-22 Chong Yidong <cyd@stupidchicken.com>
11495
11496 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11497 not to be necessary, and produces flickering.
11498
66b87493
GM
114992011-03-20 Glenn Morris <rgm@gnu.org>
11500
11501 * config.in: Remove file.
11502
45b6f6d5
JB
115032011-03-20 Juanma Barranquero <lekktu@gmail.com>
11504
11505 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11506 are now in src/globals.h.
11507 (syms_of_minibuf): Remove spurious & from previous change.
11508
cd394be1 115092011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11510
11511 * minibuf.c (completing-read-function): New variable.
11512 (completing-read-default): Rename from completing-read.
11513 (completing-read): Call completing-read-function.
11514
b14e3e21
CY
115152011-03-19 Juanma Barranquero <lekktu@gmail.com>
11516
11517 * xfaces.c (Fx_load_color_file):
11518 Read color file from absolute filename (bug#8250).
11519
f2b726e6
JB
115202011-03-19 Juanma Barranquero <lekktu@gmail.com>
11521
11522 * makefile.w32-in: Update dependencies.
11523
09f6ff02
EZ
115242011-03-17 Eli Zaretskii <eliz@gnu.org>
11525
11526 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11527
29a6015a
PE
115282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11529
a3a6c54e
PE
11530 Fix more problems found by GCC 4.5.2's static checks.
11531
b766f867
PE
11532 * process.c (make_serial_process_unwind, send_process_trap):
11533 (sigchld_handler): Now static.
11534
be02381c
PE
11535 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11536 That way, the code declares only the vars that it needs.
11537 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11538 * s/cygwin.h (PTY_ITERATION): Likewise.
11539 * s/darwin.h (PTY_ITERATION): Likewise.
11540 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11541
57048744
PE
11542 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11543 * process.c (allocate_pty): Don't declare stb unless it's needed.
11544
7914961c 11545 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11546 (CONSTANTLIM): Remove; unused.
11547 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11548 Define only if needed.
7914961c 11549
b3967b18
PE
11550 * unexelf.c (unexec): Name an expression,
11551 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11552 Use a different way to cause a compilation error if anyone uses
11553 n rather than nn, a way that does not involve shadowing.
73366a00 11554 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11555
29a6015a
PE
11556 * deps.mk (unexalpha.o): Remove; unused.
11557
43cfc33e 11558 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11559 * unexec.h: New file.
ce701a33
PE
11560 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11561 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11562 Depend on unexec.h.
11563 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11564 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11565 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11566 Change as necessary to match prototype in unexec.h.
ce701a33 11567
01f44d5a
PE
11568 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11569 shadowing.
4f63c6bb 11570 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11571
a6670b0b
PE
11572 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11573 Rename locals to avoid shadowing.
11574
cef2010d 11575 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11576 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11577
d4d7173a
PE
11578 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11579
f08b802a
PE
11580 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11581 warning when compiling print.c.
11582
3ddb0639
PE
11583 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11584 instead of using an uninitialized var.
5ad03b97 11585 (font_sort_entities): Mark var as initialized.
3ddb0639 11586
170a2692
PE
11587 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11588
e663c700
PE
11589 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11590 pointers to constants.
89bc529a 11591 (font_parse_fcname): Remove unused vars.
7b81e2d0 11592 (font_delete_unmatched): Now static.
ea838e10 11593 (font_get_spec): Remove; unused.
13a547c6
PE
11594 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11595 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11596 Rename or move locals to avoid shadowing.
e663c700 11597
2a80c887 11598 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11599 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11600
1384fa33 11601 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11602 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11603
8b2c52e9
PE
11604 * alloc.c (mark_backtrace): Move decl from here ...
11605 * lisp.h: ... to here, so that it can be checked.
11606
475545b5 11607 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11608 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11609 (lisp_indirect_variable): Name an expression,
11610 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11611 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11612
b1349114 11613 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11614 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11615 Use const pointer when appropriate.
b1349114 11616
a2928364
PE
11617 * lisp.h (get_system_name, get_operating_system_release):
11618 Move decls here, to check interfaces.
11619 * process.c (get_operating_system_release): Move decl to lisp.h.
11620 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11621 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11622 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11623 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11624 (Fformat_time_string, Fencode_time, Finsert_char):
11625 (Ftranslate_region_internal, Fformat):
11626 Rename or remove local vars to avoid shadowing.
9710023e 11627 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11628
a415e694
PE
11629 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11630 avoid shadowing.
11631
8ef4622d
PE
11632 * lisp.h (eassert): Check that the argument compiles, even if
11633 ENABLE_CHECKING is not defined.
11634
946f9a5b
PE
11635 * data.c (Findirect_variable): Name an expression, to avoid
11636 gcc -Wbad-function-cast warning.
112396d6 11637 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11638 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11639 (Fmake_variable_buffer_local, Fmake_local_variable):
11640 Mark variables as initialized.
52746918 11641 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11642
e5aab7e7 11643 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11644 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11645 Rename locals to avoid shadowing.
dff45157
PE
11646 (mark_stack): Move local variables into the #ifdef region where
11647 they're used.
7bc26fdb
PE
11648 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11649 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11650 needed otherwise.
11651 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11652 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11653 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11654
e5aab7e7
PE
11655 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11656 avoids undefined behavior in theory.
11657
4da60324
PE
11658 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11659
88043301
PE
11660 Use functions, not macros, for up- and down-casing (Bug#8254).
11661 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11662 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11663 to use the following functions instead of these macros.
11664 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11665 EMACS_INT, since callers assume the returned value fits in int.
11666 (upcase1): Likewise, for UPCASE_TABLE.
11667 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11668 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11669 the race-condition problem in the old DOWNCASE.
88043301 11670
19ed5445
PE
11671 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11672 Rename locals to avoid shadowing.
11673 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11674 (regex_compile, re_search_2, re_match_2_internal):
11675 Remove unused local vars.
952db0d7
PE
11676 (FREE_VAR): Rewrite so as not to use empty "else",
11677 which gcc can warn about.
da053e48 11678 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11679 (RETALLOC_IF): Define only if needed.
11680 (WORDCHAR_P): Likewise. This one is never needed, but is used
11681 only in a comment talking about a compiler bug, so put inside
11682 the #if 0 of that comment.
11683 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11684 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11685 Remove; unused.
19ed5445 11686
1f3561e4 11687 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11688 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11689 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11690
ded6f8f7
PE
11691 * search.c (simple_search): Remove unused var.
11692
dbd37a95
PE
11693 * dired.c (compile_pattern): Move decl from here ...
11694 * lisp.h: ... to here, so that it can be checked.
11695 (struct re_registers): New forward decl.
11696
7e47afad
PE
11697 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11698
85f24f61
PE
11699 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11700 All uses changed.
11701 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11702 Rename locals to avoid shadowing.
5671df8f 11703 (Fvertical_motion): Mark locals as initialized.
85f24f61 11704
181aa2be 11705 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11706 (casify_region): Mark local as initialized.
181aa2be 11707
930d429c
PE
11708 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11709
7082eac6
PE
11710 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11711 New macros, so that the caller can use some names other than
11712 gcpro1, gcpro2, etc.
11713 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11714 of the new macros.
11715 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11716 argument, for consistency with GCPRO2_VAR, etc: it is now the
11717 prefix of the variable, not the variable itself. All uses
11718 changed.
38b2c076
PE
11719 * dired.c (directory_files_internal, file_name_completion):
11720 Rename locals to avoid shadowing.
11721
15206ed9
PE
11722 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11723 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11724 dired.c's scmp function, had undefined behavior.
11725 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11726 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11727 * buffer.h: ... to here, because these macros use current_buffer,
11728 and the new implementation with inline functions needs to have
11729 current_buffer in scope now, rather than later when the macros
11730 are used.
11731 (downcase, upcase1): New static inline functions.
11732 (DOWNCASE, UPCASE1): Reimplement using these functions.
11733 This avoids undefined behavior in expressions like
11734 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11735 from race conditions in accessing the global variables
11736 case_temp1 and case_temp2.
11737 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11738 * lisp.h (case_temp1, case_temp2): Remove their decls.
11739 * character.h (ASCII_CHAR_P): Move from here ...
11740 * lisp.h: ... to here, so that the inline functions mentioned
11741 above can use them.
11742
4a6bea26
PE
11743 * dired.c (directory_files_internal_unwind): Now static.
11744
f14b7e14
PE
11745 * fileio.c (file_name_as_directory, directory_file_name):
11746 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11747 Now static.
2893f146
PE
11748 (file_name_as_directory): Use const pointers when appropriate.
11749 (Fexpand_file_name): Likewise. In particular, newdir might
11750 point at constant storage, so make it a const pointer.
fd4ead52 11751 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11752 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11753 signedness issues.
f839df0c
PE
11754 (Fset_file_times, Finsert_file_contents, auto_save_error):
11755 Rename locals to avoid shadowing.
f14b7e14 11756
5716756e 11757 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11758 (Ftry_completion, Fall_completions): Rename or remove locals
11759 to avoid shadowing.
5716756e 11760
b4c3046a
PE
11761 * marker.c (bytepos_to_charpos): Remove; unused.
11762
b45db522
PE
11763 * lisp.h (verify_bytepos, count_markers): New decls,
11764 so that gcc does not warn that these functions aren't declared.
11765
85876d07
PE
11766 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11767 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11768 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11769 (copy_text): Remove unused local var.
85876d07 11770
03d78a21 11771 * filelock.c (within_one_second): Now static.
b3dd38ab 11772 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11773
5df8f01b
PE
11774 * buffer.c (fix_overlays_before): Mark locals as initialized.
11775 (fix_start_end_in_overlays): Likewise. This function should be
11776 simplified by using pointers-to-pointers, but that's a different
11777 matter.
b1d876f1 11778 (switch_to_buffer_1): Now static.
8f54f30a
PE
11779 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11780 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11781
a70072c9 11782 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11783 Fix pointer signedness issue.
edced198
PE
11784 (sys_subshell): Mark local as volatile if checking for lint,
11785 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11786 (MAXPATHLEN): Define only if needed.
a70072c9 11787
a0977c44
PE
11788 * process.c (serial_open, serial_configure): Move decls from here ...
11789 * systty.h: ... to here, so that they can be checked.
11790
a884fdcc
PE
11791 * fns.c (get_random, seed_random): Move extern decls from here ...
11792 * lisp.h: ... to here, so that they can be checked.
11793
604efe86 11794 * sysdep.c (reset_io): Now static.
b8950c94 11795 (wait_for_termination_signal): Remove; unused.
604efe86 11796
38fc62d9
PE
11797 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11798 (copy_keymap_item, append_key, push_text_char_description):
11799 Now static.
1004a21a 11800 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11801 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11802 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11803 (describe_map_tree):
11804 Rename locals to avoid shadowing.
38fc62d9 11805
2f2650da
PE
11806 * keyboard.c: Declare functions static if they are not used elsewhere.
11807 (echo_char, echo_dash, cmd_error, top_level_2):
11808 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11809 (read_char, kbd_buffer_get_event, make_lispy_position):
11810 (make_lispy_event, make_lispy_movement, apply_modifiers):
11811 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11812 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11813 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11814 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11815 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11816
a053e86c 11817 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11818 (mark_kboards): Move decl here ...
11819 * alloc.c (mark_kboards): ... from here.
a053e86c 11820
4752793e
PE
11821 * lisp.h (force_auto_save_soon): New decl.
11822
74f10ca7 11823 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11824 (DEFINE_DUMMY_FUNCTION): New macro.
11825 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11826 Use it.
c03cd23f
PE
11827 (main): Add casts to avoid warnings
11828 if GCC considers string literals to be constants.
74f10ca7 11829
022e70d4
PE
11830 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11831
59d6fe83
PE
11832 * dbusbind.c: Pointer signedness fixes.
11833 (xd_signature, xd_append_arg, xd_initialize):
11834 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11835 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11836 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11837 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11838
78320123
PE
11839 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11840 if GCC considers string literals to be constants.
49cebcca 11841 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11842
35ac2a97
SM
118432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11844
fb103ca9
SM
11845 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11846 (print_preprocess, print_object): New macro to fix last change.
11847
35ac2a97
SM
11848 * print.c (print_preprocess): Don't forget font objects.
11849
62973b41
JB
118502011-03-16 Juanma Barranquero <lekktu@gmail.com>
11851
11852 * emacs.c (USAGE3): Doc fixes.
11853
0e48bb22
AS
118542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11855
11856 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11857 structure.
11858
7684e57b
JB
118592011-03-14 Juanma Barranquero <lekktu@gmail.com>
11860
11861 * lisp.h (VWindow_system, Qfile_name_history):
11862 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11863 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11864 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11865
11866 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11867 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11868
11869 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11870 * w32console.c (detect_input_pending, read_input_pending)
11871 (encode_terminal_code):
11872 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11873 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11874 (w32_system_caret_y, Qfile_name_history):
11875 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11876 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11877 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11878 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11879 * w32proc.c (Qlocal, report_file_error):
11880 * w32term.c (Vwindow_system, updating_frame):
11881 * w32uniscribe.c (initialized, uniscribe_font_driver):
11882 Remove unneeded extern declarations.
11883
2aa46d6c
CY
118842011-03-14 Chong Yidong <cyd@stupidchicken.com>
11885
c96bbc66 11886 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11887
cffc6f3b
CY
118882011-03-13 Chong Yidong <cyd@stupidchicken.com>
11889
11890 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11891 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11892 These macros can no longer be used for assignment.
11893
44f230aa
SM
11894 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11895 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11896 (record_buffer_markers, fetch_buffer_markers): New functions for
11897 recording and fetching special buffer markers.
11898 (set_buffer_internal_1, set_buffer_temp): Use them.
11899
11900 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11901
11902 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11903
11904 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11905 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11906
11907 * xdisp.c (hscroll_window_tree):
11908 (reconsider_clip_changes): Use PT instead of BUF_PT.
11909
d251f04b
EZ
119102011-03-13 Eli Zaretskii <eliz@gnu.org>
11911
11912 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11913 $(EMACS_ROOT)/lib/intprops.h.
11914
f0c77cd1
PE
119152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11916
3eca4629
PE
11917 Fix more problems found by GCC 4.5.2's static checks.
11918
7c86ee98
PE
11919 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11920 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11921 (xg_free_frame_widgets): Make it clear that a local variable is
11922 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11923 (gdk_window_get_screen): Make it clear that this macro is needed
11924 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11925 (int_gtk_range_get_value): New function, which avoids a diagnostic
11926 from gcc -Wbad-function-cast.
11927 (xg_set_toolkit_scroll_bar_thumb): Use it.
11928 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11929 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11930 (get_utf8_string, xg_get_file_with_chooser):
11931 Rename locals to avoid shadowing.
11932 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11933
41729b81
PE
11934 * xgselect.c (xg_select): Remove unused var.
11935
f0c77cd1
PE
11936 * image.c (four_corners_best): Mark locals as initialized.
11937 (gif_load): Initialize transparent_p to zero (Bug#8238).
11938 Mark another local as initialized.
ec6cf4c6 11939 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11940
ce0ad53d 11941 * image.c (clear_image_cache): Now static.
d5d5a617 11942 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11943 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11944 (x_edge_detection): Remove unnecessary cast that
11945 gcc -Wbad-function-cast diagnoses.
2037898d 11946 (gif_load): Fix pointer signedness.
6ae141d6
PE
11947 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11948 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11949
33383987 119502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11951
d32df629
PE
11952 Improve quality of tests for time stamp overflow.
11953 For example, without this patch (encode-time 0 0 0 1 1
11954 1152921504606846976) returns the obviously-bogus value (-948597
11955 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11956 reports time overflow. See
11957 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11958 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11959 * editfns.c: Include limits.h and intprops.h.
11960 (TIME_T_MIN, TIME_T_MAX): New macros.
11961 (time_overflow): Move earlier, to before first use.
11962 (hi_time, lo_time): New functions, for an accurate test for
11963 out-of-range times.
11964 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11965 (Fget_internal_run_time): Don't assume time_t fits in int.
11966 (make_time): Use list2 instead of Fcons twice.
11967 (Fdecode_time): More accurate test for out-of-range times.
11968 (check_tm_member): New function.
11969 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11970 (lisp_time_argument): Don't rely on undefined left-shift and
11971 right-shift behavior when checking for time stamp overflow.
8be6f318 11972
fe31d94c
PE
11973 * editfns.c (time_overflow): New function, refactoring common code.
11974 (Fformat_time_string, Fdecode_time, Fencode_time):
11975 (Fcurrent_time_string): Use it.
11976
8be6f318
PE
11977 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11978 * dired.c (make_time): Move to ...
11979 * editfns.c (make_time): ... here.
11980 * systime.h: Note the move.
11981
09d9db2c 119822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11983
126bc0dc
YM
11984 * fringe.c (update_window_fringes): Remove unused variables.
11985
c47cbdfd
YM
11986 * unexmacosx.c (copy_data_segment): Also copy __got section.
11987 (Bug#8223)
11988
7ac80be9
EZ
119892011-03-12 Eli Zaretskii <eliz@gnu.org>
11990
c96bbc66 11991 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11992 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11993 Constify `char *' arguments and their references according to
11994 prototypes in tparam.h.
11995
ecb0f94d 11996 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11997
7ac80be9
EZ
11998 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11999 Adapt all references accordingly.
12000
12001 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12002
ef1fd07e
TT
120032011-03-11 Tom Tromey <tromey@redhat.com>
12004
12005 * buffer.c (syms_of_buffer): Remove obsolete comment.
12006
7ef4b50c
EZ
120072011-03-11 Eli Zaretskii <eliz@gnu.org>
12008
12009 * termhooks.h (encode_terminal_code): Declare prototype.
12010
12011 * msdos.c (encode_terminal_code): Don't declare prototype.
12012
12013 * term.c (encode_terminal_code): Now external again, used by
12014 w32console.c and msdos.c.
12015
44f230aa
SM
12016 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12017 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12018
4b1ec863 120192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12020
1714f52b 12021 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12022
4b1ec863
PE
12023 * fringe.c (update_window_fringes): Mark locals as initialized
12024 (Bug#8227).
12025 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12026
524c7aa6
PE
12027 * alloc.c (mark_fringe_data): Move decl from here ...
12028 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12029 to check its interface.
12030 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12031
a5c0af81 12032 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12033 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12034 (fontset_font): Mark local as initialized.
a9a06e0b 12035 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12036
b4716021
PE
12037 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12038
811e9bac 12039 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12040 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12041 (x_own_selection, Fx_disown_selection_internal): Rename locals
12042 to avoid shadowing.
12043 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12044
7e3ab302
PE
12045 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12046 so that the caller can use some name other than gcpro1.
12047 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12048 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12049 (Fx_backspace_delete_keys_p):
12050 Use them to avoid shadowing, and rename vars to avoid shadowing.
12051 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12052 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12053 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12054 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12055 Remove unused locals.
7e3ab302
PE
12056 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12057 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12058 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12059 macros.
f78faa98 12060
e2b13473
PE
12061 * xterm.h (x_mouse_leave): New decl.
12062
77f23912
PE
12063 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12064 Remove unused functions.
cdf4ba58
PE
12065 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12066 (x_calc_absolute_position): Now static.
7411c686 12067 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12068 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12069 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12070 unless they are used.
38d0b34a
PE
12071 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12072 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12073 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12074 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12075 (x_error_catcher, x_connection_closed, x_error_handler):
12076 (x_error_quitter, xembed_send_message, x_iconify_frame):
12077 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12078 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12079 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12080
44f230aa
SM
12081 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12082 Rename or move locals to avoid shadowing.
6b463e58 12083 (tty_defined_color, merge_face_heights): Now static.
5967d051 12084 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12085 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12086 does not deduce is never used uninitialized.
73719eba
PE
12087 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12088 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12089
426994c3 12090 * terminal.c (store_terminal_param): Now static.
5489860b 12091
032f1620 12092 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12093 (set_frame_menubar): Remove unused local.
d4323972 12094 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12095 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12096 since they might point to immutable storage.
281585b0
PE
12097 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12098 since it's unused otherwise.
032f1620 12099
367c19e5 12100 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12101 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12102 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12103 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12104 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12105 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12106 does not deduce are never used uninitialized.
70739cbe 12107
07b48fa9
PE
12108 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12109
8868a238 12110 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12111 * window.c (window_loop, size_window):
12112 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12113
7e5cf297 12114 * window.c (display_buffer): Now static.
d6550a9f
PE
12115 (size_window): Mark variables that gcc -Wuninitialized
12116 does not deduce are never used uninitialized.
a586633d
PE
12117 * window.h (check_all_windows): New decl, to forestall
12118 gcc -Wmissing-prototypes diagnostic.
5b555da1 12119 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12120
f6095868
PE
12121 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12122 shadowing.
12123 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12124 Include <limits.h>.
12125 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12126 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12127 (load_charset_map): Mark variables that gcc -Wuninitialized
12128 does not deduce are never used uninitialized.
53df7c11 12129 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12130
f38b440c
PE
12131 * coding.c (coding_set_source, coding_set_destination):
12132 Use "else { /* comment */ }" rather than "else /* comment */;"
12133 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12134 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12135 a block, when the outer 'i' will do.
12136 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12137 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12138 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12139 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12140 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12141 Rename locals to avoid shadowing.
12142 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12143 * coding.c (emacs_mule_char, encode_invocation_designation):
12144 Now static, since they're not used elsewhere.
413bb2db 12145 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12146 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12147 (decode_coding_emacs_mule): Mark variables that gcc
12148 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12149 (detect_coding_iso_2022): Initialize a local variable that might
12150 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12151 this initialization is needed. (Bug#8211)
5f58e762
PE
12152 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12153 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12154 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12155 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12156 Remove unused macros.
f38b440c 12157
232b38b9 12158 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12159 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12160 * character.c (string_count_byte8): Likewise.
232b38b9 12161
fb90da1b
PE
12162 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12163 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12164
fb93dbc2
PE
12165 * chartab.c (copy_sub_char_table): Now static, since it's not used
12166 elsewhere.
5c156ace
PE
12167 (sub_char_table_ref_and_range, char_table_ref_and_range):
12168 Rename locals to avoid shadowing.
bbcd0949 12169 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12170
7d3b3862 12171 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12172 (BIDI_BOB): Remove unused macro.
7d3b3862 12173
6be7d3da
PE
12174 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12175 deduce are never used uninitialized.
c2ed9c8b 12176 * term.c (encode_terminal_code): Likewise.
6be7d3da 12177
75f8807f 12178 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12179
50938595
PE
12180 * tparam.h: New file.
12181 * term.c, tparam.h: Include it.
12182 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12183 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12184 Move these decls to tparam.h, and make them agree with what
12185 is actually in tparam.c. The previous trick of using incompatible
12186 decls in different modules does not conform to the C standard.
12187 All callers of tparam changed to use tparam's actual API.
12188 * tparam.c (tparam1, tparam, tgoto):
12189 Use const pointers where appropriate.
12190
fbceeba2
PE
12191 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12192 * cm.h (struct cm): Likewise.
12193 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12194 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12195 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12196 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12197 (turn_on_face, init_tty): Likewise.
12198 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12199
7f3f1250
PE
12200 * term.c (term_mouse_position): Rename local to avoid shadowing.
12201
e6ca6543
PE
12202 * alloc.c (mark_ttys): Move decl from here ...
12203 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12204
c40f8d15
AS
122052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12206
12207 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12208
cfe0661d
JB
122092011-03-09 Juanma Barranquero <lekktu@gmail.com>
12210
12211 * search.c (compile_pattern_1): Remove argument regp, unused since
12212 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12213 (compile_pattern): Don't pass it.
12214
0afb4571
J
122152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12216
12217 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12218 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12219 for ! HAVE_GTK3.
12220 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12221
12222 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12223
12224 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12225 gdk_window_get_screen, gdk_window_get_geometry,
12226 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12227 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12228 (xg_get_pixbuf_from_pixmap): New function.
12229 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12230 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12231 Call xg_get_pixbuf_from_pixmap instead of
12232 gdk_pixbuf_get_from_drawable.
12233 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12234 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12235 (xg_check_special_colors): Use GtkStyleContext and its functions
12236 for HAVE_GTK3.
12237 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12238 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12239 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12240 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12241 Call gtk_widget_get_preferred_size.
0afb4571
J
12242 (xg_frame_resized): gdk_window_get_geometry only takes 5
12243 parameters.
44f230aa
SM
12244 (xg_win_to_widget, xg_event_is_for_menubar):
12245 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12246 (xg_set_widget_bg): New function.
12247 (delete_cb): New function.
895009e1 12248 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12249 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12250 (xg_set_background_color): Call xg_set_widget_bg.
12251 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12252 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12253 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12254 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12255 if ! HAVE_GTK3.
12256 (update_frame_tool_bar): Call gtk_widget_hide.
12257 (xg_initialize): Use GDK_KEY_g.
12258
12259 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12260 if ! HAVE_GTK3
12261 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12262
12263 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12264 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12265 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12266
1c2cc4ef
JB
122672011-03-08 Juanma Barranquero <lekktu@gmail.com>
12268
12269 * w32xfns.c (select_palette): Check success of RealizePalette against
12270 GDI_ERROR, not zero.
12271
33383987 12272See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12273
12274;; Local Variables:
12275;; coding: utf-8
aac0c6e3
MR
12276;; End:
12277
2f097256 12278 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12279
12280 This file is part of GNU Emacs.
12281
12282 GNU Emacs is free software: you can redistribute it and/or modify
12283 it under the terms of the GNU General Public License as published by
12284 the Free Software Foundation, either version 3 of the License, or
12285 (at your option) any later version.
12286
12287 GNU Emacs is distributed in the hope that it will be useful,
12288 but WITHOUT ANY WARRANTY; without even the implied warranty of
12289 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12290 GNU General Public License for more details.
12291
12292 You should have received a copy of the GNU General Public License
12293 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.