Fix cursor motion near overlays covering reordered text.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c40e2fb2
EZ
12011-05-28 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Set start and stop points of the
4 loop that looks for the glyph on which to display cursor according
5 to the row's direction.
6
fc6f18ce
EZ
72011-05-21 Eli Zaretskii <eliz@gnu.org>
8
9 * xdisp.c (handle_display_spec): New function, refactored from the
10 last portion of handle_display_prop.
11 (compute_display_string_pos): Accept additional argument
12 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
13 value of a `display' property is a "replacing spec".
14 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
15 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
16 the display property, but just return a value indicating whether
17 the display property will replace the characters it covers.
18 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
19 frame_window_p members of struct bidi_it.
20
21 * bidi.c (bidi_fetch_char): Accept additional argument
22 FRAME_WINDOW_P and pass it to compute_display_string_pos. All
23 callers changed.
24 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
25 it to initialize the frame_window_p member of struct bidi_it.
26
27 * dispextern.h (struct bidi_it): New member frame_window_p.
28 (bidi_init_it, compute_display_string_pos): Update prototypes.
29
102ebb00
EZ
302011-05-14 Eli Zaretskii <eliz@gnu.org>
31
7b600102
EZ
32 * xdisp.c (compute_display_string_pos): Non-trivial implementation.
33 (compute_display_string_end): New function.
683a44f7
EZ
34 (push_it): Accept second argument POSITION, where pop_it should
35 jump to continue iteration.
7b600102
EZ
36
37 * dispextern.h (compute_display_string_end): Declare prototype.
38
39 * bidi.c (bidi_resolve_explicit_1): Use ZV for disp_pos.
40 (bidi_fetch_char): Implement support for runs of characters
41 covered by display strings.
42
102ebb00 43 * bidi.c (bidi_fetch_char): Accept also character position
7b600102
EZ
44 corresponding to BYTEPOS. DISP_POS is now a character position,
45 not a byte position. All callers changed.
102ebb00
EZ
46 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
47 (bidi_resolve_explicit, bidi_resolve_weak)
48 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
49 bidi_it->nchars is non-positive.
50 (bidi_level_of_next_char): Don't try to lookup the cache for the
51 next/previous character if nothing is cached there yet, or if we
52 were just reseat()'ed to a new position.
53 (bidi_paragraph_init, bidi_resolve_explicit_1)
54 (bidi_level_of_next_char): Fix arguments in the calls to
55 bidi_fetch_char.
56
182ce2d2
EZ
572011-05-10 Eli Zaretskii <eliz@gnu.org>
58
59 * xdisp.c (compute_display_string_pos): New function.
60 (reseat_1): Initialize bidi_it.disp_pos.
61
62 * bidi.c (bidi_copy_it): Use offsetof.
63 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
64 (bidi_cache_search, bidi_cache_iterator_state)
65 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
66 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
67 character positions inside a run of characters covered by a
68 display string.
69 (bidi_paragraph_init, bidi_resolve_explicit_1)
70 (bidi_level_of_next_char): Call bidi_fetch_char and
71 bidi_fetch_char_advance instead of FETCH_CHAR and
72 FETCH_CHAR_ADVANCE.
73 (bidi_init_it): Initialize new members.
74 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
75 definitions.
76 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
77 instead of using explicit *_CHAR codes.
78 (bidi_resolve_explicit, bidi_resolve_weak): Use
79 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
80 bidirectional text is supported only in multibyte buffers.
81
82 * dispextern.h (struct bidi_it): New members nchars and disp_pos.
83 ch_len is now EMACS_INT.
84 (compute_display_string_pos): Declare prototype.
85
57679c86
AS
862011-05-09 Andreas Schwab <schwab@linux-m68k.org>
87
88 * w32menu.c (set_frame_menubar): Fix submenu allocation.
89
888c9e86
EZ
902011-05-07 Eli Zaretskii <eliz@gnu.org>
91
b0512a1d
EZ
92 * w32console.c (Fset_screen_color): Doc fix.
93 (Fget_screen_color): New function.
94 (syms_of_ntterm): Defsubr it.
95
888c9e86
EZ
96 * callproc.c (call_process_cleanup): Don't close and unlink the
97 temporary file if Fcall_process didn't create it in the first
98 place.
99 (Fcall_process): Don't create tempfile if stdout of the child
100 process will be redirected to a file specified with `:file'.
101 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
102 cue to call_process_cleanup not to close that handle.
103
4d3fcc8e
BK
1042011-05-07 Ben Key <bkey76@gmail.com>
105
106 * makefile.w32-in: The bootstrap-temacs rule now makes use of
107 one of two shell specific rules, either bootstrap-temacs-CMD or
108 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
109 to the previous implementation of the bootstrap-temacs rule.
110 The bootstrap-temacs-CMD rule is similar to the previous
111 implementation of the bootstrap-temacs rule except that it
112 makes use of the ESC_CFLAGS variable instead of the CFLAGS
113 variable.
114
115 These changes, along with some changes to nt/configure.bat,
116 nt/gmake.defs, and nt/nmake.defs, are required to extend my
117 earlier fix to add support for --cflags and --ldflags options
118 that include quotes so that it works whether make uses cmd or
119 sh as the shell.
120
b4289b64
MA
1212011-05-06 Michael Albinus <michael.albinus@gmx.de>
122
123 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
124 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
125 is a constant.
126 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
127 a string. Handle both cases.
128 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
129 (Fdbus_register_method): Use Qinvalid_function.
130
af4c0e28
JB
1312011-05-06 Juanma Barranquero <lekktu@gmail.com>
132
133 * makefile.w32-in: Update dependencies.
134 (LISP_H): Add inttypes.h and stdin.h.
135 (PROCESS_H): Add unistd.h.
136
c51453d9
EZ
1372011-05-06 Eli Zaretskii <eliz@gnu.org>
138
139 * lread.c: Include limits.h (fixes the MS-Windows build broken by
140 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
141
8ff0ac3c 1422011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 143
4c4b566b
PE
144 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
145
aab2b9b5
PE
146 * term.c (vfatal): Remove stray call to va_end.
147 It's not needed and the C Standard doesn't allow it here anyway.
148
c378da0b
PE
149 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
150 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
151
288b08c7
PE
152 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
153 bytes.
154
e3601888
PE
155 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
156
db6c0e74
PE
157 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
158
dd5963ea
PE
159 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
160
88c9450f
PE
161 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
162
2f9442b8
PE
163 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
164
c032b5f8
PE
165 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
166 * charset.c (Fdefine_charset_internal): Don't initialize
167 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 168 32-bit int (Bug#8600).
a108c10b
PE
169
170 * lread.c (read_integer): Be more consistent with string-to-number.
171 Use string_to_number to do the actual conversion; this avoids
172 rounding errors and fixes some other screwups. Without this fix,
173 for example, #x1fffffffffffffff was misread as -2305843009213693952.
174 (digit_to_number): Move earlier, for benefit of read_integer.
175 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 176 not a digit in any supported base. (Bug#8602)
a108c10b 177
ad5f9eea
PE
178 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
179
aec1708a
PE
180 * dispnew.c (scrolling_window): Return 1 if we scrolled,
181 to match comment at start of function. This also removes a
182 GCC warning about overflow in a 32+64-bit port.
183
47be4ab5
PE
184 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
185
371cac43
PE
186 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
187 Reported by Stefan Monnier in
188 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
189 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
190 SYMBOLP-guarded XSYMBOL, not XPNTR.
191
d01a7826
PE
192 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
193 (EMACS_UINTPTR): Likewise, with uintptr_t.
194
7fd47d5c
PE
195 * lisp.h: Prefer 64-bit EMACS_INT if available.
196 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
197 on 32-bit hosts that have 64-bit int, so that they can access
198 large files.
122b0c86
PE
199 However, temporarily disable this change unless the temporary
200 symbol WIDE_EMACS_INT is defined.
7fd47d5c 201
8727937b
PE
202 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
203
8ac068ac
PE
204 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
205 This removes an assumption that EMACS_INT and long are the same
206 width as pointers. The assumption is true for Emacs porting targets
207 now, but we want to make other targets possible.
208 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
209 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
210 In the rest of the code, change types of integers that hold casted
211 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
212 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
213 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
214 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
215 No need to cast type when ORing.
216 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
217 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
218 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
219 assume EMACS_INT is the same width as char *.
220 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
221 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
222 Remove no-longer-needed casts.
223 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
224 (xg_tool_bar_help_callback, xg_make_tool_item):
225 Use EMACS_INTPTR to hold an integer
226 that will be cast to void *; this can avoid a GCC warning
227 if EMACS_INT is not the same width as void *.
228 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
229 * xdisp.c (display_echo_area_1, resize_mini_window_1):
230 (current_message_1, set_message_1):
231 Use a local to convert to proper width without a cast.
232 * xmenu.c (dialog_selection_callback): Likewise.
233
ede49d71
PE
234 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
235 Also, don't assume VALBITS / RAND_BITS is less than 5,
236 and don't rely on undefined behavior when shifting a 1 left into
237 the sign bit.
238 * lisp.h (get_random): Change signature to match.
239
2f30ecd0
PE
240 * lread.c (hash_string): Use size_t, not int, for hash computation.
241 Normally we prefer signed values; but hashing is special, because
242 it's better to use unsigned division on hash table sizes so that
243 the remainder is nonnegative. Also, size_t is the natural width
244 for hashing into memory. The previous code used 'int', which doesn't
245 retain enough info to hash well into very large tables.
246 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
247
2a866e7b
PE
248 * dbusbind.c: Don't possibly lose pointer info when converting.
249 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
250 Use XPNTR rather than XHASH, so that the high-order bits of
251 the pointer aren't lost when converting through void *.
252
51639eac
PE
253 * eval.c (Fautoload): Don't double-shift a pointer.
254
92394119
PE
255 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
256
dbdb9a7c
JB
2572011-05-06 Juanma Barranquero <lekktu@gmail.com>
258
259 * gnutls.c (DEF_GNUTLS_FN):
260 * image.c (DEF_IMGLIB_FN): Make function pointers static.
261
db7a0b4f
AS
2622011-05-05 Andreas Schwab <schwab@linux-m68k.org>
263
264 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
265 marker. (Bug#8610)
266
f7ff1b0f 2672011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
268
269 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
270 New version that can reserve upto 2GB of heap space.
271
f7ff1b0f 2722011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
273
274 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
275
639c109b
TZ
2762011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
277
278 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
279 `gnutls_certificate_set_x509_key_file'.
280
d2127135
JB
2812011-05-05 Juanma Barranquero <lekktu@gmail.com>
282
283 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
284 Update dependencies.
285
e968f4f3
JB
2862011-05-04 Juanma Barranquero <lekktu@gmail.com>
287
288 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
289 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
290 Remove unused parameter `fildes'.
291 * process.c (read_process_output, send_process): Don't pass it.
292
84d358f0
JB
2932011-05-04 Juanma Barranquero <lekktu@gmail.com>
294
295 Fix previous change: the library cache is defined in w32.c.
296 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
297 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
298
0898ca10
JB
2992011-05-04 Juanma Barranquero <lekktu@gmail.com>
300
301 Implement dynamic loading of GnuTLS on Windows.
302
303 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
304 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
305 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
306 Declare.
307
308 * gnutls.c (Qgnutls_dll): Define.
309 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
310 (gnutls_*): Declare function pointers.
311 (init_gnutls_functions): New function to initialize function pointers.
312 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
313 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
314 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
315 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
316 (emacs_gnutls_write, emacs_gnutls_read)
317 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
318 (Fgnutls_available_p): New function.
319 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
320 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
321 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
322
323 * image.c: Include w32.h.
324 (Vimage_type_cache): Delete.
325 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
326 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
327 (w32_delayed_load): Move to w32.c.
328
329 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
330
331 * w32.c (QCloaded_from, Vlibrary_cache): Define.
332 (w32_delayed_load): Move from image.c. When loading a library, record
333 its filename in the :loaded-from property of the library id.
334 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
335 Initialize and staticpro them.
336 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
337
338 * process.c: Include lisp.h before w32.h, not after.
339 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
340 instead of gnutls_record_check_pending.
341
342 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
343
ff4de4aa
TZ
3442011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
345
346 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
347 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
348 as passed in.
349
abe95abb
JD
3502011-05-03 Jan Djärv <jan.h.d@swipnet.se>
351
352 * xterm.c (x_set_frame_alpha): Do not set property on anything
353 else than FRAME_X_OUTER_WINDOW (Bug#8608).
354
e16e55d4
JB
3552011-05-02 Juanma Barranquero <lekktu@gmail.com>
356
357 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
358
bafcf6a5
JB
3592011-05-02 Juanma Barranquero <lekktu@gmail.com>
360
361 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
362 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
363 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
364 (gnutls_global_initialized, Qgnutls_bootprop_priority)
365 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
366 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
367 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
368 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
369 (Qgnutls_bootprop_callbacks_verify): Make static.
370
e7a6747f
AS
3712011-05-01 Andreas Schwab <schwab@linux-m68k.org>
372
19ed11ba
AS
373 * callproc.c: Indentation fixup.
374
e7a6747f
AS
375 * sysdep.c (wait_for_termination_1): Make static.
376 (wait_for_termination, interruptible_wait_for_termination): Move
377 after wait_for_termination_1.
378
1ef14cb4
LMI
3792011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
380
381 * sysdep.c (interruptible_wait_for_termination): New function
382 which is like wait_for_termination, but allows keyboard
383 interruptions.
384
385 * callproc.c (Fcall_process): Add (:file "file") as an option for
386 the STDOUT buffer.
387 (Fcall_process_region): Ditto.
388
330d880c
EZ
3892011-04-30 Eli Zaretskii <eliz@gnu.org>
390
8db90b73
EZ
391 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
392 rather than `XVECTOR (FOO)->size'.
393
330d880c
EZ
394 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
395 inttypes.h, as a gnulib replacement is used if it not available in
396 system headers.
397
15cbd324
EZ
3982011-04-21 Eli Zaretskii <eliz@gnu.org>
399
400 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
401 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
402 of MOST_POSITIVE_FIXNUM. (Bug#8528)
403
404 * coding.c (coding_alloc_by_realloc): Error out if destination
405 will grow beyond MOST_POSITIVE_FIXNUM.
406 (decode_coding_emacs_mule): Abort if there isn't enough place in
407 charbuf for the composition carryover bytes. Reserve an extra
408 space for up to 2 characters produced in a loop.
409 (decode_coding_iso_2022): Abort if there isn't enough place in
410 charbuf for the composition carryover bytes.
411
4122011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 413
ae940cca
EZ
414 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
415 aborting when %lld or %lll format is passed.
416 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
417 %llo or %llx format is passed. (Bug#8545)
418
03ab8921
EZ
419 * window.c (window_scroll_line_based): Use a marker instead of
420 simple variables to record original value of point. (Bug#7952)
421
afda1437
EZ
422 * doprnt.c (doprnt): Fix the case where a multibyte sequence
423 produced by %s or %c overflows available buffer space. (Bug#8545)
424
f76dee0c
PE
4252011-04-28 Paul Eggert <eggert@cs.ucla.edu>
426
427 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 428 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 429
fdc5744d
JB
4302011-04-28 Juanma Barranquero <lekktu@gmail.com>
431
432 * w32.c (init_environment): Warn about defaulting HOME to C:\.
433
638f053a
JB
4342011-04-28 Juanma Barranquero <lekktu@gmail.com>
435
436 * keyboard.c (Qdelayed_warnings_hook): Define.
437 (command_loop_1): Run `delayed-warnings-hook'
438 if Vdelayed_warnings_list is non-nil.
439 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
440 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
441
d178f871
EZ
4422011-04-28 Eli Zaretskii <eliz@gnu.org>
443
444 * doprnt.c (doprnt): Don't return value smaller than the buffer
445 size if the message was truncated. (Bug#8545).
446
b124fd93
JB
4472011-04-28 Juanma Barranquero <lekktu@gmail.com>
448
449 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
450 (Fx_window_property): #if-0 the whole functions, not just the bodies.
451
e810457d
PE
4522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
453
454 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
455
ea51cceb
JB
4562011-04-27 Juanma Barranquero <lekktu@gmail.com>
457
458 * makefile.w32-in: Update dependencies.
459
94dcfacf
EZ
4602011-04-27 Eli Zaretskii <eliz@gnu.org>
461
462 Improve `doprnt' and its usage. (Bug#8545)
463 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
464 `format_end'. Remove support for %l as a conversion specifier.
465 Don't use xrealloc. Improve diagnostics when the %l size modifier
466 is used. Update the commentary.
467
468 * eval.c (verror): Simplify calculation of size_t.
469
470 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
471 messages.
472
f61f41d7
PE
4732011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
474
475 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
476 change.
477
96fb4434
PE
4782011-04-27 Paul Eggert <eggert@cs.ucla.edu>
479
480 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
481 This makes this file independent of the recent pseudovector change.
482
671875da 4832011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 484
69e9b5a3
PE
485 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
486
b5f869a7 487 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 488 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 489 Remove unused local.
c8926152 490 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 491
841a1577 492 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
493 GCC 4.6.0 optimizes based on type-based alias analysis. For
494 example, if b is of type struct buffer * and v of type struct
495 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
496 != &v->size, and therefore "v->size = 1; b->size = 2; return
497 v->size;" must therefore return 1. This assumption is incorrect
498 for Emacs, since it type-puns struct Lisp_Vector * with many other
499 types. To fix this problem, this patch adds a new type struct
f904488f 500 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
501 and pseudovectors, and helps optimizing compilers not get fooled
502 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
503 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
504 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
505 the size member.
eab3844f
PE
506 (XSETPVECTYPE): Rewrite in terms of new macro.
507 (XSETPVECTYPESIZE): New macro, specifying both type and size.
508 This is a bit clearer, and further avoids the possibility of
509 undesirable aliasing.
510 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 511 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
512 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
513 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
514 (ASIZE): Now uses header.size rather than size. All
515 previous uses of XVECTOR (foo)->size replaced to use this macro,
516 to avoid the hassle of writing XVECTOR (foo)->header.size.
517 (struct vectorlike_header): New type.
eab3844f
PE
518 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
519 object, to help avoid aliasing.
520 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
521 (SUBRP): Likewise, since Lisp_Subr is a special case.
522 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
523 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
524 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 525 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
526 changed to be "header.size" and "header.next".
527 * buffer.h (struct buffer): Likewise.
528 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
529 * frame.h (struct frame): Likewise.
530 * process.h (struct Lisp_Process): Likewise.
531 * termhooks.h (struct terminal): Likewise.
532 * window.c (struct save_window_data, struct saved_window): Likewise.
533 * window.h (struct window): Likewise.
534 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
535 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
536 * buffer.c (init_buffer_once): Likewise.
537 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
538 special case.
539 * process.c (Fformat_network_address): Use local var for size,
540 for brevity.
541
0df1eac5
PE
542 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
543
847ab9d1 544 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
545 * data.c (atof): Remove decl; no longer used or needed.
546 (digit_to_number): Move to lread.c.
547 (Fstring_to_number): Use new string_to_number function, to be
548 consistent with how the Lisp reader treats infinities and NaNs.
549 Do not assume that floating-point numbers represent EMACS_INT
550 without losing information; this is not true on most 64-bit hosts.
551 Avoid double-rounding errors, by insisting on integers when
552 parsing non-base-10 numbers, as the documentation specifies.
553 * lisp.h (string_to_number): New decl, replacing ...
554 (isfloat_string): Remove.
bc0a5c13 555 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 556 (read1): Do not accept +. and -. as integers; this
452f4150
PE
557 appears to have been a coding error. Similarly, do not accept
558 strings like +-1e0 as floating point numbers. Do not report
559 overflow for integer overflows unless the base is not 10 which
560 means we have no simple and reliable way to continue.
561 Break out the floating-point parsing into a new
562 function string_to_number, so that Fstring_to_number parses
563 floating point numbers consistently with the Lisp reader.
564 (digit_to_number): Moved here from data.c. Make it static inline.
565 (E_CHAR, EXP_INT): Remove, replacing with ...
566 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
567 (string_to_number): New function, replacing isfloat_string.
568 This function checks for valid syntax and produces the resulting
569 Lisp float number too. Rework it so that string-to-number
bc0a5c13 570 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
571 so that overflow for non-base-10 numbers is reported only when
572 there's no portable and simple way to convert to floating point.
452f4150 573
67769ffc
PE
574 * textprop.c (set_text_properties_1): Rewrite for clarity,
575 and to avoid GCC warning about integer overflow.
576
c20db43f
PE
577 * intervals.h (struct interval): Use EMACS_INT for members
578 where EMACS_UINT might cause problems. See
579 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
580 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
581 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
582 All uses changed.
37aa2f85
PE
583 (offset_intervals): Tell GCC not to worry about length overflow
584 when negating a negative length.
c20db43f 585
2538aa2f
PE
586 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
587 (overrun_check_free): Likewise.
588
f2d3008d
PE
589 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
590 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
591 word size.
592
ec8df744
PE
593 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
594 (gnutls_make_error): Rename local to avoid shadowing.
595 (gnutls_emacs_global_deinit): ifdef out; not used.
596 (Fgnutls_boot): Use const for pointer to readonly storage.
597 Comment out unused local. Fix pointer signedness problems.
598
640ee02d
PE
599 * lread.c (openp): Don't stuff size_t into an 'int'.
600 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
601 about possible signed overflow.
602
6048fb2a
PE
603 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
604 (GDK_KEY_g): Don't define if already defined.
605 (xg_prepare_tooltip): Avoid pointer signedness problem.
606 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
607
fa3c87e1
PE
608 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
609 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
610
2172544b
PE
611 * xfns.c (Fx_window_property): Simplify a bit,
612 to make a bit faster and to avoid GCC 4.6.0 warning.
613 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
614
9b821a21
PE
615 * fns.c (internal_equal): Don't assume size_t fits in int.
616
3c616cfa
PE
617 * alloc.c (compact_small_strings): Tighten assertion a little.
618
c2982e87
PE
619 Replace pEd with more-general pI, and fix some printf arg casts.
620 * lisp.h (pI): New macro, generalizing old pEd macro to other
621 conversion specifiers. For example, use "...%"pI"d..." rather
622 than "...%"pEd"...".
623 (pEd): Remove. All uses replaced with similar uses of pI.
624 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
625 * alloc.c (check_pure_size): Don't overflow by converting size to int.
626 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
627 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
628 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
629 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
630 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
631 64-bit hosts.
632 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
633 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
634 * print.c (safe_debug_print, print_object): Likewise.
635 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
636 to int.
6f04d126
PE
637 Use pI instead of if-then-else-abort. Use %p to avoid casts,
638 avoiding the 0 flag, which is not portable.
c2982e87
PE
639 * process.c (Fmake_network_process): Use pI to avoid cast.
640 * region-cache.c (pp_cache): Likewise.
641 * xdisp.c (decode_mode_spec): Likewise.
642 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
643 behavior on 64-bit hosts with printf arg.
6f04d126 644 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
645 (x_stop_queuing_selection_requests): Likewise.
646 (x_get_window_property): Don't truncate byte count to an 'int'
647 when tracing.
0b432f21 648
5e073ec7
PE
649 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
650 here, since it parses constructs like leading '-' and spaces,
651 which are not wanted; and it overflows with large numbers.
652 Instead, simply match F[0-9]+, which is what is wanted anyway.
653
36372bf9
PE
654 * alloc.c: Remove unportable assumptions about struct layout.
655 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
656 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
657 (allocate_vectorlike, make_pure_vector): Use the new macros,
658 plus offsetof, to remove unportable assumptions about struct layout.
659 These assumptions hold on all porting targets that I know of, but
660 they are not guaranteed, they're easy to remove, and removing them
661 makes further changes easier.
662
0b432f21
PE
663 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
664 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
665 (string_overrun_cookie): Now const. Use initializers that
666 don't formally overflow signed char, to avoid warnings.
000098c1
PE
667 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
668 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
669 (allocate_buffer): Don't assume sizeof (struct buffer) is a
670 multiple of sizeof (EMACS_INT); it need not be, if
671 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 672 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 673
895009e1
JB
6742011-04-26 Juanma Barranquero <lekktu@gmail.com>
675
676 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
677
6a7a1b0b
TZ
6782011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
679
680 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 681 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
682 Reported by Paul Eggert <eggert@cs.ucla.edu>.
683
841a1577 6842011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
685
686 * lisp.h (Qdebug): List symbol.
895009e1 687 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
688 * keyboard.c (debug-on-event): New variable.
689 (handle_user_signal): Break into debugger when debug-on-event
690 matches the current signal symbol.
691
f2d3ba6f
DN
6922011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
693
694 * alloc.c (check_sblock, check_string_bytes)
695 (check_string_free_list): Convert to standard C.
696
42ce4c63
TZ
6972011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
698
699 * w32.c (emacs_gnutls_push): Fix typo.
700
825cd63c
EZ
7012011-04-25 Eli Zaretskii <eliz@gnu.org>
702
fb11d64d
EZ
703 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
704 "cast to pointer from integer of different size".
705
825cd63c
EZ
706 Improve doprnt and its use in verror. (Bug#8545)
707 * doprnt.c (doprnt): Document the set of format control sequences
708 supported by the function. Use SAFE_ALLOCA instead of always
709 using `alloca'.
710
711 * eval.c (verror): Don't limit the buffer size at size_max-1, that
712 is one byte too soon. Don't use xrealloc; instead xfree and
713 xmalloc anew.
714
e061a11b
TZ
7152011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
716
717 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
718 callbacks stage.
719
720 * gnutls.c: Renamed global_initialized to
721 gnutls_global_initialized. Added internals for the
722 :verify-hostname-error, :verify-error, and :verify-flags
723 parameters of `gnutls-boot' and documented those parameters in the
724 docstring. Start callback support.
725 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
726 unless a fatal error occured. Call gnutls_alert_send_appropriate
727 on error. Return error code.
728 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
729 (emacs_gnutls_read): Likewise.
730 (Fgnutls_boot): Return handshake error code.
731 (emacs_gnutls_handle_error): New function.
732 (wsaerror_to_errno): Likewise.
733
734 * w32.h (emacs_gnutls_pull): Add prototype.
735 (emacs_gnutls_push): Likewise.
736
737 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
738 (emacs_gnutls_push): Likewise.
739
7402011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
741
742 * process.c (wait_reading_process_output): Check if GnuTLS
743 buffered some data internally if no FDs are set for TLS
744 connections.
745
746 * makefile.w32-in (OBJ2): Add gnutls.$(O).
747 (LIBS): Link to USER_LIBS.
748 ($(BLD)/gnutls.$(0)): New target.
749
fa6996bc
EZ
7502011-04-24 Eli Zaretskii <eliz@gnu.org>
751
eb35682e
EZ
752 * xdisp.c (handle_single_display_spec): Rename the
753 display_replaced_before_p argument into display_replaced_p, to
754 make it consistent with the commentary. Fix typos in the
755 commentary.
756
e2ad650c
EZ
757 * textprop.c (syms_of_textprop): Remove dead code.
758 (copy_text_properties): Delete obsolete commentary about an
759 interface that was deleted long ago. Fix typos in the description
760 of arguments.
761
1b2de274
EZ
762 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
763 to changes in oldXMenu/XMenu.h from 2011-04-16.
764 <menu_help_message, prev_menu_help_message>: Constify.
765 (IT_menu_make_room): menu->help_text is now `const char **';
766 adjust.
767
768 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
769 to changes in oldXMenu/XMenu.h from 2011-04-16.
770 (struct XMenu): Declare `help_text' `const char **'.
771
772 * xfaces.c <Qunspecified>: Make extern again.
773
774 * syntax.c: Include sys/types.h before including regex.h, as
775 required by Posix.
776
762b15be
EZ
777 * doc.c (get_doc_string): Improve the format passed to `error'.
778
779 * doprnt.c (doprnt): Improve commentary.
780
781 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
782
783 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
784 them with etags.
785
f1052e5d
EZ
786 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
787 changes in globals.h immediately force recompilation.
762b15be
EZ
788 (TAGS): Depend on $(CURDIR)/m/intel386.h and
789 $(CURDIR)/s/ms-w32.h.
790 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 791
fa6996bc
EZ
792 * character.c (Fchar_direction): Function deleted.
793 (syms_of_character): Don't defsubr it.
794 <char-direction-table>: Deleted.
795
e6c3da20
EZ
7962011-04-23 Eli Zaretskii <eliz@gnu.org>
797
798 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
799 * doprnt.c: Include limits.h.
800 (SIZE_MAX): New macro.
801 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
802 local variables are now size_t instead of int or unsigned.
803 Improve overflow protection. Support `l' modifier for integer
804 conversions. Support %l conversion. Don't assume an EMACS_INT
805 argument for integer conversions and for %c.
806
807 * lisp.h (doprnt): Restore prototype.
808
809 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
810 $(SRC)/character.h.
811
812 * Makefile.in (base_obj): Add back doprnt.o.
813
814 * deps.mk (doprnt.o): Add back prerequisites.
815 (callint.o): Depend on character.h.
816
817 * eval.c (internal_lisp_condition_case): Include the handler
818 representation in the error message.
819 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
820 when breaking from the loop.
821
822 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
823
824 * callint.c (Fcall_interactively): When displaying error message
825 about invalid control letter, pass the character's codepoint, not
826 a pointer to its multibyte form. Improve display of the character
827 in octal and display also its hex code.
828
829 * character.c (char_string): Use %x to display the (unsigned)
830 codepoint of an invalid character, to avoid displaying a bogus
831 negative value.
832
833 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
834 `error', not SYMBOL_NAME itself.
835
836 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
837 character arguments to `error'.
838
839 * charset.c (check_iso_charset_parameter): Fix incorrect argument
840 to `error' in error message about FINAL_CHAR argument. Make sure
841 FINAL_CHAR is a character, and use %c when it is passed as
842 argument to `error'.
843
4ffd0d6b 8442011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
845
846 * s/ms-w32.h (localtime): Redirect to sys_localtime.
847
848 * w32.c: Include <time.h>.
849 (sys_localtime): New function.
850
4ffd0d6b 8512011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
852
853 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
854
4ffd0d6b 855 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 856
4ffd0d6b 8572011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 858
4ffd0d6b
GM
859 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
860 zombies (Bug#8467).
aac0c6e3 861
04c56954
EZ
8622011-04-19 Eli Zaretskii <eliz@gnu.org>
863
864 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
865 gl_state.e_property when gl_state.object is Qt.
866
867 * insdel.c (make_gap_larger): Remove limitation of buffer size
868 to <= INT_MAX.
869
16a43933
CY
8702011-04-18 Chong Yidong <cyd@stupidchicken.com>
871
872 * xdisp.c (lookup_glyphless_char_display)
873 (produce_glyphless_glyph): Handle cons cell entry in
874 glyphless-char-display.
875 (Vglyphless_char_display): Document it.
876
877 * term.c (produce_glyphless_glyph): Handle cons cell entry in
878 glyphless-char-display.
879
4581706e
CY
8802011-04-17 Chong Yidong <cyd@stupidchicken.com>
881
882 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
883
884 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
885
886 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
887 definition for no-X builds.
888
4887c6e2 8892011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 890
fd35b6f9
PE
891 Static checks with GCC 4.6.0 and non-default toolkits.
892
5c1ccb01
PE
893 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
894
006c5daa
PE
895 * process.c (keyboard_bit_set): Define only if SIGIO.
896 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
897 (send_process): Repair possible setjmp clobbering.
898
efc736d3
PE
899 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
900
4e2fe2e6
PE
901 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
902
f97334a2
PE
903 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
904
4e75f29d
PE
905 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
906 Define only if needed.
907
90efadd1
PE
908 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
909 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 910 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 911
3c647824
PE
912 * dispextern.h (struct redisplay_interface): Rename param
913 to avoid shadowing.
e264f262 914 * termhooks.h (struct terminal): Likewise.
761383f4 915 * xterm.c (xembed_send_message): Likewise.
3c647824 916
b58c5c4a
PE
917 * insdel.c (make_gap_smaller): Define only if
918 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
919
cad59032
PE
920 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
921 it.
922
c339dc2e
PE
923 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
924 so that we aren't warned about unused symbols.
925
91a3e27b
PE
926 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
927
399c71d3 928 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 929
8ffc96f5
PE
930 * xfns.c (x_real_positions): Mark locals as initialized.
931
eef9bc79
PE
932 * xmenu.c (xmenu_show): Don't use uninitialized vars.
933
098db9dd
PE
934 * xterm.c: Fix problems found by static analysis with other toolkits.
935 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
936 (x_dispatch_event): Declare static if USE_GTK, and
937 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 938 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 939 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
940 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
941 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 942
eb18f6cc
PE
943 * xmenu.c (menu_help_callback): Pointer type fixes.
944 Use const pointers when pointing at readonly data. Avoid pointer
945 signedness clashes.
946 (FALSE): Remove unused macro.
947 (update_frame_menubar): Remove unused decl.
948
1fe72bf8
PE
949 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
950
60d9e1db
PE
951 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
952 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
953 (single_menu_item): Rename local to avoid shadowing.
954
39261c26
PE
955 * keyboard.c (make_lispy_event): Remove unused local var.
956
018c5e19
PE
957 * frame.c, frame.h (x_get_resource_string): Bring this back, but
958 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
959
63d2b86e
PE
960 * bitmaps: Change bitmaps from unsigned char back to the X11
961 compatible char. Avoid the old compiler warnings about
962 out-of-range initializers by using, for example, '\xab' rather
963 than 0xab.
964
aefd87e1
PE
965 * xgselect.c (xgselect_initialize): Check vs interface
966 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
967
bf501fb9
PE
968 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
969
e9829fdf
PE
970 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
971 to read-only memory.
972
1086c095
PE
973 * fns.c (vector): Remove; this old hack is no longer needed.
974
2baccd04 975 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 976 Remove unused var.
dde42981 977 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 978
72391843 979 * xrdb.c (x_load_resources): Omit unused local.
3565b346 980
436c16df 981 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 982 (x_window): Rename locals to avoid shadowing.
dc5ddd85 983 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 984
92bb796d 985 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 986 (x_term_init): Remove local to avoid shadowing.
92bb796d 987
764430a3 988 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
989
990 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
991 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
992
d1dfb56c
EZ
9932011-04-16 Eli Zaretskii <eliz@gnu.org>
994
c4354cb4
EZ
995 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
996
d1dfb56c
EZ
997 Fix regex.c, syntax.c and friends for buffers > 2GB.
998 * syntax.h (struct gl_state_s): Declare character position members
999 EMACS_INT.
1000
1001 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1002
1003 * textprop.c (verify_interval_modification, interval_of): Declare
1004 arguments EMACS_INT.
1005
1006 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1007 EMACS_INT.
1008
1009 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1010
1011 * indent.c (Fvertical_motion): Local variable it_start is now
1012 EMACS_INT.
1013
1014 * regex.c (re_match, re_match_2, re_match_2_internal)
1015 (bcmp_translate, regcomp, regexec, print_double_string)
1016 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1017 (re_compile_pattern, re_exec): Declare arguments and local
1018 variables `size_t' and `ssize_t' and return values `regoff_t', as
1019 appropriate.
1020 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1021 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1022 <compile_stack_type>: `size' and `avail' are now `size_t'.
1023
1024 * regex.h <regoff_t>: Use ssize_t, not int.
1025 (re_search, re_search_2, re_match, re_match_2): Arguments that
1026 specify buffer/string position and length are now ssize_t and
1027 size_t. Return type is regoff_t.
1028
613052cd
BK
10292011-04-16 Ben Key <bkey76@gmail.com>
1030
1031 * nsfont.m: Fixed bugs in ns_get_family and
1032 ns_descriptor_to_entity that were caused by using free to
1033 deallocate memory blocks that were allocated by xmalloc (via
1034 xstrdup). This caused Emacs to crash when compiled with
1035 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1036 --enable-checking=xmallocoverrun). xfree is now used to
1037 deallocate these memory blocks.
1038
4170f62f 10392011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1040
71b41406
PE
1041 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1042
9587a89d
PE
1043 emacs_write: Accept and return EMACS_INT for sizes.
1044 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1045 et seq.
1046 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1047 Accept and return EMACS_INT.
1048 (emacs_gnutls_write): Return the number of bytes written on
1049 partial writes.
1050 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1051 (emacs_read, emacs_write): Remove check for negative size, as the
1052 Emacs source code has been audited now.
9587a89d
PE
1053 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1054 (emacs_read, emacs_write): Use it.
273a5f82
PE
1055 * process.c (send_process): Adjust to the new signatures of
1056 emacs_write and emacs_gnutls_write. Do not attempt to store
1057 a byte offset into an 'int'; it might overflow.
9587a89d 1058 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1059
3e047f51
PE
1060 * sound.c: Don't assume sizes fit in 'int'.
1061 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1062 Return EMACS_INT, not int.
3e047f51 1063 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1064 Accept EMACS_INT, not int.
1065 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1066 record read return values.
1067
cc39a9db
BK
10682011-04-15 Ben Key <bkey76@gmail.com>
1069
c9d0ec6d
JB
1070 * keyboard.c (Qundefined): Don't declare static since it is used
1071 in nsfns.m.
1072 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1073 static since they are used in nsfont.m.
cc39a9db 1074
6c60eb9f
SM
10752011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1076
1077 * process.c (Qprocessp): Don't declare static.
1078 * lisp.h (Qprocessp): Declare again.
1079
7990b61a
JB
10802011-04-15 Juanma Barranquero <lekktu@gmail.com>
1081
1082 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1083
5d4cb038
PE
10842011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1085
8bd7b830 1086 Improve C-level modularity by making more things 'static'.
cd64ea1d 1087
e3b27b31
PE
1088 Don't publish debugger-only interfaces to other modules.
1089 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1090 (verify_bytepos, count_markers): Move decls to the only modules
1091 that need them.
1092 * region-cache.h (pp_cache): Likewise.
1093 * window.h (check_all_windows): Likewise.
1094 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1095
5d4cb038
PE
1096 * sysdep.c (croak): Now static, if
1097 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1098 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1099
1100 * alloc.c (refill_memory_reserve): Now static if
1101 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1102 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1103
e87b6180
PE
1104 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1105 Define only if USE_LUCID.
1106
ac64929e
PE
1107 * xrdb.c (x_customization_string, x_rm_string): Now static.
1108
6f37259d
PE
1109 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1110 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1111
1683e3ab
PE
1112 * xdisp.c (draw_row_with_mouse_face): Now static.
1113 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1114
de9c2632
PE
1115 * window.h (check_all_windows): Mark externally visible.
1116
2b96acb7
PE
1117 * window.c (window_deletion_count): Now static.
1118
1119 * undo.c: Make symbols static if they're not exported.
1120 (last_undo_buffer, last_boundary_position, pending_boundary):
1121 Now static.
1122
50436f33
PE
1123 * textprop.c (interval_insert_behind_hooks): Now static.
1124 (interval_insert_in_front_hooks): Likewise.
1125
64520e5c
PE
1126 * term.c: Make symbols static if they're not exported.
1127 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1128 (max_frame_lines, tty_set_terminal_modes):
1129 (tty_reset_terminal_modes, tty_turn_off_highlight):
1130 (get_tty_terminal): Now static.
1131 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1132 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1133 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1134 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1135 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1136
1fa53021
PE
1137 * sysdep.c: Make symbols static if they're not exported.
1138 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1139 Now static.
1140 (sigprocmask_set, full_mask): Remove; unused.
1141 (wait_debugging): Mark as visible.
1142 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1143 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1144
d4b43b22
PE
1145 * syntax.c (syntax_temp): Define only if !__GNUC__.
1146
b7c513d0
PE
1147 * sound.c (current_sound_device, current_sound): Now static.
1148
989b29ad
PE
1149 * search.c (searchbufs, searchbuf_head): Now static.
1150
13a55a78
PE
1151 * scroll.c (scroll_cost): Remove; unused.
1152 * dispextern.h (scroll_cost): Remove decl.
1153
de68a1fc
PE
1154 * region-cache.h (pp_cache): Mark as externally visible.
1155
40ccffa6
PE
1156 * process.c: Make symbols static if they're not exported.
1157 (process_tick, update_tick, create_process, chan_process):
1158 (Vprocess_alist, proc_buffered_char, datagram_access):
1159 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1160 (deactivate_process): Mark defn as static, as well as decl.
1161 * lisp.h (create_process): Remove decl.
1162 * process.h (chan_process, Vprocess_alist): Remove decls.
1163
ad64fc97
PE
1164 * print.c: Make symbols static if they're not exported.
1165 (print_depth, new_backquote_output, being_printed, print_buffer):
1166 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1167 (print_interval, print_number_index, initial_stderr_stream):
1168 Now static.
1169 * lisp.h (Fprinc): Remove decl.
1170 (debug_output_compilation_hack): Mark as externally visible.
1171
adddb265
PE
1172 * sysdep.c (croak): Move decl from here to syssignal.h.
1173 * syssignal.h (croak): Put it here, so the API can be checked when
1174 'croak' is called from dissociate_if_controlling_tty.
1175
1717ede2
PE
1176 * minibuf.c: Make symbols static if they're not exported.
1177 (minibuf_save_list, choose_minibuf_frame): Now static.
1178 * lisp.h (choose_minibuf_frame): Remove decl.
1179
fa5fb2bc
PE
1180 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1181
1e3890d1
PE
1182 * lread.c: Make symbols static if they're not exported.
1183 (read_objects, initial_obarray, oblookup_last_bucket_number):
1184 Now static.
1185 (make_symbol): Remove; unused.
1186 * lisp.h (initial_obarray, make_symbol): Remove decls.
1187
8a1414fa
PE
1188 * keyboard.c: Make symbols static if they're not exported.
1189 (single_kboard, recent_keys_index, total_keys, recent_keys):
1190 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1191 (this_single_command_key_start, echoing, last_auto_save):
1192 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1193 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1194 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1195 (Vlispy_mouse_stem, double_click_count):
1196 Now static.
1197 (force_auto_save_soon): Define only if SIGDANGER.
1198 (ignore_mouse_drag_p): Now static if
1199 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1200 (print_help): Remove; unused.
1201 (stop_character, last_timer_event): Mark as externally visible.
1202 * keyboard.h (ignore_mouse_drag_p): Declare only if
1203 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1204 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1205 * lisp.h (echoing): Remove decl.
1206 (force_auto_save_soon): Declare only if SIGDANGER.
1207 * xdisp.c (redisplay_window): Simplify code, to make it more
1208 obvious that ignore_mouse_drag_p is not accessed if !defined
1209 USE_GTK && !defined HAVE_NS.
1210
93ea6e8f
PE
1211 * intervals.c: Make symbols static if they're not exported.
1212 (merge_properties_sticky, merge_interval_right, delete_interval):
1213 Now static.
1214 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1215
77382fcc
PE
1216 * insdel.c: Make symbols static if they're not exported.
1217 However, leave prepare_to_modify_buffer alone. It's never
1218 called from outside this function, but that appears to be a bug.
1219 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1220 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1221 (adjust_after_replace_noundo): Remove; unused.
1222 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1223 (signal_before_change): Remove decls.
77382fcc 1224
9306c32e
PE
1225 * indent.c (val_compute_motion, val_vmotion): Now static.
1226
cd44d2eb
PE
1227 * image.c: Make symbols static if they're not exported.
1228 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1229 if USE_GTK.
1230 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1231 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1232
ad9a7a06
PE
1233 * fringe.c (standard_bitmaps): Now static.
1234 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1235
81626931
PE
1236 * frame.c: Make symbols static if they're not exported.
1237 (x_report_frame_params, make_terminal_frame): Now static.
1238 (get_frame_param): Now static, unless HAVE_NS.
1239 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1240 (x_get_resource_string): Remove; not used.
1241 * frame.h (make_terminal_frame, x_report_frame_params):
1242 (x_get_resource_string); Remove decls.
1243 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1244 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1245
239f9db9
PE
1246 * font.c, fontset.c: Make symbols static if they're not exported.
1247 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1248 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1249 * font.c (font_close_object): Now static.
1250 * font.h (font_close_object): Remove.
1251 * fontset.c (FONTSET_OBJLIST): Remove.
1252 (free_realized_fontset) #if-0 the body, which does nothing.
1253 (face_suitable_for_char_p): #if-0, as it's never called.
1254 * fontset.h (face_suitable_for_char_p): Remove decl.
1255 * xfaces.c (face_at_string_position): Use
1256 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1257 since 0 is always ASCII.
1258
dfcf3579
PE
1259 * fns.c (weak_hash_tables): Now static.
1260
5045092b
PE
1261 * fileio.c: Make symbols static if they're not exported.
1262 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1263 (Vwrite_region_annotation_buffers): Now static.
1264
57a96f5c
PE
1265 * eval.c: Make symbols static if they're not exported.
1266 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1267 * lisp.h (backtrace_list): Remove decl.
1268
35f08c38
PE
1269 * emacs.c: Make symbols static if they're not exported.
1270 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1271 (fatal_error_code, fatal_error_signal_hook, standard_args):
1272 Now static.
1273 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1274 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1275 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1276 * lisp.h (fatal_error_signal_hook): Remove decl.
1277 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1278
f44bd759
PE
1279 * editfns.c: Move a (normally-unused) function to its only use.
1280 * editfns.c, lisp.h (get_operating_system_release): Remove.
1281 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1282 worth the hassle of breaking this out.
1283
b532497d
PE
1284 * xterm.c: Make symbols static if they're not exported.
1285 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1286 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1287 (x_destroy_window, x_delete_display):
1288 Now static.
1289 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1290 (x_mouse_leave): Remove; unused.
1291 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1292 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1293 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1294 Remove decls.
1295 (x_mouse_leave): Declare only if WINDOWSNT.
1296 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1297 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1298 USE_X_TOOLKIT.
1299
1675728f
PE
1300 * ftxfont.c: Make symbols static if they're not exported.
1301 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1302 HAVE_FREETYPE.
1303 * font.h (ftxfont_driver): Likewise.
1304
e4cebfca
PE
1305 * xfns.c: Make symbols static if they're not exported.
1306 (x_last_font_name, x_display_info_for_name):
1307 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1308 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1309 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1310 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1311 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1312 (last_show_tip_args): Now static.
1313 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1314 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1315 (x_screen_planes): Remove; unused.
1316 * dispextern.h (x_screen_planes): Remove decl.
1317
5bf46f05
PE
1318 * dispnew.c: Make symbols static if they're not exported.
1319 * dispextern.h (redraw_garbaged_frames, scrolling):
1320 (increment_row_positions): Remove.
1321 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1322 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1323 Now static.
1324 (redraw_garbaged_frames): Remove; unused.
1325
435f4c28
PE
1326 * xfaces.c: Make symbols static if they're not exported.
1327 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1328 Remove decls.
1329 * xterm.h (defined_color): Remove decls.
1330 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1331 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1332 (menu_face_changed_default, defined_color, free_realized_face):
1333 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1334 (ascii_face_of_lisp_face): Remove; unused.
1335
8524aef3
PE
1336 * xdisp.c: Make symbols static if they're not exported.
1337 * dispextern.h (scratch_glyph_row, window_box_edges):
1338 (glyph_to_pixel_coords, set_cursor_from_row):
1339 (get_next_display_element, set_iterator_to_next):
1340 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1341 (show_mouse_face): Remove decls
1342 * frame.h (message_buf_print): Likewise.
1343 * lisp.h (pop_message, set_message, check_point_in_composition):
1344 Likewise.
1345 * xterm.h (set_vertical_scroll_bar): Likewise.
1346 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1347 (message_buf_print, scratch_glyph_row, displayed_buffer):
1348 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1349 (get_next_display_element, show_mouse_face, window_box_edges):
1350 (frame_to_window_pixel_xy, check_point_in_composition):
1351 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1352 (glyph_to_pixel_coords): Remove; unused.
1353
16390cd2
PE
1354 * dired.c (file_name_completion): Now static.
1355
1356 * dbusbind.c (xd_in_read_queued_messages): Now static.
1357
a25f4dfa
PE
1358 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1359 * data.c (circular_list_error): Remove.
1360
14a9c8df
PE
1361 * commands.h (last_point_position, last_point_position_buffer):
1362 (last_point_position_window): Remove decls.
1363 * keyboard.c: Make these variables static.
1364
74ab6df5
PE
1365 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1366 decls.
1367 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1368 (iso_code_class, detect_coding, code_convert_region): Now static.
1369 (encode_coding_gap): Remove; unused.
1370
38dfbee1
PE
1371 * chartab.c (chartab_chars, chartab_bits): Now static.
1372
a2cb4e63
PE
1373 * charset.h (charset_iso_8859_1): Remove decl.
1374 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1375 Now static.
1376
127198fd
PE
1377 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1378 * ccl.c (Vccl_program_table): Now static.
1379 (check_ccl_update): Remove; unused.
1380
d85b608f
PE
1381 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1382 * category.h: ... from here.
1383 * category.c (check_category_table, set_category_set): Now static.
1384
31cd66f3
PE
1385 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1386 * lisp.h: Remove these decls.
1387
c358e587
PE
1388 * buffer.c (buffer_count): Remove unused var.
1389
e78aecca
PE
1390 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1391 so that it's not optimized away.
1392 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1393 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1394 exported only to the debugger.
1395
e192d7d3
PE
1396 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1397 * atimer.h (run_all_atimers): Removed; not exported.
1398
92470028
PE
1399 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1400 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1401 was inaccessible from Lisp.
1402 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1403 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1404
244ed907
PE
1405 alloc.c: Import and export fewer symbols, and remove unused items.
1406 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1407 is defined.
1408 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1409 it's not optimized away by whole-program optimization.
1410 (message_enable_multibyte, free_misc): Remove.
1411 (catchlist, handlerlist, mark_backtrace):
1412 Declare only if BYTE_MARK_STACK.
1413 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1414 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1415 (message_enable_multibyte): Remove decl.
1416 (free_misc, interval_free_list, float_block, float_block_index):
1417 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1418 (cons_free_list, last_marked_index):
1419 Now static.
1420 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1421 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1422 (mark_backtrace): Define only if BYTE_MARK_STACK.
1423 * xdisp.c (message_enable_multibyte): Now static.
1424
61c2b50e 1425 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1426 This makes it easier for human readers (and static analyzers)
1427 to see whether these variables are used from other modules.
1428 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1429 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1430 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1431 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1432 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1433 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1434 * xmenu.c, xselect.c:
1435 Declare Q* vars static if they are not used in other modules.
1436 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1437 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1438 Remove decls of unexported vars.
1439 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1440
95c82688
PE
1441 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1442
16a97296
PE
1443 Make Emacs functions such as Fatom 'static' by default.
1444 This makes it easier for human readers (and static analyzers)
1445 to see whether these functions can be called from other modules.
1446 DEFUN now defines a static function. To make the function external
1447 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1448 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1449 (Finit_image_library):
16a97296
PE
1450 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1451 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1452 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1453 Remove decls, since these functions are now static.
1454 (Funintern, Fget_internal_run_time): New decls, since these functions
1455 were already external.
95c82688 1456
16a97296
PE
1457 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1458 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1459 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1460 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1461 * keyboard.c, keymap.c, lread.c:
1462 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1463 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1464 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1465 Mark functions with DEFUE instead of DEFUN,
1466 if they are used in other modules.
1467 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1468 decls for now-static functions.
1469 * buffer.h (Fdelete_overlay): Remove decl.
1470 * callproc.c (Fgetenv_internal): Mark as internal.
1471 * composite.c (Fremove_list_of_text_properties): Remove decl.
1472 (Fcomposition_get_gstring): New forward static decl.
1473 * composite.h (Fcomposite_get_gstring): Remove decl.
1474 * dired.c (Ffile_attributes): New forward static decl.
1475 * doc.c (Fdocumntation_property): New forward static decl.
1476 * eval.c (Ffetch_bytecode): New forward static decl.
1477 (Funintern): Remove extern decl; now in .h file where it belongs.
1478 * fileio.c (Fmake_symbolic_link): New forward static decl.
1479 * image.c (Finit_image_library): New forward static decl.
1480 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1481 * intervals.h (Fprevious_property_change):
1482 (Fremove_list_of_text_properties): Remove decls.
1483 * keyboard.c (Fthis_command_keys): Remove decl.
1484 (Fcommand_execute): New forward static decl.
1485 * keymap.c (Flookup_key): New forward static decl.
1486 (Fcopy_keymap): Now static.
1487 * keymap.h (Flookup_key): Remove decl.
1488 * process.c (Fget_process): New forward static decl.
1489 (Fprocess_datagram_address): Mark as internal.
1490 * syntax.c (Fsyntax_table_p): New forward static decl.
1491 (skip_chars): Remove duplicate decl.
1492 * textprop.c (Fprevious_property_change): New forward static decl.
1493 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1494 Now internal.
1495 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1496 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1497
785bbd42
PE
1498 * editfns.c (Fformat): Remove unreachable code.
1499
8b913b57
AS
15002011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1501
1502 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1503 change. (Bug#8496)
1504
a6744a35
EZ
15052011-04-13 Eli Zaretskii <eliz@gnu.org>
1506
1507 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1508 when at ZV. (Bug#8487)
1509
e7974947
AS
15102011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1511
baad03f0
AS
1512 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1513 (Bug#8437)
1514 * keyboard.c (parse_tool_bar_item): Likewise.
1515 * sound.c (sound_cleanup, alsa_close): Likewise.
1516 * termcap.c (tgetent): Likewise.
1517 * xfns.c (x_default_font_parameter): Likewise.
1518 * xsettings.c (read_and_apply_settings): Likewise.
1519
e7974947
AS
1520 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1521 (overrun_check_free): Protoize.
1522
28272684
PE
15232011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1526 since callers should never pass a negative size.
1527 Change the signature to match that of plain 'read' and 'write'; see
1528 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1529 * lisp.h: Update prototypes of emacs_write and emacs_read.
1530
11997c76
EZ
15312011-04-11 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (redisplay_window): Don't try to determine the character
1534 position of the scroll margin if the window start point w->startp
e896f03c 1535 is outside the buffer's accessible region. (Bug#8468)
11997c76 1536
8a2cbd72
EZ
15372011-04-10 Eli Zaretskii <eliz@gnu.org>
1538
1539 Fix write-region and its subroutines for buffers > 2GB.
1540 * fileio.c (a_write, e_write): Modify declaration of arguments and
1541 local variables to support buffers larger than 2GB.
1542 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1543
1544 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1545 argument, local variables, and return value.
1546
1547 * lisp.h: Update prototypes of emacs_write and emacs_read.
1548
1549 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1550
4073e537 15512011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1552
1ebfdcb6
PE
1553 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1554
b2ded58d
PE
1555 Fix more problems found by GCC 4.6.0's static checks.
1556
7d66342c
PE
1557 * xdisp.c (vmessage): Use a better test for character truncation.
1558
bbf47d44
PE
1559 * charset.c (load_charset_map): <, not <=, for optimization,
1560 and to avoid potential problems with integer overflow.
9248994d 1561 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1562 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1563 * editfns.c (Fformat): Likewise.
1e69125e 1564 * syntax.c (skip_chars): Likewise.
3befa583 1565
e3019616
PE
1566 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1567 This also lets GCC 4.6.0 generate slightly better loop code.
1568
becfa255
PE
1569 * callint.c (Fcall_interactively): <, not <=, for optimization.
1570 (Fcall_interactively): Count the number of arguments produced,
1571 not the number of arguments given. This is simpler and lets GCC
1572 4.6.0 generate slightly better code.
1573
dae0cd48
PE
1574 * ftfont.c: Distingish more carefully between FcChar8 and char.
1575 The previous code passed unsigned char * to a functions like
1576 strlen and xstrcasecmp that expect char *, which does not
1577 conform to the C standard.
1578 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1579 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1580 char * when the C standard requires it.
1581
76032d70
PE
1582 * keyboard.c (read_char): Remove unused var.
1583
eb3f1cc8
PE
1584 * eval.c: Port to Windows vsnprintf (Bug#8435).
1585 Include <limits.h>.
1586 (SIZE_MAX): Define if the headers do not.
1587 (verror): Do not give up if vsnprintf returns a negative count.
1588 Instead, grow the buffer. This ports to Windows vsnprintf, which
1589 does not conform to C99. Problem reported by Eli Zaretskii.
1590 Also, simplify the allocation scheme, by avoiding the need for
1591 calling realloc, and removing the ALLOCATED variable.
1592
70476b54
PE
1593 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1594
12020a9e
PE
1595 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1596 But keep the doprint source code for now, as we might revamp it
1597 and use it again (Bug#8435).
ea6c7ae6
PE
1598 * lisp.h (doprnt): Remove.
1599 * Makefile.in (base_obj): Remove doprnt.o.
1600 * deps.mk (doprnt.o): Remove.
1601
5fdb398c
PE
1602 error: Print 32- and 64-bit integers portably (Bug#8435).
1603 Without this change, on typical 64-bit hosts error ("...%d...", N)
1604 was used to print both 32- and 64-bit integers N, which relied on
1605 undefined behavior.
1606 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1607 New macro.
1608 * lisp.h (error, verror): Mark as printf-like functions.
1609 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1610 Report overflow in size calculations when allocating printf buffer.
1611 Do not truncate output string at its first null byte.
1612 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1613 Truncate the output at a character boundary, since vsnprintf does not
1614 do that.
1615 * charset.c (check_iso_charset_parameter): Convert internal
1616 character to string before calling 'error', since %c now has the
1617 printf meaning.
1618 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1619 overflow when computing char to be passed to 'error'. Do not
1620 pass Lisp_Object to 'error'; pass the integer instead.
1621 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1622 formatted with plain %d.
1623
b189fa66
PE
1624 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1625
bff87ef0
PE
1626 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1627
7e2cac20
PE
1628 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1629
ce4d90b5
PE
1630 * xterm.c (x_catch_errors): Remove duplicate declaration.
1631
266c9547
PE
1632 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1633
79c49ad2
PE
1634 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1635
368f4090
JM
16362011-04-10 Jim Meyering <meyering@redhat.com>
1637
1638 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1639 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1640 return ssize_t not "int", and use size_t as the buffer length.
1641 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1642 * gnutls.h: Update declarations.
1643 * process.c (read_process_output): Use ssize_t, to match.
1644 (send_process): Likewise.
1645
a32d4040
CY
16462011-04-09 Chong Yidong <cyd@stupidchicken.com>
1647
1648 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1649
8546720e 16502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1651
8546720e
GM
1652 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1653 unsigned char, to match FcChar8 type definition.
aac0c6e3 1654
8546720e
GM
1655 * xterm.c (handle_one_xevent):
1656 * xmenu.c (create_and_show_popup_menu):
1657 * xselect.c (x_decline_selection_request)
1658 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1659
0a2f5c1a 16602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1661
1662 Fix some uses of `int' instead of EMACS_INT.
1663 * search.c (string_match_1, fast_string_match)
1664 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1665 (scan_buffer, find_next_newline_no_quit)
1666 (find_before_next_newline, search_command, Freplace_match)
1667 (Fmatch_data): Make some `int' variables be EMACS_INT.
1668
1669 * xdisp.c (display_count_lines): 3rd argument and return value now
1670 EMACS_INT. All callers changed.
1671 (pint2hrstr): Last argument is now EMACS_INT.
1672
1673 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1674 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1675 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1676 (decode_coding_utf_16, decode_coding_emacs_mule)
1677 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1678 (decode_coding_ccl, decode_coding_charset)
1679 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1680 (decode_coding_iso_2022, decode_coding_emacs_mule)
1681 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1682 <char_offset, last_offset>: Declare EMACS_INT.
1683 (encode_coding_utf_8, encode_coding_utf_16)
1684 (encode_coding_emacs_mule, encode_invocation_designation)
1685 (encode_designation_at_bol, encode_coding_iso_2022)
1686 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1687 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1688 Declare EMACS_INT.
1689 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1690 (encode_invocation_designation): Last argument P_NCHARS is now
1691 EMACS_INT.
1692 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1693 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1694
1695 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1696 All users changed.
1697
1698 * ccl.c (Fccl_execute_on_string): Declare some variables
1699 EMACS_INT.
1700
8546720e 17012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1702
1703 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1704
4e19a977
CS
17052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1706
1707 * process.c (Fformat_network_address): Doc fix.
1708
87302331
R
17092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1710
1711 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1712
cbb59342
CY
17132011-04-08 Chong Yidong <cyd@stupidchicken.com>
1714
1715 * keyboard.c (read_char): Call Lisp function help-form-show,
1716 instead of using internal_with_output_to_temp_buffer.
1717 (Qhelp_form_show): New var.
e0d38eeb 1718 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1719
1720 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1721
1722 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1723
e67a13ab
CY
17242011-04-06 Chong Yidong <cyd@stupidchicken.com>
1725
1726 * process.c (Flist_processes): Removed to Lisp.
1727 (list_processes_1): Deleted.
1728
973f782d
EZ
17292011-04-06 Eli Zaretskii <eliz@gnu.org>
1730
7c106b1e
EZ
1731 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1732
973f782d
EZ
1733 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1734
41cf7d1a 17352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1736
ca23cc88
PE
1737 Fix more problems found by GCC 4.6.0's static checks.
1738
f390e2d5
PE
1739 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1740
42eea0d0
PE
1741 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1742
b69769da 1743 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1744
f9541e84
PE
1745 * xdisp.c (vmessage): Mark as a printf-like function.
1746
13841b55
PE
1747 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1748
c136c10f
PE
1749 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1750
5e2d4a30
PE
1751 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1752 printf-like functions.
1753 (tiff_load): Add casts to remove these marks before passing them
1754 to system-supplied API.
1755
583f48b9
PE
1756 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1757
b25d760e
PE
1758 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1759 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1760 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1761 directly, rather than having caller test rule sign. This avoids
1762 some unnecessary tests.
1763 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1764 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1765 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1766
bc7b6697 1767 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1768 (xfont_open): Avoid unnecessary tests.
bc7b6697 1769
27ccc379
PE
1770 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1771
dcd5c89a
PE
1772 * composite.h, composite.c (composition_gstring_put_cache):
1773 Use EMACS_INT, not int, for length.
1774
b13a45c6
PE
1775 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1776 breaking out part of COMPOSITION_DECODE_RULE.
1777 (COMPOSITION_DECODE_RULE): Use it.
1778 * composite.c (get_composition_id): Remove unused local vars,
1779 by using the new macro.
1780
1e792e4d
PE
1781 * textprop.c (set_text_properties_1): Change while to do-while,
1782 since the condition is always true at first.
1783
dc6c6455 1784 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1785 (interval_deletion_adjustment): Return unsigned value.
1786 All uses changed.
dc6c6455 1787
aba7731a
PE
1788 * process.c (list_processes_1, create_pty, read_process_output):
1789 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1790 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1791 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1792 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1793 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1794
fdfc4bf3
PE
1795 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1796
fca8fe46 1797 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1798 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1799
06a0259a 1800 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1801 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1802 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1803
e7b9e80f
PE
1804 * print.c (print_error_message): Avoid int overflow.
1805
56201685
PE
1806 * font.c (font_list_entities): Redo for clarity,
1807 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1808
78834453 1809 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1810 (font_score): Avoid potential overflow in diff calculation.
78834453 1811
0bc0b309 1812 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1813 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1814
e610eaca
PE
1815 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1816
b895abce
PE
1817 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1818 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1819 can always succeed if overflow has undefined behavior.
1820
1f1d9321 1821 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1822 (wordify): Omit three unnecessary tests.
1f1d9321 1823
c59478bc
PE
1824 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1825 All callers changed. This avoids the need for an unused var.
1826
79b73827
PE
1827 * casefiddle.c (casify_region): Remove var that is set but not used.
1828
a4db5dfe
PE
1829 * dired.c (file_name_completion): Remove var that is set but not used.
1830
43aae36e
PE
1831 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1832
2a47c44d 1833 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1834 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1835
a37c69bf
PE
1836 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1837 Check for integer overflow on size calculations.
1838
328ab8e7
PE
1839 * buffer.c (Fprevious_overlay_change): Remove var that is set
1840 but not used.
1841
e5a2a5cb
PE
1842 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1843 Remove vars that are set but not used.
8d84a6eb 1844 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1845 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1846
a60e5f68
PE
1847 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1848
f661cb61 1849 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1850 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1851
f0397f5a
PE
1852 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1853 that are set but not used.
1854
8664db06 1855 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1856 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1857
6abdaa4a
PE
1858 * xselect.c (x_get_local_selection, x_handle_property_notify):
1859 Remove vars that are set but not used.
1860
0ce7538d 1861 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1862 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1863
9ae848fc
PE
1864 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1865 Remove var that is set but not used.
0b918413
PE
1866 (scroll_bar_windows_size): Now size_t, not int.
1867 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1868 Check for overflow.
9ae848fc 1869
a5a62657
PE
1870 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1871 (map_tty_color) [!defined MSDOS]: Likewise.
1872
5c5cdd39
PE
1873 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1874
66ebf983
PE
1875 * coding.c: Remove vars that are set but not used.
1876 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1877 All callers changed.
1878 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1879 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1880 (decode_coding_charset): Remove vars that are set but not used.
1881
1be4d761
PE
1882 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1883 that is set but not used.
1884
47553fa8
PE
1885 * print.c (print_object): Remove var that is set but not used.
1886
1f7196bf 1887 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1888 The gnulib version avoids calling malloc in the usual case,
1889 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1890 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1891 * filelock.c (current_lock_owner): Likewise.
1892 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1893 * sysdep.c: Include allocator.h, careadlinkat.h.
1894 (emacs_no_realloc_allocator): New static constant.
1895 (emacs_readlink): New function.
fdb61804
PE
1896 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1897 ../lib/careadlinkat.h.
d1fdcab7 1898
f84c17c7
SM
18992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1900
1901 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1902 first non-nil return value).
1903
ef3862ad
JD
19042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1905
1906 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1907 if not defined (Bug#8403).
1908
376a7006
JB
19092011-04-02 Juanma Barranquero <lekktu@gmail.com>
1910
1911 * xdisp.c (display_count_lines): Remove parameter `start',
1912 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1913 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1914 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1915 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1916 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1917 and thereabouts. All callers changed.
1918 (get_per_char_metric): Remove parameter `f', unused since
1919 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1920
6ca3801d
JM
19212011-04-02 Jim Meyering <meyering@redhat.com>
1922
1923 do not dereference NULL upon failed strdup
1924 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1925 (ns_get_family): Likewise.
1926
d8e2b5ba
JB
19272011-04-02 Juanma Barranquero <lekktu@gmail.com>
1928
1929 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1930
8c74fcbd
JD
19312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1932
1933 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1934 later (Bug#8403).
1935
7200d79c
SM
19362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1937
03408648 1938 Add lexical binding.
7200d79c 1939
03408648
SM
1940 * window.c (Ftemp_output_buffer_show): New fun.
1941 (Fsave_window_excursion):
1942 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1943
1944 * lread.c (lisp_file_lexically_bound_p): New function.
1945 (Fload): Bind Qlexical_binding.
1946 (readevalloop): Remove `evalfun' arg.
1947 Bind Qinternal_interpreter_environment.
1948 (Feval_buffer): Bind Qlexical_binding.
1949 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1950 Mark as dynamic.
1951 (syms_of_lread): Declare `lexical-binding'.
1952
1953 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1954
1955 * keyboard.c (eval_dyn): New fun.
1956 (menu_item_eval_property): Use it.
ca105506
SM
1957
1958 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1959
03408648
SM
1960 * fns.c (concat, mapcar1): Accept byte-code-functions.
1961
1962 * eval.c (Fsetq): Handle lexical vars.
1963 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1964 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1965 (FletX, Flet): Obey lexical binding.
1966 (Fcommandp): Handle closures.
1967 (Feval): New `lexical' arg.
1968 (eval_sub): New function extracted from Feval. Use it almost
1969 everywhere where Feval was used. Look up vars in lexical env.
1970 Handle closures.
1971 (Ffunctionp): Move from subr.el.
1972 (Ffuncall): Handle closures.
1973 (apply_lambda): Remove `eval_flags'.
1974 (funcall_lambda): Handle closures and new byte-code-functions.
1975 (Fspecial_variable_p): New function.
1976 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1977 but without exporting it to Lisp.
23aba0ea 1978
23aba0ea 1979 * doc.c (Fdocumentation, store_function_docstring):
03408648 1980 * data.c (Finteractive_form): Handle closures.
23aba0ea 1981
03408648
SM
1982 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1983 interactive spec.
ba83908c 1984
03408648
SM
1985 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1986 byte-codes.
1987 (exec_byte_code): New function extracted from Fbyte_code to handle new
1988 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1989
03408648 1990 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1991
03408648 1992 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1993
e2abce01
JB
19942011-03-31 Juanma Barranquero <lekktu@gmail.com>
1995
1996 * xdisp.c (redisplay_internal): Fix prototype.
1997
63696a73 19982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1999
63696a73
EZ
2000 * xdisp.c (SCROLL_LIMIT): New macro.
2001 (try_scrolling): Use it when setting scroll_limit. Limit
2002 scrolling to 100 screen lines.
2003 (redisplay_window): Even when falling back on "recentering",
2004 position point in the window according to scroll-conservatively,
2005 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2006
2007 (try_scrolling): When point is above the window, allow searching
2008 as far as scroll_max, or one screenful, to compute vertical
2009 distance from PT to the scroll margin position. This prevents
2010 try_scrolling from unnecessarily failing when
2011 scroll-conservatively is set to a value slightly larger than the
2012 window height. Clean up the case of PT below the margin at bottom
2013 of window: scroll_max can no longer be INT_MAX. When aggressive
2014 scrolling is in use, don't let point enter the opposite scroll
2015 margin as result of the scroll.
2016 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2017 threshold of 100 lines for never-recentering scrolling.
2018
e4cc2dfc
JB
20192011-03-31 Juanma Barranquero <lekktu@gmail.com>
2020
2021 * dispextern.h (move_it_by_lines):
2022 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2023 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2024 (message_log_check_duplicate): Remove parameters `prev_bol' and
2025 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2026 (redisplay_internal): Remove parameter `preserve_echo_area',
2027 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2028
2029 * indent.c (Fvertical_motion):
2030 * window.c (window_scroll_pixel_based, Frecenter):
2031 Don't pass `need_y_p' to `move_it_by_lines'.
2032
1c470562
SM
20332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2034
44f230aa
SM
2035 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2036 steal a few bits to be more compact.
2037 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2038 Remove unneeded casts.
2039
1c470562
SM
2040 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2041
888adce9
ZK
20422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2043
2044 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2045 binding" message (bug#7967).
2046
f838ed7b
PE
20472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2048
77861b95
PE
2049 Fix more problems found by GCC 4.6.0's static checks.
2050
de6dbc14
PE
2051 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2052 Remove unused local var.
2053
f838ed7b
PE
2054 * editfns.c (Fmessage_box): Remove unused local var.
2055
792c7b2b
PE
2056 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2057 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2058 Omit unused local vars.
c499e557 2059 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2060 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2061 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2062 Omit unused local var.
2063
ba0165e1
PE
2064 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2065 Don't assume string length fits in int.
32ad8845 2066 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2067 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2068
3c59b4c9
PE
2069 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2070 instead of alloca (Bug#8344).
2071
a3eed478 2072 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2073 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2074
eb4d412d
PE
2075 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2076
1658b401
PE
2077 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2078 concerns.
2079
2080 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2081
2082 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2083
9a2c6e05
PE
2084 * keyboard.c (syms_of_keyboard): Use the same style as later
2085 in this function when indexing through an array. This also
2086 works around GCC bug 48267.
2087
03d0a109
PE
2088 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2089
44f730c8
PE
2090 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2091
fe75f926
PE
2092 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2093 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2094
ffa8c828
PE
2095 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2096 This avoids undefined behavior on integer overflow, and is a bit
2097 more convenient anyway since it is compared to a size_t variable.
2098
c5101a77
PE
2099 Variadic C functions now count arguments with size_t, not int.
2100 This avoids an unnecessary limitation on 64-bit machines, which
2101 caused (substring ...) to crash on large vectors (Bug#8344).
2102 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2103 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2104 All variadic functions and their callers changed accordingly.
c5101a77
PE
2105 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2106 * data.c (arith_driver, float_arith_driver): Likewise.
2107 * editfns.c (general_insert_function): Likewise.
2108 * eval.c (struct backtrace.nargs, interactive_p)
2109 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2110 (funcall_lambda, mark_backtrace): Likewise.
2111 * fns.c (concat): Likewise.
2112 * frame.c (x_set_frame_parameters): Likewise.
2113 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2114 0 if not found, not -1. All callers changed.
2115
dd3f25f7
PE
2116 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2117 (stack_copy_size): Now size_t, not int.
2118 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2119
461c2ab9
JB
21202011-03-28 Juanma Barranquero <lekktu@gmail.com>
2121
2122 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2123 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2124 All callers changed.
2125
2126 * lisp.h (multibyte_char_to_unibyte):
2127 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2128 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2129 * character.h (CHAR_TO_BYTE8):
2130 * cmds.c (internal_self_insert):
2131 * editfns.c (general_insert_function):
2132 * keymap.c (push_key_description):
2133 * search.c (Freplace_match):
2134 * xdisp.c (message_dolog, set_message_1): All callers changed.
2135
f6d62986
SM
21362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2137
2138 * keyboard.c (safe_run_hook_funcall): New function.
2139 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2140 don't set the hook to nil, but remove the offending function instead.
2141 (Qcommand_hook_internal): Remove, unused.
2142 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2143 Vcommand_hook_internal.
2144
2145 * eval.c (enum run_hooks_condition): Remove.
2146 (funcall_nil, funcall_not): New functions.
2147 (run_hook_with_args): Call each function through a `funcall' argument.
2148 Remove `cond' argument, now redundant.
2149 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2150 (Frun_hook_with_args_until_failure): Adjust accordingly.
2151 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2152
1db5b1ad
JB
21532011-03-28 Juanma Barranquero <lekktu@gmail.com>
2154
2155 * dispextern.h (string_buffer_position): Remove declaration.
2156
2157 * print.c (strout): Remove parameter `multibyte', unused since
2158 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2159
2160 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2161 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2162 All callers changed.
2163
2164 * w32.c (_wsa_errlist): Use braces for struct initializers.
2165
2166 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2167 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2168 All callers changed.
2169 (string_buffer_position): Likewise. Also, make static (it's never
2170 used outside xdisp.c).
2171 (cursor_row_p): Remove parameter `w', unused since
2172 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2173 (decode_mode_spec): Remove parameter `precision', introduced during
2174 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2175 All callers changed.
2176
5ffb62aa
JD
21772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2178
2179 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2180
461c2ab9 21812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2182
2183 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2184 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2185 (ns_update_auto_hide_menu_bar): New functions.
2186 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2187 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2188 ns_constrain_all_frames.
2189 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2190 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2191
5c380ffb
JD
21922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2193
2194 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2195
9af30bdf
GM
21962011-03-27 Glenn Morris <rgm@gnu.org>
2197
2198 * syssignal.h: Replace RETSIGTYPE with void.
2199 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2200 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2201 Replace SIGTYPE with void everywhere.
2202 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2203 * s/template.h (SIGTYPE): Remove commented out definition.
2204
e2abce01
JB
22052011-03-26 Eli Zaretskii <eliz@gnu.org>
2206
2207 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2208 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2209
f868cd8a
JB
22102011-03-26 Juanma Barranquero <lekktu@gmail.com>
2211
59eb0929
JB
2212 * w32.c (read_unc_volume): Use parameter `henum', instead of
2213 global variable `wget_enum_handle'.
2214
2215 * keymap.c (describe_vector): Remove parameters `indices' and
2216 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2217 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2218
f868cd8a
JB
2219 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2220
2221 * keyboard.c (timer_check): Remove parameter `do_it_now',
2222 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2223 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2224 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2225
2226 * keyboard.c (read_char):
2227 * w32menu.c (w32_menu_display_help):
2228 * xmenu.c (show_help_event, menu_help_callback):
2229 Adjust calls to `show_help_echo'.
2230
2231 * gtkutil.c (xg_maybe_add_timer):
2232 * keyboard.c (readable_events):
2233 * process.c (wait_reading_process_output):
2234 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2235
2236 * insdel.c (adjust_markers_gap_motion):
2237 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2238 (gap_left, gap_right): Don't call it.
2239
2ecf6fdb
CY
22402011-03-25 Chong Yidong <cyd@stupidchicken.com>
2241
2242 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2243 incurred during fontification.
2244
6b1f9ba4
JB
22452011-03-25 Juanma Barranquero <lekktu@gmail.com>
2246
2247 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2248 (DEFVAR_PER_BUFFER): Don't pass it.
2249
2250 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2251 (scrolling_window): Don't pass it.
2252
0f4a96b5
JB
22532011-03-25 Juanma Barranquero <lekktu@gmail.com>
2254
2255 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2256
2257 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2258 and `suffix'.
2259 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2260 of variables specific to SELinux and computation of `encoded_absname'.
2261
2262 * image.c (XPutPixel): Remove unused variable `height'.
2263
2264 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2265
2266 * unexw32.c (get_section_info): Remove unused variable `section'.
2267
2268 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2269 (system_process_attributes): Remove unused variable `sess'.
2270 (sys_read): Remove unused variable `err'.
2271
2272 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2273 (w32_wnd_proc): Remove unused variable `isdead'.
2274 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2275 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2276 (x_create_tip_frame): Remove unused variable `tem'.
2277
2278 * w32inevt.c (w32_console_read_socket):
2279 Remove unused variable `no_events'.
2280
2281 * w32term.c (x_draw_composite_glyph_string_foreground):
2282 Remove unused variable `width'.
2283
1149507c
JB
22842011-03-24 Juanma Barranquero <lekktu@gmail.com>
2285
2286 * w32term.c (x_set_glyph_string_clipping):
2287 Don't pass uninitialized region to CombineRgn.
2288
9c88f339
JB
22892011-03-23 Juanma Barranquero <lekktu@gmail.com>
2290
2291 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2292 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2293 (Fx_close_connection): Remove unused variable `i'.
2294
2295 * w32font.c (w32font_draw): Return number of glyphs.
2296 (w32font_open_internal): Remove unused variable `i'.
2297 (w32font_driver): Add missing initializer.
2298
2299 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2300 (fill_in_menu): Remove unused variable `items_added'.
2301
2302 * w32term.c (last_mouse_press_frame): Remove static global variable.
2303 (w32_clip_to_row): Remove unused variable `f'.
2304 (x_delete_terminal): Remove unused variable `i'.
2305
2306 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2307 (NOTHING): Remove unused static global variable.
2308 (uniscribe_check_otf): Remove unused variable `table'.
2309 (uniscribe_font_driver): Add missing initializers.
2310
dee091a3
JD
23112011-03-23 Julien Danjou <julien@danjou.info>
2312
2313 * term.c (Fsuspend_tty, Fresume_tty):
2314 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2315 * window.c (temp_output_buffer_show):
2316 * insdel.c (signal_before_change):
2317 * frame.c (Fhandle_switch_frame):
2318 * fileio.c (Fdo_auto_save):
2319 * emacs.c (Fkill_emacs):
2320 * editfns.c (save_excursion_restore):
2321 * cmds.c (internal_self_insert):
2322 * callint.c (Fcall_interactively):
2323 * buffer.c (Fkill_all_local_variables):
2324 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2325 Use Frun_hooks.
0f4a96b5 2326 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2327 unconditionnaly since it does the check itself.
2328
2c520ab5 23292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2330
c9c49752
PE
2331 Fix more problems found by GCC 4.5.2's static checks.
2332
8abc3f12
PE
2333 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2334 the first time through the loop, since we know p0 < p1 then.
2335 This also avoids a gcc -Wstrict-overflow warning.
2336
a2d26660
PE
2337 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2338 leading to a memory leak, possible in functions like
2339 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2340 of objects (Bug#8318).
a2d26660 2341
916c72e9
PE
2342 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2343 that could (at least in theory) be that large.
2344
19ab8a18
PE
2345 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2346 This is less likely to overflow, and avoids undefined behavior if
2347 overflow does occur. All callers changed. Use strtoul to scan
2348 for the unsigned long integer.
b7cbbd6f
PE
2349 (pint2hrstr): Simplify and tune code slightly.
2350 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2351
f0641eff
PE
2352 * scroll.c (do_scrolling): Work around GCC bug 48228.
2353 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2354
7f650bb9
PE
2355 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2356 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2357 (validate_x_resource_name): Simplify count usage.
2358 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2359
37dd57d1
PE
2360 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2361 fail (Bug#8306).
81e56e61 2362
699979fc 2363 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2364
401bf9b4
PE
2365 * process.c (Fmake_network_process): Use socklen_t, not int,
2366 where POSIX says socklen_t is required in portable programs.
2367 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2368 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2369 (Fmake_network_process, server_accept_connection):
2370 (wait_reading_process_output, read_process_output):
2371 Likewise.
2372
b93aacde
PE
2373 * process.c: Rename or move locals to avoid shadowing.
2374 (list_processes_1, Fmake_network_process):
2375 (read_process_output_error_handler, exec_sentinel_error_handler):
2376 Rename or move locals.
4dc343ee 2377 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2378 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2379 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2380 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2381 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2382
af8a867c 2383 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2384 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2385 Include tparam.h instead, since it declares them.
af8a867c
PE
2386 * cm.h (PC): Remove extern decl; tparam.h now does this.
2387 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2388 * terminfo.c: Include tparam.h, to check interfaces.
2389 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2390 (tparam): Adjust signature to match interface in tparam.h;
2391 this removes some undefined behavior. Check that outstring and len
2392 are zero, which they always are with Emacs.
2393 * tparam.h (PC, BC, UP): New extern decls.
2394
0248044d 2395 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2396 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2397
8ff096c1 2398 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2399 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2400 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2401 (ftfont_list): Remove unused local.
49eaafba
PE
2402 (get_adstyle_property, ftfont_pattern_entity):
2403 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2404 Rename locals to avoid shadowing.
8ff096c1 2405
e2be39f6
PE
2406 * xfont.c (xfont_list_family): Mark var as initialized.
2407
c9735e30
PE
2408 * xml.c (make_dom): Now static.
2409
8f5201ae
PE
2410 * composite.c (composition_compute_stop_pos): Rename local to
2411 avoid shadowing.
b246f932
PE
2412 (composition_reseat_it): Remove unused locals.
2413 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2414 (composition_update_it): Mark var as initialized.
11b61122
PE
2415 (find_automatic_composition): Mark vars as initialized,
2416 with a FIXME (Bug#8290).
8f5201ae 2417
760fbc2c
PE
2418 character.h: Rename locals to avoid shadowing.
2419 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2420 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2421 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2422 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2423 to avoid shadowing.
2424
ff08eb85
PE
2425 * textprop.c (property_change_between_p): Remove; unused.
2426
fc7bf025
PE
2427 * intervals.c (interval_start_pos): Now static.
2428
235d7abc
PE
2429 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2430
44f230aa
SM
2431 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2432 Rename locals to avoid shadowing.
3e7d6594 2433
50060332
PE
2434 * sound.c (wav_play, au_play, Fplay_sound_internal):
2435 Fix pointer signedness.
d01f234b 2436 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2437 (wav_play): Initialize a variable to 0, to prevent undefined
2438 behavior (Bug#8278).
50060332 2439
c4fc4e30
PE
2440 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2441
918436ed
PE
2442 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2443
c939f91b
PE
2444 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2445 clobbering (Bug#8298).
b9c7f648
PE
2446 * sysdep.c (sys_subshell): Likewise.
2447 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2448
6bd8c144
PE
2449 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2450 This should get cleaned up, so that child_setup has the
2451 same signature on all platforms.
2452
7710357c 2453 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2454 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2455
c59da222
CY
24562011-03-22 Chong Yidong <cyd@stupidchicken.com>
2457
2458 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2459 not to be necessary, and produces flickering.
2460
66b87493
GM
24612011-03-20 Glenn Morris <rgm@gnu.org>
2462
2463 * config.in: Remove file.
2464
45b6f6d5
JB
24652011-03-20 Juanma Barranquero <lekktu@gmail.com>
2466
2467 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2468 are now in src/globals.h.
2469 (syms_of_minibuf): Remove spurious & from previous change.
2470
3ec03f7e
LL
24712011-03-20 Leo <sdl.web@gmail.com>
2472
2473 * minibuf.c (completing-read-function): New variable.
2474 (completing-read-default): Rename from completing-read.
2475 (completing-read): Call completing-read-function.
2476
b14e3e21
CY
24772011-03-19 Juanma Barranquero <lekktu@gmail.com>
2478
2479 * xfaces.c (Fx_load_color_file):
2480 Read color file from absolute filename (bug#8250).
2481
f2b726e6
JB
24822011-03-19 Juanma Barranquero <lekktu@gmail.com>
2483
2484 * makefile.w32-in: Update dependencies.
2485
09f6ff02
EZ
24862011-03-17 Eli Zaretskii <eliz@gnu.org>
2487
2488 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2489
29a6015a
PE
24902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2491
a3a6c54e
PE
2492 Fix more problems found by GCC 4.5.2's static checks.
2493
b766f867
PE
2494 * process.c (make_serial_process_unwind, send_process_trap):
2495 (sigchld_handler): Now static.
2496
be02381c
PE
2497 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2498 That way, the code declares only the vars that it needs.
2499 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2500 * s/cygwin.h (PTY_ITERATION): Likewise.
2501 * s/darwin.h (PTY_ITERATION): Likewise.
2502 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2503
57048744
PE
2504 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2505 * process.c (allocate_pty): Don't declare stb unless it's needed.
2506
7914961c 2507 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2508 (CONSTANTLIM): Remove; unused.
2509 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2510 Define only if needed.
7914961c 2511
b3967b18
PE
2512 * unexelf.c (unexec): Name an expression,
2513 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2514 Use a different way to cause a compilation error if anyone uses
2515 n rather than nn, a way that does not involve shadowing.
73366a00 2516 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2517
29a6015a
PE
2518 * deps.mk (unexalpha.o): Remove; unused.
2519
43cfc33e 2520 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2521 * unexec.h: New file.
ce701a33
PE
2522 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2523 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2524 Depend on unexec.h.
2525 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2526 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2527 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2528 Change as necessary to match prototype in unexec.h.
ce701a33 2529
01f44d5a
PE
2530 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2531 shadowing.
4f63c6bb 2532 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2533
a6670b0b
PE
2534 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2535 Rename locals to avoid shadowing.
2536
cef2010d 2537 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2538 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2539
d4d7173a
PE
2540 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2541
f08b802a
PE
2542 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2543 warning when compiling print.c.
2544
3ddb0639
PE
2545 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2546 instead of using an uninitialized var.
5ad03b97 2547 (font_sort_entities): Mark var as initialized.
3ddb0639 2548
170a2692
PE
2549 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2550
e663c700
PE
2551 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2552 pointers to constants.
89bc529a 2553 (font_parse_fcname): Remove unused vars.
7b81e2d0 2554 (font_delete_unmatched): Now static.
ea838e10 2555 (font_get_spec): Remove; unused.
13a547c6
PE
2556 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2557 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2558 Rename or move locals to avoid shadowing.
e663c700 2559
2a80c887 2560 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2561 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2562
1384fa33 2563 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2564 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2565
8b2c52e9
PE
2566 * alloc.c (mark_backtrace): Move decl from here ...
2567 * lisp.h: ... to here, so that it can be checked.
2568
475545b5 2569 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2570 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2571 (lisp_indirect_variable): Name an expression,
2572 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2573 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2574
b1349114 2575 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2576 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2577 Use const pointer when appropriate.
b1349114 2578
a2928364
PE
2579 * lisp.h (get_system_name, get_operating_system_release):
2580 Move decls here, to check interfaces.
2581 * process.c (get_operating_system_release): Move decl to lisp.h.
2582 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2583 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2584 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2585 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2586 (Fformat_time_string, Fencode_time, Finsert_char):
2587 (Ftranslate_region_internal, Fformat):
2588 Rename or remove local vars to avoid shadowing.
9710023e 2589 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2590
a415e694
PE
2591 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2592 avoid shadowing.
2593
8ef4622d
PE
2594 * lisp.h (eassert): Check that the argument compiles, even if
2595 ENABLE_CHECKING is not defined.
2596
946f9a5b
PE
2597 * data.c (Findirect_variable): Name an expression, to avoid
2598 gcc -Wbad-function-cast warning.
112396d6 2599 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2600 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2601 (Fmake_variable_buffer_local, Fmake_local_variable):
2602 Mark variables as initialized.
52746918 2603 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2604
e5aab7e7 2605 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2606 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2607 Rename locals to avoid shadowing.
dff45157
PE
2608 (mark_stack): Move local variables into the #ifdef region where
2609 they're used.
7bc26fdb
PE
2610 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2611 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2612 needed otherwise.
2613 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2614 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2615 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2616
e5aab7e7
PE
2617 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2618 avoids undefined behavior in theory.
2619
4da60324
PE
2620 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2621
88043301
PE
2622 Use functions, not macros, for up- and down-casing (Bug#8254).
2623 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2624 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2625 to use the following functions instead of these macros.
2626 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2627 EMACS_INT, since callers assume the returned value fits in int.
2628 (upcase1): Likewise, for UPCASE_TABLE.
2629 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2630 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2631 the race-condition problem in the old DOWNCASE.
88043301 2632
19ed5445
PE
2633 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2634 Rename locals to avoid shadowing.
2635 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2636 (regex_compile, re_search_2, re_match_2_internal):
2637 Remove unused local vars.
952db0d7
PE
2638 (FREE_VAR): Rewrite so as not to use empty "else",
2639 which gcc can warn about.
da053e48 2640 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2641 (RETALLOC_IF): Define only if needed.
2642 (WORDCHAR_P): Likewise. This one is never needed, but is used
2643 only in a comment talking about a compiler bug, so put inside
2644 the #if 0 of that comment.
2645 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2646 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2647 Remove; unused.
19ed5445 2648
1f3561e4 2649 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2650 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2651 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2652
ded6f8f7
PE
2653 * search.c (simple_search): Remove unused var.
2654
dbd37a95
PE
2655 * dired.c (compile_pattern): Move decl from here ...
2656 * lisp.h: ... to here, so that it can be checked.
2657 (struct re_registers): New forward decl.
2658
7e47afad
PE
2659 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2660
85f24f61
PE
2661 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2662 All uses changed.
2663 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2664 Rename locals to avoid shadowing.
5671df8f 2665 (Fvertical_motion): Mark locals as initialized.
85f24f61 2666
181aa2be 2667 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2668 (casify_region): Mark local as initialized.
181aa2be 2669
930d429c
PE
2670 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2671
7082eac6
PE
2672 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2673 New macros, so that the caller can use some names other than
2674 gcpro1, gcpro2, etc.
2675 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2676 of the new macros.
2677 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2678 argument, for consistency with GCPRO2_VAR, etc: it is now the
2679 prefix of the variable, not the variable itself. All uses
2680 changed.
38b2c076
PE
2681 * dired.c (directory_files_internal, file_name_completion):
2682 Rename locals to avoid shadowing.
2683
15206ed9
PE
2684 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2685 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2686 dired.c's scmp function, had undefined behavior.
2687 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2688 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2689 * buffer.h: ... to here, because these macros use current_buffer,
2690 and the new implementation with inline functions needs to have
2691 current_buffer in scope now, rather than later when the macros
2692 are used.
2693 (downcase, upcase1): New static inline functions.
2694 (DOWNCASE, UPCASE1): Reimplement using these functions.
2695 This avoids undefined behavior in expressions like
2696 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2697 from race conditions in accessing the global variables
2698 case_temp1 and case_temp2.
2699 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2700 * lisp.h (case_temp1, case_temp2): Remove their decls.
2701 * character.h (ASCII_CHAR_P): Move from here ...
2702 * lisp.h: ... to here, so that the inline functions mentioned
2703 above can use them.
2704
4a6bea26
PE
2705 * dired.c (directory_files_internal_unwind): Now static.
2706
f14b7e14
PE
2707 * fileio.c (file_name_as_directory, directory_file_name):
2708 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2709 Now static.
2893f146
PE
2710 (file_name_as_directory): Use const pointers when appropriate.
2711 (Fexpand_file_name): Likewise. In particular, newdir might
2712 point at constant storage, so make it a const pointer.
fd4ead52 2713 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2714 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2715 signedness issues.
f839df0c
PE
2716 (Fset_file_times, Finsert_file_contents, auto_save_error):
2717 Rename locals to avoid shadowing.
f14b7e14 2718
5716756e 2719 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2720 (Ftry_completion, Fall_completions): Rename or remove locals
2721 to avoid shadowing.
5716756e 2722
b4c3046a
PE
2723 * marker.c (bytepos_to_charpos): Remove; unused.
2724
b45db522
PE
2725 * lisp.h (verify_bytepos, count_markers): New decls,
2726 so that gcc does not warn that these functions aren't declared.
2727
85876d07
PE
2728 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2729 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2730 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2731 (copy_text): Remove unused local var.
85876d07 2732
03d78a21 2733 * filelock.c (within_one_second): Now static.
b3dd38ab 2734 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2735
5df8f01b
PE
2736 * buffer.c (fix_overlays_before): Mark locals as initialized.
2737 (fix_start_end_in_overlays): Likewise. This function should be
2738 simplified by using pointers-to-pointers, but that's a different
2739 matter.
b1d876f1 2740 (switch_to_buffer_1): Now static.
8f54f30a
PE
2741 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2742 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2743
a70072c9 2744 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2745 Fix pointer signedness issue.
edced198
PE
2746 (sys_subshell): Mark local as volatile if checking for lint,
2747 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2748 (MAXPATHLEN): Define only if needed.
a70072c9 2749
a0977c44
PE
2750 * process.c (serial_open, serial_configure): Move decls from here ...
2751 * systty.h: ... to here, so that they can be checked.
2752
a884fdcc
PE
2753 * fns.c (get_random, seed_random): Move extern decls from here ...
2754 * lisp.h: ... to here, so that they can be checked.
2755
604efe86 2756 * sysdep.c (reset_io): Now static.
b8950c94 2757 (wait_for_termination_signal): Remove; unused.
604efe86 2758
38fc62d9
PE
2759 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2760 (copy_keymap_item, append_key, push_text_char_description):
2761 Now static.
1004a21a 2762 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2763 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2764 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2765 (describe_map_tree):
2766 Rename locals to avoid shadowing.
38fc62d9 2767
2f2650da
PE
2768 * keyboard.c: Declare functions static if they are not used elsewhere.
2769 (echo_char, echo_dash, cmd_error, top_level_2):
2770 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2771 (read_char, kbd_buffer_get_event, make_lispy_position):
2772 (make_lispy_event, make_lispy_movement, apply_modifiers):
2773 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2774 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2775 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2776 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2777 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2778
a053e86c 2779 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2780 (mark_kboards): Move decl here ...
2781 * alloc.c (mark_kboards): ... from here.
a053e86c 2782
4752793e
PE
2783 * lisp.h (force_auto_save_soon): New decl.
2784
74f10ca7 2785 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2786 (DEFINE_DUMMY_FUNCTION): New macro.
2787 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2788 Use it.
c03cd23f
PE
2789 (main): Add casts to avoid warnings
2790 if GCC considers string literals to be constants.
74f10ca7 2791
022e70d4
PE
2792 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2793
59d6fe83
PE
2794 * dbusbind.c: Pointer signedness fixes.
2795 (xd_signature, xd_append_arg, xd_initialize):
2796 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2797 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2798 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2799 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2800
78320123
PE
2801 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2802 if GCC considers string literals to be constants.
49cebcca 2803 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2804
35ac2a97
SM
28052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2806
fb103ca9
SM
2807 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2808 (print_preprocess, print_object): New macro to fix last change.
2809
35ac2a97
SM
2810 * print.c (print_preprocess): Don't forget font objects.
2811
62973b41
JB
28122011-03-16 Juanma Barranquero <lekktu@gmail.com>
2813
2814 * emacs.c (USAGE3): Doc fixes.
2815
0e48bb22
AS
28162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2817
2818 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2819 structure.
2820
7684e57b
JB
28212011-03-14 Juanma Barranquero <lekktu@gmail.com>
2822
2823 * lisp.h (VWindow_system, Qfile_name_history):
2824 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2825 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2826 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2827
2828 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2829 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2830
2831 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2832 * w32console.c (detect_input_pending, read_input_pending)
2833 (encode_terminal_code):
2834 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2835 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2836 (w32_system_caret_y, Qfile_name_history):
2837 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2838 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2839 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2840 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2841 * w32proc.c (Qlocal, report_file_error):
2842 * w32term.c (Vwindow_system, updating_frame):
2843 * w32uniscribe.c (initialized, uniscribe_font_driver):
2844 Remove unneeded extern declarations.
2845
2aa46d6c
CY
28462011-03-14 Chong Yidong <cyd@stupidchicken.com>
2847
c96bbc66 2848 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2849
cffc6f3b
CY
28502011-03-13 Chong Yidong <cyd@stupidchicken.com>
2851
2852 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2853 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2854 These macros can no longer be used for assignment.
2855
44f230aa
SM
2856 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2857 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2858 (record_buffer_markers, fetch_buffer_markers): New functions for
2859 recording and fetching special buffer markers.
2860 (set_buffer_internal_1, set_buffer_temp): Use them.
2861
2862 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2863
2864 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2865
2866 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2867 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2868
2869 * xdisp.c (hscroll_window_tree):
2870 (reconsider_clip_changes): Use PT instead of BUF_PT.
2871
d251f04b
EZ
28722011-03-13 Eli Zaretskii <eliz@gnu.org>
2873
2874 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2875 $(EMACS_ROOT)/lib/intprops.h.
2876
f0c77cd1
PE
28772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2878
3eca4629
PE
2879 Fix more problems found by GCC 4.5.2's static checks.
2880
7c86ee98
PE
2881 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2882 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2883 (xg_free_frame_widgets): Make it clear that a local variable is
2884 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2885 (gdk_window_get_screen): Make it clear that this macro is needed
2886 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2887 (int_gtk_range_get_value): New function, which avoids a diagnostic
2888 from gcc -Wbad-function-cast.
2889 (xg_set_toolkit_scroll_bar_thumb): Use it.
2890 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2891 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2892 (get_utf8_string, xg_get_file_with_chooser):
2893 Rename locals to avoid shadowing.
2894 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2895
41729b81
PE
2896 * xgselect.c (xg_select): Remove unused var.
2897
f0c77cd1
PE
2898 * image.c (four_corners_best): Mark locals as initialized.
2899 (gif_load): Initialize transparent_p to zero (Bug#8238).
2900 Mark another local as initialized.
ec6cf4c6 2901 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2902
ce0ad53d 2903 * image.c (clear_image_cache): Now static.
d5d5a617 2904 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2905 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2906 (x_edge_detection): Remove unnecessary cast that
2907 gcc -Wbad-function-cast diagnoses.
2037898d 2908 (gif_load): Fix pointer signedness.
6ae141d6
PE
2909 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2910 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2911
33383987 29122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2913
d32df629
PE
2914 Improve quality of tests for time stamp overflow.
2915 For example, without this patch (encode-time 0 0 0 1 1
2916 1152921504606846976) returns the obviously-bogus value (-948597
2917 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2918 reports time overflow. See
2919 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2920 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2921 * editfns.c: Include limits.h and intprops.h.
2922 (TIME_T_MIN, TIME_T_MAX): New macros.
2923 (time_overflow): Move earlier, to before first use.
2924 (hi_time, lo_time): New functions, for an accurate test for
2925 out-of-range times.
2926 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2927 (Fget_internal_run_time): Don't assume time_t fits in int.
2928 (make_time): Use list2 instead of Fcons twice.
2929 (Fdecode_time): More accurate test for out-of-range times.
2930 (check_tm_member): New function.
2931 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2932 (lisp_time_argument): Don't rely on undefined left-shift and
2933 right-shift behavior when checking for time stamp overflow.
8be6f318 2934
fe31d94c
PE
2935 * editfns.c (time_overflow): New function, refactoring common code.
2936 (Fformat_time_string, Fdecode_time, Fencode_time):
2937 (Fcurrent_time_string): Use it.
2938
8be6f318
PE
2939 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2940 * dired.c (make_time): Move to ...
2941 * editfns.c (make_time): ... here.
2942 * systime.h: Note the move.
2943
09d9db2c 29442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2945
126bc0dc
YM
2946 * fringe.c (update_window_fringes): Remove unused variables.
2947
c47cbdfd
YM
2948 * unexmacosx.c (copy_data_segment): Also copy __got section.
2949 (Bug#8223)
2950
7ac80be9
EZ
29512011-03-12 Eli Zaretskii <eliz@gnu.org>
2952
c96bbc66 2953 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2954 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2955 Constify `char *' arguments and their references according to
2956 prototypes in tparam.h.
2957
ecb0f94d 2958 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2959
7ac80be9
EZ
2960 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2961 Adapt all references accordingly.
2962
2963 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2964
ef1fd07e
TT
29652011-03-11 Tom Tromey <tromey@redhat.com>
2966
2967 * buffer.c (syms_of_buffer): Remove obsolete comment.
2968
7ef4b50c
EZ
29692011-03-11 Eli Zaretskii <eliz@gnu.org>
2970
2971 * termhooks.h (encode_terminal_code): Declare prototype.
2972
2973 * msdos.c (encode_terminal_code): Don't declare prototype.
2974
2975 * term.c (encode_terminal_code): Now external again, used by
2976 w32console.c and msdos.c.
2977
44f230aa
SM
2978 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2979 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2980
4b1ec863 29812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2982
1714f52b 2983 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2984
4b1ec863
PE
2985 * fringe.c (update_window_fringes): Mark locals as initialized
2986 (Bug#8227).
2987 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2988
524c7aa6
PE
2989 * alloc.c (mark_fringe_data): Move decl from here ...
2990 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2991 to check its interface.
2992 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2993
a5c0af81 2994 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2995 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2996 (fontset_font): Mark local as initialized.
a9a06e0b 2997 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2998
b4716021
PE
2999 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3000
811e9bac 3001 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3002 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3003 (x_own_selection, Fx_disown_selection_internal): Rename locals
3004 to avoid shadowing.
3005 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3006
7e3ab302
PE
3007 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3008 so that the caller can use some name other than gcpro1.
3009 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3010 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3011 (Fx_backspace_delete_keys_p):
3012 Use them to avoid shadowing, and rename vars to avoid shadowing.
3013 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3014 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3015 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3016 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3017 Remove unused locals.
7e3ab302
PE
3018 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3019 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3020 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3021 macros.
f78faa98 3022
e2b13473
PE
3023 * xterm.h (x_mouse_leave): New decl.
3024
77f23912
PE
3025 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3026 Remove unused functions.
cdf4ba58
PE
3027 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3028 (x_calc_absolute_position): Now static.
7411c686 3029 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3030 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3031 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3032 unless they are used.
38d0b34a
PE
3033 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3034 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3035 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3036 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3037 (x_error_catcher, x_connection_closed, x_error_handler):
3038 (x_error_quitter, xembed_send_message, x_iconify_frame):
3039 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3040 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3041 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3042
44f230aa
SM
3043 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3044 Rename or move locals to avoid shadowing.
6b463e58 3045 (tty_defined_color, merge_face_heights): Now static.
5967d051 3046 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3047 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3048 does not deduce is never used uninitialized.
73719eba
PE
3049 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3050 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3051
426994c3 3052 * terminal.c (store_terminal_param): Now static.
5489860b 3053
032f1620 3054 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3055 (set_frame_menubar): Remove unused local.
d4323972 3056 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3057 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3058 since they might point to immutable storage.
281585b0
PE
3059 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3060 since it's unused otherwise.
032f1620 3061
367c19e5 3062 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3063 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3064 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3065 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3066 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3067 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3068 does not deduce are never used uninitialized.
70739cbe 3069
07b48fa9
PE
3070 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3071
8868a238 3072 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3073 * window.c (window_loop, size_window):
3074 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3075
7e5cf297 3076 * window.c (display_buffer): Now static.
d6550a9f
PE
3077 (size_window): Mark variables that gcc -Wuninitialized
3078 does not deduce are never used uninitialized.
a586633d
PE
3079 * window.h (check_all_windows): New decl, to forestall
3080 gcc -Wmissing-prototypes diagnostic.
5b555da1 3081 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3082
f6095868
PE
3083 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3084 shadowing.
3085 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3086 Include <limits.h>.
3087 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3088 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3089 (load_charset_map): Mark variables that gcc -Wuninitialized
3090 does not deduce are never used uninitialized.
53df7c11 3091 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3092
f38b440c
PE
3093 * coding.c (coding_set_source, coding_set_destination):
3094 Use "else { /* comment */ }" rather than "else /* comment */;"
3095 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3096 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3097 a block, when the outer 'i' will do.
3098 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3099 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3100 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3101 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3102 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3103 Rename locals to avoid shadowing.
3104 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3105 * coding.c (emacs_mule_char, encode_invocation_designation):
3106 Now static, since they're not used elsewhere.
413bb2db 3107 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3108 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3109 (decode_coding_emacs_mule): Mark variables that gcc
3110 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3111 (detect_coding_iso_2022): Initialize a local variable that might
3112 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3113 this initialization is needed. (Bug#8211)
5f58e762
PE
3114 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3115 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3116 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3117 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3118 Remove unused macros.
f38b440c 3119
232b38b9 3120 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3121 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3122 * character.c (string_count_byte8): Likewise.
232b38b9 3123
fb90da1b
PE
3124 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3125 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3126
fb93dbc2
PE
3127 * chartab.c (copy_sub_char_table): Now static, since it's not used
3128 elsewhere.
5c156ace
PE
3129 (sub_char_table_ref_and_range, char_table_ref_and_range):
3130 Rename locals to avoid shadowing.
bbcd0949 3131 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3132
7d3b3862 3133 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3134 (BIDI_BOB): Remove unused macro.
7d3b3862 3135
6be7d3da
PE
3136 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3137 deduce are never used uninitialized.
c2ed9c8b 3138 * term.c (encode_terminal_code): Likewise.
6be7d3da 3139
75f8807f 3140 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3141
50938595
PE
3142 * tparam.h: New file.
3143 * term.c, tparam.h: Include it.
3144 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3145 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3146 Move these decls to tparam.h, and make them agree with what
3147 is actually in tparam.c. The previous trick of using incompatible
3148 decls in different modules does not conform to the C standard.
3149 All callers of tparam changed to use tparam's actual API.
3150 * tparam.c (tparam1, tparam, tgoto):
3151 Use const pointers where appropriate.
3152
fbceeba2
PE
3153 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3154 * cm.h (struct cm): Likewise.
3155 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3156 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3157 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3158 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3159 (turn_on_face, init_tty): Likewise.
3160 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3161
7f3f1250
PE
3162 * term.c (term_mouse_position): Rename local to avoid shadowing.
3163
e6ca6543
PE
3164 * alloc.c (mark_ttys): Move decl from here ...
3165 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3166
c40f8d15
AS
31672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3168
3169 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3170
cfe0661d
JB
31712011-03-09 Juanma Barranquero <lekktu@gmail.com>
3172
3173 * search.c (compile_pattern_1): Remove argument regp, unused since
3174 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3175 (compile_pattern): Don't pass it.
3176
0afb4571
J
31772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3178
3179 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3180 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3181 for ! HAVE_GTK3.
3182 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3183
3184 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3185
3186 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3187 gdk_window_get_screen, gdk_window_get_geometry,
3188 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3189 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3190 (xg_get_pixbuf_from_pixmap): New function.
3191 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3192 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3193 Call xg_get_pixbuf_from_pixmap instead of
3194 gdk_pixbuf_get_from_drawable.
3195 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3196 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3197 (xg_check_special_colors): Use GtkStyleContext and its functions
3198 for HAVE_GTK3.
3199 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3200 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3201 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3202 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3203 Call gtk_widget_get_preferred_size.
0afb4571
J
3204 (xg_frame_resized): gdk_window_get_geometry only takes 5
3205 parameters.
44f230aa
SM
3206 (xg_win_to_widget, xg_event_is_for_menubar):
3207 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3208 (xg_set_widget_bg): New function.
3209 (delete_cb): New function.
895009e1 3210 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3211 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3212 (xg_set_background_color): Call xg_set_widget_bg.
3213 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3214 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3215 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3216 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3217 if ! HAVE_GTK3.
3218 (update_frame_tool_bar): Call gtk_widget_hide.
3219 (xg_initialize): Use GDK_KEY_g.
3220
3221 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3222 if ! HAVE_GTK3
3223 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3224
3225 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3226 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3227 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3228
1c2cc4ef
JB
32292011-03-08 Juanma Barranquero <lekktu@gmail.com>
3230
3231 * w32xfns.c (select_palette): Check success of RealizePalette against
3232 GDI_ERROR, not zero.
3233
33383987 3234See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3235
3236;; Local Variables:
3237;; coding: utf-8
aac0c6e3
MR
3238;; End:
3239
33383987 3240 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3241
3242 This file is part of GNU Emacs.
3243
3244 GNU Emacs is free software: you can redistribute it and/or modify
3245 it under the terms of the GNU General Public License as published by
3246 the Free Software Foundation, either version 3 of the License, or
3247 (at your option) any later version.
3248
3249 GNU Emacs is distributed in the hope that it will be useful,
3250 but WITHOUT ANY WARRANTY; without even the implied warranty of
3251 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3252 GNU General Public License for more details.
3253
3254 You should have received a copy of the GNU General Public License
3255 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.