* charset.c (read_hex): New arg OVERFLOW. All uses changed.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
caeeedc1
PE
12011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4 Remove unreachable code.
5 (read_hex, load_charset_map_from_file): Check for integer overflow.
6
b1f367f7 72011-07-17 Paul Eggert <eggert@cs.ucla.edu>
13464394 8
50849c52
PE
9 * xterm.c: don't go over XClientMessageEvent limit
10 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11 (x_send_scroll_bar_event): Likewise. Check that the size does not
12 exceed limits imposed by XClientMessageEvent, as well as the usual
13 ptrdiff_t and size_t limits.
14
b13995db
PE
15 * keyboard.c: Overflow, signedness and related fixes.
16 (make_lispy_movement): Use same integer type in forward decl
17 that is used in the definition.
18 (read_key_sequence, keyremap_step):
19 Change bufsize argument back to int, undoing my 2011-03-30 change.
20 We prefer signed types, and int is wide enough here.
21 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
22 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
23 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
24 length, not size_t. Use ptrdiff_t for index, not int.
25 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
26 possibility of integer overflow.
27
13464394
PE
28 Overflow, signedness and related fixes for images.
29
30 * dispextern.h (struct it.stack[0].u.image.image_id)
31 (struct_it.image_id, struct image.id, struct image_cache.size)
32 (struct image_cache.used, struct image_cache.ref_count):
33 * gtkutil.c (update_frame_tool_bar):
34 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
35 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
36 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
37 * nsmenu.m (update_frame_tool_bar):
38 * xdisp.c (calc_pixel_width_or_height):
39 * xfns.c (image_cache_refcount):
40 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
41 on typical 64-bit hosts.
42
43 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
44 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
45 Omit unnecessary casts to int.
46 (parse_image_spec): Check that integers fall into 'int' range
47 when the callers expect that.
48 (image_ascent): Redo ascent calculation to avoid int overflow.
49 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
50 (lookup_image): Remove unnecessary tests.
51 (xbm_image_p): Locals are now of int, not EMACS_INT,
52 since parse_image_check makes sure they fit into int.
53 (png_load, gif_load, svg_load_image):
54 Prefer int to unsigned where either will do.
55 (tiff_handler): New function, combining the cores of the
56 old tiff_error_handler and tiff_warning_handler. This
57 function is rewritten to use vsnprintf and thereby avoid
58 stack buffer overflows. It uses only the features of vsnprintf
59 that are common to both POSIX and native Microsoft.
60 (tiff_error_handler, tiff_warning_handler): Use it.
61 (tiff_load, gif_load, imagemagick_load_image):
62 Don't assume :index value fits in 'int'.
63 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
64 (imagemagick_load_image): Check that crop parameters fit into
65 the integer types that MagickCropImage accepts. Don't assume
66 Vimagemagick_render_type has a nonnegative value. Don't assume
67 size_t fits in 'long'.
68 (gs_load): Use printmax_t to print the widest integers possible.
69 Check for integer overflow when computing image height and width.
70
4f8a4547 712011-07-17 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 72
41f55ccd 73 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 74
39e378da
PE
75 * bidi.c: Integer size and overflow fixes.
76 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
77 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
78 (bidi_cache_find_level_change, bidi_cache_ensure_space)
79 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
80 (bidi_find_other_level_edge):
81 Use ptrdiff_t instead of EMACS_INT where either will do.
82 This works better on 32-bit hosts configured --with-wide-int.
83 (bidi_cache_ensure_space): Check for size-calculation overflow.
84 Use % rather than repeated addition, for better worst-case speed.
85 Don't set bidi_cache_size until after xrealloc returns, because it
86 might not return.
87 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
88 (bidi_cache_ensure_space): Also check that the bidi cache size
89 does not exceed that of the largest Lisp string or buffer. See Eli
90 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 91
5e927815
PE
92 * alloc.c (__malloc_size_t): Remove.
93 All uses replaced by size_t. See Andreas Schwab's note
94 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
95
ca4aa935
PE
96 * image.c: Improve checking for integer overflow.
97 (check_image_size): Assume that f is nonnull, since
98 it is always nonnull in practice. This is one less thing to
99 worry about when checking for integer overflow later.
100 (x_check_image_size): New function, which checks for integer
101 overflow issues inside X.
102 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
103 This removes the need for a memory_full check.
104 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
105 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
106 (xbm_read_bitmap_data): Change locals back to 'int', since
107 their values must fit in 'int'.
108 (xpm_load_image, png_load, tiff_load):
109 Invoke x_create_x_image_and_pixmap earlier,
110 to avoid much needless work if the image is too large.
111 (tiff_load): Treat overly large images as if
112 x_create_x_image_and_pixmap failed, not as malloc failures.
113 (gs_load): Use x_check_image_size.
114
5f8f9cc2
PE
115 * gtkutil.c: Omit integer casts.
116 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
117 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
118
5adf60bc
PE
119 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
120
c8907a93
PE
121 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
122 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
123 would wrongly return t on a 64-bit host.
124
e3c25c68
PE
125 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
126 The plain *_OVERFLOW macros run afoul of GCC bug 49705
127 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
128 and therefore cause GCC to emit a bogus diagnostic in some cases.
129
3f791afe
PE
130 * image.c: Integer signedness and overflow and related fixes.
131 This is not an exhaustive set of fixes, but it's time to
132 record what I've got.
133 (lookup_pixel_color, check_image_size): Remove redundant decls.
134 (check_image_size): Don't assume that arbitrary EMACS_INT values
135 fit in 'int', or that arbitrary 'double' values fit in 'int'.
136 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
137 (tiff_load, imagemagick_load_image):
138 Check for overflow in size calculations.
139 (x_create_x_image_and_pixmap): Remove unnecessary test for
140 xmalloc returning NULL; that can't happen.
141 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
142 (xpm_color_bucket): Use better integer hashing function.
143 (xpm_cache_color): Don't possibly over-allocate memory.
144 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
145 (gif_memory_source):
146 Use ptrdiff_t, not int or size_t, to record sizes.
147 (png_load): Don't assume values greater than 2**31 fit in 'int'.
148 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
149 either works, as we prefer signed integers.
150 (tiff_read_from_memory, tiff_write_from_memory):
151 Return tsize_t, not size_t, since that's what the TIFF API wants.
152 (tiff_read_from_memory): Don't fail simply because the read would
153 go past EOF; instead, return a short read.
154 (tiff_load): Omit no-longer-needed casts.
155 (Fimagemagick_types): Don't assume size fits into 'int'.
156
3cc5a532
PE
157 Improve hashing quality when configured --with-wide-int.
158 * fns.c (hash_string): New function, taken from sxhash_string.
159 Do not discard information about ASCII character case; this
160 discarding is no longer needed.
161 (sxhash-string): Use it. Change sig to match it. Caller changed.
162 * lisp.h: Declare it.
163 * lread.c (hash_string): Remove, since we now use fns.c's version.
164 The fns.c version returns a wider integer if --with-wide-int is
165 specified, so this should help the quality of the hashing a bit.
166
b312a492
PE
167 * emacs.c: Integer overflow minor fix.
168 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
169 Define only if GNU_LINUX.
170 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
171
dfd153ae
PE
172 * dispnew.c: Integer signedness and overflow fixes.
173 Remove unnecessary forward decls, that were a maintenance hassle.
174 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
175 All uses changed.
176 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
177 (scrolling_window): Use ptrdiff_t, not int, for byte count.
178 (prepare_desired_row, line_draw_cost):
179 Use int, not unsigned, where either works.
180 (save_current_matrix, restore_current_matrix):
181 Use ptrdiff_t, not size_t, where either works.
182 (init_display): Check for overflow more accurately, and without
183 relying on undefined behavior.
184
a81d11a3
PE
185 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
186 Remove, replacing with the new symbols in lisp.h. All uses changed.
187 * fileio.c (make_temp_name):
188 * filelock.c (lock_file_1, lock_file):
189 * xdisp.c (message_dolog):
190 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
191 Use pMd etc. instead.
192 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
193 replacing the pWIDE etc. symbols removed from editfns.c.
194
3300e6fd
PE
195 * keyboard.h (num_input_events): Now uintmax_t.
196 This is (very slightly) less likely to mess up due to wraparound.
197 All uses changed.
198
fd05c7e9
PE
199 * buffer.c: Integer signedness fixes.
200 (alloc_buffer_text, enlarge_buffer_text):
201 Use ptrdiff_t rather than size_t when either will do, as we prefer
202 signed integers.
203
903fe15d
PE
204 * alloc.c: Integer signedness and overflow fixes.
205 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
206 (__malloc_size_t): Default to size_t, not to int.
207 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
208 (Fgarbage_collect, mark_object_loop_halt, mark_object):
209 Prefer ptrdiff_t to size_t when either would do, as we prefer
210 signed integers.
211 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
212 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
213 Now const. Initialize with values that are in range even if char
214 is signed.
215 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
216 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
217 These functions do the right thing with sizes > 2**32.
218 (check_depth): Now ptrdiff_t, not int.
219 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
220 Adjust to new way of storing sizes. Check for size overflow bugs
221 in rest of code.
222 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
223 slightly wrong anyway, as it missed one instance of
224 XMALLOC_OVERRUN_CHECK_OVERHEAD.
225 (refill_memory_reserve): Omit needless cast to size_t.
226 (mark_object_loop_halt): Mark as externally visible.
227
ac82cc6a
PE
228 * xselect.c: Integer signedness and overflow fixes.
229 (Fx_register_dnd_atom, x_handle_dnd_message):
230 Use ptrdiff_t, not size_t, since we prefer signed.
231 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
232 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
233 x_dnd_atoms_size and x_dnd_atoms_length.
234
c2d1e36d
PE
235 * doprnt.c: Prefer signed to unsigned when either works.
236 * eval.c (verror):
237 * doprnt.c (doprnt):
238 * lisp.h (doprnt):
239 * xdisp.c (vmessage):
240 Use ptrdiff_t, not size_t, when using or implementing doprnt,
241 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
242 prefer signed arithmetic to avoid comparison confusion.
243 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
244 but is a bit tricky.
245
0e926e56
PE
246 Assume freestanding C89 headers, string.h, stdlib.h.
247 * data.c, doprnt.c, floatfns.c, print.c:
248 Include float.h unconditionally.
249 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
250 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
251 * regex.c: Likewise for stddef.h, string.h.
252 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
253 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
254 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
255 (STDC_HEADERS): Remove obsolete defines.
256 * sysdep.c: Include limits.h unconditionally.
257
9cfdb3ec
PE
258 Assume support for memcmp, memcpy, memmove, memset.
259 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
260 * regex.c (memcmp, memcpy):
261 Remove; we assume C89 now.
262
263 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
264 (__malloc_safe_bcopy): Remove; no longer needed.
265
cf950e6b 266 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
267 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
268 well either way, and we prefer signed to unsigned.
269
9e381cdd
PE
2702011-07-17 Paul Eggert <eggert@cs.ucla.edu>
271
272 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
273 This works around a problem with the previous change to Fcopy_file.
274 Recent glibc declares fchown with __attribute__((warn_unused_result)),
275 and without this change, GCC might complain about discarding
276 fchown's return value.
277
b5641435
JB
2782011-07-16 Juanma Barranquero <lekktu@gmail.com>
279
280 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
281
a8031457
PE
2822011-07-16 Paul Eggert <eggert@cs.ucla.edu>
283
284 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
285
dd889327
LMI
2862011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
287
750c33f7
LMI
288 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
289 it's used from the C level.
290
dd889327
LMI
291 * process.c: Use the same condition for POLL_FOR_INPUT in both
292 keyboard.c and process.c (bug#1858).
293
87e86684
LM
2942011-07-09 Lawrence Mitchell <wence@gmx.li>
295
296 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
297 (Fgnutls_boot): Use it.
298
64348f40
AS
2992011-07-15 Andreas Schwab <schwab@linux-m68k.org>
300
301 * doc.c (Fsubstitute_command_keys): Revert last change.
302
1d698799
LMI
3032011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
304
f863868c
LMI
305 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
306 quotes the next character, and doesn't affect other longer
307 sequences (bug#8935).
308
1d698799
LMI
309 * lread.c (syms_of_lread): Clarify that is isn't only
310 `eval-buffer' and `eval-defun' that's affected by
311 `lexical-binding' (bug#8460).
312
aa4b6df6
EZ
3132011-07-15 Eli Zaretskii <eliz@gnu.org>
314
315 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
316 bidi redisplay when a line includes both an image and is
317 truncated.
318
5d856da6
PE
3192011-07-14 Paul Eggert <eggert@cs.ucla.edu>
320
ad6042bb
PE
321 Fix minor problems found by static checking.
322 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
323 (elsz): Now a signed constant, not a size_t var. We prefer signed
324 types to unsigned, to avoid integer comparison confusion. Without
325 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
326 "cannot optimize loop, the loop counter may overflow", a symptom
327 of the confusion.
f00bbb22 328 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
329 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
330
6468f31c
LMI
3312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
332
49080b10
LMI
333 * search.c (Fre_search_backward): Mention `case-fold-search' in
334 all the re_search_* functions (bug#8138).
335
6468f31c
LMI
336 * keyboard.c (Fopen_dribble_file): Document when the file is
337 closed (bug#8056).
338
c965adc5
EZ
3392011-07-14 Eli Zaretskii <eliz@gnu.org>
340
df9733bf
EZ
341 * bidi.c (bidi_dump_cached_states): Fix format of displaying
342 bidi_cache_idx.
343
0bb23927
EZ
344 Support bidi reordering of display and overlay strings.
345 * xdisp.c (compute_display_string_pos)
346 (compute_display_string_end): Accept additional argument STRING.
347 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
348 (reseat_to_string): Initialize bidi_it->string.s and
349 bidi_it->string.schars.
350 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
351 NULL (avoids a crash in bidi_paragraph_init). Initialize
352 itb.string.lstring.
353 (init_iterator): Call bidi_init_it only of a valid
354 buffer position was specified. Initialize paragraph_embedding to
355 L2R.
356 (reseat_to_string): Initialize the bidi iterator.
357 (display_string): If we need to ignore text properties of
358 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
359 original value of -1 will not work with bidi.)
360 (compute_display_string_pos): First arg is now struct
361 `text_pos *'; all callers changed. Support display properties on
362 Lisp strings.
363 (compute_display_string_end): Support display properties on Lisp
364 strings.
365 (init_iterator, reseat_1, reseat_to_string): Initialize the
366 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
367 when iterating on a string not from display properties).
368 (compute_display_string_pos, compute_display_string_end): Fix
369 calculation of the object to scan. Fixes an error when using
370 arrow keys.
371 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
372 base_level_stop; instead, set base_level_stop to BEGV. Fixes
373 crashes in vertical-motion.
374 (next_element_from_buffer): Improve commentary for when
375 the iterator is before prev_stop.
376 (init_iterator): Initialize bidi_p from the default value of
377 bidi-display-reordering, not from buffer-local value. Use the
378 buffer-local value only if initializing for buffer iteration.
379 (handle_invisible_prop): Support invisible properties on strings
380 that are being bidi-reordered.
381 (set_iterator_to_next): Support bidi reordering of C strings and
382 Lisp strings.
383 (next_element_from_string): Support bidi reordering of Lisp
384 strings.
385 (handle_stop_backwards): Support Lisp strings as well.
386 (display_string): Support display of R2L glyph rows. Use
387 IT_STRING_CHARPOS when displaying from a Lisp string.
388 (init_iterator): Don't initialize it->bidi_p for strings
389 here.
390 (reseat_to_string): Initialize it->bidi_p for strings here.
391 (next_element_from_string, next_element_from_c_string)
392 (next_element_from_buffer): Add xassert's for correspondence
393 between IT's object being iterated and it->bidi_it.string
394 structure.
395 (face_before_or_after_it_pos): Support bidi iteration.
396 (next_element_from_c_string): Handle the case of the first string
397 character that is not the first one in the visual order.
398 (get_visually_first_element): New function, refactored from common
399 parts of next_element_from_buffer, next_element_from_string, and
400 next_element_from_c_string.
401 (tool_bar_lines_needed, redisplay_tool_bar)
402 (display_menu_bar): Force left-to-right direction. Add a FIXME
403 comment for making that be controlled by a user option.
404 (push_it, pop_it): Save and restore the state of the
405 bidi iterator. Save and restore the bidi_p flag.
406 (pop_it): Iterate out of display property for string iteration as
407 well.
408 (iterate_out_of_display_property): Support iteration over strings.
409 (handle_single_display_spec): Set up it->bidi_it for iteration
410 over a display string, and call bidi_init_it.
411 (handle_single_display_spec, next_overlay_string)
412 (get_overlay_strings_1, push_display_prop): Set up the bidi
413 iterator for displaying display or overlay strings.
414 (forward_to_next_line_start): Don't use the shortcut if
415 bidi-iterating.
416 (back_to_previous_visible_line_start): If handle_display_prop
417 pushed the iterator stack, restore the internal state of the bidi
418 iterator by calling bidi_pop_it same number of times.
419 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
420 and we are bidi-iterating, don't decrement the iterator position;
421 instead, set the first_elt flag in the bidi iterator, to produce
422 the same effect.
423 (reseat_1): Remove redundant setting of string_from_display_prop_p.
424 (push_display_prop): xassert that we are iterating a buffer.
425 (push_it, pop_it): Save and restore paragraph_embedding member.
426 (handle_single_display_spec, next_overlay_string)
427 (get_overlay_strings_1, reseat_1, reseat_to_string)
428 (push_display_prop): Set up the `unibyte' member of bidi_it.string
429 correctly. Don't assume unibyte strings are not bidi-reordered.
430 (compute_display_string_pos)
431 (compute_display_string_end): Fix handling the case of C string.
432 (push_it, pop_it): Save and restore from_disp_prop_p.
433 (handle_single_display_spec, push_display_prop): Set the
434 from_disp_prop_p flag.
435 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
436 (pop_it): Call iterate_out_of_display_property only if we are
437 popping after iteration over a string that came from a display
438 property. Fix a typo in popping stretch info. Add an assertion
439 for verifying that the iterator position is in sync with the bidi
440 iterator.
441 (handle_single_display_spec, get_overlay_strings_1)
442 (push_display_prop): Fix initialization of paragraph direction for
443 string when that of the parent object is not yet determined.
444 (reseat_1): Call bidi_init_it to resync the bidi
445 iterator with IT's position. (Bug#7616)
446 (find_row_edges): If ROW->start.pos gives position
447 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
448 (handle_stop, back_to_previous_visible_line_start, reseat_1):
449 Reset the from_disp_prop_p flag.
450 (SAVE_IT, RESTORE_IT): New macros.
451 (pos_visible_p, face_before_or_after_it_pos)
452 (back_to_previous_visible_line_start)
453 (move_it_in_display_line_to, move_it_in_display_line)
454 (move_it_to, move_it_vertically_backward, move_it_by_lines)
455 (try_scrolling, redisplay_window, display_line): Use them when
456 saving a temporary copy of the iterator and restoring it back.
457 (back_to_previous_visible_line_start, reseat_1)
458 (init_iterator): Empty the bidi cache "stack".
459 (move_it_in_display_line_to): If iterator ended up at
460 EOL, but we never saw any buffer positions smaller than
461 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
462 motion in bidi-reordered lines.
463 (move_it_in_display_line_to): Record prev_method and prev_pos
464 immediately before the call to set_iterator_to_next. Fixes cursor
465 motion in bidi-reordered lines with stretch glyphs and strings
466 displayed in margins. (Bug#8133) (Bug#8867)
467 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
468 TO_CHARPOS.
469 (pos_visible_p): Support positions in bidi-reordered lines. Save
470 and restore bidi cache.
471
472 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
473 (bidi_paragraph_info): Delete unused struct.
474 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
475 (bidi_cache_start): New variable.
476 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
477 to zero.
478 (bidi_cache_fetch_state, bidi_cache_search)
479 (bidi_cache_find_level_change, bidi_cache_iterator_state)
480 (bidi_cache_find, bidi_peek_at_next_level)
481 (bidi_level_of_next_char, bidi_find_other_level_edge)
482 (bidi_move_to_visually_next): Compare cache index with
483 bidi_cache_start rather than with zero.
484 (bidi_fetch_char): Accept new argument STRING; all callers
485 changed. Support iteration over a string. Support strings with
486 display properties. Support unibyte strings. Fix the type of
487 `len' according to what STRING_CHAR_AND_LENGTH expects.
488 (bidi_paragraph_init, bidi_resolve_explicit_1)
489 (bidi_resolve_explicit, bidi_resolve_weak)
490 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
491 iteration over a string.
492 (bidi_set_sor_type, bidi_resolve_explicit_1)
493 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
494 can now be zero (for strings); special values 0 and -1 were
495 changed to -1 and -2, respectively.
496 (bidi_char_at_pos): New function.
497 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
498 Call it instead of FETCH_MULTIBYTE_CHAR.
499 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
500 initialized to valid values.
501 (bidi_init_it): Don't initialize charpos and bytepos with invalid
502 values.
503 (bidi_level_of_next_char): Allow the sentinel "position" to pass
504 the test for valid cached positions. Fix the logic for looking up
505 the sentinel state in the cache. GCPRO the Lisp string we are
506 iterating.
507 (bidi_push_it, bidi_pop_it): New functions.
508 (bidi_initialize): Initialize the bidi cache start stack pointer.
509 (bidi_cache_ensure_space): New function, refactored from part of
510 bidi_cache_iterator_state. Don't assume the required size is just
511 one BIDI_CACHE_CHUNK away.
512 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
513 (bidi_count_bytes, bidi_char_at_pos): New functions.
514 (bidi_cache_search): Don't assume bidi_cache_last_idx is
515 always valid if bidi_cache_idx is valid.
516 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
517 is valid if it's going to be used.
518 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
519 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
520 (bidi_cache_find_level_change, bidi_cache_ensure_space)
521 (bidi_cache_iterator_state, bidi_cache_find)
522 (bidi_find_other_level_edge, bidi_cache_start_stack): All
523 variables related to cache indices are now EMACS_INT.
524
0bb23927
EZ
525 * dispextern.h (struct bidi_string_data): New structure.
526 (struct bidi_it): New member `string'. Make flag members be 1-bit
527 fields, and put them last in the struct.
528 (compute_display_string_pos, compute_display_string_end): Update
529 prototypes.
530 (bidi_push_it, bidi_pop_it): Add prototypes.
531 (struct iterator_stack_entry): New members bidi_p,
532 paragraph_embedding, and from_disp_prop_p.
533 (struct it): Member bidi_p is now a bit field 1 bit wide.
534 (bidi_shelve_cache, bidi_unshelve_cache): Declare
535 prototypes.
536
537 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
538 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
539 and vector-like objects.
540
541 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
542 cache around display iteration.
543
544 * window.c (Fwindow_end, window_scroll_pixel_based)
545 (displayed_window_lines, Frecenter): Save and restore the bidi
546 cache around display iteration.
547
3bbd2265
LMI
5482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
549
550 * editfns.c (Fdelete_region): Clarify the use of the named
551 parameters (bug#6788).
552
adc47434
MR
5532011-07-14 Martin Rudalics <rudalics@gmx.at>
554
555 * indent.c (Fvertical_motion): Set and restore w->pointm when
556 saving and restoring the window's buffer (Bug#9006).
557
837c31f8
LMI
5582011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
559
560 * editfns.c (Fstring_to_char): Clarify just what is returned
561 (bug#6576). Text by Eli Zaretskii.
562
ac389d0c
JB
5632011-07-13 Juanma Barranquero <lekktu@gmail.com>
564
565 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
566
0be0ce47
EZ
5672011-07-13 Eli Zaretskii <eliz@gnu.org>
568
569 * buffer.c (mmap_find): Fix a typo.
570
cd18e7e3
JB
5712011-07-13 Johan Bockgård <bojohan@gnu.org>
572
573 Fix execution of x selection hooks.
574 * xselect.c (Qx_lost_selection_functions)
575 (Qx_sent_selection_functions): New vars.
576 (syms_of_xselect): DEFSYM them.
577 (x_handle_selection_request): Pass Qx_sent_selection_functions
578 rather than Vx_sent_selection_functions to Frun_hook_with_args.
579 (x_handle_selection_clear,x_clear_frame_selections):
580 Pass Qx_lost_selection_functions rather than
581 Vx_lost_selection_functions to Frun_hook_with_args.
582
47ea7f44
PE
5832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
584
ac389d0c 585 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
586 The old code sometimes used this field without initializing it.
587
47ea7f44
PE
588 * alloc.c (gc_sweep): Don't read past end of array.
589 In theory, the old code could also have corrupted Emacs internals,
590 though it'd be very unlikely.
591
bc985c87
AS
5922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
593
594 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 595 argument. (Bug#4026)
bc985c87 596
0cf34688
LMI
5972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
598
b3dadd76
LMI
599 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
600 key" (bug#4257).
601
0cf34688
LMI
602 * window.c (Fset_window_start): Doc fix (bug#4199).
603 (Fset_window_hscroll): Ditto.
604
270768cd
PE
6052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
606
077e3dda 607 Fix minor new problems caught by GCC 4.6.1.
270768cd 608 * term.c (init_tty): Remove unused local.
490011a6 609 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 610 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 611 not used otherwise.
270768cd 612
b1f58454
CY
6132011-07-12 Chong Yidong <cyd@stupidchicken.com>
614
615 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
616
22b9578d
LMI
6172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
618
6e70ab07
LMI
619 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
620 are the mini-buffer and the echo area (bug#3320).
621
22b9578d
LMI
622 * term.c (init_tty): Remove support for supdup, c10 and perq
623 terminals, which are no longer supported (bug#1482).
624
8974cc9f
JB
6252011-07-10 Johan Bockgård <bojohan@gnu.org>
626
627 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
628
a560d974
JD
6292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
630
631 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
632 for non-popups (Bug#3642).
633
1dae0f0a
AS
6342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
635
268c2c36 636 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 637 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
638 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
639 * cm.c (losecursor): Likewise.
1dae0f0a
AS
640 * data.c (fmod): Likewise.
641 * dispnew.c (swap_glyphs_in_rows): Likewise.
642 * emacs.c (memory_warning_signal): Likewise.
643 * floatfns.c (float_error): Likewise.
644 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
645 (otf_open, font_otf_capability, generate_otf_features)
646 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
647 Likewise.
648 * image.c (pbm_read_file): Likewise.
649 * indent.c (string_display_width): Likewise.
650 * intervals.c (check_for_interval, search_for_interval)
651 (inc_interval_count, count_intervals, root_interval)
652 (adjust_intervals_for_insertion, make_new_interval): Likewise.
653 * lread.c (defalias): Likewise.
268c2c36 654 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
655 * regex.c (set_image_of_range_1, set_image_of_range)
656 (regex_grow_registers): Likewise.
657 * sysdep.c (strerror): Likewise.
658 * termcap.c (valid_filename_p, tprint, main): Likewise.
659 * tparam.c (main): Likewise.
660 * unexhp9k800.c (run_time_remap, save_data_space)
661 (update_file_ptrs, read_header, write_header, calculate_checksum)
662 (copy_file, copy_rest, display_header): Likewise.
663 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
664 Likewise.
665 * xdisp.c (check_it): Likewise.
666 * xfaces.c (register_color, unregister_color, unregister_colors):
667 Likewise.
668 * xfns.c (print_fontset_result): Likewise.
669 * xrdb.c (member, fatal, main): Likewise.
670
99033785
PE
6712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
672
673 Fix minor problems found by static checking (Bug#9031).
674 * chartab.c (char_table_set_range, map_sub_char_table):
675 Remove unused locals.
676 (uniprop_table): Now static.
677 * composite.c (_work_char): Remove unused static var.
678
9cb2ac56
JB
6792011-07-09 Juanma Barranquero <lekktu@gmail.com>
680
681 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
682
f25661f0
JD
6832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
684
685 * gtkutil.c (qttip_cb): Remove code without function.
686
8278c4fe
EZ
6872011-07-09 Eli Zaretskii <eliz@gnu.org>
688
689 * w32.c (pthread_sigmask): New stub.
690
1692ae2d 6912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 692
8a6ebd58 693 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
694 sigprocmask is portable only for single-threaded applications, and
695 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
696 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
697 (LIBES): Use it.
698 * callproc.c (Fcall_process):
699 * process.c (create_process):
700 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
701 Use pthread_sigmask, not sigprocmask.
123403e4 702
1b854618
JD
7032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
704
705 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
706 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
707 wrong (Bug#8591).
708
3fe4b549
JD
7092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
710
0ce7e563
JD
711 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
712 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
713 (xg_hide_tooltip): Fix comment.
714
3fe4b549
JD
715 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
716 in registerServicesMenuSendTypes.
717 (validRequestorForSendType): Don't check ns_return_types.
718
719 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
720 ns_return_type.
721
5df75e47
JR
7222011-07-08 Jason Rumney <jasonr@gnu.org>
723
724 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
725 frame struct members of non-existent frames (Bug#6284).
726
699c10bd
JD
7272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
728
4393663b
JD
729 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
730 variable firstTime not needed on OSX >= 10.6.
731 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
732 >= 10.5. Use setKnobProportion, setDoubleValue.
733
734 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
735 (MAC_OS_X_VERSION_10_5): Define if not defined.
736 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
737 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
738 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
739
740 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
741 cString and lossyCString on OSX >= 10.4
742
743 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
744 sizeToFit on OSX >= 10.2.
745
746 * nsimage.m (allocInitFromFile): Don't use deprecated method
747 bestRepresentationForDevice on OSX >= 10.6.
748
749 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
750 to avoid warning.
751
752 * emacs.c: Declare unexec_init_emacs_zone.
753
a63e0781
JD
754 * nsgui.h: Fix compiler warning about gnulib redefining verify.
755
699c10bd
JD
756 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
757
758 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
759 on svcsMenu (Bug#8842).
760
761 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
762 ns_return_types.
763 (Fns_list_services): Just return Qnil on 10.6, code not working there.
764
765 * nsterm.m (QUTF8_STRING): Declare.
766 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
767 (validRequestorForSendType): Return type is (id).
768 Change indexOfObjectIdenticalTo to indexOfObject.
769 Check if we have local selection before returning self (Bug#8842).
770 (writeSelectionToPasteboard): Put local selection into paste board
771 if we have a local selection (Bug#8842).
772 (syms_of_nsterm): DEFSYM QUTF8_STRING.
773
774 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
775 (ns_get_local_selection): Declare.
776
54e10184
LMI
7772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
778
9888ff71
LMI
779 * keymap.c (describe_map_tree): Don't insert a double newline at
780 the end of the buffer (bug#1169) and return whether we inserted
781 something.
782
54e10184
LMI
783 * callint.c (Fcall_interactively): Change "reading args" to
784 "providing args" to try to clarify what it does (bug#1010).
785
15fa4783
KH
7862011-07-07 Kenichi Handa <handa@m17n.org>
787
788 * composite.c (composition_compute_stop_pos): Ignore a static
789 composition starting before CHARPOS (Bug#8915).
790
791 * xdisp.c (handle_composition_prop): Likewise.
792
a8815b00
EZ
7932011-07-07 Eli Zaretskii <eliz@gnu.org>
794
795 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
796 (Bug#9015)
797
ef7b981d 7982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
799
800 * character.h (unicode_category_t): New enum type.
801
802 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
803 (Qchar_code_property_table): New variable.
804 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
805 (UNIPROP_COMPRESSED_FORM_P): New macros.
806 (char_table_ascii): Uncompress the compressed values.
807 (sub_char_table_ref): New arg is_uniprop. Callers changed.
808 Uncompress the compressed values.
ac389d0c 809 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
810 (char_table_ref_and_range): Uncompress the compressed values.
811 (sub_char_table_set): New arg is_uniprop. Callers changed.
812 Uncompress the compressed values.
813 (sub_char_table_set_range): Args changed. Callers changed.
814 (char_table_set_range): Adjuted for the above change.
815 (map_sub_char_table): Delete args default_val and parent. Add arg
816 top. Give decoded values to a Lisp function.
817 (map_char_table): Adjusted for the above change. Give decoded
818 values to a Lisp function. Gcpro more variables.
819 (uniprop_table_uncompress)
820 (uniprop_decode_value_run_length): New functions.
821 (uniprop_decoder, uniprop_decoder_count): New variables.
822 (uniprop_get_decoder, uniprop_encode_value_character)
823 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
824 New functions.
825 (uniprop_encoder, uniprop_encoder_count): New variables.
826 (uniprop_get_encoder, uniprop_table)
827 (Funicode_property_table_internal, Fget_unicode_property_internal)
828 (Fput_unicode_property_internal): New functions.
829 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
830 Sunicode_property_table_internal, Sget_unicode_property_internal,
831 and Sput_unicode_property_internal. Defvar_lisp
832 char-code-property-alist.
833
834 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
835 Vunicode_category_table.
836
837 * font.c (font_range): Adjusted for the change of
838 Vunicode_category_table.
839
76b397fb
DN
8402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
841
842 * m/iris4d.h: Remove file, move contents ...
843 * s/irix6-5.h: ... here.
844
22b4128e
PE
8452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
846
847 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
848 * alloc.c (mark_buffer):
849 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
850 (clone_per_buffer_values): Don't assume that
22b4128e
PE
851 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
852 This isn't true in general, and it's particularly not true
853 if Emacs is configured with --with-wide-int.
854 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
855 New macros, used in the buffer.c change.
856
869795d6
JD
8572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
858
859 * xsettings.c: Use both GConf and GSettings if both are available.
860 (store_config_changed_event): Add comment.
861 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
862 (store_tool_bar_style_changed): New functions.
863 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
864 (struct xsettings): Move font inside HAVE_XFT.
865 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
866 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
867 Move inside HAVE_XFT.
868 (something_changed_gsettingsCB): Renamed from something_changedCB.
869 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
870 also.
871 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
872 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
873 (something_changed_gconfCB): Renamed from something_changedCB.
874 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
875 (parse_settings): Move check for font inside HAVE_XFT.
876 (read_settings, apply_xft_settings): Add comment.
877 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
878 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
879 call store_font_name_changed.
880 (xft_settings_event): Add comment.
881 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
882 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
883 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
884 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
885 (xsettings_initialize): Call init_gsettings last.
886 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
887 comment.
888
d8ed26bd
PE
8892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
890
891 Random fixes. E.g., (random) never returned negative values.
892 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
893 subseconds part to the entropy, as that's a bit more random.
894 Prefer signed to unsigned, since the signedness doesn't matter and
895 in general we prefer signed. When given a limit, use a
896 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
897 latter isn't right if USE_2_TAGS_FOR_INTS.
898 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
899 not 0..VALMASK. Don't discard "excess" bits that random () returns.
900
cabf1cac
SM
9012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
902
903 * textprop.c (text_property_stickiness):
904 Obey Vtext_property_default_nonsticky.
905 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
906 * w32fns.c (syms_of_w32fns):
907 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
908
6e9b2be9
PE
9092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
910
911 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
912 This is more efficient than Ffile_directory_p and avoids a minor race.
913
90186c68
LMI
9142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
915
7c301272
LMI
916 * buffer.c (Foverlay_put): Say what the return value is
917 (bug#7835).
918
c4f2d8d4
LMI
919 * fileio.c (barf_or_query_if_file_exists): Check first if the file
920 is a directory before asking whether to use the file name
921 (bug#7564).
ad637907
LMI
922 (barf_or_query_if_file_exists): Make the "File is a directory"
923 error be more correct.
c4f2d8d4 924
90186c68
LMI
925 * fns.c (Frequire): Remove the mention of the .gz files, since
926 that's installation-specific, but keep the mention of
927 `get-load-suffixes'.
928
da64016e
PE
9292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
930
931 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
932 Report string overflow if the output is too long.
933
7d47b580
JB
9342011-07-04 Juanma Barranquero <lekktu@gmail.com>
935
a555cb87
JB
936 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
937 (syms_of_gnutls): Remove duplicate DEFSYM for
938 Qgnutls_bootprop_verify_hostname_error, an error for
939 Qgnutls_bootprop_verify_error (which is no longer used).
940
7d47b580
JB
941 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
942 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
943 Also (re)move comments that are misplaced or no longer relevant.
944
1e49bfab
LMI
9452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
946
947 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
948
1485f4c0
CY
9492011-07-03 Chong Yidong <cyd@stupidchicken.com>
950
951 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
952 and background color parameters if they have been changed.
953
a9ab721e
LMI
9542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
955
956 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
957
cf7cff57
PE
9582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
959
2e13213d
PE
960 * xsettings.c (SYSTEM_FONT): Define only when used.
961 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
962
cf7cff57
PE
963 * keymap.c (access_keymap_1): Now static.
964
7a8e04f7
CY
9652011-07-02 Chong Yidong <cyd@stupidchicken.com>
966
967 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
968 leave any prefix arg for the up event (Bug#1586).
969
61352f62
LMI
9702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
971
69bb1ef7
LMI
972 * lread.c (syms_of_lread): Mention single symbols defined by
973 `defvar' or `defconst' (bug#7154).
974
61352f62 975 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 976 (Frequire): Mention get-load-suffixes.
61352f62 977
28545e04
MR
9782011-07-02 Martin Rudalics <rudalics@gmx.at>
979
980 * window.h (window): Remove clone_number slot.
981 * window.c (Fwindow_clone_number, Fset_window_clone_number):
982 Remove.
983 (make_parent_window, make_window, saved_window)
984 (Fset_window_configuration, save_window_save): Don't deal with
985 clone numbers.
986 * buffer.c (Qclone_number): Remove declaration.
987 (sort_overlays, overlay_strings): Don't deal with clone numbers.
988
3349e122
SM
9892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
990
991 Add multiple inheritance to keymaps.
992 * keymap.c (Fmake_composed_keymap): New function.
993 (Fset_keymap_parent): Simplify.
994 (fix_submap_inheritance): Remove.
995 (access_keymap_1): New function extracted from access_keymap to handle
996 embedded parents and handle lists of maps.
997 (access_keymap): Use it.
998 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
999 (Fcopy_keymap): Handle embedded parents.
1000 (Fcommand_remapping, define_as_prefix): Simplify.
1001 (Fkey_binding): Simplify.
1002 (syms_of_keymap): Move minibuffer-local-completion-map,
1003 minibuffer-local-filename-completion-map,
1004 minibuffer-local-must-match-map, and
1005 minibuffer-local-filename-must-match-map to Elisp.
1006 (syms_of_keymap): Defsubr make-composed-keymap.
1007 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1008 (parse_menu_item): Trivial simplification.
1009
3279eb87
GM
10102011-07-01 Glenn Morris <rgm@gnu.org>
1011
1012 * Makefile.in (SETTINGS_LIBS): Fix typo.
1013
4550efdf
KI
10142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1015
1016 * coding.c (Fencode_coding_string): Record the last coding system
1017 used, as the function doc string says (bug#8738).
1018
0949d2b6
JD
10192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1020
1021 * xsettings.c (store_monospaced_changed): Take new font as arg and
1022 check for change against current_mono_font.
1023 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1024 (emacs_settings_constructor, emacs_settings_get_property)
1025 (emacs_settings_set_property, emacs_settings_class_init)
1026 (emacs_settings_init, gsettings_obj): Remove.
1027 (something_changedCB): New function for HAVE_GSETTINGS.
1028 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1029 with value as argument.
1030 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1031 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1032 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1033 "changed".
1034
1035 * xgselect.c: Add defined (HAVE_GSETTINGS).
1036 (xgselect_initialize): Ditto.
1037
1038 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1039 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1040 xg_select.
1041
bbc6b304
PE
10422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 * eval.c (struct backtrace): Simplify and port the data structure.
1045 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1046 signed bit field, as this assumption is not portable and it makes
1047 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1048 "char debug_on_exit : 1" as this is not portable either; instead,
1049 use the portable "unsigned int debug_on_exit : 1". Remove unused
1050 member evalargs. Remove obsolete comments about cc bombing out.
1051
9851bfc5
JD
10522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1053
51bb811f 1054 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1055 Let HAVE_GSETTINGS override HAVE_GCONF.
1056 (store_monospaced_changed): New function.
1057 (EMACS_SETTINGS): A new type derived from GObject to handle
1058 GSettings notifications.
1059 (emacs_settings_constructor, emacs_settings_get_property)
1060 (emacs_settings_set_property, emacs_settings_class_init):
1061 New functions.
1062 (gsettings_client, gsettings_obj): New variables.
1063 (GSETTINGS_SCHEMA): New define.
1064 (something_changedCB): Call store_monospaced_changed.
1065 (init_gsettings): New function.
1066 (xsettings_initialize): Call init_gsettings.
1067 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1068 to NULL.
1069
1070 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1071 GCONF_CFLAGS/LIBS.
1072
5386012d
MR
10732011-06-29 Martin Rudalics <rudalics@gmx.at>
1074
1075 * window.c (resize_root_window, grow_mini_window)
1076 (shrink_mini_window): Rename Qresize_root_window to
1077 Qwindow_resize_root_window and Qresize_root_window_vertically to
1078 Qwindow_resize_root_window_vertically.
1079
f13e0b08
PE
10802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1083
94515237
JB
10842011-06-27 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * makefile.w32-in: Redesign dependencies so they reflect more
1087 clearly which files are directly included by each source file,
1088 and not through other includes.
1089
e43b6e43
MR
10902011-06-27 Martin Rudalics <rudalics@gmx.at>
1091
1092 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1093 (sort_overlays, overlay_strings): When an overlay's clone number
1094 matches the window's clone number process the overlay even if
1095 the overlay's window property doesn't match the current window.
1096
d68443dc
MR
1097 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1098 (Fwindow_hchild): Rename to Fwindow_left_child.
1099 (Fwindow_next): Rename to Fwindow_next_sibling.
1100 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1101 (resize_window_check): Rename to window_resize_check.
1102 (resize_window_apply): Rename to window_resize_apply.
1103 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1104 (Fdelete_other_windows_internal, resize_frame_windows)
1105 (Fsplit_window_internal, Fdelete_window_internal)
1106 (grow_mini_window, shrink_mini_window)
1107 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1108
c7e73be5
JD
11092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1110
1111 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1112 (emacs_fixed_set_min_size): Remove.
1113 (emacs_fixed_new): Take frame as argument.
1114
1115 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1116 (_EmacsFixedPrivate): Remove minwidth/height.
1117 Add struct frame *f.
1118 (emacs_fixed_init): Initialize priv->f.
1119 (get_parent_class, emacs_fixed_set_min_size): Remove.
1120 (emacs_fixed_new): Set priv->f to argument.
1121 (emacs_fixed_get_preferred_width)
1122 (emacs_fixed_get_preferred_height): Use min_width/height from
1123 frames size_hint to set minimum and natural (Bug#8919).
1124 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1125 and use min_width/height from frames size_hint to set
1126 min_width/height (Bug#8919).
1127
1128 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1129 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1130 Fix indentation.
c7e73be5 1131
cf99dcf8
EZ
11322011-06-26 Eli Zaretskii <eliz@gnu.org>
1133
1134 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1135 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1136 called at ZV.
1137
029529ac
CY
11382011-06-26 Chong Yidong <cyd@stupidchicken.com>
1139
1140 * process.c (wait_reading_process_output): Bypass select if
1141 waiting for a cell while ignoring keyboard input, and input is
1142 pending. Suggested by Jan Djärv (Bug#8869).
1143
7a7ef429
PE
11442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1145
1146 Use gnulib's dup2 module instead of rolling our own.
1147 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1148
11fdef7d 11492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1150
1151 * dispnew.c (scrolling_window): Before scrolling, turn off a
1152 mouse-highlight in the window being scrolled.
1153
cd3520a4
JB
11542011-06-24 Juanma Barranquero <lekktu@gmail.com>
1155
1156 Move DEFSYM to lisp.h and use everywhere.
1157
1158 * character.h (DEFSYM): Move declaration...
1159 * lisp.h (DEFSYM): ...here.
1160
1161 * gnutls.c:
1162 * minibuf.c:
1163 * w32menu.c:
1164 * w32proc.c:
1165 * w32select.c: Don't include character.h.
1166
1167 * alloc.c (syms_of_alloc):
1168 * buffer.c (syms_of_buffer):
1169 * bytecode.c (syms_of_bytecode):
1170 * callint.c (syms_of_callint):
1171 * casefiddle.c (syms_of_casefiddle):
1172 * casetab.c (init_casetab_once):
1173 * category.c (init_category_once, syms_of_category):
1174 * ccl.c (syms_of_ccl):
1175 * cmds.c (syms_of_cmds):
1176 * composite.c (syms_of_composite):
1177 * dbusbind.c (syms_of_dbusbind):
1178 * dired.c (syms_of_dired):
1179 * dispnew.c (syms_of_display):
1180 * doc.c (syms_of_doc):
1181 * editfns.c (syms_of_editfns):
1182 * emacs.c (syms_of_emacs):
1183 * eval.c (syms_of_eval):
1184 * fileio.c (syms_of_fileio):
1185 * fns.c (syms_of_fns):
1186 * frame.c (syms_of_frame):
1187 * fringe.c (syms_of_fringe):
1188 * insdel.c (syms_of_insdel):
1189 * keymap.c (syms_of_keymap):
1190 * lread.c (init_obarray, syms_of_lread):
1191 * macros.c (syms_of_macros):
1192 * msdos.c (syms_of_msdos):
1193 * print.c (syms_of_print):
1194 * process.c (syms_of_process):
1195 * search.c (syms_of_search):
1196 * sound.c (syms_of_sound):
1197 * syntax.c (init_syntax_once, syms_of_syntax):
1198 * terminal.c (syms_of_terminal):
1199 * textprop.c (syms_of_textprop):
1200 * undo.c (syms_of_undo):
1201 * w32.c (globals_of_w32):
1202 * window.c (syms_of_window):
1203 * xdisp.c (syms_of_xdisp):
1204 * xfaces.c (syms_of_xfaces):
1205 * xfns.c (syms_of_xfns):
1206 * xmenu.c (syms_of_xmenu):
1207 * xsettings.c (syms_of_xsettings):
1208 * xterm.c (syms_of_xterm): Use DEFSYM.
1209
4228cf16
TZ
12102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1211
cd3520a4 1212 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1213
7fcccf1e
PE
12142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1215
7efb4e0e
PE
1216 Integer and buffer overflow fixes (Bug#8873).
1217
ff5844ad
PE
1218 * print.c (printchar, strout): Check for string overflow.
1219 (PRINTPREPARE, printchar, strout):
1220 Don't set size unless allocation succeeds.
1221
90532f02
PE
1222 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1223 for sizes. Check for string overflow more accurately.
1224 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1225
6d84508d
PE
1226 * macros.c: Integer and buffer overflow fixes.
1227 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1228 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1229 Use ptrdiff_t, not int, for sizes.
1230 Don't increment bufsize until after realloc succeeds.
1231 Check for size-calculation overflow.
1232 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1233
437b2cb4
PE
1234 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1235
8b9ac8b4
PE
1236 * lread.c: Integer overflow fixes.
1237 (read_integer): Radix is now EMACS_INT, not int,
1238 to improve quality of diagnostics for out-of-range radices.
1239 Calculate buffer size correctly for out-of-range radices.
1240 (read1): Check for integer overflow in radices, and in
1241 read-circle numbers.
82cb60d3
PE
1242 (read_escape): Avoid int overflow.
1243 (Fload, openp, read_buffer_size, read1)
1244 (substitute_object_recurse, read_vector, read_list, map_obarray):
1245 Use ptrdiff_t, not int, for sizes.
1246 (read1): Use EMACS_INT, not int, for sizes.
20270765 1247 Check for size overflow.
8b9ac8b4 1248
7fcccf1e
PE
1249 * image.c (cache_image): Check for size arithmetic overflow.
1250
bfbbd7e7
PE
1251 * lread.c: Integer overflow issues.
1252 (saved_doc_string_size, saved_doc_string_length)
1253 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1254 Now ptrdiff_t, not int.
1255 (read1): Don't assume doc string length fits in int. Check for
1256 out-of-range doc string lengths.
1257 (read_list): Don't assume file position fits in int.
39019e54 1258 (read_escape): Check for hex character overflow.
bfbbd7e7 1259
4e323265
LL
12602011-06-22 Leo Liu <sdl.web@gmail.com>
1261
1262 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1263 Move to minibuffer.el.
1264
85fece3e
PE
12652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1266
20b84ce9 1267 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1268 The following patches are for when GLYPH_DEBUG && !XASSERT.
1269 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1270 * dispnew.c (flush_stdout):
1271 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1272 Mark as externally visible.
1273 * dispnew.c (check_window_matrix_pointers): Now static.
1274 * dispnew.c (window_to_frame_vpos):
1275 * xfns.c (unwind_create_frame):
1276 * xterm.c (x_check_font): Remove unused local.
1277 * scroll.c (CHECK_BOUNDS):
1278 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1279 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1280 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1281 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1282 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1283 Now static.
1284 (debug_method_add): Use va_list and vsprintf rather than relying
1285 on undefined behavior with wrong number of arguments.
1286 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1287 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1288 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1289 since we're not interested in debugging glyphs with old libraries.
1290 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1291 GCC 4.6.0's static checking.
1292
0766b489
PE
12932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1294
31fd4b32
PE
1295 Integer overflow and signedness fixes (Bug#8873).
1296 A few related buffer overrun fixes, too.
1297
b79e8648
PE
1298 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1299
0766b489
PE
1300 * dispextern.h (struct face.stipple):
1301 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1302 (x_bitmap_mask, x_allocate_bitmap_record)
1303 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1304 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1305 (x_create_bitmap_from_xpm_data):
1306 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1307 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1308 (.bitmaps_last):
1309 * xfaces.c (load_pixmap):
1310 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1311 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1312 (.bitmaps_last, struct x_output.icon_bitmap):
1313 Use ptrdiff_t, not int, for bitmap indexes.
1314 (x_allocate_bitmap_record): Check for size overflow.
1315 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1316
b081724f
PE
1317 Use ptrdiff_t, not int, for overlay counts.
1318 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1319 * editfns.c (overlays_around, get_pos_property):
1320 * textprop.c (get_char_property_and_overlay):
1321 * xdisp.c (next_overlay_change, note_mouse_highlight):
1322 * xfaces.c (face_at_buffer_position):
21514da7
PE
1323 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1324 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1325 (Fnext_overlay_change, Fprevious_overlay_change)
1326 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1327 Use ptrdiff_t, not int, for sizes.
21514da7 1328 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1329
3de73e5e
PE
1330 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1331
2606c57b
PE
1332 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1333 (x_session_initialize): Do not assume string length fits in int.
1334
aaafe47a
PE
1335 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1336 This is unlikely, but can occur if DPI is outlandish.
1337
2674ddc8 1338 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1339 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1340
28154962
PE
1341 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1342 * xrdb.c (magic_file_p, search_magic_path):
1343 Omit last arg SUFFIX; it was always 0. All callers changed.
1344 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1345
7de51af5
PE
1346 * xfont.c (xfont_match): Avoid need for strlen.
1347
25ed6cc3
PE
1348 * xfns.c: Don't assume strlen fits in int.
1349 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1350
4eab31dd
PE
1351 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1352 not unsigned long, as we prefer signed integers. All callers changed.
1353 Detect integer overflow in repeat count.
1354 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1355 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1356
171e2a58
PE
1357 * termcap.c: Don't assume sizes fit in int and never overflow.
1358 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1359 (gobble_line): Check for size-calculation overflow.
1360
ad39faca 1361 * minibuf.c (Fread_buffer):
6e5bb2dc 1362 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1363 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1364 Don't assume string length fits in int.
1365
52c61c22 1366 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1367 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1368
b5b8c9e5
PE
1369 * font.c: Don't assume string length fits in int.
1370 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1371 Use ptrdiff_t, not int.
ccd6111c
PE
1372 (font_intern_prop): Don't assume string length fits in int.
1373 Don't assume integer property fits in fixnum.
1374 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1375
882f0d81 1376 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1377 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1378 Reformulate so as not to need the command string.
1379 Invoke gzip -cd rather than gunzip, as it's more portable.
1380 (lock_info_type, lock_file_1, lock_file):
1381 Don't assume pid_t and time_t fit in unsigned long.
1382 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1383 (current_lock_owner): Prefer signed type for sizes.
1384 Use memcpy, not strncpy, where memcpy is what is really wanted.
1385 Don't assume (via atoi) that time_t and pid_t fit in int.
1386 Check for time_t and/or pid_t out of range, e.g., via a network share.
1387 Don't alloca where an auto var works fine.
1388
93f4cf88
PE
1389 * fileio.c: Fix some integer overflow issues.
1390 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1391 Don't assume string length fits in int.
1392 (directory_file_name): Don't assume string length fits in long.
1393 (make_temp_name): Don't assume pid fits in int, or that its print
1394 length is less than 20.
1395
f3e92b69
PE
1396 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1397
1bfdaf10
PE
1398 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1399
35016e9a
PE
1400 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1401
3d1e65a1
PE
1402 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1403 We prefer signed integers, even for size calculations.
1404
0b963a93
PE
1405 * emacs.c: Don't assume string length fits in 'int'.
1406 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1407 (main): Don't invoke strlen when not needed.
1408
573f4b54
PE
1409 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1410 (XD_DEBUG_MESSAGE): Don't waste a byte.
1411
989f33ba
PE
1412 * callproc.c (getenv_internal_1, getenv_internal)
1413 (Fgetenv_internal):
965d34eb
PE
1414 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1415
e4d29b33
PE
1416 * lread.c (invalid_syntax): Omit length argument.
1417 All uses changed. This doesn't fix a bug, but it simplifies the
1418 code away from its former Hollerith-constant appearance, and it's
1419 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1420 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1421
eb49b136
PE
1422 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1423 This didn't break anything, but it didn't help either.
1424 It's confusing to put a bogus integer in a place where the actual
1425 value does not matter.
9f62aeb1 1426 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1427 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1428
15375a22
PE
1429 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1430 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1431 implementation.
b61cc01c
PE
1432 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1433 We prefer signed types, and the value cannot exceed the EMACS_INT
1434 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1435 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1436 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1437 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1438
53b2623d
PE
1439 * indent.c (sane_tab_width): New function.
1440 (current_column, scan_for_column, Findent_to, position_indentation)
1441 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1442 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1443
51cab52b 1444 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1445
f2ed8a70
PE
1446 * lisp.h (lint_assume): New macro.
1447 * composite.c (composition_gstring_put_cache):
1448 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1449
abe80cc6
PE
1450 * editfns.c, insdel.c:
1451 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1452
b02c740e
PE
1453 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1454
ebc96716
PE
1455 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1456
b4e50fa0 1457 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1458 Use much-faster test for byte-length change.
311d5d7c 1459 Don't assume string byte-length fits in 'int'.
a4cf38e4 1460 Check that character arg fits in 'int'.
85461888 1461 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1462
c0c1ee9f
PE
1463 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1464
a498d7f4
PE
1465 * fns.c (concat): Catch string overflow earlier.
1466 Do not rely on integer wraparound.
1467
51cab52b
PE
1468 * dispextern.h (struct it.overlay_strings_charpos)
1469 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1470 * xdisp.c (forward_to_next_line_start)
1471 (back_to_previous_visible_line_start)
1472 (reseat_at_next_visible_line_start, next_element_from_buffer):
1473 Don't arbitrarily truncate the value of 'selective' to int.
1474
76031fad
PE
1475 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1476
5eb55db9
PE
1477 * composite.c: Don't truncate sizes to 'int'.
1478 (composition_gstring_p, composition_reseat_it)
1479 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1480 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1481 not EMACS_UINT, for indexes.
5eb55db9 1482
0703a717
PE
1483 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1484
d6202519
PE
1485 * buffer.c: Include <verify.h>.
1486 (struct sortvec.priority, struct sortstr.priority):
8961a454 1487 Now EMACS_INT, not int.
c20998a7 1488 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1489 (struct sortstr.size, record_overlay_string)
1490 (struct sortstrlist.size, struct sortlist.used):
1491 Don't truncate size to int.
1492 (record_overlay_string): Check for size-calculation overflow.
d6202519 1493 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1494
d5a19415
JM
14952011-06-22 Jim Meyering <meyering@redhat.com>
1496
029529ac 1497 Don't leak an XBM-image-sized buffer
d5a19415
JM
1498 * image.c (xbm_load): Free the image buffer after using it.
1499
a9041e6c
PE
15002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 Port to Sun C.
1503 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1504 that Sun C diagnosed.
1505 * fns.c (secure_hash): Fix pointer signedness issue.
1506 * intervals.c (static_offset_intervals): New function.
1507 (offset_intervals): Use it.
1508
7f3f739f
LL
15092011-06-21 Leo Liu <sdl.web@gmail.com>
1510
1511 * deps.mk (fns.o):
1512 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1513 sha512.h.
1514
1515 * fns.c (secure_hash): Rename from crypto_hash_function and change
1516 the first arg to accept symbols.
5b66d427 1517 (Fsecure_hash): New primitive.
7f3f739f
LL
1518 (syms_of_fns): New symbols.
1519
76147d94
DD
15202011-06-20 Deniz Dogan <deniz@dogan.se>
1521
1522 * process.c (Fset_process_buffer): Clarify return value in
1523 docstring.
1524
7d7d0045
CY
15252011-06-18 Chong Yidong <cyd@stupidchicken.com>
1526
1527 * dispnew.c (add_window_display_history): Use BVAR.
1528
1529 * xdisp.c (debug_method_add): Use BVAR.
1530 (check_window_end, dump_glyph_matrix, dump_glyph)
1531 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1532
1533 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1534 Likewise.
1535
1536 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1537 check till after the cache is created in init_frame_faces.
1538
ff2bc410
SM
15392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1540
1541 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1542
28177add
PE
15432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1544
dd3482fe
PE
1545 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1546 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1547 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1548
393d71f3 1549 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1550 * fileio.c (Finsert_file_contents):
1551 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1552 Remove the old (too-loose) buffer overflow checks.
1553 They weren't needed, since make_gap checks for buffer overflow.
1554 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1555 The old code merely checked for Emacs fixnum overflow, and relied
1556 on undefined (wraparound) behavior. The new code avoids undefined
1557 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1558
2e6813b0 1559 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1560 Tune. Don't use wider integers than needed. Don't use alloca.
1561 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1562
599a9e4f
PE
1563 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1564
99561444
PE
1565 * insdel.c, lisp.h (buffer_overflow): New function.
1566 (insert_from_buffer_1, replace_range, replace_range_2):
1567 * insdel.c (make_gap_larger):
1568 * editfns.c (Finsert_char):
1569 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1570
28177add
PE
1571 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1572
e69dafad
PE
15732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1574
a7af7fde 1575 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1576
b1c46f02
PE
1577 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1578 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1579
e69dafad
PE
1580 * fileio.c: Don't assume EMACS_INT fits in off_t.
1581 (emacs_lseek): New static function.
1582 (Finsert_file_contents, Fwrite_region): Use it.
1583 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1584
566684ea
PE
1585 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1586
e6966cd6
PE
1587 * fns.c: Don't overflow int when computing a list length.
1588 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1589 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1590 truncation on 64-bit hosts. Check for QUIT every
1591 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1592 faster and is responsive enough.
1593 (Flength): Report an error instead of overflowing an integer.
1594 (Fsafe_length): Return a float if the value is not representable
1595 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1596 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1597 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1598
dd0b0efb
PE
1599 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1600 (header_size, word_size): New constants.
1601 (allocate_vectorlike): Don't check size overflow here.
1602 (allocate_vector): Check it here instead, since this is the only
1603 caller of allocate_vectorlike that could cause overflow.
1604 Check that the new vector's length is representable as a fixnum.
1605
86fe5cfe
PE
1606 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1607 The previous code was bogus. For example, next_almost_prime (32)
1608 returned 39, which is undesirable as it is a multiple of 3; and
1609 next_almost_prime (24) returned 25, which is a multiple of 5 so
1610 why was the code bothering to check for multiples of 7?
1611
80e88859
PE
1612 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1613
4a2f0ad6
PE
1614 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1615
f66c7cf8
PE
1616 Variadic C functions now count arguments with ptrdiff_t.
1617 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1618 Back then I didn't know that the Emacs coding style prefers signed int.
1619 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1620 were being counted with int, which may truncate counts on 64-bit
1621 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1622 * lisp.h (struct Lisp_Subr.function.aMANY)
1623 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1624 Arg counts are now ptrdiff_t, not size_t.
1625 All variadic functions and their callers changed accordingly.
1626 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1627 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1628 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1629 * callint.c (Fcall_interactively): Check arg count for overflow,
1630 to avoid potential buffer overrun. Use signed char, not 'int',
1631 for 'varies' array, so that we needn't bother to check its size
1632 calculation for overflow.
1633 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1634 * eval.c (apply_lambda):
1635 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1636 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1637 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1638
a1759b76
PE
1639 * callint.c (Fcall_interactively): Don't use index var as event count.
1640
d96be9fc
PE
1641 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1642 * mem-limits.h (SIZE): Remove; no longer used.
1643
a690a978 1644 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1645
578c21e6
PE
1646 Remove unnecessary casts.
1647 * xterm.c (x_term_init):
1648 * xfns.c (x_set_border_pixel):
1649 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1650 These aren't needed now that we assume ANSI C.
1651
96f53c6c
PE
1652 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1653 It's more likely to cause problems (due to unsigned overflow)
1654 than to cure them.
1655
83c77d31
PE
1656 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1657
ee2079f1
PE
1658 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1659
6da65536
PE
1660 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1661
7147c4a4
PE
1662 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1663
193e32d9
PE
1664 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1665
e5533da6
PE
1666 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1667
9910e595
PE
1668 GLYPH_CODE_FACE returns EMACS_INT, not int.
1669 * dispextern.h (merge_faces):
1670 * xfaces.c (merge_faces):
01103c44
PE
1671 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1672 Don't assume EMACS_INT fits in int.
9910e595 1673
2638320e
PE
1674 * character.h (CHAR_VALID_P): Remove unused parameter.
1675 * fontset.c, lisp.h, xdisp.c: All uses changed.
1676
045eb8d9
PE
1677 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1678
c1f134b5
PE
1679 * fns.c (concat): Minor tuning based on overflow analysis.
1680 This doesn't fix any bugs. Use int to hold character, instead
1681 of constantly refetching from Emacs object. Use XFASTINT, not
1682 XINT, for value known to be a character. Don't bother comparing
1683 a single byte to 0400, as it's always less.
1684
395fcb93 1685 * floatfns.c (Fexpt):
327eeec8
PE
1686 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1687
abbd3d23
PE
1688 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1689 for characters.
1690
684a03ef
PE
1691 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1692
0fed43f3
PE
1693 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1694 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1695 incorrectly succeed when S was a string, because 4294967386 was
1696 truncated before it was used.
1697
8fd02eb7
PE
1698 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1699 Otherwise, an out-of-range integer could cause undefined behavior
1700 on a 64-bit host.
1701
f8c86b69
PE
1702 * composite.c: Use int, not EMACS_INT, for characters.
1703 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1704 EMACS_INT, for values that are known to be in character range.
1705 This doesn't fix any bugs but is the usual style inside Emacs and
1706 may generate better code on 32-bit machines.
1707
34206dd2
PE
1708 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1709 This is for reasons similar to the recent CHAR_STRING fix.
1710 * charset.c (Fencode_char): Check that character arg is actually
1711 a character. Pass an int to ENCODE_CHAR.
1712 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1713 wider than 'int', as a compile-time check to prevent future regressions
1714 in this area.
1715
c5958d4c 1716 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1717
1718 Make sure a 64-bit char is never passed to CHAR_STRING.
1719 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1720 by silently ignoring the top 32 bits, allowing some values
1721 that were far too large to be valid characters.
1722 * character.h: Include <verify.h>.
1723 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1724 arguments are no wider than unsigned, as a compile-time check
1725 to prevent future regressions in this area.
1726 * data.c (Faset):
01103c44 1727 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1728 (Fsubst_char_in_region):
1729 * fns.c (concat):
1730 * xdisp.c (decode_mode_spec_coding):
1731 Adjust to CHAR_STRING's new requirement.
1732 * editfns.c (Finsert_char, Fsubst_char_in_region):
1733 * fns.c (concat): Check that character args are actually
1734 characters. Without this test, these functions did the wrong
1735 thing with wildly out-of-range values on 64-bit hosts.
1736
d37ca623
PE
1737 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1738 These casts should not be needed on 32-bit hosts, either.
1739 * keyboard.c (read_char):
1740 * lread.c (Fload): Remove casts to unsigned.
1741
ea204efb
PE
1742 * lisp.h (UNSIGNED_CMP): New macro.
1743 This fixes comparison bugs on 64-bit hosts.
1744 (ASCII_CHAR_P): Use it.
1745 * casefiddle.c (casify_object):
01103c44 1746 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1747 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1748 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1749 * dispextern.h (FACE_FROM_ID):
1750 * keyboard.c (read_char): Use UNSIGNED_CMP.
1751
41cb286c
PE
1752 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1753 not to EMACS_INT, to avoid GCC warning.
1754
4a1b9832
PE
1755 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1756
55daad71
PE
1757 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1758 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1759 isn't needed on 32-bit machines.
8f95c75c 1760
01103c44
PE
1761 * buffer.c (Fgenerate_new_buffer_name):
1762 Use EMACS_INT for count, not int.
0ceccced 1763 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1764
1765 * data.c (Qcompiled_function): Now static.
1766
c6f072e7
PE
1767 * window.c (window_body_lines): Now static.
1768
20ce5912
PE
1769 * image.c (gif_load): Rename local to avoid shadowing.
1770
9c4c5f81
PE
1771 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1772 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1773 * alloc.c (make_save_value): Integer argument is now of type
1774 ptrdiff_t, not int.
1775 (mark_object): Use ptrdiff_t, not int.
1776 * lisp.h (pD): New macro.
1777 * print.c (print_object): Use it.
1778
c0c5c8ae
PE
1779 * alloc.c: Use EMACS_INT, not int, to count objects.
1780 (total_conses, total_markers, total_symbols, total_vector_size)
1781 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1782 (total_free_floats, total_floats, total_free_intervals)
1783 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1784 Now EMACS_INT, not int. All uses changed.
1785 (Fgarbage_collect): Compute overall total using a double, so that
1786 integer overflow is less likely to be a problem. Check for overflow
1787 when converting back to an integer.
5a25e253
PE
1788 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1789 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1790 These were 'int' variables that could overflow on 64-bit hosts;
1791 they were never used, so remove them instead of repairing them.
211a0b2a 1792 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1793 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1794 Previously, this ceilinged at INT_MAX, but that doesn't work on
1795 64-bit machines.
e46bb31a 1796 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1797
c78baabf 1798 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1799 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1800 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1801 when a (possibly-narrower) signed value would do just as well.
1802 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1803
c9d624c6
PE
1804 * alloc.c: Catch some string size overflows that we were missing.
1805 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1806 for convenience in STRING_BYTES_MAX.
1807 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1808 The definition here is exact; the one in lisp.h was approximate.
1809 (allocate_string_data): Check for string overflow. This catches
1810 some instances we weren't catching before. Also, it catches
1811 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1812 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1813 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1814
c9d624c6
PE
1815 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1816 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1817 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1818
353032ce
PE
1819 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1820
2bccce07
PE
1821 * alloc.c (Fmake_string): Check for out-of-range init.
1822
0ac30604
SM
18232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1824
1825 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1826
c195f2de
JD
18272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1828
1829 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1830 xg_get_default_scrollbar_width.
1831
1832 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1833 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1834 (style_changed_cb): Call update_theme_scrollbar_width and call
1835 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1836 all frames (Bug#8505).
1837 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1838 Call gtk_window_set_resizable if HAVE_GTK3.
1839 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1840 and height if HAVE_GTK3 (Bug#8505).
1841 (scroll_bar_width_for_theme): New variable.
1842 (update_theme_scrollbar_width): New function.
1843 (xg_get_default_scrollbar_width): Move code to
1844 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1845 (xg_initialize): Call update_theme_scrollbar_width.
1846
1847 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1848
1849 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1850
e10ac9f1
MR
18512011-06-12 Martin Rudalics <rudalics@gmx.at>
1852
1853 * frame.c (make_frame): Call other_buffer_safely instead of
1854 other_buffer.
1855
1856 * window.c (temp_output_buffer_show): Call display_buffer with
1857 second argument Vtemp_buffer_show_specifiers and reset latter
1858 immediately after the call.
1859 (Vtemp_buffer_show_specifiers): New variable.
1860 (auto_window_vscroll_p, next_screen_context_lines)
1861 (Vscroll_preserve_screen_position): Remove leading asterisks from
1862 doc-strings.
1863
2d3c217e 18642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1865
7b7f97e8 1866 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1867 * buffer.c (Qclone_number): Remove for now, as it's unused.
1868 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1869 (record_buffer): Remove unused local.
1870 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1871 (set_frame_buffer_list): Remove; unused.
1872 * frame.h (other_visible_frames): Remove decl.
1873 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1874 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1875 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1876 if HAVE_GPM.
1877 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1878 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1879 Define only if HAVE_GPM.
1880 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1881 (update_hints_inhibit): Remove; never set. All uses removed.
1882 * widgetprv.h (emacsFrameClassRec): Remove decl.
1883 * window.c (delete_deletable_window): Now returns void, since it
1884 wasn't returning anything.
1885 (compare_window_configurations): Remove unused locals.
1886 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1887 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1888 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1889 the same widths as pointers. This follows up on the 2011-05-06 patch.
1890 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1891 * xterm.h: Likewise.
1892 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1893
1384b89e
JB
18942011-06-12 Juanma Barranquero <lekktu@gmail.com>
1895
1896 * makefile.w32-in: Update dependencies.
1897 (LISP_H): Add lib/intprops.h.
1898
1100a63c
CY
18992011-06-11 Chong Yidong <cyd@stupidchicken.com>
1900
1901 * image.c (gif_load): Add animation frame delay to the metadata.
1902 (syms_of_image): Use DEFSYM. New symbol `delay'.
1903
6198ccd0
MR
19042011-06-11 Martin Rudalics <rudalics@gmx.at>
1905
1906 * window.c (delete_deletable_window): Re-add.
1907 (Fset_window_configuration): Rewrite to handle dead buffers and
1908 consequently deletable windows.
1909 (window_tree, Fwindow_tree): Remove. Supply functionality in
1910 window.el.
1911 (compare_window_configurations): Simplify code.
1912
b6e3633c
AS
19132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1914
1ab0dee5
AS
1915 * image.c (imagemagick_load_image): Fix type mismatch.
1916 (Fimagemagick_types): Likewise.
1917
b6e3633c
AS
1918 * window.h (replace_buffer_in_windows): Declare.
1919
9397e56f
MR
19202011-06-11 Martin Rudalics <rudalics@gmx.at>
1921
1922 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1923 Qclone_number. Remove external declaration of Qdelete_window.
1924 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1925 code.
1926 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1927 Qbuffer_list_update_hook if allowed.
1928 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1929 buffer list implementation.
1930 (other_buffer_safely): New function.
1931 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1932 calls to replace_buffer_in_windows and
1933 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1934 if allowed.
1935 (record_buffer): Inhibit quitting and rewrite using quittable
1936 functions. Run Qbuffer_list_update_hook if allowed.
1937 (Frecord_buffer, Funrecord_buffer): New functions.
1938 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1939 switch-to-buffer to window.el.
1940 (bury-buffer): Move to window.el.
1941 (Vbuffer_list_update_hook): New variable.
1942
1943 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1944 section.
1945
1946 * window.h (resize_frame_windows): Move up in code.
1947 (Fwindow_frame): Remove EXFUN.
1948 (replace_buffer_in_all_windows): Remove prototype.
1949 (replace_buffer_in_windows_safely): Add prototype.
1950
1951 * window.c: Declare Qdelete_window static again. Move down
1952 declaration of select_count.
1953 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1954 (Fother_window): Move to window.el.
1955 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1956 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1957 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1958 window.el.
1959 (replace_buffer_in_windows): Implement by calling
1960 Qreplace_buffer_in_windows.
1961 (replace_buffer_in_all_windows): Remove with some functionality
1962 moved into replace_buffer_in_windows_safely.
1963 (replace_buffer_in_windows_safely): New function.
1964 (select_window_norecord, select_frame_norecord): Move in front
1965 of run_window_configuration_change_hook. Remove now obsolete
1966 declarations.
1967 (Fset_window_buffer): Rewrite doc-string. Call
1968 Qrecord_window_buffer.
1969 (keys_of_window): Move binding for other-window to window.el.
1970
b50691aa
CY
19712011-06-11 Chong Yidong <cyd@stupidchicken.com>
1972
1973 * dispextern.h (struct image): Replace data member, whose int_val
1974 and ptr_val fields were not used by anything, with a single
1975 lisp_val object.
1976
1977 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1978 (gif_clear_image, gif_load, imagemagick_load_image)
1979 (gs_clear_image, gs_load): Callers changed.
1980
3f754b86
PE
19812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1982
cca69397
PE
1983 * buffer.h: Include <time.h>, for time_t.
1984 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1985
109e28d0
PE
1986 Fix minor problems found by static checking.
1987
60737f02
PE
1988 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1989
4b66faf3
PE
1990 Make identifiers static if they are not used in other modules.
1991 * data.c (Qcompiled_function, Qframe, Qvector):
1992 * image.c (QimageMagick, Qsvg):
1993 * minibuf.c (Qmetadata):
1994 * window.c (resize_window_check, resize_root_window): Now static.
1995 * window.h (resize_window_check, resize_root_window): Remove decls.
1996
109e28d0
PE
1997 * window.c (window_deletion_count, delete_deletable_window):
1998 Remove; unused.
46a4ce9e
PE
1999 (window_body_lines): Now static.
2000 (Fdelete_other_windows_internal): Mark vars as initialized.
2001 Make sure 'resize_failed' is initialized.
2002 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2003 (resize_window_apply): Remove unused local.
2004 * window.h (delete_deletable_window): Remove decl.
2005
109e28d0 2006 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2007 (imagemagick_load_image): Fix pointer signedness problem by changing
2008 last arg from unsigned char * to char *. All uses changed.
2009 Also, fix a local for similar reasons.
2010 Remove unused locals. Remove locals to avoid shadowing.
2011 (fn_rsvg_handle_free): Remove; unused.
2012 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2013 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2014
3f754b86
PE
2015 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2016
2547adb1
CY
20172011-06-10 Chong Yidong <cyd@stupidchicken.com>
2018
2019 * image.c (gif_load): Fix omitted cast error introduced by
2020 2011-06-06 change.
2021
2c8e37d4
MR
20222011-06-10 Martin Rudalics <rudalics@gmx.at>
2023
2024 * window.h (resize_proportionally, orig_total_lines)
2025 (orig_top_line): Remove from window structure.
2026 (set_window_height, set_window_width, change_window_heights)
2027 (Fdelete_window): Remove prototypes.
2028 (resize_frame_windows): Remove duplicate declaration.
2029
440a42e3
EZ
20302011-06-10 Eli Zaretskii <eliz@gnu.org>
2031
2032 * window.h (resize_frame_windows, resize_window_check)
2033 (delete_deletable_window, resize_root_window)
2034 (resize_frame_windows): Declare prototypes.
2035
2036 * window.c (resize_window_apply): Make definition be "static" to
2037 match the prototype.
2038
562dd5e9
MR
20392011-06-10 Martin Rudalics <rudalics@gmx.at>
2040
2041 * window.c: Remove declarations of Qwindow_size_fixed,
2042 window_min_size_1, window_min_size_2, window_min_size,
2043 size_window, window_fixed_size_p, enlarge_window, delete_window.
2044 Remove static from declaration of Qdelete_window, it's
2045 temporarily needed by Fbury_buffer.
2046 (replace_window): Don't assign orig_top_line and
2047 orig_total_lines.
2048 (Fdelete_window, delete_window): Remove. Window deletion is
2049 handled by window.el.
2050 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2051 Fdelete_window calls with calls to Qdelete_window.
2052 (Fdelete_other_windows): Remove. Deleting other windows is
2053 handled by window.el.
2054 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2055 handled in window.el.
2056 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2057 Window minimum sizes are handled in window.el.
2058 (shrink_windows, size_window, set_window_height)
2059 (set_window_width, change_window_heights, window_height)
2060 (window_width, CURBEG, CURSIZE, enlarge_window)
2061 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2062 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2063 handled in window.el.
2064 (make_dummy_parent): Rename to make_parent_window and give it a
2065 second argument horflag.
2066 (make_window): Don't set resize_proportionally any more.
2067 (Fsplit_window): Remove. Windows are split in window.el.
2068 (save_restore_action, save_restore_orig_size)
2069 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2070 Resize mini windows in window.el.
2071 (grow_mini_window, shrink_mini_window): Implement by calling
2072 Qresize_root_window_vertically, resize_window_check and
2073 resize_window_apply.
2074 (saved_window, Fset_window_configuration, save_window_save): Do
2075 not handle orig_top_line, orig_total_lines, and
2076 resize_proportionally.
2077 (window_min_height, window_min_width): Move to window.el.
2078 (keys_of_window): Move bindings for delete-other-windows,
2079 split-window, delete-window and enlarge-window to window.el.
2080
2081 * buffer.c: Temporarily extern Qdelete_window.
2082 (Fbury_buffer): Temporarily call Qdelete_window instead of
2083 Fdelete_window (Fbury_buffer will move to window.el soon).
2084
2085 * frame.c (set_menu_bar_lines_1): Remove code handling
2086 orig_top_line and orig_total_lines.
2087
2088 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2089 set_window_height but set heights directly.
2090 (change_frame_size_1): Use resize_frame_windows.
2091
2092 * xdisp.c (init_xdisp): Don't use set_window_height but set
2093 heights directly.
2094
2095 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2096 resize_frame_windows instead of change_window_heights and run
2097 run_window_configuration_change_hook.
2098
2099 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2100 instead of change_window_heights and run
2101 run_window_configuration_change_hook.
2102
1a13852e
MR
21032011-06-09 Martin Rudalics <rudalics@gmx.at>
2104
2105 * window.c (replace_window): Rename second argument REPLACEMENT to
2106 NEW. New third argument SETFLAG. Rewrite.
2107 (delete_window, make_dummy_parent): Call replace_window with
2108 third argument 1.
2109 (window_list_1): Move down in code.
2110 (run_window_configuration_change_hook): Move set_buffer part
2111 before select_frame_norecord part in order to unwind correctly.
2112 Rename count1 to count.
2113 (recombine_windows, delete_deletable_window, resize_root_window)
2114 (Fdelete_other_windows_internal)
2115 (Frun_window_configuration_change_hook, make_parent_window)
2116 (resize_window_check, resize_window_apply, Fresize_window_apply)
2117 (resize_frame_windows, Fsplit_window_internal)
2118 (Fdelete_window_internal, Fresize_mini_window_internal): New
2119 functions.
2120 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2121
f3d1777e
MR
21222011-06-08 Martin Rudalics <rudalics@gmx.at>
2123
496e208e
MR
2124 * window.h (window): Add some new members to window structure -
2125 normal_lines, normal_cols, new_total, new_normal, clone_number,
2126 splits, nest, prev_buffers, next_buffers.
2127 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2128 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2129
f3d1777e
MR
2130 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2131 Remove.
496e208e
MR
2132 (make_dummy_parent): Set new members of windows structure.
2133 (make_window): Move down in code. Handle new members of window
2134 structure.
2135 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2136 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2137 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2138 (Fset_window_prev_buffers, Fwindow_next_buffers)
2139 (Fset_window_next_buffers, Fset_window_clone_number): New
2140 functions.
2141 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2142 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2143 Doc-string fixes.
2144 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2145 Argument WINDOW can be now internal window too.
2146 (Fwindow_use_time): Move up in code.
2147 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2148 Rewrite doc-string.
2149 (Fset_window_configuration, saved_window)
2150 (Fcurrent_window_configuration, save_window_save): Handle new
2151 members of window structure.
b9e809c2
MR
2152 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2153 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2154 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2155 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2156 Qget_mru_window, Qresize_root_window,
2157 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2158 Qauto_buffer_name; staticpro them.
f3d1777e 2159
abde8f8c
MR
21602011-06-07 Martin Rudalics <rudalics@gmx.at>
2161
2162 * window.c (Fwindow_total_size, Fwindow_left_column)
2163 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2164 (Fwindow_list_1): New functions.
2165 (window_box_text_cols): Replace with window_body_cols.
2166 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2167 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2168 (delete_window, Fset_window_configuration): Call
2169 delete_all_subwindows with window as argument.
2170 (delete_all_subwindows): Take a window as argument and not a
2171 structure. Rewrite.
190b47e6
MR
2172 (window_loop): Remove handling of GET_LRU_WINDOW and
2173 GET_LARGEST_WINDOW.
2174 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2175
2176 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2177 window_box_text_cols. delete_all_subwindows now takes a
2178 Lisp_Object as argument.
abde8f8c
MR
2179
2180 * indent.c (compute_motion, Fcompute_motion): Use
2181 window_body_cols instead of window_box_text_cols.
2182
fa8a67e6
MR
2183 * frame.c (delete_frame): Call delete_all_subwindows with root
2184 window as argument.
2185
a54e3482
DC
21862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2187
2188 * fns.c (Fputhash): Document return value.
2189
60002bf5
CY
21902011-06-06 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2193
0c671da6 21942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2195
b862a52a 2196 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2197
be44ca6c
PE
2198 Check for overflow when converting integer to cons and back.
2199 * charset.c (Fdefine_charset_internal, Fdecode_char):
2200 Use cons_to_unsigned to catch overflow.
2201 (Fencode_char): Use INTEGER_TO_CONS.
2202 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2203 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2204 * data.c (long_to_cons, cons_to_long): Remove.
2205 (cons_to_unsigned, cons_to_signed): New functions.
2206 These signal an error for invalid or out-of-range values.
2207 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2208 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2209 * font.c (Ffont_variation_glyphs):
2210 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2211 * lisp.h: Include <intprops.h>.
2212 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2213 (cons_to_signed, cons_to_unsigned): New decls.
2214 (long_to_cons, cons_to_long): Remove decls.
2215 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2216 (Fprimitive_undo): Use CONS_TO_INTEGER.
2217 * xfns.c (Fx_window_property): Likewise.
2218 * xselect.c: Include <limits.h>.
2219 (x_own_selection, selection_data_to_lisp_data):
2220 Use INTEGER_TO_CONS.
2221 (x_handle_selection_request, x_handle_selection_clear)
2222 (x_get_foreign_selection, Fx_disown_selection_internal)
2223 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2224 (lisp_data_to_selection_data): Use cons_to_unsigned.
2225 (x_fill_property_data): Use cons_to_signed.
2226 Report values out of range.
2227
d1f3d2af
PE
2228 Check for buffer and string overflow more precisely.
2229 * buffer.h (BUF_BYTES_MAX): New macro.
2230 * lisp.h (STRING_BYTES_MAX): New macro.
2231 * alloc.c (Fmake_string):
2232 * character.c (string_escape_byte8):
2233 * coding.c (coding_alloc_by_realloc):
2234 * doprnt.c (doprnt):
2235 * editfns.c (Fformat):
2236 * eval.c (verror):
2237 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2238 since they may not be the same number.
2239 * editfns.c (Finsert_char):
2240 * fileio.c (Finsert_file_contents):
2241 Likewise for BUF_BYTES_MAX.
2242
dd52fcea
PE
2243 * image.c: Use ptrdiff_t, not int, for sizes.
2244 (slurp_file): Switch from int to ptrdiff_t.
2245 All uses changed.
2246 (slurp_file): Check that file size fits in both size_t (for
2247 malloc) and ptrdiff_t (for sanity and safety).
2248
7f9bbdbb
PE
2249 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2250 if b->modtime has its maximal value.
2251
dfe18f82
PE
2252 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2253
84acfcf0
PE
2254 Don't assume time_t can fit into int.
2255 * buffer.h (struct buffer.modtime): Now time_t, not int.
2256 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2257 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2258
ccd9a01a
PE
2259 Minor fixes for signed vs unsigned integers.
2260 * character.h (MAYBE_UNIFY_CHAR):
2261 * charset.c (maybe_unify_char):
2262 * keyboard.c (read_char, reorder_modifiers):
2263 XINT -> XFASTINT, since the integer must be nonnegative.
2264 * ftfont.c (ftfont_spec_pattern):
2265 * keymap.c (access_keymap, silly_event_symbol_error):
2266 XUINT -> XFASTINT, since the integer must be nonnegative.
2267 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2268 since it makes no difference and we prefer signed.
2269 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2270 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2271 nonnegative.
2272
d6d100dd
SM
22732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2274
2275 * window.h (Fwindow_frame): Declare.
2276
2b6148e4
PE
22772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2280 (SPARE_MEMORY): Always define.
2281 (LARGE_REQUEST): Remove.
2282 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2283
f230ecc9
MR
22842011-06-06 Martin Rudalics <rudalics@gmx.at>
2285
727e958e
MR
2286 * lisp.h: Move EXFUNS for Fframe_root_window,
2287 Fframe_first_window and Fset_frame_selected_window to window.h.
2288
2289 * window.h: Move EXFUNS for Fframe_root_window,
2290 Fframe_first_window and Fset_frame_selected_window here from
2291 lisp.h.
2292
2293 * frame.c (Fwindow_frame, Fframe_first_window)
2294 (Fframe_root_window, Fframe_selected_window)
2295 (Fset_frame_selected_window): Move to window.c.
2296 (Factive_minibuffer_window): Move to minibuf.c.
2297 (Fother_visible_frames_p): New function.
2298
2299 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2300
f230ecc9
MR
2301 * window.c (decode_window, decode_any_window): Move up in code.
2302 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2303 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2304 (Fwindow_buffer): Move up and rewrite doc-string.
2305 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2306 (Fwindow_prev): New functions.
727e958e
MR
2307 (Fwindow_frame): Move here from frame.c. Accept any window as
2308 argument.
2309 (Fframe_root_window, Fframe_first_window)
2310 (Fframe_selected_window): Move here from frame.c. Accept frame
2311 or arbitrary window as argument. Update doc-strings.
2312 (Fminibuffer_window): Move up in code.
2313 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2314 (Fset_frame_selected_window): Move here from frame.c.
2315 Marginal rewrite.
727e958e
MR
2316 (Fselected_window, select_window, Fselect_window): Move up in
2317 code. Minor doc-string fixes.
f230ecc9 2318
4d09bcf6
PE
23192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2322 Do not assume that spare memory exists; that assumption is valid
2323 only if SYSTEM_MALLOC.
2324 (LARGE_REQUEST): New macro, so that the issue of large requests
2325 is separated from the issue of spare memory.
2326
810928a2
AS
23272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2328
172418ad
AS
2329 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2330 format. (Bug#8806)
2331
43f862f7
AS
2332 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2333
810928a2
AS
2334 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2335 before statements.
2336
a059fe24
JD
23372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2338
2339 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2340
2341 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2342
2343 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2344 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2345
989bf368
JB
23462011-06-05 Juanma Barranquero <lekktu@gmail.com>
2347
2348 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2349
4b80f674
CY
23502011-06-04 Chong Yidong <cyd@stupidchicken.com>
2351
2352 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2353 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2354 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2355 New error handlers.
4b80f674
CY
2356 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2357 Obey Vx_select_enable_clipboard_manager. Catch errors in
2358 x_clipboard_manager_save (Bug#8779).
2359 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2360 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2361
99a33b77 23622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2363
2364 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2365
99a33b77 23662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2367
2368 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2369 in the current matrix if keep_current_p is non-zero.
2370
8264569d
EZ
23712011-06-04 Eli Zaretskii <eliz@gnu.org>
2372
2373 * bidi.c (bidi_level_of_next_char): Fix last change.
2374
57f97249
EZ
23752011-06-03 Eli Zaretskii <eliz@gnu.org>
2376
fec2107c 2377 Support bidi reordering of text covered by display properties.
57f97249 2378
fec2107c
EZ
2379 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2380 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2381 (bidi_cache_search, bidi_cache_iterator_state)
2382 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2383 (bidi_level_of_next_char, bidi_move_to_visually_next):
2384 Support character positions inside a run of characters covered by a
fec2107c
EZ
2385 display string.
2386 (bidi_paragraph_init, bidi_resolve_explicit_1)
2387 (bidi_level_of_next_char): Call bidi_fetch_char and
2388 bidi_fetch_char_advance instead of FETCH_CHAR and
2389 FETCH_CHAR_ADVANCE.
2390 (bidi_init_it): Initialize new members.
2391 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2392 definitions.
2393 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2394 instead of using explicit *_CHAR codes.
d6d100dd
SM
2395 (bidi_resolve_explicit, bidi_resolve_weak):
2396 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2397 bidirectional text is supported only in multibyte buffers.
2398 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2399 it to initialize the frame_window_p member of struct bidi_it.
2400 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2401 (bidi_resolve_explicit, bidi_resolve_weak)
2402 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2403 bidi_it->nchars is non-positive.
2404 (bidi_level_of_next_char): Don't try to lookup the cache for the
2405 next/previous character if nothing is cached there yet, or if we
2406 were just reseat()'ed to a new position.
c40e2fb2 2407
0e14fe90
EZ
2408 * xdisp.c (set_cursor_from_row): Set start and stop points
2409 according to the row's direction when priming the loop that looks
2410 for the glyph on which to display cursor.
2411 (single_display_spec_intangible_p): Function deleted.
2412 (display_prop_intangible_p): Reimplement to call
2413 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2414 Accept 3 additional arguments needed by handle_display_spec.
2415 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2416 values: lists, `(when COND...)' forms, etc.
2417 (single_display_spec_string_p): Support property values that are
2418 lists with the argument STRING its top-level element.
2419 (display_prop_string_p): Fix the condition for processing a
2420 property that is a list to be consistent with handle_display_spec.
fec2107c 2421 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2422 last portion of handle_display_prop.
2423 (compute_display_string_pos): Accept additional argument
2424 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2425 value of a `display' property is a "replacing spec".
2426 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2427 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2428 the display property, but just return a value indicating whether
2429 the display property will replace the characters it covers.
2430 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2431 frame_window_p members of struct bidi_it.
d6d100dd
SM
2432 (compute_display_string_pos, compute_display_string_end):
2433 New functions.
fec2107c
EZ
2434 (push_it): Accept second argument POSITION, where pop_it should
2435 jump to continue iteration.
2436 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2437
fec2107c
EZ
2438 * keyboard.c (adjust_point_for_property): Adjust the call to
2439 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2440
2441 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2442 (bidi_init_it): Update prototypes.
2443 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2444 (compute_display_string_pos, compute_display_string_end):
2445 Declare prototypes.
fec2107c
EZ
2446 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2447 EMACS_INT.
fc6f18ce 2448
40087514 24492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2450
57f53182
PE
2451 Malloc failure behavior now depends on size of allocation.
2452 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2453 * lisp.h: Change signatures accordingly.
2454 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2455 All callers changed. (Bug#8762)
2456
2457 * gnutls.c: Use Emacs's memory allocators.
2458 Without this change, the gnutls library would invoke malloc etc.
2459 directly, which causes problems on non-SYNC_INPUT hosts, and which
2460 runs afoul of improving memory_full behavior. (Bug#8761)
2461 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2462 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2463 xfree instead of the default malloc, realloc, free.
2464 (Fgnutls_boot): No need to check for memory allocation failure,
2465 since xmalloc does that for us.
2466
ac32cd99 2467 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2468 * category.c (hash_get_category_set):
2469 * ccl.c (ccl_driver):
2470 * charset.c (Fdefine_charset_internal):
2471 * charset.h (struct charset.hash_index):
2472 * composite.c (get_composition_id, gstring_lookup_cache)
2473 (composition_gstring_put_cache):
2474 * composite.h (struct composition.hash_index):
2475 * dispextern.h (struct image.hash):
2476 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2477 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2478 (hashfn_equal, hashfn_user_defined, make_hash_table)
2479 (maybe_resize_hash_table, hash_lookup, hash_put)
2480 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2481 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2482 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2483 * image.c (make_image, search_image_cache, lookup_image)
2484 (xpm_put_color_table_h):
2485 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2486 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2487 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2488 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2489 * alloc.c (allocate_vectorlike):
2490 Check for overflow in vector size calculations.
2491 * ccl.c (ccl_driver):
2492 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2493 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2494 need to be updated by these changes.
40087514
PE
2495 * fns.c (make_hash_table, maybe_resize_hash_table):
2496 Check for integer overflow with large hash tables.
0de4bb68
PE
2497 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2498 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2499 (SXHASH_REDUCE): New macro.
2500 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2501 Use it instead of discarding useful hash info with large hash values.
2502 (sxhash_float): New function.
2503 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2504 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2505 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2506 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2507 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2508 Adjust signatures to match updated version of code.
2509 (consing_since_gc): Now EMACS_INT, since a single hash table can
2510 use more than INT_MAX bytes.
2511
698d32e2
DN
25122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2513
2514 Make it possible to build with GCC-4.6+ -O2 -flto.
2515
2516 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2517
fd6fa53f
SM
25182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2519
2520 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2521 Call minibuffer-inactive-mode.
2522
864db017
JB
25232011-05-31 Juanma Barranquero <lekktu@gmail.com>
2524
2525 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2526 Update dependencies.
2527
2ad0baf4
DN
25282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2529
2530 * data.c (init_data): Remove code for UTS, this system is not
2531 supported anymore.
2532
4fcc2638
DN
25332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2534
2535 Don't force ./temacs to start in terminal mode.
2536
2537 * frame.c (make_initial_frame): Initialize faces in all cases, not
2538 only when CANNOT_DUMP is defined.
2539 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2540
c56e0fd5
DN
25412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2542
2543 * dispnew.c (add_window_display_history): Use const for the string
2544 pointer. Remove declaration, not needed.
2545
333d54da 25462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2547
55d4c1b2 2548 Use 'inline', not 'INLINE'.
333d54da 2549 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2550 * alloc.c, fontset.c (INLINE): Remove.
2551 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2552 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2553 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2554 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2555 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2556
738db178
DN
25572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2558
2559 Make it possible to run ./temacs.
2560
2561 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2562 syms_of_callproc does the same thing. Remove test for
2563 "initialized", do it in the caller.
2564 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2565
620c53a6
SM
25662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2567
2568 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2569 (read_minibuf): Use get_minibuffer.
2570 (syms_of_minibuf): Use DEFSYM.
2571 (Qmetadata): New var.
2572 * data.c (Qbuffer): Don't make it static.
2573 (syms_of_data): Use DEFSYM.
2574
e003a292
PE
25752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2578 (CCL_CODE_MIN): New macro.
2579
ed008a6d
PE
25802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2581
3687c2ef
PE
2582 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2583
ed008a6d
PE
2584 * eval.c (Qdebug): Now static.
2585 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2586 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2587 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2588
d66c4c7c
CY
25892011-05-29 Chong Yidong <cyd@stupidchicken.com>
2590
2591 * image.c: Various fixes to ImageMagick code comments.
2592 (Fimagemagick_types): Doc fix.
2593
5fbc2025
PE
25942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2595
0196f88a
PE
2596 Minor fixes prompted by GCC 4.6.0 warnings.
2597
2598 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2599
5fbc2025
PE
2600 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2601 (x_clipboard_manager_save_all): Move extern decl to ...
2602 * xterm.h: ... here, so that it can be checked for consistency.
2603
1dd3c2d9
CY
26042011-05-29 Chong Yidong <cyd@stupidchicken.com>
2605
2606 * xselect.c (x_clipboard_manager_save_frame)
2607 (x_clipboard_manager_save_all): New functions.
2608 (Fx_clipboard_manager_save): Lisp function deleted.
2609
2610 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2611 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2612
2613 * xterm.h: Update prototype.
2614
5ba6571d
WX
26152011-05-28 William Xu <william.xwl@gmail.com>
2616
2617 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2618 exiting (Bug#8239).
2619
3eaff834
JM
26202011-05-28 Jim Meyering <meyering@redhat.com>
2621
e1900994 2622 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2623 * fns.c (to_uchar): Define.
2624 (crypto_hash_function): Use it to convert some newly-signed
2625 variables to unsigned, to avoid sign-extension bugs. For example,
2626 without this change, (md5 "truc") would evaluate to
2627 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2628 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2629 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2630
0f6990a7
PE
26312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2632
2633 Integer overflow fixes.
c8a9ca5a 2634
08686060
PE
2635 * dbusbind.c: Serial number integer overflow fixes.
2636 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2637 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2638 to hold a serial number that is too large for a fixnum.
2639 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2640 Check for serial numbers out of range. Decode any serial number
59568bf0 2641 that was so large that it became a float. (Bug#8722)
08686060 2642
2d1fc3c7
PE
2643 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2644 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2645 Use XFASTINT rather than XUINT when numbers are nonnegative.
2646 (xd_append_arg, Fdbus_method_return_internal):
2647 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2648 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2649 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2650 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2651 (Bug#8722)
2d1fc3c7 2652
c8a9ca5a
PE
2653 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2654
519e1d69
PE
2655 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2656
30569699
PE
2657 ccl: add integer overflow checks
2658 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2659 (IN_INT_RANGE): New macros.
2660 (ccl_driver): Use them to check for integer overflow when
2661 decoding a CCL program. Many of the new checks are whether XINT (x)
2662 fits in int; it doesn't always, on 64-bit hosts. The new version
2663 doesn't catch all possible integer overflows, but it's an
847044ea 2664 improvement. (Bug#8719)
30569699 2665
c11285dc
PE
2666 * alloc.c (make_event_array): Use XINT, not XUINT.
2667 There's no need for unsigned here.
2668
fdccd48e
PE
2669 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2670 This follows up to the 2011-05-06 change that substituted uintptr_t
2671 for EMACS_INT. This case wasn't caught back then.
2672
37910ab2
PE
2673 Rework Fformat to avoid integer overflow issues.
2674 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2675 now (part of C89). Include <verify.h>.
2676 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2677 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2678 (Fformat): Avoid the prepass trying to compute sizes; it was only
2679 approximate and thus did not catch overflow reliably. Instead, walk
2680 through the format just once, formatting and computing sizes as we go,
2681 checking for integer overflow at every step, and allocating a larger
2682 buffer as needed. Keep track separately whether the format is
2683 multibyte. Keep only the most-recently calculated precision, rather
2684 than them all. Record whether each argument has been converted to
2685 string. Use EMACS_INT, not int, for byte and char and arg counts.
2686 Support field widths and precisions larger than INT_MAX. Avoid
2687 sprintf's undefined behavior with conversion specifications such as %#d
2688 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2689 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2690 formatting out-of-range floating point numbers with int
9173deec 2691 formats. (Bug#8668)
37910ab2 2692
2e6578fb
PE
2693 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2694
0ae6bdee
PE
2695 * data.c: Avoid integer truncation in expressions involving floats.
2696 * data.c: Include <intprops.h>.
2697 (arith_driver): When there's an integer overflow in an expression
2698 involving floating point, convert the integers to floating point
2699 so that the resulting value does not suffer from catastrophic
2700 integer truncation. For example, on a 64-bit host (* 4
2701 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2702 Do not rely on undefined behavior after integer overflow.
2703
de883a70
PE
2704 merge count_size_as_multibyte, parse_str_to_multibyte
2705 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2706 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2707 Check for integer overflow.
2708 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2709 since it's now a duplicate of the other. This is more of
2710 a character than a buffer op, so better that it's in character.c.
2711 * fns.c, print.c: Adjust to above changes.
2712
2ff916cb
PE
27132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2714
2715 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2716
f1b54466
PE
27172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2718
fb1ac845
PE
2719 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2720 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2721 (x_clipboard_manager_save): Now static.
2722 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2723
f1b54466
PE
2724 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2725 (crypto_hash_function): Now static.
2726 Fix pointer signedness problems. Avoid unnecessary initializations.
2727
a9f737ee
CY
27282011-05-27 Chong Yidong <cyd@stupidchicken.com>
2729
2730 * termhooks.h (Vselection_alist): Make it terminal-local.
2731
2732 * terminal.c (create_terminal): Initialize it.
2733
2734 * xselect.c: Support for clipboard managers.
2735 (Vselection_alist): Move to termhooks.h as terminal-local var.
2736 (LOCAL_SELECTION): New macro.
2737 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2738 (symbol_to_x_atom): Remove gratuitous arg.
2739 (x_handle_selection_request, lisp_data_to_selection_data)
2740 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2741 (x_own_selection, x_get_local_selection, x_convert_selection):
2742 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2743 (some_frame_on_display): Delete unused function.
2744 (Fx_own_selection_internal, Fx_get_selection_internal)
2745 (Fx_disown_selection_internal, Fx_selection_owner_p)
2746 (Fx_selection_exists_p): New optional frame arg.
2747 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2748 (x_handle_selection_clear): Don't treat other terminals with the
2749 same keyboard specially. Use the terminal-local Vselection_alist.
2750 (x_clear_frame_selections): Use Frun_hook_with_args.
2751
2752 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2753
2754 * xterm.h: Add support for those atoms.
2755
e067f0c1
CY
27562011-05-26 Chong Yidong <cyd@stupidchicken.com>
2757
2758 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2759 (converted_selections, conversion_fail_tag): New global variables.
2760 (x_selection_request_lisp_error): Free the above.
2761 (x_get_local_selection): Remove unnecessary code.
2762 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2763 of converted selections stored in converted_selections.
2764 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2765 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2766 (x_convert_selection): New function.
2767 (x_handle_selection_event): Simplify.
2768 (x_get_foreign_selection): Don't ignore incoming requests while
2769 waiting for an answer; this will fail when we implement
2770 SAVE_TARGETS, and seems unnecessary anyway.
2771 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2772 (Vx_sent_selection_functions): Doc fix.
2773
0f4aebc0
LL
27742011-05-26 Leo Liu <sdl.web@gmail.com>
2775
2776 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2777
e61124cd
YM
27782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2779
2780 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2781
2782 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2783 for fringe update if it has periodic bitmap.
ac389d0c 2784 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2785 and fringe_bitmap_periodic_p.
2786
2787 * fringe.c (get_fringe_bitmap_data): New function.
2788 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2789 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2790 row. Mark glyph row for fringe update if periodicity changed.
2791
2792 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2793 for fringe update unless it has periodic bitmap.
2794
f16d9837
KH
27952011-05-25 Kenichi Handa <handa@m17n.org>
2796
2797 * xdisp.c (get_next_display_element): Set correct it->face_id for
2798 a static composition.
2799
e1b90ef6
LL
28002011-05-24 Leo Liu <sdl.web@gmail.com>
2801
2802 * deps.mk (fns.o):
2803 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2804
2805 * fns.c (crypto_hash_function, Fsha1): New function.
2806 (Fmd5): Use crypto_hash_function.
2807 (syms_of_fns): Add Ssha1.
2808
7400048f
PE
28092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 * gnutls.c: Remove unused macros.
2812 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2813 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2814 Remove macros that are defined and never used.
2815 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2816
abb71cf4
CY
28172011-05-22 Chong Yidong <cyd@stupidchicken.com>
2818
2819 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2820 (Fx_get_selection_internal): Minor cleanup.
2821 (Fx_own_selection_internal): Rename arguments for consistency with
2822 select.el.
2823
6307db39
PE
28242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2827
f3d4e0a4
CY
28282011-05-22 Chong Yidong <cyd@stupidchicken.com>
2829
2830 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2831
4d8ade89
YM
28322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2833
2834 * dispnew.c (scrolling_window): Don't exclude the case that the
2835 last enabled row in the desired matrix touches the bottom boundary.
2836
32078c8d
GM
28372011-05-21 Glenn Morris <rgm@gnu.org>
2838
2839 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2840 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2841 and add some more files.
32078c8d 2842
7285dc67
EZ
28432011-05-20 Eli Zaretskii <eliz@gnu.org>
2844
2845 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2846 report_file_error introduced by the change from 2011-05-07.
2847
89d1bd22
PE
28482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 * systime.h (Time): Define only if emacs is defined.
2851 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2852 where the include path doesn't have X11/X.h by default. See
2853 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2854
e23640bb 28552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2856
2857 * composite.c (find_automatic_composition): Fix previous change.
2858
b9704ad9
GM
28592011-05-20 Glenn Morris <rgm@gnu.org>
2860
2861 * lisp.mk: New file, split from Makefile.in.
2862 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2863 (shortlisp): Remove.
2864 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2865
4a720484
GM
28662011-05-19 Glenn Morris <rgm@gnu.org>
2867
2868 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2869 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2870 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2871 (lisp): Set the order to that of loadup.el.
2872 (shortlisp): Make it a copy of $lisp.
2873 (SOME_MACHINE_LISP): Remove.
2874 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2875 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2876
a28d4396
KH
28772011-05-18 Kenichi Handa <handa@m17n.org>
2878
2879 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2880 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2881 (find_automatic_composition): Mostly rewrite for efficiency.
2882
a2b1fa8e
JB
28832011-05-18 Juanma Barranquero <lekktu@gmail.com>
2884
2885 * makefile.w32-in: Update dependencies.
2886
8e1f5610
CS
28872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2888
2889 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2890 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2891
7025ee00 28922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2893
cdfa6eab
PE
2894 Fix some integer overflow issues, such as string length overflow.
2895
06d6db33
PE
2896 * insdel.c (count_size_as_multibyte): Check for string overflow.
2897
2b4560a8
PE
2898 * character.c (lisp_string_width): Check for string overflow.
2899 Use EMACS_INT, not int, for string indexes and lengths; in
2900 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2901 the resulting string length overflows an EMACS_INT; instead,
2902 report a string overflow if no precision given. When checking for
2903 precision exhaustion, use a check that cannot possibly have
2904 integer overflow. (Bug#8675)
2905 * character.h (lisp_string_width): Adjust to new signature.
2906
cb93f9be
PE
2907 * alloc.c (string_overflow): New function.
2908 (Fmake_string): Use it. This doesn't change behavior, but saves
2909 a few bytes and will simplify future changes.
2910 * character.c (string_escape_byte8): Likewise.
2911 * lisp.h (string_overflow): New decl.
2912
1a1f3366
PE
2913 Fixups, following up to the user-interface timestamp change.
2914 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2915 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2916 * msdos.c (mouse_get_pos): Likewise.
2917 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2918 * w32gui.h (Time): Define by including "systime.h" rather than by
2919 declaring it ourselves. (Bug#8664)
2920
d4e3e4d3
PE
2921 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2922 * image.c (clear_image_cache): Likewise.
2923
f6a24d19
PE
2924 * term.c (term_mouse_position): Don't assume time_t wraparound.
2925
08dc5ae6
PE
2926 Be more systematic about user-interface timestamps.
2927 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2928 and sometimes 'EMACS_UINT', to represent these timestamps.
2929 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2930 This makes the code easier to follow, and makes it easier to catch
2931 integer overflow bugs such as Bug#8664.
2932 * frame.c (Fmouse_position, Fmouse_pixel_position):
2933 Use Time, not unsigned long, for user-interface timestamps.
2934 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2935 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2936 * keyboard.h (last_event_timestamp): Likewise.
2937 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2938 * menu.h (xmenu_show): Likewise.
2939 * term.c (term_mouse_position): Likewise.
2940 * termhooks.h (struct input_event.timestamp): Likewise.
2941 (struct terminal.mouse_position_hook): Likewise.
2942 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2943 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2944 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2945 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2946 what it was before.
2947 * menu.h, termhooks.h: Include "systime.h", for Time.
2948
8e55734a
PE
2949 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2950 Don't assume that the difference between two unsigned long values
2951 can fit into an integer. At this point, we know button_down_time
2952 <= event->timestamp, so the difference must be nonnegative, so
2953 there's no need to cast the result if double-click-time is
2954 nonnegative, as it should be; check that it's nonnegative, just in
2955 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2956 apart (about 25 days). (Bug#8664)
8e55734a 2957
841f1b75 2958 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2959 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2960
3e26f69c
PE
2961 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2962 that always fit in int. Use a sentinel instead of a counter, to
2963 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2964 * frame.h (struct frame): Use int for menu_bar_items_used
2965 instead of EMACS_INT, since it always fits in int.
3e26f69c 2966
5cc152c0
PE
2967 * menu.c (grow_menu_items): Check for int overflow.
2968
d89eb65e
PE
2969 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2970
5235bd3e
PE
2971 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2972 Before, the code was not consistent. These values cannot exceed
2973 2**31 - 1 so there's no need to make them unsigned.
2974 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2975 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2976 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2977 as modifiers.
2978 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2979
bc827e23
PE
2980 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2981 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2982 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2983 presumably because the widths might not match.
2984
78eb494e
PE
2985 * window.c (size_window): Avoid needless test at loop start.
2986
04f2d78b
CB
29872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2988
2989 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2990
d2fc7e3d 29912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2992
2993 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2994
d2fc7e3d 29952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2996
2997 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2998 `width' to `bar_area_x' and `bar_area_width', respectively.
2999 (x_scroll_run): Take account of fringe background extension.
3000
04f2d78b
CB
3001 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3002 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3003 `bar_area_width', respectively.
3004 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3005 background extension.
3006
79b70037
GM
30072011-05-10 Jim Meyering <meyering@redhat.com>
3008
3009 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3010
2f142cc5
JB
30112011-05-10 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * image.c (Finit_image_library): Return t for built-in image types,
3014 like pbm and xbm. (Bug#8640)
3015
57679c86
AS
30162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3017
3018 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3019
888c9e86
EZ
30202011-05-07 Eli Zaretskii <eliz@gnu.org>
3021
b0512a1d
EZ
3022 * w32console.c (Fset_screen_color): Doc fix.
3023 (Fget_screen_color): New function.
3024 (syms_of_ntterm): Defsubr it.
3025
7285dc67
EZ
3026 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3027 unlink the temporary file if Fcall_process didn't create it in the
3028 first place.
3029 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3030 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3031 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3032 cue to call_process_cleanup not to close that handle.
3033
4d3fcc8e
BK
30342011-05-07 Ben Key <bkey76@gmail.com>
3035
3036 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3037 one of two shell specific rules, either bootstrap-temacs-CMD or
3038 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3039 to the previous implementation of the bootstrap-temacs rule.
3040 The bootstrap-temacs-CMD rule is similar to the previous
3041 implementation of the bootstrap-temacs rule except that it
3042 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3043 variable.
3044
3045 These changes, along with some changes to nt/configure.bat,
3046 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3047 earlier fix to add support for --cflags and --ldflags options
3048 that include quotes so that it works whether make uses cmd or
3049 sh as the shell.
3050
b4289b64
MA
30512011-05-06 Michael Albinus <michael.albinus@gmx.de>
3052
3053 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3054 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3055 is a constant.
3056 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3057 a string. Handle both cases.
3058 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3059 (Fdbus_register_method): Use Qinvalid_function.
3060
af4c0e28
JB
30612011-05-06 Juanma Barranquero <lekktu@gmail.com>
3062
3063 * makefile.w32-in: Update dependencies.
3064 (LISP_H): Add inttypes.h and stdin.h.
3065 (PROCESS_H): Add unistd.h.
3066
c51453d9
EZ
30672011-05-06 Eli Zaretskii <eliz@gnu.org>
3068
3069 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3070 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3071
8ff0ac3c 30722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3073
4c4b566b
PE
3074 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3075
aab2b9b5
PE
3076 * term.c (vfatal): Remove stray call to va_end.
3077 It's not needed and the C Standard doesn't allow it here anyway.
3078
c378da0b
PE
3079 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3080 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3081
288b08c7
PE
3082 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3083 bytes.
3084
e3601888
PE
3085 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3086
db6c0e74
PE
3087 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3088
dd5963ea
PE
3089 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3090
88c9450f
PE
3091 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3092
2f9442b8
PE
3093 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3094
c032b5f8
PE
3095 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3096 * charset.c (Fdefine_charset_internal): Don't initialize
3097 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3098 32-bit int (Bug#8600).
a108c10b
PE
3099
3100 * lread.c (read_integer): Be more consistent with string-to-number.
3101 Use string_to_number to do the actual conversion; this avoids
3102 rounding errors and fixes some other screwups. Without this fix,
3103 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3104 (digit_to_number): Move earlier, for benefit of read_integer.
3105 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3106 not a digit in any supported base. (Bug#8602)
a108c10b 3107
ad5f9eea
PE
3108 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3109
aec1708a
PE
3110 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3111 to match comment at start of function. This also removes a
3112 GCC warning about overflow in a 32+64-bit port.
3113
47be4ab5
PE
3114 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3115
371cac43
PE
3116 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3117 Reported by Stefan Monnier in
3118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3119 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3120 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3121
d01a7826
PE
3122 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3123 (EMACS_UINTPTR): Likewise, with uintptr_t.
3124
7fd47d5c
PE
3125 * lisp.h: Prefer 64-bit EMACS_INT if available.
3126 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3127 on 32-bit hosts that have 64-bit int, so that they can access
3128 large files.
122b0c86
PE
3129 However, temporarily disable this change unless the temporary
3130 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3131
8727937b
PE
3132 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3133
8ac068ac
PE
3134 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3135 This removes an assumption that EMACS_INT and long are the same
3136 width as pointers. The assumption is true for Emacs porting targets
3137 now, but we want to make other targets possible.
3138 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3139 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3140 In the rest of the code, change types of integers that hold casted
3141 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3142 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3143 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3144 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3145 No need to cast type when ORing.
3146 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3147 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3148 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3149 assume EMACS_INT is the same width as char *.
3150 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3151 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3152 Remove no-longer-needed casts.
3153 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3154 (xg_tool_bar_help_callback, xg_make_tool_item):
3155 Use EMACS_INTPTR to hold an integer
3156 that will be cast to void *; this can avoid a GCC warning
3157 if EMACS_INT is not the same width as void *.
3158 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3159 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3160 (current_message_1, set_message_1):
3161 Use a local to convert to proper width without a cast.
3162 * xmenu.c (dialog_selection_callback): Likewise.
3163
ede49d71
PE
3164 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3165 Also, don't assume VALBITS / RAND_BITS is less than 5,
3166 and don't rely on undefined behavior when shifting a 1 left into
3167 the sign bit.
3168 * lisp.h (get_random): Change signature to match.
3169
2f30ecd0
PE
3170 * lread.c (hash_string): Use size_t, not int, for hash computation.
3171 Normally we prefer signed values; but hashing is special, because
3172 it's better to use unsigned division on hash table sizes so that
3173 the remainder is nonnegative. Also, size_t is the natural width
3174 for hashing into memory. The previous code used 'int', which doesn't
3175 retain enough info to hash well into very large tables.
3176 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3177
2a866e7b
PE
3178 * dbusbind.c: Don't possibly lose pointer info when converting.
3179 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3180 Use XPNTR rather than XHASH, so that the high-order bits of
3181 the pointer aren't lost when converting through void *.
3182
51639eac
PE
3183 * eval.c (Fautoload): Don't double-shift a pointer.
3184
92394119
PE
3185 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3186
dbdb9a7c
JB
31872011-05-06 Juanma Barranquero <lekktu@gmail.com>
3188
3189 * gnutls.c (DEF_GNUTLS_FN):
3190 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3191
db7a0b4f
AS
31922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3193
3194 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3195 marker. (Bug#8610)
3196
f7ff1b0f 31972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3198
3199 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3200 New version that can reserve upto 2GB of heap space.
3201
f7ff1b0f 32022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3203
3204 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3205
639c109b
TZ
32062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3207
3208 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3209 `gnutls_certificate_set_x509_key_file'.
3210
d2127135
JB
32112011-05-05 Juanma Barranquero <lekktu@gmail.com>
3212
3213 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3214 Update dependencies.
3215
e968f4f3
JB
32162011-05-04 Juanma Barranquero <lekktu@gmail.com>
3217
3218 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3219 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3220 Remove unused parameter `fildes'.
3221 * process.c (read_process_output, send_process): Don't pass it.
3222
84d358f0
JB
32232011-05-04 Juanma Barranquero <lekktu@gmail.com>
3224
3225 Fix previous change: the library cache is defined in w32.c.
3226 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3227 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3228
0898ca10
JB
32292011-05-04 Juanma Barranquero <lekktu@gmail.com>
3230
3231 Implement dynamic loading of GnuTLS on Windows.
3232
3233 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3234 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3235 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3236 Declare.
3237
3238 * gnutls.c (Qgnutls_dll): Define.
3239 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3240 (gnutls_*): Declare function pointers.
3241 (init_gnutls_functions): New function to initialize function pointers.
3242 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3243 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3244 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3245 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3246 (emacs_gnutls_write, emacs_gnutls_read)
3247 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3248 (Fgnutls_available_p): New function.
3249 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3250 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3251 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3252
3253 * image.c: Include w32.h.
3254 (Vimage_type_cache): Delete.
3255 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3256 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3257 (w32_delayed_load): Move to w32.c.
3258
3259 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3260
3261 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3262 (w32_delayed_load): Move from image.c. When loading a library, record
3263 its filename in the :loaded-from property of the library id.
3264 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3265 Initialize and staticpro them.
3266 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3267
3268 * process.c: Include lisp.h before w32.h, not after.
3269 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3270 instead of gnutls_record_check_pending.
3271
3272 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3273
ff4de4aa
TZ
32742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3275
3276 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3277 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3278 as passed in.
3279
abe95abb
JD
32802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3281
3282 * xterm.c (x_set_frame_alpha): Do not set property on anything
3283 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3284
e16e55d4
JB
32852011-05-02 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3288
bafcf6a5
JB
32892011-05-02 Juanma Barranquero <lekktu@gmail.com>
3290
3291 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3292 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3293 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3294 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3295 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3296 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3297 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3298 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3299 (Qgnutls_bootprop_callbacks_verify): Make static.
3300
e7a6747f
AS
33012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3302
19ed11ba
AS
3303 * callproc.c: Indentation fixup.
3304
e7a6747f 3305 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3306 (wait_for_termination, interruptible_wait_for_termination):
3307 Move after wait_for_termination_1.
e7a6747f 3308
1ef14cb4
LMI
33092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3310
3311 * sysdep.c (interruptible_wait_for_termination): New function
3312 which is like wait_for_termination, but allows keyboard
3313 interruptions.
3314
3315 * callproc.c (Fcall_process): Add (:file "file") as an option for
3316 the STDOUT buffer.
3317 (Fcall_process_region): Ditto.
3318
330d880c
EZ
33192011-04-30 Eli Zaretskii <eliz@gnu.org>
3320
8db90b73
EZ
3321 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3322 rather than `XVECTOR (FOO)->size'.
3323
330d880c
EZ
3324 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3325 inttypes.h, as a gnulib replacement is used if it not available in
3326 system headers.
3327
15cbd324
EZ
33282011-04-21 Eli Zaretskii <eliz@gnu.org>
3329
3330 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3331 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3332 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3333
3334 * coding.c (coding_alloc_by_realloc): Error out if destination
3335 will grow beyond MOST_POSITIVE_FIXNUM.
3336 (decode_coding_emacs_mule): Abort if there isn't enough place in
3337 charbuf for the composition carryover bytes. Reserve an extra
3338 space for up to 2 characters produced in a loop.
3339 (decode_coding_iso_2022): Abort if there isn't enough place in
3340 charbuf for the composition carryover bytes.
3341
33422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3343
ae940cca
EZ
3344 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3345 aborting when %lld or %lll format is passed.
3346 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3347 %llo or %llx format is passed. (Bug#8545)
3348
03ab8921
EZ
3349 * window.c (window_scroll_line_based): Use a marker instead of
3350 simple variables to record original value of point. (Bug#7952)
3351
afda1437
EZ
3352 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3353 produced by %s or %c overflows available buffer space. (Bug#8545)
3354
f76dee0c
PE
33552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3356
3357 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3358 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3359
fdc5744d
JB
33602011-04-28 Juanma Barranquero <lekktu@gmail.com>
3361
3362 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3363
638f053a
JB
33642011-04-28 Juanma Barranquero <lekktu@gmail.com>
3365
3366 * keyboard.c (Qdelayed_warnings_hook): Define.
3367 (command_loop_1): Run `delayed-warnings-hook'
3368 if Vdelayed_warnings_list is non-nil.
3369 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3370 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3371
d178f871
EZ
33722011-04-28 Eli Zaretskii <eliz@gnu.org>
3373
3374 * doprnt.c (doprnt): Don't return value smaller than the buffer
3375 size if the message was truncated. (Bug#8545).
3376
b124fd93
JB
33772011-04-28 Juanma Barranquero <lekktu@gmail.com>
3378
3379 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3380 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3381
e810457d
PE
33822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3385
ea51cceb
JB
33862011-04-27 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * makefile.w32-in: Update dependencies.
3389
94dcfacf
EZ
33902011-04-27 Eli Zaretskii <eliz@gnu.org>
3391
3392 Improve `doprnt' and its usage. (Bug#8545)
3393 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3394 `format_end'. Remove support for %l as a conversion specifier.
3395 Don't use xrealloc. Improve diagnostics when the %l size modifier
3396 is used. Update the commentary.
3397
3398 * eval.c (verror): Simplify calculation of size_t.
3399
3400 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3401 messages.
3402
f61f41d7
PE
34032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3404
3405 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3406 change.
3407
96fb4434
PE
34082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3411 This makes this file independent of the recent pseudovector change.
3412
671875da 34132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3414
69e9b5a3
PE
3415 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3416
b5f869a7 3417 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3418 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3419 Remove unused local.
c8926152 3420 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3421
841a1577 3422 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3423 GCC 4.6.0 optimizes based on type-based alias analysis.
3424 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3425 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3426 != &v->size, and therefore "v->size = 1; b->size = 2; return
3427 v->size;" must therefore return 1. This assumption is incorrect
3428 for Emacs, since it type-puns struct Lisp_Vector * with many other
3429 types. To fix this problem, this patch adds a new type struct
f904488f 3430 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3431 and pseudovectors, and helps optimizing compilers not get fooled
3432 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3433 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3434 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3435 the size member.
eab3844f
PE
3436 (XSETPVECTYPE): Rewrite in terms of new macro.
3437 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3438 This is a bit clearer, and further avoids the possibility of
3439 undesirable aliasing.
3440 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3441 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3442 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3443 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3444 (ASIZE): Now uses header.size rather than size.
3445 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3446 to avoid the hassle of writing XVECTOR (foo)->header.size.
3447 (struct vectorlike_header): New type.
eab3844f
PE
3448 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3449 object, to help avoid aliasing.
3450 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3451 (SUBRP): Likewise, since Lisp_Subr is a special case.
3452 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3453 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3454 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3455 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3456 changed to be "header.size" and "header.next".
3457 * buffer.h (struct buffer): Likewise.
3458 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3459 * frame.h (struct frame): Likewise.
3460 * process.h (struct Lisp_Process): Likewise.
3461 * termhooks.h (struct terminal): Likewise.
3462 * window.c (struct save_window_data, struct saved_window): Likewise.
3463 * window.h (struct window): Likewise.
3464 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3465 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3466 * buffer.c (init_buffer_once): Likewise.
3467 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3468 special case.
3469 * process.c (Fformat_network_address): Use local var for size,
3470 for brevity.
3471
0df1eac5
PE
3472 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3473
847ab9d1 3474 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3475 * data.c (atof): Remove decl; no longer used or needed.
3476 (digit_to_number): Move to lread.c.
3477 (Fstring_to_number): Use new string_to_number function, to be
3478 consistent with how the Lisp reader treats infinities and NaNs.
3479 Do not assume that floating-point numbers represent EMACS_INT
3480 without losing information; this is not true on most 64-bit hosts.
3481 Avoid double-rounding errors, by insisting on integers when
3482 parsing non-base-10 numbers, as the documentation specifies.
3483 * lisp.h (string_to_number): New decl, replacing ...
3484 (isfloat_string): Remove.
bc0a5c13 3485 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3486 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3487 appears to have been a coding error. Similarly, do not accept
3488 strings like +-1e0 as floating point numbers. Do not report
3489 overflow for integer overflows unless the base is not 10 which
3490 means we have no simple and reliable way to continue.
3491 Break out the floating-point parsing into a new
3492 function string_to_number, so that Fstring_to_number parses
3493 floating point numbers consistently with the Lisp reader.
04f2d78b 3494 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3495 (E_CHAR, EXP_INT): Remove, replacing with ...
3496 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3497 (string_to_number): New function, replacing isfloat_string.
3498 This function checks for valid syntax and produces the resulting
3499 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3500 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3501 so that overflow for non-base-10 numbers is reported only when
3502 there's no portable and simple way to convert to floating point.
452f4150 3503
67769ffc
PE
3504 * textprop.c (set_text_properties_1): Rewrite for clarity,
3505 and to avoid GCC warning about integer overflow.
3506
c20db43f
PE
3507 * intervals.h (struct interval): Use EMACS_INT for members
3508 where EMACS_UINT might cause problems. See
3509 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3510 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3511 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3512 All uses changed.
37aa2f85
PE
3513 (offset_intervals): Tell GCC not to worry about length overflow
3514 when negating a negative length.
c20db43f 3515
2538aa2f
PE
3516 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3517 (overrun_check_free): Likewise.
3518
f2d3008d
PE
3519 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3520 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3521 word size.
3522
ec8df744
PE
3523 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3524 (gnutls_make_error): Rename local to avoid shadowing.
3525 (gnutls_emacs_global_deinit): ifdef out; not used.
3526 (Fgnutls_boot): Use const for pointer to readonly storage.
3527 Comment out unused local. Fix pointer signedness problems.
3528
640ee02d
PE
3529 * lread.c (openp): Don't stuff size_t into an 'int'.
3530 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3531 about possible signed overflow.
3532
6048fb2a
PE
3533 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3534 (GDK_KEY_g): Don't define if already defined.
3535 (xg_prepare_tooltip): Avoid pointer signedness problem.
3536 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3537
fa3c87e1
PE
3538 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3539 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3540
2172544b
PE
3541 * xfns.c (Fx_window_property): Simplify a bit,
3542 to make a bit faster and to avoid GCC 4.6.0 warning.
3543 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3544
9b821a21
PE
3545 * fns.c (internal_equal): Don't assume size_t fits in int.
3546
3c616cfa
PE
3547 * alloc.c (compact_small_strings): Tighten assertion a little.
3548
c2982e87
PE
3549 Replace pEd with more-general pI, and fix some printf arg casts.
3550 * lisp.h (pI): New macro, generalizing old pEd macro to other
3551 conversion specifiers. For example, use "...%"pI"d..." rather
3552 than "...%"pEd"...".
3553 (pEd): Remove. All uses replaced with similar uses of pI.
3554 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3555 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3556 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3557 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3558 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3559 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3560 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3561 64-bit hosts.
3562 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3563 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3564 * print.c (safe_debug_print, print_object): Likewise.
3565 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3566 to int.
6f04d126
PE
3567 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3568 avoiding the 0 flag, which is not portable.
c2982e87
PE
3569 * process.c (Fmake_network_process): Use pI to avoid cast.
3570 * region-cache.c (pp_cache): Likewise.
3571 * xdisp.c (decode_mode_spec): Likewise.
3572 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3573 behavior on 64-bit hosts with printf arg.
6f04d126 3574 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3575 (x_stop_queuing_selection_requests): Likewise.
3576 (x_get_window_property): Don't truncate byte count to an 'int'
3577 when tracing.
0b432f21 3578
5e073ec7
PE
3579 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3580 here, since it parses constructs like leading '-' and spaces,
3581 which are not wanted; and it overflows with large numbers.
3582 Instead, simply match F[0-9]+, which is what is wanted anyway.
3583
36372bf9
PE
3584 * alloc.c: Remove unportable assumptions about struct layout.
3585 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3586 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3587 (allocate_vectorlike, make_pure_vector): Use the new macros,
3588 plus offsetof, to remove unportable assumptions about struct layout.
3589 These assumptions hold on all porting targets that I know of, but
3590 they are not guaranteed, they're easy to remove, and removing them
3591 makes further changes easier.
3592
0b432f21
PE
3593 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3594 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3595 (string_overrun_cookie): Now const. Use initializers that
3596 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3597 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3598 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3599 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3600 multiple of sizeof (EMACS_INT); it need not be, if
3601 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3602 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3603
895009e1
JB
36042011-04-26 Juanma Barranquero <lekktu@gmail.com>
3605
3606 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3607
6a7a1b0b
TZ
36082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3609
3610 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3611 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3612 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3613
841a1577 36142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3615
3616 * lisp.h (Qdebug): List symbol.
895009e1 3617 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3618 * keyboard.c (debug-on-event): New variable.
3619 (handle_user_signal): Break into debugger when debug-on-event
3620 matches the current signal symbol.
3621
f2d3ba6f
DN
36222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3623
3624 * alloc.c (check_sblock, check_string_bytes)
3625 (check_string_free_list): Convert to standard C.
3626
42ce4c63
TZ
36272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3628
3629 * w32.c (emacs_gnutls_push): Fix typo.
3630
825cd63c
EZ
36312011-04-25 Eli Zaretskii <eliz@gnu.org>
3632
fb11d64d
EZ
3633 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3634 "cast to pointer from integer of different size".
3635
825cd63c
EZ
3636 Improve doprnt and its use in verror. (Bug#8545)
3637 * doprnt.c (doprnt): Document the set of format control sequences
3638 supported by the function. Use SAFE_ALLOCA instead of always
3639 using `alloca'.
3640
3641 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3642 is one byte too soon. Don't use xrealloc; instead xfree and
3643 xmalloc anew.
3644
e061a11b
TZ
36452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3646
3647 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3648 callbacks stage.
3649
3650 * gnutls.c: Renamed global_initialized to
3651 gnutls_global_initialized. Added internals for the
3652 :verify-hostname-error, :verify-error, and :verify-flags
3653 parameters of `gnutls-boot' and documented those parameters in the
3654 docstring. Start callback support.
9173deec
JB
3655 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3656 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3657 on error. Return error code.
e061a11b
TZ
3658 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3659 (emacs_gnutls_read): Likewise.
3660 (Fgnutls_boot): Return handshake error code.
3661 (emacs_gnutls_handle_error): New function.
3662 (wsaerror_to_errno): Likewise.
3663
3664 * w32.h (emacs_gnutls_pull): Add prototype.
3665 (emacs_gnutls_push): Likewise.
3666
3667 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3668 (emacs_gnutls_push): Likewise.
3669
36702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3671
3672 * process.c (wait_reading_process_output): Check if GnuTLS
3673 buffered some data internally if no FDs are set for TLS
3674 connections.
3675
3676 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3677 (LIBS): Link to USER_LIBS.
3678 ($(BLD)/gnutls.$(0)): New target.
3679
fa6996bc
EZ
36802011-04-24 Eli Zaretskii <eliz@gnu.org>
3681
eb35682e
EZ
3682 * xdisp.c (handle_single_display_spec): Rename the
3683 display_replaced_before_p argument into display_replaced_p, to
3684 make it consistent with the commentary. Fix typos in the
3685 commentary.
3686
e2ad650c
EZ
3687 * textprop.c (syms_of_textprop): Remove dead code.
3688 (copy_text_properties): Delete obsolete commentary about an
3689 interface that was deleted long ago. Fix typos in the description
3690 of arguments.
3691
1b2de274
EZ
3692 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3693 to changes in oldXMenu/XMenu.h from 2011-04-16.
3694 <menu_help_message, prev_menu_help_message>: Constify.
3695 (IT_menu_make_room): menu->help_text is now `const char **';
3696 adjust.
3697
3698 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3699 to changes in oldXMenu/XMenu.h from 2011-04-16.
3700 (struct XMenu): Declare `help_text' `const char **'.
3701
3702 * xfaces.c <Qunspecified>: Make extern again.
3703
3704 * syntax.c: Include sys/types.h before including regex.h, as
3705 required by Posix.
3706
762b15be
EZ
3707 * doc.c (get_doc_string): Improve the format passed to `error'.
3708
3709 * doprnt.c (doprnt): Improve commentary.
3710
3711 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3712
3713 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3714 them with etags.
3715
f1052e5d
EZ
3716 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3717 changes in globals.h immediately force recompilation.
762b15be
EZ
3718 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3719 $(CURDIR)/s/ms-w32.h.
3720 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3721
fa6996bc
EZ
3722 * character.c (Fchar_direction): Function deleted.
3723 (syms_of_character): Don't defsubr it.
3724 <char-direction-table>: Deleted.
3725
e6c3da20
EZ
37262011-04-23 Eli Zaretskii <eliz@gnu.org>
3727
3728 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3729 * doprnt.c: Include limits.h.
3730 (SIZE_MAX): New macro.
04f2d78b
CB
3731 (doprnt): Return a size_t value. 2nd arg is now size_t.
3732 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3733 Improve overflow protection. Support `l' modifier for integer
3734 conversions. Support %l conversion. Don't assume an EMACS_INT
3735 argument for integer conversions and for %c.
3736
3737 * lisp.h (doprnt): Restore prototype.
3738
3739 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3740 $(SRC)/character.h.
3741
3742 * Makefile.in (base_obj): Add back doprnt.o.
3743
3744 * deps.mk (doprnt.o): Add back prerequisites.
3745 (callint.o): Depend on character.h.
3746
3747 * eval.c (internal_lisp_condition_case): Include the handler
3748 representation in the error message.
3749 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3750 when breaking from the loop.
3751
3752 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3753
3754 * callint.c (Fcall_interactively): When displaying error message
3755 about invalid control letter, pass the character's codepoint, not
3756 a pointer to its multibyte form. Improve display of the character
3757 in octal and display also its hex code.
3758
3759 * character.c (char_string): Use %x to display the (unsigned)
3760 codepoint of an invalid character, to avoid displaying a bogus
3761 negative value.
3762
3763 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3764 `error', not SYMBOL_NAME itself.
3765
3766 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3767 character arguments to `error'.
3768
3769 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3770 to `error' in error message about FINAL_CHAR argument. Make sure
3771 FINAL_CHAR is a character, and use %c when it is passed as
3772 argument to `error'.
3773
4ffd0d6b 37742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3775
3776 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3777
3778 * w32.c: Include <time.h>.
3779 (sys_localtime): New function.
3780
4ffd0d6b 37812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3782
3783 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3784
4ffd0d6b 3785 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3786
4ffd0d6b 37872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3788
4ffd0d6b
GM
3789 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3790 zombies (Bug#8467).
aac0c6e3 3791
04c56954
EZ
37922011-04-19 Eli Zaretskii <eliz@gnu.org>
3793
3794 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3795 gl_state.e_property when gl_state.object is Qt.
3796
3797 * insdel.c (make_gap_larger): Remove limitation of buffer size
3798 to <= INT_MAX.
3799
16a43933
CY
38002011-04-18 Chong Yidong <cyd@stupidchicken.com>
3801
3802 * xdisp.c (lookup_glyphless_char_display)
3803 (produce_glyphless_glyph): Handle cons cell entry in
3804 glyphless-char-display.
3805 (Vglyphless_char_display): Document it.
3806
3807 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3808 glyphless-char-display.
3809
4581706e
CY
38102011-04-17 Chong Yidong <cyd@stupidchicken.com>
3811
3812 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3813
3814 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3815
3816 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3817 definition for no-X builds.
3818
4887c6e2 38192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3820
fd35b6f9
PE
3821 Static checks with GCC 4.6.0 and non-default toolkits.
3822
5c1ccb01
PE
3823 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3824
006c5daa
PE
3825 * process.c (keyboard_bit_set): Define only if SIGIO.
3826 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3827 (send_process): Repair possible setjmp clobbering.
3828
efc736d3
PE
3829 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3830
4e2fe2e6
PE
3831 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3832
f97334a2
PE
3833 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3834
4e75f29d
PE
3835 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3836 Define only if needed.
3837
90efadd1
PE
3838 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3839 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3840 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3841
3c647824
PE
3842 * dispextern.h (struct redisplay_interface): Rename param
3843 to avoid shadowing.
e264f262 3844 * termhooks.h (struct terminal): Likewise.
761383f4 3845 * xterm.c (xembed_send_message): Likewise.
3c647824 3846
b58c5c4a
PE
3847 * insdel.c (make_gap_smaller): Define only if
3848 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3849
cad59032
PE
3850 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3851 it.
3852
c339dc2e
PE
3853 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3854 so that we aren't warned about unused symbols.
3855
91a3e27b
PE
3856 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3857
399c71d3 3858 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3859
8ffc96f5
PE
3860 * xfns.c (x_real_positions): Mark locals as initialized.
3861
eef9bc79
PE
3862 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3863
098db9dd
PE
3864 * xterm.c: Fix problems found by static analysis with other toolkits.
3865 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3866 (x_dispatch_event): Declare static if USE_GTK, and
3867 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3868 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3869 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3870 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3871 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3872
eb18f6cc
PE
3873 * xmenu.c (menu_help_callback): Pointer type fixes.
3874 Use const pointers when pointing at readonly data. Avoid pointer
3875 signedness clashes.
3876 (FALSE): Remove unused macro.
3877 (update_frame_menubar): Remove unused decl.
3878
1fe72bf8
PE
3879 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3880
60d9e1db
PE
3881 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3882 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3883 (single_menu_item): Rename local to avoid shadowing.
3884
39261c26
PE
3885 * keyboard.c (make_lispy_event): Remove unused local var.
3886
018c5e19
PE
3887 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3888 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3889
63d2b86e
PE
3890 * bitmaps: Change bitmaps from unsigned char back to the X11
3891 compatible char. Avoid the old compiler warnings about
3892 out-of-range initializers by using, for example, '\xab' rather
3893 than 0xab.
3894
aefd87e1
PE
3895 * xgselect.c (xgselect_initialize): Check vs interface
3896 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3897
bf501fb9
PE
3898 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3899
e9829fdf
PE
3900 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3901 to read-only memory.
3902
1086c095
PE
3903 * fns.c (vector): Remove; this old hack is no longer needed.
3904
2baccd04 3905 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3906 Remove unused var.
dde42981 3907 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3908
72391843 3909 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3910
436c16df 3911 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3912 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3913 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3914
92bb796d 3915 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3916 (x_term_init): Remove local to avoid shadowing.
92bb796d 3917
764430a3 3918 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3919
3920 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3921 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3922
d1dfb56c
EZ
39232011-04-16 Eli Zaretskii <eliz@gnu.org>
3924
c4354cb4
EZ
3925 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3926
d1dfb56c
EZ
3927 Fix regex.c, syntax.c and friends for buffers > 2GB.
3928 * syntax.h (struct gl_state_s): Declare character position members
3929 EMACS_INT.
3930
3931 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3932
04f2d78b
CB
3933 * textprop.c (verify_interval_modification, interval_of):
3934 Declare arguments EMACS_INT.
d1dfb56c
EZ
3935
3936 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3937 EMACS_INT.
3938
3939 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3940
3941 * indent.c (Fvertical_motion): Local variable it_start is now
3942 EMACS_INT.
3943
3944 * regex.c (re_match, re_match_2, re_match_2_internal)
3945 (bcmp_translate, regcomp, regexec, print_double_string)
3946 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3947 (re_compile_pattern, re_exec): Declare arguments and local
3948 variables `size_t' and `ssize_t' and return values `regoff_t', as
3949 appropriate.
3950 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3951 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3952 <compile_stack_type>: `size' and `avail' are now `size_t'.
3953
3954 * regex.h <regoff_t>: Use ssize_t, not int.
3955 (re_search, re_search_2, re_match, re_match_2): Arguments that
3956 specify buffer/string position and length are now ssize_t and
3957 size_t. Return type is regoff_t.
3958
613052cd
BK
39592011-04-16 Ben Key <bkey76@gmail.com>
3960
3961 * nsfont.m: Fixed bugs in ns_get_family and
3962 ns_descriptor_to_entity that were caused by using free to
3963 deallocate memory blocks that were allocated by xmalloc (via
3964 xstrdup). This caused Emacs to crash when compiled with
3965 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3966 --enable-checking=xmallocoverrun). xfree is now used to
3967 deallocate these memory blocks.
3968
4170f62f 39692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3970
71b41406
PE
3971 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3972
9587a89d
PE
3973 emacs_write: Accept and return EMACS_INT for sizes.
3974 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3975 et seq.
3976 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3977 Accept and return EMACS_INT.
3978 (emacs_gnutls_write): Return the number of bytes written on
3979 partial writes.
3980 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3981 (emacs_read, emacs_write): Remove check for negative size, as the
3982 Emacs source code has been audited now.
9587a89d
PE
3983 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3984 (emacs_read, emacs_write): Use it.
273a5f82
PE
3985 * process.c (send_process): Adjust to the new signatures of
3986 emacs_write and emacs_gnutls_write. Do not attempt to store
3987 a byte offset into an 'int'; it might overflow.
9587a89d 3988 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3989
3e047f51
PE
3990 * sound.c: Don't assume sizes fit in 'int'.
3991 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3992 Return EMACS_INT, not int.
3e047f51 3993 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3994 Accept EMACS_INT, not int.
3995 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3996 record read return values.
3997
cc39a9db
BK
39982011-04-15 Ben Key <bkey76@gmail.com>
3999
c9d0ec6d
JB
4000 * keyboard.c (Qundefined): Don't declare static since it is used
4001 in nsfns.m.
4002 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4003 static since they are used in nsfont.m.
cc39a9db 4004
6c60eb9f
SM
40052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4006
4007 * process.c (Qprocessp): Don't declare static.
4008 * lisp.h (Qprocessp): Declare again.
4009
7990b61a
JB
40102011-04-15 Juanma Barranquero <lekktu@gmail.com>
4011
4012 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4013
5d4cb038
PE
40142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4015
8bd7b830 4016 Improve C-level modularity by making more things 'static'.
cd64ea1d 4017
e3b27b31
PE
4018 Don't publish debugger-only interfaces to other modules.
4019 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4020 (verify_bytepos, count_markers): Move decls to the only modules
4021 that need them.
4022 * region-cache.h (pp_cache): Likewise.
4023 * window.h (check_all_windows): Likewise.
4024 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4025
5d4cb038
PE
4026 * sysdep.c (croak): Now static, if
4027 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4028 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4029
4030 * alloc.c (refill_memory_reserve): Now static if
4031 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4032 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4033
e87b6180
PE
4034 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4035 Define only if USE_LUCID.
4036
ac64929e
PE
4037 * xrdb.c (x_customization_string, x_rm_string): Now static.
4038
6f37259d
PE
4039 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4040 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4041
1683e3ab
PE
4042 * xdisp.c (draw_row_with_mouse_face): Now static.
4043 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4044
de9c2632
PE
4045 * window.h (check_all_windows): Mark externally visible.
4046
2b96acb7
PE
4047 * window.c (window_deletion_count): Now static.
4048
4049 * undo.c: Make symbols static if they're not exported.
4050 (last_undo_buffer, last_boundary_position, pending_boundary):
4051 Now static.
4052
50436f33
PE
4053 * textprop.c (interval_insert_behind_hooks): Now static.
4054 (interval_insert_in_front_hooks): Likewise.
4055
64520e5c
PE
4056 * term.c: Make symbols static if they're not exported.
4057 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4058 (max_frame_lines, tty_set_terminal_modes):
4059 (tty_reset_terminal_modes, tty_turn_off_highlight):
4060 (get_tty_terminal): Now static.
4061 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4062 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4063 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4064 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4065 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4066
1fa53021
PE
4067 * sysdep.c: Make symbols static if they're not exported.
4068 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4069 Now static.
4070 (sigprocmask_set, full_mask): Remove; unused.
4071 (wait_debugging): Mark as visible.
4072 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4073 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4074
d4b43b22
PE
4075 * syntax.c (syntax_temp): Define only if !__GNUC__.
4076
b7c513d0
PE
4077 * sound.c (current_sound_device, current_sound): Now static.
4078
989b29ad
PE
4079 * search.c (searchbufs, searchbuf_head): Now static.
4080
13a55a78
PE
4081 * scroll.c (scroll_cost): Remove; unused.
4082 * dispextern.h (scroll_cost): Remove decl.
4083
de68a1fc
PE
4084 * region-cache.h (pp_cache): Mark as externally visible.
4085
40ccffa6
PE
4086 * process.c: Make symbols static if they're not exported.
4087 (process_tick, update_tick, create_process, chan_process):
4088 (Vprocess_alist, proc_buffered_char, datagram_access):
4089 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4090 (deactivate_process): Mark defn as static, as well as decl.
4091 * lisp.h (create_process): Remove decl.
4092 * process.h (chan_process, Vprocess_alist): Remove decls.
4093
ad64fc97
PE
4094 * print.c: Make symbols static if they're not exported.
4095 (print_depth, new_backquote_output, being_printed, print_buffer):
4096 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4097 (print_interval, print_number_index, initial_stderr_stream):
4098 Now static.
4099 * lisp.h (Fprinc): Remove decl.
4100 (debug_output_compilation_hack): Mark as externally visible.
4101
adddb265
PE
4102 * sysdep.c (croak): Move decl from here to syssignal.h.
4103 * syssignal.h (croak): Put it here, so the API can be checked when
4104 'croak' is called from dissociate_if_controlling_tty.
4105
1717ede2
PE
4106 * minibuf.c: Make symbols static if they're not exported.
4107 (minibuf_save_list, choose_minibuf_frame): Now static.
4108 * lisp.h (choose_minibuf_frame): Remove decl.
4109
fa5fb2bc
PE
4110 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4111
1e3890d1
PE
4112 * lread.c: Make symbols static if they're not exported.
4113 (read_objects, initial_obarray, oblookup_last_bucket_number):
4114 Now static.
4115 (make_symbol): Remove; unused.
4116 * lisp.h (initial_obarray, make_symbol): Remove decls.
4117
8a1414fa
PE
4118 * keyboard.c: Make symbols static if they're not exported.
4119 (single_kboard, recent_keys_index, total_keys, recent_keys):
4120 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4121 (this_single_command_key_start, echoing, last_auto_save):
4122 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4123 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4124 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4125 (Vlispy_mouse_stem, double_click_count):
4126 Now static.
4127 (force_auto_save_soon): Define only if SIGDANGER.
4128 (ignore_mouse_drag_p): Now static if
4129 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4130 (print_help): Remove; unused.
4131 (stop_character, last_timer_event): Mark as externally visible.
4132 * keyboard.h (ignore_mouse_drag_p): Declare only if
4133 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4134 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4135 * lisp.h (echoing): Remove decl.
4136 (force_auto_save_soon): Declare only if SIGDANGER.
4137 * xdisp.c (redisplay_window): Simplify code, to make it more
4138 obvious that ignore_mouse_drag_p is not accessed if !defined
4139 USE_GTK && !defined HAVE_NS.
4140
93ea6e8f
PE
4141 * intervals.c: Make symbols static if they're not exported.
4142 (merge_properties_sticky, merge_interval_right, delete_interval):
4143 Now static.
4144 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4145
77382fcc
PE
4146 * insdel.c: Make symbols static if they're not exported.
4147 However, leave prepare_to_modify_buffer alone. It's never
4148 called from outside this function, but that appears to be a bug.
4149 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4150 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4151 (adjust_after_replace_noundo): Remove; unused.
4152 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4153 (signal_before_change): Remove decls.
77382fcc 4154
9306c32e
PE
4155 * indent.c (val_compute_motion, val_vmotion): Now static.
4156
cd44d2eb
PE
4157 * image.c: Make symbols static if they're not exported.
4158 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4159 if USE_GTK.
4160 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4161 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4162
ad9a7a06
PE
4163 * fringe.c (standard_bitmaps): Now static.
4164 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4165
81626931
PE
4166 * frame.c: Make symbols static if they're not exported.
4167 (x_report_frame_params, make_terminal_frame): Now static.
4168 (get_frame_param): Now static, unless HAVE_NS.
4169 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4170 (x_get_resource_string): Remove; not used.
4171 * frame.h (make_terminal_frame, x_report_frame_params):
4172 (x_get_resource_string); Remove decls.
4173 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4174 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4175
239f9db9
PE
4176 * font.c, fontset.c: Make symbols static if they're not exported.
4177 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4178 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4179 * font.c (font_close_object): Now static.
4180 * font.h (font_close_object): Remove.
4181 * fontset.c (FONTSET_OBJLIST): Remove.
4182 (free_realized_fontset) #if-0 the body, which does nothing.
4183 (face_suitable_for_char_p): #if-0, as it's never called.
4184 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4185 * xfaces.c (face_at_string_position):
4186 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4187 since 0 is always ASCII.
4188
dfcf3579
PE
4189 * fns.c (weak_hash_tables): Now static.
4190
5045092b
PE
4191 * fileio.c: Make symbols static if they're not exported.
4192 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4193 (Vwrite_region_annotation_buffers): Now static.
4194
57a96f5c
PE
4195 * eval.c: Make symbols static if they're not exported.
4196 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4197 * lisp.h (backtrace_list): Remove decl.
4198
35f08c38
PE
4199 * emacs.c: Make symbols static if they're not exported.
4200 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4201 (fatal_error_code, fatal_error_signal_hook, standard_args):
4202 Now static.
4203 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4204 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4205 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4206 * lisp.h (fatal_error_signal_hook): Remove decl.
4207 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4208
f44bd759
PE
4209 * editfns.c: Move a (normally-unused) function to its only use.
4210 * editfns.c, lisp.h (get_operating_system_release): Remove.
4211 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4212 worth the hassle of breaking this out.
4213
b532497d
PE
4214 * xterm.c: Make symbols static if they're not exported.
4215 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4216 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4217 (x_destroy_window, x_delete_display):
4218 Now static.
4219 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4220 (x_mouse_leave): Remove; unused.
4221 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4222 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4223 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4224 Remove decls.
4225 (x_mouse_leave): Declare only if WINDOWSNT.
4226 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4227 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4228 USE_X_TOOLKIT.
4229
1675728f
PE
4230 * ftxfont.c: Make symbols static if they're not exported.
4231 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4232 HAVE_FREETYPE.
4233 * font.h (ftxfont_driver): Likewise.
4234
e4cebfca
PE
4235 * xfns.c: Make symbols static if they're not exported.
4236 (x_last_font_name, x_display_info_for_name):
4237 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4238 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4239 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4240 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4241 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4242 (last_show_tip_args): Now static.
4243 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4244 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4245 (x_screen_planes): Remove; unused.
4246 * dispextern.h (x_screen_planes): Remove decl.
4247
5bf46f05
PE
4248 * dispnew.c: Make symbols static if they're not exported.
4249 * dispextern.h (redraw_garbaged_frames, scrolling):
4250 (increment_row_positions): Remove.
4251 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4252 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4253 Now static.
4254 (redraw_garbaged_frames): Remove; unused.
4255
435f4c28
PE
4256 * xfaces.c: Make symbols static if they're not exported.
4257 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4258 Remove decls.
4259 * xterm.h (defined_color): Remove decls.
4260 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4261 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4262 (menu_face_changed_default, defined_color, free_realized_face):
4263 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4264 (ascii_face_of_lisp_face): Remove; unused.
4265
8524aef3
PE
4266 * xdisp.c: Make symbols static if they're not exported.
4267 * dispextern.h (scratch_glyph_row, window_box_edges):
4268 (glyph_to_pixel_coords, set_cursor_from_row):
4269 (get_next_display_element, set_iterator_to_next):
4270 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4271 (show_mouse_face): Remove decls
4272 * frame.h (message_buf_print): Likewise.
4273 * lisp.h (pop_message, set_message, check_point_in_composition):
4274 Likewise.
4275 * xterm.h (set_vertical_scroll_bar): Likewise.
4276 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4277 (message_buf_print, scratch_glyph_row, displayed_buffer):
4278 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4279 (get_next_display_element, show_mouse_face, window_box_edges):
4280 (frame_to_window_pixel_xy, check_point_in_composition):
4281 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4282 (glyph_to_pixel_coords): Remove; unused.
4283
16390cd2
PE
4284 * dired.c (file_name_completion): Now static.
4285
4286 * dbusbind.c (xd_in_read_queued_messages): Now static.
4287
a25f4dfa
PE
4288 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4289 * data.c (circular_list_error): Remove.
4290
14a9c8df
PE
4291 * commands.h (last_point_position, last_point_position_buffer):
4292 (last_point_position_window): Remove decls.
4293 * keyboard.c: Make these variables static.
4294
04f2d78b
CB
4295 * coding.h (coding, code_convert_region, encode_coding_gap):
4296 Remove decls.
74ab6df5
PE
4297 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4298 (iso_code_class, detect_coding, code_convert_region): Now static.
4299 (encode_coding_gap): Remove; unused.
4300
38dfbee1
PE
4301 * chartab.c (chartab_chars, chartab_bits): Now static.
4302
a2cb4e63
PE
4303 * charset.h (charset_iso_8859_1): Remove decl.
4304 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4305 Now static.
4306
127198fd
PE
4307 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4308 * ccl.c (Vccl_program_table): Now static.
4309 (check_ccl_update): Remove; unused.
4310
d85b608f
PE
4311 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4312 * category.h: ... from here.
4313 * category.c (check_category_table, set_category_set): Now static.
4314
31cd66f3
PE
4315 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4316 * lisp.h: Remove these decls.
4317
c358e587
PE
4318 * buffer.c (buffer_count): Remove unused var.
4319
e78aecca
PE
4320 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4321 so that it's not optimized away.
4322 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4323 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4324 exported only to the debugger.
4325
e192d7d3 4326 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4327 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4328
92470028
PE
4329 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4330 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4331 was inaccessible from Lisp.
4332 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4333 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4334
244ed907
PE
4335 alloc.c: Import and export fewer symbols, and remove unused items.
4336 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4337 is defined.
4338 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4339 it's not optimized away by whole-program optimization.
4340 (message_enable_multibyte, free_misc): Remove.
4341 (catchlist, handlerlist, mark_backtrace):
4342 Declare only if BYTE_MARK_STACK.
4343 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4344 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4345 (message_enable_multibyte): Remove decl.
4346 (free_misc, interval_free_list, float_block, float_block_index):
4347 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4348 (cons_free_list, last_marked_index):
4349 Now static.
4350 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4351 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4352 (mark_backtrace): Define only if BYTE_MARK_STACK.
4353 * xdisp.c (message_enable_multibyte): Now static.
4354
61c2b50e 4355 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4356 This makes it easier for human readers (and static analyzers)
4357 to see whether these variables are used from other modules.
4358 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4359 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4360 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4361 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4362 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4363 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4364 * xmenu.c, xselect.c:
4365 Declare Q* vars static if they are not used in other modules.
4366 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4367 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4368 Remove decls of unexported vars.
4369 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4370
95c82688
PE
4371 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4372
16a97296
PE
4373 Make Emacs functions such as Fatom 'static' by default.
4374 This makes it easier for human readers (and static analyzers)
4375 to see whether these functions can be called from other modules.
4376 DEFUN now defines a static function. To make the function external
4377 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4378 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4379 (Finit_image_library):
16a97296
PE
4380 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4381 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4382 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4383 Remove decls, since these functions are now static.
4384 (Funintern, Fget_internal_run_time): New decls, since these functions
4385 were already external.
95c82688 4386
16a97296
PE
4387 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4388 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4389 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4390 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4391 * keyboard.c, keymap.c, lread.c:
4392 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4393 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4394 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4395 Mark functions with DEFUE instead of DEFUN,
4396 if they are used in other modules.
4397 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4398 decls for now-static functions.
4399 * buffer.h (Fdelete_overlay): Remove decl.
4400 * callproc.c (Fgetenv_internal): Mark as internal.
4401 * composite.c (Fremove_list_of_text_properties): Remove decl.
4402 (Fcomposition_get_gstring): New forward static decl.
4403 * composite.h (Fcomposite_get_gstring): Remove decl.
4404 * dired.c (Ffile_attributes): New forward static decl.
4405 * doc.c (Fdocumntation_property): New forward static decl.
4406 * eval.c (Ffetch_bytecode): New forward static decl.
4407 (Funintern): Remove extern decl; now in .h file where it belongs.
4408 * fileio.c (Fmake_symbolic_link): New forward static decl.
4409 * image.c (Finit_image_library): New forward static decl.
4410 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4411 * intervals.h (Fprevious_property_change):
4412 (Fremove_list_of_text_properties): Remove decls.
4413 * keyboard.c (Fthis_command_keys): Remove decl.
4414 (Fcommand_execute): New forward static decl.
4415 * keymap.c (Flookup_key): New forward static decl.
4416 (Fcopy_keymap): Now static.
4417 * keymap.h (Flookup_key): Remove decl.
4418 * process.c (Fget_process): New forward static decl.
4419 (Fprocess_datagram_address): Mark as internal.
4420 * syntax.c (Fsyntax_table_p): New forward static decl.
4421 (skip_chars): Remove duplicate decl.
4422 * textprop.c (Fprevious_property_change): New forward static decl.
4423 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4424 Now internal.
4425 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4426 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4427
785bbd42
PE
4428 * editfns.c (Fformat): Remove unreachable code.
4429
8b913b57
AS
44302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4431
4432 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4433 change. (Bug#8496)
4434
a6744a35
EZ
44352011-04-13 Eli Zaretskii <eliz@gnu.org>
4436
4437 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4438 when at ZV. (Bug#8487)
4439
e7974947
AS
44402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4441
baad03f0
AS
4442 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4443 (Bug#8437)
4444 * keyboard.c (parse_tool_bar_item): Likewise.
4445 * sound.c (sound_cleanup, alsa_close): Likewise.
4446 * termcap.c (tgetent): Likewise.
4447 * xfns.c (x_default_font_parameter): Likewise.
4448 * xsettings.c (read_and_apply_settings): Likewise.
4449
e7974947
AS
4450 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4451 (overrun_check_free): Protoize.
4452
28272684
PE
44532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4454
4455 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4456 since callers should never pass a negative size.
4457 Change the signature to match that of plain 'read' and 'write'; see
4458 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4459 * lisp.h: Update prototypes of emacs_write and emacs_read.
4460
11997c76
EZ
44612011-04-11 Eli Zaretskii <eliz@gnu.org>
4462
4463 * xdisp.c (redisplay_window): Don't try to determine the character
4464 position of the scroll margin if the window start point w->startp
e896f03c 4465 is outside the buffer's accessible region. (Bug#8468)
11997c76 4466
8a2cbd72
EZ
44672011-04-10 Eli Zaretskii <eliz@gnu.org>
4468
4469 Fix write-region and its subroutines for buffers > 2GB.
4470 * fileio.c (a_write, e_write): Modify declaration of arguments and
4471 local variables to support buffers larger than 2GB.
4472 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4473
4474 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4475 argument, local variables, and return value.
4476
4477 * lisp.h: Update prototypes of emacs_write and emacs_read.
4478
4479 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4480
4073e537 44812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4482
1ebfdcb6
PE
4483 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4484
b2ded58d
PE
4485 Fix more problems found by GCC 4.6.0's static checks.
4486
7d66342c
PE
4487 * xdisp.c (vmessage): Use a better test for character truncation.
4488
bbf47d44
PE
4489 * charset.c (load_charset_map): <, not <=, for optimization,
4490 and to avoid potential problems with integer overflow.
9248994d 4491 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4492 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4493 * editfns.c (Fformat): Likewise.
1e69125e 4494 * syntax.c (skip_chars): Likewise.
3befa583 4495
e3019616
PE
4496 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4497 This also lets GCC 4.6.0 generate slightly better loop code.
4498
becfa255
PE
4499 * callint.c (Fcall_interactively): <, not <=, for optimization.
4500 (Fcall_interactively): Count the number of arguments produced,
4501 not the number of arguments given. This is simpler and lets GCC
4502 4.6.0 generate slightly better code.
4503
dae0cd48
PE
4504 * ftfont.c: Distingish more carefully between FcChar8 and char.
4505 The previous code passed unsigned char * to a functions like
4506 strlen and xstrcasecmp that expect char *, which does not
4507 conform to the C standard.
4508 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4509 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4510 char * when the C standard requires it.
4511
76032d70
PE
4512 * keyboard.c (read_char): Remove unused var.
4513
eb3f1cc8
PE
4514 * eval.c: Port to Windows vsnprintf (Bug#8435).
4515 Include <limits.h>.
4516 (SIZE_MAX): Define if the headers do not.
4517 (verror): Do not give up if vsnprintf returns a negative count.
4518 Instead, grow the buffer. This ports to Windows vsnprintf, which
4519 does not conform to C99. Problem reported by Eli Zaretskii.
4520 Also, simplify the allocation scheme, by avoiding the need for
4521 calling realloc, and removing the ALLOCATED variable.
4522
70476b54
PE
4523 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4524
12020a9e
PE
4525 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4526 But keep the doprint source code for now, as we might revamp it
4527 and use it again (Bug#8435).
ea6c7ae6
PE
4528 * lisp.h (doprnt): Remove.
4529 * Makefile.in (base_obj): Remove doprnt.o.
4530 * deps.mk (doprnt.o): Remove.
4531
5fdb398c
PE
4532 error: Print 32- and 64-bit integers portably (Bug#8435).
4533 Without this change, on typical 64-bit hosts error ("...%d...", N)
4534 was used to print both 32- and 64-bit integers N, which relied on
4535 undefined behavior.
4536 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4537 New macro.
4538 * lisp.h (error, verror): Mark as printf-like functions.
4539 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4540 Report overflow in size calculations when allocating printf buffer.
4541 Do not truncate output string at its first null byte.
4542 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4543 Truncate the output at a character boundary, since vsnprintf does not
4544 do that.
4545 * charset.c (check_iso_charset_parameter): Convert internal
4546 character to string before calling 'error', since %c now has the
4547 printf meaning.
4548 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4549 overflow when computing char to be passed to 'error'. Do not
4550 pass Lisp_Object to 'error'; pass the integer instead.
4551 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4552 formatted with plain %d.
4553
b189fa66
PE
4554 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4555
bff87ef0
PE
4556 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4557
7e2cac20
PE
4558 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4559
ce4d90b5
PE
4560 * xterm.c (x_catch_errors): Remove duplicate declaration.
4561
266c9547
PE
4562 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4563
79c49ad2
PE
4564 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4565
368f4090
JM
45662011-04-10 Jim Meyering <meyering@redhat.com>
4567
4568 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4569 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4570 return ssize_t not "int", and use size_t as the buffer length.
4571 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4572 * gnutls.h: Update declarations.
4573 * process.c (read_process_output): Use ssize_t, to match.
4574 (send_process): Likewise.
4575
a32d4040
CY
45762011-04-09 Chong Yidong <cyd@stupidchicken.com>
4577
4578 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4579
8546720e 45802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4581
04f2d78b
CB
4582 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4583 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4584
8546720e
GM
4585 * xterm.c (handle_one_xevent):
4586 * xmenu.c (create_and_show_popup_menu):
4587 * xselect.c (x_decline_selection_request)
4588 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4589
0a2f5c1a 45902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4591
4592 Fix some uses of `int' instead of EMACS_INT.
4593 * search.c (string_match_1, fast_string_match)
4594 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4595 (scan_buffer, find_next_newline_no_quit)
4596 (find_before_next_newline, search_command, Freplace_match)
4597 (Fmatch_data): Make some `int' variables be EMACS_INT.
4598
4599 * xdisp.c (display_count_lines): 3rd argument and return value now
4600 EMACS_INT. All callers changed.
4601 (pint2hrstr): Last argument is now EMACS_INT.
4602
4603 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4604 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4605 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4606 (decode_coding_utf_16, decode_coding_emacs_mule)
4607 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4608 (decode_coding_ccl, decode_coding_charset)
4609 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4610 (decode_coding_iso_2022, decode_coding_emacs_mule)
4611 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4612 <char_offset, last_offset>: Declare EMACS_INT.
4613 (encode_coding_utf_8, encode_coding_utf_16)
4614 (encode_coding_emacs_mule, encode_invocation_designation)
4615 (encode_designation_at_bol, encode_coding_iso_2022)
4616 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4617 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4618 Declare EMACS_INT.
4619 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4620 (encode_invocation_designation): Last argument P_NCHARS is now
4621 EMACS_INT.
4622 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4623 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4624
4625 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4626 All users changed.
4627
4628 * ccl.c (Fccl_execute_on_string): Declare some variables
4629 EMACS_INT.
4630
8546720e 46312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4632
4633 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4634
4e19a977
CS
46352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4636
4637 * process.c (Fformat_network_address): Doc fix.
4638
87302331
R
46392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4640
4641 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4642
cbb59342
CY
46432011-04-08 Chong Yidong <cyd@stupidchicken.com>
4644
4645 * keyboard.c (read_char): Call Lisp function help-form-show,
4646 instead of using internal_with_output_to_temp_buffer.
4647 (Qhelp_form_show): New var.
e0d38eeb 4648 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4649
4650 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4651
4652 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4653
e67a13ab
CY
46542011-04-06 Chong Yidong <cyd@stupidchicken.com>
4655
04f2d78b
CB
4656 * process.c (Flist_processes): Remove to Lisp.
4657 (list_processes_1): Delete.
e67a13ab 4658
973f782d
EZ
46592011-04-06 Eli Zaretskii <eliz@gnu.org>
4660
7c106b1e
EZ
4661 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4662
973f782d
EZ
4663 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4664
41cf7d1a 46652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4666
ca23cc88
PE
4667 Fix more problems found by GCC 4.6.0's static checks.
4668
f390e2d5
PE
4669 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4670
42eea0d0
PE
4671 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4672
b69769da 4673 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4674
f9541e84
PE
4675 * xdisp.c (vmessage): Mark as a printf-like function.
4676
13841b55
PE
4677 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4678
c136c10f
PE
4679 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4680
5e2d4a30
PE
4681 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4682 printf-like functions.
4683 (tiff_load): Add casts to remove these marks before passing them
4684 to system-supplied API.
4685
583f48b9
PE
4686 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4687
b25d760e
PE
4688 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4689 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4690 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4691 directly, rather than having caller test rule sign. This avoids
4692 some unnecessary tests.
4693 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4694 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4695 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4696
bc7b6697 4697 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4698 (xfont_open): Avoid unnecessary tests.
bc7b6697 4699
27ccc379
PE
4700 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4701
dcd5c89a
PE
4702 * composite.h, composite.c (composition_gstring_put_cache):
4703 Use EMACS_INT, not int, for length.
4704
b13a45c6
PE
4705 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4706 breaking out part of COMPOSITION_DECODE_RULE.
4707 (COMPOSITION_DECODE_RULE): Use it.
4708 * composite.c (get_composition_id): Remove unused local vars,
4709 by using the new macro.
4710
1e792e4d
PE
4711 * textprop.c (set_text_properties_1): Change while to do-while,
4712 since the condition is always true at first.
4713
dc6c6455 4714 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4715 (interval_deletion_adjustment): Return unsigned value.
4716 All uses changed.
dc6c6455 4717
aba7731a
PE
4718 * process.c (list_processes_1, create_pty, read_process_output):
4719 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4720 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4721 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4722 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4723 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4724
fdfc4bf3
PE
4725 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4726
fca8fe46 4727 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4728 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4729
06a0259a 4730 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4731 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4732 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4733
e7b9e80f
PE
4734 * print.c (print_error_message): Avoid int overflow.
4735
56201685
PE
4736 * font.c (font_list_entities): Redo for clarity,
4737 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4738
78834453 4739 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4740 (font_score): Avoid potential overflow in diff calculation.
78834453 4741
0bc0b309 4742 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4743 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4744
e610eaca
PE
4745 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4746
b895abce
PE
4747 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4748 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4749 can always succeed if overflow has undefined behavior.
4750
1f1d9321 4751 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4752 (wordify): Omit three unnecessary tests.
1f1d9321 4753
c59478bc
PE
4754 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4755 All callers changed. This avoids the need for an unused var.
4756
79b73827
PE
4757 * casefiddle.c (casify_region): Remove var that is set but not used.
4758
a4db5dfe
PE
4759 * dired.c (file_name_completion): Remove var that is set but not used.
4760
43aae36e
PE
4761 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4762
2a47c44d 4763 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4764 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4765
a37c69bf
PE
4766 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4767 Check for integer overflow on size calculations.
4768
328ab8e7
PE
4769 * buffer.c (Fprevious_overlay_change): Remove var that is set
4770 but not used.
4771
e5a2a5cb
PE
4772 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4773 Remove vars that are set but not used.
8d84a6eb 4774 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4775 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4776
a60e5f68
PE
4777 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4778
f661cb61 4779 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4780 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4781
f0397f5a
PE
4782 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4783 that are set but not used.
4784
8664db06 4785 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4786 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4787
6abdaa4a
PE
4788 * xselect.c (x_get_local_selection, x_handle_property_notify):
4789 Remove vars that are set but not used.
4790
0ce7538d 4791 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4792 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4793
9ae848fc
PE
4794 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4795 Remove var that is set but not used.
0b918413
PE
4796 (scroll_bar_windows_size): Now size_t, not int.
4797 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4798 Check for overflow.
9ae848fc 4799
a5a62657
PE
4800 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4801 (map_tty_color) [!defined MSDOS]: Likewise.
4802
5c5cdd39
PE
4803 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4804
66ebf983
PE
4805 * coding.c: Remove vars that are set but not used.
4806 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4807 All callers changed.
4808 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4809 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4810 (decode_coding_charset): Remove vars that are set but not used.
4811
1be4d761
PE
4812 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4813 that is set but not used.
4814
47553fa8
PE
4815 * print.c (print_object): Remove var that is set but not used.
4816
1f7196bf 4817 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4818 The gnulib version avoids calling malloc in the usual case,
4819 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4820 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4821 * filelock.c (current_lock_owner): Likewise.
4822 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4823 * sysdep.c: Include allocator.h, careadlinkat.h.
4824 (emacs_no_realloc_allocator): New static constant.
4825 (emacs_readlink): New function.
fdb61804
PE
4826 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4827 ../lib/careadlinkat.h.
d1fdcab7 4828
f84c17c7
SM
48292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4830
4831 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4832 first non-nil return value).
4833
ef3862ad
JD
48342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4835
4836 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4837 if not defined (Bug#8403).
4838
376a7006
JB
48392011-04-02 Juanma Barranquero <lekktu@gmail.com>
4840
4841 * xdisp.c (display_count_lines): Remove parameter `start',
4842 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4843 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4844 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4845 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4846 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4847 and thereabouts. All callers changed.
4848 (get_per_char_metric): Remove parameter `f', unused since
4849 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4850
6ca3801d
JM
48512011-04-02 Jim Meyering <meyering@redhat.com>
4852
4853 do not dereference NULL upon failed strdup
4854 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4855 (ns_get_family): Likewise.
4856
d8e2b5ba
JB
48572011-04-02 Juanma Barranquero <lekktu@gmail.com>
4858
4859 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4860
8c74fcbd
JD
48612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4862
4863 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4864 later (Bug#8403).
4865
7200d79c
SM
48662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4867
03408648 4868 Add lexical binding.
7200d79c 4869
03408648
SM
4870 * window.c (Ftemp_output_buffer_show): New fun.
4871 (Fsave_window_excursion):
4872 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4873
4874 * lread.c (lisp_file_lexically_bound_p): New function.
4875 (Fload): Bind Qlexical_binding.
4876 (readevalloop): Remove `evalfun' arg.
4877 Bind Qinternal_interpreter_environment.
4878 (Feval_buffer): Bind Qlexical_binding.
4879 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4880 Mark as dynamic.
4881 (syms_of_lread): Declare `lexical-binding'.
4882
4883 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4884
4885 * keyboard.c (eval_dyn): New fun.
4886 (menu_item_eval_property): Use it.
ca105506
SM
4887
4888 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4889
03408648
SM
4890 * fns.c (concat, mapcar1): Accept byte-code-functions.
4891
4892 * eval.c (Fsetq): Handle lexical vars.
4893 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4894 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4895 (FletX, Flet): Obey lexical binding.
4896 (Fcommandp): Handle closures.
4897 (Feval): New `lexical' arg.
4898 (eval_sub): New function extracted from Feval. Use it almost
4899 everywhere where Feval was used. Look up vars in lexical env.
4900 Handle closures.
4901 (Ffunctionp): Move from subr.el.
4902 (Ffuncall): Handle closures.
4903 (apply_lambda): Remove `eval_flags'.
4904 (funcall_lambda): Handle closures and new byte-code-functions.
4905 (Fspecial_variable_p): New function.
4906 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4907 but without exporting it to Lisp.
23aba0ea 4908
23aba0ea 4909 * doc.c (Fdocumentation, store_function_docstring):
03408648 4910 * data.c (Finteractive_form): Handle closures.
23aba0ea 4911
03408648
SM
4912 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4913 interactive spec.
ba83908c 4914
04f2d78b
CB
4915 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4916 New byte-codes.
03408648
SM
4917 (exec_byte_code): New function extracted from Fbyte_code to handle new
4918 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4919
03408648 4920 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4921
03408648 4922 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4923
e2abce01
JB
49242011-03-31 Juanma Barranquero <lekktu@gmail.com>
4925
4926 * xdisp.c (redisplay_internal): Fix prototype.
4927
63696a73 49282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4929
63696a73 4930 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4931 (try_scrolling): Use it when setting scroll_limit.
4932 Limit scrolling to 100 screen lines.
63696a73
EZ
4933 (redisplay_window): Even when falling back on "recentering",
4934 position point in the window according to scroll-conservatively,
4935 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4936
4937 (try_scrolling): When point is above the window, allow searching
4938 as far as scroll_max, or one screenful, to compute vertical
4939 distance from PT to the scroll margin position. This prevents
4940 try_scrolling from unnecessarily failing when
4941 scroll-conservatively is set to a value slightly larger than the
4942 window height. Clean up the case of PT below the margin at bottom
4943 of window: scroll_max can no longer be INT_MAX. When aggressive
4944 scrolling is in use, don't let point enter the opposite scroll
4945 margin as result of the scroll.
4946 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4947 threshold of 100 lines for never-recentering scrolling.
4948
e4cc2dfc
JB
49492011-03-31 Juanma Barranquero <lekktu@gmail.com>
4950
4951 * dispextern.h (move_it_by_lines):
4952 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4953 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4954 (message_log_check_duplicate): Remove parameters `prev_bol' and
4955 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4956 (redisplay_internal): Remove parameter `preserve_echo_area',
4957 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4958
4959 * indent.c (Fvertical_motion):
4960 * window.c (window_scroll_pixel_based, Frecenter):
4961 Don't pass `need_y_p' to `move_it_by_lines'.
4962
1c470562
SM
49632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4964
44f230aa
SM
4965 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4966 steal a few bits to be more compact.
4967 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4968 Remove unneeded casts.
4969
1c470562
SM
4970 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4971
888adce9
ZK
49722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4973
4974 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4975 binding" message (bug#7967).
4976
f838ed7b
PE
49772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4978
77861b95
PE
4979 Fix more problems found by GCC 4.6.0's static checks.
4980
de6dbc14
PE
4981 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4982 Remove unused local var.
4983
f838ed7b
PE
4984 * editfns.c (Fmessage_box): Remove unused local var.
4985
792c7b2b
PE
4986 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4987 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4988 Omit unused local vars.
c499e557 4989 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4990 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4991 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4992 Omit unused local var.
4993
ba0165e1
PE
4994 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4995 Don't assume string length fits in int.
32ad8845 4996 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4997 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4998
3c59b4c9
PE
4999 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5000 instead of alloca (Bug#8344).
5001
a3eed478 5002 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5003 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5004
eb4d412d
PE
5005 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5006
1658b401
PE
5007 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5008 concerns.
5009
5010 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5011
5012 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5013
9a2c6e05
PE
5014 * keyboard.c (syms_of_keyboard): Use the same style as later
5015 in this function when indexing through an array. This also
5016 works around GCC bug 48267.
5017
03d0a109
PE
5018 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5019
44f730c8
PE
5020 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5021
fe75f926
PE
5022 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5023 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5024
ffa8c828
PE
5025 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5026 This avoids undefined behavior on integer overflow, and is a bit
5027 more convenient anyway since it is compared to a size_t variable.
5028
c5101a77
PE
5029 Variadic C functions now count arguments with size_t, not int.
5030 This avoids an unnecessary limitation on 64-bit machines, which
5031 caused (substring ...) to crash on large vectors (Bug#8344).
5032 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5033 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5034 All variadic functions and their callers changed accordingly.
c5101a77
PE
5035 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5036 * data.c (arith_driver, float_arith_driver): Likewise.
5037 * editfns.c (general_insert_function): Likewise.
5038 * eval.c (struct backtrace.nargs, interactive_p)
5039 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5040 (funcall_lambda, mark_backtrace): Likewise.
5041 * fns.c (concat): Likewise.
5042 * frame.c (x_set_frame_parameters): Likewise.
5043 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5044 0 if not found, not -1. All callers changed.
5045
dd3f25f7
PE
5046 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5047 (stack_copy_size): Now size_t, not int.
5048 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5049
461c2ab9
JB
50502011-03-28 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5053 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5054 All callers changed.
5055
5056 * lisp.h (multibyte_char_to_unibyte):
5057 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5058 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5059 * character.h (CHAR_TO_BYTE8):
5060 * cmds.c (internal_self_insert):
5061 * editfns.c (general_insert_function):
5062 * keymap.c (push_key_description):
5063 * search.c (Freplace_match):
5064 * xdisp.c (message_dolog, set_message_1): All callers changed.
5065
f6d62986
SM
50662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5067
5068 * keyboard.c (safe_run_hook_funcall): New function.
5069 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5070 don't set the hook to nil, but remove the offending function instead.
5071 (Qcommand_hook_internal): Remove, unused.
5072 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5073 Vcommand_hook_internal.
5074
5075 * eval.c (enum run_hooks_condition): Remove.
5076 (funcall_nil, funcall_not): New functions.
5077 (run_hook_with_args): Call each function through a `funcall' argument.
5078 Remove `cond' argument, now redundant.
5079 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5080 (Frun_hook_with_args_until_failure): Adjust accordingly.
5081 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5082
1db5b1ad
JB
50832011-03-28 Juanma Barranquero <lekktu@gmail.com>
5084
5085 * dispextern.h (string_buffer_position): Remove declaration.
5086
5087 * print.c (strout): Remove parameter `multibyte', unused since
5088 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5089
5090 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5091 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5092 All callers changed.
5093
5094 * w32.c (_wsa_errlist): Use braces for struct initializers.
5095
5096 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5097 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5098 All callers changed.
5099 (string_buffer_position): Likewise. Also, make static (it's never
5100 used outside xdisp.c).
5101 (cursor_row_p): Remove parameter `w', unused since
5102 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5103 (decode_mode_spec): Remove parameter `precision', introduced during
5104 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5105 All callers changed.
5106
5ffb62aa
JD
51072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5108
5109 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5110
461c2ab9 51112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5112
5113 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5114 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5115 (ns_update_auto_hide_menu_bar): New functions.
5116 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5117 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5118 ns_constrain_all_frames.
5119 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5120 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5121
5c380ffb
JD
51222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5123
5124 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5125
9af30bdf
GM
51262011-03-27 Glenn Morris <rgm@gnu.org>
5127
5128 * syssignal.h: Replace RETSIGTYPE with void.
5129 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5130 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5131 Replace SIGTYPE with void everywhere.
5132 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5133 * s/template.h (SIGTYPE): Remove commented out definition.
5134
e2abce01
JB
51352011-03-26 Eli Zaretskii <eliz@gnu.org>
5136
5137 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5138 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5139
f868cd8a
JB
51402011-03-26 Juanma Barranquero <lekktu@gmail.com>
5141
59eb0929
JB
5142 * w32.c (read_unc_volume): Use parameter `henum', instead of
5143 global variable `wget_enum_handle'.
5144
5145 * keymap.c (describe_vector): Remove parameters `indices' and
5146 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5147 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5148
f868cd8a
JB
5149 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5150
5151 * keyboard.c (timer_check): Remove parameter `do_it_now',
5152 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5153 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5154 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5155
5156 * keyboard.c (read_char):
5157 * w32menu.c (w32_menu_display_help):
5158 * xmenu.c (show_help_event, menu_help_callback):
5159 Adjust calls to `show_help_echo'.
5160
5161 * gtkutil.c (xg_maybe_add_timer):
5162 * keyboard.c (readable_events):
5163 * process.c (wait_reading_process_output):
5164 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5165
5166 * insdel.c (adjust_markers_gap_motion):
5167 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5168 (gap_left, gap_right): Don't call it.
5169
2ecf6fdb
CY
51702011-03-25 Chong Yidong <cyd@stupidchicken.com>
5171
5172 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5173 incurred during fontification.
5174
6b1f9ba4
JB
51752011-03-25 Juanma Barranquero <lekktu@gmail.com>
5176
5177 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5178 (DEFVAR_PER_BUFFER): Don't pass it.
5179
5180 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5181 (scrolling_window): Don't pass it.
5182
0f4a96b5
JB
51832011-03-25 Juanma Barranquero <lekktu@gmail.com>
5184
5185 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5186
5187 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5188 and `suffix'.
5189 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5190 of variables specific to SELinux and computation of `encoded_absname'.
5191
5192 * image.c (XPutPixel): Remove unused variable `height'.
5193
5194 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5195
5196 * unexw32.c (get_section_info): Remove unused variable `section'.
5197
5198 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5199 (system_process_attributes): Remove unused variable `sess'.
5200 (sys_read): Remove unused variable `err'.
5201
5202 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5203 (w32_wnd_proc): Remove unused variable `isdead'.
5204 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5205 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5206 (x_create_tip_frame): Remove unused variable `tem'.
5207
5208 * w32inevt.c (w32_console_read_socket):
5209 Remove unused variable `no_events'.
5210
5211 * w32term.c (x_draw_composite_glyph_string_foreground):
5212 Remove unused variable `width'.
5213
1149507c
JB
52142011-03-24 Juanma Barranquero <lekktu@gmail.com>
5215
5216 * w32term.c (x_set_glyph_string_clipping):
5217 Don't pass uninitialized region to CombineRgn.
5218
9c88f339
JB
52192011-03-23 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5222 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5223 (Fx_close_connection): Remove unused variable `i'.
5224
5225 * w32font.c (w32font_draw): Return number of glyphs.
5226 (w32font_open_internal): Remove unused variable `i'.
5227 (w32font_driver): Add missing initializer.
5228
5229 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5230 (fill_in_menu): Remove unused variable `items_added'.
5231
5232 * w32term.c (last_mouse_press_frame): Remove static global variable.
5233 (w32_clip_to_row): Remove unused variable `f'.
5234 (x_delete_terminal): Remove unused variable `i'.
5235
5236 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5237 (NOTHING): Remove unused static global variable.
5238 (uniscribe_check_otf): Remove unused variable `table'.
5239 (uniscribe_font_driver): Add missing initializers.
5240
dee091a3
JD
52412011-03-23 Julien Danjou <julien@danjou.info>
5242
5243 * term.c (Fsuspend_tty, Fresume_tty):
5244 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5245 * window.c (temp_output_buffer_show):
5246 * insdel.c (signal_before_change):
5247 * frame.c (Fhandle_switch_frame):
5248 * fileio.c (Fdo_auto_save):
5249 * emacs.c (Fkill_emacs):
5250 * editfns.c (save_excursion_restore):
5251 * cmds.c (internal_self_insert):
5252 * callint.c (Fcall_interactively):
5253 * buffer.c (Fkill_all_local_variables):
5254 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5255 Use Frun_hooks.
0f4a96b5 5256 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5257 unconditionnaly since it does the check itself.
5258
2c520ab5 52592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5260
c9c49752
PE
5261 Fix more problems found by GCC 4.5.2's static checks.
5262
8abc3f12
PE
5263 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5264 the first time through the loop, since we know p0 < p1 then.
5265 This also avoids a gcc -Wstrict-overflow warning.
5266
a2d26660
PE
5267 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5268 leading to a memory leak, possible in functions like
5269 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5270 of objects (Bug#8318).
a2d26660 5271
916c72e9
PE
5272 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5273 that could (at least in theory) be that large.
5274
19ab8a18
PE
5275 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5276 This is less likely to overflow, and avoids undefined behavior if
5277 overflow does occur. All callers changed. Use strtoul to scan
5278 for the unsigned long integer.
b7cbbd6f
PE
5279 (pint2hrstr): Simplify and tune code slightly.
5280 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5281
f0641eff
PE
5282 * scroll.c (do_scrolling): Work around GCC bug 48228.
5283 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5284
7f650bb9
PE
5285 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5286 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5287 (validate_x_resource_name): Simplify count usage.
5288 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5289
37dd57d1
PE
5290 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5291 fail (Bug#8306).
81e56e61 5292
699979fc 5293 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5294
401bf9b4
PE
5295 * process.c (Fmake_network_process): Use socklen_t, not int,
5296 where POSIX says socklen_t is required in portable programs.
5297 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5298 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5299 (Fmake_network_process, server_accept_connection):
5300 (wait_reading_process_output, read_process_output):
5301 Likewise.
5302
b93aacde
PE
5303 * process.c: Rename or move locals to avoid shadowing.
5304 (list_processes_1, Fmake_network_process):
5305 (read_process_output_error_handler, exec_sentinel_error_handler):
5306 Rename or move locals.
4dc343ee 5307 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5308 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5309 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5310 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5311 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5312
af8a867c 5313 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5314 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5315 Include tparam.h instead, since it declares them.
af8a867c
PE
5316 * cm.h (PC): Remove extern decl; tparam.h now does this.
5317 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5318 * terminfo.c: Include tparam.h, to check interfaces.
5319 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5320 (tparam): Adjust signature to match interface in tparam.h;
5321 this removes some undefined behavior. Check that outstring and len
5322 are zero, which they always are with Emacs.
5323 * tparam.h (PC, BC, UP): New extern decls.
5324
0248044d 5325 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5326 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5327
8ff096c1 5328 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5329 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5330 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5331 (ftfont_list): Remove unused local.
49eaafba
PE
5332 (get_adstyle_property, ftfont_pattern_entity):
5333 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5334 Rename locals to avoid shadowing.
8ff096c1 5335
e2be39f6
PE
5336 * xfont.c (xfont_list_family): Mark var as initialized.
5337
c9735e30
PE
5338 * xml.c (make_dom): Now static.
5339
8f5201ae
PE
5340 * composite.c (composition_compute_stop_pos): Rename local to
5341 avoid shadowing.
b246f932
PE
5342 (composition_reseat_it): Remove unused locals.
5343 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5344 (composition_update_it): Mark var as initialized.
11b61122
PE
5345 (find_automatic_composition): Mark vars as initialized,
5346 with a FIXME (Bug#8290).
8f5201ae 5347
760fbc2c
PE
5348 character.h: Rename locals to avoid shadowing.
5349 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5350 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5351 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5352 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5353 to avoid shadowing.
5354
ff08eb85
PE
5355 * textprop.c (property_change_between_p): Remove; unused.
5356
fc7bf025
PE
5357 * intervals.c (interval_start_pos): Now static.
5358
235d7abc
PE
5359 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5360
44f230aa
SM
5361 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5362 Rename locals to avoid shadowing.
3e7d6594 5363
50060332
PE
5364 * sound.c (wav_play, au_play, Fplay_sound_internal):
5365 Fix pointer signedness.
d01f234b 5366 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5367 (wav_play): Initialize a variable to 0, to prevent undefined
5368 behavior (Bug#8278).
50060332 5369
c4fc4e30
PE
5370 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5371
918436ed
PE
5372 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5373
c939f91b
PE
5374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5375 clobbering (Bug#8298).
b9c7f648
PE
5376 * sysdep.c (sys_subshell): Likewise.
5377 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5378
6bd8c144
PE
5379 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5380 This should get cleaned up, so that child_setup has the
5381 same signature on all platforms.
5382
7710357c 5383 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5384 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5385
c59da222
CY
53862011-03-22 Chong Yidong <cyd@stupidchicken.com>
5387
5388 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5389 not to be necessary, and produces flickering.
5390
66b87493
GM
53912011-03-20 Glenn Morris <rgm@gnu.org>
5392
5393 * config.in: Remove file.
5394
45b6f6d5
JB
53952011-03-20 Juanma Barranquero <lekktu@gmail.com>
5396
5397 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5398 are now in src/globals.h.
5399 (syms_of_minibuf): Remove spurious & from previous change.
5400
3ec03f7e
LL
54012011-03-20 Leo <sdl.web@gmail.com>
5402
5403 * minibuf.c (completing-read-function): New variable.
5404 (completing-read-default): Rename from completing-read.
5405 (completing-read): Call completing-read-function.
5406
b14e3e21
CY
54072011-03-19 Juanma Barranquero <lekktu@gmail.com>
5408
5409 * xfaces.c (Fx_load_color_file):
5410 Read color file from absolute filename (bug#8250).
5411
f2b726e6
JB
54122011-03-19 Juanma Barranquero <lekktu@gmail.com>
5413
5414 * makefile.w32-in: Update dependencies.
5415
09f6ff02
EZ
54162011-03-17 Eli Zaretskii <eliz@gnu.org>
5417
5418 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5419
29a6015a
PE
54202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5421
a3a6c54e
PE
5422 Fix more problems found by GCC 4.5.2's static checks.
5423
b766f867
PE
5424 * process.c (make_serial_process_unwind, send_process_trap):
5425 (sigchld_handler): Now static.
5426
be02381c
PE
5427 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5428 That way, the code declares only the vars that it needs.
5429 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5430 * s/cygwin.h (PTY_ITERATION): Likewise.
5431 * s/darwin.h (PTY_ITERATION): Likewise.
5432 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5433
57048744
PE
5434 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5435 * process.c (allocate_pty): Don't declare stb unless it's needed.
5436
7914961c 5437 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5438 (CONSTANTLIM): Remove; unused.
5439 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5440 Define only if needed.
7914961c 5441
b3967b18
PE
5442 * unexelf.c (unexec): Name an expression,
5443 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5444 Use a different way to cause a compilation error if anyone uses
5445 n rather than nn, a way that does not involve shadowing.
73366a00 5446 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5447
29a6015a
PE
5448 * deps.mk (unexalpha.o): Remove; unused.
5449
43cfc33e 5450 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5451 * unexec.h: New file.
ce701a33
PE
5452 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5453 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5454 Depend on unexec.h.
5455 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5456 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5457 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5458 Change as necessary to match prototype in unexec.h.
ce701a33 5459
01f44d5a
PE
5460 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5461 shadowing.
4f63c6bb 5462 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5463
a6670b0b
PE
5464 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5465 Rename locals to avoid shadowing.
5466
cef2010d 5467 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5468 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5469
d4d7173a
PE
5470 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5471
f08b802a
PE
5472 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5473 warning when compiling print.c.
5474
3ddb0639
PE
5475 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5476 instead of using an uninitialized var.
5ad03b97 5477 (font_sort_entities): Mark var as initialized.
3ddb0639 5478
170a2692
PE
5479 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5480
e663c700
PE
5481 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5482 pointers to constants.
89bc529a 5483 (font_parse_fcname): Remove unused vars.
7b81e2d0 5484 (font_delete_unmatched): Now static.
ea838e10 5485 (font_get_spec): Remove; unused.
13a547c6
PE
5486 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5487 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5488 Rename or move locals to avoid shadowing.
e663c700 5489
2a80c887 5490 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5491 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5492
1384fa33 5493 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5494 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5495
8b2c52e9
PE
5496 * alloc.c (mark_backtrace): Move decl from here ...
5497 * lisp.h: ... to here, so that it can be checked.
5498
475545b5 5499 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5500 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5501 (lisp_indirect_variable): Name an expression,
5502 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5503 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5504
b1349114 5505 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5506 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5507 Use const pointer when appropriate.
b1349114 5508
a2928364
PE
5509 * lisp.h (get_system_name, get_operating_system_release):
5510 Move decls here, to check interfaces.
5511 * process.c (get_operating_system_release): Move decl to lisp.h.
5512 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5513 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5514 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5515 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5516 (Fformat_time_string, Fencode_time, Finsert_char):
5517 (Ftranslate_region_internal, Fformat):
5518 Rename or remove local vars to avoid shadowing.
9710023e 5519 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5520
a415e694
PE
5521 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5522 avoid shadowing.
5523
8ef4622d
PE
5524 * lisp.h (eassert): Check that the argument compiles, even if
5525 ENABLE_CHECKING is not defined.
5526
946f9a5b
PE
5527 * data.c (Findirect_variable): Name an expression, to avoid
5528 gcc -Wbad-function-cast warning.
112396d6 5529 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5530 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5531 (Fmake_variable_buffer_local, Fmake_local_variable):
5532 Mark variables as initialized.
52746918 5533 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5534
e5aab7e7 5535 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5536 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5537 Rename locals to avoid shadowing.
dff45157
PE
5538 (mark_stack): Move local variables into the #ifdef region where
5539 they're used.
7bc26fdb
PE
5540 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5541 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5542 needed otherwise.
5543 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5544 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5545 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5546
e5aab7e7
PE
5547 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5548 avoids undefined behavior in theory.
5549
4da60324
PE
5550 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5551
88043301
PE
5552 Use functions, not macros, for up- and down-casing (Bug#8254).
5553 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5554 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5555 to use the following functions instead of these macros.
5556 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5557 EMACS_INT, since callers assume the returned value fits in int.
5558 (upcase1): Likewise, for UPCASE_TABLE.
5559 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5560 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5561 the race-condition problem in the old DOWNCASE.
88043301 5562
19ed5445
PE
5563 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5564 Rename locals to avoid shadowing.
5565 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5566 (regex_compile, re_search_2, re_match_2_internal):
5567 Remove unused local vars.
952db0d7
PE
5568 (FREE_VAR): Rewrite so as not to use empty "else",
5569 which gcc can warn about.
da053e48 5570 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5571 (RETALLOC_IF): Define only if needed.
5572 (WORDCHAR_P): Likewise. This one is never needed, but is used
5573 only in a comment talking about a compiler bug, so put inside
5574 the #if 0 of that comment.
5575 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5576 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5577 Remove; unused.
19ed5445 5578
1f3561e4 5579 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5580 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5581 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5582
ded6f8f7
PE
5583 * search.c (simple_search): Remove unused var.
5584
dbd37a95
PE
5585 * dired.c (compile_pattern): Move decl from here ...
5586 * lisp.h: ... to here, so that it can be checked.
5587 (struct re_registers): New forward decl.
5588
7e47afad
PE
5589 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5590
85f24f61
PE
5591 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5592 All uses changed.
5593 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5594 Rename locals to avoid shadowing.
5671df8f 5595 (Fvertical_motion): Mark locals as initialized.
85f24f61 5596
181aa2be 5597 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5598 (casify_region): Mark local as initialized.
181aa2be 5599
930d429c
PE
5600 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5601
7082eac6
PE
5602 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5603 New macros, so that the caller can use some names other than
5604 gcpro1, gcpro2, etc.
5605 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5606 of the new macros.
5607 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5608 argument, for consistency with GCPRO2_VAR, etc: it is now the
5609 prefix of the variable, not the variable itself. All uses
5610 changed.
38b2c076
PE
5611 * dired.c (directory_files_internal, file_name_completion):
5612 Rename locals to avoid shadowing.
5613
15206ed9
PE
5614 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5615 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5616 dired.c's scmp function, had undefined behavior.
5617 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5618 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5619 * buffer.h: ... to here, because these macros use current_buffer,
5620 and the new implementation with inline functions needs to have
5621 current_buffer in scope now, rather than later when the macros
5622 are used.
5623 (downcase, upcase1): New static inline functions.
5624 (DOWNCASE, UPCASE1): Reimplement using these functions.
5625 This avoids undefined behavior in expressions like
5626 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5627 from race conditions in accessing the global variables
5628 case_temp1 and case_temp2.
5629 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5630 * lisp.h (case_temp1, case_temp2): Remove their decls.
5631 * character.h (ASCII_CHAR_P): Move from here ...
5632 * lisp.h: ... to here, so that the inline functions mentioned
5633 above can use them.
5634
4a6bea26
PE
5635 * dired.c (directory_files_internal_unwind): Now static.
5636
f14b7e14
PE
5637 * fileio.c (file_name_as_directory, directory_file_name):
5638 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5639 Now static.
2893f146
PE
5640 (file_name_as_directory): Use const pointers when appropriate.
5641 (Fexpand_file_name): Likewise. In particular, newdir might
5642 point at constant storage, so make it a const pointer.
fd4ead52 5643 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5644 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5645 signedness issues.
f839df0c
PE
5646 (Fset_file_times, Finsert_file_contents, auto_save_error):
5647 Rename locals to avoid shadowing.
f14b7e14 5648
5716756e 5649 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5650 (Ftry_completion, Fall_completions): Rename or remove locals
5651 to avoid shadowing.
5716756e 5652
b4c3046a
PE
5653 * marker.c (bytepos_to_charpos): Remove; unused.
5654
b45db522
PE
5655 * lisp.h (verify_bytepos, count_markers): New decls,
5656 so that gcc does not warn that these functions aren't declared.
5657
85876d07
PE
5658 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5659 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5660 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5661 (copy_text): Remove unused local var.
85876d07 5662
03d78a21 5663 * filelock.c (within_one_second): Now static.
b3dd38ab 5664 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5665
5df8f01b
PE
5666 * buffer.c (fix_overlays_before): Mark locals as initialized.
5667 (fix_start_end_in_overlays): Likewise. This function should be
5668 simplified by using pointers-to-pointers, but that's a different
5669 matter.
b1d876f1 5670 (switch_to_buffer_1): Now static.
8f54f30a
PE
5671 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5672 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5673
a70072c9 5674 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5675 Fix pointer signedness issue.
edced198
PE
5676 (sys_subshell): Mark local as volatile if checking for lint,
5677 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5678 (MAXPATHLEN): Define only if needed.
a70072c9 5679
a0977c44
PE
5680 * process.c (serial_open, serial_configure): Move decls from here ...
5681 * systty.h: ... to here, so that they can be checked.
5682
a884fdcc
PE
5683 * fns.c (get_random, seed_random): Move extern decls from here ...
5684 * lisp.h: ... to here, so that they can be checked.
5685
604efe86 5686 * sysdep.c (reset_io): Now static.
b8950c94 5687 (wait_for_termination_signal): Remove; unused.
604efe86 5688
38fc62d9
PE
5689 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5690 (copy_keymap_item, append_key, push_text_char_description):
5691 Now static.
1004a21a 5692 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5693 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5694 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5695 (describe_map_tree):
5696 Rename locals to avoid shadowing.
38fc62d9 5697
2f2650da
PE
5698 * keyboard.c: Declare functions static if they are not used elsewhere.
5699 (echo_char, echo_dash, cmd_error, top_level_2):
5700 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5701 (read_char, kbd_buffer_get_event, make_lispy_position):
5702 (make_lispy_event, make_lispy_movement, apply_modifiers):
5703 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5704 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5705 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5706 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5707 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5708
a053e86c 5709 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5710 (mark_kboards): Move decl here ...
5711 * alloc.c (mark_kboards): ... from here.
a053e86c 5712
4752793e
PE
5713 * lisp.h (force_auto_save_soon): New decl.
5714
74f10ca7 5715 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5716 (DEFINE_DUMMY_FUNCTION): New macro.
5717 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5718 Use it.
c03cd23f
PE
5719 (main): Add casts to avoid warnings
5720 if GCC considers string literals to be constants.
74f10ca7 5721
022e70d4
PE
5722 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5723
59d6fe83
PE
5724 * dbusbind.c: Pointer signedness fixes.
5725 (xd_signature, xd_append_arg, xd_initialize):
5726 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5727 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5728 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5729 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5730
78320123
PE
5731 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5732 if GCC considers string literals to be constants.
49cebcca 5733 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5734
35ac2a97
SM
57352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5736
fb103ca9
SM
5737 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5738 (print_preprocess, print_object): New macro to fix last change.
5739
35ac2a97
SM
5740 * print.c (print_preprocess): Don't forget font objects.
5741
62973b41
JB
57422011-03-16 Juanma Barranquero <lekktu@gmail.com>
5743
5744 * emacs.c (USAGE3): Doc fixes.
5745
0e48bb22
AS
57462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5747
5748 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5749 structure.
5750
7684e57b
JB
57512011-03-14 Juanma Barranquero <lekktu@gmail.com>
5752
5753 * lisp.h (VWindow_system, Qfile_name_history):
5754 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5755 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5756 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5757
5758 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5759 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5760
5761 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5762 * w32console.c (detect_input_pending, read_input_pending)
5763 (encode_terminal_code):
5764 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5765 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5766 (w32_system_caret_y, Qfile_name_history):
5767 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5768 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5769 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5770 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5771 * w32proc.c (Qlocal, report_file_error):
5772 * w32term.c (Vwindow_system, updating_frame):
5773 * w32uniscribe.c (initialized, uniscribe_font_driver):
5774 Remove unneeded extern declarations.
5775
2aa46d6c
CY
57762011-03-14 Chong Yidong <cyd@stupidchicken.com>
5777
c96bbc66 5778 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5779
cffc6f3b
CY
57802011-03-13 Chong Yidong <cyd@stupidchicken.com>
5781
5782 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5783 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5784 These macros can no longer be used for assignment.
5785
44f230aa
SM
5786 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5787 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5788 (record_buffer_markers, fetch_buffer_markers): New functions for
5789 recording and fetching special buffer markers.
5790 (set_buffer_internal_1, set_buffer_temp): Use them.
5791
5792 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5793
5794 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5795
5796 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5797 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5798
5799 * xdisp.c (hscroll_window_tree):
5800 (reconsider_clip_changes): Use PT instead of BUF_PT.
5801
d251f04b
EZ
58022011-03-13 Eli Zaretskii <eliz@gnu.org>
5803
5804 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5805 $(EMACS_ROOT)/lib/intprops.h.
5806
f0c77cd1
PE
58072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5808
3eca4629
PE
5809 Fix more problems found by GCC 4.5.2's static checks.
5810
7c86ee98
PE
5811 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5812 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5813 (xg_free_frame_widgets): Make it clear that a local variable is
5814 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5815 (gdk_window_get_screen): Make it clear that this macro is needed
5816 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5817 (int_gtk_range_get_value): New function, which avoids a diagnostic
5818 from gcc -Wbad-function-cast.
5819 (xg_set_toolkit_scroll_bar_thumb): Use it.
5820 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5821 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5822 (get_utf8_string, xg_get_file_with_chooser):
5823 Rename locals to avoid shadowing.
5824 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5825
41729b81
PE
5826 * xgselect.c (xg_select): Remove unused var.
5827
f0c77cd1
PE
5828 * image.c (four_corners_best): Mark locals as initialized.
5829 (gif_load): Initialize transparent_p to zero (Bug#8238).
5830 Mark another local as initialized.
ec6cf4c6 5831 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5832
ce0ad53d 5833 * image.c (clear_image_cache): Now static.
d5d5a617 5834 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5835 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5836 (x_edge_detection): Remove unnecessary cast that
5837 gcc -Wbad-function-cast diagnoses.
2037898d 5838 (gif_load): Fix pointer signedness.
6ae141d6
PE
5839 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5840 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5841
33383987 58422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5843
d32df629
PE
5844 Improve quality of tests for time stamp overflow.
5845 For example, without this patch (encode-time 0 0 0 1 1
5846 1152921504606846976) returns the obviously-bogus value (-948597
5847 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5848 reports time overflow. See
5849 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5850 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5851 * editfns.c: Include limits.h and intprops.h.
5852 (TIME_T_MIN, TIME_T_MAX): New macros.
5853 (time_overflow): Move earlier, to before first use.
5854 (hi_time, lo_time): New functions, for an accurate test for
5855 out-of-range times.
5856 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5857 (Fget_internal_run_time): Don't assume time_t fits in int.
5858 (make_time): Use list2 instead of Fcons twice.
5859 (Fdecode_time): More accurate test for out-of-range times.
5860 (check_tm_member): New function.
5861 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5862 (lisp_time_argument): Don't rely on undefined left-shift and
5863 right-shift behavior when checking for time stamp overflow.
8be6f318 5864
fe31d94c
PE
5865 * editfns.c (time_overflow): New function, refactoring common code.
5866 (Fformat_time_string, Fdecode_time, Fencode_time):
5867 (Fcurrent_time_string): Use it.
5868
8be6f318
PE
5869 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5870 * dired.c (make_time): Move to ...
5871 * editfns.c (make_time): ... here.
5872 * systime.h: Note the move.
5873
09d9db2c 58742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5875
126bc0dc
YM
5876 * fringe.c (update_window_fringes): Remove unused variables.
5877
c47cbdfd
YM
5878 * unexmacosx.c (copy_data_segment): Also copy __got section.
5879 (Bug#8223)
5880
7ac80be9
EZ
58812011-03-12 Eli Zaretskii <eliz@gnu.org>
5882
c96bbc66 5883 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5884 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5885 Constify `char *' arguments and their references according to
5886 prototypes in tparam.h.
5887
ecb0f94d 5888 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5889
7ac80be9
EZ
5890 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5891 Adapt all references accordingly.
5892
5893 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5894
ef1fd07e
TT
58952011-03-11 Tom Tromey <tromey@redhat.com>
5896
5897 * buffer.c (syms_of_buffer): Remove obsolete comment.
5898
7ef4b50c
EZ
58992011-03-11 Eli Zaretskii <eliz@gnu.org>
5900
5901 * termhooks.h (encode_terminal_code): Declare prototype.
5902
5903 * msdos.c (encode_terminal_code): Don't declare prototype.
5904
5905 * term.c (encode_terminal_code): Now external again, used by
5906 w32console.c and msdos.c.
5907
44f230aa
SM
5908 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5909 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5910
4b1ec863 59112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5912
1714f52b 5913 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5914
4b1ec863
PE
5915 * fringe.c (update_window_fringes): Mark locals as initialized
5916 (Bug#8227).
5917 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5918
524c7aa6
PE
5919 * alloc.c (mark_fringe_data): Move decl from here ...
5920 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5921 to check its interface.
5922 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5923
a5c0af81 5924 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5925 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5926 (fontset_font): Mark local as initialized.
a9a06e0b 5927 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5928
b4716021
PE
5929 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5930
811e9bac 5931 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5932 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5933 (x_own_selection, Fx_disown_selection_internal): Rename locals
5934 to avoid shadowing.
5935 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5936
7e3ab302
PE
5937 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5938 so that the caller can use some name other than gcpro1.
5939 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5940 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5941 (Fx_backspace_delete_keys_p):
5942 Use them to avoid shadowing, and rename vars to avoid shadowing.
5943 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5944 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5945 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5946 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5947 Remove unused locals.
7e3ab302
PE
5948 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5949 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5950 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5951 macros.
f78faa98 5952
e2b13473
PE
5953 * xterm.h (x_mouse_leave): New decl.
5954
77f23912
PE
5955 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5956 Remove unused functions.
cdf4ba58
PE
5957 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5958 (x_calc_absolute_position): Now static.
7411c686 5959 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5960 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5961 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5962 unless they are used.
38d0b34a
PE
5963 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5964 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5965 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5966 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5967 (x_error_catcher, x_connection_closed, x_error_handler):
5968 (x_error_quitter, xembed_send_message, x_iconify_frame):
5969 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5970 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5971 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5972
44f230aa
SM
5973 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5974 Rename or move locals to avoid shadowing.
6b463e58 5975 (tty_defined_color, merge_face_heights): Now static.
5967d051 5976 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5977 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5978 does not deduce is never used uninitialized.
73719eba
PE
5979 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5980 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5981
426994c3 5982 * terminal.c (store_terminal_param): Now static.
5489860b 5983
032f1620 5984 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5985 (set_frame_menubar): Remove unused local.
d4323972 5986 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5987 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5988 since they might point to immutable storage.
281585b0
PE
5989 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5990 since it's unused otherwise.
032f1620 5991
367c19e5 5992 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5993 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5994 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5995 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5996 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5997 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5998 does not deduce are never used uninitialized.
70739cbe 5999
07b48fa9
PE
6000 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6001
8868a238 6002 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6003 * window.c (window_loop, size_window):
6004 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6005
7e5cf297 6006 * window.c (display_buffer): Now static.
d6550a9f
PE
6007 (size_window): Mark variables that gcc -Wuninitialized
6008 does not deduce are never used uninitialized.
a586633d
PE
6009 * window.h (check_all_windows): New decl, to forestall
6010 gcc -Wmissing-prototypes diagnostic.
5b555da1 6011 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6012
f6095868
PE
6013 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6014 shadowing.
6015 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6016 Include <limits.h>.
6017 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6018 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6019 (load_charset_map): Mark variables that gcc -Wuninitialized
6020 does not deduce are never used uninitialized.
53df7c11 6021 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6022
f38b440c
PE
6023 * coding.c (coding_set_source, coding_set_destination):
6024 Use "else { /* comment */ }" rather than "else /* comment */;"
6025 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6026 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6027 a block, when the outer 'i' will do.
6028 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6029 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6030 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6031 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6032 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6033 Rename locals to avoid shadowing.
6034 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6035 * coding.c (emacs_mule_char, encode_invocation_designation):
6036 Now static, since they're not used elsewhere.
413bb2db 6037 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6038 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6039 (decode_coding_emacs_mule): Mark variables that gcc
6040 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6041 (detect_coding_iso_2022): Initialize a local variable that might
6042 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6043 this initialization is needed. (Bug#8211)
5f58e762
PE
6044 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6045 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6046 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6047 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6048 Remove unused macros.
f38b440c 6049
232b38b9 6050 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6051 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6052 * character.c (string_count_byte8): Likewise.
232b38b9 6053
fb90da1b
PE
6054 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6055 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6056
fb93dbc2
PE
6057 * chartab.c (copy_sub_char_table): Now static, since it's not used
6058 elsewhere.
5c156ace
PE
6059 (sub_char_table_ref_and_range, char_table_ref_and_range):
6060 Rename locals to avoid shadowing.
bbcd0949 6061 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6062
7d3b3862 6063 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6064 (BIDI_BOB): Remove unused macro.
7d3b3862 6065
6be7d3da
PE
6066 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6067 deduce are never used uninitialized.
c2ed9c8b 6068 * term.c (encode_terminal_code): Likewise.
6be7d3da 6069
75f8807f 6070 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6071
50938595
PE
6072 * tparam.h: New file.
6073 * term.c, tparam.h: Include it.
6074 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6075 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6076 Move these decls to tparam.h, and make them agree with what
6077 is actually in tparam.c. The previous trick of using incompatible
6078 decls in different modules does not conform to the C standard.
6079 All callers of tparam changed to use tparam's actual API.
6080 * tparam.c (tparam1, tparam, tgoto):
6081 Use const pointers where appropriate.
6082
fbceeba2
PE
6083 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6084 * cm.h (struct cm): Likewise.
6085 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6086 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6087 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6088 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6089 (turn_on_face, init_tty): Likewise.
6090 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6091
7f3f1250
PE
6092 * term.c (term_mouse_position): Rename local to avoid shadowing.
6093
e6ca6543
PE
6094 * alloc.c (mark_ttys): Move decl from here ...
6095 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6096
c40f8d15
AS
60972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6098
6099 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6100
cfe0661d
JB
61012011-03-09 Juanma Barranquero <lekktu@gmail.com>
6102
6103 * search.c (compile_pattern_1): Remove argument regp, unused since
6104 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6105 (compile_pattern): Don't pass it.
6106
0afb4571
J
61072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6108
6109 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6110 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6111 for ! HAVE_GTK3.
6112 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6113
6114 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6115
6116 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6117 gdk_window_get_screen, gdk_window_get_geometry,
6118 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6119 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6120 (xg_get_pixbuf_from_pixmap): New function.
6121 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6122 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6123 Call xg_get_pixbuf_from_pixmap instead of
6124 gdk_pixbuf_get_from_drawable.
6125 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6126 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6127 (xg_check_special_colors): Use GtkStyleContext and its functions
6128 for HAVE_GTK3.
6129 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6130 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6131 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6132 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6133 Call gtk_widget_get_preferred_size.
0afb4571
J
6134 (xg_frame_resized): gdk_window_get_geometry only takes 5
6135 parameters.
44f230aa
SM
6136 (xg_win_to_widget, xg_event_is_for_menubar):
6137 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6138 (xg_set_widget_bg): New function.
6139 (delete_cb): New function.
895009e1 6140 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6141 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6142 (xg_set_background_color): Call xg_set_widget_bg.
6143 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6144 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6145 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6146 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6147 if ! HAVE_GTK3.
6148 (update_frame_tool_bar): Call gtk_widget_hide.
6149 (xg_initialize): Use GDK_KEY_g.
6150
6151 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6152 if ! HAVE_GTK3
6153 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6154
6155 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6156 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6157 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6158
1c2cc4ef
JB
61592011-03-08 Juanma Barranquero <lekktu@gmail.com>
6160
6161 * w32xfns.c (select_palette): Check success of RealizePalette against
6162 GDI_ERROR, not zero.
6163
33383987 6164See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6165
6166;; Local Variables:
6167;; coding: utf-8
aac0c6e3
MR
6168;; End:
6169
33383987 6170 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6171
6172 This file is part of GNU Emacs.
6173
6174 GNU Emacs is free software: you can redistribute it and/or modify
6175 it under the terms of the GNU General Public License as published by
6176 the Free Software Foundation, either version 3 of the License, or
6177 (at your option) any later version.
6178
6179 GNU Emacs is distributed in the hope that it will be useful,
6180 but WITHOUT ANY WARRANTY; without even the implied warranty of
6181 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6182 GNU General Public License for more details.
6183
6184 You should have received a copy of the GNU General Public License
6185 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.