Merge changes made in Gnus trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dfb3f755
PE
12011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.h: Include <sys/types.h> instead of <time.h>.
4 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5 Problem reported by Herbert J. Skuhra.
6
3134906c
LMI
72011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8
9 * xml.c (parse_region): Make the parsing work for
10 non-comment-starting XML files again (bug#9144).
11
8d903f4e
AS
122011-09-10 Andreas Schwab <schwab@linux-m68k.org>
13
14 * image.c (gif_load): Fix calculation of bottom and right corner.
15 (Bug#9468)
16
80ad64f4
EZ
172011-09-10 Eli Zaretskii <eliz@gnu.org>
18
19 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
20 redisplay in small windows.
21
208a048d
EZ
222011-09-09 Eli Zaretskii <eliz@gnu.org>
23
24 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
25
9b1c252e
MR
262011-09-08 Martin Rudalics <rudalics@gmx.at>
27
28 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
29 Operate on live windows only.
30
2949f33b
JB
312011-09-08 Juanma Barranquero <lekktu@gmail.com>
32
33 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
34
e08dcafd
EZ
352011-09-07 Eli Zaretskii <eliz@gnu.org>
36
37 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
38 only under bidi iteration.
39
115b96bd
JD
402011-09-07 Jan Djärv <jan.h.d@swipnet.se>
41
42 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
43
c8199d0f
PE
442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
45
46 isnan: Fix porting problem to Solaris 10 with bundled gcc.
47 Without this fix, the command to link temacs failed due to an
48 undefined symbol __builtin_isnan. This is because
49 /usr/include/iso/math_c99.h #defines isnan(x) to
50 __builtin_isnan(x), but the bundled gcc, which identifies itself
51 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
52 a __builtin_isnan.
53 * floatfns.c (isnan): #undef, and then #define to a clone of
54 what's in data.c.
55 (Fisnan): Always define, since it's always available now.
56 (syms_of_floatfns): Always define isnan at the Lisp level.
57
e39b275c 582011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
59
60 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
61
b2db44d9 622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 63
f4af5137 64 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
65 The previous code assumed that file offsets (off_t values) fit in
66 EMACS_INT variables, which is not true on typical 32-bit hosts.
67 The code messed up by falsely reporting buffer overflow in cases
68 such as (insert-file-contents "big" nil 1 2) into an empty buffer
69 when "big" contains more than 2**29 bytes, even though this
70 inserts just one byte and does not overflow the buffer.
71 (Finsert_file_contents): Store file offsets as off_t
72 values, not as EMACS_INT values. Check for overflow when
73 converting between EMACS_INT and off_t. When checking for
74 buffer overflow or for overlap, take the offsets into account.
75 Don't use EMACS_INT for small values where int suffices.
76 When checking for overlap, fix a typo: ZV was used where
77 ZV_BYTE was intended.
78 (Fwrite_region): Don't assume off_t fits into 'long'.
79 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
80
ecfc0a49
MA
812011-09-05 Michael Albinus <michael.albinus@gmx.de>
82
83 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
84
6511acf2 852011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 86
0999621a 87 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
88
89 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 90 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
91 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
92 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
93 (modify_event_symbol): Do not assume that the length of
94 name_alist_or_stem is safe to alloca and fits in int.
95 (Fexecute_extended_command): Likewise for function name and binding.
96 (Frecursion_depth): Wrap around reliably on integer overflow.
97 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
98 since some callers pass EMACS_INT values.
99 (Fsingle_key_description): Don't crash if symbol name contains more
100 than MAX_ALLOCA bytes.
101 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
102 (get_minibuffer): Arg is now EMACS_INT, not int.
103 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 104 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
105 * window.h (command_loop_level, minibuf_level): Reflect API changes.
106
2be7d702
PE
107 * dbusbind.c (signature_cat): New function.
108 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
109 Do not overrun buffer; instead, report string overflow.
110
9d1df220
PE
111 * dispnew.c (add_window_display_history): Don't overrun buffer.
112 Truncate instead; this is OK since it's just a log.
113
33ef5c64
PE
114 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
115 even if the time zone offset is outlandishly large.
116 Don't mishandle offset == INT_MIN.
117
66c6fdd5
PE
118 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
119 when creating daemon; the previous buffer-overflow check was incorrect.
120
d749b01b
PE
121 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
122 which has the guts of the old verror function.
123
b5cd1905
PE
124 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
125 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
126
6e1a67fb
PE
127 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
128 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 129 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 130 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
131 length of string rather than counting it via multiple sprintfs;
132 that's simpler and more reliable.
c21721cc
PE
133 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
134 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
135 sprintf, in case result does not fit in int.
136
c57b67fc
PE
137 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
138 (fontset_from_font): Print it.
139
8a401434
PE
140 * frame.c (tty_frame_count): Now printmax_t, not int.
141 (make_terminal_frame, set_term_frame_name): Print it.
142 (x_report_frame_params): In X, window IDs are unsigned long,
143 not signed long, so print them as unsigned.
144 (validate_x_resource_name): Check for implausibly long names,
145 and don't assume name length fits in 'int'.
146 (x_get_resource_string): Don't blindly alloca invocation name;
147 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
148 not fit in int.
149
6e1a67fb
PE
150 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
151 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
152 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
153
0df02bf3
PE
154 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
155 Use esprintf, not sprintf, in case result does not fit in int.
156
48e30793
PE
157 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
158 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
159 it as a large positive number.
160 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
161 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
162
a66ff6d8
PE
163 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
164 in case result does not fit in int.
165
aca216ff
PE
166 * print.c (float_to_string): Detect width overflow more reliably.
167 (print_object): Make sprintf buffer a bit bigger, to avoid potential
168 buffer overrun. Don't assume list length fits in 'int'. Treat
169 print length of 0 as 0, not as infinity; to be consistent with other
170 uses of print length in this function. Don't overflow print length
171 index. Don't assume hash table size fits in 'long', or that
172 vectorlike size fits in 'unsigned long'.
173
31c286f7
PE
174 * process.c (make_process): Use printmax_t, not int, to format
175 process-name gensyms.
176
55e5faa1
PE
177 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
178
80f2e268
PE
179 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
180 to avoid potential buffer overrun.
181
670741ab
PE
182 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
183 if X resource line is longer than 512 bytes.
184
b7163a50
PE
185 * xfns.c (x_window): Make sprintf buffer a bit bigger
186 to avoid potential buffer overrun.
187
ae58ff1f
PE
188 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
189
c43c8a6a
PE
190 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
191
3f8236f4
PE
1922011-09-04 Paul Eggert <eggert@cs.ucla.edu>
193
53e9fe90 194 Integer overflow fixes for scrolling, etc.
6511acf2
PE
195 Without these, Emacs silently mishandles large integers sometimes.
196 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
197 it were "C-u 1 M-x recenter" on a typical 64-bit host.
198
6511acf2
PE
199 * xdisp.c (try_window_id): Check Emacs fixnum range before
200 converting to 'int'.
806add1d 201
6511acf2 202 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
203 Check that an Emacs fixnum is in range before assigning it to 'int'.
204 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
205 values converted from Emacs fixnums.
206 (Frecenter): Don't wrap around a line count if it is out of 'int'
207 range; instead, treat it as an extreme value.
208 (Fset_window_configuration, compare_window_configurations):
209 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
210
6511acf2
PE
211 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
212 that can exceed INT_MAX. Check that EMACS_INT value is in range
213 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
214 (match_limit): Don't assume that a fixnum can fit in 'int'.
215
6511acf2 216 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
217 exceed INT_MAX.
218
6511acf2 219 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
220 (Fvertical_motion): Don't wrap around LINES values that don't fit
221 in 'int'. Instead, treat them as extreme values. This is good
222 enough for windows, which can't have more than INT_MAX lines anyway.
223
fcb901a7
LMI
2242011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
225
0f2f6b6d
LMI
226 * Require libxml/parser.h to avoid compilation warning.
227
fcb901a7
LMI
228 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
229
230 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
231 since this reportedly can destroy thread storage.
232
6e20a0d4
CY
2332011-08-30 Chong Yidong <cyd@stupidchicken.com>
234
235 * syntax.c (find_defun_start): Update all cache variables if
236 exiting early (Bug#9401).
237
148ae00e
EZ
2382011-08-30 Eli Zaretskii <eliz@gnu.org>
239
f6cfbd8f
EZ
240 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
241
148ae00e
EZ
242 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
243 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
244 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
245
246 * term.c (tty_append_glyph): New function.
247 (produce_stretch_glyph): Static function and its prototype deleted.
248
249 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
250 prototypes.
251
c4a07a4c
PE
2522011-08-29 Paul Eggert <eggert@cs.ucla.edu>
253
254 * image.c (parse_image_spec): Check for nonnegative, not for positive,
255 when checking :margin (Bug#9390).
256 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
257 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
258 so that the name doesn't mislead. All uses changed.
259
6bc8cd65
JB
2602011-08-28 Johan Bockgård <bojohan@gnu.org>
261
262 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
263 set_tty_hooks.
264
dca4927e
EZ
2652011-08-27 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (move_it_to): Don't bail out early when reaching
268 position beyond to_charpos, if we are scanning backwards.
269 (move_it_vertically_backward): When DY == 0, make sure we get to
270 the first character in the line after the newline.
271
f2cad773
PE
2722011-08-27 Paul Eggert <eggert@cs.ucla.edu>
273
274 * ccl.c: Improve and simplify overflow checking (Bug#9196).
275 (ccl_driver): Do not generate an out-of-range pointer.
276 (Fccl_execute_on_string): Remove unnecessary check for
277 integer overflow, noted by Stefan Monnier in
278 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
279 Remove a FIXME that didn't need fixing.
280 Simplify the newly-introduced buffer reallocation code.
281
0cae2cdb
JB
2822011-08-27 Juanma Barranquero <lekktu@gmail.com>
283
284 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
285
5fc295a4 2862011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 287
70c60eb2 288 Integer and memory overflow issues (Bug#9196).
726e0ab1 289
d31850da
PE
290 * doc.c (get_doc_string): Rework so that
291 get_doc_string_buffer_size is the actual buffer size, rather than
292 being 1 less than the actual buffer size; this makes xpalloc more
293 convenient.
294
a69fbedb
PE
295 * image.c (x_allocate_bitmap_record, cache_image):
296 * xselect.c (Fx_register_dnd_atom):
297 Simplify previous changes by using xpalloc.
298
fe5c5d37
PE
299 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
300 since either will do and ptrdiff_t is convenient with xpalloc.
301
0065d054
PE
302 * charset.c (charset_table_size)
303 (struct charset_sort_data.priority): Now ptrdiff_t.
304 (charset_compare): Don't overflow if priorities differ greatly.
305 (Fsort_charsets): Don't assume list length fits in int.
306 Check for size-calculation overflow when allocating sort data.
307 (syms_of_charset): Allocate an initial charset table that is
308 just under 64 KiB, to avoid problems with glibc malloc and mmap.
309
310 * cmds.c (internal_self_insert): Check for size-calculation overflow.
311
312 * composite.h (struct composition.glyph_len): Now int, not unsigned.
313 The actual value is always <= INT_MAX, and leaving it unsigned made
314 overflow checking harder.
315
316 * dispextern.h (struct glyph_matrix.rows_allocated)
317 (struct face_cache.size): Now ptrdiff_t, for convenience in use
318 with xpalloc. The values are still always <= INT_MAX.
319
320 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
321
322 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
323 (SAFE_NALLOCA): New macro.
324
325 * region-cache.c (struct boundary.pos, find_cache_boundary)
326 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
327 (set_cache_region, invalidate_region_cache)
328 (revalidate_region_cache, know_region_cache, region_cache_forward)
329 (region_cache_backward, pp_cache):
330 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
331 so that ptrdiff_t * can be passed to xpalloc.
332 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
333 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
334 (pp_cache): Don't assume cache_len fits in int.
335 * region-cache.h: Adjust extern decls to match.
336
337 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
338 EMACS_INT, since either will do, for xpalloc.
339
340 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
341 (xnmalloc, xnrealloc, xpalloc): New functions.
342
726e0ab1
PE
343 * bidi.c (bidi_shelve_header_size): New constant.
344 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
345 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
346
51f30bc5 347 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
348 * buffer.c (overlays_at, overlays_in, record_overlay_string)
349 (overlay_strings):
350 Don't update size of array until after memory allocation succeeds,
351 because xmalloc/xrealloc may not return.
0065d054
PE
352 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
353 now that we have proper integer overflow checking.
354 (record_overlay_string, overlay_strings): Catch overflows when
355 calculating size of overlay_str_buf.
726e0ab1 356
0065d054
PE
357 * callproc.c (Fcall_process): Check for size overflow when
358 calculating size of args2.
359 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
360 Normally we prefer signed values, but sticking with ptrdiff_t would
361 require adding more-complicated checks.
726e0ab1
PE
362
363 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
364 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
365 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 366 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
367
368 * character.c (Fstring): Check for size-calculation overflow.
369
370 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
371 unnecessary integer overflow. Check for size overflow.
372 (encode_coding_object): Don't update size until xmalloc succeeds.
373
374 * composite.c (get_composition_id): Check for overflow in glyph
375 length calculations.
376
377 Integer and memory overflow fixes for display code.
378 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
379 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
380 (scrolling_window): Check for overflow in size calculations.
381 (line_draw_cost, realloc_glyph_pool, add_row_entry):
382 Don't assume glyph table len fits in int.
383 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
384 (row_table_size): Now ptrdiff_t, not int.
385 (scrolling_window): Avoid overflow in size calculations.
386 Don't update size until allocation succeeds.
387 * fns.c (concat): Check for overflow in size calculations.
388 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
389 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
390 (NEXT_ALMOST_PRIME_LIMIT): New constant.
391
392 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
393 (get_doc_string): Check for size calculation overflow.
394 Don't update size until allocation succeeds.
395 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
396 EMACS_INT, where ptrdiff_t will do.
397 (Fsubstitute_command_keys): Check for string overflow.
398
399 * editfns.c (set_time_zone_rule): Don't assume environment length
400 fits in int.
401 (message_length): Now ptrdiff_t, not int.
402 (Fmessage_box): Don't update size until allocation succeeds.
403 Don't assume message length fits in int.
404 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
405
0065d054
PE
406 * emacs.c (main): Do not reallocate argv, since there is a null at
407 the end that can be overwritten, and this way there's no need to
408 worry about size-calculation overflow.
409 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
410
411 * eval.c (init_eval_once, grow_specpdl): Don't update size until
412 alloc succeeds.
413 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
414
415 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
416 (x_set_scroll_bar_width, x_figure_window_size):
417 Check for integer overflow.
418 (x_set_alpha): Do not assume XINT fits in int.
419
420 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
421 This is for the members text_lines, text_cols, total_lines, total_cols,
422 where the system imposes an 'int' limit.
423
424 * fringe.c (Fdefine_fringe_bitmap):
425 Don't update size until alloc works.
426
427 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
428 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
429
430 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
431 Check for size-calculation overflow.
432 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
433 do, as we prefer signed integers.
434 (id_to_widget.max_size, id_to_widget.used)
435 (xg_store_widget_in_map, xg_remove_widget_from_map)
436 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
437 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
438 Use and return ptrdiff_t, not int.
439 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
440 * gtkutil.h: Change prototypes to match the above.
441
442 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
443 are duplicate now that they've been promoted to lisp.h.
444 (x_allocate_bitmap_record, x_alloc_image_color)
445 (make_image_cache, cache_image, xpm_load):
446 Don't update size until alloc is done.
447 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
448 (x_detect_edges):
3256efce 449 Check for size calculation overflow.
726e0ab1
PE
450 (ct_colors_allocated_max): New constant.
451 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
452 overflow.
3256efce 453
726e0ab1
PE
454 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
455 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
456 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
457 Use ptrdiff_t, not int, to count maps.
458 (read_char_minibuf_menu_prompt): Check for overflow in size
459 calculations. Don't update size until allocation succeeds. Redo
460 calculations to avoid overflow.
461 * keyboard.h: Change prototypes to match the above.
462
463 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
464 to count maps.
465 (current_minor_maps): Check for size calculation overflow.
466 * keymap.h: Change prototypes to match the above.
467
468 * lread.c (read1, init_obarray): Don't update size until alloc done.
469
470 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
471 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
472
726e0ab1
PE
473 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
474 Now ptrdiff_t, not int.
475 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
476 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
477
478 * process.c (Fnetwork_interface_list): Check for overflow
479 in size calculation.
480
481 * region-cache.c (move_cache_gap): Check for size calculation overflow.
482
483 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
484 overflow. Don't bother calling xmalloc when xrealloc will do.
485
486 * search.c (Freplace_match): Check for size calculation overflow.
487 (Fset_match_data): Don't assume list lengths fit in 'int'.
488
489 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
490 for command line length. Do not attempt to address one before the
491 beginning of an array, as that's not portable.
492
493 * term.c (max_frame_lines): Remove; unused.
494 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
495 not int.
496 (encode_terminal_code, calculate_costs): Check for size
497 calculation overflow.
498 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
499 table lengths and related sizes. Don't update size until alloc
500 done. Redo calculations to avoid overflow.
501 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
502
503 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
504 subtracting pointers.
505 (gobble_line): Check for overflow more carefully. Don't update size
506 until alloc done.
507
508 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
509 Don't update size until alloc done.
510 Redo size calculations to avoid overflow.
511 Check for size calculation overflow.
0065d054 512 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
513
514 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
515 Use ptrdiff_t, not int, for sizes.
516 (store_mode_line_noprop_char): Don't update size until alloc done.
517
0065d054
PE
518 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
519 Use ptrdiff_t, not int, for sizes.
520 (Finternal_make_lisp_face, cache_face):
521 Check for size calculation overflow.
522 (cache_face): Treat size calculation overflows as if they were
523 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
524
525 * xfns.c (x_encode_text, x_set_name_internal)
526 (Fx_change_window_property): Use ptrdiff_t, not int, to count
527 sizes, since they can exceed INT_MAX in size. Check for size
528 calculation overflow.
529
0065d054
PE
530 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
531 (xg_select): Check for size calculation overflow.
726e0ab1
PE
532 Don't update size until alloc done.
533
0065d054 534 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 535 as sprintf is limited to int lengths.
1d526e2f 536
252c5ee1
PE
537 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
538 (X_LONG_MIN): New macros.
864d7ce7
PE
539 Use them to make the following changes clearer.
540 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
541 This change doesn't affect the value now, but it may help remind
542 future maintainers not to raise the value too much later.
543 (SELECTION_QUANTUM): Remove, replacing with ...
544 (selection_quantum): ... new function, which avoids overflow.
545 All uses changed.
546 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
547 assumption that selection length fits in 'int'.
548 (x_reply_selection_request, x_handle_selection_request)
549 (x_get_window_property, receive_incremental_selection)
550 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
551 (lisp_data_to_selection_data, clean_local_selection_data):
552 Use ptrdiff_t, not int, to record length of selection.
553 (x_reply_selection_request, x_get_window_property)
554 (receive_incremental_selection, x_property_data_to_lisp):
555 Redo calculations to avoid overflow.
556 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 557 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
558 something.
559 (x_get_window_property, receive_incremental_selection)
560 (lisp_data_to_selection_data, x_property_data_to_lisp):
561 Check for size-calculation overflow.
562 (x_get_window_property, receive_incremental_selection)
563 (lisp_data_to_selection_data, Fx_register_dnd_atom):
564 Don't store size until memory allocation succeeds.
565 (x_get_window_property): Plug memory leak on memory exhaustion.
566 Don't double-block input; malloc is safe here. Don't assume 2**34
567 - 4 fits in unsigned long. Add an xassert to check
568 XGetWindowProperty overflow. Be more careful about overflow
569 calculations, and distinguish size from memory overflow better.
570 (receive_incremental_selection): When tracing, don't assume
571 unsigned int is less than INT_MAX.
572 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
573 harmful) conversions of unsigned short to int.
574 (lisp_data_to_selection_data): Don't assume that integers
575 in the range -65535 through -1 fit in an X unsigned short.
576 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
577 result parameters unless successful. Rely on cons_to_unsigned
578 to report problems with elements; the old code wasn't right anyway.
579 (x_check_property_data): Check for int overflow; we cannot use
580 a wider type due to X limits.
581 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
582
726e0ab1 583 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 584
0065d054
PE
585 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
586 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
587 (x_color_cells): Don't store size until memory allocation succeeds.
588 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 589 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
590 (x_term_init): Don't assume length fits in int (sprintf is limited
591 to int size).
bc18e09d 592
ebfa62c0
PE
593 Use ptrdiff_t for composition IDs.
594 * character.c (lisp_string_width):
595 * composite.c (composition_table_size, n_compositions)
596 (get_composition_id, composition_gstring_from_id):
597 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
598 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
599 * window.c (Frecenter):
600 Use ptrdiff_t, not int, for composition IDs.
601 * composite.c (get_composition_id): Check for integer overflow.
602 * composite.h: Adjust prototypes to match the above changes.
603
d3411f89
PE
604 Use ptrdiff_t for hash table indexes.
605 * category.c (hash_get_category_set):
606 * ccl.c (ccl_driver):
607 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
608 * coding.c (coding_system_charset_list, detect_coding_system):
609 * coding.h (struct coding_system.id):
610 * composite.c (get_composition_id, gstring_lookup_cache):
611 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
612 * image.c (xpm_get_color_table_h):
613 * lisp.h (hash_lookup, hash_put):
614 * minibuf.c (Ftest_completion):
615 Use ptrdiff_t for hash table indexes, not int (which is too
616 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
617 32-bit --with-wide-int hosts).
618
e097a6fa
PE
619 * charset.c (Fdefine_charset_internal): Check for integer overflow.
620 Add a FIXME comment about memory leaks.
621 (syms_of_charset): Don't assume xmalloc returns.
622
5637687f
PE
623 Don't assume that stated character widths fit in int.
624 * character.c (Fchar_width, c_string_width, lisp_string_width):
625 * character.h (CHAR_WIDTH):
626 * indent.c (MULTIBYTE_BYTES_WIDTH):
627 Use sanitize_char_width to avoid undefined and/or bad behavior
628 with outlandish widths.
629 * character.h (sanitize_tab_width): Renamed from sanitize_width,
630 now that we have two such functions. All uses changed.
631 (sanitize_char_width): New inline function.
632
a2271ba2
PE
633 Don't assume that tab-width fits in int.
634 * character.h (sanitize_width): New inline function.
635 (SANE_TAB_WIDTH): New macro.
636 (ASCII_CHAR_WIDTH): Use it.
637 * indent.c (sane_tab_width): Remove. All uses replaced by
638 SANE_TAB_WIDTH (current_buffer).
639 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
640
18c52557
PE
641 * fileio.c: Integer overflow issues with file modes.
642 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
643
caeeedc1
PE
644 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
645 Remove unreachable code.
646 (read_hex, load_charset_map_from_file): Check for integer overflow.
647
50849c52
PE
648 * xterm.c: don't go over XClientMessageEvent limit
649 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
650 (x_send_scroll_bar_event): Likewise. Check that the size does not
651 exceed limits imposed by XClientMessageEvent, as well as the usual
652 ptrdiff_t and size_t limits.
653
b13995db
PE
654 * keyboard.c: Overflow, signedness and related fixes.
655 (make_lispy_movement): Use same integer type in forward decl
656 that is used in the definition.
657 (read_key_sequence, keyremap_step):
658 Change bufsize argument back to int, undoing my 2011-03-30 change.
659 We prefer signed types, and int is wide enough here.
660 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
661 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
662 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
663 length, not size_t. Use ptrdiff_t for index, not int.
664 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
665 possibility of integer overflow.
666
13464394
PE
667 Overflow, signedness and related fixes for images.
668
669 * dispextern.h (struct it.stack[0].u.image.image_id)
670 (struct_it.image_id, struct image.id, struct image_cache.size)
671 (struct image_cache.used, struct image_cache.ref_count):
672 * gtkutil.c (update_frame_tool_bar):
673 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
674 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
675 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
676 * nsmenu.m (update_frame_tool_bar):
677 * xdisp.c (calc_pixel_width_or_height):
678 * xfns.c (image_cache_refcount):
679 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
680 on typical 64-bit hosts.
681
682 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
683 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
684 Omit unnecessary casts to int.
685 (parse_image_spec): Check that integers fall into 'int' range
686 when the callers expect that.
687 (image_ascent): Redo ascent calculation to avoid int overflow.
688 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
689 (lookup_image): Remove unnecessary tests.
690 (xbm_image_p): Locals are now of int, not EMACS_INT,
691 since parse_image_check makes sure they fit into int.
692 (png_load, gif_load, svg_load_image):
693 Prefer int to unsigned where either will do.
694 (tiff_handler): New function, combining the cores of the
695 old tiff_error_handler and tiff_warning_handler. This
696 function is rewritten to use vsnprintf and thereby avoid
697 stack buffer overflows. It uses only the features of vsnprintf
698 that are common to both POSIX and native Microsoft.
699 (tiff_error_handler, tiff_warning_handler): Use it.
700 (tiff_load, gif_load, imagemagick_load_image):
701 Don't assume :index value fits in 'int'.
702 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
703 (imagemagick_load_image): Check that crop parameters fit into
704 the integer types that MagickCropImage accepts. Don't assume
705 Vimagemagick_render_type has a nonnegative value. Don't assume
706 size_t fits in 'long'.
707 (gs_load): Use printmax_t to print the widest integers possible.
708 Check for integer overflow when computing image height and width.
709
c11821d4
EZ
7102011-08-26 Eli Zaretskii <eliz@gnu.org>
711
712 * xdisp.c (redisplay_window): Don't force window start if point
713 will be invisible in the resulting window. (Bug#9324)
714
0c95fcf7
EZ
7152011-08-25 Eli Zaretskii <eliz@gnu.org>
716
717 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
718 the display spec is of the form `(space ...)'.
719 (handle_display_spec): Return the value returned by
720 handle_single_display_spec, not just 1 or zero.
721 (handle_single_display_spec): If the display spec is of the form
722 `(space ...)', and specifies display in the text area, return 2
723 rather than 1.
fee65a97 724 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
725 accurately, and prefer exact match for point under bidi. Don't
726 advance `row' beyond the last row of the window.
0c95fcf7
EZ
727
728 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
729 into disp_prop; all users changed.
730
731 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
732 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
733 for the text covered by the display property.
734
e4ed06f1
CY
7352011-08-25 Chong Yidong <cyd@stupidchicken.com>
736
737 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
738 Change return value to nil.
739 (Frecord_buffer): Delete unused function.
740
f67cdd7f
EZ
7412011-08-24 Eli Zaretskii <eliz@gnu.org>
742
5980d4c6
EZ
743 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
744 buffers, return left-to-right.
8610fe8b
EZ
745 (set_cursor_from_row): Consider candidate row a win if its glyph
746 represents a newline and point is on that newline. Fixes cursor
747 positioning on the newline at EOL of R2L text within L2R
748 paragraph, and vice versa.
749 (try_cursor_movement): Check continued rows, in addition to
750 continuation rows. Fixes unwarranted scroll when point enters a
751 continued line of R2L text within an L2R paragraph, or vice versa.
752 (cursor_row_p): Consider the case of point being equal to
753 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
754 from the end of a short line to the beginning of a continued line
755 of R2L text within L2R paragraph.
756 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
757 composed characters.
5980d4c6 758
f67cdd7f
EZ
759 * bidi.c (bidi_check_type): Use xassert.
760 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
761 members.
762
bca633fb
EZ
7632011-08-23 Eli Zaretskii <eliz@gnu.org>
764
765 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
766 a character.
767
4a5885a7
CY
7682011-08-23 Chong Yidong <cyd@stupidchicken.com>
769
770 * nsfont.m (ns_otf_to_script): Fix typo.
771
0902a04e
KH
7722011-08-22 Kenichi Handa <handa@m17n.org>
773
774 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
775 extra slot even if the purpose is char-code-property-table.
776
1a2e6670
EZ
7772011-08-23 Eli Zaretskii <eliz@gnu.org>
778
8ddde651
EZ
779 * xdisp.c (redisplay_window): When computing centering_position,
780 account for the height of the header line. (Bug#8874)
781
425cc014
EZ
782 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
783 instead of CHAR_TO_BYTE. Fixes a crash when a completion
784 candidate is selected by the mouse, and that candidate has a
785 composed character under the mouse.
786
1a2e6670
EZ
787 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
788 coordinates reported by pos-visible-in-window-p for a composed
789 character in column zero.
790
8b76d6f8
SM
7912011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
792
793 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
794
dac347dd
EZ
7952011-08-22 Eli Zaretskii <eliz@gnu.org>
796
797 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
798 consider it a hit if to_charpos is anywhere in the range of the
799 composed buffer positions.
800
e013fb34
CY
8012011-08-22 Chong Yidong <cyd@stupidchicken.com>
802
803 * image.c (gif_load): Don't assume that each subimage has the same
804 dimensions as the base image. Handle disposal method that is
805 "undefined" by the gif spec (Bug#9335).
806
bd1ba3e8
CY
8072011-08-20 Chong Yidong <cyd@stupidchicken.com>
808
809 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 810 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 811
54a1215b
EZ
8122011-08-19 Eli Zaretskii <eliz@gnu.org>
813
823564e5
EZ
814 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
815 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
816 from an Org mode buffer to a Speedbar frame.
817
54a1215b
EZ
818 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
819 a composition, take its buffer position from IT->cmp_it.charpos.
820 Fixes cursor positioning at the beginning of a line that begins
821 with a composed character.
822
9778ebcc
EZ
8232011-08-18 Eli Zaretskii <eliz@gnu.org>
824
0be6ee06
EZ
825 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
826 character bidirectional type, use STRONG_L instead. Fixes crashes
827 in a buffer produced by `describe-categories'.
828
9778ebcc
EZ
829 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
830 members before the level stack, so they would be saved and
831 restored when copying iterator state. Fixes incorrect reordering
832 around TABs covered by display properties.
833
156bffbe
AS
8342011-08-18 Andreas Schwab <schwab@linux-m68k.org>
835
836 * process.c (Fnetwork_interface_list): Correctly determine buffer
837 size.
838
72ad093b
CY
8392011-08-17 Chong Yidong <cyd@stupidchicken.com>
840
841 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
842 (internal_condition_case_2, internal_condition_case_n):
843 Remove unnecessary aborts (Bug#9081).
72ad093b 844
35774242
EZ
8452011-08-17 Eli Zaretskii <eliz@gnu.org>
846
847 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
848 has no `load' handler, try opening the file locally. (Bug#9311)
849
db76dd85
KB
8502011-08-16 Ken Brown <kbrown@cornell.edu>
851
852 * gmalloc.c: Expand comment.
853
b215eee5
EZ
8542011-08-16 Eli Zaretskii <eliz@gnu.org>
855
856 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
857 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
858
a4579d33
KB
8592011-08-16 Ken Brown <kbrown@cornell.edu>
860
861 Fix memory allocation problems in Cygwin build (Bug#9273).
862
863 * unexcw.c ( __malloc_initialized): Declare external variable.
864 (fixup_executable): Force the dumped emacs to reinitialize malloc.
865
8b76d6f8
SM
866 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
867 New variables.
a4579d33
KB
868 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
869 dumped emacs.
870 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
871 in the static heap.
872 [CYGWIN] (special_realloc): New function.
873 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
874 requests to realloc storage in the static heap.
875
3ebec551
PE
8762011-08-15 Paul Eggert <eggert@cs.ucla.edu>
877
878 * bidi.c (bidi_initialize): Remove unused local.
879
9fd8be00
EZ
8802011-08-15 Eli Zaretskii <eliz@gnu.org>
881
474a8465
EZ
882 * biditype.h: File removed.
883
884 * bidimirror.h: File removed.
885
886 * deps.mk (bidi.o): Remove biditype.h and
887 bidimirror.h.
888
889 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
890 bidimirror.h.
891
892 * dispextern.h: Fix a typo in the comment to bidi_type_t.
893
894 * chartab.c: Improve commentary for the uniprop_table API.
895
32413314
EZ
896 * bidi.c (bidi_paragraph_init): Support zero value of
897 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
898 (bidi_initialize): Use uniprop_table instead of including
899 biditype.h and bidimirror.h.
32413314 900
9fd8be00
EZ
901 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
902 coordinates of the iterator when restoring from ppos_it.
903 (Bug#9296)
904
5cf2b69b
KH
9052011-08-14 Kenichi Handa <handa@m17n.org>
906
907 * process.c (create_process): Call setup_process_coding_systems
72ad093b 908 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 909
daf17d00
EZ
9102011-08-14 Eli Zaretskii <eliz@gnu.org>
911
912 * xdisp.c (move_it_in_display_line_to): Don't invoke
913 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
914 ppos_it. Fixes vertical cursor motion when line beginning is
915 covered by an image. (Bug#9296)
916
08e3161a
JD
9172011-08-14 Jan Djärv <jan.h.d@swipnet.se>
918
919 * nsterm.h (ns_run_ascript): Declare.
920 (NSAPP_DATA2_RUNASSCRIPT): Define.
921
922 * nsfns.m (as_script, as_result, as_status): New static variables.
923 (ns_run_ascript): New function.
5e617bc2 924 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
925 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
926 the event loop. Get status from as_status (Bug#7276).
927
928 * nsterm.m (sendEvent): If event is NSApplicationDefined and
929 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
930 the event loop (Bug#7276).
931
a3720aa2
AS
9322011-08-14 Andreas Schwab <schwab@linux-m68k.org>
933
934 * gnutls.c (QCgnutls_bootprop_priority)
935 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
936 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
937 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
938 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
939 (QCgnutls_bootprop_verify_hostname_error)
940 (QCgnutls_bootprop_callbacks_verify): Rename from
941 Qgnutls_bootprop_..., all uses changed.
942
943 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
944 uses changed.
945
0a0d27fb
PE
9462011-08-14 Paul Eggert <eggert@cs.ucla.edu>
947
19d5c50c
PE
948 * xfaces.c (Qframe_set_background_mode): Now static.
949 * dispextern.h (Qframe_set_background_mode): Remove decl.
950
0a0d27fb
PE
951 * process.c (Fnetwork_interface_info): Declare local only if needed.
952
377538cb
JD
9532011-08-13 Jan Djärv <jan.h.d@swipnet.se>
954
955 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
956 (Fnetwork_interface_list): Allocate in increments of bytes instead
957 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
958 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
959 sockaddr.
960 (struct ifflag_def): notrailers is smart on OSX.
961 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
962 Get hardware address with getifaddrs if available.
963
08fff70c
EZ
9642011-08-12 Eli Zaretskii <eliz@gnu.org>
965
966 * xdisp.c (iterate_out_of_display_property): xassert that
967 IT->position is set to within IT->object's boundaries. Break from
968 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
969 when IT->position is set up wrongly due to some bug.
970 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
971 (push_display_prop): Allow GET_FROM_STRING as IT->method on
972 entry. Force push_it to save on the stack the current
973 buffer/string position, to be restored by pop_it. Fix flags in
974 the iterator structure wrt the object coming from a display
975 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
976 properties. (Bug#9284)
977
7be1c708 9782011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 979
7be1c708
CY
980 * fontset.c (fontset_get_font_group): Add proper type checks.
981 (Bug#9172)
aac0c6e3 982
7be1c708 9832011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 984
7be1c708
CY
985 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
986 and LC_VERSION_MIN_MACOSX.
987 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
988 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 989
97bb72a6
EZ
9902011-08-08 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
993 no-display-properties-and-no-overlays under bidi display.
994 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 995 properties and overlays.
97bb72a6 996
d5617611
CY
9972011-08-08 Chong Yidong <cyd@stupidchicken.com>
998
37e11a63
CY
999 * editfns.c (Fset_time_zone_rule): Document relationship with the
1000 setenv function.
1001
d5617611
CY
1002 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1003 the font entity extracted from the cache (Bug#8109).
1004
58872834
CY
10052011-08-07 Chong Yidong <cyd@stupidchicken.com>
1006
1007 * composite.c (autocmp_chars): Don't reset point. That is done by
1008 restore_point_unwind (Bug#5984).
1009
75bfc667
JL
10102011-08-07 Juri Linkov <juri@jurta.org>
1011
1012 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1013 to show the arg `TIME' instead of `TIMEVAL'.
1014
d1410150
EZ
10152011-08-06 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1018 display property strides EOL and includes a newline, as in
1019 longlines-mode. (Bug#9254)
75b771e4
EZ
1020 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1021 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1022
1023 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1024 is non-zero, even if the data buffer is NULL. Fixes a crash in
1025 vertical-motion with longlines-mode. (Bug#9254)
1026
35928349
EZ
10272011-08-05 Eli Zaretskii <eliz@gnu.org>
1028
ec7cc85b
EZ
1029 * bidi.c <bidi_cache_total_alloc>: Now static.
1030 (bidi_initialize): Initialize bidi_cache_total_alloc.
1031
8b76d6f8 1032 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1033 cache. (Bug#9221)
1034
1035 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1036 amount allocated this far in `bidi_cache_total_alloc'.
1037 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1038 non-zero, only free the data buffer without restoring the cache
1039 contents. All callers changed.
1040
1041 * dispextern.h (bidi_unshelve_cache): Update prototype.
1042
1043 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1044 (move_it_in_display_line, move_it_to)
1045 (move_it_vertically_backward, move_it_by_lines): Replace the call
1046 to xfree to an equivalent call to bidi_unshelve_cache.
1047 (move_it_in_display_line_to): Fix logic of returning
412b6358 1048 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1049
e2e2423b
EZ
10502011-08-05 Eli Zaretskii <eliz@gnu.org>
1051
1052 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1053 came from a string character with a `cursor' property. (Bug#9229)
1054
ae9e757a
JD
10552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1056
1057 * Makefile.in (LIB_PTHREAD): New variable.
1058 (LIBES): Add LIB_PTHREAD (Bug#9216).
1059
1060 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1061 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1062
213bd7f2
AS
10632011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1064
1065 * regex.c (re_iswctype): Remove some redundant boolean
1066 conversions.
1067
99aaf75f
JD
10682011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1069
1070 * xterm.c (x_find_topmost_parent): New function.
1071 (x_set_frame_alpha): Find topmost parent window with
1072 x_find_topmost_parent and set the property there also (bug#9181).
1073 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1074
c74e9d86
PE
10752011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * callproc.c (Fcall_process): Avoid vfork clobbering
1078 the local vars buffer, coding_systems, current_dir.
1079
640c8776
SM
10802011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1081
1082 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1083
f26d0e4c
PE
10842011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1085
8a10d76c
PE
1086 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1087 so that it is not optimized away.
1088
f26d0e4c
PE
1089 * xdisp.c (compute_display_string_pos): Remove unused local.
1090
55439c61
EZ
10912011-08-02 Eli Zaretskii <eliz@gnu.org>
1092
1093 Fix slow cursor motion and scrolling in large buffers with
1094 selective display, like Org Mode buffers. (Bug#9218)
1095
1096 * dispextern.h (struct bidi_it): New member disp_prop_p.
1097
1098 * xdisp.c: Remove one-slot cache of display string positions.
1099 (compute_display_string_pos): Accept an additional argument
5e617bc2 1100 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1101 for a display string or property. If found, set DISP_PROP_P
1102 non-zero.
1103
1104 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1105 DISP_PROP_P, and pass it to compute_display_string_pos.
1106 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1107 non-zero. All callers of bidi_fetch_char changed.
1108
fb33fa43
SM
11092011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1110
1111 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1112
b099e063
DM
11132010-12-03 Don March <don@ohspite.net>
1114
1115 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1116 last character M-[char] is translated to ESC [char] (bug#7541).
1117
5cc7f7af
KH
11182011-08-02 Kenichi Handa <handa@m17n.org>
1119
d0fffa3f 1120 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1121
1122 * chartab.c (uniprop_table): Make it non-static.
1123
525d5e6e
EZ
11242011-08-01 Eli Zaretskii <eliz@gnu.org>
1125
1126 * xdisp.c (forward_to_next_line_start): Accept additional argument
1127 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1128 on the newline.
1129 (reseat_at_next_visible_line_start): Use the bidi iterator state
1130 returned by forward_to_next_line_start to restore the state of
1131 it->bidi_it after backing up to previous newline. (Bug#9212)
1132
31011111
AS
11332011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1134
1135 * regex.c (re_comp): Protoize.
1136 (re_exec): Fix return type.
1137 (regexec): Fix type of `ret'. (Bug#9203)
1138
476371c4
PE
11392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1140
e5d76069
PE
1141 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1142 This is needed if max-image-size is a floating-point number.
1143
9a79b20c
AS
11442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1145
1146 * print.c (print_object): Print empty symbol as ##.
1147
1148 * lread.c (read1): Read ## as empty symbol.
1149
d8c2fa78
AA
11502011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1151
1152 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1153 setting frame foreground color (Bug#9175).
1154 (x_set_background_color): Likewise.
1155
ffe57a7a
AA
1156 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1157 contents (Bug#9176).
1158 (EmacsTooltip -init): Remove bezels and add shadows to
1159 tooltip windows.
1160
bf3492a5
AA
1161 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1162 or scroll bar (Bug#8470).
1163
d55e9c53
AA
1164 * nsfont.m (nsfont_open): Remove assignment to voffset and
1165 unnecessary vars hshink, expand, hd, full_height, min_height.
1166 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1167
1168 * nsterm.h (nsfont_info): Remove voffset field.
1169
d8c2fa78 11702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1171
1172 Implement strike-through and overline on NextStep (Bug#8863).
1173
1174 * nsfont.m (nsfont_open): Use underline position provided by font,
1175 instead of hard-coded value of 2.
1176 (nsfont_draw): Call ns_draw_text_decoration instead.
1177
1178 * nsterm.h: Add declaration for ns_draw_text_decoration.
1179
1180 * nsterm.m (ns_draw_text_decoration): New function for drawing
1181 underline, overline, and strike-through.
1182 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1183 ns_draw_text_decoration. Change treatment of cursor drawing to
1184 accomodate underlining, etc.
1185
4cc60b9b
EZ
11862011-07-28 Eli Zaretskii <eliz@gnu.org>
1187
bc7ece87
EZ
1188 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1189 default.
4cc60b9b 1190
476371c4
PE
11912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1192
66606eea
PE
1193 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1194 Without this fix, if a signal arrives just after memory fills up,
1195 'malloc' might be invoked reentrantly.
1196
476371c4
PE
1197 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1198 In other words, assume that every image size is allowed, on non-X
1199 hosts. This assumption is probably wrong, but it lets Emacs compile.
1200
f3fcc40d
AS
12012011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1202
1203 * regex.c (re_iswctype): Convert return values to boolean.
1204
350c992f
EZ
12052011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1206
1207 * xdisp.c (compute_display_string_pos): Don't use cached display
1208 string position if the buffer had its restriction changed.
1209 (Bug#9184)
1210
5266b4bb
PE
12112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1214
2573a837 12152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1216
41f55ccd 1217 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1218
39e378da
PE
1219 * bidi.c: Integer size and overflow fixes.
1220 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1221 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1222 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1223 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1224 (bidi_find_other_level_edge):
1225 Use ptrdiff_t instead of EMACS_INT where either will do.
1226 This works better on 32-bit hosts configured --with-wide-int.
1227 (bidi_cache_ensure_space): Check for size-calculation overflow.
1228 Use % rather than repeated addition, for better worst-case speed.
1229 Don't set bidi_cache_size until after xrealloc returns, because it
1230 might not return.
1231 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1232 (bidi_cache_ensure_space): Also check that the bidi cache size
1233 does not exceed that of the largest Lisp string or buffer. See Eli
1234 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1235
5e927815
PE
1236 * alloc.c (__malloc_size_t): Remove.
1237 All uses replaced by size_t. See Andreas Schwab's note
1238 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1239
ca4aa935
PE
1240 * image.c: Improve checking for integer overflow.
1241 (check_image_size): Assume that f is nonnull, since
1242 it is always nonnull in practice. This is one less thing to
1243 worry about when checking for integer overflow later.
1244 (x_check_image_size): New function, which checks for integer
1245 overflow issues inside X.
1246 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1247 This removes the need for a memory_full check.
1248 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1249 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1250 (xbm_read_bitmap_data): Change locals back to 'int', since
1251 their values must fit in 'int'.
1252 (xpm_load_image, png_load, tiff_load):
1253 Invoke x_create_x_image_and_pixmap earlier,
1254 to avoid much needless work if the image is too large.
1255 (tiff_load): Treat overly large images as if
1256 x_create_x_image_and_pixmap failed, not as malloc failures.
1257 (gs_load): Use x_check_image_size.
1258
5f8f9cc2
PE
1259 * gtkutil.c: Omit integer casts.
1260 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1261 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1262
5adf60bc
PE
1263 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1264
c8907a93
PE
1265 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1266 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1267 would wrongly return t on a 64-bit host.
1268
e3c25c68
PE
1269 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1270 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1271 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1272 and therefore cause GCC to emit a bogus diagnostic in some cases.
1273
3f791afe
PE
1274 * image.c: Integer signedness and overflow and related fixes.
1275 This is not an exhaustive set of fixes, but it's time to
1276 record what I've got.
1277 (lookup_pixel_color, check_image_size): Remove redundant decls.
1278 (check_image_size): Don't assume that arbitrary EMACS_INT values
1279 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1280 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1281 (tiff_load, imagemagick_load_image):
1282 Check for overflow in size calculations.
1283 (x_create_x_image_and_pixmap): Remove unnecessary test for
1284 xmalloc returning NULL; that can't happen.
1285 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1286 (xpm_color_bucket): Use better integer hashing function.
1287 (xpm_cache_color): Don't possibly over-allocate memory.
1288 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1289 (gif_memory_source):
1290 Use ptrdiff_t, not int or size_t, to record sizes.
1291 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1292 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1293 either works, as we prefer signed integers.
1294 (tiff_read_from_memory, tiff_write_from_memory):
1295 Return tsize_t, not size_t, since that's what the TIFF API wants.
1296 (tiff_read_from_memory): Don't fail simply because the read would
1297 go past EOF; instead, return a short read.
1298 (tiff_load): Omit no-longer-needed casts.
1299 (Fimagemagick_types): Don't assume size fits into 'int'.
1300
3cc5a532
PE
1301 Improve hashing quality when configured --with-wide-int.
1302 * fns.c (hash_string): New function, taken from sxhash_string.
1303 Do not discard information about ASCII character case; this
1304 discarding is no longer needed.
1305 (sxhash-string): Use it. Change sig to match it. Caller changed.
1306 * lisp.h: Declare it.
1307 * lread.c (hash_string): Remove, since we now use fns.c's version.
1308 The fns.c version returns a wider integer if --with-wide-int is
1309 specified, so this should help the quality of the hashing a bit.
1310
b312a492
PE
1311 * emacs.c: Integer overflow minor fix.
1312 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1313 Define only if GNU_LINUX.
1314 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1315
dfd153ae
PE
1316 * dispnew.c: Integer signedness and overflow fixes.
1317 Remove unnecessary forward decls, that were a maintenance hassle.
1318 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1319 All uses changed.
1320 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1321 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1322 (prepare_desired_row, line_draw_cost):
1323 Use int, not unsigned, where either works.
1324 (save_current_matrix, restore_current_matrix):
1325 Use ptrdiff_t, not size_t, where either works.
1326 (init_display): Check for overflow more accurately, and without
1327 relying on undefined behavior.
1328
a81d11a3
PE
1329 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1330 Remove, replacing with the new symbols in lisp.h. All uses changed.
1331 * fileio.c (make_temp_name):
1332 * filelock.c (lock_file_1, lock_file):
1333 * xdisp.c (message_dolog):
1334 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1335 Use pMd etc. instead.
1336 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1337 replacing the pWIDE etc. symbols removed from editfns.c.
1338
3300e6fd
PE
1339 * keyboard.h (num_input_events): Now uintmax_t.
1340 This is (very slightly) less likely to mess up due to wraparound.
1341 All uses changed.
1342
fd05c7e9
PE
1343 * buffer.c: Integer signedness fixes.
1344 (alloc_buffer_text, enlarge_buffer_text):
1345 Use ptrdiff_t rather than size_t when either will do, as we prefer
1346 signed integers.
1347
903fe15d
PE
1348 * alloc.c: Integer signedness and overflow fixes.
1349 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1350 (__malloc_size_t): Default to size_t, not to int.
1351 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1352 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1353 Prefer ptrdiff_t to size_t when either would do, as we prefer
1354 signed integers.
1355 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1356 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1357 Now const. Initialize with values that are in range even if char
1358 is signed.
1359 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1360 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1361 These functions do the right thing with sizes > 2**32.
1362 (check_depth): Now ptrdiff_t, not int.
1363 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1364 Adjust to new way of storing sizes. Check for size overflow bugs
1365 in rest of code.
1366 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1367 slightly wrong anyway, as it missed one instance of
1368 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1369 (refill_memory_reserve): Omit needless cast to size_t.
1370 (mark_object_loop_halt): Mark as externally visible.
1371
ac82cc6a
PE
1372 * xselect.c: Integer signedness and overflow fixes.
1373 (Fx_register_dnd_atom, x_handle_dnd_message):
1374 Use ptrdiff_t, not size_t, since we prefer signed.
1375 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1376 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1377 x_dnd_atoms_size and x_dnd_atoms_length.
1378
c2d1e36d
PE
1379 * doprnt.c: Prefer signed to unsigned when either works.
1380 * eval.c (verror):
1381 * doprnt.c (doprnt):
1382 * lisp.h (doprnt):
1383 * xdisp.c (vmessage):
1384 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1385 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1386 prefer signed arithmetic to avoid comparison confusion.
1387 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1388 but is a bit tricky.
1389
0e926e56
PE
1390 Assume freestanding C89 headers, string.h, stdlib.h.
1391 * data.c, doprnt.c, floatfns.c, print.c:
1392 Include float.h unconditionally.
1393 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1394 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1395 * regex.c: Likewise for stddef.h, string.h.
1396 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1397 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1398 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1399 (STDC_HEADERS): Remove obsolete defines.
1400 * sysdep.c: Include limits.h unconditionally.
1401
9cfdb3ec
PE
1402 Assume support for memcmp, memcpy, memmove, memset.
1403 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1404 * regex.c (memcmp, memcpy):
1405 Remove; we assume C89 now.
1406
1407 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1408 (__malloc_safe_bcopy): Remove; no longer needed.
1409
cf950e6b 1410 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1411 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1412 well either way, and we prefer signed to unsigned.
1413
dbf38e02
LMI
14142011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1415
1416 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1417 closes the connection while we're reading (bug#9182).
1418
d6f0886c 14192011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1420
d6f0886c
JD
1421 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1422 are specified (Bug#9168).
24e0f6b1 1423
2eb1f9e6
PE
14242011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1427 Found by GCC static checking and --with-wide-int on a 32-bit host.
1428
22381272 14292011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1430
1431 * xdisp.c (compute_display_string_pos): Fix logic of caching
1432 previous display string position. Initialize cached_prev_pos to
1433 -1. Fixes slow-down at the beginning of a buffer.
1434
f25e39b4
EZ
14352011-07-24 Eli Zaretskii <eliz@gnu.org>
1436
1437 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1438 for attrs[LFACE_FONTSET_INDEX].
1439
04c4b52e
PE
14402011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 * xml.c (parse_region): Remove unused local
1443 that was recently introduced.
1444
c1734fbd
EZ
14452011-07-23 Eli Zaretskii <eliz@gnu.org>
1446
be18c5a5
EZ
1447 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1448 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1449
c1734fbd
EZ
1450 * xdisp.c (move_it_in_display_line_to): Record the best matching
1451 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1452 exit if none of the characters scanned was an exact match.
1453 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1454 when exact match is impossible due to invisible text, and the
1455 lines are truncated.
1456
a258d627
JD
14572011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1458
1459 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1460 for OSX >= 10.7.
1461
b6d5a689
EZ
14622011-07-22 Eli Zaretskii <eliz@gnu.org>
1463
0f74f785
EZ
1464 Fix a significant slow-down of cursor motion with C-n, C-p,
1465 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1466 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1467 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1468 (next_element_from_buffer): Call compute_stop_pos_backwards to
1469 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1470 base_level_stop.
1471 (reseat): Don't look for prev_stop, as that could mean a very long
1472 run.
1473 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1474 <cached_disp_overlay_modiff>: Cache for last found display string
1475 position.
551918c1 1476 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1477 about the same buffer in the same area of character positions, and
1478 the buffer wasn't changed since the time the display string
1479 position was cached.
551918c1 1480
b2d0c91a
EZ
14812011-07-22 Eli Zaretskii <eliz@gnu.org>
1482
1483 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1484 is an integer, which is important for empty lines. (Bug#9149)
1485
043604ee
CY
14862011-07-22 Chong Yidong <cyd@stupidchicken.com>
1487
1488 * frame.c (Fmodify_frame_parameters): In tty case, update the
1489 default face if necessary (Bug#4238).
1490
da4adb04
CY
14912011-07-21 Chong Yidong <cyd@stupidchicken.com>
1492
1493 * editfns.c (Fstring_to_char): No need to explain what a character
1494 is in the docstring (Bug#6576).
1495
9abd0532
LMI
14962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1497
1498 * xml.c (parse_region): Make sure we always return a tree.
1499
36881d16
HK
15002011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1501
1502 * xml.c (parse_region): If a document contains only comments,
1503 return that, too.
1504
1e98674d
LMI
15052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1506
1507 * xml.c (make_dom): Return comments, too.
1508
590bd467
PE
15092011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1510
1511 Port to OpenBSD.
1512 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1513 and the surrounding thread.
1514 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1515 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1516 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1517 timer goes off.
1518 * s/openbsd.h (BROKEN_SIGIO): Define.
1519 * unexelf.c (unexec) [__OpenBSD__]:
1520 Don't update the .mdebug section of the Alpha COFF symbol table.
1521
f41628b2
LMI
15222011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1523
1524 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1525 (bug#8460).
1526
b59b67c5
PE
15272011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1528
15e3a074
PE
1529 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1530 This fixes some race conditions on the permissions of any newly
1531 created file.
1532
41bed37d
PE
1533 * alloc.c (valid_pointer_p): Use pipe, not open.
1534 This fixes some permissions issues when debugging.
1535
b59b67c5
PE
1536 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1537 If fchown fails to set both uid and gid, try to set just gid,
1538 as that is sometimes allowed. Adjust the file's mode to eliminate
1539 setuid or setgid bits that are inappropriate if fchown fails.
1540
925a6be7
SM
15412011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1542
1543 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1544 to compare Lisp_Objects.
1545 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1546 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1547 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1548
52968808
AS
15492011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1550
0a6a104b
AS
1551 * lread.c (read_integer): Unread even EOF character.
1552 (read1): Likewise. Properly record start position of symbol.
1553
52968808
AS
1554 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1555 symbol character follows.
1556
9e381cdd
PE
15572011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1560 This works around a problem with the previous change to Fcopy_file.
1561 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1562 and without this change, GCC might complain about discarding
1563 fchown's return value.
1564
b5641435
JB
15652011-07-16 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1568
a8031457
PE
15692011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1572
dd889327
LMI
15732011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1574
750c33f7
LMI
1575 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1576 it's used from the C level.
1577
dd889327
LMI
1578 * process.c: Use the same condition for POLL_FOR_INPUT in both
1579 keyboard.c and process.c (bug#1858).
1580
87e86684
LM
15812011-07-09 Lawrence Mitchell <wence@gmx.li>
1582
1583 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1584 (Fgnutls_boot): Use it.
1585
64348f40
AS
15862011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1587
1588 * doc.c (Fsubstitute_command_keys): Revert last change.
1589
1d698799
LMI
15902011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1591
f863868c
LMI
1592 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1593 quotes the next character, and doesn't affect other longer
1594 sequences (bug#8935).
1595
1d698799
LMI
1596 * lread.c (syms_of_lread): Clarify that is isn't only
1597 `eval-buffer' and `eval-defun' that's affected by
1598 `lexical-binding' (bug#8460).
1599
aa4b6df6
EZ
16002011-07-15 Eli Zaretskii <eliz@gnu.org>
1601
1602 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1603 bidi redisplay when a line includes both an image and is
1604 truncated.
1605
5d856da6
PE
16062011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1607
ad6042bb
PE
1608 Fix minor problems found by static checking.
1609 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1610 (elsz): Now a signed constant, not a size_t var. We prefer signed
1611 types to unsigned, to avoid integer comparison confusion. Without
1612 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1613 "cannot optimize loop, the loop counter may overflow", a symptom
1614 of the confusion.
f00bbb22 1615 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1616 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1617
6468f31c
LMI
16182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1619
49080b10
LMI
1620 * search.c (Fre_search_backward): Mention `case-fold-search' in
1621 all the re_search_* functions (bug#8138).
1622
6468f31c
LMI
1623 * keyboard.c (Fopen_dribble_file): Document when the file is
1624 closed (bug#8056).
1625
c965adc5
EZ
16262011-07-14 Eli Zaretskii <eliz@gnu.org>
1627
df9733bf
EZ
1628 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1629 bidi_cache_idx.
1630
0bb23927
EZ
1631 Support bidi reordering of display and overlay strings.
1632 * xdisp.c (compute_display_string_pos)
1633 (compute_display_string_end): Accept additional argument STRING.
1634 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1635 (reseat_to_string): Initialize bidi_it->string.s and
1636 bidi_it->string.schars.
1637 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1638 NULL (avoids a crash in bidi_paragraph_init).
1639 Initialize itb.string.lstring.
0bb23927
EZ
1640 (init_iterator): Call bidi_init_it only of a valid
1641 buffer position was specified. Initialize paragraph_embedding to
1642 L2R.
1643 (reseat_to_string): Initialize the bidi iterator.
1644 (display_string): If we need to ignore text properties of
1645 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1646 original value of -1 will not work with bidi.)
1647 (compute_display_string_pos): First arg is now struct
1648 `text_pos *'; all callers changed. Support display properties on
1649 Lisp strings.
1650 (compute_display_string_end): Support display properties on Lisp
1651 strings.
1652 (init_iterator, reseat_1, reseat_to_string): Initialize the
1653 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1654 when iterating on a string not from display properties).
640c8776
SM
1655 (compute_display_string_pos, compute_display_string_end):
1656 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1657 arrow keys.
1658 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1659 base_level_stop; instead, set base_level_stop to BEGV.
1660 Fixes crashes in vertical-motion.
0bb23927
EZ
1661 (next_element_from_buffer): Improve commentary for when
1662 the iterator is before prev_stop.
1663 (init_iterator): Initialize bidi_p from the default value of
1664 bidi-display-reordering, not from buffer-local value. Use the
1665 buffer-local value only if initializing for buffer iteration.
1666 (handle_invisible_prop): Support invisible properties on strings
1667 that are being bidi-reordered.
1668 (set_iterator_to_next): Support bidi reordering of C strings and
1669 Lisp strings.
1670 (next_element_from_string): Support bidi reordering of Lisp
1671 strings.
1672 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1673 (display_string): Support display of R2L glyph rows.
1674 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1675 (init_iterator): Don't initialize it->bidi_p for strings
1676 here.
1677 (reseat_to_string): Initialize it->bidi_p for strings here.
1678 (next_element_from_string, next_element_from_c_string)
1679 (next_element_from_buffer): Add xassert's for correspondence
1680 between IT's object being iterated and it->bidi_it.string
1681 structure.
1682 (face_before_or_after_it_pos): Support bidi iteration.
1683 (next_element_from_c_string): Handle the case of the first string
1684 character that is not the first one in the visual order.
1685 (get_visually_first_element): New function, refactored from common
1686 parts of next_element_from_buffer, next_element_from_string, and
1687 next_element_from_c_string.
1688 (tool_bar_lines_needed, redisplay_tool_bar)
1689 (display_menu_bar): Force left-to-right direction. Add a FIXME
1690 comment for making that be controlled by a user option.
1691 (push_it, pop_it): Save and restore the state of the
1692 bidi iterator. Save and restore the bidi_p flag.
1693 (pop_it): Iterate out of display property for string iteration as
1694 well.
1695 (iterate_out_of_display_property): Support iteration over strings.
1696 (handle_single_display_spec): Set up it->bidi_it for iteration
1697 over a display string, and call bidi_init_it.
1698 (handle_single_display_spec, next_overlay_string)
1699 (get_overlay_strings_1, push_display_prop): Set up the bidi
1700 iterator for displaying display or overlay strings.
1701 (forward_to_next_line_start): Don't use the shortcut if
1702 bidi-iterating.
1703 (back_to_previous_visible_line_start): If handle_display_prop
1704 pushed the iterator stack, restore the internal state of the bidi
1705 iterator by calling bidi_pop_it same number of times.
1706 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1707 and we are bidi-iterating, don't decrement the iterator position;
1708 instead, set the first_elt flag in the bidi iterator, to produce
1709 the same effect.
1710 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1711 (push_display_prop): xassert that we are iterating a buffer.
1712 (push_it, pop_it): Save and restore paragraph_embedding member.
1713 (handle_single_display_spec, next_overlay_string)
1714 (get_overlay_strings_1, reseat_1, reseat_to_string)
1715 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1716 correctly. Don't assume unibyte strings are not bidi-reordered.
1717 (compute_display_string_pos)
1718 (compute_display_string_end): Fix handling the case of C string.
1719 (push_it, pop_it): Save and restore from_disp_prop_p.
1720 (handle_single_display_spec, push_display_prop): Set the
1721 from_disp_prop_p flag.
1722 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1723 (pop_it): Call iterate_out_of_display_property only if we are
1724 popping after iteration over a string that came from a display
1725 property. Fix a typo in popping stretch info. Add an assertion
1726 for verifying that the iterator position is in sync with the bidi
1727 iterator.
1728 (handle_single_display_spec, get_overlay_strings_1)
1729 (push_display_prop): Fix initialization of paragraph direction for
1730 string when that of the parent object is not yet determined.
1731 (reseat_1): Call bidi_init_it to resync the bidi
1732 iterator with IT's position. (Bug#7616)
1733 (find_row_edges): If ROW->start.pos gives position
1734 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1735 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1736 Reset the from_disp_prop_p flag.
1737 (SAVE_IT, RESTORE_IT): New macros.
1738 (pos_visible_p, face_before_or_after_it_pos)
1739 (back_to_previous_visible_line_start)
1740 (move_it_in_display_line_to, move_it_in_display_line)
1741 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1742 (try_scrolling, redisplay_window, display_line): Use them when
1743 saving a temporary copy of the iterator and restoring it back.
1744 (back_to_previous_visible_line_start, reseat_1)
1745 (init_iterator): Empty the bidi cache "stack".
1746 (move_it_in_display_line_to): If iterator ended up at
1747 EOL, but we never saw any buffer positions smaller than
1748 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1749 motion in bidi-reordered lines.
1750 (move_it_in_display_line_to): Record prev_method and prev_pos
1751 immediately before the call to set_iterator_to_next. Fixes cursor
1752 motion in bidi-reordered lines with stretch glyphs and strings
1753 displayed in margins. (Bug#8133) (Bug#8867)
1754 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1755 TO_CHARPOS.
640c8776
SM
1756 (pos_visible_p): Support positions in bidi-reordered lines.
1757 Save and restore bidi cache.
0bb23927
EZ
1758
1759 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1760 (bidi_paragraph_info): Delete unused struct.
1761 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1762 (bidi_cache_start): New variable.
1763 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1764 to zero.
1765 (bidi_cache_fetch_state, bidi_cache_search)
1766 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1767 (bidi_cache_find, bidi_peek_at_next_level)
1768 (bidi_level_of_next_char, bidi_find_other_level_edge)
1769 (bidi_move_to_visually_next): Compare cache index with
1770 bidi_cache_start rather than with zero.
1771 (bidi_fetch_char): Accept new argument STRING; all callers
1772 changed. Support iteration over a string. Support strings with
1773 display properties. Support unibyte strings. Fix the type of
1774 `len' according to what STRING_CHAR_AND_LENGTH expects.
1775 (bidi_paragraph_init, bidi_resolve_explicit_1)
1776 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1777 (bidi_level_of_next_char, bidi_move_to_visually_next):
1778 Support iteration over a string.
0bb23927
EZ
1779 (bidi_set_sor_type, bidi_resolve_explicit_1)
1780 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1781 can now be zero (for strings); special values 0 and -1 were
1782 changed to -1 and -2, respectively.
1783 (bidi_char_at_pos): New function.
1784 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1785 Call it instead of FETCH_MULTIBYTE_CHAR.
1786 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1787 initialized to valid values.
1788 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1789 values.
1790 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1791 the test for valid cached positions. Fix the logic for looking up
1792 the sentinel state in the cache. GCPRO the Lisp string we are
1793 iterating.
1794 (bidi_push_it, bidi_pop_it): New functions.
1795 (bidi_initialize): Initialize the bidi cache start stack pointer.
1796 (bidi_cache_ensure_space): New function, refactored from part of
1797 bidi_cache_iterator_state. Don't assume the required size is just
1798 one BIDI_CACHE_CHUNK away.
1799 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1800 (bidi_count_bytes, bidi_char_at_pos): New functions.
1801 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1802 always valid if bidi_cache_idx is valid.
1803 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1804 is valid if it's going to be used.
1805 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1806 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1807 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1808 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1809 (bidi_find_other_level_edge, bidi_cache_start_stack):
1810 All variables related to cache indices are now EMACS_INT.
c965adc5 1811
0bb23927
EZ
1812 * dispextern.h (struct bidi_string_data): New structure.
1813 (struct bidi_it): New member `string'. Make flag members be 1-bit
1814 fields, and put them last in the struct.
640c8776
SM
1815 (compute_display_string_pos, compute_display_string_end):
1816 Update prototypes.
0bb23927
EZ
1817 (bidi_push_it, bidi_pop_it): Add prototypes.
1818 (struct iterator_stack_entry): New members bidi_p,
1819 paragraph_embedding, and from_disp_prop_p.
1820 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1821 (bidi_shelve_cache, bidi_unshelve_cache):
1822 Declare prototypes.
0bb23927
EZ
1823
1824 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1825 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1826 and vector-like objects.
1827
1828 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1829 cache around display iteration.
1830
1831 * window.c (Fwindow_end, window_scroll_pixel_based)
1832 (displayed_window_lines, Frecenter): Save and restore the bidi
1833 cache around display iteration.
1834
3bbd2265
LMI
18352011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1836
1837 * editfns.c (Fdelete_region): Clarify the use of the named
1838 parameters (bug#6788).
1839
adc47434
MR
18402011-07-14 Martin Rudalics <rudalics@gmx.at>
1841
1842 * indent.c (Fvertical_motion): Set and restore w->pointm when
1843 saving and restoring the window's buffer (Bug#9006).
1844
837c31f8
LMI
18452011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1846
1847 * editfns.c (Fstring_to_char): Clarify just what is returned
1848 (bug#6576). Text by Eli Zaretskii.
1849
ac389d0c
JB
18502011-07-13 Juanma Barranquero <lekktu@gmail.com>
1851
1852 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1853
0be0ce47
EZ
18542011-07-13 Eli Zaretskii <eliz@gnu.org>
1855
1856 * buffer.c (mmap_find): Fix a typo.
1857
cd18e7e3
JB
18582011-07-13 Johan Bockgård <bojohan@gnu.org>
1859
1860 Fix execution of x selection hooks.
1861 * xselect.c (Qx_lost_selection_functions)
1862 (Qx_sent_selection_functions): New vars.
1863 (syms_of_xselect): DEFSYM them.
1864 (x_handle_selection_request): Pass Qx_sent_selection_functions
1865 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1866 (x_handle_selection_clear,x_clear_frame_selections):
1867 Pass Qx_lost_selection_functions rather than
1868 Vx_lost_selection_functions to Frun_hook_with_args.
1869
47ea7f44
PE
18702011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1871
ac389d0c 1872 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1873 The old code sometimes used this field without initializing it.
1874
47ea7f44
PE
1875 * alloc.c (gc_sweep): Don't read past end of array.
1876 In theory, the old code could also have corrupted Emacs internals,
1877 though it'd be very unlikely.
1878
bc985c87
AS
18792011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1882 argument. (Bug#4026)
bc985c87 1883
0cf34688
LMI
18842011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1885
b3dadd76
LMI
1886 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1887 key" (bug#4257).
1888
0cf34688
LMI
1889 * window.c (Fset_window_start): Doc fix (bug#4199).
1890 (Fset_window_hscroll): Ditto.
1891
270768cd
PE
18922011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1893
077e3dda 1894 Fix minor new problems caught by GCC 4.6.1.
270768cd 1895 * term.c (init_tty): Remove unused local.
490011a6 1896 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1897 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1898 not used otherwise.
270768cd 1899
b1f58454
CY
19002011-07-12 Chong Yidong <cyd@stupidchicken.com>
1901
1902 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1903
22b9578d
LMI
19042011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1905
6e70ab07
LMI
1906 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1907 are the mini-buffer and the echo area (bug#3320).
1908
22b9578d
LMI
1909 * term.c (init_tty): Remove support for supdup, c10 and perq
1910 terminals, which are no longer supported (bug#1482).
1911
8974cc9f
JB
19122011-07-10 Johan Bockgård <bojohan@gnu.org>
1913
1914 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1915
a560d974
JD
19162011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1917
1918 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1919 for non-popups (Bug#3642).
1920
1dae0f0a
AS
19212011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1922
268c2c36 1923 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1924 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1925 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1926 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1927 * data.c (fmod): Likewise.
1928 * dispnew.c (swap_glyphs_in_rows): Likewise.
1929 * emacs.c (memory_warning_signal): Likewise.
1930 * floatfns.c (float_error): Likewise.
1931 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1932 (otf_open, font_otf_capability, generate_otf_features)
1933 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1934 Likewise.
1935 * image.c (pbm_read_file): Likewise.
1936 * indent.c (string_display_width): Likewise.
1937 * intervals.c (check_for_interval, search_for_interval)
1938 (inc_interval_count, count_intervals, root_interval)
1939 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1940 * lread.c (defalias): Likewise.
268c2c36 1941 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1942 * regex.c (set_image_of_range_1, set_image_of_range)
1943 (regex_grow_registers): Likewise.
1944 * sysdep.c (strerror): Likewise.
1945 * termcap.c (valid_filename_p, tprint, main): Likewise.
1946 * tparam.c (main): Likewise.
1947 * unexhp9k800.c (run_time_remap, save_data_space)
1948 (update_file_ptrs, read_header, write_header, calculate_checksum)
1949 (copy_file, copy_rest, display_header): Likewise.
1950 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1951 Likewise.
1952 * xdisp.c (check_it): Likewise.
1953 * xfaces.c (register_color, unregister_color, unregister_colors):
1954 Likewise.
1955 * xfns.c (print_fontset_result): Likewise.
1956 * xrdb.c (member, fatal, main): Likewise.
1957
99033785
PE
19582011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1959
1960 Fix minor problems found by static checking (Bug#9031).
1961 * chartab.c (char_table_set_range, map_sub_char_table):
1962 Remove unused locals.
1963 (uniprop_table): Now static.
1964 * composite.c (_work_char): Remove unused static var.
1965
9cb2ac56
JB
19662011-07-09 Juanma Barranquero <lekktu@gmail.com>
1967
1968 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1969
f25661f0
JD
19702011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1971
1972 * gtkutil.c (qttip_cb): Remove code without function.
1973
8278c4fe
EZ
19742011-07-09 Eli Zaretskii <eliz@gnu.org>
1975
1976 * w32.c (pthread_sigmask): New stub.
1977
1692ae2d 19782011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1979
8a6ebd58 1980 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1981 sigprocmask is portable only for single-threaded applications, and
1982 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1983 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1984 (LIBES): Use it.
1985 * callproc.c (Fcall_process):
1986 * process.c (create_process):
1987 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1988 Use pthread_sigmask, not sigprocmask.
123403e4 1989
1b854618
JD
19902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1991
1992 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1993 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1994 wrong (Bug#8591).
1995
3fe4b549
JD
19962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1997
0ce7e563
JD
1998 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1999 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2000 (xg_hide_tooltip): Fix comment.
2001
3fe4b549
JD
2002 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2003 in registerServicesMenuSendTypes.
2004 (validRequestorForSendType): Don't check ns_return_types.
2005
2006 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2007 ns_return_type.
2008
5df75e47
JR
20092011-07-08 Jason Rumney <jasonr@gnu.org>
2010
2011 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2012 frame struct members of non-existent frames (Bug#6284).
2013
699c10bd
JD
20142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2015
4393663b
JD
2016 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2017 variable firstTime not needed on OSX >= 10.6.
2018 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2019 >= 10.5. Use setKnobProportion, setDoubleValue.
2020
2021 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2022 (MAC_OS_X_VERSION_10_5): Define if not defined.
2023 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2024 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2025 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2026
2027 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2028 cString and lossyCString on OSX >= 10.4
2029
2030 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2031 sizeToFit on OSX >= 10.2.
2032
2033 * nsimage.m (allocInitFromFile): Don't use deprecated method
2034 bestRepresentationForDevice on OSX >= 10.6.
2035
2036 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2037 to avoid warning.
2038
2039 * emacs.c: Declare unexec_init_emacs_zone.
2040
a63e0781
JD
2041 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2042
699c10bd
JD
2043 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2044
2045 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2046 on svcsMenu (Bug#8842).
2047
2048 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2049 ns_return_types.
2050 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2051
2052 * nsterm.m (QUTF8_STRING): Declare.
2053 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2054 (validRequestorForSendType): Return type is (id).
2055 Change indexOfObjectIdenticalTo to indexOfObject.
2056 Check if we have local selection before returning self (Bug#8842).
2057 (writeSelectionToPasteboard): Put local selection into paste board
2058 if we have a local selection (Bug#8842).
2059 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2060
2061 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2062 (ns_get_local_selection): Declare.
2063
54e10184
LMI
20642011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2065
9888ff71
LMI
2066 * keymap.c (describe_map_tree): Don't insert a double newline at
2067 the end of the buffer (bug#1169) and return whether we inserted
2068 something.
2069
54e10184
LMI
2070 * callint.c (Fcall_interactively): Change "reading args" to
2071 "providing args" to try to clarify what it does (bug#1010).
2072
15fa4783
KH
20732011-07-07 Kenichi Handa <handa@m17n.org>
2074
2075 * composite.c (composition_compute_stop_pos): Ignore a static
2076 composition starting before CHARPOS (Bug#8915).
2077
2078 * xdisp.c (handle_composition_prop): Likewise.
2079
a8815b00
EZ
20802011-07-07 Eli Zaretskii <eliz@gnu.org>
2081
2082 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2083 (Bug#9015)
2084
ef7b981d 20852011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2086
2087 * character.h (unicode_category_t): New enum type.
2088
2089 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2090 (Qchar_code_property_table): New variable.
2091 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2092 (UNIPROP_COMPRESSED_FORM_P): New macros.
2093 (char_table_ascii): Uncompress the compressed values.
2094 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2095 Uncompress the compressed values.
ac389d0c 2096 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2097 (char_table_ref_and_range): Uncompress the compressed values.
2098 (sub_char_table_set): New arg is_uniprop. Callers changed.
2099 Uncompress the compressed values.
2100 (sub_char_table_set_range): Args changed. Callers changed.
2101 (char_table_set_range): Adjuted for the above change.
2102 (map_sub_char_table): Delete args default_val and parent. Add arg
2103 top. Give decoded values to a Lisp function.
640c8776 2104 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2105 values to a Lisp function. Gcpro more variables.
2106 (uniprop_table_uncompress)
2107 (uniprop_decode_value_run_length): New functions.
2108 (uniprop_decoder, uniprop_decoder_count): New variables.
2109 (uniprop_get_decoder, uniprop_encode_value_character)
2110 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2111 New functions.
2112 (uniprop_encoder, uniprop_encoder_count): New variables.
2113 (uniprop_get_encoder, uniprop_table)
2114 (Funicode_property_table_internal, Fget_unicode_property_internal)
2115 (Fput_unicode_property_internal): New functions.
2116 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2117 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2118 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2119 char-code-property-alist.
2120
640c8776 2121 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2122 Vunicode_category_table.
2123
640c8776 2124 * font.c (font_range): Adjust for the change of
c805dec0
KH
2125 Vunicode_category_table.
2126
76b397fb
DN
21272011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2128
2129 * m/iris4d.h: Remove file, move contents ...
2130 * s/irix6-5.h: ... here.
2131
22b4128e
PE
21322011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2135 * alloc.c (mark_buffer):
2136 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2137 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2138 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2139 This isn't true in general, and it's particularly not true
2140 if Emacs is configured with --with-wide-int.
2141 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2142 New macros, used in the buffer.c change.
2143
869795d6
JD
21442011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2145
2146 * xsettings.c: Use both GConf and GSettings if both are available.
2147 (store_config_changed_event): Add comment.
2148 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2149 (store_tool_bar_style_changed): New functions.
5e617bc2 2150 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2151 (struct xsettings): Move font inside HAVE_XFT.
2152 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2153 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2154 Move inside HAVE_XFT.
640c8776 2155 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2156 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2157 also.
2158 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2159 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2160 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2161 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2162 (parse_settings): Move check for font inside HAVE_XFT.
2163 (read_settings, apply_xft_settings): Add comment.
2164 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2165 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2166 call store_font_name_changed.
2167 (xft_settings_event): Add comment.
2168 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2169 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2170 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2171 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2172 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2173 (xsettings_get_system_font, xsettings_get_system_normal_font):
2174 Add comment.
869795d6 2175
d8ed26bd
PE
21762011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 Random fixes. E.g., (random) never returned negative values.
2179 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2180 subseconds part to the entropy, as that's a bit more random.
2181 Prefer signed to unsigned, since the signedness doesn't matter and
2182 in general we prefer signed. When given a limit, use a
2183 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2184 latter isn't right if USE_2_TAGS_FOR_INTS.
2185 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2186 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2187
cabf1cac
SM
21882011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2189
2190 * textprop.c (text_property_stickiness):
2191 Obey Vtext_property_default_nonsticky.
2192 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2193 * w32fns.c (syms_of_w32fns):
2194 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2195
6e9b2be9
PE
21962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2197
2198 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2199 This is more efficient than Ffile_directory_p and avoids a minor race.
2200
90186c68
LMI
22012011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2202
7c301272
LMI
2203 * buffer.c (Foverlay_put): Say what the return value is
2204 (bug#7835).
2205
c4f2d8d4
LMI
2206 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2207 is a directory before asking whether to use the file name
2208 (bug#7564).
ad637907
LMI
2209 (barf_or_query_if_file_exists): Make the "File is a directory"
2210 error be more correct.
c4f2d8d4 2211
90186c68
LMI
2212 * fns.c (Frequire): Remove the mention of the .gz files, since
2213 that's installation-specific, but keep the mention of
2214 `get-load-suffixes'.
2215
da64016e
PE
22162011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2219 Report string overflow if the output is too long.
2220
7d47b580
JB
22212011-07-04 Juanma Barranquero <lekktu@gmail.com>
2222
a555cb87
JB
2223 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2224 (syms_of_gnutls): Remove duplicate DEFSYM for
2225 Qgnutls_bootprop_verify_hostname_error, an error for
2226 Qgnutls_bootprop_verify_error (which is no longer used).
2227
7d47b580
JB
2228 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2229 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2230 Also (re)move comments that are misplaced or no longer relevant.
2231
1e49bfab
LMI
22322011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2233
2234 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2235
1485f4c0
CY
22362011-07-03 Chong Yidong <cyd@stupidchicken.com>
2237
2238 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2239 and background color parameters if they have been changed.
2240
a9ab721e
LMI
22412011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2242
2243 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2244
cf7cff57
PE
22452011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2246
2e13213d
PE
2247 * xsettings.c (SYSTEM_FONT): Define only when used.
2248 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2249
cf7cff57
PE
2250 * keymap.c (access_keymap_1): Now static.
2251
7a8e04f7
CY
22522011-07-02 Chong Yidong <cyd@stupidchicken.com>
2253
2254 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2255 leave any prefix arg for the up event (Bug#1586).
2256
61352f62
LMI
22572011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2258
69bb1ef7
LMI
2259 * lread.c (syms_of_lread): Mention single symbols defined by
2260 `defvar' or `defconst' (bug#7154).
2261
61352f62 2262 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2263 (Frequire): Mention get-load-suffixes.
61352f62 2264
28545e04
MR
22652011-07-02 Martin Rudalics <rudalics@gmx.at>
2266
2267 * window.h (window): Remove clone_number slot.
2268 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2269 Remove.
2270 (make_parent_window, make_window, saved_window)
2271 (Fset_window_configuration, save_window_save): Don't deal with
2272 clone numbers.
2273 * buffer.c (Qclone_number): Remove declaration.
2274 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2275
3349e122
SM
22762011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2277
2278 Add multiple inheritance to keymaps.
2279 * keymap.c (Fmake_composed_keymap): New function.
2280 (Fset_keymap_parent): Simplify.
2281 (fix_submap_inheritance): Remove.
2282 (access_keymap_1): New function extracted from access_keymap to handle
2283 embedded parents and handle lists of maps.
2284 (access_keymap): Use it.
2285 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2286 (Fcopy_keymap): Handle embedded parents.
2287 (Fcommand_remapping, define_as_prefix): Simplify.
2288 (Fkey_binding): Simplify.
2289 (syms_of_keymap): Move minibuffer-local-completion-map,
2290 minibuffer-local-filename-completion-map,
2291 minibuffer-local-must-match-map, and
2292 minibuffer-local-filename-must-match-map to Elisp.
2293 (syms_of_keymap): Defsubr make-composed-keymap.
2294 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2295 (parse_menu_item): Trivial simplification.
2296
3279eb87
GM
22972011-07-01 Glenn Morris <rgm@gnu.org>
2298
2299 * Makefile.in (SETTINGS_LIBS): Fix typo.
2300
4550efdf
KI
23012011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2302
2303 * coding.c (Fencode_coding_string): Record the last coding system
2304 used, as the function doc string says (bug#8738).
2305
0949d2b6
JD
23062011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2307
2308 * xsettings.c (store_monospaced_changed): Take new font as arg and
2309 check for change against current_mono_font.
2310 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2311 (emacs_settings_constructor, emacs_settings_get_property)
2312 (emacs_settings_set_property, emacs_settings_class_init)
2313 (emacs_settings_init, gsettings_obj): Remove.
2314 (something_changedCB): New function for HAVE_GSETTINGS.
2315 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2316 with value as argument.
2317 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2318 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2319 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2320 "changed".
2321
2322 * xgselect.c: Add defined (HAVE_GSETTINGS).
2323 (xgselect_initialize): Ditto.
2324
2325 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2326 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2327 xg_select.
2328
bbc6b304
PE
23292011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 * eval.c (struct backtrace): Simplify and port the data structure.
2332 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2333 signed bit field, as this assumption is not portable and it makes
2334 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2335 "char debug_on_exit : 1" as this is not portable either; instead,
2336 use the portable "unsigned int debug_on_exit : 1". Remove unused
2337 member evalargs. Remove obsolete comments about cc bombing out.
2338
9851bfc5
JD
23392011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2340
51bb811f 2341 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2342 Let HAVE_GSETTINGS override HAVE_GCONF.
2343 (store_monospaced_changed): New function.
2344 (EMACS_SETTINGS): A new type derived from GObject to handle
2345 GSettings notifications.
2346 (emacs_settings_constructor, emacs_settings_get_property)
2347 (emacs_settings_set_property, emacs_settings_class_init):
2348 New functions.
2349 (gsettings_client, gsettings_obj): New variables.
2350 (GSETTINGS_SCHEMA): New define.
2351 (something_changedCB): Call store_monospaced_changed.
2352 (init_gsettings): New function.
2353 (xsettings_initialize): Call init_gsettings.
2354 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2355 to NULL.
2356
640c8776 2357 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2358 GCONF_CFLAGS/LIBS.
2359
5386012d
MR
23602011-06-29 Martin Rudalics <rudalics@gmx.at>
2361
2362 * window.c (resize_root_window, grow_mini_window)
2363 (shrink_mini_window): Rename Qresize_root_window to
2364 Qwindow_resize_root_window and Qresize_root_window_vertically to
2365 Qwindow_resize_root_window_vertically.
2366
f13e0b08
PE
23672011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2368
2369 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2370
94515237
JB
23712011-06-27 Juanma Barranquero <lekktu@gmail.com>
2372
2373 * makefile.w32-in: Redesign dependencies so they reflect more
2374 clearly which files are directly included by each source file,
2375 and not through other includes.
2376
e43b6e43
MR
23772011-06-27 Martin Rudalics <rudalics@gmx.at>
2378
2379 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2380 (sort_overlays, overlay_strings): When an overlay's clone number
2381 matches the window's clone number process the overlay even if
2382 the overlay's window property doesn't match the current window.
2383
d68443dc
MR
2384 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2385 (Fwindow_hchild): Rename to Fwindow_left_child.
2386 (Fwindow_next): Rename to Fwindow_next_sibling.
2387 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2388 (resize_window_check): Rename to window_resize_check.
2389 (resize_window_apply): Rename to window_resize_apply.
2390 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2391 (Fdelete_other_windows_internal, resize_frame_windows)
2392 (Fsplit_window_internal, Fdelete_window_internal)
2393 (grow_mini_window, shrink_mini_window)
2394 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2395
c7e73be5
JD
23962011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2397
2398 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2399 (emacs_fixed_set_min_size): Remove.
2400 (emacs_fixed_new): Take frame as argument.
2401
2402 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2403 (_EmacsFixedPrivate): Remove minwidth/height.
2404 Add struct frame *f.
2405 (emacs_fixed_init): Initialize priv->f.
2406 (get_parent_class, emacs_fixed_set_min_size): Remove.
2407 (emacs_fixed_new): Set priv->f to argument.
2408 (emacs_fixed_get_preferred_width)
2409 (emacs_fixed_get_preferred_height): Use min_width/height from
2410 frames size_hint to set minimum and natural (Bug#8919).
2411 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2412 and use min_width/height from frames size_hint to set
2413 min_width/height (Bug#8919).
2414
2415 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2416 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2417 Fix indentation.
c7e73be5 2418
cf99dcf8
EZ
24192011-06-26 Eli Zaretskii <eliz@gnu.org>
2420
2421 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2422 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2423 called at ZV.
2424
029529ac
CY
24252011-06-26 Chong Yidong <cyd@stupidchicken.com>
2426
2427 * process.c (wait_reading_process_output): Bypass select if
2428 waiting for a cell while ignoring keyboard input, and input is
2429 pending. Suggested by Jan Djärv (Bug#8869).
2430
7a7ef429
PE
24312011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 Use gnulib's dup2 module instead of rolling our own.
2434 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2435
11fdef7d 24362011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2437
2438 * dispnew.c (scrolling_window): Before scrolling, turn off a
2439 mouse-highlight in the window being scrolled.
2440
cd3520a4
JB
24412011-06-24 Juanma Barranquero <lekktu@gmail.com>
2442
2443 Move DEFSYM to lisp.h and use everywhere.
2444
2445 * character.h (DEFSYM): Move declaration...
2446 * lisp.h (DEFSYM): ...here.
2447
2448 * gnutls.c:
2449 * minibuf.c:
2450 * w32menu.c:
2451 * w32proc.c:
2452 * w32select.c: Don't include character.h.
2453
2454 * alloc.c (syms_of_alloc):
2455 * buffer.c (syms_of_buffer):
2456 * bytecode.c (syms_of_bytecode):
2457 * callint.c (syms_of_callint):
2458 * casefiddle.c (syms_of_casefiddle):
2459 * casetab.c (init_casetab_once):
2460 * category.c (init_category_once, syms_of_category):
2461 * ccl.c (syms_of_ccl):
2462 * cmds.c (syms_of_cmds):
2463 * composite.c (syms_of_composite):
2464 * dbusbind.c (syms_of_dbusbind):
2465 * dired.c (syms_of_dired):
2466 * dispnew.c (syms_of_display):
2467 * doc.c (syms_of_doc):
2468 * editfns.c (syms_of_editfns):
2469 * emacs.c (syms_of_emacs):
2470 * eval.c (syms_of_eval):
2471 * fileio.c (syms_of_fileio):
2472 * fns.c (syms_of_fns):
2473 * frame.c (syms_of_frame):
2474 * fringe.c (syms_of_fringe):
2475 * insdel.c (syms_of_insdel):
2476 * keymap.c (syms_of_keymap):
2477 * lread.c (init_obarray, syms_of_lread):
2478 * macros.c (syms_of_macros):
2479 * msdos.c (syms_of_msdos):
2480 * print.c (syms_of_print):
2481 * process.c (syms_of_process):
2482 * search.c (syms_of_search):
2483 * sound.c (syms_of_sound):
2484 * syntax.c (init_syntax_once, syms_of_syntax):
2485 * terminal.c (syms_of_terminal):
2486 * textprop.c (syms_of_textprop):
2487 * undo.c (syms_of_undo):
2488 * w32.c (globals_of_w32):
2489 * window.c (syms_of_window):
2490 * xdisp.c (syms_of_xdisp):
2491 * xfaces.c (syms_of_xfaces):
2492 * xfns.c (syms_of_xfns):
2493 * xmenu.c (syms_of_xmenu):
2494 * xsettings.c (syms_of_xsettings):
2495 * xterm.c (syms_of_xterm): Use DEFSYM.
2496
4228cf16
TZ
24972011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2498
cd3520a4 2499 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2500
7fcccf1e
PE
25012011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2502
7efb4e0e
PE
2503 Integer and buffer overflow fixes (Bug#8873).
2504
ff5844ad
PE
2505 * print.c (printchar, strout): Check for string overflow.
2506 (PRINTPREPARE, printchar, strout):
2507 Don't set size unless allocation succeeds.
2508
90532f02
PE
2509 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2510 for sizes. Check for string overflow more accurately.
2511 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2512
6d84508d
PE
2513 * macros.c: Integer and buffer overflow fixes.
2514 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2515 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2516 Use ptrdiff_t, not int, for sizes.
2517 Don't increment bufsize until after realloc succeeds.
2518 Check for size-calculation overflow.
2519 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2520
437b2cb4
PE
2521 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2522
8b9ac8b4
PE
2523 * lread.c: Integer overflow fixes.
2524 (read_integer): Radix is now EMACS_INT, not int,
2525 to improve quality of diagnostics for out-of-range radices.
2526 Calculate buffer size correctly for out-of-range radices.
2527 (read1): Check for integer overflow in radices, and in
2528 read-circle numbers.
82cb60d3
PE
2529 (read_escape): Avoid int overflow.
2530 (Fload, openp, read_buffer_size, read1)
2531 (substitute_object_recurse, read_vector, read_list, map_obarray):
2532 Use ptrdiff_t, not int, for sizes.
2533 (read1): Use EMACS_INT, not int, for sizes.
20270765 2534 Check for size overflow.
8b9ac8b4 2535
7fcccf1e
PE
2536 * image.c (cache_image): Check for size arithmetic overflow.
2537
bfbbd7e7
PE
2538 * lread.c: Integer overflow issues.
2539 (saved_doc_string_size, saved_doc_string_length)
2540 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2541 Now ptrdiff_t, not int.
2542 (read1): Don't assume doc string length fits in int. Check for
2543 out-of-range doc string lengths.
2544 (read_list): Don't assume file position fits in int.
39019e54 2545 (read_escape): Check for hex character overflow.
bfbbd7e7 2546
4e323265
LL
25472011-06-22 Leo Liu <sdl.web@gmail.com>
2548
2549 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2550 Move to minibuffer.el.
2551
85fece3e
PE
25522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2553
20b84ce9 2554 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2555 The following patches are for when GLYPH_DEBUG && !XASSERT.
2556 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2557 * dispnew.c (flush_stdout):
2558 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2559 Mark as externally visible.
2560 * dispnew.c (check_window_matrix_pointers): Now static.
2561 * dispnew.c (window_to_frame_vpos):
2562 * xfns.c (unwind_create_frame):
2563 * xterm.c (x_check_font): Remove unused local.
2564 * scroll.c (CHECK_BOUNDS):
2565 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2566 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2567 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2568 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2569 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2570 Now static.
2571 (debug_method_add): Use va_list and vsprintf rather than relying
2572 on undefined behavior with wrong number of arguments.
2573 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2574 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2575 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2576 since we're not interested in debugging glyphs with old libraries.
2577 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2578 GCC 4.6.0's static checking.
2579
0766b489
PE
25802011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2581
31fd4b32
PE
2582 Integer overflow and signedness fixes (Bug#8873).
2583 A few related buffer overrun fixes, too.
2584
b79e8648
PE
2585 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2586
0766b489
PE
2587 * dispextern.h (struct face.stipple):
2588 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2589 (x_bitmap_mask, x_allocate_bitmap_record)
2590 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2591 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2592 (x_create_bitmap_from_xpm_data):
2593 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2594 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2595 (.bitmaps_last):
2596 * xfaces.c (load_pixmap):
2597 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2598 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2599 (.bitmaps_last, struct x_output.icon_bitmap):
2600 Use ptrdiff_t, not int, for bitmap indexes.
2601 (x_allocate_bitmap_record): Check for size overflow.
2602 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2603
b081724f
PE
2604 Use ptrdiff_t, not int, for overlay counts.
2605 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2606 * editfns.c (overlays_around, get_pos_property):
2607 * textprop.c (get_char_property_and_overlay):
2608 * xdisp.c (next_overlay_change, note_mouse_highlight):
2609 * xfaces.c (face_at_buffer_position):
21514da7
PE
2610 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2611 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2612 (Fnext_overlay_change, Fprevious_overlay_change)
2613 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2614 Use ptrdiff_t, not int, for sizes.
21514da7 2615 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2616
3de73e5e
PE
2617 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2618
2606c57b
PE
2619 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2620 (x_session_initialize): Do not assume string length fits in int.
2621
aaafe47a
PE
2622 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2623 This is unlikely, but can occur if DPI is outlandish.
2624
2674ddc8 2625 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2626 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2627
28154962
PE
2628 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2629 * xrdb.c (magic_file_p, search_magic_path):
2630 Omit last arg SUFFIX; it was always 0. All callers changed.
2631 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2632
7de51af5
PE
2633 * xfont.c (xfont_match): Avoid need for strlen.
2634
25ed6cc3
PE
2635 * xfns.c: Don't assume strlen fits in int.
2636 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2637
4eab31dd
PE
2638 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2639 not unsigned long, as we prefer signed integers. All callers changed.
2640 Detect integer overflow in repeat count.
2641 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2642 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2643
171e2a58
PE
2644 * termcap.c: Don't assume sizes fit in int and never overflow.
2645 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2646 (gobble_line): Check for size-calculation overflow.
2647
ad39faca 2648 * minibuf.c (Fread_buffer):
6e5bb2dc 2649 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2650 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2651 Don't assume string length fits in int.
2652
52c61c22 2653 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2654 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2655
b5b8c9e5
PE
2656 * font.c: Don't assume string length fits in int.
2657 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2658 Use ptrdiff_t, not int.
ccd6111c
PE
2659 (font_intern_prop): Don't assume string length fits in int.
2660 Don't assume integer property fits in fixnum.
2661 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2662
882f0d81 2663 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2664 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2665 Reformulate so as not to need the command string.
2666 Invoke gzip -cd rather than gunzip, as it's more portable.
2667 (lock_info_type, lock_file_1, lock_file):
2668 Don't assume pid_t and time_t fit in unsigned long.
2669 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2670 (current_lock_owner): Prefer signed type for sizes.
2671 Use memcpy, not strncpy, where memcpy is what is really wanted.
2672 Don't assume (via atoi) that time_t and pid_t fit in int.
2673 Check for time_t and/or pid_t out of range, e.g., via a network share.
2674 Don't alloca where an auto var works fine.
2675
93f4cf88
PE
2676 * fileio.c: Fix some integer overflow issues.
2677 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2678 Don't assume string length fits in int.
2679 (directory_file_name): Don't assume string length fits in long.
2680 (make_temp_name): Don't assume pid fits in int, or that its print
2681 length is less than 20.
2682
f3e92b69
PE
2683 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2684
1bfdaf10
PE
2685 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2686
35016e9a
PE
2687 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2688
3d1e65a1
PE
2689 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2690 We prefer signed integers, even for size calculations.
2691
0b963a93
PE
2692 * emacs.c: Don't assume string length fits in 'int'.
2693 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2694 (main): Don't invoke strlen when not needed.
2695
573f4b54
PE
2696 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2697 (XD_DEBUG_MESSAGE): Don't waste a byte.
2698
989f33ba
PE
2699 * callproc.c (getenv_internal_1, getenv_internal)
2700 (Fgetenv_internal):
965d34eb
PE
2701 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2702
e4d29b33
PE
2703 * lread.c (invalid_syntax): Omit length argument.
2704 All uses changed. This doesn't fix a bug, but it simplifies the
2705 code away from its former Hollerith-constant appearance, and it's
2706 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2707 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2708
eb49b136
PE
2709 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2710 This didn't break anything, but it didn't help either.
2711 It's confusing to put a bogus integer in a place where the actual
2712 value does not matter.
9f62aeb1 2713 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2714 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2715
15375a22
PE
2716 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2717 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2718 implementation.
b61cc01c
PE
2719 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2720 We prefer signed types, and the value cannot exceed the EMACS_INT
2721 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2722 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2723 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2724 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2725
53b2623d
PE
2726 * indent.c (sane_tab_width): New function.
2727 (current_column, scan_for_column, Findent_to, position_indentation)
2728 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2729 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2730
51cab52b 2731 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2732
f2ed8a70
PE
2733 * lisp.h (lint_assume): New macro.
2734 * composite.c (composition_gstring_put_cache):
2735 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2736
abe80cc6
PE
2737 * editfns.c, insdel.c:
2738 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2739
b02c740e
PE
2740 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2741
ebc96716
PE
2742 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2743
b4e50fa0 2744 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2745 Use much-faster test for byte-length change.
311d5d7c 2746 Don't assume string byte-length fits in 'int'.
a4cf38e4 2747 Check that character arg fits in 'int'.
85461888 2748 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2749
c0c1ee9f
PE
2750 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2751
a498d7f4
PE
2752 * fns.c (concat): Catch string overflow earlier.
2753 Do not rely on integer wraparound.
2754
51cab52b
PE
2755 * dispextern.h (struct it.overlay_strings_charpos)
2756 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2757 * xdisp.c (forward_to_next_line_start)
2758 (back_to_previous_visible_line_start)
2759 (reseat_at_next_visible_line_start, next_element_from_buffer):
2760 Don't arbitrarily truncate the value of 'selective' to int.
2761
76031fad
PE
2762 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2763
5eb55db9
PE
2764 * composite.c: Don't truncate sizes to 'int'.
2765 (composition_gstring_p, composition_reseat_it)
2766 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2767 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2768 not EMACS_UINT, for indexes.
5eb55db9 2769
0703a717
PE
2770 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2771
d6202519
PE
2772 * buffer.c: Include <verify.h>.
2773 (struct sortvec.priority, struct sortstr.priority):
8961a454 2774 Now EMACS_INT, not int.
c20998a7 2775 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2776 (struct sortstr.size, record_overlay_string)
2777 (struct sortstrlist.size, struct sortlist.used):
2778 Don't truncate size to int.
2779 (record_overlay_string): Check for size-calculation overflow.
d6202519 2780 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2781
d5a19415
JM
27822011-06-22 Jim Meyering <meyering@redhat.com>
2783
029529ac 2784 Don't leak an XBM-image-sized buffer
d5a19415
JM
2785 * image.c (xbm_load): Free the image buffer after using it.
2786
a9041e6c
PE
27872011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2788
2789 Port to Sun C.
2790 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2791 that Sun C diagnosed.
2792 * fns.c (secure_hash): Fix pointer signedness issue.
2793 * intervals.c (static_offset_intervals): New function.
2794 (offset_intervals): Use it.
2795
7f3f739f
LL
27962011-06-21 Leo Liu <sdl.web@gmail.com>
2797
2798 * deps.mk (fns.o):
2799 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2800 sha512.h.
2801
2802 * fns.c (secure_hash): Rename from crypto_hash_function and change
2803 the first arg to accept symbols.
5b66d427 2804 (Fsecure_hash): New primitive.
7f3f739f
LL
2805 (syms_of_fns): New symbols.
2806
76147d94
DD
28072011-06-20 Deniz Dogan <deniz@dogan.se>
2808
2809 * process.c (Fset_process_buffer): Clarify return value in
2810 docstring.
2811
7d7d0045
CY
28122011-06-18 Chong Yidong <cyd@stupidchicken.com>
2813
2814 * dispnew.c (add_window_display_history): Use BVAR.
2815
2816 * xdisp.c (debug_method_add): Use BVAR.
2817 (check_window_end, dump_glyph_matrix, dump_glyph)
2818 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2819
2820 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2821 Likewise.
2822
2823 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2824 check till after the cache is created in init_frame_faces.
2825
ff2bc410
SM
28262011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2827
2828 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2829
28177add
PE
28302011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2831
dd3482fe
PE
2832 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2833 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2834 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2835
393d71f3 2836 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2837 * fileio.c (Finsert_file_contents):
2838 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2839 Remove the old (too-loose) buffer overflow checks.
2840 They weren't needed, since make_gap checks for buffer overflow.
2841 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2842 The old code merely checked for Emacs fixnum overflow, and relied
2843 on undefined (wraparound) behavior. The new code avoids undefined
2844 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2845
2e6813b0 2846 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2847 Tune. Don't use wider integers than needed. Don't use alloca.
2848 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2849
599a9e4f
PE
2850 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2851
99561444
PE
2852 * insdel.c, lisp.h (buffer_overflow): New function.
2853 (insert_from_buffer_1, replace_range, replace_range_2):
2854 * insdel.c (make_gap_larger):
2855 * editfns.c (Finsert_char):
2856 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2857
28177add
PE
2858 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2859
e69dafad
PE
28602011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2861
a7af7fde 2862 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2863
b1c46f02
PE
2864 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2865 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2866
e69dafad
PE
2867 * fileio.c: Don't assume EMACS_INT fits in off_t.
2868 (emacs_lseek): New static function.
2869 (Finsert_file_contents, Fwrite_region): Use it.
2870 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2871
566684ea
PE
2872 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2873
e6966cd6
PE
2874 * fns.c: Don't overflow int when computing a list length.
2875 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2876 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2877 truncation on 64-bit hosts. Check for QUIT every
2878 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2879 faster and is responsive enough.
2880 (Flength): Report an error instead of overflowing an integer.
2881 (Fsafe_length): Return a float if the value is not representable
2882 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2883 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2884 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2885
dd0b0efb
PE
2886 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2887 (header_size, word_size): New constants.
2888 (allocate_vectorlike): Don't check size overflow here.
2889 (allocate_vector): Check it here instead, since this is the only
2890 caller of allocate_vectorlike that could cause overflow.
2891 Check that the new vector's length is representable as a fixnum.
2892
86fe5cfe
PE
2893 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2894 The previous code was bogus. For example, next_almost_prime (32)
2895 returned 39, which is undesirable as it is a multiple of 3; and
2896 next_almost_prime (24) returned 25, which is a multiple of 5 so
2897 why was the code bothering to check for multiples of 7?
2898
80e88859
PE
2899 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2900
4a2f0ad6
PE
2901 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2902
f66c7cf8
PE
2903 Variadic C functions now count arguments with ptrdiff_t.
2904 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2905 Back then I didn't know that the Emacs coding style prefers signed int.
2906 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2907 were being counted with int, which may truncate counts on 64-bit
2908 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2909 * lisp.h (struct Lisp_Subr.function.aMANY)
2910 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2911 Arg counts are now ptrdiff_t, not size_t.
2912 All variadic functions and their callers changed accordingly.
2913 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2914 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2915 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2916 * callint.c (Fcall_interactively): Check arg count for overflow,
2917 to avoid potential buffer overrun. Use signed char, not 'int',
2918 for 'varies' array, so that we needn't bother to check its size
2919 calculation for overflow.
2920 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2921 * eval.c (apply_lambda):
2922 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2923 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2924 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2925
a1759b76
PE
2926 * callint.c (Fcall_interactively): Don't use index var as event count.
2927
d96be9fc
PE
2928 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2929 * mem-limits.h (SIZE): Remove; no longer used.
2930
a690a978 2931 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2932
578c21e6
PE
2933 Remove unnecessary casts.
2934 * xterm.c (x_term_init):
2935 * xfns.c (x_set_border_pixel):
2936 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2937 These aren't needed now that we assume ANSI C.
2938
96f53c6c
PE
2939 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2940 It's more likely to cause problems (due to unsigned overflow)
2941 than to cure them.
2942
83c77d31
PE
2943 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2944
ee2079f1
PE
2945 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2946
6da65536
PE
2947 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2948
7147c4a4
PE
2949 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2950
193e32d9
PE
2951 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2952
e5533da6
PE
2953 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2954
9910e595
PE
2955 GLYPH_CODE_FACE returns EMACS_INT, not int.
2956 * dispextern.h (merge_faces):
2957 * xfaces.c (merge_faces):
01103c44
PE
2958 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2959 Don't assume EMACS_INT fits in int.
9910e595 2960
2638320e
PE
2961 * character.h (CHAR_VALID_P): Remove unused parameter.
2962 * fontset.c, lisp.h, xdisp.c: All uses changed.
2963
045eb8d9
PE
2964 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2965
c1f134b5
PE
2966 * fns.c (concat): Minor tuning based on overflow analysis.
2967 This doesn't fix any bugs. Use int to hold character, instead
2968 of constantly refetching from Emacs object. Use XFASTINT, not
2969 XINT, for value known to be a character. Don't bother comparing
2970 a single byte to 0400, as it's always less.
2971
395fcb93 2972 * floatfns.c (Fexpt):
327eeec8
PE
2973 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2974
abbd3d23
PE
2975 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2976 for characters.
2977
684a03ef
PE
2978 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2979
0fed43f3
PE
2980 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2981 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2982 incorrectly succeed when S was a string, because 4294967386 was
2983 truncated before it was used.
2984
8fd02eb7
PE
2985 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2986 Otherwise, an out-of-range integer could cause undefined behavior
2987 on a 64-bit host.
2988
f8c86b69
PE
2989 * composite.c: Use int, not EMACS_INT, for characters.
2990 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2991 EMACS_INT, for values that are known to be in character range.
2992 This doesn't fix any bugs but is the usual style inside Emacs and
2993 may generate better code on 32-bit machines.
2994
34206dd2
PE
2995 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2996 This is for reasons similar to the recent CHAR_STRING fix.
2997 * charset.c (Fencode_char): Check that character arg is actually
2998 a character. Pass an int to ENCODE_CHAR.
2999 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3000 wider than 'int', as a compile-time check to prevent future regressions
3001 in this area.
3002
c5958d4c 3003 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3004
3005 Make sure a 64-bit char is never passed to CHAR_STRING.
3006 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3007 by silently ignoring the top 32 bits, allowing some values
3008 that were far too large to be valid characters.
3009 * character.h: Include <verify.h>.
3010 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3011 arguments are no wider than unsigned, as a compile-time check
3012 to prevent future regressions in this area.
3013 * data.c (Faset):
01103c44 3014 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3015 (Fsubst_char_in_region):
3016 * fns.c (concat):
3017 * xdisp.c (decode_mode_spec_coding):
3018 Adjust to CHAR_STRING's new requirement.
3019 * editfns.c (Finsert_char, Fsubst_char_in_region):
3020 * fns.c (concat): Check that character args are actually
3021 characters. Without this test, these functions did the wrong
3022 thing with wildly out-of-range values on 64-bit hosts.
3023
d37ca623
PE
3024 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3025 These casts should not be needed on 32-bit hosts, either.
3026 * keyboard.c (read_char):
3027 * lread.c (Fload): Remove casts to unsigned.
3028
ea204efb
PE
3029 * lisp.h (UNSIGNED_CMP): New macro.
3030 This fixes comparison bugs on 64-bit hosts.
3031 (ASCII_CHAR_P): Use it.
3032 * casefiddle.c (casify_object):
01103c44 3033 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3034 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3035 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3036 * dispextern.h (FACE_FROM_ID):
3037 * keyboard.c (read_char): Use UNSIGNED_CMP.
3038
41cb286c
PE
3039 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3040 not to EMACS_INT, to avoid GCC warning.
3041
4a1b9832
PE
3042 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3043
55daad71
PE
3044 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3045 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3046 isn't needed on 32-bit machines.
8f95c75c 3047
01103c44
PE
3048 * buffer.c (Fgenerate_new_buffer_name):
3049 Use EMACS_INT for count, not int.
0ceccced 3050 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3051
3052 * data.c (Qcompiled_function): Now static.
3053
c6f072e7
PE
3054 * window.c (window_body_lines): Now static.
3055
20ce5912
PE
3056 * image.c (gif_load): Rename local to avoid shadowing.
3057
9c4c5f81
PE
3058 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3059 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3060 * alloc.c (make_save_value): Integer argument is now of type
3061 ptrdiff_t, not int.
3062 (mark_object): Use ptrdiff_t, not int.
3063 * lisp.h (pD): New macro.
3064 * print.c (print_object): Use it.
3065
c0c5c8ae
PE
3066 * alloc.c: Use EMACS_INT, not int, to count objects.
3067 (total_conses, total_markers, total_symbols, total_vector_size)
3068 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3069 (total_free_floats, total_floats, total_free_intervals)
3070 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3071 Now EMACS_INT, not int. All uses changed.
3072 (Fgarbage_collect): Compute overall total using a double, so that
3073 integer overflow is less likely to be a problem. Check for overflow
3074 when converting back to an integer.
5a25e253
PE
3075 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3076 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3077 These were 'int' variables that could overflow on 64-bit hosts;
3078 they were never used, so remove them instead of repairing them.
211a0b2a 3079 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3080 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3081 Previously, this ceilinged at INT_MAX, but that doesn't work on
3082 64-bit machines.
e46bb31a 3083 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3084
c78baabf 3085 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3086 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3087 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3088 when a (possibly-narrower) signed value would do just as well.
3089 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3090
c9d624c6
PE
3091 * alloc.c: Catch some string size overflows that we were missing.
3092 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3093 for convenience in STRING_BYTES_MAX.
3094 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3095 The definition here is exact; the one in lisp.h was approximate.
3096 (allocate_string_data): Check for string overflow. This catches
3097 some instances we weren't catching before. Also, it catches
3098 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3099 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3100 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3101
c9d624c6
PE
3102 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3103 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3104 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3105
353032ce
PE
3106 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3107
2bccce07
PE
3108 * alloc.c (Fmake_string): Check for out-of-range init.
3109
0ac30604
SM
31102011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3111
3112 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3113
c195f2de
JD
31142011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3115
3116 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3117 xg_get_default_scrollbar_width.
3118
3119 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3120 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3121 (style_changed_cb): Call update_theme_scrollbar_width and call
3122 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3123 all frames (Bug#8505).
3124 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3125 Call gtk_window_set_resizable if HAVE_GTK3.
3126 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3127 and height if HAVE_GTK3 (Bug#8505).
3128 (scroll_bar_width_for_theme): New variable.
3129 (update_theme_scrollbar_width): New function.
3130 (xg_get_default_scrollbar_width): Move code to
3131 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3132 (xg_initialize): Call update_theme_scrollbar_width.
3133
3134 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3135
3136 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3137
e10ac9f1
MR
31382011-06-12 Martin Rudalics <rudalics@gmx.at>
3139
3140 * frame.c (make_frame): Call other_buffer_safely instead of
3141 other_buffer.
3142
3143 * window.c (temp_output_buffer_show): Call display_buffer with
3144 second argument Vtemp_buffer_show_specifiers and reset latter
3145 immediately after the call.
3146 (Vtemp_buffer_show_specifiers): New variable.
3147 (auto_window_vscroll_p, next_screen_context_lines)
3148 (Vscroll_preserve_screen_position): Remove leading asterisks from
3149 doc-strings.
3150
2d3c217e 31512011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3152
7b7f97e8 3153 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3154 * buffer.c (Qclone_number): Remove for now, as it's unused.
3155 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3156 (record_buffer): Remove unused local.
3157 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3158 (set_frame_buffer_list): Remove; unused.
3159 * frame.h (other_visible_frames): Remove decl.
3160 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3161 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3162 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3163 if HAVE_GPM.
3164 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3165 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3166 Define only if HAVE_GPM.
3167 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3168 (update_hints_inhibit): Remove; never set. All uses removed.
3169 * widgetprv.h (emacsFrameClassRec): Remove decl.
3170 * window.c (delete_deletable_window): Now returns void, since it
3171 wasn't returning anything.
3172 (compare_window_configurations): Remove unused locals.
3173 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3174 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3175 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3176 the same widths as pointers. This follows up on the 2011-05-06 patch.
3177 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3178 * xterm.h: Likewise.
3179 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3180
1384b89e
JB
31812011-06-12 Juanma Barranquero <lekktu@gmail.com>
3182
3183 * makefile.w32-in: Update dependencies.
3184 (LISP_H): Add lib/intprops.h.
3185
1100a63c
CY
31862011-06-11 Chong Yidong <cyd@stupidchicken.com>
3187
3188 * image.c (gif_load): Add animation frame delay to the metadata.
3189 (syms_of_image): Use DEFSYM. New symbol `delay'.
3190
6198ccd0
MR
31912011-06-11 Martin Rudalics <rudalics@gmx.at>
3192
3193 * window.c (delete_deletable_window): Re-add.
3194 (Fset_window_configuration): Rewrite to handle dead buffers and
3195 consequently deletable windows.
3196 (window_tree, Fwindow_tree): Remove. Supply functionality in
3197 window.el.
3198 (compare_window_configurations): Simplify code.
3199
b6e3633c
AS
32002011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3201
1ab0dee5
AS
3202 * image.c (imagemagick_load_image): Fix type mismatch.
3203 (Fimagemagick_types): Likewise.
3204
b6e3633c
AS
3205 * window.h (replace_buffer_in_windows): Declare.
3206
9397e56f
MR
32072011-06-11 Martin Rudalics <rudalics@gmx.at>
3208
3209 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3210 Qclone_number. Remove external declaration of Qdelete_window.
3211 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3212 code.
640c8776
SM
3213 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3214 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3215 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3216 buffer list implementation.
3217 (other_buffer_safely): New function.
3218 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3219 calls to replace_buffer_in_windows and
3220 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3221 if allowed.
3222 (record_buffer): Inhibit quitting and rewrite using quittable
3223 functions. Run Qbuffer_list_update_hook if allowed.
3224 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3225 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3226 Move switch-to-buffer to window.el.
9397e56f
MR
3227 (bury-buffer): Move to window.el.
3228 (Vbuffer_list_update_hook): New variable.
3229
3230 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3231 section.
3232
3233 * window.h (resize_frame_windows): Move up in code.
3234 (Fwindow_frame): Remove EXFUN.
3235 (replace_buffer_in_all_windows): Remove prototype.
3236 (replace_buffer_in_windows_safely): Add prototype.
3237
3238 * window.c: Declare Qdelete_window static again. Move down
3239 declaration of select_count.
3240 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3241 (Fother_window): Move to window.el.
3242 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3243 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3244 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3245 window.el.
3246 (replace_buffer_in_windows): Implement by calling
3247 Qreplace_buffer_in_windows.
3248 (replace_buffer_in_all_windows): Remove with some functionality
3249 moved into replace_buffer_in_windows_safely.
3250 (replace_buffer_in_windows_safely): New function.
3251 (select_window_norecord, select_frame_norecord): Move in front
3252 of run_window_configuration_change_hook. Remove now obsolete
3253 declarations.
640c8776
SM
3254 (Fset_window_buffer): Rewrite doc-string.
3255 Call Qrecord_window_buffer.
9397e56f
MR
3256 (keys_of_window): Move binding for other-window to window.el.
3257
b50691aa
CY
32582011-06-11 Chong Yidong <cyd@stupidchicken.com>
3259
3260 * dispextern.h (struct image): Replace data member, whose int_val
3261 and ptr_val fields were not used by anything, with a single
3262 lisp_val object.
3263
3264 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3265 (gif_clear_image, gif_load, imagemagick_load_image)
3266 (gs_clear_image, gs_load): Callers changed.
3267
3f754b86
PE
32682011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3269
cca69397
PE
3270 * buffer.h: Include <time.h>, for time_t.
3271 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3272
109e28d0
PE
3273 Fix minor problems found by static checking.
3274
60737f02
PE
3275 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3276
4b66faf3
PE
3277 Make identifiers static if they are not used in other modules.
3278 * data.c (Qcompiled_function, Qframe, Qvector):
3279 * image.c (QimageMagick, Qsvg):
3280 * minibuf.c (Qmetadata):
3281 * window.c (resize_window_check, resize_root_window): Now static.
3282 * window.h (resize_window_check, resize_root_window): Remove decls.
3283
109e28d0
PE
3284 * window.c (window_deletion_count, delete_deletable_window):
3285 Remove; unused.
46a4ce9e
PE
3286 (window_body_lines): Now static.
3287 (Fdelete_other_windows_internal): Mark vars as initialized.
3288 Make sure 'resize_failed' is initialized.
3289 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3290 (resize_window_apply): Remove unused local.
3291 * window.h (delete_deletable_window): Remove decl.
3292
109e28d0 3293 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3294 (imagemagick_load_image): Fix pointer signedness problem by changing
3295 last arg from unsigned char * to char *. All uses changed.
3296 Also, fix a local for similar reasons.
3297 Remove unused locals. Remove locals to avoid shadowing.
3298 (fn_rsvg_handle_free): Remove; unused.
3299 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3300 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3301
3f754b86
PE
3302 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3303
2547adb1
CY
33042011-06-10 Chong Yidong <cyd@stupidchicken.com>
3305
3306 * image.c (gif_load): Fix omitted cast error introduced by
3307 2011-06-06 change.
3308
2c8e37d4
MR
33092011-06-10 Martin Rudalics <rudalics@gmx.at>
3310
3311 * window.h (resize_proportionally, orig_total_lines)
3312 (orig_top_line): Remove from window structure.
3313 (set_window_height, set_window_width, change_window_heights)
3314 (Fdelete_window): Remove prototypes.
3315 (resize_frame_windows): Remove duplicate declaration.
3316
440a42e3
EZ
33172011-06-10 Eli Zaretskii <eliz@gnu.org>
3318
3319 * window.h (resize_frame_windows, resize_window_check)
3320 (delete_deletable_window, resize_root_window)
3321 (resize_frame_windows): Declare prototypes.
3322
3323 * window.c (resize_window_apply): Make definition be "static" to
3324 match the prototype.
3325
562dd5e9
MR
33262011-06-10 Martin Rudalics <rudalics@gmx.at>
3327
3328 * window.c: Remove declarations of Qwindow_size_fixed,
3329 window_min_size_1, window_min_size_2, window_min_size,
3330 size_window, window_fixed_size_p, enlarge_window, delete_window.
3331 Remove static from declaration of Qdelete_window, it's
3332 temporarily needed by Fbury_buffer.
3333 (replace_window): Don't assign orig_top_line and
3334 orig_total_lines.
3335 (Fdelete_window, delete_window): Remove. Window deletion is
3336 handled by window.el.
640c8776
SM
3337 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3338 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3339 (Fdelete_other_windows): Remove. Deleting other windows is
3340 handled by window.el.
3341 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3342 handled in window.el.
3343 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3344 Window minimum sizes are handled in window.el.
3345 (shrink_windows, size_window, set_window_height)
3346 (set_window_width, change_window_heights, window_height)
3347 (window_width, CURBEG, CURSIZE, enlarge_window)
3348 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3349 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3350 handled in window.el.
3351 (make_dummy_parent): Rename to make_parent_window and give it a
3352 second argument horflag.
3353 (make_window): Don't set resize_proportionally any more.
3354 (Fsplit_window): Remove. Windows are split in window.el.
3355 (save_restore_action, save_restore_orig_size)
3356 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3357 Resize mini windows in window.el.
3358 (grow_mini_window, shrink_mini_window): Implement by calling
3359 Qresize_root_window_vertically, resize_window_check and
3360 resize_window_apply.
640c8776
SM
3361 (saved_window, Fset_window_configuration, save_window_save):
3362 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3363 resize_proportionally.
3364 (window_min_height, window_min_width): Move to window.el.
3365 (keys_of_window): Move bindings for delete-other-windows,
3366 split-window, delete-window and enlarge-window to window.el.
3367
3368 * buffer.c: Temporarily extern Qdelete_window.
3369 (Fbury_buffer): Temporarily call Qdelete_window instead of
3370 Fdelete_window (Fbury_buffer will move to window.el soon).
3371
3372 * frame.c (set_menu_bar_lines_1): Remove code handling
3373 orig_top_line and orig_total_lines.
3374
3375 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3376 set_window_height but set heights directly.
3377 (change_frame_size_1): Use resize_frame_windows.
3378
3379 * xdisp.c (init_xdisp): Don't use set_window_height but set
3380 heights directly.
3381
640c8776
SM
3382 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3383 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3384 run_window_configuration_change_hook.
3385
3386 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3387 instead of change_window_heights and run
3388 run_window_configuration_change_hook.
3389
1a13852e
MR
33902011-06-09 Martin Rudalics <rudalics@gmx.at>
3391
3392 * window.c (replace_window): Rename second argument REPLACEMENT to
3393 NEW. New third argument SETFLAG. Rewrite.
3394 (delete_window, make_dummy_parent): Call replace_window with
3395 third argument 1.
3396 (window_list_1): Move down in code.
3397 (run_window_configuration_change_hook): Move set_buffer part
3398 before select_frame_norecord part in order to unwind correctly.
3399 Rename count1 to count.
3400 (recombine_windows, delete_deletable_window, resize_root_window)
3401 (Fdelete_other_windows_internal)
3402 (Frun_window_configuration_change_hook, make_parent_window)
3403 (resize_window_check, resize_window_apply, Fresize_window_apply)
3404 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3405 (Fdelete_window_internal, Fresize_mini_window_internal):
3406 New functions.
1a13852e
MR
3407 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3408
f3d1777e
MR
34092011-06-08 Martin Rudalics <rudalics@gmx.at>
3410
496e208e
MR
3411 * window.h (window): Add some new members to window structure -
3412 normal_lines, normal_cols, new_total, new_normal, clone_number,
3413 splits, nest, prev_buffers, next_buffers.
3414 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3415 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3416
f3d1777e
MR
3417 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3418 Remove.
496e208e
MR
3419 (make_dummy_parent): Set new members of windows structure.
3420 (make_window): Move down in code. Handle new members of window
3421 structure.
3422 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3423 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3424 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3425 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3426 (Fset_window_next_buffers, Fset_window_clone_number):
3427 New functions.
496e208e
MR
3428 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3429 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3430 Doc-string fixes.
3431 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3432 Argument WINDOW can be now internal window too.
3433 (Fwindow_use_time): Move up in code.
3434 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3435 Rewrite doc-string.
3436 (Fset_window_configuration, saved_window)
3437 (Fcurrent_window_configuration, save_window_save): Handle new
3438 members of window structure.
b9e809c2
MR
3439 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3440 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3441 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3442 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3443 Qget_mru_window, Qresize_root_window,
3444 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3445 Qauto_buffer_name; staticpro them.
f3d1777e 3446
abde8f8c
MR
34472011-06-07 Martin Rudalics <rudalics@gmx.at>
3448
3449 * window.c (Fwindow_total_size, Fwindow_left_column)
3450 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3451 (Fwindow_list_1): New functions.
3452 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3453 (Fwindow_width, Fscroll_left, Fscroll_right):
3454 Use window_body_cols instead of window_box_text_cols.
3455 (delete_window, Fset_window_configuration):
3456 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3457 (delete_all_subwindows): Take a window as argument and not a
3458 structure. Rewrite.
190b47e6
MR
3459 (window_loop): Remove handling of GET_LRU_WINDOW and
3460 GET_LARGEST_WINDOW.
3461 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3462
3463 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3464 window_box_text_cols. delete_all_subwindows now takes a
3465 Lisp_Object as argument.
abde8f8c 3466
640c8776
SM
3467 * indent.c (compute_motion, Fcompute_motion):
3468 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3469
fa8a67e6
MR
3470 * frame.c (delete_frame): Call delete_all_subwindows with root
3471 window as argument.
3472
a54e3482
DC
34732011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3474
3475 * fns.c (Fputhash): Document return value.
3476
60002bf5
CY
34772011-06-06 Chong Yidong <cyd@stupidchicken.com>
3478
3479 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3480
0c671da6 34812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3482
b862a52a 3483 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3484
be44ca6c
PE
3485 Check for overflow when converting integer to cons and back.
3486 * charset.c (Fdefine_charset_internal, Fdecode_char):
3487 Use cons_to_unsigned to catch overflow.
3488 (Fencode_char): Use INTEGER_TO_CONS.
3489 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3490 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3491 * data.c (long_to_cons, cons_to_long): Remove.
3492 (cons_to_unsigned, cons_to_signed): New functions.
3493 These signal an error for invalid or out-of-range values.
3494 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3495 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3496 * font.c (Ffont_variation_glyphs):
3497 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3498 * lisp.h: Include <intprops.h>.
3499 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3500 (cons_to_signed, cons_to_unsigned): New decls.
3501 (long_to_cons, cons_to_long): Remove decls.
3502 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3503 (Fprimitive_undo): Use CONS_TO_INTEGER.
3504 * xfns.c (Fx_window_property): Likewise.
3505 * xselect.c: Include <limits.h>.
3506 (x_own_selection, selection_data_to_lisp_data):
3507 Use INTEGER_TO_CONS.
3508 (x_handle_selection_request, x_handle_selection_clear)
3509 (x_get_foreign_selection, Fx_disown_selection_internal)
3510 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3511 (lisp_data_to_selection_data): Use cons_to_unsigned.
3512 (x_fill_property_data): Use cons_to_signed.
3513 Report values out of range.
3514
d1f3d2af
PE
3515 Check for buffer and string overflow more precisely.
3516 * buffer.h (BUF_BYTES_MAX): New macro.
3517 * lisp.h (STRING_BYTES_MAX): New macro.
3518 * alloc.c (Fmake_string):
3519 * character.c (string_escape_byte8):
3520 * coding.c (coding_alloc_by_realloc):
3521 * doprnt.c (doprnt):
3522 * editfns.c (Fformat):
3523 * eval.c (verror):
3524 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3525 since they may not be the same number.
3526 * editfns.c (Finsert_char):
3527 * fileio.c (Finsert_file_contents):
3528 Likewise for BUF_BYTES_MAX.
3529
dd52fcea
PE
3530 * image.c: Use ptrdiff_t, not int, for sizes.
3531 (slurp_file): Switch from int to ptrdiff_t.
3532 All uses changed.
3533 (slurp_file): Check that file size fits in both size_t (for
3534 malloc) and ptrdiff_t (for sanity and safety).
3535
7f9bbdbb
PE
3536 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3537 if b->modtime has its maximal value.
3538
dfe18f82
PE
3539 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3540
84acfcf0
PE
3541 Don't assume time_t can fit into int.
3542 * buffer.h (struct buffer.modtime): Now time_t, not int.
3543 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3544 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3545
ccd9a01a
PE
3546 Minor fixes for signed vs unsigned integers.
3547 * character.h (MAYBE_UNIFY_CHAR):
3548 * charset.c (maybe_unify_char):
3549 * keyboard.c (read_char, reorder_modifiers):
3550 XINT -> XFASTINT, since the integer must be nonnegative.
3551 * ftfont.c (ftfont_spec_pattern):
3552 * keymap.c (access_keymap, silly_event_symbol_error):
3553 XUINT -> XFASTINT, since the integer must be nonnegative.
3554 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3555 since it makes no difference and we prefer signed.
3556 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3557 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3558 nonnegative.
3559
d6d100dd
SM
35602011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3561
3562 * window.h (Fwindow_frame): Declare.
3563
2b6148e4
PE
35642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3565
3566 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3567 (SPARE_MEMORY): Always define.
3568 (LARGE_REQUEST): Remove.
3569 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3570
f230ecc9
MR
35712011-06-06 Martin Rudalics <rudalics@gmx.at>
3572
727e958e
MR
3573 * lisp.h: Move EXFUNS for Fframe_root_window,
3574 Fframe_first_window and Fset_frame_selected_window to window.h.
3575
3576 * window.h: Move EXFUNS for Fframe_root_window,
3577 Fframe_first_window and Fset_frame_selected_window here from
3578 lisp.h.
3579
3580 * frame.c (Fwindow_frame, Fframe_first_window)
3581 (Fframe_root_window, Fframe_selected_window)
3582 (Fset_frame_selected_window): Move to window.c.
3583 (Factive_minibuffer_window): Move to minibuf.c.
3584 (Fother_visible_frames_p): New function.
3585
3586 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3587
f230ecc9
MR
3588 * window.c (decode_window, decode_any_window): Move up in code.
3589 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3590 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3591 (Fwindow_buffer): Move up and rewrite doc-string.
3592 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3593 (Fwindow_prev): New functions.
727e958e
MR
3594 (Fwindow_frame): Move here from frame.c. Accept any window as
3595 argument.
3596 (Fframe_root_window, Fframe_first_window)
3597 (Fframe_selected_window): Move here from frame.c. Accept frame
3598 or arbitrary window as argument. Update doc-strings.
3599 (Fminibuffer_window): Move up in code.
3600 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3601 (Fset_frame_selected_window): Move here from frame.c.
3602 Marginal rewrite.
727e958e
MR
3603 (Fselected_window, select_window, Fselect_window): Move up in
3604 code. Minor doc-string fixes.
f230ecc9 3605
4d09bcf6
PE
36062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3607
3608 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3609 Do not assume that spare memory exists; that assumption is valid
3610 only if SYSTEM_MALLOC.
3611 (LARGE_REQUEST): New macro, so that the issue of large requests
3612 is separated from the issue of spare memory.
3613
810928a2
AS
36142011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3615
172418ad
AS
3616 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3617 format. (Bug#8806)
3618
43f862f7
AS
3619 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3620
810928a2
AS
3621 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3622 before statements.
3623
a059fe24
JD
36242011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3625
3626 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3627
3628 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3629
3630 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3631 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3632
989bf368
JB
36332011-06-05 Juanma Barranquero <lekktu@gmail.com>
3634
3635 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3636
4b80f674
CY
36372011-06-04 Chong Yidong <cyd@stupidchicken.com>
3638
3639 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3640 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3641 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3642 New error handlers.
4b80f674
CY
3643 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3644 Obey Vx_select_enable_clipboard_manager. Catch errors in
3645 x_clipboard_manager_save (Bug#8779).
3646 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3647 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3648
99a33b77 36492011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3650
3651 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3652
99a33b77 36532011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3654
3655 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3656 in the current matrix if keep_current_p is non-zero.
3657
8264569d
EZ
36582011-06-04 Eli Zaretskii <eliz@gnu.org>
3659
3660 * bidi.c (bidi_level_of_next_char): Fix last change.
3661
57f97249
EZ
36622011-06-03 Eli Zaretskii <eliz@gnu.org>
3663
fec2107c 3664 Support bidi reordering of text covered by display properties.
57f97249 3665
fec2107c
EZ
3666 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3667 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3668 (bidi_cache_search, bidi_cache_iterator_state)
3669 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3670 (bidi_level_of_next_char, bidi_move_to_visually_next):
3671 Support character positions inside a run of characters covered by a
fec2107c
EZ
3672 display string.
3673 (bidi_paragraph_init, bidi_resolve_explicit_1)
3674 (bidi_level_of_next_char): Call bidi_fetch_char and
3675 bidi_fetch_char_advance instead of FETCH_CHAR and
3676 FETCH_CHAR_ADVANCE.
3677 (bidi_init_it): Initialize new members.
3678 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3679 definitions.
3680 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3681 instead of using explicit *_CHAR codes.
d6d100dd
SM
3682 (bidi_resolve_explicit, bidi_resolve_weak):
3683 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3684 bidirectional text is supported only in multibyte buffers.
3685 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3686 it to initialize the frame_window_p member of struct bidi_it.
3687 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3688 (bidi_resolve_explicit, bidi_resolve_weak)
3689 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3690 bidi_it->nchars is non-positive.
3691 (bidi_level_of_next_char): Don't try to lookup the cache for the
3692 next/previous character if nothing is cached there yet, or if we
3693 were just reseat()'ed to a new position.
c40e2fb2 3694
0e14fe90
EZ
3695 * xdisp.c (set_cursor_from_row): Set start and stop points
3696 according to the row's direction when priming the loop that looks
3697 for the glyph on which to display cursor.
3698 (single_display_spec_intangible_p): Function deleted.
3699 (display_prop_intangible_p): Reimplement to call
3700 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3701 Accept 3 additional arguments needed by handle_display_spec.
3702 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3703 values: lists, `(when COND...)' forms, etc.
3704 (single_display_spec_string_p): Support property values that are
3705 lists with the argument STRING its top-level element.
3706 (display_prop_string_p): Fix the condition for processing a
3707 property that is a list to be consistent with handle_display_spec.
fec2107c 3708 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3709 last portion of handle_display_prop.
3710 (compute_display_string_pos): Accept additional argument
3711 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3712 value of a `display' property is a "replacing spec".
3713 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3714 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3715 the display property, but just return a value indicating whether
3716 the display property will replace the characters it covers.
3717 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3718 frame_window_p members of struct bidi_it.
d6d100dd
SM
3719 (compute_display_string_pos, compute_display_string_end):
3720 New functions.
fec2107c
EZ
3721 (push_it): Accept second argument POSITION, where pop_it should
3722 jump to continue iteration.
3723 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3724
fec2107c
EZ
3725 * keyboard.c (adjust_point_for_property): Adjust the call to
3726 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3727
3728 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3729 (bidi_init_it): Update prototypes.
3730 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3731 (compute_display_string_pos, compute_display_string_end):
3732 Declare prototypes.
fec2107c
EZ
3733 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3734 EMACS_INT.
fc6f18ce 3735
40087514 37362011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3737
57f53182
PE
3738 Malloc failure behavior now depends on size of allocation.
3739 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3740 * lisp.h: Change signatures accordingly.
3741 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3742 All callers changed. (Bug#8762)
3743
3744 * gnutls.c: Use Emacs's memory allocators.
3745 Without this change, the gnutls library would invoke malloc etc.
3746 directly, which causes problems on non-SYNC_INPUT hosts, and which
3747 runs afoul of improving memory_full behavior. (Bug#8761)
3748 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3749 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3750 xfree instead of the default malloc, realloc, free.
3751 (Fgnutls_boot): No need to check for memory allocation failure,
3752 since xmalloc does that for us.
3753
ac32cd99 3754 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3755 * category.c (hash_get_category_set):
3756 * ccl.c (ccl_driver):
3757 * charset.c (Fdefine_charset_internal):
3758 * charset.h (struct charset.hash_index):
3759 * composite.c (get_composition_id, gstring_lookup_cache)
3760 (composition_gstring_put_cache):
3761 * composite.h (struct composition.hash_index):
3762 * dispextern.h (struct image.hash):
3763 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3764 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3765 (hashfn_equal, hashfn_user_defined, make_hash_table)
3766 (maybe_resize_hash_table, hash_lookup, hash_put)
3767 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3768 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3769 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3770 * image.c (make_image, search_image_cache, lookup_image)
3771 (xpm_put_color_table_h):
3772 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3773 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3774 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3775 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3776 * alloc.c (allocate_vectorlike):
3777 Check for overflow in vector size calculations.
3778 * ccl.c (ccl_driver):
3779 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3780 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3781 need to be updated by these changes.
40087514
PE
3782 * fns.c (make_hash_table, maybe_resize_hash_table):
3783 Check for integer overflow with large hash tables.
0de4bb68
PE
3784 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3785 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3786 (SXHASH_REDUCE): New macro.
3787 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3788 Use it instead of discarding useful hash info with large hash values.
3789 (sxhash_float): New function.
3790 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3791 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3792 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3793 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3794 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3795 Adjust signatures to match updated version of code.
3796 (consing_since_gc): Now EMACS_INT, since a single hash table can
3797 use more than INT_MAX bytes.
3798
698d32e2
DN
37992011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3800
3801 Make it possible to build with GCC-4.6+ -O2 -flto.
3802
3803 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3804
fd6fa53f
SM
38052011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3806
3807 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3808 Call minibuffer-inactive-mode.
3809
864db017
JB
38102011-05-31 Juanma Barranquero <lekktu@gmail.com>
3811
3812 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3813 Update dependencies.
3814
2ad0baf4
DN
38152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3816
3817 * data.c (init_data): Remove code for UTS, this system is not
3818 supported anymore.
3819
4fcc2638
DN
38202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3821
3822 Don't force ./temacs to start in terminal mode.
3823
3824 * frame.c (make_initial_frame): Initialize faces in all cases, not
3825 only when CANNOT_DUMP is defined.
3826 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3827
c56e0fd5
DN
38282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3829
3830 * dispnew.c (add_window_display_history): Use const for the string
3831 pointer. Remove declaration, not needed.
3832
333d54da 38332011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3834
55d4c1b2 3835 Use 'inline', not 'INLINE'.
333d54da 3836 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3837 * alloc.c, fontset.c (INLINE): Remove.
3838 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3839 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3840 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3841 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3842 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3843
738db178
DN
38442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3845
3846 Make it possible to run ./temacs.
3847
3848 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3849 syms_of_callproc does the same thing. Remove test for
3850 "initialized", do it in the caller.
3851 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3852
620c53a6
SM
38532011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3854
3855 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3856 (read_minibuf): Use get_minibuffer.
3857 (syms_of_minibuf): Use DEFSYM.
3858 (Qmetadata): New var.
3859 * data.c (Qbuffer): Don't make it static.
3860 (syms_of_data): Use DEFSYM.
3861
e003a292
PE
38622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3863
3864 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3865 (CCL_CODE_MIN): New macro.
3866
ed008a6d
PE
38672011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3868
3687c2ef
PE
3869 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3870
ed008a6d
PE
3871 * eval.c (Qdebug): Now static.
3872 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3873 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3874 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3875
d66c4c7c
CY
38762011-05-29 Chong Yidong <cyd@stupidchicken.com>
3877
3878 * image.c: Various fixes to ImageMagick code comments.
3879 (Fimagemagick_types): Doc fix.
3880
5fbc2025
PE
38812011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3882
0196f88a
PE
3883 Minor fixes prompted by GCC 4.6.0 warnings.
3884
3885 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3886
5fbc2025
PE
3887 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3888 (x_clipboard_manager_save_all): Move extern decl to ...
3889 * xterm.h: ... here, so that it can be checked for consistency.
3890
1dd3c2d9
CY
38912011-05-29 Chong Yidong <cyd@stupidchicken.com>
3892
3893 * xselect.c (x_clipboard_manager_save_frame)
3894 (x_clipboard_manager_save_all): New functions.
3895 (Fx_clipboard_manager_save): Lisp function deleted.
3896
3897 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3898 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3899
3900 * xterm.h: Update prototype.
3901
5ba6571d
WX
39022011-05-28 William Xu <william.xwl@gmail.com>
3903
3904 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3905 exiting (Bug#8239).
3906
3eaff834
JM
39072011-05-28 Jim Meyering <meyering@redhat.com>
3908
e1900994 3909 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3910 * fns.c (to_uchar): Define.
3911 (crypto_hash_function): Use it to convert some newly-signed
3912 variables to unsigned, to avoid sign-extension bugs. For example,
3913 without this change, (md5 "truc") would evaluate to
3914 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3915 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3916 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3917
0f6990a7
PE
39182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3919
3920 Integer overflow fixes.
c8a9ca5a 3921
08686060
PE
3922 * dbusbind.c: Serial number integer overflow fixes.
3923 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3924 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3925 to hold a serial number that is too large for a fixnum.
3926 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3927 Check for serial numbers out of range. Decode any serial number
59568bf0 3928 that was so large that it became a float. (Bug#8722)
08686060 3929
2d1fc3c7
PE
3930 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3931 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3932 Use XFASTINT rather than XUINT when numbers are nonnegative.
3933 (xd_append_arg, Fdbus_method_return_internal):
3934 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3935 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3936 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3937 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3938 (Bug#8722)
2d1fc3c7 3939
c8a9ca5a
PE
3940 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3941
519e1d69
PE
3942 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3943
30569699
PE
3944 ccl: add integer overflow checks
3945 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3946 (IN_INT_RANGE): New macros.
3947 (ccl_driver): Use them to check for integer overflow when
3948 decoding a CCL program. Many of the new checks are whether XINT (x)
3949 fits in int; it doesn't always, on 64-bit hosts. The new version
3950 doesn't catch all possible integer overflows, but it's an
847044ea 3951 improvement. (Bug#8719)
30569699 3952
c11285dc
PE
3953 * alloc.c (make_event_array): Use XINT, not XUINT.
3954 There's no need for unsigned here.
3955
fdccd48e
PE
3956 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3957 This follows up to the 2011-05-06 change that substituted uintptr_t
3958 for EMACS_INT. This case wasn't caught back then.
3959
37910ab2
PE
3960 Rework Fformat to avoid integer overflow issues.
3961 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3962 now (part of C89). Include <verify.h>.
3963 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3964 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3965 (Fformat): Avoid the prepass trying to compute sizes; it was only
3966 approximate and thus did not catch overflow reliably. Instead, walk
3967 through the format just once, formatting and computing sizes as we go,
3968 checking for integer overflow at every step, and allocating a larger
3969 buffer as needed. Keep track separately whether the format is
3970 multibyte. Keep only the most-recently calculated precision, rather
3971 than them all. Record whether each argument has been converted to
3972 string. Use EMACS_INT, not int, for byte and char and arg counts.
3973 Support field widths and precisions larger than INT_MAX. Avoid
3974 sprintf's undefined behavior with conversion specifications such as %#d
3975 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3976 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3977 formatting out-of-range floating point numbers with int
9173deec 3978 formats. (Bug#8668)
37910ab2 3979
2e6578fb
PE
3980 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3981
0ae6bdee
PE
3982 * data.c: Avoid integer truncation in expressions involving floats.
3983 * data.c: Include <intprops.h>.
3984 (arith_driver): When there's an integer overflow in an expression
3985 involving floating point, convert the integers to floating point
3986 so that the resulting value does not suffer from catastrophic
3987 integer truncation. For example, on a 64-bit host (* 4
3988 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3989 Do not rely on undefined behavior after integer overflow.
3990
de883a70
PE
3991 merge count_size_as_multibyte, parse_str_to_multibyte
3992 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3993 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3994 Check for integer overflow.
3995 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3996 since it's now a duplicate of the other. This is more of
3997 a character than a buffer op, so better that it's in character.c.
3998 * fns.c, print.c: Adjust to above changes.
3999
2ff916cb
PE
40002011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4001
4002 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4003
f1b54466
PE
40042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4005
fb1ac845
PE
4006 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4007 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4008 (x_clipboard_manager_save): Now static.
4009 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4010
f1b54466
PE
4011 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4012 (crypto_hash_function): Now static.
4013 Fix pointer signedness problems. Avoid unnecessary initializations.
4014
a9f737ee
CY
40152011-05-27 Chong Yidong <cyd@stupidchicken.com>
4016
4017 * termhooks.h (Vselection_alist): Make it terminal-local.
4018
4019 * terminal.c (create_terminal): Initialize it.
4020
4021 * xselect.c: Support for clipboard managers.
4022 (Vselection_alist): Move to termhooks.h as terminal-local var.
4023 (LOCAL_SELECTION): New macro.
4024 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4025 (symbol_to_x_atom): Remove gratuitous arg.
4026 (x_handle_selection_request, lisp_data_to_selection_data)
4027 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4028 (x_own_selection, x_get_local_selection, x_convert_selection):
4029 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4030 (some_frame_on_display): Delete unused function.
4031 (Fx_own_selection_internal, Fx_get_selection_internal)
4032 (Fx_disown_selection_internal, Fx_selection_owner_p)
4033 (Fx_selection_exists_p): New optional frame arg.
4034 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4035 (x_handle_selection_clear): Don't treat other terminals with the
4036 same keyboard specially. Use the terminal-local Vselection_alist.
4037 (x_clear_frame_selections): Use Frun_hook_with_args.
4038
4039 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4040
4041 * xterm.h: Add support for those atoms.
4042
e067f0c1
CY
40432011-05-26 Chong Yidong <cyd@stupidchicken.com>
4044
4045 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4046 (converted_selections, conversion_fail_tag): New global variables.
4047 (x_selection_request_lisp_error): Free the above.
4048 (x_get_local_selection): Remove unnecessary code.
4049 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4050 of converted selections stored in converted_selections.
4051 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4052 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4053 (x_convert_selection): New function.
4054 (x_handle_selection_event): Simplify.
4055 (x_get_foreign_selection): Don't ignore incoming requests while
4056 waiting for an answer; this will fail when we implement
4057 SAVE_TARGETS, and seems unnecessary anyway.
4058 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4059 (Vx_sent_selection_functions): Doc fix.
4060
0f4aebc0
LL
40612011-05-26 Leo Liu <sdl.web@gmail.com>
4062
4063 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4064
e61124cd
YM
40652011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4066
4067 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4068
4069 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4070 for fringe update if it has periodic bitmap.
ac389d0c 4071 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4072 and fringe_bitmap_periodic_p.
4073
4074 * fringe.c (get_fringe_bitmap_data): New function.
4075 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4076 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4077 row. Mark glyph row for fringe update if periodicity changed.
4078
4079 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4080 for fringe update unless it has periodic bitmap.
4081
f16d9837
KH
40822011-05-25 Kenichi Handa <handa@m17n.org>
4083
4084 * xdisp.c (get_next_display_element): Set correct it->face_id for
4085 a static composition.
4086
e1b90ef6
LL
40872011-05-24 Leo Liu <sdl.web@gmail.com>
4088
4089 * deps.mk (fns.o):
4090 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4091
4092 * fns.c (crypto_hash_function, Fsha1): New function.
4093 (Fmd5): Use crypto_hash_function.
4094 (syms_of_fns): Add Ssha1.
4095
7400048f
PE
40962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 * gnutls.c: Remove unused macros.
4099 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4100 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4101 Remove macros that are defined and never used.
4102 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4103
abb71cf4
CY
41042011-05-22 Chong Yidong <cyd@stupidchicken.com>
4105
4106 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4107 (Fx_get_selection_internal): Minor cleanup.
4108 (Fx_own_selection_internal): Rename arguments for consistency with
4109 select.el.
4110
6307db39
PE
41112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4114
f3d4e0a4
CY
41152011-05-22 Chong Yidong <cyd@stupidchicken.com>
4116
4117 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4118
4d8ade89
YM
41192011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4120
4121 * dispnew.c (scrolling_window): Don't exclude the case that the
4122 last enabled row in the desired matrix touches the bottom boundary.
4123
32078c8d
GM
41242011-05-21 Glenn Morris <rgm@gnu.org>
4125
4126 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4127 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4128 and add some more files.
32078c8d 4129
7285dc67
EZ
41302011-05-20 Eli Zaretskii <eliz@gnu.org>
4131
4132 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4133 report_file_error introduced by the change from 2011-05-07.
4134
89d1bd22
PE
41352011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4136
4137 * systime.h (Time): Define only if emacs is defined.
4138 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4139 where the include path doesn't have X11/X.h by default. See
4140 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4141
e23640bb 41422011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4143
4144 * composite.c (find_automatic_composition): Fix previous change.
4145
b9704ad9
GM
41462011-05-20 Glenn Morris <rgm@gnu.org>
4147
4148 * lisp.mk: New file, split from Makefile.in.
4149 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4150 (shortlisp): Remove.
4151 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4152
4a720484
GM
41532011-05-19 Glenn Morris <rgm@gnu.org>
4154
4155 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4156 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4157 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4158 (lisp): Set the order to that of loadup.el.
4159 (shortlisp): Make it a copy of $lisp.
4160 (SOME_MACHINE_LISP): Remove.
4161 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4162 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4163
a28d4396
KH
41642011-05-18 Kenichi Handa <handa@m17n.org>
4165
4166 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4167 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4168 (find_automatic_composition): Mostly rewrite for efficiency.
4169
a2b1fa8e
JB
41702011-05-18 Juanma Barranquero <lekktu@gmail.com>
4171
4172 * makefile.w32-in: Update dependencies.
4173
8e1f5610
CS
41742011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4175
4176 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4177 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4178
7025ee00 41792011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4180
cdfa6eab
PE
4181 Fix some integer overflow issues, such as string length overflow.
4182
06d6db33
PE
4183 * insdel.c (count_size_as_multibyte): Check for string overflow.
4184
2b4560a8
PE
4185 * character.c (lisp_string_width): Check for string overflow.
4186 Use EMACS_INT, not int, for string indexes and lengths; in
4187 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4188 the resulting string length overflows an EMACS_INT; instead,
4189 report a string overflow if no precision given. When checking for
4190 precision exhaustion, use a check that cannot possibly have
4191 integer overflow. (Bug#8675)
4192 * character.h (lisp_string_width): Adjust to new signature.
4193
cb93f9be
PE
4194 * alloc.c (string_overflow): New function.
4195 (Fmake_string): Use it. This doesn't change behavior, but saves
4196 a few bytes and will simplify future changes.
4197 * character.c (string_escape_byte8): Likewise.
4198 * lisp.h (string_overflow): New decl.
4199
1a1f3366
PE
4200 Fixups, following up to the user-interface timestamp change.
4201 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4202 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4203 * msdos.c (mouse_get_pos): Likewise.
4204 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4205 * w32gui.h (Time): Define by including "systime.h" rather than by
4206 declaring it ourselves. (Bug#8664)
4207
d4e3e4d3
PE
4208 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4209 * image.c (clear_image_cache): Likewise.
4210
f6a24d19
PE
4211 * term.c (term_mouse_position): Don't assume time_t wraparound.
4212
08dc5ae6
PE
4213 Be more systematic about user-interface timestamps.
4214 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4215 and sometimes 'EMACS_UINT', to represent these timestamps.
4216 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4217 This makes the code easier to follow, and makes it easier to catch
4218 integer overflow bugs such as Bug#8664.
4219 * frame.c (Fmouse_position, Fmouse_pixel_position):
4220 Use Time, not unsigned long, for user-interface timestamps.
4221 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4222 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4223 * keyboard.h (last_event_timestamp): Likewise.
4224 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4225 * menu.h (xmenu_show): Likewise.
4226 * term.c (term_mouse_position): Likewise.
4227 * termhooks.h (struct input_event.timestamp): Likewise.
4228 (struct terminal.mouse_position_hook): Likewise.
4229 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4230 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4231 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4232 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4233 what it was before.
4234 * menu.h, termhooks.h: Include "systime.h", for Time.
4235
8e55734a
PE
4236 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4237 Don't assume that the difference between two unsigned long values
4238 can fit into an integer. At this point, we know button_down_time
4239 <= event->timestamp, so the difference must be nonnegative, so
4240 there's no need to cast the result if double-click-time is
4241 nonnegative, as it should be; check that it's nonnegative, just in
4242 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4243 apart (about 25 days). (Bug#8664)
8e55734a 4244
841f1b75 4245 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4246 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4247
3e26f69c
PE
4248 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4249 that always fit in int. Use a sentinel instead of a counter, to
4250 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4251 * frame.h (struct frame): Use int for menu_bar_items_used
4252 instead of EMACS_INT, since it always fits in int.
3e26f69c 4253
5cc152c0
PE
4254 * menu.c (grow_menu_items): Check for int overflow.
4255
d89eb65e
PE
4256 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4257
5235bd3e
PE
4258 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4259 Before, the code was not consistent. These values cannot exceed
4260 2**31 - 1 so there's no need to make them unsigned.
4261 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4262 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4263 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4264 as modifiers.
4265 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4266
bc827e23
PE
4267 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4268 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4269 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4270 presumably because the widths might not match.
4271
78eb494e
PE
4272 * window.c (size_window): Avoid needless test at loop start.
4273
04f2d78b
CB
42742011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4275
4276 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4277
d2fc7e3d 42782011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4279
4280 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4281
d2fc7e3d 42822011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4283
4284 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4285 `width' to `bar_area_x' and `bar_area_width', respectively.
4286 (x_scroll_run): Take account of fringe background extension.
4287
04f2d78b
CB
4288 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4289 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4290 `bar_area_width', respectively.
4291 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4292 background extension.
4293
79b70037
GM
42942011-05-10 Jim Meyering <meyering@redhat.com>
4295
4296 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4297
2f142cc5
JB
42982011-05-10 Juanma Barranquero <lekktu@gmail.com>
4299
4300 * image.c (Finit_image_library): Return t for built-in image types,
4301 like pbm and xbm. (Bug#8640)
4302
57679c86
AS
43032011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4304
4305 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4306
888c9e86
EZ
43072011-05-07 Eli Zaretskii <eliz@gnu.org>
4308
b0512a1d
EZ
4309 * w32console.c (Fset_screen_color): Doc fix.
4310 (Fget_screen_color): New function.
4311 (syms_of_ntterm): Defsubr it.
4312
7285dc67
EZ
4313 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4314 unlink the temporary file if Fcall_process didn't create it in the
4315 first place.
4316 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4317 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4318 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4319 cue to call_process_cleanup not to close that handle.
4320
4d3fcc8e
BK
43212011-05-07 Ben Key <bkey76@gmail.com>
4322
4323 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4324 one of two shell specific rules, either bootstrap-temacs-CMD or
4325 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4326 to the previous implementation of the bootstrap-temacs rule.
4327 The bootstrap-temacs-CMD rule is similar to the previous
4328 implementation of the bootstrap-temacs rule except that it
4329 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4330 variable.
4331
4332 These changes, along with some changes to nt/configure.bat,
4333 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4334 earlier fix to add support for --cflags and --ldflags options
4335 that include quotes so that it works whether make uses cmd or
4336 sh as the shell.
4337
b4289b64
MA
43382011-05-06 Michael Albinus <michael.albinus@gmx.de>
4339
4340 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4341 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4342 is a constant.
4343 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4344 a string. Handle both cases.
4345 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4346 (Fdbus_register_method): Use Qinvalid_function.
4347
af4c0e28
JB
43482011-05-06 Juanma Barranquero <lekktu@gmail.com>
4349
4350 * makefile.w32-in: Update dependencies.
4351 (LISP_H): Add inttypes.h and stdin.h.
4352 (PROCESS_H): Add unistd.h.
4353
c51453d9
EZ
43542011-05-06 Eli Zaretskii <eliz@gnu.org>
4355
4356 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4357 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4358
8ff0ac3c 43592011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4360
4c4b566b
PE
4361 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4362
aab2b9b5
PE
4363 * term.c (vfatal): Remove stray call to va_end.
4364 It's not needed and the C Standard doesn't allow it here anyway.
4365
c378da0b
PE
4366 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4367 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4368
288b08c7
PE
4369 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4370 bytes.
4371
e3601888
PE
4372 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4373
db6c0e74
PE
4374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4375
dd5963ea
PE
4376 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4377
88c9450f
PE
4378 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4379
2f9442b8
PE
4380 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4381
c032b5f8
PE
4382 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4383 * charset.c (Fdefine_charset_internal): Don't initialize
4384 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4385 32-bit int (Bug#8600).
a108c10b
PE
4386
4387 * lread.c (read_integer): Be more consistent with string-to-number.
4388 Use string_to_number to do the actual conversion; this avoids
4389 rounding errors and fixes some other screwups. Without this fix,
4390 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4391 (digit_to_number): Move earlier, for benefit of read_integer.
4392 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4393 not a digit in any supported base. (Bug#8602)
a108c10b 4394
ad5f9eea
PE
4395 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4396
aec1708a
PE
4397 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4398 to match comment at start of function. This also removes a
4399 GCC warning about overflow in a 32+64-bit port.
4400
47be4ab5
PE
4401 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4402
371cac43
PE
4403 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4404 Reported by Stefan Monnier in
4405 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4406 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4407 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4408
d01a7826
PE
4409 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4410 (EMACS_UINTPTR): Likewise, with uintptr_t.
4411
7fd47d5c
PE
4412 * lisp.h: Prefer 64-bit EMACS_INT if available.
4413 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4414 on 32-bit hosts that have 64-bit int, so that they can access
4415 large files.
122b0c86
PE
4416 However, temporarily disable this change unless the temporary
4417 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4418
8727937b
PE
4419 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4420
8ac068ac
PE
4421 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4422 This removes an assumption that EMACS_INT and long are the same
4423 width as pointers. The assumption is true for Emacs porting targets
4424 now, but we want to make other targets possible.
4425 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4426 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4427 In the rest of the code, change types of integers that hold casted
4428 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4429 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4430 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4431 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4432 No need to cast type when ORing.
4433 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4434 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4435 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4436 assume EMACS_INT is the same width as char *.
4437 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4438 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4439 Remove no-longer-needed casts.
4440 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4441 (xg_tool_bar_help_callback, xg_make_tool_item):
4442 Use EMACS_INTPTR to hold an integer
4443 that will be cast to void *; this can avoid a GCC warning
4444 if EMACS_INT is not the same width as void *.
4445 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4446 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4447 (current_message_1, set_message_1):
4448 Use a local to convert to proper width without a cast.
4449 * xmenu.c (dialog_selection_callback): Likewise.
4450
ede49d71
PE
4451 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4452 Also, don't assume VALBITS / RAND_BITS is less than 5,
4453 and don't rely on undefined behavior when shifting a 1 left into
4454 the sign bit.
4455 * lisp.h (get_random): Change signature to match.
4456
2f30ecd0
PE
4457 * lread.c (hash_string): Use size_t, not int, for hash computation.
4458 Normally we prefer signed values; but hashing is special, because
4459 it's better to use unsigned division on hash table sizes so that
4460 the remainder is nonnegative. Also, size_t is the natural width
4461 for hashing into memory. The previous code used 'int', which doesn't
4462 retain enough info to hash well into very large tables.
4463 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4464
2a866e7b
PE
4465 * dbusbind.c: Don't possibly lose pointer info when converting.
4466 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4467 Use XPNTR rather than XHASH, so that the high-order bits of
4468 the pointer aren't lost when converting through void *.
4469
51639eac
PE
4470 * eval.c (Fautoload): Don't double-shift a pointer.
4471
92394119
PE
4472 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4473
dbdb9a7c
JB
44742011-05-06 Juanma Barranquero <lekktu@gmail.com>
4475
4476 * gnutls.c (DEF_GNUTLS_FN):
4477 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4478
db7a0b4f
AS
44792011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4480
4481 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4482 marker. (Bug#8610)
4483
f7ff1b0f 44842011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4485
4486 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4487 New version that can reserve upto 2GB of heap space.
4488
f7ff1b0f 44892011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4490
4491 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4492
639c109b
TZ
44932011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4494
4495 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4496 `gnutls_certificate_set_x509_key_file'.
4497
d2127135
JB
44982011-05-05 Juanma Barranquero <lekktu@gmail.com>
4499
4500 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4501 Update dependencies.
4502
e968f4f3
JB
45032011-05-04 Juanma Barranquero <lekktu@gmail.com>
4504
4505 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4506 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4507 Remove unused parameter `fildes'.
4508 * process.c (read_process_output, send_process): Don't pass it.
4509
84d358f0
JB
45102011-05-04 Juanma Barranquero <lekktu@gmail.com>
4511
4512 Fix previous change: the library cache is defined in w32.c.
4513 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4514 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4515
0898ca10
JB
45162011-05-04 Juanma Barranquero <lekktu@gmail.com>
4517
4518 Implement dynamic loading of GnuTLS on Windows.
4519
4520 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4521 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4522 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4523 Declare.
4524
4525 * gnutls.c (Qgnutls_dll): Define.
4526 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4527 (gnutls_*): Declare function pointers.
4528 (init_gnutls_functions): New function to initialize function pointers.
4529 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4530 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4531 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4532 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4533 (emacs_gnutls_write, emacs_gnutls_read)
4534 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4535 (Fgnutls_available_p): New function.
4536 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4537 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4538 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4539
4540 * image.c: Include w32.h.
4541 (Vimage_type_cache): Delete.
4542 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4543 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4544 (w32_delayed_load): Move to w32.c.
4545
4546 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4547
4548 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4549 (w32_delayed_load): Move from image.c. When loading a library, record
4550 its filename in the :loaded-from property of the library id.
4551 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4552 Initialize and staticpro them.
4553 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4554
4555 * process.c: Include lisp.h before w32.h, not after.
4556 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4557 instead of gnutls_record_check_pending.
4558
4559 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4560
ff4de4aa
TZ
45612011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4562
4563 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4564 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4565 as passed in.
4566
abe95abb
JD
45672011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4568
4569 * xterm.c (x_set_frame_alpha): Do not set property on anything
4570 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4571
e16e55d4
JB
45722011-05-02 Juanma Barranquero <lekktu@gmail.com>
4573
4574 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4575
bafcf6a5
JB
45762011-05-02 Juanma Barranquero <lekktu@gmail.com>
4577
4578 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4579 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4580 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4581 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4582 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4583 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4584 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4585 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4586 (Qgnutls_bootprop_callbacks_verify): Make static.
4587
e7a6747f
AS
45882011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4589
19ed11ba
AS
4590 * callproc.c: Indentation fixup.
4591
e7a6747f 4592 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4593 (wait_for_termination, interruptible_wait_for_termination):
4594 Move after wait_for_termination_1.
e7a6747f 4595
1ef14cb4
LMI
45962011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4597
4598 * sysdep.c (interruptible_wait_for_termination): New function
4599 which is like wait_for_termination, but allows keyboard
4600 interruptions.
4601
4602 * callproc.c (Fcall_process): Add (:file "file") as an option for
4603 the STDOUT buffer.
4604 (Fcall_process_region): Ditto.
4605
330d880c
EZ
46062011-04-30 Eli Zaretskii <eliz@gnu.org>
4607
8db90b73
EZ
4608 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4609 rather than `XVECTOR (FOO)->size'.
4610
330d880c
EZ
4611 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4612 inttypes.h, as a gnulib replacement is used if it not available in
4613 system headers.
4614
15cbd324
EZ
46152011-04-21 Eli Zaretskii <eliz@gnu.org>
4616
4617 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4618 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4619 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4620
4621 * coding.c (coding_alloc_by_realloc): Error out if destination
4622 will grow beyond MOST_POSITIVE_FIXNUM.
4623 (decode_coding_emacs_mule): Abort if there isn't enough place in
4624 charbuf for the composition carryover bytes. Reserve an extra
4625 space for up to 2 characters produced in a loop.
4626 (decode_coding_iso_2022): Abort if there isn't enough place in
4627 charbuf for the composition carryover bytes.
4628
46292011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4630
ae940cca
EZ
4631 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4632 aborting when %lld or %lll format is passed.
4633 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4634 %llo or %llx format is passed. (Bug#8545)
4635
03ab8921
EZ
4636 * window.c (window_scroll_line_based): Use a marker instead of
4637 simple variables to record original value of point. (Bug#7952)
4638
afda1437
EZ
4639 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4640 produced by %s or %c overflows available buffer space. (Bug#8545)
4641
f76dee0c
PE
46422011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4643
4644 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4645 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4646
fdc5744d
JB
46472011-04-28 Juanma Barranquero <lekktu@gmail.com>
4648
4649 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4650
638f053a
JB
46512011-04-28 Juanma Barranquero <lekktu@gmail.com>
4652
4653 * keyboard.c (Qdelayed_warnings_hook): Define.
4654 (command_loop_1): Run `delayed-warnings-hook'
4655 if Vdelayed_warnings_list is non-nil.
4656 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4657 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4658
d178f871
EZ
46592011-04-28 Eli Zaretskii <eliz@gnu.org>
4660
4661 * doprnt.c (doprnt): Don't return value smaller than the buffer
4662 size if the message was truncated. (Bug#8545).
4663
b124fd93
JB
46642011-04-28 Juanma Barranquero <lekktu@gmail.com>
4665
4666 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4667 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4668
e810457d
PE
46692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4670
4671 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4672
ea51cceb
JB
46732011-04-27 Juanma Barranquero <lekktu@gmail.com>
4674
4675 * makefile.w32-in: Update dependencies.
4676
94dcfacf
EZ
46772011-04-27 Eli Zaretskii <eliz@gnu.org>
4678
4679 Improve `doprnt' and its usage. (Bug#8545)
4680 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4681 `format_end'. Remove support for %l as a conversion specifier.
4682 Don't use xrealloc. Improve diagnostics when the %l size modifier
4683 is used. Update the commentary.
4684
4685 * eval.c (verror): Simplify calculation of size_t.
4686
4687 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4688 messages.
4689
f61f41d7
PE
46902011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4691
4692 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4693 change.
4694
96fb4434
PE
46952011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4696
4697 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4698 This makes this file independent of the recent pseudovector change.
4699
671875da 47002011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4701
69e9b5a3
PE
4702 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4703
b5f869a7 4704 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4705 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4706 Remove unused local.
c8926152 4707 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4708
841a1577 4709 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4710 GCC 4.6.0 optimizes based on type-based alias analysis.
4711 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4712 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4713 != &v->size, and therefore "v->size = 1; b->size = 2; return
4714 v->size;" must therefore return 1. This assumption is incorrect
4715 for Emacs, since it type-puns struct Lisp_Vector * with many other
4716 types. To fix this problem, this patch adds a new type struct
f904488f 4717 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4718 and pseudovectors, and helps optimizing compilers not get fooled
4719 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4720 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4721 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4722 the size member.
eab3844f
PE
4723 (XSETPVECTYPE): Rewrite in terms of new macro.
4724 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4725 This is a bit clearer, and further avoids the possibility of
4726 undesirable aliasing.
4727 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4728 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4729 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4730 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4731 (ASIZE): Now uses header.size rather than size.
4732 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4733 to avoid the hassle of writing XVECTOR (foo)->header.size.
4734 (struct vectorlike_header): New type.
eab3844f
PE
4735 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4736 object, to help avoid aliasing.
4737 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4738 (SUBRP): Likewise, since Lisp_Subr is a special case.
4739 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4740 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4741 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4742 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4743 changed to be "header.size" and "header.next".
4744 * buffer.h (struct buffer): Likewise.
4745 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4746 * frame.h (struct frame): Likewise.
4747 * process.h (struct Lisp_Process): Likewise.
4748 * termhooks.h (struct terminal): Likewise.
4749 * window.c (struct save_window_data, struct saved_window): Likewise.
4750 * window.h (struct window): Likewise.
4751 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4752 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4753 * buffer.c (init_buffer_once): Likewise.
4754 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4755 special case.
4756 * process.c (Fformat_network_address): Use local var for size,
4757 for brevity.
4758
0df1eac5
PE
4759 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4760
847ab9d1 4761 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4762 * data.c (atof): Remove decl; no longer used or needed.
4763 (digit_to_number): Move to lread.c.
4764 (Fstring_to_number): Use new string_to_number function, to be
4765 consistent with how the Lisp reader treats infinities and NaNs.
4766 Do not assume that floating-point numbers represent EMACS_INT
4767 without losing information; this is not true on most 64-bit hosts.
4768 Avoid double-rounding errors, by insisting on integers when
4769 parsing non-base-10 numbers, as the documentation specifies.
4770 * lisp.h (string_to_number): New decl, replacing ...
4771 (isfloat_string): Remove.
bc0a5c13 4772 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4773 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4774 appears to have been a coding error. Similarly, do not accept
4775 strings like +-1e0 as floating point numbers. Do not report
4776 overflow for integer overflows unless the base is not 10 which
4777 means we have no simple and reliable way to continue.
4778 Break out the floating-point parsing into a new
4779 function string_to_number, so that Fstring_to_number parses
4780 floating point numbers consistently with the Lisp reader.
04f2d78b 4781 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4782 (E_CHAR, EXP_INT): Remove, replacing with ...
4783 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4784 (string_to_number): New function, replacing isfloat_string.
4785 This function checks for valid syntax and produces the resulting
4786 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4787 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4788 so that overflow for non-base-10 numbers is reported only when
4789 there's no portable and simple way to convert to floating point.
452f4150 4790
67769ffc
PE
4791 * textprop.c (set_text_properties_1): Rewrite for clarity,
4792 and to avoid GCC warning about integer overflow.
4793
c20db43f
PE
4794 * intervals.h (struct interval): Use EMACS_INT for members
4795 where EMACS_UINT might cause problems. See
4796 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4797 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4798 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4799 All uses changed.
37aa2f85
PE
4800 (offset_intervals): Tell GCC not to worry about length overflow
4801 when negating a negative length.
c20db43f 4802
2538aa2f
PE
4803 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4804 (overrun_check_free): Likewise.
4805
f2d3008d
PE
4806 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4807 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4808 word size.
4809
ec8df744
PE
4810 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4811 (gnutls_make_error): Rename local to avoid shadowing.
4812 (gnutls_emacs_global_deinit): ifdef out; not used.
4813 (Fgnutls_boot): Use const for pointer to readonly storage.
4814 Comment out unused local. Fix pointer signedness problems.
4815
640ee02d
PE
4816 * lread.c (openp): Don't stuff size_t into an 'int'.
4817 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4818 about possible signed overflow.
4819
6048fb2a
PE
4820 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4821 (GDK_KEY_g): Don't define if already defined.
4822 (xg_prepare_tooltip): Avoid pointer signedness problem.
4823 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4824
fa3c87e1
PE
4825 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4826 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4827
2172544b
PE
4828 * xfns.c (Fx_window_property): Simplify a bit,
4829 to make a bit faster and to avoid GCC 4.6.0 warning.
4830 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4831
9b821a21
PE
4832 * fns.c (internal_equal): Don't assume size_t fits in int.
4833
3c616cfa
PE
4834 * alloc.c (compact_small_strings): Tighten assertion a little.
4835
c2982e87
PE
4836 Replace pEd with more-general pI, and fix some printf arg casts.
4837 * lisp.h (pI): New macro, generalizing old pEd macro to other
4838 conversion specifiers. For example, use "...%"pI"d..." rather
4839 than "...%"pEd"...".
4840 (pEd): Remove. All uses replaced with similar uses of pI.
4841 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4842 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4843 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4844 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4845 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4846 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4847 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4848 64-bit hosts.
4849 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4850 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4851 * print.c (safe_debug_print, print_object): Likewise.
4852 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4853 to int.
6f04d126
PE
4854 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4855 avoiding the 0 flag, which is not portable.
c2982e87
PE
4856 * process.c (Fmake_network_process): Use pI to avoid cast.
4857 * region-cache.c (pp_cache): Likewise.
4858 * xdisp.c (decode_mode_spec): Likewise.
4859 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4860 behavior on 64-bit hosts with printf arg.
6f04d126 4861 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4862 (x_stop_queuing_selection_requests): Likewise.
4863 (x_get_window_property): Don't truncate byte count to an 'int'
4864 when tracing.
0b432f21 4865
5e073ec7
PE
4866 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4867 here, since it parses constructs like leading '-' and spaces,
4868 which are not wanted; and it overflows with large numbers.
4869 Instead, simply match F[0-9]+, which is what is wanted anyway.
4870
36372bf9
PE
4871 * alloc.c: Remove unportable assumptions about struct layout.
4872 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4873 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4874 (allocate_vectorlike, make_pure_vector): Use the new macros,
4875 plus offsetof, to remove unportable assumptions about struct layout.
4876 These assumptions hold on all porting targets that I know of, but
4877 they are not guaranteed, they're easy to remove, and removing them
4878 makes further changes easier.
4879
0b432f21
PE
4880 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4881 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4882 (string_overrun_cookie): Now const. Use initializers that
4883 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4884 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4885 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4886 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4887 multiple of sizeof (EMACS_INT); it need not be, if
4888 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4889 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4890
895009e1
JB
48912011-04-26 Juanma Barranquero <lekktu@gmail.com>
4892
4893 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4894
6a7a1b0b
TZ
48952011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4896
4897 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4898 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4899 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4900
841a1577 49012011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4902
4903 * lisp.h (Qdebug): List symbol.
895009e1 4904 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4905 * keyboard.c (debug-on-event): New variable.
4906 (handle_user_signal): Break into debugger when debug-on-event
4907 matches the current signal symbol.
4908
f2d3ba6f
DN
49092011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4910
4911 * alloc.c (check_sblock, check_string_bytes)
4912 (check_string_free_list): Convert to standard C.
4913
42ce4c63
TZ
49142011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4915
4916 * w32.c (emacs_gnutls_push): Fix typo.
4917
825cd63c
EZ
49182011-04-25 Eli Zaretskii <eliz@gnu.org>
4919
fb11d64d
EZ
4920 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4921 "cast to pointer from integer of different size".
4922
825cd63c
EZ
4923 Improve doprnt and its use in verror. (Bug#8545)
4924 * doprnt.c (doprnt): Document the set of format control sequences
4925 supported by the function. Use SAFE_ALLOCA instead of always
4926 using `alloca'.
4927
4928 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4929 is one byte too soon. Don't use xrealloc; instead xfree and
4930 xmalloc anew.
4931
e061a11b
TZ
49322011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4933
4934 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4935 callbacks stage.
4936
4937 * gnutls.c: Renamed global_initialized to
4938 gnutls_global_initialized. Added internals for the
4939 :verify-hostname-error, :verify-error, and :verify-flags
4940 parameters of `gnutls-boot' and documented those parameters in the
4941 docstring. Start callback support.
9173deec
JB
4942 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4943 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4944 on error. Return error code.
e061a11b
TZ
4945 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4946 (emacs_gnutls_read): Likewise.
4947 (Fgnutls_boot): Return handshake error code.
4948 (emacs_gnutls_handle_error): New function.
4949 (wsaerror_to_errno): Likewise.
4950
4951 * w32.h (emacs_gnutls_pull): Add prototype.
4952 (emacs_gnutls_push): Likewise.
4953
4954 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4955 (emacs_gnutls_push): Likewise.
4956
49572011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4958
4959 * process.c (wait_reading_process_output): Check if GnuTLS
4960 buffered some data internally if no FDs are set for TLS
4961 connections.
4962
4963 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4964 (LIBS): Link to USER_LIBS.
4965 ($(BLD)/gnutls.$(0)): New target.
4966
fa6996bc
EZ
49672011-04-24 Eli Zaretskii <eliz@gnu.org>
4968
eb35682e
EZ
4969 * xdisp.c (handle_single_display_spec): Rename the
4970 display_replaced_before_p argument into display_replaced_p, to
4971 make it consistent with the commentary. Fix typos in the
4972 commentary.
4973
e2ad650c
EZ
4974 * textprop.c (syms_of_textprop): Remove dead code.
4975 (copy_text_properties): Delete obsolete commentary about an
4976 interface that was deleted long ago. Fix typos in the description
4977 of arguments.
4978
1b2de274
EZ
4979 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4980 to changes in oldXMenu/XMenu.h from 2011-04-16.
4981 <menu_help_message, prev_menu_help_message>: Constify.
4982 (IT_menu_make_room): menu->help_text is now `const char **';
4983 adjust.
4984
4985 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4986 to changes in oldXMenu/XMenu.h from 2011-04-16.
4987 (struct XMenu): Declare `help_text' `const char **'.
4988
4989 * xfaces.c <Qunspecified>: Make extern again.
4990
4991 * syntax.c: Include sys/types.h before including regex.h, as
4992 required by Posix.
4993
762b15be
EZ
4994 * doc.c (get_doc_string): Improve the format passed to `error'.
4995
4996 * doprnt.c (doprnt): Improve commentary.
4997
4998 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4999
5000 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5001 them with etags.
5002
f1052e5d
EZ
5003 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5004 changes in globals.h immediately force recompilation.
762b15be
EZ
5005 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5006 $(CURDIR)/s/ms-w32.h.
5007 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5008
fa6996bc
EZ
5009 * character.c (Fchar_direction): Function deleted.
5010 (syms_of_character): Don't defsubr it.
5011 <char-direction-table>: Deleted.
5012
e6c3da20
EZ
50132011-04-23 Eli Zaretskii <eliz@gnu.org>
5014
5015 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5016 * doprnt.c: Include limits.h.
5017 (SIZE_MAX): New macro.
04f2d78b
CB
5018 (doprnt): Return a size_t value. 2nd arg is now size_t.
5019 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5020 Improve overflow protection. Support `l' modifier for integer
5021 conversions. Support %l conversion. Don't assume an EMACS_INT
5022 argument for integer conversions and for %c.
5023
5024 * lisp.h (doprnt): Restore prototype.
5025
5026 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5027 $(SRC)/character.h.
5028
5029 * Makefile.in (base_obj): Add back doprnt.o.
5030
5031 * deps.mk (doprnt.o): Add back prerequisites.
5032 (callint.o): Depend on character.h.
5033
5034 * eval.c (internal_lisp_condition_case): Include the handler
5035 representation in the error message.
5036 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5037 when breaking from the loop.
5038
5039 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5040
5041 * callint.c (Fcall_interactively): When displaying error message
5042 about invalid control letter, pass the character's codepoint, not
5043 a pointer to its multibyte form. Improve display of the character
5044 in octal and display also its hex code.
5045
5046 * character.c (char_string): Use %x to display the (unsigned)
5047 codepoint of an invalid character, to avoid displaying a bogus
5048 negative value.
5049
5050 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5051 `error', not SYMBOL_NAME itself.
5052
5053 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5054 character arguments to `error'.
5055
5056 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5057 to `error' in error message about FINAL_CHAR argument. Make sure
5058 FINAL_CHAR is a character, and use %c when it is passed as
5059 argument to `error'.
5060
4ffd0d6b 50612011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5062
5063 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5064
5065 * w32.c: Include <time.h>.
5066 (sys_localtime): New function.
5067
4ffd0d6b 50682011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5069
5070 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5071
4ffd0d6b 5072 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5073
4ffd0d6b 50742011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5075
4ffd0d6b
GM
5076 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5077 zombies (Bug#8467).
aac0c6e3 5078
04c56954
EZ
50792011-04-19 Eli Zaretskii <eliz@gnu.org>
5080
5081 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5082 gl_state.e_property when gl_state.object is Qt.
5083
5084 * insdel.c (make_gap_larger): Remove limitation of buffer size
5085 to <= INT_MAX.
5086
16a43933
CY
50872011-04-18 Chong Yidong <cyd@stupidchicken.com>
5088
5089 * xdisp.c (lookup_glyphless_char_display)
5090 (produce_glyphless_glyph): Handle cons cell entry in
5091 glyphless-char-display.
5092 (Vglyphless_char_display): Document it.
5093
5094 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5095 glyphless-char-display.
5096
4581706e
CY
50972011-04-17 Chong Yidong <cyd@stupidchicken.com>
5098
5099 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5100
5101 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5102
5103 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5104 definition for no-X builds.
5105
4887c6e2 51062011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5107
fd35b6f9
PE
5108 Static checks with GCC 4.6.0 and non-default toolkits.
5109
5c1ccb01
PE
5110 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5111
006c5daa
PE
5112 * process.c (keyboard_bit_set): Define only if SIGIO.
5113 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5114 (send_process): Repair possible setjmp clobbering.
5115
efc736d3
PE
5116 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5117
4e2fe2e6
PE
5118 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5119
f97334a2
PE
5120 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5121
4e75f29d
PE
5122 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5123 Define only if needed.
5124
90efadd1
PE
5125 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5126 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5127 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5128
3c647824
PE
5129 * dispextern.h (struct redisplay_interface): Rename param
5130 to avoid shadowing.
e264f262 5131 * termhooks.h (struct terminal): Likewise.
761383f4 5132 * xterm.c (xembed_send_message): Likewise.
3c647824 5133
b58c5c4a
PE
5134 * insdel.c (make_gap_smaller): Define only if
5135 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5136
cad59032
PE
5137 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5138 it.
5139
c339dc2e
PE
5140 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5141 so that we aren't warned about unused symbols.
5142
91a3e27b
PE
5143 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5144
399c71d3 5145 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5146
8ffc96f5
PE
5147 * xfns.c (x_real_positions): Mark locals as initialized.
5148
eef9bc79
PE
5149 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5150
098db9dd
PE
5151 * xterm.c: Fix problems found by static analysis with other toolkits.
5152 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5153 (x_dispatch_event): Declare static if USE_GTK, and
5154 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5155 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5156 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5157 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5158 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5159
eb18f6cc
PE
5160 * xmenu.c (menu_help_callback): Pointer type fixes.
5161 Use const pointers when pointing at readonly data. Avoid pointer
5162 signedness clashes.
5163 (FALSE): Remove unused macro.
5164 (update_frame_menubar): Remove unused decl.
5165
1fe72bf8
PE
5166 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5167
60d9e1db
PE
5168 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5169 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5170 (single_menu_item): Rename local to avoid shadowing.
5171
39261c26
PE
5172 * keyboard.c (make_lispy_event): Remove unused local var.
5173
018c5e19
PE
5174 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5175 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5176
63d2b86e
PE
5177 * bitmaps: Change bitmaps from unsigned char back to the X11
5178 compatible char. Avoid the old compiler warnings about
5179 out-of-range initializers by using, for example, '\xab' rather
5180 than 0xab.
5181
aefd87e1
PE
5182 * xgselect.c (xgselect_initialize): Check vs interface
5183 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5184
bf501fb9
PE
5185 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5186
e9829fdf
PE
5187 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5188 to read-only memory.
5189
1086c095
PE
5190 * fns.c (vector): Remove; this old hack is no longer needed.
5191
2baccd04 5192 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5193 Remove unused var.
dde42981 5194 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5195
72391843 5196 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5197
436c16df 5198 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5199 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5200 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5201
92bb796d 5202 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5203 (x_term_init): Remove local to avoid shadowing.
92bb796d 5204
764430a3 5205 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5206
5207 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5208 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5209
d1dfb56c
EZ
52102011-04-16 Eli Zaretskii <eliz@gnu.org>
5211
c4354cb4
EZ
5212 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5213
d1dfb56c
EZ
5214 Fix regex.c, syntax.c and friends for buffers > 2GB.
5215 * syntax.h (struct gl_state_s): Declare character position members
5216 EMACS_INT.
5217
5218 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5219
04f2d78b
CB
5220 * textprop.c (verify_interval_modification, interval_of):
5221 Declare arguments EMACS_INT.
d1dfb56c
EZ
5222
5223 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5224 EMACS_INT.
5225
5226 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5227
5228 * indent.c (Fvertical_motion): Local variable it_start is now
5229 EMACS_INT.
5230
5231 * regex.c (re_match, re_match_2, re_match_2_internal)
5232 (bcmp_translate, regcomp, regexec, print_double_string)
5233 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5234 (re_compile_pattern, re_exec): Declare arguments and local
5235 variables `size_t' and `ssize_t' and return values `regoff_t', as
5236 appropriate.
5237 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5238 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5239 <compile_stack_type>: `size' and `avail' are now `size_t'.
5240
5241 * regex.h <regoff_t>: Use ssize_t, not int.
5242 (re_search, re_search_2, re_match, re_match_2): Arguments that
5243 specify buffer/string position and length are now ssize_t and
5244 size_t. Return type is regoff_t.
5245
613052cd
BK
52462011-04-16 Ben Key <bkey76@gmail.com>
5247
5248 * nsfont.m: Fixed bugs in ns_get_family and
5249 ns_descriptor_to_entity that were caused by using free to
5250 deallocate memory blocks that were allocated by xmalloc (via
5251 xstrdup). This caused Emacs to crash when compiled with
5252 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5253 --enable-checking=xmallocoverrun). xfree is now used to
5254 deallocate these memory blocks.
5255
4170f62f 52562011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5257
71b41406
PE
5258 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5259
9587a89d
PE
5260 emacs_write: Accept and return EMACS_INT for sizes.
5261 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5262 et seq.
5263 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5264 Accept and return EMACS_INT.
5265 (emacs_gnutls_write): Return the number of bytes written on
5266 partial writes.
5267 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5268 (emacs_read, emacs_write): Remove check for negative size, as the
5269 Emacs source code has been audited now.
9587a89d
PE
5270 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5271 (emacs_read, emacs_write): Use it.
273a5f82
PE
5272 * process.c (send_process): Adjust to the new signatures of
5273 emacs_write and emacs_gnutls_write. Do not attempt to store
5274 a byte offset into an 'int'; it might overflow.
9587a89d 5275 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5276
3e047f51
PE
5277 * sound.c: Don't assume sizes fit in 'int'.
5278 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5279 Return EMACS_INT, not int.
3e047f51 5280 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5281 Accept EMACS_INT, not int.
5282 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5283 record read return values.
5284
cc39a9db
BK
52852011-04-15 Ben Key <bkey76@gmail.com>
5286
c9d0ec6d
JB
5287 * keyboard.c (Qundefined): Don't declare static since it is used
5288 in nsfns.m.
5289 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5290 static since they are used in nsfont.m.
cc39a9db 5291
6c60eb9f
SM
52922011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5293
5294 * process.c (Qprocessp): Don't declare static.
5295 * lisp.h (Qprocessp): Declare again.
5296
7990b61a
JB
52972011-04-15 Juanma Barranquero <lekktu@gmail.com>
5298
5299 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5300
5d4cb038
PE
53012011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5302
8bd7b830 5303 Improve C-level modularity by making more things 'static'.
cd64ea1d 5304
e3b27b31
PE
5305 Don't publish debugger-only interfaces to other modules.
5306 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5307 (verify_bytepos, count_markers): Move decls to the only modules
5308 that need them.
5309 * region-cache.h (pp_cache): Likewise.
5310 * window.h (check_all_windows): Likewise.
5311 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5312
5d4cb038
PE
5313 * sysdep.c (croak): Now static, if
5314 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5315 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5316
5317 * alloc.c (refill_memory_reserve): Now static if
5318 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5319 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5320
e87b6180
PE
5321 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5322 Define only if USE_LUCID.
5323
ac64929e
PE
5324 * xrdb.c (x_customization_string, x_rm_string): Now static.
5325
6f37259d
PE
5326 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5327 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5328
1683e3ab
PE
5329 * xdisp.c (draw_row_with_mouse_face): Now static.
5330 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5331
de9c2632
PE
5332 * window.h (check_all_windows): Mark externally visible.
5333
2b96acb7
PE
5334 * window.c (window_deletion_count): Now static.
5335
5336 * undo.c: Make symbols static if they're not exported.
5337 (last_undo_buffer, last_boundary_position, pending_boundary):
5338 Now static.
5339
50436f33
PE
5340 * textprop.c (interval_insert_behind_hooks): Now static.
5341 (interval_insert_in_front_hooks): Likewise.
5342
64520e5c
PE
5343 * term.c: Make symbols static if they're not exported.
5344 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5345 (max_frame_lines, tty_set_terminal_modes):
5346 (tty_reset_terminal_modes, tty_turn_off_highlight):
5347 (get_tty_terminal): Now static.
5348 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5349 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5350 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5351 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5352 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5353
1fa53021
PE
5354 * sysdep.c: Make symbols static if they're not exported.
5355 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5356 Now static.
5357 (sigprocmask_set, full_mask): Remove; unused.
5358 (wait_debugging): Mark as visible.
5359 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5360 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5361
d4b43b22
PE
5362 * syntax.c (syntax_temp): Define only if !__GNUC__.
5363
b7c513d0
PE
5364 * sound.c (current_sound_device, current_sound): Now static.
5365
989b29ad
PE
5366 * search.c (searchbufs, searchbuf_head): Now static.
5367
13a55a78
PE
5368 * scroll.c (scroll_cost): Remove; unused.
5369 * dispextern.h (scroll_cost): Remove decl.
5370
de68a1fc
PE
5371 * region-cache.h (pp_cache): Mark as externally visible.
5372
40ccffa6
PE
5373 * process.c: Make symbols static if they're not exported.
5374 (process_tick, update_tick, create_process, chan_process):
5375 (Vprocess_alist, proc_buffered_char, datagram_access):
5376 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5377 (deactivate_process): Mark defn as static, as well as decl.
5378 * lisp.h (create_process): Remove decl.
5379 * process.h (chan_process, Vprocess_alist): Remove decls.
5380
ad64fc97
PE
5381 * print.c: Make symbols static if they're not exported.
5382 (print_depth, new_backquote_output, being_printed, print_buffer):
5383 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5384 (print_interval, print_number_index, initial_stderr_stream):
5385 Now static.
5386 * lisp.h (Fprinc): Remove decl.
5387 (debug_output_compilation_hack): Mark as externally visible.
5388
adddb265
PE
5389 * sysdep.c (croak): Move decl from here to syssignal.h.
5390 * syssignal.h (croak): Put it here, so the API can be checked when
5391 'croak' is called from dissociate_if_controlling_tty.
5392
1717ede2
PE
5393 * minibuf.c: Make symbols static if they're not exported.
5394 (minibuf_save_list, choose_minibuf_frame): Now static.
5395 * lisp.h (choose_minibuf_frame): Remove decl.
5396
fa5fb2bc
PE
5397 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5398
1e3890d1
PE
5399 * lread.c: Make symbols static if they're not exported.
5400 (read_objects, initial_obarray, oblookup_last_bucket_number):
5401 Now static.
5402 (make_symbol): Remove; unused.
5403 * lisp.h (initial_obarray, make_symbol): Remove decls.
5404
8a1414fa
PE
5405 * keyboard.c: Make symbols static if they're not exported.
5406 (single_kboard, recent_keys_index, total_keys, recent_keys):
5407 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5408 (this_single_command_key_start, echoing, last_auto_save):
5409 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5410 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5411 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5412 (Vlispy_mouse_stem, double_click_count):
5413 Now static.
5414 (force_auto_save_soon): Define only if SIGDANGER.
5415 (ignore_mouse_drag_p): Now static if
5416 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5417 (print_help): Remove; unused.
5418 (stop_character, last_timer_event): Mark as externally visible.
5419 * keyboard.h (ignore_mouse_drag_p): Declare only if
5420 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5421 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5422 * lisp.h (echoing): Remove decl.
5423 (force_auto_save_soon): Declare only if SIGDANGER.
5424 * xdisp.c (redisplay_window): Simplify code, to make it more
5425 obvious that ignore_mouse_drag_p is not accessed if !defined
5426 USE_GTK && !defined HAVE_NS.
5427
93ea6e8f
PE
5428 * intervals.c: Make symbols static if they're not exported.
5429 (merge_properties_sticky, merge_interval_right, delete_interval):
5430 Now static.
5431 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5432
77382fcc
PE
5433 * insdel.c: Make symbols static if they're not exported.
5434 However, leave prepare_to_modify_buffer alone. It's never
5435 called from outside this function, but that appears to be a bug.
5436 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5437 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5438 (adjust_after_replace_noundo): Remove; unused.
5439 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5440 (signal_before_change): Remove decls.
77382fcc 5441
9306c32e
PE
5442 * indent.c (val_compute_motion, val_vmotion): Now static.
5443
cd44d2eb
PE
5444 * image.c: Make symbols static if they're not exported.
5445 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5446 if USE_GTK.
5447 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5448 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5449
ad9a7a06
PE
5450 * fringe.c (standard_bitmaps): Now static.
5451 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5452
81626931
PE
5453 * frame.c: Make symbols static if they're not exported.
5454 (x_report_frame_params, make_terminal_frame): Now static.
5455 (get_frame_param): Now static, unless HAVE_NS.
5456 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5457 (x_get_resource_string): Remove; not used.
5458 * frame.h (make_terminal_frame, x_report_frame_params):
5459 (x_get_resource_string); Remove decls.
5460 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5461 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5462
239f9db9
PE
5463 * font.c, fontset.c: Make symbols static if they're not exported.
5464 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5465 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5466 * font.c (font_close_object): Now static.
5467 * font.h (font_close_object): Remove.
5468 * fontset.c (FONTSET_OBJLIST): Remove.
5469 (free_realized_fontset) #if-0 the body, which does nothing.
5470 (face_suitable_for_char_p): #if-0, as it's never called.
5471 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5472 * xfaces.c (face_at_string_position):
5473 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5474 since 0 is always ASCII.
5475
dfcf3579
PE
5476 * fns.c (weak_hash_tables): Now static.
5477
5045092b
PE
5478 * fileio.c: Make symbols static if they're not exported.
5479 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5480 (Vwrite_region_annotation_buffers): Now static.
5481
57a96f5c
PE
5482 * eval.c: Make symbols static if they're not exported.
5483 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5484 * lisp.h (backtrace_list): Remove decl.
5485
35f08c38
PE
5486 * emacs.c: Make symbols static if they're not exported.
5487 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5488 (fatal_error_code, fatal_error_signal_hook, standard_args):
5489 Now static.
5490 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5491 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5492 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5493 * lisp.h (fatal_error_signal_hook): Remove decl.
5494 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5495
f44bd759
PE
5496 * editfns.c: Move a (normally-unused) function to its only use.
5497 * editfns.c, lisp.h (get_operating_system_release): Remove.
5498 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5499 worth the hassle of breaking this out.
5500
b532497d
PE
5501 * xterm.c: Make symbols static if they're not exported.
5502 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5503 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5504 (x_destroy_window, x_delete_display):
5505 Now static.
5506 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5507 (x_mouse_leave): Remove; unused.
5508 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5509 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5510 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5511 Remove decls.
5512 (x_mouse_leave): Declare only if WINDOWSNT.
5513 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5514 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5515 USE_X_TOOLKIT.
5516
1675728f
PE
5517 * ftxfont.c: Make symbols static if they're not exported.
5518 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5519 HAVE_FREETYPE.
5520 * font.h (ftxfont_driver): Likewise.
5521
e4cebfca
PE
5522 * xfns.c: Make symbols static if they're not exported.
5523 (x_last_font_name, x_display_info_for_name):
5524 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5525 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5526 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5527 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5528 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5529 (last_show_tip_args): Now static.
5530 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5531 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5532 (x_screen_planes): Remove; unused.
5533 * dispextern.h (x_screen_planes): Remove decl.
5534
5bf46f05
PE
5535 * dispnew.c: Make symbols static if they're not exported.
5536 * dispextern.h (redraw_garbaged_frames, scrolling):
5537 (increment_row_positions): Remove.
5538 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5539 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5540 Now static.
5541 (redraw_garbaged_frames): Remove; unused.
5542
435f4c28
PE
5543 * xfaces.c: Make symbols static if they're not exported.
5544 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5545 Remove decls.
5546 * xterm.h (defined_color): Remove decls.
5547 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5548 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5549 (menu_face_changed_default, defined_color, free_realized_face):
5550 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5551 (ascii_face_of_lisp_face): Remove; unused.
5552
8524aef3
PE
5553 * xdisp.c: Make symbols static if they're not exported.
5554 * dispextern.h (scratch_glyph_row, window_box_edges):
5555 (glyph_to_pixel_coords, set_cursor_from_row):
5556 (get_next_display_element, set_iterator_to_next):
5557 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5558 (show_mouse_face): Remove decls
5559 * frame.h (message_buf_print): Likewise.
5560 * lisp.h (pop_message, set_message, check_point_in_composition):
5561 Likewise.
5562 * xterm.h (set_vertical_scroll_bar): Likewise.
5563 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5564 (message_buf_print, scratch_glyph_row, displayed_buffer):
5565 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5566 (get_next_display_element, show_mouse_face, window_box_edges):
5567 (frame_to_window_pixel_xy, check_point_in_composition):
5568 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5569 (glyph_to_pixel_coords): Remove; unused.
5570
16390cd2
PE
5571 * dired.c (file_name_completion): Now static.
5572
5573 * dbusbind.c (xd_in_read_queued_messages): Now static.
5574
a25f4dfa
PE
5575 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5576 * data.c (circular_list_error): Remove.
5577
14a9c8df
PE
5578 * commands.h (last_point_position, last_point_position_buffer):
5579 (last_point_position_window): Remove decls.
5580 * keyboard.c: Make these variables static.
5581
04f2d78b
CB
5582 * coding.h (coding, code_convert_region, encode_coding_gap):
5583 Remove decls.
74ab6df5
PE
5584 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5585 (iso_code_class, detect_coding, code_convert_region): Now static.
5586 (encode_coding_gap): Remove; unused.
5587
38dfbee1
PE
5588 * chartab.c (chartab_chars, chartab_bits): Now static.
5589
a2cb4e63
PE
5590 * charset.h (charset_iso_8859_1): Remove decl.
5591 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5592 Now static.
5593
127198fd
PE
5594 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5595 * ccl.c (Vccl_program_table): Now static.
5596 (check_ccl_update): Remove; unused.
5597
d85b608f
PE
5598 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5599 * category.h: ... from here.
5600 * category.c (check_category_table, set_category_set): Now static.
5601
31cd66f3
PE
5602 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5603 * lisp.h: Remove these decls.
5604
c358e587
PE
5605 * buffer.c (buffer_count): Remove unused var.
5606
e78aecca
PE
5607 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5608 so that it's not optimized away.
5609 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5610 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5611 exported only to the debugger.
5612
e192d7d3 5613 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5614 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5615
92470028
PE
5616 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5617 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5618 was inaccessible from Lisp.
5619 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5620 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5621
244ed907
PE
5622 alloc.c: Import and export fewer symbols, and remove unused items.
5623 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5624 is defined.
5625 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5626 it's not optimized away by whole-program optimization.
5627 (message_enable_multibyte, free_misc): Remove.
5628 (catchlist, handlerlist, mark_backtrace):
5629 Declare only if BYTE_MARK_STACK.
5630 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5631 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5632 (message_enable_multibyte): Remove decl.
5633 (free_misc, interval_free_list, float_block, float_block_index):
5634 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5635 (cons_free_list, last_marked_index):
5636 Now static.
5637 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5638 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5639 (mark_backtrace): Define only if BYTE_MARK_STACK.
5640 * xdisp.c (message_enable_multibyte): Now static.
5641
61c2b50e 5642 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5643 This makes it easier for human readers (and static analyzers)
5644 to see whether these variables are used from other modules.
5645 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5646 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5647 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5648 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5649 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5650 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5651 * xmenu.c, xselect.c:
5652 Declare Q* vars static if they are not used in other modules.
5653 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5654 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5655 Remove decls of unexported vars.
5656 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5657
95c82688
PE
5658 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5659
16a97296
PE
5660 Make Emacs functions such as Fatom 'static' by default.
5661 This makes it easier for human readers (and static analyzers)
5662 to see whether these functions can be called from other modules.
5663 DEFUN now defines a static function. To make the function external
5664 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5665 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5666 (Finit_image_library):
16a97296
PE
5667 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5668 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5669 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5670 Remove decls, since these functions are now static.
5671 (Funintern, Fget_internal_run_time): New decls, since these functions
5672 were already external.
95c82688 5673
16a97296
PE
5674 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5675 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5676 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5677 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5678 * keyboard.c, keymap.c, lread.c:
5679 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5680 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5681 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5682 Mark functions with DEFUE instead of DEFUN,
5683 if they are used in other modules.
5684 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5685 decls for now-static functions.
5686 * buffer.h (Fdelete_overlay): Remove decl.
5687 * callproc.c (Fgetenv_internal): Mark as internal.
5688 * composite.c (Fremove_list_of_text_properties): Remove decl.
5689 (Fcomposition_get_gstring): New forward static decl.
5690 * composite.h (Fcomposite_get_gstring): Remove decl.
5691 * dired.c (Ffile_attributes): New forward static decl.
5692 * doc.c (Fdocumntation_property): New forward static decl.
5693 * eval.c (Ffetch_bytecode): New forward static decl.
5694 (Funintern): Remove extern decl; now in .h file where it belongs.
5695 * fileio.c (Fmake_symbolic_link): New forward static decl.
5696 * image.c (Finit_image_library): New forward static decl.
5697 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5698 * intervals.h (Fprevious_property_change):
5699 (Fremove_list_of_text_properties): Remove decls.
5700 * keyboard.c (Fthis_command_keys): Remove decl.
5701 (Fcommand_execute): New forward static decl.
5702 * keymap.c (Flookup_key): New forward static decl.
5703 (Fcopy_keymap): Now static.
5704 * keymap.h (Flookup_key): Remove decl.
5705 * process.c (Fget_process): New forward static decl.
5706 (Fprocess_datagram_address): Mark as internal.
5707 * syntax.c (Fsyntax_table_p): New forward static decl.
5708 (skip_chars): Remove duplicate decl.
5709 * textprop.c (Fprevious_property_change): New forward static decl.
5710 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5711 Now internal.
5712 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5713 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5714
785bbd42
PE
5715 * editfns.c (Fformat): Remove unreachable code.
5716
8b913b57
AS
57172011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5718
5719 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5720 change. (Bug#8496)
5721
a6744a35
EZ
57222011-04-13 Eli Zaretskii <eliz@gnu.org>
5723
5724 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5725 when at ZV. (Bug#8487)
5726
e7974947
AS
57272011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5728
baad03f0
AS
5729 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5730 (Bug#8437)
5731 * keyboard.c (parse_tool_bar_item): Likewise.
5732 * sound.c (sound_cleanup, alsa_close): Likewise.
5733 * termcap.c (tgetent): Likewise.
5734 * xfns.c (x_default_font_parameter): Likewise.
5735 * xsettings.c (read_and_apply_settings): Likewise.
5736
e7974947
AS
5737 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5738 (overrun_check_free): Protoize.
5739
28272684
PE
57402011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5741
5742 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5743 since callers should never pass a negative size.
5744 Change the signature to match that of plain 'read' and 'write'; see
5745 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5746 * lisp.h: Update prototypes of emacs_write and emacs_read.
5747
11997c76
EZ
57482011-04-11 Eli Zaretskii <eliz@gnu.org>
5749
5750 * xdisp.c (redisplay_window): Don't try to determine the character
5751 position of the scroll margin if the window start point w->startp
e896f03c 5752 is outside the buffer's accessible region. (Bug#8468)
11997c76 5753
8a2cbd72
EZ
57542011-04-10 Eli Zaretskii <eliz@gnu.org>
5755
5756 Fix write-region and its subroutines for buffers > 2GB.
5757 * fileio.c (a_write, e_write): Modify declaration of arguments and
5758 local variables to support buffers larger than 2GB.
5759 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5760
5761 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5762 argument, local variables, and return value.
5763
5764 * lisp.h: Update prototypes of emacs_write and emacs_read.
5765
5766 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5767
4073e537 57682011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5769
1ebfdcb6
PE
5770 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5771
b2ded58d
PE
5772 Fix more problems found by GCC 4.6.0's static checks.
5773
7d66342c
PE
5774 * xdisp.c (vmessage): Use a better test for character truncation.
5775
bbf47d44
PE
5776 * charset.c (load_charset_map): <, not <=, for optimization,
5777 and to avoid potential problems with integer overflow.
9248994d 5778 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5779 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5780 * editfns.c (Fformat): Likewise.
1e69125e 5781 * syntax.c (skip_chars): Likewise.
3befa583 5782
e3019616
PE
5783 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5784 This also lets GCC 4.6.0 generate slightly better loop code.
5785
becfa255
PE
5786 * callint.c (Fcall_interactively): <, not <=, for optimization.
5787 (Fcall_interactively): Count the number of arguments produced,
5788 not the number of arguments given. This is simpler and lets GCC
5789 4.6.0 generate slightly better code.
5790
dae0cd48
PE
5791 * ftfont.c: Distingish more carefully between FcChar8 and char.
5792 The previous code passed unsigned char * to a functions like
5793 strlen and xstrcasecmp that expect char *, which does not
5794 conform to the C standard.
5795 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5796 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5797 char * when the C standard requires it.
5798
76032d70
PE
5799 * keyboard.c (read_char): Remove unused var.
5800
eb3f1cc8
PE
5801 * eval.c: Port to Windows vsnprintf (Bug#8435).
5802 Include <limits.h>.
5803 (SIZE_MAX): Define if the headers do not.
5804 (verror): Do not give up if vsnprintf returns a negative count.
5805 Instead, grow the buffer. This ports to Windows vsnprintf, which
5806 does not conform to C99. Problem reported by Eli Zaretskii.
5807 Also, simplify the allocation scheme, by avoiding the need for
5808 calling realloc, and removing the ALLOCATED variable.
5809
70476b54
PE
5810 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5811
12020a9e
PE
5812 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5813 But keep the doprint source code for now, as we might revamp it
5814 and use it again (Bug#8435).
ea6c7ae6
PE
5815 * lisp.h (doprnt): Remove.
5816 * Makefile.in (base_obj): Remove doprnt.o.
5817 * deps.mk (doprnt.o): Remove.
5818
5fdb398c
PE
5819 error: Print 32- and 64-bit integers portably (Bug#8435).
5820 Without this change, on typical 64-bit hosts error ("...%d...", N)
5821 was used to print both 32- and 64-bit integers N, which relied on
5822 undefined behavior.
5823 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5824 New macro.
5825 * lisp.h (error, verror): Mark as printf-like functions.
5826 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5827 Report overflow in size calculations when allocating printf buffer.
5828 Do not truncate output string at its first null byte.
5829 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5830 Truncate the output at a character boundary, since vsnprintf does not
5831 do that.
5832 * charset.c (check_iso_charset_parameter): Convert internal
5833 character to string before calling 'error', since %c now has the
5834 printf meaning.
5835 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5836 overflow when computing char to be passed to 'error'. Do not
5837 pass Lisp_Object to 'error'; pass the integer instead.
5838 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5839 formatted with plain %d.
5840
b189fa66
PE
5841 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5842
bff87ef0
PE
5843 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5844
7e2cac20
PE
5845 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5846
ce4d90b5
PE
5847 * xterm.c (x_catch_errors): Remove duplicate declaration.
5848
266c9547
PE
5849 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5850
79c49ad2
PE
5851 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5852
368f4090
JM
58532011-04-10 Jim Meyering <meyering@redhat.com>
5854
5855 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5856 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5857 return ssize_t not "int", and use size_t as the buffer length.
5858 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5859 * gnutls.h: Update declarations.
5860 * process.c (read_process_output): Use ssize_t, to match.
5861 (send_process): Likewise.
5862
a32d4040
CY
58632011-04-09 Chong Yidong <cyd@stupidchicken.com>
5864
5865 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5866
8546720e 58672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5868
04f2d78b
CB
5869 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5870 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5871
8546720e
GM
5872 * xterm.c (handle_one_xevent):
5873 * xmenu.c (create_and_show_popup_menu):
5874 * xselect.c (x_decline_selection_request)
5875 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5876
0a2f5c1a 58772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5878
5879 Fix some uses of `int' instead of EMACS_INT.
5880 * search.c (string_match_1, fast_string_match)
5881 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5882 (scan_buffer, find_next_newline_no_quit)
5883 (find_before_next_newline, search_command, Freplace_match)
5884 (Fmatch_data): Make some `int' variables be EMACS_INT.
5885
5886 * xdisp.c (display_count_lines): 3rd argument and return value now
5887 EMACS_INT. All callers changed.
5888 (pint2hrstr): Last argument is now EMACS_INT.
5889
5890 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5891 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5892 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5893 (decode_coding_utf_16, decode_coding_emacs_mule)
5894 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5895 (decode_coding_ccl, decode_coding_charset)
5896 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5897 (decode_coding_iso_2022, decode_coding_emacs_mule)
5898 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5899 <char_offset, last_offset>: Declare EMACS_INT.
5900 (encode_coding_utf_8, encode_coding_utf_16)
5901 (encode_coding_emacs_mule, encode_invocation_designation)
5902 (encode_designation_at_bol, encode_coding_iso_2022)
5903 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5904 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5905 Declare EMACS_INT.
5906 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5907 (encode_invocation_designation): Last argument P_NCHARS is now
5908 EMACS_INT.
5909 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5910 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5911
5912 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5913 All users changed.
5914
5915 * ccl.c (Fccl_execute_on_string): Declare some variables
5916 EMACS_INT.
5917
8546720e 59182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5919
5920 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5921
4e19a977
CS
59222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5923
5924 * process.c (Fformat_network_address): Doc fix.
5925
87302331
R
59262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5927
5928 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5929
cbb59342
CY
59302011-04-08 Chong Yidong <cyd@stupidchicken.com>
5931
5932 * keyboard.c (read_char): Call Lisp function help-form-show,
5933 instead of using internal_with_output_to_temp_buffer.
5934 (Qhelp_form_show): New var.
e0d38eeb 5935 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5936
5937 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5938
5939 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5940
e67a13ab
CY
59412011-04-06 Chong Yidong <cyd@stupidchicken.com>
5942
04f2d78b
CB
5943 * process.c (Flist_processes): Remove to Lisp.
5944 (list_processes_1): Delete.
e67a13ab 5945
973f782d
EZ
59462011-04-06 Eli Zaretskii <eliz@gnu.org>
5947
7c106b1e
EZ
5948 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5949
973f782d
EZ
5950 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5951
41cf7d1a 59522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5953
ca23cc88
PE
5954 Fix more problems found by GCC 4.6.0's static checks.
5955
f390e2d5
PE
5956 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5957
42eea0d0
PE
5958 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5959
b69769da 5960 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5961
f9541e84
PE
5962 * xdisp.c (vmessage): Mark as a printf-like function.
5963
13841b55
PE
5964 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5965
c136c10f
PE
5966 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5967
5e2d4a30
PE
5968 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5969 printf-like functions.
5970 (tiff_load): Add casts to remove these marks before passing them
5971 to system-supplied API.
5972
583f48b9
PE
5973 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5974
b25d760e
PE
5975 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5976 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5977 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5978 directly, rather than having caller test rule sign. This avoids
5979 some unnecessary tests.
5980 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5981 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5982 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5983
bc7b6697 5984 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5985 (xfont_open): Avoid unnecessary tests.
bc7b6697 5986
27ccc379
PE
5987 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5988
dcd5c89a
PE
5989 * composite.h, composite.c (composition_gstring_put_cache):
5990 Use EMACS_INT, not int, for length.
5991
b13a45c6
PE
5992 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5993 breaking out part of COMPOSITION_DECODE_RULE.
5994 (COMPOSITION_DECODE_RULE): Use it.
5995 * composite.c (get_composition_id): Remove unused local vars,
5996 by using the new macro.
5997
1e792e4d
PE
5998 * textprop.c (set_text_properties_1): Change while to do-while,
5999 since the condition is always true at first.
6000
dc6c6455 6001 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6002 (interval_deletion_adjustment): Return unsigned value.
6003 All uses changed.
dc6c6455 6004
aba7731a
PE
6005 * process.c (list_processes_1, create_pty, read_process_output):
6006 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6007 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6008 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6009 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6010 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6011
fdfc4bf3
PE
6012 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6013
fca8fe46 6014 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6015 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6016
06a0259a 6017 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6018 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6019 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6020
e7b9e80f
PE
6021 * print.c (print_error_message): Avoid int overflow.
6022
56201685
PE
6023 * font.c (font_list_entities): Redo for clarity,
6024 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6025
78834453 6026 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6027 (font_score): Avoid potential overflow in diff calculation.
78834453 6028
0bc0b309 6029 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6030 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6031
e610eaca
PE
6032 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6033
b895abce
PE
6034 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6035 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6036 can always succeed if overflow has undefined behavior.
6037
1f1d9321 6038 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6039 (wordify): Omit three unnecessary tests.
1f1d9321 6040
c59478bc
PE
6041 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6042 All callers changed. This avoids the need for an unused var.
6043
79b73827
PE
6044 * casefiddle.c (casify_region): Remove var that is set but not used.
6045
a4db5dfe
PE
6046 * dired.c (file_name_completion): Remove var that is set but not used.
6047
43aae36e
PE
6048 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6049
2a47c44d 6050 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6051 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6052
a37c69bf
PE
6053 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6054 Check for integer overflow on size calculations.
6055
328ab8e7
PE
6056 * buffer.c (Fprevious_overlay_change): Remove var that is set
6057 but not used.
6058
e5a2a5cb
PE
6059 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6060 Remove vars that are set but not used.
8d84a6eb 6061 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6062 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6063
a60e5f68
PE
6064 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6065
f661cb61 6066 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6067 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6068
f0397f5a
PE
6069 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6070 that are set but not used.
6071
8664db06 6072 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6073 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6074
6abdaa4a
PE
6075 * xselect.c (x_get_local_selection, x_handle_property_notify):
6076 Remove vars that are set but not used.
6077
0ce7538d 6078 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6079 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6080
9ae848fc
PE
6081 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6082 Remove var that is set but not used.
0b918413
PE
6083 (scroll_bar_windows_size): Now size_t, not int.
6084 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6085 Check for overflow.
9ae848fc 6086
a5a62657
PE
6087 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6088 (map_tty_color) [!defined MSDOS]: Likewise.
6089
5c5cdd39
PE
6090 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6091
66ebf983
PE
6092 * coding.c: Remove vars that are set but not used.
6093 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6094 All callers changed.
6095 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6096 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6097 (decode_coding_charset): Remove vars that are set but not used.
6098
1be4d761
PE
6099 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6100 that is set but not used.
6101
47553fa8
PE
6102 * print.c (print_object): Remove var that is set but not used.
6103
1f7196bf 6104 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6105 The gnulib version avoids calling malloc in the usual case,
6106 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6107 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6108 * filelock.c (current_lock_owner): Likewise.
6109 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6110 * sysdep.c: Include allocator.h, careadlinkat.h.
6111 (emacs_no_realloc_allocator): New static constant.
6112 (emacs_readlink): New function.
fdb61804
PE
6113 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6114 ../lib/careadlinkat.h.
d1fdcab7 6115
f84c17c7
SM
61162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6117
6118 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6119 first non-nil return value).
6120
ef3862ad
JD
61212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6122
6123 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6124 if not defined (Bug#8403).
6125
376a7006
JB
61262011-04-02 Juanma Barranquero <lekktu@gmail.com>
6127
6128 * xdisp.c (display_count_lines): Remove parameter `start',
6129 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6130 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6131 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6132 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6133 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6134 and thereabouts. All callers changed.
6135 (get_per_char_metric): Remove parameter `f', unused since
6136 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6137
6ca3801d
JM
61382011-04-02 Jim Meyering <meyering@redhat.com>
6139
6140 do not dereference NULL upon failed strdup
6141 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6142 (ns_get_family): Likewise.
6143
d8e2b5ba
JB
61442011-04-02 Juanma Barranquero <lekktu@gmail.com>
6145
6146 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6147
8c74fcbd
JD
61482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6149
6150 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6151 later (Bug#8403).
6152
7200d79c
SM
61532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6154
03408648 6155 Add lexical binding.
7200d79c 6156
03408648
SM
6157 * window.c (Ftemp_output_buffer_show): New fun.
6158 (Fsave_window_excursion):
6159 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6160
6161 * lread.c (lisp_file_lexically_bound_p): New function.
6162 (Fload): Bind Qlexical_binding.
6163 (readevalloop): Remove `evalfun' arg.
6164 Bind Qinternal_interpreter_environment.
6165 (Feval_buffer): Bind Qlexical_binding.
6166 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6167 Mark as dynamic.
6168 (syms_of_lread): Declare `lexical-binding'.
6169
6170 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6171
6172 * keyboard.c (eval_dyn): New fun.
6173 (menu_item_eval_property): Use it.
ca105506
SM
6174
6175 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6176
03408648
SM
6177 * fns.c (concat, mapcar1): Accept byte-code-functions.
6178
6179 * eval.c (Fsetq): Handle lexical vars.
6180 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6181 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6182 (FletX, Flet): Obey lexical binding.
6183 (Fcommandp): Handle closures.
6184 (Feval): New `lexical' arg.
6185 (eval_sub): New function extracted from Feval. Use it almost
6186 everywhere where Feval was used. Look up vars in lexical env.
6187 Handle closures.
6188 (Ffunctionp): Move from subr.el.
6189 (Ffuncall): Handle closures.
6190 (apply_lambda): Remove `eval_flags'.
6191 (funcall_lambda): Handle closures and new byte-code-functions.
6192 (Fspecial_variable_p): New function.
6193 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6194 but without exporting it to Lisp.
23aba0ea 6195
23aba0ea 6196 * doc.c (Fdocumentation, store_function_docstring):
03408648 6197 * data.c (Finteractive_form): Handle closures.
23aba0ea 6198
03408648
SM
6199 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6200 interactive spec.
ba83908c 6201
04f2d78b
CB
6202 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6203 New byte-codes.
03408648
SM
6204 (exec_byte_code): New function extracted from Fbyte_code to handle new
6205 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6206
03408648 6207 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6208
03408648 6209 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6210
e2abce01
JB
62112011-03-31 Juanma Barranquero <lekktu@gmail.com>
6212
6213 * xdisp.c (redisplay_internal): Fix prototype.
6214
63696a73 62152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6216
63696a73 6217 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6218 (try_scrolling): Use it when setting scroll_limit.
6219 Limit scrolling to 100 screen lines.
63696a73
EZ
6220 (redisplay_window): Even when falling back on "recentering",
6221 position point in the window according to scroll-conservatively,
6222 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6223
6224 (try_scrolling): When point is above the window, allow searching
6225 as far as scroll_max, or one screenful, to compute vertical
6226 distance from PT to the scroll margin position. This prevents
6227 try_scrolling from unnecessarily failing when
6228 scroll-conservatively is set to a value slightly larger than the
6229 window height. Clean up the case of PT below the margin at bottom
6230 of window: scroll_max can no longer be INT_MAX. When aggressive
6231 scrolling is in use, don't let point enter the opposite scroll
6232 margin as result of the scroll.
6233 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6234 threshold of 100 lines for never-recentering scrolling.
6235
e4cc2dfc
JB
62362011-03-31 Juanma Barranquero <lekktu@gmail.com>
6237
6238 * dispextern.h (move_it_by_lines):
6239 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6240 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6241 (message_log_check_duplicate): Remove parameters `prev_bol' and
6242 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6243 (redisplay_internal): Remove parameter `preserve_echo_area',
6244 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6245
6246 * indent.c (Fvertical_motion):
6247 * window.c (window_scroll_pixel_based, Frecenter):
6248 Don't pass `need_y_p' to `move_it_by_lines'.
6249
1c470562
SM
62502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6251
44f230aa
SM
6252 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6253 steal a few bits to be more compact.
6254 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6255 Remove unneeded casts.
6256
1c470562
SM
6257 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6258
888adce9
ZK
62592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6260
6261 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6262 binding" message (bug#7967).
6263
f838ed7b
PE
62642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6265
77861b95
PE
6266 Fix more problems found by GCC 4.6.0's static checks.
6267
de6dbc14
PE
6268 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6269 Remove unused local var.
6270
f838ed7b
PE
6271 * editfns.c (Fmessage_box): Remove unused local var.
6272
792c7b2b
PE
6273 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6274 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6275 Omit unused local vars.
c499e557 6276 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6277 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6278 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6279 Omit unused local var.
6280
ba0165e1
PE
6281 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6282 Don't assume string length fits in int.
32ad8845 6283 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6284 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6285
3c59b4c9
PE
6286 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6287 instead of alloca (Bug#8344).
6288
a3eed478 6289 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6290 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6291
eb4d412d
PE
6292 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6293
1658b401
PE
6294 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6295 concerns.
6296
6297 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6298
6299 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6300
9a2c6e05
PE
6301 * keyboard.c (syms_of_keyboard): Use the same style as later
6302 in this function when indexing through an array. This also
6303 works around GCC bug 48267.
6304
03d0a109
PE
6305 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6306
44f730c8
PE
6307 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6308
fe75f926
PE
6309 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6310 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6311
ffa8c828
PE
6312 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6313 This avoids undefined behavior on integer overflow, and is a bit
6314 more convenient anyway since it is compared to a size_t variable.
6315
c5101a77
PE
6316 Variadic C functions now count arguments with size_t, not int.
6317 This avoids an unnecessary limitation on 64-bit machines, which
6318 caused (substring ...) to crash on large vectors (Bug#8344).
6319 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6320 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6321 All variadic functions and their callers changed accordingly.
c5101a77
PE
6322 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6323 * data.c (arith_driver, float_arith_driver): Likewise.
6324 * editfns.c (general_insert_function): Likewise.
6325 * eval.c (struct backtrace.nargs, interactive_p)
6326 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6327 (funcall_lambda, mark_backtrace): Likewise.
6328 * fns.c (concat): Likewise.
6329 * frame.c (x_set_frame_parameters): Likewise.
6330 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6331 0 if not found, not -1. All callers changed.
6332
dd3f25f7
PE
6333 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6334 (stack_copy_size): Now size_t, not int.
6335 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6336
461c2ab9
JB
63372011-03-28 Juanma Barranquero <lekktu@gmail.com>
6338
6339 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6340 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6341 All callers changed.
6342
6343 * lisp.h (multibyte_char_to_unibyte):
6344 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6345 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6346 * character.h (CHAR_TO_BYTE8):
6347 * cmds.c (internal_self_insert):
6348 * editfns.c (general_insert_function):
6349 * keymap.c (push_key_description):
6350 * search.c (Freplace_match):
6351 * xdisp.c (message_dolog, set_message_1): All callers changed.
6352
f6d62986
SM
63532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6354
6355 * keyboard.c (safe_run_hook_funcall): New function.
6356 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6357 don't set the hook to nil, but remove the offending function instead.
6358 (Qcommand_hook_internal): Remove, unused.
6359 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6360 Vcommand_hook_internal.
6361
6362 * eval.c (enum run_hooks_condition): Remove.
6363 (funcall_nil, funcall_not): New functions.
6364 (run_hook_with_args): Call each function through a `funcall' argument.
6365 Remove `cond' argument, now redundant.
6366 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6367 (Frun_hook_with_args_until_failure): Adjust accordingly.
6368 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6369
1db5b1ad
JB
63702011-03-28 Juanma Barranquero <lekktu@gmail.com>
6371
6372 * dispextern.h (string_buffer_position): Remove declaration.
6373
6374 * print.c (strout): Remove parameter `multibyte', unused since
6375 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6376
6377 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6378 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6379 All callers changed.
6380
6381 * w32.c (_wsa_errlist): Use braces for struct initializers.
6382
6383 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6384 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6385 All callers changed.
6386 (string_buffer_position): Likewise. Also, make static (it's never
6387 used outside xdisp.c).
6388 (cursor_row_p): Remove parameter `w', unused since
6389 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6390 (decode_mode_spec): Remove parameter `precision', introduced during
6391 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6392 All callers changed.
6393
5ffb62aa
JD
63942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6395
6396 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6397
461c2ab9 63982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6399
6400 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6401 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6402 (ns_update_auto_hide_menu_bar): New functions.
6403 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6404 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6405 ns_constrain_all_frames.
6406 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6407 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6408
5c380ffb
JD
64092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6410
6411 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6412
9af30bdf
GM
64132011-03-27 Glenn Morris <rgm@gnu.org>
6414
6415 * syssignal.h: Replace RETSIGTYPE with void.
6416 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6417 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6418 Replace SIGTYPE with void everywhere.
6419 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6420 * s/template.h (SIGTYPE): Remove commented out definition.
6421
e2abce01
JB
64222011-03-26 Eli Zaretskii <eliz@gnu.org>
6423
6424 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6425 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6426
f868cd8a
JB
64272011-03-26 Juanma Barranquero <lekktu@gmail.com>
6428
59eb0929
JB
6429 * w32.c (read_unc_volume): Use parameter `henum', instead of
6430 global variable `wget_enum_handle'.
6431
6432 * keymap.c (describe_vector): Remove parameters `indices' and
6433 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6434 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6435
f868cd8a
JB
6436 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6437
6438 * keyboard.c (timer_check): Remove parameter `do_it_now',
6439 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6440 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6441 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6442
6443 * keyboard.c (read_char):
6444 * w32menu.c (w32_menu_display_help):
6445 * xmenu.c (show_help_event, menu_help_callback):
6446 Adjust calls to `show_help_echo'.
6447
6448 * gtkutil.c (xg_maybe_add_timer):
6449 * keyboard.c (readable_events):
6450 * process.c (wait_reading_process_output):
6451 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6452
6453 * insdel.c (adjust_markers_gap_motion):
6454 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6455 (gap_left, gap_right): Don't call it.
6456
2ecf6fdb
CY
64572011-03-25 Chong Yidong <cyd@stupidchicken.com>
6458
6459 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6460 incurred during fontification.
6461
6b1f9ba4
JB
64622011-03-25 Juanma Barranquero <lekktu@gmail.com>
6463
6464 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6465 (DEFVAR_PER_BUFFER): Don't pass it.
6466
6467 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6468 (scrolling_window): Don't pass it.
6469
0f4a96b5
JB
64702011-03-25 Juanma Barranquero <lekktu@gmail.com>
6471
6472 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6473
6474 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6475 and `suffix'.
6476 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6477 of variables specific to SELinux and computation of `encoded_absname'.
6478
6479 * image.c (XPutPixel): Remove unused variable `height'.
6480
6481 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6482
6483 * unexw32.c (get_section_info): Remove unused variable `section'.
6484
6485 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6486 (system_process_attributes): Remove unused variable `sess'.
6487 (sys_read): Remove unused variable `err'.
6488
6489 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6490 (w32_wnd_proc): Remove unused variable `isdead'.
6491 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6492 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6493 (x_create_tip_frame): Remove unused variable `tem'.
6494
6495 * w32inevt.c (w32_console_read_socket):
6496 Remove unused variable `no_events'.
6497
6498 * w32term.c (x_draw_composite_glyph_string_foreground):
6499 Remove unused variable `width'.
6500
1149507c
JB
65012011-03-24 Juanma Barranquero <lekktu@gmail.com>
6502
6503 * w32term.c (x_set_glyph_string_clipping):
6504 Don't pass uninitialized region to CombineRgn.
6505
9c88f339
JB
65062011-03-23 Juanma Barranquero <lekktu@gmail.com>
6507
6508 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6509 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6510 (Fx_close_connection): Remove unused variable `i'.
6511
6512 * w32font.c (w32font_draw): Return number of glyphs.
6513 (w32font_open_internal): Remove unused variable `i'.
6514 (w32font_driver): Add missing initializer.
6515
6516 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6517 (fill_in_menu): Remove unused variable `items_added'.
6518
6519 * w32term.c (last_mouse_press_frame): Remove static global variable.
6520 (w32_clip_to_row): Remove unused variable `f'.
6521 (x_delete_terminal): Remove unused variable `i'.
6522
6523 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6524 (NOTHING): Remove unused static global variable.
6525 (uniscribe_check_otf): Remove unused variable `table'.
6526 (uniscribe_font_driver): Add missing initializers.
6527
dee091a3
JD
65282011-03-23 Julien Danjou <julien@danjou.info>
6529
6530 * term.c (Fsuspend_tty, Fresume_tty):
6531 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6532 * window.c (temp_output_buffer_show):
6533 * insdel.c (signal_before_change):
6534 * frame.c (Fhandle_switch_frame):
6535 * fileio.c (Fdo_auto_save):
6536 * emacs.c (Fkill_emacs):
6537 * editfns.c (save_excursion_restore):
6538 * cmds.c (internal_self_insert):
6539 * callint.c (Fcall_interactively):
6540 * buffer.c (Fkill_all_local_variables):
6541 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6542 Use Frun_hooks.
0f4a96b5 6543 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6544 unconditionnaly since it does the check itself.
6545
2c520ab5 65462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6547
c9c49752
PE
6548 Fix more problems found by GCC 4.5.2's static checks.
6549
8abc3f12
PE
6550 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6551 the first time through the loop, since we know p0 < p1 then.
6552 This also avoids a gcc -Wstrict-overflow warning.
6553
a2d26660
PE
6554 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6555 leading to a memory leak, possible in functions like
6556 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6557 of objects (Bug#8318).
a2d26660 6558
916c72e9
PE
6559 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6560 that could (at least in theory) be that large.
6561
19ab8a18
PE
6562 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6563 This is less likely to overflow, and avoids undefined behavior if
6564 overflow does occur. All callers changed. Use strtoul to scan
6565 for the unsigned long integer.
b7cbbd6f
PE
6566 (pint2hrstr): Simplify and tune code slightly.
6567 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6568
f0641eff
PE
6569 * scroll.c (do_scrolling): Work around GCC bug 48228.
6570 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6571
7f650bb9
PE
6572 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6573 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6574 (validate_x_resource_name): Simplify count usage.
6575 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6576
37dd57d1
PE
6577 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6578 fail (Bug#8306).
81e56e61 6579
699979fc 6580 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6581
401bf9b4
PE
6582 * process.c (Fmake_network_process): Use socklen_t, not int,
6583 where POSIX says socklen_t is required in portable programs.
6584 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6585 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6586 (Fmake_network_process, server_accept_connection):
6587 (wait_reading_process_output, read_process_output):
6588 Likewise.
6589
b93aacde
PE
6590 * process.c: Rename or move locals to avoid shadowing.
6591 (list_processes_1, Fmake_network_process):
6592 (read_process_output_error_handler, exec_sentinel_error_handler):
6593 Rename or move locals.
4dc343ee 6594 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6595 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6596 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6597 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6598 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6599
af8a867c 6600 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6601 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6602 Include tparam.h instead, since it declares them.
af8a867c
PE
6603 * cm.h (PC): Remove extern decl; tparam.h now does this.
6604 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6605 * terminfo.c: Include tparam.h, to check interfaces.
6606 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6607 (tparam): Adjust signature to match interface in tparam.h;
6608 this removes some undefined behavior. Check that outstring and len
6609 are zero, which they always are with Emacs.
6610 * tparam.h (PC, BC, UP): New extern decls.
6611
0248044d 6612 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6613 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6614
8ff096c1 6615 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6616 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6617 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6618 (ftfont_list): Remove unused local.
49eaafba
PE
6619 (get_adstyle_property, ftfont_pattern_entity):
6620 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6621 Rename locals to avoid shadowing.
8ff096c1 6622
e2be39f6
PE
6623 * xfont.c (xfont_list_family): Mark var as initialized.
6624
c9735e30
PE
6625 * xml.c (make_dom): Now static.
6626
8f5201ae
PE
6627 * composite.c (composition_compute_stop_pos): Rename local to
6628 avoid shadowing.
b246f932
PE
6629 (composition_reseat_it): Remove unused locals.
6630 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6631 (composition_update_it): Mark var as initialized.
11b61122
PE
6632 (find_automatic_composition): Mark vars as initialized,
6633 with a FIXME (Bug#8290).
8f5201ae 6634
760fbc2c
PE
6635 character.h: Rename locals to avoid shadowing.
6636 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6637 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6638 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6639 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6640 to avoid shadowing.
6641
ff08eb85
PE
6642 * textprop.c (property_change_between_p): Remove; unused.
6643
fc7bf025
PE
6644 * intervals.c (interval_start_pos): Now static.
6645
235d7abc
PE
6646 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6647
44f230aa
SM
6648 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6649 Rename locals to avoid shadowing.
3e7d6594 6650
50060332
PE
6651 * sound.c (wav_play, au_play, Fplay_sound_internal):
6652 Fix pointer signedness.
d01f234b 6653 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6654 (wav_play): Initialize a variable to 0, to prevent undefined
6655 behavior (Bug#8278).
50060332 6656
c4fc4e30
PE
6657 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6658
918436ed
PE
6659 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6660
c939f91b
PE
6661 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6662 clobbering (Bug#8298).
b9c7f648
PE
6663 * sysdep.c (sys_subshell): Likewise.
6664 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6665
6bd8c144
PE
6666 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6667 This should get cleaned up, so that child_setup has the
6668 same signature on all platforms.
6669
7710357c 6670 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6671 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6672
c59da222
CY
66732011-03-22 Chong Yidong <cyd@stupidchicken.com>
6674
6675 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6676 not to be necessary, and produces flickering.
6677
66b87493
GM
66782011-03-20 Glenn Morris <rgm@gnu.org>
6679
6680 * config.in: Remove file.
6681
45b6f6d5
JB
66822011-03-20 Juanma Barranquero <lekktu@gmail.com>
6683
6684 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6685 are now in src/globals.h.
6686 (syms_of_minibuf): Remove spurious & from previous change.
6687
3ec03f7e
LL
66882011-03-20 Leo <sdl.web@gmail.com>
6689
6690 * minibuf.c (completing-read-function): New variable.
6691 (completing-read-default): Rename from completing-read.
6692 (completing-read): Call completing-read-function.
6693
b14e3e21
CY
66942011-03-19 Juanma Barranquero <lekktu@gmail.com>
6695
6696 * xfaces.c (Fx_load_color_file):
6697 Read color file from absolute filename (bug#8250).
6698
f2b726e6
JB
66992011-03-19 Juanma Barranquero <lekktu@gmail.com>
6700
6701 * makefile.w32-in: Update dependencies.
6702
09f6ff02
EZ
67032011-03-17 Eli Zaretskii <eliz@gnu.org>
6704
6705 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6706
29a6015a
PE
67072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6708
a3a6c54e
PE
6709 Fix more problems found by GCC 4.5.2's static checks.
6710
b766f867
PE
6711 * process.c (make_serial_process_unwind, send_process_trap):
6712 (sigchld_handler): Now static.
6713
be02381c
PE
6714 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6715 That way, the code declares only the vars that it needs.
6716 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6717 * s/cygwin.h (PTY_ITERATION): Likewise.
6718 * s/darwin.h (PTY_ITERATION): Likewise.
6719 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6720
57048744
PE
6721 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6722 * process.c (allocate_pty): Don't declare stb unless it's needed.
6723
7914961c 6724 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6725 (CONSTANTLIM): Remove; unused.
6726 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6727 Define only if needed.
7914961c 6728
b3967b18
PE
6729 * unexelf.c (unexec): Name an expression,
6730 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6731 Use a different way to cause a compilation error if anyone uses
6732 n rather than nn, a way that does not involve shadowing.
73366a00 6733 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6734
29a6015a
PE
6735 * deps.mk (unexalpha.o): Remove; unused.
6736
43cfc33e 6737 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6738 * unexec.h: New file.
ce701a33
PE
6739 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6740 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6741 Depend on unexec.h.
6742 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6743 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6744 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6745 Change as necessary to match prototype in unexec.h.
ce701a33 6746
01f44d5a
PE
6747 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6748 shadowing.
4f63c6bb 6749 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6750
a6670b0b
PE
6751 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6752 Rename locals to avoid shadowing.
6753
cef2010d 6754 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6755 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6756
d4d7173a
PE
6757 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6758
f08b802a
PE
6759 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6760 warning when compiling print.c.
6761
3ddb0639
PE
6762 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6763 instead of using an uninitialized var.
5ad03b97 6764 (font_sort_entities): Mark var as initialized.
3ddb0639 6765
170a2692
PE
6766 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6767
e663c700
PE
6768 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6769 pointers to constants.
89bc529a 6770 (font_parse_fcname): Remove unused vars.
7b81e2d0 6771 (font_delete_unmatched): Now static.
ea838e10 6772 (font_get_spec): Remove; unused.
13a547c6
PE
6773 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6774 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6775 Rename or move locals to avoid shadowing.
e663c700 6776
2a80c887 6777 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6778 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6779
1384fa33 6780 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6781 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6782
8b2c52e9
PE
6783 * alloc.c (mark_backtrace): Move decl from here ...
6784 * lisp.h: ... to here, so that it can be checked.
6785
475545b5 6786 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6787 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6788 (lisp_indirect_variable): Name an expression,
6789 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6790 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6791
b1349114 6792 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6793 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6794 Use const pointer when appropriate.
b1349114 6795
a2928364
PE
6796 * lisp.h (get_system_name, get_operating_system_release):
6797 Move decls here, to check interfaces.
6798 * process.c (get_operating_system_release): Move decl to lisp.h.
6799 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6800 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6801 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6802 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6803 (Fformat_time_string, Fencode_time, Finsert_char):
6804 (Ftranslate_region_internal, Fformat):
6805 Rename or remove local vars to avoid shadowing.
9710023e 6806 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6807
a415e694
PE
6808 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6809 avoid shadowing.
6810
8ef4622d
PE
6811 * lisp.h (eassert): Check that the argument compiles, even if
6812 ENABLE_CHECKING is not defined.
6813
946f9a5b
PE
6814 * data.c (Findirect_variable): Name an expression, to avoid
6815 gcc -Wbad-function-cast warning.
112396d6 6816 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6817 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6818 (Fmake_variable_buffer_local, Fmake_local_variable):
6819 Mark variables as initialized.
52746918 6820 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6821
e5aab7e7 6822 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6823 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6824 Rename locals to avoid shadowing.
dff45157
PE
6825 (mark_stack): Move local variables into the #ifdef region where
6826 they're used.
7bc26fdb
PE
6827 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6828 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6829 needed otherwise.
6830 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6831 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6832 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6833
e5aab7e7
PE
6834 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6835 avoids undefined behavior in theory.
6836
4da60324
PE
6837 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6838
88043301
PE
6839 Use functions, not macros, for up- and down-casing (Bug#8254).
6840 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6841 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6842 to use the following functions instead of these macros.
6843 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6844 EMACS_INT, since callers assume the returned value fits in int.
6845 (upcase1): Likewise, for UPCASE_TABLE.
6846 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6847 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6848 the race-condition problem in the old DOWNCASE.
88043301 6849
19ed5445
PE
6850 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6851 Rename locals to avoid shadowing.
6852 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6853 (regex_compile, re_search_2, re_match_2_internal):
6854 Remove unused local vars.
952db0d7
PE
6855 (FREE_VAR): Rewrite so as not to use empty "else",
6856 which gcc can warn about.
da053e48 6857 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6858 (RETALLOC_IF): Define only if needed.
6859 (WORDCHAR_P): Likewise. This one is never needed, but is used
6860 only in a comment talking about a compiler bug, so put inside
6861 the #if 0 of that comment.
6862 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6863 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6864 Remove; unused.
19ed5445 6865
1f3561e4 6866 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6867 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6868 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6869
ded6f8f7
PE
6870 * search.c (simple_search): Remove unused var.
6871
dbd37a95
PE
6872 * dired.c (compile_pattern): Move decl from here ...
6873 * lisp.h: ... to here, so that it can be checked.
6874 (struct re_registers): New forward decl.
6875
7e47afad
PE
6876 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6877
85f24f61
PE
6878 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6879 All uses changed.
6880 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6881 Rename locals to avoid shadowing.
5671df8f 6882 (Fvertical_motion): Mark locals as initialized.
85f24f61 6883
181aa2be 6884 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6885 (casify_region): Mark local as initialized.
181aa2be 6886
930d429c
PE
6887 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6888
7082eac6
PE
6889 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6890 New macros, so that the caller can use some names other than
6891 gcpro1, gcpro2, etc.
6892 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6893 of the new macros.
6894 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6895 argument, for consistency with GCPRO2_VAR, etc: it is now the
6896 prefix of the variable, not the variable itself. All uses
6897 changed.
38b2c076
PE
6898 * dired.c (directory_files_internal, file_name_completion):
6899 Rename locals to avoid shadowing.
6900
15206ed9
PE
6901 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6902 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6903 dired.c's scmp function, had undefined behavior.
6904 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6905 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6906 * buffer.h: ... to here, because these macros use current_buffer,
6907 and the new implementation with inline functions needs to have
6908 current_buffer in scope now, rather than later when the macros
6909 are used.
6910 (downcase, upcase1): New static inline functions.
6911 (DOWNCASE, UPCASE1): Reimplement using these functions.
6912 This avoids undefined behavior in expressions like
6913 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6914 from race conditions in accessing the global variables
6915 case_temp1 and case_temp2.
6916 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6917 * lisp.h (case_temp1, case_temp2): Remove their decls.
6918 * character.h (ASCII_CHAR_P): Move from here ...
6919 * lisp.h: ... to here, so that the inline functions mentioned
6920 above can use them.
6921
4a6bea26
PE
6922 * dired.c (directory_files_internal_unwind): Now static.
6923
f14b7e14
PE
6924 * fileio.c (file_name_as_directory, directory_file_name):
6925 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6926 Now static.
2893f146
PE
6927 (file_name_as_directory): Use const pointers when appropriate.
6928 (Fexpand_file_name): Likewise. In particular, newdir might
6929 point at constant storage, so make it a const pointer.
fd4ead52 6930 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6931 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6932 signedness issues.
f839df0c
PE
6933 (Fset_file_times, Finsert_file_contents, auto_save_error):
6934 Rename locals to avoid shadowing.
f14b7e14 6935
5716756e 6936 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6937 (Ftry_completion, Fall_completions): Rename or remove locals
6938 to avoid shadowing.
5716756e 6939
b4c3046a
PE
6940 * marker.c (bytepos_to_charpos): Remove; unused.
6941
b45db522
PE
6942 * lisp.h (verify_bytepos, count_markers): New decls,
6943 so that gcc does not warn that these functions aren't declared.
6944
85876d07
PE
6945 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6946 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6947 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6948 (copy_text): Remove unused local var.
85876d07 6949
03d78a21 6950 * filelock.c (within_one_second): Now static.
b3dd38ab 6951 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6952
5df8f01b
PE
6953 * buffer.c (fix_overlays_before): Mark locals as initialized.
6954 (fix_start_end_in_overlays): Likewise. This function should be
6955 simplified by using pointers-to-pointers, but that's a different
6956 matter.
b1d876f1 6957 (switch_to_buffer_1): Now static.
8f54f30a
PE
6958 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6959 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6960
a70072c9 6961 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6962 Fix pointer signedness issue.
edced198
PE
6963 (sys_subshell): Mark local as volatile if checking for lint,
6964 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6965 (MAXPATHLEN): Define only if needed.
a70072c9 6966
a0977c44
PE
6967 * process.c (serial_open, serial_configure): Move decls from here ...
6968 * systty.h: ... to here, so that they can be checked.
6969
a884fdcc
PE
6970 * fns.c (get_random, seed_random): Move extern decls from here ...
6971 * lisp.h: ... to here, so that they can be checked.
6972
604efe86 6973 * sysdep.c (reset_io): Now static.
b8950c94 6974 (wait_for_termination_signal): Remove; unused.
604efe86 6975
38fc62d9
PE
6976 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6977 (copy_keymap_item, append_key, push_text_char_description):
6978 Now static.
1004a21a 6979 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6980 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6981 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6982 (describe_map_tree):
6983 Rename locals to avoid shadowing.
38fc62d9 6984
2f2650da
PE
6985 * keyboard.c: Declare functions static if they are not used elsewhere.
6986 (echo_char, echo_dash, cmd_error, top_level_2):
6987 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6988 (read_char, kbd_buffer_get_event, make_lispy_position):
6989 (make_lispy_event, make_lispy_movement, apply_modifiers):
6990 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6991 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6992 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6993 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6994 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6995
a053e86c 6996 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6997 (mark_kboards): Move decl here ...
6998 * alloc.c (mark_kboards): ... from here.
a053e86c 6999
4752793e
PE
7000 * lisp.h (force_auto_save_soon): New decl.
7001
74f10ca7 7002 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7003 (DEFINE_DUMMY_FUNCTION): New macro.
7004 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7005 Use it.
c03cd23f
PE
7006 (main): Add casts to avoid warnings
7007 if GCC considers string literals to be constants.
74f10ca7 7008
022e70d4
PE
7009 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7010
59d6fe83
PE
7011 * dbusbind.c: Pointer signedness fixes.
7012 (xd_signature, xd_append_arg, xd_initialize):
7013 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7014 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7015 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7016 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7017
78320123
PE
7018 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7019 if GCC considers string literals to be constants.
49cebcca 7020 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7021
35ac2a97
SM
70222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7023
fb103ca9
SM
7024 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7025 (print_preprocess, print_object): New macro to fix last change.
7026
35ac2a97
SM
7027 * print.c (print_preprocess): Don't forget font objects.
7028
62973b41
JB
70292011-03-16 Juanma Barranquero <lekktu@gmail.com>
7030
7031 * emacs.c (USAGE3): Doc fixes.
7032
0e48bb22
AS
70332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7034
7035 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7036 structure.
7037
7684e57b
JB
70382011-03-14 Juanma Barranquero <lekktu@gmail.com>
7039
7040 * lisp.h (VWindow_system, Qfile_name_history):
7041 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7042 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7043 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7044
7045 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7046 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7047
7048 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7049 * w32console.c (detect_input_pending, read_input_pending)
7050 (encode_terminal_code):
7051 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7052 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7053 (w32_system_caret_y, Qfile_name_history):
7054 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7055 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7056 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7057 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7058 * w32proc.c (Qlocal, report_file_error):
7059 * w32term.c (Vwindow_system, updating_frame):
7060 * w32uniscribe.c (initialized, uniscribe_font_driver):
7061 Remove unneeded extern declarations.
7062
2aa46d6c
CY
70632011-03-14 Chong Yidong <cyd@stupidchicken.com>
7064
c96bbc66 7065 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7066
cffc6f3b
CY
70672011-03-13 Chong Yidong <cyd@stupidchicken.com>
7068
7069 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7070 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7071 These macros can no longer be used for assignment.
7072
44f230aa
SM
7073 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7074 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7075 (record_buffer_markers, fetch_buffer_markers): New functions for
7076 recording and fetching special buffer markers.
7077 (set_buffer_internal_1, set_buffer_temp): Use them.
7078
7079 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7080
7081 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7082
7083 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7084 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7085
7086 * xdisp.c (hscroll_window_tree):
7087 (reconsider_clip_changes): Use PT instead of BUF_PT.
7088
d251f04b
EZ
70892011-03-13 Eli Zaretskii <eliz@gnu.org>
7090
7091 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7092 $(EMACS_ROOT)/lib/intprops.h.
7093
f0c77cd1
PE
70942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7095
3eca4629
PE
7096 Fix more problems found by GCC 4.5.2's static checks.
7097
7c86ee98
PE
7098 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7099 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7100 (xg_free_frame_widgets): Make it clear that a local variable is
7101 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7102 (gdk_window_get_screen): Make it clear that this macro is needed
7103 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7104 (int_gtk_range_get_value): New function, which avoids a diagnostic
7105 from gcc -Wbad-function-cast.
7106 (xg_set_toolkit_scroll_bar_thumb): Use it.
7107 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7108 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7109 (get_utf8_string, xg_get_file_with_chooser):
7110 Rename locals to avoid shadowing.
7111 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7112
41729b81
PE
7113 * xgselect.c (xg_select): Remove unused var.
7114
f0c77cd1
PE
7115 * image.c (four_corners_best): Mark locals as initialized.
7116 (gif_load): Initialize transparent_p to zero (Bug#8238).
7117 Mark another local as initialized.
ec6cf4c6 7118 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7119
ce0ad53d 7120 * image.c (clear_image_cache): Now static.
d5d5a617 7121 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7122 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7123 (x_edge_detection): Remove unnecessary cast that
7124 gcc -Wbad-function-cast diagnoses.
2037898d 7125 (gif_load): Fix pointer signedness.
6ae141d6
PE
7126 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7127 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7128
33383987 71292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7130
d32df629
PE
7131 Improve quality of tests for time stamp overflow.
7132 For example, without this patch (encode-time 0 0 0 1 1
7133 1152921504606846976) returns the obviously-bogus value (-948597
7134 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7135 reports time overflow. See
7136 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7137 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7138 * editfns.c: Include limits.h and intprops.h.
7139 (TIME_T_MIN, TIME_T_MAX): New macros.
7140 (time_overflow): Move earlier, to before first use.
7141 (hi_time, lo_time): New functions, for an accurate test for
7142 out-of-range times.
7143 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7144 (Fget_internal_run_time): Don't assume time_t fits in int.
7145 (make_time): Use list2 instead of Fcons twice.
7146 (Fdecode_time): More accurate test for out-of-range times.
7147 (check_tm_member): New function.
7148 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7149 (lisp_time_argument): Don't rely on undefined left-shift and
7150 right-shift behavior when checking for time stamp overflow.
8be6f318 7151
fe31d94c
PE
7152 * editfns.c (time_overflow): New function, refactoring common code.
7153 (Fformat_time_string, Fdecode_time, Fencode_time):
7154 (Fcurrent_time_string): Use it.
7155
8be6f318
PE
7156 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7157 * dired.c (make_time): Move to ...
7158 * editfns.c (make_time): ... here.
7159 * systime.h: Note the move.
7160
09d9db2c 71612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7162
126bc0dc
YM
7163 * fringe.c (update_window_fringes): Remove unused variables.
7164
c47cbdfd
YM
7165 * unexmacosx.c (copy_data_segment): Also copy __got section.
7166 (Bug#8223)
7167
7ac80be9
EZ
71682011-03-12 Eli Zaretskii <eliz@gnu.org>
7169
c96bbc66 7170 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7171 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7172 Constify `char *' arguments and their references according to
7173 prototypes in tparam.h.
7174
ecb0f94d 7175 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7176
7ac80be9
EZ
7177 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7178 Adapt all references accordingly.
7179
7180 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7181
ef1fd07e
TT
71822011-03-11 Tom Tromey <tromey@redhat.com>
7183
7184 * buffer.c (syms_of_buffer): Remove obsolete comment.
7185
7ef4b50c
EZ
71862011-03-11 Eli Zaretskii <eliz@gnu.org>
7187
7188 * termhooks.h (encode_terminal_code): Declare prototype.
7189
7190 * msdos.c (encode_terminal_code): Don't declare prototype.
7191
7192 * term.c (encode_terminal_code): Now external again, used by
7193 w32console.c and msdos.c.
7194
44f230aa
SM
7195 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7196 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7197
4b1ec863 71982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7199
1714f52b 7200 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7201
4b1ec863
PE
7202 * fringe.c (update_window_fringes): Mark locals as initialized
7203 (Bug#8227).
7204 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7205
524c7aa6
PE
7206 * alloc.c (mark_fringe_data): Move decl from here ...
7207 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7208 to check its interface.
7209 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7210
a5c0af81 7211 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7212 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7213 (fontset_font): Mark local as initialized.
a9a06e0b 7214 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7215
b4716021
PE
7216 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7217
811e9bac 7218 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7219 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7220 (x_own_selection, Fx_disown_selection_internal): Rename locals
7221 to avoid shadowing.
7222 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7223
7e3ab302
PE
7224 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7225 so that the caller can use some name other than gcpro1.
7226 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7227 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7228 (Fx_backspace_delete_keys_p):
7229 Use them to avoid shadowing, and rename vars to avoid shadowing.
7230 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7231 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7232 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7233 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7234 Remove unused locals.
7e3ab302
PE
7235 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7236 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7237 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7238 macros.
f78faa98 7239
e2b13473
PE
7240 * xterm.h (x_mouse_leave): New decl.
7241
77f23912
PE
7242 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7243 Remove unused functions.
cdf4ba58
PE
7244 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7245 (x_calc_absolute_position): Now static.
7411c686 7246 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7247 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7248 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7249 unless they are used.
38d0b34a
PE
7250 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7251 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7252 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7253 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7254 (x_error_catcher, x_connection_closed, x_error_handler):
7255 (x_error_quitter, xembed_send_message, x_iconify_frame):
7256 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7257 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7258 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7259
44f230aa
SM
7260 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7261 Rename or move locals to avoid shadowing.
6b463e58 7262 (tty_defined_color, merge_face_heights): Now static.
5967d051 7263 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7264 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7265 does not deduce is never used uninitialized.
73719eba
PE
7266 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7267 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7268
426994c3 7269 * terminal.c (store_terminal_param): Now static.
5489860b 7270
032f1620 7271 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7272 (set_frame_menubar): Remove unused local.
d4323972 7273 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7274 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7275 since they might point to immutable storage.
281585b0
PE
7276 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7277 since it's unused otherwise.
032f1620 7278
367c19e5 7279 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7280 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7281 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7282 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7283 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7284 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7285 does not deduce are never used uninitialized.
70739cbe 7286
07b48fa9
PE
7287 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7288
8868a238 7289 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7290 * window.c (window_loop, size_window):
7291 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7292
7e5cf297 7293 * window.c (display_buffer): Now static.
d6550a9f
PE
7294 (size_window): Mark variables that gcc -Wuninitialized
7295 does not deduce are never used uninitialized.
a586633d
PE
7296 * window.h (check_all_windows): New decl, to forestall
7297 gcc -Wmissing-prototypes diagnostic.
5b555da1 7298 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7299
f6095868
PE
7300 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7301 shadowing.
7302 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7303 Include <limits.h>.
7304 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7305 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7306 (load_charset_map): Mark variables that gcc -Wuninitialized
7307 does not deduce are never used uninitialized.
53df7c11 7308 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7309
f38b440c
PE
7310 * coding.c (coding_set_source, coding_set_destination):
7311 Use "else { /* comment */ }" rather than "else /* comment */;"
7312 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7313 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7314 a block, when the outer 'i' will do.
7315 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7316 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7317 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7318 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7319 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7320 Rename locals to avoid shadowing.
7321 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7322 * coding.c (emacs_mule_char, encode_invocation_designation):
7323 Now static, since they're not used elsewhere.
413bb2db 7324 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7325 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7326 (decode_coding_emacs_mule): Mark variables that gcc
7327 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7328 (detect_coding_iso_2022): Initialize a local variable that might
7329 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7330 this initialization is needed. (Bug#8211)
5f58e762
PE
7331 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7332 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7333 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7334 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7335 Remove unused macros.
f38b440c 7336
232b38b9 7337 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7338 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7339 * character.c (string_count_byte8): Likewise.
232b38b9 7340
fb90da1b
PE
7341 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7342 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7343
fb93dbc2
PE
7344 * chartab.c (copy_sub_char_table): Now static, since it's not used
7345 elsewhere.
5c156ace
PE
7346 (sub_char_table_ref_and_range, char_table_ref_and_range):
7347 Rename locals to avoid shadowing.
bbcd0949 7348 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7349
7d3b3862 7350 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7351 (BIDI_BOB): Remove unused macro.
7d3b3862 7352
6be7d3da
PE
7353 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7354 deduce are never used uninitialized.
c2ed9c8b 7355 * term.c (encode_terminal_code): Likewise.
6be7d3da 7356
75f8807f 7357 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7358
50938595
PE
7359 * tparam.h: New file.
7360 * term.c, tparam.h: Include it.
7361 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7362 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7363 Move these decls to tparam.h, and make them agree with what
7364 is actually in tparam.c. The previous trick of using incompatible
7365 decls in different modules does not conform to the C standard.
7366 All callers of tparam changed to use tparam's actual API.
7367 * tparam.c (tparam1, tparam, tgoto):
7368 Use const pointers where appropriate.
7369
fbceeba2
PE
7370 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7371 * cm.h (struct cm): Likewise.
7372 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7373 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7374 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7375 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7376 (turn_on_face, init_tty): Likewise.
7377 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7378
7f3f1250
PE
7379 * term.c (term_mouse_position): Rename local to avoid shadowing.
7380
e6ca6543
PE
7381 * alloc.c (mark_ttys): Move decl from here ...
7382 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7383
c40f8d15
AS
73842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7385
7386 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7387
cfe0661d
JB
73882011-03-09 Juanma Barranquero <lekktu@gmail.com>
7389
7390 * search.c (compile_pattern_1): Remove argument regp, unused since
7391 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7392 (compile_pattern): Don't pass it.
7393
0afb4571
J
73942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7395
7396 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7397 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7398 for ! HAVE_GTK3.
7399 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7400
7401 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7402
7403 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7404 gdk_window_get_screen, gdk_window_get_geometry,
7405 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7406 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7407 (xg_get_pixbuf_from_pixmap): New function.
7408 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7409 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7410 Call xg_get_pixbuf_from_pixmap instead of
7411 gdk_pixbuf_get_from_drawable.
7412 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7413 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7414 (xg_check_special_colors): Use GtkStyleContext and its functions
7415 for HAVE_GTK3.
7416 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7417 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7418 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7419 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7420 Call gtk_widget_get_preferred_size.
0afb4571
J
7421 (xg_frame_resized): gdk_window_get_geometry only takes 5
7422 parameters.
44f230aa
SM
7423 (xg_win_to_widget, xg_event_is_for_menubar):
7424 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7425 (xg_set_widget_bg): New function.
7426 (delete_cb): New function.
895009e1 7427 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7428 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7429 (xg_set_background_color): Call xg_set_widget_bg.
7430 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7431 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7432 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7433 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7434 if ! HAVE_GTK3.
7435 (update_frame_tool_bar): Call gtk_widget_hide.
7436 (xg_initialize): Use GDK_KEY_g.
7437
7438 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7439 if ! HAVE_GTK3
7440 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7441
7442 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7443 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7444 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7445
1c2cc4ef
JB
74462011-03-08 Juanma Barranquero <lekktu@gmail.com>
7447
7448 * w32xfns.c (select_palette): Check success of RealizePalette against
7449 GDI_ERROR, not zero.
7450
33383987 7451See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7452
7453;; Local Variables:
7454;; coding: utf-8
aac0c6e3
MR
7455;; End:
7456
33383987 7457 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7458
7459 This file is part of GNU Emacs.
7460
7461 GNU Emacs is free software: you can redistribute it and/or modify
7462 it under the terms of the GNU General Public License as published by
7463 the Free Software Foundation, either version 3 of the License, or
7464 (at your option) any later version.
7465
7466 GNU Emacs is distributed in the hope that it will be useful,
7467 but WITHOUT ANY WARRANTY; without even the implied warranty of
7468 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7469 GNU General Public License for more details.
7470
7471 You should have received a copy of the GNU General Public License
7472 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.