Fix bug 9869.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
6e56383b
JD
12011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2
3 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5 HAVE_GTK3 (Bug#9869).
b77a6a7f 6
3b574623
JD
7 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9
b77a6a7f
JD
10 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
11
12 * xterm.c: Declare x_handle_net_wm_state to return int.
13 (handle_one_xevent): Check if we are iconified but don't have
14 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
15 (get_current_wm_state): Return non-zero if not hidden,
16 check for _NET_WM_STATE_HIDDEN (Bug#9893).
17 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
18 (x_handle_net_wm_state): Return what get_current_wm_state returns.
19 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
20
196e41e4
PE
212011-10-29 Paul Eggert <eggert@cs.ucla.edu>
22
23 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
24 so that this new function doesn't get optimized away by a
25 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
26
021f2e1a
AS
272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
28
29 * frame.h (MOUSE_HL_INFO): Remove excess parens.
30
8b058d44
EZ
312011-10-29 Eli Zaretskii <eliz@gnu.org>
32
33 Fix the `xbytecode' command.
34 * .gdbinit (xprintbytestr): New command.
35 (xwhichsymbols): Renamed from `which'; all callers changed.
36 (xbytecode): Print the byte-code string as well.
37
4452fb80
EZ
382011-10-29 Kim Storm <storm@cua.dk>
39
8b058d44
EZ
40 * alloc.c (which_symbols): New function.
41
21b72067
AS
422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
43
44 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
45 line. (Bug#9903)
46
83ed7b5c
GM
472011-10-29 Glenn Morris <rgm@gnu.org>
48
49 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
50 Not clear what it was for, and it causes various bugs. (Bug#9839)
51
5a7a728b
EZ
522011-10-28 Eli Zaretskii <eliz@gnu.org>
53
54 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
55 possible random value that matches one of those tested as
56 condition to clear the mouse face.
57
d3d0842f
CY
582011-10-28 Chong Yidong <cyd@gnu.org>
59
60 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
61
31b39d13
DN
622011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
63
64 * window.c (make_window): Initialize phys_cursor_on_p.
65
9aba6043
SM
662011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
67
68 * lisp.h (struct Lisp_Symbol): Update comments.
69
c20992f4
JB
702011-10-28 Juanma Barranquero <lekktu@gmail.com>
71
72 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
73
db4f02f2
EZ
742011-10-28 Eli Zaretskii <eliz@gnu.org>
75
76 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
77 <oslsachem@gmail.com> for helping to debug this.
78
79 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
80 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
81 (g_b_init_get_glyph_outline_w): New static variables.
82 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
83 (GetGlyphOutlineW_Proc): New typedefs.
84 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
85 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
86 New functions.
87 (w32font_open_internal, compute_metrics):
88 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
89 instead of calling the "wide" APIs directly.
90
91 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
92
93 * w32.h (syms_of_w32font): Add prototype.
94
87e68db4
JB
952011-10-27 Juanma Barranquero <lekktu@gmail.com>
96
97 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
98 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
99 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
100 (Fmove_to_window_line): Doc fix.
101
435c1d67
CY
1022011-10-27 Chong Yidong <cyd@gnu.org>
103
104 * process.c (make_process): Set gnutls_state to NULL.
105
106 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
107 non-NULL, regardless of GNUTLS_INITSTAGE.
108 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
109 an error. Set process slots as soon as we allocate them.
110
111 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
112
9c6c6f49
CY
1132011-10-27 Chong Yidong <cyd@gnu.org>
114
9aba6043
SM
115 * gnutls.c (emacs_gnutls_deinit): New function.
116 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
117 (Fgnutls_deinit, Fgnutls_boot): Use it.
118
119 * process.c (make_process): Initialize GnuTLS credentials to NULL.
120 (deactivate_process): Call emacs_gnutls_deinit.
121
657d08d3
JB
1222011-10-27 Juanma Barranquero <lekktu@gmail.com>
123
124 * image.c (x_create_x_image_and_pixmap):
125 * w32.c (sys_rename, w32_delayed_load):
126 * w32font.c (fill_in_logfont):
127 * w32reg.c (x_get_string_resource): Silence compiler warnings.
128
5430d399
JB
1292011-10-26 Juanma Barranquero <lekktu@gmail.com>
130
131 * w32fns.c (w32_default_color_map): New function,
132 extracted from Fw32_default_color_map.
a7ef684b 133 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 134
fe0055fa
PE
1352011-10-25 Paul Eggert <eggert@cs.ucla.edu>
136
137 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
138
e6346438
SM
1392011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
140
141 * keyboard.c (test_undefined): New function (bug#9751).
142 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
143
e112cc37
ET
1442011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
145
146 * sysdep.c (init_sys_modes): Fix the check for the controlling
147 terminal (Bug#6649).
148
7b5d6677
EZ
1492011-10-20 Eli Zaretskii <eliz@gnu.org>
150
151 * dispextern.h (struct bidi_it): New member next_en_type.
152
153 * bidi.c (bidi_line_init): Initialize the next_en_type member.
154 (bidi_resolve_explicit_1): When next_en_pos is valid for the
155 current character, check also for next_en_type being WEAK_EN.
156 (bidi_resolve_weak): Don't enter the expensive loop if the current
157 position is before next_en_pos. Record the bidi type of the first
158 non-ET, non-BN character we find, in addition to its position.
159 (bidi_level_of_next_char): Invalidate next_en_type when
160 next_en_pos is over-stepped.
161
7da0b018
PE
1622011-10-20 Paul Eggert <eggert@cs.ucla.edu>
163
164 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
165 * editfns.c: Rewrite current-time-zone so that it invokes
166 the equivalent of (format-time-string "%Z") to get the time zone name.
167 This fixes a bug when the time zone name contains characters that
168 need converting from the system time locale to Emacs internal format.
169 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
170 that patch fixed format-time-string to do the conversion, but
171 I forgot to fix current-time-zone.
172 (format_time_string): New function, containing most of
173 what Fformat_time_string used to contain.
174 (Fformat_time_string): Rewrite in terms of format_time_string.
175 This doesn't change this function's behavior.
176 (current-time-zone): Rewrite to use format_time_string.
177 This fixes the bug reported by Michael Schierl in
178 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
179 Jason Rumney's 2007-06-07 change worked around this bug, but
180 didn't fix it.
181 * systime.h (tzname, timezone): Remove no-longer-used declarations.
182
8547b010
EZ
1832011-10-19 Eli Zaretskii <eliz@gnu.org>
184
185 * xdisp.c (start_display): If the character at POS is displayed
186 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
187 (try_window_reusing_current_matrix): If a line ends in a display
188 vector or the next line starts in a display vector, continue
189 redrawing the window even though the character position of
190 start_row was reached.
8547b010
EZ
191 (Bug#9771, part 2)
192
4e948d15
CY
1932011-10-18 Chong Yidong <cyd@gnu.org>
194
195 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
196 with nobreak-char-display too.
197
4787455f
EZ
1982011-10-18 Eli Zaretskii <eliz@gnu.org>
199
200 Fix part 3 of bug#9771.
201 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
202 (bidi_resolve_neutral): Don't enter the expensive loop looking for
203 non-neutral characters if the current character is a paragraph
204 separator (a.k.a. Newline). This avoids running the same
205 expensive loop twice, once when we consume the preceding newline
206 and the other time when the line actually needs to be displayed.
207 Avoid the loop when we see neutrals on the base embedding level
208 following a character whose directionality is the same as the
209 paragraph's. This avoids running the expensive loop when a line
210 ends in a long sequence of neutrals, like control characters.
211 Add assertion against STRONG_AL type. Slightly rearrange code
212 that determines the type of a neutral given the first non-neutral
213 that follows it.
214 (bidi_level_of_next_char): Set next_en_pos to zero when
215 invalidating its info.
216
2c91f553
EZ
2172011-10-17 Eli Zaretskii <eliz@gnu.org>
218
219 * xdisp.c (push_display_prop): Determine whether to record string
220 or buffer position by IT->string, not by IT->method. Allow
221 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
222 (move_it_vertically_backward): Don't look for character position
223 immediately after the newline when in a continuation line.
224 (Bug#9771, part 1)
2c91f553 225
c7b08b0d
MR
2262011-10-15 Martin Rudalics <rudalics@gmx.at>
227
228 * window.c (coordinates_in_window): Rewrite and delabelize
229 vertical border check. (Bug#5357) (Bug#9618)
230
6b02f655
SM
2312011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
232
233 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
234 errors in XSetWindowBorder (bug#9310).
235
81d40c92
DA
2362011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
237
238 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
239 avoid crash when xmalloc overrun checking is enabled.
240
d4172c3b
EZ
2412011-10-13 Eli Zaretskii <eliz@gnu.org>
242
243 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
244 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
245 cursor motion with <left> and <right> arrow keys.
246
247 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
248 some callers set that themselves.
249
b00eea75
EZ
2502011-10-12 Eli Zaretskii <eliz@gnu.org>
251
252 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
253 display string and the previous row comes from the same string and
254 is empty. (Bug#9739) (Bug#9738)
255
8fe012c4
SM
2562011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * doc.c (get_doc_string): Encode file name (bug#9735).
259
0074aef2
EZ
2602011-10-12 Eli Zaretskii <eliz@gnu.org>
261
79beb178
EZ
262 * bidi.c (bidi_level_of_next_char):
263 * xdisp.c (get_visually_first_element): Remove old incorrect
264 comments regarding the Unicode Line Separator character.
265
0074aef2
EZ
266 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
267
6e4b3fbe
DA
2682011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
269
270 * alloc.c (Fgc_status): Do not access beyond zombies array
271 boundary if nzombies > MAX_ZOMBIES.
272 * alloc.c (dump_zombies): Add missing format specifier.
273
0324f3af
PE
2742011-10-12 Paul Eggert <eggert@cs.ucla.edu>
275
b5525cac
PE
276 * xdisp.c (set_cursor_from_row): Simplify conditionals,
277 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
278
0324f3af
PE
279 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
280 Some packages use them to denote characters with modifiers.
281
e9b5f888
AS
2822011-10-11 Andreas Schwab <schwab@linux-m68k.org>
283
284 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
285 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
286 matching a pp-number. Rename parameter var to var1.
287
127827c0
SM
2882011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
289
290 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
291
c8fd3bd0
GM
2922011-10-08 Glenn Morris <rgm@gnu.org>
293
294 * callint.c (Fcall_interactively): Give a more explicit error for the
295 'c' case with a non-character input. (Bug#8479)
296
352ec8ff
EZ
2972011-10-08 Eli Zaretskii <eliz@gnu.org>
298
03669ccb
EZ
299 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
300 lines.
7061c986
EZ
301 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
302 lines that are hscrolled on the left.
03669ccb 303
352ec8ff
EZ
304 * dispnew.c (buffer_posn_from_coords): Account for a possible
305 presence of header-line. (Bug#4426)
306
a66cfb1c
SM
3072011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
308
6b02f655
SM
309 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
310 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 311
7c5ee88e
PE
3122011-10-07 Paul Eggert <eggert@cs.ucla.edu>
313
314 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
315 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
316 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
317 this makes Emacs dump core during garbage collection on rare
318 occasions. sizeof is obviously inferior to offsetof here, so
319 stick with offsetof.
320 (GC_POINTER_ALIGNMENT): New macro.
321 (mark_memory): Omit 3rd (offset) arg; caller changed.
322 Don't assume EMACS_INT alignment is the same as pointer alignment.
323
df1bbe5b
SM
3242011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * keyboard.c (read_key_sequence_remapped): New var.
327 (read_key_sequence): Compute remapping in the right buffer.
328 (command_loop_1): Use read_key_sequence's remapping directly.
329
51553db6
SM
3302011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
331
32c1fffd
SM
332 * dired.c (file_name_completion): Don't expand file name.
333 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
334 before checking file name handler.
335
51553db6
SM
336 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
337 they've been requested explicitly (bug#9591).
338
b6bd1599 3392011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
340
341 * keymap.c (Fsingle_key_description): Use make_specified_string
342 instead of build_string to build string from push_key_description.
343 (Bug#5193)
344
f701dc2a
PE
3452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
346
4222c55d
PE
347 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
348 This fixes a Y2038 bug on 64-bit hosts.
349 * buffer.c (reset_buffer):
350 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
351 (Fclear_buffer_auto_save_failure):
352 Use 0, not -1, to represent an unset failure time, since time_t
353 might not be signed.
354
f701dc2a
PE
355 Remove dependency on glibc malloc internals.
356 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
357 Move back here from lisp.h, but with their new implementations.
358 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
359 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
360 * charset.c (charset_table_init): New static var.
361 (syms_of_charset): Use it instead of xmalloc. This removes a
362 dependency on glibc malloc internals. See Eli Zaretskii's comment in
363 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
364 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
365 Move back to alloc.c.
366 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
367 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
368
9ceebf39
JD
3692011-09-30 Jan Djärv <jan.h.d@swipnet.se>
370
371 * nsterm.m (windowDidResize): Call x_set_window_size only when
372 ns_in_resize is true. Otherwise set pixelwidth/height and
373 call change_frame_size (Bug#9628).
374
cb993c58
PE
3752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
376
3930c88b
PE
377 Port --enable-checking=all to Fedora 14 x86-64.
378 * charset.c (syms_of_charset): Also account for glibc malloc's
379 internal overhead when calculating the initial malloc maximum.
380
cb993c58
PE
381 Port --enable-checking=all to Fedora 14 x86.
382 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
383 Move to lisp.h.
384 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
385 (overrun_check_realloc, overrun_check_free):
386 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
387 That way, xmalloc returns a properly-aligned pointer even if
388 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
389 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
390 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
391 into account when calculating the initial malloc maximum.
392 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
393 Move here from alloc.c, so that charset.c can use it too.
394 Properly align; the old code wasn't right for common 32-bit hosts
395 when configured with --enable-checking=all.
396 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
397 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
398
31bed486
EZ
3992011-09-29 Eli Zaretskii <eliz@gnu.org>
400
04c70788 401 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
402 use EDOM.
403
fbcaa2f3
EZ
4042011-09-28 Eli Zaretskii <eliz@gnu.org>
405
406 * xdisp.c (compute_display_string_end): If there's no display
407 string at CHARPOS, return -1.
408
409 * bidi.c (bidi_fetch_char): When compute_display_string_end
410 returns a negative value, treat the character as a normal
411 character not covered by a display string. (Bug#9624)
412
a239d4e9
JB
4132011-09-28 Juanma Barranquero <lekktu@gmail.com>
414
415 * lread.c (Fread_from_string): Fix typo in docstring.
416
88652fd5
EZ
4172011-09-27 Eli Zaretskii <eliz@gnu.org>
418
419 * xdisp.c (handle_invisible_prop): If invisible text ends on a
420 newline, reseat the iterator instead of bidi-iterating there one
421 character at a time. (Bug#9610)
32c1fffd
SM
422 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
423 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 424
ed497dd4
AS
4252011-09-27 Andreas Schwab <schwab@linux-m68k.org>
426
427 * lread.c (readevalloop): Use correct code for NBSP.
428 (read1): Likewise. (Bug#9608)
429
b2bf61aa
MA
4302011-09-25 Michael Albinus <michael.albinus@gmx.de>
431
432 * dbusbind.c (Fdbus_register_signal): When service is not
433 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
434
32bbb17c
GM
4352011-09-25 Glenn Morris <rgm@gnu.org>
436
437 * buffer.c (truncate-lines): Doc fix.
438
94e0933e
CY
4392011-09-24 Chong Yidong <cyd@stupidchicken.com>
440
441 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
442 (Fset_window_next_buffers): Doc fix.
443
cddde921
GM
4442011-09-24 Glenn Morris <rgm@gnu.org>
445
446 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
447
1260aef1
PE
4482011-09-24 Paul Eggert <eggert@cs.ucla.edu>
449
25b4bfa0
PE
450 Fix minor problems found by static checking.
451 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
452 * indent.c (Fvertical_motion): Fix == vs = typo.
453
e3cbd34b
EZ
4542011-09-24 Eli Zaretskii <eliz@gnu.org>
455
a66cfb1c
SM
456 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
457 Default value is now t. Doc fix.
6bf7006f 458
e3cbd34b 459 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 460 logic when moving up, not only when moving down. Fix the
e3cbd34b 461 confusing name and values of the it_overshoot_expected variable;
32c1fffd 462 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
463
464 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
465 CHARPOS is covered by a display string which includes newlines.
466 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
467 is covered by a display string with embedded newlines.
468
a3de0cbd
MA
4692011-09-24 Michael Albinus <michael.albinus@gmx.de>
470
471 * dbusbind.c (Fdbus_register_signal): Add match rule to
472 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
473 (Fdbus_register_method, Vdbus_registered_objects_table):
474 Fix docstring.
a3de0cbd 475
b260039d
JM
4762011-09-24 Jim Meyering <meyering@redhat.com>
477
32c1fffd 478 do not ignore write error for any output size
b260039d
JM
479 The previous change was incomplete.
480 While it makes emacs --batch detect the vast majority of stdout
481 write failures, errors were still ignored whenever the output size is
482 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
483 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
484 && echo FAIL: ignored write error
485 FAIL: ignored write error
486 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
487 && echo FAIL: ignored write error
488 FAIL: ignored write error
489 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
490
8eca8a7c
AS
4912011-09-23 Andreas Schwab <schwab@linux-m68k.org>
492
493 * emacs.c (Fkill_emacs): In noninteractive mode exit
494 non-successfully if a write error occurred on stdout. (Bug#9574)
495
3341db62
EZ
4962011-09-21 Eli Zaretskii <eliz@gnu.org>
497
498 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
499 the xassert test.
500
501 * dispextern.h (struct it): Update the comment documenting what
502 can it->OBJECT be.
503
8c203dbf
EZ
5042011-09-20 Eli Zaretskii <eliz@gnu.org>
505
506 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
507 a display string, extend search for cursor position to end of row.
508 (find_row_edges): If the row ends in a newline from a display
509 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
510 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
511 (Fcurrent_bidi_paragraph_direction): Fix search for previous
512 non-empty line. Fixes confusing cursor motion with arrow keys at
513 the beginning of a line that starts with whitespace.
8c203dbf 514
a4824228
LMI
5152011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
516
517 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
518 (bug#9493).
519
33ed493b
CY
5202011-09-18 Chong Yidong <cyd@stupidchicken.com>
521
522 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
523 boolean (Bug#9154).
524
56cd55c8
EZ
5252011-09-18 Eli Zaretskii <eliz@gnu.org>
526
527 * xdisp.c (display_line): Record maximum and minimum buffer
528 positions even if no glyphs were produced (e.g., by a zero-width
529 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
530 buffer positions that will be removed from the glyph row because
531 they don't fit.
c02dcedf
EZ
532 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
533 column is beyond frame width: don't subtract 1 "pixel" when
534 computing width of the stretch.
3e62b7e0
EZ
535 (reseat_at_next_visible_line_start): Undo the change made on
536 2011-09-17 that saved paragraph information and restored it after
537 the call to `reseat'. (Bug#9545)
56cd55c8 538
5ed99d36 5392011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
540
541 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
542 and turn window cursor on if cleared (Bug#9415).
543
5ed99d36 5442011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
545
546 * search.c (boyer_moore): Take unibyte characters from pattern
547 literally. (Bug#9458)
548
9bade7b2
EZ
5492011-09-18 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
552
e5e9d610
PE
5532011-09-18 Paul Eggert <eggert@cs.ucla.edu>
554
87e4427a
PE
555 Fix minor problem found by static checking.
556 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
557 initialized, to pacify gcc -Wuninitialized.
558
e5e9d610
PE
559 * fileio.c: Report proper errno when syscall falls.
560 (Finsert_file_contents): Save and restore errno,
561 so that report_file_error outputs the correct diagnostic.
562 (Fwrite_region) [CLASH_DETECTION]: Likewise.
563
a1674f0b
EZ
5642011-09-18 Eli Zaretskii <eliz@gnu.org>
565
566 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
567
fbfb6dd4
EZ
5682011-09-17 Eli Zaretskii <eliz@gnu.org>
569
570 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
571 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
572
bb187662
EZ
5732011-09-17 Eli Zaretskii <eliz@gnu.org>
574
1137e8b8 575 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 576 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
577
578 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
579 (bidi_find_paragraph_start): Search back for paragraph beginning
580 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
581 (bidi_move_to_visually_next): Only trigger paragraph-related
582 computations when the last character is a newline or at EOB, not
583 just any NEUTRAL_B. (Bug#9470)
584
bb187662
EZ
585 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
586 truncated lines if point is covered by a display string. (Bug#9524)
587
2e621251
PE
5882011-09-16 Paul Eggert <eggert@cs.ucla.edu>
589
590 * xselect.c: Relax test for outgoing X longs (Bug#9498).
591 (cons_to_x_long): New function.
592 (lisp_data_to_selection_data): Use it. Correct the test for
593 short-versus-long data; it was negated. Break out of vector
594 loop, for efficiency, when a long datum is discovered.
595
91a15bc6
SM
5962011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
597
598 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
599
b41c3a35
EZ
6002011-09-16 Eli Zaretskii <eliz@gnu.org>
601
602 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
603 GCC PR/17406) by declaring this function with external scope.
604
7812ba2d
PE
6052011-09-15 Paul Eggert <eggert@cs.ucla.edu>
606
607 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
608 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
609
cf7edc2a
AS
6102011-09-15 Andreas Schwab <schwab@linux-m68k.org>
611
612 * editfns.c (Fformat): Correctly handle text properties on "%%".
613
bd01620e
EZ
6142011-09-15 Eli Zaretskii <eliz@gnu.org>
615
616 * xterm.c (x_draw_composite_glyph_string_foreground):
617 * w32term.c (x_draw_composite_glyph_string_foreground):
618 * term.c (encode_terminal_code):
619 * composite.c (composition_update_it, get_composition_id):
620 * xdisp.c (get_next_display_element)
621 (fill_composite_glyph_string): Add comments about special meaning
622 of TAB characters in a composition.
623
a02719a3
PE
6242011-09-15 Paul Eggert <eggert@cs.ucla.edu>
625
626 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
627 This occurs when processing a multibyte format.
628 Problem reported by Wolfgang Jenker.
a02719a3 629
72589a3c
JB
6302011-09-15 Johan Bockgård <bojohan@gnu.org>
631
632 * xdisp.c (try_cursor_movement): Only check for exact match if
633 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
634
1c14176c
PE
6352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
636
637 Remove unused external symbols.
638 * dispextern.h (calc_pixel_width_or_height): Remove decl.
639 * xdisp.c (calc_pixel_width_or_height): Now static.
640 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
641 * indent.c (check_display_width):
642 * w32term.c: Fix comment to match code.
643 * xterm.c, xterm.h (x_catching_errors): Remove.
644
d2eea5b5
PE
6452011-09-14 Paul Eggert <eggert@cs.ucla.edu>
646
647 * xselect.c: Use signed conversions more consistently (Bug#9498).
648 (selection_data_to_lisp_data): Assume incoming selection data are
649 signed integers, not unsigned. This is to be consistent with
650 outgoing selection data, which was modified to use signed integers
651 in as part of the fix to Bug#9196 in response to Jan D.'s comment
652 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
653 expects long, not unsigned long.
654
46888499
EZ
6552011-09-14 Eli Zaretskii <eliz@gnu.org>
656
657 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
658 computation of loop end. Reported by Johan Bockgård
659 <bojohan@gnu.org>.
660
ef8ef9fb
CY
6612011-09-13 Chong Yidong <cyd@stupidchicken.com>
662
663 * frame.c (Fother_visible_frames_p): Function deleted.
664
fa819fed
EZ
6652011-09-12 Eli Zaretskii <eliz@gnu.org>
666
667 * indent.c (compute_motion): Process display vector front to back
668 rather than the other way around. (Bug#2496)
669
2ba8e008
SM
6702011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
671
672 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
673
20f53c69
CY
6742011-09-11 Chong Yidong <cyd@stupidchicken.com>
675
676 * minibuf.c (Fread_from_minibuffer): Doc fix.
677
d562d7a4
EZ
6782011-09-11 Eli Zaretskii <eliz@gnu.org>
679
680 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
681 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
682
1c4d7f3d
LMI
6832011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
684
685 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
686 value for non-existent files.
687
b885bf36
EZ
6882011-09-11 Eli Zaretskii <eliz@gnu.org>
689
690 * fileio.c (Finsert_file_contents): If the file cannot be opened,
691 set its "size" to -1. This will set the modtime_size field of
692 the corresponding buffer to -1, which is what
693 verify-visited-file-modtime expects for files that do not exist.
694 (Bug#9139)
695
6612f0bf
PE
6962011-09-11 Paul Eggert <eggert@cs.ucla.edu>
697
698 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
699 here ...
700 * lisp.h: ... from here. push_key_description is no longer
701 defined in keyboard.c, so its declaration should not be in
702 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
703 logically belongs with push_key_description.
704
dfb3f755
PE
7052011-09-10 Paul Eggert <eggert@cs.ucla.edu>
706
707 * buffer.h: Include <sys/types.h> instead of <time.h>.
708 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
709 Problem reported by Herbert J. Skuhra.
710
3134906c
LMI
7112011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
712
713 * xml.c (parse_region): Make the parsing work for
714 non-comment-starting XML files again (bug#9144).
715
8d903f4e
AS
7162011-09-10 Andreas Schwab <schwab@linux-m68k.org>
717
718 * image.c (gif_load): Fix calculation of bottom and right corner.
719 (Bug#9468)
720
80ad64f4
EZ
7212011-09-10 Eli Zaretskii <eliz@gnu.org>
722
723 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
724 redisplay in small windows.
725
208a048d
EZ
7262011-09-09 Eli Zaretskii <eliz@gnu.org>
727
728 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
729
9b1c252e
MR
7302011-09-08 Martin Rudalics <rudalics@gmx.at>
731
732 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
733 Operate on live windows only.
734
2949f33b
JB
7352011-09-08 Juanma Barranquero <lekktu@gmail.com>
736
737 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
738
e08dcafd
EZ
7392011-09-07 Eli Zaretskii <eliz@gnu.org>
740
741 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
742 only under bidi iteration.
743
115b96bd
JD
7442011-09-07 Jan Djärv <jan.h.d@swipnet.se>
745
746 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
747
c8199d0f
PE
7482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
749
750 isnan: Fix porting problem to Solaris 10 with bundled gcc.
751 Without this fix, the command to link temacs failed due to an
752 undefined symbol __builtin_isnan. This is because
753 /usr/include/iso/math_c99.h #defines isnan(x) to
754 __builtin_isnan(x), but the bundled gcc, which identifies itself
755 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
756 a __builtin_isnan.
757 * floatfns.c (isnan): #undef, and then #define to a clone of
758 what's in data.c.
759 (Fisnan): Always define, since it's always available now.
760 (syms_of_floatfns): Always define isnan at the Lisp level.
761
e39b275c 7622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
763
764 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
765
b2db44d9 7662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 767
f4af5137 768 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
769 The previous code assumed that file offsets (off_t values) fit in
770 EMACS_INT variables, which is not true on typical 32-bit hosts.
771 The code messed up by falsely reporting buffer overflow in cases
772 such as (insert-file-contents "big" nil 1 2) into an empty buffer
773 when "big" contains more than 2**29 bytes, even though this
774 inserts just one byte and does not overflow the buffer.
775 (Finsert_file_contents): Store file offsets as off_t
776 values, not as EMACS_INT values. Check for overflow when
777 converting between EMACS_INT and off_t. When checking for
778 buffer overflow or for overlap, take the offsets into account.
779 Don't use EMACS_INT for small values where int suffices.
780 When checking for overlap, fix a typo: ZV was used where
781 ZV_BYTE was intended.
782 (Fwrite_region): Don't assume off_t fits into 'long'.
783 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
784
ecfc0a49
MA
7852011-09-05 Michael Albinus <michael.albinus@gmx.de>
786
787 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
788
6511acf2 7892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 790
0999621a 791 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
792
793 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 794 (esprintf, exprintf, evxprintf): New functions.
62f19c19 795 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 796 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
797 (modify_event_symbol): Do not assume that the length of
798 name_alist_or_stem is safe to alloca and fits in int.
799 (Fexecute_extended_command): Likewise for function name and binding.
800 (Frecursion_depth): Wrap around reliably on integer overflow.
801 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
802 since some callers pass EMACS_INT values.
803 (Fsingle_key_description): Don't crash if symbol name contains more
804 than MAX_ALLOCA bytes.
805 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
806 (get_minibuffer): Arg is now EMACS_INT, not int.
807 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 808 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
809 * window.h (command_loop_level, minibuf_level): Reflect API changes.
810
2be7d702
PE
811 * dbusbind.c (signature_cat): New function.
812 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
813 Do not overrun buffer; instead, report string overflow.
814
9d1df220
PE
815 * dispnew.c (add_window_display_history): Don't overrun buffer.
816 Truncate instead; this is OK since it's just a log.
817
33ef5c64
PE
818 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
819 even if the time zone offset is outlandishly large.
820 Don't mishandle offset == INT_MIN.
821
66c6fdd5
PE
822 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
823 when creating daemon; the previous buffer-overflow check was incorrect.
824
d749b01b
PE
825 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
826 which has the guts of the old verror function.
827
b5cd1905
PE
828 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
829 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
830
6e1a67fb
PE
831 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
832 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 833 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 834 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
835 length of string rather than counting it via multiple sprintfs;
836 that's simpler and more reliable.
c21721cc
PE
837 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
838 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
839 sprintf, in case result does not fit in int.
840
c57b67fc
PE
841 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
842 (fontset_from_font): Print it.
843
8a401434
PE
844 * frame.c (tty_frame_count): Now printmax_t, not int.
845 (make_terminal_frame, set_term_frame_name): Print it.
846 (x_report_frame_params): In X, window IDs are unsigned long,
847 not signed long, so print them as unsigned.
848 (validate_x_resource_name): Check for implausibly long names,
849 and don't assume name length fits in 'int'.
850 (x_get_resource_string): Don't blindly alloca invocation name;
851 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
852 not fit in int.
853
6e1a67fb
PE
854 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
855 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
856 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
857
0df02bf3
PE
858 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
859 Use esprintf, not sprintf, in case result does not fit in int.
860
48e30793
PE
861 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
862 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
863 it as a large positive number.
864 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
865 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
866
a66ff6d8
PE
867 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
868 in case result does not fit in int.
869
aca216ff
PE
870 * print.c (float_to_string): Detect width overflow more reliably.
871 (print_object): Make sprintf buffer a bit bigger, to avoid potential
872 buffer overrun. Don't assume list length fits in 'int'. Treat
873 print length of 0 as 0, not as infinity; to be consistent with other
874 uses of print length in this function. Don't overflow print length
875 index. Don't assume hash table size fits in 'long', or that
876 vectorlike size fits in 'unsigned long'.
877
31c286f7
PE
878 * process.c (make_process): Use printmax_t, not int, to format
879 process-name gensyms.
880
55e5faa1
PE
881 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
882
80f2e268
PE
883 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
884 to avoid potential buffer overrun.
885
670741ab
PE
886 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
887 if X resource line is longer than 512 bytes.
888
b7163a50
PE
889 * xfns.c (x_window): Make sprintf buffer a bit bigger
890 to avoid potential buffer overrun.
891
ae58ff1f
PE
892 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
893
c43c8a6a
PE
894 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
895
3f8236f4
PE
8962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
897
53e9fe90 898 Integer overflow fixes for scrolling, etc.
6511acf2
PE
899 Without these, Emacs silently mishandles large integers sometimes.
900 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
901 it were "C-u 1 M-x recenter" on a typical 64-bit host.
902
6511acf2
PE
903 * xdisp.c (try_window_id): Check Emacs fixnum range before
904 converting to 'int'.
806add1d 905
6511acf2 906 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
907 Check that an Emacs fixnum is in range before assigning it to 'int'.
908 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
909 values converted from Emacs fixnums.
910 (Frecenter): Don't wrap around a line count if it is out of 'int'
911 range; instead, treat it as an extreme value.
912 (Fset_window_configuration, compare_window_configurations):
913 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
914
6511acf2
PE
915 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
916 that can exceed INT_MAX. Check that EMACS_INT value is in range
917 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
918 (match_limit): Don't assume that a fixnum can fit in 'int'.
919
6511acf2 920 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
921 exceed INT_MAX.
922
6511acf2 923 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
924 (Fvertical_motion): Don't wrap around LINES values that don't fit
925 in 'int'. Instead, treat them as extreme values. This is good
926 enough for windows, which can't have more than INT_MAX lines anyway.
927
fcb901a7
LMI
9282011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
929
0f2f6b6d
LMI
930 * Require libxml/parser.h to avoid compilation warning.
931
fcb901a7
LMI
932 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
933
934 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
935 since this reportedly can destroy thread storage.
936
6e20a0d4
CY
9372011-08-30 Chong Yidong <cyd@stupidchicken.com>
938
939 * syntax.c (find_defun_start): Update all cache variables if
940 exiting early (Bug#9401).
941
148ae00e
EZ
9422011-08-30 Eli Zaretskii <eliz@gnu.org>
943
f6cfbd8f
EZ
944 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
945
148ae00e
EZ
946 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
947 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
948 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
949
950 * term.c (tty_append_glyph): New function.
951 (produce_stretch_glyph): Static function and its prototype deleted.
952
a66cfb1c
SM
953 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
954 Add prototypes.
148ae00e 955
c4a07a4c
PE
9562011-08-29 Paul Eggert <eggert@cs.ucla.edu>
957
958 * image.c (parse_image_spec): Check for nonnegative, not for positive,
959 when checking :margin (Bug#9390).
960 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 961 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
962 so that the name doesn't mislead. All uses changed.
963
6bc8cd65
JB
9642011-08-28 Johan Bockgård <bojohan@gnu.org>
965
966 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
967 set_tty_hooks.
968
dca4927e
EZ
9692011-08-27 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (move_it_to): Don't bail out early when reaching
972 position beyond to_charpos, if we are scanning backwards.
973 (move_it_vertically_backward): When DY == 0, make sure we get to
974 the first character in the line after the newline.
975
f2cad773
PE
9762011-08-27 Paul Eggert <eggert@cs.ucla.edu>
977
978 * ccl.c: Improve and simplify overflow checking (Bug#9196).
979 (ccl_driver): Do not generate an out-of-range pointer.
980 (Fccl_execute_on_string): Remove unnecessary check for
981 integer overflow, noted by Stefan Monnier in
982 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
983 Remove a FIXME that didn't need fixing.
984 Simplify the newly-introduced buffer reallocation code.
985
0cae2cdb
JB
9862011-08-27 Juanma Barranquero <lekktu@gmail.com>
987
988 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
989
5fc295a4 9902011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 991
70c60eb2 992 Integer and memory overflow issues (Bug#9196).
726e0ab1 993
d31850da
PE
994 * doc.c (get_doc_string): Rework so that
995 get_doc_string_buffer_size is the actual buffer size, rather than
996 being 1 less than the actual buffer size; this makes xpalloc more
997 convenient.
998
a69fbedb
PE
999 * image.c (x_allocate_bitmap_record, cache_image):
1000 * xselect.c (Fx_register_dnd_atom):
1001 Simplify previous changes by using xpalloc.
1002
fe5c5d37
PE
1003 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1004 since either will do and ptrdiff_t is convenient with xpalloc.
1005
0065d054
PE
1006 * charset.c (charset_table_size)
1007 (struct charset_sort_data.priority): Now ptrdiff_t.
1008 (charset_compare): Don't overflow if priorities differ greatly.
1009 (Fsort_charsets): Don't assume list length fits in int.
1010 Check for size-calculation overflow when allocating sort data.
1011 (syms_of_charset): Allocate an initial charset table that is
1012 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1013
1014 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1015
1016 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1017 The actual value is always <= INT_MAX, and leaving it unsigned made
1018 overflow checking harder.
1019
1020 * dispextern.h (struct glyph_matrix.rows_allocated)
1021 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1022 with xpalloc. The values are still always <= INT_MAX.
1023
1024 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1025
1026 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1027 (SAFE_NALLOCA): New macro.
1028
1029 * region-cache.c (struct boundary.pos, find_cache_boundary)
1030 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1031 (set_cache_region, invalidate_region_cache)
1032 (revalidate_region_cache, know_region_cache, region_cache_forward)
1033 (region_cache_backward, pp_cache):
1034 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1035 so that ptrdiff_t * can be passed to xpalloc.
1036 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1037 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1038 (pp_cache): Don't assume cache_len fits in int.
1039 * region-cache.h: Adjust extern decls to match.
1040
1041 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1042 EMACS_INT, since either will do, for xpalloc.
1043
1044 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1045 (xnmalloc, xnrealloc, xpalloc): New functions.
1046
726e0ab1
PE
1047 * bidi.c (bidi_shelve_header_size): New constant.
1048 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1049 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1050
51f30bc5 1051 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1052 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1053 (overlay_strings):
1054 Don't update size of array until after memory allocation succeeds,
1055 because xmalloc/xrealloc may not return.
0065d054
PE
1056 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1057 now that we have proper integer overflow checking.
1058 (record_overlay_string, overlay_strings): Catch overflows when
1059 calculating size of overlay_str_buf.
726e0ab1 1060
0065d054
PE
1061 * callproc.c (Fcall_process): Check for size overflow when
1062 calculating size of args2.
1063 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1064 Normally we prefer signed values, but sticking with ptrdiff_t would
1065 require adding more-complicated checks.
726e0ab1
PE
1066
1067 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1068 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1069 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1070 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1071
1072 * character.c (Fstring): Check for size-calculation overflow.
1073
1074 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1075 unnecessary integer overflow. Check for size overflow.
1076 (encode_coding_object): Don't update size until xmalloc succeeds.
1077
1078 * composite.c (get_composition_id): Check for overflow in glyph
1079 length calculations.
1080
1081 Integer and memory overflow fixes for display code.
1082 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1083 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1084 (scrolling_window): Check for overflow in size calculations.
1085 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1086 Don't assume glyph table len fits in int.
1087 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1088 (row_table_size): Now ptrdiff_t, not int.
1089 (scrolling_window): Avoid overflow in size calculations.
1090 Don't update size until allocation succeeds.
1091 * fns.c (concat): Check for overflow in size calculations.
1092 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1093 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1094 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1095
1096 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1097 (get_doc_string): Check for size calculation overflow.
1098 Don't update size until allocation succeeds.
1099 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1100 EMACS_INT, where ptrdiff_t will do.
1101 (Fsubstitute_command_keys): Check for string overflow.
1102
1103 * editfns.c (set_time_zone_rule): Don't assume environment length
1104 fits in int.
1105 (message_length): Now ptrdiff_t, not int.
1106 (Fmessage_box): Don't update size until allocation succeeds.
1107 Don't assume message length fits in int.
1108 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1109
0065d054
PE
1110 * emacs.c (main): Do not reallocate argv, since there is a null at
1111 the end that can be overwritten, and this way there's no need to
1112 worry about size-calculation overflow.
1113 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1114
1115 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1116 alloc succeeds.
1117 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1118
1119 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1120 (x_set_scroll_bar_width, x_figure_window_size):
1121 Check for integer overflow.
1122 (x_set_alpha): Do not assume XINT fits in int.
1123
1124 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1125 This is for the members text_lines, text_cols, total_lines, total_cols,
1126 where the system imposes an 'int' limit.
1127
1128 * fringe.c (Fdefine_fringe_bitmap):
1129 Don't update size until alloc works.
1130
1131 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1132 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1133
1134 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1135 Check for size-calculation overflow.
1136 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1137 do, as we prefer signed integers.
1138 (id_to_widget.max_size, id_to_widget.used)
1139 (xg_store_widget_in_map, xg_remove_widget_from_map)
1140 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1141 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1142 Use and return ptrdiff_t, not int.
1143 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1144 * gtkutil.h: Change prototypes to match the above.
1145
1146 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1147 are duplicate now that they've been promoted to lisp.h.
1148 (x_allocate_bitmap_record, x_alloc_image_color)
1149 (make_image_cache, cache_image, xpm_load):
1150 Don't update size until alloc is done.
1151 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1152 (x_detect_edges):
3256efce 1153 Check for size calculation overflow.
726e0ab1
PE
1154 (ct_colors_allocated_max): New constant.
1155 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1156 overflow.
3256efce 1157
726e0ab1
PE
1158 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1159 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1160 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1161 Use ptrdiff_t, not int, to count maps.
1162 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1163 calculations. Don't update size until allocation succeeds.
1164 Redo calculations to avoid overflow.
726e0ab1
PE
1165 * keyboard.h: Change prototypes to match the above.
1166
1167 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1168 to count maps.
1169 (current_minor_maps): Check for size calculation overflow.
1170 * keymap.h: Change prototypes to match the above.
1171
1172 * lread.c (read1, init_obarray): Don't update size until alloc done.
1173
1174 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1175 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1176
726e0ab1
PE
1177 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1178 Now ptrdiff_t, not int.
1179 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1180 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1181
1182 * process.c (Fnetwork_interface_list): Check for overflow
1183 in size calculation.
1184
1185 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1186
1187 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1188 overflow. Don't bother calling xmalloc when xrealloc will do.
1189
1190 * search.c (Freplace_match): Check for size calculation overflow.
1191 (Fset_match_data): Don't assume list lengths fit in 'int'.
1192
1193 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1194 for command line length. Do not attempt to address one before the
1195 beginning of an array, as that's not portable.
1196
1197 * term.c (max_frame_lines): Remove; unused.
1198 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1199 not int.
1200 (encode_terminal_code, calculate_costs): Check for size
1201 calculation overflow.
1202 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1203 table lengths and related sizes. Don't update size until alloc
1204 done. Redo calculations to avoid overflow.
1205 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1206
1207 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1208 subtracting pointers.
1209 (gobble_line): Check for overflow more carefully. Don't update size
1210 until alloc done.
1211
1212 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1213 Don't update size until alloc done.
1214 Redo size calculations to avoid overflow.
1215 Check for size calculation overflow.
0065d054 1216 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1217
1218 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1219 Use ptrdiff_t, not int, for sizes.
1220 (store_mode_line_noprop_char): Don't update size until alloc done.
1221
0065d054
PE
1222 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1223 Use ptrdiff_t, not int, for sizes.
1224 (Finternal_make_lisp_face, cache_face):
1225 Check for size calculation overflow.
1226 (cache_face): Treat size calculation overflows as if they were
1227 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1228
1229 * xfns.c (x_encode_text, x_set_name_internal)
1230 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1231 sizes, since they can exceed INT_MAX in size. Check for size
1232 calculation overflow.
1233
0065d054
PE
1234 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1235 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1236 Don't update size until alloc done.
1237
0065d054 1238 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1239 as sprintf is limited to int lengths.
1d526e2f 1240
252c5ee1
PE
1241 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1242 (X_LONG_MIN): New macros.
864d7ce7
PE
1243 Use them to make the following changes clearer.
1244 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1245 This change doesn't affect the value now, but it may help remind
1246 future maintainers not to raise the value too much later.
1247 (SELECTION_QUANTUM): Remove, replacing with ...
1248 (selection_quantum): ... new function, which avoids overflow.
1249 All uses changed.
1250 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1251 assumption that selection length fits in 'int'.
1252 (x_reply_selection_request, x_handle_selection_request)
1253 (x_get_window_property, receive_incremental_selection)
1254 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1255 (lisp_data_to_selection_data, clean_local_selection_data):
1256 Use ptrdiff_t, not int, to record length of selection.
1257 (x_reply_selection_request, x_get_window_property)
1258 (receive_incremental_selection, x_property_data_to_lisp):
1259 Redo calculations to avoid overflow.
1260 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1261 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1262 something.
1263 (x_get_window_property, receive_incremental_selection)
1264 (lisp_data_to_selection_data, x_property_data_to_lisp):
1265 Check for size-calculation overflow.
1266 (x_get_window_property, receive_incremental_selection)
1267 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1268 Don't store size until memory allocation succeeds.
1269 (x_get_window_property): Plug memory leak on memory exhaustion.
1270 Don't double-block input; malloc is safe here. Don't assume 2**34
1271 - 4 fits in unsigned long. Add an xassert to check
1272 XGetWindowProperty overflow. Be more careful about overflow
1273 calculations, and distinguish size from memory overflow better.
1274 (receive_incremental_selection): When tracing, don't assume
1275 unsigned int is less than INT_MAX.
1276 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1277 harmful) conversions of unsigned short to int.
1278 (lisp_data_to_selection_data): Don't assume that integers
1279 in the range -65535 through -1 fit in an X unsigned short.
1280 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1281 result parameters unless successful. Rely on cons_to_unsigned
1282 to report problems with elements; the old code wasn't right anyway.
1283 (x_check_property_data): Check for int overflow; we cannot use
1284 a wider type due to X limits.
1285 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1286
726e0ab1 1287 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1288
0065d054
PE
1289 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1290 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1291 (x_color_cells): Don't store size until memory allocation succeeds.
1292 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1293 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1294 (x_term_init): Don't assume length fits in int (sprintf is limited
1295 to int size).
bc18e09d 1296
ebfa62c0
PE
1297 Use ptrdiff_t for composition IDs.
1298 * character.c (lisp_string_width):
1299 * composite.c (composition_table_size, n_compositions)
1300 (get_composition_id, composition_gstring_from_id):
1301 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1302 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1303 * window.c (Frecenter):
1304 Use ptrdiff_t, not int, for composition IDs.
1305 * composite.c (get_composition_id): Check for integer overflow.
1306 * composite.h: Adjust prototypes to match the above changes.
1307
d3411f89
PE
1308 Use ptrdiff_t for hash table indexes.
1309 * category.c (hash_get_category_set):
1310 * ccl.c (ccl_driver):
1311 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1312 * coding.c (coding_system_charset_list, detect_coding_system):
1313 * coding.h (struct coding_system.id):
1314 * composite.c (get_composition_id, gstring_lookup_cache):
1315 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1316 * image.c (xpm_get_color_table_h):
1317 * lisp.h (hash_lookup, hash_put):
1318 * minibuf.c (Ftest_completion):
1319 Use ptrdiff_t for hash table indexes, not int (which is too
1320 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1321 32-bit --with-wide-int hosts).
1322
e097a6fa
PE
1323 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1324 Add a FIXME comment about memory leaks.
1325 (syms_of_charset): Don't assume xmalloc returns.
1326
5637687f
PE
1327 Don't assume that stated character widths fit in int.
1328 * character.c (Fchar_width, c_string_width, lisp_string_width):
1329 * character.h (CHAR_WIDTH):
1330 * indent.c (MULTIBYTE_BYTES_WIDTH):
1331 Use sanitize_char_width to avoid undefined and/or bad behavior
1332 with outlandish widths.
a66cfb1c 1333 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1334 now that we have two such functions. All uses changed.
1335 (sanitize_char_width): New inline function.
1336
a2271ba2
PE
1337 Don't assume that tab-width fits in int.
1338 * character.h (sanitize_width): New inline function.
1339 (SANE_TAB_WIDTH): New macro.
1340 (ASCII_CHAR_WIDTH): Use it.
1341 * indent.c (sane_tab_width): Remove. All uses replaced by
1342 SANE_TAB_WIDTH (current_buffer).
1343 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1344
18c52557
PE
1345 * fileio.c: Integer overflow issues with file modes.
1346 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1347
caeeedc1
PE
1348 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1349 Remove unreachable code.
1350 (read_hex, load_charset_map_from_file): Check for integer overflow.
1351
50849c52
PE
1352 * xterm.c: don't go over XClientMessageEvent limit
1353 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1354 (x_send_scroll_bar_event): Likewise. Check that the size does not
1355 exceed limits imposed by XClientMessageEvent, as well as the usual
1356 ptrdiff_t and size_t limits.
1357
b13995db
PE
1358 * keyboard.c: Overflow, signedness and related fixes.
1359 (make_lispy_movement): Use same integer type in forward decl
1360 that is used in the definition.
1361 (read_key_sequence, keyremap_step):
1362 Change bufsize argument back to int, undoing my 2011-03-30 change.
1363 We prefer signed types, and int is wide enough here.
1364 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1365 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1366 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1367 length, not size_t. Use ptrdiff_t for index, not int.
1368 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1369 possibility of integer overflow.
1370
13464394
PE
1371 Overflow, signedness and related fixes for images.
1372
1373 * dispextern.h (struct it.stack[0].u.image.image_id)
1374 (struct_it.image_id, struct image.id, struct image_cache.size)
1375 (struct image_cache.used, struct image_cache.ref_count):
1376 * gtkutil.c (update_frame_tool_bar):
1377 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1378 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1379 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1380 * nsmenu.m (update_frame_tool_bar):
1381 * xdisp.c (calc_pixel_width_or_height):
1382 * xfns.c (image_cache_refcount):
1383 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1384 on typical 64-bit hosts.
1385
1386 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1387 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1388 Omit unnecessary casts to int.
1389 (parse_image_spec): Check that integers fall into 'int' range
1390 when the callers expect that.
1391 (image_ascent): Redo ascent calculation to avoid int overflow.
1392 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1393 (lookup_image): Remove unnecessary tests.
1394 (xbm_image_p): Locals are now of int, not EMACS_INT,
1395 since parse_image_check makes sure they fit into int.
1396 (png_load, gif_load, svg_load_image):
1397 Prefer int to unsigned where either will do.
1398 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1399 old tiff_error_handler and tiff_warning_handler.
1400 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1401 stack buffer overflows. It uses only the features of vsnprintf
1402 that are common to both POSIX and native Microsoft.
1403 (tiff_error_handler, tiff_warning_handler): Use it.
1404 (tiff_load, gif_load, imagemagick_load_image):
1405 Don't assume :index value fits in 'int'.
1406 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1407 (imagemagick_load_image): Check that crop parameters fit into
1408 the integer types that MagickCropImage accepts. Don't assume
1409 Vimagemagick_render_type has a nonnegative value. Don't assume
1410 size_t fits in 'long'.
1411 (gs_load): Use printmax_t to print the widest integers possible.
1412 Check for integer overflow when computing image height and width.
1413
c11821d4
EZ
14142011-08-26 Eli Zaretskii <eliz@gnu.org>
1415
1416 * xdisp.c (redisplay_window): Don't force window start if point
1417 will be invisible in the resulting window. (Bug#9324)
1418
0c95fcf7
EZ
14192011-08-25 Eli Zaretskii <eliz@gnu.org>
1420
1421 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1422 the display spec is of the form `(space ...)'.
1423 (handle_display_spec): Return the value returned by
1424 handle_single_display_spec, not just 1 or zero.
1425 (handle_single_display_spec): If the display spec is of the form
1426 `(space ...)', and specifies display in the text area, return 2
1427 rather than 1.
fee65a97 1428 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1429 accurately, and prefer exact match for point under bidi.
1430 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1431
1432 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1433 into disp_prop; all users changed.
1434
1435 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1436 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1437 for the text covered by the display property.
1438
e4ed06f1
CY
14392011-08-25 Chong Yidong <cyd@stupidchicken.com>
1440
1441 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1442 Change return value to nil.
1443 (Frecord_buffer): Delete unused function.
1444
f67cdd7f
EZ
14452011-08-24 Eli Zaretskii <eliz@gnu.org>
1446
5980d4c6
EZ
1447 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1448 buffers, return left-to-right.
8610fe8b
EZ
1449 (set_cursor_from_row): Consider candidate row a win if its glyph
1450 represents a newline and point is on that newline. Fixes cursor
1451 positioning on the newline at EOL of R2L text within L2R
1452 paragraph, and vice versa.
1453 (try_cursor_movement): Check continued rows, in addition to
1454 continuation rows. Fixes unwarranted scroll when point enters a
1455 continued line of R2L text within an L2R paragraph, or vice versa.
1456 (cursor_row_p): Consider the case of point being equal to
1457 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1458 from the end of a short line to the beginning of a continued line
1459 of R2L text within L2R paragraph.
1460 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1461 composed characters.
5980d4c6 1462
f67cdd7f
EZ
1463 * bidi.c (bidi_check_type): Use xassert.
1464 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1465 members.
1466
bca633fb
EZ
14672011-08-23 Eli Zaretskii <eliz@gnu.org>
1468
1469 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1470 a character.
1471
4a5885a7
CY
14722011-08-23 Chong Yidong <cyd@stupidchicken.com>
1473
1474 * nsfont.m (ns_otf_to_script): Fix typo.
1475
0902a04e
KH
14762011-08-22 Kenichi Handa <handa@m17n.org>
1477
1478 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1479 extra slot even if the purpose is char-code-property-table.
1480
1a2e6670
EZ
14812011-08-23 Eli Zaretskii <eliz@gnu.org>
1482
8ddde651
EZ
1483 * xdisp.c (redisplay_window): When computing centering_position,
1484 account for the height of the header line. (Bug#8874)
1485
425cc014
EZ
1486 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1487 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1488 candidate is selected by the mouse, and that candidate has a
1489 composed character under the mouse.
1490
1a2e6670
EZ
1491 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1492 coordinates reported by pos-visible-in-window-p for a composed
1493 character in column zero.
1494
8b76d6f8
SM
14952011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1496
1497 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1498
dac347dd
EZ
14992011-08-22 Eli Zaretskii <eliz@gnu.org>
1500
1501 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1502 consider it a hit if to_charpos is anywhere in the range of the
1503 composed buffer positions.
1504
e013fb34
CY
15052011-08-22 Chong Yidong <cyd@stupidchicken.com>
1506
1507 * image.c (gif_load): Don't assume that each subimage has the same
1508 dimensions as the base image. Handle disposal method that is
1509 "undefined" by the gif spec (Bug#9335).
1510
bd1ba3e8
CY
15112011-08-20 Chong Yidong <cyd@stupidchicken.com>
1512
1513 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1514 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1515
54a1215b
EZ
15162011-08-19 Eli Zaretskii <eliz@gnu.org>
1517
823564e5
EZ
1518 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1519 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1520 from an Org mode buffer to a Speedbar frame.
1521
54a1215b
EZ
1522 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1523 a composition, take its buffer position from IT->cmp_it.charpos.
1524 Fixes cursor positioning at the beginning of a line that begins
1525 with a composed character.
1526
9778ebcc
EZ
15272011-08-18 Eli Zaretskii <eliz@gnu.org>
1528
0be6ee06
EZ
1529 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1530 character bidirectional type, use STRONG_L instead. Fixes crashes
1531 in a buffer produced by `describe-categories'.
1532
9778ebcc
EZ
1533 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1534 members before the level stack, so they would be saved and
1535 restored when copying iterator state. Fixes incorrect reordering
1536 around TABs covered by display properties.
1537
156bffbe
AS
15382011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1539
6b02f655 1540 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1541
72ad093b
CY
15422011-08-17 Chong Yidong <cyd@stupidchicken.com>
1543
1544 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1545 (internal_condition_case_2, internal_condition_case_n):
1546 Remove unnecessary aborts (Bug#9081).
72ad093b 1547
35774242
EZ
15482011-08-17 Eli Zaretskii <eliz@gnu.org>
1549
1550 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1551 has no `load' handler, try opening the file locally. (Bug#9311)
1552
db76dd85
KB
15532011-08-16 Ken Brown <kbrown@cornell.edu>
1554
1555 * gmalloc.c: Expand comment.
1556
b215eee5
EZ
15572011-08-16 Eli Zaretskii <eliz@gnu.org>
1558
1559 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1560 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1561
a4579d33
KB
15622011-08-16 Ken Brown <kbrown@cornell.edu>
1563
1564 Fix memory allocation problems in Cygwin build (Bug#9273).
1565
1566 * unexcw.c ( __malloc_initialized): Declare external variable.
1567 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1568
8b76d6f8
SM
1569 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1570 New variables.
a4579d33
KB
1571 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1572 dumped emacs.
1573 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1574 in the static heap.
1575 [CYGWIN] (special_realloc): New function.
1576 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1577 requests to realloc storage in the static heap.
1578
3ebec551
PE
15792011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * bidi.c (bidi_initialize): Remove unused local.
1582
9fd8be00
EZ
15832011-08-15 Eli Zaretskii <eliz@gnu.org>
1584
6b02f655
SM
1585 * bidimirror.h:
1586 * biditype.h: Remove file.
1587 * makefile.w32-in ($(BLD)/bidi.$(O)):
1588 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1589
1590 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1591
1592 * chartab.c: Improve commentary for the uniprop_table API.
1593
32413314
EZ
1594 * bidi.c (bidi_paragraph_init): Support zero value of
1595 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1596 (bidi_initialize): Use uniprop_table instead of including
1597 biditype.h and bidimirror.h.
32413314 1598
9fd8be00
EZ
1599 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1600 coordinates of the iterator when restoring from ppos_it.
1601 (Bug#9296)
1602
5cf2b69b
KH
16032011-08-14 Kenichi Handa <handa@m17n.org>
1604
1605 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1606 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1607
daf17d00
EZ
16082011-08-14 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xdisp.c (move_it_in_display_line_to): Don't invoke
1611 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1612 ppos_it. Fixes vertical cursor motion when line beginning is
1613 covered by an image. (Bug#9296)
1614
08e3161a
JD
16152011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1616
1617 * nsterm.h (ns_run_ascript): Declare.
1618 (NSAPP_DATA2_RUNASSCRIPT): Define.
1619
1620 * nsfns.m (as_script, as_result, as_status): New static variables.
1621 (ns_run_ascript): New function.
5e617bc2 1622 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1623 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1624 the event loop. Get status from as_status (Bug#7276).
1625
1626 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1627 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1628 the event loop (Bug#7276).
1629
a3720aa2
AS
16302011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1631
1632 * gnutls.c (QCgnutls_bootprop_priority)
1633 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1634 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1635 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1636 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1637 (QCgnutls_bootprop_verify_hostname_error)
1638 (QCgnutls_bootprop_callbacks_verify): Rename from
1639 Qgnutls_bootprop_..., all uses changed.
1640
1641 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1642 uses changed.
1643
0a0d27fb
PE
16442011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1645
19d5c50c
PE
1646 * xfaces.c (Qframe_set_background_mode): Now static.
1647 * dispextern.h (Qframe_set_background_mode): Remove decl.
1648
0a0d27fb
PE
1649 * process.c (Fnetwork_interface_info): Declare local only if needed.
1650
377538cb
JD
16512011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1652
1653 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1654 (Fnetwork_interface_list): Allocate in increments of bytes instead
1655 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1656 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1657 sockaddr.
1658 (struct ifflag_def): notrailers is smart on OSX.
1659 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1660 Get hardware address with getifaddrs if available.
1661
08fff70c
EZ
16622011-08-12 Eli Zaretskii <eliz@gnu.org>
1663
1664 * xdisp.c (iterate_out_of_display_property): xassert that
1665 IT->position is set to within IT->object's boundaries. Break from
1666 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1667 when IT->position is set up wrongly due to some bug.
1668 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1669 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1670 entry. Force push_it to save on the stack the current
1671 buffer/string position, to be restored by pop_it. Fix flags in
1672 the iterator structure wrt the object coming from a display
1673 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1674 properties. (Bug#9284)
1675
7be1c708 16762011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1677
7be1c708
CY
1678 * fontset.c (fontset_get_font_group): Add proper type checks.
1679 (Bug#9172)
aac0c6e3 1680
7be1c708 16812011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1682
7be1c708
CY
1683 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1684 and LC_VERSION_MIN_MACOSX.
1685 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1686 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1687
97bb72a6
EZ
16882011-08-08 Eli Zaretskii <eliz@gnu.org>
1689
1690 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1691 no-display-properties-and-no-overlays under bidi display.
1692 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1693 properties and overlays.
97bb72a6 1694
d5617611
CY
16952011-08-08 Chong Yidong <cyd@stupidchicken.com>
1696
37e11a63
CY
1697 * editfns.c (Fset_time_zone_rule): Document relationship with the
1698 setenv function.
1699
d5617611
CY
1700 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1701 the font entity extracted from the cache (Bug#8109).
1702
58872834
CY
17032011-08-07 Chong Yidong <cyd@stupidchicken.com>
1704
1705 * composite.c (autocmp_chars): Don't reset point. That is done by
1706 restore_point_unwind (Bug#5984).
1707
75bfc667
JL
17082011-08-07 Juri Linkov <juri@jurta.org>
1709
1710 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1711 to show the arg `TIME' instead of `TIMEVAL'.
1712
d1410150
EZ
17132011-08-06 Eli Zaretskii <eliz@gnu.org>
1714
1715 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1716 display property strides EOL and includes a newline, as in
1717 longlines-mode. (Bug#9254)
75b771e4
EZ
1718 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1719 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1720
1721 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1722 is non-zero, even if the data buffer is NULL. Fixes a crash in
1723 vertical-motion with longlines-mode. (Bug#9254)
1724
35928349
EZ
17252011-08-05 Eli Zaretskii <eliz@gnu.org>
1726
ec7cc85b
EZ
1727 * bidi.c <bidi_cache_total_alloc>: Now static.
1728 (bidi_initialize): Initialize bidi_cache_total_alloc.
1729
8b76d6f8 1730 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1731 cache. (Bug#9221)
1732
1733 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1734 amount allocated this far in `bidi_cache_total_alloc'.
1735 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1736 non-zero, only free the data buffer without restoring the cache
1737 contents. All callers changed.
1738
1739 * dispextern.h (bidi_unshelve_cache): Update prototype.
1740
1741 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1742 (move_it_in_display_line, move_it_to)
1743 (move_it_vertically_backward, move_it_by_lines): Replace the call
1744 to xfree to an equivalent call to bidi_unshelve_cache.
1745 (move_it_in_display_line_to): Fix logic of returning
412b6358 1746 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1747
e2e2423b
EZ
17482011-08-05 Eli Zaretskii <eliz@gnu.org>
1749
1750 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1751 came from a string character with a `cursor' property. (Bug#9229)
1752
ae9e757a
JD
17532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1754
1755 * Makefile.in (LIB_PTHREAD): New variable.
1756 (LIBES): Add LIB_PTHREAD (Bug#9216).
1757
1758 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1759 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1760
213bd7f2
AS
17612011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1762
6b02f655 1763 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1764
99aaf75f
JD
17652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1766
1767 * xterm.c (x_find_topmost_parent): New function.
1768 (x_set_frame_alpha): Find topmost parent window with
1769 x_find_topmost_parent and set the property there also (bug#9181).
1770 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1771
c74e9d86
PE
17722011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * callproc.c (Fcall_process): Avoid vfork clobbering
1775 the local vars buffer, coding_systems, current_dir.
1776
640c8776
SM
17772011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1778
1779 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1780
f26d0e4c
PE
17812011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1782
8a10d76c
PE
1783 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1784 so that it is not optimized away.
1785
f26d0e4c
PE
1786 * xdisp.c (compute_display_string_pos): Remove unused local.
1787
55439c61
EZ
17882011-08-02 Eli Zaretskii <eliz@gnu.org>
1789
1790 Fix slow cursor motion and scrolling in large buffers with
1791 selective display, like Org Mode buffers. (Bug#9218)
1792
1793 * dispextern.h (struct bidi_it): New member disp_prop_p.
1794
1795 * xdisp.c: Remove one-slot cache of display string positions.
1796 (compute_display_string_pos): Accept an additional argument
5e617bc2 1797 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1798 for a display string or property. If found, set DISP_PROP_P
1799 non-zero.
1800
1801 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1802 DISP_PROP_P, and pass it to compute_display_string_pos.
1803 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1804 non-zero. All callers of bidi_fetch_char changed.
1805
fb33fa43
SM
18062011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1807
1808 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1809
b099e063
DM
18102010-12-03 Don March <don@ohspite.net>
1811
1812 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1813 last character M-[char] is translated to ESC [char] (bug#7541).
1814
5cc7f7af
KH
18152011-08-02 Kenichi Handa <handa@m17n.org>
1816
d0fffa3f 1817 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1818
1819 * chartab.c (uniprop_table): Make it non-static.
1820
525d5e6e
EZ
18212011-08-01 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (forward_to_next_line_start): Accept additional argument
1824 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1825 on the newline.
1826 (reseat_at_next_visible_line_start): Use the bidi iterator state
1827 returned by forward_to_next_line_start to restore the state of
1828 it->bidi_it after backing up to previous newline. (Bug#9212)
1829
31011111
AS
18302011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1831
1832 * regex.c (re_comp): Protoize.
1833 (re_exec): Fix return type.
1834 (regexec): Fix type of `ret'. (Bug#9203)
1835
476371c4
PE
18362011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1837
e5d76069
PE
1838 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1839 This is needed if max-image-size is a floating-point number.
1840
9a79b20c
AS
18412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1842
1843 * print.c (print_object): Print empty symbol as ##.
1844
1845 * lread.c (read1): Read ## as empty symbol.
1846
d8c2fa78
AA
18472011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1848
1849 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1850 setting frame foreground color (Bug#9175).
1851 (x_set_background_color): Likewise.
1852
ffe57a7a
AA
1853 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1854 contents (Bug#9176).
1855 (EmacsTooltip -init): Remove bezels and add shadows to
1856 tooltip windows.
1857
bf3492a5
AA
1858 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1859 or scroll bar (Bug#8470).
1860
d55e9c53
AA
1861 * nsfont.m (nsfont_open): Remove assignment to voffset and
1862 unnecessary vars hshink, expand, hd, full_height, min_height.
1863 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1864
1865 * nsterm.h (nsfont_info): Remove voffset field.
1866
d8c2fa78 18672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1868
1869 Implement strike-through and overline on NextStep (Bug#8863).
1870
1871 * nsfont.m (nsfont_open): Use underline position provided by font,
1872 instead of hard-coded value of 2.
1873 (nsfont_draw): Call ns_draw_text_decoration instead.
1874
1875 * nsterm.h: Add declaration for ns_draw_text_decoration.
1876
1877 * nsterm.m (ns_draw_text_decoration): New function for drawing
1878 underline, overline, and strike-through.
1879 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1880 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1881 accommodate underlining, etc.
4843aac3 1882
4cc60b9b
EZ
18832011-07-28 Eli Zaretskii <eliz@gnu.org>
1884
bc7ece87
EZ
1885 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1886 default.
4cc60b9b 1887
476371c4
PE
18882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1889
66606eea
PE
1890 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1891 Without this fix, if a signal arrives just after memory fills up,
1892 'malloc' might be invoked reentrantly.
1893
476371c4
PE
1894 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1895 In other words, assume that every image size is allowed, on non-X
1896 hosts. This assumption is probably wrong, but it lets Emacs compile.
1897
f3fcc40d
AS
18982011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1899
1900 * regex.c (re_iswctype): Convert return values to boolean.
1901
350c992f
EZ
19022011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1903
1904 * xdisp.c (compute_display_string_pos): Don't use cached display
1905 string position if the buffer had its restriction changed.
1906 (Bug#9184)
1907
5266b4bb
PE
19082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1911
2573a837 19122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1913
41f55ccd 1914 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1915
39e378da
PE
1916 * bidi.c: Integer size and overflow fixes.
1917 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1918 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1919 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1920 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1921 (bidi_find_other_level_edge):
1922 Use ptrdiff_t instead of EMACS_INT where either will do.
1923 This works better on 32-bit hosts configured --with-wide-int.
1924 (bidi_cache_ensure_space): Check for size-calculation overflow.
1925 Use % rather than repeated addition, for better worst-case speed.
1926 Don't set bidi_cache_size until after xrealloc returns, because it
1927 might not return.
1928 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1929 (bidi_cache_ensure_space): Also check that the bidi cache size
1930 does not exceed that of the largest Lisp string or buffer. See Eli
1931 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1932
5e927815
PE
1933 * alloc.c (__malloc_size_t): Remove.
1934 All uses replaced by size_t. See Andreas Schwab's note
1935 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1936
ca4aa935
PE
1937 * image.c: Improve checking for integer overflow.
1938 (check_image_size): Assume that f is nonnull, since
1939 it is always nonnull in practice. This is one less thing to
1940 worry about when checking for integer overflow later.
1941 (x_check_image_size): New function, which checks for integer
1942 overflow issues inside X.
1943 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1944 This removes the need for a memory_full check.
1945 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1946 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1947 (xbm_read_bitmap_data): Change locals back to 'int', since
1948 their values must fit in 'int'.
1949 (xpm_load_image, png_load, tiff_load):
1950 Invoke x_create_x_image_and_pixmap earlier,
1951 to avoid much needless work if the image is too large.
1952 (tiff_load): Treat overly large images as if
1953 x_create_x_image_and_pixmap failed, not as malloc failures.
1954 (gs_load): Use x_check_image_size.
1955
5f8f9cc2
PE
1956 * gtkutil.c: Omit integer casts.
1957 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1958 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1959
5adf60bc
PE
1960 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1961
c8907a93
PE
1962 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1963 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1964 would wrongly return t on a 64-bit host.
1965
e3c25c68
PE
1966 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1967 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1968 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1969 and therefore cause GCC to emit a bogus diagnostic in some cases.
1970
3f791afe
PE
1971 * image.c: Integer signedness and overflow and related fixes.
1972 This is not an exhaustive set of fixes, but it's time to
1973 record what I've got.
1974 (lookup_pixel_color, check_image_size): Remove redundant decls.
1975 (check_image_size): Don't assume that arbitrary EMACS_INT values
1976 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1977 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1978 (tiff_load, imagemagick_load_image):
1979 Check for overflow in size calculations.
1980 (x_create_x_image_and_pixmap): Remove unnecessary test for
1981 xmalloc returning NULL; that can't happen.
1982 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1983 (xpm_color_bucket): Use better integer hashing function.
1984 (xpm_cache_color): Don't possibly over-allocate memory.
1985 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1986 (gif_memory_source):
1987 Use ptrdiff_t, not int or size_t, to record sizes.
1988 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1989 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1990 either works, as we prefer signed integers.
1991 (tiff_read_from_memory, tiff_write_from_memory):
1992 Return tsize_t, not size_t, since that's what the TIFF API wants.
1993 (tiff_read_from_memory): Don't fail simply because the read would
1994 go past EOF; instead, return a short read.
1995 (tiff_load): Omit no-longer-needed casts.
1996 (Fimagemagick_types): Don't assume size fits into 'int'.
1997
3cc5a532
PE
1998 Improve hashing quality when configured --with-wide-int.
1999 * fns.c (hash_string): New function, taken from sxhash_string.
2000 Do not discard information about ASCII character case; this
2001 discarding is no longer needed.
2002 (sxhash-string): Use it. Change sig to match it. Caller changed.
2003 * lisp.h: Declare it.
2004 * lread.c (hash_string): Remove, since we now use fns.c's version.
2005 The fns.c version returns a wider integer if --with-wide-int is
2006 specified, so this should help the quality of the hashing a bit.
2007
b312a492
PE
2008 * emacs.c: Integer overflow minor fix.
2009 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2010 Define only if GNU_LINUX.
2011 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2012
dfd153ae
PE
2013 * dispnew.c: Integer signedness and overflow fixes.
2014 Remove unnecessary forward decls, that were a maintenance hassle.
2015 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2016 All uses changed.
2017 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2018 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2019 (prepare_desired_row, line_draw_cost):
2020 Use int, not unsigned, where either works.
2021 (save_current_matrix, restore_current_matrix):
2022 Use ptrdiff_t, not size_t, where either works.
2023 (init_display): Check for overflow more accurately, and without
2024 relying on undefined behavior.
2025
a81d11a3
PE
2026 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2027 Remove, replacing with the new symbols in lisp.h. All uses changed.
2028 * fileio.c (make_temp_name):
2029 * filelock.c (lock_file_1, lock_file):
2030 * xdisp.c (message_dolog):
2031 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2032 Use pMd etc. instead.
2033 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2034 replacing the pWIDE etc. symbols removed from editfns.c.
2035
3300e6fd
PE
2036 * keyboard.h (num_input_events): Now uintmax_t.
2037 This is (very slightly) less likely to mess up due to wraparound.
2038 All uses changed.
2039
fd05c7e9
PE
2040 * buffer.c: Integer signedness fixes.
2041 (alloc_buffer_text, enlarge_buffer_text):
2042 Use ptrdiff_t rather than size_t when either will do, as we prefer
2043 signed integers.
2044
903fe15d
PE
2045 * alloc.c: Integer signedness and overflow fixes.
2046 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2047 (__malloc_size_t): Default to size_t, not to int.
2048 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2049 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2050 Prefer ptrdiff_t to size_t when either would do, as we prefer
2051 signed integers.
2052 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2053 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2054 Now const. Initialize with values that are in range even if char
2055 is signed.
2056 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2057 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2058 These functions do the right thing with sizes > 2**32.
2059 (check_depth): Now ptrdiff_t, not int.
2060 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2061 Adjust to new way of storing sizes. Check for size overflow bugs
2062 in rest of code.
2063 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2064 slightly wrong anyway, as it missed one instance of
2065 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2066 (refill_memory_reserve): Omit needless cast to size_t.
2067 (mark_object_loop_halt): Mark as externally visible.
2068
ac82cc6a
PE
2069 * xselect.c: Integer signedness and overflow fixes.
2070 (Fx_register_dnd_atom, x_handle_dnd_message):
2071 Use ptrdiff_t, not size_t, since we prefer signed.
2072 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2073 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2074 x_dnd_atoms_size and x_dnd_atoms_length.
2075
c2d1e36d
PE
2076 * doprnt.c: Prefer signed to unsigned when either works.
2077 * eval.c (verror):
2078 * doprnt.c (doprnt):
2079 * lisp.h (doprnt):
2080 * xdisp.c (vmessage):
2081 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2082 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2083 prefer signed arithmetic to avoid comparison confusion.
2084 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2085 but is a bit tricky.
2086
0e926e56
PE
2087 Assume freestanding C89 headers, string.h, stdlib.h.
2088 * data.c, doprnt.c, floatfns.c, print.c:
2089 Include float.h unconditionally.
2090 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2091 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2092 * regex.c: Likewise for stddef.h, string.h.
2093 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2094 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2095 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2096 (STDC_HEADERS): Remove obsolete defines.
2097 * sysdep.c: Include limits.h unconditionally.
2098
9cfdb3ec
PE
2099 Assume support for memcmp, memcpy, memmove, memset.
2100 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2101 * regex.c (memcmp, memcpy):
2102 Remove; we assume C89 now.
2103
2104 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2105 (__malloc_safe_bcopy): Remove; no longer needed.
2106
cf950e6b 2107 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2108 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2109 well either way, and we prefer signed to unsigned.
2110
dbf38e02
LMI
21112011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2112
2113 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2114 closes the connection while we're reading (bug#9182).
2115
d6f0886c 21162011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2117
d6f0886c
JD
2118 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2119 are specified (Bug#9168).
24e0f6b1 2120
2eb1f9e6
PE
21212011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2124 Found by GCC static checking and --with-wide-int on a 32-bit host.
2125
22381272 21262011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2127
2128 * xdisp.c (compute_display_string_pos): Fix logic of caching
2129 previous display string position. Initialize cached_prev_pos to
2130 -1. Fixes slow-down at the beginning of a buffer.
2131
f25e39b4
EZ
21322011-07-24 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2135 for attrs[LFACE_FONTSET_INDEX].
2136
04c4b52e
PE
21372011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 * xml.c (parse_region): Remove unused local
2140 that was recently introduced.
2141
c1734fbd
EZ
21422011-07-23 Eli Zaretskii <eliz@gnu.org>
2143
be18c5a5
EZ
2144 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2145 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2146
c1734fbd
EZ
2147 * xdisp.c (move_it_in_display_line_to): Record the best matching
2148 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2149 exit if none of the characters scanned was an exact match.
2150 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2151 when exact match is impossible due to invisible text, and the
2152 lines are truncated.
2153
a258d627
JD
21542011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2155
2156 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2157 for OSX >= 10.7.
2158
b6d5a689
EZ
21592011-07-22 Eli Zaretskii <eliz@gnu.org>
2160
0f74f785
EZ
2161 Fix a significant slow-down of cursor motion with C-n, C-p,
2162 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2163 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2164 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2165 (next_element_from_buffer): Call compute_stop_pos_backwards to
2166 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2167 base_level_stop.
2168 (reseat): Don't look for prev_stop, as that could mean a very long
2169 run.
2170 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2171 <cached_disp_overlay_modiff>: Cache for last found display string
2172 position.
551918c1 2173 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2174 about the same buffer in the same area of character positions, and
2175 the buffer wasn't changed since the time the display string
2176 position was cached.
551918c1 2177
b2d0c91a
EZ
21782011-07-22 Eli Zaretskii <eliz@gnu.org>
2179
2180 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2181 is an integer, which is important for empty lines. (Bug#9149)
2182
043604ee
CY
21832011-07-22 Chong Yidong <cyd@stupidchicken.com>
2184
2185 * frame.c (Fmodify_frame_parameters): In tty case, update the
2186 default face if necessary (Bug#4238).
2187
da4adb04
CY
21882011-07-21 Chong Yidong <cyd@stupidchicken.com>
2189
2190 * editfns.c (Fstring_to_char): No need to explain what a character
2191 is in the docstring (Bug#6576).
2192
9abd0532
LMI
21932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2194
2195 * xml.c (parse_region): Make sure we always return a tree.
2196
36881d16
HK
21972011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2198
2199 * xml.c (parse_region): If a document contains only comments,
2200 return that, too.
2201
1e98674d
LMI
22022011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2203
2204 * xml.c (make_dom): Return comments, too.
2205
590bd467
PE
22062011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2207
2208 Port to OpenBSD.
2209 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2210 and the surrounding thread.
2211 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2212 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2213 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2214 timer goes off.
2215 * s/openbsd.h (BROKEN_SIGIO): Define.
2216 * unexelf.c (unexec) [__OpenBSD__]:
2217 Don't update the .mdebug section of the Alpha COFF symbol table.
2218
f41628b2
LMI
22192011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2220
2221 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2222 (bug#8460).
2223
b59b67c5
PE
22242011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2225
15e3a074
PE
2226 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2227 This fixes some race conditions on the permissions of any newly
2228 created file.
2229
41bed37d
PE
2230 * alloc.c (valid_pointer_p): Use pipe, not open.
2231 This fixes some permissions issues when debugging.
2232
b59b67c5
PE
2233 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2234 If fchown fails to set both uid and gid, try to set just gid,
2235 as that is sometimes allowed. Adjust the file's mode to eliminate
2236 setuid or setgid bits that are inappropriate if fchown fails.
2237
925a6be7
SM
22382011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2239
2240 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2241 to compare Lisp_Objects.
2242 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2243 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2244 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2245
52968808
AS
22462011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2247
0a6a104b
AS
2248 * lread.c (read_integer): Unread even EOF character.
2249 (read1): Likewise. Properly record start position of symbol.
2250
52968808
AS
2251 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2252 symbol character follows.
2253
9e381cdd
PE
22542011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2257 This works around a problem with the previous change to Fcopy_file.
2258 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2259 and without this change, GCC might complain about discarding
2260 fchown's return value.
2261
b5641435
JB
22622011-07-16 Juanma Barranquero <lekktu@gmail.com>
2263
2264 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2265
a8031457
PE
22662011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2269
dd889327
LMI
22702011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2271
750c33f7
LMI
2272 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2273 it's used from the C level.
2274
dd889327
LMI
2275 * process.c: Use the same condition for POLL_FOR_INPUT in both
2276 keyboard.c and process.c (bug#1858).
2277
87e86684
LM
22782011-07-09 Lawrence Mitchell <wence@gmx.li>
2279
2280 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2281 (Fgnutls_boot): Use it.
2282
64348f40
AS
22832011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2284
2285 * doc.c (Fsubstitute_command_keys): Revert last change.
2286
1d698799
LMI
22872011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2288
f863868c
LMI
2289 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2290 quotes the next character, and doesn't affect other longer
2291 sequences (bug#8935).
2292
1d698799
LMI
2293 * lread.c (syms_of_lread): Clarify that is isn't only
2294 `eval-buffer' and `eval-defun' that's affected by
2295 `lexical-binding' (bug#8460).
2296
aa4b6df6
EZ
22972011-07-15 Eli Zaretskii <eliz@gnu.org>
2298
2299 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2300 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2301
5d856da6
PE
23022011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2303
ad6042bb
PE
2304 Fix minor problems found by static checking.
2305 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2306 (elsz): Now a signed constant, not a size_t var. We prefer signed
2307 types to unsigned, to avoid integer comparison confusion. Without
2308 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2309 "cannot optimize loop, the loop counter may overflow", a symptom
2310 of the confusion.
f00bbb22 2311 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2312 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2313
6468f31c
LMI
23142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2315
49080b10
LMI
2316 * search.c (Fre_search_backward): Mention `case-fold-search' in
2317 all the re_search_* functions (bug#8138).
2318
6468f31c
LMI
2319 * keyboard.c (Fopen_dribble_file): Document when the file is
2320 closed (bug#8056).
2321
c965adc5
EZ
23222011-07-14 Eli Zaretskii <eliz@gnu.org>
2323
df9733bf
EZ
2324 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2325 bidi_cache_idx.
2326
0bb23927
EZ
2327 Support bidi reordering of display and overlay strings.
2328 * xdisp.c (compute_display_string_pos)
2329 (compute_display_string_end): Accept additional argument STRING.
2330 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2331 (reseat_to_string): Initialize bidi_it->string.s and
2332 bidi_it->string.schars.
2333 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2334 NULL (avoids a crash in bidi_paragraph_init).
2335 Initialize itb.string.lstring.
0bb23927
EZ
2336 (init_iterator): Call bidi_init_it only of a valid
2337 buffer position was specified. Initialize paragraph_embedding to
2338 L2R.
2339 (reseat_to_string): Initialize the bidi iterator.
2340 (display_string): If we need to ignore text properties of
2341 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2342 original value of -1 will not work with bidi.)
2343 (compute_display_string_pos): First arg is now struct
2344 `text_pos *'; all callers changed. Support display properties on
2345 Lisp strings.
2346 (compute_display_string_end): Support display properties on Lisp
2347 strings.
2348 (init_iterator, reseat_1, reseat_to_string): Initialize the
2349 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2350 when iterating on a string not from display properties).
640c8776
SM
2351 (compute_display_string_pos, compute_display_string_end):
2352 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2353 arrow keys.
2354 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2355 base_level_stop; instead, set base_level_stop to BEGV.
2356 Fixes crashes in vertical-motion.
0bb23927
EZ
2357 (next_element_from_buffer): Improve commentary for when
2358 the iterator is before prev_stop.
2359 (init_iterator): Initialize bidi_p from the default value of
2360 bidi-display-reordering, not from buffer-local value. Use the
2361 buffer-local value only if initializing for buffer iteration.
2362 (handle_invisible_prop): Support invisible properties on strings
2363 that are being bidi-reordered.
2364 (set_iterator_to_next): Support bidi reordering of C strings and
2365 Lisp strings.
2366 (next_element_from_string): Support bidi reordering of Lisp
2367 strings.
2368 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2369 (display_string): Support display of R2L glyph rows.
2370 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2371 (init_iterator): Don't initialize it->bidi_p for strings
2372 here.
2373 (reseat_to_string): Initialize it->bidi_p for strings here.
2374 (next_element_from_string, next_element_from_c_string)
2375 (next_element_from_buffer): Add xassert's for correspondence
2376 between IT's object being iterated and it->bidi_it.string
2377 structure.
2378 (face_before_or_after_it_pos): Support bidi iteration.
2379 (next_element_from_c_string): Handle the case of the first string
2380 character that is not the first one in the visual order.
2381 (get_visually_first_element): New function, refactored from common
2382 parts of next_element_from_buffer, next_element_from_string, and
2383 next_element_from_c_string.
2384 (tool_bar_lines_needed, redisplay_tool_bar)
2385 (display_menu_bar): Force left-to-right direction. Add a FIXME
2386 comment for making that be controlled by a user option.
2387 (push_it, pop_it): Save and restore the state of the
2388 bidi iterator. Save and restore the bidi_p flag.
2389 (pop_it): Iterate out of display property for string iteration as
2390 well.
2391 (iterate_out_of_display_property): Support iteration over strings.
2392 (handle_single_display_spec): Set up it->bidi_it for iteration
2393 over a display string, and call bidi_init_it.
2394 (handle_single_display_spec, next_overlay_string)
2395 (get_overlay_strings_1, push_display_prop): Set up the bidi
2396 iterator for displaying display or overlay strings.
2397 (forward_to_next_line_start): Don't use the shortcut if
2398 bidi-iterating.
2399 (back_to_previous_visible_line_start): If handle_display_prop
2400 pushed the iterator stack, restore the internal state of the bidi
2401 iterator by calling bidi_pop_it same number of times.
2402 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2403 and we are bidi-iterating, don't decrement the iterator position;
2404 instead, set the first_elt flag in the bidi iterator, to produce
2405 the same effect.
2406 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2407 (push_display_prop): xassert that we are iterating a buffer.
2408 (push_it, pop_it): Save and restore paragraph_embedding member.
2409 (handle_single_display_spec, next_overlay_string)
2410 (get_overlay_strings_1, reseat_1, reseat_to_string)
2411 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2412 correctly. Don't assume unibyte strings are not bidi-reordered.
2413 (compute_display_string_pos)
2414 (compute_display_string_end): Fix handling the case of C string.
2415 (push_it, pop_it): Save and restore from_disp_prop_p.
2416 (handle_single_display_spec, push_display_prop): Set the
2417 from_disp_prop_p flag.
2418 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2419 (pop_it): Call iterate_out_of_display_property only if we are
2420 popping after iteration over a string that came from a display
2421 property. Fix a typo in popping stretch info. Add an assertion
2422 for verifying that the iterator position is in sync with the bidi
2423 iterator.
2424 (handle_single_display_spec, get_overlay_strings_1)
2425 (push_display_prop): Fix initialization of paragraph direction for
2426 string when that of the parent object is not yet determined.
2427 (reseat_1): Call bidi_init_it to resync the bidi
2428 iterator with IT's position. (Bug#7616)
2429 (find_row_edges): If ROW->start.pos gives position
2430 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2431 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2432 Reset the from_disp_prop_p flag.
2433 (SAVE_IT, RESTORE_IT): New macros.
2434 (pos_visible_p, face_before_or_after_it_pos)
2435 (back_to_previous_visible_line_start)
2436 (move_it_in_display_line_to, move_it_in_display_line)
2437 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2438 (try_scrolling, redisplay_window, display_line): Use them when
2439 saving a temporary copy of the iterator and restoring it back.
2440 (back_to_previous_visible_line_start, reseat_1)
2441 (init_iterator): Empty the bidi cache "stack".
2442 (move_it_in_display_line_to): If iterator ended up at
2443 EOL, but we never saw any buffer positions smaller than
2444 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2445 motion in bidi-reordered lines.
2446 (move_it_in_display_line_to): Record prev_method and prev_pos
2447 immediately before the call to set_iterator_to_next. Fixes cursor
2448 motion in bidi-reordered lines with stretch glyphs and strings
2449 displayed in margins. (Bug#8133) (Bug#8867)
2450 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2451 TO_CHARPOS.
640c8776
SM
2452 (pos_visible_p): Support positions in bidi-reordered lines.
2453 Save and restore bidi cache.
0bb23927
EZ
2454
2455 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2456 (bidi_paragraph_info): Delete unused struct.
2457 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2458 (bidi_cache_start): New variable.
2459 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2460 to zero.
2461 (bidi_cache_fetch_state, bidi_cache_search)
2462 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2463 (bidi_cache_find, bidi_peek_at_next_level)
2464 (bidi_level_of_next_char, bidi_find_other_level_edge)
2465 (bidi_move_to_visually_next): Compare cache index with
2466 bidi_cache_start rather than with zero.
2467 (bidi_fetch_char): Accept new argument STRING; all callers
2468 changed. Support iteration over a string. Support strings with
2469 display properties. Support unibyte strings. Fix the type of
2470 `len' according to what STRING_CHAR_AND_LENGTH expects.
2471 (bidi_paragraph_init, bidi_resolve_explicit_1)
2472 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2473 (bidi_level_of_next_char, bidi_move_to_visually_next):
2474 Support iteration over a string.
0bb23927
EZ
2475 (bidi_set_sor_type, bidi_resolve_explicit_1)
2476 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2477 can now be zero (for strings); special values 0 and -1 were
2478 changed to -1 and -2, respectively.
2479 (bidi_char_at_pos): New function.
2480 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2481 Call it instead of FETCH_MULTIBYTE_CHAR.
2482 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2483 initialized to valid values.
2484 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2485 values.
2486 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2487 the test for valid cached positions. Fix the logic for looking up
2488 the sentinel state in the cache. GCPRO the Lisp string we are
2489 iterating.
2490 (bidi_push_it, bidi_pop_it): New functions.
2491 (bidi_initialize): Initialize the bidi cache start stack pointer.
2492 (bidi_cache_ensure_space): New function, refactored from part of
2493 bidi_cache_iterator_state. Don't assume the required size is just
2494 one BIDI_CACHE_CHUNK away.
2495 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2496 (bidi_count_bytes, bidi_char_at_pos): New functions.
2497 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2498 always valid if bidi_cache_idx is valid.
2499 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2500 is valid if it's going to be used.
2501 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2502 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2503 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2504 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2505 (bidi_find_other_level_edge, bidi_cache_start_stack):
2506 All variables related to cache indices are now EMACS_INT.
c965adc5 2507
0bb23927
EZ
2508 * dispextern.h (struct bidi_string_data): New structure.
2509 (struct bidi_it): New member `string'. Make flag members be 1-bit
2510 fields, and put them last in the struct.
640c8776
SM
2511 (compute_display_string_pos, compute_display_string_end):
2512 Update prototypes.
0bb23927
EZ
2513 (bidi_push_it, bidi_pop_it): Add prototypes.
2514 (struct iterator_stack_entry): New members bidi_p,
2515 paragraph_embedding, and from_disp_prop_p.
2516 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2517 (bidi_shelve_cache, bidi_unshelve_cache):
2518 Declare prototypes.
0bb23927
EZ
2519
2520 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2521 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2522 and vector-like objects.
2523
2524 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2525 cache around display iteration.
2526
2527 * window.c (Fwindow_end, window_scroll_pixel_based)
2528 (displayed_window_lines, Frecenter): Save and restore the bidi
2529 cache around display iteration.
2530
3bbd2265
LMI
25312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2532
2533 * editfns.c (Fdelete_region): Clarify the use of the named
2534 parameters (bug#6788).
2535
adc47434
MR
25362011-07-14 Martin Rudalics <rudalics@gmx.at>
2537
2538 * indent.c (Fvertical_motion): Set and restore w->pointm when
2539 saving and restoring the window's buffer (Bug#9006).
2540
837c31f8
LMI
25412011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2542
2543 * editfns.c (Fstring_to_char): Clarify just what is returned
2544 (bug#6576). Text by Eli Zaretskii.
2545
ac389d0c
JB
25462011-07-13 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2549
0be0ce47
EZ
25502011-07-13 Eli Zaretskii <eliz@gnu.org>
2551
2552 * buffer.c (mmap_find): Fix a typo.
2553
cd18e7e3
JB
25542011-07-13 Johan Bockgård <bojohan@gnu.org>
2555
2556 Fix execution of x selection hooks.
2557 * xselect.c (Qx_lost_selection_functions)
2558 (Qx_sent_selection_functions): New vars.
2559 (syms_of_xselect): DEFSYM them.
2560 (x_handle_selection_request): Pass Qx_sent_selection_functions
2561 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2562 (x_handle_selection_clear,x_clear_frame_selections):
2563 Pass Qx_lost_selection_functions rather than
2564 Vx_lost_selection_functions to Frun_hook_with_args.
2565
47ea7f44
PE
25662011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2567
ac389d0c 2568 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2569 The old code sometimes used this field without initializing it.
2570
47ea7f44
PE
2571 * alloc.c (gc_sweep): Don't read past end of array.
2572 In theory, the old code could also have corrupted Emacs internals,
2573 though it'd be very unlikely.
2574
bc985c87
AS
25752011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2576
2577 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2578 argument. (Bug#4026)
bc985c87 2579
0cf34688
LMI
25802011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2581
b3dadd76
LMI
2582 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2583 key" (bug#4257).
2584
0cf34688
LMI
2585 * window.c (Fset_window_start): Doc fix (bug#4199).
2586 (Fset_window_hscroll): Ditto.
2587
270768cd
PE
25882011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2589
077e3dda 2590 Fix minor new problems caught by GCC 4.6.1.
270768cd 2591 * term.c (init_tty): Remove unused local.
490011a6 2592 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2593 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2594 not used otherwise.
270768cd 2595
b1f58454
CY
25962011-07-12 Chong Yidong <cyd@stupidchicken.com>
2597
2598 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2599
22b9578d
LMI
26002011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2601
6e70ab07
LMI
2602 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2603 are the mini-buffer and the echo area (bug#3320).
2604
22b9578d
LMI
2605 * term.c (init_tty): Remove support for supdup, c10 and perq
2606 terminals, which are no longer supported (bug#1482).
2607
8974cc9f
JB
26082011-07-10 Johan Bockgård <bojohan@gnu.org>
2609
2610 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2611
a560d974
JD
26122011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2613
2614 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2615 for non-popups (Bug#3642).
2616
1dae0f0a
AS
26172011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2618
268c2c36 2619 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2620 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2621 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2622 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2623 * data.c (fmod): Likewise.
2624 * dispnew.c (swap_glyphs_in_rows): Likewise.
2625 * emacs.c (memory_warning_signal): Likewise.
2626 * floatfns.c (float_error): Likewise.
2627 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2628 (otf_open, font_otf_capability, generate_otf_features)
2629 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2630 Likewise.
2631 * image.c (pbm_read_file): Likewise.
2632 * indent.c (string_display_width): Likewise.
2633 * intervals.c (check_for_interval, search_for_interval)
2634 (inc_interval_count, count_intervals, root_interval)
2635 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2636 * lread.c (defalias): Likewise.
268c2c36 2637 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2638 * regex.c (set_image_of_range_1, set_image_of_range)
2639 (regex_grow_registers): Likewise.
2640 * sysdep.c (strerror): Likewise.
2641 * termcap.c (valid_filename_p, tprint, main): Likewise.
2642 * tparam.c (main): Likewise.
2643 * unexhp9k800.c (run_time_remap, save_data_space)
2644 (update_file_ptrs, read_header, write_header, calculate_checksum)
2645 (copy_file, copy_rest, display_header): Likewise.
2646 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2647 Likewise.
2648 * xdisp.c (check_it): Likewise.
2649 * xfaces.c (register_color, unregister_color, unregister_colors):
2650 Likewise.
2651 * xfns.c (print_fontset_result): Likewise.
2652 * xrdb.c (member, fatal, main): Likewise.
2653
99033785
PE
26542011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 Fix minor problems found by static checking (Bug#9031).
2657 * chartab.c (char_table_set_range, map_sub_char_table):
2658 Remove unused locals.
2659 (uniprop_table): Now static.
2660 * composite.c (_work_char): Remove unused static var.
2661
9cb2ac56
JB
26622011-07-09 Juanma Barranquero <lekktu@gmail.com>
2663
2664 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2665
f25661f0
JD
26662011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2667
2668 * gtkutil.c (qttip_cb): Remove code without function.
2669
8278c4fe
EZ
26702011-07-09 Eli Zaretskii <eliz@gnu.org>
2671
2672 * w32.c (pthread_sigmask): New stub.
2673
1692ae2d 26742011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2675
8a6ebd58 2676 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2677 sigprocmask is portable only for single-threaded applications, and
2678 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2679 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2680 (LIBES): Use it.
2681 * callproc.c (Fcall_process):
2682 * process.c (create_process):
2683 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2684 Use pthread_sigmask, not sigprocmask.
123403e4 2685
1b854618
JD
26862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2687
2688 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2689 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2690 wrong (Bug#8591).
2691
3fe4b549
JD
26922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2693
0ce7e563
JD
2694 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2695 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2696 (xg_hide_tooltip): Fix comment.
2697
3fe4b549
JD
2698 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2699 in registerServicesMenuSendTypes.
2700 (validRequestorForSendType): Don't check ns_return_types.
2701
2702 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2703 ns_return_type.
2704
5df75e47
JR
27052011-07-08 Jason Rumney <jasonr@gnu.org>
2706
2707 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2708 frame struct members of non-existent frames (Bug#6284).
2709
699c10bd
JD
27102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2711
4393663b
JD
2712 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2713 variable firstTime not needed on OSX >= 10.6.
2714 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2715 >= 10.5. Use setKnobProportion, setDoubleValue.
2716
2717 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2718 (MAC_OS_X_VERSION_10_5): Define if not defined.
2719 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2720 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2721 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2722
2723 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2724 cString and lossyCString on OSX >= 10.4
2725
2726 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2727 sizeToFit on OSX >= 10.2.
2728
2729 * nsimage.m (allocInitFromFile): Don't use deprecated method
2730 bestRepresentationForDevice on OSX >= 10.6.
2731
2732 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2733 to avoid warning.
2734
2735 * emacs.c: Declare unexec_init_emacs_zone.
2736
a63e0781
JD
2737 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2738
699c10bd
JD
2739 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2740
2741 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2742 on svcsMenu (Bug#8842).
2743
2744 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2745 ns_return_types.
2746 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2747
2748 * nsterm.m (QUTF8_STRING): Declare.
2749 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2750 (validRequestorForSendType): Return type is (id).
2751 Change indexOfObjectIdenticalTo to indexOfObject.
2752 Check if we have local selection before returning self (Bug#8842).
2753 (writeSelectionToPasteboard): Put local selection into paste board
2754 if we have a local selection (Bug#8842).
2755 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2756
2757 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2758 (ns_get_local_selection): Declare.
2759
54e10184
LMI
27602011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2761
9888ff71
LMI
2762 * keymap.c (describe_map_tree): Don't insert a double newline at
2763 the end of the buffer (bug#1169) and return whether we inserted
2764 something.
2765
54e10184
LMI
2766 * callint.c (Fcall_interactively): Change "reading args" to
2767 "providing args" to try to clarify what it does (bug#1010).
2768
15fa4783
KH
27692011-07-07 Kenichi Handa <handa@m17n.org>
2770
2771 * composite.c (composition_compute_stop_pos): Ignore a static
2772 composition starting before CHARPOS (Bug#8915).
2773
2774 * xdisp.c (handle_composition_prop): Likewise.
2775
a8815b00
EZ
27762011-07-07 Eli Zaretskii <eliz@gnu.org>
2777
2778 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2779 (Bug#9015)
2780
ef7b981d 27812011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2782
2783 * character.h (unicode_category_t): New enum type.
2784
2785 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2786 (Qchar_code_property_table): New variable.
2787 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2788 (UNIPROP_COMPRESSED_FORM_P): New macros.
2789 (char_table_ascii): Uncompress the compressed values.
2790 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2791 Uncompress the compressed values.
ac389d0c 2792 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2793 (char_table_ref_and_range): Uncompress the compressed values.
2794 (sub_char_table_set): New arg is_uniprop. Callers changed.
2795 Uncompress the compressed values.
2796 (sub_char_table_set_range): Args changed. Callers changed.
2797 (char_table_set_range): Adjuted for the above change.
2798 (map_sub_char_table): Delete args default_val and parent. Add arg
2799 top. Give decoded values to a Lisp function.
640c8776 2800 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2801 values to a Lisp function. Gcpro more variables.
2802 (uniprop_table_uncompress)
2803 (uniprop_decode_value_run_length): New functions.
2804 (uniprop_decoder, uniprop_decoder_count): New variables.
2805 (uniprop_get_decoder, uniprop_encode_value_character)
2806 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2807 New functions.
2808 (uniprop_encoder, uniprop_encoder_count): New variables.
2809 (uniprop_get_encoder, uniprop_table)
2810 (Funicode_property_table_internal, Fget_unicode_property_internal)
2811 (Fput_unicode_property_internal): New functions.
2812 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2813 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2814 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2815 char-code-property-alist.
2816
640c8776 2817 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2818 Vunicode_category_table.
2819
640c8776 2820 * font.c (font_range): Adjust for the change of
c805dec0
KH
2821 Vunicode_category_table.
2822
76b397fb
DN
28232011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2824
2825 * m/iris4d.h: Remove file, move contents ...
2826 * s/irix6-5.h: ... here.
2827
22b4128e
PE
28282011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2829
2830 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2831 * alloc.c (mark_buffer):
2832 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2833 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2834 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2835 This isn't true in general, and it's particularly not true
2836 if Emacs is configured with --with-wide-int.
2837 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2838 New macros, used in the buffer.c change.
2839
869795d6
JD
28402011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2841
2842 * xsettings.c: Use both GConf and GSettings if both are available.
2843 (store_config_changed_event): Add comment.
2844 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2845 (store_tool_bar_style_changed): New functions.
5e617bc2 2846 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2847 (struct xsettings): Move font inside HAVE_XFT.
2848 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2849 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2850 Move inside HAVE_XFT.
640c8776 2851 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2852 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2853 also.
2854 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2855 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2856 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2857 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2858 (parse_settings): Move check for font inside HAVE_XFT.
2859 (read_settings, apply_xft_settings): Add comment.
2860 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2861 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2862 call store_font_name_changed.
2863 (xft_settings_event): Add comment.
2864 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2865 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2866 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2867 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2868 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2869 (xsettings_get_system_font, xsettings_get_system_normal_font):
2870 Add comment.
869795d6 2871
d8ed26bd
PE
28722011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 Random fixes. E.g., (random) never returned negative values.
2875 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2876 subseconds part to the entropy, as that's a bit more random.
2877 Prefer signed to unsigned, since the signedness doesn't matter and
2878 in general we prefer signed. When given a limit, use a
2879 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2880 latter isn't right if USE_2_TAGS_FOR_INTS.
2881 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2882 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2883
cabf1cac
SM
28842011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2885
2886 * textprop.c (text_property_stickiness):
2887 Obey Vtext_property_default_nonsticky.
2888 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2889 * w32fns.c (syms_of_w32fns):
2890 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2891
6e9b2be9
PE
28922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2895 This is more efficient than Ffile_directory_p and avoids a minor race.
2896
90186c68
LMI
28972011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2898
7c301272
LMI
2899 * buffer.c (Foverlay_put): Say what the return value is
2900 (bug#7835).
2901
c4f2d8d4
LMI
2902 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2903 is a directory before asking whether to use the file name
2904 (bug#7564).
ad637907
LMI
2905 (barf_or_query_if_file_exists): Make the "File is a directory"
2906 error be more correct.
c4f2d8d4 2907
90186c68
LMI
2908 * fns.c (Frequire): Remove the mention of the .gz files, since
2909 that's installation-specific, but keep the mention of
2910 `get-load-suffixes'.
2911
da64016e
PE
29122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2913
2914 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2915 Report string overflow if the output is too long.
2916
7d47b580
JB
29172011-07-04 Juanma Barranquero <lekktu@gmail.com>
2918
a555cb87
JB
2919 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2920 (syms_of_gnutls): Remove duplicate DEFSYM for
2921 Qgnutls_bootprop_verify_hostname_error, an error for
2922 Qgnutls_bootprop_verify_error (which is no longer used).
2923
7d47b580
JB
2924 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2925 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2926 Also (re)move comments that are misplaced or no longer relevant.
2927
1e49bfab
LMI
29282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2929
2930 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2931
1485f4c0
CY
29322011-07-03 Chong Yidong <cyd@stupidchicken.com>
2933
2934 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2935 and background color parameters if they have been changed.
2936
a9ab721e
LMI
29372011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2938
2939 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2940
cf7cff57
PE
29412011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2942
2e13213d
PE
2943 * xsettings.c (SYSTEM_FONT): Define only when used.
2944 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2945
cf7cff57
PE
2946 * keymap.c (access_keymap_1): Now static.
2947
7a8e04f7
CY
29482011-07-02 Chong Yidong <cyd@stupidchicken.com>
2949
2950 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2951 leave any prefix arg for the up event (Bug#1586).
2952
61352f62
LMI
29532011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2954
69bb1ef7
LMI
2955 * lread.c (syms_of_lread): Mention single symbols defined by
2956 `defvar' or `defconst' (bug#7154).
2957
61352f62 2958 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2959 (Frequire): Mention get-load-suffixes.
61352f62 2960
28545e04
MR
29612011-07-02 Martin Rudalics <rudalics@gmx.at>
2962
2963 * window.h (window): Remove clone_number slot.
2964 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2965 Remove.
2966 (make_parent_window, make_window, saved_window)
2967 (Fset_window_configuration, save_window_save): Don't deal with
2968 clone numbers.
2969 * buffer.c (Qclone_number): Remove declaration.
2970 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2971
3349e122
SM
29722011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2973
2974 Add multiple inheritance to keymaps.
2975 * keymap.c (Fmake_composed_keymap): New function.
2976 (Fset_keymap_parent): Simplify.
2977 (fix_submap_inheritance): Remove.
2978 (access_keymap_1): New function extracted from access_keymap to handle
2979 embedded parents and handle lists of maps.
2980 (access_keymap): Use it.
2981 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2982 (Fcopy_keymap): Handle embedded parents.
2983 (Fcommand_remapping, define_as_prefix): Simplify.
2984 (Fkey_binding): Simplify.
2985 (syms_of_keymap): Move minibuffer-local-completion-map,
2986 minibuffer-local-filename-completion-map,
2987 minibuffer-local-must-match-map, and
2988 minibuffer-local-filename-must-match-map to Elisp.
2989 (syms_of_keymap): Defsubr make-composed-keymap.
2990 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2991 (parse_menu_item): Trivial simplification.
2992
3279eb87
GM
29932011-07-01 Glenn Morris <rgm@gnu.org>
2994
2995 * Makefile.in (SETTINGS_LIBS): Fix typo.
2996
4550efdf
KI
29972011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2998
2999 * coding.c (Fencode_coding_string): Record the last coding system
3000 used, as the function doc string says (bug#8738).
3001
0949d2b6
JD
30022011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3003
3004 * xsettings.c (store_monospaced_changed): Take new font as arg and
3005 check for change against current_mono_font.
3006 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3007 (emacs_settings_constructor, emacs_settings_get_property)
3008 (emacs_settings_set_property, emacs_settings_class_init)
3009 (emacs_settings_init, gsettings_obj): Remove.
3010 (something_changedCB): New function for HAVE_GSETTINGS.
3011 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3012 with value as argument.
3013 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3014 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3015 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3016 "changed".
3017
3018 * xgselect.c: Add defined (HAVE_GSETTINGS).
3019 (xgselect_initialize): Ditto.
3020
3021 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3022 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3023 xg_select.
3024
bbc6b304
PE
30252011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3026
3027 * eval.c (struct backtrace): Simplify and port the data structure.
3028 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3029 signed bit field, as this assumption is not portable and it makes
3030 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3031 "char debug_on_exit : 1" as this is not portable either; instead,
3032 use the portable "unsigned int debug_on_exit : 1". Remove unused
3033 member evalargs. Remove obsolete comments about cc bombing out.
3034
9851bfc5
JD
30352011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3036
51bb811f 3037 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3038 Let HAVE_GSETTINGS override HAVE_GCONF.
3039 (store_monospaced_changed): New function.
3040 (EMACS_SETTINGS): A new type derived from GObject to handle
3041 GSettings notifications.
3042 (emacs_settings_constructor, emacs_settings_get_property)
3043 (emacs_settings_set_property, emacs_settings_class_init):
3044 New functions.
3045 (gsettings_client, gsettings_obj): New variables.
3046 (GSETTINGS_SCHEMA): New define.
3047 (something_changedCB): Call store_monospaced_changed.
3048 (init_gsettings): New function.
3049 (xsettings_initialize): Call init_gsettings.
3050 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3051 to NULL.
3052
640c8776 3053 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3054 GCONF_CFLAGS/LIBS.
3055
5386012d
MR
30562011-06-29 Martin Rudalics <rudalics@gmx.at>
3057
3058 * window.c (resize_root_window, grow_mini_window)
3059 (shrink_mini_window): Rename Qresize_root_window to
3060 Qwindow_resize_root_window and Qresize_root_window_vertically to
3061 Qwindow_resize_root_window_vertically.
3062
f13e0b08
PE
30632011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3064
3065 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3066
94515237
JB
30672011-06-27 Juanma Barranquero <lekktu@gmail.com>
3068
3069 * makefile.w32-in: Redesign dependencies so they reflect more
3070 clearly which files are directly included by each source file,
3071 and not through other includes.
3072
e43b6e43
MR
30732011-06-27 Martin Rudalics <rudalics@gmx.at>
3074
3075 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3076 (sort_overlays, overlay_strings): When an overlay's clone number
3077 matches the window's clone number process the overlay even if
3078 the overlay's window property doesn't match the current window.
3079
d68443dc
MR
3080 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3081 (Fwindow_hchild): Rename to Fwindow_left_child.
3082 (Fwindow_next): Rename to Fwindow_next_sibling.
3083 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3084 (resize_window_check): Rename to window_resize_check.
3085 (resize_window_apply): Rename to window_resize_apply.
3086 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3087 (Fdelete_other_windows_internal, resize_frame_windows)
3088 (Fsplit_window_internal, Fdelete_window_internal)
3089 (grow_mini_window, shrink_mini_window)
3090 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3091
c7e73be5
JD
30922011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3093
3094 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3095 (emacs_fixed_set_min_size): Remove.
3096 (emacs_fixed_new): Take frame as argument.
3097
3098 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3099 (_EmacsFixedPrivate): Remove minwidth/height.
3100 Add struct frame *f.
3101 (emacs_fixed_init): Initialize priv->f.
3102 (get_parent_class, emacs_fixed_set_min_size): Remove.
3103 (emacs_fixed_new): Set priv->f to argument.
3104 (emacs_fixed_get_preferred_width)
3105 (emacs_fixed_get_preferred_height): Use min_width/height from
3106 frames size_hint to set minimum and natural (Bug#8919).
3107 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3108 and use min_width/height from frames size_hint to set
3109 min_width/height (Bug#8919).
3110
3111 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3112 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3113 Fix indentation.
c7e73be5 3114
cf99dcf8
EZ
31152011-06-26 Eli Zaretskii <eliz@gnu.org>
3116
3117 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3118 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3119 called at ZV.
3120
029529ac
CY
31212011-06-26 Chong Yidong <cyd@stupidchicken.com>
3122
3123 * process.c (wait_reading_process_output): Bypass select if
3124 waiting for a cell while ignoring keyboard input, and input is
3125 pending. Suggested by Jan Djärv (Bug#8869).
3126
7a7ef429
PE
31272011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 Use gnulib's dup2 module instead of rolling our own.
3130 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3131
11fdef7d 31322011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3133
3134 * dispnew.c (scrolling_window): Before scrolling, turn off a
3135 mouse-highlight in the window being scrolled.
3136
cd3520a4
JB
31372011-06-24 Juanma Barranquero <lekktu@gmail.com>
3138
3139 Move DEFSYM to lisp.h and use everywhere.
3140
3141 * character.h (DEFSYM): Move declaration...
3142 * lisp.h (DEFSYM): ...here.
3143
3144 * gnutls.c:
3145 * minibuf.c:
3146 * w32menu.c:
3147 * w32proc.c:
3148 * w32select.c: Don't include character.h.
3149
3150 * alloc.c (syms_of_alloc):
3151 * buffer.c (syms_of_buffer):
3152 * bytecode.c (syms_of_bytecode):
3153 * callint.c (syms_of_callint):
3154 * casefiddle.c (syms_of_casefiddle):
3155 * casetab.c (init_casetab_once):
3156 * category.c (init_category_once, syms_of_category):
3157 * ccl.c (syms_of_ccl):
3158 * cmds.c (syms_of_cmds):
3159 * composite.c (syms_of_composite):
3160 * dbusbind.c (syms_of_dbusbind):
3161 * dired.c (syms_of_dired):
3162 * dispnew.c (syms_of_display):
3163 * doc.c (syms_of_doc):
3164 * editfns.c (syms_of_editfns):
3165 * emacs.c (syms_of_emacs):
3166 * eval.c (syms_of_eval):
3167 * fileio.c (syms_of_fileio):
3168 * fns.c (syms_of_fns):
3169 * frame.c (syms_of_frame):
3170 * fringe.c (syms_of_fringe):
3171 * insdel.c (syms_of_insdel):
3172 * keymap.c (syms_of_keymap):
3173 * lread.c (init_obarray, syms_of_lread):
3174 * macros.c (syms_of_macros):
3175 * msdos.c (syms_of_msdos):
3176 * print.c (syms_of_print):
3177 * process.c (syms_of_process):
3178 * search.c (syms_of_search):
3179 * sound.c (syms_of_sound):
3180 * syntax.c (init_syntax_once, syms_of_syntax):
3181 * terminal.c (syms_of_terminal):
3182 * textprop.c (syms_of_textprop):
3183 * undo.c (syms_of_undo):
3184 * w32.c (globals_of_w32):
3185 * window.c (syms_of_window):
3186 * xdisp.c (syms_of_xdisp):
3187 * xfaces.c (syms_of_xfaces):
3188 * xfns.c (syms_of_xfns):
3189 * xmenu.c (syms_of_xmenu):
3190 * xsettings.c (syms_of_xsettings):
3191 * xterm.c (syms_of_xterm): Use DEFSYM.
3192
4228cf16
TZ
31932011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3194
cd3520a4 3195 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3196
7fcccf1e
PE
31972011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3198
7efb4e0e
PE
3199 Integer and buffer overflow fixes (Bug#8873).
3200
ff5844ad
PE
3201 * print.c (printchar, strout): Check for string overflow.
3202 (PRINTPREPARE, printchar, strout):
3203 Don't set size unless allocation succeeds.
3204
90532f02
PE
3205 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3206 for sizes. Check for string overflow more accurately.
3207 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3208
6d84508d
PE
3209 * macros.c: Integer and buffer overflow fixes.
3210 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3211 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3212 Use ptrdiff_t, not int, for sizes.
3213 Don't increment bufsize until after realloc succeeds.
3214 Check for size-calculation overflow.
3215 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3216
437b2cb4
PE
3217 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3218
8b9ac8b4
PE
3219 * lread.c: Integer overflow fixes.
3220 (read_integer): Radix is now EMACS_INT, not int,
3221 to improve quality of diagnostics for out-of-range radices.
3222 Calculate buffer size correctly for out-of-range radices.
3223 (read1): Check for integer overflow in radices, and in
3224 read-circle numbers.
82cb60d3
PE
3225 (read_escape): Avoid int overflow.
3226 (Fload, openp, read_buffer_size, read1)
3227 (substitute_object_recurse, read_vector, read_list, map_obarray):
3228 Use ptrdiff_t, not int, for sizes.
3229 (read1): Use EMACS_INT, not int, for sizes.
20270765 3230 Check for size overflow.
8b9ac8b4 3231
7fcccf1e
PE
3232 * image.c (cache_image): Check for size arithmetic overflow.
3233
bfbbd7e7
PE
3234 * lread.c: Integer overflow issues.
3235 (saved_doc_string_size, saved_doc_string_length)
3236 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3237 Now ptrdiff_t, not int.
3238 (read1): Don't assume doc string length fits in int. Check for
3239 out-of-range doc string lengths.
3240 (read_list): Don't assume file position fits in int.
39019e54 3241 (read_escape): Check for hex character overflow.
bfbbd7e7 3242
4e323265
LL
32432011-06-22 Leo Liu <sdl.web@gmail.com>
3244
3245 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3246 Move to minibuffer.el.
3247
85fece3e
PE
32482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3249
20b84ce9 3250 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3251 The following patches are for when GLYPH_DEBUG && !XASSERT.
3252 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3253 * dispnew.c (flush_stdout):
3254 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3255 Mark as externally visible.
3256 * dispnew.c (check_window_matrix_pointers): Now static.
3257 * dispnew.c (window_to_frame_vpos):
3258 * xfns.c (unwind_create_frame):
3259 * xterm.c (x_check_font): Remove unused local.
3260 * scroll.c (CHECK_BOUNDS):
3261 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3262 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3263 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3264 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3265 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3266 Now static.
3267 (debug_method_add): Use va_list and vsprintf rather than relying
3268 on undefined behavior with wrong number of arguments.
3269 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3270 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3271 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3272 since we're not interested in debugging glyphs with old libraries.
3273 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3274 GCC 4.6.0's static checking.
3275
0766b489
PE
32762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3277
31fd4b32
PE
3278 Integer overflow and signedness fixes (Bug#8873).
3279 A few related buffer overrun fixes, too.
3280
b79e8648
PE
3281 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3282
0766b489
PE
3283 * dispextern.h (struct face.stipple):
3284 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3285 (x_bitmap_mask, x_allocate_bitmap_record)
3286 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3287 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3288 (x_create_bitmap_from_xpm_data):
3289 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3290 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3291 (.bitmaps_last):
3292 * xfaces.c (load_pixmap):
3293 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3294 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3295 (.bitmaps_last, struct x_output.icon_bitmap):
3296 Use ptrdiff_t, not int, for bitmap indexes.
3297 (x_allocate_bitmap_record): Check for size overflow.
3298 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3299
b081724f
PE
3300 Use ptrdiff_t, not int, for overlay counts.
3301 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3302 * editfns.c (overlays_around, get_pos_property):
3303 * textprop.c (get_char_property_and_overlay):
3304 * xdisp.c (next_overlay_change, note_mouse_highlight):
3305 * xfaces.c (face_at_buffer_position):
21514da7
PE
3306 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3307 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3308 (Fnext_overlay_change, Fprevious_overlay_change)
3309 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3310 Use ptrdiff_t, not int, for sizes.
21514da7 3311 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3312
3de73e5e
PE
3313 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3314
2606c57b
PE
3315 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3316 (x_session_initialize): Do not assume string length fits in int.
3317
aaafe47a
PE
3318 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3319 This is unlikely, but can occur if DPI is outlandish.
3320
2674ddc8 3321 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3322 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3323
28154962
PE
3324 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3325 * xrdb.c (magic_file_p, search_magic_path):
3326 Omit last arg SUFFIX; it was always 0. All callers changed.
3327 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3328
7de51af5
PE
3329 * xfont.c (xfont_match): Avoid need for strlen.
3330
25ed6cc3
PE
3331 * xfns.c: Don't assume strlen fits in int.
3332 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3333
4eab31dd
PE
3334 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3335 not unsigned long, as we prefer signed integers. All callers changed.
3336 Detect integer overflow in repeat count.
3337 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3338 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3339
171e2a58
PE
3340 * termcap.c: Don't assume sizes fit in int and never overflow.
3341 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3342 (gobble_line): Check for size-calculation overflow.
3343
ad39faca 3344 * minibuf.c (Fread_buffer):
6e5bb2dc 3345 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3346 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3347 Don't assume string length fits in int.
3348
52c61c22 3349 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3350 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3351
b5b8c9e5
PE
3352 * font.c: Don't assume string length fits in int.
3353 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3354 Use ptrdiff_t, not int.
ccd6111c
PE
3355 (font_intern_prop): Don't assume string length fits in int.
3356 Don't assume integer property fits in fixnum.
3357 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3358
882f0d81 3359 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3360 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3361 Reformulate so as not to need the command string.
3362 Invoke gzip -cd rather than gunzip, as it's more portable.
3363 (lock_info_type, lock_file_1, lock_file):
3364 Don't assume pid_t and time_t fit in unsigned long.
3365 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3366 (current_lock_owner): Prefer signed type for sizes.
3367 Use memcpy, not strncpy, where memcpy is what is really wanted.
3368 Don't assume (via atoi) that time_t and pid_t fit in int.
3369 Check for time_t and/or pid_t out of range, e.g., via a network share.
3370 Don't alloca where an auto var works fine.
3371
93f4cf88
PE
3372 * fileio.c: Fix some integer overflow issues.
3373 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3374 Don't assume string length fits in int.
3375 (directory_file_name): Don't assume string length fits in long.
3376 (make_temp_name): Don't assume pid fits in int, or that its print
3377 length is less than 20.
3378
f3e92b69
PE
3379 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3380
1bfdaf10
PE
3381 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3382
35016e9a
PE
3383 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3384
3d1e65a1
PE
3385 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3386 We prefer signed integers, even for size calculations.
3387
0b963a93
PE
3388 * emacs.c: Don't assume string length fits in 'int'.
3389 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3390 (main): Don't invoke strlen when not needed.
3391
573f4b54
PE
3392 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3393 (XD_DEBUG_MESSAGE): Don't waste a byte.
3394
989f33ba
PE
3395 * callproc.c (getenv_internal_1, getenv_internal)
3396 (Fgetenv_internal):
965d34eb
PE
3397 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3398
e4d29b33
PE
3399 * lread.c (invalid_syntax): Omit length argument.
3400 All uses changed. This doesn't fix a bug, but it simplifies the
3401 code away from its former Hollerith-constant appearance, and it's
3402 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3403 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3404
eb49b136
PE
3405 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3406 This didn't break anything, but it didn't help either.
3407 It's confusing to put a bogus integer in a place where the actual
3408 value does not matter.
9f62aeb1 3409 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3410 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3411
15375a22
PE
3412 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3413 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3414 implementation.
b61cc01c
PE
3415 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3416 We prefer signed types, and the value cannot exceed the EMACS_INT
3417 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3418 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3419 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3420 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3421
53b2623d
PE
3422 * indent.c (sane_tab_width): New function.
3423 (current_column, scan_for_column, Findent_to, position_indentation)
3424 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3425 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3426
51cab52b 3427 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3428
f2ed8a70
PE
3429 * lisp.h (lint_assume): New macro.
3430 * composite.c (composition_gstring_put_cache):
3431 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3432
abe80cc6
PE
3433 * editfns.c, insdel.c:
3434 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3435
b02c740e
PE
3436 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3437
ebc96716
PE
3438 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3439
b4e50fa0 3440 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3441 Use much-faster test for byte-length change.
311d5d7c 3442 Don't assume string byte-length fits in 'int'.
a4cf38e4 3443 Check that character arg fits in 'int'.
85461888 3444 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3445
c0c1ee9f
PE
3446 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3447
a498d7f4
PE
3448 * fns.c (concat): Catch string overflow earlier.
3449 Do not rely on integer wraparound.
3450
51cab52b
PE
3451 * dispextern.h (struct it.overlay_strings_charpos)
3452 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3453 * xdisp.c (forward_to_next_line_start)
3454 (back_to_previous_visible_line_start)
3455 (reseat_at_next_visible_line_start, next_element_from_buffer):
3456 Don't arbitrarily truncate the value of 'selective' to int.
3457
76031fad
PE
3458 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3459
5eb55db9
PE
3460 * composite.c: Don't truncate sizes to 'int'.
3461 (composition_gstring_p, composition_reseat_it)
3462 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3463 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3464 not EMACS_UINT, for indexes.
5eb55db9 3465
0703a717
PE
3466 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3467
d6202519
PE
3468 * buffer.c: Include <verify.h>.
3469 (struct sortvec.priority, struct sortstr.priority):
8961a454 3470 Now EMACS_INT, not int.
c20998a7 3471 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3472 (struct sortstr.size, record_overlay_string)
3473 (struct sortstrlist.size, struct sortlist.used):
3474 Don't truncate size to int.
3475 (record_overlay_string): Check for size-calculation overflow.
d6202519 3476 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3477
d5a19415
JM
34782011-06-22 Jim Meyering <meyering@redhat.com>
3479
029529ac 3480 Don't leak an XBM-image-sized buffer
d5a19415
JM
3481 * image.c (xbm_load): Free the image buffer after using it.
3482
a9041e6c
PE
34832011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3484
3485 Port to Sun C.
3486 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3487 that Sun C diagnosed.
3488 * fns.c (secure_hash): Fix pointer signedness issue.
3489 * intervals.c (static_offset_intervals): New function.
3490 (offset_intervals): Use it.
3491
7f3f739f
LL
34922011-06-21 Leo Liu <sdl.web@gmail.com>
3493
3494 * deps.mk (fns.o):
3495 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3496 sha512.h.
3497
3498 * fns.c (secure_hash): Rename from crypto_hash_function and change
3499 the first arg to accept symbols.
5b66d427 3500 (Fsecure_hash): New primitive.
7f3f739f
LL
3501 (syms_of_fns): New symbols.
3502
76147d94
DD
35032011-06-20 Deniz Dogan <deniz@dogan.se>
3504
3505 * process.c (Fset_process_buffer): Clarify return value in
3506 docstring.
3507
7d7d0045
CY
35082011-06-18 Chong Yidong <cyd@stupidchicken.com>
3509
3510 * dispnew.c (add_window_display_history): Use BVAR.
3511
3512 * xdisp.c (debug_method_add): Use BVAR.
3513 (check_window_end, dump_glyph_matrix, dump_glyph)
3514 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3515
3516 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3517 Likewise.
3518
3519 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3520 check till after the cache is created in init_frame_faces.
3521
ff2bc410
SM
35222011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3523
3524 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3525
28177add
PE
35262011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3527
dd3482fe
PE
3528 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3529 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3530 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3531
393d71f3 3532 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3533 * fileio.c (Finsert_file_contents):
3534 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3535 Remove the old (too-loose) buffer overflow checks.
3536 They weren't needed, since make_gap checks for buffer overflow.
3537 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3538 The old code merely checked for Emacs fixnum overflow, and relied
3539 on undefined (wraparound) behavior. The new code avoids undefined
3540 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3541
2e6813b0 3542 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3543 Tune. Don't use wider integers than needed. Don't use alloca.
3544 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3545
599a9e4f
PE
3546 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3547
99561444
PE
3548 * insdel.c, lisp.h (buffer_overflow): New function.
3549 (insert_from_buffer_1, replace_range, replace_range_2):
3550 * insdel.c (make_gap_larger):
3551 * editfns.c (Finsert_char):
3552 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3553
28177add
PE
3554 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3555
e69dafad
PE
35562011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3557
a7af7fde 3558 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3559
b1c46f02
PE
3560 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3561 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3562
e69dafad
PE
3563 * fileio.c: Don't assume EMACS_INT fits in off_t.
3564 (emacs_lseek): New static function.
3565 (Finsert_file_contents, Fwrite_region): Use it.
3566 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3567
566684ea
PE
3568 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3569
e6966cd6
PE
3570 * fns.c: Don't overflow int when computing a list length.
3571 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3572 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3573 truncation on 64-bit hosts. Check for QUIT every
3574 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3575 faster and is responsive enough.
3576 (Flength): Report an error instead of overflowing an integer.
3577 (Fsafe_length): Return a float if the value is not representable
3578 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3579 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3580 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3581
dd0b0efb
PE
3582 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3583 (header_size, word_size): New constants.
3584 (allocate_vectorlike): Don't check size overflow here.
3585 (allocate_vector): Check it here instead, since this is the only
3586 caller of allocate_vectorlike that could cause overflow.
3587 Check that the new vector's length is representable as a fixnum.
3588
86fe5cfe
PE
3589 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3590 The previous code was bogus. For example, next_almost_prime (32)
3591 returned 39, which is undesirable as it is a multiple of 3; and
3592 next_almost_prime (24) returned 25, which is a multiple of 5 so
3593 why was the code bothering to check for multiples of 7?
3594
80e88859
PE
3595 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3596
4a2f0ad6
PE
3597 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3598
f66c7cf8
PE
3599 Variadic C functions now count arguments with ptrdiff_t.
3600 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3601 Back then I didn't know that the Emacs coding style prefers signed int.
3602 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3603 were being counted with int, which may truncate counts on 64-bit
3604 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3605 * lisp.h (struct Lisp_Subr.function.aMANY)
3606 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3607 Arg counts are now ptrdiff_t, not size_t.
3608 All variadic functions and their callers changed accordingly.
3609 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3610 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3611 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3612 * callint.c (Fcall_interactively): Check arg count for overflow,
3613 to avoid potential buffer overrun. Use signed char, not 'int',
3614 for 'varies' array, so that we needn't bother to check its size
3615 calculation for overflow.
3616 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3617 * eval.c (apply_lambda):
3618 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3619 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3620 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3621
a1759b76
PE
3622 * callint.c (Fcall_interactively): Don't use index var as event count.
3623
d96be9fc
PE
3624 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3625 * mem-limits.h (SIZE): Remove; no longer used.
3626
a690a978 3627 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3628
578c21e6
PE
3629 Remove unnecessary casts.
3630 * xterm.c (x_term_init):
3631 * xfns.c (x_set_border_pixel):
3632 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3633 These aren't needed now that we assume ANSI C.
3634
96f53c6c
PE
3635 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3636 It's more likely to cause problems (due to unsigned overflow)
3637 than to cure them.
3638
83c77d31
PE
3639 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3640
ee2079f1
PE
3641 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3642
6da65536
PE
3643 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3644
7147c4a4
PE
3645 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3646
193e32d9
PE
3647 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3648
e5533da6
PE
3649 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3650
9910e595
PE
3651 GLYPH_CODE_FACE returns EMACS_INT, not int.
3652 * dispextern.h (merge_faces):
3653 * xfaces.c (merge_faces):
01103c44
PE
3654 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3655 Don't assume EMACS_INT fits in int.
9910e595 3656
2638320e
PE
3657 * character.h (CHAR_VALID_P): Remove unused parameter.
3658 * fontset.c, lisp.h, xdisp.c: All uses changed.
3659
045eb8d9
PE
3660 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3661
c1f134b5
PE
3662 * fns.c (concat): Minor tuning based on overflow analysis.
3663 This doesn't fix any bugs. Use int to hold character, instead
3664 of constantly refetching from Emacs object. Use XFASTINT, not
3665 XINT, for value known to be a character. Don't bother comparing
3666 a single byte to 0400, as it's always less.
3667
395fcb93 3668 * floatfns.c (Fexpt):
327eeec8
PE
3669 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3670
abbd3d23
PE
3671 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3672 for characters.
3673
684a03ef
PE
3674 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3675
0fed43f3
PE
3676 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3677 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3678 incorrectly succeed when S was a string, because 4294967386 was
3679 truncated before it was used.
3680
8fd02eb7
PE
3681 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3682 Otherwise, an out-of-range integer could cause undefined behavior
3683 on a 64-bit host.
3684
f8c86b69
PE
3685 * composite.c: Use int, not EMACS_INT, for characters.
3686 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3687 EMACS_INT, for values that are known to be in character range.
3688 This doesn't fix any bugs but is the usual style inside Emacs and
3689 may generate better code on 32-bit machines.
3690
34206dd2
PE
3691 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3692 This is for reasons similar to the recent CHAR_STRING fix.
3693 * charset.c (Fencode_char): Check that character arg is actually
3694 a character. Pass an int to ENCODE_CHAR.
3695 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3696 wider than 'int', as a compile-time check to prevent future regressions
3697 in this area.
3698
c5958d4c 3699 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3700
3701 Make sure a 64-bit char is never passed to CHAR_STRING.
3702 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3703 by silently ignoring the top 32 bits, allowing some values
3704 that were far too large to be valid characters.
3705 * character.h: Include <verify.h>.
3706 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3707 arguments are no wider than unsigned, as a compile-time check
3708 to prevent future regressions in this area.
3709 * data.c (Faset):
01103c44 3710 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3711 (Fsubst_char_in_region):
3712 * fns.c (concat):
3713 * xdisp.c (decode_mode_spec_coding):
3714 Adjust to CHAR_STRING's new requirement.
3715 * editfns.c (Finsert_char, Fsubst_char_in_region):
3716 * fns.c (concat): Check that character args are actually
3717 characters. Without this test, these functions did the wrong
3718 thing with wildly out-of-range values on 64-bit hosts.
3719
d37ca623
PE
3720 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3721 These casts should not be needed on 32-bit hosts, either.
3722 * keyboard.c (read_char):
3723 * lread.c (Fload): Remove casts to unsigned.
3724
ea204efb
PE
3725 * lisp.h (UNSIGNED_CMP): New macro.
3726 This fixes comparison bugs on 64-bit hosts.
3727 (ASCII_CHAR_P): Use it.
3728 * casefiddle.c (casify_object):
01103c44 3729 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3730 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3731 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3732 * dispextern.h (FACE_FROM_ID):
3733 * keyboard.c (read_char): Use UNSIGNED_CMP.
3734
41cb286c
PE
3735 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3736 not to EMACS_INT, to avoid GCC warning.
3737
4a1b9832
PE
3738 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3739
55daad71
PE
3740 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3741 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3742 isn't needed on 32-bit machines.
8f95c75c 3743
01103c44
PE
3744 * buffer.c (Fgenerate_new_buffer_name):
3745 Use EMACS_INT for count, not int.
0ceccced 3746 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3747
3748 * data.c (Qcompiled_function): Now static.
3749
c6f072e7
PE
3750 * window.c (window_body_lines): Now static.
3751
20ce5912
PE
3752 * image.c (gif_load): Rename local to avoid shadowing.
3753
9c4c5f81
PE
3754 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3755 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3756 * alloc.c (make_save_value): Integer argument is now of type
3757 ptrdiff_t, not int.
3758 (mark_object): Use ptrdiff_t, not int.
3759 * lisp.h (pD): New macro.
3760 * print.c (print_object): Use it.
3761
c0c5c8ae
PE
3762 * alloc.c: Use EMACS_INT, not int, to count objects.
3763 (total_conses, total_markers, total_symbols, total_vector_size)
3764 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3765 (total_free_floats, total_floats, total_free_intervals)
3766 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3767 Now EMACS_INT, not int. All uses changed.
3768 (Fgarbage_collect): Compute overall total using a double, so that
3769 integer overflow is less likely to be a problem. Check for overflow
3770 when converting back to an integer.
5a25e253
PE
3771 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3772 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3773 These were 'int' variables that could overflow on 64-bit hosts;
3774 they were never used, so remove them instead of repairing them.
211a0b2a 3775 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3776 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3777 Previously, this ceilinged at INT_MAX, but that doesn't work on
3778 64-bit machines.
e46bb31a 3779 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3780
c78baabf 3781 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3782 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3783 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3784 when a (possibly-narrower) signed value would do just as well.
3785 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3786
c9d624c6
PE
3787 * alloc.c: Catch some string size overflows that we were missing.
3788 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3789 for convenience in STRING_BYTES_MAX.
3790 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3791 The definition here is exact; the one in lisp.h was approximate.
3792 (allocate_string_data): Check for string overflow. This catches
3793 some instances we weren't catching before. Also, it catches
3794 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3795 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3796 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3797
c9d624c6
PE
3798 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3799 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3800 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3801
353032ce
PE
3802 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3803
2bccce07
PE
3804 * alloc.c (Fmake_string): Check for out-of-range init.
3805
0ac30604
SM
38062011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3807
3808 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3809
c195f2de
JD
38102011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3811
3812 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3813 xg_get_default_scrollbar_width.
3814
3815 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3816 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3817 (style_changed_cb): Call update_theme_scrollbar_width and call
3818 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3819 all frames (Bug#8505).
3820 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3821 Call gtk_window_set_resizable if HAVE_GTK3.
3822 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3823 and height if HAVE_GTK3 (Bug#8505).
3824 (scroll_bar_width_for_theme): New variable.
3825 (update_theme_scrollbar_width): New function.
3826 (xg_get_default_scrollbar_width): Move code to
3827 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3828 (xg_initialize): Call update_theme_scrollbar_width.
3829
3830 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3831
3832 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3833
e10ac9f1
MR
38342011-06-12 Martin Rudalics <rudalics@gmx.at>
3835
3836 * frame.c (make_frame): Call other_buffer_safely instead of
3837 other_buffer.
3838
3839 * window.c (temp_output_buffer_show): Call display_buffer with
3840 second argument Vtemp_buffer_show_specifiers and reset latter
3841 immediately after the call.
3842 (Vtemp_buffer_show_specifiers): New variable.
3843 (auto_window_vscroll_p, next_screen_context_lines)
3844 (Vscroll_preserve_screen_position): Remove leading asterisks from
3845 doc-strings.
3846
2d3c217e 38472011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3848
7b7f97e8 3849 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3850 * buffer.c (Qclone_number): Remove for now, as it's unused.
3851 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3852 (record_buffer): Remove unused local.
3853 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3854 (set_frame_buffer_list): Remove; unused.
3855 * frame.h (other_visible_frames): Remove decl.
3856 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3857 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3858 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3859 if HAVE_GPM.
3860 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3861 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3862 Define only if HAVE_GPM.
3863 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3864 (update_hints_inhibit): Remove; never set. All uses removed.
3865 * widgetprv.h (emacsFrameClassRec): Remove decl.
3866 * window.c (delete_deletable_window): Now returns void, since it
3867 wasn't returning anything.
3868 (compare_window_configurations): Remove unused locals.
3869 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3870 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3871 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3872 the same widths as pointers. This follows up on the 2011-05-06 patch.
3873 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3874 * xterm.h: Likewise.
3875 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3876
1384b89e
JB
38772011-06-12 Juanma Barranquero <lekktu@gmail.com>
3878
3879 * makefile.w32-in: Update dependencies.
3880 (LISP_H): Add lib/intprops.h.
3881
1100a63c
CY
38822011-06-11 Chong Yidong <cyd@stupidchicken.com>
3883
3884 * image.c (gif_load): Add animation frame delay to the metadata.
3885 (syms_of_image): Use DEFSYM. New symbol `delay'.
3886
6198ccd0
MR
38872011-06-11 Martin Rudalics <rudalics@gmx.at>
3888
3889 * window.c (delete_deletable_window): Re-add.
3890 (Fset_window_configuration): Rewrite to handle dead buffers and
3891 consequently deletable windows.
3892 (window_tree, Fwindow_tree): Remove. Supply functionality in
3893 window.el.
3894 (compare_window_configurations): Simplify code.
3895
b6e3633c
AS
38962011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3897
1ab0dee5
AS
3898 * image.c (imagemagick_load_image): Fix type mismatch.
3899 (Fimagemagick_types): Likewise.
3900
b6e3633c
AS
3901 * window.h (replace_buffer_in_windows): Declare.
3902
9397e56f
MR
39032011-06-11 Martin Rudalics <rudalics@gmx.at>
3904
3905 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3906 Qclone_number. Remove external declaration of Qdelete_window.
3907 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3908 code.
640c8776
SM
3909 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3910 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3911 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3912 buffer list implementation.
3913 (other_buffer_safely): New function.
3914 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3915 calls to replace_buffer_in_windows and
3916 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3917 if allowed.
3918 (record_buffer): Inhibit quitting and rewrite using quittable
3919 functions. Run Qbuffer_list_update_hook if allowed.
3920 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3921 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3922 Move switch-to-buffer to window.el.
9397e56f
MR
3923 (bury-buffer): Move to window.el.
3924 (Vbuffer_list_update_hook): New variable.
3925
3926 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3927 section.
3928
3929 * window.h (resize_frame_windows): Move up in code.
3930 (Fwindow_frame): Remove EXFUN.
3931 (replace_buffer_in_all_windows): Remove prototype.
3932 (replace_buffer_in_windows_safely): Add prototype.
3933
3934 * window.c: Declare Qdelete_window static again. Move down
3935 declaration of select_count.
3936 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3937 (Fother_window): Move to window.el.
3938 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3939 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3940 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3941 window.el.
3942 (replace_buffer_in_windows): Implement by calling
3943 Qreplace_buffer_in_windows.
3944 (replace_buffer_in_all_windows): Remove with some functionality
3945 moved into replace_buffer_in_windows_safely.
3946 (replace_buffer_in_windows_safely): New function.
3947 (select_window_norecord, select_frame_norecord): Move in front
3948 of run_window_configuration_change_hook. Remove now obsolete
3949 declarations.
640c8776
SM
3950 (Fset_window_buffer): Rewrite doc-string.
3951 Call Qrecord_window_buffer.
9397e56f
MR
3952 (keys_of_window): Move binding for other-window to window.el.
3953
b50691aa
CY
39542011-06-11 Chong Yidong <cyd@stupidchicken.com>
3955
3956 * dispextern.h (struct image): Replace data member, whose int_val
3957 and ptr_val fields were not used by anything, with a single
3958 lisp_val object.
3959
3960 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3961 (gif_clear_image, gif_load, imagemagick_load_image)
3962 (gs_clear_image, gs_load): Callers changed.
3963
3f754b86
PE
39642011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3965
cca69397
PE
3966 * buffer.h: Include <time.h>, for time_t.
3967 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3968
109e28d0
PE
3969 Fix minor problems found by static checking.
3970
60737f02
PE
3971 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3972
4b66faf3
PE
3973 Make identifiers static if they are not used in other modules.
3974 * data.c (Qcompiled_function, Qframe, Qvector):
3975 * image.c (QimageMagick, Qsvg):
3976 * minibuf.c (Qmetadata):
3977 * window.c (resize_window_check, resize_root_window): Now static.
3978 * window.h (resize_window_check, resize_root_window): Remove decls.
3979
109e28d0
PE
3980 * window.c (window_deletion_count, delete_deletable_window):
3981 Remove; unused.
46a4ce9e
PE
3982 (window_body_lines): Now static.
3983 (Fdelete_other_windows_internal): Mark vars as initialized.
3984 Make sure 'resize_failed' is initialized.
3985 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3986 (resize_window_apply): Remove unused local.
3987 * window.h (delete_deletable_window): Remove decl.
3988
109e28d0 3989 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3990 (imagemagick_load_image): Fix pointer signedness problem by changing
3991 last arg from unsigned char * to char *. All uses changed.
3992 Also, fix a local for similar reasons.
3993 Remove unused locals. Remove locals to avoid shadowing.
3994 (fn_rsvg_handle_free): Remove; unused.
3995 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3996 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3997
3f754b86
PE
3998 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3999
2547adb1
CY
40002011-06-10 Chong Yidong <cyd@stupidchicken.com>
4001
4002 * image.c (gif_load): Fix omitted cast error introduced by
4003 2011-06-06 change.
4004
2c8e37d4
MR
40052011-06-10 Martin Rudalics <rudalics@gmx.at>
4006
4007 * window.h (resize_proportionally, orig_total_lines)
4008 (orig_top_line): Remove from window structure.
4009 (set_window_height, set_window_width, change_window_heights)
4010 (Fdelete_window): Remove prototypes.
4011 (resize_frame_windows): Remove duplicate declaration.
4012
440a42e3
EZ
40132011-06-10 Eli Zaretskii <eliz@gnu.org>
4014
4015 * window.h (resize_frame_windows, resize_window_check)
4016 (delete_deletable_window, resize_root_window)
4017 (resize_frame_windows): Declare prototypes.
4018
4019 * window.c (resize_window_apply): Make definition be "static" to
4020 match the prototype.
4021
562dd5e9
MR
40222011-06-10 Martin Rudalics <rudalics@gmx.at>
4023
4024 * window.c: Remove declarations of Qwindow_size_fixed,
4025 window_min_size_1, window_min_size_2, window_min_size,
4026 size_window, window_fixed_size_p, enlarge_window, delete_window.
4027 Remove static from declaration of Qdelete_window, it's
4028 temporarily needed by Fbury_buffer.
4029 (replace_window): Don't assign orig_top_line and
4030 orig_total_lines.
4031 (Fdelete_window, delete_window): Remove. Window deletion is
4032 handled by window.el.
640c8776
SM
4033 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4034 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4035 (Fdelete_other_windows): Remove. Deleting other windows is
4036 handled by window.el.
4037 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4038 handled in window.el.
4039 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4040 Window minimum sizes are handled in window.el.
4041 (shrink_windows, size_window, set_window_height)
4042 (set_window_width, change_window_heights, window_height)
4043 (window_width, CURBEG, CURSIZE, enlarge_window)
4044 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4045 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4046 handled in window.el.
4047 (make_dummy_parent): Rename to make_parent_window and give it a
4048 second argument horflag.
4049 (make_window): Don't set resize_proportionally any more.
4050 (Fsplit_window): Remove. Windows are split in window.el.
4051 (save_restore_action, save_restore_orig_size)
4052 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4053 Resize mini windows in window.el.
4054 (grow_mini_window, shrink_mini_window): Implement by calling
4055 Qresize_root_window_vertically, resize_window_check and
4056 resize_window_apply.
640c8776
SM
4057 (saved_window, Fset_window_configuration, save_window_save):
4058 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4059 resize_proportionally.
4060 (window_min_height, window_min_width): Move to window.el.
4061 (keys_of_window): Move bindings for delete-other-windows,
4062 split-window, delete-window and enlarge-window to window.el.
4063
4064 * buffer.c: Temporarily extern Qdelete_window.
4065 (Fbury_buffer): Temporarily call Qdelete_window instead of
4066 Fdelete_window (Fbury_buffer will move to window.el soon).
4067
4068 * frame.c (set_menu_bar_lines_1): Remove code handling
4069 orig_top_line and orig_total_lines.
4070
4071 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4072 set_window_height but set heights directly.
4073 (change_frame_size_1): Use resize_frame_windows.
4074
4075 * xdisp.c (init_xdisp): Don't use set_window_height but set
4076 heights directly.
4077
640c8776
SM
4078 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4079 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4080 run_window_configuration_change_hook.
4081
4082 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4083 instead of change_window_heights and run
4084 run_window_configuration_change_hook.
4085
1a13852e
MR
40862011-06-09 Martin Rudalics <rudalics@gmx.at>
4087
4088 * window.c (replace_window): Rename second argument REPLACEMENT to
4089 NEW. New third argument SETFLAG. Rewrite.
4090 (delete_window, make_dummy_parent): Call replace_window with
4091 third argument 1.
4092 (window_list_1): Move down in code.
4093 (run_window_configuration_change_hook): Move set_buffer part
4094 before select_frame_norecord part in order to unwind correctly.
4095 Rename count1 to count.
4096 (recombine_windows, delete_deletable_window, resize_root_window)
4097 (Fdelete_other_windows_internal)
4098 (Frun_window_configuration_change_hook, make_parent_window)
4099 (resize_window_check, resize_window_apply, Fresize_window_apply)
4100 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4101 (Fdelete_window_internal, Fresize_mini_window_internal):
4102 New functions.
1a13852e
MR
4103 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4104
f3d1777e
MR
41052011-06-08 Martin Rudalics <rudalics@gmx.at>
4106
496e208e
MR
4107 * window.h (window): Add some new members to window structure -
4108 normal_lines, normal_cols, new_total, new_normal, clone_number,
4109 splits, nest, prev_buffers, next_buffers.
4110 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4111 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4112
f3d1777e
MR
4113 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4114 Remove.
496e208e
MR
4115 (make_dummy_parent): Set new members of windows structure.
4116 (make_window): Move down in code. Handle new members of window
4117 structure.
4118 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4119 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4120 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4121 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4122 (Fset_window_next_buffers, Fset_window_clone_number):
4123 New functions.
496e208e
MR
4124 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4125 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4126 Doc-string fixes.
4127 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4128 Argument WINDOW can be now internal window too.
4129 (Fwindow_use_time): Move up in code.
4130 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4131 Rewrite doc-string.
4132 (Fset_window_configuration, saved_window)
4133 (Fcurrent_window_configuration, save_window_save): Handle new
4134 members of window structure.
b9e809c2
MR
4135 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4136 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4137 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4138 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4139 Qget_mru_window, Qresize_root_window,
4140 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4141 Qauto_buffer_name; staticpro them.
f3d1777e 4142
abde8f8c
MR
41432011-06-07 Martin Rudalics <rudalics@gmx.at>
4144
4145 * window.c (Fwindow_total_size, Fwindow_left_column)
4146 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4147 (Fwindow_list_1): New functions.
4148 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4149 (Fwindow_width, Fscroll_left, Fscroll_right):
4150 Use window_body_cols instead of window_box_text_cols.
4151 (delete_window, Fset_window_configuration):
4152 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4153 (delete_all_subwindows): Take a window as argument and not a
4154 structure. Rewrite.
190b47e6
MR
4155 (window_loop): Remove handling of GET_LRU_WINDOW and
4156 GET_LARGEST_WINDOW.
4157 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4158
4159 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4160 window_box_text_cols. delete_all_subwindows now takes a
4161 Lisp_Object as argument.
abde8f8c 4162
640c8776
SM
4163 * indent.c (compute_motion, Fcompute_motion):
4164 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4165
fa8a67e6
MR
4166 * frame.c (delete_frame): Call delete_all_subwindows with root
4167 window as argument.
4168
a54e3482
DC
41692011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4170
4171 * fns.c (Fputhash): Document return value.
4172
60002bf5
CY
41732011-06-06 Chong Yidong <cyd@stupidchicken.com>
4174
4175 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4176
0c671da6 41772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4178
b862a52a 4179 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4180
be44ca6c
PE
4181 Check for overflow when converting integer to cons and back.
4182 * charset.c (Fdefine_charset_internal, Fdecode_char):
4183 Use cons_to_unsigned to catch overflow.
4184 (Fencode_char): Use INTEGER_TO_CONS.
4185 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4186 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4187 * data.c (long_to_cons, cons_to_long): Remove.
4188 (cons_to_unsigned, cons_to_signed): New functions.
4189 These signal an error for invalid or out-of-range values.
4190 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4191 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4192 * font.c (Ffont_variation_glyphs):
4193 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4194 * lisp.h: Include <intprops.h>.
4195 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4196 (cons_to_signed, cons_to_unsigned): New decls.
4197 (long_to_cons, cons_to_long): Remove decls.
4198 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4199 (Fprimitive_undo): Use CONS_TO_INTEGER.
4200 * xfns.c (Fx_window_property): Likewise.
4201 * xselect.c: Include <limits.h>.
4202 (x_own_selection, selection_data_to_lisp_data):
4203 Use INTEGER_TO_CONS.
4204 (x_handle_selection_request, x_handle_selection_clear)
4205 (x_get_foreign_selection, Fx_disown_selection_internal)
4206 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4207 (lisp_data_to_selection_data): Use cons_to_unsigned.
4208 (x_fill_property_data): Use cons_to_signed.
4209 Report values out of range.
4210
d1f3d2af
PE
4211 Check for buffer and string overflow more precisely.
4212 * buffer.h (BUF_BYTES_MAX): New macro.
4213 * lisp.h (STRING_BYTES_MAX): New macro.
4214 * alloc.c (Fmake_string):
4215 * character.c (string_escape_byte8):
4216 * coding.c (coding_alloc_by_realloc):
4217 * doprnt.c (doprnt):
4218 * editfns.c (Fformat):
4219 * eval.c (verror):
4220 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4221 since they may not be the same number.
4222 * editfns.c (Finsert_char):
4223 * fileio.c (Finsert_file_contents):
4224 Likewise for BUF_BYTES_MAX.
4225
dd52fcea
PE
4226 * image.c: Use ptrdiff_t, not int, for sizes.
4227 (slurp_file): Switch from int to ptrdiff_t.
4228 All uses changed.
4229 (slurp_file): Check that file size fits in both size_t (for
4230 malloc) and ptrdiff_t (for sanity and safety).
4231
7f9bbdbb
PE
4232 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4233 if b->modtime has its maximal value.
4234
dfe18f82
PE
4235 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4236
84acfcf0
PE
4237 Don't assume time_t can fit into int.
4238 * buffer.h (struct buffer.modtime): Now time_t, not int.
4239 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4240 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4241
ccd9a01a
PE
4242 Minor fixes for signed vs unsigned integers.
4243 * character.h (MAYBE_UNIFY_CHAR):
4244 * charset.c (maybe_unify_char):
4245 * keyboard.c (read_char, reorder_modifiers):
4246 XINT -> XFASTINT, since the integer must be nonnegative.
4247 * ftfont.c (ftfont_spec_pattern):
4248 * keymap.c (access_keymap, silly_event_symbol_error):
4249 XUINT -> XFASTINT, since the integer must be nonnegative.
4250 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4251 since it makes no difference and we prefer signed.
4252 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4253 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4254 nonnegative.
4255
d6d100dd
SM
42562011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4257
4258 * window.h (Fwindow_frame): Declare.
4259
2b6148e4
PE
42602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4261
4262 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4263 (SPARE_MEMORY): Always define.
4264 (LARGE_REQUEST): Remove.
4265 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4266
f230ecc9
MR
42672011-06-06 Martin Rudalics <rudalics@gmx.at>
4268
727e958e
MR
4269 * lisp.h: Move EXFUNS for Fframe_root_window,
4270 Fframe_first_window and Fset_frame_selected_window to window.h.
4271
4272 * window.h: Move EXFUNS for Fframe_root_window,
4273 Fframe_first_window and Fset_frame_selected_window here from
4274 lisp.h.
4275
4276 * frame.c (Fwindow_frame, Fframe_first_window)
4277 (Fframe_root_window, Fframe_selected_window)
4278 (Fset_frame_selected_window): Move to window.c.
4279 (Factive_minibuffer_window): Move to minibuf.c.
4280 (Fother_visible_frames_p): New function.
4281
4282 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4283
f230ecc9
MR
4284 * window.c (decode_window, decode_any_window): Move up in code.
4285 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4286 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4287 (Fwindow_buffer): Move up and rewrite doc-string.
4288 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4289 (Fwindow_prev): New functions.
727e958e
MR
4290 (Fwindow_frame): Move here from frame.c. Accept any window as
4291 argument.
4292 (Fframe_root_window, Fframe_first_window)
4293 (Fframe_selected_window): Move here from frame.c. Accept frame
4294 or arbitrary window as argument. Update doc-strings.
4295 (Fminibuffer_window): Move up in code.
4296 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4297 (Fset_frame_selected_window): Move here from frame.c.
4298 Marginal rewrite.
727e958e
MR
4299 (Fselected_window, select_window, Fselect_window): Move up in
4300 code. Minor doc-string fixes.
f230ecc9 4301
4d09bcf6
PE
43022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4303
4304 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4305 Do not assume that spare memory exists; that assumption is valid
4306 only if SYSTEM_MALLOC.
4307 (LARGE_REQUEST): New macro, so that the issue of large requests
4308 is separated from the issue of spare memory.
4309
810928a2
AS
43102011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4311
172418ad
AS
4312 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4313 format. (Bug#8806)
4314
43f862f7
AS
4315 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4316
810928a2
AS
4317 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4318 before statements.
4319
a059fe24
JD
43202011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4321
4322 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4323
4324 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4325
4326 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4327 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4328
989bf368
JB
43292011-06-05 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4332
4b80f674
CY
43332011-06-04 Chong Yidong <cyd@stupidchicken.com>
4334
4335 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4336 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4337 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4338 New error handlers.
4b80f674
CY
4339 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4340 Obey Vx_select_enable_clipboard_manager. Catch errors in
4341 x_clipboard_manager_save (Bug#8779).
4342 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4343 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4344
99a33b77 43452011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4346
4347 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4348
99a33b77 43492011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4350
4351 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4352 in the current matrix if keep_current_p is non-zero.
4353
8264569d
EZ
43542011-06-04 Eli Zaretskii <eliz@gnu.org>
4355
4356 * bidi.c (bidi_level_of_next_char): Fix last change.
4357
57f97249
EZ
43582011-06-03 Eli Zaretskii <eliz@gnu.org>
4359
fec2107c 4360 Support bidi reordering of text covered by display properties.
57f97249 4361
fec2107c
EZ
4362 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4363 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4364 (bidi_cache_search, bidi_cache_iterator_state)
4365 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4366 (bidi_level_of_next_char, bidi_move_to_visually_next):
4367 Support character positions inside a run of characters covered by a
fec2107c
EZ
4368 display string.
4369 (bidi_paragraph_init, bidi_resolve_explicit_1)
4370 (bidi_level_of_next_char): Call bidi_fetch_char and
4371 bidi_fetch_char_advance instead of FETCH_CHAR and
4372 FETCH_CHAR_ADVANCE.
4373 (bidi_init_it): Initialize new members.
4374 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4375 definitions.
4376 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4377 instead of using explicit *_CHAR codes.
d6d100dd
SM
4378 (bidi_resolve_explicit, bidi_resolve_weak):
4379 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4380 bidirectional text is supported only in multibyte buffers.
4381 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4382 it to initialize the frame_window_p member of struct bidi_it.
4383 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4384 (bidi_resolve_explicit, bidi_resolve_weak)
4385 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4386 bidi_it->nchars is non-positive.
4387 (bidi_level_of_next_char): Don't try to lookup the cache for the
4388 next/previous character if nothing is cached there yet, or if we
4389 were just reseat()'ed to a new position.
c40e2fb2 4390
0e14fe90
EZ
4391 * xdisp.c (set_cursor_from_row): Set start and stop points
4392 according to the row's direction when priming the loop that looks
4393 for the glyph on which to display cursor.
4394 (single_display_spec_intangible_p): Function deleted.
4395 (display_prop_intangible_p): Reimplement to call
4396 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4397 Accept 3 additional arguments needed by handle_display_spec.
4398 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4399 values: lists, `(when COND...)' forms, etc.
4400 (single_display_spec_string_p): Support property values that are
4401 lists with the argument STRING its top-level element.
4402 (display_prop_string_p): Fix the condition for processing a
4403 property that is a list to be consistent with handle_display_spec.
fec2107c 4404 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4405 last portion of handle_display_prop.
4406 (compute_display_string_pos): Accept additional argument
4407 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4408 value of a `display' property is a "replacing spec".
4409 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4410 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4411 the display property, but just return a value indicating whether
4412 the display property will replace the characters it covers.
4413 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4414 frame_window_p members of struct bidi_it.
d6d100dd
SM
4415 (compute_display_string_pos, compute_display_string_end):
4416 New functions.
fec2107c
EZ
4417 (push_it): Accept second argument POSITION, where pop_it should
4418 jump to continue iteration.
4419 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4420
fec2107c
EZ
4421 * keyboard.c (adjust_point_for_property): Adjust the call to
4422 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4423
4424 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4425 (bidi_init_it): Update prototypes.
4426 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4427 (compute_display_string_pos, compute_display_string_end):
4428 Declare prototypes.
fec2107c
EZ
4429 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4430 EMACS_INT.
fc6f18ce 4431
40087514 44322011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4433
57f53182
PE
4434 Malloc failure behavior now depends on size of allocation.
4435 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4436 * lisp.h: Change signatures accordingly.
4437 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4438 All callers changed. (Bug#8762)
4439
4440 * gnutls.c: Use Emacs's memory allocators.
4441 Without this change, the gnutls library would invoke malloc etc.
4442 directly, which causes problems on non-SYNC_INPUT hosts, and which
4443 runs afoul of improving memory_full behavior. (Bug#8761)
4444 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4445 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4446 xfree instead of the default malloc, realloc, free.
4447 (Fgnutls_boot): No need to check for memory allocation failure,
4448 since xmalloc does that for us.
4449
ac32cd99 4450 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4451 * category.c (hash_get_category_set):
4452 * ccl.c (ccl_driver):
4453 * charset.c (Fdefine_charset_internal):
4454 * charset.h (struct charset.hash_index):
4455 * composite.c (get_composition_id, gstring_lookup_cache)
4456 (composition_gstring_put_cache):
4457 * composite.h (struct composition.hash_index):
4458 * dispextern.h (struct image.hash):
4459 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4460 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4461 (hashfn_equal, hashfn_user_defined, make_hash_table)
4462 (maybe_resize_hash_table, hash_lookup, hash_put)
4463 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4464 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4465 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4466 * image.c (make_image, search_image_cache, lookup_image)
4467 (xpm_put_color_table_h):
4468 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4469 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4470 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4471 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4472 * alloc.c (allocate_vectorlike):
4473 Check for overflow in vector size calculations.
4474 * ccl.c (ccl_driver):
4475 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4476 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4477 need to be updated by these changes.
40087514
PE
4478 * fns.c (make_hash_table, maybe_resize_hash_table):
4479 Check for integer overflow with large hash tables.
0de4bb68
PE
4480 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4481 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4482 (SXHASH_REDUCE): New macro.
4483 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4484 Use it instead of discarding useful hash info with large hash values.
4485 (sxhash_float): New function.
4486 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4487 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4488 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4489 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4490 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4491 Adjust signatures to match updated version of code.
4492 (consing_since_gc): Now EMACS_INT, since a single hash table can
4493 use more than INT_MAX bytes.
4494
698d32e2
DN
44952011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4496
4497 Make it possible to build with GCC-4.6+ -O2 -flto.
4498
4499 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4500
fd6fa53f
SM
45012011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4502
4503 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4504 Call minibuffer-inactive-mode.
4505
864db017
JB
45062011-05-31 Juanma Barranquero <lekktu@gmail.com>
4507
4508 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4509 Update dependencies.
4510
2ad0baf4
DN
45112011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4512
4513 * data.c (init_data): Remove code for UTS, this system is not
4514 supported anymore.
4515
4fcc2638
DN
45162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4517
4518 Don't force ./temacs to start in terminal mode.
4519
4520 * frame.c (make_initial_frame): Initialize faces in all cases, not
4521 only when CANNOT_DUMP is defined.
4522 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4523
c56e0fd5
DN
45242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4525
4526 * dispnew.c (add_window_display_history): Use const for the string
4527 pointer. Remove declaration, not needed.
4528
333d54da 45292011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4530
55d4c1b2 4531 Use 'inline', not 'INLINE'.
333d54da 4532 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4533 * alloc.c, fontset.c (INLINE): Remove.
4534 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4535 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4536 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4537 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4538 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4539
738db178
DN
45402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4541
4542 Make it possible to run ./temacs.
4543
4544 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4545 syms_of_callproc does the same thing. Remove test for
4546 "initialized", do it in the caller.
4547 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4548
620c53a6
SM
45492011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4550
4551 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4552 (read_minibuf): Use get_minibuffer.
4553 (syms_of_minibuf): Use DEFSYM.
4554 (Qmetadata): New var.
4555 * data.c (Qbuffer): Don't make it static.
4556 (syms_of_data): Use DEFSYM.
4557
e003a292
PE
45582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4559
4560 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4561 (CCL_CODE_MIN): New macro.
4562
ed008a6d
PE
45632011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4564
3687c2ef
PE
4565 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4566
ed008a6d
PE
4567 * eval.c (Qdebug): Now static.
4568 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4569 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4570 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4571
d66c4c7c
CY
45722011-05-29 Chong Yidong <cyd@stupidchicken.com>
4573
4574 * image.c: Various fixes to ImageMagick code comments.
4575 (Fimagemagick_types): Doc fix.
4576
5fbc2025
PE
45772011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4578
0196f88a
PE
4579 Minor fixes prompted by GCC 4.6.0 warnings.
4580
4581 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4582
5fbc2025
PE
4583 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4584 (x_clipboard_manager_save_all): Move extern decl to ...
4585 * xterm.h: ... here, so that it can be checked for consistency.
4586
1dd3c2d9
CY
45872011-05-29 Chong Yidong <cyd@stupidchicken.com>
4588
4589 * xselect.c (x_clipboard_manager_save_frame)
4590 (x_clipboard_manager_save_all): New functions.
4591 (Fx_clipboard_manager_save): Lisp function deleted.
4592
4593 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4594 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4595
4596 * xterm.h: Update prototype.
4597
5ba6571d
WX
45982011-05-28 William Xu <william.xwl@gmail.com>
4599
4600 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4601 exiting (Bug#8239).
4602
3eaff834
JM
46032011-05-28 Jim Meyering <meyering@redhat.com>
4604
e1900994 4605 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4606 * fns.c (to_uchar): Define.
4607 (crypto_hash_function): Use it to convert some newly-signed
4608 variables to unsigned, to avoid sign-extension bugs. For example,
4609 without this change, (md5 "truc") would evaluate to
4610 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4611 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4612 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4613
0f6990a7
PE
46142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4615
4616 Integer overflow fixes.
c8a9ca5a 4617
08686060
PE
4618 * dbusbind.c: Serial number integer overflow fixes.
4619 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4620 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4621 to hold a serial number that is too large for a fixnum.
4622 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4623 Check for serial numbers out of range. Decode any serial number
59568bf0 4624 that was so large that it became a float. (Bug#8722)
08686060 4625
2d1fc3c7
PE
4626 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4627 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4628 Use XFASTINT rather than XUINT when numbers are nonnegative.
4629 (xd_append_arg, Fdbus_method_return_internal):
4630 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4631 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4632 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4633 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4634 (Bug#8722)
2d1fc3c7 4635
c8a9ca5a
PE
4636 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4637
519e1d69
PE
4638 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4639
30569699
PE
4640 ccl: add integer overflow checks
4641 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4642 (IN_INT_RANGE): New macros.
4643 (ccl_driver): Use them to check for integer overflow when
4644 decoding a CCL program. Many of the new checks are whether XINT (x)
4645 fits in int; it doesn't always, on 64-bit hosts. The new version
4646 doesn't catch all possible integer overflows, but it's an
847044ea 4647 improvement. (Bug#8719)
30569699 4648
c11285dc
PE
4649 * alloc.c (make_event_array): Use XINT, not XUINT.
4650 There's no need for unsigned here.
4651
fdccd48e
PE
4652 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4653 This follows up to the 2011-05-06 change that substituted uintptr_t
4654 for EMACS_INT. This case wasn't caught back then.
4655
37910ab2
PE
4656 Rework Fformat to avoid integer overflow issues.
4657 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4658 now (part of C89). Include <verify.h>.
4659 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4660 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4661 (Fformat): Avoid the prepass trying to compute sizes; it was only
4662 approximate and thus did not catch overflow reliably. Instead, walk
4663 through the format just once, formatting and computing sizes as we go,
4664 checking for integer overflow at every step, and allocating a larger
4665 buffer as needed. Keep track separately whether the format is
4666 multibyte. Keep only the most-recently calculated precision, rather
4667 than them all. Record whether each argument has been converted to
4668 string. Use EMACS_INT, not int, for byte and char and arg counts.
4669 Support field widths and precisions larger than INT_MAX. Avoid
4670 sprintf's undefined behavior with conversion specifications such as %#d
4671 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4672 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4673 formatting out-of-range floating point numbers with int
9173deec 4674 formats. (Bug#8668)
37910ab2 4675
2e6578fb
PE
4676 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4677
0ae6bdee
PE
4678 * data.c: Avoid integer truncation in expressions involving floats.
4679 * data.c: Include <intprops.h>.
4680 (arith_driver): When there's an integer overflow in an expression
4681 involving floating point, convert the integers to floating point
4682 so that the resulting value does not suffer from catastrophic
4683 integer truncation. For example, on a 64-bit host (* 4
4684 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4685 Do not rely on undefined behavior after integer overflow.
4686
de883a70
PE
4687 merge count_size_as_multibyte, parse_str_to_multibyte
4688 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4689 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4690 Check for integer overflow.
4691 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4692 since it's now a duplicate of the other. This is more of
4693 a character than a buffer op, so better that it's in character.c.
4694 * fns.c, print.c: Adjust to above changes.
4695
2ff916cb
PE
46962011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4697
4698 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4699
f1b54466
PE
47002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4701
fb1ac845
PE
4702 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4703 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4704 (x_clipboard_manager_save): Now static.
4705 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4706
f1b54466
PE
4707 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4708 (crypto_hash_function): Now static.
4709 Fix pointer signedness problems. Avoid unnecessary initializations.
4710
a9f737ee
CY
47112011-05-27 Chong Yidong <cyd@stupidchicken.com>
4712
4713 * termhooks.h (Vselection_alist): Make it terminal-local.
4714
4715 * terminal.c (create_terminal): Initialize it.
4716
4717 * xselect.c: Support for clipboard managers.
4718 (Vselection_alist): Move to termhooks.h as terminal-local var.
4719 (LOCAL_SELECTION): New macro.
4720 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4721 (symbol_to_x_atom): Remove gratuitous arg.
4722 (x_handle_selection_request, lisp_data_to_selection_data)
4723 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4724 (x_own_selection, x_get_local_selection, x_convert_selection):
4725 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4726 (some_frame_on_display): Delete unused function.
4727 (Fx_own_selection_internal, Fx_get_selection_internal)
4728 (Fx_disown_selection_internal, Fx_selection_owner_p)
4729 (Fx_selection_exists_p): New optional frame arg.
4730 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4731 (x_handle_selection_clear): Don't treat other terminals with the
4732 same keyboard specially. Use the terminal-local Vselection_alist.
4733 (x_clear_frame_selections): Use Frun_hook_with_args.
4734
4735 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4736
4737 * xterm.h: Add support for those atoms.
4738
e067f0c1
CY
47392011-05-26 Chong Yidong <cyd@stupidchicken.com>
4740
4741 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4742 (converted_selections, conversion_fail_tag): New global variables.
4743 (x_selection_request_lisp_error): Free the above.
4744 (x_get_local_selection): Remove unnecessary code.
4745 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4746 of converted selections stored in converted_selections.
4747 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4748 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4749 (x_convert_selection): New function.
4750 (x_handle_selection_event): Simplify.
4751 (x_get_foreign_selection): Don't ignore incoming requests while
4752 waiting for an answer; this will fail when we implement
4753 SAVE_TARGETS, and seems unnecessary anyway.
4754 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4755 (Vx_sent_selection_functions): Doc fix.
4756
0f4aebc0
LL
47572011-05-26 Leo Liu <sdl.web@gmail.com>
4758
4759 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4760
e61124cd
YM
47612011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4762
4763 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4764
4765 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4766 for fringe update if it has periodic bitmap.
ac389d0c 4767 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4768 and fringe_bitmap_periodic_p.
4769
4770 * fringe.c (get_fringe_bitmap_data): New function.
4771 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4772 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4773 row. Mark glyph row for fringe update if periodicity changed.
4774
4775 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4776 for fringe update unless it has periodic bitmap.
4777
f16d9837
KH
47782011-05-25 Kenichi Handa <handa@m17n.org>
4779
4780 * xdisp.c (get_next_display_element): Set correct it->face_id for
4781 a static composition.
4782
e1b90ef6
LL
47832011-05-24 Leo Liu <sdl.web@gmail.com>
4784
4785 * deps.mk (fns.o):
4786 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4787
4788 * fns.c (crypto_hash_function, Fsha1): New function.
4789 (Fmd5): Use crypto_hash_function.
4790 (syms_of_fns): Add Ssha1.
4791
7400048f
PE
47922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4793
4794 * gnutls.c: Remove unused macros.
4795 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4796 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4797 Remove macros that are defined and never used.
4798 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4799
abb71cf4
CY
48002011-05-22 Chong Yidong <cyd@stupidchicken.com>
4801
4802 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4803 (Fx_get_selection_internal): Minor cleanup.
4804 (Fx_own_selection_internal): Rename arguments for consistency with
4805 select.el.
4806
6307db39
PE
48072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4810
f3d4e0a4
CY
48112011-05-22 Chong Yidong <cyd@stupidchicken.com>
4812
4813 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4814
4d8ade89
YM
48152011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4816
4817 * dispnew.c (scrolling_window): Don't exclude the case that the
4818 last enabled row in the desired matrix touches the bottom boundary.
4819
32078c8d
GM
48202011-05-21 Glenn Morris <rgm@gnu.org>
4821
4822 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4823 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4824 and add some more files.
32078c8d 4825
7285dc67
EZ
48262011-05-20 Eli Zaretskii <eliz@gnu.org>
4827
4828 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4829 report_file_error introduced by the change from 2011-05-07.
4830
89d1bd22
PE
48312011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4832
4833 * systime.h (Time): Define only if emacs is defined.
4834 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4835 where the include path doesn't have X11/X.h by default. See
4836 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4837
e23640bb 48382011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4839
4840 * composite.c (find_automatic_composition): Fix previous change.
4841
b9704ad9
GM
48422011-05-20 Glenn Morris <rgm@gnu.org>
4843
4844 * lisp.mk: New file, split from Makefile.in.
4845 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4846 (shortlisp): Remove.
4847 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4848
4a720484
GM
48492011-05-19 Glenn Morris <rgm@gnu.org>
4850
4851 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4852 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4853 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4854 (lisp): Set the order to that of loadup.el.
4855 (shortlisp): Make it a copy of $lisp.
4856 (SOME_MACHINE_LISP): Remove.
4857 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4858 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4859
a28d4396
KH
48602011-05-18 Kenichi Handa <handa@m17n.org>
4861
4862 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4863 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4864 (find_automatic_composition): Mostly rewrite for efficiency.
4865
a2b1fa8e
JB
48662011-05-18 Juanma Barranquero <lekktu@gmail.com>
4867
4868 * makefile.w32-in: Update dependencies.
4869
8e1f5610
CS
48702011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4871
4872 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4873 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4874
7025ee00 48752011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4876
cdfa6eab
PE
4877 Fix some integer overflow issues, such as string length overflow.
4878
06d6db33
PE
4879 * insdel.c (count_size_as_multibyte): Check for string overflow.
4880
2b4560a8
PE
4881 * character.c (lisp_string_width): Check for string overflow.
4882 Use EMACS_INT, not int, for string indexes and lengths; in
4883 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4884 the resulting string length overflows an EMACS_INT; instead,
4885 report a string overflow if no precision given. When checking for
4886 precision exhaustion, use a check that cannot possibly have
4887 integer overflow. (Bug#8675)
4888 * character.h (lisp_string_width): Adjust to new signature.
4889
cb93f9be
PE
4890 * alloc.c (string_overflow): New function.
4891 (Fmake_string): Use it. This doesn't change behavior, but saves
4892 a few bytes and will simplify future changes.
4893 * character.c (string_escape_byte8): Likewise.
4894 * lisp.h (string_overflow): New decl.
4895
1a1f3366
PE
4896 Fixups, following up to the user-interface timestamp change.
4897 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4898 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4899 * msdos.c (mouse_get_pos): Likewise.
4900 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4901 * w32gui.h (Time): Define by including "systime.h" rather than by
4902 declaring it ourselves. (Bug#8664)
4903
d4e3e4d3
PE
4904 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4905 * image.c (clear_image_cache): Likewise.
4906
f6a24d19
PE
4907 * term.c (term_mouse_position): Don't assume time_t wraparound.
4908
08dc5ae6
PE
4909 Be more systematic about user-interface timestamps.
4910 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4911 and sometimes 'EMACS_UINT', to represent these timestamps.
4912 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4913 This makes the code easier to follow, and makes it easier to catch
4914 integer overflow bugs such as Bug#8664.
4915 * frame.c (Fmouse_position, Fmouse_pixel_position):
4916 Use Time, not unsigned long, for user-interface timestamps.
4917 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4918 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4919 * keyboard.h (last_event_timestamp): Likewise.
4920 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4921 * menu.h (xmenu_show): Likewise.
4922 * term.c (term_mouse_position): Likewise.
4923 * termhooks.h (struct input_event.timestamp): Likewise.
4924 (struct terminal.mouse_position_hook): Likewise.
4925 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4926 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4927 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4928 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4929 what it was before.
4930 * menu.h, termhooks.h: Include "systime.h", for Time.
4931
8e55734a
PE
4932 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4933 Don't assume that the difference between two unsigned long values
4934 can fit into an integer. At this point, we know button_down_time
4935 <= event->timestamp, so the difference must be nonnegative, so
4936 there's no need to cast the result if double-click-time is
4937 nonnegative, as it should be; check that it's nonnegative, just in
4938 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4939 apart (about 25 days). (Bug#8664)
8e55734a 4940
841f1b75 4941 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4942 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4943
3e26f69c
PE
4944 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4945 that always fit in int. Use a sentinel instead of a counter, to
4946 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4947 * frame.h (struct frame): Use int for menu_bar_items_used
4948 instead of EMACS_INT, since it always fits in int.
3e26f69c 4949
5cc152c0
PE
4950 * menu.c (grow_menu_items): Check for int overflow.
4951
d89eb65e
PE
4952 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4953
5235bd3e
PE
4954 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4955 Before, the code was not consistent. These values cannot exceed
4956 2**31 - 1 so there's no need to make them unsigned.
4957 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4958 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4959 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4960 as modifiers.
4961 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4962
bc827e23
PE
4963 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4964 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4965 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4966 presumably because the widths might not match.
4967
78eb494e
PE
4968 * window.c (size_window): Avoid needless test at loop start.
4969
04f2d78b
CB
49702011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4971
4972 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4973
d2fc7e3d 49742011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4975
4976 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4977
d2fc7e3d 49782011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4979
4980 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4981 `width' to `bar_area_x' and `bar_area_width', respectively.
4982 (x_scroll_run): Take account of fringe background extension.
4983
04f2d78b
CB
4984 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4985 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4986 `bar_area_width', respectively.
4987 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4988 background extension.
4989
79b70037
GM
49902011-05-10 Jim Meyering <meyering@redhat.com>
4991
4992 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4993
2f142cc5
JB
49942011-05-10 Juanma Barranquero <lekktu@gmail.com>
4995
4996 * image.c (Finit_image_library): Return t for built-in image types,
4997 like pbm and xbm. (Bug#8640)
4998
57679c86
AS
49992011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5000
5001 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5002
888c9e86
EZ
50032011-05-07 Eli Zaretskii <eliz@gnu.org>
5004
b0512a1d
EZ
5005 * w32console.c (Fset_screen_color): Doc fix.
5006 (Fget_screen_color): New function.
5007 (syms_of_ntterm): Defsubr it.
5008
7285dc67
EZ
5009 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5010 unlink the temporary file if Fcall_process didn't create it in the
5011 first place.
5012 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5013 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5014 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5015 cue to call_process_cleanup not to close that handle.
5016
4d3fcc8e
BK
50172011-05-07 Ben Key <bkey76@gmail.com>
5018
5019 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5020 one of two shell specific rules, either bootstrap-temacs-CMD or
5021 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5022 to the previous implementation of the bootstrap-temacs rule.
5023 The bootstrap-temacs-CMD rule is similar to the previous
5024 implementation of the bootstrap-temacs rule except that it
5025 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5026 variable.
5027
5028 These changes, along with some changes to nt/configure.bat,
5029 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5030 earlier fix to add support for --cflags and --ldflags options
5031 that include quotes so that it works whether make uses cmd or
5032 sh as the shell.
5033
b4289b64
MA
50342011-05-06 Michael Albinus <michael.albinus@gmx.de>
5035
5036 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5037 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5038 is a constant.
5039 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5040 a string. Handle both cases.
5041 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5042 (Fdbus_register_method): Use Qinvalid_function.
5043
af4c0e28
JB
50442011-05-06 Juanma Barranquero <lekktu@gmail.com>
5045
5046 * makefile.w32-in: Update dependencies.
5047 (LISP_H): Add inttypes.h and stdin.h.
5048 (PROCESS_H): Add unistd.h.
5049
c51453d9
EZ
50502011-05-06 Eli Zaretskii <eliz@gnu.org>
5051
5052 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5053 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5054
8ff0ac3c 50552011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5056
4c4b566b
PE
5057 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5058
aab2b9b5
PE
5059 * term.c (vfatal): Remove stray call to va_end.
5060 It's not needed and the C Standard doesn't allow it here anyway.
5061
c378da0b
PE
5062 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5063 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5064
288b08c7
PE
5065 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5066 bytes.
5067
e3601888
PE
5068 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5069
db6c0e74
PE
5070 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5071
dd5963ea
PE
5072 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5073
88c9450f
PE
5074 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5075
2f9442b8
PE
5076 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5077
c032b5f8
PE
5078 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5079 * charset.c (Fdefine_charset_internal): Don't initialize
5080 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5081 32-bit int (Bug#8600).
a108c10b
PE
5082
5083 * lread.c (read_integer): Be more consistent with string-to-number.
5084 Use string_to_number to do the actual conversion; this avoids
5085 rounding errors and fixes some other screwups. Without this fix,
5086 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5087 (digit_to_number): Move earlier, for benefit of read_integer.
5088 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5089 not a digit in any supported base. (Bug#8602)
a108c10b 5090
ad5f9eea
PE
5091 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5092
aec1708a
PE
5093 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5094 to match comment at start of function. This also removes a
5095 GCC warning about overflow in a 32+64-bit port.
5096
47be4ab5
PE
5097 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5098
371cac43
PE
5099 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5100 Reported by Stefan Monnier in
5101 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5102 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5103 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5104
d01a7826
PE
5105 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5106 (EMACS_UINTPTR): Likewise, with uintptr_t.
5107
7fd47d5c
PE
5108 * lisp.h: Prefer 64-bit EMACS_INT if available.
5109 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5110 on 32-bit hosts that have 64-bit int, so that they can access
5111 large files.
122b0c86
PE
5112 However, temporarily disable this change unless the temporary
5113 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5114
8727937b
PE
5115 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5116
8ac068ac
PE
5117 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5118 This removes an assumption that EMACS_INT and long are the same
5119 width as pointers. The assumption is true for Emacs porting targets
5120 now, but we want to make other targets possible.
5121 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5122 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5123 In the rest of the code, change types of integers that hold casted
5124 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5125 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5126 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5127 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5128 No need to cast type when ORing.
5129 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5130 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5131 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5132 assume EMACS_INT is the same width as char *.
5133 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5134 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5135 Remove no-longer-needed casts.
5136 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5137 (xg_tool_bar_help_callback, xg_make_tool_item):
5138 Use EMACS_INTPTR to hold an integer
5139 that will be cast to void *; this can avoid a GCC warning
5140 if EMACS_INT is not the same width as void *.
5141 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5142 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5143 (current_message_1, set_message_1):
5144 Use a local to convert to proper width without a cast.
5145 * xmenu.c (dialog_selection_callback): Likewise.
5146
ede49d71
PE
5147 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5148 Also, don't assume VALBITS / RAND_BITS is less than 5,
5149 and don't rely on undefined behavior when shifting a 1 left into
5150 the sign bit.
5151 * lisp.h (get_random): Change signature to match.
5152
2f30ecd0
PE
5153 * lread.c (hash_string): Use size_t, not int, for hash computation.
5154 Normally we prefer signed values; but hashing is special, because
5155 it's better to use unsigned division on hash table sizes so that
5156 the remainder is nonnegative. Also, size_t is the natural width
5157 for hashing into memory. The previous code used 'int', which doesn't
5158 retain enough info to hash well into very large tables.
5159 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5160
2a866e7b
PE
5161 * dbusbind.c: Don't possibly lose pointer info when converting.
5162 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5163 Use XPNTR rather than XHASH, so that the high-order bits of
5164 the pointer aren't lost when converting through void *.
5165
51639eac
PE
5166 * eval.c (Fautoload): Don't double-shift a pointer.
5167
92394119
PE
5168 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5169
dbdb9a7c
JB
51702011-05-06 Juanma Barranquero <lekktu@gmail.com>
5171
5172 * gnutls.c (DEF_GNUTLS_FN):
5173 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5174
db7a0b4f
AS
51752011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5176
5177 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5178 marker. (Bug#8610)
5179
f7ff1b0f 51802011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5181
5182 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5183 New version that can reserve upto 2GB of heap space.
5184
f7ff1b0f 51852011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5186
5187 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5188
639c109b
TZ
51892011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5190
5191 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5192 `gnutls_certificate_set_x509_key_file'.
5193
d2127135
JB
51942011-05-05 Juanma Barranquero <lekktu@gmail.com>
5195
5196 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5197 Update dependencies.
5198
e968f4f3
JB
51992011-05-04 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5202 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5203 Remove unused parameter `fildes'.
5204 * process.c (read_process_output, send_process): Don't pass it.
5205
84d358f0
JB
52062011-05-04 Juanma Barranquero <lekktu@gmail.com>
5207
5208 Fix previous change: the library cache is defined in w32.c.
5209 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5210 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5211
0898ca10
JB
52122011-05-04 Juanma Barranquero <lekktu@gmail.com>
5213
5214 Implement dynamic loading of GnuTLS on Windows.
5215
5216 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5217 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5218 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5219 Declare.
5220
5221 * gnutls.c (Qgnutls_dll): Define.
5222 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5223 (gnutls_*): Declare function pointers.
5224 (init_gnutls_functions): New function to initialize function pointers.
5225 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5226 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5227 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5228 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5229 (emacs_gnutls_write, emacs_gnutls_read)
5230 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5231 (Fgnutls_available_p): New function.
5232 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5233 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5234 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5235
5236 * image.c: Include w32.h.
5237 (Vimage_type_cache): Delete.
5238 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5239 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5240 (w32_delayed_load): Move to w32.c.
5241
5242 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5243
5244 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5245 (w32_delayed_load): Move from image.c. When loading a library, record
5246 its filename in the :loaded-from property of the library id.
5247 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5248 Initialize and staticpro them.
5249 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5250
5251 * process.c: Include lisp.h before w32.h, not after.
5252 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5253 instead of gnutls_record_check_pending.
5254
5255 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5256
ff4de4aa
TZ
52572011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5258
5259 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5260 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5261 as passed in.
5262
abe95abb
JD
52632011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5264
5265 * xterm.c (x_set_frame_alpha): Do not set property on anything
5266 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5267
e16e55d4
JB
52682011-05-02 Juanma Barranquero <lekktu@gmail.com>
5269
5270 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5271
bafcf6a5
JB
52722011-05-02 Juanma Barranquero <lekktu@gmail.com>
5273
5274 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5275 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5276 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5277 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5278 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5279 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5280 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5281 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5282 (Qgnutls_bootprop_callbacks_verify): Make static.
5283
e7a6747f
AS
52842011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5285
19ed11ba
AS
5286 * callproc.c: Indentation fixup.
5287
e7a6747f 5288 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5289 (wait_for_termination, interruptible_wait_for_termination):
5290 Move after wait_for_termination_1.
e7a6747f 5291
1ef14cb4
LMI
52922011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5293
5294 * sysdep.c (interruptible_wait_for_termination): New function
5295 which is like wait_for_termination, but allows keyboard
5296 interruptions.
5297
5298 * callproc.c (Fcall_process): Add (:file "file") as an option for
5299 the STDOUT buffer.
5300 (Fcall_process_region): Ditto.
5301
330d880c
EZ
53022011-04-30 Eli Zaretskii <eliz@gnu.org>
5303
8db90b73
EZ
5304 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5305 rather than `XVECTOR (FOO)->size'.
5306
330d880c
EZ
5307 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5308 inttypes.h, as a gnulib replacement is used if it not available in
5309 system headers.
5310
15cbd324
EZ
53112011-04-21 Eli Zaretskii <eliz@gnu.org>
5312
5313 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5314 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5315 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5316
5317 * coding.c (coding_alloc_by_realloc): Error out if destination
5318 will grow beyond MOST_POSITIVE_FIXNUM.
5319 (decode_coding_emacs_mule): Abort if there isn't enough place in
5320 charbuf for the composition carryover bytes. Reserve an extra
5321 space for up to 2 characters produced in a loop.
5322 (decode_coding_iso_2022): Abort if there isn't enough place in
5323 charbuf for the composition carryover bytes.
5324
53252011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5326
ae940cca
EZ
5327 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5328 aborting when %lld or %lll format is passed.
5329 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5330 %llo or %llx format is passed. (Bug#8545)
5331
03ab8921
EZ
5332 * window.c (window_scroll_line_based): Use a marker instead of
5333 simple variables to record original value of point. (Bug#7952)
5334
afda1437
EZ
5335 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5336 produced by %s or %c overflows available buffer space. (Bug#8545)
5337
f76dee0c
PE
53382011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5339
5340 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5341 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5342
fdc5744d
JB
53432011-04-28 Juanma Barranquero <lekktu@gmail.com>
5344
5345 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5346
638f053a
JB
53472011-04-28 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * keyboard.c (Qdelayed_warnings_hook): Define.
5350 (command_loop_1): Run `delayed-warnings-hook'
5351 if Vdelayed_warnings_list is non-nil.
5352 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5353 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5354
d178f871
EZ
53552011-04-28 Eli Zaretskii <eliz@gnu.org>
5356
5357 * doprnt.c (doprnt): Don't return value smaller than the buffer
5358 size if the message was truncated. (Bug#8545).
5359
b124fd93
JB
53602011-04-28 Juanma Barranquero <lekktu@gmail.com>
5361
5362 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5363 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5364
e810457d
PE
53652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5366
5367 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5368
ea51cceb
JB
53692011-04-27 Juanma Barranquero <lekktu@gmail.com>
5370
5371 * makefile.w32-in: Update dependencies.
5372
94dcfacf
EZ
53732011-04-27 Eli Zaretskii <eliz@gnu.org>
5374
5375 Improve `doprnt' and its usage. (Bug#8545)
5376 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5377 `format_end'. Remove support for %l as a conversion specifier.
5378 Don't use xrealloc. Improve diagnostics when the %l size modifier
5379 is used. Update the commentary.
5380
5381 * eval.c (verror): Simplify calculation of size_t.
5382
5383 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5384 messages.
5385
f61f41d7
PE
53862011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5387
5388 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5389 change.
5390
96fb4434
PE
53912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5392
5393 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5394 This makes this file independent of the recent pseudovector change.
5395
671875da 53962011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5397
69e9b5a3
PE
5398 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5399
b5f869a7 5400 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5401 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5402 Remove unused local.
c8926152 5403 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5404
841a1577 5405 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5406 GCC 4.6.0 optimizes based on type-based alias analysis.
5407 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5408 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5409 != &v->size, and therefore "v->size = 1; b->size = 2; return
5410 v->size;" must therefore return 1. This assumption is incorrect
5411 for Emacs, since it type-puns struct Lisp_Vector * with many other
5412 types. To fix this problem, this patch adds a new type struct
f904488f 5413 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5414 and pseudovectors, and helps optimizing compilers not get fooled
5415 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5416 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5417 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5418 the size member.
eab3844f
PE
5419 (XSETPVECTYPE): Rewrite in terms of new macro.
5420 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5421 This is a bit clearer, and further avoids the possibility of
5422 undesirable aliasing.
5423 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5424 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5425 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5426 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5427 (ASIZE): Now uses header.size rather than size.
5428 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5429 to avoid the hassle of writing XVECTOR (foo)->header.size.
5430 (struct vectorlike_header): New type.
eab3844f
PE
5431 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5432 object, to help avoid aliasing.
5433 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5434 (SUBRP): Likewise, since Lisp_Subr is a special case.
5435 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5436 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5437 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5438 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5439 changed to be "header.size" and "header.next".
5440 * buffer.h (struct buffer): Likewise.
5441 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5442 * frame.h (struct frame): Likewise.
5443 * process.h (struct Lisp_Process): Likewise.
5444 * termhooks.h (struct terminal): Likewise.
5445 * window.c (struct save_window_data, struct saved_window): Likewise.
5446 * window.h (struct window): Likewise.
5447 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5448 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5449 * buffer.c (init_buffer_once): Likewise.
5450 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5451 special case.
5452 * process.c (Fformat_network_address): Use local var for size,
5453 for brevity.
5454
0df1eac5
PE
5455 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5456
847ab9d1 5457 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5458 * data.c (atof): Remove decl; no longer used or needed.
5459 (digit_to_number): Move to lread.c.
5460 (Fstring_to_number): Use new string_to_number function, to be
5461 consistent with how the Lisp reader treats infinities and NaNs.
5462 Do not assume that floating-point numbers represent EMACS_INT
5463 without losing information; this is not true on most 64-bit hosts.
5464 Avoid double-rounding errors, by insisting on integers when
5465 parsing non-base-10 numbers, as the documentation specifies.
5466 * lisp.h (string_to_number): New decl, replacing ...
5467 (isfloat_string): Remove.
bc0a5c13 5468 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5469 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5470 appears to have been a coding error. Similarly, do not accept
5471 strings like +-1e0 as floating point numbers. Do not report
5472 overflow for integer overflows unless the base is not 10 which
5473 means we have no simple and reliable way to continue.
5474 Break out the floating-point parsing into a new
5475 function string_to_number, so that Fstring_to_number parses
5476 floating point numbers consistently with the Lisp reader.
04f2d78b 5477 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5478 (E_CHAR, EXP_INT): Remove, replacing with ...
5479 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5480 (string_to_number): New function, replacing isfloat_string.
5481 This function checks for valid syntax and produces the resulting
5482 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5483 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5484 so that overflow for non-base-10 numbers is reported only when
5485 there's no portable and simple way to convert to floating point.
452f4150 5486
67769ffc
PE
5487 * textprop.c (set_text_properties_1): Rewrite for clarity,
5488 and to avoid GCC warning about integer overflow.
5489
c20db43f
PE
5490 * intervals.h (struct interval): Use EMACS_INT for members
5491 where EMACS_UINT might cause problems. See
5492 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5493 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5494 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5495 All uses changed.
37aa2f85
PE
5496 (offset_intervals): Tell GCC not to worry about length overflow
5497 when negating a negative length.
c20db43f 5498
2538aa2f
PE
5499 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5500 (overrun_check_free): Likewise.
5501
f2d3008d
PE
5502 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5503 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5504 word size.
5505
ec8df744
PE
5506 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5507 (gnutls_make_error): Rename local to avoid shadowing.
5508 (gnutls_emacs_global_deinit): ifdef out; not used.
5509 (Fgnutls_boot): Use const for pointer to readonly storage.
5510 Comment out unused local. Fix pointer signedness problems.
5511
640ee02d
PE
5512 * lread.c (openp): Don't stuff size_t into an 'int'.
5513 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5514 about possible signed overflow.
5515
6048fb2a
PE
5516 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5517 (GDK_KEY_g): Don't define if already defined.
5518 (xg_prepare_tooltip): Avoid pointer signedness problem.
5519 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5520
fa3c87e1
PE
5521 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5522 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5523
2172544b
PE
5524 * xfns.c (Fx_window_property): Simplify a bit,
5525 to make a bit faster and to avoid GCC 4.6.0 warning.
5526 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5527
9b821a21
PE
5528 * fns.c (internal_equal): Don't assume size_t fits in int.
5529
3c616cfa
PE
5530 * alloc.c (compact_small_strings): Tighten assertion a little.
5531
c2982e87
PE
5532 Replace pEd with more-general pI, and fix some printf arg casts.
5533 * lisp.h (pI): New macro, generalizing old pEd macro to other
5534 conversion specifiers. For example, use "...%"pI"d..." rather
5535 than "...%"pEd"...".
5536 (pEd): Remove. All uses replaced with similar uses of pI.
5537 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5538 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5539 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5540 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5541 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5542 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5543 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5544 64-bit hosts.
5545 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5546 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5547 * print.c (safe_debug_print, print_object): Likewise.
5548 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5549 to int.
6f04d126
PE
5550 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5551 avoiding the 0 flag, which is not portable.
c2982e87
PE
5552 * process.c (Fmake_network_process): Use pI to avoid cast.
5553 * region-cache.c (pp_cache): Likewise.
5554 * xdisp.c (decode_mode_spec): Likewise.
5555 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5556 behavior on 64-bit hosts with printf arg.
6f04d126 5557 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5558 (x_stop_queuing_selection_requests): Likewise.
5559 (x_get_window_property): Don't truncate byte count to an 'int'
5560 when tracing.
0b432f21 5561
5e073ec7
PE
5562 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5563 here, since it parses constructs like leading '-' and spaces,
5564 which are not wanted; and it overflows with large numbers.
5565 Instead, simply match F[0-9]+, which is what is wanted anyway.
5566
36372bf9
PE
5567 * alloc.c: Remove unportable assumptions about struct layout.
5568 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5569 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5570 (allocate_vectorlike, make_pure_vector): Use the new macros,
5571 plus offsetof, to remove unportable assumptions about struct layout.
5572 These assumptions hold on all porting targets that I know of, but
5573 they are not guaranteed, they're easy to remove, and removing them
5574 makes further changes easier.
5575
0b432f21
PE
5576 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5577 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5578 (string_overrun_cookie): Now const. Use initializers that
5579 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5580 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5581 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5582 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5583 multiple of sizeof (EMACS_INT); it need not be, if
5584 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5585 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5586
895009e1
JB
55872011-04-26 Juanma Barranquero <lekktu@gmail.com>
5588
5589 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5590
6a7a1b0b
TZ
55912011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5592
5593 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5594 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5595 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5596
841a1577 55972011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5598
5599 * lisp.h (Qdebug): List symbol.
895009e1 5600 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5601 * keyboard.c (debug-on-event): New variable.
5602 (handle_user_signal): Break into debugger when debug-on-event
5603 matches the current signal symbol.
5604
f2d3ba6f
DN
56052011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5606
5607 * alloc.c (check_sblock, check_string_bytes)
5608 (check_string_free_list): Convert to standard C.
5609
42ce4c63
TZ
56102011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5611
5612 * w32.c (emacs_gnutls_push): Fix typo.
5613
825cd63c
EZ
56142011-04-25 Eli Zaretskii <eliz@gnu.org>
5615
fb11d64d
EZ
5616 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5617 "cast to pointer from integer of different size".
5618
825cd63c
EZ
5619 Improve doprnt and its use in verror. (Bug#8545)
5620 * doprnt.c (doprnt): Document the set of format control sequences
5621 supported by the function. Use SAFE_ALLOCA instead of always
5622 using `alloca'.
5623
5624 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5625 is one byte too soon. Don't use xrealloc; instead xfree and
5626 xmalloc anew.
5627
e061a11b
TZ
56282011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5629
5630 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5631 callbacks stage.
5632
5633 * gnutls.c: Renamed global_initialized to
5634 gnutls_global_initialized. Added internals for the
5635 :verify-hostname-error, :verify-error, and :verify-flags
5636 parameters of `gnutls-boot' and documented those parameters in the
5637 docstring. Start callback support.
9173deec
JB
5638 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5639 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5640 on error. Return error code.
e061a11b
TZ
5641 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5642 (emacs_gnutls_read): Likewise.
5643 (Fgnutls_boot): Return handshake error code.
5644 (emacs_gnutls_handle_error): New function.
5645 (wsaerror_to_errno): Likewise.
5646
5647 * w32.h (emacs_gnutls_pull): Add prototype.
5648 (emacs_gnutls_push): Likewise.
5649
5650 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5651 (emacs_gnutls_push): Likewise.
5652
56532011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5654
5655 * process.c (wait_reading_process_output): Check if GnuTLS
5656 buffered some data internally if no FDs are set for TLS
5657 connections.
5658
5659 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5660 (LIBS): Link to USER_LIBS.
5661 ($(BLD)/gnutls.$(0)): New target.
5662
fa6996bc
EZ
56632011-04-24 Eli Zaretskii <eliz@gnu.org>
5664
eb35682e
EZ
5665 * xdisp.c (handle_single_display_spec): Rename the
5666 display_replaced_before_p argument into display_replaced_p, to
5667 make it consistent with the commentary. Fix typos in the
5668 commentary.
5669
e2ad650c
EZ
5670 * textprop.c (syms_of_textprop): Remove dead code.
5671 (copy_text_properties): Delete obsolete commentary about an
5672 interface that was deleted long ago. Fix typos in the description
5673 of arguments.
5674
1b2de274
EZ
5675 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5676 to changes in oldXMenu/XMenu.h from 2011-04-16.
5677 <menu_help_message, prev_menu_help_message>: Constify.
5678 (IT_menu_make_room): menu->help_text is now `const char **';
5679 adjust.
5680
5681 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5682 to changes in oldXMenu/XMenu.h from 2011-04-16.
5683 (struct XMenu): Declare `help_text' `const char **'.
5684
5685 * xfaces.c <Qunspecified>: Make extern again.
5686
5687 * syntax.c: Include sys/types.h before including regex.h, as
5688 required by Posix.
5689
762b15be
EZ
5690 * doc.c (get_doc_string): Improve the format passed to `error'.
5691
5692 * doprnt.c (doprnt): Improve commentary.
5693
5694 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5695
5696 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5697 them with etags.
5698
f1052e5d
EZ
5699 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5700 changes in globals.h immediately force recompilation.
762b15be
EZ
5701 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5702 $(CURDIR)/s/ms-w32.h.
5703 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5704
fa6996bc
EZ
5705 * character.c (Fchar_direction): Function deleted.
5706 (syms_of_character): Don't defsubr it.
5707 <char-direction-table>: Deleted.
5708
e6c3da20
EZ
57092011-04-23 Eli Zaretskii <eliz@gnu.org>
5710
5711 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5712 * doprnt.c: Include limits.h.
5713 (SIZE_MAX): New macro.
04f2d78b
CB
5714 (doprnt): Return a size_t value. 2nd arg is now size_t.
5715 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5716 Improve overflow protection. Support `l' modifier for integer
5717 conversions. Support %l conversion. Don't assume an EMACS_INT
5718 argument for integer conversions and for %c.
5719
5720 * lisp.h (doprnt): Restore prototype.
5721
5722 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5723 $(SRC)/character.h.
5724
5725 * Makefile.in (base_obj): Add back doprnt.o.
5726
5727 * deps.mk (doprnt.o): Add back prerequisites.
5728 (callint.o): Depend on character.h.
5729
5730 * eval.c (internal_lisp_condition_case): Include the handler
5731 representation in the error message.
5732 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5733 when breaking from the loop.
5734
5735 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5736
5737 * callint.c (Fcall_interactively): When displaying error message
5738 about invalid control letter, pass the character's codepoint, not
5739 a pointer to its multibyte form. Improve display of the character
5740 in octal and display also its hex code.
5741
5742 * character.c (char_string): Use %x to display the (unsigned)
5743 codepoint of an invalid character, to avoid displaying a bogus
5744 negative value.
5745
5746 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5747 `error', not SYMBOL_NAME itself.
5748
5749 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5750 character arguments to `error'.
5751
5752 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5753 to `error' in error message about FINAL_CHAR argument. Make sure
5754 FINAL_CHAR is a character, and use %c when it is passed as
5755 argument to `error'.
5756
4ffd0d6b 57572011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5758
5759 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5760
5761 * w32.c: Include <time.h>.
5762 (sys_localtime): New function.
5763
4ffd0d6b 57642011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5765
5766 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5767
4ffd0d6b 5768 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5769
4ffd0d6b 57702011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5771
4ffd0d6b
GM
5772 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5773 zombies (Bug#8467).
aac0c6e3 5774
04c56954
EZ
57752011-04-19 Eli Zaretskii <eliz@gnu.org>
5776
5777 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5778 gl_state.e_property when gl_state.object is Qt.
5779
5780 * insdel.c (make_gap_larger): Remove limitation of buffer size
5781 to <= INT_MAX.
5782
16a43933
CY
57832011-04-18 Chong Yidong <cyd@stupidchicken.com>
5784
5785 * xdisp.c (lookup_glyphless_char_display)
5786 (produce_glyphless_glyph): Handle cons cell entry in
5787 glyphless-char-display.
5788 (Vglyphless_char_display): Document it.
5789
5790 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5791 glyphless-char-display.
5792
4581706e
CY
57932011-04-17 Chong Yidong <cyd@stupidchicken.com>
5794
5795 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5796
5797 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5798
5799 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5800 definition for no-X builds.
5801
4887c6e2 58022011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5803
fd35b6f9
PE
5804 Static checks with GCC 4.6.0 and non-default toolkits.
5805
5c1ccb01
PE
5806 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5807
006c5daa
PE
5808 * process.c (keyboard_bit_set): Define only if SIGIO.
5809 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5810 (send_process): Repair possible setjmp clobbering.
5811
efc736d3
PE
5812 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5813
4e2fe2e6
PE
5814 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5815
f97334a2
PE
5816 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5817
4e75f29d
PE
5818 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5819 Define only if needed.
5820
90efadd1
PE
5821 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5822 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5823 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5824
3c647824
PE
5825 * dispextern.h (struct redisplay_interface): Rename param
5826 to avoid shadowing.
e264f262 5827 * termhooks.h (struct terminal): Likewise.
761383f4 5828 * xterm.c (xembed_send_message): Likewise.
3c647824 5829
b58c5c4a
PE
5830 * insdel.c (make_gap_smaller): Define only if
5831 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5832
cad59032
PE
5833 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5834 it.
5835
c339dc2e
PE
5836 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5837 so that we aren't warned about unused symbols.
5838
91a3e27b
PE
5839 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5840
399c71d3 5841 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5842
8ffc96f5
PE
5843 * xfns.c (x_real_positions): Mark locals as initialized.
5844
eef9bc79
PE
5845 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5846
098db9dd
PE
5847 * xterm.c: Fix problems found by static analysis with other toolkits.
5848 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5849 (x_dispatch_event): Declare static if USE_GTK, and
5850 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5851 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5852 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5853 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5854 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5855
eb18f6cc
PE
5856 * xmenu.c (menu_help_callback): Pointer type fixes.
5857 Use const pointers when pointing at readonly data. Avoid pointer
5858 signedness clashes.
5859 (FALSE): Remove unused macro.
5860 (update_frame_menubar): Remove unused decl.
5861
1fe72bf8
PE
5862 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5863
60d9e1db
PE
5864 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5865 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5866 (single_menu_item): Rename local to avoid shadowing.
5867
39261c26
PE
5868 * keyboard.c (make_lispy_event): Remove unused local var.
5869
018c5e19
PE
5870 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5871 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5872
63d2b86e
PE
5873 * bitmaps: Change bitmaps from unsigned char back to the X11
5874 compatible char. Avoid the old compiler warnings about
5875 out-of-range initializers by using, for example, '\xab' rather
5876 than 0xab.
5877
aefd87e1
PE
5878 * xgselect.c (xgselect_initialize): Check vs interface
5879 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5880
bf501fb9
PE
5881 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5882
e9829fdf
PE
5883 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5884 to read-only memory.
5885
1086c095
PE
5886 * fns.c (vector): Remove; this old hack is no longer needed.
5887
2baccd04 5888 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5889 Remove unused var.
dde42981 5890 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5891
72391843 5892 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5893
436c16df 5894 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5895 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5896 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5897
92bb796d 5898 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5899 (x_term_init): Remove local to avoid shadowing.
92bb796d 5900
764430a3 5901 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5902
5903 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5904 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5905
d1dfb56c
EZ
59062011-04-16 Eli Zaretskii <eliz@gnu.org>
5907
c4354cb4
EZ
5908 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5909
d1dfb56c
EZ
5910 Fix regex.c, syntax.c and friends for buffers > 2GB.
5911 * syntax.h (struct gl_state_s): Declare character position members
5912 EMACS_INT.
5913
5914 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5915
04f2d78b
CB
5916 * textprop.c (verify_interval_modification, interval_of):
5917 Declare arguments EMACS_INT.
d1dfb56c
EZ
5918
5919 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5920 EMACS_INT.
5921
5922 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5923
5924 * indent.c (Fvertical_motion): Local variable it_start is now
5925 EMACS_INT.
5926
5927 * regex.c (re_match, re_match_2, re_match_2_internal)
5928 (bcmp_translate, regcomp, regexec, print_double_string)
5929 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5930 (re_compile_pattern, re_exec): Declare arguments and local
5931 variables `size_t' and `ssize_t' and return values `regoff_t', as
5932 appropriate.
5933 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5934 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5935 <compile_stack_type>: `size' and `avail' are now `size_t'.
5936
5937 * regex.h <regoff_t>: Use ssize_t, not int.
5938 (re_search, re_search_2, re_match, re_match_2): Arguments that
5939 specify buffer/string position and length are now ssize_t and
5940 size_t. Return type is regoff_t.
5941
613052cd
BK
59422011-04-16 Ben Key <bkey76@gmail.com>
5943
5944 * nsfont.m: Fixed bugs in ns_get_family and
5945 ns_descriptor_to_entity that were caused by using free to
5946 deallocate memory blocks that were allocated by xmalloc (via
5947 xstrdup). This caused Emacs to crash when compiled with
5948 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5949 --enable-checking=xmallocoverrun). xfree is now used to
5950 deallocate these memory blocks.
5951
4170f62f 59522011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5953
71b41406
PE
5954 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5955
9587a89d
PE
5956 emacs_write: Accept and return EMACS_INT for sizes.
5957 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5958 et seq.
5959 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5960 Accept and return EMACS_INT.
5961 (emacs_gnutls_write): Return the number of bytes written on
5962 partial writes.
5963 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5964 (emacs_read, emacs_write): Remove check for negative size, as the
5965 Emacs source code has been audited now.
9587a89d
PE
5966 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5967 (emacs_read, emacs_write): Use it.
273a5f82
PE
5968 * process.c (send_process): Adjust to the new signatures of
5969 emacs_write and emacs_gnutls_write. Do not attempt to store
5970 a byte offset into an 'int'; it might overflow.
9587a89d 5971 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5972
3e047f51
PE
5973 * sound.c: Don't assume sizes fit in 'int'.
5974 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5975 Return EMACS_INT, not int.
3e047f51 5976 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5977 Accept EMACS_INT, not int.
5978 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5979 record read return values.
5980
cc39a9db
BK
59812011-04-15 Ben Key <bkey76@gmail.com>
5982
c9d0ec6d
JB
5983 * keyboard.c (Qundefined): Don't declare static since it is used
5984 in nsfns.m.
5985 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5986 static since they are used in nsfont.m.
cc39a9db 5987
6c60eb9f
SM
59882011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5989
5990 * process.c (Qprocessp): Don't declare static.
5991 * lisp.h (Qprocessp): Declare again.
5992
7990b61a
JB
59932011-04-15 Juanma Barranquero <lekktu@gmail.com>
5994
5995 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5996
5d4cb038
PE
59972011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5998
8bd7b830 5999 Improve C-level modularity by making more things 'static'.
cd64ea1d 6000
e3b27b31
PE
6001 Don't publish debugger-only interfaces to other modules.
6002 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6003 (verify_bytepos, count_markers): Move decls to the only modules
6004 that need them.
6005 * region-cache.h (pp_cache): Likewise.
6006 * window.h (check_all_windows): Likewise.
6007 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6008
5d4cb038
PE
6009 * sysdep.c (croak): Now static, if
6010 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6011 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6012
6013 * alloc.c (refill_memory_reserve): Now static if
6014 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6015 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6016
e87b6180
PE
6017 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6018 Define only if USE_LUCID.
6019
ac64929e
PE
6020 * xrdb.c (x_customization_string, x_rm_string): Now static.
6021
6f37259d
PE
6022 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6023 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6024
1683e3ab
PE
6025 * xdisp.c (draw_row_with_mouse_face): Now static.
6026 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6027
de9c2632
PE
6028 * window.h (check_all_windows): Mark externally visible.
6029
2b96acb7
PE
6030 * window.c (window_deletion_count): Now static.
6031
6032 * undo.c: Make symbols static if they're not exported.
6033 (last_undo_buffer, last_boundary_position, pending_boundary):
6034 Now static.
6035
50436f33
PE
6036 * textprop.c (interval_insert_behind_hooks): Now static.
6037 (interval_insert_in_front_hooks): Likewise.
6038
64520e5c
PE
6039 * term.c: Make symbols static if they're not exported.
6040 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6041 (max_frame_lines, tty_set_terminal_modes):
6042 (tty_reset_terminal_modes, tty_turn_off_highlight):
6043 (get_tty_terminal): Now static.
6044 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6045 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6046 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6047 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6048 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6049
1fa53021
PE
6050 * sysdep.c: Make symbols static if they're not exported.
6051 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6052 Now static.
6053 (sigprocmask_set, full_mask): Remove; unused.
6054 (wait_debugging): Mark as visible.
6055 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6056 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6057
d4b43b22
PE
6058 * syntax.c (syntax_temp): Define only if !__GNUC__.
6059
b7c513d0
PE
6060 * sound.c (current_sound_device, current_sound): Now static.
6061
989b29ad
PE
6062 * search.c (searchbufs, searchbuf_head): Now static.
6063
13a55a78
PE
6064 * scroll.c (scroll_cost): Remove; unused.
6065 * dispextern.h (scroll_cost): Remove decl.
6066
de68a1fc
PE
6067 * region-cache.h (pp_cache): Mark as externally visible.
6068
40ccffa6
PE
6069 * process.c: Make symbols static if they're not exported.
6070 (process_tick, update_tick, create_process, chan_process):
6071 (Vprocess_alist, proc_buffered_char, datagram_access):
6072 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6073 (deactivate_process): Mark defn as static, as well as decl.
6074 * lisp.h (create_process): Remove decl.
6075 * process.h (chan_process, Vprocess_alist): Remove decls.
6076
ad64fc97
PE
6077 * print.c: Make symbols static if they're not exported.
6078 (print_depth, new_backquote_output, being_printed, print_buffer):
6079 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6080 (print_interval, print_number_index, initial_stderr_stream):
6081 Now static.
6082 * lisp.h (Fprinc): Remove decl.
6083 (debug_output_compilation_hack): Mark as externally visible.
6084
adddb265
PE
6085 * sysdep.c (croak): Move decl from here to syssignal.h.
6086 * syssignal.h (croak): Put it here, so the API can be checked when
6087 'croak' is called from dissociate_if_controlling_tty.
6088
1717ede2
PE
6089 * minibuf.c: Make symbols static if they're not exported.
6090 (minibuf_save_list, choose_minibuf_frame): Now static.
6091 * lisp.h (choose_minibuf_frame): Remove decl.
6092
fa5fb2bc
PE
6093 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6094
1e3890d1
PE
6095 * lread.c: Make symbols static if they're not exported.
6096 (read_objects, initial_obarray, oblookup_last_bucket_number):
6097 Now static.
6098 (make_symbol): Remove; unused.
6099 * lisp.h (initial_obarray, make_symbol): Remove decls.
6100
8a1414fa
PE
6101 * keyboard.c: Make symbols static if they're not exported.
6102 (single_kboard, recent_keys_index, total_keys, recent_keys):
6103 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6104 (this_single_command_key_start, echoing, last_auto_save):
6105 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6106 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6107 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6108 (Vlispy_mouse_stem, double_click_count):
6109 Now static.
6110 (force_auto_save_soon): Define only if SIGDANGER.
6111 (ignore_mouse_drag_p): Now static if
6112 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6113 (print_help): Remove; unused.
6114 (stop_character, last_timer_event): Mark as externally visible.
6115 * keyboard.h (ignore_mouse_drag_p): Declare only if
6116 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6117 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6118 * lisp.h (echoing): Remove decl.
6119 (force_auto_save_soon): Declare only if SIGDANGER.
6120 * xdisp.c (redisplay_window): Simplify code, to make it more
6121 obvious that ignore_mouse_drag_p is not accessed if !defined
6122 USE_GTK && !defined HAVE_NS.
6123
93ea6e8f
PE
6124 * intervals.c: Make symbols static if they're not exported.
6125 (merge_properties_sticky, merge_interval_right, delete_interval):
6126 Now static.
6127 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6128
77382fcc
PE
6129 * insdel.c: Make symbols static if they're not exported.
6130 However, leave prepare_to_modify_buffer alone. It's never
6131 called from outside this function, but that appears to be a bug.
6132 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6133 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6134 (adjust_after_replace_noundo): Remove; unused.
6135 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6136 (signal_before_change): Remove decls.
77382fcc 6137
9306c32e
PE
6138 * indent.c (val_compute_motion, val_vmotion): Now static.
6139
cd44d2eb
PE
6140 * image.c: Make symbols static if they're not exported.
6141 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6142 if USE_GTK.
6143 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6144 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6145
ad9a7a06
PE
6146 * fringe.c (standard_bitmaps): Now static.
6147 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6148
81626931
PE
6149 * frame.c: Make symbols static if they're not exported.
6150 (x_report_frame_params, make_terminal_frame): Now static.
6151 (get_frame_param): Now static, unless HAVE_NS.
6152 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6153 (x_get_resource_string): Remove; not used.
6154 * frame.h (make_terminal_frame, x_report_frame_params):
6155 (x_get_resource_string); Remove decls.
6156 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6157 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6158
239f9db9
PE
6159 * font.c, fontset.c: Make symbols static if they're not exported.
6160 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6161 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6162 * font.c (font_close_object): Now static.
6163 * font.h (font_close_object): Remove.
6164 * fontset.c (FONTSET_OBJLIST): Remove.
6165 (free_realized_fontset) #if-0 the body, which does nothing.
6166 (face_suitable_for_char_p): #if-0, as it's never called.
6167 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6168 * xfaces.c (face_at_string_position):
6169 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6170 since 0 is always ASCII.
6171
dfcf3579
PE
6172 * fns.c (weak_hash_tables): Now static.
6173
5045092b
PE
6174 * fileio.c: Make symbols static if they're not exported.
6175 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6176 (Vwrite_region_annotation_buffers): Now static.
6177
57a96f5c
PE
6178 * eval.c: Make symbols static if they're not exported.
6179 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6180 * lisp.h (backtrace_list): Remove decl.
6181
35f08c38
PE
6182 * emacs.c: Make symbols static if they're not exported.
6183 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6184 (fatal_error_code, fatal_error_signal_hook, standard_args):
6185 Now static.
6186 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6187 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6188 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6189 * lisp.h (fatal_error_signal_hook): Remove decl.
6190 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6191
f44bd759
PE
6192 * editfns.c: Move a (normally-unused) function to its only use.
6193 * editfns.c, lisp.h (get_operating_system_release): Remove.
6194 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6195 worth the hassle of breaking this out.
6196
b532497d
PE
6197 * xterm.c: Make symbols static if they're not exported.
6198 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6199 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6200 (x_destroy_window, x_delete_display):
6201 Now static.
6202 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6203 (x_mouse_leave): Remove; unused.
6204 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6205 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6206 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6207 Remove decls.
6208 (x_mouse_leave): Declare only if WINDOWSNT.
6209 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6210 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6211 USE_X_TOOLKIT.
6212
1675728f
PE
6213 * ftxfont.c: Make symbols static if they're not exported.
6214 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6215 HAVE_FREETYPE.
6216 * font.h (ftxfont_driver): Likewise.
6217
e4cebfca
PE
6218 * xfns.c: Make symbols static if they're not exported.
6219 (x_last_font_name, x_display_info_for_name):
6220 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6221 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6222 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6223 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6224 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6225 (last_show_tip_args): Now static.
6226 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6227 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6228 (x_screen_planes): Remove; unused.
6229 * dispextern.h (x_screen_planes): Remove decl.
6230
5bf46f05
PE
6231 * dispnew.c: Make symbols static if they're not exported.
6232 * dispextern.h (redraw_garbaged_frames, scrolling):
6233 (increment_row_positions): Remove.
6234 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6235 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6236 Now static.
6237 (redraw_garbaged_frames): Remove; unused.
6238
435f4c28
PE
6239 * xfaces.c: Make symbols static if they're not exported.
6240 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6241 Remove decls.
6242 * xterm.h (defined_color): Remove decls.
6243 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6244 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6245 (menu_face_changed_default, defined_color, free_realized_face):
6246 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6247 (ascii_face_of_lisp_face): Remove; unused.
6248
8524aef3
PE
6249 * xdisp.c: Make symbols static if they're not exported.
6250 * dispextern.h (scratch_glyph_row, window_box_edges):
6251 (glyph_to_pixel_coords, set_cursor_from_row):
6252 (get_next_display_element, set_iterator_to_next):
6253 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6254 (show_mouse_face): Remove decls
6255 * frame.h (message_buf_print): Likewise.
6256 * lisp.h (pop_message, set_message, check_point_in_composition):
6257 Likewise.
6258 * xterm.h (set_vertical_scroll_bar): Likewise.
6259 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6260 (message_buf_print, scratch_glyph_row, displayed_buffer):
6261 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6262 (get_next_display_element, show_mouse_face, window_box_edges):
6263 (frame_to_window_pixel_xy, check_point_in_composition):
6264 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6265 (glyph_to_pixel_coords): Remove; unused.
6266
16390cd2
PE
6267 * dired.c (file_name_completion): Now static.
6268
6269 * dbusbind.c (xd_in_read_queued_messages): Now static.
6270
a25f4dfa
PE
6271 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6272 * data.c (circular_list_error): Remove.
6273
14a9c8df
PE
6274 * commands.h (last_point_position, last_point_position_buffer):
6275 (last_point_position_window): Remove decls.
6276 * keyboard.c: Make these variables static.
6277
04f2d78b
CB
6278 * coding.h (coding, code_convert_region, encode_coding_gap):
6279 Remove decls.
74ab6df5
PE
6280 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6281 (iso_code_class, detect_coding, code_convert_region): Now static.
6282 (encode_coding_gap): Remove; unused.
6283
38dfbee1
PE
6284 * chartab.c (chartab_chars, chartab_bits): Now static.
6285
a2cb4e63
PE
6286 * charset.h (charset_iso_8859_1): Remove decl.
6287 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6288 Now static.
6289
127198fd
PE
6290 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6291 * ccl.c (Vccl_program_table): Now static.
6292 (check_ccl_update): Remove; unused.
6293
d85b608f
PE
6294 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6295 * category.h: ... from here.
6296 * category.c (check_category_table, set_category_set): Now static.
6297
31cd66f3
PE
6298 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6299 * lisp.h: Remove these decls.
6300
c358e587
PE
6301 * buffer.c (buffer_count): Remove unused var.
6302
e78aecca
PE
6303 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6304 so that it's not optimized away.
6305 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6306 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6307 exported only to the debugger.
6308
e192d7d3 6309 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6310 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6311
92470028
PE
6312 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6313 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6314 was inaccessible from Lisp.
6315 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6316 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6317
244ed907
PE
6318 alloc.c: Import and export fewer symbols, and remove unused items.
6319 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6320 is defined.
6321 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6322 it's not optimized away by whole-program optimization.
6323 (message_enable_multibyte, free_misc): Remove.
6324 (catchlist, handlerlist, mark_backtrace):
6325 Declare only if BYTE_MARK_STACK.
6326 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6327 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6328 (message_enable_multibyte): Remove decl.
6329 (free_misc, interval_free_list, float_block, float_block_index):
6330 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6331 (cons_free_list, last_marked_index):
6332 Now static.
6333 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6334 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6335 (mark_backtrace): Define only if BYTE_MARK_STACK.
6336 * xdisp.c (message_enable_multibyte): Now static.
6337
61c2b50e 6338 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6339 This makes it easier for human readers (and static analyzers)
6340 to see whether these variables are used from other modules.
6341 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6342 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6343 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6344 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6345 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6346 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6347 * xmenu.c, xselect.c:
6348 Declare Q* vars static if they are not used in other modules.
6349 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6350 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6351 Remove decls of unexported vars.
6352 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6353
95c82688
PE
6354 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6355
16a97296
PE
6356 Make Emacs functions such as Fatom 'static' by default.
6357 This makes it easier for human readers (and static analyzers)
6358 to see whether these functions can be called from other modules.
6359 DEFUN now defines a static function. To make the function external
6360 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6361 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6362 (Finit_image_library):
16a97296
PE
6363 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6364 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6365 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6366 Remove decls, since these functions are now static.
6367 (Funintern, Fget_internal_run_time): New decls, since these functions
6368 were already external.
95c82688 6369
16a97296
PE
6370 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6371 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6372 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6373 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6374 * keyboard.c, keymap.c, lread.c:
6375 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6376 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6377 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6378 Mark functions with DEFUE instead of DEFUN,
6379 if they are used in other modules.
6380 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6381 decls for now-static functions.
6382 * buffer.h (Fdelete_overlay): Remove decl.
6383 * callproc.c (Fgetenv_internal): Mark as internal.
6384 * composite.c (Fremove_list_of_text_properties): Remove decl.
6385 (Fcomposition_get_gstring): New forward static decl.
6386 * composite.h (Fcomposite_get_gstring): Remove decl.
6387 * dired.c (Ffile_attributes): New forward static decl.
6388 * doc.c (Fdocumntation_property): New forward static decl.
6389 * eval.c (Ffetch_bytecode): New forward static decl.
6390 (Funintern): Remove extern decl; now in .h file where it belongs.
6391 * fileio.c (Fmake_symbolic_link): New forward static decl.
6392 * image.c (Finit_image_library): New forward static decl.
6393 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6394 * intervals.h (Fprevious_property_change):
6395 (Fremove_list_of_text_properties): Remove decls.
6396 * keyboard.c (Fthis_command_keys): Remove decl.
6397 (Fcommand_execute): New forward static decl.
6398 * keymap.c (Flookup_key): New forward static decl.
6399 (Fcopy_keymap): Now static.
6400 * keymap.h (Flookup_key): Remove decl.
6401 * process.c (Fget_process): New forward static decl.
6402 (Fprocess_datagram_address): Mark as internal.
6403 * syntax.c (Fsyntax_table_p): New forward static decl.
6404 (skip_chars): Remove duplicate decl.
6405 * textprop.c (Fprevious_property_change): New forward static decl.
6406 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6407 Now internal.
6408 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6409 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6410
785bbd42
PE
6411 * editfns.c (Fformat): Remove unreachable code.
6412
8b913b57
AS
64132011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6414
6415 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6416 change. (Bug#8496)
6417
a6744a35
EZ
64182011-04-13 Eli Zaretskii <eliz@gnu.org>
6419
6420 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6421 when at ZV. (Bug#8487)
6422
e7974947
AS
64232011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6424
baad03f0
AS
6425 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6426 (Bug#8437)
6427 * keyboard.c (parse_tool_bar_item): Likewise.
6428 * sound.c (sound_cleanup, alsa_close): Likewise.
6429 * termcap.c (tgetent): Likewise.
6430 * xfns.c (x_default_font_parameter): Likewise.
6431 * xsettings.c (read_and_apply_settings): Likewise.
6432
e7974947
AS
6433 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6434 (overrun_check_free): Protoize.
6435
28272684
PE
64362011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6437
6438 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6439 since callers should never pass a negative size.
6440 Change the signature to match that of plain 'read' and 'write'; see
6441 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6442 * lisp.h: Update prototypes of emacs_write and emacs_read.
6443
11997c76
EZ
64442011-04-11 Eli Zaretskii <eliz@gnu.org>
6445
6446 * xdisp.c (redisplay_window): Don't try to determine the character
6447 position of the scroll margin if the window start point w->startp
e896f03c 6448 is outside the buffer's accessible region. (Bug#8468)
11997c76 6449
8a2cbd72
EZ
64502011-04-10 Eli Zaretskii <eliz@gnu.org>
6451
6452 Fix write-region and its subroutines for buffers > 2GB.
6453 * fileio.c (a_write, e_write): Modify declaration of arguments and
6454 local variables to support buffers larger than 2GB.
6455 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6456
6457 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6458 argument, local variables, and return value.
6459
6460 * lisp.h: Update prototypes of emacs_write and emacs_read.
6461
6462 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6463
4073e537 64642011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6465
1ebfdcb6
PE
6466 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6467
b2ded58d
PE
6468 Fix more problems found by GCC 4.6.0's static checks.
6469
7d66342c
PE
6470 * xdisp.c (vmessage): Use a better test for character truncation.
6471
bbf47d44
PE
6472 * charset.c (load_charset_map): <, not <=, for optimization,
6473 and to avoid potential problems with integer overflow.
9248994d 6474 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6475 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6476 * editfns.c (Fformat): Likewise.
1e69125e 6477 * syntax.c (skip_chars): Likewise.
3befa583 6478
e3019616
PE
6479 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6480 This also lets GCC 4.6.0 generate slightly better loop code.
6481
becfa255
PE
6482 * callint.c (Fcall_interactively): <, not <=, for optimization.
6483 (Fcall_interactively): Count the number of arguments produced,
6484 not the number of arguments given. This is simpler and lets GCC
6485 4.6.0 generate slightly better code.
6486
dae0cd48
PE
6487 * ftfont.c: Distingish more carefully between FcChar8 and char.
6488 The previous code passed unsigned char * to a functions like
6489 strlen and xstrcasecmp that expect char *, which does not
6490 conform to the C standard.
6491 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6492 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6493 char * when the C standard requires it.
6494
76032d70
PE
6495 * keyboard.c (read_char): Remove unused var.
6496
eb3f1cc8
PE
6497 * eval.c: Port to Windows vsnprintf (Bug#8435).
6498 Include <limits.h>.
6499 (SIZE_MAX): Define if the headers do not.
6500 (verror): Do not give up if vsnprintf returns a negative count.
6501 Instead, grow the buffer. This ports to Windows vsnprintf, which
6502 does not conform to C99. Problem reported by Eli Zaretskii.
6503 Also, simplify the allocation scheme, by avoiding the need for
6504 calling realloc, and removing the ALLOCATED variable.
6505
70476b54
PE
6506 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6507
12020a9e
PE
6508 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6509 But keep the doprint source code for now, as we might revamp it
6510 and use it again (Bug#8435).
ea6c7ae6
PE
6511 * lisp.h (doprnt): Remove.
6512 * Makefile.in (base_obj): Remove doprnt.o.
6513 * deps.mk (doprnt.o): Remove.
6514
5fdb398c
PE
6515 error: Print 32- and 64-bit integers portably (Bug#8435).
6516 Without this change, on typical 64-bit hosts error ("...%d...", N)
6517 was used to print both 32- and 64-bit integers N, which relied on
6518 undefined behavior.
6519 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6520 New macro.
6521 * lisp.h (error, verror): Mark as printf-like functions.
6522 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6523 Report overflow in size calculations when allocating printf buffer.
6524 Do not truncate output string at its first null byte.
6525 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6526 Truncate the output at a character boundary, since vsnprintf does not
6527 do that.
6528 * charset.c (check_iso_charset_parameter): Convert internal
6529 character to string before calling 'error', since %c now has the
6530 printf meaning.
6531 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6532 overflow when computing char to be passed to 'error'. Do not
6533 pass Lisp_Object to 'error'; pass the integer instead.
6534 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6535 formatted with plain %d.
6536
b189fa66
PE
6537 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6538
bff87ef0
PE
6539 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6540
7e2cac20
PE
6541 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6542
ce4d90b5
PE
6543 * xterm.c (x_catch_errors): Remove duplicate declaration.
6544
266c9547
PE
6545 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6546
79c49ad2
PE
6547 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6548
368f4090
JM
65492011-04-10 Jim Meyering <meyering@redhat.com>
6550
6551 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6552 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6553 return ssize_t not "int", and use size_t as the buffer length.
6554 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6555 * gnutls.h: Update declarations.
6556 * process.c (read_process_output): Use ssize_t, to match.
6557 (send_process): Likewise.
6558
a32d4040
CY
65592011-04-09 Chong Yidong <cyd@stupidchicken.com>
6560
6561 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6562
8546720e 65632011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6564
04f2d78b
CB
6565 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6566 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6567
8546720e
GM
6568 * xterm.c (handle_one_xevent):
6569 * xmenu.c (create_and_show_popup_menu):
6570 * xselect.c (x_decline_selection_request)
6571 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6572
0a2f5c1a 65732011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6574
6575 Fix some uses of `int' instead of EMACS_INT.
6576 * search.c (string_match_1, fast_string_match)
6577 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6578 (scan_buffer, find_next_newline_no_quit)
6579 (find_before_next_newline, search_command, Freplace_match)
6580 (Fmatch_data): Make some `int' variables be EMACS_INT.
6581
6582 * xdisp.c (display_count_lines): 3rd argument and return value now
6583 EMACS_INT. All callers changed.
6584 (pint2hrstr): Last argument is now EMACS_INT.
6585
6586 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6587 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6588 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6589 (decode_coding_utf_16, decode_coding_emacs_mule)
6590 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6591 (decode_coding_ccl, decode_coding_charset)
6592 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6593 (decode_coding_iso_2022, decode_coding_emacs_mule)
6594 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6595 <char_offset, last_offset>: Declare EMACS_INT.
6596 (encode_coding_utf_8, encode_coding_utf_16)
6597 (encode_coding_emacs_mule, encode_invocation_designation)
6598 (encode_designation_at_bol, encode_coding_iso_2022)
6599 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6600 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6601 Declare EMACS_INT.
6602 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6603 (encode_invocation_designation): Last argument P_NCHARS is now
6604 EMACS_INT.
6605 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6606 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6607
6608 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6609 All users changed.
6610
6611 * ccl.c (Fccl_execute_on_string): Declare some variables
6612 EMACS_INT.
6613
8546720e 66142011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6615
6616 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6617
4e19a977
CS
66182011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6619
6620 * process.c (Fformat_network_address): Doc fix.
6621
87302331
R
66222011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6623
6624 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6625
cbb59342
CY
66262011-04-08 Chong Yidong <cyd@stupidchicken.com>
6627
6628 * keyboard.c (read_char): Call Lisp function help-form-show,
6629 instead of using internal_with_output_to_temp_buffer.
6630 (Qhelp_form_show): New var.
e0d38eeb 6631 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6632
6633 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6634
6635 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6636
e67a13ab
CY
66372011-04-06 Chong Yidong <cyd@stupidchicken.com>
6638
04f2d78b
CB
6639 * process.c (Flist_processes): Remove to Lisp.
6640 (list_processes_1): Delete.
e67a13ab 6641
973f782d
EZ
66422011-04-06 Eli Zaretskii <eliz@gnu.org>
6643
7c106b1e
EZ
6644 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6645
973f782d
EZ
6646 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6647
41cf7d1a 66482011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6649
ca23cc88
PE
6650 Fix more problems found by GCC 4.6.0's static checks.
6651
f390e2d5
PE
6652 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6653
42eea0d0
PE
6654 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6655
b69769da 6656 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6657
f9541e84
PE
6658 * xdisp.c (vmessage): Mark as a printf-like function.
6659
13841b55
PE
6660 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6661
c136c10f
PE
6662 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6663
5e2d4a30
PE
6664 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6665 printf-like functions.
6666 (tiff_load): Add casts to remove these marks before passing them
6667 to system-supplied API.
6668
583f48b9
PE
6669 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6670
b25d760e
PE
6671 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6672 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6673 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6674 directly, rather than having caller test rule sign. This avoids
6675 some unnecessary tests.
6676 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6677 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6678 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6679
bc7b6697 6680 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6681 (xfont_open): Avoid unnecessary tests.
bc7b6697 6682
27ccc379
PE
6683 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6684
dcd5c89a
PE
6685 * composite.h, composite.c (composition_gstring_put_cache):
6686 Use EMACS_INT, not int, for length.
6687
b13a45c6
PE
6688 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6689 breaking out part of COMPOSITION_DECODE_RULE.
6690 (COMPOSITION_DECODE_RULE): Use it.
6691 * composite.c (get_composition_id): Remove unused local vars,
6692 by using the new macro.
6693
1e792e4d
PE
6694 * textprop.c (set_text_properties_1): Change while to do-while,
6695 since the condition is always true at first.
6696
dc6c6455 6697 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6698 (interval_deletion_adjustment): Return unsigned value.
6699 All uses changed.
dc6c6455 6700
aba7731a
PE
6701 * process.c (list_processes_1, create_pty, read_process_output):
6702 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6703 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6704 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6705 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6706 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6707
fdfc4bf3
PE
6708 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6709
fca8fe46 6710 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6711 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6712
06a0259a 6713 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6714 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6715 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6716
e7b9e80f
PE
6717 * print.c (print_error_message): Avoid int overflow.
6718
56201685
PE
6719 * font.c (font_list_entities): Redo for clarity,
6720 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6721
78834453 6722 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6723 (font_score): Avoid potential overflow in diff calculation.
78834453 6724
0bc0b309 6725 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6726 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6727
e610eaca
PE
6728 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6729
b895abce
PE
6730 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6731 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6732 can always succeed if overflow has undefined behavior.
6733
1f1d9321 6734 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6735 (wordify): Omit three unnecessary tests.
1f1d9321 6736
c59478bc
PE
6737 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6738 All callers changed. This avoids the need for an unused var.
6739
79b73827
PE
6740 * casefiddle.c (casify_region): Remove var that is set but not used.
6741
a4db5dfe
PE
6742 * dired.c (file_name_completion): Remove var that is set but not used.
6743
43aae36e
PE
6744 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6745
2a47c44d 6746 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6747 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6748
a37c69bf
PE
6749 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6750 Check for integer overflow on size calculations.
6751
328ab8e7
PE
6752 * buffer.c (Fprevious_overlay_change): Remove var that is set
6753 but not used.
6754
e5a2a5cb
PE
6755 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6756 Remove vars that are set but not used.
8d84a6eb 6757 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6758 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6759
a60e5f68
PE
6760 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6761
f661cb61 6762 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6763 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6764
f0397f5a
PE
6765 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6766 that are set but not used.
6767
8664db06 6768 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6769 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6770
6abdaa4a
PE
6771 * xselect.c (x_get_local_selection, x_handle_property_notify):
6772 Remove vars that are set but not used.
6773
0ce7538d 6774 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6775 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6776
9ae848fc
PE
6777 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6778 Remove var that is set but not used.
0b918413
PE
6779 (scroll_bar_windows_size): Now size_t, not int.
6780 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6781 Check for overflow.
9ae848fc 6782
a5a62657
PE
6783 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6784 (map_tty_color) [!defined MSDOS]: Likewise.
6785
5c5cdd39
PE
6786 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6787
66ebf983
PE
6788 * coding.c: Remove vars that are set but not used.
6789 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6790 All callers changed.
6791 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6792 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6793 (decode_coding_charset): Remove vars that are set but not used.
6794
1be4d761
PE
6795 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6796 that is set but not used.
6797
47553fa8
PE
6798 * print.c (print_object): Remove var that is set but not used.
6799
1f7196bf 6800 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6801 The gnulib version avoids calling malloc in the usual case,
6802 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6803 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6804 * filelock.c (current_lock_owner): Likewise.
6805 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6806 * sysdep.c: Include allocator.h, careadlinkat.h.
6807 (emacs_no_realloc_allocator): New static constant.
6808 (emacs_readlink): New function.
fdb61804
PE
6809 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6810 ../lib/careadlinkat.h.
d1fdcab7 6811
f84c17c7
SM
68122011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6813
6814 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6815 first non-nil return value).
6816
ef3862ad
JD
68172011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6818
6819 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6820 if not defined (Bug#8403).
6821
376a7006
JB
68222011-04-02 Juanma Barranquero <lekktu@gmail.com>
6823
6824 * xdisp.c (display_count_lines): Remove parameter `start',
6825 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6826 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6827 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6828 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6829 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6830 and thereabouts. All callers changed.
6831 (get_per_char_metric): Remove parameter `f', unused since
6832 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6833
6ca3801d
JM
68342011-04-02 Jim Meyering <meyering@redhat.com>
6835
6836 do not dereference NULL upon failed strdup
6837 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6838 (ns_get_family): Likewise.
6839
d8e2b5ba
JB
68402011-04-02 Juanma Barranquero <lekktu@gmail.com>
6841
6842 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6843
8c74fcbd
JD
68442011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6845
6846 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6847 later (Bug#8403).
6848
7200d79c
SM
68492011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6850
03408648 6851 Add lexical binding.
7200d79c 6852
03408648
SM
6853 * window.c (Ftemp_output_buffer_show): New fun.
6854 (Fsave_window_excursion):
6855 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6856
6857 * lread.c (lisp_file_lexically_bound_p): New function.
6858 (Fload): Bind Qlexical_binding.
6859 (readevalloop): Remove `evalfun' arg.
6860 Bind Qinternal_interpreter_environment.
6861 (Feval_buffer): Bind Qlexical_binding.
6862 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6863 Mark as dynamic.
6864 (syms_of_lread): Declare `lexical-binding'.
6865
6866 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6867
6868 * keyboard.c (eval_dyn): New fun.
6869 (menu_item_eval_property): Use it.
ca105506
SM
6870
6871 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6872
03408648
SM
6873 * fns.c (concat, mapcar1): Accept byte-code-functions.
6874
6875 * eval.c (Fsetq): Handle lexical vars.
6876 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6877 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6878 (FletX, Flet): Obey lexical binding.
6879 (Fcommandp): Handle closures.
6880 (Feval): New `lexical' arg.
6881 (eval_sub): New function extracted from Feval. Use it almost
6882 everywhere where Feval was used. Look up vars in lexical env.
6883 Handle closures.
6884 (Ffunctionp): Move from subr.el.
6885 (Ffuncall): Handle closures.
6886 (apply_lambda): Remove `eval_flags'.
6887 (funcall_lambda): Handle closures and new byte-code-functions.
6888 (Fspecial_variable_p): New function.
6889 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6890 but without exporting it to Lisp.
23aba0ea 6891
23aba0ea 6892 * doc.c (Fdocumentation, store_function_docstring):
03408648 6893 * data.c (Finteractive_form): Handle closures.
23aba0ea 6894
03408648
SM
6895 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6896 interactive spec.
ba83908c 6897
04f2d78b
CB
6898 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6899 New byte-codes.
03408648
SM
6900 (exec_byte_code): New function extracted from Fbyte_code to handle new
6901 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6902
03408648 6903 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6904
03408648 6905 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6906
e2abce01
JB
69072011-03-31 Juanma Barranquero <lekktu@gmail.com>
6908
6909 * xdisp.c (redisplay_internal): Fix prototype.
6910
63696a73 69112011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6912
63696a73 6913 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6914 (try_scrolling): Use it when setting scroll_limit.
6915 Limit scrolling to 100 screen lines.
63696a73
EZ
6916 (redisplay_window): Even when falling back on "recentering",
6917 position point in the window according to scroll-conservatively,
6918 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6919
6920 (try_scrolling): When point is above the window, allow searching
6921 as far as scroll_max, or one screenful, to compute vertical
6922 distance from PT to the scroll margin position. This prevents
6923 try_scrolling from unnecessarily failing when
6924 scroll-conservatively is set to a value slightly larger than the
6925 window height. Clean up the case of PT below the margin at bottom
6926 of window: scroll_max can no longer be INT_MAX. When aggressive
6927 scrolling is in use, don't let point enter the opposite scroll
6928 margin as result of the scroll.
6929 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6930 threshold of 100 lines for never-recentering scrolling.
6931
e4cc2dfc
JB
69322011-03-31 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * dispextern.h (move_it_by_lines):
6935 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6936 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6937 (message_log_check_duplicate): Remove parameters `prev_bol' and
6938 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6939 (redisplay_internal): Remove parameter `preserve_echo_area',
6940 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6941
6942 * indent.c (Fvertical_motion):
6943 * window.c (window_scroll_pixel_based, Frecenter):
6944 Don't pass `need_y_p' to `move_it_by_lines'.
6945
1c470562
SM
69462011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6947
44f230aa
SM
6948 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6949 steal a few bits to be more compact.
6950 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6951 Remove unneeded casts.
6952
1c470562
SM
6953 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6954
888adce9
ZK
69552011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6956
6957 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6958 binding" message (bug#7967).
6959
f838ed7b
PE
69602011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6961
77861b95
PE
6962 Fix more problems found by GCC 4.6.0's static checks.
6963
de6dbc14
PE
6964 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6965 Remove unused local var.
6966
f838ed7b
PE
6967 * editfns.c (Fmessage_box): Remove unused local var.
6968
792c7b2b
PE
6969 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6970 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6971 Omit unused local vars.
c499e557 6972 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6973 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6974 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6975 Omit unused local var.
6976
ba0165e1
PE
6977 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6978 Don't assume string length fits in int.
32ad8845 6979 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6980 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6981
3c59b4c9
PE
6982 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6983 instead of alloca (Bug#8344).
6984
a3eed478 6985 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6986 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6987
eb4d412d
PE
6988 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6989
1658b401
PE
6990 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6991 concerns.
6992
6993 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6994
6995 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6996
9a2c6e05
PE
6997 * keyboard.c (syms_of_keyboard): Use the same style as later
6998 in this function when indexing through an array. This also
6999 works around GCC bug 48267.
7000
03d0a109
PE
7001 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7002
44f730c8
PE
7003 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7004
fe75f926
PE
7005 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7006 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7007
ffa8c828
PE
7008 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7009 This avoids undefined behavior on integer overflow, and is a bit
7010 more convenient anyway since it is compared to a size_t variable.
7011
c5101a77
PE
7012 Variadic C functions now count arguments with size_t, not int.
7013 This avoids an unnecessary limitation on 64-bit machines, which
7014 caused (substring ...) to crash on large vectors (Bug#8344).
7015 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7016 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7017 All variadic functions and their callers changed accordingly.
c5101a77
PE
7018 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7019 * data.c (arith_driver, float_arith_driver): Likewise.
7020 * editfns.c (general_insert_function): Likewise.
7021 * eval.c (struct backtrace.nargs, interactive_p)
7022 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7023 (funcall_lambda, mark_backtrace): Likewise.
7024 * fns.c (concat): Likewise.
7025 * frame.c (x_set_frame_parameters): Likewise.
7026 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7027 0 if not found, not -1. All callers changed.
7028
dd3f25f7
PE
7029 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7030 (stack_copy_size): Now size_t, not int.
7031 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7032
461c2ab9
JB
70332011-03-28 Juanma Barranquero <lekktu@gmail.com>
7034
7035 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7036 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7037 All callers changed.
7038
7039 * lisp.h (multibyte_char_to_unibyte):
7040 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7041 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7042 * character.h (CHAR_TO_BYTE8):
7043 * cmds.c (internal_self_insert):
7044 * editfns.c (general_insert_function):
7045 * keymap.c (push_key_description):
7046 * search.c (Freplace_match):
7047 * xdisp.c (message_dolog, set_message_1): All callers changed.
7048
f6d62986
SM
70492011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7050
7051 * keyboard.c (safe_run_hook_funcall): New function.
7052 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7053 don't set the hook to nil, but remove the offending function instead.
7054 (Qcommand_hook_internal): Remove, unused.
7055 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7056 Vcommand_hook_internal.
7057
7058 * eval.c (enum run_hooks_condition): Remove.
7059 (funcall_nil, funcall_not): New functions.
7060 (run_hook_with_args): Call each function through a `funcall' argument.
7061 Remove `cond' argument, now redundant.
7062 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7063 (Frun_hook_with_args_until_failure): Adjust accordingly.
7064 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7065
1db5b1ad
JB
70662011-03-28 Juanma Barranquero <lekktu@gmail.com>
7067
7068 * dispextern.h (string_buffer_position): Remove declaration.
7069
7070 * print.c (strout): Remove parameter `multibyte', unused since
7071 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7072
7073 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7074 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7075 All callers changed.
7076
7077 * w32.c (_wsa_errlist): Use braces for struct initializers.
7078
7079 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7080 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7081 All callers changed.
7082 (string_buffer_position): Likewise. Also, make static (it's never
7083 used outside xdisp.c).
7084 (cursor_row_p): Remove parameter `w', unused since
7085 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7086 (decode_mode_spec): Remove parameter `precision', introduced during
7087 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7088 All callers changed.
7089
5ffb62aa
JD
70902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7091
7092 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7093
461c2ab9 70942011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7095
7096 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7097 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7098 (ns_update_auto_hide_menu_bar): New functions.
7099 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7100 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7101 ns_constrain_all_frames.
7102 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7103 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7104
5c380ffb
JD
71052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7106
7107 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7108
9af30bdf
GM
71092011-03-27 Glenn Morris <rgm@gnu.org>
7110
7111 * syssignal.h: Replace RETSIGTYPE with void.
7112 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7113 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7114 Replace SIGTYPE with void everywhere.
7115 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7116 * s/template.h (SIGTYPE): Remove commented out definition.
7117
e2abce01
JB
71182011-03-26 Eli Zaretskii <eliz@gnu.org>
7119
7120 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7121 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7122
f868cd8a
JB
71232011-03-26 Juanma Barranquero <lekktu@gmail.com>
7124
59eb0929
JB
7125 * w32.c (read_unc_volume): Use parameter `henum', instead of
7126 global variable `wget_enum_handle'.
7127
7128 * keymap.c (describe_vector): Remove parameters `indices' and
7129 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7130 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7131
f868cd8a
JB
7132 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7133
7134 * keyboard.c (timer_check): Remove parameter `do_it_now',
7135 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7136 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7137 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7138
7139 * keyboard.c (read_char):
7140 * w32menu.c (w32_menu_display_help):
7141 * xmenu.c (show_help_event, menu_help_callback):
7142 Adjust calls to `show_help_echo'.
7143
7144 * gtkutil.c (xg_maybe_add_timer):
7145 * keyboard.c (readable_events):
7146 * process.c (wait_reading_process_output):
7147 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7148
7149 * insdel.c (adjust_markers_gap_motion):
7150 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7151 (gap_left, gap_right): Don't call it.
7152
2ecf6fdb
CY
71532011-03-25 Chong Yidong <cyd@stupidchicken.com>
7154
7155 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7156 incurred during fontification.
7157
6b1f9ba4
JB
71582011-03-25 Juanma Barranquero <lekktu@gmail.com>
7159
7160 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7161 (DEFVAR_PER_BUFFER): Don't pass it.
7162
7163 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7164 (scrolling_window): Don't pass it.
7165
0f4a96b5
JB
71662011-03-25 Juanma Barranquero <lekktu@gmail.com>
7167
7168 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7169
7170 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7171 and `suffix'.
7172 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7173 of variables specific to SELinux and computation of `encoded_absname'.
7174
7175 * image.c (XPutPixel): Remove unused variable `height'.
7176
7177 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7178
7179 * unexw32.c (get_section_info): Remove unused variable `section'.
7180
7181 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7182 (system_process_attributes): Remove unused variable `sess'.
7183 (sys_read): Remove unused variable `err'.
7184
7185 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7186 (w32_wnd_proc): Remove unused variable `isdead'.
7187 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7188 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7189 (x_create_tip_frame): Remove unused variable `tem'.
7190
7191 * w32inevt.c (w32_console_read_socket):
7192 Remove unused variable `no_events'.
7193
7194 * w32term.c (x_draw_composite_glyph_string_foreground):
7195 Remove unused variable `width'.
7196
1149507c
JB
71972011-03-24 Juanma Barranquero <lekktu@gmail.com>
7198
7199 * w32term.c (x_set_glyph_string_clipping):
7200 Don't pass uninitialized region to CombineRgn.
7201
9c88f339
JB
72022011-03-23 Juanma Barranquero <lekktu@gmail.com>
7203
7204 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7205 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7206 (Fx_close_connection): Remove unused variable `i'.
7207
7208 * w32font.c (w32font_draw): Return number of glyphs.
7209 (w32font_open_internal): Remove unused variable `i'.
7210 (w32font_driver): Add missing initializer.
7211
7212 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7213 (fill_in_menu): Remove unused variable `items_added'.
7214
7215 * w32term.c (last_mouse_press_frame): Remove static global variable.
7216 (w32_clip_to_row): Remove unused variable `f'.
7217 (x_delete_terminal): Remove unused variable `i'.
7218
7219 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7220 (NOTHING): Remove unused static global variable.
7221 (uniscribe_check_otf): Remove unused variable `table'.
7222 (uniscribe_font_driver): Add missing initializers.
7223
dee091a3
JD
72242011-03-23 Julien Danjou <julien@danjou.info>
7225
7226 * term.c (Fsuspend_tty, Fresume_tty):
7227 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7228 * window.c (temp_output_buffer_show):
7229 * insdel.c (signal_before_change):
7230 * frame.c (Fhandle_switch_frame):
7231 * fileio.c (Fdo_auto_save):
7232 * emacs.c (Fkill_emacs):
7233 * editfns.c (save_excursion_restore):
7234 * cmds.c (internal_self_insert):
7235 * callint.c (Fcall_interactively):
7236 * buffer.c (Fkill_all_local_variables):
7237 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7238 Use Frun_hooks.
0f4a96b5 7239 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7240 unconditionnaly since it does the check itself.
7241
2c520ab5 72422011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7243
c9c49752
PE
7244 Fix more problems found by GCC 4.5.2's static checks.
7245
8abc3f12
PE
7246 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7247 the first time through the loop, since we know p0 < p1 then.
7248 This also avoids a gcc -Wstrict-overflow warning.
7249
a2d26660
PE
7250 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7251 leading to a memory leak, possible in functions like
7252 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7253 of objects (Bug#8318).
a2d26660 7254
916c72e9
PE
7255 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7256 that could (at least in theory) be that large.
7257
19ab8a18
PE
7258 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7259 This is less likely to overflow, and avoids undefined behavior if
7260 overflow does occur. All callers changed. Use strtoul to scan
7261 for the unsigned long integer.
b7cbbd6f
PE
7262 (pint2hrstr): Simplify and tune code slightly.
7263 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7264
f0641eff
PE
7265 * scroll.c (do_scrolling): Work around GCC bug 48228.
7266 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7267
7f650bb9
PE
7268 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7269 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7270 (validate_x_resource_name): Simplify count usage.
7271 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7272
37dd57d1
PE
7273 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7274 fail (Bug#8306).
81e56e61 7275
699979fc 7276 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7277
401bf9b4
PE
7278 * process.c (Fmake_network_process): Use socklen_t, not int,
7279 where POSIX says socklen_t is required in portable programs.
7280 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7281 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7282 (Fmake_network_process, server_accept_connection):
7283 (wait_reading_process_output, read_process_output):
7284 Likewise.
7285
b93aacde
PE
7286 * process.c: Rename or move locals to avoid shadowing.
7287 (list_processes_1, Fmake_network_process):
7288 (read_process_output_error_handler, exec_sentinel_error_handler):
7289 Rename or move locals.
4dc343ee 7290 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7291 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7292 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7293 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7294 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7295
af8a867c 7296 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7297 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7298 Include tparam.h instead, since it declares them.
af8a867c
PE
7299 * cm.h (PC): Remove extern decl; tparam.h now does this.
7300 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7301 * terminfo.c: Include tparam.h, to check interfaces.
7302 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7303 (tparam): Adjust signature to match interface in tparam.h;
7304 this removes some undefined behavior. Check that outstring and len
7305 are zero, which they always are with Emacs.
7306 * tparam.h (PC, BC, UP): New extern decls.
7307
0248044d 7308 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7309 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7310
8ff096c1 7311 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7312 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7313 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7314 (ftfont_list): Remove unused local.
49eaafba
PE
7315 (get_adstyle_property, ftfont_pattern_entity):
7316 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7317 Rename locals to avoid shadowing.
8ff096c1 7318
e2be39f6
PE
7319 * xfont.c (xfont_list_family): Mark var as initialized.
7320
c9735e30
PE
7321 * xml.c (make_dom): Now static.
7322
8f5201ae
PE
7323 * composite.c (composition_compute_stop_pos): Rename local to
7324 avoid shadowing.
b246f932
PE
7325 (composition_reseat_it): Remove unused locals.
7326 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7327 (composition_update_it): Mark var as initialized.
11b61122
PE
7328 (find_automatic_composition): Mark vars as initialized,
7329 with a FIXME (Bug#8290).
8f5201ae 7330
760fbc2c
PE
7331 character.h: Rename locals to avoid shadowing.
7332 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7333 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7334 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7335 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7336 to avoid shadowing.
7337
ff08eb85
PE
7338 * textprop.c (property_change_between_p): Remove; unused.
7339
fc7bf025
PE
7340 * intervals.c (interval_start_pos): Now static.
7341
235d7abc
PE
7342 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7343
44f230aa
SM
7344 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7345 Rename locals to avoid shadowing.
3e7d6594 7346
50060332
PE
7347 * sound.c (wav_play, au_play, Fplay_sound_internal):
7348 Fix pointer signedness.
d01f234b 7349 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7350 (wav_play): Initialize a variable to 0, to prevent undefined
7351 behavior (Bug#8278).
50060332 7352
c4fc4e30
PE
7353 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7354
918436ed
PE
7355 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7356
c939f91b
PE
7357 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7358 clobbering (Bug#8298).
b9c7f648
PE
7359 * sysdep.c (sys_subshell): Likewise.
7360 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7361
6bd8c144
PE
7362 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7363 This should get cleaned up, so that child_setup has the
7364 same signature on all platforms.
7365
7710357c 7366 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7367 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7368
c59da222
CY
73692011-03-22 Chong Yidong <cyd@stupidchicken.com>
7370
7371 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7372 not to be necessary, and produces flickering.
7373
66b87493
GM
73742011-03-20 Glenn Morris <rgm@gnu.org>
7375
7376 * config.in: Remove file.
7377
45b6f6d5
JB
73782011-03-20 Juanma Barranquero <lekktu@gmail.com>
7379
7380 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7381 are now in src/globals.h.
7382 (syms_of_minibuf): Remove spurious & from previous change.
7383
3ec03f7e
LL
73842011-03-20 Leo <sdl.web@gmail.com>
7385
7386 * minibuf.c (completing-read-function): New variable.
7387 (completing-read-default): Rename from completing-read.
7388 (completing-read): Call completing-read-function.
7389
b14e3e21
CY
73902011-03-19 Juanma Barranquero <lekktu@gmail.com>
7391
7392 * xfaces.c (Fx_load_color_file):
7393 Read color file from absolute filename (bug#8250).
7394
f2b726e6
JB
73952011-03-19 Juanma Barranquero <lekktu@gmail.com>
7396
7397 * makefile.w32-in: Update dependencies.
7398
09f6ff02
EZ
73992011-03-17 Eli Zaretskii <eliz@gnu.org>
7400
7401 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7402
29a6015a
PE
74032011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7404
a3a6c54e
PE
7405 Fix more problems found by GCC 4.5.2's static checks.
7406
b766f867
PE
7407 * process.c (make_serial_process_unwind, send_process_trap):
7408 (sigchld_handler): Now static.
7409
be02381c
PE
7410 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7411 That way, the code declares only the vars that it needs.
7412 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7413 * s/cygwin.h (PTY_ITERATION): Likewise.
7414 * s/darwin.h (PTY_ITERATION): Likewise.
7415 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7416
57048744
PE
7417 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7418 * process.c (allocate_pty): Don't declare stb unless it's needed.
7419
7914961c 7420 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7421 (CONSTANTLIM): Remove; unused.
7422 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7423 Define only if needed.
7914961c 7424
b3967b18
PE
7425 * unexelf.c (unexec): Name an expression,
7426 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7427 Use a different way to cause a compilation error if anyone uses
7428 n rather than nn, a way that does not involve shadowing.
73366a00 7429 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7430
29a6015a
PE
7431 * deps.mk (unexalpha.o): Remove; unused.
7432
43cfc33e 7433 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7434 * unexec.h: New file.
ce701a33
PE
7435 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7436 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7437 Depend on unexec.h.
7438 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7439 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7440 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7441 Change as necessary to match prototype in unexec.h.
ce701a33 7442
01f44d5a
PE
7443 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7444 shadowing.
4f63c6bb 7445 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7446
a6670b0b
PE
7447 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7448 Rename locals to avoid shadowing.
7449
cef2010d 7450 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7451 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7452
d4d7173a
PE
7453 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7454
f08b802a
PE
7455 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7456 warning when compiling print.c.
7457
3ddb0639
PE
7458 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7459 instead of using an uninitialized var.
5ad03b97 7460 (font_sort_entities): Mark var as initialized.
3ddb0639 7461
170a2692
PE
7462 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7463
e663c700
PE
7464 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7465 pointers to constants.
89bc529a 7466 (font_parse_fcname): Remove unused vars.
7b81e2d0 7467 (font_delete_unmatched): Now static.
ea838e10 7468 (font_get_spec): Remove; unused.
13a547c6
PE
7469 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7470 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7471 Rename or move locals to avoid shadowing.
e663c700 7472
2a80c887 7473 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7474 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7475
1384fa33 7476 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7477 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7478
8b2c52e9
PE
7479 * alloc.c (mark_backtrace): Move decl from here ...
7480 * lisp.h: ... to here, so that it can be checked.
7481
475545b5 7482 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7483 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7484 (lisp_indirect_variable): Name an expression,
7485 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7486 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7487
b1349114 7488 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7489 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7490 Use const pointer when appropriate.
b1349114 7491
a2928364
PE
7492 * lisp.h (get_system_name, get_operating_system_release):
7493 Move decls here, to check interfaces.
7494 * process.c (get_operating_system_release): Move decl to lisp.h.
7495 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7496 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7497 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7498 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7499 (Fformat_time_string, Fencode_time, Finsert_char):
7500 (Ftranslate_region_internal, Fformat):
7501 Rename or remove local vars to avoid shadowing.
9710023e 7502 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7503
a415e694
PE
7504 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7505 avoid shadowing.
7506
8ef4622d
PE
7507 * lisp.h (eassert): Check that the argument compiles, even if
7508 ENABLE_CHECKING is not defined.
7509
946f9a5b
PE
7510 * data.c (Findirect_variable): Name an expression, to avoid
7511 gcc -Wbad-function-cast warning.
112396d6 7512 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7513 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7514 (Fmake_variable_buffer_local, Fmake_local_variable):
7515 Mark variables as initialized.
52746918 7516 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7517
e5aab7e7 7518 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7519 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7520 Rename locals to avoid shadowing.
dff45157
PE
7521 (mark_stack): Move local variables into the #ifdef region where
7522 they're used.
7bc26fdb
PE
7523 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7524 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7525 needed otherwise.
7526 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7527 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7528 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7529
e5aab7e7
PE
7530 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7531 avoids undefined behavior in theory.
7532
4da60324
PE
7533 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7534
88043301
PE
7535 Use functions, not macros, for up- and down-casing (Bug#8254).
7536 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7537 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7538 to use the following functions instead of these macros.
7539 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7540 EMACS_INT, since callers assume the returned value fits in int.
7541 (upcase1): Likewise, for UPCASE_TABLE.
7542 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7543 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7544 the race-condition problem in the old DOWNCASE.
88043301 7545
19ed5445
PE
7546 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7547 Rename locals to avoid shadowing.
7548 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7549 (regex_compile, re_search_2, re_match_2_internal):
7550 Remove unused local vars.
952db0d7
PE
7551 (FREE_VAR): Rewrite so as not to use empty "else",
7552 which gcc can warn about.
da053e48 7553 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7554 (RETALLOC_IF): Define only if needed.
7555 (WORDCHAR_P): Likewise. This one is never needed, but is used
7556 only in a comment talking about a compiler bug, so put inside
7557 the #if 0 of that comment.
7558 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7559 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7560 Remove; unused.
19ed5445 7561
1f3561e4 7562 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7563 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7564 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7565
ded6f8f7
PE
7566 * search.c (simple_search): Remove unused var.
7567
dbd37a95
PE
7568 * dired.c (compile_pattern): Move decl from here ...
7569 * lisp.h: ... to here, so that it can be checked.
7570 (struct re_registers): New forward decl.
7571
7e47afad
PE
7572 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7573
85f24f61
PE
7574 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7575 All uses changed.
7576 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7577 Rename locals to avoid shadowing.
5671df8f 7578 (Fvertical_motion): Mark locals as initialized.
85f24f61 7579
181aa2be 7580 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7581 (casify_region): Mark local as initialized.
181aa2be 7582
930d429c
PE
7583 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7584
7082eac6
PE
7585 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7586 New macros, so that the caller can use some names other than
7587 gcpro1, gcpro2, etc.
7588 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7589 of the new macros.
7590 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7591 argument, for consistency with GCPRO2_VAR, etc: it is now the
7592 prefix of the variable, not the variable itself. All uses
7593 changed.
38b2c076
PE
7594 * dired.c (directory_files_internal, file_name_completion):
7595 Rename locals to avoid shadowing.
7596
15206ed9
PE
7597 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7598 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7599 dired.c's scmp function, had undefined behavior.
7600 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7601 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7602 * buffer.h: ... to here, because these macros use current_buffer,
7603 and the new implementation with inline functions needs to have
7604 current_buffer in scope now, rather than later when the macros
7605 are used.
7606 (downcase, upcase1): New static inline functions.
7607 (DOWNCASE, UPCASE1): Reimplement using these functions.
7608 This avoids undefined behavior in expressions like
7609 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7610 from race conditions in accessing the global variables
7611 case_temp1 and case_temp2.
7612 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7613 * lisp.h (case_temp1, case_temp2): Remove their decls.
7614 * character.h (ASCII_CHAR_P): Move from here ...
7615 * lisp.h: ... to here, so that the inline functions mentioned
7616 above can use them.
7617
4a6bea26
PE
7618 * dired.c (directory_files_internal_unwind): Now static.
7619
f14b7e14
PE
7620 * fileio.c (file_name_as_directory, directory_file_name):
7621 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7622 Now static.
2893f146
PE
7623 (file_name_as_directory): Use const pointers when appropriate.
7624 (Fexpand_file_name): Likewise. In particular, newdir might
7625 point at constant storage, so make it a const pointer.
fd4ead52 7626 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7627 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7628 signedness issues.
f839df0c
PE
7629 (Fset_file_times, Finsert_file_contents, auto_save_error):
7630 Rename locals to avoid shadowing.
f14b7e14 7631
5716756e 7632 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7633 (Ftry_completion, Fall_completions): Rename or remove locals
7634 to avoid shadowing.
5716756e 7635
b4c3046a
PE
7636 * marker.c (bytepos_to_charpos): Remove; unused.
7637
b45db522
PE
7638 * lisp.h (verify_bytepos, count_markers): New decls,
7639 so that gcc does not warn that these functions aren't declared.
7640
85876d07
PE
7641 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7642 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7643 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7644 (copy_text): Remove unused local var.
85876d07 7645
03d78a21 7646 * filelock.c (within_one_second): Now static.
b3dd38ab 7647 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7648
5df8f01b
PE
7649 * buffer.c (fix_overlays_before): Mark locals as initialized.
7650 (fix_start_end_in_overlays): Likewise. This function should be
7651 simplified by using pointers-to-pointers, but that's a different
7652 matter.
b1d876f1 7653 (switch_to_buffer_1): Now static.
8f54f30a
PE
7654 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7655 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7656
a70072c9 7657 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7658 Fix pointer signedness issue.
edced198
PE
7659 (sys_subshell): Mark local as volatile if checking for lint,
7660 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7661 (MAXPATHLEN): Define only if needed.
a70072c9 7662
a0977c44
PE
7663 * process.c (serial_open, serial_configure): Move decls from here ...
7664 * systty.h: ... to here, so that they can be checked.
7665
a884fdcc
PE
7666 * fns.c (get_random, seed_random): Move extern decls from here ...
7667 * lisp.h: ... to here, so that they can be checked.
7668
604efe86 7669 * sysdep.c (reset_io): Now static.
b8950c94 7670 (wait_for_termination_signal): Remove; unused.
604efe86 7671
38fc62d9
PE
7672 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7673 (copy_keymap_item, append_key, push_text_char_description):
7674 Now static.
1004a21a 7675 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7676 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7677 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7678 (describe_map_tree):
7679 Rename locals to avoid shadowing.
38fc62d9 7680
2f2650da
PE
7681 * keyboard.c: Declare functions static if they are not used elsewhere.
7682 (echo_char, echo_dash, cmd_error, top_level_2):
7683 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7684 (read_char, kbd_buffer_get_event, make_lispy_position):
7685 (make_lispy_event, make_lispy_movement, apply_modifiers):
7686 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7687 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7688 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7689 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7690 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7691
a053e86c 7692 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7693 (mark_kboards): Move decl here ...
7694 * alloc.c (mark_kboards): ... from here.
a053e86c 7695
4752793e
PE
7696 * lisp.h (force_auto_save_soon): New decl.
7697
74f10ca7 7698 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7699 (DEFINE_DUMMY_FUNCTION): New macro.
7700 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7701 Use it.
c03cd23f
PE
7702 (main): Add casts to avoid warnings
7703 if GCC considers string literals to be constants.
74f10ca7 7704
022e70d4
PE
7705 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7706
59d6fe83
PE
7707 * dbusbind.c: Pointer signedness fixes.
7708 (xd_signature, xd_append_arg, xd_initialize):
7709 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7710 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7711 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7712 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7713
78320123
PE
7714 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7715 if GCC considers string literals to be constants.
49cebcca 7716 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7717
35ac2a97
SM
77182011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7719
fb103ca9
SM
7720 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7721 (print_preprocess, print_object): New macro to fix last change.
7722
35ac2a97
SM
7723 * print.c (print_preprocess): Don't forget font objects.
7724
62973b41
JB
77252011-03-16 Juanma Barranquero <lekktu@gmail.com>
7726
7727 * emacs.c (USAGE3): Doc fixes.
7728
0e48bb22
AS
77292011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7730
7731 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7732 structure.
7733
7684e57b
JB
77342011-03-14 Juanma Barranquero <lekktu@gmail.com>
7735
7736 * lisp.h (VWindow_system, Qfile_name_history):
7737 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7738 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7739 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7740
7741 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7742 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7743
7744 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7745 * w32console.c (detect_input_pending, read_input_pending)
7746 (encode_terminal_code):
7747 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7748 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7749 (w32_system_caret_y, Qfile_name_history):
7750 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7751 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7752 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7753 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7754 * w32proc.c (Qlocal, report_file_error):
7755 * w32term.c (Vwindow_system, updating_frame):
7756 * w32uniscribe.c (initialized, uniscribe_font_driver):
7757 Remove unneeded extern declarations.
7758
2aa46d6c
CY
77592011-03-14 Chong Yidong <cyd@stupidchicken.com>
7760
c96bbc66 7761 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7762
cffc6f3b
CY
77632011-03-13 Chong Yidong <cyd@stupidchicken.com>
7764
7765 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7766 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7767 These macros can no longer be used for assignment.
7768
44f230aa
SM
7769 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7770 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7771 (record_buffer_markers, fetch_buffer_markers): New functions for
7772 recording and fetching special buffer markers.
7773 (set_buffer_internal_1, set_buffer_temp): Use them.
7774
7775 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7776
7777 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7778
7779 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7780 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7781
7782 * xdisp.c (hscroll_window_tree):
7783 (reconsider_clip_changes): Use PT instead of BUF_PT.
7784
d251f04b
EZ
77852011-03-13 Eli Zaretskii <eliz@gnu.org>
7786
7787 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7788 $(EMACS_ROOT)/lib/intprops.h.
7789
f0c77cd1
PE
77902011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7791
3eca4629
PE
7792 Fix more problems found by GCC 4.5.2's static checks.
7793
7c86ee98
PE
7794 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7795 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7796 (xg_free_frame_widgets): Make it clear that a local variable is
7797 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7798 (gdk_window_get_screen): Make it clear that this macro is needed
7799 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7800 (int_gtk_range_get_value): New function, which avoids a diagnostic
7801 from gcc -Wbad-function-cast.
7802 (xg_set_toolkit_scroll_bar_thumb): Use it.
7803 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7804 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7805 (get_utf8_string, xg_get_file_with_chooser):
7806 Rename locals to avoid shadowing.
7807 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7808
41729b81
PE
7809 * xgselect.c (xg_select): Remove unused var.
7810
f0c77cd1
PE
7811 * image.c (four_corners_best): Mark locals as initialized.
7812 (gif_load): Initialize transparent_p to zero (Bug#8238).
7813 Mark another local as initialized.
ec6cf4c6 7814 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7815
ce0ad53d 7816 * image.c (clear_image_cache): Now static.
d5d5a617 7817 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7818 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7819 (x_edge_detection): Remove unnecessary cast that
7820 gcc -Wbad-function-cast diagnoses.
2037898d 7821 (gif_load): Fix pointer signedness.
6ae141d6
PE
7822 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7823 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7824
33383987 78252011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7826
d32df629
PE
7827 Improve quality of tests for time stamp overflow.
7828 For example, without this patch (encode-time 0 0 0 1 1
7829 1152921504606846976) returns the obviously-bogus value (-948597
7830 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7831 reports time overflow. See
7832 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7833 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7834 * editfns.c: Include limits.h and intprops.h.
7835 (TIME_T_MIN, TIME_T_MAX): New macros.
7836 (time_overflow): Move earlier, to before first use.
7837 (hi_time, lo_time): New functions, for an accurate test for
7838 out-of-range times.
7839 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7840 (Fget_internal_run_time): Don't assume time_t fits in int.
7841 (make_time): Use list2 instead of Fcons twice.
7842 (Fdecode_time): More accurate test for out-of-range times.
7843 (check_tm_member): New function.
7844 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7845 (lisp_time_argument): Don't rely on undefined left-shift and
7846 right-shift behavior when checking for time stamp overflow.
8be6f318 7847
fe31d94c
PE
7848 * editfns.c (time_overflow): New function, refactoring common code.
7849 (Fformat_time_string, Fdecode_time, Fencode_time):
7850 (Fcurrent_time_string): Use it.
7851
8be6f318
PE
7852 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7853 * dired.c (make_time): Move to ...
7854 * editfns.c (make_time): ... here.
7855 * systime.h: Note the move.
7856
09d9db2c 78572011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7858
126bc0dc
YM
7859 * fringe.c (update_window_fringes): Remove unused variables.
7860
c47cbdfd
YM
7861 * unexmacosx.c (copy_data_segment): Also copy __got section.
7862 (Bug#8223)
7863
7ac80be9
EZ
78642011-03-12 Eli Zaretskii <eliz@gnu.org>
7865
c96bbc66 7866 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7867 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7868 Constify `char *' arguments and their references according to
7869 prototypes in tparam.h.
7870
ecb0f94d 7871 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7872
7ac80be9
EZ
7873 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7874 Adapt all references accordingly.
7875
7876 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7877
ef1fd07e
TT
78782011-03-11 Tom Tromey <tromey@redhat.com>
7879
7880 * buffer.c (syms_of_buffer): Remove obsolete comment.
7881
7ef4b50c
EZ
78822011-03-11 Eli Zaretskii <eliz@gnu.org>
7883
7884 * termhooks.h (encode_terminal_code): Declare prototype.
7885
7886 * msdos.c (encode_terminal_code): Don't declare prototype.
7887
7888 * term.c (encode_terminal_code): Now external again, used by
7889 w32console.c and msdos.c.
7890
44f230aa
SM
7891 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7892 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7893
4b1ec863 78942011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7895
1714f52b 7896 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7897
4b1ec863
PE
7898 * fringe.c (update_window_fringes): Mark locals as initialized
7899 (Bug#8227).
7900 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7901
524c7aa6
PE
7902 * alloc.c (mark_fringe_data): Move decl from here ...
7903 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7904 to check its interface.
7905 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7906
a5c0af81 7907 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7908 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7909 (fontset_font): Mark local as initialized.
a9a06e0b 7910 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7911
b4716021
PE
7912 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7913
811e9bac 7914 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7915 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7916 (x_own_selection, Fx_disown_selection_internal): Rename locals
7917 to avoid shadowing.
7918 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7919
7e3ab302
PE
7920 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7921 so that the caller can use some name other than gcpro1.
7922 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7923 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7924 (Fx_backspace_delete_keys_p):
7925 Use them to avoid shadowing, and rename vars to avoid shadowing.
7926 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7927 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7928 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7929 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7930 Remove unused locals.
7e3ab302
PE
7931 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7932 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7933 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7934 macros.
f78faa98 7935
e2b13473
PE
7936 * xterm.h (x_mouse_leave): New decl.
7937
77f23912
PE
7938 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7939 Remove unused functions.
cdf4ba58
PE
7940 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7941 (x_calc_absolute_position): Now static.
7411c686 7942 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7943 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7944 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7945 unless they are used.
38d0b34a
PE
7946 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7947 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7948 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7949 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7950 (x_error_catcher, x_connection_closed, x_error_handler):
7951 (x_error_quitter, xembed_send_message, x_iconify_frame):
7952 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7953 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7954 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7955
44f230aa
SM
7956 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7957 Rename or move locals to avoid shadowing.
6b463e58 7958 (tty_defined_color, merge_face_heights): Now static.
5967d051 7959 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7960 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7961 does not deduce is never used uninitialized.
73719eba
PE
7962 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7963 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7964
426994c3 7965 * terminal.c (store_terminal_param): Now static.
5489860b 7966
032f1620 7967 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7968 (set_frame_menubar): Remove unused local.
d4323972 7969 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7970 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7971 since they might point to immutable storage.
281585b0
PE
7972 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7973 since it's unused otherwise.
032f1620 7974
367c19e5 7975 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7976 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7977 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7978 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7979 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7980 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7981 does not deduce are never used uninitialized.
70739cbe 7982
07b48fa9
PE
7983 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7984
8868a238 7985 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7986 * window.c (window_loop, size_window):
7987 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7988
7e5cf297 7989 * window.c (display_buffer): Now static.
d6550a9f
PE
7990 (size_window): Mark variables that gcc -Wuninitialized
7991 does not deduce are never used uninitialized.
a586633d
PE
7992 * window.h (check_all_windows): New decl, to forestall
7993 gcc -Wmissing-prototypes diagnostic.
5b555da1 7994 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7995
f6095868
PE
7996 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7997 shadowing.
7998 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7999 Include <limits.h>.
8000 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8001 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8002 (load_charset_map): Mark variables that gcc -Wuninitialized
8003 does not deduce are never used uninitialized.
53df7c11 8004 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8005
f38b440c
PE
8006 * coding.c (coding_set_source, coding_set_destination):
8007 Use "else { /* comment */ }" rather than "else /* comment */;"
8008 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8009 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8010 a block, when the outer 'i' will do.
8011 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8012 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8013 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8014 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8015 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8016 Rename locals to avoid shadowing.
8017 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8018 * coding.c (emacs_mule_char, encode_invocation_designation):
8019 Now static, since they're not used elsewhere.
413bb2db 8020 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8021 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8022 (decode_coding_emacs_mule): Mark variables that gcc
8023 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8024 (detect_coding_iso_2022): Initialize a local variable that might
8025 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8026 this initialization is needed. (Bug#8211)
5f58e762
PE
8027 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8028 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8029 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8030 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8031 Remove unused macros.
f38b440c 8032
232b38b9 8033 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8034 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8035 * character.c (string_count_byte8): Likewise.
232b38b9 8036
fb90da1b
PE
8037 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8038 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8039
fb93dbc2
PE
8040 * chartab.c (copy_sub_char_table): Now static, since it's not used
8041 elsewhere.
5c156ace
PE
8042 (sub_char_table_ref_and_range, char_table_ref_and_range):
8043 Rename locals to avoid shadowing.
bbcd0949 8044 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8045
7d3b3862 8046 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8047 (BIDI_BOB): Remove unused macro.
7d3b3862 8048
6be7d3da
PE
8049 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8050 deduce are never used uninitialized.
c2ed9c8b 8051 * term.c (encode_terminal_code): Likewise.
6be7d3da 8052
75f8807f 8053 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8054
50938595
PE
8055 * tparam.h: New file.
8056 * term.c, tparam.h: Include it.
8057 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8058 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8059 Move these decls to tparam.h, and make them agree with what
8060 is actually in tparam.c. The previous trick of using incompatible
8061 decls in different modules does not conform to the C standard.
8062 All callers of tparam changed to use tparam's actual API.
8063 * tparam.c (tparam1, tparam, tgoto):
8064 Use const pointers where appropriate.
8065
fbceeba2
PE
8066 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8067 * cm.h (struct cm): Likewise.
8068 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8069 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8070 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8071 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8072 (turn_on_face, init_tty): Likewise.
8073 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8074
7f3f1250
PE
8075 * term.c (term_mouse_position): Rename local to avoid shadowing.
8076
e6ca6543
PE
8077 * alloc.c (mark_ttys): Move decl from here ...
8078 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8079
c40f8d15
AS
80802011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8081
8082 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8083
cfe0661d
JB
80842011-03-09 Juanma Barranquero <lekktu@gmail.com>
8085
8086 * search.c (compile_pattern_1): Remove argument regp, unused since
8087 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8088 (compile_pattern): Don't pass it.
8089
0afb4571
J
80902011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8091
8092 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8093 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8094 for ! HAVE_GTK3.
8095 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8096
8097 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8098
8099 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8100 gdk_window_get_screen, gdk_window_get_geometry,
8101 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8102 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8103 (xg_get_pixbuf_from_pixmap): New function.
8104 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8105 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8106 Call xg_get_pixbuf_from_pixmap instead of
8107 gdk_pixbuf_get_from_drawable.
8108 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8109 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8110 (xg_check_special_colors): Use GtkStyleContext and its functions
8111 for HAVE_GTK3.
8112 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8113 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8114 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8115 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8116 Call gtk_widget_get_preferred_size.
0afb4571
J
8117 (xg_frame_resized): gdk_window_get_geometry only takes 5
8118 parameters.
44f230aa
SM
8119 (xg_win_to_widget, xg_event_is_for_menubar):
8120 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8121 (xg_set_widget_bg): New function.
8122 (delete_cb): New function.
895009e1 8123 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8124 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8125 (xg_set_background_color): Call xg_set_widget_bg.
8126 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8127 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8128 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8129 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8130 if ! HAVE_GTK3.
8131 (update_frame_tool_bar): Call gtk_widget_hide.
8132 (xg_initialize): Use GDK_KEY_g.
8133
8134 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8135 if ! HAVE_GTK3
8136 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8137
8138 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8139 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8140 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8141
1c2cc4ef
JB
81422011-03-08 Juanma Barranquero <lekktu@gmail.com>
8143
8144 * w32xfns.c (select_palette): Check success of RealizePalette against
8145 GDI_ERROR, not zero.
8146
33383987 8147See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8148
8149;; Local Variables:
8150;; coding: utf-8
aac0c6e3
MR
8151;; End:
8152
33383987 8153 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8154
8155 This file is part of GNU Emacs.
8156
8157 GNU Emacs is free software: you can redistribute it and/or modify
8158 it under the terms of the GNU General Public License as published by
8159 the Free Software Foundation, either version 3 of the License, or
8160 (at your option) any later version.
8161
8162 GNU Emacs is distributed in the hope that it will be useful,
8163 but WITHOUT ANY WARRANTY; without even the implied warranty of
8164 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8165 GNU General Public License for more details.
8166
8167 You should have received a copy of the GNU General Public License
8168 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.