* lisp/vc/vc-mtn.el (vc-mtn-revision-completion-table): Handle completion
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ac4845a6
JD
12012-08-15 Jan Djärv <jan.h.d@swipnet.se>
2
ddee6515
JD
3 * nsmenu.m (popupSession): Remove.
4 (pop_down_menu): Remove endModalSession.
5 (timeout_handler:): New method.
6 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
7 Call runModalForWindow. Check timer_fired when it returns.
8 If not set, cancel timer and break out of loop.
9 Otherwise loop again, with a new timeout.
10
11 * nsterm.m: Include fcntl.h if present.
12 (fd_entry, t_readfds, inNsSelect): Remove.
13 (select_writefds, select_valid, select_timeout, selfds)
14 (select_mutex, apploopnr): Add.
15 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
16 Otherwise call kbd_buffer_store_event.
17 (ns_send_appdefined): Remove release of fd_entry.
18 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
19 Increment and decrement apploopnr.
20 (ns_select): If no file descriptors, just do a NSTimer.
21 Otherwise copy read/write masks and start select thread (fd_handler).
22 Start main loop and wait for application defined event.
23 Inform select thread to stop selecting after main loop is exited.
24 (ns_term_init): Create selfds pipe and set non-blocking.
25 Initialize select_mutex. Start the select thread (fd_handler).
26 (fd_handler:): Loop forever, wait for info from the main thread
27 to either start or stop selecting. When select returns, send
28 and appdefined event.
29 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
30 If not call kbd_buffer_store_event.
31
32 * nsterm.h (EmacsApp): fd_handler takes id argument.
33 (EmacsDialogPanel): Add timer_fired and timeout_handler.
34
ac4845a6
JD
35 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
36
eb424fe3
EZ
372012-08-15 Eli Zaretskii <eliz@gnu.org>
38
39 * region-cache.c (move_cache_gap): Update gap_len using the actual
40 growth of the boundaries array. Do not change cache_len.
41 (Bug#12196)
42
4e6a86c6
DA
432012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
44
45 Generalize and cleanup font subsystem checks.
46 * font.h (FONT_DEBUG, font_assert): Remove.
47 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c: Change
48 font_assert to eassert. Use eassert where appropriate.
49
5bf192ca
DA
502012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
51
52 * gtkutil.c (xg_get_font): Use pango_units_to_double.
53
f2045622
CY
542012-08-15 Chong Yidong <cyd@gnu.org>
55
56 * gtkutil.c (xg_get_font): Rename from xg_get_font_name. When
57 using the new font chooser, use gtk_font_chooser_get_font_desc to
58 extract the font descriptor instead of just the font name. In
59 that case, return a font spec instead of a string.
60 (x_last_font_name): Move to this file from xfns.c.
61
62 * xfns.c (Fx_select_font): The return value can also be a font
63 spec. Move x_last_font_name management to gtkutil.c.
64
65 * xfaces.c: Make font weight and style symbols non-static.
66
7f6feb56
SM
672012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
70 (bug#12117).
71
fecbd8ff
SM
722012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
73
74 * alloc.c (Fgarbage_collect): Use plural form consistently.
75
9b8d5165
EZ
762012-08-14 Eli Zaretskii <eliz@gnu.org>
77
78 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
79 iteration through the command loop. Fixes a problem whereby mouse
80 movements are ignored until the first mouse click.
81
f5d9e83a
PE
822012-08-14 Paul Eggert <eggert@cs.ucla.edu>
83
84 Use bool, not int, for Lisp booleans.
85 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
86 makes Emacs a bit smaller and presumably a bit faster.
87 * lisp.h: Include <stdbool.h>.
88 (struct Lisp_Boolfwd, defvar_bool):
89 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
90 * regex.c [!emacs]: Include <stdbool.h>.
91 (false, true): Remove; <stdbool.h> does this for us now.
92
55802e4a
CY
932012-08-14 Chong Yidong <cyd@gnu.org>
94
4abcdac8
CY
95 * character.c (Fcharacterp): Doc fix (Bug#12076).
96
97 * data.c (Findirect_variable): Doc fix (Bug#11040).
98
55802e4a
CY
99 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
100
101 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 102 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 103
8e99d072
BR
1042012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
105
106 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
107 (bug#12022).
108
08908aca
MR
1092012-08-14 Martin Rudalics <rudalics@gmx.at>
110
111 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
112 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
113 * minibuf.c (choose_minibuf_frame, read_minibuf):
114 * w32fns.c (x_create_tip_frame):
115 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
116 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
117
56120d6f
PE
1182012-08-14 Paul Eggert <eggert@cs.ucla.edu>
119
120 * intervals.c (offset_intervals): Remove obsolete comment.
121
67b77c0b
AS
1222012-08-14 Andreas Schwab <schwab@linux-m68k.org>
123
124 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
125
f48b82fd
GR
1262012-08-14 Gergely Risko <gergely@risko.hu>
127
128 * coding.c (decode_coding): Record buffer modification before
129 disabling undo_list (Bug#11773).
130
fd318b54
DA
1312012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
132
133 Revert and cleanup some recent overlay changes.
134 * buffer.h (enum overlay_type): Remove.
135 (buffer_get_overlays, buffer_set_overlays): Likewise.
136 (buffer_set_overlays_before, buffer_set_overlays_after):
137 New function. Adjust users.
138 (unchain_both): Add eassert.
139
41a62dd9
DA
1402012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
141
142 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
143
5884c324
PE
1442012-08-14 Paul Eggert <eggert@cs.ucla.edu>
145
146 * gtkutil.c (xg_mark_data): Don't assume C99.
147
ca06f160
JD
1482012-08-13 Jan Djärv <jan.h.d@swipnet.se>
149
150 * gtkutil.c (xg_frame_tb_info): New struct.
151 (TB_INFO_KEY): New define.
152 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
153 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
154 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
155 if not present.
156 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
157 is up to date. Otherwise store new data.
158 (free_frame_tool_bar): Free xg_frame_tb_info if present.
159
7864a3f7
DA
1602012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
161
162 Use KSET for write access to Lisp_Object members of struct kboard.
163 * keyboard.h (KSET): New macro.
164 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
165 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
166 * xterm.c: Adjust users.
167
4c31be61
DA
1682012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
169
170 Use BSET for write access to Lisp_Object members of struct buffer.
171 * buffer.h (BSET): New macro.
172 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
173 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
174 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
175 * window.c, xdisp.c, xfns.c: Adjust users.
176
14ae4239
BT
1772012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
178
179 * lread.c (syms_of_lread): Initialize Vlexical_binding.
180
32bcadb4
JD
1812012-08-11 Jan Djärv <jan.h.d@swipnet.se>
182
3d29b2ce
JD
183 * nsterm.m (not_in_argv): New function.
184 (application:openFile, application:openTempFile:):
185 (application:openFileWithoutUI:, application:openFiles:): Open file
186 if not_in_argv returns non-zero (bug#12171).
187
32bcadb4 188 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
189 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
190 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
191 (xg_get_font_name): Use those functions/macros here.
192 Reported by Frans Oilinki <moilinki@gmail.com>.
193
9ff9402d 1942012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
195
196 * unexmacosx.c (copy_data_segment): Copy initialized data in
197 statically linked libraries from input file rather than memory.
198
db74a5fc
YM
199 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
200 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
201 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
202
25e65510
GM
2032012-08-10 Glenn Morris <rgm@gnu.org>
204
205 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
206 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
207
7961135c
DA
2082012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Fix last change to allow compilation with low optimization levels.
211 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
212 Reported by Jan Djärv <jan.h.d@swipnet.se>.
213
42b3a444
DA
2142012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
215
216 Use common inline syntax in intervals.h.
217 * intervals.h (INTERVALS_INLINE): New macro.
218 Change all users from LISP_INLINE.
219
9fb0c957
DA
2202012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Define Qnone once for all platforms.
223 * frame.c (Qnone): Define here.
224 (syms_of_frame): DEFSYM it.
225 * lisp.h (Qnone): New declaration.
226 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
227 * xfns.c: Remove duplication. Adjust users.
228
65e8ee52
DA
2292012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
230
231 Remove unused macros from intervals.h.
232 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
233 * intervals.c: Adjust comment.
234
9b855fd6
EZ
2352012-08-10 Eli Zaretskii <eliz@gnu.org>
236
237 * w32fns.c <w32_unicode_gui>: New static variable.
238 (globals_of_w32fns): Initialize it according to os_subtype.
239 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
240 testing os_subtype.
241
39cb9e56 2422012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
243 Eli Zaretskii <eliz@gnu.org>
244
245 Fix bug #10299 with Unicode characters sent by customized
246 keyboards created by MSKLC.
247 * w32fns.c (INIT_WINDOW_CLASS): New macro.
248 (w32_init_class): Use it to initialize the Emacs class with either
249 ANSI or Unicode API calls.
250 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
251 later.
252 (w32_wnd_proc): If the character code sent by WM_CHAR or
253 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
254 original message. Call DefWindowProcW on NT and later.
255
9374581a
GM
2562012-08-10 Glenn Morris <rgm@gnu.org>
257
4b94e8cf
GM
258 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
259
9374581a
GM
260 * lisp.h (DIRECTORY_SEP): Let configure set it.
261
a2752828
DA
2622012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
263
264 Use TSET for write access to Lisp_Object slots of struct terminal.
265 * termhooks.h (TSET): New macro.
266 * coding.c, terminal.c, xselect.c: Adjust users.
267
cc92c454
SM
2682012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
269
270 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
271 the failing expression, include them in the error message.
272 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
273 * lisp.h (internal_condition_case_n): Update declaration.
274
4cb3e6b3
DA
2752012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Inline functions to examine and change buffer overlays.
278 * buffer.c (unchain_both): New function.
279 * buffer.h (buffer_get_overlays, buffer_set_overlays):
280 (buffer_has_overlays): New function.
281 (enum overlay_type): New enum.
282 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
283 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
284
8707c1e5
DA
2852012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
286
287 Inline functions to examine and change buffer intervals.
288 * alloc.c (mark_interval_tree): Remove.
289 (MARK_INTERVAL_TREE): Simplify.
290 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
291 * intervals.c (buffer_balance_intervals): New function.
292 (graft_intervals_into_buffer): Adjust indentation.
293 (set_intervals_multibyte): Simplify.
294 * buffer.h (BUF_INTERVALS): Remove.
295 (buffer_get_intervals, buffer_set_intervals): New function.
296 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
297 * intervals.c, textprop.c: Adjust users.
298
ad8c997f
DA
2992012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
300
301 Inline functions to examine and change string intervals.
302 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
303 (string_get_intervals, string_set_intervals): New function.
304 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
305 * lread.c, print.c, textprop.c: Adjust users.
306
32ac3a6b
GM
3072012-08-08 Glenn Morris <rgm@gnu.org>
308
309 * lisp.mk (lisp): Remove language/persian.elc.
310
77c7bcb1
DA
3112012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
312
313 Cleanup intervals.
314 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
315 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
316 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
317 Adjust comment. Move under #if 0.
77c7bcb1
DA
318 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
319 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
320
9c08a8d4
DA
3212012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
322
323 Check total length of intervals with eassert.
324 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
325 * intervals.c: Change all users to eassert.
326
26d16b35
EZ
3272012-08-07 Eli Zaretskii <eliz@gnu.org>
328
14ae4239
BT
329 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
330 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
331 INTERNAL_FIELD in Lisp_Cons.
332
c644523b
DA
3332012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
334
335 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
336 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
337 name since all xname users are fixed long time ago. Do not
338 use INTERNAL_FIELD.
339 (set_symbol_name, set_symbol_function, set_symbol_plist):
340 (set_symbol_next, set_overlay_plist): New function.
341 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
342 (struct Lisp_Overlay): Likewise.
343 (CVAR, MVAR, SVAR): Remove.
344 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
345 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
346 * xterm.c: Adjust users.
347 * .gdbinit: Change to use name field of struct Lisp_Symbol
348 where appropriate.
349
6a3d20cc
DA
3502012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Basic functions to set Lisp_Object and pointer slots of intervals.
353 * intervals.h (interval_set_parent, interval_set_object):
354 (interval_set_left, interval_set_right, interval_set_plist):
355 (interval_copy_parent): New function.
356 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
357 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
358 Adjust indentation.
6a3d20cc
DA
359 (INTERVAL_SIZE): Remove. Adjust users.
360 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
361
4d2b044c
DA
3622012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
363
364 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
365 * process.h (PGET): Remove.
366 (struct Lisp_Process): Do not use INTERNAL_FIELD.
367 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
368
d3d50620
DA
3692012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
370
371 Drop WGET and revert read access to Lisp_Objects slots of struct window.
372 * window.h (WGET): Remove.
373 (struct window): Do not use INTERNAL_FIELD.
374 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
375 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
376 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
377 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
378 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
379 Adjust users.
380
d10a51dc
CY
3812012-08-07 Chong Yidong <cyd@gnu.org>
382
383 * window.c (Fwindow_edges, Fwindow_pixel_edges)
384 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
385 (Fdelete_window_internal): Signal an error if the window is not on
386 a live frame (Bug#12025).
387
e69b0960
DA
3882012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
389
390 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
391 * frame.h (FGET): Remove.
392 (struct frame): Do not use INTERNAL_FIELD.
393 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
394 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
395 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
396 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
397
25a20a3a
JB
3982012-08-06 Juanma Barranquero <lekktu@gmail.com>
399
400 * w32.c: Silence compiler warnings.
401 (map_w32_filename): Remove unused variable `is_fat'.
402 (chase_symlinks): Add parentheses around expression.
403
1c6f11f4
GM
4042012-08-06 Glenn Morris <rgm@gnu.org>
405
1db4583a
GM
406 * sysdep.c: Respect BROKEN_GETWD.
407
1c6f11f4
GM
408 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
409 Let configure handle it.
410 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
411
2b90362b
DA
4122012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
413
414 Use GCALIGNMENT where appropriate.
415 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
416 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
417 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
418
5f50daf2
EZ
4192012-08-06 Eli Zaretskii <eliz@gnu.org>
420
14ae4239
BT
421 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
422 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 423
cbcc7007
SM
4242012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
425
426 * buffer.h (struct buffer): Revert `indirections' to a simple int;
427 that should be sufficient for everyone.
428
4d365fa4
JD
4292012-08-06 Jan Djärv <jan.h.d@swipnet.se>
430
431 * keyboard.c (timer_check_2): Add break so timer_check returns next
432 timeout.
433
dd86bd82
DA
4342012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
435
436 Fix Windows build errors introduced after converting to WGET and WSET.
437 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
438 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
439
054e1668
JD
4402012-08-06 Jan Djärv <jan.h.d@swipnet.se>
441
442 * nsterm.m (ns_frame_rehighlight): Use FSET.
443
444 * nsmenu.m (ns_update_menubar): Use FSET.
445
21238f11
DA
4462012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
447
448 Separate read and write access to Lisp_Object slots of Lisp_Process.
449 * process.h (PGET, PSET): New macros similar to AREF and ASET.
450 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
451
077288cf
DA
4522012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
453
454 Separate read and write access to Lisp_Object slots of struct window.
455 * window.h (WGET, WSET): New macros similar to AREF and ASET.
456 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
457 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
458 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
459 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
460 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
461 Adjust users.
462
71688bd7
DA
4632012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
464
465 Fix Windows build errors introduced after converting to FGET and FSET.
466 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
467 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
468 (w32_judge_scroll_bars): Change to use FSET.
469 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
470
f99bac93
DA
4712012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
472
473 Fix replacement typo.
474 * window.c (replace_window): Set root_window instead of
475 selected_window. This fixes a total window subsystem
476 malfunction reported by Bastien Guerry <bzg@gnu.org>.
477
8c2a0f2d
GM
4782012-08-06 Glenn Morris <rgm@gnu.org>
479
480 * lisp.mk (lisp): Add language/persian.elc.
481
edd74c35
DA
4822012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
483
484 Separate read and write access to Lisp_Object slots of struct frame.
485 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
486 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
487 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
488 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
489 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
490
8671676c
AS
4912012-08-05 Andreas Schwab <schwab@linux-m68k.org>
492
493 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
494
663e2b3f
DA
4952012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Generalize common compile-time constants.
498 * lisp.h (header_size, bool_header_size, word_size): Now here.
499 (struct Lisp_Vector): Add comment.
500 (struct Lisp_Bool_Vector): Move up to define handy constants.
501 (VECSIZE, PSEUDOVECSIZE): Simplify.
502 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
503 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
504 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
505 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
506 * xfont.c, xmenu.c: Use word_size where appropriate.
507
d32e47af
LM
5082012-08-05 Lawrence Mitchell <wence@gmx.li>
509
510 * search.c (Freplace_match): Treat \? in the replacement text
511 literally (Bug#8161).
512
e5d9c0d1
CY
5132012-08-05 Chong Yidong <cyd@gnu.org>
514
515 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
516 * frame.c (Vdelete_frame_functions):
517 * emacs.c (Vkill_emacs_hook): Doc fix.
518
8da0576b
EZ
5192012-08-04 Eli Zaretskii <eliz@gnu.org>
520
521 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
522 --with-x-toolkit=no builds.
523 Reported by Carsten Mattner <carstenmattner@gmail.com>.
524
02676e5d
CY
5252012-08-04 Chong Yidong <cyd@gnu.org>
526
527 * syntax.c (Fmodify_syntax_entry): Doc fix.
528
97147da9
EZ
5292012-08-04 Eli Zaretskii <eliz@gnu.org>
530
76151e2c
EZ
531 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
532 * w32.c (init_environment): Change the default values of many
533 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
534 them into environment when they were not already defined.
535 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 536 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
537 (check_windows_init_file): Now external, not static.
538 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
539 called when Vload_path is already set up.
540
541 * w32.h (check_windows_init_file): Add prototype.
542
543 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
544 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
545 compatibility with Posix platforms.
546 (main): Move the call to check_windows_init_file to here from
547 w32.c.
548 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
549 any, in the DEFALT argument into the root of the Emacs build or
550 installation tree, as appropriate.
551
552 * callproc.c (init_callproc_1): Call decode_env_path instead of
553 doing its equivalent by hand.
554 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
555 the code that sets Vexec_path run on MS-Windows.
556
557 * lread.c (init_lread): Add comments to #ifdef's.
558
97147da9
EZ
559 * msdos.c (dos_set_window_size, IT_update_begin)
560 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
561 instead of direct references.
562
185ee146
PE
5632012-08-04 Paul Eggert <eggert@cs.ucla.edu>
564
565 Export DEFAULT_REHASH_* to GDB.
566 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
567 Now constants, not macros.
568
8834c57a
PE
5692012-08-03 Paul Eggert <eggert@cs.ucla.edu>
570
98c6f1e3
PE
571 Remove unnecessary casts involving pointers.
572 These casts are no longer needed now that we assume C89 or later,
573 since they involve casting to or from void *.
574 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
575 (make_pure_float, make_pure_vector):
576 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
577 * macros.c (Fstart_kbd_macro):
578 * menu.c (find_and_return_menu_selection):
579 * minibuf.c (read_minibuf_noninteractive):
580 * sysdep.c (closedir):
581 * xdisp.c (x_produce_glyphs):
582 * xfaces.c (compare_fonts_by_sort_order):
583 * xfns.c (x_real_positions, select_visual):
584 * xselect.c (x_stop_queuing_selection_requests)
585 (x_get_window_property, x_get_window_property_as_lisp_data):
586 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
587 Remove unnecessary pointer casts.
588 * alloc.c (record_xmalloc): New function.
589 * lisp.h (record_xmalloc): New decl.
590 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
591 more like a function. This is because the pointer cast is not
592 needed. All uses changed.
593 * print.c (print_string, print_error_message): Avoid length recalc.
594
8834c57a
PE
595 Improve fix for macroexp crash with debugging (Bug#12118).
596 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
597 ARRAY_MARK_FLAG when checking subscripts, because ASET is
598 not supposed to be invoked from the garbage collector.
599 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
600 (gc_aset): New function, which is like ASET but can be
601 used in the garbage collector.
602 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
603 (set_hash_index): Use it instead of ASET.
604
6dad7178
EZ
6052012-08-03 Eli Zaretskii <eliz@gnu.org>
606
607 Support symlinks on latest versions of MS-Windows.
608 * w32.c: Include winioctl.h and aclapi.h.
609 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
610 (revert_to_self): Forward declarations of static functions.
611 <static BOOL g_b_init_get_security_info>:
612 <g_b_init_create_symbolic_link>: New static flags.
613 (globals_of_w32): Initialize them to zero.
614 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
615 (map_w32_filename): Improve commentary. Simplify switch.
616 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
617 headers (most versions of MinGW w32api don't).
618 (get_security_info, create_symbolic_link)
619 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
620 New functions.
621 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
622 in the argument file name.
623 (sys_access): Call unc_volume_file_attributes only if
624 GetFileAttributes fails with network-related error codes.
625 (sys_rename): Diagnose renaming of a symlink when the user doesn't
626 have the required privileges.
14ae4239 627 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
628 get_file_security_desc.
629 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
630 with addition of handling of symlinks and support for 'lstat'.
631 If possible, get file's attributes and security information by
6dad7178
EZ
632 handle, not by name. Produce S_IFLNK bit for symlinks, when
633 called from 'lstat'.
634 (stat, lstat): New functions, call 'stat_worker'.
635 (symlink, readlink, careadlinkat): Rewritten to create and resolve
636 symlinks when the underlying filesystem supports them.
637
f162bcc3
PE
6382012-08-02 Paul Eggert <eggert@cs.ucla.edu>
639
79ea6c20
PE
640 Fix macroexp crash on Windows with debugging (Bug#12118).
641 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
642 checking subscripts; problem introduced with the recent
643 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
644 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
645 since it's used in non-static inline functions now.
646
c0ce93fd
PE
647 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
648 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 649
f162bcc3
PE
650 Use C99-style 'extern inline' if available.
651 * buffer.h (BUFFER_INLINE):
652 * category.h (CATEGORY_INLINE):
653 * character.h (CHARACTER_INLINE):
654 * charset.h (CHARSET_INLINE):
655 * composite.h (COMPOSITE_INLINE):
656 * dispextern.h (DISPEXTERN_INLINE):
657 * lisp.h (LISP_INLINE):
658 * systime.h (SYSTIME_INLINE):
659 New macro, replacing 'static inline' in this header.
660 * buffer.h, category.h, character.h, charset.h, composite.h:
661 * dispextern.h, lisp.h, systime.h:
662 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
663 * alloc.c (LISP_INLINE):
664 * buffer.c (BUFFER_INLINE):
665 * category.c (CATEGORY_INLINE):
666 * character.c (CHARACTER_INLINE):
667 * charset.c (CHARSET_INLINE):
668 * composite.c (COMPOSITE_INLINE):
669 * dispnew.c (DISPEXTERN_INLINE):
670 * sysdep.c (SYSTIME_INLINE):
671 Define to EXTERN_INLINE, so that the corresponding functions
672 are compiled into code.
673 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
674 (INLINE_HEADER_END): New macros.
675 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
676 since it's used in non-static inline functions now.
a8333d03 677 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 678
837b365b
GM
6792012-08-02 Glenn Morris <rgm@gnu.org>
680
d66b744d
GM
681 * s/: Remove empty directory.
682
837b365b
GM
683 * s/ms-w32.h: Move to ../nt/inc.
684 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
685 Update for new ms-w32.h location.
686
13294f95
PE
6872012-08-02 Paul Eggert <eggert@cs.ucla.edu>
688
689 Port to Solaris 8.
690 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
691
90df0db3
GM
6922012-08-02 Glenn Morris <rgm@gnu.org>
693
694 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
695 hard-coding the path separator.
696
4939150c
PE
6972012-08-01 Paul Eggert <eggert@cs.ucla.edu>
698
699 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
700 This how ASET and AREF are supposed to work, and makes
701 it easier to think about future improvements. See
702 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
703 * charset.h (set_charset_attr): New function.
704 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
705 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
706 (aref_addr): New function. All uses of &AREF(...) changed.
707 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
708 (set_hash_index): New functions. All lvalue-style uses of
709 HASH_KEY etc. changed.
710 * keyboard.c (set_prop): New function. All lvalue-style uses
711 of PROP changed.
712
947b2afd
AA
7132012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
714
715 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
716 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
717 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
718 * nsfns.m (ns_set_name_as_filename): Likewise.
719 * nsmenu.m (ns_update_menubar): Likewise.
720 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
721
4f5d0325
EZ
7222012-08-01 Eli Zaretskii <eliz@gnu.org>
723
2008beae
EZ
724 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
725 Adapt to latest changes in field names of the corresponding Lisp
288479f6 726 objects.
2008beae 727
4f5d0325
EZ
728 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
729
fe3cc771
GM
7302012-08-01 Glenn Morris <rgm@gnu.org>
731
732 * s/msdos.h: Remove file.
733 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
734 * Makefile.in (S_FILE): Remove.
735 (config_h): Remove S_FILE.
736
c90acc54
JB
7372012-08-01 Juanma Barranquero <lekktu@gmail.com>
738
739 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
740 Remove; moved to nt/config.nt.
741
d8a05828
DA
7422012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
743
744 Use INTERNAL_FIELD for conses and overlays.
745 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
746 Remove obsolete comment.
747 (MVAR): New macro.
748 (struct Lisp_Overlay): Use INTERNAL_FIELD.
749 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
750
8271d590
DA
7512012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
752
753 Use INTERNAL_FIELD for symbols.
754 * lisp.h (SVAR): New macro. Adjust users.
755 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
756 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
757
3193acd2
DA
7582012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
759
760 Use INTERNAL_FIELD for processes.
761 * process.h (PVAR): New macro. Adjust style.
762 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
763 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
764
3a45383a
DA
7652012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
766
767 Use INTERNAL_FIELD for windows.
768 * window.h (WVAR): New macro.
769 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
770 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
771 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
772 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
773 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
774 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
775
c1dbc63c
PE
7762012-08-01 Paul Eggert <eggert@cs.ucla.edu>
777
778 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
779
5c0c0e8a
GM
7802012-08-01 Glenn Morris <rgm@gnu.org>
781
782 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
783 Move to configure.ac.
784
552a99b4
JB
7852012-08-01 Juanma Barranquero <lekktu@gmail.com>
786
787 * makefile.w32-in (CONFIG_H): Update dependencies.
788 (CONF_POST_H): New macro.
789
790 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
791
8d8e2dfe
GM
7922012-07-31 Glenn Morris <rgm@gnu.org>
793
bc96620a
GM
794 * Makefile.in (S_FILE): No longer set by configure.
795
476b1b2d
GM
796 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
797 is available.
798 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
799
b2c7a106
GM
800 * process.h (NULL_DEVICE):
801 * emacs.c (SEPCHAR):
802 * editfns.c (USER_FULL_NAME): Let configure set them.
803
d53d062a
GM
804 * s/README, s/template.h: Remove files.
805
4515017f
GM
806 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
807
8d8e2dfe
GM
808 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
809 Move to configure.ac.
810
5b20b3cc
EZ
8112012-07-31 Eli Zaretskii <eliz@gnu.org>
812
1e0afd9a
EZ
813 * .gdbinit (xframe): Adapt to introduction of FVAR and the
814 resulting renaming of 'struct frame' members.
815
5b20b3cc
EZ
816 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
817
818 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
819 after introduction of FVAR.
820
f1310128
JD
8212012-07-31 Jan Djärv <jan.h.d@swipnet.se>
822
79e721e0
JD
823 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
824
825 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
826 instead of compositeToPoint.
827 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
828
8d7c7eed 829 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 830
e34f7f79
DA
8312012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
832
833 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
834 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 835 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
836 (BVAR): Change to use INTERNAL_FIELD.
837 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
838 (KVAR): Change to use INTERNAL_FIELD.
839 * frame.h (FVAR): New macro.
840 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
841 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
842 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
843 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
844 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
845
c09bfb2f
DA
8462012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
847
848 Miscellaneous fixes for non-default X toolkits.
849 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
850 * xterm.c (x_frame_of_widget): Remove redundant prototype.
851 Move under #ifdef USE_LUCID.
852 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
853 definition and usage to avoid warnings.
854
14c114ae
JD
8552012-07-31 Jan Djärv <jan.h.d@swipnet.se>
856
857 * nsterm.m (openFiles): Fix previous checkin.
858
3bd21e82
PE
8592012-07-31 Paul Eggert <eggert@cs.ucla.edu>
860
861 * indent.c (compute_motion): Remove unused local.
862
c1529ded
GM
8632012-07-31 Glenn Morris <rgm@gnu.org>
864
400d5621
GM
865 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
866
268e2432
GM
867 * conf_post.h [USG5_4]:
868 Move remaining contents of s/usg5-4-common.h here.
869 * s/usg5-4-common.h: Remove file.
870
7552f3ee
GM
871 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
872 * s/irix6-5.h: Remove file.
873
6a381852
GM
874 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
875 * s/darwin.h: Remove file.
876
c1529ded
GM
877 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
878 * s/hpux10-20.h: Remove file, which is now empty.
879
b429a4ee
GM
8802012-07-30 Glenn Morris <rgm@gnu.org>
881
882 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
883 * Makefile.in (config_h): Add conf_post.h.
884 * makefile.w32-in (CONFIG_H): Add conf_post.h.
885
adff3182
JD
8862012-07-30 Jan Djärv <jan.h.d@swipnet.se>
887
888 * nsterm.m (ns_do_open_file): New variable.
b9031d69 889 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
890 (openFile, openTempFile, openFileWithoutUI, openFiles):
891 Open files only if ns_do_open_file.
adff3182 892
c32af1e4
PE
8932012-07-30 Paul Eggert <eggert@cs.ucla.edu>
894
7393bcbb
PE
895 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
896 This no-op macro hasn't been needed for many years.
897 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
898
c32af1e4
PE
899 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
900 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
901 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
902 gdb_make_enums_visible.
903 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
904 (DIRECTORY_SEP): Now a constant, not a macro.
905
302fc036
EZ
9062012-07-30 Eli Zaretskii <eliz@gnu.org>
907
908 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
909 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
910
911 * w32term.c <w32_keyboard_codepage>: Renamed from
912 keyboard_codepage and now external. All users changed.
913
914 * w32term.h: Add declaration of w32_keyboard_codepage.
915
916 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
917 the codepage to translate keys to Unicode. If this argument is
918 -1, use the value returned by GetConsoleCP. All callers changed.
919
88fb40b4
PE
9202012-07-30 Paul Eggert <eggert@cs.ucla.edu>
921
0aee6912
PE
922 Update .PHONY listings in makefiles.
923 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
924 bootstrap-clean, distclean, maintainer-clean, versioclean,
925 extraclean, frc.
926
88fb40b4
PE
927 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
928 This is a bit clearer. Fix some commentary typos.
929
0a763bd1
GM
9302012-07-30 Glenn Morris <rgm@gnu.org>
931
32bac6d6
GM
932 * s/netbsd.h: Let configure include signal.h if needed.
933 Remove file, which is now empty.
934
b65e7c46
GM
935 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
936 Let configure set them.
937 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
938 No more need to undefine.
0a763bd1 939
169304bd
AS
9402012-07-30 Andreas Schwab <schwab@linux-m68k.org>
941
942 * keymap.c (Fkey_description): Don't remove 0x80 bit from
943 non-single-byte char when adding meta modifier. (Bug#12090)
944
6cd7a139
DA
9452012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
946
947 Convert safe_call to use variable number of arguments.
948 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
949 (safe_call2): Fix comment.
950 * lisp.h (safe_call): Adjust prototype.
951 * coding.c (encode_coding_object): Change to use safe_call2.
952 * xfaces.c (merge_face_heights): Change to use safe_call1.
953
d34d6ffc
GM
9542012-07-30 Glenn Morris <rgm@gnu.org>
955
7b8a48e4 956 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 957 does that unconditionally. Remove file, which is now empty.
7b8a48e4 958
d34d6ffc
GM
959 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
960 Remove empty files.
961
03a660a6
PE
9622012-07-30 Paul Eggert <eggert@cs.ucla.edu>
963
964 Export to GDB most of lisp.h's remaining object-like macros.
965 * lisp.h (min, max): Move earlier, because they're used earlier now.
966 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
967 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
968 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
969 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
970 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
971 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
972 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
973 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
974 Now constants, for GDB. They need not be macros.
975 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
976 Now constants, for GDB, as well as macros, for static initializers.
977 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
978 Move to after the definition of struct Lisp_Char_Table,
979 since the former now needs that type defined.
980 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
981 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
982 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
983 New enums, for gdb_make_enums_visible.
984 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 985 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
986 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
987 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
988 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
989 enum maxargs, enum MAX_ALLOCA.
990 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
991 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
992 no longer needed, now that they are done in lisp.h.
993
e499d0ee
DA
9942012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
995
996 Cleanup string bytes checking.
997 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
998 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
999 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1000 (check_sblock, compact_small_strings): Simplify.
1001
d5040d2d
PE
10022012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1003
1004 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1005 These macros are confusing and no longer need to be defined, as
1006 the enum values now suffice. All uses replaced with definiens.
1007 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1008
7f259ae6
JB
10092012-07-29 Juanma Barranquero <lekktu@gmail.com>
1010
1011 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1012 ($(BLD)/w32console.$(O)): Update dependencies.
1013
7e63e0c3
DA
10142012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1015
1016 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1017 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1018 time. Adjust users.
1019 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1020
ffd817eb
JD
10212012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1022
1023 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1024 setting sitelisp (Bug#12010).
1025
417a7a0e
EZ
10262012-07-29 Eli Zaretskii <eliz@gnu.org>
1027
14ae4239 1028 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1029
1030 * w32heap.c (cache_system_info):
1031 * w32.c (sys_rename):
1032 * w32proc.c (find_child_console, sys_kill): All users changed.
1033
387d4d92
PE
10342012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1037
55a6cca6
EZ
10382012-07-29 Eli Zaretskii <eliz@gnu.org>
1039
1040 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1041
dbcf001c
DA
10422012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1043
1044 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1045 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1046 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1047
e2688e4a
DA
10482012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1049
1050 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1051 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1052 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1053 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1054 (replace_range, replace_range_2, del_range_2): Change to eassert.
1055 * marker.c (byte_char_debug_check): Adjust style.
1056
b46a6a83
PE
10572012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1060 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1061 long-ago-commented-out code that talks about "WIN32".
1062 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1063 All uses changed.
1064
e32a5799
PE
10652012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1068 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1069 Simplify by using alignof.
1070 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1071 * lisp.h: Include <stdalign.h>.
1072 (GCALIGNMENT): New macro and constant.
1073 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1074 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1075 (stdalign): New macro, if not already defined.
1076
df81cd29
EZ
10772012-07-28 Eli Zaretskii <eliz@gnu.org>
1078
01bd1b0d
EZ
1079 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1080 * w32inevt.c: Include w32inevt.h.
1081 (w32_read_console_input): New inline function, calls either
1082 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1083 w32_console_unicode_input.
1084 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1085 (w32_kbd_patch_key, key_event): Use the codepage returned by
1086 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1087 (key_event): use uChar.UnicodeChar only if
1088 w32_console_unicode_input is non-zero.
1089
1090 * w32console.c: Include w32heap.h.
1091 <w32_console_unicode_input>: New global variable.
1092 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1093 family of Windows, zero otherwise.
1094
1095 * w32inevt.h: Declare w32_console_unicode_input.
1096
df81cd29
EZ
1097 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1098 --without-x. (Bug#11742)
1099
c20fdd9e
PE
11002012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Adjust GDB to reflect pvec_type changes (Bug#12036).
1103 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1104 2012-07-04 changes to pseudovector representation.
1105 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1106
32770973 11072012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1108
1109 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1110 bus address.
1111 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1112
3438fe21
EZ
11132012-07-27 Eli Zaretskii <eliz@gnu.org>
1114
bcfbc9de
EZ
1115 * alloc.c (listn): Fix the order the arguments are consed onto the
1116 list.
1117
3438fe21
EZ
1118 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1119 enumeration constants, as PURE and HEAP are too general, and clash
1120 with other headers and sources, such as gmalloc.c and the
1121 MS-Windows system headers. All users changed.
1122
eeaea515
DA
11232012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1124
1125 Revert last save_excursion_save and save_excursion_restore changes.
1126 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1127 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1128
073c88c2
DA
11292012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1130
1131 Fix recently-introduced typos in Windows port.
1132 Reported by Martin Rudalics <rudalics@gmx.at>.
1133 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1134 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1135
4706125e
PE
11362012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1137
1138 Improve GDB symbol export (Bug#12036).
1139 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1140 arms of an 'if', not using conditional expressions; otherwise GDB
1141 complains about the types in the unevaluated arm when the argument
1142 is an integer literal.
1143 (xgetint): Simplify expression.
1144 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1145 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1146 Zaretskii in <http://bugs.gnu.org/12036#13>.
1147 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1148 needed now that we have gdb_make_enums_visible.
1149 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1150 (enum enum_USE_LSB_TAG):
1151 New enum types, packaging up enums that need to be exported to GDB.
1152
694b6c97
DA
11532012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 Utility function to make a list from specified amount of objects.
1156 * lisp.h (enum constype): New datatype.
1157 (listn): New prototype.
1158 * alloc.c (listn): New function.
1159 (Fmemory_use_count, syms_of_alloc): Use it.
1160 * buffer.c (syms_of_buffer): Likewise.
1161 * callint.c (syms_of_callint): Likewise.
1162 * charset.c (define_charset_internal): Likewise.
1163 * coding.c (syms_of_coding): Likewise.
1164 * keymap.c (syms_of_keymap): Likewise.
1165 * search.c (syms_of_search): Likewise.
1166 * syntax.c (syms_of_syntax): Likewise.
1167 * w32.c (init_environment): Likewise.
1168 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1169 * xdisp.c (syms_of_xdisp): Likewise.
1170 * xfns.c (syms_of_xfns): Likewise.
1171
6195f384
DA
11722012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1173
1174 Fast save_excursion_save and save_excursion_restore.
1175 * lisp.h (struct Lisp_Excursion): New data type.
1176 (PVEC_EXCURSION): New pseudovector type.
1177 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1178 to deal with it. Adjust comments.
1179 (init_marker, attach_marker): New prototype.
1180 (unchain_marker): Adjust prototype.
1181 * marker.c (attach_marker): Change to global.
1182 (init_marker): New function.
1183 * alloc.c (Fmake_marker, build_marker): Use it.
1184 (build_marker): More easserts.
1185 (mark_object): Handle struct Lisp_Excursion.
1186 * editfns.c (save_excursion_save, save_excursion_restore):
1187 Reimplement to use struct Lisp_Excursion. Add comments.
1188
5eceb8fb
PE
11892012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 Fix export of symbols to GDB (Bug#12036).
1192 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1193 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1194 emacs.c, as this is a more-suitable home. Had this been done earlier
1195 the fix for 12036 would have avoided some of the problems noted in
1196 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1197 would have been more obvious.
562157c8
PE
1198 * emacs.c: Do not include <verify.h>; no longer needed.
1199 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1200 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1201 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1202 Remove; now done in lisp.h.
1203 * lisp.h (PUBLISH_TO_GDB): New macro.
1204 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1205 (DATA_SEG_BITS): Use it.
1206 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1207 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1208 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1209 not be usable in #if. This simplifies things.
1210
d6749401
JB
12112012-07-26 Juanma Barranquero <lekktu@gmail.com>
1212
1213 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1214
1781b9e9
PE
12152012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1216
d89518db 1217 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1218 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1219 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1220 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1221 Adjust to changes in lisp.h and emacs.c, by using
1222 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1223 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1224 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1225 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1226 instead of gdb_valbits.
1227 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1228 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1229 instead of gdb_array_mark_flag.
1230 (xboolvector): Get size from $->size, not $->header.size.
1231 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1232 (xreload, hook-run, hookpost-run): Remove.
1233 * emacs.c: Include <verify.h>.
1234 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1235 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1236 Remove.
1237 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1238 (gdb_USE_LSB_TAG): New enum constants.
1239 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1240 Also define these as enum constants, so they're visible to GDB.
1241 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1242 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1243 as constants, so they're visible to GDB.
1244 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1245 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1246 Now enum constants, not macros, so they're visible to GDB.
1247 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1248 more convenient now. All uses changed.
1249 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1250 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1251
3628596a
DA
12522012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 Explicitly free restriction data that are not needed anymore.
1255 * editfns.c (save_restriction_restore): Free restriction data.
1256
7abaf5cc
SM
12572012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1258
1259 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1260 add argument, tune behavior, and adjust all callers.
1261
71f88e00
PE
12622012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Use typedef for EMACS_INT, EMACS_UINT.
1265 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1266 than macros. This simplifies debugging in the usual case, since
1267 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1268 and it allows expressions involving EMACS_INT casts.
1269 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1270
57ec3034
JD
12712012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1272
1273 * nsterm.m (ns_read_socket): Return early if there is a modal
1274 window (Bug#12043).
1275
8137e7b3
MR
12762012-07-25 Martin Rudalics <rudalics@gmx.at>
1277
1278 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1279 that FOCUS-FRAME can be omitted.
1280
04e9897c
DA
12812012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1282
1283 Adjust buffer text indirection counters at the end of Fkill_buffer.
1284 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1285 buffer is definitely dead. This should really fix an issue reported
1286 by Christoph Scholtes again. (Bug#12007).
1287 (init_buffer_once): Initialize indirection counters of
1288 buffer_defaults and buffer_local_symbols (for sanity and safety).
1289
8a0484e1
EZ
12902012-07-24 Eli Zaretskii <eliz@gnu.org>
1291
1292 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1293 and continuation glyphs on tooltip frames, leave them at zero.
1294 Avoids continued lines in tooltips. (Bug#11832)
1295
fa691a83
DA
12962012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1297
1298 Simplify copy_overlay.
04e9897c 1299 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1300 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1301
436bc8e0
EZ
13022012-07-23 Eli Zaretskii <eliz@gnu.org>
1303
1304 * print.c (print_object): Don't crash when a frame's name is nil
1305 or invalid. (Bug#12025)
1306
1307 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1308 it signals an error when a tooltip frame is being created.
1309
d7a7fda3
DA
13102012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Cleanup miscellaneous objects allocation and initialization.
1313 * alloc.c (allocate_misc): Change to static. Add argument to
1314 specify the subtype. Adjust comment and users.
1315 (build_overlay): New function.
1316 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1317 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1318 (allocate_misc): Remove prototype.
1319 (build_overlay): Add prototype.
1320
13212012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1322
1323 Swap buffer text indirection counters in Fbuffer_swap_text.
1324 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1325 This avoids crash reported by Christoph Scholtes at
1326 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1327
9d7fa573
JD
13282012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1329
1330 * nsmenu.m (Popdown_data): New struct.
1331 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1332 free Popdown_data.
1333 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1334 (initWithContentRect): Make imgView and contentView non-static
1335 and autorelease them. Also autorelease img and matrix (Bug#12005).
1336 (dealloc): Remove (Bug#12005).
1337
0dd6d66d
DA
13382012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1339
1340 Adjust consing_since_gc when objects are explicitly freed.
1341 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1342 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1343 (free_cons, free_misc): Subtract object size from consing_since_gc.
1344
d36d71df
DA
13452012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1346
1347 Simplify and cleanup markers positioning code.
1348 * marker.c (attach_marker): More useful eassert.
1349 (live_buffer, set_marker_internal): New function.
1350 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1351 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1352
fb9ea40f
PE
13532012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1354
1355 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1356 as it's limited by the amount of memory, not by INT_MAX.
1357
2d5c5f7d
EZ
13582012-07-21 Eli Zaretskii <eliz@gnu.org>
1359
07fb592e
EZ
1360 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1361 in special-event-map. See the discussion at
1362 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1363 for the reasons.
1364
37a9eac8 1365 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1366 info.dwItemData. Fixes crashes on 64-bit Windows.
1367 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1368
c4328746
JD
13692012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1370
1371 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1372 (conversationIdentifier): Return value is NSInteger.
784051c4 1373 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1374
6e5d1c12
CY
13752012-07-21 Chong Yidong <cyd@gnu.org>
1376
1377 * window.c (decode_any_window): Signal an error if the window is
1378 on a dead frame (Bug#11984).
1379
9928463d
DA
13802012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 Add indirection counting to speed up Fkill_buffer.
1383 * buffer.h (struct buffer): New member.
1384 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1385 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1386 base buffer indirection counter.
1387 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1388 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1389 through buffer list if indirection counter is 0.
1390
f8643a6b
DA
13912012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1392
1393 Extend the value returned by Fgarbage_collect with heap statistics.
1394 * alloc.c (Qheap): New symbol.
1395 (syms_of_alloc): DEFSYM it.
1396 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1397 (Fmemory_free): Remove.
1398 (syms_of_alloc): Don't defsubr it.
1399 * buffer.c (Fcompact_buffer): Remove.
1400 (syms_of_buffer): Don't defsubr it.
1401
dac616ff
DA
14022012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1403
1404 Make maybe_gc inline.
1405 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1406 * lisp.h (consing_since_gc, gc_relative_threshold)
1407 (memory_full_cons_threshold): Revert declaration.
1408 (maybe_gc): Remove prototype, define as inline.
1409 * alloc.c: Remove old commented-out code.
1410 (consing_since_gc, gc_relative_threshold)
1411 (memory_full_cons_threshold): Revert to global.
1412 (maybe_gc): Remove.
1413
d7ea76b4
DA
14142012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1415
1416 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1417 * lisp.h (build_unibyte_string): New function.
1418 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1419 * sysdep.c, w32fns.c, xfns.c: Use it.
1420 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1421 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1422 Adjust users accordingly.
1423 * font.h (font_open_by_name): Adjust prototype.
1424
765e61e3
DA
14252012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1426
1427 Cleanup calls to Fgarbage_collect.
1428 * lisp.h (maybe_gc): New prototype.
1429 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1430 Remove declarations.
1431 * alloc.c (maybe_gc): New function.
1432 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1433 Make them static.
1434 * bytecode.c (MAYBE_GC): Use maybe_gc.
1435 * eval.c (eval_sub, Ffuncall): Likewise.
1436 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1437 to avoid dependency from auto-save feature.
1438
52b852c7
PE
14392012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1442 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1443 'for_each_per_buffer_object_at'.
1444 All uses changed. It's better to use upper-case for macros that
1445 cannot be implemented as functions, to give the reader a clue
1446 that they're special.
1447
5db81e33
SM
14482012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1449
1450 * alloc.c (Fgarbage_collect): Tweak docstring.
1451
5b835e1d
DA
14522012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1453
1454 Tweak the value returned from Fgarbage_collect again.
1455 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1456 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1457 Adjust documentation.
1458 (total_vector_bytes): Rename to total_vector_slots, adjust
1459 accounting.
1460 (total_free_vector_bytes): Rename to total_free_vector_slots,
1461 adjust accounting.
1462 (Qstring_bytes, Qvector_slots): New symbols.
1463 (syms_of_alloc): DEFSYM them.
1464
9cd47b72
DA
14652012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1466
1467 Buffer compaction primitive which may be used from Lisp.
1468 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1469 (syms_of_buffer): Register Fcompact_buffer.
1470 * alloc.c (Fgarbage_collect): Use compact_buffer.
1471 * buffer.h (compact_buffer): New prototype.
1472 (struct buffer_text): New member.
1473
d17337e5
DA
14742012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1475
1476 New macro to iterate over all buffers, miscellaneous cleanups.
1477 * lisp.h (all_buffers): Remove declaration.
1478 * buffer.h (all_buffers): Add declaration, with comment.
1479 (for_each_buffer): New macro.
1480 * alloc.c (Fgarbage_collect, mark_object): Use it.
1481 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1482 (init_buffer): Likewise.
1483 * data.c (Fset_default): Likewise.
1484 * coding.c (code_conversion_restore): Remove redundant check
1485 for dead buffer.
1486 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1487
60cfd278
AS
14882012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1489
1490 Fix bug that created negative-length intervals.
1491 * intervals.c (merge_interval_right, merge_interval_left):
1492 Do not zero out this interval if it is absorbed by its children,
1493 as this interval's total length doesn't change in that case. See
1494 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1495
d06714cb
PE
14962012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1497
83713154
PE
1498 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1499 when invoking (make-bool-vector N t) and N is a positive
1500 multiple of 8 -- the last 8 bits were mistakenly cleared.
1501
d06714cb
PE
1502 Remove some struct layout assumptions in bool vectors.
1503 * alloc.c (bool_header_size): New constant.
1504 (header_size, word_size): Move earlier, as they're now used earlier.
1505 Use 'word_size' in a few more places, where it's appropriate.
1506 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1507 padding before the data member of a bool vector.
1508 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1509 than doing the check by hand with an abort ().
1510
464d5a5e
SM
15112012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1512
5fbc0409
SM
1513 * eval.c (Fdefvar): Don't check constants since we only set the var if
1514 it's not yet defined anyway (bug#11904).
1515
464d5a5e
SM
1516 * lisp.h (last_undo_boundary): Declare new var.
1517 * keyboard.c (command_loop_1): Set it.
1518 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1519 were auto-added by the command loop (bug#11774).
1520
8dc2e44a
AS
15212012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1522
1523 * w32font.c (Qsymbol): Remove local definition.
1524 (syms_of_w32font): Don't DEFSYM it.
1525
169925ec
DA
15262012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1527
1528 Fix sweep_vectors to handle large bool vectors correctly.
1529 * alloc.c (sweep_vectors): Account total_vector_bytes for
1530 bool vectors larger than VBLOCK_BYTES_MAX.
1531
5fbfb018
CY
15322012-07-18 Chong Yidong <cyd@gnu.org>
1533
1534 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1535 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1536
3ab6e069
DA
15372012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1538
1539 Return more descriptive data from Fgarbage_collect.
1540 Suggested by Stefan Monnier in
1541 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1542 * alloc.c (bounded_number): New function.
1543 (total_buffers, total_vectors): New variable.
1544 (total_string_size): Rename to total_string_bytes, adjust users.
1545 (total_vector_size): Rename to total_vector_bytes, adjust users.
1546 (sweep_vectors): Account total_vectors and total_vector_bytes.
1547 (Fgarbage_collect): New return value. Adjust documentation.
1548 (gc_sweep): Account total_buffers.
1549 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1550 (VECTOR_SIZE): Remove.
1551 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1552 (Qinterval, Qmisc): New symbols.
1553 (syms_of_data): Initialize them.
1554 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1555 (Qcons, Qbuffer): New declarations.
1556
6d02fe5b
PE
15572012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1560 Round up, not down. Improve doc.
1561
b7ffe040
DA
15622012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1563
1564 Restore old code in allocate_string_data to avoid Faset breakage.
1565 Reported by Julien Danjou <julien@danjou.info> in
1566 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1567 * alloc.c (allocate_string_data): Restore old code with minor
1568 adjustments, fix comment to explain this subtle issue.
1569
4dc7c8d5
SM
15702012-07-17 Eli Zaretskii <eliz@gnu.org>
1571
1572 Remove FILE_SYSTEM_CASE.
1573 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1574
1575 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1576 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1577 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1578 call-process-region passes it through expand-file-name.
1579
1580 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1581
15822012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1583
1584 Fix crash when creating indirect buffer (Bug#11917)
1585 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1586 Don't handle unbound variables specially if non-zero.
1587 (Fbuffer_local_variables): Pass zero.
1588 (clone_per_buffer_values): Pass non-zero.
1589
15902012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1591
1592 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1593 to make the loop interruptible.
1594
15952012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1596
1597 * gnutls.c (emacs_gnutls_handshake): Only retry if
1598 GNUTLS_E_INTERRUPTED.
1599
cce7fefc
DA
16002012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1601
1602 Cleanup and convert miscellaneous checks to eassert.
1603 * alloc.c (mark_interval): Fix comment, partially rephrase
1604 old comment from intervals.h (see below).
1605 * intervals.c (find_interval, adjust_intervals_for_insertion)
1606 (delete_interval, adjust_intervals_for_deletion)
1607 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1608 Convert to eassert.
1609 (adjust_intervals_for_insertion, make_new_interval):
1610 Remove obsolete and unused code.
1611 * intervals.h (struct interval): Remove obsolete comment.
1612 * textprotp.c (erase_properties): Remove unused code.
1613 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1614 (Fremove_list_of_text_properties): Convert to eassert.
1615
9ea10cc3
CY
16162012-07-17 Chong Yidong <cyd@gnu.org>
1617
1618 * editfns.c (Finsert_char): Doc fix.
1619
3900d5de
DA
16202012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1621
1622 Fix previous change to make Fmemory_free always accurate.
1623 * alloc.c (make_interval): Update total_free_intervals.
1624 (make_float): Likewise for total_free_floats.
1625 (free_cons, Fcons): Likewise for total_free_conses.
1626 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1627 Likewise for total_free_vector_bytes.
1628 (Fmake_symbol): Likewise for total_free_symbols.
1629 (bytes_free): Remove.
1630
7098646f
DA
16312012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1632
1633 Simple free memory accounting feature.
1634 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1635 (sweep_vectors): Accumulate size of free vectors.
1636 (Fgarbage_collect): Setup bytes_free.
1637 (Fmemory_free): New function.
1638 (syms_of_alloc): Register it.
1639
22657b40
DA
16402012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1641
1642 Cleanup overlays checking.
1643 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1644 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1645 eassert and OVERLAYP.
1646 (sort_overlays): Change to use OVERLAYP.
1647
ddfc8813
RK
16482012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1649
1650 * editfns.c (Finsert_char): Make it interactive, and make the
1651 second arg optional. Copy interactive spec and docstring from
1652 ucs-insert.
1653
7c26cf3c
PE
16542012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1655
1656 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1657 Unlike the other wrapped functions, fabs has an unspecified
1658 effect on errno.
1659
5d127af9
JD
16602012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1661
1662 * nsterm.m (keyDown): Interpret flags without left/right bits
1663 as the left key (Bug#11670).
1664
6a0dd1d7
DA
16652012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1666
1667 Remove empty and useless init functions.
1668 * lisp.h (init_character_once, init_fns, init_image)
1669 (init_filelock, init_sound): Remove prototype.
1670 * character.c (init_character_once): Remove.
1671 * filelock.c (init_filelock): Likewise.
1672 * fns.c (init_fns): Likewise.
1673 * image.c (init_image): Likewise.
1674 * sound.c (init_sound): Likewise.
1675 * emacs.c (main): Adjust accordingly.
1676
7a6136fd
DA
16772012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1678
1679 * gtkutil.h: Tiny cleanups.
1680 (use_old_gtk_file_dialog): Remove useless declaration.
1681 (xg_uses_old_file_dialog): Add suggested const attribute.
1682
ce811ad9
EZ
16832012-07-15 Eli Zaretskii <eliz@gnu.org>
1684
1685 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1686 (bidi_paragraph_init): Use it to limit search forward for a strong
1687 directional character in abnormally large paragraphs full of
1688 neutral or weak characters. (Bug#11943)
1689
c9adfeaa
SF
16902012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1691
1692 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1693 the toolbar (Bug#9451).
1694 (xg_make_tool_item): Give the widget event box a transparent
1695 background.
1696
fff62aa9
DA
16972012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1698
1699 Cleanup basic allocation variables and functions.
1700 * alloc.c (ignore_warnings, init_intervals, init_float)
1701 (init_cons, init_symbol, init_marker): Remove.
1702 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1703 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1704 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1705 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1706 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1707 (staticidx, init_alloc_once, init_strings, free_ablock):
1708 Remove redundant initialization.
1709 * fns.c (init_weak_hash_tables): Remove.
1710 * lisp.h (init_weak_hash_tables): Remove prototype.
1711
9730daca
DA
17122012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1713
1714 Use zero_vector where appropriate.
1715 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1716 accordingly.
1717 * lisp.h (zero_vector): New declaration.
1718 * font.c (null_vector): Remove.
1719 (syms_of_font): Remove initialization and staticpro.
1720 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1721 * keymap.c (Faccessible_keymaps): Likewise.
1722
2e2d2a13
LL
17232012-07-15 Leo Liu <sdl.web@gmail.com>
1724
1725 * fringe.c: Fix typo in comments.
1726
cd276f6e
LL
17272012-07-14 Leo Liu <sdl.web@gmail.com>
1728
1729 * fringe.c: Add a new bitmap exclamation-mark.
1730
5a1131d9
EZ
17312012-07-14 Eli Zaretskii <eliz@gnu.org>
1732
1733 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1734
1735 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1736 (HAVE_MENUS): Don't define, defined by editing config.in with
1737 msdos/sed2v2.inp.
1738 (GMALLOC_INHIBIT_VALLOC): Don't define.
1739 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1740
22e983b7
JB
17412012-07-14 Juanma Barranquero <lekktu@gmail.com>
1742
1743 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1744
5b3f250f
GM
17452012-07-14 Glenn Morris <rgm@gnu.org>
1746
1747 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1748 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1749 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1750
33d63ff4
GM
17512012-07-13 Glenn Morris <rgm@gnu.org>
1752
5b633342
GM
1753 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1754
33d63ff4
GM
1755 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1756 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1757
b55b9f85
JD
17582012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1759
0dc8cf50
JD
1760 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1761 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1762 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1763 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1764 where appropriate.
1765 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1766 as boolean expression.
1767 (x_set_window_size): Remove unused variable toolbar.
1768 (ns_get_color_default, ns_mod_to_lisp): Remove.
1769 (ns_mouse_position): Remove unused variables xchar and ychar.
1770 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1771 (ns_set_vertical_scroll_bar): Remove unused variable count.
1772 (ns_delete_terminal): Remove unused variable i.
1773 (ns_term_init): Remove unused variables r, g and b.
1774 (mouseDown): Remove unused variable window.
1775 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1776 (initFrameFromEmacs): Remove unused variable vbextra.
1777 (mouseEntered): Remove unused variables p and dpyinfo.
1778 (mouseExited): Remove unused variables p and r.
1779 (ns_define_frame_cursor, ns_clear_frame_area)
1780 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1781 (menuDown): Assign [sender tag] to variable and cast the variable.
1782
1783 * nsterm.h (menuDown): Add id as type to argument sender.
1784 (ns_display_info_for_name): Add Lisp_Object argument.
1785 (ns_term_init): Add Lisp_Object argument.
1786 (ns_map_event_to_object): Add void argument.
1787 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1788 prototype with arguments and only declare if __OBJC__.
1789 (nxatoms_of_nsselect): Add void argument.
1790 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1791 (ns_alloc_autorelease_pool): Add void argument.
1792 (ns_release_autorelease_pool): Add void* argument.
1793 (ns_get_defaults_value): Add const char* argument.
1794
1795 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1796 (initFromContents): Use SSDATA where appropriate.
1797 (ns_update_menubar): Add braces to ambigous if-else.
1798 (initWithTitle): Put () around assignment in if statement.
1799 (ns_menu_show): Remove unused variables window and keymap.
1800 (update_frame_tool_bar): Remove unused variable selected_p.
1801 (initWithContentRect): Remove unused variable this_cmd_name.
1802
1803 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1804 appropriate.
1805 (setXBMColor): Remove unused variable len.
1806 (setPixmapData): Put () around assignment in loop statement.
1807
1808 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1809 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1810 where appropriate.
1811 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1812 around assignment in loop statement.
1813 (nsfont_open): Remove unused variable i.
1814 (nsfont_open): Remove unused variable len.
1815 (nsfont_draw): Remove unused variable cs.
1816
1817 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1818 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1819 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1820 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1821 (Fns_font_name, Fns_perform_service)
1822 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1823 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1824 (ns_set_name): Remove unused variable view.
1825 (x_set_menu_bar_lines): Remove unused variable olines.
1826 (x_set_tool_bar_lines): Remove unused variable root_window.
1827 (Fns_list_colors): Put () around assignment in while statement.
1828 (Fns_perform_service): Remove unused variable len.
1829 (Fns_display_usable_bounds): Remove unused variable top.
1830 (syms_of_nsfns): Remove unused variable i.
1831
b55b9f85
JD
1832 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1833 memcpy (Bug#11907).
1834
ed9265fc 18352012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1836
1837 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1838 and free it with DestroyExceptionInfo (Bug#11558).
1839
ef099b57
JB
18402012-07-13 Juanma Barranquero <lekktu@gmail.com>
1841
1842 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1843 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1844 Set here, not in nt/config.nt.
1845
ea814a5d
EZ
18462012-07-13 Eli Zaretskii <eliz@gnu.org>
1847
1848 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1849 cursor overflow into the last glyph on display line when the right
1850 fringe is off. (Bug#11832)
1851
1a952767
PE
18522012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1853
1854 * xdisp.c (produce_special_glyphs): Now static.
1855 * dispextern.h (produce_special_glyphs): Remove decl.
1856
983188fd
GM
18572012-07-13 Glenn Morris <rgm@gnu.org>
1858
8d7c7eed 1859 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1860 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1861
983188fd
GM
1862 * s/usg5-4-common.h (USG, USG5):
1863 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1864 * s/sol2-6.h (SOLARIS2):
1865 * s/irix6-5.h (IRIX6_5):
1866 * s/hpux10-20.h (USG, USG5, HPUX):
1867 * s/gnu-linux.h (USG, GNU_LINUX):
1868 * s/freebsd.h (BSD_SYSTEM):
1869 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1870 * s/cygwin.h (CYGWIN):
1871 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1872 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1873
d1e68667 18742012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1875
1876 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1877
6de0e799
GM
18782012-07-13 Glenn Morris <rgm@gnu.org>
1879
739ae010
GM
1880 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1881
dbee5793
GM
1882 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1883
6de0e799
GM
1884 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1885 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1886
b82da769
GM
18872012-07-12 Glenn Morris <rgm@gnu.org>
1888
4fae5a7a 1889 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1890
1891 * process.c (init_process_emacs): Rename from init_process.
1892 The old name is also the name of a Mach system call.
1893 * lisp.h, emacs.c: Update for this name change.
1894 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1895 longer needed.
1896
5a979817
EZ
18972012-07-12 Eli Zaretskii <eliz@gnu.org>
1898
1899 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1900 memmove call that removes glyphs covered by the left truncation
1901 glyph. Improve commentary.
1902 (display_line): Fix display of continuation glyphs on GUI frames
1903 when the right fringe is turned off and variable-size fonts are
1904 used in the window. Move the code that appends a stretch glyph to
1905 produce_special_glyphs, so that it could be used for truncation
1906 and continuation glyphs alike.
1907 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1908 glyph of a suitably computed width, to align the special glyphs at
1909 the window margin. Code moved from display_line. (Bug#11832)
1910
3e91a053
GM
19112012-07-12 Glenn Morris <rgm@gnu.org>
1912
ba9e4b84
GM
1913 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1914
1915 * s/gnu-linux.h, s/hpux10-20.h:
1916 Do not unconditionally define HAVE_XRMSETDATABASE.
1917
3e91a053
GM
1918 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1919
b300b1f4
PE
19202012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 Fix typos that broke OS X build.
1923 Reported by Randal L. Schwartz in
1924 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1925 * nsterm.m (ns_timeout): Add missing local decl.
1926 (ns_get_color): snprintf -> sprintf, to fix typo.
1927
6e777848
GM
19282012-07-12 Glenn Morris <rgm@gnu.org>
1929
3f922c37
GM
1930 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1931 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1932 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1933 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1934
0ab7b23a
GM
1935 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1936 Move PTY_OPEN to configure.
1937
6e777848
GM
1938 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1939 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1940 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1941
4a7edc24
DA
19422012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1943
1944 Use empty_unibyte_string where applicable.
1945 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1946 * lread.c (read1): Likewise.
1947 * xsettings.c (syms_of_xsettings): Likewise.
1948
308aab79
GM
19492012-07-12 Glenn Morris <rgm@gnu.org>
1950
42bd1719
GM
1951 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1952 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1953 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1954 * s/hpux10-20.h (RUN_TIME_REMAP):
1955 * s/bsd-common.h (TABDLY): Move to configure.
1956
1957 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1958
1959 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1960
ea0bbd17 1961 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1962 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1963
1964 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1965
308aab79
GM
1966 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1967 * s/template.h: Move NARROWPROTO to configure.
1968
ee1cf5cf
GM
19692012-07-11 Glenn Morris <rgm@gnu.org>
1970
30fe9bf4
GM
1971 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1972 unused since 2011-01-17 change to systty.h.
1973
ee1cf5cf
GM
1974 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1975 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1976 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1977
63e47e07
PE
19782012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1979
1980 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1981
c43fb4c3
GM
19822012-07-11 Glenn Morris <rgm@gnu.org>
1983
1984 * s/darwin.h, s/gnu-linux.h, s/template.h:
1985 Move INTERRUPT_INPUT to configure.
1986
e8df9267
DA
19872012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1988
1989 Minor adjustments to interning code.
1990 * lisp.h (intern, intern_c_string): Redefine as static inline
1991 wrappers for intern_1 and intern_c_string_1, respectively.
1992 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1993 * lread.c (intern_1, intern_c_string_1, oblookup):
1994 Simplify Vobarray checking.
e8df9267
DA
1995 * font.c (font_intern_prop): Likewise. Adjust comment.
1996 * w32font.c (intern_font_name): Likewise.
1997
34348bd4
AS
19982012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1999
d96a1e0c
AS
2000 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2001
34348bd4
AS
2002 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2003 of Fcar/Fcdr if possible.
2004 * font.c (check_otf_features): Likewise.
2005 * fontset.c (Fnew_fontset): Likewise.
2006 * gnutls.c (Fgnutls_boot): Likewise.
2007 * minibuf.c (read_minibuf): Likewise.
2008 * msdos.c (IT_set_frame_parameters): Likewise.
2009 * xmenu.c (Fx_popup_dialog): Likewise.
2010 * w32menu.c (Fx_popup_dialog): Likewise.
2011
c8add24e
GM
20122012-07-11 Glenn Morris <rgm@gnu.org>
2013
4b575b3c
GM
2014 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2015 since nothing has defined it on these platforms.
2016
09f4e3b0
GM
2017 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2018 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2019
172bedef
GM
2020 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2021 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2022 Move CLASH_DETECTION to configure.
2023
249685df
GM
2024 * s/gnu.h: Remove file, which is now empty.
2025
c8add24e
GM
2026 * s/gnu.h, s/gnu-linux.h:
2027 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2028
b41253a3
JW
20292012-07-11 John Wiegley <johnw@newartisans.com>
2030
2031 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2032 function attribute, so we only use it if it exists in the
2033 compiler.
2034
d923b542
DA
20352012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2036
2037 Avoid call to strlen in fast_c_string_match_ignore_case.
2038 * search.c (fast_c_string_match_ignore_case): Change to use
2039 length argument. Adjust users accordingly.
2040 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2041
5ebbef1d
PE
20422012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2043
bb352260
PE
2044 Assume mkdir, rmdir.
2045 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2046 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2047
57054ddd
PE
2048 Assume rename.
2049 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2050
b747d3f7
PE
2051 Assume perror.
2052 * s/hpux10-20.h (HAVE_PERROR): Remove.
2053 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2054 Remove dummy definition, as this problem was obsolete long ago.
2055
5ebbef1d
PE
2056 Assume strerror.
2057 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2058
984e7f30
DA
20592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2060
2061 Avoid calls to strlen in font processing functions.
2062 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2063 (font_open_by_name): Change to use length argument.
2064 Adjust users accordingly.
d923b542
DA
2065 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2066 Adjust prototypes.
2067 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2068 Change to return ptrdiff_t.
984e7f30
DA
2069 (xfont_list_pattern, xfont_match): Use length returned by
2070 xfont_decode_coding_xlfd.
2071 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2072
20e94fdd
GM
20732012-07-11 Glenn Morris <rgm@gnu.org>
2074
9d596af3
GM
2075 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2076 Move DONT_REOPEN_PTY to configure.
2077
20e94fdd
GM
2078 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2079 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2080
e99a530f
PE
20812012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2082
22ffb973
PE
2083 Remove "#define unix" that is no longer needed (Bug#11905).
2084 * s/aix4-2.h (unix): Remove; no longer needed.
2085
e9a9ae03
PE
2086 EMACS_TIME simplification (Bug#11875).
2087 This replaces macros (which typically do not work in GDB)
2088 with functions, typedefs and enums, making the code easier to debug.
2089 The functional style also makes code easier to read and maintain.
2090 * systime.h: Include <sys/time.h> on all hosts, not just if
2091 WINDOWSNT, since 'struct timeval' is needed in general.
2092 (EMACS_TIME): Now a typedef, not a macro.
2093 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2094 not macros.
2095 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2096 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2097 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2098 (EMACS_TIME_LE): Now functions, not macros.
2099 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2100 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2101 which are not functions. All uses rewritten to use:
2102 (make_emacs_time): New function.
2103 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2104 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2105 not functions. All uses rewritten to use the following, respectively:
2106 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2107 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2108 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2109 * fileio.c (Fcopy_file):
2110 * xterm.c (XTflash): Get the current time closer to when it's used.
2111 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2112
ffacb126
PE
2113 * bytecode.c (targets): Suppress -Woverride-init warnings.
2114
e99a530f
PE
2115 Simplify by avoiding confusing use of strncpy etc.
2116 * doc.c (Fsnarf_documentation):
2117 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2118 * frame.c (Fmake_terminal_frame):
2119 * gtkutil.c (get_utf8_string):
2120 * lread.c (openp):
2121 * nsmenu.m (ns_update_menubar):
2122 * regex.c (regerror):
2123 Prefer memcpy to strncpy and strncat when either will do.
2124 * fileio.c (Fsubstitute_in_file_name):
2125 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2126 (menu_separator_name_p):
2127 * nsmenu.m (ns_update_menubar):
2128 Prefer memcmp to strncmp when either will do.
2129 * nsterm.m: Include <ftoastr.h>.
2130 (ns_get_color):
2131 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2132 Prefer snprintf to strncpy.
2133 * nsterm.m (ns_term_init):
2134 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2135 * nsterm.m (ns_term_init):
2136 Avoid the need for strncpy, by using build_string or
2137 make_unibyte_string directly. Use dtoastr, not snprintf.
2138 * process.c (Fmake_network_process): Diagnose service names that
2139 are too long, rather than silently truncating them or creating
2140 non-null-terminated names.
2141 (Fnetwork_interface_info): Likewise, for interface names.
2142 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2143 Prefer sprintf to strncat.
2144 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2145 Prefer vsnprintf to vsprintf + strncpy.
2146
c59592b3
GM
21472012-07-10 Glenn Morris <rgm@gnu.org>
2148
2149 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2150 Clarify fallback case.
2151
7d7bbefd
DA
21522012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2153
2154 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2155 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2156 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2157 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2158 where argument type is known to be a Lisp_Cons.
2159
3a4c8000
TT
21602012-07-10 Tom Tromey <tromey@redhat.com>
2161
2162 * bytecode.c (BYTE_CODE_THREADED): New macro.
2163 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2164 (enum byte_code_op): New type.
2165 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2166 (exec_byte_code): Use them. Use token threading when applicable.
2167
2a0213a6
DA
21682012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2169
2170 Optimize pure C strings initialization.
2171 * lisp.h (make_pure_string): Fix prototype.
2172 (build_pure_c_string): New function, defined as static inline. This
2173 provides a better opportunity to optimize away calls to strlen when
2174 the function is called with compile-time constant argument.
2175 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2176 argument, adjust users accordingly. Use build_pure_c_string where
2177 appropriate.
2178 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2179 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2180 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2181
cb1caeaf
DA
21822012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2183
2184 Avoid calls to strlen in miscellaneous functions.
2185 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2186 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2187 * lread.c (openp): Likewise.
2188
c293e30c
DA
21892012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2190
2191 Avoid calls to strlen in path processing functions.
2192 * fileio.c (file_name_as_directory): Add comment. Change to add
2193 srclen argument and return the length of result. Adjust users
2194 accordingly.
2195 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2196 swap 1st and 2nd arguments to obey the common convention.
2197 Adjust users accordingly.
c293e30c
DA
2198 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2199
9e059e3f
GM
22002012-07-10 Glenn Morris <rgm@gnu.org>
2201
d02eb359
GM
2202 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2203 Move PENDING_OUTPUT_COUNT definition to configure.
2204
882cf227
GM
2205 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2206 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2207 * s/gnu.h (DATA_START): Move definitions to configure.
2208
af6e839f
GM
2209 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2210 We include usg5-4-common.h, which defines them both.
2211
40289a12
GM
2212 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2213 O_RDONLY already includes it).
2214
9e059e3f
GM
2215 Stop ns builds setting the EMACSLOADPATH environment variable.
2216 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2217 Now it does not set EMACSLOADPATH, just returns the load-path string.
2218 * nsterm.h: Update accordingly.
2219 * lread.c [HAVE_NS]: Include nsterm.h.
2220 (init_lread) [HAVE_NS]: Use ns_load_path.
2221 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2222
7c4e8ec0
GM
22232012-07-09 Glenn Morris <rgm@gnu.org>
2224
d4f600ff
GM
2225 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2226 since the included bsd-common.h does so.
2227
cbb31951
GM
2228 Stop ns builds setting the EMACSPATH environment variable.
2229 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2230 (ns_init_paths): Do not set EMACSPATH.
2231 * nsterm.h (ns_exec_path): Add it.
2232 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2233 Use ns_exec_path.
2234
7c4e8ec0
GM
2235 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2236
26bccfae
PE
22372012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2238
a0bee46f
PE
2239 * process.c (wait_reading_process_output): 'waitchannels' was unset
2240 when read_kbd || !NILP (wait_for_cell); fix this.
2241
5994c183
PE
2242 Add GCC-style 'const' attribute to functions that can use it.
2243 * character.h (char_resolve_modifier_mask):
2244 * keyboard.h (make_ctrl_char):
2245 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2246 (init_character_once, next_almost_prime, init_fns, init_image)
2247 (flush_pending_output, init_sound):
2248 * mem-limits.h (start_of_data):
2249 * menu.h (finish_menu_items):
2250 Add ATTRIBUTE_CONST.
2251 * emacs.c (DEFINE_DUMMY_FUNCTION):
2252 Declare the dummy function with ATTRIBUTE_CONST.
2253 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2254 Add decls with ATTRIBUTE_CONST.
2255
26bccfae
PE
2256 Minor improvements to make_formatted_string.
2257 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2258 where int is good enough, as vsprintf returns an int.
2259 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2260
a8290ec3
DA
22612012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2262
2263 Use make_formatted_string to avoid double length calculation.
2264 * lisp.h (make_formatted_string): New prototype.
2265 * alloc.c (make_formatted_string): New function.
2266 * buffer.c (Fgenerate_new_buffer_name): Use it.
2267 * dbus.c (syms_of_dbusbind): Likewise.
2268 * editfns.c (Fcurrent_time_zone): Likewise.
2269 * filelock.c (get_boot_time): Likewise.
2270 * frame.c (make_terminal_frame, set_term_frame_name)
2271 (x_report_frame_params): Likewise.
2272 * image.c (gs_load): Likewise.
2273 * minibuf.c (get_minibuffer): Likewise.
2274 * msdos.c (dos_set_window_size): Likewise.
2275 * process.c (make_process): Likewise.
2276 * xdisp.c (ensure_echo_area_buffers): Likewise.
2277 * xsettings.c (apply_xft_settings): Likewise.
2278
d01ba2f1
GM
22792012-07-09 Glenn Morris <rgm@gnu.org>
2280
2281 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2282 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2283 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2284 * nsterm.h (ns_etc_directory): Add it.
2285 * callproc.c [HAVE_NS]: Include nsterm.h.
2286 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2287
f1f924b6
DA
22882012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2289
2290 Move marker debugging code under MARKER_DEBUG.
2291 * marker.c (MARKER_DEBUG): Move marker debugging code under
2292 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2293 for bootstrap with --enable-checking (~3x slowdown reported
2294 by Juanma Barranquero <lekktu@gmail.com>).
2295 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2296
ab531b66
PE
22972012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2300 See <http://bugs.gnu.org/11825#29>.
2301
c4b3bc8a
EZ
23022012-07-08 Eli Zaretskii <eliz@gnu.org>
2303
2304 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2305 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2306 (display_line): Add commentary about displaying truncation glyphs
2307 on GUI frames.
2308 (produce_special_glyphs): Move here from term.c.
2309
2310 * term.c (produce_special_glyphs): Move to xdisp.c.
2311
2312 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2313 section.
c4b3bc8a 2314
b676b881
AS
23152012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2316
f17c5273
AS
2317 * xdisp.c (display_line): Avoid warning about implicit declaration
2318 of FRAME_FONT.
2319
298819b9
AS
2320 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2321
b676b881
AS
2322 * lisp.h: Remove empty conditional.
2323
6045c4fd
PE
23242012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2325
b3350bf9
PE
2326 * lread.c (load_path_check): Now static.
2327
6045c4fd
PE
2328 Fix some minor --with-ns problems found by static checking.
2329 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2330 (x_set_font) [!HAVE_X_WINDOWS]:
2331 * image.c (xpm_load_image) [HAVE_NS]:
2332 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2333 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2334 Remove unused local.
2335 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2336 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2337 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2338 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2339 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2340 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2341 Fix pointer signedness problem.
2342 * xfaces.c (FRAME_X_FONT_TABLE):
2343 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2344
929e7845
GM
23452012-07-07 Glenn Morris <rgm@gnu.org>
2346
2347 * lread.c (load_path_check): New function, split from init_lread.
2348 (init_lread): Reorganize. Motivation:
2349 If EMACSLOADPATH is set, check/warn about that rather than the
2350 defaults, which we are not going to use. Hence we can remove
2351 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2352 Don't warn if site-lisp directories are missing.
2353 If not installed, start from a blank load-path, since
2354 PATH_LOADSEARCH refers to the eventual installation directories.
2355
58dd0aa4
EZ
23562012-07-07 Eli Zaretskii <eliz@gnu.org>
2357
2358 Support truncation and continuation glyphs on GUI frames, when
2359 fringes are disabled. (Bug#11832)
2360 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2361 continuation glyphs even if on GUI frames.
2362 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2363 or both, are absent.
2364 (start_display, move_it_in_display_line_to): Handle the case of a
2365 GUI frame without a fringe to display continuation or truncation
2366 glyphs.
2367 (insert_left_trunc_glyphs): Support GUI frames: make sure
2368 truncation glyphs overwrite enough glyphs from the current line to
2369 have sufficient space in pixels.
2370 (display_line): Support truncation and continuation glyphs on GUI
2371 frames. If some spare pixels are left on the line after inserting
2372 the truncation glyphs, fill that space with a stretch glyph of a
2373 suitably computed width.
2374
2375 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2376 produce_glyphs, to support GUI sessions.
2377
31571fd7
PE
23782012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2379
5a16b9bc
PE
2380 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2381
f3047c75
PE
2382 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2383
31571fd7
PE
2384 Do not require float-time's arg to fit in time_t (Bug#11825).
2385 This works better on hosts where time_t is unsigned, and where
2386 float-time is applied to the (negative) difference between two times.
2387 * editfns.c (decode_time_components): Last arg is now double *,
2388 not int *, and means to store all the result as a double, without
2389 worrying about whether the seconds part fits in time_t.
2390 All callers changed.
2391 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2392 All callers changed.
2393 (Ffloat_time): Do not fail merely because the specified time falls
2394 outside of time_t range.
2395
4516fbef
GM
23962012-07-07 Glenn Morris <rgm@gnu.org>
2397
2398 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2399 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2400 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2401
07adc2c6
JB
24022012-07-07 Juanma Barranquero <lekktu@gmail.com>
2403
2404 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2405 Update dependencies.
2406
2407 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2408
fd573f31
PE
24092012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2410
fee5959d
PE
2411 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2412 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2413 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2414 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2415 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2416 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2417
fd573f31
PE
2418 * xfont.c (compare_font_names): Redo to omit the need for casts.
2419
ddadbc0e
AS
24202012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2421
fca8d6b6
AS
2422 * xfns.c (Fx_change_window_property): Doc fix.
2423 * w32fns.c (Fx_change_window_property): Doc fix.
2424
ddadbc0e
AS
2425 * w32fns.c (Fx_window_property): Accept the same arguments as the
2426 X Windows version. Doc fix.
2427 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2428
ed9265fc 24292012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2430 Eli Zaretskii <eliz@gnu.org>
2431
2432 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2433 Windows-specific code from nt/config.nt moved here.
2434 Obsolete settings removed.
2435
216ee680
PE
24362012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 * process.c: Avoid unnecessary calls to gettime.
2439 (wait_reading_process_output): Don't get the time of day
2440 when gobbling data immediately and not waiting, as there's no need
2441 for it in that case. This removes a FIXME.
2442
bdd091e4
JD
24432012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2444
2445 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2446 is defined (Bug#11768).
2447
9d44f8ce
DA
24482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2449
2450 Fix marker debugging code.
2451 * marker.c (byte_char_debug_check): Do not perform the check
2452 if buffer is not multibyte.
090bd7cb
JB
2453 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2454 Call byte_char_debug_check with correct arguments.
9d44f8ce 2455
90fc4786
DA
24562012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2457
2458 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2459 * marker.c (byte_char_debug_check, count_markers):
2460 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2461 (byte_debug_flag): Remove.
2462 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2463 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2464
7b7ae965
DA
24652012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2466
4e57b342
DA
2467 Avoid code repetition in marker-related functions.
2468 * marker.c (attach_marker): New function.
2469 (Fset_marker, set_marker_restricted, set_marker_both)
2470 (set_marker_restricted_both): Use it.
2471 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2472 Consistently rename charno to charpos.
2473 (marker_position): Add eassert.
2474 (marker_byte_position): Convert to eassert.
2475
24762012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2477
2478 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2479 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2480 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2481
657924ff
DA
24822012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2483
2484 Introduce fast path for the widely used marker operation.
2485 * alloc.c (build_marker): New function.
2486 * lisp.h (build_marker): New prototype.
2487 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2488 * composite.c (autocmp_chars): Likewise.
2489 * editfns.c (buildmark): Remove.
2490 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2491 (save_restriction_save): Use build_marker.
2492 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2493 * window.c (save_window_save): Likewise.
2494
041a49a6
DA
24952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2496
2497 Do not use Fdelete_overlay in delete_all_overlays
2498 to avoid redundant calls to unchain_overlay.
2499 * buffer.c (drop_overlay): New function.
2500 (delete_all_overlays, Fdelete_overlay): Use it.
2501 * minibuf.c (get_minibuffer): Fix comment.
2502
7dca65a4
PE
25032012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2504
2505 Port to OpenBSD 5.1 amd64.
2506 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2507 This is needed for OpenBSD, and should be harmless on all BSD systems.
2508 Also, include <sys/sysctl.h>, as it should be available on all
2509 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2510 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2511 use p_pid member, not kp_proc.pid.
2512
8eb876e2
GM
25132012-07-06 Glenn Morris <rgm@gnu.org>
2514
2515 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2516
38182d90
PE
25172012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2518
2519 More xmalloc and related cleanup.
2520 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2521 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2522 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2523 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2524 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2525 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2526 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2527 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2528 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2529 * xterm.c:
2530 Omit needless casts involving void * pointers and allocation.
2531 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2532 as the former is more robust if P's type is changed.
2533 Prefer xzalloc to xmalloc + memset 0.
2534 Simplify malloc-or-realloc to realloc.
2535 Don't worry about xmalloc returning a null pointer.
2536 Prefer xstrdup to xmalloc + strcpy.
2537 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2538 growing it.
2539 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2540 alloca of a constant.
2541
6dd5a677
EZ
25422012-07-05 Eli Zaretskii <eliz@gnu.org>
2543
2544 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2545 hscroll is larger than the line width. Fixes long and futile
2546 looping inside extend_face_to_end_of_line (on a TTY) producing
2547 glyphs that are not needed and thrown away.
2548
6b312f0f
DA
25492012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2550
2551 * marker.c (set_marker_restricted_both): Simplify by using
2552 clip_to_bounds.
2553
f520ef9b
PE
25542012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2555
2556 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2557
383b7c95
JD
25582012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2561 not defined (Bug#11768).
2562 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2563 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2564 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2565 followed by gtk_box_set_homogeneous (Bug#11768).
2566 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2567 (update_theme_scrollbar_width, xg_create_scroll_bar):
2568 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2569 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2570 (is_box_type): New function (Bug#11768).
2571 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2572 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2573 with default display (Bug#11768).
2574
d6e7bf45
EZ
25752012-07-05 Eli Zaretskii <eliz@gnu.org>
2576
2577 * xdisp.c (window_hscroll_limited): New function.
2578 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2579 coordinates when window's hscroll is set to insanely large
2580 values. (Bug#11857)
2581
431391ec
JB
25822012-07-05 Juanma Barranquero <lekktu@gmail.com>
2583
2584 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2585 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2586
23f86fce
DA
25872012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2588
2589 Cleanup xmalloc.
2590 * lisp.h (xzalloc): New prototype. Omit needless casts.
2591 * alloc.c (xzalloc): New function. Omit needless casts.
2592 * charset.c: Omit needless casts. Convert all calls to
2593 xmalloc with following memset to xzalloc.
2594 * dispnew.c: Likewise.
2595 * fringe.c: Likewise.
2596 * image.c: Likewise.
2597 * sound.c: Likewise.
2598 * term.c: Likewise.
2599 * w32fns.c: Likewise.
2600 * w32font.c: Likewise.
2601 * w32term.c: Likewise.
2602 * xfaces.c: Likewise.
2603 * xfns.c: Likewise.
2604 * xterm.c: Likewise.
2605 * atimer.c: Omit needless casts.
2606 * buffer.c: Likewise.
2607 * callproc.c: Likewise.
2608 * ccl.c: Likewise.
2609 * coding.c: Likewise.
2610 * composite.c: Likewise.
2611 * doc.c: Likewise.
2612 * doprnt.c: Likewise.
2613 * editfns.c: Likewise.
2614 * emacs.c: Likewise.
2615 * eval.c: Likewise.
2616 * filelock.c: Likewise.
2617 * fns.c: Likewise.
2618 * gtkutil.c: Likewise.
2619 * keyboard.c: Likewise.
2620 * lisp.h: Likewise.
2621 * lread.c: Likewise.
2622 * minibuf.c: Likewise.
2623 * msdos.c: Likewise.
2624 * print.c: Likewise.
2625 * process.c: Likewise.
2626 * region-cache.c: Likewise.
2627 * search.c: Likewise.
2628 * sysdep.c: Likewise.
2629 * termcap.c: Likewise.
2630 * terminal.c: Likewise.
2631 * tparam.c: Likewise.
2632 * w16select.c: Likewise.
2633 * w32.c: Likewise.
2634 * w32reg.c: Likewise.
2635 * w32select.c: Likewise.
2636 * w32uniscribe.c: Likewise.
2637 * widget.c: Likewise.
2638 * xdisp.c: Likewise.
2639 * xmenu.c: Likewise.
2640 * xrdb.c: Likewise.
2641 * xselect.c: Likewise.
2642
0497dc44
PE
26432012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * fileio.c (time_error_value): Check the right error number.
2646 Problem reported by Troels Nielsen in
2647 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2648
356e7178
PE
26492012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2650
4e71fd89
PE
2651 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2652 This should be fixed in a better way; see Eli Zaretskii in
2653 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2654 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2655
f0941253
PE
2656 * fileio.c (time_error_value): Rename from special_mtime.
2657 The old name's problems were noted by Eli Zaretskii in
2658 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2659
065c9eb4
PE
2660 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2661 This variable's comment says Emacs needs at least one GDB-visible
2662 symbol of type enum pvec_type, to work around GDB problems.
2663 The symbol's value doesn't matter.
2664
356e7178
PE
2665 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2666 that causes compilation to fail on pre-C99 compilers.
2667
ed9265fc 26682012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2669
2670 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2671 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2672
3884d954
DA
26732012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2674
d209e2fb 2675 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2676 headers for buffer_defaults and buffer_local_symbols.
2677 Reported by Juanma Barranquero <lekktu@gmail.com>.
2678
ee28be33
SM
26792012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2680
2681 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2682 * lisp.h (enum pvec_type): Use fewer bits.
2683 (PSEUDOVECTOR_SIZE_BITS): New constant.
2684 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2685 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2686 change in pvec_type.
2687 (PSEUDOVECTOR_TYPEP): New macro.
2688 (TYPED_PSEUDOVECTORP): Use it.
2689 * fns.c (internal_equal): Adapt code to extract pvectype.
2690 * emacs.c (gdb_pvec_type): Update type.
2691 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2692 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2693 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2694 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2695 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2696 abusing vector->header.next.nbytes.
2697 (live_vector_p): Use PVEC_TYPE.
2698 (mark_object): Adapt code to extract pvectype. Use switch.
2699
c7f2cd7f
PE
27002012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2701
2702 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2703 Tighten new eassert a bit.
2704
8ce70ed2
DA
27052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2706
2707 Fix compilation with --enable-gcc-warnings and -O1
2708 optimization level.
2709 * doprnt.c (doprnt): Change type of tem to int, initialize
2710 to avoid compiler warning. Add eassert.
2711 * search.c (simple_search): Initialize match_byte to avoid
2712 compiler warning. Add eassert.
2713
dea7f1e5
PE
27142012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2715
24a212eb
PE
2716 Avoid weird behavior with large horizontal scrolls.
2717 Without this change, for example, large hscroll values would
2718 mess up Emacs's display on Fedora 15 x86, presumably due to
2719 overflows in int calculations in the display code.
2720 Also, if buffers had long lines, Emacs would freeze.
2721 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2722 (set_window_hscroll): New function, containing the old guts of
2723 Fset_window_hscroll. Return the clipped value.
2724 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2725 This avoids the need to check against PTRDIFF_MAX.
2726
dea7f1e5
PE
2727 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2728
76046526
DA
27292012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2730
2731 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2732
39adff0d
PE
27332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2734
63807d47
PE
2735 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2736 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2737 since GCC 4.4.6 issues a bogus warning for them.
2738
39adff0d
PE
2739 Fix bugs in file timestamp newness comparisons.
2740 * fileio.c (Ffile_newer_than_file_p):
2741 * lread.c (Fload): Use full timestamp resolution of files,
2742 not just the 1-second resolution, so that files that are only
2743 slightly newer still count as newer.
2744 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2745 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2746
dbeed9a6
PE
27472012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2748
2749 * fileio.c: Improve handling of file time marker. (Bug#11852)
2750 (special_mtime): New function.
2751 (Finsert_file_contents, Fverify_visited_file_modtime):
2752 Use it to set special mtime values consistently.
2753
636334d6
AS
27542012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2755
2756 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2757 marker for non-existing file. (Bug#11852)
2758
e2017fe2
GM
27592012-07-03 Glenn Morris <rgm@gnu.org>
2760
2761 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2762 and did not make it into globals.h).
2763
404dbd37
TT
27642012-07-03 Tom Tromey <tromey@redhat.com>
2765
2766 * window.c (Fset_window_margins, Fset_window_fringes)
2767 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2768 * textprop.c (Fprevious_property_change): No longer static.
2769 * syntax.c (Fsyntax_table_p): No longer static.
2770 * process.c (Fget_process, Fprocess_datagram_address): No longer
2771 static.
2772 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2773 * keyboard.c (Fcommand_execute): No longer static.
2774 Remove EXFUN.
2775 * insdel.c (Fcombine_after_change_execute): No longer static.
2776 * image.c (Finit_image_library): No longer static.
2777 * fileio.c (Fmake_symbolic_link): No longer static.
2778 * eval.c (Ffetch_bytecode): No longer static.
2779 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2780 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2781 No longer static.
404dbd37
TT
2782 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2783 static.
2784 * dired.c (Ffile_attributes): No longer static.
2785 * composite.c (Fcomposition_get_gstring): No longer static.
2786 * callproc.c (Fgetenv_internal): No longer static.
2787
2788 * ccl.h: Remove EXFUNs.
2789 * buffer.h: Remove EXFUNs.
2790 * dispextern.h: Remove EXFUNs.
2791 * intervals.h: Remove EXFUNs.
2792 * fontset.h: Remove EXFUN.
2793 * font.h: Remove EXFUNs.
2794 * dosfns.c (system_process_attributes): Remove EXFUN.
2795 * keymap.h: Remove EXFUNs.
2796 * lisp.h: Remove EXFUNs.
2797 * w32term.h: Remove EXFUNs.
2798 * window.h: Remove EXFUNs.
2799 * xsettings.h: Remove EXFUN.
2800 * xterm.h: Remove EXFUN.
2801
8e4fd1e1
GM
28022012-07-03 Glenn Morris <rgm@gnu.org>
2803
2804 * lisp.h (Frandom): Make it visible to C.
2805 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2806 buffer for invisible buffers. (Bug#1229)
2807
ca95b3eb
DA
28082012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2809
2810 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2811 values which aren't power of 2.
14ae4239
BT
2812 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2813 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2814 accordingly.
2815
7555c33f
SM
28162012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2817
2818 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2819
2820 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2821
d12e8f5a
DA
28222012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2823
2824 * alloc.c (allocate_vector_block): Remove redundant
2825 calls to mallopt if DOUG_LEA_MALLOC is defined.
2826 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2827 avoid calls to mallopt if zero_vector is returned.
2828
296094c3
DA
28292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2830
2831 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2832 is enabled, avoid dereferencing NULL current_sblock if
2833 running undumped.
2834
36429c89
DA
28352012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2836
2837 Cleanup basic buffer management.
2838 * buffer.h (struct buffer): Change layout to use generic vector
2839 marking code. Fix some comments. Change type of 'clip_changed'
2840 to bitfield. Remove unused #ifndef old.
2841 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2842 (GET_OVERLAYS_AT): Fix indentation.
2843 (for_each_per_buffer_object_at): New macro.
2844 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2845 (Fbuffer_local_variables): Use it.
2846 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2847 * alloc.c (allocate_buffer): Adjust to match new layout of
2848 struct buffer. Fix comment.
2849 (mark_overlay): New function.
2850 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2851 Lisp area of struct buffer.
2852 (mark_object): Use it. Adjust marking of misc objects
2853 and related comments.
2854
3b3e4cac
PE
28552012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2858 wrapper that is not needed because the wrapped code is a no-op (zero
2859 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2860 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2861
cf5c0175
DA
28622012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2863
2864 * alloc.c (mark_buffer): Simplify. Remove prototype.
2865 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2866 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2867 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2868 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2869
ca26824c
GM
28702012-06-30 Glenn Morris <rgm@gnu.org>
2871
2e4c5312
GM
2872 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2873
ca26824c
GM
2874 * epaths.in (PATH_SITELOADSEARCH): New.
2875 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2876 This is rather than relying on --enable-locallisppath elements
2877 having "site-lisp" in their names. (Bug#10208#25, 11658)
2878
0d23c240
EZ
28792012-06-30 Eli Zaretskii <eliz@gnu.org>
2880
c9240d7a
EZ
2881 * w32proc.c (sys_select): Accept and ignore one more argument.
2882
2883 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2884
0d23c240 2885 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2886 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2887
2888 * sysdep.c: Don't include dos.h and dosfns.h.
2889
2890 * process.c (sys_select):
2891 * msdos.c (sys_select): Accept one more argument and ignore it.
2892
2893 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2894 adapt data types and code to that.
2895
2896 * dosfns.c:
2897 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2898 which clashes with the gnulib function of the same name.
2899
af5a5a98
AS
29002012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2901
c5e4379c
AS
2902 * font.c (font_style_to_value, font_style_symbolic)
2903 (font_prop_validate_style): Add type checks for values in
2904 font_style_table.
2905
af5a5a98
AS
2906 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2907 argument.
2908 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2909 uses.
2910
8d38f461
EZ
29112012-06-29 Eli Zaretskii <eliz@gnu.org>
2912
2e5a6631
EZ
2913 * xdisp.c (try_window_id): Undo last change.
2914
8d38f461
EZ
2915 * w32.c (getwd): Adjust commentary about startup_dir.
2916 (init_environment): Always call sys_access, even in non-MSVC
2917 builds. Don't chdir to the directory of the Emacs executable.
2918 This undoes code from 1997 which was justified by the need to
2919 "avoid conflicts when removing and renaming directories". But its
2920 downside was that every relative file name was being interpreted
2921 relative to the directory of the Emacs executable, which can never
2922 be TRT. In particular, it broke sys_access when called with
2923 relative file names.
2924 (sys_access): Map GetLastError to errno.
2925
2af3565e
DA
29262012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2927
2928 * window.h (struct window): Change type of 'fringes_outside_margins'
2929 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2930 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2931 Adjust comment.
2932 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2933 to ptrdiff_t.
2934
c8d3a25c 29352012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2936
c8d3a25c
GM
2937 * gnutls.c (emacs_gnutls_handshake):
2938 Add QUIT to make the loop interruptible.
57570cd3 2939
c8d3a25c 29402012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2941
c8d3a25c
GM
2942 * charset.c (init_charset): Make lack of etc/charsets fatal.
2943
3e984ee8
DA
29442012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2945
2946 * editfns.c (region_limit): Fix type mismatch.
2947
ef884f23
DA
29482012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2949
2950 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2951 undefined. Convert from xassert to eassert.
2952 * nsmenu.m: Convert from xassert to eassert.
2953 * nsterm.m: Likewise.
2954
7d7e0027
SM
29552012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2956
2957 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2958
aa754e6a
PE
29592012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 Avoid integer overflow on scroll-left and scroll-right.
2962 * window.c (HSCROLL_MAX): New macro.
2963 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2964 overflow when requested scroll falls outside ptrdiff_t range.
2965
80b00b08
DA
29662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2967
2968 * window.h (struct window): Change type of 'hscroll',
2969 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2970 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2971 Adjust users accordingly.
2972 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2973 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2974 from EMACS_INT to ptrdiff_t.
2975 (make_window): Omit redundant initialization.
2976
62b2bcf6
JB
29772012-06-28 Juanma Barranquero <lekktu@gmail.com>
2978
2979 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2980
45942c7d
DA
29812012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2982
2983 * window.h (struct window): Change type of 'use_time' and
2984 'sequence_number' from Lisp_Object to int.
2985 * frame.c (make_frame): Adjust users accordingly.
2986 * print.c (print_object): Likewise.
2987 * window.c (select_window, Fwindow_use_time, make_parent_window)
2988 (make_window): Likewise.
2989
e509cfa6
DA
29902012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2991
2992 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2993 enabled with --enable-checking=[all,glyphs] configure option.
2994 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2995 adjust comments accordingly.
2996 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2997 undefined, adjust comments accordingly.
2998 * image.c: Likewise.
2999 * scroll.c: Likewise.
3000 * w32fns.c: Likewise.
3001 * w32term.c: Likewise.
3002 * xdisp.c: Likewise.
3003 * xfaces.c: Likewise.
3004 * xfns.c: Likewise.
3005 * xterm.c: Likewise.
3006
a54e2c05
DA
30072012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3008
3009 Generalize run-time debugging checks.
3010 * dispextern.h (XASSERTS): Remove.
3011 * fontset.c (xassert): Remove.
3012 Convert from xassert to eassert.
3013 * alloc.c: Convert from xassert to eassert.
3014 * bidi.c: Likewise.
3015 * dispnew.c: Likewise.
3016 * fns.c: Likewise.
3017 * fringe.c: Likewise.
3018 * ftfont.c: Likewise.
3019 * gtkutil.c: Likewise.
3020 * image.c: Likewise.
3021 * keyboard.c: Likewise.
3022 * menu.c: Likewise.
3023 * process.c: Likewise.
3024 * scroll.c: Likewise.
3025 * sound.c: Likewise.
3026 * term.c: Likewise.
3027 * w32console.c: Likewise.
3028 * w32fns.c: Likewise.
3029 * w32term.c: Likewise.
3030 * window.c: Likewise.
3031 * xdisp.c: Likewise.
3032 * xfaces.c: Likewise.
3033 * xfns.c: Likewise.
3034 * xselect.c: Likewise.
3035 * xterm.c: Likewise.
3036
1ec4b7b2
SM
30372012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3038
3039 * fns.c (maybe_resize_hash_table): Output message when growing the
3040 purify-hashtable.
3041
2014308a
DA
30422012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3043
3044 * alloc.c (allocate_string_data): Remove dead code.
3045 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3046 avoid GCC warning about unused macro.
3047
246155eb
DA
30482012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3049
3050 * alloc.c (allocate_string): Omit intervals initialization.
3051 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3052 as in make_pure_string and make_pure_c_string.
3053
43184b7b
DA
30542012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3055
d209e2fb 3056 * alloc.c (allocate_string): Fix last change.
43184b7b 3057
3fe6dd74
DA
30582012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3059
d209e2fb 3060 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3061 to memset, add explicit initialization where appropriate.
3062
1ba6038a
GM
30632012-06-27 Glenn Morris <rgm@gnu.org>
3064
3065 * lisp.mk (lisp): Remove paths.elc.
3066
c89926a5
CY
30672012-06-27 Chong Yidong <cyd@gnu.org>
3068
3069 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3070
ed6b3510
JW
30712012-06-26 John Wiegley <johnw@newartisans.com>
3072
1ec4b7b2 3073 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3074 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3075
ed6b3510
JW
3076 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3077 when building with Clang.
3078
8edd4a2b
SM
30792012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3080
3081 * eval.c (Fapply): Allow calling it with a single argument.
3082
f6f62d1b
EZ
30832012-06-26 Eli Zaretskii <eliz@gnu.org>
3084
3085 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3086 _stricmp and _strnicmp.
3087 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3088
62efea5e
DA
30892012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3090
3091 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3092 allocated window.
3093 (allocate_process): Likewise for new process.
8edd4a2b 3094 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3095 (allocate_frame): Likewise.
3096 * frame.c (make_frame): Omit redundant initialization.
3097 * window.c (make_parent_window): Use memset.
3098 (make_window): Omit redundant initialization.
3099 * process.c (make_process): Omit redundant initialization.
3100 * terminal.c (create_terminal): Likewise.
3101
42997f4d
DA
31022012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3103
3104 * term.c (delete_tty): Remove redundant call to memset.
3105
1130ecfc
DA
31062012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3107
3108 * alloc.c: Remove build_string.
3109 * lisp.h: Define build_string as static inline. This provides
3110 a better opportunity to optimize away calls to strlen when the
3111 function is called with compile-time constant argument.
3112 * image.c (imagemagick_error): Convert to build_string.
3113 * w32proc.c (sys_spawnve): Likewise.
3114 * xterm.c (x_term_init): Likewise.
3115
cf38a720
PE
31162012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3117
99027bdd
PE
3118 Use sprintf return value instead of invoking strlen on result.
3119 In the old days this wasn't portable, since some sprintf
3120 implementations returned char *. But they died out years ago and
3121 Emacs already assumes sprintf returns int.
3122 Similarly for float_to_string.
3123 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3124 * ccl.c (ccl_driver):
3125 * character.c (string_escape_byte8):
3126 * data.c (Fnumber_to_string):
3127 * doprnt.c (doprnt):
3128 * print.c (print_object):
3129 * xdisp.c (message_dolog):
3130 * xfns.c (syms_of_xfns):
3131 Use sprintf or float_to_string result to avoid need to call strlen.
3132 * data.c (Fnumber_to_string):
3133 Use make_unibyte_string, since the string must be ASCII.
3134 * lisp.h, print.c (float_to_string): Now returns int length.
3135 * term.c (produce_glyphless_glyph):
3136 Use sprintf result rather than recomputing it.
3137
cf38a720
PE
3138 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3139 * Makefile.in (ALL_CFLAGS):
3140 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3141 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3142
3511c784
DA
31432012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3144
0a08eb21 3145 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3146 strcasecmp if available.
3147 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3148
fb7da12e
AS
31492012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3150
3151 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3152 Avoid comma operator.
3153 * menu.c (push_submenu_start, push_submenu_end)
3154 (push_left_right_boundary, push_menu_pane): Likewise.
3155 * msdos.c (dos_rawgetc): Likewise.
3156
afa2ffd8
DA
31572012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3158
3159 * xfns.c (xic_create_fontsetname): Remove redundant calls
3160 to memset.
3161
b3b4476b
PE
31622012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3163
4495ff38
PE
3164 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3165 sprintf already null-terminates its output.
3166
b3b4476b
PE
3167 * xfns.c (x_window): Remove redundant cast.
3168
b00876c9
DA
31692012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3170
3171 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3172 `const char *' to `char *' to avoid compiler warning.
3173
d188e26b
PE
31742012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3175
885d1d74
PE
3176 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3177 instead of truncating it to 63 (admittedly a generous limit).
3178
d188e26b
PE
3179 * process.c: Fix spelling and caps in comments.
3180
e2f560b1
DN
31812012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3182
e86db54b 3183 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3184 * sysdep.c (setpgrp): Remove definition, not used in this file.
3185
7583a3a1
JB
31862012-06-24 Juanma Barranquero <lekktu@gmail.com>
3187
3188 * makefile.w32-in: Update dependencies.
3189
696056c2
EZ
31902012-06-24 Eli Zaretskii <eliz@gnu.org>
3191
3192 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3193 (SYSTIME_H): Add nt/inc/sys/time.h.
3194
3195 * systime.h [WINDOWSNT]: Include sys/time.h.
3196
3197 * s/ms-w32.h (struct timespec): Definition moved from
3198 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3199
845ca893
PE
32002012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3203 * buffer.h (buffer_slot_type_mismatch):
3204 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3205 * eval.c (unwind_to_catch):
3206 * image.c (my_png_error, my_error_exit):
3207 * keyboard.c (quit_throw_to_read_char, user_error)
3208 (Fexit_recursive_edit, Fabort_recursive_edit):
3209 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3210 (wrong_type_argument, buffer_overflow, __executable_start)
3211 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3212 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3213 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3214 (fatal):
3215 (child_setup) [!DOS_NT]:
3216 * lread.c (end_of_file_error, invalid_syntax):
3217 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3218 * puresize.h (pure_write_error):
3219 * search.c (matcher_overflow):
3220 * sound.c (sound_perror, alsa_sound_perror):
3221 * sysdep.c, syssignal.h (croak):
3222 * term.c (maybe_fatal, vfatal):
3223 * textprop.c (text_read_only):
3224 * undo.c (user_error):
3225 * unexmacosx.c (unexec_error):
3226 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3227 Use _Noreturn rather than NO_RETURN.
3228 No need for separate decl merely because of _Noreturn.
3229 * sound.c (sound_warning, parse_sound):
3230 Remove unnecessary forward decls.
3231
f1dd8073
PE
32322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3233
3234 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3235 * lisp.h (WAIT_READING_MAX): New macro.
3236 * dispnew.c (Fsleep_for, sit_for):
3237 * keyboard.c (kbd_buffer_get_event):
3238 * process.c (Faccept_process_output):
3239 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3240 This improves on the previous patch, which introduced a bug
3241 when time_t is unsigned and as wide as intmax_t.
3242 See <http://bugs.gnu.org/9000#51>.
3243
b82c1755
EZ
32442012-06-23 Eli Zaretskii <eliz@gnu.org>
3245
3246 * dispnew.c (sit_for, Fsleep_for):
3247 * keyboard.c (kbd_buffer_get_event):
3248 * process.c (Faccept_process_output): Avoid compiler warnings when
3249 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3250
ca300656
JB
32512012-06-23 Juanma Barranquero <lekktu@gmail.com>
3252
049ec95b
JB
3253 * makefile.w32-in: Update dependencies.
3254
ca300656
JB
3255 * w32.c (ltime): Add return type and declare static.
3256 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3257
db7b8d06
PE
32582012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3261 Privately reported by Herbert J. Skuhra.
3262 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3263 All uses changed.
3264 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3265 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3266
0bd8297f
EZ
32672012-06-23 Eli Zaretskii <eliz@gnu.org>
3268
96512555
EZ
3269 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3270 last argument of make_unibyte_string.
3271
0bd8297f
EZ
3272 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3273 language ID in the event parameters.
3274
3275 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3276 event.code, not the obscure "character set ID".
3277
63def6b6
CY
32782012-06-23 Chong Yidong <cyd@gnu.org>
3279
3280 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3281
e8a02204
EZ
32822012-06-23 Eli Zaretskii <eliz@gnu.org>
3283
388cdec0
EZ
3284 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3285 * w32.c (fdutimens): New function.
3286
3287 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3288
3289 * s/ms-w32.h (pselect): Redirect to sys_select.
3290
3291 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3292
e8a02204
EZ
3293 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3294 in the logic of incrementing and decrementing the value of
3295 use_relocatable_buffers.
3296
d054f3fb
PE
32972012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3298
3299 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3300 Privately reported by Herbert J. Skuhra.
3301 [__FreeBSD__]: Remove "*/" typo after "#include".
3302 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3303 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3304 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3305 Don't assume EMACS_TIME and struct timeval are the same type.
3306
d35af63c
PE
33072012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 Support higher-resolution time stamps (Bug#9000).
3310 The time stamps are only nanosecond-resolution at the C level,
3311 since that's the best that any real-world system supports now.
3312 But they are picosecond-resolution at the Lisp level, as that's
3313 easy, and leaves room for future OS improvements.
3314
3315 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3316 (LIBES): Use it.
3317
3318 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3319 Don't get current time unless it's needed.
3320
3321 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3322 now provides it if it's absent.
3323 (start_atimer): Port to higher-res time stamps.
3324 Check for time stamp overflow. Don't get current time more
3325 often than is needed.
3326
3327 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3328 Include systime.h, not time.h.
3329 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3330
3331 * dired.c: Include stat-time.h.
3332 (Ffile-attributes): File times now have higher resolution.
3333
3334 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3335 (struct image): Timestamp now has higher resolution.
3336
3337 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3338 has at least microseconds now. All uses removed.
3339 (update_frame, update_single_window, update_window, update_frame_1)
3340 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3341
3342 * editfns.c (time_overflow): Now extern.
3343 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3344 (float-time, Fformat_time_string, Fcurrent_time_string)
3345 (Fcurrent_time_zone): Accept and generate higher-resolution
3346 time stamps.
3347 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3348 (decode_time_components, lisp_seconds_argument): New functions.
3349 (make_time): Now static.
3350 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3351 Report an error if the time is invalid, rather than having the caller
3352 do that.
3353
3354 * fileio.c: Include <stat-time.h>
3355 (Fcopy_file): Copy higher-resolution time stamps.
3356 Prefer to set the time stamp via a file descriptor if that works.
3357 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3358 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3359 (Fvisited_file_modtime, Fset_visited_file_modtime):
3360 Support higher-resolution time stamps.
3361
3362 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3363
3364 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3365
3366 * image.c (prepare_image_for_display, clear_image_cache)
3367 (lookup_image): Port to higer-resolution time stamps.
3368
3369 * keyboard.c (start_polling, bind_polling_period):
3370 Check for time stamp overflow.
3371 (read_char, kbd_buffer_get_event, timer_start_idle)
3372 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3373 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3374 Port to higher-resolution time stamps. Do not assume time_t is signed.
3375 (decode_timer): New function. Timers are now vectors of length 9,
3376 not 8, to accommodate the picosecond component.
3377 (timer_check_2): Use it.
3378
3379 * nsterm.m (select_timeout, timeval_subtract): Remove.
3380 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3381 as they're a bit more accurate and handle overflow better.
3382 (ns_select): Change prototype to be compatible with pselect.
3383 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3384 * nsterm.h (ns_select): Adjust prototype.
3385
3386 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3387 us-resolution time stamps.
3388 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3389
3390 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3391
3392 * lisp.h (time_overflow): New decl.
3393 (wait_reading_process_output): First arg is now intmax_t, not int,
3394 to accommodate larger waits.
3395
3396 * process.h (struct Lisp_Process.read_output_delay):
3397 Now counts nanoseconds, not microseconds.
3398 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3399 EMACS_HAS_USECS.
3400 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3401 (wait_reading_process_output):
3402 Port to ns-resolution time stamps.
3403 (Faccept_process_output, wait_reading_process_output):
3404 Check for time stamp overflow. Do not assume time_t is signed.
3405 (select_wrapper): Remove; we now use pselect.
3406 (Fprocess_attributes): Now generates ns-resolution time stamps.
3407
3408 * sysdep.c: Include utimens.h. Don't include utime.h
3409 or worry about struct utimbuf; gnulib does that for us now.
3410 (gettimeofday): Remove; gnulib provides a substitute.
3411 (make_timeval): New function.
3412 (set_file_times): Now sets ns-resolution time stamps.
3413 New arg FD; all uses changed.
3414 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3415 (system_process_attributes):
3416 Now returns ns-resolution time stamp. All uses changed.
3417 Check for time stamp overflow.
3418
3419 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3420 provides a substitute now.
3421
3422 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3423 since it guarantees struct timespec.
3424 (EMACS_TIME): Now struct timespec, so that we can support
3425 ns-resolution time stamps.
3426 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3427 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3428 (EMACS_USECS): Remove.
3429 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3430 so multiply the arg by 1000 before storing it.
3431 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3432 New macros.
3433 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3434 Port to ns-resolution time stamps.
3435 (EMACS_TIME_NEG_P): Remove; replaced by....
3436 (EMACS_TIME_SIGN): New macro.
3437 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3438 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3439 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3440 (make_timeval, make_lisp_time, decode_time_components): New decls.
3441 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3442 that it mishandled time_t overflow. You can't compare by subtracting!
3443 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3444 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3445
3446 * term.c: Include <sys/time.h>.
3447 (timeval_to_Time): New function, for proper overflow wraparound.
3448 (term_mouse_position, term_mouse_click): Use it.
3449
3450 * undo.c (record_first_change): Support higher-resolution time stamps
3451 in the undo buffer.
3452 (Fprimitive_undo): Use them when restoring time stamps.
3453
3454 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3455 (w32_get_internal_run_time):
3456 Port to higher-resolution Emacs time stamps.
3457 (ltime): Now accepts single 64-bit integer, as that's more convenient
3458 for callers.
3459
3460 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3461
3462 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3463 for compatibility with pselect. Support ns-resolution time stamps.
3464
3465 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3466
3467 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3468 Check for time stamp overflow, and support ns-resolution time stamps.
3469
3470 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3471 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3472 (timeval_subtract): Remove; no longer needed.
3473 (XTflash, XTring_bell, x_wait_for_event):
3474 Port to ns-resolution time stamps. Don't assume time_t is signed.
3475
b6a92dfe
CY
34762012-06-22 Chong Yidong <cyd@gnu.org>
3477
3478 * xdisp.c (x_consider_frame_title): Revert last change.
3479
d251c37c
EZ
34802012-06-22 Eli Zaretskii <eliz@gnu.org>
3481
3482 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3483 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3484 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3485 staticidx goes up to 1597 out of 1600 = 0x640.)
3486
f10deafb
PE
34872012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3488
3489 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3490 Otherwise, the umask might be mistakenly 0 while handling input signals.
3491
ec6de1e2
SM
34922012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3493
3494 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3495
28be1ada
DA
34962012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3497
3498 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3499 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3500 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3501 access to `contents' member of Lisp_Vector objects with AREF and ASET
3502 where appropriate.
3503
c6bf3022
CY
35042012-06-19 Chong Yidong <cyd@gnu.org>
3505
3506 * frame.c (delete_frame): When selecting a frame on a different
3507 text terminal, do not alter the terminal's top-frame.
3508
3509 * xdisp.c (format_mode_line_unwind_data): Record the target
3510 frame's selected window and its terminal's top-frame.
3511 (unwind_format_mode_line): Restore them.
3512 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3513 Callers changed.
3514 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3515 since tty frames can be explicitly named.
3516 (prepare_menu_bars): Likewise.
3517
3518 * term.c (Ftty_top_frame): New function.
3519
defd4196
PE
35202012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 Port byte-code-meter to modern targets.
3523 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3524 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3525 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3526 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3527 (METER_1, METER_2): Simplify.
3528
1053a871
SM
35292012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3530
3531 * data.c (Fdefalias): Return `symbol' (bug#11686).
3532
b7e8d081
MR
35332012-06-18 Martin Rudalics <rudalics@gmx.at>
3534
3535 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3536 gets killed during executing of this function (Bug#11665).
3537 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3538 (Vkill_buffer_query_functions): In doc-string say that functions
3539 run by this hook should not change the current buffer.
3540
7ea2b339
PE
35412012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 Fix recently-introduced process.c problems found by static checking.
3544 * process.c (write_queue_push, write_queue_pop, send_process):
3545 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3546 (write_queue_pop): Fix pointer signedness problem.
3547 (send_process): Remove unused local.
3548
96a313a1
CY
35492012-06-17 Chong Yidong <cyd@gnu.org>
3550
3551 * xdisp.c (redisplay_internal): No need to redisplay terminal
3552 frames that are not on top.
3553
20ca2e94
TN
35542012-06-17 Troels Nielsen <bn.troels@gmail.com>
3555
3556 * process.c (make_process): Initialize write_queue.
3557 (write_queue_push, write_queue_pop): New functions.
3558 (send_process): Use them to maintain correct ordering of process
3559 writes (Bug#10815).
3560
9a900ca9
PE
35612012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3562
310fbfa8
PE
3563 * lisp.h (eassert): Assume C89 or later.
3564 This removes the need for CHECK.
3565 (CHECK): Remove. Its comments about always evaluating its
3566 argument were confusing, as 'eassert' typically does not evaluate
3567 its argument.
3568
27bb1ca4
PE
3569 * coding.c (produce_chars): Use ptrdiff_t, not int.
3570
9a900ca9
PE
3571 * xterm.c (x_draw_underwave): Check for integer overflow.
3572 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3573
41b7f8bc 35742012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3575
3576 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3577 referenced (Bug#11583).
3578
9b0e3eba
AA
35792012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3580
3581 Implement wave-style variant of underlining.
3582 * dispextern.h (face_underline_type): New enum.
3583 (face): Add field for underline type.
3584 * nsterm.m (ns_draw_underwave): New function.
3585 (ns_draw_text_decoration): Use it.
3586 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3587 New functions.
3588 (x_draw_glyph_string): Use them.
3589 * xfaces.c (Qline, Qwave): New Lisp objects.
3590 (check_lface_attrs, merge_face_ref)
1053a871
SM
3591 (Finternal_set_lisp_face_attribute, realize_x_face):
3592 Handle wave-style underline face attributes.
9b0e3eba
AA
3593 * xterm.c (x_draw_underwave): New function.
3594 (x_draw_glyph_string): Use it.
3595
0fb52f11
JB
35962012-06-16 Juanma Barranquero <lekktu@gmail.com>
3597
3598 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3599 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3600 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3601 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3602 ($(BLD)/w32select.$(O)): Update dependencies.
3603
e5560ff7
AS
36042012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3605
3606 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3607 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3608 * character.c (_fetch_multibyte_char_p): Remove.
3609 * alloc.c: Include "character.h" before "buffer.h".
3610 * bidi.c: Likewise.
3611 * buffer.c: Likewise.
3612 * bytecode.c: Likewise.
3613 * callint.c: Likewise.
3614 * callproc.c: Likewise.
3615 * casefiddle.c: Likewise.
3616 * casetab.c: Likewise.
3617 * category.c: Likewise.
3618 * cmds.c: Likewise.
3619 * coding.c: Likewise.
3620 * composite.c: Likewise.
3621 * dired.c: Likewise.
3622 * dispnew.c: Likewise.
3623 * doc.c: Likewise.
3624 * dosfns.c: Likewise.
3625 * editfns.c: Likewise.
3626 * emacs.c: Likewise.
3627 * fileio.c: Likewise.
3628 * filelock.c: Likewise.
3629 * font.c: Likewise.
3630 * fontset.c: Likewise.
3631 * fringe.c: Likewise.
3632 * indent.c: Likewise.
3633 * insdel.c: Likewise.
3634 * intervals.c: Likewise.
3635 * keyboard.c: Likewise.
3636 * keymap.c: Likewise.
3637 * lread.c: Likewise.
3638 * macros.c: Likewise.
3639 * marker.c: Likewise.
3640 * minibuf.c: Likewise.
3641 * nsfns.m: Likewise.
3642 * nsmenu.m: Likewise.
3643 * print.c: Likewise.
3644 * process.c: Likewise.
3645 * regex.c: Likewise.
3646 * region-cache.c: Likewise.
3647 * search.c: Likewise.
3648 * syntax.c: Likewise.
3649 * term.c: Likewise.
3650 * textprop.c: Likewise.
3651 * undo.c: Likewise.
3652 * unexsol.c: Likewise.
3653 * w16select.c: Likewise.
3654 * w32fns.c: Likewise.
3655 * w32menu.c: Likewise.
3656 * window.c: Likewise.
3657 * xdisp.c: Likewise.
3658 * xfns.c: Likewise.
3659 * xmenu.c: Likewise.
3660 * xml.c: Likewise.
3661 * xselect.c: Likewise.
3662
2f07e6af
EZ
36632012-06-16 Eli Zaretskii <eliz@gnu.org>
3664
1053a871
SM
3665 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3666 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3667 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3668 row.
3669 (handle_face_prop): Use chunk-relative overlay string index when
3670 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3671 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3672 the rightmost. (Bug#11720)
2f07e6af 3673
29b83cec
AS
36742012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3675
3676 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3677 (CATEGORY_MEMBER): Enforce 1/0 value.
3678 * category.c (_temp_category_set): Remove.
3679
4c5501e9
EZ
36802012-06-16 Eli Zaretskii <eliz@gnu.org>
3681
3682 * window.c (Fdelete_other_windows_internal)
3683 (Fdelete_window_internal): Don't access frame's mouse highlight
3684 info of the initial frame. (Bug#11677)
3685
2b570124
PE
36862012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3687
e93864f9
PE
3688 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3689 Assume USE_2_TAGS_FOR_INTS.
3690 (xreload): Adjust $tagmask width to match recent lisp.h change.
3691
2b570124
PE
3692 Simplify lisp.h in minor ways that should not affect code.
3693 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3694 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3695 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3696 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3697 (INTTYPEBITS): New macro, for clarity.
3698 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3699 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3700 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3701 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3702 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3703
81755f69
JB
37042012-06-13 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3707
16192a57
GM
37082012-06-13 Glenn Morris <rgm@gnu.org>
3709
3710 * s/bsd-common.h (BSD4_3):
3711 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3712
646b5f55
AS
37132012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3714
3715 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3716 instead of union.
3717 (XLI, XIL): Define.
1053a871
SM
3718 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3719 Use them.
3720 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3721 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3722 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3723 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3724 * frame.c (delete_frame): Remove outdated comment.
3725 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3726 USE_LISP_UNION_TYPE.
3727 (Fw32_unregister_hot_key): Likewise.
3728 (Fw32_toggle_lock_key): Likewise.
3729 * w32menu.c (add_menu_item): Likewise.
3730 (w32_menu_display_help): Use XIL instead of checking
3731 USE_LISP_UNION_TYPE.
3732 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3733 (init_heap): Likewise.
3734 * w32term.c (w32_read_socket): Update comment.
3735
1d3823c9
GM
37362012-06-13 Glenn Morris <rgm@gnu.org>
3737
c62ff706
GM
3738 * s/usg5-4-common.h, src/s/unixware.h:
3739 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3740
1d3823c9
GM
3741 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3742
bfe3e0a2
PE
37432012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3744
3745 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3746 * alloc.c (make_number) [!defined make_number]:
3747 Remove, as lisp.h always defines this now.
3748 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3749 (roundup_size): Verify that it is a power of 2.
3750 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3751 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3752 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3753 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3754 USE_LSB_TAG now is always defined to be either 0 or 1.
3755 All uses changed.
3756 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3757 code works fine either way, and efficiency is not a concern here,
3758 as the union type is for debugging, not for production.
3759 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3760 Use an inline function on all platforms when using the union type,
3761 since this is simpler and 'static inline' can be used portably
3762 within Emacs now.
3763 (LISP_INITIALLY_ZERO): New macro.
3764 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3765 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3766
45fa9c0f
GM
37672012-06-12 Glenn Morris <rgm@gnu.org>
3768
b4492cba
GM
3769 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3770
3771 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3772
45fa9c0f
GM
3773 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3774 Move BROKEN_SIGIO to configure.
3775
3776 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3777 Move NO_TERMIO to configure.
3778
0e25d334
CY
37792012-06-12 Chong Yidong <cyd@gnu.org>
3780
3781 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3782 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3783 MagickExportImagePixels is undefined.
3784
43682bb6
PE
37852012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 * image.c (imagemagick_load_image): Remove unused label.
3788
a9be7d2b
GM
37892012-06-11 Glenn Morris <rgm@gnu.org>
3790
3791 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3792 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3793 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3794 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3795
3017f87f
SM
37962012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3797
3798 * alloc.c (make_byte_code): New function.
3799 (Fmake_byte_code): Use it. Don't purify here.
3800 * lread.c (read1): Use it as well to avoid extra allocation.
3801
1b9b4cf4
CY
38022012-06-11 Chong Yidong <cyd@gnu.org>
3803
3804 * image.c (imagemagick_load_image): Implement transparency.
3805
95988fcf
AS
38062012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3807
3808 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3809 account for preceding backslashes. (Bug#11663)
3810
cd4eb164
CY
38112012-06-09 Chong Yidong <cyd@gnu.org>
3812
3813 * term.c: Support italics in capable terminals (Bug#9652).
3814 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3815 (turn_on_face): Output using TS_enter_italic_mode if available.
3816 Don't handle unused blinking and alt-charset cases.
3817 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3818 and tty_alt_charset_p cases.
3819 (tty_capable_p, init_tty): Support italics.
3820
3821 * termchar.h (struct tty_display_info): Add field for italics.
3822 Remove unused blink field.
3823
3824 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3825 Handle slant.
3826
3827 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3828 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3829 tty_alt_charset_p. Add tty_italic_p.
3830
ff88beb8
MA
38312012-06-09 Michael Albinus <michael.albinus@gmx.de>
3832
3833 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3834 dbus_type_is_basic if available.
3835 (xd_extract_signed, xd_extract_unsigned): Rename from
3836 extract_signed and extract_unsigned, respectively. Adapt callers.
3837
44286096
CY
38382012-06-09 Chong Yidong <cyd@gnu.org>
3839
1682701f
CY
3840 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3841
44286096
CY
3842 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3843 case (Bug#9752).
3844
d86feb17
PE
38452012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 * xdisp.c (vmessage): Treat frame message as multibyte.
3848 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3849 would generate the diagnostic "Making \302\247 buffer-local while
3850 let-bound!".
3851
d5c20fe8
EZ
38522012-06-08 Eli Zaretskii <eliz@gnu.org>
3853
3854 * dispnew.c (showing_window_margins_p): Undo last change, which
3855 was done due to an inadvertent commit.
3856 (adjust_frame_glyphs_for_frame_redisplay): Do call
3857 showing_window_margins_p.
3858
513749ee
SM
38592012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3860
3861 * eval.c (Fmake_var_non_special): New primitive.
3862 (syms_of_eval): Defsubr it.
3863 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3864
d4a8f5c1
JB
38652012-06-08 Juanma Barranquero <lekktu@gmail.com>
3866
3867 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3868 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3869
8bbbc977
EZ
38702012-06-08 Eli Zaretskii <eliz@gnu.org>
3871
3872 * alloc.c (allocate_vectorlike): Fix last change.
3873
f3372c87
DA
38742012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3875
3876 Block-based vector allocation of small vectors.
3877 * lisp.h (struct vectorlike_header): New field `nbytes',
3878 adjust comment accordingly.
3879 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3880 to denote vector blocks. Adjust users (live_vector_p,
3881 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3882 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3883 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3884 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3885 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3886 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3887 (roundup_size): New constant.
3888 (struct vector_block): New data type.
3889 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3890 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3891 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3892 (sweep_vectors): New functions.
3893 (allocate_vectorlike): Return `zero_vector' as the only vector of
3894 0 items. Allocate new vector from block if vector size is less than
3895 or equal to VBLOCK_BYTES_MAX.
3896 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3897 (init_alloc_once): Add call to init_vectors.
3898
4f18a4ed
SM
38992012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3900
3901 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3902
86f158bc
PE
39032012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 * doprnt.c (doprnt): Truncate multibyte char correctly.
3906 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3907 would mishandle a string argument "Xc" if X was a multibyte
3908 character of length 2: it would truncate after X's first byte
3909 rather than including all of X.
3910
c5cfcbe0
CY
39112012-06-06 Chong Yidong <cyd@gnu.org>
3912
3913 * buffer.c (word_wrap): Doc fix.
3914
c05cf390
PE
39152012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3916
3917 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3918
0c3461de
GM
39192012-06-03 Glenn Morris <rgm@gnu.org>
3920
3921 * xdisp.c (tool-bar-style): Doc fix.
3922
c71232db
UM
39232012-06-03 Ulrich Müller <ulm@gentoo.org>
3924
3925 * Makefile.in (PAXCTL): Define.
3926 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3927 binary via PaX flags if the paxctl utility is available.
3928 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3929 Restore PaX flags to their default. (Bug#11398)
3930
383f7350
CY
39312012-06-03 Chong Yidong <cyd@gnu.org>
3932
3933 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3934 buffer (Bug#11226).
3935
5f2c76c6
CY
39362012-06-03 Chong Yidong <cyd@gnu.org>
3937
3938 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3939 (note_mode_line_or_margin_highlight): If there is no help echo,
3940 use mode-line-default-help-echo. Handle the case where the mouse
3941 position is past the end of the mode line string.
3942
3943 * buffer.c (buffer_local_value_1): New function, split from
3944 Fbuffer_local_value; can return Qunbound.
3945 (Fbuffer_local_value): Use it.
3946 (Vmode_line_format): Docstring tweaks.
3947
773d47f6
PE
39482012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 * sysdep.c (system_process_attributes): Improve comment.
3951
f2d6a3df
SM
39522012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3953
3954 * keyboard.c: Export real-this-command to Elisp.
3955 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3956 and DEFVAR it. Update all users.
3957
63810350
PE
39582012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3959
7bd5c1f4
PE
3960 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3961
63810350
PE
3962 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3963 Convert pctcpu and pctmem to Lisp float properly.
3964 Let the compiler fold better, as 100.0/0x8000 is exact.
3965
a2821611
AS
39662012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3967
3968 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3969 cons_block.
3970
5fceba1d
PE
39712012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3972
3973 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3974
c98ff5dd
DA
39752012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3976
3977 For a 'struct window', replace some Lisp_Object fields to
3978 bitfields where appropriate, remove unused fields.
3979 * window.h (struct window): Remove unused 'last_mark_x' and
3980 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3981 change it's type from Lisp_Object to bitfield.
3982 Change type of 'force_start', 'optional_new_start',
3983 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3984 fields from Lisp_Object to bitfield. Adjust users accordingly.
3985
ca34e0be
PE
39862012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Pacify gcc -Wdouble-precision when using Xaw.
3989 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3990 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3991 Use 'float' consistently, rather than 'float' in most places
3992 and 'double' in a couple of places.
3993
efc00ab1 39942012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3995
3996 * xdisp.c (handle_stop): Detect whether we have overlay strings
3997 loaded by testing it->current.overlay_string_index to be
3998 non-negative, instead of checking whether n_overlay_strings is
3999 positive. (Bug#11587)
4000
efc00ab1 40012012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4002
4003 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4004
4005 * doc.c (Fsubstitute_command_keys): Doc fix.
4006
efc00ab1 40072012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4008
4009 * search.c (search_buffer): Remove calls to
4010 r_alloc_inhibit_buffer_relocation, as it is now called by
4011 maybe_unify_char, which was the cause of relocation of buffer text
4012 in bug#11519.
4013
efc00ab1 40142012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4015
4016 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4017 for the duration of call to load_charset, to avoid problems with
4018 callers of maybe_unify_char that access buffer text through C
4019 pointers.
4020
4021 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4022 decrement the inhibition flag, instead of just setting or
4023 resetting it.
4024
ba93a187
PE
40252012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 Remove obsolete '#define static' cruft.
4028 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4029 This #undef was "temporary" in 2000; it is no longer needed
4030 now that '#define static' has gone away.
4031 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4032 (gray_bitmap_bits): Remove; no longer needed.
4033 All uses replaced with definiens.
4034 * xterm.c: Include "bitmaps/gray.xbm".
4035
9e4bf381
PE
40362012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4037
4038 Clean up __executable_start, monstartup when --enable-profiling.
4039 The following changes affect the code only when profiling.
4040 * dispnew.c (__executable_start): Rename from safe_bcopy.
4041 Define only on platforms that need it.
4042 * emacs.c: Include <sys/gmon.h> when profiling.
4043 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4044 (__executable_start): Remove decl, since lisp.h does it now.
4045 (safe_bcopy): Remove decl; no longer has that name.
4046 (main): Coalesce #if into single bit of code, for simplicity.
4047 Cast pointers to uintptr_t, since standard libraries want integers
4048 and not pointers.
4049 * lisp.h (__executable_start): New decl.
4050
32d72c2f
GM
40512012-05-31 Glenn Morris <rgm@gnu.org>
4052
4053 * image.c (Fimagemagick_types): Doc fix.
4054
baac5bc7
JM
40552012-05-30 Jim Meyering <meyering@redhat.com>
4056
4057 * callproc.c (Fcall_process_region): Include directory component
4058 in mkstemp error message (Bug#11586).
4059
72cb32cf
PE
40602012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4061
4062 * alloc.c, lisp.h (make_pure_vector): Now static.
4063
61b108cc
SM
40642012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4065
4066 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4067 Move to byte-run.el.
4068 (Fautoload): Do the hash-doc more carefully.
4069 * data.c (Fdefalias): Purify definition, except for keymaps.
4070 (Qdefun): Move from eval.c.
4071 * lisp.h (Qdefun): Remove.
4072 * lread.c (read1): Tiny simplification.
4073
471fe23d
TN
40742012-05-29 Troels Nielsen <bn.troels@gmail.com>
4075
934f3f58 4076 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4077 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4078 Bug#9642, but explicitly check that the buffer the overlay would
4079 be moved to is live and rearrange lines to make sure that errors
4080 will not put the overlay in an inconsistent state.
4081 (Fdelete_overlay): Cosmetics.
4082
85d0efd1
EZ
40832012-05-28 Eli Zaretskii <eliz@gnu.org>
4084
4085 * w32term.c (my_bring_window_to_top): New function.
4086 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4087 could be different from the original one.
4088 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4089 (Bug#11513)
4090
4091 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4092 by calling BringWindowToTop.
4093
4094 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4095 (WM_EMACS_END): Increase by one.
4096
da92a98c
PE
40972012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4100 This avoids undefined behavior that might cause the eassert
4101 to not catch an out-of-range value.
4102
74d1f848
JB
41032012-05-28 Juanma Barranquero <lekktu@gmail.com>
4104
4105 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4106 Update dependencies.
4107
9e1a06fc
EZ
41082012-05-27 Eli Zaretskii <eliz@gnu.org>
4109
4110 * bidi.c (bidi_mirror_char): Fix last change.
4111
f3dd7312
AS
41122012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4113
4114 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4115 when referring to sectname field in printf format.
4116
81899c91
PE
41172012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4118
57b81a9f
PE
4119 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4120 Only r_alloc_inhibit_buffer_relocation needed to be added;
4121 the others were already declared.
4122
81899c91
PE
4123 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4124 before checking whether it's out of range. Put the check inside
4125 eassert. See
4126 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4127
33017faf 41282012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4129
4130 * callproc.c (Fcall_process): Restore a line that was accidentally
4131 commented out in the 2011-02-13 change (bug#11547).
4132
33017faf 41332012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4134
4135 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4136 defined on ralloc.c.
4137
4138 * buffer.c [REL_ALLOC]: Remove prototypes of
4139 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4140 they are now on lisp.h.
4141
4142 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4143
4144 * search.c (search_buffer): Use it to inhibit relocation of buffer
4145 text while re_search_2 is doing its job, because re_search_2 is
4146 passed C pointers to buffer text. (Bug#11519)
4147
23415acf
EZ
4148 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4149 Update value to 24.
4150
44e27368
EZ
4151 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4152 state after an additional call to move_it_in_display_line_to, keep
4153 the values of it->max_ascent and it->max_descent found for the
4154 entire line.
4155 (pos_visible_p): Revert the comparison against bottom_y to what it
4156 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4157 (Bug#11464)
4158
c1892f11
PE
41592012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4160
4161 Fix coding-related core dumps with gcc -ftrapv.
4162 The code was computing A - B, where A and B are pointers, and B is
4163 random garbage. This can lead to core dumps on platforms that
4164 have special pointer registers, and it also leads to core dumps on
4165 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4166 A - B only when B is initialized properly.
4167 * coding.c (coding_set_source, coding_set_destination): Return void.
4168 (coding_change_source, coding_change_destinations): New functions,
4169 with the old behaviors of coding_set_source and coding_set_destination.
4170 All callers that need an offset changed to use these new functions.
4171
eb7afdad
GM
41722012-05-26 Glenn Morris <rgm@gnu.org>
4173
4174 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4175
f12fdf02
EZ
41762012-05-26 Eli Zaretskii <eliz@gnu.org>
4177
53a63be6 4178 Extend mouse support on W32 text-mode console.
61b108cc
SM
4179 * xdisp.c (draw_row_with_mouse_face):
4180 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4181
eb3f6f01 4182 * w32console.c: Include window.h.
61b108cc
SM
4183 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4184 New functions.
eb3f6f01
EZ
4185 (initialize_w32_display): Initialize mouse-highlight data.
4186
53a63be6
EZ
4187 * w32inevt.c: Include termchar.h and window.h.
4188 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4189 moves, call note_mouse_highlight. If help_echo changed, call
4190 gen_help_event to produce help-echo message in the echo area.
4191 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4192 highlight info.
4193
4cfd81f6
PE
41942012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4195
4196 * lread.c (read1): Simplify slightly to avoid an overflow warning
4197 with GCC 4.7.0 on x86-64.
4198
4446092a
EZ
41992012-05-26 Eli Zaretskii <eliz@gnu.org>
4200
4201 * bidi.c (bidi_mirror_char): Revert last change: an int is
4202 definitely wide enough here.
4203
42b2a986 42042012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4205
42b2a986 4206 Fix integer width and related bugs (Bug#9874).
eb106a49 4207 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4208 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4209 (string_bytes, check_sblock, allocate_string_data):
4210 (compact_small_strings, Fmake_bool_vector, make_string)
4211 (make_unibyte_string, make_multibyte_string)
4212 (make_string_from_bytes, make_specified_string)
4213 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4214 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4215 (mark_vectorlike):
4216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4217 (allocate_pseudovector):
4218 Use int, not EMACS_INT, where int is wide enough.
4219 (inhibit_garbage_collection, Fgarbage_collect):
4220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4221 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4222 int might not be wide enough.
4223 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4224 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4225 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4226 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4227 (bidi_level_of_next_char, bidi_move_to_visually_next):
4228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4229 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4230 (Fkill_buffer, Fset_buffer_major_mode)
4231 (advance_to_char_boundary, Fbuffer_swap_text)
4232 (Fset_buffer_multibyte, overlays_at, overlays_in)
4233 (overlay_touches_p, struct sortvec, record_overlay_string)
4234 (overlay_strings, recenter_overlay_lists)
4235 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4236 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4237 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4238 (Foverlay_recenter, last_overlay_modification_hooks_used)
4239 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4241 (validate_region): Omit unnecessary test for b <= e,
4242 since that's guaranteed by the previous test.
d311d28c
PE
4243 (adjust_overlays_for_delete): Avoid pos + length overflow.
4244 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4245 (report_overlay_modification):
4246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4247 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4248 Omit pointer cast, which isn't needed anyway, and doesn't work
4249 after the EMACS_INT -> ptrdiff_t change.
02481186 4250 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4251 * buffer.h: Adjust decls to match defn changes elsewhere.
4252 (struct buffer_text, struct buffer):
4253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4254 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4255 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4256 not int, to avoid needless 32-bit limit on 64-bit hosts.
4257 (exec_byte_code): Use tighter memory-full test, one that checks
4258 for alloca overflow. Don't compute the address of the object just
4259 before an array, as that's not portable. Use EMACS_INT, not
4260 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4261 * callint.c (Fcall_interactively):
4262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4263 * callproc.c (call_process_kill, Fcall_process):
4264 Don't assume pid_t fits into an Emacs fixnum.
4265 (call_process_cleanup, Fcall_process, child_setup):
4266 Don't assume pid_t fits into int.
4267 (call_process_cleanup, Fcall_process, delete_temp_file)
4268 (Fcall_process_region):
4269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4270 (Fcall_process): Simplify handling of volatile integers.
4271 Use int, not EMACS_INT, where int will do.
4272 * casefiddle.c (casify_object, casify_region, operate_on_word)
4273 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4275 (casify_object): Avoid integer overflow when overallocating buffer.
4276 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4277 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4278 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4279 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4280 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4281 integers are now checked earlier. All uses replaced with XINT.
4282 (ccl_driver):
4283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4284 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4285 (ccl_driver, Fregister_code_conversion_map):
4286 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4287 (resolve_symbol_ccl_program): Check that vector header is in range.
4288 Always copy the vector, so that we can check its contents reliably
4289 now rather than having to recheck each instruction as it's being
4290 executed. Check that vector words fit in 'int'.
4291 (ccl_get_compiled_code, Fregister_ccl_program)
4292 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4293 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4294 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4295 contents are in range.
4296 (Fccl_execute_on_string): Check that status is in range.
4297 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4298 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4299 Accept and return EMACS_INT, not int, because callers can pass values
4300 out of 'int' range.
4301 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4302 (multibyte_chars_in_text, parse_str_as_multibyte)
4303 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4304 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4305 (string_escape_byte8, Fget_byte):
4306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4307 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4308 avoid mishandling large integers.
4309 * character.h: Adjust decls to match defn changes elsewhere.
4310 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4311 (Ffind_charset_region):
4312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4313 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4314 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4315 Don't assume fixnum fits in int.
d311d28c
PE
4316 (load_charset_map_from_vector, Fmap_charset_chars):
4317 Remove now-unnecessary CHECK_NATNUMs.
4318 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4319 Don't rely on undefined behavior with signed left shift overflow.
4320 Don't assume unsigned int fits into fixnum, or that fixnum fits
4321 into unsigned int. Don't require max_code to be a valid fixnum;
4322 that's not true for gb10830 4-byte on a 32-bit host. Allow
4323 invalid_code to be a cons, for the same reason. Require code_offset
4324 to be a character. Avoid int overflow if max_char is close
4325 to INT_MAX.
4326 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4327 this is intended anyway and avoids some undefined behavior.
4328 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4329 INDEX_TO_CODE_POINT, as that's what it expects.
4330 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4331 * charset.h (DECODE_CHAR): Return int, not unsigned;
4332 this is what was intended anyway, and it avoids undefined behavior.
4333 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4334 integer-overflow issues.
4335 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4336 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4337 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4338 * chartab.c (Fmake_char_table, Fset_char_table_range)
4339 (uniprop_get_decoder, uniprop_get_encoder):
4340 Don't assume fixnum fits in int.
4341 * cmds.c (move_point): New function, that does the gist of
4342 Fforward_char and Fbackward_char, but does so while checking
4343 for integer overflow more accurately.
c96e5d6a 4344 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4345 (Fforward_line, Fend_of_line, internal_self_insert)
4346 (internal_self_insert):
4347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4348 Fix a FIXME, by checking for integer overflow when calculating
4349 target_clm and actual_clm.
4350 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4351 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4352 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4353 (coding_alloc_by_making_gap, alloc_destination)
4354 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4355 (encode_coding_utf_16, detect_coding_emacs_mule)
4356 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4357 (detect_coding_iso_2022, decode_coding_iso_2022)
4358 (encode_invocation_designation, encode_designation_at_bol)
4359 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4360 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4361 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4362 (encode_coding_ccl, encode_coding_raw_text)
4363 (detect_coding_charset, decode_coding_charset)
4364 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4365 (produce_composition, produce_charset, produce_annotation)
4366 (decode_coding, handle_composition_annotation)
4367 (handle_charset_annotation, consume_chars, decode_coding_gap)
4368 (decode_coding_object, encode_coding_object, detect_coding_system)
4369 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4370 (code_convert_region, code_convert_string)
8f50130c
PE
4371 (Fdefine_coding_system_internal)
4372 (coding_set_source, coding_set_destination):
d311d28c
PE
4373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4374 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4375 (Fdefine_coding_system_internal):
4376 Don't assume fixnums fit in int.
4377 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4378 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4379 (Funencodable_char_position, Fcheck_coding_systems_region)
4380 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4382 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4383 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4384 Don't access memory outside of the args array.
d311d28c 4385 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4386 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4387 result of ENCODE_CHAR.
d311d28c
PE
4388 * coding.h: Adjust decls to match defn changes elsewhere.
4389 (struct coding_system):
4390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4391 * composite.c (get_composition_id, find_composition)
4392 (run_composition_function, update_compositions)
4393 (compose_text, composition_gstring_put_cache)
4394 (composition_gstring_p, composition_gstring_width)
4395 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4396 (composition_compute_stop_pos, composition_reseat_it)
4397 (composition_update_it, struct position_record)
4398 (find_automatic_composition, composition_adjust_point)
4399 (Fcomposition_get_gstring, Ffind_composition_internal):
4400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4401 (update_compositions):
4402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4403 * composite.h: Adjust decls to match defn changes elsewhere.
4404 (struct composition):
4405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4406 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4407 Do not attempt to compute the address of the object just before a
4408 buffer; this is not portable.
4409 (Faref, Faset):
4410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4411 (Faset): Use int, not EMACS_INT, where int is wide enough.
4412 (Fstring_to_number): Don't assume fixnums fit in int.
4413 (Frem): Don't assume arg is nonnegative.
4414 * dbusbind.c (xd_append_arg): Check for integers out of range.
4415 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4416 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4417 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4418 (xd_get_connection_references): Return ptrdiff_t, not int.
4419 All uses changed.
4420 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4421 (xd_read_message_1):
4422 Use int, not unsigned, where the dbus API uses int.
4423 (Fdbus_message_internal): Don't overflow mtype.
4424 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4425 * dired.c (directory_files_internal, file_name_completion, scmp)
4426 (file_name_completion_stat):
4427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4428 (file_name_completion): Don't overflow matchcount.
4429 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4430 * dispextern.h: Adjust decls to match defn changes elsewhere.
4431 (struct text_pos, struct glyph, struct bidi_saved_info)
4432 (struct bidi_string_data, struct bidi_it, struct composition_it)
4433 (struct it):
4434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4435 (struct display_pos, struct composition_it, struct it):
4436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4437 * dispnew.c (increment_matrix_positions)
4438 (increment_row_positions, mode_line_string)
4439 (marginal_area_string):
4440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4441 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4443 (duration_to_sec_usec): New function, to check for overflow better.
4444 (Fsleep_for, sit_for): Use it.
4445 * doc.c (get_doc_string, store_function_docstring):
4446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4447 (get_doc_string, Fsnarf_documentation):
4448 Use int, not EMACS_INT, where int is wide enough.
4449 (get_doc_string):
4450 Use SAFE_ALLOCA, not alloca.
4451 Check for overflow when converting EMACS_INT to off_t.
4452 * doprnt.c (doprnt):
4453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4454 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4455 Don't assume uid_t fits into fixnum.
4456 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4457 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4458 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4459 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4460 (general_insert_function)
4461 (Finsert_char, make_buffer_string, make_buffer_string_both)
4462 (update_buffer_properties, Fbuffer_substring)
4463 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4464 (Fsubst_char_in_region, check_translation)
4465 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4466 (transpose_markers, Ftranspose_regions):
4467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4468 (clip_to_bounds): Move to lisp.h as an inline function).
4469 (Fconstrain_to_field): Don't assume integers are nonnegative.
4470 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4471 (Fsubst_char_in_region, Fsave_restriction):
4472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4473 (Femacs_pid): Don't assume pid_t fits into fixnum.
4474 (lo_time): Use int, not EMACS_INT, when int suffices.
4475 (lisp_time_argument): Check for usec out of range.
4476 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4477 (Fuser_login_name, Fuser_full_name): Signal an error
4478 if a uid argument is out of range, rather than relying on
4479 undefined behavior.
c8d5c857
PE
4480 (Fformat_time_string): Remove now-unnecessary check.
4481 lisp_time_argument checks for out-of-range usec now.
243e0530 4482 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4483 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4484 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4485 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4486 (init_cmdargs, Fdump_emacs):
4487 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4488 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4489 the bottom (typically) 32 bits of the fixnum.
4490 * eval.c (specpdl_size, call_debugger):
4491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4492 (when_entered_debugger, Fbacktrace_debug):
4493 Don't assume fixnum can fit in int.
4494 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4495 the object just before a buffer; this is not portable.
4496 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4497 (grow_specpdl, unbind_to):
4498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4499 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4500 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4501 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4502 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4503 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4505 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4506 (a_write, e_write):
4507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4508 (Fcopy_file, non_regular_nbytes, read_non_regular)
4509 (Finsert_file_contents):
4510 Use int, not EMACS_INT, where int is wide enough.
4511 (READ_BUF_SIZE): Verify that it fits in int.
4512 (Finsert_file_contents): Check that counts are in proper range,
4513 rather than assuming fixnums fit into ptrdiff_t etc.
4514 Don't assume fixnums fit into int.
125b3835 4515 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4516 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4517 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4518 (string_char_to_byte, string_byte_to_char)
4519 (string_make_multibyte, string_to_multibyte)
4520 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4521 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4522 (substring_both, Fdelete, internal_equal, Ffillarray)
4523 (Fclear_string, mapcar1)
4524 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4525 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4526 (larger_vector, make_hash_table, maybe_resize_hash_table)
4527 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4528 (Fmaphash, secure_hash):
4529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4530 (concat): Check for string index and length overflow.
4531 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4532 (Frequire):
4533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4534 (larger_vector): New API (vec, incr_min, size_max) replaces old
4535 one (vec, new_size, init). This catches size overflow.
4536 INIT was removed because it was always Qnil.
4537 All callers changed.
4538 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4539 the upper bound on a hash table index size.
4540 (make_hash_table, maybe_resize_hash_table): Use it.
4541 (secure_hash): Computer start_byte and end_byte only after
4542 they're known to be in ptrdiff_t range.
4543 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4544 (Ffont_get_glyphs, Ffont_at):
4545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4546 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4547 (Flist_fonts, Fopen_font):
4548 Don't assume fixnum can fit in int.
4549 (check_gstring): Don't assume index can fit in int.
4550 (font_match_p): Check that fixnum is a character, not a nonnegative
4551 fixnum, since the later code needs to stuff it into an int.
4552 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4553 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4554 conversion overflow issues.
4555 (Fopen_font): Check for integer out of range.
4556 (Ffont_get_glyphs): Don't assume index can fit in int.
4557 * font.h: Adjust decls to match defn changes elsewhere.
4558 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4559 integer overflow.
4560 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4561 printmax_t, where ptrdiff_t is wide enough.
4562 (Finternal_char_font):
4563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4564 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4565 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4566 (Fset_frame_position, x_set_frame_parameters)
4567 (x_set_line_spacing, x_set_border_width)
4568 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4569 Check that fixnums are in proper range for system types.
4570 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4572 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4573 Use SAFE_ALLOCA_LISP, not alloca.
4574 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4575 intptr_t is wide enough.
4576 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4577 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4578 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4579 Check for fixnum out of range.
4580 * ftfont.c (ftfont_list): Don't assume index fits in int.
4581 Check that fixnums are in proper range for system types.
4582 (ftfont_shape_by_flt):
4583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4584 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4586 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4587 Check that fixnums are in proper range for system types.
4588 * gnutls.h: Adjust decls to match defn changes elsewhere.
4589 * gtkutil.c (xg_dialog_run):
4590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4591 (update_frame_tool_bar):
4592 Check that fixnums are in proper range for system types.
4593 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4594 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4595 * indent.c (last_known_column, last_known_column_point):
4596 (current_column_bol_cache):
4597 (skip_invisible, current_column, check_display_width):
4598 (check_display_width, scan_for_column, current_column_1)
4599 (Findent_to, Fcurrent_indentation, position_indentation)
4600 (indented_beyond_p, Fmove_to_column, compute_motion):
4601 (Fcompute_motion, Fvertical_motion):
4602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4603 (last_known_column_modified): Use EMACS_INT, not int.
4604 (check_display_width):
4605 (Fcompute_motion):
4606 Check that fixnums and floats are in proper range for system types.
4607 (compute_motion): Don't assume index or fixnum fits in int.
4608 (compute_motion, Fcompute_motion):
4609 Use int, not EMACS_INT, when it is wide enough.
4610 (vmotion): Omit local var start_hpos that is always 0; that way
4611 we don't need to worry about overflow in expressions involving it.
4612 * indent.h: Adjust decls to match defn changes elsewhere.
4613 (struct position):
4614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4615 Use int, not EMACS_INT, where int is wide enough.
4616 Remove unused members ovstring_chars_done and tab_offset;
4617 all uses removed.
4618 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4619 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4620 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4621 (make_gap, copy_text, insert, insert_and_inherit)
4622 (insert_before_markers, insert_before_markers_and_inherit)
4623 (insert_1, count_combining_before, count_combining_after)
4624 (insert_1_both, insert_from_string)
4625 (insert_from_string_before_markers, insert_from_string_1)
4626 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4627 (adjust_after_replace, adjust_after_insert, replace_range)
4628 (replace_range_2, del_range, del_range_1, del_range_byte)
4629 (del_range_both, del_range_2, modify_region)
4630 (prepare_to_modify_buffer, signal_before_change)
4631 (signal_after_change, Fcombine_after_change_execute):
4632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4633 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4634 (balance_an_interval, split_interval_right, split_interval_left)
4635 (find_interval, next_interval, update_interval)
4636 (adjust_intervals_for_insertion, delete_node, delete_interval)
4637 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4638 (static_offset_intervals, offset_intervals)
4639 (merge_interval_right, merge_interval_left, make_new_interval)
4640 (graft_intervals_into_buffer, temp_set_point_both)
4641 (temp_set_point, set_point, adjust_for_invis_intang)
4642 (set_point_both, move_if_not_intangible, get_property_and_range)
4643 (get_local_map, copy_intervals, copy_intervals_to_string)
4644 (compare_string_intervals, set_intervals_multibyte_1):
4645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4646 * intervals.h: Adjust decls to match defn changes elsewhere.
4647 (struct interval):
4648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4649 * keyboard.c (this_command_key_count, this_single_command_key_start)
4650 (before_command_key_count, before_command_echo_length, echo_now)
4651 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4652 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4653 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4654 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4656 (last_non_minibuf_size, last_point_position, echo_truncate)
4657 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4658 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4659 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4660 (stuff_buffered_input):
4661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4662 (last_auto_save, command_loop_1, read_char):
4663 Use EMACS_INT, not int, to avoid integer overflow.
4664 (record_char): Avoid overflow in total_keys computation.
4665 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4666 * keyboard.h: Adjust decls to match defn changes elsewhere.
4667 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4668 (Fkey_description, Fdescribe_vector, Flookup_key):
4669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4670 (click_position): New function, to check that positions are in range.
4671 (Fcurrent_active_maps):
4672 (describe_command):
4673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4674 (Faccessible_keymaps, Fkey_description):
4675 (preferred_sequence_p):
4676 Don't assume fixnum can fit into int.
4677 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4678 Check for integer overflow in size calculations.
4679 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4680 avoid mishandling large integers.
4681 * lisp.h: Adjust decls to match defn changes elsewhere.
4682 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4683 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4684 (struct Lisp_Marker):
4685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4686 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4687 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4688 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4689 All callers changed.
4690 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4691 Assume the arg has valid form, since it always does.
4692 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4693 unsigned integer system type.
4694 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4695 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4697 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4698 (duration_to_sec_usec): New decl.
4699 * lread.c (read_from_string_index, read_from_string_index_byte)
4700 (read_from_string_limit, readchar, unreadchar, openp)
4701 (read_internal_start, read1, oblookup):
4702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4703 (Fload, readevalloop, Feval_buffer, Feval_region):
4704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4705 (openp): Check for out-of-range argument to 'access'.
4706 (read1): Use int, not EMACS_INT, where int is wide enough.
4707 Don't assume fixnum fits into int.
6efdadfd 4708 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4709 (read_filtered_event): Use duration_to_sec_usec
4710 to do proper overflow checking on durations.
d311d28c
PE
4711 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4712 in size calculation.
4713 (Fexecute_kbd_macro):
4714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4715 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4716 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4717 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4718 (set_marker_both, set_marker_restricted_both, marker_position)
4719 (marker_byte_position, Fbuffer_has_markers_at):
4720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4721 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4722 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4723 It now merely ensures that the menu is large enough, without
4724 necessarily growing it, as this avoids some integer overflow issues.
4725 All callers changed.
4726 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4728 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4729 Use SAFE_ALLOCA_LISP, not alloca.
4730 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4731 to EMACS_INT. Check that fixnums are in proper range for system types.
4732 * minibuf.c (minibuf_prompt_width, string_to_object)
4733 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4734 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4736 (get_minibuffer, read_minibuf_unwind):
4737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4738 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4739 this simplifies overflow checking. All callers changed.
4740 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4741 (Ftest_completion):
4742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4743 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4744 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4745 Check that fixnums are in proper range for system types.
4746 (Fx_create_frame, Fx_show_tip):
4747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4748 * nsfont.m (ns_findfonts, nsfont_list_family):
4749 Don't assume fixnum fits in long.
4750 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4752 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4753 wide enough.
17fdb222 4754 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4756 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4757 (PRINTDECLARE, PRINTPREPARE):
4758 (strout, print_string):
4759 (print, print_preprocess, print_check_string_charset_prop)
4760 (print_object):
4761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4762 (PRINTDECLARE):
4763 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4765 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4766 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4767 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4768 (print_error_message): Use SAFE_ALLOCA, not alloca.
4769 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4770 (print_depth, new_backquote_output, print_number_index):
4771 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4772 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4773 (Fset_process_window_size, Fformat_network_address)
4774 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4775 (sigchld_handler):
d311d28c 4776 Check that fixnums are in proper range for system types.
d44287d4 4777 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4778 Check for process-ids out of pid_t range rather than relying on
4779 undefined behavior.
e4d81efc 4780 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4781 (Fformat_network_address, read_process_output, send_process)
4782 (Fprocess_send_region, status_notify):
4783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4784 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4785 (wait_reading_process_output, read_process_output, exec_sentinel):
4786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4787 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4788 (Faccept_process_output): Use duration_to_sec_usec to do proper
4789 overflow checking on durations.
dde14581
PE
4790 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4791 Don't assume pid_t fits in int.
02481186
PE
4792 * process.h (struct Lisp_Process): Members tick and update_tick
4793 are now of type EMACS_INT, not int.
b62b53e8
PE
4794 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4795 configured --with-wide-int.
d311d28c
PE
4796 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4797 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4798 * search.c (looking_at_1, string_match_1):
4799 (fast_string_match, fast_c_string_match_ignore_case)
4800 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4801 (scan_newline, find_before_next_newline, search_command)
4802 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4803 (set_search_regs, wordify):
4804 (Freplace_match):
4805 (Fmatch_data):
4806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4807 (string_match_1, search_buffer, set_search_regs):
4808 (Fmatch_data):
4809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4810 (wordify): Check for overflow in size calculation.
4811 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4812 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4813 Check that fixnums are in proper range for system types.
4814 * sound.c (struct sound_device)
4815 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4817 (Fplay_sound_internal):
4818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4819 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4820 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4821 (Fparse_partial_sexp):
4822 Don't assume fixnums can fit in int.
4823 (struct lisp_parse_state, find_start_pos, find_start_value)
4824 (find_start_value_byte, find_start_begv)
4825 (update_syntax_table, char_quoted, dec_bytepos)
4826 (find_defun_start, prev_char_comend_first, back_comment):
4827 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4828 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4830 (Finternal_describe_syntax_value): Check that match_lisp is a
4831 character, not an integer, since the code stuffs it into int.
4832 (scan_words, scan_sexps_forward):
4833 Check that fixnums are in proper range for system types.
4834 (Fforward_word):
4835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4836 (scan_sexps_forward):
4837 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4838 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4839 * syntax.h: Adjust decls to match defn changes elsewhere.
4840 (struct gl_state_s):
4841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4842 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4843 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4844 * sysdep.c (wait_for_termination_1, wait_for_termination)
4845 (interruptible_wait_for_termination, mkdir):
4846 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4847 (emacs_read, emacs_write):
4848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4849 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4850 and double all fit in int.
d311d28c
PE
4851 * term.c (set_tty_color_mode):
4852 Check that fixnums are in proper range for system types.
4853 * termhooks.h (struct input_event):
4854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4855 * textprop.c (validate_interval_range, interval_of)
4856 (Fadd_text_properties, set_text_properties_1)
4857 (Fremove_text_properties, Fremove_list_of_text_properties)
4858 (Ftext_property_any, Ftext_property_not_all)
4859 (copy_text_properties, text_property_list, extend_property_ranges)
4860 (verify_interval_modification):
4861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4862 (Fnext_single_char_property_change)
4863 (Fprevious_single_char_property_change):
4864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4865 (copy_text_properties):
4866 Check for integer overflow in index calculation.
d311d28c
PE
4867 * undo.c (last_boundary_position, record_point, record_insert)
4868 (record_delete, record_marker_adjustment, record_change)
4869 (record_property_change):
4870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4871 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4873 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4874 (Fx_hide_tip, Fx_file_dialog):
4875 * w32menu.c (set_frame_menubar):
4876 Use ptrdiff_t, not int, for consistency with rest of code.
4877 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4878 (select_window, Fdelete_other_windows_internal)
4879 (window_scroll_pixel_based, window_scroll_line_based)
4880 (Frecenter, Fset_window_configuration):
4881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4882 (Fset_window_hscroll, run_window_configuration_change_hook)
4883 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4884 (Fscroll_other_window, Frecenter):
d311d28c
PE
4885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4886 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4887 Don't assume fixnum fits in int.
4888 (Fset_window_scroll_bars):
4889 Check that fixnums are in proper range for system types.
4890 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4891 (string_pos, c_string_pos, number_of_chars, init_iterator)
4892 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4893 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4894 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4895 (face_before_or_after_it_pos, handle_invisible_prop)
4896 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4897 (display_prop_intangible_p, string_buffer_position_lim)
4898 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4899 (get_overlay_strings_1, get_overlay_strings)
4900 (iterate_out_of_display_property, forward_to_next_line_start)
4901 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4902 (get_next_display_element, set_iterator_to_next)
4903 (get_visually_first_element, compute_stop_pos_backwards)
4904 (handle_stop_backwards, next_element_from_buffer)
4905 (move_it_in_display_line_to, move_it_in_display_line)
4906 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4907 (add_to_log, message_dolog, message_log_check_duplicate)
4908 (message2, message2_nolog, message3, message3_nolog
4909 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4910 (current_message_1, truncate_echo_area, truncate_message_1)
4911 (set_message, set_message_1, store_mode_line_noprop)
4912 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4913 (text_outside_line_unchanged_p, check_point_in_composition)
4914 (reconsider_clip_changes)
4915 (redisplay_internal, set_cursor_from_row, try_scrolling)
4916 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4917 (redisplay_window, find_last_unchanged_at_beg_row)
4918 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4919 (trailing_whitespace_p, find_row_edges, display_line)
4920 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4921 (display_mode_element, store_mode_line_string)
4922 (pint2str, pint2hrstr, decode_mode_spec)
4923 (display_count_lines, display_string, draw_glyphs)
4924 (x_produce_glyphs, x_insert_glyphs)
4925 (rows_from_pos_range, mouse_face_from_buffer_pos)
4926 (fast_find_string_pos, mouse_face_from_string_pos)
4927 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4929 (safe_call, init_from_display_pos, handle_fontified_prop)
4930 (handle_single_display_spec, load_overlay_strings)
4931 (with_echo_area_buffer, setup_echo_area_for_printing)
4932 (display_echo_area, echo_area_display)
4933 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4934 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4935 (redisplay_window, dump_glyph_row, display_mode_line)
4936 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4937 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4939 (handle_single_display_spec, build_desired_tool_bar_string)
4940 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4941 (get_specified_cursor_type):
4942 Check that fixnums are in proper range for system types.
4943 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4944 (Flookup_image_map):
4945 Don't assume fixnums fit in int.
4946 (compare_overlay_entries):
4947 Avoid mishandling comparisons due to subtraction overflow.
4948 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4949 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4950 (handle_tool_bar_click):
4951 Use int, not unsigned, since we prefer signed and the signedness
4952 doesn't matter here.
4953 (get_next_display_element, next_element_from_display_vector):
4954 Use int, not EMACS_INT, when int is wide enough.
4955 (start_hourglass): Use duration_to_sec_usec to do proper
4956 overflow checking on durations.
4957 * xfaces.c (Fbitmap_spec_p):
4958 Check that fixnums are in proper range for system types.
4959 (compare_fonts_by_sort_order):
4960 Avoid mishandling comparisons due to subtraction overflow.
4961 (Fx_family_fonts, realize_basic_faces):
4962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4963 (Fx_family_fonts):
4964 Don't assume fixnum fits in int.
4965 Use SAFE_ALLOCA_LISP, not alloca.
4966 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4967 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4968 (face_at_buffer_position, face_for_overlay_string)
4969 (face_at_string_position):
4970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4971 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4972 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4973 (Fx_show_tip):
4974 Check that fixnums are in proper range for system types.
4975 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4976 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4977 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4978 (Fx_change_window_property): Don't assume fixnums fit in int.
4979 * xfont.c (xfont_chars_supported):
4980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4981 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4982 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4984 * xml.c (parse_region):
4985 * xrdb.c (magic_file_p):
4986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4987 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4988 (x_get_local_selection, x_reply_selection_request)
4989 (x_handle_selection_request, wait_for_property_change):
4990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4991 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4992 short is wide enough.
4993 (x_send_client_event): Don't assume fixnum fits in int.
4994 * xterm.c (x_x_to_emacs_modifiers):
4995 Don't assume EMACS_INT overflows nicely into int.
4996 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4997 may come from Lisp.
4998 (handle_one_xevent): NATNUMP can eval its arg twice.
4999 (x_connection_closed):
5000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5001 * xterm.h: Adjust decls to match defn changes elsewhere.
5002 (struct scroll_bar): Use struct vectorlike_header
5003 rather than rolling our own approximation.
5004 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5005
c6574eb5
GM
50062012-05-25 Glenn Morris <rgm@gnu.org>
5007
5008 * lisp.mk (lisp): Update for more files being compiled now.
5009
e8d32c7e
SM
50102012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5011
48def666
SM
5012 * lread.c: Remove `read_pure' which makes no difference.
5013 (read_pure): Remove var.
5014 (unreadpure): Remove function.
5015 (readevalloop): Don't call read_list with -1 flag.
5016 (read1, read_vector): Don't test read_pure any more.
5017 (read_list): Simplify.
5018
e8d32c7e
SM
5019 * fileio.c, character.h: Minor style tweaks.
5020
4b2addb7
DA
50212012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5022
5023 * window.h (clip_changed): Remove useless declaration.
5024
584461b2
JB
50252012-05-22 Juanma Barranquero <lekktu@gmail.com>
5026
5027 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5028 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5029
34374650
PE
50302012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5031
5032 Remove src/m/*.
5033 This directory predates autoconf and is no longer needed nowadays.
5034 Move its few remaining bits of functionality to where they're needed.
5035 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5036 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5037 * m/template.h: Remove.
5038 * Makefile.in (M_FILE): Remove. All uses removed.
5039 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5040 * lisp.h (USE_LSB_TAG):
5041 * mem-limits.h (EXCEEDS_LISP_PTR):
5042 Use VAL_MAX, not VALBITS, in #if.
5043 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5044 (EMACS_UINT): Define unconditionally now.
5045 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5046 (BITS_PER_EMACS_INT): New constants, replacing
5047 what used to be in config.h, but not useful in #if.
5048 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5049 define them any more.
5050 (VAL_MAX): New macro.
5051 (VALMASK): Use it.
5052 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5053 BITS_PER_EMACS_INT, in #if.
5054 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5055 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5056 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5057 * s/ms-w32.h (DATA_START):
5058 Move here from removed file m/intel386.h.
5059 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5060 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5061
261cb4bb
PE
50622012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5063
5064 Assume C89 or later.
5065 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5066 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5067 (xrealloc):
5068 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5069 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5070 * textprop.c, tparam.c (NULL): Remove.
5071 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5072 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5073 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5074 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5075 * xterm.c (input_signal_count): Assume volatile works.
5076
ff23cd9f
KB
50772012-05-21 Ken Brown <kbrown@cornell.edu>
5078
5079 * xgselect.c (xg_select): Fix first argument in call to 'select'
5080 (bug#11508).
5081
1b170bc6
KB
50822012-05-20 Ken Brown <kbrown@cornell.edu>
5083
5084 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5085 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5086
b2f4d39f
KB
50872012-05-19 Ken Brown <kbrown@cornell.edu>
5088
5089 * xfns.c (x_in_use): Remove `static' qualifier.
5090 * xterm.h (x_in_use): Declare.
5091 * xgselect.c: Include xterm.h.
5092 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5093 and `display_arg' (bug#9754).
5094
003fdae2
PE
50952012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5096
9232a6d9
PE
5097 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5098
003fdae2
PE
5099 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5100 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5101
784b56e2
EZ
51022012-05-18 Eli Zaretskii <eliz@gnu.org>
5103
5104 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5105
5106 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5107 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5108
5109 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5110 reference to image_cache->refcount.
5111 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5112
a0a79cde
JL
51132012-05-17 Juri Linkov <juri@jurta.org>
5114
5115 * search.c (Fword_search_regexp, Fword_search_backward)
5116 (Fword_search_forward, Fword_search_backward_lax)
5117 (Fword_search_forward_lax): Move functions to isearch.el
5118 (bug#10145, bug#11381).
5119
b0572523
PE
51202012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5121
5122 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5123
9660f5fc
SM
51242012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5125
5126 * lread.c (init_obarray): Declare Qt and Qnil as special.
5127
4374de83
GM
51282012-05-14 Glenn Morris <rgm@gnu.org>
5129
5130 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5131 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5132
dc44c39a
PE
51332012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5134
078c97cb
PE
5135 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5136
dc44c39a
PE
5137 * unexaix.c: Port to more-recent AIX compilers.
5138 (report_error, report_error_1, make_hdr, copy_sym)
5139 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5140 Make arguments const char *, not char *, to avoid violations of C
5141 standard and to fix some AIX warnings reported by Gilles Pion.
5142
e18afed7 51432012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5144
5145 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5146 already have overlays loaded.
5147 (handle_single_display_spec): Before returning without displaying
5148 fringe bitmap, synchronize the bidi iterator with the main display
5149 iterator, by calling iterate_out_of_display_property.
5150 (iterate_out_of_display_property): Detect buffer iteration by
5151 testing that it->string is a Lisp string.
5152 (get_next_display_element): When the current object is exhausted,
5153 and there's something on it->stack, call set_iterator_to_next to
5154 proceed with what's on the stack, instead of returning zero.
5155 (set_iterator_to_next): If called at the end of a Lisp string,
5156 proceed to consider_string_end without incrementing string
5157 position. Don't increment display vector index past the end of
5158 the display vector. (Bug#11417)
c8fb9dc6
EZ
5159 (pos_visible_p): Don't report a position visible when move_it_to
5160 stopped at the last line of window, which happens to be scanned
5161 backwards by the bidi iteration. (Bug#11464)
ac268e67 5162
e18afed7 51632012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5164
5165 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5166 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5167 are on a TTY, and thus unable to display on the fringes.
5168 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5169 so we need to signal to the caller that this is a "replacing"
5170 display spec. This fixes display when the spec is invalid or we
5171 are on a TTY.
5172
e18afed7 51732012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5174
5175 * unexaix.c (make_hdr): Fix typo in prototype.
5176 This bug broke the build on AIX. Problem reported by Gilles Pion.
5177
9d0a235a
MA
51782012-05-14 Michael Albinus <michael.albinus@gmx.de>
5179
5180 * keyboard.c (kbd_buffer_get_event): Read special events also in
5181 batch mode. (Bug#11415)
5182
9e6b06ed
GM
51832012-05-12 Glenn Morris <rgm@gnu.org>
5184
5185 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5186
c1a1d7a3
EZ
51872012-05-12 Eli Zaretskii <eliz@gnu.org>
5188
5189 * lisp.mk (lisp): Add newcomment.elc.
5190
3fe7cdc8
GM
51912012-05-12 Glenn Morris <rgm@gnu.org>
5192
5193 * Makefile.in (MKDIR_P): New, set by configure.
5194 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5195
53f7d2c0
PE
51962012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5197
5198 Remove unused function hourglass_started.
5199 * dispextern.h (hourglass_started):
5200 * w32fns.c (hourglass_started):
5201 * xdisp.c (hourglass_started): Remove.
5202
75aafb17
JB
52032012-05-10 Juanma Barranquero <lekktu@gmail.com>
5204
5205 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5206 Update dependencies.
5207
12959e8e
PE
52082012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5209
97107e2e
PE
5210 * xgselect.c (xg_select): Put maxfds+1 into a var.
5211 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5212
12959e8e
PE
5213 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5214
836d29b3
DA
52152012-05-10 Dave Abrahams <dave@boostpro.com>
5216
5217 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5218 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5219
5cb67954
MA
52202012-05-09 Michael Albinus <michael.albinus@gmx.de>
5221
5222 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5223 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5224 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5225 Initialize xd_registered_buses.
5226
3478ec45
PE
52272012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5228
b263a6b0
PE
5229 Untag more efficiently if USE_LSB_TAG.
5230 This is based on a proposal by YAMAMOTO Mitsuharu in
5231 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5232 For an admittedly artificial (nth 8000 longlist) benchmark on
5233 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5234 Emacs's overall text size by 1%.
5235 * lisp.h (XUNTAG): New macro.
5236 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5237 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5238 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5239 * eval.c (Fautoload):
5240 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5241 * frame.h (XFRAME): Use XUNTAG.
5242
3478ec45
PE
5243 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5244 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5245 Remove unportable assumptions about print widths of types like
5246 dbus_uint32_t.
5247 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5248 intptr_t when converting between pointer and integer, to avoid GCC
5249 warnings about wrong width.
5250
666b903b 52512012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5252
5253 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5254 stack for each reader_thread, instead of defaulting to 8MB
5255 determined by the linker. This avoids failures in creating
5256 subprocesses on Windows 7, see the discussion in this thread:
5257 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5258
b120cc17
JC
52592012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5260
5261 Fix up display of the *Minibuf-0* buffer in the mini window.
5262 * keyboard.c (read_char): Don't clear the echo area if there's no
5263 message to clear.
5264 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5265 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5266
9a4b36f8
MA
52672012-05-07 Michael Albinus <michael.albinus@gmx.de>
5268
5269 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5270 batch mode.
5271
e5f9458f
CY
52722012-05-06 Chong Yidong <cyd@gnu.org>
5273
5274 * lisp.mk (lisp): Update.
5275
eceeb5fc 52762012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5277
5278 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5279
71873e2b
SM
52802012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5281
5282 * data.c (PUT_ERROR): New macro.
5283 (syms_of_data): Use it. Add new error type `user-error'.
5284 * undo.c (user_error): New function.
5285 (Fprimitive_undo): Use it.
5286 * print.c (print_error_message): Adjust print style for `user-error'.
5287 * keyboard.c (user_error): New function.
5288 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5289
ab0fa4e4
PE
52902012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5291
5292 Do not limit current-time-string to years 1000..9999.
5293 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5294 (Fcurrent_time_string): Support any year that is supported by the
5295 underlying localtime representation. Don't use asctime, as it
5296 has undefined behavior for years outside the range -999..9999.
5297
7ed806a7
PE
52982012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5299
5300 Fix race conditions involving setenv, gmtime, localtime, asctime.
5301 Without this fix, interrupts could mess up code that uses these
5302 nonreentrant functions, since setting TZ invalidates existing
5303 tm_zone or tzname values, and since most of these functions return
5304 pointers to static storage.
5305 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5306 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5307 Grow the critical sections to include not just invoking
5308 localtime/gmtime, but also accessing these functions' results
5309 including their tm_zone values if any, and any related TZ setting.
5310 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5311 so that the struct tm is saved in the critical section.
5312 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5313 motivated by the fact that memory allocation needs to be outside
5314 the critical section.
5315
0c16dfed
DA
53162012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5317
5318 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5319 with RESET_INTERVAL.
5320
5321 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5322 Remove duplicated buffer name initialization.
5323
3f83ace8
JM
53242012-05-02 Jim Meyering <jim@meyering.net>
5325
5326 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5327
c7b8541e
JM
5328 * xfns.c (x_window): Use xstrdup (Bug#11375).
5329
90207a15 53302012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5331
5332 * xdisp.c (pos_visible_p): If already at a newline from the
5333 display string before the 'while' loop, don't walk back the glyphs
5334 from it3.glyph_row. Solves assertion violation when the display
5335 string begins with a newline (egg.el). (Bug#11367)
5336
b593d6a9
AH
53372012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5338
5339 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5340 Move to simple.el.
5341
4737362e
GM
53422012-05-01 Glenn Morris <rgm@gnu.org>
5343
99cf43f9
GM
5344 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5345 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5346 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5347 All were removed before 23.1.
5348
9311dcff
GM
5349 * dispnew.c: Remove HAVE_LIBNCURSES test;
5350 it is always true on relevant platforms.
5351
4d5c6349
GM
5352 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5353 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5354
4737362e
GM
5355 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5356
74dd3a6b
AS
53572012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5358
5359 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5360 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5361 Remove.
5362
13c379ee
PE
53632012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5364
5365 Do not avoid creating empty evaporating overlays (Bug#9642).
5366 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5367 That is, do not delete an evaporating overlay if it becomes
5368 empty after its bounds are adjusted to fit within its buffer.
5369 This fix caused other problems, and I'm reverting it until we get
5370 to the bottom of them.
5371
a8e7d6d7 53722012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5373
5374 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5375
a8e7d6d7 53762012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5377
5378 * xdisp.c (pos_visible_p): If the window start position is beyond
5379 ZV, start the display from buffer beginning. Prevents assertion
5380 violation in init_iterator when the minibuffer window is scrolled
5381 via the scroll bar.
5382
5383 * window.c (window_scroll_pixel_based): Likewise.
5384
a8e7d6d7 53852012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5386
5387 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5388
a8e7d6d7 53892012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5390
5391 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5392 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5393
a8e7d6d7 53942012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5395
b593d6a9
AH
5396 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5397 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5398
1c6900d9
EZ
53992012-04-26 Eli Zaretskii <eliz@gnu.org>
5400
4c3fa1d9
EZ
5401 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5402 display element, check also the underlying string or buffer
5403 character. (Bug#11341)
5404
1c6900d9
EZ
5405 * w32menu.c: Include w32heap.h.
5406 (add_menu_item): If the call to AppendMenuW (via
5407 unicode_append_menu) fails, disable Unicode menus only if we are
5408 running on Windows 9X/Me.
5409
42bf8205
AS
54102012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5411
5412 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5413 (xgetint): Add missing shift for LSB tags.
5414
b1bac16e
MR
54152012-04-24 Martin Rudalics <rudalics@gmx.at>
5416
5417 * keyboard.c (read_char): Don't wipe echo area for select window
5418 events: These might get delayed via `mouse-autoselect-window'
5419 (Bug#11304).
5420
d69621cc
JB
54212012-04-24 Juanma Barranquero <lekktu@gmail.com>
5422
5423 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5424 manipulation of :loaded-from data.
5425
02fd101b
JB
54262012-04-23 Juanma Barranquero <lekktu@gmail.com>
5427
5428 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5429 now a cons (bug#11311).
5430
888bec30
PE
54312012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5432
89a438bd
PE
5433 Do not create empty overlays with the evaporate property (Bug#9642).
5434 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5435 if it becomes empty after its bounds are adjusted to fit within
5436 its buffer. Without this fix, in a nonempty buffer (let ((o
5437 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5438 yields an empty overlay that has the evaporate property, which is
5439 not supposed to happen.
5440
1068fe4d
PE
5441 Fix minor GTK3 problems found by static checking.
5442 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5443 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5444 (struct _EmacsFixedClass, emacs_fixed_get_type):
5445 Move decls here from emacsgtkfixed.h, since they needn't be public.
5446 (emacs_fixed_get_type): Now static.
5447 (emacs_fixed_class_init): Omit unused local.
5448 (emacs_fixed_child_type): Remove; unused.
5449 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5450 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5451 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5452 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5453 (EMACS_FIXED_GET_CLASS): Remove; unused.
5454 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5455
888bec30
PE
5456 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5457 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5458
de85e130
PE
54592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5460
d0baac98 5461 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5462 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5463 (__malloc_size_t, __malloc_ptrdiff_t):
5464 Remove. All uses removed, replaced by the definiens if needed,
5465 since we can assume C89 or better now.
5466 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5467 (protect_malloc_state, align, get_contiguous_space)
5468 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5469 (malloc_atfork_handler_child, malloc_enable_thread)
5470 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5471 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5472 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5473 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5474 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5475 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5476 Define using prototypes, not old style.
5477 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5478 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5479 (align): Don't assume that signed integer overflow wraps around.
5480 Omit unused local var.
5481 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5482 (_free_internal_nolock, memalign, mallochook, reallochook):
5483 Omit no-longer-needed casts.
5484 (valloc): Use getpagesize, not __getpagesize.
5485 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5486 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5487
de85e130
PE
5488 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5489
dcbf5805
MA
54902012-04-22 Michael Albinus <michael.albinus@gmx.de>
5491
5492 Move functions from C to Lisp. Make non-blocking method calls
5493 the default. Implement further D-Bus standard interfaces.
5494
5495 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5496 (QCdbus_request_name_allow_replacement)
5497 (QCdbus_request_name_replace_existing)
5498 (QCdbus_request_name_do_not_queue)
5499 (QCdbus_request_name_reply_primary_owner)
5500 (QCdbus_request_name_reply_in_queue)
5501 (QCdbus_request_name_reply_exists)
5502 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5503 (QCdbus_registered_serial, QCdbus_registered_method)
5504 (QCdbus_registered_signal): New Lisp objects.
5505 (XD_DEBUG_MESSAGE): Use sizeof.
5506 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5507 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5508 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5509 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5510 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5511 (xd_signature, xd_append_arg): Allow float for integer types.
5512 (xd_get_connection_references): New function.
b593d6a9
AH
5513 (xd_get_connection_address): Rename from xd_initialize.
5514 Return cached address.
dcbf5805
MA
5515 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5516 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5517 level.
5518 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5519 Return number of refcounts.
dcbf5805
MA
5520 (Fdbus_get_unique_name): Make stronger parameter check.
5521 (Fdbus_message_internal): New defun.
5522 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5523 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5524 (Fdbus_send_signal, Fdbus_register_service)
5525 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5526 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5527 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5528 (Vdbus_compiled_version, Vdbus_runtime_version)
5529 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5530 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5531 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5532 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5533 Adapt docstring.
dcbf5805 5534
52828e02
PE
55352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5536
da05bc4c
PE
5537 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5538 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5539 Do not assume ptrdiff_t is the same width as 'int'.
5540
52828e02
PE
5541 * alloc.c: Handle unusual debugging option combinations.
5542 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5543 since the two debugging options are incompatible.
5544 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5545 is defined.
5546 (mem_init, mem_insert, mem_insert_fixup):
5547 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5548 (NEED_MEM_INSERT): Remove; no longer needed.
5549
f01769f9
LL
55502012-04-22 Leo Liu <sdl.web@gmail.com>
5551
5552 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5553
5790543d
PE
55542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5555
5556 * sysdep.c [__FreeBSD__]: Minor cleanups.
5557 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5558 Use Emacs indenting style more consistently. Avoid some casts.
5559 Use 'double' consistently rather than mixing 'float' and 'double'.
5560
b91b7e4d
EW
55612012-04-21 Eduard Wiebe <usenet@pusto.de>
5562
b593d6a9
AH
5563 * sysdep.c (list_system_processes, system_process_attributes):
5564 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5565
6114eb15
AS
55662012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5567
5568 * lisp.mk (lisp): Update.
5569
2f38dff7
PE
55702012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5573 It is never used otherwise.
5574
4ae29f89
SM
55752012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5576
5577 * print.c (print_preprocess): Only check print_depth if print-circle
5578 is nil.
5579 (print_object): Check for cycles even when print-circle is nil and
5580 print-gensym is t, but only check print_depth if print-circle is nil.
5581
f30d612a
CY
55822012-04-20 Chong Yidong <cyd@gnu.org>
5583
5584 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5585 set the status to "failed" and ensure that sentinel is run.
5586
c07a4c0b 55872012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5588
5589 * process.c (Fset_process_inherit_coding_system_flag)
5590 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5591 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5592
c07a4c0b 55932012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5594
5595 * xdisp.c (string_buffer_position_lim): Limit starting position to
5596 BEGV.
5597 (set_cursor_from_row): If called for a mode-line or header-line
5598 row, return zero immediately.
5599 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5600 farther than the first row after the header line, if any.
5601 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5602 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5603
c07a4c0b 56042012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5605
4ae29f89
SM
5606 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5607 (bug#11238).
ad3a2b41 5608
c07a4c0b 56092012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 56102012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5611
5612 configure: new option --enable-gcc-warnings (Bug#11207)
5613 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5614 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5615 (ALL_CFLAGS): Use new macros rather than old.
5616 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5617 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5618 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5619 -Wunused-result, -Wunused-variable. This should go away once
5620 the Emacs and Gnulib regex code is merged.
5621 (xmalloc, xrealloc): Now static.
5622
aba027e8
PE
56232012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5624
5625 * dired.c (Fsystem_groups): Remove unused local.
5626
e5a36063
GM
56272012-04-17 Glenn Morris <rgm@gnu.org>
5628
5629 * dired.c (Fsystem_users): Doc fix.
5630
316411f0
DA
56312012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5632
5633 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5634 (syms_of_dired): Add them.
5635
9426aba4
PE
56362012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5637
b62a57be
PE
5638 Fix minor alloc.c problems found by static checking.
5639 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5640 New extern decls, to avoid calling undeclared functions.
5641 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5642 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5643 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5644 (NEED_MEM_INSERT): New macro.
5645 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5646 Remove one incorrect comment and fix another.
b62a57be 5647
3539f31f
PE
5648 Fix minor ralloc.c problems found by static checking.
5649 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5650 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5651 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5652 (r_alloc_sbrk): Now static.
5653
a041960a
PE
5654 Improve ralloc.c interface checking.
5655 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5656 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5657 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5658 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5659 [REL_ALLOC]: ... to here, to check interface.
5660 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5661 Remove decls. This fixes an "It stinks!".
5662
9426aba4
PE
5663 * alloc.c (which_symbols): Fix alignment issue / type clash.
5664
d55c12ed
AS
56652012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5666
5667 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5668 (struct Lisp_Misc_Any): Likewise.
5669 (struct Lisp_Free): Likewise.
5670 * alloc.c (union aligned_Lisp_Symbol): Define.
5671 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5672 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5673 (union aligned_Lisp_Misc): Define.
5674 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5675 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5676 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5677
b948ce8b
PE
56782012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5679
5680 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5681 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5682 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5683 * s/netbsd.h, s/sol2-6.h:
5684 Remove definition of GC_MARK_STACK, since the default now works.
5685 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5686 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5687 no longer the default.
5688 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5689
35dc09a1 56902012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5691
35dc09a1
GM
5692 * lread.c (lisp_file_lexically_bound_p):
5693 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5694
35dc09a1
GM
56952012-04-14 Eli Zaretskii <eliz@gnu.org>
5696
5697 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5698 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5699
57002012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5701
5702 * nsterm.m (constrainFrameRect): Always constrain when there is only
5703 one screen (Bug#10962).
5704
bcd86815
KB
57052012-04-13 Ken Brown <kbrown@cornell.edu>
5706
5707 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5708
c25df26e
RT
57092012-04-13 Reuben Thomas <rrt@sc3d.org>
5710
5711 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5712
0fc59f1e
DC
57132012-04-11 Daniel Colascione <dancol@dancol.org>
5714
5715 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5716 against is gone. It's better to use vfork now so that when Cygwin
5717 gains a new, working vfork, we use it automatically (bug#10398).
5718
de8c03dc
SM
57192012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5720
5721 * window.c (save_window_save): Obey window-point-insertion-type.
5722
2f097256
GM
57232012-04-11 Glenn Morris <rgm@gnu.org>
5724
5725 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5726
453b951e
SM
57272012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5728
5729 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5730
75f1671a 57312012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5732
5733 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5734 (force_quit_count): New var.
5735 (handle_interrupt): Use it.
5736
2a8ce227
JB
57372012-04-10 Juanma Barranquero <lekktu@gmail.com>
5738
5739 * w32.c (w32_delayed_load): Record the full path of the library
5740 being loaded (bug#10424).
5741
935396c0
GM
57422012-04-09 Glenn Morris <rgm@gnu.org>
5743
05920a43
GM
5744 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5745 not just in the obarray, before snarfing them. (Bug#11036)
5746
935396c0
GM
5747 * Makefile.in ($(leimdir)/leim-list.el):
5748 Pass EMACS rather than BUILT_EMACS.
5749
a18ecafa
TZ
57502012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5751
5752 * process.c (make_process):
5753 * process.h: Add integer `gnutls_handshakes_tried' member to
5754 process struct.
5755
6bbef4e5
JC
5756 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5757 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5758
5759 * gnutls.c (gnutls_log_function2i): Convenience log function.
5760 (emacs_gnutls_read): Use new log functions,
5761 `gnutls_handshakes_tried' process member, and
5762 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5763 attempts per process (connection).
5764
b4d3bc10
CY
57652012-04-09 Chong Yidong <cyd@gnu.org>
5766
5767 * eval.c (Fuser_variable_p, user_variable_p_eh)
5768 (lisp_indirect_variable): Functions deleted.
5769 (Fdefvar): Caller changed.
5770
5771 * callint.c (Finteractive, Fcall_interactively):
5772 * minibuf.c (Fread_variable): Callers changed.
5773
70f4d973
EZ
57742012-04-09 Eli Zaretskii <eliz@gnu.org>
5775
5776 * xdisp.c (set_cursor_from_row): If the display string appears in
5777 the buffer at position that is closer to point than the position
5778 after the display string, display the cursor on the first glyph of
5779 the display string. Fixes cursor display when a 'display' text
5780 property immediately follows invisible text. (Bug#11094)
5781
cb3c2e3e
PE
57822012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5783
5784 composite.c: use 'double' consistently
5785 * composite.c (get_composition_id): Use 'double' consistently
5786 instead of converting 'float' to 'double' and vice versa; this is
5787 easier to understand and avoids a GCC warning.
5788
fd06db5d
GM
57892012-04-09 Glenn Morris <rgm@gnu.org>
5790
50fe702a
GM
5791 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5792 preparation for dumping it with emacs. (Bug#4789)
5793 (leimdir): New variable.
5794 ($(leimdir)/leim-list.el): New rule.
5795 (emacs$(EXEEXT)): Depend on leim-list.el.
5796
fd06db5d
GM
5797 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5798 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5799 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5800
55c131ee
AS
58012012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5802
5803 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5804 proper alignment.
5805
9209588f
JB
58062012-04-07 Juanma Barranquero <lekktu@gmail.com>
5807
5808 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5809 Remove unused local variable.
5810
e3fb2efb
PE
58112012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5812
5813 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5814 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5815 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5816 objects, as mark_maybe_pointer will catch them otherwise.
5817 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5818 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5819
b5385551
PE
58202012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5821
5822 Fix typo that broke non-Windows builds.
5823 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5824
9078ead6
EZ
58252012-04-07 Eli Zaretskii <eliz@gnu.org>
5826
5827 Support building on MS-Windows with libxml2.
5828
5829 * makefile.w32-in (OBJ2): Add xml.$(O).
5830 (GLOBAL_SOURCES): Add xml.c.
5831 ($(BLD)/xml.$(O)): New dependency list.
5832
5833 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5834 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5835 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5836 [!WINDOWSNT]: New macros.
5837 (init_libxml2_functions, libxml2_loaded_p): New functions.
5838 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5839 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5840 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5841 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5842 linked in).
6bbef4e5
JC
5843 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5844 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5845 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5846
5847 * emacs.c: Don't include libxml/parser.h.
5848 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5849 xmlCleanupParser directly.
5850
5851 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5852
3811fdf3
EZ
58532012-04-07 Eli Zaretskii <eliz@gnu.org>
5854
5855 * indent.c (Fvertical_motion): If there is a display string at
5856 point, use it.vpos to compute how many lines to backtrack after
5857 move_it_to point. (Bug#11133)
5858
2f8e16b2
EZ
58592012-04-06 Eli Zaretskii <eliz@gnu.org>
5860
5861 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5862 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5863 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5864 macros related to unification of CJK characters. For the details,
5865 see the discussion following the message here:
5866 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5867
3d439cd1
CY
58682012-04-04 Chong Yidong <cyd@gnu.org>
5869
5870 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5871
8bc53d00
EZ
58722012-04-01 Eli Zaretskii <eliz@gnu.org>
5873
5874 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5875 instead of alloca. (Bug#11138)
5876
3b0512a3
AS
58772012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5878
5879 * w32menu.c (is_simple_dialog): Properly check lisp types.
5880 (Bug#11141)
5881
8427ddd2
EZ
58822012-03-31 Eli Zaretskii <eliz@gnu.org>
5883
979022ef
EZ
5884 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5885 position we get to after a call to move_it_to fails the
5886 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5887 only if we wind up in a string from display property. (Bug#11063)
5888
a6b1c7cc
EZ
5889 * window.c (Fdelete_other_windows_internal): Invalidate the row
5890 and column information about mouse highlight, so that redisplay
5891 restores it after reallocating the glyph matrices. (Bug#7464)
5892
8427ddd2
EZ
5893 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5894 string comes from a `display' text property, use the buffer
5895 position of that property as if we actually saw that position in
5896 the row's glyphs.
697ba24b
EZ
5897 (move_it_by_lines): Remove the assertion that
5898 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5899 violated when there's a before-string at the beginning of a line.
5900 (Bug#11063)
8427ddd2 5901
65a0a738
EZ
59022012-03-30 Eli Zaretskii <eliz@gnu.org>
5903
5904 * xdisp.c (append_space_for_newline): If the default face was
5905 remapped, use the remapped face for the appended newline.
5906 (extend_face_to_end_of_line): Use the remapped default face for
5907 extending the face to the end of the line.
5908 (display_line): Call extend_face_to_end_of_line when the default
5909 face was remapped. (Bug#11068)
5910
581355cc
EZ
59112012-03-29 Eli Zaretskii <eliz@gnu.org>
5912
5913 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5914
e8fc049f
SM
59152012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5916
5917 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5918
4fb9a543
GM
59192012-03-27 Glenn Morris <rgm@gnu.org>
5920
5921 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5922 Doc fixes.
5923
679910f1
KH
59242012-03-26 Kenichi Handa <handa@m17n.org>
5925
5926 * dispextern.h (struct glyph): Fix previous change. Change the
5927 bit length of glyphless.ch to 25 (Bug#11082).
5928
90d49b7f
CY
59292012-03-26 Chong Yidong <cyd@gnu.org>
5930
5931 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5932 (command_loop_1): Use it; inhibit selection update for
5933 handle-select-window too (Bug#8996).
5934
f514f6f0
FP
59352012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5936
e8fc049f 5937 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5938
bf43fa51
KH
59392012-03-25 Kenichi Handa <handa@m17n.org>
5940
5941 * dispextern.h (struct glyph): Change the bit length of
5942 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5943
8a0c01dd
EZ
59442012-03-24 Eli Zaretskii <eliz@gnu.org>
5945
5946 * s/ms-w32.h (tzname): Include time.h before redirecting to
5947 _tzname. Fixes the MSVC build. (Bug#9960)
5948
7d1c3a76
AS
59492012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5950
8ed79523
AS
5951 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5952 characters.
5953
7d1c3a76
AS
5954 * xterm.c (XTread_socket): Only modify handling_signal if
5955 !SYNC_INPUT. (Bug#11080)
5956
e99a9b8b
EZ
59572012-03-23 Eli Zaretskii <eliz@gnu.org>
5958
5959 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5960 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5961 when fetching a multibyte character consumes more bytes than
5962 CHAR_BYTES returns, due to unification of CJK characters in
5963 string_char. (Bug#11073)
5964
5063c0e1
TN
59652012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5966
5967 * process.c (wait_reading_process_output): Handle pty disconnect
5968 by refraining from sending oneself a SIGCHLD (bug#10933).
5969
9f851fbd
CY
59702012-03-22 Chong Yidong <cyd@gnu.org>
5971
5972 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5973
5063c0e1 5974 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5975 Mark string as coming from a prefix property.
5976 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5977 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5978
fb5b8aca
CY
59792012-03-21 Chong Yidong <cyd@gnu.org>
5980
5981 * xfaces.c (Vface_remapping_alist): Doc fix.
5982
62356a1b
EZ
59832012-03-20 Eli Zaretskii <eliz@gnu.org>
5984
5985 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5986 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5987 Doc fixes.
62356a1b 5988
025de85b
CY
59892012-03-20 Chong Yidong <cyd@gnu.org>
5990
5991 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5992 to reflect default non-nil value of redisplay-dont-pause.
5993
4827f94e
KH
59942012-03-19 Kenichi Handa <handa@m17n.org>
5995
5996 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5997 it fit in a valid range (Bug#11003).
5998
e50a24a2
EZ
59992012-03-18 Eli Zaretskii <eliz@gnu.org>
6000
6001 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6002 that is not from display property, accept the row as a "cursor
6003 row" if one of the string's character has a non-nil `cursor'
6004 property. Fixes cursor positioning when there are newlines in
6005 overlay strings, e.g. in icomplete.el. (Bug#11035)
6006
9af5ed87
PE
60072012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6010
d1f55f16
CY
60112012-03-12 Chong Yidong <cyd@gnu.org>
6012
6013 * eval.c (inhibit_lisp_code): Rename from
6014 inhibit_window_configuration_change_hook; move from window.c.
6015
6016 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6017 * window.c (run_window_configuration_change_hook)
6018 (syms_of_window): Callers changed.
6019
66c5eebd
CY
60202012-03-11 Chong Yidong <cyd@gnu.org>
6021
413df973
CY
6022 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6023
66c5eebd
CY
6024 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6025
1de11f56
CY
60262012-03-10 Chong Yidong <cyd@gnu.org>
6027
6028 * frame.c (other_visible_frames): Don't assume the selected frame
6029 is visible (Bug#10955).
6030
cae07000
SM
60312012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6032
6033 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6034
89c94350
JD
60352012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6036
6037 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6038 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6039 zero (Bug#10954).
6040
999dd333
GM
60412012-03-03 Glenn Morris <rgm@gnu.org>
6042
01a6dcc8 6043 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6044
de0100f2
EZ
60452012-03-02 Eli Zaretskii <eliz@gnu.org>
6046
6047 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6048 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6049 (redisplay_window, next_element_from_string): Fix typos in
6050 comments.
3e441275
EZ
6051 (redisplay_window): Pass to move_it_vertically the margin in
6052 pixels, not in screen lines.
de0100f2 6053
96a72ee9
GM
60542012-03-02 Glenn Morris <rgm@gnu.org>
6055
6056 * buffer.c (buffer-list-update-hook): Doc fix.
6057
312508d7
EZ
60582012-02-29 Eli Zaretskii <eliz@gnu.org>
6059
6060 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6061 push_it before setting up the iterator for the first overlay
6062 string, even if we have an empty string loaded.
6063 (next_overlay_string): If there's an empty string on the iterator
6064 stack, pop the stack. (Bug#10903)
6065
27f3c637
PE
60662012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6067
6068 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6069 Suggested by Stefan Monnier in
6070 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6071 * alloc.c (widen_to_Lisp_Object): New static function.
6072 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6073 and widening them to Lisp_Objects. This would work even if
6074 USE_LSB_TAG is defined and wide integers are used, which might
6075 happen in a future version of Emacs.
6076
3c9dfce6
CY
60772012-02-25 Chong Yidong <cyd@gnu.org>
6078
fa74b241
CY
6079 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6080 Doc fix.
6081
3c9dfce6
CY
6082 * xselect.c (Fx_selection_exists_p): Doc fix.
6083 (x_clipboard_manager_save_all): Print an informative message
6084 before saving to clipboard manager.
6085
9486df08
CY
60862012-02-24 Chong Yidong <cyd@gnu.org>
6087
6088 * keyboard.c (process_special_events): Handle all X selection
6089 requests in kbd_buffer, not just the next one (Bug#8869).
6090
f01d3321
CY
60912012-02-23 Chong Yidong <cyd@gnu.org>
6092
6093 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6094 call when setting menu-bar-lines and tool-bar-lines parameters.
6095 (unwind_create_frame_1): New helper function.
6096
6097 * window.c (inhibit_window_configuration_change_hook): New var.
6098 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6099 (syms_of_window): Initialize it.
f01d3321 6100
86b847b6
CY
61012012-02-22 Chong Yidong <cyd@gnu.org>
6102
6103 * xterm.c (x_draw_image_relief): Add missing type check for
6104 Vtool_bar_button_margin (Bug#10743).
6105
a59225b1
CY
61062012-02-21 Chong Yidong <cyd@gnu.org>
6107
6108 * fileio.c (Vfile_name_handler_alist): Doc fix.
6109
6110 * buffer.c (Fget_file_buffer): Protect against invalid file
6111 handler return value.
6112
310f5bd4
PE
61132012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6114
cb3a28cc
PE
6115 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6116 when computing $valmask.
6117
310f5bd4
PE
6118 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6119 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6120 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6121 It's useless in that case, and it can cause problems on hosts
6122 that allocate halves of EMACS_INT values separately.
6123 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6124 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6125 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6126 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6127 it avoids undefined behavior on hosts where shifting right by more
6128 than the word width has undefined behavior.
6129
2375c96a
CY
61302012-02-19 Chong Yidong <cyd@gnu.org>
6131
6132 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6133 (Funhandled_file_name_directory, Ffile_name_as_directory)
6134 (Fdirectory_file_name, Fexpand_file_name)
6135 (Fsubstitute_in_file_name): Protect against invalid file handler
6136 return values (Bug#10845).
6137
3eb49e71
EZ
61382012-02-18 Eli Zaretskii <eliz@gnu.org>
6139
6140 * .gdbinit (pitx): Fix incorrect references to fields of the
6141 iterator stack.
6142
7b926f3f
CY
61432012-02-17 Chong Yidong <cyd@gnu.org>
6144
6145 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6146
11273115
PE
61472012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6148
6149 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6150 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6151
c3a70e2b
CY
61522012-02-15 Chong Yidong <cyd@gnu.org>
6153
6154 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6155 marked as special. Also, starting docstrings with * is obsolete.
6156
0ca43699
AS
61572012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6158
6159 * gnutls.c (emacs_gnutls_write): Fix last change.
6160
2e8f3c56
LI
61612012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6162
6163 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6164 send_process.
6165
af70074f
SM
61662012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6167
6168 * keymap.c (Fsingle_key_description): Handle char ranges.
6169
95986d52
CY
61702012-02-12 Chong Yidong <cyd@gnu.org>
6171
afd83bd1
CY
6172 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6173 as that creates a dangerous corner case.
6174
95986d52
CY
6175 * window.c (Fdelete_window_internal): Invalidate the mouse
6176 highlight (Bug#9904).
6177
bd7da63e
GM
61782012-02-12 Glenn Morris <rgm@gnu.org>
6179
6180 * xselect.c (Fx_own_selection_internal)
6181 (Fx_get_selection_internal, Fx_disown_selection_internal)
6182 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6183 * nsselect.m (Fx_own_selection_internal)
6184 (Fx_disown_selection_internal, Fx_selection_exists_p)
6185 (Fx_selection_owner_p, Fx_get_selection_internal):
6186 Sync docs and argument specs with the xselect.c versions.
6187
77abcbc2
LI
61882012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6189
6190 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6191
90b671e2
EZ
61922012-02-11 Eli Zaretskii <eliz@gnu.org>
6193
1c0ca0b7
EZ
6194 * w32select.c (Fx_selection_exists_p): Sync doc string and
6195 argument list with xselect.c. (Bug#10783)
6196
6197 * w16select.c (Fx_selection_exists_p): Sync doc string and
6198 argument list with xselect.c. (Bug#10783)
90b671e2 6199
49241268
GM
62002012-02-10 Glenn Morris <rgm@gnu.org>
6201
6202 * fns.c (Fsecure_hash): Doc fix.
6203
f998bbe7 62042012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6205
6206 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6207
0992bd9c
CY
62082012-02-07 Chong Yidong <cyd@gnu.org>
6209
6210 * buffer.c (Fbuffer_local_variables)
6211 (buffer_lisp_local_variables): Handle unbound vars correctly;
6212 don't let Qunbound leak into Lisp.
6213
af008560
GM
62142012-02-07 Glenn Morris <rgm@gnu.org>
6215
dd605cc4
GM
6216 * image.c (Fimagemagick_types): Doc fix.
6217
af008560
GM
6218 * image.c (imagemagick-render-type): Change it from a lisp object
6219 to an integer. Move the doc here from the lisp manual.
6220 Treat all values not equal to 0 the same.
6221
1449fa1d
CY
62222012-02-06 Chong Yidong <cyd@gnu.org>
6223
6224 * doc.c (store_function_docstring): Avoid applying docstring of
6225 alias to base function (Bug#2603).
6226
3723ec07
AS
62272012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6228
6229 * .gdbinit (pp1, pv1): Remove redundant defines.
6230 (pr): Use pp.
6231
79c1cc1e
CY
62322012-02-04 Chong Yidong <cyd@gnu.org>
6233
6234 * nsterm.m: Declare a global (Bug#10694).
6235
d7f29f8e
EZ
62362012-02-04 Eli Zaretskii <eliz@gnu.org>
6237
cae07000
SM
6238 * w32.c (get_emacs_configuration_options):
6239 Include --enable-checking, if specified, in the return value.
d7f29f8e 6240
3b95a6f9
MR
62412012-02-04 Martin Rudalics <rudalics@gmx.at>
6242
6243 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6244 after rounding frame sizes. (Bug#9723)
6245
d6fa96a6
EZ
62462012-02-04 Eli Zaretskii <eliz@gnu.org>
6247
6248 * keyboard.c (adjust_point_for_property): Don't position point
6249 before BEGV. (Bug#10696)
6250
df0b2940
PE
62512012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6252
6253 Handle overflow when computing char display width (Bug#9496).
6254 * character.c (char_width): Return EMACS_INT, not int.
6255 (char_width, c_string_width): Check for overflow when
6256 computing the width; this is possible now that individual
6257 characters can have unbounded width. Problem introduced
6258 by merge from Emacs 23 on 2012-01-19.
6259
6bee44d6
MA
62602012-02-02 Michael Albinus <michael.albinus@gmx.de>
6261
6262 * dbusbind.c (Fdbus_register_method): Mention the return value
6263 :ignore in the docstring.
6264
44f92739
GM
62652012-02-02 Glenn Morris <rgm@gnu.org>
6266
1b9f60cc
GM
6267 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6268
44f92739
GM
6269 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6270 Unconditionally set to t. (Bug#10673)
6271 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6272 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6273 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6274
c5d3843c
KH
62752012-02-02 Kenichi Handa <handa@m17n.org>
6276
6277 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6278 0, do not call append_composite_glyph.
6279
159462d4 62802012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6281
6282 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6283 NULL (Bug#6988).
6284 (x_produce_glyphs): If the component of a composition is a null
6285 string, set it->pixel_width to 1 to avoid zero-width glyph.
6286
78cef877
EZ
62872012-02-01 Eli Zaretskii <eliz@gnu.org>
6288
6289 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6290 first 2 arguments are identical. This makes inserting large
6291 output from a subprocess an order of magnitude faster on
6292 MS-Windows, where all sbrk'ed memory is always contiguous.
6293
97897668
GM
62942012-01-31 Glenn Morris <rgm@gnu.org>
6295
6296 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6297 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6298 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6299
31fd3586
GM
63002012-01-29 Glenn Morris <rgm@gnu.org>
6301
6302 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6303
0e24a8b2
CY
63042012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6305
6306 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6307
cc0adcb0
CY
63082012-01-28 Chong Yidong <cyd@gnu.org>
6309
6310 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6311
acc28cb9
CY
63122012-01-26 Chong Yidong <cyd@gnu.org>
6313
9c69cfb7
CY
6314 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6315
acc28cb9
CY
6316 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6317 repeat counts (Bug#10507).
6318
48da7392
GM
63192012-01-26 Glenn Morris <rgm@gnu.org>
6320
6321 * lread.c (syms_of_lread): Doc fix.
6322
14af5f7f
CY
63232012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6324
6325 * coding.c (encode_designation_at_bol): Change return value to
6326 EMACS_INT.
6327
0b21c100
CY
63282012-01-25 Chong Yidong <cyd@gnu.org>
6329
6330 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6331
3c2907f7
CY
63322012-01-21 Chong Yidong <cyd@gnu.org>
6333
6334 * floatfns.c (Fcopysign): Make the second argument non-optional,
6335 since nil is not allowed anyway.
6336
959ad23f
AS
63372012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6338
6339 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6340 (send_process): Likewise.
6341
34a02f46
MR
63422012-01-19 Martin Rudalics <rudalics@gmx.at>
6343
6344 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6345 (Vwindow_persistent_parameters): Do not use Qstate.
6346 Rewrite doc-strings.
34a02f46 6347
1259009a 63482012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6349
6350 * character.c (char_width): New function.
70d4fdf6
GM
6351 (Fchar_width, c_string_width, lisp_string_width):
6352 Use char_width (Bug#9496).
25ed9e61 6353
6a6ee00d
MR
63542012-01-16 Martin Rudalics <rudalics@gmx.at>
6355
6356 * window.c (Vwindow_persistent_parameters): New variable.
6357 (Fset_window_configuration, save_window_save): Handle persistent
6358 window parameters.
6359
c85efaf7
EZ
63602012-01-14 Eli Zaretskii <eliz@gnu.org>
6361
6362 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6363 thrashing the stack of the thread. (Bug#9087)
6364
5944709e
PE
63652012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6366
6367 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6368
e71f5d99
EZ
63692012-01-11 Eli Zaretskii <eliz@gnu.org>
6370
6371 * xdisp.c (rows_from_pos_range): Handle the case where the
6372 highlight ends on a newline. (Bug#10464)
6373 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6374 he end column for display of highlight that ends on a newline
6375 before a R2L line.
6376
ce316182
GM
63772012-01-11 Glenn Morris <rgm@gnu.org>
6378
6379 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6380 from load-path also when installation-directory is nil. (Bug#10208)
6381
5b43da69
GM
63822012-01-10 Glenn Morris <rgm@gnu.org>
6383
74cc8ff9
GM
6384 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6385
7d8d6e4e
GM
6386 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6387 Update template values to be closer to their typical values these days.
5b43da69 6388
a0db8d43
EZ
63892012-01-09 Eli Zaretskii <eliz@gnu.org>
6390
6391 * xdisp.c (rows_from_pos_range): Accept additional argument
6392 DISP_STRING, and accept any glyph in a row whose object is that
6393 string as eligible for mouse highlight. Fixes mouse highlight of
6394 display strings from overlays. (Bug#10464)
6395
9a0115ab 63962012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6397
b9110d6a 6398 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6399 * fileio.c (auto_saving_dir_umask): New static var.
6400 (Fmake_directory_internal): Use it.
6401 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6402 creating the directory. The old code temporarily assigns
6403 too-generous permissions to the directory.
6404 (do_auto_save_eh): Clear it.
b9110d6a 6405 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6406 that the var is always cleared.
6407
6c1bd3f3
EZ
64082012-01-07 Eli Zaretskii <eliz@gnu.org>
6409
6410 * search.c (scan_buffer): Pass character positions to
6411 know_region_cache, not byte positions. (Bug#6540)
6412
069d2b50
L
64132012-01-07 LynX <_LynX@bk.ru> (tiny change)
6414
6415 * w32.c (sys_rename): Report EXDEV when rename of a directory
6416 fails because the target is on another logical disk. (Bug#10284)
6417
75bf0d33
DB
64182012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6419
6420 * xterm.c (x_embed_request_focus): New function.
6421
6422 * xterm.h: Add prototype.
6423
6424 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6425
1c6e5a32
GM
64262012-01-05 Glenn Morris <rgm@gnu.org>
6427
6428 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6429
651e947e
EZ
64302012-01-01 Eli Zaretskii <eliz@gnu.org>
6431
6432 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6433 Load gnutls_transport_set_lowat only if GnuTLS version is below
6434 2.11.1.
6435 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6436 GnuTLS versions below 2.11.1.
6437
3778cdd8
AL
64382011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6439
6440 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6441 to the doc string advising against its use for altering the way
6442 windows are scrolled.
6443
0e5317f7
KH
64442011-12-28 Kenichi Handa <handa@m17n.org>
6445
6446 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6447 coding-system ASCII compatible only when it does not produce BOM
6448 on encoding (Bug#10383).
6449
93d5ca1f
JD
64502011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6451
6452 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6453 can scroll.
6454 (create_and_show_popup_menu): Always use menu_position_func for
6455 Gtk3 (Bug#10361).
6456
ca22b785
AS
64572011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6458
6459 * callint.c (Fcall_interactively): Don't truncate prompt string.
6460
d048e1e6
EZ
64612011-12-23 Eli Zaretskii <eliz@gnu.org>
6462
6463 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6464 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6465 resumed from there (after widening). (Bug#10360)
d048e1e6 6466
5ccaba1f
JD
64672011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6468
6469 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6470
204ee57f
JD
64712011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6472
b81d40f0
JB
6473 * nsterm.m (x_free_frame_resources):
6474 Release f->output_data.ns->miniimage.
204ee57f
JD
6475 (ns_index_color): Fix indentation. Do not retain
6476 color_table->colors[i].
6477
6478 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6479 before returning.
6480
6481 * nsfns.m (x_set_background_color): Assign return value from
6482 ns_index_color to face-background instead of NSColor*.
6483 (ns_implicitly_set_icon_type): Fix indentation.
6484 Change assignment in for loop to comparison.
6485
6486 * emacs.c (ns_pool): New variable.
6487 (main): Assign ns_pool.
6488 (Fkill_emacs): Call ns_release_autorelease_pool.
6489
6490 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6491 autorelease fdesc, release fdAttrs and tdict.
6492 (ns_get_covering_families): Release charset.
6493 (ns_findfonts): Release NSFontDescriptor created with new.
6494 (ns_uni_to_glyphs): Fix indentation.
6495 (setString): Release attrStr before assigning new value.
6496
c803b2b7
JD
64972011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6498
678f4426
JD
6499 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6500 and NS_IMPL_COCOA.
6501 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6502 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6503
cd394be1 65042011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6505
5fecd5fc
JD
6506 * nsterm.m (ns_term_init): Subscribe for notifications
6507 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6508 to method trackingNotification in EmacsMenu.
6509
6510 * nsmenu.m (trackingMenu): New variable.
3771cb17 6511 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6512 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6513 from Aquamacs (Bug#7030).
678f4426
JD
6514
65152011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6516
c803b2b7
JD
6517 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6518 (symbol_to_nsstring): Fix indentation.
6519 (ns_symbol_to_pb): New function.
cae07000
SM
6520 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6521 (Fns_rotate_cut_buffers_internal): Remove.
6522 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6523 Fns_store_cut_buffer_internal.
6524 (ns_get_foreign_selection, Fx_own_selection_internal)
6525 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6526 (Fns_get_selection_internal, Fns_store_selection_internal):
6527 Use ns_symbol_to_pb and check if return value is nil.
6528 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6529 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6530 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6531 renamed to Sns_store_selection_internal.
6532 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6533 and remove this function.
6534 (ns_handle_selection_clear): Remove, never used.
6535 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6536 here.
6537
e1b01a3a
KB
65382011-12-17 Ken Brown <kbrown@cornell.edu>
6539
6540 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6541 GID is unknown (Bug#10257).
6542
2adb6e85
PE
65432011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6544
6545 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6546 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6547 which caused a build failure on GNU/Linux IA-64. This problem was
6548 introduced by my 2011-10-07 patch.
6549
d1d7b339
JL
65502011-12-15 Juri Linkov <juri@jurta.org>
6551
6552 * image.c (imagemagick_error): New function. (Bug#10112)
6553 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6554 Use `imagemagick_error' where ImageMagick functions return
6555 `MagickFalse'.
6556 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6557 proper order.
6558
100d5755
KH
65592011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6560
6561 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6562 fill background (Bug#8992).
6563
454592a6
MR
65642011-12-13 Martin Rudalics <rudalics@gmx.at>
6565
6566 * window.c (Vwindow_combination_resize)
6567 (Vwindow_combination_limit): Use t instead of non-nil in
6568 doc-strings.
61d4b438
MR
6569 (Vrecenter_redisplay): Add first sentence of doc-string on
6570 separate line.
53524d93 6571 (Frecenter): Fix doc-string typo.
454592a6 6572
3633e3aa
KH
65732011-12-11 Kenichi Handa <handa@m17n.org>
6574
6575 * coding.c (Funencodable_char_position): Pay attention to the
6576 buffer text relocation (Bug#9389).
6577
7b9d523a 65782011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6579
7b9d523a
JD
6580 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6581 gtk_init (Bug#10100).
6582
b73189c6
EZ
65832011-12-10 Eli Zaretskii <eliz@gnu.org>
6584
6585 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6586 IT->string is nil. (Bug#10263)
6587
f7dfe5d6
JD
65882011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6589
83faebb4
JD
6590 * nsterm.h (x_free_frame_resources): Declare.
6591
f7dfe5d6
JD
6592 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6593 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6594
6595 * nsterm.h (ns_get_defaults_value): Declare.
6596
6597 * nsterm.m (ns_default): Call ns_get_defaults_value.
6598
7cd4e72c
EZ
65992011-12-09 Eli Zaretskii <eliz@gnu.org>
6600
6601 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6602 (Bug#10170)
6603
b34d7317
YM
66042011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6605
6606 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6607 that where the value of an _OBJC_* symbol points to is in the .bss
6608 section (Bug#10240).
6609
76470ad1
KH
66102011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6611
6612 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6613 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6614
745fff94
KH
66152011-12-08 Kenichi Handa <handa@m17n.org>
6616
6617 * ftfont.c (get_adstyle_property): Fix previous change
6618 (Bug#10233).
6619
6e44397c
JB
66202011-12-07 Juanma Barranquero <lekktu@gmail.com>
6621
6622 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6623 dirs from the default value of EMACSLOADPATH (bug#10208).
6624
7efa6272
GM
66252011-12-07 Glenn Morris <rgm@gnu.org>
6626
6627 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6628 installation and source directories as well. (Bug#10208)
6629
f6fc4d87
CY
66302011-12-06 Chong Yidong <cyd@gnu.org>
6631
6632 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6633
2bf26180
GM
66342011-12-06 Glenn Morris <rgm@gnu.org>
6635
6636 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6637 as an error, not just -1. (Bug#10217)
6638
3a6ad4f0
CY
66392011-12-05 Chong Yidong <cyd@gnu.org>
6640
6641 * keyboard.c (process_special_events): New function.
6642 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6643
75a3b399
PE
66442011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6645
6646 * coding.c (encode_designation_at_bol): Don't use uninitialized
6647 local variable (Bug#9318).
6648
c3c9e25e
KH
66492011-12-05 Kenichi Handa <handa@m17n.org>
6650
6651 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6652 return Qnil (Bug#8046, Bug#10193).
6653
5eb05ea3
KH
66542011-12-05 Kenichi Handa <handa@m17n.org>
6655
6656 * coding.c (encode_designation_at_bol): New args charbuf_end and
6657 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6658 (coding_set_source): Return how many bytes coding->source was
6659 relocated.
6660 (coding_set_destination): Return how many bytes
6661 coding->destination was relocated.
6662 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6663 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6664
66652011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6666
6667 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6668 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6669 macro (Bug#9318).
6670
66712011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6672
6673 The following changes are to fix Bug#9318.
6674
a79703f5 6675 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6676 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6677 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6678 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6679
7dbda6df
JB
66802011-12-05 Juanma Barranquero <lekktu@gmail.com>
6681
6682 * lisp.h (process_quit_flag): Fix external declaration.
6683
6d5eb5b0
SM
66842011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6685
6686 Don't macro-inline non-performance-critical code.
6687 * eval.c (process_quit_flag): New function.
6688 * lisp.h (QUIT): Use it.
6689
a0c3fad0
JD
66902011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6691
6692 * nsfns.m (get_geometry_from_preferences): New function.
6693 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6694
6c07aac2
AS
66952011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6696
6697 * emacs.c (Qkill_emacs): Define.
6698 (syms_of_emacs): Initialize it.
6699 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6700 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6701 (quit_throw_to_read_char): Add parameter `from_signal'.
6702 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6703 * lisp.h (QUIT): Call Fkill_emacs if requested.
6704
c052ead4
JD
67052011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6706
6707 * widget.c (update_wm_hints): Return if wmshell is null.
6708 (widget_update_wm_size_hints): New function.
6709
6710 * widget.h (widget_update_wm_size_hints): Declare.
6711
6712 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6713 widget_update_wm_size_hints (Bug#10104).
6714
9e49252b
EZ
67152011-12-03 Eli Zaretskii <eliz@gnu.org>
6716
6717 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6718 before a newline, prepare the bidi iterator for consuming the
6719 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6720 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6721
02b16839
JL
67222011-12-02 Juri Linkov <juri@jurta.org>
6723
6724 * search.c (Fword_search_regexp): New Lisp function created from
6725 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6726 (Fword_search_backward, Fword_search_forward)
6727 (Fword_search_backward_lax, Fword_search_forward_lax):
6728 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6729 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6730
0068070e
SM
67312011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6732
6733 * fileio.c (Finsert_file_contents): Move after-change-function call
6734 to before the "handled:" label, since all "goto handled" appear in
6735 cases where the *-change-functions have already been properly called
6736 (bug#10117).
6737
3360a3fc
AS
67382011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6739
6740 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6741 waiting for input. (Bug#10169)
6742
73d6c093
EZ
67432011-11-30 Eli Zaretskii <eliz@gnu.org>
6744
6745 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6746 verifies glyph row's hash code--we have just reallocated the
6747 glyphs, so their contents can be complete garbage. (Bug#10164)
6748
febe6bea
JB
67492011-11-30 Juanma Barranquero <lekktu@gmail.com>
6750
6751 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6752
801a4313
EZ
67532011-11-30 Eli Zaretskii <eliz@gnu.org>
6754
6755 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6756 attributes are tested _before_ calling verify_row_hash, to protect
6757 against GCC re-ordering of the tests. (Bug#10164)
6758
2b56b87e
JD
67592011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6760
6761 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6762
6763 * xterm.c (handle_one_xevent): Only set async_visible and friends
6764 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6765 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6766 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6767
dbf31225
PE
67682011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6769
6770 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6771 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6772 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6773 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6774 All uses changed to use GCPRO1 etc.
6775 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6776 Revert to old implementation (i.e., before 2011-03-11).
6777
1305621b
YM
67782011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6779
6780 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6781 of scroll runs so as to avoid assigning disabled bogus rows and
6782 unnecessary graphics copy operations.
6783
8c9afb46
EZ
67842011-11-27 Eli Zaretskii <eliz@gnu.org>
6785
6786 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6787 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6788 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6789 (malloc, free, realloc, calloc): Redirect to e_* only when
6790 compiling Emacs.
6791
6792 * lisp.h (GCTYPEBITS): Move before first use.
6793 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6794 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6795 this macro definition.
6796
6797 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6798 _MSC_VER.
6799
54e9e3bf
JD
68002011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6801
6d5eb5b0
SM
6802 * gtkutil.c (xg_create_frame_widgets):
6803 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6804 present with Gtk+ 2.0.
6805
83aca1cb
PE
68062011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6807
6808 * fileio.c (Finsert_file_contents): Undo previous change; see
6809 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6810
5b76caa4
PE
68112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6812
6813 Rename locals to avoid shadowing.
6814 * fileio.c (Finsert_file_contents):
6815 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6816 * process.c (wait_reading_process_output):
6817 Rename inner 'proc' to 'p' to avoid shadowing.
6818 Indent for consistency with usual Emacs style.
6819
8c535114
EZ
68202011-11-25 Eli Zaretskii <eliz@gnu.org>
6821
6822 * xdisp.c (redisplay_window): If cursor row is not fully visible
6823 after recentering, and scroll-conservatively is set to a large
6824 number, scroll window by a few more lines to make the cursor fully
6825 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6826 (start_display): Don't move to the next line if the display should
6827 start at a newline that is part of a display vector or an overlay
6828 string. (Bug#10119)
8c535114 6829
fa4fdb5c
JL
68302011-11-24 Juri Linkov <juri@jurta.org>
6831
6832 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6833 after the `MagickPingImage' call. (Bug#10112)
6834
90ec88df
CY
68352011-11-23 Chong Yidong <cyd@gnu.org>
6836
6837 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6838
56e2e794
MR
68392011-11-23 Martin Rudalics <rudalics@gmx.at>
6840
6841 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6842 making another buffer current. (Bug#10114)
6843
b6e64c41
GM
68442011-11-23 Glenn Morris <rgm@gnu.org>
6845
6846 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6847
6b21de18
CY
68482011-11-23 Chong Yidong <cyd@gnu.org>
6849
6850 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6851 using it (Bug#5984).
6852
b12cd789
EZ
68532011-11-22 Eli Zaretskii <eliz@gnu.org>
6854
6855 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6856 and header-lines, as they don't have one computed for them.
6857 (Bug#10098)
6858
6859 * .gdbinit (prow): Make displayed values more self-explaining.
6860 Add row's hash code.
6861
261b6fd4
LMI
68622011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6863
6864 * process.c (wait_reading_process_output): Fix asynchrounous
6865 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6866 (wait_reading_process_output): Add comment and URL.
261b6fd4 6867
e7cfd277
JD
68682011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6869
6870 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6871
a9b9b7f5
CY
68722011-11-21 Chong Yidong <cyd@gnu.org>
6873
6874 * window.c (Fnext_window, Fprevious_window): Doc fix.
6875
b0d15b4f
SM
68762011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6877
6878 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6879
fe7a3057
JB
68802011-11-20 Juanma Barranquero <lekktu@gmail.com>
6881
6882 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6883
d2999b1a
MR
68842011-11-20 Martin Rudalics <rudalics@gmx.at>
6885
6886 * window.c (Fset_window_combination_limit): Rename argument
6887 STATUS to LIMIT.
6888 (Vwindow_combination_limit): Remove "status" from doc-string.
6889
d5ff9cd0
AS
68902011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6891
6892 * m/ibms390.h: Remove.
6893 * m/ibms390x.h: Don't include "ibms390.h".
6894
a5bb9bd3
SM
68952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6896
6897 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6898 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6899
cd1181db
JB
69002011-11-20 Juanma Barranquero <lekktu@gmail.com>
6901
6902 * casetab.c (Fset_case_table):
6903 * charset.c (Fcharset_after): Fix typos.
6904
615a3b8d 69052011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6906
17e845af
PE
6907 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6908 Otherwise, valgrind does not work on some platforms.
6909 Problem reported by Andreas Schwab in
6a0bf43d
PE
6910 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6911 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6912 is set, removing the need for VIRT_ADDRESS_VARIES.
6913 (PURE_P): Use a more-efficient implementation that needs just one
6914 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6915 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6916 to 4 (xorl, subq, cmpq, setbe).
6917 * alloc.c (pure): Always extern now, since that's the
6918 VIRT_ADDR_VARIES behavior.
6919 (PURE_POINTER_P): Use a single comparison, not two, for
6920 consistency with the new puresize.h.
6921 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6922 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6923 Remove VIRT_ADDR_VARIES no longer needed.
6924
f8fe6f96
EZ
69252011-11-19 Eli Zaretskii <eliz@gnu.org>
6926
6927 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6928 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6929 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6930 behave as if the cursor position were at the window margin.
6931
6932 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6933 and the cursor position is out of bounds, behave as if the cursor
6934 position were at the window margin. (Bug#10075)
6935
df05a53c
CY
69362011-11-18 Chong Yidong <cyd@gnu.org>
6937
6938 * window.c (Fwindow_combination_limit): Make first argument
6939 non-optional, since it is meaningless for live windows like the
6940 selected window.
61ccba97 6941
2071918e
DA
69422011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6943
6944 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6945
b50a28de
SM
69462011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6947
6948 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6949 (graft_intervals_into_buffer): Simplify.
6950
015137db
EZ
69512011-11-18 Eli Zaretskii <eliz@gnu.org>
6952
6953 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6954 hash values of the two rows.
6955 (copy_row_except_pointers): Preserve the used[] arrays and the
6956 hash values of the two rows. (Bug#10035)
68c95424 6957 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6958
6959 * xdisp.c (row_hash): New function, body extracted from
6960 compute_line_metrics.
6961 (compute_line_metrics): Call row_hash, instead of computing the
6962 hash code inline.
6963
6964 * dispnew.c (verify_row_hash): Call row_hash for computing the
6965 hash code of a row, instead of duplicating code from xdisp.c.
6966
6967 * dispextern.h (row_hash): Add prototype.
6968
a2addb04
TH
69692011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6970
6971 * frame.c (delete_frame): Don't delete the terminal when the last
6972 X frame is closed if emacs is built with GTK toolkit.
6973
df85d315
JB
69742011-11-17 Juanma Barranquero <lekktu@gmail.com>
6975
6976 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6977
a0c2d0ae
MR
69782011-11-17 Martin Rudalics <rudalics@gmx.at>
6979
6980 * window.c (Vwindow_splits): Rename to
6981 Vwindow_combination_resize. Suggested by Juri Linkov.
6982 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6983 of Vwindow_splits.
6984
58179cce
JB
69852011-11-16 Juanma Barranquero <lekktu@gmail.com>
6986
7877f373
JB
6987 * nsfns.m (Fns_font_name):
6988 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6989
b6f67890
MR
69902011-11-16 Martin Rudalics <rudalics@gmx.at>
6991
6992 * window.h (window): Rename slot "nest" to "combination_limit".
6993 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6994 (Fset_window_nest): Rename to Fset_window_combination_limit.
6995 (Vwindow_nest): Rename to Vwindow_combination_limit.
6996 (recombine_windows, make_parent_window, make_window)
6997 (Fsplit_window_internal, saved_window)
6998 (Fset_window_configuration, save_window_save): Rename all
6999 occurrences of window_nest to window_combination_limit.
7000
c7015153
JB
70012011-11-15 Juanma Barranquero <lekktu@gmail.com>
7002
7003 * image.c (imagemagick_load_image): Fix typo.
7004
322ad6ec
EZ
70052011-11-14 Eli Zaretskii <eliz@gnu.org>
7006
7007 * xdisp.c (display_line): Move the call to
7008 highlight_trailing_whitespace before the call to
7009 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7010 faces of all the glyphs to compute ROW's hash value.
7011 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7012
f067b8ec
JB
70132011-11-14 Juanma Barranquero <lekktu@gmail.com>
7014
7015 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7016 just return (bug#10044).
7017
1e5b2111
EZ
70182011-11-12 Eli Zaretskii <eliz@gnu.org>
7019
7ef3cbd5
EZ
7020 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7021 with user-defined heap size. Bump the default size of the temacs
7022 heap to 27MB, to avoid memory warning when running temacs.
7023 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7024
1e5b2111
EZ
7025 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7026 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7027 (verify_row_hash) [XASSERTS]: New function.
7028 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7029 that the hash value of glyph rows is correct.
1e5b2111 7030
89d61221
MR
70312011-11-12 Martin Rudalics <rudalics@gmx.at>
7032
7033 * window.h (window): Remove splits slot.
7034 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7035 (Fdelete_other_windows_internal, make_parent_window)
7036 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7037 (Fset_window_configuration, save_window_save): Don't deal with
7038 split status of windows.
7039 (saved_window): Remove splits slot.
7040 (Vwindow_splits): Rewrite doc-string.
7041
97f18cc8
JD
70422011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7043
7044 * xfns.c (unwind_create_frame):
7045 * nsfns.m (unwind_create_frame):
7046 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7047 Vframe_list (Bug#9999).
7048
22a648b4
DA
70492011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7050
0b381c7e 7051 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7052
659afede
KH
70532011-11-11 Kenichi Handa <handa@m17n.org>
7054
7055 * callproc.c (Fcall_process): Set the member dst_multibyte of
7056 process_coding.
7057
9ac0394b
KH
70582011-11-11 Johan Bockgård <bojohan@gnu.org>
7059
7060 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7061 avoid a crash (bug#9496).
7062
2fbdc249
CY
70632011-11-09 Chong Yidong <cyd@gnu.org>
7064
7065 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7066 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7067
ac6b1f81
PE
70682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7069
7070 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7071
09db192c
PE
70722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7073
7074 Avoid some portability problems by eschewing 'extern inline' functions.
7075 The trivial performance wins aren't worth the portability hassles; see
7076 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7077 et seq.
7078 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7079 (window_box_width, window_box_left, window_box_left_offset)
7080 (window_box_right, window_box_right_offset): Undo previous change,
7081 by removing the "extern"s.
7082 * intervals.c (adjust_intervals_for_insertion)
7083 (adjust_intervals_for_deletion): Undo previous change,
7084 making these static again.
7085 (offset_intervals, temp_set_point_both, temp_set_point)
7086 (copy_intervals_to_string): No longer inline.
7087 * xdisp.c (window_text_bottom_y, window_box_width)
7088 (window_box_height, window_box_left_offset)
7089 (window_box_right_offset, window_box_left, window_box_right)
7090 (window_box): No longer inline.
7091
105216ed
CY
70922011-11-08 Chong Yidong <cyd@gnu.org>
7093
7094 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7095 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7096 Signal an error if not a live window.
105216ed
CY
7097 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7098 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7099
ae9e237f
JB
71002011-11-07 Juanma Barranquero <lekktu@gmail.com>
7101
7102 * lisp.h (syms_of_abbrev): Remove declaration.
7103 Reported by CHENG Gao <chenggao@royau.me>.
7104
c7aa8333
EZ
71052011-11-07 Eli Zaretskii <eliz@gnu.org>
7106
7107 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7108 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7109 of temacs in GUI mode.
7110
be7f5545
MR
71112011-11-07 Martin Rudalics <rudalics@gmx.at>
7112
7113 * window.h: Declare delete_all_child_windows instead of
7114 delete_all_subwindows.
7115 * window.c (Fwindow_nest, Fset_window_nest)
7116 (Fset_window_new_total, Fset_window_new_normal)
7117 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7118 (delete_all_subwindows): Rename to delete_all_child_windows.
7119 (Fdelete_other_windows_internal, Fset_window_configuration):
7120 Call delete_all_child_windows instead of delete_all_subwindows.
7121 * frame.c (delete_frame): Call delete_all_child_windows instead
7122 of delete_all_subwindows.
7123
ca78dc43
PE
71242011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7125
7126 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7127 This is also needed for porting to any host where GC_MARK_STACK is
7128 not GC_MAKE_GCPROS_NOOPS.
7129 (which_symbols): Use it.
7130
a0241d01
KH
71312011-11-07 Kenichi Handa <handa@m17n.org>
7132
7133 * coding.c (coding_set_destination): Check coding->src_pos only
7134 when coding->src_object is a buffer (bug#9910).
7135
7136 * process.c (send_process): Set the member src_multibyte of coding
7137 to 0 (bug#9911) when sending a unibyte text.
7138
7139 * callproc.c (Fcall_process): Set the member src_multibyte of
7140 process_coding to 0 (bug#9912).
7141
a64bfdfa 71422011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7143
7144 * xmenu.c (cleanup_widget_value_tree): New function.
7145 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7146 calling free_menubar_widget_value_tree directly (Bug#9830).
7147
cb41b32a
PE
71482011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7149
7150 Fix some portability problems with 'inline'.
7151 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7152 (window_box_width, window_box_left, window_box_left_offset)
7153 (window_box_right, window_box_right_offset): Declare extern.
7154 Otherwise, these inline functions do not conform to C99 and
7155 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7156 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7157 * intervals.c (adjust_intervals_for_insertion)
7158 (adjust_intervals_for_deletion): Now extern, because otherwise the
7159 extern inline functions 'offset_intervals' couldn't refer to it.
7160 (static_offset_intervals): Remove.
7161 (offset_intervals): Rewrite using the old contents of
7162 static_offset_intervals. The old version didn't conform to C99
7163 because an extern inline function contained a reference to an
7164 identifier with static linkage.
7165
b7041366
AS
71662011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7167
7168 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7169 GC.
7170
88a37c4d
EZ
71712011-11-06 Eli Zaretskii <eliz@gnu.org>
7172
7173 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7174 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7175 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7176 return Qleft_to_right.
7177
49745b39
CY
71782011-11-06 Chong Yidong <cyd@gnu.org>
7179
7180 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7181 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7182 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7183 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7184 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7185 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7186 (Fwindow_vscroll): Doc fix.
7187 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7188 argument, since it makes no sense to pass a live window and for
7189 consistency with window-child.
7190
1f05cd82
CS
71912011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7192
7193 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7194 support MSVC.
7195
22610910
JR
71962011-11-05 Jason Rumney <jasonr@gnu.org>
7197
7198 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7199 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7200 fonts (Bug#6029).
7201 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7202 bitwise arithmetic preventing use of unicode-sip and non-truetype
7203 opentype fonts.
7204
a06776b2
EZ
72052011-11-05 Eli Zaretskii <eliz@gnu.org>
7206
3ad924ba
EZ
7207 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7208 "emacs"-only part.
7209
a06776b2
EZ
7210 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7211 initialization code to keep similarity to xfns.c after changes
7212 from 2011-11-05.
7213
c9e7db78
JD
72142011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7215
a97f8f3f
JD
7216 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7217 (unwind_create_frame): New function (Bug#9943).
7218 (Fx_create_frame): Restructure code to be more similar to the one in
7219 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7220 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7221 Move terminal->reference_count++ just before making the frame official
7222 (Bug#9943).
7223
7224 * nsterm.m (x_free_frame_resources): New function.
7225 (x_destroy_window): Move code to x_free_frame_resources.
7226
c9e7db78 7227 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7228 (Fx_create_frame, x_create_tip_frame):
7229 Move terminal->reference_count++ just before making the frame
75f1671a 7230 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7231 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7232
a6fc3b5c
EZ
72332011-11-05 Eli Zaretskii <eliz@gnu.org>
7234
7235 Support MSVC build with newer versions of Visual Studio.
7236 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7237 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7238 nt/gmake.defs.
7239
7240 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7241 which are not supported by MSVC.
7242 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7243 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7244 bitfields.
7245 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7246 types in bitfields.
7247 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7248
7249 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7250
58179cce 72512011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7252
7253 Support MSVC build with newer versions of Visual Studio.
7254 * w32.c: Don't include w32api.h for MSVC.
7255 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7256
7257 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7258 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7259 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7260 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7261 e_* cousins.
7262 (alloca) [_MSC_VER]: Define to _alloca.
7263
7264 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7265
7266 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7267
a58c13ed
EZ
72682011-11-04 Eli Zaretskii <eliz@gnu.org>
7269
7270 * xdisp.c (note_mouse_highlight): If either of
7271 previous/next-single-property-change returns nil, treat that as
7272 the beginning or the end of the buffer. (Bug#9955)
7273
fe0b6370
JD
72742011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7275
a58c13ed 7276 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7277 label is not null (Bug#9951).
7278 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7279 may be NULL.
7280
89bd5ee1
EZ
72812011-11-04 Eli Zaretskii <eliz@gnu.org>
7282
7283 * window.c (Fwindow_body_size): Mention in the doc string that the
7284 return value is in frame's canonical units. (Bug#9949)
7285
84c3edb9
EZ
72862011-11-03 Eli Zaretskii <eliz@gnu.org>
7287
4e2fb5c7
EZ
7288 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7289
84c3edb9 7290 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7291 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7292 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7293
bc17a887
EZ
72942011-11-01 Eli Zaretskii <eliz@gnu.org>
7295
7296 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7297 Don't stop backward scan on the continuation glyph, even though
7298 its CHARPOS is positive.
6d5eb5b0
SM
7299 (mouse_face_from_buffer_pos, note_mouse_highlight):
7300 Rename cover_string to disp_string.
bc17a887 7301
4ee88440
MR
73022011-11-01 Martin Rudalics <rudalics@gmx.at>
7303
7304 * window.c (temp_output_buffer_show): Don't use
7305 Vtemp_buffer_show_specifiers.
7306 (Vtemp_buffer_show_specifiers): Remove unused variable.
7307
c2ff3c02
EZ
73082011-10-30 Eli Zaretskii <eliz@gnu.org>
7309
7310 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7311 past the beginning of the current glyph matrix.
7312
58179cce 73132011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7314
7315 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7316 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7317 HAVE_GTK3 (Bug#9869).
b77a6a7f 7318
3b574623
JD
7319 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7320 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7321
b77a6a7f
JD
7322 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7323
7324 * xterm.c: Declare x_handle_net_wm_state to return int.
7325 (handle_one_xevent): Check if we are iconified but don't have
7326 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7327 (get_current_wm_state): Return non-zero if not hidden,
7328 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7329 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7330 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7331 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7332
196e41e4
PE
73332011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7334
7335 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7336 so that this new function doesn't get optimized away by a
7337 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7338
021f2e1a
AS
73392011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7340
7341 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7342
8b058d44
EZ
73432011-10-29 Eli Zaretskii <eliz@gnu.org>
7344
7345 Fix the `xbytecode' command.
7346 * .gdbinit (xprintbytestr): New command.
b50a28de 7347 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7348 (xbytecode): Print the byte-code string as well.
7349
4452fb80
EZ
73502011-10-29 Kim Storm <storm@cua.dk>
7351
8b058d44
EZ
7352 * alloc.c (which_symbols): New function.
7353
21b72067
AS
73542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7355
7356 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7357 line. (Bug#9903)
7358
83ed7b5c
GM
73592011-10-29 Glenn Morris <rgm@gnu.org>
7360
7361 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7362 Not clear what it was for, and it causes various bugs. (Bug#9839)
7363
5a7a728b
EZ
73642011-10-28 Eli Zaretskii <eliz@gnu.org>
7365
7366 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7367 possible random value that matches one of those tested as
7368 condition to clear the mouse face.
7369
d3d0842f
CY
73702011-10-28 Chong Yidong <cyd@gnu.org>
7371
7372 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7373
31b39d13
DN
73742011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7375
7376 * window.c (make_window): Initialize phys_cursor_on_p.
7377
9aba6043
SM
73782011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7379
7380 * lisp.h (struct Lisp_Symbol): Update comments.
7381
c20992f4
JB
73822011-10-28 Juanma Barranquero <lekktu@gmail.com>
7383
7384 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7385
db4f02f2
EZ
73862011-10-28 Eli Zaretskii <eliz@gnu.org>
7387
7388 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7389 <oslsachem@gmail.com> for helping to debug this.
7390
7391 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7392 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7393 (g_b_init_get_glyph_outline_w): New static variables.
7394 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7395 (GetGlyphOutlineW_Proc): New typedefs.
7396 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7397 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7398 New functions.
7399 (w32font_open_internal, compute_metrics):
7400 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7401 instead of calling the "wide" APIs directly.
7402
7403 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7404
7405 * w32.h (syms_of_w32font): Add prototype.
7406
87e68db4
JB
74072011-10-27 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7410 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7411 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7412 (Fmove_to_window_line): Doc fix.
7413
435c1d67
CY
74142011-10-27 Chong Yidong <cyd@gnu.org>
7415
7416 * process.c (make_process): Set gnutls_state to NULL.
7417
7418 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7419 non-NULL, regardless of GNUTLS_INITSTAGE.
7420 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7421 an error. Set process slots as soon as we allocate them.
7422
7423 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7424
9c6c6f49
CY
74252011-10-27 Chong Yidong <cyd@gnu.org>
7426
9aba6043
SM
7427 * gnutls.c (emacs_gnutls_deinit): New function.
7428 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7429 (Fgnutls_deinit, Fgnutls_boot): Use it.
7430
7431 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7432 (deactivate_process): Call emacs_gnutls_deinit.
7433
657d08d3
JB
74342011-10-27 Juanma Barranquero <lekktu@gmail.com>
7435
7436 * image.c (x_create_x_image_and_pixmap):
7437 * w32.c (sys_rename, w32_delayed_load):
7438 * w32font.c (fill_in_logfont):
7439 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7440
5430d399
JB
74412011-10-26 Juanma Barranquero <lekktu@gmail.com>
7442
7443 * w32fns.c (w32_default_color_map): New function,
7444 extracted from Fw32_default_color_map.
a7ef684b 7445 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7446
fe0055fa
PE
74472011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7448
7449 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7450
e6346438
SM
74512011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7452
7453 * keyboard.c (test_undefined): New function (bug#9751).
7454 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7455
e112cc37
ET
74562011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7457
7458 * sysdep.c (init_sys_modes): Fix the check for the controlling
7459 terminal (Bug#6649).
7460
7b5d6677
EZ
74612011-10-20 Eli Zaretskii <eliz@gnu.org>
7462
7463 * dispextern.h (struct bidi_it): New member next_en_type.
7464
7465 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7466 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7467 current character, check also for next_en_type being WEAK_EN.
7468 (bidi_resolve_weak): Don't enter the expensive loop if the current
7469 position is before next_en_pos. Record the bidi type of the first
7470 non-ET, non-BN character we find, in addition to its position.
7471 (bidi_level_of_next_char): Invalidate next_en_type when
7472 next_en_pos is over-stepped.
7473
7da0b018
PE
74742011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7475
7476 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7477 * editfns.c: Rewrite current-time-zone so that it invokes
7478 the equivalent of (format-time-string "%Z") to get the time zone name.
7479 This fixes a bug when the time zone name contains characters that
7480 need converting from the system time locale to Emacs internal format.
7481 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7482 that patch fixed format-time-string to do the conversion, but
7483 I forgot to fix current-time-zone.
7484 (format_time_string): New function, containing most of
7485 what Fformat_time_string used to contain.
7486 (Fformat_time_string): Rewrite in terms of format_time_string.
7487 This doesn't change this function's behavior.
7488 (current-time-zone): Rewrite to use format_time_string.
7489 This fixes the bug reported by Michael Schierl in
7490 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7491 Jason Rumney's 2007-06-07 change worked around this bug, but
7492 didn't fix it.
7493 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7494
8547b010
EZ
74952011-10-19 Eli Zaretskii <eliz@gnu.org>
7496
7497 * xdisp.c (start_display): If the character at POS is displayed
7498 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7499 (try_window_reusing_current_matrix): If a line ends in a display
7500 vector or the next line starts in a display vector, continue
7501 redrawing the window even though the character position of
7502 start_row was reached.
8547b010
EZ
7503 (Bug#9771, part 2)
7504
4e948d15
CY
75052011-10-18 Chong Yidong <cyd@gnu.org>
7506
7507 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7508 with nobreak-char-display too.
7509
4787455f
EZ
75102011-10-18 Eli Zaretskii <eliz@gnu.org>
7511
7512 Fix part 3 of bug#9771.
7513 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7514 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7515 non-neutral characters if the current character is a paragraph
7516 separator (a.k.a. Newline). This avoids running the same
7517 expensive loop twice, once when we consume the preceding newline
7518 and the other time when the line actually needs to be displayed.
7519 Avoid the loop when we see neutrals on the base embedding level
7520 following a character whose directionality is the same as the
7521 paragraph's. This avoids running the expensive loop when a line
7522 ends in a long sequence of neutrals, like control characters.
7523 Add assertion against STRONG_AL type. Slightly rearrange code
7524 that determines the type of a neutral given the first non-neutral
7525 that follows it.
7526 (bidi_level_of_next_char): Set next_en_pos to zero when
7527 invalidating its info.
7528
2c91f553
EZ
75292011-10-17 Eli Zaretskii <eliz@gnu.org>
7530
7531 * xdisp.c (push_display_prop): Determine whether to record string
7532 or buffer position by IT->string, not by IT->method. Allow
7533 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7534 (move_it_vertically_backward): Don't look for character position
7535 immediately after the newline when in a continuation line.
7536 (Bug#9771, part 1)
2c91f553 7537
c7b08b0d
MR
75382011-10-15 Martin Rudalics <rudalics@gmx.at>
7539
7540 * window.c (coordinates_in_window): Rewrite and delabelize
7541 vertical border check. (Bug#5357) (Bug#9618)
7542
6b02f655
SM
75432011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7544
7545 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7546 errors in XSetWindowBorder (bug#9310).
7547
81d40c92
DA
75482011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7549
7550 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7551 avoid crash when xmalloc overrun checking is enabled.
7552
d4172c3b
EZ
75532011-10-13 Eli Zaretskii <eliz@gnu.org>
7554
7555 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7556 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7557 cursor motion with <left> and <right> arrow keys.
7558
7559 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7560 some callers set that themselves.
7561
b00eea75
EZ
75622011-10-12 Eli Zaretskii <eliz@gnu.org>
7563
7564 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7565 display string and the previous row comes from the same string and
7566 is empty. (Bug#9739) (Bug#9738)
7567
8fe012c4
SM
75682011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7569
7570 * doc.c (get_doc_string): Encode file name (bug#9735).
7571
0074aef2
EZ
75722011-10-12 Eli Zaretskii <eliz@gnu.org>
7573
79beb178
EZ
7574 * bidi.c (bidi_level_of_next_char):
7575 * xdisp.c (get_visually_first_element): Remove old incorrect
7576 comments regarding the Unicode Line Separator character.
7577
0074aef2
EZ
7578 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7579
6e4b3fbe
DA
75802011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7581
7582 * alloc.c (Fgc_status): Do not access beyond zombies array
7583 boundary if nzombies > MAX_ZOMBIES.
7584 * alloc.c (dump_zombies): Add missing format specifier.
7585
0324f3af
PE
75862011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7587
b5525cac
PE
7588 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7589 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7590
0324f3af
PE
7591 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7592 Some packages use them to denote characters with modifiers.
7593
e9b5f888
AS
75942011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7595
7596 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7597 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7598 matching a pp-number. Rename parameter var to var1.
7599
127827c0
SM
76002011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7601
7602 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7603
c8fd3bd0
GM
76042011-10-08 Glenn Morris <rgm@gnu.org>
7605
7606 * callint.c (Fcall_interactively): Give a more explicit error for the
7607 'c' case with a non-character input. (Bug#8479)
7608
352ec8ff
EZ
76092011-10-08 Eli Zaretskii <eliz@gnu.org>
7610
03669ccb
EZ
7611 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7612 lines.
7061c986
EZ
7613 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7614 lines that are hscrolled on the left.
03669ccb 7615
352ec8ff
EZ
7616 * dispnew.c (buffer_posn_from_coords): Account for a possible
7617 presence of header-line. (Bug#4426)
7618
a66cfb1c
SM
76192011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7620
6b02f655
SM
7621 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7622 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7623
7c5ee88e
PE
76242011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7625
7626 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7627 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7628 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7629 this makes Emacs dump core during garbage collection on rare
7630 occasions. sizeof is obviously inferior to offsetof here, so
7631 stick with offsetof.
7632 (GC_POINTER_ALIGNMENT): New macro.
7633 (mark_memory): Omit 3rd (offset) arg; caller changed.
7634 Don't assume EMACS_INT alignment is the same as pointer alignment.
7635
df1bbe5b
SM
76362011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7637
7638 * keyboard.c (read_key_sequence_remapped): New var.
7639 (read_key_sequence): Compute remapping in the right buffer.
7640 (command_loop_1): Use read_key_sequence's remapping directly.
7641
51553db6
SM
76422011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7643
32c1fffd
SM
7644 * dired.c (file_name_completion): Don't expand file name.
7645 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7646 before checking file name handler.
7647
51553db6
SM
7648 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7649 they've been requested explicitly (bug#9591).
7650
b6bd1599 76512011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7652
7653 * keymap.c (Fsingle_key_description): Use make_specified_string
7654 instead of build_string to build string from push_key_description.
7655 (Bug#5193)
7656
f701dc2a
PE
76572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7658
4222c55d
PE
7659 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7660 This fixes a Y2038 bug on 64-bit hosts.
7661 * buffer.c (reset_buffer):
7662 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7663 (Fclear_buffer_auto_save_failure):
7664 Use 0, not -1, to represent an unset failure time, since time_t
7665 might not be signed.
7666
f701dc2a
PE
7667 Remove dependency on glibc malloc internals.
7668 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7669 Move back here from lisp.h, but with their new implementations.
7670 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7671 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7672 * charset.c (charset_table_init): New static var.
7673 (syms_of_charset): Use it instead of xmalloc. This removes a
7674 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7675 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7676 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7677 Move back to alloc.c.
7678 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7679 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7680
9ceebf39
JD
76812011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7682
7683 * nsterm.m (windowDidResize): Call x_set_window_size only when
7684 ns_in_resize is true. Otherwise set pixelwidth/height and
7685 call change_frame_size (Bug#9628).
7686
cb993c58
PE
76872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7688
3930c88b
PE
7689 Port --enable-checking=all to Fedora 14 x86-64.
7690 * charset.c (syms_of_charset): Also account for glibc malloc's
7691 internal overhead when calculating the initial malloc maximum.
7692
cb993c58
PE
7693 Port --enable-checking=all to Fedora 14 x86.
7694 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7695 Move to lisp.h.
7696 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7697 (overrun_check_realloc, overrun_check_free):
7698 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7699 That way, xmalloc returns a properly-aligned pointer even if
7700 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7701 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7702 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7703 into account when calculating the initial malloc maximum.
7704 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7705 Move here from alloc.c, so that charset.c can use it too.
7706 Properly align; the old code wasn't right for common 32-bit hosts
7707 when configured with --enable-checking=all.
7708 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7709 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7710
31bed486
EZ
77112011-09-29 Eli Zaretskii <eliz@gnu.org>
7712
04c70788 7713 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7714 use EDOM.
7715
fbcaa2f3
EZ
77162011-09-28 Eli Zaretskii <eliz@gnu.org>
7717
7718 * xdisp.c (compute_display_string_end): If there's no display
7719 string at CHARPOS, return -1.
7720
7721 * bidi.c (bidi_fetch_char): When compute_display_string_end
7722 returns a negative value, treat the character as a normal
7723 character not covered by a display string. (Bug#9624)
7724
a239d4e9
JB
77252011-09-28 Juanma Barranquero <lekktu@gmail.com>
7726
7727 * lread.c (Fread_from_string): Fix typo in docstring.
7728
88652fd5
EZ
77292011-09-27 Eli Zaretskii <eliz@gnu.org>
7730
7731 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7732 newline, reseat the iterator instead of bidi-iterating there one
7733 character at a time. (Bug#9610)
32c1fffd
SM
7734 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7735 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7736
ed497dd4
AS
77372011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7738
7739 * lread.c (readevalloop): Use correct code for NBSP.
7740 (read1): Likewise. (Bug#9608)
7741
b2bf61aa
MA
77422011-09-25 Michael Albinus <michael.albinus@gmx.de>
7743
7744 * dbusbind.c (Fdbus_register_signal): When service is not
7745 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7746
32bbb17c
GM
77472011-09-25 Glenn Morris <rgm@gnu.org>
7748
7749 * buffer.c (truncate-lines): Doc fix.
7750
94e0933e
CY
77512011-09-24 Chong Yidong <cyd@stupidchicken.com>
7752
7753 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7754 (Fset_window_next_buffers): Doc fix.
7755
cddde921
GM
77562011-09-24 Glenn Morris <rgm@gnu.org>
7757
7758 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7759
1260aef1
PE
77602011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7761
25b4bfa0
PE
7762 Fix minor problems found by static checking.
7763 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7764 * indent.c (Fvertical_motion): Fix == vs = typo.
7765
e3cbd34b
EZ
77662011-09-24 Eli Zaretskii <eliz@gnu.org>
7767
a66cfb1c
SM
7768 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7769 Default value is now t. Doc fix.
6bf7006f 7770
e3cbd34b 7771 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7772 logic when moving up, not only when moving down. Fix the
e3cbd34b 7773 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7774 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7775
7776 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7777 CHARPOS is covered by a display string which includes newlines.
7778 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7779 is covered by a display string with embedded newlines.
7780
a3de0cbd
MA
77812011-09-24 Michael Albinus <michael.albinus@gmx.de>
7782
7783 * dbusbind.c (Fdbus_register_signal): Add match rule to
7784 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7785 (Fdbus_register_method, Vdbus_registered_objects_table):
7786 Fix docstring.
a3de0cbd 7787
b260039d
JM
77882011-09-24 Jim Meyering <meyering@redhat.com>
7789
32c1fffd 7790 do not ignore write error for any output size
b260039d
JM
7791 The previous change was incomplete.
7792 While it makes emacs --batch detect the vast majority of stdout
7793 write failures, errors were still ignored whenever the output size is
7794 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7795 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7796 && echo FAIL: ignored write error
7797 FAIL: ignored write error
7798 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7799 && echo FAIL: ignored write error
7800 FAIL: ignored write error
7801 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7802
8eca8a7c
AS
78032011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7804
7805 * emacs.c (Fkill_emacs): In noninteractive mode exit
7806 non-successfully if a write error occurred on stdout. (Bug#9574)
7807
3341db62
EZ
78082011-09-21 Eli Zaretskii <eliz@gnu.org>
7809
7810 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7811 the xassert test.
7812
7813 * dispextern.h (struct it): Update the comment documenting what
7814 can it->OBJECT be.
7815
8c203dbf
EZ
78162011-09-20 Eli Zaretskii <eliz@gnu.org>
7817
7818 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7819 a display string, extend search for cursor position to end of row.
7820 (find_row_edges): If the row ends in a newline from a display
7821 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7822 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7823 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7824 non-empty line. Fixes confusing cursor motion with arrow keys at
7825 the beginning of a line that starts with whitespace.
8c203dbf 7826
a4824228
LMI
78272011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7828
7829 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7830 (bug#9493).
7831
33ed493b
CY
78322011-09-18 Chong Yidong <cyd@stupidchicken.com>
7833
7834 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7835 boolean (Bug#9154).
7836
56cd55c8
EZ
78372011-09-18 Eli Zaretskii <eliz@gnu.org>
7838
7839 * xdisp.c (display_line): Record maximum and minimum buffer
7840 positions even if no glyphs were produced (e.g., by a zero-width
7841 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7842 buffer positions that will be removed from the glyph row because
7843 they don't fit.
c02dcedf
EZ
7844 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7845 column is beyond frame width: don't subtract 1 "pixel" when
7846 computing width of the stretch.
3e62b7e0
EZ
7847 (reseat_at_next_visible_line_start): Undo the change made on
7848 2011-09-17 that saved paragraph information and restored it after
7849 the call to `reseat'. (Bug#9545)
56cd55c8 7850
5ed99d36 78512011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7852
7853 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7854 and turn window cursor on if cleared (Bug#9415).
7855
5ed99d36 78562011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7857
7858 * search.c (boyer_moore): Take unibyte characters from pattern
7859 literally. (Bug#9458)
7860
9bade7b2
EZ
78612011-09-18 Eli Zaretskii <eliz@gnu.org>
7862
7863 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7864
e5e9d610
PE
78652011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7866
87e4427a
PE
7867 Fix minor problem found by static checking.
7868 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7869 initialized, to pacify gcc -Wuninitialized.
7870
e5e9d610
PE
7871 * fileio.c: Report proper errno when syscall falls.
7872 (Finsert_file_contents): Save and restore errno,
7873 so that report_file_error outputs the correct diagnostic.
7874 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7875
a1674f0b
EZ
78762011-09-18 Eli Zaretskii <eliz@gnu.org>
7877
7878 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7879
fbfb6dd4
EZ
78802011-09-17 Eli Zaretskii <eliz@gnu.org>
7881
7882 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7883 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7884
bb187662
EZ
78852011-09-17 Eli Zaretskii <eliz@gnu.org>
7886
1137e8b8 7887 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7888 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7889
7890 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7891 (bidi_find_paragraph_start): Search back for paragraph beginning
7892 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7893 (bidi_move_to_visually_next): Only trigger paragraph-related
7894 computations when the last character is a newline or at EOB, not
7895 just any NEUTRAL_B. (Bug#9470)
7896
bb187662
EZ
7897 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7898 truncated lines if point is covered by a display string. (Bug#9524)
7899
2e621251
PE
79002011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7901
7902 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7903 (cons_to_x_long): New function.
7904 (lisp_data_to_selection_data): Use it. Correct the test for
7905 short-versus-long data; it was negated. Break out of vector
7906 loop, for efficiency, when a long datum is discovered.
7907
91a15bc6
SM
79082011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7909
7910 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7911
b41c3a35
EZ
79122011-09-16 Eli Zaretskii <eliz@gnu.org>
7913
7914 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7915 GCC PR/17406) by declaring this function with external scope.
7916
7812ba2d
PE
79172011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7918
7919 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7920 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7921
cf7edc2a
AS
79222011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7923
7924 * editfns.c (Fformat): Correctly handle text properties on "%%".
7925
bd01620e
EZ
79262011-09-15 Eli Zaretskii <eliz@gnu.org>
7927
7928 * xterm.c (x_draw_composite_glyph_string_foreground):
7929 * w32term.c (x_draw_composite_glyph_string_foreground):
7930 * term.c (encode_terminal_code):
7931 * composite.c (composition_update_it, get_composition_id):
7932 * xdisp.c (get_next_display_element)
7933 (fill_composite_glyph_string): Add comments about special meaning
7934 of TAB characters in a composition.
7935
a02719a3
PE
79362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7937
7938 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7939 This occurs when processing a multibyte format.
7940 Problem reported by Wolfgang Jenker.
a02719a3 7941
72589a3c
JB
79422011-09-15 Johan Bockgård <bojohan@gnu.org>
7943
7944 * xdisp.c (try_cursor_movement): Only check for exact match if
7945 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7946
1c14176c
PE
79472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7948
7949 Remove unused external symbols.
7950 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7951 * xdisp.c (calc_pixel_width_or_height): Now static.
7952 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7953 * indent.c (check_display_width):
7954 * w32term.c: Fix comment to match code.
7955 * xterm.c, xterm.h (x_catching_errors): Remove.
7956
d2eea5b5
PE
79572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7958
7959 * xselect.c: Use signed conversions more consistently (Bug#9498).
7960 (selection_data_to_lisp_data): Assume incoming selection data are
7961 signed integers, not unsigned. This is to be consistent with
7962 outgoing selection data, which was modified to use signed integers
7963 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7964 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7965 expects long, not unsigned long.
7966
46888499
EZ
79672011-09-14 Eli Zaretskii <eliz@gnu.org>
7968
7969 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7970 computation of loop end. Reported by Johan Bockgård
7971 <bojohan@gnu.org>.
7972
ef8ef9fb
CY
79732011-09-13 Chong Yidong <cyd@stupidchicken.com>
7974
7975 * frame.c (Fother_visible_frames_p): Function deleted.
7976
fa819fed
EZ
79772011-09-12 Eli Zaretskii <eliz@gnu.org>
7978
7979 * indent.c (compute_motion): Process display vector front to back
7980 rather than the other way around. (Bug#2496)
7981
2ba8e008
SM
79822011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7983
7984 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7985
20f53c69
CY
79862011-09-11 Chong Yidong <cyd@stupidchicken.com>
7987
7988 * minibuf.c (Fread_from_minibuffer): Doc fix.
7989
d562d7a4
EZ
79902011-09-11 Eli Zaretskii <eliz@gnu.org>
7991
7992 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7993 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7994
1c4d7f3d
LMI
79952011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7996
7997 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7998 value for non-existent files.
7999
b885bf36
EZ
80002011-09-11 Eli Zaretskii <eliz@gnu.org>
8001
8002 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8003 set its "size" to -1. This will set the modtime_size field of
8004 the corresponding buffer to -1, which is what
8005 verify-visited-file-modtime expects for files that do not exist.
8006 (Bug#9139)
8007
6612f0bf
PE
80082011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8009
8010 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8011 here ...
8012 * lisp.h: ... from here. push_key_description is no longer
8013 defined in keyboard.c, so its declaration should not be in
8014 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8015 logically belongs with push_key_description.
8016
dfb3f755
PE
80172011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8018
8019 * buffer.h: Include <sys/types.h> instead of <time.h>.
8020 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8021 Problem reported by Herbert J. Skuhra.
8022
3134906c
LMI
80232011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8024
8025 * xml.c (parse_region): Make the parsing work for
8026 non-comment-starting XML files again (bug#9144).
8027
8d903f4e
AS
80282011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8029
8030 * image.c (gif_load): Fix calculation of bottom and right corner.
8031 (Bug#9468)
8032
80ad64f4
EZ
80332011-09-10 Eli Zaretskii <eliz@gnu.org>
8034
8035 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8036 redisplay in small windows.
8037
208a048d
EZ
80382011-09-09 Eli Zaretskii <eliz@gnu.org>
8039
8040 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8041
9b1c252e
MR
80422011-09-08 Martin Rudalics <rudalics@gmx.at>
8043
8044 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8045 Operate on live windows only.
8046
2949f33b
JB
80472011-09-08 Juanma Barranquero <lekktu@gmail.com>
8048
8049 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8050
e08dcafd
EZ
80512011-09-07 Eli Zaretskii <eliz@gnu.org>
8052
8053 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8054 only under bidi iteration.
8055
115b96bd
JD
80562011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8057
8058 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8059
c8199d0f
PE
80602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8061
8062 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8063 Without this fix, the command to link temacs failed due to an
8064 undefined symbol __builtin_isnan. This is because
8065 /usr/include/iso/math_c99.h #defines isnan(x) to
8066 __builtin_isnan(x), but the bundled gcc, which identifies itself
8067 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8068 a __builtin_isnan.
8069 * floatfns.c (isnan): #undef, and then #define to a clone of
8070 what's in data.c.
8071 (Fisnan): Always define, since it's always available now.
8072 (syms_of_floatfns): Always define isnan at the Lisp level.
8073
e39b275c 80742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8075
8076 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8077
b2db44d9 80782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8079
f4af5137 8080 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8081 The previous code assumed that file offsets (off_t values) fit in
8082 EMACS_INT variables, which is not true on typical 32-bit hosts.
8083 The code messed up by falsely reporting buffer overflow in cases
8084 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8085 when "big" contains more than 2**29 bytes, even though this
8086 inserts just one byte and does not overflow the buffer.
8087 (Finsert_file_contents): Store file offsets as off_t
8088 values, not as EMACS_INT values. Check for overflow when
8089 converting between EMACS_INT and off_t. When checking for
8090 buffer overflow or for overlap, take the offsets into account.
8091 Don't use EMACS_INT for small values where int suffices.
8092 When checking for overlap, fix a typo: ZV was used where
8093 ZV_BYTE was intended.
8094 (Fwrite_region): Don't assume off_t fits into 'long'.
8095 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8096
ecfc0a49
MA
80972011-09-05 Michael Albinus <michael.albinus@gmx.de>
8098
8099 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8100
6511acf2 81012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8102
0999621a 8103 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8104
8105 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8106 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8107 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8108 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8109 (modify_event_symbol): Do not assume that the length of
8110 name_alist_or_stem is safe to alloca and fits in int.
8111 (Fexecute_extended_command): Likewise for function name and binding.
8112 (Frecursion_depth): Wrap around reliably on integer overflow.
8113 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8114 since some callers pass EMACS_INT values.
8115 (Fsingle_key_description): Don't crash if symbol name contains more
8116 than MAX_ALLOCA bytes.
8117 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8118 (get_minibuffer): Arg is now EMACS_INT, not int.
8119 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8120 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8121 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8122
2be7d702
PE
8123 * dbusbind.c (signature_cat): New function.
8124 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8125 Do not overrun buffer; instead, report string overflow.
8126
9d1df220
PE
8127 * dispnew.c (add_window_display_history): Don't overrun buffer.
8128 Truncate instead; this is OK since it's just a log.
8129
33ef5c64
PE
8130 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8131 even if the time zone offset is outlandishly large.
8132 Don't mishandle offset == INT_MIN.
8133
66c6fdd5
PE
8134 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8135 when creating daemon; the previous buffer-overflow check was incorrect.
8136
d749b01b
PE
8137 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8138 which has the guts of the old verror function.
8139
b5cd1905
PE
8140 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8141 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8142
6e1a67fb
PE
8143 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8144 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8145 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8146 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8147 length of string rather than counting it via multiple sprintfs;
8148 that's simpler and more reliable.
c21721cc
PE
8149 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8150 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8151 sprintf, in case result does not fit in int.
8152
c57b67fc
PE
8153 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8154 (fontset_from_font): Print it.
8155
8a401434
PE
8156 * frame.c (tty_frame_count): Now printmax_t, not int.
8157 (make_terminal_frame, set_term_frame_name): Print it.
8158 (x_report_frame_params): In X, window IDs are unsigned long,
8159 not signed long, so print them as unsigned.
8160 (validate_x_resource_name): Check for implausibly long names,
8161 and don't assume name length fits in 'int'.
8162 (x_get_resource_string): Don't blindly alloca invocation name;
8163 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8164 not fit in int.
8165
6e1a67fb
PE
8166 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8167 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8168 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8169
0df02bf3
PE
8170 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8171 Use esprintf, not sprintf, in case result does not fit in int.
8172
48e30793
PE
8173 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8174 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8175 it as a large positive number.
8176 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8177 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8178
a66ff6d8
PE
8179 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8180 in case result does not fit in int.
8181
aca216ff
PE
8182 * print.c (float_to_string): Detect width overflow more reliably.
8183 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8184 buffer overrun. Don't assume list length fits in 'int'. Treat
8185 print length of 0 as 0, not as infinity; to be consistent with other
8186 uses of print length in this function. Don't overflow print length
8187 index. Don't assume hash table size fits in 'long', or that
8188 vectorlike size fits in 'unsigned long'.
8189
31c286f7
PE
8190 * process.c (make_process): Use printmax_t, not int, to format
8191 process-name gensyms.
8192
55e5faa1
PE
8193 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8194
80f2e268
PE
8195 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8196 to avoid potential buffer overrun.
8197
670741ab
PE
8198 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8199 if X resource line is longer than 512 bytes.
8200
b7163a50
PE
8201 * xfns.c (x_window): Make sprintf buffer a bit bigger
8202 to avoid potential buffer overrun.
8203
ae58ff1f
PE
8204 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8205
c43c8a6a
PE
8206 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8207
3f8236f4
PE
82082011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8209
53e9fe90 8210 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8211 Without these, Emacs silently mishandles large integers sometimes.
8212 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8213 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8214
6511acf2
PE
8215 * xdisp.c (try_window_id): Check Emacs fixnum range before
8216 converting to 'int'.
806add1d 8217
6511acf2 8218 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8219 Check that an Emacs fixnum is in range before assigning it to 'int'.
8220 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8221 values converted from Emacs fixnums.
8222 (Frecenter): Don't wrap around a line count if it is out of 'int'
8223 range; instead, treat it as an extreme value.
8224 (Fset_window_configuration, compare_window_configurations):
8225 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8226
6511acf2
PE
8227 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8228 that can exceed INT_MAX. Check that EMACS_INT value is in range
8229 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8230 (match_limit): Don't assume that a fixnum can fit in 'int'.
8231
6511acf2 8232 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8233 exceed INT_MAX.
8234
6511acf2 8235 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8236 (Fvertical_motion): Don't wrap around LINES values that don't fit
8237 in 'int'. Instead, treat them as extreme values. This is good
8238 enough for windows, which can't have more than INT_MAX lines anyway.
8239
fcb901a7
LMI
82402011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8241
0f2f6b6d
LMI
8242 * Require libxml/parser.h to avoid compilation warning.
8243
fcb901a7
LMI
8244 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8245
8246 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8247 since this reportedly can destroy thread storage.
8248
6e20a0d4
CY
82492011-08-30 Chong Yidong <cyd@stupidchicken.com>
8250
8251 * syntax.c (find_defun_start): Update all cache variables if
8252 exiting early (Bug#9401).
8253
148ae00e
EZ
82542011-08-30 Eli Zaretskii <eliz@gnu.org>
8255
f6cfbd8f
EZ
8256 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8257
148ae00e
EZ
8258 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8259 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8260 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8261
8262 * term.c (tty_append_glyph): New function.
8263 (produce_stretch_glyph): Static function and its prototype deleted.
8264
a66cfb1c
SM
8265 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8266 Add prototypes.
148ae00e 8267
c4a07a4c
PE
82682011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8269
8270 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8271 when checking :margin (Bug#9390).
8272 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8273 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8274 so that the name doesn't mislead. All uses changed.
8275
6bc8cd65
JB
82762011-08-28 Johan Bockgård <bojohan@gnu.org>
8277
8278 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8279 set_tty_hooks.
8280
dca4927e
EZ
82812011-08-27 Eli Zaretskii <eliz@gnu.org>
8282
8283 * xdisp.c (move_it_to): Don't bail out early when reaching
8284 position beyond to_charpos, if we are scanning backwards.
8285 (move_it_vertically_backward): When DY == 0, make sure we get to
8286 the first character in the line after the newline.
8287
f2cad773
PE
82882011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8289
8290 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8291 (ccl_driver): Do not generate an out-of-range pointer.
8292 (Fccl_execute_on_string): Remove unnecessary check for
8293 integer overflow, noted by Stefan Monnier in
8294 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8295 Remove a FIXME that didn't need fixing.
8296 Simplify the newly-introduced buffer reallocation code.
8297
0cae2cdb
JB
82982011-08-27 Juanma Barranquero <lekktu@gmail.com>
8299
8300 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8301
5fc295a4 83022011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8303
70c60eb2 8304 Integer and memory overflow issues (Bug#9196).
726e0ab1 8305
d31850da
PE
8306 * doc.c (get_doc_string): Rework so that
8307 get_doc_string_buffer_size is the actual buffer size, rather than
8308 being 1 less than the actual buffer size; this makes xpalloc more
8309 convenient.
8310
a69fbedb
PE
8311 * image.c (x_allocate_bitmap_record, cache_image):
8312 * xselect.c (Fx_register_dnd_atom):
8313 Simplify previous changes by using xpalloc.
8314
fe5c5d37
PE
8315 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8316 since either will do and ptrdiff_t is convenient with xpalloc.
8317
0065d054
PE
8318 * charset.c (charset_table_size)
8319 (struct charset_sort_data.priority): Now ptrdiff_t.
8320 (charset_compare): Don't overflow if priorities differ greatly.
8321 (Fsort_charsets): Don't assume list length fits in int.
8322 Check for size-calculation overflow when allocating sort data.
8323 (syms_of_charset): Allocate an initial charset table that is
8324 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8325
8326 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8327
8328 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8329 The actual value is always <= INT_MAX, and leaving it unsigned made
8330 overflow checking harder.
8331
8332 * dispextern.h (struct glyph_matrix.rows_allocated)
8333 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8334 with xpalloc. The values are still always <= INT_MAX.
8335
8336 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8337
8338 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8339 (SAFE_NALLOCA): New macro.
8340
8341 * region-cache.c (struct boundary.pos, find_cache_boundary)
8342 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8343 (set_cache_region, invalidate_region_cache)
8344 (revalidate_region_cache, know_region_cache, region_cache_forward)
8345 (region_cache_backward, pp_cache):
8346 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8347 so that ptrdiff_t * can be passed to xpalloc.
8348 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8349 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8350 (pp_cache): Don't assume cache_len fits in int.
8351 * region-cache.h: Adjust extern decls to match.
8352
8353 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8354 EMACS_INT, since either will do, for xpalloc.
8355
8356 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8357 (xnmalloc, xnrealloc, xpalloc): New functions.
8358
726e0ab1
PE
8359 * bidi.c (bidi_shelve_header_size): New constant.
8360 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8361 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8362
51f30bc5 8363 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8364 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8365 (overlay_strings):
8366 Don't update size of array until after memory allocation succeeds,
8367 because xmalloc/xrealloc may not return.
0065d054
PE
8368 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8369 now that we have proper integer overflow checking.
8370 (record_overlay_string, overlay_strings): Catch overflows when
8371 calculating size of overlay_str_buf.
726e0ab1 8372
0065d054
PE
8373 * callproc.c (Fcall_process): Check for size overflow when
8374 calculating size of args2.
8375 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8376 Normally we prefer signed values, but sticking with ptrdiff_t would
8377 require adding more-complicated checks.
726e0ab1
PE
8378
8379 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8380 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8381 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8382 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8383
8384 * character.c (Fstring): Check for size-calculation overflow.
8385
8386 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8387 unnecessary integer overflow. Check for size overflow.
8388 (encode_coding_object): Don't update size until xmalloc succeeds.
8389
8390 * composite.c (get_composition_id): Check for overflow in glyph
8391 length calculations.
8392
8393 Integer and memory overflow fixes for display code.
8394 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8395 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8396 (scrolling_window): Check for overflow in size calculations.
8397 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8398 Don't assume glyph table len fits in int.
8399 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8400 (row_table_size): Now ptrdiff_t, not int.
8401 (scrolling_window): Avoid overflow in size calculations.
8402 Don't update size until allocation succeeds.
8403 * fns.c (concat): Check for overflow in size calculations.
8404 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8405 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8406 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8407
8408 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8409 (get_doc_string): Check for size calculation overflow.
8410 Don't update size until allocation succeeds.
8411 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8412 EMACS_INT, where ptrdiff_t will do.
8413 (Fsubstitute_command_keys): Check for string overflow.
8414
8415 * editfns.c (set_time_zone_rule): Don't assume environment length
8416 fits in int.
8417 (message_length): Now ptrdiff_t, not int.
8418 (Fmessage_box): Don't update size until allocation succeeds.
8419 Don't assume message length fits in int.
8420 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8421
0065d054
PE
8422 * emacs.c (main): Do not reallocate argv, since there is a null at
8423 the end that can be overwritten, and this way there's no need to
8424 worry about size-calculation overflow.
8425 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8426
8427 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8428 alloc succeeds.
8429 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8430
8431 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8432 (x_set_scroll_bar_width, x_figure_window_size):
8433 Check for integer overflow.
8434 (x_set_alpha): Do not assume XINT fits in int.
8435
8436 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8437 This is for the members text_lines, text_cols, total_lines, total_cols,
8438 where the system imposes an 'int' limit.
8439
8440 * fringe.c (Fdefine_fringe_bitmap):
8441 Don't update size until alloc works.
8442
8443 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8444 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8445
8446 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8447 Check for size-calculation overflow.
8448 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8449 do, as we prefer signed integers.
8450 (id_to_widget.max_size, id_to_widget.used)
8451 (xg_store_widget_in_map, xg_remove_widget_from_map)
8452 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8453 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8454 Use and return ptrdiff_t, not int.
8455 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8456 * gtkutil.h: Change prototypes to match the above.
8457
8458 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8459 are duplicate now that they've been promoted to lisp.h.
8460 (x_allocate_bitmap_record, x_alloc_image_color)
8461 (make_image_cache, cache_image, xpm_load):
8462 Don't update size until alloc is done.
8463 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8464 (x_detect_edges):
3256efce 8465 Check for size calculation overflow.
726e0ab1
PE
8466 (ct_colors_allocated_max): New constant.
8467 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8468 overflow.
3256efce 8469
726e0ab1
PE
8470 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8471 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8472 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8473 Use ptrdiff_t, not int, to count maps.
8474 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8475 calculations. Don't update size until allocation succeeds.
8476 Redo calculations to avoid overflow.
726e0ab1
PE
8477 * keyboard.h: Change prototypes to match the above.
8478
8479 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8480 to count maps.
8481 (current_minor_maps): Check for size calculation overflow.
8482 * keymap.h: Change prototypes to match the above.
8483
8484 * lread.c (read1, init_obarray): Don't update size until alloc done.
8485
8486 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8487 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8488
726e0ab1
PE
8489 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8490 Now ptrdiff_t, not int.
8491 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8492 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8493
8494 * process.c (Fnetwork_interface_list): Check for overflow
8495 in size calculation.
8496
8497 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8498
8499 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8500 overflow. Don't bother calling xmalloc when xrealloc will do.
8501
8502 * search.c (Freplace_match): Check for size calculation overflow.
8503 (Fset_match_data): Don't assume list lengths fit in 'int'.
8504
8505 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8506 for command line length. Do not attempt to address one before the
8507 beginning of an array, as that's not portable.
8508
8509 * term.c (max_frame_lines): Remove; unused.
8510 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8511 not int.
8512 (encode_terminal_code, calculate_costs): Check for size
8513 calculation overflow.
8514 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8515 table lengths and related sizes. Don't update size until alloc
8516 done. Redo calculations to avoid overflow.
8517 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8518
8519 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8520 subtracting pointers.
8521 (gobble_line): Check for overflow more carefully. Don't update size
8522 until alloc done.
8523
8524 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8525 Don't update size until alloc done.
8526 Redo size calculations to avoid overflow.
8527 Check for size calculation overflow.
0065d054 8528 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8529
8530 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8531 Use ptrdiff_t, not int, for sizes.
8532 (store_mode_line_noprop_char): Don't update size until alloc done.
8533
0065d054
PE
8534 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8535 Use ptrdiff_t, not int, for sizes.
8536 (Finternal_make_lisp_face, cache_face):
8537 Check for size calculation overflow.
8538 (cache_face): Treat size calculation overflows as if they were
8539 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8540
8541 * xfns.c (x_encode_text, x_set_name_internal)
8542 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8543 sizes, since they can exceed INT_MAX in size. Check for size
8544 calculation overflow.
8545
0065d054
PE
8546 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8547 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8548 Don't update size until alloc done.
8549
0065d054 8550 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8551 as sprintf is limited to int lengths.
1d526e2f 8552
252c5ee1
PE
8553 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8554 (X_LONG_MIN): New macros.
864d7ce7
PE
8555 Use them to make the following changes clearer.
8556 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8557 This change doesn't affect the value now, but it may help remind
8558 future maintainers not to raise the value too much later.
8559 (SELECTION_QUANTUM): Remove, replacing with ...
8560 (selection_quantum): ... new function, which avoids overflow.
8561 All uses changed.
8562 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8563 assumption that selection length fits in 'int'.
8564 (x_reply_selection_request, x_handle_selection_request)
8565 (x_get_window_property, receive_incremental_selection)
8566 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8567 (lisp_data_to_selection_data, clean_local_selection_data):
8568 Use ptrdiff_t, not int, to record length of selection.
8569 (x_reply_selection_request, x_get_window_property)
8570 (receive_incremental_selection, x_property_data_to_lisp):
8571 Redo calculations to avoid overflow.
8572 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8573 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8574 something.
8575 (x_get_window_property, receive_incremental_selection)
8576 (lisp_data_to_selection_data, x_property_data_to_lisp):
8577 Check for size-calculation overflow.
8578 (x_get_window_property, receive_incremental_selection)
8579 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8580 Don't store size until memory allocation succeeds.
8581 (x_get_window_property): Plug memory leak on memory exhaustion.
8582 Don't double-block input; malloc is safe here. Don't assume 2**34
8583 - 4 fits in unsigned long. Add an xassert to check
8584 XGetWindowProperty overflow. Be more careful about overflow
8585 calculations, and distinguish size from memory overflow better.
8586 (receive_incremental_selection): When tracing, don't assume
8587 unsigned int is less than INT_MAX.
8588 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8589 harmful) conversions of unsigned short to int.
8590 (lisp_data_to_selection_data): Don't assume that integers
8591 in the range -65535 through -1 fit in an X unsigned short.
8592 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8593 result parameters unless successful. Rely on cons_to_unsigned
8594 to report problems with elements; the old code wasn't right anyway.
8595 (x_check_property_data): Check for int overflow; we cannot use
8596 a wider type due to X limits.
8597 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8598
726e0ab1 8599 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8600
0065d054
PE
8601 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8602 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8603 (x_color_cells): Don't store size until memory allocation succeeds.
8604 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8605 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8606 (x_term_init): Don't assume length fits in int (sprintf is limited
8607 to int size).
bc18e09d 8608
ebfa62c0
PE
8609 Use ptrdiff_t for composition IDs.
8610 * character.c (lisp_string_width):
8611 * composite.c (composition_table_size, n_compositions)
8612 (get_composition_id, composition_gstring_from_id):
8613 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8614 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8615 * window.c (Frecenter):
8616 Use ptrdiff_t, not int, for composition IDs.
8617 * composite.c (get_composition_id): Check for integer overflow.
8618 * composite.h: Adjust prototypes to match the above changes.
8619
d3411f89
PE
8620 Use ptrdiff_t for hash table indexes.
8621 * category.c (hash_get_category_set):
8622 * ccl.c (ccl_driver):
8623 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8624 * coding.c (coding_system_charset_list, detect_coding_system):
8625 * coding.h (struct coding_system.id):
8626 * composite.c (get_composition_id, gstring_lookup_cache):
8627 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8628 * image.c (xpm_get_color_table_h):
8629 * lisp.h (hash_lookup, hash_put):
8630 * minibuf.c (Ftest_completion):
8631 Use ptrdiff_t for hash table indexes, not int (which is too
8632 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8633 32-bit --with-wide-int hosts).
8634
e097a6fa
PE
8635 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8636 Add a FIXME comment about memory leaks.
8637 (syms_of_charset): Don't assume xmalloc returns.
8638
5637687f
PE
8639 Don't assume that stated character widths fit in int.
8640 * character.c (Fchar_width, c_string_width, lisp_string_width):
8641 * character.h (CHAR_WIDTH):
8642 * indent.c (MULTIBYTE_BYTES_WIDTH):
8643 Use sanitize_char_width to avoid undefined and/or bad behavior
8644 with outlandish widths.
a66cfb1c 8645 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8646 now that we have two such functions. All uses changed.
8647 (sanitize_char_width): New inline function.
8648
a2271ba2
PE
8649 Don't assume that tab-width fits in int.
8650 * character.h (sanitize_width): New inline function.
8651 (SANE_TAB_WIDTH): New macro.
8652 (ASCII_CHAR_WIDTH): Use it.
8653 * indent.c (sane_tab_width): Remove. All uses replaced by
8654 SANE_TAB_WIDTH (current_buffer).
8655 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8656
18c52557
PE
8657 * fileio.c: Integer overflow issues with file modes.
8658 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8659
caeeedc1
PE
8660 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8661 Remove unreachable code.
8662 (read_hex, load_charset_map_from_file): Check for integer overflow.
8663
6df6ae42 8664 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8665 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8666 (x_send_scroll_bar_event): Likewise. Check that the size does not
8667 exceed limits imposed by XClientMessageEvent, as well as the usual
8668 ptrdiff_t and size_t limits.
8669
b13995db
PE
8670 * keyboard.c: Overflow, signedness and related fixes.
8671 (make_lispy_movement): Use same integer type in forward decl
8672 that is used in the definition.
8673 (read_key_sequence, keyremap_step):
8674 Change bufsize argument back to int, undoing my 2011-03-30 change.
8675 We prefer signed types, and int is wide enough here.
8676 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8677 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8678 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8679 length, not size_t. Use ptrdiff_t for index, not int.
8680 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8681 possibility of integer overflow.
8682
13464394
PE
8683 Overflow, signedness and related fixes for images.
8684
8685 * dispextern.h (struct it.stack[0].u.image.image_id)
8686 (struct_it.image_id, struct image.id, struct image_cache.size)
8687 (struct image_cache.used, struct image_cache.ref_count):
8688 * gtkutil.c (update_frame_tool_bar):
8689 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8690 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8691 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8692 * nsmenu.m (update_frame_tool_bar):
8693 * xdisp.c (calc_pixel_width_or_height):
8694 * xfns.c (image_cache_refcount):
8695 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8696 on typical 64-bit hosts.
8697
8698 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8699 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8700 Omit unnecessary casts to int.
8701 (parse_image_spec): Check that integers fall into 'int' range
8702 when the callers expect that.
8703 (image_ascent): Redo ascent calculation to avoid int overflow.
8704 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8705 (lookup_image): Remove unnecessary tests.
8706 (xbm_image_p): Locals are now of int, not EMACS_INT,
8707 since parse_image_check makes sure they fit into int.
8708 (png_load, gif_load, svg_load_image):
8709 Prefer int to unsigned where either will do.
8710 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8711 old tiff_error_handler and tiff_warning_handler.
8712 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8713 stack buffer overflows. It uses only the features of vsnprintf
8714 that are common to both POSIX and native Microsoft.
8715 (tiff_error_handler, tiff_warning_handler): Use it.
8716 (tiff_load, gif_load, imagemagick_load_image):
8717 Don't assume :index value fits in 'int'.
8718 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8719 (imagemagick_load_image): Check that crop parameters fit into
8720 the integer types that MagickCropImage accepts. Don't assume
8721 Vimagemagick_render_type has a nonnegative value. Don't assume
8722 size_t fits in 'long'.
8723 (gs_load): Use printmax_t to print the widest integers possible.
8724 Check for integer overflow when computing image height and width.
8725
c11821d4
EZ
87262011-08-26 Eli Zaretskii <eliz@gnu.org>
8727
8728 * xdisp.c (redisplay_window): Don't force window start if point
8729 will be invisible in the resulting window. (Bug#9324)
8730
0c95fcf7
EZ
87312011-08-25 Eli Zaretskii <eliz@gnu.org>
8732
8733 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8734 the display spec is of the form `(space ...)'.
8735 (handle_display_spec): Return the value returned by
8736 handle_single_display_spec, not just 1 or zero.
8737 (handle_single_display_spec): If the display spec is of the form
8738 `(space ...)', and specifies display in the text area, return 2
8739 rather than 1.
fee65a97 8740 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8741 accurately, and prefer exact match for point under bidi.
8742 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8743
8744 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8745 into disp_prop; all users changed.
8746
8747 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8748 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8749 for the text covered by the display property.
8750
e4ed06f1
CY
87512011-08-25 Chong Yidong <cyd@stupidchicken.com>
8752
8753 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8754 Change return value to nil.
8755 (Frecord_buffer): Delete unused function.
8756
f67cdd7f
EZ
87572011-08-24 Eli Zaretskii <eliz@gnu.org>
8758
5980d4c6
EZ
8759 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8760 buffers, return left-to-right.
8610fe8b
EZ
8761 (set_cursor_from_row): Consider candidate row a win if its glyph
8762 represents a newline and point is on that newline. Fixes cursor
8763 positioning on the newline at EOL of R2L text within L2R
8764 paragraph, and vice versa.
8765 (try_cursor_movement): Check continued rows, in addition to
8766 continuation rows. Fixes unwarranted scroll when point enters a
8767 continued line of R2L text within an L2R paragraph, or vice versa.
8768 (cursor_row_p): Consider the case of point being equal to
8769 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8770 from the end of a short line to the beginning of a continued line
8771 of R2L text within L2R paragraph.
8772 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8773 composed characters.
5980d4c6 8774
f67cdd7f
EZ
8775 * bidi.c (bidi_check_type): Use xassert.
8776 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8777 members.
8778
bca633fb
EZ
87792011-08-23 Eli Zaretskii <eliz@gnu.org>
8780
8781 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8782 a character.
8783
4a5885a7
CY
87842011-08-23 Chong Yidong <cyd@stupidchicken.com>
8785
8786 * nsfont.m (ns_otf_to_script): Fix typo.
8787
0902a04e
KH
87882011-08-22 Kenichi Handa <handa@m17n.org>
8789
8790 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8791 extra slot even if the purpose is char-code-property-table.
8792
1a2e6670
EZ
87932011-08-23 Eli Zaretskii <eliz@gnu.org>
8794
8ddde651
EZ
8795 * xdisp.c (redisplay_window): When computing centering_position,
8796 account for the height of the header line. (Bug#8874)
8797
425cc014
EZ
8798 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8799 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8800 candidate is selected by the mouse, and that candidate has a
8801 composed character under the mouse.
8802
1a2e6670
EZ
8803 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8804 coordinates reported by pos-visible-in-window-p for a composed
8805 character in column zero.
8806
8b76d6f8
SM
88072011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8808
8809 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8810
dac347dd
EZ
88112011-08-22 Eli Zaretskii <eliz@gnu.org>
8812
8813 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8814 consider it a hit if to_charpos is anywhere in the range of the
8815 composed buffer positions.
8816
e013fb34
CY
88172011-08-22 Chong Yidong <cyd@stupidchicken.com>
8818
8819 * image.c (gif_load): Don't assume that each subimage has the same
8820 dimensions as the base image. Handle disposal method that is
8821 "undefined" by the gif spec (Bug#9335).
8822
bd1ba3e8
CY
88232011-08-20 Chong Yidong <cyd@stupidchicken.com>
8824
8825 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8826 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8827
54a1215b
EZ
88282011-08-19 Eli Zaretskii <eliz@gnu.org>
8829
823564e5
EZ
8830 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8831 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8832 from an Org mode buffer to a Speedbar frame.
8833
54a1215b
EZ
8834 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8835 a composition, take its buffer position from IT->cmp_it.charpos.
8836 Fixes cursor positioning at the beginning of a line that begins
8837 with a composed character.
8838
9778ebcc
EZ
88392011-08-18 Eli Zaretskii <eliz@gnu.org>
8840
0be6ee06
EZ
8841 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8842 character bidirectional type, use STRONG_L instead. Fixes crashes
8843 in a buffer produced by `describe-categories'.
8844
9778ebcc
EZ
8845 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8846 members before the level stack, so they would be saved and
8847 restored when copying iterator state. Fixes incorrect reordering
8848 around TABs covered by display properties.
8849
156bffbe
AS
88502011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8851
6b02f655 8852 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8853
72ad093b
CY
88542011-08-17 Chong Yidong <cyd@stupidchicken.com>
8855
8856 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8857 (internal_condition_case_2, internal_condition_case_n):
8858 Remove unnecessary aborts (Bug#9081).
72ad093b 8859
35774242
EZ
88602011-08-17 Eli Zaretskii <eliz@gnu.org>
8861
8862 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8863 has no `load' handler, try opening the file locally. (Bug#9311)
8864
db76dd85
KB
88652011-08-16 Ken Brown <kbrown@cornell.edu>
8866
8867 * gmalloc.c: Expand comment.
8868
b215eee5
EZ
88692011-08-16 Eli Zaretskii <eliz@gnu.org>
8870
8871 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8872 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8873
a4579d33
KB
88742011-08-16 Ken Brown <kbrown@cornell.edu>
8875
8876 Fix memory allocation problems in Cygwin build (Bug#9273).
8877
8878 * unexcw.c ( __malloc_initialized): Declare external variable.
8879 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8880
8b76d6f8
SM
8881 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8882 New variables.
a4579d33
KB
8883 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8884 dumped emacs.
8885 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8886 in the static heap.
8887 [CYGWIN] (special_realloc): New function.
8888 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8889 requests to realloc storage in the static heap.
8890
3ebec551
PE
88912011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8892
8893 * bidi.c (bidi_initialize): Remove unused local.
8894
9fd8be00
EZ
88952011-08-15 Eli Zaretskii <eliz@gnu.org>
8896
6b02f655
SM
8897 * bidimirror.h:
8898 * biditype.h: Remove file.
8899 * makefile.w32-in ($(BLD)/bidi.$(O)):
8900 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8901
8902 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8903
8904 * chartab.c: Improve commentary for the uniprop_table API.
8905
32413314
EZ
8906 * bidi.c (bidi_paragraph_init): Support zero value of
8907 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8908 (bidi_initialize): Use uniprop_table instead of including
8909 biditype.h and bidimirror.h.
32413314 8910
9fd8be00
EZ
8911 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8912 coordinates of the iterator when restoring from ppos_it.
8913 (Bug#9296)
8914
5cf2b69b
KH
89152011-08-14 Kenichi Handa <handa@m17n.org>
8916
8917 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8918 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8919
daf17d00
EZ
89202011-08-14 Eli Zaretskii <eliz@gnu.org>
8921
8922 * xdisp.c (move_it_in_display_line_to): Don't invoke
8923 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8924 ppos_it. Fixes vertical cursor motion when line beginning is
8925 covered by an image. (Bug#9296)
8926
08e3161a
JD
89272011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8928
8929 * nsterm.h (ns_run_ascript): Declare.
8930 (NSAPP_DATA2_RUNASSCRIPT): Define.
8931
8932 * nsfns.m (as_script, as_result, as_status): New static variables.
8933 (ns_run_ascript): New function.
5e617bc2 8934 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8935 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8936 the event loop. Get status from as_status (Bug#7276).
8937
8938 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8939 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8940 the event loop (Bug#7276).
8941
a3720aa2
AS
89422011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8943
8944 * gnutls.c (QCgnutls_bootprop_priority)
8945 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8946 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8947 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8948 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8949 (QCgnutls_bootprop_verify_hostname_error)
8950 (QCgnutls_bootprop_callbacks_verify): Rename from
8951 Qgnutls_bootprop_..., all uses changed.
8952
8953 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8954 uses changed.
8955
0a0d27fb
PE
89562011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8957
19d5c50c
PE
8958 * xfaces.c (Qframe_set_background_mode): Now static.
8959 * dispextern.h (Qframe_set_background_mode): Remove decl.
8960
0a0d27fb
PE
8961 * process.c (Fnetwork_interface_info): Declare local only if needed.
8962
377538cb
JD
89632011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8964
8965 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8966 (Fnetwork_interface_list): Allocate in increments of bytes instead
8967 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8968 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8969 sockaddr.
8970 (struct ifflag_def): notrailers is smart on OSX.
8971 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8972 Get hardware address with getifaddrs if available.
8973
08fff70c
EZ
89742011-08-12 Eli Zaretskii <eliz@gnu.org>
8975
8976 * xdisp.c (iterate_out_of_display_property): xassert that
8977 IT->position is set to within IT->object's boundaries. Break from
8978 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8979 when IT->position is set up wrongly due to some bug.
8980 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8981 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8982 entry. Force push_it to save on the stack the current
8983 buffer/string position, to be restored by pop_it. Fix flags in
8984 the iterator structure wrt the object coming from a display
8985 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8986 properties. (Bug#9284)
8987
7be1c708 89882011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8989
7be1c708
CY
8990 * fontset.c (fontset_get_font_group): Add proper type checks.
8991 (Bug#9172)
aac0c6e3 8992
7be1c708 89932011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8994
7be1c708
CY
8995 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8996 and LC_VERSION_MIN_MACOSX.
8997 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8998 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8999
97bb72a6
EZ
90002011-08-08 Eli Zaretskii <eliz@gnu.org>
9001
9002 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9003 no-display-properties-and-no-overlays under bidi display.
9004 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9005 properties and overlays.
97bb72a6 9006
d5617611
CY
90072011-08-08 Chong Yidong <cyd@stupidchicken.com>
9008
37e11a63
CY
9009 * editfns.c (Fset_time_zone_rule): Document relationship with the
9010 setenv function.
9011
d5617611
CY
9012 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9013 the font entity extracted from the cache (Bug#8109).
9014
58872834
CY
90152011-08-07 Chong Yidong <cyd@stupidchicken.com>
9016
9017 * composite.c (autocmp_chars): Don't reset point. That is done by
9018 restore_point_unwind (Bug#5984).
9019
75bfc667
JL
90202011-08-07 Juri Linkov <juri@jurta.org>
9021
9022 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9023 to show the arg `TIME' instead of `TIMEVAL'.
9024
d1410150
EZ
90252011-08-06 Eli Zaretskii <eliz@gnu.org>
9026
9027 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9028 display property strides EOL and includes a newline, as in
9029 longlines-mode. (Bug#9254)
75b771e4
EZ
9030 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9031 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9032
9033 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9034 is non-zero, even if the data buffer is NULL. Fixes a crash in
9035 vertical-motion with longlines-mode. (Bug#9254)
9036
35928349
EZ
90372011-08-05 Eli Zaretskii <eliz@gnu.org>
9038
ec7cc85b
EZ
9039 * bidi.c <bidi_cache_total_alloc>: Now static.
9040 (bidi_initialize): Initialize bidi_cache_total_alloc.
9041
8b76d6f8 9042 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9043 cache. (Bug#9221)
9044
9045 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9046 amount allocated this far in `bidi_cache_total_alloc'.
9047 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9048 non-zero, only free the data buffer without restoring the cache
9049 contents. All callers changed.
9050
9051 * dispextern.h (bidi_unshelve_cache): Update prototype.
9052
9053 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9054 (move_it_in_display_line, move_it_to)
9055 (move_it_vertically_backward, move_it_by_lines): Replace the call
9056 to xfree to an equivalent call to bidi_unshelve_cache.
9057 (move_it_in_display_line_to): Fix logic of returning
412b6358 9058 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9059
e2e2423b
EZ
90602011-08-05 Eli Zaretskii <eliz@gnu.org>
9061
9062 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9063 came from a string character with a `cursor' property. (Bug#9229)
9064
ae9e757a
JD
90652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9066
9067 * Makefile.in (LIB_PTHREAD): New variable.
9068 (LIBES): Add LIB_PTHREAD (Bug#9216).
9069
9070 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9071 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9072
213bd7f2
AS
90732011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9074
6b02f655 9075 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9076
99aaf75f
JD
90772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9078
9079 * xterm.c (x_find_topmost_parent): New function.
9080 (x_set_frame_alpha): Find topmost parent window with
9081 x_find_topmost_parent and set the property there also (bug#9181).
9082 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9083
c74e9d86
PE
90842011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9085
9086 * callproc.c (Fcall_process): Avoid vfork clobbering
9087 the local vars buffer, coding_systems, current_dir.
9088
640c8776
SM
90892011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9090
9091 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9092
f26d0e4c
PE
90932011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9094
8a10d76c
PE
9095 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9096 so that it is not optimized away.
9097
f26d0e4c
PE
9098 * xdisp.c (compute_display_string_pos): Remove unused local.
9099
55439c61
EZ
91002011-08-02 Eli Zaretskii <eliz@gnu.org>
9101
9102 Fix slow cursor motion and scrolling in large buffers with
9103 selective display, like Org Mode buffers. (Bug#9218)
9104
9105 * dispextern.h (struct bidi_it): New member disp_prop_p.
9106
9107 * xdisp.c: Remove one-slot cache of display string positions.
9108 (compute_display_string_pos): Accept an additional argument
5e617bc2 9109 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9110 for a display string or property. If found, set DISP_PROP_P
9111 non-zero.
9112
9113 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9114 DISP_PROP_P, and pass it to compute_display_string_pos.
9115 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9116 non-zero. All callers of bidi_fetch_char changed.
9117
fb33fa43
SM
91182011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9119
9120 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9121
b099e063
DM
91222010-12-03 Don March <don@ohspite.net>
9123
9124 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9125 last character M-[char] is translated to ESC [char] (bug#7541).
9126
5cc7f7af
KH
91272011-08-02 Kenichi Handa <handa@m17n.org>
9128
d0fffa3f 9129 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9130
9131 * chartab.c (uniprop_table): Make it non-static.
9132
525d5e6e
EZ
91332011-08-01 Eli Zaretskii <eliz@gnu.org>
9134
9135 * xdisp.c (forward_to_next_line_start): Accept additional argument
9136 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9137 on the newline.
9138 (reseat_at_next_visible_line_start): Use the bidi iterator state
9139 returned by forward_to_next_line_start to restore the state of
9140 it->bidi_it after backing up to previous newline. (Bug#9212)
9141
31011111
AS
91422011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9143
9144 * regex.c (re_comp): Protoize.
9145 (re_exec): Fix return type.
9146 (regexec): Fix type of `ret'. (Bug#9203)
9147
476371c4
PE
91482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9149
e5d76069
PE
9150 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9151 This is needed if max-image-size is a floating-point number.
9152
9a79b20c
AS
91532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9154
9155 * print.c (print_object): Print empty symbol as ##.
9156
9157 * lread.c (read1): Read ## as empty symbol.
9158
d8c2fa78
AA
91592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9160
9161 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9162 setting frame foreground color (Bug#9175).
9163 (x_set_background_color): Likewise.
9164
ffe57a7a
AA
9165 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9166 contents (Bug#9176).
9167 (EmacsTooltip -init): Remove bezels and add shadows to
9168 tooltip windows.
9169
bf3492a5
AA
9170 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9171 or scroll bar (Bug#8470).
9172
d55e9c53
AA
9173 * nsfont.m (nsfont_open): Remove assignment to voffset and
9174 unnecessary vars hshink, expand, hd, full_height, min_height.
9175 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9176
9177 * nsterm.h (nsfont_info): Remove voffset field.
9178
d8c2fa78 91792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9180
9181 Implement strike-through and overline on NextStep (Bug#8863).
9182
9183 * nsfont.m (nsfont_open): Use underline position provided by font,
9184 instead of hard-coded value of 2.
9185 (nsfont_draw): Call ns_draw_text_decoration instead.
9186
9187 * nsterm.h: Add declaration for ns_draw_text_decoration.
9188
9189 * nsterm.m (ns_draw_text_decoration): New function for drawing
9190 underline, overline, and strike-through.
9191 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9192 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9193 accommodate underlining, etc.
4843aac3 9194
4cc60b9b
EZ
91952011-07-28 Eli Zaretskii <eliz@gnu.org>
9196
bc7ece87
EZ
9197 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9198 default.
4cc60b9b 9199
476371c4
PE
92002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9201
66606eea
PE
9202 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9203 Without this fix, if a signal arrives just after memory fills up,
9204 'malloc' might be invoked reentrantly.
9205
476371c4
PE
9206 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9207 In other words, assume that every image size is allowed, on non-X
9208 hosts. This assumption is probably wrong, but it lets Emacs compile.
9209
f3fcc40d
AS
92102011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9211
9212 * regex.c (re_iswctype): Convert return values to boolean.
9213
350c992f
EZ
92142011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9215
9216 * xdisp.c (compute_display_string_pos): Don't use cached display
9217 string position if the buffer had its restriction changed.
9218 (Bug#9184)
9219
5266b4bb
PE
92202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9221
9222 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9223
2573a837 92242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9225
41f55ccd 9226 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9227
39e378da
PE
9228 * bidi.c: Integer size and overflow fixes.
9229 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9230 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9231 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9232 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9233 (bidi_find_other_level_edge):
9234 Use ptrdiff_t instead of EMACS_INT where either will do.
9235 This works better on 32-bit hosts configured --with-wide-int.
9236 (bidi_cache_ensure_space): Check for size-calculation overflow.
9237 Use % rather than repeated addition, for better worst-case speed.
9238 Don't set bidi_cache_size until after xrealloc returns, because it
9239 might not return.
9240 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9241 (bidi_cache_ensure_space): Also check that the bidi cache size
9242 does not exceed that of the largest Lisp string or buffer. See Eli
9243 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9244
5e927815
PE
9245 * alloc.c (__malloc_size_t): Remove.
9246 All uses replaced by size_t. See Andreas Schwab's note
9247 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9248
ca4aa935
PE
9249 * image.c: Improve checking for integer overflow.
9250 (check_image_size): Assume that f is nonnull, since
9251 it is always nonnull in practice. This is one less thing to
9252 worry about when checking for integer overflow later.
9253 (x_check_image_size): New function, which checks for integer
9254 overflow issues inside X.
9255 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9256 This removes the need for a memory_full check.
9257 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9258 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9259 (xbm_read_bitmap_data): Change locals back to 'int', since
9260 their values must fit in 'int'.
9261 (xpm_load_image, png_load, tiff_load):
9262 Invoke x_create_x_image_and_pixmap earlier,
9263 to avoid much needless work if the image is too large.
9264 (tiff_load): Treat overly large images as if
9265 x_create_x_image_and_pixmap failed, not as malloc failures.
9266 (gs_load): Use x_check_image_size.
9267
5f8f9cc2
PE
9268 * gtkutil.c: Omit integer casts.
9269 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9270 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9271
5adf60bc
PE
9272 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9273
c8907a93
PE
9274 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9275 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9276 would wrongly return t on a 64-bit host.
9277
e3c25c68
PE
9278 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9279 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9280 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9281 and therefore cause GCC to emit a bogus diagnostic in some cases.
9282
3f791afe
PE
9283 * image.c: Integer signedness and overflow and related fixes.
9284 This is not an exhaustive set of fixes, but it's time to
9285 record what I've got.
9286 (lookup_pixel_color, check_image_size): Remove redundant decls.
9287 (check_image_size): Don't assume that arbitrary EMACS_INT values
9288 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9289 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9290 (tiff_load, imagemagick_load_image):
9291 Check for overflow in size calculations.
9292 (x_create_x_image_and_pixmap): Remove unnecessary test for
9293 xmalloc returning NULL; that can't happen.
9294 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9295 (xpm_color_bucket): Use better integer hashing function.
9296 (xpm_cache_color): Don't possibly over-allocate memory.
9297 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9298 (gif_memory_source):
9299 Use ptrdiff_t, not int or size_t, to record sizes.
9300 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9301 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9302 either works, as we prefer signed integers.
9303 (tiff_read_from_memory, tiff_write_from_memory):
9304 Return tsize_t, not size_t, since that's what the TIFF API wants.
9305 (tiff_read_from_memory): Don't fail simply because the read would
9306 go past EOF; instead, return a short read.
9307 (tiff_load): Omit no-longer-needed casts.
9308 (Fimagemagick_types): Don't assume size fits into 'int'.
9309
3cc5a532
PE
9310 Improve hashing quality when configured --with-wide-int.
9311 * fns.c (hash_string): New function, taken from sxhash_string.
9312 Do not discard information about ASCII character case; this
9313 discarding is no longer needed.
9314 (sxhash-string): Use it. Change sig to match it. Caller changed.
9315 * lisp.h: Declare it.
9316 * lread.c (hash_string): Remove, since we now use fns.c's version.
9317 The fns.c version returns a wider integer if --with-wide-int is
9318 specified, so this should help the quality of the hashing a bit.
9319
b312a492
PE
9320 * emacs.c: Integer overflow minor fix.
9321 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9322 Define only if GNU_LINUX.
9323 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9324
dfd153ae
PE
9325 * dispnew.c: Integer signedness and overflow fixes.
9326 Remove unnecessary forward decls, that were a maintenance hassle.
9327 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9328 All uses changed.
9329 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9330 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9331 (prepare_desired_row, line_draw_cost):
9332 Use int, not unsigned, where either works.
9333 (save_current_matrix, restore_current_matrix):
9334 Use ptrdiff_t, not size_t, where either works.
9335 (init_display): Check for overflow more accurately, and without
9336 relying on undefined behavior.
9337
a81d11a3
PE
9338 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9339 Remove, replacing with the new symbols in lisp.h. All uses changed.
9340 * fileio.c (make_temp_name):
9341 * filelock.c (lock_file_1, lock_file):
9342 * xdisp.c (message_dolog):
9343 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9344 Use pMd etc. instead.
9345 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9346 replacing the pWIDE etc. symbols removed from editfns.c.
9347
3300e6fd
PE
9348 * keyboard.h (num_input_events): Now uintmax_t.
9349 This is (very slightly) less likely to mess up due to wraparound.
9350 All uses changed.
9351
fd05c7e9
PE
9352 * buffer.c: Integer signedness fixes.
9353 (alloc_buffer_text, enlarge_buffer_text):
9354 Use ptrdiff_t rather than size_t when either will do, as we prefer
9355 signed integers.
9356
903fe15d
PE
9357 * alloc.c: Integer signedness and overflow fixes.
9358 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9359 (__malloc_size_t): Default to size_t, not to int.
9360 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9361 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9362 Prefer ptrdiff_t to size_t when either would do, as we prefer
9363 signed integers.
9364 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9365 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9366 Now const. Initialize with values that are in range even if char
9367 is signed.
9368 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9369 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9370 These functions do the right thing with sizes > 2**32.
9371 (check_depth): Now ptrdiff_t, not int.
9372 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9373 Adjust to new way of storing sizes. Check for size overflow bugs
9374 in rest of code.
9375 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9376 slightly wrong anyway, as it missed one instance of
9377 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9378 (refill_memory_reserve): Omit needless cast to size_t.
9379 (mark_object_loop_halt): Mark as externally visible.
9380
ac82cc6a
PE
9381 * xselect.c: Integer signedness and overflow fixes.
9382 (Fx_register_dnd_atom, x_handle_dnd_message):
9383 Use ptrdiff_t, not size_t, since we prefer signed.
9384 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9385 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9386 x_dnd_atoms_size and x_dnd_atoms_length.
9387
c2d1e36d
PE
9388 * doprnt.c: Prefer signed to unsigned when either works.
9389 * eval.c (verror):
9390 * doprnt.c (doprnt):
9391 * lisp.h (doprnt):
9392 * xdisp.c (vmessage):
9393 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9394 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9395 prefer signed arithmetic to avoid comparison confusion.
9396 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9397 but is a bit tricky.
9398
0e926e56
PE
9399 Assume freestanding C89 headers, string.h, stdlib.h.
9400 * data.c, doprnt.c, floatfns.c, print.c:
9401 Include float.h unconditionally.
9402 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9403 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9404 * regex.c: Likewise for stddef.h, string.h.
9405 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9406 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9407 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9408 (STDC_HEADERS): Remove obsolete defines.
9409 * sysdep.c: Include limits.h unconditionally.
9410
9cfdb3ec
PE
9411 Assume support for memcmp, memcpy, memmove, memset.
9412 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9413 * regex.c (memcmp, memcpy):
9414 Remove; we assume C89 now.
9415
9416 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9417 (__malloc_safe_bcopy): Remove; no longer needed.
9418
cf950e6b 9419 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9420 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9421 well either way, and we prefer signed to unsigned.
9422
dbf38e02
LMI
94232011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9424
9425 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9426 closes the connection while we're reading (bug#9182).
9427
d6f0886c 94282011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9429
d6f0886c
JD
9430 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9431 are specified (Bug#9168).
24e0f6b1 9432
2eb1f9e6
PE
94332011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9434
9435 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9436 Found by GCC static checking and --with-wide-int on a 32-bit host.
9437
22381272 94382011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9439
9440 * xdisp.c (compute_display_string_pos): Fix logic of caching
9441 previous display string position. Initialize cached_prev_pos to
9442 -1. Fixes slow-down at the beginning of a buffer.
9443
f25e39b4
EZ
94442011-07-24 Eli Zaretskii <eliz@gnu.org>
9445
9446 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9447 for attrs[LFACE_FONTSET_INDEX].
9448
04c4b52e
PE
94492011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9450
9451 * xml.c (parse_region): Remove unused local
9452 that was recently introduced.
9453
c1734fbd
EZ
94542011-07-23 Eli Zaretskii <eliz@gnu.org>
9455
be18c5a5
EZ
9456 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9457 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9458
c1734fbd
EZ
9459 * xdisp.c (move_it_in_display_line_to): Record the best matching
9460 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9461 exit if none of the characters scanned was an exact match.
9462 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9463 when exact match is impossible due to invisible text, and the
9464 lines are truncated.
9465
a258d627
JD
94662011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9467
9468 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9469 for OSX >= 10.7.
9470
b6d5a689
EZ
94712011-07-22 Eli Zaretskii <eliz@gnu.org>
9472
0f74f785
EZ
9473 Fix a significant slow-down of cursor motion with C-n, C-p,
9474 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9475 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9476 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9477 (next_element_from_buffer): Call compute_stop_pos_backwards to
9478 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9479 base_level_stop.
9480 (reseat): Don't look for prev_stop, as that could mean a very long
9481 run.
9482 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9483 <cached_disp_overlay_modiff>: Cache for last found display string
9484 position.
551918c1 9485 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9486 about the same buffer in the same area of character positions, and
9487 the buffer wasn't changed since the time the display string
9488 position was cached.
551918c1 9489
b2d0c91a
EZ
94902011-07-22 Eli Zaretskii <eliz@gnu.org>
9491
9492 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9493 is an integer, which is important for empty lines. (Bug#9149)
9494
043604ee
CY
94952011-07-22 Chong Yidong <cyd@stupidchicken.com>
9496
9497 * frame.c (Fmodify_frame_parameters): In tty case, update the
9498 default face if necessary (Bug#4238).
9499
da4adb04
CY
95002011-07-21 Chong Yidong <cyd@stupidchicken.com>
9501
9502 * editfns.c (Fstring_to_char): No need to explain what a character
9503 is in the docstring (Bug#6576).
9504
9abd0532
LMI
95052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9506
9507 * xml.c (parse_region): Make sure we always return a tree.
9508
36881d16
HK
95092011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9510
9511 * xml.c (parse_region): If a document contains only comments,
9512 return that, too.
9513
1e98674d
LMI
95142011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9515
9516 * xml.c (make_dom): Return comments, too.
9517
590bd467
PE
95182011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9519
9520 Port to OpenBSD.
9521 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9522 and the surrounding thread.
9523 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9524 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9525 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9526 timer goes off.
9527 * s/openbsd.h (BROKEN_SIGIO): Define.
9528 * unexelf.c (unexec) [__OpenBSD__]:
9529 Don't update the .mdebug section of the Alpha COFF symbol table.
9530
f41628b2
LMI
95312011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9532
9533 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9534 (bug#8460).
9535
b59b67c5
PE
95362011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9537
15e3a074
PE
9538 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9539 This fixes some race conditions on the permissions of any newly
9540 created file.
9541
41bed37d
PE
9542 * alloc.c (valid_pointer_p): Use pipe, not open.
9543 This fixes some permissions issues when debugging.
9544
b59b67c5
PE
9545 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9546 If fchown fails to set both uid and gid, try to set just gid,
9547 as that is sometimes allowed. Adjust the file's mode to eliminate
9548 setuid or setgid bits that are inappropriate if fchown fails.
9549
925a6be7
SM
95502011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9551
9552 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9553 to compare Lisp_Objects.
9554 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9555 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9556 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9557
52968808
AS
95582011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9559
0a6a104b
AS
9560 * lread.c (read_integer): Unread even EOF character.
9561 (read1): Likewise. Properly record start position of symbol.
9562
52968808
AS
9563 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9564 symbol character follows.
9565
9e381cdd
PE
95662011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9567
9568 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9569 This works around a problem with the previous change to Fcopy_file.
9570 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9571 and without this change, GCC might complain about discarding
9572 fchown's return value.
9573
b5641435
JB
95742011-07-16 Juanma Barranquero <lekktu@gmail.com>
9575
9576 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9577
a8031457
PE
95782011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9579
9580 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9581
dd889327
LMI
95822011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9583
750c33f7
LMI
9584 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9585 it's used from the C level.
9586
dd889327
LMI
9587 * process.c: Use the same condition for POLL_FOR_INPUT in both
9588 keyboard.c and process.c (bug#1858).
9589
87e86684
LM
95902011-07-09 Lawrence Mitchell <wence@gmx.li>
9591
9592 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9593 (Fgnutls_boot): Use it.
9594
64348f40
AS
95952011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9596
9597 * doc.c (Fsubstitute_command_keys): Revert last change.
9598
1d698799
LMI
95992011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9600
f863868c
LMI
9601 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9602 quotes the next character, and doesn't affect other longer
9603 sequences (bug#8935).
9604
1d698799
LMI
9605 * lread.c (syms_of_lread): Clarify that is isn't only
9606 `eval-buffer' and `eval-defun' that's affected by
9607 `lexical-binding' (bug#8460).
9608
aa4b6df6
EZ
96092011-07-15 Eli Zaretskii <eliz@gnu.org>
9610
9611 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9612 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9613
5d856da6
PE
96142011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9615
ad6042bb
PE
9616 Fix minor problems found by static checking.
9617 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9618 (elsz): Now a signed constant, not a size_t var. We prefer signed
9619 types to unsigned, to avoid integer comparison confusion. Without
9620 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9621 "cannot optimize loop, the loop counter may overflow", a symptom
9622 of the confusion.
f00bbb22 9623 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9624 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9625
6468f31c
LMI
96262011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9627
49080b10
LMI
9628 * search.c (Fre_search_backward): Mention `case-fold-search' in
9629 all the re_search_* functions (bug#8138).
9630
6468f31c
LMI
9631 * keyboard.c (Fopen_dribble_file): Document when the file is
9632 closed (bug#8056).
9633
c965adc5
EZ
96342011-07-14 Eli Zaretskii <eliz@gnu.org>
9635
df9733bf
EZ
9636 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9637 bidi_cache_idx.
9638
0bb23927
EZ
9639 Support bidi reordering of display and overlay strings.
9640 * xdisp.c (compute_display_string_pos)
9641 (compute_display_string_end): Accept additional argument STRING.
9642 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9643 (reseat_to_string): Initialize bidi_it->string.s and
9644 bidi_it->string.schars.
9645 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9646 NULL (avoids a crash in bidi_paragraph_init).
9647 Initialize itb.string.lstring.
0bb23927
EZ
9648 (init_iterator): Call bidi_init_it only of a valid
9649 buffer position was specified. Initialize paragraph_embedding to
9650 L2R.
9651 (reseat_to_string): Initialize the bidi iterator.
9652 (display_string): If we need to ignore text properties of
9653 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9654 original value of -1 will not work with bidi.)
9655 (compute_display_string_pos): First arg is now struct
9656 `text_pos *'; all callers changed. Support display properties on
9657 Lisp strings.
9658 (compute_display_string_end): Support display properties on Lisp
9659 strings.
9660 (init_iterator, reseat_1, reseat_to_string): Initialize the
9661 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9662 when iterating on a string not from display properties).
640c8776
SM
9663 (compute_display_string_pos, compute_display_string_end):
9664 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9665 arrow keys.
9666 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9667 base_level_stop; instead, set base_level_stop to BEGV.
9668 Fixes crashes in vertical-motion.
0bb23927
EZ
9669 (next_element_from_buffer): Improve commentary for when
9670 the iterator is before prev_stop.
9671 (init_iterator): Initialize bidi_p from the default value of
9672 bidi-display-reordering, not from buffer-local value. Use the
9673 buffer-local value only if initializing for buffer iteration.
9674 (handle_invisible_prop): Support invisible properties on strings
9675 that are being bidi-reordered.
9676 (set_iterator_to_next): Support bidi reordering of C strings and
9677 Lisp strings.
9678 (next_element_from_string): Support bidi reordering of Lisp
9679 strings.
9680 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9681 (display_string): Support display of R2L glyph rows.
9682 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9683 (init_iterator): Don't initialize it->bidi_p for strings
9684 here.
9685 (reseat_to_string): Initialize it->bidi_p for strings here.
9686 (next_element_from_string, next_element_from_c_string)
9687 (next_element_from_buffer): Add xassert's for correspondence
9688 between IT's object being iterated and it->bidi_it.string
9689 structure.
9690 (face_before_or_after_it_pos): Support bidi iteration.
9691 (next_element_from_c_string): Handle the case of the first string
9692 character that is not the first one in the visual order.
9693 (get_visually_first_element): New function, refactored from common
9694 parts of next_element_from_buffer, next_element_from_string, and
9695 next_element_from_c_string.
9696 (tool_bar_lines_needed, redisplay_tool_bar)
9697 (display_menu_bar): Force left-to-right direction. Add a FIXME
9698 comment for making that be controlled by a user option.
9699 (push_it, pop_it): Save and restore the state of the
9700 bidi iterator. Save and restore the bidi_p flag.
9701 (pop_it): Iterate out of display property for string iteration as
9702 well.
9703 (iterate_out_of_display_property): Support iteration over strings.
9704 (handle_single_display_spec): Set up it->bidi_it for iteration
9705 over a display string, and call bidi_init_it.
9706 (handle_single_display_spec, next_overlay_string)
9707 (get_overlay_strings_1, push_display_prop): Set up the bidi
9708 iterator for displaying display or overlay strings.
9709 (forward_to_next_line_start): Don't use the shortcut if
9710 bidi-iterating.
9711 (back_to_previous_visible_line_start): If handle_display_prop
9712 pushed the iterator stack, restore the internal state of the bidi
9713 iterator by calling bidi_pop_it same number of times.
9714 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9715 and we are bidi-iterating, don't decrement the iterator position;
9716 instead, set the first_elt flag in the bidi iterator, to produce
9717 the same effect.
9718 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9719 (push_display_prop): xassert that we are iterating a buffer.
9720 (push_it, pop_it): Save and restore paragraph_embedding member.
9721 (handle_single_display_spec, next_overlay_string)
9722 (get_overlay_strings_1, reseat_1, reseat_to_string)
9723 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9724 correctly. Don't assume unibyte strings are not bidi-reordered.
9725 (compute_display_string_pos)
9726 (compute_display_string_end): Fix handling the case of C string.
9727 (push_it, pop_it): Save and restore from_disp_prop_p.
9728 (handle_single_display_spec, push_display_prop): Set the
9729 from_disp_prop_p flag.
9730 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9731 (pop_it): Call iterate_out_of_display_property only if we are
9732 popping after iteration over a string that came from a display
9733 property. Fix a typo in popping stretch info. Add an assertion
9734 for verifying that the iterator position is in sync with the bidi
9735 iterator.
9736 (handle_single_display_spec, get_overlay_strings_1)
9737 (push_display_prop): Fix initialization of paragraph direction for
9738 string when that of the parent object is not yet determined.
9739 (reseat_1): Call bidi_init_it to resync the bidi
9740 iterator with IT's position. (Bug#7616)
9741 (find_row_edges): If ROW->start.pos gives position
9742 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9743 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9744 Reset the from_disp_prop_p flag.
9745 (SAVE_IT, RESTORE_IT): New macros.
9746 (pos_visible_p, face_before_or_after_it_pos)
9747 (back_to_previous_visible_line_start)
9748 (move_it_in_display_line_to, move_it_in_display_line)
9749 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9750 (try_scrolling, redisplay_window, display_line): Use them when
9751 saving a temporary copy of the iterator and restoring it back.
9752 (back_to_previous_visible_line_start, reseat_1)
9753 (init_iterator): Empty the bidi cache "stack".
9754 (move_it_in_display_line_to): If iterator ended up at
9755 EOL, but we never saw any buffer positions smaller than
9756 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9757 motion in bidi-reordered lines.
9758 (move_it_in_display_line_to): Record prev_method and prev_pos
9759 immediately before the call to set_iterator_to_next. Fixes cursor
9760 motion in bidi-reordered lines with stretch glyphs and strings
9761 displayed in margins. (Bug#8133) (Bug#8867)
9762 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9763 TO_CHARPOS.
640c8776
SM
9764 (pos_visible_p): Support positions in bidi-reordered lines.
9765 Save and restore bidi cache.
0bb23927
EZ
9766
9767 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9768 (bidi_paragraph_info): Delete unused struct.
9769 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9770 (bidi_cache_start): New variable.
9771 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9772 to zero.
9773 (bidi_cache_fetch_state, bidi_cache_search)
9774 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9775 (bidi_cache_find, bidi_peek_at_next_level)
9776 (bidi_level_of_next_char, bidi_find_other_level_edge)
9777 (bidi_move_to_visually_next): Compare cache index with
9778 bidi_cache_start rather than with zero.
9779 (bidi_fetch_char): Accept new argument STRING; all callers
9780 changed. Support iteration over a string. Support strings with
9781 display properties. Support unibyte strings. Fix the type of
9782 `len' according to what STRING_CHAR_AND_LENGTH expects.
9783 (bidi_paragraph_init, bidi_resolve_explicit_1)
9784 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9785 (bidi_level_of_next_char, bidi_move_to_visually_next):
9786 Support iteration over a string.
0bb23927
EZ
9787 (bidi_set_sor_type, bidi_resolve_explicit_1)
9788 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9789 can now be zero (for strings); special values 0 and -1 were
9790 changed to -1 and -2, respectively.
9791 (bidi_char_at_pos): New function.
9792 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9793 Call it instead of FETCH_MULTIBYTE_CHAR.
9794 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9795 initialized to valid values.
9796 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9797 values.
9798 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9799 the test for valid cached positions. Fix the logic for looking up
9800 the sentinel state in the cache. GCPRO the Lisp string we are
9801 iterating.
9802 (bidi_push_it, bidi_pop_it): New functions.
9803 (bidi_initialize): Initialize the bidi cache start stack pointer.
9804 (bidi_cache_ensure_space): New function, refactored from part of
9805 bidi_cache_iterator_state. Don't assume the required size is just
9806 one BIDI_CACHE_CHUNK away.
9807 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9808 (bidi_count_bytes, bidi_char_at_pos): New functions.
9809 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9810 always valid if bidi_cache_idx is valid.
9811 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9812 is valid if it's going to be used.
9813 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9814 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9815 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9816 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9817 (bidi_find_other_level_edge, bidi_cache_start_stack):
9818 All variables related to cache indices are now EMACS_INT.
c965adc5 9819
0bb23927
EZ
9820 * dispextern.h (struct bidi_string_data): New structure.
9821 (struct bidi_it): New member `string'. Make flag members be 1-bit
9822 fields, and put them last in the struct.
640c8776
SM
9823 (compute_display_string_pos, compute_display_string_end):
9824 Update prototypes.
0bb23927
EZ
9825 (bidi_push_it, bidi_pop_it): Add prototypes.
9826 (struct iterator_stack_entry): New members bidi_p,
9827 paragraph_embedding, and from_disp_prop_p.
9828 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9829 (bidi_shelve_cache, bidi_unshelve_cache):
9830 Declare prototypes.
0bb23927
EZ
9831
9832 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9833 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9834 and vector-like objects.
9835
9836 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9837 cache around display iteration.
9838
9839 * window.c (Fwindow_end, window_scroll_pixel_based)
9840 (displayed_window_lines, Frecenter): Save and restore the bidi
9841 cache around display iteration.
9842
3bbd2265
LMI
98432011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9844
9845 * editfns.c (Fdelete_region): Clarify the use of the named
9846 parameters (bug#6788).
9847
adc47434
MR
98482011-07-14 Martin Rudalics <rudalics@gmx.at>
9849
9850 * indent.c (Fvertical_motion): Set and restore w->pointm when
9851 saving and restoring the window's buffer (Bug#9006).
9852
837c31f8
LMI
98532011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9854
9855 * editfns.c (Fstring_to_char): Clarify just what is returned
9856 (bug#6576). Text by Eli Zaretskii.
9857
ac389d0c
JB
98582011-07-13 Juanma Barranquero <lekktu@gmail.com>
9859
9860 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9861
0be0ce47
EZ
98622011-07-13 Eli Zaretskii <eliz@gnu.org>
9863
9864 * buffer.c (mmap_find): Fix a typo.
9865
cd18e7e3
JB
98662011-07-13 Johan Bockgård <bojohan@gnu.org>
9867
9868 Fix execution of x selection hooks.
9869 * xselect.c (Qx_lost_selection_functions)
9870 (Qx_sent_selection_functions): New vars.
9871 (syms_of_xselect): DEFSYM them.
9872 (x_handle_selection_request): Pass Qx_sent_selection_functions
9873 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9874 (x_handle_selection_clear,x_clear_frame_selections):
9875 Pass Qx_lost_selection_functions rather than
9876 Vx_lost_selection_functions to Frun_hook_with_args.
9877
47ea7f44
PE
98782011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9879
ac389d0c 9880 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9881 The old code sometimes used this field without initializing it.
9882
47ea7f44
PE
9883 * alloc.c (gc_sweep): Don't read past end of array.
9884 In theory, the old code could also have corrupted Emacs internals,
9885 though it'd be very unlikely.
9886
bc985c87
AS
98872011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9888
9889 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9890 argument. (Bug#4026)
bc985c87 9891
0cf34688
LMI
98922011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9893
b3dadd76
LMI
9894 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9895 key" (bug#4257).
9896
0cf34688
LMI
9897 * window.c (Fset_window_start): Doc fix (bug#4199).
9898 (Fset_window_hscroll): Ditto.
9899
270768cd
PE
99002011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9901
077e3dda 9902 Fix minor new problems caught by GCC 4.6.1.
270768cd 9903 * term.c (init_tty): Remove unused local.
490011a6 9904 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9905 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9906 not used otherwise.
270768cd 9907
b1f58454
CY
99082011-07-12 Chong Yidong <cyd@stupidchicken.com>
9909
9910 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9911
22b9578d
LMI
99122011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9913
6e70ab07
LMI
9914 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9915 are the mini-buffer and the echo area (bug#3320).
9916
22b9578d
LMI
9917 * term.c (init_tty): Remove support for supdup, c10 and perq
9918 terminals, which are no longer supported (bug#1482).
9919
8974cc9f
JB
99202011-07-10 Johan Bockgård <bojohan@gnu.org>
9921
9922 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9923
a560d974
JD
99242011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9925
9926 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9927 for non-popups (Bug#3642).
9928
1dae0f0a
AS
99292011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9930
268c2c36 9931 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9932 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9933 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9934 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9935 * data.c (fmod): Likewise.
9936 * dispnew.c (swap_glyphs_in_rows): Likewise.
9937 * emacs.c (memory_warning_signal): Likewise.
9938 * floatfns.c (float_error): Likewise.
9939 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9940 (otf_open, font_otf_capability, generate_otf_features)
9941 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9942 Likewise.
9943 * image.c (pbm_read_file): Likewise.
9944 * indent.c (string_display_width): Likewise.
9945 * intervals.c (check_for_interval, search_for_interval)
9946 (inc_interval_count, count_intervals, root_interval)
9947 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9948 * lread.c (defalias): Likewise.
268c2c36 9949 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9950 * regex.c (set_image_of_range_1, set_image_of_range)
9951 (regex_grow_registers): Likewise.
9952 * sysdep.c (strerror): Likewise.
9953 * termcap.c (valid_filename_p, tprint, main): Likewise.
9954 * tparam.c (main): Likewise.
9955 * unexhp9k800.c (run_time_remap, save_data_space)
9956 (update_file_ptrs, read_header, write_header, calculate_checksum)
9957 (copy_file, copy_rest, display_header): Likewise.
9958 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9959 Likewise.
9960 * xdisp.c (check_it): Likewise.
9961 * xfaces.c (register_color, unregister_color, unregister_colors):
9962 Likewise.
9963 * xfns.c (print_fontset_result): Likewise.
9964 * xrdb.c (member, fatal, main): Likewise.
9965
99033785
PE
99662011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9967
9968 Fix minor problems found by static checking (Bug#9031).
9969 * chartab.c (char_table_set_range, map_sub_char_table):
9970 Remove unused locals.
9971 (uniprop_table): Now static.
9972 * composite.c (_work_char): Remove unused static var.
9973
9cb2ac56
JB
99742011-07-09 Juanma Barranquero <lekktu@gmail.com>
9975
9976 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9977
f25661f0
JD
99782011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9979
9980 * gtkutil.c (qttip_cb): Remove code without function.
9981
8278c4fe
EZ
99822011-07-09 Eli Zaretskii <eliz@gnu.org>
9983
9984 * w32.c (pthread_sigmask): New stub.
9985
1692ae2d 99862011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9987
8a6ebd58 9988 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9989 sigprocmask is portable only for single-threaded applications, and
9990 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9991 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9992 (LIBES): Use it.
9993 * callproc.c (Fcall_process):
9994 * process.c (create_process):
9995 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9996 Use pthread_sigmask, not sigprocmask.
123403e4 9997
1b854618
JD
99982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9999
10000 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10001 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10002 wrong (Bug#8591).
10003
3fe4b549
JD
100042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10005
0ce7e563
JD
10006 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10007 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10008 (xg_hide_tooltip): Fix comment.
10009
3fe4b549
JD
10010 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10011 in registerServicesMenuSendTypes.
10012 (validRequestorForSendType): Don't check ns_return_types.
10013
10014 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10015 ns_return_type.
10016
5df75e47
JR
100172011-07-08 Jason Rumney <jasonr@gnu.org>
10018
22610910
JR
10019 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10020 SH_SHOW for hidden windows (Bug#5482).
10021
5df75e47
JR
10022 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10023 frame struct members of non-existent frames (Bug#6284).
10024
699c10bd
JD
100252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10026
4393663b
JD
10027 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10028 variable firstTime not needed on OSX >= 10.6.
10029 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10030 >= 10.5. Use setKnobProportion, setDoubleValue.
10031
10032 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10033 (MAC_OS_X_VERSION_10_5): Define if not defined.
10034 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10035 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10036 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10037
10038 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10039 cString and lossyCString on OSX >= 10.4.
4393663b 10040
58179cce 10041 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10042 sizeToFit on OSX >= 10.2.
10043
10044 * nsimage.m (allocInitFromFile): Don't use deprecated method
10045 bestRepresentationForDevice on OSX >= 10.6.
10046
10047 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10048 to avoid warning.
10049
10050 * emacs.c: Declare unexec_init_emacs_zone.
10051
a63e0781
JD
10052 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10053
699c10bd
JD
10054 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10055
10056 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10057 on svcsMenu (Bug#8842).
10058
10059 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10060 ns_return_types.
10061 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10062
10063 * nsterm.m (QUTF8_STRING): Declare.
10064 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10065 (validRequestorForSendType): Return type is (id).
10066 Change indexOfObjectIdenticalTo to indexOfObject.
10067 Check if we have local selection before returning self (Bug#8842).
10068 (writeSelectionToPasteboard): Put local selection into paste board
10069 if we have a local selection (Bug#8842).
10070 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10071
10072 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10073 (ns_get_local_selection): Declare.
10074
54e10184
LMI
100752011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10076
9888ff71
LMI
10077 * keymap.c (describe_map_tree): Don't insert a double newline at
10078 the end of the buffer (bug#1169) and return whether we inserted
10079 something.
10080
54e10184
LMI
10081 * callint.c (Fcall_interactively): Change "reading args" to
10082 "providing args" to try to clarify what it does (bug#1010).
10083
15fa4783
KH
100842011-07-07 Kenichi Handa <handa@m17n.org>
10085
10086 * composite.c (composition_compute_stop_pos): Ignore a static
10087 composition starting before CHARPOS (Bug#8915).
10088
10089 * xdisp.c (handle_composition_prop): Likewise.
10090
a8815b00
EZ
100912011-07-07 Eli Zaretskii <eliz@gnu.org>
10092
10093 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10094 (Bug#9015)
10095
ef7b981d 100962011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10097
10098 * character.h (unicode_category_t): New enum type.
10099
10100 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10101 (Qchar_code_property_table): New variable.
10102 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10103 (UNIPROP_COMPRESSED_FORM_P): New macros.
10104 (char_table_ascii): Uncompress the compressed values.
10105 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10106 Uncompress the compressed values.
ac389d0c 10107 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10108 (char_table_ref_and_range): Uncompress the compressed values.
10109 (sub_char_table_set): New arg is_uniprop. Callers changed.
10110 Uncompress the compressed values.
10111 (sub_char_table_set_range): Args changed. Callers changed.
10112 (char_table_set_range): Adjuted for the above change.
10113 (map_sub_char_table): Delete args default_val and parent. Add arg
10114 top. Give decoded values to a Lisp function.
640c8776 10115 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10116 values to a Lisp function. Gcpro more variables.
10117 (uniprop_table_uncompress)
10118 (uniprop_decode_value_run_length): New functions.
10119 (uniprop_decoder, uniprop_decoder_count): New variables.
10120 (uniprop_get_decoder, uniprop_encode_value_character)
10121 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10122 New functions.
10123 (uniprop_encoder, uniprop_encoder_count): New variables.
10124 (uniprop_get_encoder, uniprop_table)
10125 (Funicode_property_table_internal, Fget_unicode_property_internal)
10126 (Fput_unicode_property_internal): New functions.
10127 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10128 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10129 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10130 char-code-property-alist.
10131
640c8776 10132 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10133 Vunicode_category_table.
10134
640c8776 10135 * font.c (font_range): Adjust for the change of
c805dec0
KH
10136 Vunicode_category_table.
10137
76b397fb
DN
101382011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10139
10140 * m/iris4d.h: Remove file, move contents ...
10141 * s/irix6-5.h: ... here.
10142
22b4128e
PE
101432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10144
10145 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10146 * alloc.c (mark_buffer):
10147 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10148 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10149 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10150 This isn't true in general, and it's particularly not true
10151 if Emacs is configured with --with-wide-int.
10152 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10153 New macros, used in the buffer.c change.
10154
869795d6
JD
101552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10156
10157 * xsettings.c: Use both GConf and GSettings if both are available.
10158 (store_config_changed_event): Add comment.
10159 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10160 (store_tool_bar_style_changed): New functions.
5e617bc2 10161 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10162 (struct xsettings): Move font inside HAVE_XFT.
10163 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10164 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10165 Move inside HAVE_XFT.
640c8776 10166 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10167 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10168 also.
10169 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10170 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10171 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10172 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10173 (parse_settings): Move check for font inside HAVE_XFT.
10174 (read_settings, apply_xft_settings): Add comment.
10175 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10176 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10177 call store_font_name_changed.
10178 (xft_settings_event): Add comment.
10179 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10180 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10181 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10182 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10183 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10184 (xsettings_get_system_font, xsettings_get_system_normal_font):
10185 Add comment.
869795d6 10186
d8ed26bd
PE
101872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10188
10189 Random fixes. E.g., (random) never returned negative values.
10190 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10191 subseconds part to the entropy, as that's a bit more random.
10192 Prefer signed to unsigned, since the signedness doesn't matter and
10193 in general we prefer signed. When given a limit, use a
10194 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10195 latter isn't right if USE_2_TAGS_FOR_INTS.
10196 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10197 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10198
cabf1cac
SM
101992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10200
10201 * textprop.c (text_property_stickiness):
10202 Obey Vtext_property_default_nonsticky.
10203 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10204 * w32fns.c (syms_of_w32fns):
10205 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10206
6e9b2be9
PE
102072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10208
10209 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10210 This is more efficient than Ffile_directory_p and avoids a minor race.
10211
90186c68
LMI
102122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10213
7c301272
LMI
10214 * buffer.c (Foverlay_put): Say what the return value is
10215 (bug#7835).
10216
c4f2d8d4
LMI
10217 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10218 is a directory before asking whether to use the file name
10219 (bug#7564).
ad637907
LMI
10220 (barf_or_query_if_file_exists): Make the "File is a directory"
10221 error be more correct.
c4f2d8d4 10222
90186c68
LMI
10223 * fns.c (Frequire): Remove the mention of the .gz files, since
10224 that's installation-specific, but keep the mention of
10225 `get-load-suffixes'.
10226
da64016e
PE
102272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10228
10229 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10230 Report string overflow if the output is too long.
10231
7d47b580
JB
102322011-07-04 Juanma Barranquero <lekktu@gmail.com>
10233
a555cb87
JB
10234 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10235 (syms_of_gnutls): Remove duplicate DEFSYM for
10236 Qgnutls_bootprop_verify_hostname_error, an error for
10237 Qgnutls_bootprop_verify_error (which is no longer used).
10238
7d47b580
JB
10239 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10240 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10241 Also (re)move comments that are misplaced or no longer relevant.
10242
1e49bfab
LMI
102432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10244
10245 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10246
1485f4c0
CY
102472011-07-03 Chong Yidong <cyd@stupidchicken.com>
10248
10249 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10250 and background color parameters if they have been changed.
10251
a9ab721e
LMI
102522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10253
10254 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10255
cf7cff57
PE
102562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10257
2e13213d
PE
10258 * xsettings.c (SYSTEM_FONT): Define only when used.
10259 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10260
cf7cff57
PE
10261 * keymap.c (access_keymap_1): Now static.
10262
7a8e04f7
CY
102632011-07-02 Chong Yidong <cyd@stupidchicken.com>
10264
10265 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10266 leave any prefix arg for the up event (Bug#1586).
10267
61352f62
LMI
102682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10269
69bb1ef7
LMI
10270 * lread.c (syms_of_lread): Mention single symbols defined by
10271 `defvar' or `defconst' (bug#7154).
10272
61352f62 10273 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10274 (Frequire): Mention get-load-suffixes.
61352f62 10275
28545e04
MR
102762011-07-02 Martin Rudalics <rudalics@gmx.at>
10277
10278 * window.h (window): Remove clone_number slot.
10279 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10280 Remove.
10281 (make_parent_window, make_window, saved_window)
10282 (Fset_window_configuration, save_window_save): Don't deal with
10283 clone numbers.
10284 * buffer.c (Qclone_number): Remove declaration.
10285 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10286
3349e122
SM
102872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10288
10289 Add multiple inheritance to keymaps.
10290 * keymap.c (Fmake_composed_keymap): New function.
10291 (Fset_keymap_parent): Simplify.
10292 (fix_submap_inheritance): Remove.
10293 (access_keymap_1): New function extracted from access_keymap to handle
10294 embedded parents and handle lists of maps.
10295 (access_keymap): Use it.
10296 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10297 (Fcopy_keymap): Handle embedded parents.
10298 (Fcommand_remapping, define_as_prefix): Simplify.
10299 (Fkey_binding): Simplify.
10300 (syms_of_keymap): Move minibuffer-local-completion-map,
10301 minibuffer-local-filename-completion-map,
10302 minibuffer-local-must-match-map, and
10303 minibuffer-local-filename-must-match-map to Elisp.
10304 (syms_of_keymap): Defsubr make-composed-keymap.
10305 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10306 (parse_menu_item): Trivial simplification.
10307
3279eb87
GM
103082011-07-01 Glenn Morris <rgm@gnu.org>
10309
10310 * Makefile.in (SETTINGS_LIBS): Fix typo.
10311
39cb9e56 103122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10313
10314 * coding.c (Fencode_coding_string): Record the last coding system
10315 used, as the function doc string says (bug#8738).
10316
0949d2b6
JD
103172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10318
10319 * xsettings.c (store_monospaced_changed): Take new font as arg and
10320 check for change against current_mono_font.
10321 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10322 (emacs_settings_constructor, emacs_settings_get_property)
10323 (emacs_settings_set_property, emacs_settings_class_init)
10324 (emacs_settings_init, gsettings_obj): Remove.
10325 (something_changedCB): New function for HAVE_GSETTINGS.
10326 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10327 with value as argument.
10328 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10329 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10330 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10331 "changed".
10332
10333 * xgselect.c: Add defined (HAVE_GSETTINGS).
10334 (xgselect_initialize): Ditto.
10335
10336 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10337 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10338 xg_select.
10339
bbc6b304
PE
103402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10341
10342 * eval.c (struct backtrace): Simplify and port the data structure.
10343 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10344 signed bit field, as this assumption is not portable and it makes
10345 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10346 "char debug_on_exit : 1" as this is not portable either; instead,
10347 use the portable "unsigned int debug_on_exit : 1". Remove unused
10348 member evalargs. Remove obsolete comments about cc bombing out.
10349
9851bfc5
JD
103502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10351
51bb811f 10352 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10353 Let HAVE_GSETTINGS override HAVE_GCONF.
10354 (store_monospaced_changed): New function.
10355 (EMACS_SETTINGS): A new type derived from GObject to handle
10356 GSettings notifications.
10357 (emacs_settings_constructor, emacs_settings_get_property)
10358 (emacs_settings_set_property, emacs_settings_class_init):
10359 New functions.
10360 (gsettings_client, gsettings_obj): New variables.
10361 (GSETTINGS_SCHEMA): New define.
10362 (something_changedCB): Call store_monospaced_changed.
10363 (init_gsettings): New function.
10364 (xsettings_initialize): Call init_gsettings.
10365 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10366 to NULL.
10367
640c8776 10368 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10369 GCONF_CFLAGS/LIBS.
10370
5386012d
MR
103712011-06-29 Martin Rudalics <rudalics@gmx.at>
10372
10373 * window.c (resize_root_window, grow_mini_window)
10374 (shrink_mini_window): Rename Qresize_root_window to
10375 Qwindow_resize_root_window and Qresize_root_window_vertically to
10376 Qwindow_resize_root_window_vertically.
10377
f13e0b08
PE
103782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10379
10380 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10381
94515237
JB
103822011-06-27 Juanma Barranquero <lekktu@gmail.com>
10383
10384 * makefile.w32-in: Redesign dependencies so they reflect more
10385 clearly which files are directly included by each source file,
10386 and not through other includes.
10387
e43b6e43
MR
103882011-06-27 Martin Rudalics <rudalics@gmx.at>
10389
10390 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10391 (sort_overlays, overlay_strings): When an overlay's clone number
10392 matches the window's clone number process the overlay even if
10393 the overlay's window property doesn't match the current window.
10394
d68443dc
MR
10395 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10396 (Fwindow_hchild): Rename to Fwindow_left_child.
10397 (Fwindow_next): Rename to Fwindow_next_sibling.
10398 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10399 (resize_window_check): Rename to window_resize_check.
10400 (resize_window_apply): Rename to window_resize_apply.
10401 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10402 (Fdelete_other_windows_internal, resize_frame_windows)
10403 (Fsplit_window_internal, Fdelete_window_internal)
10404 (grow_mini_window, shrink_mini_window)
10405 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10406
c7e73be5
JD
104072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10408
10409 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10410 (emacs_fixed_set_min_size): Remove.
10411 (emacs_fixed_new): Take frame as argument.
10412
10413 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10414 (_EmacsFixedPrivate): Remove minwidth/height.
10415 Add struct frame *f.
10416 (emacs_fixed_init): Initialize priv->f.
10417 (get_parent_class, emacs_fixed_set_min_size): Remove.
10418 (emacs_fixed_new): Set priv->f to argument.
10419 (emacs_fixed_get_preferred_width)
10420 (emacs_fixed_get_preferred_height): Use min_width/height from
10421 frames size_hint to set minimum and natural (Bug#8919).
10422 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10423 and use min_width/height from frames size_hint to set
10424 min_width/height (Bug#8919).
10425
10426 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10427 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10428 Fix indentation.
c7e73be5 10429
cf99dcf8
EZ
104302011-06-26 Eli Zaretskii <eliz@gnu.org>
10431
10432 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10433 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10434 called at ZV.
10435
029529ac
CY
104362011-06-26 Chong Yidong <cyd@stupidchicken.com>
10437
10438 * process.c (wait_reading_process_output): Bypass select if
10439 waiting for a cell while ignoring keyboard input, and input is
10440 pending. Suggested by Jan Djärv (Bug#8869).
10441
7a7ef429
PE
104422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10443
10444 Use gnulib's dup2 module instead of rolling our own.
10445 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10446
11fdef7d 104472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10448
10449 * dispnew.c (scrolling_window): Before scrolling, turn off a
10450 mouse-highlight in the window being scrolled.
10451
cd3520a4
JB
104522011-06-24 Juanma Barranquero <lekktu@gmail.com>
10453
10454 Move DEFSYM to lisp.h and use everywhere.
10455
10456 * character.h (DEFSYM): Move declaration...
10457 * lisp.h (DEFSYM): ...here.
10458
10459 * gnutls.c:
10460 * minibuf.c:
10461 * w32menu.c:
10462 * w32proc.c:
10463 * w32select.c: Don't include character.h.
10464
10465 * alloc.c (syms_of_alloc):
10466 * buffer.c (syms_of_buffer):
10467 * bytecode.c (syms_of_bytecode):
10468 * callint.c (syms_of_callint):
10469 * casefiddle.c (syms_of_casefiddle):
10470 * casetab.c (init_casetab_once):
10471 * category.c (init_category_once, syms_of_category):
10472 * ccl.c (syms_of_ccl):
10473 * cmds.c (syms_of_cmds):
10474 * composite.c (syms_of_composite):
10475 * dbusbind.c (syms_of_dbusbind):
10476 * dired.c (syms_of_dired):
10477 * dispnew.c (syms_of_display):
10478 * doc.c (syms_of_doc):
10479 * editfns.c (syms_of_editfns):
10480 * emacs.c (syms_of_emacs):
10481 * eval.c (syms_of_eval):
10482 * fileio.c (syms_of_fileio):
10483 * fns.c (syms_of_fns):
10484 * frame.c (syms_of_frame):
10485 * fringe.c (syms_of_fringe):
10486 * insdel.c (syms_of_insdel):
10487 * keymap.c (syms_of_keymap):
10488 * lread.c (init_obarray, syms_of_lread):
10489 * macros.c (syms_of_macros):
10490 * msdos.c (syms_of_msdos):
10491 * print.c (syms_of_print):
10492 * process.c (syms_of_process):
10493 * search.c (syms_of_search):
10494 * sound.c (syms_of_sound):
10495 * syntax.c (init_syntax_once, syms_of_syntax):
10496 * terminal.c (syms_of_terminal):
10497 * textprop.c (syms_of_textprop):
10498 * undo.c (syms_of_undo):
10499 * w32.c (globals_of_w32):
10500 * window.c (syms_of_window):
10501 * xdisp.c (syms_of_xdisp):
10502 * xfaces.c (syms_of_xfaces):
10503 * xfns.c (syms_of_xfns):
10504 * xmenu.c (syms_of_xmenu):
10505 * xsettings.c (syms_of_xsettings):
10506 * xterm.c (syms_of_xterm): Use DEFSYM.
10507
4228cf16
TZ
105082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10509
cd3520a4 10510 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10511
7fcccf1e
PE
105122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10513
7efb4e0e
PE
10514 Integer and buffer overflow fixes (Bug#8873).
10515
ff5844ad
PE
10516 * print.c (printchar, strout): Check for string overflow.
10517 (PRINTPREPARE, printchar, strout):
10518 Don't set size unless allocation succeeds.
10519
90532f02
PE
10520 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10521 for sizes. Check for string overflow more accurately.
10522 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10523
6d84508d
PE
10524 * macros.c: Integer and buffer overflow fixes.
10525 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10526 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10527 Use ptrdiff_t, not int, for sizes.
10528 Don't increment bufsize until after realloc succeeds.
10529 Check for size-calculation overflow.
10530 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10531
437b2cb4
PE
10532 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10533
8b9ac8b4
PE
10534 * lread.c: Integer overflow fixes.
10535 (read_integer): Radix is now EMACS_INT, not int,
10536 to improve quality of diagnostics for out-of-range radices.
10537 Calculate buffer size correctly for out-of-range radices.
10538 (read1): Check for integer overflow in radices, and in
10539 read-circle numbers.
82cb60d3
PE
10540 (read_escape): Avoid int overflow.
10541 (Fload, openp, read_buffer_size, read1)
10542 (substitute_object_recurse, read_vector, read_list, map_obarray):
10543 Use ptrdiff_t, not int, for sizes.
10544 (read1): Use EMACS_INT, not int, for sizes.
20270765 10545 Check for size overflow.
8b9ac8b4 10546
7fcccf1e
PE
10547 * image.c (cache_image): Check for size arithmetic overflow.
10548
bfbbd7e7
PE
10549 * lread.c: Integer overflow issues.
10550 (saved_doc_string_size, saved_doc_string_length)
10551 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10552 Now ptrdiff_t, not int.
10553 (read1): Don't assume doc string length fits in int. Check for
10554 out-of-range doc string lengths.
10555 (read_list): Don't assume file position fits in int.
39019e54 10556 (read_escape): Check for hex character overflow.
bfbbd7e7 10557
4e323265
LL
105582011-06-22 Leo Liu <sdl.web@gmail.com>
10559
10560 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10561 Move to minibuffer.el.
10562
85fece3e
PE
105632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10564
20b84ce9 10565 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10566 The following patches are for when GLYPH_DEBUG && !XASSERT.
10567 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10568 * dispnew.c (flush_stdout):
10569 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10570 Mark as externally visible.
10571 * dispnew.c (check_window_matrix_pointers): Now static.
10572 * dispnew.c (window_to_frame_vpos):
10573 * xfns.c (unwind_create_frame):
10574 * xterm.c (x_check_font): Remove unused local.
10575 * scroll.c (CHECK_BOUNDS):
10576 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10577 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10578 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10579 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10580 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10581 Now static.
10582 (debug_method_add): Use va_list and vsprintf rather than relying
10583 on undefined behavior with wrong number of arguments.
10584 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10585 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10586 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10587 since we're not interested in debugging glyphs with old libraries.
10588 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10589 GCC 4.6.0's static checking.
10590
0766b489
PE
105912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10592
31fd4b32
PE
10593 Integer overflow and signedness fixes (Bug#8873).
10594 A few related buffer overrun fixes, too.
10595
b79e8648
PE
10596 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10597
0766b489
PE
10598 * dispextern.h (struct face.stipple):
10599 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10600 (x_bitmap_mask, x_allocate_bitmap_record)
10601 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10602 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10603 (x_create_bitmap_from_xpm_data):
10604 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10605 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10606 (.bitmaps_last):
10607 * xfaces.c (load_pixmap):
10608 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10609 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10610 (.bitmaps_last, struct x_output.icon_bitmap):
10611 Use ptrdiff_t, not int, for bitmap indexes.
10612 (x_allocate_bitmap_record): Check for size overflow.
10613 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10614
b081724f
PE
10615 Use ptrdiff_t, not int, for overlay counts.
10616 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10617 * editfns.c (overlays_around, get_pos_property):
10618 * textprop.c (get_char_property_and_overlay):
10619 * xdisp.c (next_overlay_change, note_mouse_highlight):
10620 * xfaces.c (face_at_buffer_position):
21514da7
PE
10621 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10622 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10623 (Fnext_overlay_change, Fprevious_overlay_change)
10624 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10625 Use ptrdiff_t, not int, for sizes.
21514da7 10626 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10627
3de73e5e
PE
10628 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10629
2606c57b
PE
10630 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10631 (x_session_initialize): Do not assume string length fits in int.
10632
aaafe47a
PE
10633 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10634 This is unlikely, but can occur if DPI is outlandish.
10635
2674ddc8 10636 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10637 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10638
28154962
PE
10639 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10640 * xrdb.c (magic_file_p, search_magic_path):
10641 Omit last arg SUFFIX; it was always 0. All callers changed.
10642 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10643
7de51af5
PE
10644 * xfont.c (xfont_match): Avoid need for strlen.
10645
25ed6cc3
PE
10646 * xfns.c: Don't assume strlen fits in int.
10647 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10648
4eab31dd
PE
10649 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10650 not unsigned long, as we prefer signed integers. All callers changed.
10651 Detect integer overflow in repeat count.
10652 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10653 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10654
171e2a58
PE
10655 * termcap.c: Don't assume sizes fit in int and never overflow.
10656 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10657 (gobble_line): Check for size-calculation overflow.
10658
ad39faca 10659 * minibuf.c (Fread_buffer):
6e5bb2dc 10660 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10661 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10662 Don't assume string length fits in int.
10663
52c61c22 10664 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10665 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10666
b5b8c9e5
PE
10667 * font.c: Don't assume string length fits in int.
10668 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10669 Use ptrdiff_t, not int.
ccd6111c
PE
10670 (font_intern_prop): Don't assume string length fits in int.
10671 Don't assume integer property fits in fixnum.
10672 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10673
882f0d81 10674 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10675 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10676 Reformulate so as not to need the command string.
10677 Invoke gzip -cd rather than gunzip, as it's more portable.
10678 (lock_info_type, lock_file_1, lock_file):
10679 Don't assume pid_t and time_t fit in unsigned long.
10680 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10681 (current_lock_owner): Prefer signed type for sizes.
10682 Use memcpy, not strncpy, where memcpy is what is really wanted.
10683 Don't assume (via atoi) that time_t and pid_t fit in int.
10684 Check for time_t and/or pid_t out of range, e.g., via a network share.
10685 Don't alloca where an auto var works fine.
10686
93f4cf88
PE
10687 * fileio.c: Fix some integer overflow issues.
10688 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10689 Don't assume string length fits in int.
10690 (directory_file_name): Don't assume string length fits in long.
10691 (make_temp_name): Don't assume pid fits in int, or that its print
10692 length is less than 20.
10693
f3e92b69
PE
10694 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10695
1bfdaf10
PE
10696 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10697
35016e9a
PE
10698 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10699
3d1e65a1
PE
10700 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10701 We prefer signed integers, even for size calculations.
10702
0b963a93
PE
10703 * emacs.c: Don't assume string length fits in 'int'.
10704 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10705 (main): Don't invoke strlen when not needed.
10706
573f4b54
PE
10707 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10708 (XD_DEBUG_MESSAGE): Don't waste a byte.
10709
989f33ba
PE
10710 * callproc.c (getenv_internal_1, getenv_internal)
10711 (Fgetenv_internal):
965d34eb
PE
10712 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10713
e4d29b33
PE
10714 * lread.c (invalid_syntax): Omit length argument.
10715 All uses changed. This doesn't fix a bug, but it simplifies the
10716 code away from its former Hollerith-constant appearance, and it's
10717 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10718 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10719
eb49b136
PE
10720 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10721 This didn't break anything, but it didn't help either.
10722 It's confusing to put a bogus integer in a place where the actual
10723 value does not matter.
9f62aeb1 10724 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10725 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10726
15375a22
PE
10727 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10728 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10729 implementation.
b61cc01c
PE
10730 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10731 We prefer signed types, and the value cannot exceed the EMACS_INT
10732 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10733 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10734 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10735 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10736
53b2623d
PE
10737 * indent.c (sane_tab_width): New function.
10738 (current_column, scan_for_column, Findent_to, position_indentation)
10739 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10740 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10741
51cab52b 10742 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10743
f2ed8a70
PE
10744 * lisp.h (lint_assume): New macro.
10745 * composite.c (composition_gstring_put_cache):
10746 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10747
abe80cc6
PE
10748 * editfns.c, insdel.c:
10749 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10750
b02c740e
PE
10751 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10752
ebc96716
PE
10753 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10754
b4e50fa0 10755 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10756 Use much-faster test for byte-length change.
311d5d7c 10757 Don't assume string byte-length fits in 'int'.
a4cf38e4 10758 Check that character arg fits in 'int'.
85461888 10759 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10760
c0c1ee9f
PE
10761 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10762
a498d7f4
PE
10763 * fns.c (concat): Catch string overflow earlier.
10764 Do not rely on integer wraparound.
10765
51cab52b
PE
10766 * dispextern.h (struct it.overlay_strings_charpos)
10767 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10768 * xdisp.c (forward_to_next_line_start)
10769 (back_to_previous_visible_line_start)
10770 (reseat_at_next_visible_line_start, next_element_from_buffer):
10771 Don't arbitrarily truncate the value of 'selective' to int.
10772
76031fad
PE
10773 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10774
5eb55db9
PE
10775 * composite.c: Don't truncate sizes to 'int'.
10776 (composition_gstring_p, composition_reseat_it)
10777 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10778 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10779 not EMACS_UINT, for indexes.
5eb55db9 10780
0703a717
PE
10781 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10782
d6202519
PE
10783 * buffer.c: Include <verify.h>.
10784 (struct sortvec.priority, struct sortstr.priority):
8961a454 10785 Now EMACS_INT, not int.
c20998a7 10786 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10787 (struct sortstr.size, record_overlay_string)
10788 (struct sortstrlist.size, struct sortlist.used):
10789 Don't truncate size to int.
10790 (record_overlay_string): Check for size-calculation overflow.
d6202519 10791 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10792
d5a19415
JM
107932011-06-22 Jim Meyering <meyering@redhat.com>
10794
029529ac 10795 Don't leak an XBM-image-sized buffer
d5a19415
JM
10796 * image.c (xbm_load): Free the image buffer after using it.
10797
a9041e6c
PE
107982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10799
10800 Port to Sun C.
10801 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10802 that Sun C diagnosed.
10803 * fns.c (secure_hash): Fix pointer signedness issue.
10804 * intervals.c (static_offset_intervals): New function.
10805 (offset_intervals): Use it.
10806
7f3f739f
LL
108072011-06-21 Leo Liu <sdl.web@gmail.com>
10808
10809 * deps.mk (fns.o):
10810 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10811 sha512.h.
10812
10813 * fns.c (secure_hash): Rename from crypto_hash_function and change
10814 the first arg to accept symbols.
5b66d427 10815 (Fsecure_hash): New primitive.
7f3f739f
LL
10816 (syms_of_fns): New symbols.
10817
76147d94
DD
108182011-06-20 Deniz Dogan <deniz@dogan.se>
10819
10820 * process.c (Fset_process_buffer): Clarify return value in
10821 docstring.
10822
7d7d0045
CY
108232011-06-18 Chong Yidong <cyd@stupidchicken.com>
10824
10825 * dispnew.c (add_window_display_history): Use BVAR.
10826
10827 * xdisp.c (debug_method_add): Use BVAR.
10828 (check_window_end, dump_glyph_matrix, dump_glyph)
10829 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10830
10831 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10832 Likewise.
10833
10834 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10835 check till after the cache is created in init_frame_faces.
10836
ff2bc410
SM
108372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10838
10839 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10840
28177add
PE
108412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10842
dd3482fe
PE
10843 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10844 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10845 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10846
393d71f3 10847 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10848 * fileio.c (Finsert_file_contents):
10849 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10850 Remove the old (too-loose) buffer overflow checks.
10851 They weren't needed, since make_gap checks for buffer overflow.
10852 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10853 The old code merely checked for Emacs fixnum overflow, and relied
10854 on undefined (wraparound) behavior. The new code avoids undefined
10855 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10856
2e6813b0 10857 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10858 Tune. Don't use wider integers than needed. Don't use alloca.
10859 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10860
599a9e4f
PE
10861 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10862
99561444
PE
10863 * insdel.c, lisp.h (buffer_overflow): New function.
10864 (insert_from_buffer_1, replace_range, replace_range_2):
10865 * insdel.c (make_gap_larger):
10866 * editfns.c (Finsert_char):
10867 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10868
28177add
PE
10869 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10870
e69dafad
PE
108712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10872
4baa020d 10873 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10874
b1c46f02
PE
10875 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10876 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10877
e69dafad
PE
10878 * fileio.c: Don't assume EMACS_INT fits in off_t.
10879 (emacs_lseek): New static function.
10880 (Finsert_file_contents, Fwrite_region): Use it.
10881 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10882
566684ea
PE
10883 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10884
e6966cd6
PE
10885 * fns.c: Don't overflow int when computing a list length.
10886 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10887 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10888 truncation on 64-bit hosts. Check for QUIT every
10889 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10890 faster and is responsive enough.
10891 (Flength): Report an error instead of overflowing an integer.
10892 (Fsafe_length): Return a float if the value is not representable
10893 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10894 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10895 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10896
dd0b0efb
PE
10897 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10898 (header_size, word_size): New constants.
10899 (allocate_vectorlike): Don't check size overflow here.
10900 (allocate_vector): Check it here instead, since this is the only
10901 caller of allocate_vectorlike that could cause overflow.
10902 Check that the new vector's length is representable as a fixnum.
10903
86fe5cfe
PE
10904 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10905 The previous code was bogus. For example, next_almost_prime (32)
10906 returned 39, which is undesirable as it is a multiple of 3; and
10907 next_almost_prime (24) returned 25, which is a multiple of 5 so
10908 why was the code bothering to check for multiples of 7?
10909
80e88859
PE
10910 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10911
4a2f0ad6
PE
10912 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10913
f66c7cf8
PE
10914 Variadic C functions now count arguments with ptrdiff_t.
10915 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10916 Back then I didn't know that the Emacs coding style prefers signed int.
10917 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10918 were being counted with int, which may truncate counts on 64-bit
10919 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10920 * lisp.h (struct Lisp_Subr.function.aMANY)
10921 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10922 Arg counts are now ptrdiff_t, not size_t.
10923 All variadic functions and their callers changed accordingly.
10924 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10925 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10926 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10927 * callint.c (Fcall_interactively): Check arg count for overflow,
10928 to avoid potential buffer overrun. Use signed char, not 'int',
10929 for 'varies' array, so that we needn't bother to check its size
10930 calculation for overflow.
10931 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10932 * eval.c (apply_lambda):
10933 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10934 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10935 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10936
a1759b76
PE
10937 * callint.c (Fcall_interactively): Don't use index var as event count.
10938
d96be9fc
PE
10939 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10940 * mem-limits.h (SIZE): Remove; no longer used.
10941
a690a978 10942 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10943
578c21e6
PE
10944 Remove unnecessary casts.
10945 * xterm.c (x_term_init):
10946 * xfns.c (x_set_border_pixel):
10947 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10948 These aren't needed now that we assume ANSI C.
10949
96f53c6c
PE
10950 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10951 It's more likely to cause problems (due to unsigned overflow)
10952 than to cure them.
10953
83c77d31
PE
10954 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10955
ee2079f1
PE
10956 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10957
6da65536
PE
10958 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10959
7147c4a4
PE
10960 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10961
193e32d9
PE
10962 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10963
e5533da6
PE
10964 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10965
9910e595
PE
10966 GLYPH_CODE_FACE returns EMACS_INT, not int.
10967 * dispextern.h (merge_faces):
10968 * xfaces.c (merge_faces):
01103c44
PE
10969 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10970 Don't assume EMACS_INT fits in int.
9910e595 10971
2638320e
PE
10972 * character.h (CHAR_VALID_P): Remove unused parameter.
10973 * fontset.c, lisp.h, xdisp.c: All uses changed.
10974
045eb8d9
PE
10975 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10976
c1f134b5
PE
10977 * fns.c (concat): Minor tuning based on overflow analysis.
10978 This doesn't fix any bugs. Use int to hold character, instead
10979 of constantly refetching from Emacs object. Use XFASTINT, not
10980 XINT, for value known to be a character. Don't bother comparing
10981 a single byte to 0400, as it's always less.
10982
395fcb93 10983 * floatfns.c (Fexpt):
327eeec8
PE
10984 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10985
abbd3d23
PE
10986 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10987 for characters.
10988
684a03ef
PE
10989 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10990
0fed43f3
PE
10991 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10992 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10993 incorrectly succeed when S was a string, because 4294967386 was
10994 truncated before it was used.
10995
8fd02eb7
PE
10996 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10997 Otherwise, an out-of-range integer could cause undefined behavior
10998 on a 64-bit host.
10999
f8c86b69
PE
11000 * composite.c: Use int, not EMACS_INT, for characters.
11001 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11002 EMACS_INT, for values that are known to be in character range.
11003 This doesn't fix any bugs but is the usual style inside Emacs and
11004 may generate better code on 32-bit machines.
11005
34206dd2
PE
11006 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11007 This is for reasons similar to the recent CHAR_STRING fix.
11008 * charset.c (Fencode_char): Check that character arg is actually
11009 a character. Pass an int to ENCODE_CHAR.
11010 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11011 wider than 'int', as a compile-time check to prevent future regressions
11012 in this area.
11013
c5958d4c 11014 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11015
11016 Make sure a 64-bit char is never passed to CHAR_STRING.
11017 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11018 by silently ignoring the top 32 bits, allowing some values
11019 that were far too large to be valid characters.
11020 * character.h: Include <verify.h>.
11021 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11022 arguments are no wider than unsigned, as a compile-time check
11023 to prevent future regressions in this area.
11024 * data.c (Faset):
01103c44 11025 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11026 (Fsubst_char_in_region):
11027 * fns.c (concat):
11028 * xdisp.c (decode_mode_spec_coding):
11029 Adjust to CHAR_STRING's new requirement.
11030 * editfns.c (Finsert_char, Fsubst_char_in_region):
11031 * fns.c (concat): Check that character args are actually
11032 characters. Without this test, these functions did the wrong
11033 thing with wildly out-of-range values on 64-bit hosts.
11034
d37ca623
PE
11035 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11036 These casts should not be needed on 32-bit hosts, either.
11037 * keyboard.c (read_char):
11038 * lread.c (Fload): Remove casts to unsigned.
11039
ea204efb
PE
11040 * lisp.h (UNSIGNED_CMP): New macro.
11041 This fixes comparison bugs on 64-bit hosts.
11042 (ASCII_CHAR_P): Use it.
11043 * casefiddle.c (casify_object):
01103c44 11044 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11045 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11046 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11047 * dispextern.h (FACE_FROM_ID):
11048 * keyboard.c (read_char): Use UNSIGNED_CMP.
11049
41cb286c
PE
11050 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11051 not to EMACS_INT, to avoid GCC warning.
11052
4a1b9832
PE
11053 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11054
55daad71
PE
11055 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11056 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11057 isn't needed on 32-bit machines.
8f95c75c 11058
01103c44
PE
11059 * buffer.c (Fgenerate_new_buffer_name):
11060 Use EMACS_INT for count, not int.
0ceccced 11061 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11062
11063 * data.c (Qcompiled_function): Now static.
11064
c6f072e7
PE
11065 * window.c (window_body_lines): Now static.
11066
20ce5912
PE
11067 * image.c (gif_load): Rename local to avoid shadowing.
11068
9c4c5f81
PE
11069 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11070 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11071 * alloc.c (make_save_value): Integer argument is now of type
11072 ptrdiff_t, not int.
11073 (mark_object): Use ptrdiff_t, not int.
11074 * lisp.h (pD): New macro.
11075 * print.c (print_object): Use it.
11076
c0c5c8ae
PE
11077 * alloc.c: Use EMACS_INT, not int, to count objects.
11078 (total_conses, total_markers, total_symbols, total_vector_size)
11079 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11080 (total_free_floats, total_floats, total_free_intervals)
11081 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11082 Now EMACS_INT, not int. All uses changed.
11083 (Fgarbage_collect): Compute overall total using a double, so that
11084 integer overflow is less likely to be a problem. Check for overflow
11085 when converting back to an integer.
5a25e253
PE
11086 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11087 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11088 These were 'int' variables that could overflow on 64-bit hosts;
11089 they were never used, so remove them instead of repairing them.
211a0b2a 11090 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11091 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11092 Previously, this ceilinged at INT_MAX, but that doesn't work on
11093 64-bit machines.
e46bb31a 11094 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11095
c78baabf 11096 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11097 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11098 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11099 when a (possibly-narrower) signed value would do just as well.
11100 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11101
c9d624c6
PE
11102 * alloc.c: Catch some string size overflows that we were missing.
11103 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11104 for convenience in STRING_BYTES_MAX.
11105 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11106 The definition here is exact; the one in lisp.h was approximate.
11107 (allocate_string_data): Check for string overflow. This catches
11108 some instances we weren't catching before. Also, it catches
11109 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11110 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11111 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11112
c9d624c6
PE
11113 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11114 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11115 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11116
353032ce
PE
11117 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11118
2bccce07
PE
11119 * alloc.c (Fmake_string): Check for out-of-range init.
11120
0ac30604
SM
111212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11122
11123 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11124
c195f2de
JD
111252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11126
11127 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11128 xg_get_default_scrollbar_width.
11129
11130 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11131 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11132 (style_changed_cb): Call update_theme_scrollbar_width and call
11133 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11134 all frames (Bug#8505).
11135 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11136 Call gtk_window_set_resizable if HAVE_GTK3.
11137 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11138 and height if HAVE_GTK3 (Bug#8505).
11139 (scroll_bar_width_for_theme): New variable.
11140 (update_theme_scrollbar_width): New function.
11141 (xg_get_default_scrollbar_width): Move code to
11142 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11143 (xg_initialize): Call update_theme_scrollbar_width.
11144
11145 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11146
11147 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11148
e10ac9f1
MR
111492011-06-12 Martin Rudalics <rudalics@gmx.at>
11150
11151 * frame.c (make_frame): Call other_buffer_safely instead of
11152 other_buffer.
11153
11154 * window.c (temp_output_buffer_show): Call display_buffer with
11155 second argument Vtemp_buffer_show_specifiers and reset latter
11156 immediately after the call.
11157 (Vtemp_buffer_show_specifiers): New variable.
11158 (auto_window_vscroll_p, next_screen_context_lines)
11159 (Vscroll_preserve_screen_position): Remove leading asterisks from
11160 doc-strings.
11161
2d3c217e 111622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11163
7b7f97e8 11164 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11165 * buffer.c (Qclone_number): Remove for now, as it's unused.
11166 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11167 (record_buffer): Remove unused local.
11168 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11169 (set_frame_buffer_list): Remove; unused.
11170 * frame.h (other_visible_frames): Remove decl.
11171 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11172 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11173 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11174 if HAVE_GPM.
11175 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11176 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11177 Define only if HAVE_GPM.
11178 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11179 (update_hints_inhibit): Remove; never set. All uses removed.
11180 * widgetprv.h (emacsFrameClassRec): Remove decl.
11181 * window.c (delete_deletable_window): Now returns void, since it
11182 wasn't returning anything.
11183 (compare_window_configurations): Remove unused locals.
11184 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11185 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11186 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11187 the same widths as pointers. This follows up on the 2011-05-06 patch.
11188 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11189 * xterm.h: Likewise.
11190 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11191
1384b89e
JB
111922011-06-12 Juanma Barranquero <lekktu@gmail.com>
11193
11194 * makefile.w32-in: Update dependencies.
11195 (LISP_H): Add lib/intprops.h.
11196
1100a63c
CY
111972011-06-11 Chong Yidong <cyd@stupidchicken.com>
11198
11199 * image.c (gif_load): Add animation frame delay to the metadata.
11200 (syms_of_image): Use DEFSYM. New symbol `delay'.
11201
6198ccd0
MR
112022011-06-11 Martin Rudalics <rudalics@gmx.at>
11203
11204 * window.c (delete_deletable_window): Re-add.
11205 (Fset_window_configuration): Rewrite to handle dead buffers and
11206 consequently deletable windows.
11207 (window_tree, Fwindow_tree): Remove. Supply functionality in
11208 window.el.
11209 (compare_window_configurations): Simplify code.
11210
b6e3633c
AS
112112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11212
1ab0dee5
AS
11213 * image.c (imagemagick_load_image): Fix type mismatch.
11214 (Fimagemagick_types): Likewise.
11215
b6e3633c
AS
11216 * window.h (replace_buffer_in_windows): Declare.
11217
9397e56f
MR
112182011-06-11 Martin Rudalics <rudalics@gmx.at>
11219
11220 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11221 Qclone_number. Remove external declaration of Qdelete_window.
11222 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11223 code.
640c8776
SM
11224 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11225 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11226 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11227 buffer list implementation.
11228 (other_buffer_safely): New function.
11229 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11230 calls to replace_buffer_in_windows and
11231 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11232 if allowed.
11233 (record_buffer): Inhibit quitting and rewrite using quittable
11234 functions. Run Qbuffer_list_update_hook if allowed.
11235 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11236 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11237 Move switch-to-buffer to window.el.
9397e56f
MR
11238 (bury-buffer): Move to window.el.
11239 (Vbuffer_list_update_hook): New variable.
11240
11241 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11242 section.
11243
11244 * window.h (resize_frame_windows): Move up in code.
11245 (Fwindow_frame): Remove EXFUN.
11246 (replace_buffer_in_all_windows): Remove prototype.
11247 (replace_buffer_in_windows_safely): Add prototype.
11248
11249 * window.c: Declare Qdelete_window static again. Move down
11250 declaration of select_count.
11251 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11252 (Fother_window): Move to window.el.
11253 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11254 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11255 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11256 window.el.
11257 (replace_buffer_in_windows): Implement by calling
11258 Qreplace_buffer_in_windows.
11259 (replace_buffer_in_all_windows): Remove with some functionality
11260 moved into replace_buffer_in_windows_safely.
11261 (replace_buffer_in_windows_safely): New function.
11262 (select_window_norecord, select_frame_norecord): Move in front
11263 of run_window_configuration_change_hook. Remove now obsolete
11264 declarations.
640c8776
SM
11265 (Fset_window_buffer): Rewrite doc-string.
11266 Call Qrecord_window_buffer.
9397e56f
MR
11267 (keys_of_window): Move binding for other-window to window.el.
11268
b50691aa
CY
112692011-06-11 Chong Yidong <cyd@stupidchicken.com>
11270
11271 * dispextern.h (struct image): Replace data member, whose int_val
11272 and ptr_val fields were not used by anything, with a single
11273 lisp_val object.
11274
11275 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11276 (gif_clear_image, gif_load, imagemagick_load_image)
11277 (gs_clear_image, gs_load): Callers changed.
11278
3f754b86
PE
112792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11280
cca69397
PE
11281 * buffer.h: Include <time.h>, for time_t.
11282 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11283
109e28d0
PE
11284 Fix minor problems found by static checking.
11285
60737f02
PE
11286 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11287
4b66faf3
PE
11288 Make identifiers static if they are not used in other modules.
11289 * data.c (Qcompiled_function, Qframe, Qvector):
11290 * image.c (QimageMagick, Qsvg):
11291 * minibuf.c (Qmetadata):
11292 * window.c (resize_window_check, resize_root_window): Now static.
11293 * window.h (resize_window_check, resize_root_window): Remove decls.
11294
109e28d0
PE
11295 * window.c (window_deletion_count, delete_deletable_window):
11296 Remove; unused.
46a4ce9e
PE
11297 (window_body_lines): Now static.
11298 (Fdelete_other_windows_internal): Mark vars as initialized.
11299 Make sure 'resize_failed' is initialized.
11300 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11301 (resize_window_apply): Remove unused local.
11302 * window.h (delete_deletable_window): Remove decl.
11303
109e28d0 11304 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11305 (imagemagick_load_image): Fix pointer signedness problem by changing
11306 last arg from unsigned char * to char *. All uses changed.
11307 Also, fix a local for similar reasons.
11308 Remove unused locals. Remove locals to avoid shadowing.
11309 (fn_rsvg_handle_free): Remove; unused.
11310 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11311 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11312
3f754b86
PE
11313 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11314
2547adb1
CY
113152011-06-10 Chong Yidong <cyd@stupidchicken.com>
11316
11317 * image.c (gif_load): Fix omitted cast error introduced by
11318 2011-06-06 change.
11319
2c8e37d4
MR
113202011-06-10 Martin Rudalics <rudalics@gmx.at>
11321
11322 * window.h (resize_proportionally, orig_total_lines)
11323 (orig_top_line): Remove from window structure.
11324 (set_window_height, set_window_width, change_window_heights)
11325 (Fdelete_window): Remove prototypes.
11326 (resize_frame_windows): Remove duplicate declaration.
11327
440a42e3
EZ
113282011-06-10 Eli Zaretskii <eliz@gnu.org>
11329
11330 * window.h (resize_frame_windows, resize_window_check)
11331 (delete_deletable_window, resize_root_window)
11332 (resize_frame_windows): Declare prototypes.
11333
11334 * window.c (resize_window_apply): Make definition be "static" to
11335 match the prototype.
11336
562dd5e9
MR
113372011-06-10 Martin Rudalics <rudalics@gmx.at>
11338
11339 * window.c: Remove declarations of Qwindow_size_fixed,
11340 window_min_size_1, window_min_size_2, window_min_size,
11341 size_window, window_fixed_size_p, enlarge_window, delete_window.
11342 Remove static from declaration of Qdelete_window, it's
11343 temporarily needed by Fbury_buffer.
11344 (replace_window): Don't assign orig_top_line and
11345 orig_total_lines.
11346 (Fdelete_window, delete_window): Remove. Window deletion is
11347 handled by window.el.
640c8776
SM
11348 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11349 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11350 (Fdelete_other_windows): Remove. Deleting other windows is
11351 handled by window.el.
11352 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11353 handled in window.el.
11354 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11355 Window minimum sizes are handled in window.el.
11356 (shrink_windows, size_window, set_window_height)
11357 (set_window_width, change_window_heights, window_height)
11358 (window_width, CURBEG, CURSIZE, enlarge_window)
11359 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11360 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11361 handled in window.el.
11362 (make_dummy_parent): Rename to make_parent_window and give it a
11363 second argument horflag.
11364 (make_window): Don't set resize_proportionally any more.
11365 (Fsplit_window): Remove. Windows are split in window.el.
11366 (save_restore_action, save_restore_orig_size)
11367 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11368 Resize mini windows in window.el.
11369 (grow_mini_window, shrink_mini_window): Implement by calling
11370 Qresize_root_window_vertically, resize_window_check and
11371 resize_window_apply.
640c8776
SM
11372 (saved_window, Fset_window_configuration, save_window_save):
11373 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11374 resize_proportionally.
11375 (window_min_height, window_min_width): Move to window.el.
11376 (keys_of_window): Move bindings for delete-other-windows,
11377 split-window, delete-window and enlarge-window to window.el.
11378
11379 * buffer.c: Temporarily extern Qdelete_window.
11380 (Fbury_buffer): Temporarily call Qdelete_window instead of
11381 Fdelete_window (Fbury_buffer will move to window.el soon).
11382
11383 * frame.c (set_menu_bar_lines_1): Remove code handling
11384 orig_top_line and orig_total_lines.
11385
11386 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11387 set_window_height but set heights directly.
11388 (change_frame_size_1): Use resize_frame_windows.
11389
11390 * xdisp.c (init_xdisp): Don't use set_window_height but set
11391 heights directly.
11392
640c8776
SM
11393 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11394 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11395 run_window_configuration_change_hook.
11396
11397 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11398 instead of change_window_heights and run
11399 run_window_configuration_change_hook.
11400
1a13852e
MR
114012011-06-09 Martin Rudalics <rudalics@gmx.at>
11402
11403 * window.c (replace_window): Rename second argument REPLACEMENT to
11404 NEW. New third argument SETFLAG. Rewrite.
11405 (delete_window, make_dummy_parent): Call replace_window with
11406 third argument 1.
11407 (window_list_1): Move down in code.
11408 (run_window_configuration_change_hook): Move set_buffer part
11409 before select_frame_norecord part in order to unwind correctly.
11410 Rename count1 to count.
11411 (recombine_windows, delete_deletable_window, resize_root_window)
11412 (Fdelete_other_windows_internal)
11413 (Frun_window_configuration_change_hook, make_parent_window)
11414 (resize_window_check, resize_window_apply, Fresize_window_apply)
11415 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11416 (Fdelete_window_internal, Fresize_mini_window_internal):
11417 New functions.
1a13852e
MR
11418 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11419
f3d1777e
MR
114202011-06-08 Martin Rudalics <rudalics@gmx.at>
11421
496e208e
MR
11422 * window.h (window): Add some new members to window structure -
11423 normal_lines, normal_cols, new_total, new_normal, clone_number,
11424 splits, nest, prev_buffers, next_buffers.
11425 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11426 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11427
f3d1777e
MR
11428 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11429 Remove.
496e208e
MR
11430 (make_dummy_parent): Set new members of windows structure.
11431 (make_window): Move down in code. Handle new members of window
11432 structure.
11433 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11434 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11435 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11436 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11437 (Fset_window_next_buffers, Fset_window_clone_number):
11438 New functions.
496e208e
MR
11439 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11440 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11441 Doc-string fixes.
11442 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11443 Argument WINDOW can be now internal window too.
11444 (Fwindow_use_time): Move up in code.
11445 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11446 Rewrite doc-string.
11447 (Fset_window_configuration, saved_window)
11448 (Fcurrent_window_configuration, save_window_save): Handle new
11449 members of window structure.
b9e809c2
MR
11450 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11451 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11452 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11453 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11454 Qget_mru_window, Qresize_root_window,
11455 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11456 Qauto_buffer_name; staticpro them.
f3d1777e 11457
abde8f8c
MR
114582011-06-07 Martin Rudalics <rudalics@gmx.at>
11459
11460 * window.c (Fwindow_total_size, Fwindow_left_column)
11461 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11462 (Fwindow_list_1): New functions.
11463 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11464 (Fwindow_width, Fscroll_left, Fscroll_right):
11465 Use window_body_cols instead of window_box_text_cols.
11466 (delete_window, Fset_window_configuration):
11467 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11468 (delete_all_subwindows): Take a window as argument and not a
11469 structure. Rewrite.
190b47e6
MR
11470 (window_loop): Remove handling of GET_LRU_WINDOW and
11471 GET_LARGEST_WINDOW.
11472 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11473
11474 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11475 window_box_text_cols. delete_all_subwindows now takes a
11476 Lisp_Object as argument.
abde8f8c 11477
640c8776
SM
11478 * indent.c (compute_motion, Fcompute_motion):
11479 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11480
fa8a67e6
MR
11481 * frame.c (delete_frame): Call delete_all_subwindows with root
11482 window as argument.
11483
a54e3482
DC
114842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11485
11486 * fns.c (Fputhash): Document return value.
11487
60002bf5
CY
114882011-06-06 Chong Yidong <cyd@stupidchicken.com>
11489
11490 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11491
0c671da6 114922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11493
b862a52a 11494 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11495
be44ca6c
PE
11496 Check for overflow when converting integer to cons and back.
11497 * charset.c (Fdefine_charset_internal, Fdecode_char):
11498 Use cons_to_unsigned to catch overflow.
11499 (Fencode_char): Use INTEGER_TO_CONS.
11500 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11501 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11502 * data.c (long_to_cons, cons_to_long): Remove.
11503 (cons_to_unsigned, cons_to_signed): New functions.
11504 These signal an error for invalid or out-of-range values.
11505 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11506 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11507 * font.c (Ffont_variation_glyphs):
11508 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11509 * lisp.h: Include <intprops.h>.
11510 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11511 (cons_to_signed, cons_to_unsigned): New decls.
11512 (long_to_cons, cons_to_long): Remove decls.
11513 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11514 (Fprimitive_undo): Use CONS_TO_INTEGER.
11515 * xfns.c (Fx_window_property): Likewise.
11516 * xselect.c: Include <limits.h>.
11517 (x_own_selection, selection_data_to_lisp_data):
11518 Use INTEGER_TO_CONS.
11519 (x_handle_selection_request, x_handle_selection_clear)
11520 (x_get_foreign_selection, Fx_disown_selection_internal)
11521 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11522 (lisp_data_to_selection_data): Use cons_to_unsigned.
11523 (x_fill_property_data): Use cons_to_signed.
11524 Report values out of range.
11525
d1f3d2af
PE
11526 Check for buffer and string overflow more precisely.
11527 * buffer.h (BUF_BYTES_MAX): New macro.
11528 * lisp.h (STRING_BYTES_MAX): New macro.
11529 * alloc.c (Fmake_string):
11530 * character.c (string_escape_byte8):
11531 * coding.c (coding_alloc_by_realloc):
11532 * doprnt.c (doprnt):
11533 * editfns.c (Fformat):
11534 * eval.c (verror):
11535 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11536 since they may not be the same number.
11537 * editfns.c (Finsert_char):
11538 * fileio.c (Finsert_file_contents):
11539 Likewise for BUF_BYTES_MAX.
11540
dd52fcea
PE
11541 * image.c: Use ptrdiff_t, not int, for sizes.
11542 (slurp_file): Switch from int to ptrdiff_t.
11543 All uses changed.
11544 (slurp_file): Check that file size fits in both size_t (for
11545 malloc) and ptrdiff_t (for sanity and safety).
11546
7f9bbdbb
PE
11547 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11548 if b->modtime has its maximal value.
11549
dfe18f82
PE
11550 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11551
84acfcf0
PE
11552 Don't assume time_t can fit into int.
11553 * buffer.h (struct buffer.modtime): Now time_t, not int.
11554 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11555 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11556
ccd9a01a
PE
11557 Minor fixes for signed vs unsigned integers.
11558 * character.h (MAYBE_UNIFY_CHAR):
11559 * charset.c (maybe_unify_char):
11560 * keyboard.c (read_char, reorder_modifiers):
11561 XINT -> XFASTINT, since the integer must be nonnegative.
11562 * ftfont.c (ftfont_spec_pattern):
11563 * keymap.c (access_keymap, silly_event_symbol_error):
11564 XUINT -> XFASTINT, since the integer must be nonnegative.
11565 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11566 since it makes no difference and we prefer signed.
11567 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11568 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11569 nonnegative.
11570
d6d100dd
SM
115712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11572
11573 * window.h (Fwindow_frame): Declare.
11574
2b6148e4
PE
115752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11576
11577 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11578 (SPARE_MEMORY): Always define.
11579 (LARGE_REQUEST): Remove.
11580 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11581
f230ecc9
MR
115822011-06-06 Martin Rudalics <rudalics@gmx.at>
11583
727e958e
MR
11584 * lisp.h: Move EXFUNS for Fframe_root_window,
11585 Fframe_first_window and Fset_frame_selected_window to window.h.
11586
11587 * window.h: Move EXFUNS for Fframe_root_window,
11588 Fframe_first_window and Fset_frame_selected_window here from
11589 lisp.h.
11590
11591 * frame.c (Fwindow_frame, Fframe_first_window)
11592 (Fframe_root_window, Fframe_selected_window)
11593 (Fset_frame_selected_window): Move to window.c.
11594 (Factive_minibuffer_window): Move to minibuf.c.
11595 (Fother_visible_frames_p): New function.
11596
11597 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11598
f230ecc9
MR
11599 * window.c (decode_window, decode_any_window): Move up in code.
11600 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11601 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11602 (Fwindow_buffer): Move up and rewrite doc-string.
11603 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11604 (Fwindow_prev): New functions.
727e958e
MR
11605 (Fwindow_frame): Move here from frame.c. Accept any window as
11606 argument.
11607 (Fframe_root_window, Fframe_first_window)
11608 (Fframe_selected_window): Move here from frame.c. Accept frame
11609 or arbitrary window as argument. Update doc-strings.
11610 (Fminibuffer_window): Move up in code.
11611 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11612 (Fset_frame_selected_window): Move here from frame.c.
11613 Marginal rewrite.
727e958e
MR
11614 (Fselected_window, select_window, Fselect_window): Move up in
11615 code. Minor doc-string fixes.
f230ecc9 11616
4d09bcf6
PE
116172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11618
11619 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11620 Do not assume that spare memory exists; that assumption is valid
11621 only if SYSTEM_MALLOC.
11622 (LARGE_REQUEST): New macro, so that the issue of large requests
11623 is separated from the issue of spare memory.
11624
810928a2
AS
116252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11626
172418ad
AS
11627 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11628 format. (Bug#8806)
11629
43f862f7
AS
11630 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11631
810928a2
AS
11632 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11633 before statements.
11634
a059fe24
JD
116352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11636
11637 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11638
11639 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11640
11641 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11642 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11643
989bf368
JB
116442011-06-05 Juanma Barranquero <lekktu@gmail.com>
11645
11646 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11647
4b80f674
CY
116482011-06-04 Chong Yidong <cyd@stupidchicken.com>
11649
11650 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11651 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11652 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11653 New error handlers.
4b80f674
CY
11654 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11655 Obey Vx_select_enable_clipboard_manager. Catch errors in
11656 x_clipboard_manager_save (Bug#8779).
11657 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11658 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11659
99a33b77 116602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11661
11662 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11663
99a33b77 116642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11665
11666 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11667 in the current matrix if keep_current_p is non-zero.
11668
8264569d
EZ
116692011-06-04 Eli Zaretskii <eliz@gnu.org>
11670
11671 * bidi.c (bidi_level_of_next_char): Fix last change.
11672
57f97249
EZ
116732011-06-03 Eli Zaretskii <eliz@gnu.org>
11674
fec2107c 11675 Support bidi reordering of text covered by display properties.
57f97249 11676
fec2107c
EZ
11677 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11678 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11679 (bidi_cache_search, bidi_cache_iterator_state)
11680 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11681 (bidi_level_of_next_char, bidi_move_to_visually_next):
11682 Support character positions inside a run of characters covered by a
fec2107c
EZ
11683 display string.
11684 (bidi_paragraph_init, bidi_resolve_explicit_1)
11685 (bidi_level_of_next_char): Call bidi_fetch_char and
11686 bidi_fetch_char_advance instead of FETCH_CHAR and
11687 FETCH_CHAR_ADVANCE.
11688 (bidi_init_it): Initialize new members.
11689 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11690 definitions.
11691 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11692 instead of using explicit *_CHAR codes.
d6d100dd
SM
11693 (bidi_resolve_explicit, bidi_resolve_weak):
11694 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11695 bidirectional text is supported only in multibyte buffers.
11696 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11697 it to initialize the frame_window_p member of struct bidi_it.
11698 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11699 (bidi_resolve_explicit, bidi_resolve_weak)
11700 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11701 bidi_it->nchars is non-positive.
11702 (bidi_level_of_next_char): Don't try to lookup the cache for the
11703 next/previous character if nothing is cached there yet, or if we
11704 were just reseat()'ed to a new position.
c40e2fb2 11705
0e14fe90
EZ
11706 * xdisp.c (set_cursor_from_row): Set start and stop points
11707 according to the row's direction when priming the loop that looks
11708 for the glyph on which to display cursor.
11709 (single_display_spec_intangible_p): Function deleted.
11710 (display_prop_intangible_p): Reimplement to call
11711 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11712 Accept 3 additional arguments needed by handle_display_spec.
11713 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11714 values: lists, `(when COND...)' forms, etc.
11715 (single_display_spec_string_p): Support property values that are
11716 lists with the argument STRING its top-level element.
11717 (display_prop_string_p): Fix the condition for processing a
11718 property that is a list to be consistent with handle_display_spec.
fec2107c 11719 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11720 last portion of handle_display_prop.
11721 (compute_display_string_pos): Accept additional argument
11722 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11723 value of a `display' property is a "replacing spec".
11724 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11725 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11726 the display property, but just return a value indicating whether
11727 the display property will replace the characters it covers.
11728 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11729 frame_window_p members of struct bidi_it.
d6d100dd
SM
11730 (compute_display_string_pos, compute_display_string_end):
11731 New functions.
fec2107c
EZ
11732 (push_it): Accept second argument POSITION, where pop_it should
11733 jump to continue iteration.
11734 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11735
fec2107c
EZ
11736 * keyboard.c (adjust_point_for_property): Adjust the call to
11737 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11738
11739 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11740 (bidi_init_it): Update prototypes.
11741 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11742 (compute_display_string_pos, compute_display_string_end):
11743 Declare prototypes.
fec2107c
EZ
11744 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11745 EMACS_INT.
fc6f18ce 11746
40087514 117472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11748
57f53182
PE
11749 Malloc failure behavior now depends on size of allocation.
11750 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11751 * lisp.h: Change signatures accordingly.
11752 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11753 All callers changed. (Bug#8762)
11754
11755 * gnutls.c: Use Emacs's memory allocators.
11756 Without this change, the gnutls library would invoke malloc etc.
11757 directly, which causes problems on non-SYNC_INPUT hosts, and which
11758 runs afoul of improving memory_full behavior. (Bug#8761)
11759 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11760 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11761 xfree instead of the default malloc, realloc, free.
11762 (Fgnutls_boot): No need to check for memory allocation failure,
11763 since xmalloc does that for us.
11764
ac32cd99 11765 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11766 * category.c (hash_get_category_set):
11767 * ccl.c (ccl_driver):
11768 * charset.c (Fdefine_charset_internal):
11769 * charset.h (struct charset.hash_index):
11770 * composite.c (get_composition_id, gstring_lookup_cache)
11771 (composition_gstring_put_cache):
11772 * composite.h (struct composition.hash_index):
11773 * dispextern.h (struct image.hash):
11774 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11775 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11776 (hashfn_equal, hashfn_user_defined, make_hash_table)
11777 (maybe_resize_hash_table, hash_lookup, hash_put)
11778 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11779 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11780 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11781 * image.c (make_image, search_image_cache, lookup_image)
11782 (xpm_put_color_table_h):
11783 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11784 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11785 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11786 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11787 * alloc.c (allocate_vectorlike):
11788 Check for overflow in vector size calculations.
11789 * ccl.c (ccl_driver):
11790 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11791 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11792 need to be updated by these changes.
40087514
PE
11793 * fns.c (make_hash_table, maybe_resize_hash_table):
11794 Check for integer overflow with large hash tables.
0de4bb68
PE
11795 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11796 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11797 (SXHASH_REDUCE): New macro.
11798 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11799 Use it instead of discarding useful hash info with large hash values.
11800 (sxhash_float): New function.
11801 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11802 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11803 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11804 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11805 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11806 Adjust signatures to match updated version of code.
11807 (consing_since_gc): Now EMACS_INT, since a single hash table can
11808 use more than INT_MAX bytes.
11809
698d32e2
DN
118102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11811
11812 Make it possible to build with GCC-4.6+ -O2 -flto.
11813
11814 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11815
fd6fa53f
SM
118162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11817
11818 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11819 Call minibuffer-inactive-mode.
11820
864db017
JB
118212011-05-31 Juanma Barranquero <lekktu@gmail.com>
11822
11823 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11824 Update dependencies.
11825
2ad0baf4
DN
118262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11827
11828 * data.c (init_data): Remove code for UTS, this system is not
11829 supported anymore.
11830
4fcc2638
DN
118312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11832
11833 Don't force ./temacs to start in terminal mode.
11834
11835 * frame.c (make_initial_frame): Initialize faces in all cases, not
11836 only when CANNOT_DUMP is defined.
11837 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11838
c56e0fd5
DN
118392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11840
11841 * dispnew.c (add_window_display_history): Use const for the string
11842 pointer. Remove declaration, not needed.
11843
333d54da 118442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11845
55d4c1b2 11846 Use 'inline', not 'INLINE'.
333d54da 11847 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11848 * alloc.c, fontset.c (INLINE): Remove.
11849 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11850 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11851 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11852 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11853 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11854
738db178
DN
118552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11856
11857 Make it possible to run ./temacs.
11858
11859 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11860 syms_of_callproc does the same thing. Remove test for
11861 "initialized", do it in the caller.
11862 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11863
620c53a6
SM
118642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11865
11866 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11867 (read_minibuf): Use get_minibuffer.
11868 (syms_of_minibuf): Use DEFSYM.
11869 (Qmetadata): New var.
11870 * data.c (Qbuffer): Don't make it static.
11871 (syms_of_data): Use DEFSYM.
11872
e003a292
PE
118732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11874
11875 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11876 (CCL_CODE_MIN): New macro.
11877
ed008a6d
PE
118782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11879
3687c2ef
PE
11880 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11881
ed008a6d
PE
11882 * eval.c (Qdebug): Now static.
11883 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11884 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11885 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11886
d66c4c7c
CY
118872011-05-29 Chong Yidong <cyd@stupidchicken.com>
11888
11889 * image.c: Various fixes to ImageMagick code comments.
11890 (Fimagemagick_types): Doc fix.
11891
5fbc2025
PE
118922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11893
0196f88a
PE
11894 Minor fixes prompted by GCC 4.6.0 warnings.
11895
11896 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11897
5fbc2025
PE
11898 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11899 (x_clipboard_manager_save_all): Move extern decl to ...
11900 * xterm.h: ... here, so that it can be checked for consistency.
11901
1dd3c2d9
CY
119022011-05-29 Chong Yidong <cyd@stupidchicken.com>
11903
11904 * xselect.c (x_clipboard_manager_save_frame)
11905 (x_clipboard_manager_save_all): New functions.
11906 (Fx_clipboard_manager_save): Lisp function deleted.
11907
11908 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11909 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11910
11911 * xterm.h: Update prototype.
11912
5ba6571d
WX
119132011-05-28 William Xu <william.xwl@gmail.com>
11914
11915 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11916 exiting (Bug#8239).
11917
3eaff834
JM
119182011-05-28 Jim Meyering <meyering@redhat.com>
11919
e1900994 11920 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11921 * fns.c (to_uchar): Define.
11922 (crypto_hash_function): Use it to convert some newly-signed
11923 variables to unsigned, to avoid sign-extension bugs. For example,
11924 without this change, (md5 "truc") would evaluate to
11925 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11926 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11927 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11928
0f6990a7
PE
119292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11930
11931 Integer overflow fixes.
c8a9ca5a 11932
08686060
PE
11933 * dbusbind.c: Serial number integer overflow fixes.
11934 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11935 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11936 to hold a serial number that is too large for a fixnum.
11937 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11938 Check for serial numbers out of range. Decode any serial number
59568bf0 11939 that was so large that it became a float. (Bug#8722)
08686060 11940
2d1fc3c7
PE
11941 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11943 Use XFASTINT rather than XUINT when numbers are nonnegative.
11944 (xd_append_arg, Fdbus_method_return_internal):
11945 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11946 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11947 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11948 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11949 (Bug#8722)
2d1fc3c7 11950
c8a9ca5a
PE
11951 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11952
519e1d69
PE
11953 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11954
6df6ae42 11955 ccl: Add integer overflow checks.
30569699
PE
11956 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11957 (IN_INT_RANGE): New macros.
11958 (ccl_driver): Use them to check for integer overflow when
11959 decoding a CCL program. Many of the new checks are whether XINT (x)
11960 fits in int; it doesn't always, on 64-bit hosts. The new version
11961 doesn't catch all possible integer overflows, but it's an
847044ea 11962 improvement. (Bug#8719)
30569699 11963
c11285dc
PE
11964 * alloc.c (make_event_array): Use XINT, not XUINT.
11965 There's no need for unsigned here.
11966
fdccd48e
PE
11967 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11968 This follows up to the 2011-05-06 change that substituted uintptr_t
11969 for EMACS_INT. This case wasn't caught back then.
11970
37910ab2
PE
11971 Rework Fformat to avoid integer overflow issues.
11972 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11973 now (part of C89). Include <verify.h>.
11974 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11975 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11976 (Fformat): Avoid the prepass trying to compute sizes; it was only
11977 approximate and thus did not catch overflow reliably. Instead, walk
11978 through the format just once, formatting and computing sizes as we go,
11979 checking for integer overflow at every step, and allocating a larger
11980 buffer as needed. Keep track separately whether the format is
11981 multibyte. Keep only the most-recently calculated precision, rather
11982 than them all. Record whether each argument has been converted to
11983 string. Use EMACS_INT, not int, for byte and char and arg counts.
11984 Support field widths and precisions larger than INT_MAX. Avoid
11985 sprintf's undefined behavior with conversion specifications such as %#d
11986 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11987 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11988 formatting out-of-range floating point numbers with int
9173deec 11989 formats. (Bug#8668)
37910ab2 11990
2e6578fb
PE
11991 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11992
0ae6bdee
PE
11993 * data.c: Avoid integer truncation in expressions involving floats.
11994 * data.c: Include <intprops.h>.
11995 (arith_driver): When there's an integer overflow in an expression
11996 involving floating point, convert the integers to floating point
11997 so that the resulting value does not suffer from catastrophic
11998 integer truncation. For example, on a 64-bit host (* 4
11999 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12000 Do not rely on undefined behavior after integer overflow.
12001
de883a70
PE
12002 merge count_size_as_multibyte, parse_str_to_multibyte
12003 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12004 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12005 Check for integer overflow.
12006 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12007 since it's now a duplicate of the other. This is more of
12008 a character than a buffer op, so better that it's in character.c.
12009 * fns.c, print.c: Adjust to above changes.
12010
2ff916cb
PE
120112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12012
12013 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12014
f1b54466
PE
120152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12016
fb1ac845
PE
12017 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12018 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12019 (x_clipboard_manager_save): Now static.
12020 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12021
f1b54466
PE
12022 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12023 (crypto_hash_function): Now static.
12024 Fix pointer signedness problems. Avoid unnecessary initializations.
12025
a9f737ee
CY
120262011-05-27 Chong Yidong <cyd@stupidchicken.com>
12027
12028 * termhooks.h (Vselection_alist): Make it terminal-local.
12029
12030 * terminal.c (create_terminal): Initialize it.
12031
12032 * xselect.c: Support for clipboard managers.
12033 (Vselection_alist): Move to termhooks.h as terminal-local var.
12034 (LOCAL_SELECTION): New macro.
12035 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12036 (symbol_to_x_atom): Remove gratuitous arg.
12037 (x_handle_selection_request, lisp_data_to_selection_data)
12038 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12039 (x_own_selection, x_get_local_selection, x_convert_selection):
12040 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12041 (some_frame_on_display): Delete unused function.
12042 (Fx_own_selection_internal, Fx_get_selection_internal)
12043 (Fx_disown_selection_internal, Fx_selection_owner_p)
12044 (Fx_selection_exists_p): New optional frame arg.
12045 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12046 (x_handle_selection_clear): Don't treat other terminals with the
12047 same keyboard specially. Use the terminal-local Vselection_alist.
12048 (x_clear_frame_selections): Use Frun_hook_with_args.
12049
12050 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12051
12052 * xterm.h: Add support for those atoms.
12053
e067f0c1
CY
120542011-05-26 Chong Yidong <cyd@stupidchicken.com>
12055
12056 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12057 (converted_selections, conversion_fail_tag): New global variables.
12058 (x_selection_request_lisp_error): Free the above.
12059 (x_get_local_selection): Remove unnecessary code.
12060 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12061 of converted selections stored in converted_selections.
12062 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12063 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12064 (x_convert_selection): New function.
12065 (x_handle_selection_event): Simplify.
12066 (x_get_foreign_selection): Don't ignore incoming requests while
12067 waiting for an answer; this will fail when we implement
12068 SAVE_TARGETS, and seems unnecessary anyway.
12069 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12070 (Vx_sent_selection_functions): Doc fix.
12071
0f4aebc0
LL
120722011-05-26 Leo Liu <sdl.web@gmail.com>
12073
12074 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12075
e61124cd
YM
120762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12077
12078 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12079
12080 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12081 for fringe update if it has periodic bitmap.
ac389d0c 12082 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12083 and fringe_bitmap_periodic_p.
12084
12085 * fringe.c (get_fringe_bitmap_data): New function.
12086 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12087 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12088 row. Mark glyph row for fringe update if periodicity changed.
12089
12090 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12091 for fringe update unless it has periodic bitmap.
12092
f16d9837
KH
120932011-05-25 Kenichi Handa <handa@m17n.org>
12094
12095 * xdisp.c (get_next_display_element): Set correct it->face_id for
12096 a static composition.
12097
e1b90ef6
LL
120982011-05-24 Leo Liu <sdl.web@gmail.com>
12099
12100 * deps.mk (fns.o):
12101 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12102
12103 * fns.c (crypto_hash_function, Fsha1): New function.
12104 (Fmd5): Use crypto_hash_function.
12105 (syms_of_fns): Add Ssha1.
12106
7400048f
PE
121072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12108
12109 * gnutls.c: Remove unused macros.
12110 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12111 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12112 Remove macros that are defined and never used.
12113 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12114
abb71cf4
CY
121152011-05-22 Chong Yidong <cyd@stupidchicken.com>
12116
12117 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12118 (Fx_get_selection_internal): Minor cleanup.
12119 (Fx_own_selection_internal): Rename arguments for consistency with
12120 select.el.
12121
6307db39
PE
121222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12123
12124 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12125
f3d4e0a4
CY
121262011-05-22 Chong Yidong <cyd@stupidchicken.com>
12127
12128 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12129
4d8ade89
YM
121302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12131
12132 * dispnew.c (scrolling_window): Don't exclude the case that the
12133 last enabled row in the desired matrix touches the bottom boundary.
12134
32078c8d
GM
121352011-05-21 Glenn Morris <rgm@gnu.org>
12136
12137 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12138 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12139 and add some more files.
32078c8d 12140
7285dc67
EZ
121412011-05-20 Eli Zaretskii <eliz@gnu.org>
12142
12143 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12144 report_file_error introduced by the change from 2011-05-07.
12145
89d1bd22
PE
121462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12147
12148 * systime.h (Time): Define only if emacs is defined.
12149 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12150 where the include path doesn't have X11/X.h by default. See
12151 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12152
cd394be1 121532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12154
12155 * composite.c (find_automatic_composition): Fix previous change.
12156
b9704ad9
GM
121572011-05-20 Glenn Morris <rgm@gnu.org>
12158
12159 * lisp.mk: New file, split from Makefile.in.
12160 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12161 (shortlisp): Remove.
12162 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12163
4a720484
GM
121642011-05-19 Glenn Morris <rgm@gnu.org>
12165
12166 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12167 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12168 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12169 (lisp): Set the order to that of loadup.el.
12170 (shortlisp): Make it a copy of $lisp.
12171 (SOME_MACHINE_LISP): Remove.
12172 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12173 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12174
a28d4396
KH
121752011-05-18 Kenichi Handa <handa@m17n.org>
12176
12177 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12178 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12179 (find_automatic_composition): Mostly rewrite for efficiency.
12180
a2b1fa8e
JB
121812011-05-18 Juanma Barranquero <lekktu@gmail.com>
12182
12183 * makefile.w32-in: Update dependencies.
12184
8e1f5610
CS
121852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12186
12187 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12188 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12189
7025ee00 121902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12191
cdfa6eab
PE
12192 Fix some integer overflow issues, such as string length overflow.
12193
06d6db33
PE
12194 * insdel.c (count_size_as_multibyte): Check for string overflow.
12195
2b4560a8
PE
12196 * character.c (lisp_string_width): Check for string overflow.
12197 Use EMACS_INT, not int, for string indexes and lengths; in
12198 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12199 the resulting string length overflows an EMACS_INT; instead,
12200 report a string overflow if no precision given. When checking for
12201 precision exhaustion, use a check that cannot possibly have
12202 integer overflow. (Bug#8675)
12203 * character.h (lisp_string_width): Adjust to new signature.
12204
cb93f9be
PE
12205 * alloc.c (string_overflow): New function.
12206 (Fmake_string): Use it. This doesn't change behavior, but saves
12207 a few bytes and will simplify future changes.
12208 * character.c (string_escape_byte8): Likewise.
12209 * lisp.h (string_overflow): New decl.
12210
1a1f3366
PE
12211 Fixups, following up to the user-interface timestamp change.
12212 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12213 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12214 * msdos.c (mouse_get_pos): Likewise.
12215 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12216 * w32gui.h (Time): Define by including "systime.h" rather than by
12217 declaring it ourselves. (Bug#8664)
12218
d4e3e4d3
PE
12219 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12220 * image.c (clear_image_cache): Likewise.
12221
f6a24d19
PE
12222 * term.c (term_mouse_position): Don't assume time_t wraparound.
12223
08dc5ae6
PE
12224 Be more systematic about user-interface timestamps.
12225 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12226 and sometimes 'EMACS_UINT', to represent these timestamps.
12227 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12228 This makes the code easier to follow, and makes it easier to catch
12229 integer overflow bugs such as Bug#8664.
12230 * frame.c (Fmouse_position, Fmouse_pixel_position):
12231 Use Time, not unsigned long, for user-interface timestamps.
12232 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12233 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12234 * keyboard.h (last_event_timestamp): Likewise.
12235 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12236 * menu.h (xmenu_show): Likewise.
12237 * term.c (term_mouse_position): Likewise.
12238 * termhooks.h (struct input_event.timestamp): Likewise.
12239 (struct terminal.mouse_position_hook): Likewise.
12240 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12241 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12242 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12243 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12244 what it was before.
12245 * menu.h, termhooks.h: Include "systime.h", for Time.
12246
8e55734a
PE
12247 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12248 Don't assume that the difference between two unsigned long values
12249 can fit into an integer. At this point, we know button_down_time
12250 <= event->timestamp, so the difference must be nonnegative, so
12251 there's no need to cast the result if double-click-time is
12252 nonnegative, as it should be; check that it's nonnegative, just in
12253 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12254 apart (about 25 days). (Bug#8664)
8e55734a 12255
841f1b75 12256 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12257 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12258
3e26f69c
PE
12259 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12260 that always fit in int. Use a sentinel instead of a counter, to
12261 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12262 * frame.h (struct frame): Use int for menu_bar_items_used
12263 instead of EMACS_INT, since it always fits in int.
3e26f69c 12264
5cc152c0
PE
12265 * menu.c (grow_menu_items): Check for int overflow.
12266
d89eb65e
PE
12267 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12268
5235bd3e
PE
12269 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12270 Before, the code was not consistent. These values cannot exceed
12271 2**31 - 1 so there's no need to make them unsigned.
12272 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12273 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12274 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12275 as modifiers.
12276 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12277
bc827e23
PE
12278 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12279 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12280 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12281 presumably because the widths might not match.
12282
78eb494e
PE
12283 * window.c (size_window): Avoid needless test at loop start.
12284
04f2d78b
CB
122852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12286
12287 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12288
d2fc7e3d 122892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12290
12291 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12292
d2fc7e3d 122932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12294
12295 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12296 `width' to `bar_area_x' and `bar_area_width', respectively.
12297 (x_scroll_run): Take account of fringe background extension.
12298
04f2d78b
CB
12299 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12300 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12301 `bar_area_width', respectively.
12302 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12303 background extension.
12304
79b70037
GM
123052011-05-10 Jim Meyering <meyering@redhat.com>
12306
12307 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12308
2f142cc5
JB
123092011-05-10 Juanma Barranquero <lekktu@gmail.com>
12310
12311 * image.c (Finit_image_library): Return t for built-in image types,
12312 like pbm and xbm. (Bug#8640)
12313
57679c86
AS
123142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12315
12316 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12317
888c9e86
EZ
123182011-05-07 Eli Zaretskii <eliz@gnu.org>
12319
b0512a1d
EZ
12320 * w32console.c (Fset_screen_color): Doc fix.
12321 (Fget_screen_color): New function.
12322 (syms_of_ntterm): Defsubr it.
12323
7285dc67
EZ
12324 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12325 unlink the temporary file if Fcall_process didn't create it in the
12326 first place.
12327 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12328 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12329 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12330 cue to call_process_cleanup not to close that handle.
12331
4d3fcc8e
BK
123322011-05-07 Ben Key <bkey76@gmail.com>
12333
12334 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12335 one of two shell specific rules, either bootstrap-temacs-CMD or
12336 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12337 to the previous implementation of the bootstrap-temacs rule.
12338 The bootstrap-temacs-CMD rule is similar to the previous
12339 implementation of the bootstrap-temacs rule except that it
12340 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12341 variable.
12342
12343 These changes, along with some changes to nt/configure.bat,
12344 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12345 earlier fix to add support for --cflags and --ldflags options
12346 that include quotes so that it works whether make uses cmd or
12347 sh as the shell.
12348
b4289b64
MA
123492011-05-06 Michael Albinus <michael.albinus@gmx.de>
12350
12351 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12352 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12353 is a constant.
12354 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12355 a string. Handle both cases.
12356 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12357 (Fdbus_register_method): Use Qinvalid_function.
12358
af4c0e28
JB
123592011-05-06 Juanma Barranquero <lekktu@gmail.com>
12360
12361 * makefile.w32-in: Update dependencies.
12362 (LISP_H): Add inttypes.h and stdin.h.
12363 (PROCESS_H): Add unistd.h.
12364
c51453d9
EZ
123652011-05-06 Eli Zaretskii <eliz@gnu.org>
12366
12367 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12368 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12369
8ff0ac3c 123702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12371
4c4b566b
PE
12372 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12373
aab2b9b5
PE
12374 * term.c (vfatal): Remove stray call to va_end.
12375 It's not needed and the C Standard doesn't allow it here anyway.
12376
c378da0b
PE
12377 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12378 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12379
288b08c7
PE
12380 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12381 bytes.
12382
e3601888
PE
12383 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12384
db6c0e74
PE
12385 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12386
dd5963ea
PE
12387 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12388
88c9450f
PE
12389 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12390
2f9442b8
PE
12391 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12392
c032b5f8
PE
12393 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12394 * charset.c (Fdefine_charset_internal): Don't initialize
12395 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12396 32-bit int (Bug#8600).
a108c10b
PE
12397
12398 * lread.c (read_integer): Be more consistent with string-to-number.
12399 Use string_to_number to do the actual conversion; this avoids
12400 rounding errors and fixes some other screwups. Without this fix,
12401 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12402 (digit_to_number): Move earlier, for benefit of read_integer.
12403 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12404 not a digit in any supported base. (Bug#8602)
a108c10b 12405
ad5f9eea
PE
12406 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12407
aec1708a
PE
12408 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12409 to match comment at start of function. This also removes a
12410 GCC warning about overflow in a 32+64-bit port.
12411
47be4ab5
PE
12412 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12413
371cac43
PE
12414 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12415 Reported by Stefan Monnier in
12416 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12417 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12418 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12419
d01a7826
PE
12420 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12421 (EMACS_UINTPTR): Likewise, with uintptr_t.
12422
7fd47d5c
PE
12423 * lisp.h: Prefer 64-bit EMACS_INT if available.
12424 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12425 on 32-bit hosts that have 64-bit int, so that they can access
12426 large files.
122b0c86
PE
12427 However, temporarily disable this change unless the temporary
12428 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12429
8727937b
PE
12430 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12431
8ac068ac
PE
12432 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12433 This removes an assumption that EMACS_INT and long are the same
12434 width as pointers. The assumption is true for Emacs porting targets
12435 now, but we want to make other targets possible.
12436 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12437 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12438 In the rest of the code, change types of integers that hold casted
12439 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12440 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12441 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12442 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12443 No need to cast type when ORing.
12444 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12445 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12446 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12447 assume EMACS_INT is the same width as char *.
12448 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12449 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12450 Remove no-longer-needed casts.
12451 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12452 (xg_tool_bar_help_callback, xg_make_tool_item):
12453 Use EMACS_INTPTR to hold an integer
12454 that will be cast to void *; this can avoid a GCC warning
12455 if EMACS_INT is not the same width as void *.
12456 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12457 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12458 (current_message_1, set_message_1):
12459 Use a local to convert to proper width without a cast.
12460 * xmenu.c (dialog_selection_callback): Likewise.
12461
ede49d71
PE
12462 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12463 Also, don't assume VALBITS / RAND_BITS is less than 5,
12464 and don't rely on undefined behavior when shifting a 1 left into
12465 the sign bit.
12466 * lisp.h (get_random): Change signature to match.
12467
2f30ecd0
PE
12468 * lread.c (hash_string): Use size_t, not int, for hash computation.
12469 Normally we prefer signed values; but hashing is special, because
12470 it's better to use unsigned division on hash table sizes so that
12471 the remainder is nonnegative. Also, size_t is the natural width
12472 for hashing into memory. The previous code used 'int', which doesn't
12473 retain enough info to hash well into very large tables.
12474 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12475
2a866e7b
PE
12476 * dbusbind.c: Don't possibly lose pointer info when converting.
12477 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12478 Use XPNTR rather than XHASH, so that the high-order bits of
12479 the pointer aren't lost when converting through void *.
12480
51639eac
PE
12481 * eval.c (Fautoload): Don't double-shift a pointer.
12482
92394119
PE
12483 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12484
dbdb9a7c
JB
124852011-05-06 Juanma Barranquero <lekktu@gmail.com>
12486
12487 * gnutls.c (DEF_GNUTLS_FN):
12488 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12489
db7a0b4f
AS
124902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12491
12492 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12493 marker. (Bug#8610)
12494
cd394be1 124952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12496
12497 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12498 New version that can reserve upto 2GB of heap space.
12499
f7ff1b0f 125002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12501
12502 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12503
639c109b
TZ
125042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12505
12506 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12507 `gnutls_certificate_set_x509_key_file'.
12508
d2127135
JB
125092011-05-05 Juanma Barranquero <lekktu@gmail.com>
12510
12511 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12512 Update dependencies.
12513
e968f4f3
JB
125142011-05-04 Juanma Barranquero <lekktu@gmail.com>
12515
12516 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12517 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12518 Remove unused parameter `fildes'.
12519 * process.c (read_process_output, send_process): Don't pass it.
12520
84d358f0
JB
125212011-05-04 Juanma Barranquero <lekktu@gmail.com>
12522
12523 Fix previous change: the library cache is defined in w32.c.
12524 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12525 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12526
0898ca10
JB
125272011-05-04 Juanma Barranquero <lekktu@gmail.com>
12528
12529 Implement dynamic loading of GnuTLS on Windows.
12530
12531 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12532 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12533 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12534 Declare.
12535
12536 * gnutls.c (Qgnutls_dll): Define.
12537 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12538 (gnutls_*): Declare function pointers.
12539 (init_gnutls_functions): New function to initialize function pointers.
12540 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12541 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12542 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12543 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12544 (emacs_gnutls_write, emacs_gnutls_read)
12545 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12546 (Fgnutls_available_p): New function.
12547 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12548 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12549 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12550
12551 * image.c: Include w32.h.
12552 (Vimage_type_cache): Delete.
12553 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12554 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12555 (w32_delayed_load): Move to w32.c.
12556
12557 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12558
12559 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12560 (w32_delayed_load): Move from image.c. When loading a library, record
12561 its filename in the :loaded-from property of the library id.
12562 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12563 Initialize and staticpro them.
12564 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12565
12566 * process.c: Include lisp.h before w32.h, not after.
12567 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12568 instead of gnutls_record_check_pending.
12569
12570 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12571
ff4de4aa
TZ
125722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12573
12574 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12575 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12576 as passed in.
12577
abe95abb
JD
125782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12579
12580 * xterm.c (x_set_frame_alpha): Do not set property on anything
12581 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12582
e16e55d4
JB
125832011-05-02 Juanma Barranquero <lekktu@gmail.com>
12584
12585 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12586
bafcf6a5
JB
125872011-05-02 Juanma Barranquero <lekktu@gmail.com>
12588
12589 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12590 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12591 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12592 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12593 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12594 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12595 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12596 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12597 (Qgnutls_bootprop_callbacks_verify): Make static.
12598
e7a6747f
AS
125992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12600
19ed11ba
AS
12601 * callproc.c: Indentation fixup.
12602
e7a6747f 12603 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12604 (wait_for_termination, interruptible_wait_for_termination):
12605 Move after wait_for_termination_1.
e7a6747f 12606
1ef14cb4
LMI
126072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12608
12609 * sysdep.c (interruptible_wait_for_termination): New function
12610 which is like wait_for_termination, but allows keyboard
12611 interruptions.
12612
12613 * callproc.c (Fcall_process): Add (:file "file") as an option for
12614 the STDOUT buffer.
12615 (Fcall_process_region): Ditto.
12616
330d880c
EZ
126172011-04-30 Eli Zaretskii <eliz@gnu.org>
12618
8db90b73
EZ
12619 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12620 rather than `XVECTOR (FOO)->size'.
12621
330d880c
EZ
12622 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12623 inttypes.h, as a gnulib replacement is used if it not available in
12624 system headers.
12625
15cbd324
EZ
126262011-04-21 Eli Zaretskii <eliz@gnu.org>
12627
12628 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12629 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12630 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12631
12632 * coding.c (coding_alloc_by_realloc): Error out if destination
12633 will grow beyond MOST_POSITIVE_FIXNUM.
12634 (decode_coding_emacs_mule): Abort if there isn't enough place in
12635 charbuf for the composition carryover bytes. Reserve an extra
12636 space for up to 2 characters produced in a loop.
12637 (decode_coding_iso_2022): Abort if there isn't enough place in
12638 charbuf for the composition carryover bytes.
12639
126402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12641
ae940cca
EZ
12642 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12643 aborting when %lld or %lll format is passed.
12644 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12645 %llo or %llx format is passed. (Bug#8545)
12646
03ab8921
EZ
12647 * window.c (window_scroll_line_based): Use a marker instead of
12648 simple variables to record original value of point. (Bug#7952)
12649
afda1437
EZ
12650 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12651 produced by %s or %c overflows available buffer space. (Bug#8545)
12652
f76dee0c
PE
126532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12654
12655 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12656 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12657
fdc5744d
JB
126582011-04-28 Juanma Barranquero <lekktu@gmail.com>
12659
12660 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12661
638f053a
JB
126622011-04-28 Juanma Barranquero <lekktu@gmail.com>
12663
12664 * keyboard.c (Qdelayed_warnings_hook): Define.
12665 (command_loop_1): Run `delayed-warnings-hook'
12666 if Vdelayed_warnings_list is non-nil.
12667 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12668 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12669
d178f871
EZ
126702011-04-28 Eli Zaretskii <eliz@gnu.org>
12671
12672 * doprnt.c (doprnt): Don't return value smaller than the buffer
12673 size if the message was truncated. (Bug#8545).
12674
b124fd93
JB
126752011-04-28 Juanma Barranquero <lekktu@gmail.com>
12676
12677 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12678 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12679
e810457d
PE
126802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12681
12682 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12683
ea51cceb
JB
126842011-04-27 Juanma Barranquero <lekktu@gmail.com>
12685
12686 * makefile.w32-in: Update dependencies.
12687
94dcfacf
EZ
126882011-04-27 Eli Zaretskii <eliz@gnu.org>
12689
12690 Improve `doprnt' and its usage. (Bug#8545)
12691 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12692 `format_end'. Remove support for %l as a conversion specifier.
12693 Don't use xrealloc. Improve diagnostics when the %l size modifier
12694 is used. Update the commentary.
12695
12696 * eval.c (verror): Simplify calculation of size_t.
12697
12698 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12699 messages.
12700
f61f41d7
PE
127012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12702
12703 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12704 change.
12705
96fb4434
PE
127062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12707
12708 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12709 This makes this file independent of the recent pseudovector change.
12710
671875da 127112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12712
69e9b5a3
PE
12713 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12714
b5f869a7 12715 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12716 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12717 Remove unused local.
c8926152 12718 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12719
841a1577 12720 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12721 GCC 4.6.0 optimizes based on type-based alias analysis.
12722 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12723 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12724 != &v->size, and therefore "v->size = 1; b->size = 2; return
12725 v->size;" must therefore return 1. This assumption is incorrect
12726 for Emacs, since it type-puns struct Lisp_Vector * with many other
12727 types. To fix this problem, this patch adds a new type struct
f904488f 12728 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12729 and pseudovectors, and helps optimizing compilers not get fooled
12730 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12731 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12732 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12733 the size member.
eab3844f
PE
12734 (XSETPVECTYPE): Rewrite in terms of new macro.
12735 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12736 This is a bit clearer, and further avoids the possibility of
12737 undesirable aliasing.
12738 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12739 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12740 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12741 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12742 (ASIZE): Now uses header.size rather than size.
12743 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12744 to avoid the hassle of writing XVECTOR (foo)->header.size.
12745 (struct vectorlike_header): New type.
eab3844f
PE
12746 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12747 object, to help avoid aliasing.
12748 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12749 (SUBRP): Likewise, since Lisp_Subr is a special case.
12750 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12751 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12752 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12753 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12754 changed to be "header.size" and "header.next".
12755 * buffer.h (struct buffer): Likewise.
12756 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12757 * frame.h (struct frame): Likewise.
12758 * process.h (struct Lisp_Process): Likewise.
12759 * termhooks.h (struct terminal): Likewise.
12760 * window.c (struct save_window_data, struct saved_window): Likewise.
12761 * window.h (struct window): Likewise.
12762 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12763 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12764 * buffer.c (init_buffer_once): Likewise.
12765 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12766 special case.
12767 * process.c (Fformat_network_address): Use local var for size,
12768 for brevity.
12769
0df1eac5
PE
12770 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12771
847ab9d1 12772 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12773 * data.c (atof): Remove decl; no longer used or needed.
12774 (digit_to_number): Move to lread.c.
12775 (Fstring_to_number): Use new string_to_number function, to be
12776 consistent with how the Lisp reader treats infinities and NaNs.
12777 Do not assume that floating-point numbers represent EMACS_INT
12778 without losing information; this is not true on most 64-bit hosts.
12779 Avoid double-rounding errors, by insisting on integers when
12780 parsing non-base-10 numbers, as the documentation specifies.
12781 * lisp.h (string_to_number): New decl, replacing ...
12782 (isfloat_string): Remove.
bc0a5c13 12783 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12784 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12785 appears to have been a coding error. Similarly, do not accept
12786 strings like +-1e0 as floating point numbers. Do not report
12787 overflow for integer overflows unless the base is not 10 which
12788 means we have no simple and reliable way to continue.
12789 Break out the floating-point parsing into a new
12790 function string_to_number, so that Fstring_to_number parses
12791 floating point numbers consistently with the Lisp reader.
04f2d78b 12792 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12793 (E_CHAR, EXP_INT): Remove, replacing with ...
12794 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12795 (string_to_number): New function, replacing isfloat_string.
12796 This function checks for valid syntax and produces the resulting
12797 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12798 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12799 so that overflow for non-base-10 numbers is reported only when
12800 there's no portable and simple way to convert to floating point.
452f4150 12801
67769ffc
PE
12802 * textprop.c (set_text_properties_1): Rewrite for clarity,
12803 and to avoid GCC warning about integer overflow.
12804
c20db43f
PE
12805 * intervals.h (struct interval): Use EMACS_INT for members
12806 where EMACS_UINT might cause problems. See
12807 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12808 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12809 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12810 All uses changed.
37aa2f85
PE
12811 (offset_intervals): Tell GCC not to worry about length overflow
12812 when negating a negative length.
c20db43f 12813
2538aa2f
PE
12814 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12815 (overrun_check_free): Likewise.
12816
f2d3008d
PE
12817 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12818 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12819 word size.
12820
ec8df744
PE
12821 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12822 (gnutls_make_error): Rename local to avoid shadowing.
12823 (gnutls_emacs_global_deinit): ifdef out; not used.
12824 (Fgnutls_boot): Use const for pointer to readonly storage.
12825 Comment out unused local. Fix pointer signedness problems.
12826
640ee02d
PE
12827 * lread.c (openp): Don't stuff size_t into an 'int'.
12828 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12829 about possible signed overflow.
12830
6048fb2a
PE
12831 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12832 (GDK_KEY_g): Don't define if already defined.
12833 (xg_prepare_tooltip): Avoid pointer signedness problem.
12834 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12835
fa3c87e1
PE
12836 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12837 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12838
2172544b
PE
12839 * xfns.c (Fx_window_property): Simplify a bit,
12840 to make a bit faster and to avoid GCC 4.6.0 warning.
12841 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12842
9b821a21
PE
12843 * fns.c (internal_equal): Don't assume size_t fits in int.
12844
3c616cfa
PE
12845 * alloc.c (compact_small_strings): Tighten assertion a little.
12846
c2982e87
PE
12847 Replace pEd with more-general pI, and fix some printf arg casts.
12848 * lisp.h (pI): New macro, generalizing old pEd macro to other
12849 conversion specifiers. For example, use "...%"pI"d..." rather
12850 than "...%"pEd"...".
12851 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12852 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12853 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12854 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12855 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12856 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12857 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12858 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12859 64-bit hosts.
12860 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12861 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12862 * print.c (safe_debug_print, print_object): Likewise.
12863 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12864 to int.
6f04d126
PE
12865 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12866 avoiding the 0 flag, which is not portable.
c2982e87
PE
12867 * process.c (Fmake_network_process): Use pI to avoid cast.
12868 * region-cache.c (pp_cache): Likewise.
12869 * xdisp.c (decode_mode_spec): Likewise.
12870 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12871 behavior on 64-bit hosts with printf arg.
6f04d126 12872 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12873 (x_stop_queuing_selection_requests): Likewise.
12874 (x_get_window_property): Don't truncate byte count to an 'int'
12875 when tracing.
0b432f21 12876
5e073ec7
PE
12877 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12878 here, since it parses constructs like leading '-' and spaces,
12879 which are not wanted; and it overflows with large numbers.
12880 Instead, simply match F[0-9]+, which is what is wanted anyway.
12881
36372bf9
PE
12882 * alloc.c: Remove unportable assumptions about struct layout.
12883 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12884 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12885 (allocate_vectorlike, make_pure_vector): Use the new macros,
12886 plus offsetof, to remove unportable assumptions about struct layout.
12887 These assumptions hold on all porting targets that I know of, but
12888 they are not guaranteed, they're easy to remove, and removing them
12889 makes further changes easier.
12890
0b432f21
PE
12891 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12892 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12893 (string_overrun_cookie): Now const. Use initializers that
12894 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12895 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12896 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12897 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12898 multiple of sizeof (EMACS_INT); it need not be, if
12899 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12900 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12901
895009e1
JB
129022011-04-26 Juanma Barranquero <lekktu@gmail.com>
12903
12904 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12905
6a7a1b0b
TZ
129062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12907
12908 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12909 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12910 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12911
841a1577 129122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12913
12914 * lisp.h (Qdebug): List symbol.
895009e1 12915 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12916 * keyboard.c (debug-on-event): New variable.
12917 (handle_user_signal): Break into debugger when debug-on-event
12918 matches the current signal symbol.
12919
f2d3ba6f
DN
129202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12921
12922 * alloc.c (check_sblock, check_string_bytes)
12923 (check_string_free_list): Convert to standard C.
12924
42ce4c63
TZ
129252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12926
12927 * w32.c (emacs_gnutls_push): Fix typo.
12928
825cd63c
EZ
129292011-04-25 Eli Zaretskii <eliz@gnu.org>
12930
fb11d64d
EZ
12931 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12932 "cast to pointer from integer of different size".
12933
825cd63c
EZ
12934 Improve doprnt and its use in verror. (Bug#8545)
12935 * doprnt.c (doprnt): Document the set of format control sequences
12936 supported by the function. Use SAFE_ALLOCA instead of always
12937 using `alloca'.
12938
12939 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12940 is one byte too soon. Don't use xrealloc; instead xfree and
12941 xmalloc anew.
12942
e061a11b
TZ
129432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12944
12945 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12946 callbacks stage.
12947
12948 * gnutls.c: Renamed global_initialized to
12949 gnutls_global_initialized. Added internals for the
12950 :verify-hostname-error, :verify-error, and :verify-flags
12951 parameters of `gnutls-boot' and documented those parameters in the
12952 docstring. Start callback support.
9173deec
JB
12953 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12954 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12955 on error. Return error code.
e061a11b
TZ
12956 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12957 (emacs_gnutls_read): Likewise.
12958 (Fgnutls_boot): Return handshake error code.
12959 (emacs_gnutls_handle_error): New function.
12960 (wsaerror_to_errno): Likewise.
12961
12962 * w32.h (emacs_gnutls_pull): Add prototype.
12963 (emacs_gnutls_push): Likewise.
12964
12965 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12966 (emacs_gnutls_push): Likewise.
12967
129682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12969
12970 * process.c (wait_reading_process_output): Check if GnuTLS
12971 buffered some data internally if no FDs are set for TLS
12972 connections.
12973
12974 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12975 (LIBS): Link to USER_LIBS.
12976 ($(BLD)/gnutls.$(0)): New target.
12977
fa6996bc
EZ
129782011-04-24 Eli Zaretskii <eliz@gnu.org>
12979
eb35682e
EZ
12980 * xdisp.c (handle_single_display_spec): Rename the
12981 display_replaced_before_p argument into display_replaced_p, to
12982 make it consistent with the commentary. Fix typos in the
12983 commentary.
12984
e2ad650c
EZ
12985 * textprop.c (syms_of_textprop): Remove dead code.
12986 (copy_text_properties): Delete obsolete commentary about an
12987 interface that was deleted long ago. Fix typos in the description
12988 of arguments.
12989
1b2de274
EZ
12990 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12991 to changes in oldXMenu/XMenu.h from 2011-04-16.
12992 <menu_help_message, prev_menu_help_message>: Constify.
12993 (IT_menu_make_room): menu->help_text is now `const char **';
12994 adjust.
12995
12996 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12997 to changes in oldXMenu/XMenu.h from 2011-04-16.
12998 (struct XMenu): Declare `help_text' `const char **'.
12999
13000 * xfaces.c <Qunspecified>: Make extern again.
13001
13002 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13003 required by POSIX.
1b2de274 13004
762b15be
EZ
13005 * doc.c (get_doc_string): Improve the format passed to `error'.
13006
13007 * doprnt.c (doprnt): Improve commentary.
13008
13009 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13010
13011 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13012 them with etags.
13013
f1052e5d
EZ
13014 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13015 changes in globals.h immediately force recompilation.
762b15be
EZ
13016 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13017 $(CURDIR)/s/ms-w32.h.
13018 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13019
fa6996bc
EZ
13020 * character.c (Fchar_direction): Function deleted.
13021 (syms_of_character): Don't defsubr it.
13022 <char-direction-table>: Deleted.
13023
e6c3da20
EZ
130242011-04-23 Eli Zaretskii <eliz@gnu.org>
13025
13026 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13027 * doprnt.c: Include limits.h.
13028 (SIZE_MAX): New macro.
04f2d78b
CB
13029 (doprnt): Return a size_t value. 2nd arg is now size_t.
13030 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13031 Improve overflow protection. Support `l' modifier for integer
13032 conversions. Support %l conversion. Don't assume an EMACS_INT
13033 argument for integer conversions and for %c.
13034
13035 * lisp.h (doprnt): Restore prototype.
13036
13037 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13038 $(SRC)/character.h.
13039
13040 * Makefile.in (base_obj): Add back doprnt.o.
13041
13042 * deps.mk (doprnt.o): Add back prerequisites.
13043 (callint.o): Depend on character.h.
13044
13045 * eval.c (internal_lisp_condition_case): Include the handler
13046 representation in the error message.
13047 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13048 when breaking from the loop.
13049
13050 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13051
13052 * callint.c (Fcall_interactively): When displaying error message
13053 about invalid control letter, pass the character's codepoint, not
13054 a pointer to its multibyte form. Improve display of the character
13055 in octal and display also its hex code.
13056
13057 * character.c (char_string): Use %x to display the (unsigned)
13058 codepoint of an invalid character, to avoid displaying a bogus
13059 negative value.
13060
13061 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13062 `error', not SYMBOL_NAME itself.
13063
13064 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13065 character arguments to `error'.
13066
13067 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13068 to `error' in error message about FINAL_CHAR argument. Make sure
13069 FINAL_CHAR is a character, and use %c when it is passed as
13070 argument to `error'.
13071
4ffd0d6b 130722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13073
13074 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13075
13076 * w32.c: Include <time.h>.
13077 (sys_localtime): New function.
13078
4ffd0d6b 130792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13080
13081 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13082
4ffd0d6b 13083 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13084
4ffd0d6b 130852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13086
4ffd0d6b
GM
13087 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13088 zombies (Bug#8467).
aac0c6e3 13089
04c56954
EZ
130902011-04-19 Eli Zaretskii <eliz@gnu.org>
13091
13092 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13093 gl_state.e_property when gl_state.object is Qt.
13094
13095 * insdel.c (make_gap_larger): Remove limitation of buffer size
13096 to <= INT_MAX.
13097
16a43933
CY
130982011-04-18 Chong Yidong <cyd@stupidchicken.com>
13099
13100 * xdisp.c (lookup_glyphless_char_display)
13101 (produce_glyphless_glyph): Handle cons cell entry in
13102 glyphless-char-display.
13103 (Vglyphless_char_display): Document it.
13104
13105 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13106 glyphless-char-display.
13107
4581706e
CY
131082011-04-17 Chong Yidong <cyd@stupidchicken.com>
13109
13110 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13111
13112 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13113
13114 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13115 definition for no-X builds.
13116
4887c6e2 131172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13118
fd35b6f9
PE
13119 Static checks with GCC 4.6.0 and non-default toolkits.
13120
5c1ccb01
PE
13121 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13122
006c5daa
PE
13123 * process.c (keyboard_bit_set): Define only if SIGIO.
13124 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13125 (send_process): Repair possible setjmp clobbering.
13126
efc736d3
PE
13127 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13128
4e2fe2e6
PE
13129 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13130
f97334a2
PE
13131 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13132
4e75f29d
PE
13133 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13134 Define only if needed.
13135
90efadd1
PE
13136 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13137 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13138 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13139
3c647824
PE
13140 * dispextern.h (struct redisplay_interface): Rename param
13141 to avoid shadowing.
e264f262 13142 * termhooks.h (struct terminal): Likewise.
761383f4 13143 * xterm.c (xembed_send_message): Likewise.
3c647824 13144
b58c5c4a
PE
13145 * insdel.c (make_gap_smaller): Define only if
13146 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13147
cad59032
PE
13148 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13149 it.
13150
c339dc2e
PE
13151 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13152 so that we aren't warned about unused symbols.
13153
91a3e27b
PE
13154 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13155
399c71d3 13156 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13157
8ffc96f5
PE
13158 * xfns.c (x_real_positions): Mark locals as initialized.
13159
eef9bc79
PE
13160 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13161
098db9dd
PE
13162 * xterm.c: Fix problems found by static analysis with other toolkits.
13163 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13164 (x_dispatch_event): Declare static if USE_GTK, and
13165 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13166 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13167 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13168 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13169 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13170
eb18f6cc
PE
13171 * xmenu.c (menu_help_callback): Pointer type fixes.
13172 Use const pointers when pointing at readonly data. Avoid pointer
13173 signedness clashes.
13174 (FALSE): Remove unused macro.
13175 (update_frame_menubar): Remove unused decl.
13176
1fe72bf8
PE
13177 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13178
60d9e1db
PE
13179 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13180 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13181 (single_menu_item): Rename local to avoid shadowing.
13182
39261c26
PE
13183 * keyboard.c (make_lispy_event): Remove unused local var.
13184
018c5e19
PE
13185 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13186 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13187
63d2b86e
PE
13188 * bitmaps: Change bitmaps from unsigned char back to the X11
13189 compatible char. Avoid the old compiler warnings about
13190 out-of-range initializers by using, for example, '\xab' rather
13191 than 0xab.
13192
aefd87e1
PE
13193 * xgselect.c (xgselect_initialize): Check vs interface
13194 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13195
bf501fb9
PE
13196 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13197
e9829fdf
PE
13198 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13199 to read-only memory.
13200
1086c095
PE
13201 * fns.c (vector): Remove; this old hack is no longer needed.
13202
2baccd04 13203 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13204 Remove unused var.
dde42981 13205 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13206
72391843 13207 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13208
436c16df 13209 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13210 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13211 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13212
92bb796d 13213 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13214 (x_term_init): Remove local to avoid shadowing.
92bb796d 13215
764430a3 13216 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13217
13218 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13219 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13220
d1dfb56c
EZ
132212011-04-16 Eli Zaretskii <eliz@gnu.org>
13222
c4354cb4
EZ
13223 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13224
d1dfb56c
EZ
13225 Fix regex.c, syntax.c and friends for buffers > 2GB.
13226 * syntax.h (struct gl_state_s): Declare character position members
13227 EMACS_INT.
13228
13229 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13230
04f2d78b
CB
13231 * textprop.c (verify_interval_modification, interval_of):
13232 Declare arguments EMACS_INT.
d1dfb56c
EZ
13233
13234 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13235 EMACS_INT.
13236
13237 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13238
13239 * indent.c (Fvertical_motion): Local variable it_start is now
13240 EMACS_INT.
13241
13242 * regex.c (re_match, re_match_2, re_match_2_internal)
13243 (bcmp_translate, regcomp, regexec, print_double_string)
13244 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13245 (re_compile_pattern, re_exec): Declare arguments and local
13246 variables `size_t' and `ssize_t' and return values `regoff_t', as
13247 appropriate.
13248 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13249 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13250 <compile_stack_type>: `size' and `avail' are now `size_t'.
13251
13252 * regex.h <regoff_t>: Use ssize_t, not int.
13253 (re_search, re_search_2, re_match, re_match_2): Arguments that
13254 specify buffer/string position and length are now ssize_t and
13255 size_t. Return type is regoff_t.
13256
613052cd
BK
132572011-04-16 Ben Key <bkey76@gmail.com>
13258
13259 * nsfont.m: Fixed bugs in ns_get_family and
13260 ns_descriptor_to_entity that were caused by using free to
13261 deallocate memory blocks that were allocated by xmalloc (via
13262 xstrdup). This caused Emacs to crash when compiled with
13263 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13264 --enable-checking=xmallocoverrun). xfree is now used to
13265 deallocate these memory blocks.
13266
4170f62f 132672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13268
71b41406
PE
13269 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13270
9587a89d
PE
13271 emacs_write: Accept and return EMACS_INT for sizes.
13272 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13273 et seq.
13274 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13275 Accept and return EMACS_INT.
13276 (emacs_gnutls_write): Return the number of bytes written on
13277 partial writes.
13278 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13279 (emacs_read, emacs_write): Remove check for negative size, as the
13280 Emacs source code has been audited now.
9587a89d
PE
13281 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13282 (emacs_read, emacs_write): Use it.
273a5f82
PE
13283 * process.c (send_process): Adjust to the new signatures of
13284 emacs_write and emacs_gnutls_write. Do not attempt to store
13285 a byte offset into an 'int'; it might overflow.
9587a89d 13286 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13287
3e047f51
PE
13288 * sound.c: Don't assume sizes fit in 'int'.
13289 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13290 Return EMACS_INT, not int.
3e047f51 13291 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13292 Accept EMACS_INT, not int.
13293 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13294 record read return values.
13295
cc39a9db
BK
132962011-04-15 Ben Key <bkey76@gmail.com>
13297
c9d0ec6d
JB
13298 * keyboard.c (Qundefined): Don't declare static since it is used
13299 in nsfns.m.
13300 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13301 static since they are used in nsfont.m.
cc39a9db 13302
6c60eb9f
SM
133032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13304
13305 * process.c (Qprocessp): Don't declare static.
13306 * lisp.h (Qprocessp): Declare again.
13307
7990b61a
JB
133082011-04-15 Juanma Barranquero <lekktu@gmail.com>
13309
13310 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13311
5d4cb038
PE
133122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13313
8bd7b830 13314 Improve C-level modularity by making more things 'static'.
cd64ea1d 13315
e3b27b31
PE
13316 Don't publish debugger-only interfaces to other modules.
13317 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13318 (verify_bytepos, count_markers): Move decls to the only modules
13319 that need them.
13320 * region-cache.h (pp_cache): Likewise.
13321 * window.h (check_all_windows): Likewise.
13322 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13323
5d4cb038
PE
13324 * sysdep.c (croak): Now static, if
13325 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13326 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13327
13328 * alloc.c (refill_memory_reserve): Now static if
13329 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13330 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13331
e87b6180
PE
13332 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13333 Define only if USE_LUCID.
13334
ac64929e
PE
13335 * xrdb.c (x_customization_string, x_rm_string): Now static.
13336
6f37259d
PE
13337 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13338 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13339
1683e3ab
PE
13340 * xdisp.c (draw_row_with_mouse_face): Now static.
13341 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13342
de9c2632
PE
13343 * window.h (check_all_windows): Mark externally visible.
13344
2b96acb7
PE
13345 * window.c (window_deletion_count): Now static.
13346
13347 * undo.c: Make symbols static if they're not exported.
13348 (last_undo_buffer, last_boundary_position, pending_boundary):
13349 Now static.
13350
50436f33
PE
13351 * textprop.c (interval_insert_behind_hooks): Now static.
13352 (interval_insert_in_front_hooks): Likewise.
13353
64520e5c
PE
13354 * term.c: Make symbols static if they're not exported.
13355 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13356 (max_frame_lines, tty_set_terminal_modes):
13357 (tty_reset_terminal_modes, tty_turn_off_highlight):
13358 (get_tty_terminal): Now static.
13359 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13360 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13361 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13362 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13363 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13364
1fa53021
PE
13365 * sysdep.c: Make symbols static if they're not exported.
13366 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13367 Now static.
13368 (sigprocmask_set, full_mask): Remove; unused.
13369 (wait_debugging): Mark as visible.
13370 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13371 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13372
d4b43b22
PE
13373 * syntax.c (syntax_temp): Define only if !__GNUC__.
13374
b7c513d0
PE
13375 * sound.c (current_sound_device, current_sound): Now static.
13376
989b29ad
PE
13377 * search.c (searchbufs, searchbuf_head): Now static.
13378
13a55a78
PE
13379 * scroll.c (scroll_cost): Remove; unused.
13380 * dispextern.h (scroll_cost): Remove decl.
13381
de68a1fc
PE
13382 * region-cache.h (pp_cache): Mark as externally visible.
13383
40ccffa6
PE
13384 * process.c: Make symbols static if they're not exported.
13385 (process_tick, update_tick, create_process, chan_process):
13386 (Vprocess_alist, proc_buffered_char, datagram_access):
13387 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13388 (deactivate_process): Mark defn as static, as well as decl.
13389 * lisp.h (create_process): Remove decl.
13390 * process.h (chan_process, Vprocess_alist): Remove decls.
13391
ad64fc97
PE
13392 * print.c: Make symbols static if they're not exported.
13393 (print_depth, new_backquote_output, being_printed, print_buffer):
13394 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13395 (print_interval, print_number_index, initial_stderr_stream):
13396 Now static.
13397 * lisp.h (Fprinc): Remove decl.
13398 (debug_output_compilation_hack): Mark as externally visible.
13399
adddb265
PE
13400 * sysdep.c (croak): Move decl from here to syssignal.h.
13401 * syssignal.h (croak): Put it here, so the API can be checked when
13402 'croak' is called from dissociate_if_controlling_tty.
13403
1717ede2
PE
13404 * minibuf.c: Make symbols static if they're not exported.
13405 (minibuf_save_list, choose_minibuf_frame): Now static.
13406 * lisp.h (choose_minibuf_frame): Remove decl.
13407
fa5fb2bc
PE
13408 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13409
1e3890d1
PE
13410 * lread.c: Make symbols static if they're not exported.
13411 (read_objects, initial_obarray, oblookup_last_bucket_number):
13412 Now static.
13413 (make_symbol): Remove; unused.
13414 * lisp.h (initial_obarray, make_symbol): Remove decls.
13415
8a1414fa
PE
13416 * keyboard.c: Make symbols static if they're not exported.
13417 (single_kboard, recent_keys_index, total_keys, recent_keys):
13418 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13419 (this_single_command_key_start, echoing, last_auto_save):
13420 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13421 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13422 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13423 (Vlispy_mouse_stem, double_click_count):
13424 Now static.
13425 (force_auto_save_soon): Define only if SIGDANGER.
13426 (ignore_mouse_drag_p): Now static if
13427 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13428 (print_help): Remove; unused.
13429 (stop_character, last_timer_event): Mark as externally visible.
13430 * keyboard.h (ignore_mouse_drag_p): Declare only if
13431 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13432 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13433 * lisp.h (echoing): Remove decl.
13434 (force_auto_save_soon): Declare only if SIGDANGER.
13435 * xdisp.c (redisplay_window): Simplify code, to make it more
13436 obvious that ignore_mouse_drag_p is not accessed if !defined
13437 USE_GTK && !defined HAVE_NS.
13438
93ea6e8f
PE
13439 * intervals.c: Make symbols static if they're not exported.
13440 (merge_properties_sticky, merge_interval_right, delete_interval):
13441 Now static.
13442 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13443
77382fcc
PE
13444 * insdel.c: Make symbols static if they're not exported.
13445 However, leave prepare_to_modify_buffer alone. It's never
13446 called from outside this function, but that appears to be a bug.
13447 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13448 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13449 (adjust_after_replace_noundo): Remove; unused.
13450 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13451 (signal_before_change): Remove decls.
77382fcc 13452
9306c32e
PE
13453 * indent.c (val_compute_motion, val_vmotion): Now static.
13454
cd44d2eb
PE
13455 * image.c: Make symbols static if they're not exported.
13456 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13457 if USE_GTK.
13458 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13459 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13460
ad9a7a06
PE
13461 * fringe.c (standard_bitmaps): Now static.
13462 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13463
81626931
PE
13464 * frame.c: Make symbols static if they're not exported.
13465 (x_report_frame_params, make_terminal_frame): Now static.
13466 (get_frame_param): Now static, unless HAVE_NS.
13467 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13468 (x_get_resource_string): Remove; not used.
13469 * frame.h (make_terminal_frame, x_report_frame_params):
13470 (x_get_resource_string); Remove decls.
13471 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13472 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13473
239f9db9
PE
13474 * font.c, fontset.c: Make symbols static if they're not exported.
13475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13476 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13477 * font.c (font_close_object): Now static.
13478 * font.h (font_close_object): Remove.
13479 * fontset.c (FONTSET_OBJLIST): Remove.
13480 (free_realized_fontset) #if-0 the body, which does nothing.
13481 (face_suitable_for_char_p): #if-0, as it's never called.
13482 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13483 * xfaces.c (face_at_string_position):
13484 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13485 since 0 is always ASCII.
13486
dfcf3579
PE
13487 * fns.c (weak_hash_tables): Now static.
13488
5045092b
PE
13489 * fileio.c: Make symbols static if they're not exported.
13490 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13491 (Vwrite_region_annotation_buffers): Now static.
13492
57a96f5c
PE
13493 * eval.c: Make symbols static if they're not exported.
13494 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13495 * lisp.h (backtrace_list): Remove decl.
13496
35f08c38
PE
13497 * emacs.c: Make symbols static if they're not exported.
13498 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13499 (fatal_error_code, fatal_error_signal_hook, standard_args):
13500 Now static.
13501 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13502 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13503 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13504 * lisp.h (fatal_error_signal_hook): Remove decl.
13505 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13506
f44bd759
PE
13507 * editfns.c: Move a (normally-unused) function to its only use.
13508 * editfns.c, lisp.h (get_operating_system_release): Remove.
13509 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13510 worth the hassle of breaking this out.
13511
b532497d
PE
13512 * xterm.c: Make symbols static if they're not exported.
13513 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13514 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13515 (x_destroy_window, x_delete_display):
13516 Now static.
13517 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13518 (x_mouse_leave): Remove; unused.
13519 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13520 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13521 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13522 Remove decls.
13523 (x_mouse_leave): Declare only if WINDOWSNT.
13524 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13525 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13526 USE_X_TOOLKIT.
13527
1675728f
PE
13528 * ftxfont.c: Make symbols static if they're not exported.
13529 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13530 HAVE_FREETYPE.
13531 * font.h (ftxfont_driver): Likewise.
13532
e4cebfca
PE
13533 * xfns.c: Make symbols static if they're not exported.
13534 (x_last_font_name, x_display_info_for_name):
13535 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13536 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13537 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13538 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13539 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13540 (last_show_tip_args): Now static.
13541 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13542 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13543 (x_screen_planes): Remove; unused.
13544 * dispextern.h (x_screen_planes): Remove decl.
13545
5bf46f05
PE
13546 * dispnew.c: Make symbols static if they're not exported.
13547 * dispextern.h (redraw_garbaged_frames, scrolling):
13548 (increment_row_positions): Remove.
13549 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13550 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13551 Now static.
13552 (redraw_garbaged_frames): Remove; unused.
13553
435f4c28
PE
13554 * xfaces.c: Make symbols static if they're not exported.
13555 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13556 Remove decls.
13557 * xterm.h (defined_color): Remove decls.
13558 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13559 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13560 (menu_face_changed_default, defined_color, free_realized_face):
13561 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13562 (ascii_face_of_lisp_face): Remove; unused.
13563
8524aef3
PE
13564 * xdisp.c: Make symbols static if they're not exported.
13565 * dispextern.h (scratch_glyph_row, window_box_edges):
13566 (glyph_to_pixel_coords, set_cursor_from_row):
13567 (get_next_display_element, set_iterator_to_next):
13568 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13569 (show_mouse_face): Remove decls
13570 * frame.h (message_buf_print): Likewise.
13571 * lisp.h (pop_message, set_message, check_point_in_composition):
13572 Likewise.
13573 * xterm.h (set_vertical_scroll_bar): Likewise.
13574 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13575 (message_buf_print, scratch_glyph_row, displayed_buffer):
13576 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13577 (get_next_display_element, show_mouse_face, window_box_edges):
13578 (frame_to_window_pixel_xy, check_point_in_composition):
13579 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13580 (glyph_to_pixel_coords): Remove; unused.
13581
16390cd2
PE
13582 * dired.c (file_name_completion): Now static.
13583
13584 * dbusbind.c (xd_in_read_queued_messages): Now static.
13585
a25f4dfa
PE
13586 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13587 * data.c (circular_list_error): Remove.
13588
14a9c8df
PE
13589 * commands.h (last_point_position, last_point_position_buffer):
13590 (last_point_position_window): Remove decls.
13591 * keyboard.c: Make these variables static.
13592
04f2d78b
CB
13593 * coding.h (coding, code_convert_region, encode_coding_gap):
13594 Remove decls.
74ab6df5
PE
13595 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13596 (iso_code_class, detect_coding, code_convert_region): Now static.
13597 (encode_coding_gap): Remove; unused.
13598
38dfbee1
PE
13599 * chartab.c (chartab_chars, chartab_bits): Now static.
13600
a2cb4e63
PE
13601 * charset.h (charset_iso_8859_1): Remove decl.
13602 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13603 Now static.
13604
127198fd
PE
13605 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13606 * ccl.c (Vccl_program_table): Now static.
13607 (check_ccl_update): Remove; unused.
13608
d85b608f
PE
13609 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13610 * category.h: ... from here.
13611 * category.c (check_category_table, set_category_set): Now static.
13612
31cd66f3
PE
13613 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13614 * lisp.h: Remove these decls.
13615
c358e587
PE
13616 * buffer.c (buffer_count): Remove unused var.
13617
e78aecca
PE
13618 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13619 so that it's not optimized away.
13620 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13621 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13622 exported only to the debugger.
13623
e192d7d3 13624 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13625 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13626
92470028
PE
13627 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13628 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13629 was inaccessible from Lisp.
13630 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13631 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13632
244ed907
PE
13633 alloc.c: Import and export fewer symbols, and remove unused items.
13634 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13635 is defined.
13636 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13637 it's not optimized away by whole-program optimization.
13638 (message_enable_multibyte, free_misc): Remove.
13639 (catchlist, handlerlist, mark_backtrace):
13640 Declare only if BYTE_MARK_STACK.
13641 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13642 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13643 (message_enable_multibyte): Remove decl.
13644 (free_misc, interval_free_list, float_block, float_block_index):
13645 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13646 (cons_free_list, last_marked_index):
13647 Now static.
13648 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13649 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13650 (mark_backtrace): Define only if BYTE_MARK_STACK.
13651 * xdisp.c (message_enable_multibyte): Now static.
13652
61c2b50e 13653 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13654 This makes it easier for human readers (and static analyzers)
13655 to see whether these variables are used from other modules.
13656 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13657 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13658 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13659 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13660 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13661 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13662 * xmenu.c, xselect.c:
13663 Declare Q* vars static if they are not used in other modules.
13664 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13665 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13666 Remove decls of unexported vars.
13667 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13668
95c82688
PE
13669 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13670
16a97296
PE
13671 Make Emacs functions such as Fatom 'static' by default.
13672 This makes it easier for human readers (and static analyzers)
13673 to see whether these functions can be called from other modules.
13674 DEFUN now defines a static function. To make the function external
13675 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13676 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13677 (Finit_image_library):
16a97296
PE
13678 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13679 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13680 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13681 Remove decls, since these functions are now static.
13682 (Funintern, Fget_internal_run_time): New decls, since these functions
13683 were already external.
95c82688 13684
16a97296
PE
13685 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13686 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13687 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13688 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13689 * keyboard.c, keymap.c, lread.c:
13690 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13691 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13692 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13693 Mark functions with DEFUE instead of DEFUN,
13694 if they are used in other modules.
13695 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13696 decls for now-static functions.
13697 * buffer.h (Fdelete_overlay): Remove decl.
13698 * callproc.c (Fgetenv_internal): Mark as internal.
13699 * composite.c (Fremove_list_of_text_properties): Remove decl.
13700 (Fcomposition_get_gstring): New forward static decl.
13701 * composite.h (Fcomposite_get_gstring): Remove decl.
13702 * dired.c (Ffile_attributes): New forward static decl.
13703 * doc.c (Fdocumntation_property): New forward static decl.
13704 * eval.c (Ffetch_bytecode): New forward static decl.
13705 (Funintern): Remove extern decl; now in .h file where it belongs.
13706 * fileio.c (Fmake_symbolic_link): New forward static decl.
13707 * image.c (Finit_image_library): New forward static decl.
13708 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13709 * intervals.h (Fprevious_property_change):
13710 (Fremove_list_of_text_properties): Remove decls.
13711 * keyboard.c (Fthis_command_keys): Remove decl.
13712 (Fcommand_execute): New forward static decl.
13713 * keymap.c (Flookup_key): New forward static decl.
13714 (Fcopy_keymap): Now static.
13715 * keymap.h (Flookup_key): Remove decl.
13716 * process.c (Fget_process): New forward static decl.
13717 (Fprocess_datagram_address): Mark as internal.
13718 * syntax.c (Fsyntax_table_p): New forward static decl.
13719 (skip_chars): Remove duplicate decl.
13720 * textprop.c (Fprevious_property_change): New forward static decl.
13721 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13722 Now internal.
13723 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13724 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13725
785bbd42
PE
13726 * editfns.c (Fformat): Remove unreachable code.
13727
8b913b57
AS
137282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13729
13730 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13731 change. (Bug#8496)
13732
a6744a35
EZ
137332011-04-13 Eli Zaretskii <eliz@gnu.org>
13734
13735 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13736 when at ZV. (Bug#8487)
13737
e7974947
AS
137382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13739
baad03f0
AS
13740 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13741 (Bug#8437)
13742 * keyboard.c (parse_tool_bar_item): Likewise.
13743 * sound.c (sound_cleanup, alsa_close): Likewise.
13744 * termcap.c (tgetent): Likewise.
13745 * xfns.c (x_default_font_parameter): Likewise.
13746 * xsettings.c (read_and_apply_settings): Likewise.
13747
e7974947
AS
13748 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13749 (overrun_check_free): Protoize.
13750
28272684
PE
137512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13752
13753 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13754 since callers should never pass a negative size.
13755 Change the signature to match that of plain 'read' and 'write'; see
13756 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13757 * lisp.h: Update prototypes of emacs_write and emacs_read.
13758
11997c76
EZ
137592011-04-11 Eli Zaretskii <eliz@gnu.org>
13760
13761 * xdisp.c (redisplay_window): Don't try to determine the character
13762 position of the scroll margin if the window start point w->startp
e896f03c 13763 is outside the buffer's accessible region. (Bug#8468)
11997c76 13764
8a2cbd72
EZ
137652011-04-10 Eli Zaretskii <eliz@gnu.org>
13766
13767 Fix write-region and its subroutines for buffers > 2GB.
13768 * fileio.c (a_write, e_write): Modify declaration of arguments and
13769 local variables to support buffers larger than 2GB.
13770 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13771
13772 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13773 argument, local variables, and return value.
13774
13775 * lisp.h: Update prototypes of emacs_write and emacs_read.
13776
13777 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13778
4073e537 137792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13780
1ebfdcb6
PE
13781 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13782
b2ded58d
PE
13783 Fix more problems found by GCC 4.6.0's static checks.
13784
7d66342c
PE
13785 * xdisp.c (vmessage): Use a better test for character truncation.
13786
bbf47d44
PE
13787 * charset.c (load_charset_map): <, not <=, for optimization,
13788 and to avoid potential problems with integer overflow.
9248994d 13789 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13790 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13791 * editfns.c (Fformat): Likewise.
1e69125e 13792 * syntax.c (skip_chars): Likewise.
3befa583 13793
e3019616
PE
13794 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13795 This also lets GCC 4.6.0 generate slightly better loop code.
13796
becfa255
PE
13797 * callint.c (Fcall_interactively): <, not <=, for optimization.
13798 (Fcall_interactively): Count the number of arguments produced,
13799 not the number of arguments given. This is simpler and lets GCC
13800 4.6.0 generate slightly better code.
13801
dae0cd48
PE
13802 * ftfont.c: Distingish more carefully between FcChar8 and char.
13803 The previous code passed unsigned char * to a functions like
13804 strlen and xstrcasecmp that expect char *, which does not
13805 conform to the C standard.
13806 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13807 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13808 char * when the C standard requires it.
13809
76032d70
PE
13810 * keyboard.c (read_char): Remove unused var.
13811
eb3f1cc8
PE
13812 * eval.c: Port to Windows vsnprintf (Bug#8435).
13813 Include <limits.h>.
13814 (SIZE_MAX): Define if the headers do not.
13815 (verror): Do not give up if vsnprintf returns a negative count.
13816 Instead, grow the buffer. This ports to Windows vsnprintf, which
13817 does not conform to C99. Problem reported by Eli Zaretskii.
13818 Also, simplify the allocation scheme, by avoiding the need for
13819 calling realloc, and removing the ALLOCATED variable.
13820
70476b54
PE
13821 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13822
12020a9e
PE
13823 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13824 But keep the doprint source code for now, as we might revamp it
13825 and use it again (Bug#8435).
ea6c7ae6
PE
13826 * lisp.h (doprnt): Remove.
13827 * Makefile.in (base_obj): Remove doprnt.o.
13828 * deps.mk (doprnt.o): Remove.
13829
5fdb398c
PE
13830 error: Print 32- and 64-bit integers portably (Bug#8435).
13831 Without this change, on typical 64-bit hosts error ("...%d...", N)
13832 was used to print both 32- and 64-bit integers N, which relied on
13833 undefined behavior.
61bdb816 13834 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13835 * lisp.h (error, verror): Mark as printf-like functions.
13836 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13837 Report overflow in size calculations when allocating printf buffer.
13838 Do not truncate output string at its first null byte.
13839 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13840 Truncate the output at a character boundary, since vsnprintf does not
13841 do that.
13842 * charset.c (check_iso_charset_parameter): Convert internal
13843 character to string before calling 'error', since %c now has the
13844 printf meaning.
13845 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13846 overflow when computing char to be passed to 'error'. Do not
13847 pass Lisp_Object to 'error'; pass the integer instead.
13848 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13849 formatted with plain %d.
13850
b189fa66
PE
13851 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13852
bff87ef0
PE
13853 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13854
7e2cac20
PE
13855 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13856
ce4d90b5
PE
13857 * xterm.c (x_catch_errors): Remove duplicate declaration.
13858
266c9547
PE
13859 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13860
79c49ad2
PE
13861 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13862
368f4090
JM
138632011-04-10 Jim Meyering <meyering@redhat.com>
13864
13865 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13866 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13867 return ssize_t not "int", and use size_t as the buffer length.
13868 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13869 * gnutls.h: Update declarations.
13870 * process.c (read_process_output): Use ssize_t, to match.
13871 (send_process): Likewise.
13872
a32d4040
CY
138732011-04-09 Chong Yidong <cyd@stupidchicken.com>
13874
13875 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13876
8546720e 138772011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13878
04f2d78b
CB
13879 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13880 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13881
8546720e
GM
13882 * xterm.c (handle_one_xevent):
13883 * xmenu.c (create_and_show_popup_menu):
13884 * xselect.c (x_decline_selection_request)
13885 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13886
0a2f5c1a 138872011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13888
13889 Fix some uses of `int' instead of EMACS_INT.
13890 * search.c (string_match_1, fast_string_match)
13891 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13892 (scan_buffer, find_next_newline_no_quit)
13893 (find_before_next_newline, search_command, Freplace_match)
13894 (Fmatch_data): Make some `int' variables be EMACS_INT.
13895
13896 * xdisp.c (display_count_lines): 3rd argument and return value now
13897 EMACS_INT. All callers changed.
13898 (pint2hrstr): Last argument is now EMACS_INT.
13899
13900 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13901 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13902 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13903 (decode_coding_utf_16, decode_coding_emacs_mule)
13904 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13905 (decode_coding_ccl, decode_coding_charset)
13906 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13907 (decode_coding_iso_2022, decode_coding_emacs_mule)
13908 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13909 <char_offset, last_offset>: Declare EMACS_INT.
13910 (encode_coding_utf_8, encode_coding_utf_16)
13911 (encode_coding_emacs_mule, encode_invocation_designation)
13912 (encode_designation_at_bol, encode_coding_iso_2022)
13913 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13914 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13915 Declare EMACS_INT.
13916 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13917 (encode_invocation_designation): Last argument P_NCHARS is now
13918 EMACS_INT.
13919 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13920 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13921
13922 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13923 All users changed.
13924
13925 * ccl.c (Fccl_execute_on_string): Declare some variables
13926 EMACS_INT.
13927
8546720e 139282011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13929
13930 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13931
4e19a977
CS
139322011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13933
13934 * process.c (Fformat_network_address): Doc fix.
13935
87302331
R
139362011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13937
ee7683eb 13938 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13939
cbb59342
CY
139402011-04-08 Chong Yidong <cyd@stupidchicken.com>
13941
13942 * keyboard.c (read_char): Call Lisp function help-form-show,
13943 instead of using internal_with_output_to_temp_buffer.
13944 (Qhelp_form_show): New var.
e0d38eeb 13945 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13946
13947 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13948
13949 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13950
e67a13ab
CY
139512011-04-06 Chong Yidong <cyd@stupidchicken.com>
13952
04f2d78b
CB
13953 * process.c (Flist_processes): Remove to Lisp.
13954 (list_processes_1): Delete.
e67a13ab 13955
973f782d
EZ
139562011-04-06 Eli Zaretskii <eliz@gnu.org>
13957
7c106b1e
EZ
13958 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13959
973f782d
EZ
13960 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13961
41cf7d1a 139622011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13963
ca23cc88
PE
13964 Fix more problems found by GCC 4.6.0's static checks.
13965
f390e2d5
PE
13966 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13967
42eea0d0
PE
13968 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13969
b69769da 13970 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13971
f9541e84
PE
13972 * xdisp.c (vmessage): Mark as a printf-like function.
13973
13841b55
PE
13974 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13975
c136c10f
PE
13976 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13977
5e2d4a30
PE
13978 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13979 printf-like functions.
13980 (tiff_load): Add casts to remove these marks before passing them
13981 to system-supplied API.
13982
583f48b9
PE
13983 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13984
b25d760e
PE
13985 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13986 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13987 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13988 directly, rather than having caller test rule sign. This avoids
13989 some unnecessary tests.
13990 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13991 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13992 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13993
bc7b6697 13994 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13995 (xfont_open): Avoid unnecessary tests.
bc7b6697 13996
27ccc379
PE
13997 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13998
dcd5c89a
PE
13999 * composite.h, composite.c (composition_gstring_put_cache):
14000 Use EMACS_INT, not int, for length.
14001
b13a45c6
PE
14002 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14003 breaking out part of COMPOSITION_DECODE_RULE.
14004 (COMPOSITION_DECODE_RULE): Use it.
14005 * composite.c (get_composition_id): Remove unused local vars,
14006 by using the new macro.
14007
1e792e4d
PE
14008 * textprop.c (set_text_properties_1): Change while to do-while,
14009 since the condition is always true at first.
14010
dc6c6455 14011 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14012 (interval_deletion_adjustment): Return unsigned value.
14013 All uses changed.
dc6c6455 14014
aba7731a
PE
14015 * process.c (list_processes_1, create_pty, read_process_output):
14016 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14017 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14018 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14019 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14020 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14021
fdfc4bf3
PE
14022 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14023
fca8fe46 14024 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14025 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14026
06a0259a 14027 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14028 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14029 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14030
e7b9e80f
PE
14031 * print.c (print_error_message): Avoid int overflow.
14032
56201685
PE
14033 * font.c (font_list_entities): Redo for clarity,
14034 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14035
78834453 14036 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14037 (font_score): Avoid potential overflow in diff calculation.
78834453 14038
0bc0b309 14039 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14040 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14041
e610eaca
PE
14042 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14043
b895abce
PE
14044 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14045 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14046 can always succeed if overflow has undefined behavior.
14047
1f1d9321 14048 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14049 (wordify): Omit three unnecessary tests.
1f1d9321 14050
c59478bc
PE
14051 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14052 All callers changed. This avoids the need for an unused var.
14053
79b73827
PE
14054 * casefiddle.c (casify_region): Remove var that is set but not used.
14055
a4db5dfe
PE
14056 * dired.c (file_name_completion): Remove var that is set but not used.
14057
43aae36e
PE
14058 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14059
2a47c44d 14060 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14061 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14062
a37c69bf
PE
14063 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14064 Check for integer overflow on size calculations.
14065
328ab8e7
PE
14066 * buffer.c (Fprevious_overlay_change): Remove var that is set
14067 but not used.
14068
e5a2a5cb
PE
14069 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14070 Remove vars that are set but not used.
8d84a6eb 14071 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14072 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14073
a60e5f68
PE
14074 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14075
f661cb61 14076 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14077 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14078
f0397f5a
PE
14079 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14080 that are set but not used.
14081
8664db06 14082 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14083 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14084
6abdaa4a
PE
14085 * xselect.c (x_get_local_selection, x_handle_property_notify):
14086 Remove vars that are set but not used.
14087
0ce7538d 14088 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14089 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14090
9ae848fc
PE
14091 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14092 Remove var that is set but not used.
0b918413
PE
14093 (scroll_bar_windows_size): Now size_t, not int.
14094 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14095 Check for overflow.
9ae848fc 14096
a5a62657
PE
14097 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14098 (map_tty_color) [!defined MSDOS]: Likewise.
14099
5c5cdd39
PE
14100 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14101
66ebf983
PE
14102 * coding.c: Remove vars that are set but not used.
14103 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14104 All callers changed.
14105 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14106 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14107 (decode_coding_charset): Remove vars that are set but not used.
14108
1be4d761
PE
14109 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14110 that is set but not used.
14111
47553fa8
PE
14112 * print.c (print_object): Remove var that is set but not used.
14113
1f7196bf 14114 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14115 The gnulib version avoids calling malloc in the usual case,
14116 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14117 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14118 * filelock.c (current_lock_owner): Likewise.
14119 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14120 * sysdep.c: Include allocator.h, careadlinkat.h.
14121 (emacs_no_realloc_allocator): New static constant.
14122 (emacs_readlink): New function.
fdb61804
PE
14123 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14124 ../lib/careadlinkat.h.
d1fdcab7 14125
f84c17c7
SM
141262011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14127
14128 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14129 first non-nil return value).
14130
ef3862ad
JD
141312011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14132
14133 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14134 if not defined (Bug#8403).
14135
376a7006
JB
141362011-04-02 Juanma Barranquero <lekktu@gmail.com>
14137
14138 * xdisp.c (display_count_lines): Remove parameter `start',
14139 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14140 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14141 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14142 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14143 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14144 and thereabouts. All callers changed.
14145 (get_per_char_metric): Remove parameter `f', unused since
14146 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14147
6ca3801d
JM
141482011-04-02 Jim Meyering <meyering@redhat.com>
14149
14150 do not dereference NULL upon failed strdup
14151 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14152 (ns_get_family): Likewise.
14153
d8e2b5ba
JB
141542011-04-02 Juanma Barranquero <lekktu@gmail.com>
14155
14156 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14157
8c74fcbd
JD
141582011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14159
14160 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14161 later (Bug#8403).
14162
7200d79c
SM
141632011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14164
03408648 14165 Add lexical binding.
7200d79c 14166
03408648
SM
14167 * window.c (Ftemp_output_buffer_show): New fun.
14168 (Fsave_window_excursion):
14169 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14170
14171 * lread.c (lisp_file_lexically_bound_p): New function.
14172 (Fload): Bind Qlexical_binding.
14173 (readevalloop): Remove `evalfun' arg.
14174 Bind Qinternal_interpreter_environment.
14175 (Feval_buffer): Bind Qlexical_binding.
14176 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14177 Mark as dynamic.
14178 (syms_of_lread): Declare `lexical-binding'.
14179
14180 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14181
14182 * keyboard.c (eval_dyn): New fun.
14183 (menu_item_eval_property): Use it.
ca105506
SM
14184
14185 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14186
03408648
SM
14187 * fns.c (concat, mapcar1): Accept byte-code-functions.
14188
14189 * eval.c (Fsetq): Handle lexical vars.
14190 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14191 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14192 (FletX, Flet): Obey lexical binding.
14193 (Fcommandp): Handle closures.
14194 (Feval): New `lexical' arg.
14195 (eval_sub): New function extracted from Feval. Use it almost
14196 everywhere where Feval was used. Look up vars in lexical env.
14197 Handle closures.
14198 (Ffunctionp): Move from subr.el.
14199 (Ffuncall): Handle closures.
14200 (apply_lambda): Remove `eval_flags'.
14201 (funcall_lambda): Handle closures and new byte-code-functions.
14202 (Fspecial_variable_p): New function.
14203 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14204 but without exporting it to Lisp.
23aba0ea 14205
23aba0ea 14206 * doc.c (Fdocumentation, store_function_docstring):
03408648 14207 * data.c (Finteractive_form): Handle closures.
23aba0ea 14208
03408648
SM
14209 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14210 interactive spec.
ba83908c 14211
04f2d78b
CB
14212 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14213 New byte-codes.
03408648
SM
14214 (exec_byte_code): New function extracted from Fbyte_code to handle new
14215 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14216
03408648 14217 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14218
03408648 14219 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14220
e2abce01
JB
142212011-03-31 Juanma Barranquero <lekktu@gmail.com>
14222
14223 * xdisp.c (redisplay_internal): Fix prototype.
14224
63696a73 142252011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14226
63696a73 14227 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14228 (try_scrolling): Use it when setting scroll_limit.
14229 Limit scrolling to 100 screen lines.
63696a73
EZ
14230 (redisplay_window): Even when falling back on "recentering",
14231 position point in the window according to scroll-conservatively,
14232 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14233
14234 (try_scrolling): When point is above the window, allow searching
14235 as far as scroll_max, or one screenful, to compute vertical
14236 distance from PT to the scroll margin position. This prevents
14237 try_scrolling from unnecessarily failing when
14238 scroll-conservatively is set to a value slightly larger than the
14239 window height. Clean up the case of PT below the margin at bottom
14240 of window: scroll_max can no longer be INT_MAX. When aggressive
14241 scrolling is in use, don't let point enter the opposite scroll
14242 margin as result of the scroll.
14243 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14244 threshold of 100 lines for never-recentering scrolling.
14245
e4cc2dfc
JB
142462011-03-31 Juanma Barranquero <lekktu@gmail.com>
14247
14248 * dispextern.h (move_it_by_lines):
14249 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14250 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14251 (message_log_check_duplicate): Remove parameters `prev_bol' and
14252 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14253 (redisplay_internal): Remove parameter `preserve_echo_area',
14254 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14255
14256 * indent.c (Fvertical_motion):
14257 * window.c (window_scroll_pixel_based, Frecenter):
14258 Don't pass `need_y_p' to `move_it_by_lines'.
14259
1c470562
SM
142602011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14261
44f230aa
SM
14262 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14263 steal a few bits to be more compact.
14264 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14265 Remove unneeded casts.
14266
1c470562
SM
14267 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14268
888adce9
ZK
142692011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14270
14271 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14272 binding" message (bug#7967).
14273
f838ed7b
PE
142742011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14275
77861b95
PE
14276 Fix more problems found by GCC 4.6.0's static checks.
14277
de6dbc14
PE
14278 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14279 Remove unused local var.
14280
f838ed7b
PE
14281 * editfns.c (Fmessage_box): Remove unused local var.
14282
792c7b2b
PE
14283 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14284 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14285 Omit unused local vars.
c499e557 14286 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14287 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14288 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14289 Omit unused local var.
14290
ba0165e1
PE
14291 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14292 Don't assume string length fits in int.
32ad8845 14293 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14294 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14295
3c59b4c9
PE
14296 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14297 instead of alloca (Bug#8344).
14298
a3eed478 14299 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14300 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14301
eb4d412d
PE
14302 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14303
1658b401
PE
14304 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14305 concerns.
14306
14307 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14308
14309 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14310
9a2c6e05
PE
14311 * keyboard.c (syms_of_keyboard): Use the same style as later
14312 in this function when indexing through an array. This also
14313 works around GCC bug 48267.
14314
03d0a109
PE
14315 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14316
44f730c8
PE
14317 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14318
fe75f926
PE
14319 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14320 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14321
ffa8c828
PE
14322 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14323 This avoids undefined behavior on integer overflow, and is a bit
14324 more convenient anyway since it is compared to a size_t variable.
14325
c5101a77
PE
14326 Variadic C functions now count arguments with size_t, not int.
14327 This avoids an unnecessary limitation on 64-bit machines, which
14328 caused (substring ...) to crash on large vectors (Bug#8344).
14329 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14330 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14331 All variadic functions and their callers changed accordingly.
c5101a77
PE
14332 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14333 * data.c (arith_driver, float_arith_driver): Likewise.
14334 * editfns.c (general_insert_function): Likewise.
14335 * eval.c (struct backtrace.nargs, interactive_p)
14336 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14337 (funcall_lambda, mark_backtrace): Likewise.
14338 * fns.c (concat): Likewise.
14339 * frame.c (x_set_frame_parameters): Likewise.
14340 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14341 0 if not found, not -1. All callers changed.
14342
dd3f25f7
PE
14343 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14344 (stack_copy_size): Now size_t, not int.
14345 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14346
461c2ab9
JB
143472011-03-28 Juanma Barranquero <lekktu@gmail.com>
14348
14349 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14350 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14351 All callers changed.
14352
14353 * lisp.h (multibyte_char_to_unibyte):
14354 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14355 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14356 * character.h (CHAR_TO_BYTE8):
14357 * cmds.c (internal_self_insert):
14358 * editfns.c (general_insert_function):
14359 * keymap.c (push_key_description):
14360 * search.c (Freplace_match):
14361 * xdisp.c (message_dolog, set_message_1): All callers changed.
14362
f6d62986
SM
143632011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14364
14365 * keyboard.c (safe_run_hook_funcall): New function.
14366 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14367 don't set the hook to nil, but remove the offending function instead.
14368 (Qcommand_hook_internal): Remove, unused.
14369 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14370 Vcommand_hook_internal.
14371
14372 * eval.c (enum run_hooks_condition): Remove.
14373 (funcall_nil, funcall_not): New functions.
14374 (run_hook_with_args): Call each function through a `funcall' argument.
14375 Remove `cond' argument, now redundant.
14376 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14377 (Frun_hook_with_args_until_failure): Adjust accordingly.
14378 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14379
1db5b1ad
JB
143802011-03-28 Juanma Barranquero <lekktu@gmail.com>
14381
14382 * dispextern.h (string_buffer_position): Remove declaration.
14383
14384 * print.c (strout): Remove parameter `multibyte', unused since
14385 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14386
14387 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14388 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14389 All callers changed.
14390
14391 * w32.c (_wsa_errlist): Use braces for struct initializers.
14392
14393 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14394 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14395 All callers changed.
14396 (string_buffer_position): Likewise. Also, make static (it's never
14397 used outside xdisp.c).
14398 (cursor_row_p): Remove parameter `w', unused since
14399 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14400 (decode_mode_spec): Remove parameter `precision', introduced during
14401 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14402 All callers changed.
14403
5ffb62aa
JD
144042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14405
14406 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14407
461c2ab9 144082011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14409
14410 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14411 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14412 (ns_update_auto_hide_menu_bar): New functions.
14413 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14414 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14415 ns_constrain_all_frames.
14416 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14417 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14418
5c380ffb
JD
144192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14420
14421 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14422
9af30bdf
GM
144232011-03-27 Glenn Morris <rgm@gnu.org>
14424
14425 * syssignal.h: Replace RETSIGTYPE with void.
14426 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14427 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14428 Replace SIGTYPE with void everywhere.
14429 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14430 * s/template.h (SIGTYPE): Remove commented out definition.
14431
e2abce01
JB
144322011-03-26 Eli Zaretskii <eliz@gnu.org>
14433
14434 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14435 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14436
f868cd8a
JB
144372011-03-26 Juanma Barranquero <lekktu@gmail.com>
14438
59eb0929
JB
14439 * w32.c (read_unc_volume): Use parameter `henum', instead of
14440 global variable `wget_enum_handle'.
14441
14442 * keymap.c (describe_vector): Remove parameters `indices' and
14443 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14444 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14445
f868cd8a
JB
14446 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14447
14448 * keyboard.c (timer_check): Remove parameter `do_it_now',
14449 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14450 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14451 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14452
14453 * keyboard.c (read_char):
14454 * w32menu.c (w32_menu_display_help):
14455 * xmenu.c (show_help_event, menu_help_callback):
14456 Adjust calls to `show_help_echo'.
14457
14458 * gtkutil.c (xg_maybe_add_timer):
14459 * keyboard.c (readable_events):
14460 * process.c (wait_reading_process_output):
14461 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14462
14463 * insdel.c (adjust_markers_gap_motion):
14464 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14465 (gap_left, gap_right): Don't call it.
14466
2ecf6fdb
CY
144672011-03-25 Chong Yidong <cyd@stupidchicken.com>
14468
14469 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14470 incurred during fontification.
14471
6b1f9ba4
JB
144722011-03-25 Juanma Barranquero <lekktu@gmail.com>
14473
14474 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14475 (DEFVAR_PER_BUFFER): Don't pass it.
14476
14477 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14478 (scrolling_window): Don't pass it.
14479
0f4a96b5
JB
144802011-03-25 Juanma Barranquero <lekktu@gmail.com>
14481
14482 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14483
14484 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14485 and `suffix'.
14486 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14487 of variables specific to SELinux and computation of `encoded_absname'.
14488
14489 * image.c (XPutPixel): Remove unused variable `height'.
14490
14491 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14492
14493 * unexw32.c (get_section_info): Remove unused variable `section'.
14494
14495 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14496 (system_process_attributes): Remove unused variable `sess'.
14497 (sys_read): Remove unused variable `err'.
14498
14499 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14500 (w32_wnd_proc): Remove unused variable `isdead'.
14501 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14502 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14503 (x_create_tip_frame): Remove unused variable `tem'.
14504
14505 * w32inevt.c (w32_console_read_socket):
14506 Remove unused variable `no_events'.
14507
14508 * w32term.c (x_draw_composite_glyph_string_foreground):
14509 Remove unused variable `width'.
14510
1149507c
JB
145112011-03-24 Juanma Barranquero <lekktu@gmail.com>
14512
14513 * w32term.c (x_set_glyph_string_clipping):
14514 Don't pass uninitialized region to CombineRgn.
14515
9c88f339
JB
145162011-03-23 Juanma Barranquero <lekktu@gmail.com>
14517
14518 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14519 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14520 (Fx_close_connection): Remove unused variable `i'.
14521
14522 * w32font.c (w32font_draw): Return number of glyphs.
14523 (w32font_open_internal): Remove unused variable `i'.
14524 (w32font_driver): Add missing initializer.
14525
14526 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14527 (fill_in_menu): Remove unused variable `items_added'.
14528
14529 * w32term.c (last_mouse_press_frame): Remove static global variable.
14530 (w32_clip_to_row): Remove unused variable `f'.
14531 (x_delete_terminal): Remove unused variable `i'.
14532
14533 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14534 (NOTHING): Remove unused static global variable.
14535 (uniscribe_check_otf): Remove unused variable `table'.
14536 (uniscribe_font_driver): Add missing initializers.
14537
dee091a3
JD
145382011-03-23 Julien Danjou <julien@danjou.info>
14539
14540 * term.c (Fsuspend_tty, Fresume_tty):
14541 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14542 * window.c (temp_output_buffer_show):
14543 * insdel.c (signal_before_change):
14544 * frame.c (Fhandle_switch_frame):
14545 * fileio.c (Fdo_auto_save):
14546 * emacs.c (Fkill_emacs):
14547 * editfns.c (save_excursion_restore):
14548 * cmds.c (internal_self_insert):
14549 * callint.c (Fcall_interactively):
14550 * buffer.c (Fkill_all_local_variables):
14551 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14552 Use Frun_hooks.
0f4a96b5 14553 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14554 unconditionally since it does the check itself.
dee091a3 14555
2c520ab5 145562011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14557
c9c49752
PE
14558 Fix more problems found by GCC 4.5.2's static checks.
14559
8abc3f12
PE
14560 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14561 the first time through the loop, since we know p0 < p1 then.
14562 This also avoids a gcc -Wstrict-overflow warning.
14563
a2d26660
PE
14564 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14565 leading to a memory leak, possible in functions like
14566 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14567 of objects (Bug#8318).
a2d26660 14568
916c72e9
PE
14569 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14570 that could (at least in theory) be that large.
14571
19ab8a18
PE
14572 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14573 This is less likely to overflow, and avoids undefined behavior if
14574 overflow does occur. All callers changed. Use strtoul to scan
14575 for the unsigned long integer.
b7cbbd6f
PE
14576 (pint2hrstr): Simplify and tune code slightly.
14577 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14578
f0641eff
PE
14579 * scroll.c (do_scrolling): Work around GCC bug 48228.
14580 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14581
7f650bb9
PE
14582 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14583 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14584 (validate_x_resource_name): Simplify count usage.
14585 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14586
37dd57d1
PE
14587 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14588 fail (Bug#8306).
81e56e61 14589
699979fc 14590 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14591
401bf9b4
PE
14592 * process.c (Fmake_network_process): Use socklen_t, not int,
14593 where POSIX says socklen_t is required in portable programs.
14594 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14595 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14596 (Fmake_network_process, server_accept_connection):
14597 (wait_reading_process_output, read_process_output):
14598 Likewise.
14599
b93aacde
PE
14600 * process.c: Rename or move locals to avoid shadowing.
14601 (list_processes_1, Fmake_network_process):
14602 (read_process_output_error_handler, exec_sentinel_error_handler):
14603 Rename or move locals.
4dc343ee 14604 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14605 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14606 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14607 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14608 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14609
af8a867c 14610 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14611 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14612 Include tparam.h instead, since it declares them.
af8a867c
PE
14613 * cm.h (PC): Remove extern decl; tparam.h now does this.
14614 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14615 * terminfo.c: Include tparam.h, to check interfaces.
14616 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14617 (tparam): Adjust signature to match interface in tparam.h;
14618 this removes some undefined behavior. Check that outstring and len
14619 are zero, which they always are with Emacs.
14620 * tparam.h (PC, BC, UP): New extern decls.
14621
0248044d 14622 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14623 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14624
8ff096c1 14625 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14626 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14627 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14628 (ftfont_list): Remove unused local.
49eaafba
PE
14629 (get_adstyle_property, ftfont_pattern_entity):
14630 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14631 Rename locals to avoid shadowing.
8ff096c1 14632
e2be39f6
PE
14633 * xfont.c (xfont_list_family): Mark var as initialized.
14634
c9735e30
PE
14635 * xml.c (make_dom): Now static.
14636
8f5201ae
PE
14637 * composite.c (composition_compute_stop_pos): Rename local to
14638 avoid shadowing.
b246f932
PE
14639 (composition_reseat_it): Remove unused locals.
14640 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14641 (composition_update_it): Mark var as initialized.
11b61122
PE
14642 (find_automatic_composition): Mark vars as initialized,
14643 with a FIXME (Bug#8290).
8f5201ae 14644
760fbc2c
PE
14645 character.h: Rename locals to avoid shadowing.
14646 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14647 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14648 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14649 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14650 to avoid shadowing.
14651
ff08eb85
PE
14652 * textprop.c (property_change_between_p): Remove; unused.
14653
fc7bf025
PE
14654 * intervals.c (interval_start_pos): Now static.
14655
235d7abc
PE
14656 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14657
44f230aa
SM
14658 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14659 Rename locals to avoid shadowing.
3e7d6594 14660
50060332
PE
14661 * sound.c (wav_play, au_play, Fplay_sound_internal):
14662 Fix pointer signedness.
d01f234b 14663 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14664 (wav_play): Initialize a variable to 0, to prevent undefined
14665 behavior (Bug#8278).
50060332 14666
c4fc4e30
PE
14667 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14668
918436ed
PE
14669 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14670
c939f91b
PE
14671 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14672 clobbering (Bug#8298).
b9c7f648
PE
14673 * sysdep.c (sys_subshell): Likewise.
14674 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14675
6bd8c144
PE
14676 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14677 This should get cleaned up, so that child_setup has the
14678 same signature on all platforms.
14679
7710357c 14680 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14681 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14682
c59da222
CY
146832011-03-22 Chong Yidong <cyd@stupidchicken.com>
14684
14685 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14686 not to be necessary, and produces flickering.
14687
66b87493
GM
146882011-03-20 Glenn Morris <rgm@gnu.org>
14689
14690 * config.in: Remove file.
14691
45b6f6d5
JB
146922011-03-20 Juanma Barranquero <lekktu@gmail.com>
14693
14694 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14695 are now in src/globals.h.
14696 (syms_of_minibuf): Remove spurious & from previous change.
14697
cd394be1 146982011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14699
14700 * minibuf.c (completing-read-function): New variable.
14701 (completing-read-default): Rename from completing-read.
14702 (completing-read): Call completing-read-function.
14703
b14e3e21
CY
147042011-03-19 Juanma Barranquero <lekktu@gmail.com>
14705
14706 * xfaces.c (Fx_load_color_file):
14707 Read color file from absolute filename (bug#8250).
14708
f2b726e6
JB
147092011-03-19 Juanma Barranquero <lekktu@gmail.com>
14710
14711 * makefile.w32-in: Update dependencies.
14712
09f6ff02
EZ
147132011-03-17 Eli Zaretskii <eliz@gnu.org>
14714
14715 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14716
29a6015a
PE
147172011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14718
a3a6c54e
PE
14719 Fix more problems found by GCC 4.5.2's static checks.
14720
b766f867
PE
14721 * process.c (make_serial_process_unwind, send_process_trap):
14722 (sigchld_handler): Now static.
14723
be02381c
PE
14724 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14725 That way, the code declares only the vars that it needs.
14726 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14727 * s/cygwin.h (PTY_ITERATION): Likewise.
14728 * s/darwin.h (PTY_ITERATION): Likewise.
14729 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14730
57048744
PE
14731 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14732 * process.c (allocate_pty): Don't declare stb unless it's needed.
14733
7914961c 14734 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14735 (CONSTANTLIM): Remove; unused.
14736 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14737 Define only if needed.
7914961c 14738
b3967b18
PE
14739 * unexelf.c (unexec): Name an expression,
14740 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14741 Use a different way to cause a compilation error if anyone uses
14742 n rather than nn, a way that does not involve shadowing.
73366a00 14743 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14744
29a6015a
PE
14745 * deps.mk (unexalpha.o): Remove; unused.
14746
43cfc33e 14747 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14748 * unexec.h: New file.
ce701a33
PE
14749 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14750 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14751 Depend on unexec.h.
14752 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14753 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14754 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14755 Change as necessary to match prototype in unexec.h.
ce701a33 14756
01f44d5a
PE
14757 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14758 shadowing.
4f63c6bb 14759 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14760
a6670b0b
PE
14761 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14762 Rename locals to avoid shadowing.
14763
cef2010d 14764 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14765 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14766
d4d7173a
PE
14767 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14768
f08b802a
PE
14769 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14770 warning when compiling print.c.
14771
3ddb0639
PE
14772 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14773 instead of using an uninitialized var.
5ad03b97 14774 (font_sort_entities): Mark var as initialized.
3ddb0639 14775
170a2692
PE
14776 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14777
e663c700
PE
14778 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14779 pointers to constants.
89bc529a 14780 (font_parse_fcname): Remove unused vars.
7b81e2d0 14781 (font_delete_unmatched): Now static.
ea838e10 14782 (font_get_spec): Remove; unused.
13a547c6
PE
14783 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14784 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14785 Rename or move locals to avoid shadowing.
e663c700 14786
2a80c887 14787 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14788 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14789
1384fa33 14790 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14791 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14792
8b2c52e9
PE
14793 * alloc.c (mark_backtrace): Move decl from here ...
14794 * lisp.h: ... to here, so that it can be checked.
14795
475545b5 14796 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14797 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14798 (lisp_indirect_variable): Name an expression,
14799 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14800 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14801
b1349114 14802 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14803 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14804 Use const pointer when appropriate.
b1349114 14805
a2928364
PE
14806 * lisp.h (get_system_name, get_operating_system_release):
14807 Move decls here, to check interfaces.
14808 * process.c (get_operating_system_release): Move decl to lisp.h.
14809 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14810 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14811 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14812 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14813 (Fformat_time_string, Fencode_time, Finsert_char):
14814 (Ftranslate_region_internal, Fformat):
14815 Rename or remove local vars to avoid shadowing.
9710023e 14816 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14817
a415e694
PE
14818 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14819 avoid shadowing.
14820
8ef4622d
PE
14821 * lisp.h (eassert): Check that the argument compiles, even if
14822 ENABLE_CHECKING is not defined.
14823
946f9a5b
PE
14824 * data.c (Findirect_variable): Name an expression, to avoid
14825 gcc -Wbad-function-cast warning.
112396d6 14826 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14827 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14828 (Fmake_variable_buffer_local, Fmake_local_variable):
14829 Mark variables as initialized.
52746918 14830 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14831
e5aab7e7 14832 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14833 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14834 Rename locals to avoid shadowing.
dff45157
PE
14835 (mark_stack): Move local variables into the #ifdef region where
14836 they're used.
7bc26fdb
PE
14837 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14838 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14839 needed otherwise.
14840 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14841 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14842 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14843
e5aab7e7
PE
14844 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14845 avoids undefined behavior in theory.
14846
4da60324
PE
14847 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14848
88043301
PE
14849 Use functions, not macros, for up- and down-casing (Bug#8254).
14850 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14851 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14852 to use the following functions instead of these macros.
14853 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14854 EMACS_INT, since callers assume the returned value fits in int.
14855 (upcase1): Likewise, for UPCASE_TABLE.
14856 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14857 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14858 the race-condition problem in the old DOWNCASE.
88043301 14859
19ed5445
PE
14860 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14861 Rename locals to avoid shadowing.
14862 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14863 (regex_compile, re_search_2, re_match_2_internal):
14864 Remove unused local vars.
952db0d7
PE
14865 (FREE_VAR): Rewrite so as not to use empty "else",
14866 which gcc can warn about.
da053e48 14867 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14868 (RETALLOC_IF): Define only if needed.
14869 (WORDCHAR_P): Likewise. This one is never needed, but is used
14870 only in a comment talking about a compiler bug, so put inside
14871 the #if 0 of that comment.
14872 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14873 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14874 Remove; unused.
19ed5445 14875
1f3561e4 14876 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14877 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14878 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14879
ded6f8f7
PE
14880 * search.c (simple_search): Remove unused var.
14881
dbd37a95
PE
14882 * dired.c (compile_pattern): Move decl from here ...
14883 * lisp.h: ... to here, so that it can be checked.
14884 (struct re_registers): New forward decl.
14885
7e47afad
PE
14886 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14887
85f24f61
PE
14888 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14889 All uses changed.
14890 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14891 Rename locals to avoid shadowing.
5671df8f 14892 (Fvertical_motion): Mark locals as initialized.
85f24f61 14893
181aa2be 14894 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14895 (casify_region): Mark local as initialized.
181aa2be 14896
930d429c
PE
14897 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14898
7082eac6
PE
14899 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14900 New macros, so that the caller can use some names other than
14901 gcpro1, gcpro2, etc.
14902 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14903 of the new macros.
14904 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14905 argument, for consistency with GCPRO2_VAR, etc: it is now the
14906 prefix of the variable, not the variable itself. All uses
14907 changed.
38b2c076
PE
14908 * dired.c (directory_files_internal, file_name_completion):
14909 Rename locals to avoid shadowing.
14910
15206ed9
PE
14911 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14912 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14913 dired.c's scmp function, had undefined behavior.
14914 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14915 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14916 * buffer.h: ... to here, because these macros use current_buffer,
14917 and the new implementation with inline functions needs to have
14918 current_buffer in scope now, rather than later when the macros
14919 are used.
14920 (downcase, upcase1): New static inline functions.
14921 (DOWNCASE, UPCASE1): Reimplement using these functions.
14922 This avoids undefined behavior in expressions like
14923 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14924 from race conditions in accessing the global variables
14925 case_temp1 and case_temp2.
14926 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14927 * lisp.h (case_temp1, case_temp2): Remove their decls.
14928 * character.h (ASCII_CHAR_P): Move from here ...
14929 * lisp.h: ... to here, so that the inline functions mentioned
14930 above can use them.
14931
4a6bea26
PE
14932 * dired.c (directory_files_internal_unwind): Now static.
14933
f14b7e14
PE
14934 * fileio.c (file_name_as_directory, directory_file_name):
14935 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14936 Now static.
2893f146
PE
14937 (file_name_as_directory): Use const pointers when appropriate.
14938 (Fexpand_file_name): Likewise. In particular, newdir might
14939 point at constant storage, so make it a const pointer.
fd4ead52 14940 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14941 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14942 signedness issues.
f839df0c
PE
14943 (Fset_file_times, Finsert_file_contents, auto_save_error):
14944 Rename locals to avoid shadowing.
f14b7e14 14945
5716756e 14946 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14947 (Ftry_completion, Fall_completions): Rename or remove locals
14948 to avoid shadowing.
5716756e 14949
b4c3046a
PE
14950 * marker.c (bytepos_to_charpos): Remove; unused.
14951
b45db522
PE
14952 * lisp.h (verify_bytepos, count_markers): New decls,
14953 so that gcc does not warn that these functions aren't declared.
14954
85876d07
PE
14955 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14956 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14957 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14958 (copy_text): Remove unused local var.
85876d07 14959
03d78a21 14960 * filelock.c (within_one_second): Now static.
b3dd38ab 14961 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14962
5df8f01b
PE
14963 * buffer.c (fix_overlays_before): Mark locals as initialized.
14964 (fix_start_end_in_overlays): Likewise. This function should be
14965 simplified by using pointers-to-pointers, but that's a different
14966 matter.
b1d876f1 14967 (switch_to_buffer_1): Now static.
8f54f30a
PE
14968 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14969 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14970
a70072c9 14971 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14972 Fix pointer signedness issue.
edced198
PE
14973 (sys_subshell): Mark local as volatile if checking for lint,
14974 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14975 (MAXPATHLEN): Define only if needed.
a70072c9 14976
a0977c44
PE
14977 * process.c (serial_open, serial_configure): Move decls from here ...
14978 * systty.h: ... to here, so that they can be checked.
14979
a884fdcc
PE
14980 * fns.c (get_random, seed_random): Move extern decls from here ...
14981 * lisp.h: ... to here, so that they can be checked.
14982
604efe86 14983 * sysdep.c (reset_io): Now static.
b8950c94 14984 (wait_for_termination_signal): Remove; unused.
604efe86 14985
38fc62d9
PE
14986 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14987 (copy_keymap_item, append_key, push_text_char_description):
14988 Now static.
1004a21a 14989 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14990 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14991 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14992 (describe_map_tree):
14993 Rename locals to avoid shadowing.
38fc62d9 14994
2f2650da
PE
14995 * keyboard.c: Declare functions static if they are not used elsewhere.
14996 (echo_char, echo_dash, cmd_error, top_level_2):
14997 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14998 (read_char, kbd_buffer_get_event, make_lispy_position):
14999 (make_lispy_event, make_lispy_movement, apply_modifiers):
15000 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15001 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15002 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15003 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15004 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15005
a053e86c 15006 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15007 (mark_kboards): Move decl here ...
15008 * alloc.c (mark_kboards): ... from here.
a053e86c 15009
4752793e
PE
15010 * lisp.h (force_auto_save_soon): New decl.
15011
74f10ca7 15012 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15013 (DEFINE_DUMMY_FUNCTION): New macro.
15014 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15015 Use it.
c03cd23f
PE
15016 (main): Add casts to avoid warnings
15017 if GCC considers string literals to be constants.
74f10ca7 15018
022e70d4
PE
15019 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15020
59d6fe83
PE
15021 * dbusbind.c: Pointer signedness fixes.
15022 (xd_signature, xd_append_arg, xd_initialize):
15023 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15024 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15025 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15026 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15027
78320123
PE
15028 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15029 if GCC considers string literals to be constants.
49cebcca 15030 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15031
35ac2a97
SM
150322011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15033
fb103ca9
SM
15034 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15035 (print_preprocess, print_object): New macro to fix last change.
15036
35ac2a97
SM
15037 * print.c (print_preprocess): Don't forget font objects.
15038
62973b41
JB
150392011-03-16 Juanma Barranquero <lekktu@gmail.com>
15040
15041 * emacs.c (USAGE3): Doc fixes.
15042
0e48bb22
AS
150432011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15044
15045 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15046 structure.
15047
7684e57b
JB
150482011-03-14 Juanma Barranquero <lekktu@gmail.com>
15049
15050 * lisp.h (VWindow_system, Qfile_name_history):
15051 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15052 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15053 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15054
15055 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15056 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15057
15058 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15059 * w32console.c (detect_input_pending, read_input_pending)
15060 (encode_terminal_code):
15061 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15062 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15063 (w32_system_caret_y, Qfile_name_history):
15064 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15065 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15066 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15067 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15068 * w32proc.c (Qlocal, report_file_error):
15069 * w32term.c (Vwindow_system, updating_frame):
15070 * w32uniscribe.c (initialized, uniscribe_font_driver):
15071 Remove unneeded extern declarations.
15072
2aa46d6c
CY
150732011-03-14 Chong Yidong <cyd@stupidchicken.com>
15074
c96bbc66 15075 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15076
cffc6f3b
CY
150772011-03-13 Chong Yidong <cyd@stupidchicken.com>
15078
15079 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15080 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15081 These macros can no longer be used for assignment.
15082
44f230aa
SM
15083 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15084 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15085 (record_buffer_markers, fetch_buffer_markers): New functions for
15086 recording and fetching special buffer markers.
15087 (set_buffer_internal_1, set_buffer_temp): Use them.
15088
15089 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15090
15091 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15092
15093 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15094 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15095
15096 * xdisp.c (hscroll_window_tree):
15097 (reconsider_clip_changes): Use PT instead of BUF_PT.
15098
d251f04b
EZ
150992011-03-13 Eli Zaretskii <eliz@gnu.org>
15100
15101 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15102 $(EMACS_ROOT)/lib/intprops.h.
15103
f0c77cd1
PE
151042011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15105
3eca4629
PE
15106 Fix more problems found by GCC 4.5.2's static checks.
15107
7c86ee98
PE
15108 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15109 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15110 (xg_free_frame_widgets): Make it clear that a local variable is
15111 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15112 (gdk_window_get_screen): Make it clear that this macro is needed
15113 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15114 (int_gtk_range_get_value): New function, which avoids a diagnostic
15115 from gcc -Wbad-function-cast.
15116 (xg_set_toolkit_scroll_bar_thumb): Use it.
15117 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15118 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15119 (get_utf8_string, xg_get_file_with_chooser):
15120 Rename locals to avoid shadowing.
15121 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15122
41729b81
PE
15123 * xgselect.c (xg_select): Remove unused var.
15124
f0c77cd1
PE
15125 * image.c (four_corners_best): Mark locals as initialized.
15126 (gif_load): Initialize transparent_p to zero (Bug#8238).
15127 Mark another local as initialized.
ec6cf4c6 15128 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15129
ce0ad53d 15130 * image.c (clear_image_cache): Now static.
d5d5a617 15131 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15132 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15133 (x_edge_detection): Remove unnecessary cast that
15134 gcc -Wbad-function-cast diagnoses.
2037898d 15135 (gif_load): Fix pointer signedness.
6ae141d6
PE
15136 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15137 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15138
33383987 151392011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15140
d32df629
PE
15141 Improve quality of tests for time stamp overflow.
15142 For example, without this patch (encode-time 0 0 0 1 1
15143 1152921504606846976) returns the obviously-bogus value (-948597
15144 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15145 reports time overflow. See
15146 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15147 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15148 * editfns.c: Include limits.h and intprops.h.
15149 (TIME_T_MIN, TIME_T_MAX): New macros.
15150 (time_overflow): Move earlier, to before first use.
15151 (hi_time, lo_time): New functions, for an accurate test for
15152 out-of-range times.
15153 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15154 (Fget_internal_run_time): Don't assume time_t fits in int.
15155 (make_time): Use list2 instead of Fcons twice.
15156 (Fdecode_time): More accurate test for out-of-range times.
15157 (check_tm_member): New function.
15158 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15159 (lisp_time_argument): Don't rely on undefined left-shift and
15160 right-shift behavior when checking for time stamp overflow.
8be6f318 15161
fe31d94c
PE
15162 * editfns.c (time_overflow): New function, refactoring common code.
15163 (Fformat_time_string, Fdecode_time, Fencode_time):
15164 (Fcurrent_time_string): Use it.
15165
8be6f318
PE
15166 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15167 * dired.c (make_time): Move to ...
15168 * editfns.c (make_time): ... here.
15169 * systime.h: Note the move.
15170
09d9db2c 151712011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15172
126bc0dc
YM
15173 * fringe.c (update_window_fringes): Remove unused variables.
15174
c47cbdfd
YM
15175 * unexmacosx.c (copy_data_segment): Also copy __got section.
15176 (Bug#8223)
15177
7ac80be9
EZ
151782011-03-12 Eli Zaretskii <eliz@gnu.org>
15179
c96bbc66 15180 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15181 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15182 Constify `char *' arguments and their references according to
15183 prototypes in tparam.h.
15184
ecb0f94d 15185 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15186
7ac80be9
EZ
15187 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15188 Adapt all references accordingly.
15189
15190 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15191
ef1fd07e
TT
151922011-03-11 Tom Tromey <tromey@redhat.com>
15193
15194 * buffer.c (syms_of_buffer): Remove obsolete comment.
15195
7ef4b50c
EZ
151962011-03-11 Eli Zaretskii <eliz@gnu.org>
15197
15198 * termhooks.h (encode_terminal_code): Declare prototype.
15199
15200 * msdos.c (encode_terminal_code): Don't declare prototype.
15201
15202 * term.c (encode_terminal_code): Now external again, used by
15203 w32console.c and msdos.c.
15204
44f230aa
SM
15205 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15206 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15207
4b1ec863 152082011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15209
1714f52b 15210 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15211
4b1ec863
PE
15212 * fringe.c (update_window_fringes): Mark locals as initialized
15213 (Bug#8227).
15214 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15215
524c7aa6
PE
15216 * alloc.c (mark_fringe_data): Move decl from here ...
15217 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15218 to check its interface.
15219 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15220
a5c0af81 15221 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15222 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15223 (fontset_font): Mark local as initialized.
a9a06e0b 15224 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15225
b4716021
PE
15226 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15227
811e9bac 15228 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15229 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15230 (x_own_selection, Fx_disown_selection_internal): Rename locals
15231 to avoid shadowing.
15232 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15233
7e3ab302
PE
15234 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15235 so that the caller can use some name other than gcpro1.
15236 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15237 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15238 (Fx_backspace_delete_keys_p):
15239 Use them to avoid shadowing, and rename vars to avoid shadowing.
15240 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15241 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15242 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15243 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15244 Remove unused locals.
7e3ab302
PE
15245 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15246 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15247 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15248 macros.
f78faa98 15249
e2b13473
PE
15250 * xterm.h (x_mouse_leave): New decl.
15251
77f23912
PE
15252 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15253 Remove unused functions.
cdf4ba58
PE
15254 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15255 (x_calc_absolute_position): Now static.
7411c686 15256 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15257 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15258 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15259 unless they are used.
38d0b34a
PE
15260 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15261 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15262 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15263 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15264 (x_error_catcher, x_connection_closed, x_error_handler):
15265 (x_error_quitter, xembed_send_message, x_iconify_frame):
15266 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15267 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15268 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15269
44f230aa
SM
15270 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15271 Rename or move locals to avoid shadowing.
6b463e58 15272 (tty_defined_color, merge_face_heights): Now static.
5967d051 15273 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15274 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15275 does not deduce is never used uninitialized.
73719eba
PE
15276 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15277 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15278
426994c3 15279 * terminal.c (store_terminal_param): Now static.
5489860b 15280
032f1620 15281 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15282 (set_frame_menubar): Remove unused local.
d4323972 15283 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15284 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15285 since they might point to immutable storage.
281585b0
PE
15286 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15287 since it's unused otherwise.
032f1620 15288
367c19e5 15289 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15290 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15291 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15292 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15293 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15294 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15295 does not deduce are never used uninitialized.
70739cbe 15296
07b48fa9
PE
15297 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15298
8868a238 15299 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15300 * window.c (window_loop, size_window):
15301 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15302
7e5cf297 15303 * window.c (display_buffer): Now static.
d6550a9f
PE
15304 (size_window): Mark variables that gcc -Wuninitialized
15305 does not deduce are never used uninitialized.
a586633d
PE
15306 * window.h (check_all_windows): New decl, to forestall
15307 gcc -Wmissing-prototypes diagnostic.
5b555da1 15308 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15309
f6095868
PE
15310 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15311 shadowing.
15312 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15313 Include <limits.h>.
15314 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15315 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15316 (load_charset_map): Mark variables that gcc -Wuninitialized
15317 does not deduce are never used uninitialized.
53df7c11 15318 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15319
f38b440c
PE
15320 * coding.c (coding_set_source, coding_set_destination):
15321 Use "else { /* comment */ }" rather than "else /* comment */;"
15322 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15323 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15324 a block, when the outer 'i' will do.
15325 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15326 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15327 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15328 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15329 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15330 Rename locals to avoid shadowing.
15331 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15332 * coding.c (emacs_mule_char, encode_invocation_designation):
15333 Now static, since they're not used elsewhere.
413bb2db 15334 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15335 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15336 (decode_coding_emacs_mule): Mark variables that gcc
15337 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15338 (detect_coding_iso_2022): Initialize a local variable that might
15339 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15340 this initialization is needed. (Bug#8211)
5f58e762
PE
15341 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15342 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15343 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15344 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15345 Remove unused macros.
f38b440c 15346
232b38b9 15347 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15348 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15349 * character.c (string_count_byte8): Likewise.
232b38b9 15350
fb90da1b
PE
15351 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15352 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15353
fb93dbc2
PE
15354 * chartab.c (copy_sub_char_table): Now static, since it's not used
15355 elsewhere.
5c156ace
PE
15356 (sub_char_table_ref_and_range, char_table_ref_and_range):
15357 Rename locals to avoid shadowing.
bbcd0949 15358 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15359
7d3b3862 15360 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15361 (BIDI_BOB): Remove unused macro.
7d3b3862 15362
6be7d3da
PE
15363 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15364 deduce are never used uninitialized.
c2ed9c8b 15365 * term.c (encode_terminal_code): Likewise.
6be7d3da 15366
75f8807f 15367 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15368
50938595
PE
15369 * tparam.h: New file.
15370 * term.c, tparam.h: Include it.
15371 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15372 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15373 Move these decls to tparam.h, and make them agree with what
15374 is actually in tparam.c. The previous trick of using incompatible
15375 decls in different modules does not conform to the C standard.
15376 All callers of tparam changed to use tparam's actual API.
15377 * tparam.c (tparam1, tparam, tgoto):
15378 Use const pointers where appropriate.
15379
fbceeba2
PE
15380 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15381 * cm.h (struct cm): Likewise.
15382 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15383 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15384 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15385 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15386 (turn_on_face, init_tty): Likewise.
15387 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15388
7f3f1250
PE
15389 * term.c (term_mouse_position): Rename local to avoid shadowing.
15390
e6ca6543
PE
15391 * alloc.c (mark_ttys): Move decl from here ...
15392 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15393
c40f8d15
AS
153942011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15395
15396 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15397
cfe0661d
JB
153982011-03-09 Juanma Barranquero <lekktu@gmail.com>
15399
15400 * search.c (compile_pattern_1): Remove argument regp, unused since
15401 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15402 (compile_pattern): Don't pass it.
15403
0afb4571
J
154042011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15405
15406 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15407 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15408 for ! HAVE_GTK3.
15409 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15410
15411 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15412
15413 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15414 gdk_window_get_screen, gdk_window_get_geometry,
15415 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15416 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15417 (xg_get_pixbuf_from_pixmap): New function.
15418 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15419 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15420 Call xg_get_pixbuf_from_pixmap instead of
15421 gdk_pixbuf_get_from_drawable.
15422 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15423 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15424 (xg_check_special_colors): Use GtkStyleContext and its functions
15425 for HAVE_GTK3.
15426 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15427 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15428 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15429 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15430 Call gtk_widget_get_preferred_size.
0afb4571
J
15431 (xg_frame_resized): gdk_window_get_geometry only takes 5
15432 parameters.
44f230aa
SM
15433 (xg_win_to_widget, xg_event_is_for_menubar):
15434 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15435 (xg_set_widget_bg): New function.
15436 (delete_cb): New function.
895009e1 15437 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15438 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15439 (xg_set_background_color): Call xg_set_widget_bg.
15440 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15441 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15442 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15443 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15444 if ! HAVE_GTK3.
15445 (update_frame_tool_bar): Call gtk_widget_hide.
15446 (xg_initialize): Use GDK_KEY_g.
15447
15448 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15449 if ! HAVE_GTK3
15450 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15451
15452 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15453 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15454 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15455
1c2cc4ef
JB
154562011-03-08 Juanma Barranquero <lekktu@gmail.com>
15457
15458 * w32xfns.c (select_palette): Check success of RealizePalette against
15459 GDI_ERROR, not zero.
15460
33383987 15461See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15462
15463;; Local Variables:
15464;; coding: utf-8
aac0c6e3
MR
15465;; End:
15466
2f097256 15467 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15468
15469 This file is part of GNU Emacs.
15470
15471 GNU Emacs is free software: you can redistribute it and/or modify
15472 it under the terms of the GNU General Public License as published by
15473 the Free Software Foundation, either version 3 of the License, or
15474 (at your option) any later version.
15475
15476 GNU Emacs is distributed in the hope that it will be useful,
15477 but WITHOUT ANY WARRANTY; without even the implied warranty of
15478 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15479 GNU General Public License for more details.
15480
15481 You should have received a copy of the GNU General Public License
15482 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.