* search.c (searchbufs, searchbuf_head): Now static.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
93ea6e8f
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
989b29ad
PE
3 * search.c (searchbufs, searchbuf_head): Now static.
4
13a55a78
PE
5 * scroll.c (scroll_cost): Remove; unused.
6 * dispextern.h (scroll_cost): Remove decl.
7
de68a1fc
PE
8 * region-cache.h (pp_cache): Mark as externally visible.
9
40ccffa6
PE
10 * process.c: Make symbols static if they're not exported.
11 (process_tick, update_tick, create_process, chan_process):
12 (Vprocess_alist, proc_buffered_char, datagram_access):
13 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14 (deactivate_process): Mark defn as static, as well as decl.
15 * lisp.h (create_process): Remove decl.
16 * process.h (chan_process, Vprocess_alist): Remove decls.
17
ad64fc97
PE
18 * print.c: Make symbols static if they're not exported.
19 (print_depth, new_backquote_output, being_printed, print_buffer):
20 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
21 (print_interval, print_number_index, initial_stderr_stream):
22 Now static.
23 * lisp.h (Fprinc): Remove decl.
24 (debug_output_compilation_hack): Mark as externally visible.
25
adddb265
PE
26 * sysdep.c (croak): Move decl from here to syssignal.h.
27 * syssignal.h (croak): Put it here, so the API can be checked when
28 'croak' is called from dissociate_if_controlling_tty.
29
1717ede2
PE
30 * minibuf.c: Make symbols static if they're not exported.
31 (minibuf_save_list, choose_minibuf_frame): Now static.
32 * lisp.h (choose_minibuf_frame): Remove decl.
33
fa5fb2bc
PE
34 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
35
1e3890d1
PE
36 * lread.c: Make symbols static if they're not exported.
37 (read_objects, initial_obarray, oblookup_last_bucket_number):
38 Now static.
39 (make_symbol): Remove; unused.
40 * lisp.h (initial_obarray, make_symbol): Remove decls.
41
8a1414fa
PE
42 * keyboard.c: Make symbols static if they're not exported.
43 (single_kboard, recent_keys_index, total_keys, recent_keys):
44 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
45 (this_single_command_key_start, echoing, last_auto_save):
46 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
47 (command_loop, echo_now, keyboard_init_hook, help_char_p):
48 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
49 (Vlispy_mouse_stem, double_click_count):
50 Now static.
51 (force_auto_save_soon): Define only if SIGDANGER.
52 (ignore_mouse_drag_p): Now static if
53 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
54 (print_help): Remove; unused.
55 (stop_character, last_timer_event): Mark as externally visible.
56 * keyboard.h (ignore_mouse_drag_p): Declare only if
57 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
58 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
59 * lisp.h (echoing): Remove decl.
60 (force_auto_save_soon): Declare only if SIGDANGER.
61 * xdisp.c (redisplay_window): Simplify code, to make it more
62 obvious that ignore_mouse_drag_p is not accessed if !defined
63 USE_GTK && !defined HAVE_NS.
64
93ea6e8f
PE
65 * intervals.c: Make symbols static if they're not exported.
66 (merge_properties_sticky, merge_interval_right, delete_interval):
67 Now static.
68 * intervals.h (merge_interval_right, delete_interval): Remove decls.
69
b532497d
PE
702011-04-13 Paul Eggert <eggert@cs.ucla.edu>
71
77382fcc
PE
72 * insdel.c: Make symbols static if they're not exported.
73 However, leave prepare_to_modify_buffer alone. It's never
74 called from outside this function, but that appears to be a bug.
75 (combine_after_change_list, combine_after_change_buffer):
4889fc82 76 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
77 (adjust_after_replace_noundo): Remove; unused.
78 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 79 (signal_before_change): Remove decls.
77382fcc 80
9306c32e
PE
81 * indent.c (val_compute_motion, val_vmotion): Now static.
82
cd44d2eb
PE
83 * image.c: Make symbols static if they're not exported.
84 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
85 if USE_GTK.
86 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
87 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
88
ad9a7a06
PE
89 * fringe.c (standard_bitmaps): Now static.
90 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
91
81626931
PE
92 * frame.c: Make symbols static if they're not exported.
93 (x_report_frame_params, make_terminal_frame): Now static.
94 (get_frame_param): Now static, unless HAVE_NS.
95 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
96 (x_get_resource_string): Remove; not used.
97 * frame.h (make_terminal_frame, x_report_frame_params):
98 (x_get_resource_string); Remove decls.
99 (x_fullscreen_adjust): Declare only if WINDOWSNT.
100 * lisp.h (get_frame_param): Declare only if HAVE_NS.
101
239f9db9
PE
102 * font.c, fontset.c: Make symbols static if they're not exported.
103 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
104 (FACE_SUITABLE_FOR_CHAR_P): Use it.
105 * font.c (font_close_object): Now static.
106 * font.h (font_close_object): Remove.
107 * fontset.c (FONTSET_OBJLIST): Remove.
108 (free_realized_fontset) #if-0 the body, which does nothing.
109 (face_suitable_for_char_p): #if-0, as it's never called.
110 * fontset.h (face_suitable_for_char_p): Remove decl.
111 * xfaces.c (face_at_string_position): Use
112 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
113 since 0 is always ASCII.
114
dfcf3579
PE
115 * fns.c (weak_hash_tables): Now static.
116
5045092b
PE
117 * fileio.c: Make symbols static if they're not exported.
118 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
119 (Vwrite_region_annotation_buffers): Now static.
120
57a96f5c
PE
121 * eval.c: Make symbols static if they're not exported.
122 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
123 * lisp.h (backtrace_list): Remove decl.
124
35f08c38
PE
125 * emacs.c: Make symbols static if they're not exported.
126 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
127 (fatal_error_code, fatal_error_signal_hook, standard_args):
128 Now static.
129 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
130 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
131 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
132 * lisp.h (fatal_error_signal_hook): Remove decl.
133 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
134
f44bd759
PE
135 * editfns.c: Move a (normally-unused) function to its only use.
136 * editfns.c, lisp.h (get_operating_system_release): Remove.
137 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
138 worth the hassle of breaking this out.
139
b532497d
PE
140 * xterm.c: Make symbols static if they're not exported.
141 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
142 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
143 (x_destroy_window, x_delete_display):
144 Now static.
145 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
146 (x_mouse_leave): Remove; unused.
147 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
148 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
149 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
150 Remove decls.
151 (x_mouse_leave): Declare only if WINDOWSNT.
152 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
153 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
154 USE_X_TOOLKIT.
155
a25f4dfa
PE
1562011-04-12 Paul Eggert <eggert@cs.ucla.edu>
157
1675728f
PE
158 * ftxfont.c: Make symbols static if they're not exported.
159 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
160 HAVE_FREETYPE.
161 * font.h (ftxfont_driver): Likewise.
162
e4cebfca
PE
163 * xfns.c: Make symbols static if they're not exported.
164 (x_last_font_name, x_display_info_for_name):
165 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
166 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
167 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
168 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
169 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
170 (last_show_tip_args): Now static.
171 (xic_defaut_fontset, xic_create_fontsetname): Define only if
172 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
173 (x_screen_planes): Remove; unused.
174 * dispextern.h (x_screen_planes): Remove decl.
175
5bf46f05
PE
176 * dispnew.c: Make symbols static if they're not exported.
177 * dispextern.h (redraw_garbaged_frames, scrolling):
178 (increment_row_positions): Remove.
179 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
180 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
181 Now static.
182 (redraw_garbaged_frames): Remove; unused.
183
435f4c28
PE
184 * xfaces.c: Make symbols static if they're not exported.
185 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
186 Remove decls.
187 * xterm.h (defined_color): Remove decls.
188 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
189 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
190 (menu_face_changed_default, defined_color, free_realized_face):
191 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
192 (ascii_face_of_lisp_face): Remove; unused.
193
8524aef3
PE
194 * xdisp.c: Make symbols static if they're not exported.
195 * dispextern.h (scratch_glyph_row, window_box_edges):
196 (glyph_to_pixel_coords, set_cursor_from_row):
197 (get_next_display_element, set_iterator_to_next):
198 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
199 (show_mouse_face): Remove decls
200 * frame.h (message_buf_print): Likewise.
201 * lisp.h (pop_message, set_message, check_point_in_composition):
202 Likewise.
203 * xterm.h (set_vertical_scroll_bar): Likewise.
204 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
205 (message_buf_print, scratch_glyph_row, displayed_buffer):
206 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
207 (get_next_display_element, show_mouse_face, window_box_edges):
208 (frame_to_window_pixel_xy, check_point_in_composition):
209 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
210 (glyph_to_pixel_coords): Remove; unused.
211
16390cd2
PE
212 * dired.c (file_name_completion): Now static.
213
214 * dbusbind.c (xd_in_read_queued_messages): Now static.
215
a25f4dfa
PE
216 * lisp.h (circular_list_error, FOREACH): Remove; unused.
217 * data.c (circular_list_error): Remove.
218
16a97296
PE
2192011-04-11 Paul Eggert <eggert@cs.ucla.edu>
220
14a9c8df
PE
221 * commands.h (last_point_position, last_point_position_buffer):
222 (last_point_position_window): Remove decls.
223 * keyboard.c: Make these variables static.
224
74ab6df5
PE
225 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
226 decls.
227 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
228 (iso_code_class, detect_coding, code_convert_region): Now static.
229 (encode_coding_gap): Remove; unused.
230
38dfbee1
PE
231 * chartab.c (chartab_chars, chartab_bits): Now static.
232
a2cb4e63
PE
233 * charset.h (charset_iso_8859_1): Remove decl.
234 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
235 Now static.
236
127198fd
PE
237 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
238 * ccl.c (Vccl_program_table): Now static.
239 (check_ccl_update): Remove; unused.
240
d85b608f
PE
241 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
242 * category.h: ... from here.
243 * category.c (check_category_table, set_category_set): Now static.
244
31cd66f3
PE
245 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
246 * lisp.h: Remove these decls.
247
c358e587
PE
248 * buffer.c (buffer_count): Remove unused var.
249
e78aecca
PE
250 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
251 so that it's not optimized away.
252 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
253 * dispextern.h (bidi_dump_cached_states): Remove, since it's
254 exported only to the debugger.
255
e192d7d3
PE
256 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
257 * atimer.h (run_all_atimers): Removed; not exported.
258
92470028
PE
259 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
260 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
261 was inaccessible from Lisp.
262 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
263 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
264
244ed907
PE
265 alloc.c: Import and export fewer symbols, and remove unused items.
266 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
267 is defined.
268 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
269 it's not optimized away by whole-program optimization.
270 (message_enable_multibyte, free_misc): Remove.
271 (catchlist, handlerlist, mark_backtrace):
272 Declare only if BYTE_MARK_STACK.
273 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
274 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
275 (message_enable_multibyte): Remove decl.
276 (free_misc, interval_free_list, float_block, float_block_index):
277 (n_float_blocks, float_free_list, cons_block, cons_block_index):
278 (cons_free_list, last_marked_index):
279 Now static.
280 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
281 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
282 (mark_backtrace): Define only if BYTE_MARK_STACK.
283 * xdisp.c (message_enable_multibyte): Now static.
284
955cbe7b
PE
285 Declare Lisp_Object Q* variables to be 'static' if not exproted.
286 This makes it easier for human readers (and static analyzers)
287 to see whether these variables are used from other modules.
288 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
289 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
290 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
291 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
292 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
293 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
294 * xmenu.c, xselect.c:
295 Declare Q* vars static if they are not used in other modules.
296 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
297 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
298 Remove decls of unexported vars.
299 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
300
95c82688
PE
301 * lisp.h (DEFINE_FUNC): Make sname 'static'.
302
16a97296
PE
303 Make Emacs functions such as Fatom 'static' by default.
304 This makes it easier for human readers (and static analyzers)
305 to see whether these functions can be called from other modules.
306 DEFUN now defines a static function. To make the function external
307 so that it can be used in other C modules, use the new macro DEFUE.
308 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
309 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
310 static function definition. Use DEFUE if you want an extern one.
311 (DEFUE, INFUN): New macros.
312 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
313 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
314 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
315 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
316 Remove decls, since these functions are now static.
317 (Funintern, Fget_internal_run_time): New decls, since these functions
318 were already external.
95c82688 319
16a97296
PE
320 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
321 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
322 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
323 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
324 * keyboard.c, keymap.c, lread.c:
325 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
326 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
327 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
328 Mark functions with DEFUE instead of DEFUN,
329 if they are used in other modules.
330 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
331 decls for now-static functions.
332 * buffer.h (Fdelete_overlay): Remove decl.
333 * callproc.c (Fgetenv_internal): Mark as internal.
334 * composite.c (Fremove_list_of_text_properties): Remove decl.
335 (Fcomposition_get_gstring): New forward static decl.
336 * composite.h (Fcomposite_get_gstring): Remove decl.
337 * dired.c (Ffile_attributes): New forward static decl.
338 * doc.c (Fdocumntation_property): New forward static decl.
339 * eval.c (Ffetch_bytecode): New forward static decl.
340 (Funintern): Remove extern decl; now in .h file where it belongs.
341 * fileio.c (Fmake_symbolic_link): New forward static decl.
342 * image.c (Finit_image_library): New forward static decl.
343 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
344 * intervals.h (Fprevious_property_change):
345 (Fremove_list_of_text_properties): Remove decls.
346 * keyboard.c (Fthis_command_keys): Remove decl.
347 (Fcommand_execute): New forward static decl.
348 * keymap.c (Flookup_key): New forward static decl.
349 (Fcopy_keymap): Now static.
350 * keymap.h (Flookup_key): Remove decl.
351 * process.c (Fget_process): New forward static decl.
352 (Fprocess_datagram_address): Mark as internal.
353 * syntax.c (Fsyntax_table_p): New forward static decl.
354 (skip_chars): Remove duplicate decl.
355 * textprop.c (Fprevious_property_change): New forward static decl.
356 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
357 Now internal.
358 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
359 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
360
785bbd42
PE
3612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
362
363 * editfns.c (Fformat): Remove unreachable code.
364
4073e537 3652011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 366
b2ded58d
PE
367 Fix more problems found by GCC 4.6.0's static checks.
368
7d66342c
PE
369 * xdisp.c (vmessage): Use a better test for character truncation.
370
bbf47d44
PE
371 * charset.c (load_charset_map): <, not <=, for optimization,
372 and to avoid potential problems with integer overflow.
9248994d 373 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 374 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 375 * editfns.c (Fformat): Likewise.
1e69125e 376 * syntax.c (skip_chars): Likewise.
3befa583 377
e3019616
PE
378 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
379 This also lets GCC 4.6.0 generate slightly better loop code.
380
becfa255
PE
381 * callint.c (Fcall_interactively): <, not <=, for optimization.
382 (Fcall_interactively): Count the number of arguments produced,
383 not the number of arguments given. This is simpler and lets GCC
384 4.6.0 generate slightly better code.
385
dae0cd48
PE
386 * ftfont.c: Distingish more carefully between FcChar8 and char.
387 The previous code passed unsigned char * to a functions like
388 strlen and xstrcasecmp that expect char *, which does not
389 conform to the C standard.
390 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
391 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
392 char * when the C standard requires it.
393
76032d70
PE
394 * keyboard.c (read_char): Remove unused var.
395
eb3f1cc8
PE
396 * eval.c: Port to Windows vsnprintf (Bug#8435).
397 Include <limits.h>.
398 (SIZE_MAX): Define if the headers do not.
399 (verror): Do not give up if vsnprintf returns a negative count.
400 Instead, grow the buffer. This ports to Windows vsnprintf, which
401 does not conform to C99. Problem reported by Eli Zaretskii.
402 Also, simplify the allocation scheme, by avoiding the need for
403 calling realloc, and removing the ALLOCATED variable.
404
70476b54
PE
405 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
406
12020a9e
PE
407 Remove invocations of doprnt, as Emacs now uses vsnprintf.
408 But keep the doprint source code for now, as we might revamp it
409 and use it again (Bug#8435).
ea6c7ae6
PE
410 * lisp.h (doprnt): Remove.
411 * Makefile.in (base_obj): Remove doprnt.o.
412 * deps.mk (doprnt.o): Remove.
413
5fdb398c
PE
414 error: Print 32- and 64-bit integers portably (Bug#8435).
415 Without this change, on typical 64-bit hosts error ("...%d...", N)
416 was used to print both 32- and 64-bit integers N, which relied on
417 undefined behavior.
418 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
419 New macro.
420 * lisp.h (error, verror): Mark as printf-like functions.
421 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
422 Report overflow in size calculations when allocating printf buffer.
423 Do not truncate output string at its first null byte.
424 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
425 Truncate the output at a character boundary, since vsnprintf does not
426 do that.
427 * charset.c (check_iso_charset_parameter): Convert internal
428 character to string before calling 'error', since %c now has the
429 printf meaning.
430 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
431 overflow when computing char to be passed to 'error'. Do not
432 pass Lisp_Object to 'error'; pass the integer instead.
433 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
434 formatted with plain %d.
435
b189fa66
PE
436 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
437
bff87ef0
PE
438 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
439
7e2cac20
PE
440 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
441
ce4d90b5
PE
442 * xterm.c (x_catch_errors): Remove duplicate declaration.
443
266c9547
PE
444 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
445
79c49ad2
PE
446 * xdisp.c, lisp.h (message_nolog): Remove; unused.
447
368f4090
JM
4482011-04-10 Jim Meyering <meyering@redhat.com>
449
450 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
451 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
452 return ssize_t not "int", and use size_t as the buffer length.
453 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
454 * gnutls.h: Update declarations.
455 * process.c (read_process_output): Use ssize_t, to match.
456 (send_process): Likewise.
457
a32d4040
CY
4582011-04-09 Chong Yidong <cyd@stupidchicken.com>
459
460 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
461
8546720e 4622011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 463
8546720e
GM
464 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
465 unsigned char, to match FcChar8 type definition.
aac0c6e3 466
8546720e
GM
467 * xterm.c (handle_one_xevent):
468 * xmenu.c (create_and_show_popup_menu):
469 * xselect.c (x_decline_selection_request)
470 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 471
a53e2e89
EZ
4722011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
473
474 Fix some uses of `int' instead of EMACS_INT.
475 * search.c (string_match_1, fast_string_match)
476 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
477 (scan_buffer, find_next_newline_no_quit)
478 (find_before_next_newline, search_command, Freplace_match)
479 (Fmatch_data): Make some `int' variables be EMACS_INT.
480
481 * xdisp.c (display_count_lines): 3rd argument and return value now
482 EMACS_INT. All callers changed.
483 (pint2hrstr): Last argument is now EMACS_INT.
484
485 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
486 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
487 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
488 (decode_coding_utf_16, decode_coding_emacs_mule)
489 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
490 (decode_coding_ccl, decode_coding_charset)
491 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
492 (decode_coding_iso_2022, decode_coding_emacs_mule)
493 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
494 <char_offset, last_offset>: Declare EMACS_INT.
495 (encode_coding_utf_8, encode_coding_utf_16)
496 (encode_coding_emacs_mule, encode_invocation_designation)
497 (encode_designation_at_bol, encode_coding_iso_2022)
498 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
499 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
500 Declare EMACS_INT.
501 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
502 (encode_invocation_designation): Last argument P_NCHARS is now
503 EMACS_INT.
504 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
505 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
506
507 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
508 All users changed.
509
510 * ccl.c (Fccl_execute_on_string): Declare some variables
511 EMACS_INT.
512
8546720e 5132011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
514
515 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
516
4e19a977
CS
5172011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
518
519 * process.c (Fformat_network_address): Doc fix.
520
87302331
R
5212011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
522
523 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
524
cbb59342
CY
5252011-04-08 Chong Yidong <cyd@stupidchicken.com>
526
527 * keyboard.c (read_char): Call Lisp function help-form-show,
528 instead of using internal_with_output_to_temp_buffer.
529 (Qhelp_form_show): New var.
e0d38eeb 530 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
531
532 * print.c (internal_with_output_to_temp_buffer): Function deleted.
533
534 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
535
e67a13ab
CY
5362011-04-06 Chong Yidong <cyd@stupidchicken.com>
537
538 * process.c (Flist_processes): Removed to Lisp.
539 (list_processes_1): Deleted.
540
973f782d
EZ
5412011-04-06 Eli Zaretskii <eliz@gnu.org>
542
7c106b1e
EZ
543 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
544
973f782d
EZ
545 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
546
41cf7d1a 5472011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 548
ca23cc88
PE
549 Fix more problems found by GCC 4.6.0's static checks.
550
f390e2d5
PE
551 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
552
42eea0d0
PE
553 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
554
b69769da 555 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 556
f9541e84
PE
557 * xdisp.c (vmessage): Mark as a printf-like function.
558
13841b55
PE
559 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
560
c136c10f
PE
561 * sound.c (sound_warning): Don't crash if arg contains a printf format.
562
5e2d4a30
PE
563 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
564 printf-like functions.
565 (tiff_load): Add casts to remove these marks before passing them
566 to system-supplied API.
567
583f48b9
PE
568 * eval.c (Fsignal): Remove excess argument to 'fatal'.
569
b25d760e
PE
570 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
571 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
572 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
573 directly, rather than having caller test rule sign. This avoids
574 some unnecessary tests.
575 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
576 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
577 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 578
bc7b6697 579 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 580 (xfont_open): Avoid unnecessary tests.
bc7b6697 581
27ccc379
PE
582 * composite.c (composition_gstring_put_cache): Use unsigned integer.
583
dcd5c89a
PE
584 * composite.h, composite.c (composition_gstring_put_cache):
585 Use EMACS_INT, not int, for length.
586
b13a45c6
PE
587 * composite.h (COMPOSITION_DECODE_REFS): New macro,
588 breaking out part of COMPOSITION_DECODE_RULE.
589 (COMPOSITION_DECODE_RULE): Use it.
590 * composite.c (get_composition_id): Remove unused local vars,
591 by using the new macro.
592
1e792e4d
PE
593 * textprop.c (set_text_properties_1): Change while to do-while,
594 since the condition is always true at first.
595
dc6c6455 596 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
597 (interval_deletion_adjustment): Return unsigned value.
598 All uses changed.
dc6c6455 599
aba7731a
PE
600 * process.c (list_processes_1, create_pty, read_process_output):
601 (exec_sentinel): Remove vars that were set but not used.
afd4052b 602 (create_pty): Remove unnecessary "volatile"s.
bc57d757 603 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 604 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 605 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 606
fdfc4bf3
PE
607 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
608
fca8fe46 609 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 610 (update_syntax_table): Use unsigned instead of int.
fca8fe46 611
06a0259a 612 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 613 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 614 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 615
e7b9e80f
PE
616 * print.c (print_error_message): Avoid int overflow.
617
56201685
PE
618 * font.c (font_list_entities): Redo for clarity,
619 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
620
78834453 621 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 622 (font_score): Avoid potential overflow in diff calculation.
78834453 623
0bc0b309 624 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 625 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 626
e610eaca
PE
627 * eval.c (funcall_lambda): Rename local to avoid shadowing.
628
b895abce
PE
629 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
630 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
631 can always succeed if overflow has undefined behavior.
632
1f1d9321 633 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 634 (wordify): Omit three unnecessary tests.
1f1d9321 635
c59478bc
PE
636 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
637 All callers changed. This avoids the need for an unused var.
638
79b73827
PE
639 * casefiddle.c (casify_region): Remove var that is set but not used.
640
a4db5dfe
PE
641 * dired.c (file_name_completion): Remove var that is set but not used.
642
43aae36e
PE
643 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
644
2a47c44d 645 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 646 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 647
a37c69bf
PE
648 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
649 Check for integer overflow on size calculations.
650
328ab8e7
PE
651 * buffer.c (Fprevious_overlay_change): Remove var that is set
652 but not used.
653
e5a2a5cb
PE
654 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
655 Remove vars that are set but not used.
8d84a6eb 656 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 657 (timer_check_2): Mark vars as initialized.
e5a2a5cb 658
a60e5f68
PE
659 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
660
f661cb61 661 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 662 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 663
f0397f5a
PE
664 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
665 that are set but not used.
666
8664db06 667 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 668 if XCreateBitmapFromData fails (Bug#8410).
8664db06 669
6abdaa4a
PE
670 * xselect.c (x_get_local_selection, x_handle_property_notify):
671 Remove vars that are set but not used.
672
0ce7538d 673 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 674 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 675
9ae848fc
PE
676 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
677 Remove var that is set but not used.
0b918413
PE
678 (scroll_bar_windows_size): Now size_t, not int.
679 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
680 Check for overflow.
9ae848fc 681
a5a62657
PE
682 * xfaces.c (realize_named_face): Remove vars that are set but not used.
683 (map_tty_color) [!defined MSDOS]: Likewise.
684
5c5cdd39
PE
685 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
686
66ebf983
PE
687 * coding.c: Remove vars that are set but not used.
688 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
689 All callers changed.
690 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
691 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
692 (decode_coding_charset): Remove vars that are set but not used.
693
1be4d761
PE
694 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
695 that is set but not used.
696
47553fa8
PE
697 * print.c (print_object): Remove var that is set but not used.
698
1f7196bf 699 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
700 The gnulib version avoids calling malloc in the usual case,
701 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
702 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
703 * filelock.c (current_lock_owner): Likewise.
704 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
705 * sysdep.c: Include allocator.h, careadlinkat.h.
706 (emacs_no_realloc_allocator): New static constant.
707 (emacs_readlink): New function.
fdb61804
PE
708 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
709 ../lib/careadlinkat.h.
d1fdcab7 710
f84c17c7
SM
7112011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
712
713 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
714 first non-nil return value).
715
ef3862ad
JD
7162011-04-03 Jan Djärv <jan.h.d@swipnet.se>
717
718 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
719 if not defined (Bug#8403).
720
376a7006
JB
7212011-04-02 Juanma Barranquero <lekktu@gmail.com>
722
723 * xdisp.c (display_count_lines): Remove parameter `start',
724 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
725 (get_char_face_and_encoding): Remove parameter `multibyte_p',
726 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
727 (fill_stretch_glyph_string): Remove parameters `row' and `area',
728 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
729 and thereabouts. All callers changed.
730 (get_per_char_metric): Remove parameter `f', unused since
731 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
732
6ca3801d
JM
7332011-04-02 Jim Meyering <meyering@redhat.com>
734
735 do not dereference NULL upon failed strdup
736 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
737 (ns_get_family): Likewise.
738
d8e2b5ba
JB
7392011-04-02 Juanma Barranquero <lekktu@gmail.com>
740
741 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
742
8c74fcbd
JD
7432011-04-02 Jan Djärv <jan.h.d@swipnet.se>
744
745 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
746 later (Bug#8403).
747
7200d79c
SM
7482011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
749
03408648 750 Add lexical binding.
7200d79c 751
03408648
SM
752 * window.c (Ftemp_output_buffer_show): New fun.
753 (Fsave_window_excursion):
754 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
755
756 * lread.c (lisp_file_lexically_bound_p): New function.
757 (Fload): Bind Qlexical_binding.
758 (readevalloop): Remove `evalfun' arg.
759 Bind Qinternal_interpreter_environment.
760 (Feval_buffer): Bind Qlexical_binding.
761 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
762 Mark as dynamic.
763 (syms_of_lread): Declare `lexical-binding'.
764
765 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
766
767 * keyboard.c (eval_dyn): New fun.
768 (menu_item_eval_property): Use it.
ca105506
SM
769
770 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 771
03408648
SM
772 * fns.c (concat, mapcar1): Accept byte-code-functions.
773
774 * eval.c (Fsetq): Handle lexical vars.
775 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
776 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
777 (FletX, Flet): Obey lexical binding.
778 (Fcommandp): Handle closures.
779 (Feval): New `lexical' arg.
780 (eval_sub): New function extracted from Feval. Use it almost
781 everywhere where Feval was used. Look up vars in lexical env.
782 Handle closures.
783 (Ffunctionp): Move from subr.el.
784 (Ffuncall): Handle closures.
785 (apply_lambda): Remove `eval_flags'.
786 (funcall_lambda): Handle closures and new byte-code-functions.
787 (Fspecial_variable_p): New function.
788 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
789 but without exporting it to Lisp.
23aba0ea 790
23aba0ea 791 * doc.c (Fdocumentation, store_function_docstring):
03408648 792 * data.c (Finteractive_form): Handle closures.
23aba0ea 793
03408648
SM
794 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
795 interactive spec.
ba83908c 796
03408648
SM
797 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
798 byte-codes.
799 (exec_byte_code): New function extracted from Fbyte_code to handle new
800 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 801
03408648 802 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 803
03408648 804 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 805
e2abce01
JB
8062011-03-31 Juanma Barranquero <lekktu@gmail.com>
807
808 * xdisp.c (redisplay_internal): Fix prototype.
809
63696a73 8102011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 811
63696a73
EZ
812 * xdisp.c (SCROLL_LIMIT): New macro.
813 (try_scrolling): Use it when setting scroll_limit. Limit
814 scrolling to 100 screen lines.
815 (redisplay_window): Even when falling back on "recentering",
816 position point in the window according to scroll-conservatively,
817 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
818
819 (try_scrolling): When point is above the window, allow searching
820 as far as scroll_max, or one screenful, to compute vertical
821 distance from PT to the scroll margin position. This prevents
822 try_scrolling from unnecessarily failing when
823 scroll-conservatively is set to a value slightly larger than the
824 window height. Clean up the case of PT below the margin at bottom
825 of window: scroll_max can no longer be INT_MAX. When aggressive
826 scrolling is in use, don't let point enter the opposite scroll
827 margin as result of the scroll.
828 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
829 threshold of 100 lines for never-recentering scrolling.
830
e4cc2dfc
JB
8312011-03-31 Juanma Barranquero <lekktu@gmail.com>
832
833 * dispextern.h (move_it_by_lines):
834 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
835 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
836 (message_log_check_duplicate): Remove parameters `prev_bol' and
837 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
838 (redisplay_internal): Remove parameter `preserve_echo_area',
839 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
840
841 * indent.c (Fvertical_motion):
842 * window.c (window_scroll_pixel_based, Frecenter):
843 Don't pass `need_y_p' to `move_it_by_lines'.
844
1c470562
SM
8452011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
846
44f230aa
SM
847 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
848 steal a few bits to be more compact.
849 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
850 Remove unneeded casts.
851
1c470562
SM
852 * bytecode.c (Fbyte_code): CAR and CDR can GC.
853
888adce9
ZK
8542011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
855
856 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
857 binding" message (bug#7967).
858
f838ed7b
PE
8592011-03-30 Paul Eggert <eggert@cs.ucla.edu>
860
77861b95
PE
861 Fix more problems found by GCC 4.6.0's static checks.
862
de6dbc14
PE
863 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
864 Remove unused local var.
865
f838ed7b
PE
866 * editfns.c (Fmessage_box): Remove unused local var.
867
792c7b2b
PE
868 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
869 (note_mode_line_or_margin_highlight, note_mouse_highlight):
870 Omit unused local vars.
c499e557 871 * window.c (shrink_windows): Omit unused local var.
b01a1c29 872 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
873 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
874 Omit unused local var.
875
ba0165e1
PE
876 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
877 Don't assume string length fits in int.
32ad8845 878 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 879 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 880
3c59b4c9
PE
881 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
882 instead of alloca (Bug#8344).
883
a3eed478 884 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 885 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 886
eb4d412d
PE
887 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
888
1658b401
PE
889 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
890 concerns.
891
892 * term.c (produce_glyphless_glyph): Remove unnecessary test.
893
894 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 895
9a2c6e05
PE
896 * keyboard.c (syms_of_keyboard): Use the same style as later
897 in this function when indexing through an array. This also
898 works around GCC bug 48267.
899
03d0a109
PE
900 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
901
44f730c8
PE
902 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
903
fe75f926
PE
904 * chartab.c (sub_char_table_ref_and_range): Redo for slight
905 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
906
ffa8c828
PE
907 * keyboard.c, keyboard.h (num_input_events): Now size_t.
908 This avoids undefined behavior on integer overflow, and is a bit
909 more convenient anyway since it is compared to a size_t variable.
910
c5101a77
PE
911 Variadic C functions now count arguments with size_t, not int.
912 This avoids an unnecessary limitation on 64-bit machines, which
913 caused (substring ...) to crash on large vectors (Bug#8344).
914 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
915 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 916 All variadic functions and their callers changed accordingly.
c5101a77
PE
917 (struct gcpro.nvars): Now size_t, not int. All uses changed.
918 * data.c (arith_driver, float_arith_driver): Likewise.
919 * editfns.c (general_insert_function): Likewise.
920 * eval.c (struct backtrace.nargs, interactive_p)
921 (internal_condition_case_n, run_hook_with_args, apply_lambda)
922 (funcall_lambda, mark_backtrace): Likewise.
923 * fns.c (concat): Likewise.
924 * frame.c (x_set_frame_parameters): Likewise.
925 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
926 0 if not found, not -1. All callers changed.
927
dd3f25f7
PE
928 * alloc.c (garbage_collect): Don't assume stack size fits in int.
929 (stack_copy_size): Now size_t, not int.
930 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
931
461c2ab9
JB
9322011-03-28 Juanma Barranquero <lekktu@gmail.com>
933
934 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
935 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
936 All callers changed.
937
938 * lisp.h (multibyte_char_to_unibyte):
939 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
940 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
941 * character.h (CHAR_TO_BYTE8):
942 * cmds.c (internal_self_insert):
943 * editfns.c (general_insert_function):
944 * keymap.c (push_key_description):
945 * search.c (Freplace_match):
946 * xdisp.c (message_dolog, set_message_1): All callers changed.
947
f6d62986
SM
9482011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
949
950 * keyboard.c (safe_run_hook_funcall): New function.
951 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
952 don't set the hook to nil, but remove the offending function instead.
953 (Qcommand_hook_internal): Remove, unused.
954 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
955 Vcommand_hook_internal.
956
957 * eval.c (enum run_hooks_condition): Remove.
958 (funcall_nil, funcall_not): New functions.
959 (run_hook_with_args): Call each function through a `funcall' argument.
960 Remove `cond' argument, now redundant.
961 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
962 (Frun_hook_with_args_until_failure): Adjust accordingly.
963 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
964
1db5b1ad
JB
9652011-03-28 Juanma Barranquero <lekktu@gmail.com>
966
967 * dispextern.h (string_buffer_position): Remove declaration.
968
969 * print.c (strout): Remove parameter `multibyte', unused since
970 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
971
972 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
973 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
974 All callers changed.
975
976 * w32.c (_wsa_errlist): Use braces for struct initializers.
977
978 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
979 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
980 All callers changed.
981 (string_buffer_position): Likewise. Also, make static (it's never
982 used outside xdisp.c).
983 (cursor_row_p): Remove parameter `w', unused since
984 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
985 (decode_mode_spec): Remove parameter `precision', introduced during
986 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
987 All callers changed.
988
5ffb62aa
JD
9892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
990
991 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
992
461c2ab9 9932011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
994
995 * nsterm.m (ns_menu_bar_is_hidden): New variable.
996 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
997 (ns_update_auto_hide_menu_bar): New functions.
998 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
999 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1000 ns_constrain_all_frames.
1001 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1002 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1003
5c380ffb
JD
10042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1005
1006 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1007
9af30bdf
GM
10082011-03-27 Glenn Morris <rgm@gnu.org>
1009
1010 * syssignal.h: Replace RETSIGTYPE with void.
1011 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1012 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1013 Replace SIGTYPE with void everywhere.
1014 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1015 * s/template.h (SIGTYPE): Remove commented out definition.
1016
e2abce01
JB
10172011-03-26 Eli Zaretskii <eliz@gnu.org>
1018
1019 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1020 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1021
f868cd8a
JB
10222011-03-26 Juanma Barranquero <lekktu@gmail.com>
1023
59eb0929
JB
1024 * w32.c (read_unc_volume): Use parameter `henum', instead of
1025 global variable `wget_enum_handle'.
1026
1027 * keymap.c (describe_vector): Remove parameters `indices' and
1028 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1029 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1030
f868cd8a
JB
1031 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1032
1033 * keyboard.c (timer_check): Remove parameter `do_it_now',
1034 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1035 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1036 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1037
1038 * keyboard.c (read_char):
1039 * w32menu.c (w32_menu_display_help):
1040 * xmenu.c (show_help_event, menu_help_callback):
1041 Adjust calls to `show_help_echo'.
1042
1043 * gtkutil.c (xg_maybe_add_timer):
1044 * keyboard.c (readable_events):
1045 * process.c (wait_reading_process_output):
1046 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1047
1048 * insdel.c (adjust_markers_gap_motion):
1049 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1050 (gap_left, gap_right): Don't call it.
1051
2ecf6fdb
CY
10522011-03-25 Chong Yidong <cyd@stupidchicken.com>
1053
1054 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1055 incurred during fontification.
1056
6b1f9ba4
JB
10572011-03-25 Juanma Barranquero <lekktu@gmail.com>
1058
1059 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1060 (DEFVAR_PER_BUFFER): Don't pass it.
1061
1062 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1063 (scrolling_window): Don't pass it.
1064
0f4a96b5
JB
10652011-03-25 Juanma Barranquero <lekktu@gmail.com>
1066
1067 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1068
1069 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1070 and `suffix'.
1071 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1072 of variables specific to SELinux and computation of `encoded_absname'.
1073
1074 * image.c (XPutPixel): Remove unused variable `height'.
1075
1076 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1077
1078 * unexw32.c (get_section_info): Remove unused variable `section'.
1079
1080 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1081 (system_process_attributes): Remove unused variable `sess'.
1082 (sys_read): Remove unused variable `err'.
1083
1084 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1085 (w32_wnd_proc): Remove unused variable `isdead'.
1086 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1087 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1088 (x_create_tip_frame): Remove unused variable `tem'.
1089
1090 * w32inevt.c (w32_console_read_socket):
1091 Remove unused variable `no_events'.
1092
1093 * w32term.c (x_draw_composite_glyph_string_foreground):
1094 Remove unused variable `width'.
1095
1149507c
JB
10962011-03-24 Juanma Barranquero <lekktu@gmail.com>
1097
1098 * w32term.c (x_set_glyph_string_clipping):
1099 Don't pass uninitialized region to CombineRgn.
1100
9c88f339
JB
11012011-03-23 Juanma Barranquero <lekktu@gmail.com>
1102
1103 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1104 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1105 (Fx_close_connection): Remove unused variable `i'.
1106
1107 * w32font.c (w32font_draw): Return number of glyphs.
1108 (w32font_open_internal): Remove unused variable `i'.
1109 (w32font_driver): Add missing initializer.
1110
1111 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1112 (fill_in_menu): Remove unused variable `items_added'.
1113
1114 * w32term.c (last_mouse_press_frame): Remove static global variable.
1115 (w32_clip_to_row): Remove unused variable `f'.
1116 (x_delete_terminal): Remove unused variable `i'.
1117
1118 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1119 (NOTHING): Remove unused static global variable.
1120 (uniscribe_check_otf): Remove unused variable `table'.
1121 (uniscribe_font_driver): Add missing initializers.
1122
dee091a3
JD
11232011-03-23 Julien Danjou <julien@danjou.info>
1124
1125 * term.c (Fsuspend_tty, Fresume_tty):
1126 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1127 * window.c (temp_output_buffer_show):
1128 * insdel.c (signal_before_change):
1129 * frame.c (Fhandle_switch_frame):
1130 * fileio.c (Fdo_auto_save):
1131 * emacs.c (Fkill_emacs):
1132 * editfns.c (save_excursion_restore):
1133 * cmds.c (internal_self_insert):
1134 * callint.c (Fcall_interactively):
1135 * buffer.c (Fkill_all_local_variables):
1136 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1137 Use Frun_hooks.
0f4a96b5 1138 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1139 unconditionnaly since it does the check itself.
1140
2c520ab5 11412011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1142
c9c49752
PE
1143 Fix more problems found by GCC 4.5.2's static checks.
1144
8abc3f12
PE
1145 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1146 the first time through the loop, since we know p0 < p1 then.
1147 This also avoids a gcc -Wstrict-overflow warning.
1148
a2d26660
PE
1149 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1150 leading to a memory leak, possible in functions like
1151 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1152 of objects (Bug#8318).
a2d26660 1153
916c72e9
PE
1154 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1155 that could (at least in theory) be that large.
1156
19ab8a18
PE
1157 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1158 This is less likely to overflow, and avoids undefined behavior if
1159 overflow does occur. All callers changed. Use strtoul to scan
1160 for the unsigned long integer.
b7cbbd6f
PE
1161 (pint2hrstr): Simplify and tune code slightly.
1162 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1163
f0641eff
PE
1164 * scroll.c (do_scrolling): Work around GCC bug 48228.
1165 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1166
7f650bb9
PE
1167 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1168 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1169 (validate_x_resource_name): Simplify count usage.
1170 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1171
37dd57d1
PE
1172 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1173 fail (Bug#8306).
81e56e61 1174
699979fc 1175 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1176
401bf9b4
PE
1177 * process.c (Fmake_network_process): Use socklen_t, not int,
1178 where POSIX says socklen_t is required in portable programs.
1179 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1180 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1181 (Fmake_network_process, server_accept_connection):
1182 (wait_reading_process_output, read_process_output):
1183 Likewise.
1184
b93aacde
PE
1185 * process.c: Rename or move locals to avoid shadowing.
1186 (list_processes_1, Fmake_network_process):
1187 (read_process_output_error_handler, exec_sentinel_error_handler):
1188 Rename or move locals.
4dc343ee 1189 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1190 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1191 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1192 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1193 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1194
af8a867c 1195 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1196 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1197 Include tparam.h instead, since it declares them.
af8a867c
PE
1198 * cm.h (PC): Remove extern decl; tparam.h now does this.
1199 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1200 * terminfo.c: Include tparam.h, to check interfaces.
1201 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1202 (tparam): Adjust signature to match interface in tparam.h;
1203 this removes some undefined behavior. Check that outstring and len
1204 are zero, which they always are with Emacs.
1205 * tparam.h (PC, BC, UP): New extern decls.
1206
0248044d 1207 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1208 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1209
8ff096c1 1210 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1211 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1212 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1213 (ftfont_list): Remove unused local.
49eaafba
PE
1214 (get_adstyle_property, ftfont_pattern_entity):
1215 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1216 Rename locals to avoid shadowing.
8ff096c1 1217
e2be39f6
PE
1218 * xfont.c (xfont_list_family): Mark var as initialized.
1219
c9735e30
PE
1220 * xml.c (make_dom): Now static.
1221
8f5201ae
PE
1222 * composite.c (composition_compute_stop_pos): Rename local to
1223 avoid shadowing.
b246f932
PE
1224 (composition_reseat_it): Remove unused locals.
1225 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1226 (composition_update_it): Mark var as initialized.
11b61122
PE
1227 (find_automatic_composition): Mark vars as initialized,
1228 with a FIXME (Bug#8290).
8f5201ae 1229
760fbc2c
PE
1230 character.h: Rename locals to avoid shadowing.
1231 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1232 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1233 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1234 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1235 to avoid shadowing.
1236
ff08eb85
PE
1237 * textprop.c (property_change_between_p): Remove; unused.
1238
fc7bf025
PE
1239 * intervals.c (interval_start_pos): Now static.
1240
235d7abc
PE
1241 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1242
44f230aa
SM
1243 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1244 Rename locals to avoid shadowing.
3e7d6594 1245
50060332
PE
1246 * sound.c (wav_play, au_play, Fplay_sound_internal):
1247 Fix pointer signedness.
d01f234b 1248 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1249 (wav_play): Initialize a variable to 0, to prevent undefined
1250 behavior (Bug#8278).
50060332 1251
c4fc4e30
PE
1252 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1253
918436ed
PE
1254 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1255
c939f91b
PE
1256 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1257 clobbering (Bug#8298).
b9c7f648
PE
1258 * sysdep.c (sys_subshell): Likewise.
1259 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1260
6bd8c144
PE
1261 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1262 This should get cleaned up, so that child_setup has the
1263 same signature on all platforms.
1264
7710357c 1265 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1266 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1267
c59da222
CY
12682011-03-22 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1271 not to be necessary, and produces flickering.
1272
66b87493
GM
12732011-03-20 Glenn Morris <rgm@gnu.org>
1274
1275 * config.in: Remove file.
1276
45b6f6d5
JB
12772011-03-20 Juanma Barranquero <lekktu@gmail.com>
1278
1279 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1280 are now in src/globals.h.
1281 (syms_of_minibuf): Remove spurious & from previous change.
1282
3ec03f7e
LL
12832011-03-20 Leo <sdl.web@gmail.com>
1284
1285 * minibuf.c (completing-read-function): New variable.
1286 (completing-read-default): Rename from completing-read.
1287 (completing-read): Call completing-read-function.
1288
b14e3e21
CY
12892011-03-19 Juanma Barranquero <lekktu@gmail.com>
1290
1291 * xfaces.c (Fx_load_color_file):
1292 Read color file from absolute filename (bug#8250).
1293
f2b726e6
JB
12942011-03-19 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * makefile.w32-in: Update dependencies.
1297
09f6ff02
EZ
12982011-03-17 Eli Zaretskii <eliz@gnu.org>
1299
1300 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1301
29a6015a
PE
13022011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1303
a3a6c54e
PE
1304 Fix more problems found by GCC 4.5.2's static checks.
1305
b766f867
PE
1306 * process.c (make_serial_process_unwind, send_process_trap):
1307 (sigchld_handler): Now static.
1308
be02381c
PE
1309 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1310 That way, the code declares only the vars that it needs.
1311 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1312 * s/cygwin.h (PTY_ITERATION): Likewise.
1313 * s/darwin.h (PTY_ITERATION): Likewise.
1314 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1315
57048744
PE
1316 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1317 * process.c (allocate_pty): Don't declare stb unless it's needed.
1318
7914961c 1319 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1320 (CONSTANTLIM): Remove; unused.
1321 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1322 Define only if needed.
7914961c 1323
b3967b18
PE
1324 * unexelf.c (unexec): Name an expression,
1325 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1326 Use a different way to cause a compilation error if anyone uses
1327 n rather than nn, a way that does not involve shadowing.
73366a00 1328 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1329
29a6015a
PE
1330 * deps.mk (unexalpha.o): Remove; unused.
1331
43cfc33e 1332 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1333 * unexec.h: New file.
ce701a33
PE
1334 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1335 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1336 Depend on unexec.h.
1337 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1338 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1339 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1340 Change as necessary to match prototype in unexec.h.
ce701a33 1341
01f44d5a
PE
1342 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1343 shadowing.
4f63c6bb 1344 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1345
a6670b0b
PE
1346 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1347 Rename locals to avoid shadowing.
1348
cef2010d 1349 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1350 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1351
d4d7173a
PE
1352 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1353
f08b802a
PE
1354 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1355 warning when compiling print.c.
1356
3ddb0639
PE
1357 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1358 instead of using an uninitialized var.
5ad03b97 1359 (font_sort_entities): Mark var as initialized.
3ddb0639 1360
170a2692
PE
1361 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1362
e663c700
PE
1363 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1364 pointers to constants.
89bc529a 1365 (font_parse_fcname): Remove unused vars.
7b81e2d0 1366 (font_delete_unmatched): Now static.
ea838e10 1367 (font_get_spec): Remove; unused.
13a547c6
PE
1368 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1369 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1370 Rename or move locals to avoid shadowing.
e663c700 1371
2a80c887 1372 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1373 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1374
1384fa33 1375 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1376 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1377
8b2c52e9
PE
1378 * alloc.c (mark_backtrace): Move decl from here ...
1379 * lisp.h: ... to here, so that it can be checked.
1380
475545b5 1381 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1382 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1383 (lisp_indirect_variable): Name an expression,
1384 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1385 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1386
b1349114 1387 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1388 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1389 Use const pointer when appropriate.
b1349114 1390
a2928364
PE
1391 * lisp.h (get_system_name, get_operating_system_release):
1392 Move decls here, to check interfaces.
1393 * process.c (get_operating_system_release): Move decl to lisp.h.
1394 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1395 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1396 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1397 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1398 (Fformat_time_string, Fencode_time, Finsert_char):
1399 (Ftranslate_region_internal, Fformat):
1400 Rename or remove local vars to avoid shadowing.
9710023e 1401 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1402
a415e694
PE
1403 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1404 avoid shadowing.
1405
8ef4622d
PE
1406 * lisp.h (eassert): Check that the argument compiles, even if
1407 ENABLE_CHECKING is not defined.
1408
946f9a5b
PE
1409 * data.c (Findirect_variable): Name an expression, to avoid
1410 gcc -Wbad-function-cast warning.
112396d6 1411 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1412 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1413 (Fmake_variable_buffer_local, Fmake_local_variable):
1414 Mark variables as initialized.
52746918 1415 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1416
e5aab7e7 1417 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1418 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1419 Rename locals to avoid shadowing.
dff45157
PE
1420 (mark_stack): Move local variables into the #ifdef region where
1421 they're used.
7bc26fdb
PE
1422 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1423 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1424 needed otherwise.
1425 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1426 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1427 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1428
e5aab7e7
PE
1429 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1430 avoids undefined behavior in theory.
1431
4da60324
PE
1432 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1433
88043301
PE
1434 Use functions, not macros, for up- and down-casing (Bug#8254).
1435 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1436 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1437 to use the following functions instead of these macros.
1438 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1439 EMACS_INT, since callers assume the returned value fits in int.
1440 (upcase1): Likewise, for UPCASE_TABLE.
1441 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1442 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1443 the race-condition problem in the old DOWNCASE.
88043301 1444
19ed5445
PE
1445 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1446 Rename locals to avoid shadowing.
1447 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1448 (regex_compile, re_search_2, re_match_2_internal):
1449 Remove unused local vars.
952db0d7
PE
1450 (FREE_VAR): Rewrite so as not to use empty "else",
1451 which gcc can warn about.
da053e48 1452 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1453 (RETALLOC_IF): Define only if needed.
1454 (WORDCHAR_P): Likewise. This one is never needed, but is used
1455 only in a comment talking about a compiler bug, so put inside
1456 the #if 0 of that comment.
1457 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1458 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1459 Remove; unused.
19ed5445 1460
1f3561e4 1461 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1462 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1463 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1464
ded6f8f7
PE
1465 * search.c (simple_search): Remove unused var.
1466
dbd37a95
PE
1467 * dired.c (compile_pattern): Move decl from here ...
1468 * lisp.h: ... to here, so that it can be checked.
1469 (struct re_registers): New forward decl.
1470
7e47afad
PE
1471 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1472
85f24f61
PE
1473 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1474 All uses changed.
1475 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1476 Rename locals to avoid shadowing.
5671df8f 1477 (Fvertical_motion): Mark locals as initialized.
85f24f61 1478
181aa2be 1479 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1480 (casify_region): Mark local as initialized.
181aa2be 1481
930d429c
PE
1482 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1483
7082eac6
PE
1484 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1485 New macros, so that the caller can use some names other than
1486 gcpro1, gcpro2, etc.
1487 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1488 of the new macros.
1489 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1490 argument, for consistency with GCPRO2_VAR, etc: it is now the
1491 prefix of the variable, not the variable itself. All uses
1492 changed.
38b2c076
PE
1493 * dired.c (directory_files_internal, file_name_completion):
1494 Rename locals to avoid shadowing.
1495
15206ed9
PE
1496 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1497 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1498 dired.c's scmp function, had undefined behavior.
1499 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1500 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1501 * buffer.h: ... to here, because these macros use current_buffer,
1502 and the new implementation with inline functions needs to have
1503 current_buffer in scope now, rather than later when the macros
1504 are used.
1505 (downcase, upcase1): New static inline functions.
1506 (DOWNCASE, UPCASE1): Reimplement using these functions.
1507 This avoids undefined behavior in expressions like
1508 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1509 from race conditions in accessing the global variables
1510 case_temp1 and case_temp2.
1511 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1512 * lisp.h (case_temp1, case_temp2): Remove their decls.
1513 * character.h (ASCII_CHAR_P): Move from here ...
1514 * lisp.h: ... to here, so that the inline functions mentioned
1515 above can use them.
1516
4a6bea26
PE
1517 * dired.c (directory_files_internal_unwind): Now static.
1518
f14b7e14
PE
1519 * fileio.c (file_name_as_directory, directory_file_name):
1520 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1521 Now static.
2893f146
PE
1522 (file_name_as_directory): Use const pointers when appropriate.
1523 (Fexpand_file_name): Likewise. In particular, newdir might
1524 point at constant storage, so make it a const pointer.
fd4ead52 1525 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1526 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1527 signedness issues.
f839df0c
PE
1528 (Fset_file_times, Finsert_file_contents, auto_save_error):
1529 Rename locals to avoid shadowing.
f14b7e14 1530
5716756e 1531 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1532 (Ftry_completion, Fall_completions): Rename or remove locals
1533 to avoid shadowing.
5716756e 1534
b4c3046a
PE
1535 * marker.c (bytepos_to_charpos): Remove; unused.
1536
b45db522
PE
1537 * lisp.h (verify_bytepos, count_markers): New decls,
1538 so that gcc does not warn that these functions aren't declared.
1539
85876d07
PE
1540 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1541 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1542 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1543 (copy_text): Remove unused local var.
85876d07 1544
03d78a21 1545 * filelock.c (within_one_second): Now static.
b3dd38ab 1546 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1547
5df8f01b
PE
1548 * buffer.c (fix_overlays_before): Mark locals as initialized.
1549 (fix_start_end_in_overlays): Likewise. This function should be
1550 simplified by using pointers-to-pointers, but that's a different
1551 matter.
b1d876f1 1552 (switch_to_buffer_1): Now static.
8f54f30a
PE
1553 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1554 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1555
a70072c9 1556 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1557 Fix pointer signedness issue.
edced198
PE
1558 (sys_subshell): Mark local as volatile if checking for lint,
1559 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1560 (MAXPATHLEN): Define only if needed.
a70072c9 1561
a0977c44
PE
1562 * process.c (serial_open, serial_configure): Move decls from here ...
1563 * systty.h: ... to here, so that they can be checked.
1564
a884fdcc
PE
1565 * fns.c (get_random, seed_random): Move extern decls from here ...
1566 * lisp.h: ... to here, so that they can be checked.
1567
604efe86 1568 * sysdep.c (reset_io): Now static.
b8950c94 1569 (wait_for_termination_signal): Remove; unused.
604efe86 1570
38fc62d9
PE
1571 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1572 (copy_keymap_item, append_key, push_text_char_description):
1573 Now static.
1004a21a 1574 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1575 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1576 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1577 (describe_map_tree):
1578 Rename locals to avoid shadowing.
38fc62d9 1579
2f2650da
PE
1580 * keyboard.c: Declare functions static if they are not used elsewhere.
1581 (echo_char, echo_dash, cmd_error, top_level_2):
1582 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1583 (read_char, kbd_buffer_get_event, make_lispy_position):
1584 (make_lispy_event, make_lispy_movement, apply_modifiers):
1585 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1586 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1587 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1588 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1589 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1590
a053e86c 1591 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1592 (mark_kboards): Move decl here ...
1593 * alloc.c (mark_kboards): ... from here.
a053e86c 1594
4752793e
PE
1595 * lisp.h (force_auto_save_soon): New decl.
1596
74f10ca7 1597 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1598 (DEFINE_DUMMY_FUNCTION): New macro.
1599 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1600 Use it.
c03cd23f
PE
1601 (main): Add casts to avoid warnings
1602 if GCC considers string literals to be constants.
74f10ca7 1603
022e70d4
PE
1604 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1605
59d6fe83
PE
1606 * dbusbind.c: Pointer signedness fixes.
1607 (xd_signature, xd_append_arg, xd_initialize):
1608 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1609 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1610 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1611 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1612
78320123
PE
1613 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1614 if GCC considers string literals to be constants.
49cebcca 1615 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1616
35ac2a97
SM
16172011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1618
fb103ca9
SM
1619 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1620 (print_preprocess, print_object): New macro to fix last change.
1621
35ac2a97
SM
1622 * print.c (print_preprocess): Don't forget font objects.
1623
62973b41
JB
16242011-03-16 Juanma Barranquero <lekktu@gmail.com>
1625
1626 * emacs.c (USAGE3): Doc fixes.
1627
0e48bb22
AS
16282011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1629
1630 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1631 structure.
1632
7684e57b
JB
16332011-03-14 Juanma Barranquero <lekktu@gmail.com>
1634
1635 * lisp.h (VWindow_system, Qfile_name_history):
1636 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1637 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1638 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1639
1640 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1641 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1642
1643 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1644 * w32console.c (detect_input_pending, read_input_pending)
1645 (encode_terminal_code):
1646 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1647 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1648 (w32_system_caret_y, Qfile_name_history):
1649 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1650 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1651 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1652 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1653 * w32proc.c (Qlocal, report_file_error):
1654 * w32term.c (Vwindow_system, updating_frame):
1655 * w32uniscribe.c (initialized, uniscribe_font_driver):
1656 Remove unneeded extern declarations.
1657
2aa46d6c
CY
16582011-03-14 Chong Yidong <cyd@stupidchicken.com>
1659
c96bbc66 1660 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1661
cffc6f3b
CY
16622011-03-13 Chong Yidong <cyd@stupidchicken.com>
1663
1664 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1665 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1666 These macros can no longer be used for assignment.
1667
44f230aa
SM
1668 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1669 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1670 (record_buffer_markers, fetch_buffer_markers): New functions for
1671 recording and fetching special buffer markers.
1672 (set_buffer_internal_1, set_buffer_temp): Use them.
1673
1674 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1675
1676 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1677
1678 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1679 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1680
1681 * xdisp.c (hscroll_window_tree):
1682 (reconsider_clip_changes): Use PT instead of BUF_PT.
1683
d251f04b
EZ
16842011-03-13 Eli Zaretskii <eliz@gnu.org>
1685
1686 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1687 $(EMACS_ROOT)/lib/intprops.h.
1688
f0c77cd1
PE
16892011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1690
3eca4629
PE
1691 Fix more problems found by GCC 4.5.2's static checks.
1692
7c86ee98
PE
1693 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1694 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1695 (xg_free_frame_widgets): Make it clear that a local variable is
1696 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1697 (gdk_window_get_screen): Make it clear that this macro is needed
1698 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1699 (int_gtk_range_get_value): New function, which avoids a diagnostic
1700 from gcc -Wbad-function-cast.
1701 (xg_set_toolkit_scroll_bar_thumb): Use it.
1702 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1703 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1704 (get_utf8_string, xg_get_file_with_chooser):
1705 Rename locals to avoid shadowing.
1706 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1707
41729b81
PE
1708 * xgselect.c (xg_select): Remove unused var.
1709
f0c77cd1
PE
1710 * image.c (four_corners_best): Mark locals as initialized.
1711 (gif_load): Initialize transparent_p to zero (Bug#8238).
1712 Mark another local as initialized.
ec6cf4c6 1713 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1714
ce0ad53d 1715 * image.c (clear_image_cache): Now static.
d5d5a617 1716 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1717 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1718 (x_edge_detection): Remove unnecessary cast that
1719 gcc -Wbad-function-cast diagnoses.
2037898d 1720 (gif_load): Fix pointer signedness.
6ae141d6
PE
1721 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1722 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1723
33383987 17242011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1725
d32df629
PE
1726 Improve quality of tests for time stamp overflow.
1727 For example, without this patch (encode-time 0 0 0 1 1
1728 1152921504606846976) returns the obviously-bogus value (-948597
1729 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1730 reports time overflow. See
1731 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1732 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1733 * editfns.c: Include limits.h and intprops.h.
1734 (TIME_T_MIN, TIME_T_MAX): New macros.
1735 (time_overflow): Move earlier, to before first use.
1736 (hi_time, lo_time): New functions, for an accurate test for
1737 out-of-range times.
1738 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1739 (Fget_internal_run_time): Don't assume time_t fits in int.
1740 (make_time): Use list2 instead of Fcons twice.
1741 (Fdecode_time): More accurate test for out-of-range times.
1742 (check_tm_member): New function.
1743 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1744 (lisp_time_argument): Don't rely on undefined left-shift and
1745 right-shift behavior when checking for time stamp overflow.
8be6f318 1746
fe31d94c
PE
1747 * editfns.c (time_overflow): New function, refactoring common code.
1748 (Fformat_time_string, Fdecode_time, Fencode_time):
1749 (Fcurrent_time_string): Use it.
1750
8be6f318
PE
1751 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1752 * dired.c (make_time): Move to ...
1753 * editfns.c (make_time): ... here.
1754 * systime.h: Note the move.
1755
09d9db2c 17562011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1757
126bc0dc
YM
1758 * fringe.c (update_window_fringes): Remove unused variables.
1759
c47cbdfd
YM
1760 * unexmacosx.c (copy_data_segment): Also copy __got section.
1761 (Bug#8223)
1762
7ac80be9
EZ
17632011-03-12 Eli Zaretskii <eliz@gnu.org>
1764
c96bbc66 1765 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1766 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1767 Constify `char *' arguments and their references according to
1768 prototypes in tparam.h.
1769
ecb0f94d 1770 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1771
7ac80be9
EZ
1772 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1773 Adapt all references accordingly.
1774
1775 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1776
ef1fd07e
TT
17772011-03-11 Tom Tromey <tromey@redhat.com>
1778
1779 * buffer.c (syms_of_buffer): Remove obsolete comment.
1780
7ef4b50c
EZ
17812011-03-11 Eli Zaretskii <eliz@gnu.org>
1782
1783 * termhooks.h (encode_terminal_code): Declare prototype.
1784
1785 * msdos.c (encode_terminal_code): Don't declare prototype.
1786
1787 * term.c (encode_terminal_code): Now external again, used by
1788 w32console.c and msdos.c.
1789
44f230aa
SM
1790 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1791 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1792
4b1ec863 17932011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1794
1714f52b 1795 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1796
4b1ec863
PE
1797 * fringe.c (update_window_fringes): Mark locals as initialized
1798 (Bug#8227).
1799 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1800
524c7aa6
PE
1801 * alloc.c (mark_fringe_data): Move decl from here ...
1802 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1803 to check its interface.
1804 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1805
a5c0af81 1806 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1807 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1808 (fontset_font): Mark local as initialized.
a9a06e0b 1809 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1810
b4716021
PE
1811 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1812
811e9bac 1813 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1814 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1815 (x_own_selection, Fx_disown_selection_internal): Rename locals
1816 to avoid shadowing.
1817 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1818
7e3ab302
PE
1819 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1820 so that the caller can use some name other than gcpro1.
1821 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1822 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1823 (Fx_backspace_delete_keys_p):
1824 Use them to avoid shadowing, and rename vars to avoid shadowing.
1825 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1826 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1827 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1828 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1829 Remove unused locals.
7e3ab302
PE
1830 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1831 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1832 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1833 macros.
f78faa98 1834
e2b13473
PE
1835 * xterm.h (x_mouse_leave): New decl.
1836
77f23912
PE
1837 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1838 Remove unused functions.
cdf4ba58
PE
1839 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1840 (x_calc_absolute_position): Now static.
7411c686 1841 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1842 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1843 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1844 unless they are used.
38d0b34a
PE
1845 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1846 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1847 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1848 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1849 (x_error_catcher, x_connection_closed, x_error_handler):
1850 (x_error_quitter, xembed_send_message, x_iconify_frame):
1851 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1852 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1853 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1854
44f230aa
SM
1855 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1856 Rename or move locals to avoid shadowing.
6b463e58 1857 (tty_defined_color, merge_face_heights): Now static.
5967d051 1858 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1859 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1860 does not deduce is never used uninitialized.
73719eba
PE
1861 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1862 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1863
426994c3 1864 * terminal.c (store_terminal_param): Now static.
5489860b 1865
032f1620 1866 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1867 (set_frame_menubar): Remove unused local.
d4323972 1868 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1869 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1870 since they might point to immutable storage.
281585b0
PE
1871 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1872 since it's unused otherwise.
032f1620 1873
367c19e5 1874 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1875 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1876 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1877 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1878 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1879 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1880 does not deduce are never used uninitialized.
70739cbe 1881
07b48fa9
PE
1882 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1883
8868a238 1884 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1885 * window.c (window_loop, size_window):
1886 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1887
7e5cf297 1888 * window.c (display_buffer): Now static.
d6550a9f
PE
1889 (size_window): Mark variables that gcc -Wuninitialized
1890 does not deduce are never used uninitialized.
a586633d
PE
1891 * window.h (check_all_windows): New decl, to forestall
1892 gcc -Wmissing-prototypes diagnostic.
5b555da1 1893 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1894
f6095868
PE
1895 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1896 shadowing.
1897 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1898 Include <limits.h>.
1899 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1900 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1901 (load_charset_map): Mark variables that gcc -Wuninitialized
1902 does not deduce are never used uninitialized.
53df7c11 1903 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1904
f38b440c
PE
1905 * coding.c (coding_set_source, coding_set_destination):
1906 Use "else { /* comment */ }" rather than "else /* comment */;"
1907 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1908 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1909 a block, when the outer 'i' will do.
1910 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1911 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1912 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1913 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1914 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1915 Rename locals to avoid shadowing.
1916 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1917 * coding.c (emacs_mule_char, encode_invocation_designation):
1918 Now static, since they're not used elsewhere.
413bb2db 1919 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1920 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1921 (decode_coding_emacs_mule): Mark variables that gcc
1922 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1923 (detect_coding_iso_2022): Initialize a local variable that might
1924 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1925 this initialization is needed. (Bug#8211)
5f58e762
PE
1926 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1927 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1928 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1929 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1930 Remove unused macros.
f38b440c 1931
232b38b9 1932 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1933 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1934 * character.c (string_count_byte8): Likewise.
232b38b9 1935
fb90da1b
PE
1936 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1937 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1938
fb93dbc2
PE
1939 * chartab.c (copy_sub_char_table): Now static, since it's not used
1940 elsewhere.
5c156ace
PE
1941 (sub_char_table_ref_and_range, char_table_ref_and_range):
1942 Rename locals to avoid shadowing.
bbcd0949 1943 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1944
7d3b3862 1945 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1946 (BIDI_BOB): Remove unused macro.
7d3b3862 1947
6be7d3da
PE
1948 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1949 deduce are never used uninitialized.
c2ed9c8b 1950 * term.c (encode_terminal_code): Likewise.
6be7d3da 1951
75f8807f 1952 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1953
50938595
PE
1954 * tparam.h: New file.
1955 * term.c, tparam.h: Include it.
1956 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1957 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1958 Move these decls to tparam.h, and make them agree with what
1959 is actually in tparam.c. The previous trick of using incompatible
1960 decls in different modules does not conform to the C standard.
1961 All callers of tparam changed to use tparam's actual API.
1962 * tparam.c (tparam1, tparam, tgoto):
1963 Use const pointers where appropriate.
1964
fbceeba2
PE
1965 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1966 * cm.h (struct cm): Likewise.
1967 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1968 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1969 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1970 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1971 (turn_on_face, init_tty): Likewise.
1972 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1973
7f3f1250
PE
1974 * term.c (term_mouse_position): Rename local to avoid shadowing.
1975
e6ca6543
PE
1976 * alloc.c (mark_ttys): Move decl from here ...
1977 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1978
c40f8d15
AS
19792011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1980
1981 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1982
cfe0661d
JB
19832011-03-09 Juanma Barranquero <lekktu@gmail.com>
1984
1985 * search.c (compile_pattern_1): Remove argument regp, unused since
1986 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1987 (compile_pattern): Don't pass it.
1988
0afb4571
J
19892011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1990
1991 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1992 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1993 for ! HAVE_GTK3.
1994 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1995
1996 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1997
1998 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1999 gdk_window_get_screen, gdk_window_get_geometry,
2000 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2001 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2002 (xg_get_pixbuf_from_pixmap): New function.
2003 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2004 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2005 Call xg_get_pixbuf_from_pixmap instead of
2006 gdk_pixbuf_get_from_drawable.
2007 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2008 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2009 (xg_check_special_colors): Use GtkStyleContext and its functions
2010 for HAVE_GTK3.
2011 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2012 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2013 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2014 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2015 Call gtk_widget_get_preferred_size.
0afb4571
J
2016 (xg_frame_resized): gdk_window_get_geometry only takes 5
2017 parameters.
44f230aa
SM
2018 (xg_win_to_widget, xg_event_is_for_menubar):
2019 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2020 (xg_set_widget_bg): New function.
2021 (delete_cb): New function.
2022 (xg_create_frame_widgets): connect delete-event to delete_cb.
2023 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2024 (xg_set_background_color): Call xg_set_widget_bg.
2025 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2026 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2027 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2028 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2029 if ! HAVE_GTK3.
2030 (update_frame_tool_bar): Call gtk_widget_hide.
2031 (xg_initialize): Use GDK_KEY_g.
2032
2033 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2034 if ! HAVE_GTK3
2035 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2036
2037 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2038 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2039 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2040
1c2cc4ef
JB
20412011-03-08 Juanma Barranquero <lekktu@gmail.com>
2042
2043 * w32xfns.c (select_palette): Check success of RealizePalette against
2044 GDI_ERROR, not zero.
2045
33383987 2046See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2047
2048;; Local Variables:
2049;; coding: utf-8
aac0c6e3
MR
2050;; End:
2051
33383987 2052 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2053
2054 This file is part of GNU Emacs.
2055
2056 GNU Emacs is free software: you can redistribute it and/or modify
2057 it under the terms of the GNU General Public License as published by
2058 the Free Software Foundation, either version 3 of the License, or
2059 (at your option) any later version.
2060
2061 GNU Emacs is distributed in the hope that it will be useful,
2062 but WITHOUT ANY WARRANTY; without even the implied warranty of
2063 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2064 GNU General Public License for more details.
2065
2066 You should have received a copy of the GNU General Public License
2067 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.