* inc/stdint.h (UINT64_MAX, UINT64_MIN, INT64_MIN, UINTMAX_MAX)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
22610910
JR
12011-11-05 Jason Rumney <jasonr@gnu.org>
2
3 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5 fonts (Bug#6029).
6 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7 bitwise arithmetic preventing use of unicode-sip and non-truetype
8 opentype fonts.
9
a06776b2
EZ
102011-11-05 Eli Zaretskii <eliz@gnu.org>
11
3ad924ba
EZ
12 * s/ms-w32.h (fstat, stat, utime): Move redirections to
13 "emacs"-only part.
14
a06776b2
EZ
15 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
16 initialization code to keep similarity to xfns.c after changes
17 from 2011-11-05.
18
c9e7db78
JD
192011-11-05 Jan Djärv <jan.h.d@swipnet.se>
20
a97f8f3f
JD
21 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
22 (unwind_create_frame): New function (Bug#9943).
23 (Fx_create_frame): Restructure code to be more similar to the one in
24 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
25 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
26 Move terminal->reference_count++ just before making the frame official
27 (Bug#9943).
28
29 * nsterm.m (x_free_frame_resources): New function.
30 (x_destroy_window): Move code to x_free_frame_resources.
31
c9e7db78
JD
32 * xfns.c (unwind_create_frame): Fix comment.
33 (Fx_create_frame, x_create_tip_frame): Move
34 terminal->reference_count++ just before making the frame
35 official. Move initialization of image_cache_refcount and
36 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
37
a6fc3b5c
EZ
382011-11-05 Eli Zaretskii <eliz@gnu.org>
39
40 Support MSVC build with newer versions of Visual Studio.
41 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
42 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
43 nt/gmake.defs.
44
45 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
46 which are not supported by MSVC.
47 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
48 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
49 bitfields.
50 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
51 types in bitfields.
52 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
53
54 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
55
562011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
57
58 Support MSVC build with newer versions of Visual Studio.
59 * w32.c: Don't include w32api.h for MSVC.
60 (init_environment) [_MSC_VER]: Call sys_access, not _access.
61
62 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
63 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
64 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
65 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
66 e_* cousins.
67 (alloca) [_MSC_VER]: Define to _alloca.
68
69 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
70
71 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
72
a58c13ed
EZ
732011-11-04 Eli Zaretskii <eliz@gnu.org>
74
75 * xdisp.c (note_mouse_highlight): If either of
76 previous/next-single-property-change returns nil, treat that as
77 the beginning or the end of the buffer. (Bug#9955)
78
fe0b6370
JD
792011-11-04 Jan Djärv <jan.h.d@swipnet.se>
80
a58c13ed 81 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
82 label is not null (Bug#9951).
83 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
84 may be NULL.
85
89bd5ee1
EZ
862011-11-04 Eli Zaretskii <eliz@gnu.org>
87
88 * window.c (Fwindow_body_size): Mention in the doc string that the
89 return value is in frame's canonical units. (Bug#9949)
90
84c3edb9
EZ
912011-11-03 Eli Zaretskii <eliz@gnu.org>
92
4e2fb5c7
EZ
93 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
94
84c3edb9 95 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 96 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 97 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 98
bc17a887
EZ
992011-11-01 Eli Zaretskii <eliz@gnu.org>
100
101 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
102 Don't stop backward scan on the continuation glyph, even though
103 its CHARPOS is positive.
26b46e51
EZ
104 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
105 cover_string to disp_string.
bc17a887 106
4ee88440
MR
1072011-11-01 Martin Rudalics <rudalics@gmx.at>
108
109 * window.c (temp_output_buffer_show): Don't use
110 Vtemp_buffer_show_specifiers.
111 (Vtemp_buffer_show_specifiers): Remove unused variable.
112
c2ff3c02
EZ
1132011-10-30 Eli Zaretskii <eliz@gnu.org>
114
115 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
116 past the beginning of the current glyph matrix.
117
6e56383b
JD
1182011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
119
120 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
121 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
122 HAVE_GTK3 (Bug#9869).
b77a6a7f 123
3b574623
JD
124 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
125 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
126
b77a6a7f
JD
127 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
128
129 * xterm.c: Declare x_handle_net_wm_state to return int.
130 (handle_one_xevent): Check if we are iconified but don't have
131 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
132 (get_current_wm_state): Return non-zero if not hidden,
133 check for _NET_WM_STATE_HIDDEN (Bug#9893).
134 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
135 (x_handle_net_wm_state): Return what get_current_wm_state returns.
136 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
137
196e41e4
PE
1382011-10-29 Paul Eggert <eggert@cs.ucla.edu>
139
140 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
141 so that this new function doesn't get optimized away by a
142 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
143
021f2e1a
AS
1442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
145
146 * frame.h (MOUSE_HL_INFO): Remove excess parens.
147
8b058d44
EZ
1482011-10-29 Eli Zaretskii <eliz@gnu.org>
149
150 Fix the `xbytecode' command.
151 * .gdbinit (xprintbytestr): New command.
152 (xwhichsymbols): Renamed from `which'; all callers changed.
153 (xbytecode): Print the byte-code string as well.
154
4452fb80
EZ
1552011-10-29 Kim Storm <storm@cua.dk>
156
8b058d44
EZ
157 * alloc.c (which_symbols): New function.
158
21b72067
AS
1592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
160
161 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
162 line. (Bug#9903)
163
83ed7b5c
GM
1642011-10-29 Glenn Morris <rgm@gnu.org>
165
166 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
167 Not clear what it was for, and it causes various bugs. (Bug#9839)
168
5a7a728b
EZ
1692011-10-28 Eli Zaretskii <eliz@gnu.org>
170
171 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
172 possible random value that matches one of those tested as
173 condition to clear the mouse face.
174
d3d0842f
CY
1752011-10-28 Chong Yidong <cyd@gnu.org>
176
177 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
178
31b39d13
DN
1792011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
180
181 * window.c (make_window): Initialize phys_cursor_on_p.
182
9aba6043
SM
1832011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
184
185 * lisp.h (struct Lisp_Symbol): Update comments.
186
c20992f4
JB
1872011-10-28 Juanma Barranquero <lekktu@gmail.com>
188
189 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
190
db4f02f2
EZ
1912011-10-28 Eli Zaretskii <eliz@gnu.org>
192
193 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
194 <oslsachem@gmail.com> for helping to debug this.
195
196 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
197 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
198 (g_b_init_get_glyph_outline_w): New static variables.
199 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
200 (GetGlyphOutlineW_Proc): New typedefs.
201 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
202 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
203 New functions.
204 (w32font_open_internal, compute_metrics):
205 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
206 instead of calling the "wide" APIs directly.
207
208 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
209
210 * w32.h (syms_of_w32font): Add prototype.
211
87e68db4
JB
2122011-10-27 Juanma Barranquero <lekktu@gmail.com>
213
214 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
215 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
216 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
217 (Fmove_to_window_line): Doc fix.
218
435c1d67
CY
2192011-10-27 Chong Yidong <cyd@gnu.org>
220
221 * process.c (make_process): Set gnutls_state to NULL.
222
223 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
224 non-NULL, regardless of GNUTLS_INITSTAGE.
225 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
226 an error. Set process slots as soon as we allocate them.
227
228 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
229
9c6c6f49
CY
2302011-10-27 Chong Yidong <cyd@gnu.org>
231
9aba6043
SM
232 * gnutls.c (emacs_gnutls_deinit): New function.
233 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
234 (Fgnutls_deinit, Fgnutls_boot): Use it.
235
236 * process.c (make_process): Initialize GnuTLS credentials to NULL.
237 (deactivate_process): Call emacs_gnutls_deinit.
238
657d08d3
JB
2392011-10-27 Juanma Barranquero <lekktu@gmail.com>
240
241 * image.c (x_create_x_image_and_pixmap):
242 * w32.c (sys_rename, w32_delayed_load):
243 * w32font.c (fill_in_logfont):
244 * w32reg.c (x_get_string_resource): Silence compiler warnings.
245
5430d399
JB
2462011-10-26 Juanma Barranquero <lekktu@gmail.com>
247
248 * w32fns.c (w32_default_color_map): New function,
249 extracted from Fw32_default_color_map.
a7ef684b 250 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 251
fe0055fa
PE
2522011-10-25 Paul Eggert <eggert@cs.ucla.edu>
253
254 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
255
e6346438
SM
2562011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
257
258 * keyboard.c (test_undefined): New function (bug#9751).
259 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
260
e112cc37
ET
2612011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
262
263 * sysdep.c (init_sys_modes): Fix the check for the controlling
264 terminal (Bug#6649).
265
7b5d6677
EZ
2662011-10-20 Eli Zaretskii <eliz@gnu.org>
267
268 * dispextern.h (struct bidi_it): New member next_en_type.
269
270 * bidi.c (bidi_line_init): Initialize the next_en_type member.
271 (bidi_resolve_explicit_1): When next_en_pos is valid for the
272 current character, check also for next_en_type being WEAK_EN.
273 (bidi_resolve_weak): Don't enter the expensive loop if the current
274 position is before next_en_pos. Record the bidi type of the first
275 non-ET, non-BN character we find, in addition to its position.
276 (bidi_level_of_next_char): Invalidate next_en_type when
277 next_en_pos is over-stepped.
278
7da0b018
PE
2792011-10-20 Paul Eggert <eggert@cs.ucla.edu>
280
281 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
282 * editfns.c: Rewrite current-time-zone so that it invokes
283 the equivalent of (format-time-string "%Z") to get the time zone name.
284 This fixes a bug when the time zone name contains characters that
285 need converting from the system time locale to Emacs internal format.
286 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
287 that patch fixed format-time-string to do the conversion, but
288 I forgot to fix current-time-zone.
289 (format_time_string): New function, containing most of
290 what Fformat_time_string used to contain.
291 (Fformat_time_string): Rewrite in terms of format_time_string.
292 This doesn't change this function's behavior.
293 (current-time-zone): Rewrite to use format_time_string.
294 This fixes the bug reported by Michael Schierl in
295 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
296 Jason Rumney's 2007-06-07 change worked around this bug, but
297 didn't fix it.
298 * systime.h (tzname, timezone): Remove no-longer-used declarations.
299
8547b010
EZ
3002011-10-19 Eli Zaretskii <eliz@gnu.org>
301
302 * xdisp.c (start_display): If the character at POS is displayed
303 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
304 (try_window_reusing_current_matrix): If a line ends in a display
305 vector or the next line starts in a display vector, continue
306 redrawing the window even though the character position of
307 start_row was reached.
8547b010
EZ
308 (Bug#9771, part 2)
309
4e948d15
CY
3102011-10-18 Chong Yidong <cyd@gnu.org>
311
312 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
313 with nobreak-char-display too.
314
4787455f
EZ
3152011-10-18 Eli Zaretskii <eliz@gnu.org>
316
317 Fix part 3 of bug#9771.
318 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
319 (bidi_resolve_neutral): Don't enter the expensive loop looking for
320 non-neutral characters if the current character is a paragraph
321 separator (a.k.a. Newline). This avoids running the same
322 expensive loop twice, once when we consume the preceding newline
323 and the other time when the line actually needs to be displayed.
324 Avoid the loop when we see neutrals on the base embedding level
325 following a character whose directionality is the same as the
326 paragraph's. This avoids running the expensive loop when a line
327 ends in a long sequence of neutrals, like control characters.
328 Add assertion against STRONG_AL type. Slightly rearrange code
329 that determines the type of a neutral given the first non-neutral
330 that follows it.
331 (bidi_level_of_next_char): Set next_en_pos to zero when
332 invalidating its info.
333
2c91f553
EZ
3342011-10-17 Eli Zaretskii <eliz@gnu.org>
335
336 * xdisp.c (push_display_prop): Determine whether to record string
337 or buffer position by IT->string, not by IT->method. Allow
338 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
339 (move_it_vertically_backward): Don't look for character position
340 immediately after the newline when in a continuation line.
341 (Bug#9771, part 1)
2c91f553 342
c7b08b0d
MR
3432011-10-15 Martin Rudalics <rudalics@gmx.at>
344
345 * window.c (coordinates_in_window): Rewrite and delabelize
346 vertical border check. (Bug#5357) (Bug#9618)
347
6b02f655
SM
3482011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
351 errors in XSetWindowBorder (bug#9310).
352
81d40c92
DA
3532011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
354
355 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
356 avoid crash when xmalloc overrun checking is enabled.
357
d4172c3b
EZ
3582011-10-13 Eli Zaretskii <eliz@gnu.org>
359
360 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
361 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
362 cursor motion with <left> and <right> arrow keys.
363
364 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
365 some callers set that themselves.
366
b00eea75
EZ
3672011-10-12 Eli Zaretskii <eliz@gnu.org>
368
369 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
370 display string and the previous row comes from the same string and
371 is empty. (Bug#9739) (Bug#9738)
372
8fe012c4
SM
3732011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
374
375 * doc.c (get_doc_string): Encode file name (bug#9735).
376
0074aef2
EZ
3772011-10-12 Eli Zaretskii <eliz@gnu.org>
378
79beb178
EZ
379 * bidi.c (bidi_level_of_next_char):
380 * xdisp.c (get_visually_first_element): Remove old incorrect
381 comments regarding the Unicode Line Separator character.
382
0074aef2
EZ
383 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
384
6e4b3fbe
DA
3852011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
386
387 * alloc.c (Fgc_status): Do not access beyond zombies array
388 boundary if nzombies > MAX_ZOMBIES.
389 * alloc.c (dump_zombies): Add missing format specifier.
390
0324f3af
PE
3912011-10-12 Paul Eggert <eggert@cs.ucla.edu>
392
b5525cac
PE
393 * xdisp.c (set_cursor_from_row): Simplify conditionals,
394 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
395
0324f3af
PE
396 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
397 Some packages use them to denote characters with modifiers.
398
e9b5f888
AS
3992011-10-11 Andreas Schwab <schwab@linux-m68k.org>
400
401 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
402 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
403 matching a pp-number. Rename parameter var to var1.
404
127827c0
SM
4052011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
406
407 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
408
c8fd3bd0
GM
4092011-10-08 Glenn Morris <rgm@gnu.org>
410
411 * callint.c (Fcall_interactively): Give a more explicit error for the
412 'c' case with a non-character input. (Bug#8479)
413
352ec8ff
EZ
4142011-10-08 Eli Zaretskii <eliz@gnu.org>
415
03669ccb
EZ
416 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
417 lines.
7061c986
EZ
418 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
419 lines that are hscrolled on the left.
03669ccb 420
352ec8ff
EZ
421 * dispnew.c (buffer_posn_from_coords): Account for a possible
422 presence of header-line. (Bug#4426)
423
a66cfb1c
SM
4242011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
425
6b02f655
SM
426 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
427 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 428
7c5ee88e
PE
4292011-10-07 Paul Eggert <eggert@cs.ucla.edu>
430
431 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
432 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
433 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
434 this makes Emacs dump core during garbage collection on rare
435 occasions. sizeof is obviously inferior to offsetof here, so
436 stick with offsetof.
437 (GC_POINTER_ALIGNMENT): New macro.
438 (mark_memory): Omit 3rd (offset) arg; caller changed.
439 Don't assume EMACS_INT alignment is the same as pointer alignment.
440
df1bbe5b
SM
4412011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
442
443 * keyboard.c (read_key_sequence_remapped): New var.
444 (read_key_sequence): Compute remapping in the right buffer.
445 (command_loop_1): Use read_key_sequence's remapping directly.
446
51553db6
SM
4472011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
448
32c1fffd
SM
449 * dired.c (file_name_completion): Don't expand file name.
450 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
451 before checking file name handler.
452
51553db6
SM
453 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
454 they've been requested explicitly (bug#9591).
455
b6bd1599 4562011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
457
458 * keymap.c (Fsingle_key_description): Use make_specified_string
459 instead of build_string to build string from push_key_description.
460 (Bug#5193)
461
f701dc2a
PE
4622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
463
4222c55d
PE
464 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
465 This fixes a Y2038 bug on 64-bit hosts.
466 * buffer.c (reset_buffer):
467 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
468 (Fclear_buffer_auto_save_failure):
469 Use 0, not -1, to represent an unset failure time, since time_t
470 might not be signed.
471
f701dc2a
PE
472 Remove dependency on glibc malloc internals.
473 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
474 Move back here from lisp.h, but with their new implementations.
475 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
476 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
477 * charset.c (charset_table_init): New static var.
478 (syms_of_charset): Use it instead of xmalloc. This removes a
479 dependency on glibc malloc internals. See Eli Zaretskii's comment in
480 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
481 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
482 Move back to alloc.c.
483 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
484 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
485
9ceebf39
JD
4862011-09-30 Jan Djärv <jan.h.d@swipnet.se>
487
488 * nsterm.m (windowDidResize): Call x_set_window_size only when
489 ns_in_resize is true. Otherwise set pixelwidth/height and
490 call change_frame_size (Bug#9628).
491
cb993c58
PE
4922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
493
3930c88b
PE
494 Port --enable-checking=all to Fedora 14 x86-64.
495 * charset.c (syms_of_charset): Also account for glibc malloc's
496 internal overhead when calculating the initial malloc maximum.
497
cb993c58
PE
498 Port --enable-checking=all to Fedora 14 x86.
499 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
500 Move to lisp.h.
501 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
502 (overrun_check_realloc, overrun_check_free):
503 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
504 That way, xmalloc returns a properly-aligned pointer even if
505 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
506 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
507 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
508 into account when calculating the initial malloc maximum.
509 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
510 Move here from alloc.c, so that charset.c can use it too.
511 Properly align; the old code wasn't right for common 32-bit hosts
512 when configured with --enable-checking=all.
513 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
514 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
515
31bed486
EZ
5162011-09-29 Eli Zaretskii <eliz@gnu.org>
517
04c70788 518 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
519 use EDOM.
520
fbcaa2f3
EZ
5212011-09-28 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (compute_display_string_end): If there's no display
524 string at CHARPOS, return -1.
525
526 * bidi.c (bidi_fetch_char): When compute_display_string_end
527 returns a negative value, treat the character as a normal
528 character not covered by a display string. (Bug#9624)
529
a239d4e9
JB
5302011-09-28 Juanma Barranquero <lekktu@gmail.com>
531
532 * lread.c (Fread_from_string): Fix typo in docstring.
533
88652fd5
EZ
5342011-09-27 Eli Zaretskii <eliz@gnu.org>
535
536 * xdisp.c (handle_invisible_prop): If invisible text ends on a
537 newline, reseat the iterator instead of bidi-iterating there one
538 character at a time. (Bug#9610)
32c1fffd
SM
539 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
540 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 541
ed497dd4
AS
5422011-09-27 Andreas Schwab <schwab@linux-m68k.org>
543
544 * lread.c (readevalloop): Use correct code for NBSP.
545 (read1): Likewise. (Bug#9608)
546
b2bf61aa
MA
5472011-09-25 Michael Albinus <michael.albinus@gmx.de>
548
549 * dbusbind.c (Fdbus_register_signal): When service is not
550 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
551
32bbb17c
GM
5522011-09-25 Glenn Morris <rgm@gnu.org>
553
554 * buffer.c (truncate-lines): Doc fix.
555
94e0933e
CY
5562011-09-24 Chong Yidong <cyd@stupidchicken.com>
557
558 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
559 (Fset_window_next_buffers): Doc fix.
560
cddde921
GM
5612011-09-24 Glenn Morris <rgm@gnu.org>
562
563 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
564
1260aef1
PE
5652011-09-24 Paul Eggert <eggert@cs.ucla.edu>
566
25b4bfa0
PE
567 Fix minor problems found by static checking.
568 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
569 * indent.c (Fvertical_motion): Fix == vs = typo.
570
e3cbd34b
EZ
5712011-09-24 Eli Zaretskii <eliz@gnu.org>
572
a66cfb1c
SM
573 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
574 Default value is now t. Doc fix.
6bf7006f 575
e3cbd34b 576 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 577 logic when moving up, not only when moving down. Fix the
e3cbd34b 578 confusing name and values of the it_overshoot_expected variable;
32c1fffd 579 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
580
581 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
582 CHARPOS is covered by a display string which includes newlines.
583 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
584 is covered by a display string with embedded newlines.
585
a3de0cbd
MA
5862011-09-24 Michael Albinus <michael.albinus@gmx.de>
587
588 * dbusbind.c (Fdbus_register_signal): Add match rule to
589 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
590 (Fdbus_register_method, Vdbus_registered_objects_table):
591 Fix docstring.
a3de0cbd 592
b260039d
JM
5932011-09-24 Jim Meyering <meyering@redhat.com>
594
32c1fffd 595 do not ignore write error for any output size
b260039d
JM
596 The previous change was incomplete.
597 While it makes emacs --batch detect the vast majority of stdout
598 write failures, errors were still ignored whenever the output size is
599 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
600 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
601 && echo FAIL: ignored write error
602 FAIL: ignored write error
603 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
604 && echo FAIL: ignored write error
605 FAIL: ignored write error
606 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
607
8eca8a7c
AS
6082011-09-23 Andreas Schwab <schwab@linux-m68k.org>
609
610 * emacs.c (Fkill_emacs): In noninteractive mode exit
611 non-successfully if a write error occurred on stdout. (Bug#9574)
612
3341db62
EZ
6132011-09-21 Eli Zaretskii <eliz@gnu.org>
614
615 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
616 the xassert test.
617
618 * dispextern.h (struct it): Update the comment documenting what
619 can it->OBJECT be.
620
8c203dbf
EZ
6212011-09-20 Eli Zaretskii <eliz@gnu.org>
622
623 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
624 a display string, extend search for cursor position to end of row.
625 (find_row_edges): If the row ends in a newline from a display
626 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
627 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
628 (Fcurrent_bidi_paragraph_direction): Fix search for previous
629 non-empty line. Fixes confusing cursor motion with arrow keys at
630 the beginning of a line that starts with whitespace.
8c203dbf 631
a4824228
LMI
6322011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
633
634 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
635 (bug#9493).
636
33ed493b
CY
6372011-09-18 Chong Yidong <cyd@stupidchicken.com>
638
639 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
640 boolean (Bug#9154).
641
56cd55c8
EZ
6422011-09-18 Eli Zaretskii <eliz@gnu.org>
643
644 * xdisp.c (display_line): Record maximum and minimum buffer
645 positions even if no glyphs were produced (e.g., by a zero-width
646 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
647 buffer positions that will be removed from the glyph row because
648 they don't fit.
c02dcedf
EZ
649 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
650 column is beyond frame width: don't subtract 1 "pixel" when
651 computing width of the stretch.
3e62b7e0
EZ
652 (reseat_at_next_visible_line_start): Undo the change made on
653 2011-09-17 that saved paragraph information and restored it after
654 the call to `reseat'. (Bug#9545)
56cd55c8 655
5ed99d36 6562011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
657
658 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
659 and turn window cursor on if cleared (Bug#9415).
660
5ed99d36 6612011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
662
663 * search.c (boyer_moore): Take unibyte characters from pattern
664 literally. (Bug#9458)
665
9bade7b2
EZ
6662011-09-18 Eli Zaretskii <eliz@gnu.org>
667
668 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
669
e5e9d610
PE
6702011-09-18 Paul Eggert <eggert@cs.ucla.edu>
671
87e4427a
PE
672 Fix minor problem found by static checking.
673 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
674 initialized, to pacify gcc -Wuninitialized.
675
e5e9d610
PE
676 * fileio.c: Report proper errno when syscall falls.
677 (Finsert_file_contents): Save and restore errno,
678 so that report_file_error outputs the correct diagnostic.
679 (Fwrite_region) [CLASH_DETECTION]: Likewise.
680
a1674f0b
EZ
6812011-09-18 Eli Zaretskii <eliz@gnu.org>
682
683 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
684
fbfb6dd4
EZ
6852011-09-17 Eli Zaretskii <eliz@gnu.org>
686
687 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
688 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
689
bb187662
EZ
6902011-09-17 Eli Zaretskii <eliz@gnu.org>
691
1137e8b8 692 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 693 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
694
695 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
696 (bidi_find_paragraph_start): Search back for paragraph beginning
697 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
698 (bidi_move_to_visually_next): Only trigger paragraph-related
699 computations when the last character is a newline or at EOB, not
700 just any NEUTRAL_B. (Bug#9470)
701
bb187662
EZ
702 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
703 truncated lines if point is covered by a display string. (Bug#9524)
704
2e621251
PE
7052011-09-16 Paul Eggert <eggert@cs.ucla.edu>
706
707 * xselect.c: Relax test for outgoing X longs (Bug#9498).
708 (cons_to_x_long): New function.
709 (lisp_data_to_selection_data): Use it. Correct the test for
710 short-versus-long data; it was negated. Break out of vector
711 loop, for efficiency, when a long datum is discovered.
712
91a15bc6
SM
7132011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
714
715 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
716
b41c3a35
EZ
7172011-09-16 Eli Zaretskii <eliz@gnu.org>
718
719 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
720 GCC PR/17406) by declaring this function with external scope.
721
7812ba2d
PE
7222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
723
724 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
725 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
726
cf7edc2a
AS
7272011-09-15 Andreas Schwab <schwab@linux-m68k.org>
728
729 * editfns.c (Fformat): Correctly handle text properties on "%%".
730
bd01620e
EZ
7312011-09-15 Eli Zaretskii <eliz@gnu.org>
732
733 * xterm.c (x_draw_composite_glyph_string_foreground):
734 * w32term.c (x_draw_composite_glyph_string_foreground):
735 * term.c (encode_terminal_code):
736 * composite.c (composition_update_it, get_composition_id):
737 * xdisp.c (get_next_display_element)
738 (fill_composite_glyph_string): Add comments about special meaning
739 of TAB characters in a composition.
740
a02719a3
PE
7412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
742
743 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
744 This occurs when processing a multibyte format.
745 Problem reported by Wolfgang Jenker.
a02719a3 746
72589a3c
JB
7472011-09-15 Johan Bockgård <bojohan@gnu.org>
748
749 * xdisp.c (try_cursor_movement): Only check for exact match if
750 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
751
1c14176c
PE
7522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
753
754 Remove unused external symbols.
755 * dispextern.h (calc_pixel_width_or_height): Remove decl.
756 * xdisp.c (calc_pixel_width_or_height): Now static.
757 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
758 * indent.c (check_display_width):
759 * w32term.c: Fix comment to match code.
760 * xterm.c, xterm.h (x_catching_errors): Remove.
761
d2eea5b5
PE
7622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
763
764 * xselect.c: Use signed conversions more consistently (Bug#9498).
765 (selection_data_to_lisp_data): Assume incoming selection data are
766 signed integers, not unsigned. This is to be consistent with
767 outgoing selection data, which was modified to use signed integers
768 in as part of the fix to Bug#9196 in response to Jan D.'s comment
769 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
770 expects long, not unsigned long.
771
46888499
EZ
7722011-09-14 Eli Zaretskii <eliz@gnu.org>
773
774 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
775 computation of loop end. Reported by Johan Bockgård
776 <bojohan@gnu.org>.
777
ef8ef9fb
CY
7782011-09-13 Chong Yidong <cyd@stupidchicken.com>
779
780 * frame.c (Fother_visible_frames_p): Function deleted.
781
fa819fed
EZ
7822011-09-12 Eli Zaretskii <eliz@gnu.org>
783
784 * indent.c (compute_motion): Process display vector front to back
785 rather than the other way around. (Bug#2496)
786
2ba8e008
SM
7872011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
788
789 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
790
20f53c69
CY
7912011-09-11 Chong Yidong <cyd@stupidchicken.com>
792
793 * minibuf.c (Fread_from_minibuffer): Doc fix.
794
d562d7a4
EZ
7952011-09-11 Eli Zaretskii <eliz@gnu.org>
796
797 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
798 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
799
1c4d7f3d
LMI
8002011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
801
802 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
803 value for non-existent files.
804
b885bf36
EZ
8052011-09-11 Eli Zaretskii <eliz@gnu.org>
806
807 * fileio.c (Finsert_file_contents): If the file cannot be opened,
808 set its "size" to -1. This will set the modtime_size field of
809 the corresponding buffer to -1, which is what
810 verify-visited-file-modtime expects for files that do not exist.
811 (Bug#9139)
812
6612f0bf
PE
8132011-09-11 Paul Eggert <eggert@cs.ucla.edu>
814
815 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
816 here ...
817 * lisp.h: ... from here. push_key_description is no longer
818 defined in keyboard.c, so its declaration should not be in
819 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
820 logically belongs with push_key_description.
821
dfb3f755
PE
8222011-09-10 Paul Eggert <eggert@cs.ucla.edu>
823
824 * buffer.h: Include <sys/types.h> instead of <time.h>.
825 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
826 Problem reported by Herbert J. Skuhra.
827
3134906c
LMI
8282011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
829
830 * xml.c (parse_region): Make the parsing work for
831 non-comment-starting XML files again (bug#9144).
832
8d903f4e
AS
8332011-09-10 Andreas Schwab <schwab@linux-m68k.org>
834
835 * image.c (gif_load): Fix calculation of bottom and right corner.
836 (Bug#9468)
837
80ad64f4
EZ
8382011-09-10 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
841 redisplay in small windows.
842
208a048d
EZ
8432011-09-09 Eli Zaretskii <eliz@gnu.org>
844
845 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
846
9b1c252e
MR
8472011-09-08 Martin Rudalics <rudalics@gmx.at>
848
849 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
850 Operate on live windows only.
851
2949f33b
JB
8522011-09-08 Juanma Barranquero <lekktu@gmail.com>
853
854 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
855
e08dcafd
EZ
8562011-09-07 Eli Zaretskii <eliz@gnu.org>
857
858 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
859 only under bidi iteration.
860
115b96bd
JD
8612011-09-07 Jan Djärv <jan.h.d@swipnet.se>
862
863 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
864
c8199d0f
PE
8652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
866
867 isnan: Fix porting problem to Solaris 10 with bundled gcc.
868 Without this fix, the command to link temacs failed due to an
869 undefined symbol __builtin_isnan. This is because
870 /usr/include/iso/math_c99.h #defines isnan(x) to
871 __builtin_isnan(x), but the bundled gcc, which identifies itself
872 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
873 a __builtin_isnan.
874 * floatfns.c (isnan): #undef, and then #define to a clone of
875 what's in data.c.
876 (Fisnan): Always define, since it's always available now.
877 (syms_of_floatfns): Always define isnan at the Lisp level.
878
e39b275c 8792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
880
881 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
882
b2db44d9 8832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 884
f4af5137 885 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
886 The previous code assumed that file offsets (off_t values) fit in
887 EMACS_INT variables, which is not true on typical 32-bit hosts.
888 The code messed up by falsely reporting buffer overflow in cases
889 such as (insert-file-contents "big" nil 1 2) into an empty buffer
890 when "big" contains more than 2**29 bytes, even though this
891 inserts just one byte and does not overflow the buffer.
892 (Finsert_file_contents): Store file offsets as off_t
893 values, not as EMACS_INT values. Check for overflow when
894 converting between EMACS_INT and off_t. When checking for
895 buffer overflow or for overlap, take the offsets into account.
896 Don't use EMACS_INT for small values where int suffices.
897 When checking for overlap, fix a typo: ZV was used where
898 ZV_BYTE was intended.
899 (Fwrite_region): Don't assume off_t fits into 'long'.
900 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
901
ecfc0a49
MA
9022011-09-05 Michael Albinus <michael.albinus@gmx.de>
903
904 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
905
6511acf2 9062011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 907
0999621a 908 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
909
910 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 911 (esprintf, exprintf, evxprintf): New functions.
62f19c19 912 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 913 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
914 (modify_event_symbol): Do not assume that the length of
915 name_alist_or_stem is safe to alloca and fits in int.
916 (Fexecute_extended_command): Likewise for function name and binding.
917 (Frecursion_depth): Wrap around reliably on integer overflow.
918 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
919 since some callers pass EMACS_INT values.
920 (Fsingle_key_description): Don't crash if symbol name contains more
921 than MAX_ALLOCA bytes.
922 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
923 (get_minibuffer): Arg is now EMACS_INT, not int.
924 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 925 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
926 * window.h (command_loop_level, minibuf_level): Reflect API changes.
927
2be7d702
PE
928 * dbusbind.c (signature_cat): New function.
929 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
930 Do not overrun buffer; instead, report string overflow.
931
9d1df220
PE
932 * dispnew.c (add_window_display_history): Don't overrun buffer.
933 Truncate instead; this is OK since it's just a log.
934
33ef5c64
PE
935 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
936 even if the time zone offset is outlandishly large.
937 Don't mishandle offset == INT_MIN.
938
66c6fdd5
PE
939 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
940 when creating daemon; the previous buffer-overflow check was incorrect.
941
d749b01b
PE
942 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
943 which has the guts of the old verror function.
944
b5cd1905
PE
945 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
946 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
947
6e1a67fb
PE
948 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
949 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 950 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 951 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
952 length of string rather than counting it via multiple sprintfs;
953 that's simpler and more reliable.
c21721cc
PE
954 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
955 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
956 sprintf, in case result does not fit in int.
957
c57b67fc
PE
958 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
959 (fontset_from_font): Print it.
960
8a401434
PE
961 * frame.c (tty_frame_count): Now printmax_t, not int.
962 (make_terminal_frame, set_term_frame_name): Print it.
963 (x_report_frame_params): In X, window IDs are unsigned long,
964 not signed long, so print them as unsigned.
965 (validate_x_resource_name): Check for implausibly long names,
966 and don't assume name length fits in 'int'.
967 (x_get_resource_string): Don't blindly alloca invocation name;
968 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
969 not fit in int.
970
6e1a67fb
PE
971 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
972 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
973 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
974
0df02bf3
PE
975 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
976 Use esprintf, not sprintf, in case result does not fit in int.
977
48e30793
PE
978 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
979 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
980 it as a large positive number.
981 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
982 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
983
a66ff6d8
PE
984 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
985 in case result does not fit in int.
986
aca216ff
PE
987 * print.c (float_to_string): Detect width overflow more reliably.
988 (print_object): Make sprintf buffer a bit bigger, to avoid potential
989 buffer overrun. Don't assume list length fits in 'int'. Treat
990 print length of 0 as 0, not as infinity; to be consistent with other
991 uses of print length in this function. Don't overflow print length
992 index. Don't assume hash table size fits in 'long', or that
993 vectorlike size fits in 'unsigned long'.
994
31c286f7
PE
995 * process.c (make_process): Use printmax_t, not int, to format
996 process-name gensyms.
997
55e5faa1
PE
998 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
999
80f2e268
PE
1000 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1001 to avoid potential buffer overrun.
1002
670741ab
PE
1003 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1004 if X resource line is longer than 512 bytes.
1005
b7163a50
PE
1006 * xfns.c (x_window): Make sprintf buffer a bit bigger
1007 to avoid potential buffer overrun.
1008
ae58ff1f
PE
1009 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1010
c43c8a6a
PE
1011 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1012
3f8236f4
PE
10132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1014
53e9fe90 1015 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1016 Without these, Emacs silently mishandles large integers sometimes.
1017 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1018 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1019
6511acf2
PE
1020 * xdisp.c (try_window_id): Check Emacs fixnum range before
1021 converting to 'int'.
806add1d 1022
6511acf2 1023 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1024 Check that an Emacs fixnum is in range before assigning it to 'int'.
1025 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1026 values converted from Emacs fixnums.
1027 (Frecenter): Don't wrap around a line count if it is out of 'int'
1028 range; instead, treat it as an extreme value.
1029 (Fset_window_configuration, compare_window_configurations):
1030 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1031
6511acf2
PE
1032 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1033 that can exceed INT_MAX. Check that EMACS_INT value is in range
1034 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1035 (match_limit): Don't assume that a fixnum can fit in 'int'.
1036
6511acf2 1037 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1038 exceed INT_MAX.
1039
6511acf2 1040 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1041 (Fvertical_motion): Don't wrap around LINES values that don't fit
1042 in 'int'. Instead, treat them as extreme values. This is good
1043 enough for windows, which can't have more than INT_MAX lines anyway.
1044
fcb901a7
LMI
10452011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1046
0f2f6b6d
LMI
1047 * Require libxml/parser.h to avoid compilation warning.
1048
fcb901a7
LMI
1049 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1050
1051 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1052 since this reportedly can destroy thread storage.
1053
6e20a0d4
CY
10542011-08-30 Chong Yidong <cyd@stupidchicken.com>
1055
1056 * syntax.c (find_defun_start): Update all cache variables if
1057 exiting early (Bug#9401).
1058
148ae00e
EZ
10592011-08-30 Eli Zaretskii <eliz@gnu.org>
1060
f6cfbd8f
EZ
1061 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1062
148ae00e
EZ
1063 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1064 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1065 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1066
1067 * term.c (tty_append_glyph): New function.
1068 (produce_stretch_glyph): Static function and its prototype deleted.
1069
a66cfb1c
SM
1070 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1071 Add prototypes.
148ae00e 1072
c4a07a4c
PE
10732011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1074
1075 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1076 when checking :margin (Bug#9390).
1077 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1078 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1079 so that the name doesn't mislead. All uses changed.
1080
6bc8cd65
JB
10812011-08-28 Johan Bockgård <bojohan@gnu.org>
1082
1083 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1084 set_tty_hooks.
1085
dca4927e
EZ
10862011-08-27 Eli Zaretskii <eliz@gnu.org>
1087
1088 * xdisp.c (move_it_to): Don't bail out early when reaching
1089 position beyond to_charpos, if we are scanning backwards.
1090 (move_it_vertically_backward): When DY == 0, make sure we get to
1091 the first character in the line after the newline.
1092
f2cad773
PE
10932011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1096 (ccl_driver): Do not generate an out-of-range pointer.
1097 (Fccl_execute_on_string): Remove unnecessary check for
1098 integer overflow, noted by Stefan Monnier in
1099 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1100 Remove a FIXME that didn't need fixing.
1101 Simplify the newly-introduced buffer reallocation code.
1102
0cae2cdb
JB
11032011-08-27 Juanma Barranquero <lekktu@gmail.com>
1104
1105 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1106
5fc295a4 11072011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1108
70c60eb2 1109 Integer and memory overflow issues (Bug#9196).
726e0ab1 1110
d31850da
PE
1111 * doc.c (get_doc_string): Rework so that
1112 get_doc_string_buffer_size is the actual buffer size, rather than
1113 being 1 less than the actual buffer size; this makes xpalloc more
1114 convenient.
1115
a69fbedb
PE
1116 * image.c (x_allocate_bitmap_record, cache_image):
1117 * xselect.c (Fx_register_dnd_atom):
1118 Simplify previous changes by using xpalloc.
1119
fe5c5d37
PE
1120 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1121 since either will do and ptrdiff_t is convenient with xpalloc.
1122
0065d054
PE
1123 * charset.c (charset_table_size)
1124 (struct charset_sort_data.priority): Now ptrdiff_t.
1125 (charset_compare): Don't overflow if priorities differ greatly.
1126 (Fsort_charsets): Don't assume list length fits in int.
1127 Check for size-calculation overflow when allocating sort data.
1128 (syms_of_charset): Allocate an initial charset table that is
1129 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1130
1131 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1132
1133 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1134 The actual value is always <= INT_MAX, and leaving it unsigned made
1135 overflow checking harder.
1136
1137 * dispextern.h (struct glyph_matrix.rows_allocated)
1138 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1139 with xpalloc. The values are still always <= INT_MAX.
1140
1141 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1142
1143 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1144 (SAFE_NALLOCA): New macro.
1145
1146 * region-cache.c (struct boundary.pos, find_cache_boundary)
1147 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1148 (set_cache_region, invalidate_region_cache)
1149 (revalidate_region_cache, know_region_cache, region_cache_forward)
1150 (region_cache_backward, pp_cache):
1151 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1152 so that ptrdiff_t * can be passed to xpalloc.
1153 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1154 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1155 (pp_cache): Don't assume cache_len fits in int.
1156 * region-cache.h: Adjust extern decls to match.
1157
1158 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1159 EMACS_INT, since either will do, for xpalloc.
1160
1161 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1162 (xnmalloc, xnrealloc, xpalloc): New functions.
1163
726e0ab1
PE
1164 * bidi.c (bidi_shelve_header_size): New constant.
1165 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1166 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1167
51f30bc5 1168 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1169 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1170 (overlay_strings):
1171 Don't update size of array until after memory allocation succeeds,
1172 because xmalloc/xrealloc may not return.
0065d054
PE
1173 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1174 now that we have proper integer overflow checking.
1175 (record_overlay_string, overlay_strings): Catch overflows when
1176 calculating size of overlay_str_buf.
726e0ab1 1177
0065d054
PE
1178 * callproc.c (Fcall_process): Check for size overflow when
1179 calculating size of args2.
1180 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1181 Normally we prefer signed values, but sticking with ptrdiff_t would
1182 require adding more-complicated checks.
726e0ab1
PE
1183
1184 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1185 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1186 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1187 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1188
1189 * character.c (Fstring): Check for size-calculation overflow.
1190
1191 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1192 unnecessary integer overflow. Check for size overflow.
1193 (encode_coding_object): Don't update size until xmalloc succeeds.
1194
1195 * composite.c (get_composition_id): Check for overflow in glyph
1196 length calculations.
1197
1198 Integer and memory overflow fixes for display code.
1199 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1200 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1201 (scrolling_window): Check for overflow in size calculations.
1202 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1203 Don't assume glyph table len fits in int.
1204 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1205 (row_table_size): Now ptrdiff_t, not int.
1206 (scrolling_window): Avoid overflow in size calculations.
1207 Don't update size until allocation succeeds.
1208 * fns.c (concat): Check for overflow in size calculations.
1209 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1210 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1211 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1212
1213 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1214 (get_doc_string): Check for size calculation overflow.
1215 Don't update size until allocation succeeds.
1216 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1217 EMACS_INT, where ptrdiff_t will do.
1218 (Fsubstitute_command_keys): Check for string overflow.
1219
1220 * editfns.c (set_time_zone_rule): Don't assume environment length
1221 fits in int.
1222 (message_length): Now ptrdiff_t, not int.
1223 (Fmessage_box): Don't update size until allocation succeeds.
1224 Don't assume message length fits in int.
1225 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1226
0065d054
PE
1227 * emacs.c (main): Do not reallocate argv, since there is a null at
1228 the end that can be overwritten, and this way there's no need to
1229 worry about size-calculation overflow.
1230 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1231
1232 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1233 alloc succeeds.
1234 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1235
1236 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1237 (x_set_scroll_bar_width, x_figure_window_size):
1238 Check for integer overflow.
1239 (x_set_alpha): Do not assume XINT fits in int.
1240
1241 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1242 This is for the members text_lines, text_cols, total_lines, total_cols,
1243 where the system imposes an 'int' limit.
1244
1245 * fringe.c (Fdefine_fringe_bitmap):
1246 Don't update size until alloc works.
1247
1248 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1249 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1250
1251 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1252 Check for size-calculation overflow.
1253 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1254 do, as we prefer signed integers.
1255 (id_to_widget.max_size, id_to_widget.used)
1256 (xg_store_widget_in_map, xg_remove_widget_from_map)
1257 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1258 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1259 Use and return ptrdiff_t, not int.
1260 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1261 * gtkutil.h: Change prototypes to match the above.
1262
1263 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1264 are duplicate now that they've been promoted to lisp.h.
1265 (x_allocate_bitmap_record, x_alloc_image_color)
1266 (make_image_cache, cache_image, xpm_load):
1267 Don't update size until alloc is done.
1268 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1269 (x_detect_edges):
3256efce 1270 Check for size calculation overflow.
726e0ab1
PE
1271 (ct_colors_allocated_max): New constant.
1272 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1273 overflow.
3256efce 1274
726e0ab1
PE
1275 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1276 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1277 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1278 Use ptrdiff_t, not int, to count maps.
1279 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1280 calculations. Don't update size until allocation succeeds.
1281 Redo calculations to avoid overflow.
726e0ab1
PE
1282 * keyboard.h: Change prototypes to match the above.
1283
1284 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1285 to count maps.
1286 (current_minor_maps): Check for size calculation overflow.
1287 * keymap.h: Change prototypes to match the above.
1288
1289 * lread.c (read1, init_obarray): Don't update size until alloc done.
1290
1291 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1292 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1293
726e0ab1
PE
1294 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1295 Now ptrdiff_t, not int.
1296 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1297 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1298
1299 * process.c (Fnetwork_interface_list): Check for overflow
1300 in size calculation.
1301
1302 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1303
1304 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1305 overflow. Don't bother calling xmalloc when xrealloc will do.
1306
1307 * search.c (Freplace_match): Check for size calculation overflow.
1308 (Fset_match_data): Don't assume list lengths fit in 'int'.
1309
1310 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1311 for command line length. Do not attempt to address one before the
1312 beginning of an array, as that's not portable.
1313
1314 * term.c (max_frame_lines): Remove; unused.
1315 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1316 not int.
1317 (encode_terminal_code, calculate_costs): Check for size
1318 calculation overflow.
1319 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1320 table lengths and related sizes. Don't update size until alloc
1321 done. Redo calculations to avoid overflow.
1322 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1323
1324 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1325 subtracting pointers.
1326 (gobble_line): Check for overflow more carefully. Don't update size
1327 until alloc done.
1328
1329 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1330 Don't update size until alloc done.
1331 Redo size calculations to avoid overflow.
1332 Check for size calculation overflow.
0065d054 1333 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1334
1335 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1336 Use ptrdiff_t, not int, for sizes.
1337 (store_mode_line_noprop_char): Don't update size until alloc done.
1338
0065d054
PE
1339 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1340 Use ptrdiff_t, not int, for sizes.
1341 (Finternal_make_lisp_face, cache_face):
1342 Check for size calculation overflow.
1343 (cache_face): Treat size calculation overflows as if they were
1344 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1345
1346 * xfns.c (x_encode_text, x_set_name_internal)
1347 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1348 sizes, since they can exceed INT_MAX in size. Check for size
1349 calculation overflow.
1350
0065d054
PE
1351 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1352 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1353 Don't update size until alloc done.
1354
0065d054 1355 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1356 as sprintf is limited to int lengths.
1d526e2f 1357
252c5ee1
PE
1358 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1359 (X_LONG_MIN): New macros.
864d7ce7
PE
1360 Use them to make the following changes clearer.
1361 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1362 This change doesn't affect the value now, but it may help remind
1363 future maintainers not to raise the value too much later.
1364 (SELECTION_QUANTUM): Remove, replacing with ...
1365 (selection_quantum): ... new function, which avoids overflow.
1366 All uses changed.
1367 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1368 assumption that selection length fits in 'int'.
1369 (x_reply_selection_request, x_handle_selection_request)
1370 (x_get_window_property, receive_incremental_selection)
1371 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1372 (lisp_data_to_selection_data, clean_local_selection_data):
1373 Use ptrdiff_t, not int, to record length of selection.
1374 (x_reply_selection_request, x_get_window_property)
1375 (receive_incremental_selection, x_property_data_to_lisp):
1376 Redo calculations to avoid overflow.
1377 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1378 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1379 something.
1380 (x_get_window_property, receive_incremental_selection)
1381 (lisp_data_to_selection_data, x_property_data_to_lisp):
1382 Check for size-calculation overflow.
1383 (x_get_window_property, receive_incremental_selection)
1384 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1385 Don't store size until memory allocation succeeds.
1386 (x_get_window_property): Plug memory leak on memory exhaustion.
1387 Don't double-block input; malloc is safe here. Don't assume 2**34
1388 - 4 fits in unsigned long. Add an xassert to check
1389 XGetWindowProperty overflow. Be more careful about overflow
1390 calculations, and distinguish size from memory overflow better.
1391 (receive_incremental_selection): When tracing, don't assume
1392 unsigned int is less than INT_MAX.
1393 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1394 harmful) conversions of unsigned short to int.
1395 (lisp_data_to_selection_data): Don't assume that integers
1396 in the range -65535 through -1 fit in an X unsigned short.
1397 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1398 result parameters unless successful. Rely on cons_to_unsigned
1399 to report problems with elements; the old code wasn't right anyway.
1400 (x_check_property_data): Check for int overflow; we cannot use
1401 a wider type due to X limits.
1402 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1403
726e0ab1 1404 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1405
0065d054
PE
1406 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1407 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1408 (x_color_cells): Don't store size until memory allocation succeeds.
1409 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1410 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1411 (x_term_init): Don't assume length fits in int (sprintf is limited
1412 to int size).
bc18e09d 1413
ebfa62c0
PE
1414 Use ptrdiff_t for composition IDs.
1415 * character.c (lisp_string_width):
1416 * composite.c (composition_table_size, n_compositions)
1417 (get_composition_id, composition_gstring_from_id):
1418 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1419 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1420 * window.c (Frecenter):
1421 Use ptrdiff_t, not int, for composition IDs.
1422 * composite.c (get_composition_id): Check for integer overflow.
1423 * composite.h: Adjust prototypes to match the above changes.
1424
d3411f89
PE
1425 Use ptrdiff_t for hash table indexes.
1426 * category.c (hash_get_category_set):
1427 * ccl.c (ccl_driver):
1428 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1429 * coding.c (coding_system_charset_list, detect_coding_system):
1430 * coding.h (struct coding_system.id):
1431 * composite.c (get_composition_id, gstring_lookup_cache):
1432 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1433 * image.c (xpm_get_color_table_h):
1434 * lisp.h (hash_lookup, hash_put):
1435 * minibuf.c (Ftest_completion):
1436 Use ptrdiff_t for hash table indexes, not int (which is too
1437 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1438 32-bit --with-wide-int hosts).
1439
e097a6fa
PE
1440 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1441 Add a FIXME comment about memory leaks.
1442 (syms_of_charset): Don't assume xmalloc returns.
1443
5637687f
PE
1444 Don't assume that stated character widths fit in int.
1445 * character.c (Fchar_width, c_string_width, lisp_string_width):
1446 * character.h (CHAR_WIDTH):
1447 * indent.c (MULTIBYTE_BYTES_WIDTH):
1448 Use sanitize_char_width to avoid undefined and/or bad behavior
1449 with outlandish widths.
a66cfb1c 1450 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1451 now that we have two such functions. All uses changed.
1452 (sanitize_char_width): New inline function.
1453
a2271ba2
PE
1454 Don't assume that tab-width fits in int.
1455 * character.h (sanitize_width): New inline function.
1456 (SANE_TAB_WIDTH): New macro.
1457 (ASCII_CHAR_WIDTH): Use it.
1458 * indent.c (sane_tab_width): Remove. All uses replaced by
1459 SANE_TAB_WIDTH (current_buffer).
1460 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1461
18c52557
PE
1462 * fileio.c: Integer overflow issues with file modes.
1463 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1464
caeeedc1
PE
1465 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1466 Remove unreachable code.
1467 (read_hex, load_charset_map_from_file): Check for integer overflow.
1468
50849c52
PE
1469 * xterm.c: don't go over XClientMessageEvent limit
1470 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1471 (x_send_scroll_bar_event): Likewise. Check that the size does not
1472 exceed limits imposed by XClientMessageEvent, as well as the usual
1473 ptrdiff_t and size_t limits.
1474
b13995db
PE
1475 * keyboard.c: Overflow, signedness and related fixes.
1476 (make_lispy_movement): Use same integer type in forward decl
1477 that is used in the definition.
1478 (read_key_sequence, keyremap_step):
1479 Change bufsize argument back to int, undoing my 2011-03-30 change.
1480 We prefer signed types, and int is wide enough here.
1481 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1482 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1483 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1484 length, not size_t. Use ptrdiff_t for index, not int.
1485 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1486 possibility of integer overflow.
1487
13464394
PE
1488 Overflow, signedness and related fixes for images.
1489
1490 * dispextern.h (struct it.stack[0].u.image.image_id)
1491 (struct_it.image_id, struct image.id, struct image_cache.size)
1492 (struct image_cache.used, struct image_cache.ref_count):
1493 * gtkutil.c (update_frame_tool_bar):
1494 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1495 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1496 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1497 * nsmenu.m (update_frame_tool_bar):
1498 * xdisp.c (calc_pixel_width_or_height):
1499 * xfns.c (image_cache_refcount):
1500 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1501 on typical 64-bit hosts.
1502
1503 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1504 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1505 Omit unnecessary casts to int.
1506 (parse_image_spec): Check that integers fall into 'int' range
1507 when the callers expect that.
1508 (image_ascent): Redo ascent calculation to avoid int overflow.
1509 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1510 (lookup_image): Remove unnecessary tests.
1511 (xbm_image_p): Locals are now of int, not EMACS_INT,
1512 since parse_image_check makes sure they fit into int.
1513 (png_load, gif_load, svg_load_image):
1514 Prefer int to unsigned where either will do.
1515 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1516 old tiff_error_handler and tiff_warning_handler.
1517 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1518 stack buffer overflows. It uses only the features of vsnprintf
1519 that are common to both POSIX and native Microsoft.
1520 (tiff_error_handler, tiff_warning_handler): Use it.
1521 (tiff_load, gif_load, imagemagick_load_image):
1522 Don't assume :index value fits in 'int'.
1523 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1524 (imagemagick_load_image): Check that crop parameters fit into
1525 the integer types that MagickCropImage accepts. Don't assume
1526 Vimagemagick_render_type has a nonnegative value. Don't assume
1527 size_t fits in 'long'.
1528 (gs_load): Use printmax_t to print the widest integers possible.
1529 Check for integer overflow when computing image height and width.
1530
c11821d4
EZ
15312011-08-26 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (redisplay_window): Don't force window start if point
1534 will be invisible in the resulting window. (Bug#9324)
1535
0c95fcf7
EZ
15362011-08-25 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1539 the display spec is of the form `(space ...)'.
1540 (handle_display_spec): Return the value returned by
1541 handle_single_display_spec, not just 1 or zero.
1542 (handle_single_display_spec): If the display spec is of the form
1543 `(space ...)', and specifies display in the text area, return 2
1544 rather than 1.
fee65a97 1545 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1546 accurately, and prefer exact match for point under bidi.
1547 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1548
1549 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1550 into disp_prop; all users changed.
1551
1552 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1553 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1554 for the text covered by the display property.
1555
e4ed06f1
CY
15562011-08-25 Chong Yidong <cyd@stupidchicken.com>
1557
1558 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1559 Change return value to nil.
1560 (Frecord_buffer): Delete unused function.
1561
f67cdd7f
EZ
15622011-08-24 Eli Zaretskii <eliz@gnu.org>
1563
5980d4c6
EZ
1564 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1565 buffers, return left-to-right.
8610fe8b
EZ
1566 (set_cursor_from_row): Consider candidate row a win if its glyph
1567 represents a newline and point is on that newline. Fixes cursor
1568 positioning on the newline at EOL of R2L text within L2R
1569 paragraph, and vice versa.
1570 (try_cursor_movement): Check continued rows, in addition to
1571 continuation rows. Fixes unwarranted scroll when point enters a
1572 continued line of R2L text within an L2R paragraph, or vice versa.
1573 (cursor_row_p): Consider the case of point being equal to
1574 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1575 from the end of a short line to the beginning of a continued line
1576 of R2L text within L2R paragraph.
1577 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1578 composed characters.
5980d4c6 1579
f67cdd7f
EZ
1580 * bidi.c (bidi_check_type): Use xassert.
1581 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1582 members.
1583
bca633fb
EZ
15842011-08-23 Eli Zaretskii <eliz@gnu.org>
1585
1586 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1587 a character.
1588
4a5885a7
CY
15892011-08-23 Chong Yidong <cyd@stupidchicken.com>
1590
1591 * nsfont.m (ns_otf_to_script): Fix typo.
1592
0902a04e
KH
15932011-08-22 Kenichi Handa <handa@m17n.org>
1594
1595 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1596 extra slot even if the purpose is char-code-property-table.
1597
1a2e6670
EZ
15982011-08-23 Eli Zaretskii <eliz@gnu.org>
1599
8ddde651
EZ
1600 * xdisp.c (redisplay_window): When computing centering_position,
1601 account for the height of the header line. (Bug#8874)
1602
425cc014
EZ
1603 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1604 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1605 candidate is selected by the mouse, and that candidate has a
1606 composed character under the mouse.
1607
1a2e6670
EZ
1608 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1609 coordinates reported by pos-visible-in-window-p for a composed
1610 character in column zero.
1611
8b76d6f8
SM
16122011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1613
1614 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1615
dac347dd
EZ
16162011-08-22 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1619 consider it a hit if to_charpos is anywhere in the range of the
1620 composed buffer positions.
1621
e013fb34
CY
16222011-08-22 Chong Yidong <cyd@stupidchicken.com>
1623
1624 * image.c (gif_load): Don't assume that each subimage has the same
1625 dimensions as the base image. Handle disposal method that is
1626 "undefined" by the gif spec (Bug#9335).
1627
bd1ba3e8
CY
16282011-08-20 Chong Yidong <cyd@stupidchicken.com>
1629
1630 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1631 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1632
54a1215b
EZ
16332011-08-19 Eli Zaretskii <eliz@gnu.org>
1634
823564e5
EZ
1635 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1636 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1637 from an Org mode buffer to a Speedbar frame.
1638
54a1215b
EZ
1639 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1640 a composition, take its buffer position from IT->cmp_it.charpos.
1641 Fixes cursor positioning at the beginning of a line that begins
1642 with a composed character.
1643
9778ebcc
EZ
16442011-08-18 Eli Zaretskii <eliz@gnu.org>
1645
0be6ee06
EZ
1646 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1647 character bidirectional type, use STRONG_L instead. Fixes crashes
1648 in a buffer produced by `describe-categories'.
1649
9778ebcc
EZ
1650 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1651 members before the level stack, so they would be saved and
1652 restored when copying iterator state. Fixes incorrect reordering
1653 around TABs covered by display properties.
1654
156bffbe
AS
16552011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1656
6b02f655 1657 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1658
72ad093b
CY
16592011-08-17 Chong Yidong <cyd@stupidchicken.com>
1660
1661 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1662 (internal_condition_case_2, internal_condition_case_n):
1663 Remove unnecessary aborts (Bug#9081).
72ad093b 1664
35774242
EZ
16652011-08-17 Eli Zaretskii <eliz@gnu.org>
1666
1667 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1668 has no `load' handler, try opening the file locally. (Bug#9311)
1669
db76dd85
KB
16702011-08-16 Ken Brown <kbrown@cornell.edu>
1671
1672 * gmalloc.c: Expand comment.
1673
b215eee5
EZ
16742011-08-16 Eli Zaretskii <eliz@gnu.org>
1675
1676 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1677 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1678
a4579d33
KB
16792011-08-16 Ken Brown <kbrown@cornell.edu>
1680
1681 Fix memory allocation problems in Cygwin build (Bug#9273).
1682
1683 * unexcw.c ( __malloc_initialized): Declare external variable.
1684 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1685
8b76d6f8
SM
1686 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1687 New variables.
a4579d33
KB
1688 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1689 dumped emacs.
1690 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1691 in the static heap.
1692 [CYGWIN] (special_realloc): New function.
1693 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1694 requests to realloc storage in the static heap.
1695
3ebec551
PE
16962011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 * bidi.c (bidi_initialize): Remove unused local.
1699
9fd8be00
EZ
17002011-08-15 Eli Zaretskii <eliz@gnu.org>
1701
6b02f655
SM
1702 * bidimirror.h:
1703 * biditype.h: Remove file.
1704 * makefile.w32-in ($(BLD)/bidi.$(O)):
1705 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1706
1707 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1708
1709 * chartab.c: Improve commentary for the uniprop_table API.
1710
32413314
EZ
1711 * bidi.c (bidi_paragraph_init): Support zero value of
1712 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1713 (bidi_initialize): Use uniprop_table instead of including
1714 biditype.h and bidimirror.h.
32413314 1715
9fd8be00
EZ
1716 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1717 coordinates of the iterator when restoring from ppos_it.
1718 (Bug#9296)
1719
5cf2b69b
KH
17202011-08-14 Kenichi Handa <handa@m17n.org>
1721
1722 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1723 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1724
daf17d00
EZ
17252011-08-14 Eli Zaretskii <eliz@gnu.org>
1726
1727 * xdisp.c (move_it_in_display_line_to): Don't invoke
1728 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1729 ppos_it. Fixes vertical cursor motion when line beginning is
1730 covered by an image. (Bug#9296)
1731
08e3161a
JD
17322011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1733
1734 * nsterm.h (ns_run_ascript): Declare.
1735 (NSAPP_DATA2_RUNASSCRIPT): Define.
1736
1737 * nsfns.m (as_script, as_result, as_status): New static variables.
1738 (ns_run_ascript): New function.
5e617bc2 1739 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1740 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1741 the event loop. Get status from as_status (Bug#7276).
1742
1743 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1744 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1745 the event loop (Bug#7276).
1746
a3720aa2
AS
17472011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1748
1749 * gnutls.c (QCgnutls_bootprop_priority)
1750 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1751 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1752 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1753 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1754 (QCgnutls_bootprop_verify_hostname_error)
1755 (QCgnutls_bootprop_callbacks_verify): Rename from
1756 Qgnutls_bootprop_..., all uses changed.
1757
1758 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1759 uses changed.
1760
0a0d27fb
PE
17612011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1762
19d5c50c
PE
1763 * xfaces.c (Qframe_set_background_mode): Now static.
1764 * dispextern.h (Qframe_set_background_mode): Remove decl.
1765
0a0d27fb
PE
1766 * process.c (Fnetwork_interface_info): Declare local only if needed.
1767
377538cb
JD
17682011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1769
1770 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1771 (Fnetwork_interface_list): Allocate in increments of bytes instead
1772 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1773 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1774 sockaddr.
1775 (struct ifflag_def): notrailers is smart on OSX.
1776 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1777 Get hardware address with getifaddrs if available.
1778
08fff70c
EZ
17792011-08-12 Eli Zaretskii <eliz@gnu.org>
1780
1781 * xdisp.c (iterate_out_of_display_property): xassert that
1782 IT->position is set to within IT->object's boundaries. Break from
1783 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1784 when IT->position is set up wrongly due to some bug.
1785 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1786 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1787 entry. Force push_it to save on the stack the current
1788 buffer/string position, to be restored by pop_it. Fix flags in
1789 the iterator structure wrt the object coming from a display
1790 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1791 properties. (Bug#9284)
1792
7be1c708 17932011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1794
7be1c708
CY
1795 * fontset.c (fontset_get_font_group): Add proper type checks.
1796 (Bug#9172)
aac0c6e3 1797
7be1c708 17982011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1799
7be1c708
CY
1800 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1801 and LC_VERSION_MIN_MACOSX.
1802 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1803 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1804
97bb72a6
EZ
18052011-08-08 Eli Zaretskii <eliz@gnu.org>
1806
1807 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1808 no-display-properties-and-no-overlays under bidi display.
1809 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1810 properties and overlays.
97bb72a6 1811
d5617611
CY
18122011-08-08 Chong Yidong <cyd@stupidchicken.com>
1813
37e11a63
CY
1814 * editfns.c (Fset_time_zone_rule): Document relationship with the
1815 setenv function.
1816
d5617611
CY
1817 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1818 the font entity extracted from the cache (Bug#8109).
1819
58872834
CY
18202011-08-07 Chong Yidong <cyd@stupidchicken.com>
1821
1822 * composite.c (autocmp_chars): Don't reset point. That is done by
1823 restore_point_unwind (Bug#5984).
1824
75bfc667
JL
18252011-08-07 Juri Linkov <juri@jurta.org>
1826
1827 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1828 to show the arg `TIME' instead of `TIMEVAL'.
1829
d1410150
EZ
18302011-08-06 Eli Zaretskii <eliz@gnu.org>
1831
1832 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1833 display property strides EOL and includes a newline, as in
1834 longlines-mode. (Bug#9254)
75b771e4
EZ
1835 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1836 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1837
1838 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1839 is non-zero, even if the data buffer is NULL. Fixes a crash in
1840 vertical-motion with longlines-mode. (Bug#9254)
1841
35928349
EZ
18422011-08-05 Eli Zaretskii <eliz@gnu.org>
1843
ec7cc85b
EZ
1844 * bidi.c <bidi_cache_total_alloc>: Now static.
1845 (bidi_initialize): Initialize bidi_cache_total_alloc.
1846
8b76d6f8 1847 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1848 cache. (Bug#9221)
1849
1850 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1851 amount allocated this far in `bidi_cache_total_alloc'.
1852 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1853 non-zero, only free the data buffer without restoring the cache
1854 contents. All callers changed.
1855
1856 * dispextern.h (bidi_unshelve_cache): Update prototype.
1857
1858 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1859 (move_it_in_display_line, move_it_to)
1860 (move_it_vertically_backward, move_it_by_lines): Replace the call
1861 to xfree to an equivalent call to bidi_unshelve_cache.
1862 (move_it_in_display_line_to): Fix logic of returning
412b6358 1863 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1864
e2e2423b
EZ
18652011-08-05 Eli Zaretskii <eliz@gnu.org>
1866
1867 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1868 came from a string character with a `cursor' property. (Bug#9229)
1869
ae9e757a
JD
18702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1871
1872 * Makefile.in (LIB_PTHREAD): New variable.
1873 (LIBES): Add LIB_PTHREAD (Bug#9216).
1874
1875 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1876 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1877
213bd7f2
AS
18782011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1879
6b02f655 1880 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1881
99aaf75f
JD
18822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1883
1884 * xterm.c (x_find_topmost_parent): New function.
1885 (x_set_frame_alpha): Find topmost parent window with
1886 x_find_topmost_parent and set the property there also (bug#9181).
1887 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1888
c74e9d86
PE
18892011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 * callproc.c (Fcall_process): Avoid vfork clobbering
1892 the local vars buffer, coding_systems, current_dir.
1893
640c8776
SM
18942011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1895
1896 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1897
f26d0e4c
PE
18982011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1899
8a10d76c
PE
1900 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1901 so that it is not optimized away.
1902
f26d0e4c
PE
1903 * xdisp.c (compute_display_string_pos): Remove unused local.
1904
55439c61
EZ
19052011-08-02 Eli Zaretskii <eliz@gnu.org>
1906
1907 Fix slow cursor motion and scrolling in large buffers with
1908 selective display, like Org Mode buffers. (Bug#9218)
1909
1910 * dispextern.h (struct bidi_it): New member disp_prop_p.
1911
1912 * xdisp.c: Remove one-slot cache of display string positions.
1913 (compute_display_string_pos): Accept an additional argument
5e617bc2 1914 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1915 for a display string or property. If found, set DISP_PROP_P
1916 non-zero.
1917
1918 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1919 DISP_PROP_P, and pass it to compute_display_string_pos.
1920 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1921 non-zero. All callers of bidi_fetch_char changed.
1922
fb33fa43
SM
19232011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1924
1925 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1926
b099e063
DM
19272010-12-03 Don March <don@ohspite.net>
1928
1929 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1930 last character M-[char] is translated to ESC [char] (bug#7541).
1931
5cc7f7af
KH
19322011-08-02 Kenichi Handa <handa@m17n.org>
1933
d0fffa3f 1934 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1935
1936 * chartab.c (uniprop_table): Make it non-static.
1937
525d5e6e
EZ
19382011-08-01 Eli Zaretskii <eliz@gnu.org>
1939
1940 * xdisp.c (forward_to_next_line_start): Accept additional argument
1941 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1942 on the newline.
1943 (reseat_at_next_visible_line_start): Use the bidi iterator state
1944 returned by forward_to_next_line_start to restore the state of
1945 it->bidi_it after backing up to previous newline. (Bug#9212)
1946
31011111
AS
19472011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1948
1949 * regex.c (re_comp): Protoize.
1950 (re_exec): Fix return type.
1951 (regexec): Fix type of `ret'. (Bug#9203)
1952
476371c4
PE
19532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1954
e5d76069
PE
1955 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1956 This is needed if max-image-size is a floating-point number.
1957
9a79b20c
AS
19582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1959
1960 * print.c (print_object): Print empty symbol as ##.
1961
1962 * lread.c (read1): Read ## as empty symbol.
1963
d8c2fa78
AA
19642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1965
1966 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1967 setting frame foreground color (Bug#9175).
1968 (x_set_background_color): Likewise.
1969
ffe57a7a
AA
1970 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1971 contents (Bug#9176).
1972 (EmacsTooltip -init): Remove bezels and add shadows to
1973 tooltip windows.
1974
bf3492a5
AA
1975 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1976 or scroll bar (Bug#8470).
1977
d55e9c53
AA
1978 * nsfont.m (nsfont_open): Remove assignment to voffset and
1979 unnecessary vars hshink, expand, hd, full_height, min_height.
1980 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1981
1982 * nsterm.h (nsfont_info): Remove voffset field.
1983
d8c2fa78 19842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1985
1986 Implement strike-through and overline on NextStep (Bug#8863).
1987
1988 * nsfont.m (nsfont_open): Use underline position provided by font,
1989 instead of hard-coded value of 2.
1990 (nsfont_draw): Call ns_draw_text_decoration instead.
1991
1992 * nsterm.h: Add declaration for ns_draw_text_decoration.
1993
1994 * nsterm.m (ns_draw_text_decoration): New function for drawing
1995 underline, overline, and strike-through.
1996 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1997 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1998 accommodate underlining, etc.
4843aac3 1999
4cc60b9b
EZ
20002011-07-28 Eli Zaretskii <eliz@gnu.org>
2001
bc7ece87
EZ
2002 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2003 default.
4cc60b9b 2004
476371c4
PE
20052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2006
66606eea
PE
2007 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2008 Without this fix, if a signal arrives just after memory fills up,
2009 'malloc' might be invoked reentrantly.
2010
476371c4
PE
2011 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2012 In other words, assume that every image size is allowed, on non-X
2013 hosts. This assumption is probably wrong, but it lets Emacs compile.
2014
f3fcc40d
AS
20152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2016
2017 * regex.c (re_iswctype): Convert return values to boolean.
2018
350c992f
EZ
20192011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2020
2021 * xdisp.c (compute_display_string_pos): Don't use cached display
2022 string position if the buffer had its restriction changed.
2023 (Bug#9184)
2024
5266b4bb
PE
20252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2028
2573a837 20292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2030
41f55ccd 2031 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2032
39e378da
PE
2033 * bidi.c: Integer size and overflow fixes.
2034 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2035 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2036 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2037 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2038 (bidi_find_other_level_edge):
2039 Use ptrdiff_t instead of EMACS_INT where either will do.
2040 This works better on 32-bit hosts configured --with-wide-int.
2041 (bidi_cache_ensure_space): Check for size-calculation overflow.
2042 Use % rather than repeated addition, for better worst-case speed.
2043 Don't set bidi_cache_size until after xrealloc returns, because it
2044 might not return.
2045 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2046 (bidi_cache_ensure_space): Also check that the bidi cache size
2047 does not exceed that of the largest Lisp string or buffer. See Eli
2048 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2049
5e927815
PE
2050 * alloc.c (__malloc_size_t): Remove.
2051 All uses replaced by size_t. See Andreas Schwab's note
2052 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2053
ca4aa935
PE
2054 * image.c: Improve checking for integer overflow.
2055 (check_image_size): Assume that f is nonnull, since
2056 it is always nonnull in practice. This is one less thing to
2057 worry about when checking for integer overflow later.
2058 (x_check_image_size): New function, which checks for integer
2059 overflow issues inside X.
2060 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2061 This removes the need for a memory_full check.
2062 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2063 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2064 (xbm_read_bitmap_data): Change locals back to 'int', since
2065 their values must fit in 'int'.
2066 (xpm_load_image, png_load, tiff_load):
2067 Invoke x_create_x_image_and_pixmap earlier,
2068 to avoid much needless work if the image is too large.
2069 (tiff_load): Treat overly large images as if
2070 x_create_x_image_and_pixmap failed, not as malloc failures.
2071 (gs_load): Use x_check_image_size.
2072
5f8f9cc2
PE
2073 * gtkutil.c: Omit integer casts.
2074 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2075 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2076
5adf60bc
PE
2077 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2078
c8907a93
PE
2079 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2080 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2081 would wrongly return t on a 64-bit host.
2082
e3c25c68
PE
2083 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2084 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2085 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2086 and therefore cause GCC to emit a bogus diagnostic in some cases.
2087
3f791afe
PE
2088 * image.c: Integer signedness and overflow and related fixes.
2089 This is not an exhaustive set of fixes, but it's time to
2090 record what I've got.
2091 (lookup_pixel_color, check_image_size): Remove redundant decls.
2092 (check_image_size): Don't assume that arbitrary EMACS_INT values
2093 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2094 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2095 (tiff_load, imagemagick_load_image):
2096 Check for overflow in size calculations.
2097 (x_create_x_image_and_pixmap): Remove unnecessary test for
2098 xmalloc returning NULL; that can't happen.
2099 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2100 (xpm_color_bucket): Use better integer hashing function.
2101 (xpm_cache_color): Don't possibly over-allocate memory.
2102 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2103 (gif_memory_source):
2104 Use ptrdiff_t, not int or size_t, to record sizes.
2105 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2106 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2107 either works, as we prefer signed integers.
2108 (tiff_read_from_memory, tiff_write_from_memory):
2109 Return tsize_t, not size_t, since that's what the TIFF API wants.
2110 (tiff_read_from_memory): Don't fail simply because the read would
2111 go past EOF; instead, return a short read.
2112 (tiff_load): Omit no-longer-needed casts.
2113 (Fimagemagick_types): Don't assume size fits into 'int'.
2114
3cc5a532
PE
2115 Improve hashing quality when configured --with-wide-int.
2116 * fns.c (hash_string): New function, taken from sxhash_string.
2117 Do not discard information about ASCII character case; this
2118 discarding is no longer needed.
2119 (sxhash-string): Use it. Change sig to match it. Caller changed.
2120 * lisp.h: Declare it.
2121 * lread.c (hash_string): Remove, since we now use fns.c's version.
2122 The fns.c version returns a wider integer if --with-wide-int is
2123 specified, so this should help the quality of the hashing a bit.
2124
b312a492
PE
2125 * emacs.c: Integer overflow minor fix.
2126 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2127 Define only if GNU_LINUX.
2128 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2129
dfd153ae
PE
2130 * dispnew.c: Integer signedness and overflow fixes.
2131 Remove unnecessary forward decls, that were a maintenance hassle.
2132 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2133 All uses changed.
2134 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2135 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2136 (prepare_desired_row, line_draw_cost):
2137 Use int, not unsigned, where either works.
2138 (save_current_matrix, restore_current_matrix):
2139 Use ptrdiff_t, not size_t, where either works.
2140 (init_display): Check for overflow more accurately, and without
2141 relying on undefined behavior.
2142
a81d11a3
PE
2143 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2144 Remove, replacing with the new symbols in lisp.h. All uses changed.
2145 * fileio.c (make_temp_name):
2146 * filelock.c (lock_file_1, lock_file):
2147 * xdisp.c (message_dolog):
2148 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2149 Use pMd etc. instead.
2150 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2151 replacing the pWIDE etc. symbols removed from editfns.c.
2152
3300e6fd
PE
2153 * keyboard.h (num_input_events): Now uintmax_t.
2154 This is (very slightly) less likely to mess up due to wraparound.
2155 All uses changed.
2156
fd05c7e9
PE
2157 * buffer.c: Integer signedness fixes.
2158 (alloc_buffer_text, enlarge_buffer_text):
2159 Use ptrdiff_t rather than size_t when either will do, as we prefer
2160 signed integers.
2161
903fe15d
PE
2162 * alloc.c: Integer signedness and overflow fixes.
2163 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2164 (__malloc_size_t): Default to size_t, not to int.
2165 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2166 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2167 Prefer ptrdiff_t to size_t when either would do, as we prefer
2168 signed integers.
2169 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2170 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2171 Now const. Initialize with values that are in range even if char
2172 is signed.
2173 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2174 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2175 These functions do the right thing with sizes > 2**32.
2176 (check_depth): Now ptrdiff_t, not int.
2177 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2178 Adjust to new way of storing sizes. Check for size overflow bugs
2179 in rest of code.
2180 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2181 slightly wrong anyway, as it missed one instance of
2182 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2183 (refill_memory_reserve): Omit needless cast to size_t.
2184 (mark_object_loop_halt): Mark as externally visible.
2185
ac82cc6a
PE
2186 * xselect.c: Integer signedness and overflow fixes.
2187 (Fx_register_dnd_atom, x_handle_dnd_message):
2188 Use ptrdiff_t, not size_t, since we prefer signed.
2189 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2190 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2191 x_dnd_atoms_size and x_dnd_atoms_length.
2192
c2d1e36d
PE
2193 * doprnt.c: Prefer signed to unsigned when either works.
2194 * eval.c (verror):
2195 * doprnt.c (doprnt):
2196 * lisp.h (doprnt):
2197 * xdisp.c (vmessage):
2198 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2199 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2200 prefer signed arithmetic to avoid comparison confusion.
2201 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2202 but is a bit tricky.
2203
0e926e56
PE
2204 Assume freestanding C89 headers, string.h, stdlib.h.
2205 * data.c, doprnt.c, floatfns.c, print.c:
2206 Include float.h unconditionally.
2207 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2208 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2209 * regex.c: Likewise for stddef.h, string.h.
2210 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2211 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2212 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2213 (STDC_HEADERS): Remove obsolete defines.
2214 * sysdep.c: Include limits.h unconditionally.
2215
9cfdb3ec
PE
2216 Assume support for memcmp, memcpy, memmove, memset.
2217 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2218 * regex.c (memcmp, memcpy):
2219 Remove; we assume C89 now.
2220
2221 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2222 (__malloc_safe_bcopy): Remove; no longer needed.
2223
cf950e6b 2224 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2225 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2226 well either way, and we prefer signed to unsigned.
2227
dbf38e02
LMI
22282011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2229
2230 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2231 closes the connection while we're reading (bug#9182).
2232
d6f0886c 22332011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2234
d6f0886c
JD
2235 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2236 are specified (Bug#9168).
24e0f6b1 2237
2eb1f9e6
PE
22382011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2241 Found by GCC static checking and --with-wide-int on a 32-bit host.
2242
22381272 22432011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2244
2245 * xdisp.c (compute_display_string_pos): Fix logic of caching
2246 previous display string position. Initialize cached_prev_pos to
2247 -1. Fixes slow-down at the beginning of a buffer.
2248
f25e39b4
EZ
22492011-07-24 Eli Zaretskii <eliz@gnu.org>
2250
2251 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2252 for attrs[LFACE_FONTSET_INDEX].
2253
04c4b52e
PE
22542011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 * xml.c (parse_region): Remove unused local
2257 that was recently introduced.
2258
c1734fbd
EZ
22592011-07-23 Eli Zaretskii <eliz@gnu.org>
2260
be18c5a5
EZ
2261 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2262 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2263
c1734fbd
EZ
2264 * xdisp.c (move_it_in_display_line_to): Record the best matching
2265 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2266 exit if none of the characters scanned was an exact match.
2267 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2268 when exact match is impossible due to invisible text, and the
2269 lines are truncated.
2270
a258d627
JD
22712011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2272
2273 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2274 for OSX >= 10.7.
2275
b6d5a689
EZ
22762011-07-22 Eli Zaretskii <eliz@gnu.org>
2277
0f74f785
EZ
2278 Fix a significant slow-down of cursor motion with C-n, C-p,
2279 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2280 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2281 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2282 (next_element_from_buffer): Call compute_stop_pos_backwards to
2283 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2284 base_level_stop.
2285 (reseat): Don't look for prev_stop, as that could mean a very long
2286 run.
2287 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2288 <cached_disp_overlay_modiff>: Cache for last found display string
2289 position.
551918c1 2290 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2291 about the same buffer in the same area of character positions, and
2292 the buffer wasn't changed since the time the display string
2293 position was cached.
551918c1 2294
b2d0c91a
EZ
22952011-07-22 Eli Zaretskii <eliz@gnu.org>
2296
2297 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2298 is an integer, which is important for empty lines. (Bug#9149)
2299
043604ee
CY
23002011-07-22 Chong Yidong <cyd@stupidchicken.com>
2301
2302 * frame.c (Fmodify_frame_parameters): In tty case, update the
2303 default face if necessary (Bug#4238).
2304
da4adb04
CY
23052011-07-21 Chong Yidong <cyd@stupidchicken.com>
2306
2307 * editfns.c (Fstring_to_char): No need to explain what a character
2308 is in the docstring (Bug#6576).
2309
9abd0532
LMI
23102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2311
2312 * xml.c (parse_region): Make sure we always return a tree.
2313
36881d16
HK
23142011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2315
2316 * xml.c (parse_region): If a document contains only comments,
2317 return that, too.
2318
1e98674d
LMI
23192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2320
2321 * xml.c (make_dom): Return comments, too.
2322
590bd467
PE
23232011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2324
2325 Port to OpenBSD.
2326 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2327 and the surrounding thread.
2328 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2329 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2330 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2331 timer goes off.
2332 * s/openbsd.h (BROKEN_SIGIO): Define.
2333 * unexelf.c (unexec) [__OpenBSD__]:
2334 Don't update the .mdebug section of the Alpha COFF symbol table.
2335
f41628b2
LMI
23362011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2337
2338 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2339 (bug#8460).
2340
b59b67c5
PE
23412011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2342
15e3a074
PE
2343 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2344 This fixes some race conditions on the permissions of any newly
2345 created file.
2346
41bed37d
PE
2347 * alloc.c (valid_pointer_p): Use pipe, not open.
2348 This fixes some permissions issues when debugging.
2349
b59b67c5
PE
2350 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2351 If fchown fails to set both uid and gid, try to set just gid,
2352 as that is sometimes allowed. Adjust the file's mode to eliminate
2353 setuid or setgid bits that are inappropriate if fchown fails.
2354
925a6be7
SM
23552011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2356
2357 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2358 to compare Lisp_Objects.
2359 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2360 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2361 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2362
52968808
AS
23632011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2364
0a6a104b
AS
2365 * lread.c (read_integer): Unread even EOF character.
2366 (read1): Likewise. Properly record start position of symbol.
2367
52968808
AS
2368 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2369 symbol character follows.
2370
9e381cdd
PE
23712011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2374 This works around a problem with the previous change to Fcopy_file.
2375 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2376 and without this change, GCC might complain about discarding
2377 fchown's return value.
2378
b5641435
JB
23792011-07-16 Juanma Barranquero <lekktu@gmail.com>
2380
2381 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2382
a8031457
PE
23832011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2386
dd889327
LMI
23872011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2388
750c33f7
LMI
2389 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2390 it's used from the C level.
2391
dd889327
LMI
2392 * process.c: Use the same condition for POLL_FOR_INPUT in both
2393 keyboard.c and process.c (bug#1858).
2394
87e86684
LM
23952011-07-09 Lawrence Mitchell <wence@gmx.li>
2396
2397 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2398 (Fgnutls_boot): Use it.
2399
64348f40
AS
24002011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2401
2402 * doc.c (Fsubstitute_command_keys): Revert last change.
2403
1d698799
LMI
24042011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2405
f863868c
LMI
2406 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2407 quotes the next character, and doesn't affect other longer
2408 sequences (bug#8935).
2409
1d698799
LMI
2410 * lread.c (syms_of_lread): Clarify that is isn't only
2411 `eval-buffer' and `eval-defun' that's affected by
2412 `lexical-binding' (bug#8460).
2413
aa4b6df6
EZ
24142011-07-15 Eli Zaretskii <eliz@gnu.org>
2415
2416 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2417 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2418
5d856da6
PE
24192011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2420
ad6042bb
PE
2421 Fix minor problems found by static checking.
2422 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2423 (elsz): Now a signed constant, not a size_t var. We prefer signed
2424 types to unsigned, to avoid integer comparison confusion. Without
2425 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2426 "cannot optimize loop, the loop counter may overflow", a symptom
2427 of the confusion.
f00bbb22 2428 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2429 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2430
6468f31c
LMI
24312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2432
49080b10
LMI
2433 * search.c (Fre_search_backward): Mention `case-fold-search' in
2434 all the re_search_* functions (bug#8138).
2435
6468f31c
LMI
2436 * keyboard.c (Fopen_dribble_file): Document when the file is
2437 closed (bug#8056).
2438
c965adc5
EZ
24392011-07-14 Eli Zaretskii <eliz@gnu.org>
2440
df9733bf
EZ
2441 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2442 bidi_cache_idx.
2443
0bb23927
EZ
2444 Support bidi reordering of display and overlay strings.
2445 * xdisp.c (compute_display_string_pos)
2446 (compute_display_string_end): Accept additional argument STRING.
2447 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2448 (reseat_to_string): Initialize bidi_it->string.s and
2449 bidi_it->string.schars.
2450 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2451 NULL (avoids a crash in bidi_paragraph_init).
2452 Initialize itb.string.lstring.
0bb23927
EZ
2453 (init_iterator): Call bidi_init_it only of a valid
2454 buffer position was specified. Initialize paragraph_embedding to
2455 L2R.
2456 (reseat_to_string): Initialize the bidi iterator.
2457 (display_string): If we need to ignore text properties of
2458 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2459 original value of -1 will not work with bidi.)
2460 (compute_display_string_pos): First arg is now struct
2461 `text_pos *'; all callers changed. Support display properties on
2462 Lisp strings.
2463 (compute_display_string_end): Support display properties on Lisp
2464 strings.
2465 (init_iterator, reseat_1, reseat_to_string): Initialize the
2466 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2467 when iterating on a string not from display properties).
640c8776
SM
2468 (compute_display_string_pos, compute_display_string_end):
2469 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2470 arrow keys.
2471 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2472 base_level_stop; instead, set base_level_stop to BEGV.
2473 Fixes crashes in vertical-motion.
0bb23927
EZ
2474 (next_element_from_buffer): Improve commentary for when
2475 the iterator is before prev_stop.
2476 (init_iterator): Initialize bidi_p from the default value of
2477 bidi-display-reordering, not from buffer-local value. Use the
2478 buffer-local value only if initializing for buffer iteration.
2479 (handle_invisible_prop): Support invisible properties on strings
2480 that are being bidi-reordered.
2481 (set_iterator_to_next): Support bidi reordering of C strings and
2482 Lisp strings.
2483 (next_element_from_string): Support bidi reordering of Lisp
2484 strings.
2485 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2486 (display_string): Support display of R2L glyph rows.
2487 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2488 (init_iterator): Don't initialize it->bidi_p for strings
2489 here.
2490 (reseat_to_string): Initialize it->bidi_p for strings here.
2491 (next_element_from_string, next_element_from_c_string)
2492 (next_element_from_buffer): Add xassert's for correspondence
2493 between IT's object being iterated and it->bidi_it.string
2494 structure.
2495 (face_before_or_after_it_pos): Support bidi iteration.
2496 (next_element_from_c_string): Handle the case of the first string
2497 character that is not the first one in the visual order.
2498 (get_visually_first_element): New function, refactored from common
2499 parts of next_element_from_buffer, next_element_from_string, and
2500 next_element_from_c_string.
2501 (tool_bar_lines_needed, redisplay_tool_bar)
2502 (display_menu_bar): Force left-to-right direction. Add a FIXME
2503 comment for making that be controlled by a user option.
2504 (push_it, pop_it): Save and restore the state of the
2505 bidi iterator. Save and restore the bidi_p flag.
2506 (pop_it): Iterate out of display property for string iteration as
2507 well.
2508 (iterate_out_of_display_property): Support iteration over strings.
2509 (handle_single_display_spec): Set up it->bidi_it for iteration
2510 over a display string, and call bidi_init_it.
2511 (handle_single_display_spec, next_overlay_string)
2512 (get_overlay_strings_1, push_display_prop): Set up the bidi
2513 iterator for displaying display or overlay strings.
2514 (forward_to_next_line_start): Don't use the shortcut if
2515 bidi-iterating.
2516 (back_to_previous_visible_line_start): If handle_display_prop
2517 pushed the iterator stack, restore the internal state of the bidi
2518 iterator by calling bidi_pop_it same number of times.
2519 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2520 and we are bidi-iterating, don't decrement the iterator position;
2521 instead, set the first_elt flag in the bidi iterator, to produce
2522 the same effect.
2523 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2524 (push_display_prop): xassert that we are iterating a buffer.
2525 (push_it, pop_it): Save and restore paragraph_embedding member.
2526 (handle_single_display_spec, next_overlay_string)
2527 (get_overlay_strings_1, reseat_1, reseat_to_string)
2528 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2529 correctly. Don't assume unibyte strings are not bidi-reordered.
2530 (compute_display_string_pos)
2531 (compute_display_string_end): Fix handling the case of C string.
2532 (push_it, pop_it): Save and restore from_disp_prop_p.
2533 (handle_single_display_spec, push_display_prop): Set the
2534 from_disp_prop_p flag.
2535 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2536 (pop_it): Call iterate_out_of_display_property only if we are
2537 popping after iteration over a string that came from a display
2538 property. Fix a typo in popping stretch info. Add an assertion
2539 for verifying that the iterator position is in sync with the bidi
2540 iterator.
2541 (handle_single_display_spec, get_overlay_strings_1)
2542 (push_display_prop): Fix initialization of paragraph direction for
2543 string when that of the parent object is not yet determined.
2544 (reseat_1): Call bidi_init_it to resync the bidi
2545 iterator with IT's position. (Bug#7616)
2546 (find_row_edges): If ROW->start.pos gives position
2547 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2548 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2549 Reset the from_disp_prop_p flag.
2550 (SAVE_IT, RESTORE_IT): New macros.
2551 (pos_visible_p, face_before_or_after_it_pos)
2552 (back_to_previous_visible_line_start)
2553 (move_it_in_display_line_to, move_it_in_display_line)
2554 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2555 (try_scrolling, redisplay_window, display_line): Use them when
2556 saving a temporary copy of the iterator and restoring it back.
2557 (back_to_previous_visible_line_start, reseat_1)
2558 (init_iterator): Empty the bidi cache "stack".
2559 (move_it_in_display_line_to): If iterator ended up at
2560 EOL, but we never saw any buffer positions smaller than
2561 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2562 motion in bidi-reordered lines.
2563 (move_it_in_display_line_to): Record prev_method and prev_pos
2564 immediately before the call to set_iterator_to_next. Fixes cursor
2565 motion in bidi-reordered lines with stretch glyphs and strings
2566 displayed in margins. (Bug#8133) (Bug#8867)
2567 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2568 TO_CHARPOS.
640c8776
SM
2569 (pos_visible_p): Support positions in bidi-reordered lines.
2570 Save and restore bidi cache.
0bb23927
EZ
2571
2572 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2573 (bidi_paragraph_info): Delete unused struct.
2574 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2575 (bidi_cache_start): New variable.
2576 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2577 to zero.
2578 (bidi_cache_fetch_state, bidi_cache_search)
2579 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2580 (bidi_cache_find, bidi_peek_at_next_level)
2581 (bidi_level_of_next_char, bidi_find_other_level_edge)
2582 (bidi_move_to_visually_next): Compare cache index with
2583 bidi_cache_start rather than with zero.
2584 (bidi_fetch_char): Accept new argument STRING; all callers
2585 changed. Support iteration over a string. Support strings with
2586 display properties. Support unibyte strings. Fix the type of
2587 `len' according to what STRING_CHAR_AND_LENGTH expects.
2588 (bidi_paragraph_init, bidi_resolve_explicit_1)
2589 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2590 (bidi_level_of_next_char, bidi_move_to_visually_next):
2591 Support iteration over a string.
0bb23927
EZ
2592 (bidi_set_sor_type, bidi_resolve_explicit_1)
2593 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2594 can now be zero (for strings); special values 0 and -1 were
2595 changed to -1 and -2, respectively.
2596 (bidi_char_at_pos): New function.
2597 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2598 Call it instead of FETCH_MULTIBYTE_CHAR.
2599 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2600 initialized to valid values.
2601 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2602 values.
2603 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2604 the test for valid cached positions. Fix the logic for looking up
2605 the sentinel state in the cache. GCPRO the Lisp string we are
2606 iterating.
2607 (bidi_push_it, bidi_pop_it): New functions.
2608 (bidi_initialize): Initialize the bidi cache start stack pointer.
2609 (bidi_cache_ensure_space): New function, refactored from part of
2610 bidi_cache_iterator_state. Don't assume the required size is just
2611 one BIDI_CACHE_CHUNK away.
2612 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2613 (bidi_count_bytes, bidi_char_at_pos): New functions.
2614 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2615 always valid if bidi_cache_idx is valid.
2616 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2617 is valid if it's going to be used.
2618 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2619 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2620 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2621 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2622 (bidi_find_other_level_edge, bidi_cache_start_stack):
2623 All variables related to cache indices are now EMACS_INT.
c965adc5 2624
0bb23927
EZ
2625 * dispextern.h (struct bidi_string_data): New structure.
2626 (struct bidi_it): New member `string'. Make flag members be 1-bit
2627 fields, and put them last in the struct.
640c8776
SM
2628 (compute_display_string_pos, compute_display_string_end):
2629 Update prototypes.
0bb23927
EZ
2630 (bidi_push_it, bidi_pop_it): Add prototypes.
2631 (struct iterator_stack_entry): New members bidi_p,
2632 paragraph_embedding, and from_disp_prop_p.
2633 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2634 (bidi_shelve_cache, bidi_unshelve_cache):
2635 Declare prototypes.
0bb23927
EZ
2636
2637 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2638 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2639 and vector-like objects.
2640
2641 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2642 cache around display iteration.
2643
2644 * window.c (Fwindow_end, window_scroll_pixel_based)
2645 (displayed_window_lines, Frecenter): Save and restore the bidi
2646 cache around display iteration.
2647
3bbd2265
LMI
26482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2649
2650 * editfns.c (Fdelete_region): Clarify the use of the named
2651 parameters (bug#6788).
2652
adc47434
MR
26532011-07-14 Martin Rudalics <rudalics@gmx.at>
2654
2655 * indent.c (Fvertical_motion): Set and restore w->pointm when
2656 saving and restoring the window's buffer (Bug#9006).
2657
837c31f8
LMI
26582011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2659
2660 * editfns.c (Fstring_to_char): Clarify just what is returned
2661 (bug#6576). Text by Eli Zaretskii.
2662
ac389d0c
JB
26632011-07-13 Juanma Barranquero <lekktu@gmail.com>
2664
2665 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2666
0be0ce47
EZ
26672011-07-13 Eli Zaretskii <eliz@gnu.org>
2668
2669 * buffer.c (mmap_find): Fix a typo.
2670
cd18e7e3
JB
26712011-07-13 Johan Bockgård <bojohan@gnu.org>
2672
2673 Fix execution of x selection hooks.
2674 * xselect.c (Qx_lost_selection_functions)
2675 (Qx_sent_selection_functions): New vars.
2676 (syms_of_xselect): DEFSYM them.
2677 (x_handle_selection_request): Pass Qx_sent_selection_functions
2678 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2679 (x_handle_selection_clear,x_clear_frame_selections):
2680 Pass Qx_lost_selection_functions rather than
2681 Vx_lost_selection_functions to Frun_hook_with_args.
2682
47ea7f44
PE
26832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2684
ac389d0c 2685 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2686 The old code sometimes used this field without initializing it.
2687
47ea7f44
PE
2688 * alloc.c (gc_sweep): Don't read past end of array.
2689 In theory, the old code could also have corrupted Emacs internals,
2690 though it'd be very unlikely.
2691
bc985c87
AS
26922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2693
2694 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2695 argument. (Bug#4026)
bc985c87 2696
0cf34688
LMI
26972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2698
b3dadd76
LMI
2699 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2700 key" (bug#4257).
2701
0cf34688
LMI
2702 * window.c (Fset_window_start): Doc fix (bug#4199).
2703 (Fset_window_hscroll): Ditto.
2704
270768cd
PE
27052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2706
077e3dda 2707 Fix minor new problems caught by GCC 4.6.1.
270768cd 2708 * term.c (init_tty): Remove unused local.
490011a6 2709 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2710 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2711 not used otherwise.
270768cd 2712
b1f58454
CY
27132011-07-12 Chong Yidong <cyd@stupidchicken.com>
2714
2715 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2716
22b9578d
LMI
27172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2718
6e70ab07
LMI
2719 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2720 are the mini-buffer and the echo area (bug#3320).
2721
22b9578d
LMI
2722 * term.c (init_tty): Remove support for supdup, c10 and perq
2723 terminals, which are no longer supported (bug#1482).
2724
8974cc9f
JB
27252011-07-10 Johan Bockgård <bojohan@gnu.org>
2726
2727 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2728
a560d974
JD
27292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2730
2731 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2732 for non-popups (Bug#3642).
2733
1dae0f0a
AS
27342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2735
268c2c36 2736 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2737 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2738 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2739 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2740 * data.c (fmod): Likewise.
2741 * dispnew.c (swap_glyphs_in_rows): Likewise.
2742 * emacs.c (memory_warning_signal): Likewise.
2743 * floatfns.c (float_error): Likewise.
2744 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2745 (otf_open, font_otf_capability, generate_otf_features)
2746 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2747 Likewise.
2748 * image.c (pbm_read_file): Likewise.
2749 * indent.c (string_display_width): Likewise.
2750 * intervals.c (check_for_interval, search_for_interval)
2751 (inc_interval_count, count_intervals, root_interval)
2752 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2753 * lread.c (defalias): Likewise.
268c2c36 2754 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2755 * regex.c (set_image_of_range_1, set_image_of_range)
2756 (regex_grow_registers): Likewise.
2757 * sysdep.c (strerror): Likewise.
2758 * termcap.c (valid_filename_p, tprint, main): Likewise.
2759 * tparam.c (main): Likewise.
2760 * unexhp9k800.c (run_time_remap, save_data_space)
2761 (update_file_ptrs, read_header, write_header, calculate_checksum)
2762 (copy_file, copy_rest, display_header): Likewise.
2763 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2764 Likewise.
2765 * xdisp.c (check_it): Likewise.
2766 * xfaces.c (register_color, unregister_color, unregister_colors):
2767 Likewise.
2768 * xfns.c (print_fontset_result): Likewise.
2769 * xrdb.c (member, fatal, main): Likewise.
2770
99033785
PE
27712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 Fix minor problems found by static checking (Bug#9031).
2774 * chartab.c (char_table_set_range, map_sub_char_table):
2775 Remove unused locals.
2776 (uniprop_table): Now static.
2777 * composite.c (_work_char): Remove unused static var.
2778
9cb2ac56
JB
27792011-07-09 Juanma Barranquero <lekktu@gmail.com>
2780
2781 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2782
f25661f0
JD
27832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2784
2785 * gtkutil.c (qttip_cb): Remove code without function.
2786
8278c4fe
EZ
27872011-07-09 Eli Zaretskii <eliz@gnu.org>
2788
2789 * w32.c (pthread_sigmask): New stub.
2790
1692ae2d 27912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2792
8a6ebd58 2793 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2794 sigprocmask is portable only for single-threaded applications, and
2795 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2796 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2797 (LIBES): Use it.
2798 * callproc.c (Fcall_process):
2799 * process.c (create_process):
2800 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2801 Use pthread_sigmask, not sigprocmask.
123403e4 2802
1b854618
JD
28032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2804
2805 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2806 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2807 wrong (Bug#8591).
2808
3fe4b549
JD
28092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2810
0ce7e563
JD
2811 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2812 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2813 (xg_hide_tooltip): Fix comment.
2814
3fe4b549
JD
2815 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2816 in registerServicesMenuSendTypes.
2817 (validRequestorForSendType): Don't check ns_return_types.
2818
2819 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2820 ns_return_type.
2821
5df75e47
JR
28222011-07-08 Jason Rumney <jasonr@gnu.org>
2823
22610910
JR
2824 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2825 SH_SHOW for hidden windows (Bug#5482).
2826
5df75e47
JR
2827 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2828 frame struct members of non-existent frames (Bug#6284).
2829
699c10bd
JD
28302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2831
4393663b
JD
2832 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2833 variable firstTime not needed on OSX >= 10.6.
2834 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2835 >= 10.5. Use setKnobProportion, setDoubleValue.
2836
2837 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2838 (MAC_OS_X_VERSION_10_5): Define if not defined.
2839 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2840 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2841 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2842
2843 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2844 cString and lossyCString on OSX >= 10.4
2845
2846 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2847 sizeToFit on OSX >= 10.2.
2848
2849 * nsimage.m (allocInitFromFile): Don't use deprecated method
2850 bestRepresentationForDevice on OSX >= 10.6.
2851
2852 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2853 to avoid warning.
2854
2855 * emacs.c: Declare unexec_init_emacs_zone.
2856
a63e0781
JD
2857 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2858
699c10bd
JD
2859 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2860
2861 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2862 on svcsMenu (Bug#8842).
2863
2864 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2865 ns_return_types.
2866 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2867
2868 * nsterm.m (QUTF8_STRING): Declare.
2869 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2870 (validRequestorForSendType): Return type is (id).
2871 Change indexOfObjectIdenticalTo to indexOfObject.
2872 Check if we have local selection before returning self (Bug#8842).
2873 (writeSelectionToPasteboard): Put local selection into paste board
2874 if we have a local selection (Bug#8842).
2875 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2876
2877 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2878 (ns_get_local_selection): Declare.
2879
54e10184
LMI
28802011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2881
9888ff71
LMI
2882 * keymap.c (describe_map_tree): Don't insert a double newline at
2883 the end of the buffer (bug#1169) and return whether we inserted
2884 something.
2885
54e10184
LMI
2886 * callint.c (Fcall_interactively): Change "reading args" to
2887 "providing args" to try to clarify what it does (bug#1010).
2888
15fa4783
KH
28892011-07-07 Kenichi Handa <handa@m17n.org>
2890
2891 * composite.c (composition_compute_stop_pos): Ignore a static
2892 composition starting before CHARPOS (Bug#8915).
2893
2894 * xdisp.c (handle_composition_prop): Likewise.
2895
a8815b00
EZ
28962011-07-07 Eli Zaretskii <eliz@gnu.org>
2897
2898 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2899 (Bug#9015)
2900
ef7b981d 29012011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2902
2903 * character.h (unicode_category_t): New enum type.
2904
2905 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2906 (Qchar_code_property_table): New variable.
2907 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2908 (UNIPROP_COMPRESSED_FORM_P): New macros.
2909 (char_table_ascii): Uncompress the compressed values.
2910 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2911 Uncompress the compressed values.
ac389d0c 2912 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2913 (char_table_ref_and_range): Uncompress the compressed values.
2914 (sub_char_table_set): New arg is_uniprop. Callers changed.
2915 Uncompress the compressed values.
2916 (sub_char_table_set_range): Args changed. Callers changed.
2917 (char_table_set_range): Adjuted for the above change.
2918 (map_sub_char_table): Delete args default_val and parent. Add arg
2919 top. Give decoded values to a Lisp function.
640c8776 2920 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2921 values to a Lisp function. Gcpro more variables.
2922 (uniprop_table_uncompress)
2923 (uniprop_decode_value_run_length): New functions.
2924 (uniprop_decoder, uniprop_decoder_count): New variables.
2925 (uniprop_get_decoder, uniprop_encode_value_character)
2926 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2927 New functions.
2928 (uniprop_encoder, uniprop_encoder_count): New variables.
2929 (uniprop_get_encoder, uniprop_table)
2930 (Funicode_property_table_internal, Fget_unicode_property_internal)
2931 (Fput_unicode_property_internal): New functions.
2932 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2933 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2934 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2935 char-code-property-alist.
2936
640c8776 2937 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2938 Vunicode_category_table.
2939
640c8776 2940 * font.c (font_range): Adjust for the change of
c805dec0
KH
2941 Vunicode_category_table.
2942
76b397fb
DN
29432011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2944
2945 * m/iris4d.h: Remove file, move contents ...
2946 * s/irix6-5.h: ... here.
2947
22b4128e
PE
29482011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2951 * alloc.c (mark_buffer):
2952 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2953 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2954 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2955 This isn't true in general, and it's particularly not true
2956 if Emacs is configured with --with-wide-int.
2957 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2958 New macros, used in the buffer.c change.
2959
869795d6
JD
29602011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2961
2962 * xsettings.c: Use both GConf and GSettings if both are available.
2963 (store_config_changed_event): Add comment.
2964 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2965 (store_tool_bar_style_changed): New functions.
5e617bc2 2966 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2967 (struct xsettings): Move font inside HAVE_XFT.
2968 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2969 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2970 Move inside HAVE_XFT.
640c8776 2971 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2972 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2973 also.
2974 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2975 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2976 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2977 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2978 (parse_settings): Move check for font inside HAVE_XFT.
2979 (read_settings, apply_xft_settings): Add comment.
2980 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2981 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2982 call store_font_name_changed.
2983 (xft_settings_event): Add comment.
2984 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2985 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2986 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2987 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2988 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2989 (xsettings_get_system_font, xsettings_get_system_normal_font):
2990 Add comment.
869795d6 2991
d8ed26bd
PE
29922011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2993
2994 Random fixes. E.g., (random) never returned negative values.
2995 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2996 subseconds part to the entropy, as that's a bit more random.
2997 Prefer signed to unsigned, since the signedness doesn't matter and
2998 in general we prefer signed. When given a limit, use a
2999 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3000 latter isn't right if USE_2_TAGS_FOR_INTS.
3001 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3002 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3003
cabf1cac
SM
30042011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3005
3006 * textprop.c (text_property_stickiness):
3007 Obey Vtext_property_default_nonsticky.
3008 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3009 * w32fns.c (syms_of_w32fns):
3010 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3011
6e9b2be9
PE
30122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3013
3014 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3015 This is more efficient than Ffile_directory_p and avoids a minor race.
3016
90186c68
LMI
30172011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3018
7c301272
LMI
3019 * buffer.c (Foverlay_put): Say what the return value is
3020 (bug#7835).
3021
c4f2d8d4
LMI
3022 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3023 is a directory before asking whether to use the file name
3024 (bug#7564).
ad637907
LMI
3025 (barf_or_query_if_file_exists): Make the "File is a directory"
3026 error be more correct.
c4f2d8d4 3027
90186c68
LMI
3028 * fns.c (Frequire): Remove the mention of the .gz files, since
3029 that's installation-specific, but keep the mention of
3030 `get-load-suffixes'.
3031
da64016e
PE
30322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3033
3034 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3035 Report string overflow if the output is too long.
3036
7d47b580
JB
30372011-07-04 Juanma Barranquero <lekktu@gmail.com>
3038
a555cb87
JB
3039 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3040 (syms_of_gnutls): Remove duplicate DEFSYM for
3041 Qgnutls_bootprop_verify_hostname_error, an error for
3042 Qgnutls_bootprop_verify_error (which is no longer used).
3043
7d47b580
JB
3044 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3045 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3046 Also (re)move comments that are misplaced or no longer relevant.
3047
1e49bfab
LMI
30482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3049
3050 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3051
1485f4c0
CY
30522011-07-03 Chong Yidong <cyd@stupidchicken.com>
3053
3054 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3055 and background color parameters if they have been changed.
3056
a9ab721e
LMI
30572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3058
3059 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3060
cf7cff57
PE
30612011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3062
2e13213d
PE
3063 * xsettings.c (SYSTEM_FONT): Define only when used.
3064 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3065
cf7cff57
PE
3066 * keymap.c (access_keymap_1): Now static.
3067
7a8e04f7
CY
30682011-07-02 Chong Yidong <cyd@stupidchicken.com>
3069
3070 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3071 leave any prefix arg for the up event (Bug#1586).
3072
61352f62
LMI
30732011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3074
69bb1ef7
LMI
3075 * lread.c (syms_of_lread): Mention single symbols defined by
3076 `defvar' or `defconst' (bug#7154).
3077
61352f62 3078 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3079 (Frequire): Mention get-load-suffixes.
61352f62 3080
28545e04
MR
30812011-07-02 Martin Rudalics <rudalics@gmx.at>
3082
3083 * window.h (window): Remove clone_number slot.
3084 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3085 Remove.
3086 (make_parent_window, make_window, saved_window)
3087 (Fset_window_configuration, save_window_save): Don't deal with
3088 clone numbers.
3089 * buffer.c (Qclone_number): Remove declaration.
3090 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3091
3349e122
SM
30922011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3093
3094 Add multiple inheritance to keymaps.
3095 * keymap.c (Fmake_composed_keymap): New function.
3096 (Fset_keymap_parent): Simplify.
3097 (fix_submap_inheritance): Remove.
3098 (access_keymap_1): New function extracted from access_keymap to handle
3099 embedded parents and handle lists of maps.
3100 (access_keymap): Use it.
3101 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3102 (Fcopy_keymap): Handle embedded parents.
3103 (Fcommand_remapping, define_as_prefix): Simplify.
3104 (Fkey_binding): Simplify.
3105 (syms_of_keymap): Move minibuffer-local-completion-map,
3106 minibuffer-local-filename-completion-map,
3107 minibuffer-local-must-match-map, and
3108 minibuffer-local-filename-must-match-map to Elisp.
3109 (syms_of_keymap): Defsubr make-composed-keymap.
3110 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3111 (parse_menu_item): Trivial simplification.
3112
3279eb87
GM
31132011-07-01 Glenn Morris <rgm@gnu.org>
3114
3115 * Makefile.in (SETTINGS_LIBS): Fix typo.
3116
4550efdf
KI
31172011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3118
3119 * coding.c (Fencode_coding_string): Record the last coding system
3120 used, as the function doc string says (bug#8738).
3121
0949d2b6
JD
31222011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3123
3124 * xsettings.c (store_monospaced_changed): Take new font as arg and
3125 check for change against current_mono_font.
3126 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3127 (emacs_settings_constructor, emacs_settings_get_property)
3128 (emacs_settings_set_property, emacs_settings_class_init)
3129 (emacs_settings_init, gsettings_obj): Remove.
3130 (something_changedCB): New function for HAVE_GSETTINGS.
3131 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3132 with value as argument.
3133 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3134 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3135 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3136 "changed".
3137
3138 * xgselect.c: Add defined (HAVE_GSETTINGS).
3139 (xgselect_initialize): Ditto.
3140
3141 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3142 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3143 xg_select.
3144
bbc6b304
PE
31452011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3146
3147 * eval.c (struct backtrace): Simplify and port the data structure.
3148 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3149 signed bit field, as this assumption is not portable and it makes
3150 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3151 "char debug_on_exit : 1" as this is not portable either; instead,
3152 use the portable "unsigned int debug_on_exit : 1". Remove unused
3153 member evalargs. Remove obsolete comments about cc bombing out.
3154
9851bfc5
JD
31552011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3156
51bb811f 3157 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3158 Let HAVE_GSETTINGS override HAVE_GCONF.
3159 (store_monospaced_changed): New function.
3160 (EMACS_SETTINGS): A new type derived from GObject to handle
3161 GSettings notifications.
3162 (emacs_settings_constructor, emacs_settings_get_property)
3163 (emacs_settings_set_property, emacs_settings_class_init):
3164 New functions.
3165 (gsettings_client, gsettings_obj): New variables.
3166 (GSETTINGS_SCHEMA): New define.
3167 (something_changedCB): Call store_monospaced_changed.
3168 (init_gsettings): New function.
3169 (xsettings_initialize): Call init_gsettings.
3170 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3171 to NULL.
3172
640c8776 3173 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3174 GCONF_CFLAGS/LIBS.
3175
5386012d
MR
31762011-06-29 Martin Rudalics <rudalics@gmx.at>
3177
3178 * window.c (resize_root_window, grow_mini_window)
3179 (shrink_mini_window): Rename Qresize_root_window to
3180 Qwindow_resize_root_window and Qresize_root_window_vertically to
3181 Qwindow_resize_root_window_vertically.
3182
f13e0b08
PE
31832011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3186
94515237
JB
31872011-06-27 Juanma Barranquero <lekktu@gmail.com>
3188
3189 * makefile.w32-in: Redesign dependencies so they reflect more
3190 clearly which files are directly included by each source file,
3191 and not through other includes.
3192
e43b6e43
MR
31932011-06-27 Martin Rudalics <rudalics@gmx.at>
3194
3195 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3196 (sort_overlays, overlay_strings): When an overlay's clone number
3197 matches the window's clone number process the overlay even if
3198 the overlay's window property doesn't match the current window.
3199
d68443dc
MR
3200 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3201 (Fwindow_hchild): Rename to Fwindow_left_child.
3202 (Fwindow_next): Rename to Fwindow_next_sibling.
3203 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3204 (resize_window_check): Rename to window_resize_check.
3205 (resize_window_apply): Rename to window_resize_apply.
3206 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3207 (Fdelete_other_windows_internal, resize_frame_windows)
3208 (Fsplit_window_internal, Fdelete_window_internal)
3209 (grow_mini_window, shrink_mini_window)
3210 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3211
c7e73be5
JD
32122011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3213
3214 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3215 (emacs_fixed_set_min_size): Remove.
3216 (emacs_fixed_new): Take frame as argument.
3217
3218 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3219 (_EmacsFixedPrivate): Remove minwidth/height.
3220 Add struct frame *f.
3221 (emacs_fixed_init): Initialize priv->f.
3222 (get_parent_class, emacs_fixed_set_min_size): Remove.
3223 (emacs_fixed_new): Set priv->f to argument.
3224 (emacs_fixed_get_preferred_width)
3225 (emacs_fixed_get_preferred_height): Use min_width/height from
3226 frames size_hint to set minimum and natural (Bug#8919).
3227 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3228 and use min_width/height from frames size_hint to set
3229 min_width/height (Bug#8919).
3230
3231 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3232 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3233 Fix indentation.
c7e73be5 3234
cf99dcf8
EZ
32352011-06-26 Eli Zaretskii <eliz@gnu.org>
3236
3237 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3238 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3239 called at ZV.
3240
029529ac
CY
32412011-06-26 Chong Yidong <cyd@stupidchicken.com>
3242
3243 * process.c (wait_reading_process_output): Bypass select if
3244 waiting for a cell while ignoring keyboard input, and input is
3245 pending. Suggested by Jan Djärv (Bug#8869).
3246
7a7ef429
PE
32472011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3248
3249 Use gnulib's dup2 module instead of rolling our own.
3250 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3251
11fdef7d 32522011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3253
3254 * dispnew.c (scrolling_window): Before scrolling, turn off a
3255 mouse-highlight in the window being scrolled.
3256
cd3520a4
JB
32572011-06-24 Juanma Barranquero <lekktu@gmail.com>
3258
3259 Move DEFSYM to lisp.h and use everywhere.
3260
3261 * character.h (DEFSYM): Move declaration...
3262 * lisp.h (DEFSYM): ...here.
3263
3264 * gnutls.c:
3265 * minibuf.c:
3266 * w32menu.c:
3267 * w32proc.c:
3268 * w32select.c: Don't include character.h.
3269
3270 * alloc.c (syms_of_alloc):
3271 * buffer.c (syms_of_buffer):
3272 * bytecode.c (syms_of_bytecode):
3273 * callint.c (syms_of_callint):
3274 * casefiddle.c (syms_of_casefiddle):
3275 * casetab.c (init_casetab_once):
3276 * category.c (init_category_once, syms_of_category):
3277 * ccl.c (syms_of_ccl):
3278 * cmds.c (syms_of_cmds):
3279 * composite.c (syms_of_composite):
3280 * dbusbind.c (syms_of_dbusbind):
3281 * dired.c (syms_of_dired):
3282 * dispnew.c (syms_of_display):
3283 * doc.c (syms_of_doc):
3284 * editfns.c (syms_of_editfns):
3285 * emacs.c (syms_of_emacs):
3286 * eval.c (syms_of_eval):
3287 * fileio.c (syms_of_fileio):
3288 * fns.c (syms_of_fns):
3289 * frame.c (syms_of_frame):
3290 * fringe.c (syms_of_fringe):
3291 * insdel.c (syms_of_insdel):
3292 * keymap.c (syms_of_keymap):
3293 * lread.c (init_obarray, syms_of_lread):
3294 * macros.c (syms_of_macros):
3295 * msdos.c (syms_of_msdos):
3296 * print.c (syms_of_print):
3297 * process.c (syms_of_process):
3298 * search.c (syms_of_search):
3299 * sound.c (syms_of_sound):
3300 * syntax.c (init_syntax_once, syms_of_syntax):
3301 * terminal.c (syms_of_terminal):
3302 * textprop.c (syms_of_textprop):
3303 * undo.c (syms_of_undo):
3304 * w32.c (globals_of_w32):
3305 * window.c (syms_of_window):
3306 * xdisp.c (syms_of_xdisp):
3307 * xfaces.c (syms_of_xfaces):
3308 * xfns.c (syms_of_xfns):
3309 * xmenu.c (syms_of_xmenu):
3310 * xsettings.c (syms_of_xsettings):
3311 * xterm.c (syms_of_xterm): Use DEFSYM.
3312
4228cf16
TZ
33132011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3314
cd3520a4 3315 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3316
7fcccf1e
PE
33172011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3318
7efb4e0e
PE
3319 Integer and buffer overflow fixes (Bug#8873).
3320
ff5844ad
PE
3321 * print.c (printchar, strout): Check for string overflow.
3322 (PRINTPREPARE, printchar, strout):
3323 Don't set size unless allocation succeeds.
3324
90532f02
PE
3325 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3326 for sizes. Check for string overflow more accurately.
3327 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3328
6d84508d
PE
3329 * macros.c: Integer and buffer overflow fixes.
3330 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3331 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3332 Use ptrdiff_t, not int, for sizes.
3333 Don't increment bufsize until after realloc succeeds.
3334 Check for size-calculation overflow.
3335 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3336
437b2cb4
PE
3337 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3338
8b9ac8b4
PE
3339 * lread.c: Integer overflow fixes.
3340 (read_integer): Radix is now EMACS_INT, not int,
3341 to improve quality of diagnostics for out-of-range radices.
3342 Calculate buffer size correctly for out-of-range radices.
3343 (read1): Check for integer overflow in radices, and in
3344 read-circle numbers.
82cb60d3
PE
3345 (read_escape): Avoid int overflow.
3346 (Fload, openp, read_buffer_size, read1)
3347 (substitute_object_recurse, read_vector, read_list, map_obarray):
3348 Use ptrdiff_t, not int, for sizes.
3349 (read1): Use EMACS_INT, not int, for sizes.
20270765 3350 Check for size overflow.
8b9ac8b4 3351
7fcccf1e
PE
3352 * image.c (cache_image): Check for size arithmetic overflow.
3353
bfbbd7e7
PE
3354 * lread.c: Integer overflow issues.
3355 (saved_doc_string_size, saved_doc_string_length)
3356 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3357 Now ptrdiff_t, not int.
3358 (read1): Don't assume doc string length fits in int. Check for
3359 out-of-range doc string lengths.
3360 (read_list): Don't assume file position fits in int.
39019e54 3361 (read_escape): Check for hex character overflow.
bfbbd7e7 3362
4e323265
LL
33632011-06-22 Leo Liu <sdl.web@gmail.com>
3364
3365 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3366 Move to minibuffer.el.
3367
85fece3e
PE
33682011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3369
20b84ce9 3370 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3371 The following patches are for when GLYPH_DEBUG && !XASSERT.
3372 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3373 * dispnew.c (flush_stdout):
3374 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3375 Mark as externally visible.
3376 * dispnew.c (check_window_matrix_pointers): Now static.
3377 * dispnew.c (window_to_frame_vpos):
3378 * xfns.c (unwind_create_frame):
3379 * xterm.c (x_check_font): Remove unused local.
3380 * scroll.c (CHECK_BOUNDS):
3381 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3382 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3383 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3384 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3385 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3386 Now static.
3387 (debug_method_add): Use va_list and vsprintf rather than relying
3388 on undefined behavior with wrong number of arguments.
3389 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3390 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3391 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3392 since we're not interested in debugging glyphs with old libraries.
3393 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3394 GCC 4.6.0's static checking.
3395
0766b489
PE
33962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3397
31fd4b32
PE
3398 Integer overflow and signedness fixes (Bug#8873).
3399 A few related buffer overrun fixes, too.
3400
b79e8648
PE
3401 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3402
0766b489
PE
3403 * dispextern.h (struct face.stipple):
3404 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3405 (x_bitmap_mask, x_allocate_bitmap_record)
3406 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3407 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3408 (x_create_bitmap_from_xpm_data):
3409 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3410 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3411 (.bitmaps_last):
3412 * xfaces.c (load_pixmap):
3413 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3414 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3415 (.bitmaps_last, struct x_output.icon_bitmap):
3416 Use ptrdiff_t, not int, for bitmap indexes.
3417 (x_allocate_bitmap_record): Check for size overflow.
3418 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3419
b081724f
PE
3420 Use ptrdiff_t, not int, for overlay counts.
3421 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3422 * editfns.c (overlays_around, get_pos_property):
3423 * textprop.c (get_char_property_and_overlay):
3424 * xdisp.c (next_overlay_change, note_mouse_highlight):
3425 * xfaces.c (face_at_buffer_position):
21514da7
PE
3426 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3427 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3428 (Fnext_overlay_change, Fprevious_overlay_change)
3429 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3430 Use ptrdiff_t, not int, for sizes.
21514da7 3431 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3432
3de73e5e
PE
3433 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3434
2606c57b
PE
3435 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3436 (x_session_initialize): Do not assume string length fits in int.
3437
aaafe47a
PE
3438 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3439 This is unlikely, but can occur if DPI is outlandish.
3440
2674ddc8 3441 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3442 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3443
28154962
PE
3444 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3445 * xrdb.c (magic_file_p, search_magic_path):
3446 Omit last arg SUFFIX; it was always 0. All callers changed.
3447 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3448
7de51af5
PE
3449 * xfont.c (xfont_match): Avoid need for strlen.
3450
25ed6cc3
PE
3451 * xfns.c: Don't assume strlen fits in int.
3452 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3453
4eab31dd
PE
3454 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3455 not unsigned long, as we prefer signed integers. All callers changed.
3456 Detect integer overflow in repeat count.
3457 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3458 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3459
171e2a58
PE
3460 * termcap.c: Don't assume sizes fit in int and never overflow.
3461 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3462 (gobble_line): Check for size-calculation overflow.
3463
ad39faca 3464 * minibuf.c (Fread_buffer):
6e5bb2dc 3465 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3466 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3467 Don't assume string length fits in int.
3468
52c61c22 3469 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3470 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3471
b5b8c9e5
PE
3472 * font.c: Don't assume string length fits in int.
3473 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3474 Use ptrdiff_t, not int.
ccd6111c
PE
3475 (font_intern_prop): Don't assume string length fits in int.
3476 Don't assume integer property fits in fixnum.
3477 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3478
882f0d81 3479 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3480 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3481 Reformulate so as not to need the command string.
3482 Invoke gzip -cd rather than gunzip, as it's more portable.
3483 (lock_info_type, lock_file_1, lock_file):
3484 Don't assume pid_t and time_t fit in unsigned long.
3485 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3486 (current_lock_owner): Prefer signed type for sizes.
3487 Use memcpy, not strncpy, where memcpy is what is really wanted.
3488 Don't assume (via atoi) that time_t and pid_t fit in int.
3489 Check for time_t and/or pid_t out of range, e.g., via a network share.
3490 Don't alloca where an auto var works fine.
3491
93f4cf88
PE
3492 * fileio.c: Fix some integer overflow issues.
3493 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3494 Don't assume string length fits in int.
3495 (directory_file_name): Don't assume string length fits in long.
3496 (make_temp_name): Don't assume pid fits in int, or that its print
3497 length is less than 20.
3498
f3e92b69
PE
3499 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3500
1bfdaf10
PE
3501 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3502
35016e9a
PE
3503 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3504
3d1e65a1
PE
3505 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3506 We prefer signed integers, even for size calculations.
3507
0b963a93
PE
3508 * emacs.c: Don't assume string length fits in 'int'.
3509 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3510 (main): Don't invoke strlen when not needed.
3511
573f4b54
PE
3512 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3513 (XD_DEBUG_MESSAGE): Don't waste a byte.
3514
989f33ba
PE
3515 * callproc.c (getenv_internal_1, getenv_internal)
3516 (Fgetenv_internal):
965d34eb
PE
3517 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3518
e4d29b33
PE
3519 * lread.c (invalid_syntax): Omit length argument.
3520 All uses changed. This doesn't fix a bug, but it simplifies the
3521 code away from its former Hollerith-constant appearance, and it's
3522 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3523 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3524
eb49b136
PE
3525 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3526 This didn't break anything, but it didn't help either.
3527 It's confusing to put a bogus integer in a place where the actual
3528 value does not matter.
9f62aeb1 3529 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3530 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3531
15375a22
PE
3532 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3533 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3534 implementation.
b61cc01c
PE
3535 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3536 We prefer signed types, and the value cannot exceed the EMACS_INT
3537 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3538 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3539 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3540 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3541
53b2623d
PE
3542 * indent.c (sane_tab_width): New function.
3543 (current_column, scan_for_column, Findent_to, position_indentation)
3544 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3545 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3546
51cab52b 3547 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3548
f2ed8a70
PE
3549 * lisp.h (lint_assume): New macro.
3550 * composite.c (composition_gstring_put_cache):
3551 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3552
abe80cc6
PE
3553 * editfns.c, insdel.c:
3554 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3555
b02c740e
PE
3556 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3557
ebc96716
PE
3558 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3559
b4e50fa0 3560 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3561 Use much-faster test for byte-length change.
311d5d7c 3562 Don't assume string byte-length fits in 'int'.
a4cf38e4 3563 Check that character arg fits in 'int'.
85461888 3564 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3565
c0c1ee9f
PE
3566 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3567
a498d7f4
PE
3568 * fns.c (concat): Catch string overflow earlier.
3569 Do not rely on integer wraparound.
3570
51cab52b
PE
3571 * dispextern.h (struct it.overlay_strings_charpos)
3572 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3573 * xdisp.c (forward_to_next_line_start)
3574 (back_to_previous_visible_line_start)
3575 (reseat_at_next_visible_line_start, next_element_from_buffer):
3576 Don't arbitrarily truncate the value of 'selective' to int.
3577
76031fad
PE
3578 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3579
5eb55db9
PE
3580 * composite.c: Don't truncate sizes to 'int'.
3581 (composition_gstring_p, composition_reseat_it)
3582 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3583 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3584 not EMACS_UINT, for indexes.
5eb55db9 3585
0703a717
PE
3586 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3587
d6202519
PE
3588 * buffer.c: Include <verify.h>.
3589 (struct sortvec.priority, struct sortstr.priority):
8961a454 3590 Now EMACS_INT, not int.
c20998a7 3591 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3592 (struct sortstr.size, record_overlay_string)
3593 (struct sortstrlist.size, struct sortlist.used):
3594 Don't truncate size to int.
3595 (record_overlay_string): Check for size-calculation overflow.
d6202519 3596 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3597
d5a19415
JM
35982011-06-22 Jim Meyering <meyering@redhat.com>
3599
029529ac 3600 Don't leak an XBM-image-sized buffer
d5a19415
JM
3601 * image.c (xbm_load): Free the image buffer after using it.
3602
a9041e6c
PE
36032011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 Port to Sun C.
3606 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3607 that Sun C diagnosed.
3608 * fns.c (secure_hash): Fix pointer signedness issue.
3609 * intervals.c (static_offset_intervals): New function.
3610 (offset_intervals): Use it.
3611
7f3f739f
LL
36122011-06-21 Leo Liu <sdl.web@gmail.com>
3613
3614 * deps.mk (fns.o):
3615 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3616 sha512.h.
3617
3618 * fns.c (secure_hash): Rename from crypto_hash_function and change
3619 the first arg to accept symbols.
5b66d427 3620 (Fsecure_hash): New primitive.
7f3f739f
LL
3621 (syms_of_fns): New symbols.
3622
76147d94
DD
36232011-06-20 Deniz Dogan <deniz@dogan.se>
3624
3625 * process.c (Fset_process_buffer): Clarify return value in
3626 docstring.
3627
7d7d0045
CY
36282011-06-18 Chong Yidong <cyd@stupidchicken.com>
3629
3630 * dispnew.c (add_window_display_history): Use BVAR.
3631
3632 * xdisp.c (debug_method_add): Use BVAR.
3633 (check_window_end, dump_glyph_matrix, dump_glyph)
3634 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3635
3636 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3637 Likewise.
3638
3639 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3640 check till after the cache is created in init_frame_faces.
3641
ff2bc410
SM
36422011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3643
3644 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3645
28177add
PE
36462011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3647
dd3482fe
PE
3648 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3649 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3650 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3651
393d71f3 3652 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3653 * fileio.c (Finsert_file_contents):
3654 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3655 Remove the old (too-loose) buffer overflow checks.
3656 They weren't needed, since make_gap checks for buffer overflow.
3657 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3658 The old code merely checked for Emacs fixnum overflow, and relied
3659 on undefined (wraparound) behavior. The new code avoids undefined
3660 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3661
2e6813b0 3662 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3663 Tune. Don't use wider integers than needed. Don't use alloca.
3664 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3665
599a9e4f
PE
3666 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3667
99561444
PE
3668 * insdel.c, lisp.h (buffer_overflow): New function.
3669 (insert_from_buffer_1, replace_range, replace_range_2):
3670 * insdel.c (make_gap_larger):
3671 * editfns.c (Finsert_char):
3672 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3673
28177add
PE
3674 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3675
e69dafad
PE
36762011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3677
a7af7fde 3678 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3679
b1c46f02
PE
3680 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3681 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3682
e69dafad
PE
3683 * fileio.c: Don't assume EMACS_INT fits in off_t.
3684 (emacs_lseek): New static function.
3685 (Finsert_file_contents, Fwrite_region): Use it.
3686 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3687
566684ea
PE
3688 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3689
e6966cd6
PE
3690 * fns.c: Don't overflow int when computing a list length.
3691 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3692 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3693 truncation on 64-bit hosts. Check for QUIT every
3694 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3695 faster and is responsive enough.
3696 (Flength): Report an error instead of overflowing an integer.
3697 (Fsafe_length): Return a float if the value is not representable
3698 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3699 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3700 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3701
dd0b0efb
PE
3702 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3703 (header_size, word_size): New constants.
3704 (allocate_vectorlike): Don't check size overflow here.
3705 (allocate_vector): Check it here instead, since this is the only
3706 caller of allocate_vectorlike that could cause overflow.
3707 Check that the new vector's length is representable as a fixnum.
3708
86fe5cfe
PE
3709 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3710 The previous code was bogus. For example, next_almost_prime (32)
3711 returned 39, which is undesirable as it is a multiple of 3; and
3712 next_almost_prime (24) returned 25, which is a multiple of 5 so
3713 why was the code bothering to check for multiples of 7?
3714
80e88859
PE
3715 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3716
4a2f0ad6
PE
3717 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3718
f66c7cf8
PE
3719 Variadic C functions now count arguments with ptrdiff_t.
3720 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3721 Back then I didn't know that the Emacs coding style prefers signed int.
3722 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3723 were being counted with int, which may truncate counts on 64-bit
3724 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3725 * lisp.h (struct Lisp_Subr.function.aMANY)
3726 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3727 Arg counts are now ptrdiff_t, not size_t.
3728 All variadic functions and their callers changed accordingly.
3729 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3730 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3731 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3732 * callint.c (Fcall_interactively): Check arg count for overflow,
3733 to avoid potential buffer overrun. Use signed char, not 'int',
3734 for 'varies' array, so that we needn't bother to check its size
3735 calculation for overflow.
3736 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3737 * eval.c (apply_lambda):
3738 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3739 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3740 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3741
a1759b76
PE
3742 * callint.c (Fcall_interactively): Don't use index var as event count.
3743
d96be9fc
PE
3744 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3745 * mem-limits.h (SIZE): Remove; no longer used.
3746
a690a978 3747 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3748
578c21e6
PE
3749 Remove unnecessary casts.
3750 * xterm.c (x_term_init):
3751 * xfns.c (x_set_border_pixel):
3752 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3753 These aren't needed now that we assume ANSI C.
3754
96f53c6c
PE
3755 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3756 It's more likely to cause problems (due to unsigned overflow)
3757 than to cure them.
3758
83c77d31
PE
3759 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3760
ee2079f1
PE
3761 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3762
6da65536
PE
3763 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3764
7147c4a4
PE
3765 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3766
193e32d9
PE
3767 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3768
e5533da6
PE
3769 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3770
9910e595
PE
3771 GLYPH_CODE_FACE returns EMACS_INT, not int.
3772 * dispextern.h (merge_faces):
3773 * xfaces.c (merge_faces):
01103c44
PE
3774 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3775 Don't assume EMACS_INT fits in int.
9910e595 3776
2638320e
PE
3777 * character.h (CHAR_VALID_P): Remove unused parameter.
3778 * fontset.c, lisp.h, xdisp.c: All uses changed.
3779
045eb8d9
PE
3780 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3781
c1f134b5
PE
3782 * fns.c (concat): Minor tuning based on overflow analysis.
3783 This doesn't fix any bugs. Use int to hold character, instead
3784 of constantly refetching from Emacs object. Use XFASTINT, not
3785 XINT, for value known to be a character. Don't bother comparing
3786 a single byte to 0400, as it's always less.
3787
395fcb93 3788 * floatfns.c (Fexpt):
327eeec8
PE
3789 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3790
abbd3d23
PE
3791 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3792 for characters.
3793
684a03ef
PE
3794 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3795
0fed43f3
PE
3796 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3797 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3798 incorrectly succeed when S was a string, because 4294967386 was
3799 truncated before it was used.
3800
8fd02eb7
PE
3801 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3802 Otherwise, an out-of-range integer could cause undefined behavior
3803 on a 64-bit host.
3804
f8c86b69
PE
3805 * composite.c: Use int, not EMACS_INT, for characters.
3806 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3807 EMACS_INT, for values that are known to be in character range.
3808 This doesn't fix any bugs but is the usual style inside Emacs and
3809 may generate better code on 32-bit machines.
3810
34206dd2
PE
3811 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3812 This is for reasons similar to the recent CHAR_STRING fix.
3813 * charset.c (Fencode_char): Check that character arg is actually
3814 a character. Pass an int to ENCODE_CHAR.
3815 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3816 wider than 'int', as a compile-time check to prevent future regressions
3817 in this area.
3818
c5958d4c 3819 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3820
3821 Make sure a 64-bit char is never passed to CHAR_STRING.
3822 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3823 by silently ignoring the top 32 bits, allowing some values
3824 that were far too large to be valid characters.
3825 * character.h: Include <verify.h>.
3826 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3827 arguments are no wider than unsigned, as a compile-time check
3828 to prevent future regressions in this area.
3829 * data.c (Faset):
01103c44 3830 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3831 (Fsubst_char_in_region):
3832 * fns.c (concat):
3833 * xdisp.c (decode_mode_spec_coding):
3834 Adjust to CHAR_STRING's new requirement.
3835 * editfns.c (Finsert_char, Fsubst_char_in_region):
3836 * fns.c (concat): Check that character args are actually
3837 characters. Without this test, these functions did the wrong
3838 thing with wildly out-of-range values on 64-bit hosts.
3839
d37ca623
PE
3840 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3841 These casts should not be needed on 32-bit hosts, either.
3842 * keyboard.c (read_char):
3843 * lread.c (Fload): Remove casts to unsigned.
3844
ea204efb
PE
3845 * lisp.h (UNSIGNED_CMP): New macro.
3846 This fixes comparison bugs on 64-bit hosts.
3847 (ASCII_CHAR_P): Use it.
3848 * casefiddle.c (casify_object):
01103c44 3849 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3850 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3851 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3852 * dispextern.h (FACE_FROM_ID):
3853 * keyboard.c (read_char): Use UNSIGNED_CMP.
3854
41cb286c
PE
3855 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3856 not to EMACS_INT, to avoid GCC warning.
3857
4a1b9832
PE
3858 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3859
55daad71
PE
3860 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3861 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3862 isn't needed on 32-bit machines.
8f95c75c 3863
01103c44
PE
3864 * buffer.c (Fgenerate_new_buffer_name):
3865 Use EMACS_INT for count, not int.
0ceccced 3866 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3867
3868 * data.c (Qcompiled_function): Now static.
3869
c6f072e7
PE
3870 * window.c (window_body_lines): Now static.
3871
20ce5912
PE
3872 * image.c (gif_load): Rename local to avoid shadowing.
3873
9c4c5f81
PE
3874 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3875 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3876 * alloc.c (make_save_value): Integer argument is now of type
3877 ptrdiff_t, not int.
3878 (mark_object): Use ptrdiff_t, not int.
3879 * lisp.h (pD): New macro.
3880 * print.c (print_object): Use it.
3881
c0c5c8ae
PE
3882 * alloc.c: Use EMACS_INT, not int, to count objects.
3883 (total_conses, total_markers, total_symbols, total_vector_size)
3884 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3885 (total_free_floats, total_floats, total_free_intervals)
3886 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3887 Now EMACS_INT, not int. All uses changed.
3888 (Fgarbage_collect): Compute overall total using a double, so that
3889 integer overflow is less likely to be a problem. Check for overflow
3890 when converting back to an integer.
5a25e253
PE
3891 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3892 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3893 These were 'int' variables that could overflow on 64-bit hosts;
3894 they were never used, so remove them instead of repairing them.
211a0b2a 3895 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3896 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3897 Previously, this ceilinged at INT_MAX, but that doesn't work on
3898 64-bit machines.
e46bb31a 3899 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3900
c78baabf 3901 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3902 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3903 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3904 when a (possibly-narrower) signed value would do just as well.
3905 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3906
c9d624c6
PE
3907 * alloc.c: Catch some string size overflows that we were missing.
3908 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3909 for convenience in STRING_BYTES_MAX.
3910 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3911 The definition here is exact; the one in lisp.h was approximate.
3912 (allocate_string_data): Check for string overflow. This catches
3913 some instances we weren't catching before. Also, it catches
3914 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3915 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3916 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3917
c9d624c6
PE
3918 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3919 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3920 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3921
353032ce
PE
3922 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3923
2bccce07
PE
3924 * alloc.c (Fmake_string): Check for out-of-range init.
3925
0ac30604
SM
39262011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3927
3928 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3929
c195f2de
JD
39302011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3931
3932 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3933 xg_get_default_scrollbar_width.
3934
3935 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3936 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3937 (style_changed_cb): Call update_theme_scrollbar_width and call
3938 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3939 all frames (Bug#8505).
3940 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3941 Call gtk_window_set_resizable if HAVE_GTK3.
3942 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3943 and height if HAVE_GTK3 (Bug#8505).
3944 (scroll_bar_width_for_theme): New variable.
3945 (update_theme_scrollbar_width): New function.
3946 (xg_get_default_scrollbar_width): Move code to
3947 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3948 (xg_initialize): Call update_theme_scrollbar_width.
3949
3950 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3951
3952 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3953
e10ac9f1
MR
39542011-06-12 Martin Rudalics <rudalics@gmx.at>
3955
3956 * frame.c (make_frame): Call other_buffer_safely instead of
3957 other_buffer.
3958
3959 * window.c (temp_output_buffer_show): Call display_buffer with
3960 second argument Vtemp_buffer_show_specifiers and reset latter
3961 immediately after the call.
3962 (Vtemp_buffer_show_specifiers): New variable.
3963 (auto_window_vscroll_p, next_screen_context_lines)
3964 (Vscroll_preserve_screen_position): Remove leading asterisks from
3965 doc-strings.
3966
2d3c217e 39672011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3968
7b7f97e8 3969 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3970 * buffer.c (Qclone_number): Remove for now, as it's unused.
3971 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3972 (record_buffer): Remove unused local.
3973 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3974 (set_frame_buffer_list): Remove; unused.
3975 * frame.h (other_visible_frames): Remove decl.
3976 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3977 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3978 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3979 if HAVE_GPM.
3980 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3981 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3982 Define only if HAVE_GPM.
3983 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3984 (update_hints_inhibit): Remove; never set. All uses removed.
3985 * widgetprv.h (emacsFrameClassRec): Remove decl.
3986 * window.c (delete_deletable_window): Now returns void, since it
3987 wasn't returning anything.
3988 (compare_window_configurations): Remove unused locals.
3989 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3990 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3991 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3992 the same widths as pointers. This follows up on the 2011-05-06 patch.
3993 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3994 * xterm.h: Likewise.
3995 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3996
1384b89e
JB
39972011-06-12 Juanma Barranquero <lekktu@gmail.com>
3998
3999 * makefile.w32-in: Update dependencies.
4000 (LISP_H): Add lib/intprops.h.
4001
1100a63c
CY
40022011-06-11 Chong Yidong <cyd@stupidchicken.com>
4003
4004 * image.c (gif_load): Add animation frame delay to the metadata.
4005 (syms_of_image): Use DEFSYM. New symbol `delay'.
4006
6198ccd0
MR
40072011-06-11 Martin Rudalics <rudalics@gmx.at>
4008
4009 * window.c (delete_deletable_window): Re-add.
4010 (Fset_window_configuration): Rewrite to handle dead buffers and
4011 consequently deletable windows.
4012 (window_tree, Fwindow_tree): Remove. Supply functionality in
4013 window.el.
4014 (compare_window_configurations): Simplify code.
4015
b6e3633c
AS
40162011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4017
1ab0dee5
AS
4018 * image.c (imagemagick_load_image): Fix type mismatch.
4019 (Fimagemagick_types): Likewise.
4020
b6e3633c
AS
4021 * window.h (replace_buffer_in_windows): Declare.
4022
9397e56f
MR
40232011-06-11 Martin Rudalics <rudalics@gmx.at>
4024
4025 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4026 Qclone_number. Remove external declaration of Qdelete_window.
4027 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4028 code.
640c8776
SM
4029 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4030 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4031 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4032 buffer list implementation.
4033 (other_buffer_safely): New function.
4034 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4035 calls to replace_buffer_in_windows and
4036 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4037 if allowed.
4038 (record_buffer): Inhibit quitting and rewrite using quittable
4039 functions. Run Qbuffer_list_update_hook if allowed.
4040 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4041 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4042 Move switch-to-buffer to window.el.
9397e56f
MR
4043 (bury-buffer): Move to window.el.
4044 (Vbuffer_list_update_hook): New variable.
4045
4046 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4047 section.
4048
4049 * window.h (resize_frame_windows): Move up in code.
4050 (Fwindow_frame): Remove EXFUN.
4051 (replace_buffer_in_all_windows): Remove prototype.
4052 (replace_buffer_in_windows_safely): Add prototype.
4053
4054 * window.c: Declare Qdelete_window static again. Move down
4055 declaration of select_count.
4056 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4057 (Fother_window): Move to window.el.
4058 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4059 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4060 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4061 window.el.
4062 (replace_buffer_in_windows): Implement by calling
4063 Qreplace_buffer_in_windows.
4064 (replace_buffer_in_all_windows): Remove with some functionality
4065 moved into replace_buffer_in_windows_safely.
4066 (replace_buffer_in_windows_safely): New function.
4067 (select_window_norecord, select_frame_norecord): Move in front
4068 of run_window_configuration_change_hook. Remove now obsolete
4069 declarations.
640c8776
SM
4070 (Fset_window_buffer): Rewrite doc-string.
4071 Call Qrecord_window_buffer.
9397e56f
MR
4072 (keys_of_window): Move binding for other-window to window.el.
4073
b50691aa
CY
40742011-06-11 Chong Yidong <cyd@stupidchicken.com>
4075
4076 * dispextern.h (struct image): Replace data member, whose int_val
4077 and ptr_val fields were not used by anything, with a single
4078 lisp_val object.
4079
4080 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4081 (gif_clear_image, gif_load, imagemagick_load_image)
4082 (gs_clear_image, gs_load): Callers changed.
4083
3f754b86
PE
40842011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4085
cca69397
PE
4086 * buffer.h: Include <time.h>, for time_t.
4087 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4088
109e28d0
PE
4089 Fix minor problems found by static checking.
4090
60737f02
PE
4091 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4092
4b66faf3
PE
4093 Make identifiers static if they are not used in other modules.
4094 * data.c (Qcompiled_function, Qframe, Qvector):
4095 * image.c (QimageMagick, Qsvg):
4096 * minibuf.c (Qmetadata):
4097 * window.c (resize_window_check, resize_root_window): Now static.
4098 * window.h (resize_window_check, resize_root_window): Remove decls.
4099
109e28d0
PE
4100 * window.c (window_deletion_count, delete_deletable_window):
4101 Remove; unused.
46a4ce9e
PE
4102 (window_body_lines): Now static.
4103 (Fdelete_other_windows_internal): Mark vars as initialized.
4104 Make sure 'resize_failed' is initialized.
4105 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4106 (resize_window_apply): Remove unused local.
4107 * window.h (delete_deletable_window): Remove decl.
4108
109e28d0 4109 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4110 (imagemagick_load_image): Fix pointer signedness problem by changing
4111 last arg from unsigned char * to char *. All uses changed.
4112 Also, fix a local for similar reasons.
4113 Remove unused locals. Remove locals to avoid shadowing.
4114 (fn_rsvg_handle_free): Remove; unused.
4115 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4116 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4117
3f754b86
PE
4118 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4119
2547adb1
CY
41202011-06-10 Chong Yidong <cyd@stupidchicken.com>
4121
4122 * image.c (gif_load): Fix omitted cast error introduced by
4123 2011-06-06 change.
4124
2c8e37d4
MR
41252011-06-10 Martin Rudalics <rudalics@gmx.at>
4126
4127 * window.h (resize_proportionally, orig_total_lines)
4128 (orig_top_line): Remove from window structure.
4129 (set_window_height, set_window_width, change_window_heights)
4130 (Fdelete_window): Remove prototypes.
4131 (resize_frame_windows): Remove duplicate declaration.
4132
440a42e3
EZ
41332011-06-10 Eli Zaretskii <eliz@gnu.org>
4134
4135 * window.h (resize_frame_windows, resize_window_check)
4136 (delete_deletable_window, resize_root_window)
4137 (resize_frame_windows): Declare prototypes.
4138
4139 * window.c (resize_window_apply): Make definition be "static" to
4140 match the prototype.
4141
562dd5e9
MR
41422011-06-10 Martin Rudalics <rudalics@gmx.at>
4143
4144 * window.c: Remove declarations of Qwindow_size_fixed,
4145 window_min_size_1, window_min_size_2, window_min_size,
4146 size_window, window_fixed_size_p, enlarge_window, delete_window.
4147 Remove static from declaration of Qdelete_window, it's
4148 temporarily needed by Fbury_buffer.
4149 (replace_window): Don't assign orig_top_line and
4150 orig_total_lines.
4151 (Fdelete_window, delete_window): Remove. Window deletion is
4152 handled by window.el.
640c8776
SM
4153 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4154 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4155 (Fdelete_other_windows): Remove. Deleting other windows is
4156 handled by window.el.
4157 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4158 handled in window.el.
4159 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4160 Window minimum sizes are handled in window.el.
4161 (shrink_windows, size_window, set_window_height)
4162 (set_window_width, change_window_heights, window_height)
4163 (window_width, CURBEG, CURSIZE, enlarge_window)
4164 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4165 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4166 handled in window.el.
4167 (make_dummy_parent): Rename to make_parent_window and give it a
4168 second argument horflag.
4169 (make_window): Don't set resize_proportionally any more.
4170 (Fsplit_window): Remove. Windows are split in window.el.
4171 (save_restore_action, save_restore_orig_size)
4172 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4173 Resize mini windows in window.el.
4174 (grow_mini_window, shrink_mini_window): Implement by calling
4175 Qresize_root_window_vertically, resize_window_check and
4176 resize_window_apply.
640c8776
SM
4177 (saved_window, Fset_window_configuration, save_window_save):
4178 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4179 resize_proportionally.
4180 (window_min_height, window_min_width): Move to window.el.
4181 (keys_of_window): Move bindings for delete-other-windows,
4182 split-window, delete-window and enlarge-window to window.el.
4183
4184 * buffer.c: Temporarily extern Qdelete_window.
4185 (Fbury_buffer): Temporarily call Qdelete_window instead of
4186 Fdelete_window (Fbury_buffer will move to window.el soon).
4187
4188 * frame.c (set_menu_bar_lines_1): Remove code handling
4189 orig_top_line and orig_total_lines.
4190
4191 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4192 set_window_height but set heights directly.
4193 (change_frame_size_1): Use resize_frame_windows.
4194
4195 * xdisp.c (init_xdisp): Don't use set_window_height but set
4196 heights directly.
4197
640c8776
SM
4198 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4199 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4200 run_window_configuration_change_hook.
4201
4202 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4203 instead of change_window_heights and run
4204 run_window_configuration_change_hook.
4205
1a13852e
MR
42062011-06-09 Martin Rudalics <rudalics@gmx.at>
4207
4208 * window.c (replace_window): Rename second argument REPLACEMENT to
4209 NEW. New third argument SETFLAG. Rewrite.
4210 (delete_window, make_dummy_parent): Call replace_window with
4211 third argument 1.
4212 (window_list_1): Move down in code.
4213 (run_window_configuration_change_hook): Move set_buffer part
4214 before select_frame_norecord part in order to unwind correctly.
4215 Rename count1 to count.
4216 (recombine_windows, delete_deletable_window, resize_root_window)
4217 (Fdelete_other_windows_internal)
4218 (Frun_window_configuration_change_hook, make_parent_window)
4219 (resize_window_check, resize_window_apply, Fresize_window_apply)
4220 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4221 (Fdelete_window_internal, Fresize_mini_window_internal):
4222 New functions.
1a13852e
MR
4223 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4224
f3d1777e
MR
42252011-06-08 Martin Rudalics <rudalics@gmx.at>
4226
496e208e
MR
4227 * window.h (window): Add some new members to window structure -
4228 normal_lines, normal_cols, new_total, new_normal, clone_number,
4229 splits, nest, prev_buffers, next_buffers.
4230 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4231 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4232
f3d1777e
MR
4233 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4234 Remove.
496e208e
MR
4235 (make_dummy_parent): Set new members of windows structure.
4236 (make_window): Move down in code. Handle new members of window
4237 structure.
4238 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4239 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4240 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4241 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4242 (Fset_window_next_buffers, Fset_window_clone_number):
4243 New functions.
496e208e
MR
4244 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4245 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4246 Doc-string fixes.
4247 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4248 Argument WINDOW can be now internal window too.
4249 (Fwindow_use_time): Move up in code.
4250 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4251 Rewrite doc-string.
4252 (Fset_window_configuration, saved_window)
4253 (Fcurrent_window_configuration, save_window_save): Handle new
4254 members of window structure.
b9e809c2
MR
4255 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4256 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4257 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4258 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4259 Qget_mru_window, Qresize_root_window,
4260 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4261 Qauto_buffer_name; staticpro them.
f3d1777e 4262
abde8f8c
MR
42632011-06-07 Martin Rudalics <rudalics@gmx.at>
4264
4265 * window.c (Fwindow_total_size, Fwindow_left_column)
4266 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4267 (Fwindow_list_1): New functions.
4268 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4269 (Fwindow_width, Fscroll_left, Fscroll_right):
4270 Use window_body_cols instead of window_box_text_cols.
4271 (delete_window, Fset_window_configuration):
4272 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4273 (delete_all_subwindows): Take a window as argument and not a
4274 structure. Rewrite.
190b47e6
MR
4275 (window_loop): Remove handling of GET_LRU_WINDOW and
4276 GET_LARGEST_WINDOW.
4277 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4278
4279 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4280 window_box_text_cols. delete_all_subwindows now takes a
4281 Lisp_Object as argument.
abde8f8c 4282
640c8776
SM
4283 * indent.c (compute_motion, Fcompute_motion):
4284 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4285
fa8a67e6
MR
4286 * frame.c (delete_frame): Call delete_all_subwindows with root
4287 window as argument.
4288
a54e3482
DC
42892011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4290
4291 * fns.c (Fputhash): Document return value.
4292
60002bf5
CY
42932011-06-06 Chong Yidong <cyd@stupidchicken.com>
4294
4295 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4296
0c671da6 42972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4298
b862a52a 4299 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4300
be44ca6c
PE
4301 Check for overflow when converting integer to cons and back.
4302 * charset.c (Fdefine_charset_internal, Fdecode_char):
4303 Use cons_to_unsigned to catch overflow.
4304 (Fencode_char): Use INTEGER_TO_CONS.
4305 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4306 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4307 * data.c (long_to_cons, cons_to_long): Remove.
4308 (cons_to_unsigned, cons_to_signed): New functions.
4309 These signal an error for invalid or out-of-range values.
4310 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4311 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4312 * font.c (Ffont_variation_glyphs):
4313 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4314 * lisp.h: Include <intprops.h>.
4315 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4316 (cons_to_signed, cons_to_unsigned): New decls.
4317 (long_to_cons, cons_to_long): Remove decls.
4318 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4319 (Fprimitive_undo): Use CONS_TO_INTEGER.
4320 * xfns.c (Fx_window_property): Likewise.
4321 * xselect.c: Include <limits.h>.
4322 (x_own_selection, selection_data_to_lisp_data):
4323 Use INTEGER_TO_CONS.
4324 (x_handle_selection_request, x_handle_selection_clear)
4325 (x_get_foreign_selection, Fx_disown_selection_internal)
4326 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4327 (lisp_data_to_selection_data): Use cons_to_unsigned.
4328 (x_fill_property_data): Use cons_to_signed.
4329 Report values out of range.
4330
d1f3d2af
PE
4331 Check for buffer and string overflow more precisely.
4332 * buffer.h (BUF_BYTES_MAX): New macro.
4333 * lisp.h (STRING_BYTES_MAX): New macro.
4334 * alloc.c (Fmake_string):
4335 * character.c (string_escape_byte8):
4336 * coding.c (coding_alloc_by_realloc):
4337 * doprnt.c (doprnt):
4338 * editfns.c (Fformat):
4339 * eval.c (verror):
4340 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4341 since they may not be the same number.
4342 * editfns.c (Finsert_char):
4343 * fileio.c (Finsert_file_contents):
4344 Likewise for BUF_BYTES_MAX.
4345
dd52fcea
PE
4346 * image.c: Use ptrdiff_t, not int, for sizes.
4347 (slurp_file): Switch from int to ptrdiff_t.
4348 All uses changed.
4349 (slurp_file): Check that file size fits in both size_t (for
4350 malloc) and ptrdiff_t (for sanity and safety).
4351
7f9bbdbb
PE
4352 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4353 if b->modtime has its maximal value.
4354
dfe18f82
PE
4355 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4356
84acfcf0
PE
4357 Don't assume time_t can fit into int.
4358 * buffer.h (struct buffer.modtime): Now time_t, not int.
4359 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4360 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4361
ccd9a01a
PE
4362 Minor fixes for signed vs unsigned integers.
4363 * character.h (MAYBE_UNIFY_CHAR):
4364 * charset.c (maybe_unify_char):
4365 * keyboard.c (read_char, reorder_modifiers):
4366 XINT -> XFASTINT, since the integer must be nonnegative.
4367 * ftfont.c (ftfont_spec_pattern):
4368 * keymap.c (access_keymap, silly_event_symbol_error):
4369 XUINT -> XFASTINT, since the integer must be nonnegative.
4370 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4371 since it makes no difference and we prefer signed.
4372 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4373 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4374 nonnegative.
4375
d6d100dd
SM
43762011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4377
4378 * window.h (Fwindow_frame): Declare.
4379
2b6148e4
PE
43802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4381
4382 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4383 (SPARE_MEMORY): Always define.
4384 (LARGE_REQUEST): Remove.
4385 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4386
f230ecc9
MR
43872011-06-06 Martin Rudalics <rudalics@gmx.at>
4388
727e958e
MR
4389 * lisp.h: Move EXFUNS for Fframe_root_window,
4390 Fframe_first_window and Fset_frame_selected_window to window.h.
4391
4392 * window.h: Move EXFUNS for Fframe_root_window,
4393 Fframe_first_window and Fset_frame_selected_window here from
4394 lisp.h.
4395
4396 * frame.c (Fwindow_frame, Fframe_first_window)
4397 (Fframe_root_window, Fframe_selected_window)
4398 (Fset_frame_selected_window): Move to window.c.
4399 (Factive_minibuffer_window): Move to minibuf.c.
4400 (Fother_visible_frames_p): New function.
4401
4402 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4403
f230ecc9
MR
4404 * window.c (decode_window, decode_any_window): Move up in code.
4405 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4406 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4407 (Fwindow_buffer): Move up and rewrite doc-string.
4408 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4409 (Fwindow_prev): New functions.
727e958e
MR
4410 (Fwindow_frame): Move here from frame.c. Accept any window as
4411 argument.
4412 (Fframe_root_window, Fframe_first_window)
4413 (Fframe_selected_window): Move here from frame.c. Accept frame
4414 or arbitrary window as argument. Update doc-strings.
4415 (Fminibuffer_window): Move up in code.
4416 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4417 (Fset_frame_selected_window): Move here from frame.c.
4418 Marginal rewrite.
727e958e
MR
4419 (Fselected_window, select_window, Fselect_window): Move up in
4420 code. Minor doc-string fixes.
f230ecc9 4421
4d09bcf6
PE
44222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4425 Do not assume that spare memory exists; that assumption is valid
4426 only if SYSTEM_MALLOC.
4427 (LARGE_REQUEST): New macro, so that the issue of large requests
4428 is separated from the issue of spare memory.
4429
810928a2
AS
44302011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4431
172418ad
AS
4432 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4433 format. (Bug#8806)
4434
43f862f7
AS
4435 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4436
810928a2
AS
4437 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4438 before statements.
4439
a059fe24
JD
44402011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4441
4442 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4443
4444 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4445
4446 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4447 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4448
989bf368
JB
44492011-06-05 Juanma Barranquero <lekktu@gmail.com>
4450
4451 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4452
4b80f674
CY
44532011-06-04 Chong Yidong <cyd@stupidchicken.com>
4454
4455 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4456 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4457 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4458 New error handlers.
4b80f674
CY
4459 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4460 Obey Vx_select_enable_clipboard_manager. Catch errors in
4461 x_clipboard_manager_save (Bug#8779).
4462 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4463 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4464
99a33b77 44652011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4466
4467 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4468
99a33b77 44692011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4470
4471 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4472 in the current matrix if keep_current_p is non-zero.
4473
8264569d
EZ
44742011-06-04 Eli Zaretskii <eliz@gnu.org>
4475
4476 * bidi.c (bidi_level_of_next_char): Fix last change.
4477
57f97249
EZ
44782011-06-03 Eli Zaretskii <eliz@gnu.org>
4479
fec2107c 4480 Support bidi reordering of text covered by display properties.
57f97249 4481
fec2107c
EZ
4482 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4483 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4484 (bidi_cache_search, bidi_cache_iterator_state)
4485 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4486 (bidi_level_of_next_char, bidi_move_to_visually_next):
4487 Support character positions inside a run of characters covered by a
fec2107c
EZ
4488 display string.
4489 (bidi_paragraph_init, bidi_resolve_explicit_1)
4490 (bidi_level_of_next_char): Call bidi_fetch_char and
4491 bidi_fetch_char_advance instead of FETCH_CHAR and
4492 FETCH_CHAR_ADVANCE.
4493 (bidi_init_it): Initialize new members.
4494 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4495 definitions.
4496 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4497 instead of using explicit *_CHAR codes.
d6d100dd
SM
4498 (bidi_resolve_explicit, bidi_resolve_weak):
4499 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4500 bidirectional text is supported only in multibyte buffers.
4501 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4502 it to initialize the frame_window_p member of struct bidi_it.
4503 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4504 (bidi_resolve_explicit, bidi_resolve_weak)
4505 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4506 bidi_it->nchars is non-positive.
4507 (bidi_level_of_next_char): Don't try to lookup the cache for the
4508 next/previous character if nothing is cached there yet, or if we
4509 were just reseat()'ed to a new position.
c40e2fb2 4510
0e14fe90
EZ
4511 * xdisp.c (set_cursor_from_row): Set start and stop points
4512 according to the row's direction when priming the loop that looks
4513 for the glyph on which to display cursor.
4514 (single_display_spec_intangible_p): Function deleted.
4515 (display_prop_intangible_p): Reimplement to call
4516 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4517 Accept 3 additional arguments needed by handle_display_spec.
4518 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4519 values: lists, `(when COND...)' forms, etc.
4520 (single_display_spec_string_p): Support property values that are
4521 lists with the argument STRING its top-level element.
4522 (display_prop_string_p): Fix the condition for processing a
4523 property that is a list to be consistent with handle_display_spec.
fec2107c 4524 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4525 last portion of handle_display_prop.
4526 (compute_display_string_pos): Accept additional argument
4527 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4528 value of a `display' property is a "replacing spec".
4529 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4530 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4531 the display property, but just return a value indicating whether
4532 the display property will replace the characters it covers.
4533 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4534 frame_window_p members of struct bidi_it.
d6d100dd
SM
4535 (compute_display_string_pos, compute_display_string_end):
4536 New functions.
fec2107c
EZ
4537 (push_it): Accept second argument POSITION, where pop_it should
4538 jump to continue iteration.
4539 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4540
fec2107c
EZ
4541 * keyboard.c (adjust_point_for_property): Adjust the call to
4542 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4543
4544 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4545 (bidi_init_it): Update prototypes.
4546 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4547 (compute_display_string_pos, compute_display_string_end):
4548 Declare prototypes.
fec2107c
EZ
4549 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4550 EMACS_INT.
fc6f18ce 4551
40087514 45522011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4553
57f53182
PE
4554 Malloc failure behavior now depends on size of allocation.
4555 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4556 * lisp.h: Change signatures accordingly.
4557 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4558 All callers changed. (Bug#8762)
4559
4560 * gnutls.c: Use Emacs's memory allocators.
4561 Without this change, the gnutls library would invoke malloc etc.
4562 directly, which causes problems on non-SYNC_INPUT hosts, and which
4563 runs afoul of improving memory_full behavior. (Bug#8761)
4564 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4565 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4566 xfree instead of the default malloc, realloc, free.
4567 (Fgnutls_boot): No need to check for memory allocation failure,
4568 since xmalloc does that for us.
4569
ac32cd99 4570 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4571 * category.c (hash_get_category_set):
4572 * ccl.c (ccl_driver):
4573 * charset.c (Fdefine_charset_internal):
4574 * charset.h (struct charset.hash_index):
4575 * composite.c (get_composition_id, gstring_lookup_cache)
4576 (composition_gstring_put_cache):
4577 * composite.h (struct composition.hash_index):
4578 * dispextern.h (struct image.hash):
4579 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4580 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4581 (hashfn_equal, hashfn_user_defined, make_hash_table)
4582 (maybe_resize_hash_table, hash_lookup, hash_put)
4583 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4584 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4585 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4586 * image.c (make_image, search_image_cache, lookup_image)
4587 (xpm_put_color_table_h):
4588 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4589 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4590 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4591 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4592 * alloc.c (allocate_vectorlike):
4593 Check for overflow in vector size calculations.
4594 * ccl.c (ccl_driver):
4595 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4596 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4597 need to be updated by these changes.
40087514
PE
4598 * fns.c (make_hash_table, maybe_resize_hash_table):
4599 Check for integer overflow with large hash tables.
0de4bb68
PE
4600 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4601 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4602 (SXHASH_REDUCE): New macro.
4603 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4604 Use it instead of discarding useful hash info with large hash values.
4605 (sxhash_float): New function.
4606 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4607 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4608 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4609 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4610 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4611 Adjust signatures to match updated version of code.
4612 (consing_since_gc): Now EMACS_INT, since a single hash table can
4613 use more than INT_MAX bytes.
4614
698d32e2
DN
46152011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4616
4617 Make it possible to build with GCC-4.6+ -O2 -flto.
4618
4619 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4620
fd6fa53f
SM
46212011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4622
4623 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4624 Call minibuffer-inactive-mode.
4625
864db017
JB
46262011-05-31 Juanma Barranquero <lekktu@gmail.com>
4627
4628 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4629 Update dependencies.
4630
2ad0baf4
DN
46312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4632
4633 * data.c (init_data): Remove code for UTS, this system is not
4634 supported anymore.
4635
4fcc2638
DN
46362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4637
4638 Don't force ./temacs to start in terminal mode.
4639
4640 * frame.c (make_initial_frame): Initialize faces in all cases, not
4641 only when CANNOT_DUMP is defined.
4642 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4643
c56e0fd5
DN
46442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4645
4646 * dispnew.c (add_window_display_history): Use const for the string
4647 pointer. Remove declaration, not needed.
4648
333d54da 46492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4650
55d4c1b2 4651 Use 'inline', not 'INLINE'.
333d54da 4652 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4653 * alloc.c, fontset.c (INLINE): Remove.
4654 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4655 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4656 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4657 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4658 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4659
738db178
DN
46602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4661
4662 Make it possible to run ./temacs.
4663
4664 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4665 syms_of_callproc does the same thing. Remove test for
4666 "initialized", do it in the caller.
4667 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4668
620c53a6
SM
46692011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4670
4671 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4672 (read_minibuf): Use get_minibuffer.
4673 (syms_of_minibuf): Use DEFSYM.
4674 (Qmetadata): New var.
4675 * data.c (Qbuffer): Don't make it static.
4676 (syms_of_data): Use DEFSYM.
4677
e003a292
PE
46782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4679
4680 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4681 (CCL_CODE_MIN): New macro.
4682
ed008a6d
PE
46832011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4684
3687c2ef
PE
4685 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4686
ed008a6d
PE
4687 * eval.c (Qdebug): Now static.
4688 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4689 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4690 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4691
d66c4c7c
CY
46922011-05-29 Chong Yidong <cyd@stupidchicken.com>
4693
4694 * image.c: Various fixes to ImageMagick code comments.
4695 (Fimagemagick_types): Doc fix.
4696
5fbc2025
PE
46972011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4698
0196f88a
PE
4699 Minor fixes prompted by GCC 4.6.0 warnings.
4700
4701 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4702
5fbc2025
PE
4703 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4704 (x_clipboard_manager_save_all): Move extern decl to ...
4705 * xterm.h: ... here, so that it can be checked for consistency.
4706
1dd3c2d9
CY
47072011-05-29 Chong Yidong <cyd@stupidchicken.com>
4708
4709 * xselect.c (x_clipboard_manager_save_frame)
4710 (x_clipboard_manager_save_all): New functions.
4711 (Fx_clipboard_manager_save): Lisp function deleted.
4712
4713 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4714 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4715
4716 * xterm.h: Update prototype.
4717
5ba6571d
WX
47182011-05-28 William Xu <william.xwl@gmail.com>
4719
4720 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4721 exiting (Bug#8239).
4722
3eaff834
JM
47232011-05-28 Jim Meyering <meyering@redhat.com>
4724
e1900994 4725 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4726 * fns.c (to_uchar): Define.
4727 (crypto_hash_function): Use it to convert some newly-signed
4728 variables to unsigned, to avoid sign-extension bugs. For example,
4729 without this change, (md5 "truc") would evaluate to
4730 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4731 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4732 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4733
0f6990a7
PE
47342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 Integer overflow fixes.
c8a9ca5a 4737
08686060
PE
4738 * dbusbind.c: Serial number integer overflow fixes.
4739 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4740 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4741 to hold a serial number that is too large for a fixnum.
4742 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4743 Check for serial numbers out of range. Decode any serial number
59568bf0 4744 that was so large that it became a float. (Bug#8722)
08686060 4745
2d1fc3c7
PE
4746 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4747 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4748 Use XFASTINT rather than XUINT when numbers are nonnegative.
4749 (xd_append_arg, Fdbus_method_return_internal):
4750 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4751 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4752 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4753 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4754 (Bug#8722)
2d1fc3c7 4755
c8a9ca5a
PE
4756 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4757
519e1d69
PE
4758 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4759
30569699
PE
4760 ccl: add integer overflow checks
4761 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4762 (IN_INT_RANGE): New macros.
4763 (ccl_driver): Use them to check for integer overflow when
4764 decoding a CCL program. Many of the new checks are whether XINT (x)
4765 fits in int; it doesn't always, on 64-bit hosts. The new version
4766 doesn't catch all possible integer overflows, but it's an
847044ea 4767 improvement. (Bug#8719)
30569699 4768
c11285dc
PE
4769 * alloc.c (make_event_array): Use XINT, not XUINT.
4770 There's no need for unsigned here.
4771
fdccd48e
PE
4772 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4773 This follows up to the 2011-05-06 change that substituted uintptr_t
4774 for EMACS_INT. This case wasn't caught back then.
4775
37910ab2
PE
4776 Rework Fformat to avoid integer overflow issues.
4777 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4778 now (part of C89). Include <verify.h>.
4779 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4780 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4781 (Fformat): Avoid the prepass trying to compute sizes; it was only
4782 approximate and thus did not catch overflow reliably. Instead, walk
4783 through the format just once, formatting and computing sizes as we go,
4784 checking for integer overflow at every step, and allocating a larger
4785 buffer as needed. Keep track separately whether the format is
4786 multibyte. Keep only the most-recently calculated precision, rather
4787 than them all. Record whether each argument has been converted to
4788 string. Use EMACS_INT, not int, for byte and char and arg counts.
4789 Support field widths and precisions larger than INT_MAX. Avoid
4790 sprintf's undefined behavior with conversion specifications such as %#d
4791 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4792 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4793 formatting out-of-range floating point numbers with int
9173deec 4794 formats. (Bug#8668)
37910ab2 4795
2e6578fb
PE
4796 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4797
0ae6bdee
PE
4798 * data.c: Avoid integer truncation in expressions involving floats.
4799 * data.c: Include <intprops.h>.
4800 (arith_driver): When there's an integer overflow in an expression
4801 involving floating point, convert the integers to floating point
4802 so that the resulting value does not suffer from catastrophic
4803 integer truncation. For example, on a 64-bit host (* 4
4804 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4805 Do not rely on undefined behavior after integer overflow.
4806
de883a70
PE
4807 merge count_size_as_multibyte, parse_str_to_multibyte
4808 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4809 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4810 Check for integer overflow.
4811 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4812 since it's now a duplicate of the other. This is more of
4813 a character than a buffer op, so better that it's in character.c.
4814 * fns.c, print.c: Adjust to above changes.
4815
2ff916cb
PE
48162011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4817
4818 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4819
f1b54466
PE
48202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4821
fb1ac845
PE
4822 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4823 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4824 (x_clipboard_manager_save): Now static.
4825 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4826
f1b54466
PE
4827 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4828 (crypto_hash_function): Now static.
4829 Fix pointer signedness problems. Avoid unnecessary initializations.
4830
a9f737ee
CY
48312011-05-27 Chong Yidong <cyd@stupidchicken.com>
4832
4833 * termhooks.h (Vselection_alist): Make it terminal-local.
4834
4835 * terminal.c (create_terminal): Initialize it.
4836
4837 * xselect.c: Support for clipboard managers.
4838 (Vselection_alist): Move to termhooks.h as terminal-local var.
4839 (LOCAL_SELECTION): New macro.
4840 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4841 (symbol_to_x_atom): Remove gratuitous arg.
4842 (x_handle_selection_request, lisp_data_to_selection_data)
4843 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4844 (x_own_selection, x_get_local_selection, x_convert_selection):
4845 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4846 (some_frame_on_display): Delete unused function.
4847 (Fx_own_selection_internal, Fx_get_selection_internal)
4848 (Fx_disown_selection_internal, Fx_selection_owner_p)
4849 (Fx_selection_exists_p): New optional frame arg.
4850 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4851 (x_handle_selection_clear): Don't treat other terminals with the
4852 same keyboard specially. Use the terminal-local Vselection_alist.
4853 (x_clear_frame_selections): Use Frun_hook_with_args.
4854
4855 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4856
4857 * xterm.h: Add support for those atoms.
4858
e067f0c1
CY
48592011-05-26 Chong Yidong <cyd@stupidchicken.com>
4860
4861 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4862 (converted_selections, conversion_fail_tag): New global variables.
4863 (x_selection_request_lisp_error): Free the above.
4864 (x_get_local_selection): Remove unnecessary code.
4865 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4866 of converted selections stored in converted_selections.
4867 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4868 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4869 (x_convert_selection): New function.
4870 (x_handle_selection_event): Simplify.
4871 (x_get_foreign_selection): Don't ignore incoming requests while
4872 waiting for an answer; this will fail when we implement
4873 SAVE_TARGETS, and seems unnecessary anyway.
4874 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4875 (Vx_sent_selection_functions): Doc fix.
4876
0f4aebc0
LL
48772011-05-26 Leo Liu <sdl.web@gmail.com>
4878
4879 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4880
e61124cd
YM
48812011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4882
4883 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4884
4885 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4886 for fringe update if it has periodic bitmap.
ac389d0c 4887 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4888 and fringe_bitmap_periodic_p.
4889
4890 * fringe.c (get_fringe_bitmap_data): New function.
4891 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4892 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4893 row. Mark glyph row for fringe update if periodicity changed.
4894
4895 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4896 for fringe update unless it has periodic bitmap.
4897
f16d9837
KH
48982011-05-25 Kenichi Handa <handa@m17n.org>
4899
4900 * xdisp.c (get_next_display_element): Set correct it->face_id for
4901 a static composition.
4902
e1b90ef6
LL
49032011-05-24 Leo Liu <sdl.web@gmail.com>
4904
4905 * deps.mk (fns.o):
4906 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4907
4908 * fns.c (crypto_hash_function, Fsha1): New function.
4909 (Fmd5): Use crypto_hash_function.
4910 (syms_of_fns): Add Ssha1.
4911
7400048f
PE
49122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4913
4914 * gnutls.c: Remove unused macros.
4915 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4916 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4917 Remove macros that are defined and never used.
4918 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4919
abb71cf4
CY
49202011-05-22 Chong Yidong <cyd@stupidchicken.com>
4921
4922 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4923 (Fx_get_selection_internal): Minor cleanup.
4924 (Fx_own_selection_internal): Rename arguments for consistency with
4925 select.el.
4926
6307db39
PE
49272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4928
4929 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4930
f3d4e0a4
CY
49312011-05-22 Chong Yidong <cyd@stupidchicken.com>
4932
4933 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4934
4d8ade89
YM
49352011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4936
4937 * dispnew.c (scrolling_window): Don't exclude the case that the
4938 last enabled row in the desired matrix touches the bottom boundary.
4939
32078c8d
GM
49402011-05-21 Glenn Morris <rgm@gnu.org>
4941
4942 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4943 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4944 and add some more files.
32078c8d 4945
7285dc67
EZ
49462011-05-20 Eli Zaretskii <eliz@gnu.org>
4947
4948 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4949 report_file_error introduced by the change from 2011-05-07.
4950
89d1bd22
PE
49512011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 * systime.h (Time): Define only if emacs is defined.
4954 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4955 where the include path doesn't have X11/X.h by default. See
4956 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4957
e23640bb 49582011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4959
4960 * composite.c (find_automatic_composition): Fix previous change.
4961
b9704ad9
GM
49622011-05-20 Glenn Morris <rgm@gnu.org>
4963
4964 * lisp.mk: New file, split from Makefile.in.
4965 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4966 (shortlisp): Remove.
4967 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4968
4a720484
GM
49692011-05-19 Glenn Morris <rgm@gnu.org>
4970
4971 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4972 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4973 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4974 (lisp): Set the order to that of loadup.el.
4975 (shortlisp): Make it a copy of $lisp.
4976 (SOME_MACHINE_LISP): Remove.
4977 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4978 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4979
a28d4396
KH
49802011-05-18 Kenichi Handa <handa@m17n.org>
4981
4982 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4983 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4984 (find_automatic_composition): Mostly rewrite for efficiency.
4985
a2b1fa8e
JB
49862011-05-18 Juanma Barranquero <lekktu@gmail.com>
4987
4988 * makefile.w32-in: Update dependencies.
4989
8e1f5610
CS
49902011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4991
4992 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4993 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4994
7025ee00 49952011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4996
cdfa6eab
PE
4997 Fix some integer overflow issues, such as string length overflow.
4998
06d6db33
PE
4999 * insdel.c (count_size_as_multibyte): Check for string overflow.
5000
2b4560a8
PE
5001 * character.c (lisp_string_width): Check for string overflow.
5002 Use EMACS_INT, not int, for string indexes and lengths; in
5003 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5004 the resulting string length overflows an EMACS_INT; instead,
5005 report a string overflow if no precision given. When checking for
5006 precision exhaustion, use a check that cannot possibly have
5007 integer overflow. (Bug#8675)
5008 * character.h (lisp_string_width): Adjust to new signature.
5009
cb93f9be
PE
5010 * alloc.c (string_overflow): New function.
5011 (Fmake_string): Use it. This doesn't change behavior, but saves
5012 a few bytes and will simplify future changes.
5013 * character.c (string_escape_byte8): Likewise.
5014 * lisp.h (string_overflow): New decl.
5015
1a1f3366
PE
5016 Fixups, following up to the user-interface timestamp change.
5017 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5018 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5019 * msdos.c (mouse_get_pos): Likewise.
5020 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5021 * w32gui.h (Time): Define by including "systime.h" rather than by
5022 declaring it ourselves. (Bug#8664)
5023
d4e3e4d3
PE
5024 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5025 * image.c (clear_image_cache): Likewise.
5026
f6a24d19
PE
5027 * term.c (term_mouse_position): Don't assume time_t wraparound.
5028
08dc5ae6
PE
5029 Be more systematic about user-interface timestamps.
5030 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5031 and sometimes 'EMACS_UINT', to represent these timestamps.
5032 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5033 This makes the code easier to follow, and makes it easier to catch
5034 integer overflow bugs such as Bug#8664.
5035 * frame.c (Fmouse_position, Fmouse_pixel_position):
5036 Use Time, not unsigned long, for user-interface timestamps.
5037 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5038 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5039 * keyboard.h (last_event_timestamp): Likewise.
5040 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5041 * menu.h (xmenu_show): Likewise.
5042 * term.c (term_mouse_position): Likewise.
5043 * termhooks.h (struct input_event.timestamp): Likewise.
5044 (struct terminal.mouse_position_hook): Likewise.
5045 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5046 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5047 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5048 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5049 what it was before.
5050 * menu.h, termhooks.h: Include "systime.h", for Time.
5051
8e55734a
PE
5052 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5053 Don't assume that the difference between two unsigned long values
5054 can fit into an integer. At this point, we know button_down_time
5055 <= event->timestamp, so the difference must be nonnegative, so
5056 there's no need to cast the result if double-click-time is
5057 nonnegative, as it should be; check that it's nonnegative, just in
5058 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5059 apart (about 25 days). (Bug#8664)
8e55734a 5060
841f1b75 5061 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5062 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5063
3e26f69c
PE
5064 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5065 that always fit in int. Use a sentinel instead of a counter, to
5066 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5067 * frame.h (struct frame): Use int for menu_bar_items_used
5068 instead of EMACS_INT, since it always fits in int.
3e26f69c 5069
5cc152c0
PE
5070 * menu.c (grow_menu_items): Check for int overflow.
5071
d89eb65e
PE
5072 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5073
5235bd3e
PE
5074 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5075 Before, the code was not consistent. These values cannot exceed
5076 2**31 - 1 so there's no need to make them unsigned.
5077 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5078 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5079 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5080 as modifiers.
5081 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5082
bc827e23
PE
5083 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5084 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5085 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5086 presumably because the widths might not match.
5087
78eb494e
PE
5088 * window.c (size_window): Avoid needless test at loop start.
5089
04f2d78b
CB
50902011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5091
5092 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5093
d2fc7e3d 50942011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5095
5096 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5097
d2fc7e3d 50982011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5099
5100 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5101 `width' to `bar_area_x' and `bar_area_width', respectively.
5102 (x_scroll_run): Take account of fringe background extension.
5103
04f2d78b
CB
5104 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5105 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5106 `bar_area_width', respectively.
5107 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5108 background extension.
5109
79b70037
GM
51102011-05-10 Jim Meyering <meyering@redhat.com>
5111
5112 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5113
2f142cc5
JB
51142011-05-10 Juanma Barranquero <lekktu@gmail.com>
5115
5116 * image.c (Finit_image_library): Return t for built-in image types,
5117 like pbm and xbm. (Bug#8640)
5118
57679c86
AS
51192011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5120
5121 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5122
888c9e86
EZ
51232011-05-07 Eli Zaretskii <eliz@gnu.org>
5124
b0512a1d
EZ
5125 * w32console.c (Fset_screen_color): Doc fix.
5126 (Fget_screen_color): New function.
5127 (syms_of_ntterm): Defsubr it.
5128
7285dc67
EZ
5129 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5130 unlink the temporary file if Fcall_process didn't create it in the
5131 first place.
5132 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5133 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5134 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5135 cue to call_process_cleanup not to close that handle.
5136
4d3fcc8e
BK
51372011-05-07 Ben Key <bkey76@gmail.com>
5138
5139 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5140 one of two shell specific rules, either bootstrap-temacs-CMD or
5141 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5142 to the previous implementation of the bootstrap-temacs rule.
5143 The bootstrap-temacs-CMD rule is similar to the previous
5144 implementation of the bootstrap-temacs rule except that it
5145 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5146 variable.
5147
5148 These changes, along with some changes to nt/configure.bat,
5149 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5150 earlier fix to add support for --cflags and --ldflags options
5151 that include quotes so that it works whether make uses cmd or
5152 sh as the shell.
5153
b4289b64
MA
51542011-05-06 Michael Albinus <michael.albinus@gmx.de>
5155
5156 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5157 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5158 is a constant.
5159 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5160 a string. Handle both cases.
5161 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5162 (Fdbus_register_method): Use Qinvalid_function.
5163
af4c0e28
JB
51642011-05-06 Juanma Barranquero <lekktu@gmail.com>
5165
5166 * makefile.w32-in: Update dependencies.
5167 (LISP_H): Add inttypes.h and stdin.h.
5168 (PROCESS_H): Add unistd.h.
5169
c51453d9
EZ
51702011-05-06 Eli Zaretskii <eliz@gnu.org>
5171
5172 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5173 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5174
8ff0ac3c 51752011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5176
4c4b566b
PE
5177 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5178
aab2b9b5
PE
5179 * term.c (vfatal): Remove stray call to va_end.
5180 It's not needed and the C Standard doesn't allow it here anyway.
5181
c378da0b
PE
5182 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5183 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5184
288b08c7
PE
5185 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5186 bytes.
5187
e3601888
PE
5188 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5189
db6c0e74
PE
5190 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5191
dd5963ea
PE
5192 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5193
88c9450f
PE
5194 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5195
2f9442b8
PE
5196 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5197
c032b5f8
PE
5198 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5199 * charset.c (Fdefine_charset_internal): Don't initialize
5200 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5201 32-bit int (Bug#8600).
a108c10b
PE
5202
5203 * lread.c (read_integer): Be more consistent with string-to-number.
5204 Use string_to_number to do the actual conversion; this avoids
5205 rounding errors and fixes some other screwups. Without this fix,
5206 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5207 (digit_to_number): Move earlier, for benefit of read_integer.
5208 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5209 not a digit in any supported base. (Bug#8602)
a108c10b 5210
ad5f9eea
PE
5211 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5212
aec1708a
PE
5213 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5214 to match comment at start of function. This also removes a
5215 GCC warning about overflow in a 32+64-bit port.
5216
47be4ab5
PE
5217 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5218
371cac43
PE
5219 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5220 Reported by Stefan Monnier in
5221 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5222 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5223 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5224
d01a7826
PE
5225 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5226 (EMACS_UINTPTR): Likewise, with uintptr_t.
5227
7fd47d5c
PE
5228 * lisp.h: Prefer 64-bit EMACS_INT if available.
5229 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5230 on 32-bit hosts that have 64-bit int, so that they can access
5231 large files.
122b0c86
PE
5232 However, temporarily disable this change unless the temporary
5233 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5234
8727937b
PE
5235 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5236
8ac068ac
PE
5237 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5238 This removes an assumption that EMACS_INT and long are the same
5239 width as pointers. The assumption is true for Emacs porting targets
5240 now, but we want to make other targets possible.
5241 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5242 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5243 In the rest of the code, change types of integers that hold casted
5244 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5245 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5246 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5247 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5248 No need to cast type when ORing.
5249 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5250 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5251 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5252 assume EMACS_INT is the same width as char *.
5253 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5254 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5255 Remove no-longer-needed casts.
5256 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5257 (xg_tool_bar_help_callback, xg_make_tool_item):
5258 Use EMACS_INTPTR to hold an integer
5259 that will be cast to void *; this can avoid a GCC warning
5260 if EMACS_INT is not the same width as void *.
5261 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5262 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5263 (current_message_1, set_message_1):
5264 Use a local to convert to proper width without a cast.
5265 * xmenu.c (dialog_selection_callback): Likewise.
5266
ede49d71
PE
5267 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5268 Also, don't assume VALBITS / RAND_BITS is less than 5,
5269 and don't rely on undefined behavior when shifting a 1 left into
5270 the sign bit.
5271 * lisp.h (get_random): Change signature to match.
5272
2f30ecd0
PE
5273 * lread.c (hash_string): Use size_t, not int, for hash computation.
5274 Normally we prefer signed values; but hashing is special, because
5275 it's better to use unsigned division on hash table sizes so that
5276 the remainder is nonnegative. Also, size_t is the natural width
5277 for hashing into memory. The previous code used 'int', which doesn't
5278 retain enough info to hash well into very large tables.
5279 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5280
2a866e7b
PE
5281 * dbusbind.c: Don't possibly lose pointer info when converting.
5282 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5283 Use XPNTR rather than XHASH, so that the high-order bits of
5284 the pointer aren't lost when converting through void *.
5285
51639eac
PE
5286 * eval.c (Fautoload): Don't double-shift a pointer.
5287
92394119
PE
5288 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5289
dbdb9a7c
JB
52902011-05-06 Juanma Barranquero <lekktu@gmail.com>
5291
5292 * gnutls.c (DEF_GNUTLS_FN):
5293 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5294
db7a0b4f
AS
52952011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5296
5297 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5298 marker. (Bug#8610)
5299
f7ff1b0f 53002011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5301
5302 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5303 New version that can reserve upto 2GB of heap space.
5304
f7ff1b0f 53052011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5306
5307 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5308
639c109b
TZ
53092011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5310
5311 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5312 `gnutls_certificate_set_x509_key_file'.
5313
d2127135
JB
53142011-05-05 Juanma Barranquero <lekktu@gmail.com>
5315
5316 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5317 Update dependencies.
5318
e968f4f3
JB
53192011-05-04 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5322 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5323 Remove unused parameter `fildes'.
5324 * process.c (read_process_output, send_process): Don't pass it.
5325
84d358f0
JB
53262011-05-04 Juanma Barranquero <lekktu@gmail.com>
5327
5328 Fix previous change: the library cache is defined in w32.c.
5329 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5330 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5331
0898ca10
JB
53322011-05-04 Juanma Barranquero <lekktu@gmail.com>
5333
5334 Implement dynamic loading of GnuTLS on Windows.
5335
5336 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5337 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5338 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5339 Declare.
5340
5341 * gnutls.c (Qgnutls_dll): Define.
5342 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5343 (gnutls_*): Declare function pointers.
5344 (init_gnutls_functions): New function to initialize function pointers.
5345 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5346 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5347 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5348 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5349 (emacs_gnutls_write, emacs_gnutls_read)
5350 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5351 (Fgnutls_available_p): New function.
5352 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5353 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5354 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5355
5356 * image.c: Include w32.h.
5357 (Vimage_type_cache): Delete.
5358 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5359 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5360 (w32_delayed_load): Move to w32.c.
5361
5362 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5363
5364 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5365 (w32_delayed_load): Move from image.c. When loading a library, record
5366 its filename in the :loaded-from property of the library id.
5367 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5368 Initialize and staticpro them.
5369 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5370
5371 * process.c: Include lisp.h before w32.h, not after.
5372 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5373 instead of gnutls_record_check_pending.
5374
5375 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5376
ff4de4aa
TZ
53772011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5378
5379 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5380 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5381 as passed in.
5382
abe95abb
JD
53832011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5384
5385 * xterm.c (x_set_frame_alpha): Do not set property on anything
5386 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5387
e16e55d4
JB
53882011-05-02 Juanma Barranquero <lekktu@gmail.com>
5389
5390 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5391
bafcf6a5
JB
53922011-05-02 Juanma Barranquero <lekktu@gmail.com>
5393
5394 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5395 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5396 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5397 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5398 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5399 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5400 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5401 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5402 (Qgnutls_bootprop_callbacks_verify): Make static.
5403
e7a6747f
AS
54042011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5405
19ed11ba
AS
5406 * callproc.c: Indentation fixup.
5407
e7a6747f 5408 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5409 (wait_for_termination, interruptible_wait_for_termination):
5410 Move after wait_for_termination_1.
e7a6747f 5411
1ef14cb4
LMI
54122011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5413
5414 * sysdep.c (interruptible_wait_for_termination): New function
5415 which is like wait_for_termination, but allows keyboard
5416 interruptions.
5417
5418 * callproc.c (Fcall_process): Add (:file "file") as an option for
5419 the STDOUT buffer.
5420 (Fcall_process_region): Ditto.
5421
330d880c
EZ
54222011-04-30 Eli Zaretskii <eliz@gnu.org>
5423
8db90b73
EZ
5424 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5425 rather than `XVECTOR (FOO)->size'.
5426
330d880c
EZ
5427 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5428 inttypes.h, as a gnulib replacement is used if it not available in
5429 system headers.
5430
15cbd324
EZ
54312011-04-21 Eli Zaretskii <eliz@gnu.org>
5432
5433 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5434 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5435 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5436
5437 * coding.c (coding_alloc_by_realloc): Error out if destination
5438 will grow beyond MOST_POSITIVE_FIXNUM.
5439 (decode_coding_emacs_mule): Abort if there isn't enough place in
5440 charbuf for the composition carryover bytes. Reserve an extra
5441 space for up to 2 characters produced in a loop.
5442 (decode_coding_iso_2022): Abort if there isn't enough place in
5443 charbuf for the composition carryover bytes.
5444
54452011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5446
ae940cca
EZ
5447 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5448 aborting when %lld or %lll format is passed.
5449 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5450 %llo or %llx format is passed. (Bug#8545)
5451
03ab8921
EZ
5452 * window.c (window_scroll_line_based): Use a marker instead of
5453 simple variables to record original value of point. (Bug#7952)
5454
afda1437
EZ
5455 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5456 produced by %s or %c overflows available buffer space. (Bug#8545)
5457
f76dee0c
PE
54582011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5459
5460 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5461 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5462
fdc5744d
JB
54632011-04-28 Juanma Barranquero <lekktu@gmail.com>
5464
5465 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5466
638f053a
JB
54672011-04-28 Juanma Barranquero <lekktu@gmail.com>
5468
5469 * keyboard.c (Qdelayed_warnings_hook): Define.
5470 (command_loop_1): Run `delayed-warnings-hook'
5471 if Vdelayed_warnings_list is non-nil.
5472 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5473 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5474
d178f871
EZ
54752011-04-28 Eli Zaretskii <eliz@gnu.org>
5476
5477 * doprnt.c (doprnt): Don't return value smaller than the buffer
5478 size if the message was truncated. (Bug#8545).
5479
b124fd93
JB
54802011-04-28 Juanma Barranquero <lekktu@gmail.com>
5481
5482 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5483 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5484
e810457d
PE
54852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5486
5487 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5488
ea51cceb
JB
54892011-04-27 Juanma Barranquero <lekktu@gmail.com>
5490
5491 * makefile.w32-in: Update dependencies.
5492
94dcfacf
EZ
54932011-04-27 Eli Zaretskii <eliz@gnu.org>
5494
5495 Improve `doprnt' and its usage. (Bug#8545)
5496 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5497 `format_end'. Remove support for %l as a conversion specifier.
5498 Don't use xrealloc. Improve diagnostics when the %l size modifier
5499 is used. Update the commentary.
5500
5501 * eval.c (verror): Simplify calculation of size_t.
5502
5503 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5504 messages.
5505
f61f41d7
PE
55062011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5507
5508 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5509 change.
5510
96fb4434
PE
55112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5512
5513 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5514 This makes this file independent of the recent pseudovector change.
5515
671875da 55162011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5517
69e9b5a3
PE
5518 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5519
b5f869a7 5520 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5521 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5522 Remove unused local.
c8926152 5523 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5524
841a1577 5525 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5526 GCC 4.6.0 optimizes based on type-based alias analysis.
5527 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5528 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5529 != &v->size, and therefore "v->size = 1; b->size = 2; return
5530 v->size;" must therefore return 1. This assumption is incorrect
5531 for Emacs, since it type-puns struct Lisp_Vector * with many other
5532 types. To fix this problem, this patch adds a new type struct
f904488f 5533 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5534 and pseudovectors, and helps optimizing compilers not get fooled
5535 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5536 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5537 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5538 the size member.
eab3844f
PE
5539 (XSETPVECTYPE): Rewrite in terms of new macro.
5540 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5541 This is a bit clearer, and further avoids the possibility of
5542 undesirable aliasing.
5543 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5544 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5545 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5546 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5547 (ASIZE): Now uses header.size rather than size.
5548 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5549 to avoid the hassle of writing XVECTOR (foo)->header.size.
5550 (struct vectorlike_header): New type.
eab3844f
PE
5551 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5552 object, to help avoid aliasing.
5553 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5554 (SUBRP): Likewise, since Lisp_Subr is a special case.
5555 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5556 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5557 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5558 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5559 changed to be "header.size" and "header.next".
5560 * buffer.h (struct buffer): Likewise.
5561 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5562 * frame.h (struct frame): Likewise.
5563 * process.h (struct Lisp_Process): Likewise.
5564 * termhooks.h (struct terminal): Likewise.
5565 * window.c (struct save_window_data, struct saved_window): Likewise.
5566 * window.h (struct window): Likewise.
5567 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5568 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5569 * buffer.c (init_buffer_once): Likewise.
5570 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5571 special case.
5572 * process.c (Fformat_network_address): Use local var for size,
5573 for brevity.
5574
0df1eac5
PE
5575 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5576
847ab9d1 5577 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5578 * data.c (atof): Remove decl; no longer used or needed.
5579 (digit_to_number): Move to lread.c.
5580 (Fstring_to_number): Use new string_to_number function, to be
5581 consistent with how the Lisp reader treats infinities and NaNs.
5582 Do not assume that floating-point numbers represent EMACS_INT
5583 without losing information; this is not true on most 64-bit hosts.
5584 Avoid double-rounding errors, by insisting on integers when
5585 parsing non-base-10 numbers, as the documentation specifies.
5586 * lisp.h (string_to_number): New decl, replacing ...
5587 (isfloat_string): Remove.
bc0a5c13 5588 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5589 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5590 appears to have been a coding error. Similarly, do not accept
5591 strings like +-1e0 as floating point numbers. Do not report
5592 overflow for integer overflows unless the base is not 10 which
5593 means we have no simple and reliable way to continue.
5594 Break out the floating-point parsing into a new
5595 function string_to_number, so that Fstring_to_number parses
5596 floating point numbers consistently with the Lisp reader.
04f2d78b 5597 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5598 (E_CHAR, EXP_INT): Remove, replacing with ...
5599 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5600 (string_to_number): New function, replacing isfloat_string.
5601 This function checks for valid syntax and produces the resulting
5602 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5603 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5604 so that overflow for non-base-10 numbers is reported only when
5605 there's no portable and simple way to convert to floating point.
452f4150 5606
67769ffc
PE
5607 * textprop.c (set_text_properties_1): Rewrite for clarity,
5608 and to avoid GCC warning about integer overflow.
5609
c20db43f
PE
5610 * intervals.h (struct interval): Use EMACS_INT for members
5611 where EMACS_UINT might cause problems. See
5612 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5613 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5614 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5615 All uses changed.
37aa2f85
PE
5616 (offset_intervals): Tell GCC not to worry about length overflow
5617 when negating a negative length.
c20db43f 5618
2538aa2f
PE
5619 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5620 (overrun_check_free): Likewise.
5621
f2d3008d
PE
5622 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5623 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5624 word size.
5625
ec8df744
PE
5626 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5627 (gnutls_make_error): Rename local to avoid shadowing.
5628 (gnutls_emacs_global_deinit): ifdef out; not used.
5629 (Fgnutls_boot): Use const for pointer to readonly storage.
5630 Comment out unused local. Fix pointer signedness problems.
5631
640ee02d
PE
5632 * lread.c (openp): Don't stuff size_t into an 'int'.
5633 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5634 about possible signed overflow.
5635
6048fb2a
PE
5636 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5637 (GDK_KEY_g): Don't define if already defined.
5638 (xg_prepare_tooltip): Avoid pointer signedness problem.
5639 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5640
fa3c87e1
PE
5641 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5642 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5643
2172544b
PE
5644 * xfns.c (Fx_window_property): Simplify a bit,
5645 to make a bit faster and to avoid GCC 4.6.0 warning.
5646 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5647
9b821a21
PE
5648 * fns.c (internal_equal): Don't assume size_t fits in int.
5649
3c616cfa
PE
5650 * alloc.c (compact_small_strings): Tighten assertion a little.
5651
c2982e87
PE
5652 Replace pEd with more-general pI, and fix some printf arg casts.
5653 * lisp.h (pI): New macro, generalizing old pEd macro to other
5654 conversion specifiers. For example, use "...%"pI"d..." rather
5655 than "...%"pEd"...".
5656 (pEd): Remove. All uses replaced with similar uses of pI.
5657 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5658 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5659 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5660 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5661 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5662 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5663 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5664 64-bit hosts.
5665 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5666 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5667 * print.c (safe_debug_print, print_object): Likewise.
5668 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5669 to int.
6f04d126
PE
5670 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5671 avoiding the 0 flag, which is not portable.
c2982e87
PE
5672 * process.c (Fmake_network_process): Use pI to avoid cast.
5673 * region-cache.c (pp_cache): Likewise.
5674 * xdisp.c (decode_mode_spec): Likewise.
5675 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5676 behavior on 64-bit hosts with printf arg.
6f04d126 5677 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5678 (x_stop_queuing_selection_requests): Likewise.
5679 (x_get_window_property): Don't truncate byte count to an 'int'
5680 when tracing.
0b432f21 5681
5e073ec7
PE
5682 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5683 here, since it parses constructs like leading '-' and spaces,
5684 which are not wanted; and it overflows with large numbers.
5685 Instead, simply match F[0-9]+, which is what is wanted anyway.
5686
36372bf9
PE
5687 * alloc.c: Remove unportable assumptions about struct layout.
5688 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5689 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5690 (allocate_vectorlike, make_pure_vector): Use the new macros,
5691 plus offsetof, to remove unportable assumptions about struct layout.
5692 These assumptions hold on all porting targets that I know of, but
5693 they are not guaranteed, they're easy to remove, and removing them
5694 makes further changes easier.
5695
0b432f21
PE
5696 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5697 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5698 (string_overrun_cookie): Now const. Use initializers that
5699 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5700 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5701 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5702 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5703 multiple of sizeof (EMACS_INT); it need not be, if
5704 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5705 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5706
895009e1
JB
57072011-04-26 Juanma Barranquero <lekktu@gmail.com>
5708
5709 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5710
6a7a1b0b
TZ
57112011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5712
5713 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5714 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5715 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5716
841a1577 57172011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5718
5719 * lisp.h (Qdebug): List symbol.
895009e1 5720 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5721 * keyboard.c (debug-on-event): New variable.
5722 (handle_user_signal): Break into debugger when debug-on-event
5723 matches the current signal symbol.
5724
f2d3ba6f
DN
57252011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5726
5727 * alloc.c (check_sblock, check_string_bytes)
5728 (check_string_free_list): Convert to standard C.
5729
42ce4c63
TZ
57302011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5731
5732 * w32.c (emacs_gnutls_push): Fix typo.
5733
825cd63c
EZ
57342011-04-25 Eli Zaretskii <eliz@gnu.org>
5735
fb11d64d
EZ
5736 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5737 "cast to pointer from integer of different size".
5738
825cd63c
EZ
5739 Improve doprnt and its use in verror. (Bug#8545)
5740 * doprnt.c (doprnt): Document the set of format control sequences
5741 supported by the function. Use SAFE_ALLOCA instead of always
5742 using `alloca'.
5743
5744 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5745 is one byte too soon. Don't use xrealloc; instead xfree and
5746 xmalloc anew.
5747
e061a11b
TZ
57482011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5749
5750 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5751 callbacks stage.
5752
5753 * gnutls.c: Renamed global_initialized to
5754 gnutls_global_initialized. Added internals for the
5755 :verify-hostname-error, :verify-error, and :verify-flags
5756 parameters of `gnutls-boot' and documented those parameters in the
5757 docstring. Start callback support.
9173deec
JB
5758 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5759 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5760 on error. Return error code.
e061a11b
TZ
5761 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5762 (emacs_gnutls_read): Likewise.
5763 (Fgnutls_boot): Return handshake error code.
5764 (emacs_gnutls_handle_error): New function.
5765 (wsaerror_to_errno): Likewise.
5766
5767 * w32.h (emacs_gnutls_pull): Add prototype.
5768 (emacs_gnutls_push): Likewise.
5769
5770 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5771 (emacs_gnutls_push): Likewise.
5772
57732011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5774
5775 * process.c (wait_reading_process_output): Check if GnuTLS
5776 buffered some data internally if no FDs are set for TLS
5777 connections.
5778
5779 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5780 (LIBS): Link to USER_LIBS.
5781 ($(BLD)/gnutls.$(0)): New target.
5782
fa6996bc
EZ
57832011-04-24 Eli Zaretskii <eliz@gnu.org>
5784
eb35682e
EZ
5785 * xdisp.c (handle_single_display_spec): Rename the
5786 display_replaced_before_p argument into display_replaced_p, to
5787 make it consistent with the commentary. Fix typos in the
5788 commentary.
5789
e2ad650c
EZ
5790 * textprop.c (syms_of_textprop): Remove dead code.
5791 (copy_text_properties): Delete obsolete commentary about an
5792 interface that was deleted long ago. Fix typos in the description
5793 of arguments.
5794
1b2de274
EZ
5795 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5796 to changes in oldXMenu/XMenu.h from 2011-04-16.
5797 <menu_help_message, prev_menu_help_message>: Constify.
5798 (IT_menu_make_room): menu->help_text is now `const char **';
5799 adjust.
5800
5801 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5802 to changes in oldXMenu/XMenu.h from 2011-04-16.
5803 (struct XMenu): Declare `help_text' `const char **'.
5804
5805 * xfaces.c <Qunspecified>: Make extern again.
5806
5807 * syntax.c: Include sys/types.h before including regex.h, as
5808 required by Posix.
5809
762b15be
EZ
5810 * doc.c (get_doc_string): Improve the format passed to `error'.
5811
5812 * doprnt.c (doprnt): Improve commentary.
5813
5814 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5815
5816 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5817 them with etags.
5818
f1052e5d
EZ
5819 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5820 changes in globals.h immediately force recompilation.
762b15be
EZ
5821 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5822 $(CURDIR)/s/ms-w32.h.
5823 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5824
fa6996bc
EZ
5825 * character.c (Fchar_direction): Function deleted.
5826 (syms_of_character): Don't defsubr it.
5827 <char-direction-table>: Deleted.
5828
e6c3da20
EZ
58292011-04-23 Eli Zaretskii <eliz@gnu.org>
5830
5831 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5832 * doprnt.c: Include limits.h.
5833 (SIZE_MAX): New macro.
04f2d78b
CB
5834 (doprnt): Return a size_t value. 2nd arg is now size_t.
5835 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5836 Improve overflow protection. Support `l' modifier for integer
5837 conversions. Support %l conversion. Don't assume an EMACS_INT
5838 argument for integer conversions and for %c.
5839
5840 * lisp.h (doprnt): Restore prototype.
5841
5842 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5843 $(SRC)/character.h.
5844
5845 * Makefile.in (base_obj): Add back doprnt.o.
5846
5847 * deps.mk (doprnt.o): Add back prerequisites.
5848 (callint.o): Depend on character.h.
5849
5850 * eval.c (internal_lisp_condition_case): Include the handler
5851 representation in the error message.
5852 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5853 when breaking from the loop.
5854
5855 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5856
5857 * callint.c (Fcall_interactively): When displaying error message
5858 about invalid control letter, pass the character's codepoint, not
5859 a pointer to its multibyte form. Improve display of the character
5860 in octal and display also its hex code.
5861
5862 * character.c (char_string): Use %x to display the (unsigned)
5863 codepoint of an invalid character, to avoid displaying a bogus
5864 negative value.
5865
5866 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5867 `error', not SYMBOL_NAME itself.
5868
5869 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5870 character arguments to `error'.
5871
5872 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5873 to `error' in error message about FINAL_CHAR argument. Make sure
5874 FINAL_CHAR is a character, and use %c when it is passed as
5875 argument to `error'.
5876
4ffd0d6b 58772011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5878
5879 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5880
5881 * w32.c: Include <time.h>.
5882 (sys_localtime): New function.
5883
4ffd0d6b 58842011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5885
5886 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5887
4ffd0d6b 5888 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5889
4ffd0d6b 58902011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5891
4ffd0d6b
GM
5892 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5893 zombies (Bug#8467).
aac0c6e3 5894
04c56954
EZ
58952011-04-19 Eli Zaretskii <eliz@gnu.org>
5896
5897 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5898 gl_state.e_property when gl_state.object is Qt.
5899
5900 * insdel.c (make_gap_larger): Remove limitation of buffer size
5901 to <= INT_MAX.
5902
16a43933
CY
59032011-04-18 Chong Yidong <cyd@stupidchicken.com>
5904
5905 * xdisp.c (lookup_glyphless_char_display)
5906 (produce_glyphless_glyph): Handle cons cell entry in
5907 glyphless-char-display.
5908 (Vglyphless_char_display): Document it.
5909
5910 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5911 glyphless-char-display.
5912
4581706e
CY
59132011-04-17 Chong Yidong <cyd@stupidchicken.com>
5914
5915 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5916
5917 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5918
5919 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5920 definition for no-X builds.
5921
4887c6e2 59222011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5923
fd35b6f9
PE
5924 Static checks with GCC 4.6.0 and non-default toolkits.
5925
5c1ccb01
PE
5926 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5927
006c5daa
PE
5928 * process.c (keyboard_bit_set): Define only if SIGIO.
5929 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5930 (send_process): Repair possible setjmp clobbering.
5931
efc736d3
PE
5932 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5933
4e2fe2e6
PE
5934 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5935
f97334a2
PE
5936 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5937
4e75f29d
PE
5938 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5939 Define only if needed.
5940
90efadd1
PE
5941 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5942 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5943 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5944
3c647824
PE
5945 * dispextern.h (struct redisplay_interface): Rename param
5946 to avoid shadowing.
e264f262 5947 * termhooks.h (struct terminal): Likewise.
761383f4 5948 * xterm.c (xembed_send_message): Likewise.
3c647824 5949
b58c5c4a
PE
5950 * insdel.c (make_gap_smaller): Define only if
5951 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5952
cad59032
PE
5953 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5954 it.
5955
c339dc2e
PE
5956 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5957 so that we aren't warned about unused symbols.
5958
91a3e27b
PE
5959 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5960
399c71d3 5961 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5962
8ffc96f5
PE
5963 * xfns.c (x_real_positions): Mark locals as initialized.
5964
eef9bc79
PE
5965 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5966
098db9dd
PE
5967 * xterm.c: Fix problems found by static analysis with other toolkits.
5968 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5969 (x_dispatch_event): Declare static if USE_GTK, and
5970 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5971 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5972 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5973 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5974 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5975
eb18f6cc
PE
5976 * xmenu.c (menu_help_callback): Pointer type fixes.
5977 Use const pointers when pointing at readonly data. Avoid pointer
5978 signedness clashes.
5979 (FALSE): Remove unused macro.
5980 (update_frame_menubar): Remove unused decl.
5981
1fe72bf8
PE
5982 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5983
60d9e1db
PE
5984 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5985 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5986 (single_menu_item): Rename local to avoid shadowing.
5987
39261c26
PE
5988 * keyboard.c (make_lispy_event): Remove unused local var.
5989
018c5e19
PE
5990 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5991 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5992
63d2b86e
PE
5993 * bitmaps: Change bitmaps from unsigned char back to the X11
5994 compatible char. Avoid the old compiler warnings about
5995 out-of-range initializers by using, for example, '\xab' rather
5996 than 0xab.
5997
aefd87e1
PE
5998 * xgselect.c (xgselect_initialize): Check vs interface
5999 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6000
bf501fb9
PE
6001 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6002
e9829fdf
PE
6003 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6004 to read-only memory.
6005
1086c095
PE
6006 * fns.c (vector): Remove; this old hack is no longer needed.
6007
2baccd04 6008 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6009 Remove unused var.
dde42981 6010 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6011
72391843 6012 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6013
436c16df 6014 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6015 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6016 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6017
92bb796d 6018 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6019 (x_term_init): Remove local to avoid shadowing.
92bb796d 6020
764430a3 6021 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6022
6023 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6024 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6025
d1dfb56c
EZ
60262011-04-16 Eli Zaretskii <eliz@gnu.org>
6027
c4354cb4
EZ
6028 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6029
d1dfb56c
EZ
6030 Fix regex.c, syntax.c and friends for buffers > 2GB.
6031 * syntax.h (struct gl_state_s): Declare character position members
6032 EMACS_INT.
6033
6034 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6035
04f2d78b
CB
6036 * textprop.c (verify_interval_modification, interval_of):
6037 Declare arguments EMACS_INT.
d1dfb56c
EZ
6038
6039 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6040 EMACS_INT.
6041
6042 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6043
6044 * indent.c (Fvertical_motion): Local variable it_start is now
6045 EMACS_INT.
6046
6047 * regex.c (re_match, re_match_2, re_match_2_internal)
6048 (bcmp_translate, regcomp, regexec, print_double_string)
6049 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6050 (re_compile_pattern, re_exec): Declare arguments and local
6051 variables `size_t' and `ssize_t' and return values `regoff_t', as
6052 appropriate.
6053 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6054 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6055 <compile_stack_type>: `size' and `avail' are now `size_t'.
6056
6057 * regex.h <regoff_t>: Use ssize_t, not int.
6058 (re_search, re_search_2, re_match, re_match_2): Arguments that
6059 specify buffer/string position and length are now ssize_t and
6060 size_t. Return type is regoff_t.
6061
613052cd
BK
60622011-04-16 Ben Key <bkey76@gmail.com>
6063
6064 * nsfont.m: Fixed bugs in ns_get_family and
6065 ns_descriptor_to_entity that were caused by using free to
6066 deallocate memory blocks that were allocated by xmalloc (via
6067 xstrdup). This caused Emacs to crash when compiled with
6068 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6069 --enable-checking=xmallocoverrun). xfree is now used to
6070 deallocate these memory blocks.
6071
4170f62f 60722011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6073
71b41406
PE
6074 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6075
9587a89d
PE
6076 emacs_write: Accept and return EMACS_INT for sizes.
6077 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6078 et seq.
6079 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6080 Accept and return EMACS_INT.
6081 (emacs_gnutls_write): Return the number of bytes written on
6082 partial writes.
6083 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6084 (emacs_read, emacs_write): Remove check for negative size, as the
6085 Emacs source code has been audited now.
9587a89d
PE
6086 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6087 (emacs_read, emacs_write): Use it.
273a5f82
PE
6088 * process.c (send_process): Adjust to the new signatures of
6089 emacs_write and emacs_gnutls_write. Do not attempt to store
6090 a byte offset into an 'int'; it might overflow.
9587a89d 6091 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6092
3e047f51
PE
6093 * sound.c: Don't assume sizes fit in 'int'.
6094 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6095 Return EMACS_INT, not int.
3e047f51 6096 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6097 Accept EMACS_INT, not int.
6098 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6099 record read return values.
6100
cc39a9db
BK
61012011-04-15 Ben Key <bkey76@gmail.com>
6102
c9d0ec6d
JB
6103 * keyboard.c (Qundefined): Don't declare static since it is used
6104 in nsfns.m.
6105 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6106 static since they are used in nsfont.m.
cc39a9db 6107
6c60eb9f
SM
61082011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6109
6110 * process.c (Qprocessp): Don't declare static.
6111 * lisp.h (Qprocessp): Declare again.
6112
7990b61a
JB
61132011-04-15 Juanma Barranquero <lekktu@gmail.com>
6114
6115 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6116
5d4cb038
PE
61172011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6118
8bd7b830 6119 Improve C-level modularity by making more things 'static'.
cd64ea1d 6120
e3b27b31
PE
6121 Don't publish debugger-only interfaces to other modules.
6122 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6123 (verify_bytepos, count_markers): Move decls to the only modules
6124 that need them.
6125 * region-cache.h (pp_cache): Likewise.
6126 * window.h (check_all_windows): Likewise.
6127 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6128
5d4cb038
PE
6129 * sysdep.c (croak): Now static, if
6130 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6131 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6132
6133 * alloc.c (refill_memory_reserve): Now static if
6134 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6135 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6136
e87b6180
PE
6137 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6138 Define only if USE_LUCID.
6139
ac64929e
PE
6140 * xrdb.c (x_customization_string, x_rm_string): Now static.
6141
6f37259d
PE
6142 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6143 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6144
1683e3ab
PE
6145 * xdisp.c (draw_row_with_mouse_face): Now static.
6146 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6147
de9c2632
PE
6148 * window.h (check_all_windows): Mark externally visible.
6149
2b96acb7
PE
6150 * window.c (window_deletion_count): Now static.
6151
6152 * undo.c: Make symbols static if they're not exported.
6153 (last_undo_buffer, last_boundary_position, pending_boundary):
6154 Now static.
6155
50436f33
PE
6156 * textprop.c (interval_insert_behind_hooks): Now static.
6157 (interval_insert_in_front_hooks): Likewise.
6158
64520e5c
PE
6159 * term.c: Make symbols static if they're not exported.
6160 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6161 (max_frame_lines, tty_set_terminal_modes):
6162 (tty_reset_terminal_modes, tty_turn_off_highlight):
6163 (get_tty_terminal): Now static.
6164 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6165 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6166 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6167 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6168 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6169
1fa53021
PE
6170 * sysdep.c: Make symbols static if they're not exported.
6171 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6172 Now static.
6173 (sigprocmask_set, full_mask): Remove; unused.
6174 (wait_debugging): Mark as visible.
6175 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6176 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6177
d4b43b22
PE
6178 * syntax.c (syntax_temp): Define only if !__GNUC__.
6179
b7c513d0
PE
6180 * sound.c (current_sound_device, current_sound): Now static.
6181
989b29ad
PE
6182 * search.c (searchbufs, searchbuf_head): Now static.
6183
13a55a78
PE
6184 * scroll.c (scroll_cost): Remove; unused.
6185 * dispextern.h (scroll_cost): Remove decl.
6186
de68a1fc
PE
6187 * region-cache.h (pp_cache): Mark as externally visible.
6188
40ccffa6
PE
6189 * process.c: Make symbols static if they're not exported.
6190 (process_tick, update_tick, create_process, chan_process):
6191 (Vprocess_alist, proc_buffered_char, datagram_access):
6192 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6193 (deactivate_process): Mark defn as static, as well as decl.
6194 * lisp.h (create_process): Remove decl.
6195 * process.h (chan_process, Vprocess_alist): Remove decls.
6196
ad64fc97
PE
6197 * print.c: Make symbols static if they're not exported.
6198 (print_depth, new_backquote_output, being_printed, print_buffer):
6199 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6200 (print_interval, print_number_index, initial_stderr_stream):
6201 Now static.
6202 * lisp.h (Fprinc): Remove decl.
6203 (debug_output_compilation_hack): Mark as externally visible.
6204
adddb265
PE
6205 * sysdep.c (croak): Move decl from here to syssignal.h.
6206 * syssignal.h (croak): Put it here, so the API can be checked when
6207 'croak' is called from dissociate_if_controlling_tty.
6208
1717ede2
PE
6209 * minibuf.c: Make symbols static if they're not exported.
6210 (minibuf_save_list, choose_minibuf_frame): Now static.
6211 * lisp.h (choose_minibuf_frame): Remove decl.
6212
fa5fb2bc
PE
6213 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6214
1e3890d1
PE
6215 * lread.c: Make symbols static if they're not exported.
6216 (read_objects, initial_obarray, oblookup_last_bucket_number):
6217 Now static.
6218 (make_symbol): Remove; unused.
6219 * lisp.h (initial_obarray, make_symbol): Remove decls.
6220
8a1414fa
PE
6221 * keyboard.c: Make symbols static if they're not exported.
6222 (single_kboard, recent_keys_index, total_keys, recent_keys):
6223 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6224 (this_single_command_key_start, echoing, last_auto_save):
6225 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6226 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6227 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6228 (Vlispy_mouse_stem, double_click_count):
6229 Now static.
6230 (force_auto_save_soon): Define only if SIGDANGER.
6231 (ignore_mouse_drag_p): Now static if
6232 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6233 (print_help): Remove; unused.
6234 (stop_character, last_timer_event): Mark as externally visible.
6235 * keyboard.h (ignore_mouse_drag_p): Declare only if
6236 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6237 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6238 * lisp.h (echoing): Remove decl.
6239 (force_auto_save_soon): Declare only if SIGDANGER.
6240 * xdisp.c (redisplay_window): Simplify code, to make it more
6241 obvious that ignore_mouse_drag_p is not accessed if !defined
6242 USE_GTK && !defined HAVE_NS.
6243
93ea6e8f
PE
6244 * intervals.c: Make symbols static if they're not exported.
6245 (merge_properties_sticky, merge_interval_right, delete_interval):
6246 Now static.
6247 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6248
77382fcc
PE
6249 * insdel.c: Make symbols static if they're not exported.
6250 However, leave prepare_to_modify_buffer alone. It's never
6251 called from outside this function, but that appears to be a bug.
6252 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6253 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6254 (adjust_after_replace_noundo): Remove; unused.
6255 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6256 (signal_before_change): Remove decls.
77382fcc 6257
9306c32e
PE
6258 * indent.c (val_compute_motion, val_vmotion): Now static.
6259
cd44d2eb
PE
6260 * image.c: Make symbols static if they're not exported.
6261 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6262 if USE_GTK.
6263 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6264 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6265
ad9a7a06
PE
6266 * fringe.c (standard_bitmaps): Now static.
6267 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6268
81626931
PE
6269 * frame.c: Make symbols static if they're not exported.
6270 (x_report_frame_params, make_terminal_frame): Now static.
6271 (get_frame_param): Now static, unless HAVE_NS.
6272 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6273 (x_get_resource_string): Remove; not used.
6274 * frame.h (make_terminal_frame, x_report_frame_params):
6275 (x_get_resource_string); Remove decls.
6276 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6277 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6278
239f9db9
PE
6279 * font.c, fontset.c: Make symbols static if they're not exported.
6280 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6281 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6282 * font.c (font_close_object): Now static.
6283 * font.h (font_close_object): Remove.
6284 * fontset.c (FONTSET_OBJLIST): Remove.
6285 (free_realized_fontset) #if-0 the body, which does nothing.
6286 (face_suitable_for_char_p): #if-0, as it's never called.
6287 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6288 * xfaces.c (face_at_string_position):
6289 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6290 since 0 is always ASCII.
6291
dfcf3579
PE
6292 * fns.c (weak_hash_tables): Now static.
6293
5045092b
PE
6294 * fileio.c: Make symbols static if they're not exported.
6295 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6296 (Vwrite_region_annotation_buffers): Now static.
6297
57a96f5c
PE
6298 * eval.c: Make symbols static if they're not exported.
6299 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6300 * lisp.h (backtrace_list): Remove decl.
6301
35f08c38
PE
6302 * emacs.c: Make symbols static if they're not exported.
6303 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6304 (fatal_error_code, fatal_error_signal_hook, standard_args):
6305 Now static.
6306 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6307 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6308 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6309 * lisp.h (fatal_error_signal_hook): Remove decl.
6310 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6311
f44bd759
PE
6312 * editfns.c: Move a (normally-unused) function to its only use.
6313 * editfns.c, lisp.h (get_operating_system_release): Remove.
6314 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6315 worth the hassle of breaking this out.
6316
b532497d
PE
6317 * xterm.c: Make symbols static if they're not exported.
6318 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6319 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6320 (x_destroy_window, x_delete_display):
6321 Now static.
6322 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6323 (x_mouse_leave): Remove; unused.
6324 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6325 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6326 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6327 Remove decls.
6328 (x_mouse_leave): Declare only if WINDOWSNT.
6329 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6330 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6331 USE_X_TOOLKIT.
6332
1675728f
PE
6333 * ftxfont.c: Make symbols static if they're not exported.
6334 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6335 HAVE_FREETYPE.
6336 * font.h (ftxfont_driver): Likewise.
6337
e4cebfca
PE
6338 * xfns.c: Make symbols static if they're not exported.
6339 (x_last_font_name, x_display_info_for_name):
6340 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6341 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6342 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6343 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6344 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6345 (last_show_tip_args): Now static.
6346 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6347 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6348 (x_screen_planes): Remove; unused.
6349 * dispextern.h (x_screen_planes): Remove decl.
6350
5bf46f05
PE
6351 * dispnew.c: Make symbols static if they're not exported.
6352 * dispextern.h (redraw_garbaged_frames, scrolling):
6353 (increment_row_positions): Remove.
6354 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6355 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6356 Now static.
6357 (redraw_garbaged_frames): Remove; unused.
6358
435f4c28
PE
6359 * xfaces.c: Make symbols static if they're not exported.
6360 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6361 Remove decls.
6362 * xterm.h (defined_color): Remove decls.
6363 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6364 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6365 (menu_face_changed_default, defined_color, free_realized_face):
6366 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6367 (ascii_face_of_lisp_face): Remove; unused.
6368
8524aef3
PE
6369 * xdisp.c: Make symbols static if they're not exported.
6370 * dispextern.h (scratch_glyph_row, window_box_edges):
6371 (glyph_to_pixel_coords, set_cursor_from_row):
6372 (get_next_display_element, set_iterator_to_next):
6373 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6374 (show_mouse_face): Remove decls
6375 * frame.h (message_buf_print): Likewise.
6376 * lisp.h (pop_message, set_message, check_point_in_composition):
6377 Likewise.
6378 * xterm.h (set_vertical_scroll_bar): Likewise.
6379 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6380 (message_buf_print, scratch_glyph_row, displayed_buffer):
6381 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6382 (get_next_display_element, show_mouse_face, window_box_edges):
6383 (frame_to_window_pixel_xy, check_point_in_composition):
6384 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6385 (glyph_to_pixel_coords): Remove; unused.
6386
16390cd2
PE
6387 * dired.c (file_name_completion): Now static.
6388
6389 * dbusbind.c (xd_in_read_queued_messages): Now static.
6390
a25f4dfa
PE
6391 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6392 * data.c (circular_list_error): Remove.
6393
14a9c8df
PE
6394 * commands.h (last_point_position, last_point_position_buffer):
6395 (last_point_position_window): Remove decls.
6396 * keyboard.c: Make these variables static.
6397
04f2d78b
CB
6398 * coding.h (coding, code_convert_region, encode_coding_gap):
6399 Remove decls.
74ab6df5
PE
6400 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6401 (iso_code_class, detect_coding, code_convert_region): Now static.
6402 (encode_coding_gap): Remove; unused.
6403
38dfbee1
PE
6404 * chartab.c (chartab_chars, chartab_bits): Now static.
6405
a2cb4e63
PE
6406 * charset.h (charset_iso_8859_1): Remove decl.
6407 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6408 Now static.
6409
127198fd
PE
6410 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6411 * ccl.c (Vccl_program_table): Now static.
6412 (check_ccl_update): Remove; unused.
6413
d85b608f
PE
6414 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6415 * category.h: ... from here.
6416 * category.c (check_category_table, set_category_set): Now static.
6417
31cd66f3
PE
6418 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6419 * lisp.h: Remove these decls.
6420
c358e587
PE
6421 * buffer.c (buffer_count): Remove unused var.
6422
e78aecca
PE
6423 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6424 so that it's not optimized away.
6425 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6426 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6427 exported only to the debugger.
6428
e192d7d3 6429 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6430 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6431
92470028
PE
6432 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6433 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6434 was inaccessible from Lisp.
6435 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6436 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6437
244ed907
PE
6438 alloc.c: Import and export fewer symbols, and remove unused items.
6439 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6440 is defined.
6441 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6442 it's not optimized away by whole-program optimization.
6443 (message_enable_multibyte, free_misc): Remove.
6444 (catchlist, handlerlist, mark_backtrace):
6445 Declare only if BYTE_MARK_STACK.
6446 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6447 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6448 (message_enable_multibyte): Remove decl.
6449 (free_misc, interval_free_list, float_block, float_block_index):
6450 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6451 (cons_free_list, last_marked_index):
6452 Now static.
6453 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6454 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6455 (mark_backtrace): Define only if BYTE_MARK_STACK.
6456 * xdisp.c (message_enable_multibyte): Now static.
6457
61c2b50e 6458 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6459 This makes it easier for human readers (and static analyzers)
6460 to see whether these variables are used from other modules.
6461 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6462 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6463 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6464 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6465 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6466 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6467 * xmenu.c, xselect.c:
6468 Declare Q* vars static if they are not used in other modules.
6469 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6470 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6471 Remove decls of unexported vars.
6472 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6473
95c82688
PE
6474 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6475
16a97296
PE
6476 Make Emacs functions such as Fatom 'static' by default.
6477 This makes it easier for human readers (and static analyzers)
6478 to see whether these functions can be called from other modules.
6479 DEFUN now defines a static function. To make the function external
6480 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6481 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6482 (Finit_image_library):
16a97296
PE
6483 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6484 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6485 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6486 Remove decls, since these functions are now static.
6487 (Funintern, Fget_internal_run_time): New decls, since these functions
6488 were already external.
95c82688 6489
16a97296
PE
6490 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6491 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6492 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6493 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6494 * keyboard.c, keymap.c, lread.c:
6495 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6496 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6497 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6498 Mark functions with DEFUE instead of DEFUN,
6499 if they are used in other modules.
6500 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6501 decls for now-static functions.
6502 * buffer.h (Fdelete_overlay): Remove decl.
6503 * callproc.c (Fgetenv_internal): Mark as internal.
6504 * composite.c (Fremove_list_of_text_properties): Remove decl.
6505 (Fcomposition_get_gstring): New forward static decl.
6506 * composite.h (Fcomposite_get_gstring): Remove decl.
6507 * dired.c (Ffile_attributes): New forward static decl.
6508 * doc.c (Fdocumntation_property): New forward static decl.
6509 * eval.c (Ffetch_bytecode): New forward static decl.
6510 (Funintern): Remove extern decl; now in .h file where it belongs.
6511 * fileio.c (Fmake_symbolic_link): New forward static decl.
6512 * image.c (Finit_image_library): New forward static decl.
6513 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6514 * intervals.h (Fprevious_property_change):
6515 (Fremove_list_of_text_properties): Remove decls.
6516 * keyboard.c (Fthis_command_keys): Remove decl.
6517 (Fcommand_execute): New forward static decl.
6518 * keymap.c (Flookup_key): New forward static decl.
6519 (Fcopy_keymap): Now static.
6520 * keymap.h (Flookup_key): Remove decl.
6521 * process.c (Fget_process): New forward static decl.
6522 (Fprocess_datagram_address): Mark as internal.
6523 * syntax.c (Fsyntax_table_p): New forward static decl.
6524 (skip_chars): Remove duplicate decl.
6525 * textprop.c (Fprevious_property_change): New forward static decl.
6526 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6527 Now internal.
6528 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6529 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6530
785bbd42
PE
6531 * editfns.c (Fformat): Remove unreachable code.
6532
8b913b57
AS
65332011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6534
6535 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6536 change. (Bug#8496)
6537
a6744a35
EZ
65382011-04-13 Eli Zaretskii <eliz@gnu.org>
6539
6540 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6541 when at ZV. (Bug#8487)
6542
e7974947
AS
65432011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6544
baad03f0
AS
6545 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6546 (Bug#8437)
6547 * keyboard.c (parse_tool_bar_item): Likewise.
6548 * sound.c (sound_cleanup, alsa_close): Likewise.
6549 * termcap.c (tgetent): Likewise.
6550 * xfns.c (x_default_font_parameter): Likewise.
6551 * xsettings.c (read_and_apply_settings): Likewise.
6552
e7974947
AS
6553 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6554 (overrun_check_free): Protoize.
6555
28272684
PE
65562011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6557
6558 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6559 since callers should never pass a negative size.
6560 Change the signature to match that of plain 'read' and 'write'; see
6561 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6562 * lisp.h: Update prototypes of emacs_write and emacs_read.
6563
11997c76
EZ
65642011-04-11 Eli Zaretskii <eliz@gnu.org>
6565
6566 * xdisp.c (redisplay_window): Don't try to determine the character
6567 position of the scroll margin if the window start point w->startp
e896f03c 6568 is outside the buffer's accessible region. (Bug#8468)
11997c76 6569
8a2cbd72
EZ
65702011-04-10 Eli Zaretskii <eliz@gnu.org>
6571
6572 Fix write-region and its subroutines for buffers > 2GB.
6573 * fileio.c (a_write, e_write): Modify declaration of arguments and
6574 local variables to support buffers larger than 2GB.
6575 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6576
6577 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6578 argument, local variables, and return value.
6579
6580 * lisp.h: Update prototypes of emacs_write and emacs_read.
6581
6582 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6583
4073e537 65842011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6585
1ebfdcb6
PE
6586 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6587
b2ded58d
PE
6588 Fix more problems found by GCC 4.6.0's static checks.
6589
7d66342c
PE
6590 * xdisp.c (vmessage): Use a better test for character truncation.
6591
bbf47d44
PE
6592 * charset.c (load_charset_map): <, not <=, for optimization,
6593 and to avoid potential problems with integer overflow.
9248994d 6594 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6595 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6596 * editfns.c (Fformat): Likewise.
1e69125e 6597 * syntax.c (skip_chars): Likewise.
3befa583 6598
e3019616
PE
6599 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6600 This also lets GCC 4.6.0 generate slightly better loop code.
6601
becfa255
PE
6602 * callint.c (Fcall_interactively): <, not <=, for optimization.
6603 (Fcall_interactively): Count the number of arguments produced,
6604 not the number of arguments given. This is simpler and lets GCC
6605 4.6.0 generate slightly better code.
6606
dae0cd48
PE
6607 * ftfont.c: Distingish more carefully between FcChar8 and char.
6608 The previous code passed unsigned char * to a functions like
6609 strlen and xstrcasecmp that expect char *, which does not
6610 conform to the C standard.
6611 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6612 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6613 char * when the C standard requires it.
6614
76032d70
PE
6615 * keyboard.c (read_char): Remove unused var.
6616
eb3f1cc8
PE
6617 * eval.c: Port to Windows vsnprintf (Bug#8435).
6618 Include <limits.h>.
6619 (SIZE_MAX): Define if the headers do not.
6620 (verror): Do not give up if vsnprintf returns a negative count.
6621 Instead, grow the buffer. This ports to Windows vsnprintf, which
6622 does not conform to C99. Problem reported by Eli Zaretskii.
6623 Also, simplify the allocation scheme, by avoiding the need for
6624 calling realloc, and removing the ALLOCATED variable.
6625
70476b54
PE
6626 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6627
12020a9e
PE
6628 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6629 But keep the doprint source code for now, as we might revamp it
6630 and use it again (Bug#8435).
ea6c7ae6
PE
6631 * lisp.h (doprnt): Remove.
6632 * Makefile.in (base_obj): Remove doprnt.o.
6633 * deps.mk (doprnt.o): Remove.
6634
5fdb398c
PE
6635 error: Print 32- and 64-bit integers portably (Bug#8435).
6636 Without this change, on typical 64-bit hosts error ("...%d...", N)
6637 was used to print both 32- and 64-bit integers N, which relied on
6638 undefined behavior.
6639 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6640 New macro.
6641 * lisp.h (error, verror): Mark as printf-like functions.
6642 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6643 Report overflow in size calculations when allocating printf buffer.
6644 Do not truncate output string at its first null byte.
6645 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6646 Truncate the output at a character boundary, since vsnprintf does not
6647 do that.
6648 * charset.c (check_iso_charset_parameter): Convert internal
6649 character to string before calling 'error', since %c now has the
6650 printf meaning.
6651 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6652 overflow when computing char to be passed to 'error'. Do not
6653 pass Lisp_Object to 'error'; pass the integer instead.
6654 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6655 formatted with plain %d.
6656
b189fa66
PE
6657 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6658
bff87ef0
PE
6659 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6660
7e2cac20
PE
6661 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6662
ce4d90b5
PE
6663 * xterm.c (x_catch_errors): Remove duplicate declaration.
6664
266c9547
PE
6665 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6666
79c49ad2
PE
6667 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6668
368f4090
JM
66692011-04-10 Jim Meyering <meyering@redhat.com>
6670
6671 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6672 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6673 return ssize_t not "int", and use size_t as the buffer length.
6674 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6675 * gnutls.h: Update declarations.
6676 * process.c (read_process_output): Use ssize_t, to match.
6677 (send_process): Likewise.
6678
a32d4040
CY
66792011-04-09 Chong Yidong <cyd@stupidchicken.com>
6680
6681 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6682
8546720e 66832011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6684
04f2d78b
CB
6685 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6686 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6687
8546720e
GM
6688 * xterm.c (handle_one_xevent):
6689 * xmenu.c (create_and_show_popup_menu):
6690 * xselect.c (x_decline_selection_request)
6691 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6692
0a2f5c1a 66932011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6694
6695 Fix some uses of `int' instead of EMACS_INT.
6696 * search.c (string_match_1, fast_string_match)
6697 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6698 (scan_buffer, find_next_newline_no_quit)
6699 (find_before_next_newline, search_command, Freplace_match)
6700 (Fmatch_data): Make some `int' variables be EMACS_INT.
6701
6702 * xdisp.c (display_count_lines): 3rd argument and return value now
6703 EMACS_INT. All callers changed.
6704 (pint2hrstr): Last argument is now EMACS_INT.
6705
6706 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6707 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6708 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6709 (decode_coding_utf_16, decode_coding_emacs_mule)
6710 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6711 (decode_coding_ccl, decode_coding_charset)
6712 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6713 (decode_coding_iso_2022, decode_coding_emacs_mule)
6714 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6715 <char_offset, last_offset>: Declare EMACS_INT.
6716 (encode_coding_utf_8, encode_coding_utf_16)
6717 (encode_coding_emacs_mule, encode_invocation_designation)
6718 (encode_designation_at_bol, encode_coding_iso_2022)
6719 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6720 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6721 Declare EMACS_INT.
6722 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6723 (encode_invocation_designation): Last argument P_NCHARS is now
6724 EMACS_INT.
6725 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6726 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6727
6728 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6729 All users changed.
6730
6731 * ccl.c (Fccl_execute_on_string): Declare some variables
6732 EMACS_INT.
6733
8546720e 67342011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6735
6736 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6737
4e19a977
CS
67382011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6739
6740 * process.c (Fformat_network_address): Doc fix.
6741
87302331
R
67422011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6743
6744 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6745
cbb59342
CY
67462011-04-08 Chong Yidong <cyd@stupidchicken.com>
6747
6748 * keyboard.c (read_char): Call Lisp function help-form-show,
6749 instead of using internal_with_output_to_temp_buffer.
6750 (Qhelp_form_show): New var.
e0d38eeb 6751 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6752
6753 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6754
6755 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6756
e67a13ab
CY
67572011-04-06 Chong Yidong <cyd@stupidchicken.com>
6758
04f2d78b
CB
6759 * process.c (Flist_processes): Remove to Lisp.
6760 (list_processes_1): Delete.
e67a13ab 6761
973f782d
EZ
67622011-04-06 Eli Zaretskii <eliz@gnu.org>
6763
7c106b1e
EZ
6764 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6765
973f782d
EZ
6766 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6767
41cf7d1a 67682011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6769
ca23cc88
PE
6770 Fix more problems found by GCC 4.6.0's static checks.
6771
f390e2d5
PE
6772 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6773
42eea0d0
PE
6774 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6775
b69769da 6776 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6777
f9541e84
PE
6778 * xdisp.c (vmessage): Mark as a printf-like function.
6779
13841b55
PE
6780 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6781
c136c10f
PE
6782 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6783
5e2d4a30
PE
6784 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6785 printf-like functions.
6786 (tiff_load): Add casts to remove these marks before passing them
6787 to system-supplied API.
6788
583f48b9
PE
6789 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6790
b25d760e
PE
6791 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6792 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6793 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6794 directly, rather than having caller test rule sign. This avoids
6795 some unnecessary tests.
6796 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6797 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6798 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6799
bc7b6697 6800 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6801 (xfont_open): Avoid unnecessary tests.
bc7b6697 6802
27ccc379
PE
6803 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6804
dcd5c89a
PE
6805 * composite.h, composite.c (composition_gstring_put_cache):
6806 Use EMACS_INT, not int, for length.
6807
b13a45c6
PE
6808 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6809 breaking out part of COMPOSITION_DECODE_RULE.
6810 (COMPOSITION_DECODE_RULE): Use it.
6811 * composite.c (get_composition_id): Remove unused local vars,
6812 by using the new macro.
6813
1e792e4d
PE
6814 * textprop.c (set_text_properties_1): Change while to do-while,
6815 since the condition is always true at first.
6816
dc6c6455 6817 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6818 (interval_deletion_adjustment): Return unsigned value.
6819 All uses changed.
dc6c6455 6820
aba7731a
PE
6821 * process.c (list_processes_1, create_pty, read_process_output):
6822 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6823 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6824 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6825 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6826 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6827
fdfc4bf3
PE
6828 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6829
fca8fe46 6830 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6831 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6832
06a0259a 6833 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6834 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6835 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6836
e7b9e80f
PE
6837 * print.c (print_error_message): Avoid int overflow.
6838
56201685
PE
6839 * font.c (font_list_entities): Redo for clarity,
6840 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6841
78834453 6842 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6843 (font_score): Avoid potential overflow in diff calculation.
78834453 6844
0bc0b309 6845 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6846 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6847
e610eaca
PE
6848 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6849
b895abce
PE
6850 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6851 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6852 can always succeed if overflow has undefined behavior.
6853
1f1d9321 6854 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6855 (wordify): Omit three unnecessary tests.
1f1d9321 6856
c59478bc
PE
6857 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6858 All callers changed. This avoids the need for an unused var.
6859
79b73827
PE
6860 * casefiddle.c (casify_region): Remove var that is set but not used.
6861
a4db5dfe
PE
6862 * dired.c (file_name_completion): Remove var that is set but not used.
6863
43aae36e
PE
6864 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6865
2a47c44d 6866 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6867 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6868
a37c69bf
PE
6869 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6870 Check for integer overflow on size calculations.
6871
328ab8e7
PE
6872 * buffer.c (Fprevious_overlay_change): Remove var that is set
6873 but not used.
6874
e5a2a5cb
PE
6875 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6876 Remove vars that are set but not used.
8d84a6eb 6877 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6878 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6879
a60e5f68
PE
6880 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6881
f661cb61 6882 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6883 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6884
f0397f5a
PE
6885 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6886 that are set but not used.
6887
8664db06 6888 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6889 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6890
6abdaa4a
PE
6891 * xselect.c (x_get_local_selection, x_handle_property_notify):
6892 Remove vars that are set but not used.
6893
0ce7538d 6894 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6895 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6896
9ae848fc
PE
6897 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6898 Remove var that is set but not used.
0b918413
PE
6899 (scroll_bar_windows_size): Now size_t, not int.
6900 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6901 Check for overflow.
9ae848fc 6902
a5a62657
PE
6903 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6904 (map_tty_color) [!defined MSDOS]: Likewise.
6905
5c5cdd39
PE
6906 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6907
66ebf983
PE
6908 * coding.c: Remove vars that are set but not used.
6909 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6910 All callers changed.
6911 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6912 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6913 (decode_coding_charset): Remove vars that are set but not used.
6914
1be4d761
PE
6915 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6916 that is set but not used.
6917
47553fa8
PE
6918 * print.c (print_object): Remove var that is set but not used.
6919
1f7196bf 6920 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6921 The gnulib version avoids calling malloc in the usual case,
6922 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6923 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6924 * filelock.c (current_lock_owner): Likewise.
6925 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6926 * sysdep.c: Include allocator.h, careadlinkat.h.
6927 (emacs_no_realloc_allocator): New static constant.
6928 (emacs_readlink): New function.
fdb61804
PE
6929 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6930 ../lib/careadlinkat.h.
d1fdcab7 6931
f84c17c7
SM
69322011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6933
6934 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6935 first non-nil return value).
6936
ef3862ad
JD
69372011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6938
6939 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6940 if not defined (Bug#8403).
6941
376a7006
JB
69422011-04-02 Juanma Barranquero <lekktu@gmail.com>
6943
6944 * xdisp.c (display_count_lines): Remove parameter `start',
6945 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6946 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6947 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6948 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6949 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6950 and thereabouts. All callers changed.
6951 (get_per_char_metric): Remove parameter `f', unused since
6952 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6953
6ca3801d
JM
69542011-04-02 Jim Meyering <meyering@redhat.com>
6955
6956 do not dereference NULL upon failed strdup
6957 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6958 (ns_get_family): Likewise.
6959
d8e2b5ba
JB
69602011-04-02 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6963
8c74fcbd
JD
69642011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6965
6966 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6967 later (Bug#8403).
6968
7200d79c
SM
69692011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6970
03408648 6971 Add lexical binding.
7200d79c 6972
03408648
SM
6973 * window.c (Ftemp_output_buffer_show): New fun.
6974 (Fsave_window_excursion):
6975 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6976
6977 * lread.c (lisp_file_lexically_bound_p): New function.
6978 (Fload): Bind Qlexical_binding.
6979 (readevalloop): Remove `evalfun' arg.
6980 Bind Qinternal_interpreter_environment.
6981 (Feval_buffer): Bind Qlexical_binding.
6982 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6983 Mark as dynamic.
6984 (syms_of_lread): Declare `lexical-binding'.
6985
6986 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6987
6988 * keyboard.c (eval_dyn): New fun.
6989 (menu_item_eval_property): Use it.
ca105506
SM
6990
6991 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6992
03408648
SM
6993 * fns.c (concat, mapcar1): Accept byte-code-functions.
6994
6995 * eval.c (Fsetq): Handle lexical vars.
6996 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6997 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6998 (FletX, Flet): Obey lexical binding.
6999 (Fcommandp): Handle closures.
7000 (Feval): New `lexical' arg.
7001 (eval_sub): New function extracted from Feval. Use it almost
7002 everywhere where Feval was used. Look up vars in lexical env.
7003 Handle closures.
7004 (Ffunctionp): Move from subr.el.
7005 (Ffuncall): Handle closures.
7006 (apply_lambda): Remove `eval_flags'.
7007 (funcall_lambda): Handle closures and new byte-code-functions.
7008 (Fspecial_variable_p): New function.
7009 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7010 but without exporting it to Lisp.
23aba0ea 7011
23aba0ea 7012 * doc.c (Fdocumentation, store_function_docstring):
03408648 7013 * data.c (Finteractive_form): Handle closures.
23aba0ea 7014
03408648
SM
7015 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7016 interactive spec.
ba83908c 7017
04f2d78b
CB
7018 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7019 New byte-codes.
03408648
SM
7020 (exec_byte_code): New function extracted from Fbyte_code to handle new
7021 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7022
03408648 7023 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7024
03408648 7025 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7026
e2abce01
JB
70272011-03-31 Juanma Barranquero <lekktu@gmail.com>
7028
7029 * xdisp.c (redisplay_internal): Fix prototype.
7030
63696a73 70312011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7032
63696a73 7033 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7034 (try_scrolling): Use it when setting scroll_limit.
7035 Limit scrolling to 100 screen lines.
63696a73
EZ
7036 (redisplay_window): Even when falling back on "recentering",
7037 position point in the window according to scroll-conservatively,
7038 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7039
7040 (try_scrolling): When point is above the window, allow searching
7041 as far as scroll_max, or one screenful, to compute vertical
7042 distance from PT to the scroll margin position. This prevents
7043 try_scrolling from unnecessarily failing when
7044 scroll-conservatively is set to a value slightly larger than the
7045 window height. Clean up the case of PT below the margin at bottom
7046 of window: scroll_max can no longer be INT_MAX. When aggressive
7047 scrolling is in use, don't let point enter the opposite scroll
7048 margin as result of the scroll.
7049 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7050 threshold of 100 lines for never-recentering scrolling.
7051
e4cc2dfc
JB
70522011-03-31 Juanma Barranquero <lekktu@gmail.com>
7053
7054 * dispextern.h (move_it_by_lines):
7055 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7056 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7057 (message_log_check_duplicate): Remove parameters `prev_bol' and
7058 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7059 (redisplay_internal): Remove parameter `preserve_echo_area',
7060 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7061
7062 * indent.c (Fvertical_motion):
7063 * window.c (window_scroll_pixel_based, Frecenter):
7064 Don't pass `need_y_p' to `move_it_by_lines'.
7065
1c470562
SM
70662011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7067
44f230aa
SM
7068 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7069 steal a few bits to be more compact.
7070 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7071 Remove unneeded casts.
7072
1c470562
SM
7073 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7074
888adce9
ZK
70752011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7076
7077 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7078 binding" message (bug#7967).
7079
f838ed7b
PE
70802011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7081
77861b95
PE
7082 Fix more problems found by GCC 4.6.0's static checks.
7083
de6dbc14
PE
7084 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7085 Remove unused local var.
7086
f838ed7b
PE
7087 * editfns.c (Fmessage_box): Remove unused local var.
7088
792c7b2b
PE
7089 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7090 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7091 Omit unused local vars.
c499e557 7092 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7093 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7094 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7095 Omit unused local var.
7096
ba0165e1
PE
7097 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7098 Don't assume string length fits in int.
32ad8845 7099 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7100 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7101
3c59b4c9
PE
7102 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7103 instead of alloca (Bug#8344).
7104
a3eed478 7105 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7106 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7107
eb4d412d
PE
7108 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7109
1658b401
PE
7110 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7111 concerns.
7112
7113 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7114
7115 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7116
9a2c6e05
PE
7117 * keyboard.c (syms_of_keyboard): Use the same style as later
7118 in this function when indexing through an array. This also
7119 works around GCC bug 48267.
7120
03d0a109
PE
7121 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7122
44f730c8
PE
7123 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7124
fe75f926
PE
7125 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7126 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7127
ffa8c828
PE
7128 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7129 This avoids undefined behavior on integer overflow, and is a bit
7130 more convenient anyway since it is compared to a size_t variable.
7131
c5101a77
PE
7132 Variadic C functions now count arguments with size_t, not int.
7133 This avoids an unnecessary limitation on 64-bit machines, which
7134 caused (substring ...) to crash on large vectors (Bug#8344).
7135 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7136 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7137 All variadic functions and their callers changed accordingly.
c5101a77
PE
7138 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7139 * data.c (arith_driver, float_arith_driver): Likewise.
7140 * editfns.c (general_insert_function): Likewise.
7141 * eval.c (struct backtrace.nargs, interactive_p)
7142 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7143 (funcall_lambda, mark_backtrace): Likewise.
7144 * fns.c (concat): Likewise.
7145 * frame.c (x_set_frame_parameters): Likewise.
7146 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7147 0 if not found, not -1. All callers changed.
7148
dd3f25f7
PE
7149 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7150 (stack_copy_size): Now size_t, not int.
7151 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7152
461c2ab9
JB
71532011-03-28 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7156 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7157 All callers changed.
7158
7159 * lisp.h (multibyte_char_to_unibyte):
7160 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7161 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7162 * character.h (CHAR_TO_BYTE8):
7163 * cmds.c (internal_self_insert):
7164 * editfns.c (general_insert_function):
7165 * keymap.c (push_key_description):
7166 * search.c (Freplace_match):
7167 * xdisp.c (message_dolog, set_message_1): All callers changed.
7168
f6d62986
SM
71692011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7170
7171 * keyboard.c (safe_run_hook_funcall): New function.
7172 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7173 don't set the hook to nil, but remove the offending function instead.
7174 (Qcommand_hook_internal): Remove, unused.
7175 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7176 Vcommand_hook_internal.
7177
7178 * eval.c (enum run_hooks_condition): Remove.
7179 (funcall_nil, funcall_not): New functions.
7180 (run_hook_with_args): Call each function through a `funcall' argument.
7181 Remove `cond' argument, now redundant.
7182 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7183 (Frun_hook_with_args_until_failure): Adjust accordingly.
7184 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7185
1db5b1ad
JB
71862011-03-28 Juanma Barranquero <lekktu@gmail.com>
7187
7188 * dispextern.h (string_buffer_position): Remove declaration.
7189
7190 * print.c (strout): Remove parameter `multibyte', unused since
7191 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7192
7193 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7194 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7195 All callers changed.
7196
7197 * w32.c (_wsa_errlist): Use braces for struct initializers.
7198
7199 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7200 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7201 All callers changed.
7202 (string_buffer_position): Likewise. Also, make static (it's never
7203 used outside xdisp.c).
7204 (cursor_row_p): Remove parameter `w', unused since
7205 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7206 (decode_mode_spec): Remove parameter `precision', introduced during
7207 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7208 All callers changed.
7209
5ffb62aa
JD
72102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7211
7212 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7213
461c2ab9 72142011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7215
7216 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7217 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7218 (ns_update_auto_hide_menu_bar): New functions.
7219 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7220 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7221 ns_constrain_all_frames.
7222 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7223 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7224
5c380ffb
JD
72252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7226
7227 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7228
9af30bdf
GM
72292011-03-27 Glenn Morris <rgm@gnu.org>
7230
7231 * syssignal.h: Replace RETSIGTYPE with void.
7232 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7233 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7234 Replace SIGTYPE with void everywhere.
7235 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7236 * s/template.h (SIGTYPE): Remove commented out definition.
7237
e2abce01
JB
72382011-03-26 Eli Zaretskii <eliz@gnu.org>
7239
7240 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7241 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7242
f868cd8a
JB
72432011-03-26 Juanma Barranquero <lekktu@gmail.com>
7244
59eb0929
JB
7245 * w32.c (read_unc_volume): Use parameter `henum', instead of
7246 global variable `wget_enum_handle'.
7247
7248 * keymap.c (describe_vector): Remove parameters `indices' and
7249 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7250 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7251
f868cd8a
JB
7252 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7253
7254 * keyboard.c (timer_check): Remove parameter `do_it_now',
7255 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7256 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7257 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7258
7259 * keyboard.c (read_char):
7260 * w32menu.c (w32_menu_display_help):
7261 * xmenu.c (show_help_event, menu_help_callback):
7262 Adjust calls to `show_help_echo'.
7263
7264 * gtkutil.c (xg_maybe_add_timer):
7265 * keyboard.c (readable_events):
7266 * process.c (wait_reading_process_output):
7267 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7268
7269 * insdel.c (adjust_markers_gap_motion):
7270 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7271 (gap_left, gap_right): Don't call it.
7272
2ecf6fdb
CY
72732011-03-25 Chong Yidong <cyd@stupidchicken.com>
7274
7275 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7276 incurred during fontification.
7277
6b1f9ba4
JB
72782011-03-25 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7281 (DEFVAR_PER_BUFFER): Don't pass it.
7282
7283 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7284 (scrolling_window): Don't pass it.
7285
0f4a96b5
JB
72862011-03-25 Juanma Barranquero <lekktu@gmail.com>
7287
7288 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7289
7290 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7291 and `suffix'.
7292 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7293 of variables specific to SELinux and computation of `encoded_absname'.
7294
7295 * image.c (XPutPixel): Remove unused variable `height'.
7296
7297 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7298
7299 * unexw32.c (get_section_info): Remove unused variable `section'.
7300
7301 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7302 (system_process_attributes): Remove unused variable `sess'.
7303 (sys_read): Remove unused variable `err'.
7304
7305 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7306 (w32_wnd_proc): Remove unused variable `isdead'.
7307 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7308 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7309 (x_create_tip_frame): Remove unused variable `tem'.
7310
7311 * w32inevt.c (w32_console_read_socket):
7312 Remove unused variable `no_events'.
7313
7314 * w32term.c (x_draw_composite_glyph_string_foreground):
7315 Remove unused variable `width'.
7316
1149507c
JB
73172011-03-24 Juanma Barranquero <lekktu@gmail.com>
7318
7319 * w32term.c (x_set_glyph_string_clipping):
7320 Don't pass uninitialized region to CombineRgn.
7321
9c88f339
JB
73222011-03-23 Juanma Barranquero <lekktu@gmail.com>
7323
7324 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7325 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7326 (Fx_close_connection): Remove unused variable `i'.
7327
7328 * w32font.c (w32font_draw): Return number of glyphs.
7329 (w32font_open_internal): Remove unused variable `i'.
7330 (w32font_driver): Add missing initializer.
7331
7332 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7333 (fill_in_menu): Remove unused variable `items_added'.
7334
7335 * w32term.c (last_mouse_press_frame): Remove static global variable.
7336 (w32_clip_to_row): Remove unused variable `f'.
7337 (x_delete_terminal): Remove unused variable `i'.
7338
7339 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7340 (NOTHING): Remove unused static global variable.
7341 (uniscribe_check_otf): Remove unused variable `table'.
7342 (uniscribe_font_driver): Add missing initializers.
7343
dee091a3
JD
73442011-03-23 Julien Danjou <julien@danjou.info>
7345
7346 * term.c (Fsuspend_tty, Fresume_tty):
7347 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7348 * window.c (temp_output_buffer_show):
7349 * insdel.c (signal_before_change):
7350 * frame.c (Fhandle_switch_frame):
7351 * fileio.c (Fdo_auto_save):
7352 * emacs.c (Fkill_emacs):
7353 * editfns.c (save_excursion_restore):
7354 * cmds.c (internal_self_insert):
7355 * callint.c (Fcall_interactively):
7356 * buffer.c (Fkill_all_local_variables):
7357 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7358 Use Frun_hooks.
0f4a96b5 7359 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7360 unconditionnaly since it does the check itself.
7361
2c520ab5 73622011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7363
c9c49752
PE
7364 Fix more problems found by GCC 4.5.2's static checks.
7365
8abc3f12
PE
7366 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7367 the first time through the loop, since we know p0 < p1 then.
7368 This also avoids a gcc -Wstrict-overflow warning.
7369
a2d26660
PE
7370 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7371 leading to a memory leak, possible in functions like
7372 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7373 of objects (Bug#8318).
a2d26660 7374
916c72e9
PE
7375 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7376 that could (at least in theory) be that large.
7377
19ab8a18
PE
7378 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7379 This is less likely to overflow, and avoids undefined behavior if
7380 overflow does occur. All callers changed. Use strtoul to scan
7381 for the unsigned long integer.
b7cbbd6f
PE
7382 (pint2hrstr): Simplify and tune code slightly.
7383 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7384
f0641eff
PE
7385 * scroll.c (do_scrolling): Work around GCC bug 48228.
7386 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7387
7f650bb9
PE
7388 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7389 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7390 (validate_x_resource_name): Simplify count usage.
7391 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7392
37dd57d1
PE
7393 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7394 fail (Bug#8306).
81e56e61 7395
699979fc 7396 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7397
401bf9b4
PE
7398 * process.c (Fmake_network_process): Use socklen_t, not int,
7399 where POSIX says socklen_t is required in portable programs.
7400 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7401 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7402 (Fmake_network_process, server_accept_connection):
7403 (wait_reading_process_output, read_process_output):
7404 Likewise.
7405
b93aacde
PE
7406 * process.c: Rename or move locals to avoid shadowing.
7407 (list_processes_1, Fmake_network_process):
7408 (read_process_output_error_handler, exec_sentinel_error_handler):
7409 Rename or move locals.
4dc343ee 7410 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7411 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7412 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7413 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7414 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7415
af8a867c 7416 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7417 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7418 Include tparam.h instead, since it declares them.
af8a867c
PE
7419 * cm.h (PC): Remove extern decl; tparam.h now does this.
7420 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7421 * terminfo.c: Include tparam.h, to check interfaces.
7422 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7423 (tparam): Adjust signature to match interface in tparam.h;
7424 this removes some undefined behavior. Check that outstring and len
7425 are zero, which they always are with Emacs.
7426 * tparam.h (PC, BC, UP): New extern decls.
7427
0248044d 7428 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7429 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7430
8ff096c1 7431 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7432 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7433 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7434 (ftfont_list): Remove unused local.
49eaafba
PE
7435 (get_adstyle_property, ftfont_pattern_entity):
7436 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7437 Rename locals to avoid shadowing.
8ff096c1 7438
e2be39f6
PE
7439 * xfont.c (xfont_list_family): Mark var as initialized.
7440
c9735e30
PE
7441 * xml.c (make_dom): Now static.
7442
8f5201ae
PE
7443 * composite.c (composition_compute_stop_pos): Rename local to
7444 avoid shadowing.
b246f932
PE
7445 (composition_reseat_it): Remove unused locals.
7446 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7447 (composition_update_it): Mark var as initialized.
11b61122
PE
7448 (find_automatic_composition): Mark vars as initialized,
7449 with a FIXME (Bug#8290).
8f5201ae 7450
760fbc2c
PE
7451 character.h: Rename locals to avoid shadowing.
7452 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7453 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7454 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7455 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7456 to avoid shadowing.
7457
ff08eb85
PE
7458 * textprop.c (property_change_between_p): Remove; unused.
7459
fc7bf025
PE
7460 * intervals.c (interval_start_pos): Now static.
7461
235d7abc
PE
7462 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7463
44f230aa
SM
7464 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7465 Rename locals to avoid shadowing.
3e7d6594 7466
50060332
PE
7467 * sound.c (wav_play, au_play, Fplay_sound_internal):
7468 Fix pointer signedness.
d01f234b 7469 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7470 (wav_play): Initialize a variable to 0, to prevent undefined
7471 behavior (Bug#8278).
50060332 7472
c4fc4e30
PE
7473 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7474
918436ed
PE
7475 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7476
c939f91b
PE
7477 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7478 clobbering (Bug#8298).
b9c7f648
PE
7479 * sysdep.c (sys_subshell): Likewise.
7480 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7481
6bd8c144
PE
7482 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7483 This should get cleaned up, so that child_setup has the
7484 same signature on all platforms.
7485
7710357c 7486 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7487 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7488
c59da222
CY
74892011-03-22 Chong Yidong <cyd@stupidchicken.com>
7490
7491 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7492 not to be necessary, and produces flickering.
7493
66b87493
GM
74942011-03-20 Glenn Morris <rgm@gnu.org>
7495
7496 * config.in: Remove file.
7497
45b6f6d5
JB
74982011-03-20 Juanma Barranquero <lekktu@gmail.com>
7499
7500 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7501 are now in src/globals.h.
7502 (syms_of_minibuf): Remove spurious & from previous change.
7503
3ec03f7e
LL
75042011-03-20 Leo <sdl.web@gmail.com>
7505
7506 * minibuf.c (completing-read-function): New variable.
7507 (completing-read-default): Rename from completing-read.
7508 (completing-read): Call completing-read-function.
7509
b14e3e21
CY
75102011-03-19 Juanma Barranquero <lekktu@gmail.com>
7511
7512 * xfaces.c (Fx_load_color_file):
7513 Read color file from absolute filename (bug#8250).
7514
f2b726e6
JB
75152011-03-19 Juanma Barranquero <lekktu@gmail.com>
7516
7517 * makefile.w32-in: Update dependencies.
7518
09f6ff02
EZ
75192011-03-17 Eli Zaretskii <eliz@gnu.org>
7520
7521 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7522
29a6015a
PE
75232011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7524
a3a6c54e
PE
7525 Fix more problems found by GCC 4.5.2's static checks.
7526
b766f867
PE
7527 * process.c (make_serial_process_unwind, send_process_trap):
7528 (sigchld_handler): Now static.
7529
be02381c
PE
7530 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7531 That way, the code declares only the vars that it needs.
7532 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7533 * s/cygwin.h (PTY_ITERATION): Likewise.
7534 * s/darwin.h (PTY_ITERATION): Likewise.
7535 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7536
57048744
PE
7537 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7538 * process.c (allocate_pty): Don't declare stb unless it's needed.
7539
7914961c 7540 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7541 (CONSTANTLIM): Remove; unused.
7542 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7543 Define only if needed.
7914961c 7544
b3967b18
PE
7545 * unexelf.c (unexec): Name an expression,
7546 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7547 Use a different way to cause a compilation error if anyone uses
7548 n rather than nn, a way that does not involve shadowing.
73366a00 7549 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7550
29a6015a
PE
7551 * deps.mk (unexalpha.o): Remove; unused.
7552
43cfc33e 7553 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7554 * unexec.h: New file.
ce701a33
PE
7555 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7556 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7557 Depend on unexec.h.
7558 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7559 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7560 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7561 Change as necessary to match prototype in unexec.h.
ce701a33 7562
01f44d5a
PE
7563 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7564 shadowing.
4f63c6bb 7565 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7566
a6670b0b
PE
7567 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7568 Rename locals to avoid shadowing.
7569
cef2010d 7570 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7571 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7572
d4d7173a
PE
7573 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7574
f08b802a
PE
7575 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7576 warning when compiling print.c.
7577
3ddb0639
PE
7578 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7579 instead of using an uninitialized var.
5ad03b97 7580 (font_sort_entities): Mark var as initialized.
3ddb0639 7581
170a2692
PE
7582 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7583
e663c700
PE
7584 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7585 pointers to constants.
89bc529a 7586 (font_parse_fcname): Remove unused vars.
7b81e2d0 7587 (font_delete_unmatched): Now static.
ea838e10 7588 (font_get_spec): Remove; unused.
13a547c6
PE
7589 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7590 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7591 Rename or move locals to avoid shadowing.
e663c700 7592
2a80c887 7593 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7594 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7595
1384fa33 7596 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7597 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7598
8b2c52e9
PE
7599 * alloc.c (mark_backtrace): Move decl from here ...
7600 * lisp.h: ... to here, so that it can be checked.
7601
475545b5 7602 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7603 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7604 (lisp_indirect_variable): Name an expression,
7605 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7606 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7607
b1349114 7608 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7609 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7610 Use const pointer when appropriate.
b1349114 7611
a2928364
PE
7612 * lisp.h (get_system_name, get_operating_system_release):
7613 Move decls here, to check interfaces.
7614 * process.c (get_operating_system_release): Move decl to lisp.h.
7615 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7616 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7617 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7618 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7619 (Fformat_time_string, Fencode_time, Finsert_char):
7620 (Ftranslate_region_internal, Fformat):
7621 Rename or remove local vars to avoid shadowing.
9710023e 7622 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7623
a415e694
PE
7624 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7625 avoid shadowing.
7626
8ef4622d
PE
7627 * lisp.h (eassert): Check that the argument compiles, even if
7628 ENABLE_CHECKING is not defined.
7629
946f9a5b
PE
7630 * data.c (Findirect_variable): Name an expression, to avoid
7631 gcc -Wbad-function-cast warning.
112396d6 7632 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7633 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7634 (Fmake_variable_buffer_local, Fmake_local_variable):
7635 Mark variables as initialized.
52746918 7636 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7637
e5aab7e7 7638 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7639 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7640 Rename locals to avoid shadowing.
dff45157
PE
7641 (mark_stack): Move local variables into the #ifdef region where
7642 they're used.
7bc26fdb
PE
7643 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7644 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7645 needed otherwise.
7646 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7647 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7648 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7649
e5aab7e7
PE
7650 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7651 avoids undefined behavior in theory.
7652
4da60324
PE
7653 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7654
88043301
PE
7655 Use functions, not macros, for up- and down-casing (Bug#8254).
7656 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7657 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7658 to use the following functions instead of these macros.
7659 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7660 EMACS_INT, since callers assume the returned value fits in int.
7661 (upcase1): Likewise, for UPCASE_TABLE.
7662 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7663 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7664 the race-condition problem in the old DOWNCASE.
88043301 7665
19ed5445
PE
7666 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7667 Rename locals to avoid shadowing.
7668 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7669 (regex_compile, re_search_2, re_match_2_internal):
7670 Remove unused local vars.
952db0d7
PE
7671 (FREE_VAR): Rewrite so as not to use empty "else",
7672 which gcc can warn about.
da053e48 7673 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7674 (RETALLOC_IF): Define only if needed.
7675 (WORDCHAR_P): Likewise. This one is never needed, but is used
7676 only in a comment talking about a compiler bug, so put inside
7677 the #if 0 of that comment.
7678 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7679 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7680 Remove; unused.
19ed5445 7681
1f3561e4 7682 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7683 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7684 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7685
ded6f8f7
PE
7686 * search.c (simple_search): Remove unused var.
7687
dbd37a95
PE
7688 * dired.c (compile_pattern): Move decl from here ...
7689 * lisp.h: ... to here, so that it can be checked.
7690 (struct re_registers): New forward decl.
7691
7e47afad
PE
7692 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7693
85f24f61
PE
7694 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7695 All uses changed.
7696 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7697 Rename locals to avoid shadowing.
5671df8f 7698 (Fvertical_motion): Mark locals as initialized.
85f24f61 7699
181aa2be 7700 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7701 (casify_region): Mark local as initialized.
181aa2be 7702
930d429c
PE
7703 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7704
7082eac6
PE
7705 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7706 New macros, so that the caller can use some names other than
7707 gcpro1, gcpro2, etc.
7708 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7709 of the new macros.
7710 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7711 argument, for consistency with GCPRO2_VAR, etc: it is now the
7712 prefix of the variable, not the variable itself. All uses
7713 changed.
38b2c076
PE
7714 * dired.c (directory_files_internal, file_name_completion):
7715 Rename locals to avoid shadowing.
7716
15206ed9
PE
7717 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7718 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7719 dired.c's scmp function, had undefined behavior.
7720 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7721 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7722 * buffer.h: ... to here, because these macros use current_buffer,
7723 and the new implementation with inline functions needs to have
7724 current_buffer in scope now, rather than later when the macros
7725 are used.
7726 (downcase, upcase1): New static inline functions.
7727 (DOWNCASE, UPCASE1): Reimplement using these functions.
7728 This avoids undefined behavior in expressions like
7729 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7730 from race conditions in accessing the global variables
7731 case_temp1 and case_temp2.
7732 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7733 * lisp.h (case_temp1, case_temp2): Remove their decls.
7734 * character.h (ASCII_CHAR_P): Move from here ...
7735 * lisp.h: ... to here, so that the inline functions mentioned
7736 above can use them.
7737
4a6bea26
PE
7738 * dired.c (directory_files_internal_unwind): Now static.
7739
f14b7e14
PE
7740 * fileio.c (file_name_as_directory, directory_file_name):
7741 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7742 Now static.
2893f146
PE
7743 (file_name_as_directory): Use const pointers when appropriate.
7744 (Fexpand_file_name): Likewise. In particular, newdir might
7745 point at constant storage, so make it a const pointer.
fd4ead52 7746 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7747 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7748 signedness issues.
f839df0c
PE
7749 (Fset_file_times, Finsert_file_contents, auto_save_error):
7750 Rename locals to avoid shadowing.
f14b7e14 7751
5716756e 7752 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7753 (Ftry_completion, Fall_completions): Rename or remove locals
7754 to avoid shadowing.
5716756e 7755
b4c3046a
PE
7756 * marker.c (bytepos_to_charpos): Remove; unused.
7757
b45db522
PE
7758 * lisp.h (verify_bytepos, count_markers): New decls,
7759 so that gcc does not warn that these functions aren't declared.
7760
85876d07
PE
7761 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7762 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7763 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7764 (copy_text): Remove unused local var.
85876d07 7765
03d78a21 7766 * filelock.c (within_one_second): Now static.
b3dd38ab 7767 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7768
5df8f01b
PE
7769 * buffer.c (fix_overlays_before): Mark locals as initialized.
7770 (fix_start_end_in_overlays): Likewise. This function should be
7771 simplified by using pointers-to-pointers, but that's a different
7772 matter.
b1d876f1 7773 (switch_to_buffer_1): Now static.
8f54f30a
PE
7774 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7775 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7776
a70072c9 7777 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7778 Fix pointer signedness issue.
edced198
PE
7779 (sys_subshell): Mark local as volatile if checking for lint,
7780 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7781 (MAXPATHLEN): Define only if needed.
a70072c9 7782
a0977c44
PE
7783 * process.c (serial_open, serial_configure): Move decls from here ...
7784 * systty.h: ... to here, so that they can be checked.
7785
a884fdcc
PE
7786 * fns.c (get_random, seed_random): Move extern decls from here ...
7787 * lisp.h: ... to here, so that they can be checked.
7788
604efe86 7789 * sysdep.c (reset_io): Now static.
b8950c94 7790 (wait_for_termination_signal): Remove; unused.
604efe86 7791
38fc62d9
PE
7792 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7793 (copy_keymap_item, append_key, push_text_char_description):
7794 Now static.
1004a21a 7795 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7796 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7797 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7798 (describe_map_tree):
7799 Rename locals to avoid shadowing.
38fc62d9 7800
2f2650da
PE
7801 * keyboard.c: Declare functions static if they are not used elsewhere.
7802 (echo_char, echo_dash, cmd_error, top_level_2):
7803 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7804 (read_char, kbd_buffer_get_event, make_lispy_position):
7805 (make_lispy_event, make_lispy_movement, apply_modifiers):
7806 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7807 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7808 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7809 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7810 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7811
a053e86c 7812 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7813 (mark_kboards): Move decl here ...
7814 * alloc.c (mark_kboards): ... from here.
a053e86c 7815
4752793e
PE
7816 * lisp.h (force_auto_save_soon): New decl.
7817
74f10ca7 7818 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7819 (DEFINE_DUMMY_FUNCTION): New macro.
7820 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7821 Use it.
c03cd23f
PE
7822 (main): Add casts to avoid warnings
7823 if GCC considers string literals to be constants.
74f10ca7 7824
022e70d4
PE
7825 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7826
59d6fe83
PE
7827 * dbusbind.c: Pointer signedness fixes.
7828 (xd_signature, xd_append_arg, xd_initialize):
7829 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7830 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7831 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7832 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7833
78320123
PE
7834 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7835 if GCC considers string literals to be constants.
49cebcca 7836 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7837
35ac2a97
SM
78382011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7839
fb103ca9
SM
7840 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7841 (print_preprocess, print_object): New macro to fix last change.
7842
35ac2a97
SM
7843 * print.c (print_preprocess): Don't forget font objects.
7844
62973b41
JB
78452011-03-16 Juanma Barranquero <lekktu@gmail.com>
7846
7847 * emacs.c (USAGE3): Doc fixes.
7848
0e48bb22
AS
78492011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7850
7851 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7852 structure.
7853
7684e57b
JB
78542011-03-14 Juanma Barranquero <lekktu@gmail.com>
7855
7856 * lisp.h (VWindow_system, Qfile_name_history):
7857 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7858 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7859 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7860
7861 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7862 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7863
7864 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7865 * w32console.c (detect_input_pending, read_input_pending)
7866 (encode_terminal_code):
7867 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7868 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7869 (w32_system_caret_y, Qfile_name_history):
7870 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7871 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7872 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7873 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7874 * w32proc.c (Qlocal, report_file_error):
7875 * w32term.c (Vwindow_system, updating_frame):
7876 * w32uniscribe.c (initialized, uniscribe_font_driver):
7877 Remove unneeded extern declarations.
7878
2aa46d6c
CY
78792011-03-14 Chong Yidong <cyd@stupidchicken.com>
7880
c96bbc66 7881 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7882
cffc6f3b
CY
78832011-03-13 Chong Yidong <cyd@stupidchicken.com>
7884
7885 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7886 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7887 These macros can no longer be used for assignment.
7888
44f230aa
SM
7889 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7890 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7891 (record_buffer_markers, fetch_buffer_markers): New functions for
7892 recording and fetching special buffer markers.
7893 (set_buffer_internal_1, set_buffer_temp): Use them.
7894
7895 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7896
7897 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7898
7899 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7900 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7901
7902 * xdisp.c (hscroll_window_tree):
7903 (reconsider_clip_changes): Use PT instead of BUF_PT.
7904
d251f04b
EZ
79052011-03-13 Eli Zaretskii <eliz@gnu.org>
7906
7907 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7908 $(EMACS_ROOT)/lib/intprops.h.
7909
f0c77cd1
PE
79102011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7911
3eca4629
PE
7912 Fix more problems found by GCC 4.5.2's static checks.
7913
7c86ee98
PE
7914 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7915 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7916 (xg_free_frame_widgets): Make it clear that a local variable is
7917 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7918 (gdk_window_get_screen): Make it clear that this macro is needed
7919 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7920 (int_gtk_range_get_value): New function, which avoids a diagnostic
7921 from gcc -Wbad-function-cast.
7922 (xg_set_toolkit_scroll_bar_thumb): Use it.
7923 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7924 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7925 (get_utf8_string, xg_get_file_with_chooser):
7926 Rename locals to avoid shadowing.
7927 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7928
41729b81
PE
7929 * xgselect.c (xg_select): Remove unused var.
7930
f0c77cd1
PE
7931 * image.c (four_corners_best): Mark locals as initialized.
7932 (gif_load): Initialize transparent_p to zero (Bug#8238).
7933 Mark another local as initialized.
ec6cf4c6 7934 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7935
ce0ad53d 7936 * image.c (clear_image_cache): Now static.
d5d5a617 7937 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7938 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7939 (x_edge_detection): Remove unnecessary cast that
7940 gcc -Wbad-function-cast diagnoses.
2037898d 7941 (gif_load): Fix pointer signedness.
6ae141d6
PE
7942 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7943 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7944
33383987 79452011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7946
d32df629
PE
7947 Improve quality of tests for time stamp overflow.
7948 For example, without this patch (encode-time 0 0 0 1 1
7949 1152921504606846976) returns the obviously-bogus value (-948597
7950 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7951 reports time overflow. See
7952 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7953 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7954 * editfns.c: Include limits.h and intprops.h.
7955 (TIME_T_MIN, TIME_T_MAX): New macros.
7956 (time_overflow): Move earlier, to before first use.
7957 (hi_time, lo_time): New functions, for an accurate test for
7958 out-of-range times.
7959 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7960 (Fget_internal_run_time): Don't assume time_t fits in int.
7961 (make_time): Use list2 instead of Fcons twice.
7962 (Fdecode_time): More accurate test for out-of-range times.
7963 (check_tm_member): New function.
7964 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7965 (lisp_time_argument): Don't rely on undefined left-shift and
7966 right-shift behavior when checking for time stamp overflow.
8be6f318 7967
fe31d94c
PE
7968 * editfns.c (time_overflow): New function, refactoring common code.
7969 (Fformat_time_string, Fdecode_time, Fencode_time):
7970 (Fcurrent_time_string): Use it.
7971
8be6f318
PE
7972 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7973 * dired.c (make_time): Move to ...
7974 * editfns.c (make_time): ... here.
7975 * systime.h: Note the move.
7976
09d9db2c 79772011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7978
126bc0dc
YM
7979 * fringe.c (update_window_fringes): Remove unused variables.
7980
c47cbdfd
YM
7981 * unexmacosx.c (copy_data_segment): Also copy __got section.
7982 (Bug#8223)
7983
7ac80be9
EZ
79842011-03-12 Eli Zaretskii <eliz@gnu.org>
7985
c96bbc66 7986 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7987 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7988 Constify `char *' arguments and their references according to
7989 prototypes in tparam.h.
7990
ecb0f94d 7991 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7992
7ac80be9
EZ
7993 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7994 Adapt all references accordingly.
7995
7996 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7997
ef1fd07e
TT
79982011-03-11 Tom Tromey <tromey@redhat.com>
7999
8000 * buffer.c (syms_of_buffer): Remove obsolete comment.
8001
7ef4b50c
EZ
80022011-03-11 Eli Zaretskii <eliz@gnu.org>
8003
8004 * termhooks.h (encode_terminal_code): Declare prototype.
8005
8006 * msdos.c (encode_terminal_code): Don't declare prototype.
8007
8008 * term.c (encode_terminal_code): Now external again, used by
8009 w32console.c and msdos.c.
8010
44f230aa
SM
8011 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8012 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8013
4b1ec863 80142011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8015
1714f52b 8016 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8017
4b1ec863
PE
8018 * fringe.c (update_window_fringes): Mark locals as initialized
8019 (Bug#8227).
8020 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8021
524c7aa6
PE
8022 * alloc.c (mark_fringe_data): Move decl from here ...
8023 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8024 to check its interface.
8025 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8026
a5c0af81 8027 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8028 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8029 (fontset_font): Mark local as initialized.
a9a06e0b 8030 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8031
b4716021
PE
8032 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8033
811e9bac 8034 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8035 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8036 (x_own_selection, Fx_disown_selection_internal): Rename locals
8037 to avoid shadowing.
8038 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8039
7e3ab302
PE
8040 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8041 so that the caller can use some name other than gcpro1.
8042 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8043 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8044 (Fx_backspace_delete_keys_p):
8045 Use them to avoid shadowing, and rename vars to avoid shadowing.
8046 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8047 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8048 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8049 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8050 Remove unused locals.
7e3ab302
PE
8051 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8052 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8053 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8054 macros.
f78faa98 8055
e2b13473
PE
8056 * xterm.h (x_mouse_leave): New decl.
8057
77f23912
PE
8058 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8059 Remove unused functions.
cdf4ba58
PE
8060 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8061 (x_calc_absolute_position): Now static.
7411c686 8062 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8063 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8064 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8065 unless they are used.
38d0b34a
PE
8066 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8067 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8068 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8069 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8070 (x_error_catcher, x_connection_closed, x_error_handler):
8071 (x_error_quitter, xembed_send_message, x_iconify_frame):
8072 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8073 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8074 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8075
44f230aa
SM
8076 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8077 Rename or move locals to avoid shadowing.
6b463e58 8078 (tty_defined_color, merge_face_heights): Now static.
5967d051 8079 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8080 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8081 does not deduce is never used uninitialized.
73719eba
PE
8082 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8083 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8084
426994c3 8085 * terminal.c (store_terminal_param): Now static.
5489860b 8086
032f1620 8087 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8088 (set_frame_menubar): Remove unused local.
d4323972 8089 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8090 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8091 since they might point to immutable storage.
281585b0
PE
8092 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8093 since it's unused otherwise.
032f1620 8094
367c19e5 8095 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8096 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8097 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8098 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8099 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8100 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8101 does not deduce are never used uninitialized.
70739cbe 8102
07b48fa9
PE
8103 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8104
8868a238 8105 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8106 * window.c (window_loop, size_window):
8107 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8108
7e5cf297 8109 * window.c (display_buffer): Now static.
d6550a9f
PE
8110 (size_window): Mark variables that gcc -Wuninitialized
8111 does not deduce are never used uninitialized.
a586633d
PE
8112 * window.h (check_all_windows): New decl, to forestall
8113 gcc -Wmissing-prototypes diagnostic.
5b555da1 8114 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8115
f6095868
PE
8116 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8117 shadowing.
8118 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8119 Include <limits.h>.
8120 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8121 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8122 (load_charset_map): Mark variables that gcc -Wuninitialized
8123 does not deduce are never used uninitialized.
53df7c11 8124 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8125
f38b440c
PE
8126 * coding.c (coding_set_source, coding_set_destination):
8127 Use "else { /* comment */ }" rather than "else /* comment */;"
8128 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8129 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8130 a block, when the outer 'i' will do.
8131 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8132 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8133 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8134 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8135 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8136 Rename locals to avoid shadowing.
8137 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8138 * coding.c (emacs_mule_char, encode_invocation_designation):
8139 Now static, since they're not used elsewhere.
413bb2db 8140 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8141 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8142 (decode_coding_emacs_mule): Mark variables that gcc
8143 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8144 (detect_coding_iso_2022): Initialize a local variable that might
8145 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8146 this initialization is needed. (Bug#8211)
5f58e762
PE
8147 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8148 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8149 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8150 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8151 Remove unused macros.
f38b440c 8152
232b38b9 8153 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8154 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8155 * character.c (string_count_byte8): Likewise.
232b38b9 8156
fb90da1b
PE
8157 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8158 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8159
fb93dbc2
PE
8160 * chartab.c (copy_sub_char_table): Now static, since it's not used
8161 elsewhere.
5c156ace
PE
8162 (sub_char_table_ref_and_range, char_table_ref_and_range):
8163 Rename locals to avoid shadowing.
bbcd0949 8164 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8165
7d3b3862 8166 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8167 (BIDI_BOB): Remove unused macro.
7d3b3862 8168
6be7d3da
PE
8169 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8170 deduce are never used uninitialized.
c2ed9c8b 8171 * term.c (encode_terminal_code): Likewise.
6be7d3da 8172
75f8807f 8173 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8174
50938595
PE
8175 * tparam.h: New file.
8176 * term.c, tparam.h: Include it.
8177 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8178 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8179 Move these decls to tparam.h, and make them agree with what
8180 is actually in tparam.c. The previous trick of using incompatible
8181 decls in different modules does not conform to the C standard.
8182 All callers of tparam changed to use tparam's actual API.
8183 * tparam.c (tparam1, tparam, tgoto):
8184 Use const pointers where appropriate.
8185
fbceeba2
PE
8186 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8187 * cm.h (struct cm): Likewise.
8188 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8189 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8190 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8191 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8192 (turn_on_face, init_tty): Likewise.
8193 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8194
7f3f1250
PE
8195 * term.c (term_mouse_position): Rename local to avoid shadowing.
8196
e6ca6543
PE
8197 * alloc.c (mark_ttys): Move decl from here ...
8198 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8199
c40f8d15
AS
82002011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8201
8202 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8203
cfe0661d
JB
82042011-03-09 Juanma Barranquero <lekktu@gmail.com>
8205
8206 * search.c (compile_pattern_1): Remove argument regp, unused since
8207 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8208 (compile_pattern): Don't pass it.
8209
0afb4571
J
82102011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8211
8212 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8213 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8214 for ! HAVE_GTK3.
8215 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8216
8217 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8218
8219 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8220 gdk_window_get_screen, gdk_window_get_geometry,
8221 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8222 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8223 (xg_get_pixbuf_from_pixmap): New function.
8224 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8225 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8226 Call xg_get_pixbuf_from_pixmap instead of
8227 gdk_pixbuf_get_from_drawable.
8228 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8229 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8230 (xg_check_special_colors): Use GtkStyleContext and its functions
8231 for HAVE_GTK3.
8232 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8233 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8234 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8235 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8236 Call gtk_widget_get_preferred_size.
0afb4571
J
8237 (xg_frame_resized): gdk_window_get_geometry only takes 5
8238 parameters.
44f230aa
SM
8239 (xg_win_to_widget, xg_event_is_for_menubar):
8240 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8241 (xg_set_widget_bg): New function.
8242 (delete_cb): New function.
895009e1 8243 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8244 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8245 (xg_set_background_color): Call xg_set_widget_bg.
8246 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8247 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8248 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8249 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8250 if ! HAVE_GTK3.
8251 (update_frame_tool_bar): Call gtk_widget_hide.
8252 (xg_initialize): Use GDK_KEY_g.
8253
8254 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8255 if ! HAVE_GTK3
8256 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8257
8258 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8259 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8260 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8261
1c2cc4ef
JB
82622011-03-08 Juanma Barranquero <lekktu@gmail.com>
8263
8264 * w32xfns.c (select_palette): Check success of RealizePalette against
8265 GDI_ERROR, not zero.
8266
33383987 8267See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8268
8269;; Local Variables:
8270;; coding: utf-8
aac0c6e3
MR
8271;; End:
8272
33383987 8273 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8274
8275 This file is part of GNU Emacs.
8276
8277 GNU Emacs is free software: you can redistribute it and/or modify
8278 it under the terms of the GNU General Public License as published by
8279 the Free Software Foundation, either version 3 of the License, or
8280 (at your option) any later version.
8281
8282 GNU Emacs is distributed in the hope that it will be useful,
8283 but WITHOUT ANY WARRANTY; without even the implied warranty of
8284 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8285 GNU General Public License for more details.
8286
8287 You should have received a copy of the GNU General Public License
8288 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.