Workaround dumping problem on PaX-enabled Linux kernels
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c71232db
UM
12012-06-03 Ulrich Müller <ulm@gentoo.org>
2
3 * Makefile.in (PAXCTL): Define.
4 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5 binary via PaX flags if the paxctl utility is available.
6 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
7 Restore PaX flags to their default. (Bug#11398)
8
383f7350
CY
92012-06-03 Chong Yidong <cyd@gnu.org>
10
11 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
12 buffer (Bug#11226).
13
5f2c76c6
CY
142012-06-03 Chong Yidong <cyd@gnu.org>
15
16 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
17 (note_mode_line_or_margin_highlight): If there is no help echo,
18 use mode-line-default-help-echo. Handle the case where the mouse
19 position is past the end of the mode line string.
20
21 * buffer.c (buffer_local_value_1): New function, split from
22 Fbuffer_local_value; can return Qunbound.
23 (Fbuffer_local_value): Use it.
24 (Vmode_line_format): Docstring tweaks.
25
773d47f6
PE
262012-06-02 Paul Eggert <eggert@cs.ucla.edu>
27
28 * sysdep.c (system_process_attributes): Improve comment.
29
f2d6a3df
SM
302012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
31
32 * keyboard.c: Export real-this-command to Elisp.
33 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
34 and DEFVAR it. Update all users.
35
63810350
PE
362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
37
7bd5c1f4
PE
38 * minibuf.c (Fassoc_string): Remove duplicate declaration.
39
63810350
PE
40 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
41 Convert pctcpu and pctmem to Lisp float properly.
42 Let the compiler fold better, as 100.0/0x8000 is exact.
43
a2821611
AS
442012-06-02 Andreas Schwab <schwab@linux-m68k.org>
45
46 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
47 cons_block.
48
5fceba1d
PE
492012-06-01 Paul Eggert <eggert@cs.ucla.edu>
50
51 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
52
c98ff5dd
DA
532012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
54
55 For a 'struct window', replace some Lisp_Object fields to
56 bitfields where appropriate, remove unused fields.
57 * window.h (struct window): Remove unused 'last_mark_x' and
58 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
59 change it's type from Lisp_Object to bitfield.
60 Change type of 'force_start', 'optional_new_start',
61 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
62 fields from Lisp_Object to bitfield. Adjust users accordingly.
63
ca34e0be
PE
642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
65
66 Pacify gcc -Wdouble-precision when using Xaw.
67 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
68 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
69 Use 'float' consistently, rather than 'float' in most places
70 and 'double' in a couple of places.
71
efc00ab1 722012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
73
74 * xdisp.c (handle_stop): Detect whether we have overlay strings
75 loaded by testing it->current.overlay_string_index to be
76 non-negative, instead of checking whether n_overlay_strings is
77 positive. (Bug#11587)
78
efc00ab1 792012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
80
81 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
82
83 * doc.c (Fsubstitute_command_keys): Doc fix.
84
efc00ab1 852012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
86
87 * search.c (search_buffer): Remove calls to
88 r_alloc_inhibit_buffer_relocation, as it is now called by
89 maybe_unify_char, which was the cause of relocation of buffer text
90 in bug#11519.
91
efc00ab1 922012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
93
94 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
95 for the duration of call to load_charset, to avoid problems with
96 callers of maybe_unify_char that access buffer text through C
97 pointers.
98
99 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
100 decrement the inhibition flag, instead of just setting or
101 resetting it.
102
ba93a187
PE
1032012-05-31 Paul Eggert <eggert@cs.ucla.edu>
104
105 Remove obsolete '#define static' cruft.
106 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
107 This #undef was "temporary" in 2000; it is no longer needed
108 now that '#define static' has gone away.
109 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
110 (gray_bitmap_bits): Remove; no longer needed.
111 All uses replaced with definiens.
112 * xterm.c: Include "bitmaps/gray.xbm".
113
9e4bf381
PE
1142012-05-30 Paul Eggert <eggert@cs.ucla.edu>
115
116 Clean up __executable_start, monstartup when --enable-profiling.
117 The following changes affect the code only when profiling.
118 * dispnew.c (__executable_start): Rename from safe_bcopy.
119 Define only on platforms that need it.
120 * emacs.c: Include <sys/gmon.h> when profiling.
121 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
122 (__executable_start): Remove decl, since lisp.h does it now.
123 (safe_bcopy): Remove decl; no longer has that name.
124 (main): Coalesce #if into single bit of code, for simplicity.
125 Cast pointers to uintptr_t, since standard libraries want integers
126 and not pointers.
127 * lisp.h (__executable_start): New decl.
128
32d72c2f
GM
1292012-05-31 Glenn Morris <rgm@gnu.org>
130
131 * image.c (Fimagemagick_types): Doc fix.
132
baac5bc7
JM
1332012-05-30 Jim Meyering <meyering@redhat.com>
134
135 * callproc.c (Fcall_process_region): Include directory component
136 in mkstemp error message (Bug#11586).
137
72cb32cf
PE
1382012-05-30 Paul Eggert <eggert@cs.ucla.edu>
139
140 * alloc.c, lisp.h (make_pure_vector): Now static.
141
61b108cc
SM
1422012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
143
144 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
145 Move to byte-run.el.
146 (Fautoload): Do the hash-doc more carefully.
147 * data.c (Fdefalias): Purify definition, except for keymaps.
148 (Qdefun): Move from eval.c.
149 * lisp.h (Qdefun): Remove.
150 * lread.c (read1): Tiny simplification.
151
471fe23d
TN
1522012-05-29 Troels Nielsen <bn.troels@gmail.com>
153
934f3f58 154 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
155 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
156 Bug#9642, but explicitly check that the buffer the overlay would
157 be moved to is live and rearrange lines to make sure that errors
158 will not put the overlay in an inconsistent state.
159 (Fdelete_overlay): Cosmetics.
160
85d0efd1
EZ
1612012-05-28 Eli Zaretskii <eliz@gnu.org>
162
163 * w32term.c (my_bring_window_to_top): New function.
164 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
165 could be different from the original one.
166 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
167 (Bug#11513)
168
169 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
170 by calling BringWindowToTop.
171
172 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
173 (WM_EMACS_END): Increase by one.
174
da92a98c
PE
1752012-05-28 Paul Eggert <eggert@cs.ucla.edu>
176
177 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
178 This avoids undefined behavior that might cause the eassert
179 to not catch an out-of-range value.
180
74d1f848
JB
1812012-05-28 Juanma Barranquero <lekktu@gmail.com>
182
183 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
184 Update dependencies.
185
9e1a06fc
EZ
1862012-05-27 Eli Zaretskii <eliz@gnu.org>
187
188 * bidi.c (bidi_mirror_char): Fix last change.
189
f3dd7312
AS
1902012-05-27 Andreas Schwab <schwab@linux-m68k.org>
191
192 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
193 when referring to sectname field in printf format.
194
81899c91
PE
1952012-05-27 Paul Eggert <eggert@cs.ucla.edu>
196
57b81a9f
PE
197 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
198 Only r_alloc_inhibit_buffer_relocation needed to be added;
199 the others were already declared.
200
81899c91
PE
201 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
202 before checking whether it's out of range. Put the check inside
203 eassert. See
204 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
205
33017faf 2062012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
207
208 * callproc.c (Fcall_process): Restore a line that was accidentally
209 commented out in the 2011-02-13 change (bug#11547).
210
33017faf 2112012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
212
213 * lisp.h [REL_ALLOC]: Add prototypes for external functions
214 defined on ralloc.c.
215
216 * buffer.c [REL_ALLOC]: Remove prototypes of
217 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
218 they are now on lisp.h.
219
220 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
221
222 * search.c (search_buffer): Use it to inhibit relocation of buffer
223 text while re_search_2 is doing its job, because re_search_2 is
224 passed C pointers to buffer text. (Bug#11519)
225
23415acf
EZ
226 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
227 Update value to 24.
228
44e27368
EZ
229 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
230 state after an additional call to move_it_in_display_line_to, keep
231 the values of it->max_ascent and it->max_descent found for the
232 entire line.
233 (pos_visible_p): Revert the comparison against bottom_y to what it
234 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
235 (Bug#11464)
236
c1892f11
PE
2372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
238
239 Fix coding-related core dumps with gcc -ftrapv.
240 The code was computing A - B, where A and B are pointers, and B is
241 random garbage. This can lead to core dumps on platforms that
242 have special pointer registers, and it also leads to core dumps on
243 x86-64 when compiled with gcc -ftrapv. The fix is to compute
244 A - B only when B is initialized properly.
245 * coding.c (coding_set_source, coding_set_destination): Return void.
246 (coding_change_source, coding_change_destinations): New functions,
247 with the old behaviors of coding_set_source and coding_set_destination.
248 All callers that need an offset changed to use these new functions.
249
eb7afdad
GM
2502012-05-26 Glenn Morris <rgm@gnu.org>
251
252 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
253
f12fdf02
EZ
2542012-05-26 Eli Zaretskii <eliz@gnu.org>
255
53a63be6 256 Extend mouse support on W32 text-mode console.
61b108cc
SM
257 * xdisp.c (draw_row_with_mouse_face):
258 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 259
eb3f6f01 260 * w32console.c: Include window.h.
61b108cc
SM
261 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
262 New functions.
eb3f6f01
EZ
263 (initialize_w32_display): Initialize mouse-highlight data.
264
53a63be6
EZ
265 * w32inevt.c: Include termchar.h and window.h.
266 (do_mouse_event): Support mouse-autoselect-window. When the mouse
267 moves, call note_mouse_highlight. If help_echo changed, call
268 gen_help_event to produce help-echo message in the echo area.
269 Call clear_mouse_face if mouse_face_hidden is set in the mouse
270 highlight info.
271
4cfd81f6
PE
2722012-05-26 Paul Eggert <eggert@cs.ucla.edu>
273
274 * lread.c (read1): Simplify slightly to avoid an overflow warning
275 with GCC 4.7.0 on x86-64.
276
4446092a
EZ
2772012-05-26 Eli Zaretskii <eliz@gnu.org>
278
279 * bidi.c (bidi_mirror_char): Revert last change: an int is
280 definitely wide enough here.
281
42b2a986 2822012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 283
42b2a986 284 Fix integer width and related bugs (Bug#9874).
eb106a49 285 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
286 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
287 (string_bytes, check_sblock, allocate_string_data):
288 (compact_small_strings, Fmake_bool_vector, make_string)
289 (make_unibyte_string, make_multibyte_string)
290 (make_string_from_bytes, make_specified_string)
291 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
292 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
293 (mark_vectorlike):
294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
295 (allocate_pseudovector):
296 Use int, not EMACS_INT, where int is wide enough.
297 (inhibit_garbage_collection, Fgarbage_collect):
298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
299 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
300 int might not be wide enough.
301 (bidi_cache_search, bidi_cache_find, bidi_init_it)
302 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
303 (bidi_at_paragraph_end, bidi_find_paragraph_start)
304 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
305 (bidi_level_of_next_char, bidi_move_to_visually_next):
306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
307 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
308 (Fkill_buffer, Fset_buffer_major_mode)
309 (advance_to_char_boundary, Fbuffer_swap_text)
310 (Fset_buffer_multibyte, overlays_at, overlays_in)
311 (overlay_touches_p, struct sortvec, record_overlay_string)
312 (overlay_strings, recenter_overlay_lists)
313 (adjust_overlays_for_insert, adjust_overlays_for_delete)
314 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
315 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
316 (Foverlay_recenter, last_overlay_modification_hooks_used)
317 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
319 (validate_region): Omit unnecessary test for b <= e,
320 since that's guaranteed by the previous test.
d311d28c
PE
321 (adjust_overlays_for_delete): Avoid pos + length overflow.
322 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
323 (report_overlay_modification):
324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
325 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
326 Omit pointer cast, which isn't needed anyway, and doesn't work
327 after the EMACS_INT -> ptrdiff_t change.
02481186 328 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
329 * buffer.h: Adjust decls to match defn changes elsewhere.
330 (struct buffer_text, struct buffer):
331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
332 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
333 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
334 not int, to avoid needless 32-bit limit on 64-bit hosts.
335 (exec_byte_code): Use tighter memory-full test, one that checks
336 for alloca overflow. Don't compute the address of the object just
337 before an array, as that's not portable. Use EMACS_INT, not
338 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
339 * callint.c (Fcall_interactively):
340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
341 * callproc.c (call_process_kill, Fcall_process):
342 Don't assume pid_t fits into an Emacs fixnum.
343 (call_process_cleanup, Fcall_process, child_setup):
344 Don't assume pid_t fits into int.
345 (call_process_cleanup, Fcall_process, delete_temp_file)
346 (Fcall_process_region):
347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
348 (Fcall_process): Simplify handling of volatile integers.
349 Use int, not EMACS_INT, where int will do.
350 * casefiddle.c (casify_object, casify_region, operate_on_word)
351 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
353 (casify_object): Avoid integer overflow when overallocating buffer.
354 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 355 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
356 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
357 * category.h (CATEGORYP): Don't assume arg is nonnegative.
358 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
359 integers are now checked earlier. All uses replaced with XINT.
360 (ccl_driver):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
363 (ccl_driver, Fregister_code_conversion_map):
364 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
365 (resolve_symbol_ccl_program): Check that vector header is in range.
366 Always copy the vector, so that we can check its contents reliably
367 now rather than having to recheck each instruction as it's being
368 executed. Check that vector words fit in 'int'.
369 (ccl_get_compiled_code, Fregister_ccl_program)
370 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
371 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
372 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
373 contents are in range.
374 (Fccl_execute_on_string): Check that status is in range.
375 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
376 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
377 Accept and return EMACS_INT, not int, because callers can pass values
378 out of 'int' range.
379 (c_string_width, strwidth, lisp_string_width, chars_in_text)
380 (multibyte_chars_in_text, parse_str_as_multibyte)
381 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
382 (str_as_unibyte, str_to_unibyte, string_count_byte8)
383 (string_escape_byte8, Fget_byte):
384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 385 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
386 avoid mishandling large integers.
387 * character.h: Adjust decls to match defn changes elsewhere.
388 * charset.c (load_charset_map_from_file, find_charsets_in_text)
389 (Ffind_charset_region):
390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
391 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
392 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 393 Don't assume fixnum fits in int.
d311d28c
PE
394 (load_charset_map_from_vector, Fmap_charset_chars):
395 Remove now-unnecessary CHECK_NATNUMs.
396 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
397 Don't rely on undefined behavior with signed left shift overflow.
398 Don't assume unsigned int fits into fixnum, or that fixnum fits
399 into unsigned int. Don't require max_code to be a valid fixnum;
400 that's not true for gb10830 4-byte on a 32-bit host. Allow
401 invalid_code to be a cons, for the same reason. Require code_offset
402 to be a character. Avoid int overflow if max_char is close
403 to INT_MAX.
404 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
405 this is intended anyway and avoids some undefined behavior.
406 (load_charset_map): Pass unsigned, not int, as 2nd arg of
407 INDEX_TO_CODE_POINT, as that's what it expects.
408 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
409 * charset.h (DECODE_CHAR): Return int, not unsigned;
410 this is what was intended anyway, and it avoids undefined behavior.
411 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
412 integer-overflow issues.
413 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
414 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
415 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
416 * chartab.c (Fmake_char_table, Fset_char_table_range)
417 (uniprop_get_decoder, uniprop_get_encoder):
418 Don't assume fixnum fits in int.
419 * cmds.c (move_point): New function, that does the gist of
420 Fforward_char and Fbackward_char, but does so while checking
421 for integer overflow more accurately.
c96e5d6a 422 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
423 (Fforward_line, Fend_of_line, internal_self_insert)
424 (internal_self_insert):
425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
426 Fix a FIXME, by checking for integer overflow when calculating
427 target_clm and actual_clm.
428 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 429 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
430 (ASSURE_DESTINATION, coding_alloc_by_realloc)
431 (coding_alloc_by_making_gap, alloc_destination)
432 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
433 (encode_coding_utf_16, detect_coding_emacs_mule)
434 (decode_coding_emacs_mule, encode_coding_emacs_mule)
435 (detect_coding_iso_2022, decode_coding_iso_2022)
436 (encode_invocation_designation, encode_designation_at_bol)
437 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
438 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
439 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
440 (encode_coding_ccl, encode_coding_raw_text)
441 (detect_coding_charset, decode_coding_charset)
442 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
443 (produce_composition, produce_charset, produce_annotation)
444 (decode_coding, handle_composition_annotation)
445 (handle_charset_annotation, consume_chars, decode_coding_gap)
446 (decode_coding_object, encode_coding_object, detect_coding_system)
447 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
448 (code_convert_region, code_convert_string)
8f50130c
PE
449 (Fdefine_coding_system_internal)
450 (coding_set_source, coding_set_destination):
d311d28c
PE
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
453 (Fdefine_coding_system_internal):
454 Don't assume fixnums fit in int.
455 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 456 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
457 (Funencodable_char_position, Fcheck_coding_systems_region)
458 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 460 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 461 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 462 Don't access memory outside of the args array.
d311d28c 463 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
464 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
465 result of ENCODE_CHAR.
d311d28c
PE
466 * coding.h: Adjust decls to match defn changes elsewhere.
467 (struct coding_system):
468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
469 * composite.c (get_composition_id, find_composition)
470 (run_composition_function, update_compositions)
471 (compose_text, composition_gstring_put_cache)
472 (composition_gstring_p, composition_gstring_width)
473 (fill_gstring_header, fill_gstring_body, autocmp_chars)
474 (composition_compute_stop_pos, composition_reseat_it)
475 (composition_update_it, struct position_record)
476 (find_automatic_composition, composition_adjust_point)
477 (Fcomposition_get_gstring, Ffind_composition_internal):
478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
479 (update_compositions):
480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
481 * composite.h: Adjust decls to match defn changes elsewhere.
482 (struct composition):
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
485 Do not attempt to compute the address of the object just before a
486 buffer; this is not portable.
487 (Faref, Faset):
488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
489 (Faset): Use int, not EMACS_INT, where int is wide enough.
490 (Fstring_to_number): Don't assume fixnums fit in int.
491 (Frem): Don't assume arg is nonnegative.
492 * dbusbind.c (xd_append_arg): Check for integers out of range.
493 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 494 (extract_signed, extract_unsigned): New functions.
243e0530
PE
495 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
496 (xd_get_connection_references): Return ptrdiff_t, not int.
497 All uses changed.
498 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
499 (xd_read_message_1):
500 Use int, not unsigned, where the dbus API uses int.
501 (Fdbus_message_internal): Don't overflow mtype.
502 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
503 * dired.c (directory_files_internal, file_name_completion, scmp)
504 (file_name_completion_stat):
505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
506 (file_name_completion): Don't overflow matchcount.
507 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
508 * dispextern.h: Adjust decls to match defn changes elsewhere.
509 (struct text_pos, struct glyph, struct bidi_saved_info)
510 (struct bidi_string_data, struct bidi_it, struct composition_it)
511 (struct it):
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 (struct display_pos, struct composition_it, struct it):
514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
515 * dispnew.c (increment_matrix_positions)
516 (increment_row_positions, mode_line_string)
517 (marginal_area_string):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 519 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
521 (duration_to_sec_usec): New function, to check for overflow better.
522 (Fsleep_for, sit_for): Use it.
523 * doc.c (get_doc_string, store_function_docstring):
524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
525 (get_doc_string, Fsnarf_documentation):
526 Use int, not EMACS_INT, where int is wide enough.
527 (get_doc_string):
528 Use SAFE_ALLOCA, not alloca.
529 Check for overflow when converting EMACS_INT to off_t.
530 * doprnt.c (doprnt):
531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
532 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
533 Don't assume uid_t fits into fixnum.
534 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
535 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
536 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
537 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
538 (general_insert_function)
539 (Finsert_char, make_buffer_string, make_buffer_string_both)
540 (update_buffer_properties, Fbuffer_substring)
541 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
542 (Fsubst_char_in_region, check_translation)
543 (Ftranslate_region_internal, save_restriction_restore, Fformat)
544 (transpose_markers, Ftranspose_regions):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 (clip_to_bounds): Move to lisp.h as an inline function).
547 (Fconstrain_to_field): Don't assume integers are nonnegative.
548 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
549 (Fsubst_char_in_region, Fsave_restriction):
550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
551 (Femacs_pid): Don't assume pid_t fits into fixnum.
552 (lo_time): Use int, not EMACS_INT, when int suffices.
553 (lisp_time_argument): Check for usec out of range.
554 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
555 (Fuser_login_name, Fuser_full_name): Signal an error
556 if a uid argument is out of range, rather than relying on
557 undefined behavior.
c8d5c857
PE
558 (Fformat_time_string): Remove now-unnecessary check.
559 lisp_time_argument checks for out-of-range usec now.
243e0530 560 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
561 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
562 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
563 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
564 (init_cmdargs, Fdump_emacs):
565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
566 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
567 the bottom (typically) 32 bits of the fixnum.
568 * eval.c (specpdl_size, call_debugger):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 (when_entered_debugger, Fbacktrace_debug):
571 Don't assume fixnum can fit in int.
572 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
573 the object just before a buffer; this is not portable.
574 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
575 (grow_specpdl, unbind_to):
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
578 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 579 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
580 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
581 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
583 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
584 (a_write, e_write):
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (Fcopy_file, non_regular_nbytes, read_non_regular)
587 (Finsert_file_contents):
588 Use int, not EMACS_INT, where int is wide enough.
589 (READ_BUF_SIZE): Verify that it fits in int.
590 (Finsert_file_contents): Check that counts are in proper range,
591 rather than assuming fixnums fit into ptrdiff_t etc.
592 Don't assume fixnums fit into int.
125b3835 593 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
594 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
595 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
596 (string_char_to_byte, string_byte_to_char)
597 (string_make_multibyte, string_to_multibyte)
598 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
599 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
600 (substring_both, Fdelete, internal_equal, Ffillarray)
601 (Fclear_string, mapcar1)
602 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
603 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
604 (larger_vector, make_hash_table, maybe_resize_hash_table)
605 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
606 (Fmaphash, secure_hash):
607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
608 (concat): Check for string index and length overflow.
609 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
610 (Frequire):
611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
612 (larger_vector): New API (vec, incr_min, size_max) replaces old
613 one (vec, new_size, init). This catches size overflow.
614 INIT was removed because it was always Qnil.
615 All callers changed.
616 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
617 the upper bound on a hash table index size.
618 (make_hash_table, maybe_resize_hash_table): Use it.
619 (secure_hash): Computer start_byte and end_byte only after
620 they're known to be in ptrdiff_t range.
621 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
622 (Ffont_get_glyphs, Ffont_at):
623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
624 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
625 (Flist_fonts, Fopen_font):
626 Don't assume fixnum can fit in int.
627 (check_gstring): Don't assume index can fit in int.
628 (font_match_p): Check that fixnum is a character, not a nonnegative
629 fixnum, since the later code needs to stuff it into an int.
630 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
631 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
632 conversion overflow issues.
633 (Fopen_font): Check for integer out of range.
634 (Ffont_get_glyphs): Don't assume index can fit in int.
635 * font.h: Adjust decls to match defn changes elsewhere.
636 * fontset.c (reorder_font_vector): Redo score calculation to avoid
637 integer overflow.
638 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
639 printmax_t, where ptrdiff_t is wide enough.
640 (Finternal_char_font):
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
642 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
643 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
644 (Fset_frame_position, x_set_frame_parameters)
645 (x_set_line_spacing, x_set_border_width)
646 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
647 Check that fixnums are in proper range for system types.
648 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
650 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
651 Use SAFE_ALLOCA_LISP, not alloca.
652 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
653 intptr_t is wide enough.
654 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
655 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
656 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
657 Check for fixnum out of range.
658 * ftfont.c (ftfont_list): Don't assume index fits in int.
659 Check that fixnums are in proper range for system types.
660 (ftfont_shape_by_flt):
661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
662 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
665 Check that fixnums are in proper range for system types.
666 * gnutls.h: Adjust decls to match defn changes elsewhere.
667 * gtkutil.c (xg_dialog_run):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (update_frame_tool_bar):
670 Check that fixnums are in proper range for system types.
671 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 672 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
673 * indent.c (last_known_column, last_known_column_point):
674 (current_column_bol_cache):
675 (skip_invisible, current_column, check_display_width):
676 (check_display_width, scan_for_column, current_column_1)
677 (Findent_to, Fcurrent_indentation, position_indentation)
678 (indented_beyond_p, Fmove_to_column, compute_motion):
679 (Fcompute_motion, Fvertical_motion):
680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
681 (last_known_column_modified): Use EMACS_INT, not int.
682 (check_display_width):
683 (Fcompute_motion):
684 Check that fixnums and floats are in proper range for system types.
685 (compute_motion): Don't assume index or fixnum fits in int.
686 (compute_motion, Fcompute_motion):
687 Use int, not EMACS_INT, when it is wide enough.
688 (vmotion): Omit local var start_hpos that is always 0; that way
689 we don't need to worry about overflow in expressions involving it.
690 * indent.h: Adjust decls to match defn changes elsewhere.
691 (struct position):
692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
693 Use int, not EMACS_INT, where int is wide enough.
694 Remove unused members ovstring_chars_done and tab_offset;
695 all uses removed.
696 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
697 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
698 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
699 (make_gap, copy_text, insert, insert_and_inherit)
700 (insert_before_markers, insert_before_markers_and_inherit)
701 (insert_1, count_combining_before, count_combining_after)
702 (insert_1_both, insert_from_string)
703 (insert_from_string_before_markers, insert_from_string_1)
704 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
705 (adjust_after_replace, adjust_after_insert, replace_range)
706 (replace_range_2, del_range, del_range_1, del_range_byte)
707 (del_range_both, del_range_2, modify_region)
708 (prepare_to_modify_buffer, signal_before_change)
709 (signal_after_change, Fcombine_after_change_execute):
710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
711 * intervals.c (traverse_intervals, rotate_right, rotate_left)
712 (balance_an_interval, split_interval_right, split_interval_left)
713 (find_interval, next_interval, update_interval)
714 (adjust_intervals_for_insertion, delete_node, delete_interval)
715 (interval_deletion_adjustment, adjust_intervals_for_deletion)
716 (static_offset_intervals, offset_intervals)
717 (merge_interval_right, merge_interval_left, make_new_interval)
718 (graft_intervals_into_buffer, temp_set_point_both)
719 (temp_set_point, set_point, adjust_for_invis_intang)
720 (set_point_both, move_if_not_intangible, get_property_and_range)
721 (get_local_map, copy_intervals, copy_intervals_to_string)
722 (compare_string_intervals, set_intervals_multibyte_1):
723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
724 * intervals.h: Adjust decls to match defn changes elsewhere.
725 (struct interval):
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 * keyboard.c (this_command_key_count, this_single_command_key_start)
728 (before_command_key_count, before_command_echo_length, echo_now)
729 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
730 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
731 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
732 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
734 (last_non_minibuf_size, last_point_position, echo_truncate)
735 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
736 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
737 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
738 (stuff_buffered_input):
739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
740 (last_auto_save, command_loop_1, read_char):
741 Use EMACS_INT, not int, to avoid integer overflow.
742 (record_char): Avoid overflow in total_keys computation.
743 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
744 * keyboard.h: Adjust decls to match defn changes elsewhere.
745 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
746 (Fkey_description, Fdescribe_vector, Flookup_key):
747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
748 (click_position): New function, to check that positions are in range.
749 (Fcurrent_active_maps):
750 (describe_command):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (Faccessible_keymaps, Fkey_description):
753 (preferred_sequence_p):
754 Don't assume fixnum can fit into int.
755 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
756 Check for integer overflow in size calculations.
757 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
758 avoid mishandling large integers.
759 * lisp.h: Adjust decls to match defn changes elsewhere.
760 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
761 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
762 (struct Lisp_Marker):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
765 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
766 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
767 All callers changed.
768 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
769 Assume the arg has valid form, since it always does.
770 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
771 unsigned integer system type.
772 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
773 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
776 (duration_to_sec_usec): New decl.
777 * lread.c (read_from_string_index, read_from_string_index_byte)
778 (read_from_string_limit, readchar, unreadchar, openp)
779 (read_internal_start, read1, oblookup):
780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
781 (Fload, readevalloop, Feval_buffer, Feval_region):
782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
783 (openp): Check for out-of-range argument to 'access'.
784 (read1): Use int, not EMACS_INT, where int is wide enough.
785 Don't assume fixnum fits into int.
6efdadfd 786 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
787 (read_filtered_event): Use duration_to_sec_usec
788 to do proper overflow checking on durations.
d311d28c
PE
789 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
790 in size calculation.
791 (Fexecute_kbd_macro):
792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
794 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
795 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
796 (set_marker_both, set_marker_restricted_both, marker_position)
797 (marker_byte_position, Fbuffer_has_markers_at):
798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
799 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 800 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
801 It now merely ensures that the menu is large enough, without
802 necessarily growing it, as this avoids some integer overflow issues.
803 All callers changed.
804 (keymap_panes, parse_single_submenu, Fx_popup_menu):
805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
806 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
807 Use SAFE_ALLOCA_LISP, not alloca.
808 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
809 to EMACS_INT. Check that fixnums are in proper range for system types.
810 * minibuf.c (minibuf_prompt_width, string_to_object)
811 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
812 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
814 (get_minibuffer, read_minibuf_unwind):
815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
816 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
817 this simplifies overflow checking. All callers changed.
818 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
819 (Ftest_completion):
820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
821 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
822 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
823 Check that fixnums are in proper range for system types.
824 (Fx_create_frame, Fx_show_tip):
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 * nsfont.m (ns_findfonts, nsfont_list_family):
827 Don't assume fixnum fits in long.
828 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
830 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
831 wide enough.
17fdb222 832 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
834 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
835 (PRINTDECLARE, PRINTPREPARE):
836 (strout, print_string):
837 (print, print_preprocess, print_check_string_charset_prop)
838 (print_object):
839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
840 (PRINTDECLARE):
841 (temp_output_buffer_setup, Fprin1_to_string, print_object):
842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
843 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 844 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 845 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
846 (print_error_message): Use SAFE_ALLOCA, not alloca.
847 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
848 (print_depth, new_backquote_output, print_number_index):
849 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
850 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
851 (Fset_process_window_size, Fformat_network_address)
852 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 853 (sigchld_handler):
d311d28c 854 Check that fixnums are in proper range for system types.
d44287d4 855 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
856 Check for process-ids out of pid_t range rather than relying on
857 undefined behavior.
e4d81efc 858 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
859 (Fformat_network_address, read_process_output, send_process)
860 (Fprocess_send_region, status_notify):
861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
862 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
863 (wait_reading_process_output, read_process_output, exec_sentinel):
864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
865 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
866 (Faccept_process_output): Use duration_to_sec_usec to do proper
867 overflow checking on durations.
dde14581
PE
868 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
869 Don't assume pid_t fits in int.
02481186
PE
870 * process.h (struct Lisp_Process): Members tick and update_tick
871 are now of type EMACS_INT, not int.
b62b53e8
PE
872 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
873 configured --with-wide-int.
d311d28c
PE
874 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
875 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
876 * search.c (looking_at_1, string_match_1):
877 (fast_string_match, fast_c_string_match_ignore_case)
878 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
879 (scan_newline, find_before_next_newline, search_command)
880 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
881 (set_search_regs, wordify):
882 (Freplace_match):
883 (Fmatch_data):
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 (string_match_1, search_buffer, set_search_regs):
886 (Fmatch_data):
887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
888 (wordify): Check for overflow in size calculation.
889 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
890 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
891 Check that fixnums are in proper range for system types.
892 * sound.c (struct sound_device)
893 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
895 (Fplay_sound_internal):
896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 897 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
898 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
899 (Fparse_partial_sexp):
900 Don't assume fixnums can fit in int.
901 (struct lisp_parse_state, find_start_pos, find_start_value)
902 (find_start_value_byte, find_start_begv)
903 (update_syntax_table, char_quoted, dec_bytepos)
904 (find_defun_start, prev_char_comend_first, back_comment):
905 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
906 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (Finternal_describe_syntax_value): Check that match_lisp is a
909 character, not an integer, since the code stuffs it into int.
910 (scan_words, scan_sexps_forward):
911 Check that fixnums are in proper range for system types.
912 (Fforward_word):
913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
914 (scan_sexps_forward):
915 Use CHARACTERP, not INTEGERP, since the value must fit into int.
916 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
917 * syntax.h: Adjust decls to match defn changes elsewhere.
918 (struct gl_state_s):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
920 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
921 MOST_POSITIVE_FIXNUM.
d311d28c
PE
922 * sysdep.c (wait_for_termination_1, wait_for_termination)
923 (interruptible_wait_for_termination, mkdir):
924 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
925 (emacs_read, emacs_write):
926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
927 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
928 and double all fit in int.
d311d28c
PE
929 * term.c (set_tty_color_mode):
930 Check that fixnums are in proper range for system types.
931 * termhooks.h (struct input_event):
932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
933 * textprop.c (validate_interval_range, interval_of)
934 (Fadd_text_properties, set_text_properties_1)
935 (Fremove_text_properties, Fremove_list_of_text_properties)
936 (Ftext_property_any, Ftext_property_not_all)
937 (copy_text_properties, text_property_list, extend_property_ranges)
938 (verify_interval_modification):
939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
940 (Fnext_single_char_property_change)
941 (Fprevious_single_char_property_change):
942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
943 (copy_text_properties):
944 Check for integer overflow in index calculation.
d311d28c
PE
945 * undo.c (last_boundary_position, record_point, record_insert)
946 (record_delete, record_marker_adjustment, record_change)
947 (record_property_change):
948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
949 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
951 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
952 (Fx_hide_tip, Fx_file_dialog):
953 * w32menu.c (set_frame_menubar):
954 Use ptrdiff_t, not int, for consistency with rest of code.
955 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
956 (select_window, Fdelete_other_windows_internal)
957 (window_scroll_pixel_based, window_scroll_line_based)
958 (Frecenter, Fset_window_configuration):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
960 (Fset_window_hscroll, run_window_configuration_change_hook)
961 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 962 (Fscroll_other_window, Frecenter):
d311d28c
PE
963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
964 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
965 Don't assume fixnum fits in int.
966 (Fset_window_scroll_bars):
967 Check that fixnums are in proper range for system types.
968 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
969 (string_pos, c_string_pos, number_of_chars, init_iterator)
970 (in_ellipses_for_invisible_text_p, init_from_display_pos)
971 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
972 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
973 (face_before_or_after_it_pos, handle_invisible_prop)
974 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
975 (display_prop_intangible_p, string_buffer_position_lim)
976 (string_buffer_position, handle_composition_prop, load_overlay_strings)
977 (get_overlay_strings_1, get_overlay_strings)
978 (iterate_out_of_display_property, forward_to_next_line_start)
979 (back_to_previous_visible_line_start, reseat, reseat_to_string)
980 (get_next_display_element, set_iterator_to_next)
981 (get_visually_first_element, compute_stop_pos_backwards)
982 (handle_stop_backwards, next_element_from_buffer)
983 (move_it_in_display_line_to, move_it_in_display_line)
984 (move_it_to, move_it_vertically_backward, move_it_by_lines)
985 (add_to_log, message_dolog, message_log_check_duplicate)
986 (message2, message2_nolog, message3, message3_nolog
987 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
988 (current_message_1, truncate_echo_area, truncate_message_1)
989 (set_message, set_message_1, store_mode_line_noprop)
990 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
991 (text_outside_line_unchanged_p, check_point_in_composition)
992 (reconsider_clip_changes)
993 (redisplay_internal, set_cursor_from_row, try_scrolling)
994 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
995 (redisplay_window, find_last_unchanged_at_beg_row)
996 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
997 (trailing_whitespace_p, find_row_edges, display_line)
998 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
999 (display_mode_element, store_mode_line_string)
1000 (pint2str, pint2hrstr, decode_mode_spec)
1001 (display_count_lines, display_string, draw_glyphs)
1002 (x_produce_glyphs, x_insert_glyphs)
1003 (rows_from_pos_range, mouse_face_from_buffer_pos)
1004 (fast_find_string_pos, mouse_face_from_string_pos)
1005 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1007 (safe_call, init_from_display_pos, handle_fontified_prop)
1008 (handle_single_display_spec, load_overlay_strings)
1009 (with_echo_area_buffer, setup_echo_area_for_printing)
1010 (display_echo_area, echo_area_display)
1011 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1012 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1013 (redisplay_window, dump_glyph_row, display_mode_line)
1014 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1015 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1017 (handle_single_display_spec, build_desired_tool_bar_string)
1018 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1019 (get_specified_cursor_type):
1020 Check that fixnums are in proper range for system types.
1021 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1022 (Flookup_image_map):
1023 Don't assume fixnums fit in int.
1024 (compare_overlay_entries):
1025 Avoid mishandling comparisons due to subtraction overflow.
1026 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1027 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1028 (handle_tool_bar_click):
1029 Use int, not unsigned, since we prefer signed and the signedness
1030 doesn't matter here.
1031 (get_next_display_element, next_element_from_display_vector):
1032 Use int, not EMACS_INT, when int is wide enough.
1033 (start_hourglass): Use duration_to_sec_usec to do proper
1034 overflow checking on durations.
1035 * xfaces.c (Fbitmap_spec_p):
1036 Check that fixnums are in proper range for system types.
1037 (compare_fonts_by_sort_order):
1038 Avoid mishandling comparisons due to subtraction overflow.
1039 (Fx_family_fonts, realize_basic_faces):
1040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1041 (Fx_family_fonts):
1042 Don't assume fixnum fits in int.
1043 Use SAFE_ALLOCA_LISP, not alloca.
1044 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1045 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1046 (face_at_buffer_position, face_for_overlay_string)
1047 (face_at_string_position):
1048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1049 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1050 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1051 (Fx_show_tip):
1052 Check that fixnums are in proper range for system types.
1053 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1054 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1056 (Fx_change_window_property): Don't assume fixnums fit in int.
1057 * xfont.c (xfont_chars_supported):
1058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1059 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1060 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1062 * xml.c (parse_region):
1063 * xrdb.c (magic_file_p):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1065 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1066 (x_get_local_selection, x_reply_selection_request)
1067 (x_handle_selection_request, wait_for_property_change):
1068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1069 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1070 short is wide enough.
1071 (x_send_client_event): Don't assume fixnum fits in int.
1072 * xterm.c (x_x_to_emacs_modifiers):
1073 Don't assume EMACS_INT overflows nicely into int.
1074 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1075 may come from Lisp.
1076 (handle_one_xevent): NATNUMP can eval its arg twice.
1077 (x_connection_closed):
1078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1079 * xterm.h: Adjust decls to match defn changes elsewhere.
1080 (struct scroll_bar): Use struct vectorlike_header
1081 rather than rolling our own approximation.
1082 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1083
c6574eb5
GM
10842012-05-25 Glenn Morris <rgm@gnu.org>
1085
1086 * lisp.mk (lisp): Update for more files being compiled now.
1087
e8d32c7e
SM
10882012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1089
48def666
SM
1090 * lread.c: Remove `read_pure' which makes no difference.
1091 (read_pure): Remove var.
1092 (unreadpure): Remove function.
1093 (readevalloop): Don't call read_list with -1 flag.
1094 (read1, read_vector): Don't test read_pure any more.
1095 (read_list): Simplify.
1096
e8d32c7e
SM
1097 * fileio.c, character.h: Minor style tweaks.
1098
4b2addb7
DA
10992012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1100
1101 * window.h (clip_changed): Remove useless declaration.
1102
584461b2
JB
11032012-05-22 Juanma Barranquero <lekktu@gmail.com>
1104
1105 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1106 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1107
34374650
PE
11082012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 Remove src/m/*.
1111 This directory predates autoconf and is no longer needed nowadays.
1112 Move its few remaining bits of functionality to where they're needed.
1113 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1114 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1115 * m/template.h: Remove.
1116 * Makefile.in (M_FILE): Remove. All uses removed.
1117 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1118 * lisp.h (USE_LSB_TAG):
1119 * mem-limits.h (EXCEEDS_LISP_PTR):
1120 Use VAL_MAX, not VALBITS, in #if.
1121 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1122 (EMACS_UINT): Define unconditionally now.
1123 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1124 (BITS_PER_EMACS_INT): New constants, replacing
1125 what used to be in config.h, but not useful in #if.
1126 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1127 define them any more.
1128 (VAL_MAX): New macro.
1129 (VALMASK): Use it.
1130 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1131 BITS_PER_EMACS_INT, in #if.
1132 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1133 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1134 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1135 * s/ms-w32.h (DATA_START):
1136 Move here from removed file m/intel386.h.
1137 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1138 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1139
261cb4bb
PE
11402012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 Assume C89 or later.
1143 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1144 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1145 (xrealloc):
1146 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1147 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1148 * textprop.c, tparam.c (NULL): Remove.
1149 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1150 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1151 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1152 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1153 * xterm.c (input_signal_count): Assume volatile works.
1154
ff23cd9f
KB
11552012-05-21 Ken Brown <kbrown@cornell.edu>
1156
1157 * xgselect.c (xg_select): Fix first argument in call to 'select'
1158 (bug#11508).
1159
1b170bc6
KB
11602012-05-20 Ken Brown <kbrown@cornell.edu>
1161
1162 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1163 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1164
b2f4d39f
KB
11652012-05-19 Ken Brown <kbrown@cornell.edu>
1166
1167 * xfns.c (x_in_use): Remove `static' qualifier.
1168 * xterm.h (x_in_use): Declare.
1169 * xgselect.c: Include xterm.h.
1170 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1171 and `display_arg' (bug#9754).
1172
003fdae2
PE
11732012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1174
9232a6d9
PE
1175 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1176
003fdae2
PE
1177 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1178 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1179
784b56e2
EZ
11802012-05-18 Eli Zaretskii <eliz@gnu.org>
1181
1182 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1183
1184 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1185 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1186
1187 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1188 reference to image_cache->refcount.
1189 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1190
a0a79cde
JL
11912012-05-17 Juri Linkov <juri@jurta.org>
1192
1193 * search.c (Fword_search_regexp, Fword_search_backward)
1194 (Fword_search_forward, Fword_search_backward_lax)
1195 (Fword_search_forward_lax): Move functions to isearch.el
1196 (bug#10145, bug#11381).
1197
b0572523
PE
11982012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1201
9660f5fc
SM
12022012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1203
1204 * lread.c (init_obarray): Declare Qt and Qnil as special.
1205
4374de83
GM
12062012-05-14 Glenn Morris <rgm@gnu.org>
1207
1208 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1209 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1210
dc44c39a
PE
12112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1212
078c97cb
PE
1213 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1214
dc44c39a
PE
1215 * unexaix.c: Port to more-recent AIX compilers.
1216 (report_error, report_error_1, make_hdr, copy_sym)
1217 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1218 Make arguments const char *, not char *, to avoid violations of C
1219 standard and to fix some AIX warnings reported by Gilles Pion.
1220
e18afed7 12212012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1222
1223 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1224 already have overlays loaded.
1225 (handle_single_display_spec): Before returning without displaying
1226 fringe bitmap, synchronize the bidi iterator with the main display
1227 iterator, by calling iterate_out_of_display_property.
1228 (iterate_out_of_display_property): Detect buffer iteration by
1229 testing that it->string is a Lisp string.
1230 (get_next_display_element): When the current object is exhausted,
1231 and there's something on it->stack, call set_iterator_to_next to
1232 proceed with what's on the stack, instead of returning zero.
1233 (set_iterator_to_next): If called at the end of a Lisp string,
1234 proceed to consider_string_end without incrementing string
1235 position. Don't increment display vector index past the end of
1236 the display vector. (Bug#11417)
c8fb9dc6
EZ
1237 (pos_visible_p): Don't report a position visible when move_it_to
1238 stopped at the last line of window, which happens to be scanned
1239 backwards by the bidi iteration. (Bug#11464)
ac268e67 1240
e18afed7 12412012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1242
1243 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1244 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1245 are on a TTY, and thus unable to display on the fringes.
1246 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1247 so we need to signal to the caller that this is a "replacing"
1248 display spec. This fixes display when the spec is invalid or we
1249 are on a TTY.
1250
e18afed7 12512012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1252
1253 * unexaix.c (make_hdr): Fix typo in prototype.
1254 This bug broke the build on AIX. Problem reported by Gilles Pion.
1255
9d0a235a
MA
12562012-05-14 Michael Albinus <michael.albinus@gmx.de>
1257
1258 * keyboard.c (kbd_buffer_get_event): Read special events also in
1259 batch mode. (Bug#11415)
1260
9e6b06ed
GM
12612012-05-12 Glenn Morris <rgm@gnu.org>
1262
1263 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1264
c1a1d7a3
EZ
12652012-05-12 Eli Zaretskii <eliz@gnu.org>
1266
1267 * lisp.mk (lisp): Add newcomment.elc.
1268
3fe7cdc8
GM
12692012-05-12 Glenn Morris <rgm@gnu.org>
1270
1271 * Makefile.in (MKDIR_P): New, set by configure.
1272 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1273
53f7d2c0
PE
12742012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1275
1276 Remove unused function hourglass_started.
1277 * dispextern.h (hourglass_started):
1278 * w32fns.c (hourglass_started):
1279 * xdisp.c (hourglass_started): Remove.
1280
75aafb17
JB
12812012-05-10 Juanma Barranquero <lekktu@gmail.com>
1282
1283 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1284 Update dependencies.
1285
12959e8e
PE
12862012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1287
97107e2e
PE
1288 * xgselect.c (xg_select): Put maxfds+1 into a var.
1289 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1290
12959e8e
PE
1291 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1292
836d29b3
DA
12932012-05-10 Dave Abrahams <dave@boostpro.com>
1294
1295 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1296 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1297
5cb67954
MA
12982012-05-09 Michael Albinus <michael.albinus@gmx.de>
1299
1300 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1301 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1302 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1303 Initialize xd_registered_buses.
1304
3478ec45
PE
13052012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1306
b263a6b0
PE
1307 Untag more efficiently if USE_LSB_TAG.
1308 This is based on a proposal by YAMAMOTO Mitsuharu in
1309 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1310 For an admittedly artificial (nth 8000 longlist) benchmark on
1311 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1312 Emacs's overall text size by 1%.
1313 * lisp.h (XUNTAG): New macro.
1314 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1315 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1316 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1317 * eval.c (Fautoload):
1318 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1319 * frame.h (XFRAME): Use XUNTAG.
1320
3478ec45
PE
1321 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1322 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1323 Remove unportable assumptions about print widths of types like
1324 dbus_uint32_t.
1325 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1326 intptr_t when converting between pointer and integer, to avoid GCC
1327 warnings about wrong width.
1328
666b903b 13292012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1330
1331 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1332 stack for each reader_thread, instead of defaulting to 8MB
1333 determined by the linker. This avoids failures in creating
1334 subprocesses on Windows 7, see the discussion in this thread:
1335 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1336
b120cc17
JC
13372012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1338
1339 Fix up display of the *Minibuf-0* buffer in the mini window.
1340 * keyboard.c (read_char): Don't clear the echo area if there's no
1341 message to clear.
1342 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1343 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1344
9a4b36f8
MA
13452012-05-07 Michael Albinus <michael.albinus@gmx.de>
1346
1347 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1348 batch mode.
1349
e5f9458f
CY
13502012-05-06 Chong Yidong <cyd@gnu.org>
1351
1352 * lisp.mk (lisp): Update.
1353
eceeb5fc 13542012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1355
1356 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1357
71873e2b
SM
13582012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1359
1360 * data.c (PUT_ERROR): New macro.
1361 (syms_of_data): Use it. Add new error type `user-error'.
1362 * undo.c (user_error): New function.
1363 (Fprimitive_undo): Use it.
1364 * print.c (print_error_message): Adjust print style for `user-error'.
1365 * keyboard.c (user_error): New function.
1366 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1367
ab0fa4e4
PE
13682012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 Do not limit current-time-string to years 1000..9999.
1371 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1372 (Fcurrent_time_string): Support any year that is supported by the
1373 underlying localtime representation. Don't use asctime, as it
1374 has undefined behavior for years outside the range -999..9999.
1375
7ed806a7
PE
13762012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1377
1378 Fix race conditions involving setenv, gmtime, localtime, asctime.
1379 Without this fix, interrupts could mess up code that uses these
1380 nonreentrant functions, since setting TZ invalidates existing
1381 tm_zone or tzname values, and since most of these functions return
1382 pointers to static storage.
1383 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1384 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1385 Grow the critical sections to include not just invoking
1386 localtime/gmtime, but also accessing these functions' results
1387 including their tm_zone values if any, and any related TZ setting.
1388 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1389 so that the struct tm is saved in the critical section.
1390 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1391 motivated by the fact that memory allocation needs to be outside
1392 the critical section.
1393
0c16dfed
DA
13942012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1395
1396 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1397 with RESET_INTERVAL.
1398
1399 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1400 Remove duplicated buffer name initialization.
1401
3f83ace8
JM
14022012-05-02 Jim Meyering <jim@meyering.net>
1403
1404 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1405
c7b8541e
JM
1406 * xfns.c (x_window): Use xstrdup (Bug#11375).
1407
90207a15 14082012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1409
1410 * xdisp.c (pos_visible_p): If already at a newline from the
1411 display string before the 'while' loop, don't walk back the glyphs
1412 from it3.glyph_row. Solves assertion violation when the display
1413 string begins with a newline (egg.el). (Bug#11367)
1414
b593d6a9
AH
14152012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1416
1417 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1418 Move to simple.el.
1419
4737362e
GM
14202012-05-01 Glenn Morris <rgm@gnu.org>
1421
99cf43f9
GM
1422 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1423 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1424 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1425 All were removed before 23.1.
1426
9311dcff
GM
1427 * dispnew.c: Remove HAVE_LIBNCURSES test;
1428 it is always true on relevant platforms.
1429
4d5c6349
GM
1430 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1431 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1432
4737362e
GM
1433 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1434
74dd3a6b
AS
14352012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1436
1437 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1438 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1439 Remove.
1440
13c379ee
PE
14412012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1442
1443 Do not avoid creating empty evaporating overlays (Bug#9642).
1444 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1445 That is, do not delete an evaporating overlay if it becomes
1446 empty after its bounds are adjusted to fit within its buffer.
1447 This fix caused other problems, and I'm reverting it until we get
1448 to the bottom of them.
1449
a8e7d6d7 14502012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1451
1452 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1453
a8e7d6d7 14542012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1455
1456 * xdisp.c (pos_visible_p): If the window start position is beyond
1457 ZV, start the display from buffer beginning. Prevents assertion
1458 violation in init_iterator when the minibuffer window is scrolled
1459 via the scroll bar.
1460
1461 * window.c (window_scroll_pixel_based): Likewise.
1462
a8e7d6d7 14632012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1464
1465 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1466
a8e7d6d7 14672012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1468
1469 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1470 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1471
a8e7d6d7 14722012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1473
b593d6a9
AH
1474 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1475 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1476
1c6900d9
EZ
14772012-04-26 Eli Zaretskii <eliz@gnu.org>
1478
4c3fa1d9
EZ
1479 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1480 display element, check also the underlying string or buffer
1481 character. (Bug#11341)
1482
1c6900d9
EZ
1483 * w32menu.c: Include w32heap.h.
1484 (add_menu_item): If the call to AppendMenuW (via
1485 unicode_append_menu) fails, disable Unicode menus only if we are
1486 running on Windows 9X/Me.
1487
42bf8205
AS
14882012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1489
1490 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1491 (xgetint): Add missing shift for LSB tags.
1492
b1bac16e
MR
14932012-04-24 Martin Rudalics <rudalics@gmx.at>
1494
1495 * keyboard.c (read_char): Don't wipe echo area for select window
1496 events: These might get delayed via `mouse-autoselect-window'
1497 (Bug#11304).
1498
d69621cc
JB
14992012-04-24 Juanma Barranquero <lekktu@gmail.com>
1500
1501 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1502 manipulation of :loaded-from data.
1503
02fd101b
JB
15042012-04-23 Juanma Barranquero <lekktu@gmail.com>
1505
1506 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1507 now a cons (bug#11311).
1508
888bec30
PE
15092012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1510
89a438bd
PE
1511 Do not create empty overlays with the evaporate property (Bug#9642).
1512 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1513 if it becomes empty after its bounds are adjusted to fit within
1514 its buffer. Without this fix, in a nonempty buffer (let ((o
1515 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1516 yields an empty overlay that has the evaporate property, which is
1517 not supposed to happen.
1518
1068fe4d
PE
1519 Fix minor GTK3 problems found by static checking.
1520 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1521 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1522 (struct _EmacsFixedClass, emacs_fixed_get_type):
1523 Move decls here from emacsgtkfixed.h, since they needn't be public.
1524 (emacs_fixed_get_type): Now static.
1525 (emacs_fixed_class_init): Omit unused local.
1526 (emacs_fixed_child_type): Remove; unused.
1527 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1528 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1529 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1530 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1531 (EMACS_FIXED_GET_CLASS): Remove; unused.
1532 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1533
888bec30
PE
1534 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1535 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1536
de85e130
PE
15372012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1538
d0baac98 1539 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1540 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1541 (__malloc_size_t, __malloc_ptrdiff_t):
1542 Remove. All uses removed, replaced by the definiens if needed,
1543 since we can assume C89 or better now.
1544 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1545 (protect_malloc_state, align, get_contiguous_space)
1546 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1547 (malloc_atfork_handler_child, malloc_enable_thread)
1548 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1549 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1550 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1551 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1552 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1553 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1554 Define using prototypes, not old style.
1555 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1556 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1557 (align): Don't assume that signed integer overflow wraps around.
1558 Omit unused local var.
1559 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1560 (_free_internal_nolock, memalign, mallochook, reallochook):
1561 Omit no-longer-needed casts.
1562 (valloc): Use getpagesize, not __getpagesize.
1563 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1564 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1565
de85e130
PE
1566 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1567
dcbf5805
MA
15682012-04-22 Michael Albinus <michael.albinus@gmx.de>
1569
1570 Move functions from C to Lisp. Make non-blocking method calls
1571 the default. Implement further D-Bus standard interfaces.
1572
1573 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1574 (QCdbus_request_name_allow_replacement)
1575 (QCdbus_request_name_replace_existing)
1576 (QCdbus_request_name_do_not_queue)
1577 (QCdbus_request_name_reply_primary_owner)
1578 (QCdbus_request_name_reply_in_queue)
1579 (QCdbus_request_name_reply_exists)
1580 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1581 (QCdbus_registered_serial, QCdbus_registered_method)
1582 (QCdbus_registered_signal): New Lisp objects.
1583 (XD_DEBUG_MESSAGE): Use sizeof.
1584 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1585 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1586 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1587 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1588 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1589 (xd_signature, xd_append_arg): Allow float for integer types.
1590 (xd_get_connection_references): New function.
b593d6a9
AH
1591 (xd_get_connection_address): Rename from xd_initialize.
1592 Return cached address.
dcbf5805
MA
1593 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1594 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1595 level.
1596 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1597 Return number of refcounts.
dcbf5805
MA
1598 (Fdbus_get_unique_name): Make stronger parameter check.
1599 (Fdbus_message_internal): New defun.
1600 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1601 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1602 (Fdbus_send_signal, Fdbus_register_service)
1603 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1604 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1605 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1606 (Vdbus_compiled_version, Vdbus_runtime_version)
1607 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1608 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1609 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1610 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1611 Adapt docstring.
dcbf5805 1612
52828e02
PE
16132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1614
da05bc4c
PE
1615 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1616 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1617 Do not assume ptrdiff_t is the same width as 'int'.
1618
52828e02
PE
1619 * alloc.c: Handle unusual debugging option combinations.
1620 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1621 since the two debugging options are incompatible.
1622 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1623 is defined.
1624 (mem_init, mem_insert, mem_insert_fixup):
1625 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1626 (NEED_MEM_INSERT): Remove; no longer needed.
1627
f01769f9
LL
16282012-04-22 Leo Liu <sdl.web@gmail.com>
1629
1630 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1631
5790543d
PE
16322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 * sysdep.c [__FreeBSD__]: Minor cleanups.
1635 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1636 Use Emacs indenting style more consistently. Avoid some casts.
1637 Use 'double' consistently rather than mixing 'float' and 'double'.
1638
b91b7e4d
EW
16392012-04-21 Eduard Wiebe <usenet@pusto.de>
1640
b593d6a9
AH
1641 * sysdep.c (list_system_processes, system_process_attributes):
1642 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1643
6114eb15
AS
16442012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1645
1646 * lisp.mk (lisp): Update.
1647
2f38dff7
PE
16482012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1651 It is never used otherwise.
1652
4ae29f89
SM
16532012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1654
1655 * print.c (print_preprocess): Only check print_depth if print-circle
1656 is nil.
1657 (print_object): Check for cycles even when print-circle is nil and
1658 print-gensym is t, but only check print_depth if print-circle is nil.
1659
f30d612a
CY
16602012-04-20 Chong Yidong <cyd@gnu.org>
1661
1662 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1663 set the status to "failed" and ensure that sentinel is run.
1664
c07a4c0b 16652012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1666
1667 * process.c (Fset_process_inherit_coding_system_flag)
1668 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1669 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1670
c07a4c0b 16712012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1672
1673 * xdisp.c (string_buffer_position_lim): Limit starting position to
1674 BEGV.
1675 (set_cursor_from_row): If called for a mode-line or header-line
1676 row, return zero immediately.
1677 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1678 farther than the first row after the header line, if any.
1679 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1680 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1681
c07a4c0b 16822012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1683
4ae29f89
SM
1684 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1685 (bug#11238).
ad3a2b41 1686
c07a4c0b 16872012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 16882012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1689
1690 configure: new option --enable-gcc-warnings (Bug#11207)
1691 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1692 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1693 (ALL_CFLAGS): Use new macros rather than old.
1694 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1695 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1696 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1697 -Wunused-result, -Wunused-variable. This should go away once
1698 the Emacs and Gnulib regex code is merged.
1699 (xmalloc, xrealloc): Now static.
1700
aba027e8
PE
17012012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1702
1703 * dired.c (Fsystem_groups): Remove unused local.
1704
e5a36063
GM
17052012-04-17 Glenn Morris <rgm@gnu.org>
1706
1707 * dired.c (Fsystem_users): Doc fix.
1708
316411f0
DA
17092012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1710
1711 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1712 (syms_of_dired): Add them.
1713
9426aba4
PE
17142012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1715
b62a57be
PE
1716 Fix minor alloc.c problems found by static checking.
1717 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1718 New extern decls, to avoid calling undeclared functions.
1719 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1720 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1721 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1722 (NEED_MEM_INSERT): New macro.
1723 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1724 Remove one incorrect comment and fix another.
b62a57be 1725
3539f31f
PE
1726 Fix minor ralloc.c problems found by static checking.
1727 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1728 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1729 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1730 (r_alloc_sbrk): Now static.
1731
a041960a
PE
1732 Improve ralloc.c interface checking.
1733 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1734 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1735 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1736 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1737 [REL_ALLOC]: ... to here, to check interface.
1738 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1739 Remove decls. This fixes an "It stinks!".
1740
9426aba4
PE
1741 * alloc.c (which_symbols): Fix alignment issue / type clash.
1742
d55c12ed
AS
17432012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1744
1745 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1746 (struct Lisp_Misc_Any): Likewise.
1747 (struct Lisp_Free): Likewise.
1748 * alloc.c (union aligned_Lisp_Symbol): Define.
1749 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1750 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1751 (union aligned_Lisp_Misc): Define.
1752 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1753 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1754 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1755
b948ce8b
PE
17562012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1757
1758 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1759 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1760 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1761 * s/netbsd.h, s/sol2-6.h:
1762 Remove definition of GC_MARK_STACK, since the default now works.
1763 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1764 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1765 no longer the default.
1766 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1767
35dc09a1 17682012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1769
35dc09a1
GM
1770 * lread.c (lisp_file_lexically_bound_p):
1771 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1772
35dc09a1
GM
17732012-04-14 Eli Zaretskii <eliz@gnu.org>
1774
1775 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1776 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1777
17782012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1779
1780 * nsterm.m (constrainFrameRect): Always constrain when there is only
1781 one screen (Bug#10962).
1782
bcd86815
KB
17832012-04-13 Ken Brown <kbrown@cornell.edu>
1784
1785 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1786
c25df26e
RT
17872012-04-13 Reuben Thomas <rrt@sc3d.org>
1788
1789 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1790
0fc59f1e
DC
17912012-04-11 Daniel Colascione <dancol@dancol.org>
1792
1793 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1794 against is gone. It's better to use vfork now so that when Cygwin
1795 gains a new, working vfork, we use it automatically (bug#10398).
1796
de8c03dc
SM
17972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1798
1799 * window.c (save_window_save): Obey window-point-insertion-type.
1800
2f097256
GM
18012012-04-11 Glenn Morris <rgm@gnu.org>
1802
1803 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1804
453b951e
SM
18052012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1806
1807 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1808
75f1671a 18092012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1810
1811 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1812 (force_quit_count): New var.
1813 (handle_interrupt): Use it.
1814
2a8ce227
JB
18152012-04-10 Juanma Barranquero <lekktu@gmail.com>
1816
1817 * w32.c (w32_delayed_load): Record the full path of the library
1818 being loaded (bug#10424).
1819
935396c0
GM
18202012-04-09 Glenn Morris <rgm@gnu.org>
1821
05920a43
GM
1822 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1823 not just in the obarray, before snarfing them. (Bug#11036)
1824
935396c0
GM
1825 * Makefile.in ($(leimdir)/leim-list.el):
1826 Pass EMACS rather than BUILT_EMACS.
1827
a18ecafa
TZ
18282012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1829
1830 * process.c (make_process):
1831 * process.h: Add integer `gnutls_handshakes_tried' member to
1832 process struct.
1833
6bbef4e5
JC
1834 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1835 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1836
1837 * gnutls.c (gnutls_log_function2i): Convenience log function.
1838 (emacs_gnutls_read): Use new log functions,
1839 `gnutls_handshakes_tried' process member, and
1840 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1841 attempts per process (connection).
1842
b4d3bc10
CY
18432012-04-09 Chong Yidong <cyd@gnu.org>
1844
1845 * eval.c (Fuser_variable_p, user_variable_p_eh)
1846 (lisp_indirect_variable): Functions deleted.
1847 (Fdefvar): Caller changed.
1848
1849 * callint.c (Finteractive, Fcall_interactively):
1850 * minibuf.c (Fread_variable): Callers changed.
1851
70f4d973
EZ
18522012-04-09 Eli Zaretskii <eliz@gnu.org>
1853
1854 * xdisp.c (set_cursor_from_row): If the display string appears in
1855 the buffer at position that is closer to point than the position
1856 after the display string, display the cursor on the first glyph of
1857 the display string. Fixes cursor display when a 'display' text
1858 property immediately follows invisible text. (Bug#11094)
1859
cb3c2e3e
PE
18602012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1861
1862 composite.c: use 'double' consistently
1863 * composite.c (get_composition_id): Use 'double' consistently
1864 instead of converting 'float' to 'double' and vice versa; this is
1865 easier to understand and avoids a GCC warning.
1866
fd06db5d
GM
18672012-04-09 Glenn Morris <rgm@gnu.org>
1868
50fe702a
GM
1869 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1870 preparation for dumping it with emacs. (Bug#4789)
1871 (leimdir): New variable.
1872 ($(leimdir)/leim-list.el): New rule.
1873 (emacs$(EXEEXT)): Depend on leim-list.el.
1874
fd06db5d
GM
1875 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1876 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1877 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1878
55c131ee
AS
18792012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1882 proper alignment.
1883
9209588f
JB
18842012-04-07 Juanma Barranquero <lekktu@gmail.com>
1885
1886 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1887 Remove unused local variable.
1888
e3fb2efb
PE
18892012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1892 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1893 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1894 objects, as mark_maybe_pointer will catch them otherwise.
1895 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1896 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1897
b5385551
PE
18982012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1899
1900 Fix typo that broke non-Windows builds.
1901 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1902
9078ead6
EZ
19032012-04-07 Eli Zaretskii <eliz@gnu.org>
1904
1905 Support building on MS-Windows with libxml2.
1906
1907 * makefile.w32-in (OBJ2): Add xml.$(O).
1908 (GLOBAL_SOURCES): Add xml.c.
1909 ($(BLD)/xml.$(O)): New dependency list.
1910
1911 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1912 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1913 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1914 [!WINDOWSNT]: New macros.
1915 (init_libxml2_functions, libxml2_loaded_p): New functions.
1916 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1917 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1918 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1919 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1920 linked in).
6bbef4e5
JC
1921 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1922 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1923 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1924
1925 * emacs.c: Don't include libxml/parser.h.
1926 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1927 xmlCleanupParser directly.
1928
1929 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1930
3811fdf3
EZ
19312012-04-07 Eli Zaretskii <eliz@gnu.org>
1932
1933 * indent.c (Fvertical_motion): If there is a display string at
1934 point, use it.vpos to compute how many lines to backtrack after
1935 move_it_to point. (Bug#11133)
1936
2f8e16b2
EZ
19372012-04-06 Eli Zaretskii <eliz@gnu.org>
1938
1939 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1940 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1941 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1942 macros related to unification of CJK characters. For the details,
1943 see the discussion following the message here:
1944 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1945
3d439cd1
CY
19462012-04-04 Chong Yidong <cyd@gnu.org>
1947
1948 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1949
8bc53d00
EZ
19502012-04-01 Eli Zaretskii <eliz@gnu.org>
1951
1952 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1953 instead of alloca. (Bug#11138)
1954
3b0512a3
AS
19552012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1956
1957 * w32menu.c (is_simple_dialog): Properly check lisp types.
1958 (Bug#11141)
1959
8427ddd2
EZ
19602012-03-31 Eli Zaretskii <eliz@gnu.org>
1961
979022ef
EZ
1962 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1963 position we get to after a call to move_it_to fails the
1964 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1965 only if we wind up in a string from display property. (Bug#11063)
1966
a6b1c7cc
EZ
1967 * window.c (Fdelete_other_windows_internal): Invalidate the row
1968 and column information about mouse highlight, so that redisplay
1969 restores it after reallocating the glyph matrices. (Bug#7464)
1970
8427ddd2
EZ
1971 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1972 string comes from a `display' text property, use the buffer
1973 position of that property as if we actually saw that position in
1974 the row's glyphs.
697ba24b
EZ
1975 (move_it_by_lines): Remove the assertion that
1976 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1977 violated when there's a before-string at the beginning of a line.
1978 (Bug#11063)
8427ddd2 1979
65a0a738
EZ
19802012-03-30 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (append_space_for_newline): If the default face was
1983 remapped, use the remapped face for the appended newline.
1984 (extend_face_to_end_of_line): Use the remapped default face for
1985 extending the face to the end of the line.
1986 (display_line): Call extend_face_to_end_of_line when the default
1987 face was remapped. (Bug#11068)
1988
581355cc
EZ
19892012-03-29 Eli Zaretskii <eliz@gnu.org>
1990
1991 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1992
e8fc049f
SM
19932012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1994
1995 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1996
4fb9a543
GM
19972012-03-27 Glenn Morris <rgm@gnu.org>
1998
1999 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2000 Doc fixes.
2001
679910f1
KH
20022012-03-26 Kenichi Handa <handa@m17n.org>
2003
2004 * dispextern.h (struct glyph): Fix previous change. Change the
2005 bit length of glyphless.ch to 25 (Bug#11082).
2006
90d49b7f
CY
20072012-03-26 Chong Yidong <cyd@gnu.org>
2008
2009 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2010 (command_loop_1): Use it; inhibit selection update for
2011 handle-select-window too (Bug#8996).
2012
f514f6f0
FP
20132012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2014
e8fc049f 2015 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2016
bf43fa51
KH
20172012-03-25 Kenichi Handa <handa@m17n.org>
2018
2019 * dispextern.h (struct glyph): Change the bit length of
2020 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2021
8a0c01dd
EZ
20222012-03-24 Eli Zaretskii <eliz@gnu.org>
2023
2024 * s/ms-w32.h (tzname): Include time.h before redirecting to
2025 _tzname. Fixes the MSVC build. (Bug#9960)
2026
7d1c3a76
AS
20272012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2028
8ed79523
AS
2029 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2030 characters.
2031
7d1c3a76
AS
2032 * xterm.c (XTread_socket): Only modify handling_signal if
2033 !SYNC_INPUT. (Bug#11080)
2034
e99a9b8b
EZ
20352012-03-23 Eli Zaretskii <eliz@gnu.org>
2036
2037 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2038 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2039 when fetching a multibyte character consumes more bytes than
2040 CHAR_BYTES returns, due to unification of CJK characters in
2041 string_char. (Bug#11073)
2042
5063c0e1
TN
20432012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2044
2045 * process.c (wait_reading_process_output): Handle pty disconnect
2046 by refraining from sending oneself a SIGCHLD (bug#10933).
2047
9f851fbd
CY
20482012-03-22 Chong Yidong <cyd@gnu.org>
2049
2050 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2051
5063c0e1 2052 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2053 Mark string as coming from a prefix property.
2054 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2055 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2056
fb5b8aca
CY
20572012-03-21 Chong Yidong <cyd@gnu.org>
2058
2059 * xfaces.c (Vface_remapping_alist): Doc fix.
2060
62356a1b
EZ
20612012-03-20 Eli Zaretskii <eliz@gnu.org>
2062
2063 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2064 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2065 Doc fixes.
62356a1b 2066
025de85b
CY
20672012-03-20 Chong Yidong <cyd@gnu.org>
2068
2069 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2070 to reflect default non-nil value of redisplay-dont-pause.
2071
4827f94e
KH
20722012-03-19 Kenichi Handa <handa@m17n.org>
2073
2074 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2075 it fit in a valid range (Bug#11003).
2076
e50a24a2
EZ
20772012-03-18 Eli Zaretskii <eliz@gnu.org>
2078
2079 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2080 that is not from display property, accept the row as a "cursor
2081 row" if one of the string's character has a non-nil `cursor'
2082 property. Fixes cursor positioning when there are newlines in
2083 overlay strings, e.g. in icomplete.el. (Bug#11035)
2084
9af5ed87
PE
20852012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2088
d1f55f16
CY
20892012-03-12 Chong Yidong <cyd@gnu.org>
2090
2091 * eval.c (inhibit_lisp_code): Rename from
2092 inhibit_window_configuration_change_hook; move from window.c.
2093
2094 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2095 * window.c (run_window_configuration_change_hook)
2096 (syms_of_window): Callers changed.
2097
66c5eebd
CY
20982012-03-11 Chong Yidong <cyd@gnu.org>
2099
413df973
CY
2100 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2101
66c5eebd
CY
2102 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2103
1de11f56
CY
21042012-03-10 Chong Yidong <cyd@gnu.org>
2105
2106 * frame.c (other_visible_frames): Don't assume the selected frame
2107 is visible (Bug#10955).
2108
cae07000
SM
21092012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2110
2111 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2112
89c94350
JD
21132012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2114
2115 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2116 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2117 zero (Bug#10954).
2118
999dd333
GM
21192012-03-03 Glenn Morris <rgm@gnu.org>
2120
01a6dcc8 2121 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2122
de0100f2
EZ
21232012-03-02 Eli Zaretskii <eliz@gnu.org>
2124
2125 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2126 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2127 (redisplay_window, next_element_from_string): Fix typos in
2128 comments.
3e441275
EZ
2129 (redisplay_window): Pass to move_it_vertically the margin in
2130 pixels, not in screen lines.
de0100f2 2131
96a72ee9
GM
21322012-03-02 Glenn Morris <rgm@gnu.org>
2133
2134 * buffer.c (buffer-list-update-hook): Doc fix.
2135
312508d7
EZ
21362012-02-29 Eli Zaretskii <eliz@gnu.org>
2137
2138 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2139 push_it before setting up the iterator for the first overlay
2140 string, even if we have an empty string loaded.
2141 (next_overlay_string): If there's an empty string on the iterator
2142 stack, pop the stack. (Bug#10903)
2143
27f3c637
PE
21442012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2147 Suggested by Stefan Monnier in
2148 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2149 * alloc.c (widen_to_Lisp_Object): New static function.
2150 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2151 and widening them to Lisp_Objects. This would work even if
2152 USE_LSB_TAG is defined and wide integers are used, which might
2153 happen in a future version of Emacs.
2154
3c9dfce6
CY
21552012-02-25 Chong Yidong <cyd@gnu.org>
2156
fa74b241
CY
2157 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2158 Doc fix.
2159
3c9dfce6
CY
2160 * xselect.c (Fx_selection_exists_p): Doc fix.
2161 (x_clipboard_manager_save_all): Print an informative message
2162 before saving to clipboard manager.
2163
9486df08
CY
21642012-02-24 Chong Yidong <cyd@gnu.org>
2165
2166 * keyboard.c (process_special_events): Handle all X selection
2167 requests in kbd_buffer, not just the next one (Bug#8869).
2168
f01d3321
CY
21692012-02-23 Chong Yidong <cyd@gnu.org>
2170
2171 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2172 call when setting menu-bar-lines and tool-bar-lines parameters.
2173 (unwind_create_frame_1): New helper function.
2174
2175 * window.c (inhibit_window_configuration_change_hook): New var.
2176 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2177 (syms_of_window): Initialize it.
f01d3321 2178
86b847b6
CY
21792012-02-22 Chong Yidong <cyd@gnu.org>
2180
2181 * xterm.c (x_draw_image_relief): Add missing type check for
2182 Vtool_bar_button_margin (Bug#10743).
2183
a59225b1
CY
21842012-02-21 Chong Yidong <cyd@gnu.org>
2185
2186 * fileio.c (Vfile_name_handler_alist): Doc fix.
2187
2188 * buffer.c (Fget_file_buffer): Protect against invalid file
2189 handler return value.
2190
310f5bd4
PE
21912012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2192
cb3a28cc
PE
2193 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2194 when computing $valmask.
2195
310f5bd4
PE
2196 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2197 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2198 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2199 It's useless in that case, and it can cause problems on hosts
2200 that allocate halves of EMACS_INT values separately.
2201 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2202 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2203 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2204 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2205 it avoids undefined behavior on hosts where shifting right by more
2206 than the word width has undefined behavior.
2207
2375c96a
CY
22082012-02-19 Chong Yidong <cyd@gnu.org>
2209
2210 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2211 (Funhandled_file_name_directory, Ffile_name_as_directory)
2212 (Fdirectory_file_name, Fexpand_file_name)
2213 (Fsubstitute_in_file_name): Protect against invalid file handler
2214 return values (Bug#10845).
2215
3eb49e71
EZ
22162012-02-18 Eli Zaretskii <eliz@gnu.org>
2217
2218 * .gdbinit (pitx): Fix incorrect references to fields of the
2219 iterator stack.
2220
7b926f3f
CY
22212012-02-17 Chong Yidong <cyd@gnu.org>
2222
2223 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2224
11273115
PE
22252012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2228 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2229
c3a70e2b
CY
22302012-02-15 Chong Yidong <cyd@gnu.org>
2231
2232 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2233 marked as special. Also, starting docstrings with * is obsolete.
2234
0ca43699
AS
22352012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2236
2237 * gnutls.c (emacs_gnutls_write): Fix last change.
2238
2e8f3c56
LI
22392012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2240
2241 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2242 send_process.
2243
af70074f
SM
22442012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2245
2246 * keymap.c (Fsingle_key_description): Handle char ranges.
2247
95986d52
CY
22482012-02-12 Chong Yidong <cyd@gnu.org>
2249
afd83bd1
CY
2250 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2251 as that creates a dangerous corner case.
2252
95986d52
CY
2253 * window.c (Fdelete_window_internal): Invalidate the mouse
2254 highlight (Bug#9904).
2255
bd7da63e
GM
22562012-02-12 Glenn Morris <rgm@gnu.org>
2257
2258 * xselect.c (Fx_own_selection_internal)
2259 (Fx_get_selection_internal, Fx_disown_selection_internal)
2260 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2261 * nsselect.m (Fx_own_selection_internal)
2262 (Fx_disown_selection_internal, Fx_selection_exists_p)
2263 (Fx_selection_owner_p, Fx_get_selection_internal):
2264 Sync docs and argument specs with the xselect.c versions.
2265
77abcbc2
LI
22662012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2267
2268 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2269
90b671e2
EZ
22702012-02-11 Eli Zaretskii <eliz@gnu.org>
2271
1c0ca0b7
EZ
2272 * w32select.c (Fx_selection_exists_p): Sync doc string and
2273 argument list with xselect.c. (Bug#10783)
2274
2275 * w16select.c (Fx_selection_exists_p): Sync doc string and
2276 argument list with xselect.c. (Bug#10783)
90b671e2 2277
49241268
GM
22782012-02-10 Glenn Morris <rgm@gnu.org>
2279
2280 * fns.c (Fsecure_hash): Doc fix.
2281
f998bbe7 22822012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2283
2284 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2285
0992bd9c
CY
22862012-02-07 Chong Yidong <cyd@gnu.org>
2287
2288 * buffer.c (Fbuffer_local_variables)
2289 (buffer_lisp_local_variables): Handle unbound vars correctly;
2290 don't let Qunbound leak into Lisp.
2291
af008560
GM
22922012-02-07 Glenn Morris <rgm@gnu.org>
2293
dd605cc4
GM
2294 * image.c (Fimagemagick_types): Doc fix.
2295
af008560
GM
2296 * image.c (imagemagick-render-type): Change it from a lisp object
2297 to an integer. Move the doc here from the lisp manual.
2298 Treat all values not equal to 0 the same.
2299
1449fa1d
CY
23002012-02-06 Chong Yidong <cyd@gnu.org>
2301
2302 * doc.c (store_function_docstring): Avoid applying docstring of
2303 alias to base function (Bug#2603).
2304
3723ec07
AS
23052012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2306
2307 * .gdbinit (pp1, pv1): Remove redundant defines.
2308 (pr): Use pp.
2309
79c1cc1e
CY
23102012-02-04 Chong Yidong <cyd@gnu.org>
2311
2312 * nsterm.m: Declare a global (Bug#10694).
2313
d7f29f8e
EZ
23142012-02-04 Eli Zaretskii <eliz@gnu.org>
2315
cae07000
SM
2316 * w32.c (get_emacs_configuration_options):
2317 Include --enable-checking, if specified, in the return value.
d7f29f8e 2318
3b95a6f9
MR
23192012-02-04 Martin Rudalics <rudalics@gmx.at>
2320
2321 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2322 after rounding frame sizes. (Bug#9723)
2323
d6fa96a6
EZ
23242012-02-04 Eli Zaretskii <eliz@gnu.org>
2325
2326 * keyboard.c (adjust_point_for_property): Don't position point
2327 before BEGV. (Bug#10696)
2328
df0b2940
PE
23292012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Handle overflow when computing char display width (Bug#9496).
2332 * character.c (char_width): Return EMACS_INT, not int.
2333 (char_width, c_string_width): Check for overflow when
2334 computing the width; this is possible now that individual
2335 characters can have unbounded width. Problem introduced
2336 by merge from Emacs 23 on 2012-01-19.
2337
6bee44d6
MA
23382012-02-02 Michael Albinus <michael.albinus@gmx.de>
2339
2340 * dbusbind.c (Fdbus_register_method): Mention the return value
2341 :ignore in the docstring.
2342
44f92739
GM
23432012-02-02 Glenn Morris <rgm@gnu.org>
2344
1b9f60cc
GM
2345 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2346
44f92739
GM
2347 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2348 Unconditionally set to t. (Bug#10673)
2349 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2350 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2351 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2352
c5d3843c
KH
23532012-02-02 Kenichi Handa <handa@m17n.org>
2354
2355 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2356 0, do not call append_composite_glyph.
2357
159462d4 23582012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2359
2360 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2361 NULL (Bug#6988).
2362 (x_produce_glyphs): If the component of a composition is a null
2363 string, set it->pixel_width to 1 to avoid zero-width glyph.
2364
78cef877
EZ
23652012-02-01 Eli Zaretskii <eliz@gnu.org>
2366
2367 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2368 first 2 arguments are identical. This makes inserting large
2369 output from a subprocess an order of magnitude faster on
2370 MS-Windows, where all sbrk'ed memory is always contiguous.
2371
97897668
GM
23722012-01-31 Glenn Morris <rgm@gnu.org>
2373
2374 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2375 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2376 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2377
31fd3586
GM
23782012-01-29 Glenn Morris <rgm@gnu.org>
2379
2380 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2381
0e24a8b2
CY
23822012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2383
2384 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2385
cc0adcb0
CY
23862012-01-28 Chong Yidong <cyd@gnu.org>
2387
2388 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2389
acc28cb9
CY
23902012-01-26 Chong Yidong <cyd@gnu.org>
2391
9c69cfb7
CY
2392 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2393
acc28cb9
CY
2394 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2395 repeat counts (Bug#10507).
2396
48da7392
GM
23972012-01-26 Glenn Morris <rgm@gnu.org>
2398
2399 * lread.c (syms_of_lread): Doc fix.
2400
14af5f7f
CY
24012012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2402
2403 * coding.c (encode_designation_at_bol): Change return value to
2404 EMACS_INT.
2405
0b21c100
CY
24062012-01-25 Chong Yidong <cyd@gnu.org>
2407
2408 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2409
3c2907f7
CY
24102012-01-21 Chong Yidong <cyd@gnu.org>
2411
2412 * floatfns.c (Fcopysign): Make the second argument non-optional,
2413 since nil is not allowed anyway.
2414
959ad23f
AS
24152012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2416
2417 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2418 (send_process): Likewise.
2419
34a02f46
MR
24202012-01-19 Martin Rudalics <rudalics@gmx.at>
2421
2422 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2423 (Vwindow_persistent_parameters): Do not use Qstate.
2424 Rewrite doc-strings.
34a02f46 2425
1259009a 24262012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2427
2428 * character.c (char_width): New function.
70d4fdf6
GM
2429 (Fchar_width, c_string_width, lisp_string_width):
2430 Use char_width (Bug#9496).
25ed9e61 2431
6a6ee00d
MR
24322012-01-16 Martin Rudalics <rudalics@gmx.at>
2433
2434 * window.c (Vwindow_persistent_parameters): New variable.
2435 (Fset_window_configuration, save_window_save): Handle persistent
2436 window parameters.
2437
c85efaf7
EZ
24382012-01-14 Eli Zaretskii <eliz@gnu.org>
2439
2440 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2441 thrashing the stack of the thread. (Bug#9087)
2442
5944709e
PE
24432012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2446
e71f5d99
EZ
24472012-01-11 Eli Zaretskii <eliz@gnu.org>
2448
2449 * xdisp.c (rows_from_pos_range): Handle the case where the
2450 highlight ends on a newline. (Bug#10464)
2451 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2452 he end column for display of highlight that ends on a newline
2453 before a R2L line.
2454
ce316182
GM
24552012-01-11 Glenn Morris <rgm@gnu.org>
2456
2457 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2458 from load-path also when installation-directory is nil. (Bug#10208)
2459
5b43da69
GM
24602012-01-10 Glenn Morris <rgm@gnu.org>
2461
74cc8ff9
GM
2462 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2463
7d8d6e4e
GM
2464 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2465 Update template values to be closer to their typical values these days.
5b43da69 2466
a0db8d43
EZ
24672012-01-09 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xdisp.c (rows_from_pos_range): Accept additional argument
2470 DISP_STRING, and accept any glyph in a row whose object is that
2471 string as eligible for mouse highlight. Fixes mouse highlight of
2472 display strings from overlays. (Bug#10464)
2473
9a0115ab 24742012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2475
b9110d6a 2476 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2477 * fileio.c (auto_saving_dir_umask): New static var.
2478 (Fmake_directory_internal): Use it.
2479 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2480 creating the directory. The old code temporarily assigns
2481 too-generous permissions to the directory.
2482 (do_auto_save_eh): Clear it.
b9110d6a 2483 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2484 that the var is always cleared.
2485
6c1bd3f3
EZ
24862012-01-07 Eli Zaretskii <eliz@gnu.org>
2487
2488 * search.c (scan_buffer): Pass character positions to
2489 know_region_cache, not byte positions. (Bug#6540)
2490
069d2b50
L
24912012-01-07 LynX <_LynX@bk.ru> (tiny change)
2492
2493 * w32.c (sys_rename): Report EXDEV when rename of a directory
2494 fails because the target is on another logical disk. (Bug#10284)
2495
75bf0d33
DB
24962012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2497
2498 * xterm.c (x_embed_request_focus): New function.
2499
2500 * xterm.h: Add prototype.
2501
2502 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2503
1c6e5a32
GM
25042012-01-05 Glenn Morris <rgm@gnu.org>
2505
2506 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2507
651e947e
EZ
25082012-01-01 Eli Zaretskii <eliz@gnu.org>
2509
2510 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2511 Load gnutls_transport_set_lowat only if GnuTLS version is below
2512 2.11.1.
2513 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2514 GnuTLS versions below 2.11.1.
2515
3778cdd8
AL
25162011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2517
2518 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2519 to the doc string advising against its use for altering the way
2520 windows are scrolled.
2521
0e5317f7
KH
25222011-12-28 Kenichi Handa <handa@m17n.org>
2523
2524 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2525 coding-system ASCII compatible only when it does not produce BOM
2526 on encoding (Bug#10383).
2527
93d5ca1f
JD
25282011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2529
2530 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2531 can scroll.
2532 (create_and_show_popup_menu): Always use menu_position_func for
2533 Gtk3 (Bug#10361).
2534
ca22b785
AS
25352011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2536
2537 * callint.c (Fcall_interactively): Don't truncate prompt string.
2538
d048e1e6
EZ
25392011-12-23 Eli Zaretskii <eliz@gnu.org>
2540
2541 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2542 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2543 resumed from there (after widening). (Bug#10360)
d048e1e6 2544
5ccaba1f
JD
25452011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2546
2547 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2548
204ee57f
JD
25492011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2550
b81d40f0
JB
2551 * nsterm.m (x_free_frame_resources):
2552 Release f->output_data.ns->miniimage.
204ee57f
JD
2553 (ns_index_color): Fix indentation. Do not retain
2554 color_table->colors[i].
2555
2556 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2557 before returning.
2558
2559 * nsfns.m (x_set_background_color): Assign return value from
2560 ns_index_color to face-background instead of NSColor*.
2561 (ns_implicitly_set_icon_type): Fix indentation.
2562 Change assignment in for loop to comparison.
2563
2564 * emacs.c (ns_pool): New variable.
2565 (main): Assign ns_pool.
2566 (Fkill_emacs): Call ns_release_autorelease_pool.
2567
2568 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2569 autorelease fdesc, release fdAttrs and tdict.
2570 (ns_get_covering_families): Release charset.
2571 (ns_findfonts): Release NSFontDescriptor created with new.
2572 (ns_uni_to_glyphs): Fix indentation.
2573 (setString): Release attrStr before assigning new value.
2574
c803b2b7
JD
25752011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2576
678f4426
JD
2577 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2578 and NS_IMPL_COCOA.
2579 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2580 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2581
cd394be1 25822011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2583
5fecd5fc
JD
2584 * nsterm.m (ns_term_init): Subscribe for notifications
2585 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2586 to method trackingNotification in EmacsMenu.
2587
2588 * nsmenu.m (trackingMenu): New variable.
3771cb17 2589 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2590 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2591 from Aquamacs (Bug#7030).
678f4426
JD
2592
25932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2594
c803b2b7
JD
2595 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2596 (symbol_to_nsstring): Fix indentation.
2597 (ns_symbol_to_pb): New function.
cae07000
SM
2598 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2599 (Fns_rotate_cut_buffers_internal): Remove.
2600 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2601 Fns_store_cut_buffer_internal.
2602 (ns_get_foreign_selection, Fx_own_selection_internal)
2603 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2604 (Fns_get_selection_internal, Fns_store_selection_internal):
2605 Use ns_symbol_to_pb and check if return value is nil.
2606 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2607 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2608 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2609 renamed to Sns_store_selection_internal.
2610 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2611 and remove this function.
2612 (ns_handle_selection_clear): Remove, never used.
2613 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2614 here.
2615
e1b01a3a
KB
26162011-12-17 Ken Brown <kbrown@cornell.edu>
2617
2618 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2619 GID is unknown (Bug#10257).
2620
2adb6e85
PE
26212011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2624 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2625 which caused a build failure on GNU/Linux IA-64. This problem was
2626 introduced by my 2011-10-07 patch.
2627
d1d7b339
JL
26282011-12-15 Juri Linkov <juri@jurta.org>
2629
2630 * image.c (imagemagick_error): New function. (Bug#10112)
2631 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2632 Use `imagemagick_error' where ImageMagick functions return
2633 `MagickFalse'.
2634 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2635 proper order.
2636
100d5755
KH
26372011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2638
2639 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2640 fill background (Bug#8992).
2641
454592a6
MR
26422011-12-13 Martin Rudalics <rudalics@gmx.at>
2643
2644 * window.c (Vwindow_combination_resize)
2645 (Vwindow_combination_limit): Use t instead of non-nil in
2646 doc-strings.
61d4b438
MR
2647 (Vrecenter_redisplay): Add first sentence of doc-string on
2648 separate line.
53524d93 2649 (Frecenter): Fix doc-string typo.
454592a6 2650
3633e3aa
KH
26512011-12-11 Kenichi Handa <handa@m17n.org>
2652
2653 * coding.c (Funencodable_char_position): Pay attention to the
2654 buffer text relocation (Bug#9389).
2655
7b9d523a 26562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2657
7b9d523a
JD
2658 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2659 gtk_init (Bug#10100).
2660
b73189c6
EZ
26612011-12-10 Eli Zaretskii <eliz@gnu.org>
2662
2663 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2664 IT->string is nil. (Bug#10263)
2665
f7dfe5d6
JD
26662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2667
83faebb4
JD
2668 * nsterm.h (x_free_frame_resources): Declare.
2669
f7dfe5d6
JD
2670 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2671 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2672
2673 * nsterm.h (ns_get_defaults_value): Declare.
2674
2675 * nsterm.m (ns_default): Call ns_get_defaults_value.
2676
7cd4e72c
EZ
26772011-12-09 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2680 (Bug#10170)
2681
b34d7317
YM
26822011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2683
2684 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2685 that where the value of an _OBJC_* symbol points to is in the .bss
2686 section (Bug#10240).
2687
76470ad1
KH
26882011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2689
2690 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2691 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2692
745fff94
KH
26932011-12-08 Kenichi Handa <handa@m17n.org>
2694
2695 * ftfont.c (get_adstyle_property): Fix previous change
2696 (Bug#10233).
2697
6e44397c
JB
26982011-12-07 Juanma Barranquero <lekktu@gmail.com>
2699
2700 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2701 dirs from the default value of EMACSLOADPATH (bug#10208).
2702
7efa6272
GM
27032011-12-07 Glenn Morris <rgm@gnu.org>
2704
2705 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2706 installation and source directories as well. (Bug#10208)
2707
f6fc4d87
CY
27082011-12-06 Chong Yidong <cyd@gnu.org>
2709
2710 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2711
2bf26180
GM
27122011-12-06 Glenn Morris <rgm@gnu.org>
2713
2714 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2715 as an error, not just -1. (Bug#10217)
2716
3a6ad4f0
CY
27172011-12-05 Chong Yidong <cyd@gnu.org>
2718
2719 * keyboard.c (process_special_events): New function.
2720 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2721
75a3b399
PE
27222011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 * coding.c (encode_designation_at_bol): Don't use uninitialized
2725 local variable (Bug#9318).
2726
c3c9e25e
KH
27272011-12-05 Kenichi Handa <handa@m17n.org>
2728
2729 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2730 return Qnil (Bug#8046, Bug#10193).
2731
5eb05ea3
KH
27322011-12-05 Kenichi Handa <handa@m17n.org>
2733
2734 * coding.c (encode_designation_at_bol): New args charbuf_end and
2735 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2736 (coding_set_source): Return how many bytes coding->source was
2737 relocated.
2738 (coding_set_destination): Return how many bytes
2739 coding->destination was relocated.
2740 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2741 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2742
27432011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2744
2745 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2746 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2747 macro (Bug#9318).
2748
27492011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2750
2751 The following changes are to fix Bug#9318.
2752
a79703f5 2753 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2754 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2755 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2756 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2757
7dbda6df
JB
27582011-12-05 Juanma Barranquero <lekktu@gmail.com>
2759
2760 * lisp.h (process_quit_flag): Fix external declaration.
2761
6d5eb5b0
SM
27622011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2763
2764 Don't macro-inline non-performance-critical code.
2765 * eval.c (process_quit_flag): New function.
2766 * lisp.h (QUIT): Use it.
2767
a0c3fad0
JD
27682011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2769
2770 * nsfns.m (get_geometry_from_preferences): New function.
2771 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2772
6c07aac2
AS
27732011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2774
2775 * emacs.c (Qkill_emacs): Define.
2776 (syms_of_emacs): Initialize it.
2777 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2778 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2779 (quit_throw_to_read_char): Add parameter `from_signal'.
2780 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2781 * lisp.h (QUIT): Call Fkill_emacs if requested.
2782
c052ead4
JD
27832011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2784
2785 * widget.c (update_wm_hints): Return if wmshell is null.
2786 (widget_update_wm_size_hints): New function.
2787
2788 * widget.h (widget_update_wm_size_hints): Declare.
2789
2790 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2791 widget_update_wm_size_hints (Bug#10104).
2792
9e49252b
EZ
27932011-12-03 Eli Zaretskii <eliz@gnu.org>
2794
2795 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2796 before a newline, prepare the bidi iterator for consuming the
2797 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2798 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2799
02b16839
JL
28002011-12-02 Juri Linkov <juri@jurta.org>
2801
2802 * search.c (Fword_search_regexp): New Lisp function created from
2803 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2804 (Fword_search_backward, Fword_search_forward)
2805 (Fword_search_backward_lax, Fword_search_forward_lax):
2806 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2807 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2808
0068070e
SM
28092011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2810
2811 * fileio.c (Finsert_file_contents): Move after-change-function call
2812 to before the "handled:" label, since all "goto handled" appear in
2813 cases where the *-change-functions have already been properly called
2814 (bug#10117).
2815
3360a3fc
AS
28162011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2817
2818 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2819 waiting for input. (Bug#10169)
2820
73d6c093
EZ
28212011-11-30 Eli Zaretskii <eliz@gnu.org>
2822
2823 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2824 verifies glyph row's hash code--we have just reallocated the
2825 glyphs, so their contents can be complete garbage. (Bug#10164)
2826
febe6bea
JB
28272011-11-30 Juanma Barranquero <lekktu@gmail.com>
2828
2829 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2830
801a4313
EZ
28312011-11-30 Eli Zaretskii <eliz@gnu.org>
2832
2833 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2834 attributes are tested _before_ calling verify_row_hash, to protect
2835 against GCC re-ordering of the tests. (Bug#10164)
2836
2b56b87e
JD
28372011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2838
2839 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2840
2841 * xterm.c (handle_one_xevent): Only set async_visible and friends
2842 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2843 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2844 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2845
dbf31225
PE
28462011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2849 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2850 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2851 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2852 All uses changed to use GCPRO1 etc.
2853 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2854 Revert to old implementation (i.e., before 2011-03-11).
2855
1305621b
YM
28562011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2857
2858 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2859 of scroll runs so as to avoid assigning disabled bogus rows and
2860 unnecessary graphics copy operations.
2861
8c9afb46
EZ
28622011-11-27 Eli Zaretskii <eliz@gnu.org>
2863
2864 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2865 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2866 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2867 (malloc, free, realloc, calloc): Redirect to e_* only when
2868 compiling Emacs.
2869
2870 * lisp.h (GCTYPEBITS): Move before first use.
2871 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2872 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2873 this macro definition.
2874
2875 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2876 _MSC_VER.
2877
54e9e3bf
JD
28782011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2879
6d5eb5b0
SM
2880 * gtkutil.c (xg_create_frame_widgets):
2881 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2882 present with Gtk+ 2.0.
2883
83aca1cb
PE
28842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 * fileio.c (Finsert_file_contents): Undo previous change; see
2887 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2888
5b76caa4
PE
28892011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 Rename locals to avoid shadowing.
2892 * fileio.c (Finsert_file_contents):
2893 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2894 * process.c (wait_reading_process_output):
2895 Rename inner 'proc' to 'p' to avoid shadowing.
2896 Indent for consistency with usual Emacs style.
2897
8c535114
EZ
28982011-11-25 Eli Zaretskii <eliz@gnu.org>
2899
2900 * xdisp.c (redisplay_window): If cursor row is not fully visible
2901 after recentering, and scroll-conservatively is set to a large
2902 number, scroll window by a few more lines to make the cursor fully
2903 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2904 (start_display): Don't move to the next line if the display should
2905 start at a newline that is part of a display vector or an overlay
2906 string. (Bug#10119)
8c535114 2907
fa4fdb5c
JL
29082011-11-24 Juri Linkov <juri@jurta.org>
2909
2910 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2911 after the `MagickPingImage' call. (Bug#10112)
2912
90ec88df
CY
29132011-11-23 Chong Yidong <cyd@gnu.org>
2914
2915 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2916
56e2e794
MR
29172011-11-23 Martin Rudalics <rudalics@gmx.at>
2918
2919 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2920 making another buffer current. (Bug#10114)
2921
b6e64c41
GM
29222011-11-23 Glenn Morris <rgm@gnu.org>
2923
2924 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2925
6b21de18
CY
29262011-11-23 Chong Yidong <cyd@gnu.org>
2927
2928 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2929 using it (Bug#5984).
2930
b12cd789
EZ
29312011-11-22 Eli Zaretskii <eliz@gnu.org>
2932
2933 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2934 and header-lines, as they don't have one computed for them.
2935 (Bug#10098)
2936
2937 * .gdbinit (prow): Make displayed values more self-explaining.
2938 Add row's hash code.
2939
261b6fd4
LMI
29402011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2941
2942 * process.c (wait_reading_process_output): Fix asynchrounous
2943 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2944 (wait_reading_process_output): Add comment and URL.
261b6fd4 2945
e7cfd277
JD
29462011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2947
2948 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2949
a9b9b7f5
CY
29502011-11-21 Chong Yidong <cyd@gnu.org>
2951
2952 * window.c (Fnext_window, Fprevious_window): Doc fix.
2953
b0d15b4f
SM
29542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2955
2956 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2957
fe7a3057
JB
29582011-11-20 Juanma Barranquero <lekktu@gmail.com>
2959
2960 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2961
d2999b1a
MR
29622011-11-20 Martin Rudalics <rudalics@gmx.at>
2963
2964 * window.c (Fset_window_combination_limit): Rename argument
2965 STATUS to LIMIT.
2966 (Vwindow_combination_limit): Remove "status" from doc-string.
2967
d5ff9cd0
AS
29682011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2969
2970 * m/ibms390.h: Remove.
2971 * m/ibms390x.h: Don't include "ibms390.h".
2972
a5bb9bd3
SM
29732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2974
2975 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2976 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2977
cd1181db
JB
29782011-11-20 Juanma Barranquero <lekktu@gmail.com>
2979
2980 * casetab.c (Fset_case_table):
2981 * charset.c (Fcharset_after): Fix typos.
2982
615a3b8d 29832011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2984
17e845af
PE
2985 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2986 Otherwise, valgrind does not work on some platforms.
2987 Problem reported by Andreas Schwab in
6a0bf43d
PE
2988 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2989 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2990 is set, removing the need for VIRT_ADDRESS_VARIES.
2991 (PURE_P): Use a more-efficient implementation that needs just one
2992 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2993 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2994 to 4 (xorl, subq, cmpq, setbe).
2995 * alloc.c (pure): Always extern now, since that's the
2996 VIRT_ADDR_VARIES behavior.
2997 (PURE_POINTER_P): Use a single comparison, not two, for
2998 consistency with the new puresize.h.
2999 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3000 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3001 Remove VIRT_ADDR_VARIES no longer needed.
3002
f8fe6f96
EZ
30032011-11-19 Eli Zaretskii <eliz@gnu.org>
3004
3005 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3006 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3007 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3008 behave as if the cursor position were at the window margin.
3009
3010 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3011 and the cursor position is out of bounds, behave as if the cursor
3012 position were at the window margin. (Bug#10075)
3013
df05a53c
CY
30142011-11-18 Chong Yidong <cyd@gnu.org>
3015
3016 * window.c (Fwindow_combination_limit): Make first argument
3017 non-optional, since it is meaningless for live windows like the
3018 selected window.
61ccba97 3019
2071918e
DA
30202011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3021
3022 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3023
b50a28de
SM
30242011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3025
3026 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3027 (graft_intervals_into_buffer): Simplify.
3028
015137db
EZ
30292011-11-18 Eli Zaretskii <eliz@gnu.org>
3030
3031 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3032 hash values of the two rows.
3033 (copy_row_except_pointers): Preserve the used[] arrays and the
3034 hash values of the two rows. (Bug#10035)
68c95424 3035 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3036
3037 * xdisp.c (row_hash): New function, body extracted from
3038 compute_line_metrics.
3039 (compute_line_metrics): Call row_hash, instead of computing the
3040 hash code inline.
3041
3042 * dispnew.c (verify_row_hash): Call row_hash for computing the
3043 hash code of a row, instead of duplicating code from xdisp.c.
3044
3045 * dispextern.h (row_hash): Add prototype.
3046
a2addb04
TH
30472011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3048
3049 * frame.c (delete_frame): Don't delete the terminal when the last
3050 X frame is closed if emacs is built with GTK toolkit.
3051
df85d315
JB
30522011-11-17 Juanma Barranquero <lekktu@gmail.com>
3053
3054 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3055
a0c2d0ae
MR
30562011-11-17 Martin Rudalics <rudalics@gmx.at>
3057
3058 * window.c (Vwindow_splits): Rename to
3059 Vwindow_combination_resize. Suggested by Juri Linkov.
3060 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3061 of Vwindow_splits.
3062
58179cce
JB
30632011-11-16 Juanma Barranquero <lekktu@gmail.com>
3064
7877f373
JB
3065 * nsfns.m (Fns_font_name):
3066 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3067
b6f67890
MR
30682011-11-16 Martin Rudalics <rudalics@gmx.at>
3069
3070 * window.h (window): Rename slot "nest" to "combination_limit".
3071 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3072 (Fset_window_nest): Rename to Fset_window_combination_limit.
3073 (Vwindow_nest): Rename to Vwindow_combination_limit.
3074 (recombine_windows, make_parent_window, make_window)
3075 (Fsplit_window_internal, saved_window)
3076 (Fset_window_configuration, save_window_save): Rename all
3077 occurrences of window_nest to window_combination_limit.
3078
c7015153
JB
30792011-11-15 Juanma Barranquero <lekktu@gmail.com>
3080
3081 * image.c (imagemagick_load_image): Fix typo.
3082
322ad6ec
EZ
30832011-11-14 Eli Zaretskii <eliz@gnu.org>
3084
3085 * xdisp.c (display_line): Move the call to
3086 highlight_trailing_whitespace before the call to
3087 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3088 faces of all the glyphs to compute ROW's hash value.
3089 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3090
f067b8ec
JB
30912011-11-14 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3094 just return (bug#10044).
3095
1e5b2111
EZ
30962011-11-12 Eli Zaretskii <eliz@gnu.org>
3097
7ef3cbd5
EZ
3098 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3099 with user-defined heap size. Bump the default size of the temacs
3100 heap to 27MB, to avoid memory warning when running temacs.
3101 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3102
1e5b2111
EZ
3103 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3104 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3105 (verify_row_hash) [XASSERTS]: New function.
3106 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3107 that the hash value of glyph rows is correct.
1e5b2111 3108
89d61221
MR
31092011-11-12 Martin Rudalics <rudalics@gmx.at>
3110
3111 * window.h (window): Remove splits slot.
3112 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3113 (Fdelete_other_windows_internal, make_parent_window)
3114 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3115 (Fset_window_configuration, save_window_save): Don't deal with
3116 split status of windows.
3117 (saved_window): Remove splits slot.
3118 (Vwindow_splits): Rewrite doc-string.
3119
97f18cc8
JD
31202011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3121
3122 * xfns.c (unwind_create_frame):
3123 * nsfns.m (unwind_create_frame):
3124 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3125 Vframe_list (Bug#9999).
3126
22a648b4
DA
31272011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3128
0b381c7e 3129 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3130
659afede
KH
31312011-11-11 Kenichi Handa <handa@m17n.org>
3132
3133 * callproc.c (Fcall_process): Set the member dst_multibyte of
3134 process_coding.
3135
9ac0394b
KH
31362011-11-11 Johan Bockgård <bojohan@gnu.org>
3137
3138 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3139 avoid a crash (bug#9496).
3140
2fbdc249
CY
31412011-11-09 Chong Yidong <cyd@gnu.org>
3142
3143 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3144 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3145
ac6b1f81
PE
31462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3149
09db192c
PE
31502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3151
3152 Avoid some portability problems by eschewing 'extern inline' functions.
3153 The trivial performance wins aren't worth the portability hassles; see
3154 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3155 et seq.
3156 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3157 (window_box_width, window_box_left, window_box_left_offset)
3158 (window_box_right, window_box_right_offset): Undo previous change,
3159 by removing the "extern"s.
3160 * intervals.c (adjust_intervals_for_insertion)
3161 (adjust_intervals_for_deletion): Undo previous change,
3162 making these static again.
3163 (offset_intervals, temp_set_point_both, temp_set_point)
3164 (copy_intervals_to_string): No longer inline.
3165 * xdisp.c (window_text_bottom_y, window_box_width)
3166 (window_box_height, window_box_left_offset)
3167 (window_box_right_offset, window_box_left, window_box_right)
3168 (window_box): No longer inline.
3169
105216ed
CY
31702011-11-08 Chong Yidong <cyd@gnu.org>
3171
3172 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3173 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3174 Signal an error if not a live window.
105216ed
CY
3175 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3176 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3177
ae9e237f
JB
31782011-11-07 Juanma Barranquero <lekktu@gmail.com>
3179
3180 * lisp.h (syms_of_abbrev): Remove declaration.
3181 Reported by CHENG Gao <chenggao@royau.me>.
3182
c7aa8333
EZ
31832011-11-07 Eli Zaretskii <eliz@gnu.org>
3184
3185 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3186 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3187 of temacs in GUI mode.
3188
be7f5545
MR
31892011-11-07 Martin Rudalics <rudalics@gmx.at>
3190
3191 * window.h: Declare delete_all_child_windows instead of
3192 delete_all_subwindows.
3193 * window.c (Fwindow_nest, Fset_window_nest)
3194 (Fset_window_new_total, Fset_window_new_normal)
3195 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3196 (delete_all_subwindows): Rename to delete_all_child_windows.
3197 (Fdelete_other_windows_internal, Fset_window_configuration):
3198 Call delete_all_child_windows instead of delete_all_subwindows.
3199 * frame.c (delete_frame): Call delete_all_child_windows instead
3200 of delete_all_subwindows.
3201
ca78dc43
PE
32022011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3203
3204 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3205 This is also needed for porting to any host where GC_MARK_STACK is
3206 not GC_MAKE_GCPROS_NOOPS.
3207 (which_symbols): Use it.
3208
a0241d01
KH
32092011-11-07 Kenichi Handa <handa@m17n.org>
3210
3211 * coding.c (coding_set_destination): Check coding->src_pos only
3212 when coding->src_object is a buffer (bug#9910).
3213
3214 * process.c (send_process): Set the member src_multibyte of coding
3215 to 0 (bug#9911) when sending a unibyte text.
3216
3217 * callproc.c (Fcall_process): Set the member src_multibyte of
3218 process_coding to 0 (bug#9912).
3219
a64bfdfa 32202011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3221
3222 * xmenu.c (cleanup_widget_value_tree): New function.
3223 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3224 calling free_menubar_widget_value_tree directly (Bug#9830).
3225
cb41b32a
PE
32262011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 Fix some portability problems with 'inline'.
3229 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3230 (window_box_width, window_box_left, window_box_left_offset)
3231 (window_box_right, window_box_right_offset): Declare extern.
3232 Otherwise, these inline functions do not conform to C99 and
3233 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3234 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3235 * intervals.c (adjust_intervals_for_insertion)
3236 (adjust_intervals_for_deletion): Now extern, because otherwise the
3237 extern inline functions 'offset_intervals' couldn't refer to it.
3238 (static_offset_intervals): Remove.
3239 (offset_intervals): Rewrite using the old contents of
3240 static_offset_intervals. The old version didn't conform to C99
3241 because an extern inline function contained a reference to an
3242 identifier with static linkage.
3243
b7041366
AS
32442011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3245
3246 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3247 GC.
3248
88a37c4d
EZ
32492011-11-06 Eli Zaretskii <eliz@gnu.org>
3250
3251 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3252 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3253 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3254 return Qleft_to_right.
3255
49745b39
CY
32562011-11-06 Chong Yidong <cyd@gnu.org>
3257
3258 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3259 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3260 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3261 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3262 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3263 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3264 (Fwindow_vscroll): Doc fix.
3265 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3266 argument, since it makes no sense to pass a live window and for
3267 consistency with window-child.
3268
1f05cd82
CS
32692011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3270
3271 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3272 support MSVC.
3273
22610910
JR
32742011-11-05 Jason Rumney <jasonr@gnu.org>
3275
3276 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3277 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3278 fonts (Bug#6029).
3279 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3280 bitwise arithmetic preventing use of unicode-sip and non-truetype
3281 opentype fonts.
3282
a06776b2
EZ
32832011-11-05 Eli Zaretskii <eliz@gnu.org>
3284
3ad924ba
EZ
3285 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3286 "emacs"-only part.
3287
a06776b2
EZ
3288 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3289 initialization code to keep similarity to xfns.c after changes
3290 from 2011-11-05.
3291
c9e7db78
JD
32922011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3293
a97f8f3f
JD
3294 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3295 (unwind_create_frame): New function (Bug#9943).
3296 (Fx_create_frame): Restructure code to be more similar to the one in
3297 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3298 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3299 Move terminal->reference_count++ just before making the frame official
3300 (Bug#9943).
3301
3302 * nsterm.m (x_free_frame_resources): New function.
3303 (x_destroy_window): Move code to x_free_frame_resources.
3304
c9e7db78 3305 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3306 (Fx_create_frame, x_create_tip_frame):
3307 Move terminal->reference_count++ just before making the frame
75f1671a 3308 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3309 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3310
a6fc3b5c
EZ
33112011-11-05 Eli Zaretskii <eliz@gnu.org>
3312
3313 Support MSVC build with newer versions of Visual Studio.
3314 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3315 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3316 nt/gmake.defs.
3317
3318 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3319 which are not supported by MSVC.
3320 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3321 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3322 bitfields.
3323 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3324 types in bitfields.
3325 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3326
3327 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3328
58179cce 33292011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3330
3331 Support MSVC build with newer versions of Visual Studio.
3332 * w32.c: Don't include w32api.h for MSVC.
3333 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3334
3335 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3336 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3337 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3338 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3339 e_* cousins.
3340 (alloca) [_MSC_VER]: Define to _alloca.
3341
3342 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3343
3344 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3345
a58c13ed
EZ
33462011-11-04 Eli Zaretskii <eliz@gnu.org>
3347
3348 * xdisp.c (note_mouse_highlight): If either of
3349 previous/next-single-property-change returns nil, treat that as
3350 the beginning or the end of the buffer. (Bug#9955)
3351
fe0b6370
JD
33522011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3353
a58c13ed 3354 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3355 label is not null (Bug#9951).
3356 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3357 may be NULL.
3358
89bd5ee1
EZ
33592011-11-04 Eli Zaretskii <eliz@gnu.org>
3360
3361 * window.c (Fwindow_body_size): Mention in the doc string that the
3362 return value is in frame's canonical units. (Bug#9949)
3363
84c3edb9
EZ
33642011-11-03 Eli Zaretskii <eliz@gnu.org>
3365
4e2fb5c7
EZ
3366 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3367
84c3edb9 3368 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3369 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3370 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3371
bc17a887
EZ
33722011-11-01 Eli Zaretskii <eliz@gnu.org>
3373
3374 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3375 Don't stop backward scan on the continuation glyph, even though
3376 its CHARPOS is positive.
6d5eb5b0
SM
3377 (mouse_face_from_buffer_pos, note_mouse_highlight):
3378 Rename cover_string to disp_string.
bc17a887 3379
4ee88440
MR
33802011-11-01 Martin Rudalics <rudalics@gmx.at>
3381
3382 * window.c (temp_output_buffer_show): Don't use
3383 Vtemp_buffer_show_specifiers.
3384 (Vtemp_buffer_show_specifiers): Remove unused variable.
3385
c2ff3c02
EZ
33862011-10-30 Eli Zaretskii <eliz@gnu.org>
3387
3388 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3389 past the beginning of the current glyph matrix.
3390
58179cce 33912011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3392
3393 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3394 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3395 HAVE_GTK3 (Bug#9869).
b77a6a7f 3396
3b574623
JD
3397 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3398 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3399
b77a6a7f
JD
3400 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3401
3402 * xterm.c: Declare x_handle_net_wm_state to return int.
3403 (handle_one_xevent): Check if we are iconified but don't have
3404 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3405 (get_current_wm_state): Return non-zero if not hidden,
3406 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3407 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3408 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3409 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3410
196e41e4
PE
34112011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3412
3413 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3414 so that this new function doesn't get optimized away by a
3415 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3416
021f2e1a
AS
34172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3418
3419 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3420
8b058d44
EZ
34212011-10-29 Eli Zaretskii <eliz@gnu.org>
3422
3423 Fix the `xbytecode' command.
3424 * .gdbinit (xprintbytestr): New command.
b50a28de 3425 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3426 (xbytecode): Print the byte-code string as well.
3427
4452fb80
EZ
34282011-10-29 Kim Storm <storm@cua.dk>
3429
8b058d44
EZ
3430 * alloc.c (which_symbols): New function.
3431
21b72067
AS
34322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3433
3434 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3435 line. (Bug#9903)
3436
83ed7b5c
GM
34372011-10-29 Glenn Morris <rgm@gnu.org>
3438
3439 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3440 Not clear what it was for, and it causes various bugs. (Bug#9839)
3441
5a7a728b
EZ
34422011-10-28 Eli Zaretskii <eliz@gnu.org>
3443
3444 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3445 possible random value that matches one of those tested as
3446 condition to clear the mouse face.
3447
d3d0842f
CY
34482011-10-28 Chong Yidong <cyd@gnu.org>
3449
3450 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3451
31b39d13
DN
34522011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3453
3454 * window.c (make_window): Initialize phys_cursor_on_p.
3455
9aba6043
SM
34562011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3457
3458 * lisp.h (struct Lisp_Symbol): Update comments.
3459
c20992f4
JB
34602011-10-28 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3463
db4f02f2
EZ
34642011-10-28 Eli Zaretskii <eliz@gnu.org>
3465
3466 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3467 <oslsachem@gmail.com> for helping to debug this.
3468
3469 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3470 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3471 (g_b_init_get_glyph_outline_w): New static variables.
3472 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3473 (GetGlyphOutlineW_Proc): New typedefs.
3474 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3475 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3476 New functions.
3477 (w32font_open_internal, compute_metrics):
3478 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3479 instead of calling the "wide" APIs directly.
3480
3481 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3482
3483 * w32.h (syms_of_w32font): Add prototype.
3484
87e68db4
JB
34852011-10-27 Juanma Barranquero <lekktu@gmail.com>
3486
3487 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3488 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3489 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3490 (Fmove_to_window_line): Doc fix.
3491
435c1d67
CY
34922011-10-27 Chong Yidong <cyd@gnu.org>
3493
3494 * process.c (make_process): Set gnutls_state to NULL.
3495
3496 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3497 non-NULL, regardless of GNUTLS_INITSTAGE.
3498 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3499 an error. Set process slots as soon as we allocate them.
3500
3501 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3502
9c6c6f49
CY
35032011-10-27 Chong Yidong <cyd@gnu.org>
3504
9aba6043
SM
3505 * gnutls.c (emacs_gnutls_deinit): New function.
3506 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3507 (Fgnutls_deinit, Fgnutls_boot): Use it.
3508
3509 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3510 (deactivate_process): Call emacs_gnutls_deinit.
3511
657d08d3
JB
35122011-10-27 Juanma Barranquero <lekktu@gmail.com>
3513
3514 * image.c (x_create_x_image_and_pixmap):
3515 * w32.c (sys_rename, w32_delayed_load):
3516 * w32font.c (fill_in_logfont):
3517 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3518
5430d399
JB
35192011-10-26 Juanma Barranquero <lekktu@gmail.com>
3520
3521 * w32fns.c (w32_default_color_map): New function,
3522 extracted from Fw32_default_color_map.
a7ef684b 3523 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3524
fe0055fa
PE
35252011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3526
3527 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3528
e6346438
SM
35292011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3530
3531 * keyboard.c (test_undefined): New function (bug#9751).
3532 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3533
e112cc37
ET
35342011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3535
3536 * sysdep.c (init_sys_modes): Fix the check for the controlling
3537 terminal (Bug#6649).
3538
7b5d6677
EZ
35392011-10-20 Eli Zaretskii <eliz@gnu.org>
3540
3541 * dispextern.h (struct bidi_it): New member next_en_type.
3542
3543 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3544 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3545 current character, check also for next_en_type being WEAK_EN.
3546 (bidi_resolve_weak): Don't enter the expensive loop if the current
3547 position is before next_en_pos. Record the bidi type of the first
3548 non-ET, non-BN character we find, in addition to its position.
3549 (bidi_level_of_next_char): Invalidate next_en_type when
3550 next_en_pos is over-stepped.
3551
7da0b018
PE
35522011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3553
3554 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3555 * editfns.c: Rewrite current-time-zone so that it invokes
3556 the equivalent of (format-time-string "%Z") to get the time zone name.
3557 This fixes a bug when the time zone name contains characters that
3558 need converting from the system time locale to Emacs internal format.
3559 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3560 that patch fixed format-time-string to do the conversion, but
3561 I forgot to fix current-time-zone.
3562 (format_time_string): New function, containing most of
3563 what Fformat_time_string used to contain.
3564 (Fformat_time_string): Rewrite in terms of format_time_string.
3565 This doesn't change this function's behavior.
3566 (current-time-zone): Rewrite to use format_time_string.
3567 This fixes the bug reported by Michael Schierl in
3568 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3569 Jason Rumney's 2007-06-07 change worked around this bug, but
3570 didn't fix it.
3571 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3572
8547b010
EZ
35732011-10-19 Eli Zaretskii <eliz@gnu.org>
3574
3575 * xdisp.c (start_display): If the character at POS is displayed
3576 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3577 (try_window_reusing_current_matrix): If a line ends in a display
3578 vector or the next line starts in a display vector, continue
3579 redrawing the window even though the character position of
3580 start_row was reached.
8547b010
EZ
3581 (Bug#9771, part 2)
3582
4e948d15
CY
35832011-10-18 Chong Yidong <cyd@gnu.org>
3584
3585 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3586 with nobreak-char-display too.
3587
4787455f
EZ
35882011-10-18 Eli Zaretskii <eliz@gnu.org>
3589
3590 Fix part 3 of bug#9771.
3591 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3592 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3593 non-neutral characters if the current character is a paragraph
3594 separator (a.k.a. Newline). This avoids running the same
3595 expensive loop twice, once when we consume the preceding newline
3596 and the other time when the line actually needs to be displayed.
3597 Avoid the loop when we see neutrals on the base embedding level
3598 following a character whose directionality is the same as the
3599 paragraph's. This avoids running the expensive loop when a line
3600 ends in a long sequence of neutrals, like control characters.
3601 Add assertion against STRONG_AL type. Slightly rearrange code
3602 that determines the type of a neutral given the first non-neutral
3603 that follows it.
3604 (bidi_level_of_next_char): Set next_en_pos to zero when
3605 invalidating its info.
3606
2c91f553
EZ
36072011-10-17 Eli Zaretskii <eliz@gnu.org>
3608
3609 * xdisp.c (push_display_prop): Determine whether to record string
3610 or buffer position by IT->string, not by IT->method. Allow
3611 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3612 (move_it_vertically_backward): Don't look for character position
3613 immediately after the newline when in a continuation line.
3614 (Bug#9771, part 1)
2c91f553 3615
c7b08b0d
MR
36162011-10-15 Martin Rudalics <rudalics@gmx.at>
3617
3618 * window.c (coordinates_in_window): Rewrite and delabelize
3619 vertical border check. (Bug#5357) (Bug#9618)
3620
6b02f655
SM
36212011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3622
3623 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3624 errors in XSetWindowBorder (bug#9310).
3625
81d40c92
DA
36262011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3627
3628 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3629 avoid crash when xmalloc overrun checking is enabled.
3630
d4172c3b
EZ
36312011-10-13 Eli Zaretskii <eliz@gnu.org>
3632
3633 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3634 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3635 cursor motion with <left> and <right> arrow keys.
3636
3637 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3638 some callers set that themselves.
3639
b00eea75
EZ
36402011-10-12 Eli Zaretskii <eliz@gnu.org>
3641
3642 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3643 display string and the previous row comes from the same string and
3644 is empty. (Bug#9739) (Bug#9738)
3645
8fe012c4
SM
36462011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3647
3648 * doc.c (get_doc_string): Encode file name (bug#9735).
3649
0074aef2
EZ
36502011-10-12 Eli Zaretskii <eliz@gnu.org>
3651
79beb178
EZ
3652 * bidi.c (bidi_level_of_next_char):
3653 * xdisp.c (get_visually_first_element): Remove old incorrect
3654 comments regarding the Unicode Line Separator character.
3655
0074aef2
EZ
3656 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3657
6e4b3fbe
DA
36582011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3659
3660 * alloc.c (Fgc_status): Do not access beyond zombies array
3661 boundary if nzombies > MAX_ZOMBIES.
3662 * alloc.c (dump_zombies): Add missing format specifier.
3663
0324f3af
PE
36642011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3665
b5525cac
PE
3666 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3667 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3668
0324f3af
PE
3669 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3670 Some packages use them to denote characters with modifiers.
3671
e9b5f888
AS
36722011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3673
3674 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3675 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3676 matching a pp-number. Rename parameter var to var1.
3677
127827c0
SM
36782011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3679
3680 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3681
c8fd3bd0
GM
36822011-10-08 Glenn Morris <rgm@gnu.org>
3683
3684 * callint.c (Fcall_interactively): Give a more explicit error for the
3685 'c' case with a non-character input. (Bug#8479)
3686
352ec8ff
EZ
36872011-10-08 Eli Zaretskii <eliz@gnu.org>
3688
03669ccb
EZ
3689 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3690 lines.
7061c986
EZ
3691 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3692 lines that are hscrolled on the left.
03669ccb 3693
352ec8ff
EZ
3694 * dispnew.c (buffer_posn_from_coords): Account for a possible
3695 presence of header-line. (Bug#4426)
3696
a66cfb1c
SM
36972011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3698
6b02f655
SM
3699 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3700 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3701
7c5ee88e
PE
37022011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3705 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3706 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3707 this makes Emacs dump core during garbage collection on rare
3708 occasions. sizeof is obviously inferior to offsetof here, so
3709 stick with offsetof.
3710 (GC_POINTER_ALIGNMENT): New macro.
3711 (mark_memory): Omit 3rd (offset) arg; caller changed.
3712 Don't assume EMACS_INT alignment is the same as pointer alignment.
3713
df1bbe5b
SM
37142011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3715
3716 * keyboard.c (read_key_sequence_remapped): New var.
3717 (read_key_sequence): Compute remapping in the right buffer.
3718 (command_loop_1): Use read_key_sequence's remapping directly.
3719
51553db6
SM
37202011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3721
32c1fffd
SM
3722 * dired.c (file_name_completion): Don't expand file name.
3723 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3724 before checking file name handler.
3725
51553db6
SM
3726 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3727 they've been requested explicitly (bug#9591).
3728
b6bd1599 37292011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3730
3731 * keymap.c (Fsingle_key_description): Use make_specified_string
3732 instead of build_string to build string from push_key_description.
3733 (Bug#5193)
3734
f701dc2a
PE
37352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3736
4222c55d
PE
3737 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3738 This fixes a Y2038 bug on 64-bit hosts.
3739 * buffer.c (reset_buffer):
3740 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3741 (Fclear_buffer_auto_save_failure):
3742 Use 0, not -1, to represent an unset failure time, since time_t
3743 might not be signed.
3744
f701dc2a
PE
3745 Remove dependency on glibc malloc internals.
3746 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3747 Move back here from lisp.h, but with their new implementations.
3748 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3749 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3750 * charset.c (charset_table_init): New static var.
3751 (syms_of_charset): Use it instead of xmalloc. This removes a
3752 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3753 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3754 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3755 Move back to alloc.c.
3756 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3757 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3758
9ceebf39
JD
37592011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3760
3761 * nsterm.m (windowDidResize): Call x_set_window_size only when
3762 ns_in_resize is true. Otherwise set pixelwidth/height and
3763 call change_frame_size (Bug#9628).
3764
cb993c58
PE
37652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3766
3930c88b
PE
3767 Port --enable-checking=all to Fedora 14 x86-64.
3768 * charset.c (syms_of_charset): Also account for glibc malloc's
3769 internal overhead when calculating the initial malloc maximum.
3770
cb993c58
PE
3771 Port --enable-checking=all to Fedora 14 x86.
3772 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3773 Move to lisp.h.
3774 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3775 (overrun_check_realloc, overrun_check_free):
3776 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3777 That way, xmalloc returns a properly-aligned pointer even if
3778 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3779 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3780 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3781 into account when calculating the initial malloc maximum.
3782 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3783 Move here from alloc.c, so that charset.c can use it too.
3784 Properly align; the old code wasn't right for common 32-bit hosts
3785 when configured with --enable-checking=all.
3786 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3787 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3788
31bed486
EZ
37892011-09-29 Eli Zaretskii <eliz@gnu.org>
3790
04c70788 3791 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3792 use EDOM.
3793
fbcaa2f3
EZ
37942011-09-28 Eli Zaretskii <eliz@gnu.org>
3795
3796 * xdisp.c (compute_display_string_end): If there's no display
3797 string at CHARPOS, return -1.
3798
3799 * bidi.c (bidi_fetch_char): When compute_display_string_end
3800 returns a negative value, treat the character as a normal
3801 character not covered by a display string. (Bug#9624)
3802
a239d4e9
JB
38032011-09-28 Juanma Barranquero <lekktu@gmail.com>
3804
3805 * lread.c (Fread_from_string): Fix typo in docstring.
3806
88652fd5
EZ
38072011-09-27 Eli Zaretskii <eliz@gnu.org>
3808
3809 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3810 newline, reseat the iterator instead of bidi-iterating there one
3811 character at a time. (Bug#9610)
32c1fffd
SM
3812 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3813 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3814
ed497dd4
AS
38152011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3816
3817 * lread.c (readevalloop): Use correct code for NBSP.
3818 (read1): Likewise. (Bug#9608)
3819
b2bf61aa
MA
38202011-09-25 Michael Albinus <michael.albinus@gmx.de>
3821
3822 * dbusbind.c (Fdbus_register_signal): When service is not
3823 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3824
32bbb17c
GM
38252011-09-25 Glenn Morris <rgm@gnu.org>
3826
3827 * buffer.c (truncate-lines): Doc fix.
3828
94e0933e
CY
38292011-09-24 Chong Yidong <cyd@stupidchicken.com>
3830
3831 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3832 (Fset_window_next_buffers): Doc fix.
3833
cddde921
GM
38342011-09-24 Glenn Morris <rgm@gnu.org>
3835
3836 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3837
1260aef1
PE
38382011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3839
25b4bfa0
PE
3840 Fix minor problems found by static checking.
3841 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3842 * indent.c (Fvertical_motion): Fix == vs = typo.
3843
e3cbd34b
EZ
38442011-09-24 Eli Zaretskii <eliz@gnu.org>
3845
a66cfb1c
SM
3846 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3847 Default value is now t. Doc fix.
6bf7006f 3848
e3cbd34b 3849 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3850 logic when moving up, not only when moving down. Fix the
e3cbd34b 3851 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3852 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3853
3854 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3855 CHARPOS is covered by a display string which includes newlines.
3856 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3857 is covered by a display string with embedded newlines.
3858
a3de0cbd
MA
38592011-09-24 Michael Albinus <michael.albinus@gmx.de>
3860
3861 * dbusbind.c (Fdbus_register_signal): Add match rule to
3862 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3863 (Fdbus_register_method, Vdbus_registered_objects_table):
3864 Fix docstring.
a3de0cbd 3865
b260039d
JM
38662011-09-24 Jim Meyering <meyering@redhat.com>
3867
32c1fffd 3868 do not ignore write error for any output size
b260039d
JM
3869 The previous change was incomplete.
3870 While it makes emacs --batch detect the vast majority of stdout
3871 write failures, errors were still ignored whenever the output size is
3872 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3873 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3874 && echo FAIL: ignored write error
3875 FAIL: ignored write error
3876 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3877 && echo FAIL: ignored write error
3878 FAIL: ignored write error
3879 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3880
8eca8a7c
AS
38812011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3882
3883 * emacs.c (Fkill_emacs): In noninteractive mode exit
3884 non-successfully if a write error occurred on stdout. (Bug#9574)
3885
3341db62
EZ
38862011-09-21 Eli Zaretskii <eliz@gnu.org>
3887
3888 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3889 the xassert test.
3890
3891 * dispextern.h (struct it): Update the comment documenting what
3892 can it->OBJECT be.
3893
8c203dbf
EZ
38942011-09-20 Eli Zaretskii <eliz@gnu.org>
3895
3896 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3897 a display string, extend search for cursor position to end of row.
3898 (find_row_edges): If the row ends in a newline from a display
3899 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3900 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3901 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3902 non-empty line. Fixes confusing cursor motion with arrow keys at
3903 the beginning of a line that starts with whitespace.
8c203dbf 3904
a4824228
LMI
39052011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3906
3907 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3908 (bug#9493).
3909
33ed493b
CY
39102011-09-18 Chong Yidong <cyd@stupidchicken.com>
3911
3912 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3913 boolean (Bug#9154).
3914
56cd55c8
EZ
39152011-09-18 Eli Zaretskii <eliz@gnu.org>
3916
3917 * xdisp.c (display_line): Record maximum and minimum buffer
3918 positions even if no glyphs were produced (e.g., by a zero-width
3919 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3920 buffer positions that will be removed from the glyph row because
3921 they don't fit.
c02dcedf
EZ
3922 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3923 column is beyond frame width: don't subtract 1 "pixel" when
3924 computing width of the stretch.
3e62b7e0
EZ
3925 (reseat_at_next_visible_line_start): Undo the change made on
3926 2011-09-17 that saved paragraph information and restored it after
3927 the call to `reseat'. (Bug#9545)
56cd55c8 3928
5ed99d36 39292011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3930
3931 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3932 and turn window cursor on if cleared (Bug#9415).
3933
5ed99d36 39342011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3935
3936 * search.c (boyer_moore): Take unibyte characters from pattern
3937 literally. (Bug#9458)
3938
9bade7b2
EZ
39392011-09-18 Eli Zaretskii <eliz@gnu.org>
3940
3941 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3942
e5e9d610
PE
39432011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3944
87e4427a
PE
3945 Fix minor problem found by static checking.
3946 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3947 initialized, to pacify gcc -Wuninitialized.
3948
e5e9d610
PE
3949 * fileio.c: Report proper errno when syscall falls.
3950 (Finsert_file_contents): Save and restore errno,
3951 so that report_file_error outputs the correct diagnostic.
3952 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3953
a1674f0b
EZ
39542011-09-18 Eli Zaretskii <eliz@gnu.org>
3955
3956 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3957
fbfb6dd4
EZ
39582011-09-17 Eli Zaretskii <eliz@gnu.org>
3959
3960 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3961 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3962
bb187662
EZ
39632011-09-17 Eli Zaretskii <eliz@gnu.org>
3964
1137e8b8 3965 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3966 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3967
3968 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3969 (bidi_find_paragraph_start): Search back for paragraph beginning
3970 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3971 (bidi_move_to_visually_next): Only trigger paragraph-related
3972 computations when the last character is a newline or at EOB, not
3973 just any NEUTRAL_B. (Bug#9470)
3974
bb187662
EZ
3975 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3976 truncated lines if point is covered by a display string. (Bug#9524)
3977
2e621251
PE
39782011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3981 (cons_to_x_long): New function.
3982 (lisp_data_to_selection_data): Use it. Correct the test for
3983 short-versus-long data; it was negated. Break out of vector
3984 loop, for efficiency, when a long datum is discovered.
3985
91a15bc6
SM
39862011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3987
3988 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3989
b41c3a35
EZ
39902011-09-16 Eli Zaretskii <eliz@gnu.org>
3991
3992 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3993 GCC PR/17406) by declaring this function with external scope.
3994
7812ba2d
PE
39952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3996
3997 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3998 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3999
cf7edc2a
AS
40002011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4001
4002 * editfns.c (Fformat): Correctly handle text properties on "%%".
4003
bd01620e
EZ
40042011-09-15 Eli Zaretskii <eliz@gnu.org>
4005
4006 * xterm.c (x_draw_composite_glyph_string_foreground):
4007 * w32term.c (x_draw_composite_glyph_string_foreground):
4008 * term.c (encode_terminal_code):
4009 * composite.c (composition_update_it, get_composition_id):
4010 * xdisp.c (get_next_display_element)
4011 (fill_composite_glyph_string): Add comments about special meaning
4012 of TAB characters in a composition.
4013
a02719a3
PE
40142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4017 This occurs when processing a multibyte format.
4018 Problem reported by Wolfgang Jenker.
a02719a3 4019
72589a3c
JB
40202011-09-15 Johan Bockgård <bojohan@gnu.org>
4021
4022 * xdisp.c (try_cursor_movement): Only check for exact match if
4023 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4024
1c14176c
PE
40252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 Remove unused external symbols.
4028 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4029 * xdisp.c (calc_pixel_width_or_height): Now static.
4030 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4031 * indent.c (check_display_width):
4032 * w32term.c: Fix comment to match code.
4033 * xterm.c, xterm.h (x_catching_errors): Remove.
4034
d2eea5b5
PE
40352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 * xselect.c: Use signed conversions more consistently (Bug#9498).
4038 (selection_data_to_lisp_data): Assume incoming selection data are
4039 signed integers, not unsigned. This is to be consistent with
4040 outgoing selection data, which was modified to use signed integers
4041 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4042 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4043 expects long, not unsigned long.
4044
46888499
EZ
40452011-09-14 Eli Zaretskii <eliz@gnu.org>
4046
4047 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4048 computation of loop end. Reported by Johan Bockgård
4049 <bojohan@gnu.org>.
4050
ef8ef9fb
CY
40512011-09-13 Chong Yidong <cyd@stupidchicken.com>
4052
4053 * frame.c (Fother_visible_frames_p): Function deleted.
4054
fa819fed
EZ
40552011-09-12 Eli Zaretskii <eliz@gnu.org>
4056
4057 * indent.c (compute_motion): Process display vector front to back
4058 rather than the other way around. (Bug#2496)
4059
2ba8e008
SM
40602011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4061
4062 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4063
20f53c69
CY
40642011-09-11 Chong Yidong <cyd@stupidchicken.com>
4065
4066 * minibuf.c (Fread_from_minibuffer): Doc fix.
4067
d562d7a4
EZ
40682011-09-11 Eli Zaretskii <eliz@gnu.org>
4069
4070 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4071 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4072
1c4d7f3d
LMI
40732011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4074
4075 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4076 value for non-existent files.
4077
b885bf36
EZ
40782011-09-11 Eli Zaretskii <eliz@gnu.org>
4079
4080 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4081 set its "size" to -1. This will set the modtime_size field of
4082 the corresponding buffer to -1, which is what
4083 verify-visited-file-modtime expects for files that do not exist.
4084 (Bug#9139)
4085
6612f0bf
PE
40862011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4087
4088 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4089 here ...
4090 * lisp.h: ... from here. push_key_description is no longer
4091 defined in keyboard.c, so its declaration should not be in
4092 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4093 logically belongs with push_key_description.
4094
dfb3f755
PE
40952011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 * buffer.h: Include <sys/types.h> instead of <time.h>.
4098 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4099 Problem reported by Herbert J. Skuhra.
4100
3134906c
LMI
41012011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4102
4103 * xml.c (parse_region): Make the parsing work for
4104 non-comment-starting XML files again (bug#9144).
4105
8d903f4e
AS
41062011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4107
4108 * image.c (gif_load): Fix calculation of bottom and right corner.
4109 (Bug#9468)
4110
80ad64f4
EZ
41112011-09-10 Eli Zaretskii <eliz@gnu.org>
4112
4113 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4114 redisplay in small windows.
4115
208a048d
EZ
41162011-09-09 Eli Zaretskii <eliz@gnu.org>
4117
4118 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4119
9b1c252e
MR
41202011-09-08 Martin Rudalics <rudalics@gmx.at>
4121
4122 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4123 Operate on live windows only.
4124
2949f33b
JB
41252011-09-08 Juanma Barranquero <lekktu@gmail.com>
4126
4127 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4128
e08dcafd
EZ
41292011-09-07 Eli Zaretskii <eliz@gnu.org>
4130
4131 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4132 only under bidi iteration.
4133
115b96bd
JD
41342011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4135
4136 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4137
c8199d0f
PE
41382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4141 Without this fix, the command to link temacs failed due to an
4142 undefined symbol __builtin_isnan. This is because
4143 /usr/include/iso/math_c99.h #defines isnan(x) to
4144 __builtin_isnan(x), but the bundled gcc, which identifies itself
4145 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4146 a __builtin_isnan.
4147 * floatfns.c (isnan): #undef, and then #define to a clone of
4148 what's in data.c.
4149 (Fisnan): Always define, since it's always available now.
4150 (syms_of_floatfns): Always define isnan at the Lisp level.
4151
e39b275c 41522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4153
4154 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4155
b2db44d9 41562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4157
f4af5137 4158 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4159 The previous code assumed that file offsets (off_t values) fit in
4160 EMACS_INT variables, which is not true on typical 32-bit hosts.
4161 The code messed up by falsely reporting buffer overflow in cases
4162 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4163 when "big" contains more than 2**29 bytes, even though this
4164 inserts just one byte and does not overflow the buffer.
4165 (Finsert_file_contents): Store file offsets as off_t
4166 values, not as EMACS_INT values. Check for overflow when
4167 converting between EMACS_INT and off_t. When checking for
4168 buffer overflow or for overlap, take the offsets into account.
4169 Don't use EMACS_INT for small values where int suffices.
4170 When checking for overlap, fix a typo: ZV was used where
4171 ZV_BYTE was intended.
4172 (Fwrite_region): Don't assume off_t fits into 'long'.
4173 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4174
ecfc0a49
MA
41752011-09-05 Michael Albinus <michael.albinus@gmx.de>
4176
4177 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4178
6511acf2 41792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4180
0999621a 4181 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4182
4183 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4184 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4185 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4186 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4187 (modify_event_symbol): Do not assume that the length of
4188 name_alist_or_stem is safe to alloca and fits in int.
4189 (Fexecute_extended_command): Likewise for function name and binding.
4190 (Frecursion_depth): Wrap around reliably on integer overflow.
4191 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4192 since some callers pass EMACS_INT values.
4193 (Fsingle_key_description): Don't crash if symbol name contains more
4194 than MAX_ALLOCA bytes.
4195 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4196 (get_minibuffer): Arg is now EMACS_INT, not int.
4197 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4198 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4199 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4200
2be7d702
PE
4201 * dbusbind.c (signature_cat): New function.
4202 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4203 Do not overrun buffer; instead, report string overflow.
4204
9d1df220
PE
4205 * dispnew.c (add_window_display_history): Don't overrun buffer.
4206 Truncate instead; this is OK since it's just a log.
4207
33ef5c64
PE
4208 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4209 even if the time zone offset is outlandishly large.
4210 Don't mishandle offset == INT_MIN.
4211
66c6fdd5
PE
4212 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4213 when creating daemon; the previous buffer-overflow check was incorrect.
4214
d749b01b
PE
4215 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4216 which has the guts of the old verror function.
4217
b5cd1905
PE
4218 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4219 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4220
6e1a67fb
PE
4221 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4222 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4223 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4224 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4225 length of string rather than counting it via multiple sprintfs;
4226 that's simpler and more reliable.
c21721cc
PE
4227 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4228 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4229 sprintf, in case result does not fit in int.
4230
c57b67fc
PE
4231 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4232 (fontset_from_font): Print it.
4233
8a401434
PE
4234 * frame.c (tty_frame_count): Now printmax_t, not int.
4235 (make_terminal_frame, set_term_frame_name): Print it.
4236 (x_report_frame_params): In X, window IDs are unsigned long,
4237 not signed long, so print them as unsigned.
4238 (validate_x_resource_name): Check for implausibly long names,
4239 and don't assume name length fits in 'int'.
4240 (x_get_resource_string): Don't blindly alloca invocation name;
4241 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4242 not fit in int.
4243
6e1a67fb
PE
4244 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4245 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4246 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4247
0df02bf3
PE
4248 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4249 Use esprintf, not sprintf, in case result does not fit in int.
4250
48e30793
PE
4251 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4252 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4253 it as a large positive number.
4254 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4255 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4256
a66ff6d8
PE
4257 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4258 in case result does not fit in int.
4259
aca216ff
PE
4260 * print.c (float_to_string): Detect width overflow more reliably.
4261 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4262 buffer overrun. Don't assume list length fits in 'int'. Treat
4263 print length of 0 as 0, not as infinity; to be consistent with other
4264 uses of print length in this function. Don't overflow print length
4265 index. Don't assume hash table size fits in 'long', or that
4266 vectorlike size fits in 'unsigned long'.
4267
31c286f7
PE
4268 * process.c (make_process): Use printmax_t, not int, to format
4269 process-name gensyms.
4270
55e5faa1
PE
4271 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4272
80f2e268
PE
4273 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4274 to avoid potential buffer overrun.
4275
670741ab
PE
4276 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4277 if X resource line is longer than 512 bytes.
4278
b7163a50
PE
4279 * xfns.c (x_window): Make sprintf buffer a bit bigger
4280 to avoid potential buffer overrun.
4281
ae58ff1f
PE
4282 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4283
c43c8a6a
PE
4284 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4285
3f8236f4
PE
42862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4287
53e9fe90 4288 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4289 Without these, Emacs silently mishandles large integers sometimes.
4290 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4291 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4292
6511acf2
PE
4293 * xdisp.c (try_window_id): Check Emacs fixnum range before
4294 converting to 'int'.
806add1d 4295
6511acf2 4296 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4297 Check that an Emacs fixnum is in range before assigning it to 'int'.
4298 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4299 values converted from Emacs fixnums.
4300 (Frecenter): Don't wrap around a line count if it is out of 'int'
4301 range; instead, treat it as an extreme value.
4302 (Fset_window_configuration, compare_window_configurations):
4303 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4304
6511acf2
PE
4305 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4306 that can exceed INT_MAX. Check that EMACS_INT value is in range
4307 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4308 (match_limit): Don't assume that a fixnum can fit in 'int'.
4309
6511acf2 4310 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4311 exceed INT_MAX.
4312
6511acf2 4313 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4314 (Fvertical_motion): Don't wrap around LINES values that don't fit
4315 in 'int'. Instead, treat them as extreme values. This is good
4316 enough for windows, which can't have more than INT_MAX lines anyway.
4317
fcb901a7
LMI
43182011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4319
0f2f6b6d
LMI
4320 * Require libxml/parser.h to avoid compilation warning.
4321
fcb901a7
LMI
4322 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4323
4324 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4325 since this reportedly can destroy thread storage.
4326
6e20a0d4
CY
43272011-08-30 Chong Yidong <cyd@stupidchicken.com>
4328
4329 * syntax.c (find_defun_start): Update all cache variables if
4330 exiting early (Bug#9401).
4331
148ae00e
EZ
43322011-08-30 Eli Zaretskii <eliz@gnu.org>
4333
f6cfbd8f
EZ
4334 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4335
148ae00e
EZ
4336 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4337 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4338 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4339
4340 * term.c (tty_append_glyph): New function.
4341 (produce_stretch_glyph): Static function and its prototype deleted.
4342
a66cfb1c
SM
4343 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4344 Add prototypes.
148ae00e 4345
c4a07a4c
PE
43462011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4347
4348 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4349 when checking :margin (Bug#9390).
4350 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4351 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4352 so that the name doesn't mislead. All uses changed.
4353
6bc8cd65
JB
43542011-08-28 Johan Bockgård <bojohan@gnu.org>
4355
4356 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4357 set_tty_hooks.
4358
dca4927e
EZ
43592011-08-27 Eli Zaretskii <eliz@gnu.org>
4360
4361 * xdisp.c (move_it_to): Don't bail out early when reaching
4362 position beyond to_charpos, if we are scanning backwards.
4363 (move_it_vertically_backward): When DY == 0, make sure we get to
4364 the first character in the line after the newline.
4365
f2cad773
PE
43662011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4367
4368 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4369 (ccl_driver): Do not generate an out-of-range pointer.
4370 (Fccl_execute_on_string): Remove unnecessary check for
4371 integer overflow, noted by Stefan Monnier in
4372 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4373 Remove a FIXME that didn't need fixing.
4374 Simplify the newly-introduced buffer reallocation code.
4375
0cae2cdb
JB
43762011-08-27 Juanma Barranquero <lekktu@gmail.com>
4377
4378 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4379
5fc295a4 43802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4381
70c60eb2 4382 Integer and memory overflow issues (Bug#9196).
726e0ab1 4383
d31850da
PE
4384 * doc.c (get_doc_string): Rework so that
4385 get_doc_string_buffer_size is the actual buffer size, rather than
4386 being 1 less than the actual buffer size; this makes xpalloc more
4387 convenient.
4388
a69fbedb
PE
4389 * image.c (x_allocate_bitmap_record, cache_image):
4390 * xselect.c (Fx_register_dnd_atom):
4391 Simplify previous changes by using xpalloc.
4392
fe5c5d37
PE
4393 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4394 since either will do and ptrdiff_t is convenient with xpalloc.
4395
0065d054
PE
4396 * charset.c (charset_table_size)
4397 (struct charset_sort_data.priority): Now ptrdiff_t.
4398 (charset_compare): Don't overflow if priorities differ greatly.
4399 (Fsort_charsets): Don't assume list length fits in int.
4400 Check for size-calculation overflow when allocating sort data.
4401 (syms_of_charset): Allocate an initial charset table that is
4402 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4403
4404 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4405
4406 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4407 The actual value is always <= INT_MAX, and leaving it unsigned made
4408 overflow checking harder.
4409
4410 * dispextern.h (struct glyph_matrix.rows_allocated)
4411 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4412 with xpalloc. The values are still always <= INT_MAX.
4413
4414 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4415
4416 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4417 (SAFE_NALLOCA): New macro.
4418
4419 * region-cache.c (struct boundary.pos, find_cache_boundary)
4420 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4421 (set_cache_region, invalidate_region_cache)
4422 (revalidate_region_cache, know_region_cache, region_cache_forward)
4423 (region_cache_backward, pp_cache):
4424 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4425 so that ptrdiff_t * can be passed to xpalloc.
4426 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4427 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4428 (pp_cache): Don't assume cache_len fits in int.
4429 * region-cache.h: Adjust extern decls to match.
4430
4431 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4432 EMACS_INT, since either will do, for xpalloc.
4433
4434 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4435 (xnmalloc, xnrealloc, xpalloc): New functions.
4436
726e0ab1
PE
4437 * bidi.c (bidi_shelve_header_size): New constant.
4438 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4439 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4440
51f30bc5 4441 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4442 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4443 (overlay_strings):
4444 Don't update size of array until after memory allocation succeeds,
4445 because xmalloc/xrealloc may not return.
0065d054
PE
4446 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4447 now that we have proper integer overflow checking.
4448 (record_overlay_string, overlay_strings): Catch overflows when
4449 calculating size of overlay_str_buf.
726e0ab1 4450
0065d054
PE
4451 * callproc.c (Fcall_process): Check for size overflow when
4452 calculating size of args2.
4453 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4454 Normally we prefer signed values, but sticking with ptrdiff_t would
4455 require adding more-complicated checks.
726e0ab1
PE
4456
4457 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4458 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4459 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4460 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4461
4462 * character.c (Fstring): Check for size-calculation overflow.
4463
4464 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4465 unnecessary integer overflow. Check for size overflow.
4466 (encode_coding_object): Don't update size until xmalloc succeeds.
4467
4468 * composite.c (get_composition_id): Check for overflow in glyph
4469 length calculations.
4470
4471 Integer and memory overflow fixes for display code.
4472 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4473 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4474 (scrolling_window): Check for overflow in size calculations.
4475 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4476 Don't assume glyph table len fits in int.
4477 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4478 (row_table_size): Now ptrdiff_t, not int.
4479 (scrolling_window): Avoid overflow in size calculations.
4480 Don't update size until allocation succeeds.
4481 * fns.c (concat): Check for overflow in size calculations.
4482 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4483 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4484 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4485
4486 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4487 (get_doc_string): Check for size calculation overflow.
4488 Don't update size until allocation succeeds.
4489 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4490 EMACS_INT, where ptrdiff_t will do.
4491 (Fsubstitute_command_keys): Check for string overflow.
4492
4493 * editfns.c (set_time_zone_rule): Don't assume environment length
4494 fits in int.
4495 (message_length): Now ptrdiff_t, not int.
4496 (Fmessage_box): Don't update size until allocation succeeds.
4497 Don't assume message length fits in int.
4498 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4499
0065d054
PE
4500 * emacs.c (main): Do not reallocate argv, since there is a null at
4501 the end that can be overwritten, and this way there's no need to
4502 worry about size-calculation overflow.
4503 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4504
4505 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4506 alloc succeeds.
4507 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4508
4509 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4510 (x_set_scroll_bar_width, x_figure_window_size):
4511 Check for integer overflow.
4512 (x_set_alpha): Do not assume XINT fits in int.
4513
4514 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4515 This is for the members text_lines, text_cols, total_lines, total_cols,
4516 where the system imposes an 'int' limit.
4517
4518 * fringe.c (Fdefine_fringe_bitmap):
4519 Don't update size until alloc works.
4520
4521 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4522 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4523
4524 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4525 Check for size-calculation overflow.
4526 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4527 do, as we prefer signed integers.
4528 (id_to_widget.max_size, id_to_widget.used)
4529 (xg_store_widget_in_map, xg_remove_widget_from_map)
4530 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4531 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4532 Use and return ptrdiff_t, not int.
4533 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4534 * gtkutil.h: Change prototypes to match the above.
4535
4536 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4537 are duplicate now that they've been promoted to lisp.h.
4538 (x_allocate_bitmap_record, x_alloc_image_color)
4539 (make_image_cache, cache_image, xpm_load):
4540 Don't update size until alloc is done.
4541 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4542 (x_detect_edges):
3256efce 4543 Check for size calculation overflow.
726e0ab1
PE
4544 (ct_colors_allocated_max): New constant.
4545 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4546 overflow.
3256efce 4547
726e0ab1
PE
4548 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4549 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4550 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4551 Use ptrdiff_t, not int, to count maps.
4552 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4553 calculations. Don't update size until allocation succeeds.
4554 Redo calculations to avoid overflow.
726e0ab1
PE
4555 * keyboard.h: Change prototypes to match the above.
4556
4557 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4558 to count maps.
4559 (current_minor_maps): Check for size calculation overflow.
4560 * keymap.h: Change prototypes to match the above.
4561
4562 * lread.c (read1, init_obarray): Don't update size until alloc done.
4563
4564 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4565 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4566
726e0ab1
PE
4567 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4568 Now ptrdiff_t, not int.
4569 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4570 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4571
4572 * process.c (Fnetwork_interface_list): Check for overflow
4573 in size calculation.
4574
4575 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4576
4577 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4578 overflow. Don't bother calling xmalloc when xrealloc will do.
4579
4580 * search.c (Freplace_match): Check for size calculation overflow.
4581 (Fset_match_data): Don't assume list lengths fit in 'int'.
4582
4583 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4584 for command line length. Do not attempt to address one before the
4585 beginning of an array, as that's not portable.
4586
4587 * term.c (max_frame_lines): Remove; unused.
4588 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4589 not int.
4590 (encode_terminal_code, calculate_costs): Check for size
4591 calculation overflow.
4592 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4593 table lengths and related sizes. Don't update size until alloc
4594 done. Redo calculations to avoid overflow.
4595 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4596
4597 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4598 subtracting pointers.
4599 (gobble_line): Check for overflow more carefully. Don't update size
4600 until alloc done.
4601
4602 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4603 Don't update size until alloc done.
4604 Redo size calculations to avoid overflow.
4605 Check for size calculation overflow.
0065d054 4606 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4607
4608 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4609 Use ptrdiff_t, not int, for sizes.
4610 (store_mode_line_noprop_char): Don't update size until alloc done.
4611
0065d054
PE
4612 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4613 Use ptrdiff_t, not int, for sizes.
4614 (Finternal_make_lisp_face, cache_face):
4615 Check for size calculation overflow.
4616 (cache_face): Treat size calculation overflows as if they were
4617 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4618
4619 * xfns.c (x_encode_text, x_set_name_internal)
4620 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4621 sizes, since they can exceed INT_MAX in size. Check for size
4622 calculation overflow.
4623
0065d054
PE
4624 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4625 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4626 Don't update size until alloc done.
4627
0065d054 4628 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4629 as sprintf is limited to int lengths.
1d526e2f 4630
252c5ee1
PE
4631 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4632 (X_LONG_MIN): New macros.
864d7ce7
PE
4633 Use them to make the following changes clearer.
4634 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4635 This change doesn't affect the value now, but it may help remind
4636 future maintainers not to raise the value too much later.
4637 (SELECTION_QUANTUM): Remove, replacing with ...
4638 (selection_quantum): ... new function, which avoids overflow.
4639 All uses changed.
4640 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4641 assumption that selection length fits in 'int'.
4642 (x_reply_selection_request, x_handle_selection_request)
4643 (x_get_window_property, receive_incremental_selection)
4644 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4645 (lisp_data_to_selection_data, clean_local_selection_data):
4646 Use ptrdiff_t, not int, to record length of selection.
4647 (x_reply_selection_request, x_get_window_property)
4648 (receive_incremental_selection, x_property_data_to_lisp):
4649 Redo calculations to avoid overflow.
4650 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4651 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4652 something.
4653 (x_get_window_property, receive_incremental_selection)
4654 (lisp_data_to_selection_data, x_property_data_to_lisp):
4655 Check for size-calculation overflow.
4656 (x_get_window_property, receive_incremental_selection)
4657 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4658 Don't store size until memory allocation succeeds.
4659 (x_get_window_property): Plug memory leak on memory exhaustion.
4660 Don't double-block input; malloc is safe here. Don't assume 2**34
4661 - 4 fits in unsigned long. Add an xassert to check
4662 XGetWindowProperty overflow. Be more careful about overflow
4663 calculations, and distinguish size from memory overflow better.
4664 (receive_incremental_selection): When tracing, don't assume
4665 unsigned int is less than INT_MAX.
4666 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4667 harmful) conversions of unsigned short to int.
4668 (lisp_data_to_selection_data): Don't assume that integers
4669 in the range -65535 through -1 fit in an X unsigned short.
4670 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4671 result parameters unless successful. Rely on cons_to_unsigned
4672 to report problems with elements; the old code wasn't right anyway.
4673 (x_check_property_data): Check for int overflow; we cannot use
4674 a wider type due to X limits.
4675 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4676
726e0ab1 4677 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4678
0065d054
PE
4679 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4680 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4681 (x_color_cells): Don't store size until memory allocation succeeds.
4682 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4683 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4684 (x_term_init): Don't assume length fits in int (sprintf is limited
4685 to int size).
bc18e09d 4686
ebfa62c0
PE
4687 Use ptrdiff_t for composition IDs.
4688 * character.c (lisp_string_width):
4689 * composite.c (composition_table_size, n_compositions)
4690 (get_composition_id, composition_gstring_from_id):
4691 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4692 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4693 * window.c (Frecenter):
4694 Use ptrdiff_t, not int, for composition IDs.
4695 * composite.c (get_composition_id): Check for integer overflow.
4696 * composite.h: Adjust prototypes to match the above changes.
4697
d3411f89
PE
4698 Use ptrdiff_t for hash table indexes.
4699 * category.c (hash_get_category_set):
4700 * ccl.c (ccl_driver):
4701 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4702 * coding.c (coding_system_charset_list, detect_coding_system):
4703 * coding.h (struct coding_system.id):
4704 * composite.c (get_composition_id, gstring_lookup_cache):
4705 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4706 * image.c (xpm_get_color_table_h):
4707 * lisp.h (hash_lookup, hash_put):
4708 * minibuf.c (Ftest_completion):
4709 Use ptrdiff_t for hash table indexes, not int (which is too
4710 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4711 32-bit --with-wide-int hosts).
4712
e097a6fa
PE
4713 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4714 Add a FIXME comment about memory leaks.
4715 (syms_of_charset): Don't assume xmalloc returns.
4716
5637687f
PE
4717 Don't assume that stated character widths fit in int.
4718 * character.c (Fchar_width, c_string_width, lisp_string_width):
4719 * character.h (CHAR_WIDTH):
4720 * indent.c (MULTIBYTE_BYTES_WIDTH):
4721 Use sanitize_char_width to avoid undefined and/or bad behavior
4722 with outlandish widths.
a66cfb1c 4723 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4724 now that we have two such functions. All uses changed.
4725 (sanitize_char_width): New inline function.
4726
a2271ba2
PE
4727 Don't assume that tab-width fits in int.
4728 * character.h (sanitize_width): New inline function.
4729 (SANE_TAB_WIDTH): New macro.
4730 (ASCII_CHAR_WIDTH): Use it.
4731 * indent.c (sane_tab_width): Remove. All uses replaced by
4732 SANE_TAB_WIDTH (current_buffer).
4733 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4734
18c52557
PE
4735 * fileio.c: Integer overflow issues with file modes.
4736 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4737
caeeedc1
PE
4738 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4739 Remove unreachable code.
4740 (read_hex, load_charset_map_from_file): Check for integer overflow.
4741
6df6ae42 4742 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4743 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4744 (x_send_scroll_bar_event): Likewise. Check that the size does not
4745 exceed limits imposed by XClientMessageEvent, as well as the usual
4746 ptrdiff_t and size_t limits.
4747
b13995db
PE
4748 * keyboard.c: Overflow, signedness and related fixes.
4749 (make_lispy_movement): Use same integer type in forward decl
4750 that is used in the definition.
4751 (read_key_sequence, keyremap_step):
4752 Change bufsize argument back to int, undoing my 2011-03-30 change.
4753 We prefer signed types, and int is wide enough here.
4754 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4755 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4756 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4757 length, not size_t. Use ptrdiff_t for index, not int.
4758 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4759 possibility of integer overflow.
4760
13464394
PE
4761 Overflow, signedness and related fixes for images.
4762
4763 * dispextern.h (struct it.stack[0].u.image.image_id)
4764 (struct_it.image_id, struct image.id, struct image_cache.size)
4765 (struct image_cache.used, struct image_cache.ref_count):
4766 * gtkutil.c (update_frame_tool_bar):
4767 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4768 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4769 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4770 * nsmenu.m (update_frame_tool_bar):
4771 * xdisp.c (calc_pixel_width_or_height):
4772 * xfns.c (image_cache_refcount):
4773 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4774 on typical 64-bit hosts.
4775
4776 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4777 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4778 Omit unnecessary casts to int.
4779 (parse_image_spec): Check that integers fall into 'int' range
4780 when the callers expect that.
4781 (image_ascent): Redo ascent calculation to avoid int overflow.
4782 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4783 (lookup_image): Remove unnecessary tests.
4784 (xbm_image_p): Locals are now of int, not EMACS_INT,
4785 since parse_image_check makes sure they fit into int.
4786 (png_load, gif_load, svg_load_image):
4787 Prefer int to unsigned where either will do.
4788 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4789 old tiff_error_handler and tiff_warning_handler.
4790 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4791 stack buffer overflows. It uses only the features of vsnprintf
4792 that are common to both POSIX and native Microsoft.
4793 (tiff_error_handler, tiff_warning_handler): Use it.
4794 (tiff_load, gif_load, imagemagick_load_image):
4795 Don't assume :index value fits in 'int'.
4796 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4797 (imagemagick_load_image): Check that crop parameters fit into
4798 the integer types that MagickCropImage accepts. Don't assume
4799 Vimagemagick_render_type has a nonnegative value. Don't assume
4800 size_t fits in 'long'.
4801 (gs_load): Use printmax_t to print the widest integers possible.
4802 Check for integer overflow when computing image height and width.
4803
c11821d4
EZ
48042011-08-26 Eli Zaretskii <eliz@gnu.org>
4805
4806 * xdisp.c (redisplay_window): Don't force window start if point
4807 will be invisible in the resulting window. (Bug#9324)
4808
0c95fcf7
EZ
48092011-08-25 Eli Zaretskii <eliz@gnu.org>
4810
4811 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4812 the display spec is of the form `(space ...)'.
4813 (handle_display_spec): Return the value returned by
4814 handle_single_display_spec, not just 1 or zero.
4815 (handle_single_display_spec): If the display spec is of the form
4816 `(space ...)', and specifies display in the text area, return 2
4817 rather than 1.
fee65a97 4818 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4819 accurately, and prefer exact match for point under bidi.
4820 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4821
4822 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4823 into disp_prop; all users changed.
4824
4825 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4826 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4827 for the text covered by the display property.
4828
e4ed06f1
CY
48292011-08-25 Chong Yidong <cyd@stupidchicken.com>
4830
4831 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4832 Change return value to nil.
4833 (Frecord_buffer): Delete unused function.
4834
f67cdd7f
EZ
48352011-08-24 Eli Zaretskii <eliz@gnu.org>
4836
5980d4c6
EZ
4837 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4838 buffers, return left-to-right.
8610fe8b
EZ
4839 (set_cursor_from_row): Consider candidate row a win if its glyph
4840 represents a newline and point is on that newline. Fixes cursor
4841 positioning on the newline at EOL of R2L text within L2R
4842 paragraph, and vice versa.
4843 (try_cursor_movement): Check continued rows, in addition to
4844 continuation rows. Fixes unwarranted scroll when point enters a
4845 continued line of R2L text within an L2R paragraph, or vice versa.
4846 (cursor_row_p): Consider the case of point being equal to
4847 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4848 from the end of a short line to the beginning of a continued line
4849 of R2L text within L2R paragraph.
4850 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4851 composed characters.
5980d4c6 4852
f67cdd7f
EZ
4853 * bidi.c (bidi_check_type): Use xassert.
4854 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4855 members.
4856
bca633fb
EZ
48572011-08-23 Eli Zaretskii <eliz@gnu.org>
4858
4859 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4860 a character.
4861
4a5885a7
CY
48622011-08-23 Chong Yidong <cyd@stupidchicken.com>
4863
4864 * nsfont.m (ns_otf_to_script): Fix typo.
4865
0902a04e
KH
48662011-08-22 Kenichi Handa <handa@m17n.org>
4867
4868 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4869 extra slot even if the purpose is char-code-property-table.
4870
1a2e6670
EZ
48712011-08-23 Eli Zaretskii <eliz@gnu.org>
4872
8ddde651
EZ
4873 * xdisp.c (redisplay_window): When computing centering_position,
4874 account for the height of the header line. (Bug#8874)
4875
425cc014
EZ
4876 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4877 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4878 candidate is selected by the mouse, and that candidate has a
4879 composed character under the mouse.
4880
1a2e6670
EZ
4881 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4882 coordinates reported by pos-visible-in-window-p for a composed
4883 character in column zero.
4884
8b76d6f8
SM
48852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4886
4887 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4888
dac347dd
EZ
48892011-08-22 Eli Zaretskii <eliz@gnu.org>
4890
4891 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4892 consider it a hit if to_charpos is anywhere in the range of the
4893 composed buffer positions.
4894
e013fb34
CY
48952011-08-22 Chong Yidong <cyd@stupidchicken.com>
4896
4897 * image.c (gif_load): Don't assume that each subimage has the same
4898 dimensions as the base image. Handle disposal method that is
4899 "undefined" by the gif spec (Bug#9335).
4900
bd1ba3e8
CY
49012011-08-20 Chong Yidong <cyd@stupidchicken.com>
4902
4903 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4904 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4905
54a1215b
EZ
49062011-08-19 Eli Zaretskii <eliz@gnu.org>
4907
823564e5
EZ
4908 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4909 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4910 from an Org mode buffer to a Speedbar frame.
4911
54a1215b
EZ
4912 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4913 a composition, take its buffer position from IT->cmp_it.charpos.
4914 Fixes cursor positioning at the beginning of a line that begins
4915 with a composed character.
4916
9778ebcc
EZ
49172011-08-18 Eli Zaretskii <eliz@gnu.org>
4918
0be6ee06
EZ
4919 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4920 character bidirectional type, use STRONG_L instead. Fixes crashes
4921 in a buffer produced by `describe-categories'.
4922
9778ebcc
EZ
4923 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4924 members before the level stack, so they would be saved and
4925 restored when copying iterator state. Fixes incorrect reordering
4926 around TABs covered by display properties.
4927
156bffbe
AS
49282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4929
6b02f655 4930 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4931
72ad093b
CY
49322011-08-17 Chong Yidong <cyd@stupidchicken.com>
4933
4934 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4935 (internal_condition_case_2, internal_condition_case_n):
4936 Remove unnecessary aborts (Bug#9081).
72ad093b 4937
35774242
EZ
49382011-08-17 Eli Zaretskii <eliz@gnu.org>
4939
4940 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4941 has no `load' handler, try opening the file locally. (Bug#9311)
4942
db76dd85
KB
49432011-08-16 Ken Brown <kbrown@cornell.edu>
4944
4945 * gmalloc.c: Expand comment.
4946
b215eee5
EZ
49472011-08-16 Eli Zaretskii <eliz@gnu.org>
4948
4949 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4950 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4951
a4579d33
KB
49522011-08-16 Ken Brown <kbrown@cornell.edu>
4953
4954 Fix memory allocation problems in Cygwin build (Bug#9273).
4955
4956 * unexcw.c ( __malloc_initialized): Declare external variable.
4957 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4958
8b76d6f8
SM
4959 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4960 New variables.
a4579d33
KB
4961 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4962 dumped emacs.
4963 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4964 in the static heap.
4965 [CYGWIN] (special_realloc): New function.
4966 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4967 requests to realloc storage in the static heap.
4968
3ebec551
PE
49692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4970
4971 * bidi.c (bidi_initialize): Remove unused local.
4972
9fd8be00
EZ
49732011-08-15 Eli Zaretskii <eliz@gnu.org>
4974
6b02f655
SM
4975 * bidimirror.h:
4976 * biditype.h: Remove file.
4977 * makefile.w32-in ($(BLD)/bidi.$(O)):
4978 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4979
4980 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4981
4982 * chartab.c: Improve commentary for the uniprop_table API.
4983
32413314
EZ
4984 * bidi.c (bidi_paragraph_init): Support zero value of
4985 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4986 (bidi_initialize): Use uniprop_table instead of including
4987 biditype.h and bidimirror.h.
32413314 4988
9fd8be00
EZ
4989 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4990 coordinates of the iterator when restoring from ppos_it.
4991 (Bug#9296)
4992
5cf2b69b
KH
49932011-08-14 Kenichi Handa <handa@m17n.org>
4994
4995 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4996 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4997
daf17d00
EZ
49982011-08-14 Eli Zaretskii <eliz@gnu.org>
4999
5000 * xdisp.c (move_it_in_display_line_to): Don't invoke
5001 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5002 ppos_it. Fixes vertical cursor motion when line beginning is
5003 covered by an image. (Bug#9296)
5004
08e3161a
JD
50052011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5006
5007 * nsterm.h (ns_run_ascript): Declare.
5008 (NSAPP_DATA2_RUNASSCRIPT): Define.
5009
5010 * nsfns.m (as_script, as_result, as_status): New static variables.
5011 (ns_run_ascript): New function.
5e617bc2 5012 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5013 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5014 the event loop. Get status from as_status (Bug#7276).
5015
5016 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5017 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5018 the event loop (Bug#7276).
5019
a3720aa2
AS
50202011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5021
5022 * gnutls.c (QCgnutls_bootprop_priority)
5023 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5024 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5025 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5026 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5027 (QCgnutls_bootprop_verify_hostname_error)
5028 (QCgnutls_bootprop_callbacks_verify): Rename from
5029 Qgnutls_bootprop_..., all uses changed.
5030
5031 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5032 uses changed.
5033
0a0d27fb
PE
50342011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5035
19d5c50c
PE
5036 * xfaces.c (Qframe_set_background_mode): Now static.
5037 * dispextern.h (Qframe_set_background_mode): Remove decl.
5038
0a0d27fb
PE
5039 * process.c (Fnetwork_interface_info): Declare local only if needed.
5040
377538cb
JD
50412011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5042
5043 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5044 (Fnetwork_interface_list): Allocate in increments of bytes instead
5045 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5046 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5047 sockaddr.
5048 (struct ifflag_def): notrailers is smart on OSX.
5049 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5050 Get hardware address with getifaddrs if available.
5051
08fff70c
EZ
50522011-08-12 Eli Zaretskii <eliz@gnu.org>
5053
5054 * xdisp.c (iterate_out_of_display_property): xassert that
5055 IT->position is set to within IT->object's boundaries. Break from
5056 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5057 when IT->position is set up wrongly due to some bug.
5058 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5059 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5060 entry. Force push_it to save on the stack the current
5061 buffer/string position, to be restored by pop_it. Fix flags in
5062 the iterator structure wrt the object coming from a display
5063 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5064 properties. (Bug#9284)
5065
7be1c708 50662011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5067
7be1c708
CY
5068 * fontset.c (fontset_get_font_group): Add proper type checks.
5069 (Bug#9172)
aac0c6e3 5070
7be1c708 50712011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5072
7be1c708
CY
5073 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5074 and LC_VERSION_MIN_MACOSX.
5075 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5076 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5077
97bb72a6
EZ
50782011-08-08 Eli Zaretskii <eliz@gnu.org>
5079
5080 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5081 no-display-properties-and-no-overlays under bidi display.
5082 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5083 properties and overlays.
97bb72a6 5084
d5617611
CY
50852011-08-08 Chong Yidong <cyd@stupidchicken.com>
5086
37e11a63
CY
5087 * editfns.c (Fset_time_zone_rule): Document relationship with the
5088 setenv function.
5089
d5617611
CY
5090 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5091 the font entity extracted from the cache (Bug#8109).
5092
58872834
CY
50932011-08-07 Chong Yidong <cyd@stupidchicken.com>
5094
5095 * composite.c (autocmp_chars): Don't reset point. That is done by
5096 restore_point_unwind (Bug#5984).
5097
75bfc667
JL
50982011-08-07 Juri Linkov <juri@jurta.org>
5099
5100 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5101 to show the arg `TIME' instead of `TIMEVAL'.
5102
d1410150
EZ
51032011-08-06 Eli Zaretskii <eliz@gnu.org>
5104
5105 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5106 display property strides EOL and includes a newline, as in
5107 longlines-mode. (Bug#9254)
75b771e4
EZ
5108 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5109 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5110
5111 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5112 is non-zero, even if the data buffer is NULL. Fixes a crash in
5113 vertical-motion with longlines-mode. (Bug#9254)
5114
35928349
EZ
51152011-08-05 Eli Zaretskii <eliz@gnu.org>
5116
ec7cc85b
EZ
5117 * bidi.c <bidi_cache_total_alloc>: Now static.
5118 (bidi_initialize): Initialize bidi_cache_total_alloc.
5119
8b76d6f8 5120 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5121 cache. (Bug#9221)
5122
5123 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5124 amount allocated this far in `bidi_cache_total_alloc'.
5125 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5126 non-zero, only free the data buffer without restoring the cache
5127 contents. All callers changed.
5128
5129 * dispextern.h (bidi_unshelve_cache): Update prototype.
5130
5131 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5132 (move_it_in_display_line, move_it_to)
5133 (move_it_vertically_backward, move_it_by_lines): Replace the call
5134 to xfree to an equivalent call to bidi_unshelve_cache.
5135 (move_it_in_display_line_to): Fix logic of returning
412b6358 5136 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5137
e2e2423b
EZ
51382011-08-05 Eli Zaretskii <eliz@gnu.org>
5139
5140 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5141 came from a string character with a `cursor' property. (Bug#9229)
5142
ae9e757a
JD
51432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5144
5145 * Makefile.in (LIB_PTHREAD): New variable.
5146 (LIBES): Add LIB_PTHREAD (Bug#9216).
5147
5148 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5149 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5150
213bd7f2
AS
51512011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5152
6b02f655 5153 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5154
99aaf75f
JD
51552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5156
5157 * xterm.c (x_find_topmost_parent): New function.
5158 (x_set_frame_alpha): Find topmost parent window with
5159 x_find_topmost_parent and set the property there also (bug#9181).
5160 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5161
c74e9d86
PE
51622011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5163
5164 * callproc.c (Fcall_process): Avoid vfork clobbering
5165 the local vars buffer, coding_systems, current_dir.
5166
640c8776
SM
51672011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5168
5169 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5170
f26d0e4c
PE
51712011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5172
8a10d76c
PE
5173 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5174 so that it is not optimized away.
5175
f26d0e4c
PE
5176 * xdisp.c (compute_display_string_pos): Remove unused local.
5177
55439c61
EZ
51782011-08-02 Eli Zaretskii <eliz@gnu.org>
5179
5180 Fix slow cursor motion and scrolling in large buffers with
5181 selective display, like Org Mode buffers. (Bug#9218)
5182
5183 * dispextern.h (struct bidi_it): New member disp_prop_p.
5184
5185 * xdisp.c: Remove one-slot cache of display string positions.
5186 (compute_display_string_pos): Accept an additional argument
5e617bc2 5187 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5188 for a display string or property. If found, set DISP_PROP_P
5189 non-zero.
5190
5191 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5192 DISP_PROP_P, and pass it to compute_display_string_pos.
5193 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5194 non-zero. All callers of bidi_fetch_char changed.
5195
fb33fa43
SM
51962011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5197
5198 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5199
b099e063
DM
52002010-12-03 Don March <don@ohspite.net>
5201
5202 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5203 last character M-[char] is translated to ESC [char] (bug#7541).
5204
5cc7f7af
KH
52052011-08-02 Kenichi Handa <handa@m17n.org>
5206
d0fffa3f 5207 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5208
5209 * chartab.c (uniprop_table): Make it non-static.
5210
525d5e6e
EZ
52112011-08-01 Eli Zaretskii <eliz@gnu.org>
5212
5213 * xdisp.c (forward_to_next_line_start): Accept additional argument
5214 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5215 on the newline.
5216 (reseat_at_next_visible_line_start): Use the bidi iterator state
5217 returned by forward_to_next_line_start to restore the state of
5218 it->bidi_it after backing up to previous newline. (Bug#9212)
5219
31011111
AS
52202011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5221
5222 * regex.c (re_comp): Protoize.
5223 (re_exec): Fix return type.
5224 (regexec): Fix type of `ret'. (Bug#9203)
5225
476371c4
PE
52262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5227
e5d76069
PE
5228 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5229 This is needed if max-image-size is a floating-point number.
5230
9a79b20c
AS
52312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5232
5233 * print.c (print_object): Print empty symbol as ##.
5234
5235 * lread.c (read1): Read ## as empty symbol.
5236
d8c2fa78
AA
52372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5238
5239 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5240 setting frame foreground color (Bug#9175).
5241 (x_set_background_color): Likewise.
5242
ffe57a7a
AA
5243 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5244 contents (Bug#9176).
5245 (EmacsTooltip -init): Remove bezels and add shadows to
5246 tooltip windows.
5247
bf3492a5
AA
5248 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5249 or scroll bar (Bug#8470).
5250
d55e9c53
AA
5251 * nsfont.m (nsfont_open): Remove assignment to voffset and
5252 unnecessary vars hshink, expand, hd, full_height, min_height.
5253 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5254
5255 * nsterm.h (nsfont_info): Remove voffset field.
5256
d8c2fa78 52572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5258
5259 Implement strike-through and overline on NextStep (Bug#8863).
5260
5261 * nsfont.m (nsfont_open): Use underline position provided by font,
5262 instead of hard-coded value of 2.
5263 (nsfont_draw): Call ns_draw_text_decoration instead.
5264
5265 * nsterm.h: Add declaration for ns_draw_text_decoration.
5266
5267 * nsterm.m (ns_draw_text_decoration): New function for drawing
5268 underline, overline, and strike-through.
5269 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5270 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5271 accommodate underlining, etc.
4843aac3 5272
4cc60b9b
EZ
52732011-07-28 Eli Zaretskii <eliz@gnu.org>
5274
bc7ece87
EZ
5275 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5276 default.
4cc60b9b 5277
476371c4
PE
52782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5279
66606eea
PE
5280 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5281 Without this fix, if a signal arrives just after memory fills up,
5282 'malloc' might be invoked reentrantly.
5283
476371c4
PE
5284 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5285 In other words, assume that every image size is allowed, on non-X
5286 hosts. This assumption is probably wrong, but it lets Emacs compile.
5287
f3fcc40d
AS
52882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5289
5290 * regex.c (re_iswctype): Convert return values to boolean.
5291
350c992f
EZ
52922011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5293
5294 * xdisp.c (compute_display_string_pos): Don't use cached display
5295 string position if the buffer had its restriction changed.
5296 (Bug#9184)
5297
5266b4bb
PE
52982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5299
5300 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5301
2573a837 53022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5303
41f55ccd 5304 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5305
39e378da
PE
5306 * bidi.c: Integer size and overflow fixes.
5307 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5308 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5309 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5310 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5311 (bidi_find_other_level_edge):
5312 Use ptrdiff_t instead of EMACS_INT where either will do.
5313 This works better on 32-bit hosts configured --with-wide-int.
5314 (bidi_cache_ensure_space): Check for size-calculation overflow.
5315 Use % rather than repeated addition, for better worst-case speed.
5316 Don't set bidi_cache_size until after xrealloc returns, because it
5317 might not return.
5318 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5319 (bidi_cache_ensure_space): Also check that the bidi cache size
5320 does not exceed that of the largest Lisp string or buffer. See Eli
5321 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5322
5e927815
PE
5323 * alloc.c (__malloc_size_t): Remove.
5324 All uses replaced by size_t. See Andreas Schwab's note
5325 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5326
ca4aa935
PE
5327 * image.c: Improve checking for integer overflow.
5328 (check_image_size): Assume that f is nonnull, since
5329 it is always nonnull in practice. This is one less thing to
5330 worry about when checking for integer overflow later.
5331 (x_check_image_size): New function, which checks for integer
5332 overflow issues inside X.
5333 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5334 This removes the need for a memory_full check.
5335 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5336 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5337 (xbm_read_bitmap_data): Change locals back to 'int', since
5338 their values must fit in 'int'.
5339 (xpm_load_image, png_load, tiff_load):
5340 Invoke x_create_x_image_and_pixmap earlier,
5341 to avoid much needless work if the image is too large.
5342 (tiff_load): Treat overly large images as if
5343 x_create_x_image_and_pixmap failed, not as malloc failures.
5344 (gs_load): Use x_check_image_size.
5345
5f8f9cc2
PE
5346 * gtkutil.c: Omit integer casts.
5347 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5348 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5349
5adf60bc
PE
5350 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5351
c8907a93
PE
5352 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5353 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5354 would wrongly return t on a 64-bit host.
5355
e3c25c68
PE
5356 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5357 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5358 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5359 and therefore cause GCC to emit a bogus diagnostic in some cases.
5360
3f791afe
PE
5361 * image.c: Integer signedness and overflow and related fixes.
5362 This is not an exhaustive set of fixes, but it's time to
5363 record what I've got.
5364 (lookup_pixel_color, check_image_size): Remove redundant decls.
5365 (check_image_size): Don't assume that arbitrary EMACS_INT values
5366 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5367 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5368 (tiff_load, imagemagick_load_image):
5369 Check for overflow in size calculations.
5370 (x_create_x_image_and_pixmap): Remove unnecessary test for
5371 xmalloc returning NULL; that can't happen.
5372 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5373 (xpm_color_bucket): Use better integer hashing function.
5374 (xpm_cache_color): Don't possibly over-allocate memory.
5375 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5376 (gif_memory_source):
5377 Use ptrdiff_t, not int or size_t, to record sizes.
5378 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5379 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5380 either works, as we prefer signed integers.
5381 (tiff_read_from_memory, tiff_write_from_memory):
5382 Return tsize_t, not size_t, since that's what the TIFF API wants.
5383 (tiff_read_from_memory): Don't fail simply because the read would
5384 go past EOF; instead, return a short read.
5385 (tiff_load): Omit no-longer-needed casts.
5386 (Fimagemagick_types): Don't assume size fits into 'int'.
5387
3cc5a532
PE
5388 Improve hashing quality when configured --with-wide-int.
5389 * fns.c (hash_string): New function, taken from sxhash_string.
5390 Do not discard information about ASCII character case; this
5391 discarding is no longer needed.
5392 (sxhash-string): Use it. Change sig to match it. Caller changed.
5393 * lisp.h: Declare it.
5394 * lread.c (hash_string): Remove, since we now use fns.c's version.
5395 The fns.c version returns a wider integer if --with-wide-int is
5396 specified, so this should help the quality of the hashing a bit.
5397
b312a492
PE
5398 * emacs.c: Integer overflow minor fix.
5399 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5400 Define only if GNU_LINUX.
5401 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5402
dfd153ae
PE
5403 * dispnew.c: Integer signedness and overflow fixes.
5404 Remove unnecessary forward decls, that were a maintenance hassle.
5405 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5406 All uses changed.
5407 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5408 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5409 (prepare_desired_row, line_draw_cost):
5410 Use int, not unsigned, where either works.
5411 (save_current_matrix, restore_current_matrix):
5412 Use ptrdiff_t, not size_t, where either works.
5413 (init_display): Check for overflow more accurately, and without
5414 relying on undefined behavior.
5415
a81d11a3
PE
5416 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5417 Remove, replacing with the new symbols in lisp.h. All uses changed.
5418 * fileio.c (make_temp_name):
5419 * filelock.c (lock_file_1, lock_file):
5420 * xdisp.c (message_dolog):
5421 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5422 Use pMd etc. instead.
5423 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5424 replacing the pWIDE etc. symbols removed from editfns.c.
5425
3300e6fd
PE
5426 * keyboard.h (num_input_events): Now uintmax_t.
5427 This is (very slightly) less likely to mess up due to wraparound.
5428 All uses changed.
5429
fd05c7e9
PE
5430 * buffer.c: Integer signedness fixes.
5431 (alloc_buffer_text, enlarge_buffer_text):
5432 Use ptrdiff_t rather than size_t when either will do, as we prefer
5433 signed integers.
5434
903fe15d
PE
5435 * alloc.c: Integer signedness and overflow fixes.
5436 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5437 (__malloc_size_t): Default to size_t, not to int.
5438 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5439 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5440 Prefer ptrdiff_t to size_t when either would do, as we prefer
5441 signed integers.
5442 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5443 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5444 Now const. Initialize with values that are in range even if char
5445 is signed.
5446 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5447 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5448 These functions do the right thing with sizes > 2**32.
5449 (check_depth): Now ptrdiff_t, not int.
5450 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5451 Adjust to new way of storing sizes. Check for size overflow bugs
5452 in rest of code.
5453 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5454 slightly wrong anyway, as it missed one instance of
5455 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5456 (refill_memory_reserve): Omit needless cast to size_t.
5457 (mark_object_loop_halt): Mark as externally visible.
5458
ac82cc6a
PE
5459 * xselect.c: Integer signedness and overflow fixes.
5460 (Fx_register_dnd_atom, x_handle_dnd_message):
5461 Use ptrdiff_t, not size_t, since we prefer signed.
5462 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5463 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5464 x_dnd_atoms_size and x_dnd_atoms_length.
5465
c2d1e36d
PE
5466 * doprnt.c: Prefer signed to unsigned when either works.
5467 * eval.c (verror):
5468 * doprnt.c (doprnt):
5469 * lisp.h (doprnt):
5470 * xdisp.c (vmessage):
5471 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5472 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5473 prefer signed arithmetic to avoid comparison confusion.
5474 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5475 but is a bit tricky.
5476
0e926e56
PE
5477 Assume freestanding C89 headers, string.h, stdlib.h.
5478 * data.c, doprnt.c, floatfns.c, print.c:
5479 Include float.h unconditionally.
5480 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5481 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5482 * regex.c: Likewise for stddef.h, string.h.
5483 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5484 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5485 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5486 (STDC_HEADERS): Remove obsolete defines.
5487 * sysdep.c: Include limits.h unconditionally.
5488
9cfdb3ec
PE
5489 Assume support for memcmp, memcpy, memmove, memset.
5490 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5491 * regex.c (memcmp, memcpy):
5492 Remove; we assume C89 now.
5493
5494 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5495 (__malloc_safe_bcopy): Remove; no longer needed.
5496
cf950e6b 5497 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5498 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5499 well either way, and we prefer signed to unsigned.
5500
dbf38e02
LMI
55012011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5502
5503 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5504 closes the connection while we're reading (bug#9182).
5505
d6f0886c 55062011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5507
d6f0886c
JD
5508 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5509 are specified (Bug#9168).
24e0f6b1 5510
2eb1f9e6
PE
55112011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5512
5513 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5514 Found by GCC static checking and --with-wide-int on a 32-bit host.
5515
22381272 55162011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5517
5518 * xdisp.c (compute_display_string_pos): Fix logic of caching
5519 previous display string position. Initialize cached_prev_pos to
5520 -1. Fixes slow-down at the beginning of a buffer.
5521
f25e39b4
EZ
55222011-07-24 Eli Zaretskii <eliz@gnu.org>
5523
5524 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5525 for attrs[LFACE_FONTSET_INDEX].
5526
04c4b52e
PE
55272011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5528
5529 * xml.c (parse_region): Remove unused local
5530 that was recently introduced.
5531
c1734fbd
EZ
55322011-07-23 Eli Zaretskii <eliz@gnu.org>
5533
be18c5a5
EZ
5534 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5535 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5536
c1734fbd
EZ
5537 * xdisp.c (move_it_in_display_line_to): Record the best matching
5538 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5539 exit if none of the characters scanned was an exact match.
5540 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5541 when exact match is impossible due to invisible text, and the
5542 lines are truncated.
5543
a258d627
JD
55442011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5545
5546 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5547 for OSX >= 10.7.
5548
b6d5a689
EZ
55492011-07-22 Eli Zaretskii <eliz@gnu.org>
5550
0f74f785
EZ
5551 Fix a significant slow-down of cursor motion with C-n, C-p,
5552 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5553 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5554 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5555 (next_element_from_buffer): Call compute_stop_pos_backwards to
5556 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5557 base_level_stop.
5558 (reseat): Don't look for prev_stop, as that could mean a very long
5559 run.
5560 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5561 <cached_disp_overlay_modiff>: Cache for last found display string
5562 position.
551918c1 5563 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5564 about the same buffer in the same area of character positions, and
5565 the buffer wasn't changed since the time the display string
5566 position was cached.
551918c1 5567
b2d0c91a
EZ
55682011-07-22 Eli Zaretskii <eliz@gnu.org>
5569
5570 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5571 is an integer, which is important for empty lines. (Bug#9149)
5572
043604ee
CY
55732011-07-22 Chong Yidong <cyd@stupidchicken.com>
5574
5575 * frame.c (Fmodify_frame_parameters): In tty case, update the
5576 default face if necessary (Bug#4238).
5577
da4adb04
CY
55782011-07-21 Chong Yidong <cyd@stupidchicken.com>
5579
5580 * editfns.c (Fstring_to_char): No need to explain what a character
5581 is in the docstring (Bug#6576).
5582
9abd0532
LMI
55832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5584
5585 * xml.c (parse_region): Make sure we always return a tree.
5586
36881d16
HK
55872011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5588
5589 * xml.c (parse_region): If a document contains only comments,
5590 return that, too.
5591
1e98674d
LMI
55922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5593
5594 * xml.c (make_dom): Return comments, too.
5595
590bd467
PE
55962011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5597
5598 Port to OpenBSD.
5599 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5600 and the surrounding thread.
5601 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5602 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5603 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5604 timer goes off.
5605 * s/openbsd.h (BROKEN_SIGIO): Define.
5606 * unexelf.c (unexec) [__OpenBSD__]:
5607 Don't update the .mdebug section of the Alpha COFF symbol table.
5608
f41628b2
LMI
56092011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5610
5611 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5612 (bug#8460).
5613
b59b67c5
PE
56142011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5615
15e3a074
PE
5616 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5617 This fixes some race conditions on the permissions of any newly
5618 created file.
5619
41bed37d
PE
5620 * alloc.c (valid_pointer_p): Use pipe, not open.
5621 This fixes some permissions issues when debugging.
5622
b59b67c5
PE
5623 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5624 If fchown fails to set both uid and gid, try to set just gid,
5625 as that is sometimes allowed. Adjust the file's mode to eliminate
5626 setuid or setgid bits that are inappropriate if fchown fails.
5627
925a6be7
SM
56282011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5629
5630 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5631 to compare Lisp_Objects.
5632 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5633 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5634 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5635
52968808
AS
56362011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5637
0a6a104b
AS
5638 * lread.c (read_integer): Unread even EOF character.
5639 (read1): Likewise. Properly record start position of symbol.
5640
52968808
AS
5641 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5642 symbol character follows.
5643
9e381cdd
PE
56442011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5645
5646 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5647 This works around a problem with the previous change to Fcopy_file.
5648 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5649 and without this change, GCC might complain about discarding
5650 fchown's return value.
5651
b5641435
JB
56522011-07-16 Juanma Barranquero <lekktu@gmail.com>
5653
5654 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5655
a8031457
PE
56562011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5657
5658 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5659
dd889327
LMI
56602011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5661
750c33f7
LMI
5662 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5663 it's used from the C level.
5664
dd889327
LMI
5665 * process.c: Use the same condition for POLL_FOR_INPUT in both
5666 keyboard.c and process.c (bug#1858).
5667
87e86684
LM
56682011-07-09 Lawrence Mitchell <wence@gmx.li>
5669
5670 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5671 (Fgnutls_boot): Use it.
5672
64348f40
AS
56732011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5674
5675 * doc.c (Fsubstitute_command_keys): Revert last change.
5676
1d698799
LMI
56772011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5678
f863868c
LMI
5679 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5680 quotes the next character, and doesn't affect other longer
5681 sequences (bug#8935).
5682
1d698799
LMI
5683 * lread.c (syms_of_lread): Clarify that is isn't only
5684 `eval-buffer' and `eval-defun' that's affected by
5685 `lexical-binding' (bug#8460).
5686
aa4b6df6
EZ
56872011-07-15 Eli Zaretskii <eliz@gnu.org>
5688
5689 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5690 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5691
5d856da6
PE
56922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5693
ad6042bb
PE
5694 Fix minor problems found by static checking.
5695 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5696 (elsz): Now a signed constant, not a size_t var. We prefer signed
5697 types to unsigned, to avoid integer comparison confusion. Without
5698 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5699 "cannot optimize loop, the loop counter may overflow", a symptom
5700 of the confusion.
f00bbb22 5701 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5702 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5703
6468f31c
LMI
57042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5705
49080b10
LMI
5706 * search.c (Fre_search_backward): Mention `case-fold-search' in
5707 all the re_search_* functions (bug#8138).
5708
6468f31c
LMI
5709 * keyboard.c (Fopen_dribble_file): Document when the file is
5710 closed (bug#8056).
5711
c965adc5
EZ
57122011-07-14 Eli Zaretskii <eliz@gnu.org>
5713
df9733bf
EZ
5714 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5715 bidi_cache_idx.
5716
0bb23927
EZ
5717 Support bidi reordering of display and overlay strings.
5718 * xdisp.c (compute_display_string_pos)
5719 (compute_display_string_end): Accept additional argument STRING.
5720 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5721 (reseat_to_string): Initialize bidi_it->string.s and
5722 bidi_it->string.schars.
5723 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5724 NULL (avoids a crash in bidi_paragraph_init).
5725 Initialize itb.string.lstring.
0bb23927
EZ
5726 (init_iterator): Call bidi_init_it only of a valid
5727 buffer position was specified. Initialize paragraph_embedding to
5728 L2R.
5729 (reseat_to_string): Initialize the bidi iterator.
5730 (display_string): If we need to ignore text properties of
5731 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5732 original value of -1 will not work with bidi.)
5733 (compute_display_string_pos): First arg is now struct
5734 `text_pos *'; all callers changed. Support display properties on
5735 Lisp strings.
5736 (compute_display_string_end): Support display properties on Lisp
5737 strings.
5738 (init_iterator, reseat_1, reseat_to_string): Initialize the
5739 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5740 when iterating on a string not from display properties).
640c8776
SM
5741 (compute_display_string_pos, compute_display_string_end):
5742 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5743 arrow keys.
5744 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5745 base_level_stop; instead, set base_level_stop to BEGV.
5746 Fixes crashes in vertical-motion.
0bb23927
EZ
5747 (next_element_from_buffer): Improve commentary for when
5748 the iterator is before prev_stop.
5749 (init_iterator): Initialize bidi_p from the default value of
5750 bidi-display-reordering, not from buffer-local value. Use the
5751 buffer-local value only if initializing for buffer iteration.
5752 (handle_invisible_prop): Support invisible properties on strings
5753 that are being bidi-reordered.
5754 (set_iterator_to_next): Support bidi reordering of C strings and
5755 Lisp strings.
5756 (next_element_from_string): Support bidi reordering of Lisp
5757 strings.
5758 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5759 (display_string): Support display of R2L glyph rows.
5760 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5761 (init_iterator): Don't initialize it->bidi_p for strings
5762 here.
5763 (reseat_to_string): Initialize it->bidi_p for strings here.
5764 (next_element_from_string, next_element_from_c_string)
5765 (next_element_from_buffer): Add xassert's for correspondence
5766 between IT's object being iterated and it->bidi_it.string
5767 structure.
5768 (face_before_or_after_it_pos): Support bidi iteration.
5769 (next_element_from_c_string): Handle the case of the first string
5770 character that is not the first one in the visual order.
5771 (get_visually_first_element): New function, refactored from common
5772 parts of next_element_from_buffer, next_element_from_string, and
5773 next_element_from_c_string.
5774 (tool_bar_lines_needed, redisplay_tool_bar)
5775 (display_menu_bar): Force left-to-right direction. Add a FIXME
5776 comment for making that be controlled by a user option.
5777 (push_it, pop_it): Save and restore the state of the
5778 bidi iterator. Save and restore the bidi_p flag.
5779 (pop_it): Iterate out of display property for string iteration as
5780 well.
5781 (iterate_out_of_display_property): Support iteration over strings.
5782 (handle_single_display_spec): Set up it->bidi_it for iteration
5783 over a display string, and call bidi_init_it.
5784 (handle_single_display_spec, next_overlay_string)
5785 (get_overlay_strings_1, push_display_prop): Set up the bidi
5786 iterator for displaying display or overlay strings.
5787 (forward_to_next_line_start): Don't use the shortcut if
5788 bidi-iterating.
5789 (back_to_previous_visible_line_start): If handle_display_prop
5790 pushed the iterator stack, restore the internal state of the bidi
5791 iterator by calling bidi_pop_it same number of times.
5792 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5793 and we are bidi-iterating, don't decrement the iterator position;
5794 instead, set the first_elt flag in the bidi iterator, to produce
5795 the same effect.
5796 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5797 (push_display_prop): xassert that we are iterating a buffer.
5798 (push_it, pop_it): Save and restore paragraph_embedding member.
5799 (handle_single_display_spec, next_overlay_string)
5800 (get_overlay_strings_1, reseat_1, reseat_to_string)
5801 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5802 correctly. Don't assume unibyte strings are not bidi-reordered.
5803 (compute_display_string_pos)
5804 (compute_display_string_end): Fix handling the case of C string.
5805 (push_it, pop_it): Save and restore from_disp_prop_p.
5806 (handle_single_display_spec, push_display_prop): Set the
5807 from_disp_prop_p flag.
5808 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5809 (pop_it): Call iterate_out_of_display_property only if we are
5810 popping after iteration over a string that came from a display
5811 property. Fix a typo in popping stretch info. Add an assertion
5812 for verifying that the iterator position is in sync with the bidi
5813 iterator.
5814 (handle_single_display_spec, get_overlay_strings_1)
5815 (push_display_prop): Fix initialization of paragraph direction for
5816 string when that of the parent object is not yet determined.
5817 (reseat_1): Call bidi_init_it to resync the bidi
5818 iterator with IT's position. (Bug#7616)
5819 (find_row_edges): If ROW->start.pos gives position
5820 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5821 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5822 Reset the from_disp_prop_p flag.
5823 (SAVE_IT, RESTORE_IT): New macros.
5824 (pos_visible_p, face_before_or_after_it_pos)
5825 (back_to_previous_visible_line_start)
5826 (move_it_in_display_line_to, move_it_in_display_line)
5827 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5828 (try_scrolling, redisplay_window, display_line): Use them when
5829 saving a temporary copy of the iterator and restoring it back.
5830 (back_to_previous_visible_line_start, reseat_1)
5831 (init_iterator): Empty the bidi cache "stack".
5832 (move_it_in_display_line_to): If iterator ended up at
5833 EOL, but we never saw any buffer positions smaller than
5834 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5835 motion in bidi-reordered lines.
5836 (move_it_in_display_line_to): Record prev_method and prev_pos
5837 immediately before the call to set_iterator_to_next. Fixes cursor
5838 motion in bidi-reordered lines with stretch glyphs and strings
5839 displayed in margins. (Bug#8133) (Bug#8867)
5840 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5841 TO_CHARPOS.
640c8776
SM
5842 (pos_visible_p): Support positions in bidi-reordered lines.
5843 Save and restore bidi cache.
0bb23927
EZ
5844
5845 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5846 (bidi_paragraph_info): Delete unused struct.
5847 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5848 (bidi_cache_start): New variable.
5849 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5850 to zero.
5851 (bidi_cache_fetch_state, bidi_cache_search)
5852 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5853 (bidi_cache_find, bidi_peek_at_next_level)
5854 (bidi_level_of_next_char, bidi_find_other_level_edge)
5855 (bidi_move_to_visually_next): Compare cache index with
5856 bidi_cache_start rather than with zero.
5857 (bidi_fetch_char): Accept new argument STRING; all callers
5858 changed. Support iteration over a string. Support strings with
5859 display properties. Support unibyte strings. Fix the type of
5860 `len' according to what STRING_CHAR_AND_LENGTH expects.
5861 (bidi_paragraph_init, bidi_resolve_explicit_1)
5862 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5863 (bidi_level_of_next_char, bidi_move_to_visually_next):
5864 Support iteration over a string.
0bb23927
EZ
5865 (bidi_set_sor_type, bidi_resolve_explicit_1)
5866 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5867 can now be zero (for strings); special values 0 and -1 were
5868 changed to -1 and -2, respectively.
5869 (bidi_char_at_pos): New function.
5870 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5871 Call it instead of FETCH_MULTIBYTE_CHAR.
5872 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5873 initialized to valid values.
5874 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5875 values.
5876 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5877 the test for valid cached positions. Fix the logic for looking up
5878 the sentinel state in the cache. GCPRO the Lisp string we are
5879 iterating.
5880 (bidi_push_it, bidi_pop_it): New functions.
5881 (bidi_initialize): Initialize the bidi cache start stack pointer.
5882 (bidi_cache_ensure_space): New function, refactored from part of
5883 bidi_cache_iterator_state. Don't assume the required size is just
5884 one BIDI_CACHE_CHUNK away.
5885 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5886 (bidi_count_bytes, bidi_char_at_pos): New functions.
5887 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5888 always valid if bidi_cache_idx is valid.
5889 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5890 is valid if it's going to be used.
5891 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5892 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5893 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5894 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5895 (bidi_find_other_level_edge, bidi_cache_start_stack):
5896 All variables related to cache indices are now EMACS_INT.
c965adc5 5897
0bb23927
EZ
5898 * dispextern.h (struct bidi_string_data): New structure.
5899 (struct bidi_it): New member `string'. Make flag members be 1-bit
5900 fields, and put them last in the struct.
640c8776
SM
5901 (compute_display_string_pos, compute_display_string_end):
5902 Update prototypes.
0bb23927
EZ
5903 (bidi_push_it, bidi_pop_it): Add prototypes.
5904 (struct iterator_stack_entry): New members bidi_p,
5905 paragraph_embedding, and from_disp_prop_p.
5906 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5907 (bidi_shelve_cache, bidi_unshelve_cache):
5908 Declare prototypes.
0bb23927
EZ
5909
5910 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5911 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5912 and vector-like objects.
5913
5914 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5915 cache around display iteration.
5916
5917 * window.c (Fwindow_end, window_scroll_pixel_based)
5918 (displayed_window_lines, Frecenter): Save and restore the bidi
5919 cache around display iteration.
5920
3bbd2265
LMI
59212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5922
5923 * editfns.c (Fdelete_region): Clarify the use of the named
5924 parameters (bug#6788).
5925
adc47434
MR
59262011-07-14 Martin Rudalics <rudalics@gmx.at>
5927
5928 * indent.c (Fvertical_motion): Set and restore w->pointm when
5929 saving and restoring the window's buffer (Bug#9006).
5930
837c31f8
LMI
59312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5932
5933 * editfns.c (Fstring_to_char): Clarify just what is returned
5934 (bug#6576). Text by Eli Zaretskii.
5935
ac389d0c
JB
59362011-07-13 Juanma Barranquero <lekktu@gmail.com>
5937
5938 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5939
0be0ce47
EZ
59402011-07-13 Eli Zaretskii <eliz@gnu.org>
5941
5942 * buffer.c (mmap_find): Fix a typo.
5943
cd18e7e3
JB
59442011-07-13 Johan Bockgård <bojohan@gnu.org>
5945
5946 Fix execution of x selection hooks.
5947 * xselect.c (Qx_lost_selection_functions)
5948 (Qx_sent_selection_functions): New vars.
5949 (syms_of_xselect): DEFSYM them.
5950 (x_handle_selection_request): Pass Qx_sent_selection_functions
5951 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5952 (x_handle_selection_clear,x_clear_frame_selections):
5953 Pass Qx_lost_selection_functions rather than
5954 Vx_lost_selection_functions to Frun_hook_with_args.
5955
47ea7f44
PE
59562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5957
ac389d0c 5958 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5959 The old code sometimes used this field without initializing it.
5960
47ea7f44
PE
5961 * alloc.c (gc_sweep): Don't read past end of array.
5962 In theory, the old code could also have corrupted Emacs internals,
5963 though it'd be very unlikely.
5964
bc985c87
AS
59652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5966
5967 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5968 argument. (Bug#4026)
bc985c87 5969
0cf34688
LMI
59702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5971
b3dadd76
LMI
5972 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5973 key" (bug#4257).
5974
0cf34688
LMI
5975 * window.c (Fset_window_start): Doc fix (bug#4199).
5976 (Fset_window_hscroll): Ditto.
5977
270768cd
PE
59782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5979
077e3dda 5980 Fix minor new problems caught by GCC 4.6.1.
270768cd 5981 * term.c (init_tty): Remove unused local.
490011a6 5982 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5983 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5984 not used otherwise.
270768cd 5985
b1f58454
CY
59862011-07-12 Chong Yidong <cyd@stupidchicken.com>
5987
5988 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5989
22b9578d
LMI
59902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5991
6e70ab07
LMI
5992 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5993 are the mini-buffer and the echo area (bug#3320).
5994
22b9578d
LMI
5995 * term.c (init_tty): Remove support for supdup, c10 and perq
5996 terminals, which are no longer supported (bug#1482).
5997
8974cc9f
JB
59982011-07-10 Johan Bockgård <bojohan@gnu.org>
5999
6000 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6001
a560d974
JD
60022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6003
6004 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6005 for non-popups (Bug#3642).
6006
1dae0f0a
AS
60072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6008
268c2c36 6009 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6010 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6011 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6012 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6013 * data.c (fmod): Likewise.
6014 * dispnew.c (swap_glyphs_in_rows): Likewise.
6015 * emacs.c (memory_warning_signal): Likewise.
6016 * floatfns.c (float_error): Likewise.
6017 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6018 (otf_open, font_otf_capability, generate_otf_features)
6019 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6020 Likewise.
6021 * image.c (pbm_read_file): Likewise.
6022 * indent.c (string_display_width): Likewise.
6023 * intervals.c (check_for_interval, search_for_interval)
6024 (inc_interval_count, count_intervals, root_interval)
6025 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6026 * lread.c (defalias): Likewise.
268c2c36 6027 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6028 * regex.c (set_image_of_range_1, set_image_of_range)
6029 (regex_grow_registers): Likewise.
6030 * sysdep.c (strerror): Likewise.
6031 * termcap.c (valid_filename_p, tprint, main): Likewise.
6032 * tparam.c (main): Likewise.
6033 * unexhp9k800.c (run_time_remap, save_data_space)
6034 (update_file_ptrs, read_header, write_header, calculate_checksum)
6035 (copy_file, copy_rest, display_header): Likewise.
6036 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6037 Likewise.
6038 * xdisp.c (check_it): Likewise.
6039 * xfaces.c (register_color, unregister_color, unregister_colors):
6040 Likewise.
6041 * xfns.c (print_fontset_result): Likewise.
6042 * xrdb.c (member, fatal, main): Likewise.
6043
99033785
PE
60442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 Fix minor problems found by static checking (Bug#9031).
6047 * chartab.c (char_table_set_range, map_sub_char_table):
6048 Remove unused locals.
6049 (uniprop_table): Now static.
6050 * composite.c (_work_char): Remove unused static var.
6051
9cb2ac56
JB
60522011-07-09 Juanma Barranquero <lekktu@gmail.com>
6053
6054 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6055
f25661f0
JD
60562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6057
6058 * gtkutil.c (qttip_cb): Remove code without function.
6059
8278c4fe
EZ
60602011-07-09 Eli Zaretskii <eliz@gnu.org>
6061
6062 * w32.c (pthread_sigmask): New stub.
6063
1692ae2d 60642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6065
8a6ebd58 6066 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6067 sigprocmask is portable only for single-threaded applications, and
6068 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6069 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6070 (LIBES): Use it.
6071 * callproc.c (Fcall_process):
6072 * process.c (create_process):
6073 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6074 Use pthread_sigmask, not sigprocmask.
123403e4 6075
1b854618
JD
60762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6077
6078 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6079 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6080 wrong (Bug#8591).
6081
3fe4b549
JD
60822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6083
0ce7e563
JD
6084 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6085 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6086 (xg_hide_tooltip): Fix comment.
6087
3fe4b549
JD
6088 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6089 in registerServicesMenuSendTypes.
6090 (validRequestorForSendType): Don't check ns_return_types.
6091
6092 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6093 ns_return_type.
6094
5df75e47
JR
60952011-07-08 Jason Rumney <jasonr@gnu.org>
6096
22610910
JR
6097 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6098 SH_SHOW for hidden windows (Bug#5482).
6099
5df75e47
JR
6100 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6101 frame struct members of non-existent frames (Bug#6284).
6102
699c10bd
JD
61032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6104
4393663b
JD
6105 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6106 variable firstTime not needed on OSX >= 10.6.
6107 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6108 >= 10.5. Use setKnobProportion, setDoubleValue.
6109
6110 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6111 (MAC_OS_X_VERSION_10_5): Define if not defined.
6112 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6113 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6114 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6115
6116 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6117 cString and lossyCString on OSX >= 10.4
6118
58179cce 6119 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6120 sizeToFit on OSX >= 10.2.
6121
6122 * nsimage.m (allocInitFromFile): Don't use deprecated method
6123 bestRepresentationForDevice on OSX >= 10.6.
6124
6125 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6126 to avoid warning.
6127
6128 * emacs.c: Declare unexec_init_emacs_zone.
6129
a63e0781
JD
6130 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6131
699c10bd
JD
6132 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6133
6134 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6135 on svcsMenu (Bug#8842).
6136
6137 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6138 ns_return_types.
6139 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6140
6141 * nsterm.m (QUTF8_STRING): Declare.
6142 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6143 (validRequestorForSendType): Return type is (id).
6144 Change indexOfObjectIdenticalTo to indexOfObject.
6145 Check if we have local selection before returning self (Bug#8842).
6146 (writeSelectionToPasteboard): Put local selection into paste board
6147 if we have a local selection (Bug#8842).
6148 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6149
6150 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6151 (ns_get_local_selection): Declare.
6152
54e10184
LMI
61532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6154
9888ff71
LMI
6155 * keymap.c (describe_map_tree): Don't insert a double newline at
6156 the end of the buffer (bug#1169) and return whether we inserted
6157 something.
6158
54e10184
LMI
6159 * callint.c (Fcall_interactively): Change "reading args" to
6160 "providing args" to try to clarify what it does (bug#1010).
6161
15fa4783
KH
61622011-07-07 Kenichi Handa <handa@m17n.org>
6163
6164 * composite.c (composition_compute_stop_pos): Ignore a static
6165 composition starting before CHARPOS (Bug#8915).
6166
6167 * xdisp.c (handle_composition_prop): Likewise.
6168
a8815b00
EZ
61692011-07-07 Eli Zaretskii <eliz@gnu.org>
6170
6171 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6172 (Bug#9015)
6173
ef7b981d 61742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6175
6176 * character.h (unicode_category_t): New enum type.
6177
6178 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6179 (Qchar_code_property_table): New variable.
6180 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6181 (UNIPROP_COMPRESSED_FORM_P): New macros.
6182 (char_table_ascii): Uncompress the compressed values.
6183 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6184 Uncompress the compressed values.
ac389d0c 6185 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6186 (char_table_ref_and_range): Uncompress the compressed values.
6187 (sub_char_table_set): New arg is_uniprop. Callers changed.
6188 Uncompress the compressed values.
6189 (sub_char_table_set_range): Args changed. Callers changed.
6190 (char_table_set_range): Adjuted for the above change.
6191 (map_sub_char_table): Delete args default_val and parent. Add arg
6192 top. Give decoded values to a Lisp function.
640c8776 6193 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6194 values to a Lisp function. Gcpro more variables.
6195 (uniprop_table_uncompress)
6196 (uniprop_decode_value_run_length): New functions.
6197 (uniprop_decoder, uniprop_decoder_count): New variables.
6198 (uniprop_get_decoder, uniprop_encode_value_character)
6199 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6200 New functions.
6201 (uniprop_encoder, uniprop_encoder_count): New variables.
6202 (uniprop_get_encoder, uniprop_table)
6203 (Funicode_property_table_internal, Fget_unicode_property_internal)
6204 (Fput_unicode_property_internal): New functions.
6205 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6206 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6207 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6208 char-code-property-alist.
6209
640c8776 6210 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6211 Vunicode_category_table.
6212
640c8776 6213 * font.c (font_range): Adjust for the change of
c805dec0
KH
6214 Vunicode_category_table.
6215
76b397fb
DN
62162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6217
6218 * m/iris4d.h: Remove file, move contents ...
6219 * s/irix6-5.h: ... here.
6220
22b4128e
PE
62212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6222
6223 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6224 * alloc.c (mark_buffer):
6225 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6226 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6227 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6228 This isn't true in general, and it's particularly not true
6229 if Emacs is configured with --with-wide-int.
6230 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6231 New macros, used in the buffer.c change.
6232
869795d6
JD
62332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6234
6235 * xsettings.c: Use both GConf and GSettings if both are available.
6236 (store_config_changed_event): Add comment.
6237 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6238 (store_tool_bar_style_changed): New functions.
5e617bc2 6239 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6240 (struct xsettings): Move font inside HAVE_XFT.
6241 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6242 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6243 Move inside HAVE_XFT.
640c8776 6244 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6245 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6246 also.
6247 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6248 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6249 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6250 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6251 (parse_settings): Move check for font inside HAVE_XFT.
6252 (read_settings, apply_xft_settings): Add comment.
6253 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6254 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6255 call store_font_name_changed.
6256 (xft_settings_event): Add comment.
6257 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6258 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6259 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6260 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6261 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6262 (xsettings_get_system_font, xsettings_get_system_normal_font):
6263 Add comment.
869795d6 6264
d8ed26bd
PE
62652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6266
6267 Random fixes. E.g., (random) never returned negative values.
6268 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6269 subseconds part to the entropy, as that's a bit more random.
6270 Prefer signed to unsigned, since the signedness doesn't matter and
6271 in general we prefer signed. When given a limit, use a
6272 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6273 latter isn't right if USE_2_TAGS_FOR_INTS.
6274 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6275 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6276
cabf1cac
SM
62772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6278
6279 * textprop.c (text_property_stickiness):
6280 Obey Vtext_property_default_nonsticky.
6281 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6282 * w32fns.c (syms_of_w32fns):
6283 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6284
6e9b2be9
PE
62852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6286
6287 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6288 This is more efficient than Ffile_directory_p and avoids a minor race.
6289
90186c68
LMI
62902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6291
7c301272
LMI
6292 * buffer.c (Foverlay_put): Say what the return value is
6293 (bug#7835).
6294
c4f2d8d4
LMI
6295 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6296 is a directory before asking whether to use the file name
6297 (bug#7564).
ad637907
LMI
6298 (barf_or_query_if_file_exists): Make the "File is a directory"
6299 error be more correct.
c4f2d8d4 6300
90186c68
LMI
6301 * fns.c (Frequire): Remove the mention of the .gz files, since
6302 that's installation-specific, but keep the mention of
6303 `get-load-suffixes'.
6304
da64016e
PE
63052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6306
6307 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6308 Report string overflow if the output is too long.
6309
7d47b580
JB
63102011-07-04 Juanma Barranquero <lekktu@gmail.com>
6311
a555cb87
JB
6312 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6313 (syms_of_gnutls): Remove duplicate DEFSYM for
6314 Qgnutls_bootprop_verify_hostname_error, an error for
6315 Qgnutls_bootprop_verify_error (which is no longer used).
6316
7d47b580
JB
6317 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6318 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6319 Also (re)move comments that are misplaced or no longer relevant.
6320
1e49bfab
LMI
63212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6322
6323 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6324
1485f4c0
CY
63252011-07-03 Chong Yidong <cyd@stupidchicken.com>
6326
6327 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6328 and background color parameters if they have been changed.
6329
a9ab721e
LMI
63302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6331
6332 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6333
cf7cff57
PE
63342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6335
2e13213d
PE
6336 * xsettings.c (SYSTEM_FONT): Define only when used.
6337 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6338
cf7cff57
PE
6339 * keymap.c (access_keymap_1): Now static.
6340
7a8e04f7
CY
63412011-07-02 Chong Yidong <cyd@stupidchicken.com>
6342
6343 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6344 leave any prefix arg for the up event (Bug#1586).
6345
61352f62
LMI
63462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6347
69bb1ef7
LMI
6348 * lread.c (syms_of_lread): Mention single symbols defined by
6349 `defvar' or `defconst' (bug#7154).
6350
61352f62 6351 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6352 (Frequire): Mention get-load-suffixes.
61352f62 6353
28545e04
MR
63542011-07-02 Martin Rudalics <rudalics@gmx.at>
6355
6356 * window.h (window): Remove clone_number slot.
6357 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6358 Remove.
6359 (make_parent_window, make_window, saved_window)
6360 (Fset_window_configuration, save_window_save): Don't deal with
6361 clone numbers.
6362 * buffer.c (Qclone_number): Remove declaration.
6363 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6364
3349e122
SM
63652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6366
6367 Add multiple inheritance to keymaps.
6368 * keymap.c (Fmake_composed_keymap): New function.
6369 (Fset_keymap_parent): Simplify.
6370 (fix_submap_inheritance): Remove.
6371 (access_keymap_1): New function extracted from access_keymap to handle
6372 embedded parents and handle lists of maps.
6373 (access_keymap): Use it.
6374 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6375 (Fcopy_keymap): Handle embedded parents.
6376 (Fcommand_remapping, define_as_prefix): Simplify.
6377 (Fkey_binding): Simplify.
6378 (syms_of_keymap): Move minibuffer-local-completion-map,
6379 minibuffer-local-filename-completion-map,
6380 minibuffer-local-must-match-map, and
6381 minibuffer-local-filename-must-match-map to Elisp.
6382 (syms_of_keymap): Defsubr make-composed-keymap.
6383 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6384 (parse_menu_item): Trivial simplification.
6385
3279eb87
GM
63862011-07-01 Glenn Morris <rgm@gnu.org>
6387
6388 * Makefile.in (SETTINGS_LIBS): Fix typo.
6389
4550efdf
KI
63902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6391
6392 * coding.c (Fencode_coding_string): Record the last coding system
6393 used, as the function doc string says (bug#8738).
6394
0949d2b6
JD
63952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6396
6397 * xsettings.c (store_monospaced_changed): Take new font as arg and
6398 check for change against current_mono_font.
6399 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6400 (emacs_settings_constructor, emacs_settings_get_property)
6401 (emacs_settings_set_property, emacs_settings_class_init)
6402 (emacs_settings_init, gsettings_obj): Remove.
6403 (something_changedCB): New function for HAVE_GSETTINGS.
6404 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6405 with value as argument.
6406 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6407 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6408 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6409 "changed".
6410
6411 * xgselect.c: Add defined (HAVE_GSETTINGS).
6412 (xgselect_initialize): Ditto.
6413
6414 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6415 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6416 xg_select.
6417
bbc6b304
PE
64182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6419
6420 * eval.c (struct backtrace): Simplify and port the data structure.
6421 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6422 signed bit field, as this assumption is not portable and it makes
6423 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6424 "char debug_on_exit : 1" as this is not portable either; instead,
6425 use the portable "unsigned int debug_on_exit : 1". Remove unused
6426 member evalargs. Remove obsolete comments about cc bombing out.
6427
9851bfc5
JD
64282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6429
51bb811f 6430 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6431 Let HAVE_GSETTINGS override HAVE_GCONF.
6432 (store_monospaced_changed): New function.
6433 (EMACS_SETTINGS): A new type derived from GObject to handle
6434 GSettings notifications.
6435 (emacs_settings_constructor, emacs_settings_get_property)
6436 (emacs_settings_set_property, emacs_settings_class_init):
6437 New functions.
6438 (gsettings_client, gsettings_obj): New variables.
6439 (GSETTINGS_SCHEMA): New define.
6440 (something_changedCB): Call store_monospaced_changed.
6441 (init_gsettings): New function.
6442 (xsettings_initialize): Call init_gsettings.
6443 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6444 to NULL.
6445
640c8776 6446 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6447 GCONF_CFLAGS/LIBS.
6448
5386012d
MR
64492011-06-29 Martin Rudalics <rudalics@gmx.at>
6450
6451 * window.c (resize_root_window, grow_mini_window)
6452 (shrink_mini_window): Rename Qresize_root_window to
6453 Qwindow_resize_root_window and Qresize_root_window_vertically to
6454 Qwindow_resize_root_window_vertically.
6455
f13e0b08
PE
64562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6457
6458 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6459
94515237
JB
64602011-06-27 Juanma Barranquero <lekktu@gmail.com>
6461
6462 * makefile.w32-in: Redesign dependencies so they reflect more
6463 clearly which files are directly included by each source file,
6464 and not through other includes.
6465
e43b6e43
MR
64662011-06-27 Martin Rudalics <rudalics@gmx.at>
6467
6468 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6469 (sort_overlays, overlay_strings): When an overlay's clone number
6470 matches the window's clone number process the overlay even if
6471 the overlay's window property doesn't match the current window.
6472
d68443dc
MR
6473 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6474 (Fwindow_hchild): Rename to Fwindow_left_child.
6475 (Fwindow_next): Rename to Fwindow_next_sibling.
6476 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6477 (resize_window_check): Rename to window_resize_check.
6478 (resize_window_apply): Rename to window_resize_apply.
6479 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6480 (Fdelete_other_windows_internal, resize_frame_windows)
6481 (Fsplit_window_internal, Fdelete_window_internal)
6482 (grow_mini_window, shrink_mini_window)
6483 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6484
c7e73be5
JD
64852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6486
6487 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6488 (emacs_fixed_set_min_size): Remove.
6489 (emacs_fixed_new): Take frame as argument.
6490
6491 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6492 (_EmacsFixedPrivate): Remove minwidth/height.
6493 Add struct frame *f.
6494 (emacs_fixed_init): Initialize priv->f.
6495 (get_parent_class, emacs_fixed_set_min_size): Remove.
6496 (emacs_fixed_new): Set priv->f to argument.
6497 (emacs_fixed_get_preferred_width)
6498 (emacs_fixed_get_preferred_height): Use min_width/height from
6499 frames size_hint to set minimum and natural (Bug#8919).
6500 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6501 and use min_width/height from frames size_hint to set
6502 min_width/height (Bug#8919).
6503
6504 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6505 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6506 Fix indentation.
c7e73be5 6507
cf99dcf8
EZ
65082011-06-26 Eli Zaretskii <eliz@gnu.org>
6509
6510 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6511 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6512 called at ZV.
6513
029529ac
CY
65142011-06-26 Chong Yidong <cyd@stupidchicken.com>
6515
6516 * process.c (wait_reading_process_output): Bypass select if
6517 waiting for a cell while ignoring keyboard input, and input is
6518 pending. Suggested by Jan Djärv (Bug#8869).
6519
7a7ef429
PE
65202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6521
6522 Use gnulib's dup2 module instead of rolling our own.
6523 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6524
11fdef7d 65252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6526
6527 * dispnew.c (scrolling_window): Before scrolling, turn off a
6528 mouse-highlight in the window being scrolled.
6529
cd3520a4
JB
65302011-06-24 Juanma Barranquero <lekktu@gmail.com>
6531
6532 Move DEFSYM to lisp.h and use everywhere.
6533
6534 * character.h (DEFSYM): Move declaration...
6535 * lisp.h (DEFSYM): ...here.
6536
6537 * gnutls.c:
6538 * minibuf.c:
6539 * w32menu.c:
6540 * w32proc.c:
6541 * w32select.c: Don't include character.h.
6542
6543 * alloc.c (syms_of_alloc):
6544 * buffer.c (syms_of_buffer):
6545 * bytecode.c (syms_of_bytecode):
6546 * callint.c (syms_of_callint):
6547 * casefiddle.c (syms_of_casefiddle):
6548 * casetab.c (init_casetab_once):
6549 * category.c (init_category_once, syms_of_category):
6550 * ccl.c (syms_of_ccl):
6551 * cmds.c (syms_of_cmds):
6552 * composite.c (syms_of_composite):
6553 * dbusbind.c (syms_of_dbusbind):
6554 * dired.c (syms_of_dired):
6555 * dispnew.c (syms_of_display):
6556 * doc.c (syms_of_doc):
6557 * editfns.c (syms_of_editfns):
6558 * emacs.c (syms_of_emacs):
6559 * eval.c (syms_of_eval):
6560 * fileio.c (syms_of_fileio):
6561 * fns.c (syms_of_fns):
6562 * frame.c (syms_of_frame):
6563 * fringe.c (syms_of_fringe):
6564 * insdel.c (syms_of_insdel):
6565 * keymap.c (syms_of_keymap):
6566 * lread.c (init_obarray, syms_of_lread):
6567 * macros.c (syms_of_macros):
6568 * msdos.c (syms_of_msdos):
6569 * print.c (syms_of_print):
6570 * process.c (syms_of_process):
6571 * search.c (syms_of_search):
6572 * sound.c (syms_of_sound):
6573 * syntax.c (init_syntax_once, syms_of_syntax):
6574 * terminal.c (syms_of_terminal):
6575 * textprop.c (syms_of_textprop):
6576 * undo.c (syms_of_undo):
6577 * w32.c (globals_of_w32):
6578 * window.c (syms_of_window):
6579 * xdisp.c (syms_of_xdisp):
6580 * xfaces.c (syms_of_xfaces):
6581 * xfns.c (syms_of_xfns):
6582 * xmenu.c (syms_of_xmenu):
6583 * xsettings.c (syms_of_xsettings):
6584 * xterm.c (syms_of_xterm): Use DEFSYM.
6585
4228cf16
TZ
65862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6587
cd3520a4 6588 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6589
7fcccf1e
PE
65902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6591
7efb4e0e
PE
6592 Integer and buffer overflow fixes (Bug#8873).
6593
ff5844ad
PE
6594 * print.c (printchar, strout): Check for string overflow.
6595 (PRINTPREPARE, printchar, strout):
6596 Don't set size unless allocation succeeds.
6597
90532f02
PE
6598 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6599 for sizes. Check for string overflow more accurately.
6600 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6601
6d84508d
PE
6602 * macros.c: Integer and buffer overflow fixes.
6603 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6604 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6605 Use ptrdiff_t, not int, for sizes.
6606 Don't increment bufsize until after realloc succeeds.
6607 Check for size-calculation overflow.
6608 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6609
437b2cb4
PE
6610 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6611
8b9ac8b4
PE
6612 * lread.c: Integer overflow fixes.
6613 (read_integer): Radix is now EMACS_INT, not int,
6614 to improve quality of diagnostics for out-of-range radices.
6615 Calculate buffer size correctly for out-of-range radices.
6616 (read1): Check for integer overflow in radices, and in
6617 read-circle numbers.
82cb60d3
PE
6618 (read_escape): Avoid int overflow.
6619 (Fload, openp, read_buffer_size, read1)
6620 (substitute_object_recurse, read_vector, read_list, map_obarray):
6621 Use ptrdiff_t, not int, for sizes.
6622 (read1): Use EMACS_INT, not int, for sizes.
20270765 6623 Check for size overflow.
8b9ac8b4 6624
7fcccf1e
PE
6625 * image.c (cache_image): Check for size arithmetic overflow.
6626
bfbbd7e7
PE
6627 * lread.c: Integer overflow issues.
6628 (saved_doc_string_size, saved_doc_string_length)
6629 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6630 Now ptrdiff_t, not int.
6631 (read1): Don't assume doc string length fits in int. Check for
6632 out-of-range doc string lengths.
6633 (read_list): Don't assume file position fits in int.
39019e54 6634 (read_escape): Check for hex character overflow.
bfbbd7e7 6635
4e323265
LL
66362011-06-22 Leo Liu <sdl.web@gmail.com>
6637
6638 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6639 Move to minibuffer.el.
6640
85fece3e
PE
66412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6642
20b84ce9 6643 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6644 The following patches are for when GLYPH_DEBUG && !XASSERT.
6645 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6646 * dispnew.c (flush_stdout):
6647 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6648 Mark as externally visible.
6649 * dispnew.c (check_window_matrix_pointers): Now static.
6650 * dispnew.c (window_to_frame_vpos):
6651 * xfns.c (unwind_create_frame):
6652 * xterm.c (x_check_font): Remove unused local.
6653 * scroll.c (CHECK_BOUNDS):
6654 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6655 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6656 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6657 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6658 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6659 Now static.
6660 (debug_method_add): Use va_list and vsprintf rather than relying
6661 on undefined behavior with wrong number of arguments.
6662 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6663 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6664 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6665 since we're not interested in debugging glyphs with old libraries.
6666 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6667 GCC 4.6.0's static checking.
6668
0766b489
PE
66692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6670
31fd4b32
PE
6671 Integer overflow and signedness fixes (Bug#8873).
6672 A few related buffer overrun fixes, too.
6673
b79e8648
PE
6674 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6675
0766b489
PE
6676 * dispextern.h (struct face.stipple):
6677 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6678 (x_bitmap_mask, x_allocate_bitmap_record)
6679 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6680 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6681 (x_create_bitmap_from_xpm_data):
6682 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6683 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6684 (.bitmaps_last):
6685 * xfaces.c (load_pixmap):
6686 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6687 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6688 (.bitmaps_last, struct x_output.icon_bitmap):
6689 Use ptrdiff_t, not int, for bitmap indexes.
6690 (x_allocate_bitmap_record): Check for size overflow.
6691 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6692
b081724f
PE
6693 Use ptrdiff_t, not int, for overlay counts.
6694 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6695 * editfns.c (overlays_around, get_pos_property):
6696 * textprop.c (get_char_property_and_overlay):
6697 * xdisp.c (next_overlay_change, note_mouse_highlight):
6698 * xfaces.c (face_at_buffer_position):
21514da7
PE
6699 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6700 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6701 (Fnext_overlay_change, Fprevious_overlay_change)
6702 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6703 Use ptrdiff_t, not int, for sizes.
21514da7 6704 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6705
3de73e5e
PE
6706 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6707
2606c57b
PE
6708 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6709 (x_session_initialize): Do not assume string length fits in int.
6710
aaafe47a
PE
6711 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6712 This is unlikely, but can occur if DPI is outlandish.
6713
2674ddc8 6714 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6715 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6716
28154962
PE
6717 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6718 * xrdb.c (magic_file_p, search_magic_path):
6719 Omit last arg SUFFIX; it was always 0. All callers changed.
6720 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6721
7de51af5
PE
6722 * xfont.c (xfont_match): Avoid need for strlen.
6723
25ed6cc3
PE
6724 * xfns.c: Don't assume strlen fits in int.
6725 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6726
4eab31dd
PE
6727 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6728 not unsigned long, as we prefer signed integers. All callers changed.
6729 Detect integer overflow in repeat count.
6730 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6731 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6732
171e2a58
PE
6733 * termcap.c: Don't assume sizes fit in int and never overflow.
6734 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6735 (gobble_line): Check for size-calculation overflow.
6736
ad39faca 6737 * minibuf.c (Fread_buffer):
6e5bb2dc 6738 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6739 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6740 Don't assume string length fits in int.
6741
52c61c22 6742 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6743 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6744
b5b8c9e5
PE
6745 * font.c: Don't assume string length fits in int.
6746 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6747 Use ptrdiff_t, not int.
ccd6111c
PE
6748 (font_intern_prop): Don't assume string length fits in int.
6749 Don't assume integer property fits in fixnum.
6750 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6751
882f0d81 6752 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6753 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6754 Reformulate so as not to need the command string.
6755 Invoke gzip -cd rather than gunzip, as it's more portable.
6756 (lock_info_type, lock_file_1, lock_file):
6757 Don't assume pid_t and time_t fit in unsigned long.
6758 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6759 (current_lock_owner): Prefer signed type for sizes.
6760 Use memcpy, not strncpy, where memcpy is what is really wanted.
6761 Don't assume (via atoi) that time_t and pid_t fit in int.
6762 Check for time_t and/or pid_t out of range, e.g., via a network share.
6763 Don't alloca where an auto var works fine.
6764
93f4cf88
PE
6765 * fileio.c: Fix some integer overflow issues.
6766 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6767 Don't assume string length fits in int.
6768 (directory_file_name): Don't assume string length fits in long.
6769 (make_temp_name): Don't assume pid fits in int, or that its print
6770 length is less than 20.
6771
f3e92b69
PE
6772 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6773
1bfdaf10
PE
6774 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6775
35016e9a
PE
6776 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6777
3d1e65a1
PE
6778 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6779 We prefer signed integers, even for size calculations.
6780
0b963a93
PE
6781 * emacs.c: Don't assume string length fits in 'int'.
6782 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6783 (main): Don't invoke strlen when not needed.
6784
573f4b54
PE
6785 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6786 (XD_DEBUG_MESSAGE): Don't waste a byte.
6787
989f33ba
PE
6788 * callproc.c (getenv_internal_1, getenv_internal)
6789 (Fgetenv_internal):
965d34eb
PE
6790 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6791
e4d29b33
PE
6792 * lread.c (invalid_syntax): Omit length argument.
6793 All uses changed. This doesn't fix a bug, but it simplifies the
6794 code away from its former Hollerith-constant appearance, and it's
6795 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6796 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6797
eb49b136
PE
6798 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6799 This didn't break anything, but it didn't help either.
6800 It's confusing to put a bogus integer in a place where the actual
6801 value does not matter.
9f62aeb1 6802 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6803 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6804
15375a22
PE
6805 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6806 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6807 implementation.
b61cc01c
PE
6808 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6809 We prefer signed types, and the value cannot exceed the EMACS_INT
6810 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6811 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6812 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6813 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6814
53b2623d
PE
6815 * indent.c (sane_tab_width): New function.
6816 (current_column, scan_for_column, Findent_to, position_indentation)
6817 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6818 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6819
51cab52b 6820 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6821
f2ed8a70
PE
6822 * lisp.h (lint_assume): New macro.
6823 * composite.c (composition_gstring_put_cache):
6824 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6825
abe80cc6
PE
6826 * editfns.c, insdel.c:
6827 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6828
b02c740e
PE
6829 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6830
ebc96716
PE
6831 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6832
b4e50fa0 6833 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6834 Use much-faster test for byte-length change.
311d5d7c 6835 Don't assume string byte-length fits in 'int'.
a4cf38e4 6836 Check that character arg fits in 'int'.
85461888 6837 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6838
c0c1ee9f
PE
6839 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6840
a498d7f4
PE
6841 * fns.c (concat): Catch string overflow earlier.
6842 Do not rely on integer wraparound.
6843
51cab52b
PE
6844 * dispextern.h (struct it.overlay_strings_charpos)
6845 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6846 * xdisp.c (forward_to_next_line_start)
6847 (back_to_previous_visible_line_start)
6848 (reseat_at_next_visible_line_start, next_element_from_buffer):
6849 Don't arbitrarily truncate the value of 'selective' to int.
6850
76031fad
PE
6851 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6852
5eb55db9
PE
6853 * composite.c: Don't truncate sizes to 'int'.
6854 (composition_gstring_p, composition_reseat_it)
6855 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6856 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6857 not EMACS_UINT, for indexes.
5eb55db9 6858
0703a717
PE
6859 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6860
d6202519
PE
6861 * buffer.c: Include <verify.h>.
6862 (struct sortvec.priority, struct sortstr.priority):
8961a454 6863 Now EMACS_INT, not int.
c20998a7 6864 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6865 (struct sortstr.size, record_overlay_string)
6866 (struct sortstrlist.size, struct sortlist.used):
6867 Don't truncate size to int.
6868 (record_overlay_string): Check for size-calculation overflow.
d6202519 6869 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6870
d5a19415
JM
68712011-06-22 Jim Meyering <meyering@redhat.com>
6872
029529ac 6873 Don't leak an XBM-image-sized buffer
d5a19415
JM
6874 * image.c (xbm_load): Free the image buffer after using it.
6875
a9041e6c
PE
68762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6877
6878 Port to Sun C.
6879 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6880 that Sun C diagnosed.
6881 * fns.c (secure_hash): Fix pointer signedness issue.
6882 * intervals.c (static_offset_intervals): New function.
6883 (offset_intervals): Use it.
6884
7f3f739f
LL
68852011-06-21 Leo Liu <sdl.web@gmail.com>
6886
6887 * deps.mk (fns.o):
6888 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6889 sha512.h.
6890
6891 * fns.c (secure_hash): Rename from crypto_hash_function and change
6892 the first arg to accept symbols.
5b66d427 6893 (Fsecure_hash): New primitive.
7f3f739f
LL
6894 (syms_of_fns): New symbols.
6895
76147d94
DD
68962011-06-20 Deniz Dogan <deniz@dogan.se>
6897
6898 * process.c (Fset_process_buffer): Clarify return value in
6899 docstring.
6900
7d7d0045
CY
69012011-06-18 Chong Yidong <cyd@stupidchicken.com>
6902
6903 * dispnew.c (add_window_display_history): Use BVAR.
6904
6905 * xdisp.c (debug_method_add): Use BVAR.
6906 (check_window_end, dump_glyph_matrix, dump_glyph)
6907 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6908
6909 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6910 Likewise.
6911
6912 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6913 check till after the cache is created in init_frame_faces.
6914
ff2bc410
SM
69152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6916
6917 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6918
28177add
PE
69192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6920
dd3482fe
PE
6921 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6922 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6923 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6924
393d71f3 6925 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6926 * fileio.c (Finsert_file_contents):
6927 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6928 Remove the old (too-loose) buffer overflow checks.
6929 They weren't needed, since make_gap checks for buffer overflow.
6930 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6931 The old code merely checked for Emacs fixnum overflow, and relied
6932 on undefined (wraparound) behavior. The new code avoids undefined
6933 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6934
2e6813b0 6935 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6936 Tune. Don't use wider integers than needed. Don't use alloca.
6937 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6938
599a9e4f
PE
6939 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6940
99561444
PE
6941 * insdel.c, lisp.h (buffer_overflow): New function.
6942 (insert_from_buffer_1, replace_range, replace_range_2):
6943 * insdel.c (make_gap_larger):
6944 * editfns.c (Finsert_char):
6945 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6946
28177add
PE
6947 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6948
e69dafad
PE
69492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6950
4baa020d 6951 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6952
b1c46f02
PE
6953 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6954 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6955
e69dafad
PE
6956 * fileio.c: Don't assume EMACS_INT fits in off_t.
6957 (emacs_lseek): New static function.
6958 (Finsert_file_contents, Fwrite_region): Use it.
6959 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6960
566684ea
PE
6961 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6962
e6966cd6
PE
6963 * fns.c: Don't overflow int when computing a list length.
6964 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6965 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6966 truncation on 64-bit hosts. Check for QUIT every
6967 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6968 faster and is responsive enough.
6969 (Flength): Report an error instead of overflowing an integer.
6970 (Fsafe_length): Return a float if the value is not representable
6971 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6972 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6973 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6974
dd0b0efb
PE
6975 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6976 (header_size, word_size): New constants.
6977 (allocate_vectorlike): Don't check size overflow here.
6978 (allocate_vector): Check it here instead, since this is the only
6979 caller of allocate_vectorlike that could cause overflow.
6980 Check that the new vector's length is representable as a fixnum.
6981
86fe5cfe
PE
6982 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6983 The previous code was bogus. For example, next_almost_prime (32)
6984 returned 39, which is undesirable as it is a multiple of 3; and
6985 next_almost_prime (24) returned 25, which is a multiple of 5 so
6986 why was the code bothering to check for multiples of 7?
6987
80e88859
PE
6988 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6989
4a2f0ad6
PE
6990 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6991
f66c7cf8
PE
6992 Variadic C functions now count arguments with ptrdiff_t.
6993 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6994 Back then I didn't know that the Emacs coding style prefers signed int.
6995 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6996 were being counted with int, which may truncate counts on 64-bit
6997 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6998 * lisp.h (struct Lisp_Subr.function.aMANY)
6999 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7000 Arg counts are now ptrdiff_t, not size_t.
7001 All variadic functions and their callers changed accordingly.
7002 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7003 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7004 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7005 * callint.c (Fcall_interactively): Check arg count for overflow,
7006 to avoid potential buffer overrun. Use signed char, not 'int',
7007 for 'varies' array, so that we needn't bother to check its size
7008 calculation for overflow.
7009 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7010 * eval.c (apply_lambda):
7011 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7012 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7013 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7014
a1759b76
PE
7015 * callint.c (Fcall_interactively): Don't use index var as event count.
7016
d96be9fc
PE
7017 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7018 * mem-limits.h (SIZE): Remove; no longer used.
7019
a690a978 7020 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7021
578c21e6
PE
7022 Remove unnecessary casts.
7023 * xterm.c (x_term_init):
7024 * xfns.c (x_set_border_pixel):
7025 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7026 These aren't needed now that we assume ANSI C.
7027
96f53c6c
PE
7028 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7029 It's more likely to cause problems (due to unsigned overflow)
7030 than to cure them.
7031
83c77d31
PE
7032 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7033
ee2079f1
PE
7034 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7035
6da65536
PE
7036 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7037
7147c4a4
PE
7038 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7039
193e32d9
PE
7040 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7041
e5533da6
PE
7042 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7043
9910e595
PE
7044 GLYPH_CODE_FACE returns EMACS_INT, not int.
7045 * dispextern.h (merge_faces):
7046 * xfaces.c (merge_faces):
01103c44
PE
7047 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7048 Don't assume EMACS_INT fits in int.
9910e595 7049
2638320e
PE
7050 * character.h (CHAR_VALID_P): Remove unused parameter.
7051 * fontset.c, lisp.h, xdisp.c: All uses changed.
7052
045eb8d9
PE
7053 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7054
c1f134b5
PE
7055 * fns.c (concat): Minor tuning based on overflow analysis.
7056 This doesn't fix any bugs. Use int to hold character, instead
7057 of constantly refetching from Emacs object. Use XFASTINT, not
7058 XINT, for value known to be a character. Don't bother comparing
7059 a single byte to 0400, as it's always less.
7060
395fcb93 7061 * floatfns.c (Fexpt):
327eeec8
PE
7062 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7063
abbd3d23
PE
7064 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7065 for characters.
7066
684a03ef
PE
7067 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7068
0fed43f3
PE
7069 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7070 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7071 incorrectly succeed when S was a string, because 4294967386 was
7072 truncated before it was used.
7073
8fd02eb7
PE
7074 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7075 Otherwise, an out-of-range integer could cause undefined behavior
7076 on a 64-bit host.
7077
f8c86b69
PE
7078 * composite.c: Use int, not EMACS_INT, for characters.
7079 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7080 EMACS_INT, for values that are known to be in character range.
7081 This doesn't fix any bugs but is the usual style inside Emacs and
7082 may generate better code on 32-bit machines.
7083
34206dd2
PE
7084 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7085 This is for reasons similar to the recent CHAR_STRING fix.
7086 * charset.c (Fencode_char): Check that character arg is actually
7087 a character. Pass an int to ENCODE_CHAR.
7088 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7089 wider than 'int', as a compile-time check to prevent future regressions
7090 in this area.
7091
c5958d4c 7092 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7093
7094 Make sure a 64-bit char is never passed to CHAR_STRING.
7095 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7096 by silently ignoring the top 32 bits, allowing some values
7097 that were far too large to be valid characters.
7098 * character.h: Include <verify.h>.
7099 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7100 arguments are no wider than unsigned, as a compile-time check
7101 to prevent future regressions in this area.
7102 * data.c (Faset):
01103c44 7103 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7104 (Fsubst_char_in_region):
7105 * fns.c (concat):
7106 * xdisp.c (decode_mode_spec_coding):
7107 Adjust to CHAR_STRING's new requirement.
7108 * editfns.c (Finsert_char, Fsubst_char_in_region):
7109 * fns.c (concat): Check that character args are actually
7110 characters. Without this test, these functions did the wrong
7111 thing with wildly out-of-range values on 64-bit hosts.
7112
d37ca623
PE
7113 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7114 These casts should not be needed on 32-bit hosts, either.
7115 * keyboard.c (read_char):
7116 * lread.c (Fload): Remove casts to unsigned.
7117
ea204efb
PE
7118 * lisp.h (UNSIGNED_CMP): New macro.
7119 This fixes comparison bugs on 64-bit hosts.
7120 (ASCII_CHAR_P): Use it.
7121 * casefiddle.c (casify_object):
01103c44 7122 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7123 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7124 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7125 * dispextern.h (FACE_FROM_ID):
7126 * keyboard.c (read_char): Use UNSIGNED_CMP.
7127
41cb286c
PE
7128 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7129 not to EMACS_INT, to avoid GCC warning.
7130
4a1b9832
PE
7131 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7132
55daad71
PE
7133 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7134 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7135 isn't needed on 32-bit machines.
8f95c75c 7136
01103c44
PE
7137 * buffer.c (Fgenerate_new_buffer_name):
7138 Use EMACS_INT for count, not int.
0ceccced 7139 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7140
7141 * data.c (Qcompiled_function): Now static.
7142
c6f072e7
PE
7143 * window.c (window_body_lines): Now static.
7144
20ce5912
PE
7145 * image.c (gif_load): Rename local to avoid shadowing.
7146
9c4c5f81
PE
7147 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7148 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7149 * alloc.c (make_save_value): Integer argument is now of type
7150 ptrdiff_t, not int.
7151 (mark_object): Use ptrdiff_t, not int.
7152 * lisp.h (pD): New macro.
7153 * print.c (print_object): Use it.
7154
c0c5c8ae
PE
7155 * alloc.c: Use EMACS_INT, not int, to count objects.
7156 (total_conses, total_markers, total_symbols, total_vector_size)
7157 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7158 (total_free_floats, total_floats, total_free_intervals)
7159 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7160 Now EMACS_INT, not int. All uses changed.
7161 (Fgarbage_collect): Compute overall total using a double, so that
7162 integer overflow is less likely to be a problem. Check for overflow
7163 when converting back to an integer.
5a25e253
PE
7164 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7165 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7166 These were 'int' variables that could overflow on 64-bit hosts;
7167 they were never used, so remove them instead of repairing them.
211a0b2a 7168 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7169 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7170 Previously, this ceilinged at INT_MAX, but that doesn't work on
7171 64-bit machines.
e46bb31a 7172 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7173
c78baabf 7174 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7175 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7176 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7177 when a (possibly-narrower) signed value would do just as well.
7178 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7179
c9d624c6
PE
7180 * alloc.c: Catch some string size overflows that we were missing.
7181 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7182 for convenience in STRING_BYTES_MAX.
7183 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7184 The definition here is exact; the one in lisp.h was approximate.
7185 (allocate_string_data): Check for string overflow. This catches
7186 some instances we weren't catching before. Also, it catches
7187 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7188 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7189 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7190
c9d624c6
PE
7191 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7192 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7193 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7194
353032ce
PE
7195 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7196
2bccce07
PE
7197 * alloc.c (Fmake_string): Check for out-of-range init.
7198
0ac30604
SM
71992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7200
7201 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7202
c195f2de
JD
72032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7204
7205 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7206 xg_get_default_scrollbar_width.
7207
7208 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7209 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7210 (style_changed_cb): Call update_theme_scrollbar_width and call
7211 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7212 all frames (Bug#8505).
7213 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7214 Call gtk_window_set_resizable if HAVE_GTK3.
7215 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7216 and height if HAVE_GTK3 (Bug#8505).
7217 (scroll_bar_width_for_theme): New variable.
7218 (update_theme_scrollbar_width): New function.
7219 (xg_get_default_scrollbar_width): Move code to
7220 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7221 (xg_initialize): Call update_theme_scrollbar_width.
7222
7223 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7224
7225 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7226
e10ac9f1
MR
72272011-06-12 Martin Rudalics <rudalics@gmx.at>
7228
7229 * frame.c (make_frame): Call other_buffer_safely instead of
7230 other_buffer.
7231
7232 * window.c (temp_output_buffer_show): Call display_buffer with
7233 second argument Vtemp_buffer_show_specifiers and reset latter
7234 immediately after the call.
7235 (Vtemp_buffer_show_specifiers): New variable.
7236 (auto_window_vscroll_p, next_screen_context_lines)
7237 (Vscroll_preserve_screen_position): Remove leading asterisks from
7238 doc-strings.
7239
2d3c217e 72402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7241
7b7f97e8 7242 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7243 * buffer.c (Qclone_number): Remove for now, as it's unused.
7244 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7245 (record_buffer): Remove unused local.
7246 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7247 (set_frame_buffer_list): Remove; unused.
7248 * frame.h (other_visible_frames): Remove decl.
7249 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7250 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7251 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7252 if HAVE_GPM.
7253 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7254 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7255 Define only if HAVE_GPM.
7256 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7257 (update_hints_inhibit): Remove; never set. All uses removed.
7258 * widgetprv.h (emacsFrameClassRec): Remove decl.
7259 * window.c (delete_deletable_window): Now returns void, since it
7260 wasn't returning anything.
7261 (compare_window_configurations): Remove unused locals.
7262 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7263 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7264 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7265 the same widths as pointers. This follows up on the 2011-05-06 patch.
7266 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7267 * xterm.h: Likewise.
7268 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7269
1384b89e
JB
72702011-06-12 Juanma Barranquero <lekktu@gmail.com>
7271
7272 * makefile.w32-in: Update dependencies.
7273 (LISP_H): Add lib/intprops.h.
7274
1100a63c
CY
72752011-06-11 Chong Yidong <cyd@stupidchicken.com>
7276
7277 * image.c (gif_load): Add animation frame delay to the metadata.
7278 (syms_of_image): Use DEFSYM. New symbol `delay'.
7279
6198ccd0
MR
72802011-06-11 Martin Rudalics <rudalics@gmx.at>
7281
7282 * window.c (delete_deletable_window): Re-add.
7283 (Fset_window_configuration): Rewrite to handle dead buffers and
7284 consequently deletable windows.
7285 (window_tree, Fwindow_tree): Remove. Supply functionality in
7286 window.el.
7287 (compare_window_configurations): Simplify code.
7288
b6e3633c
AS
72892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7290
1ab0dee5
AS
7291 * image.c (imagemagick_load_image): Fix type mismatch.
7292 (Fimagemagick_types): Likewise.
7293
b6e3633c
AS
7294 * window.h (replace_buffer_in_windows): Declare.
7295
9397e56f
MR
72962011-06-11 Martin Rudalics <rudalics@gmx.at>
7297
7298 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7299 Qclone_number. Remove external declaration of Qdelete_window.
7300 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7301 code.
640c8776
SM
7302 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7303 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7304 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7305 buffer list implementation.
7306 (other_buffer_safely): New function.
7307 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7308 calls to replace_buffer_in_windows and
7309 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7310 if allowed.
7311 (record_buffer): Inhibit quitting and rewrite using quittable
7312 functions. Run Qbuffer_list_update_hook if allowed.
7313 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7314 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7315 Move switch-to-buffer to window.el.
9397e56f
MR
7316 (bury-buffer): Move to window.el.
7317 (Vbuffer_list_update_hook): New variable.
7318
7319 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7320 section.
7321
7322 * window.h (resize_frame_windows): Move up in code.
7323 (Fwindow_frame): Remove EXFUN.
7324 (replace_buffer_in_all_windows): Remove prototype.
7325 (replace_buffer_in_windows_safely): Add prototype.
7326
7327 * window.c: Declare Qdelete_window static again. Move down
7328 declaration of select_count.
7329 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7330 (Fother_window): Move to window.el.
7331 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7332 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7333 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7334 window.el.
7335 (replace_buffer_in_windows): Implement by calling
7336 Qreplace_buffer_in_windows.
7337 (replace_buffer_in_all_windows): Remove with some functionality
7338 moved into replace_buffer_in_windows_safely.
7339 (replace_buffer_in_windows_safely): New function.
7340 (select_window_norecord, select_frame_norecord): Move in front
7341 of run_window_configuration_change_hook. Remove now obsolete
7342 declarations.
640c8776
SM
7343 (Fset_window_buffer): Rewrite doc-string.
7344 Call Qrecord_window_buffer.
9397e56f
MR
7345 (keys_of_window): Move binding for other-window to window.el.
7346
b50691aa
CY
73472011-06-11 Chong Yidong <cyd@stupidchicken.com>
7348
7349 * dispextern.h (struct image): Replace data member, whose int_val
7350 and ptr_val fields were not used by anything, with a single
7351 lisp_val object.
7352
7353 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7354 (gif_clear_image, gif_load, imagemagick_load_image)
7355 (gs_clear_image, gs_load): Callers changed.
7356
3f754b86
PE
73572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7358
cca69397
PE
7359 * buffer.h: Include <time.h>, for time_t.
7360 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7361
109e28d0
PE
7362 Fix minor problems found by static checking.
7363
60737f02
PE
7364 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7365
4b66faf3
PE
7366 Make identifiers static if they are not used in other modules.
7367 * data.c (Qcompiled_function, Qframe, Qvector):
7368 * image.c (QimageMagick, Qsvg):
7369 * minibuf.c (Qmetadata):
7370 * window.c (resize_window_check, resize_root_window): Now static.
7371 * window.h (resize_window_check, resize_root_window): Remove decls.
7372
109e28d0
PE
7373 * window.c (window_deletion_count, delete_deletable_window):
7374 Remove; unused.
46a4ce9e
PE
7375 (window_body_lines): Now static.
7376 (Fdelete_other_windows_internal): Mark vars as initialized.
7377 Make sure 'resize_failed' is initialized.
7378 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7379 (resize_window_apply): Remove unused local.
7380 * window.h (delete_deletable_window): Remove decl.
7381
109e28d0 7382 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7383 (imagemagick_load_image): Fix pointer signedness problem by changing
7384 last arg from unsigned char * to char *. All uses changed.
7385 Also, fix a local for similar reasons.
7386 Remove unused locals. Remove locals to avoid shadowing.
7387 (fn_rsvg_handle_free): Remove; unused.
7388 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7389 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7390
3f754b86
PE
7391 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7392
2547adb1
CY
73932011-06-10 Chong Yidong <cyd@stupidchicken.com>
7394
7395 * image.c (gif_load): Fix omitted cast error introduced by
7396 2011-06-06 change.
7397
2c8e37d4
MR
73982011-06-10 Martin Rudalics <rudalics@gmx.at>
7399
7400 * window.h (resize_proportionally, orig_total_lines)
7401 (orig_top_line): Remove from window structure.
7402 (set_window_height, set_window_width, change_window_heights)
7403 (Fdelete_window): Remove prototypes.
7404 (resize_frame_windows): Remove duplicate declaration.
7405
440a42e3
EZ
74062011-06-10 Eli Zaretskii <eliz@gnu.org>
7407
7408 * window.h (resize_frame_windows, resize_window_check)
7409 (delete_deletable_window, resize_root_window)
7410 (resize_frame_windows): Declare prototypes.
7411
7412 * window.c (resize_window_apply): Make definition be "static" to
7413 match the prototype.
7414
562dd5e9
MR
74152011-06-10 Martin Rudalics <rudalics@gmx.at>
7416
7417 * window.c: Remove declarations of Qwindow_size_fixed,
7418 window_min_size_1, window_min_size_2, window_min_size,
7419 size_window, window_fixed_size_p, enlarge_window, delete_window.
7420 Remove static from declaration of Qdelete_window, it's
7421 temporarily needed by Fbury_buffer.
7422 (replace_window): Don't assign orig_top_line and
7423 orig_total_lines.
7424 (Fdelete_window, delete_window): Remove. Window deletion is
7425 handled by window.el.
640c8776
SM
7426 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7427 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7428 (Fdelete_other_windows): Remove. Deleting other windows is
7429 handled by window.el.
7430 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7431 handled in window.el.
7432 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7433 Window minimum sizes are handled in window.el.
7434 (shrink_windows, size_window, set_window_height)
7435 (set_window_width, change_window_heights, window_height)
7436 (window_width, CURBEG, CURSIZE, enlarge_window)
7437 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7438 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7439 handled in window.el.
7440 (make_dummy_parent): Rename to make_parent_window and give it a
7441 second argument horflag.
7442 (make_window): Don't set resize_proportionally any more.
7443 (Fsplit_window): Remove. Windows are split in window.el.
7444 (save_restore_action, save_restore_orig_size)
7445 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7446 Resize mini windows in window.el.
7447 (grow_mini_window, shrink_mini_window): Implement by calling
7448 Qresize_root_window_vertically, resize_window_check and
7449 resize_window_apply.
640c8776
SM
7450 (saved_window, Fset_window_configuration, save_window_save):
7451 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7452 resize_proportionally.
7453 (window_min_height, window_min_width): Move to window.el.
7454 (keys_of_window): Move bindings for delete-other-windows,
7455 split-window, delete-window and enlarge-window to window.el.
7456
7457 * buffer.c: Temporarily extern Qdelete_window.
7458 (Fbury_buffer): Temporarily call Qdelete_window instead of
7459 Fdelete_window (Fbury_buffer will move to window.el soon).
7460
7461 * frame.c (set_menu_bar_lines_1): Remove code handling
7462 orig_top_line and orig_total_lines.
7463
7464 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7465 set_window_height but set heights directly.
7466 (change_frame_size_1): Use resize_frame_windows.
7467
7468 * xdisp.c (init_xdisp): Don't use set_window_height but set
7469 heights directly.
7470
640c8776
SM
7471 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7472 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7473 run_window_configuration_change_hook.
7474
7475 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7476 instead of change_window_heights and run
7477 run_window_configuration_change_hook.
7478
1a13852e
MR
74792011-06-09 Martin Rudalics <rudalics@gmx.at>
7480
7481 * window.c (replace_window): Rename second argument REPLACEMENT to
7482 NEW. New third argument SETFLAG. Rewrite.
7483 (delete_window, make_dummy_parent): Call replace_window with
7484 third argument 1.
7485 (window_list_1): Move down in code.
7486 (run_window_configuration_change_hook): Move set_buffer part
7487 before select_frame_norecord part in order to unwind correctly.
7488 Rename count1 to count.
7489 (recombine_windows, delete_deletable_window, resize_root_window)
7490 (Fdelete_other_windows_internal)
7491 (Frun_window_configuration_change_hook, make_parent_window)
7492 (resize_window_check, resize_window_apply, Fresize_window_apply)
7493 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7494 (Fdelete_window_internal, Fresize_mini_window_internal):
7495 New functions.
1a13852e
MR
7496 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7497
f3d1777e
MR
74982011-06-08 Martin Rudalics <rudalics@gmx.at>
7499
496e208e
MR
7500 * window.h (window): Add some new members to window structure -
7501 normal_lines, normal_cols, new_total, new_normal, clone_number,
7502 splits, nest, prev_buffers, next_buffers.
7503 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7504 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7505
f3d1777e
MR
7506 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7507 Remove.
496e208e
MR
7508 (make_dummy_parent): Set new members of windows structure.
7509 (make_window): Move down in code. Handle new members of window
7510 structure.
7511 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7512 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7513 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7514 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7515 (Fset_window_next_buffers, Fset_window_clone_number):
7516 New functions.
496e208e
MR
7517 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7518 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7519 Doc-string fixes.
7520 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7521 Argument WINDOW can be now internal window too.
7522 (Fwindow_use_time): Move up in code.
7523 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7524 Rewrite doc-string.
7525 (Fset_window_configuration, saved_window)
7526 (Fcurrent_window_configuration, save_window_save): Handle new
7527 members of window structure.
b9e809c2
MR
7528 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7529 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7530 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7531 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7532 Qget_mru_window, Qresize_root_window,
7533 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7534 Qauto_buffer_name; staticpro them.
f3d1777e 7535
abde8f8c
MR
75362011-06-07 Martin Rudalics <rudalics@gmx.at>
7537
7538 * window.c (Fwindow_total_size, Fwindow_left_column)
7539 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7540 (Fwindow_list_1): New functions.
7541 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7542 (Fwindow_width, Fscroll_left, Fscroll_right):
7543 Use window_body_cols instead of window_box_text_cols.
7544 (delete_window, Fset_window_configuration):
7545 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7546 (delete_all_subwindows): Take a window as argument and not a
7547 structure. Rewrite.
190b47e6
MR
7548 (window_loop): Remove handling of GET_LRU_WINDOW and
7549 GET_LARGEST_WINDOW.
7550 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7551
7552 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7553 window_box_text_cols. delete_all_subwindows now takes a
7554 Lisp_Object as argument.
abde8f8c 7555
640c8776
SM
7556 * indent.c (compute_motion, Fcompute_motion):
7557 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7558
fa8a67e6
MR
7559 * frame.c (delete_frame): Call delete_all_subwindows with root
7560 window as argument.
7561
a54e3482
DC
75622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7563
7564 * fns.c (Fputhash): Document return value.
7565
60002bf5
CY
75662011-06-06 Chong Yidong <cyd@stupidchicken.com>
7567
7568 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7569
0c671da6 75702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7571
b862a52a 7572 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7573
be44ca6c
PE
7574 Check for overflow when converting integer to cons and back.
7575 * charset.c (Fdefine_charset_internal, Fdecode_char):
7576 Use cons_to_unsigned to catch overflow.
7577 (Fencode_char): Use INTEGER_TO_CONS.
7578 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7579 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7580 * data.c (long_to_cons, cons_to_long): Remove.
7581 (cons_to_unsigned, cons_to_signed): New functions.
7582 These signal an error for invalid or out-of-range values.
7583 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7584 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7585 * font.c (Ffont_variation_glyphs):
7586 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7587 * lisp.h: Include <intprops.h>.
7588 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7589 (cons_to_signed, cons_to_unsigned): New decls.
7590 (long_to_cons, cons_to_long): Remove decls.
7591 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7592 (Fprimitive_undo): Use CONS_TO_INTEGER.
7593 * xfns.c (Fx_window_property): Likewise.
7594 * xselect.c: Include <limits.h>.
7595 (x_own_selection, selection_data_to_lisp_data):
7596 Use INTEGER_TO_CONS.
7597 (x_handle_selection_request, x_handle_selection_clear)
7598 (x_get_foreign_selection, Fx_disown_selection_internal)
7599 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7600 (lisp_data_to_selection_data): Use cons_to_unsigned.
7601 (x_fill_property_data): Use cons_to_signed.
7602 Report values out of range.
7603
d1f3d2af
PE
7604 Check for buffer and string overflow more precisely.
7605 * buffer.h (BUF_BYTES_MAX): New macro.
7606 * lisp.h (STRING_BYTES_MAX): New macro.
7607 * alloc.c (Fmake_string):
7608 * character.c (string_escape_byte8):
7609 * coding.c (coding_alloc_by_realloc):
7610 * doprnt.c (doprnt):
7611 * editfns.c (Fformat):
7612 * eval.c (verror):
7613 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7614 since they may not be the same number.
7615 * editfns.c (Finsert_char):
7616 * fileio.c (Finsert_file_contents):
7617 Likewise for BUF_BYTES_MAX.
7618
dd52fcea
PE
7619 * image.c: Use ptrdiff_t, not int, for sizes.
7620 (slurp_file): Switch from int to ptrdiff_t.
7621 All uses changed.
7622 (slurp_file): Check that file size fits in both size_t (for
7623 malloc) and ptrdiff_t (for sanity and safety).
7624
7f9bbdbb
PE
7625 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7626 if b->modtime has its maximal value.
7627
dfe18f82
PE
7628 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7629
84acfcf0
PE
7630 Don't assume time_t can fit into int.
7631 * buffer.h (struct buffer.modtime): Now time_t, not int.
7632 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7633 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7634
ccd9a01a
PE
7635 Minor fixes for signed vs unsigned integers.
7636 * character.h (MAYBE_UNIFY_CHAR):
7637 * charset.c (maybe_unify_char):
7638 * keyboard.c (read_char, reorder_modifiers):
7639 XINT -> XFASTINT, since the integer must be nonnegative.
7640 * ftfont.c (ftfont_spec_pattern):
7641 * keymap.c (access_keymap, silly_event_symbol_error):
7642 XUINT -> XFASTINT, since the integer must be nonnegative.
7643 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7644 since it makes no difference and we prefer signed.
7645 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7646 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7647 nonnegative.
7648
d6d100dd
SM
76492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7650
7651 * window.h (Fwindow_frame): Declare.
7652
2b6148e4
PE
76532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7654
7655 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7656 (SPARE_MEMORY): Always define.
7657 (LARGE_REQUEST): Remove.
7658 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7659
f230ecc9
MR
76602011-06-06 Martin Rudalics <rudalics@gmx.at>
7661
727e958e
MR
7662 * lisp.h: Move EXFUNS for Fframe_root_window,
7663 Fframe_first_window and Fset_frame_selected_window to window.h.
7664
7665 * window.h: Move EXFUNS for Fframe_root_window,
7666 Fframe_first_window and Fset_frame_selected_window here from
7667 lisp.h.
7668
7669 * frame.c (Fwindow_frame, Fframe_first_window)
7670 (Fframe_root_window, Fframe_selected_window)
7671 (Fset_frame_selected_window): Move to window.c.
7672 (Factive_minibuffer_window): Move to minibuf.c.
7673 (Fother_visible_frames_p): New function.
7674
7675 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7676
f230ecc9
MR
7677 * window.c (decode_window, decode_any_window): Move up in code.
7678 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7679 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7680 (Fwindow_buffer): Move up and rewrite doc-string.
7681 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7682 (Fwindow_prev): New functions.
727e958e
MR
7683 (Fwindow_frame): Move here from frame.c. Accept any window as
7684 argument.
7685 (Fframe_root_window, Fframe_first_window)
7686 (Fframe_selected_window): Move here from frame.c. Accept frame
7687 or arbitrary window as argument. Update doc-strings.
7688 (Fminibuffer_window): Move up in code.
7689 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7690 (Fset_frame_selected_window): Move here from frame.c.
7691 Marginal rewrite.
727e958e
MR
7692 (Fselected_window, select_window, Fselect_window): Move up in
7693 code. Minor doc-string fixes.
f230ecc9 7694
4d09bcf6
PE
76952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7696
7697 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7698 Do not assume that spare memory exists; that assumption is valid
7699 only if SYSTEM_MALLOC.
7700 (LARGE_REQUEST): New macro, so that the issue of large requests
7701 is separated from the issue of spare memory.
7702
810928a2
AS
77032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7704
172418ad
AS
7705 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7706 format. (Bug#8806)
7707
43f862f7
AS
7708 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7709
810928a2
AS
7710 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7711 before statements.
7712
a059fe24
JD
77132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7714
7715 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7716
7717 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7718
7719 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7720 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7721
989bf368
JB
77222011-06-05 Juanma Barranquero <lekktu@gmail.com>
7723
7724 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7725
4b80f674
CY
77262011-06-04 Chong Yidong <cyd@stupidchicken.com>
7727
7728 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7729 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7730 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7731 New error handlers.
4b80f674
CY
7732 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7733 Obey Vx_select_enable_clipboard_manager. Catch errors in
7734 x_clipboard_manager_save (Bug#8779).
7735 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7736 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7737
99a33b77 77382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7739
7740 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7741
99a33b77 77422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7743
7744 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7745 in the current matrix if keep_current_p is non-zero.
7746
8264569d
EZ
77472011-06-04 Eli Zaretskii <eliz@gnu.org>
7748
7749 * bidi.c (bidi_level_of_next_char): Fix last change.
7750
57f97249
EZ
77512011-06-03 Eli Zaretskii <eliz@gnu.org>
7752
fec2107c 7753 Support bidi reordering of text covered by display properties.
57f97249 7754
fec2107c
EZ
7755 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7756 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7757 (bidi_cache_search, bidi_cache_iterator_state)
7758 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7759 (bidi_level_of_next_char, bidi_move_to_visually_next):
7760 Support character positions inside a run of characters covered by a
fec2107c
EZ
7761 display string.
7762 (bidi_paragraph_init, bidi_resolve_explicit_1)
7763 (bidi_level_of_next_char): Call bidi_fetch_char and
7764 bidi_fetch_char_advance instead of FETCH_CHAR and
7765 FETCH_CHAR_ADVANCE.
7766 (bidi_init_it): Initialize new members.
7767 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7768 definitions.
7769 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7770 instead of using explicit *_CHAR codes.
d6d100dd
SM
7771 (bidi_resolve_explicit, bidi_resolve_weak):
7772 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7773 bidirectional text is supported only in multibyte buffers.
7774 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7775 it to initialize the frame_window_p member of struct bidi_it.
7776 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7777 (bidi_resolve_explicit, bidi_resolve_weak)
7778 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7779 bidi_it->nchars is non-positive.
7780 (bidi_level_of_next_char): Don't try to lookup the cache for the
7781 next/previous character if nothing is cached there yet, or if we
7782 were just reseat()'ed to a new position.
c40e2fb2 7783
0e14fe90
EZ
7784 * xdisp.c (set_cursor_from_row): Set start and stop points
7785 according to the row's direction when priming the loop that looks
7786 for the glyph on which to display cursor.
7787 (single_display_spec_intangible_p): Function deleted.
7788 (display_prop_intangible_p): Reimplement to call
7789 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7790 Accept 3 additional arguments needed by handle_display_spec.
7791 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7792 values: lists, `(when COND...)' forms, etc.
7793 (single_display_spec_string_p): Support property values that are
7794 lists with the argument STRING its top-level element.
7795 (display_prop_string_p): Fix the condition for processing a
7796 property that is a list to be consistent with handle_display_spec.
fec2107c 7797 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7798 last portion of handle_display_prop.
7799 (compute_display_string_pos): Accept additional argument
7800 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7801 value of a `display' property is a "replacing spec".
7802 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7803 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7804 the display property, but just return a value indicating whether
7805 the display property will replace the characters it covers.
7806 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7807 frame_window_p members of struct bidi_it.
d6d100dd
SM
7808 (compute_display_string_pos, compute_display_string_end):
7809 New functions.
fec2107c
EZ
7810 (push_it): Accept second argument POSITION, where pop_it should
7811 jump to continue iteration.
7812 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7813
fec2107c
EZ
7814 * keyboard.c (adjust_point_for_property): Adjust the call to
7815 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7816
7817 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7818 (bidi_init_it): Update prototypes.
7819 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7820 (compute_display_string_pos, compute_display_string_end):
7821 Declare prototypes.
fec2107c
EZ
7822 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7823 EMACS_INT.
fc6f18ce 7824
40087514 78252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7826
57f53182
PE
7827 Malloc failure behavior now depends on size of allocation.
7828 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7829 * lisp.h: Change signatures accordingly.
7830 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7831 All callers changed. (Bug#8762)
7832
7833 * gnutls.c: Use Emacs's memory allocators.
7834 Without this change, the gnutls library would invoke malloc etc.
7835 directly, which causes problems on non-SYNC_INPUT hosts, and which
7836 runs afoul of improving memory_full behavior. (Bug#8761)
7837 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7838 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7839 xfree instead of the default malloc, realloc, free.
7840 (Fgnutls_boot): No need to check for memory allocation failure,
7841 since xmalloc does that for us.
7842
ac32cd99 7843 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7844 * category.c (hash_get_category_set):
7845 * ccl.c (ccl_driver):
7846 * charset.c (Fdefine_charset_internal):
7847 * charset.h (struct charset.hash_index):
7848 * composite.c (get_composition_id, gstring_lookup_cache)
7849 (composition_gstring_put_cache):
7850 * composite.h (struct composition.hash_index):
7851 * dispextern.h (struct image.hash):
7852 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7853 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7854 (hashfn_equal, hashfn_user_defined, make_hash_table)
7855 (maybe_resize_hash_table, hash_lookup, hash_put)
7856 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7857 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7858 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7859 * image.c (make_image, search_image_cache, lookup_image)
7860 (xpm_put_color_table_h):
7861 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7862 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7863 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7864 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7865 * alloc.c (allocate_vectorlike):
7866 Check for overflow in vector size calculations.
7867 * ccl.c (ccl_driver):
7868 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7869 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7870 need to be updated by these changes.
40087514
PE
7871 * fns.c (make_hash_table, maybe_resize_hash_table):
7872 Check for integer overflow with large hash tables.
0de4bb68
PE
7873 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7874 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7875 (SXHASH_REDUCE): New macro.
7876 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7877 Use it instead of discarding useful hash info with large hash values.
7878 (sxhash_float): New function.
7879 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7880 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7881 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7882 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7883 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7884 Adjust signatures to match updated version of code.
7885 (consing_since_gc): Now EMACS_INT, since a single hash table can
7886 use more than INT_MAX bytes.
7887
698d32e2
DN
78882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7889
7890 Make it possible to build with GCC-4.6+ -O2 -flto.
7891
7892 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7893
fd6fa53f
SM
78942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7895
7896 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7897 Call minibuffer-inactive-mode.
7898
864db017
JB
78992011-05-31 Juanma Barranquero <lekktu@gmail.com>
7900
7901 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7902 Update dependencies.
7903
2ad0baf4
DN
79042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7905
7906 * data.c (init_data): Remove code for UTS, this system is not
7907 supported anymore.
7908
4fcc2638
DN
79092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7910
7911 Don't force ./temacs to start in terminal mode.
7912
7913 * frame.c (make_initial_frame): Initialize faces in all cases, not
7914 only when CANNOT_DUMP is defined.
7915 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7916
c56e0fd5
DN
79172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7918
7919 * dispnew.c (add_window_display_history): Use const for the string
7920 pointer. Remove declaration, not needed.
7921
333d54da 79222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7923
55d4c1b2 7924 Use 'inline', not 'INLINE'.
333d54da 7925 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7926 * alloc.c, fontset.c (INLINE): Remove.
7927 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7928 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7929 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7930 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7931 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7932
738db178
DN
79332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7934
7935 Make it possible to run ./temacs.
7936
7937 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7938 syms_of_callproc does the same thing. Remove test for
7939 "initialized", do it in the caller.
7940 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7941
620c53a6
SM
79422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7943
7944 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7945 (read_minibuf): Use get_minibuffer.
7946 (syms_of_minibuf): Use DEFSYM.
7947 (Qmetadata): New var.
7948 * data.c (Qbuffer): Don't make it static.
7949 (syms_of_data): Use DEFSYM.
7950
e003a292
PE
79512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7952
7953 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7954 (CCL_CODE_MIN): New macro.
7955
ed008a6d
PE
79562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7957
3687c2ef
PE
7958 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7959
ed008a6d
PE
7960 * eval.c (Qdebug): Now static.
7961 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7962 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7963 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7964
d66c4c7c
CY
79652011-05-29 Chong Yidong <cyd@stupidchicken.com>
7966
7967 * image.c: Various fixes to ImageMagick code comments.
7968 (Fimagemagick_types): Doc fix.
7969
5fbc2025
PE
79702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7971
0196f88a
PE
7972 Minor fixes prompted by GCC 4.6.0 warnings.
7973
7974 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7975
5fbc2025
PE
7976 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7977 (x_clipboard_manager_save_all): Move extern decl to ...
7978 * xterm.h: ... here, so that it can be checked for consistency.
7979
1dd3c2d9
CY
79802011-05-29 Chong Yidong <cyd@stupidchicken.com>
7981
7982 * xselect.c (x_clipboard_manager_save_frame)
7983 (x_clipboard_manager_save_all): New functions.
7984 (Fx_clipboard_manager_save): Lisp function deleted.
7985
7986 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7987 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7988
7989 * xterm.h: Update prototype.
7990
5ba6571d
WX
79912011-05-28 William Xu <william.xwl@gmail.com>
7992
7993 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7994 exiting (Bug#8239).
7995
3eaff834
JM
79962011-05-28 Jim Meyering <meyering@redhat.com>
7997
e1900994 7998 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7999 * fns.c (to_uchar): Define.
8000 (crypto_hash_function): Use it to convert some newly-signed
8001 variables to unsigned, to avoid sign-extension bugs. For example,
8002 without this change, (md5 "truc") would evaluate to
8003 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8004 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8005 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8006
0f6990a7
PE
80072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8008
8009 Integer overflow fixes.
c8a9ca5a 8010
08686060
PE
8011 * dbusbind.c: Serial number integer overflow fixes.
8012 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8013 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8014 to hold a serial number that is too large for a fixnum.
8015 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8016 Check for serial numbers out of range. Decode any serial number
59568bf0 8017 that was so large that it became a float. (Bug#8722)
08686060 8018
2d1fc3c7
PE
8019 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8020 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8021 Use XFASTINT rather than XUINT when numbers are nonnegative.
8022 (xd_append_arg, Fdbus_method_return_internal):
8023 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8024 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8025 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8026 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8027 (Bug#8722)
2d1fc3c7 8028
c8a9ca5a
PE
8029 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8030
519e1d69
PE
8031 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8032
6df6ae42 8033 ccl: Add integer overflow checks.
30569699
PE
8034 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8035 (IN_INT_RANGE): New macros.
8036 (ccl_driver): Use them to check for integer overflow when
8037 decoding a CCL program. Many of the new checks are whether XINT (x)
8038 fits in int; it doesn't always, on 64-bit hosts. The new version
8039 doesn't catch all possible integer overflows, but it's an
847044ea 8040 improvement. (Bug#8719)
30569699 8041
c11285dc
PE
8042 * alloc.c (make_event_array): Use XINT, not XUINT.
8043 There's no need for unsigned here.
8044
fdccd48e
PE
8045 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8046 This follows up to the 2011-05-06 change that substituted uintptr_t
8047 for EMACS_INT. This case wasn't caught back then.
8048
37910ab2
PE
8049 Rework Fformat to avoid integer overflow issues.
8050 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8051 now (part of C89). Include <verify.h>.
8052 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8053 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8054 (Fformat): Avoid the prepass trying to compute sizes; it was only
8055 approximate and thus did not catch overflow reliably. Instead, walk
8056 through the format just once, formatting and computing sizes as we go,
8057 checking for integer overflow at every step, and allocating a larger
8058 buffer as needed. Keep track separately whether the format is
8059 multibyte. Keep only the most-recently calculated precision, rather
8060 than them all. Record whether each argument has been converted to
8061 string. Use EMACS_INT, not int, for byte and char and arg counts.
8062 Support field widths and precisions larger than INT_MAX. Avoid
8063 sprintf's undefined behavior with conversion specifications such as %#d
8064 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8065 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8066 formatting out-of-range floating point numbers with int
9173deec 8067 formats. (Bug#8668)
37910ab2 8068
2e6578fb
PE
8069 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8070
0ae6bdee
PE
8071 * data.c: Avoid integer truncation in expressions involving floats.
8072 * data.c: Include <intprops.h>.
8073 (arith_driver): When there's an integer overflow in an expression
8074 involving floating point, convert the integers to floating point
8075 so that the resulting value does not suffer from catastrophic
8076 integer truncation. For example, on a 64-bit host (* 4
8077 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8078 Do not rely on undefined behavior after integer overflow.
8079
de883a70
PE
8080 merge count_size_as_multibyte, parse_str_to_multibyte
8081 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8082 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8083 Check for integer overflow.
8084 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8085 since it's now a duplicate of the other. This is more of
8086 a character than a buffer op, so better that it's in character.c.
8087 * fns.c, print.c: Adjust to above changes.
8088
2ff916cb
PE
80892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8090
8091 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8092
f1b54466
PE
80932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8094
fb1ac845
PE
8095 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8096 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8097 (x_clipboard_manager_save): Now static.
8098 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8099
f1b54466
PE
8100 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8101 (crypto_hash_function): Now static.
8102 Fix pointer signedness problems. Avoid unnecessary initializations.
8103
a9f737ee
CY
81042011-05-27 Chong Yidong <cyd@stupidchicken.com>
8105
8106 * termhooks.h (Vselection_alist): Make it terminal-local.
8107
8108 * terminal.c (create_terminal): Initialize it.
8109
8110 * xselect.c: Support for clipboard managers.
8111 (Vselection_alist): Move to termhooks.h as terminal-local var.
8112 (LOCAL_SELECTION): New macro.
8113 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8114 (symbol_to_x_atom): Remove gratuitous arg.
8115 (x_handle_selection_request, lisp_data_to_selection_data)
8116 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8117 (x_own_selection, x_get_local_selection, x_convert_selection):
8118 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8119 (some_frame_on_display): Delete unused function.
8120 (Fx_own_selection_internal, Fx_get_selection_internal)
8121 (Fx_disown_selection_internal, Fx_selection_owner_p)
8122 (Fx_selection_exists_p): New optional frame arg.
8123 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8124 (x_handle_selection_clear): Don't treat other terminals with the
8125 same keyboard specially. Use the terminal-local Vselection_alist.
8126 (x_clear_frame_selections): Use Frun_hook_with_args.
8127
8128 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8129
8130 * xterm.h: Add support for those atoms.
8131
e067f0c1
CY
81322011-05-26 Chong Yidong <cyd@stupidchicken.com>
8133
8134 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8135 (converted_selections, conversion_fail_tag): New global variables.
8136 (x_selection_request_lisp_error): Free the above.
8137 (x_get_local_selection): Remove unnecessary code.
8138 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8139 of converted selections stored in converted_selections.
8140 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8141 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8142 (x_convert_selection): New function.
8143 (x_handle_selection_event): Simplify.
8144 (x_get_foreign_selection): Don't ignore incoming requests while
8145 waiting for an answer; this will fail when we implement
8146 SAVE_TARGETS, and seems unnecessary anyway.
8147 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8148 (Vx_sent_selection_functions): Doc fix.
8149
0f4aebc0
LL
81502011-05-26 Leo Liu <sdl.web@gmail.com>
8151
8152 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8153
e61124cd
YM
81542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8155
8156 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8157
8158 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8159 for fringe update if it has periodic bitmap.
ac389d0c 8160 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8161 and fringe_bitmap_periodic_p.
8162
8163 * fringe.c (get_fringe_bitmap_data): New function.
8164 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8165 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8166 row. Mark glyph row for fringe update if periodicity changed.
8167
8168 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8169 for fringe update unless it has periodic bitmap.
8170
f16d9837
KH
81712011-05-25 Kenichi Handa <handa@m17n.org>
8172
8173 * xdisp.c (get_next_display_element): Set correct it->face_id for
8174 a static composition.
8175
e1b90ef6
LL
81762011-05-24 Leo Liu <sdl.web@gmail.com>
8177
8178 * deps.mk (fns.o):
8179 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8180
8181 * fns.c (crypto_hash_function, Fsha1): New function.
8182 (Fmd5): Use crypto_hash_function.
8183 (syms_of_fns): Add Ssha1.
8184
7400048f
PE
81852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8186
8187 * gnutls.c: Remove unused macros.
8188 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8189 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8190 Remove macros that are defined and never used.
8191 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8192
abb71cf4
CY
81932011-05-22 Chong Yidong <cyd@stupidchicken.com>
8194
8195 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8196 (Fx_get_selection_internal): Minor cleanup.
8197 (Fx_own_selection_internal): Rename arguments for consistency with
8198 select.el.
8199
6307db39
PE
82002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8201
8202 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8203
f3d4e0a4
CY
82042011-05-22 Chong Yidong <cyd@stupidchicken.com>
8205
8206 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8207
4d8ade89
YM
82082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8209
8210 * dispnew.c (scrolling_window): Don't exclude the case that the
8211 last enabled row in the desired matrix touches the bottom boundary.
8212
32078c8d
GM
82132011-05-21 Glenn Morris <rgm@gnu.org>
8214
8215 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8216 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8217 and add some more files.
32078c8d 8218
7285dc67
EZ
82192011-05-20 Eli Zaretskii <eliz@gnu.org>
8220
8221 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8222 report_file_error introduced by the change from 2011-05-07.
8223
89d1bd22
PE
82242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8225
8226 * systime.h (Time): Define only if emacs is defined.
8227 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8228 where the include path doesn't have X11/X.h by default. See
8229 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8230
cd394be1 82312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8232
8233 * composite.c (find_automatic_composition): Fix previous change.
8234
b9704ad9
GM
82352011-05-20 Glenn Morris <rgm@gnu.org>
8236
8237 * lisp.mk: New file, split from Makefile.in.
8238 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8239 (shortlisp): Remove.
8240 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8241
4a720484
GM
82422011-05-19 Glenn Morris <rgm@gnu.org>
8243
8244 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8245 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8246 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8247 (lisp): Set the order to that of loadup.el.
8248 (shortlisp): Make it a copy of $lisp.
8249 (SOME_MACHINE_LISP): Remove.
8250 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8251 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8252
a28d4396
KH
82532011-05-18 Kenichi Handa <handa@m17n.org>
8254
8255 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8256 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8257 (find_automatic_composition): Mostly rewrite for efficiency.
8258
a2b1fa8e
JB
82592011-05-18 Juanma Barranquero <lekktu@gmail.com>
8260
8261 * makefile.w32-in: Update dependencies.
8262
8e1f5610
CS
82632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8264
8265 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8266 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8267
7025ee00 82682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8269
cdfa6eab
PE
8270 Fix some integer overflow issues, such as string length overflow.
8271
06d6db33
PE
8272 * insdel.c (count_size_as_multibyte): Check for string overflow.
8273
2b4560a8
PE
8274 * character.c (lisp_string_width): Check for string overflow.
8275 Use EMACS_INT, not int, for string indexes and lengths; in
8276 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8277 the resulting string length overflows an EMACS_INT; instead,
8278 report a string overflow if no precision given. When checking for
8279 precision exhaustion, use a check that cannot possibly have
8280 integer overflow. (Bug#8675)
8281 * character.h (lisp_string_width): Adjust to new signature.
8282
cb93f9be
PE
8283 * alloc.c (string_overflow): New function.
8284 (Fmake_string): Use it. This doesn't change behavior, but saves
8285 a few bytes and will simplify future changes.
8286 * character.c (string_escape_byte8): Likewise.
8287 * lisp.h (string_overflow): New decl.
8288
1a1f3366
PE
8289 Fixups, following up to the user-interface timestamp change.
8290 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8291 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8292 * msdos.c (mouse_get_pos): Likewise.
8293 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8294 * w32gui.h (Time): Define by including "systime.h" rather than by
8295 declaring it ourselves. (Bug#8664)
8296
d4e3e4d3
PE
8297 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8298 * image.c (clear_image_cache): Likewise.
8299
f6a24d19
PE
8300 * term.c (term_mouse_position): Don't assume time_t wraparound.
8301
08dc5ae6
PE
8302 Be more systematic about user-interface timestamps.
8303 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8304 and sometimes 'EMACS_UINT', to represent these timestamps.
8305 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8306 This makes the code easier to follow, and makes it easier to catch
8307 integer overflow bugs such as Bug#8664.
8308 * frame.c (Fmouse_position, Fmouse_pixel_position):
8309 Use Time, not unsigned long, for user-interface timestamps.
8310 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8311 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8312 * keyboard.h (last_event_timestamp): Likewise.
8313 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8314 * menu.h (xmenu_show): Likewise.
8315 * term.c (term_mouse_position): Likewise.
8316 * termhooks.h (struct input_event.timestamp): Likewise.
8317 (struct terminal.mouse_position_hook): Likewise.
8318 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8319 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8320 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8321 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8322 what it was before.
8323 * menu.h, termhooks.h: Include "systime.h", for Time.
8324
8e55734a
PE
8325 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8326 Don't assume that the difference between two unsigned long values
8327 can fit into an integer. At this point, we know button_down_time
8328 <= event->timestamp, so the difference must be nonnegative, so
8329 there's no need to cast the result if double-click-time is
8330 nonnegative, as it should be; check that it's nonnegative, just in
8331 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8332 apart (about 25 days). (Bug#8664)
8e55734a 8333
841f1b75 8334 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8335 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8336
3e26f69c
PE
8337 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8338 that always fit in int. Use a sentinel instead of a counter, to
8339 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8340 * frame.h (struct frame): Use int for menu_bar_items_used
8341 instead of EMACS_INT, since it always fits in int.
3e26f69c 8342
5cc152c0
PE
8343 * menu.c (grow_menu_items): Check for int overflow.
8344
d89eb65e
PE
8345 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8346
5235bd3e
PE
8347 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8348 Before, the code was not consistent. These values cannot exceed
8349 2**31 - 1 so there's no need to make them unsigned.
8350 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8351 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8352 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8353 as modifiers.
8354 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8355
bc827e23
PE
8356 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8357 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8358 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8359 presumably because the widths might not match.
8360
78eb494e
PE
8361 * window.c (size_window): Avoid needless test at loop start.
8362
04f2d78b
CB
83632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8364
8365 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8366
d2fc7e3d 83672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8368
8369 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8370
d2fc7e3d 83712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8372
8373 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8374 `width' to `bar_area_x' and `bar_area_width', respectively.
8375 (x_scroll_run): Take account of fringe background extension.
8376
04f2d78b
CB
8377 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8378 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8379 `bar_area_width', respectively.
8380 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8381 background extension.
8382
79b70037
GM
83832011-05-10 Jim Meyering <meyering@redhat.com>
8384
8385 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8386
2f142cc5
JB
83872011-05-10 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * image.c (Finit_image_library): Return t for built-in image types,
8390 like pbm and xbm. (Bug#8640)
8391
57679c86
AS
83922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8393
8394 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8395
888c9e86
EZ
83962011-05-07 Eli Zaretskii <eliz@gnu.org>
8397
b0512a1d
EZ
8398 * w32console.c (Fset_screen_color): Doc fix.
8399 (Fget_screen_color): New function.
8400 (syms_of_ntterm): Defsubr it.
8401
7285dc67
EZ
8402 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8403 unlink the temporary file if Fcall_process didn't create it in the
8404 first place.
8405 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8406 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8407 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8408 cue to call_process_cleanup not to close that handle.
8409
4d3fcc8e
BK
84102011-05-07 Ben Key <bkey76@gmail.com>
8411
8412 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8413 one of two shell specific rules, either bootstrap-temacs-CMD or
8414 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8415 to the previous implementation of the bootstrap-temacs rule.
8416 The bootstrap-temacs-CMD rule is similar to the previous
8417 implementation of the bootstrap-temacs rule except that it
8418 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8419 variable.
8420
8421 These changes, along with some changes to nt/configure.bat,
8422 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8423 earlier fix to add support for --cflags and --ldflags options
8424 that include quotes so that it works whether make uses cmd or
8425 sh as the shell.
8426
b4289b64
MA
84272011-05-06 Michael Albinus <michael.albinus@gmx.de>
8428
8429 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8430 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8431 is a constant.
8432 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8433 a string. Handle both cases.
8434 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8435 (Fdbus_register_method): Use Qinvalid_function.
8436
af4c0e28
JB
84372011-05-06 Juanma Barranquero <lekktu@gmail.com>
8438
8439 * makefile.w32-in: Update dependencies.
8440 (LISP_H): Add inttypes.h and stdin.h.
8441 (PROCESS_H): Add unistd.h.
8442
c51453d9
EZ
84432011-05-06 Eli Zaretskii <eliz@gnu.org>
8444
8445 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8446 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8447
8ff0ac3c 84482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8449
4c4b566b
PE
8450 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8451
aab2b9b5
PE
8452 * term.c (vfatal): Remove stray call to va_end.
8453 It's not needed and the C Standard doesn't allow it here anyway.
8454
c378da0b
PE
8455 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8456 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8457
288b08c7
PE
8458 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8459 bytes.
8460
e3601888
PE
8461 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8462
db6c0e74
PE
8463 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8464
dd5963ea
PE
8465 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8466
88c9450f
PE
8467 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8468
2f9442b8
PE
8469 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8470
c032b5f8
PE
8471 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8472 * charset.c (Fdefine_charset_internal): Don't initialize
8473 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8474 32-bit int (Bug#8600).
a108c10b
PE
8475
8476 * lread.c (read_integer): Be more consistent with string-to-number.
8477 Use string_to_number to do the actual conversion; this avoids
8478 rounding errors and fixes some other screwups. Without this fix,
8479 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8480 (digit_to_number): Move earlier, for benefit of read_integer.
8481 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8482 not a digit in any supported base. (Bug#8602)
a108c10b 8483
ad5f9eea
PE
8484 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8485
aec1708a
PE
8486 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8487 to match comment at start of function. This also removes a
8488 GCC warning about overflow in a 32+64-bit port.
8489
47be4ab5
PE
8490 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8491
371cac43
PE
8492 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8493 Reported by Stefan Monnier in
8494 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8495 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8496 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8497
d01a7826
PE
8498 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8499 (EMACS_UINTPTR): Likewise, with uintptr_t.
8500
7fd47d5c
PE
8501 * lisp.h: Prefer 64-bit EMACS_INT if available.
8502 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8503 on 32-bit hosts that have 64-bit int, so that they can access
8504 large files.
122b0c86
PE
8505 However, temporarily disable this change unless the temporary
8506 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8507
8727937b
PE
8508 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8509
8ac068ac
PE
8510 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8511 This removes an assumption that EMACS_INT and long are the same
8512 width as pointers. The assumption is true for Emacs porting targets
8513 now, but we want to make other targets possible.
8514 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8515 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8516 In the rest of the code, change types of integers that hold casted
8517 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8518 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8519 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8520 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8521 No need to cast type when ORing.
8522 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8523 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8524 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8525 assume EMACS_INT is the same width as char *.
8526 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8527 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8528 Remove no-longer-needed casts.
8529 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8530 (xg_tool_bar_help_callback, xg_make_tool_item):
8531 Use EMACS_INTPTR to hold an integer
8532 that will be cast to void *; this can avoid a GCC warning
8533 if EMACS_INT is not the same width as void *.
8534 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8535 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8536 (current_message_1, set_message_1):
8537 Use a local to convert to proper width without a cast.
8538 * xmenu.c (dialog_selection_callback): Likewise.
8539
ede49d71
PE
8540 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8541 Also, don't assume VALBITS / RAND_BITS is less than 5,
8542 and don't rely on undefined behavior when shifting a 1 left into
8543 the sign bit.
8544 * lisp.h (get_random): Change signature to match.
8545
2f30ecd0
PE
8546 * lread.c (hash_string): Use size_t, not int, for hash computation.
8547 Normally we prefer signed values; but hashing is special, because
8548 it's better to use unsigned division on hash table sizes so that
8549 the remainder is nonnegative. Also, size_t is the natural width
8550 for hashing into memory. The previous code used 'int', which doesn't
8551 retain enough info to hash well into very large tables.
8552 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8553
2a866e7b
PE
8554 * dbusbind.c: Don't possibly lose pointer info when converting.
8555 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8556 Use XPNTR rather than XHASH, so that the high-order bits of
8557 the pointer aren't lost when converting through void *.
8558
51639eac
PE
8559 * eval.c (Fautoload): Don't double-shift a pointer.
8560
92394119
PE
8561 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8562
dbdb9a7c
JB
85632011-05-06 Juanma Barranquero <lekktu@gmail.com>
8564
8565 * gnutls.c (DEF_GNUTLS_FN):
8566 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8567
db7a0b4f
AS
85682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8569
8570 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8571 marker. (Bug#8610)
8572
cd394be1 85732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8574
8575 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8576 New version that can reserve upto 2GB of heap space.
8577
f7ff1b0f 85782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8579
8580 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8581
639c109b
TZ
85822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8583
8584 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8585 `gnutls_certificate_set_x509_key_file'.
8586
d2127135
JB
85872011-05-05 Juanma Barranquero <lekktu@gmail.com>
8588
8589 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8590 Update dependencies.
8591
e968f4f3
JB
85922011-05-04 Juanma Barranquero <lekktu@gmail.com>
8593
8594 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8595 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8596 Remove unused parameter `fildes'.
8597 * process.c (read_process_output, send_process): Don't pass it.
8598
84d358f0
JB
85992011-05-04 Juanma Barranquero <lekktu@gmail.com>
8600
8601 Fix previous change: the library cache is defined in w32.c.
8602 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8603 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8604
0898ca10
JB
86052011-05-04 Juanma Barranquero <lekktu@gmail.com>
8606
8607 Implement dynamic loading of GnuTLS on Windows.
8608
8609 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8610 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8611 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8612 Declare.
8613
8614 * gnutls.c (Qgnutls_dll): Define.
8615 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8616 (gnutls_*): Declare function pointers.
8617 (init_gnutls_functions): New function to initialize function pointers.
8618 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8619 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8620 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8621 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8622 (emacs_gnutls_write, emacs_gnutls_read)
8623 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8624 (Fgnutls_available_p): New function.
8625 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8626 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8627 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8628
8629 * image.c: Include w32.h.
8630 (Vimage_type_cache): Delete.
8631 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8632 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8633 (w32_delayed_load): Move to w32.c.
8634
8635 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8636
8637 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8638 (w32_delayed_load): Move from image.c. When loading a library, record
8639 its filename in the :loaded-from property of the library id.
8640 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8641 Initialize and staticpro them.
8642 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8643
8644 * process.c: Include lisp.h before w32.h, not after.
8645 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8646 instead of gnutls_record_check_pending.
8647
8648 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8649
ff4de4aa
TZ
86502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8651
8652 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8653 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8654 as passed in.
8655
abe95abb
JD
86562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8657
8658 * xterm.c (x_set_frame_alpha): Do not set property on anything
8659 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8660
e16e55d4
JB
86612011-05-02 Juanma Barranquero <lekktu@gmail.com>
8662
8663 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8664
bafcf6a5
JB
86652011-05-02 Juanma Barranquero <lekktu@gmail.com>
8666
8667 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8668 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8669 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8670 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8671 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8672 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8673 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8674 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8675 (Qgnutls_bootprop_callbacks_verify): Make static.
8676
e7a6747f
AS
86772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8678
19ed11ba
AS
8679 * callproc.c: Indentation fixup.
8680
e7a6747f 8681 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8682 (wait_for_termination, interruptible_wait_for_termination):
8683 Move after wait_for_termination_1.
e7a6747f 8684
1ef14cb4
LMI
86852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8686
8687 * sysdep.c (interruptible_wait_for_termination): New function
8688 which is like wait_for_termination, but allows keyboard
8689 interruptions.
8690
8691 * callproc.c (Fcall_process): Add (:file "file") as an option for
8692 the STDOUT buffer.
8693 (Fcall_process_region): Ditto.
8694
330d880c
EZ
86952011-04-30 Eli Zaretskii <eliz@gnu.org>
8696
8db90b73
EZ
8697 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8698 rather than `XVECTOR (FOO)->size'.
8699
330d880c
EZ
8700 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8701 inttypes.h, as a gnulib replacement is used if it not available in
8702 system headers.
8703
15cbd324
EZ
87042011-04-21 Eli Zaretskii <eliz@gnu.org>
8705
8706 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8707 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8708 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8709
8710 * coding.c (coding_alloc_by_realloc): Error out if destination
8711 will grow beyond MOST_POSITIVE_FIXNUM.
8712 (decode_coding_emacs_mule): Abort if there isn't enough place in
8713 charbuf for the composition carryover bytes. Reserve an extra
8714 space for up to 2 characters produced in a loop.
8715 (decode_coding_iso_2022): Abort if there isn't enough place in
8716 charbuf for the composition carryover bytes.
8717
87182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8719
ae940cca
EZ
8720 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8721 aborting when %lld or %lll format is passed.
8722 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8723 %llo or %llx format is passed. (Bug#8545)
8724
03ab8921
EZ
8725 * window.c (window_scroll_line_based): Use a marker instead of
8726 simple variables to record original value of point. (Bug#7952)
8727
afda1437
EZ
8728 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8729 produced by %s or %c overflows available buffer space. (Bug#8545)
8730
f76dee0c
PE
87312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8732
8733 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8734 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8735
fdc5744d
JB
87362011-04-28 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8739
638f053a
JB
87402011-04-28 Juanma Barranquero <lekktu@gmail.com>
8741
8742 * keyboard.c (Qdelayed_warnings_hook): Define.
8743 (command_loop_1): Run `delayed-warnings-hook'
8744 if Vdelayed_warnings_list is non-nil.
8745 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8746 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8747
d178f871
EZ
87482011-04-28 Eli Zaretskii <eliz@gnu.org>
8749
8750 * doprnt.c (doprnt): Don't return value smaller than the buffer
8751 size if the message was truncated. (Bug#8545).
8752
b124fd93
JB
87532011-04-28 Juanma Barranquero <lekktu@gmail.com>
8754
8755 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8756 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8757
e810457d
PE
87582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8759
8760 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8761
ea51cceb
JB
87622011-04-27 Juanma Barranquero <lekktu@gmail.com>
8763
8764 * makefile.w32-in: Update dependencies.
8765
94dcfacf
EZ
87662011-04-27 Eli Zaretskii <eliz@gnu.org>
8767
8768 Improve `doprnt' and its usage. (Bug#8545)
8769 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8770 `format_end'. Remove support for %l as a conversion specifier.
8771 Don't use xrealloc. Improve diagnostics when the %l size modifier
8772 is used. Update the commentary.
8773
8774 * eval.c (verror): Simplify calculation of size_t.
8775
8776 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8777 messages.
8778
f61f41d7
PE
87792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8780
8781 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8782 change.
8783
96fb4434
PE
87842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8785
8786 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8787 This makes this file independent of the recent pseudovector change.
8788
671875da 87892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8790
69e9b5a3
PE
8791 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8792
b5f869a7 8793 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8794 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8795 Remove unused local.
c8926152 8796 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8797
841a1577 8798 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8799 GCC 4.6.0 optimizes based on type-based alias analysis.
8800 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8801 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8802 != &v->size, and therefore "v->size = 1; b->size = 2; return
8803 v->size;" must therefore return 1. This assumption is incorrect
8804 for Emacs, since it type-puns struct Lisp_Vector * with many other
8805 types. To fix this problem, this patch adds a new type struct
f904488f 8806 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8807 and pseudovectors, and helps optimizing compilers not get fooled
8808 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8809 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8810 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8811 the size member.
eab3844f
PE
8812 (XSETPVECTYPE): Rewrite in terms of new macro.
8813 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8814 This is a bit clearer, and further avoids the possibility of
8815 undesirable aliasing.
8816 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8817 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8818 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8819 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8820 (ASIZE): Now uses header.size rather than size.
8821 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8822 to avoid the hassle of writing XVECTOR (foo)->header.size.
8823 (struct vectorlike_header): New type.
eab3844f
PE
8824 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8825 object, to help avoid aliasing.
8826 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8827 (SUBRP): Likewise, since Lisp_Subr is a special case.
8828 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8829 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8830 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8831 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8832 changed to be "header.size" and "header.next".
8833 * buffer.h (struct buffer): Likewise.
8834 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8835 * frame.h (struct frame): Likewise.
8836 * process.h (struct Lisp_Process): Likewise.
8837 * termhooks.h (struct terminal): Likewise.
8838 * window.c (struct save_window_data, struct saved_window): Likewise.
8839 * window.h (struct window): Likewise.
8840 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8841 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8842 * buffer.c (init_buffer_once): Likewise.
8843 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8844 special case.
8845 * process.c (Fformat_network_address): Use local var for size,
8846 for brevity.
8847
0df1eac5
PE
8848 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8849
847ab9d1 8850 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8851 * data.c (atof): Remove decl; no longer used or needed.
8852 (digit_to_number): Move to lread.c.
8853 (Fstring_to_number): Use new string_to_number function, to be
8854 consistent with how the Lisp reader treats infinities and NaNs.
8855 Do not assume that floating-point numbers represent EMACS_INT
8856 without losing information; this is not true on most 64-bit hosts.
8857 Avoid double-rounding errors, by insisting on integers when
8858 parsing non-base-10 numbers, as the documentation specifies.
8859 * lisp.h (string_to_number): New decl, replacing ...
8860 (isfloat_string): Remove.
bc0a5c13 8861 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8862 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8863 appears to have been a coding error. Similarly, do not accept
8864 strings like +-1e0 as floating point numbers. Do not report
8865 overflow for integer overflows unless the base is not 10 which
8866 means we have no simple and reliable way to continue.
8867 Break out the floating-point parsing into a new
8868 function string_to_number, so that Fstring_to_number parses
8869 floating point numbers consistently with the Lisp reader.
04f2d78b 8870 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8871 (E_CHAR, EXP_INT): Remove, replacing with ...
8872 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8873 (string_to_number): New function, replacing isfloat_string.
8874 This function checks for valid syntax and produces the resulting
8875 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8876 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8877 so that overflow for non-base-10 numbers is reported only when
8878 there's no portable and simple way to convert to floating point.
452f4150 8879
67769ffc
PE
8880 * textprop.c (set_text_properties_1): Rewrite for clarity,
8881 and to avoid GCC warning about integer overflow.
8882
c20db43f
PE
8883 * intervals.h (struct interval): Use EMACS_INT for members
8884 where EMACS_UINT might cause problems. See
8885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8886 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8887 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8888 All uses changed.
37aa2f85
PE
8889 (offset_intervals): Tell GCC not to worry about length overflow
8890 when negating a negative length.
c20db43f 8891
2538aa2f
PE
8892 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8893 (overrun_check_free): Likewise.
8894
f2d3008d
PE
8895 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8896 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8897 word size.
8898
ec8df744
PE
8899 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8900 (gnutls_make_error): Rename local to avoid shadowing.
8901 (gnutls_emacs_global_deinit): ifdef out; not used.
8902 (Fgnutls_boot): Use const for pointer to readonly storage.
8903 Comment out unused local. Fix pointer signedness problems.
8904
640ee02d
PE
8905 * lread.c (openp): Don't stuff size_t into an 'int'.
8906 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8907 about possible signed overflow.
8908
6048fb2a
PE
8909 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8910 (GDK_KEY_g): Don't define if already defined.
8911 (xg_prepare_tooltip): Avoid pointer signedness problem.
8912 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8913
fa3c87e1
PE
8914 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8915 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8916
2172544b
PE
8917 * xfns.c (Fx_window_property): Simplify a bit,
8918 to make a bit faster and to avoid GCC 4.6.0 warning.
8919 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8920
9b821a21
PE
8921 * fns.c (internal_equal): Don't assume size_t fits in int.
8922
3c616cfa
PE
8923 * alloc.c (compact_small_strings): Tighten assertion a little.
8924
c2982e87
PE
8925 Replace pEd with more-general pI, and fix some printf arg casts.
8926 * lisp.h (pI): New macro, generalizing old pEd macro to other
8927 conversion specifiers. For example, use "...%"pI"d..." rather
8928 than "...%"pEd"...".
8929 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8930 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8931 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8932 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8933 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8934 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8935 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8936 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8937 64-bit hosts.
8938 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8939 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8940 * print.c (safe_debug_print, print_object): Likewise.
8941 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8942 to int.
6f04d126
PE
8943 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8944 avoiding the 0 flag, which is not portable.
c2982e87
PE
8945 * process.c (Fmake_network_process): Use pI to avoid cast.
8946 * region-cache.c (pp_cache): Likewise.
8947 * xdisp.c (decode_mode_spec): Likewise.
8948 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8949 behavior on 64-bit hosts with printf arg.
6f04d126 8950 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8951 (x_stop_queuing_selection_requests): Likewise.
8952 (x_get_window_property): Don't truncate byte count to an 'int'
8953 when tracing.
0b432f21 8954
5e073ec7
PE
8955 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8956 here, since it parses constructs like leading '-' and spaces,
8957 which are not wanted; and it overflows with large numbers.
8958 Instead, simply match F[0-9]+, which is what is wanted anyway.
8959
36372bf9
PE
8960 * alloc.c: Remove unportable assumptions about struct layout.
8961 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8962 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8963 (allocate_vectorlike, make_pure_vector): Use the new macros,
8964 plus offsetof, to remove unportable assumptions about struct layout.
8965 These assumptions hold on all porting targets that I know of, but
8966 they are not guaranteed, they're easy to remove, and removing them
8967 makes further changes easier.
8968
0b432f21
PE
8969 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8970 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8971 (string_overrun_cookie): Now const. Use initializers that
8972 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8973 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8974 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8975 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8976 multiple of sizeof (EMACS_INT); it need not be, if
8977 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8978 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8979
895009e1
JB
89802011-04-26 Juanma Barranquero <lekktu@gmail.com>
8981
8982 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8983
6a7a1b0b
TZ
89842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8985
8986 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8987 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8988 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8989
841a1577 89902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8991
8992 * lisp.h (Qdebug): List symbol.
895009e1 8993 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8994 * keyboard.c (debug-on-event): New variable.
8995 (handle_user_signal): Break into debugger when debug-on-event
8996 matches the current signal symbol.
8997
f2d3ba6f
DN
89982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8999
9000 * alloc.c (check_sblock, check_string_bytes)
9001 (check_string_free_list): Convert to standard C.
9002
42ce4c63
TZ
90032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9004
9005 * w32.c (emacs_gnutls_push): Fix typo.
9006
825cd63c
EZ
90072011-04-25 Eli Zaretskii <eliz@gnu.org>
9008
fb11d64d
EZ
9009 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9010 "cast to pointer from integer of different size".
9011
825cd63c
EZ
9012 Improve doprnt and its use in verror. (Bug#8545)
9013 * doprnt.c (doprnt): Document the set of format control sequences
9014 supported by the function. Use SAFE_ALLOCA instead of always
9015 using `alloca'.
9016
9017 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9018 is one byte too soon. Don't use xrealloc; instead xfree and
9019 xmalloc anew.
9020
e061a11b
TZ
90212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9022
9023 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9024 callbacks stage.
9025
9026 * gnutls.c: Renamed global_initialized to
9027 gnutls_global_initialized. Added internals for the
9028 :verify-hostname-error, :verify-error, and :verify-flags
9029 parameters of `gnutls-boot' and documented those parameters in the
9030 docstring. Start callback support.
9173deec
JB
9031 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9032 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9033 on error. Return error code.
e061a11b
TZ
9034 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9035 (emacs_gnutls_read): Likewise.
9036 (Fgnutls_boot): Return handshake error code.
9037 (emacs_gnutls_handle_error): New function.
9038 (wsaerror_to_errno): Likewise.
9039
9040 * w32.h (emacs_gnutls_pull): Add prototype.
9041 (emacs_gnutls_push): Likewise.
9042
9043 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9044 (emacs_gnutls_push): Likewise.
9045
90462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9047
9048 * process.c (wait_reading_process_output): Check if GnuTLS
9049 buffered some data internally if no FDs are set for TLS
9050 connections.
9051
9052 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9053 (LIBS): Link to USER_LIBS.
9054 ($(BLD)/gnutls.$(0)): New target.
9055
fa6996bc
EZ
90562011-04-24 Eli Zaretskii <eliz@gnu.org>
9057
eb35682e
EZ
9058 * xdisp.c (handle_single_display_spec): Rename the
9059 display_replaced_before_p argument into display_replaced_p, to
9060 make it consistent with the commentary. Fix typos in the
9061 commentary.
9062
e2ad650c
EZ
9063 * textprop.c (syms_of_textprop): Remove dead code.
9064 (copy_text_properties): Delete obsolete commentary about an
9065 interface that was deleted long ago. Fix typos in the description
9066 of arguments.
9067
1b2de274
EZ
9068 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9069 to changes in oldXMenu/XMenu.h from 2011-04-16.
9070 <menu_help_message, prev_menu_help_message>: Constify.
9071 (IT_menu_make_room): menu->help_text is now `const char **';
9072 adjust.
9073
9074 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9075 to changes in oldXMenu/XMenu.h from 2011-04-16.
9076 (struct XMenu): Declare `help_text' `const char **'.
9077
9078 * xfaces.c <Qunspecified>: Make extern again.
9079
9080 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9081 required by POSIX.
1b2de274 9082
762b15be
EZ
9083 * doc.c (get_doc_string): Improve the format passed to `error'.
9084
9085 * doprnt.c (doprnt): Improve commentary.
9086
9087 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9088
9089 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9090 them with etags.
9091
f1052e5d
EZ
9092 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9093 changes in globals.h immediately force recompilation.
762b15be
EZ
9094 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9095 $(CURDIR)/s/ms-w32.h.
9096 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9097
fa6996bc
EZ
9098 * character.c (Fchar_direction): Function deleted.
9099 (syms_of_character): Don't defsubr it.
9100 <char-direction-table>: Deleted.
9101
e6c3da20
EZ
91022011-04-23 Eli Zaretskii <eliz@gnu.org>
9103
9104 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9105 * doprnt.c: Include limits.h.
9106 (SIZE_MAX): New macro.
04f2d78b
CB
9107 (doprnt): Return a size_t value. 2nd arg is now size_t.
9108 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9109 Improve overflow protection. Support `l' modifier for integer
9110 conversions. Support %l conversion. Don't assume an EMACS_INT
9111 argument for integer conversions and for %c.
9112
9113 * lisp.h (doprnt): Restore prototype.
9114
9115 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9116 $(SRC)/character.h.
9117
9118 * Makefile.in (base_obj): Add back doprnt.o.
9119
9120 * deps.mk (doprnt.o): Add back prerequisites.
9121 (callint.o): Depend on character.h.
9122
9123 * eval.c (internal_lisp_condition_case): Include the handler
9124 representation in the error message.
9125 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9126 when breaking from the loop.
9127
9128 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9129
9130 * callint.c (Fcall_interactively): When displaying error message
9131 about invalid control letter, pass the character's codepoint, not
9132 a pointer to its multibyte form. Improve display of the character
9133 in octal and display also its hex code.
9134
9135 * character.c (char_string): Use %x to display the (unsigned)
9136 codepoint of an invalid character, to avoid displaying a bogus
9137 negative value.
9138
9139 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9140 `error', not SYMBOL_NAME itself.
9141
9142 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9143 character arguments to `error'.
9144
9145 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9146 to `error' in error message about FINAL_CHAR argument. Make sure
9147 FINAL_CHAR is a character, and use %c when it is passed as
9148 argument to `error'.
9149
4ffd0d6b 91502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9151
9152 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9153
9154 * w32.c: Include <time.h>.
9155 (sys_localtime): New function.
9156
4ffd0d6b 91572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9158
9159 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9160
4ffd0d6b 9161 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9162
4ffd0d6b 91632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9164
4ffd0d6b
GM
9165 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9166 zombies (Bug#8467).
aac0c6e3 9167
04c56954
EZ
91682011-04-19 Eli Zaretskii <eliz@gnu.org>
9169
9170 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9171 gl_state.e_property when gl_state.object is Qt.
9172
9173 * insdel.c (make_gap_larger): Remove limitation of buffer size
9174 to <= INT_MAX.
9175
16a43933
CY
91762011-04-18 Chong Yidong <cyd@stupidchicken.com>
9177
9178 * xdisp.c (lookup_glyphless_char_display)
9179 (produce_glyphless_glyph): Handle cons cell entry in
9180 glyphless-char-display.
9181 (Vglyphless_char_display): Document it.
9182
9183 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9184 glyphless-char-display.
9185
4581706e
CY
91862011-04-17 Chong Yidong <cyd@stupidchicken.com>
9187
9188 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9189
9190 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9191
9192 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9193 definition for no-X builds.
9194
4887c6e2 91952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9196
fd35b6f9
PE
9197 Static checks with GCC 4.6.0 and non-default toolkits.
9198
5c1ccb01
PE
9199 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9200
006c5daa
PE
9201 * process.c (keyboard_bit_set): Define only if SIGIO.
9202 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9203 (send_process): Repair possible setjmp clobbering.
9204
efc736d3
PE
9205 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9206
4e2fe2e6
PE
9207 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9208
f97334a2
PE
9209 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9210
4e75f29d
PE
9211 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9212 Define only if needed.
9213
90efadd1
PE
9214 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9215 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9216 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9217
3c647824
PE
9218 * dispextern.h (struct redisplay_interface): Rename param
9219 to avoid shadowing.
e264f262 9220 * termhooks.h (struct terminal): Likewise.
761383f4 9221 * xterm.c (xembed_send_message): Likewise.
3c647824 9222
b58c5c4a
PE
9223 * insdel.c (make_gap_smaller): Define only if
9224 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9225
cad59032
PE
9226 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9227 it.
9228
c339dc2e
PE
9229 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9230 so that we aren't warned about unused symbols.
9231
91a3e27b
PE
9232 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9233
399c71d3 9234 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9235
8ffc96f5
PE
9236 * xfns.c (x_real_positions): Mark locals as initialized.
9237
eef9bc79
PE
9238 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9239
098db9dd
PE
9240 * xterm.c: Fix problems found by static analysis with other toolkits.
9241 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9242 (x_dispatch_event): Declare static if USE_GTK, and
9243 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9244 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9245 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9246 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9247 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9248
eb18f6cc
PE
9249 * xmenu.c (menu_help_callback): Pointer type fixes.
9250 Use const pointers when pointing at readonly data. Avoid pointer
9251 signedness clashes.
9252 (FALSE): Remove unused macro.
9253 (update_frame_menubar): Remove unused decl.
9254
1fe72bf8
PE
9255 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9256
60d9e1db
PE
9257 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9258 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9259 (single_menu_item): Rename local to avoid shadowing.
9260
39261c26
PE
9261 * keyboard.c (make_lispy_event): Remove unused local var.
9262
018c5e19
PE
9263 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9264 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9265
63d2b86e
PE
9266 * bitmaps: Change bitmaps from unsigned char back to the X11
9267 compatible char. Avoid the old compiler warnings about
9268 out-of-range initializers by using, for example, '\xab' rather
9269 than 0xab.
9270
aefd87e1
PE
9271 * xgselect.c (xgselect_initialize): Check vs interface
9272 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9273
bf501fb9
PE
9274 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9275
e9829fdf
PE
9276 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9277 to read-only memory.
9278
1086c095
PE
9279 * fns.c (vector): Remove; this old hack is no longer needed.
9280
2baccd04 9281 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9282 Remove unused var.
dde42981 9283 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9284
72391843 9285 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9286
436c16df 9287 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9288 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9289 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9290
92bb796d 9291 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9292 (x_term_init): Remove local to avoid shadowing.
92bb796d 9293
764430a3 9294 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9295
9296 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9297 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9298
d1dfb56c
EZ
92992011-04-16 Eli Zaretskii <eliz@gnu.org>
9300
c4354cb4
EZ
9301 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9302
d1dfb56c
EZ
9303 Fix regex.c, syntax.c and friends for buffers > 2GB.
9304 * syntax.h (struct gl_state_s): Declare character position members
9305 EMACS_INT.
9306
9307 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9308
04f2d78b
CB
9309 * textprop.c (verify_interval_modification, interval_of):
9310 Declare arguments EMACS_INT.
d1dfb56c
EZ
9311
9312 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9313 EMACS_INT.
9314
9315 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9316
9317 * indent.c (Fvertical_motion): Local variable it_start is now
9318 EMACS_INT.
9319
9320 * regex.c (re_match, re_match_2, re_match_2_internal)
9321 (bcmp_translate, regcomp, regexec, print_double_string)
9322 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9323 (re_compile_pattern, re_exec): Declare arguments and local
9324 variables `size_t' and `ssize_t' and return values `regoff_t', as
9325 appropriate.
9326 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9327 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9328 <compile_stack_type>: `size' and `avail' are now `size_t'.
9329
9330 * regex.h <regoff_t>: Use ssize_t, not int.
9331 (re_search, re_search_2, re_match, re_match_2): Arguments that
9332 specify buffer/string position and length are now ssize_t and
9333 size_t. Return type is regoff_t.
9334
613052cd
BK
93352011-04-16 Ben Key <bkey76@gmail.com>
9336
9337 * nsfont.m: Fixed bugs in ns_get_family and
9338 ns_descriptor_to_entity that were caused by using free to
9339 deallocate memory blocks that were allocated by xmalloc (via
9340 xstrdup). This caused Emacs to crash when compiled with
9341 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9342 --enable-checking=xmallocoverrun). xfree is now used to
9343 deallocate these memory blocks.
9344
4170f62f 93452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9346
71b41406
PE
9347 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9348
9587a89d
PE
9349 emacs_write: Accept and return EMACS_INT for sizes.
9350 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9351 et seq.
9352 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9353 Accept and return EMACS_INT.
9354 (emacs_gnutls_write): Return the number of bytes written on
9355 partial writes.
9356 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9357 (emacs_read, emacs_write): Remove check for negative size, as the
9358 Emacs source code has been audited now.
9587a89d
PE
9359 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9360 (emacs_read, emacs_write): Use it.
273a5f82
PE
9361 * process.c (send_process): Adjust to the new signatures of
9362 emacs_write and emacs_gnutls_write. Do not attempt to store
9363 a byte offset into an 'int'; it might overflow.
9587a89d 9364 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9365
3e047f51
PE
9366 * sound.c: Don't assume sizes fit in 'int'.
9367 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9368 Return EMACS_INT, not int.
3e047f51 9369 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9370 Accept EMACS_INT, not int.
9371 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9372 record read return values.
9373
cc39a9db
BK
93742011-04-15 Ben Key <bkey76@gmail.com>
9375
c9d0ec6d
JB
9376 * keyboard.c (Qundefined): Don't declare static since it is used
9377 in nsfns.m.
9378 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9379 static since they are used in nsfont.m.
cc39a9db 9380
6c60eb9f
SM
93812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9382
9383 * process.c (Qprocessp): Don't declare static.
9384 * lisp.h (Qprocessp): Declare again.
9385
7990b61a
JB
93862011-04-15 Juanma Barranquero <lekktu@gmail.com>
9387
9388 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9389
5d4cb038
PE
93902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9391
8bd7b830 9392 Improve C-level modularity by making more things 'static'.
cd64ea1d 9393
e3b27b31
PE
9394 Don't publish debugger-only interfaces to other modules.
9395 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9396 (verify_bytepos, count_markers): Move decls to the only modules
9397 that need them.
9398 * region-cache.h (pp_cache): Likewise.
9399 * window.h (check_all_windows): Likewise.
9400 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9401
5d4cb038
PE
9402 * sysdep.c (croak): Now static, if
9403 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9404 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9405
9406 * alloc.c (refill_memory_reserve): Now static if
9407 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9408 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9409
e87b6180
PE
9410 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9411 Define only if USE_LUCID.
9412
ac64929e
PE
9413 * xrdb.c (x_customization_string, x_rm_string): Now static.
9414
6f37259d
PE
9415 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9416 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9417
1683e3ab
PE
9418 * xdisp.c (draw_row_with_mouse_face): Now static.
9419 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9420
de9c2632
PE
9421 * window.h (check_all_windows): Mark externally visible.
9422
2b96acb7
PE
9423 * window.c (window_deletion_count): Now static.
9424
9425 * undo.c: Make symbols static if they're not exported.
9426 (last_undo_buffer, last_boundary_position, pending_boundary):
9427 Now static.
9428
50436f33
PE
9429 * textprop.c (interval_insert_behind_hooks): Now static.
9430 (interval_insert_in_front_hooks): Likewise.
9431
64520e5c
PE
9432 * term.c: Make symbols static if they're not exported.
9433 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9434 (max_frame_lines, tty_set_terminal_modes):
9435 (tty_reset_terminal_modes, tty_turn_off_highlight):
9436 (get_tty_terminal): Now static.
9437 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9438 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9439 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9440 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9441 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9442
1fa53021
PE
9443 * sysdep.c: Make symbols static if they're not exported.
9444 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9445 Now static.
9446 (sigprocmask_set, full_mask): Remove; unused.
9447 (wait_debugging): Mark as visible.
9448 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9449 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9450
d4b43b22
PE
9451 * syntax.c (syntax_temp): Define only if !__GNUC__.
9452
b7c513d0
PE
9453 * sound.c (current_sound_device, current_sound): Now static.
9454
989b29ad
PE
9455 * search.c (searchbufs, searchbuf_head): Now static.
9456
13a55a78
PE
9457 * scroll.c (scroll_cost): Remove; unused.
9458 * dispextern.h (scroll_cost): Remove decl.
9459
de68a1fc
PE
9460 * region-cache.h (pp_cache): Mark as externally visible.
9461
40ccffa6
PE
9462 * process.c: Make symbols static if they're not exported.
9463 (process_tick, update_tick, create_process, chan_process):
9464 (Vprocess_alist, proc_buffered_char, datagram_access):
9465 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9466 (deactivate_process): Mark defn as static, as well as decl.
9467 * lisp.h (create_process): Remove decl.
9468 * process.h (chan_process, Vprocess_alist): Remove decls.
9469
ad64fc97
PE
9470 * print.c: Make symbols static if they're not exported.
9471 (print_depth, new_backquote_output, being_printed, print_buffer):
9472 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9473 (print_interval, print_number_index, initial_stderr_stream):
9474 Now static.
9475 * lisp.h (Fprinc): Remove decl.
9476 (debug_output_compilation_hack): Mark as externally visible.
9477
adddb265
PE
9478 * sysdep.c (croak): Move decl from here to syssignal.h.
9479 * syssignal.h (croak): Put it here, so the API can be checked when
9480 'croak' is called from dissociate_if_controlling_tty.
9481
1717ede2
PE
9482 * minibuf.c: Make symbols static if they're not exported.
9483 (minibuf_save_list, choose_minibuf_frame): Now static.
9484 * lisp.h (choose_minibuf_frame): Remove decl.
9485
fa5fb2bc
PE
9486 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9487
1e3890d1
PE
9488 * lread.c: Make symbols static if they're not exported.
9489 (read_objects, initial_obarray, oblookup_last_bucket_number):
9490 Now static.
9491 (make_symbol): Remove; unused.
9492 * lisp.h (initial_obarray, make_symbol): Remove decls.
9493
8a1414fa
PE
9494 * keyboard.c: Make symbols static if they're not exported.
9495 (single_kboard, recent_keys_index, total_keys, recent_keys):
9496 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9497 (this_single_command_key_start, echoing, last_auto_save):
9498 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9499 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9500 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9501 (Vlispy_mouse_stem, double_click_count):
9502 Now static.
9503 (force_auto_save_soon): Define only if SIGDANGER.
9504 (ignore_mouse_drag_p): Now static if
9505 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9506 (print_help): Remove; unused.
9507 (stop_character, last_timer_event): Mark as externally visible.
9508 * keyboard.h (ignore_mouse_drag_p): Declare only if
9509 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9510 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9511 * lisp.h (echoing): Remove decl.
9512 (force_auto_save_soon): Declare only if SIGDANGER.
9513 * xdisp.c (redisplay_window): Simplify code, to make it more
9514 obvious that ignore_mouse_drag_p is not accessed if !defined
9515 USE_GTK && !defined HAVE_NS.
9516
93ea6e8f
PE
9517 * intervals.c: Make symbols static if they're not exported.
9518 (merge_properties_sticky, merge_interval_right, delete_interval):
9519 Now static.
9520 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9521
77382fcc
PE
9522 * insdel.c: Make symbols static if they're not exported.
9523 However, leave prepare_to_modify_buffer alone. It's never
9524 called from outside this function, but that appears to be a bug.
9525 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9526 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9527 (adjust_after_replace_noundo): Remove; unused.
9528 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9529 (signal_before_change): Remove decls.
77382fcc 9530
9306c32e
PE
9531 * indent.c (val_compute_motion, val_vmotion): Now static.
9532
cd44d2eb
PE
9533 * image.c: Make symbols static if they're not exported.
9534 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9535 if USE_GTK.
9536 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9537 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9538
ad9a7a06
PE
9539 * fringe.c (standard_bitmaps): Now static.
9540 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9541
81626931
PE
9542 * frame.c: Make symbols static if they're not exported.
9543 (x_report_frame_params, make_terminal_frame): Now static.
9544 (get_frame_param): Now static, unless HAVE_NS.
9545 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9546 (x_get_resource_string): Remove; not used.
9547 * frame.h (make_terminal_frame, x_report_frame_params):
9548 (x_get_resource_string); Remove decls.
9549 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9550 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9551
239f9db9
PE
9552 * font.c, fontset.c: Make symbols static if they're not exported.
9553 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9554 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9555 * font.c (font_close_object): Now static.
9556 * font.h (font_close_object): Remove.
9557 * fontset.c (FONTSET_OBJLIST): Remove.
9558 (free_realized_fontset) #if-0 the body, which does nothing.
9559 (face_suitable_for_char_p): #if-0, as it's never called.
9560 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9561 * xfaces.c (face_at_string_position):
9562 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9563 since 0 is always ASCII.
9564
dfcf3579
PE
9565 * fns.c (weak_hash_tables): Now static.
9566
5045092b
PE
9567 * fileio.c: Make symbols static if they're not exported.
9568 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9569 (Vwrite_region_annotation_buffers): Now static.
9570
57a96f5c
PE
9571 * eval.c: Make symbols static if they're not exported.
9572 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9573 * lisp.h (backtrace_list): Remove decl.
9574
35f08c38
PE
9575 * emacs.c: Make symbols static if they're not exported.
9576 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9577 (fatal_error_code, fatal_error_signal_hook, standard_args):
9578 Now static.
9579 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9580 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9581 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9582 * lisp.h (fatal_error_signal_hook): Remove decl.
9583 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9584
f44bd759
PE
9585 * editfns.c: Move a (normally-unused) function to its only use.
9586 * editfns.c, lisp.h (get_operating_system_release): Remove.
9587 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9588 worth the hassle of breaking this out.
9589
b532497d
PE
9590 * xterm.c: Make symbols static if they're not exported.
9591 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9592 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9593 (x_destroy_window, x_delete_display):
9594 Now static.
9595 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9596 (x_mouse_leave): Remove; unused.
9597 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9598 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9599 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9600 Remove decls.
9601 (x_mouse_leave): Declare only if WINDOWSNT.
9602 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9603 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9604 USE_X_TOOLKIT.
9605
1675728f
PE
9606 * ftxfont.c: Make symbols static if they're not exported.
9607 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9608 HAVE_FREETYPE.
9609 * font.h (ftxfont_driver): Likewise.
9610
e4cebfca
PE
9611 * xfns.c: Make symbols static if they're not exported.
9612 (x_last_font_name, x_display_info_for_name):
9613 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9614 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9615 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9616 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9617 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9618 (last_show_tip_args): Now static.
9619 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9620 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9621 (x_screen_planes): Remove; unused.
9622 * dispextern.h (x_screen_planes): Remove decl.
9623
5bf46f05
PE
9624 * dispnew.c: Make symbols static if they're not exported.
9625 * dispextern.h (redraw_garbaged_frames, scrolling):
9626 (increment_row_positions): Remove.
9627 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9628 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9629 Now static.
9630 (redraw_garbaged_frames): Remove; unused.
9631
435f4c28
PE
9632 * xfaces.c: Make symbols static if they're not exported.
9633 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9634 Remove decls.
9635 * xterm.h (defined_color): Remove decls.
9636 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9637 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9638 (menu_face_changed_default, defined_color, free_realized_face):
9639 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9640 (ascii_face_of_lisp_face): Remove; unused.
9641
8524aef3
PE
9642 * xdisp.c: Make symbols static if they're not exported.
9643 * dispextern.h (scratch_glyph_row, window_box_edges):
9644 (glyph_to_pixel_coords, set_cursor_from_row):
9645 (get_next_display_element, set_iterator_to_next):
9646 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9647 (show_mouse_face): Remove decls
9648 * frame.h (message_buf_print): Likewise.
9649 * lisp.h (pop_message, set_message, check_point_in_composition):
9650 Likewise.
9651 * xterm.h (set_vertical_scroll_bar): Likewise.
9652 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9653 (message_buf_print, scratch_glyph_row, displayed_buffer):
9654 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9655 (get_next_display_element, show_mouse_face, window_box_edges):
9656 (frame_to_window_pixel_xy, check_point_in_composition):
9657 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9658 (glyph_to_pixel_coords): Remove; unused.
9659
16390cd2
PE
9660 * dired.c (file_name_completion): Now static.
9661
9662 * dbusbind.c (xd_in_read_queued_messages): Now static.
9663
a25f4dfa
PE
9664 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9665 * data.c (circular_list_error): Remove.
9666
14a9c8df
PE
9667 * commands.h (last_point_position, last_point_position_buffer):
9668 (last_point_position_window): Remove decls.
9669 * keyboard.c: Make these variables static.
9670
04f2d78b
CB
9671 * coding.h (coding, code_convert_region, encode_coding_gap):
9672 Remove decls.
74ab6df5
PE
9673 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9674 (iso_code_class, detect_coding, code_convert_region): Now static.
9675 (encode_coding_gap): Remove; unused.
9676
38dfbee1
PE
9677 * chartab.c (chartab_chars, chartab_bits): Now static.
9678
a2cb4e63
PE
9679 * charset.h (charset_iso_8859_1): Remove decl.
9680 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9681 Now static.
9682
127198fd
PE
9683 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9684 * ccl.c (Vccl_program_table): Now static.
9685 (check_ccl_update): Remove; unused.
9686
d85b608f
PE
9687 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9688 * category.h: ... from here.
9689 * category.c (check_category_table, set_category_set): Now static.
9690
31cd66f3
PE
9691 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9692 * lisp.h: Remove these decls.
9693
c358e587
PE
9694 * buffer.c (buffer_count): Remove unused var.
9695
e78aecca
PE
9696 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9697 so that it's not optimized away.
9698 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9699 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9700 exported only to the debugger.
9701
e192d7d3 9702 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9703 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9704
92470028
PE
9705 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9706 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9707 was inaccessible from Lisp.
9708 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9709 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9710
244ed907
PE
9711 alloc.c: Import and export fewer symbols, and remove unused items.
9712 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9713 is defined.
9714 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9715 it's not optimized away by whole-program optimization.
9716 (message_enable_multibyte, free_misc): Remove.
9717 (catchlist, handlerlist, mark_backtrace):
9718 Declare only if BYTE_MARK_STACK.
9719 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9720 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9721 (message_enable_multibyte): Remove decl.
9722 (free_misc, interval_free_list, float_block, float_block_index):
9723 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9724 (cons_free_list, last_marked_index):
9725 Now static.
9726 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9727 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9728 (mark_backtrace): Define only if BYTE_MARK_STACK.
9729 * xdisp.c (message_enable_multibyte): Now static.
9730
61c2b50e 9731 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9732 This makes it easier for human readers (and static analyzers)
9733 to see whether these variables are used from other modules.
9734 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9735 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9736 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9737 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9738 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9739 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9740 * xmenu.c, xselect.c:
9741 Declare Q* vars static if they are not used in other modules.
9742 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9743 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9744 Remove decls of unexported vars.
9745 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9746
95c82688
PE
9747 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9748
16a97296
PE
9749 Make Emacs functions such as Fatom 'static' by default.
9750 This makes it easier for human readers (and static analyzers)
9751 to see whether these functions can be called from other modules.
9752 DEFUN now defines a static function. To make the function external
9753 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9754 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9755 (Finit_image_library):
16a97296
PE
9756 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9757 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9758 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9759 Remove decls, since these functions are now static.
9760 (Funintern, Fget_internal_run_time): New decls, since these functions
9761 were already external.
95c82688 9762
16a97296
PE
9763 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9764 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9765 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9766 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9767 * keyboard.c, keymap.c, lread.c:
9768 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9769 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9770 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9771 Mark functions with DEFUE instead of DEFUN,
9772 if they are used in other modules.
9773 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9774 decls for now-static functions.
9775 * buffer.h (Fdelete_overlay): Remove decl.
9776 * callproc.c (Fgetenv_internal): Mark as internal.
9777 * composite.c (Fremove_list_of_text_properties): Remove decl.
9778 (Fcomposition_get_gstring): New forward static decl.
9779 * composite.h (Fcomposite_get_gstring): Remove decl.
9780 * dired.c (Ffile_attributes): New forward static decl.
9781 * doc.c (Fdocumntation_property): New forward static decl.
9782 * eval.c (Ffetch_bytecode): New forward static decl.
9783 (Funintern): Remove extern decl; now in .h file where it belongs.
9784 * fileio.c (Fmake_symbolic_link): New forward static decl.
9785 * image.c (Finit_image_library): New forward static decl.
9786 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9787 * intervals.h (Fprevious_property_change):
9788 (Fremove_list_of_text_properties): Remove decls.
9789 * keyboard.c (Fthis_command_keys): Remove decl.
9790 (Fcommand_execute): New forward static decl.
9791 * keymap.c (Flookup_key): New forward static decl.
9792 (Fcopy_keymap): Now static.
9793 * keymap.h (Flookup_key): Remove decl.
9794 * process.c (Fget_process): New forward static decl.
9795 (Fprocess_datagram_address): Mark as internal.
9796 * syntax.c (Fsyntax_table_p): New forward static decl.
9797 (skip_chars): Remove duplicate decl.
9798 * textprop.c (Fprevious_property_change): New forward static decl.
9799 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9800 Now internal.
9801 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9802 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9803
785bbd42
PE
9804 * editfns.c (Fformat): Remove unreachable code.
9805
8b913b57
AS
98062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9807
9808 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9809 change. (Bug#8496)
9810
a6744a35
EZ
98112011-04-13 Eli Zaretskii <eliz@gnu.org>
9812
9813 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9814 when at ZV. (Bug#8487)
9815
e7974947
AS
98162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9817
baad03f0
AS
9818 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9819 (Bug#8437)
9820 * keyboard.c (parse_tool_bar_item): Likewise.
9821 * sound.c (sound_cleanup, alsa_close): Likewise.
9822 * termcap.c (tgetent): Likewise.
9823 * xfns.c (x_default_font_parameter): Likewise.
9824 * xsettings.c (read_and_apply_settings): Likewise.
9825
e7974947
AS
9826 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9827 (overrun_check_free): Protoize.
9828
28272684
PE
98292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9830
9831 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9832 since callers should never pass a negative size.
9833 Change the signature to match that of plain 'read' and 'write'; see
9834 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9835 * lisp.h: Update prototypes of emacs_write and emacs_read.
9836
11997c76
EZ
98372011-04-11 Eli Zaretskii <eliz@gnu.org>
9838
9839 * xdisp.c (redisplay_window): Don't try to determine the character
9840 position of the scroll margin if the window start point w->startp
e896f03c 9841 is outside the buffer's accessible region. (Bug#8468)
11997c76 9842
8a2cbd72
EZ
98432011-04-10 Eli Zaretskii <eliz@gnu.org>
9844
9845 Fix write-region and its subroutines for buffers > 2GB.
9846 * fileio.c (a_write, e_write): Modify declaration of arguments and
9847 local variables to support buffers larger than 2GB.
9848 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9849
9850 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9851 argument, local variables, and return value.
9852
9853 * lisp.h: Update prototypes of emacs_write and emacs_read.
9854
9855 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9856
4073e537 98572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9858
1ebfdcb6
PE
9859 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9860
b2ded58d
PE
9861 Fix more problems found by GCC 4.6.0's static checks.
9862
7d66342c
PE
9863 * xdisp.c (vmessage): Use a better test for character truncation.
9864
bbf47d44
PE
9865 * charset.c (load_charset_map): <, not <=, for optimization,
9866 and to avoid potential problems with integer overflow.
9248994d 9867 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9868 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9869 * editfns.c (Fformat): Likewise.
1e69125e 9870 * syntax.c (skip_chars): Likewise.
3befa583 9871
e3019616
PE
9872 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9873 This also lets GCC 4.6.0 generate slightly better loop code.
9874
becfa255
PE
9875 * callint.c (Fcall_interactively): <, not <=, for optimization.
9876 (Fcall_interactively): Count the number of arguments produced,
9877 not the number of arguments given. This is simpler and lets GCC
9878 4.6.0 generate slightly better code.
9879
dae0cd48
PE
9880 * ftfont.c: Distingish more carefully between FcChar8 and char.
9881 The previous code passed unsigned char * to a functions like
9882 strlen and xstrcasecmp that expect char *, which does not
9883 conform to the C standard.
9884 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9885 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9886 char * when the C standard requires it.
9887
76032d70
PE
9888 * keyboard.c (read_char): Remove unused var.
9889
eb3f1cc8
PE
9890 * eval.c: Port to Windows vsnprintf (Bug#8435).
9891 Include <limits.h>.
9892 (SIZE_MAX): Define if the headers do not.
9893 (verror): Do not give up if vsnprintf returns a negative count.
9894 Instead, grow the buffer. This ports to Windows vsnprintf, which
9895 does not conform to C99. Problem reported by Eli Zaretskii.
9896 Also, simplify the allocation scheme, by avoiding the need for
9897 calling realloc, and removing the ALLOCATED variable.
9898
70476b54
PE
9899 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9900
12020a9e
PE
9901 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9902 But keep the doprint source code for now, as we might revamp it
9903 and use it again (Bug#8435).
ea6c7ae6
PE
9904 * lisp.h (doprnt): Remove.
9905 * Makefile.in (base_obj): Remove doprnt.o.
9906 * deps.mk (doprnt.o): Remove.
9907
5fdb398c
PE
9908 error: Print 32- and 64-bit integers portably (Bug#8435).
9909 Without this change, on typical 64-bit hosts error ("...%d...", N)
9910 was used to print both 32- and 64-bit integers N, which relied on
9911 undefined behavior.
61bdb816 9912 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9913 * lisp.h (error, verror): Mark as printf-like functions.
9914 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9915 Report overflow in size calculations when allocating printf buffer.
9916 Do not truncate output string at its first null byte.
9917 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9918 Truncate the output at a character boundary, since vsnprintf does not
9919 do that.
9920 * charset.c (check_iso_charset_parameter): Convert internal
9921 character to string before calling 'error', since %c now has the
9922 printf meaning.
9923 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9924 overflow when computing char to be passed to 'error'. Do not
9925 pass Lisp_Object to 'error'; pass the integer instead.
9926 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9927 formatted with plain %d.
9928
b189fa66
PE
9929 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9930
bff87ef0
PE
9931 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9932
7e2cac20
PE
9933 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9934
ce4d90b5
PE
9935 * xterm.c (x_catch_errors): Remove duplicate declaration.
9936
266c9547
PE
9937 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9938
79c49ad2
PE
9939 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9940
368f4090
JM
99412011-04-10 Jim Meyering <meyering@redhat.com>
9942
9943 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9944 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9945 return ssize_t not "int", and use size_t as the buffer length.
9946 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9947 * gnutls.h: Update declarations.
9948 * process.c (read_process_output): Use ssize_t, to match.
9949 (send_process): Likewise.
9950
a32d4040
CY
99512011-04-09 Chong Yidong <cyd@stupidchicken.com>
9952
9953 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9954
8546720e 99552011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9956
04f2d78b
CB
9957 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9958 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9959
8546720e
GM
9960 * xterm.c (handle_one_xevent):
9961 * xmenu.c (create_and_show_popup_menu):
9962 * xselect.c (x_decline_selection_request)
9963 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9964
0a2f5c1a 99652011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9966
9967 Fix some uses of `int' instead of EMACS_INT.
9968 * search.c (string_match_1, fast_string_match)
9969 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9970 (scan_buffer, find_next_newline_no_quit)
9971 (find_before_next_newline, search_command, Freplace_match)
9972 (Fmatch_data): Make some `int' variables be EMACS_INT.
9973
9974 * xdisp.c (display_count_lines): 3rd argument and return value now
9975 EMACS_INT. All callers changed.
9976 (pint2hrstr): Last argument is now EMACS_INT.
9977
9978 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9979 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9980 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9981 (decode_coding_utf_16, decode_coding_emacs_mule)
9982 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9983 (decode_coding_ccl, decode_coding_charset)
9984 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9985 (decode_coding_iso_2022, decode_coding_emacs_mule)
9986 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9987 <char_offset, last_offset>: Declare EMACS_INT.
9988 (encode_coding_utf_8, encode_coding_utf_16)
9989 (encode_coding_emacs_mule, encode_invocation_designation)
9990 (encode_designation_at_bol, encode_coding_iso_2022)
9991 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9992 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9993 Declare EMACS_INT.
9994 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9995 (encode_invocation_designation): Last argument P_NCHARS is now
9996 EMACS_INT.
9997 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9998 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9999
10000 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10001 All users changed.
10002
10003 * ccl.c (Fccl_execute_on_string): Declare some variables
10004 EMACS_INT.
10005
8546720e 100062011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10007
10008 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10009
4e19a977
CS
100102011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10011
10012 * process.c (Fformat_network_address): Doc fix.
10013
87302331
R
100142011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10015
ee7683eb 10016 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10017
cbb59342
CY
100182011-04-08 Chong Yidong <cyd@stupidchicken.com>
10019
10020 * keyboard.c (read_char): Call Lisp function help-form-show,
10021 instead of using internal_with_output_to_temp_buffer.
10022 (Qhelp_form_show): New var.
e0d38eeb 10023 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10024
10025 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10026
10027 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10028
e67a13ab
CY
100292011-04-06 Chong Yidong <cyd@stupidchicken.com>
10030
04f2d78b
CB
10031 * process.c (Flist_processes): Remove to Lisp.
10032 (list_processes_1): Delete.
e67a13ab 10033
973f782d
EZ
100342011-04-06 Eli Zaretskii <eliz@gnu.org>
10035
7c106b1e
EZ
10036 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10037
973f782d
EZ
10038 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10039
41cf7d1a 100402011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10041
ca23cc88
PE
10042 Fix more problems found by GCC 4.6.0's static checks.
10043
f390e2d5
PE
10044 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10045
42eea0d0
PE
10046 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10047
b69769da 10048 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10049
f9541e84
PE
10050 * xdisp.c (vmessage): Mark as a printf-like function.
10051
13841b55
PE
10052 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10053
c136c10f
PE
10054 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10055
5e2d4a30
PE
10056 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10057 printf-like functions.
10058 (tiff_load): Add casts to remove these marks before passing them
10059 to system-supplied API.
10060
583f48b9
PE
10061 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10062
b25d760e
PE
10063 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10064 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10065 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10066 directly, rather than having caller test rule sign. This avoids
10067 some unnecessary tests.
10068 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10069 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10070 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10071
bc7b6697 10072 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10073 (xfont_open): Avoid unnecessary tests.
bc7b6697 10074
27ccc379
PE
10075 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10076
dcd5c89a
PE
10077 * composite.h, composite.c (composition_gstring_put_cache):
10078 Use EMACS_INT, not int, for length.
10079
b13a45c6
PE
10080 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10081 breaking out part of COMPOSITION_DECODE_RULE.
10082 (COMPOSITION_DECODE_RULE): Use it.
10083 * composite.c (get_composition_id): Remove unused local vars,
10084 by using the new macro.
10085
1e792e4d
PE
10086 * textprop.c (set_text_properties_1): Change while to do-while,
10087 since the condition is always true at first.
10088
dc6c6455 10089 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10090 (interval_deletion_adjustment): Return unsigned value.
10091 All uses changed.
dc6c6455 10092
aba7731a
PE
10093 * process.c (list_processes_1, create_pty, read_process_output):
10094 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10095 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10096 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10097 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10098 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10099
fdfc4bf3
PE
10100 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10101
fca8fe46 10102 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10103 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10104
06a0259a 10105 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10106 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10107 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10108
e7b9e80f
PE
10109 * print.c (print_error_message): Avoid int overflow.
10110
56201685
PE
10111 * font.c (font_list_entities): Redo for clarity,
10112 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10113
78834453 10114 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10115 (font_score): Avoid potential overflow in diff calculation.
78834453 10116
0bc0b309 10117 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10118 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10119
e610eaca
PE
10120 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10121
b895abce
PE
10122 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10123 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10124 can always succeed if overflow has undefined behavior.
10125
1f1d9321 10126 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10127 (wordify): Omit three unnecessary tests.
1f1d9321 10128
c59478bc
PE
10129 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10130 All callers changed. This avoids the need for an unused var.
10131
79b73827
PE
10132 * casefiddle.c (casify_region): Remove var that is set but not used.
10133
a4db5dfe
PE
10134 * dired.c (file_name_completion): Remove var that is set but not used.
10135
43aae36e
PE
10136 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10137
2a47c44d 10138 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10139 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10140
a37c69bf
PE
10141 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10142 Check for integer overflow on size calculations.
10143
328ab8e7
PE
10144 * buffer.c (Fprevious_overlay_change): Remove var that is set
10145 but not used.
10146
e5a2a5cb
PE
10147 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10148 Remove vars that are set but not used.
8d84a6eb 10149 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10150 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10151
a60e5f68
PE
10152 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10153
f661cb61 10154 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10155 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10156
f0397f5a
PE
10157 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10158 that are set but not used.
10159
8664db06 10160 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10161 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10162
6abdaa4a
PE
10163 * xselect.c (x_get_local_selection, x_handle_property_notify):
10164 Remove vars that are set but not used.
10165
0ce7538d 10166 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10167 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10168
9ae848fc
PE
10169 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10170 Remove var that is set but not used.
0b918413
PE
10171 (scroll_bar_windows_size): Now size_t, not int.
10172 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10173 Check for overflow.
9ae848fc 10174
a5a62657
PE
10175 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10176 (map_tty_color) [!defined MSDOS]: Likewise.
10177
5c5cdd39
PE
10178 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10179
66ebf983
PE
10180 * coding.c: Remove vars that are set but not used.
10181 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10182 All callers changed.
10183 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10184 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10185 (decode_coding_charset): Remove vars that are set but not used.
10186
1be4d761
PE
10187 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10188 that is set but not used.
10189
47553fa8
PE
10190 * print.c (print_object): Remove var that is set but not used.
10191
1f7196bf 10192 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10193 The gnulib version avoids calling malloc in the usual case,
10194 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10195 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10196 * filelock.c (current_lock_owner): Likewise.
10197 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10198 * sysdep.c: Include allocator.h, careadlinkat.h.
10199 (emacs_no_realloc_allocator): New static constant.
10200 (emacs_readlink): New function.
fdb61804
PE
10201 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10202 ../lib/careadlinkat.h.
d1fdcab7 10203
f84c17c7
SM
102042011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10205
10206 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10207 first non-nil return value).
10208
ef3862ad
JD
102092011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10210
10211 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10212 if not defined (Bug#8403).
10213
376a7006
JB
102142011-04-02 Juanma Barranquero <lekktu@gmail.com>
10215
10216 * xdisp.c (display_count_lines): Remove parameter `start',
10217 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10218 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10219 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10220 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10221 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10222 and thereabouts. All callers changed.
10223 (get_per_char_metric): Remove parameter `f', unused since
10224 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10225
6ca3801d
JM
102262011-04-02 Jim Meyering <meyering@redhat.com>
10227
10228 do not dereference NULL upon failed strdup
10229 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10230 (ns_get_family): Likewise.
10231
d8e2b5ba
JB
102322011-04-02 Juanma Barranquero <lekktu@gmail.com>
10233
10234 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10235
8c74fcbd
JD
102362011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10237
10238 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10239 later (Bug#8403).
10240
7200d79c
SM
102412011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10242
03408648 10243 Add lexical binding.
7200d79c 10244
03408648
SM
10245 * window.c (Ftemp_output_buffer_show): New fun.
10246 (Fsave_window_excursion):
10247 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10248
10249 * lread.c (lisp_file_lexically_bound_p): New function.
10250 (Fload): Bind Qlexical_binding.
10251 (readevalloop): Remove `evalfun' arg.
10252 Bind Qinternal_interpreter_environment.
10253 (Feval_buffer): Bind Qlexical_binding.
10254 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10255 Mark as dynamic.
10256 (syms_of_lread): Declare `lexical-binding'.
10257
10258 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10259
10260 * keyboard.c (eval_dyn): New fun.
10261 (menu_item_eval_property): Use it.
ca105506
SM
10262
10263 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10264
03408648
SM
10265 * fns.c (concat, mapcar1): Accept byte-code-functions.
10266
10267 * eval.c (Fsetq): Handle lexical vars.
10268 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10269 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10270 (FletX, Flet): Obey lexical binding.
10271 (Fcommandp): Handle closures.
10272 (Feval): New `lexical' arg.
10273 (eval_sub): New function extracted from Feval. Use it almost
10274 everywhere where Feval was used. Look up vars in lexical env.
10275 Handle closures.
10276 (Ffunctionp): Move from subr.el.
10277 (Ffuncall): Handle closures.
10278 (apply_lambda): Remove `eval_flags'.
10279 (funcall_lambda): Handle closures and new byte-code-functions.
10280 (Fspecial_variable_p): New function.
10281 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10282 but without exporting it to Lisp.
23aba0ea 10283
23aba0ea 10284 * doc.c (Fdocumentation, store_function_docstring):
03408648 10285 * data.c (Finteractive_form): Handle closures.
23aba0ea 10286
03408648
SM
10287 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10288 interactive spec.
ba83908c 10289
04f2d78b
CB
10290 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10291 New byte-codes.
03408648
SM
10292 (exec_byte_code): New function extracted from Fbyte_code to handle new
10293 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10294
03408648 10295 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10296
03408648 10297 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10298
e2abce01
JB
102992011-03-31 Juanma Barranquero <lekktu@gmail.com>
10300
10301 * xdisp.c (redisplay_internal): Fix prototype.
10302
63696a73 103032011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10304
63696a73 10305 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10306 (try_scrolling): Use it when setting scroll_limit.
10307 Limit scrolling to 100 screen lines.
63696a73
EZ
10308 (redisplay_window): Even when falling back on "recentering",
10309 position point in the window according to scroll-conservatively,
10310 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10311
10312 (try_scrolling): When point is above the window, allow searching
10313 as far as scroll_max, or one screenful, to compute vertical
10314 distance from PT to the scroll margin position. This prevents
10315 try_scrolling from unnecessarily failing when
10316 scroll-conservatively is set to a value slightly larger than the
10317 window height. Clean up the case of PT below the margin at bottom
10318 of window: scroll_max can no longer be INT_MAX. When aggressive
10319 scrolling is in use, don't let point enter the opposite scroll
10320 margin as result of the scroll.
10321 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10322 threshold of 100 lines for never-recentering scrolling.
10323
e4cc2dfc
JB
103242011-03-31 Juanma Barranquero <lekktu@gmail.com>
10325
10326 * dispextern.h (move_it_by_lines):
10327 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10328 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10329 (message_log_check_duplicate): Remove parameters `prev_bol' and
10330 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10331 (redisplay_internal): Remove parameter `preserve_echo_area',
10332 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10333
10334 * indent.c (Fvertical_motion):
10335 * window.c (window_scroll_pixel_based, Frecenter):
10336 Don't pass `need_y_p' to `move_it_by_lines'.
10337
1c470562
SM
103382011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10339
44f230aa
SM
10340 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10341 steal a few bits to be more compact.
10342 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10343 Remove unneeded casts.
10344
1c470562
SM
10345 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10346
888adce9
ZK
103472011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10348
10349 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10350 binding" message (bug#7967).
10351
f838ed7b
PE
103522011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10353
77861b95
PE
10354 Fix more problems found by GCC 4.6.0's static checks.
10355
de6dbc14
PE
10356 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10357 Remove unused local var.
10358
f838ed7b
PE
10359 * editfns.c (Fmessage_box): Remove unused local var.
10360
792c7b2b
PE
10361 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10362 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10363 Omit unused local vars.
c499e557 10364 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10365 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10366 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10367 Omit unused local var.
10368
ba0165e1
PE
10369 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10370 Don't assume string length fits in int.
32ad8845 10371 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10372 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10373
3c59b4c9
PE
10374 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10375 instead of alloca (Bug#8344).
10376
a3eed478 10377 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10378 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10379
eb4d412d
PE
10380 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10381
1658b401
PE
10382 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10383 concerns.
10384
10385 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10386
10387 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10388
9a2c6e05
PE
10389 * keyboard.c (syms_of_keyboard): Use the same style as later
10390 in this function when indexing through an array. This also
10391 works around GCC bug 48267.
10392
03d0a109
PE
10393 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10394
44f730c8
PE
10395 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10396
fe75f926
PE
10397 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10398 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10399
ffa8c828
PE
10400 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10401 This avoids undefined behavior on integer overflow, and is a bit
10402 more convenient anyway since it is compared to a size_t variable.
10403
c5101a77
PE
10404 Variadic C functions now count arguments with size_t, not int.
10405 This avoids an unnecessary limitation on 64-bit machines, which
10406 caused (substring ...) to crash on large vectors (Bug#8344).
10407 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10408 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10409 All variadic functions and their callers changed accordingly.
c5101a77
PE
10410 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10411 * data.c (arith_driver, float_arith_driver): Likewise.
10412 * editfns.c (general_insert_function): Likewise.
10413 * eval.c (struct backtrace.nargs, interactive_p)
10414 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10415 (funcall_lambda, mark_backtrace): Likewise.
10416 * fns.c (concat): Likewise.
10417 * frame.c (x_set_frame_parameters): Likewise.
10418 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10419 0 if not found, not -1. All callers changed.
10420
dd3f25f7
PE
10421 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10422 (stack_copy_size): Now size_t, not int.
10423 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10424
461c2ab9
JB
104252011-03-28 Juanma Barranquero <lekktu@gmail.com>
10426
10427 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10428 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10429 All callers changed.
10430
10431 * lisp.h (multibyte_char_to_unibyte):
10432 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10433 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10434 * character.h (CHAR_TO_BYTE8):
10435 * cmds.c (internal_self_insert):
10436 * editfns.c (general_insert_function):
10437 * keymap.c (push_key_description):
10438 * search.c (Freplace_match):
10439 * xdisp.c (message_dolog, set_message_1): All callers changed.
10440
f6d62986
SM
104412011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10442
10443 * keyboard.c (safe_run_hook_funcall): New function.
10444 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10445 don't set the hook to nil, but remove the offending function instead.
10446 (Qcommand_hook_internal): Remove, unused.
10447 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10448 Vcommand_hook_internal.
10449
10450 * eval.c (enum run_hooks_condition): Remove.
10451 (funcall_nil, funcall_not): New functions.
10452 (run_hook_with_args): Call each function through a `funcall' argument.
10453 Remove `cond' argument, now redundant.
10454 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10455 (Frun_hook_with_args_until_failure): Adjust accordingly.
10456 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10457
1db5b1ad
JB
104582011-03-28 Juanma Barranquero <lekktu@gmail.com>
10459
10460 * dispextern.h (string_buffer_position): Remove declaration.
10461
10462 * print.c (strout): Remove parameter `multibyte', unused since
10463 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10464
10465 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10466 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10467 All callers changed.
10468
10469 * w32.c (_wsa_errlist): Use braces for struct initializers.
10470
10471 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10472 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10473 All callers changed.
10474 (string_buffer_position): Likewise. Also, make static (it's never
10475 used outside xdisp.c).
10476 (cursor_row_p): Remove parameter `w', unused since
10477 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10478 (decode_mode_spec): Remove parameter `precision', introduced during
10479 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10480 All callers changed.
10481
5ffb62aa
JD
104822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10483
10484 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10485
461c2ab9 104862011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10487
10488 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10489 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10490 (ns_update_auto_hide_menu_bar): New functions.
10491 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10492 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10493 ns_constrain_all_frames.
10494 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10495 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10496
5c380ffb
JD
104972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10498
10499 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10500
9af30bdf
GM
105012011-03-27 Glenn Morris <rgm@gnu.org>
10502
10503 * syssignal.h: Replace RETSIGTYPE with void.
10504 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10505 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10506 Replace SIGTYPE with void everywhere.
10507 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10508 * s/template.h (SIGTYPE): Remove commented out definition.
10509
e2abce01
JB
105102011-03-26 Eli Zaretskii <eliz@gnu.org>
10511
10512 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10513 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10514
f868cd8a
JB
105152011-03-26 Juanma Barranquero <lekktu@gmail.com>
10516
59eb0929
JB
10517 * w32.c (read_unc_volume): Use parameter `henum', instead of
10518 global variable `wget_enum_handle'.
10519
10520 * keymap.c (describe_vector): Remove parameters `indices' and
10521 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10522 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10523
f868cd8a
JB
10524 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10525
10526 * keyboard.c (timer_check): Remove parameter `do_it_now',
10527 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10528 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10529 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10530
10531 * keyboard.c (read_char):
10532 * w32menu.c (w32_menu_display_help):
10533 * xmenu.c (show_help_event, menu_help_callback):
10534 Adjust calls to `show_help_echo'.
10535
10536 * gtkutil.c (xg_maybe_add_timer):
10537 * keyboard.c (readable_events):
10538 * process.c (wait_reading_process_output):
10539 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10540
10541 * insdel.c (adjust_markers_gap_motion):
10542 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10543 (gap_left, gap_right): Don't call it.
10544
2ecf6fdb
CY
105452011-03-25 Chong Yidong <cyd@stupidchicken.com>
10546
10547 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10548 incurred during fontification.
10549
6b1f9ba4
JB
105502011-03-25 Juanma Barranquero <lekktu@gmail.com>
10551
10552 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10553 (DEFVAR_PER_BUFFER): Don't pass it.
10554
10555 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10556 (scrolling_window): Don't pass it.
10557
0f4a96b5
JB
105582011-03-25 Juanma Barranquero <lekktu@gmail.com>
10559
10560 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10561
10562 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10563 and `suffix'.
10564 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10565 of variables specific to SELinux and computation of `encoded_absname'.
10566
10567 * image.c (XPutPixel): Remove unused variable `height'.
10568
10569 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10570
10571 * unexw32.c (get_section_info): Remove unused variable `section'.
10572
10573 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10574 (system_process_attributes): Remove unused variable `sess'.
10575 (sys_read): Remove unused variable `err'.
10576
10577 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10578 (w32_wnd_proc): Remove unused variable `isdead'.
10579 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10580 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10581 (x_create_tip_frame): Remove unused variable `tem'.
10582
10583 * w32inevt.c (w32_console_read_socket):
10584 Remove unused variable `no_events'.
10585
10586 * w32term.c (x_draw_composite_glyph_string_foreground):
10587 Remove unused variable `width'.
10588
1149507c
JB
105892011-03-24 Juanma Barranquero <lekktu@gmail.com>
10590
10591 * w32term.c (x_set_glyph_string_clipping):
10592 Don't pass uninitialized region to CombineRgn.
10593
9c88f339
JB
105942011-03-23 Juanma Barranquero <lekktu@gmail.com>
10595
10596 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10597 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10598 (Fx_close_connection): Remove unused variable `i'.
10599
10600 * w32font.c (w32font_draw): Return number of glyphs.
10601 (w32font_open_internal): Remove unused variable `i'.
10602 (w32font_driver): Add missing initializer.
10603
10604 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10605 (fill_in_menu): Remove unused variable `items_added'.
10606
10607 * w32term.c (last_mouse_press_frame): Remove static global variable.
10608 (w32_clip_to_row): Remove unused variable `f'.
10609 (x_delete_terminal): Remove unused variable `i'.
10610
10611 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10612 (NOTHING): Remove unused static global variable.
10613 (uniscribe_check_otf): Remove unused variable `table'.
10614 (uniscribe_font_driver): Add missing initializers.
10615
dee091a3
JD
106162011-03-23 Julien Danjou <julien@danjou.info>
10617
10618 * term.c (Fsuspend_tty, Fresume_tty):
10619 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10620 * window.c (temp_output_buffer_show):
10621 * insdel.c (signal_before_change):
10622 * frame.c (Fhandle_switch_frame):
10623 * fileio.c (Fdo_auto_save):
10624 * emacs.c (Fkill_emacs):
10625 * editfns.c (save_excursion_restore):
10626 * cmds.c (internal_self_insert):
10627 * callint.c (Fcall_interactively):
10628 * buffer.c (Fkill_all_local_variables):
10629 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10630 Use Frun_hooks.
0f4a96b5 10631 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10632 unconditionally since it does the check itself.
dee091a3 10633
2c520ab5 106342011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10635
c9c49752
PE
10636 Fix more problems found by GCC 4.5.2's static checks.
10637
8abc3f12
PE
10638 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10639 the first time through the loop, since we know p0 < p1 then.
10640 This also avoids a gcc -Wstrict-overflow warning.
10641
a2d26660
PE
10642 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10643 leading to a memory leak, possible in functions like
10644 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10645 of objects (Bug#8318).
a2d26660 10646
916c72e9
PE
10647 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10648 that could (at least in theory) be that large.
10649
19ab8a18
PE
10650 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10651 This is less likely to overflow, and avoids undefined behavior if
10652 overflow does occur. All callers changed. Use strtoul to scan
10653 for the unsigned long integer.
b7cbbd6f
PE
10654 (pint2hrstr): Simplify and tune code slightly.
10655 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10656
f0641eff
PE
10657 * scroll.c (do_scrolling): Work around GCC bug 48228.
10658 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10659
7f650bb9
PE
10660 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10661 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10662 (validate_x_resource_name): Simplify count usage.
10663 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10664
37dd57d1
PE
10665 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10666 fail (Bug#8306).
81e56e61 10667
699979fc 10668 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10669
401bf9b4
PE
10670 * process.c (Fmake_network_process): Use socklen_t, not int,
10671 where POSIX says socklen_t is required in portable programs.
10672 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10673 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10674 (Fmake_network_process, server_accept_connection):
10675 (wait_reading_process_output, read_process_output):
10676 Likewise.
10677
b93aacde
PE
10678 * process.c: Rename or move locals to avoid shadowing.
10679 (list_processes_1, Fmake_network_process):
10680 (read_process_output_error_handler, exec_sentinel_error_handler):
10681 Rename or move locals.
4dc343ee 10682 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10683 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10684 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10685 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10686 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10687
af8a867c 10688 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10689 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10690 Include tparam.h instead, since it declares them.
af8a867c
PE
10691 * cm.h (PC): Remove extern decl; tparam.h now does this.
10692 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10693 * terminfo.c: Include tparam.h, to check interfaces.
10694 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10695 (tparam): Adjust signature to match interface in tparam.h;
10696 this removes some undefined behavior. Check that outstring and len
10697 are zero, which they always are with Emacs.
10698 * tparam.h (PC, BC, UP): New extern decls.
10699
0248044d 10700 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10701 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10702
8ff096c1 10703 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10704 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10705 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10706 (ftfont_list): Remove unused local.
49eaafba
PE
10707 (get_adstyle_property, ftfont_pattern_entity):
10708 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10709 Rename locals to avoid shadowing.
8ff096c1 10710
e2be39f6
PE
10711 * xfont.c (xfont_list_family): Mark var as initialized.
10712
c9735e30
PE
10713 * xml.c (make_dom): Now static.
10714
8f5201ae
PE
10715 * composite.c (composition_compute_stop_pos): Rename local to
10716 avoid shadowing.
b246f932
PE
10717 (composition_reseat_it): Remove unused locals.
10718 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10719 (composition_update_it): Mark var as initialized.
11b61122
PE
10720 (find_automatic_composition): Mark vars as initialized,
10721 with a FIXME (Bug#8290).
8f5201ae 10722
760fbc2c
PE
10723 character.h: Rename locals to avoid shadowing.
10724 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10725 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10726 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10727 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10728 to avoid shadowing.
10729
ff08eb85
PE
10730 * textprop.c (property_change_between_p): Remove; unused.
10731
fc7bf025
PE
10732 * intervals.c (interval_start_pos): Now static.
10733
235d7abc
PE
10734 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10735
44f230aa
SM
10736 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10737 Rename locals to avoid shadowing.
3e7d6594 10738
50060332
PE
10739 * sound.c (wav_play, au_play, Fplay_sound_internal):
10740 Fix pointer signedness.
d01f234b 10741 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10742 (wav_play): Initialize a variable to 0, to prevent undefined
10743 behavior (Bug#8278).
50060332 10744
c4fc4e30
PE
10745 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10746
918436ed
PE
10747 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10748
c939f91b
PE
10749 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10750 clobbering (Bug#8298).
b9c7f648
PE
10751 * sysdep.c (sys_subshell): Likewise.
10752 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10753
6bd8c144
PE
10754 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10755 This should get cleaned up, so that child_setup has the
10756 same signature on all platforms.
10757
7710357c 10758 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10759 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10760
c59da222
CY
107612011-03-22 Chong Yidong <cyd@stupidchicken.com>
10762
10763 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10764 not to be necessary, and produces flickering.
10765
66b87493
GM
107662011-03-20 Glenn Morris <rgm@gnu.org>
10767
10768 * config.in: Remove file.
10769
45b6f6d5
JB
107702011-03-20 Juanma Barranquero <lekktu@gmail.com>
10771
10772 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10773 are now in src/globals.h.
10774 (syms_of_minibuf): Remove spurious & from previous change.
10775
cd394be1 107762011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10777
10778 * minibuf.c (completing-read-function): New variable.
10779 (completing-read-default): Rename from completing-read.
10780 (completing-read): Call completing-read-function.
10781
b14e3e21
CY
107822011-03-19 Juanma Barranquero <lekktu@gmail.com>
10783
10784 * xfaces.c (Fx_load_color_file):
10785 Read color file from absolute filename (bug#8250).
10786
f2b726e6
JB
107872011-03-19 Juanma Barranquero <lekktu@gmail.com>
10788
10789 * makefile.w32-in: Update dependencies.
10790
09f6ff02
EZ
107912011-03-17 Eli Zaretskii <eliz@gnu.org>
10792
10793 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10794
29a6015a
PE
107952011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10796
a3a6c54e
PE
10797 Fix more problems found by GCC 4.5.2's static checks.
10798
b766f867
PE
10799 * process.c (make_serial_process_unwind, send_process_trap):
10800 (sigchld_handler): Now static.
10801
be02381c
PE
10802 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10803 That way, the code declares only the vars that it needs.
10804 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10805 * s/cygwin.h (PTY_ITERATION): Likewise.
10806 * s/darwin.h (PTY_ITERATION): Likewise.
10807 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10808
57048744
PE
10809 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10810 * process.c (allocate_pty): Don't declare stb unless it's needed.
10811
7914961c 10812 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10813 (CONSTANTLIM): Remove; unused.
10814 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10815 Define only if needed.
7914961c 10816
b3967b18
PE
10817 * unexelf.c (unexec): Name an expression,
10818 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10819 Use a different way to cause a compilation error if anyone uses
10820 n rather than nn, a way that does not involve shadowing.
73366a00 10821 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10822
29a6015a
PE
10823 * deps.mk (unexalpha.o): Remove; unused.
10824
43cfc33e 10825 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10826 * unexec.h: New file.
ce701a33
PE
10827 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10828 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10829 Depend on unexec.h.
10830 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10831 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10832 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10833 Change as necessary to match prototype in unexec.h.
ce701a33 10834
01f44d5a
PE
10835 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10836 shadowing.
4f63c6bb 10837 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10838
a6670b0b
PE
10839 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10840 Rename locals to avoid shadowing.
10841
cef2010d 10842 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10843 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10844
d4d7173a
PE
10845 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10846
f08b802a
PE
10847 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10848 warning when compiling print.c.
10849
3ddb0639
PE
10850 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10851 instead of using an uninitialized var.
5ad03b97 10852 (font_sort_entities): Mark var as initialized.
3ddb0639 10853
170a2692
PE
10854 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10855
e663c700
PE
10856 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10857 pointers to constants.
89bc529a 10858 (font_parse_fcname): Remove unused vars.
7b81e2d0 10859 (font_delete_unmatched): Now static.
ea838e10 10860 (font_get_spec): Remove; unused.
13a547c6
PE
10861 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10862 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10863 Rename or move locals to avoid shadowing.
e663c700 10864
2a80c887 10865 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10866 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10867
1384fa33 10868 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10869 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10870
8b2c52e9
PE
10871 * alloc.c (mark_backtrace): Move decl from here ...
10872 * lisp.h: ... to here, so that it can be checked.
10873
475545b5 10874 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10875 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10876 (lisp_indirect_variable): Name an expression,
10877 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10878 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10879
b1349114 10880 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10881 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10882 Use const pointer when appropriate.
b1349114 10883
a2928364
PE
10884 * lisp.h (get_system_name, get_operating_system_release):
10885 Move decls here, to check interfaces.
10886 * process.c (get_operating_system_release): Move decl to lisp.h.
10887 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10888 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10889 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10890 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10891 (Fformat_time_string, Fencode_time, Finsert_char):
10892 (Ftranslate_region_internal, Fformat):
10893 Rename or remove local vars to avoid shadowing.
9710023e 10894 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10895
a415e694
PE
10896 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10897 avoid shadowing.
10898
8ef4622d
PE
10899 * lisp.h (eassert): Check that the argument compiles, even if
10900 ENABLE_CHECKING is not defined.
10901
946f9a5b
PE
10902 * data.c (Findirect_variable): Name an expression, to avoid
10903 gcc -Wbad-function-cast warning.
112396d6 10904 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10905 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10906 (Fmake_variable_buffer_local, Fmake_local_variable):
10907 Mark variables as initialized.
52746918 10908 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10909
e5aab7e7 10910 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10911 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10912 Rename locals to avoid shadowing.
dff45157
PE
10913 (mark_stack): Move local variables into the #ifdef region where
10914 they're used.
7bc26fdb
PE
10915 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10916 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10917 needed otherwise.
10918 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10919 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10920 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10921
e5aab7e7
PE
10922 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10923 avoids undefined behavior in theory.
10924
4da60324
PE
10925 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10926
88043301
PE
10927 Use functions, not macros, for up- and down-casing (Bug#8254).
10928 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10929 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10930 to use the following functions instead of these macros.
10931 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10932 EMACS_INT, since callers assume the returned value fits in int.
10933 (upcase1): Likewise, for UPCASE_TABLE.
10934 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10935 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10936 the race-condition problem in the old DOWNCASE.
88043301 10937
19ed5445
PE
10938 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10939 Rename locals to avoid shadowing.
10940 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10941 (regex_compile, re_search_2, re_match_2_internal):
10942 Remove unused local vars.
952db0d7
PE
10943 (FREE_VAR): Rewrite so as not to use empty "else",
10944 which gcc can warn about.
da053e48 10945 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10946 (RETALLOC_IF): Define only if needed.
10947 (WORDCHAR_P): Likewise. This one is never needed, but is used
10948 only in a comment talking about a compiler bug, so put inside
10949 the #if 0 of that comment.
10950 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10951 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10952 Remove; unused.
19ed5445 10953
1f3561e4 10954 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10955 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10956 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10957
ded6f8f7
PE
10958 * search.c (simple_search): Remove unused var.
10959
dbd37a95
PE
10960 * dired.c (compile_pattern): Move decl from here ...
10961 * lisp.h: ... to here, so that it can be checked.
10962 (struct re_registers): New forward decl.
10963
7e47afad
PE
10964 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10965
85f24f61
PE
10966 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10967 All uses changed.
10968 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10969 Rename locals to avoid shadowing.
5671df8f 10970 (Fvertical_motion): Mark locals as initialized.
85f24f61 10971
181aa2be 10972 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10973 (casify_region): Mark local as initialized.
181aa2be 10974
930d429c
PE
10975 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10976
7082eac6
PE
10977 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10978 New macros, so that the caller can use some names other than
10979 gcpro1, gcpro2, etc.
10980 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10981 of the new macros.
10982 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10983 argument, for consistency with GCPRO2_VAR, etc: it is now the
10984 prefix of the variable, not the variable itself. All uses
10985 changed.
38b2c076
PE
10986 * dired.c (directory_files_internal, file_name_completion):
10987 Rename locals to avoid shadowing.
10988
15206ed9
PE
10989 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10990 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10991 dired.c's scmp function, had undefined behavior.
10992 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10993 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10994 * buffer.h: ... to here, because these macros use current_buffer,
10995 and the new implementation with inline functions needs to have
10996 current_buffer in scope now, rather than later when the macros
10997 are used.
10998 (downcase, upcase1): New static inline functions.
10999 (DOWNCASE, UPCASE1): Reimplement using these functions.
11000 This avoids undefined behavior in expressions like
11001 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11002 from race conditions in accessing the global variables
11003 case_temp1 and case_temp2.
11004 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11005 * lisp.h (case_temp1, case_temp2): Remove their decls.
11006 * character.h (ASCII_CHAR_P): Move from here ...
11007 * lisp.h: ... to here, so that the inline functions mentioned
11008 above can use them.
11009
4a6bea26
PE
11010 * dired.c (directory_files_internal_unwind): Now static.
11011
f14b7e14
PE
11012 * fileio.c (file_name_as_directory, directory_file_name):
11013 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11014 Now static.
2893f146
PE
11015 (file_name_as_directory): Use const pointers when appropriate.
11016 (Fexpand_file_name): Likewise. In particular, newdir might
11017 point at constant storage, so make it a const pointer.
fd4ead52 11018 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11019 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11020 signedness issues.
f839df0c
PE
11021 (Fset_file_times, Finsert_file_contents, auto_save_error):
11022 Rename locals to avoid shadowing.
f14b7e14 11023
5716756e 11024 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11025 (Ftry_completion, Fall_completions): Rename or remove locals
11026 to avoid shadowing.
5716756e 11027
b4c3046a
PE
11028 * marker.c (bytepos_to_charpos): Remove; unused.
11029
b45db522
PE
11030 * lisp.h (verify_bytepos, count_markers): New decls,
11031 so that gcc does not warn that these functions aren't declared.
11032
85876d07
PE
11033 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11034 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11035 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11036 (copy_text): Remove unused local var.
85876d07 11037
03d78a21 11038 * filelock.c (within_one_second): Now static.
b3dd38ab 11039 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11040
5df8f01b
PE
11041 * buffer.c (fix_overlays_before): Mark locals as initialized.
11042 (fix_start_end_in_overlays): Likewise. This function should be
11043 simplified by using pointers-to-pointers, but that's a different
11044 matter.
b1d876f1 11045 (switch_to_buffer_1): Now static.
8f54f30a
PE
11046 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11047 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11048
a70072c9 11049 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11050 Fix pointer signedness issue.
edced198
PE
11051 (sys_subshell): Mark local as volatile if checking for lint,
11052 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11053 (MAXPATHLEN): Define only if needed.
a70072c9 11054
a0977c44
PE
11055 * process.c (serial_open, serial_configure): Move decls from here ...
11056 * systty.h: ... to here, so that they can be checked.
11057
a884fdcc
PE
11058 * fns.c (get_random, seed_random): Move extern decls from here ...
11059 * lisp.h: ... to here, so that they can be checked.
11060
604efe86 11061 * sysdep.c (reset_io): Now static.
b8950c94 11062 (wait_for_termination_signal): Remove; unused.
604efe86 11063
38fc62d9
PE
11064 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11065 (copy_keymap_item, append_key, push_text_char_description):
11066 Now static.
1004a21a 11067 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11068 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11069 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11070 (describe_map_tree):
11071 Rename locals to avoid shadowing.
38fc62d9 11072
2f2650da
PE
11073 * keyboard.c: Declare functions static if they are not used elsewhere.
11074 (echo_char, echo_dash, cmd_error, top_level_2):
11075 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11076 (read_char, kbd_buffer_get_event, make_lispy_position):
11077 (make_lispy_event, make_lispy_movement, apply_modifiers):
11078 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11079 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11080 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11081 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11082 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11083
a053e86c 11084 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11085 (mark_kboards): Move decl here ...
11086 * alloc.c (mark_kboards): ... from here.
a053e86c 11087
4752793e
PE
11088 * lisp.h (force_auto_save_soon): New decl.
11089
74f10ca7 11090 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11091 (DEFINE_DUMMY_FUNCTION): New macro.
11092 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11093 Use it.
c03cd23f
PE
11094 (main): Add casts to avoid warnings
11095 if GCC considers string literals to be constants.
74f10ca7 11096
022e70d4
PE
11097 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11098
59d6fe83
PE
11099 * dbusbind.c: Pointer signedness fixes.
11100 (xd_signature, xd_append_arg, xd_initialize):
11101 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11102 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11103 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11104 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11105
78320123
PE
11106 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11107 if GCC considers string literals to be constants.
49cebcca 11108 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11109
35ac2a97
SM
111102011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11111
fb103ca9
SM
11112 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11113 (print_preprocess, print_object): New macro to fix last change.
11114
35ac2a97
SM
11115 * print.c (print_preprocess): Don't forget font objects.
11116
62973b41
JB
111172011-03-16 Juanma Barranquero <lekktu@gmail.com>
11118
11119 * emacs.c (USAGE3): Doc fixes.
11120
0e48bb22
AS
111212011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11122
11123 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11124 structure.
11125
7684e57b
JB
111262011-03-14 Juanma Barranquero <lekktu@gmail.com>
11127
11128 * lisp.h (VWindow_system, Qfile_name_history):
11129 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11130 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11131 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11132
11133 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11134 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11135
11136 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11137 * w32console.c (detect_input_pending, read_input_pending)
11138 (encode_terminal_code):
11139 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11140 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11141 (w32_system_caret_y, Qfile_name_history):
11142 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11143 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11144 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11145 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11146 * w32proc.c (Qlocal, report_file_error):
11147 * w32term.c (Vwindow_system, updating_frame):
11148 * w32uniscribe.c (initialized, uniscribe_font_driver):
11149 Remove unneeded extern declarations.
11150
2aa46d6c
CY
111512011-03-14 Chong Yidong <cyd@stupidchicken.com>
11152
c96bbc66 11153 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11154
cffc6f3b
CY
111552011-03-13 Chong Yidong <cyd@stupidchicken.com>
11156
11157 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11158 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11159 These macros can no longer be used for assignment.
11160
44f230aa
SM
11161 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11162 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11163 (record_buffer_markers, fetch_buffer_markers): New functions for
11164 recording and fetching special buffer markers.
11165 (set_buffer_internal_1, set_buffer_temp): Use them.
11166
11167 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11168
11169 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11170
11171 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11172 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11173
11174 * xdisp.c (hscroll_window_tree):
11175 (reconsider_clip_changes): Use PT instead of BUF_PT.
11176
d251f04b
EZ
111772011-03-13 Eli Zaretskii <eliz@gnu.org>
11178
11179 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11180 $(EMACS_ROOT)/lib/intprops.h.
11181
f0c77cd1
PE
111822011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11183
3eca4629
PE
11184 Fix more problems found by GCC 4.5.2's static checks.
11185
7c86ee98
PE
11186 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11187 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11188 (xg_free_frame_widgets): Make it clear that a local variable is
11189 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11190 (gdk_window_get_screen): Make it clear that this macro is needed
11191 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11192 (int_gtk_range_get_value): New function, which avoids a diagnostic
11193 from gcc -Wbad-function-cast.
11194 (xg_set_toolkit_scroll_bar_thumb): Use it.
11195 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11196 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11197 (get_utf8_string, xg_get_file_with_chooser):
11198 Rename locals to avoid shadowing.
11199 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11200
41729b81
PE
11201 * xgselect.c (xg_select): Remove unused var.
11202
f0c77cd1
PE
11203 * image.c (four_corners_best): Mark locals as initialized.
11204 (gif_load): Initialize transparent_p to zero (Bug#8238).
11205 Mark another local as initialized.
ec6cf4c6 11206 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11207
ce0ad53d 11208 * image.c (clear_image_cache): Now static.
d5d5a617 11209 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11210 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11211 (x_edge_detection): Remove unnecessary cast that
11212 gcc -Wbad-function-cast diagnoses.
2037898d 11213 (gif_load): Fix pointer signedness.
6ae141d6
PE
11214 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11215 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11216
33383987 112172011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11218
d32df629
PE
11219 Improve quality of tests for time stamp overflow.
11220 For example, without this patch (encode-time 0 0 0 1 1
11221 1152921504606846976) returns the obviously-bogus value (-948597
11222 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11223 reports time overflow. See
11224 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11225 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11226 * editfns.c: Include limits.h and intprops.h.
11227 (TIME_T_MIN, TIME_T_MAX): New macros.
11228 (time_overflow): Move earlier, to before first use.
11229 (hi_time, lo_time): New functions, for an accurate test for
11230 out-of-range times.
11231 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11232 (Fget_internal_run_time): Don't assume time_t fits in int.
11233 (make_time): Use list2 instead of Fcons twice.
11234 (Fdecode_time): More accurate test for out-of-range times.
11235 (check_tm_member): New function.
11236 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11237 (lisp_time_argument): Don't rely on undefined left-shift and
11238 right-shift behavior when checking for time stamp overflow.
8be6f318 11239
fe31d94c
PE
11240 * editfns.c (time_overflow): New function, refactoring common code.
11241 (Fformat_time_string, Fdecode_time, Fencode_time):
11242 (Fcurrent_time_string): Use it.
11243
8be6f318
PE
11244 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11245 * dired.c (make_time): Move to ...
11246 * editfns.c (make_time): ... here.
11247 * systime.h: Note the move.
11248
09d9db2c 112492011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11250
126bc0dc
YM
11251 * fringe.c (update_window_fringes): Remove unused variables.
11252
c47cbdfd
YM
11253 * unexmacosx.c (copy_data_segment): Also copy __got section.
11254 (Bug#8223)
11255
7ac80be9
EZ
112562011-03-12 Eli Zaretskii <eliz@gnu.org>
11257
c96bbc66 11258 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11259 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11260 Constify `char *' arguments and their references according to
11261 prototypes in tparam.h.
11262
ecb0f94d 11263 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11264
7ac80be9
EZ
11265 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11266 Adapt all references accordingly.
11267
11268 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11269
ef1fd07e
TT
112702011-03-11 Tom Tromey <tromey@redhat.com>
11271
11272 * buffer.c (syms_of_buffer): Remove obsolete comment.
11273
7ef4b50c
EZ
112742011-03-11 Eli Zaretskii <eliz@gnu.org>
11275
11276 * termhooks.h (encode_terminal_code): Declare prototype.
11277
11278 * msdos.c (encode_terminal_code): Don't declare prototype.
11279
11280 * term.c (encode_terminal_code): Now external again, used by
11281 w32console.c and msdos.c.
11282
44f230aa
SM
11283 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11284 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11285
4b1ec863 112862011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11287
1714f52b 11288 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11289
4b1ec863
PE
11290 * fringe.c (update_window_fringes): Mark locals as initialized
11291 (Bug#8227).
11292 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11293
524c7aa6
PE
11294 * alloc.c (mark_fringe_data): Move decl from here ...
11295 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11296 to check its interface.
11297 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11298
a5c0af81 11299 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11300 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11301 (fontset_font): Mark local as initialized.
a9a06e0b 11302 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11303
b4716021
PE
11304 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11305
811e9bac 11306 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11307 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11308 (x_own_selection, Fx_disown_selection_internal): Rename locals
11309 to avoid shadowing.
11310 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11311
7e3ab302
PE
11312 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11313 so that the caller can use some name other than gcpro1.
11314 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11315 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11316 (Fx_backspace_delete_keys_p):
11317 Use them to avoid shadowing, and rename vars to avoid shadowing.
11318 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11319 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11320 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11321 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11322 Remove unused locals.
7e3ab302
PE
11323 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11324 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11325 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11326 macros.
f78faa98 11327
e2b13473
PE
11328 * xterm.h (x_mouse_leave): New decl.
11329
77f23912
PE
11330 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11331 Remove unused functions.
cdf4ba58
PE
11332 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11333 (x_calc_absolute_position): Now static.
7411c686 11334 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11335 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11336 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11337 unless they are used.
38d0b34a
PE
11338 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11339 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11340 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11341 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11342 (x_error_catcher, x_connection_closed, x_error_handler):
11343 (x_error_quitter, xembed_send_message, x_iconify_frame):
11344 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11345 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11346 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11347
44f230aa
SM
11348 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11349 Rename or move locals to avoid shadowing.
6b463e58 11350 (tty_defined_color, merge_face_heights): Now static.
5967d051 11351 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11352 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11353 does not deduce is never used uninitialized.
73719eba
PE
11354 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11355 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11356
426994c3 11357 * terminal.c (store_terminal_param): Now static.
5489860b 11358
032f1620 11359 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11360 (set_frame_menubar): Remove unused local.
d4323972 11361 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11362 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11363 since they might point to immutable storage.
281585b0
PE
11364 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11365 since it's unused otherwise.
032f1620 11366
367c19e5 11367 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11368 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11369 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11370 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11371 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11372 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11373 does not deduce are never used uninitialized.
70739cbe 11374
07b48fa9
PE
11375 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11376
8868a238 11377 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11378 * window.c (window_loop, size_window):
11379 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11380
7e5cf297 11381 * window.c (display_buffer): Now static.
d6550a9f
PE
11382 (size_window): Mark variables that gcc -Wuninitialized
11383 does not deduce are never used uninitialized.
a586633d
PE
11384 * window.h (check_all_windows): New decl, to forestall
11385 gcc -Wmissing-prototypes diagnostic.
5b555da1 11386 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11387
f6095868
PE
11388 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11389 shadowing.
11390 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11391 Include <limits.h>.
11392 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11393 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11394 (load_charset_map): Mark variables that gcc -Wuninitialized
11395 does not deduce are never used uninitialized.
53df7c11 11396 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11397
f38b440c
PE
11398 * coding.c (coding_set_source, coding_set_destination):
11399 Use "else { /* comment */ }" rather than "else /* comment */;"
11400 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11401 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11402 a block, when the outer 'i' will do.
11403 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11404 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11405 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11406 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11407 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11408 Rename locals to avoid shadowing.
11409 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11410 * coding.c (emacs_mule_char, encode_invocation_designation):
11411 Now static, since they're not used elsewhere.
413bb2db 11412 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11413 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11414 (decode_coding_emacs_mule): Mark variables that gcc
11415 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11416 (detect_coding_iso_2022): Initialize a local variable that might
11417 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11418 this initialization is needed. (Bug#8211)
5f58e762
PE
11419 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11420 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11421 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11422 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11423 Remove unused macros.
f38b440c 11424
232b38b9 11425 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11426 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11427 * character.c (string_count_byte8): Likewise.
232b38b9 11428
fb90da1b
PE
11429 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11430 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11431
fb93dbc2
PE
11432 * chartab.c (copy_sub_char_table): Now static, since it's not used
11433 elsewhere.
5c156ace
PE
11434 (sub_char_table_ref_and_range, char_table_ref_and_range):
11435 Rename locals to avoid shadowing.
bbcd0949 11436 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11437
7d3b3862 11438 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11439 (BIDI_BOB): Remove unused macro.
7d3b3862 11440
6be7d3da
PE
11441 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11442 deduce are never used uninitialized.
c2ed9c8b 11443 * term.c (encode_terminal_code): Likewise.
6be7d3da 11444
75f8807f 11445 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11446
50938595
PE
11447 * tparam.h: New file.
11448 * term.c, tparam.h: Include it.
11449 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11450 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11451 Move these decls to tparam.h, and make them agree with what
11452 is actually in tparam.c. The previous trick of using incompatible
11453 decls in different modules does not conform to the C standard.
11454 All callers of tparam changed to use tparam's actual API.
11455 * tparam.c (tparam1, tparam, tgoto):
11456 Use const pointers where appropriate.
11457
fbceeba2
PE
11458 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11459 * cm.h (struct cm): Likewise.
11460 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11461 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11462 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11463 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11464 (turn_on_face, init_tty): Likewise.
11465 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11466
7f3f1250
PE
11467 * term.c (term_mouse_position): Rename local to avoid shadowing.
11468
e6ca6543
PE
11469 * alloc.c (mark_ttys): Move decl from here ...
11470 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11471
c40f8d15
AS
114722011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11473
11474 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11475
cfe0661d
JB
114762011-03-09 Juanma Barranquero <lekktu@gmail.com>
11477
11478 * search.c (compile_pattern_1): Remove argument regp, unused since
11479 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11480 (compile_pattern): Don't pass it.
11481
0afb4571
J
114822011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11483
11484 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11485 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11486 for ! HAVE_GTK3.
11487 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11488
11489 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11490
11491 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11492 gdk_window_get_screen, gdk_window_get_geometry,
11493 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11494 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11495 (xg_get_pixbuf_from_pixmap): New function.
11496 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11497 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11498 Call xg_get_pixbuf_from_pixmap instead of
11499 gdk_pixbuf_get_from_drawable.
11500 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11501 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11502 (xg_check_special_colors): Use GtkStyleContext and its functions
11503 for HAVE_GTK3.
11504 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11505 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11506 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11507 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11508 Call gtk_widget_get_preferred_size.
0afb4571
J
11509 (xg_frame_resized): gdk_window_get_geometry only takes 5
11510 parameters.
44f230aa
SM
11511 (xg_win_to_widget, xg_event_is_for_menubar):
11512 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11513 (xg_set_widget_bg): New function.
11514 (delete_cb): New function.
895009e1 11515 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11516 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11517 (xg_set_background_color): Call xg_set_widget_bg.
11518 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11519 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11520 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11521 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11522 if ! HAVE_GTK3.
11523 (update_frame_tool_bar): Call gtk_widget_hide.
11524 (xg_initialize): Use GDK_KEY_g.
11525
11526 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11527 if ! HAVE_GTK3
11528 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11529
11530 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11531 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11532 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11533
1c2cc4ef
JB
115342011-03-08 Juanma Barranquero <lekktu@gmail.com>
11535
11536 * w32xfns.c (select_palette): Check success of RealizePalette against
11537 GDI_ERROR, not zero.
11538
33383987 11539See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11540
11541;; Local Variables:
11542;; coding: utf-8
aac0c6e3
MR
11543;; End:
11544
2f097256 11545 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11546
11547 This file is part of GNU Emacs.
11548
11549 GNU Emacs is free software: you can redistribute it and/or modify
11550 it under the terms of the GNU General Public License as published by
11551 the Free Software Foundation, either version 3 of the License, or
11552 (at your option) any later version.
11553
11554 GNU Emacs is distributed in the hope that it will be useful,
11555 but WITHOUT ANY WARRANTY; without even the implied warranty of
11556 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11557 GNU General Public License for more details.
11558
11559 You should have received a copy of the GNU General Public License
11560 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.