* src/keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2071918e
DA
12011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4
b50a28de
SM
52011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6
7 * intervals.c: Fix grafting over the whole buffer (bug#10071).
8 (graft_intervals_into_buffer): Simplify.
9
015137db
EZ
102011-11-18 Eli Zaretskii <eliz@gnu.org>
11
12 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
13 hash values of the two rows.
14 (copy_row_except_pointers): Preserve the used[] arrays and the
15 hash values of the two rows. (Bug#10035)
68c95424 16 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
17
18 * xdisp.c (row_hash): New function, body extracted from
19 compute_line_metrics.
20 (compute_line_metrics): Call row_hash, instead of computing the
21 hash code inline.
22
23 * dispnew.c (verify_row_hash): Call row_hash for computing the
24 hash code of a row, instead of duplicating code from xdisp.c.
25
26 * dispextern.h (row_hash): Add prototype.
27
a2addb04
TH
282011-11-18 Tassilo Horn <tassilo@member.fsf.org>
29
30 * frame.c (delete_frame): Don't delete the terminal when the last
31 X frame is closed if emacs is built with GTK toolkit.
32
df85d315
JB
332011-11-17 Juanma Barranquero <lekktu@gmail.com>
34
35 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
36
a0c2d0ae
MR
372011-11-17 Martin Rudalics <rudalics@gmx.at>
38
39 * window.c (Vwindow_splits): Rename to
40 Vwindow_combination_resize. Suggested by Juri Linkov.
41 (Fsplit_window_internal): Use Vwindow_combination_resize instead
42 of Vwindow_splits.
43
58179cce
JB
442011-11-16 Juanma Barranquero <lekktu@gmail.com>
45
7877f373
JB
46 * nsfns.m (Fns_font_name):
47 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 48
b6f67890
MR
492011-11-16 Martin Rudalics <rudalics@gmx.at>
50
51 * window.h (window): Rename slot "nest" to "combination_limit".
52 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
53 (Fset_window_nest): Rename to Fset_window_combination_limit.
54 (Vwindow_nest): Rename to Vwindow_combination_limit.
55 (recombine_windows, make_parent_window, make_window)
56 (Fsplit_window_internal, saved_window)
57 (Fset_window_configuration, save_window_save): Rename all
58 occurrences of window_nest to window_combination_limit.
59
c7015153
JB
602011-11-15 Juanma Barranquero <lekktu@gmail.com>
61
62 * image.c (imagemagick_load_image): Fix typo.
63
322ad6ec
EZ
642011-11-14 Eli Zaretskii <eliz@gnu.org>
65
66 * xdisp.c (display_line): Move the call to
67 highlight_trailing_whitespace before the call to
68 compute_line_metrics, since the latter needs to see the final
69 faces of all the glyphs to compute ROW's hash value. Fixes
70 assertion violations in row_equal_p. (Bug#10035)
71
f067b8ec
JB
722011-11-14 Juanma Barranquero <lekktu@gmail.com>
73
74 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
75 just return (bug#10044).
76
1e5b2111
EZ
772011-11-12 Eli Zaretskii <eliz@gnu.org>
78
7ef3cbd5
EZ
79 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
80 with user-defined heap size. Bump the default size of the temacs
81 heap to 27MB, to avoid memory warning when running temacs.
82 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
83
1e5b2111
EZ
84 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
85 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
86 (verify_row_hash) [XASSERTS]: New function.
87 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
88 that the hash value of glyph rows is correct.
1e5b2111 89
89d61221
MR
902011-11-12 Martin Rudalics <rudalics@gmx.at>
91
92 * window.h (window): Remove splits slot.
93 * window.c (Fwindow_splits, Fset_window_splits): Remove.
94 (Fdelete_other_windows_internal, make_parent_window)
95 (make_window, Fsplit_window_internal, Fdelete_window_internal)
96 (Fset_window_configuration, save_window_save): Don't deal with
97 split status of windows.
98 (saved_window): Remove splits slot.
99 (Vwindow_splits): Rewrite doc-string.
100
97f18cc8
JD
1012011-11-11 Jan Djärv <jan.h.d@swipnet.se>
102
103 * xfns.c (unwind_create_frame):
104 * nsfns.m (unwind_create_frame):
105 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
106 Vframe_list (Bug#9999).
107
22a648b4
DA
1082011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
109
0b381c7e 110 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 111
659afede
KH
1122011-11-11 Kenichi Handa <handa@m17n.org>
113
114 * callproc.c (Fcall_process): Set the member dst_multibyte of
115 process_coding.
116
9ac0394b
KH
1172011-11-11 Johan Bockgård <bojohan@gnu.org>
118
119 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
120 avoid a crash (bug#9496).
121
2fbdc249
CY
1222011-11-09 Chong Yidong <cyd@gnu.org>
123
124 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
125 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
126
ac6b1f81
PE
1272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
128
129 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
130
09db192c
PE
1312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
132
133 Avoid some portability problems by eschewing 'extern inline' functions.
134 The trivial performance wins aren't worth the portability hassles; see
135 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
136 et seq.
137 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
138 (window_box_width, window_box_left, window_box_left_offset)
139 (window_box_right, window_box_right_offset): Undo previous change,
140 by removing the "extern"s.
141 * intervals.c (adjust_intervals_for_insertion)
142 (adjust_intervals_for_deletion): Undo previous change,
143 making these static again.
144 (offset_intervals, temp_set_point_both, temp_set_point)
145 (copy_intervals_to_string): No longer inline.
146 * xdisp.c (window_text_bottom_y, window_box_width)
147 (window_box_height, window_box_left_offset)
148 (window_box_right_offset, window_box_left, window_box_right)
149 (window_box): No longer inline.
150
105216ed
CY
1512011-11-08 Chong Yidong <cyd@gnu.org>
152
153 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
154 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
155 an error if not a live window.
156 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
157 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
158
ae9e237f
JB
1592011-11-07 Juanma Barranquero <lekktu@gmail.com>
160
161 * lisp.h (syms_of_abbrev): Remove declaration.
162 Reported by CHENG Gao <chenggao@royau.me>.
163
c7aa8333
EZ
1642011-11-07 Eli Zaretskii <eliz@gnu.org>
165
166 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
167 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
168 of temacs in GUI mode.
169
be7f5545
MR
1702011-11-07 Martin Rudalics <rudalics@gmx.at>
171
172 * window.h: Declare delete_all_child_windows instead of
173 delete_all_subwindows.
174 * window.c (Fwindow_nest, Fset_window_nest)
175 (Fset_window_new_total, Fset_window_new_normal)
176 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
177 (delete_all_subwindows): Rename to delete_all_child_windows.
178 (Fdelete_other_windows_internal, Fset_window_configuration):
179 Call delete_all_child_windows instead of delete_all_subwindows.
180 * frame.c (delete_frame): Call delete_all_child_windows instead
181 of delete_all_subwindows.
182
ca78dc43
PE
1832011-11-07 Paul Eggert <eggert@cs.ucla.edu>
184
185 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
186 This is also needed for porting to any host where GC_MARK_STACK is
187 not GC_MAKE_GCPROS_NOOPS.
188 (which_symbols): Use it.
189
a0241d01
KH
1902011-11-07 Kenichi Handa <handa@m17n.org>
191
192 * coding.c (coding_set_destination): Check coding->src_pos only
193 when coding->src_object is a buffer (bug#9910).
194
195 * process.c (send_process): Set the member src_multibyte of coding
196 to 0 (bug#9911) when sending a unibyte text.
197
198 * callproc.c (Fcall_process): Set the member src_multibyte of
199 process_coding to 0 (bug#9912).
200
a64bfdfa 2012011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
202
203 * xmenu.c (cleanup_widget_value_tree): New function.
204 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
205 calling free_menubar_widget_value_tree directly (Bug#9830).
206
cb41b32a
PE
2072011-11-06 Paul Eggert <eggert@cs.ucla.edu>
208
209 Fix some portability problems with 'inline'.
210 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
211 (window_box_width, window_box_left, window_box_left_offset)
212 (window_box_right, window_box_right_offset): Declare extern.
213 Otherwise, these inline functions do not conform to C99 and
214 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
215 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
216 * intervals.c (adjust_intervals_for_insertion)
217 (adjust_intervals_for_deletion): Now extern, because otherwise the
218 extern inline functions 'offset_intervals' couldn't refer to it.
219 (static_offset_intervals): Remove.
220 (offset_intervals): Rewrite using the old contents of
221 static_offset_intervals. The old version didn't conform to C99
222 because an extern inline function contained a reference to an
223 identifier with static linkage.
224
b7041366
AS
2252011-11-06 Andreas Schwab <schwab@linux-m68k.org>
226
227 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
228 GC.
229
88a37c4d
EZ
2302011-11-06 Eli Zaretskii <eliz@gnu.org>
231
232 * xdisp.c (init_iterator, reseat_to_string): Don't set the
233 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
234 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
235 return Qleft_to_right.
236
49745b39
CY
2372011-11-06 Chong Yidong <cyd@gnu.org>
238
239 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
240 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
241 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
242 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
243 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
244 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
245 (Fwindow_vscroll): Doc fix.
246 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
247 argument, since it makes no sense to pass a live window and for
248 consistency with window-child.
249
1f05cd82
CS
2502011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
251
252 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
253 support MSVC.
254
22610910
JR
2552011-11-05 Jason Rumney <jasonr@gnu.org>
256
257 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
258 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
259 fonts (Bug#6029).
260 (add_font_entity_to_list): Fix logic errors in mixed boolean and
261 bitwise arithmetic preventing use of unicode-sip and non-truetype
262 opentype fonts.
263
a06776b2
EZ
2642011-11-05 Eli Zaretskii <eliz@gnu.org>
265
3ad924ba
EZ
266 * s/ms-w32.h (fstat, stat, utime): Move redirections to
267 "emacs"-only part.
268
a06776b2
EZ
269 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
270 initialization code to keep similarity to xfns.c after changes
271 from 2011-11-05.
272
c9e7db78
JD
2732011-11-05 Jan Djärv <jan.h.d@swipnet.se>
274
a97f8f3f
JD
275 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
276 (unwind_create_frame): New function (Bug#9943).
277 (Fx_create_frame): Restructure code to be more similar to the one in
278 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
279 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
280 Move terminal->reference_count++ just before making the frame official
281 (Bug#9943).
282
283 * nsterm.m (x_free_frame_resources): New function.
284 (x_destroy_window): Move code to x_free_frame_resources.
285
c9e7db78
JD
286 * xfns.c (unwind_create_frame): Fix comment.
287 (Fx_create_frame, x_create_tip_frame): Move
288 terminal->reference_count++ just before making the frame
289 official. Move initialization of image_cache_refcount and
290 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
291
a6fc3b5c
EZ
2922011-11-05 Eli Zaretskii <eliz@gnu.org>
293
294 Support MSVC build with newer versions of Visual Studio.
295 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
296 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
297 nt/gmake.defs.
298
299 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
300 which are not supported by MSVC.
301 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
302 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
303 bitfields.
304 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
305 types in bitfields.
306 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
307
308 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
309
58179cce 3102011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
311
312 Support MSVC build with newer versions of Visual Studio.
313 * w32.c: Don't include w32api.h for MSVC.
314 (init_environment) [_MSC_VER]: Call sys_access, not _access.
315
316 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
317 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
318 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
319 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
320 e_* cousins.
321 (alloca) [_MSC_VER]: Define to _alloca.
322
323 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
324
325 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
326
a58c13ed
EZ
3272011-11-04 Eli Zaretskii <eliz@gnu.org>
328
329 * xdisp.c (note_mouse_highlight): If either of
330 previous/next-single-property-change returns nil, treat that as
331 the beginning or the end of the buffer. (Bug#9955)
332
fe0b6370
JD
3332011-11-04 Jan Djärv <jan.h.d@swipnet.se>
334
a58c13ed 335 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
336 label is not null (Bug#9951).
337 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
338 may be NULL.
339
89bd5ee1
EZ
3402011-11-04 Eli Zaretskii <eliz@gnu.org>
341
342 * window.c (Fwindow_body_size): Mention in the doc string that the
343 return value is in frame's canonical units. (Bug#9949)
344
84c3edb9
EZ
3452011-11-03 Eli Zaretskii <eliz@gnu.org>
346
4e2fb5c7
EZ
347 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
348
84c3edb9 349 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 350 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 351 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 352
bc17a887
EZ
3532011-11-01 Eli Zaretskii <eliz@gnu.org>
354
355 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
356 Don't stop backward scan on the continuation glyph, even though
357 its CHARPOS is positive.
26b46e51
EZ
358 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
359 cover_string to disp_string.
bc17a887 360
4ee88440
MR
3612011-11-01 Martin Rudalics <rudalics@gmx.at>
362
363 * window.c (temp_output_buffer_show): Don't use
364 Vtemp_buffer_show_specifiers.
365 (Vtemp_buffer_show_specifiers): Remove unused variable.
366
c2ff3c02
EZ
3672011-10-30 Eli Zaretskii <eliz@gnu.org>
368
369 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
370 past the beginning of the current glyph matrix.
371
58179cce 3722011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
373
374 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
375 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
376 HAVE_GTK3 (Bug#9869).
b77a6a7f 377
3b574623
JD
378 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
379 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
380
b77a6a7f
JD
381 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
382
383 * xterm.c: Declare x_handle_net_wm_state to return int.
384 (handle_one_xevent): Check if we are iconified but don't have
385 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
386 (get_current_wm_state): Return non-zero if not hidden,
387 check for _NET_WM_STATE_HIDDEN (Bug#9893).
388 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
389 (x_handle_net_wm_state): Return what get_current_wm_state returns.
390 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
391
196e41e4
PE
3922011-10-29 Paul Eggert <eggert@cs.ucla.edu>
393
394 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
395 so that this new function doesn't get optimized away by a
396 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
397
021f2e1a
AS
3982011-10-29 Andreas Schwab <schwab@linux-m68k.org>
399
400 * frame.h (MOUSE_HL_INFO): Remove excess parens.
401
8b058d44
EZ
4022011-10-29 Eli Zaretskii <eliz@gnu.org>
403
404 Fix the `xbytecode' command.
405 * .gdbinit (xprintbytestr): New command.
b50a28de 406 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
407 (xbytecode): Print the byte-code string as well.
408
4452fb80
EZ
4092011-10-29 Kim Storm <storm@cua.dk>
410
8b058d44
EZ
411 * alloc.c (which_symbols): New function.
412
21b72067
AS
4132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
414
415 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
416 line. (Bug#9903)
417
83ed7b5c
GM
4182011-10-29 Glenn Morris <rgm@gnu.org>
419
420 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
421 Not clear what it was for, and it causes various bugs. (Bug#9839)
422
5a7a728b
EZ
4232011-10-28 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
426 possible random value that matches one of those tested as
427 condition to clear the mouse face.
428
d3d0842f
CY
4292011-10-28 Chong Yidong <cyd@gnu.org>
430
431 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
432
31b39d13
DN
4332011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
434
435 * window.c (make_window): Initialize phys_cursor_on_p.
436
9aba6043
SM
4372011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
438
439 * lisp.h (struct Lisp_Symbol): Update comments.
440
c20992f4
JB
4412011-10-28 Juanma Barranquero <lekktu@gmail.com>
442
443 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
444
db4f02f2
EZ
4452011-10-28 Eli Zaretskii <eliz@gnu.org>
446
447 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
448 <oslsachem@gmail.com> for helping to debug this.
449
450 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
451 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
452 (g_b_init_get_glyph_outline_w): New static variables.
453 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
454 (GetGlyphOutlineW_Proc): New typedefs.
455 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
456 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
457 New functions.
458 (w32font_open_internal, compute_metrics):
459 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
460 instead of calling the "wide" APIs directly.
461
462 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
463
464 * w32.h (syms_of_w32font): Add prototype.
465
87e68db4
JB
4662011-10-27 Juanma Barranquero <lekktu@gmail.com>
467
468 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
469 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
470 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
471 (Fmove_to_window_line): Doc fix.
472
435c1d67
CY
4732011-10-27 Chong Yidong <cyd@gnu.org>
474
475 * process.c (make_process): Set gnutls_state to NULL.
476
477 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
478 non-NULL, regardless of GNUTLS_INITSTAGE.
479 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
480 an error. Set process slots as soon as we allocate them.
481
482 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
483
9c6c6f49
CY
4842011-10-27 Chong Yidong <cyd@gnu.org>
485
9aba6043
SM
486 * gnutls.c (emacs_gnutls_deinit): New function.
487 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
488 (Fgnutls_deinit, Fgnutls_boot): Use it.
489
490 * process.c (make_process): Initialize GnuTLS credentials to NULL.
491 (deactivate_process): Call emacs_gnutls_deinit.
492
657d08d3
JB
4932011-10-27 Juanma Barranquero <lekktu@gmail.com>
494
495 * image.c (x_create_x_image_and_pixmap):
496 * w32.c (sys_rename, w32_delayed_load):
497 * w32font.c (fill_in_logfont):
498 * w32reg.c (x_get_string_resource): Silence compiler warnings.
499
5430d399
JB
5002011-10-26 Juanma Barranquero <lekktu@gmail.com>
501
502 * w32fns.c (w32_default_color_map): New function,
503 extracted from Fw32_default_color_map.
a7ef684b 504 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 505
fe0055fa
PE
5062011-10-25 Paul Eggert <eggert@cs.ucla.edu>
507
508 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
509
e6346438
SM
5102011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
511
512 * keyboard.c (test_undefined): New function (bug#9751).
513 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
514
e112cc37
ET
5152011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
516
517 * sysdep.c (init_sys_modes): Fix the check for the controlling
518 terminal (Bug#6649).
519
7b5d6677
EZ
5202011-10-20 Eli Zaretskii <eliz@gnu.org>
521
522 * dispextern.h (struct bidi_it): New member next_en_type.
523
524 * bidi.c (bidi_line_init): Initialize the next_en_type member.
525 (bidi_resolve_explicit_1): When next_en_pos is valid for the
526 current character, check also for next_en_type being WEAK_EN.
527 (bidi_resolve_weak): Don't enter the expensive loop if the current
528 position is before next_en_pos. Record the bidi type of the first
529 non-ET, non-BN character we find, in addition to its position.
530 (bidi_level_of_next_char): Invalidate next_en_type when
531 next_en_pos is over-stepped.
532
7da0b018
PE
5332011-10-20 Paul Eggert <eggert@cs.ucla.edu>
534
535 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
536 * editfns.c: Rewrite current-time-zone so that it invokes
537 the equivalent of (format-time-string "%Z") to get the time zone name.
538 This fixes a bug when the time zone name contains characters that
539 need converting from the system time locale to Emacs internal format.
540 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
541 that patch fixed format-time-string to do the conversion, but
542 I forgot to fix current-time-zone.
543 (format_time_string): New function, containing most of
544 what Fformat_time_string used to contain.
545 (Fformat_time_string): Rewrite in terms of format_time_string.
546 This doesn't change this function's behavior.
547 (current-time-zone): Rewrite to use format_time_string.
548 This fixes the bug reported by Michael Schierl in
549 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
550 Jason Rumney's 2007-06-07 change worked around this bug, but
551 didn't fix it.
552 * systime.h (tzname, timezone): Remove no-longer-used declarations.
553
8547b010
EZ
5542011-10-19 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (start_display): If the character at POS is displayed
557 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
558 (try_window_reusing_current_matrix): If a line ends in a display
559 vector or the next line starts in a display vector, continue
560 redrawing the window even though the character position of
561 start_row was reached.
8547b010
EZ
562 (Bug#9771, part 2)
563
4e948d15
CY
5642011-10-18 Chong Yidong <cyd@gnu.org>
565
566 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
567 with nobreak-char-display too.
568
4787455f
EZ
5692011-10-18 Eli Zaretskii <eliz@gnu.org>
570
571 Fix part 3 of bug#9771.
572 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
573 (bidi_resolve_neutral): Don't enter the expensive loop looking for
574 non-neutral characters if the current character is a paragraph
575 separator (a.k.a. Newline). This avoids running the same
576 expensive loop twice, once when we consume the preceding newline
577 and the other time when the line actually needs to be displayed.
578 Avoid the loop when we see neutrals on the base embedding level
579 following a character whose directionality is the same as the
580 paragraph's. This avoids running the expensive loop when a line
581 ends in a long sequence of neutrals, like control characters.
582 Add assertion against STRONG_AL type. Slightly rearrange code
583 that determines the type of a neutral given the first non-neutral
584 that follows it.
585 (bidi_level_of_next_char): Set next_en_pos to zero when
586 invalidating its info.
587
2c91f553
EZ
5882011-10-17 Eli Zaretskii <eliz@gnu.org>
589
590 * xdisp.c (push_display_prop): Determine whether to record string
591 or buffer position by IT->string, not by IT->method. Allow
592 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
593 (move_it_vertically_backward): Don't look for character position
594 immediately after the newline when in a continuation line.
595 (Bug#9771, part 1)
2c91f553 596
c7b08b0d
MR
5972011-10-15 Martin Rudalics <rudalics@gmx.at>
598
599 * window.c (coordinates_in_window): Rewrite and delabelize
600 vertical border check. (Bug#5357) (Bug#9618)
601
6b02f655
SM
6022011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
603
604 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
605 errors in XSetWindowBorder (bug#9310).
606
81d40c92
DA
6072011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
608
609 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
610 avoid crash when xmalloc overrun checking is enabled.
611
d4172c3b
EZ
6122011-10-13 Eli Zaretskii <eliz@gnu.org>
613
614 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
615 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
616 cursor motion with <left> and <right> arrow keys.
617
618 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
619 some callers set that themselves.
620
b00eea75
EZ
6212011-10-12 Eli Zaretskii <eliz@gnu.org>
622
623 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
624 display string and the previous row comes from the same string and
625 is empty. (Bug#9739) (Bug#9738)
626
8fe012c4
SM
6272011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
628
629 * doc.c (get_doc_string): Encode file name (bug#9735).
630
0074aef2
EZ
6312011-10-12 Eli Zaretskii <eliz@gnu.org>
632
79beb178
EZ
633 * bidi.c (bidi_level_of_next_char):
634 * xdisp.c (get_visually_first_element): Remove old incorrect
635 comments regarding the Unicode Line Separator character.
636
0074aef2
EZ
637 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
638
6e4b3fbe
DA
6392011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
640
641 * alloc.c (Fgc_status): Do not access beyond zombies array
642 boundary if nzombies > MAX_ZOMBIES.
643 * alloc.c (dump_zombies): Add missing format specifier.
644
0324f3af
PE
6452011-10-12 Paul Eggert <eggert@cs.ucla.edu>
646
b5525cac
PE
647 * xdisp.c (set_cursor_from_row): Simplify conditionals,
648 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
649
0324f3af
PE
650 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
651 Some packages use them to denote characters with modifiers.
652
e9b5f888
AS
6532011-10-11 Andreas Schwab <schwab@linux-m68k.org>
654
655 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
656 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
657 matching a pp-number. Rename parameter var to var1.
658
127827c0
SM
6592011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
660
661 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
662
c8fd3bd0
GM
6632011-10-08 Glenn Morris <rgm@gnu.org>
664
665 * callint.c (Fcall_interactively): Give a more explicit error for the
666 'c' case with a non-character input. (Bug#8479)
667
352ec8ff
EZ
6682011-10-08 Eli Zaretskii <eliz@gnu.org>
669
03669ccb
EZ
670 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
671 lines.
7061c986
EZ
672 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
673 lines that are hscrolled on the left.
03669ccb 674
352ec8ff
EZ
675 * dispnew.c (buffer_posn_from_coords): Account for a possible
676 presence of header-line. (Bug#4426)
677
a66cfb1c
SM
6782011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
679
6b02f655
SM
680 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
681 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 682
7c5ee88e
PE
6832011-10-07 Paul Eggert <eggert@cs.ucla.edu>
684
685 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
686 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
687 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
688 this makes Emacs dump core during garbage collection on rare
689 occasions. sizeof is obviously inferior to offsetof here, so
690 stick with offsetof.
691 (GC_POINTER_ALIGNMENT): New macro.
692 (mark_memory): Omit 3rd (offset) arg; caller changed.
693 Don't assume EMACS_INT alignment is the same as pointer alignment.
694
df1bbe5b
SM
6952011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
696
697 * keyboard.c (read_key_sequence_remapped): New var.
698 (read_key_sequence): Compute remapping in the right buffer.
699 (command_loop_1): Use read_key_sequence's remapping directly.
700
51553db6
SM
7012011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
702
32c1fffd
SM
703 * dired.c (file_name_completion): Don't expand file name.
704 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
705 before checking file name handler.
706
51553db6
SM
707 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
708 they've been requested explicitly (bug#9591).
709
b6bd1599 7102011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
711
712 * keymap.c (Fsingle_key_description): Use make_specified_string
713 instead of build_string to build string from push_key_description.
714 (Bug#5193)
715
f701dc2a
PE
7162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
717
4222c55d
PE
718 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
719 This fixes a Y2038 bug on 64-bit hosts.
720 * buffer.c (reset_buffer):
721 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
722 (Fclear_buffer_auto_save_failure):
723 Use 0, not -1, to represent an unset failure time, since time_t
724 might not be signed.
725
f701dc2a
PE
726 Remove dependency on glibc malloc internals.
727 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
728 Move back here from lisp.h, but with their new implementations.
729 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
730 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
731 * charset.c (charset_table_init): New static var.
732 (syms_of_charset): Use it instead of xmalloc. This removes a
733 dependency on glibc malloc internals. See Eli Zaretskii's comment in
734 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
735 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
736 Move back to alloc.c.
737 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
738 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
739
9ceebf39
JD
7402011-09-30 Jan Djärv <jan.h.d@swipnet.se>
741
742 * nsterm.m (windowDidResize): Call x_set_window_size only when
743 ns_in_resize is true. Otherwise set pixelwidth/height and
744 call change_frame_size (Bug#9628).
745
cb993c58
PE
7462011-09-30 Paul Eggert <eggert@cs.ucla.edu>
747
3930c88b
PE
748 Port --enable-checking=all to Fedora 14 x86-64.
749 * charset.c (syms_of_charset): Also account for glibc malloc's
750 internal overhead when calculating the initial malloc maximum.
751
cb993c58
PE
752 Port --enable-checking=all to Fedora 14 x86.
753 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
754 Move to lisp.h.
755 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
756 (overrun_check_realloc, overrun_check_free):
757 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
758 That way, xmalloc returns a properly-aligned pointer even if
759 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
760 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
761 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
762 into account when calculating the initial malloc maximum.
763 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
764 Move here from alloc.c, so that charset.c can use it too.
765 Properly align; the old code wasn't right for common 32-bit hosts
766 when configured with --enable-checking=all.
767 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
768 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
769
31bed486
EZ
7702011-09-29 Eli Zaretskii <eliz@gnu.org>
771
04c70788 772 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
773 use EDOM.
774
fbcaa2f3
EZ
7752011-09-28 Eli Zaretskii <eliz@gnu.org>
776
777 * xdisp.c (compute_display_string_end): If there's no display
778 string at CHARPOS, return -1.
779
780 * bidi.c (bidi_fetch_char): When compute_display_string_end
781 returns a negative value, treat the character as a normal
782 character not covered by a display string. (Bug#9624)
783
a239d4e9
JB
7842011-09-28 Juanma Barranquero <lekktu@gmail.com>
785
786 * lread.c (Fread_from_string): Fix typo in docstring.
787
88652fd5
EZ
7882011-09-27 Eli Zaretskii <eliz@gnu.org>
789
790 * xdisp.c (handle_invisible_prop): If invisible text ends on a
791 newline, reseat the iterator instead of bidi-iterating there one
792 character at a time. (Bug#9610)
32c1fffd
SM
793 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
794 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 795
ed497dd4
AS
7962011-09-27 Andreas Schwab <schwab@linux-m68k.org>
797
798 * lread.c (readevalloop): Use correct code for NBSP.
799 (read1): Likewise. (Bug#9608)
800
b2bf61aa
MA
8012011-09-25 Michael Albinus <michael.albinus@gmx.de>
802
803 * dbusbind.c (Fdbus_register_signal): When service is not
804 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
805
32bbb17c
GM
8062011-09-25 Glenn Morris <rgm@gnu.org>
807
808 * buffer.c (truncate-lines): Doc fix.
809
94e0933e
CY
8102011-09-24 Chong Yidong <cyd@stupidchicken.com>
811
812 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
813 (Fset_window_next_buffers): Doc fix.
814
cddde921
GM
8152011-09-24 Glenn Morris <rgm@gnu.org>
816
817 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
818
1260aef1
PE
8192011-09-24 Paul Eggert <eggert@cs.ucla.edu>
820
25b4bfa0
PE
821 Fix minor problems found by static checking.
822 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
823 * indent.c (Fvertical_motion): Fix == vs = typo.
824
e3cbd34b
EZ
8252011-09-24 Eli Zaretskii <eliz@gnu.org>
826
a66cfb1c
SM
827 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
828 Default value is now t. Doc fix.
6bf7006f 829
e3cbd34b 830 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 831 logic when moving up, not only when moving down. Fix the
e3cbd34b 832 confusing name and values of the it_overshoot_expected variable;
32c1fffd 833 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
834
835 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
836 CHARPOS is covered by a display string which includes newlines.
837 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
838 is covered by a display string with embedded newlines.
839
a3de0cbd
MA
8402011-09-24 Michael Albinus <michael.albinus@gmx.de>
841
842 * dbusbind.c (Fdbus_register_signal): Add match rule to
843 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
844 (Fdbus_register_method, Vdbus_registered_objects_table):
845 Fix docstring.
a3de0cbd 846
b260039d
JM
8472011-09-24 Jim Meyering <meyering@redhat.com>
848
32c1fffd 849 do not ignore write error for any output size
b260039d
JM
850 The previous change was incomplete.
851 While it makes emacs --batch detect the vast majority of stdout
852 write failures, errors were still ignored whenever the output size is
853 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
854 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
855 && echo FAIL: ignored write error
856 FAIL: ignored write error
857 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
858 && echo FAIL: ignored write error
859 FAIL: ignored write error
860 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
861
8eca8a7c
AS
8622011-09-23 Andreas Schwab <schwab@linux-m68k.org>
863
864 * emacs.c (Fkill_emacs): In noninteractive mode exit
865 non-successfully if a write error occurred on stdout. (Bug#9574)
866
3341db62
EZ
8672011-09-21 Eli Zaretskii <eliz@gnu.org>
868
869 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
870 the xassert test.
871
872 * dispextern.h (struct it): Update the comment documenting what
873 can it->OBJECT be.
874
8c203dbf
EZ
8752011-09-20 Eli Zaretskii <eliz@gnu.org>
876
877 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
878 a display string, extend search for cursor position to end of row.
879 (find_row_edges): If the row ends in a newline from a display
880 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
881 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
882 (Fcurrent_bidi_paragraph_direction): Fix search for previous
883 non-empty line. Fixes confusing cursor motion with arrow keys at
884 the beginning of a line that starts with whitespace.
8c203dbf 885
a4824228
LMI
8862011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
887
888 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
889 (bug#9493).
890
33ed493b
CY
8912011-09-18 Chong Yidong <cyd@stupidchicken.com>
892
893 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
894 boolean (Bug#9154).
895
56cd55c8
EZ
8962011-09-18 Eli Zaretskii <eliz@gnu.org>
897
898 * xdisp.c (display_line): Record maximum and minimum buffer
899 positions even if no glyphs were produced (e.g., by a zero-width
900 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
901 buffer positions that will be removed from the glyph row because
902 they don't fit.
c02dcedf
EZ
903 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
904 column is beyond frame width: don't subtract 1 "pixel" when
905 computing width of the stretch.
3e62b7e0
EZ
906 (reseat_at_next_visible_line_start): Undo the change made on
907 2011-09-17 that saved paragraph information and restored it after
908 the call to `reseat'. (Bug#9545)
56cd55c8 909
5ed99d36 9102011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
911
912 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
913 and turn window cursor on if cleared (Bug#9415).
914
5ed99d36 9152011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
916
917 * search.c (boyer_moore): Take unibyte characters from pattern
918 literally. (Bug#9458)
919
9bade7b2
EZ
9202011-09-18 Eli Zaretskii <eliz@gnu.org>
921
922 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
923
e5e9d610
PE
9242011-09-18 Paul Eggert <eggert@cs.ucla.edu>
925
87e4427a
PE
926 Fix minor problem found by static checking.
927 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
928 initialized, to pacify gcc -Wuninitialized.
929
e5e9d610
PE
930 * fileio.c: Report proper errno when syscall falls.
931 (Finsert_file_contents): Save and restore errno,
932 so that report_file_error outputs the correct diagnostic.
933 (Fwrite_region) [CLASH_DETECTION]: Likewise.
934
a1674f0b
EZ
9352011-09-18 Eli Zaretskii <eliz@gnu.org>
936
937 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
938
fbfb6dd4
EZ
9392011-09-17 Eli Zaretskii <eliz@gnu.org>
940
941 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
942 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
943
bb187662
EZ
9442011-09-17 Eli Zaretskii <eliz@gnu.org>
945
1137e8b8 946 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 947 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
948
949 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
950 (bidi_find_paragraph_start): Search back for paragraph beginning
951 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
952 (bidi_move_to_visually_next): Only trigger paragraph-related
953 computations when the last character is a newline or at EOB, not
954 just any NEUTRAL_B. (Bug#9470)
955
bb187662
EZ
956 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
957 truncated lines if point is covered by a display string. (Bug#9524)
958
2e621251
PE
9592011-09-16 Paul Eggert <eggert@cs.ucla.edu>
960
961 * xselect.c: Relax test for outgoing X longs (Bug#9498).
962 (cons_to_x_long): New function.
963 (lisp_data_to_selection_data): Use it. Correct the test for
964 short-versus-long data; it was negated. Break out of vector
965 loop, for efficiency, when a long datum is discovered.
966
91a15bc6
SM
9672011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
968
969 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
970
b41c3a35
EZ
9712011-09-16 Eli Zaretskii <eliz@gnu.org>
972
973 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
974 GCC PR/17406) by declaring this function with external scope.
975
7812ba2d
PE
9762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
977
978 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
979 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
980
cf7edc2a
AS
9812011-09-15 Andreas Schwab <schwab@linux-m68k.org>
982
983 * editfns.c (Fformat): Correctly handle text properties on "%%".
984
bd01620e
EZ
9852011-09-15 Eli Zaretskii <eliz@gnu.org>
986
987 * xterm.c (x_draw_composite_glyph_string_foreground):
988 * w32term.c (x_draw_composite_glyph_string_foreground):
989 * term.c (encode_terminal_code):
990 * composite.c (composition_update_it, get_composition_id):
991 * xdisp.c (get_next_display_element)
992 (fill_composite_glyph_string): Add comments about special meaning
993 of TAB characters in a composition.
994
a02719a3
PE
9952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
996
997 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
998 This occurs when processing a multibyte format.
999 Problem reported by Wolfgang Jenker.
a02719a3 1000
72589a3c
JB
10012011-09-15 Johan Bockgård <bojohan@gnu.org>
1002
1003 * xdisp.c (try_cursor_movement): Only check for exact match if
1004 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1005
1c14176c
PE
10062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 Remove unused external symbols.
1009 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1010 * xdisp.c (calc_pixel_width_or_height): Now static.
1011 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1012 * indent.c (check_display_width):
1013 * w32term.c: Fix comment to match code.
1014 * xterm.c, xterm.h (x_catching_errors): Remove.
1015
d2eea5b5
PE
10162011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * xselect.c: Use signed conversions more consistently (Bug#9498).
1019 (selection_data_to_lisp_data): Assume incoming selection data are
1020 signed integers, not unsigned. This is to be consistent with
1021 outgoing selection data, which was modified to use signed integers
1022 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1023 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1024 expects long, not unsigned long.
1025
46888499
EZ
10262011-09-14 Eli Zaretskii <eliz@gnu.org>
1027
1028 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1029 computation of loop end. Reported by Johan Bockgård
1030 <bojohan@gnu.org>.
1031
ef8ef9fb
CY
10322011-09-13 Chong Yidong <cyd@stupidchicken.com>
1033
1034 * frame.c (Fother_visible_frames_p): Function deleted.
1035
fa819fed
EZ
10362011-09-12 Eli Zaretskii <eliz@gnu.org>
1037
1038 * indent.c (compute_motion): Process display vector front to back
1039 rather than the other way around. (Bug#2496)
1040
2ba8e008
SM
10412011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1042
1043 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1044
20f53c69
CY
10452011-09-11 Chong Yidong <cyd@stupidchicken.com>
1046
1047 * minibuf.c (Fread_from_minibuffer): Doc fix.
1048
d562d7a4
EZ
10492011-09-11 Eli Zaretskii <eliz@gnu.org>
1050
1051 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1052 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1053
1c4d7f3d
LMI
10542011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1055
1056 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1057 value for non-existent files.
1058
b885bf36
EZ
10592011-09-11 Eli Zaretskii <eliz@gnu.org>
1060
1061 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1062 set its "size" to -1. This will set the modtime_size field of
1063 the corresponding buffer to -1, which is what
1064 verify-visited-file-modtime expects for files that do not exist.
1065 (Bug#9139)
1066
6612f0bf
PE
10672011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1070 here ...
1071 * lisp.h: ... from here. push_key_description is no longer
1072 defined in keyboard.c, so its declaration should not be in
1073 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1074 logically belongs with push_key_description.
1075
dfb3f755
PE
10762011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 * buffer.h: Include <sys/types.h> instead of <time.h>.
1079 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1080 Problem reported by Herbert J. Skuhra.
1081
3134906c
LMI
10822011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1083
1084 * xml.c (parse_region): Make the parsing work for
1085 non-comment-starting XML files again (bug#9144).
1086
8d903f4e
AS
10872011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1088
1089 * image.c (gif_load): Fix calculation of bottom and right corner.
1090 (Bug#9468)
1091
80ad64f4
EZ
10922011-09-10 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1095 redisplay in small windows.
1096
208a048d
EZ
10972011-09-09 Eli Zaretskii <eliz@gnu.org>
1098
1099 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1100
9b1c252e
MR
11012011-09-08 Martin Rudalics <rudalics@gmx.at>
1102
1103 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1104 Operate on live windows only.
1105
2949f33b
JB
11062011-09-08 Juanma Barranquero <lekktu@gmail.com>
1107
1108 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1109
e08dcafd
EZ
11102011-09-07 Eli Zaretskii <eliz@gnu.org>
1111
1112 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1113 only under bidi iteration.
1114
115b96bd
JD
11152011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1116
1117 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1118
c8199d0f
PE
11192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1122 Without this fix, the command to link temacs failed due to an
1123 undefined symbol __builtin_isnan. This is because
1124 /usr/include/iso/math_c99.h #defines isnan(x) to
1125 __builtin_isnan(x), but the bundled gcc, which identifies itself
1126 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1127 a __builtin_isnan.
1128 * floatfns.c (isnan): #undef, and then #define to a clone of
1129 what's in data.c.
1130 (Fisnan): Always define, since it's always available now.
1131 (syms_of_floatfns): Always define isnan at the Lisp level.
1132
e39b275c 11332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1134
1135 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1136
b2db44d9 11372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1138
f4af5137 1139 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1140 The previous code assumed that file offsets (off_t values) fit in
1141 EMACS_INT variables, which is not true on typical 32-bit hosts.
1142 The code messed up by falsely reporting buffer overflow in cases
1143 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1144 when "big" contains more than 2**29 bytes, even though this
1145 inserts just one byte and does not overflow the buffer.
1146 (Finsert_file_contents): Store file offsets as off_t
1147 values, not as EMACS_INT values. Check for overflow when
1148 converting between EMACS_INT and off_t. When checking for
1149 buffer overflow or for overlap, take the offsets into account.
1150 Don't use EMACS_INT for small values where int suffices.
1151 When checking for overlap, fix a typo: ZV was used where
1152 ZV_BYTE was intended.
1153 (Fwrite_region): Don't assume off_t fits into 'long'.
1154 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1155
ecfc0a49
MA
11562011-09-05 Michael Albinus <michael.albinus@gmx.de>
1157
1158 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1159
6511acf2 11602011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1161
0999621a 1162 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1163
1164 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1165 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1166 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1167 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1168 (modify_event_symbol): Do not assume that the length of
1169 name_alist_or_stem is safe to alloca and fits in int.
1170 (Fexecute_extended_command): Likewise for function name and binding.
1171 (Frecursion_depth): Wrap around reliably on integer overflow.
1172 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1173 since some callers pass EMACS_INT values.
1174 (Fsingle_key_description): Don't crash if symbol name contains more
1175 than MAX_ALLOCA bytes.
1176 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1177 (get_minibuffer): Arg is now EMACS_INT, not int.
1178 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1179 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1180 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1181
2be7d702
PE
1182 * dbusbind.c (signature_cat): New function.
1183 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1184 Do not overrun buffer; instead, report string overflow.
1185
9d1df220
PE
1186 * dispnew.c (add_window_display_history): Don't overrun buffer.
1187 Truncate instead; this is OK since it's just a log.
1188
33ef5c64
PE
1189 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1190 even if the time zone offset is outlandishly large.
1191 Don't mishandle offset == INT_MIN.
1192
66c6fdd5
PE
1193 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1194 when creating daemon; the previous buffer-overflow check was incorrect.
1195
d749b01b
PE
1196 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1197 which has the guts of the old verror function.
1198
b5cd1905
PE
1199 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1200 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1201
6e1a67fb
PE
1202 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1203 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1204 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1205 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1206 length of string rather than counting it via multiple sprintfs;
1207 that's simpler and more reliable.
c21721cc
PE
1208 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1209 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1210 sprintf, in case result does not fit in int.
1211
c57b67fc
PE
1212 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1213 (fontset_from_font): Print it.
1214
8a401434
PE
1215 * frame.c (tty_frame_count): Now printmax_t, not int.
1216 (make_terminal_frame, set_term_frame_name): Print it.
1217 (x_report_frame_params): In X, window IDs are unsigned long,
1218 not signed long, so print them as unsigned.
1219 (validate_x_resource_name): Check for implausibly long names,
1220 and don't assume name length fits in 'int'.
1221 (x_get_resource_string): Don't blindly alloca invocation name;
1222 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1223 not fit in int.
1224
6e1a67fb
PE
1225 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1226 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1227 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1228
0df02bf3
PE
1229 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1230 Use esprintf, not sprintf, in case result does not fit in int.
1231
48e30793
PE
1232 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1233 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1234 it as a large positive number.
1235 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1236 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1237
a66ff6d8
PE
1238 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1239 in case result does not fit in int.
1240
aca216ff
PE
1241 * print.c (float_to_string): Detect width overflow more reliably.
1242 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1243 buffer overrun. Don't assume list length fits in 'int'. Treat
1244 print length of 0 as 0, not as infinity; to be consistent with other
1245 uses of print length in this function. Don't overflow print length
1246 index. Don't assume hash table size fits in 'long', or that
1247 vectorlike size fits in 'unsigned long'.
1248
31c286f7
PE
1249 * process.c (make_process): Use printmax_t, not int, to format
1250 process-name gensyms.
1251
55e5faa1
PE
1252 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1253
80f2e268
PE
1254 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1255 to avoid potential buffer overrun.
1256
670741ab
PE
1257 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1258 if X resource line is longer than 512 bytes.
1259
b7163a50
PE
1260 * xfns.c (x_window): Make sprintf buffer a bit bigger
1261 to avoid potential buffer overrun.
1262
ae58ff1f
PE
1263 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1264
c43c8a6a
PE
1265 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1266
3f8236f4
PE
12672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1268
53e9fe90 1269 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1270 Without these, Emacs silently mishandles large integers sometimes.
1271 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1272 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1273
6511acf2
PE
1274 * xdisp.c (try_window_id): Check Emacs fixnum range before
1275 converting to 'int'.
806add1d 1276
6511acf2 1277 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1278 Check that an Emacs fixnum is in range before assigning it to 'int'.
1279 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1280 values converted from Emacs fixnums.
1281 (Frecenter): Don't wrap around a line count if it is out of 'int'
1282 range; instead, treat it as an extreme value.
1283 (Fset_window_configuration, compare_window_configurations):
1284 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1285
6511acf2
PE
1286 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1287 that can exceed INT_MAX. Check that EMACS_INT value is in range
1288 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1289 (match_limit): Don't assume that a fixnum can fit in 'int'.
1290
6511acf2 1291 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1292 exceed INT_MAX.
1293
6511acf2 1294 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1295 (Fvertical_motion): Don't wrap around LINES values that don't fit
1296 in 'int'. Instead, treat them as extreme values. This is good
1297 enough for windows, which can't have more than INT_MAX lines anyway.
1298
fcb901a7
LMI
12992011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1300
0f2f6b6d
LMI
1301 * Require libxml/parser.h to avoid compilation warning.
1302
fcb901a7
LMI
1303 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1304
1305 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1306 since this reportedly can destroy thread storage.
1307
6e20a0d4
CY
13082011-08-30 Chong Yidong <cyd@stupidchicken.com>
1309
1310 * syntax.c (find_defun_start): Update all cache variables if
1311 exiting early (Bug#9401).
1312
148ae00e
EZ
13132011-08-30 Eli Zaretskii <eliz@gnu.org>
1314
f6cfbd8f
EZ
1315 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1316
148ae00e
EZ
1317 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1318 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1319 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1320
1321 * term.c (tty_append_glyph): New function.
1322 (produce_stretch_glyph): Static function and its prototype deleted.
1323
a66cfb1c
SM
1324 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1325 Add prototypes.
148ae00e 1326
c4a07a4c
PE
13272011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1330 when checking :margin (Bug#9390).
1331 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1332 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1333 so that the name doesn't mislead. All uses changed.
1334
6bc8cd65
JB
13352011-08-28 Johan Bockgård <bojohan@gnu.org>
1336
1337 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1338 set_tty_hooks.
1339
dca4927e
EZ
13402011-08-27 Eli Zaretskii <eliz@gnu.org>
1341
1342 * xdisp.c (move_it_to): Don't bail out early when reaching
1343 position beyond to_charpos, if we are scanning backwards.
1344 (move_it_vertically_backward): When DY == 0, make sure we get to
1345 the first character in the line after the newline.
1346
f2cad773
PE
13472011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1350 (ccl_driver): Do not generate an out-of-range pointer.
1351 (Fccl_execute_on_string): Remove unnecessary check for
1352 integer overflow, noted by Stefan Monnier in
1353 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1354 Remove a FIXME that didn't need fixing.
1355 Simplify the newly-introduced buffer reallocation code.
1356
0cae2cdb
JB
13572011-08-27 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1360
5fc295a4 13612011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1362
70c60eb2 1363 Integer and memory overflow issues (Bug#9196).
726e0ab1 1364
d31850da
PE
1365 * doc.c (get_doc_string): Rework so that
1366 get_doc_string_buffer_size is the actual buffer size, rather than
1367 being 1 less than the actual buffer size; this makes xpalloc more
1368 convenient.
1369
a69fbedb
PE
1370 * image.c (x_allocate_bitmap_record, cache_image):
1371 * xselect.c (Fx_register_dnd_atom):
1372 Simplify previous changes by using xpalloc.
1373
fe5c5d37
PE
1374 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1375 since either will do and ptrdiff_t is convenient with xpalloc.
1376
0065d054
PE
1377 * charset.c (charset_table_size)
1378 (struct charset_sort_data.priority): Now ptrdiff_t.
1379 (charset_compare): Don't overflow if priorities differ greatly.
1380 (Fsort_charsets): Don't assume list length fits in int.
1381 Check for size-calculation overflow when allocating sort data.
1382 (syms_of_charset): Allocate an initial charset table that is
1383 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1384
1385 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1386
1387 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1388 The actual value is always <= INT_MAX, and leaving it unsigned made
1389 overflow checking harder.
1390
1391 * dispextern.h (struct glyph_matrix.rows_allocated)
1392 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1393 with xpalloc. The values are still always <= INT_MAX.
1394
1395 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1396
1397 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1398 (SAFE_NALLOCA): New macro.
1399
1400 * region-cache.c (struct boundary.pos, find_cache_boundary)
1401 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1402 (set_cache_region, invalidate_region_cache)
1403 (revalidate_region_cache, know_region_cache, region_cache_forward)
1404 (region_cache_backward, pp_cache):
1405 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1406 so that ptrdiff_t * can be passed to xpalloc.
1407 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1408 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1409 (pp_cache): Don't assume cache_len fits in int.
1410 * region-cache.h: Adjust extern decls to match.
1411
1412 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1413 EMACS_INT, since either will do, for xpalloc.
1414
1415 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1416 (xnmalloc, xnrealloc, xpalloc): New functions.
1417
726e0ab1
PE
1418 * bidi.c (bidi_shelve_header_size): New constant.
1419 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1420 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1421
51f30bc5 1422 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1423 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1424 (overlay_strings):
1425 Don't update size of array until after memory allocation succeeds,
1426 because xmalloc/xrealloc may not return.
0065d054
PE
1427 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1428 now that we have proper integer overflow checking.
1429 (record_overlay_string, overlay_strings): Catch overflows when
1430 calculating size of overlay_str_buf.
726e0ab1 1431
0065d054
PE
1432 * callproc.c (Fcall_process): Check for size overflow when
1433 calculating size of args2.
1434 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1435 Normally we prefer signed values, but sticking with ptrdiff_t would
1436 require adding more-complicated checks.
726e0ab1
PE
1437
1438 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1439 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1440 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1441 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1442
1443 * character.c (Fstring): Check for size-calculation overflow.
1444
1445 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1446 unnecessary integer overflow. Check for size overflow.
1447 (encode_coding_object): Don't update size until xmalloc succeeds.
1448
1449 * composite.c (get_composition_id): Check for overflow in glyph
1450 length calculations.
1451
1452 Integer and memory overflow fixes for display code.
1453 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1454 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1455 (scrolling_window): Check for overflow in size calculations.
1456 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1457 Don't assume glyph table len fits in int.
1458 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1459 (row_table_size): Now ptrdiff_t, not int.
1460 (scrolling_window): Avoid overflow in size calculations.
1461 Don't update size until allocation succeeds.
1462 * fns.c (concat): Check for overflow in size calculations.
1463 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1464 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1465 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1466
1467 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1468 (get_doc_string): Check for size calculation overflow.
1469 Don't update size until allocation succeeds.
1470 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1471 EMACS_INT, where ptrdiff_t will do.
1472 (Fsubstitute_command_keys): Check for string overflow.
1473
1474 * editfns.c (set_time_zone_rule): Don't assume environment length
1475 fits in int.
1476 (message_length): Now ptrdiff_t, not int.
1477 (Fmessage_box): Don't update size until allocation succeeds.
1478 Don't assume message length fits in int.
1479 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1480
0065d054
PE
1481 * emacs.c (main): Do not reallocate argv, since there is a null at
1482 the end that can be overwritten, and this way there's no need to
1483 worry about size-calculation overflow.
1484 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1485
1486 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1487 alloc succeeds.
1488 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1489
1490 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1491 (x_set_scroll_bar_width, x_figure_window_size):
1492 Check for integer overflow.
1493 (x_set_alpha): Do not assume XINT fits in int.
1494
1495 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1496 This is for the members text_lines, text_cols, total_lines, total_cols,
1497 where the system imposes an 'int' limit.
1498
1499 * fringe.c (Fdefine_fringe_bitmap):
1500 Don't update size until alloc works.
1501
1502 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1503 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1504
1505 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1506 Check for size-calculation overflow.
1507 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1508 do, as we prefer signed integers.
1509 (id_to_widget.max_size, id_to_widget.used)
1510 (xg_store_widget_in_map, xg_remove_widget_from_map)
1511 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1512 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1513 Use and return ptrdiff_t, not int.
1514 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1515 * gtkutil.h: Change prototypes to match the above.
1516
1517 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1518 are duplicate now that they've been promoted to lisp.h.
1519 (x_allocate_bitmap_record, x_alloc_image_color)
1520 (make_image_cache, cache_image, xpm_load):
1521 Don't update size until alloc is done.
1522 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1523 (x_detect_edges):
3256efce 1524 Check for size calculation overflow.
726e0ab1
PE
1525 (ct_colors_allocated_max): New constant.
1526 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1527 overflow.
3256efce 1528
726e0ab1
PE
1529 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1530 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1531 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1532 Use ptrdiff_t, not int, to count maps.
1533 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1534 calculations. Don't update size until allocation succeeds.
1535 Redo calculations to avoid overflow.
726e0ab1
PE
1536 * keyboard.h: Change prototypes to match the above.
1537
1538 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1539 to count maps.
1540 (current_minor_maps): Check for size calculation overflow.
1541 * keymap.h: Change prototypes to match the above.
1542
1543 * lread.c (read1, init_obarray): Don't update size until alloc done.
1544
1545 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1546 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1547
726e0ab1
PE
1548 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1549 Now ptrdiff_t, not int.
1550 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1551 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1552
1553 * process.c (Fnetwork_interface_list): Check for overflow
1554 in size calculation.
1555
1556 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1557
1558 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1559 overflow. Don't bother calling xmalloc when xrealloc will do.
1560
1561 * search.c (Freplace_match): Check for size calculation overflow.
1562 (Fset_match_data): Don't assume list lengths fit in 'int'.
1563
1564 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1565 for command line length. Do not attempt to address one before the
1566 beginning of an array, as that's not portable.
1567
1568 * term.c (max_frame_lines): Remove; unused.
1569 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1570 not int.
1571 (encode_terminal_code, calculate_costs): Check for size
1572 calculation overflow.
1573 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1574 table lengths and related sizes. Don't update size until alloc
1575 done. Redo calculations to avoid overflow.
1576 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1577
1578 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1579 subtracting pointers.
1580 (gobble_line): Check for overflow more carefully. Don't update size
1581 until alloc done.
1582
1583 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1584 Don't update size until alloc done.
1585 Redo size calculations to avoid overflow.
1586 Check for size calculation overflow.
0065d054 1587 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1588
1589 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1590 Use ptrdiff_t, not int, for sizes.
1591 (store_mode_line_noprop_char): Don't update size until alloc done.
1592
0065d054
PE
1593 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1594 Use ptrdiff_t, not int, for sizes.
1595 (Finternal_make_lisp_face, cache_face):
1596 Check for size calculation overflow.
1597 (cache_face): Treat size calculation overflows as if they were
1598 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1599
1600 * xfns.c (x_encode_text, x_set_name_internal)
1601 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1602 sizes, since they can exceed INT_MAX in size. Check for size
1603 calculation overflow.
1604
0065d054
PE
1605 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1606 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1607 Don't update size until alloc done.
1608
0065d054 1609 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1610 as sprintf is limited to int lengths.
1d526e2f 1611
252c5ee1
PE
1612 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1613 (X_LONG_MIN): New macros.
864d7ce7
PE
1614 Use them to make the following changes clearer.
1615 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1616 This change doesn't affect the value now, but it may help remind
1617 future maintainers not to raise the value too much later.
1618 (SELECTION_QUANTUM): Remove, replacing with ...
1619 (selection_quantum): ... new function, which avoids overflow.
1620 All uses changed.
1621 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1622 assumption that selection length fits in 'int'.
1623 (x_reply_selection_request, x_handle_selection_request)
1624 (x_get_window_property, receive_incremental_selection)
1625 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1626 (lisp_data_to_selection_data, clean_local_selection_data):
1627 Use ptrdiff_t, not int, to record length of selection.
1628 (x_reply_selection_request, x_get_window_property)
1629 (receive_incremental_selection, x_property_data_to_lisp):
1630 Redo calculations to avoid overflow.
1631 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1632 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1633 something.
1634 (x_get_window_property, receive_incremental_selection)
1635 (lisp_data_to_selection_data, x_property_data_to_lisp):
1636 Check for size-calculation overflow.
1637 (x_get_window_property, receive_incremental_selection)
1638 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1639 Don't store size until memory allocation succeeds.
1640 (x_get_window_property): Plug memory leak on memory exhaustion.
1641 Don't double-block input; malloc is safe here. Don't assume 2**34
1642 - 4 fits in unsigned long. Add an xassert to check
1643 XGetWindowProperty overflow. Be more careful about overflow
1644 calculations, and distinguish size from memory overflow better.
1645 (receive_incremental_selection): When tracing, don't assume
1646 unsigned int is less than INT_MAX.
1647 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1648 harmful) conversions of unsigned short to int.
1649 (lisp_data_to_selection_data): Don't assume that integers
1650 in the range -65535 through -1 fit in an X unsigned short.
1651 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1652 result parameters unless successful. Rely on cons_to_unsigned
1653 to report problems with elements; the old code wasn't right anyway.
1654 (x_check_property_data): Check for int overflow; we cannot use
1655 a wider type due to X limits.
1656 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1657
726e0ab1 1658 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1659
0065d054
PE
1660 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1661 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1662 (x_color_cells): Don't store size until memory allocation succeeds.
1663 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1664 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1665 (x_term_init): Don't assume length fits in int (sprintf is limited
1666 to int size).
bc18e09d 1667
ebfa62c0
PE
1668 Use ptrdiff_t for composition IDs.
1669 * character.c (lisp_string_width):
1670 * composite.c (composition_table_size, n_compositions)
1671 (get_composition_id, composition_gstring_from_id):
1672 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1673 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1674 * window.c (Frecenter):
1675 Use ptrdiff_t, not int, for composition IDs.
1676 * composite.c (get_composition_id): Check for integer overflow.
1677 * composite.h: Adjust prototypes to match the above changes.
1678
d3411f89
PE
1679 Use ptrdiff_t for hash table indexes.
1680 * category.c (hash_get_category_set):
1681 * ccl.c (ccl_driver):
1682 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1683 * coding.c (coding_system_charset_list, detect_coding_system):
1684 * coding.h (struct coding_system.id):
1685 * composite.c (get_composition_id, gstring_lookup_cache):
1686 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1687 * image.c (xpm_get_color_table_h):
1688 * lisp.h (hash_lookup, hash_put):
1689 * minibuf.c (Ftest_completion):
1690 Use ptrdiff_t for hash table indexes, not int (which is too
1691 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1692 32-bit --with-wide-int hosts).
1693
e097a6fa
PE
1694 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1695 Add a FIXME comment about memory leaks.
1696 (syms_of_charset): Don't assume xmalloc returns.
1697
5637687f
PE
1698 Don't assume that stated character widths fit in int.
1699 * character.c (Fchar_width, c_string_width, lisp_string_width):
1700 * character.h (CHAR_WIDTH):
1701 * indent.c (MULTIBYTE_BYTES_WIDTH):
1702 Use sanitize_char_width to avoid undefined and/or bad behavior
1703 with outlandish widths.
a66cfb1c 1704 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1705 now that we have two such functions. All uses changed.
1706 (sanitize_char_width): New inline function.
1707
a2271ba2
PE
1708 Don't assume that tab-width fits in int.
1709 * character.h (sanitize_width): New inline function.
1710 (SANE_TAB_WIDTH): New macro.
1711 (ASCII_CHAR_WIDTH): Use it.
1712 * indent.c (sane_tab_width): Remove. All uses replaced by
1713 SANE_TAB_WIDTH (current_buffer).
1714 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1715
18c52557
PE
1716 * fileio.c: Integer overflow issues with file modes.
1717 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1718
caeeedc1
PE
1719 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1720 Remove unreachable code.
1721 (read_hex, load_charset_map_from_file): Check for integer overflow.
1722
50849c52
PE
1723 * xterm.c: don't go over XClientMessageEvent limit
1724 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1725 (x_send_scroll_bar_event): Likewise. Check that the size does not
1726 exceed limits imposed by XClientMessageEvent, as well as the usual
1727 ptrdiff_t and size_t limits.
1728
b13995db
PE
1729 * keyboard.c: Overflow, signedness and related fixes.
1730 (make_lispy_movement): Use same integer type in forward decl
1731 that is used in the definition.
1732 (read_key_sequence, keyremap_step):
1733 Change bufsize argument back to int, undoing my 2011-03-30 change.
1734 We prefer signed types, and int is wide enough here.
1735 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1736 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1737 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1738 length, not size_t. Use ptrdiff_t for index, not int.
1739 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1740 possibility of integer overflow.
1741
13464394
PE
1742 Overflow, signedness and related fixes for images.
1743
1744 * dispextern.h (struct it.stack[0].u.image.image_id)
1745 (struct_it.image_id, struct image.id, struct image_cache.size)
1746 (struct image_cache.used, struct image_cache.ref_count):
1747 * gtkutil.c (update_frame_tool_bar):
1748 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1749 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1750 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1751 * nsmenu.m (update_frame_tool_bar):
1752 * xdisp.c (calc_pixel_width_or_height):
1753 * xfns.c (image_cache_refcount):
1754 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1755 on typical 64-bit hosts.
1756
1757 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1758 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1759 Omit unnecessary casts to int.
1760 (parse_image_spec): Check that integers fall into 'int' range
1761 when the callers expect that.
1762 (image_ascent): Redo ascent calculation to avoid int overflow.
1763 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1764 (lookup_image): Remove unnecessary tests.
1765 (xbm_image_p): Locals are now of int, not EMACS_INT,
1766 since parse_image_check makes sure they fit into int.
1767 (png_load, gif_load, svg_load_image):
1768 Prefer int to unsigned where either will do.
1769 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1770 old tiff_error_handler and tiff_warning_handler.
1771 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1772 stack buffer overflows. It uses only the features of vsnprintf
1773 that are common to both POSIX and native Microsoft.
1774 (tiff_error_handler, tiff_warning_handler): Use it.
1775 (tiff_load, gif_load, imagemagick_load_image):
1776 Don't assume :index value fits in 'int'.
1777 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1778 (imagemagick_load_image): Check that crop parameters fit into
1779 the integer types that MagickCropImage accepts. Don't assume
1780 Vimagemagick_render_type has a nonnegative value. Don't assume
1781 size_t fits in 'long'.
1782 (gs_load): Use printmax_t to print the widest integers possible.
1783 Check for integer overflow when computing image height and width.
1784
c11821d4
EZ
17852011-08-26 Eli Zaretskii <eliz@gnu.org>
1786
1787 * xdisp.c (redisplay_window): Don't force window start if point
1788 will be invisible in the resulting window. (Bug#9324)
1789
0c95fcf7
EZ
17902011-08-25 Eli Zaretskii <eliz@gnu.org>
1791
1792 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1793 the display spec is of the form `(space ...)'.
1794 (handle_display_spec): Return the value returned by
1795 handle_single_display_spec, not just 1 or zero.
1796 (handle_single_display_spec): If the display spec is of the form
1797 `(space ...)', and specifies display in the text area, return 2
1798 rather than 1.
fee65a97 1799 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1800 accurately, and prefer exact match for point under bidi.
1801 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1802
1803 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1804 into disp_prop; all users changed.
1805
1806 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1807 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1808 for the text covered by the display property.
1809
e4ed06f1
CY
18102011-08-25 Chong Yidong <cyd@stupidchicken.com>
1811
1812 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1813 Change return value to nil.
1814 (Frecord_buffer): Delete unused function.
1815
f67cdd7f
EZ
18162011-08-24 Eli Zaretskii <eliz@gnu.org>
1817
5980d4c6
EZ
1818 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1819 buffers, return left-to-right.
8610fe8b
EZ
1820 (set_cursor_from_row): Consider candidate row a win if its glyph
1821 represents a newline and point is on that newline. Fixes cursor
1822 positioning on the newline at EOL of R2L text within L2R
1823 paragraph, and vice versa.
1824 (try_cursor_movement): Check continued rows, in addition to
1825 continuation rows. Fixes unwarranted scroll when point enters a
1826 continued line of R2L text within an L2R paragraph, or vice versa.
1827 (cursor_row_p): Consider the case of point being equal to
1828 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1829 from the end of a short line to the beginning of a continued line
1830 of R2L text within L2R paragraph.
1831 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1832 composed characters.
5980d4c6 1833
f67cdd7f
EZ
1834 * bidi.c (bidi_check_type): Use xassert.
1835 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1836 members.
1837
bca633fb
EZ
18382011-08-23 Eli Zaretskii <eliz@gnu.org>
1839
1840 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1841 a character.
1842
4a5885a7
CY
18432011-08-23 Chong Yidong <cyd@stupidchicken.com>
1844
1845 * nsfont.m (ns_otf_to_script): Fix typo.
1846
0902a04e
KH
18472011-08-22 Kenichi Handa <handa@m17n.org>
1848
1849 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1850 extra slot even if the purpose is char-code-property-table.
1851
1a2e6670
EZ
18522011-08-23 Eli Zaretskii <eliz@gnu.org>
1853
8ddde651
EZ
1854 * xdisp.c (redisplay_window): When computing centering_position,
1855 account for the height of the header line. (Bug#8874)
1856
425cc014
EZ
1857 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1858 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1859 candidate is selected by the mouse, and that candidate has a
1860 composed character under the mouse.
1861
1a2e6670
EZ
1862 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1863 coordinates reported by pos-visible-in-window-p for a composed
1864 character in column zero.
1865
8b76d6f8
SM
18662011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1867
1868 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1869
dac347dd
EZ
18702011-08-22 Eli Zaretskii <eliz@gnu.org>
1871
1872 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1873 consider it a hit if to_charpos is anywhere in the range of the
1874 composed buffer positions.
1875
e013fb34
CY
18762011-08-22 Chong Yidong <cyd@stupidchicken.com>
1877
1878 * image.c (gif_load): Don't assume that each subimage has the same
1879 dimensions as the base image. Handle disposal method that is
1880 "undefined" by the gif spec (Bug#9335).
1881
bd1ba3e8
CY
18822011-08-20 Chong Yidong <cyd@stupidchicken.com>
1883
1884 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1885 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1886
54a1215b
EZ
18872011-08-19 Eli Zaretskii <eliz@gnu.org>
1888
823564e5
EZ
1889 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1890 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1891 from an Org mode buffer to a Speedbar frame.
1892
54a1215b
EZ
1893 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1894 a composition, take its buffer position from IT->cmp_it.charpos.
1895 Fixes cursor positioning at the beginning of a line that begins
1896 with a composed character.
1897
9778ebcc
EZ
18982011-08-18 Eli Zaretskii <eliz@gnu.org>
1899
0be6ee06
EZ
1900 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1901 character bidirectional type, use STRONG_L instead. Fixes crashes
1902 in a buffer produced by `describe-categories'.
1903
9778ebcc
EZ
1904 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1905 members before the level stack, so they would be saved and
1906 restored when copying iterator state. Fixes incorrect reordering
1907 around TABs covered by display properties.
1908
156bffbe
AS
19092011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1910
6b02f655 1911 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1912
72ad093b
CY
19132011-08-17 Chong Yidong <cyd@stupidchicken.com>
1914
1915 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1916 (internal_condition_case_2, internal_condition_case_n):
1917 Remove unnecessary aborts (Bug#9081).
72ad093b 1918
35774242
EZ
19192011-08-17 Eli Zaretskii <eliz@gnu.org>
1920
1921 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1922 has no `load' handler, try opening the file locally. (Bug#9311)
1923
db76dd85
KB
19242011-08-16 Ken Brown <kbrown@cornell.edu>
1925
1926 * gmalloc.c: Expand comment.
1927
b215eee5
EZ
19282011-08-16 Eli Zaretskii <eliz@gnu.org>
1929
1930 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1931 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1932
a4579d33
KB
19332011-08-16 Ken Brown <kbrown@cornell.edu>
1934
1935 Fix memory allocation problems in Cygwin build (Bug#9273).
1936
1937 * unexcw.c ( __malloc_initialized): Declare external variable.
1938 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1939
8b76d6f8
SM
1940 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1941 New variables.
a4579d33
KB
1942 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1943 dumped emacs.
1944 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1945 in the static heap.
1946 [CYGWIN] (special_realloc): New function.
1947 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1948 requests to realloc storage in the static heap.
1949
3ebec551
PE
19502011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 * bidi.c (bidi_initialize): Remove unused local.
1953
9fd8be00
EZ
19542011-08-15 Eli Zaretskii <eliz@gnu.org>
1955
6b02f655
SM
1956 * bidimirror.h:
1957 * biditype.h: Remove file.
1958 * makefile.w32-in ($(BLD)/bidi.$(O)):
1959 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1960
1961 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1962
1963 * chartab.c: Improve commentary for the uniprop_table API.
1964
32413314
EZ
1965 * bidi.c (bidi_paragraph_init): Support zero value of
1966 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1967 (bidi_initialize): Use uniprop_table instead of including
1968 biditype.h and bidimirror.h.
32413314 1969
9fd8be00
EZ
1970 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1971 coordinates of the iterator when restoring from ppos_it.
1972 (Bug#9296)
1973
5cf2b69b
KH
19742011-08-14 Kenichi Handa <handa@m17n.org>
1975
1976 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1977 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1978
daf17d00
EZ
19792011-08-14 Eli Zaretskii <eliz@gnu.org>
1980
1981 * xdisp.c (move_it_in_display_line_to): Don't invoke
1982 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1983 ppos_it. Fixes vertical cursor motion when line beginning is
1984 covered by an image. (Bug#9296)
1985
08e3161a
JD
19862011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1987
1988 * nsterm.h (ns_run_ascript): Declare.
1989 (NSAPP_DATA2_RUNASSCRIPT): Define.
1990
1991 * nsfns.m (as_script, as_result, as_status): New static variables.
1992 (ns_run_ascript): New function.
5e617bc2 1993 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1994 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1995 the event loop. Get status from as_status (Bug#7276).
1996
1997 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1998 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1999 the event loop (Bug#7276).
2000
a3720aa2
AS
20012011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2002
2003 * gnutls.c (QCgnutls_bootprop_priority)
2004 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2005 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2006 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2007 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2008 (QCgnutls_bootprop_verify_hostname_error)
2009 (QCgnutls_bootprop_callbacks_verify): Rename from
2010 Qgnutls_bootprop_..., all uses changed.
2011
2012 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2013 uses changed.
2014
0a0d27fb
PE
20152011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2016
19d5c50c
PE
2017 * xfaces.c (Qframe_set_background_mode): Now static.
2018 * dispextern.h (Qframe_set_background_mode): Remove decl.
2019
0a0d27fb
PE
2020 * process.c (Fnetwork_interface_info): Declare local only if needed.
2021
377538cb
JD
20222011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2023
2024 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2025 (Fnetwork_interface_list): Allocate in increments of bytes instead
2026 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2027 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2028 sockaddr.
2029 (struct ifflag_def): notrailers is smart on OSX.
2030 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2031 Get hardware address with getifaddrs if available.
2032
08fff70c
EZ
20332011-08-12 Eli Zaretskii <eliz@gnu.org>
2034
2035 * xdisp.c (iterate_out_of_display_property): xassert that
2036 IT->position is set to within IT->object's boundaries. Break from
2037 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2038 when IT->position is set up wrongly due to some bug.
2039 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2040 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2041 entry. Force push_it to save on the stack the current
2042 buffer/string position, to be restored by pop_it. Fix flags in
2043 the iterator structure wrt the object coming from a display
2044 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2045 properties. (Bug#9284)
2046
7be1c708 20472011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2048
7be1c708
CY
2049 * fontset.c (fontset_get_font_group): Add proper type checks.
2050 (Bug#9172)
aac0c6e3 2051
7be1c708 20522011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2053
7be1c708
CY
2054 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2055 and LC_VERSION_MIN_MACOSX.
2056 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2057 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2058
97bb72a6
EZ
20592011-08-08 Eli Zaretskii <eliz@gnu.org>
2060
2061 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2062 no-display-properties-and-no-overlays under bidi display.
2063 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2064 properties and overlays.
97bb72a6 2065
d5617611
CY
20662011-08-08 Chong Yidong <cyd@stupidchicken.com>
2067
37e11a63
CY
2068 * editfns.c (Fset_time_zone_rule): Document relationship with the
2069 setenv function.
2070
d5617611
CY
2071 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2072 the font entity extracted from the cache (Bug#8109).
2073
58872834
CY
20742011-08-07 Chong Yidong <cyd@stupidchicken.com>
2075
2076 * composite.c (autocmp_chars): Don't reset point. That is done by
2077 restore_point_unwind (Bug#5984).
2078
75bfc667
JL
20792011-08-07 Juri Linkov <juri@jurta.org>
2080
2081 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2082 to show the arg `TIME' instead of `TIMEVAL'.
2083
d1410150
EZ
20842011-08-06 Eli Zaretskii <eliz@gnu.org>
2085
2086 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2087 display property strides EOL and includes a newline, as in
2088 longlines-mode. (Bug#9254)
75b771e4
EZ
2089 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2090 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2091
2092 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2093 is non-zero, even if the data buffer is NULL. Fixes a crash in
2094 vertical-motion with longlines-mode. (Bug#9254)
2095
35928349
EZ
20962011-08-05 Eli Zaretskii <eliz@gnu.org>
2097
ec7cc85b
EZ
2098 * bidi.c <bidi_cache_total_alloc>: Now static.
2099 (bidi_initialize): Initialize bidi_cache_total_alloc.
2100
8b76d6f8 2101 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2102 cache. (Bug#9221)
2103
2104 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2105 amount allocated this far in `bidi_cache_total_alloc'.
2106 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2107 non-zero, only free the data buffer without restoring the cache
2108 contents. All callers changed.
2109
2110 * dispextern.h (bidi_unshelve_cache): Update prototype.
2111
2112 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2113 (move_it_in_display_line, move_it_to)
2114 (move_it_vertically_backward, move_it_by_lines): Replace the call
2115 to xfree to an equivalent call to bidi_unshelve_cache.
2116 (move_it_in_display_line_to): Fix logic of returning
412b6358 2117 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2118
e2e2423b
EZ
21192011-08-05 Eli Zaretskii <eliz@gnu.org>
2120
2121 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2122 came from a string character with a `cursor' property. (Bug#9229)
2123
ae9e757a
JD
21242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2125
2126 * Makefile.in (LIB_PTHREAD): New variable.
2127 (LIBES): Add LIB_PTHREAD (Bug#9216).
2128
2129 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2130 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2131
213bd7f2
AS
21322011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2133
6b02f655 2134 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2135
99aaf75f
JD
21362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2137
2138 * xterm.c (x_find_topmost_parent): New function.
2139 (x_set_frame_alpha): Find topmost parent window with
2140 x_find_topmost_parent and set the property there also (bug#9181).
2141 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2142
c74e9d86
PE
21432011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2144
2145 * callproc.c (Fcall_process): Avoid vfork clobbering
2146 the local vars buffer, coding_systems, current_dir.
2147
640c8776
SM
21482011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2149
2150 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2151
f26d0e4c
PE
21522011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2153
8a10d76c
PE
2154 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2155 so that it is not optimized away.
2156
f26d0e4c
PE
2157 * xdisp.c (compute_display_string_pos): Remove unused local.
2158
55439c61
EZ
21592011-08-02 Eli Zaretskii <eliz@gnu.org>
2160
2161 Fix slow cursor motion and scrolling in large buffers with
2162 selective display, like Org Mode buffers. (Bug#9218)
2163
2164 * dispextern.h (struct bidi_it): New member disp_prop_p.
2165
2166 * xdisp.c: Remove one-slot cache of display string positions.
2167 (compute_display_string_pos): Accept an additional argument
5e617bc2 2168 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2169 for a display string or property. If found, set DISP_PROP_P
2170 non-zero.
2171
2172 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2173 DISP_PROP_P, and pass it to compute_display_string_pos.
2174 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2175 non-zero. All callers of bidi_fetch_char changed.
2176
fb33fa43
SM
21772011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2180
b099e063
DM
21812010-12-03 Don March <don@ohspite.net>
2182
2183 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2184 last character M-[char] is translated to ESC [char] (bug#7541).
2185
5cc7f7af
KH
21862011-08-02 Kenichi Handa <handa@m17n.org>
2187
d0fffa3f 2188 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2189
2190 * chartab.c (uniprop_table): Make it non-static.
2191
525d5e6e
EZ
21922011-08-01 Eli Zaretskii <eliz@gnu.org>
2193
2194 * xdisp.c (forward_to_next_line_start): Accept additional argument
2195 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2196 on the newline.
2197 (reseat_at_next_visible_line_start): Use the bidi iterator state
2198 returned by forward_to_next_line_start to restore the state of
2199 it->bidi_it after backing up to previous newline. (Bug#9212)
2200
31011111
AS
22012011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2202
2203 * regex.c (re_comp): Protoize.
2204 (re_exec): Fix return type.
2205 (regexec): Fix type of `ret'. (Bug#9203)
2206
476371c4
PE
22072011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2208
e5d76069
PE
2209 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2210 This is needed if max-image-size is a floating-point number.
2211
9a79b20c
AS
22122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2213
2214 * print.c (print_object): Print empty symbol as ##.
2215
2216 * lread.c (read1): Read ## as empty symbol.
2217
d8c2fa78
AA
22182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2219
2220 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2221 setting frame foreground color (Bug#9175).
2222 (x_set_background_color): Likewise.
2223
ffe57a7a
AA
2224 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2225 contents (Bug#9176).
2226 (EmacsTooltip -init): Remove bezels and add shadows to
2227 tooltip windows.
2228
bf3492a5
AA
2229 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2230 or scroll bar (Bug#8470).
2231
d55e9c53
AA
2232 * nsfont.m (nsfont_open): Remove assignment to voffset and
2233 unnecessary vars hshink, expand, hd, full_height, min_height.
2234 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2235
2236 * nsterm.h (nsfont_info): Remove voffset field.
2237
d8c2fa78 22382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2239
2240 Implement strike-through and overline on NextStep (Bug#8863).
2241
2242 * nsfont.m (nsfont_open): Use underline position provided by font,
2243 instead of hard-coded value of 2.
2244 (nsfont_draw): Call ns_draw_text_decoration instead.
2245
2246 * nsterm.h: Add declaration for ns_draw_text_decoration.
2247
2248 * nsterm.m (ns_draw_text_decoration): New function for drawing
2249 underline, overline, and strike-through.
2250 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2251 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2252 accommodate underlining, etc.
4843aac3 2253
4cc60b9b
EZ
22542011-07-28 Eli Zaretskii <eliz@gnu.org>
2255
bc7ece87
EZ
2256 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2257 default.
4cc60b9b 2258
476371c4
PE
22592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2260
66606eea
PE
2261 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2262 Without this fix, if a signal arrives just after memory fills up,
2263 'malloc' might be invoked reentrantly.
2264
476371c4
PE
2265 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2266 In other words, assume that every image size is allowed, on non-X
2267 hosts. This assumption is probably wrong, but it lets Emacs compile.
2268
f3fcc40d
AS
22692011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2270
2271 * regex.c (re_iswctype): Convert return values to boolean.
2272
350c992f
EZ
22732011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2274
2275 * xdisp.c (compute_display_string_pos): Don't use cached display
2276 string position if the buffer had its restriction changed.
2277 (Bug#9184)
2278
5266b4bb
PE
22792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2282
2573a837 22832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2284
41f55ccd 2285 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2286
39e378da
PE
2287 * bidi.c: Integer size and overflow fixes.
2288 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2289 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2290 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2291 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2292 (bidi_find_other_level_edge):
2293 Use ptrdiff_t instead of EMACS_INT where either will do.
2294 This works better on 32-bit hosts configured --with-wide-int.
2295 (bidi_cache_ensure_space): Check for size-calculation overflow.
2296 Use % rather than repeated addition, for better worst-case speed.
2297 Don't set bidi_cache_size until after xrealloc returns, because it
2298 might not return.
2299 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2300 (bidi_cache_ensure_space): Also check that the bidi cache size
2301 does not exceed that of the largest Lisp string or buffer. See Eli
2302 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2303
5e927815
PE
2304 * alloc.c (__malloc_size_t): Remove.
2305 All uses replaced by size_t. See Andreas Schwab's note
2306 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2307
ca4aa935
PE
2308 * image.c: Improve checking for integer overflow.
2309 (check_image_size): Assume that f is nonnull, since
2310 it is always nonnull in practice. This is one less thing to
2311 worry about when checking for integer overflow later.
2312 (x_check_image_size): New function, which checks for integer
2313 overflow issues inside X.
2314 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2315 This removes the need for a memory_full check.
2316 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2317 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2318 (xbm_read_bitmap_data): Change locals back to 'int', since
2319 their values must fit in 'int'.
2320 (xpm_load_image, png_load, tiff_load):
2321 Invoke x_create_x_image_and_pixmap earlier,
2322 to avoid much needless work if the image is too large.
2323 (tiff_load): Treat overly large images as if
2324 x_create_x_image_and_pixmap failed, not as malloc failures.
2325 (gs_load): Use x_check_image_size.
2326
5f8f9cc2
PE
2327 * gtkutil.c: Omit integer casts.
2328 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2329 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2330
5adf60bc
PE
2331 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2332
c8907a93
PE
2333 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2334 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2335 would wrongly return t on a 64-bit host.
2336
e3c25c68
PE
2337 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2338 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2339 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2340 and therefore cause GCC to emit a bogus diagnostic in some cases.
2341
3f791afe
PE
2342 * image.c: Integer signedness and overflow and related fixes.
2343 This is not an exhaustive set of fixes, but it's time to
2344 record what I've got.
2345 (lookup_pixel_color, check_image_size): Remove redundant decls.
2346 (check_image_size): Don't assume that arbitrary EMACS_INT values
2347 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2348 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2349 (tiff_load, imagemagick_load_image):
2350 Check for overflow in size calculations.
2351 (x_create_x_image_and_pixmap): Remove unnecessary test for
2352 xmalloc returning NULL; that can't happen.
2353 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2354 (xpm_color_bucket): Use better integer hashing function.
2355 (xpm_cache_color): Don't possibly over-allocate memory.
2356 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2357 (gif_memory_source):
2358 Use ptrdiff_t, not int or size_t, to record sizes.
2359 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2360 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2361 either works, as we prefer signed integers.
2362 (tiff_read_from_memory, tiff_write_from_memory):
2363 Return tsize_t, not size_t, since that's what the TIFF API wants.
2364 (tiff_read_from_memory): Don't fail simply because the read would
2365 go past EOF; instead, return a short read.
2366 (tiff_load): Omit no-longer-needed casts.
2367 (Fimagemagick_types): Don't assume size fits into 'int'.
2368
3cc5a532
PE
2369 Improve hashing quality when configured --with-wide-int.
2370 * fns.c (hash_string): New function, taken from sxhash_string.
2371 Do not discard information about ASCII character case; this
2372 discarding is no longer needed.
2373 (sxhash-string): Use it. Change sig to match it. Caller changed.
2374 * lisp.h: Declare it.
2375 * lread.c (hash_string): Remove, since we now use fns.c's version.
2376 The fns.c version returns a wider integer if --with-wide-int is
2377 specified, so this should help the quality of the hashing a bit.
2378
b312a492
PE
2379 * emacs.c: Integer overflow minor fix.
2380 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2381 Define only if GNU_LINUX.
2382 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2383
dfd153ae
PE
2384 * dispnew.c: Integer signedness and overflow fixes.
2385 Remove unnecessary forward decls, that were a maintenance hassle.
2386 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2387 All uses changed.
2388 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2389 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2390 (prepare_desired_row, line_draw_cost):
2391 Use int, not unsigned, where either works.
2392 (save_current_matrix, restore_current_matrix):
2393 Use ptrdiff_t, not size_t, where either works.
2394 (init_display): Check for overflow more accurately, and without
2395 relying on undefined behavior.
2396
a81d11a3
PE
2397 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2398 Remove, replacing with the new symbols in lisp.h. All uses changed.
2399 * fileio.c (make_temp_name):
2400 * filelock.c (lock_file_1, lock_file):
2401 * xdisp.c (message_dolog):
2402 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2403 Use pMd etc. instead.
2404 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2405 replacing the pWIDE etc. symbols removed from editfns.c.
2406
3300e6fd
PE
2407 * keyboard.h (num_input_events): Now uintmax_t.
2408 This is (very slightly) less likely to mess up due to wraparound.
2409 All uses changed.
2410
fd05c7e9
PE
2411 * buffer.c: Integer signedness fixes.
2412 (alloc_buffer_text, enlarge_buffer_text):
2413 Use ptrdiff_t rather than size_t when either will do, as we prefer
2414 signed integers.
2415
903fe15d
PE
2416 * alloc.c: Integer signedness and overflow fixes.
2417 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2418 (__malloc_size_t): Default to size_t, not to int.
2419 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2420 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2421 Prefer ptrdiff_t to size_t when either would do, as we prefer
2422 signed integers.
2423 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2424 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2425 Now const. Initialize with values that are in range even if char
2426 is signed.
2427 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2428 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2429 These functions do the right thing with sizes > 2**32.
2430 (check_depth): Now ptrdiff_t, not int.
2431 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2432 Adjust to new way of storing sizes. Check for size overflow bugs
2433 in rest of code.
2434 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2435 slightly wrong anyway, as it missed one instance of
2436 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2437 (refill_memory_reserve): Omit needless cast to size_t.
2438 (mark_object_loop_halt): Mark as externally visible.
2439
ac82cc6a
PE
2440 * xselect.c: Integer signedness and overflow fixes.
2441 (Fx_register_dnd_atom, x_handle_dnd_message):
2442 Use ptrdiff_t, not size_t, since we prefer signed.
2443 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2444 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2445 x_dnd_atoms_size and x_dnd_atoms_length.
2446
c2d1e36d
PE
2447 * doprnt.c: Prefer signed to unsigned when either works.
2448 * eval.c (verror):
2449 * doprnt.c (doprnt):
2450 * lisp.h (doprnt):
2451 * xdisp.c (vmessage):
2452 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2453 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2454 prefer signed arithmetic to avoid comparison confusion.
2455 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2456 but is a bit tricky.
2457
0e926e56
PE
2458 Assume freestanding C89 headers, string.h, stdlib.h.
2459 * data.c, doprnt.c, floatfns.c, print.c:
2460 Include float.h unconditionally.
2461 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2462 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2463 * regex.c: Likewise for stddef.h, string.h.
2464 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2465 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2466 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2467 (STDC_HEADERS): Remove obsolete defines.
2468 * sysdep.c: Include limits.h unconditionally.
2469
9cfdb3ec
PE
2470 Assume support for memcmp, memcpy, memmove, memset.
2471 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2472 * regex.c (memcmp, memcpy):
2473 Remove; we assume C89 now.
2474
2475 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2476 (__malloc_safe_bcopy): Remove; no longer needed.
2477
cf950e6b 2478 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2479 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2480 well either way, and we prefer signed to unsigned.
2481
dbf38e02
LMI
24822011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2483
2484 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2485 closes the connection while we're reading (bug#9182).
2486
d6f0886c 24872011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2488
d6f0886c
JD
2489 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2490 are specified (Bug#9168).
24e0f6b1 2491
2eb1f9e6
PE
24922011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2493
2494 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2495 Found by GCC static checking and --with-wide-int on a 32-bit host.
2496
22381272 24972011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2498
2499 * xdisp.c (compute_display_string_pos): Fix logic of caching
2500 previous display string position. Initialize cached_prev_pos to
2501 -1. Fixes slow-down at the beginning of a buffer.
2502
f25e39b4
EZ
25032011-07-24 Eli Zaretskii <eliz@gnu.org>
2504
2505 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2506 for attrs[LFACE_FONTSET_INDEX].
2507
04c4b52e
PE
25082011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2509
2510 * xml.c (parse_region): Remove unused local
2511 that was recently introduced.
2512
c1734fbd
EZ
25132011-07-23 Eli Zaretskii <eliz@gnu.org>
2514
be18c5a5
EZ
2515 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2516 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2517
c1734fbd
EZ
2518 * xdisp.c (move_it_in_display_line_to): Record the best matching
2519 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2520 exit if none of the characters scanned was an exact match.
2521 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2522 when exact match is impossible due to invisible text, and the
2523 lines are truncated.
2524
a258d627
JD
25252011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2526
2527 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2528 for OSX >= 10.7.
2529
b6d5a689
EZ
25302011-07-22 Eli Zaretskii <eliz@gnu.org>
2531
0f74f785
EZ
2532 Fix a significant slow-down of cursor motion with C-n, C-p,
2533 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2534 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2535 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2536 (next_element_from_buffer): Call compute_stop_pos_backwards to
2537 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2538 base_level_stop.
2539 (reseat): Don't look for prev_stop, as that could mean a very long
2540 run.
2541 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2542 <cached_disp_overlay_modiff>: Cache for last found display string
2543 position.
551918c1 2544 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2545 about the same buffer in the same area of character positions, and
2546 the buffer wasn't changed since the time the display string
2547 position was cached.
551918c1 2548
b2d0c91a
EZ
25492011-07-22 Eli Zaretskii <eliz@gnu.org>
2550
2551 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2552 is an integer, which is important for empty lines. (Bug#9149)
2553
043604ee
CY
25542011-07-22 Chong Yidong <cyd@stupidchicken.com>
2555
2556 * frame.c (Fmodify_frame_parameters): In tty case, update the
2557 default face if necessary (Bug#4238).
2558
da4adb04
CY
25592011-07-21 Chong Yidong <cyd@stupidchicken.com>
2560
2561 * editfns.c (Fstring_to_char): No need to explain what a character
2562 is in the docstring (Bug#6576).
2563
9abd0532
LMI
25642011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2565
2566 * xml.c (parse_region): Make sure we always return a tree.
2567
36881d16
HK
25682011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2569
2570 * xml.c (parse_region): If a document contains only comments,
2571 return that, too.
2572
1e98674d
LMI
25732011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2574
2575 * xml.c (make_dom): Return comments, too.
2576
590bd467
PE
25772011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 Port to OpenBSD.
2580 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2581 and the surrounding thread.
2582 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2583 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2584 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2585 timer goes off.
2586 * s/openbsd.h (BROKEN_SIGIO): Define.
2587 * unexelf.c (unexec) [__OpenBSD__]:
2588 Don't update the .mdebug section of the Alpha COFF symbol table.
2589
f41628b2
LMI
25902011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2591
2592 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2593 (bug#8460).
2594
b59b67c5
PE
25952011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2596
15e3a074
PE
2597 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2598 This fixes some race conditions on the permissions of any newly
2599 created file.
2600
41bed37d
PE
2601 * alloc.c (valid_pointer_p): Use pipe, not open.
2602 This fixes some permissions issues when debugging.
2603
b59b67c5
PE
2604 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2605 If fchown fails to set both uid and gid, try to set just gid,
2606 as that is sometimes allowed. Adjust the file's mode to eliminate
2607 setuid or setgid bits that are inappropriate if fchown fails.
2608
925a6be7
SM
26092011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2610
2611 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2612 to compare Lisp_Objects.
2613 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2614 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2615 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2616
52968808
AS
26172011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2618
0a6a104b
AS
2619 * lread.c (read_integer): Unread even EOF character.
2620 (read1): Likewise. Properly record start position of symbol.
2621
52968808
AS
2622 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2623 symbol character follows.
2624
9e381cdd
PE
26252011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2626
2627 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2628 This works around a problem with the previous change to Fcopy_file.
2629 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2630 and without this change, GCC might complain about discarding
2631 fchown's return value.
2632
b5641435
JB
26332011-07-16 Juanma Barranquero <lekktu@gmail.com>
2634
2635 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2636
a8031457
PE
26372011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2640
dd889327
LMI
26412011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2642
750c33f7
LMI
2643 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2644 it's used from the C level.
2645
dd889327
LMI
2646 * process.c: Use the same condition for POLL_FOR_INPUT in both
2647 keyboard.c and process.c (bug#1858).
2648
87e86684
LM
26492011-07-09 Lawrence Mitchell <wence@gmx.li>
2650
2651 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2652 (Fgnutls_boot): Use it.
2653
64348f40
AS
26542011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2655
2656 * doc.c (Fsubstitute_command_keys): Revert last change.
2657
1d698799
LMI
26582011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2659
f863868c
LMI
2660 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2661 quotes the next character, and doesn't affect other longer
2662 sequences (bug#8935).
2663
1d698799
LMI
2664 * lread.c (syms_of_lread): Clarify that is isn't only
2665 `eval-buffer' and `eval-defun' that's affected by
2666 `lexical-binding' (bug#8460).
2667
aa4b6df6
EZ
26682011-07-15 Eli Zaretskii <eliz@gnu.org>
2669
2670 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2671 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2672
5d856da6
PE
26732011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2674
ad6042bb
PE
2675 Fix minor problems found by static checking.
2676 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2677 (elsz): Now a signed constant, not a size_t var. We prefer signed
2678 types to unsigned, to avoid integer comparison confusion. Without
2679 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2680 "cannot optimize loop, the loop counter may overflow", a symptom
2681 of the confusion.
f00bbb22 2682 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2683 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2684
6468f31c
LMI
26852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2686
49080b10
LMI
2687 * search.c (Fre_search_backward): Mention `case-fold-search' in
2688 all the re_search_* functions (bug#8138).
2689
6468f31c
LMI
2690 * keyboard.c (Fopen_dribble_file): Document when the file is
2691 closed (bug#8056).
2692
c965adc5
EZ
26932011-07-14 Eli Zaretskii <eliz@gnu.org>
2694
df9733bf
EZ
2695 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2696 bidi_cache_idx.
2697
0bb23927
EZ
2698 Support bidi reordering of display and overlay strings.
2699 * xdisp.c (compute_display_string_pos)
2700 (compute_display_string_end): Accept additional argument STRING.
2701 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2702 (reseat_to_string): Initialize bidi_it->string.s and
2703 bidi_it->string.schars.
2704 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2705 NULL (avoids a crash in bidi_paragraph_init).
2706 Initialize itb.string.lstring.
0bb23927
EZ
2707 (init_iterator): Call bidi_init_it only of a valid
2708 buffer position was specified. Initialize paragraph_embedding to
2709 L2R.
2710 (reseat_to_string): Initialize the bidi iterator.
2711 (display_string): If we need to ignore text properties of
2712 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2713 original value of -1 will not work with bidi.)
2714 (compute_display_string_pos): First arg is now struct
2715 `text_pos *'; all callers changed. Support display properties on
2716 Lisp strings.
2717 (compute_display_string_end): Support display properties on Lisp
2718 strings.
2719 (init_iterator, reseat_1, reseat_to_string): Initialize the
2720 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2721 when iterating on a string not from display properties).
640c8776
SM
2722 (compute_display_string_pos, compute_display_string_end):
2723 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2724 arrow keys.
2725 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2726 base_level_stop; instead, set base_level_stop to BEGV.
2727 Fixes crashes in vertical-motion.
0bb23927
EZ
2728 (next_element_from_buffer): Improve commentary for when
2729 the iterator is before prev_stop.
2730 (init_iterator): Initialize bidi_p from the default value of
2731 bidi-display-reordering, not from buffer-local value. Use the
2732 buffer-local value only if initializing for buffer iteration.
2733 (handle_invisible_prop): Support invisible properties on strings
2734 that are being bidi-reordered.
2735 (set_iterator_to_next): Support bidi reordering of C strings and
2736 Lisp strings.
2737 (next_element_from_string): Support bidi reordering of Lisp
2738 strings.
2739 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2740 (display_string): Support display of R2L glyph rows.
2741 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2742 (init_iterator): Don't initialize it->bidi_p for strings
2743 here.
2744 (reseat_to_string): Initialize it->bidi_p for strings here.
2745 (next_element_from_string, next_element_from_c_string)
2746 (next_element_from_buffer): Add xassert's for correspondence
2747 between IT's object being iterated and it->bidi_it.string
2748 structure.
2749 (face_before_or_after_it_pos): Support bidi iteration.
2750 (next_element_from_c_string): Handle the case of the first string
2751 character that is not the first one in the visual order.
2752 (get_visually_first_element): New function, refactored from common
2753 parts of next_element_from_buffer, next_element_from_string, and
2754 next_element_from_c_string.
2755 (tool_bar_lines_needed, redisplay_tool_bar)
2756 (display_menu_bar): Force left-to-right direction. Add a FIXME
2757 comment for making that be controlled by a user option.
2758 (push_it, pop_it): Save and restore the state of the
2759 bidi iterator. Save and restore the bidi_p flag.
2760 (pop_it): Iterate out of display property for string iteration as
2761 well.
2762 (iterate_out_of_display_property): Support iteration over strings.
2763 (handle_single_display_spec): Set up it->bidi_it for iteration
2764 over a display string, and call bidi_init_it.
2765 (handle_single_display_spec, next_overlay_string)
2766 (get_overlay_strings_1, push_display_prop): Set up the bidi
2767 iterator for displaying display or overlay strings.
2768 (forward_to_next_line_start): Don't use the shortcut if
2769 bidi-iterating.
2770 (back_to_previous_visible_line_start): If handle_display_prop
2771 pushed the iterator stack, restore the internal state of the bidi
2772 iterator by calling bidi_pop_it same number of times.
2773 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2774 and we are bidi-iterating, don't decrement the iterator position;
2775 instead, set the first_elt flag in the bidi iterator, to produce
2776 the same effect.
2777 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2778 (push_display_prop): xassert that we are iterating a buffer.
2779 (push_it, pop_it): Save and restore paragraph_embedding member.
2780 (handle_single_display_spec, next_overlay_string)
2781 (get_overlay_strings_1, reseat_1, reseat_to_string)
2782 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2783 correctly. Don't assume unibyte strings are not bidi-reordered.
2784 (compute_display_string_pos)
2785 (compute_display_string_end): Fix handling the case of C string.
2786 (push_it, pop_it): Save and restore from_disp_prop_p.
2787 (handle_single_display_spec, push_display_prop): Set the
2788 from_disp_prop_p flag.
2789 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2790 (pop_it): Call iterate_out_of_display_property only if we are
2791 popping after iteration over a string that came from a display
2792 property. Fix a typo in popping stretch info. Add an assertion
2793 for verifying that the iterator position is in sync with the bidi
2794 iterator.
2795 (handle_single_display_spec, get_overlay_strings_1)
2796 (push_display_prop): Fix initialization of paragraph direction for
2797 string when that of the parent object is not yet determined.
2798 (reseat_1): Call bidi_init_it to resync the bidi
2799 iterator with IT's position. (Bug#7616)
2800 (find_row_edges): If ROW->start.pos gives position
2801 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2802 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2803 Reset the from_disp_prop_p flag.
2804 (SAVE_IT, RESTORE_IT): New macros.
2805 (pos_visible_p, face_before_or_after_it_pos)
2806 (back_to_previous_visible_line_start)
2807 (move_it_in_display_line_to, move_it_in_display_line)
2808 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2809 (try_scrolling, redisplay_window, display_line): Use them when
2810 saving a temporary copy of the iterator and restoring it back.
2811 (back_to_previous_visible_line_start, reseat_1)
2812 (init_iterator): Empty the bidi cache "stack".
2813 (move_it_in_display_line_to): If iterator ended up at
2814 EOL, but we never saw any buffer positions smaller than
2815 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2816 motion in bidi-reordered lines.
2817 (move_it_in_display_line_to): Record prev_method and prev_pos
2818 immediately before the call to set_iterator_to_next. Fixes cursor
2819 motion in bidi-reordered lines with stretch glyphs and strings
2820 displayed in margins. (Bug#8133) (Bug#8867)
2821 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2822 TO_CHARPOS.
640c8776
SM
2823 (pos_visible_p): Support positions in bidi-reordered lines.
2824 Save and restore bidi cache.
0bb23927
EZ
2825
2826 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2827 (bidi_paragraph_info): Delete unused struct.
2828 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2829 (bidi_cache_start): New variable.
2830 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2831 to zero.
2832 (bidi_cache_fetch_state, bidi_cache_search)
2833 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2834 (bidi_cache_find, bidi_peek_at_next_level)
2835 (bidi_level_of_next_char, bidi_find_other_level_edge)
2836 (bidi_move_to_visually_next): Compare cache index with
2837 bidi_cache_start rather than with zero.
2838 (bidi_fetch_char): Accept new argument STRING; all callers
2839 changed. Support iteration over a string. Support strings with
2840 display properties. Support unibyte strings. Fix the type of
2841 `len' according to what STRING_CHAR_AND_LENGTH expects.
2842 (bidi_paragraph_init, bidi_resolve_explicit_1)
2843 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2844 (bidi_level_of_next_char, bidi_move_to_visually_next):
2845 Support iteration over a string.
0bb23927
EZ
2846 (bidi_set_sor_type, bidi_resolve_explicit_1)
2847 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2848 can now be zero (for strings); special values 0 and -1 were
2849 changed to -1 and -2, respectively.
2850 (bidi_char_at_pos): New function.
2851 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2852 Call it instead of FETCH_MULTIBYTE_CHAR.
2853 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2854 initialized to valid values.
2855 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2856 values.
2857 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2858 the test for valid cached positions. Fix the logic for looking up
2859 the sentinel state in the cache. GCPRO the Lisp string we are
2860 iterating.
2861 (bidi_push_it, bidi_pop_it): New functions.
2862 (bidi_initialize): Initialize the bidi cache start stack pointer.
2863 (bidi_cache_ensure_space): New function, refactored from part of
2864 bidi_cache_iterator_state. Don't assume the required size is just
2865 one BIDI_CACHE_CHUNK away.
2866 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2867 (bidi_count_bytes, bidi_char_at_pos): New functions.
2868 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2869 always valid if bidi_cache_idx is valid.
2870 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2871 is valid if it's going to be used.
2872 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2873 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2874 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2875 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2876 (bidi_find_other_level_edge, bidi_cache_start_stack):
2877 All variables related to cache indices are now EMACS_INT.
c965adc5 2878
0bb23927
EZ
2879 * dispextern.h (struct bidi_string_data): New structure.
2880 (struct bidi_it): New member `string'. Make flag members be 1-bit
2881 fields, and put them last in the struct.
640c8776
SM
2882 (compute_display_string_pos, compute_display_string_end):
2883 Update prototypes.
0bb23927
EZ
2884 (bidi_push_it, bidi_pop_it): Add prototypes.
2885 (struct iterator_stack_entry): New members bidi_p,
2886 paragraph_embedding, and from_disp_prop_p.
2887 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2888 (bidi_shelve_cache, bidi_unshelve_cache):
2889 Declare prototypes.
0bb23927
EZ
2890
2891 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2892 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2893 and vector-like objects.
2894
2895 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2896 cache around display iteration.
2897
2898 * window.c (Fwindow_end, window_scroll_pixel_based)
2899 (displayed_window_lines, Frecenter): Save and restore the bidi
2900 cache around display iteration.
2901
3bbd2265
LMI
29022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2903
2904 * editfns.c (Fdelete_region): Clarify the use of the named
2905 parameters (bug#6788).
2906
adc47434
MR
29072011-07-14 Martin Rudalics <rudalics@gmx.at>
2908
2909 * indent.c (Fvertical_motion): Set and restore w->pointm when
2910 saving and restoring the window's buffer (Bug#9006).
2911
837c31f8
LMI
29122011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913
2914 * editfns.c (Fstring_to_char): Clarify just what is returned
2915 (bug#6576). Text by Eli Zaretskii.
2916
ac389d0c
JB
29172011-07-13 Juanma Barranquero <lekktu@gmail.com>
2918
2919 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2920
0be0ce47
EZ
29212011-07-13 Eli Zaretskii <eliz@gnu.org>
2922
2923 * buffer.c (mmap_find): Fix a typo.
2924
cd18e7e3
JB
29252011-07-13 Johan Bockgård <bojohan@gnu.org>
2926
2927 Fix execution of x selection hooks.
2928 * xselect.c (Qx_lost_selection_functions)
2929 (Qx_sent_selection_functions): New vars.
2930 (syms_of_xselect): DEFSYM them.
2931 (x_handle_selection_request): Pass Qx_sent_selection_functions
2932 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2933 (x_handle_selection_clear,x_clear_frame_selections):
2934 Pass Qx_lost_selection_functions rather than
2935 Vx_lost_selection_functions to Frun_hook_with_args.
2936
47ea7f44
PE
29372011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2938
ac389d0c 2939 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2940 The old code sometimes used this field without initializing it.
2941
47ea7f44
PE
2942 * alloc.c (gc_sweep): Don't read past end of array.
2943 In theory, the old code could also have corrupted Emacs internals,
2944 though it'd be very unlikely.
2945
bc985c87
AS
29462011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2947
2948 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2949 argument. (Bug#4026)
bc985c87 2950
0cf34688
LMI
29512011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2952
b3dadd76
LMI
2953 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2954 key" (bug#4257).
2955
0cf34688
LMI
2956 * window.c (Fset_window_start): Doc fix (bug#4199).
2957 (Fset_window_hscroll): Ditto.
2958
270768cd
PE
29592011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2960
077e3dda 2961 Fix minor new problems caught by GCC 4.6.1.
270768cd 2962 * term.c (init_tty): Remove unused local.
490011a6 2963 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2964 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2965 not used otherwise.
270768cd 2966
b1f58454
CY
29672011-07-12 Chong Yidong <cyd@stupidchicken.com>
2968
2969 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2970
22b9578d
LMI
29712011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2972
6e70ab07
LMI
2973 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2974 are the mini-buffer and the echo area (bug#3320).
2975
22b9578d
LMI
2976 * term.c (init_tty): Remove support for supdup, c10 and perq
2977 terminals, which are no longer supported (bug#1482).
2978
8974cc9f
JB
29792011-07-10 Johan Bockgård <bojohan@gnu.org>
2980
2981 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2982
a560d974
JD
29832011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2984
2985 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2986 for non-popups (Bug#3642).
2987
1dae0f0a
AS
29882011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2989
268c2c36 2990 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2991 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2992 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2993 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2994 * data.c (fmod): Likewise.
2995 * dispnew.c (swap_glyphs_in_rows): Likewise.
2996 * emacs.c (memory_warning_signal): Likewise.
2997 * floatfns.c (float_error): Likewise.
2998 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2999 (otf_open, font_otf_capability, generate_otf_features)
3000 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3001 Likewise.
3002 * image.c (pbm_read_file): Likewise.
3003 * indent.c (string_display_width): Likewise.
3004 * intervals.c (check_for_interval, search_for_interval)
3005 (inc_interval_count, count_intervals, root_interval)
3006 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3007 * lread.c (defalias): Likewise.
268c2c36 3008 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3009 * regex.c (set_image_of_range_1, set_image_of_range)
3010 (regex_grow_registers): Likewise.
3011 * sysdep.c (strerror): Likewise.
3012 * termcap.c (valid_filename_p, tprint, main): Likewise.
3013 * tparam.c (main): Likewise.
3014 * unexhp9k800.c (run_time_remap, save_data_space)
3015 (update_file_ptrs, read_header, write_header, calculate_checksum)
3016 (copy_file, copy_rest, display_header): Likewise.
3017 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3018 Likewise.
3019 * xdisp.c (check_it): Likewise.
3020 * xfaces.c (register_color, unregister_color, unregister_colors):
3021 Likewise.
3022 * xfns.c (print_fontset_result): Likewise.
3023 * xrdb.c (member, fatal, main): Likewise.
3024
99033785
PE
30252011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3026
3027 Fix minor problems found by static checking (Bug#9031).
3028 * chartab.c (char_table_set_range, map_sub_char_table):
3029 Remove unused locals.
3030 (uniprop_table): Now static.
3031 * composite.c (_work_char): Remove unused static var.
3032
9cb2ac56
JB
30332011-07-09 Juanma Barranquero <lekktu@gmail.com>
3034
3035 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3036
f25661f0
JD
30372011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3038
3039 * gtkutil.c (qttip_cb): Remove code without function.
3040
8278c4fe
EZ
30412011-07-09 Eli Zaretskii <eliz@gnu.org>
3042
3043 * w32.c (pthread_sigmask): New stub.
3044
1692ae2d 30452011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3046
8a6ebd58 3047 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3048 sigprocmask is portable only for single-threaded applications, and
3049 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3050 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3051 (LIBES): Use it.
3052 * callproc.c (Fcall_process):
3053 * process.c (create_process):
3054 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3055 Use pthread_sigmask, not sigprocmask.
123403e4 3056
1b854618
JD
30572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3058
3059 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3060 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3061 wrong (Bug#8591).
3062
3fe4b549
JD
30632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3064
0ce7e563
JD
3065 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3066 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3067 (xg_hide_tooltip): Fix comment.
3068
3fe4b549
JD
3069 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3070 in registerServicesMenuSendTypes.
3071 (validRequestorForSendType): Don't check ns_return_types.
3072
3073 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3074 ns_return_type.
3075
5df75e47
JR
30762011-07-08 Jason Rumney <jasonr@gnu.org>
3077
22610910
JR
3078 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3079 SH_SHOW for hidden windows (Bug#5482).
3080
5df75e47
JR
3081 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3082 frame struct members of non-existent frames (Bug#6284).
3083
699c10bd
JD
30842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3085
4393663b
JD
3086 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3087 variable firstTime not needed on OSX >= 10.6.
3088 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3089 >= 10.5. Use setKnobProportion, setDoubleValue.
3090
3091 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3092 (MAC_OS_X_VERSION_10_5): Define if not defined.
3093 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3094 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3095 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3096
3097 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3098 cString and lossyCString on OSX >= 10.4
3099
58179cce 3100 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3101 sizeToFit on OSX >= 10.2.
3102
3103 * nsimage.m (allocInitFromFile): Don't use deprecated method
3104 bestRepresentationForDevice on OSX >= 10.6.
3105
3106 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3107 to avoid warning.
3108
3109 * emacs.c: Declare unexec_init_emacs_zone.
3110
a63e0781
JD
3111 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3112
699c10bd
JD
3113 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3114
3115 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3116 on svcsMenu (Bug#8842).
3117
3118 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3119 ns_return_types.
3120 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3121
3122 * nsterm.m (QUTF8_STRING): Declare.
3123 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3124 (validRequestorForSendType): Return type is (id).
3125 Change indexOfObjectIdenticalTo to indexOfObject.
3126 Check if we have local selection before returning self (Bug#8842).
3127 (writeSelectionToPasteboard): Put local selection into paste board
3128 if we have a local selection (Bug#8842).
3129 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3130
3131 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3132 (ns_get_local_selection): Declare.
3133
54e10184
LMI
31342011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3135
9888ff71
LMI
3136 * keymap.c (describe_map_tree): Don't insert a double newline at
3137 the end of the buffer (bug#1169) and return whether we inserted
3138 something.
3139
54e10184
LMI
3140 * callint.c (Fcall_interactively): Change "reading args" to
3141 "providing args" to try to clarify what it does (bug#1010).
3142
15fa4783
KH
31432011-07-07 Kenichi Handa <handa@m17n.org>
3144
3145 * composite.c (composition_compute_stop_pos): Ignore a static
3146 composition starting before CHARPOS (Bug#8915).
3147
3148 * xdisp.c (handle_composition_prop): Likewise.
3149
a8815b00
EZ
31502011-07-07 Eli Zaretskii <eliz@gnu.org>
3151
3152 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3153 (Bug#9015)
3154
ef7b981d 31552011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3156
3157 * character.h (unicode_category_t): New enum type.
3158
3159 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3160 (Qchar_code_property_table): New variable.
3161 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3162 (UNIPROP_COMPRESSED_FORM_P): New macros.
3163 (char_table_ascii): Uncompress the compressed values.
3164 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3165 Uncompress the compressed values.
ac389d0c 3166 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3167 (char_table_ref_and_range): Uncompress the compressed values.
3168 (sub_char_table_set): New arg is_uniprop. Callers changed.
3169 Uncompress the compressed values.
3170 (sub_char_table_set_range): Args changed. Callers changed.
3171 (char_table_set_range): Adjuted for the above change.
3172 (map_sub_char_table): Delete args default_val and parent. Add arg
3173 top. Give decoded values to a Lisp function.
640c8776 3174 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3175 values to a Lisp function. Gcpro more variables.
3176 (uniprop_table_uncompress)
3177 (uniprop_decode_value_run_length): New functions.
3178 (uniprop_decoder, uniprop_decoder_count): New variables.
3179 (uniprop_get_decoder, uniprop_encode_value_character)
3180 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3181 New functions.
3182 (uniprop_encoder, uniprop_encoder_count): New variables.
3183 (uniprop_get_encoder, uniprop_table)
3184 (Funicode_property_table_internal, Fget_unicode_property_internal)
3185 (Fput_unicode_property_internal): New functions.
3186 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3187 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3188 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3189 char-code-property-alist.
3190
640c8776 3191 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3192 Vunicode_category_table.
3193
640c8776 3194 * font.c (font_range): Adjust for the change of
c805dec0
KH
3195 Vunicode_category_table.
3196
76b397fb
DN
31972011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3198
3199 * m/iris4d.h: Remove file, move contents ...
3200 * s/irix6-5.h: ... here.
3201
22b4128e
PE
32022011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3203
3204 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3205 * alloc.c (mark_buffer):
3206 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3207 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3208 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3209 This isn't true in general, and it's particularly not true
3210 if Emacs is configured with --with-wide-int.
3211 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3212 New macros, used in the buffer.c change.
3213
869795d6
JD
32142011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3215
3216 * xsettings.c: Use both GConf and GSettings if both are available.
3217 (store_config_changed_event): Add comment.
3218 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3219 (store_tool_bar_style_changed): New functions.
5e617bc2 3220 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3221 (struct xsettings): Move font inside HAVE_XFT.
3222 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3223 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3224 Move inside HAVE_XFT.
640c8776 3225 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3226 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3227 also.
3228 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3229 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3230 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3231 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3232 (parse_settings): Move check for font inside HAVE_XFT.
3233 (read_settings, apply_xft_settings): Add comment.
3234 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3235 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3236 call store_font_name_changed.
3237 (xft_settings_event): Add comment.
3238 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3239 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3240 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3241 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3242 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3243 (xsettings_get_system_font, xsettings_get_system_normal_font):
3244 Add comment.
869795d6 3245
d8ed26bd
PE
32462011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 Random fixes. E.g., (random) never returned negative values.
3249 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3250 subseconds part to the entropy, as that's a bit more random.
3251 Prefer signed to unsigned, since the signedness doesn't matter and
3252 in general we prefer signed. When given a limit, use a
3253 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3254 latter isn't right if USE_2_TAGS_FOR_INTS.
3255 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3256 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3257
cabf1cac
SM
32582011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3259
3260 * textprop.c (text_property_stickiness):
3261 Obey Vtext_property_default_nonsticky.
3262 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3263 * w32fns.c (syms_of_w32fns):
3264 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3265
6e9b2be9
PE
32662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3267
3268 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3269 This is more efficient than Ffile_directory_p and avoids a minor race.
3270
90186c68
LMI
32712011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3272
7c301272
LMI
3273 * buffer.c (Foverlay_put): Say what the return value is
3274 (bug#7835).
3275
c4f2d8d4
LMI
3276 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3277 is a directory before asking whether to use the file name
3278 (bug#7564).
ad637907
LMI
3279 (barf_or_query_if_file_exists): Make the "File is a directory"
3280 error be more correct.
c4f2d8d4 3281
90186c68
LMI
3282 * fns.c (Frequire): Remove the mention of the .gz files, since
3283 that's installation-specific, but keep the mention of
3284 `get-load-suffixes'.
3285
da64016e
PE
32862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3289 Report string overflow if the output is too long.
3290
7d47b580
JB
32912011-07-04 Juanma Barranquero <lekktu@gmail.com>
3292
a555cb87
JB
3293 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3294 (syms_of_gnutls): Remove duplicate DEFSYM for
3295 Qgnutls_bootprop_verify_hostname_error, an error for
3296 Qgnutls_bootprop_verify_error (which is no longer used).
3297
7d47b580
JB
3298 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3299 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3300 Also (re)move comments that are misplaced or no longer relevant.
3301
1e49bfab
LMI
33022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3303
3304 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3305
1485f4c0
CY
33062011-07-03 Chong Yidong <cyd@stupidchicken.com>
3307
3308 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3309 and background color parameters if they have been changed.
3310
a9ab721e
LMI
33112011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3312
3313 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3314
cf7cff57
PE
33152011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3316
2e13213d
PE
3317 * xsettings.c (SYSTEM_FONT): Define only when used.
3318 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3319
cf7cff57
PE
3320 * keymap.c (access_keymap_1): Now static.
3321
7a8e04f7
CY
33222011-07-02 Chong Yidong <cyd@stupidchicken.com>
3323
3324 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3325 leave any prefix arg for the up event (Bug#1586).
3326
61352f62
LMI
33272011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3328
69bb1ef7
LMI
3329 * lread.c (syms_of_lread): Mention single symbols defined by
3330 `defvar' or `defconst' (bug#7154).
3331
61352f62 3332 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3333 (Frequire): Mention get-load-suffixes.
61352f62 3334
28545e04
MR
33352011-07-02 Martin Rudalics <rudalics@gmx.at>
3336
3337 * window.h (window): Remove clone_number slot.
3338 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3339 Remove.
3340 (make_parent_window, make_window, saved_window)
3341 (Fset_window_configuration, save_window_save): Don't deal with
3342 clone numbers.
3343 * buffer.c (Qclone_number): Remove declaration.
3344 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3345
3349e122
SM
33462011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3347
3348 Add multiple inheritance to keymaps.
3349 * keymap.c (Fmake_composed_keymap): New function.
3350 (Fset_keymap_parent): Simplify.
3351 (fix_submap_inheritance): Remove.
3352 (access_keymap_1): New function extracted from access_keymap to handle
3353 embedded parents and handle lists of maps.
3354 (access_keymap): Use it.
3355 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3356 (Fcopy_keymap): Handle embedded parents.
3357 (Fcommand_remapping, define_as_prefix): Simplify.
3358 (Fkey_binding): Simplify.
3359 (syms_of_keymap): Move minibuffer-local-completion-map,
3360 minibuffer-local-filename-completion-map,
3361 minibuffer-local-must-match-map, and
3362 minibuffer-local-filename-must-match-map to Elisp.
3363 (syms_of_keymap): Defsubr make-composed-keymap.
3364 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3365 (parse_menu_item): Trivial simplification.
3366
3279eb87
GM
33672011-07-01 Glenn Morris <rgm@gnu.org>
3368
3369 * Makefile.in (SETTINGS_LIBS): Fix typo.
3370
4550efdf
KI
33712011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3372
3373 * coding.c (Fencode_coding_string): Record the last coding system
3374 used, as the function doc string says (bug#8738).
3375
0949d2b6
JD
33762011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3377
3378 * xsettings.c (store_monospaced_changed): Take new font as arg and
3379 check for change against current_mono_font.
3380 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3381 (emacs_settings_constructor, emacs_settings_get_property)
3382 (emacs_settings_set_property, emacs_settings_class_init)
3383 (emacs_settings_init, gsettings_obj): Remove.
3384 (something_changedCB): New function for HAVE_GSETTINGS.
3385 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3386 with value as argument.
3387 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3388 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3389 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3390 "changed".
3391
3392 * xgselect.c: Add defined (HAVE_GSETTINGS).
3393 (xgselect_initialize): Ditto.
3394
3395 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3396 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3397 xg_select.
3398
bbc6b304
PE
33992011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3400
3401 * eval.c (struct backtrace): Simplify and port the data structure.
3402 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3403 signed bit field, as this assumption is not portable and it makes
3404 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3405 "char debug_on_exit : 1" as this is not portable either; instead,
3406 use the portable "unsigned int debug_on_exit : 1". Remove unused
3407 member evalargs. Remove obsolete comments about cc bombing out.
3408
9851bfc5
JD
34092011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3410
51bb811f 3411 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3412 Let HAVE_GSETTINGS override HAVE_GCONF.
3413 (store_monospaced_changed): New function.
3414 (EMACS_SETTINGS): A new type derived from GObject to handle
3415 GSettings notifications.
3416 (emacs_settings_constructor, emacs_settings_get_property)
3417 (emacs_settings_set_property, emacs_settings_class_init):
3418 New functions.
3419 (gsettings_client, gsettings_obj): New variables.
3420 (GSETTINGS_SCHEMA): New define.
3421 (something_changedCB): Call store_monospaced_changed.
3422 (init_gsettings): New function.
3423 (xsettings_initialize): Call init_gsettings.
3424 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3425 to NULL.
3426
640c8776 3427 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3428 GCONF_CFLAGS/LIBS.
3429
5386012d
MR
34302011-06-29 Martin Rudalics <rudalics@gmx.at>
3431
3432 * window.c (resize_root_window, grow_mini_window)
3433 (shrink_mini_window): Rename Qresize_root_window to
3434 Qwindow_resize_root_window and Qresize_root_window_vertically to
3435 Qwindow_resize_root_window_vertically.
3436
f13e0b08
PE
34372011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3438
3439 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3440
94515237
JB
34412011-06-27 Juanma Barranquero <lekktu@gmail.com>
3442
3443 * makefile.w32-in: Redesign dependencies so they reflect more
3444 clearly which files are directly included by each source file,
3445 and not through other includes.
3446
e43b6e43
MR
34472011-06-27 Martin Rudalics <rudalics@gmx.at>
3448
3449 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3450 (sort_overlays, overlay_strings): When an overlay's clone number
3451 matches the window's clone number process the overlay even if
3452 the overlay's window property doesn't match the current window.
3453
d68443dc
MR
3454 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3455 (Fwindow_hchild): Rename to Fwindow_left_child.
3456 (Fwindow_next): Rename to Fwindow_next_sibling.
3457 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3458 (resize_window_check): Rename to window_resize_check.
3459 (resize_window_apply): Rename to window_resize_apply.
3460 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3461 (Fdelete_other_windows_internal, resize_frame_windows)
3462 (Fsplit_window_internal, Fdelete_window_internal)
3463 (grow_mini_window, shrink_mini_window)
3464 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3465
c7e73be5
JD
34662011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3467
3468 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3469 (emacs_fixed_set_min_size): Remove.
3470 (emacs_fixed_new): Take frame as argument.
3471
3472 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3473 (_EmacsFixedPrivate): Remove minwidth/height.
3474 Add struct frame *f.
3475 (emacs_fixed_init): Initialize priv->f.
3476 (get_parent_class, emacs_fixed_set_min_size): Remove.
3477 (emacs_fixed_new): Set priv->f to argument.
3478 (emacs_fixed_get_preferred_width)
3479 (emacs_fixed_get_preferred_height): Use min_width/height from
3480 frames size_hint to set minimum and natural (Bug#8919).
3481 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3482 and use min_width/height from frames size_hint to set
3483 min_width/height (Bug#8919).
3484
3485 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3486 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3487 Fix indentation.
c7e73be5 3488
cf99dcf8
EZ
34892011-06-26 Eli Zaretskii <eliz@gnu.org>
3490
3491 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3492 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3493 called at ZV.
3494
029529ac
CY
34952011-06-26 Chong Yidong <cyd@stupidchicken.com>
3496
3497 * process.c (wait_reading_process_output): Bypass select if
3498 waiting for a cell while ignoring keyboard input, and input is
3499 pending. Suggested by Jan Djärv (Bug#8869).
3500
7a7ef429
PE
35012011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3502
3503 Use gnulib's dup2 module instead of rolling our own.
3504 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3505
11fdef7d 35062011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3507
3508 * dispnew.c (scrolling_window): Before scrolling, turn off a
3509 mouse-highlight in the window being scrolled.
3510
cd3520a4
JB
35112011-06-24 Juanma Barranquero <lekktu@gmail.com>
3512
3513 Move DEFSYM to lisp.h and use everywhere.
3514
3515 * character.h (DEFSYM): Move declaration...
3516 * lisp.h (DEFSYM): ...here.
3517
3518 * gnutls.c:
3519 * minibuf.c:
3520 * w32menu.c:
3521 * w32proc.c:
3522 * w32select.c: Don't include character.h.
3523
3524 * alloc.c (syms_of_alloc):
3525 * buffer.c (syms_of_buffer):
3526 * bytecode.c (syms_of_bytecode):
3527 * callint.c (syms_of_callint):
3528 * casefiddle.c (syms_of_casefiddle):
3529 * casetab.c (init_casetab_once):
3530 * category.c (init_category_once, syms_of_category):
3531 * ccl.c (syms_of_ccl):
3532 * cmds.c (syms_of_cmds):
3533 * composite.c (syms_of_composite):
3534 * dbusbind.c (syms_of_dbusbind):
3535 * dired.c (syms_of_dired):
3536 * dispnew.c (syms_of_display):
3537 * doc.c (syms_of_doc):
3538 * editfns.c (syms_of_editfns):
3539 * emacs.c (syms_of_emacs):
3540 * eval.c (syms_of_eval):
3541 * fileio.c (syms_of_fileio):
3542 * fns.c (syms_of_fns):
3543 * frame.c (syms_of_frame):
3544 * fringe.c (syms_of_fringe):
3545 * insdel.c (syms_of_insdel):
3546 * keymap.c (syms_of_keymap):
3547 * lread.c (init_obarray, syms_of_lread):
3548 * macros.c (syms_of_macros):
3549 * msdos.c (syms_of_msdos):
3550 * print.c (syms_of_print):
3551 * process.c (syms_of_process):
3552 * search.c (syms_of_search):
3553 * sound.c (syms_of_sound):
3554 * syntax.c (init_syntax_once, syms_of_syntax):
3555 * terminal.c (syms_of_terminal):
3556 * textprop.c (syms_of_textprop):
3557 * undo.c (syms_of_undo):
3558 * w32.c (globals_of_w32):
3559 * window.c (syms_of_window):
3560 * xdisp.c (syms_of_xdisp):
3561 * xfaces.c (syms_of_xfaces):
3562 * xfns.c (syms_of_xfns):
3563 * xmenu.c (syms_of_xmenu):
3564 * xsettings.c (syms_of_xsettings):
3565 * xterm.c (syms_of_xterm): Use DEFSYM.
3566
4228cf16
TZ
35672011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3568
cd3520a4 3569 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3570
7fcccf1e
PE
35712011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3572
7efb4e0e
PE
3573 Integer and buffer overflow fixes (Bug#8873).
3574
ff5844ad
PE
3575 * print.c (printchar, strout): Check for string overflow.
3576 (PRINTPREPARE, printchar, strout):
3577 Don't set size unless allocation succeeds.
3578
90532f02
PE
3579 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3580 for sizes. Check for string overflow more accurately.
3581 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3582
6d84508d
PE
3583 * macros.c: Integer and buffer overflow fixes.
3584 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3585 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3586 Use ptrdiff_t, not int, for sizes.
3587 Don't increment bufsize until after realloc succeeds.
3588 Check for size-calculation overflow.
3589 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3590
437b2cb4
PE
3591 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3592
8b9ac8b4
PE
3593 * lread.c: Integer overflow fixes.
3594 (read_integer): Radix is now EMACS_INT, not int,
3595 to improve quality of diagnostics for out-of-range radices.
3596 Calculate buffer size correctly for out-of-range radices.
3597 (read1): Check for integer overflow in radices, and in
3598 read-circle numbers.
82cb60d3
PE
3599 (read_escape): Avoid int overflow.
3600 (Fload, openp, read_buffer_size, read1)
3601 (substitute_object_recurse, read_vector, read_list, map_obarray):
3602 Use ptrdiff_t, not int, for sizes.
3603 (read1): Use EMACS_INT, not int, for sizes.
20270765 3604 Check for size overflow.
8b9ac8b4 3605
7fcccf1e
PE
3606 * image.c (cache_image): Check for size arithmetic overflow.
3607
bfbbd7e7
PE
3608 * lread.c: Integer overflow issues.
3609 (saved_doc_string_size, saved_doc_string_length)
3610 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3611 Now ptrdiff_t, not int.
3612 (read1): Don't assume doc string length fits in int. Check for
3613 out-of-range doc string lengths.
3614 (read_list): Don't assume file position fits in int.
39019e54 3615 (read_escape): Check for hex character overflow.
bfbbd7e7 3616
4e323265
LL
36172011-06-22 Leo Liu <sdl.web@gmail.com>
3618
3619 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3620 Move to minibuffer.el.
3621
85fece3e
PE
36222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3623
20b84ce9 3624 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3625 The following patches are for when GLYPH_DEBUG && !XASSERT.
3626 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3627 * dispnew.c (flush_stdout):
3628 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3629 Mark as externally visible.
3630 * dispnew.c (check_window_matrix_pointers): Now static.
3631 * dispnew.c (window_to_frame_vpos):
3632 * xfns.c (unwind_create_frame):
3633 * xterm.c (x_check_font): Remove unused local.
3634 * scroll.c (CHECK_BOUNDS):
3635 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3636 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3637 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3638 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3639 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3640 Now static.
3641 (debug_method_add): Use va_list and vsprintf rather than relying
3642 on undefined behavior with wrong number of arguments.
3643 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3644 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3645 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3646 since we're not interested in debugging glyphs with old libraries.
3647 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3648 GCC 4.6.0's static checking.
3649
0766b489
PE
36502011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3651
31fd4b32
PE
3652 Integer overflow and signedness fixes (Bug#8873).
3653 A few related buffer overrun fixes, too.
3654
b79e8648
PE
3655 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3656
0766b489
PE
3657 * dispextern.h (struct face.stipple):
3658 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3659 (x_bitmap_mask, x_allocate_bitmap_record)
3660 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3661 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3662 (x_create_bitmap_from_xpm_data):
3663 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3664 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3665 (.bitmaps_last):
3666 * xfaces.c (load_pixmap):
3667 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3668 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3669 (.bitmaps_last, struct x_output.icon_bitmap):
3670 Use ptrdiff_t, not int, for bitmap indexes.
3671 (x_allocate_bitmap_record): Check for size overflow.
3672 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3673
b081724f
PE
3674 Use ptrdiff_t, not int, for overlay counts.
3675 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3676 * editfns.c (overlays_around, get_pos_property):
3677 * textprop.c (get_char_property_and_overlay):
3678 * xdisp.c (next_overlay_change, note_mouse_highlight):
3679 * xfaces.c (face_at_buffer_position):
21514da7
PE
3680 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3681 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3682 (Fnext_overlay_change, Fprevious_overlay_change)
3683 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3684 Use ptrdiff_t, not int, for sizes.
21514da7 3685 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3686
3de73e5e
PE
3687 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3688
2606c57b
PE
3689 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3690 (x_session_initialize): Do not assume string length fits in int.
3691
aaafe47a
PE
3692 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3693 This is unlikely, but can occur if DPI is outlandish.
3694
2674ddc8 3695 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3696 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3697
28154962
PE
3698 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3699 * xrdb.c (magic_file_p, search_magic_path):
3700 Omit last arg SUFFIX; it was always 0. All callers changed.
3701 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3702
7de51af5
PE
3703 * xfont.c (xfont_match): Avoid need for strlen.
3704
25ed6cc3
PE
3705 * xfns.c: Don't assume strlen fits in int.
3706 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3707
4eab31dd
PE
3708 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3709 not unsigned long, as we prefer signed integers. All callers changed.
3710 Detect integer overflow in repeat count.
3711 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3712 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3713
171e2a58
PE
3714 * termcap.c: Don't assume sizes fit in int and never overflow.
3715 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3716 (gobble_line): Check for size-calculation overflow.
3717
ad39faca 3718 * minibuf.c (Fread_buffer):
6e5bb2dc 3719 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3720 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3721 Don't assume string length fits in int.
3722
52c61c22 3723 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3724 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3725
b5b8c9e5
PE
3726 * font.c: Don't assume string length fits in int.
3727 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3728 Use ptrdiff_t, not int.
ccd6111c
PE
3729 (font_intern_prop): Don't assume string length fits in int.
3730 Don't assume integer property fits in fixnum.
3731 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3732
882f0d81 3733 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3734 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3735 Reformulate so as not to need the command string.
3736 Invoke gzip -cd rather than gunzip, as it's more portable.
3737 (lock_info_type, lock_file_1, lock_file):
3738 Don't assume pid_t and time_t fit in unsigned long.
3739 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3740 (current_lock_owner): Prefer signed type for sizes.
3741 Use memcpy, not strncpy, where memcpy is what is really wanted.
3742 Don't assume (via atoi) that time_t and pid_t fit in int.
3743 Check for time_t and/or pid_t out of range, e.g., via a network share.
3744 Don't alloca where an auto var works fine.
3745
93f4cf88
PE
3746 * fileio.c: Fix some integer overflow issues.
3747 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3748 Don't assume string length fits in int.
3749 (directory_file_name): Don't assume string length fits in long.
3750 (make_temp_name): Don't assume pid fits in int, or that its print
3751 length is less than 20.
3752
f3e92b69
PE
3753 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3754
1bfdaf10
PE
3755 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3756
35016e9a
PE
3757 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3758
3d1e65a1
PE
3759 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3760 We prefer signed integers, even for size calculations.
3761
0b963a93
PE
3762 * emacs.c: Don't assume string length fits in 'int'.
3763 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3764 (main): Don't invoke strlen when not needed.
3765
573f4b54
PE
3766 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3767 (XD_DEBUG_MESSAGE): Don't waste a byte.
3768
989f33ba
PE
3769 * callproc.c (getenv_internal_1, getenv_internal)
3770 (Fgetenv_internal):
965d34eb
PE
3771 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3772
e4d29b33
PE
3773 * lread.c (invalid_syntax): Omit length argument.
3774 All uses changed. This doesn't fix a bug, but it simplifies the
3775 code away from its former Hollerith-constant appearance, and it's
3776 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3777 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3778
eb49b136
PE
3779 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3780 This didn't break anything, but it didn't help either.
3781 It's confusing to put a bogus integer in a place where the actual
3782 value does not matter.
9f62aeb1 3783 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3784 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3785
15375a22
PE
3786 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3787 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3788 implementation.
b61cc01c
PE
3789 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3790 We prefer signed types, and the value cannot exceed the EMACS_INT
3791 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3792 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3793 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3794 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3795
53b2623d
PE
3796 * indent.c (sane_tab_width): New function.
3797 (current_column, scan_for_column, Findent_to, position_indentation)
3798 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3799 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3800
51cab52b 3801 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3802
f2ed8a70
PE
3803 * lisp.h (lint_assume): New macro.
3804 * composite.c (composition_gstring_put_cache):
3805 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3806
abe80cc6
PE
3807 * editfns.c, insdel.c:
3808 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3809
b02c740e
PE
3810 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3811
ebc96716
PE
3812 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3813
b4e50fa0 3814 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3815 Use much-faster test for byte-length change.
311d5d7c 3816 Don't assume string byte-length fits in 'int'.
a4cf38e4 3817 Check that character arg fits in 'int'.
85461888 3818 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3819
c0c1ee9f
PE
3820 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3821
a498d7f4
PE
3822 * fns.c (concat): Catch string overflow earlier.
3823 Do not rely on integer wraparound.
3824
51cab52b
PE
3825 * dispextern.h (struct it.overlay_strings_charpos)
3826 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3827 * xdisp.c (forward_to_next_line_start)
3828 (back_to_previous_visible_line_start)
3829 (reseat_at_next_visible_line_start, next_element_from_buffer):
3830 Don't arbitrarily truncate the value of 'selective' to int.
3831
76031fad
PE
3832 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3833
5eb55db9
PE
3834 * composite.c: Don't truncate sizes to 'int'.
3835 (composition_gstring_p, composition_reseat_it)
3836 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3837 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3838 not EMACS_UINT, for indexes.
5eb55db9 3839
0703a717
PE
3840 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3841
d6202519
PE
3842 * buffer.c: Include <verify.h>.
3843 (struct sortvec.priority, struct sortstr.priority):
8961a454 3844 Now EMACS_INT, not int.
c20998a7 3845 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3846 (struct sortstr.size, record_overlay_string)
3847 (struct sortstrlist.size, struct sortlist.used):
3848 Don't truncate size to int.
3849 (record_overlay_string): Check for size-calculation overflow.
d6202519 3850 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3851
d5a19415
JM
38522011-06-22 Jim Meyering <meyering@redhat.com>
3853
029529ac 3854 Don't leak an XBM-image-sized buffer
d5a19415
JM
3855 * image.c (xbm_load): Free the image buffer after using it.
3856
a9041e6c
PE
38572011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 Port to Sun C.
3860 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3861 that Sun C diagnosed.
3862 * fns.c (secure_hash): Fix pointer signedness issue.
3863 * intervals.c (static_offset_intervals): New function.
3864 (offset_intervals): Use it.
3865
7f3f739f
LL
38662011-06-21 Leo Liu <sdl.web@gmail.com>
3867
3868 * deps.mk (fns.o):
3869 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3870 sha512.h.
3871
3872 * fns.c (secure_hash): Rename from crypto_hash_function and change
3873 the first arg to accept symbols.
5b66d427 3874 (Fsecure_hash): New primitive.
7f3f739f
LL
3875 (syms_of_fns): New symbols.
3876
76147d94
DD
38772011-06-20 Deniz Dogan <deniz@dogan.se>
3878
3879 * process.c (Fset_process_buffer): Clarify return value in
3880 docstring.
3881
7d7d0045
CY
38822011-06-18 Chong Yidong <cyd@stupidchicken.com>
3883
3884 * dispnew.c (add_window_display_history): Use BVAR.
3885
3886 * xdisp.c (debug_method_add): Use BVAR.
3887 (check_window_end, dump_glyph_matrix, dump_glyph)
3888 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3889
3890 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3891 Likewise.
3892
3893 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3894 check till after the cache is created in init_frame_faces.
3895
ff2bc410
SM
38962011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3897
3898 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3899
28177add
PE
39002011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3901
dd3482fe
PE
3902 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3903 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3904 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3905
393d71f3 3906 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3907 * fileio.c (Finsert_file_contents):
3908 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3909 Remove the old (too-loose) buffer overflow checks.
3910 They weren't needed, since make_gap checks for buffer overflow.
3911 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3912 The old code merely checked for Emacs fixnum overflow, and relied
3913 on undefined (wraparound) behavior. The new code avoids undefined
3914 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3915
2e6813b0 3916 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3917 Tune. Don't use wider integers than needed. Don't use alloca.
3918 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3919
599a9e4f
PE
3920 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3921
99561444
PE
3922 * insdel.c, lisp.h (buffer_overflow): New function.
3923 (insert_from_buffer_1, replace_range, replace_range_2):
3924 * insdel.c (make_gap_larger):
3925 * editfns.c (Finsert_char):
3926 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3927
28177add
PE
3928 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3929
e69dafad
PE
39302011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3931
a7af7fde 3932 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3933
b1c46f02
PE
3934 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3935 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3936
e69dafad
PE
3937 * fileio.c: Don't assume EMACS_INT fits in off_t.
3938 (emacs_lseek): New static function.
3939 (Finsert_file_contents, Fwrite_region): Use it.
3940 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3941
566684ea
PE
3942 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3943
e6966cd6
PE
3944 * fns.c: Don't overflow int when computing a list length.
3945 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3946 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3947 truncation on 64-bit hosts. Check for QUIT every
3948 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3949 faster and is responsive enough.
3950 (Flength): Report an error instead of overflowing an integer.
3951 (Fsafe_length): Return a float if the value is not representable
3952 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3953 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3954 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3955
dd0b0efb
PE
3956 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3957 (header_size, word_size): New constants.
3958 (allocate_vectorlike): Don't check size overflow here.
3959 (allocate_vector): Check it here instead, since this is the only
3960 caller of allocate_vectorlike that could cause overflow.
3961 Check that the new vector's length is representable as a fixnum.
3962
86fe5cfe
PE
3963 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3964 The previous code was bogus. For example, next_almost_prime (32)
3965 returned 39, which is undesirable as it is a multiple of 3; and
3966 next_almost_prime (24) returned 25, which is a multiple of 5 so
3967 why was the code bothering to check for multiples of 7?
3968
80e88859
PE
3969 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3970
4a2f0ad6
PE
3971 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3972
f66c7cf8
PE
3973 Variadic C functions now count arguments with ptrdiff_t.
3974 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3975 Back then I didn't know that the Emacs coding style prefers signed int.
3976 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3977 were being counted with int, which may truncate counts on 64-bit
3978 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3979 * lisp.h (struct Lisp_Subr.function.aMANY)
3980 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3981 Arg counts are now ptrdiff_t, not size_t.
3982 All variadic functions and their callers changed accordingly.
3983 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3984 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3985 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3986 * callint.c (Fcall_interactively): Check arg count for overflow,
3987 to avoid potential buffer overrun. Use signed char, not 'int',
3988 for 'varies' array, so that we needn't bother to check its size
3989 calculation for overflow.
3990 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3991 * eval.c (apply_lambda):
3992 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3993 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3994 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3995
a1759b76
PE
3996 * callint.c (Fcall_interactively): Don't use index var as event count.
3997
d96be9fc
PE
3998 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3999 * mem-limits.h (SIZE): Remove; no longer used.
4000
a690a978 4001 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4002
578c21e6
PE
4003 Remove unnecessary casts.
4004 * xterm.c (x_term_init):
4005 * xfns.c (x_set_border_pixel):
4006 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4007 These aren't needed now that we assume ANSI C.
4008
96f53c6c
PE
4009 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4010 It's more likely to cause problems (due to unsigned overflow)
4011 than to cure them.
4012
83c77d31
PE
4013 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4014
ee2079f1
PE
4015 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4016
6da65536
PE
4017 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4018
7147c4a4
PE
4019 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4020
193e32d9
PE
4021 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4022
e5533da6
PE
4023 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4024
9910e595
PE
4025 GLYPH_CODE_FACE returns EMACS_INT, not int.
4026 * dispextern.h (merge_faces):
4027 * xfaces.c (merge_faces):
01103c44
PE
4028 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4029 Don't assume EMACS_INT fits in int.
9910e595 4030
2638320e
PE
4031 * character.h (CHAR_VALID_P): Remove unused parameter.
4032 * fontset.c, lisp.h, xdisp.c: All uses changed.
4033
045eb8d9
PE
4034 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4035
c1f134b5
PE
4036 * fns.c (concat): Minor tuning based on overflow analysis.
4037 This doesn't fix any bugs. Use int to hold character, instead
4038 of constantly refetching from Emacs object. Use XFASTINT, not
4039 XINT, for value known to be a character. Don't bother comparing
4040 a single byte to 0400, as it's always less.
4041
395fcb93 4042 * floatfns.c (Fexpt):
327eeec8
PE
4043 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4044
abbd3d23
PE
4045 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4046 for characters.
4047
684a03ef
PE
4048 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4049
0fed43f3
PE
4050 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4051 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4052 incorrectly succeed when S was a string, because 4294967386 was
4053 truncated before it was used.
4054
8fd02eb7
PE
4055 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4056 Otherwise, an out-of-range integer could cause undefined behavior
4057 on a 64-bit host.
4058
f8c86b69
PE
4059 * composite.c: Use int, not EMACS_INT, for characters.
4060 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4061 EMACS_INT, for values that are known to be in character range.
4062 This doesn't fix any bugs but is the usual style inside Emacs and
4063 may generate better code on 32-bit machines.
4064
34206dd2
PE
4065 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4066 This is for reasons similar to the recent CHAR_STRING fix.
4067 * charset.c (Fencode_char): Check that character arg is actually
4068 a character. Pass an int to ENCODE_CHAR.
4069 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4070 wider than 'int', as a compile-time check to prevent future regressions
4071 in this area.
4072
c5958d4c 4073 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4074
4075 Make sure a 64-bit char is never passed to CHAR_STRING.
4076 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4077 by silently ignoring the top 32 bits, allowing some values
4078 that were far too large to be valid characters.
4079 * character.h: Include <verify.h>.
4080 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4081 arguments are no wider than unsigned, as a compile-time check
4082 to prevent future regressions in this area.
4083 * data.c (Faset):
01103c44 4084 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4085 (Fsubst_char_in_region):
4086 * fns.c (concat):
4087 * xdisp.c (decode_mode_spec_coding):
4088 Adjust to CHAR_STRING's new requirement.
4089 * editfns.c (Finsert_char, Fsubst_char_in_region):
4090 * fns.c (concat): Check that character args are actually
4091 characters. Without this test, these functions did the wrong
4092 thing with wildly out-of-range values on 64-bit hosts.
4093
d37ca623
PE
4094 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4095 These casts should not be needed on 32-bit hosts, either.
4096 * keyboard.c (read_char):
4097 * lread.c (Fload): Remove casts to unsigned.
4098
ea204efb
PE
4099 * lisp.h (UNSIGNED_CMP): New macro.
4100 This fixes comparison bugs on 64-bit hosts.
4101 (ASCII_CHAR_P): Use it.
4102 * casefiddle.c (casify_object):
01103c44 4103 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4104 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4105 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4106 * dispextern.h (FACE_FROM_ID):
4107 * keyboard.c (read_char): Use UNSIGNED_CMP.
4108
41cb286c
PE
4109 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4110 not to EMACS_INT, to avoid GCC warning.
4111
4a1b9832
PE
4112 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4113
55daad71
PE
4114 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4115 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4116 isn't needed on 32-bit machines.
8f95c75c 4117
01103c44
PE
4118 * buffer.c (Fgenerate_new_buffer_name):
4119 Use EMACS_INT for count, not int.
0ceccced 4120 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4121
4122 * data.c (Qcompiled_function): Now static.
4123
c6f072e7
PE
4124 * window.c (window_body_lines): Now static.
4125
20ce5912
PE
4126 * image.c (gif_load): Rename local to avoid shadowing.
4127
9c4c5f81
PE
4128 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4129 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4130 * alloc.c (make_save_value): Integer argument is now of type
4131 ptrdiff_t, not int.
4132 (mark_object): Use ptrdiff_t, not int.
4133 * lisp.h (pD): New macro.
4134 * print.c (print_object): Use it.
4135
c0c5c8ae
PE
4136 * alloc.c: Use EMACS_INT, not int, to count objects.
4137 (total_conses, total_markers, total_symbols, total_vector_size)
4138 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4139 (total_free_floats, total_floats, total_free_intervals)
4140 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4141 Now EMACS_INT, not int. All uses changed.
4142 (Fgarbage_collect): Compute overall total using a double, so that
4143 integer overflow is less likely to be a problem. Check for overflow
4144 when converting back to an integer.
5a25e253
PE
4145 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4146 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4147 These were 'int' variables that could overflow on 64-bit hosts;
4148 they were never used, so remove them instead of repairing them.
211a0b2a 4149 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4150 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4151 Previously, this ceilinged at INT_MAX, but that doesn't work on
4152 64-bit machines.
e46bb31a 4153 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4154
c78baabf 4155 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4156 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4157 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4158 when a (possibly-narrower) signed value would do just as well.
4159 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4160
c9d624c6
PE
4161 * alloc.c: Catch some string size overflows that we were missing.
4162 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4163 for convenience in STRING_BYTES_MAX.
4164 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4165 The definition here is exact; the one in lisp.h was approximate.
4166 (allocate_string_data): Check for string overflow. This catches
4167 some instances we weren't catching before. Also, it catches
4168 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4169 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4170 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4171
c9d624c6
PE
4172 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4173 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4174 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4175
353032ce
PE
4176 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4177
2bccce07
PE
4178 * alloc.c (Fmake_string): Check for out-of-range init.
4179
0ac30604
SM
41802011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4181
4182 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4183
c195f2de
JD
41842011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4185
4186 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4187 xg_get_default_scrollbar_width.
4188
4189 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4190 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4191 (style_changed_cb): Call update_theme_scrollbar_width and call
4192 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4193 all frames (Bug#8505).
4194 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4195 Call gtk_window_set_resizable if HAVE_GTK3.
4196 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4197 and height if HAVE_GTK3 (Bug#8505).
4198 (scroll_bar_width_for_theme): New variable.
4199 (update_theme_scrollbar_width): New function.
4200 (xg_get_default_scrollbar_width): Move code to
4201 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4202 (xg_initialize): Call update_theme_scrollbar_width.
4203
4204 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4205
4206 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4207
e10ac9f1
MR
42082011-06-12 Martin Rudalics <rudalics@gmx.at>
4209
4210 * frame.c (make_frame): Call other_buffer_safely instead of
4211 other_buffer.
4212
4213 * window.c (temp_output_buffer_show): Call display_buffer with
4214 second argument Vtemp_buffer_show_specifiers and reset latter
4215 immediately after the call.
4216 (Vtemp_buffer_show_specifiers): New variable.
4217 (auto_window_vscroll_p, next_screen_context_lines)
4218 (Vscroll_preserve_screen_position): Remove leading asterisks from
4219 doc-strings.
4220
2d3c217e 42212011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4222
7b7f97e8 4223 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4224 * buffer.c (Qclone_number): Remove for now, as it's unused.
4225 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4226 (record_buffer): Remove unused local.
4227 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4228 (set_frame_buffer_list): Remove; unused.
4229 * frame.h (other_visible_frames): Remove decl.
4230 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4231 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4232 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4233 if HAVE_GPM.
4234 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4235 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4236 Define only if HAVE_GPM.
4237 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4238 (update_hints_inhibit): Remove; never set. All uses removed.
4239 * widgetprv.h (emacsFrameClassRec): Remove decl.
4240 * window.c (delete_deletable_window): Now returns void, since it
4241 wasn't returning anything.
4242 (compare_window_configurations): Remove unused locals.
4243 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4244 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4245 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4246 the same widths as pointers. This follows up on the 2011-05-06 patch.
4247 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4248 * xterm.h: Likewise.
4249 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4250
1384b89e
JB
42512011-06-12 Juanma Barranquero <lekktu@gmail.com>
4252
4253 * makefile.w32-in: Update dependencies.
4254 (LISP_H): Add lib/intprops.h.
4255
1100a63c
CY
42562011-06-11 Chong Yidong <cyd@stupidchicken.com>
4257
4258 * image.c (gif_load): Add animation frame delay to the metadata.
4259 (syms_of_image): Use DEFSYM. New symbol `delay'.
4260
6198ccd0
MR
42612011-06-11 Martin Rudalics <rudalics@gmx.at>
4262
4263 * window.c (delete_deletable_window): Re-add.
4264 (Fset_window_configuration): Rewrite to handle dead buffers and
4265 consequently deletable windows.
4266 (window_tree, Fwindow_tree): Remove. Supply functionality in
4267 window.el.
4268 (compare_window_configurations): Simplify code.
4269
b6e3633c
AS
42702011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4271
1ab0dee5
AS
4272 * image.c (imagemagick_load_image): Fix type mismatch.
4273 (Fimagemagick_types): Likewise.
4274
b6e3633c
AS
4275 * window.h (replace_buffer_in_windows): Declare.
4276
9397e56f
MR
42772011-06-11 Martin Rudalics <rudalics@gmx.at>
4278
4279 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4280 Qclone_number. Remove external declaration of Qdelete_window.
4281 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4282 code.
640c8776
SM
4283 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4284 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4285 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4286 buffer list implementation.
4287 (other_buffer_safely): New function.
4288 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4289 calls to replace_buffer_in_windows and
4290 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4291 if allowed.
4292 (record_buffer): Inhibit quitting and rewrite using quittable
4293 functions. Run Qbuffer_list_update_hook if allowed.
4294 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4295 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4296 Move switch-to-buffer to window.el.
9397e56f
MR
4297 (bury-buffer): Move to window.el.
4298 (Vbuffer_list_update_hook): New variable.
4299
4300 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4301 section.
4302
4303 * window.h (resize_frame_windows): Move up in code.
4304 (Fwindow_frame): Remove EXFUN.
4305 (replace_buffer_in_all_windows): Remove prototype.
4306 (replace_buffer_in_windows_safely): Add prototype.
4307
4308 * window.c: Declare Qdelete_window static again. Move down
4309 declaration of select_count.
4310 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4311 (Fother_window): Move to window.el.
4312 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4313 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4314 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4315 window.el.
4316 (replace_buffer_in_windows): Implement by calling
4317 Qreplace_buffer_in_windows.
4318 (replace_buffer_in_all_windows): Remove with some functionality
4319 moved into replace_buffer_in_windows_safely.
4320 (replace_buffer_in_windows_safely): New function.
4321 (select_window_norecord, select_frame_norecord): Move in front
4322 of run_window_configuration_change_hook. Remove now obsolete
4323 declarations.
640c8776
SM
4324 (Fset_window_buffer): Rewrite doc-string.
4325 Call Qrecord_window_buffer.
9397e56f
MR
4326 (keys_of_window): Move binding for other-window to window.el.
4327
b50691aa
CY
43282011-06-11 Chong Yidong <cyd@stupidchicken.com>
4329
4330 * dispextern.h (struct image): Replace data member, whose int_val
4331 and ptr_val fields were not used by anything, with a single
4332 lisp_val object.
4333
4334 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4335 (gif_clear_image, gif_load, imagemagick_load_image)
4336 (gs_clear_image, gs_load): Callers changed.
4337
3f754b86
PE
43382011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4339
cca69397
PE
4340 * buffer.h: Include <time.h>, for time_t.
4341 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4342
109e28d0
PE
4343 Fix minor problems found by static checking.
4344
60737f02
PE
4345 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4346
4b66faf3
PE
4347 Make identifiers static if they are not used in other modules.
4348 * data.c (Qcompiled_function, Qframe, Qvector):
4349 * image.c (QimageMagick, Qsvg):
4350 * minibuf.c (Qmetadata):
4351 * window.c (resize_window_check, resize_root_window): Now static.
4352 * window.h (resize_window_check, resize_root_window): Remove decls.
4353
109e28d0
PE
4354 * window.c (window_deletion_count, delete_deletable_window):
4355 Remove; unused.
46a4ce9e
PE
4356 (window_body_lines): Now static.
4357 (Fdelete_other_windows_internal): Mark vars as initialized.
4358 Make sure 'resize_failed' is initialized.
4359 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4360 (resize_window_apply): Remove unused local.
4361 * window.h (delete_deletable_window): Remove decl.
4362
109e28d0 4363 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4364 (imagemagick_load_image): Fix pointer signedness problem by changing
4365 last arg from unsigned char * to char *. All uses changed.
4366 Also, fix a local for similar reasons.
4367 Remove unused locals. Remove locals to avoid shadowing.
4368 (fn_rsvg_handle_free): Remove; unused.
4369 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4370 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4371
3f754b86
PE
4372 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4373
2547adb1
CY
43742011-06-10 Chong Yidong <cyd@stupidchicken.com>
4375
4376 * image.c (gif_load): Fix omitted cast error introduced by
4377 2011-06-06 change.
4378
2c8e37d4
MR
43792011-06-10 Martin Rudalics <rudalics@gmx.at>
4380
4381 * window.h (resize_proportionally, orig_total_lines)
4382 (orig_top_line): Remove from window structure.
4383 (set_window_height, set_window_width, change_window_heights)
4384 (Fdelete_window): Remove prototypes.
4385 (resize_frame_windows): Remove duplicate declaration.
4386
440a42e3
EZ
43872011-06-10 Eli Zaretskii <eliz@gnu.org>
4388
4389 * window.h (resize_frame_windows, resize_window_check)
4390 (delete_deletable_window, resize_root_window)
4391 (resize_frame_windows): Declare prototypes.
4392
4393 * window.c (resize_window_apply): Make definition be "static" to
4394 match the prototype.
4395
562dd5e9
MR
43962011-06-10 Martin Rudalics <rudalics@gmx.at>
4397
4398 * window.c: Remove declarations of Qwindow_size_fixed,
4399 window_min_size_1, window_min_size_2, window_min_size,
4400 size_window, window_fixed_size_p, enlarge_window, delete_window.
4401 Remove static from declaration of Qdelete_window, it's
4402 temporarily needed by Fbury_buffer.
4403 (replace_window): Don't assign orig_top_line and
4404 orig_total_lines.
4405 (Fdelete_window, delete_window): Remove. Window deletion is
4406 handled by window.el.
640c8776
SM
4407 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4408 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4409 (Fdelete_other_windows): Remove. Deleting other windows is
4410 handled by window.el.
4411 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4412 handled in window.el.
4413 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4414 Window minimum sizes are handled in window.el.
4415 (shrink_windows, size_window, set_window_height)
4416 (set_window_width, change_window_heights, window_height)
4417 (window_width, CURBEG, CURSIZE, enlarge_window)
4418 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4419 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4420 handled in window.el.
4421 (make_dummy_parent): Rename to make_parent_window and give it a
4422 second argument horflag.
4423 (make_window): Don't set resize_proportionally any more.
4424 (Fsplit_window): Remove. Windows are split in window.el.
4425 (save_restore_action, save_restore_orig_size)
4426 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4427 Resize mini windows in window.el.
4428 (grow_mini_window, shrink_mini_window): Implement by calling
4429 Qresize_root_window_vertically, resize_window_check and
4430 resize_window_apply.
640c8776
SM
4431 (saved_window, Fset_window_configuration, save_window_save):
4432 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4433 resize_proportionally.
4434 (window_min_height, window_min_width): Move to window.el.
4435 (keys_of_window): Move bindings for delete-other-windows,
4436 split-window, delete-window and enlarge-window to window.el.
4437
4438 * buffer.c: Temporarily extern Qdelete_window.
4439 (Fbury_buffer): Temporarily call Qdelete_window instead of
4440 Fdelete_window (Fbury_buffer will move to window.el soon).
4441
4442 * frame.c (set_menu_bar_lines_1): Remove code handling
4443 orig_top_line and orig_total_lines.
4444
4445 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4446 set_window_height but set heights directly.
4447 (change_frame_size_1): Use resize_frame_windows.
4448
4449 * xdisp.c (init_xdisp): Don't use set_window_height but set
4450 heights directly.
4451
640c8776
SM
4452 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4453 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4454 run_window_configuration_change_hook.
4455
4456 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4457 instead of change_window_heights and run
4458 run_window_configuration_change_hook.
4459
1a13852e
MR
44602011-06-09 Martin Rudalics <rudalics@gmx.at>
4461
4462 * window.c (replace_window): Rename second argument REPLACEMENT to
4463 NEW. New third argument SETFLAG. Rewrite.
4464 (delete_window, make_dummy_parent): Call replace_window with
4465 third argument 1.
4466 (window_list_1): Move down in code.
4467 (run_window_configuration_change_hook): Move set_buffer part
4468 before select_frame_norecord part in order to unwind correctly.
4469 Rename count1 to count.
4470 (recombine_windows, delete_deletable_window, resize_root_window)
4471 (Fdelete_other_windows_internal)
4472 (Frun_window_configuration_change_hook, make_parent_window)
4473 (resize_window_check, resize_window_apply, Fresize_window_apply)
4474 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4475 (Fdelete_window_internal, Fresize_mini_window_internal):
4476 New functions.
1a13852e
MR
4477 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4478
f3d1777e
MR
44792011-06-08 Martin Rudalics <rudalics@gmx.at>
4480
496e208e
MR
4481 * window.h (window): Add some new members to window structure -
4482 normal_lines, normal_cols, new_total, new_normal, clone_number,
4483 splits, nest, prev_buffers, next_buffers.
4484 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4485 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4486
f3d1777e
MR
4487 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4488 Remove.
496e208e
MR
4489 (make_dummy_parent): Set new members of windows structure.
4490 (make_window): Move down in code. Handle new members of window
4491 structure.
4492 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4493 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4494 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4495 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4496 (Fset_window_next_buffers, Fset_window_clone_number):
4497 New functions.
496e208e
MR
4498 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4499 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4500 Doc-string fixes.
4501 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4502 Argument WINDOW can be now internal window too.
4503 (Fwindow_use_time): Move up in code.
4504 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4505 Rewrite doc-string.
4506 (Fset_window_configuration, saved_window)
4507 (Fcurrent_window_configuration, save_window_save): Handle new
4508 members of window structure.
b9e809c2
MR
4509 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4510 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4511 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4512 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4513 Qget_mru_window, Qresize_root_window,
4514 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4515 Qauto_buffer_name; staticpro them.
f3d1777e 4516
abde8f8c
MR
45172011-06-07 Martin Rudalics <rudalics@gmx.at>
4518
4519 * window.c (Fwindow_total_size, Fwindow_left_column)
4520 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4521 (Fwindow_list_1): New functions.
4522 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4523 (Fwindow_width, Fscroll_left, Fscroll_right):
4524 Use window_body_cols instead of window_box_text_cols.
4525 (delete_window, Fset_window_configuration):
4526 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4527 (delete_all_subwindows): Take a window as argument and not a
4528 structure. Rewrite.
190b47e6
MR
4529 (window_loop): Remove handling of GET_LRU_WINDOW and
4530 GET_LARGEST_WINDOW.
4531 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4532
4533 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4534 window_box_text_cols. delete_all_subwindows now takes a
4535 Lisp_Object as argument.
abde8f8c 4536
640c8776
SM
4537 * indent.c (compute_motion, Fcompute_motion):
4538 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4539
fa8a67e6
MR
4540 * frame.c (delete_frame): Call delete_all_subwindows with root
4541 window as argument.
4542
a54e3482
DC
45432011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4544
4545 * fns.c (Fputhash): Document return value.
4546
60002bf5
CY
45472011-06-06 Chong Yidong <cyd@stupidchicken.com>
4548
4549 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4550
0c671da6 45512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4552
b862a52a 4553 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4554
be44ca6c
PE
4555 Check for overflow when converting integer to cons and back.
4556 * charset.c (Fdefine_charset_internal, Fdecode_char):
4557 Use cons_to_unsigned to catch overflow.
4558 (Fencode_char): Use INTEGER_TO_CONS.
4559 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4560 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4561 * data.c (long_to_cons, cons_to_long): Remove.
4562 (cons_to_unsigned, cons_to_signed): New functions.
4563 These signal an error for invalid or out-of-range values.
4564 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4565 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4566 * font.c (Ffont_variation_glyphs):
4567 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4568 * lisp.h: Include <intprops.h>.
4569 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4570 (cons_to_signed, cons_to_unsigned): New decls.
4571 (long_to_cons, cons_to_long): Remove decls.
4572 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4573 (Fprimitive_undo): Use CONS_TO_INTEGER.
4574 * xfns.c (Fx_window_property): Likewise.
4575 * xselect.c: Include <limits.h>.
4576 (x_own_selection, selection_data_to_lisp_data):
4577 Use INTEGER_TO_CONS.
4578 (x_handle_selection_request, x_handle_selection_clear)
4579 (x_get_foreign_selection, Fx_disown_selection_internal)
4580 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4581 (lisp_data_to_selection_data): Use cons_to_unsigned.
4582 (x_fill_property_data): Use cons_to_signed.
4583 Report values out of range.
4584
d1f3d2af
PE
4585 Check for buffer and string overflow more precisely.
4586 * buffer.h (BUF_BYTES_MAX): New macro.
4587 * lisp.h (STRING_BYTES_MAX): New macro.
4588 * alloc.c (Fmake_string):
4589 * character.c (string_escape_byte8):
4590 * coding.c (coding_alloc_by_realloc):
4591 * doprnt.c (doprnt):
4592 * editfns.c (Fformat):
4593 * eval.c (verror):
4594 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4595 since they may not be the same number.
4596 * editfns.c (Finsert_char):
4597 * fileio.c (Finsert_file_contents):
4598 Likewise for BUF_BYTES_MAX.
4599
dd52fcea
PE
4600 * image.c: Use ptrdiff_t, not int, for sizes.
4601 (slurp_file): Switch from int to ptrdiff_t.
4602 All uses changed.
4603 (slurp_file): Check that file size fits in both size_t (for
4604 malloc) and ptrdiff_t (for sanity and safety).
4605
7f9bbdbb
PE
4606 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4607 if b->modtime has its maximal value.
4608
dfe18f82
PE
4609 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4610
84acfcf0
PE
4611 Don't assume time_t can fit into int.
4612 * buffer.h (struct buffer.modtime): Now time_t, not int.
4613 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4614 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4615
ccd9a01a
PE
4616 Minor fixes for signed vs unsigned integers.
4617 * character.h (MAYBE_UNIFY_CHAR):
4618 * charset.c (maybe_unify_char):
4619 * keyboard.c (read_char, reorder_modifiers):
4620 XINT -> XFASTINT, since the integer must be nonnegative.
4621 * ftfont.c (ftfont_spec_pattern):
4622 * keymap.c (access_keymap, silly_event_symbol_error):
4623 XUINT -> XFASTINT, since the integer must be nonnegative.
4624 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4625 since it makes no difference and we prefer signed.
4626 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4627 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4628 nonnegative.
4629
d6d100dd
SM
46302011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4631
4632 * window.h (Fwindow_frame): Declare.
4633
2b6148e4
PE
46342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4635
4636 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4637 (SPARE_MEMORY): Always define.
4638 (LARGE_REQUEST): Remove.
4639 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4640
f230ecc9
MR
46412011-06-06 Martin Rudalics <rudalics@gmx.at>
4642
727e958e
MR
4643 * lisp.h: Move EXFUNS for Fframe_root_window,
4644 Fframe_first_window and Fset_frame_selected_window to window.h.
4645
4646 * window.h: Move EXFUNS for Fframe_root_window,
4647 Fframe_first_window and Fset_frame_selected_window here from
4648 lisp.h.
4649
4650 * frame.c (Fwindow_frame, Fframe_first_window)
4651 (Fframe_root_window, Fframe_selected_window)
4652 (Fset_frame_selected_window): Move to window.c.
4653 (Factive_minibuffer_window): Move to minibuf.c.
4654 (Fother_visible_frames_p): New function.
4655
4656 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4657
f230ecc9
MR
4658 * window.c (decode_window, decode_any_window): Move up in code.
4659 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4660 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4661 (Fwindow_buffer): Move up and rewrite doc-string.
4662 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4663 (Fwindow_prev): New functions.
727e958e
MR
4664 (Fwindow_frame): Move here from frame.c. Accept any window as
4665 argument.
4666 (Fframe_root_window, Fframe_first_window)
4667 (Fframe_selected_window): Move here from frame.c. Accept frame
4668 or arbitrary window as argument. Update doc-strings.
4669 (Fminibuffer_window): Move up in code.
4670 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4671 (Fset_frame_selected_window): Move here from frame.c.
4672 Marginal rewrite.
727e958e
MR
4673 (Fselected_window, select_window, Fselect_window): Move up in
4674 code. Minor doc-string fixes.
f230ecc9 4675
4d09bcf6
PE
46762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4679 Do not assume that spare memory exists; that assumption is valid
4680 only if SYSTEM_MALLOC.
4681 (LARGE_REQUEST): New macro, so that the issue of large requests
4682 is separated from the issue of spare memory.
4683
810928a2
AS
46842011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4685
172418ad
AS
4686 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4687 format. (Bug#8806)
4688
43f862f7
AS
4689 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4690
810928a2
AS
4691 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4692 before statements.
4693
a059fe24
JD
46942011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4695
4696 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4697
4698 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4699
4700 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4701 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4702
989bf368
JB
47032011-06-05 Juanma Barranquero <lekktu@gmail.com>
4704
4705 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4706
4b80f674
CY
47072011-06-04 Chong Yidong <cyd@stupidchicken.com>
4708
4709 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4710 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4711 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4712 New error handlers.
4b80f674
CY
4713 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4714 Obey Vx_select_enable_clipboard_manager. Catch errors in
4715 x_clipboard_manager_save (Bug#8779).
4716 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4717 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4718
99a33b77 47192011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4720
4721 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4722
99a33b77 47232011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4724
4725 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4726 in the current matrix if keep_current_p is non-zero.
4727
8264569d
EZ
47282011-06-04 Eli Zaretskii <eliz@gnu.org>
4729
4730 * bidi.c (bidi_level_of_next_char): Fix last change.
4731
57f97249
EZ
47322011-06-03 Eli Zaretskii <eliz@gnu.org>
4733
fec2107c 4734 Support bidi reordering of text covered by display properties.
57f97249 4735
fec2107c
EZ
4736 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4737 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4738 (bidi_cache_search, bidi_cache_iterator_state)
4739 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4740 (bidi_level_of_next_char, bidi_move_to_visually_next):
4741 Support character positions inside a run of characters covered by a
fec2107c
EZ
4742 display string.
4743 (bidi_paragraph_init, bidi_resolve_explicit_1)
4744 (bidi_level_of_next_char): Call bidi_fetch_char and
4745 bidi_fetch_char_advance instead of FETCH_CHAR and
4746 FETCH_CHAR_ADVANCE.
4747 (bidi_init_it): Initialize new members.
4748 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4749 definitions.
4750 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4751 instead of using explicit *_CHAR codes.
d6d100dd
SM
4752 (bidi_resolve_explicit, bidi_resolve_weak):
4753 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4754 bidirectional text is supported only in multibyte buffers.
4755 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4756 it to initialize the frame_window_p member of struct bidi_it.
4757 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4758 (bidi_resolve_explicit, bidi_resolve_weak)
4759 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4760 bidi_it->nchars is non-positive.
4761 (bidi_level_of_next_char): Don't try to lookup the cache for the
4762 next/previous character if nothing is cached there yet, or if we
4763 were just reseat()'ed to a new position.
c40e2fb2 4764
0e14fe90
EZ
4765 * xdisp.c (set_cursor_from_row): Set start and stop points
4766 according to the row's direction when priming the loop that looks
4767 for the glyph on which to display cursor.
4768 (single_display_spec_intangible_p): Function deleted.
4769 (display_prop_intangible_p): Reimplement to call
4770 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4771 Accept 3 additional arguments needed by handle_display_spec.
4772 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4773 values: lists, `(when COND...)' forms, etc.
4774 (single_display_spec_string_p): Support property values that are
4775 lists with the argument STRING its top-level element.
4776 (display_prop_string_p): Fix the condition for processing a
4777 property that is a list to be consistent with handle_display_spec.
fec2107c 4778 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4779 last portion of handle_display_prop.
4780 (compute_display_string_pos): Accept additional argument
4781 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4782 value of a `display' property is a "replacing spec".
4783 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4784 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4785 the display property, but just return a value indicating whether
4786 the display property will replace the characters it covers.
4787 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4788 frame_window_p members of struct bidi_it.
d6d100dd
SM
4789 (compute_display_string_pos, compute_display_string_end):
4790 New functions.
fec2107c
EZ
4791 (push_it): Accept second argument POSITION, where pop_it should
4792 jump to continue iteration.
4793 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4794
fec2107c
EZ
4795 * keyboard.c (adjust_point_for_property): Adjust the call to
4796 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4797
4798 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4799 (bidi_init_it): Update prototypes.
4800 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4801 (compute_display_string_pos, compute_display_string_end):
4802 Declare prototypes.
fec2107c
EZ
4803 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4804 EMACS_INT.
fc6f18ce 4805
40087514 48062011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4807
57f53182
PE
4808 Malloc failure behavior now depends on size of allocation.
4809 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4810 * lisp.h: Change signatures accordingly.
4811 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4812 All callers changed. (Bug#8762)
4813
4814 * gnutls.c: Use Emacs's memory allocators.
4815 Without this change, the gnutls library would invoke malloc etc.
4816 directly, which causes problems on non-SYNC_INPUT hosts, and which
4817 runs afoul of improving memory_full behavior. (Bug#8761)
4818 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4819 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4820 xfree instead of the default malloc, realloc, free.
4821 (Fgnutls_boot): No need to check for memory allocation failure,
4822 since xmalloc does that for us.
4823
ac32cd99 4824 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4825 * category.c (hash_get_category_set):
4826 * ccl.c (ccl_driver):
4827 * charset.c (Fdefine_charset_internal):
4828 * charset.h (struct charset.hash_index):
4829 * composite.c (get_composition_id, gstring_lookup_cache)
4830 (composition_gstring_put_cache):
4831 * composite.h (struct composition.hash_index):
4832 * dispextern.h (struct image.hash):
4833 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4834 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4835 (hashfn_equal, hashfn_user_defined, make_hash_table)
4836 (maybe_resize_hash_table, hash_lookup, hash_put)
4837 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4838 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4839 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4840 * image.c (make_image, search_image_cache, lookup_image)
4841 (xpm_put_color_table_h):
4842 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4843 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4844 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4845 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4846 * alloc.c (allocate_vectorlike):
4847 Check for overflow in vector size calculations.
4848 * ccl.c (ccl_driver):
4849 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4850 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4851 need to be updated by these changes.
40087514
PE
4852 * fns.c (make_hash_table, maybe_resize_hash_table):
4853 Check for integer overflow with large hash tables.
0de4bb68
PE
4854 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4855 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4856 (SXHASH_REDUCE): New macro.
4857 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4858 Use it instead of discarding useful hash info with large hash values.
4859 (sxhash_float): New function.
4860 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4861 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4862 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4863 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4864 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4865 Adjust signatures to match updated version of code.
4866 (consing_since_gc): Now EMACS_INT, since a single hash table can
4867 use more than INT_MAX bytes.
4868
698d32e2
DN
48692011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4870
4871 Make it possible to build with GCC-4.6+ -O2 -flto.
4872
4873 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4874
fd6fa53f
SM
48752011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4876
4877 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4878 Call minibuffer-inactive-mode.
4879
864db017
JB
48802011-05-31 Juanma Barranquero <lekktu@gmail.com>
4881
4882 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4883 Update dependencies.
4884
2ad0baf4
DN
48852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4886
4887 * data.c (init_data): Remove code for UTS, this system is not
4888 supported anymore.
4889
4fcc2638
DN
48902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4891
4892 Don't force ./temacs to start in terminal mode.
4893
4894 * frame.c (make_initial_frame): Initialize faces in all cases, not
4895 only when CANNOT_DUMP is defined.
4896 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4897
c56e0fd5
DN
48982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4899
4900 * dispnew.c (add_window_display_history): Use const for the string
4901 pointer. Remove declaration, not needed.
4902
333d54da 49032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4904
55d4c1b2 4905 Use 'inline', not 'INLINE'.
333d54da 4906 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4907 * alloc.c, fontset.c (INLINE): Remove.
4908 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4909 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4910 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4911 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4912 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4913
738db178
DN
49142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4915
4916 Make it possible to run ./temacs.
4917
4918 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4919 syms_of_callproc does the same thing. Remove test for
4920 "initialized", do it in the caller.
4921 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4922
620c53a6
SM
49232011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4924
4925 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4926 (read_minibuf): Use get_minibuffer.
4927 (syms_of_minibuf): Use DEFSYM.
4928 (Qmetadata): New var.
4929 * data.c (Qbuffer): Don't make it static.
4930 (syms_of_data): Use DEFSYM.
4931
e003a292
PE
49322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4933
4934 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4935 (CCL_CODE_MIN): New macro.
4936
ed008a6d
PE
49372011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4938
3687c2ef
PE
4939 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4940
ed008a6d
PE
4941 * eval.c (Qdebug): Now static.
4942 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4943 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4944 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4945
d66c4c7c
CY
49462011-05-29 Chong Yidong <cyd@stupidchicken.com>
4947
4948 * image.c: Various fixes to ImageMagick code comments.
4949 (Fimagemagick_types): Doc fix.
4950
5fbc2025
PE
49512011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4952
0196f88a
PE
4953 Minor fixes prompted by GCC 4.6.0 warnings.
4954
4955 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4956
5fbc2025
PE
4957 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4958 (x_clipboard_manager_save_all): Move extern decl to ...
4959 * xterm.h: ... here, so that it can be checked for consistency.
4960
1dd3c2d9
CY
49612011-05-29 Chong Yidong <cyd@stupidchicken.com>
4962
4963 * xselect.c (x_clipboard_manager_save_frame)
4964 (x_clipboard_manager_save_all): New functions.
4965 (Fx_clipboard_manager_save): Lisp function deleted.
4966
4967 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4968 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4969
4970 * xterm.h: Update prototype.
4971
5ba6571d
WX
49722011-05-28 William Xu <william.xwl@gmail.com>
4973
4974 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4975 exiting (Bug#8239).
4976
3eaff834
JM
49772011-05-28 Jim Meyering <meyering@redhat.com>
4978
e1900994 4979 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4980 * fns.c (to_uchar): Define.
4981 (crypto_hash_function): Use it to convert some newly-signed
4982 variables to unsigned, to avoid sign-extension bugs. For example,
4983 without this change, (md5 "truc") would evaluate to
4984 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4985 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4986 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4987
0f6990a7
PE
49882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 Integer overflow fixes.
c8a9ca5a 4991
08686060
PE
4992 * dbusbind.c: Serial number integer overflow fixes.
4993 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4994 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4995 to hold a serial number that is too large for a fixnum.
4996 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4997 Check for serial numbers out of range. Decode any serial number
59568bf0 4998 that was so large that it became a float. (Bug#8722)
08686060 4999
2d1fc3c7
PE
5000 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5001 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5002 Use XFASTINT rather than XUINT when numbers are nonnegative.
5003 (xd_append_arg, Fdbus_method_return_internal):
5004 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5005 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5006 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5007 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5008 (Bug#8722)
2d1fc3c7 5009
c8a9ca5a
PE
5010 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5011
519e1d69
PE
5012 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5013
30569699
PE
5014 ccl: add integer overflow checks
5015 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5016 (IN_INT_RANGE): New macros.
5017 (ccl_driver): Use them to check for integer overflow when
5018 decoding a CCL program. Many of the new checks are whether XINT (x)
5019 fits in int; it doesn't always, on 64-bit hosts. The new version
5020 doesn't catch all possible integer overflows, but it's an
847044ea 5021 improvement. (Bug#8719)
30569699 5022
c11285dc
PE
5023 * alloc.c (make_event_array): Use XINT, not XUINT.
5024 There's no need for unsigned here.
5025
fdccd48e
PE
5026 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5027 This follows up to the 2011-05-06 change that substituted uintptr_t
5028 for EMACS_INT. This case wasn't caught back then.
5029
37910ab2
PE
5030 Rework Fformat to avoid integer overflow issues.
5031 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5032 now (part of C89). Include <verify.h>.
5033 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5034 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5035 (Fformat): Avoid the prepass trying to compute sizes; it was only
5036 approximate and thus did not catch overflow reliably. Instead, walk
5037 through the format just once, formatting and computing sizes as we go,
5038 checking for integer overflow at every step, and allocating a larger
5039 buffer as needed. Keep track separately whether the format is
5040 multibyte. Keep only the most-recently calculated precision, rather
5041 than them all. Record whether each argument has been converted to
5042 string. Use EMACS_INT, not int, for byte and char and arg counts.
5043 Support field widths and precisions larger than INT_MAX. Avoid
5044 sprintf's undefined behavior with conversion specifications such as %#d
5045 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5046 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5047 formatting out-of-range floating point numbers with int
9173deec 5048 formats. (Bug#8668)
37910ab2 5049
2e6578fb
PE
5050 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5051
0ae6bdee
PE
5052 * data.c: Avoid integer truncation in expressions involving floats.
5053 * data.c: Include <intprops.h>.
5054 (arith_driver): When there's an integer overflow in an expression
5055 involving floating point, convert the integers to floating point
5056 so that the resulting value does not suffer from catastrophic
5057 integer truncation. For example, on a 64-bit host (* 4
5058 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5059 Do not rely on undefined behavior after integer overflow.
5060
de883a70
PE
5061 merge count_size_as_multibyte, parse_str_to_multibyte
5062 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5063 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5064 Check for integer overflow.
5065 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5066 since it's now a duplicate of the other. This is more of
5067 a character than a buffer op, so better that it's in character.c.
5068 * fns.c, print.c: Adjust to above changes.
5069
2ff916cb
PE
50702011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5071
5072 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5073
f1b54466
PE
50742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5075
fb1ac845
PE
5076 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5077 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5078 (x_clipboard_manager_save): Now static.
5079 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5080
f1b54466
PE
5081 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5082 (crypto_hash_function): Now static.
5083 Fix pointer signedness problems. Avoid unnecessary initializations.
5084
a9f737ee
CY
50852011-05-27 Chong Yidong <cyd@stupidchicken.com>
5086
5087 * termhooks.h (Vselection_alist): Make it terminal-local.
5088
5089 * terminal.c (create_terminal): Initialize it.
5090
5091 * xselect.c: Support for clipboard managers.
5092 (Vselection_alist): Move to termhooks.h as terminal-local var.
5093 (LOCAL_SELECTION): New macro.
5094 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5095 (symbol_to_x_atom): Remove gratuitous arg.
5096 (x_handle_selection_request, lisp_data_to_selection_data)
5097 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5098 (x_own_selection, x_get_local_selection, x_convert_selection):
5099 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5100 (some_frame_on_display): Delete unused function.
5101 (Fx_own_selection_internal, Fx_get_selection_internal)
5102 (Fx_disown_selection_internal, Fx_selection_owner_p)
5103 (Fx_selection_exists_p): New optional frame arg.
5104 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5105 (x_handle_selection_clear): Don't treat other terminals with the
5106 same keyboard specially. Use the terminal-local Vselection_alist.
5107 (x_clear_frame_selections): Use Frun_hook_with_args.
5108
5109 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5110
5111 * xterm.h: Add support for those atoms.
5112
e067f0c1
CY
51132011-05-26 Chong Yidong <cyd@stupidchicken.com>
5114
5115 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5116 (converted_selections, conversion_fail_tag): New global variables.
5117 (x_selection_request_lisp_error): Free the above.
5118 (x_get_local_selection): Remove unnecessary code.
5119 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5120 of converted selections stored in converted_selections.
5121 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5122 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5123 (x_convert_selection): New function.
5124 (x_handle_selection_event): Simplify.
5125 (x_get_foreign_selection): Don't ignore incoming requests while
5126 waiting for an answer; this will fail when we implement
5127 SAVE_TARGETS, and seems unnecessary anyway.
5128 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5129 (Vx_sent_selection_functions): Doc fix.
5130
0f4aebc0
LL
51312011-05-26 Leo Liu <sdl.web@gmail.com>
5132
5133 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5134
e61124cd
YM
51352011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5136
5137 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5138
5139 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5140 for fringe update if it has periodic bitmap.
ac389d0c 5141 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5142 and fringe_bitmap_periodic_p.
5143
5144 * fringe.c (get_fringe_bitmap_data): New function.
5145 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5146 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5147 row. Mark glyph row for fringe update if periodicity changed.
5148
5149 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5150 for fringe update unless it has periodic bitmap.
5151
f16d9837
KH
51522011-05-25 Kenichi Handa <handa@m17n.org>
5153
5154 * xdisp.c (get_next_display_element): Set correct it->face_id for
5155 a static composition.
5156
e1b90ef6
LL
51572011-05-24 Leo Liu <sdl.web@gmail.com>
5158
5159 * deps.mk (fns.o):
5160 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5161
5162 * fns.c (crypto_hash_function, Fsha1): New function.
5163 (Fmd5): Use crypto_hash_function.
5164 (syms_of_fns): Add Ssha1.
5165
7400048f
PE
51662011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5167
5168 * gnutls.c: Remove unused macros.
5169 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5170 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5171 Remove macros that are defined and never used.
5172 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5173
abb71cf4
CY
51742011-05-22 Chong Yidong <cyd@stupidchicken.com>
5175
5176 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5177 (Fx_get_selection_internal): Minor cleanup.
5178 (Fx_own_selection_internal): Rename arguments for consistency with
5179 select.el.
5180
6307db39
PE
51812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5182
5183 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5184
f3d4e0a4
CY
51852011-05-22 Chong Yidong <cyd@stupidchicken.com>
5186
5187 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5188
4d8ade89
YM
51892011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5190
5191 * dispnew.c (scrolling_window): Don't exclude the case that the
5192 last enabled row in the desired matrix touches the bottom boundary.
5193
32078c8d
GM
51942011-05-21 Glenn Morris <rgm@gnu.org>
5195
5196 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5197 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5198 and add some more files.
32078c8d 5199
7285dc67
EZ
52002011-05-20 Eli Zaretskii <eliz@gnu.org>
5201
5202 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5203 report_file_error introduced by the change from 2011-05-07.
5204
89d1bd22
PE
52052011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5206
5207 * systime.h (Time): Define only if emacs is defined.
5208 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5209 where the include path doesn't have X11/X.h by default. See
5210 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5211
e23640bb 52122011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5213
5214 * composite.c (find_automatic_composition): Fix previous change.
5215
b9704ad9
GM
52162011-05-20 Glenn Morris <rgm@gnu.org>
5217
5218 * lisp.mk: New file, split from Makefile.in.
5219 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5220 (shortlisp): Remove.
5221 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5222
4a720484
GM
52232011-05-19 Glenn Morris <rgm@gnu.org>
5224
5225 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5226 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5227 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5228 (lisp): Set the order to that of loadup.el.
5229 (shortlisp): Make it a copy of $lisp.
5230 (SOME_MACHINE_LISP): Remove.
5231 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5232 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5233
a28d4396
KH
52342011-05-18 Kenichi Handa <handa@m17n.org>
5235
5236 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5237 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5238 (find_automatic_composition): Mostly rewrite for efficiency.
5239
a2b1fa8e
JB
52402011-05-18 Juanma Barranquero <lekktu@gmail.com>
5241
5242 * makefile.w32-in: Update dependencies.
5243
8e1f5610
CS
52442011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5245
5246 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5247 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5248
7025ee00 52492011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5250
cdfa6eab
PE
5251 Fix some integer overflow issues, such as string length overflow.
5252
06d6db33
PE
5253 * insdel.c (count_size_as_multibyte): Check for string overflow.
5254
2b4560a8
PE
5255 * character.c (lisp_string_width): Check for string overflow.
5256 Use EMACS_INT, not int, for string indexes and lengths; in
5257 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5258 the resulting string length overflows an EMACS_INT; instead,
5259 report a string overflow if no precision given. When checking for
5260 precision exhaustion, use a check that cannot possibly have
5261 integer overflow. (Bug#8675)
5262 * character.h (lisp_string_width): Adjust to new signature.
5263
cb93f9be
PE
5264 * alloc.c (string_overflow): New function.
5265 (Fmake_string): Use it. This doesn't change behavior, but saves
5266 a few bytes and will simplify future changes.
5267 * character.c (string_escape_byte8): Likewise.
5268 * lisp.h (string_overflow): New decl.
5269
1a1f3366
PE
5270 Fixups, following up to the user-interface timestamp change.
5271 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5272 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5273 * msdos.c (mouse_get_pos): Likewise.
5274 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5275 * w32gui.h (Time): Define by including "systime.h" rather than by
5276 declaring it ourselves. (Bug#8664)
5277
d4e3e4d3
PE
5278 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5279 * image.c (clear_image_cache): Likewise.
5280
f6a24d19
PE
5281 * term.c (term_mouse_position): Don't assume time_t wraparound.
5282
08dc5ae6
PE
5283 Be more systematic about user-interface timestamps.
5284 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5285 and sometimes 'EMACS_UINT', to represent these timestamps.
5286 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5287 This makes the code easier to follow, and makes it easier to catch
5288 integer overflow bugs such as Bug#8664.
5289 * frame.c (Fmouse_position, Fmouse_pixel_position):
5290 Use Time, not unsigned long, for user-interface timestamps.
5291 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5292 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5293 * keyboard.h (last_event_timestamp): Likewise.
5294 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5295 * menu.h (xmenu_show): Likewise.
5296 * term.c (term_mouse_position): Likewise.
5297 * termhooks.h (struct input_event.timestamp): Likewise.
5298 (struct terminal.mouse_position_hook): Likewise.
5299 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5300 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5301 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5302 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5303 what it was before.
5304 * menu.h, termhooks.h: Include "systime.h", for Time.
5305
8e55734a
PE
5306 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5307 Don't assume that the difference between two unsigned long values
5308 can fit into an integer. At this point, we know button_down_time
5309 <= event->timestamp, so the difference must be nonnegative, so
5310 there's no need to cast the result if double-click-time is
5311 nonnegative, as it should be; check that it's nonnegative, just in
5312 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5313 apart (about 25 days). (Bug#8664)
8e55734a 5314
841f1b75 5315 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5316 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5317
3e26f69c
PE
5318 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5319 that always fit in int. Use a sentinel instead of a counter, to
5320 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5321 * frame.h (struct frame): Use int for menu_bar_items_used
5322 instead of EMACS_INT, since it always fits in int.
3e26f69c 5323
5cc152c0
PE
5324 * menu.c (grow_menu_items): Check for int overflow.
5325
d89eb65e
PE
5326 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5327
5235bd3e
PE
5328 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5329 Before, the code was not consistent. These values cannot exceed
5330 2**31 - 1 so there's no need to make them unsigned.
5331 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5332 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5333 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5334 as modifiers.
5335 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5336
bc827e23
PE
5337 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5338 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5339 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5340 presumably because the widths might not match.
5341
78eb494e
PE
5342 * window.c (size_window): Avoid needless test at loop start.
5343
04f2d78b
CB
53442011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5345
5346 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5347
d2fc7e3d 53482011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5349
5350 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5351
d2fc7e3d 53522011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5353
5354 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5355 `width' to `bar_area_x' and `bar_area_width', respectively.
5356 (x_scroll_run): Take account of fringe background extension.
5357
04f2d78b
CB
5358 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5359 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5360 `bar_area_width', respectively.
5361 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5362 background extension.
5363
79b70037
GM
53642011-05-10 Jim Meyering <meyering@redhat.com>
5365
5366 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5367
2f142cc5
JB
53682011-05-10 Juanma Barranquero <lekktu@gmail.com>
5369
5370 * image.c (Finit_image_library): Return t for built-in image types,
5371 like pbm and xbm. (Bug#8640)
5372
57679c86
AS
53732011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5374
5375 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5376
888c9e86
EZ
53772011-05-07 Eli Zaretskii <eliz@gnu.org>
5378
b0512a1d
EZ
5379 * w32console.c (Fset_screen_color): Doc fix.
5380 (Fget_screen_color): New function.
5381 (syms_of_ntterm): Defsubr it.
5382
7285dc67
EZ
5383 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5384 unlink the temporary file if Fcall_process didn't create it in the
5385 first place.
5386 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5387 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5388 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5389 cue to call_process_cleanup not to close that handle.
5390
4d3fcc8e
BK
53912011-05-07 Ben Key <bkey76@gmail.com>
5392
5393 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5394 one of two shell specific rules, either bootstrap-temacs-CMD or
5395 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5396 to the previous implementation of the bootstrap-temacs rule.
5397 The bootstrap-temacs-CMD rule is similar to the previous
5398 implementation of the bootstrap-temacs rule except that it
5399 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5400 variable.
5401
5402 These changes, along with some changes to nt/configure.bat,
5403 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5404 earlier fix to add support for --cflags and --ldflags options
5405 that include quotes so that it works whether make uses cmd or
5406 sh as the shell.
5407
b4289b64
MA
54082011-05-06 Michael Albinus <michael.albinus@gmx.de>
5409
5410 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5411 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5412 is a constant.
5413 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5414 a string. Handle both cases.
5415 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5416 (Fdbus_register_method): Use Qinvalid_function.
5417
af4c0e28
JB
54182011-05-06 Juanma Barranquero <lekktu@gmail.com>
5419
5420 * makefile.w32-in: Update dependencies.
5421 (LISP_H): Add inttypes.h and stdin.h.
5422 (PROCESS_H): Add unistd.h.
5423
c51453d9
EZ
54242011-05-06 Eli Zaretskii <eliz@gnu.org>
5425
5426 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5427 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5428
8ff0ac3c 54292011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5430
4c4b566b
PE
5431 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5432
aab2b9b5
PE
5433 * term.c (vfatal): Remove stray call to va_end.
5434 It's not needed and the C Standard doesn't allow it here anyway.
5435
c378da0b
PE
5436 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5437 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5438
288b08c7
PE
5439 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5440 bytes.
5441
e3601888
PE
5442 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5443
db6c0e74
PE
5444 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5445
dd5963ea
PE
5446 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5447
88c9450f
PE
5448 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5449
2f9442b8
PE
5450 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5451
c032b5f8
PE
5452 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5453 * charset.c (Fdefine_charset_internal): Don't initialize
5454 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5455 32-bit int (Bug#8600).
a108c10b
PE
5456
5457 * lread.c (read_integer): Be more consistent with string-to-number.
5458 Use string_to_number to do the actual conversion; this avoids
5459 rounding errors and fixes some other screwups. Without this fix,
5460 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5461 (digit_to_number): Move earlier, for benefit of read_integer.
5462 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5463 not a digit in any supported base. (Bug#8602)
a108c10b 5464
ad5f9eea
PE
5465 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5466
aec1708a
PE
5467 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5468 to match comment at start of function. This also removes a
5469 GCC warning about overflow in a 32+64-bit port.
5470
47be4ab5
PE
5471 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5472
371cac43
PE
5473 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5474 Reported by Stefan Monnier in
5475 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5476 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5477 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5478
d01a7826
PE
5479 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5480 (EMACS_UINTPTR): Likewise, with uintptr_t.
5481
7fd47d5c
PE
5482 * lisp.h: Prefer 64-bit EMACS_INT if available.
5483 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5484 on 32-bit hosts that have 64-bit int, so that they can access
5485 large files.
122b0c86
PE
5486 However, temporarily disable this change unless the temporary
5487 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5488
8727937b
PE
5489 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5490
8ac068ac
PE
5491 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5492 This removes an assumption that EMACS_INT and long are the same
5493 width as pointers. The assumption is true for Emacs porting targets
5494 now, but we want to make other targets possible.
5495 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5496 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5497 In the rest of the code, change types of integers that hold casted
5498 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5499 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5500 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5501 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5502 No need to cast type when ORing.
5503 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5504 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5505 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5506 assume EMACS_INT is the same width as char *.
5507 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5508 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5509 Remove no-longer-needed casts.
5510 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5511 (xg_tool_bar_help_callback, xg_make_tool_item):
5512 Use EMACS_INTPTR to hold an integer
5513 that will be cast to void *; this can avoid a GCC warning
5514 if EMACS_INT is not the same width as void *.
5515 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5516 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5517 (current_message_1, set_message_1):
5518 Use a local to convert to proper width without a cast.
5519 * xmenu.c (dialog_selection_callback): Likewise.
5520
ede49d71
PE
5521 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5522 Also, don't assume VALBITS / RAND_BITS is less than 5,
5523 and don't rely on undefined behavior when shifting a 1 left into
5524 the sign bit.
5525 * lisp.h (get_random): Change signature to match.
5526
2f30ecd0
PE
5527 * lread.c (hash_string): Use size_t, not int, for hash computation.
5528 Normally we prefer signed values; but hashing is special, because
5529 it's better to use unsigned division on hash table sizes so that
5530 the remainder is nonnegative. Also, size_t is the natural width
5531 for hashing into memory. The previous code used 'int', which doesn't
5532 retain enough info to hash well into very large tables.
5533 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5534
2a866e7b
PE
5535 * dbusbind.c: Don't possibly lose pointer info when converting.
5536 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5537 Use XPNTR rather than XHASH, so that the high-order bits of
5538 the pointer aren't lost when converting through void *.
5539
51639eac
PE
5540 * eval.c (Fautoload): Don't double-shift a pointer.
5541
92394119
PE
5542 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5543
dbdb9a7c
JB
55442011-05-06 Juanma Barranquero <lekktu@gmail.com>
5545
5546 * gnutls.c (DEF_GNUTLS_FN):
5547 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5548
db7a0b4f
AS
55492011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5550
5551 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5552 marker. (Bug#8610)
5553
f7ff1b0f 55542011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5555
5556 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5557 New version that can reserve upto 2GB of heap space.
5558
f7ff1b0f 55592011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5560
5561 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5562
639c109b
TZ
55632011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5564
5565 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5566 `gnutls_certificate_set_x509_key_file'.
5567
d2127135
JB
55682011-05-05 Juanma Barranquero <lekktu@gmail.com>
5569
5570 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5571 Update dependencies.
5572
e968f4f3
JB
55732011-05-04 Juanma Barranquero <lekktu@gmail.com>
5574
5575 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5576 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5577 Remove unused parameter `fildes'.
5578 * process.c (read_process_output, send_process): Don't pass it.
5579
84d358f0
JB
55802011-05-04 Juanma Barranquero <lekktu@gmail.com>
5581
5582 Fix previous change: the library cache is defined in w32.c.
5583 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5584 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5585
0898ca10
JB
55862011-05-04 Juanma Barranquero <lekktu@gmail.com>
5587
5588 Implement dynamic loading of GnuTLS on Windows.
5589
5590 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5591 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5592 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5593 Declare.
5594
5595 * gnutls.c (Qgnutls_dll): Define.
5596 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5597 (gnutls_*): Declare function pointers.
5598 (init_gnutls_functions): New function to initialize function pointers.
5599 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5600 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5601 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5602 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5603 (emacs_gnutls_write, emacs_gnutls_read)
5604 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5605 (Fgnutls_available_p): New function.
5606 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5607 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5608 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5609
5610 * image.c: Include w32.h.
5611 (Vimage_type_cache): Delete.
5612 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5613 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5614 (w32_delayed_load): Move to w32.c.
5615
5616 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5617
5618 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5619 (w32_delayed_load): Move from image.c. When loading a library, record
5620 its filename in the :loaded-from property of the library id.
5621 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5622 Initialize and staticpro them.
5623 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5624
5625 * process.c: Include lisp.h before w32.h, not after.
5626 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5627 instead of gnutls_record_check_pending.
5628
5629 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5630
ff4de4aa
TZ
56312011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5632
5633 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5634 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5635 as passed in.
5636
abe95abb
JD
56372011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5638
5639 * xterm.c (x_set_frame_alpha): Do not set property on anything
5640 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5641
e16e55d4
JB
56422011-05-02 Juanma Barranquero <lekktu@gmail.com>
5643
5644 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5645
bafcf6a5
JB
56462011-05-02 Juanma Barranquero <lekktu@gmail.com>
5647
5648 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5649 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5650 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5651 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5652 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5653 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5654 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5655 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5656 (Qgnutls_bootprop_callbacks_verify): Make static.
5657
e7a6747f
AS
56582011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5659
19ed11ba
AS
5660 * callproc.c: Indentation fixup.
5661
e7a6747f 5662 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5663 (wait_for_termination, interruptible_wait_for_termination):
5664 Move after wait_for_termination_1.
e7a6747f 5665
1ef14cb4
LMI
56662011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5667
5668 * sysdep.c (interruptible_wait_for_termination): New function
5669 which is like wait_for_termination, but allows keyboard
5670 interruptions.
5671
5672 * callproc.c (Fcall_process): Add (:file "file") as an option for
5673 the STDOUT buffer.
5674 (Fcall_process_region): Ditto.
5675
330d880c
EZ
56762011-04-30 Eli Zaretskii <eliz@gnu.org>
5677
8db90b73
EZ
5678 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5679 rather than `XVECTOR (FOO)->size'.
5680
330d880c
EZ
5681 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5682 inttypes.h, as a gnulib replacement is used if it not available in
5683 system headers.
5684
15cbd324
EZ
56852011-04-21 Eli Zaretskii <eliz@gnu.org>
5686
5687 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5688 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5689 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5690
5691 * coding.c (coding_alloc_by_realloc): Error out if destination
5692 will grow beyond MOST_POSITIVE_FIXNUM.
5693 (decode_coding_emacs_mule): Abort if there isn't enough place in
5694 charbuf for the composition carryover bytes. Reserve an extra
5695 space for up to 2 characters produced in a loop.
5696 (decode_coding_iso_2022): Abort if there isn't enough place in
5697 charbuf for the composition carryover bytes.
5698
56992011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5700
ae940cca
EZ
5701 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5702 aborting when %lld or %lll format is passed.
5703 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5704 %llo or %llx format is passed. (Bug#8545)
5705
03ab8921
EZ
5706 * window.c (window_scroll_line_based): Use a marker instead of
5707 simple variables to record original value of point. (Bug#7952)
5708
afda1437
EZ
5709 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5710 produced by %s or %c overflows available buffer space. (Bug#8545)
5711
f76dee0c
PE
57122011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5713
5714 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5715 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5716
fdc5744d
JB
57172011-04-28 Juanma Barranquero <lekktu@gmail.com>
5718
5719 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5720
638f053a
JB
57212011-04-28 Juanma Barranquero <lekktu@gmail.com>
5722
5723 * keyboard.c (Qdelayed_warnings_hook): Define.
5724 (command_loop_1): Run `delayed-warnings-hook'
5725 if Vdelayed_warnings_list is non-nil.
5726 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5727 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5728
d178f871
EZ
57292011-04-28 Eli Zaretskii <eliz@gnu.org>
5730
5731 * doprnt.c (doprnt): Don't return value smaller than the buffer
5732 size if the message was truncated. (Bug#8545).
5733
b124fd93
JB
57342011-04-28 Juanma Barranquero <lekktu@gmail.com>
5735
5736 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5737 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5738
e810457d
PE
57392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5740
5741 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5742
ea51cceb
JB
57432011-04-27 Juanma Barranquero <lekktu@gmail.com>
5744
5745 * makefile.w32-in: Update dependencies.
5746
94dcfacf
EZ
57472011-04-27 Eli Zaretskii <eliz@gnu.org>
5748
5749 Improve `doprnt' and its usage. (Bug#8545)
5750 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5751 `format_end'. Remove support for %l as a conversion specifier.
5752 Don't use xrealloc. Improve diagnostics when the %l size modifier
5753 is used. Update the commentary.
5754
5755 * eval.c (verror): Simplify calculation of size_t.
5756
5757 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5758 messages.
5759
f61f41d7
PE
57602011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5761
5762 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5763 change.
5764
96fb4434
PE
57652011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5768 This makes this file independent of the recent pseudovector change.
5769
671875da 57702011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5771
69e9b5a3
PE
5772 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5773
b5f869a7 5774 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5775 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5776 Remove unused local.
c8926152 5777 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5778
841a1577 5779 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5780 GCC 4.6.0 optimizes based on type-based alias analysis.
5781 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5782 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5783 != &v->size, and therefore "v->size = 1; b->size = 2; return
5784 v->size;" must therefore return 1. This assumption is incorrect
5785 for Emacs, since it type-puns struct Lisp_Vector * with many other
5786 types. To fix this problem, this patch adds a new type struct
f904488f 5787 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5788 and pseudovectors, and helps optimizing compilers not get fooled
5789 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5790 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5791 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5792 the size member.
eab3844f
PE
5793 (XSETPVECTYPE): Rewrite in terms of new macro.
5794 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5795 This is a bit clearer, and further avoids the possibility of
5796 undesirable aliasing.
5797 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5798 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5799 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5800 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5801 (ASIZE): Now uses header.size rather than size.
5802 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5803 to avoid the hassle of writing XVECTOR (foo)->header.size.
5804 (struct vectorlike_header): New type.
eab3844f
PE
5805 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5806 object, to help avoid aliasing.
5807 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5808 (SUBRP): Likewise, since Lisp_Subr is a special case.
5809 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5810 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5811 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5812 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5813 changed to be "header.size" and "header.next".
5814 * buffer.h (struct buffer): Likewise.
5815 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5816 * frame.h (struct frame): Likewise.
5817 * process.h (struct Lisp_Process): Likewise.
5818 * termhooks.h (struct terminal): Likewise.
5819 * window.c (struct save_window_data, struct saved_window): Likewise.
5820 * window.h (struct window): Likewise.
5821 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5822 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5823 * buffer.c (init_buffer_once): Likewise.
5824 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5825 special case.
5826 * process.c (Fformat_network_address): Use local var for size,
5827 for brevity.
5828
0df1eac5
PE
5829 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5830
847ab9d1 5831 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5832 * data.c (atof): Remove decl; no longer used or needed.
5833 (digit_to_number): Move to lread.c.
5834 (Fstring_to_number): Use new string_to_number function, to be
5835 consistent with how the Lisp reader treats infinities and NaNs.
5836 Do not assume that floating-point numbers represent EMACS_INT
5837 without losing information; this is not true on most 64-bit hosts.
5838 Avoid double-rounding errors, by insisting on integers when
5839 parsing non-base-10 numbers, as the documentation specifies.
5840 * lisp.h (string_to_number): New decl, replacing ...
5841 (isfloat_string): Remove.
bc0a5c13 5842 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5843 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5844 appears to have been a coding error. Similarly, do not accept
5845 strings like +-1e0 as floating point numbers. Do not report
5846 overflow for integer overflows unless the base is not 10 which
5847 means we have no simple and reliable way to continue.
5848 Break out the floating-point parsing into a new
5849 function string_to_number, so that Fstring_to_number parses
5850 floating point numbers consistently with the Lisp reader.
04f2d78b 5851 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5852 (E_CHAR, EXP_INT): Remove, replacing with ...
5853 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5854 (string_to_number): New function, replacing isfloat_string.
5855 This function checks for valid syntax and produces the resulting
5856 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5857 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5858 so that overflow for non-base-10 numbers is reported only when
5859 there's no portable and simple way to convert to floating point.
452f4150 5860
67769ffc
PE
5861 * textprop.c (set_text_properties_1): Rewrite for clarity,
5862 and to avoid GCC warning about integer overflow.
5863
c20db43f
PE
5864 * intervals.h (struct interval): Use EMACS_INT for members
5865 where EMACS_UINT might cause problems. See
5866 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5867 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5868 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5869 All uses changed.
37aa2f85
PE
5870 (offset_intervals): Tell GCC not to worry about length overflow
5871 when negating a negative length.
c20db43f 5872
2538aa2f
PE
5873 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5874 (overrun_check_free): Likewise.
5875
f2d3008d
PE
5876 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5877 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5878 word size.
5879
ec8df744
PE
5880 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5881 (gnutls_make_error): Rename local to avoid shadowing.
5882 (gnutls_emacs_global_deinit): ifdef out; not used.
5883 (Fgnutls_boot): Use const for pointer to readonly storage.
5884 Comment out unused local. Fix pointer signedness problems.
5885
640ee02d
PE
5886 * lread.c (openp): Don't stuff size_t into an 'int'.
5887 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5888 about possible signed overflow.
5889
6048fb2a
PE
5890 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5891 (GDK_KEY_g): Don't define if already defined.
5892 (xg_prepare_tooltip): Avoid pointer signedness problem.
5893 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5894
fa3c87e1
PE
5895 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5896 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5897
2172544b
PE
5898 * xfns.c (Fx_window_property): Simplify a bit,
5899 to make a bit faster and to avoid GCC 4.6.0 warning.
5900 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5901
9b821a21
PE
5902 * fns.c (internal_equal): Don't assume size_t fits in int.
5903
3c616cfa
PE
5904 * alloc.c (compact_small_strings): Tighten assertion a little.
5905
c2982e87
PE
5906 Replace pEd with more-general pI, and fix some printf arg casts.
5907 * lisp.h (pI): New macro, generalizing old pEd macro to other
5908 conversion specifiers. For example, use "...%"pI"d..." rather
5909 than "...%"pEd"...".
5910 (pEd): Remove. All uses replaced with similar uses of pI.
5911 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5912 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5913 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5914 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5915 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5916 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5917 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5918 64-bit hosts.
5919 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5920 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5921 * print.c (safe_debug_print, print_object): Likewise.
5922 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5923 to int.
6f04d126
PE
5924 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5925 avoiding the 0 flag, which is not portable.
c2982e87
PE
5926 * process.c (Fmake_network_process): Use pI to avoid cast.
5927 * region-cache.c (pp_cache): Likewise.
5928 * xdisp.c (decode_mode_spec): Likewise.
5929 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5930 behavior on 64-bit hosts with printf arg.
6f04d126 5931 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5932 (x_stop_queuing_selection_requests): Likewise.
5933 (x_get_window_property): Don't truncate byte count to an 'int'
5934 when tracing.
0b432f21 5935
5e073ec7
PE
5936 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5937 here, since it parses constructs like leading '-' and spaces,
5938 which are not wanted; and it overflows with large numbers.
5939 Instead, simply match F[0-9]+, which is what is wanted anyway.
5940
36372bf9
PE
5941 * alloc.c: Remove unportable assumptions about struct layout.
5942 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5943 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5944 (allocate_vectorlike, make_pure_vector): Use the new macros,
5945 plus offsetof, to remove unportable assumptions about struct layout.
5946 These assumptions hold on all porting targets that I know of, but
5947 they are not guaranteed, they're easy to remove, and removing them
5948 makes further changes easier.
5949
0b432f21
PE
5950 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5951 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5952 (string_overrun_cookie): Now const. Use initializers that
5953 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5954 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5955 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5956 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5957 multiple of sizeof (EMACS_INT); it need not be, if
5958 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5959 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5960
895009e1
JB
59612011-04-26 Juanma Barranquero <lekktu@gmail.com>
5962
5963 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5964
6a7a1b0b
TZ
59652011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5966
5967 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5968 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5969 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5970
841a1577 59712011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5972
5973 * lisp.h (Qdebug): List symbol.
895009e1 5974 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5975 * keyboard.c (debug-on-event): New variable.
5976 (handle_user_signal): Break into debugger when debug-on-event
5977 matches the current signal symbol.
5978
f2d3ba6f
DN
59792011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5980
5981 * alloc.c (check_sblock, check_string_bytes)
5982 (check_string_free_list): Convert to standard C.
5983
42ce4c63
TZ
59842011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5985
5986 * w32.c (emacs_gnutls_push): Fix typo.
5987
825cd63c
EZ
59882011-04-25 Eli Zaretskii <eliz@gnu.org>
5989
fb11d64d
EZ
5990 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5991 "cast to pointer from integer of different size".
5992
825cd63c
EZ
5993 Improve doprnt and its use in verror. (Bug#8545)
5994 * doprnt.c (doprnt): Document the set of format control sequences
5995 supported by the function. Use SAFE_ALLOCA instead of always
5996 using `alloca'.
5997
5998 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5999 is one byte too soon. Don't use xrealloc; instead xfree and
6000 xmalloc anew.
6001
e061a11b
TZ
60022011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6003
6004 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6005 callbacks stage.
6006
6007 * gnutls.c: Renamed global_initialized to
6008 gnutls_global_initialized. Added internals for the
6009 :verify-hostname-error, :verify-error, and :verify-flags
6010 parameters of `gnutls-boot' and documented those parameters in the
6011 docstring. Start callback support.
9173deec
JB
6012 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6013 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6014 on error. Return error code.
e061a11b
TZ
6015 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6016 (emacs_gnutls_read): Likewise.
6017 (Fgnutls_boot): Return handshake error code.
6018 (emacs_gnutls_handle_error): New function.
6019 (wsaerror_to_errno): Likewise.
6020
6021 * w32.h (emacs_gnutls_pull): Add prototype.
6022 (emacs_gnutls_push): Likewise.
6023
6024 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6025 (emacs_gnutls_push): Likewise.
6026
60272011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6028
6029 * process.c (wait_reading_process_output): Check if GnuTLS
6030 buffered some data internally if no FDs are set for TLS
6031 connections.
6032
6033 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6034 (LIBS): Link to USER_LIBS.
6035 ($(BLD)/gnutls.$(0)): New target.
6036
fa6996bc
EZ
60372011-04-24 Eli Zaretskii <eliz@gnu.org>
6038
eb35682e
EZ
6039 * xdisp.c (handle_single_display_spec): Rename the
6040 display_replaced_before_p argument into display_replaced_p, to
6041 make it consistent with the commentary. Fix typos in the
6042 commentary.
6043
e2ad650c
EZ
6044 * textprop.c (syms_of_textprop): Remove dead code.
6045 (copy_text_properties): Delete obsolete commentary about an
6046 interface that was deleted long ago. Fix typos in the description
6047 of arguments.
6048
1b2de274
EZ
6049 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6050 to changes in oldXMenu/XMenu.h from 2011-04-16.
6051 <menu_help_message, prev_menu_help_message>: Constify.
6052 (IT_menu_make_room): menu->help_text is now `const char **';
6053 adjust.
6054
6055 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6056 to changes in oldXMenu/XMenu.h from 2011-04-16.
6057 (struct XMenu): Declare `help_text' `const char **'.
6058
6059 * xfaces.c <Qunspecified>: Make extern again.
6060
6061 * syntax.c: Include sys/types.h before including regex.h, as
6062 required by Posix.
6063
762b15be
EZ
6064 * doc.c (get_doc_string): Improve the format passed to `error'.
6065
6066 * doprnt.c (doprnt): Improve commentary.
6067
6068 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6069
6070 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6071 them with etags.
6072
f1052e5d
EZ
6073 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6074 changes in globals.h immediately force recompilation.
762b15be
EZ
6075 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6076 $(CURDIR)/s/ms-w32.h.
6077 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6078
fa6996bc
EZ
6079 * character.c (Fchar_direction): Function deleted.
6080 (syms_of_character): Don't defsubr it.
6081 <char-direction-table>: Deleted.
6082
e6c3da20
EZ
60832011-04-23 Eli Zaretskii <eliz@gnu.org>
6084
6085 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6086 * doprnt.c: Include limits.h.
6087 (SIZE_MAX): New macro.
04f2d78b
CB
6088 (doprnt): Return a size_t value. 2nd arg is now size_t.
6089 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6090 Improve overflow protection. Support `l' modifier for integer
6091 conversions. Support %l conversion. Don't assume an EMACS_INT
6092 argument for integer conversions and for %c.
6093
6094 * lisp.h (doprnt): Restore prototype.
6095
6096 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6097 $(SRC)/character.h.
6098
6099 * Makefile.in (base_obj): Add back doprnt.o.
6100
6101 * deps.mk (doprnt.o): Add back prerequisites.
6102 (callint.o): Depend on character.h.
6103
6104 * eval.c (internal_lisp_condition_case): Include the handler
6105 representation in the error message.
6106 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6107 when breaking from the loop.
6108
6109 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6110
6111 * callint.c (Fcall_interactively): When displaying error message
6112 about invalid control letter, pass the character's codepoint, not
6113 a pointer to its multibyte form. Improve display of the character
6114 in octal and display also its hex code.
6115
6116 * character.c (char_string): Use %x to display the (unsigned)
6117 codepoint of an invalid character, to avoid displaying a bogus
6118 negative value.
6119
6120 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6121 `error', not SYMBOL_NAME itself.
6122
6123 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6124 character arguments to `error'.
6125
6126 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6127 to `error' in error message about FINAL_CHAR argument. Make sure
6128 FINAL_CHAR is a character, and use %c when it is passed as
6129 argument to `error'.
6130
4ffd0d6b 61312011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6132
6133 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6134
6135 * w32.c: Include <time.h>.
6136 (sys_localtime): New function.
6137
4ffd0d6b 61382011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6139
6140 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6141
4ffd0d6b 6142 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6143
4ffd0d6b 61442011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6145
4ffd0d6b
GM
6146 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6147 zombies (Bug#8467).
aac0c6e3 6148
04c56954
EZ
61492011-04-19 Eli Zaretskii <eliz@gnu.org>
6150
6151 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6152 gl_state.e_property when gl_state.object is Qt.
6153
6154 * insdel.c (make_gap_larger): Remove limitation of buffer size
6155 to <= INT_MAX.
6156
16a43933
CY
61572011-04-18 Chong Yidong <cyd@stupidchicken.com>
6158
6159 * xdisp.c (lookup_glyphless_char_display)
6160 (produce_glyphless_glyph): Handle cons cell entry in
6161 glyphless-char-display.
6162 (Vglyphless_char_display): Document it.
6163
6164 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6165 glyphless-char-display.
6166
4581706e
CY
61672011-04-17 Chong Yidong <cyd@stupidchicken.com>
6168
6169 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6170
6171 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6172
6173 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6174 definition for no-X builds.
6175
4887c6e2 61762011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6177
fd35b6f9
PE
6178 Static checks with GCC 4.6.0 and non-default toolkits.
6179
5c1ccb01
PE
6180 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6181
006c5daa
PE
6182 * process.c (keyboard_bit_set): Define only if SIGIO.
6183 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6184 (send_process): Repair possible setjmp clobbering.
6185
efc736d3
PE
6186 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6187
4e2fe2e6
PE
6188 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6189
f97334a2
PE
6190 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6191
4e75f29d
PE
6192 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6193 Define only if needed.
6194
90efadd1
PE
6195 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6196 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6197 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6198
3c647824
PE
6199 * dispextern.h (struct redisplay_interface): Rename param
6200 to avoid shadowing.
e264f262 6201 * termhooks.h (struct terminal): Likewise.
761383f4 6202 * xterm.c (xembed_send_message): Likewise.
3c647824 6203
b58c5c4a
PE
6204 * insdel.c (make_gap_smaller): Define only if
6205 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6206
cad59032
PE
6207 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6208 it.
6209
c339dc2e
PE
6210 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6211 so that we aren't warned about unused symbols.
6212
91a3e27b
PE
6213 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6214
399c71d3 6215 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6216
8ffc96f5
PE
6217 * xfns.c (x_real_positions): Mark locals as initialized.
6218
eef9bc79
PE
6219 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6220
098db9dd
PE
6221 * xterm.c: Fix problems found by static analysis with other toolkits.
6222 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6223 (x_dispatch_event): Declare static if USE_GTK, and
6224 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6225 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6226 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6227 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6228 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6229
eb18f6cc
PE
6230 * xmenu.c (menu_help_callback): Pointer type fixes.
6231 Use const pointers when pointing at readonly data. Avoid pointer
6232 signedness clashes.
6233 (FALSE): Remove unused macro.
6234 (update_frame_menubar): Remove unused decl.
6235
1fe72bf8
PE
6236 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6237
60d9e1db
PE
6238 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6239 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6240 (single_menu_item): Rename local to avoid shadowing.
6241
39261c26
PE
6242 * keyboard.c (make_lispy_event): Remove unused local var.
6243
018c5e19
PE
6244 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6245 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6246
63d2b86e
PE
6247 * bitmaps: Change bitmaps from unsigned char back to the X11
6248 compatible char. Avoid the old compiler warnings about
6249 out-of-range initializers by using, for example, '\xab' rather
6250 than 0xab.
6251
aefd87e1
PE
6252 * xgselect.c (xgselect_initialize): Check vs interface
6253 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6254
bf501fb9
PE
6255 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6256
e9829fdf
PE
6257 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6258 to read-only memory.
6259
1086c095
PE
6260 * fns.c (vector): Remove; this old hack is no longer needed.
6261
2baccd04 6262 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6263 Remove unused var.
dde42981 6264 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6265
72391843 6266 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6267
436c16df 6268 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6269 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6270 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6271
92bb796d 6272 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6273 (x_term_init): Remove local to avoid shadowing.
92bb796d 6274
764430a3 6275 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6276
6277 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6278 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6279
d1dfb56c
EZ
62802011-04-16 Eli Zaretskii <eliz@gnu.org>
6281
c4354cb4
EZ
6282 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6283
d1dfb56c
EZ
6284 Fix regex.c, syntax.c and friends for buffers > 2GB.
6285 * syntax.h (struct gl_state_s): Declare character position members
6286 EMACS_INT.
6287
6288 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6289
04f2d78b
CB
6290 * textprop.c (verify_interval_modification, interval_of):
6291 Declare arguments EMACS_INT.
d1dfb56c
EZ
6292
6293 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6294 EMACS_INT.
6295
6296 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6297
6298 * indent.c (Fvertical_motion): Local variable it_start is now
6299 EMACS_INT.
6300
6301 * regex.c (re_match, re_match_2, re_match_2_internal)
6302 (bcmp_translate, regcomp, regexec, print_double_string)
6303 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6304 (re_compile_pattern, re_exec): Declare arguments and local
6305 variables `size_t' and `ssize_t' and return values `regoff_t', as
6306 appropriate.
6307 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6308 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6309 <compile_stack_type>: `size' and `avail' are now `size_t'.
6310
6311 * regex.h <regoff_t>: Use ssize_t, not int.
6312 (re_search, re_search_2, re_match, re_match_2): Arguments that
6313 specify buffer/string position and length are now ssize_t and
6314 size_t. Return type is regoff_t.
6315
613052cd
BK
63162011-04-16 Ben Key <bkey76@gmail.com>
6317
6318 * nsfont.m: Fixed bugs in ns_get_family and
6319 ns_descriptor_to_entity that were caused by using free to
6320 deallocate memory blocks that were allocated by xmalloc (via
6321 xstrdup). This caused Emacs to crash when compiled with
6322 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6323 --enable-checking=xmallocoverrun). xfree is now used to
6324 deallocate these memory blocks.
6325
4170f62f 63262011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6327
71b41406
PE
6328 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6329
9587a89d
PE
6330 emacs_write: Accept and return EMACS_INT for sizes.
6331 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6332 et seq.
6333 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6334 Accept and return EMACS_INT.
6335 (emacs_gnutls_write): Return the number of bytes written on
6336 partial writes.
6337 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6338 (emacs_read, emacs_write): Remove check for negative size, as the
6339 Emacs source code has been audited now.
9587a89d
PE
6340 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6341 (emacs_read, emacs_write): Use it.
273a5f82
PE
6342 * process.c (send_process): Adjust to the new signatures of
6343 emacs_write and emacs_gnutls_write. Do not attempt to store
6344 a byte offset into an 'int'; it might overflow.
9587a89d 6345 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6346
3e047f51
PE
6347 * sound.c: Don't assume sizes fit in 'int'.
6348 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6349 Return EMACS_INT, not int.
3e047f51 6350 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6351 Accept EMACS_INT, not int.
6352 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6353 record read return values.
6354
cc39a9db
BK
63552011-04-15 Ben Key <bkey76@gmail.com>
6356
c9d0ec6d
JB
6357 * keyboard.c (Qundefined): Don't declare static since it is used
6358 in nsfns.m.
6359 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6360 static since they are used in nsfont.m.
cc39a9db 6361
6c60eb9f
SM
63622011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6363
6364 * process.c (Qprocessp): Don't declare static.
6365 * lisp.h (Qprocessp): Declare again.
6366
7990b61a
JB
63672011-04-15 Juanma Barranquero <lekktu@gmail.com>
6368
6369 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6370
5d4cb038
PE
63712011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6372
8bd7b830 6373 Improve C-level modularity by making more things 'static'.
cd64ea1d 6374
e3b27b31
PE
6375 Don't publish debugger-only interfaces to other modules.
6376 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6377 (verify_bytepos, count_markers): Move decls to the only modules
6378 that need them.
6379 * region-cache.h (pp_cache): Likewise.
6380 * window.h (check_all_windows): Likewise.
6381 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6382
5d4cb038
PE
6383 * sysdep.c (croak): Now static, if
6384 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6385 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6386
6387 * alloc.c (refill_memory_reserve): Now static if
6388 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6389 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6390
e87b6180
PE
6391 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6392 Define only if USE_LUCID.
6393
ac64929e
PE
6394 * xrdb.c (x_customization_string, x_rm_string): Now static.
6395
6f37259d
PE
6396 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6397 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6398
1683e3ab
PE
6399 * xdisp.c (draw_row_with_mouse_face): Now static.
6400 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6401
de9c2632
PE
6402 * window.h (check_all_windows): Mark externally visible.
6403
2b96acb7
PE
6404 * window.c (window_deletion_count): Now static.
6405
6406 * undo.c: Make symbols static if they're not exported.
6407 (last_undo_buffer, last_boundary_position, pending_boundary):
6408 Now static.
6409
50436f33
PE
6410 * textprop.c (interval_insert_behind_hooks): Now static.
6411 (interval_insert_in_front_hooks): Likewise.
6412
64520e5c
PE
6413 * term.c: Make symbols static if they're not exported.
6414 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6415 (max_frame_lines, tty_set_terminal_modes):
6416 (tty_reset_terminal_modes, tty_turn_off_highlight):
6417 (get_tty_terminal): Now static.
6418 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6419 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6420 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6421 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6422 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6423
1fa53021
PE
6424 * sysdep.c: Make symbols static if they're not exported.
6425 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6426 Now static.
6427 (sigprocmask_set, full_mask): Remove; unused.
6428 (wait_debugging): Mark as visible.
6429 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6430 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6431
d4b43b22
PE
6432 * syntax.c (syntax_temp): Define only if !__GNUC__.
6433
b7c513d0
PE
6434 * sound.c (current_sound_device, current_sound): Now static.
6435
989b29ad
PE
6436 * search.c (searchbufs, searchbuf_head): Now static.
6437
13a55a78
PE
6438 * scroll.c (scroll_cost): Remove; unused.
6439 * dispextern.h (scroll_cost): Remove decl.
6440
de68a1fc
PE
6441 * region-cache.h (pp_cache): Mark as externally visible.
6442
40ccffa6
PE
6443 * process.c: Make symbols static if they're not exported.
6444 (process_tick, update_tick, create_process, chan_process):
6445 (Vprocess_alist, proc_buffered_char, datagram_access):
6446 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6447 (deactivate_process): Mark defn as static, as well as decl.
6448 * lisp.h (create_process): Remove decl.
6449 * process.h (chan_process, Vprocess_alist): Remove decls.
6450
ad64fc97
PE
6451 * print.c: Make symbols static if they're not exported.
6452 (print_depth, new_backquote_output, being_printed, print_buffer):
6453 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6454 (print_interval, print_number_index, initial_stderr_stream):
6455 Now static.
6456 * lisp.h (Fprinc): Remove decl.
6457 (debug_output_compilation_hack): Mark as externally visible.
6458
adddb265
PE
6459 * sysdep.c (croak): Move decl from here to syssignal.h.
6460 * syssignal.h (croak): Put it here, so the API can be checked when
6461 'croak' is called from dissociate_if_controlling_tty.
6462
1717ede2
PE
6463 * minibuf.c: Make symbols static if they're not exported.
6464 (minibuf_save_list, choose_minibuf_frame): Now static.
6465 * lisp.h (choose_minibuf_frame): Remove decl.
6466
fa5fb2bc
PE
6467 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6468
1e3890d1
PE
6469 * lread.c: Make symbols static if they're not exported.
6470 (read_objects, initial_obarray, oblookup_last_bucket_number):
6471 Now static.
6472 (make_symbol): Remove; unused.
6473 * lisp.h (initial_obarray, make_symbol): Remove decls.
6474
8a1414fa
PE
6475 * keyboard.c: Make symbols static if they're not exported.
6476 (single_kboard, recent_keys_index, total_keys, recent_keys):
6477 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6478 (this_single_command_key_start, echoing, last_auto_save):
6479 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6480 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6481 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6482 (Vlispy_mouse_stem, double_click_count):
6483 Now static.
6484 (force_auto_save_soon): Define only if SIGDANGER.
6485 (ignore_mouse_drag_p): Now static if
6486 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6487 (print_help): Remove; unused.
6488 (stop_character, last_timer_event): Mark as externally visible.
6489 * keyboard.h (ignore_mouse_drag_p): Declare only if
6490 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6491 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6492 * lisp.h (echoing): Remove decl.
6493 (force_auto_save_soon): Declare only if SIGDANGER.
6494 * xdisp.c (redisplay_window): Simplify code, to make it more
6495 obvious that ignore_mouse_drag_p is not accessed if !defined
6496 USE_GTK && !defined HAVE_NS.
6497
93ea6e8f
PE
6498 * intervals.c: Make symbols static if they're not exported.
6499 (merge_properties_sticky, merge_interval_right, delete_interval):
6500 Now static.
6501 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6502
77382fcc
PE
6503 * insdel.c: Make symbols static if they're not exported.
6504 However, leave prepare_to_modify_buffer alone. It's never
6505 called from outside this function, but that appears to be a bug.
6506 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6507 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6508 (adjust_after_replace_noundo): Remove; unused.
6509 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6510 (signal_before_change): Remove decls.
77382fcc 6511
9306c32e
PE
6512 * indent.c (val_compute_motion, val_vmotion): Now static.
6513
cd44d2eb
PE
6514 * image.c: Make symbols static if they're not exported.
6515 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6516 if USE_GTK.
6517 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6518 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6519
ad9a7a06
PE
6520 * fringe.c (standard_bitmaps): Now static.
6521 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6522
81626931
PE
6523 * frame.c: Make symbols static if they're not exported.
6524 (x_report_frame_params, make_terminal_frame): Now static.
6525 (get_frame_param): Now static, unless HAVE_NS.
6526 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6527 (x_get_resource_string): Remove; not used.
6528 * frame.h (make_terminal_frame, x_report_frame_params):
6529 (x_get_resource_string); Remove decls.
6530 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6531 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6532
239f9db9
PE
6533 * font.c, fontset.c: Make symbols static if they're not exported.
6534 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6535 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6536 * font.c (font_close_object): Now static.
6537 * font.h (font_close_object): Remove.
6538 * fontset.c (FONTSET_OBJLIST): Remove.
6539 (free_realized_fontset) #if-0 the body, which does nothing.
6540 (face_suitable_for_char_p): #if-0, as it's never called.
6541 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6542 * xfaces.c (face_at_string_position):
6543 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6544 since 0 is always ASCII.
6545
dfcf3579
PE
6546 * fns.c (weak_hash_tables): Now static.
6547
5045092b
PE
6548 * fileio.c: Make symbols static if they're not exported.
6549 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6550 (Vwrite_region_annotation_buffers): Now static.
6551
57a96f5c
PE
6552 * eval.c: Make symbols static if they're not exported.
6553 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6554 * lisp.h (backtrace_list): Remove decl.
6555
35f08c38
PE
6556 * emacs.c: Make symbols static if they're not exported.
6557 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6558 (fatal_error_code, fatal_error_signal_hook, standard_args):
6559 Now static.
6560 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6561 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6562 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6563 * lisp.h (fatal_error_signal_hook): Remove decl.
6564 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6565
f44bd759
PE
6566 * editfns.c: Move a (normally-unused) function to its only use.
6567 * editfns.c, lisp.h (get_operating_system_release): Remove.
6568 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6569 worth the hassle of breaking this out.
6570
b532497d
PE
6571 * xterm.c: Make symbols static if they're not exported.
6572 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6573 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6574 (x_destroy_window, x_delete_display):
6575 Now static.
6576 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6577 (x_mouse_leave): Remove; unused.
6578 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6579 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6580 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6581 Remove decls.
6582 (x_mouse_leave): Declare only if WINDOWSNT.
6583 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6584 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6585 USE_X_TOOLKIT.
6586
1675728f
PE
6587 * ftxfont.c: Make symbols static if they're not exported.
6588 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6589 HAVE_FREETYPE.
6590 * font.h (ftxfont_driver): Likewise.
6591
e4cebfca
PE
6592 * xfns.c: Make symbols static if they're not exported.
6593 (x_last_font_name, x_display_info_for_name):
6594 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6595 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6596 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6597 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6598 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6599 (last_show_tip_args): Now static.
6600 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6601 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6602 (x_screen_planes): Remove; unused.
6603 * dispextern.h (x_screen_planes): Remove decl.
6604
5bf46f05
PE
6605 * dispnew.c: Make symbols static if they're not exported.
6606 * dispextern.h (redraw_garbaged_frames, scrolling):
6607 (increment_row_positions): Remove.
6608 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6609 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6610 Now static.
6611 (redraw_garbaged_frames): Remove; unused.
6612
435f4c28
PE
6613 * xfaces.c: Make symbols static if they're not exported.
6614 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6615 Remove decls.
6616 * xterm.h (defined_color): Remove decls.
6617 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6618 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6619 (menu_face_changed_default, defined_color, free_realized_face):
6620 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6621 (ascii_face_of_lisp_face): Remove; unused.
6622
8524aef3
PE
6623 * xdisp.c: Make symbols static if they're not exported.
6624 * dispextern.h (scratch_glyph_row, window_box_edges):
6625 (glyph_to_pixel_coords, set_cursor_from_row):
6626 (get_next_display_element, set_iterator_to_next):
6627 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6628 (show_mouse_face): Remove decls
6629 * frame.h (message_buf_print): Likewise.
6630 * lisp.h (pop_message, set_message, check_point_in_composition):
6631 Likewise.
6632 * xterm.h (set_vertical_scroll_bar): Likewise.
6633 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6634 (message_buf_print, scratch_glyph_row, displayed_buffer):
6635 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6636 (get_next_display_element, show_mouse_face, window_box_edges):
6637 (frame_to_window_pixel_xy, check_point_in_composition):
6638 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6639 (glyph_to_pixel_coords): Remove; unused.
6640
16390cd2
PE
6641 * dired.c (file_name_completion): Now static.
6642
6643 * dbusbind.c (xd_in_read_queued_messages): Now static.
6644
a25f4dfa
PE
6645 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6646 * data.c (circular_list_error): Remove.
6647
14a9c8df
PE
6648 * commands.h (last_point_position, last_point_position_buffer):
6649 (last_point_position_window): Remove decls.
6650 * keyboard.c: Make these variables static.
6651
04f2d78b
CB
6652 * coding.h (coding, code_convert_region, encode_coding_gap):
6653 Remove decls.
74ab6df5
PE
6654 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6655 (iso_code_class, detect_coding, code_convert_region): Now static.
6656 (encode_coding_gap): Remove; unused.
6657
38dfbee1
PE
6658 * chartab.c (chartab_chars, chartab_bits): Now static.
6659
a2cb4e63
PE
6660 * charset.h (charset_iso_8859_1): Remove decl.
6661 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6662 Now static.
6663
127198fd
PE
6664 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6665 * ccl.c (Vccl_program_table): Now static.
6666 (check_ccl_update): Remove; unused.
6667
d85b608f
PE
6668 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6669 * category.h: ... from here.
6670 * category.c (check_category_table, set_category_set): Now static.
6671
31cd66f3
PE
6672 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6673 * lisp.h: Remove these decls.
6674
c358e587
PE
6675 * buffer.c (buffer_count): Remove unused var.
6676
e78aecca
PE
6677 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6678 so that it's not optimized away.
6679 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6680 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6681 exported only to the debugger.
6682
e192d7d3 6683 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6684 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6685
92470028
PE
6686 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6687 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6688 was inaccessible from Lisp.
6689 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6690 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6691
244ed907
PE
6692 alloc.c: Import and export fewer symbols, and remove unused items.
6693 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6694 is defined.
6695 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6696 it's not optimized away by whole-program optimization.
6697 (message_enable_multibyte, free_misc): Remove.
6698 (catchlist, handlerlist, mark_backtrace):
6699 Declare only if BYTE_MARK_STACK.
6700 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6701 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6702 (message_enable_multibyte): Remove decl.
6703 (free_misc, interval_free_list, float_block, float_block_index):
6704 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6705 (cons_free_list, last_marked_index):
6706 Now static.
6707 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6708 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6709 (mark_backtrace): Define only if BYTE_MARK_STACK.
6710 * xdisp.c (message_enable_multibyte): Now static.
6711
61c2b50e 6712 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6713 This makes it easier for human readers (and static analyzers)
6714 to see whether these variables are used from other modules.
6715 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6716 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6717 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6718 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6719 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6720 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6721 * xmenu.c, xselect.c:
6722 Declare Q* vars static if they are not used in other modules.
6723 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6724 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6725 Remove decls of unexported vars.
6726 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6727
95c82688
PE
6728 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6729
16a97296
PE
6730 Make Emacs functions such as Fatom 'static' by default.
6731 This makes it easier for human readers (and static analyzers)
6732 to see whether these functions can be called from other modules.
6733 DEFUN now defines a static function. To make the function external
6734 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6735 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6736 (Finit_image_library):
16a97296
PE
6737 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6738 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6739 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6740 Remove decls, since these functions are now static.
6741 (Funintern, Fget_internal_run_time): New decls, since these functions
6742 were already external.
95c82688 6743
16a97296
PE
6744 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6745 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6746 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6747 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6748 * keyboard.c, keymap.c, lread.c:
6749 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6750 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6751 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6752 Mark functions with DEFUE instead of DEFUN,
6753 if they are used in other modules.
6754 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6755 decls for now-static functions.
6756 * buffer.h (Fdelete_overlay): Remove decl.
6757 * callproc.c (Fgetenv_internal): Mark as internal.
6758 * composite.c (Fremove_list_of_text_properties): Remove decl.
6759 (Fcomposition_get_gstring): New forward static decl.
6760 * composite.h (Fcomposite_get_gstring): Remove decl.
6761 * dired.c (Ffile_attributes): New forward static decl.
6762 * doc.c (Fdocumntation_property): New forward static decl.
6763 * eval.c (Ffetch_bytecode): New forward static decl.
6764 (Funintern): Remove extern decl; now in .h file where it belongs.
6765 * fileio.c (Fmake_symbolic_link): New forward static decl.
6766 * image.c (Finit_image_library): New forward static decl.
6767 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6768 * intervals.h (Fprevious_property_change):
6769 (Fremove_list_of_text_properties): Remove decls.
6770 * keyboard.c (Fthis_command_keys): Remove decl.
6771 (Fcommand_execute): New forward static decl.
6772 * keymap.c (Flookup_key): New forward static decl.
6773 (Fcopy_keymap): Now static.
6774 * keymap.h (Flookup_key): Remove decl.
6775 * process.c (Fget_process): New forward static decl.
6776 (Fprocess_datagram_address): Mark as internal.
6777 * syntax.c (Fsyntax_table_p): New forward static decl.
6778 (skip_chars): Remove duplicate decl.
6779 * textprop.c (Fprevious_property_change): New forward static decl.
6780 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6781 Now internal.
6782 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6783 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6784
785bbd42
PE
6785 * editfns.c (Fformat): Remove unreachable code.
6786
8b913b57
AS
67872011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6788
6789 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6790 change. (Bug#8496)
6791
a6744a35
EZ
67922011-04-13 Eli Zaretskii <eliz@gnu.org>
6793
6794 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6795 when at ZV. (Bug#8487)
6796
e7974947
AS
67972011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6798
baad03f0
AS
6799 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6800 (Bug#8437)
6801 * keyboard.c (parse_tool_bar_item): Likewise.
6802 * sound.c (sound_cleanup, alsa_close): Likewise.
6803 * termcap.c (tgetent): Likewise.
6804 * xfns.c (x_default_font_parameter): Likewise.
6805 * xsettings.c (read_and_apply_settings): Likewise.
6806
e7974947
AS
6807 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6808 (overrun_check_free): Protoize.
6809
28272684
PE
68102011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6811
6812 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6813 since callers should never pass a negative size.
6814 Change the signature to match that of plain 'read' and 'write'; see
6815 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6816 * lisp.h: Update prototypes of emacs_write and emacs_read.
6817
11997c76
EZ
68182011-04-11 Eli Zaretskii <eliz@gnu.org>
6819
6820 * xdisp.c (redisplay_window): Don't try to determine the character
6821 position of the scroll margin if the window start point w->startp
e896f03c 6822 is outside the buffer's accessible region. (Bug#8468)
11997c76 6823
8a2cbd72
EZ
68242011-04-10 Eli Zaretskii <eliz@gnu.org>
6825
6826 Fix write-region and its subroutines for buffers > 2GB.
6827 * fileio.c (a_write, e_write): Modify declaration of arguments and
6828 local variables to support buffers larger than 2GB.
6829 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6830
6831 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6832 argument, local variables, and return value.
6833
6834 * lisp.h: Update prototypes of emacs_write and emacs_read.
6835
6836 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6837
4073e537 68382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6839
1ebfdcb6
PE
6840 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6841
b2ded58d
PE
6842 Fix more problems found by GCC 4.6.0's static checks.
6843
7d66342c
PE
6844 * xdisp.c (vmessage): Use a better test for character truncation.
6845
bbf47d44
PE
6846 * charset.c (load_charset_map): <, not <=, for optimization,
6847 and to avoid potential problems with integer overflow.
9248994d 6848 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6849 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6850 * editfns.c (Fformat): Likewise.
1e69125e 6851 * syntax.c (skip_chars): Likewise.
3befa583 6852
e3019616
PE
6853 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6854 This also lets GCC 4.6.0 generate slightly better loop code.
6855
becfa255
PE
6856 * callint.c (Fcall_interactively): <, not <=, for optimization.
6857 (Fcall_interactively): Count the number of arguments produced,
6858 not the number of arguments given. This is simpler and lets GCC
6859 4.6.0 generate slightly better code.
6860
dae0cd48
PE
6861 * ftfont.c: Distingish more carefully between FcChar8 and char.
6862 The previous code passed unsigned char * to a functions like
6863 strlen and xstrcasecmp that expect char *, which does not
6864 conform to the C standard.
6865 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6866 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6867 char * when the C standard requires it.
6868
76032d70
PE
6869 * keyboard.c (read_char): Remove unused var.
6870
eb3f1cc8
PE
6871 * eval.c: Port to Windows vsnprintf (Bug#8435).
6872 Include <limits.h>.
6873 (SIZE_MAX): Define if the headers do not.
6874 (verror): Do not give up if vsnprintf returns a negative count.
6875 Instead, grow the buffer. This ports to Windows vsnprintf, which
6876 does not conform to C99. Problem reported by Eli Zaretskii.
6877 Also, simplify the allocation scheme, by avoiding the need for
6878 calling realloc, and removing the ALLOCATED variable.
6879
70476b54
PE
6880 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6881
12020a9e
PE
6882 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6883 But keep the doprint source code for now, as we might revamp it
6884 and use it again (Bug#8435).
ea6c7ae6
PE
6885 * lisp.h (doprnt): Remove.
6886 * Makefile.in (base_obj): Remove doprnt.o.
6887 * deps.mk (doprnt.o): Remove.
6888
5fdb398c
PE
6889 error: Print 32- and 64-bit integers portably (Bug#8435).
6890 Without this change, on typical 64-bit hosts error ("...%d...", N)
6891 was used to print both 32- and 64-bit integers N, which relied on
6892 undefined behavior.
6893 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6894 New macro.
6895 * lisp.h (error, verror): Mark as printf-like functions.
6896 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6897 Report overflow in size calculations when allocating printf buffer.
6898 Do not truncate output string at its first null byte.
6899 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6900 Truncate the output at a character boundary, since vsnprintf does not
6901 do that.
6902 * charset.c (check_iso_charset_parameter): Convert internal
6903 character to string before calling 'error', since %c now has the
6904 printf meaning.
6905 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6906 overflow when computing char to be passed to 'error'. Do not
6907 pass Lisp_Object to 'error'; pass the integer instead.
6908 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6909 formatted with plain %d.
6910
b189fa66
PE
6911 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6912
bff87ef0
PE
6913 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6914
7e2cac20
PE
6915 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6916
ce4d90b5
PE
6917 * xterm.c (x_catch_errors): Remove duplicate declaration.
6918
266c9547
PE
6919 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6920
79c49ad2
PE
6921 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6922
368f4090
JM
69232011-04-10 Jim Meyering <meyering@redhat.com>
6924
6925 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6926 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6927 return ssize_t not "int", and use size_t as the buffer length.
6928 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6929 * gnutls.h: Update declarations.
6930 * process.c (read_process_output): Use ssize_t, to match.
6931 (send_process): Likewise.
6932
a32d4040
CY
69332011-04-09 Chong Yidong <cyd@stupidchicken.com>
6934
6935 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6936
8546720e 69372011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6938
04f2d78b
CB
6939 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6940 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6941
8546720e
GM
6942 * xterm.c (handle_one_xevent):
6943 * xmenu.c (create_and_show_popup_menu):
6944 * xselect.c (x_decline_selection_request)
6945 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6946
0a2f5c1a 69472011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6948
6949 Fix some uses of `int' instead of EMACS_INT.
6950 * search.c (string_match_1, fast_string_match)
6951 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6952 (scan_buffer, find_next_newline_no_quit)
6953 (find_before_next_newline, search_command, Freplace_match)
6954 (Fmatch_data): Make some `int' variables be EMACS_INT.
6955
6956 * xdisp.c (display_count_lines): 3rd argument and return value now
6957 EMACS_INT. All callers changed.
6958 (pint2hrstr): Last argument is now EMACS_INT.
6959
6960 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6961 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6962 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6963 (decode_coding_utf_16, decode_coding_emacs_mule)
6964 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6965 (decode_coding_ccl, decode_coding_charset)
6966 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6967 (decode_coding_iso_2022, decode_coding_emacs_mule)
6968 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6969 <char_offset, last_offset>: Declare EMACS_INT.
6970 (encode_coding_utf_8, encode_coding_utf_16)
6971 (encode_coding_emacs_mule, encode_invocation_designation)
6972 (encode_designation_at_bol, encode_coding_iso_2022)
6973 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6974 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6975 Declare EMACS_INT.
6976 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6977 (encode_invocation_designation): Last argument P_NCHARS is now
6978 EMACS_INT.
6979 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6980 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6981
6982 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6983 All users changed.
6984
6985 * ccl.c (Fccl_execute_on_string): Declare some variables
6986 EMACS_INT.
6987
8546720e 69882011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6989
6990 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6991
4e19a977
CS
69922011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6993
6994 * process.c (Fformat_network_address): Doc fix.
6995
87302331
R
69962011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6997
6998 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6999
cbb59342
CY
70002011-04-08 Chong Yidong <cyd@stupidchicken.com>
7001
7002 * keyboard.c (read_char): Call Lisp function help-form-show,
7003 instead of using internal_with_output_to_temp_buffer.
7004 (Qhelp_form_show): New var.
e0d38eeb 7005 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7006
7007 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7008
7009 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7010
e67a13ab
CY
70112011-04-06 Chong Yidong <cyd@stupidchicken.com>
7012
04f2d78b
CB
7013 * process.c (Flist_processes): Remove to Lisp.
7014 (list_processes_1): Delete.
e67a13ab 7015
973f782d
EZ
70162011-04-06 Eli Zaretskii <eliz@gnu.org>
7017
7c106b1e
EZ
7018 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7019
973f782d
EZ
7020 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7021
41cf7d1a 70222011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7023
ca23cc88
PE
7024 Fix more problems found by GCC 4.6.0's static checks.
7025
f390e2d5
PE
7026 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7027
42eea0d0
PE
7028 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7029
b69769da 7030 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7031
f9541e84
PE
7032 * xdisp.c (vmessage): Mark as a printf-like function.
7033
13841b55
PE
7034 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7035
c136c10f
PE
7036 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7037
5e2d4a30
PE
7038 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7039 printf-like functions.
7040 (tiff_load): Add casts to remove these marks before passing them
7041 to system-supplied API.
7042
583f48b9
PE
7043 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7044
b25d760e
PE
7045 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7046 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7047 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7048 directly, rather than having caller test rule sign. This avoids
7049 some unnecessary tests.
7050 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7051 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7052 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7053
bc7b6697 7054 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7055 (xfont_open): Avoid unnecessary tests.
bc7b6697 7056
27ccc379
PE
7057 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7058
dcd5c89a
PE
7059 * composite.h, composite.c (composition_gstring_put_cache):
7060 Use EMACS_INT, not int, for length.
7061
b13a45c6
PE
7062 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7063 breaking out part of COMPOSITION_DECODE_RULE.
7064 (COMPOSITION_DECODE_RULE): Use it.
7065 * composite.c (get_composition_id): Remove unused local vars,
7066 by using the new macro.
7067
1e792e4d
PE
7068 * textprop.c (set_text_properties_1): Change while to do-while,
7069 since the condition is always true at first.
7070
dc6c6455 7071 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7072 (interval_deletion_adjustment): Return unsigned value.
7073 All uses changed.
dc6c6455 7074
aba7731a
PE
7075 * process.c (list_processes_1, create_pty, read_process_output):
7076 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7077 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7078 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7079 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7080 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7081
fdfc4bf3
PE
7082 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7083
fca8fe46 7084 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7085 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7086
06a0259a 7087 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7088 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7089 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7090
e7b9e80f
PE
7091 * print.c (print_error_message): Avoid int overflow.
7092
56201685
PE
7093 * font.c (font_list_entities): Redo for clarity,
7094 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7095
78834453 7096 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7097 (font_score): Avoid potential overflow in diff calculation.
78834453 7098
0bc0b309 7099 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7100 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7101
e610eaca
PE
7102 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7103
b895abce
PE
7104 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7105 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7106 can always succeed if overflow has undefined behavior.
7107
1f1d9321 7108 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7109 (wordify): Omit three unnecessary tests.
1f1d9321 7110
c59478bc
PE
7111 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7112 All callers changed. This avoids the need for an unused var.
7113
79b73827
PE
7114 * casefiddle.c (casify_region): Remove var that is set but not used.
7115
a4db5dfe
PE
7116 * dired.c (file_name_completion): Remove var that is set but not used.
7117
43aae36e
PE
7118 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7119
2a47c44d 7120 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7121 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7122
a37c69bf
PE
7123 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7124 Check for integer overflow on size calculations.
7125
328ab8e7
PE
7126 * buffer.c (Fprevious_overlay_change): Remove var that is set
7127 but not used.
7128
e5a2a5cb
PE
7129 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7130 Remove vars that are set but not used.
8d84a6eb 7131 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7132 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7133
a60e5f68
PE
7134 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7135
f661cb61 7136 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7137 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7138
f0397f5a
PE
7139 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7140 that are set but not used.
7141
8664db06 7142 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7143 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7144
6abdaa4a
PE
7145 * xselect.c (x_get_local_selection, x_handle_property_notify):
7146 Remove vars that are set but not used.
7147
0ce7538d 7148 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7149 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7150
9ae848fc
PE
7151 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7152 Remove var that is set but not used.
0b918413
PE
7153 (scroll_bar_windows_size): Now size_t, not int.
7154 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7155 Check for overflow.
9ae848fc 7156
a5a62657
PE
7157 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7158 (map_tty_color) [!defined MSDOS]: Likewise.
7159
5c5cdd39
PE
7160 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7161
66ebf983
PE
7162 * coding.c: Remove vars that are set but not used.
7163 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7164 All callers changed.
7165 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7166 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7167 (decode_coding_charset): Remove vars that are set but not used.
7168
1be4d761
PE
7169 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7170 that is set but not used.
7171
47553fa8
PE
7172 * print.c (print_object): Remove var that is set but not used.
7173
1f7196bf 7174 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7175 The gnulib version avoids calling malloc in the usual case,
7176 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7177 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7178 * filelock.c (current_lock_owner): Likewise.
7179 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7180 * sysdep.c: Include allocator.h, careadlinkat.h.
7181 (emacs_no_realloc_allocator): New static constant.
7182 (emacs_readlink): New function.
fdb61804
PE
7183 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7184 ../lib/careadlinkat.h.
d1fdcab7 7185
f84c17c7
SM
71862011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7187
7188 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7189 first non-nil return value).
7190
ef3862ad
JD
71912011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7192
7193 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7194 if not defined (Bug#8403).
7195
376a7006
JB
71962011-04-02 Juanma Barranquero <lekktu@gmail.com>
7197
7198 * xdisp.c (display_count_lines): Remove parameter `start',
7199 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7200 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7201 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7202 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7203 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7204 and thereabouts. All callers changed.
7205 (get_per_char_metric): Remove parameter `f', unused since
7206 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7207
6ca3801d
JM
72082011-04-02 Jim Meyering <meyering@redhat.com>
7209
7210 do not dereference NULL upon failed strdup
7211 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7212 (ns_get_family): Likewise.
7213
d8e2b5ba
JB
72142011-04-02 Juanma Barranquero <lekktu@gmail.com>
7215
7216 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7217
8c74fcbd
JD
72182011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7219
7220 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7221 later (Bug#8403).
7222
7200d79c
SM
72232011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7224
03408648 7225 Add lexical binding.
7200d79c 7226
03408648
SM
7227 * window.c (Ftemp_output_buffer_show): New fun.
7228 (Fsave_window_excursion):
7229 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7230
7231 * lread.c (lisp_file_lexically_bound_p): New function.
7232 (Fload): Bind Qlexical_binding.
7233 (readevalloop): Remove `evalfun' arg.
7234 Bind Qinternal_interpreter_environment.
7235 (Feval_buffer): Bind Qlexical_binding.
7236 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7237 Mark as dynamic.
7238 (syms_of_lread): Declare `lexical-binding'.
7239
7240 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7241
7242 * keyboard.c (eval_dyn): New fun.
7243 (menu_item_eval_property): Use it.
ca105506
SM
7244
7245 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7246
03408648
SM
7247 * fns.c (concat, mapcar1): Accept byte-code-functions.
7248
7249 * eval.c (Fsetq): Handle lexical vars.
7250 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7251 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7252 (FletX, Flet): Obey lexical binding.
7253 (Fcommandp): Handle closures.
7254 (Feval): New `lexical' arg.
7255 (eval_sub): New function extracted from Feval. Use it almost
7256 everywhere where Feval was used. Look up vars in lexical env.
7257 Handle closures.
7258 (Ffunctionp): Move from subr.el.
7259 (Ffuncall): Handle closures.
7260 (apply_lambda): Remove `eval_flags'.
7261 (funcall_lambda): Handle closures and new byte-code-functions.
7262 (Fspecial_variable_p): New function.
7263 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7264 but without exporting it to Lisp.
23aba0ea 7265
23aba0ea 7266 * doc.c (Fdocumentation, store_function_docstring):
03408648 7267 * data.c (Finteractive_form): Handle closures.
23aba0ea 7268
03408648
SM
7269 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7270 interactive spec.
ba83908c 7271
04f2d78b
CB
7272 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7273 New byte-codes.
03408648
SM
7274 (exec_byte_code): New function extracted from Fbyte_code to handle new
7275 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7276
03408648 7277 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7278
03408648 7279 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7280
e2abce01
JB
72812011-03-31 Juanma Barranquero <lekktu@gmail.com>
7282
7283 * xdisp.c (redisplay_internal): Fix prototype.
7284
63696a73 72852011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7286
63696a73 7287 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7288 (try_scrolling): Use it when setting scroll_limit.
7289 Limit scrolling to 100 screen lines.
63696a73
EZ
7290 (redisplay_window): Even when falling back on "recentering",
7291 position point in the window according to scroll-conservatively,
7292 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7293
7294 (try_scrolling): When point is above the window, allow searching
7295 as far as scroll_max, or one screenful, to compute vertical
7296 distance from PT to the scroll margin position. This prevents
7297 try_scrolling from unnecessarily failing when
7298 scroll-conservatively is set to a value slightly larger than the
7299 window height. Clean up the case of PT below the margin at bottom
7300 of window: scroll_max can no longer be INT_MAX. When aggressive
7301 scrolling is in use, don't let point enter the opposite scroll
7302 margin as result of the scroll.
7303 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7304 threshold of 100 lines for never-recentering scrolling.
7305
e4cc2dfc
JB
73062011-03-31 Juanma Barranquero <lekktu@gmail.com>
7307
7308 * dispextern.h (move_it_by_lines):
7309 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7310 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7311 (message_log_check_duplicate): Remove parameters `prev_bol' and
7312 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7313 (redisplay_internal): Remove parameter `preserve_echo_area',
7314 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7315
7316 * indent.c (Fvertical_motion):
7317 * window.c (window_scroll_pixel_based, Frecenter):
7318 Don't pass `need_y_p' to `move_it_by_lines'.
7319
1c470562
SM
73202011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7321
44f230aa
SM
7322 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7323 steal a few bits to be more compact.
7324 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7325 Remove unneeded casts.
7326
1c470562
SM
7327 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7328
888adce9
ZK
73292011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7330
7331 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7332 binding" message (bug#7967).
7333
f838ed7b
PE
73342011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7335
77861b95
PE
7336 Fix more problems found by GCC 4.6.0's static checks.
7337
de6dbc14
PE
7338 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7339 Remove unused local var.
7340
f838ed7b
PE
7341 * editfns.c (Fmessage_box): Remove unused local var.
7342
792c7b2b
PE
7343 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7344 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7345 Omit unused local vars.
c499e557 7346 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7347 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7348 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7349 Omit unused local var.
7350
ba0165e1
PE
7351 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7352 Don't assume string length fits in int.
32ad8845 7353 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7354 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7355
3c59b4c9
PE
7356 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7357 instead of alloca (Bug#8344).
7358
a3eed478 7359 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7360 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7361
eb4d412d
PE
7362 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7363
1658b401
PE
7364 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7365 concerns.
7366
7367 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7368
7369 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7370
9a2c6e05
PE
7371 * keyboard.c (syms_of_keyboard): Use the same style as later
7372 in this function when indexing through an array. This also
7373 works around GCC bug 48267.
7374
03d0a109
PE
7375 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7376
44f730c8
PE
7377 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7378
fe75f926
PE
7379 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7380 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7381
ffa8c828
PE
7382 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7383 This avoids undefined behavior on integer overflow, and is a bit
7384 more convenient anyway since it is compared to a size_t variable.
7385
c5101a77
PE
7386 Variadic C functions now count arguments with size_t, not int.
7387 This avoids an unnecessary limitation on 64-bit machines, which
7388 caused (substring ...) to crash on large vectors (Bug#8344).
7389 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7390 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7391 All variadic functions and their callers changed accordingly.
c5101a77
PE
7392 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7393 * data.c (arith_driver, float_arith_driver): Likewise.
7394 * editfns.c (general_insert_function): Likewise.
7395 * eval.c (struct backtrace.nargs, interactive_p)
7396 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7397 (funcall_lambda, mark_backtrace): Likewise.
7398 * fns.c (concat): Likewise.
7399 * frame.c (x_set_frame_parameters): Likewise.
7400 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7401 0 if not found, not -1. All callers changed.
7402
dd3f25f7
PE
7403 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7404 (stack_copy_size): Now size_t, not int.
7405 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7406
461c2ab9
JB
74072011-03-28 Juanma Barranquero <lekktu@gmail.com>
7408
7409 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7410 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7411 All callers changed.
7412
7413 * lisp.h (multibyte_char_to_unibyte):
7414 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7415 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7416 * character.h (CHAR_TO_BYTE8):
7417 * cmds.c (internal_self_insert):
7418 * editfns.c (general_insert_function):
7419 * keymap.c (push_key_description):
7420 * search.c (Freplace_match):
7421 * xdisp.c (message_dolog, set_message_1): All callers changed.
7422
f6d62986
SM
74232011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7424
7425 * keyboard.c (safe_run_hook_funcall): New function.
7426 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7427 don't set the hook to nil, but remove the offending function instead.
7428 (Qcommand_hook_internal): Remove, unused.
7429 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7430 Vcommand_hook_internal.
7431
7432 * eval.c (enum run_hooks_condition): Remove.
7433 (funcall_nil, funcall_not): New functions.
7434 (run_hook_with_args): Call each function through a `funcall' argument.
7435 Remove `cond' argument, now redundant.
7436 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7437 (Frun_hook_with_args_until_failure): Adjust accordingly.
7438 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7439
1db5b1ad
JB
74402011-03-28 Juanma Barranquero <lekktu@gmail.com>
7441
7442 * dispextern.h (string_buffer_position): Remove declaration.
7443
7444 * print.c (strout): Remove parameter `multibyte', unused since
7445 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7446
7447 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7448 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7449 All callers changed.
7450
7451 * w32.c (_wsa_errlist): Use braces for struct initializers.
7452
7453 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7454 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7455 All callers changed.
7456 (string_buffer_position): Likewise. Also, make static (it's never
7457 used outside xdisp.c).
7458 (cursor_row_p): Remove parameter `w', unused since
7459 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7460 (decode_mode_spec): Remove parameter `precision', introduced during
7461 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7462 All callers changed.
7463
5ffb62aa
JD
74642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7465
7466 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7467
461c2ab9 74682011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7469
7470 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7471 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7472 (ns_update_auto_hide_menu_bar): New functions.
7473 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7474 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7475 ns_constrain_all_frames.
7476 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7477 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7478
5c380ffb
JD
74792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7480
7481 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7482
9af30bdf
GM
74832011-03-27 Glenn Morris <rgm@gnu.org>
7484
7485 * syssignal.h: Replace RETSIGTYPE with void.
7486 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7487 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7488 Replace SIGTYPE with void everywhere.
7489 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7490 * s/template.h (SIGTYPE): Remove commented out definition.
7491
e2abce01
JB
74922011-03-26 Eli Zaretskii <eliz@gnu.org>
7493
7494 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7495 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7496
f868cd8a
JB
74972011-03-26 Juanma Barranquero <lekktu@gmail.com>
7498
59eb0929
JB
7499 * w32.c (read_unc_volume): Use parameter `henum', instead of
7500 global variable `wget_enum_handle'.
7501
7502 * keymap.c (describe_vector): Remove parameters `indices' and
7503 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7504 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7505
f868cd8a
JB
7506 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7507
7508 * keyboard.c (timer_check): Remove parameter `do_it_now',
7509 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7510 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7511 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7512
7513 * keyboard.c (read_char):
7514 * w32menu.c (w32_menu_display_help):
7515 * xmenu.c (show_help_event, menu_help_callback):
7516 Adjust calls to `show_help_echo'.
7517
7518 * gtkutil.c (xg_maybe_add_timer):
7519 * keyboard.c (readable_events):
7520 * process.c (wait_reading_process_output):
7521 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7522
7523 * insdel.c (adjust_markers_gap_motion):
7524 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7525 (gap_left, gap_right): Don't call it.
7526
2ecf6fdb
CY
75272011-03-25 Chong Yidong <cyd@stupidchicken.com>
7528
7529 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7530 incurred during fontification.
7531
6b1f9ba4
JB
75322011-03-25 Juanma Barranquero <lekktu@gmail.com>
7533
7534 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7535 (DEFVAR_PER_BUFFER): Don't pass it.
7536
7537 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7538 (scrolling_window): Don't pass it.
7539
0f4a96b5
JB
75402011-03-25 Juanma Barranquero <lekktu@gmail.com>
7541
7542 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7543
7544 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7545 and `suffix'.
7546 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7547 of variables specific to SELinux and computation of `encoded_absname'.
7548
7549 * image.c (XPutPixel): Remove unused variable `height'.
7550
7551 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7552
7553 * unexw32.c (get_section_info): Remove unused variable `section'.
7554
7555 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7556 (system_process_attributes): Remove unused variable `sess'.
7557 (sys_read): Remove unused variable `err'.
7558
7559 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7560 (w32_wnd_proc): Remove unused variable `isdead'.
7561 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7562 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7563 (x_create_tip_frame): Remove unused variable `tem'.
7564
7565 * w32inevt.c (w32_console_read_socket):
7566 Remove unused variable `no_events'.
7567
7568 * w32term.c (x_draw_composite_glyph_string_foreground):
7569 Remove unused variable `width'.
7570
1149507c
JB
75712011-03-24 Juanma Barranquero <lekktu@gmail.com>
7572
7573 * w32term.c (x_set_glyph_string_clipping):
7574 Don't pass uninitialized region to CombineRgn.
7575
9c88f339
JB
75762011-03-23 Juanma Barranquero <lekktu@gmail.com>
7577
7578 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7579 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7580 (Fx_close_connection): Remove unused variable `i'.
7581
7582 * w32font.c (w32font_draw): Return number of glyphs.
7583 (w32font_open_internal): Remove unused variable `i'.
7584 (w32font_driver): Add missing initializer.
7585
7586 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7587 (fill_in_menu): Remove unused variable `items_added'.
7588
7589 * w32term.c (last_mouse_press_frame): Remove static global variable.
7590 (w32_clip_to_row): Remove unused variable `f'.
7591 (x_delete_terminal): Remove unused variable `i'.
7592
7593 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7594 (NOTHING): Remove unused static global variable.
7595 (uniscribe_check_otf): Remove unused variable `table'.
7596 (uniscribe_font_driver): Add missing initializers.
7597
dee091a3
JD
75982011-03-23 Julien Danjou <julien@danjou.info>
7599
7600 * term.c (Fsuspend_tty, Fresume_tty):
7601 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7602 * window.c (temp_output_buffer_show):
7603 * insdel.c (signal_before_change):
7604 * frame.c (Fhandle_switch_frame):
7605 * fileio.c (Fdo_auto_save):
7606 * emacs.c (Fkill_emacs):
7607 * editfns.c (save_excursion_restore):
7608 * cmds.c (internal_self_insert):
7609 * callint.c (Fcall_interactively):
7610 * buffer.c (Fkill_all_local_variables):
7611 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7612 Use Frun_hooks.
0f4a96b5 7613 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7614 unconditionnaly since it does the check itself.
7615
2c520ab5 76162011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7617
c9c49752
PE
7618 Fix more problems found by GCC 4.5.2's static checks.
7619
8abc3f12
PE
7620 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7621 the first time through the loop, since we know p0 < p1 then.
7622 This also avoids a gcc -Wstrict-overflow warning.
7623
a2d26660
PE
7624 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7625 leading to a memory leak, possible in functions like
7626 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7627 of objects (Bug#8318).
a2d26660 7628
916c72e9
PE
7629 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7630 that could (at least in theory) be that large.
7631
19ab8a18
PE
7632 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7633 This is less likely to overflow, and avoids undefined behavior if
7634 overflow does occur. All callers changed. Use strtoul to scan
7635 for the unsigned long integer.
b7cbbd6f
PE
7636 (pint2hrstr): Simplify and tune code slightly.
7637 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7638
f0641eff
PE
7639 * scroll.c (do_scrolling): Work around GCC bug 48228.
7640 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7641
7f650bb9
PE
7642 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7643 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7644 (validate_x_resource_name): Simplify count usage.
7645 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7646
37dd57d1
PE
7647 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7648 fail (Bug#8306).
81e56e61 7649
699979fc 7650 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7651
401bf9b4
PE
7652 * process.c (Fmake_network_process): Use socklen_t, not int,
7653 where POSIX says socklen_t is required in portable programs.
7654 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7655 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7656 (Fmake_network_process, server_accept_connection):
7657 (wait_reading_process_output, read_process_output):
7658 Likewise.
7659
b93aacde
PE
7660 * process.c: Rename or move locals to avoid shadowing.
7661 (list_processes_1, Fmake_network_process):
7662 (read_process_output_error_handler, exec_sentinel_error_handler):
7663 Rename or move locals.
4dc343ee 7664 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7665 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7666 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7667 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7668 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7669
af8a867c 7670 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7671 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7672 Include tparam.h instead, since it declares them.
af8a867c
PE
7673 * cm.h (PC): Remove extern decl; tparam.h now does this.
7674 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7675 * terminfo.c: Include tparam.h, to check interfaces.
7676 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7677 (tparam): Adjust signature to match interface in tparam.h;
7678 this removes some undefined behavior. Check that outstring and len
7679 are zero, which they always are with Emacs.
7680 * tparam.h (PC, BC, UP): New extern decls.
7681
0248044d 7682 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7683 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7684
8ff096c1 7685 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7686 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7687 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7688 (ftfont_list): Remove unused local.
49eaafba
PE
7689 (get_adstyle_property, ftfont_pattern_entity):
7690 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7691 Rename locals to avoid shadowing.
8ff096c1 7692
e2be39f6
PE
7693 * xfont.c (xfont_list_family): Mark var as initialized.
7694
c9735e30
PE
7695 * xml.c (make_dom): Now static.
7696
8f5201ae
PE
7697 * composite.c (composition_compute_stop_pos): Rename local to
7698 avoid shadowing.
b246f932
PE
7699 (composition_reseat_it): Remove unused locals.
7700 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7701 (composition_update_it): Mark var as initialized.
11b61122
PE
7702 (find_automatic_composition): Mark vars as initialized,
7703 with a FIXME (Bug#8290).
8f5201ae 7704
760fbc2c
PE
7705 character.h: Rename locals to avoid shadowing.
7706 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7707 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7708 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7709 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7710 to avoid shadowing.
7711
ff08eb85
PE
7712 * textprop.c (property_change_between_p): Remove; unused.
7713
fc7bf025
PE
7714 * intervals.c (interval_start_pos): Now static.
7715
235d7abc
PE
7716 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7717
44f230aa
SM
7718 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7719 Rename locals to avoid shadowing.
3e7d6594 7720
50060332
PE
7721 * sound.c (wav_play, au_play, Fplay_sound_internal):
7722 Fix pointer signedness.
d01f234b 7723 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7724 (wav_play): Initialize a variable to 0, to prevent undefined
7725 behavior (Bug#8278).
50060332 7726
c4fc4e30
PE
7727 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7728
918436ed
PE
7729 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7730
c939f91b
PE
7731 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7732 clobbering (Bug#8298).
b9c7f648
PE
7733 * sysdep.c (sys_subshell): Likewise.
7734 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7735
6bd8c144
PE
7736 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7737 This should get cleaned up, so that child_setup has the
7738 same signature on all platforms.
7739
7710357c 7740 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7741 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7742
c59da222
CY
77432011-03-22 Chong Yidong <cyd@stupidchicken.com>
7744
7745 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7746 not to be necessary, and produces flickering.
7747
66b87493
GM
77482011-03-20 Glenn Morris <rgm@gnu.org>
7749
7750 * config.in: Remove file.
7751
45b6f6d5
JB
77522011-03-20 Juanma Barranquero <lekktu@gmail.com>
7753
7754 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7755 are now in src/globals.h.
7756 (syms_of_minibuf): Remove spurious & from previous change.
7757
3ec03f7e
LL
77582011-03-20 Leo <sdl.web@gmail.com>
7759
7760 * minibuf.c (completing-read-function): New variable.
7761 (completing-read-default): Rename from completing-read.
7762 (completing-read): Call completing-read-function.
7763
b14e3e21
CY
77642011-03-19 Juanma Barranquero <lekktu@gmail.com>
7765
7766 * xfaces.c (Fx_load_color_file):
7767 Read color file from absolute filename (bug#8250).
7768
f2b726e6
JB
77692011-03-19 Juanma Barranquero <lekktu@gmail.com>
7770
7771 * makefile.w32-in: Update dependencies.
7772
09f6ff02
EZ
77732011-03-17 Eli Zaretskii <eliz@gnu.org>
7774
7775 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7776
29a6015a
PE
77772011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7778
a3a6c54e
PE
7779 Fix more problems found by GCC 4.5.2's static checks.
7780
b766f867
PE
7781 * process.c (make_serial_process_unwind, send_process_trap):
7782 (sigchld_handler): Now static.
7783
be02381c
PE
7784 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7785 That way, the code declares only the vars that it needs.
7786 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7787 * s/cygwin.h (PTY_ITERATION): Likewise.
7788 * s/darwin.h (PTY_ITERATION): Likewise.
7789 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7790
57048744
PE
7791 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7792 * process.c (allocate_pty): Don't declare stb unless it's needed.
7793
7914961c 7794 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7795 (CONSTANTLIM): Remove; unused.
7796 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7797 Define only if needed.
7914961c 7798
b3967b18
PE
7799 * unexelf.c (unexec): Name an expression,
7800 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7801 Use a different way to cause a compilation error if anyone uses
7802 n rather than nn, a way that does not involve shadowing.
73366a00 7803 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7804
29a6015a
PE
7805 * deps.mk (unexalpha.o): Remove; unused.
7806
43cfc33e 7807 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7808 * unexec.h: New file.
ce701a33
PE
7809 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7810 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7811 Depend on unexec.h.
7812 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7813 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7814 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7815 Change as necessary to match prototype in unexec.h.
ce701a33 7816
01f44d5a
PE
7817 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7818 shadowing.
4f63c6bb 7819 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7820
a6670b0b
PE
7821 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7822 Rename locals to avoid shadowing.
7823
cef2010d 7824 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7825 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7826
d4d7173a
PE
7827 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7828
f08b802a
PE
7829 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7830 warning when compiling print.c.
7831
3ddb0639
PE
7832 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7833 instead of using an uninitialized var.
5ad03b97 7834 (font_sort_entities): Mark var as initialized.
3ddb0639 7835
170a2692
PE
7836 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7837
e663c700
PE
7838 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7839 pointers to constants.
89bc529a 7840 (font_parse_fcname): Remove unused vars.
7b81e2d0 7841 (font_delete_unmatched): Now static.
ea838e10 7842 (font_get_spec): Remove; unused.
13a547c6
PE
7843 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7844 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7845 Rename or move locals to avoid shadowing.
e663c700 7846
2a80c887 7847 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7848 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7849
1384fa33 7850 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7851 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7852
8b2c52e9
PE
7853 * alloc.c (mark_backtrace): Move decl from here ...
7854 * lisp.h: ... to here, so that it can be checked.
7855
475545b5 7856 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7857 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7858 (lisp_indirect_variable): Name an expression,
7859 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7860 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7861
b1349114 7862 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7863 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7864 Use const pointer when appropriate.
b1349114 7865
a2928364
PE
7866 * lisp.h (get_system_name, get_operating_system_release):
7867 Move decls here, to check interfaces.
7868 * process.c (get_operating_system_release): Move decl to lisp.h.
7869 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7870 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7871 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7872 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7873 (Fformat_time_string, Fencode_time, Finsert_char):
7874 (Ftranslate_region_internal, Fformat):
7875 Rename or remove local vars to avoid shadowing.
9710023e 7876 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7877
a415e694
PE
7878 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7879 avoid shadowing.
7880
8ef4622d
PE
7881 * lisp.h (eassert): Check that the argument compiles, even if
7882 ENABLE_CHECKING is not defined.
7883
946f9a5b
PE
7884 * data.c (Findirect_variable): Name an expression, to avoid
7885 gcc -Wbad-function-cast warning.
112396d6 7886 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7887 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7888 (Fmake_variable_buffer_local, Fmake_local_variable):
7889 Mark variables as initialized.
52746918 7890 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7891
e5aab7e7 7892 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7893 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7894 Rename locals to avoid shadowing.
dff45157
PE
7895 (mark_stack): Move local variables into the #ifdef region where
7896 they're used.
7bc26fdb
PE
7897 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7898 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7899 needed otherwise.
7900 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7901 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7902 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7903
e5aab7e7
PE
7904 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7905 avoids undefined behavior in theory.
7906
4da60324
PE
7907 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7908
88043301
PE
7909 Use functions, not macros, for up- and down-casing (Bug#8254).
7910 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7911 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7912 to use the following functions instead of these macros.
7913 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7914 EMACS_INT, since callers assume the returned value fits in int.
7915 (upcase1): Likewise, for UPCASE_TABLE.
7916 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7917 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7918 the race-condition problem in the old DOWNCASE.
88043301 7919
19ed5445
PE
7920 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7921 Rename locals to avoid shadowing.
7922 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7923 (regex_compile, re_search_2, re_match_2_internal):
7924 Remove unused local vars.
952db0d7
PE
7925 (FREE_VAR): Rewrite so as not to use empty "else",
7926 which gcc can warn about.
da053e48 7927 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7928 (RETALLOC_IF): Define only if needed.
7929 (WORDCHAR_P): Likewise. This one is never needed, but is used
7930 only in a comment talking about a compiler bug, so put inside
7931 the #if 0 of that comment.
7932 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7933 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7934 Remove; unused.
19ed5445 7935
1f3561e4 7936 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7937 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7938 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7939
ded6f8f7
PE
7940 * search.c (simple_search): Remove unused var.
7941
dbd37a95
PE
7942 * dired.c (compile_pattern): Move decl from here ...
7943 * lisp.h: ... to here, so that it can be checked.
7944 (struct re_registers): New forward decl.
7945
7e47afad
PE
7946 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7947
85f24f61
PE
7948 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7949 All uses changed.
7950 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7951 Rename locals to avoid shadowing.
5671df8f 7952 (Fvertical_motion): Mark locals as initialized.
85f24f61 7953
181aa2be 7954 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7955 (casify_region): Mark local as initialized.
181aa2be 7956
930d429c
PE
7957 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7958
7082eac6
PE
7959 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7960 New macros, so that the caller can use some names other than
7961 gcpro1, gcpro2, etc.
7962 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7963 of the new macros.
7964 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7965 argument, for consistency with GCPRO2_VAR, etc: it is now the
7966 prefix of the variable, not the variable itself. All uses
7967 changed.
38b2c076
PE
7968 * dired.c (directory_files_internal, file_name_completion):
7969 Rename locals to avoid shadowing.
7970
15206ed9
PE
7971 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7972 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7973 dired.c's scmp function, had undefined behavior.
7974 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7975 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7976 * buffer.h: ... to here, because these macros use current_buffer,
7977 and the new implementation with inline functions needs to have
7978 current_buffer in scope now, rather than later when the macros
7979 are used.
7980 (downcase, upcase1): New static inline functions.
7981 (DOWNCASE, UPCASE1): Reimplement using these functions.
7982 This avoids undefined behavior in expressions like
7983 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7984 from race conditions in accessing the global variables
7985 case_temp1 and case_temp2.
7986 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7987 * lisp.h (case_temp1, case_temp2): Remove their decls.
7988 * character.h (ASCII_CHAR_P): Move from here ...
7989 * lisp.h: ... to here, so that the inline functions mentioned
7990 above can use them.
7991
4a6bea26
PE
7992 * dired.c (directory_files_internal_unwind): Now static.
7993
f14b7e14
PE
7994 * fileio.c (file_name_as_directory, directory_file_name):
7995 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7996 Now static.
2893f146
PE
7997 (file_name_as_directory): Use const pointers when appropriate.
7998 (Fexpand_file_name): Likewise. In particular, newdir might
7999 point at constant storage, so make it a const pointer.
fd4ead52 8000 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8001 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8002 signedness issues.
f839df0c
PE
8003 (Fset_file_times, Finsert_file_contents, auto_save_error):
8004 Rename locals to avoid shadowing.
f14b7e14 8005
5716756e 8006 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8007 (Ftry_completion, Fall_completions): Rename or remove locals
8008 to avoid shadowing.
5716756e 8009
b4c3046a
PE
8010 * marker.c (bytepos_to_charpos): Remove; unused.
8011
b45db522
PE
8012 * lisp.h (verify_bytepos, count_markers): New decls,
8013 so that gcc does not warn that these functions aren't declared.
8014
85876d07
PE
8015 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8016 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8017 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8018 (copy_text): Remove unused local var.
85876d07 8019
03d78a21 8020 * filelock.c (within_one_second): Now static.
b3dd38ab 8021 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8022
5df8f01b
PE
8023 * buffer.c (fix_overlays_before): Mark locals as initialized.
8024 (fix_start_end_in_overlays): Likewise. This function should be
8025 simplified by using pointers-to-pointers, but that's a different
8026 matter.
b1d876f1 8027 (switch_to_buffer_1): Now static.
8f54f30a
PE
8028 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8029 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8030
a70072c9 8031 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8032 Fix pointer signedness issue.
edced198
PE
8033 (sys_subshell): Mark local as volatile if checking for lint,
8034 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8035 (MAXPATHLEN): Define only if needed.
a70072c9 8036
a0977c44
PE
8037 * process.c (serial_open, serial_configure): Move decls from here ...
8038 * systty.h: ... to here, so that they can be checked.
8039
a884fdcc
PE
8040 * fns.c (get_random, seed_random): Move extern decls from here ...
8041 * lisp.h: ... to here, so that they can be checked.
8042
604efe86 8043 * sysdep.c (reset_io): Now static.
b8950c94 8044 (wait_for_termination_signal): Remove; unused.
604efe86 8045
38fc62d9
PE
8046 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8047 (copy_keymap_item, append_key, push_text_char_description):
8048 Now static.
1004a21a 8049 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8050 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8051 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8052 (describe_map_tree):
8053 Rename locals to avoid shadowing.
38fc62d9 8054
2f2650da
PE
8055 * keyboard.c: Declare functions static if they are not used elsewhere.
8056 (echo_char, echo_dash, cmd_error, top_level_2):
8057 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8058 (read_char, kbd_buffer_get_event, make_lispy_position):
8059 (make_lispy_event, make_lispy_movement, apply_modifiers):
8060 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8061 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8062 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8063 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8064 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8065
a053e86c 8066 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8067 (mark_kboards): Move decl here ...
8068 * alloc.c (mark_kboards): ... from here.
a053e86c 8069
4752793e
PE
8070 * lisp.h (force_auto_save_soon): New decl.
8071
74f10ca7 8072 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8073 (DEFINE_DUMMY_FUNCTION): New macro.
8074 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8075 Use it.
c03cd23f
PE
8076 (main): Add casts to avoid warnings
8077 if GCC considers string literals to be constants.
74f10ca7 8078
022e70d4
PE
8079 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8080
59d6fe83
PE
8081 * dbusbind.c: Pointer signedness fixes.
8082 (xd_signature, xd_append_arg, xd_initialize):
8083 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8084 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8085 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8086 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8087
78320123
PE
8088 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8089 if GCC considers string literals to be constants.
49cebcca 8090 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8091
35ac2a97
SM
80922011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8093
fb103ca9
SM
8094 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8095 (print_preprocess, print_object): New macro to fix last change.
8096
35ac2a97
SM
8097 * print.c (print_preprocess): Don't forget font objects.
8098
62973b41
JB
80992011-03-16 Juanma Barranquero <lekktu@gmail.com>
8100
8101 * emacs.c (USAGE3): Doc fixes.
8102
0e48bb22
AS
81032011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8104
8105 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8106 structure.
8107
7684e57b
JB
81082011-03-14 Juanma Barranquero <lekktu@gmail.com>
8109
8110 * lisp.h (VWindow_system, Qfile_name_history):
8111 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8112 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8113 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8114
8115 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8116 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8117
8118 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8119 * w32console.c (detect_input_pending, read_input_pending)
8120 (encode_terminal_code):
8121 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8122 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8123 (w32_system_caret_y, Qfile_name_history):
8124 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8125 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8126 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8127 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8128 * w32proc.c (Qlocal, report_file_error):
8129 * w32term.c (Vwindow_system, updating_frame):
8130 * w32uniscribe.c (initialized, uniscribe_font_driver):
8131 Remove unneeded extern declarations.
8132
2aa46d6c
CY
81332011-03-14 Chong Yidong <cyd@stupidchicken.com>
8134
c96bbc66 8135 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8136
cffc6f3b
CY
81372011-03-13 Chong Yidong <cyd@stupidchicken.com>
8138
8139 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8140 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8141 These macros can no longer be used for assignment.
8142
44f230aa
SM
8143 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8144 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8145 (record_buffer_markers, fetch_buffer_markers): New functions for
8146 recording and fetching special buffer markers.
8147 (set_buffer_internal_1, set_buffer_temp): Use them.
8148
8149 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8150
8151 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8152
8153 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8154 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8155
8156 * xdisp.c (hscroll_window_tree):
8157 (reconsider_clip_changes): Use PT instead of BUF_PT.
8158
d251f04b
EZ
81592011-03-13 Eli Zaretskii <eliz@gnu.org>
8160
8161 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8162 $(EMACS_ROOT)/lib/intprops.h.
8163
f0c77cd1
PE
81642011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8165
3eca4629
PE
8166 Fix more problems found by GCC 4.5.2's static checks.
8167
7c86ee98
PE
8168 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8169 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8170 (xg_free_frame_widgets): Make it clear that a local variable is
8171 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8172 (gdk_window_get_screen): Make it clear that this macro is needed
8173 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8174 (int_gtk_range_get_value): New function, which avoids a diagnostic
8175 from gcc -Wbad-function-cast.
8176 (xg_set_toolkit_scroll_bar_thumb): Use it.
8177 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8178 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8179 (get_utf8_string, xg_get_file_with_chooser):
8180 Rename locals to avoid shadowing.
8181 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8182
41729b81
PE
8183 * xgselect.c (xg_select): Remove unused var.
8184
f0c77cd1
PE
8185 * image.c (four_corners_best): Mark locals as initialized.
8186 (gif_load): Initialize transparent_p to zero (Bug#8238).
8187 Mark another local as initialized.
ec6cf4c6 8188 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8189
ce0ad53d 8190 * image.c (clear_image_cache): Now static.
d5d5a617 8191 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8192 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8193 (x_edge_detection): Remove unnecessary cast that
8194 gcc -Wbad-function-cast diagnoses.
2037898d 8195 (gif_load): Fix pointer signedness.
6ae141d6
PE
8196 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8197 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8198
33383987 81992011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8200
d32df629
PE
8201 Improve quality of tests for time stamp overflow.
8202 For example, without this patch (encode-time 0 0 0 1 1
8203 1152921504606846976) returns the obviously-bogus value (-948597
8204 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8205 reports time overflow. See
8206 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8207 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8208 * editfns.c: Include limits.h and intprops.h.
8209 (TIME_T_MIN, TIME_T_MAX): New macros.
8210 (time_overflow): Move earlier, to before first use.
8211 (hi_time, lo_time): New functions, for an accurate test for
8212 out-of-range times.
8213 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8214 (Fget_internal_run_time): Don't assume time_t fits in int.
8215 (make_time): Use list2 instead of Fcons twice.
8216 (Fdecode_time): More accurate test for out-of-range times.
8217 (check_tm_member): New function.
8218 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8219 (lisp_time_argument): Don't rely on undefined left-shift and
8220 right-shift behavior when checking for time stamp overflow.
8be6f318 8221
fe31d94c
PE
8222 * editfns.c (time_overflow): New function, refactoring common code.
8223 (Fformat_time_string, Fdecode_time, Fencode_time):
8224 (Fcurrent_time_string): Use it.
8225
8be6f318
PE
8226 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8227 * dired.c (make_time): Move to ...
8228 * editfns.c (make_time): ... here.
8229 * systime.h: Note the move.
8230
09d9db2c 82312011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8232
126bc0dc
YM
8233 * fringe.c (update_window_fringes): Remove unused variables.
8234
c47cbdfd
YM
8235 * unexmacosx.c (copy_data_segment): Also copy __got section.
8236 (Bug#8223)
8237
7ac80be9
EZ
82382011-03-12 Eli Zaretskii <eliz@gnu.org>
8239
c96bbc66 8240 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8241 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8242 Constify `char *' arguments and their references according to
8243 prototypes in tparam.h.
8244
ecb0f94d 8245 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8246
7ac80be9
EZ
8247 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8248 Adapt all references accordingly.
8249
8250 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8251
ef1fd07e
TT
82522011-03-11 Tom Tromey <tromey@redhat.com>
8253
8254 * buffer.c (syms_of_buffer): Remove obsolete comment.
8255
7ef4b50c
EZ
82562011-03-11 Eli Zaretskii <eliz@gnu.org>
8257
8258 * termhooks.h (encode_terminal_code): Declare prototype.
8259
8260 * msdos.c (encode_terminal_code): Don't declare prototype.
8261
8262 * term.c (encode_terminal_code): Now external again, used by
8263 w32console.c and msdos.c.
8264
44f230aa
SM
8265 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8266 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8267
4b1ec863 82682011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8269
1714f52b 8270 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8271
4b1ec863
PE
8272 * fringe.c (update_window_fringes): Mark locals as initialized
8273 (Bug#8227).
8274 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8275
524c7aa6
PE
8276 * alloc.c (mark_fringe_data): Move decl from here ...
8277 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8278 to check its interface.
8279 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8280
a5c0af81 8281 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8282 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8283 (fontset_font): Mark local as initialized.
a9a06e0b 8284 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8285
b4716021
PE
8286 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8287
811e9bac 8288 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8289 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8290 (x_own_selection, Fx_disown_selection_internal): Rename locals
8291 to avoid shadowing.
8292 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8293
7e3ab302
PE
8294 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8295 so that the caller can use some name other than gcpro1.
8296 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8297 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8298 (Fx_backspace_delete_keys_p):
8299 Use them to avoid shadowing, and rename vars to avoid shadowing.
8300 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8301 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8302 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8303 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8304 Remove unused locals.
7e3ab302
PE
8305 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8306 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8307 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8308 macros.
f78faa98 8309
e2b13473
PE
8310 * xterm.h (x_mouse_leave): New decl.
8311
77f23912
PE
8312 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8313 Remove unused functions.
cdf4ba58
PE
8314 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8315 (x_calc_absolute_position): Now static.
7411c686 8316 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8317 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8318 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8319 unless they are used.
38d0b34a
PE
8320 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8321 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8322 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8323 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8324 (x_error_catcher, x_connection_closed, x_error_handler):
8325 (x_error_quitter, xembed_send_message, x_iconify_frame):
8326 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8327 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8328 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8329
44f230aa
SM
8330 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8331 Rename or move locals to avoid shadowing.
6b463e58 8332 (tty_defined_color, merge_face_heights): Now static.
5967d051 8333 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8334 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8335 does not deduce is never used uninitialized.
73719eba
PE
8336 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8337 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8338
426994c3 8339 * terminal.c (store_terminal_param): Now static.
5489860b 8340
032f1620 8341 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8342 (set_frame_menubar): Remove unused local.
d4323972 8343 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8344 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8345 since they might point to immutable storage.
281585b0
PE
8346 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8347 since it's unused otherwise.
032f1620 8348
367c19e5 8349 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8350 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8351 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8352 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8353 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8354 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8355 does not deduce are never used uninitialized.
70739cbe 8356
07b48fa9
PE
8357 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8358
8868a238 8359 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8360 * window.c (window_loop, size_window):
8361 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8362
7e5cf297 8363 * window.c (display_buffer): Now static.
d6550a9f
PE
8364 (size_window): Mark variables that gcc -Wuninitialized
8365 does not deduce are never used uninitialized.
a586633d
PE
8366 * window.h (check_all_windows): New decl, to forestall
8367 gcc -Wmissing-prototypes diagnostic.
5b555da1 8368 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8369
f6095868
PE
8370 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8371 shadowing.
8372 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8373 Include <limits.h>.
8374 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8375 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8376 (load_charset_map): Mark variables that gcc -Wuninitialized
8377 does not deduce are never used uninitialized.
53df7c11 8378 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8379
f38b440c
PE
8380 * coding.c (coding_set_source, coding_set_destination):
8381 Use "else { /* comment */ }" rather than "else /* comment */;"
8382 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8383 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8384 a block, when the outer 'i' will do.
8385 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8386 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8387 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8388 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8389 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8390 Rename locals to avoid shadowing.
8391 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8392 * coding.c (emacs_mule_char, encode_invocation_designation):
8393 Now static, since they're not used elsewhere.
413bb2db 8394 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8395 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8396 (decode_coding_emacs_mule): Mark variables that gcc
8397 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8398 (detect_coding_iso_2022): Initialize a local variable that might
8399 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8400 this initialization is needed. (Bug#8211)
5f58e762
PE
8401 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8402 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8403 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8404 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8405 Remove unused macros.
f38b440c 8406
232b38b9 8407 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8408 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8409 * character.c (string_count_byte8): Likewise.
232b38b9 8410
fb90da1b
PE
8411 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8412 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8413
fb93dbc2
PE
8414 * chartab.c (copy_sub_char_table): Now static, since it's not used
8415 elsewhere.
5c156ace
PE
8416 (sub_char_table_ref_and_range, char_table_ref_and_range):
8417 Rename locals to avoid shadowing.
bbcd0949 8418 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8419
7d3b3862 8420 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8421 (BIDI_BOB): Remove unused macro.
7d3b3862 8422
6be7d3da
PE
8423 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8424 deduce are never used uninitialized.
c2ed9c8b 8425 * term.c (encode_terminal_code): Likewise.
6be7d3da 8426
75f8807f 8427 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8428
50938595
PE
8429 * tparam.h: New file.
8430 * term.c, tparam.h: Include it.
8431 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8432 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8433 Move these decls to tparam.h, and make them agree with what
8434 is actually in tparam.c. The previous trick of using incompatible
8435 decls in different modules does not conform to the C standard.
8436 All callers of tparam changed to use tparam's actual API.
8437 * tparam.c (tparam1, tparam, tgoto):
8438 Use const pointers where appropriate.
8439
fbceeba2
PE
8440 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8441 * cm.h (struct cm): Likewise.
8442 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8443 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8444 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8445 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8446 (turn_on_face, init_tty): Likewise.
8447 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8448
7f3f1250
PE
8449 * term.c (term_mouse_position): Rename local to avoid shadowing.
8450
e6ca6543
PE
8451 * alloc.c (mark_ttys): Move decl from here ...
8452 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8453
c40f8d15
AS
84542011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8455
8456 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8457
cfe0661d
JB
84582011-03-09 Juanma Barranquero <lekktu@gmail.com>
8459
8460 * search.c (compile_pattern_1): Remove argument regp, unused since
8461 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8462 (compile_pattern): Don't pass it.
8463
0afb4571
J
84642011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8465
8466 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8467 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8468 for ! HAVE_GTK3.
8469 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8470
8471 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8472
8473 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8474 gdk_window_get_screen, gdk_window_get_geometry,
8475 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8476 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8477 (xg_get_pixbuf_from_pixmap): New function.
8478 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8479 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8480 Call xg_get_pixbuf_from_pixmap instead of
8481 gdk_pixbuf_get_from_drawable.
8482 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8483 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8484 (xg_check_special_colors): Use GtkStyleContext and its functions
8485 for HAVE_GTK3.
8486 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8487 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8488 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8489 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8490 Call gtk_widget_get_preferred_size.
0afb4571
J
8491 (xg_frame_resized): gdk_window_get_geometry only takes 5
8492 parameters.
44f230aa
SM
8493 (xg_win_to_widget, xg_event_is_for_menubar):
8494 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8495 (xg_set_widget_bg): New function.
8496 (delete_cb): New function.
895009e1 8497 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8498 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8499 (xg_set_background_color): Call xg_set_widget_bg.
8500 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8501 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8502 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8503 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8504 if ! HAVE_GTK3.
8505 (update_frame_tool_bar): Call gtk_widget_hide.
8506 (xg_initialize): Use GDK_KEY_g.
8507
8508 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8509 if ! HAVE_GTK3
8510 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8511
8512 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8513 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8514 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8515
1c2cc4ef
JB
85162011-03-08 Juanma Barranquero <lekktu@gmail.com>
8517
8518 * w32xfns.c (select_palette): Check success of RealizePalette against
8519 GDI_ERROR, not zero.
8520
33383987 8521See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8522
8523;; Local Variables:
8524;; coding: utf-8
aac0c6e3
MR
8525;; End:
8526
33383987 8527 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8528
8529 This file is part of GNU Emacs.
8530
8531 GNU Emacs is free software: you can redistribute it and/or modify
8532 it under the terms of the GNU General Public License as published by
8533 the Free Software Foundation, either version 3 of the License, or
8534 (at your option) any later version.
8535
8536 GNU Emacs is distributed in the hope that it will be useful,
8537 but WITHOUT ANY WARRANTY; without even the implied warranty of
8538 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8539 GNU General Public License for more details.
8540
8541 You should have received a copy of the GNU General Public License
8542 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.