Don't use deprecated functions when compiling with Gtk3.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
383b7c95
JD
12012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4 not defined (Bug#11768).
5 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
6 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
7 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
8 followed by gtk_box_set_homogeneous (Bug#11768).
9 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
10 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
11 gtk_scrollbar_new (Bug#11768).
12 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
13 (is_box_type): New function (Bug#11768).
14 (xg_tool_item_stale_p): Call is_box_type.
15 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
16 with default display (Bug#11768).
17
d6e7bf45
EZ
182012-07-05 Eli Zaretskii <eliz@gnu.org>
19
20 * xdisp.c (window_hscroll_limited): New function.
21 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
22 coordinates when window's hscroll is set to insanely large
23 values. (Bug#11857)
24
431391ec
JB
252012-07-05 Juanma Barranquero <lekktu@gmail.com>
26
27 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
28 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
29
23f86fce
DA
302012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
31
32 Cleanup xmalloc.
33 * lisp.h (xzalloc): New prototype. Omit needless casts.
34 * alloc.c (xzalloc): New function. Omit needless casts.
35 * charset.c: Omit needless casts. Convert all calls to
36 xmalloc with following memset to xzalloc.
37 * dispnew.c: Likewise.
38 * fringe.c: Likewise.
39 * image.c: Likewise.
40 * sound.c: Likewise.
41 * term.c: Likewise.
42 * w32fns.c: Likewise.
43 * w32font.c: Likewise.
44 * w32term.c: Likewise.
45 * xfaces.c: Likewise.
46 * xfns.c: Likewise.
47 * xterm.c: Likewise.
48 * atimer.c: Omit needless casts.
49 * buffer.c: Likewise.
50 * callproc.c: Likewise.
51 * ccl.c: Likewise.
52 * coding.c: Likewise.
53 * composite.c: Likewise.
54 * doc.c: Likewise.
55 * doprnt.c: Likewise.
56 * editfns.c: Likewise.
57 * emacs.c: Likewise.
58 * eval.c: Likewise.
59 * filelock.c: Likewise.
60 * fns.c: Likewise.
61 * gtkutil.c: Likewise.
62 * keyboard.c: Likewise.
63 * lisp.h: Likewise.
64 * lread.c: Likewise.
65 * minibuf.c: Likewise.
66 * msdos.c: Likewise.
67 * print.c: Likewise.
68 * process.c: Likewise.
69 * region-cache.c: Likewise.
70 * search.c: Likewise.
71 * sysdep.c: Likewise.
72 * termcap.c: Likewise.
73 * terminal.c: Likewise.
74 * tparam.c: Likewise.
75 * w16select.c: Likewise.
76 * w32.c: Likewise.
77 * w32reg.c: Likewise.
78 * w32select.c: Likewise.
79 * w32uniscribe.c: Likewise.
80 * widget.c: Likewise.
81 * xdisp.c: Likewise.
82 * xmenu.c: Likewise.
83 * xrdb.c: Likewise.
84 * xselect.c: Likewise.
85
0497dc44
PE
862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
87
88 * fileio.c (time_error_value): Check the right error number.
89 Problem reported by Troels Nielsen in
90 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
91
356e7178
PE
922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
93
4e71fd89
PE
94 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
95 This should be fixed in a better way; see Eli Zaretskii in
96 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
97 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
98
f0941253
PE
99 * fileio.c (time_error_value): Rename from special_mtime.
100 The old name's problems were noted by Eli Zaretskii in
101 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
102
065c9eb4
PE
103 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
104 This variable's comment says Emacs needs at least one GDB-visible
105 symbol of type enum pvec_type, to work around GDB problems.
106 The symbol's value doesn't matter.
107
356e7178
PE
108 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
109 that causes compilation to fail on pre-C99 compilers.
110
95f61aa2
JB
1112012-07-04 Juanma Barranquero <lekktu@gmail.com>
112
113 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
114 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
115
3884d954
DA
1162012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
117
d209e2fb 118 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
119 headers for buffer_defaults and buffer_local_symbols.
120 Reported by Juanma Barranquero <lekktu@gmail.com>.
121
ee28be33
SM
1222012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
123
124 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
125 * lisp.h (enum pvec_type): Use fewer bits.
126 (PSEUDOVECTOR_SIZE_BITS): New constant.
127 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
128 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
129 change in pvec_type.
130 (PSEUDOVECTOR_TYPEP): New macro.
131 (TYPED_PSEUDOVECTORP): Use it.
132 * fns.c (internal_equal): Adapt code to extract pvectype.
133 * emacs.c (gdb_pvec_type): Update type.
134 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
135 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
136 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
137 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
138 (sweep_vectors): Use it. Use local var `total_bytes' instead of
139 abusing vector->header.next.nbytes.
140 (live_vector_p): Use PVEC_TYPE.
141 (mark_object): Adapt code to extract pvectype. Use switch.
142
c7f2cd7f
PE
1432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
144
145 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
146 Tighten new eassert a bit.
147
8ce70ed2
DA
1482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
149
150 Fix compilation with --enable-gcc-warnings and -O1
151 optimization level.
152 * doprnt.c (doprnt): Change type of tem to int, initialize
153 to avoid compiler warning. Add eassert.
154 * search.c (simple_search): Initialize match_byte to avoid
155 compiler warning. Add eassert.
156
dea7f1e5
PE
1572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
158
24a212eb
PE
159 Avoid weird behavior with large horizontal scrolls.
160 Without this change, for example, large hscroll values would
161 mess up Emacs's display on Fedora 15 x86, presumably due to
162 overflows in int calculations in the display code.
163 Also, if buffers had long lines, Emacs would freeze.
164 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
165 (set_window_hscroll): New function, containing the old guts of
166 Fset_window_hscroll. Return the clipped value.
167 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
168 This avoids the need to check against PTRDIFF_MAX.
169
dea7f1e5
PE
170 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
171
76046526
DA
1722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
173
174 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
175
39adff0d
PE
1762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
177
63807d47
PE
178 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
179 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
180 since GCC 4.4.6 issues a bogus warning for them.
181
39adff0d
PE
182 Fix bugs in file timestamp newness comparisons.
183 * fileio.c (Ffile_newer_than_file_p):
184 * lread.c (Fload): Use full timestamp resolution of files,
185 not just the 1-second resolution, so that files that are only
186 slightly newer still count as newer.
187 * fileio.c (Ffile_newer_than_file_p): Don't assume file
188 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
189
dbeed9a6
PE
1902012-07-03 Paul Eggert <eggert@cs.ucla.edu>
191
192 * fileio.c: Improve handling of file time marker. (Bug#11852)
193 (special_mtime): New function.
194 (Finsert_file_contents, Fverify_visited_file_modtime):
195 Use it to set special mtime values consistently.
196
636334d6
AS
1972012-07-03 Andreas Schwab <schwab@linux-m68k.org>
198
199 * fileio.c (Finsert_file_contents): Properly handle st_mtime
200 marker for non-existing file. (Bug#11852)
201
e2017fe2
GM
2022012-07-03 Glenn Morris <rgm@gnu.org>
203
204 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
205 and did not make it into globals.h).
206
404dbd37
TT
2072012-07-03 Tom Tromey <tromey@redhat.com>
208
209 * window.c (Fset_window_margins, Fset_window_fringes)
210 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
211 * textprop.c (Fprevious_property_change): No longer static.
212 * syntax.c (Fsyntax_table_p): No longer static.
213 * process.c (Fget_process, Fprocess_datagram_address): No longer
214 static.
215 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
216 * keyboard.c (Fcommand_execute): No longer static.
217 Remove EXFUN.
218 * insdel.c (Fcombine_after_change_execute): No longer static.
219 * image.c (Finit_image_library): No longer static.
220 * fileio.c (Fmake_symbolic_link): No longer static.
221 * eval.c (Ffetch_bytecode): No longer static.
222 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
223 * doc.c (Fdocumentation_property, Fsnarf_documentation):
224 No longer static.
404dbd37
TT
225 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
226 static.
227 * dired.c (Ffile_attributes): No longer static.
228 * composite.c (Fcomposition_get_gstring): No longer static.
229 * callproc.c (Fgetenv_internal): No longer static.
230
231 * ccl.h: Remove EXFUNs.
232 * buffer.h: Remove EXFUNs.
233 * dispextern.h: Remove EXFUNs.
234 * intervals.h: Remove EXFUNs.
235 * fontset.h: Remove EXFUN.
236 * font.h: Remove EXFUNs.
237 * dosfns.c (system_process_attributes): Remove EXFUN.
238 * keymap.h: Remove EXFUNs.
239 * lisp.h: Remove EXFUNs.
240 * w32term.h: Remove EXFUNs.
241 * window.h: Remove EXFUNs.
242 * xsettings.h: Remove EXFUN.
243 * xterm.h: Remove EXFUN.
244
8e4fd1e1
GM
2452012-07-03 Glenn Morris <rgm@gnu.org>
246
247 * lisp.h (Frandom): Make it visible to C.
248 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
249 buffer for invisible buffers. (Bug#1229)
250
ca95b3eb
DA
2512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
252
253 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
254 values which aren't power of 2.
255 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
256 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
257 accordingly.
258
7555c33f
SM
2592012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
260
261 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
262
263 * alloc.c (mark_object): Revert part of last patch to use `switch'.
264
d12e8f5a
DA
2652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
266
267 * alloc.c (allocate_vector_block): Remove redundant
268 calls to mallopt if DOUG_LEA_MALLOC is defined.
269 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
270 avoid calls to mallopt if zero_vector is returned.
271
296094c3
DA
2722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
273
274 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
275 is enabled, avoid dereferencing NULL current_sblock if
276 running undumped.
277
36429c89
DA
2782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
279
280 Cleanup basic buffer management.
281 * buffer.h (struct buffer): Change layout to use generic vector
282 marking code. Fix some comments. Change type of 'clip_changed'
283 to bitfield. Remove unused #ifndef old.
284 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
285 (GET_OVERLAYS_AT): Fix indentation.
286 (for_each_per_buffer_object_at): New macro.
287 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
288 (Fbuffer_local_variables): Use it.
289 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
290 * alloc.c (allocate_buffer): Adjust to match new layout of
291 struct buffer. Fix comment.
292 (mark_overlay): New function.
293 (mark_buffer): Use it. Use mark_vectorlike to mark normal
294 Lisp area of struct buffer.
295 (mark_object): Use it. Adjust marking of misc objects
296 and related comments.
297
3b3e4cac
PE
2982012-07-02 Paul Eggert <eggert@cs.ucla.edu>
299
300 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
301 wrapper that is not needed because the wrapped code is a no-op (zero
302 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
303 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
304
cf5c0175
DA
3052012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
306
307 * alloc.c (mark_buffer): Simplify. Remove prototype.
308 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 309 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
310 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
311 redundant calls to mark_vectorlike for bool vectors.
312
ca26824c
GM
3132012-06-30 Glenn Morris <rgm@gnu.org>
314
2e4c5312
GM
315 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
316
ca26824c
GM
317 * epaths.in (PATH_SITELOADSEARCH): New.
318 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
319 This is rather than relying on --enable-locallisppath elements
320 having "site-lisp" in their names. (Bug#10208#25, 11658)
321
0d23c240
EZ
3222012-06-30 Eli Zaretskii <eliz@gnu.org>
323
c9240d7a
EZ
324 * w32proc.c (sys_select): Accept and ignore one more argument.
325
326 * w32.c (emacs_gnutls_pull): Call select with one more argument.
327
0d23c240 328 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 329 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
330
331 * sysdep.c: Don't include dos.h and dosfns.h.
332
333 * process.c (sys_select):
334 * msdos.c (sys_select): Accept one more argument and ignore it.
335
336 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
337 adapt data types and code to that.
338
339 * dosfns.c:
340 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
341 which clashes with the gnulib function of the same name.
342
af5a5a98
AS
3432012-06-30 Andreas Schwab <schwab@linux-m68k.org>
344
c5e4379c
AS
345 * font.c (font_style_to_value, font_style_symbolic)
346 (font_prop_validate_style): Add type checks for values in
347 font_style_table.
348
af5a5a98
AS
349 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
350 argument.
351 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
352 uses.
353
8d38f461
EZ
3542012-06-29 Eli Zaretskii <eliz@gnu.org>
355
2e5a6631
EZ
356 * xdisp.c (try_window_id): Undo last change.
357
8d38f461
EZ
358 * w32.c (getwd): Adjust commentary about startup_dir.
359 (init_environment): Always call sys_access, even in non-MSVC
360 builds. Don't chdir to the directory of the Emacs executable.
361 This undoes code from 1997 which was justified by the need to
362 "avoid conflicts when removing and renaming directories". But its
363 downside was that every relative file name was being interpreted
364 relative to the directory of the Emacs executable, which can never
365 be TRT. In particular, it broke sys_access when called with
366 relative file names.
367 (sys_access): Map GetLastError to errno.
368
2af3565e
DA
3692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
370
371 * window.h (struct window): Change type of 'fringes_outside_margins'
372 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 373 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
374 Adjust comment.
375 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
376 to ptrdiff_t.
377
c8d3a25c 3782012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 379
c8d3a25c
GM
380 * gnutls.c (emacs_gnutls_handshake):
381 Add QUIT to make the loop interruptible.
57570cd3 382
c8d3a25c 3832012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 384
c8d3a25c
GM
385 * charset.c (init_charset): Make lack of etc/charsets fatal.
386
3e984ee8
DA
3872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
388
389 * editfns.c (region_limit): Fix type mismatch.
390
ef884f23
DA
3912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
392
393 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
394 undefined. Convert from xassert to eassert.
395 * nsmenu.m: Convert from xassert to eassert.
396 * nsterm.m: Likewise.
397
7d7e0027
SM
3982012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
399
400 * editfns.c (region_limit): Clip to narrowing (bug#11770).
401
aa754e6a
PE
4022012-06-28 Paul Eggert <eggert@cs.ucla.edu>
403
404 Avoid integer overflow on scroll-left and scroll-right.
405 * window.c (HSCROLL_MAX): New macro.
406 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
407 overflow when requested scroll falls outside ptrdiff_t range.
408
80b00b08
DA
4092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
410
411 * window.h (struct window): Change type of 'hscroll',
412 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
413 'last_modified' and 'last_overlay_modified' to EMACS_INT.
414 Adjust users accordingly.
415 * xdisp.c (try_cursor_movement): Replace type check with eassert.
416 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
417 from EMACS_INT to ptrdiff_t.
418 (make_window): Omit redundant initialization.
419
62b2bcf6
JB
4202012-06-28 Juanma Barranquero <lekktu@gmail.com>
421
422 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
423
45942c7d
DA
4242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
425
426 * window.h (struct window): Change type of 'use_time' and
427 'sequence_number' from Lisp_Object to int.
428 * frame.c (make_frame): Adjust users accordingly.
429 * print.c (print_object): Likewise.
430 * window.c (select_window, Fwindow_use_time, make_parent_window)
431 (make_window): Likewise.
432
e509cfa6
DA
4332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
434
435 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
436 enabled with --enable-checking=[all,glyphs] configure option.
437 Fix GLYPH_DEBUG usage assuming that it may be undefined,
438 adjust comments accordingly.
439 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
440 undefined, adjust comments accordingly.
441 * image.c: Likewise.
442 * scroll.c: Likewise.
443 * w32fns.c: Likewise.
444 * w32term.c: Likewise.
445 * xdisp.c: Likewise.
446 * xfaces.c: Likewise.
447 * xfns.c: Likewise.
448 * xterm.c: Likewise.
449
a54e2c05
DA
4502012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
451
452 Generalize run-time debugging checks.
453 * dispextern.h (XASSERTS): Remove.
454 * fontset.c (xassert): Remove.
455 Convert from xassert to eassert.
456 * alloc.c: Convert from xassert to eassert.
457 * bidi.c: Likewise.
458 * dispnew.c: Likewise.
459 * fns.c: Likewise.
460 * fringe.c: Likewise.
461 * ftfont.c: Likewise.
462 * gtkutil.c: Likewise.
463 * image.c: Likewise.
464 * keyboard.c: Likewise.
465 * menu.c: Likewise.
466 * process.c: Likewise.
467 * scroll.c: Likewise.
468 * sound.c: Likewise.
469 * term.c: Likewise.
470 * w32console.c: Likewise.
471 * w32fns.c: Likewise.
472 * w32term.c: Likewise.
473 * window.c: Likewise.
474 * xdisp.c: Likewise.
475 * xfaces.c: Likewise.
476 * xfns.c: Likewise.
477 * xselect.c: Likewise.
478 * xterm.c: Likewise.
479
1ec4b7b2
SM
4802012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
481
482 * fns.c (maybe_resize_hash_table): Output message when growing the
483 purify-hashtable.
484
2014308a
DA
4852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
486
487 * alloc.c (allocate_string_data): Remove dead code.
488 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
489 avoid GCC warning about unused macro.
490
246155eb
DA
4912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
492
493 * alloc.c (allocate_string): Omit intervals initialization.
494 * alloc.c (make_uninit_multibyte_string): Initialize intervals
495 as in make_pure_string and make_pure_c_string.
496
43184b7b
DA
4972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
498
d209e2fb 499 * alloc.c (allocate_string): Fix last change.
43184b7b 500
3fe6dd74
DA
5012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
502
d209e2fb 503 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
504 to memset, add explicit initialization where appropriate.
505
1ba6038a
GM
5062012-06-27 Glenn Morris <rgm@gnu.org>
507
508 * lisp.mk (lisp): Remove paths.elc.
509
c89926a5
CY
5102012-06-27 Chong Yidong <cyd@gnu.org>
511
512 * doc.c (Fsubstitute_command_keys): Fix punctuation.
513
ed6b3510
JW
5142012-06-26 John Wiegley <johnw@newartisans.com>
515
1ec4b7b2 516 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
517 on Mac OS X Lion: __mod_init_func and __mod_term_func.
518
ed6b3510
JW
519 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
520 when building with Clang.
521
8edd4a2b
SM
5222012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
523
524 * eval.c (Fapply): Allow calling it with a single argument.
525
f6f62d1b
EZ
5262012-06-26 Eli Zaretskii <eliz@gnu.org>
527
528 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
529 _stricmp and _strnicmp.
530 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
531
62efea5e
DA
5322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
533
534 * alloc.c (allocate_window): Zero out non-Lisp part of newly
535 allocated window.
536 (allocate_process): Likewise for new process.
8edd4a2b 537 (allocate_terminal): Change to use offsetof.
62efea5e
DA
538 (allocate_frame): Likewise.
539 * frame.c (make_frame): Omit redundant initialization.
540 * window.c (make_parent_window): Use memset.
541 (make_window): Omit redundant initialization.
542 * process.c (make_process): Omit redundant initialization.
543 * terminal.c (create_terminal): Likewise.
544
42997f4d
DA
5452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
546
547 * term.c (delete_tty): Remove redundant call to memset.
548
1130ecfc
DA
5492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
550
551 * alloc.c: Remove build_string.
552 * lisp.h: Define build_string as static inline. This provides
553 a better opportunity to optimize away calls to strlen when the
554 function is called with compile-time constant argument.
555 * image.c (imagemagick_error): Convert to build_string.
556 * w32proc.c (sys_spawnve): Likewise.
557 * xterm.c (x_term_init): Likewise.
558
cf38a720
PE
5592012-06-26 Paul Eggert <eggert@cs.ucla.edu>
560
99027bdd
PE
561 Use sprintf return value instead of invoking strlen on result.
562 In the old days this wasn't portable, since some sprintf
563 implementations returned char *. But they died out years ago and
564 Emacs already assumes sprintf returns int.
565 Similarly for float_to_string.
566 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
567 * ccl.c (ccl_driver):
568 * character.c (string_escape_byte8):
569 * data.c (Fnumber_to_string):
570 * doprnt.c (doprnt):
571 * print.c (print_object):
572 * xdisp.c (message_dolog):
573 * xfns.c (syms_of_xfns):
574 Use sprintf or float_to_string result to avoid need to call strlen.
575 * data.c (Fnumber_to_string):
576 Use make_unibyte_string, since the string must be ASCII.
577 * lisp.h, print.c (float_to_string): Now returns int length.
578 * term.c (produce_glyphless_glyph):
579 Use sprintf result rather than recomputing it.
580
cf38a720
PE
581 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
582 * Makefile.in (ALL_CFLAGS):
583 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
584 * gmalloc.c, regex.c: Include <config.h> unconditionally.
585
3511c784
DA
5862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
587
0a08eb21 588 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
589 strcasecmp if available.
590 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
591
fb7da12e
AS
5922012-06-25 Andreas Schwab <schwab@linux-m68k.org>
593
594 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
595 Avoid comma operator.
596 * menu.c (push_submenu_start, push_submenu_end)
597 (push_left_right_boundary, push_menu_pane): Likewise.
598 * msdos.c (dos_rawgetc): Likewise.
599
afa2ffd8
DA
6002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
601
602 * xfns.c (xic_create_fontsetname): Remove redundant calls
603 to memset.
604
b3b4476b
PE
6052012-06-25 Paul Eggert <eggert@cs.ucla.edu>
606
4495ff38
PE
607 * gtkutil.c (get_utf8_string): Remove redundant assignment.
608 sprintf already null-terminates its output.
609
b3b4476b
PE
610 * xfns.c (x_window): Remove redundant cast.
611
b00876c9
DA
6122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
613
614 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
615 `const char *' to `char *' to avoid compiler warning.
616
d188e26b
PE
6172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
618
885d1d74
PE
619 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
620 instead of truncating it to 63 (admittedly a generous limit).
621
d188e26b
PE
622 * process.c: Fix spelling and caps in comments.
623
e2f560b1
DN
6242012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
625
e86db54b 626 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
627 * sysdep.c (setpgrp): Remove definition, not used in this file.
628
7583a3a1
JB
6292012-06-24 Juanma Barranquero <lekktu@gmail.com>
630
631 * makefile.w32-in: Update dependencies.
632
696056c2
EZ
6332012-06-24 Eli Zaretskii <eliz@gnu.org>
634
635 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
636 (SYSTIME_H): Add nt/inc/sys/time.h.
637
638 * systime.h [WINDOWSNT]: Include sys/time.h.
639
640 * s/ms-w32.h (struct timespec): Definition moved from
641 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
642
845ca893
PE
6432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
644
645 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
646 * buffer.h (buffer_slot_type_mismatch):
647 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
648 * eval.c (unwind_to_catch):
649 * image.c (my_png_error, my_error_exit):
650 * keyboard.c (quit_throw_to_read_char, user_error)
651 (Fexit_recursive_edit, Fabort_recursive_edit):
652 * lisp.h (die, args_out_of_range, args_out_of_range_3)
653 (wrong_type_argument, buffer_overflow, __executable_start)
654 (memory_full, buffer_memory_full, string_overflow, Fthrow)
655 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
656 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
657 (fatal):
658 (child_setup) [!DOS_NT]:
659 * lread.c (end_of_file_error, invalid_syntax):
660 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
661 * puresize.h (pure_write_error):
662 * search.c (matcher_overflow):
663 * sound.c (sound_perror, alsa_sound_perror):
664 * sysdep.c, syssignal.h (croak):
665 * term.c (maybe_fatal, vfatal):
666 * textprop.c (text_read_only):
667 * undo.c (user_error):
668 * unexmacosx.c (unexec_error):
669 * xterm.c (x_ins_del_lines, x_delete_glyphs):
670 Use _Noreturn rather than NO_RETURN.
671 No need for separate decl merely because of _Noreturn.
672 * sound.c (sound_warning, parse_sound):
673 Remove unnecessary forward decls.
674
f1dd8073
PE
6752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
676
677 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
678 * lisp.h (WAIT_READING_MAX): New macro.
679 * dispnew.c (Fsleep_for, sit_for):
680 * keyboard.c (kbd_buffer_get_event):
681 * process.c (Faccept_process_output):
682 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
683 This improves on the previous patch, which introduced a bug
684 when time_t is unsigned and as wide as intmax_t.
685 See <http://bugs.gnu.org/9000#51>.
686
b82c1755
EZ
6872012-06-23 Eli Zaretskii <eliz@gnu.org>
688
689 * dispnew.c (sit_for, Fsleep_for):
690 * keyboard.c (kbd_buffer_get_event):
691 * process.c (Faccept_process_output): Avoid compiler warnings when
692 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
693
ca300656
JB
6942012-06-23 Juanma Barranquero <lekktu@gmail.com>
695
049ec95b
JB
696 * makefile.w32-in: Update dependencies.
697
ca300656
JB
698 * w32.c (ltime): Add return type and declare static.
699 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
700
db7b8d06
PE
7012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
702
703 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
704 Privately reported by Herbert J. Skuhra.
705 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
706 All uses changed.
707 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
708 not make_lisp_timeval, when the argument is of type EMACS_TIME.
709
0bd8297f
EZ
7102012-06-23 Eli Zaretskii <eliz@gnu.org>
711
96512555
EZ
712 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
713 last argument of make_unibyte_string.
714
0bd8297f
EZ
715 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
716 language ID in the event parameters.
717
718 * w32term.c (w32_read_socket): Put the new keyboard codepage into
719 event.code, not the obscure "character set ID".
720
63def6b6
CY
7212012-06-23 Chong Yidong <cyd@gnu.org>
722
723 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
724
e8a02204
EZ
7252012-06-23 Eli Zaretskii <eliz@gnu.org>
726
388cdec0
EZ
727 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
728 * w32.c (fdutimens): New function.
729
730 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
731
732 * s/ms-w32.h (pselect): Redirect to sys_select.
733
734 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
735
e8a02204
EZ
736 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
737 in the logic of incrementing and decrementing the value of
738 use_relocatable_buffers.
739
d054f3fb
PE
7402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
741
742 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
743 Privately reported by Herbert J. Skuhra.
744 [__FreeBSD__]: Remove "*/" typo after "#include".
745 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
746 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
747 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
748 Don't assume EMACS_TIME and struct timeval are the same type.
749
d35af63c
PE
7502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
751
752 Support higher-resolution time stamps (Bug#9000).
753 The time stamps are only nanosecond-resolution at the C level,
754 since that's the best that any real-world system supports now.
755 But they are picosecond-resolution at the Lisp level, as that's
756 easy, and leaves room for future OS improvements.
757
758 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
759 (LIBES): Use it.
760
761 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
762 Don't get current time unless it's needed.
763
764 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
765 now provides it if it's absent.
766 (start_atimer): Port to higher-res time stamps.
767 Check for time stamp overflow. Don't get current time more
768 often than is needed.
769
770 * buffer.h (struct buffer): Buffer modtime now has high resolution.
771 Include systime.h, not time.h.
772 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
773
774 * dired.c: Include stat-time.h.
775 (Ffile-attributes): File times now have higher resolution.
776
777 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
778 (struct image): Timestamp now has higher resolution.
779
780 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
781 has at least microseconds now. All uses removed.
782 (update_frame, update_single_window, update_window, update_frame_1)
783 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
784
785 * editfns.c (time_overflow): Now extern.
786 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
787 (float-time, Fformat_time_string, Fcurrent_time_string)
788 (Fcurrent_time_zone): Accept and generate higher-resolution
789 time stamps.
790 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
791 (decode_time_components, lisp_seconds_argument): New functions.
792 (make_time): Now static.
793 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
794 Report an error if the time is invalid, rather than having the caller
795 do that.
796
797 * fileio.c: Include <stat-time.h>
798 (Fcopy_file): Copy higher-resolution time stamps.
799 Prefer to set the time stamp via a file descriptor if that works.
800 (Fset_file_times, Finsert_file_contents, Fwrite_region)
801 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
802 (Fvisited_file_modtime, Fset_visited_file_modtime):
803 Support higher-resolution time stamps.
804
805 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
806
807 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
808
809 * image.c (prepare_image_for_display, clear_image_cache)
810 (lookup_image): Port to higer-resolution time stamps.
811
812 * keyboard.c (start_polling, bind_polling_period):
813 Check for time stamp overflow.
814 (read_char, kbd_buffer_get_event, timer_start_idle)
815 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
816 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
817 Port to higher-resolution time stamps. Do not assume time_t is signed.
818 (decode_timer): New function. Timers are now vectors of length 9,
819 not 8, to accommodate the picosecond component.
820 (timer_check_2): Use it.
821
822 * nsterm.m (select_timeout, timeval_subtract): Remove.
823 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
824 as they're a bit more accurate and handle overflow better.
825 (ns_select): Change prototype to be compatible with pselect.
826 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
827 * nsterm.h (ns_select): Adjust prototype.
828
829 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
830 us-resolution time stamps.
831 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
832
833 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
834
835 * lisp.h (time_overflow): New decl.
836 (wait_reading_process_output): First arg is now intmax_t, not int,
837 to accommodate larger waits.
838
839 * process.h (struct Lisp_Process.read_output_delay):
840 Now counts nanoseconds, not microseconds.
841 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
842 EMACS_HAS_USECS.
843 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
844 (wait_reading_process_output):
845 Port to ns-resolution time stamps.
846 (Faccept_process_output, wait_reading_process_output):
847 Check for time stamp overflow. Do not assume time_t is signed.
848 (select_wrapper): Remove; we now use pselect.
849 (Fprocess_attributes): Now generates ns-resolution time stamps.
850
851 * sysdep.c: Include utimens.h. Don't include utime.h
852 or worry about struct utimbuf; gnulib does that for us now.
853 (gettimeofday): Remove; gnulib provides a substitute.
854 (make_timeval): New function.
855 (set_file_times): Now sets ns-resolution time stamps.
856 New arg FD; all uses changed.
857 (time_from_jiffies, ltime_from_jiffies, get_up_time)
858 (system_process_attributes):
859 Now returns ns-resolution time stamp. All uses changed.
860 Check for time stamp overflow.
861
862 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
863 provides a substitute now.
864
865 * systime.h: Include timespec.h rather than sys/time.h and time.h,
866 since it guarantees struct timespec.
867 (EMACS_TIME): Now struct timespec, so that we can support
868 ns-resolution time stamps.
869 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
870 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
871 (EMACS_USECS): Remove.
872 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
873 so multiply the arg by 1000 before storing it.
874 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
875 New macros.
876 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
877 Port to ns-resolution time stamps.
878 (EMACS_TIME_NEG_P): Remove; replaced by....
879 (EMACS_TIME_SIGN): New macro.
880 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
881 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
882 (set_file_times, make_time, lisp_time_argument): Adjust signature.
883 (make_timeval, make_lisp_time, decode_time_components): New decls.
884 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
885 that it mishandled time_t overflow. You can't compare by subtracting!
886 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
887 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
888
889 * term.c: Include <sys/time.h>.
890 (timeval_to_Time): New function, for proper overflow wraparound.
891 (term_mouse_position, term_mouse_click): Use it.
892
893 * undo.c (record_first_change): Support higher-resolution time stamps
894 in the undo buffer.
895 (Fprimitive_undo): Use them when restoring time stamps.
896
897 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
898 (w32_get_internal_run_time):
899 Port to higher-resolution Emacs time stamps.
900 (ltime): Now accepts single 64-bit integer, as that's more convenient
901 for callers.
902
903 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
904
905 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
906 for compatibility with pselect. Support ns-resolution time stamps.
907
908 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
909
910 * xselect.c (wait_for_property_change, x_get_foreign_selection):
911 Check for time stamp overflow, and support ns-resolution time stamps.
912
913 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
914 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
915 (timeval_subtract): Remove; no longer needed.
916 (XTflash, XTring_bell, x_wait_for_event):
917 Port to ns-resolution time stamps. Don't assume time_t is signed.
918
b6a92dfe
CY
9192012-06-22 Chong Yidong <cyd@gnu.org>
920
921 * xdisp.c (x_consider_frame_title): Revert last change.
922
d251c37c
EZ
9232012-06-22 Eli Zaretskii <eliz@gnu.org>
924
925 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
926 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
927 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
928 staticidx goes up to 1597 out of 1600 = 0x640.)
929
f10deafb
PE
9302012-06-20 Paul Eggert <eggert@cs.ucla.edu>
931
932 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
933 Otherwise, the umask might be mistakenly 0 while handling input signals.
934
ec6de1e2
SM
9352012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
938
28be1ada
DA
9392012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
942 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
943 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
944 access to `contents' member of Lisp_Vector objects with AREF and ASET
945 where appropriate.
946
c6bf3022
CY
9472012-06-19 Chong Yidong <cyd@gnu.org>
948
949 * frame.c (delete_frame): When selecting a frame on a different
950 text terminal, do not alter the terminal's top-frame.
951
952 * xdisp.c (format_mode_line_unwind_data): Record the target
953 frame's selected window and its terminal's top-frame.
954 (unwind_format_mode_line): Restore them.
955 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
956 Callers changed.
957 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
958 since tty frames can be explicitly named.
959 (prepare_menu_bars): Likewise.
960
961 * term.c (Ftty_top_frame): New function.
962
defd4196
PE
9632012-06-18 Paul Eggert <eggert@cs.ucla.edu>
964
965 Port byte-code-meter to modern targets.
966 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
967 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 968 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
969 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
970 (METER_1, METER_2): Simplify.
971
1053a871
SM
9722012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
973
974 * data.c (Fdefalias): Return `symbol' (bug#11686).
975
b7e8d081
MR
9762012-06-18 Martin Rudalics <rudalics@gmx.at>
977
978 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
979 gets killed during executing of this function (Bug#11665).
980 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
981 (Vkill_buffer_query_functions): In doc-string say that functions
982 run by this hook should not change the current buffer.
983
7ea2b339
PE
9842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
985
986 Fix recently-introduced process.c problems found by static checking.
987 * process.c (write_queue_push, write_queue_pop, send_process):
988 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
989 (write_queue_pop): Fix pointer signedness problem.
990 (send_process): Remove unused local.
991
96a313a1
CY
9922012-06-17 Chong Yidong <cyd@gnu.org>
993
994 * xdisp.c (redisplay_internal): No need to redisplay terminal
995 frames that are not on top.
996
20ca2e94
TN
9972012-06-17 Troels Nielsen <bn.troels@gmail.com>
998
999 * process.c (make_process): Initialize write_queue.
1000 (write_queue_push, write_queue_pop): New functions.
1001 (send_process): Use them to maintain correct ordering of process
1002 writes (Bug#10815).
1003
9a900ca9
PE
10042012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1005
310fbfa8
PE
1006 * lisp.h (eassert): Assume C89 or later.
1007 This removes the need for CHECK.
1008 (CHECK): Remove. Its comments about always evaluating its
1009 argument were confusing, as 'eassert' typically does not evaluate
1010 its argument.
1011
27bb1ca4
PE
1012 * coding.c (produce_chars): Use ptrdiff_t, not int.
1013
9a900ca9
PE
1014 * xterm.c (x_draw_underwave): Check for integer overflow.
1015 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1016
41b7f8bc 10172012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1018
1019 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1020 referenced (Bug#11583).
1021
9b0e3eba
AA
10222012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1023
1024 Implement wave-style variant of underlining.
1025 * dispextern.h (face_underline_type): New enum.
1026 (face): Add field for underline type.
1027 * nsterm.m (ns_draw_underwave): New function.
1028 (ns_draw_text_decoration): Use it.
1029 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1030 New functions.
1031 (x_draw_glyph_string): Use them.
1032 * xfaces.c (Qline, Qwave): New Lisp objects.
1033 (check_lface_attrs, merge_face_ref)
1053a871
SM
1034 (Finternal_set_lisp_face_attribute, realize_x_face):
1035 Handle wave-style underline face attributes.
9b0e3eba
AA
1036 * xterm.c (x_draw_underwave): New function.
1037 (x_draw_glyph_string): Use it.
1038
0fb52f11
JB
10392012-06-16 Juanma Barranquero <lekktu@gmail.com>
1040
1041 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1042 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1043 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1044 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1045 ($(BLD)/w32select.$(O)): Update dependencies.
1046
e5560ff7
AS
10472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1048
1049 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1050 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1051 * character.c (_fetch_multibyte_char_p): Remove.
1052 * alloc.c: Include "character.h" before "buffer.h".
1053 * bidi.c: Likewise.
1054 * buffer.c: Likewise.
1055 * bytecode.c: Likewise.
1056 * callint.c: Likewise.
1057 * callproc.c: Likewise.
1058 * casefiddle.c: Likewise.
1059 * casetab.c: Likewise.
1060 * category.c: Likewise.
1061 * cmds.c: Likewise.
1062 * coding.c: Likewise.
1063 * composite.c: Likewise.
1064 * dired.c: Likewise.
1065 * dispnew.c: Likewise.
1066 * doc.c: Likewise.
1067 * dosfns.c: Likewise.
1068 * editfns.c: Likewise.
1069 * emacs.c: Likewise.
1070 * fileio.c: Likewise.
1071 * filelock.c: Likewise.
1072 * font.c: Likewise.
1073 * fontset.c: Likewise.
1074 * fringe.c: Likewise.
1075 * indent.c: Likewise.
1076 * insdel.c: Likewise.
1077 * intervals.c: Likewise.
1078 * keyboard.c: Likewise.
1079 * keymap.c: Likewise.
1080 * lread.c: Likewise.
1081 * macros.c: Likewise.
1082 * marker.c: Likewise.
1083 * minibuf.c: Likewise.
1084 * nsfns.m: Likewise.
1085 * nsmenu.m: Likewise.
1086 * print.c: Likewise.
1087 * process.c: Likewise.
1088 * regex.c: Likewise.
1089 * region-cache.c: Likewise.
1090 * search.c: Likewise.
1091 * syntax.c: Likewise.
1092 * term.c: Likewise.
1093 * textprop.c: Likewise.
1094 * undo.c: Likewise.
1095 * unexsol.c: Likewise.
1096 * w16select.c: Likewise.
1097 * w32fns.c: Likewise.
1098 * w32menu.c: Likewise.
1099 * window.c: Likewise.
1100 * xdisp.c: Likewise.
1101 * xfns.c: Likewise.
1102 * xmenu.c: Likewise.
1103 * xml.c: Likewise.
1104 * xselect.c: Likewise.
1105
2f07e6af
EZ
11062012-06-16 Eli Zaretskii <eliz@gnu.org>
1107
1053a871
SM
1108 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1109 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1110 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1111 row.
1112 (handle_face_prop): Use chunk-relative overlay string index when
1113 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1114 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1115 the rightmost. (Bug#11720)
2f07e6af 1116
29b83cec
AS
11172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1118
1119 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1120 (CATEGORY_MEMBER): Enforce 1/0 value.
1121 * category.c (_temp_category_set): Remove.
1122
4c5501e9
EZ
11232012-06-16 Eli Zaretskii <eliz@gnu.org>
1124
1125 * window.c (Fdelete_other_windows_internal)
1126 (Fdelete_window_internal): Don't access frame's mouse highlight
1127 info of the initial frame. (Bug#11677)
1128
2b570124
PE
11292012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1130
e93864f9
PE
1131 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1132 Assume USE_2_TAGS_FOR_INTS.
1133 (xreload): Adjust $tagmask width to match recent lisp.h change.
1134
2b570124
PE
1135 Simplify lisp.h in minor ways that should not affect code.
1136 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1137 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1138 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1139 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1140 (INTTYPEBITS): New macro, for clarity.
1141 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1142 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1143 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1144 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1145 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1146
81755f69
JB
11472012-06-13 Juanma Barranquero <lekktu@gmail.com>
1148
1149 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1150
16192a57
GM
11512012-06-13 Glenn Morris <rgm@gnu.org>
1152
1153 * s/bsd-common.h (BSD4_3):
1154 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1155
646b5f55
AS
11562012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1157
1158 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1159 instead of union.
1160 (XLI, XIL): Define.
1053a871
SM
1161 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1162 Use them.
1163 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1164 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1165 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1166 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1167 * frame.c (delete_frame): Remove outdated comment.
1168 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1169 USE_LISP_UNION_TYPE.
1170 (Fw32_unregister_hot_key): Likewise.
1171 (Fw32_toggle_lock_key): Likewise.
1172 * w32menu.c (add_menu_item): Likewise.
1173 (w32_menu_display_help): Use XIL instead of checking
1174 USE_LISP_UNION_TYPE.
1175 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1176 (init_heap): Likewise.
1177 * w32term.c (w32_read_socket): Update comment.
1178
1d3823c9
GM
11792012-06-13 Glenn Morris <rgm@gnu.org>
1180
c62ff706
GM
1181 * s/usg5-4-common.h, src/s/unixware.h:
1182 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1183
1d3823c9
GM
1184 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1185
bfe3e0a2
PE
11862012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1189 * alloc.c (make_number) [!defined make_number]:
1190 Remove, as lisp.h always defines this now.
1191 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1192 (roundup_size): Verify that it is a power of 2.
1193 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1194 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1195 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1196 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1197 USE_LSB_TAG now is always defined to be either 0 or 1.
1198 All uses changed.
1199 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1200 code works fine either way, and efficiency is not a concern here,
1201 as the union type is for debugging, not for production.
1202 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1203 Use an inline function on all platforms when using the union type,
1204 since this is simpler and 'static inline' can be used portably
1205 within Emacs now.
1206 (LISP_INITIALLY_ZERO): New macro.
1207 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1208 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1209
45fa9c0f
GM
12102012-06-12 Glenn Morris <rgm@gnu.org>
1211
b4492cba
GM
1212 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1213
1214 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1215
45fa9c0f
GM
1216 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1217 Move BROKEN_SIGIO to configure.
1218
1219 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1220 Move NO_TERMIO to configure.
1221
0e25d334
CY
12222012-06-12 Chong Yidong <cyd@gnu.org>
1223
1224 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1225 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1226 MagickExportImagePixels is undefined.
1227
43682bb6
PE
12282012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * image.c (imagemagick_load_image): Remove unused label.
1231
a9be7d2b
GM
12322012-06-11 Glenn Morris <rgm@gnu.org>
1233
1234 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1235 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1236 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1237 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1238
3017f87f
SM
12392012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1240
1241 * alloc.c (make_byte_code): New function.
1242 (Fmake_byte_code): Use it. Don't purify here.
1243 * lread.c (read1): Use it as well to avoid extra allocation.
1244
1b9b4cf4
CY
12452012-06-11 Chong Yidong <cyd@gnu.org>
1246
1247 * image.c (imagemagick_load_image): Implement transparency.
1248
95988fcf
AS
12492012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1250
1251 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1252 account for preceding backslashes. (Bug#11663)
1253
cd4eb164
CY
12542012-06-09 Chong Yidong <cyd@gnu.org>
1255
1256 * term.c: Support italics in capable terminals (Bug#9652).
1257 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1258 (turn_on_face): Output using TS_enter_italic_mode if available.
1259 Don't handle unused blinking and alt-charset cases.
1260 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1261 and tty_alt_charset_p cases.
1262 (tty_capable_p, init_tty): Support italics.
1263
1264 * termchar.h (struct tty_display_info): Add field for italics.
1265 Remove unused blink field.
1266
1267 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1268 Handle slant.
1269
1270 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1271 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1272 tty_alt_charset_p. Add tty_italic_p.
1273
ff88beb8
MA
12742012-06-09 Michael Albinus <michael.albinus@gmx.de>
1275
1276 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1277 dbus_type_is_basic if available.
1278 (xd_extract_signed, xd_extract_unsigned): Rename from
1279 extract_signed and extract_unsigned, respectively. Adapt callers.
1280
44286096
CY
12812012-06-09 Chong Yidong <cyd@gnu.org>
1282
1682701f
CY
1283 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1284
44286096
CY
1285 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1286 case (Bug#9752).
1287
d86feb17
PE
12882012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * xdisp.c (vmessage): Treat frame message as multibyte.
1291 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1292 would generate the diagnostic "Making \302\247 buffer-local while
1293 let-bound!".
1294
d5c20fe8
EZ
12952012-06-08 Eli Zaretskii <eliz@gnu.org>
1296
1297 * dispnew.c (showing_window_margins_p): Undo last change, which
1298 was done due to an inadvertent commit.
1299 (adjust_frame_glyphs_for_frame_redisplay): Do call
1300 showing_window_margins_p.
1301
513749ee
SM
13022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1303
1304 * eval.c (Fmake_var_non_special): New primitive.
1305 (syms_of_eval): Defsubr it.
1306 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1307
d4a8f5c1
JB
13082012-06-08 Juanma Barranquero <lekktu@gmail.com>
1309
1310 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1311 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1312
8bbbc977
EZ
13132012-06-08 Eli Zaretskii <eliz@gnu.org>
1314
1315 * alloc.c (allocate_vectorlike): Fix last change.
1316
f3372c87
DA
13172012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1318
1319 Block-based vector allocation of small vectors.
1320 * lisp.h (struct vectorlike_header): New field `nbytes',
1321 adjust comment accordingly.
1322 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1323 to denote vector blocks. Adjust users (live_vector_p,
1324 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1325 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1326 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1327 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1328 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1329 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1330 (roundup_size): New constant.
1331 (struct vector_block): New data type.
1332 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1333 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1334 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1335 (sweep_vectors): New functions.
1336 (allocate_vectorlike): Return `zero_vector' as the only vector of
1337 0 items. Allocate new vector from block if vector size is less than
1338 or equal to VBLOCK_BYTES_MAX.
1339 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1340 (init_alloc_once): Add call to init_vectors.
1341
4f18a4ed
SM
13422012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1343
1344 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1345
86f158bc
PE
13462012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 * doprnt.c (doprnt): Truncate multibyte char correctly.
1349 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1350 would mishandle a string argument "Xc" if X was a multibyte
1351 character of length 2: it would truncate after X's first byte
1352 rather than including all of X.
1353
c5cfcbe0
CY
13542012-06-06 Chong Yidong <cyd@gnu.org>
1355
1356 * buffer.c (word_wrap): Doc fix.
1357
c05cf390
PE
13582012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1359
1360 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1361
0c3461de
GM
13622012-06-03 Glenn Morris <rgm@gnu.org>
1363
1364 * xdisp.c (tool-bar-style): Doc fix.
1365
c71232db
UM
13662012-06-03 Ulrich Müller <ulm@gentoo.org>
1367
1368 * Makefile.in (PAXCTL): Define.
1369 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1370 binary via PaX flags if the paxctl utility is available.
1371 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1372 Restore PaX flags to their default. (Bug#11398)
1373
383f7350
CY
13742012-06-03 Chong Yidong <cyd@gnu.org>
1375
1376 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1377 buffer (Bug#11226).
1378
5f2c76c6
CY
13792012-06-03 Chong Yidong <cyd@gnu.org>
1380
1381 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1382 (note_mode_line_or_margin_highlight): If there is no help echo,
1383 use mode-line-default-help-echo. Handle the case where the mouse
1384 position is past the end of the mode line string.
1385
1386 * buffer.c (buffer_local_value_1): New function, split from
1387 Fbuffer_local_value; can return Qunbound.
1388 (Fbuffer_local_value): Use it.
1389 (Vmode_line_format): Docstring tweaks.
1390
773d47f6
PE
13912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 * sysdep.c (system_process_attributes): Improve comment.
1394
f2d6a3df
SM
13952012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1396
1397 * keyboard.c: Export real-this-command to Elisp.
1398 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1399 and DEFVAR it. Update all users.
1400
63810350
PE
14012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1402
7bd5c1f4
PE
1403 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1404
63810350
PE
1405 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1406 Convert pctcpu and pctmem to Lisp float properly.
1407 Let the compiler fold better, as 100.0/0x8000 is exact.
1408
a2821611
AS
14092012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1410
1411 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1412 cons_block.
1413
5fceba1d
PE
14142012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1415
1416 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1417
c98ff5dd
DA
14182012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1419
1420 For a 'struct window', replace some Lisp_Object fields to
1421 bitfields where appropriate, remove unused fields.
1422 * window.h (struct window): Remove unused 'last_mark_x' and
1423 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1424 change it's type from Lisp_Object to bitfield.
1425 Change type of 'force_start', 'optional_new_start',
1426 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1427 fields from Lisp_Object to bitfield. Adjust users accordingly.
1428
ca34e0be
PE
14292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1430
1431 Pacify gcc -Wdouble-precision when using Xaw.
1432 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1433 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1434 Use 'float' consistently, rather than 'float' in most places
1435 and 'double' in a couple of places.
1436
efc00ab1 14372012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1438
1439 * xdisp.c (handle_stop): Detect whether we have overlay strings
1440 loaded by testing it->current.overlay_string_index to be
1441 non-negative, instead of checking whether n_overlay_strings is
1442 positive. (Bug#11587)
1443
efc00ab1 14442012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1445
1446 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1447
1448 * doc.c (Fsubstitute_command_keys): Doc fix.
1449
efc00ab1 14502012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1451
1452 * search.c (search_buffer): Remove calls to
1453 r_alloc_inhibit_buffer_relocation, as it is now called by
1454 maybe_unify_char, which was the cause of relocation of buffer text
1455 in bug#11519.
1456
efc00ab1 14572012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1458
1459 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1460 for the duration of call to load_charset, to avoid problems with
1461 callers of maybe_unify_char that access buffer text through C
1462 pointers.
1463
1464 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1465 decrement the inhibition flag, instead of just setting or
1466 resetting it.
1467
ba93a187
PE
14682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1469
1470 Remove obsolete '#define static' cruft.
1471 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1472 This #undef was "temporary" in 2000; it is no longer needed
1473 now that '#define static' has gone away.
1474 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1475 (gray_bitmap_bits): Remove; no longer needed.
1476 All uses replaced with definiens.
1477 * xterm.c: Include "bitmaps/gray.xbm".
1478
9e4bf381
PE
14792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 Clean up __executable_start, monstartup when --enable-profiling.
1482 The following changes affect the code only when profiling.
1483 * dispnew.c (__executable_start): Rename from safe_bcopy.
1484 Define only on platforms that need it.
1485 * emacs.c: Include <sys/gmon.h> when profiling.
1486 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1487 (__executable_start): Remove decl, since lisp.h does it now.
1488 (safe_bcopy): Remove decl; no longer has that name.
1489 (main): Coalesce #if into single bit of code, for simplicity.
1490 Cast pointers to uintptr_t, since standard libraries want integers
1491 and not pointers.
1492 * lisp.h (__executable_start): New decl.
1493
32d72c2f
GM
14942012-05-31 Glenn Morris <rgm@gnu.org>
1495
1496 * image.c (Fimagemagick_types): Doc fix.
1497
baac5bc7
JM
14982012-05-30 Jim Meyering <meyering@redhat.com>
1499
1500 * callproc.c (Fcall_process_region): Include directory component
1501 in mkstemp error message (Bug#11586).
1502
72cb32cf
PE
15032012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 * alloc.c, lisp.h (make_pure_vector): Now static.
1506
61b108cc
SM
15072012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1508
1509 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1510 Move to byte-run.el.
1511 (Fautoload): Do the hash-doc more carefully.
1512 * data.c (Fdefalias): Purify definition, except for keymaps.
1513 (Qdefun): Move from eval.c.
1514 * lisp.h (Qdefun): Remove.
1515 * lread.c (read1): Tiny simplification.
1516
471fe23d
TN
15172012-05-29 Troels Nielsen <bn.troels@gmail.com>
1518
934f3f58 1519 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1520 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1521 Bug#9642, but explicitly check that the buffer the overlay would
1522 be moved to is live and rearrange lines to make sure that errors
1523 will not put the overlay in an inconsistent state.
1524 (Fdelete_overlay): Cosmetics.
1525
85d0efd1
EZ
15262012-05-28 Eli Zaretskii <eliz@gnu.org>
1527
1528 * w32term.c (my_bring_window_to_top): New function.
1529 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1530 could be different from the original one.
1531 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1532 (Bug#11513)
1533
1534 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1535 by calling BringWindowToTop.
1536
1537 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1538 (WM_EMACS_END): Increase by one.
1539
da92a98c
PE
15402012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1543 This avoids undefined behavior that might cause the eassert
1544 to not catch an out-of-range value.
1545
74d1f848
JB
15462012-05-28 Juanma Barranquero <lekktu@gmail.com>
1547
1548 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1549 Update dependencies.
1550
9e1a06fc
EZ
15512012-05-27 Eli Zaretskii <eliz@gnu.org>
1552
1553 * bidi.c (bidi_mirror_char): Fix last change.
1554
f3dd7312
AS
15552012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1556
1557 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1558 when referring to sectname field in printf format.
1559
81899c91
PE
15602012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1561
57b81a9f
PE
1562 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1563 Only r_alloc_inhibit_buffer_relocation needed to be added;
1564 the others were already declared.
1565
81899c91
PE
1566 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1567 before checking whether it's out of range. Put the check inside
1568 eassert. See
1569 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1570
33017faf 15712012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1572
1573 * callproc.c (Fcall_process): Restore a line that was accidentally
1574 commented out in the 2011-02-13 change (bug#11547).
1575
33017faf 15762012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1577
1578 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1579 defined on ralloc.c.
1580
1581 * buffer.c [REL_ALLOC]: Remove prototypes of
1582 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1583 they are now on lisp.h.
1584
1585 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1586
1587 * search.c (search_buffer): Use it to inhibit relocation of buffer
1588 text while re_search_2 is doing its job, because re_search_2 is
1589 passed C pointers to buffer text. (Bug#11519)
1590
23415acf
EZ
1591 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1592 Update value to 24.
1593
44e27368
EZ
1594 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1595 state after an additional call to move_it_in_display_line_to, keep
1596 the values of it->max_ascent and it->max_descent found for the
1597 entire line.
1598 (pos_visible_p): Revert the comparison against bottom_y to what it
1599 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1600 (Bug#11464)
1601
c1892f11
PE
16022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 Fix coding-related core dumps with gcc -ftrapv.
1605 The code was computing A - B, where A and B are pointers, and B is
1606 random garbage. This can lead to core dumps on platforms that
1607 have special pointer registers, and it also leads to core dumps on
1608 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1609 A - B only when B is initialized properly.
1610 * coding.c (coding_set_source, coding_set_destination): Return void.
1611 (coding_change_source, coding_change_destinations): New functions,
1612 with the old behaviors of coding_set_source and coding_set_destination.
1613 All callers that need an offset changed to use these new functions.
1614
eb7afdad
GM
16152012-05-26 Glenn Morris <rgm@gnu.org>
1616
1617 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1618
f12fdf02
EZ
16192012-05-26 Eli Zaretskii <eliz@gnu.org>
1620
53a63be6 1621 Extend mouse support on W32 text-mode console.
61b108cc
SM
1622 * xdisp.c (draw_row_with_mouse_face):
1623 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1624
eb3f6f01 1625 * w32console.c: Include window.h.
61b108cc
SM
1626 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1627 New functions.
eb3f6f01
EZ
1628 (initialize_w32_display): Initialize mouse-highlight data.
1629
53a63be6
EZ
1630 * w32inevt.c: Include termchar.h and window.h.
1631 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1632 moves, call note_mouse_highlight. If help_echo changed, call
1633 gen_help_event to produce help-echo message in the echo area.
1634 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1635 highlight info.
1636
4cfd81f6
PE
16372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1638
1639 * lread.c (read1): Simplify slightly to avoid an overflow warning
1640 with GCC 4.7.0 on x86-64.
1641
4446092a
EZ
16422012-05-26 Eli Zaretskii <eliz@gnu.org>
1643
1644 * bidi.c (bidi_mirror_char): Revert last change: an int is
1645 definitely wide enough here.
1646
42b2a986 16472012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1648
42b2a986 1649 Fix integer width and related bugs (Bug#9874).
eb106a49 1650 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1651 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1652 (string_bytes, check_sblock, allocate_string_data):
1653 (compact_small_strings, Fmake_bool_vector, make_string)
1654 (make_unibyte_string, make_multibyte_string)
1655 (make_string_from_bytes, make_specified_string)
1656 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1657 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1658 (mark_vectorlike):
1659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1660 (allocate_pseudovector):
1661 Use int, not EMACS_INT, where int is wide enough.
1662 (inhibit_garbage_collection, Fgarbage_collect):
1663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1664 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1665 int might not be wide enough.
1666 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1667 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1668 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1669 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1670 (bidi_level_of_next_char, bidi_move_to_visually_next):
1671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1672 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1673 (Fkill_buffer, Fset_buffer_major_mode)
1674 (advance_to_char_boundary, Fbuffer_swap_text)
1675 (Fset_buffer_multibyte, overlays_at, overlays_in)
1676 (overlay_touches_p, struct sortvec, record_overlay_string)
1677 (overlay_strings, recenter_overlay_lists)
1678 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1679 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1680 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1681 (Foverlay_recenter, last_overlay_modification_hooks_used)
1682 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1684 (validate_region): Omit unnecessary test for b <= e,
1685 since that's guaranteed by the previous test.
d311d28c
PE
1686 (adjust_overlays_for_delete): Avoid pos + length overflow.
1687 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1688 (report_overlay_modification):
1689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1690 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1691 Omit pointer cast, which isn't needed anyway, and doesn't work
1692 after the EMACS_INT -> ptrdiff_t change.
02481186 1693 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1694 * buffer.h: Adjust decls to match defn changes elsewhere.
1695 (struct buffer_text, struct buffer):
1696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1697 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1698 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1699 not int, to avoid needless 32-bit limit on 64-bit hosts.
1700 (exec_byte_code): Use tighter memory-full test, one that checks
1701 for alloca overflow. Don't compute the address of the object just
1702 before an array, as that's not portable. Use EMACS_INT, not
1703 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1704 * callint.c (Fcall_interactively):
1705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1706 * callproc.c (call_process_kill, Fcall_process):
1707 Don't assume pid_t fits into an Emacs fixnum.
1708 (call_process_cleanup, Fcall_process, child_setup):
1709 Don't assume pid_t fits into int.
1710 (call_process_cleanup, Fcall_process, delete_temp_file)
1711 (Fcall_process_region):
1712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1713 (Fcall_process): Simplify handling of volatile integers.
1714 Use int, not EMACS_INT, where int will do.
1715 * casefiddle.c (casify_object, casify_region, operate_on_word)
1716 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1718 (casify_object): Avoid integer overflow when overallocating buffer.
1719 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1720 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1721 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1722 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1723 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1724 integers are now checked earlier. All uses replaced with XINT.
1725 (ccl_driver):
1726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1727 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1728 (ccl_driver, Fregister_code_conversion_map):
1729 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1730 (resolve_symbol_ccl_program): Check that vector header is in range.
1731 Always copy the vector, so that we can check its contents reliably
1732 now rather than having to recheck each instruction as it's being
1733 executed. Check that vector words fit in 'int'.
1734 (ccl_get_compiled_code, Fregister_ccl_program)
1735 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1736 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1737 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1738 contents are in range.
1739 (Fccl_execute_on_string): Check that status is in range.
1740 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1741 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1742 Accept and return EMACS_INT, not int, because callers can pass values
1743 out of 'int' range.
1744 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1745 (multibyte_chars_in_text, parse_str_as_multibyte)
1746 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1747 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1748 (string_escape_byte8, Fget_byte):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1750 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1751 avoid mishandling large integers.
1752 * character.h: Adjust decls to match defn changes elsewhere.
1753 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1754 (Ffind_charset_region):
1755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1756 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1757 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1758 Don't assume fixnum fits in int.
d311d28c
PE
1759 (load_charset_map_from_vector, Fmap_charset_chars):
1760 Remove now-unnecessary CHECK_NATNUMs.
1761 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1762 Don't rely on undefined behavior with signed left shift overflow.
1763 Don't assume unsigned int fits into fixnum, or that fixnum fits
1764 into unsigned int. Don't require max_code to be a valid fixnum;
1765 that's not true for gb10830 4-byte on a 32-bit host. Allow
1766 invalid_code to be a cons, for the same reason. Require code_offset
1767 to be a character. Avoid int overflow if max_char is close
1768 to INT_MAX.
1769 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1770 this is intended anyway and avoids some undefined behavior.
1771 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1772 INDEX_TO_CODE_POINT, as that's what it expects.
1773 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1774 * charset.h (DECODE_CHAR): Return int, not unsigned;
1775 this is what was intended anyway, and it avoids undefined behavior.
1776 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1777 integer-overflow issues.
1778 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1779 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1780 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1781 * chartab.c (Fmake_char_table, Fset_char_table_range)
1782 (uniprop_get_decoder, uniprop_get_encoder):
1783 Don't assume fixnum fits in int.
1784 * cmds.c (move_point): New function, that does the gist of
1785 Fforward_char and Fbackward_char, but does so while checking
1786 for integer overflow more accurately.
c96e5d6a 1787 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1788 (Fforward_line, Fend_of_line, internal_self_insert)
1789 (internal_self_insert):
1790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1791 Fix a FIXME, by checking for integer overflow when calculating
1792 target_clm and actual_clm.
1793 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1794 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1795 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1796 (coding_alloc_by_making_gap, alloc_destination)
1797 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1798 (encode_coding_utf_16, detect_coding_emacs_mule)
1799 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1800 (detect_coding_iso_2022, decode_coding_iso_2022)
1801 (encode_invocation_designation, encode_designation_at_bol)
1802 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1803 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1804 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1805 (encode_coding_ccl, encode_coding_raw_text)
1806 (detect_coding_charset, decode_coding_charset)
1807 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1808 (produce_composition, produce_charset, produce_annotation)
1809 (decode_coding, handle_composition_annotation)
1810 (handle_charset_annotation, consume_chars, decode_coding_gap)
1811 (decode_coding_object, encode_coding_object, detect_coding_system)
1812 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1813 (code_convert_region, code_convert_string)
8f50130c
PE
1814 (Fdefine_coding_system_internal)
1815 (coding_set_source, coding_set_destination):
d311d28c
PE
1816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1817 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1818 (Fdefine_coding_system_internal):
1819 Don't assume fixnums fit in int.
1820 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1821 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1822 (Funencodable_char_position, Fcheck_coding_systems_region)
1823 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1825 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1826 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1827 Don't access memory outside of the args array.
d311d28c 1828 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1829 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1830 result of ENCODE_CHAR.
d311d28c
PE
1831 * coding.h: Adjust decls to match defn changes elsewhere.
1832 (struct coding_system):
1833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1834 * composite.c (get_composition_id, find_composition)
1835 (run_composition_function, update_compositions)
1836 (compose_text, composition_gstring_put_cache)
1837 (composition_gstring_p, composition_gstring_width)
1838 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1839 (composition_compute_stop_pos, composition_reseat_it)
1840 (composition_update_it, struct position_record)
1841 (find_automatic_composition, composition_adjust_point)
1842 (Fcomposition_get_gstring, Ffind_composition_internal):
1843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1844 (update_compositions):
1845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1846 * composite.h: Adjust decls to match defn changes elsewhere.
1847 (struct composition):
1848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1849 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1850 Do not attempt to compute the address of the object just before a
1851 buffer; this is not portable.
1852 (Faref, Faset):
1853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1854 (Faset): Use int, not EMACS_INT, where int is wide enough.
1855 (Fstring_to_number): Don't assume fixnums fit in int.
1856 (Frem): Don't assume arg is nonnegative.
1857 * dbusbind.c (xd_append_arg): Check for integers out of range.
1858 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1859 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1860 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1861 (xd_get_connection_references): Return ptrdiff_t, not int.
1862 All uses changed.
1863 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1864 (xd_read_message_1):
1865 Use int, not unsigned, where the dbus API uses int.
1866 (Fdbus_message_internal): Don't overflow mtype.
1867 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1868 * dired.c (directory_files_internal, file_name_completion, scmp)
1869 (file_name_completion_stat):
1870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1871 (file_name_completion): Don't overflow matchcount.
1872 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1873 * dispextern.h: Adjust decls to match defn changes elsewhere.
1874 (struct text_pos, struct glyph, struct bidi_saved_info)
1875 (struct bidi_string_data, struct bidi_it, struct composition_it)
1876 (struct it):
1877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1878 (struct display_pos, struct composition_it, struct it):
1879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1880 * dispnew.c (increment_matrix_positions)
1881 (increment_row_positions, mode_line_string)
1882 (marginal_area_string):
1883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1884 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1886 (duration_to_sec_usec): New function, to check for overflow better.
1887 (Fsleep_for, sit_for): Use it.
1888 * doc.c (get_doc_string, store_function_docstring):
1889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1890 (get_doc_string, Fsnarf_documentation):
1891 Use int, not EMACS_INT, where int is wide enough.
1892 (get_doc_string):
1893 Use SAFE_ALLOCA, not alloca.
1894 Check for overflow when converting EMACS_INT to off_t.
1895 * doprnt.c (doprnt):
1896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1897 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1898 Don't assume uid_t fits into fixnum.
1899 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1900 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1901 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1902 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1903 (general_insert_function)
1904 (Finsert_char, make_buffer_string, make_buffer_string_both)
1905 (update_buffer_properties, Fbuffer_substring)
1906 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1907 (Fsubst_char_in_region, check_translation)
1908 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1909 (transpose_markers, Ftranspose_regions):
1910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1911 (clip_to_bounds): Move to lisp.h as an inline function).
1912 (Fconstrain_to_field): Don't assume integers are nonnegative.
1913 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1914 (Fsubst_char_in_region, Fsave_restriction):
1915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1916 (Femacs_pid): Don't assume pid_t fits into fixnum.
1917 (lo_time): Use int, not EMACS_INT, when int suffices.
1918 (lisp_time_argument): Check for usec out of range.
1919 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1920 (Fuser_login_name, Fuser_full_name): Signal an error
1921 if a uid argument is out of range, rather than relying on
1922 undefined behavior.
c8d5c857
PE
1923 (Fformat_time_string): Remove now-unnecessary check.
1924 lisp_time_argument checks for out-of-range usec now.
243e0530 1925 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1926 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1927 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1928 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1929 (init_cmdargs, Fdump_emacs):
1930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1931 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1932 the bottom (typically) 32 bits of the fixnum.
1933 * eval.c (specpdl_size, call_debugger):
1934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1935 (when_entered_debugger, Fbacktrace_debug):
1936 Don't assume fixnum can fit in int.
1937 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1938 the object just before a buffer; this is not portable.
1939 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1940 (grow_specpdl, unbind_to):
1941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1942 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1943 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1944 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1945 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1946 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1948 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1949 (a_write, e_write):
1950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1951 (Fcopy_file, non_regular_nbytes, read_non_regular)
1952 (Finsert_file_contents):
1953 Use int, not EMACS_INT, where int is wide enough.
1954 (READ_BUF_SIZE): Verify that it fits in int.
1955 (Finsert_file_contents): Check that counts are in proper range,
1956 rather than assuming fixnums fit into ptrdiff_t etc.
1957 Don't assume fixnums fit into int.
125b3835 1958 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1959 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1960 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1961 (string_char_to_byte, string_byte_to_char)
1962 (string_make_multibyte, string_to_multibyte)
1963 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1964 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1965 (substring_both, Fdelete, internal_equal, Ffillarray)
1966 (Fclear_string, mapcar1)
1967 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1968 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1969 (larger_vector, make_hash_table, maybe_resize_hash_table)
1970 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1971 (Fmaphash, secure_hash):
1972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1973 (concat): Check for string index and length overflow.
1974 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1975 (Frequire):
1976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1977 (larger_vector): New API (vec, incr_min, size_max) replaces old
1978 one (vec, new_size, init). This catches size overflow.
1979 INIT was removed because it was always Qnil.
1980 All callers changed.
1981 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1982 the upper bound on a hash table index size.
1983 (make_hash_table, maybe_resize_hash_table): Use it.
1984 (secure_hash): Computer start_byte and end_byte only after
1985 they're known to be in ptrdiff_t range.
1986 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1987 (Ffont_get_glyphs, Ffont_at):
1988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1989 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1990 (Flist_fonts, Fopen_font):
1991 Don't assume fixnum can fit in int.
1992 (check_gstring): Don't assume index can fit in int.
1993 (font_match_p): Check that fixnum is a character, not a nonnegative
1994 fixnum, since the later code needs to stuff it into an int.
1995 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1996 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1997 conversion overflow issues.
1998 (Fopen_font): Check for integer out of range.
1999 (Ffont_get_glyphs): Don't assume index can fit in int.
2000 * font.h: Adjust decls to match defn changes elsewhere.
2001 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2002 integer overflow.
2003 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2004 printmax_t, where ptrdiff_t is wide enough.
2005 (Finternal_char_font):
2006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2007 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2008 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2009 (Fset_frame_position, x_set_frame_parameters)
2010 (x_set_line_spacing, x_set_border_width)
2011 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2012 Check that fixnums are in proper range for system types.
2013 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2015 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2016 Use SAFE_ALLOCA_LISP, not alloca.
2017 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2018 intptr_t is wide enough.
2019 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2020 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2021 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2022 Check for fixnum out of range.
2023 * ftfont.c (ftfont_list): Don't assume index fits in int.
2024 Check that fixnums are in proper range for system types.
2025 (ftfont_shape_by_flt):
2026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2027 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2029 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2030 Check that fixnums are in proper range for system types.
2031 * gnutls.h: Adjust decls to match defn changes elsewhere.
2032 * gtkutil.c (xg_dialog_run):
2033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2034 (update_frame_tool_bar):
2035 Check that fixnums are in proper range for system types.
2036 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2037 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2038 * indent.c (last_known_column, last_known_column_point):
2039 (current_column_bol_cache):
2040 (skip_invisible, current_column, check_display_width):
2041 (check_display_width, scan_for_column, current_column_1)
2042 (Findent_to, Fcurrent_indentation, position_indentation)
2043 (indented_beyond_p, Fmove_to_column, compute_motion):
2044 (Fcompute_motion, Fvertical_motion):
2045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2046 (last_known_column_modified): Use EMACS_INT, not int.
2047 (check_display_width):
2048 (Fcompute_motion):
2049 Check that fixnums and floats are in proper range for system types.
2050 (compute_motion): Don't assume index or fixnum fits in int.
2051 (compute_motion, Fcompute_motion):
2052 Use int, not EMACS_INT, when it is wide enough.
2053 (vmotion): Omit local var start_hpos that is always 0; that way
2054 we don't need to worry about overflow in expressions involving it.
2055 * indent.h: Adjust decls to match defn changes elsewhere.
2056 (struct position):
2057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2058 Use int, not EMACS_INT, where int is wide enough.
2059 Remove unused members ovstring_chars_done and tab_offset;
2060 all uses removed.
2061 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2062 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2063 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2064 (make_gap, copy_text, insert, insert_and_inherit)
2065 (insert_before_markers, insert_before_markers_and_inherit)
2066 (insert_1, count_combining_before, count_combining_after)
2067 (insert_1_both, insert_from_string)
2068 (insert_from_string_before_markers, insert_from_string_1)
2069 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2070 (adjust_after_replace, adjust_after_insert, replace_range)
2071 (replace_range_2, del_range, del_range_1, del_range_byte)
2072 (del_range_both, del_range_2, modify_region)
2073 (prepare_to_modify_buffer, signal_before_change)
2074 (signal_after_change, Fcombine_after_change_execute):
2075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2076 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2077 (balance_an_interval, split_interval_right, split_interval_left)
2078 (find_interval, next_interval, update_interval)
2079 (adjust_intervals_for_insertion, delete_node, delete_interval)
2080 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2081 (static_offset_intervals, offset_intervals)
2082 (merge_interval_right, merge_interval_left, make_new_interval)
2083 (graft_intervals_into_buffer, temp_set_point_both)
2084 (temp_set_point, set_point, adjust_for_invis_intang)
2085 (set_point_both, move_if_not_intangible, get_property_and_range)
2086 (get_local_map, copy_intervals, copy_intervals_to_string)
2087 (compare_string_intervals, set_intervals_multibyte_1):
2088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2089 * intervals.h: Adjust decls to match defn changes elsewhere.
2090 (struct interval):
2091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2092 * keyboard.c (this_command_key_count, this_single_command_key_start)
2093 (before_command_key_count, before_command_echo_length, echo_now)
2094 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2095 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2096 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2097 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2099 (last_non_minibuf_size, last_point_position, echo_truncate)
2100 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2101 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2102 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2103 (stuff_buffered_input):
2104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2105 (last_auto_save, command_loop_1, read_char):
2106 Use EMACS_INT, not int, to avoid integer overflow.
2107 (record_char): Avoid overflow in total_keys computation.
2108 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2109 * keyboard.h: Adjust decls to match defn changes elsewhere.
2110 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2111 (Fkey_description, Fdescribe_vector, Flookup_key):
2112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2113 (click_position): New function, to check that positions are in range.
2114 (Fcurrent_active_maps):
2115 (describe_command):
2116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2117 (Faccessible_keymaps, Fkey_description):
2118 (preferred_sequence_p):
2119 Don't assume fixnum can fit into int.
2120 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2121 Check for integer overflow in size calculations.
2122 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2123 avoid mishandling large integers.
2124 * lisp.h: Adjust decls to match defn changes elsewhere.
2125 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2126 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2127 (struct Lisp_Marker):
2128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2129 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2130 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2131 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2132 All callers changed.
2133 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2134 Assume the arg has valid form, since it always does.
2135 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2136 unsigned integer system type.
2137 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2138 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2140 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2141 (duration_to_sec_usec): New decl.
2142 * lread.c (read_from_string_index, read_from_string_index_byte)
2143 (read_from_string_limit, readchar, unreadchar, openp)
2144 (read_internal_start, read1, oblookup):
2145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2146 (Fload, readevalloop, Feval_buffer, Feval_region):
2147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2148 (openp): Check for out-of-range argument to 'access'.
2149 (read1): Use int, not EMACS_INT, where int is wide enough.
2150 Don't assume fixnum fits into int.
6efdadfd 2151 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2152 (read_filtered_event): Use duration_to_sec_usec
2153 to do proper overflow checking on durations.
d311d28c
PE
2154 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2155 in size calculation.
2156 (Fexecute_kbd_macro):
2157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2158 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2159 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2160 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2161 (set_marker_both, set_marker_restricted_both, marker_position)
2162 (marker_byte_position, Fbuffer_has_markers_at):
2163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2164 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2165 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2166 It now merely ensures that the menu is large enough, without
2167 necessarily growing it, as this avoids some integer overflow issues.
2168 All callers changed.
2169 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2171 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2172 Use SAFE_ALLOCA_LISP, not alloca.
2173 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2174 to EMACS_INT. Check that fixnums are in proper range for system types.
2175 * minibuf.c (minibuf_prompt_width, string_to_object)
2176 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2177 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2179 (get_minibuffer, read_minibuf_unwind):
2180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2181 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2182 this simplifies overflow checking. All callers changed.
2183 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2184 (Ftest_completion):
2185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2186 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2187 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2188 Check that fixnums are in proper range for system types.
2189 (Fx_create_frame, Fx_show_tip):
2190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2191 * nsfont.m (ns_findfonts, nsfont_list_family):
2192 Don't assume fixnum fits in long.
2193 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2195 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2196 wide enough.
17fdb222 2197 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2199 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2200 (PRINTDECLARE, PRINTPREPARE):
2201 (strout, print_string):
2202 (print, print_preprocess, print_check_string_charset_prop)
2203 (print_object):
2204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2205 (PRINTDECLARE):
2206 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2208 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2209 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2210 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2211 (print_error_message): Use SAFE_ALLOCA, not alloca.
2212 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2213 (print_depth, new_backquote_output, print_number_index):
2214 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2215 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2216 (Fset_process_window_size, Fformat_network_address)
2217 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2218 (sigchld_handler):
d311d28c 2219 Check that fixnums are in proper range for system types.
d44287d4 2220 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2221 Check for process-ids out of pid_t range rather than relying on
2222 undefined behavior.
e4d81efc 2223 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2224 (Fformat_network_address, read_process_output, send_process)
2225 (Fprocess_send_region, status_notify):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2228 (wait_reading_process_output, read_process_output, exec_sentinel):
2229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2230 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2231 (Faccept_process_output): Use duration_to_sec_usec to do proper
2232 overflow checking on durations.
dde14581
PE
2233 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2234 Don't assume pid_t fits in int.
02481186
PE
2235 * process.h (struct Lisp_Process): Members tick and update_tick
2236 are now of type EMACS_INT, not int.
b62b53e8
PE
2237 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2238 configured --with-wide-int.
d311d28c
PE
2239 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2240 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2241 * search.c (looking_at_1, string_match_1):
2242 (fast_string_match, fast_c_string_match_ignore_case)
2243 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2244 (scan_newline, find_before_next_newline, search_command)
2245 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2246 (set_search_regs, wordify):
2247 (Freplace_match):
2248 (Fmatch_data):
2249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2250 (string_match_1, search_buffer, set_search_regs):
2251 (Fmatch_data):
2252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2253 (wordify): Check for overflow in size calculation.
2254 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2255 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2256 Check that fixnums are in proper range for system types.
2257 * sound.c (struct sound_device)
2258 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2260 (Fplay_sound_internal):
2261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2262 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2263 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2264 (Fparse_partial_sexp):
2265 Don't assume fixnums can fit in int.
2266 (struct lisp_parse_state, find_start_pos, find_start_value)
2267 (find_start_value_byte, find_start_begv)
2268 (update_syntax_table, char_quoted, dec_bytepos)
2269 (find_defun_start, prev_char_comend_first, back_comment):
2270 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2271 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2273 (Finternal_describe_syntax_value): Check that match_lisp is a
2274 character, not an integer, since the code stuffs it into int.
2275 (scan_words, scan_sexps_forward):
2276 Check that fixnums are in proper range for system types.
2277 (Fforward_word):
2278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2279 (scan_sexps_forward):
2280 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2281 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2282 * syntax.h: Adjust decls to match defn changes elsewhere.
2283 (struct gl_state_s):
2284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2285 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2286 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2287 * sysdep.c (wait_for_termination_1, wait_for_termination)
2288 (interruptible_wait_for_termination, mkdir):
2289 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2290 (emacs_read, emacs_write):
2291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2292 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2293 and double all fit in int.
d311d28c
PE
2294 * term.c (set_tty_color_mode):
2295 Check that fixnums are in proper range for system types.
2296 * termhooks.h (struct input_event):
2297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2298 * textprop.c (validate_interval_range, interval_of)
2299 (Fadd_text_properties, set_text_properties_1)
2300 (Fremove_text_properties, Fremove_list_of_text_properties)
2301 (Ftext_property_any, Ftext_property_not_all)
2302 (copy_text_properties, text_property_list, extend_property_ranges)
2303 (verify_interval_modification):
2304 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2305 (Fnext_single_char_property_change)
2306 (Fprevious_single_char_property_change):
2307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2308 (copy_text_properties):
2309 Check for integer overflow in index calculation.
d311d28c
PE
2310 * undo.c (last_boundary_position, record_point, record_insert)
2311 (record_delete, record_marker_adjustment, record_change)
2312 (record_property_change):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2316 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2317 (Fx_hide_tip, Fx_file_dialog):
2318 * w32menu.c (set_frame_menubar):
2319 Use ptrdiff_t, not int, for consistency with rest of code.
2320 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2321 (select_window, Fdelete_other_windows_internal)
2322 (window_scroll_pixel_based, window_scroll_line_based)
2323 (Frecenter, Fset_window_configuration):
2324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2325 (Fset_window_hscroll, run_window_configuration_change_hook)
2326 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2327 (Fscroll_other_window, Frecenter):
d311d28c
PE
2328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2329 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2330 Don't assume fixnum fits in int.
2331 (Fset_window_scroll_bars):
2332 Check that fixnums are in proper range for system types.
2333 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2334 (string_pos, c_string_pos, number_of_chars, init_iterator)
2335 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2336 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2337 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2338 (face_before_or_after_it_pos, handle_invisible_prop)
2339 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2340 (display_prop_intangible_p, string_buffer_position_lim)
2341 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2342 (get_overlay_strings_1, get_overlay_strings)
2343 (iterate_out_of_display_property, forward_to_next_line_start)
2344 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2345 (get_next_display_element, set_iterator_to_next)
2346 (get_visually_first_element, compute_stop_pos_backwards)
2347 (handle_stop_backwards, next_element_from_buffer)
2348 (move_it_in_display_line_to, move_it_in_display_line)
2349 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2350 (add_to_log, message_dolog, message_log_check_duplicate)
2351 (message2, message2_nolog, message3, message3_nolog
2352 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2353 (current_message_1, truncate_echo_area, truncate_message_1)
2354 (set_message, set_message_1, store_mode_line_noprop)
2355 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2356 (text_outside_line_unchanged_p, check_point_in_composition)
2357 (reconsider_clip_changes)
2358 (redisplay_internal, set_cursor_from_row, try_scrolling)
2359 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2360 (redisplay_window, find_last_unchanged_at_beg_row)
2361 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2362 (trailing_whitespace_p, find_row_edges, display_line)
2363 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2364 (display_mode_element, store_mode_line_string)
2365 (pint2str, pint2hrstr, decode_mode_spec)
2366 (display_count_lines, display_string, draw_glyphs)
2367 (x_produce_glyphs, x_insert_glyphs)
2368 (rows_from_pos_range, mouse_face_from_buffer_pos)
2369 (fast_find_string_pos, mouse_face_from_string_pos)
2370 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2372 (safe_call, init_from_display_pos, handle_fontified_prop)
2373 (handle_single_display_spec, load_overlay_strings)
2374 (with_echo_area_buffer, setup_echo_area_for_printing)
2375 (display_echo_area, echo_area_display)
2376 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2377 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2378 (redisplay_window, dump_glyph_row, display_mode_line)
2379 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2380 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2382 (handle_single_display_spec, build_desired_tool_bar_string)
2383 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2384 (get_specified_cursor_type):
2385 Check that fixnums are in proper range for system types.
2386 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2387 (Flookup_image_map):
2388 Don't assume fixnums fit in int.
2389 (compare_overlay_entries):
2390 Avoid mishandling comparisons due to subtraction overflow.
2391 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2392 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2393 (handle_tool_bar_click):
2394 Use int, not unsigned, since we prefer signed and the signedness
2395 doesn't matter here.
2396 (get_next_display_element, next_element_from_display_vector):
2397 Use int, not EMACS_INT, when int is wide enough.
2398 (start_hourglass): Use duration_to_sec_usec to do proper
2399 overflow checking on durations.
2400 * xfaces.c (Fbitmap_spec_p):
2401 Check that fixnums are in proper range for system types.
2402 (compare_fonts_by_sort_order):
2403 Avoid mishandling comparisons due to subtraction overflow.
2404 (Fx_family_fonts, realize_basic_faces):
2405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2406 (Fx_family_fonts):
2407 Don't assume fixnum fits in int.
2408 Use SAFE_ALLOCA_LISP, not alloca.
2409 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2410 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2411 (face_at_buffer_position, face_for_overlay_string)
2412 (face_at_string_position):
2413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2414 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2415 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2416 (Fx_show_tip):
2417 Check that fixnums are in proper range for system types.
2418 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2419 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2420 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2421 (Fx_change_window_property): Don't assume fixnums fit in int.
2422 * xfont.c (xfont_chars_supported):
2423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2424 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2425 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2426 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2427 * xml.c (parse_region):
2428 * xrdb.c (magic_file_p):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2430 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2431 (x_get_local_selection, x_reply_selection_request)
2432 (x_handle_selection_request, wait_for_property_change):
2433 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2434 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2435 short is wide enough.
2436 (x_send_client_event): Don't assume fixnum fits in int.
2437 * xterm.c (x_x_to_emacs_modifiers):
2438 Don't assume EMACS_INT overflows nicely into int.
2439 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2440 may come from Lisp.
2441 (handle_one_xevent): NATNUMP can eval its arg twice.
2442 (x_connection_closed):
2443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2444 * xterm.h: Adjust decls to match defn changes elsewhere.
2445 (struct scroll_bar): Use struct vectorlike_header
2446 rather than rolling our own approximation.
2447 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2448
c6574eb5
GM
24492012-05-25 Glenn Morris <rgm@gnu.org>
2450
2451 * lisp.mk (lisp): Update for more files being compiled now.
2452
e8d32c7e
SM
24532012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2454
48def666
SM
2455 * lread.c: Remove `read_pure' which makes no difference.
2456 (read_pure): Remove var.
2457 (unreadpure): Remove function.
2458 (readevalloop): Don't call read_list with -1 flag.
2459 (read1, read_vector): Don't test read_pure any more.
2460 (read_list): Simplify.
2461
e8d32c7e
SM
2462 * fileio.c, character.h: Minor style tweaks.
2463
4b2addb7
DA
24642012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2465
2466 * window.h (clip_changed): Remove useless declaration.
2467
584461b2
JB
24682012-05-22 Juanma Barranquero <lekktu@gmail.com>
2469
2470 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2471 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2472
34374650
PE
24732012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 Remove src/m/*.
2476 This directory predates autoconf and is no longer needed nowadays.
2477 Move its few remaining bits of functionality to where they're needed.
2478 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2479 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2480 * m/template.h: Remove.
2481 * Makefile.in (M_FILE): Remove. All uses removed.
2482 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2483 * lisp.h (USE_LSB_TAG):
2484 * mem-limits.h (EXCEEDS_LISP_PTR):
2485 Use VAL_MAX, not VALBITS, in #if.
2486 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2487 (EMACS_UINT): Define unconditionally now.
2488 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2489 (BITS_PER_EMACS_INT): New constants, replacing
2490 what used to be in config.h, but not useful in #if.
2491 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2492 define them any more.
2493 (VAL_MAX): New macro.
2494 (VALMASK): Use it.
2495 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2496 BITS_PER_EMACS_INT, in #if.
2497 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2498 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2499 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2500 * s/ms-w32.h (DATA_START):
2501 Move here from removed file m/intel386.h.
2502 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2503 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2504
261cb4bb
PE
25052012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 Assume C89 or later.
2508 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2509 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2510 (xrealloc):
2511 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2512 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2513 * textprop.c, tparam.c (NULL): Remove.
2514 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2515 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2516 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2517 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2518 * xterm.c (input_signal_count): Assume volatile works.
2519
ff23cd9f
KB
25202012-05-21 Ken Brown <kbrown@cornell.edu>
2521
2522 * xgselect.c (xg_select): Fix first argument in call to 'select'
2523 (bug#11508).
2524
1b170bc6
KB
25252012-05-20 Ken Brown <kbrown@cornell.edu>
2526
2527 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2528 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2529
b2f4d39f
KB
25302012-05-19 Ken Brown <kbrown@cornell.edu>
2531
2532 * xfns.c (x_in_use): Remove `static' qualifier.
2533 * xterm.h (x_in_use): Declare.
2534 * xgselect.c: Include xterm.h.
2535 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2536 and `display_arg' (bug#9754).
2537
003fdae2
PE
25382012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2539
9232a6d9
PE
2540 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2541
003fdae2
PE
2542 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2543 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2544
784b56e2
EZ
25452012-05-18 Eli Zaretskii <eliz@gnu.org>
2546
2547 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2548
2549 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2550 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2551
2552 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2553 reference to image_cache->refcount.
2554 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2555
a0a79cde
JL
25562012-05-17 Juri Linkov <juri@jurta.org>
2557
2558 * search.c (Fword_search_regexp, Fword_search_backward)
2559 (Fword_search_forward, Fword_search_backward_lax)
2560 (Fword_search_forward_lax): Move functions to isearch.el
2561 (bug#10145, bug#11381).
2562
b0572523
PE
25632012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2566
9660f5fc
SM
25672012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2568
2569 * lread.c (init_obarray): Declare Qt and Qnil as special.
2570
4374de83
GM
25712012-05-14 Glenn Morris <rgm@gnu.org>
2572
2573 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2574 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2575
dc44c39a
PE
25762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2577
078c97cb
PE
2578 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2579
dc44c39a
PE
2580 * unexaix.c: Port to more-recent AIX compilers.
2581 (report_error, report_error_1, make_hdr, copy_sym)
2582 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2583 Make arguments const char *, not char *, to avoid violations of C
2584 standard and to fix some AIX warnings reported by Gilles Pion.
2585
e18afed7 25862012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2587
2588 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2589 already have overlays loaded.
2590 (handle_single_display_spec): Before returning without displaying
2591 fringe bitmap, synchronize the bidi iterator with the main display
2592 iterator, by calling iterate_out_of_display_property.
2593 (iterate_out_of_display_property): Detect buffer iteration by
2594 testing that it->string is a Lisp string.
2595 (get_next_display_element): When the current object is exhausted,
2596 and there's something on it->stack, call set_iterator_to_next to
2597 proceed with what's on the stack, instead of returning zero.
2598 (set_iterator_to_next): If called at the end of a Lisp string,
2599 proceed to consider_string_end without incrementing string
2600 position. Don't increment display vector index past the end of
2601 the display vector. (Bug#11417)
c8fb9dc6
EZ
2602 (pos_visible_p): Don't report a position visible when move_it_to
2603 stopped at the last line of window, which happens to be scanned
2604 backwards by the bidi iteration. (Bug#11464)
ac268e67 2605
e18afed7 26062012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2607
2608 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2609 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2610 are on a TTY, and thus unable to display on the fringes.
2611 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2612 so we need to signal to the caller that this is a "replacing"
2613 display spec. This fixes display when the spec is invalid or we
2614 are on a TTY.
2615
e18afed7 26162012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2617
2618 * unexaix.c (make_hdr): Fix typo in prototype.
2619 This bug broke the build on AIX. Problem reported by Gilles Pion.
2620
9d0a235a
MA
26212012-05-14 Michael Albinus <michael.albinus@gmx.de>
2622
2623 * keyboard.c (kbd_buffer_get_event): Read special events also in
2624 batch mode. (Bug#11415)
2625
9e6b06ed
GM
26262012-05-12 Glenn Morris <rgm@gnu.org>
2627
2628 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2629
c1a1d7a3
EZ
26302012-05-12 Eli Zaretskii <eliz@gnu.org>
2631
2632 * lisp.mk (lisp): Add newcomment.elc.
2633
3fe7cdc8
GM
26342012-05-12 Glenn Morris <rgm@gnu.org>
2635
2636 * Makefile.in (MKDIR_P): New, set by configure.
2637 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2638
53f7d2c0
PE
26392012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2640
2641 Remove unused function hourglass_started.
2642 * dispextern.h (hourglass_started):
2643 * w32fns.c (hourglass_started):
2644 * xdisp.c (hourglass_started): Remove.
2645
75aafb17
JB
26462012-05-10 Juanma Barranquero <lekktu@gmail.com>
2647
2648 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2649 Update dependencies.
2650
12959e8e
PE
26512012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2652
97107e2e
PE
2653 * xgselect.c (xg_select): Put maxfds+1 into a var.
2654 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2655
12959e8e
PE
2656 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2657
836d29b3
DA
26582012-05-10 Dave Abrahams <dave@boostpro.com>
2659
2660 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2661 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2662
5cb67954
MA
26632012-05-09 Michael Albinus <michael.albinus@gmx.de>
2664
2665 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2666 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2667 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2668 Initialize xd_registered_buses.
2669
3478ec45
PE
26702012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2671
b263a6b0
PE
2672 Untag more efficiently if USE_LSB_TAG.
2673 This is based on a proposal by YAMAMOTO Mitsuharu in
2674 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2675 For an admittedly artificial (nth 8000 longlist) benchmark on
2676 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2677 Emacs's overall text size by 1%.
2678 * lisp.h (XUNTAG): New macro.
2679 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2680 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2681 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2682 * eval.c (Fautoload):
2683 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2684 * frame.h (XFRAME): Use XUNTAG.
2685
3478ec45
PE
2686 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2687 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2688 Remove unportable assumptions about print widths of types like
2689 dbus_uint32_t.
2690 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2691 intptr_t when converting between pointer and integer, to avoid GCC
2692 warnings about wrong width.
2693
666b903b 26942012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2695
2696 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2697 stack for each reader_thread, instead of defaulting to 8MB
2698 determined by the linker. This avoids failures in creating
2699 subprocesses on Windows 7, see the discussion in this thread:
2700 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2701
b120cc17
JC
27022012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2703
2704 Fix up display of the *Minibuf-0* buffer in the mini window.
2705 * keyboard.c (read_char): Don't clear the echo area if there's no
2706 message to clear.
2707 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2708 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2709
9a4b36f8
MA
27102012-05-07 Michael Albinus <michael.albinus@gmx.de>
2711
2712 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2713 batch mode.
2714
e5f9458f
CY
27152012-05-06 Chong Yidong <cyd@gnu.org>
2716
2717 * lisp.mk (lisp): Update.
2718
eceeb5fc 27192012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2720
2721 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2722
71873e2b
SM
27232012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2724
2725 * data.c (PUT_ERROR): New macro.
2726 (syms_of_data): Use it. Add new error type `user-error'.
2727 * undo.c (user_error): New function.
2728 (Fprimitive_undo): Use it.
2729 * print.c (print_error_message): Adjust print style for `user-error'.
2730 * keyboard.c (user_error): New function.
2731 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2732
ab0fa4e4
PE
27332012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2734
2735 Do not limit current-time-string to years 1000..9999.
2736 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2737 (Fcurrent_time_string): Support any year that is supported by the
2738 underlying localtime representation. Don't use asctime, as it
2739 has undefined behavior for years outside the range -999..9999.
2740
7ed806a7
PE
27412012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 Fix race conditions involving setenv, gmtime, localtime, asctime.
2744 Without this fix, interrupts could mess up code that uses these
2745 nonreentrant functions, since setting TZ invalidates existing
2746 tm_zone or tzname values, and since most of these functions return
2747 pointers to static storage.
2748 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2749 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2750 Grow the critical sections to include not just invoking
2751 localtime/gmtime, but also accessing these functions' results
2752 including their tm_zone values if any, and any related TZ setting.
2753 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2754 so that the struct tm is saved in the critical section.
2755 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2756 motivated by the fact that memory allocation needs to be outside
2757 the critical section.
2758
0c16dfed
DA
27592012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2760
2761 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2762 with RESET_INTERVAL.
2763
2764 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2765 Remove duplicated buffer name initialization.
2766
3f83ace8
JM
27672012-05-02 Jim Meyering <jim@meyering.net>
2768
2769 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2770
c7b8541e
JM
2771 * xfns.c (x_window): Use xstrdup (Bug#11375).
2772
90207a15 27732012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2774
2775 * xdisp.c (pos_visible_p): If already at a newline from the
2776 display string before the 'while' loop, don't walk back the glyphs
2777 from it3.glyph_row. Solves assertion violation when the display
2778 string begins with a newline (egg.el). (Bug#11367)
2779
b593d6a9
AH
27802012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2781
2782 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2783 Move to simple.el.
2784
4737362e
GM
27852012-05-01 Glenn Morris <rgm@gnu.org>
2786
99cf43f9
GM
2787 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2788 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2789 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2790 All were removed before 23.1.
2791
9311dcff
GM
2792 * dispnew.c: Remove HAVE_LIBNCURSES test;
2793 it is always true on relevant platforms.
2794
4d5c6349
GM
2795 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2796 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2797
4737362e
GM
2798 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2799
74dd3a6b
AS
28002012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2801
2802 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2803 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2804 Remove.
2805
13c379ee
PE
28062012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2807
2808 Do not avoid creating empty evaporating overlays (Bug#9642).
2809 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2810 That is, do not delete an evaporating overlay if it becomes
2811 empty after its bounds are adjusted to fit within its buffer.
2812 This fix caused other problems, and I'm reverting it until we get
2813 to the bottom of them.
2814
a8e7d6d7 28152012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2816
2817 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2818
a8e7d6d7 28192012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2820
2821 * xdisp.c (pos_visible_p): If the window start position is beyond
2822 ZV, start the display from buffer beginning. Prevents assertion
2823 violation in init_iterator when the minibuffer window is scrolled
2824 via the scroll bar.
2825
2826 * window.c (window_scroll_pixel_based): Likewise.
2827
a8e7d6d7 28282012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2829
2830 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2831
a8e7d6d7 28322012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2833
2834 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2835 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2836
a8e7d6d7 28372012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2838
b593d6a9
AH
2839 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2840 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2841
1c6900d9
EZ
28422012-04-26 Eli Zaretskii <eliz@gnu.org>
2843
4c3fa1d9
EZ
2844 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2845 display element, check also the underlying string or buffer
2846 character. (Bug#11341)
2847
1c6900d9
EZ
2848 * w32menu.c: Include w32heap.h.
2849 (add_menu_item): If the call to AppendMenuW (via
2850 unicode_append_menu) fails, disable Unicode menus only if we are
2851 running on Windows 9X/Me.
2852
42bf8205
AS
28532012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2854
2855 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2856 (xgetint): Add missing shift for LSB tags.
2857
b1bac16e
MR
28582012-04-24 Martin Rudalics <rudalics@gmx.at>
2859
2860 * keyboard.c (read_char): Don't wipe echo area for select window
2861 events: These might get delayed via `mouse-autoselect-window'
2862 (Bug#11304).
2863
d69621cc
JB
28642012-04-24 Juanma Barranquero <lekktu@gmail.com>
2865
2866 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2867 manipulation of :loaded-from data.
2868
02fd101b
JB
28692012-04-23 Juanma Barranquero <lekktu@gmail.com>
2870
2871 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2872 now a cons (bug#11311).
2873
888bec30
PE
28742012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2875
89a438bd
PE
2876 Do not create empty overlays with the evaporate property (Bug#9642).
2877 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2878 if it becomes empty after its bounds are adjusted to fit within
2879 its buffer. Without this fix, in a nonempty buffer (let ((o
2880 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2881 yields an empty overlay that has the evaporate property, which is
2882 not supposed to happen.
2883
1068fe4d
PE
2884 Fix minor GTK3 problems found by static checking.
2885 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2886 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2887 (struct _EmacsFixedClass, emacs_fixed_get_type):
2888 Move decls here from emacsgtkfixed.h, since they needn't be public.
2889 (emacs_fixed_get_type): Now static.
2890 (emacs_fixed_class_init): Omit unused local.
2891 (emacs_fixed_child_type): Remove; unused.
2892 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2893 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2894 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2895 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2896 (EMACS_FIXED_GET_CLASS): Remove; unused.
2897 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2898
888bec30
PE
2899 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2900 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2901
de85e130
PE
29022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2903
d0baac98 2904 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2905 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2906 (__malloc_size_t, __malloc_ptrdiff_t):
2907 Remove. All uses removed, replaced by the definiens if needed,
2908 since we can assume C89 or better now.
2909 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2910 (protect_malloc_state, align, get_contiguous_space)
2911 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2912 (malloc_atfork_handler_child, malloc_enable_thread)
2913 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2914 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2915 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2916 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2917 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2918 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2919 Define using prototypes, not old style.
2920 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2921 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2922 (align): Don't assume that signed integer overflow wraps around.
2923 Omit unused local var.
2924 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2925 (_free_internal_nolock, memalign, mallochook, reallochook):
2926 Omit no-longer-needed casts.
2927 (valloc): Use getpagesize, not __getpagesize.
2928 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2929 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2930
de85e130
PE
2931 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2932
dcbf5805
MA
29332012-04-22 Michael Albinus <michael.albinus@gmx.de>
2934
2935 Move functions from C to Lisp. Make non-blocking method calls
2936 the default. Implement further D-Bus standard interfaces.
2937
2938 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2939 (QCdbus_request_name_allow_replacement)
2940 (QCdbus_request_name_replace_existing)
2941 (QCdbus_request_name_do_not_queue)
2942 (QCdbus_request_name_reply_primary_owner)
2943 (QCdbus_request_name_reply_in_queue)
2944 (QCdbus_request_name_reply_exists)
2945 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2946 (QCdbus_registered_serial, QCdbus_registered_method)
2947 (QCdbus_registered_signal): New Lisp objects.
2948 (XD_DEBUG_MESSAGE): Use sizeof.
2949 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2950 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2951 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2952 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2953 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2954 (xd_signature, xd_append_arg): Allow float for integer types.
2955 (xd_get_connection_references): New function.
b593d6a9
AH
2956 (xd_get_connection_address): Rename from xd_initialize.
2957 Return cached address.
dcbf5805
MA
2958 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2959 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2960 level.
2961 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2962 Return number of refcounts.
dcbf5805
MA
2963 (Fdbus_get_unique_name): Make stronger parameter check.
2964 (Fdbus_message_internal): New defun.
2965 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2966 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2967 (Fdbus_send_signal, Fdbus_register_service)
2968 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2969 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2970 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2971 (Vdbus_compiled_version, Vdbus_runtime_version)
2972 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2973 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2974 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2975 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2976 Adapt docstring.
dcbf5805 2977
52828e02
PE
29782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2979
da05bc4c
PE
2980 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2981 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2982 Do not assume ptrdiff_t is the same width as 'int'.
2983
52828e02
PE
2984 * alloc.c: Handle unusual debugging option combinations.
2985 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2986 since the two debugging options are incompatible.
2987 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2988 is defined.
2989 (mem_init, mem_insert, mem_insert_fixup):
2990 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2991 (NEED_MEM_INSERT): Remove; no longer needed.
2992
f01769f9
LL
29932012-04-22 Leo Liu <sdl.web@gmail.com>
2994
2995 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2996
5790543d
PE
29972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 * sysdep.c [__FreeBSD__]: Minor cleanups.
3000 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3001 Use Emacs indenting style more consistently. Avoid some casts.
3002 Use 'double' consistently rather than mixing 'float' and 'double'.
3003
b91b7e4d
EW
30042012-04-21 Eduard Wiebe <usenet@pusto.de>
3005
b593d6a9
AH
3006 * sysdep.c (list_system_processes, system_process_attributes):
3007 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3008
6114eb15
AS
30092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3010
3011 * lisp.mk (lisp): Update.
3012
2f38dff7
PE
30132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3016 It is never used otherwise.
3017
4ae29f89
SM
30182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3019
3020 * print.c (print_preprocess): Only check print_depth if print-circle
3021 is nil.
3022 (print_object): Check for cycles even when print-circle is nil and
3023 print-gensym is t, but only check print_depth if print-circle is nil.
3024
f30d612a
CY
30252012-04-20 Chong Yidong <cyd@gnu.org>
3026
3027 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3028 set the status to "failed" and ensure that sentinel is run.
3029
c07a4c0b 30302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3031
3032 * process.c (Fset_process_inherit_coding_system_flag)
3033 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3034 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3035
c07a4c0b 30362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3037
3038 * xdisp.c (string_buffer_position_lim): Limit starting position to
3039 BEGV.
3040 (set_cursor_from_row): If called for a mode-line or header-line
3041 row, return zero immediately.
3042 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3043 farther than the first row after the header line, if any.
3044 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3045 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3046
c07a4c0b 30472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3048
4ae29f89
SM
3049 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3050 (bug#11238).
ad3a2b41 3051
c07a4c0b 30522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 30532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3054
3055 configure: new option --enable-gcc-warnings (Bug#11207)
3056 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3057 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3058 (ALL_CFLAGS): Use new macros rather than old.
3059 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3060 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3061 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3062 -Wunused-result, -Wunused-variable. This should go away once
3063 the Emacs and Gnulib regex code is merged.
3064 (xmalloc, xrealloc): Now static.
3065
aba027e8
PE
30662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 * dired.c (Fsystem_groups): Remove unused local.
3069
e5a36063
GM
30702012-04-17 Glenn Morris <rgm@gnu.org>
3071
3072 * dired.c (Fsystem_users): Doc fix.
3073
316411f0
DA
30742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3075
3076 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3077 (syms_of_dired): Add them.
3078
9426aba4
PE
30792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3080
b62a57be
PE
3081 Fix minor alloc.c problems found by static checking.
3082 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3083 New extern decls, to avoid calling undeclared functions.
3084 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3085 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3086 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3087 (NEED_MEM_INSERT): New macro.
3088 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3089 Remove one incorrect comment and fix another.
b62a57be 3090
3539f31f
PE
3091 Fix minor ralloc.c problems found by static checking.
3092 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3093 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3094 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3095 (r_alloc_sbrk): Now static.
3096
a041960a
PE
3097 Improve ralloc.c interface checking.
3098 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3099 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3100 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3101 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3102 [REL_ALLOC]: ... to here, to check interface.
3103 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3104 Remove decls. This fixes an "It stinks!".
3105
9426aba4
PE
3106 * alloc.c (which_symbols): Fix alignment issue / type clash.
3107
d55c12ed
AS
31082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3109
3110 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3111 (struct Lisp_Misc_Any): Likewise.
3112 (struct Lisp_Free): Likewise.
3113 * alloc.c (union aligned_Lisp_Symbol): Define.
3114 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3115 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3116 (union aligned_Lisp_Misc): Define.
3117 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3118 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3119 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3120
b948ce8b
PE
31212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3124 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3125 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3126 * s/netbsd.h, s/sol2-6.h:
3127 Remove definition of GC_MARK_STACK, since the default now works.
3128 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3129 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3130 no longer the default.
3131 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3132
35dc09a1 31332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3134
35dc09a1
GM
3135 * lread.c (lisp_file_lexically_bound_p):
3136 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3137
35dc09a1
GM
31382012-04-14 Eli Zaretskii <eliz@gnu.org>
3139
3140 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3141 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3142
31432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3144
3145 * nsterm.m (constrainFrameRect): Always constrain when there is only
3146 one screen (Bug#10962).
3147
bcd86815
KB
31482012-04-13 Ken Brown <kbrown@cornell.edu>
3149
3150 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3151
c25df26e
RT
31522012-04-13 Reuben Thomas <rrt@sc3d.org>
3153
3154 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3155
0fc59f1e
DC
31562012-04-11 Daniel Colascione <dancol@dancol.org>
3157
3158 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3159 against is gone. It's better to use vfork now so that when Cygwin
3160 gains a new, working vfork, we use it automatically (bug#10398).
3161
de8c03dc
SM
31622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3163
3164 * window.c (save_window_save): Obey window-point-insertion-type.
3165
2f097256
GM
31662012-04-11 Glenn Morris <rgm@gnu.org>
3167
3168 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3169
453b951e
SM
31702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3171
3172 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3173
75f1671a 31742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3175
3176 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3177 (force_quit_count): New var.
3178 (handle_interrupt): Use it.
3179
2a8ce227
JB
31802012-04-10 Juanma Barranquero <lekktu@gmail.com>
3181
3182 * w32.c (w32_delayed_load): Record the full path of the library
3183 being loaded (bug#10424).
3184
935396c0
GM
31852012-04-09 Glenn Morris <rgm@gnu.org>
3186
05920a43
GM
3187 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3188 not just in the obarray, before snarfing them. (Bug#11036)
3189
935396c0
GM
3190 * Makefile.in ($(leimdir)/leim-list.el):
3191 Pass EMACS rather than BUILT_EMACS.
3192
a18ecafa
TZ
31932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3194
3195 * process.c (make_process):
3196 * process.h: Add integer `gnutls_handshakes_tried' member to
3197 process struct.
3198
6bbef4e5
JC
3199 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3200 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3201
3202 * gnutls.c (gnutls_log_function2i): Convenience log function.
3203 (emacs_gnutls_read): Use new log functions,
3204 `gnutls_handshakes_tried' process member, and
3205 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3206 attempts per process (connection).
3207
b4d3bc10
CY
32082012-04-09 Chong Yidong <cyd@gnu.org>
3209
3210 * eval.c (Fuser_variable_p, user_variable_p_eh)
3211 (lisp_indirect_variable): Functions deleted.
3212 (Fdefvar): Caller changed.
3213
3214 * callint.c (Finteractive, Fcall_interactively):
3215 * minibuf.c (Fread_variable): Callers changed.
3216
70f4d973
EZ
32172012-04-09 Eli Zaretskii <eliz@gnu.org>
3218
3219 * xdisp.c (set_cursor_from_row): If the display string appears in
3220 the buffer at position that is closer to point than the position
3221 after the display string, display the cursor on the first glyph of
3222 the display string. Fixes cursor display when a 'display' text
3223 property immediately follows invisible text. (Bug#11094)
3224
cb3c2e3e
PE
32252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 composite.c: use 'double' consistently
3228 * composite.c (get_composition_id): Use 'double' consistently
3229 instead of converting 'float' to 'double' and vice versa; this is
3230 easier to understand and avoids a GCC warning.
3231
fd06db5d
GM
32322012-04-09 Glenn Morris <rgm@gnu.org>
3233
50fe702a
GM
3234 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3235 preparation for dumping it with emacs. (Bug#4789)
3236 (leimdir): New variable.
3237 ($(leimdir)/leim-list.el): New rule.
3238 (emacs$(EXEEXT)): Depend on leim-list.el.
3239
fd06db5d
GM
3240 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3241 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3242 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3243
55c131ee
AS
32442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3245
3246 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3247 proper alignment.
3248
9209588f
JB
32492012-04-07 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3252 Remove unused local variable.
3253
e3fb2efb
PE
32542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3257 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3258 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3259 objects, as mark_maybe_pointer will catch them otherwise.
3260 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3261 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3262
b5385551
PE
32632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 Fix typo that broke non-Windows builds.
3266 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3267
9078ead6
EZ
32682012-04-07 Eli Zaretskii <eliz@gnu.org>
3269
3270 Support building on MS-Windows with libxml2.
3271
3272 * makefile.w32-in (OBJ2): Add xml.$(O).
3273 (GLOBAL_SOURCES): Add xml.c.
3274 ($(BLD)/xml.$(O)): New dependency list.
3275
3276 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3277 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3278 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3279 [!WINDOWSNT]: New macros.
3280 (init_libxml2_functions, libxml2_loaded_p): New functions.
3281 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3282 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3283 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3284 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3285 linked in).
6bbef4e5
JC
3286 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3287 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3288 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3289
3290 * emacs.c: Don't include libxml/parser.h.
3291 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3292 xmlCleanupParser directly.
3293
3294 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3295
3811fdf3
EZ
32962012-04-07 Eli Zaretskii <eliz@gnu.org>
3297
3298 * indent.c (Fvertical_motion): If there is a display string at
3299 point, use it.vpos to compute how many lines to backtrack after
3300 move_it_to point. (Bug#11133)
3301
2f8e16b2
EZ
33022012-04-06 Eli Zaretskii <eliz@gnu.org>
3303
3304 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3305 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3306 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3307 macros related to unification of CJK characters. For the details,
3308 see the discussion following the message here:
3309 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3310
3d439cd1
CY
33112012-04-04 Chong Yidong <cyd@gnu.org>
3312
3313 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3314
8bc53d00
EZ
33152012-04-01 Eli Zaretskii <eliz@gnu.org>
3316
3317 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3318 instead of alloca. (Bug#11138)
3319
3b0512a3
AS
33202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3321
3322 * w32menu.c (is_simple_dialog): Properly check lisp types.
3323 (Bug#11141)
3324
8427ddd2
EZ
33252012-03-31 Eli Zaretskii <eliz@gnu.org>
3326
979022ef
EZ
3327 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3328 position we get to after a call to move_it_to fails the
3329 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3330 only if we wind up in a string from display property. (Bug#11063)
3331
a6b1c7cc
EZ
3332 * window.c (Fdelete_other_windows_internal): Invalidate the row
3333 and column information about mouse highlight, so that redisplay
3334 restores it after reallocating the glyph matrices. (Bug#7464)
3335
8427ddd2
EZ
3336 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3337 string comes from a `display' text property, use the buffer
3338 position of that property as if we actually saw that position in
3339 the row's glyphs.
697ba24b
EZ
3340 (move_it_by_lines): Remove the assertion that
3341 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3342 violated when there's a before-string at the beginning of a line.
3343 (Bug#11063)
8427ddd2 3344
65a0a738
EZ
33452012-03-30 Eli Zaretskii <eliz@gnu.org>
3346
3347 * xdisp.c (append_space_for_newline): If the default face was
3348 remapped, use the remapped face for the appended newline.
3349 (extend_face_to_end_of_line): Use the remapped default face for
3350 extending the face to the end of the line.
3351 (display_line): Call extend_face_to_end_of_line when the default
3352 face was remapped. (Bug#11068)
3353
581355cc
EZ
33542012-03-29 Eli Zaretskii <eliz@gnu.org>
3355
3356 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3357
e8fc049f
SM
33582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3359
3360 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3361
4fb9a543
GM
33622012-03-27 Glenn Morris <rgm@gnu.org>
3363
3364 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3365 Doc fixes.
3366
679910f1
KH
33672012-03-26 Kenichi Handa <handa@m17n.org>
3368
3369 * dispextern.h (struct glyph): Fix previous change. Change the
3370 bit length of glyphless.ch to 25 (Bug#11082).
3371
90d49b7f
CY
33722012-03-26 Chong Yidong <cyd@gnu.org>
3373
3374 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3375 (command_loop_1): Use it; inhibit selection update for
3376 handle-select-window too (Bug#8996).
3377
f514f6f0
FP
33782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3379
e8fc049f 3380 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3381
bf43fa51
KH
33822012-03-25 Kenichi Handa <handa@m17n.org>
3383
3384 * dispextern.h (struct glyph): Change the bit length of
3385 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3386
8a0c01dd
EZ
33872012-03-24 Eli Zaretskii <eliz@gnu.org>
3388
3389 * s/ms-w32.h (tzname): Include time.h before redirecting to
3390 _tzname. Fixes the MSVC build. (Bug#9960)
3391
7d1c3a76
AS
33922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3393
8ed79523
AS
3394 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3395 characters.
3396
7d1c3a76
AS
3397 * xterm.c (XTread_socket): Only modify handling_signal if
3398 !SYNC_INPUT. (Bug#11080)
3399
e99a9b8b
EZ
34002012-03-23 Eli Zaretskii <eliz@gnu.org>
3401
3402 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3403 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3404 when fetching a multibyte character consumes more bytes than
3405 CHAR_BYTES returns, due to unification of CJK characters in
3406 string_char. (Bug#11073)
3407
5063c0e1
TN
34082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3409
3410 * process.c (wait_reading_process_output): Handle pty disconnect
3411 by refraining from sending oneself a SIGCHLD (bug#10933).
3412
9f851fbd
CY
34132012-03-22 Chong Yidong <cyd@gnu.org>
3414
3415 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3416
5063c0e1 3417 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3418 Mark string as coming from a prefix property.
3419 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3420 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3421
fb5b8aca
CY
34222012-03-21 Chong Yidong <cyd@gnu.org>
3423
3424 * xfaces.c (Vface_remapping_alist): Doc fix.
3425
62356a1b
EZ
34262012-03-20 Eli Zaretskii <eliz@gnu.org>
3427
3428 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3429 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3430 Doc fixes.
62356a1b 3431
025de85b
CY
34322012-03-20 Chong Yidong <cyd@gnu.org>
3433
3434 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3435 to reflect default non-nil value of redisplay-dont-pause.
3436
4827f94e
KH
34372012-03-19 Kenichi Handa <handa@m17n.org>
3438
3439 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3440 it fit in a valid range (Bug#11003).
3441
e50a24a2
EZ
34422012-03-18 Eli Zaretskii <eliz@gnu.org>
3443
3444 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3445 that is not from display property, accept the row as a "cursor
3446 row" if one of the string's character has a non-nil `cursor'
3447 property. Fixes cursor positioning when there are newlines in
3448 overlay strings, e.g. in icomplete.el. (Bug#11035)
3449
9af5ed87
PE
34502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3453
d1f55f16
CY
34542012-03-12 Chong Yidong <cyd@gnu.org>
3455
3456 * eval.c (inhibit_lisp_code): Rename from
3457 inhibit_window_configuration_change_hook; move from window.c.
3458
3459 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3460 * window.c (run_window_configuration_change_hook)
3461 (syms_of_window): Callers changed.
3462
66c5eebd
CY
34632012-03-11 Chong Yidong <cyd@gnu.org>
3464
413df973
CY
3465 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3466
66c5eebd
CY
3467 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3468
1de11f56
CY
34692012-03-10 Chong Yidong <cyd@gnu.org>
3470
3471 * frame.c (other_visible_frames): Don't assume the selected frame
3472 is visible (Bug#10955).
3473
cae07000
SM
34742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3475
3476 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3477
89c94350
JD
34782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3479
3480 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3481 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3482 zero (Bug#10954).
3483
999dd333
GM
34842012-03-03 Glenn Morris <rgm@gnu.org>
3485
01a6dcc8 3486 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3487
de0100f2
EZ
34882012-03-02 Eli Zaretskii <eliz@gnu.org>
3489
3490 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3491 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3492 (redisplay_window, next_element_from_string): Fix typos in
3493 comments.
3e441275
EZ
3494 (redisplay_window): Pass to move_it_vertically the margin in
3495 pixels, not in screen lines.
de0100f2 3496
96a72ee9
GM
34972012-03-02 Glenn Morris <rgm@gnu.org>
3498
3499 * buffer.c (buffer-list-update-hook): Doc fix.
3500
312508d7
EZ
35012012-02-29 Eli Zaretskii <eliz@gnu.org>
3502
3503 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3504 push_it before setting up the iterator for the first overlay
3505 string, even if we have an empty string loaded.
3506 (next_overlay_string): If there's an empty string on the iterator
3507 stack, pop the stack. (Bug#10903)
3508
27f3c637
PE
35092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3510
3511 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3512 Suggested by Stefan Monnier in
3513 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3514 * alloc.c (widen_to_Lisp_Object): New static function.
3515 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3516 and widening them to Lisp_Objects. This would work even if
3517 USE_LSB_TAG is defined and wide integers are used, which might
3518 happen in a future version of Emacs.
3519
3c9dfce6
CY
35202012-02-25 Chong Yidong <cyd@gnu.org>
3521
fa74b241
CY
3522 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3523 Doc fix.
3524
3c9dfce6
CY
3525 * xselect.c (Fx_selection_exists_p): Doc fix.
3526 (x_clipboard_manager_save_all): Print an informative message
3527 before saving to clipboard manager.
3528
9486df08
CY
35292012-02-24 Chong Yidong <cyd@gnu.org>
3530
3531 * keyboard.c (process_special_events): Handle all X selection
3532 requests in kbd_buffer, not just the next one (Bug#8869).
3533
f01d3321
CY
35342012-02-23 Chong Yidong <cyd@gnu.org>
3535
3536 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3537 call when setting menu-bar-lines and tool-bar-lines parameters.
3538 (unwind_create_frame_1): New helper function.
3539
3540 * window.c (inhibit_window_configuration_change_hook): New var.
3541 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3542 (syms_of_window): Initialize it.
f01d3321 3543
86b847b6
CY
35442012-02-22 Chong Yidong <cyd@gnu.org>
3545
3546 * xterm.c (x_draw_image_relief): Add missing type check for
3547 Vtool_bar_button_margin (Bug#10743).
3548
a59225b1
CY
35492012-02-21 Chong Yidong <cyd@gnu.org>
3550
3551 * fileio.c (Vfile_name_handler_alist): Doc fix.
3552
3553 * buffer.c (Fget_file_buffer): Protect against invalid file
3554 handler return value.
3555
310f5bd4
PE
35562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3557
cb3a28cc
PE
3558 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3559 when computing $valmask.
3560
310f5bd4
PE
3561 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3562 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3563 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3564 It's useless in that case, and it can cause problems on hosts
3565 that allocate halves of EMACS_INT values separately.
3566 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3567 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3568 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3569 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3570 it avoids undefined behavior on hosts where shifting right by more
3571 than the word width has undefined behavior.
3572
2375c96a
CY
35732012-02-19 Chong Yidong <cyd@gnu.org>
3574
3575 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3576 (Funhandled_file_name_directory, Ffile_name_as_directory)
3577 (Fdirectory_file_name, Fexpand_file_name)
3578 (Fsubstitute_in_file_name): Protect against invalid file handler
3579 return values (Bug#10845).
3580
3eb49e71
EZ
35812012-02-18 Eli Zaretskii <eliz@gnu.org>
3582
3583 * .gdbinit (pitx): Fix incorrect references to fields of the
3584 iterator stack.
3585
7b926f3f
CY
35862012-02-17 Chong Yidong <cyd@gnu.org>
3587
3588 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3589
11273115
PE
35902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3593 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3594
c3a70e2b
CY
35952012-02-15 Chong Yidong <cyd@gnu.org>
3596
3597 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3598 marked as special. Also, starting docstrings with * is obsolete.
3599
0ca43699
AS
36002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3601
3602 * gnutls.c (emacs_gnutls_write): Fix last change.
3603
2e8f3c56
LI
36042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3605
3606 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3607 send_process.
3608
af70074f
SM
36092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3610
3611 * keymap.c (Fsingle_key_description): Handle char ranges.
3612
95986d52
CY
36132012-02-12 Chong Yidong <cyd@gnu.org>
3614
afd83bd1
CY
3615 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3616 as that creates a dangerous corner case.
3617
95986d52
CY
3618 * window.c (Fdelete_window_internal): Invalidate the mouse
3619 highlight (Bug#9904).
3620
bd7da63e
GM
36212012-02-12 Glenn Morris <rgm@gnu.org>
3622
3623 * xselect.c (Fx_own_selection_internal)
3624 (Fx_get_selection_internal, Fx_disown_selection_internal)
3625 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3626 * nsselect.m (Fx_own_selection_internal)
3627 (Fx_disown_selection_internal, Fx_selection_exists_p)
3628 (Fx_selection_owner_p, Fx_get_selection_internal):
3629 Sync docs and argument specs with the xselect.c versions.
3630
77abcbc2
LI
36312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3632
3633 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3634
90b671e2
EZ
36352012-02-11 Eli Zaretskii <eliz@gnu.org>
3636
1c0ca0b7
EZ
3637 * w32select.c (Fx_selection_exists_p): Sync doc string and
3638 argument list with xselect.c. (Bug#10783)
3639
3640 * w16select.c (Fx_selection_exists_p): Sync doc string and
3641 argument list with xselect.c. (Bug#10783)
90b671e2 3642
49241268
GM
36432012-02-10 Glenn Morris <rgm@gnu.org>
3644
3645 * fns.c (Fsecure_hash): Doc fix.
3646
f998bbe7 36472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3648
3649 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3650
0992bd9c
CY
36512012-02-07 Chong Yidong <cyd@gnu.org>
3652
3653 * buffer.c (Fbuffer_local_variables)
3654 (buffer_lisp_local_variables): Handle unbound vars correctly;
3655 don't let Qunbound leak into Lisp.
3656
af008560
GM
36572012-02-07 Glenn Morris <rgm@gnu.org>
3658
dd605cc4
GM
3659 * image.c (Fimagemagick_types): Doc fix.
3660
af008560
GM
3661 * image.c (imagemagick-render-type): Change it from a lisp object
3662 to an integer. Move the doc here from the lisp manual.
3663 Treat all values not equal to 0 the same.
3664
1449fa1d
CY
36652012-02-06 Chong Yidong <cyd@gnu.org>
3666
3667 * doc.c (store_function_docstring): Avoid applying docstring of
3668 alias to base function (Bug#2603).
3669
3723ec07
AS
36702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3671
3672 * .gdbinit (pp1, pv1): Remove redundant defines.
3673 (pr): Use pp.
3674
79c1cc1e
CY
36752012-02-04 Chong Yidong <cyd@gnu.org>
3676
3677 * nsterm.m: Declare a global (Bug#10694).
3678
d7f29f8e
EZ
36792012-02-04 Eli Zaretskii <eliz@gnu.org>
3680
cae07000
SM
3681 * w32.c (get_emacs_configuration_options):
3682 Include --enable-checking, if specified, in the return value.
d7f29f8e 3683
3b95a6f9
MR
36842012-02-04 Martin Rudalics <rudalics@gmx.at>
3685
3686 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3687 after rounding frame sizes. (Bug#9723)
3688
d6fa96a6
EZ
36892012-02-04 Eli Zaretskii <eliz@gnu.org>
3690
3691 * keyboard.c (adjust_point_for_property): Don't position point
3692 before BEGV. (Bug#10696)
3693
df0b2940
PE
36942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 Handle overflow when computing char display width (Bug#9496).
3697 * character.c (char_width): Return EMACS_INT, not int.
3698 (char_width, c_string_width): Check for overflow when
3699 computing the width; this is possible now that individual
3700 characters can have unbounded width. Problem introduced
3701 by merge from Emacs 23 on 2012-01-19.
3702
6bee44d6
MA
37032012-02-02 Michael Albinus <michael.albinus@gmx.de>
3704
3705 * dbusbind.c (Fdbus_register_method): Mention the return value
3706 :ignore in the docstring.
3707
44f92739
GM
37082012-02-02 Glenn Morris <rgm@gnu.org>
3709
1b9f60cc
GM
3710 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3711
44f92739
GM
3712 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3713 Unconditionally set to t. (Bug#10673)
3714 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3715 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3716 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3717
c5d3843c
KH
37182012-02-02 Kenichi Handa <handa@m17n.org>
3719
3720 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3721 0, do not call append_composite_glyph.
3722
159462d4 37232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3724
3725 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3726 NULL (Bug#6988).
3727 (x_produce_glyphs): If the component of a composition is a null
3728 string, set it->pixel_width to 1 to avoid zero-width glyph.
3729
78cef877
EZ
37302012-02-01 Eli Zaretskii <eliz@gnu.org>
3731
3732 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3733 first 2 arguments are identical. This makes inserting large
3734 output from a subprocess an order of magnitude faster on
3735 MS-Windows, where all sbrk'ed memory is always contiguous.
3736
97897668
GM
37372012-01-31 Glenn Morris <rgm@gnu.org>
3738
3739 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3740 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3741 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3742
31fd3586
GM
37432012-01-29 Glenn Morris <rgm@gnu.org>
3744
3745 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3746
0e24a8b2
CY
37472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3748
3749 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3750
cc0adcb0
CY
37512012-01-28 Chong Yidong <cyd@gnu.org>
3752
3753 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3754
acc28cb9
CY
37552012-01-26 Chong Yidong <cyd@gnu.org>
3756
9c69cfb7
CY
3757 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3758
acc28cb9
CY
3759 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3760 repeat counts (Bug#10507).
3761
48da7392
GM
37622012-01-26 Glenn Morris <rgm@gnu.org>
3763
3764 * lread.c (syms_of_lread): Doc fix.
3765
14af5f7f
CY
37662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3767
3768 * coding.c (encode_designation_at_bol): Change return value to
3769 EMACS_INT.
3770
0b21c100
CY
37712012-01-25 Chong Yidong <cyd@gnu.org>
3772
3773 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3774
3c2907f7
CY
37752012-01-21 Chong Yidong <cyd@gnu.org>
3776
3777 * floatfns.c (Fcopysign): Make the second argument non-optional,
3778 since nil is not allowed anyway.
3779
959ad23f
AS
37802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3781
3782 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3783 (send_process): Likewise.
3784
34a02f46
MR
37852012-01-19 Martin Rudalics <rudalics@gmx.at>
3786
3787 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3788 (Vwindow_persistent_parameters): Do not use Qstate.
3789 Rewrite doc-strings.
34a02f46 3790
1259009a 37912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3792
3793 * character.c (char_width): New function.
70d4fdf6
GM
3794 (Fchar_width, c_string_width, lisp_string_width):
3795 Use char_width (Bug#9496).
25ed9e61 3796
6a6ee00d
MR
37972012-01-16 Martin Rudalics <rudalics@gmx.at>
3798
3799 * window.c (Vwindow_persistent_parameters): New variable.
3800 (Fset_window_configuration, save_window_save): Handle persistent
3801 window parameters.
3802
c85efaf7
EZ
38032012-01-14 Eli Zaretskii <eliz@gnu.org>
3804
3805 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3806 thrashing the stack of the thread. (Bug#9087)
3807
5944709e
PE
38082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3809
3810 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3811
e71f5d99
EZ
38122012-01-11 Eli Zaretskii <eliz@gnu.org>
3813
3814 * xdisp.c (rows_from_pos_range): Handle the case where the
3815 highlight ends on a newline. (Bug#10464)
3816 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3817 he end column for display of highlight that ends on a newline
3818 before a R2L line.
3819
ce316182
GM
38202012-01-11 Glenn Morris <rgm@gnu.org>
3821
3822 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3823 from load-path also when installation-directory is nil. (Bug#10208)
3824
5b43da69
GM
38252012-01-10 Glenn Morris <rgm@gnu.org>
3826
74cc8ff9
GM
3827 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3828
7d8d6e4e
GM
3829 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3830 Update template values to be closer to their typical values these days.
5b43da69 3831
a0db8d43
EZ
38322012-01-09 Eli Zaretskii <eliz@gnu.org>
3833
3834 * xdisp.c (rows_from_pos_range): Accept additional argument
3835 DISP_STRING, and accept any glyph in a row whose object is that
3836 string as eligible for mouse highlight. Fixes mouse highlight of
3837 display strings from overlays. (Bug#10464)
3838
9a0115ab 38392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3840
b9110d6a 3841 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3842 * fileio.c (auto_saving_dir_umask): New static var.
3843 (Fmake_directory_internal): Use it.
3844 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3845 creating the directory. The old code temporarily assigns
3846 too-generous permissions to the directory.
3847 (do_auto_save_eh): Clear it.
b9110d6a 3848 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3849 that the var is always cleared.
3850
6c1bd3f3
EZ
38512012-01-07 Eli Zaretskii <eliz@gnu.org>
3852
3853 * search.c (scan_buffer): Pass character positions to
3854 know_region_cache, not byte positions. (Bug#6540)
3855
069d2b50
L
38562012-01-07 LynX <_LynX@bk.ru> (tiny change)
3857
3858 * w32.c (sys_rename): Report EXDEV when rename of a directory
3859 fails because the target is on another logical disk. (Bug#10284)
3860
75bf0d33
DB
38612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3862
3863 * xterm.c (x_embed_request_focus): New function.
3864
3865 * xterm.h: Add prototype.
3866
3867 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3868
1c6e5a32
GM
38692012-01-05 Glenn Morris <rgm@gnu.org>
3870
3871 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3872
651e947e
EZ
38732012-01-01 Eli Zaretskii <eliz@gnu.org>
3874
3875 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3876 Load gnutls_transport_set_lowat only if GnuTLS version is below
3877 2.11.1.
3878 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3879 GnuTLS versions below 2.11.1.
3880
3778cdd8
AL
38812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3882
3883 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3884 to the doc string advising against its use for altering the way
3885 windows are scrolled.
3886
0e5317f7
KH
38872011-12-28 Kenichi Handa <handa@m17n.org>
3888
3889 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3890 coding-system ASCII compatible only when it does not produce BOM
3891 on encoding (Bug#10383).
3892
93d5ca1f
JD
38932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3894
3895 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3896 can scroll.
3897 (create_and_show_popup_menu): Always use menu_position_func for
3898 Gtk3 (Bug#10361).
3899
ca22b785
AS
39002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3901
3902 * callint.c (Fcall_interactively): Don't truncate prompt string.
3903
d048e1e6
EZ
39042011-12-23 Eli Zaretskii <eliz@gnu.org>
3905
3906 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3907 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3908 resumed from there (after widening). (Bug#10360)
d048e1e6 3909
5ccaba1f
JD
39102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3911
3912 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3913
204ee57f
JD
39142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3915
b81d40f0
JB
3916 * nsterm.m (x_free_frame_resources):
3917 Release f->output_data.ns->miniimage.
204ee57f
JD
3918 (ns_index_color): Fix indentation. Do not retain
3919 color_table->colors[i].
3920
3921 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3922 before returning.
3923
3924 * nsfns.m (x_set_background_color): Assign return value from
3925 ns_index_color to face-background instead of NSColor*.
3926 (ns_implicitly_set_icon_type): Fix indentation.
3927 Change assignment in for loop to comparison.
3928
3929 * emacs.c (ns_pool): New variable.
3930 (main): Assign ns_pool.
3931 (Fkill_emacs): Call ns_release_autorelease_pool.
3932
3933 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3934 autorelease fdesc, release fdAttrs and tdict.
3935 (ns_get_covering_families): Release charset.
3936 (ns_findfonts): Release NSFontDescriptor created with new.
3937 (ns_uni_to_glyphs): Fix indentation.
3938 (setString): Release attrStr before assigning new value.
3939
c803b2b7
JD
39402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3941
678f4426
JD
3942 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3943 and NS_IMPL_COCOA.
3944 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3945 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3946
cd394be1 39472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3948
5fecd5fc
JD
3949 * nsterm.m (ns_term_init): Subscribe for notifications
3950 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3951 to method trackingNotification in EmacsMenu.
3952
3953 * nsmenu.m (trackingMenu): New variable.
3771cb17 3954 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3955 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3956 from Aquamacs (Bug#7030).
678f4426
JD
3957
39582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3959
c803b2b7
JD
3960 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3961 (symbol_to_nsstring): Fix indentation.
3962 (ns_symbol_to_pb): New function.
cae07000
SM
3963 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3964 (Fns_rotate_cut_buffers_internal): Remove.
3965 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3966 Fns_store_cut_buffer_internal.
3967 (ns_get_foreign_selection, Fx_own_selection_internal)
3968 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3969 (Fns_get_selection_internal, Fns_store_selection_internal):
3970 Use ns_symbol_to_pb and check if return value is nil.
3971 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3972 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3973 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3974 renamed to Sns_store_selection_internal.
3975 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3976 and remove this function.
3977 (ns_handle_selection_clear): Remove, never used.
3978 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3979 here.
3980
e1b01a3a
KB
39812011-12-17 Ken Brown <kbrown@cornell.edu>
3982
3983 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3984 GID is unknown (Bug#10257).
3985
2adb6e85
PE
39862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3989 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3990 which caused a build failure on GNU/Linux IA-64. This problem was
3991 introduced by my 2011-10-07 patch.
3992
d1d7b339
JL
39932011-12-15 Juri Linkov <juri@jurta.org>
3994
3995 * image.c (imagemagick_error): New function. (Bug#10112)
3996 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3997 Use `imagemagick_error' where ImageMagick functions return
3998 `MagickFalse'.
3999 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4000 proper order.
4001
100d5755
KH
40022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4003
4004 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4005 fill background (Bug#8992).
4006
454592a6
MR
40072011-12-13 Martin Rudalics <rudalics@gmx.at>
4008
4009 * window.c (Vwindow_combination_resize)
4010 (Vwindow_combination_limit): Use t instead of non-nil in
4011 doc-strings.
61d4b438
MR
4012 (Vrecenter_redisplay): Add first sentence of doc-string on
4013 separate line.
53524d93 4014 (Frecenter): Fix doc-string typo.
454592a6 4015
3633e3aa
KH
40162011-12-11 Kenichi Handa <handa@m17n.org>
4017
4018 * coding.c (Funencodable_char_position): Pay attention to the
4019 buffer text relocation (Bug#9389).
4020
7b9d523a 40212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4022
7b9d523a
JD
4023 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4024 gtk_init (Bug#10100).
4025
b73189c6
EZ
40262011-12-10 Eli Zaretskii <eliz@gnu.org>
4027
4028 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4029 IT->string is nil. (Bug#10263)
4030
f7dfe5d6
JD
40312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4032
83faebb4
JD
4033 * nsterm.h (x_free_frame_resources): Declare.
4034
f7dfe5d6
JD
4035 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4036 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4037
4038 * nsterm.h (ns_get_defaults_value): Declare.
4039
4040 * nsterm.m (ns_default): Call ns_get_defaults_value.
4041
7cd4e72c
EZ
40422011-12-09 Eli Zaretskii <eliz@gnu.org>
4043
4044 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4045 (Bug#10170)
4046
b34d7317
YM
40472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4048
4049 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4050 that where the value of an _OBJC_* symbol points to is in the .bss
4051 section (Bug#10240).
4052
76470ad1
KH
40532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4054
4055 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4056 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4057
745fff94
KH
40582011-12-08 Kenichi Handa <handa@m17n.org>
4059
4060 * ftfont.c (get_adstyle_property): Fix previous change
4061 (Bug#10233).
4062
6e44397c
JB
40632011-12-07 Juanma Barranquero <lekktu@gmail.com>
4064
4065 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4066 dirs from the default value of EMACSLOADPATH (bug#10208).
4067
7efa6272
GM
40682011-12-07 Glenn Morris <rgm@gnu.org>
4069
4070 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4071 installation and source directories as well. (Bug#10208)
4072
f6fc4d87
CY
40732011-12-06 Chong Yidong <cyd@gnu.org>
4074
4075 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4076
2bf26180
GM
40772011-12-06 Glenn Morris <rgm@gnu.org>
4078
4079 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4080 as an error, not just -1. (Bug#10217)
4081
3a6ad4f0
CY
40822011-12-05 Chong Yidong <cyd@gnu.org>
4083
4084 * keyboard.c (process_special_events): New function.
4085 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4086
75a3b399
PE
40872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 * coding.c (encode_designation_at_bol): Don't use uninitialized
4090 local variable (Bug#9318).
4091
c3c9e25e
KH
40922011-12-05 Kenichi Handa <handa@m17n.org>
4093
4094 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4095 return Qnil (Bug#8046, Bug#10193).
4096
5eb05ea3
KH
40972011-12-05 Kenichi Handa <handa@m17n.org>
4098
4099 * coding.c (encode_designation_at_bol): New args charbuf_end and
4100 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4101 (coding_set_source): Return how many bytes coding->source was
4102 relocated.
4103 (coding_set_destination): Return how many bytes
4104 coding->destination was relocated.
4105 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4106 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4107
41082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4109
4110 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4111 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4112 macro (Bug#9318).
4113
41142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 The following changes are to fix Bug#9318.
4117
a79703f5 4118 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4119 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4120 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4121 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4122
7dbda6df
JB
41232011-12-05 Juanma Barranquero <lekktu@gmail.com>
4124
4125 * lisp.h (process_quit_flag): Fix external declaration.
4126
6d5eb5b0
SM
41272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4128
4129 Don't macro-inline non-performance-critical code.
4130 * eval.c (process_quit_flag): New function.
4131 * lisp.h (QUIT): Use it.
4132
a0c3fad0
JD
41332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4134
4135 * nsfns.m (get_geometry_from_preferences): New function.
4136 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4137
6c07aac2
AS
41382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4139
4140 * emacs.c (Qkill_emacs): Define.
4141 (syms_of_emacs): Initialize it.
4142 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4143 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4144 (quit_throw_to_read_char): Add parameter `from_signal'.
4145 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4146 * lisp.h (QUIT): Call Fkill_emacs if requested.
4147
c052ead4
JD
41482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4149
4150 * widget.c (update_wm_hints): Return if wmshell is null.
4151 (widget_update_wm_size_hints): New function.
4152
4153 * widget.h (widget_update_wm_size_hints): Declare.
4154
4155 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4156 widget_update_wm_size_hints (Bug#10104).
4157
9e49252b
EZ
41582011-12-03 Eli Zaretskii <eliz@gnu.org>
4159
4160 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4161 before a newline, prepare the bidi iterator for consuming the
4162 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4163 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4164
02b16839
JL
41652011-12-02 Juri Linkov <juri@jurta.org>
4166
4167 * search.c (Fword_search_regexp): New Lisp function created from
4168 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4169 (Fword_search_backward, Fword_search_forward)
4170 (Fword_search_backward_lax, Fword_search_forward_lax):
4171 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4172 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4173
0068070e
SM
41742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4175
4176 * fileio.c (Finsert_file_contents): Move after-change-function call
4177 to before the "handled:" label, since all "goto handled" appear in
4178 cases where the *-change-functions have already been properly called
4179 (bug#10117).
4180
3360a3fc
AS
41812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4182
4183 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4184 waiting for input. (Bug#10169)
4185
73d6c093
EZ
41862011-11-30 Eli Zaretskii <eliz@gnu.org>
4187
4188 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4189 verifies glyph row's hash code--we have just reallocated the
4190 glyphs, so their contents can be complete garbage. (Bug#10164)
4191
febe6bea
JB
41922011-11-30 Juanma Barranquero <lekktu@gmail.com>
4193
4194 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4195
801a4313
EZ
41962011-11-30 Eli Zaretskii <eliz@gnu.org>
4197
4198 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4199 attributes are tested _before_ calling verify_row_hash, to protect
4200 against GCC re-ordering of the tests. (Bug#10164)
4201
2b56b87e
JD
42022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4203
4204 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4205
4206 * xterm.c (handle_one_xevent): Only set async_visible and friends
4207 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4208 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4209 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4210
dbf31225
PE
42112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4214 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4215 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4216 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4217 All uses changed to use GCPRO1 etc.
4218 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4219 Revert to old implementation (i.e., before 2011-03-11).
4220
1305621b
YM
42212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4222
4223 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4224 of scroll runs so as to avoid assigning disabled bogus rows and
4225 unnecessary graphics copy operations.
4226
8c9afb46
EZ
42272011-11-27 Eli Zaretskii <eliz@gnu.org>
4228
4229 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4230 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4231 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4232 (malloc, free, realloc, calloc): Redirect to e_* only when
4233 compiling Emacs.
4234
4235 * lisp.h (GCTYPEBITS): Move before first use.
4236 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4237 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4238 this macro definition.
4239
4240 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4241 _MSC_VER.
4242
54e9e3bf
JD
42432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4244
6d5eb5b0
SM
4245 * gtkutil.c (xg_create_frame_widgets):
4246 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4247 present with Gtk+ 2.0.
4248
83aca1cb
PE
42492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * fileio.c (Finsert_file_contents): Undo previous change; see
4252 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4253
5b76caa4
PE
42542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4255
4256 Rename locals to avoid shadowing.
4257 * fileio.c (Finsert_file_contents):
4258 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4259 * process.c (wait_reading_process_output):
4260 Rename inner 'proc' to 'p' to avoid shadowing.
4261 Indent for consistency with usual Emacs style.
4262
8c535114
EZ
42632011-11-25 Eli Zaretskii <eliz@gnu.org>
4264
4265 * xdisp.c (redisplay_window): If cursor row is not fully visible
4266 after recentering, and scroll-conservatively is set to a large
4267 number, scroll window by a few more lines to make the cursor fully
4268 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4269 (start_display): Don't move to the next line if the display should
4270 start at a newline that is part of a display vector or an overlay
4271 string. (Bug#10119)
8c535114 4272
fa4fdb5c
JL
42732011-11-24 Juri Linkov <juri@jurta.org>
4274
4275 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4276 after the `MagickPingImage' call. (Bug#10112)
4277
90ec88df
CY
42782011-11-23 Chong Yidong <cyd@gnu.org>
4279
4280 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4281
56e2e794
MR
42822011-11-23 Martin Rudalics <rudalics@gmx.at>
4283
4284 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4285 making another buffer current. (Bug#10114)
4286
b6e64c41
GM
42872011-11-23 Glenn Morris <rgm@gnu.org>
4288
4289 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4290
6b21de18
CY
42912011-11-23 Chong Yidong <cyd@gnu.org>
4292
4293 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4294 using it (Bug#5984).
4295
b12cd789
EZ
42962011-11-22 Eli Zaretskii <eliz@gnu.org>
4297
4298 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4299 and header-lines, as they don't have one computed for them.
4300 (Bug#10098)
4301
4302 * .gdbinit (prow): Make displayed values more self-explaining.
4303 Add row's hash code.
4304
261b6fd4
LMI
43052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4306
4307 * process.c (wait_reading_process_output): Fix asynchrounous
4308 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4309 (wait_reading_process_output): Add comment and URL.
261b6fd4 4310
e7cfd277
JD
43112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4312
4313 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4314
a9b9b7f5
CY
43152011-11-21 Chong Yidong <cyd@gnu.org>
4316
4317 * window.c (Fnext_window, Fprevious_window): Doc fix.
4318
b0d15b4f
SM
43192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4320
4321 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4322
fe7a3057
JB
43232011-11-20 Juanma Barranquero <lekktu@gmail.com>
4324
4325 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4326
d2999b1a
MR
43272011-11-20 Martin Rudalics <rudalics@gmx.at>
4328
4329 * window.c (Fset_window_combination_limit): Rename argument
4330 STATUS to LIMIT.
4331 (Vwindow_combination_limit): Remove "status" from doc-string.
4332
d5ff9cd0
AS
43332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4334
4335 * m/ibms390.h: Remove.
4336 * m/ibms390x.h: Don't include "ibms390.h".
4337
a5bb9bd3
SM
43382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4339
4340 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4341 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4342
cd1181db
JB
43432011-11-20 Juanma Barranquero <lekktu@gmail.com>
4344
4345 * casetab.c (Fset_case_table):
4346 * charset.c (Fcharset_after): Fix typos.
4347
615a3b8d 43482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4349
17e845af
PE
4350 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4351 Otherwise, valgrind does not work on some platforms.
4352 Problem reported by Andreas Schwab in
6a0bf43d
PE
4353 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4354 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4355 is set, removing the need for VIRT_ADDRESS_VARIES.
4356 (PURE_P): Use a more-efficient implementation that needs just one
4357 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4358 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4359 to 4 (xorl, subq, cmpq, setbe).
4360 * alloc.c (pure): Always extern now, since that's the
4361 VIRT_ADDR_VARIES behavior.
4362 (PURE_POINTER_P): Use a single comparison, not two, for
4363 consistency with the new puresize.h.
4364 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4365 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4366 Remove VIRT_ADDR_VARIES no longer needed.
4367
f8fe6f96
EZ
43682011-11-19 Eli Zaretskii <eliz@gnu.org>
4369
4370 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4371 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4372 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4373 behave as if the cursor position were at the window margin.
4374
4375 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4376 and the cursor position is out of bounds, behave as if the cursor
4377 position were at the window margin. (Bug#10075)
4378
df05a53c
CY
43792011-11-18 Chong Yidong <cyd@gnu.org>
4380
4381 * window.c (Fwindow_combination_limit): Make first argument
4382 non-optional, since it is meaningless for live windows like the
4383 selected window.
61ccba97 4384
2071918e
DA
43852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4386
4387 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4388
b50a28de
SM
43892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4390
4391 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4392 (graft_intervals_into_buffer): Simplify.
4393
015137db
EZ
43942011-11-18 Eli Zaretskii <eliz@gnu.org>
4395
4396 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4397 hash values of the two rows.
4398 (copy_row_except_pointers): Preserve the used[] arrays and the
4399 hash values of the two rows. (Bug#10035)
68c95424 4400 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4401
4402 * xdisp.c (row_hash): New function, body extracted from
4403 compute_line_metrics.
4404 (compute_line_metrics): Call row_hash, instead of computing the
4405 hash code inline.
4406
4407 * dispnew.c (verify_row_hash): Call row_hash for computing the
4408 hash code of a row, instead of duplicating code from xdisp.c.
4409
4410 * dispextern.h (row_hash): Add prototype.
4411
a2addb04
TH
44122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4413
4414 * frame.c (delete_frame): Don't delete the terminal when the last
4415 X frame is closed if emacs is built with GTK toolkit.
4416
df85d315
JB
44172011-11-17 Juanma Barranquero <lekktu@gmail.com>
4418
4419 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4420
a0c2d0ae
MR
44212011-11-17 Martin Rudalics <rudalics@gmx.at>
4422
4423 * window.c (Vwindow_splits): Rename to
4424 Vwindow_combination_resize. Suggested by Juri Linkov.
4425 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4426 of Vwindow_splits.
4427
58179cce
JB
44282011-11-16 Juanma Barranquero <lekktu@gmail.com>
4429
7877f373
JB
4430 * nsfns.m (Fns_font_name):
4431 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4432
b6f67890
MR
44332011-11-16 Martin Rudalics <rudalics@gmx.at>
4434
4435 * window.h (window): Rename slot "nest" to "combination_limit".
4436 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4437 (Fset_window_nest): Rename to Fset_window_combination_limit.
4438 (Vwindow_nest): Rename to Vwindow_combination_limit.
4439 (recombine_windows, make_parent_window, make_window)
4440 (Fsplit_window_internal, saved_window)
4441 (Fset_window_configuration, save_window_save): Rename all
4442 occurrences of window_nest to window_combination_limit.
4443
c7015153
JB
44442011-11-15 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * image.c (imagemagick_load_image): Fix typo.
4447
322ad6ec
EZ
44482011-11-14 Eli Zaretskii <eliz@gnu.org>
4449
4450 * xdisp.c (display_line): Move the call to
4451 highlight_trailing_whitespace before the call to
4452 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4453 faces of all the glyphs to compute ROW's hash value.
4454 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4455
f067b8ec
JB
44562011-11-14 Juanma Barranquero <lekktu@gmail.com>
4457
4458 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4459 just return (bug#10044).
4460
1e5b2111
EZ
44612011-11-12 Eli Zaretskii <eliz@gnu.org>
4462
7ef3cbd5
EZ
4463 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4464 with user-defined heap size. Bump the default size of the temacs
4465 heap to 27MB, to avoid memory warning when running temacs.
4466 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4467
1e5b2111
EZ
4468 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4469 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4470 (verify_row_hash) [XASSERTS]: New function.
4471 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4472 that the hash value of glyph rows is correct.
1e5b2111 4473
89d61221
MR
44742011-11-12 Martin Rudalics <rudalics@gmx.at>
4475
4476 * window.h (window): Remove splits slot.
4477 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4478 (Fdelete_other_windows_internal, make_parent_window)
4479 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4480 (Fset_window_configuration, save_window_save): Don't deal with
4481 split status of windows.
4482 (saved_window): Remove splits slot.
4483 (Vwindow_splits): Rewrite doc-string.
4484
97f18cc8
JD
44852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4486
4487 * xfns.c (unwind_create_frame):
4488 * nsfns.m (unwind_create_frame):
4489 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4490 Vframe_list (Bug#9999).
4491
22a648b4
DA
44922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4493
0b381c7e 4494 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4495
659afede
KH
44962011-11-11 Kenichi Handa <handa@m17n.org>
4497
4498 * callproc.c (Fcall_process): Set the member dst_multibyte of
4499 process_coding.
4500
9ac0394b
KH
45012011-11-11 Johan Bockgård <bojohan@gnu.org>
4502
4503 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4504 avoid a crash (bug#9496).
4505
2fbdc249
CY
45062011-11-09 Chong Yidong <cyd@gnu.org>
4507
4508 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4509 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4510
ac6b1f81
PE
45112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4512
4513 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4514
09db192c
PE
45152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4516
4517 Avoid some portability problems by eschewing 'extern inline' functions.
4518 The trivial performance wins aren't worth the portability hassles; see
4519 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4520 et seq.
4521 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4522 (window_box_width, window_box_left, window_box_left_offset)
4523 (window_box_right, window_box_right_offset): Undo previous change,
4524 by removing the "extern"s.
4525 * intervals.c (adjust_intervals_for_insertion)
4526 (adjust_intervals_for_deletion): Undo previous change,
4527 making these static again.
4528 (offset_intervals, temp_set_point_both, temp_set_point)
4529 (copy_intervals_to_string): No longer inline.
4530 * xdisp.c (window_text_bottom_y, window_box_width)
4531 (window_box_height, window_box_left_offset)
4532 (window_box_right_offset, window_box_left, window_box_right)
4533 (window_box): No longer inline.
4534
105216ed
CY
45352011-11-08 Chong Yidong <cyd@gnu.org>
4536
4537 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4538 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4539 Signal an error if not a live window.
105216ed
CY
4540 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4541 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4542
ae9e237f
JB
45432011-11-07 Juanma Barranquero <lekktu@gmail.com>
4544
4545 * lisp.h (syms_of_abbrev): Remove declaration.
4546 Reported by CHENG Gao <chenggao@royau.me>.
4547
c7aa8333
EZ
45482011-11-07 Eli Zaretskii <eliz@gnu.org>
4549
4550 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4551 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4552 of temacs in GUI mode.
4553
be7f5545
MR
45542011-11-07 Martin Rudalics <rudalics@gmx.at>
4555
4556 * window.h: Declare delete_all_child_windows instead of
4557 delete_all_subwindows.
4558 * window.c (Fwindow_nest, Fset_window_nest)
4559 (Fset_window_new_total, Fset_window_new_normal)
4560 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4561 (delete_all_subwindows): Rename to delete_all_child_windows.
4562 (Fdelete_other_windows_internal, Fset_window_configuration):
4563 Call delete_all_child_windows instead of delete_all_subwindows.
4564 * frame.c (delete_frame): Call delete_all_child_windows instead
4565 of delete_all_subwindows.
4566
ca78dc43
PE
45672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4570 This is also needed for porting to any host where GC_MARK_STACK is
4571 not GC_MAKE_GCPROS_NOOPS.
4572 (which_symbols): Use it.
4573
a0241d01
KH
45742011-11-07 Kenichi Handa <handa@m17n.org>
4575
4576 * coding.c (coding_set_destination): Check coding->src_pos only
4577 when coding->src_object is a buffer (bug#9910).
4578
4579 * process.c (send_process): Set the member src_multibyte of coding
4580 to 0 (bug#9911) when sending a unibyte text.
4581
4582 * callproc.c (Fcall_process): Set the member src_multibyte of
4583 process_coding to 0 (bug#9912).
4584
a64bfdfa 45852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4586
4587 * xmenu.c (cleanup_widget_value_tree): New function.
4588 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4589 calling free_menubar_widget_value_tree directly (Bug#9830).
4590
cb41b32a
PE
45912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 Fix some portability problems with 'inline'.
4594 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4595 (window_box_width, window_box_left, window_box_left_offset)
4596 (window_box_right, window_box_right_offset): Declare extern.
4597 Otherwise, these inline functions do not conform to C99 and
4598 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4599 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4600 * intervals.c (adjust_intervals_for_insertion)
4601 (adjust_intervals_for_deletion): Now extern, because otherwise the
4602 extern inline functions 'offset_intervals' couldn't refer to it.
4603 (static_offset_intervals): Remove.
4604 (offset_intervals): Rewrite using the old contents of
4605 static_offset_intervals. The old version didn't conform to C99
4606 because an extern inline function contained a reference to an
4607 identifier with static linkage.
4608
b7041366
AS
46092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4610
4611 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4612 GC.
4613
88a37c4d
EZ
46142011-11-06 Eli Zaretskii <eliz@gnu.org>
4615
4616 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4617 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4618 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4619 return Qleft_to_right.
4620
49745b39
CY
46212011-11-06 Chong Yidong <cyd@gnu.org>
4622
4623 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4624 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4625 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4626 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4627 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4628 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4629 (Fwindow_vscroll): Doc fix.
4630 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4631 argument, since it makes no sense to pass a live window and for
4632 consistency with window-child.
4633
1f05cd82
CS
46342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4635
4636 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4637 support MSVC.
4638
22610910
JR
46392011-11-05 Jason Rumney <jasonr@gnu.org>
4640
4641 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4642 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4643 fonts (Bug#6029).
4644 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4645 bitwise arithmetic preventing use of unicode-sip and non-truetype
4646 opentype fonts.
4647
a06776b2
EZ
46482011-11-05 Eli Zaretskii <eliz@gnu.org>
4649
3ad924ba
EZ
4650 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4651 "emacs"-only part.
4652
a06776b2
EZ
4653 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4654 initialization code to keep similarity to xfns.c after changes
4655 from 2011-11-05.
4656
c9e7db78
JD
46572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4658
a97f8f3f
JD
4659 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4660 (unwind_create_frame): New function (Bug#9943).
4661 (Fx_create_frame): Restructure code to be more similar to the one in
4662 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4663 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4664 Move terminal->reference_count++ just before making the frame official
4665 (Bug#9943).
4666
4667 * nsterm.m (x_free_frame_resources): New function.
4668 (x_destroy_window): Move code to x_free_frame_resources.
4669
c9e7db78 4670 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4671 (Fx_create_frame, x_create_tip_frame):
4672 Move terminal->reference_count++ just before making the frame
75f1671a 4673 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4674 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4675
a6fc3b5c
EZ
46762011-11-05 Eli Zaretskii <eliz@gnu.org>
4677
4678 Support MSVC build with newer versions of Visual Studio.
4679 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4680 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4681 nt/gmake.defs.
4682
4683 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4684 which are not supported by MSVC.
4685 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4686 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4687 bitfields.
4688 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4689 types in bitfields.
4690 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4691
4692 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4693
58179cce 46942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4695
4696 Support MSVC build with newer versions of Visual Studio.
4697 * w32.c: Don't include w32api.h for MSVC.
4698 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4699
4700 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4701 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4702 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4703 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4704 e_* cousins.
4705 (alloca) [_MSC_VER]: Define to _alloca.
4706
4707 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4708
4709 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4710
a58c13ed
EZ
47112011-11-04 Eli Zaretskii <eliz@gnu.org>
4712
4713 * xdisp.c (note_mouse_highlight): If either of
4714 previous/next-single-property-change returns nil, treat that as
4715 the beginning or the end of the buffer. (Bug#9955)
4716
fe0b6370
JD
47172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4718
a58c13ed 4719 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4720 label is not null (Bug#9951).
4721 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4722 may be NULL.
4723
89bd5ee1
EZ
47242011-11-04 Eli Zaretskii <eliz@gnu.org>
4725
4726 * window.c (Fwindow_body_size): Mention in the doc string that the
4727 return value is in frame's canonical units. (Bug#9949)
4728
84c3edb9
EZ
47292011-11-03 Eli Zaretskii <eliz@gnu.org>
4730
4e2fb5c7
EZ
4731 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4732
84c3edb9 4733 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4734 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4735 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4736
bc17a887
EZ
47372011-11-01 Eli Zaretskii <eliz@gnu.org>
4738
4739 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4740 Don't stop backward scan on the continuation glyph, even though
4741 its CHARPOS is positive.
6d5eb5b0
SM
4742 (mouse_face_from_buffer_pos, note_mouse_highlight):
4743 Rename cover_string to disp_string.
bc17a887 4744
4ee88440
MR
47452011-11-01 Martin Rudalics <rudalics@gmx.at>
4746
4747 * window.c (temp_output_buffer_show): Don't use
4748 Vtemp_buffer_show_specifiers.
4749 (Vtemp_buffer_show_specifiers): Remove unused variable.
4750
c2ff3c02
EZ
47512011-10-30 Eli Zaretskii <eliz@gnu.org>
4752
4753 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4754 past the beginning of the current glyph matrix.
4755
58179cce 47562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4757
4758 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4759 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4760 HAVE_GTK3 (Bug#9869).
b77a6a7f 4761
3b574623
JD
4762 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4763 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4764
b77a6a7f
JD
4765 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4766
4767 * xterm.c: Declare x_handle_net_wm_state to return int.
4768 (handle_one_xevent): Check if we are iconified but don't have
4769 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4770 (get_current_wm_state): Return non-zero if not hidden,
4771 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4772 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4773 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4774 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4775
196e41e4
PE
47762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4777
4778 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4779 so that this new function doesn't get optimized away by a
4780 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4781
021f2e1a
AS
47822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4783
4784 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4785
8b058d44
EZ
47862011-10-29 Eli Zaretskii <eliz@gnu.org>
4787
4788 Fix the `xbytecode' command.
4789 * .gdbinit (xprintbytestr): New command.
b50a28de 4790 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4791 (xbytecode): Print the byte-code string as well.
4792
4452fb80
EZ
47932011-10-29 Kim Storm <storm@cua.dk>
4794
8b058d44
EZ
4795 * alloc.c (which_symbols): New function.
4796
21b72067
AS
47972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4798
4799 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4800 line. (Bug#9903)
4801
83ed7b5c
GM
48022011-10-29 Glenn Morris <rgm@gnu.org>
4803
4804 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4805 Not clear what it was for, and it causes various bugs. (Bug#9839)
4806
5a7a728b
EZ
48072011-10-28 Eli Zaretskii <eliz@gnu.org>
4808
4809 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4810 possible random value that matches one of those tested as
4811 condition to clear the mouse face.
4812
d3d0842f
CY
48132011-10-28 Chong Yidong <cyd@gnu.org>
4814
4815 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4816
31b39d13
DN
48172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4818
4819 * window.c (make_window): Initialize phys_cursor_on_p.
4820
9aba6043
SM
48212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4822
4823 * lisp.h (struct Lisp_Symbol): Update comments.
4824
c20992f4
JB
48252011-10-28 Juanma Barranquero <lekktu@gmail.com>
4826
4827 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4828
db4f02f2
EZ
48292011-10-28 Eli Zaretskii <eliz@gnu.org>
4830
4831 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4832 <oslsachem@gmail.com> for helping to debug this.
4833
4834 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4835 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4836 (g_b_init_get_glyph_outline_w): New static variables.
4837 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4838 (GetGlyphOutlineW_Proc): New typedefs.
4839 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4840 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4841 New functions.
4842 (w32font_open_internal, compute_metrics):
4843 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4844 instead of calling the "wide" APIs directly.
4845
4846 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4847
4848 * w32.h (syms_of_w32font): Add prototype.
4849
87e68db4
JB
48502011-10-27 Juanma Barranquero <lekktu@gmail.com>
4851
4852 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4853 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4854 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4855 (Fmove_to_window_line): Doc fix.
4856
435c1d67
CY
48572011-10-27 Chong Yidong <cyd@gnu.org>
4858
4859 * process.c (make_process): Set gnutls_state to NULL.
4860
4861 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4862 non-NULL, regardless of GNUTLS_INITSTAGE.
4863 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4864 an error. Set process slots as soon as we allocate them.
4865
4866 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4867
9c6c6f49
CY
48682011-10-27 Chong Yidong <cyd@gnu.org>
4869
9aba6043
SM
4870 * gnutls.c (emacs_gnutls_deinit): New function.
4871 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4872 (Fgnutls_deinit, Fgnutls_boot): Use it.
4873
4874 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4875 (deactivate_process): Call emacs_gnutls_deinit.
4876
657d08d3
JB
48772011-10-27 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * image.c (x_create_x_image_and_pixmap):
4880 * w32.c (sys_rename, w32_delayed_load):
4881 * w32font.c (fill_in_logfont):
4882 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4883
5430d399
JB
48842011-10-26 Juanma Barranquero <lekktu@gmail.com>
4885
4886 * w32fns.c (w32_default_color_map): New function,
4887 extracted from Fw32_default_color_map.
a7ef684b 4888 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4889
fe0055fa
PE
48902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4891
4892 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4893
e6346438
SM
48942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4895
4896 * keyboard.c (test_undefined): New function (bug#9751).
4897 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4898
e112cc37
ET
48992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4900
4901 * sysdep.c (init_sys_modes): Fix the check for the controlling
4902 terminal (Bug#6649).
4903
7b5d6677
EZ
49042011-10-20 Eli Zaretskii <eliz@gnu.org>
4905
4906 * dispextern.h (struct bidi_it): New member next_en_type.
4907
4908 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4909 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4910 current character, check also for next_en_type being WEAK_EN.
4911 (bidi_resolve_weak): Don't enter the expensive loop if the current
4912 position is before next_en_pos. Record the bidi type of the first
4913 non-ET, non-BN character we find, in addition to its position.
4914 (bidi_level_of_next_char): Invalidate next_en_type when
4915 next_en_pos is over-stepped.
4916
7da0b018
PE
49172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4918
4919 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4920 * editfns.c: Rewrite current-time-zone so that it invokes
4921 the equivalent of (format-time-string "%Z") to get the time zone name.
4922 This fixes a bug when the time zone name contains characters that
4923 need converting from the system time locale to Emacs internal format.
4924 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4925 that patch fixed format-time-string to do the conversion, but
4926 I forgot to fix current-time-zone.
4927 (format_time_string): New function, containing most of
4928 what Fformat_time_string used to contain.
4929 (Fformat_time_string): Rewrite in terms of format_time_string.
4930 This doesn't change this function's behavior.
4931 (current-time-zone): Rewrite to use format_time_string.
4932 This fixes the bug reported by Michael Schierl in
4933 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4934 Jason Rumney's 2007-06-07 change worked around this bug, but
4935 didn't fix it.
4936 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4937
8547b010
EZ
49382011-10-19 Eli Zaretskii <eliz@gnu.org>
4939
4940 * xdisp.c (start_display): If the character at POS is displayed
4941 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4942 (try_window_reusing_current_matrix): If a line ends in a display
4943 vector or the next line starts in a display vector, continue
4944 redrawing the window even though the character position of
4945 start_row was reached.
8547b010
EZ
4946 (Bug#9771, part 2)
4947
4e948d15
CY
49482011-10-18 Chong Yidong <cyd@gnu.org>
4949
4950 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4951 with nobreak-char-display too.
4952
4787455f
EZ
49532011-10-18 Eli Zaretskii <eliz@gnu.org>
4954
4955 Fix part 3 of bug#9771.
4956 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4957 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4958 non-neutral characters if the current character is a paragraph
4959 separator (a.k.a. Newline). This avoids running the same
4960 expensive loop twice, once when we consume the preceding newline
4961 and the other time when the line actually needs to be displayed.
4962 Avoid the loop when we see neutrals on the base embedding level
4963 following a character whose directionality is the same as the
4964 paragraph's. This avoids running the expensive loop when a line
4965 ends in a long sequence of neutrals, like control characters.
4966 Add assertion against STRONG_AL type. Slightly rearrange code
4967 that determines the type of a neutral given the first non-neutral
4968 that follows it.
4969 (bidi_level_of_next_char): Set next_en_pos to zero when
4970 invalidating its info.
4971
2c91f553
EZ
49722011-10-17 Eli Zaretskii <eliz@gnu.org>
4973
4974 * xdisp.c (push_display_prop): Determine whether to record string
4975 or buffer position by IT->string, not by IT->method. Allow
4976 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4977 (move_it_vertically_backward): Don't look for character position
4978 immediately after the newline when in a continuation line.
4979 (Bug#9771, part 1)
2c91f553 4980
c7b08b0d
MR
49812011-10-15 Martin Rudalics <rudalics@gmx.at>
4982
4983 * window.c (coordinates_in_window): Rewrite and delabelize
4984 vertical border check. (Bug#5357) (Bug#9618)
4985
6b02f655
SM
49862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4987
4988 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4989 errors in XSetWindowBorder (bug#9310).
4990
81d40c92
DA
49912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4992
4993 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4994 avoid crash when xmalloc overrun checking is enabled.
4995
d4172c3b
EZ
49962011-10-13 Eli Zaretskii <eliz@gnu.org>
4997
4998 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4999 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5000 cursor motion with <left> and <right> arrow keys.
5001
5002 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5003 some callers set that themselves.
5004
b00eea75
EZ
50052011-10-12 Eli Zaretskii <eliz@gnu.org>
5006
5007 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5008 display string and the previous row comes from the same string and
5009 is empty. (Bug#9739) (Bug#9738)
5010
8fe012c4
SM
50112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5012
5013 * doc.c (get_doc_string): Encode file name (bug#9735).
5014
0074aef2
EZ
50152011-10-12 Eli Zaretskii <eliz@gnu.org>
5016
79beb178
EZ
5017 * bidi.c (bidi_level_of_next_char):
5018 * xdisp.c (get_visually_first_element): Remove old incorrect
5019 comments regarding the Unicode Line Separator character.
5020
0074aef2
EZ
5021 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5022
6e4b3fbe
DA
50232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5024
5025 * alloc.c (Fgc_status): Do not access beyond zombies array
5026 boundary if nzombies > MAX_ZOMBIES.
5027 * alloc.c (dump_zombies): Add missing format specifier.
5028
0324f3af
PE
50292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5030
b5525cac
PE
5031 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5032 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5033
0324f3af
PE
5034 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5035 Some packages use them to denote characters with modifiers.
5036
e9b5f888
AS
50372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5038
5039 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5040 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5041 matching a pp-number. Rename parameter var to var1.
5042
127827c0
SM
50432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5044
5045 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5046
c8fd3bd0
GM
50472011-10-08 Glenn Morris <rgm@gnu.org>
5048
5049 * callint.c (Fcall_interactively): Give a more explicit error for the
5050 'c' case with a non-character input. (Bug#8479)
5051
352ec8ff
EZ
50522011-10-08 Eli Zaretskii <eliz@gnu.org>
5053
03669ccb
EZ
5054 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5055 lines.
7061c986
EZ
5056 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5057 lines that are hscrolled on the left.
03669ccb 5058
352ec8ff
EZ
5059 * dispnew.c (buffer_posn_from_coords): Account for a possible
5060 presence of header-line. (Bug#4426)
5061
a66cfb1c
SM
50622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5063
6b02f655
SM
5064 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5065 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5066
7c5ee88e
PE
50672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5070 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5071 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5072 this makes Emacs dump core during garbage collection on rare
5073 occasions. sizeof is obviously inferior to offsetof here, so
5074 stick with offsetof.
5075 (GC_POINTER_ALIGNMENT): New macro.
5076 (mark_memory): Omit 3rd (offset) arg; caller changed.
5077 Don't assume EMACS_INT alignment is the same as pointer alignment.
5078
df1bbe5b
SM
50792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5080
5081 * keyboard.c (read_key_sequence_remapped): New var.
5082 (read_key_sequence): Compute remapping in the right buffer.
5083 (command_loop_1): Use read_key_sequence's remapping directly.
5084
51553db6
SM
50852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5086
32c1fffd
SM
5087 * dired.c (file_name_completion): Don't expand file name.
5088 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5089 before checking file name handler.
5090
51553db6
SM
5091 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5092 they've been requested explicitly (bug#9591).
5093
b6bd1599 50942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5095
5096 * keymap.c (Fsingle_key_description): Use make_specified_string
5097 instead of build_string to build string from push_key_description.
5098 (Bug#5193)
5099
f701dc2a
PE
51002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5101
4222c55d
PE
5102 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5103 This fixes a Y2038 bug on 64-bit hosts.
5104 * buffer.c (reset_buffer):
5105 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5106 (Fclear_buffer_auto_save_failure):
5107 Use 0, not -1, to represent an unset failure time, since time_t
5108 might not be signed.
5109
f701dc2a
PE
5110 Remove dependency on glibc malloc internals.
5111 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5112 Move back here from lisp.h, but with their new implementations.
5113 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5114 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5115 * charset.c (charset_table_init): New static var.
5116 (syms_of_charset): Use it instead of xmalloc. This removes a
5117 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5118 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5119 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5120 Move back to alloc.c.
5121 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5122 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5123
9ceebf39
JD
51242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5125
5126 * nsterm.m (windowDidResize): Call x_set_window_size only when
5127 ns_in_resize is true. Otherwise set pixelwidth/height and
5128 call change_frame_size (Bug#9628).
5129
cb993c58
PE
51302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5131
3930c88b
PE
5132 Port --enable-checking=all to Fedora 14 x86-64.
5133 * charset.c (syms_of_charset): Also account for glibc malloc's
5134 internal overhead when calculating the initial malloc maximum.
5135
cb993c58
PE
5136 Port --enable-checking=all to Fedora 14 x86.
5137 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5138 Move to lisp.h.
5139 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5140 (overrun_check_realloc, overrun_check_free):
5141 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5142 That way, xmalloc returns a properly-aligned pointer even if
5143 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5144 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5145 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5146 into account when calculating the initial malloc maximum.
5147 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5148 Move here from alloc.c, so that charset.c can use it too.
5149 Properly align; the old code wasn't right for common 32-bit hosts
5150 when configured with --enable-checking=all.
5151 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5152 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5153
31bed486
EZ
51542011-09-29 Eli Zaretskii <eliz@gnu.org>
5155
04c70788 5156 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5157 use EDOM.
5158
fbcaa2f3
EZ
51592011-09-28 Eli Zaretskii <eliz@gnu.org>
5160
5161 * xdisp.c (compute_display_string_end): If there's no display
5162 string at CHARPOS, return -1.
5163
5164 * bidi.c (bidi_fetch_char): When compute_display_string_end
5165 returns a negative value, treat the character as a normal
5166 character not covered by a display string. (Bug#9624)
5167
a239d4e9
JB
51682011-09-28 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * lread.c (Fread_from_string): Fix typo in docstring.
5171
88652fd5
EZ
51722011-09-27 Eli Zaretskii <eliz@gnu.org>
5173
5174 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5175 newline, reseat the iterator instead of bidi-iterating there one
5176 character at a time. (Bug#9610)
32c1fffd
SM
5177 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5178 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5179
ed497dd4
AS
51802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5181
5182 * lread.c (readevalloop): Use correct code for NBSP.
5183 (read1): Likewise. (Bug#9608)
5184
b2bf61aa
MA
51852011-09-25 Michael Albinus <michael.albinus@gmx.de>
5186
5187 * dbusbind.c (Fdbus_register_signal): When service is not
5188 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5189
32bbb17c
GM
51902011-09-25 Glenn Morris <rgm@gnu.org>
5191
5192 * buffer.c (truncate-lines): Doc fix.
5193
94e0933e
CY
51942011-09-24 Chong Yidong <cyd@stupidchicken.com>
5195
5196 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5197 (Fset_window_next_buffers): Doc fix.
5198
cddde921
GM
51992011-09-24 Glenn Morris <rgm@gnu.org>
5200
5201 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5202
1260aef1
PE
52032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5204
25b4bfa0
PE
5205 Fix minor problems found by static checking.
5206 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5207 * indent.c (Fvertical_motion): Fix == vs = typo.
5208
e3cbd34b
EZ
52092011-09-24 Eli Zaretskii <eliz@gnu.org>
5210
a66cfb1c
SM
5211 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5212 Default value is now t. Doc fix.
6bf7006f 5213
e3cbd34b 5214 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5215 logic when moving up, not only when moving down. Fix the
e3cbd34b 5216 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5217 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5218
5219 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5220 CHARPOS is covered by a display string which includes newlines.
5221 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5222 is covered by a display string with embedded newlines.
5223
a3de0cbd
MA
52242011-09-24 Michael Albinus <michael.albinus@gmx.de>
5225
5226 * dbusbind.c (Fdbus_register_signal): Add match rule to
5227 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5228 (Fdbus_register_method, Vdbus_registered_objects_table):
5229 Fix docstring.
a3de0cbd 5230
b260039d
JM
52312011-09-24 Jim Meyering <meyering@redhat.com>
5232
32c1fffd 5233 do not ignore write error for any output size
b260039d
JM
5234 The previous change was incomplete.
5235 While it makes emacs --batch detect the vast majority of stdout
5236 write failures, errors were still ignored whenever the output size is
5237 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5238 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5239 && echo FAIL: ignored write error
5240 FAIL: ignored write error
5241 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5242 && echo FAIL: ignored write error
5243 FAIL: ignored write error
5244 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5245
8eca8a7c
AS
52462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5247
5248 * emacs.c (Fkill_emacs): In noninteractive mode exit
5249 non-successfully if a write error occurred on stdout. (Bug#9574)
5250
3341db62
EZ
52512011-09-21 Eli Zaretskii <eliz@gnu.org>
5252
5253 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5254 the xassert test.
5255
5256 * dispextern.h (struct it): Update the comment documenting what
5257 can it->OBJECT be.
5258
8c203dbf
EZ
52592011-09-20 Eli Zaretskii <eliz@gnu.org>
5260
5261 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5262 a display string, extend search for cursor position to end of row.
5263 (find_row_edges): If the row ends in a newline from a display
5264 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5265 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5266 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5267 non-empty line. Fixes confusing cursor motion with arrow keys at
5268 the beginning of a line that starts with whitespace.
8c203dbf 5269
a4824228
LMI
52702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5271
5272 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5273 (bug#9493).
5274
33ed493b
CY
52752011-09-18 Chong Yidong <cyd@stupidchicken.com>
5276
5277 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5278 boolean (Bug#9154).
5279
56cd55c8
EZ
52802011-09-18 Eli Zaretskii <eliz@gnu.org>
5281
5282 * xdisp.c (display_line): Record maximum and minimum buffer
5283 positions even if no glyphs were produced (e.g., by a zero-width
5284 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5285 buffer positions that will be removed from the glyph row because
5286 they don't fit.
c02dcedf
EZ
5287 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5288 column is beyond frame width: don't subtract 1 "pixel" when
5289 computing width of the stretch.
3e62b7e0
EZ
5290 (reseat_at_next_visible_line_start): Undo the change made on
5291 2011-09-17 that saved paragraph information and restored it after
5292 the call to `reseat'. (Bug#9545)
56cd55c8 5293
5ed99d36 52942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5295
5296 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5297 and turn window cursor on if cleared (Bug#9415).
5298
5ed99d36 52992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5300
5301 * search.c (boyer_moore): Take unibyte characters from pattern
5302 literally. (Bug#9458)
5303
9bade7b2
EZ
53042011-09-18 Eli Zaretskii <eliz@gnu.org>
5305
5306 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5307
e5e9d610
PE
53082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5309
87e4427a
PE
5310 Fix minor problem found by static checking.
5311 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5312 initialized, to pacify gcc -Wuninitialized.
5313
e5e9d610
PE
5314 * fileio.c: Report proper errno when syscall falls.
5315 (Finsert_file_contents): Save and restore errno,
5316 so that report_file_error outputs the correct diagnostic.
5317 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5318
a1674f0b
EZ
53192011-09-18 Eli Zaretskii <eliz@gnu.org>
5320
5321 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5322
fbfb6dd4
EZ
53232011-09-17 Eli Zaretskii <eliz@gnu.org>
5324
5325 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5326 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5327
bb187662
EZ
53282011-09-17 Eli Zaretskii <eliz@gnu.org>
5329
1137e8b8 5330 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5331 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5332
5333 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5334 (bidi_find_paragraph_start): Search back for paragraph beginning
5335 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5336 (bidi_move_to_visually_next): Only trigger paragraph-related
5337 computations when the last character is a newline or at EOB, not
5338 just any NEUTRAL_B. (Bug#9470)
5339
bb187662
EZ
5340 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5341 truncated lines if point is covered by a display string. (Bug#9524)
5342
2e621251
PE
53432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5346 (cons_to_x_long): New function.
5347 (lisp_data_to_selection_data): Use it. Correct the test for
5348 short-versus-long data; it was negated. Break out of vector
5349 loop, for efficiency, when a long datum is discovered.
5350
91a15bc6
SM
53512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5352
5353 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5354
b41c3a35
EZ
53552011-09-16 Eli Zaretskii <eliz@gnu.org>
5356
5357 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5358 GCC PR/17406) by declaring this function with external scope.
5359
7812ba2d
PE
53602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5361
5362 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5363 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5364
cf7edc2a
AS
53652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5366
5367 * editfns.c (Fformat): Correctly handle text properties on "%%".
5368
bd01620e
EZ
53692011-09-15 Eli Zaretskii <eliz@gnu.org>
5370
5371 * xterm.c (x_draw_composite_glyph_string_foreground):
5372 * w32term.c (x_draw_composite_glyph_string_foreground):
5373 * term.c (encode_terminal_code):
5374 * composite.c (composition_update_it, get_composition_id):
5375 * xdisp.c (get_next_display_element)
5376 (fill_composite_glyph_string): Add comments about special meaning
5377 of TAB characters in a composition.
5378
a02719a3
PE
53792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5380
5381 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5382 This occurs when processing a multibyte format.
5383 Problem reported by Wolfgang Jenker.
a02719a3 5384
72589a3c
JB
53852011-09-15 Johan Bockgård <bojohan@gnu.org>
5386
5387 * xdisp.c (try_cursor_movement): Only check for exact match if
5388 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5389
1c14176c
PE
53902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5391
5392 Remove unused external symbols.
5393 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5394 * xdisp.c (calc_pixel_width_or_height): Now static.
5395 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5396 * indent.c (check_display_width):
5397 * w32term.c: Fix comment to match code.
5398 * xterm.c, xterm.h (x_catching_errors): Remove.
5399
d2eea5b5
PE
54002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5401
5402 * xselect.c: Use signed conversions more consistently (Bug#9498).
5403 (selection_data_to_lisp_data): Assume incoming selection data are
5404 signed integers, not unsigned. This is to be consistent with
5405 outgoing selection data, which was modified to use signed integers
5406 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5407 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5408 expects long, not unsigned long.
5409
46888499
EZ
54102011-09-14 Eli Zaretskii <eliz@gnu.org>
5411
5412 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5413 computation of loop end. Reported by Johan Bockgård
5414 <bojohan@gnu.org>.
5415
ef8ef9fb
CY
54162011-09-13 Chong Yidong <cyd@stupidchicken.com>
5417
5418 * frame.c (Fother_visible_frames_p): Function deleted.
5419
fa819fed
EZ
54202011-09-12 Eli Zaretskii <eliz@gnu.org>
5421
5422 * indent.c (compute_motion): Process display vector front to back
5423 rather than the other way around. (Bug#2496)
5424
2ba8e008
SM
54252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5426
5427 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5428
20f53c69
CY
54292011-09-11 Chong Yidong <cyd@stupidchicken.com>
5430
5431 * minibuf.c (Fread_from_minibuffer): Doc fix.
5432
d562d7a4
EZ
54332011-09-11 Eli Zaretskii <eliz@gnu.org>
5434
5435 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5436 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5437
1c4d7f3d
LMI
54382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5439
5440 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5441 value for non-existent files.
5442
b885bf36
EZ
54432011-09-11 Eli Zaretskii <eliz@gnu.org>
5444
5445 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5446 set its "size" to -1. This will set the modtime_size field of
5447 the corresponding buffer to -1, which is what
5448 verify-visited-file-modtime expects for files that do not exist.
5449 (Bug#9139)
5450
6612f0bf
PE
54512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5452
5453 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5454 here ...
5455 * lisp.h: ... from here. push_key_description is no longer
5456 defined in keyboard.c, so its declaration should not be in
5457 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5458 logically belongs with push_key_description.
5459
dfb3f755
PE
54602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5461
5462 * buffer.h: Include <sys/types.h> instead of <time.h>.
5463 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5464 Problem reported by Herbert J. Skuhra.
5465
3134906c
LMI
54662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5467
5468 * xml.c (parse_region): Make the parsing work for
5469 non-comment-starting XML files again (bug#9144).
5470
8d903f4e
AS
54712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5472
5473 * image.c (gif_load): Fix calculation of bottom and right corner.
5474 (Bug#9468)
5475
80ad64f4
EZ
54762011-09-10 Eli Zaretskii <eliz@gnu.org>
5477
5478 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5479 redisplay in small windows.
5480
208a048d
EZ
54812011-09-09 Eli Zaretskii <eliz@gnu.org>
5482
5483 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5484
9b1c252e
MR
54852011-09-08 Martin Rudalics <rudalics@gmx.at>
5486
5487 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5488 Operate on live windows only.
5489
2949f33b
JB
54902011-09-08 Juanma Barranquero <lekktu@gmail.com>
5491
5492 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5493
e08dcafd
EZ
54942011-09-07 Eli Zaretskii <eliz@gnu.org>
5495
5496 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5497 only under bidi iteration.
5498
115b96bd
JD
54992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5500
5501 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5502
c8199d0f
PE
55032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5504
5505 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5506 Without this fix, the command to link temacs failed due to an
5507 undefined symbol __builtin_isnan. This is because
5508 /usr/include/iso/math_c99.h #defines isnan(x) to
5509 __builtin_isnan(x), but the bundled gcc, which identifies itself
5510 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5511 a __builtin_isnan.
5512 * floatfns.c (isnan): #undef, and then #define to a clone of
5513 what's in data.c.
5514 (Fisnan): Always define, since it's always available now.
5515 (syms_of_floatfns): Always define isnan at the Lisp level.
5516
e39b275c 55172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5518
5519 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5520
b2db44d9 55212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5522
f4af5137 5523 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5524 The previous code assumed that file offsets (off_t values) fit in
5525 EMACS_INT variables, which is not true on typical 32-bit hosts.
5526 The code messed up by falsely reporting buffer overflow in cases
5527 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5528 when "big" contains more than 2**29 bytes, even though this
5529 inserts just one byte and does not overflow the buffer.
5530 (Finsert_file_contents): Store file offsets as off_t
5531 values, not as EMACS_INT values. Check for overflow when
5532 converting between EMACS_INT and off_t. When checking for
5533 buffer overflow or for overlap, take the offsets into account.
5534 Don't use EMACS_INT for small values where int suffices.
5535 When checking for overlap, fix a typo: ZV was used where
5536 ZV_BYTE was intended.
5537 (Fwrite_region): Don't assume off_t fits into 'long'.
5538 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5539
ecfc0a49
MA
55402011-09-05 Michael Albinus <michael.albinus@gmx.de>
5541
5542 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5543
6511acf2 55442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5545
0999621a 5546 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5547
5548 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5549 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5550 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5551 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5552 (modify_event_symbol): Do not assume that the length of
5553 name_alist_or_stem is safe to alloca and fits in int.
5554 (Fexecute_extended_command): Likewise for function name and binding.
5555 (Frecursion_depth): Wrap around reliably on integer overflow.
5556 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5557 since some callers pass EMACS_INT values.
5558 (Fsingle_key_description): Don't crash if symbol name contains more
5559 than MAX_ALLOCA bytes.
5560 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5561 (get_minibuffer): Arg is now EMACS_INT, not int.
5562 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5563 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5564 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5565
2be7d702
PE
5566 * dbusbind.c (signature_cat): New function.
5567 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5568 Do not overrun buffer; instead, report string overflow.
5569
9d1df220
PE
5570 * dispnew.c (add_window_display_history): Don't overrun buffer.
5571 Truncate instead; this is OK since it's just a log.
5572
33ef5c64
PE
5573 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5574 even if the time zone offset is outlandishly large.
5575 Don't mishandle offset == INT_MIN.
5576
66c6fdd5
PE
5577 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5578 when creating daemon; the previous buffer-overflow check was incorrect.
5579
d749b01b
PE
5580 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5581 which has the guts of the old verror function.
5582
b5cd1905
PE
5583 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5584 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5585
6e1a67fb
PE
5586 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5587 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5588 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5589 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5590 length of string rather than counting it via multiple sprintfs;
5591 that's simpler and more reliable.
c21721cc
PE
5592 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5593 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5594 sprintf, in case result does not fit in int.
5595
c57b67fc
PE
5596 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5597 (fontset_from_font): Print it.
5598
8a401434
PE
5599 * frame.c (tty_frame_count): Now printmax_t, not int.
5600 (make_terminal_frame, set_term_frame_name): Print it.
5601 (x_report_frame_params): In X, window IDs are unsigned long,
5602 not signed long, so print them as unsigned.
5603 (validate_x_resource_name): Check for implausibly long names,
5604 and don't assume name length fits in 'int'.
5605 (x_get_resource_string): Don't blindly alloca invocation name;
5606 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5607 not fit in int.
5608
6e1a67fb
PE
5609 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5610 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5611 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5612
0df02bf3
PE
5613 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5614 Use esprintf, not sprintf, in case result does not fit in int.
5615
48e30793
PE
5616 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5617 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5618 it as a large positive number.
5619 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5620 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5621
a66ff6d8
PE
5622 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5623 in case result does not fit in int.
5624
aca216ff
PE
5625 * print.c (float_to_string): Detect width overflow more reliably.
5626 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5627 buffer overrun. Don't assume list length fits in 'int'. Treat
5628 print length of 0 as 0, not as infinity; to be consistent with other
5629 uses of print length in this function. Don't overflow print length
5630 index. Don't assume hash table size fits in 'long', or that
5631 vectorlike size fits in 'unsigned long'.
5632
31c286f7
PE
5633 * process.c (make_process): Use printmax_t, not int, to format
5634 process-name gensyms.
5635
55e5faa1
PE
5636 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5637
80f2e268
PE
5638 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5639 to avoid potential buffer overrun.
5640
670741ab
PE
5641 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5642 if X resource line is longer than 512 bytes.
5643
b7163a50
PE
5644 * xfns.c (x_window): Make sprintf buffer a bit bigger
5645 to avoid potential buffer overrun.
5646
ae58ff1f
PE
5647 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5648
c43c8a6a
PE
5649 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5650
3f8236f4
PE
56512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5652
53e9fe90 5653 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5654 Without these, Emacs silently mishandles large integers sometimes.
5655 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5656 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5657
6511acf2
PE
5658 * xdisp.c (try_window_id): Check Emacs fixnum range before
5659 converting to 'int'.
806add1d 5660
6511acf2 5661 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5662 Check that an Emacs fixnum is in range before assigning it to 'int'.
5663 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5664 values converted from Emacs fixnums.
5665 (Frecenter): Don't wrap around a line count if it is out of 'int'
5666 range; instead, treat it as an extreme value.
5667 (Fset_window_configuration, compare_window_configurations):
5668 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5669
6511acf2
PE
5670 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5671 that can exceed INT_MAX. Check that EMACS_INT value is in range
5672 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5673 (match_limit): Don't assume that a fixnum can fit in 'int'.
5674
6511acf2 5675 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5676 exceed INT_MAX.
5677
6511acf2 5678 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5679 (Fvertical_motion): Don't wrap around LINES values that don't fit
5680 in 'int'. Instead, treat them as extreme values. This is good
5681 enough for windows, which can't have more than INT_MAX lines anyway.
5682
fcb901a7
LMI
56832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5684
0f2f6b6d
LMI
5685 * Require libxml/parser.h to avoid compilation warning.
5686
fcb901a7
LMI
5687 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5688
5689 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5690 since this reportedly can destroy thread storage.
5691
6e20a0d4
CY
56922011-08-30 Chong Yidong <cyd@stupidchicken.com>
5693
5694 * syntax.c (find_defun_start): Update all cache variables if
5695 exiting early (Bug#9401).
5696
148ae00e
EZ
56972011-08-30 Eli Zaretskii <eliz@gnu.org>
5698
f6cfbd8f
EZ
5699 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5700
148ae00e
EZ
5701 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5702 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5703 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5704
5705 * term.c (tty_append_glyph): New function.
5706 (produce_stretch_glyph): Static function and its prototype deleted.
5707
a66cfb1c
SM
5708 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5709 Add prototypes.
148ae00e 5710
c4a07a4c
PE
57112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5712
5713 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5714 when checking :margin (Bug#9390).
5715 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5716 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5717 so that the name doesn't mislead. All uses changed.
5718
6bc8cd65
JB
57192011-08-28 Johan Bockgård <bojohan@gnu.org>
5720
5721 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5722 set_tty_hooks.
5723
dca4927e
EZ
57242011-08-27 Eli Zaretskii <eliz@gnu.org>
5725
5726 * xdisp.c (move_it_to): Don't bail out early when reaching
5727 position beyond to_charpos, if we are scanning backwards.
5728 (move_it_vertically_backward): When DY == 0, make sure we get to
5729 the first character in the line after the newline.
5730
f2cad773
PE
57312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5732
5733 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5734 (ccl_driver): Do not generate an out-of-range pointer.
5735 (Fccl_execute_on_string): Remove unnecessary check for
5736 integer overflow, noted by Stefan Monnier in
5737 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5738 Remove a FIXME that didn't need fixing.
5739 Simplify the newly-introduced buffer reallocation code.
5740
0cae2cdb
JB
57412011-08-27 Juanma Barranquero <lekktu@gmail.com>
5742
5743 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5744
5fc295a4 57452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5746
70c60eb2 5747 Integer and memory overflow issues (Bug#9196).
726e0ab1 5748
d31850da
PE
5749 * doc.c (get_doc_string): Rework so that
5750 get_doc_string_buffer_size is the actual buffer size, rather than
5751 being 1 less than the actual buffer size; this makes xpalloc more
5752 convenient.
5753
a69fbedb
PE
5754 * image.c (x_allocate_bitmap_record, cache_image):
5755 * xselect.c (Fx_register_dnd_atom):
5756 Simplify previous changes by using xpalloc.
5757
fe5c5d37
PE
5758 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5759 since either will do and ptrdiff_t is convenient with xpalloc.
5760
0065d054
PE
5761 * charset.c (charset_table_size)
5762 (struct charset_sort_data.priority): Now ptrdiff_t.
5763 (charset_compare): Don't overflow if priorities differ greatly.
5764 (Fsort_charsets): Don't assume list length fits in int.
5765 Check for size-calculation overflow when allocating sort data.
5766 (syms_of_charset): Allocate an initial charset table that is
5767 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5768
5769 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5770
5771 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5772 The actual value is always <= INT_MAX, and leaving it unsigned made
5773 overflow checking harder.
5774
5775 * dispextern.h (struct glyph_matrix.rows_allocated)
5776 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5777 with xpalloc. The values are still always <= INT_MAX.
5778
5779 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5780
5781 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5782 (SAFE_NALLOCA): New macro.
5783
5784 * region-cache.c (struct boundary.pos, find_cache_boundary)
5785 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5786 (set_cache_region, invalidate_region_cache)
5787 (revalidate_region_cache, know_region_cache, region_cache_forward)
5788 (region_cache_backward, pp_cache):
5789 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5790 so that ptrdiff_t * can be passed to xpalloc.
5791 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5792 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5793 (pp_cache): Don't assume cache_len fits in int.
5794 * region-cache.h: Adjust extern decls to match.
5795
5796 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5797 EMACS_INT, since either will do, for xpalloc.
5798
5799 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5800 (xnmalloc, xnrealloc, xpalloc): New functions.
5801
726e0ab1
PE
5802 * bidi.c (bidi_shelve_header_size): New constant.
5803 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5804 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5805
51f30bc5 5806 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5807 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5808 (overlay_strings):
5809 Don't update size of array until after memory allocation succeeds,
5810 because xmalloc/xrealloc may not return.
0065d054
PE
5811 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5812 now that we have proper integer overflow checking.
5813 (record_overlay_string, overlay_strings): Catch overflows when
5814 calculating size of overlay_str_buf.
726e0ab1 5815
0065d054
PE
5816 * callproc.c (Fcall_process): Check for size overflow when
5817 calculating size of args2.
5818 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5819 Normally we prefer signed values, but sticking with ptrdiff_t would
5820 require adding more-complicated checks.
726e0ab1
PE
5821
5822 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5823 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5824 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5825 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5826
5827 * character.c (Fstring): Check for size-calculation overflow.
5828
5829 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5830 unnecessary integer overflow. Check for size overflow.
5831 (encode_coding_object): Don't update size until xmalloc succeeds.
5832
5833 * composite.c (get_composition_id): Check for overflow in glyph
5834 length calculations.
5835
5836 Integer and memory overflow fixes for display code.
5837 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5838 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5839 (scrolling_window): Check for overflow in size calculations.
5840 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5841 Don't assume glyph table len fits in int.
5842 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5843 (row_table_size): Now ptrdiff_t, not int.
5844 (scrolling_window): Avoid overflow in size calculations.
5845 Don't update size until allocation succeeds.
5846 * fns.c (concat): Check for overflow in size calculations.
5847 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5848 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5849 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5850
5851 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5852 (get_doc_string): Check for size calculation overflow.
5853 Don't update size until allocation succeeds.
5854 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5855 EMACS_INT, where ptrdiff_t will do.
5856 (Fsubstitute_command_keys): Check for string overflow.
5857
5858 * editfns.c (set_time_zone_rule): Don't assume environment length
5859 fits in int.
5860 (message_length): Now ptrdiff_t, not int.
5861 (Fmessage_box): Don't update size until allocation succeeds.
5862 Don't assume message length fits in int.
5863 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5864
0065d054
PE
5865 * emacs.c (main): Do not reallocate argv, since there is a null at
5866 the end that can be overwritten, and this way there's no need to
5867 worry about size-calculation overflow.
5868 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5869
5870 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5871 alloc succeeds.
5872 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5873
5874 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5875 (x_set_scroll_bar_width, x_figure_window_size):
5876 Check for integer overflow.
5877 (x_set_alpha): Do not assume XINT fits in int.
5878
5879 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5880 This is for the members text_lines, text_cols, total_lines, total_cols,
5881 where the system imposes an 'int' limit.
5882
5883 * fringe.c (Fdefine_fringe_bitmap):
5884 Don't update size until alloc works.
5885
5886 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5887 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5888
5889 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5890 Check for size-calculation overflow.
5891 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5892 do, as we prefer signed integers.
5893 (id_to_widget.max_size, id_to_widget.used)
5894 (xg_store_widget_in_map, xg_remove_widget_from_map)
5895 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5896 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5897 Use and return ptrdiff_t, not int.
5898 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5899 * gtkutil.h: Change prototypes to match the above.
5900
5901 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5902 are duplicate now that they've been promoted to lisp.h.
5903 (x_allocate_bitmap_record, x_alloc_image_color)
5904 (make_image_cache, cache_image, xpm_load):
5905 Don't update size until alloc is done.
5906 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5907 (x_detect_edges):
3256efce 5908 Check for size calculation overflow.
726e0ab1
PE
5909 (ct_colors_allocated_max): New constant.
5910 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5911 overflow.
3256efce 5912
726e0ab1
PE
5913 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5914 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5915 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5916 Use ptrdiff_t, not int, to count maps.
5917 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5918 calculations. Don't update size until allocation succeeds.
5919 Redo calculations to avoid overflow.
726e0ab1
PE
5920 * keyboard.h: Change prototypes to match the above.
5921
5922 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5923 to count maps.
5924 (current_minor_maps): Check for size calculation overflow.
5925 * keymap.h: Change prototypes to match the above.
5926
5927 * lread.c (read1, init_obarray): Don't update size until alloc done.
5928
5929 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5930 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5931
726e0ab1
PE
5932 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5933 Now ptrdiff_t, not int.
5934 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5935 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5936
5937 * process.c (Fnetwork_interface_list): Check for overflow
5938 in size calculation.
5939
5940 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5941
5942 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5943 overflow. Don't bother calling xmalloc when xrealloc will do.
5944
5945 * search.c (Freplace_match): Check for size calculation overflow.
5946 (Fset_match_data): Don't assume list lengths fit in 'int'.
5947
5948 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5949 for command line length. Do not attempt to address one before the
5950 beginning of an array, as that's not portable.
5951
5952 * term.c (max_frame_lines): Remove; unused.
5953 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5954 not int.
5955 (encode_terminal_code, calculate_costs): Check for size
5956 calculation overflow.
5957 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5958 table lengths and related sizes. Don't update size until alloc
5959 done. Redo calculations to avoid overflow.
5960 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5961
5962 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5963 subtracting pointers.
5964 (gobble_line): Check for overflow more carefully. Don't update size
5965 until alloc done.
5966
5967 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5968 Don't update size until alloc done.
5969 Redo size calculations to avoid overflow.
5970 Check for size calculation overflow.
0065d054 5971 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5972
5973 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5974 Use ptrdiff_t, not int, for sizes.
5975 (store_mode_line_noprop_char): Don't update size until alloc done.
5976
0065d054
PE
5977 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5978 Use ptrdiff_t, not int, for sizes.
5979 (Finternal_make_lisp_face, cache_face):
5980 Check for size calculation overflow.
5981 (cache_face): Treat size calculation overflows as if they were
5982 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5983
5984 * xfns.c (x_encode_text, x_set_name_internal)
5985 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5986 sizes, since they can exceed INT_MAX in size. Check for size
5987 calculation overflow.
5988
0065d054
PE
5989 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5990 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5991 Don't update size until alloc done.
5992
0065d054 5993 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5994 as sprintf is limited to int lengths.
1d526e2f 5995
252c5ee1
PE
5996 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5997 (X_LONG_MIN): New macros.
864d7ce7
PE
5998 Use them to make the following changes clearer.
5999 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6000 This change doesn't affect the value now, but it may help remind
6001 future maintainers not to raise the value too much later.
6002 (SELECTION_QUANTUM): Remove, replacing with ...
6003 (selection_quantum): ... new function, which avoids overflow.
6004 All uses changed.
6005 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6006 assumption that selection length fits in 'int'.
6007 (x_reply_selection_request, x_handle_selection_request)
6008 (x_get_window_property, receive_incremental_selection)
6009 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6010 (lisp_data_to_selection_data, clean_local_selection_data):
6011 Use ptrdiff_t, not int, to record length of selection.
6012 (x_reply_selection_request, x_get_window_property)
6013 (receive_incremental_selection, x_property_data_to_lisp):
6014 Redo calculations to avoid overflow.
6015 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6016 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6017 something.
6018 (x_get_window_property, receive_incremental_selection)
6019 (lisp_data_to_selection_data, x_property_data_to_lisp):
6020 Check for size-calculation overflow.
6021 (x_get_window_property, receive_incremental_selection)
6022 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6023 Don't store size until memory allocation succeeds.
6024 (x_get_window_property): Plug memory leak on memory exhaustion.
6025 Don't double-block input; malloc is safe here. Don't assume 2**34
6026 - 4 fits in unsigned long. Add an xassert to check
6027 XGetWindowProperty overflow. Be more careful about overflow
6028 calculations, and distinguish size from memory overflow better.
6029 (receive_incremental_selection): When tracing, don't assume
6030 unsigned int is less than INT_MAX.
6031 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6032 harmful) conversions of unsigned short to int.
6033 (lisp_data_to_selection_data): Don't assume that integers
6034 in the range -65535 through -1 fit in an X unsigned short.
6035 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6036 result parameters unless successful. Rely on cons_to_unsigned
6037 to report problems with elements; the old code wasn't right anyway.
6038 (x_check_property_data): Check for int overflow; we cannot use
6039 a wider type due to X limits.
6040 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6041
726e0ab1 6042 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6043
0065d054
PE
6044 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6045 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6046 (x_color_cells): Don't store size until memory allocation succeeds.
6047 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6048 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6049 (x_term_init): Don't assume length fits in int (sprintf is limited
6050 to int size).
bc18e09d 6051
ebfa62c0
PE
6052 Use ptrdiff_t for composition IDs.
6053 * character.c (lisp_string_width):
6054 * composite.c (composition_table_size, n_compositions)
6055 (get_composition_id, composition_gstring_from_id):
6056 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6057 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6058 * window.c (Frecenter):
6059 Use ptrdiff_t, not int, for composition IDs.
6060 * composite.c (get_composition_id): Check for integer overflow.
6061 * composite.h: Adjust prototypes to match the above changes.
6062
d3411f89
PE
6063 Use ptrdiff_t for hash table indexes.
6064 * category.c (hash_get_category_set):
6065 * ccl.c (ccl_driver):
6066 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6067 * coding.c (coding_system_charset_list, detect_coding_system):
6068 * coding.h (struct coding_system.id):
6069 * composite.c (get_composition_id, gstring_lookup_cache):
6070 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6071 * image.c (xpm_get_color_table_h):
6072 * lisp.h (hash_lookup, hash_put):
6073 * minibuf.c (Ftest_completion):
6074 Use ptrdiff_t for hash table indexes, not int (which is too
6075 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6076 32-bit --with-wide-int hosts).
6077
e097a6fa
PE
6078 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6079 Add a FIXME comment about memory leaks.
6080 (syms_of_charset): Don't assume xmalloc returns.
6081
5637687f
PE
6082 Don't assume that stated character widths fit in int.
6083 * character.c (Fchar_width, c_string_width, lisp_string_width):
6084 * character.h (CHAR_WIDTH):
6085 * indent.c (MULTIBYTE_BYTES_WIDTH):
6086 Use sanitize_char_width to avoid undefined and/or bad behavior
6087 with outlandish widths.
a66cfb1c 6088 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6089 now that we have two such functions. All uses changed.
6090 (sanitize_char_width): New inline function.
6091
a2271ba2
PE
6092 Don't assume that tab-width fits in int.
6093 * character.h (sanitize_width): New inline function.
6094 (SANE_TAB_WIDTH): New macro.
6095 (ASCII_CHAR_WIDTH): Use it.
6096 * indent.c (sane_tab_width): Remove. All uses replaced by
6097 SANE_TAB_WIDTH (current_buffer).
6098 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6099
18c52557
PE
6100 * fileio.c: Integer overflow issues with file modes.
6101 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6102
caeeedc1
PE
6103 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6104 Remove unreachable code.
6105 (read_hex, load_charset_map_from_file): Check for integer overflow.
6106
6df6ae42 6107 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6108 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6109 (x_send_scroll_bar_event): Likewise. Check that the size does not
6110 exceed limits imposed by XClientMessageEvent, as well as the usual
6111 ptrdiff_t and size_t limits.
6112
b13995db
PE
6113 * keyboard.c: Overflow, signedness and related fixes.
6114 (make_lispy_movement): Use same integer type in forward decl
6115 that is used in the definition.
6116 (read_key_sequence, keyremap_step):
6117 Change bufsize argument back to int, undoing my 2011-03-30 change.
6118 We prefer signed types, and int is wide enough here.
6119 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6120 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6121 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6122 length, not size_t. Use ptrdiff_t for index, not int.
6123 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6124 possibility of integer overflow.
6125
13464394
PE
6126 Overflow, signedness and related fixes for images.
6127
6128 * dispextern.h (struct it.stack[0].u.image.image_id)
6129 (struct_it.image_id, struct image.id, struct image_cache.size)
6130 (struct image_cache.used, struct image_cache.ref_count):
6131 * gtkutil.c (update_frame_tool_bar):
6132 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6133 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6134 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6135 * nsmenu.m (update_frame_tool_bar):
6136 * xdisp.c (calc_pixel_width_or_height):
6137 * xfns.c (image_cache_refcount):
6138 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6139 on typical 64-bit hosts.
6140
6141 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6142 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6143 Omit unnecessary casts to int.
6144 (parse_image_spec): Check that integers fall into 'int' range
6145 when the callers expect that.
6146 (image_ascent): Redo ascent calculation to avoid int overflow.
6147 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6148 (lookup_image): Remove unnecessary tests.
6149 (xbm_image_p): Locals are now of int, not EMACS_INT,
6150 since parse_image_check makes sure they fit into int.
6151 (png_load, gif_load, svg_load_image):
6152 Prefer int to unsigned where either will do.
6153 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6154 old tiff_error_handler and tiff_warning_handler.
6155 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6156 stack buffer overflows. It uses only the features of vsnprintf
6157 that are common to both POSIX and native Microsoft.
6158 (tiff_error_handler, tiff_warning_handler): Use it.
6159 (tiff_load, gif_load, imagemagick_load_image):
6160 Don't assume :index value fits in 'int'.
6161 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6162 (imagemagick_load_image): Check that crop parameters fit into
6163 the integer types that MagickCropImage accepts. Don't assume
6164 Vimagemagick_render_type has a nonnegative value. Don't assume
6165 size_t fits in 'long'.
6166 (gs_load): Use printmax_t to print the widest integers possible.
6167 Check for integer overflow when computing image height and width.
6168
c11821d4
EZ
61692011-08-26 Eli Zaretskii <eliz@gnu.org>
6170
6171 * xdisp.c (redisplay_window): Don't force window start if point
6172 will be invisible in the resulting window. (Bug#9324)
6173
0c95fcf7
EZ
61742011-08-25 Eli Zaretskii <eliz@gnu.org>
6175
6176 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6177 the display spec is of the form `(space ...)'.
6178 (handle_display_spec): Return the value returned by
6179 handle_single_display_spec, not just 1 or zero.
6180 (handle_single_display_spec): If the display spec is of the form
6181 `(space ...)', and specifies display in the text area, return 2
6182 rather than 1.
fee65a97 6183 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6184 accurately, and prefer exact match for point under bidi.
6185 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6186
6187 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6188 into disp_prop; all users changed.
6189
6190 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6191 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6192 for the text covered by the display property.
6193
e4ed06f1
CY
61942011-08-25 Chong Yidong <cyd@stupidchicken.com>
6195
6196 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6197 Change return value to nil.
6198 (Frecord_buffer): Delete unused function.
6199
f67cdd7f
EZ
62002011-08-24 Eli Zaretskii <eliz@gnu.org>
6201
5980d4c6
EZ
6202 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6203 buffers, return left-to-right.
8610fe8b
EZ
6204 (set_cursor_from_row): Consider candidate row a win if its glyph
6205 represents a newline and point is on that newline. Fixes cursor
6206 positioning on the newline at EOL of R2L text within L2R
6207 paragraph, and vice versa.
6208 (try_cursor_movement): Check continued rows, in addition to
6209 continuation rows. Fixes unwarranted scroll when point enters a
6210 continued line of R2L text within an L2R paragraph, or vice versa.
6211 (cursor_row_p): Consider the case of point being equal to
6212 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6213 from the end of a short line to the beginning of a continued line
6214 of R2L text within L2R paragraph.
6215 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6216 composed characters.
5980d4c6 6217
f67cdd7f
EZ
6218 * bidi.c (bidi_check_type): Use xassert.
6219 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6220 members.
6221
bca633fb
EZ
62222011-08-23 Eli Zaretskii <eliz@gnu.org>
6223
6224 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6225 a character.
6226
4a5885a7
CY
62272011-08-23 Chong Yidong <cyd@stupidchicken.com>
6228
6229 * nsfont.m (ns_otf_to_script): Fix typo.
6230
0902a04e
KH
62312011-08-22 Kenichi Handa <handa@m17n.org>
6232
6233 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6234 extra slot even if the purpose is char-code-property-table.
6235
1a2e6670
EZ
62362011-08-23 Eli Zaretskii <eliz@gnu.org>
6237
8ddde651
EZ
6238 * xdisp.c (redisplay_window): When computing centering_position,
6239 account for the height of the header line. (Bug#8874)
6240
425cc014
EZ
6241 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6242 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6243 candidate is selected by the mouse, and that candidate has a
6244 composed character under the mouse.
6245
1a2e6670
EZ
6246 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6247 coordinates reported by pos-visible-in-window-p for a composed
6248 character in column zero.
6249
8b76d6f8
SM
62502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6251
6252 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6253
dac347dd
EZ
62542011-08-22 Eli Zaretskii <eliz@gnu.org>
6255
6256 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6257 consider it a hit if to_charpos is anywhere in the range of the
6258 composed buffer positions.
6259
e013fb34
CY
62602011-08-22 Chong Yidong <cyd@stupidchicken.com>
6261
6262 * image.c (gif_load): Don't assume that each subimage has the same
6263 dimensions as the base image. Handle disposal method that is
6264 "undefined" by the gif spec (Bug#9335).
6265
bd1ba3e8
CY
62662011-08-20 Chong Yidong <cyd@stupidchicken.com>
6267
6268 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6269 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6270
54a1215b
EZ
62712011-08-19 Eli Zaretskii <eliz@gnu.org>
6272
823564e5
EZ
6273 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6274 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6275 from an Org mode buffer to a Speedbar frame.
6276
54a1215b
EZ
6277 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6278 a composition, take its buffer position from IT->cmp_it.charpos.
6279 Fixes cursor positioning at the beginning of a line that begins
6280 with a composed character.
6281
9778ebcc
EZ
62822011-08-18 Eli Zaretskii <eliz@gnu.org>
6283
0be6ee06
EZ
6284 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6285 character bidirectional type, use STRONG_L instead. Fixes crashes
6286 in a buffer produced by `describe-categories'.
6287
9778ebcc
EZ
6288 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6289 members before the level stack, so they would be saved and
6290 restored when copying iterator state. Fixes incorrect reordering
6291 around TABs covered by display properties.
6292
156bffbe
AS
62932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6294
6b02f655 6295 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6296
72ad093b
CY
62972011-08-17 Chong Yidong <cyd@stupidchicken.com>
6298
6299 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6300 (internal_condition_case_2, internal_condition_case_n):
6301 Remove unnecessary aborts (Bug#9081).
72ad093b 6302
35774242
EZ
63032011-08-17 Eli Zaretskii <eliz@gnu.org>
6304
6305 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6306 has no `load' handler, try opening the file locally. (Bug#9311)
6307
db76dd85
KB
63082011-08-16 Ken Brown <kbrown@cornell.edu>
6309
6310 * gmalloc.c: Expand comment.
6311
b215eee5
EZ
63122011-08-16 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6315 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6316
a4579d33
KB
63172011-08-16 Ken Brown <kbrown@cornell.edu>
6318
6319 Fix memory allocation problems in Cygwin build (Bug#9273).
6320
6321 * unexcw.c ( __malloc_initialized): Declare external variable.
6322 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6323
8b76d6f8
SM
6324 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6325 New variables.
a4579d33
KB
6326 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6327 dumped emacs.
6328 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6329 in the static heap.
6330 [CYGWIN] (special_realloc): New function.
6331 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6332 requests to realloc storage in the static heap.
6333
3ebec551
PE
63342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6335
6336 * bidi.c (bidi_initialize): Remove unused local.
6337
9fd8be00
EZ
63382011-08-15 Eli Zaretskii <eliz@gnu.org>
6339
6b02f655
SM
6340 * bidimirror.h:
6341 * biditype.h: Remove file.
6342 * makefile.w32-in ($(BLD)/bidi.$(O)):
6343 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6344
6345 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6346
6347 * chartab.c: Improve commentary for the uniprop_table API.
6348
32413314
EZ
6349 * bidi.c (bidi_paragraph_init): Support zero value of
6350 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6351 (bidi_initialize): Use uniprop_table instead of including
6352 biditype.h and bidimirror.h.
32413314 6353
9fd8be00
EZ
6354 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6355 coordinates of the iterator when restoring from ppos_it.
6356 (Bug#9296)
6357
5cf2b69b
KH
63582011-08-14 Kenichi Handa <handa@m17n.org>
6359
6360 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6361 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6362
daf17d00
EZ
63632011-08-14 Eli Zaretskii <eliz@gnu.org>
6364
6365 * xdisp.c (move_it_in_display_line_to): Don't invoke
6366 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6367 ppos_it. Fixes vertical cursor motion when line beginning is
6368 covered by an image. (Bug#9296)
6369
08e3161a
JD
63702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6371
6372 * nsterm.h (ns_run_ascript): Declare.
6373 (NSAPP_DATA2_RUNASSCRIPT): Define.
6374
6375 * nsfns.m (as_script, as_result, as_status): New static variables.
6376 (ns_run_ascript): New function.
5e617bc2 6377 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6378 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6379 the event loop. Get status from as_status (Bug#7276).
6380
6381 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6382 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6383 the event loop (Bug#7276).
6384
a3720aa2
AS
63852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6386
6387 * gnutls.c (QCgnutls_bootprop_priority)
6388 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6389 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6390 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6391 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6392 (QCgnutls_bootprop_verify_hostname_error)
6393 (QCgnutls_bootprop_callbacks_verify): Rename from
6394 Qgnutls_bootprop_..., all uses changed.
6395
6396 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6397 uses changed.
6398
0a0d27fb
PE
63992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6400
19d5c50c
PE
6401 * xfaces.c (Qframe_set_background_mode): Now static.
6402 * dispextern.h (Qframe_set_background_mode): Remove decl.
6403
0a0d27fb
PE
6404 * process.c (Fnetwork_interface_info): Declare local only if needed.
6405
377538cb
JD
64062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6407
6408 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6409 (Fnetwork_interface_list): Allocate in increments of bytes instead
6410 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6411 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6412 sockaddr.
6413 (struct ifflag_def): notrailers is smart on OSX.
6414 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6415 Get hardware address with getifaddrs if available.
6416
08fff70c
EZ
64172011-08-12 Eli Zaretskii <eliz@gnu.org>
6418
6419 * xdisp.c (iterate_out_of_display_property): xassert that
6420 IT->position is set to within IT->object's boundaries. Break from
6421 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6422 when IT->position is set up wrongly due to some bug.
6423 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6424 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6425 entry. Force push_it to save on the stack the current
6426 buffer/string position, to be restored by pop_it. Fix flags in
6427 the iterator structure wrt the object coming from a display
6428 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6429 properties. (Bug#9284)
6430
7be1c708 64312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6432
7be1c708
CY
6433 * fontset.c (fontset_get_font_group): Add proper type checks.
6434 (Bug#9172)
aac0c6e3 6435
7be1c708 64362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6437
7be1c708
CY
6438 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6439 and LC_VERSION_MIN_MACOSX.
6440 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6441 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6442
97bb72a6
EZ
64432011-08-08 Eli Zaretskii <eliz@gnu.org>
6444
6445 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6446 no-display-properties-and-no-overlays under bidi display.
6447 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6448 properties and overlays.
97bb72a6 6449
d5617611
CY
64502011-08-08 Chong Yidong <cyd@stupidchicken.com>
6451
37e11a63
CY
6452 * editfns.c (Fset_time_zone_rule): Document relationship with the
6453 setenv function.
6454
d5617611
CY
6455 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6456 the font entity extracted from the cache (Bug#8109).
6457
58872834
CY
64582011-08-07 Chong Yidong <cyd@stupidchicken.com>
6459
6460 * composite.c (autocmp_chars): Don't reset point. That is done by
6461 restore_point_unwind (Bug#5984).
6462
75bfc667
JL
64632011-08-07 Juri Linkov <juri@jurta.org>
6464
6465 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6466 to show the arg `TIME' instead of `TIMEVAL'.
6467
d1410150
EZ
64682011-08-06 Eli Zaretskii <eliz@gnu.org>
6469
6470 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6471 display property strides EOL and includes a newline, as in
6472 longlines-mode. (Bug#9254)
75b771e4
EZ
6473 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6474 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6475
6476 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6477 is non-zero, even if the data buffer is NULL. Fixes a crash in
6478 vertical-motion with longlines-mode. (Bug#9254)
6479
35928349
EZ
64802011-08-05 Eli Zaretskii <eliz@gnu.org>
6481
ec7cc85b
EZ
6482 * bidi.c <bidi_cache_total_alloc>: Now static.
6483 (bidi_initialize): Initialize bidi_cache_total_alloc.
6484
8b76d6f8 6485 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6486 cache. (Bug#9221)
6487
6488 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6489 amount allocated this far in `bidi_cache_total_alloc'.
6490 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6491 non-zero, only free the data buffer without restoring the cache
6492 contents. All callers changed.
6493
6494 * dispextern.h (bidi_unshelve_cache): Update prototype.
6495
6496 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6497 (move_it_in_display_line, move_it_to)
6498 (move_it_vertically_backward, move_it_by_lines): Replace the call
6499 to xfree to an equivalent call to bidi_unshelve_cache.
6500 (move_it_in_display_line_to): Fix logic of returning
412b6358 6501 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6502
e2e2423b
EZ
65032011-08-05 Eli Zaretskii <eliz@gnu.org>
6504
6505 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6506 came from a string character with a `cursor' property. (Bug#9229)
6507
ae9e757a
JD
65082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6509
6510 * Makefile.in (LIB_PTHREAD): New variable.
6511 (LIBES): Add LIB_PTHREAD (Bug#9216).
6512
6513 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6514 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6515
213bd7f2
AS
65162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6517
6b02f655 6518 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6519
99aaf75f
JD
65202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6521
6522 * xterm.c (x_find_topmost_parent): New function.
6523 (x_set_frame_alpha): Find topmost parent window with
6524 x_find_topmost_parent and set the property there also (bug#9181).
6525 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6526
c74e9d86
PE
65272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6528
6529 * callproc.c (Fcall_process): Avoid vfork clobbering
6530 the local vars buffer, coding_systems, current_dir.
6531
640c8776
SM
65322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6533
6534 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6535
f26d0e4c
PE
65362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6537
8a10d76c
PE
6538 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6539 so that it is not optimized away.
6540
f26d0e4c
PE
6541 * xdisp.c (compute_display_string_pos): Remove unused local.
6542
55439c61
EZ
65432011-08-02 Eli Zaretskii <eliz@gnu.org>
6544
6545 Fix slow cursor motion and scrolling in large buffers with
6546 selective display, like Org Mode buffers. (Bug#9218)
6547
6548 * dispextern.h (struct bidi_it): New member disp_prop_p.
6549
6550 * xdisp.c: Remove one-slot cache of display string positions.
6551 (compute_display_string_pos): Accept an additional argument
5e617bc2 6552 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6553 for a display string or property. If found, set DISP_PROP_P
6554 non-zero.
6555
6556 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6557 DISP_PROP_P, and pass it to compute_display_string_pos.
6558 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6559 non-zero. All callers of bidi_fetch_char changed.
6560
fb33fa43
SM
65612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6562
6563 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6564
b099e063
DM
65652010-12-03 Don March <don@ohspite.net>
6566
6567 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6568 last character M-[char] is translated to ESC [char] (bug#7541).
6569
5cc7f7af
KH
65702011-08-02 Kenichi Handa <handa@m17n.org>
6571
d0fffa3f 6572 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6573
6574 * chartab.c (uniprop_table): Make it non-static.
6575
525d5e6e
EZ
65762011-08-01 Eli Zaretskii <eliz@gnu.org>
6577
6578 * xdisp.c (forward_to_next_line_start): Accept additional argument
6579 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6580 on the newline.
6581 (reseat_at_next_visible_line_start): Use the bidi iterator state
6582 returned by forward_to_next_line_start to restore the state of
6583 it->bidi_it after backing up to previous newline. (Bug#9212)
6584
31011111
AS
65852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6586
6587 * regex.c (re_comp): Protoize.
6588 (re_exec): Fix return type.
6589 (regexec): Fix type of `ret'. (Bug#9203)
6590
476371c4
PE
65912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6592
e5d76069
PE
6593 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6594 This is needed if max-image-size is a floating-point number.
6595
9a79b20c
AS
65962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6597
6598 * print.c (print_object): Print empty symbol as ##.
6599
6600 * lread.c (read1): Read ## as empty symbol.
6601
d8c2fa78
AA
66022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6603
6604 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6605 setting frame foreground color (Bug#9175).
6606 (x_set_background_color): Likewise.
6607
ffe57a7a
AA
6608 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6609 contents (Bug#9176).
6610 (EmacsTooltip -init): Remove bezels and add shadows to
6611 tooltip windows.
6612
bf3492a5
AA
6613 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6614 or scroll bar (Bug#8470).
6615
d55e9c53
AA
6616 * nsfont.m (nsfont_open): Remove assignment to voffset and
6617 unnecessary vars hshink, expand, hd, full_height, min_height.
6618 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6619
6620 * nsterm.h (nsfont_info): Remove voffset field.
6621
d8c2fa78 66222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6623
6624 Implement strike-through and overline on NextStep (Bug#8863).
6625
6626 * nsfont.m (nsfont_open): Use underline position provided by font,
6627 instead of hard-coded value of 2.
6628 (nsfont_draw): Call ns_draw_text_decoration instead.
6629
6630 * nsterm.h: Add declaration for ns_draw_text_decoration.
6631
6632 * nsterm.m (ns_draw_text_decoration): New function for drawing
6633 underline, overline, and strike-through.
6634 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6635 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6636 accommodate underlining, etc.
4843aac3 6637
4cc60b9b
EZ
66382011-07-28 Eli Zaretskii <eliz@gnu.org>
6639
bc7ece87
EZ
6640 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6641 default.
4cc60b9b 6642
476371c4
PE
66432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6644
66606eea
PE
6645 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6646 Without this fix, if a signal arrives just after memory fills up,
6647 'malloc' might be invoked reentrantly.
6648
476371c4
PE
6649 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6650 In other words, assume that every image size is allowed, on non-X
6651 hosts. This assumption is probably wrong, but it lets Emacs compile.
6652
f3fcc40d
AS
66532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6654
6655 * regex.c (re_iswctype): Convert return values to boolean.
6656
350c992f
EZ
66572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6658
6659 * xdisp.c (compute_display_string_pos): Don't use cached display
6660 string position if the buffer had its restriction changed.
6661 (Bug#9184)
6662
5266b4bb
PE
66632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6664
6665 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6666
2573a837 66672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6668
41f55ccd 6669 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6670
39e378da
PE
6671 * bidi.c: Integer size and overflow fixes.
6672 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6673 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6674 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6675 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6676 (bidi_find_other_level_edge):
6677 Use ptrdiff_t instead of EMACS_INT where either will do.
6678 This works better on 32-bit hosts configured --with-wide-int.
6679 (bidi_cache_ensure_space): Check for size-calculation overflow.
6680 Use % rather than repeated addition, for better worst-case speed.
6681 Don't set bidi_cache_size until after xrealloc returns, because it
6682 might not return.
6683 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6684 (bidi_cache_ensure_space): Also check that the bidi cache size
6685 does not exceed that of the largest Lisp string or buffer. See Eli
6686 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6687
5e927815
PE
6688 * alloc.c (__malloc_size_t): Remove.
6689 All uses replaced by size_t. See Andreas Schwab's note
6690 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6691
ca4aa935
PE
6692 * image.c: Improve checking for integer overflow.
6693 (check_image_size): Assume that f is nonnull, since
6694 it is always nonnull in practice. This is one less thing to
6695 worry about when checking for integer overflow later.
6696 (x_check_image_size): New function, which checks for integer
6697 overflow issues inside X.
6698 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6699 This removes the need for a memory_full check.
6700 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6701 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6702 (xbm_read_bitmap_data): Change locals back to 'int', since
6703 their values must fit in 'int'.
6704 (xpm_load_image, png_load, tiff_load):
6705 Invoke x_create_x_image_and_pixmap earlier,
6706 to avoid much needless work if the image is too large.
6707 (tiff_load): Treat overly large images as if
6708 x_create_x_image_and_pixmap failed, not as malloc failures.
6709 (gs_load): Use x_check_image_size.
6710
5f8f9cc2
PE
6711 * gtkutil.c: Omit integer casts.
6712 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6713 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6714
5adf60bc
PE
6715 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6716
c8907a93
PE
6717 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6718 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6719 would wrongly return t on a 64-bit host.
6720
e3c25c68
PE
6721 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6722 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6723 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6724 and therefore cause GCC to emit a bogus diagnostic in some cases.
6725
3f791afe
PE
6726 * image.c: Integer signedness and overflow and related fixes.
6727 This is not an exhaustive set of fixes, but it's time to
6728 record what I've got.
6729 (lookup_pixel_color, check_image_size): Remove redundant decls.
6730 (check_image_size): Don't assume that arbitrary EMACS_INT values
6731 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6732 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6733 (tiff_load, imagemagick_load_image):
6734 Check for overflow in size calculations.
6735 (x_create_x_image_and_pixmap): Remove unnecessary test for
6736 xmalloc returning NULL; that can't happen.
6737 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6738 (xpm_color_bucket): Use better integer hashing function.
6739 (xpm_cache_color): Don't possibly over-allocate memory.
6740 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6741 (gif_memory_source):
6742 Use ptrdiff_t, not int or size_t, to record sizes.
6743 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6744 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6745 either works, as we prefer signed integers.
6746 (tiff_read_from_memory, tiff_write_from_memory):
6747 Return tsize_t, not size_t, since that's what the TIFF API wants.
6748 (tiff_read_from_memory): Don't fail simply because the read would
6749 go past EOF; instead, return a short read.
6750 (tiff_load): Omit no-longer-needed casts.
6751 (Fimagemagick_types): Don't assume size fits into 'int'.
6752
3cc5a532
PE
6753 Improve hashing quality when configured --with-wide-int.
6754 * fns.c (hash_string): New function, taken from sxhash_string.
6755 Do not discard information about ASCII character case; this
6756 discarding is no longer needed.
6757 (sxhash-string): Use it. Change sig to match it. Caller changed.
6758 * lisp.h: Declare it.
6759 * lread.c (hash_string): Remove, since we now use fns.c's version.
6760 The fns.c version returns a wider integer if --with-wide-int is
6761 specified, so this should help the quality of the hashing a bit.
6762
b312a492
PE
6763 * emacs.c: Integer overflow minor fix.
6764 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6765 Define only if GNU_LINUX.
6766 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6767
dfd153ae
PE
6768 * dispnew.c: Integer signedness and overflow fixes.
6769 Remove unnecessary forward decls, that were a maintenance hassle.
6770 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6771 All uses changed.
6772 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6773 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6774 (prepare_desired_row, line_draw_cost):
6775 Use int, not unsigned, where either works.
6776 (save_current_matrix, restore_current_matrix):
6777 Use ptrdiff_t, not size_t, where either works.
6778 (init_display): Check for overflow more accurately, and without
6779 relying on undefined behavior.
6780
a81d11a3
PE
6781 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6782 Remove, replacing with the new symbols in lisp.h. All uses changed.
6783 * fileio.c (make_temp_name):
6784 * filelock.c (lock_file_1, lock_file):
6785 * xdisp.c (message_dolog):
6786 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6787 Use pMd etc. instead.
6788 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6789 replacing the pWIDE etc. symbols removed from editfns.c.
6790
3300e6fd
PE
6791 * keyboard.h (num_input_events): Now uintmax_t.
6792 This is (very slightly) less likely to mess up due to wraparound.
6793 All uses changed.
6794
fd05c7e9
PE
6795 * buffer.c: Integer signedness fixes.
6796 (alloc_buffer_text, enlarge_buffer_text):
6797 Use ptrdiff_t rather than size_t when either will do, as we prefer
6798 signed integers.
6799
903fe15d
PE
6800 * alloc.c: Integer signedness and overflow fixes.
6801 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6802 (__malloc_size_t): Default to size_t, not to int.
6803 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6804 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6805 Prefer ptrdiff_t to size_t when either would do, as we prefer
6806 signed integers.
6807 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6808 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6809 Now const. Initialize with values that are in range even if char
6810 is signed.
6811 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6812 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6813 These functions do the right thing with sizes > 2**32.
6814 (check_depth): Now ptrdiff_t, not int.
6815 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6816 Adjust to new way of storing sizes. Check for size overflow bugs
6817 in rest of code.
6818 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6819 slightly wrong anyway, as it missed one instance of
6820 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6821 (refill_memory_reserve): Omit needless cast to size_t.
6822 (mark_object_loop_halt): Mark as externally visible.
6823
ac82cc6a
PE
6824 * xselect.c: Integer signedness and overflow fixes.
6825 (Fx_register_dnd_atom, x_handle_dnd_message):
6826 Use ptrdiff_t, not size_t, since we prefer signed.
6827 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6828 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6829 x_dnd_atoms_size and x_dnd_atoms_length.
6830
c2d1e36d
PE
6831 * doprnt.c: Prefer signed to unsigned when either works.
6832 * eval.c (verror):
6833 * doprnt.c (doprnt):
6834 * lisp.h (doprnt):
6835 * xdisp.c (vmessage):
6836 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6837 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6838 prefer signed arithmetic to avoid comparison confusion.
6839 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6840 but is a bit tricky.
6841
0e926e56
PE
6842 Assume freestanding C89 headers, string.h, stdlib.h.
6843 * data.c, doprnt.c, floatfns.c, print.c:
6844 Include float.h unconditionally.
6845 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6846 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6847 * regex.c: Likewise for stddef.h, string.h.
6848 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6849 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6850 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6851 (STDC_HEADERS): Remove obsolete defines.
6852 * sysdep.c: Include limits.h unconditionally.
6853
9cfdb3ec
PE
6854 Assume support for memcmp, memcpy, memmove, memset.
6855 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6856 * regex.c (memcmp, memcpy):
6857 Remove; we assume C89 now.
6858
6859 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6860 (__malloc_safe_bcopy): Remove; no longer needed.
6861
cf950e6b 6862 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6863 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6864 well either way, and we prefer signed to unsigned.
6865
dbf38e02
LMI
68662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6867
6868 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6869 closes the connection while we're reading (bug#9182).
6870
d6f0886c 68712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6872
d6f0886c
JD
6873 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6874 are specified (Bug#9168).
24e0f6b1 6875
2eb1f9e6
PE
68762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6877
6878 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6879 Found by GCC static checking and --with-wide-int on a 32-bit host.
6880
22381272 68812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6882
6883 * xdisp.c (compute_display_string_pos): Fix logic of caching
6884 previous display string position. Initialize cached_prev_pos to
6885 -1. Fixes slow-down at the beginning of a buffer.
6886
f25e39b4
EZ
68872011-07-24 Eli Zaretskii <eliz@gnu.org>
6888
6889 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6890 for attrs[LFACE_FONTSET_INDEX].
6891
04c4b52e
PE
68922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6893
6894 * xml.c (parse_region): Remove unused local
6895 that was recently introduced.
6896
c1734fbd
EZ
68972011-07-23 Eli Zaretskii <eliz@gnu.org>
6898
be18c5a5
EZ
6899 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6900 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6901
c1734fbd
EZ
6902 * xdisp.c (move_it_in_display_line_to): Record the best matching
6903 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6904 exit if none of the characters scanned was an exact match.
6905 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6906 when exact match is impossible due to invisible text, and the
6907 lines are truncated.
6908
a258d627
JD
69092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6910
6911 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6912 for OSX >= 10.7.
6913
b6d5a689
EZ
69142011-07-22 Eli Zaretskii <eliz@gnu.org>
6915
0f74f785
EZ
6916 Fix a significant slow-down of cursor motion with C-n, C-p,
6917 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6918 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6919 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6920 (next_element_from_buffer): Call compute_stop_pos_backwards to
6921 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6922 base_level_stop.
6923 (reseat): Don't look for prev_stop, as that could mean a very long
6924 run.
6925 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6926 <cached_disp_overlay_modiff>: Cache for last found display string
6927 position.
551918c1 6928 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6929 about the same buffer in the same area of character positions, and
6930 the buffer wasn't changed since the time the display string
6931 position was cached.
551918c1 6932
b2d0c91a
EZ
69332011-07-22 Eli Zaretskii <eliz@gnu.org>
6934
6935 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6936 is an integer, which is important for empty lines. (Bug#9149)
6937
043604ee
CY
69382011-07-22 Chong Yidong <cyd@stupidchicken.com>
6939
6940 * frame.c (Fmodify_frame_parameters): In tty case, update the
6941 default face if necessary (Bug#4238).
6942
da4adb04
CY
69432011-07-21 Chong Yidong <cyd@stupidchicken.com>
6944
6945 * editfns.c (Fstring_to_char): No need to explain what a character
6946 is in the docstring (Bug#6576).
6947
9abd0532
LMI
69482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6949
6950 * xml.c (parse_region): Make sure we always return a tree.
6951
36881d16
HK
69522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6953
6954 * xml.c (parse_region): If a document contains only comments,
6955 return that, too.
6956
1e98674d
LMI
69572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6958
6959 * xml.c (make_dom): Return comments, too.
6960
590bd467
PE
69612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6962
6963 Port to OpenBSD.
6964 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6965 and the surrounding thread.
6966 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6967 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6968 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6969 timer goes off.
6970 * s/openbsd.h (BROKEN_SIGIO): Define.
6971 * unexelf.c (unexec) [__OpenBSD__]:
6972 Don't update the .mdebug section of the Alpha COFF symbol table.
6973
f41628b2
LMI
69742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6975
6976 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6977 (bug#8460).
6978
b59b67c5
PE
69792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6980
15e3a074
PE
6981 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6982 This fixes some race conditions on the permissions of any newly
6983 created file.
6984
41bed37d
PE
6985 * alloc.c (valid_pointer_p): Use pipe, not open.
6986 This fixes some permissions issues when debugging.
6987
b59b67c5
PE
6988 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6989 If fchown fails to set both uid and gid, try to set just gid,
6990 as that is sometimes allowed. Adjust the file's mode to eliminate
6991 setuid or setgid bits that are inappropriate if fchown fails.
6992
925a6be7
SM
69932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6994
6995 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6996 to compare Lisp_Objects.
6997 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6998 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6999 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7000
52968808
AS
70012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7002
0a6a104b
AS
7003 * lread.c (read_integer): Unread even EOF character.
7004 (read1): Likewise. Properly record start position of symbol.
7005
52968808
AS
7006 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7007 symbol character follows.
7008
9e381cdd
PE
70092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7010
7011 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7012 This works around a problem with the previous change to Fcopy_file.
7013 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7014 and without this change, GCC might complain about discarding
7015 fchown's return value.
7016
b5641435
JB
70172011-07-16 Juanma Barranquero <lekktu@gmail.com>
7018
7019 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7020
a8031457
PE
70212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7022
7023 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7024
dd889327
LMI
70252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7026
750c33f7
LMI
7027 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7028 it's used from the C level.
7029
dd889327
LMI
7030 * process.c: Use the same condition for POLL_FOR_INPUT in both
7031 keyboard.c and process.c (bug#1858).
7032
87e86684
LM
70332011-07-09 Lawrence Mitchell <wence@gmx.li>
7034
7035 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7036 (Fgnutls_boot): Use it.
7037
64348f40
AS
70382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7039
7040 * doc.c (Fsubstitute_command_keys): Revert last change.
7041
1d698799
LMI
70422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7043
f863868c
LMI
7044 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7045 quotes the next character, and doesn't affect other longer
7046 sequences (bug#8935).
7047
1d698799
LMI
7048 * lread.c (syms_of_lread): Clarify that is isn't only
7049 `eval-buffer' and `eval-defun' that's affected by
7050 `lexical-binding' (bug#8460).
7051
aa4b6df6
EZ
70522011-07-15 Eli Zaretskii <eliz@gnu.org>
7053
7054 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7055 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7056
5d856da6
PE
70572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7058
ad6042bb
PE
7059 Fix minor problems found by static checking.
7060 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7061 (elsz): Now a signed constant, not a size_t var. We prefer signed
7062 types to unsigned, to avoid integer comparison confusion. Without
7063 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7064 "cannot optimize loop, the loop counter may overflow", a symptom
7065 of the confusion.
f00bbb22 7066 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7067 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7068
6468f31c
LMI
70692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7070
49080b10
LMI
7071 * search.c (Fre_search_backward): Mention `case-fold-search' in
7072 all the re_search_* functions (bug#8138).
7073
6468f31c
LMI
7074 * keyboard.c (Fopen_dribble_file): Document when the file is
7075 closed (bug#8056).
7076
c965adc5
EZ
70772011-07-14 Eli Zaretskii <eliz@gnu.org>
7078
df9733bf
EZ
7079 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7080 bidi_cache_idx.
7081
0bb23927
EZ
7082 Support bidi reordering of display and overlay strings.
7083 * xdisp.c (compute_display_string_pos)
7084 (compute_display_string_end): Accept additional argument STRING.
7085 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7086 (reseat_to_string): Initialize bidi_it->string.s and
7087 bidi_it->string.schars.
7088 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7089 NULL (avoids a crash in bidi_paragraph_init).
7090 Initialize itb.string.lstring.
0bb23927
EZ
7091 (init_iterator): Call bidi_init_it only of a valid
7092 buffer position was specified. Initialize paragraph_embedding to
7093 L2R.
7094 (reseat_to_string): Initialize the bidi iterator.
7095 (display_string): If we need to ignore text properties of
7096 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7097 original value of -1 will not work with bidi.)
7098 (compute_display_string_pos): First arg is now struct
7099 `text_pos *'; all callers changed. Support display properties on
7100 Lisp strings.
7101 (compute_display_string_end): Support display properties on Lisp
7102 strings.
7103 (init_iterator, reseat_1, reseat_to_string): Initialize the
7104 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7105 when iterating on a string not from display properties).
640c8776
SM
7106 (compute_display_string_pos, compute_display_string_end):
7107 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7108 arrow keys.
7109 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7110 base_level_stop; instead, set base_level_stop to BEGV.
7111 Fixes crashes in vertical-motion.
0bb23927
EZ
7112 (next_element_from_buffer): Improve commentary for when
7113 the iterator is before prev_stop.
7114 (init_iterator): Initialize bidi_p from the default value of
7115 bidi-display-reordering, not from buffer-local value. Use the
7116 buffer-local value only if initializing for buffer iteration.
7117 (handle_invisible_prop): Support invisible properties on strings
7118 that are being bidi-reordered.
7119 (set_iterator_to_next): Support bidi reordering of C strings and
7120 Lisp strings.
7121 (next_element_from_string): Support bidi reordering of Lisp
7122 strings.
7123 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7124 (display_string): Support display of R2L glyph rows.
7125 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7126 (init_iterator): Don't initialize it->bidi_p for strings
7127 here.
7128 (reseat_to_string): Initialize it->bidi_p for strings here.
7129 (next_element_from_string, next_element_from_c_string)
7130 (next_element_from_buffer): Add xassert's for correspondence
7131 between IT's object being iterated and it->bidi_it.string
7132 structure.
7133 (face_before_or_after_it_pos): Support bidi iteration.
7134 (next_element_from_c_string): Handle the case of the first string
7135 character that is not the first one in the visual order.
7136 (get_visually_first_element): New function, refactored from common
7137 parts of next_element_from_buffer, next_element_from_string, and
7138 next_element_from_c_string.
7139 (tool_bar_lines_needed, redisplay_tool_bar)
7140 (display_menu_bar): Force left-to-right direction. Add a FIXME
7141 comment for making that be controlled by a user option.
7142 (push_it, pop_it): Save and restore the state of the
7143 bidi iterator. Save and restore the bidi_p flag.
7144 (pop_it): Iterate out of display property for string iteration as
7145 well.
7146 (iterate_out_of_display_property): Support iteration over strings.
7147 (handle_single_display_spec): Set up it->bidi_it for iteration
7148 over a display string, and call bidi_init_it.
7149 (handle_single_display_spec, next_overlay_string)
7150 (get_overlay_strings_1, push_display_prop): Set up the bidi
7151 iterator for displaying display or overlay strings.
7152 (forward_to_next_line_start): Don't use the shortcut if
7153 bidi-iterating.
7154 (back_to_previous_visible_line_start): If handle_display_prop
7155 pushed the iterator stack, restore the internal state of the bidi
7156 iterator by calling bidi_pop_it same number of times.
7157 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7158 and we are bidi-iterating, don't decrement the iterator position;
7159 instead, set the first_elt flag in the bidi iterator, to produce
7160 the same effect.
7161 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7162 (push_display_prop): xassert that we are iterating a buffer.
7163 (push_it, pop_it): Save and restore paragraph_embedding member.
7164 (handle_single_display_spec, next_overlay_string)
7165 (get_overlay_strings_1, reseat_1, reseat_to_string)
7166 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7167 correctly. Don't assume unibyte strings are not bidi-reordered.
7168 (compute_display_string_pos)
7169 (compute_display_string_end): Fix handling the case of C string.
7170 (push_it, pop_it): Save and restore from_disp_prop_p.
7171 (handle_single_display_spec, push_display_prop): Set the
7172 from_disp_prop_p flag.
7173 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7174 (pop_it): Call iterate_out_of_display_property only if we are
7175 popping after iteration over a string that came from a display
7176 property. Fix a typo in popping stretch info. Add an assertion
7177 for verifying that the iterator position is in sync with the bidi
7178 iterator.
7179 (handle_single_display_spec, get_overlay_strings_1)
7180 (push_display_prop): Fix initialization of paragraph direction for
7181 string when that of the parent object is not yet determined.
7182 (reseat_1): Call bidi_init_it to resync the bidi
7183 iterator with IT's position. (Bug#7616)
7184 (find_row_edges): If ROW->start.pos gives position
7185 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7186 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7187 Reset the from_disp_prop_p flag.
7188 (SAVE_IT, RESTORE_IT): New macros.
7189 (pos_visible_p, face_before_or_after_it_pos)
7190 (back_to_previous_visible_line_start)
7191 (move_it_in_display_line_to, move_it_in_display_line)
7192 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7193 (try_scrolling, redisplay_window, display_line): Use them when
7194 saving a temporary copy of the iterator and restoring it back.
7195 (back_to_previous_visible_line_start, reseat_1)
7196 (init_iterator): Empty the bidi cache "stack".
7197 (move_it_in_display_line_to): If iterator ended up at
7198 EOL, but we never saw any buffer positions smaller than
7199 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7200 motion in bidi-reordered lines.
7201 (move_it_in_display_line_to): Record prev_method and prev_pos
7202 immediately before the call to set_iterator_to_next. Fixes cursor
7203 motion in bidi-reordered lines with stretch glyphs and strings
7204 displayed in margins. (Bug#8133) (Bug#8867)
7205 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7206 TO_CHARPOS.
640c8776
SM
7207 (pos_visible_p): Support positions in bidi-reordered lines.
7208 Save and restore bidi cache.
0bb23927
EZ
7209
7210 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7211 (bidi_paragraph_info): Delete unused struct.
7212 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7213 (bidi_cache_start): New variable.
7214 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7215 to zero.
7216 (bidi_cache_fetch_state, bidi_cache_search)
7217 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7218 (bidi_cache_find, bidi_peek_at_next_level)
7219 (bidi_level_of_next_char, bidi_find_other_level_edge)
7220 (bidi_move_to_visually_next): Compare cache index with
7221 bidi_cache_start rather than with zero.
7222 (bidi_fetch_char): Accept new argument STRING; all callers
7223 changed. Support iteration over a string. Support strings with
7224 display properties. Support unibyte strings. Fix the type of
7225 `len' according to what STRING_CHAR_AND_LENGTH expects.
7226 (bidi_paragraph_init, bidi_resolve_explicit_1)
7227 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7228 (bidi_level_of_next_char, bidi_move_to_visually_next):
7229 Support iteration over a string.
0bb23927
EZ
7230 (bidi_set_sor_type, bidi_resolve_explicit_1)
7231 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7232 can now be zero (for strings); special values 0 and -1 were
7233 changed to -1 and -2, respectively.
7234 (bidi_char_at_pos): New function.
7235 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7236 Call it instead of FETCH_MULTIBYTE_CHAR.
7237 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7238 initialized to valid values.
7239 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7240 values.
7241 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7242 the test for valid cached positions. Fix the logic for looking up
7243 the sentinel state in the cache. GCPRO the Lisp string we are
7244 iterating.
7245 (bidi_push_it, bidi_pop_it): New functions.
7246 (bidi_initialize): Initialize the bidi cache start stack pointer.
7247 (bidi_cache_ensure_space): New function, refactored from part of
7248 bidi_cache_iterator_state. Don't assume the required size is just
7249 one BIDI_CACHE_CHUNK away.
7250 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7251 (bidi_count_bytes, bidi_char_at_pos): New functions.
7252 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7253 always valid if bidi_cache_idx is valid.
7254 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7255 is valid if it's going to be used.
7256 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7257 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7258 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7259 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7260 (bidi_find_other_level_edge, bidi_cache_start_stack):
7261 All variables related to cache indices are now EMACS_INT.
c965adc5 7262
0bb23927
EZ
7263 * dispextern.h (struct bidi_string_data): New structure.
7264 (struct bidi_it): New member `string'. Make flag members be 1-bit
7265 fields, and put them last in the struct.
640c8776
SM
7266 (compute_display_string_pos, compute_display_string_end):
7267 Update prototypes.
0bb23927
EZ
7268 (bidi_push_it, bidi_pop_it): Add prototypes.
7269 (struct iterator_stack_entry): New members bidi_p,
7270 paragraph_embedding, and from_disp_prop_p.
7271 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7272 (bidi_shelve_cache, bidi_unshelve_cache):
7273 Declare prototypes.
0bb23927
EZ
7274
7275 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7276 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7277 and vector-like objects.
7278
7279 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7280 cache around display iteration.
7281
7282 * window.c (Fwindow_end, window_scroll_pixel_based)
7283 (displayed_window_lines, Frecenter): Save and restore the bidi
7284 cache around display iteration.
7285
3bbd2265
LMI
72862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7287
7288 * editfns.c (Fdelete_region): Clarify the use of the named
7289 parameters (bug#6788).
7290
adc47434
MR
72912011-07-14 Martin Rudalics <rudalics@gmx.at>
7292
7293 * indent.c (Fvertical_motion): Set and restore w->pointm when
7294 saving and restoring the window's buffer (Bug#9006).
7295
837c31f8
LMI
72962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7297
7298 * editfns.c (Fstring_to_char): Clarify just what is returned
7299 (bug#6576). Text by Eli Zaretskii.
7300
ac389d0c
JB
73012011-07-13 Juanma Barranquero <lekktu@gmail.com>
7302
7303 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7304
0be0ce47
EZ
73052011-07-13 Eli Zaretskii <eliz@gnu.org>
7306
7307 * buffer.c (mmap_find): Fix a typo.
7308
cd18e7e3
JB
73092011-07-13 Johan Bockgård <bojohan@gnu.org>
7310
7311 Fix execution of x selection hooks.
7312 * xselect.c (Qx_lost_selection_functions)
7313 (Qx_sent_selection_functions): New vars.
7314 (syms_of_xselect): DEFSYM them.
7315 (x_handle_selection_request): Pass Qx_sent_selection_functions
7316 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7317 (x_handle_selection_clear,x_clear_frame_selections):
7318 Pass Qx_lost_selection_functions rather than
7319 Vx_lost_selection_functions to Frun_hook_with_args.
7320
47ea7f44
PE
73212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7322
ac389d0c 7323 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7324 The old code sometimes used this field without initializing it.
7325
47ea7f44
PE
7326 * alloc.c (gc_sweep): Don't read past end of array.
7327 In theory, the old code could also have corrupted Emacs internals,
7328 though it'd be very unlikely.
7329
bc985c87
AS
73302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7331
7332 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7333 argument. (Bug#4026)
bc985c87 7334
0cf34688
LMI
73352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7336
b3dadd76
LMI
7337 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7338 key" (bug#4257).
7339
0cf34688
LMI
7340 * window.c (Fset_window_start): Doc fix (bug#4199).
7341 (Fset_window_hscroll): Ditto.
7342
270768cd
PE
73432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7344
077e3dda 7345 Fix minor new problems caught by GCC 4.6.1.
270768cd 7346 * term.c (init_tty): Remove unused local.
490011a6 7347 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7348 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7349 not used otherwise.
270768cd 7350
b1f58454
CY
73512011-07-12 Chong Yidong <cyd@stupidchicken.com>
7352
7353 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7354
22b9578d
LMI
73552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7356
6e70ab07
LMI
7357 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7358 are the mini-buffer and the echo area (bug#3320).
7359
22b9578d
LMI
7360 * term.c (init_tty): Remove support for supdup, c10 and perq
7361 terminals, which are no longer supported (bug#1482).
7362
8974cc9f
JB
73632011-07-10 Johan Bockgård <bojohan@gnu.org>
7364
7365 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7366
a560d974
JD
73672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7368
7369 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7370 for non-popups (Bug#3642).
7371
1dae0f0a
AS
73722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7373
268c2c36 7374 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7375 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7376 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7377 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7378 * data.c (fmod): Likewise.
7379 * dispnew.c (swap_glyphs_in_rows): Likewise.
7380 * emacs.c (memory_warning_signal): Likewise.
7381 * floatfns.c (float_error): Likewise.
7382 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7383 (otf_open, font_otf_capability, generate_otf_features)
7384 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7385 Likewise.
7386 * image.c (pbm_read_file): Likewise.
7387 * indent.c (string_display_width): Likewise.
7388 * intervals.c (check_for_interval, search_for_interval)
7389 (inc_interval_count, count_intervals, root_interval)
7390 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7391 * lread.c (defalias): Likewise.
268c2c36 7392 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7393 * regex.c (set_image_of_range_1, set_image_of_range)
7394 (regex_grow_registers): Likewise.
7395 * sysdep.c (strerror): Likewise.
7396 * termcap.c (valid_filename_p, tprint, main): Likewise.
7397 * tparam.c (main): Likewise.
7398 * unexhp9k800.c (run_time_remap, save_data_space)
7399 (update_file_ptrs, read_header, write_header, calculate_checksum)
7400 (copy_file, copy_rest, display_header): Likewise.
7401 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7402 Likewise.
7403 * xdisp.c (check_it): Likewise.
7404 * xfaces.c (register_color, unregister_color, unregister_colors):
7405 Likewise.
7406 * xfns.c (print_fontset_result): Likewise.
7407 * xrdb.c (member, fatal, main): Likewise.
7408
99033785
PE
74092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7410
7411 Fix minor problems found by static checking (Bug#9031).
7412 * chartab.c (char_table_set_range, map_sub_char_table):
7413 Remove unused locals.
7414 (uniprop_table): Now static.
7415 * composite.c (_work_char): Remove unused static var.
7416
9cb2ac56
JB
74172011-07-09 Juanma Barranquero <lekktu@gmail.com>
7418
7419 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7420
f25661f0
JD
74212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7422
7423 * gtkutil.c (qttip_cb): Remove code without function.
7424
8278c4fe
EZ
74252011-07-09 Eli Zaretskii <eliz@gnu.org>
7426
7427 * w32.c (pthread_sigmask): New stub.
7428
1692ae2d 74292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7430
8a6ebd58 7431 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7432 sigprocmask is portable only for single-threaded applications, and
7433 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7434 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7435 (LIBES): Use it.
7436 * callproc.c (Fcall_process):
7437 * process.c (create_process):
7438 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7439 Use pthread_sigmask, not sigprocmask.
123403e4 7440
1b854618
JD
74412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7442
7443 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7444 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7445 wrong (Bug#8591).
7446
3fe4b549
JD
74472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7448
0ce7e563
JD
7449 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7450 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7451 (xg_hide_tooltip): Fix comment.
7452
3fe4b549
JD
7453 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7454 in registerServicesMenuSendTypes.
7455 (validRequestorForSendType): Don't check ns_return_types.
7456
7457 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7458 ns_return_type.
7459
5df75e47
JR
74602011-07-08 Jason Rumney <jasonr@gnu.org>
7461
22610910
JR
7462 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7463 SH_SHOW for hidden windows (Bug#5482).
7464
5df75e47
JR
7465 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7466 frame struct members of non-existent frames (Bug#6284).
7467
699c10bd
JD
74682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7469
4393663b
JD
7470 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7471 variable firstTime not needed on OSX >= 10.6.
7472 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7473 >= 10.5. Use setKnobProportion, setDoubleValue.
7474
7475 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7476 (MAC_OS_X_VERSION_10_5): Define if not defined.
7477 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7478 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7479 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7480
7481 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7482 cString and lossyCString on OSX >= 10.4
7483
58179cce 7484 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7485 sizeToFit on OSX >= 10.2.
7486
7487 * nsimage.m (allocInitFromFile): Don't use deprecated method
7488 bestRepresentationForDevice on OSX >= 10.6.
7489
7490 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7491 to avoid warning.
7492
7493 * emacs.c: Declare unexec_init_emacs_zone.
7494
a63e0781
JD
7495 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7496
699c10bd
JD
7497 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7498
7499 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7500 on svcsMenu (Bug#8842).
7501
7502 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7503 ns_return_types.
7504 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7505
7506 * nsterm.m (QUTF8_STRING): Declare.
7507 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7508 (validRequestorForSendType): Return type is (id).
7509 Change indexOfObjectIdenticalTo to indexOfObject.
7510 Check if we have local selection before returning self (Bug#8842).
7511 (writeSelectionToPasteboard): Put local selection into paste board
7512 if we have a local selection (Bug#8842).
7513 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7514
7515 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7516 (ns_get_local_selection): Declare.
7517
54e10184
LMI
75182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7519
9888ff71
LMI
7520 * keymap.c (describe_map_tree): Don't insert a double newline at
7521 the end of the buffer (bug#1169) and return whether we inserted
7522 something.
7523
54e10184
LMI
7524 * callint.c (Fcall_interactively): Change "reading args" to
7525 "providing args" to try to clarify what it does (bug#1010).
7526
15fa4783
KH
75272011-07-07 Kenichi Handa <handa@m17n.org>
7528
7529 * composite.c (composition_compute_stop_pos): Ignore a static
7530 composition starting before CHARPOS (Bug#8915).
7531
7532 * xdisp.c (handle_composition_prop): Likewise.
7533
a8815b00
EZ
75342011-07-07 Eli Zaretskii <eliz@gnu.org>
7535
7536 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7537 (Bug#9015)
7538
ef7b981d 75392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7540
7541 * character.h (unicode_category_t): New enum type.
7542
7543 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7544 (Qchar_code_property_table): New variable.
7545 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7546 (UNIPROP_COMPRESSED_FORM_P): New macros.
7547 (char_table_ascii): Uncompress the compressed values.
7548 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7549 Uncompress the compressed values.
ac389d0c 7550 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7551 (char_table_ref_and_range): Uncompress the compressed values.
7552 (sub_char_table_set): New arg is_uniprop. Callers changed.
7553 Uncompress the compressed values.
7554 (sub_char_table_set_range): Args changed. Callers changed.
7555 (char_table_set_range): Adjuted for the above change.
7556 (map_sub_char_table): Delete args default_val and parent. Add arg
7557 top. Give decoded values to a Lisp function.
640c8776 7558 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7559 values to a Lisp function. Gcpro more variables.
7560 (uniprop_table_uncompress)
7561 (uniprop_decode_value_run_length): New functions.
7562 (uniprop_decoder, uniprop_decoder_count): New variables.
7563 (uniprop_get_decoder, uniprop_encode_value_character)
7564 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7565 New functions.
7566 (uniprop_encoder, uniprop_encoder_count): New variables.
7567 (uniprop_get_encoder, uniprop_table)
7568 (Funicode_property_table_internal, Fget_unicode_property_internal)
7569 (Fput_unicode_property_internal): New functions.
7570 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7571 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7572 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7573 char-code-property-alist.
7574
640c8776 7575 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7576 Vunicode_category_table.
7577
640c8776 7578 * font.c (font_range): Adjust for the change of
c805dec0
KH
7579 Vunicode_category_table.
7580
76b397fb
DN
75812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7582
7583 * m/iris4d.h: Remove file, move contents ...
7584 * s/irix6-5.h: ... here.
7585
22b4128e
PE
75862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7587
7588 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7589 * alloc.c (mark_buffer):
7590 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7591 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7592 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7593 This isn't true in general, and it's particularly not true
7594 if Emacs is configured with --with-wide-int.
7595 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7596 New macros, used in the buffer.c change.
7597
869795d6
JD
75982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7599
7600 * xsettings.c: Use both GConf and GSettings if both are available.
7601 (store_config_changed_event): Add comment.
7602 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7603 (store_tool_bar_style_changed): New functions.
5e617bc2 7604 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7605 (struct xsettings): Move font inside HAVE_XFT.
7606 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7607 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7608 Move inside HAVE_XFT.
640c8776 7609 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7610 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7611 also.
7612 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7613 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7614 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7615 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7616 (parse_settings): Move check for font inside HAVE_XFT.
7617 (read_settings, apply_xft_settings): Add comment.
7618 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7619 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7620 call store_font_name_changed.
7621 (xft_settings_event): Add comment.
7622 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7623 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7624 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7625 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7626 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7627 (xsettings_get_system_font, xsettings_get_system_normal_font):
7628 Add comment.
869795d6 7629
d8ed26bd
PE
76302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7631
7632 Random fixes. E.g., (random) never returned negative values.
7633 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7634 subseconds part to the entropy, as that's a bit more random.
7635 Prefer signed to unsigned, since the signedness doesn't matter and
7636 in general we prefer signed. When given a limit, use a
7637 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7638 latter isn't right if USE_2_TAGS_FOR_INTS.
7639 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7640 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7641
cabf1cac
SM
76422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7643
7644 * textprop.c (text_property_stickiness):
7645 Obey Vtext_property_default_nonsticky.
7646 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7647 * w32fns.c (syms_of_w32fns):
7648 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7649
6e9b2be9
PE
76502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7651
7652 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7653 This is more efficient than Ffile_directory_p and avoids a minor race.
7654
90186c68
LMI
76552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7656
7c301272
LMI
7657 * buffer.c (Foverlay_put): Say what the return value is
7658 (bug#7835).
7659
c4f2d8d4
LMI
7660 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7661 is a directory before asking whether to use the file name
7662 (bug#7564).
ad637907
LMI
7663 (barf_or_query_if_file_exists): Make the "File is a directory"
7664 error be more correct.
c4f2d8d4 7665
90186c68
LMI
7666 * fns.c (Frequire): Remove the mention of the .gz files, since
7667 that's installation-specific, but keep the mention of
7668 `get-load-suffixes'.
7669
da64016e
PE
76702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7671
7672 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7673 Report string overflow if the output is too long.
7674
7d47b580
JB
76752011-07-04 Juanma Barranquero <lekktu@gmail.com>
7676
a555cb87
JB
7677 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7678 (syms_of_gnutls): Remove duplicate DEFSYM for
7679 Qgnutls_bootprop_verify_hostname_error, an error for
7680 Qgnutls_bootprop_verify_error (which is no longer used).
7681
7d47b580
JB
7682 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7683 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7684 Also (re)move comments that are misplaced or no longer relevant.
7685
1e49bfab
LMI
76862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7687
7688 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7689
1485f4c0
CY
76902011-07-03 Chong Yidong <cyd@stupidchicken.com>
7691
7692 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7693 and background color parameters if they have been changed.
7694
a9ab721e
LMI
76952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7696
7697 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7698
cf7cff57
PE
76992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7700
2e13213d
PE
7701 * xsettings.c (SYSTEM_FONT): Define only when used.
7702 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7703
cf7cff57
PE
7704 * keymap.c (access_keymap_1): Now static.
7705
7a8e04f7
CY
77062011-07-02 Chong Yidong <cyd@stupidchicken.com>
7707
7708 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7709 leave any prefix arg for the up event (Bug#1586).
7710
61352f62
LMI
77112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7712
69bb1ef7
LMI
7713 * lread.c (syms_of_lread): Mention single symbols defined by
7714 `defvar' or `defconst' (bug#7154).
7715
61352f62 7716 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7717 (Frequire): Mention get-load-suffixes.
61352f62 7718
28545e04
MR
77192011-07-02 Martin Rudalics <rudalics@gmx.at>
7720
7721 * window.h (window): Remove clone_number slot.
7722 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7723 Remove.
7724 (make_parent_window, make_window, saved_window)
7725 (Fset_window_configuration, save_window_save): Don't deal with
7726 clone numbers.
7727 * buffer.c (Qclone_number): Remove declaration.
7728 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7729
3349e122
SM
77302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7731
7732 Add multiple inheritance to keymaps.
7733 * keymap.c (Fmake_composed_keymap): New function.
7734 (Fset_keymap_parent): Simplify.
7735 (fix_submap_inheritance): Remove.
7736 (access_keymap_1): New function extracted from access_keymap to handle
7737 embedded parents and handle lists of maps.
7738 (access_keymap): Use it.
7739 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7740 (Fcopy_keymap): Handle embedded parents.
7741 (Fcommand_remapping, define_as_prefix): Simplify.
7742 (Fkey_binding): Simplify.
7743 (syms_of_keymap): Move minibuffer-local-completion-map,
7744 minibuffer-local-filename-completion-map,
7745 minibuffer-local-must-match-map, and
7746 minibuffer-local-filename-must-match-map to Elisp.
7747 (syms_of_keymap): Defsubr make-composed-keymap.
7748 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7749 (parse_menu_item): Trivial simplification.
7750
3279eb87
GM
77512011-07-01 Glenn Morris <rgm@gnu.org>
7752
7753 * Makefile.in (SETTINGS_LIBS): Fix typo.
7754
4550efdf
KI
77552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7756
7757 * coding.c (Fencode_coding_string): Record the last coding system
7758 used, as the function doc string says (bug#8738).
7759
0949d2b6
JD
77602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7761
7762 * xsettings.c (store_monospaced_changed): Take new font as arg and
7763 check for change against current_mono_font.
7764 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7765 (emacs_settings_constructor, emacs_settings_get_property)
7766 (emacs_settings_set_property, emacs_settings_class_init)
7767 (emacs_settings_init, gsettings_obj): Remove.
7768 (something_changedCB): New function for HAVE_GSETTINGS.
7769 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7770 with value as argument.
7771 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7772 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7773 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7774 "changed".
7775
7776 * xgselect.c: Add defined (HAVE_GSETTINGS).
7777 (xgselect_initialize): Ditto.
7778
7779 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7780 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7781 xg_select.
7782
bbc6b304
PE
77832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7784
7785 * eval.c (struct backtrace): Simplify and port the data structure.
7786 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7787 signed bit field, as this assumption is not portable and it makes
7788 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7789 "char debug_on_exit : 1" as this is not portable either; instead,
7790 use the portable "unsigned int debug_on_exit : 1". Remove unused
7791 member evalargs. Remove obsolete comments about cc bombing out.
7792
9851bfc5
JD
77932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7794
51bb811f 7795 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7796 Let HAVE_GSETTINGS override HAVE_GCONF.
7797 (store_monospaced_changed): New function.
7798 (EMACS_SETTINGS): A new type derived from GObject to handle
7799 GSettings notifications.
7800 (emacs_settings_constructor, emacs_settings_get_property)
7801 (emacs_settings_set_property, emacs_settings_class_init):
7802 New functions.
7803 (gsettings_client, gsettings_obj): New variables.
7804 (GSETTINGS_SCHEMA): New define.
7805 (something_changedCB): Call store_monospaced_changed.
7806 (init_gsettings): New function.
7807 (xsettings_initialize): Call init_gsettings.
7808 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7809 to NULL.
7810
640c8776 7811 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7812 GCONF_CFLAGS/LIBS.
7813
5386012d
MR
78142011-06-29 Martin Rudalics <rudalics@gmx.at>
7815
7816 * window.c (resize_root_window, grow_mini_window)
7817 (shrink_mini_window): Rename Qresize_root_window to
7818 Qwindow_resize_root_window and Qresize_root_window_vertically to
7819 Qwindow_resize_root_window_vertically.
7820
f13e0b08
PE
78212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7822
7823 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7824
94515237
JB
78252011-06-27 Juanma Barranquero <lekktu@gmail.com>
7826
7827 * makefile.w32-in: Redesign dependencies so they reflect more
7828 clearly which files are directly included by each source file,
7829 and not through other includes.
7830
e43b6e43
MR
78312011-06-27 Martin Rudalics <rudalics@gmx.at>
7832
7833 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7834 (sort_overlays, overlay_strings): When an overlay's clone number
7835 matches the window's clone number process the overlay even if
7836 the overlay's window property doesn't match the current window.
7837
d68443dc
MR
7838 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7839 (Fwindow_hchild): Rename to Fwindow_left_child.
7840 (Fwindow_next): Rename to Fwindow_next_sibling.
7841 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7842 (resize_window_check): Rename to window_resize_check.
7843 (resize_window_apply): Rename to window_resize_apply.
7844 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7845 (Fdelete_other_windows_internal, resize_frame_windows)
7846 (Fsplit_window_internal, Fdelete_window_internal)
7847 (grow_mini_window, shrink_mini_window)
7848 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7849
c7e73be5
JD
78502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7851
7852 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7853 (emacs_fixed_set_min_size): Remove.
7854 (emacs_fixed_new): Take frame as argument.
7855
7856 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7857 (_EmacsFixedPrivate): Remove minwidth/height.
7858 Add struct frame *f.
7859 (emacs_fixed_init): Initialize priv->f.
7860 (get_parent_class, emacs_fixed_set_min_size): Remove.
7861 (emacs_fixed_new): Set priv->f to argument.
7862 (emacs_fixed_get_preferred_width)
7863 (emacs_fixed_get_preferred_height): Use min_width/height from
7864 frames size_hint to set minimum and natural (Bug#8919).
7865 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7866 and use min_width/height from frames size_hint to set
7867 min_width/height (Bug#8919).
7868
7869 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7870 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7871 Fix indentation.
c7e73be5 7872
cf99dcf8
EZ
78732011-06-26 Eli Zaretskii <eliz@gnu.org>
7874
7875 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7876 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7877 called at ZV.
7878
029529ac
CY
78792011-06-26 Chong Yidong <cyd@stupidchicken.com>
7880
7881 * process.c (wait_reading_process_output): Bypass select if
7882 waiting for a cell while ignoring keyboard input, and input is
7883 pending. Suggested by Jan Djärv (Bug#8869).
7884
7a7ef429
PE
78852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7886
7887 Use gnulib's dup2 module instead of rolling our own.
7888 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7889
11fdef7d 78902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7891
7892 * dispnew.c (scrolling_window): Before scrolling, turn off a
7893 mouse-highlight in the window being scrolled.
7894
cd3520a4
JB
78952011-06-24 Juanma Barranquero <lekktu@gmail.com>
7896
7897 Move DEFSYM to lisp.h and use everywhere.
7898
7899 * character.h (DEFSYM): Move declaration...
7900 * lisp.h (DEFSYM): ...here.
7901
7902 * gnutls.c:
7903 * minibuf.c:
7904 * w32menu.c:
7905 * w32proc.c:
7906 * w32select.c: Don't include character.h.
7907
7908 * alloc.c (syms_of_alloc):
7909 * buffer.c (syms_of_buffer):
7910 * bytecode.c (syms_of_bytecode):
7911 * callint.c (syms_of_callint):
7912 * casefiddle.c (syms_of_casefiddle):
7913 * casetab.c (init_casetab_once):
7914 * category.c (init_category_once, syms_of_category):
7915 * ccl.c (syms_of_ccl):
7916 * cmds.c (syms_of_cmds):
7917 * composite.c (syms_of_composite):
7918 * dbusbind.c (syms_of_dbusbind):
7919 * dired.c (syms_of_dired):
7920 * dispnew.c (syms_of_display):
7921 * doc.c (syms_of_doc):
7922 * editfns.c (syms_of_editfns):
7923 * emacs.c (syms_of_emacs):
7924 * eval.c (syms_of_eval):
7925 * fileio.c (syms_of_fileio):
7926 * fns.c (syms_of_fns):
7927 * frame.c (syms_of_frame):
7928 * fringe.c (syms_of_fringe):
7929 * insdel.c (syms_of_insdel):
7930 * keymap.c (syms_of_keymap):
7931 * lread.c (init_obarray, syms_of_lread):
7932 * macros.c (syms_of_macros):
7933 * msdos.c (syms_of_msdos):
7934 * print.c (syms_of_print):
7935 * process.c (syms_of_process):
7936 * search.c (syms_of_search):
7937 * sound.c (syms_of_sound):
7938 * syntax.c (init_syntax_once, syms_of_syntax):
7939 * terminal.c (syms_of_terminal):
7940 * textprop.c (syms_of_textprop):
7941 * undo.c (syms_of_undo):
7942 * w32.c (globals_of_w32):
7943 * window.c (syms_of_window):
7944 * xdisp.c (syms_of_xdisp):
7945 * xfaces.c (syms_of_xfaces):
7946 * xfns.c (syms_of_xfns):
7947 * xmenu.c (syms_of_xmenu):
7948 * xsettings.c (syms_of_xsettings):
7949 * xterm.c (syms_of_xterm): Use DEFSYM.
7950
4228cf16
TZ
79512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7952
cd3520a4 7953 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7954
7fcccf1e
PE
79552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7956
7efb4e0e
PE
7957 Integer and buffer overflow fixes (Bug#8873).
7958
ff5844ad
PE
7959 * print.c (printchar, strout): Check for string overflow.
7960 (PRINTPREPARE, printchar, strout):
7961 Don't set size unless allocation succeeds.
7962
90532f02
PE
7963 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7964 for sizes. Check for string overflow more accurately.
7965 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7966
6d84508d
PE
7967 * macros.c: Integer and buffer overflow fixes.
7968 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7969 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7970 Use ptrdiff_t, not int, for sizes.
7971 Don't increment bufsize until after realloc succeeds.
7972 Check for size-calculation overflow.
7973 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7974
437b2cb4
PE
7975 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7976
8b9ac8b4
PE
7977 * lread.c: Integer overflow fixes.
7978 (read_integer): Radix is now EMACS_INT, not int,
7979 to improve quality of diagnostics for out-of-range radices.
7980 Calculate buffer size correctly for out-of-range radices.
7981 (read1): Check for integer overflow in radices, and in
7982 read-circle numbers.
82cb60d3
PE
7983 (read_escape): Avoid int overflow.
7984 (Fload, openp, read_buffer_size, read1)
7985 (substitute_object_recurse, read_vector, read_list, map_obarray):
7986 Use ptrdiff_t, not int, for sizes.
7987 (read1): Use EMACS_INT, not int, for sizes.
20270765 7988 Check for size overflow.
8b9ac8b4 7989
7fcccf1e
PE
7990 * image.c (cache_image): Check for size arithmetic overflow.
7991
bfbbd7e7
PE
7992 * lread.c: Integer overflow issues.
7993 (saved_doc_string_size, saved_doc_string_length)
7994 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7995 Now ptrdiff_t, not int.
7996 (read1): Don't assume doc string length fits in int. Check for
7997 out-of-range doc string lengths.
7998 (read_list): Don't assume file position fits in int.
39019e54 7999 (read_escape): Check for hex character overflow.
bfbbd7e7 8000
4e323265
LL
80012011-06-22 Leo Liu <sdl.web@gmail.com>
8002
8003 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8004 Move to minibuffer.el.
8005
85fece3e
PE
80062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8007
20b84ce9 8008 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8009 The following patches are for when GLYPH_DEBUG && !XASSERT.
8010 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8011 * dispnew.c (flush_stdout):
8012 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8013 Mark as externally visible.
8014 * dispnew.c (check_window_matrix_pointers): Now static.
8015 * dispnew.c (window_to_frame_vpos):
8016 * xfns.c (unwind_create_frame):
8017 * xterm.c (x_check_font): Remove unused local.
8018 * scroll.c (CHECK_BOUNDS):
8019 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8020 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8021 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8022 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8023 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8024 Now static.
8025 (debug_method_add): Use va_list and vsprintf rather than relying
8026 on undefined behavior with wrong number of arguments.
8027 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8028 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8029 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8030 since we're not interested in debugging glyphs with old libraries.
8031 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8032 GCC 4.6.0's static checking.
8033
0766b489
PE
80342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8035
31fd4b32
PE
8036 Integer overflow and signedness fixes (Bug#8873).
8037 A few related buffer overrun fixes, too.
8038
b79e8648
PE
8039 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8040
0766b489
PE
8041 * dispextern.h (struct face.stipple):
8042 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8043 (x_bitmap_mask, x_allocate_bitmap_record)
8044 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8045 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8046 (x_create_bitmap_from_xpm_data):
8047 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8048 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8049 (.bitmaps_last):
8050 * xfaces.c (load_pixmap):
8051 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8052 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8053 (.bitmaps_last, struct x_output.icon_bitmap):
8054 Use ptrdiff_t, not int, for bitmap indexes.
8055 (x_allocate_bitmap_record): Check for size overflow.
8056 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8057
b081724f
PE
8058 Use ptrdiff_t, not int, for overlay counts.
8059 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8060 * editfns.c (overlays_around, get_pos_property):
8061 * textprop.c (get_char_property_and_overlay):
8062 * xdisp.c (next_overlay_change, note_mouse_highlight):
8063 * xfaces.c (face_at_buffer_position):
21514da7
PE
8064 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8065 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8066 (Fnext_overlay_change, Fprevious_overlay_change)
8067 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8068 Use ptrdiff_t, not int, for sizes.
21514da7 8069 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8070
3de73e5e
PE
8071 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8072
2606c57b
PE
8073 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8074 (x_session_initialize): Do not assume string length fits in int.
8075
aaafe47a
PE
8076 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8077 This is unlikely, but can occur if DPI is outlandish.
8078
2674ddc8 8079 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8080 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8081
28154962
PE
8082 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8083 * xrdb.c (magic_file_p, search_magic_path):
8084 Omit last arg SUFFIX; it was always 0. All callers changed.
8085 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8086
7de51af5
PE
8087 * xfont.c (xfont_match): Avoid need for strlen.
8088
25ed6cc3
PE
8089 * xfns.c: Don't assume strlen fits in int.
8090 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8091
4eab31dd
PE
8092 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8093 not unsigned long, as we prefer signed integers. All callers changed.
8094 Detect integer overflow in repeat count.
8095 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8096 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8097
171e2a58
PE
8098 * termcap.c: Don't assume sizes fit in int and never overflow.
8099 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8100 (gobble_line): Check for size-calculation overflow.
8101
ad39faca 8102 * minibuf.c (Fread_buffer):
6e5bb2dc 8103 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8104 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8105 Don't assume string length fits in int.
8106
52c61c22 8107 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8108 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8109
b5b8c9e5
PE
8110 * font.c: Don't assume string length fits in int.
8111 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8112 Use ptrdiff_t, not int.
ccd6111c
PE
8113 (font_intern_prop): Don't assume string length fits in int.
8114 Don't assume integer property fits in fixnum.
8115 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8116
882f0d81 8117 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8118 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8119 Reformulate so as not to need the command string.
8120 Invoke gzip -cd rather than gunzip, as it's more portable.
8121 (lock_info_type, lock_file_1, lock_file):
8122 Don't assume pid_t and time_t fit in unsigned long.
8123 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8124 (current_lock_owner): Prefer signed type for sizes.
8125 Use memcpy, not strncpy, where memcpy is what is really wanted.
8126 Don't assume (via atoi) that time_t and pid_t fit in int.
8127 Check for time_t and/or pid_t out of range, e.g., via a network share.
8128 Don't alloca where an auto var works fine.
8129
93f4cf88
PE
8130 * fileio.c: Fix some integer overflow issues.
8131 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8132 Don't assume string length fits in int.
8133 (directory_file_name): Don't assume string length fits in long.
8134 (make_temp_name): Don't assume pid fits in int, or that its print
8135 length is less than 20.
8136
f3e92b69
PE
8137 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8138
1bfdaf10
PE
8139 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8140
35016e9a
PE
8141 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8142
3d1e65a1
PE
8143 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8144 We prefer signed integers, even for size calculations.
8145
0b963a93
PE
8146 * emacs.c: Don't assume string length fits in 'int'.
8147 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8148 (main): Don't invoke strlen when not needed.
8149
573f4b54
PE
8150 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8151 (XD_DEBUG_MESSAGE): Don't waste a byte.
8152
989f33ba
PE
8153 * callproc.c (getenv_internal_1, getenv_internal)
8154 (Fgetenv_internal):
965d34eb
PE
8155 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8156
e4d29b33
PE
8157 * lread.c (invalid_syntax): Omit length argument.
8158 All uses changed. This doesn't fix a bug, but it simplifies the
8159 code away from its former Hollerith-constant appearance, and it's
8160 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8161 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8162
eb49b136
PE
8163 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8164 This didn't break anything, but it didn't help either.
8165 It's confusing to put a bogus integer in a place where the actual
8166 value does not matter.
9f62aeb1 8167 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8168 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8169
15375a22
PE
8170 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8171 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8172 implementation.
b61cc01c
PE
8173 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8174 We prefer signed types, and the value cannot exceed the EMACS_INT
8175 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8176 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8177 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8178 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8179
53b2623d
PE
8180 * indent.c (sane_tab_width): New function.
8181 (current_column, scan_for_column, Findent_to, position_indentation)
8182 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8183 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8184
51cab52b 8185 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8186
f2ed8a70
PE
8187 * lisp.h (lint_assume): New macro.
8188 * composite.c (composition_gstring_put_cache):
8189 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8190
abe80cc6
PE
8191 * editfns.c, insdel.c:
8192 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8193
b02c740e
PE
8194 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8195
ebc96716
PE
8196 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8197
b4e50fa0 8198 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8199 Use much-faster test for byte-length change.
311d5d7c 8200 Don't assume string byte-length fits in 'int'.
a4cf38e4 8201 Check that character arg fits in 'int'.
85461888 8202 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8203
c0c1ee9f
PE
8204 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8205
a498d7f4
PE
8206 * fns.c (concat): Catch string overflow earlier.
8207 Do not rely on integer wraparound.
8208
51cab52b
PE
8209 * dispextern.h (struct it.overlay_strings_charpos)
8210 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8211 * xdisp.c (forward_to_next_line_start)
8212 (back_to_previous_visible_line_start)
8213 (reseat_at_next_visible_line_start, next_element_from_buffer):
8214 Don't arbitrarily truncate the value of 'selective' to int.
8215
76031fad
PE
8216 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8217
5eb55db9
PE
8218 * composite.c: Don't truncate sizes to 'int'.
8219 (composition_gstring_p, composition_reseat_it)
8220 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8221 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8222 not EMACS_UINT, for indexes.
5eb55db9 8223
0703a717
PE
8224 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8225
d6202519
PE
8226 * buffer.c: Include <verify.h>.
8227 (struct sortvec.priority, struct sortstr.priority):
8961a454 8228 Now EMACS_INT, not int.
c20998a7 8229 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8230 (struct sortstr.size, record_overlay_string)
8231 (struct sortstrlist.size, struct sortlist.used):
8232 Don't truncate size to int.
8233 (record_overlay_string): Check for size-calculation overflow.
d6202519 8234 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8235
d5a19415
JM
82362011-06-22 Jim Meyering <meyering@redhat.com>
8237
029529ac 8238 Don't leak an XBM-image-sized buffer
d5a19415
JM
8239 * image.c (xbm_load): Free the image buffer after using it.
8240
a9041e6c
PE
82412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8242
8243 Port to Sun C.
8244 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8245 that Sun C diagnosed.
8246 * fns.c (secure_hash): Fix pointer signedness issue.
8247 * intervals.c (static_offset_intervals): New function.
8248 (offset_intervals): Use it.
8249
7f3f739f
LL
82502011-06-21 Leo Liu <sdl.web@gmail.com>
8251
8252 * deps.mk (fns.o):
8253 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8254 sha512.h.
8255
8256 * fns.c (secure_hash): Rename from crypto_hash_function and change
8257 the first arg to accept symbols.
5b66d427 8258 (Fsecure_hash): New primitive.
7f3f739f
LL
8259 (syms_of_fns): New symbols.
8260
76147d94
DD
82612011-06-20 Deniz Dogan <deniz@dogan.se>
8262
8263 * process.c (Fset_process_buffer): Clarify return value in
8264 docstring.
8265
7d7d0045
CY
82662011-06-18 Chong Yidong <cyd@stupidchicken.com>
8267
8268 * dispnew.c (add_window_display_history): Use BVAR.
8269
8270 * xdisp.c (debug_method_add): Use BVAR.
8271 (check_window_end, dump_glyph_matrix, dump_glyph)
8272 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8273
8274 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8275 Likewise.
8276
8277 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8278 check till after the cache is created in init_frame_faces.
8279
ff2bc410
SM
82802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8281
8282 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8283
28177add
PE
82842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8285
dd3482fe
PE
8286 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8287 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8288 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8289
393d71f3 8290 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8291 * fileio.c (Finsert_file_contents):
8292 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8293 Remove the old (too-loose) buffer overflow checks.
8294 They weren't needed, since make_gap checks for buffer overflow.
8295 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8296 The old code merely checked for Emacs fixnum overflow, and relied
8297 on undefined (wraparound) behavior. The new code avoids undefined
8298 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8299
2e6813b0 8300 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8301 Tune. Don't use wider integers than needed. Don't use alloca.
8302 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8303
599a9e4f
PE
8304 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8305
99561444
PE
8306 * insdel.c, lisp.h (buffer_overflow): New function.
8307 (insert_from_buffer_1, replace_range, replace_range_2):
8308 * insdel.c (make_gap_larger):
8309 * editfns.c (Finsert_char):
8310 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8311
28177add
PE
8312 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8313
e69dafad
PE
83142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8315
4baa020d 8316 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8317
b1c46f02
PE
8318 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8319 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8320
e69dafad
PE
8321 * fileio.c: Don't assume EMACS_INT fits in off_t.
8322 (emacs_lseek): New static function.
8323 (Finsert_file_contents, Fwrite_region): Use it.
8324 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8325
566684ea
PE
8326 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8327
e6966cd6
PE
8328 * fns.c: Don't overflow int when computing a list length.
8329 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8330 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8331 truncation on 64-bit hosts. Check for QUIT every
8332 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8333 faster and is responsive enough.
8334 (Flength): Report an error instead of overflowing an integer.
8335 (Fsafe_length): Return a float if the value is not representable
8336 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8337 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8338 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8339
dd0b0efb
PE
8340 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8341 (header_size, word_size): New constants.
8342 (allocate_vectorlike): Don't check size overflow here.
8343 (allocate_vector): Check it here instead, since this is the only
8344 caller of allocate_vectorlike that could cause overflow.
8345 Check that the new vector's length is representable as a fixnum.
8346
86fe5cfe
PE
8347 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8348 The previous code was bogus. For example, next_almost_prime (32)
8349 returned 39, which is undesirable as it is a multiple of 3; and
8350 next_almost_prime (24) returned 25, which is a multiple of 5 so
8351 why was the code bothering to check for multiples of 7?
8352
80e88859
PE
8353 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8354
4a2f0ad6
PE
8355 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8356
f66c7cf8
PE
8357 Variadic C functions now count arguments with ptrdiff_t.
8358 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8359 Back then I didn't know that the Emacs coding style prefers signed int.
8360 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8361 were being counted with int, which may truncate counts on 64-bit
8362 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8363 * lisp.h (struct Lisp_Subr.function.aMANY)
8364 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8365 Arg counts are now ptrdiff_t, not size_t.
8366 All variadic functions and their callers changed accordingly.
8367 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8368 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8369 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8370 * callint.c (Fcall_interactively): Check arg count for overflow,
8371 to avoid potential buffer overrun. Use signed char, not 'int',
8372 for 'varies' array, so that we needn't bother to check its size
8373 calculation for overflow.
8374 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8375 * eval.c (apply_lambda):
8376 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8377 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8378 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8379
a1759b76
PE
8380 * callint.c (Fcall_interactively): Don't use index var as event count.
8381
d96be9fc
PE
8382 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8383 * mem-limits.h (SIZE): Remove; no longer used.
8384
a690a978 8385 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8386
578c21e6
PE
8387 Remove unnecessary casts.
8388 * xterm.c (x_term_init):
8389 * xfns.c (x_set_border_pixel):
8390 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8391 These aren't needed now that we assume ANSI C.
8392
96f53c6c
PE
8393 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8394 It's more likely to cause problems (due to unsigned overflow)
8395 than to cure them.
8396
83c77d31
PE
8397 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8398
ee2079f1
PE
8399 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8400
6da65536
PE
8401 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8402
7147c4a4
PE
8403 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8404
193e32d9
PE
8405 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8406
e5533da6
PE
8407 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8408
9910e595
PE
8409 GLYPH_CODE_FACE returns EMACS_INT, not int.
8410 * dispextern.h (merge_faces):
8411 * xfaces.c (merge_faces):
01103c44
PE
8412 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8413 Don't assume EMACS_INT fits in int.
9910e595 8414
2638320e
PE
8415 * character.h (CHAR_VALID_P): Remove unused parameter.
8416 * fontset.c, lisp.h, xdisp.c: All uses changed.
8417
045eb8d9
PE
8418 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8419
c1f134b5
PE
8420 * fns.c (concat): Minor tuning based on overflow analysis.
8421 This doesn't fix any bugs. Use int to hold character, instead
8422 of constantly refetching from Emacs object. Use XFASTINT, not
8423 XINT, for value known to be a character. Don't bother comparing
8424 a single byte to 0400, as it's always less.
8425
395fcb93 8426 * floatfns.c (Fexpt):
327eeec8
PE
8427 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8428
abbd3d23
PE
8429 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8430 for characters.
8431
684a03ef
PE
8432 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8433
0fed43f3
PE
8434 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8435 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8436 incorrectly succeed when S was a string, because 4294967386 was
8437 truncated before it was used.
8438
8fd02eb7
PE
8439 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8440 Otherwise, an out-of-range integer could cause undefined behavior
8441 on a 64-bit host.
8442
f8c86b69
PE
8443 * composite.c: Use int, not EMACS_INT, for characters.
8444 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8445 EMACS_INT, for values that are known to be in character range.
8446 This doesn't fix any bugs but is the usual style inside Emacs and
8447 may generate better code on 32-bit machines.
8448
34206dd2
PE
8449 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8450 This is for reasons similar to the recent CHAR_STRING fix.
8451 * charset.c (Fencode_char): Check that character arg is actually
8452 a character. Pass an int to ENCODE_CHAR.
8453 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8454 wider than 'int', as a compile-time check to prevent future regressions
8455 in this area.
8456
c5958d4c 8457 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8458
8459 Make sure a 64-bit char is never passed to CHAR_STRING.
8460 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8461 by silently ignoring the top 32 bits, allowing some values
8462 that were far too large to be valid characters.
8463 * character.h: Include <verify.h>.
8464 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8465 arguments are no wider than unsigned, as a compile-time check
8466 to prevent future regressions in this area.
8467 * data.c (Faset):
01103c44 8468 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8469 (Fsubst_char_in_region):
8470 * fns.c (concat):
8471 * xdisp.c (decode_mode_spec_coding):
8472 Adjust to CHAR_STRING's new requirement.
8473 * editfns.c (Finsert_char, Fsubst_char_in_region):
8474 * fns.c (concat): Check that character args are actually
8475 characters. Without this test, these functions did the wrong
8476 thing with wildly out-of-range values on 64-bit hosts.
8477
d37ca623
PE
8478 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8479 These casts should not be needed on 32-bit hosts, either.
8480 * keyboard.c (read_char):
8481 * lread.c (Fload): Remove casts to unsigned.
8482
ea204efb
PE
8483 * lisp.h (UNSIGNED_CMP): New macro.
8484 This fixes comparison bugs on 64-bit hosts.
8485 (ASCII_CHAR_P): Use it.
8486 * casefiddle.c (casify_object):
01103c44 8487 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8488 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8489 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8490 * dispextern.h (FACE_FROM_ID):
8491 * keyboard.c (read_char): Use UNSIGNED_CMP.
8492
41cb286c
PE
8493 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8494 not to EMACS_INT, to avoid GCC warning.
8495
4a1b9832
PE
8496 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8497
55daad71
PE
8498 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8499 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8500 isn't needed on 32-bit machines.
8f95c75c 8501
01103c44
PE
8502 * buffer.c (Fgenerate_new_buffer_name):
8503 Use EMACS_INT for count, not int.
0ceccced 8504 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8505
8506 * data.c (Qcompiled_function): Now static.
8507
c6f072e7
PE
8508 * window.c (window_body_lines): Now static.
8509
20ce5912
PE
8510 * image.c (gif_load): Rename local to avoid shadowing.
8511
9c4c5f81
PE
8512 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8513 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8514 * alloc.c (make_save_value): Integer argument is now of type
8515 ptrdiff_t, not int.
8516 (mark_object): Use ptrdiff_t, not int.
8517 * lisp.h (pD): New macro.
8518 * print.c (print_object): Use it.
8519
c0c5c8ae
PE
8520 * alloc.c: Use EMACS_INT, not int, to count objects.
8521 (total_conses, total_markers, total_symbols, total_vector_size)
8522 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8523 (total_free_floats, total_floats, total_free_intervals)
8524 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8525 Now EMACS_INT, not int. All uses changed.
8526 (Fgarbage_collect): Compute overall total using a double, so that
8527 integer overflow is less likely to be a problem. Check for overflow
8528 when converting back to an integer.
5a25e253
PE
8529 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8530 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8531 These were 'int' variables that could overflow on 64-bit hosts;
8532 they were never used, so remove them instead of repairing them.
211a0b2a 8533 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8534 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8535 Previously, this ceilinged at INT_MAX, but that doesn't work on
8536 64-bit machines.
e46bb31a 8537 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8538
c78baabf 8539 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8540 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8541 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8542 when a (possibly-narrower) signed value would do just as well.
8543 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8544
c9d624c6
PE
8545 * alloc.c: Catch some string size overflows that we were missing.
8546 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8547 for convenience in STRING_BYTES_MAX.
8548 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8549 The definition here is exact; the one in lisp.h was approximate.
8550 (allocate_string_data): Check for string overflow. This catches
8551 some instances we weren't catching before. Also, it catches
8552 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8553 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8554 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8555
c9d624c6
PE
8556 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8557 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8558 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8559
353032ce
PE
8560 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8561
2bccce07
PE
8562 * alloc.c (Fmake_string): Check for out-of-range init.
8563
0ac30604
SM
85642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8565
8566 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8567
c195f2de
JD
85682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8569
8570 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8571 xg_get_default_scrollbar_width.
8572
8573 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8574 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8575 (style_changed_cb): Call update_theme_scrollbar_width and call
8576 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8577 all frames (Bug#8505).
8578 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8579 Call gtk_window_set_resizable if HAVE_GTK3.
8580 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8581 and height if HAVE_GTK3 (Bug#8505).
8582 (scroll_bar_width_for_theme): New variable.
8583 (update_theme_scrollbar_width): New function.
8584 (xg_get_default_scrollbar_width): Move code to
8585 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8586 (xg_initialize): Call update_theme_scrollbar_width.
8587
8588 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8589
8590 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8591
e10ac9f1
MR
85922011-06-12 Martin Rudalics <rudalics@gmx.at>
8593
8594 * frame.c (make_frame): Call other_buffer_safely instead of
8595 other_buffer.
8596
8597 * window.c (temp_output_buffer_show): Call display_buffer with
8598 second argument Vtemp_buffer_show_specifiers and reset latter
8599 immediately after the call.
8600 (Vtemp_buffer_show_specifiers): New variable.
8601 (auto_window_vscroll_p, next_screen_context_lines)
8602 (Vscroll_preserve_screen_position): Remove leading asterisks from
8603 doc-strings.
8604
2d3c217e 86052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8606
7b7f97e8 8607 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8608 * buffer.c (Qclone_number): Remove for now, as it's unused.
8609 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8610 (record_buffer): Remove unused local.
8611 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8612 (set_frame_buffer_list): Remove; unused.
8613 * frame.h (other_visible_frames): Remove decl.
8614 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8615 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8616 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8617 if HAVE_GPM.
8618 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8619 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8620 Define only if HAVE_GPM.
8621 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8622 (update_hints_inhibit): Remove; never set. All uses removed.
8623 * widgetprv.h (emacsFrameClassRec): Remove decl.
8624 * window.c (delete_deletable_window): Now returns void, since it
8625 wasn't returning anything.
8626 (compare_window_configurations): Remove unused locals.
8627 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8628 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8629 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8630 the same widths as pointers. This follows up on the 2011-05-06 patch.
8631 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8632 * xterm.h: Likewise.
8633 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8634
1384b89e
JB
86352011-06-12 Juanma Barranquero <lekktu@gmail.com>
8636
8637 * makefile.w32-in: Update dependencies.
8638 (LISP_H): Add lib/intprops.h.
8639
1100a63c
CY
86402011-06-11 Chong Yidong <cyd@stupidchicken.com>
8641
8642 * image.c (gif_load): Add animation frame delay to the metadata.
8643 (syms_of_image): Use DEFSYM. New symbol `delay'.
8644
6198ccd0
MR
86452011-06-11 Martin Rudalics <rudalics@gmx.at>
8646
8647 * window.c (delete_deletable_window): Re-add.
8648 (Fset_window_configuration): Rewrite to handle dead buffers and
8649 consequently deletable windows.
8650 (window_tree, Fwindow_tree): Remove. Supply functionality in
8651 window.el.
8652 (compare_window_configurations): Simplify code.
8653
b6e3633c
AS
86542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8655
1ab0dee5
AS
8656 * image.c (imagemagick_load_image): Fix type mismatch.
8657 (Fimagemagick_types): Likewise.
8658
b6e3633c
AS
8659 * window.h (replace_buffer_in_windows): Declare.
8660
9397e56f
MR
86612011-06-11 Martin Rudalics <rudalics@gmx.at>
8662
8663 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8664 Qclone_number. Remove external declaration of Qdelete_window.
8665 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8666 code.
640c8776
SM
8667 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8668 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8669 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8670 buffer list implementation.
8671 (other_buffer_safely): New function.
8672 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8673 calls to replace_buffer_in_windows and
8674 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8675 if allowed.
8676 (record_buffer): Inhibit quitting and rewrite using quittable
8677 functions. Run Qbuffer_list_update_hook if allowed.
8678 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8679 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8680 Move switch-to-buffer to window.el.
9397e56f
MR
8681 (bury-buffer): Move to window.el.
8682 (Vbuffer_list_update_hook): New variable.
8683
8684 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8685 section.
8686
8687 * window.h (resize_frame_windows): Move up in code.
8688 (Fwindow_frame): Remove EXFUN.
8689 (replace_buffer_in_all_windows): Remove prototype.
8690 (replace_buffer_in_windows_safely): Add prototype.
8691
8692 * window.c: Declare Qdelete_window static again. Move down
8693 declaration of select_count.
8694 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8695 (Fother_window): Move to window.el.
8696 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8697 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8698 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8699 window.el.
8700 (replace_buffer_in_windows): Implement by calling
8701 Qreplace_buffer_in_windows.
8702 (replace_buffer_in_all_windows): Remove with some functionality
8703 moved into replace_buffer_in_windows_safely.
8704 (replace_buffer_in_windows_safely): New function.
8705 (select_window_norecord, select_frame_norecord): Move in front
8706 of run_window_configuration_change_hook. Remove now obsolete
8707 declarations.
640c8776
SM
8708 (Fset_window_buffer): Rewrite doc-string.
8709 Call Qrecord_window_buffer.
9397e56f
MR
8710 (keys_of_window): Move binding for other-window to window.el.
8711
b50691aa
CY
87122011-06-11 Chong Yidong <cyd@stupidchicken.com>
8713
8714 * dispextern.h (struct image): Replace data member, whose int_val
8715 and ptr_val fields were not used by anything, with a single
8716 lisp_val object.
8717
8718 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8719 (gif_clear_image, gif_load, imagemagick_load_image)
8720 (gs_clear_image, gs_load): Callers changed.
8721
3f754b86
PE
87222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8723
cca69397
PE
8724 * buffer.h: Include <time.h>, for time_t.
8725 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8726
109e28d0
PE
8727 Fix minor problems found by static checking.
8728
60737f02
PE
8729 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8730
4b66faf3
PE
8731 Make identifiers static if they are not used in other modules.
8732 * data.c (Qcompiled_function, Qframe, Qvector):
8733 * image.c (QimageMagick, Qsvg):
8734 * minibuf.c (Qmetadata):
8735 * window.c (resize_window_check, resize_root_window): Now static.
8736 * window.h (resize_window_check, resize_root_window): Remove decls.
8737
109e28d0
PE
8738 * window.c (window_deletion_count, delete_deletable_window):
8739 Remove; unused.
46a4ce9e
PE
8740 (window_body_lines): Now static.
8741 (Fdelete_other_windows_internal): Mark vars as initialized.
8742 Make sure 'resize_failed' is initialized.
8743 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8744 (resize_window_apply): Remove unused local.
8745 * window.h (delete_deletable_window): Remove decl.
8746
109e28d0 8747 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8748 (imagemagick_load_image): Fix pointer signedness problem by changing
8749 last arg from unsigned char * to char *. All uses changed.
8750 Also, fix a local for similar reasons.
8751 Remove unused locals. Remove locals to avoid shadowing.
8752 (fn_rsvg_handle_free): Remove; unused.
8753 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8754 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8755
3f754b86
PE
8756 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8757
2547adb1
CY
87582011-06-10 Chong Yidong <cyd@stupidchicken.com>
8759
8760 * image.c (gif_load): Fix omitted cast error introduced by
8761 2011-06-06 change.
8762
2c8e37d4
MR
87632011-06-10 Martin Rudalics <rudalics@gmx.at>
8764
8765 * window.h (resize_proportionally, orig_total_lines)
8766 (orig_top_line): Remove from window structure.
8767 (set_window_height, set_window_width, change_window_heights)
8768 (Fdelete_window): Remove prototypes.
8769 (resize_frame_windows): Remove duplicate declaration.
8770
440a42e3
EZ
87712011-06-10 Eli Zaretskii <eliz@gnu.org>
8772
8773 * window.h (resize_frame_windows, resize_window_check)
8774 (delete_deletable_window, resize_root_window)
8775 (resize_frame_windows): Declare prototypes.
8776
8777 * window.c (resize_window_apply): Make definition be "static" to
8778 match the prototype.
8779
562dd5e9
MR
87802011-06-10 Martin Rudalics <rudalics@gmx.at>
8781
8782 * window.c: Remove declarations of Qwindow_size_fixed,
8783 window_min_size_1, window_min_size_2, window_min_size,
8784 size_window, window_fixed_size_p, enlarge_window, delete_window.
8785 Remove static from declaration of Qdelete_window, it's
8786 temporarily needed by Fbury_buffer.
8787 (replace_window): Don't assign orig_top_line and
8788 orig_total_lines.
8789 (Fdelete_window, delete_window): Remove. Window deletion is
8790 handled by window.el.
640c8776
SM
8791 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8792 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8793 (Fdelete_other_windows): Remove. Deleting other windows is
8794 handled by window.el.
8795 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8796 handled in window.el.
8797 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8798 Window minimum sizes are handled in window.el.
8799 (shrink_windows, size_window, set_window_height)
8800 (set_window_width, change_window_heights, window_height)
8801 (window_width, CURBEG, CURSIZE, enlarge_window)
8802 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8803 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8804 handled in window.el.
8805 (make_dummy_parent): Rename to make_parent_window and give it a
8806 second argument horflag.
8807 (make_window): Don't set resize_proportionally any more.
8808 (Fsplit_window): Remove. Windows are split in window.el.
8809 (save_restore_action, save_restore_orig_size)
8810 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8811 Resize mini windows in window.el.
8812 (grow_mini_window, shrink_mini_window): Implement by calling
8813 Qresize_root_window_vertically, resize_window_check and
8814 resize_window_apply.
640c8776
SM
8815 (saved_window, Fset_window_configuration, save_window_save):
8816 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8817 resize_proportionally.
8818 (window_min_height, window_min_width): Move to window.el.
8819 (keys_of_window): Move bindings for delete-other-windows,
8820 split-window, delete-window and enlarge-window to window.el.
8821
8822 * buffer.c: Temporarily extern Qdelete_window.
8823 (Fbury_buffer): Temporarily call Qdelete_window instead of
8824 Fdelete_window (Fbury_buffer will move to window.el soon).
8825
8826 * frame.c (set_menu_bar_lines_1): Remove code handling
8827 orig_top_line and orig_total_lines.
8828
8829 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8830 set_window_height but set heights directly.
8831 (change_frame_size_1): Use resize_frame_windows.
8832
8833 * xdisp.c (init_xdisp): Don't use set_window_height but set
8834 heights directly.
8835
640c8776
SM
8836 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8837 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8838 run_window_configuration_change_hook.
8839
8840 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8841 instead of change_window_heights and run
8842 run_window_configuration_change_hook.
8843
1a13852e
MR
88442011-06-09 Martin Rudalics <rudalics@gmx.at>
8845
8846 * window.c (replace_window): Rename second argument REPLACEMENT to
8847 NEW. New third argument SETFLAG. Rewrite.
8848 (delete_window, make_dummy_parent): Call replace_window with
8849 third argument 1.
8850 (window_list_1): Move down in code.
8851 (run_window_configuration_change_hook): Move set_buffer part
8852 before select_frame_norecord part in order to unwind correctly.
8853 Rename count1 to count.
8854 (recombine_windows, delete_deletable_window, resize_root_window)
8855 (Fdelete_other_windows_internal)
8856 (Frun_window_configuration_change_hook, make_parent_window)
8857 (resize_window_check, resize_window_apply, Fresize_window_apply)
8858 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8859 (Fdelete_window_internal, Fresize_mini_window_internal):
8860 New functions.
1a13852e
MR
8861 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8862
f3d1777e
MR
88632011-06-08 Martin Rudalics <rudalics@gmx.at>
8864
496e208e
MR
8865 * window.h (window): Add some new members to window structure -
8866 normal_lines, normal_cols, new_total, new_normal, clone_number,
8867 splits, nest, prev_buffers, next_buffers.
8868 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8869 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8870
f3d1777e
MR
8871 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8872 Remove.
496e208e
MR
8873 (make_dummy_parent): Set new members of windows structure.
8874 (make_window): Move down in code. Handle new members of window
8875 structure.
8876 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8877 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8878 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8879 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8880 (Fset_window_next_buffers, Fset_window_clone_number):
8881 New functions.
496e208e
MR
8882 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8883 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8884 Doc-string fixes.
8885 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8886 Argument WINDOW can be now internal window too.
8887 (Fwindow_use_time): Move up in code.
8888 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8889 Rewrite doc-string.
8890 (Fset_window_configuration, saved_window)
8891 (Fcurrent_window_configuration, save_window_save): Handle new
8892 members of window structure.
b9e809c2
MR
8893 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8894 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8895 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8896 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8897 Qget_mru_window, Qresize_root_window,
8898 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8899 Qauto_buffer_name; staticpro them.
f3d1777e 8900
abde8f8c
MR
89012011-06-07 Martin Rudalics <rudalics@gmx.at>
8902
8903 * window.c (Fwindow_total_size, Fwindow_left_column)
8904 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8905 (Fwindow_list_1): New functions.
8906 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8907 (Fwindow_width, Fscroll_left, Fscroll_right):
8908 Use window_body_cols instead of window_box_text_cols.
8909 (delete_window, Fset_window_configuration):
8910 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8911 (delete_all_subwindows): Take a window as argument and not a
8912 structure. Rewrite.
190b47e6
MR
8913 (window_loop): Remove handling of GET_LRU_WINDOW and
8914 GET_LARGEST_WINDOW.
8915 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8916
8917 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8918 window_box_text_cols. delete_all_subwindows now takes a
8919 Lisp_Object as argument.
abde8f8c 8920
640c8776
SM
8921 * indent.c (compute_motion, Fcompute_motion):
8922 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8923
fa8a67e6
MR
8924 * frame.c (delete_frame): Call delete_all_subwindows with root
8925 window as argument.
8926
a54e3482
DC
89272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8928
8929 * fns.c (Fputhash): Document return value.
8930
60002bf5
CY
89312011-06-06 Chong Yidong <cyd@stupidchicken.com>
8932
8933 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8934
0c671da6 89352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8936
b862a52a 8937 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8938
be44ca6c
PE
8939 Check for overflow when converting integer to cons and back.
8940 * charset.c (Fdefine_charset_internal, Fdecode_char):
8941 Use cons_to_unsigned to catch overflow.
8942 (Fencode_char): Use INTEGER_TO_CONS.
8943 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8944 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8945 * data.c (long_to_cons, cons_to_long): Remove.
8946 (cons_to_unsigned, cons_to_signed): New functions.
8947 These signal an error for invalid or out-of-range values.
8948 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8949 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8950 * font.c (Ffont_variation_glyphs):
8951 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8952 * lisp.h: Include <intprops.h>.
8953 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8954 (cons_to_signed, cons_to_unsigned): New decls.
8955 (long_to_cons, cons_to_long): Remove decls.
8956 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8957 (Fprimitive_undo): Use CONS_TO_INTEGER.
8958 * xfns.c (Fx_window_property): Likewise.
8959 * xselect.c: Include <limits.h>.
8960 (x_own_selection, selection_data_to_lisp_data):
8961 Use INTEGER_TO_CONS.
8962 (x_handle_selection_request, x_handle_selection_clear)
8963 (x_get_foreign_selection, Fx_disown_selection_internal)
8964 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8965 (lisp_data_to_selection_data): Use cons_to_unsigned.
8966 (x_fill_property_data): Use cons_to_signed.
8967 Report values out of range.
8968
d1f3d2af
PE
8969 Check for buffer and string overflow more precisely.
8970 * buffer.h (BUF_BYTES_MAX): New macro.
8971 * lisp.h (STRING_BYTES_MAX): New macro.
8972 * alloc.c (Fmake_string):
8973 * character.c (string_escape_byte8):
8974 * coding.c (coding_alloc_by_realloc):
8975 * doprnt.c (doprnt):
8976 * editfns.c (Fformat):
8977 * eval.c (verror):
8978 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8979 since they may not be the same number.
8980 * editfns.c (Finsert_char):
8981 * fileio.c (Finsert_file_contents):
8982 Likewise for BUF_BYTES_MAX.
8983
dd52fcea
PE
8984 * image.c: Use ptrdiff_t, not int, for sizes.
8985 (slurp_file): Switch from int to ptrdiff_t.
8986 All uses changed.
8987 (slurp_file): Check that file size fits in both size_t (for
8988 malloc) and ptrdiff_t (for sanity and safety).
8989
7f9bbdbb
PE
8990 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8991 if b->modtime has its maximal value.
8992
dfe18f82
PE
8993 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8994
84acfcf0
PE
8995 Don't assume time_t can fit into int.
8996 * buffer.h (struct buffer.modtime): Now time_t, not int.
8997 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8998 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8999
ccd9a01a
PE
9000 Minor fixes for signed vs unsigned integers.
9001 * character.h (MAYBE_UNIFY_CHAR):
9002 * charset.c (maybe_unify_char):
9003 * keyboard.c (read_char, reorder_modifiers):
9004 XINT -> XFASTINT, since the integer must be nonnegative.
9005 * ftfont.c (ftfont_spec_pattern):
9006 * keymap.c (access_keymap, silly_event_symbol_error):
9007 XUINT -> XFASTINT, since the integer must be nonnegative.
9008 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9009 since it makes no difference and we prefer signed.
9010 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9011 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9012 nonnegative.
9013
d6d100dd
SM
90142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9015
9016 * window.h (Fwindow_frame): Declare.
9017
2b6148e4
PE
90182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9019
9020 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9021 (SPARE_MEMORY): Always define.
9022 (LARGE_REQUEST): Remove.
9023 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9024
f230ecc9
MR
90252011-06-06 Martin Rudalics <rudalics@gmx.at>
9026
727e958e
MR
9027 * lisp.h: Move EXFUNS for Fframe_root_window,
9028 Fframe_first_window and Fset_frame_selected_window to window.h.
9029
9030 * window.h: Move EXFUNS for Fframe_root_window,
9031 Fframe_first_window and Fset_frame_selected_window here from
9032 lisp.h.
9033
9034 * frame.c (Fwindow_frame, Fframe_first_window)
9035 (Fframe_root_window, Fframe_selected_window)
9036 (Fset_frame_selected_window): Move to window.c.
9037 (Factive_minibuffer_window): Move to minibuf.c.
9038 (Fother_visible_frames_p): New function.
9039
9040 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9041
f230ecc9
MR
9042 * window.c (decode_window, decode_any_window): Move up in code.
9043 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9044 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9045 (Fwindow_buffer): Move up and rewrite doc-string.
9046 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9047 (Fwindow_prev): New functions.
727e958e
MR
9048 (Fwindow_frame): Move here from frame.c. Accept any window as
9049 argument.
9050 (Fframe_root_window, Fframe_first_window)
9051 (Fframe_selected_window): Move here from frame.c. Accept frame
9052 or arbitrary window as argument. Update doc-strings.
9053 (Fminibuffer_window): Move up in code.
9054 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9055 (Fset_frame_selected_window): Move here from frame.c.
9056 Marginal rewrite.
727e958e
MR
9057 (Fselected_window, select_window, Fselect_window): Move up in
9058 code. Minor doc-string fixes.
f230ecc9 9059
4d09bcf6
PE
90602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9061
9062 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9063 Do not assume that spare memory exists; that assumption is valid
9064 only if SYSTEM_MALLOC.
9065 (LARGE_REQUEST): New macro, so that the issue of large requests
9066 is separated from the issue of spare memory.
9067
810928a2
AS
90682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9069
172418ad
AS
9070 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9071 format. (Bug#8806)
9072
43f862f7
AS
9073 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9074
810928a2
AS
9075 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9076 before statements.
9077
a059fe24
JD
90782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9079
9080 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9081
9082 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9083
9084 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9085 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9086
989bf368
JB
90872011-06-05 Juanma Barranquero <lekktu@gmail.com>
9088
9089 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9090
4b80f674
CY
90912011-06-04 Chong Yidong <cyd@stupidchicken.com>
9092
9093 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9094 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9095 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9096 New error handlers.
4b80f674
CY
9097 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9098 Obey Vx_select_enable_clipboard_manager. Catch errors in
9099 x_clipboard_manager_save (Bug#8779).
9100 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9101 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9102
99a33b77 91032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9104
9105 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9106
99a33b77 91072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9108
9109 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9110 in the current matrix if keep_current_p is non-zero.
9111
8264569d
EZ
91122011-06-04 Eli Zaretskii <eliz@gnu.org>
9113
9114 * bidi.c (bidi_level_of_next_char): Fix last change.
9115
57f97249
EZ
91162011-06-03 Eli Zaretskii <eliz@gnu.org>
9117
fec2107c 9118 Support bidi reordering of text covered by display properties.
57f97249 9119
fec2107c
EZ
9120 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9121 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9122 (bidi_cache_search, bidi_cache_iterator_state)
9123 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9124 (bidi_level_of_next_char, bidi_move_to_visually_next):
9125 Support character positions inside a run of characters covered by a
fec2107c
EZ
9126 display string.
9127 (bidi_paragraph_init, bidi_resolve_explicit_1)
9128 (bidi_level_of_next_char): Call bidi_fetch_char and
9129 bidi_fetch_char_advance instead of FETCH_CHAR and
9130 FETCH_CHAR_ADVANCE.
9131 (bidi_init_it): Initialize new members.
9132 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9133 definitions.
9134 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9135 instead of using explicit *_CHAR codes.
d6d100dd
SM
9136 (bidi_resolve_explicit, bidi_resolve_weak):
9137 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9138 bidirectional text is supported only in multibyte buffers.
9139 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9140 it to initialize the frame_window_p member of struct bidi_it.
9141 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9142 (bidi_resolve_explicit, bidi_resolve_weak)
9143 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9144 bidi_it->nchars is non-positive.
9145 (bidi_level_of_next_char): Don't try to lookup the cache for the
9146 next/previous character if nothing is cached there yet, or if we
9147 were just reseat()'ed to a new position.
c40e2fb2 9148
0e14fe90
EZ
9149 * xdisp.c (set_cursor_from_row): Set start and stop points
9150 according to the row's direction when priming the loop that looks
9151 for the glyph on which to display cursor.
9152 (single_display_spec_intangible_p): Function deleted.
9153 (display_prop_intangible_p): Reimplement to call
9154 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9155 Accept 3 additional arguments needed by handle_display_spec.
9156 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9157 values: lists, `(when COND...)' forms, etc.
9158 (single_display_spec_string_p): Support property values that are
9159 lists with the argument STRING its top-level element.
9160 (display_prop_string_p): Fix the condition for processing a
9161 property that is a list to be consistent with handle_display_spec.
fec2107c 9162 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9163 last portion of handle_display_prop.
9164 (compute_display_string_pos): Accept additional argument
9165 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9166 value of a `display' property is a "replacing spec".
9167 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9168 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9169 the display property, but just return a value indicating whether
9170 the display property will replace the characters it covers.
9171 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9172 frame_window_p members of struct bidi_it.
d6d100dd
SM
9173 (compute_display_string_pos, compute_display_string_end):
9174 New functions.
fec2107c
EZ
9175 (push_it): Accept second argument POSITION, where pop_it should
9176 jump to continue iteration.
9177 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9178
fec2107c
EZ
9179 * keyboard.c (adjust_point_for_property): Adjust the call to
9180 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9181
9182 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9183 (bidi_init_it): Update prototypes.
9184 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9185 (compute_display_string_pos, compute_display_string_end):
9186 Declare prototypes.
fec2107c
EZ
9187 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9188 EMACS_INT.
fc6f18ce 9189
40087514 91902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9191
57f53182
PE
9192 Malloc failure behavior now depends on size of allocation.
9193 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9194 * lisp.h: Change signatures accordingly.
9195 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9196 All callers changed. (Bug#8762)
9197
9198 * gnutls.c: Use Emacs's memory allocators.
9199 Without this change, the gnutls library would invoke malloc etc.
9200 directly, which causes problems on non-SYNC_INPUT hosts, and which
9201 runs afoul of improving memory_full behavior. (Bug#8761)
9202 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9203 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9204 xfree instead of the default malloc, realloc, free.
9205 (Fgnutls_boot): No need to check for memory allocation failure,
9206 since xmalloc does that for us.
9207
ac32cd99 9208 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9209 * category.c (hash_get_category_set):
9210 * ccl.c (ccl_driver):
9211 * charset.c (Fdefine_charset_internal):
9212 * charset.h (struct charset.hash_index):
9213 * composite.c (get_composition_id, gstring_lookup_cache)
9214 (composition_gstring_put_cache):
9215 * composite.h (struct composition.hash_index):
9216 * dispextern.h (struct image.hash):
9217 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9218 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9219 (hashfn_equal, hashfn_user_defined, make_hash_table)
9220 (maybe_resize_hash_table, hash_lookup, hash_put)
9221 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9222 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9223 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9224 * image.c (make_image, search_image_cache, lookup_image)
9225 (xpm_put_color_table_h):
9226 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9227 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9228 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9229 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9230 * alloc.c (allocate_vectorlike):
9231 Check for overflow in vector size calculations.
9232 * ccl.c (ccl_driver):
9233 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9234 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9235 need to be updated by these changes.
40087514
PE
9236 * fns.c (make_hash_table, maybe_resize_hash_table):
9237 Check for integer overflow with large hash tables.
0de4bb68
PE
9238 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9239 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9240 (SXHASH_REDUCE): New macro.
9241 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9242 Use it instead of discarding useful hash info with large hash values.
9243 (sxhash_float): New function.
9244 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9245 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9246 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9247 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9248 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9249 Adjust signatures to match updated version of code.
9250 (consing_since_gc): Now EMACS_INT, since a single hash table can
9251 use more than INT_MAX bytes.
9252
698d32e2
DN
92532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9254
9255 Make it possible to build with GCC-4.6+ -O2 -flto.
9256
9257 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9258
fd6fa53f
SM
92592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9260
9261 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9262 Call minibuffer-inactive-mode.
9263
864db017
JB
92642011-05-31 Juanma Barranquero <lekktu@gmail.com>
9265
9266 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9267 Update dependencies.
9268
2ad0baf4
DN
92692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9270
9271 * data.c (init_data): Remove code for UTS, this system is not
9272 supported anymore.
9273
4fcc2638
DN
92742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9275
9276 Don't force ./temacs to start in terminal mode.
9277
9278 * frame.c (make_initial_frame): Initialize faces in all cases, not
9279 only when CANNOT_DUMP is defined.
9280 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9281
c56e0fd5
DN
92822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9283
9284 * dispnew.c (add_window_display_history): Use const for the string
9285 pointer. Remove declaration, not needed.
9286
333d54da 92872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9288
55d4c1b2 9289 Use 'inline', not 'INLINE'.
333d54da 9290 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9291 * alloc.c, fontset.c (INLINE): Remove.
9292 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9293 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9294 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9295 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9296 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9297
738db178
DN
92982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9299
9300 Make it possible to run ./temacs.
9301
9302 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9303 syms_of_callproc does the same thing. Remove test for
9304 "initialized", do it in the caller.
9305 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9306
620c53a6
SM
93072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9308
9309 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9310 (read_minibuf): Use get_minibuffer.
9311 (syms_of_minibuf): Use DEFSYM.
9312 (Qmetadata): New var.
9313 * data.c (Qbuffer): Don't make it static.
9314 (syms_of_data): Use DEFSYM.
9315
e003a292
PE
93162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9317
9318 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9319 (CCL_CODE_MIN): New macro.
9320
ed008a6d
PE
93212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9322
3687c2ef
PE
9323 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9324
ed008a6d
PE
9325 * eval.c (Qdebug): Now static.
9326 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9327 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9328 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9329
d66c4c7c
CY
93302011-05-29 Chong Yidong <cyd@stupidchicken.com>
9331
9332 * image.c: Various fixes to ImageMagick code comments.
9333 (Fimagemagick_types): Doc fix.
9334
5fbc2025
PE
93352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9336
0196f88a
PE
9337 Minor fixes prompted by GCC 4.6.0 warnings.
9338
9339 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9340
5fbc2025
PE
9341 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9342 (x_clipboard_manager_save_all): Move extern decl to ...
9343 * xterm.h: ... here, so that it can be checked for consistency.
9344
1dd3c2d9
CY
93452011-05-29 Chong Yidong <cyd@stupidchicken.com>
9346
9347 * xselect.c (x_clipboard_manager_save_frame)
9348 (x_clipboard_manager_save_all): New functions.
9349 (Fx_clipboard_manager_save): Lisp function deleted.
9350
9351 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9352 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9353
9354 * xterm.h: Update prototype.
9355
5ba6571d
WX
93562011-05-28 William Xu <william.xwl@gmail.com>
9357
9358 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9359 exiting (Bug#8239).
9360
3eaff834
JM
93612011-05-28 Jim Meyering <meyering@redhat.com>
9362
e1900994 9363 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9364 * fns.c (to_uchar): Define.
9365 (crypto_hash_function): Use it to convert some newly-signed
9366 variables to unsigned, to avoid sign-extension bugs. For example,
9367 without this change, (md5 "truc") would evaluate to
9368 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9369 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9370 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9371
0f6990a7
PE
93722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9373
9374 Integer overflow fixes.
c8a9ca5a 9375
08686060
PE
9376 * dbusbind.c: Serial number integer overflow fixes.
9377 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9378 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9379 to hold a serial number that is too large for a fixnum.
9380 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9381 Check for serial numbers out of range. Decode any serial number
59568bf0 9382 that was so large that it became a float. (Bug#8722)
08686060 9383
2d1fc3c7
PE
9384 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9385 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9386 Use XFASTINT rather than XUINT when numbers are nonnegative.
9387 (xd_append_arg, Fdbus_method_return_internal):
9388 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9389 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9390 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9391 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9392 (Bug#8722)
2d1fc3c7 9393
c8a9ca5a
PE
9394 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9395
519e1d69
PE
9396 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9397
6df6ae42 9398 ccl: Add integer overflow checks.
30569699
PE
9399 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9400 (IN_INT_RANGE): New macros.
9401 (ccl_driver): Use them to check for integer overflow when
9402 decoding a CCL program. Many of the new checks are whether XINT (x)
9403 fits in int; it doesn't always, on 64-bit hosts. The new version
9404 doesn't catch all possible integer overflows, but it's an
847044ea 9405 improvement. (Bug#8719)
30569699 9406
c11285dc
PE
9407 * alloc.c (make_event_array): Use XINT, not XUINT.
9408 There's no need for unsigned here.
9409
fdccd48e
PE
9410 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9411 This follows up to the 2011-05-06 change that substituted uintptr_t
9412 for EMACS_INT. This case wasn't caught back then.
9413
37910ab2
PE
9414 Rework Fformat to avoid integer overflow issues.
9415 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9416 now (part of C89). Include <verify.h>.
9417 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9418 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9419 (Fformat): Avoid the prepass trying to compute sizes; it was only
9420 approximate and thus did not catch overflow reliably. Instead, walk
9421 through the format just once, formatting and computing sizes as we go,
9422 checking for integer overflow at every step, and allocating a larger
9423 buffer as needed. Keep track separately whether the format is
9424 multibyte. Keep only the most-recently calculated precision, rather
9425 than them all. Record whether each argument has been converted to
9426 string. Use EMACS_INT, not int, for byte and char and arg counts.
9427 Support field widths and precisions larger than INT_MAX. Avoid
9428 sprintf's undefined behavior with conversion specifications such as %#d
9429 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9430 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9431 formatting out-of-range floating point numbers with int
9173deec 9432 formats. (Bug#8668)
37910ab2 9433
2e6578fb
PE
9434 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9435
0ae6bdee
PE
9436 * data.c: Avoid integer truncation in expressions involving floats.
9437 * data.c: Include <intprops.h>.
9438 (arith_driver): When there's an integer overflow in an expression
9439 involving floating point, convert the integers to floating point
9440 so that the resulting value does not suffer from catastrophic
9441 integer truncation. For example, on a 64-bit host (* 4
9442 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9443 Do not rely on undefined behavior after integer overflow.
9444
de883a70
PE
9445 merge count_size_as_multibyte, parse_str_to_multibyte
9446 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9447 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9448 Check for integer overflow.
9449 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9450 since it's now a duplicate of the other. This is more of
9451 a character than a buffer op, so better that it's in character.c.
9452 * fns.c, print.c: Adjust to above changes.
9453
2ff916cb
PE
94542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9455
9456 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9457
f1b54466
PE
94582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9459
fb1ac845
PE
9460 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9461 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9462 (x_clipboard_manager_save): Now static.
9463 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9464
f1b54466
PE
9465 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9466 (crypto_hash_function): Now static.
9467 Fix pointer signedness problems. Avoid unnecessary initializations.
9468
a9f737ee
CY
94692011-05-27 Chong Yidong <cyd@stupidchicken.com>
9470
9471 * termhooks.h (Vselection_alist): Make it terminal-local.
9472
9473 * terminal.c (create_terminal): Initialize it.
9474
9475 * xselect.c: Support for clipboard managers.
9476 (Vselection_alist): Move to termhooks.h as terminal-local var.
9477 (LOCAL_SELECTION): New macro.
9478 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9479 (symbol_to_x_atom): Remove gratuitous arg.
9480 (x_handle_selection_request, lisp_data_to_selection_data)
9481 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9482 (x_own_selection, x_get_local_selection, x_convert_selection):
9483 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9484 (some_frame_on_display): Delete unused function.
9485 (Fx_own_selection_internal, Fx_get_selection_internal)
9486 (Fx_disown_selection_internal, Fx_selection_owner_p)
9487 (Fx_selection_exists_p): New optional frame arg.
9488 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9489 (x_handle_selection_clear): Don't treat other terminals with the
9490 same keyboard specially. Use the terminal-local Vselection_alist.
9491 (x_clear_frame_selections): Use Frun_hook_with_args.
9492
9493 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9494
9495 * xterm.h: Add support for those atoms.
9496
e067f0c1
CY
94972011-05-26 Chong Yidong <cyd@stupidchicken.com>
9498
9499 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9500 (converted_selections, conversion_fail_tag): New global variables.
9501 (x_selection_request_lisp_error): Free the above.
9502 (x_get_local_selection): Remove unnecessary code.
9503 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9504 of converted selections stored in converted_selections.
9505 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9506 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9507 (x_convert_selection): New function.
9508 (x_handle_selection_event): Simplify.
9509 (x_get_foreign_selection): Don't ignore incoming requests while
9510 waiting for an answer; this will fail when we implement
9511 SAVE_TARGETS, and seems unnecessary anyway.
9512 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9513 (Vx_sent_selection_functions): Doc fix.
9514
0f4aebc0
LL
95152011-05-26 Leo Liu <sdl.web@gmail.com>
9516
9517 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9518
e61124cd
YM
95192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9520
9521 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9522
9523 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9524 for fringe update if it has periodic bitmap.
ac389d0c 9525 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9526 and fringe_bitmap_periodic_p.
9527
9528 * fringe.c (get_fringe_bitmap_data): New function.
9529 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9530 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9531 row. Mark glyph row for fringe update if periodicity changed.
9532
9533 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9534 for fringe update unless it has periodic bitmap.
9535
f16d9837
KH
95362011-05-25 Kenichi Handa <handa@m17n.org>
9537
9538 * xdisp.c (get_next_display_element): Set correct it->face_id for
9539 a static composition.
9540
e1b90ef6
LL
95412011-05-24 Leo Liu <sdl.web@gmail.com>
9542
9543 * deps.mk (fns.o):
9544 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9545
9546 * fns.c (crypto_hash_function, Fsha1): New function.
9547 (Fmd5): Use crypto_hash_function.
9548 (syms_of_fns): Add Ssha1.
9549
7400048f
PE
95502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9551
9552 * gnutls.c: Remove unused macros.
9553 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9554 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9555 Remove macros that are defined and never used.
9556 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9557
abb71cf4
CY
95582011-05-22 Chong Yidong <cyd@stupidchicken.com>
9559
9560 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9561 (Fx_get_selection_internal): Minor cleanup.
9562 (Fx_own_selection_internal): Rename arguments for consistency with
9563 select.el.
9564
6307db39
PE
95652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9566
9567 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9568
f3d4e0a4
CY
95692011-05-22 Chong Yidong <cyd@stupidchicken.com>
9570
9571 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9572
4d8ade89
YM
95732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9574
9575 * dispnew.c (scrolling_window): Don't exclude the case that the
9576 last enabled row in the desired matrix touches the bottom boundary.
9577
32078c8d
GM
95782011-05-21 Glenn Morris <rgm@gnu.org>
9579
9580 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9581 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9582 and add some more files.
32078c8d 9583
7285dc67
EZ
95842011-05-20 Eli Zaretskii <eliz@gnu.org>
9585
9586 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9587 report_file_error introduced by the change from 2011-05-07.
9588
89d1bd22
PE
95892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9590
9591 * systime.h (Time): Define only if emacs is defined.
9592 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9593 where the include path doesn't have X11/X.h by default. See
9594 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9595
cd394be1 95962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9597
9598 * composite.c (find_automatic_composition): Fix previous change.
9599
b9704ad9
GM
96002011-05-20 Glenn Morris <rgm@gnu.org>
9601
9602 * lisp.mk: New file, split from Makefile.in.
9603 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9604 (shortlisp): Remove.
9605 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9606
4a720484
GM
96072011-05-19 Glenn Morris <rgm@gnu.org>
9608
9609 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9610 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9611 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9612 (lisp): Set the order to that of loadup.el.
9613 (shortlisp): Make it a copy of $lisp.
9614 (SOME_MACHINE_LISP): Remove.
9615 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9616 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9617
a28d4396
KH
96182011-05-18 Kenichi Handa <handa@m17n.org>
9619
9620 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9621 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9622 (find_automatic_composition): Mostly rewrite for efficiency.
9623
a2b1fa8e
JB
96242011-05-18 Juanma Barranquero <lekktu@gmail.com>
9625
9626 * makefile.w32-in: Update dependencies.
9627
8e1f5610
CS
96282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9629
9630 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9631 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9632
7025ee00 96332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9634
cdfa6eab
PE
9635 Fix some integer overflow issues, such as string length overflow.
9636
06d6db33
PE
9637 * insdel.c (count_size_as_multibyte): Check for string overflow.
9638
2b4560a8
PE
9639 * character.c (lisp_string_width): Check for string overflow.
9640 Use EMACS_INT, not int, for string indexes and lengths; in
9641 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9642 the resulting string length overflows an EMACS_INT; instead,
9643 report a string overflow if no precision given. When checking for
9644 precision exhaustion, use a check that cannot possibly have
9645 integer overflow. (Bug#8675)
9646 * character.h (lisp_string_width): Adjust to new signature.
9647
cb93f9be
PE
9648 * alloc.c (string_overflow): New function.
9649 (Fmake_string): Use it. This doesn't change behavior, but saves
9650 a few bytes and will simplify future changes.
9651 * character.c (string_escape_byte8): Likewise.
9652 * lisp.h (string_overflow): New decl.
9653
1a1f3366
PE
9654 Fixups, following up to the user-interface timestamp change.
9655 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9656 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9657 * msdos.c (mouse_get_pos): Likewise.
9658 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9659 * w32gui.h (Time): Define by including "systime.h" rather than by
9660 declaring it ourselves. (Bug#8664)
9661
d4e3e4d3
PE
9662 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9663 * image.c (clear_image_cache): Likewise.
9664
f6a24d19
PE
9665 * term.c (term_mouse_position): Don't assume time_t wraparound.
9666
08dc5ae6
PE
9667 Be more systematic about user-interface timestamps.
9668 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9669 and sometimes 'EMACS_UINT', to represent these timestamps.
9670 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9671 This makes the code easier to follow, and makes it easier to catch
9672 integer overflow bugs such as Bug#8664.
9673 * frame.c (Fmouse_position, Fmouse_pixel_position):
9674 Use Time, not unsigned long, for user-interface timestamps.
9675 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9676 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9677 * keyboard.h (last_event_timestamp): Likewise.
9678 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9679 * menu.h (xmenu_show): Likewise.
9680 * term.c (term_mouse_position): Likewise.
9681 * termhooks.h (struct input_event.timestamp): Likewise.
9682 (struct terminal.mouse_position_hook): Likewise.
9683 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9684 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9685 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9686 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9687 what it was before.
9688 * menu.h, termhooks.h: Include "systime.h", for Time.
9689
8e55734a
PE
9690 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9691 Don't assume that the difference between two unsigned long values
9692 can fit into an integer. At this point, we know button_down_time
9693 <= event->timestamp, so the difference must be nonnegative, so
9694 there's no need to cast the result if double-click-time is
9695 nonnegative, as it should be; check that it's nonnegative, just in
9696 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9697 apart (about 25 days). (Bug#8664)
8e55734a 9698
841f1b75 9699 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9700 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9701
3e26f69c
PE
9702 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9703 that always fit in int. Use a sentinel instead of a counter, to
9704 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9705 * frame.h (struct frame): Use int for menu_bar_items_used
9706 instead of EMACS_INT, since it always fits in int.
3e26f69c 9707
5cc152c0
PE
9708 * menu.c (grow_menu_items): Check for int overflow.
9709
d89eb65e
PE
9710 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9711
5235bd3e
PE
9712 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9713 Before, the code was not consistent. These values cannot exceed
9714 2**31 - 1 so there's no need to make them unsigned.
9715 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9716 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9717 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9718 as modifiers.
9719 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9720
bc827e23
PE
9721 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9722 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9723 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9724 presumably because the widths might not match.
9725
78eb494e
PE
9726 * window.c (size_window): Avoid needless test at loop start.
9727
04f2d78b
CB
97282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9729
9730 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9731
d2fc7e3d 97322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9733
9734 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9735
d2fc7e3d 97362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9737
9738 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9739 `width' to `bar_area_x' and `bar_area_width', respectively.
9740 (x_scroll_run): Take account of fringe background extension.
9741
04f2d78b
CB
9742 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9743 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9744 `bar_area_width', respectively.
9745 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9746 background extension.
9747
79b70037
GM
97482011-05-10 Jim Meyering <meyering@redhat.com>
9749
9750 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9751
2f142cc5
JB
97522011-05-10 Juanma Barranquero <lekktu@gmail.com>
9753
9754 * image.c (Finit_image_library): Return t for built-in image types,
9755 like pbm and xbm. (Bug#8640)
9756
57679c86
AS
97572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9758
9759 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9760
888c9e86
EZ
97612011-05-07 Eli Zaretskii <eliz@gnu.org>
9762
b0512a1d
EZ
9763 * w32console.c (Fset_screen_color): Doc fix.
9764 (Fget_screen_color): New function.
9765 (syms_of_ntterm): Defsubr it.
9766
7285dc67
EZ
9767 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9768 unlink the temporary file if Fcall_process didn't create it in the
9769 first place.
9770 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9771 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9772 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9773 cue to call_process_cleanup not to close that handle.
9774
4d3fcc8e
BK
97752011-05-07 Ben Key <bkey76@gmail.com>
9776
9777 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9778 one of two shell specific rules, either bootstrap-temacs-CMD or
9779 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9780 to the previous implementation of the bootstrap-temacs rule.
9781 The bootstrap-temacs-CMD rule is similar to the previous
9782 implementation of the bootstrap-temacs rule except that it
9783 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9784 variable.
9785
9786 These changes, along with some changes to nt/configure.bat,
9787 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9788 earlier fix to add support for --cflags and --ldflags options
9789 that include quotes so that it works whether make uses cmd or
9790 sh as the shell.
9791
b4289b64
MA
97922011-05-06 Michael Albinus <michael.albinus@gmx.de>
9793
9794 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9795 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9796 is a constant.
9797 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9798 a string. Handle both cases.
9799 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9800 (Fdbus_register_method): Use Qinvalid_function.
9801
af4c0e28
JB
98022011-05-06 Juanma Barranquero <lekktu@gmail.com>
9803
9804 * makefile.w32-in: Update dependencies.
9805 (LISP_H): Add inttypes.h and stdin.h.
9806 (PROCESS_H): Add unistd.h.
9807
c51453d9
EZ
98082011-05-06 Eli Zaretskii <eliz@gnu.org>
9809
9810 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9811 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9812
8ff0ac3c 98132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9814
4c4b566b
PE
9815 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9816
aab2b9b5
PE
9817 * term.c (vfatal): Remove stray call to va_end.
9818 It's not needed and the C Standard doesn't allow it here anyway.
9819
c378da0b
PE
9820 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9821 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9822
288b08c7
PE
9823 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9824 bytes.
9825
e3601888
PE
9826 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9827
db6c0e74
PE
9828 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9829
dd5963ea
PE
9830 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9831
88c9450f
PE
9832 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9833
2f9442b8
PE
9834 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9835
c032b5f8
PE
9836 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9837 * charset.c (Fdefine_charset_internal): Don't initialize
9838 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9839 32-bit int (Bug#8600).
a108c10b
PE
9840
9841 * lread.c (read_integer): Be more consistent with string-to-number.
9842 Use string_to_number to do the actual conversion; this avoids
9843 rounding errors and fixes some other screwups. Without this fix,
9844 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9845 (digit_to_number): Move earlier, for benefit of read_integer.
9846 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9847 not a digit in any supported base. (Bug#8602)
a108c10b 9848
ad5f9eea
PE
9849 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9850
aec1708a
PE
9851 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9852 to match comment at start of function. This also removes a
9853 GCC warning about overflow in a 32+64-bit port.
9854
47be4ab5
PE
9855 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9856
371cac43
PE
9857 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9858 Reported by Stefan Monnier in
9859 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9860 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9861 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9862
d01a7826
PE
9863 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9864 (EMACS_UINTPTR): Likewise, with uintptr_t.
9865
7fd47d5c
PE
9866 * lisp.h: Prefer 64-bit EMACS_INT if available.
9867 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9868 on 32-bit hosts that have 64-bit int, so that they can access
9869 large files.
122b0c86
PE
9870 However, temporarily disable this change unless the temporary
9871 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9872
8727937b
PE
9873 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9874
8ac068ac
PE
9875 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9876 This removes an assumption that EMACS_INT and long are the same
9877 width as pointers. The assumption is true for Emacs porting targets
9878 now, but we want to make other targets possible.
9879 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9880 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9881 In the rest of the code, change types of integers that hold casted
9882 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9883 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9884 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9885 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9886 No need to cast type when ORing.
9887 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9888 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9889 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9890 assume EMACS_INT is the same width as char *.
9891 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9892 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9893 Remove no-longer-needed casts.
9894 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9895 (xg_tool_bar_help_callback, xg_make_tool_item):
9896 Use EMACS_INTPTR to hold an integer
9897 that will be cast to void *; this can avoid a GCC warning
9898 if EMACS_INT is not the same width as void *.
9899 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9900 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9901 (current_message_1, set_message_1):
9902 Use a local to convert to proper width without a cast.
9903 * xmenu.c (dialog_selection_callback): Likewise.
9904
ede49d71
PE
9905 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9906 Also, don't assume VALBITS / RAND_BITS is less than 5,
9907 and don't rely on undefined behavior when shifting a 1 left into
9908 the sign bit.
9909 * lisp.h (get_random): Change signature to match.
9910
2f30ecd0
PE
9911 * lread.c (hash_string): Use size_t, not int, for hash computation.
9912 Normally we prefer signed values; but hashing is special, because
9913 it's better to use unsigned division on hash table sizes so that
9914 the remainder is nonnegative. Also, size_t is the natural width
9915 for hashing into memory. The previous code used 'int', which doesn't
9916 retain enough info to hash well into very large tables.
9917 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9918
2a866e7b
PE
9919 * dbusbind.c: Don't possibly lose pointer info when converting.
9920 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9921 Use XPNTR rather than XHASH, so that the high-order bits of
9922 the pointer aren't lost when converting through void *.
9923
51639eac
PE
9924 * eval.c (Fautoload): Don't double-shift a pointer.
9925
92394119
PE
9926 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9927
dbdb9a7c
JB
99282011-05-06 Juanma Barranquero <lekktu@gmail.com>
9929
9930 * gnutls.c (DEF_GNUTLS_FN):
9931 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9932
db7a0b4f
AS
99332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9934
9935 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9936 marker. (Bug#8610)
9937
cd394be1 99382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9939
9940 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9941 New version that can reserve upto 2GB of heap space.
9942
f7ff1b0f 99432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9944
9945 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9946
639c109b
TZ
99472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9948
9949 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9950 `gnutls_certificate_set_x509_key_file'.
9951
d2127135
JB
99522011-05-05 Juanma Barranquero <lekktu@gmail.com>
9953
9954 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9955 Update dependencies.
9956
e968f4f3
JB
99572011-05-04 Juanma Barranquero <lekktu@gmail.com>
9958
9959 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9960 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9961 Remove unused parameter `fildes'.
9962 * process.c (read_process_output, send_process): Don't pass it.
9963
84d358f0
JB
99642011-05-04 Juanma Barranquero <lekktu@gmail.com>
9965
9966 Fix previous change: the library cache is defined in w32.c.
9967 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9968 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9969
0898ca10
JB
99702011-05-04 Juanma Barranquero <lekktu@gmail.com>
9971
9972 Implement dynamic loading of GnuTLS on Windows.
9973
9974 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9975 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9976 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9977 Declare.
9978
9979 * gnutls.c (Qgnutls_dll): Define.
9980 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9981 (gnutls_*): Declare function pointers.
9982 (init_gnutls_functions): New function to initialize function pointers.
9983 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9984 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9985 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9986 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9987 (emacs_gnutls_write, emacs_gnutls_read)
9988 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9989 (Fgnutls_available_p): New function.
9990 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9991 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9992 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9993
9994 * image.c: Include w32.h.
9995 (Vimage_type_cache): Delete.
9996 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9997 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9998 (w32_delayed_load): Move to w32.c.
9999
10000 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10001
10002 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10003 (w32_delayed_load): Move from image.c. When loading a library, record
10004 its filename in the :loaded-from property of the library id.
10005 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10006 Initialize and staticpro them.
10007 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10008
10009 * process.c: Include lisp.h before w32.h, not after.
10010 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10011 instead of gnutls_record_check_pending.
10012
10013 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10014
ff4de4aa
TZ
100152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10016
10017 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10018 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10019 as passed in.
10020
abe95abb
JD
100212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10022
10023 * xterm.c (x_set_frame_alpha): Do not set property on anything
10024 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10025
e16e55d4
JB
100262011-05-02 Juanma Barranquero <lekktu@gmail.com>
10027
10028 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10029
bafcf6a5
JB
100302011-05-02 Juanma Barranquero <lekktu@gmail.com>
10031
10032 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10033 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10034 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10035 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10036 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10037 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10038 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10039 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10040 (Qgnutls_bootprop_callbacks_verify): Make static.
10041
e7a6747f
AS
100422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10043
19ed11ba
AS
10044 * callproc.c: Indentation fixup.
10045
e7a6747f 10046 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10047 (wait_for_termination, interruptible_wait_for_termination):
10048 Move after wait_for_termination_1.
e7a6747f 10049
1ef14cb4
LMI
100502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10051
10052 * sysdep.c (interruptible_wait_for_termination): New function
10053 which is like wait_for_termination, but allows keyboard
10054 interruptions.
10055
10056 * callproc.c (Fcall_process): Add (:file "file") as an option for
10057 the STDOUT buffer.
10058 (Fcall_process_region): Ditto.
10059
330d880c
EZ
100602011-04-30 Eli Zaretskii <eliz@gnu.org>
10061
8db90b73
EZ
10062 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10063 rather than `XVECTOR (FOO)->size'.
10064
330d880c
EZ
10065 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10066 inttypes.h, as a gnulib replacement is used if it not available in
10067 system headers.
10068
15cbd324
EZ
100692011-04-21 Eli Zaretskii <eliz@gnu.org>
10070
10071 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10072 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10073 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10074
10075 * coding.c (coding_alloc_by_realloc): Error out if destination
10076 will grow beyond MOST_POSITIVE_FIXNUM.
10077 (decode_coding_emacs_mule): Abort if there isn't enough place in
10078 charbuf for the composition carryover bytes. Reserve an extra
10079 space for up to 2 characters produced in a loop.
10080 (decode_coding_iso_2022): Abort if there isn't enough place in
10081 charbuf for the composition carryover bytes.
10082
100832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10084
ae940cca
EZ
10085 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10086 aborting when %lld or %lll format is passed.
10087 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10088 %llo or %llx format is passed. (Bug#8545)
10089
03ab8921
EZ
10090 * window.c (window_scroll_line_based): Use a marker instead of
10091 simple variables to record original value of point. (Bug#7952)
10092
afda1437
EZ
10093 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10094 produced by %s or %c overflows available buffer space. (Bug#8545)
10095
f76dee0c
PE
100962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10097
10098 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10099 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10100
fdc5744d
JB
101012011-04-28 Juanma Barranquero <lekktu@gmail.com>
10102
10103 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10104
638f053a
JB
101052011-04-28 Juanma Barranquero <lekktu@gmail.com>
10106
10107 * keyboard.c (Qdelayed_warnings_hook): Define.
10108 (command_loop_1): Run `delayed-warnings-hook'
10109 if Vdelayed_warnings_list is non-nil.
10110 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10111 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10112
d178f871
EZ
101132011-04-28 Eli Zaretskii <eliz@gnu.org>
10114
10115 * doprnt.c (doprnt): Don't return value smaller than the buffer
10116 size if the message was truncated. (Bug#8545).
10117
b124fd93
JB
101182011-04-28 Juanma Barranquero <lekktu@gmail.com>
10119
10120 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10121 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10122
e810457d
PE
101232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10124
10125 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10126
ea51cceb
JB
101272011-04-27 Juanma Barranquero <lekktu@gmail.com>
10128
10129 * makefile.w32-in: Update dependencies.
10130
94dcfacf
EZ
101312011-04-27 Eli Zaretskii <eliz@gnu.org>
10132
10133 Improve `doprnt' and its usage. (Bug#8545)
10134 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10135 `format_end'. Remove support for %l as a conversion specifier.
10136 Don't use xrealloc. Improve diagnostics when the %l size modifier
10137 is used. Update the commentary.
10138
10139 * eval.c (verror): Simplify calculation of size_t.
10140
10141 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10142 messages.
10143
f61f41d7
PE
101442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10145
10146 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10147 change.
10148
96fb4434
PE
101492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10150
10151 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10152 This makes this file independent of the recent pseudovector change.
10153
671875da 101542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10155
69e9b5a3
PE
10156 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10157
b5f869a7 10158 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10159 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10160 Remove unused local.
c8926152 10161 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10162
841a1577 10163 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10164 GCC 4.6.0 optimizes based on type-based alias analysis.
10165 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10166 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10167 != &v->size, and therefore "v->size = 1; b->size = 2; return
10168 v->size;" must therefore return 1. This assumption is incorrect
10169 for Emacs, since it type-puns struct Lisp_Vector * with many other
10170 types. To fix this problem, this patch adds a new type struct
f904488f 10171 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10172 and pseudovectors, and helps optimizing compilers not get fooled
10173 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10174 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10175 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10176 the size member.
eab3844f
PE
10177 (XSETPVECTYPE): Rewrite in terms of new macro.
10178 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10179 This is a bit clearer, and further avoids the possibility of
10180 undesirable aliasing.
10181 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10182 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10183 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10184 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10185 (ASIZE): Now uses header.size rather than size.
10186 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10187 to avoid the hassle of writing XVECTOR (foo)->header.size.
10188 (struct vectorlike_header): New type.
eab3844f
PE
10189 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10190 object, to help avoid aliasing.
10191 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10192 (SUBRP): Likewise, since Lisp_Subr is a special case.
10193 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10194 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10195 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10196 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10197 changed to be "header.size" and "header.next".
10198 * buffer.h (struct buffer): Likewise.
10199 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10200 * frame.h (struct frame): Likewise.
10201 * process.h (struct Lisp_Process): Likewise.
10202 * termhooks.h (struct terminal): Likewise.
10203 * window.c (struct save_window_data, struct saved_window): Likewise.
10204 * window.h (struct window): Likewise.
10205 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10206 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10207 * buffer.c (init_buffer_once): Likewise.
10208 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10209 special case.
10210 * process.c (Fformat_network_address): Use local var for size,
10211 for brevity.
10212
0df1eac5
PE
10213 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10214
847ab9d1 10215 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10216 * data.c (atof): Remove decl; no longer used or needed.
10217 (digit_to_number): Move to lread.c.
10218 (Fstring_to_number): Use new string_to_number function, to be
10219 consistent with how the Lisp reader treats infinities and NaNs.
10220 Do not assume that floating-point numbers represent EMACS_INT
10221 without losing information; this is not true on most 64-bit hosts.
10222 Avoid double-rounding errors, by insisting on integers when
10223 parsing non-base-10 numbers, as the documentation specifies.
10224 * lisp.h (string_to_number): New decl, replacing ...
10225 (isfloat_string): Remove.
bc0a5c13 10226 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10227 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10228 appears to have been a coding error. Similarly, do not accept
10229 strings like +-1e0 as floating point numbers. Do not report
10230 overflow for integer overflows unless the base is not 10 which
10231 means we have no simple and reliable way to continue.
10232 Break out the floating-point parsing into a new
10233 function string_to_number, so that Fstring_to_number parses
10234 floating point numbers consistently with the Lisp reader.
04f2d78b 10235 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10236 (E_CHAR, EXP_INT): Remove, replacing with ...
10237 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10238 (string_to_number): New function, replacing isfloat_string.
10239 This function checks for valid syntax and produces the resulting
10240 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10241 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10242 so that overflow for non-base-10 numbers is reported only when
10243 there's no portable and simple way to convert to floating point.
452f4150 10244
67769ffc
PE
10245 * textprop.c (set_text_properties_1): Rewrite for clarity,
10246 and to avoid GCC warning about integer overflow.
10247
c20db43f
PE
10248 * intervals.h (struct interval): Use EMACS_INT for members
10249 where EMACS_UINT might cause problems. See
10250 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10251 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10252 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10253 All uses changed.
37aa2f85
PE
10254 (offset_intervals): Tell GCC not to worry about length overflow
10255 when negating a negative length.
c20db43f 10256
2538aa2f
PE
10257 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10258 (overrun_check_free): Likewise.
10259
f2d3008d
PE
10260 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10261 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10262 word size.
10263
ec8df744
PE
10264 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10265 (gnutls_make_error): Rename local to avoid shadowing.
10266 (gnutls_emacs_global_deinit): ifdef out; not used.
10267 (Fgnutls_boot): Use const for pointer to readonly storage.
10268 Comment out unused local. Fix pointer signedness problems.
10269
640ee02d
PE
10270 * lread.c (openp): Don't stuff size_t into an 'int'.
10271 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10272 about possible signed overflow.
10273
6048fb2a
PE
10274 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10275 (GDK_KEY_g): Don't define if already defined.
10276 (xg_prepare_tooltip): Avoid pointer signedness problem.
10277 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10278
fa3c87e1
PE
10279 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10280 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10281
2172544b
PE
10282 * xfns.c (Fx_window_property): Simplify a bit,
10283 to make a bit faster and to avoid GCC 4.6.0 warning.
10284 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10285
9b821a21
PE
10286 * fns.c (internal_equal): Don't assume size_t fits in int.
10287
3c616cfa
PE
10288 * alloc.c (compact_small_strings): Tighten assertion a little.
10289
c2982e87
PE
10290 Replace pEd with more-general pI, and fix some printf arg casts.
10291 * lisp.h (pI): New macro, generalizing old pEd macro to other
10292 conversion specifiers. For example, use "...%"pI"d..." rather
10293 than "...%"pEd"...".
10294 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10295 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10296 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10297 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10298 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10299 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10300 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10301 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10302 64-bit hosts.
10303 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10304 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10305 * print.c (safe_debug_print, print_object): Likewise.
10306 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10307 to int.
6f04d126
PE
10308 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10309 avoiding the 0 flag, which is not portable.
c2982e87
PE
10310 * process.c (Fmake_network_process): Use pI to avoid cast.
10311 * region-cache.c (pp_cache): Likewise.
10312 * xdisp.c (decode_mode_spec): Likewise.
10313 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10314 behavior on 64-bit hosts with printf arg.
6f04d126 10315 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10316 (x_stop_queuing_selection_requests): Likewise.
10317 (x_get_window_property): Don't truncate byte count to an 'int'
10318 when tracing.
0b432f21 10319
5e073ec7
PE
10320 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10321 here, since it parses constructs like leading '-' and spaces,
10322 which are not wanted; and it overflows with large numbers.
10323 Instead, simply match F[0-9]+, which is what is wanted anyway.
10324
36372bf9
PE
10325 * alloc.c: Remove unportable assumptions about struct layout.
10326 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10327 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10328 (allocate_vectorlike, make_pure_vector): Use the new macros,
10329 plus offsetof, to remove unportable assumptions about struct layout.
10330 These assumptions hold on all porting targets that I know of, but
10331 they are not guaranteed, they're easy to remove, and removing them
10332 makes further changes easier.
10333
0b432f21
PE
10334 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10335 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10336 (string_overrun_cookie): Now const. Use initializers that
10337 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10338 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10339 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10340 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10341 multiple of sizeof (EMACS_INT); it need not be, if
10342 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10343 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10344
895009e1
JB
103452011-04-26 Juanma Barranquero <lekktu@gmail.com>
10346
10347 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10348
6a7a1b0b
TZ
103492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10350
10351 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10352 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10353 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10354
841a1577 103552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10356
10357 * lisp.h (Qdebug): List symbol.
895009e1 10358 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10359 * keyboard.c (debug-on-event): New variable.
10360 (handle_user_signal): Break into debugger when debug-on-event
10361 matches the current signal symbol.
10362
f2d3ba6f
DN
103632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10364
10365 * alloc.c (check_sblock, check_string_bytes)
10366 (check_string_free_list): Convert to standard C.
10367
42ce4c63
TZ
103682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10369
10370 * w32.c (emacs_gnutls_push): Fix typo.
10371
825cd63c
EZ
103722011-04-25 Eli Zaretskii <eliz@gnu.org>
10373
fb11d64d
EZ
10374 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10375 "cast to pointer from integer of different size".
10376
825cd63c
EZ
10377 Improve doprnt and its use in verror. (Bug#8545)
10378 * doprnt.c (doprnt): Document the set of format control sequences
10379 supported by the function. Use SAFE_ALLOCA instead of always
10380 using `alloca'.
10381
10382 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10383 is one byte too soon. Don't use xrealloc; instead xfree and
10384 xmalloc anew.
10385
e061a11b
TZ
103862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10387
10388 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10389 callbacks stage.
10390
10391 * gnutls.c: Renamed global_initialized to
10392 gnutls_global_initialized. Added internals for the
10393 :verify-hostname-error, :verify-error, and :verify-flags
10394 parameters of `gnutls-boot' and documented those parameters in the
10395 docstring. Start callback support.
9173deec
JB
10396 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10397 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10398 on error. Return error code.
e061a11b
TZ
10399 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10400 (emacs_gnutls_read): Likewise.
10401 (Fgnutls_boot): Return handshake error code.
10402 (emacs_gnutls_handle_error): New function.
10403 (wsaerror_to_errno): Likewise.
10404
10405 * w32.h (emacs_gnutls_pull): Add prototype.
10406 (emacs_gnutls_push): Likewise.
10407
10408 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10409 (emacs_gnutls_push): Likewise.
10410
104112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10412
10413 * process.c (wait_reading_process_output): Check if GnuTLS
10414 buffered some data internally if no FDs are set for TLS
10415 connections.
10416
10417 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10418 (LIBS): Link to USER_LIBS.
10419 ($(BLD)/gnutls.$(0)): New target.
10420
fa6996bc
EZ
104212011-04-24 Eli Zaretskii <eliz@gnu.org>
10422
eb35682e
EZ
10423 * xdisp.c (handle_single_display_spec): Rename the
10424 display_replaced_before_p argument into display_replaced_p, to
10425 make it consistent with the commentary. Fix typos in the
10426 commentary.
10427
e2ad650c
EZ
10428 * textprop.c (syms_of_textprop): Remove dead code.
10429 (copy_text_properties): Delete obsolete commentary about an
10430 interface that was deleted long ago. Fix typos in the description
10431 of arguments.
10432
1b2de274
EZ
10433 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10434 to changes in oldXMenu/XMenu.h from 2011-04-16.
10435 <menu_help_message, prev_menu_help_message>: Constify.
10436 (IT_menu_make_room): menu->help_text is now `const char **';
10437 adjust.
10438
10439 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10440 to changes in oldXMenu/XMenu.h from 2011-04-16.
10441 (struct XMenu): Declare `help_text' `const char **'.
10442
10443 * xfaces.c <Qunspecified>: Make extern again.
10444
10445 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10446 required by POSIX.
1b2de274 10447
762b15be
EZ
10448 * doc.c (get_doc_string): Improve the format passed to `error'.
10449
10450 * doprnt.c (doprnt): Improve commentary.
10451
10452 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10453
10454 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10455 them with etags.
10456
f1052e5d
EZ
10457 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10458 changes in globals.h immediately force recompilation.
762b15be
EZ
10459 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10460 $(CURDIR)/s/ms-w32.h.
10461 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10462
fa6996bc
EZ
10463 * character.c (Fchar_direction): Function deleted.
10464 (syms_of_character): Don't defsubr it.
10465 <char-direction-table>: Deleted.
10466
e6c3da20
EZ
104672011-04-23 Eli Zaretskii <eliz@gnu.org>
10468
10469 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10470 * doprnt.c: Include limits.h.
10471 (SIZE_MAX): New macro.
04f2d78b
CB
10472 (doprnt): Return a size_t value. 2nd arg is now size_t.
10473 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10474 Improve overflow protection. Support `l' modifier for integer
10475 conversions. Support %l conversion. Don't assume an EMACS_INT
10476 argument for integer conversions and for %c.
10477
10478 * lisp.h (doprnt): Restore prototype.
10479
10480 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10481 $(SRC)/character.h.
10482
10483 * Makefile.in (base_obj): Add back doprnt.o.
10484
10485 * deps.mk (doprnt.o): Add back prerequisites.
10486 (callint.o): Depend on character.h.
10487
10488 * eval.c (internal_lisp_condition_case): Include the handler
10489 representation in the error message.
10490 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10491 when breaking from the loop.
10492
10493 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10494
10495 * callint.c (Fcall_interactively): When displaying error message
10496 about invalid control letter, pass the character's codepoint, not
10497 a pointer to its multibyte form. Improve display of the character
10498 in octal and display also its hex code.
10499
10500 * character.c (char_string): Use %x to display the (unsigned)
10501 codepoint of an invalid character, to avoid displaying a bogus
10502 negative value.
10503
10504 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10505 `error', not SYMBOL_NAME itself.
10506
10507 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10508 character arguments to `error'.
10509
10510 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10511 to `error' in error message about FINAL_CHAR argument. Make sure
10512 FINAL_CHAR is a character, and use %c when it is passed as
10513 argument to `error'.
10514
4ffd0d6b 105152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10516
10517 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10518
10519 * w32.c: Include <time.h>.
10520 (sys_localtime): New function.
10521
4ffd0d6b 105222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10523
10524 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10525
4ffd0d6b 10526 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10527
4ffd0d6b 105282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10529
4ffd0d6b
GM
10530 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10531 zombies (Bug#8467).
aac0c6e3 10532
04c56954
EZ
105332011-04-19 Eli Zaretskii <eliz@gnu.org>
10534
10535 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10536 gl_state.e_property when gl_state.object is Qt.
10537
10538 * insdel.c (make_gap_larger): Remove limitation of buffer size
10539 to <= INT_MAX.
10540
16a43933
CY
105412011-04-18 Chong Yidong <cyd@stupidchicken.com>
10542
10543 * xdisp.c (lookup_glyphless_char_display)
10544 (produce_glyphless_glyph): Handle cons cell entry in
10545 glyphless-char-display.
10546 (Vglyphless_char_display): Document it.
10547
10548 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10549 glyphless-char-display.
10550
4581706e
CY
105512011-04-17 Chong Yidong <cyd@stupidchicken.com>
10552
10553 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10554
10555 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10556
10557 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10558 definition for no-X builds.
10559
4887c6e2 105602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10561
fd35b6f9
PE
10562 Static checks with GCC 4.6.0 and non-default toolkits.
10563
5c1ccb01
PE
10564 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10565
006c5daa
PE
10566 * process.c (keyboard_bit_set): Define only if SIGIO.
10567 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10568 (send_process): Repair possible setjmp clobbering.
10569
efc736d3
PE
10570 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10571
4e2fe2e6
PE
10572 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10573
f97334a2
PE
10574 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10575
4e75f29d
PE
10576 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10577 Define only if needed.
10578
90efadd1
PE
10579 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10580 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10581 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10582
3c647824
PE
10583 * dispextern.h (struct redisplay_interface): Rename param
10584 to avoid shadowing.
e264f262 10585 * termhooks.h (struct terminal): Likewise.
761383f4 10586 * xterm.c (xembed_send_message): Likewise.
3c647824 10587
b58c5c4a
PE
10588 * insdel.c (make_gap_smaller): Define only if
10589 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10590
cad59032
PE
10591 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10592 it.
10593
c339dc2e
PE
10594 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10595 so that we aren't warned about unused symbols.
10596
91a3e27b
PE
10597 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10598
399c71d3 10599 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10600
8ffc96f5
PE
10601 * xfns.c (x_real_positions): Mark locals as initialized.
10602
eef9bc79
PE
10603 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10604
098db9dd
PE
10605 * xterm.c: Fix problems found by static analysis with other toolkits.
10606 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10607 (x_dispatch_event): Declare static if USE_GTK, and
10608 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10609 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10610 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10611 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10612 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10613
eb18f6cc
PE
10614 * xmenu.c (menu_help_callback): Pointer type fixes.
10615 Use const pointers when pointing at readonly data. Avoid pointer
10616 signedness clashes.
10617 (FALSE): Remove unused macro.
10618 (update_frame_menubar): Remove unused decl.
10619
1fe72bf8
PE
10620 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10621
60d9e1db
PE
10622 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10623 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10624 (single_menu_item): Rename local to avoid shadowing.
10625
39261c26
PE
10626 * keyboard.c (make_lispy_event): Remove unused local var.
10627
018c5e19
PE
10628 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10629 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10630
63d2b86e
PE
10631 * bitmaps: Change bitmaps from unsigned char back to the X11
10632 compatible char. Avoid the old compiler warnings about
10633 out-of-range initializers by using, for example, '\xab' rather
10634 than 0xab.
10635
aefd87e1
PE
10636 * xgselect.c (xgselect_initialize): Check vs interface
10637 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10638
bf501fb9
PE
10639 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10640
e9829fdf
PE
10641 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10642 to read-only memory.
10643
1086c095
PE
10644 * fns.c (vector): Remove; this old hack is no longer needed.
10645
2baccd04 10646 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10647 Remove unused var.
dde42981 10648 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10649
72391843 10650 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10651
436c16df 10652 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10653 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10654 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10655
92bb796d 10656 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10657 (x_term_init): Remove local to avoid shadowing.
92bb796d 10658
764430a3 10659 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10660
10661 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10662 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10663
d1dfb56c
EZ
106642011-04-16 Eli Zaretskii <eliz@gnu.org>
10665
c4354cb4
EZ
10666 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10667
d1dfb56c
EZ
10668 Fix regex.c, syntax.c and friends for buffers > 2GB.
10669 * syntax.h (struct gl_state_s): Declare character position members
10670 EMACS_INT.
10671
10672 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10673
04f2d78b
CB
10674 * textprop.c (verify_interval_modification, interval_of):
10675 Declare arguments EMACS_INT.
d1dfb56c
EZ
10676
10677 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10678 EMACS_INT.
10679
10680 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10681
10682 * indent.c (Fvertical_motion): Local variable it_start is now
10683 EMACS_INT.
10684
10685 * regex.c (re_match, re_match_2, re_match_2_internal)
10686 (bcmp_translate, regcomp, regexec, print_double_string)
10687 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10688 (re_compile_pattern, re_exec): Declare arguments and local
10689 variables `size_t' and `ssize_t' and return values `regoff_t', as
10690 appropriate.
10691 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10692 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10693 <compile_stack_type>: `size' and `avail' are now `size_t'.
10694
10695 * regex.h <regoff_t>: Use ssize_t, not int.
10696 (re_search, re_search_2, re_match, re_match_2): Arguments that
10697 specify buffer/string position and length are now ssize_t and
10698 size_t. Return type is regoff_t.
10699
613052cd
BK
107002011-04-16 Ben Key <bkey76@gmail.com>
10701
10702 * nsfont.m: Fixed bugs in ns_get_family and
10703 ns_descriptor_to_entity that were caused by using free to
10704 deallocate memory blocks that were allocated by xmalloc (via
10705 xstrdup). This caused Emacs to crash when compiled with
10706 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10707 --enable-checking=xmallocoverrun). xfree is now used to
10708 deallocate these memory blocks.
10709
4170f62f 107102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10711
71b41406
PE
10712 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10713
9587a89d
PE
10714 emacs_write: Accept and return EMACS_INT for sizes.
10715 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10716 et seq.
10717 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10718 Accept and return EMACS_INT.
10719 (emacs_gnutls_write): Return the number of bytes written on
10720 partial writes.
10721 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10722 (emacs_read, emacs_write): Remove check for negative size, as the
10723 Emacs source code has been audited now.
9587a89d
PE
10724 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10725 (emacs_read, emacs_write): Use it.
273a5f82
PE
10726 * process.c (send_process): Adjust to the new signatures of
10727 emacs_write and emacs_gnutls_write. Do not attempt to store
10728 a byte offset into an 'int'; it might overflow.
9587a89d 10729 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10730
3e047f51
PE
10731 * sound.c: Don't assume sizes fit in 'int'.
10732 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10733 Return EMACS_INT, not int.
3e047f51 10734 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10735 Accept EMACS_INT, not int.
10736 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10737 record read return values.
10738
cc39a9db
BK
107392011-04-15 Ben Key <bkey76@gmail.com>
10740
c9d0ec6d
JB
10741 * keyboard.c (Qundefined): Don't declare static since it is used
10742 in nsfns.m.
10743 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10744 static since they are used in nsfont.m.
cc39a9db 10745
6c60eb9f
SM
107462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10747
10748 * process.c (Qprocessp): Don't declare static.
10749 * lisp.h (Qprocessp): Declare again.
10750
7990b61a
JB
107512011-04-15 Juanma Barranquero <lekktu@gmail.com>
10752
10753 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10754
5d4cb038
PE
107552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10756
8bd7b830 10757 Improve C-level modularity by making more things 'static'.
cd64ea1d 10758
e3b27b31
PE
10759 Don't publish debugger-only interfaces to other modules.
10760 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10761 (verify_bytepos, count_markers): Move decls to the only modules
10762 that need them.
10763 * region-cache.h (pp_cache): Likewise.
10764 * window.h (check_all_windows): Likewise.
10765 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10766
5d4cb038
PE
10767 * sysdep.c (croak): Now static, if
10768 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10769 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10770
10771 * alloc.c (refill_memory_reserve): Now static if
10772 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10773 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10774
e87b6180
PE
10775 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10776 Define only if USE_LUCID.
10777
ac64929e
PE
10778 * xrdb.c (x_customization_string, x_rm_string): Now static.
10779
6f37259d
PE
10780 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10781 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10782
1683e3ab
PE
10783 * xdisp.c (draw_row_with_mouse_face): Now static.
10784 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10785
de9c2632
PE
10786 * window.h (check_all_windows): Mark externally visible.
10787
2b96acb7
PE
10788 * window.c (window_deletion_count): Now static.
10789
10790 * undo.c: Make symbols static if they're not exported.
10791 (last_undo_buffer, last_boundary_position, pending_boundary):
10792 Now static.
10793
50436f33
PE
10794 * textprop.c (interval_insert_behind_hooks): Now static.
10795 (interval_insert_in_front_hooks): Likewise.
10796
64520e5c
PE
10797 * term.c: Make symbols static if they're not exported.
10798 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10799 (max_frame_lines, tty_set_terminal_modes):
10800 (tty_reset_terminal_modes, tty_turn_off_highlight):
10801 (get_tty_terminal): Now static.
10802 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10803 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10804 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10805 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10806 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10807
1fa53021
PE
10808 * sysdep.c: Make symbols static if they're not exported.
10809 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10810 Now static.
10811 (sigprocmask_set, full_mask): Remove; unused.
10812 (wait_debugging): Mark as visible.
10813 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10814 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10815
d4b43b22
PE
10816 * syntax.c (syntax_temp): Define only if !__GNUC__.
10817
b7c513d0
PE
10818 * sound.c (current_sound_device, current_sound): Now static.
10819
989b29ad
PE
10820 * search.c (searchbufs, searchbuf_head): Now static.
10821
13a55a78
PE
10822 * scroll.c (scroll_cost): Remove; unused.
10823 * dispextern.h (scroll_cost): Remove decl.
10824
de68a1fc
PE
10825 * region-cache.h (pp_cache): Mark as externally visible.
10826
40ccffa6
PE
10827 * process.c: Make symbols static if they're not exported.
10828 (process_tick, update_tick, create_process, chan_process):
10829 (Vprocess_alist, proc_buffered_char, datagram_access):
10830 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10831 (deactivate_process): Mark defn as static, as well as decl.
10832 * lisp.h (create_process): Remove decl.
10833 * process.h (chan_process, Vprocess_alist): Remove decls.
10834
ad64fc97
PE
10835 * print.c: Make symbols static if they're not exported.
10836 (print_depth, new_backquote_output, being_printed, print_buffer):
10837 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10838 (print_interval, print_number_index, initial_stderr_stream):
10839 Now static.
10840 * lisp.h (Fprinc): Remove decl.
10841 (debug_output_compilation_hack): Mark as externally visible.
10842
adddb265
PE
10843 * sysdep.c (croak): Move decl from here to syssignal.h.
10844 * syssignal.h (croak): Put it here, so the API can be checked when
10845 'croak' is called from dissociate_if_controlling_tty.
10846
1717ede2
PE
10847 * minibuf.c: Make symbols static if they're not exported.
10848 (minibuf_save_list, choose_minibuf_frame): Now static.
10849 * lisp.h (choose_minibuf_frame): Remove decl.
10850
fa5fb2bc
PE
10851 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10852
1e3890d1
PE
10853 * lread.c: Make symbols static if they're not exported.
10854 (read_objects, initial_obarray, oblookup_last_bucket_number):
10855 Now static.
10856 (make_symbol): Remove; unused.
10857 * lisp.h (initial_obarray, make_symbol): Remove decls.
10858
8a1414fa
PE
10859 * keyboard.c: Make symbols static if they're not exported.
10860 (single_kboard, recent_keys_index, total_keys, recent_keys):
10861 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10862 (this_single_command_key_start, echoing, last_auto_save):
10863 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10864 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10865 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10866 (Vlispy_mouse_stem, double_click_count):
10867 Now static.
10868 (force_auto_save_soon): Define only if SIGDANGER.
10869 (ignore_mouse_drag_p): Now static if
10870 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10871 (print_help): Remove; unused.
10872 (stop_character, last_timer_event): Mark as externally visible.
10873 * keyboard.h (ignore_mouse_drag_p): Declare only if
10874 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10875 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10876 * lisp.h (echoing): Remove decl.
10877 (force_auto_save_soon): Declare only if SIGDANGER.
10878 * xdisp.c (redisplay_window): Simplify code, to make it more
10879 obvious that ignore_mouse_drag_p is not accessed if !defined
10880 USE_GTK && !defined HAVE_NS.
10881
93ea6e8f
PE
10882 * intervals.c: Make symbols static if they're not exported.
10883 (merge_properties_sticky, merge_interval_right, delete_interval):
10884 Now static.
10885 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10886
77382fcc
PE
10887 * insdel.c: Make symbols static if they're not exported.
10888 However, leave prepare_to_modify_buffer alone. It's never
10889 called from outside this function, but that appears to be a bug.
10890 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10891 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10892 (adjust_after_replace_noundo): Remove; unused.
10893 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10894 (signal_before_change): Remove decls.
77382fcc 10895
9306c32e
PE
10896 * indent.c (val_compute_motion, val_vmotion): Now static.
10897
cd44d2eb
PE
10898 * image.c: Make symbols static if they're not exported.
10899 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10900 if USE_GTK.
10901 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10902 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10903
ad9a7a06
PE
10904 * fringe.c (standard_bitmaps): Now static.
10905 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10906
81626931
PE
10907 * frame.c: Make symbols static if they're not exported.
10908 (x_report_frame_params, make_terminal_frame): Now static.
10909 (get_frame_param): Now static, unless HAVE_NS.
10910 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10911 (x_get_resource_string): Remove; not used.
10912 * frame.h (make_terminal_frame, x_report_frame_params):
10913 (x_get_resource_string); Remove decls.
10914 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10915 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10916
239f9db9
PE
10917 * font.c, fontset.c: Make symbols static if they're not exported.
10918 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10919 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10920 * font.c (font_close_object): Now static.
10921 * font.h (font_close_object): Remove.
10922 * fontset.c (FONTSET_OBJLIST): Remove.
10923 (free_realized_fontset) #if-0 the body, which does nothing.
10924 (face_suitable_for_char_p): #if-0, as it's never called.
10925 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10926 * xfaces.c (face_at_string_position):
10927 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10928 since 0 is always ASCII.
10929
dfcf3579
PE
10930 * fns.c (weak_hash_tables): Now static.
10931
5045092b
PE
10932 * fileio.c: Make symbols static if they're not exported.
10933 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10934 (Vwrite_region_annotation_buffers): Now static.
10935
57a96f5c
PE
10936 * eval.c: Make symbols static if they're not exported.
10937 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10938 * lisp.h (backtrace_list): Remove decl.
10939
35f08c38
PE
10940 * emacs.c: Make symbols static if they're not exported.
10941 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10942 (fatal_error_code, fatal_error_signal_hook, standard_args):
10943 Now static.
10944 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10945 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10946 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10947 * lisp.h (fatal_error_signal_hook): Remove decl.
10948 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10949
f44bd759
PE
10950 * editfns.c: Move a (normally-unused) function to its only use.
10951 * editfns.c, lisp.h (get_operating_system_release): Remove.
10952 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10953 worth the hassle of breaking this out.
10954
b532497d
PE
10955 * xterm.c: Make symbols static if they're not exported.
10956 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10957 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10958 (x_destroy_window, x_delete_display):
10959 Now static.
10960 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10961 (x_mouse_leave): Remove; unused.
10962 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10963 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10964 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10965 Remove decls.
10966 (x_mouse_leave): Declare only if WINDOWSNT.
10967 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10968 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10969 USE_X_TOOLKIT.
10970
1675728f
PE
10971 * ftxfont.c: Make symbols static if they're not exported.
10972 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10973 HAVE_FREETYPE.
10974 * font.h (ftxfont_driver): Likewise.
10975
e4cebfca
PE
10976 * xfns.c: Make symbols static if they're not exported.
10977 (x_last_font_name, x_display_info_for_name):
10978 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10979 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10980 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10981 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10982 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10983 (last_show_tip_args): Now static.
10984 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10985 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10986 (x_screen_planes): Remove; unused.
10987 * dispextern.h (x_screen_planes): Remove decl.
10988
5bf46f05
PE
10989 * dispnew.c: Make symbols static if they're not exported.
10990 * dispextern.h (redraw_garbaged_frames, scrolling):
10991 (increment_row_positions): Remove.
10992 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10993 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10994 Now static.
10995 (redraw_garbaged_frames): Remove; unused.
10996
435f4c28
PE
10997 * xfaces.c: Make symbols static if they're not exported.
10998 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10999 Remove decls.
11000 * xterm.h (defined_color): Remove decls.
11001 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11002 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11003 (menu_face_changed_default, defined_color, free_realized_face):
11004 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11005 (ascii_face_of_lisp_face): Remove; unused.
11006
8524aef3
PE
11007 * xdisp.c: Make symbols static if they're not exported.
11008 * dispextern.h (scratch_glyph_row, window_box_edges):
11009 (glyph_to_pixel_coords, set_cursor_from_row):
11010 (get_next_display_element, set_iterator_to_next):
11011 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11012 (show_mouse_face): Remove decls
11013 * frame.h (message_buf_print): Likewise.
11014 * lisp.h (pop_message, set_message, check_point_in_composition):
11015 Likewise.
11016 * xterm.h (set_vertical_scroll_bar): Likewise.
11017 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11018 (message_buf_print, scratch_glyph_row, displayed_buffer):
11019 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11020 (get_next_display_element, show_mouse_face, window_box_edges):
11021 (frame_to_window_pixel_xy, check_point_in_composition):
11022 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11023 (glyph_to_pixel_coords): Remove; unused.
11024
16390cd2
PE
11025 * dired.c (file_name_completion): Now static.
11026
11027 * dbusbind.c (xd_in_read_queued_messages): Now static.
11028
a25f4dfa
PE
11029 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11030 * data.c (circular_list_error): Remove.
11031
14a9c8df
PE
11032 * commands.h (last_point_position, last_point_position_buffer):
11033 (last_point_position_window): Remove decls.
11034 * keyboard.c: Make these variables static.
11035
04f2d78b
CB
11036 * coding.h (coding, code_convert_region, encode_coding_gap):
11037 Remove decls.
74ab6df5
PE
11038 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11039 (iso_code_class, detect_coding, code_convert_region): Now static.
11040 (encode_coding_gap): Remove; unused.
11041
38dfbee1
PE
11042 * chartab.c (chartab_chars, chartab_bits): Now static.
11043
a2cb4e63
PE
11044 * charset.h (charset_iso_8859_1): Remove decl.
11045 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11046 Now static.
11047
127198fd
PE
11048 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11049 * ccl.c (Vccl_program_table): Now static.
11050 (check_ccl_update): Remove; unused.
11051
d85b608f
PE
11052 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11053 * category.h: ... from here.
11054 * category.c (check_category_table, set_category_set): Now static.
11055
31cd66f3
PE
11056 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11057 * lisp.h: Remove these decls.
11058
c358e587
PE
11059 * buffer.c (buffer_count): Remove unused var.
11060
e78aecca
PE
11061 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11062 so that it's not optimized away.
11063 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11064 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11065 exported only to the debugger.
11066
e192d7d3 11067 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11068 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11069
92470028
PE
11070 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11071 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11072 was inaccessible from Lisp.
11073 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11074 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11075
244ed907
PE
11076 alloc.c: Import and export fewer symbols, and remove unused items.
11077 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11078 is defined.
11079 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11080 it's not optimized away by whole-program optimization.
11081 (message_enable_multibyte, free_misc): Remove.
11082 (catchlist, handlerlist, mark_backtrace):
11083 Declare only if BYTE_MARK_STACK.
11084 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11085 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11086 (message_enable_multibyte): Remove decl.
11087 (free_misc, interval_free_list, float_block, float_block_index):
11088 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11089 (cons_free_list, last_marked_index):
11090 Now static.
11091 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11092 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11093 (mark_backtrace): Define only if BYTE_MARK_STACK.
11094 * xdisp.c (message_enable_multibyte): Now static.
11095
61c2b50e 11096 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11097 This makes it easier for human readers (and static analyzers)
11098 to see whether these variables are used from other modules.
11099 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11100 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11101 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11102 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11103 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11104 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11105 * xmenu.c, xselect.c:
11106 Declare Q* vars static if they are not used in other modules.
11107 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11108 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11109 Remove decls of unexported vars.
11110 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11111
95c82688
PE
11112 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11113
16a97296
PE
11114 Make Emacs functions such as Fatom 'static' by default.
11115 This makes it easier for human readers (and static analyzers)
11116 to see whether these functions can be called from other modules.
11117 DEFUN now defines a static function. To make the function external
11118 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11119 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11120 (Finit_image_library):
16a97296
PE
11121 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11122 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11123 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11124 Remove decls, since these functions are now static.
11125 (Funintern, Fget_internal_run_time): New decls, since these functions
11126 were already external.
95c82688 11127
16a97296
PE
11128 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11129 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11130 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11131 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11132 * keyboard.c, keymap.c, lread.c:
11133 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11134 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11135 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11136 Mark functions with DEFUE instead of DEFUN,
11137 if they are used in other modules.
11138 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11139 decls for now-static functions.
11140 * buffer.h (Fdelete_overlay): Remove decl.
11141 * callproc.c (Fgetenv_internal): Mark as internal.
11142 * composite.c (Fremove_list_of_text_properties): Remove decl.
11143 (Fcomposition_get_gstring): New forward static decl.
11144 * composite.h (Fcomposite_get_gstring): Remove decl.
11145 * dired.c (Ffile_attributes): New forward static decl.
11146 * doc.c (Fdocumntation_property): New forward static decl.
11147 * eval.c (Ffetch_bytecode): New forward static decl.
11148 (Funintern): Remove extern decl; now in .h file where it belongs.
11149 * fileio.c (Fmake_symbolic_link): New forward static decl.
11150 * image.c (Finit_image_library): New forward static decl.
11151 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11152 * intervals.h (Fprevious_property_change):
11153 (Fremove_list_of_text_properties): Remove decls.
11154 * keyboard.c (Fthis_command_keys): Remove decl.
11155 (Fcommand_execute): New forward static decl.
11156 * keymap.c (Flookup_key): New forward static decl.
11157 (Fcopy_keymap): Now static.
11158 * keymap.h (Flookup_key): Remove decl.
11159 * process.c (Fget_process): New forward static decl.
11160 (Fprocess_datagram_address): Mark as internal.
11161 * syntax.c (Fsyntax_table_p): New forward static decl.
11162 (skip_chars): Remove duplicate decl.
11163 * textprop.c (Fprevious_property_change): New forward static decl.
11164 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11165 Now internal.
11166 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11167 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11168
785bbd42
PE
11169 * editfns.c (Fformat): Remove unreachable code.
11170
8b913b57
AS
111712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11172
11173 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11174 change. (Bug#8496)
11175
a6744a35
EZ
111762011-04-13 Eli Zaretskii <eliz@gnu.org>
11177
11178 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11179 when at ZV. (Bug#8487)
11180
e7974947
AS
111812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11182
baad03f0
AS
11183 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11184 (Bug#8437)
11185 * keyboard.c (parse_tool_bar_item): Likewise.
11186 * sound.c (sound_cleanup, alsa_close): Likewise.
11187 * termcap.c (tgetent): Likewise.
11188 * xfns.c (x_default_font_parameter): Likewise.
11189 * xsettings.c (read_and_apply_settings): Likewise.
11190
e7974947
AS
11191 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11192 (overrun_check_free): Protoize.
11193
28272684
PE
111942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11195
11196 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11197 since callers should never pass a negative size.
11198 Change the signature to match that of plain 'read' and 'write'; see
11199 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11200 * lisp.h: Update prototypes of emacs_write and emacs_read.
11201
11997c76
EZ
112022011-04-11 Eli Zaretskii <eliz@gnu.org>
11203
11204 * xdisp.c (redisplay_window): Don't try to determine the character
11205 position of the scroll margin if the window start point w->startp
e896f03c 11206 is outside the buffer's accessible region. (Bug#8468)
11997c76 11207
8a2cbd72
EZ
112082011-04-10 Eli Zaretskii <eliz@gnu.org>
11209
11210 Fix write-region and its subroutines for buffers > 2GB.
11211 * fileio.c (a_write, e_write): Modify declaration of arguments and
11212 local variables to support buffers larger than 2GB.
11213 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11214
11215 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11216 argument, local variables, and return value.
11217
11218 * lisp.h: Update prototypes of emacs_write and emacs_read.
11219
11220 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11221
4073e537 112222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11223
1ebfdcb6
PE
11224 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11225
b2ded58d
PE
11226 Fix more problems found by GCC 4.6.0's static checks.
11227
7d66342c
PE
11228 * xdisp.c (vmessage): Use a better test for character truncation.
11229
bbf47d44
PE
11230 * charset.c (load_charset_map): <, not <=, for optimization,
11231 and to avoid potential problems with integer overflow.
9248994d 11232 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11233 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11234 * editfns.c (Fformat): Likewise.
1e69125e 11235 * syntax.c (skip_chars): Likewise.
3befa583 11236
e3019616
PE
11237 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11238 This also lets GCC 4.6.0 generate slightly better loop code.
11239
becfa255
PE
11240 * callint.c (Fcall_interactively): <, not <=, for optimization.
11241 (Fcall_interactively): Count the number of arguments produced,
11242 not the number of arguments given. This is simpler and lets GCC
11243 4.6.0 generate slightly better code.
11244
dae0cd48
PE
11245 * ftfont.c: Distingish more carefully between FcChar8 and char.
11246 The previous code passed unsigned char * to a functions like
11247 strlen and xstrcasecmp that expect char *, which does not
11248 conform to the C standard.
11249 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11250 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11251 char * when the C standard requires it.
11252
76032d70
PE
11253 * keyboard.c (read_char): Remove unused var.
11254
eb3f1cc8
PE
11255 * eval.c: Port to Windows vsnprintf (Bug#8435).
11256 Include <limits.h>.
11257 (SIZE_MAX): Define if the headers do not.
11258 (verror): Do not give up if vsnprintf returns a negative count.
11259 Instead, grow the buffer. This ports to Windows vsnprintf, which
11260 does not conform to C99. Problem reported by Eli Zaretskii.
11261 Also, simplify the allocation scheme, by avoiding the need for
11262 calling realloc, and removing the ALLOCATED variable.
11263
70476b54
PE
11264 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11265
12020a9e
PE
11266 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11267 But keep the doprint source code for now, as we might revamp it
11268 and use it again (Bug#8435).
ea6c7ae6
PE
11269 * lisp.h (doprnt): Remove.
11270 * Makefile.in (base_obj): Remove doprnt.o.
11271 * deps.mk (doprnt.o): Remove.
11272
5fdb398c
PE
11273 error: Print 32- and 64-bit integers portably (Bug#8435).
11274 Without this change, on typical 64-bit hosts error ("...%d...", N)
11275 was used to print both 32- and 64-bit integers N, which relied on
11276 undefined behavior.
61bdb816 11277 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11278 * lisp.h (error, verror): Mark as printf-like functions.
11279 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11280 Report overflow in size calculations when allocating printf buffer.
11281 Do not truncate output string at its first null byte.
11282 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11283 Truncate the output at a character boundary, since vsnprintf does not
11284 do that.
11285 * charset.c (check_iso_charset_parameter): Convert internal
11286 character to string before calling 'error', since %c now has the
11287 printf meaning.
11288 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11289 overflow when computing char to be passed to 'error'. Do not
11290 pass Lisp_Object to 'error'; pass the integer instead.
11291 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11292 formatted with plain %d.
11293
b189fa66
PE
11294 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11295
bff87ef0
PE
11296 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11297
7e2cac20
PE
11298 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11299
ce4d90b5
PE
11300 * xterm.c (x_catch_errors): Remove duplicate declaration.
11301
266c9547
PE
11302 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11303
79c49ad2
PE
11304 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11305
368f4090
JM
113062011-04-10 Jim Meyering <meyering@redhat.com>
11307
11308 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11309 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11310 return ssize_t not "int", and use size_t as the buffer length.
11311 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11312 * gnutls.h: Update declarations.
11313 * process.c (read_process_output): Use ssize_t, to match.
11314 (send_process): Likewise.
11315
a32d4040
CY
113162011-04-09 Chong Yidong <cyd@stupidchicken.com>
11317
11318 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11319
8546720e 113202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11321
04f2d78b
CB
11322 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11323 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11324
8546720e
GM
11325 * xterm.c (handle_one_xevent):
11326 * xmenu.c (create_and_show_popup_menu):
11327 * xselect.c (x_decline_selection_request)
11328 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11329
0a2f5c1a 113302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11331
11332 Fix some uses of `int' instead of EMACS_INT.
11333 * search.c (string_match_1, fast_string_match)
11334 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11335 (scan_buffer, find_next_newline_no_quit)
11336 (find_before_next_newline, search_command, Freplace_match)
11337 (Fmatch_data): Make some `int' variables be EMACS_INT.
11338
11339 * xdisp.c (display_count_lines): 3rd argument and return value now
11340 EMACS_INT. All callers changed.
11341 (pint2hrstr): Last argument is now EMACS_INT.
11342
11343 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11344 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11345 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11346 (decode_coding_utf_16, decode_coding_emacs_mule)
11347 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11348 (decode_coding_ccl, decode_coding_charset)
11349 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11350 (decode_coding_iso_2022, decode_coding_emacs_mule)
11351 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11352 <char_offset, last_offset>: Declare EMACS_INT.
11353 (encode_coding_utf_8, encode_coding_utf_16)
11354 (encode_coding_emacs_mule, encode_invocation_designation)
11355 (encode_designation_at_bol, encode_coding_iso_2022)
11356 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11357 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11358 Declare EMACS_INT.
11359 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11360 (encode_invocation_designation): Last argument P_NCHARS is now
11361 EMACS_INT.
11362 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11363 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11364
11365 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11366 All users changed.
11367
11368 * ccl.c (Fccl_execute_on_string): Declare some variables
11369 EMACS_INT.
11370
8546720e 113712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11372
11373 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11374
4e19a977
CS
113752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11376
11377 * process.c (Fformat_network_address): Doc fix.
11378
87302331
R
113792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11380
ee7683eb 11381 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11382
cbb59342
CY
113832011-04-08 Chong Yidong <cyd@stupidchicken.com>
11384
11385 * keyboard.c (read_char): Call Lisp function help-form-show,
11386 instead of using internal_with_output_to_temp_buffer.
11387 (Qhelp_form_show): New var.
e0d38eeb 11388 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11389
11390 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11391
11392 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11393
e67a13ab
CY
113942011-04-06 Chong Yidong <cyd@stupidchicken.com>
11395
04f2d78b
CB
11396 * process.c (Flist_processes): Remove to Lisp.
11397 (list_processes_1): Delete.
e67a13ab 11398
973f782d
EZ
113992011-04-06 Eli Zaretskii <eliz@gnu.org>
11400
7c106b1e
EZ
11401 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11402
973f782d
EZ
11403 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11404
41cf7d1a 114052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11406
ca23cc88
PE
11407 Fix more problems found by GCC 4.6.0's static checks.
11408
f390e2d5
PE
11409 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11410
42eea0d0
PE
11411 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11412
b69769da 11413 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11414
f9541e84
PE
11415 * xdisp.c (vmessage): Mark as a printf-like function.
11416
13841b55
PE
11417 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11418
c136c10f
PE
11419 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11420
5e2d4a30
PE
11421 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11422 printf-like functions.
11423 (tiff_load): Add casts to remove these marks before passing them
11424 to system-supplied API.
11425
583f48b9
PE
11426 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11427
b25d760e
PE
11428 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11429 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11430 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11431 directly, rather than having caller test rule sign. This avoids
11432 some unnecessary tests.
11433 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11434 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11435 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11436
bc7b6697 11437 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11438 (xfont_open): Avoid unnecessary tests.
bc7b6697 11439
27ccc379
PE
11440 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11441
dcd5c89a
PE
11442 * composite.h, composite.c (composition_gstring_put_cache):
11443 Use EMACS_INT, not int, for length.
11444
b13a45c6
PE
11445 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11446 breaking out part of COMPOSITION_DECODE_RULE.
11447 (COMPOSITION_DECODE_RULE): Use it.
11448 * composite.c (get_composition_id): Remove unused local vars,
11449 by using the new macro.
11450
1e792e4d
PE
11451 * textprop.c (set_text_properties_1): Change while to do-while,
11452 since the condition is always true at first.
11453
dc6c6455 11454 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11455 (interval_deletion_adjustment): Return unsigned value.
11456 All uses changed.
dc6c6455 11457
aba7731a
PE
11458 * process.c (list_processes_1, create_pty, read_process_output):
11459 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11460 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11461 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11462 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11463 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11464
fdfc4bf3
PE
11465 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11466
fca8fe46 11467 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11468 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11469
06a0259a 11470 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11471 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11472 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11473
e7b9e80f
PE
11474 * print.c (print_error_message): Avoid int overflow.
11475
56201685
PE
11476 * font.c (font_list_entities): Redo for clarity,
11477 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11478
78834453 11479 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11480 (font_score): Avoid potential overflow in diff calculation.
78834453 11481
0bc0b309 11482 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11483 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11484
e610eaca
PE
11485 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11486
b895abce
PE
11487 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11488 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11489 can always succeed if overflow has undefined behavior.
11490
1f1d9321 11491 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11492 (wordify): Omit three unnecessary tests.
1f1d9321 11493
c59478bc
PE
11494 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11495 All callers changed. This avoids the need for an unused var.
11496
79b73827
PE
11497 * casefiddle.c (casify_region): Remove var that is set but not used.
11498
a4db5dfe
PE
11499 * dired.c (file_name_completion): Remove var that is set but not used.
11500
43aae36e
PE
11501 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11502
2a47c44d 11503 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11504 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11505
a37c69bf
PE
11506 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11507 Check for integer overflow on size calculations.
11508
328ab8e7
PE
11509 * buffer.c (Fprevious_overlay_change): Remove var that is set
11510 but not used.
11511
e5a2a5cb
PE
11512 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11513 Remove vars that are set but not used.
8d84a6eb 11514 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11515 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11516
a60e5f68
PE
11517 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11518
f661cb61 11519 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11520 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11521
f0397f5a
PE
11522 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11523 that are set but not used.
11524
8664db06 11525 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11526 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11527
6abdaa4a
PE
11528 * xselect.c (x_get_local_selection, x_handle_property_notify):
11529 Remove vars that are set but not used.
11530
0ce7538d 11531 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11532 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11533
9ae848fc
PE
11534 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11535 Remove var that is set but not used.
0b918413
PE
11536 (scroll_bar_windows_size): Now size_t, not int.
11537 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11538 Check for overflow.
9ae848fc 11539
a5a62657
PE
11540 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11541 (map_tty_color) [!defined MSDOS]: Likewise.
11542
5c5cdd39
PE
11543 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11544
66ebf983
PE
11545 * coding.c: Remove vars that are set but not used.
11546 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11547 All callers changed.
11548 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11549 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11550 (decode_coding_charset): Remove vars that are set but not used.
11551
1be4d761
PE
11552 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11553 that is set but not used.
11554
47553fa8
PE
11555 * print.c (print_object): Remove var that is set but not used.
11556
1f7196bf 11557 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11558 The gnulib version avoids calling malloc in the usual case,
11559 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11560 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11561 * filelock.c (current_lock_owner): Likewise.
11562 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11563 * sysdep.c: Include allocator.h, careadlinkat.h.
11564 (emacs_no_realloc_allocator): New static constant.
11565 (emacs_readlink): New function.
fdb61804
PE
11566 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11567 ../lib/careadlinkat.h.
d1fdcab7 11568
f84c17c7
SM
115692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11570
11571 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11572 first non-nil return value).
11573
ef3862ad
JD
115742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11575
11576 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11577 if not defined (Bug#8403).
11578
376a7006
JB
115792011-04-02 Juanma Barranquero <lekktu@gmail.com>
11580
11581 * xdisp.c (display_count_lines): Remove parameter `start',
11582 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11583 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11584 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11585 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11586 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11587 and thereabouts. All callers changed.
11588 (get_per_char_metric): Remove parameter `f', unused since
11589 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11590
6ca3801d
JM
115912011-04-02 Jim Meyering <meyering@redhat.com>
11592
11593 do not dereference NULL upon failed strdup
11594 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11595 (ns_get_family): Likewise.
11596
d8e2b5ba
JB
115972011-04-02 Juanma Barranquero <lekktu@gmail.com>
11598
11599 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11600
8c74fcbd
JD
116012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11602
11603 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11604 later (Bug#8403).
11605
7200d79c
SM
116062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11607
03408648 11608 Add lexical binding.
7200d79c 11609
03408648
SM
11610 * window.c (Ftemp_output_buffer_show): New fun.
11611 (Fsave_window_excursion):
11612 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11613
11614 * lread.c (lisp_file_lexically_bound_p): New function.
11615 (Fload): Bind Qlexical_binding.
11616 (readevalloop): Remove `evalfun' arg.
11617 Bind Qinternal_interpreter_environment.
11618 (Feval_buffer): Bind Qlexical_binding.
11619 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11620 Mark as dynamic.
11621 (syms_of_lread): Declare `lexical-binding'.
11622
11623 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11624
11625 * keyboard.c (eval_dyn): New fun.
11626 (menu_item_eval_property): Use it.
ca105506
SM
11627
11628 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11629
03408648
SM
11630 * fns.c (concat, mapcar1): Accept byte-code-functions.
11631
11632 * eval.c (Fsetq): Handle lexical vars.
11633 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11634 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11635 (FletX, Flet): Obey lexical binding.
11636 (Fcommandp): Handle closures.
11637 (Feval): New `lexical' arg.
11638 (eval_sub): New function extracted from Feval. Use it almost
11639 everywhere where Feval was used. Look up vars in lexical env.
11640 Handle closures.
11641 (Ffunctionp): Move from subr.el.
11642 (Ffuncall): Handle closures.
11643 (apply_lambda): Remove `eval_flags'.
11644 (funcall_lambda): Handle closures and new byte-code-functions.
11645 (Fspecial_variable_p): New function.
11646 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11647 but without exporting it to Lisp.
23aba0ea 11648
23aba0ea 11649 * doc.c (Fdocumentation, store_function_docstring):
03408648 11650 * data.c (Finteractive_form): Handle closures.
23aba0ea 11651
03408648
SM
11652 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11653 interactive spec.
ba83908c 11654
04f2d78b
CB
11655 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11656 New byte-codes.
03408648
SM
11657 (exec_byte_code): New function extracted from Fbyte_code to handle new
11658 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11659
03408648 11660 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11661
03408648 11662 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11663
e2abce01
JB
116642011-03-31 Juanma Barranquero <lekktu@gmail.com>
11665
11666 * xdisp.c (redisplay_internal): Fix prototype.
11667
63696a73 116682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11669
63696a73 11670 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11671 (try_scrolling): Use it when setting scroll_limit.
11672 Limit scrolling to 100 screen lines.
63696a73
EZ
11673 (redisplay_window): Even when falling back on "recentering",
11674 position point in the window according to scroll-conservatively,
11675 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11676
11677 (try_scrolling): When point is above the window, allow searching
11678 as far as scroll_max, or one screenful, to compute vertical
11679 distance from PT to the scroll margin position. This prevents
11680 try_scrolling from unnecessarily failing when
11681 scroll-conservatively is set to a value slightly larger than the
11682 window height. Clean up the case of PT below the margin at bottom
11683 of window: scroll_max can no longer be INT_MAX. When aggressive
11684 scrolling is in use, don't let point enter the opposite scroll
11685 margin as result of the scroll.
11686 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11687 threshold of 100 lines for never-recentering scrolling.
11688
e4cc2dfc
JB
116892011-03-31 Juanma Barranquero <lekktu@gmail.com>
11690
11691 * dispextern.h (move_it_by_lines):
11692 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11693 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11694 (message_log_check_duplicate): Remove parameters `prev_bol' and
11695 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11696 (redisplay_internal): Remove parameter `preserve_echo_area',
11697 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11698
11699 * indent.c (Fvertical_motion):
11700 * window.c (window_scroll_pixel_based, Frecenter):
11701 Don't pass `need_y_p' to `move_it_by_lines'.
11702
1c470562
SM
117032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11704
44f230aa
SM
11705 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11706 steal a few bits to be more compact.
11707 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11708 Remove unneeded casts.
11709
1c470562
SM
11710 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11711
888adce9
ZK
117122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11713
11714 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11715 binding" message (bug#7967).
11716
f838ed7b
PE
117172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11718
77861b95
PE
11719 Fix more problems found by GCC 4.6.0's static checks.
11720
de6dbc14
PE
11721 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11722 Remove unused local var.
11723
f838ed7b
PE
11724 * editfns.c (Fmessage_box): Remove unused local var.
11725
792c7b2b
PE
11726 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11727 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11728 Omit unused local vars.
c499e557 11729 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11730 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11731 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11732 Omit unused local var.
11733
ba0165e1
PE
11734 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11735 Don't assume string length fits in int.
32ad8845 11736 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11737 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11738
3c59b4c9
PE
11739 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11740 instead of alloca (Bug#8344).
11741
a3eed478 11742 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11743 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11744
eb4d412d
PE
11745 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11746
1658b401
PE
11747 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11748 concerns.
11749
11750 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11751
11752 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11753
9a2c6e05
PE
11754 * keyboard.c (syms_of_keyboard): Use the same style as later
11755 in this function when indexing through an array. This also
11756 works around GCC bug 48267.
11757
03d0a109
PE
11758 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11759
44f730c8
PE
11760 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11761
fe75f926
PE
11762 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11763 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11764
ffa8c828
PE
11765 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11766 This avoids undefined behavior on integer overflow, and is a bit
11767 more convenient anyway since it is compared to a size_t variable.
11768
c5101a77
PE
11769 Variadic C functions now count arguments with size_t, not int.
11770 This avoids an unnecessary limitation on 64-bit machines, which
11771 caused (substring ...) to crash on large vectors (Bug#8344).
11772 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11773 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11774 All variadic functions and their callers changed accordingly.
c5101a77
PE
11775 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11776 * data.c (arith_driver, float_arith_driver): Likewise.
11777 * editfns.c (general_insert_function): Likewise.
11778 * eval.c (struct backtrace.nargs, interactive_p)
11779 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11780 (funcall_lambda, mark_backtrace): Likewise.
11781 * fns.c (concat): Likewise.
11782 * frame.c (x_set_frame_parameters): Likewise.
11783 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11784 0 if not found, not -1. All callers changed.
11785
dd3f25f7
PE
11786 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11787 (stack_copy_size): Now size_t, not int.
11788 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11789
461c2ab9
JB
117902011-03-28 Juanma Barranquero <lekktu@gmail.com>
11791
11792 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11793 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11794 All callers changed.
11795
11796 * lisp.h (multibyte_char_to_unibyte):
11797 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11798 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11799 * character.h (CHAR_TO_BYTE8):
11800 * cmds.c (internal_self_insert):
11801 * editfns.c (general_insert_function):
11802 * keymap.c (push_key_description):
11803 * search.c (Freplace_match):
11804 * xdisp.c (message_dolog, set_message_1): All callers changed.
11805
f6d62986
SM
118062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11807
11808 * keyboard.c (safe_run_hook_funcall): New function.
11809 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11810 don't set the hook to nil, but remove the offending function instead.
11811 (Qcommand_hook_internal): Remove, unused.
11812 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11813 Vcommand_hook_internal.
11814
11815 * eval.c (enum run_hooks_condition): Remove.
11816 (funcall_nil, funcall_not): New functions.
11817 (run_hook_with_args): Call each function through a `funcall' argument.
11818 Remove `cond' argument, now redundant.
11819 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11820 (Frun_hook_with_args_until_failure): Adjust accordingly.
11821 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11822
1db5b1ad
JB
118232011-03-28 Juanma Barranquero <lekktu@gmail.com>
11824
11825 * dispextern.h (string_buffer_position): Remove declaration.
11826
11827 * print.c (strout): Remove parameter `multibyte', unused since
11828 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11829
11830 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11831 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11832 All callers changed.
11833
11834 * w32.c (_wsa_errlist): Use braces for struct initializers.
11835
11836 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11837 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11838 All callers changed.
11839 (string_buffer_position): Likewise. Also, make static (it's never
11840 used outside xdisp.c).
11841 (cursor_row_p): Remove parameter `w', unused since
11842 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11843 (decode_mode_spec): Remove parameter `precision', introduced during
11844 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11845 All callers changed.
11846
5ffb62aa
JD
118472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11848
11849 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11850
461c2ab9 118512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11852
11853 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11854 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11855 (ns_update_auto_hide_menu_bar): New functions.
11856 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11857 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11858 ns_constrain_all_frames.
11859 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11860 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11861
5c380ffb
JD
118622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11863
11864 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11865
9af30bdf
GM
118662011-03-27 Glenn Morris <rgm@gnu.org>
11867
11868 * syssignal.h: Replace RETSIGTYPE with void.
11869 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11870 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11871 Replace SIGTYPE with void everywhere.
11872 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11873 * s/template.h (SIGTYPE): Remove commented out definition.
11874
e2abce01
JB
118752011-03-26 Eli Zaretskii <eliz@gnu.org>
11876
11877 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11878 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11879
f868cd8a
JB
118802011-03-26 Juanma Barranquero <lekktu@gmail.com>
11881
59eb0929
JB
11882 * w32.c (read_unc_volume): Use parameter `henum', instead of
11883 global variable `wget_enum_handle'.
11884
11885 * keymap.c (describe_vector): Remove parameters `indices' and
11886 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11887 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11888
f868cd8a
JB
11889 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11890
11891 * keyboard.c (timer_check): Remove parameter `do_it_now',
11892 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11893 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11894 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11895
11896 * keyboard.c (read_char):
11897 * w32menu.c (w32_menu_display_help):
11898 * xmenu.c (show_help_event, menu_help_callback):
11899 Adjust calls to `show_help_echo'.
11900
11901 * gtkutil.c (xg_maybe_add_timer):
11902 * keyboard.c (readable_events):
11903 * process.c (wait_reading_process_output):
11904 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11905
11906 * insdel.c (adjust_markers_gap_motion):
11907 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11908 (gap_left, gap_right): Don't call it.
11909
2ecf6fdb
CY
119102011-03-25 Chong Yidong <cyd@stupidchicken.com>
11911
11912 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11913 incurred during fontification.
11914
6b1f9ba4
JB
119152011-03-25 Juanma Barranquero <lekktu@gmail.com>
11916
11917 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11918 (DEFVAR_PER_BUFFER): Don't pass it.
11919
11920 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11921 (scrolling_window): Don't pass it.
11922
0f4a96b5
JB
119232011-03-25 Juanma Barranquero <lekktu@gmail.com>
11924
11925 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11926
11927 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11928 and `suffix'.
11929 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11930 of variables specific to SELinux and computation of `encoded_absname'.
11931
11932 * image.c (XPutPixel): Remove unused variable `height'.
11933
11934 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11935
11936 * unexw32.c (get_section_info): Remove unused variable `section'.
11937
11938 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11939 (system_process_attributes): Remove unused variable `sess'.
11940 (sys_read): Remove unused variable `err'.
11941
11942 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11943 (w32_wnd_proc): Remove unused variable `isdead'.
11944 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11945 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11946 (x_create_tip_frame): Remove unused variable `tem'.
11947
11948 * w32inevt.c (w32_console_read_socket):
11949 Remove unused variable `no_events'.
11950
11951 * w32term.c (x_draw_composite_glyph_string_foreground):
11952 Remove unused variable `width'.
11953
1149507c
JB
119542011-03-24 Juanma Barranquero <lekktu@gmail.com>
11955
11956 * w32term.c (x_set_glyph_string_clipping):
11957 Don't pass uninitialized region to CombineRgn.
11958
9c88f339
JB
119592011-03-23 Juanma Barranquero <lekktu@gmail.com>
11960
11961 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11962 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11963 (Fx_close_connection): Remove unused variable `i'.
11964
11965 * w32font.c (w32font_draw): Return number of glyphs.
11966 (w32font_open_internal): Remove unused variable `i'.
11967 (w32font_driver): Add missing initializer.
11968
11969 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11970 (fill_in_menu): Remove unused variable `items_added'.
11971
11972 * w32term.c (last_mouse_press_frame): Remove static global variable.
11973 (w32_clip_to_row): Remove unused variable `f'.
11974 (x_delete_terminal): Remove unused variable `i'.
11975
11976 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11977 (NOTHING): Remove unused static global variable.
11978 (uniscribe_check_otf): Remove unused variable `table'.
11979 (uniscribe_font_driver): Add missing initializers.
11980
dee091a3
JD
119812011-03-23 Julien Danjou <julien@danjou.info>
11982
11983 * term.c (Fsuspend_tty, Fresume_tty):
11984 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11985 * window.c (temp_output_buffer_show):
11986 * insdel.c (signal_before_change):
11987 * frame.c (Fhandle_switch_frame):
11988 * fileio.c (Fdo_auto_save):
11989 * emacs.c (Fkill_emacs):
11990 * editfns.c (save_excursion_restore):
11991 * cmds.c (internal_self_insert):
11992 * callint.c (Fcall_interactively):
11993 * buffer.c (Fkill_all_local_variables):
11994 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11995 Use Frun_hooks.
0f4a96b5 11996 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11997 unconditionally since it does the check itself.
dee091a3 11998
2c520ab5 119992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12000
c9c49752
PE
12001 Fix more problems found by GCC 4.5.2's static checks.
12002
8abc3f12
PE
12003 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12004 the first time through the loop, since we know p0 < p1 then.
12005 This also avoids a gcc -Wstrict-overflow warning.
12006
a2d26660
PE
12007 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12008 leading to a memory leak, possible in functions like
12009 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12010 of objects (Bug#8318).
a2d26660 12011
916c72e9
PE
12012 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12013 that could (at least in theory) be that large.
12014
19ab8a18
PE
12015 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12016 This is less likely to overflow, and avoids undefined behavior if
12017 overflow does occur. All callers changed. Use strtoul to scan
12018 for the unsigned long integer.
b7cbbd6f
PE
12019 (pint2hrstr): Simplify and tune code slightly.
12020 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12021
f0641eff
PE
12022 * scroll.c (do_scrolling): Work around GCC bug 48228.
12023 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12024
7f650bb9
PE
12025 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12026 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12027 (validate_x_resource_name): Simplify count usage.
12028 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12029
37dd57d1
PE
12030 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12031 fail (Bug#8306).
81e56e61 12032
699979fc 12033 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12034
401bf9b4
PE
12035 * process.c (Fmake_network_process): Use socklen_t, not int,
12036 where POSIX says socklen_t is required in portable programs.
12037 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12038 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12039 (Fmake_network_process, server_accept_connection):
12040 (wait_reading_process_output, read_process_output):
12041 Likewise.
12042
b93aacde
PE
12043 * process.c: Rename or move locals to avoid shadowing.
12044 (list_processes_1, Fmake_network_process):
12045 (read_process_output_error_handler, exec_sentinel_error_handler):
12046 Rename or move locals.
4dc343ee 12047 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12048 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12049 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12050 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12051 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12052
af8a867c 12053 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12054 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12055 Include tparam.h instead, since it declares them.
af8a867c
PE
12056 * cm.h (PC): Remove extern decl; tparam.h now does this.
12057 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12058 * terminfo.c: Include tparam.h, to check interfaces.
12059 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12060 (tparam): Adjust signature to match interface in tparam.h;
12061 this removes some undefined behavior. Check that outstring and len
12062 are zero, which they always are with Emacs.
12063 * tparam.h (PC, BC, UP): New extern decls.
12064
0248044d 12065 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12066 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12067
8ff096c1 12068 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12069 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12070 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12071 (ftfont_list): Remove unused local.
49eaafba
PE
12072 (get_adstyle_property, ftfont_pattern_entity):
12073 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12074 Rename locals to avoid shadowing.
8ff096c1 12075
e2be39f6
PE
12076 * xfont.c (xfont_list_family): Mark var as initialized.
12077
c9735e30
PE
12078 * xml.c (make_dom): Now static.
12079
8f5201ae
PE
12080 * composite.c (composition_compute_stop_pos): Rename local to
12081 avoid shadowing.
b246f932
PE
12082 (composition_reseat_it): Remove unused locals.
12083 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12084 (composition_update_it): Mark var as initialized.
11b61122
PE
12085 (find_automatic_composition): Mark vars as initialized,
12086 with a FIXME (Bug#8290).
8f5201ae 12087
760fbc2c
PE
12088 character.h: Rename locals to avoid shadowing.
12089 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12090 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12091 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12092 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12093 to avoid shadowing.
12094
ff08eb85
PE
12095 * textprop.c (property_change_between_p): Remove; unused.
12096
fc7bf025
PE
12097 * intervals.c (interval_start_pos): Now static.
12098
235d7abc
PE
12099 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12100
44f230aa
SM
12101 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12102 Rename locals to avoid shadowing.
3e7d6594 12103
50060332
PE
12104 * sound.c (wav_play, au_play, Fplay_sound_internal):
12105 Fix pointer signedness.
d01f234b 12106 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12107 (wav_play): Initialize a variable to 0, to prevent undefined
12108 behavior (Bug#8278).
50060332 12109
c4fc4e30
PE
12110 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12111
918436ed
PE
12112 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12113
c939f91b
PE
12114 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12115 clobbering (Bug#8298).
b9c7f648
PE
12116 * sysdep.c (sys_subshell): Likewise.
12117 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12118
6bd8c144
PE
12119 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12120 This should get cleaned up, so that child_setup has the
12121 same signature on all platforms.
12122
7710357c 12123 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12124 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12125
c59da222
CY
121262011-03-22 Chong Yidong <cyd@stupidchicken.com>
12127
12128 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12129 not to be necessary, and produces flickering.
12130
66b87493
GM
121312011-03-20 Glenn Morris <rgm@gnu.org>
12132
12133 * config.in: Remove file.
12134
45b6f6d5
JB
121352011-03-20 Juanma Barranquero <lekktu@gmail.com>
12136
12137 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12138 are now in src/globals.h.
12139 (syms_of_minibuf): Remove spurious & from previous change.
12140
cd394be1 121412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12142
12143 * minibuf.c (completing-read-function): New variable.
12144 (completing-read-default): Rename from completing-read.
12145 (completing-read): Call completing-read-function.
12146
b14e3e21
CY
121472011-03-19 Juanma Barranquero <lekktu@gmail.com>
12148
12149 * xfaces.c (Fx_load_color_file):
12150 Read color file from absolute filename (bug#8250).
12151
f2b726e6
JB
121522011-03-19 Juanma Barranquero <lekktu@gmail.com>
12153
12154 * makefile.w32-in: Update dependencies.
12155
09f6ff02
EZ
121562011-03-17 Eli Zaretskii <eliz@gnu.org>
12157
12158 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12159
29a6015a
PE
121602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12161
a3a6c54e
PE
12162 Fix more problems found by GCC 4.5.2's static checks.
12163
b766f867
PE
12164 * process.c (make_serial_process_unwind, send_process_trap):
12165 (sigchld_handler): Now static.
12166
be02381c
PE
12167 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12168 That way, the code declares only the vars that it needs.
12169 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12170 * s/cygwin.h (PTY_ITERATION): Likewise.
12171 * s/darwin.h (PTY_ITERATION): Likewise.
12172 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12173
57048744
PE
12174 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12175 * process.c (allocate_pty): Don't declare stb unless it's needed.
12176
7914961c 12177 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12178 (CONSTANTLIM): Remove; unused.
12179 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12180 Define only if needed.
7914961c 12181
b3967b18
PE
12182 * unexelf.c (unexec): Name an expression,
12183 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12184 Use a different way to cause a compilation error if anyone uses
12185 n rather than nn, a way that does not involve shadowing.
73366a00 12186 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12187
29a6015a
PE
12188 * deps.mk (unexalpha.o): Remove; unused.
12189
43cfc33e 12190 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12191 * unexec.h: New file.
ce701a33
PE
12192 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12193 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12194 Depend on unexec.h.
12195 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12196 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12197 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12198 Change as necessary to match prototype in unexec.h.
ce701a33 12199
01f44d5a
PE
12200 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12201 shadowing.
4f63c6bb 12202 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12203
a6670b0b
PE
12204 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12205 Rename locals to avoid shadowing.
12206
cef2010d 12207 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12208 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12209
d4d7173a
PE
12210 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12211
f08b802a
PE
12212 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12213 warning when compiling print.c.
12214
3ddb0639
PE
12215 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12216 instead of using an uninitialized var.
5ad03b97 12217 (font_sort_entities): Mark var as initialized.
3ddb0639 12218
170a2692
PE
12219 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12220
e663c700
PE
12221 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12222 pointers to constants.
89bc529a 12223 (font_parse_fcname): Remove unused vars.
7b81e2d0 12224 (font_delete_unmatched): Now static.
ea838e10 12225 (font_get_spec): Remove; unused.
13a547c6
PE
12226 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12227 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12228 Rename or move locals to avoid shadowing.
e663c700 12229
2a80c887 12230 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12231 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12232
1384fa33 12233 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12234 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12235
8b2c52e9
PE
12236 * alloc.c (mark_backtrace): Move decl from here ...
12237 * lisp.h: ... to here, so that it can be checked.
12238
475545b5 12239 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12240 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12241 (lisp_indirect_variable): Name an expression,
12242 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12243 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12244
b1349114 12245 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12246 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12247 Use const pointer when appropriate.
b1349114 12248
a2928364
PE
12249 * lisp.h (get_system_name, get_operating_system_release):
12250 Move decls here, to check interfaces.
12251 * process.c (get_operating_system_release): Move decl to lisp.h.
12252 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12253 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12254 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12255 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12256 (Fformat_time_string, Fencode_time, Finsert_char):
12257 (Ftranslate_region_internal, Fformat):
12258 Rename or remove local vars to avoid shadowing.
9710023e 12259 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12260
a415e694
PE
12261 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12262 avoid shadowing.
12263
8ef4622d
PE
12264 * lisp.h (eassert): Check that the argument compiles, even if
12265 ENABLE_CHECKING is not defined.
12266
946f9a5b
PE
12267 * data.c (Findirect_variable): Name an expression, to avoid
12268 gcc -Wbad-function-cast warning.
112396d6 12269 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12270 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12271 (Fmake_variable_buffer_local, Fmake_local_variable):
12272 Mark variables as initialized.
52746918 12273 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12274
e5aab7e7 12275 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12276 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12277 Rename locals to avoid shadowing.
dff45157
PE
12278 (mark_stack): Move local variables into the #ifdef region where
12279 they're used.
7bc26fdb
PE
12280 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12281 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12282 needed otherwise.
12283 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12284 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12285 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12286
e5aab7e7
PE
12287 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12288 avoids undefined behavior in theory.
12289
4da60324
PE
12290 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12291
88043301
PE
12292 Use functions, not macros, for up- and down-casing (Bug#8254).
12293 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12294 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12295 to use the following functions instead of these macros.
12296 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12297 EMACS_INT, since callers assume the returned value fits in int.
12298 (upcase1): Likewise, for UPCASE_TABLE.
12299 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12300 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12301 the race-condition problem in the old DOWNCASE.
88043301 12302
19ed5445
PE
12303 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12304 Rename locals to avoid shadowing.
12305 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12306 (regex_compile, re_search_2, re_match_2_internal):
12307 Remove unused local vars.
952db0d7
PE
12308 (FREE_VAR): Rewrite so as not to use empty "else",
12309 which gcc can warn about.
da053e48 12310 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12311 (RETALLOC_IF): Define only if needed.
12312 (WORDCHAR_P): Likewise. This one is never needed, but is used
12313 only in a comment talking about a compiler bug, so put inside
12314 the #if 0 of that comment.
12315 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12316 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12317 Remove; unused.
19ed5445 12318
1f3561e4 12319 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12320 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12321 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12322
ded6f8f7
PE
12323 * search.c (simple_search): Remove unused var.
12324
dbd37a95
PE
12325 * dired.c (compile_pattern): Move decl from here ...
12326 * lisp.h: ... to here, so that it can be checked.
12327 (struct re_registers): New forward decl.
12328
7e47afad
PE
12329 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12330
85f24f61
PE
12331 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12332 All uses changed.
12333 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12334 Rename locals to avoid shadowing.
5671df8f 12335 (Fvertical_motion): Mark locals as initialized.
85f24f61 12336
181aa2be 12337 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12338 (casify_region): Mark local as initialized.
181aa2be 12339
930d429c
PE
12340 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12341
7082eac6
PE
12342 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12343 New macros, so that the caller can use some names other than
12344 gcpro1, gcpro2, etc.
12345 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12346 of the new macros.
12347 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12348 argument, for consistency with GCPRO2_VAR, etc: it is now the
12349 prefix of the variable, not the variable itself. All uses
12350 changed.
38b2c076
PE
12351 * dired.c (directory_files_internal, file_name_completion):
12352 Rename locals to avoid shadowing.
12353
15206ed9
PE
12354 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12355 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12356 dired.c's scmp function, had undefined behavior.
12357 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12358 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12359 * buffer.h: ... to here, because these macros use current_buffer,
12360 and the new implementation with inline functions needs to have
12361 current_buffer in scope now, rather than later when the macros
12362 are used.
12363 (downcase, upcase1): New static inline functions.
12364 (DOWNCASE, UPCASE1): Reimplement using these functions.
12365 This avoids undefined behavior in expressions like
12366 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12367 from race conditions in accessing the global variables
12368 case_temp1 and case_temp2.
12369 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12370 * lisp.h (case_temp1, case_temp2): Remove their decls.
12371 * character.h (ASCII_CHAR_P): Move from here ...
12372 * lisp.h: ... to here, so that the inline functions mentioned
12373 above can use them.
12374
4a6bea26
PE
12375 * dired.c (directory_files_internal_unwind): Now static.
12376
f14b7e14
PE
12377 * fileio.c (file_name_as_directory, directory_file_name):
12378 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12379 Now static.
2893f146
PE
12380 (file_name_as_directory): Use const pointers when appropriate.
12381 (Fexpand_file_name): Likewise. In particular, newdir might
12382 point at constant storage, so make it a const pointer.
fd4ead52 12383 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12384 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12385 signedness issues.
f839df0c
PE
12386 (Fset_file_times, Finsert_file_contents, auto_save_error):
12387 Rename locals to avoid shadowing.
f14b7e14 12388
5716756e 12389 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12390 (Ftry_completion, Fall_completions): Rename or remove locals
12391 to avoid shadowing.
5716756e 12392
b4c3046a
PE
12393 * marker.c (bytepos_to_charpos): Remove; unused.
12394
b45db522
PE
12395 * lisp.h (verify_bytepos, count_markers): New decls,
12396 so that gcc does not warn that these functions aren't declared.
12397
85876d07
PE
12398 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12399 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12400 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12401 (copy_text): Remove unused local var.
85876d07 12402
03d78a21 12403 * filelock.c (within_one_second): Now static.
b3dd38ab 12404 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12405
5df8f01b
PE
12406 * buffer.c (fix_overlays_before): Mark locals as initialized.
12407 (fix_start_end_in_overlays): Likewise. This function should be
12408 simplified by using pointers-to-pointers, but that's a different
12409 matter.
b1d876f1 12410 (switch_to_buffer_1): Now static.
8f54f30a
PE
12411 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12412 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12413
a70072c9 12414 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12415 Fix pointer signedness issue.
edced198
PE
12416 (sys_subshell): Mark local as volatile if checking for lint,
12417 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12418 (MAXPATHLEN): Define only if needed.
a70072c9 12419
a0977c44
PE
12420 * process.c (serial_open, serial_configure): Move decls from here ...
12421 * systty.h: ... to here, so that they can be checked.
12422
a884fdcc
PE
12423 * fns.c (get_random, seed_random): Move extern decls from here ...
12424 * lisp.h: ... to here, so that they can be checked.
12425
604efe86 12426 * sysdep.c (reset_io): Now static.
b8950c94 12427 (wait_for_termination_signal): Remove; unused.
604efe86 12428
38fc62d9
PE
12429 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12430 (copy_keymap_item, append_key, push_text_char_description):
12431 Now static.
1004a21a 12432 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12433 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12434 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12435 (describe_map_tree):
12436 Rename locals to avoid shadowing.
38fc62d9 12437
2f2650da
PE
12438 * keyboard.c: Declare functions static if they are not used elsewhere.
12439 (echo_char, echo_dash, cmd_error, top_level_2):
12440 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12441 (read_char, kbd_buffer_get_event, make_lispy_position):
12442 (make_lispy_event, make_lispy_movement, apply_modifiers):
12443 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12444 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12445 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12446 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12447 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12448
a053e86c 12449 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12450 (mark_kboards): Move decl here ...
12451 * alloc.c (mark_kboards): ... from here.
a053e86c 12452
4752793e
PE
12453 * lisp.h (force_auto_save_soon): New decl.
12454
74f10ca7 12455 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12456 (DEFINE_DUMMY_FUNCTION): New macro.
12457 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12458 Use it.
c03cd23f
PE
12459 (main): Add casts to avoid warnings
12460 if GCC considers string literals to be constants.
74f10ca7 12461
022e70d4
PE
12462 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12463
59d6fe83
PE
12464 * dbusbind.c: Pointer signedness fixes.
12465 (xd_signature, xd_append_arg, xd_initialize):
12466 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12467 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12468 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12469 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12470
78320123
PE
12471 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12472 if GCC considers string literals to be constants.
49cebcca 12473 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12474
35ac2a97
SM
124752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12476
fb103ca9
SM
12477 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12478 (print_preprocess, print_object): New macro to fix last change.
12479
35ac2a97
SM
12480 * print.c (print_preprocess): Don't forget font objects.
12481
62973b41
JB
124822011-03-16 Juanma Barranquero <lekktu@gmail.com>
12483
12484 * emacs.c (USAGE3): Doc fixes.
12485
0e48bb22
AS
124862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12487
12488 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12489 structure.
12490
7684e57b
JB
124912011-03-14 Juanma Barranquero <lekktu@gmail.com>
12492
12493 * lisp.h (VWindow_system, Qfile_name_history):
12494 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12495 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12496 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12497
12498 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12499 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12500
12501 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12502 * w32console.c (detect_input_pending, read_input_pending)
12503 (encode_terminal_code):
12504 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12505 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12506 (w32_system_caret_y, Qfile_name_history):
12507 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12508 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12509 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12510 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12511 * w32proc.c (Qlocal, report_file_error):
12512 * w32term.c (Vwindow_system, updating_frame):
12513 * w32uniscribe.c (initialized, uniscribe_font_driver):
12514 Remove unneeded extern declarations.
12515
2aa46d6c
CY
125162011-03-14 Chong Yidong <cyd@stupidchicken.com>
12517
c96bbc66 12518 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12519
cffc6f3b
CY
125202011-03-13 Chong Yidong <cyd@stupidchicken.com>
12521
12522 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12523 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12524 These macros can no longer be used for assignment.
12525
44f230aa
SM
12526 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12527 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12528 (record_buffer_markers, fetch_buffer_markers): New functions for
12529 recording and fetching special buffer markers.
12530 (set_buffer_internal_1, set_buffer_temp): Use them.
12531
12532 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12533
12534 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12535
12536 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12537 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12538
12539 * xdisp.c (hscroll_window_tree):
12540 (reconsider_clip_changes): Use PT instead of BUF_PT.
12541
d251f04b
EZ
125422011-03-13 Eli Zaretskii <eliz@gnu.org>
12543
12544 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12545 $(EMACS_ROOT)/lib/intprops.h.
12546
f0c77cd1
PE
125472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12548
3eca4629
PE
12549 Fix more problems found by GCC 4.5.2's static checks.
12550
7c86ee98
PE
12551 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12552 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12553 (xg_free_frame_widgets): Make it clear that a local variable is
12554 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12555 (gdk_window_get_screen): Make it clear that this macro is needed
12556 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12557 (int_gtk_range_get_value): New function, which avoids a diagnostic
12558 from gcc -Wbad-function-cast.
12559 (xg_set_toolkit_scroll_bar_thumb): Use it.
12560 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12561 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12562 (get_utf8_string, xg_get_file_with_chooser):
12563 Rename locals to avoid shadowing.
12564 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12565
41729b81
PE
12566 * xgselect.c (xg_select): Remove unused var.
12567
f0c77cd1
PE
12568 * image.c (four_corners_best): Mark locals as initialized.
12569 (gif_load): Initialize transparent_p to zero (Bug#8238).
12570 Mark another local as initialized.
ec6cf4c6 12571 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12572
ce0ad53d 12573 * image.c (clear_image_cache): Now static.
d5d5a617 12574 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12575 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12576 (x_edge_detection): Remove unnecessary cast that
12577 gcc -Wbad-function-cast diagnoses.
2037898d 12578 (gif_load): Fix pointer signedness.
6ae141d6
PE
12579 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12580 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12581
33383987 125822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12583
d32df629
PE
12584 Improve quality of tests for time stamp overflow.
12585 For example, without this patch (encode-time 0 0 0 1 1
12586 1152921504606846976) returns the obviously-bogus value (-948597
12587 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12588 reports time overflow. See
12589 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12590 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12591 * editfns.c: Include limits.h and intprops.h.
12592 (TIME_T_MIN, TIME_T_MAX): New macros.
12593 (time_overflow): Move earlier, to before first use.
12594 (hi_time, lo_time): New functions, for an accurate test for
12595 out-of-range times.
12596 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12597 (Fget_internal_run_time): Don't assume time_t fits in int.
12598 (make_time): Use list2 instead of Fcons twice.
12599 (Fdecode_time): More accurate test for out-of-range times.
12600 (check_tm_member): New function.
12601 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12602 (lisp_time_argument): Don't rely on undefined left-shift and
12603 right-shift behavior when checking for time stamp overflow.
8be6f318 12604
fe31d94c
PE
12605 * editfns.c (time_overflow): New function, refactoring common code.
12606 (Fformat_time_string, Fdecode_time, Fencode_time):
12607 (Fcurrent_time_string): Use it.
12608
8be6f318
PE
12609 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12610 * dired.c (make_time): Move to ...
12611 * editfns.c (make_time): ... here.
12612 * systime.h: Note the move.
12613
09d9db2c 126142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12615
126bc0dc
YM
12616 * fringe.c (update_window_fringes): Remove unused variables.
12617
c47cbdfd
YM
12618 * unexmacosx.c (copy_data_segment): Also copy __got section.
12619 (Bug#8223)
12620
7ac80be9
EZ
126212011-03-12 Eli Zaretskii <eliz@gnu.org>
12622
c96bbc66 12623 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12624 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12625 Constify `char *' arguments and their references according to
12626 prototypes in tparam.h.
12627
ecb0f94d 12628 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12629
7ac80be9
EZ
12630 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12631 Adapt all references accordingly.
12632
12633 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12634
ef1fd07e
TT
126352011-03-11 Tom Tromey <tromey@redhat.com>
12636
12637 * buffer.c (syms_of_buffer): Remove obsolete comment.
12638
7ef4b50c
EZ
126392011-03-11 Eli Zaretskii <eliz@gnu.org>
12640
12641 * termhooks.h (encode_terminal_code): Declare prototype.
12642
12643 * msdos.c (encode_terminal_code): Don't declare prototype.
12644
12645 * term.c (encode_terminal_code): Now external again, used by
12646 w32console.c and msdos.c.
12647
44f230aa
SM
12648 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12649 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12650
4b1ec863 126512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12652
1714f52b 12653 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12654
4b1ec863
PE
12655 * fringe.c (update_window_fringes): Mark locals as initialized
12656 (Bug#8227).
12657 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12658
524c7aa6
PE
12659 * alloc.c (mark_fringe_data): Move decl from here ...
12660 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12661 to check its interface.
12662 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12663
a5c0af81 12664 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12665 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12666 (fontset_font): Mark local as initialized.
a9a06e0b 12667 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12668
b4716021
PE
12669 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12670
811e9bac 12671 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12672 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12673 (x_own_selection, Fx_disown_selection_internal): Rename locals
12674 to avoid shadowing.
12675 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12676
7e3ab302
PE
12677 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12678 so that the caller can use some name other than gcpro1.
12679 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12680 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12681 (Fx_backspace_delete_keys_p):
12682 Use them to avoid shadowing, and rename vars to avoid shadowing.
12683 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12684 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12685 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12686 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12687 Remove unused locals.
7e3ab302
PE
12688 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12689 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12690 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12691 macros.
f78faa98 12692
e2b13473
PE
12693 * xterm.h (x_mouse_leave): New decl.
12694
77f23912
PE
12695 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12696 Remove unused functions.
cdf4ba58
PE
12697 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12698 (x_calc_absolute_position): Now static.
7411c686 12699 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12700 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12701 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12702 unless they are used.
38d0b34a
PE
12703 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12704 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12705 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12706 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12707 (x_error_catcher, x_connection_closed, x_error_handler):
12708 (x_error_quitter, xembed_send_message, x_iconify_frame):
12709 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12710 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12711 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12712
44f230aa
SM
12713 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12714 Rename or move locals to avoid shadowing.
6b463e58 12715 (tty_defined_color, merge_face_heights): Now static.
5967d051 12716 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12717 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12718 does not deduce is never used uninitialized.
73719eba
PE
12719 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12720 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12721
426994c3 12722 * terminal.c (store_terminal_param): Now static.
5489860b 12723
032f1620 12724 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12725 (set_frame_menubar): Remove unused local.
d4323972 12726 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12727 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12728 since they might point to immutable storage.
281585b0
PE
12729 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12730 since it's unused otherwise.
032f1620 12731
367c19e5 12732 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12733 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12734 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12735 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12736 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12737 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12738 does not deduce are never used uninitialized.
70739cbe 12739
07b48fa9
PE
12740 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12741
8868a238 12742 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12743 * window.c (window_loop, size_window):
12744 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12745
7e5cf297 12746 * window.c (display_buffer): Now static.
d6550a9f
PE
12747 (size_window): Mark variables that gcc -Wuninitialized
12748 does not deduce are never used uninitialized.
a586633d
PE
12749 * window.h (check_all_windows): New decl, to forestall
12750 gcc -Wmissing-prototypes diagnostic.
5b555da1 12751 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12752
f6095868
PE
12753 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12754 shadowing.
12755 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12756 Include <limits.h>.
12757 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12758 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12759 (load_charset_map): Mark variables that gcc -Wuninitialized
12760 does not deduce are never used uninitialized.
53df7c11 12761 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12762
f38b440c
PE
12763 * coding.c (coding_set_source, coding_set_destination):
12764 Use "else { /* comment */ }" rather than "else /* comment */;"
12765 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12766 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12767 a block, when the outer 'i' will do.
12768 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12769 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12770 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12771 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12772 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12773 Rename locals to avoid shadowing.
12774 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12775 * coding.c (emacs_mule_char, encode_invocation_designation):
12776 Now static, since they're not used elsewhere.
413bb2db 12777 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12778 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12779 (decode_coding_emacs_mule): Mark variables that gcc
12780 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12781 (detect_coding_iso_2022): Initialize a local variable that might
12782 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12783 this initialization is needed. (Bug#8211)
5f58e762
PE
12784 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12785 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12786 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12787 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12788 Remove unused macros.
f38b440c 12789
232b38b9 12790 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12791 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12792 * character.c (string_count_byte8): Likewise.
232b38b9 12793
fb90da1b
PE
12794 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12795 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12796
fb93dbc2
PE
12797 * chartab.c (copy_sub_char_table): Now static, since it's not used
12798 elsewhere.
5c156ace
PE
12799 (sub_char_table_ref_and_range, char_table_ref_and_range):
12800 Rename locals to avoid shadowing.
bbcd0949 12801 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12802
7d3b3862 12803 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12804 (BIDI_BOB): Remove unused macro.
7d3b3862 12805
6be7d3da
PE
12806 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12807 deduce are never used uninitialized.
c2ed9c8b 12808 * term.c (encode_terminal_code): Likewise.
6be7d3da 12809
75f8807f 12810 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12811
50938595
PE
12812 * tparam.h: New file.
12813 * term.c, tparam.h: Include it.
12814 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12815 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12816 Move these decls to tparam.h, and make them agree with what
12817 is actually in tparam.c. The previous trick of using incompatible
12818 decls in different modules does not conform to the C standard.
12819 All callers of tparam changed to use tparam's actual API.
12820 * tparam.c (tparam1, tparam, tgoto):
12821 Use const pointers where appropriate.
12822
fbceeba2
PE
12823 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12824 * cm.h (struct cm): Likewise.
12825 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12826 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12827 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12828 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12829 (turn_on_face, init_tty): Likewise.
12830 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12831
7f3f1250
PE
12832 * term.c (term_mouse_position): Rename local to avoid shadowing.
12833
e6ca6543
PE
12834 * alloc.c (mark_ttys): Move decl from here ...
12835 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12836
c40f8d15
AS
128372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12838
12839 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12840
cfe0661d
JB
128412011-03-09 Juanma Barranquero <lekktu@gmail.com>
12842
12843 * search.c (compile_pattern_1): Remove argument regp, unused since
12844 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12845 (compile_pattern): Don't pass it.
12846
0afb4571
J
128472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12848
12849 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12850 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12851 for ! HAVE_GTK3.
12852 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12853
12854 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12855
12856 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12857 gdk_window_get_screen, gdk_window_get_geometry,
12858 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12859 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12860 (xg_get_pixbuf_from_pixmap): New function.
12861 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12862 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12863 Call xg_get_pixbuf_from_pixmap instead of
12864 gdk_pixbuf_get_from_drawable.
12865 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12866 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12867 (xg_check_special_colors): Use GtkStyleContext and its functions
12868 for HAVE_GTK3.
12869 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12870 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12871 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12872 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12873 Call gtk_widget_get_preferred_size.
0afb4571
J
12874 (xg_frame_resized): gdk_window_get_geometry only takes 5
12875 parameters.
44f230aa
SM
12876 (xg_win_to_widget, xg_event_is_for_menubar):
12877 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12878 (xg_set_widget_bg): New function.
12879 (delete_cb): New function.
895009e1 12880 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12881 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12882 (xg_set_background_color): Call xg_set_widget_bg.
12883 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12884 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12885 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12886 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12887 if ! HAVE_GTK3.
12888 (update_frame_tool_bar): Call gtk_widget_hide.
12889 (xg_initialize): Use GDK_KEY_g.
12890
12891 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12892 if ! HAVE_GTK3
12893 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12894
12895 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12896 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12897 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12898
1c2cc4ef
JB
128992011-03-08 Juanma Barranquero <lekktu@gmail.com>
12900
12901 * w32xfns.c (select_palette): Check success of RealizePalette against
12902 GDI_ERROR, not zero.
12903
33383987 12904See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12905
12906;; Local Variables:
12907;; coding: utf-8
aac0c6e3
MR
12908;; End:
12909
2f097256 12910 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12911
12912 This file is part of GNU Emacs.
12913
12914 GNU Emacs is free software: you can redistribute it and/or modify
12915 it under the terms of the GNU General Public License as published by
12916 the Free Software Foundation, either version 3 of the License, or
12917 (at your option) any later version.
12918
12919 GNU Emacs is distributed in the hope that it will be useful,
12920 but WITHOUT ANY WARRANTY; without even the implied warranty of
12921 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12922 GNU General Public License for more details.
12923
12924 You should have received a copy of the GNU General Public License
12925 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.