Drop WGET and revert read access to Lisp_Objects slots of struct window.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d3d50620
DA
12012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Drop WGET and revert read access to Lisp_Objects slots of struct window.
4 * window.h (WGET): Remove.
5 (struct window): Do not use INTERNAL_FIELD.
6 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
7 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
8 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
9 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
10 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
11 Adjust users.
12
d10a51dc
CY
132012-08-07 Chong Yidong <cyd@gnu.org>
14
15 * window.c (Fwindow_edges, Fwindow_pixel_edges)
16 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
17 (Fdelete_window_internal): Signal an error if the window is not on
18 a live frame (Bug#12025).
19
e69b0960
DA
202012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
21
22 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
23 * frame.h (FGET): Remove.
24 (struct frame): Do not use INTERNAL_FIELD.
25 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
26 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
27 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
28 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
29
25a20a3a
JB
302012-08-06 Juanma Barranquero <lekktu@gmail.com>
31
32 * w32.c: Silence compiler warnings.
33 (map_w32_filename): Remove unused variable `is_fat'.
34 (chase_symlinks): Add parentheses around expression.
35
1c6f11f4
GM
362012-08-06 Glenn Morris <rgm@gnu.org>
37
1db4583a
GM
38 * sysdep.c: Respect BROKEN_GETWD.
39
1c6f11f4
GM
40 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
41 Let configure handle it.
42 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
43
2b90362b
DA
442012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
45
46 Use GCALIGNMENT where appropriate.
47 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
48 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
49 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
50
5f50daf2
EZ
512012-08-06 Eli Zaretskii <eliz@gnu.org>
52
53 * w32menu.c (set_frame_menubar, initialize_frame_menubar): Don't
54 use FRAME_MENU_BAR_ITEMS as an lvalue.
55
cbcc7007
SM
562012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
57
58 * buffer.h (struct buffer): Revert `indirections' to a simple int;
59 that should be sufficient for everyone.
60
4d365fa4
JD
612012-08-06 Jan Djärv <jan.h.d@swipnet.se>
62
63 * keyboard.c (timer_check_2): Add break so timer_check returns next
64 timeout.
65
dd86bd82
DA
662012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
67
68 Fix Windows build errors introduced after converting to WGET and WSET.
69 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
70 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
71
054e1668
JD
722012-08-06 Jan Djärv <jan.h.d@swipnet.se>
73
74 * nsterm.m (ns_frame_rehighlight): Use FSET.
75
76 * nsmenu.m (ns_update_menubar): Use FSET.
77
21238f11
DA
782012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
79
80 Separate read and write access to Lisp_Object slots of Lisp_Process.
81 * process.h (PGET, PSET): New macros similar to AREF and ASET.
82 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
83
077288cf
DA
842012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
85
86 Separate read and write access to Lisp_Object slots of struct window.
87 * window.h (WGET, WSET): New macros similar to AREF and ASET.
88 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
89 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
90 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
91 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
92 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
93 Adjust users.
94
71688bd7
DA
952012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
96
97 Fix Windows build errors introduced after converting to FGET and FSET.
98 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
99 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
100 (w32_judge_scroll_bars): Change to use FSET.
101 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
102
f99bac93
DA
1032012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Fix replacement typo.
106 * window.c (replace_window): Set root_window instead of
107 selected_window. This fixes a total window subsystem
108 malfunction reported by Bastien Guerry <bzg@gnu.org>.
109
8c2a0f2d
GM
1102012-08-06 Glenn Morris <rgm@gnu.org>
111
112 * lisp.mk (lisp): Add language/persian.elc.
113
edd74c35
DA
1142012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
115
116 Separate read and write access to Lisp_Object slots of struct frame.
117 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
118 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
119 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
120 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
121 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
122
8671676c
AS
1232012-08-05 Andreas Schwab <schwab@linux-m68k.org>
124
125 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
126
663e2b3f
DA
1272012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
128
129 Generalize common compile-time constants.
130 * lisp.h (header_size, bool_header_size, word_size): Now here.
131 (struct Lisp_Vector): Add comment.
132 (struct Lisp_Bool_Vector): Move up to define handy constants.
133 (VECSIZE, PSEUDOVECSIZE): Simplify.
134 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
135 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
136 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
137 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
138 * xfont.c, xmenu.c: Use word_size where appropriate.
139
d32e47af
LM
1402012-08-05 Lawrence Mitchell <wence@gmx.li>
141
142 * search.c (Freplace_match): Treat \? in the replacement text
143 literally (Bug#8161).
144
e5d9c0d1
CY
1452012-08-05 Chong Yidong <cyd@gnu.org>
146
147 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
148 * frame.c (Vdelete_frame_functions):
149 * emacs.c (Vkill_emacs_hook): Doc fix.
150
8da0576b
EZ
1512012-08-04 Eli Zaretskii <eliz@gnu.org>
152
153 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
154 --with-x-toolkit=no builds.
155 Reported by Carsten Mattner <carstenmattner@gmail.com>.
156
02676e5d
CY
1572012-08-04 Chong Yidong <cyd@gnu.org>
158
159 * syntax.c (Fmodify_syntax_entry): Doc fix.
160
97147da9
EZ
1612012-08-04 Eli Zaretskii <eliz@gnu.org>
162
76151e2c
EZ
163 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
164 * w32.c (init_environment): Change the default values of many
165 environment variables in dflt_envvars[] to NULL, to avoid pushing
166 them into environment when they were not already defined. Remove
167 the code that deletes site-lisp subdirectories from the default
168 value of EMACSLOADPATH, as it is no longer needed.
169 (check_windows_init_file): Now external, not static. Use
170 Vload_path as is, without adding anything, as this function is now
171 called when Vload_path is already set up.
172
173 * w32.h (check_windows_init_file): Add prototype.
174
175 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
176 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
177 compatibility with Posix platforms.
178 (main): Move the call to check_windows_init_file to here from
179 w32.c.
180 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
181 any, in the DEFALT argument into the root of the Emacs build or
182 installation tree, as appropriate.
183
184 * callproc.c (init_callproc_1): Call decode_env_path instead of
185 doing its equivalent by hand.
186 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
187 the code that sets Vexec_path run on MS-Windows.
188
189 * lread.c (init_lread): Add comments to #ifdef's.
190
97147da9
EZ
191 * msdos.c (dos_set_window_size, IT_update_begin)
192 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
193 instead of direct references.
194
185ee146
PE
1952012-08-04 Paul Eggert <eggert@cs.ucla.edu>
196
197 Export DEFAULT_REHASH_* to GDB.
198 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
199 Now constants, not macros.
200
8834c57a
PE
2012012-08-03 Paul Eggert <eggert@cs.ucla.edu>
202
98c6f1e3
PE
203 Remove unnecessary casts involving pointers.
204 These casts are no longer needed now that we assume C89 or later,
205 since they involve casting to or from void *.
206 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
207 (make_pure_float, make_pure_vector):
208 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
209 * macros.c (Fstart_kbd_macro):
210 * menu.c (find_and_return_menu_selection):
211 * minibuf.c (read_minibuf_noninteractive):
212 * sysdep.c (closedir):
213 * xdisp.c (x_produce_glyphs):
214 * xfaces.c (compare_fonts_by_sort_order):
215 * xfns.c (x_real_positions, select_visual):
216 * xselect.c (x_stop_queuing_selection_requests)
217 (x_get_window_property, x_get_window_property_as_lisp_data):
218 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
219 Remove unnecessary pointer casts.
220 * alloc.c (record_xmalloc): New function.
221 * lisp.h (record_xmalloc): New decl.
222 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
223 more like a function. This is because the pointer cast is not
224 needed. All uses changed.
225 * print.c (print_string, print_error_message): Avoid length recalc.
226
8834c57a
PE
227 Improve fix for macroexp crash with debugging (Bug#12118).
228 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
229 ARRAY_MARK_FLAG when checking subscripts, because ASET is
230 not supposed to be invoked from the garbage collector.
231 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
232 (gc_aset): New function, which is like ASET but can be
233 used in the garbage collector.
234 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
235 (set_hash_index): Use it instead of ASET.
236
6dad7178
EZ
2372012-08-03 Eli Zaretskii <eliz@gnu.org>
238
239 Support symlinks on latest versions of MS-Windows.
240 * w32.c: Include winioctl.h and aclapi.h.
241 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
242 (revert_to_self): Forward declarations of static functions.
243 <static BOOL g_b_init_get_security_info>:
244 <g_b_init_create_symbolic_link>: New static flags.
245 (globals_of_w32): Initialize them to zero.
246 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
247 (map_w32_filename): Improve commentary. Simplify switch.
248 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
249 headers (most versions of MinGW w32api don't).
250 (get_security_info, create_symbolic_link)
251 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
252 New functions.
253 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
254 in the argument file name.
255 (sys_access): Call unc_volume_file_attributes only if
256 GetFileAttributes fails with network-related error codes.
257 (sys_rename): Diagnose renaming of a symlink when the user doesn't
258 have the required privileges.
259 (get_file_security_desc_by_name): Renamed from
260 get_file_security_desc.
261 (stat_worker): New function, with most of the guts of 'stat', and
262 with addition of handling of symlinks and support for 'lstat'. If
263 possible, get file's attributes and security information by
264 handle, not by name. Produce S_IFLNK bit for symlinks, when
265 called from 'lstat'.
266 (stat, lstat): New functions, call 'stat_worker'.
267 (symlink, readlink, careadlinkat): Rewritten to create and resolve
268 symlinks when the underlying filesystem supports them.
269
f162bcc3
PE
2702012-08-02 Paul Eggert <eggert@cs.ucla.edu>
271
79ea6c20
PE
272 Fix macroexp crash on Windows with debugging (Bug#12118).
273 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
274 checking subscripts; problem introduced with the recent
275 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
276 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
277 since it's used in non-static inline functions now.
278
c0ce93fd
PE
279 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
280 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 281
f162bcc3
PE
282 Use C99-style 'extern inline' if available.
283 * buffer.h (BUFFER_INLINE):
284 * category.h (CATEGORY_INLINE):
285 * character.h (CHARACTER_INLINE):
286 * charset.h (CHARSET_INLINE):
287 * composite.h (COMPOSITE_INLINE):
288 * dispextern.h (DISPEXTERN_INLINE):
289 * lisp.h (LISP_INLINE):
290 * systime.h (SYSTIME_INLINE):
291 New macro, replacing 'static inline' in this header.
292 * buffer.h, category.h, character.h, charset.h, composite.h:
293 * dispextern.h, lisp.h, systime.h:
294 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
295 * alloc.c (LISP_INLINE):
296 * buffer.c (BUFFER_INLINE):
297 * category.c (CATEGORY_INLINE):
298 * character.c (CHARACTER_INLINE):
299 * charset.c (CHARSET_INLINE):
300 * composite.c (COMPOSITE_INLINE):
301 * dispnew.c (DISPEXTERN_INLINE):
302 * sysdep.c (SYSTIME_INLINE):
303 Define to EXTERN_INLINE, so that the corresponding functions
304 are compiled into code.
305 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
306 (INLINE_HEADER_END): New macros.
307 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
308 since it's used in non-static inline functions now.
a8333d03 309 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 310
837b365b
GM
3112012-08-02 Glenn Morris <rgm@gnu.org>
312
d66b744d
GM
313 * s/: Remove empty directory.
314
837b365b
GM
315 * s/ms-w32.h: Move to ../nt/inc.
316 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
317 Update for new ms-w32.h location.
318
13294f95
PE
3192012-08-02 Paul Eggert <eggert@cs.ucla.edu>
320
321 Port to Solaris 8.
322 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
323
90df0db3
GM
3242012-08-02 Glenn Morris <rgm@gnu.org>
325
326 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
327 hard-coding the path separator.
328
4939150c
PE
3292012-08-01 Paul Eggert <eggert@cs.ucla.edu>
330
331 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
332 This how ASET and AREF are supposed to work, and makes
333 it easier to think about future improvements. See
334 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
335 * charset.h (set_charset_attr): New function.
336 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
337 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
338 (aref_addr): New function. All uses of &AREF(...) changed.
339 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
340 (set_hash_index): New functions. All lvalue-style uses of
341 HASH_KEY etc. changed.
342 * keyboard.c (set_prop): New function. All lvalue-style uses
343 of PROP changed.
344
947b2afd
AA
3452012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
346
347 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
348 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
349 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
350 * nsfns.m (ns_set_name_as_filename): Likewise.
351 * nsmenu.m (ns_update_menubar): Likewise.
352 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
353
4f5d0325
EZ
3542012-08-01 Eli Zaretskii <eliz@gnu.org>
355
2008beae
EZ
356 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
357 Adapt to latest changes in field names of the corresponding Lisp
288479f6 358 objects.
2008beae 359
4f5d0325
EZ
360 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
361
fe3cc771
GM
3622012-08-01 Glenn Morris <rgm@gnu.org>
363
364 * s/msdos.h: Remove file.
365 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
366 * Makefile.in (S_FILE): Remove.
367 (config_h): Remove S_FILE.
368
c90acc54
JB
3692012-08-01 Juanma Barranquero <lekktu@gmail.com>
370
371 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
372 Remove; moved to nt/config.nt.
373
d8a05828
DA
3742012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
375
376 Use INTERNAL_FIELD for conses and overlays.
377 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
378 Remove obsolete comment.
379 (MVAR): New macro.
380 (struct Lisp_Overlay): Use INTERNAL_FIELD.
381 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
382
8271d590
DA
3832012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
384
385 Use INTERNAL_FIELD for symbols.
386 * lisp.h (SVAR): New macro. Adjust users.
387 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
388 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
389
3193acd2
DA
3902012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
391
392 Use INTERNAL_FIELD for processes.
393 * process.h (PVAR): New macro. Adjust style.
394 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
395 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
396
3a45383a
DA
3972012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
398
399 Use INTERNAL_FIELD for windows.
400 * window.h (WVAR): New macro.
401 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
402 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
403 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
404 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
405 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
406 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
407
c1dbc63c
PE
4082012-08-01 Paul Eggert <eggert@cs.ucla.edu>
409
410 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
411
5c0c0e8a
GM
4122012-08-01 Glenn Morris <rgm@gnu.org>
413
414 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
415 Move to configure.ac.
416
552a99b4
JB
4172012-08-01 Juanma Barranquero <lekktu@gmail.com>
418
419 * makefile.w32-in (CONFIG_H): Update dependencies.
420 (CONF_POST_H): New macro.
421
422 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
423
8d8e2dfe
GM
4242012-07-31 Glenn Morris <rgm@gnu.org>
425
bc96620a
GM
426 * Makefile.in (S_FILE): No longer set by configure.
427
476b1b2d
GM
428 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
429 is available.
430 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
431
b2c7a106
GM
432 * process.h (NULL_DEVICE):
433 * emacs.c (SEPCHAR):
434 * editfns.c (USER_FULL_NAME): Let configure set them.
435
d53d062a
GM
436 * s/README, s/template.h: Remove files.
437
4515017f
GM
438 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
439
8d8e2dfe
GM
440 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
441 Move to configure.ac.
442
5b20b3cc
EZ
4432012-07-31 Eli Zaretskii <eliz@gnu.org>
444
1e0afd9a
EZ
445 * .gdbinit (xframe): Adapt to introduction of FVAR and the
446 resulting renaming of 'struct frame' members.
447
5b20b3cc
EZ
448 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
449
450 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
451 after introduction of FVAR.
452
f1310128
JD
4532012-07-31 Jan Djärv <jan.h.d@swipnet.se>
454
79e721e0
JD
455 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
456
457 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
458 instead of compositeToPoint.
459 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
460
8d7c7eed 461 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 462
e34f7f79
DA
4632012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
464
465 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
466 * lisp.h (INTERNAL_FIELD): New macro.
467 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
468 (BVAR): Change to use INTERNAL_FIELD.
469 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
470 (KVAR): Change to use INTERNAL_FIELD.
471 * frame.h (FVAR): New macro.
472 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
473 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
474 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
475 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
476 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
477
c09bfb2f
DA
4782012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
479
480 Miscellaneous fixes for non-default X toolkits.
481 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
482 * xterm.c (x_frame_of_widget): Remove redundant prototype.
483 Move under #ifdef USE_LUCID.
484 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
485 definition and usage to avoid warnings.
486
14c114ae
JD
4872012-07-31 Jan Djärv <jan.h.d@swipnet.se>
488
489 * nsterm.m (openFiles): Fix previous checkin.
490
3bd21e82
PE
4912012-07-31 Paul Eggert <eggert@cs.ucla.edu>
492
493 * indent.c (compute_motion): Remove unused local.
494
c1529ded
GM
4952012-07-31 Glenn Morris <rgm@gnu.org>
496
400d5621
GM
497 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
498
268e2432
GM
499 * conf_post.h [USG5_4]:
500 Move remaining contents of s/usg5-4-common.h here.
501 * s/usg5-4-common.h: Remove file.
502
7552f3ee
GM
503 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
504 * s/irix6-5.h: Remove file.
505
6a381852
GM
506 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
507 * s/darwin.h: Remove file.
508
c1529ded
GM
509 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
510 * s/hpux10-20.h: Remove file, which is now empty.
511
b429a4ee
GM
5122012-07-30 Glenn Morris <rgm@gnu.org>
513
514 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
515 * Makefile.in (config_h): Add conf_post.h.
516 * makefile.w32-in (CONFIG_H): Add conf_post.h.
517
adff3182
JD
5182012-07-30 Jan Djärv <jan.h.d@swipnet.se>
519
520 * nsterm.m (ns_do_open_file): New variable.
b9031d69 521 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
522 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
523 files only if ns_do_open_file.
524
c32af1e4
PE
5252012-07-30 Paul Eggert <eggert@cs.ucla.edu>
526
7393bcbb
PE
527 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
528 This no-op macro hasn't been needed for many years.
529 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
530
c32af1e4
PE
531 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
532 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
533 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
534 gdb_make_enums_visible.
535 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
536 (DIRECTORY_SEP): Now a constant, not a macro.
537
302fc036
EZ
5382012-07-30 Eli Zaretskii <eliz@gnu.org>
539
540 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
541 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
542
543 * w32term.c <w32_keyboard_codepage>: Renamed from
544 keyboard_codepage and now external. All users changed.
545
546 * w32term.h: Add declaration of w32_keyboard_codepage.
547
548 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
549 the codepage to translate keys to Unicode. If this argument is
550 -1, use the value returned by GetConsoleCP. All callers changed.
551
88fb40b4
PE
5522012-07-30 Paul Eggert <eggert@cs.ucla.edu>
553
0aee6912
PE
554 Update .PHONY listings in makefiles.
555 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
556 bootstrap-clean, distclean, maintainer-clean, versioclean,
557 extraclean, frc.
558
88fb40b4
PE
559 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
560 This is a bit clearer. Fix some commentary typos.
561
0a763bd1
GM
5622012-07-30 Glenn Morris <rgm@gnu.org>
563
32bac6d6
GM
564 * s/netbsd.h: Let configure include signal.h if needed.
565 Remove file, which is now empty.
566
b65e7c46
GM
567 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
568 Let configure set them.
569 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
570 No more need to undefine.
0a763bd1 571
169304bd
AS
5722012-07-30 Andreas Schwab <schwab@linux-m68k.org>
573
574 * keymap.c (Fkey_description): Don't remove 0x80 bit from
575 non-single-byte char when adding meta modifier. (Bug#12090)
576
6cd7a139
DA
5772012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
578
579 Convert safe_call to use variable number of arguments.
580 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
581 (safe_call2): Fix comment.
582 * lisp.h (safe_call): Adjust prototype.
583 * coding.c (encode_coding_object): Change to use safe_call2.
584 * xfaces.c (merge_face_heights): Change to use safe_call1.
585
d34d6ffc
GM
5862012-07-30 Glenn Morris <rgm@gnu.org>
587
7b8a48e4 588 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 589 does that unconditionally. Remove file, which is now empty.
7b8a48e4 590
d34d6ffc
GM
591 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
592 Remove empty files.
593
03a660a6
PE
5942012-07-30 Paul Eggert <eggert@cs.ucla.edu>
595
596 Export to GDB most of lisp.h's remaining object-like macros.
597 * lisp.h (min, max): Move earlier, because they're used earlier now.
598 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
599 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
600 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
601 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
602 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
603 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
604 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
605 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
606 Now constants, for GDB. They need not be macros.
607 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
608 Now constants, for GDB, as well as macros, for static initializers.
609 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
610 Move to after the definition of struct Lisp_Char_Table,
611 since the former now needs that type defined.
612 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
613 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
614 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
615 New enums, for gdb_make_enums_visible.
616 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 617 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
618 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
619 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
620 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
621 enum maxargs, enum MAX_ALLOCA.
622 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
623 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
624 no longer needed, now that they are done in lisp.h.
625
e499d0ee
DA
6262012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
627
628 Cleanup string bytes checking.
629 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
630 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
631 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
632 (check_sblock, compact_small_strings): Simplify.
633
d5040d2d
PE
6342012-07-29 Paul Eggert <eggert@cs.ucla.edu>
635
636 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
637 These macros are confusing and no longer need to be defined, as
638 the enum values now suffice. All uses replaced with definiens.
639 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
640
7f259ae6
JB
6412012-07-29 Juanma Barranquero <lekktu@gmail.com>
642
643 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
644 ($(BLD)/w32console.$(O)): Update dependencies.
645
7e63e0c3
DA
6462012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
647
648 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
649 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
650 time. Adjust users.
651 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
652
ffd817eb
JD
6532012-07-29 Jan Djärv <jan.h.d@swipnet.se>
654
655 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
656 setting sitelisp (Bug#12010).
657
417a7a0e
EZ
6582012-07-29 Eli Zaretskii <eliz@gnu.org>
659
660 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
661
662 * w32heap.c (cache_system_info):
663 * w32.c (sys_rename):
664 * w32proc.c (find_child_console, sys_kill): All users changed.
665
387d4d92
PE
6662012-07-29 Paul Eggert <eggert@cs.ucla.edu>
667
668 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
669
55a6cca6
EZ
6702012-07-29 Eli Zaretskii <eliz@gnu.org>
671
672 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
673
dbcf001c
DA
6742012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
675
676 Cleanup statistics calculation in Fgarbage_collect.
677 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
678 zombies percentage calculation. Simplify elapsed time calculation.
679
e2688e4a
DA
6802012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
681
682 Generalize marker debugging code under MARKER_DEBUG and use eassert.
683 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
684 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
685 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
686 (replace_range, replace_range_2, del_range_2): Change to eassert.
687 * marker.c (byte_char_debug_check): Adjust style.
688
b46a6a83
PE
6892012-07-29 Paul Eggert <eggert@cs.ucla.edu>
690
691 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
692 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
693 long-ago-commented-out code that talks about "WIN32".
694 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
695 All uses changed.
696
e32a5799
PE
6972012-07-28 Paul Eggert <eggert@cs.ucla.edu>
698
699 Use Gnulib stdalign module (Bug#9772, Bug#9960).
700 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
701 Simplify by using alignof.
702 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
703 * lisp.h: Include <stdalign.h>.
704 (GCALIGNMENT): New macro and constant.
705 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
706 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
707 (stdalign): New macro, if not already defined.
708
df81cd29
EZ
7092012-07-28 Eli Zaretskii <eliz@gnu.org>
710
01bd1b0d
EZ
711 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
712 * w32inevt.c: Include w32inevt.h.
713 (w32_read_console_input): New inline function, calls either
714 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
715 w32_console_unicode_input.
716 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
717 (w32_kbd_patch_key, key_event): Use the codepage returned by
718 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
719 (key_event): use uChar.UnicodeChar only if
720 w32_console_unicode_input is non-zero.
721
722 * w32console.c: Include w32heap.h.
723 <w32_console_unicode_input>: New global variable.
724 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
725 family of Windows, zero otherwise.
726
727 * w32inevt.h: Declare w32_console_unicode_input.
728
df81cd29
EZ
729 * xdisp.c (init_iterator): Don't reference tip_frame in a build
730 --without-x. (Bug#11742)
731
c20fdd9e
PE
7322012-07-27 Paul Eggert <eggert@cs.ucla.edu>
733
734 Adjust GDB to reflect pvec_type changes (Bug#12036).
735 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
736 2012-07-04 changes to pseudovector representation. Problem
737 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
738
32770973 7392012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
740
741 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
742 bus address.
743 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
744
3438fe21
EZ
7452012-07-27 Eli Zaretskii <eliz@gnu.org>
746
bcfbc9de
EZ
747 * alloc.c (listn): Fix the order the arguments are consed onto the
748 list.
749
3438fe21
EZ
750 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
751 enumeration constants, as PURE and HEAP are too general, and clash
752 with other headers and sources, such as gmalloc.c and the
753 MS-Windows system headers. All users changed.
754
eeaea515
DA
7552012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Revert last save_excursion_save and save_excursion_restore changes.
758 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
759 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
760
073c88c2
DA
7612012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
762
763 Fix recently-introduced typos in Windows port.
764 Reported by Martin Rudalics <rudalics@gmx.at>.
765 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 766 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 767
4706125e
PE
7682012-07-27 Paul Eggert <eggert@cs.ucla.edu>
769
770 Improve GDB symbol export (Bug#12036).
771 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
772 arms of an 'if', not using conditional expressions; otherwise GDB
773 complains about the types in the unevaluated arm when the argument
774 is an integer literal.
775 (xgetint): Simplify expression.
776 * alloc.c (gdb_make_enums_visible): New constant. This ports to
777 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
778 Zaretskii in <http://bugs.gnu.org/12036#13>.
779 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
780 needed now that we have gdb_make_enums_visible.
781 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
782 (enum enum_USE_LSB_TAG):
783 New enum types, packaging up enums that need to be exported to GDB.
784
694b6c97
DA
7852012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
786
787 Utility function to make a list from specified amount of objects.
788 * lisp.h (enum constype): New datatype.
789 (listn): New prototype.
790 * alloc.c (listn): New function.
791 (Fmemory_use_count, syms_of_alloc): Use it.
792 * buffer.c (syms_of_buffer): Likewise.
793 * callint.c (syms_of_callint): Likewise.
794 * charset.c (define_charset_internal): Likewise.
795 * coding.c (syms_of_coding): Likewise.
796 * keymap.c (syms_of_keymap): Likewise.
797 * search.c (syms_of_search): Likewise.
798 * syntax.c (syms_of_syntax): Likewise.
799 * w32.c (init_environment): Likewise.
800 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
801 * xdisp.c (syms_of_xdisp): Likewise.
802 * xfns.c (syms_of_xfns): Likewise.
803
6195f384
DA
8042012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
805
806 Fast save_excursion_save and save_excursion_restore.
807 * lisp.h (struct Lisp_Excursion): New data type.
808 (PVEC_EXCURSION): New pseudovector type.
809 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
810 to deal with it. Adjust comments.
811 (init_marker, attach_marker): New prototype.
812 (unchain_marker): Adjust prototype.
813 * marker.c (attach_marker): Change to global.
814 (init_marker): New function.
815 * alloc.c (Fmake_marker, build_marker): Use it.
816 (build_marker): More easserts.
817 (mark_object): Handle struct Lisp_Excursion.
818 * editfns.c (save_excursion_save, save_excursion_restore):
819 Reimplement to use struct Lisp_Excursion. Add comments.
820
5eceb8fb
PE
8212012-07-26 Paul Eggert <eggert@cs.ucla.edu>
822
823 Fix export of symbols to GDB (Bug#12036).
824 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
825 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
826 emacs.c, as this is a more-suitable home. Had this been done earlier
827 the fix for 12036 would have avoided some of the problems noted in
828 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
829 would have been more obvious.
562157c8
PE
830 * emacs.c: Do not include <verify.h>; no longer needed.
831 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
832 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
833 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
834 Remove; now done in lisp.h.
835 * lisp.h (PUBLISH_TO_GDB): New macro.
836 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
837 (DATA_SEG_BITS): Use it.
838 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
839 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
840 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
841 not be usable in #if. This simplifies things.
842
d6749401
JB
8432012-07-26 Juanma Barranquero <lekktu@gmail.com>
844
845 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
846
1781b9e9
PE
8472012-07-26 Paul Eggert <eggert@cs.ucla.edu>
848
d89518db 849 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
850 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
851 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
852 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
853 Adjust to changes in lisp.h and emacs.c, by using
854 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
855 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
856 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
857 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
858 instead of gdb_valbits.
859 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
860 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
861 instead of gdb_array_mark_flag.
862 (xboolvector): Get size from $->size, not $->header.size.
863 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
864 (xreload, hook-run, hookpost-run): Remove.
865 * emacs.c: Include <verify.h>.
866 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
867 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
868 Remove.
869 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
870 (gdb_USE_LSB_TAG): New enum constants.
871 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
872 Also define these as enum constants, so they're visible to GDB.
873 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
874 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
875 as constants, so they're visible to GDB.
876 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
877 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
878 Now enum constants, not macros, so they're visible to GDB.
879 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
880 more convenient now. All uses changed.
881 (VALMASK) [USE_LSB_TAG]: Also define in this case.
882 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
883
3628596a
DA
8842012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
885
886 Explicitly free restriction data that are not needed anymore.
887 * editfns.c (save_restriction_restore): Free restriction data.
888
7abaf5cc
SM
8892012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
890
891 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
892 add argument, tune behavior, and adjust all callers.
893
71f88e00
PE
8942012-07-25 Paul Eggert <eggert@cs.ucla.edu>
895
896 Use typedef for EMACS_INT, EMACS_UINT.
897 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
898 than macros. This simplifies debugging in the usual case, since
899 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
900 and it allows expressions involving EMACS_INT casts.
901 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
902
57ec3034
JD
9032012-07-25 Jan Djärv <jan.h.d@swipnet.se>
904
905 * nsterm.m (ns_read_socket): Return early if there is a modal
906 window (Bug#12043).
907
8137e7b3
MR
9082012-07-25 Martin Rudalics <rudalics@gmx.at>
909
910 * frame.c (Fredirect_frame_focus): In doc-string don't mention
911 that FOCUS-FRAME can be omitted.
912
04e9897c
DA
9132012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
914
915 Adjust buffer text indirection counters at the end of Fkill_buffer.
916 * buffer.c (Fkill_buffer): Adjust indirection counters when the
917 buffer is definitely dead. This should really fix an issue reported
918 by Christoph Scholtes again. (Bug#12007).
919 (init_buffer_once): Initialize indirection counters of
920 buffer_defaults and buffer_local_symbols (for sanity and safety).
921
8a0484e1
EZ
9222012-07-24 Eli Zaretskii <eliz@gnu.org>
923
924 * xdisp.c (init_iterator): Don't compute dimensions of truncation
925 and continuation glyphs on tooltip frames, leave them at zero.
926 Avoids continued lines in tooltips. (Bug#11832)
927
fa691a83
DA
9282012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
929
930 Simplify copy_overlay.
04e9897c 931 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
932 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
933
436bc8e0
EZ
9342012-07-23 Eli Zaretskii <eliz@gnu.org>
935
936 * print.c (print_object): Don't crash when a frame's name is nil
937 or invalid. (Bug#12025)
938
939 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
940 it signals an error when a tooltip frame is being created.
941
d7a7fda3
DA
9422012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
943
944 Cleanup miscellaneous objects allocation and initialization.
945 * alloc.c (allocate_misc): Change to static. Add argument to
946 specify the subtype. Adjust comment and users.
947 (build_overlay): New function.
948 * buffer.c (copy_overlays, Fmake_overlay): Use it.
949 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
950 (allocate_misc): Remove prototype.
951 (build_overlay): Add prototype.
952
9532012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
954
955 Swap buffer text indirection counters in Fbuffer_swap_text.
956 * buffer.c (Fbuffer_swap_text): Swap indirections too.
957 This avoids crash reported by Christoph Scholtes at
958 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
959
9d7fa573
JD
9602012-07-22 Jan Djärv <jan.h.d@swipnet.se>
961
962 * nsmenu.m (Popdown_data): New struct.
963 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
964 free Popdown_data.
965 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
966 (initWithContentRect): Make imgView and contentView non-static
967 and autorelease them. Also autorelease img and matrix (Bug#12005).
968 (dealloc): Remove (Bug#12005).
969
0dd6d66d
DA
9702012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
971
972 Adjust consing_since_gc when objects are explicitly freed.
973 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
974 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
975 (free_cons, free_misc): Subtract object size from consing_since_gc.
976
d36d71df
DA
9772012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
978
979 Simplify and cleanup markers positioning code.
980 * marker.c (attach_marker): More useful eassert.
981 (live_buffer, set_marker_internal): New function.
982 (Fset_marker, set_marker_restricted): Use set_marker_internal.
983 (set_marker_both, set_marker_restricted_both): Use live_buffer.
984
fb9ea40f
PE
9852012-07-22 Paul Eggert <eggert@cs.ucla.edu>
986
987 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
988 as it's limited by the amount of memory, not by INT_MAX.
989
2d5c5f7d
EZ
9902012-07-21 Eli Zaretskii <eliz@gnu.org>
991
07fb592e
EZ
992 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
993 in special-event-map. See the discussion at
994 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
995 for the reasons.
996
37a9eac8 997 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
998 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
999 Fabrice Popineau <fabrice.popineau@supelec.fr>.
1000
c4328746
JD
10012012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1004 (conversationIdentifier): Return value is NSInteger.
784051c4 1005 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1006
6e5d1c12
CY
10072012-07-21 Chong Yidong <cyd@gnu.org>
1008
1009 * window.c (decode_any_window): Signal an error if the window is
1010 on a dead frame (Bug#11984).
1011
9928463d
DA
10122012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1013
1014 Add indirection counting to speed up Fkill_buffer.
1015 * buffer.h (struct buffer): New member.
1016 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1017 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1018 base buffer indirection counter.
1019 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1020 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1021 through buffer list if indirection counter is 0.
1022
f8643a6b
DA
10232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1024
1025 Extend the value returned by Fgarbage_collect with heap statistics.
1026 * alloc.c (Qheap): New symbol.
1027 (syms_of_alloc): DEFSYM it.
1028 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1029 (Fmemory_free): Remove.
1030 (syms_of_alloc): Don't defsubr it.
1031 * buffer.c (Fcompact_buffer): Remove.
1032 (syms_of_buffer): Don't defsubr it.
1033
dac616ff
DA
10342012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1035
1036 Make maybe_gc inline.
1037 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1038 * lisp.h (consing_since_gc, gc_relative_threshold)
1039 (memory_full_cons_threshold): Revert declaration.
1040 (maybe_gc): Remove prototype, define as inline.
1041 * alloc.c: Remove old commented-out code.
1042 (consing_since_gc, gc_relative_threshold)
1043 (memory_full_cons_threshold): Revert to global.
1044 (maybe_gc): Remove.
1045
d7ea76b4
DA
10462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1049 * lisp.h (build_unibyte_string): New function.
1050 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1051 * sysdep.c, w32fns.c, xfns.c: Use it.
1052 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1053 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1054 Adjust users accordingly.
1055 * font.h (font_open_by_name): Adjust prototype.
1056
765e61e3
DA
10572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1058
1059 Cleanup calls to Fgarbage_collect.
1060 * lisp.h (maybe_gc): New prototype.
1061 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1062 Remove declarations.
1063 * alloc.c (maybe_gc): New function.
1064 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1065 Make them static.
1066 * bytecode.c (MAYBE_GC): Use maybe_gc.
1067 * eval.c (eval_sub, Ffuncall): Likewise.
1068 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1069 to avoid dependency from auto-save feature.
1070
52b852c7
PE
10712012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1074 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1075 'for_each_per_buffer_object_at'.
1076 All uses changed. It's better to use upper-case for macros that
1077 cannot be implemented as functions, to give the reader a clue
1078 that they're special.
1079
5db81e33
SM
10802012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1081
1082 * alloc.c (Fgarbage_collect): Tweak docstring.
1083
5b835e1d
DA
10842012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1085
1086 Tweak the value returned from Fgarbage_collect again.
1087 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1088 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1089 Adjust documentation.
1090 (total_vector_bytes): Rename to total_vector_slots, adjust
1091 accounting.
1092 (total_free_vector_bytes): Rename to total_free_vector_slots,
1093 adjust accounting.
1094 (Qstring_bytes, Qvector_slots): New symbols.
1095 (syms_of_alloc): DEFSYM them.
1096
9cd47b72
DA
10972012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Buffer compaction primitive which may be used from Lisp.
1100 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1101 (syms_of_buffer): Register Fcompact_buffer.
1102 * alloc.c (Fgarbage_collect): Use compact_buffer.
1103 * buffer.h (compact_buffer): New prototype.
1104 (struct buffer_text): New member.
1105
d17337e5
DA
11062012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 New macro to iterate over all buffers, miscellaneous cleanups.
1109 * lisp.h (all_buffers): Remove declaration.
1110 * buffer.h (all_buffers): Add declaration, with comment.
1111 (for_each_buffer): New macro.
1112 * alloc.c (Fgarbage_collect, mark_object): Use it.
1113 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1114 (init_buffer): Likewise.
1115 * data.c (Fset_default): Likewise.
1116 * coding.c (code_conversion_restore): Remove redundant check
1117 for dead buffer.
1118 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1119
60cfd278
AS
11202012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1121
1122 Fix bug that created negative-length intervals.
1123 * intervals.c (merge_interval_right, merge_interval_left):
1124 Do not zero out this interval if it is absorbed by its children,
1125 as this interval's total length doesn't change in that case. See
1126 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1127
d06714cb
PE
11282012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1129
83713154
PE
1130 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1131 when invoking (make-bool-vector N t) and N is a positive
1132 multiple of 8 -- the last 8 bits were mistakenly cleared.
1133
d06714cb
PE
1134 Remove some struct layout assumptions in bool vectors.
1135 * alloc.c (bool_header_size): New constant.
1136 (header_size, word_size): Move earlier, as they're now used earlier.
1137 Use 'word_size' in a few more places, where it's appropriate.
1138 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1139 padding before the data member of a bool vector.
1140 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1141 than doing the check by hand with an abort ().
1142
464d5a5e
SM
11432012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1144
5fbc0409
SM
1145 * eval.c (Fdefvar): Don't check constants since we only set the var if
1146 it's not yet defined anyway (bug#11904).
1147
464d5a5e
SM
1148 * lisp.h (last_undo_boundary): Declare new var.
1149 * keyboard.c (command_loop_1): Set it.
1150 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1151 were auto-added by the command loop (bug#11774).
1152
8dc2e44a
AS
11532012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1154
1155 * w32font.c (Qsymbol): Remove local definition.
1156 (syms_of_w32font): Don't DEFSYM it.
1157
169925ec
DA
11582012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1159
1160 Fix sweep_vectors to handle large bool vectors correctly.
1161 * alloc.c (sweep_vectors): Account total_vector_bytes for
1162 bool vectors larger than VBLOCK_BYTES_MAX.
1163
5fbfb018
CY
11642012-07-18 Chong Yidong <cyd@gnu.org>
1165
1166 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1167 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1168
3ab6e069
DA
11692012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 Return more descriptive data from Fgarbage_collect.
1172 Suggested by Stefan Monnier in
1173 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1174 * alloc.c (bounded_number): New function.
1175 (total_buffers, total_vectors): New variable.
1176 (total_string_size): Rename to total_string_bytes, adjust users.
1177 (total_vector_size): Rename to total_vector_bytes, adjust users.
1178 (sweep_vectors): Account total_vectors and total_vector_bytes.
1179 (Fgarbage_collect): New return value. Adjust documentation.
1180 (gc_sweep): Account total_buffers.
1181 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1182 (VECTOR_SIZE): Remove.
1183 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1184 (Qinterval, Qmisc): New symbols.
1185 (syms_of_data): Initialize them.
1186 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1187 (Qcons, Qbuffer): New declarations.
1188
6d02fe5b
PE
11892012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1192 Round up, not down. Improve doc.
1193
b7ffe040
DA
11942012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 Restore old code in allocate_string_data to avoid Faset breakage.
1197 Reported by Julien Danjou <julien@danjou.info> in
1198 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1199 * alloc.c (allocate_string_data): Restore old code with minor
1200 adjustments, fix comment to explain this subtle issue.
1201
4dc7c8d5
SM
12022012-07-17 Eli Zaretskii <eliz@gnu.org>
1203
1204 Remove FILE_SYSTEM_CASE.
1205 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1206
1207 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1208 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1209 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1210 call-process-region passes it through expand-file-name.
1211
1212 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1213
12142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1215
1216 Fix crash when creating indirect buffer (Bug#11917)
1217 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1218 Don't handle unbound variables specially if non-zero.
1219 (Fbuffer_local_variables): Pass zero.
1220 (clone_per_buffer_values): Pass non-zero.
1221
12222012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1223
1224 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1225 to make the loop interruptible.
1226
12272012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1228
1229 * gnutls.c (emacs_gnutls_handshake): Only retry if
1230 GNUTLS_E_INTERRUPTED.
1231
cce7fefc
DA
12322012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1233
1234 Cleanup and convert miscellaneous checks to eassert.
1235 * alloc.c (mark_interval): Fix comment, partially rephrase
1236 old comment from intervals.h (see below).
1237 * intervals.c (find_interval, adjust_intervals_for_insertion)
1238 (delete_interval, adjust_intervals_for_deletion)
1239 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1240 Convert to eassert.
1241 (adjust_intervals_for_insertion, make_new_interval):
1242 Remove obsolete and unused code.
1243 * intervals.h (struct interval): Remove obsolete comment.
1244 * textprotp.c (erase_properties): Remove unused code.
1245 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1246 (Fremove_list_of_text_properties): Convert to eassert.
1247
9ea10cc3
CY
12482012-07-17 Chong Yidong <cyd@gnu.org>
1249
1250 * editfns.c (Finsert_char): Doc fix.
1251
3900d5de
DA
12522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1253
1254 Fix previous change to make Fmemory_free always accurate.
1255 * alloc.c (make_interval): Update total_free_intervals.
1256 (make_float): Likewise for total_free_floats.
1257 (free_cons, Fcons): Likewise for total_free_conses.
1258 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1259 Likewise for total_free_vector_bytes.
1260 (Fmake_symbol): Likewise for total_free_symbols.
1261 (bytes_free): Remove.
1262
7098646f
DA
12632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1264
1265 Simple free memory accounting feature.
1266 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1267 (sweep_vectors): Accumulate size of free vectors.
1268 (Fgarbage_collect): Setup bytes_free.
1269 (Fmemory_free): New function.
1270 (syms_of_alloc): Register it.
1271
22657b40
DA
12722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1273
1274 Cleanup overlays checking.
1275 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1276 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1277 eassert and OVERLAYP.
1278 (sort_overlays): Change to use OVERLAYP.
1279
ddfc8813
RK
12802012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1281
1282 * editfns.c (Finsert_char): Make it interactive, and make the
1283 second arg optional. Copy interactive spec and docstring from
1284 ucs-insert.
1285
7c26cf3c
PE
12862012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1289 Unlike the other wrapped functions, fabs has an unspecified
1290 effect on errno.
1291
5d127af9
JD
12922012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1293
1294 * nsterm.m (keyDown): Interpret flags without left/right bits
1295 as the left key (Bug#11670).
1296
6a0dd1d7
DA
12972012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 Remove empty and useless init functions.
1300 * lisp.h (init_character_once, init_fns, init_image)
1301 (init_filelock, init_sound): Remove prototype.
1302 * character.c (init_character_once): Remove.
1303 * filelock.c (init_filelock): Likewise.
1304 * fns.c (init_fns): Likewise.
1305 * image.c (init_image): Likewise.
1306 * sound.c (init_sound): Likewise.
1307 * emacs.c (main): Adjust accordingly.
1308
7a6136fd
DA
13092012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1310
1311 * gtkutil.h: Tiny cleanups.
1312 (use_old_gtk_file_dialog): Remove useless declaration.
1313 (xg_uses_old_file_dialog): Add suggested const attribute.
1314
ce811ad9
EZ
13152012-07-15 Eli Zaretskii <eliz@gnu.org>
1316
1317 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1318 (bidi_paragraph_init): Use it to limit search forward for a strong
1319 directional character in abnormally large paragraphs full of
1320 neutral or weak characters. (Bug#11943)
1321
c9adfeaa
SF
13222012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1323
1324 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1325 the toolbar (Bug#9451).
1326 (xg_make_tool_item): Give the widget event box a transparent
1327 background.
1328
fff62aa9
DA
13292012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1330
1331 Cleanup basic allocation variables and functions.
1332 * alloc.c (ignore_warnings, init_intervals, init_float)
1333 (init_cons, init_symbol, init_marker): Remove.
1334 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1335 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1336 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1337 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1338 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1339 (staticidx, init_alloc_once, init_strings, free_ablock):
1340 Remove redundant initialization.
1341 * fns.c (init_weak_hash_tables): Remove.
1342 * lisp.h (init_weak_hash_tables): Remove prototype.
1343
9730daca
DA
13442012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1345
1346 Use zero_vector where appropriate.
1347 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1348 accordingly.
1349 * lisp.h (zero_vector): New declaration.
1350 * font.c (null_vector): Remove.
1351 (syms_of_font): Remove initialization and staticpro.
1352 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1353 * keymap.c (Faccessible_keymaps): Likewise.
1354
2e2d2a13
LL
13552012-07-15 Leo Liu <sdl.web@gmail.com>
1356
1357 * fringe.c: Fix typo in comments.
1358
cd276f6e
LL
13592012-07-14 Leo Liu <sdl.web@gmail.com>
1360
1361 * fringe.c: Add a new bitmap exclamation-mark.
1362
5a1131d9
EZ
13632012-07-14 Eli Zaretskii <eliz@gnu.org>
1364
1365 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1366
1367 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1368 (HAVE_MENUS): Don't define, defined by editing config.in with
1369 msdos/sed2v2.inp.
1370 (GMALLOC_INHIBIT_VALLOC): Don't define.
1371 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1372
22e983b7
JB
13732012-07-14 Juanma Barranquero <lekktu@gmail.com>
1374
1375 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1376
5b3f250f
GM
13772012-07-14 Glenn Morris <rgm@gnu.org>
1378
1379 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1380 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1381 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1382
33d63ff4
GM
13832012-07-13 Glenn Morris <rgm@gnu.org>
1384
5b633342
GM
1385 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1386
33d63ff4
GM
1387 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1388 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1389
b55b9f85
JD
13902012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1391
0dc8cf50
JD
1392 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1393 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1394 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1395 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1396 where appropriate.
1397 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1398 as boolean expression.
1399 (x_set_window_size): Remove unused variable toolbar.
1400 (ns_get_color_default, ns_mod_to_lisp): Remove.
1401 (ns_mouse_position): Remove unused variables xchar and ychar.
1402 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1403 (ns_set_vertical_scroll_bar): Remove unused variable count.
1404 (ns_delete_terminal): Remove unused variable i.
1405 (ns_term_init): Remove unused variables r, g and b.
1406 (mouseDown): Remove unused variable window.
1407 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1408 (initFrameFromEmacs): Remove unused variable vbextra.
1409 (mouseEntered): Remove unused variables p and dpyinfo.
1410 (mouseExited): Remove unused variables p and r.
1411 (ns_define_frame_cursor, ns_clear_frame_area)
1412 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1413 (menuDown): Assign [sender tag] to variable and cast the variable.
1414
1415 * nsterm.h (menuDown): Add id as type to argument sender.
1416 (ns_display_info_for_name): Add Lisp_Object argument.
1417 (ns_term_init): Add Lisp_Object argument.
1418 (ns_map_event_to_object): Add void argument.
1419 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1420 prototype with arguments and only declare if __OBJC__.
1421 (nxatoms_of_nsselect): Add void argument.
1422 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1423 (ns_alloc_autorelease_pool): Add void argument.
1424 (ns_release_autorelease_pool): Add void* argument.
1425 (ns_get_defaults_value): Add const char* argument.
1426
1427 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1428 (initFromContents): Use SSDATA where appropriate.
1429 (ns_update_menubar): Add braces to ambigous if-else.
1430 (initWithTitle): Put () around assignment in if statement.
1431 (ns_menu_show): Remove unused variables window and keymap.
1432 (update_frame_tool_bar): Remove unused variable selected_p.
1433 (initWithContentRect): Remove unused variable this_cmd_name.
1434
1435 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1436 appropriate.
1437 (setXBMColor): Remove unused variable len.
1438 (setPixmapData): Put () around assignment in loop statement.
1439
1440 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1441 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1442 where appropriate.
1443 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1444 around assignment in loop statement.
1445 (nsfont_open): Remove unused variable i.
1446 (nsfont_open): Remove unused variable len.
1447 (nsfont_draw): Remove unused variable cs.
1448
1449 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1450 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1451 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1452 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1453 (Fns_font_name, Fns_perform_service)
1454 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1455 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1456 (ns_set_name): Remove unused variable view.
1457 (x_set_menu_bar_lines): Remove unused variable olines.
1458 (x_set_tool_bar_lines): Remove unused variable root_window.
1459 (Fns_list_colors): Put () around assignment in while statement.
1460 (Fns_perform_service): Remove unused variable len.
1461 (Fns_display_usable_bounds): Remove unused variable top.
1462 (syms_of_nsfns): Remove unused variable i.
1463
b55b9f85
JD
1464 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1465 memcpy (Bug#11907).
1466
ed9265fc 14672012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1468
1469 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1470 and free it with DestroyExceptionInfo (Bug#11558).
1471
ef099b57
JB
14722012-07-13 Juanma Barranquero <lekktu@gmail.com>
1473
1474 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1475 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1476 Set here, not in nt/config.nt.
1477
ea814a5d
EZ
14782012-07-13 Eli Zaretskii <eliz@gnu.org>
1479
1480 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1481 cursor overflow into the last glyph on display line when the right
1482 fringe is off. (Bug#11832)
1483
1a952767
PE
14842012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1485
1486 * xdisp.c (produce_special_glyphs): Now static.
1487 * dispextern.h (produce_special_glyphs): Remove decl.
1488
983188fd
GM
14892012-07-13 Glenn Morris <rgm@gnu.org>
1490
8d7c7eed 1491 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1492 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1493
983188fd
GM
1494 * s/usg5-4-common.h (USG, USG5):
1495 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1496 * s/sol2-6.h (SOLARIS2):
1497 * s/irix6-5.h (IRIX6_5):
1498 * s/hpux10-20.h (USG, USG5, HPUX):
1499 * s/gnu-linux.h (USG, GNU_LINUX):
1500 * s/freebsd.h (BSD_SYSTEM):
1501 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1502 * s/cygwin.h (CYGWIN):
1503 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1504 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1505
d1e68667 15062012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1507
1508 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1509
6de0e799
GM
15102012-07-13 Glenn Morris <rgm@gnu.org>
1511
739ae010
GM
1512 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1513
dbee5793
GM
1514 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1515
6de0e799
GM
1516 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1517 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1518
b82da769
GM
15192012-07-12 Glenn Morris <rgm@gnu.org>
1520
4fae5a7a 1521 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1522
1523 * process.c (init_process_emacs): Rename from init_process.
1524 The old name is also the name of a Mach system call.
1525 * lisp.h, emacs.c: Update for this name change.
1526 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1527 longer needed.
1528
5a979817
EZ
15292012-07-12 Eli Zaretskii <eliz@gnu.org>
1530
1531 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1532 memmove call that removes glyphs covered by the left truncation
1533 glyph. Improve commentary.
1534 (display_line): Fix display of continuation glyphs on GUI frames
1535 when the right fringe is turned off and variable-size fonts are
1536 used in the window. Move the code that appends a stretch glyph to
1537 produce_special_glyphs, so that it could be used for truncation
1538 and continuation glyphs alike.
1539 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1540 glyph of a suitably computed width, to align the special glyphs at
1541 the window margin. Code moved from display_line. (Bug#11832)
1542
3e91a053
GM
15432012-07-12 Glenn Morris <rgm@gnu.org>
1544
ba9e4b84
GM
1545 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1546
1547 * s/gnu-linux.h, s/hpux10-20.h:
1548 Do not unconditionally define HAVE_XRMSETDATABASE.
1549
3e91a053
GM
1550 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1551
b300b1f4
PE
15522012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Fix typos that broke OS X build.
1555 Reported by Randal L. Schwartz in
1556 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1557 * nsterm.m (ns_timeout): Add missing local decl.
1558 (ns_get_color): snprintf -> sprintf, to fix typo.
1559
6e777848
GM
15602012-07-12 Glenn Morris <rgm@gnu.org>
1561
3f922c37
GM
1562 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1563 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1564 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1565 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1566
0ab7b23a
GM
1567 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1568 Move PTY_OPEN to configure.
1569
6e777848
GM
1570 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1571 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1572 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1573
4a7edc24
DA
15742012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1575
1576 Use empty_unibyte_string where applicable.
1577 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1578 * lread.c (read1): Likewise.
1579 * xsettings.c (syms_of_xsettings): Likewise.
1580
308aab79
GM
15812012-07-12 Glenn Morris <rgm@gnu.org>
1582
42bd1719
GM
1583 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1584 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1585 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1586 * s/hpux10-20.h (RUN_TIME_REMAP):
1587 * s/bsd-common.h (TABDLY): Move to configure.
1588
1589 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1590
1591 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1592
ea0bbd17 1593 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1594 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1595
1596 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1597
308aab79
GM
1598 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1599 * s/template.h: Move NARROWPROTO to configure.
1600
ee1cf5cf
GM
16012012-07-11 Glenn Morris <rgm@gnu.org>
1602
30fe9bf4
GM
1603 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1604 unused since 2011-01-17 change to systty.h.
1605
ee1cf5cf
GM
1606 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1607 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1608 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1609
63e47e07
PE
16102012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1611
1612 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1613
c43fb4c3
GM
16142012-07-11 Glenn Morris <rgm@gnu.org>
1615
1616 * s/darwin.h, s/gnu-linux.h, s/template.h:
1617 Move INTERRUPT_INPUT to configure.
1618
e8df9267
DA
16192012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1620
1621 Minor adjustments to interning code.
1622 * lisp.h (intern, intern_c_string): Redefine as static inline
1623 wrappers for intern_1 and intern_c_string_1, respectively.
1624 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1625 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1626 Vobarray checking.
e8df9267
DA
1627 * font.c (font_intern_prop): Likewise. Adjust comment.
1628 * w32font.c (intern_font_name): Likewise.
1629
34348bd4
AS
16302012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1631
d96a1e0c
AS
1632 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1633
34348bd4
AS
1634 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1635 of Fcar/Fcdr if possible.
1636 * font.c (check_otf_features): Likewise.
1637 * fontset.c (Fnew_fontset): Likewise.
1638 * gnutls.c (Fgnutls_boot): Likewise.
1639 * minibuf.c (read_minibuf): Likewise.
1640 * msdos.c (IT_set_frame_parameters): Likewise.
1641 * xmenu.c (Fx_popup_dialog): Likewise.
1642 * w32menu.c (Fx_popup_dialog): Likewise.
1643
c8add24e
GM
16442012-07-11 Glenn Morris <rgm@gnu.org>
1645
4b575b3c
GM
1646 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1647 since nothing has defined it on these platforms.
1648
09f4e3b0
GM
1649 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1650 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1651
172bedef
GM
1652 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1653 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1654 Move CLASH_DETECTION to configure.
1655
249685df
GM
1656 * s/gnu.h: Remove file, which is now empty.
1657
c8add24e
GM
1658 * s/gnu.h, s/gnu-linux.h:
1659 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1660
b41253a3
JW
16612012-07-11 John Wiegley <johnw@newartisans.com>
1662
1663 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1664 function attribute, so we only use it if it exists in the
1665 compiler.
1666
d923b542
DA
16672012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1668
1669 Avoid call to strlen in fast_c_string_match_ignore_case.
1670 * search.c (fast_c_string_match_ignore_case): Change to use
1671 length argument. Adjust users accordingly.
1672 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1673
5ebbef1d
PE
16742012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1675
bb352260
PE
1676 Assume mkdir, rmdir.
1677 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1678 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1679
57054ddd
PE
1680 Assume rename.
1681 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1682
b747d3f7
PE
1683 Assume perror.
1684 * s/hpux10-20.h (HAVE_PERROR): Remove.
1685 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1686 Remove dummy definition, as this problem was obsolete long ago.
1687
5ebbef1d
PE
1688 Assume strerror.
1689 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1690
984e7f30
DA
16912012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1692
1693 Avoid calls to strlen in font processing functions.
1694 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1695 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1696 users accordingly.
d923b542
DA
1697 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1698 Adjust prototypes.
1699 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1700 Change to return ptrdiff_t.
984e7f30
DA
1701 (xfont_list_pattern, xfont_match): Use length returned by
1702 xfont_decode_coding_xlfd.
1703 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1704
20e94fdd
GM
17052012-07-11 Glenn Morris <rgm@gnu.org>
1706
9d596af3
GM
1707 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1708 Move DONT_REOPEN_PTY to configure.
1709
20e94fdd
GM
1710 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1711 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1712
e99a530f
PE
17132012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1714
22ffb973
PE
1715 Remove "#define unix" that is no longer needed (Bug#11905).
1716 * s/aix4-2.h (unix): Remove; no longer needed.
1717
e9a9ae03
PE
1718 EMACS_TIME simplification (Bug#11875).
1719 This replaces macros (which typically do not work in GDB)
1720 with functions, typedefs and enums, making the code easier to debug.
1721 The functional style also makes code easier to read and maintain.
1722 * systime.h: Include <sys/time.h> on all hosts, not just if
1723 WINDOWSNT, since 'struct timeval' is needed in general.
1724 (EMACS_TIME): Now a typedef, not a macro.
1725 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1726 not macros.
1727 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1728 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1729 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1730 (EMACS_TIME_LE): Now functions, not macros.
1731 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1732 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1733 which are not functions. All uses rewritten to use:
1734 (make_emacs_time): New function.
1735 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1736 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1737 not functions. All uses rewritten to use the following, respectively:
1738 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1739 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1740 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1741 * fileio.c (Fcopy_file):
1742 * xterm.c (XTflash): Get the current time closer to when it's used.
1743 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1744
ffacb126
PE
1745 * bytecode.c (targets): Suppress -Woverride-init warnings.
1746
e99a530f
PE
1747 Simplify by avoiding confusing use of strncpy etc.
1748 * doc.c (Fsnarf_documentation):
1749 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1750 * frame.c (Fmake_terminal_frame):
1751 * gtkutil.c (get_utf8_string):
1752 * lread.c (openp):
1753 * nsmenu.m (ns_update_menubar):
1754 * regex.c (regerror):
1755 Prefer memcpy to strncpy and strncat when either will do.
1756 * fileio.c (Fsubstitute_in_file_name):
1757 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1758 (menu_separator_name_p):
1759 * nsmenu.m (ns_update_menubar):
1760 Prefer memcmp to strncmp when either will do.
1761 * nsterm.m: Include <ftoastr.h>.
1762 (ns_get_color):
1763 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1764 Prefer snprintf to strncpy.
1765 * nsterm.m (ns_term_init):
1766 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1767 * nsterm.m (ns_term_init):
1768 Avoid the need for strncpy, by using build_string or
1769 make_unibyte_string directly. Use dtoastr, not snprintf.
1770 * process.c (Fmake_network_process): Diagnose service names that
1771 are too long, rather than silently truncating them or creating
1772 non-null-terminated names.
1773 (Fnetwork_interface_info): Likewise, for interface names.
1774 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1775 Prefer sprintf to strncat.
1776 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1777 Prefer vsnprintf to vsprintf + strncpy.
1778
c59592b3
GM
17792012-07-10 Glenn Morris <rgm@gnu.org>
1780
1781 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1782 Clarify fallback case.
1783
7d7bbefd
DA
17842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1785
1786 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1787 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1788 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1789 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1790 where argument type is known to be a Lisp_Cons.
1791
3a4c8000
TT
17922012-07-10 Tom Tromey <tromey@redhat.com>
1793
1794 * bytecode.c (BYTE_CODE_THREADED): New macro.
1795 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1796 (enum byte_code_op): New type.
1797 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1798 (exec_byte_code): Use them. Use token threading when applicable.
1799
2a0213a6
DA
18002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 Optimize pure C strings initialization.
1803 * lisp.h (make_pure_string): Fix prototype.
1804 (build_pure_c_string): New function, defined as static inline. This
1805 provides a better opportunity to optimize away calls to strlen when
1806 the function is called with compile-time constant argument.
1807 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1808 argument, adjust users accordingly. Use build_pure_c_string where
1809 appropriate.
1810 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1811 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1812 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1813
cb1caeaf
DA
18142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1815
1816 Avoid calls to strlen in miscellaneous functions.
1817 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1818 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1819 * lread.c (openp): Likewise.
1820
c293e30c
DA
18212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1822
1823 Avoid calls to strlen in path processing functions.
1824 * fileio.c (file_name_as_directory): Add comment. Change to add
1825 srclen argument and return the length of result. Adjust users
1826 accordingly.
1827 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1828 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1829 users accordingly.
1830 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1831
9e059e3f
GM
18322012-07-10 Glenn Morris <rgm@gnu.org>
1833
d02eb359
GM
1834 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1835 Move PENDING_OUTPUT_COUNT definition to configure.
1836
882cf227
GM
1837 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1838 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1839 * s/gnu.h (DATA_START): Move definitions to configure.
1840
af6e839f
GM
1841 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1842 We include usg5-4-common.h, which defines them both.
1843
40289a12
GM
1844 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1845 O_RDONLY already includes it).
1846
9e059e3f
GM
1847 Stop ns builds setting the EMACSLOADPATH environment variable.
1848 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1849 Now it does not set EMACSLOADPATH, just returns the load-path string.
1850 * nsterm.h: Update accordingly.
1851 * lread.c [HAVE_NS]: Include nsterm.h.
1852 (init_lread) [HAVE_NS]: Use ns_load_path.
1853 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1854
7c4e8ec0
GM
18552012-07-09 Glenn Morris <rgm@gnu.org>
1856
d4f600ff
GM
1857 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1858 since the included bsd-common.h does so.
1859
cbb31951
GM
1860 Stop ns builds setting the EMACSPATH environment variable.
1861 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1862 (ns_init_paths): Do not set EMACSPATH.
1863 * nsterm.h (ns_exec_path): Add it.
1864 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1865 Use ns_exec_path.
1866
7c4e8ec0
GM
1867 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1868
26bccfae
PE
18692012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1870
a0bee46f
PE
1871 * process.c (wait_reading_process_output): 'waitchannels' was unset
1872 when read_kbd || !NILP (wait_for_cell); fix this.
1873
5994c183
PE
1874 Add GCC-style 'const' attribute to functions that can use it.
1875 * character.h (char_resolve_modifier_mask):
1876 * keyboard.h (make_ctrl_char):
1877 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1878 (init_character_once, next_almost_prime, init_fns, init_image)
1879 (flush_pending_output, init_sound):
1880 * mem-limits.h (start_of_data):
1881 * menu.h (finish_menu_items):
1882 Add ATTRIBUTE_CONST.
1883 * emacs.c (DEFINE_DUMMY_FUNCTION):
1884 Declare the dummy function with ATTRIBUTE_CONST.
1885 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1886 Add decls with ATTRIBUTE_CONST.
1887
26bccfae
PE
1888 Minor improvements to make_formatted_string.
1889 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1890 where int is good enough, as vsprintf returns an int.
1891 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1892
a8290ec3
DA
18932012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1894
1895 Use make_formatted_string to avoid double length calculation.
1896 * lisp.h (make_formatted_string): New prototype.
1897 * alloc.c (make_formatted_string): New function.
1898 * buffer.c (Fgenerate_new_buffer_name): Use it.
1899 * dbus.c (syms_of_dbusbind): Likewise.
1900 * editfns.c (Fcurrent_time_zone): Likewise.
1901 * filelock.c (get_boot_time): Likewise.
1902 * frame.c (make_terminal_frame, set_term_frame_name)
1903 (x_report_frame_params): Likewise.
1904 * image.c (gs_load): Likewise.
1905 * minibuf.c (get_minibuffer): Likewise.
1906 * msdos.c (dos_set_window_size): Likewise.
1907 * process.c (make_process): Likewise.
1908 * xdisp.c (ensure_echo_area_buffers): Likewise.
1909 * xsettings.c (apply_xft_settings): Likewise.
1910
d01ba2f1
GM
19112012-07-09 Glenn Morris <rgm@gnu.org>
1912
1913 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1914 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1915 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1916 * nsterm.h (ns_etc_directory): Add it.
1917 * callproc.c [HAVE_NS]: Include nsterm.h.
1918 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1919
f1f924b6
DA
19202012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1921
1922 Move marker debugging code under MARKER_DEBUG.
1923 * marker.c (MARKER_DEBUG): Move marker debugging code under
1924 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1925 for bootstrap with --enable-checking (~3x slowdown reported
1926 by Juanma Barranquero <lekktu@gmail.com>).
1927 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1928
ab531b66
PE
19292012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1932 See <http://bugs.gnu.org/11825#29>.
1933
c4b3bc8a
EZ
19342012-07-08 Eli Zaretskii <eliz@gnu.org>
1935
1936 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1937 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1938 (display_line): Add commentary about displaying truncation glyphs
1939 on GUI frames.
1940 (produce_special_glyphs): Move here from term.c.
1941
1942 * term.c (produce_special_glyphs): Move to xdisp.c.
1943
1944 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1945 section.
c4b3bc8a 1946
b676b881
AS
19472012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1948
f17c5273
AS
1949 * xdisp.c (display_line): Avoid warning about implicit declaration
1950 of FRAME_FONT.
1951
298819b9
AS
1952 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1953
b676b881
AS
1954 * lisp.h: Remove empty conditional.
1955
6045c4fd
PE
19562012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1957
b3350bf9
PE
1958 * lread.c (load_path_check): Now static.
1959
6045c4fd
PE
1960 Fix some minor --with-ns problems found by static checking.
1961 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1962 (x_set_font) [!HAVE_X_WINDOWS]:
1963 * image.c (xpm_load_image) [HAVE_NS]:
1964 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1965 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1966 Remove unused local.
1967 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1968 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1969 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1970 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1971 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1972 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1973 Fix pointer signedness problem.
1974 * xfaces.c (FRAME_X_FONT_TABLE):
1975 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1976
929e7845
GM
19772012-07-07 Glenn Morris <rgm@gnu.org>
1978
1979 * lread.c (load_path_check): New function, split from init_lread.
1980 (init_lread): Reorganize. Motivation:
1981 If EMACSLOADPATH is set, check/warn about that rather than the
1982 defaults, which we are not going to use. Hence we can remove
1983 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1984 Don't warn if site-lisp directories are missing.
1985 If not installed, start from a blank load-path, since
1986 PATH_LOADSEARCH refers to the eventual installation directories.
1987
58dd0aa4
EZ
19882012-07-07 Eli Zaretskii <eliz@gnu.org>
1989
1990 Support truncation and continuation glyphs on GUI frames, when
1991 fringes are disabled. (Bug#11832)
1992 * xdisp.c (init_iterator): Get dimensions of truncation and
1993 continuation glyphs even if on GUI frames. Adjust
1994 it->last_visible_x on GUI frames when the left or right fringes,
1995 or both, are absent.
1996 (start_display, move_it_in_display_line_to): Handle the case of a
1997 GUI frame without a fringe to display continuation or truncation
1998 glyphs.
1999 (insert_left_trunc_glyphs): Support GUI frames: make sure
2000 truncation glyphs overwrite enough glyphs from the current line to
2001 have sufficient space in pixels.
2002 (display_line): Support truncation and continuation glyphs on GUI
2003 frames. If some spare pixels are left on the line after inserting
2004 the truncation glyphs, fill that space with a stretch glyph of a
2005 suitably computed width.
2006
2007 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2008 produce_glyphs, to support GUI sessions.
2009
31571fd7
PE
20102012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2011
5a16b9bc
PE
2012 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2013
f3047c75
PE
2014 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2015
31571fd7
PE
2016 Do not require float-time's arg to fit in time_t (Bug#11825).
2017 This works better on hosts where time_t is unsigned, and where
2018 float-time is applied to the (negative) difference between two times.
2019 * editfns.c (decode_time_components): Last arg is now double *,
2020 not int *, and means to store all the result as a double, without
2021 worrying about whether the seconds part fits in time_t.
2022 All callers changed.
2023 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2024 All callers changed.
2025 (Ffloat_time): Do not fail merely because the specified time falls
2026 outside of time_t range.
2027
4516fbef
GM
20282012-07-07 Glenn Morris <rgm@gnu.org>
2029
2030 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2031 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2032 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2033
07adc2c6
JB
20342012-07-07 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2037 Update dependencies.
2038
2039 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2040
fd573f31
PE
20412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2042
fee5959d
PE
2043 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2044 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2045 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2046 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2047 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2048 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2049
fd573f31
PE
2050 * xfont.c (compare_font_names): Redo to omit the need for casts.
2051
ddadbc0e
AS
20522012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2053
fca8d6b6
AS
2054 * xfns.c (Fx_change_window_property): Doc fix.
2055 * w32fns.c (Fx_change_window_property): Doc fix.
2056
ddadbc0e
AS
2057 * w32fns.c (Fx_window_property): Accept the same arguments as the
2058 X Windows version. Doc fix.
2059 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2060
ed9265fc 20612012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2062 Eli Zaretskii <eliz@gnu.org>
2063
2064 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2065 Windows-specific code from nt/config.nt moved here.
2066 Obsolete settings removed.
2067
216ee680
PE
20682012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2069
2070 * process.c: Avoid unnecessary calls to gettime.
2071 (wait_reading_process_output): Don't get the time of day
2072 when gobbling data immediately and not waiting, as there's no need
2073 for it in that case. This removes a FIXME.
2074
bdd091e4
JD
20752012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2076
2077 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2078 is defined (Bug#11768).
2079
9d44f8ce
DA
20802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2081
2082 Fix marker debugging code.
2083 * marker.c (byte_char_debug_check): Do not perform the check
2084 if buffer is not multibyte.
090bd7cb
JB
2085 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2086 Call byte_char_debug_check with correct arguments.
9d44f8ce 2087
90fc4786
DA
20882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2089
2090 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2091 * marker.c (byte_char_debug_check, count_markers):
2092 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2093 (byte_debug_flag): Remove.
2094 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2095 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2096
7b7ae965
DA
20972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2098
4e57b342
DA
2099 Avoid code repetition in marker-related functions.
2100 * marker.c (attach_marker): New function.
2101 (Fset_marker, set_marker_restricted, set_marker_both)
2102 (set_marker_restricted_both): Use it.
2103 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2104 Consistently rename charno to charpos.
2105 (marker_position): Add eassert.
2106 (marker_byte_position): Convert to eassert.
2107
21082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2111 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2112 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2113
657924ff
DA
21142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2115
2116 Introduce fast path for the widely used marker operation.
2117 * alloc.c (build_marker): New function.
2118 * lisp.h (build_marker): New prototype.
2119 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2120 * composite.c (autocmp_chars): Likewise.
2121 * editfns.c (buildmark): Remove.
2122 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2123 (save_restriction_save): Use build_marker.
2124 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2125 * window.c (save_window_save): Likewise.
2126
041a49a6
DA
21272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2128
2129 Do not use Fdelete_overlay in delete_all_overlays
2130 to avoid redundant calls to unchain_overlay.
2131 * buffer.c (drop_overlay): New function.
2132 (delete_all_overlays, Fdelete_overlay): Use it.
2133 * minibuf.c (get_minibuffer): Fix comment.
2134
7dca65a4
PE
21352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 Port to OpenBSD 5.1 amd64.
2138 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2139 This is needed for OpenBSD, and should be harmless on all BSD systems.
2140 Also, include <sys/sysctl.h>, as it should be available on all
2141 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2142 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2143 use p_pid member, not kp_proc.pid.
2144
8eb876e2
GM
21452012-07-06 Glenn Morris <rgm@gnu.org>
2146
2147 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2148
38182d90
PE
21492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2150
2151 More xmalloc and related cleanup.
2152 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2153 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2154 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2155 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2156 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2157 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2158 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2159 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2160 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2161 * xterm.c:
2162 Omit needless casts involving void * pointers and allocation.
2163 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2164 as the former is more robust if P's type is changed.
2165 Prefer xzalloc to xmalloc + memset 0.
2166 Simplify malloc-or-realloc to realloc.
2167 Don't worry about xmalloc returning a null pointer.
2168 Prefer xstrdup to xmalloc + strcpy.
2169 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2170 growing it.
2171 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2172 alloca of a constant.
2173
6dd5a677
EZ
21742012-07-05 Eli Zaretskii <eliz@gnu.org>
2175
2176 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2177 hscroll is larger than the line width. Fixes long and futile
2178 looping inside extend_face_to_end_of_line (on a TTY) producing
2179 glyphs that are not needed and thrown away.
2180
6b312f0f
DA
21812012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2182
2183 * marker.c (set_marker_restricted_both): Simplify by using
2184 clip_to_bounds.
2185
f520ef9b
PE
21862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2189
383b7c95
JD
21902012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2191
2192 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2193 not defined (Bug#11768).
2194 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2195 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2196 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2197 followed by gtk_box_set_homogeneous (Bug#11768).
2198 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2199 (update_theme_scrollbar_width, xg_create_scroll_bar):
2200 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2201 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2202 (is_box_type): New function (Bug#11768).
2203 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2204 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2205 with default display (Bug#11768).
2206
d6e7bf45
EZ
22072012-07-05 Eli Zaretskii <eliz@gnu.org>
2208
2209 * xdisp.c (window_hscroll_limited): New function.
2210 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2211 coordinates when window's hscroll is set to insanely large
2212 values. (Bug#11857)
2213
431391ec
JB
22142012-07-05 Juanma Barranquero <lekktu@gmail.com>
2215
2216 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2217 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2218
23f86fce
DA
22192012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2220
2221 Cleanup xmalloc.
2222 * lisp.h (xzalloc): New prototype. Omit needless casts.
2223 * alloc.c (xzalloc): New function. Omit needless casts.
2224 * charset.c: Omit needless casts. Convert all calls to
2225 xmalloc with following memset to xzalloc.
2226 * dispnew.c: Likewise.
2227 * fringe.c: Likewise.
2228 * image.c: Likewise.
2229 * sound.c: Likewise.
2230 * term.c: Likewise.
2231 * w32fns.c: Likewise.
2232 * w32font.c: Likewise.
2233 * w32term.c: Likewise.
2234 * xfaces.c: Likewise.
2235 * xfns.c: Likewise.
2236 * xterm.c: Likewise.
2237 * atimer.c: Omit needless casts.
2238 * buffer.c: Likewise.
2239 * callproc.c: Likewise.
2240 * ccl.c: Likewise.
2241 * coding.c: Likewise.
2242 * composite.c: Likewise.
2243 * doc.c: Likewise.
2244 * doprnt.c: Likewise.
2245 * editfns.c: Likewise.
2246 * emacs.c: Likewise.
2247 * eval.c: Likewise.
2248 * filelock.c: Likewise.
2249 * fns.c: Likewise.
2250 * gtkutil.c: Likewise.
2251 * keyboard.c: Likewise.
2252 * lisp.h: Likewise.
2253 * lread.c: Likewise.
2254 * minibuf.c: Likewise.
2255 * msdos.c: Likewise.
2256 * print.c: Likewise.
2257 * process.c: Likewise.
2258 * region-cache.c: Likewise.
2259 * search.c: Likewise.
2260 * sysdep.c: Likewise.
2261 * termcap.c: Likewise.
2262 * terminal.c: Likewise.
2263 * tparam.c: Likewise.
2264 * w16select.c: Likewise.
2265 * w32.c: Likewise.
2266 * w32reg.c: Likewise.
2267 * w32select.c: Likewise.
2268 * w32uniscribe.c: Likewise.
2269 * widget.c: Likewise.
2270 * xdisp.c: Likewise.
2271 * xmenu.c: Likewise.
2272 * xrdb.c: Likewise.
2273 * xselect.c: Likewise.
2274
0497dc44
PE
22752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2276
2277 * fileio.c (time_error_value): Check the right error number.
2278 Problem reported by Troels Nielsen in
2279 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2280
356e7178
PE
22812012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2282
4e71fd89
PE
2283 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2284 This should be fixed in a better way; see Eli Zaretskii in
2285 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2286 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2287
f0941253
PE
2288 * fileio.c (time_error_value): Rename from special_mtime.
2289 The old name's problems were noted by Eli Zaretskii in
2290 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2291
065c9eb4
PE
2292 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2293 This variable's comment says Emacs needs at least one GDB-visible
2294 symbol of type enum pvec_type, to work around GDB problems.
2295 The symbol's value doesn't matter.
2296
356e7178
PE
2297 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2298 that causes compilation to fail on pre-C99 compilers.
2299
ed9265fc 23002012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2301
2302 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2303 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2304
3884d954
DA
23052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2306
d209e2fb 2307 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2308 headers for buffer_defaults and buffer_local_symbols.
2309 Reported by Juanma Barranquero <lekktu@gmail.com>.
2310
ee28be33
SM
23112012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2312
2313 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2314 * lisp.h (enum pvec_type): Use fewer bits.
2315 (PSEUDOVECTOR_SIZE_BITS): New constant.
2316 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2317 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2318 change in pvec_type.
2319 (PSEUDOVECTOR_TYPEP): New macro.
2320 (TYPED_PSEUDOVECTORP): Use it.
2321 * fns.c (internal_equal): Adapt code to extract pvectype.
2322 * emacs.c (gdb_pvec_type): Update type.
2323 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2324 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2325 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2326 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2327 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2328 abusing vector->header.next.nbytes.
2329 (live_vector_p): Use PVEC_TYPE.
2330 (mark_object): Adapt code to extract pvectype. Use switch.
2331
c7f2cd7f
PE
23322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2333
2334 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2335 Tighten new eassert a bit.
2336
8ce70ed2
DA
23372012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2338
2339 Fix compilation with --enable-gcc-warnings and -O1
2340 optimization level.
2341 * doprnt.c (doprnt): Change type of tem to int, initialize
2342 to avoid compiler warning. Add eassert.
2343 * search.c (simple_search): Initialize match_byte to avoid
2344 compiler warning. Add eassert.
2345
dea7f1e5
PE
23462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2347
24a212eb
PE
2348 Avoid weird behavior with large horizontal scrolls.
2349 Without this change, for example, large hscroll values would
2350 mess up Emacs's display on Fedora 15 x86, presumably due to
2351 overflows in int calculations in the display code.
2352 Also, if buffers had long lines, Emacs would freeze.
2353 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2354 (set_window_hscroll): New function, containing the old guts of
2355 Fset_window_hscroll. Return the clipped value.
2356 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2357 This avoids the need to check against PTRDIFF_MAX.
2358
dea7f1e5
PE
2359 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2360
76046526
DA
23612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2362
2363 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2364
39adff0d
PE
23652012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2366
63807d47
PE
2367 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2368 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2369 since GCC 4.4.6 issues a bogus warning for them.
2370
39adff0d
PE
2371 Fix bugs in file timestamp newness comparisons.
2372 * fileio.c (Ffile_newer_than_file_p):
2373 * lread.c (Fload): Use full timestamp resolution of files,
2374 not just the 1-second resolution, so that files that are only
2375 slightly newer still count as newer.
2376 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2377 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2378
dbeed9a6
PE
23792012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * fileio.c: Improve handling of file time marker. (Bug#11852)
2382 (special_mtime): New function.
2383 (Finsert_file_contents, Fverify_visited_file_modtime):
2384 Use it to set special mtime values consistently.
2385
636334d6
AS
23862012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2387
2388 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2389 marker for non-existing file. (Bug#11852)
2390
e2017fe2
GM
23912012-07-03 Glenn Morris <rgm@gnu.org>
2392
2393 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2394 and did not make it into globals.h).
2395
404dbd37
TT
23962012-07-03 Tom Tromey <tromey@redhat.com>
2397
2398 * window.c (Fset_window_margins, Fset_window_fringes)
2399 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2400 * textprop.c (Fprevious_property_change): No longer static.
2401 * syntax.c (Fsyntax_table_p): No longer static.
2402 * process.c (Fget_process, Fprocess_datagram_address): No longer
2403 static.
2404 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2405 * keyboard.c (Fcommand_execute): No longer static.
2406 Remove EXFUN.
2407 * insdel.c (Fcombine_after_change_execute): No longer static.
2408 * image.c (Finit_image_library): No longer static.
2409 * fileio.c (Fmake_symbolic_link): No longer static.
2410 * eval.c (Ffetch_bytecode): No longer static.
2411 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2412 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2413 No longer static.
404dbd37
TT
2414 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2415 static.
2416 * dired.c (Ffile_attributes): No longer static.
2417 * composite.c (Fcomposition_get_gstring): No longer static.
2418 * callproc.c (Fgetenv_internal): No longer static.
2419
2420 * ccl.h: Remove EXFUNs.
2421 * buffer.h: Remove EXFUNs.
2422 * dispextern.h: Remove EXFUNs.
2423 * intervals.h: Remove EXFUNs.
2424 * fontset.h: Remove EXFUN.
2425 * font.h: Remove EXFUNs.
2426 * dosfns.c (system_process_attributes): Remove EXFUN.
2427 * keymap.h: Remove EXFUNs.
2428 * lisp.h: Remove EXFUNs.
2429 * w32term.h: Remove EXFUNs.
2430 * window.h: Remove EXFUNs.
2431 * xsettings.h: Remove EXFUN.
2432 * xterm.h: Remove EXFUN.
2433
8e4fd1e1
GM
24342012-07-03 Glenn Morris <rgm@gnu.org>
2435
2436 * lisp.h (Frandom): Make it visible to C.
2437 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2438 buffer for invisible buffers. (Bug#1229)
2439
ca95b3eb
DA
24402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2441
2442 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2443 values which aren't power of 2.
2444 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2445 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2446 accordingly.
2447
7555c33f
SM
24482012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2449
2450 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2451
2452 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2453
d12e8f5a
DA
24542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2455
2456 * alloc.c (allocate_vector_block): Remove redundant
2457 calls to mallopt if DOUG_LEA_MALLOC is defined.
2458 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2459 avoid calls to mallopt if zero_vector is returned.
2460
296094c3
DA
24612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2462
2463 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2464 is enabled, avoid dereferencing NULL current_sblock if
2465 running undumped.
2466
36429c89
DA
24672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2468
2469 Cleanup basic buffer management.
2470 * buffer.h (struct buffer): Change layout to use generic vector
2471 marking code. Fix some comments. Change type of 'clip_changed'
2472 to bitfield. Remove unused #ifndef old.
2473 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2474 (GET_OVERLAYS_AT): Fix indentation.
2475 (for_each_per_buffer_object_at): New macro.
2476 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2477 (Fbuffer_local_variables): Use it.
2478 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2479 * alloc.c (allocate_buffer): Adjust to match new layout of
2480 struct buffer. Fix comment.
2481 (mark_overlay): New function.
2482 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2483 Lisp area of struct buffer.
2484 (mark_object): Use it. Adjust marking of misc objects
2485 and related comments.
2486
3b3e4cac
PE
24872012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2488
2489 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2490 wrapper that is not needed because the wrapped code is a no-op (zero
2491 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2492 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2493
cf5c0175
DA
24942012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2495
2496 * alloc.c (mark_buffer): Simplify. Remove prototype.
2497 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2498 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2499 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2500 redundant calls to mark_vectorlike for bool vectors.
2501
ca26824c
GM
25022012-06-30 Glenn Morris <rgm@gnu.org>
2503
2e4c5312
GM
2504 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2505
ca26824c
GM
2506 * epaths.in (PATH_SITELOADSEARCH): New.
2507 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2508 This is rather than relying on --enable-locallisppath elements
2509 having "site-lisp" in their names. (Bug#10208#25, 11658)
2510
0d23c240
EZ
25112012-06-30 Eli Zaretskii <eliz@gnu.org>
2512
c9240d7a
EZ
2513 * w32proc.c (sys_select): Accept and ignore one more argument.
2514
2515 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2516
0d23c240 2517 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2518 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2519
2520 * sysdep.c: Don't include dos.h and dosfns.h.
2521
2522 * process.c (sys_select):
2523 * msdos.c (sys_select): Accept one more argument and ignore it.
2524
2525 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2526 adapt data types and code to that.
2527
2528 * dosfns.c:
2529 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2530 which clashes with the gnulib function of the same name.
2531
af5a5a98
AS
25322012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2533
c5e4379c
AS
2534 * font.c (font_style_to_value, font_style_symbolic)
2535 (font_prop_validate_style): Add type checks for values in
2536 font_style_table.
2537
af5a5a98
AS
2538 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2539 argument.
2540 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2541 uses.
2542
8d38f461
EZ
25432012-06-29 Eli Zaretskii <eliz@gnu.org>
2544
2e5a6631
EZ
2545 * xdisp.c (try_window_id): Undo last change.
2546
8d38f461
EZ
2547 * w32.c (getwd): Adjust commentary about startup_dir.
2548 (init_environment): Always call sys_access, even in non-MSVC
2549 builds. Don't chdir to the directory of the Emacs executable.
2550 This undoes code from 1997 which was justified by the need to
2551 "avoid conflicts when removing and renaming directories". But its
2552 downside was that every relative file name was being interpreted
2553 relative to the directory of the Emacs executable, which can never
2554 be TRT. In particular, it broke sys_access when called with
2555 relative file names.
2556 (sys_access): Map GetLastError to errno.
2557
2af3565e
DA
25582012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2559
2560 * window.h (struct window): Change type of 'fringes_outside_margins'
2561 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2562 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2563 Adjust comment.
2564 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2565 to ptrdiff_t.
2566
c8d3a25c 25672012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2568
c8d3a25c
GM
2569 * gnutls.c (emacs_gnutls_handshake):
2570 Add QUIT to make the loop interruptible.
57570cd3 2571
c8d3a25c 25722012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2573
c8d3a25c
GM
2574 * charset.c (init_charset): Make lack of etc/charsets fatal.
2575
3e984ee8
DA
25762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2577
2578 * editfns.c (region_limit): Fix type mismatch.
2579
ef884f23
DA
25802012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2581
2582 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2583 undefined. Convert from xassert to eassert.
2584 * nsmenu.m: Convert from xassert to eassert.
2585 * nsterm.m: Likewise.
2586
7d7e0027
SM
25872012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2588
2589 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2590
aa754e6a
PE
25912012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 Avoid integer overflow on scroll-left and scroll-right.
2594 * window.c (HSCROLL_MAX): New macro.
2595 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2596 overflow when requested scroll falls outside ptrdiff_t range.
2597
80b00b08
DA
25982012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2599
2600 * window.h (struct window): Change type of 'hscroll',
2601 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2602 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2603 Adjust users accordingly.
2604 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2605 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2606 from EMACS_INT to ptrdiff_t.
2607 (make_window): Omit redundant initialization.
2608
62b2bcf6
JB
26092012-06-28 Juanma Barranquero <lekktu@gmail.com>
2610
2611 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2612
45942c7d
DA
26132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2614
2615 * window.h (struct window): Change type of 'use_time' and
2616 'sequence_number' from Lisp_Object to int.
2617 * frame.c (make_frame): Adjust users accordingly.
2618 * print.c (print_object): Likewise.
2619 * window.c (select_window, Fwindow_use_time, make_parent_window)
2620 (make_window): Likewise.
2621
e509cfa6
DA
26222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2623
2624 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2625 enabled with --enable-checking=[all,glyphs] configure option.
2626 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2627 adjust comments accordingly.
2628 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2629 undefined, adjust comments accordingly.
2630 * image.c: Likewise.
2631 * scroll.c: Likewise.
2632 * w32fns.c: Likewise.
2633 * w32term.c: Likewise.
2634 * xdisp.c: Likewise.
2635 * xfaces.c: Likewise.
2636 * xfns.c: Likewise.
2637 * xterm.c: Likewise.
2638
a54e2c05
DA
26392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2640
2641 Generalize run-time debugging checks.
2642 * dispextern.h (XASSERTS): Remove.
2643 * fontset.c (xassert): Remove.
2644 Convert from xassert to eassert.
2645 * alloc.c: Convert from xassert to eassert.
2646 * bidi.c: Likewise.
2647 * dispnew.c: Likewise.
2648 * fns.c: Likewise.
2649 * fringe.c: Likewise.
2650 * ftfont.c: Likewise.
2651 * gtkutil.c: Likewise.
2652 * image.c: Likewise.
2653 * keyboard.c: Likewise.
2654 * menu.c: Likewise.
2655 * process.c: Likewise.
2656 * scroll.c: Likewise.
2657 * sound.c: Likewise.
2658 * term.c: Likewise.
2659 * w32console.c: Likewise.
2660 * w32fns.c: Likewise.
2661 * w32term.c: Likewise.
2662 * window.c: Likewise.
2663 * xdisp.c: Likewise.
2664 * xfaces.c: Likewise.
2665 * xfns.c: Likewise.
2666 * xselect.c: Likewise.
2667 * xterm.c: Likewise.
2668
1ec4b7b2
SM
26692012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2670
2671 * fns.c (maybe_resize_hash_table): Output message when growing the
2672 purify-hashtable.
2673
2014308a
DA
26742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2675
2676 * alloc.c (allocate_string_data): Remove dead code.
2677 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2678 avoid GCC warning about unused macro.
2679
246155eb
DA
26802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2681
2682 * alloc.c (allocate_string): Omit intervals initialization.
2683 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2684 as in make_pure_string and make_pure_c_string.
2685
43184b7b
DA
26862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2687
d209e2fb 2688 * alloc.c (allocate_string): Fix last change.
43184b7b 2689
3fe6dd74
DA
26902012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2691
d209e2fb 2692 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2693 to memset, add explicit initialization where appropriate.
2694
1ba6038a
GM
26952012-06-27 Glenn Morris <rgm@gnu.org>
2696
2697 * lisp.mk (lisp): Remove paths.elc.
2698
c89926a5
CY
26992012-06-27 Chong Yidong <cyd@gnu.org>
2700
2701 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2702
ed6b3510
JW
27032012-06-26 John Wiegley <johnw@newartisans.com>
2704
1ec4b7b2 2705 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2706 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2707
ed6b3510
JW
2708 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2709 when building with Clang.
2710
8edd4a2b
SM
27112012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2712
2713 * eval.c (Fapply): Allow calling it with a single argument.
2714
f6f62d1b
EZ
27152012-06-26 Eli Zaretskii <eliz@gnu.org>
2716
2717 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2718 _stricmp and _strnicmp.
2719 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2720
62efea5e
DA
27212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2722
2723 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2724 allocated window.
2725 (allocate_process): Likewise for new process.
8edd4a2b 2726 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2727 (allocate_frame): Likewise.
2728 * frame.c (make_frame): Omit redundant initialization.
2729 * window.c (make_parent_window): Use memset.
2730 (make_window): Omit redundant initialization.
2731 * process.c (make_process): Omit redundant initialization.
2732 * terminal.c (create_terminal): Likewise.
2733
42997f4d
DA
27342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2735
2736 * term.c (delete_tty): Remove redundant call to memset.
2737
1130ecfc
DA
27382012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2739
2740 * alloc.c: Remove build_string.
2741 * lisp.h: Define build_string as static inline. This provides
2742 a better opportunity to optimize away calls to strlen when the
2743 function is called with compile-time constant argument.
2744 * image.c (imagemagick_error): Convert to build_string.
2745 * w32proc.c (sys_spawnve): Likewise.
2746 * xterm.c (x_term_init): Likewise.
2747
cf38a720
PE
27482012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2749
99027bdd
PE
2750 Use sprintf return value instead of invoking strlen on result.
2751 In the old days this wasn't portable, since some sprintf
2752 implementations returned char *. But they died out years ago and
2753 Emacs already assumes sprintf returns int.
2754 Similarly for float_to_string.
2755 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2756 * ccl.c (ccl_driver):
2757 * character.c (string_escape_byte8):
2758 * data.c (Fnumber_to_string):
2759 * doprnt.c (doprnt):
2760 * print.c (print_object):
2761 * xdisp.c (message_dolog):
2762 * xfns.c (syms_of_xfns):
2763 Use sprintf or float_to_string result to avoid need to call strlen.
2764 * data.c (Fnumber_to_string):
2765 Use make_unibyte_string, since the string must be ASCII.
2766 * lisp.h, print.c (float_to_string): Now returns int length.
2767 * term.c (produce_glyphless_glyph):
2768 Use sprintf result rather than recomputing it.
2769
cf38a720
PE
2770 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2771 * Makefile.in (ALL_CFLAGS):
2772 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2773 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2774
3511c784
DA
27752012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2776
0a08eb21 2777 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2778 strcasecmp if available.
2779 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2780
fb7da12e
AS
27812012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2782
2783 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2784 Avoid comma operator.
2785 * menu.c (push_submenu_start, push_submenu_end)
2786 (push_left_right_boundary, push_menu_pane): Likewise.
2787 * msdos.c (dos_rawgetc): Likewise.
2788
afa2ffd8
DA
27892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2790
2791 * xfns.c (xic_create_fontsetname): Remove redundant calls
2792 to memset.
2793
b3b4476b
PE
27942012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2795
4495ff38
PE
2796 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2797 sprintf already null-terminates its output.
2798
b3b4476b
PE
2799 * xfns.c (x_window): Remove redundant cast.
2800
b00876c9
DA
28012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2802
2803 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2804 `const char *' to `char *' to avoid compiler warning.
2805
d188e26b
PE
28062012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2807
885d1d74
PE
2808 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2809 instead of truncating it to 63 (admittedly a generous limit).
2810
d188e26b
PE
2811 * process.c: Fix spelling and caps in comments.
2812
e2f560b1
DN
28132012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2814
e86db54b 2815 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2816 * sysdep.c (setpgrp): Remove definition, not used in this file.
2817
7583a3a1
JB
28182012-06-24 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * makefile.w32-in: Update dependencies.
2821
696056c2
EZ
28222012-06-24 Eli Zaretskii <eliz@gnu.org>
2823
2824 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2825 (SYSTIME_H): Add nt/inc/sys/time.h.
2826
2827 * systime.h [WINDOWSNT]: Include sys/time.h.
2828
2829 * s/ms-w32.h (struct timespec): Definition moved from
2830 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2831
845ca893
PE
28322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2835 * buffer.h (buffer_slot_type_mismatch):
2836 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2837 * eval.c (unwind_to_catch):
2838 * image.c (my_png_error, my_error_exit):
2839 * keyboard.c (quit_throw_to_read_char, user_error)
2840 (Fexit_recursive_edit, Fabort_recursive_edit):
2841 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2842 (wrong_type_argument, buffer_overflow, __executable_start)
2843 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2844 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2845 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2846 (fatal):
2847 (child_setup) [!DOS_NT]:
2848 * lread.c (end_of_file_error, invalid_syntax):
2849 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2850 * puresize.h (pure_write_error):
2851 * search.c (matcher_overflow):
2852 * sound.c (sound_perror, alsa_sound_perror):
2853 * sysdep.c, syssignal.h (croak):
2854 * term.c (maybe_fatal, vfatal):
2855 * textprop.c (text_read_only):
2856 * undo.c (user_error):
2857 * unexmacosx.c (unexec_error):
2858 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2859 Use _Noreturn rather than NO_RETURN.
2860 No need for separate decl merely because of _Noreturn.
2861 * sound.c (sound_warning, parse_sound):
2862 Remove unnecessary forward decls.
2863
f1dd8073
PE
28642012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2867 * lisp.h (WAIT_READING_MAX): New macro.
2868 * dispnew.c (Fsleep_for, sit_for):
2869 * keyboard.c (kbd_buffer_get_event):
2870 * process.c (Faccept_process_output):
2871 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2872 This improves on the previous patch, which introduced a bug
2873 when time_t is unsigned and as wide as intmax_t.
2874 See <http://bugs.gnu.org/9000#51>.
2875
b82c1755
EZ
28762012-06-23 Eli Zaretskii <eliz@gnu.org>
2877
2878 * dispnew.c (sit_for, Fsleep_for):
2879 * keyboard.c (kbd_buffer_get_event):
2880 * process.c (Faccept_process_output): Avoid compiler warnings when
2881 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2882
ca300656
JB
28832012-06-23 Juanma Barranquero <lekktu@gmail.com>
2884
049ec95b
JB
2885 * makefile.w32-in: Update dependencies.
2886
ca300656
JB
2887 * w32.c (ltime): Add return type and declare static.
2888 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2889
db7b8d06
PE
28902012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2891
2892 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2893 Privately reported by Herbert J. Skuhra.
2894 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2895 All uses changed.
2896 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2897 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2898
0bd8297f
EZ
28992012-06-23 Eli Zaretskii <eliz@gnu.org>
2900
96512555
EZ
2901 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2902 last argument of make_unibyte_string.
2903
0bd8297f
EZ
2904 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2905 language ID in the event parameters.
2906
2907 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2908 event.code, not the obscure "character set ID".
2909
63def6b6
CY
29102012-06-23 Chong Yidong <cyd@gnu.org>
2911
2912 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2913
e8a02204
EZ
29142012-06-23 Eli Zaretskii <eliz@gnu.org>
2915
388cdec0
EZ
2916 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2917 * w32.c (fdutimens): New function.
2918
2919 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2920
2921 * s/ms-w32.h (pselect): Redirect to sys_select.
2922
2923 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2924
e8a02204
EZ
2925 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2926 in the logic of incrementing and decrementing the value of
2927 use_relocatable_buffers.
2928
d054f3fb
PE
29292012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2932 Privately reported by Herbert J. Skuhra.
2933 [__FreeBSD__]: Remove "*/" typo after "#include".
2934 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2935 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2936 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2937 Don't assume EMACS_TIME and struct timeval are the same type.
2938
d35af63c
PE
29392012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2940
2941 Support higher-resolution time stamps (Bug#9000).
2942 The time stamps are only nanosecond-resolution at the C level,
2943 since that's the best that any real-world system supports now.
2944 But they are picosecond-resolution at the Lisp level, as that's
2945 easy, and leaves room for future OS improvements.
2946
2947 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2948 (LIBES): Use it.
2949
2950 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2951 Don't get current time unless it's needed.
2952
2953 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2954 now provides it if it's absent.
2955 (start_atimer): Port to higher-res time stamps.
2956 Check for time stamp overflow. Don't get current time more
2957 often than is needed.
2958
2959 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2960 Include systime.h, not time.h.
2961 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2962
2963 * dired.c: Include stat-time.h.
2964 (Ffile-attributes): File times now have higher resolution.
2965
2966 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2967 (struct image): Timestamp now has higher resolution.
2968
2969 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2970 has at least microseconds now. All uses removed.
2971 (update_frame, update_single_window, update_window, update_frame_1)
2972 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2973
2974 * editfns.c (time_overflow): Now extern.
2975 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2976 (float-time, Fformat_time_string, Fcurrent_time_string)
2977 (Fcurrent_time_zone): Accept and generate higher-resolution
2978 time stamps.
2979 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2980 (decode_time_components, lisp_seconds_argument): New functions.
2981 (make_time): Now static.
2982 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2983 Report an error if the time is invalid, rather than having the caller
2984 do that.
2985
2986 * fileio.c: Include <stat-time.h>
2987 (Fcopy_file): Copy higher-resolution time stamps.
2988 Prefer to set the time stamp via a file descriptor if that works.
2989 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2990 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2991 (Fvisited_file_modtime, Fset_visited_file_modtime):
2992 Support higher-resolution time stamps.
2993
2994 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2995
2996 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2997
2998 * image.c (prepare_image_for_display, clear_image_cache)
2999 (lookup_image): Port to higer-resolution time stamps.
3000
3001 * keyboard.c (start_polling, bind_polling_period):
3002 Check for time stamp overflow.
3003 (read_char, kbd_buffer_get_event, timer_start_idle)
3004 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3005 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3006 Port to higher-resolution time stamps. Do not assume time_t is signed.
3007 (decode_timer): New function. Timers are now vectors of length 9,
3008 not 8, to accommodate the picosecond component.
3009 (timer_check_2): Use it.
3010
3011 * nsterm.m (select_timeout, timeval_subtract): Remove.
3012 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3013 as they're a bit more accurate and handle overflow better.
3014 (ns_select): Change prototype to be compatible with pselect.
3015 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3016 * nsterm.h (ns_select): Adjust prototype.
3017
3018 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3019 us-resolution time stamps.
3020 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3021
3022 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3023
3024 * lisp.h (time_overflow): New decl.
3025 (wait_reading_process_output): First arg is now intmax_t, not int,
3026 to accommodate larger waits.
3027
3028 * process.h (struct Lisp_Process.read_output_delay):
3029 Now counts nanoseconds, not microseconds.
3030 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3031 EMACS_HAS_USECS.
3032 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3033 (wait_reading_process_output):
3034 Port to ns-resolution time stamps.
3035 (Faccept_process_output, wait_reading_process_output):
3036 Check for time stamp overflow. Do not assume time_t is signed.
3037 (select_wrapper): Remove; we now use pselect.
3038 (Fprocess_attributes): Now generates ns-resolution time stamps.
3039
3040 * sysdep.c: Include utimens.h. Don't include utime.h
3041 or worry about struct utimbuf; gnulib does that for us now.
3042 (gettimeofday): Remove; gnulib provides a substitute.
3043 (make_timeval): New function.
3044 (set_file_times): Now sets ns-resolution time stamps.
3045 New arg FD; all uses changed.
3046 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3047 (system_process_attributes):
3048 Now returns ns-resolution time stamp. All uses changed.
3049 Check for time stamp overflow.
3050
3051 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3052 provides a substitute now.
3053
3054 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3055 since it guarantees struct timespec.
3056 (EMACS_TIME): Now struct timespec, so that we can support
3057 ns-resolution time stamps.
3058 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3059 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3060 (EMACS_USECS): Remove.
3061 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3062 so multiply the arg by 1000 before storing it.
3063 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3064 New macros.
3065 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3066 Port to ns-resolution time stamps.
3067 (EMACS_TIME_NEG_P): Remove; replaced by....
3068 (EMACS_TIME_SIGN): New macro.
3069 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3070 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3071 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3072 (make_timeval, make_lisp_time, decode_time_components): New decls.
3073 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3074 that it mishandled time_t overflow. You can't compare by subtracting!
3075 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3076 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3077
3078 * term.c: Include <sys/time.h>.
3079 (timeval_to_Time): New function, for proper overflow wraparound.
3080 (term_mouse_position, term_mouse_click): Use it.
3081
3082 * undo.c (record_first_change): Support higher-resolution time stamps
3083 in the undo buffer.
3084 (Fprimitive_undo): Use them when restoring time stamps.
3085
3086 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3087 (w32_get_internal_run_time):
3088 Port to higher-resolution Emacs time stamps.
3089 (ltime): Now accepts single 64-bit integer, as that's more convenient
3090 for callers.
3091
3092 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3093
3094 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3095 for compatibility with pselect. Support ns-resolution time stamps.
3096
3097 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3098
3099 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3100 Check for time stamp overflow, and support ns-resolution time stamps.
3101
3102 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3103 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3104 (timeval_subtract): Remove; no longer needed.
3105 (XTflash, XTring_bell, x_wait_for_event):
3106 Port to ns-resolution time stamps. Don't assume time_t is signed.
3107
b6a92dfe
CY
31082012-06-22 Chong Yidong <cyd@gnu.org>
3109
3110 * xdisp.c (x_consider_frame_title): Revert last change.
3111
d251c37c
EZ
31122012-06-22 Eli Zaretskii <eliz@gnu.org>
3113
3114 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3115 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3116 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3117 staticidx goes up to 1597 out of 1600 = 0x640.)
3118
f10deafb
PE
31192012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3122 Otherwise, the umask might be mistakenly 0 while handling input signals.
3123
ec6de1e2
SM
31242012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3125
3126 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3127
28be1ada
DA
31282012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3129
3130 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3131 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3132 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3133 access to `contents' member of Lisp_Vector objects with AREF and ASET
3134 where appropriate.
3135
c6bf3022
CY
31362012-06-19 Chong Yidong <cyd@gnu.org>
3137
3138 * frame.c (delete_frame): When selecting a frame on a different
3139 text terminal, do not alter the terminal's top-frame.
3140
3141 * xdisp.c (format_mode_line_unwind_data): Record the target
3142 frame's selected window and its terminal's top-frame.
3143 (unwind_format_mode_line): Restore them.
3144 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3145 Callers changed.
3146 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3147 since tty frames can be explicitly named.
3148 (prepare_menu_bars): Likewise.
3149
3150 * term.c (Ftty_top_frame): New function.
3151
defd4196
PE
31522012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3153
3154 Port byte-code-meter to modern targets.
3155 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3156 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3157 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3158 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3159 (METER_1, METER_2): Simplify.
3160
1053a871
SM
31612012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3162
3163 * data.c (Fdefalias): Return `symbol' (bug#11686).
3164
b7e8d081
MR
31652012-06-18 Martin Rudalics <rudalics@gmx.at>
3166
3167 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3168 gets killed during executing of this function (Bug#11665).
3169 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3170 (Vkill_buffer_query_functions): In doc-string say that functions
3171 run by this hook should not change the current buffer.
3172
7ea2b339
PE
31732012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3174
3175 Fix recently-introduced process.c problems found by static checking.
3176 * process.c (write_queue_push, write_queue_pop, send_process):
3177 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3178 (write_queue_pop): Fix pointer signedness problem.
3179 (send_process): Remove unused local.
3180
96a313a1
CY
31812012-06-17 Chong Yidong <cyd@gnu.org>
3182
3183 * xdisp.c (redisplay_internal): No need to redisplay terminal
3184 frames that are not on top.
3185
20ca2e94
TN
31862012-06-17 Troels Nielsen <bn.troels@gmail.com>
3187
3188 * process.c (make_process): Initialize write_queue.
3189 (write_queue_push, write_queue_pop): New functions.
3190 (send_process): Use them to maintain correct ordering of process
3191 writes (Bug#10815).
3192
9a900ca9
PE
31932012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3194
310fbfa8
PE
3195 * lisp.h (eassert): Assume C89 or later.
3196 This removes the need for CHECK.
3197 (CHECK): Remove. Its comments about always evaluating its
3198 argument were confusing, as 'eassert' typically does not evaluate
3199 its argument.
3200
27bb1ca4
PE
3201 * coding.c (produce_chars): Use ptrdiff_t, not int.
3202
9a900ca9
PE
3203 * xterm.c (x_draw_underwave): Check for integer overflow.
3204 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3205
41b7f8bc 32062012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3207
3208 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3209 referenced (Bug#11583).
3210
9b0e3eba
AA
32112012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3212
3213 Implement wave-style variant of underlining.
3214 * dispextern.h (face_underline_type): New enum.
3215 (face): Add field for underline type.
3216 * nsterm.m (ns_draw_underwave): New function.
3217 (ns_draw_text_decoration): Use it.
3218 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3219 New functions.
3220 (x_draw_glyph_string): Use them.
3221 * xfaces.c (Qline, Qwave): New Lisp objects.
3222 (check_lface_attrs, merge_face_ref)
1053a871
SM
3223 (Finternal_set_lisp_face_attribute, realize_x_face):
3224 Handle wave-style underline face attributes.
9b0e3eba
AA
3225 * xterm.c (x_draw_underwave): New function.
3226 (x_draw_glyph_string): Use it.
3227
0fb52f11
JB
32282012-06-16 Juanma Barranquero <lekktu@gmail.com>
3229
3230 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3231 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3232 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3233 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3234 ($(BLD)/w32select.$(O)): Update dependencies.
3235
e5560ff7
AS
32362012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3237
3238 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3239 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3240 * character.c (_fetch_multibyte_char_p): Remove.
3241 * alloc.c: Include "character.h" before "buffer.h".
3242 * bidi.c: Likewise.
3243 * buffer.c: Likewise.
3244 * bytecode.c: Likewise.
3245 * callint.c: Likewise.
3246 * callproc.c: Likewise.
3247 * casefiddle.c: Likewise.
3248 * casetab.c: Likewise.
3249 * category.c: Likewise.
3250 * cmds.c: Likewise.
3251 * coding.c: Likewise.
3252 * composite.c: Likewise.
3253 * dired.c: Likewise.
3254 * dispnew.c: Likewise.
3255 * doc.c: Likewise.
3256 * dosfns.c: Likewise.
3257 * editfns.c: Likewise.
3258 * emacs.c: Likewise.
3259 * fileio.c: Likewise.
3260 * filelock.c: Likewise.
3261 * font.c: Likewise.
3262 * fontset.c: Likewise.
3263 * fringe.c: Likewise.
3264 * indent.c: Likewise.
3265 * insdel.c: Likewise.
3266 * intervals.c: Likewise.
3267 * keyboard.c: Likewise.
3268 * keymap.c: Likewise.
3269 * lread.c: Likewise.
3270 * macros.c: Likewise.
3271 * marker.c: Likewise.
3272 * minibuf.c: Likewise.
3273 * nsfns.m: Likewise.
3274 * nsmenu.m: Likewise.
3275 * print.c: Likewise.
3276 * process.c: Likewise.
3277 * regex.c: Likewise.
3278 * region-cache.c: Likewise.
3279 * search.c: Likewise.
3280 * syntax.c: Likewise.
3281 * term.c: Likewise.
3282 * textprop.c: Likewise.
3283 * undo.c: Likewise.
3284 * unexsol.c: Likewise.
3285 * w16select.c: Likewise.
3286 * w32fns.c: Likewise.
3287 * w32menu.c: Likewise.
3288 * window.c: Likewise.
3289 * xdisp.c: Likewise.
3290 * xfns.c: Likewise.
3291 * xmenu.c: Likewise.
3292 * xml.c: Likewise.
3293 * xselect.c: Likewise.
3294
2f07e6af
EZ
32952012-06-16 Eli Zaretskii <eliz@gnu.org>
3296
1053a871
SM
3297 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3298 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3299 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3300 row.
3301 (handle_face_prop): Use chunk-relative overlay string index when
3302 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3303 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3304 the rightmost. (Bug#11720)
2f07e6af 3305
29b83cec
AS
33062012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3307
3308 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3309 (CATEGORY_MEMBER): Enforce 1/0 value.
3310 * category.c (_temp_category_set): Remove.
3311
4c5501e9
EZ
33122012-06-16 Eli Zaretskii <eliz@gnu.org>
3313
3314 * window.c (Fdelete_other_windows_internal)
3315 (Fdelete_window_internal): Don't access frame's mouse highlight
3316 info of the initial frame. (Bug#11677)
3317
2b570124
PE
33182012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3319
e93864f9
PE
3320 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3321 Assume USE_2_TAGS_FOR_INTS.
3322 (xreload): Adjust $tagmask width to match recent lisp.h change.
3323
2b570124
PE
3324 Simplify lisp.h in minor ways that should not affect code.
3325 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3326 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3327 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3328 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3329 (INTTYPEBITS): New macro, for clarity.
3330 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3331 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3332 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3333 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3334 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3335
81755f69
JB
33362012-06-13 Juanma Barranquero <lekktu@gmail.com>
3337
3338 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3339
16192a57
GM
33402012-06-13 Glenn Morris <rgm@gnu.org>
3341
3342 * s/bsd-common.h (BSD4_3):
3343 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3344
646b5f55
AS
33452012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3346
3347 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3348 instead of union.
3349 (XLI, XIL): Define.
1053a871
SM
3350 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3351 Use them.
3352 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3353 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3354 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3355 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3356 * frame.c (delete_frame): Remove outdated comment.
3357 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3358 USE_LISP_UNION_TYPE.
3359 (Fw32_unregister_hot_key): Likewise.
3360 (Fw32_toggle_lock_key): Likewise.
3361 * w32menu.c (add_menu_item): Likewise.
3362 (w32_menu_display_help): Use XIL instead of checking
3363 USE_LISP_UNION_TYPE.
3364 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3365 (init_heap): Likewise.
3366 * w32term.c (w32_read_socket): Update comment.
3367
1d3823c9
GM
33682012-06-13 Glenn Morris <rgm@gnu.org>
3369
c62ff706
GM
3370 * s/usg5-4-common.h, src/s/unixware.h:
3371 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3372
1d3823c9
GM
3373 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3374
bfe3e0a2
PE
33752012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3378 * alloc.c (make_number) [!defined make_number]:
3379 Remove, as lisp.h always defines this now.
3380 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3381 (roundup_size): Verify that it is a power of 2.
3382 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3383 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3384 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3385 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3386 USE_LSB_TAG now is always defined to be either 0 or 1.
3387 All uses changed.
3388 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3389 code works fine either way, and efficiency is not a concern here,
3390 as the union type is for debugging, not for production.
3391 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3392 Use an inline function on all platforms when using the union type,
3393 since this is simpler and 'static inline' can be used portably
3394 within Emacs now.
3395 (LISP_INITIALLY_ZERO): New macro.
3396 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3397 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3398
45fa9c0f
GM
33992012-06-12 Glenn Morris <rgm@gnu.org>
3400
b4492cba
GM
3401 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3402
3403 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3404
45fa9c0f
GM
3405 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3406 Move BROKEN_SIGIO to configure.
3407
3408 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3409 Move NO_TERMIO to configure.
3410
0e25d334
CY
34112012-06-12 Chong Yidong <cyd@gnu.org>
3412
3413 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3414 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3415 MagickExportImagePixels is undefined.
3416
43682bb6
PE
34172012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 * image.c (imagemagick_load_image): Remove unused label.
3420
a9be7d2b
GM
34212012-06-11 Glenn Morris <rgm@gnu.org>
3422
3423 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3424 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3425 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3426 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3427
3017f87f
SM
34282012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3429
3430 * alloc.c (make_byte_code): New function.
3431 (Fmake_byte_code): Use it. Don't purify here.
3432 * lread.c (read1): Use it as well to avoid extra allocation.
3433
1b9b4cf4
CY
34342012-06-11 Chong Yidong <cyd@gnu.org>
3435
3436 * image.c (imagemagick_load_image): Implement transparency.
3437
95988fcf
AS
34382012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3439
3440 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3441 account for preceding backslashes. (Bug#11663)
3442
cd4eb164
CY
34432012-06-09 Chong Yidong <cyd@gnu.org>
3444
3445 * term.c: Support italics in capable terminals (Bug#9652).
3446 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3447 (turn_on_face): Output using TS_enter_italic_mode if available.
3448 Don't handle unused blinking and alt-charset cases.
3449 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3450 and tty_alt_charset_p cases.
3451 (tty_capable_p, init_tty): Support italics.
3452
3453 * termchar.h (struct tty_display_info): Add field for italics.
3454 Remove unused blink field.
3455
3456 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3457 Handle slant.
3458
3459 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3460 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3461 tty_alt_charset_p. Add tty_italic_p.
3462
ff88beb8
MA
34632012-06-09 Michael Albinus <michael.albinus@gmx.de>
3464
3465 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3466 dbus_type_is_basic if available.
3467 (xd_extract_signed, xd_extract_unsigned): Rename from
3468 extract_signed and extract_unsigned, respectively. Adapt callers.
3469
44286096
CY
34702012-06-09 Chong Yidong <cyd@gnu.org>
3471
1682701f
CY
3472 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3473
44286096
CY
3474 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3475 case (Bug#9752).
3476
d86feb17
PE
34772012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 * xdisp.c (vmessage): Treat frame message as multibyte.
3480 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3481 would generate the diagnostic "Making \302\247 buffer-local while
3482 let-bound!".
3483
d5c20fe8
EZ
34842012-06-08 Eli Zaretskii <eliz@gnu.org>
3485
3486 * dispnew.c (showing_window_margins_p): Undo last change, which
3487 was done due to an inadvertent commit.
3488 (adjust_frame_glyphs_for_frame_redisplay): Do call
3489 showing_window_margins_p.
3490
513749ee
SM
34912012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3492
3493 * eval.c (Fmake_var_non_special): New primitive.
3494 (syms_of_eval): Defsubr it.
3495 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3496
d4a8f5c1
JB
34972012-06-08 Juanma Barranquero <lekktu@gmail.com>
3498
3499 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3500 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3501
8bbbc977
EZ
35022012-06-08 Eli Zaretskii <eliz@gnu.org>
3503
3504 * alloc.c (allocate_vectorlike): Fix last change.
3505
f3372c87
DA
35062012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3507
3508 Block-based vector allocation of small vectors.
3509 * lisp.h (struct vectorlike_header): New field `nbytes',
3510 adjust comment accordingly.
3511 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3512 to denote vector blocks. Adjust users (live_vector_p,
3513 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3514 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3515 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3516 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3517 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3518 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3519 (roundup_size): New constant.
3520 (struct vector_block): New data type.
3521 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3522 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3523 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3524 (sweep_vectors): New functions.
3525 (allocate_vectorlike): Return `zero_vector' as the only vector of
3526 0 items. Allocate new vector from block if vector size is less than
3527 or equal to VBLOCK_BYTES_MAX.
3528 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3529 (init_alloc_once): Add call to init_vectors.
3530
4f18a4ed
SM
35312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3532
3533 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3534
86f158bc
PE
35352012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 * doprnt.c (doprnt): Truncate multibyte char correctly.
3538 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3539 would mishandle a string argument "Xc" if X was a multibyte
3540 character of length 2: it would truncate after X's first byte
3541 rather than including all of X.
3542
c5cfcbe0
CY
35432012-06-06 Chong Yidong <cyd@gnu.org>
3544
3545 * buffer.c (word_wrap): Doc fix.
3546
c05cf390
PE
35472012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3548
3549 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3550
0c3461de
GM
35512012-06-03 Glenn Morris <rgm@gnu.org>
3552
3553 * xdisp.c (tool-bar-style): Doc fix.
3554
c71232db
UM
35552012-06-03 Ulrich Müller <ulm@gentoo.org>
3556
3557 * Makefile.in (PAXCTL): Define.
3558 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3559 binary via PaX flags if the paxctl utility is available.
3560 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3561 Restore PaX flags to their default. (Bug#11398)
3562
383f7350
CY
35632012-06-03 Chong Yidong <cyd@gnu.org>
3564
3565 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3566 buffer (Bug#11226).
3567
5f2c76c6
CY
35682012-06-03 Chong Yidong <cyd@gnu.org>
3569
3570 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3571 (note_mode_line_or_margin_highlight): If there is no help echo,
3572 use mode-line-default-help-echo. Handle the case where the mouse
3573 position is past the end of the mode line string.
3574
3575 * buffer.c (buffer_local_value_1): New function, split from
3576 Fbuffer_local_value; can return Qunbound.
3577 (Fbuffer_local_value): Use it.
3578 (Vmode_line_format): Docstring tweaks.
3579
773d47f6
PE
35802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3581
3582 * sysdep.c (system_process_attributes): Improve comment.
3583
f2d6a3df
SM
35842012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3585
3586 * keyboard.c: Export real-this-command to Elisp.
3587 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3588 and DEFVAR it. Update all users.
3589
63810350
PE
35902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3591
7bd5c1f4
PE
3592 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3593
63810350
PE
3594 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3595 Convert pctcpu and pctmem to Lisp float properly.
3596 Let the compiler fold better, as 100.0/0x8000 is exact.
3597
a2821611
AS
35982012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3599
3600 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3601 cons_block.
3602
5fceba1d
PE
36032012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3606
c98ff5dd
DA
36072012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3608
3609 For a 'struct window', replace some Lisp_Object fields to
3610 bitfields where appropriate, remove unused fields.
3611 * window.h (struct window): Remove unused 'last_mark_x' and
3612 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3613 change it's type from Lisp_Object to bitfield.
3614 Change type of 'force_start', 'optional_new_start',
3615 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3616 fields from Lisp_Object to bitfield. Adjust users accordingly.
3617
ca34e0be
PE
36182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 Pacify gcc -Wdouble-precision when using Xaw.
3621 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3622 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3623 Use 'float' consistently, rather than 'float' in most places
3624 and 'double' in a couple of places.
3625
efc00ab1 36262012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3627
3628 * xdisp.c (handle_stop): Detect whether we have overlay strings
3629 loaded by testing it->current.overlay_string_index to be
3630 non-negative, instead of checking whether n_overlay_strings is
3631 positive. (Bug#11587)
3632
efc00ab1 36332012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3634
3635 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3636
3637 * doc.c (Fsubstitute_command_keys): Doc fix.
3638
efc00ab1 36392012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3640
3641 * search.c (search_buffer): Remove calls to
3642 r_alloc_inhibit_buffer_relocation, as it is now called by
3643 maybe_unify_char, which was the cause of relocation of buffer text
3644 in bug#11519.
3645
efc00ab1 36462012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3647
3648 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3649 for the duration of call to load_charset, to avoid problems with
3650 callers of maybe_unify_char that access buffer text through C
3651 pointers.
3652
3653 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3654 decrement the inhibition flag, instead of just setting or
3655 resetting it.
3656
ba93a187
PE
36572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3658
3659 Remove obsolete '#define static' cruft.
3660 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3661 This #undef was "temporary" in 2000; it is no longer needed
3662 now that '#define static' has gone away.
3663 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3664 (gray_bitmap_bits): Remove; no longer needed.
3665 All uses replaced with definiens.
3666 * xterm.c: Include "bitmaps/gray.xbm".
3667
9e4bf381
PE
36682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 Clean up __executable_start, monstartup when --enable-profiling.
3671 The following changes affect the code only when profiling.
3672 * dispnew.c (__executable_start): Rename from safe_bcopy.
3673 Define only on platforms that need it.
3674 * emacs.c: Include <sys/gmon.h> when profiling.
3675 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3676 (__executable_start): Remove decl, since lisp.h does it now.
3677 (safe_bcopy): Remove decl; no longer has that name.
3678 (main): Coalesce #if into single bit of code, for simplicity.
3679 Cast pointers to uintptr_t, since standard libraries want integers
3680 and not pointers.
3681 * lisp.h (__executable_start): New decl.
3682
32d72c2f
GM
36832012-05-31 Glenn Morris <rgm@gnu.org>
3684
3685 * image.c (Fimagemagick_types): Doc fix.
3686
baac5bc7
JM
36872012-05-30 Jim Meyering <meyering@redhat.com>
3688
3689 * callproc.c (Fcall_process_region): Include directory component
3690 in mkstemp error message (Bug#11586).
3691
72cb32cf
PE
36922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3693
3694 * alloc.c, lisp.h (make_pure_vector): Now static.
3695
61b108cc
SM
36962012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3697
3698 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3699 Move to byte-run.el.
3700 (Fautoload): Do the hash-doc more carefully.
3701 * data.c (Fdefalias): Purify definition, except for keymaps.
3702 (Qdefun): Move from eval.c.
3703 * lisp.h (Qdefun): Remove.
3704 * lread.c (read1): Tiny simplification.
3705
471fe23d
TN
37062012-05-29 Troels Nielsen <bn.troels@gmail.com>
3707
934f3f58 3708 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3709 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3710 Bug#9642, but explicitly check that the buffer the overlay would
3711 be moved to is live and rearrange lines to make sure that errors
3712 will not put the overlay in an inconsistent state.
3713 (Fdelete_overlay): Cosmetics.
3714
85d0efd1
EZ
37152012-05-28 Eli Zaretskii <eliz@gnu.org>
3716
3717 * w32term.c (my_bring_window_to_top): New function.
3718 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3719 could be different from the original one.
3720 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3721 (Bug#11513)
3722
3723 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3724 by calling BringWindowToTop.
3725
3726 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3727 (WM_EMACS_END): Increase by one.
3728
da92a98c
PE
37292012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3730
3731 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3732 This avoids undefined behavior that might cause the eassert
3733 to not catch an out-of-range value.
3734
74d1f848
JB
37352012-05-28 Juanma Barranquero <lekktu@gmail.com>
3736
3737 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3738 Update dependencies.
3739
9e1a06fc
EZ
37402012-05-27 Eli Zaretskii <eliz@gnu.org>
3741
3742 * bidi.c (bidi_mirror_char): Fix last change.
3743
f3dd7312
AS
37442012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3745
3746 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3747 when referring to sectname field in printf format.
3748
81899c91
PE
37492012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3750
57b81a9f
PE
3751 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3752 Only r_alloc_inhibit_buffer_relocation needed to be added;
3753 the others were already declared.
3754
81899c91
PE
3755 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3756 before checking whether it's out of range. Put the check inside
3757 eassert. See
3758 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3759
33017faf 37602012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3761
3762 * callproc.c (Fcall_process): Restore a line that was accidentally
3763 commented out in the 2011-02-13 change (bug#11547).
3764
33017faf 37652012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3766
3767 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3768 defined on ralloc.c.
3769
3770 * buffer.c [REL_ALLOC]: Remove prototypes of
3771 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3772 they are now on lisp.h.
3773
3774 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3775
3776 * search.c (search_buffer): Use it to inhibit relocation of buffer
3777 text while re_search_2 is doing its job, because re_search_2 is
3778 passed C pointers to buffer text. (Bug#11519)
3779
23415acf
EZ
3780 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3781 Update value to 24.
3782
44e27368
EZ
3783 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3784 state after an additional call to move_it_in_display_line_to, keep
3785 the values of it->max_ascent and it->max_descent found for the
3786 entire line.
3787 (pos_visible_p): Revert the comparison against bottom_y to what it
3788 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3789 (Bug#11464)
3790
c1892f11
PE
37912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 Fix coding-related core dumps with gcc -ftrapv.
3794 The code was computing A - B, where A and B are pointers, and B is
3795 random garbage. This can lead to core dumps on platforms that
3796 have special pointer registers, and it also leads to core dumps on
3797 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3798 A - B only when B is initialized properly.
3799 * coding.c (coding_set_source, coding_set_destination): Return void.
3800 (coding_change_source, coding_change_destinations): New functions,
3801 with the old behaviors of coding_set_source and coding_set_destination.
3802 All callers that need an offset changed to use these new functions.
3803
eb7afdad
GM
38042012-05-26 Glenn Morris <rgm@gnu.org>
3805
3806 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3807
f12fdf02
EZ
38082012-05-26 Eli Zaretskii <eliz@gnu.org>
3809
53a63be6 3810 Extend mouse support on W32 text-mode console.
61b108cc
SM
3811 * xdisp.c (draw_row_with_mouse_face):
3812 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3813
eb3f6f01 3814 * w32console.c: Include window.h.
61b108cc
SM
3815 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3816 New functions.
eb3f6f01
EZ
3817 (initialize_w32_display): Initialize mouse-highlight data.
3818
53a63be6
EZ
3819 * w32inevt.c: Include termchar.h and window.h.
3820 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3821 moves, call note_mouse_highlight. If help_echo changed, call
3822 gen_help_event to produce help-echo message in the echo area.
3823 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3824 highlight info.
3825
4cfd81f6
PE
38262012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * lread.c (read1): Simplify slightly to avoid an overflow warning
3829 with GCC 4.7.0 on x86-64.
3830
4446092a
EZ
38312012-05-26 Eli Zaretskii <eliz@gnu.org>
3832
3833 * bidi.c (bidi_mirror_char): Revert last change: an int is
3834 definitely wide enough here.
3835
42b2a986 38362012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3837
42b2a986 3838 Fix integer width and related bugs (Bug#9874).
eb106a49 3839 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3840 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3841 (string_bytes, check_sblock, allocate_string_data):
3842 (compact_small_strings, Fmake_bool_vector, make_string)
3843 (make_unibyte_string, make_multibyte_string)
3844 (make_string_from_bytes, make_specified_string)
3845 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3846 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3847 (mark_vectorlike):
3848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3849 (allocate_pseudovector):
3850 Use int, not EMACS_INT, where int is wide enough.
3851 (inhibit_garbage_collection, Fgarbage_collect):
3852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3853 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3854 int might not be wide enough.
3855 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3856 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3857 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3858 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3859 (bidi_level_of_next_char, bidi_move_to_visually_next):
3860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3861 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3862 (Fkill_buffer, Fset_buffer_major_mode)
3863 (advance_to_char_boundary, Fbuffer_swap_text)
3864 (Fset_buffer_multibyte, overlays_at, overlays_in)
3865 (overlay_touches_p, struct sortvec, record_overlay_string)
3866 (overlay_strings, recenter_overlay_lists)
3867 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3868 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3869 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3870 (Foverlay_recenter, last_overlay_modification_hooks_used)
3871 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3873 (validate_region): Omit unnecessary test for b <= e,
3874 since that's guaranteed by the previous test.
d311d28c
PE
3875 (adjust_overlays_for_delete): Avoid pos + length overflow.
3876 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3877 (report_overlay_modification):
3878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3879 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3880 Omit pointer cast, which isn't needed anyway, and doesn't work
3881 after the EMACS_INT -> ptrdiff_t change.
02481186 3882 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3883 * buffer.h: Adjust decls to match defn changes elsewhere.
3884 (struct buffer_text, struct buffer):
3885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3886 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3887 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3888 not int, to avoid needless 32-bit limit on 64-bit hosts.
3889 (exec_byte_code): Use tighter memory-full test, one that checks
3890 for alloca overflow. Don't compute the address of the object just
3891 before an array, as that's not portable. Use EMACS_INT, not
3892 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3893 * callint.c (Fcall_interactively):
3894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3895 * callproc.c (call_process_kill, Fcall_process):
3896 Don't assume pid_t fits into an Emacs fixnum.
3897 (call_process_cleanup, Fcall_process, child_setup):
3898 Don't assume pid_t fits into int.
3899 (call_process_cleanup, Fcall_process, delete_temp_file)
3900 (Fcall_process_region):
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 (Fcall_process): Simplify handling of volatile integers.
3903 Use int, not EMACS_INT, where int will do.
3904 * casefiddle.c (casify_object, casify_region, operate_on_word)
3905 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3907 (casify_object): Avoid integer overflow when overallocating buffer.
3908 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3909 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3910 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3911 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3912 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3913 integers are now checked earlier. All uses replaced with XINT.
3914 (ccl_driver):
3915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3916 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3917 (ccl_driver, Fregister_code_conversion_map):
3918 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3919 (resolve_symbol_ccl_program): Check that vector header is in range.
3920 Always copy the vector, so that we can check its contents reliably
3921 now rather than having to recheck each instruction as it's being
3922 executed. Check that vector words fit in 'int'.
3923 (ccl_get_compiled_code, Fregister_ccl_program)
3924 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3925 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3926 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3927 contents are in range.
3928 (Fccl_execute_on_string): Check that status is in range.
3929 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3930 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3931 Accept and return EMACS_INT, not int, because callers can pass values
3932 out of 'int' range.
3933 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3934 (multibyte_chars_in_text, parse_str_as_multibyte)
3935 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3936 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3937 (string_escape_byte8, Fget_byte):
3938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3939 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3940 avoid mishandling large integers.
3941 * character.h: Adjust decls to match defn changes elsewhere.
3942 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3943 (Ffind_charset_region):
3944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3945 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3946 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3947 Don't assume fixnum fits in int.
d311d28c
PE
3948 (load_charset_map_from_vector, Fmap_charset_chars):
3949 Remove now-unnecessary CHECK_NATNUMs.
3950 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3951 Don't rely on undefined behavior with signed left shift overflow.
3952 Don't assume unsigned int fits into fixnum, or that fixnum fits
3953 into unsigned int. Don't require max_code to be a valid fixnum;
3954 that's not true for gb10830 4-byte on a 32-bit host. Allow
3955 invalid_code to be a cons, for the same reason. Require code_offset
3956 to be a character. Avoid int overflow if max_char is close
3957 to INT_MAX.
3958 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3959 this is intended anyway and avoids some undefined behavior.
3960 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3961 INDEX_TO_CODE_POINT, as that's what it expects.
3962 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3963 * charset.h (DECODE_CHAR): Return int, not unsigned;
3964 this is what was intended anyway, and it avoids undefined behavior.
3965 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3966 integer-overflow issues.
3967 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3968 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3969 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3970 * chartab.c (Fmake_char_table, Fset_char_table_range)
3971 (uniprop_get_decoder, uniprop_get_encoder):
3972 Don't assume fixnum fits in int.
3973 * cmds.c (move_point): New function, that does the gist of
3974 Fforward_char and Fbackward_char, but does so while checking
3975 for integer overflow more accurately.
c96e5d6a 3976 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3977 (Fforward_line, Fend_of_line, internal_self_insert)
3978 (internal_self_insert):
3979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3980 Fix a FIXME, by checking for integer overflow when calculating
3981 target_clm and actual_clm.
3982 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3983 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3984 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3985 (coding_alloc_by_making_gap, alloc_destination)
3986 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3987 (encode_coding_utf_16, detect_coding_emacs_mule)
3988 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3989 (detect_coding_iso_2022, decode_coding_iso_2022)
3990 (encode_invocation_designation, encode_designation_at_bol)
3991 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3992 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3993 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3994 (encode_coding_ccl, encode_coding_raw_text)
3995 (detect_coding_charset, decode_coding_charset)
3996 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3997 (produce_composition, produce_charset, produce_annotation)
3998 (decode_coding, handle_composition_annotation)
3999 (handle_charset_annotation, consume_chars, decode_coding_gap)
4000 (decode_coding_object, encode_coding_object, detect_coding_system)
4001 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4002 (code_convert_region, code_convert_string)
8f50130c
PE
4003 (Fdefine_coding_system_internal)
4004 (coding_set_source, coding_set_destination):
d311d28c
PE
4005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4006 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4007 (Fdefine_coding_system_internal):
4008 Don't assume fixnums fit in int.
4009 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4010 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4011 (Funencodable_char_position, Fcheck_coding_systems_region)
4012 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4014 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4015 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4016 Don't access memory outside of the args array.
d311d28c 4017 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4018 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4019 result of ENCODE_CHAR.
d311d28c
PE
4020 * coding.h: Adjust decls to match defn changes elsewhere.
4021 (struct coding_system):
4022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4023 * composite.c (get_composition_id, find_composition)
4024 (run_composition_function, update_compositions)
4025 (compose_text, composition_gstring_put_cache)
4026 (composition_gstring_p, composition_gstring_width)
4027 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4028 (composition_compute_stop_pos, composition_reseat_it)
4029 (composition_update_it, struct position_record)
4030 (find_automatic_composition, composition_adjust_point)
4031 (Fcomposition_get_gstring, Ffind_composition_internal):
4032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4033 (update_compositions):
4034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4035 * composite.h: Adjust decls to match defn changes elsewhere.
4036 (struct composition):
4037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4038 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4039 Do not attempt to compute the address of the object just before a
4040 buffer; this is not portable.
4041 (Faref, Faset):
4042 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4043 (Faset): Use int, not EMACS_INT, where int is wide enough.
4044 (Fstring_to_number): Don't assume fixnums fit in int.
4045 (Frem): Don't assume arg is nonnegative.
4046 * dbusbind.c (xd_append_arg): Check for integers out of range.
4047 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4048 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4049 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4050 (xd_get_connection_references): Return ptrdiff_t, not int.
4051 All uses changed.
4052 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4053 (xd_read_message_1):
4054 Use int, not unsigned, where the dbus API uses int.
4055 (Fdbus_message_internal): Don't overflow mtype.
4056 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4057 * dired.c (directory_files_internal, file_name_completion, scmp)
4058 (file_name_completion_stat):
4059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4060 (file_name_completion): Don't overflow matchcount.
4061 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4062 * dispextern.h: Adjust decls to match defn changes elsewhere.
4063 (struct text_pos, struct glyph, struct bidi_saved_info)
4064 (struct bidi_string_data, struct bidi_it, struct composition_it)
4065 (struct it):
4066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4067 (struct display_pos, struct composition_it, struct it):
4068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4069 * dispnew.c (increment_matrix_positions)
4070 (increment_row_positions, mode_line_string)
4071 (marginal_area_string):
4072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4073 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4075 (duration_to_sec_usec): New function, to check for overflow better.
4076 (Fsleep_for, sit_for): Use it.
4077 * doc.c (get_doc_string, store_function_docstring):
4078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4079 (get_doc_string, Fsnarf_documentation):
4080 Use int, not EMACS_INT, where int is wide enough.
4081 (get_doc_string):
4082 Use SAFE_ALLOCA, not alloca.
4083 Check for overflow when converting EMACS_INT to off_t.
4084 * doprnt.c (doprnt):
4085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4086 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4087 Don't assume uid_t fits into fixnum.
4088 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4089 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4090 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4091 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4092 (general_insert_function)
4093 (Finsert_char, make_buffer_string, make_buffer_string_both)
4094 (update_buffer_properties, Fbuffer_substring)
4095 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4096 (Fsubst_char_in_region, check_translation)
4097 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4098 (transpose_markers, Ftranspose_regions):
4099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4100 (clip_to_bounds): Move to lisp.h as an inline function).
4101 (Fconstrain_to_field): Don't assume integers are nonnegative.
4102 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4103 (Fsubst_char_in_region, Fsave_restriction):
4104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4105 (Femacs_pid): Don't assume pid_t fits into fixnum.
4106 (lo_time): Use int, not EMACS_INT, when int suffices.
4107 (lisp_time_argument): Check for usec out of range.
4108 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4109 (Fuser_login_name, Fuser_full_name): Signal an error
4110 if a uid argument is out of range, rather than relying on
4111 undefined behavior.
c8d5c857
PE
4112 (Fformat_time_string): Remove now-unnecessary check.
4113 lisp_time_argument checks for out-of-range usec now.
243e0530 4114 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4115 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4116 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4117 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4118 (init_cmdargs, Fdump_emacs):
4119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4120 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4121 the bottom (typically) 32 bits of the fixnum.
4122 * eval.c (specpdl_size, call_debugger):
4123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4124 (when_entered_debugger, Fbacktrace_debug):
4125 Don't assume fixnum can fit in int.
4126 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4127 the object just before a buffer; this is not portable.
4128 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4129 (grow_specpdl, unbind_to):
4130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4131 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4132 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4133 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4134 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4135 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4137 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4138 (a_write, e_write):
4139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4140 (Fcopy_file, non_regular_nbytes, read_non_regular)
4141 (Finsert_file_contents):
4142 Use int, not EMACS_INT, where int is wide enough.
4143 (READ_BUF_SIZE): Verify that it fits in int.
4144 (Finsert_file_contents): Check that counts are in proper range,
4145 rather than assuming fixnums fit into ptrdiff_t etc.
4146 Don't assume fixnums fit into int.
125b3835 4147 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4148 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4149 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4150 (string_char_to_byte, string_byte_to_char)
4151 (string_make_multibyte, string_to_multibyte)
4152 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4153 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4154 (substring_both, Fdelete, internal_equal, Ffillarray)
4155 (Fclear_string, mapcar1)
4156 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4157 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4158 (larger_vector, make_hash_table, maybe_resize_hash_table)
4159 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4160 (Fmaphash, secure_hash):
4161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4162 (concat): Check for string index and length overflow.
4163 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4164 (Frequire):
4165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4166 (larger_vector): New API (vec, incr_min, size_max) replaces old
4167 one (vec, new_size, init). This catches size overflow.
4168 INIT was removed because it was always Qnil.
4169 All callers changed.
4170 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4171 the upper bound on a hash table index size.
4172 (make_hash_table, maybe_resize_hash_table): Use it.
4173 (secure_hash): Computer start_byte and end_byte only after
4174 they're known to be in ptrdiff_t range.
4175 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4176 (Ffont_get_glyphs, Ffont_at):
4177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4178 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4179 (Flist_fonts, Fopen_font):
4180 Don't assume fixnum can fit in int.
4181 (check_gstring): Don't assume index can fit in int.
4182 (font_match_p): Check that fixnum is a character, not a nonnegative
4183 fixnum, since the later code needs to stuff it into an int.
4184 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4185 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4186 conversion overflow issues.
4187 (Fopen_font): Check for integer out of range.
4188 (Ffont_get_glyphs): Don't assume index can fit in int.
4189 * font.h: Adjust decls to match defn changes elsewhere.
4190 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4191 integer overflow.
4192 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4193 printmax_t, where ptrdiff_t is wide enough.
4194 (Finternal_char_font):
4195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4196 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4197 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4198 (Fset_frame_position, x_set_frame_parameters)
4199 (x_set_line_spacing, x_set_border_width)
4200 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4201 Check that fixnums are in proper range for system types.
4202 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4204 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4205 Use SAFE_ALLOCA_LISP, not alloca.
4206 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4207 intptr_t is wide enough.
4208 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4209 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4210 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4211 Check for fixnum out of range.
4212 * ftfont.c (ftfont_list): Don't assume index fits in int.
4213 Check that fixnums are in proper range for system types.
4214 (ftfont_shape_by_flt):
4215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4216 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4218 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4219 Check that fixnums are in proper range for system types.
4220 * gnutls.h: Adjust decls to match defn changes elsewhere.
4221 * gtkutil.c (xg_dialog_run):
4222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4223 (update_frame_tool_bar):
4224 Check that fixnums are in proper range for system types.
4225 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4226 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4227 * indent.c (last_known_column, last_known_column_point):
4228 (current_column_bol_cache):
4229 (skip_invisible, current_column, check_display_width):
4230 (check_display_width, scan_for_column, current_column_1)
4231 (Findent_to, Fcurrent_indentation, position_indentation)
4232 (indented_beyond_p, Fmove_to_column, compute_motion):
4233 (Fcompute_motion, Fvertical_motion):
4234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4235 (last_known_column_modified): Use EMACS_INT, not int.
4236 (check_display_width):
4237 (Fcompute_motion):
4238 Check that fixnums and floats are in proper range for system types.
4239 (compute_motion): Don't assume index or fixnum fits in int.
4240 (compute_motion, Fcompute_motion):
4241 Use int, not EMACS_INT, when it is wide enough.
4242 (vmotion): Omit local var start_hpos that is always 0; that way
4243 we don't need to worry about overflow in expressions involving it.
4244 * indent.h: Adjust decls to match defn changes elsewhere.
4245 (struct position):
4246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4247 Use int, not EMACS_INT, where int is wide enough.
4248 Remove unused members ovstring_chars_done and tab_offset;
4249 all uses removed.
4250 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4251 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4252 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4253 (make_gap, copy_text, insert, insert_and_inherit)
4254 (insert_before_markers, insert_before_markers_and_inherit)
4255 (insert_1, count_combining_before, count_combining_after)
4256 (insert_1_both, insert_from_string)
4257 (insert_from_string_before_markers, insert_from_string_1)
4258 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4259 (adjust_after_replace, adjust_after_insert, replace_range)
4260 (replace_range_2, del_range, del_range_1, del_range_byte)
4261 (del_range_both, del_range_2, modify_region)
4262 (prepare_to_modify_buffer, signal_before_change)
4263 (signal_after_change, Fcombine_after_change_execute):
4264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4265 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4266 (balance_an_interval, split_interval_right, split_interval_left)
4267 (find_interval, next_interval, update_interval)
4268 (adjust_intervals_for_insertion, delete_node, delete_interval)
4269 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4270 (static_offset_intervals, offset_intervals)
4271 (merge_interval_right, merge_interval_left, make_new_interval)
4272 (graft_intervals_into_buffer, temp_set_point_both)
4273 (temp_set_point, set_point, adjust_for_invis_intang)
4274 (set_point_both, move_if_not_intangible, get_property_and_range)
4275 (get_local_map, copy_intervals, copy_intervals_to_string)
4276 (compare_string_intervals, set_intervals_multibyte_1):
4277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4278 * intervals.h: Adjust decls to match defn changes elsewhere.
4279 (struct interval):
4280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4281 * keyboard.c (this_command_key_count, this_single_command_key_start)
4282 (before_command_key_count, before_command_echo_length, echo_now)
4283 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4284 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4285 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4286 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4288 (last_non_minibuf_size, last_point_position, echo_truncate)
4289 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4290 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4291 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4292 (stuff_buffered_input):
4293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4294 (last_auto_save, command_loop_1, read_char):
4295 Use EMACS_INT, not int, to avoid integer overflow.
4296 (record_char): Avoid overflow in total_keys computation.
4297 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4298 * keyboard.h: Adjust decls to match defn changes elsewhere.
4299 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4300 (Fkey_description, Fdescribe_vector, Flookup_key):
4301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4302 (click_position): New function, to check that positions are in range.
4303 (Fcurrent_active_maps):
4304 (describe_command):
4305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4306 (Faccessible_keymaps, Fkey_description):
4307 (preferred_sequence_p):
4308 Don't assume fixnum can fit into int.
4309 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4310 Check for integer overflow in size calculations.
4311 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4312 avoid mishandling large integers.
4313 * lisp.h: Adjust decls to match defn changes elsewhere.
4314 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4315 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4316 (struct Lisp_Marker):
4317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4318 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4319 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4320 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4321 All callers changed.
4322 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4323 Assume the arg has valid form, since it always does.
4324 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4325 unsigned integer system type.
4326 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4327 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4329 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4330 (duration_to_sec_usec): New decl.
4331 * lread.c (read_from_string_index, read_from_string_index_byte)
4332 (read_from_string_limit, readchar, unreadchar, openp)
4333 (read_internal_start, read1, oblookup):
4334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4335 (Fload, readevalloop, Feval_buffer, Feval_region):
4336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4337 (openp): Check for out-of-range argument to 'access'.
4338 (read1): Use int, not EMACS_INT, where int is wide enough.
4339 Don't assume fixnum fits into int.
6efdadfd 4340 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4341 (read_filtered_event): Use duration_to_sec_usec
4342 to do proper overflow checking on durations.
d311d28c
PE
4343 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4344 in size calculation.
4345 (Fexecute_kbd_macro):
4346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4347 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4348 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4349 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4350 (set_marker_both, set_marker_restricted_both, marker_position)
4351 (marker_byte_position, Fbuffer_has_markers_at):
4352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4353 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4354 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4355 It now merely ensures that the menu is large enough, without
4356 necessarily growing it, as this avoids some integer overflow issues.
4357 All callers changed.
4358 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4360 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4361 Use SAFE_ALLOCA_LISP, not alloca.
4362 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4363 to EMACS_INT. Check that fixnums are in proper range for system types.
4364 * minibuf.c (minibuf_prompt_width, string_to_object)
4365 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4366 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4368 (get_minibuffer, read_minibuf_unwind):
4369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4370 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4371 this simplifies overflow checking. All callers changed.
4372 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4373 (Ftest_completion):
4374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4375 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4376 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4377 Check that fixnums are in proper range for system types.
4378 (Fx_create_frame, Fx_show_tip):
4379 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4380 * nsfont.m (ns_findfonts, nsfont_list_family):
4381 Don't assume fixnum fits in long.
4382 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4384 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4385 wide enough.
17fdb222 4386 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4388 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4389 (PRINTDECLARE, PRINTPREPARE):
4390 (strout, print_string):
4391 (print, print_preprocess, print_check_string_charset_prop)
4392 (print_object):
4393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4394 (PRINTDECLARE):
4395 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4397 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4398 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4399 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4400 (print_error_message): Use SAFE_ALLOCA, not alloca.
4401 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4402 (print_depth, new_backquote_output, print_number_index):
4403 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4404 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4405 (Fset_process_window_size, Fformat_network_address)
4406 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4407 (sigchld_handler):
d311d28c 4408 Check that fixnums are in proper range for system types.
d44287d4 4409 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4410 Check for process-ids out of pid_t range rather than relying on
4411 undefined behavior.
e4d81efc 4412 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4413 (Fformat_network_address, read_process_output, send_process)
4414 (Fprocess_send_region, status_notify):
4415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4416 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4417 (wait_reading_process_output, read_process_output, exec_sentinel):
4418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4419 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4420 (Faccept_process_output): Use duration_to_sec_usec to do proper
4421 overflow checking on durations.
dde14581
PE
4422 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4423 Don't assume pid_t fits in int.
02481186
PE
4424 * process.h (struct Lisp_Process): Members tick and update_tick
4425 are now of type EMACS_INT, not int.
b62b53e8
PE
4426 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4427 configured --with-wide-int.
d311d28c
PE
4428 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4429 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4430 * search.c (looking_at_1, string_match_1):
4431 (fast_string_match, fast_c_string_match_ignore_case)
4432 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4433 (scan_newline, find_before_next_newline, search_command)
4434 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4435 (set_search_regs, wordify):
4436 (Freplace_match):
4437 (Fmatch_data):
4438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4439 (string_match_1, search_buffer, set_search_regs):
4440 (Fmatch_data):
4441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4442 (wordify): Check for overflow in size calculation.
4443 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4444 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4445 Check that fixnums are in proper range for system types.
4446 * sound.c (struct sound_device)
4447 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4449 (Fplay_sound_internal):
4450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4451 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4452 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4453 (Fparse_partial_sexp):
4454 Don't assume fixnums can fit in int.
4455 (struct lisp_parse_state, find_start_pos, find_start_value)
4456 (find_start_value_byte, find_start_begv)
4457 (update_syntax_table, char_quoted, dec_bytepos)
4458 (find_defun_start, prev_char_comend_first, back_comment):
4459 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4460 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4462 (Finternal_describe_syntax_value): Check that match_lisp is a
4463 character, not an integer, since the code stuffs it into int.
4464 (scan_words, scan_sexps_forward):
4465 Check that fixnums are in proper range for system types.
4466 (Fforward_word):
4467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4468 (scan_sexps_forward):
4469 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4470 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4471 * syntax.h: Adjust decls to match defn changes elsewhere.
4472 (struct gl_state_s):
4473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4474 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4475 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4476 * sysdep.c (wait_for_termination_1, wait_for_termination)
4477 (interruptible_wait_for_termination, mkdir):
4478 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4479 (emacs_read, emacs_write):
4480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4481 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4482 and double all fit in int.
d311d28c
PE
4483 * term.c (set_tty_color_mode):
4484 Check that fixnums are in proper range for system types.
4485 * termhooks.h (struct input_event):
4486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4487 * textprop.c (validate_interval_range, interval_of)
4488 (Fadd_text_properties, set_text_properties_1)
4489 (Fremove_text_properties, Fremove_list_of_text_properties)
4490 (Ftext_property_any, Ftext_property_not_all)
4491 (copy_text_properties, text_property_list, extend_property_ranges)
4492 (verify_interval_modification):
4493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4494 (Fnext_single_char_property_change)
4495 (Fprevious_single_char_property_change):
4496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4497 (copy_text_properties):
4498 Check for integer overflow in index calculation.
d311d28c
PE
4499 * undo.c (last_boundary_position, record_point, record_insert)
4500 (record_delete, record_marker_adjustment, record_change)
4501 (record_property_change):
4502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4503 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4505 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4506 (Fx_hide_tip, Fx_file_dialog):
4507 * w32menu.c (set_frame_menubar):
4508 Use ptrdiff_t, not int, for consistency with rest of code.
4509 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4510 (select_window, Fdelete_other_windows_internal)
4511 (window_scroll_pixel_based, window_scroll_line_based)
4512 (Frecenter, Fset_window_configuration):
4513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4514 (Fset_window_hscroll, run_window_configuration_change_hook)
4515 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4516 (Fscroll_other_window, Frecenter):
d311d28c
PE
4517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4518 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4519 Don't assume fixnum fits in int.
4520 (Fset_window_scroll_bars):
4521 Check that fixnums are in proper range for system types.
4522 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4523 (string_pos, c_string_pos, number_of_chars, init_iterator)
4524 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4525 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4526 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4527 (face_before_or_after_it_pos, handle_invisible_prop)
4528 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4529 (display_prop_intangible_p, string_buffer_position_lim)
4530 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4531 (get_overlay_strings_1, get_overlay_strings)
4532 (iterate_out_of_display_property, forward_to_next_line_start)
4533 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4534 (get_next_display_element, set_iterator_to_next)
4535 (get_visually_first_element, compute_stop_pos_backwards)
4536 (handle_stop_backwards, next_element_from_buffer)
4537 (move_it_in_display_line_to, move_it_in_display_line)
4538 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4539 (add_to_log, message_dolog, message_log_check_duplicate)
4540 (message2, message2_nolog, message3, message3_nolog
4541 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4542 (current_message_1, truncate_echo_area, truncate_message_1)
4543 (set_message, set_message_1, store_mode_line_noprop)
4544 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4545 (text_outside_line_unchanged_p, check_point_in_composition)
4546 (reconsider_clip_changes)
4547 (redisplay_internal, set_cursor_from_row, try_scrolling)
4548 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4549 (redisplay_window, find_last_unchanged_at_beg_row)
4550 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4551 (trailing_whitespace_p, find_row_edges, display_line)
4552 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4553 (display_mode_element, store_mode_line_string)
4554 (pint2str, pint2hrstr, decode_mode_spec)
4555 (display_count_lines, display_string, draw_glyphs)
4556 (x_produce_glyphs, x_insert_glyphs)
4557 (rows_from_pos_range, mouse_face_from_buffer_pos)
4558 (fast_find_string_pos, mouse_face_from_string_pos)
4559 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4561 (safe_call, init_from_display_pos, handle_fontified_prop)
4562 (handle_single_display_spec, load_overlay_strings)
4563 (with_echo_area_buffer, setup_echo_area_for_printing)
4564 (display_echo_area, echo_area_display)
4565 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4566 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4567 (redisplay_window, dump_glyph_row, display_mode_line)
4568 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4569 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4571 (handle_single_display_spec, build_desired_tool_bar_string)
4572 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4573 (get_specified_cursor_type):
4574 Check that fixnums are in proper range for system types.
4575 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4576 (Flookup_image_map):
4577 Don't assume fixnums fit in int.
4578 (compare_overlay_entries):
4579 Avoid mishandling comparisons due to subtraction overflow.
4580 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4581 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4582 (handle_tool_bar_click):
4583 Use int, not unsigned, since we prefer signed and the signedness
4584 doesn't matter here.
4585 (get_next_display_element, next_element_from_display_vector):
4586 Use int, not EMACS_INT, when int is wide enough.
4587 (start_hourglass): Use duration_to_sec_usec to do proper
4588 overflow checking on durations.
4589 * xfaces.c (Fbitmap_spec_p):
4590 Check that fixnums are in proper range for system types.
4591 (compare_fonts_by_sort_order):
4592 Avoid mishandling comparisons due to subtraction overflow.
4593 (Fx_family_fonts, realize_basic_faces):
4594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4595 (Fx_family_fonts):
4596 Don't assume fixnum fits in int.
4597 Use SAFE_ALLOCA_LISP, not alloca.
4598 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4599 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4600 (face_at_buffer_position, face_for_overlay_string)
4601 (face_at_string_position):
4602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4603 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4604 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4605 (Fx_show_tip):
4606 Check that fixnums are in proper range for system types.
4607 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4608 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4610 (Fx_change_window_property): Don't assume fixnums fit in int.
4611 * xfont.c (xfont_chars_supported):
4612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4614 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4616 * xml.c (parse_region):
4617 * xrdb.c (magic_file_p):
4618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4619 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4620 (x_get_local_selection, x_reply_selection_request)
4621 (x_handle_selection_request, wait_for_property_change):
4622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4623 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4624 short is wide enough.
4625 (x_send_client_event): Don't assume fixnum fits in int.
4626 * xterm.c (x_x_to_emacs_modifiers):
4627 Don't assume EMACS_INT overflows nicely into int.
4628 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4629 may come from Lisp.
4630 (handle_one_xevent): NATNUMP can eval its arg twice.
4631 (x_connection_closed):
4632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4633 * xterm.h: Adjust decls to match defn changes elsewhere.
4634 (struct scroll_bar): Use struct vectorlike_header
4635 rather than rolling our own approximation.
4636 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4637
c6574eb5
GM
46382012-05-25 Glenn Morris <rgm@gnu.org>
4639
4640 * lisp.mk (lisp): Update for more files being compiled now.
4641
e8d32c7e
SM
46422012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4643
48def666
SM
4644 * lread.c: Remove `read_pure' which makes no difference.
4645 (read_pure): Remove var.
4646 (unreadpure): Remove function.
4647 (readevalloop): Don't call read_list with -1 flag.
4648 (read1, read_vector): Don't test read_pure any more.
4649 (read_list): Simplify.
4650
e8d32c7e
SM
4651 * fileio.c, character.h: Minor style tweaks.
4652
4b2addb7
DA
46532012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4654
4655 * window.h (clip_changed): Remove useless declaration.
4656
584461b2
JB
46572012-05-22 Juanma Barranquero <lekktu@gmail.com>
4658
4659 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4660 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4661
34374650
PE
46622012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4663
4664 Remove src/m/*.
4665 This directory predates autoconf and is no longer needed nowadays.
4666 Move its few remaining bits of functionality to where they're needed.
4667 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4668 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4669 * m/template.h: Remove.
4670 * Makefile.in (M_FILE): Remove. All uses removed.
4671 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4672 * lisp.h (USE_LSB_TAG):
4673 * mem-limits.h (EXCEEDS_LISP_PTR):
4674 Use VAL_MAX, not VALBITS, in #if.
4675 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4676 (EMACS_UINT): Define unconditionally now.
4677 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4678 (BITS_PER_EMACS_INT): New constants, replacing
4679 what used to be in config.h, but not useful in #if.
4680 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4681 define them any more.
4682 (VAL_MAX): New macro.
4683 (VALMASK): Use it.
4684 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4685 BITS_PER_EMACS_INT, in #if.
4686 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4687 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4688 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4689 * s/ms-w32.h (DATA_START):
4690 Move here from removed file m/intel386.h.
4691 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4692 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4693
261cb4bb
PE
46942012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 Assume C89 or later.
4697 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4698 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4699 (xrealloc):
4700 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4701 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4702 * textprop.c, tparam.c (NULL): Remove.
4703 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4704 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4705 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4706 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4707 * xterm.c (input_signal_count): Assume volatile works.
4708
ff23cd9f
KB
47092012-05-21 Ken Brown <kbrown@cornell.edu>
4710
4711 * xgselect.c (xg_select): Fix first argument in call to 'select'
4712 (bug#11508).
4713
1b170bc6
KB
47142012-05-20 Ken Brown <kbrown@cornell.edu>
4715
4716 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4717 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4718
b2f4d39f
KB
47192012-05-19 Ken Brown <kbrown@cornell.edu>
4720
4721 * xfns.c (x_in_use): Remove `static' qualifier.
4722 * xterm.h (x_in_use): Declare.
4723 * xgselect.c: Include xterm.h.
4724 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4725 and `display_arg' (bug#9754).
4726
003fdae2
PE
47272012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4728
9232a6d9
PE
4729 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4730
003fdae2
PE
4731 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4732 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4733
784b56e2
EZ
47342012-05-18 Eli Zaretskii <eliz@gnu.org>
4735
4736 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4737
4738 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4739 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4740
4741 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4742 reference to image_cache->refcount.
4743 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4744
a0a79cde
JL
47452012-05-17 Juri Linkov <juri@jurta.org>
4746
4747 * search.c (Fword_search_regexp, Fword_search_backward)
4748 (Fword_search_forward, Fword_search_backward_lax)
4749 (Fword_search_forward_lax): Move functions to isearch.el
4750 (bug#10145, bug#11381).
4751
b0572523
PE
47522012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4755
9660f5fc
SM
47562012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4757
4758 * lread.c (init_obarray): Declare Qt and Qnil as special.
4759
4374de83
GM
47602012-05-14 Glenn Morris <rgm@gnu.org>
4761
4762 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4763 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4764
dc44c39a
PE
47652012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4766
078c97cb
PE
4767 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4768
dc44c39a
PE
4769 * unexaix.c: Port to more-recent AIX compilers.
4770 (report_error, report_error_1, make_hdr, copy_sym)
4771 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4772 Make arguments const char *, not char *, to avoid violations of C
4773 standard and to fix some AIX warnings reported by Gilles Pion.
4774
e18afed7 47752012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4776
4777 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4778 already have overlays loaded.
4779 (handle_single_display_spec): Before returning without displaying
4780 fringe bitmap, synchronize the bidi iterator with the main display
4781 iterator, by calling iterate_out_of_display_property.
4782 (iterate_out_of_display_property): Detect buffer iteration by
4783 testing that it->string is a Lisp string.
4784 (get_next_display_element): When the current object is exhausted,
4785 and there's something on it->stack, call set_iterator_to_next to
4786 proceed with what's on the stack, instead of returning zero.
4787 (set_iterator_to_next): If called at the end of a Lisp string,
4788 proceed to consider_string_end without incrementing string
4789 position. Don't increment display vector index past the end of
4790 the display vector. (Bug#11417)
c8fb9dc6
EZ
4791 (pos_visible_p): Don't report a position visible when move_it_to
4792 stopped at the last line of window, which happens to be scanned
4793 backwards by the bidi iteration. (Bug#11464)
ac268e67 4794
e18afed7 47952012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4796
4797 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4798 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4799 are on a TTY, and thus unable to display on the fringes.
4800 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4801 so we need to signal to the caller that this is a "replacing"
4802 display spec. This fixes display when the spec is invalid or we
4803 are on a TTY.
4804
e18afed7 48052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4806
4807 * unexaix.c (make_hdr): Fix typo in prototype.
4808 This bug broke the build on AIX. Problem reported by Gilles Pion.
4809
9d0a235a
MA
48102012-05-14 Michael Albinus <michael.albinus@gmx.de>
4811
4812 * keyboard.c (kbd_buffer_get_event): Read special events also in
4813 batch mode. (Bug#11415)
4814
9e6b06ed
GM
48152012-05-12 Glenn Morris <rgm@gnu.org>
4816
4817 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4818
c1a1d7a3
EZ
48192012-05-12 Eli Zaretskii <eliz@gnu.org>
4820
4821 * lisp.mk (lisp): Add newcomment.elc.
4822
3fe7cdc8
GM
48232012-05-12 Glenn Morris <rgm@gnu.org>
4824
4825 * Makefile.in (MKDIR_P): New, set by configure.
4826 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4827
53f7d2c0
PE
48282012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4829
4830 Remove unused function hourglass_started.
4831 * dispextern.h (hourglass_started):
4832 * w32fns.c (hourglass_started):
4833 * xdisp.c (hourglass_started): Remove.
4834
75aafb17
JB
48352012-05-10 Juanma Barranquero <lekktu@gmail.com>
4836
4837 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4838 Update dependencies.
4839
12959e8e
PE
48402012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4841
97107e2e
PE
4842 * xgselect.c (xg_select): Put maxfds+1 into a var.
4843 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4844
12959e8e
PE
4845 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4846
836d29b3
DA
48472012-05-10 Dave Abrahams <dave@boostpro.com>
4848
4849 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4850 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4851
5cb67954
MA
48522012-05-09 Michael Albinus <michael.albinus@gmx.de>
4853
4854 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4855 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4856 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4857 Initialize xd_registered_buses.
4858
3478ec45
PE
48592012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4860
b263a6b0
PE
4861 Untag more efficiently if USE_LSB_TAG.
4862 This is based on a proposal by YAMAMOTO Mitsuharu in
4863 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4864 For an admittedly artificial (nth 8000 longlist) benchmark on
4865 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4866 Emacs's overall text size by 1%.
4867 * lisp.h (XUNTAG): New macro.
4868 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4869 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4870 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4871 * eval.c (Fautoload):
4872 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4873 * frame.h (XFRAME): Use XUNTAG.
4874
3478ec45
PE
4875 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4876 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4877 Remove unportable assumptions about print widths of types like
4878 dbus_uint32_t.
4879 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4880 intptr_t when converting between pointer and integer, to avoid GCC
4881 warnings about wrong width.
4882
666b903b 48832012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4884
4885 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4886 stack for each reader_thread, instead of defaulting to 8MB
4887 determined by the linker. This avoids failures in creating
4888 subprocesses on Windows 7, see the discussion in this thread:
4889 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4890
b120cc17
JC
48912012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4892
4893 Fix up display of the *Minibuf-0* buffer in the mini window.
4894 * keyboard.c (read_char): Don't clear the echo area if there's no
4895 message to clear.
4896 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4897 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4898
9a4b36f8
MA
48992012-05-07 Michael Albinus <michael.albinus@gmx.de>
4900
4901 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4902 batch mode.
4903
e5f9458f
CY
49042012-05-06 Chong Yidong <cyd@gnu.org>
4905
4906 * lisp.mk (lisp): Update.
4907
eceeb5fc 49082012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4909
4910 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4911
71873e2b
SM
49122012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4913
4914 * data.c (PUT_ERROR): New macro.
4915 (syms_of_data): Use it. Add new error type `user-error'.
4916 * undo.c (user_error): New function.
4917 (Fprimitive_undo): Use it.
4918 * print.c (print_error_message): Adjust print style for `user-error'.
4919 * keyboard.c (user_error): New function.
4920 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4921
ab0fa4e4
PE
49222012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4923
4924 Do not limit current-time-string to years 1000..9999.
4925 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4926 (Fcurrent_time_string): Support any year that is supported by the
4927 underlying localtime representation. Don't use asctime, as it
4928 has undefined behavior for years outside the range -999..9999.
4929
7ed806a7
PE
49302012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4931
4932 Fix race conditions involving setenv, gmtime, localtime, asctime.
4933 Without this fix, interrupts could mess up code that uses these
4934 nonreentrant functions, since setting TZ invalidates existing
4935 tm_zone or tzname values, and since most of these functions return
4936 pointers to static storage.
4937 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4938 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4939 Grow the critical sections to include not just invoking
4940 localtime/gmtime, but also accessing these functions' results
4941 including their tm_zone values if any, and any related TZ setting.
4942 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4943 so that the struct tm is saved in the critical section.
4944 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4945 motivated by the fact that memory allocation needs to be outside
4946 the critical section.
4947
0c16dfed
DA
49482012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4949
4950 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4951 with RESET_INTERVAL.
4952
4953 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4954 Remove duplicated buffer name initialization.
4955
3f83ace8
JM
49562012-05-02 Jim Meyering <jim@meyering.net>
4957
4958 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4959
c7b8541e
JM
4960 * xfns.c (x_window): Use xstrdup (Bug#11375).
4961
90207a15 49622012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4963
4964 * xdisp.c (pos_visible_p): If already at a newline from the
4965 display string before the 'while' loop, don't walk back the glyphs
4966 from it3.glyph_row. Solves assertion violation when the display
4967 string begins with a newline (egg.el). (Bug#11367)
4968
b593d6a9
AH
49692012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4970
4971 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4972 Move to simple.el.
4973
4737362e
GM
49742012-05-01 Glenn Morris <rgm@gnu.org>
4975
99cf43f9
GM
4976 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4977 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4978 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4979 All were removed before 23.1.
4980
9311dcff
GM
4981 * dispnew.c: Remove HAVE_LIBNCURSES test;
4982 it is always true on relevant platforms.
4983
4d5c6349
GM
4984 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4985 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4986
4737362e
GM
4987 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4988
74dd3a6b
AS
49892012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4990
4991 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4992 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4993 Remove.
4994
13c379ee
PE
49952012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4996
4997 Do not avoid creating empty evaporating overlays (Bug#9642).
4998 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4999 That is, do not delete an evaporating overlay if it becomes
5000 empty after its bounds are adjusted to fit within its buffer.
5001 This fix caused other problems, and I'm reverting it until we get
5002 to the bottom of them.
5003
a8e7d6d7 50042012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5005
5006 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5007
a8e7d6d7 50082012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5009
5010 * xdisp.c (pos_visible_p): If the window start position is beyond
5011 ZV, start the display from buffer beginning. Prevents assertion
5012 violation in init_iterator when the minibuffer window is scrolled
5013 via the scroll bar.
5014
5015 * window.c (window_scroll_pixel_based): Likewise.
5016
a8e7d6d7 50172012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5018
5019 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5020
a8e7d6d7 50212012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5022
5023 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5024 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5025
a8e7d6d7 50262012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5027
b593d6a9
AH
5028 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5029 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5030
1c6900d9
EZ
50312012-04-26 Eli Zaretskii <eliz@gnu.org>
5032
4c3fa1d9
EZ
5033 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5034 display element, check also the underlying string or buffer
5035 character. (Bug#11341)
5036
1c6900d9
EZ
5037 * w32menu.c: Include w32heap.h.
5038 (add_menu_item): If the call to AppendMenuW (via
5039 unicode_append_menu) fails, disable Unicode menus only if we are
5040 running on Windows 9X/Me.
5041
42bf8205
AS
50422012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5043
5044 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5045 (xgetint): Add missing shift for LSB tags.
5046
b1bac16e
MR
50472012-04-24 Martin Rudalics <rudalics@gmx.at>
5048
5049 * keyboard.c (read_char): Don't wipe echo area for select window
5050 events: These might get delayed via `mouse-autoselect-window'
5051 (Bug#11304).
5052
d69621cc
JB
50532012-04-24 Juanma Barranquero <lekktu@gmail.com>
5054
5055 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5056 manipulation of :loaded-from data.
5057
02fd101b
JB
50582012-04-23 Juanma Barranquero <lekktu@gmail.com>
5059
5060 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5061 now a cons (bug#11311).
5062
888bec30
PE
50632012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5064
89a438bd
PE
5065 Do not create empty overlays with the evaporate property (Bug#9642).
5066 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5067 if it becomes empty after its bounds are adjusted to fit within
5068 its buffer. Without this fix, in a nonempty buffer (let ((o
5069 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5070 yields an empty overlay that has the evaporate property, which is
5071 not supposed to happen.
5072
1068fe4d
PE
5073 Fix minor GTK3 problems found by static checking.
5074 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5075 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5076 (struct _EmacsFixedClass, emacs_fixed_get_type):
5077 Move decls here from emacsgtkfixed.h, since they needn't be public.
5078 (emacs_fixed_get_type): Now static.
5079 (emacs_fixed_class_init): Omit unused local.
5080 (emacs_fixed_child_type): Remove; unused.
5081 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5082 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5083 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5084 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5085 (EMACS_FIXED_GET_CLASS): Remove; unused.
5086 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5087
888bec30
PE
5088 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5089 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5090
de85e130
PE
50912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5092
d0baac98 5093 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5094 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5095 (__malloc_size_t, __malloc_ptrdiff_t):
5096 Remove. All uses removed, replaced by the definiens if needed,
5097 since we can assume C89 or better now.
5098 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5099 (protect_malloc_state, align, get_contiguous_space)
5100 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5101 (malloc_atfork_handler_child, malloc_enable_thread)
5102 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5103 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5104 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5105 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5106 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5107 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5108 Define using prototypes, not old style.
5109 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5110 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5111 (align): Don't assume that signed integer overflow wraps around.
5112 Omit unused local var.
5113 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5114 (_free_internal_nolock, memalign, mallochook, reallochook):
5115 Omit no-longer-needed casts.
5116 (valloc): Use getpagesize, not __getpagesize.
5117 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5118 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5119
de85e130
PE
5120 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5121
dcbf5805
MA
51222012-04-22 Michael Albinus <michael.albinus@gmx.de>
5123
5124 Move functions from C to Lisp. Make non-blocking method calls
5125 the default. Implement further D-Bus standard interfaces.
5126
5127 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5128 (QCdbus_request_name_allow_replacement)
5129 (QCdbus_request_name_replace_existing)
5130 (QCdbus_request_name_do_not_queue)
5131 (QCdbus_request_name_reply_primary_owner)
5132 (QCdbus_request_name_reply_in_queue)
5133 (QCdbus_request_name_reply_exists)
5134 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5135 (QCdbus_registered_serial, QCdbus_registered_method)
5136 (QCdbus_registered_signal): New Lisp objects.
5137 (XD_DEBUG_MESSAGE): Use sizeof.
5138 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5139 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5140 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5141 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5142 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5143 (xd_signature, xd_append_arg): Allow float for integer types.
5144 (xd_get_connection_references): New function.
b593d6a9
AH
5145 (xd_get_connection_address): Rename from xd_initialize.
5146 Return cached address.
dcbf5805
MA
5147 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5148 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5149 level.
5150 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5151 Return number of refcounts.
dcbf5805
MA
5152 (Fdbus_get_unique_name): Make stronger parameter check.
5153 (Fdbus_message_internal): New defun.
5154 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5155 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5156 (Fdbus_send_signal, Fdbus_register_service)
5157 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5158 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5159 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5160 (Vdbus_compiled_version, Vdbus_runtime_version)
5161 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5162 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5163 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5164 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5165 Adapt docstring.
dcbf5805 5166
52828e02
PE
51672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5168
da05bc4c
PE
5169 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5170 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5171 Do not assume ptrdiff_t is the same width as 'int'.
5172
52828e02
PE
5173 * alloc.c: Handle unusual debugging option combinations.
5174 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5175 since the two debugging options are incompatible.
5176 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5177 is defined.
5178 (mem_init, mem_insert, mem_insert_fixup):
5179 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5180 (NEED_MEM_INSERT): Remove; no longer needed.
5181
f01769f9
LL
51822012-04-22 Leo Liu <sdl.web@gmail.com>
5183
5184 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5185
5790543d
PE
51862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5187
5188 * sysdep.c [__FreeBSD__]: Minor cleanups.
5189 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5190 Use Emacs indenting style more consistently. Avoid some casts.
5191 Use 'double' consistently rather than mixing 'float' and 'double'.
5192
b91b7e4d
EW
51932012-04-21 Eduard Wiebe <usenet@pusto.de>
5194
b593d6a9
AH
5195 * sysdep.c (list_system_processes, system_process_attributes):
5196 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5197
6114eb15
AS
51982012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5199
5200 * lisp.mk (lisp): Update.
5201
2f38dff7
PE
52022012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5203
5204 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5205 It is never used otherwise.
5206
4ae29f89
SM
52072012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5208
5209 * print.c (print_preprocess): Only check print_depth if print-circle
5210 is nil.
5211 (print_object): Check for cycles even when print-circle is nil and
5212 print-gensym is t, but only check print_depth if print-circle is nil.
5213
f30d612a
CY
52142012-04-20 Chong Yidong <cyd@gnu.org>
5215
5216 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5217 set the status to "failed" and ensure that sentinel is run.
5218
c07a4c0b 52192012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5220
5221 * process.c (Fset_process_inherit_coding_system_flag)
5222 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5223 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5224
c07a4c0b 52252012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5226
5227 * xdisp.c (string_buffer_position_lim): Limit starting position to
5228 BEGV.
5229 (set_cursor_from_row): If called for a mode-line or header-line
5230 row, return zero immediately.
5231 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5232 farther than the first row after the header line, if any.
5233 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5234 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5235
c07a4c0b 52362012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5237
4ae29f89
SM
5238 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5239 (bug#11238).
ad3a2b41 5240
c07a4c0b 52412012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 52422012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5243
5244 configure: new option --enable-gcc-warnings (Bug#11207)
5245 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5246 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5247 (ALL_CFLAGS): Use new macros rather than old.
5248 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5249 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5250 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5251 -Wunused-result, -Wunused-variable. This should go away once
5252 the Emacs and Gnulib regex code is merged.
5253 (xmalloc, xrealloc): Now static.
5254
aba027e8
PE
52552012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5256
5257 * dired.c (Fsystem_groups): Remove unused local.
5258
e5a36063
GM
52592012-04-17 Glenn Morris <rgm@gnu.org>
5260
5261 * dired.c (Fsystem_users): Doc fix.
5262
316411f0
DA
52632012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5264
5265 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5266 (syms_of_dired): Add them.
5267
9426aba4
PE
52682012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5269
b62a57be
PE
5270 Fix minor alloc.c problems found by static checking.
5271 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5272 New extern decls, to avoid calling undeclared functions.
5273 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5274 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5275 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5276 (NEED_MEM_INSERT): New macro.
5277 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5278 Remove one incorrect comment and fix another.
b62a57be 5279
3539f31f
PE
5280 Fix minor ralloc.c problems found by static checking.
5281 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5282 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5283 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5284 (r_alloc_sbrk): Now static.
5285
a041960a
PE
5286 Improve ralloc.c interface checking.
5287 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5288 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5289 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5290 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5291 [REL_ALLOC]: ... to here, to check interface.
5292 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5293 Remove decls. This fixes an "It stinks!".
5294
9426aba4
PE
5295 * alloc.c (which_symbols): Fix alignment issue / type clash.
5296
d55c12ed
AS
52972012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5298
5299 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5300 (struct Lisp_Misc_Any): Likewise.
5301 (struct Lisp_Free): Likewise.
5302 * alloc.c (union aligned_Lisp_Symbol): Define.
5303 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5304 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5305 (union aligned_Lisp_Misc): Define.
5306 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5307 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5308 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5309
b948ce8b
PE
53102012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5311
5312 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5313 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5314 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5315 * s/netbsd.h, s/sol2-6.h:
5316 Remove definition of GC_MARK_STACK, since the default now works.
5317 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5318 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5319 no longer the default.
5320 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5321
35dc09a1 53222012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5323
35dc09a1
GM
5324 * lread.c (lisp_file_lexically_bound_p):
5325 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5326
35dc09a1
GM
53272012-04-14 Eli Zaretskii <eliz@gnu.org>
5328
5329 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5330 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5331
53322012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5333
5334 * nsterm.m (constrainFrameRect): Always constrain when there is only
5335 one screen (Bug#10962).
5336
bcd86815
KB
53372012-04-13 Ken Brown <kbrown@cornell.edu>
5338
5339 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5340
c25df26e
RT
53412012-04-13 Reuben Thomas <rrt@sc3d.org>
5342
5343 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5344
0fc59f1e
DC
53452012-04-11 Daniel Colascione <dancol@dancol.org>
5346
5347 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5348 against is gone. It's better to use vfork now so that when Cygwin
5349 gains a new, working vfork, we use it automatically (bug#10398).
5350
de8c03dc
SM
53512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5352
5353 * window.c (save_window_save): Obey window-point-insertion-type.
5354
2f097256
GM
53552012-04-11 Glenn Morris <rgm@gnu.org>
5356
5357 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5358
453b951e
SM
53592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5360
5361 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5362
75f1671a 53632012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5364
5365 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5366 (force_quit_count): New var.
5367 (handle_interrupt): Use it.
5368
2a8ce227
JB
53692012-04-10 Juanma Barranquero <lekktu@gmail.com>
5370
5371 * w32.c (w32_delayed_load): Record the full path of the library
5372 being loaded (bug#10424).
5373
935396c0
GM
53742012-04-09 Glenn Morris <rgm@gnu.org>
5375
05920a43
GM
5376 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5377 not just in the obarray, before snarfing them. (Bug#11036)
5378
935396c0
GM
5379 * Makefile.in ($(leimdir)/leim-list.el):
5380 Pass EMACS rather than BUILT_EMACS.
5381
a18ecafa
TZ
53822012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5383
5384 * process.c (make_process):
5385 * process.h: Add integer `gnutls_handshakes_tried' member to
5386 process struct.
5387
6bbef4e5
JC
5388 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5389 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5390
5391 * gnutls.c (gnutls_log_function2i): Convenience log function.
5392 (emacs_gnutls_read): Use new log functions,
5393 `gnutls_handshakes_tried' process member, and
5394 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5395 attempts per process (connection).
5396
b4d3bc10
CY
53972012-04-09 Chong Yidong <cyd@gnu.org>
5398
5399 * eval.c (Fuser_variable_p, user_variable_p_eh)
5400 (lisp_indirect_variable): Functions deleted.
5401 (Fdefvar): Caller changed.
5402
5403 * callint.c (Finteractive, Fcall_interactively):
5404 * minibuf.c (Fread_variable): Callers changed.
5405
70f4d973
EZ
54062012-04-09 Eli Zaretskii <eliz@gnu.org>
5407
5408 * xdisp.c (set_cursor_from_row): If the display string appears in
5409 the buffer at position that is closer to point than the position
5410 after the display string, display the cursor on the first glyph of
5411 the display string. Fixes cursor display when a 'display' text
5412 property immediately follows invisible text. (Bug#11094)
5413
cb3c2e3e
PE
54142012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5415
5416 composite.c: use 'double' consistently
5417 * composite.c (get_composition_id): Use 'double' consistently
5418 instead of converting 'float' to 'double' and vice versa; this is
5419 easier to understand and avoids a GCC warning.
5420
fd06db5d
GM
54212012-04-09 Glenn Morris <rgm@gnu.org>
5422
50fe702a
GM
5423 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5424 preparation for dumping it with emacs. (Bug#4789)
5425 (leimdir): New variable.
5426 ($(leimdir)/leim-list.el): New rule.
5427 (emacs$(EXEEXT)): Depend on leim-list.el.
5428
fd06db5d
GM
5429 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5430 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5431 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5432
55c131ee
AS
54332012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5434
5435 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5436 proper alignment.
5437
9209588f
JB
54382012-04-07 Juanma Barranquero <lekktu@gmail.com>
5439
5440 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5441 Remove unused local variable.
5442
e3fb2efb
PE
54432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5444
5445 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5446 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5447 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5448 objects, as mark_maybe_pointer will catch them otherwise.
5449 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5450 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5451
b5385551
PE
54522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5453
5454 Fix typo that broke non-Windows builds.
5455 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5456
9078ead6
EZ
54572012-04-07 Eli Zaretskii <eliz@gnu.org>
5458
5459 Support building on MS-Windows with libxml2.
5460
5461 * makefile.w32-in (OBJ2): Add xml.$(O).
5462 (GLOBAL_SOURCES): Add xml.c.
5463 ($(BLD)/xml.$(O)): New dependency list.
5464
5465 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5466 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5467 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5468 [!WINDOWSNT]: New macros.
5469 (init_libxml2_functions, libxml2_loaded_p): New functions.
5470 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5471 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5472 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5473 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5474 linked in).
6bbef4e5
JC
5475 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5476 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5477 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5478
5479 * emacs.c: Don't include libxml/parser.h.
5480 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5481 xmlCleanupParser directly.
5482
5483 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5484
3811fdf3
EZ
54852012-04-07 Eli Zaretskii <eliz@gnu.org>
5486
5487 * indent.c (Fvertical_motion): If there is a display string at
5488 point, use it.vpos to compute how many lines to backtrack after
5489 move_it_to point. (Bug#11133)
5490
2f8e16b2
EZ
54912012-04-06 Eli Zaretskii <eliz@gnu.org>
5492
5493 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5494 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5495 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5496 macros related to unification of CJK characters. For the details,
5497 see the discussion following the message here:
5498 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5499
3d439cd1
CY
55002012-04-04 Chong Yidong <cyd@gnu.org>
5501
5502 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5503
8bc53d00
EZ
55042012-04-01 Eli Zaretskii <eliz@gnu.org>
5505
5506 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5507 instead of alloca. (Bug#11138)
5508
3b0512a3
AS
55092012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5510
5511 * w32menu.c (is_simple_dialog): Properly check lisp types.
5512 (Bug#11141)
5513
8427ddd2
EZ
55142012-03-31 Eli Zaretskii <eliz@gnu.org>
5515
979022ef
EZ
5516 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5517 position we get to after a call to move_it_to fails the
5518 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5519 only if we wind up in a string from display property. (Bug#11063)
5520
a6b1c7cc
EZ
5521 * window.c (Fdelete_other_windows_internal): Invalidate the row
5522 and column information about mouse highlight, so that redisplay
5523 restores it after reallocating the glyph matrices. (Bug#7464)
5524
8427ddd2
EZ
5525 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5526 string comes from a `display' text property, use the buffer
5527 position of that property as if we actually saw that position in
5528 the row's glyphs.
697ba24b
EZ
5529 (move_it_by_lines): Remove the assertion that
5530 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5531 violated when there's a before-string at the beginning of a line.
5532 (Bug#11063)
8427ddd2 5533
65a0a738
EZ
55342012-03-30 Eli Zaretskii <eliz@gnu.org>
5535
5536 * xdisp.c (append_space_for_newline): If the default face was
5537 remapped, use the remapped face for the appended newline.
5538 (extend_face_to_end_of_line): Use the remapped default face for
5539 extending the face to the end of the line.
5540 (display_line): Call extend_face_to_end_of_line when the default
5541 face was remapped. (Bug#11068)
5542
581355cc
EZ
55432012-03-29 Eli Zaretskii <eliz@gnu.org>
5544
5545 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5546
e8fc049f
SM
55472012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5548
5549 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5550
4fb9a543
GM
55512012-03-27 Glenn Morris <rgm@gnu.org>
5552
5553 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5554 Doc fixes.
5555
679910f1
KH
55562012-03-26 Kenichi Handa <handa@m17n.org>
5557
5558 * dispextern.h (struct glyph): Fix previous change. Change the
5559 bit length of glyphless.ch to 25 (Bug#11082).
5560
90d49b7f
CY
55612012-03-26 Chong Yidong <cyd@gnu.org>
5562
5563 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5564 (command_loop_1): Use it; inhibit selection update for
5565 handle-select-window too (Bug#8996).
5566
f514f6f0
FP
55672012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5568
e8fc049f 5569 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5570
bf43fa51
KH
55712012-03-25 Kenichi Handa <handa@m17n.org>
5572
5573 * dispextern.h (struct glyph): Change the bit length of
5574 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5575
8a0c01dd
EZ
55762012-03-24 Eli Zaretskii <eliz@gnu.org>
5577
5578 * s/ms-w32.h (tzname): Include time.h before redirecting to
5579 _tzname. Fixes the MSVC build. (Bug#9960)
5580
7d1c3a76
AS
55812012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5582
8ed79523
AS
5583 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5584 characters.
5585
7d1c3a76
AS
5586 * xterm.c (XTread_socket): Only modify handling_signal if
5587 !SYNC_INPUT. (Bug#11080)
5588
e99a9b8b
EZ
55892012-03-23 Eli Zaretskii <eliz@gnu.org>
5590
5591 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5592 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5593 when fetching a multibyte character consumes more bytes than
5594 CHAR_BYTES returns, due to unification of CJK characters in
5595 string_char. (Bug#11073)
5596
5063c0e1
TN
55972012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5598
5599 * process.c (wait_reading_process_output): Handle pty disconnect
5600 by refraining from sending oneself a SIGCHLD (bug#10933).
5601
9f851fbd
CY
56022012-03-22 Chong Yidong <cyd@gnu.org>
5603
5604 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5605
5063c0e1 5606 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5607 Mark string as coming from a prefix property.
5608 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5609 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5610
fb5b8aca
CY
56112012-03-21 Chong Yidong <cyd@gnu.org>
5612
5613 * xfaces.c (Vface_remapping_alist): Doc fix.
5614
62356a1b
EZ
56152012-03-20 Eli Zaretskii <eliz@gnu.org>
5616
5617 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5618 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5619 Doc fixes.
62356a1b 5620
025de85b
CY
56212012-03-20 Chong Yidong <cyd@gnu.org>
5622
5623 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5624 to reflect default non-nil value of redisplay-dont-pause.
5625
4827f94e
KH
56262012-03-19 Kenichi Handa <handa@m17n.org>
5627
5628 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5629 it fit in a valid range (Bug#11003).
5630
e50a24a2
EZ
56312012-03-18 Eli Zaretskii <eliz@gnu.org>
5632
5633 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5634 that is not from display property, accept the row as a "cursor
5635 row" if one of the string's character has a non-nil `cursor'
5636 property. Fixes cursor positioning when there are newlines in
5637 overlay strings, e.g. in icomplete.el. (Bug#11035)
5638
9af5ed87
PE
56392012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5640
5641 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5642
d1f55f16
CY
56432012-03-12 Chong Yidong <cyd@gnu.org>
5644
5645 * eval.c (inhibit_lisp_code): Rename from
5646 inhibit_window_configuration_change_hook; move from window.c.
5647
5648 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5649 * window.c (run_window_configuration_change_hook)
5650 (syms_of_window): Callers changed.
5651
66c5eebd
CY
56522012-03-11 Chong Yidong <cyd@gnu.org>
5653
413df973
CY
5654 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5655
66c5eebd
CY
5656 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5657
1de11f56
CY
56582012-03-10 Chong Yidong <cyd@gnu.org>
5659
5660 * frame.c (other_visible_frames): Don't assume the selected frame
5661 is visible (Bug#10955).
5662
cae07000
SM
56632012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5664
5665 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5666
89c94350
JD
56672012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5668
5669 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5670 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5671 zero (Bug#10954).
5672
999dd333
GM
56732012-03-03 Glenn Morris <rgm@gnu.org>
5674
01a6dcc8 5675 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5676
de0100f2
EZ
56772012-03-02 Eli Zaretskii <eliz@gnu.org>
5678
5679 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5680 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5681 (redisplay_window, next_element_from_string): Fix typos in
5682 comments.
3e441275
EZ
5683 (redisplay_window): Pass to move_it_vertically the margin in
5684 pixels, not in screen lines.
de0100f2 5685
96a72ee9
GM
56862012-03-02 Glenn Morris <rgm@gnu.org>
5687
5688 * buffer.c (buffer-list-update-hook): Doc fix.
5689
312508d7
EZ
56902012-02-29 Eli Zaretskii <eliz@gnu.org>
5691
5692 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5693 push_it before setting up the iterator for the first overlay
5694 string, even if we have an empty string loaded.
5695 (next_overlay_string): If there's an empty string on the iterator
5696 stack, pop the stack. (Bug#10903)
5697
27f3c637
PE
56982012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5699
5700 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5701 Suggested by Stefan Monnier in
5702 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5703 * alloc.c (widen_to_Lisp_Object): New static function.
5704 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5705 and widening them to Lisp_Objects. This would work even if
5706 USE_LSB_TAG is defined and wide integers are used, which might
5707 happen in a future version of Emacs.
5708
3c9dfce6
CY
57092012-02-25 Chong Yidong <cyd@gnu.org>
5710
fa74b241
CY
5711 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5712 Doc fix.
5713
3c9dfce6
CY
5714 * xselect.c (Fx_selection_exists_p): Doc fix.
5715 (x_clipboard_manager_save_all): Print an informative message
5716 before saving to clipboard manager.
5717
9486df08
CY
57182012-02-24 Chong Yidong <cyd@gnu.org>
5719
5720 * keyboard.c (process_special_events): Handle all X selection
5721 requests in kbd_buffer, not just the next one (Bug#8869).
5722
f01d3321
CY
57232012-02-23 Chong Yidong <cyd@gnu.org>
5724
5725 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5726 call when setting menu-bar-lines and tool-bar-lines parameters.
5727 (unwind_create_frame_1): New helper function.
5728
5729 * window.c (inhibit_window_configuration_change_hook): New var.
5730 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5731 (syms_of_window): Initialize it.
f01d3321 5732
86b847b6
CY
57332012-02-22 Chong Yidong <cyd@gnu.org>
5734
5735 * xterm.c (x_draw_image_relief): Add missing type check for
5736 Vtool_bar_button_margin (Bug#10743).
5737
a59225b1
CY
57382012-02-21 Chong Yidong <cyd@gnu.org>
5739
5740 * fileio.c (Vfile_name_handler_alist): Doc fix.
5741
5742 * buffer.c (Fget_file_buffer): Protect against invalid file
5743 handler return value.
5744
310f5bd4
PE
57452012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5746
cb3a28cc
PE
5747 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5748 when computing $valmask.
5749
310f5bd4
PE
5750 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5751 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5752 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5753 It's useless in that case, and it can cause problems on hosts
5754 that allocate halves of EMACS_INT values separately.
5755 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5756 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5757 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5758 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5759 it avoids undefined behavior on hosts where shifting right by more
5760 than the word width has undefined behavior.
5761
2375c96a
CY
57622012-02-19 Chong Yidong <cyd@gnu.org>
5763
5764 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5765 (Funhandled_file_name_directory, Ffile_name_as_directory)
5766 (Fdirectory_file_name, Fexpand_file_name)
5767 (Fsubstitute_in_file_name): Protect against invalid file handler
5768 return values (Bug#10845).
5769
3eb49e71
EZ
57702012-02-18 Eli Zaretskii <eliz@gnu.org>
5771
5772 * .gdbinit (pitx): Fix incorrect references to fields of the
5773 iterator stack.
5774
7b926f3f
CY
57752012-02-17 Chong Yidong <cyd@gnu.org>
5776
5777 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5778
11273115
PE
57792012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5780
5781 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5782 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5783
c3a70e2b
CY
57842012-02-15 Chong Yidong <cyd@gnu.org>
5785
5786 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5787 marked as special. Also, starting docstrings with * is obsolete.
5788
0ca43699
AS
57892012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5790
5791 * gnutls.c (emacs_gnutls_write): Fix last change.
5792
2e8f3c56
LI
57932012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5794
5795 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5796 send_process.
5797
af70074f
SM
57982012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5799
5800 * keymap.c (Fsingle_key_description): Handle char ranges.
5801
95986d52
CY
58022012-02-12 Chong Yidong <cyd@gnu.org>
5803
afd83bd1
CY
5804 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5805 as that creates a dangerous corner case.
5806
95986d52
CY
5807 * window.c (Fdelete_window_internal): Invalidate the mouse
5808 highlight (Bug#9904).
5809
bd7da63e
GM
58102012-02-12 Glenn Morris <rgm@gnu.org>
5811
5812 * xselect.c (Fx_own_selection_internal)
5813 (Fx_get_selection_internal, Fx_disown_selection_internal)
5814 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5815 * nsselect.m (Fx_own_selection_internal)
5816 (Fx_disown_selection_internal, Fx_selection_exists_p)
5817 (Fx_selection_owner_p, Fx_get_selection_internal):
5818 Sync docs and argument specs with the xselect.c versions.
5819
77abcbc2
LI
58202012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5821
5822 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5823
90b671e2
EZ
58242012-02-11 Eli Zaretskii <eliz@gnu.org>
5825
1c0ca0b7
EZ
5826 * w32select.c (Fx_selection_exists_p): Sync doc string and
5827 argument list with xselect.c. (Bug#10783)
5828
5829 * w16select.c (Fx_selection_exists_p): Sync doc string and
5830 argument list with xselect.c. (Bug#10783)
90b671e2 5831
49241268
GM
58322012-02-10 Glenn Morris <rgm@gnu.org>
5833
5834 * fns.c (Fsecure_hash): Doc fix.
5835
f998bbe7 58362012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5837
5838 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5839
0992bd9c
CY
58402012-02-07 Chong Yidong <cyd@gnu.org>
5841
5842 * buffer.c (Fbuffer_local_variables)
5843 (buffer_lisp_local_variables): Handle unbound vars correctly;
5844 don't let Qunbound leak into Lisp.
5845
af008560
GM
58462012-02-07 Glenn Morris <rgm@gnu.org>
5847
dd605cc4
GM
5848 * image.c (Fimagemagick_types): Doc fix.
5849
af008560
GM
5850 * image.c (imagemagick-render-type): Change it from a lisp object
5851 to an integer. Move the doc here from the lisp manual.
5852 Treat all values not equal to 0 the same.
5853
1449fa1d
CY
58542012-02-06 Chong Yidong <cyd@gnu.org>
5855
5856 * doc.c (store_function_docstring): Avoid applying docstring of
5857 alias to base function (Bug#2603).
5858
3723ec07
AS
58592012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5860
5861 * .gdbinit (pp1, pv1): Remove redundant defines.
5862 (pr): Use pp.
5863
79c1cc1e
CY
58642012-02-04 Chong Yidong <cyd@gnu.org>
5865
5866 * nsterm.m: Declare a global (Bug#10694).
5867
d7f29f8e
EZ
58682012-02-04 Eli Zaretskii <eliz@gnu.org>
5869
cae07000
SM
5870 * w32.c (get_emacs_configuration_options):
5871 Include --enable-checking, if specified, in the return value.
d7f29f8e 5872
3b95a6f9
MR
58732012-02-04 Martin Rudalics <rudalics@gmx.at>
5874
5875 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5876 after rounding frame sizes. (Bug#9723)
5877
d6fa96a6
EZ
58782012-02-04 Eli Zaretskii <eliz@gnu.org>
5879
5880 * keyboard.c (adjust_point_for_property): Don't position point
5881 before BEGV. (Bug#10696)
5882
df0b2940
PE
58832012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5884
5885 Handle overflow when computing char display width (Bug#9496).
5886 * character.c (char_width): Return EMACS_INT, not int.
5887 (char_width, c_string_width): Check for overflow when
5888 computing the width; this is possible now that individual
5889 characters can have unbounded width. Problem introduced
5890 by merge from Emacs 23 on 2012-01-19.
5891
6bee44d6
MA
58922012-02-02 Michael Albinus <michael.albinus@gmx.de>
5893
5894 * dbusbind.c (Fdbus_register_method): Mention the return value
5895 :ignore in the docstring.
5896
44f92739
GM
58972012-02-02 Glenn Morris <rgm@gnu.org>
5898
1b9f60cc
GM
5899 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5900
44f92739
GM
5901 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5902 Unconditionally set to t. (Bug#10673)
5903 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5904 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5905 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5906
c5d3843c
KH
59072012-02-02 Kenichi Handa <handa@m17n.org>
5908
5909 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5910 0, do not call append_composite_glyph.
5911
159462d4 59122012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5913
5914 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5915 NULL (Bug#6988).
5916 (x_produce_glyphs): If the component of a composition is a null
5917 string, set it->pixel_width to 1 to avoid zero-width glyph.
5918
78cef877
EZ
59192012-02-01 Eli Zaretskii <eliz@gnu.org>
5920
5921 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5922 first 2 arguments are identical. This makes inserting large
5923 output from a subprocess an order of magnitude faster on
5924 MS-Windows, where all sbrk'ed memory is always contiguous.
5925
97897668
GM
59262012-01-31 Glenn Morris <rgm@gnu.org>
5927
5928 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5929 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5930 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5931
31fd3586
GM
59322012-01-29 Glenn Morris <rgm@gnu.org>
5933
5934 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5935
0e24a8b2
CY
59362012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5937
5938 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5939
cc0adcb0
CY
59402012-01-28 Chong Yidong <cyd@gnu.org>
5941
5942 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5943
acc28cb9
CY
59442012-01-26 Chong Yidong <cyd@gnu.org>
5945
9c69cfb7
CY
5946 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5947
acc28cb9
CY
5948 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5949 repeat counts (Bug#10507).
5950
48da7392
GM
59512012-01-26 Glenn Morris <rgm@gnu.org>
5952
5953 * lread.c (syms_of_lread): Doc fix.
5954
14af5f7f
CY
59552012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5956
5957 * coding.c (encode_designation_at_bol): Change return value to
5958 EMACS_INT.
5959
0b21c100
CY
59602012-01-25 Chong Yidong <cyd@gnu.org>
5961
5962 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5963
3c2907f7
CY
59642012-01-21 Chong Yidong <cyd@gnu.org>
5965
5966 * floatfns.c (Fcopysign): Make the second argument non-optional,
5967 since nil is not allowed anyway.
5968
959ad23f
AS
59692012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5970
5971 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5972 (send_process): Likewise.
5973
34a02f46
MR
59742012-01-19 Martin Rudalics <rudalics@gmx.at>
5975
5976 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5977 (Vwindow_persistent_parameters): Do not use Qstate.
5978 Rewrite doc-strings.
34a02f46 5979
1259009a 59802012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5981
5982 * character.c (char_width): New function.
70d4fdf6
GM
5983 (Fchar_width, c_string_width, lisp_string_width):
5984 Use char_width (Bug#9496).
25ed9e61 5985
6a6ee00d
MR
59862012-01-16 Martin Rudalics <rudalics@gmx.at>
5987
5988 * window.c (Vwindow_persistent_parameters): New variable.
5989 (Fset_window_configuration, save_window_save): Handle persistent
5990 window parameters.
5991
c85efaf7
EZ
59922012-01-14 Eli Zaretskii <eliz@gnu.org>
5993
5994 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5995 thrashing the stack of the thread. (Bug#9087)
5996
5944709e
PE
59972012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5998
5999 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6000
e71f5d99
EZ
60012012-01-11 Eli Zaretskii <eliz@gnu.org>
6002
6003 * xdisp.c (rows_from_pos_range): Handle the case where the
6004 highlight ends on a newline. (Bug#10464)
6005 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6006 he end column for display of highlight that ends on a newline
6007 before a R2L line.
6008
ce316182
GM
60092012-01-11 Glenn Morris <rgm@gnu.org>
6010
6011 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6012 from load-path also when installation-directory is nil. (Bug#10208)
6013
5b43da69
GM
60142012-01-10 Glenn Morris <rgm@gnu.org>
6015
74cc8ff9
GM
6016 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6017
7d8d6e4e
GM
6018 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6019 Update template values to be closer to their typical values these days.
5b43da69 6020
a0db8d43
EZ
60212012-01-09 Eli Zaretskii <eliz@gnu.org>
6022
6023 * xdisp.c (rows_from_pos_range): Accept additional argument
6024 DISP_STRING, and accept any glyph in a row whose object is that
6025 string as eligible for mouse highlight. Fixes mouse highlight of
6026 display strings from overlays. (Bug#10464)
6027
9a0115ab 60282012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6029
b9110d6a 6030 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6031 * fileio.c (auto_saving_dir_umask): New static var.
6032 (Fmake_directory_internal): Use it.
6033 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6034 creating the directory. The old code temporarily assigns
6035 too-generous permissions to the directory.
6036 (do_auto_save_eh): Clear it.
b9110d6a 6037 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6038 that the var is always cleared.
6039
6c1bd3f3
EZ
60402012-01-07 Eli Zaretskii <eliz@gnu.org>
6041
6042 * search.c (scan_buffer): Pass character positions to
6043 know_region_cache, not byte positions. (Bug#6540)
6044
069d2b50
L
60452012-01-07 LynX <_LynX@bk.ru> (tiny change)
6046
6047 * w32.c (sys_rename): Report EXDEV when rename of a directory
6048 fails because the target is on another logical disk. (Bug#10284)
6049
75bf0d33
DB
60502012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6051
6052 * xterm.c (x_embed_request_focus): New function.
6053
6054 * xterm.h: Add prototype.
6055
6056 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6057
1c6e5a32
GM
60582012-01-05 Glenn Morris <rgm@gnu.org>
6059
6060 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6061
651e947e
EZ
60622012-01-01 Eli Zaretskii <eliz@gnu.org>
6063
6064 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6065 Load gnutls_transport_set_lowat only if GnuTLS version is below
6066 2.11.1.
6067 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6068 GnuTLS versions below 2.11.1.
6069
3778cdd8
AL
60702011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6071
6072 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6073 to the doc string advising against its use for altering the way
6074 windows are scrolled.
6075
0e5317f7
KH
60762011-12-28 Kenichi Handa <handa@m17n.org>
6077
6078 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6079 coding-system ASCII compatible only when it does not produce BOM
6080 on encoding (Bug#10383).
6081
93d5ca1f
JD
60822011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6083
6084 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6085 can scroll.
6086 (create_and_show_popup_menu): Always use menu_position_func for
6087 Gtk3 (Bug#10361).
6088
ca22b785
AS
60892011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6090
6091 * callint.c (Fcall_interactively): Don't truncate prompt string.
6092
d048e1e6
EZ
60932011-12-23 Eli Zaretskii <eliz@gnu.org>
6094
6095 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6096 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6097 resumed from there (after widening). (Bug#10360)
d048e1e6 6098
5ccaba1f
JD
60992011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6100
6101 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6102
204ee57f
JD
61032011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6104
b81d40f0
JB
6105 * nsterm.m (x_free_frame_resources):
6106 Release f->output_data.ns->miniimage.
204ee57f
JD
6107 (ns_index_color): Fix indentation. Do not retain
6108 color_table->colors[i].
6109
6110 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6111 before returning.
6112
6113 * nsfns.m (x_set_background_color): Assign return value from
6114 ns_index_color to face-background instead of NSColor*.
6115 (ns_implicitly_set_icon_type): Fix indentation.
6116 Change assignment in for loop to comparison.
6117
6118 * emacs.c (ns_pool): New variable.
6119 (main): Assign ns_pool.
6120 (Fkill_emacs): Call ns_release_autorelease_pool.
6121
6122 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6123 autorelease fdesc, release fdAttrs and tdict.
6124 (ns_get_covering_families): Release charset.
6125 (ns_findfonts): Release NSFontDescriptor created with new.
6126 (ns_uni_to_glyphs): Fix indentation.
6127 (setString): Release attrStr before assigning new value.
6128
c803b2b7
JD
61292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6130
678f4426
JD
6131 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6132 and NS_IMPL_COCOA.
6133 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6134 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6135
cd394be1 61362011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6137
5fecd5fc
JD
6138 * nsterm.m (ns_term_init): Subscribe for notifications
6139 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6140 to method trackingNotification in EmacsMenu.
6141
6142 * nsmenu.m (trackingMenu): New variable.
3771cb17 6143 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6144 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6145 from Aquamacs (Bug#7030).
678f4426
JD
6146
61472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6148
c803b2b7
JD
6149 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6150 (symbol_to_nsstring): Fix indentation.
6151 (ns_symbol_to_pb): New function.
cae07000
SM
6152 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6153 (Fns_rotate_cut_buffers_internal): Remove.
6154 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6155 Fns_store_cut_buffer_internal.
6156 (ns_get_foreign_selection, Fx_own_selection_internal)
6157 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6158 (Fns_get_selection_internal, Fns_store_selection_internal):
6159 Use ns_symbol_to_pb and check if return value is nil.
6160 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6161 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6162 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6163 renamed to Sns_store_selection_internal.
6164 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6165 and remove this function.
6166 (ns_handle_selection_clear): Remove, never used.
6167 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6168 here.
6169
e1b01a3a
KB
61702011-12-17 Ken Brown <kbrown@cornell.edu>
6171
6172 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6173 GID is unknown (Bug#10257).
6174
2adb6e85
PE
61752011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6176
6177 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6178 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6179 which caused a build failure on GNU/Linux IA-64. This problem was
6180 introduced by my 2011-10-07 patch.
6181
d1d7b339
JL
61822011-12-15 Juri Linkov <juri@jurta.org>
6183
6184 * image.c (imagemagick_error): New function. (Bug#10112)
6185 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6186 Use `imagemagick_error' where ImageMagick functions return
6187 `MagickFalse'.
6188 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6189 proper order.
6190
100d5755
KH
61912011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6192
6193 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6194 fill background (Bug#8992).
6195
454592a6
MR
61962011-12-13 Martin Rudalics <rudalics@gmx.at>
6197
6198 * window.c (Vwindow_combination_resize)
6199 (Vwindow_combination_limit): Use t instead of non-nil in
6200 doc-strings.
61d4b438
MR
6201 (Vrecenter_redisplay): Add first sentence of doc-string on
6202 separate line.
53524d93 6203 (Frecenter): Fix doc-string typo.
454592a6 6204
3633e3aa
KH
62052011-12-11 Kenichi Handa <handa@m17n.org>
6206
6207 * coding.c (Funencodable_char_position): Pay attention to the
6208 buffer text relocation (Bug#9389).
6209
7b9d523a 62102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6211
7b9d523a
JD
6212 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6213 gtk_init (Bug#10100).
6214
b73189c6
EZ
62152011-12-10 Eli Zaretskii <eliz@gnu.org>
6216
6217 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6218 IT->string is nil. (Bug#10263)
6219
f7dfe5d6
JD
62202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6221
83faebb4
JD
6222 * nsterm.h (x_free_frame_resources): Declare.
6223
f7dfe5d6
JD
6224 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6225 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6226
6227 * nsterm.h (ns_get_defaults_value): Declare.
6228
6229 * nsterm.m (ns_default): Call ns_get_defaults_value.
6230
7cd4e72c
EZ
62312011-12-09 Eli Zaretskii <eliz@gnu.org>
6232
6233 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6234 (Bug#10170)
6235
b34d7317
YM
62362011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6237
6238 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6239 that where the value of an _OBJC_* symbol points to is in the .bss
6240 section (Bug#10240).
6241
76470ad1
KH
62422011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6243
6244 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6245 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6246
745fff94
KH
62472011-12-08 Kenichi Handa <handa@m17n.org>
6248
6249 * ftfont.c (get_adstyle_property): Fix previous change
6250 (Bug#10233).
6251
6e44397c
JB
62522011-12-07 Juanma Barranquero <lekktu@gmail.com>
6253
6254 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6255 dirs from the default value of EMACSLOADPATH (bug#10208).
6256
7efa6272
GM
62572011-12-07 Glenn Morris <rgm@gnu.org>
6258
6259 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6260 installation and source directories as well. (Bug#10208)
6261
f6fc4d87
CY
62622011-12-06 Chong Yidong <cyd@gnu.org>
6263
6264 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6265
2bf26180
GM
62662011-12-06 Glenn Morris <rgm@gnu.org>
6267
6268 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6269 as an error, not just -1. (Bug#10217)
6270
3a6ad4f0
CY
62712011-12-05 Chong Yidong <cyd@gnu.org>
6272
6273 * keyboard.c (process_special_events): New function.
6274 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6275
75a3b399
PE
62762011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6277
6278 * coding.c (encode_designation_at_bol): Don't use uninitialized
6279 local variable (Bug#9318).
6280
c3c9e25e
KH
62812011-12-05 Kenichi Handa <handa@m17n.org>
6282
6283 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6284 return Qnil (Bug#8046, Bug#10193).
6285
5eb05ea3
KH
62862011-12-05 Kenichi Handa <handa@m17n.org>
6287
6288 * coding.c (encode_designation_at_bol): New args charbuf_end and
6289 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6290 (coding_set_source): Return how many bytes coding->source was
6291 relocated.
6292 (coding_set_destination): Return how many bytes
6293 coding->destination was relocated.
6294 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6295 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6296
62972011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6298
6299 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6300 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6301 macro (Bug#9318).
6302
63032011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6304
6305 The following changes are to fix Bug#9318.
6306
a79703f5 6307 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6308 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6309 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6310 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6311
7dbda6df
JB
63122011-12-05 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * lisp.h (process_quit_flag): Fix external declaration.
6315
6d5eb5b0
SM
63162011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6317
6318 Don't macro-inline non-performance-critical code.
6319 * eval.c (process_quit_flag): New function.
6320 * lisp.h (QUIT): Use it.
6321
a0c3fad0
JD
63222011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6323
6324 * nsfns.m (get_geometry_from_preferences): New function.
6325 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6326
6c07aac2
AS
63272011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6328
6329 * emacs.c (Qkill_emacs): Define.
6330 (syms_of_emacs): Initialize it.
6331 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6332 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6333 (quit_throw_to_read_char): Add parameter `from_signal'.
6334 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6335 * lisp.h (QUIT): Call Fkill_emacs if requested.
6336
c052ead4
JD
63372011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6338
6339 * widget.c (update_wm_hints): Return if wmshell is null.
6340 (widget_update_wm_size_hints): New function.
6341
6342 * widget.h (widget_update_wm_size_hints): Declare.
6343
6344 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6345 widget_update_wm_size_hints (Bug#10104).
6346
9e49252b
EZ
63472011-12-03 Eli Zaretskii <eliz@gnu.org>
6348
6349 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6350 before a newline, prepare the bidi iterator for consuming the
6351 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6352 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6353
02b16839
JL
63542011-12-02 Juri Linkov <juri@jurta.org>
6355
6356 * search.c (Fword_search_regexp): New Lisp function created from
6357 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6358 (Fword_search_backward, Fword_search_forward)
6359 (Fword_search_backward_lax, Fword_search_forward_lax):
6360 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6361 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6362
0068070e
SM
63632011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6364
6365 * fileio.c (Finsert_file_contents): Move after-change-function call
6366 to before the "handled:" label, since all "goto handled" appear in
6367 cases where the *-change-functions have already been properly called
6368 (bug#10117).
6369
3360a3fc
AS
63702011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6371
6372 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6373 waiting for input. (Bug#10169)
6374
73d6c093
EZ
63752011-11-30 Eli Zaretskii <eliz@gnu.org>
6376
6377 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6378 verifies glyph row's hash code--we have just reallocated the
6379 glyphs, so their contents can be complete garbage. (Bug#10164)
6380
febe6bea
JB
63812011-11-30 Juanma Barranquero <lekktu@gmail.com>
6382
6383 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6384
801a4313
EZ
63852011-11-30 Eli Zaretskii <eliz@gnu.org>
6386
6387 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6388 attributes are tested _before_ calling verify_row_hash, to protect
6389 against GCC re-ordering of the tests. (Bug#10164)
6390
2b56b87e
JD
63912011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6392
6393 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6394
6395 * xterm.c (handle_one_xevent): Only set async_visible and friends
6396 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6397 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6398 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6399
dbf31225
PE
64002011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6401
6402 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6403 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6404 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6405 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6406 All uses changed to use GCPRO1 etc.
6407 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6408 Revert to old implementation (i.e., before 2011-03-11).
6409
1305621b
YM
64102011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6411
6412 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6413 of scroll runs so as to avoid assigning disabled bogus rows and
6414 unnecessary graphics copy operations.
6415
8c9afb46
EZ
64162011-11-27 Eli Zaretskii <eliz@gnu.org>
6417
6418 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6419 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6420 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6421 (malloc, free, realloc, calloc): Redirect to e_* only when
6422 compiling Emacs.
6423
6424 * lisp.h (GCTYPEBITS): Move before first use.
6425 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6426 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6427 this macro definition.
6428
6429 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6430 _MSC_VER.
6431
54e9e3bf
JD
64322011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6433
6d5eb5b0
SM
6434 * gtkutil.c (xg_create_frame_widgets):
6435 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6436 present with Gtk+ 2.0.
6437
83aca1cb
PE
64382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6439
6440 * fileio.c (Finsert_file_contents): Undo previous change; see
6441 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6442
5b76caa4
PE
64432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6444
6445 Rename locals to avoid shadowing.
6446 * fileio.c (Finsert_file_contents):
6447 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6448 * process.c (wait_reading_process_output):
6449 Rename inner 'proc' to 'p' to avoid shadowing.
6450 Indent for consistency with usual Emacs style.
6451
8c535114
EZ
64522011-11-25 Eli Zaretskii <eliz@gnu.org>
6453
6454 * xdisp.c (redisplay_window): If cursor row is not fully visible
6455 after recentering, and scroll-conservatively is set to a large
6456 number, scroll window by a few more lines to make the cursor fully
6457 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6458 (start_display): Don't move to the next line if the display should
6459 start at a newline that is part of a display vector or an overlay
6460 string. (Bug#10119)
8c535114 6461
fa4fdb5c
JL
64622011-11-24 Juri Linkov <juri@jurta.org>
6463
6464 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6465 after the `MagickPingImage' call. (Bug#10112)
6466
90ec88df
CY
64672011-11-23 Chong Yidong <cyd@gnu.org>
6468
6469 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6470
56e2e794
MR
64712011-11-23 Martin Rudalics <rudalics@gmx.at>
6472
6473 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6474 making another buffer current. (Bug#10114)
6475
b6e64c41
GM
64762011-11-23 Glenn Morris <rgm@gnu.org>
6477
6478 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6479
6b21de18
CY
64802011-11-23 Chong Yidong <cyd@gnu.org>
6481
6482 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6483 using it (Bug#5984).
6484
b12cd789
EZ
64852011-11-22 Eli Zaretskii <eliz@gnu.org>
6486
6487 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6488 and header-lines, as they don't have one computed for them.
6489 (Bug#10098)
6490
6491 * .gdbinit (prow): Make displayed values more self-explaining.
6492 Add row's hash code.
6493
261b6fd4
LMI
64942011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6495
6496 * process.c (wait_reading_process_output): Fix asynchrounous
6497 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6498 (wait_reading_process_output): Add comment and URL.
261b6fd4 6499
e7cfd277
JD
65002011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6501
6502 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6503
a9b9b7f5
CY
65042011-11-21 Chong Yidong <cyd@gnu.org>
6505
6506 * window.c (Fnext_window, Fprevious_window): Doc fix.
6507
b0d15b4f
SM
65082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6509
6510 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6511
fe7a3057
JB
65122011-11-20 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6515
d2999b1a
MR
65162011-11-20 Martin Rudalics <rudalics@gmx.at>
6517
6518 * window.c (Fset_window_combination_limit): Rename argument
6519 STATUS to LIMIT.
6520 (Vwindow_combination_limit): Remove "status" from doc-string.
6521
d5ff9cd0
AS
65222011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6523
6524 * m/ibms390.h: Remove.
6525 * m/ibms390x.h: Don't include "ibms390.h".
6526
a5bb9bd3
SM
65272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6528
6529 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6530 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6531
cd1181db
JB
65322011-11-20 Juanma Barranquero <lekktu@gmail.com>
6533
6534 * casetab.c (Fset_case_table):
6535 * charset.c (Fcharset_after): Fix typos.
6536
615a3b8d 65372011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6538
17e845af
PE
6539 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6540 Otherwise, valgrind does not work on some platforms.
6541 Problem reported by Andreas Schwab in
6a0bf43d
PE
6542 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6543 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6544 is set, removing the need for VIRT_ADDRESS_VARIES.
6545 (PURE_P): Use a more-efficient implementation that needs just one
6546 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6547 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6548 to 4 (xorl, subq, cmpq, setbe).
6549 * alloc.c (pure): Always extern now, since that's the
6550 VIRT_ADDR_VARIES behavior.
6551 (PURE_POINTER_P): Use a single comparison, not two, for
6552 consistency with the new puresize.h.
6553 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6554 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6555 Remove VIRT_ADDR_VARIES no longer needed.
6556
f8fe6f96
EZ
65572011-11-19 Eli Zaretskii <eliz@gnu.org>
6558
6559 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6560 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6561 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6562 behave as if the cursor position were at the window margin.
6563
6564 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6565 and the cursor position is out of bounds, behave as if the cursor
6566 position were at the window margin. (Bug#10075)
6567
df05a53c
CY
65682011-11-18 Chong Yidong <cyd@gnu.org>
6569
6570 * window.c (Fwindow_combination_limit): Make first argument
6571 non-optional, since it is meaningless for live windows like the
6572 selected window.
61ccba97 6573
2071918e
DA
65742011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6575
6576 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6577
b50a28de
SM
65782011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6579
6580 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6581 (graft_intervals_into_buffer): Simplify.
6582
015137db
EZ
65832011-11-18 Eli Zaretskii <eliz@gnu.org>
6584
6585 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6586 hash values of the two rows.
6587 (copy_row_except_pointers): Preserve the used[] arrays and the
6588 hash values of the two rows. (Bug#10035)
68c95424 6589 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6590
6591 * xdisp.c (row_hash): New function, body extracted from
6592 compute_line_metrics.
6593 (compute_line_metrics): Call row_hash, instead of computing the
6594 hash code inline.
6595
6596 * dispnew.c (verify_row_hash): Call row_hash for computing the
6597 hash code of a row, instead of duplicating code from xdisp.c.
6598
6599 * dispextern.h (row_hash): Add prototype.
6600
a2addb04
TH
66012011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6602
6603 * frame.c (delete_frame): Don't delete the terminal when the last
6604 X frame is closed if emacs is built with GTK toolkit.
6605
df85d315
JB
66062011-11-17 Juanma Barranquero <lekktu@gmail.com>
6607
6608 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6609
a0c2d0ae
MR
66102011-11-17 Martin Rudalics <rudalics@gmx.at>
6611
6612 * window.c (Vwindow_splits): Rename to
6613 Vwindow_combination_resize. Suggested by Juri Linkov.
6614 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6615 of Vwindow_splits.
6616
58179cce
JB
66172011-11-16 Juanma Barranquero <lekktu@gmail.com>
6618
7877f373
JB
6619 * nsfns.m (Fns_font_name):
6620 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6621
b6f67890
MR
66222011-11-16 Martin Rudalics <rudalics@gmx.at>
6623
6624 * window.h (window): Rename slot "nest" to "combination_limit".
6625 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6626 (Fset_window_nest): Rename to Fset_window_combination_limit.
6627 (Vwindow_nest): Rename to Vwindow_combination_limit.
6628 (recombine_windows, make_parent_window, make_window)
6629 (Fsplit_window_internal, saved_window)
6630 (Fset_window_configuration, save_window_save): Rename all
6631 occurrences of window_nest to window_combination_limit.
6632
c7015153
JB
66332011-11-15 Juanma Barranquero <lekktu@gmail.com>
6634
6635 * image.c (imagemagick_load_image): Fix typo.
6636
322ad6ec
EZ
66372011-11-14 Eli Zaretskii <eliz@gnu.org>
6638
6639 * xdisp.c (display_line): Move the call to
6640 highlight_trailing_whitespace before the call to
6641 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6642 faces of all the glyphs to compute ROW's hash value.
6643 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6644
f067b8ec
JB
66452011-11-14 Juanma Barranquero <lekktu@gmail.com>
6646
6647 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6648 just return (bug#10044).
6649
1e5b2111
EZ
66502011-11-12 Eli Zaretskii <eliz@gnu.org>
6651
7ef3cbd5
EZ
6652 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6653 with user-defined heap size. Bump the default size of the temacs
6654 heap to 27MB, to avoid memory warning when running temacs.
6655 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6656
1e5b2111
EZ
6657 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6658 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6659 (verify_row_hash) [XASSERTS]: New function.
6660 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6661 that the hash value of glyph rows is correct.
1e5b2111 6662
89d61221
MR
66632011-11-12 Martin Rudalics <rudalics@gmx.at>
6664
6665 * window.h (window): Remove splits slot.
6666 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6667 (Fdelete_other_windows_internal, make_parent_window)
6668 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6669 (Fset_window_configuration, save_window_save): Don't deal with
6670 split status of windows.
6671 (saved_window): Remove splits slot.
6672 (Vwindow_splits): Rewrite doc-string.
6673
97f18cc8
JD
66742011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6675
6676 * xfns.c (unwind_create_frame):
6677 * nsfns.m (unwind_create_frame):
6678 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6679 Vframe_list (Bug#9999).
6680
22a648b4
DA
66812011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6682
0b381c7e 6683 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6684
659afede
KH
66852011-11-11 Kenichi Handa <handa@m17n.org>
6686
6687 * callproc.c (Fcall_process): Set the member dst_multibyte of
6688 process_coding.
6689
9ac0394b
KH
66902011-11-11 Johan Bockgård <bojohan@gnu.org>
6691
6692 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6693 avoid a crash (bug#9496).
6694
2fbdc249
CY
66952011-11-09 Chong Yidong <cyd@gnu.org>
6696
6697 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6698 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6699
ac6b1f81
PE
67002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6701
6702 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6703
09db192c
PE
67042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6705
6706 Avoid some portability problems by eschewing 'extern inline' functions.
6707 The trivial performance wins aren't worth the portability hassles; see
6708 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6709 et seq.
6710 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6711 (window_box_width, window_box_left, window_box_left_offset)
6712 (window_box_right, window_box_right_offset): Undo previous change,
6713 by removing the "extern"s.
6714 * intervals.c (adjust_intervals_for_insertion)
6715 (adjust_intervals_for_deletion): Undo previous change,
6716 making these static again.
6717 (offset_intervals, temp_set_point_both, temp_set_point)
6718 (copy_intervals_to_string): No longer inline.
6719 * xdisp.c (window_text_bottom_y, window_box_width)
6720 (window_box_height, window_box_left_offset)
6721 (window_box_right_offset, window_box_left, window_box_right)
6722 (window_box): No longer inline.
6723
105216ed
CY
67242011-11-08 Chong Yidong <cyd@gnu.org>
6725
6726 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6727 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6728 Signal an error if not a live window.
105216ed
CY
6729 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6730 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6731
ae9e237f
JB
67322011-11-07 Juanma Barranquero <lekktu@gmail.com>
6733
6734 * lisp.h (syms_of_abbrev): Remove declaration.
6735 Reported by CHENG Gao <chenggao@royau.me>.
6736
c7aa8333
EZ
67372011-11-07 Eli Zaretskii <eliz@gnu.org>
6738
6739 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6740 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6741 of temacs in GUI mode.
6742
be7f5545
MR
67432011-11-07 Martin Rudalics <rudalics@gmx.at>
6744
6745 * window.h: Declare delete_all_child_windows instead of
6746 delete_all_subwindows.
6747 * window.c (Fwindow_nest, Fset_window_nest)
6748 (Fset_window_new_total, Fset_window_new_normal)
6749 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6750 (delete_all_subwindows): Rename to delete_all_child_windows.
6751 (Fdelete_other_windows_internal, Fset_window_configuration):
6752 Call delete_all_child_windows instead of delete_all_subwindows.
6753 * frame.c (delete_frame): Call delete_all_child_windows instead
6754 of delete_all_subwindows.
6755
ca78dc43
PE
67562011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6757
6758 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6759 This is also needed for porting to any host where GC_MARK_STACK is
6760 not GC_MAKE_GCPROS_NOOPS.
6761 (which_symbols): Use it.
6762
a0241d01
KH
67632011-11-07 Kenichi Handa <handa@m17n.org>
6764
6765 * coding.c (coding_set_destination): Check coding->src_pos only
6766 when coding->src_object is a buffer (bug#9910).
6767
6768 * process.c (send_process): Set the member src_multibyte of coding
6769 to 0 (bug#9911) when sending a unibyte text.
6770
6771 * callproc.c (Fcall_process): Set the member src_multibyte of
6772 process_coding to 0 (bug#9912).
6773
a64bfdfa 67742011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6775
6776 * xmenu.c (cleanup_widget_value_tree): New function.
6777 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6778 calling free_menubar_widget_value_tree directly (Bug#9830).
6779
cb41b32a
PE
67802011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6781
6782 Fix some portability problems with 'inline'.
6783 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6784 (window_box_width, window_box_left, window_box_left_offset)
6785 (window_box_right, window_box_right_offset): Declare extern.
6786 Otherwise, these inline functions do not conform to C99 and
6787 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6788 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6789 * intervals.c (adjust_intervals_for_insertion)
6790 (adjust_intervals_for_deletion): Now extern, because otherwise the
6791 extern inline functions 'offset_intervals' couldn't refer to it.
6792 (static_offset_intervals): Remove.
6793 (offset_intervals): Rewrite using the old contents of
6794 static_offset_intervals. The old version didn't conform to C99
6795 because an extern inline function contained a reference to an
6796 identifier with static linkage.
6797
b7041366
AS
67982011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6799
6800 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6801 GC.
6802
88a37c4d
EZ
68032011-11-06 Eli Zaretskii <eliz@gnu.org>
6804
6805 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6806 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6807 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6808 return Qleft_to_right.
6809
49745b39
CY
68102011-11-06 Chong Yidong <cyd@gnu.org>
6811
6812 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6813 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6814 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6815 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6816 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6817 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6818 (Fwindow_vscroll): Doc fix.
6819 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6820 argument, since it makes no sense to pass a live window and for
6821 consistency with window-child.
6822
1f05cd82
CS
68232011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6824
6825 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6826 support MSVC.
6827
22610910
JR
68282011-11-05 Jason Rumney <jasonr@gnu.org>
6829
6830 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6831 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6832 fonts (Bug#6029).
6833 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6834 bitwise arithmetic preventing use of unicode-sip and non-truetype
6835 opentype fonts.
6836
a06776b2
EZ
68372011-11-05 Eli Zaretskii <eliz@gnu.org>
6838
3ad924ba
EZ
6839 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6840 "emacs"-only part.
6841
a06776b2
EZ
6842 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6843 initialization code to keep similarity to xfns.c after changes
6844 from 2011-11-05.
6845
c9e7db78
JD
68462011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6847
a97f8f3f
JD
6848 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6849 (unwind_create_frame): New function (Bug#9943).
6850 (Fx_create_frame): Restructure code to be more similar to the one in
6851 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6852 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6853 Move terminal->reference_count++ just before making the frame official
6854 (Bug#9943).
6855
6856 * nsterm.m (x_free_frame_resources): New function.
6857 (x_destroy_window): Move code to x_free_frame_resources.
6858
c9e7db78 6859 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6860 (Fx_create_frame, x_create_tip_frame):
6861 Move terminal->reference_count++ just before making the frame
75f1671a 6862 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6863 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6864
a6fc3b5c
EZ
68652011-11-05 Eli Zaretskii <eliz@gnu.org>
6866
6867 Support MSVC build with newer versions of Visual Studio.
6868 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6869 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6870 nt/gmake.defs.
6871
6872 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6873 which are not supported by MSVC.
6874 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6875 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6876 bitfields.
6877 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6878 types in bitfields.
6879 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6880
6881 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6882
58179cce 68832011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6884
6885 Support MSVC build with newer versions of Visual Studio.
6886 * w32.c: Don't include w32api.h for MSVC.
6887 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6888
6889 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6890 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6891 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6892 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6893 e_* cousins.
6894 (alloca) [_MSC_VER]: Define to _alloca.
6895
6896 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6897
6898 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6899
a58c13ed
EZ
69002011-11-04 Eli Zaretskii <eliz@gnu.org>
6901
6902 * xdisp.c (note_mouse_highlight): If either of
6903 previous/next-single-property-change returns nil, treat that as
6904 the beginning or the end of the buffer. (Bug#9955)
6905
fe0b6370
JD
69062011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6907
a58c13ed 6908 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6909 label is not null (Bug#9951).
6910 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6911 may be NULL.
6912
89bd5ee1
EZ
69132011-11-04 Eli Zaretskii <eliz@gnu.org>
6914
6915 * window.c (Fwindow_body_size): Mention in the doc string that the
6916 return value is in frame's canonical units. (Bug#9949)
6917
84c3edb9
EZ
69182011-11-03 Eli Zaretskii <eliz@gnu.org>
6919
4e2fb5c7
EZ
6920 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6921
84c3edb9 6922 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6923 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6924 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6925
bc17a887
EZ
69262011-11-01 Eli Zaretskii <eliz@gnu.org>
6927
6928 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6929 Don't stop backward scan on the continuation glyph, even though
6930 its CHARPOS is positive.
6d5eb5b0
SM
6931 (mouse_face_from_buffer_pos, note_mouse_highlight):
6932 Rename cover_string to disp_string.
bc17a887 6933
4ee88440
MR
69342011-11-01 Martin Rudalics <rudalics@gmx.at>
6935
6936 * window.c (temp_output_buffer_show): Don't use
6937 Vtemp_buffer_show_specifiers.
6938 (Vtemp_buffer_show_specifiers): Remove unused variable.
6939
c2ff3c02
EZ
69402011-10-30 Eli Zaretskii <eliz@gnu.org>
6941
6942 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6943 past the beginning of the current glyph matrix.
6944
58179cce 69452011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6946
6947 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6948 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6949 HAVE_GTK3 (Bug#9869).
b77a6a7f 6950
3b574623
JD
6951 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6952 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6953
b77a6a7f
JD
6954 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6955
6956 * xterm.c: Declare x_handle_net_wm_state to return int.
6957 (handle_one_xevent): Check if we are iconified but don't have
6958 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6959 (get_current_wm_state): Return non-zero if not hidden,
6960 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6961 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6962 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6963 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6964
196e41e4
PE
69652011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6966
6967 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6968 so that this new function doesn't get optimized away by a
6969 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6970
021f2e1a
AS
69712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6972
6973 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6974
8b058d44
EZ
69752011-10-29 Eli Zaretskii <eliz@gnu.org>
6976
6977 Fix the `xbytecode' command.
6978 * .gdbinit (xprintbytestr): New command.
b50a28de 6979 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6980 (xbytecode): Print the byte-code string as well.
6981
4452fb80
EZ
69822011-10-29 Kim Storm <storm@cua.dk>
6983
8b058d44
EZ
6984 * alloc.c (which_symbols): New function.
6985
21b72067
AS
69862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6987
6988 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6989 line. (Bug#9903)
6990
83ed7b5c
GM
69912011-10-29 Glenn Morris <rgm@gnu.org>
6992
6993 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6994 Not clear what it was for, and it causes various bugs. (Bug#9839)
6995
5a7a728b
EZ
69962011-10-28 Eli Zaretskii <eliz@gnu.org>
6997
6998 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6999 possible random value that matches one of those tested as
7000 condition to clear the mouse face.
7001
d3d0842f
CY
70022011-10-28 Chong Yidong <cyd@gnu.org>
7003
7004 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7005
31b39d13
DN
70062011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7007
7008 * window.c (make_window): Initialize phys_cursor_on_p.
7009
9aba6043
SM
70102011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7011
7012 * lisp.h (struct Lisp_Symbol): Update comments.
7013
c20992f4
JB
70142011-10-28 Juanma Barranquero <lekktu@gmail.com>
7015
7016 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7017
db4f02f2
EZ
70182011-10-28 Eli Zaretskii <eliz@gnu.org>
7019
7020 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7021 <oslsachem@gmail.com> for helping to debug this.
7022
7023 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7024 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7025 (g_b_init_get_glyph_outline_w): New static variables.
7026 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7027 (GetGlyphOutlineW_Proc): New typedefs.
7028 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7029 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7030 New functions.
7031 (w32font_open_internal, compute_metrics):
7032 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7033 instead of calling the "wide" APIs directly.
7034
7035 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7036
7037 * w32.h (syms_of_w32font): Add prototype.
7038
87e68db4
JB
70392011-10-27 Juanma Barranquero <lekktu@gmail.com>
7040
7041 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7042 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7043 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7044 (Fmove_to_window_line): Doc fix.
7045
435c1d67
CY
70462011-10-27 Chong Yidong <cyd@gnu.org>
7047
7048 * process.c (make_process): Set gnutls_state to NULL.
7049
7050 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7051 non-NULL, regardless of GNUTLS_INITSTAGE.
7052 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7053 an error. Set process slots as soon as we allocate them.
7054
7055 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7056
9c6c6f49
CY
70572011-10-27 Chong Yidong <cyd@gnu.org>
7058
9aba6043
SM
7059 * gnutls.c (emacs_gnutls_deinit): New function.
7060 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7061 (Fgnutls_deinit, Fgnutls_boot): Use it.
7062
7063 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7064 (deactivate_process): Call emacs_gnutls_deinit.
7065
657d08d3
JB
70662011-10-27 Juanma Barranquero <lekktu@gmail.com>
7067
7068 * image.c (x_create_x_image_and_pixmap):
7069 * w32.c (sys_rename, w32_delayed_load):
7070 * w32font.c (fill_in_logfont):
7071 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7072
5430d399
JB
70732011-10-26 Juanma Barranquero <lekktu@gmail.com>
7074
7075 * w32fns.c (w32_default_color_map): New function,
7076 extracted from Fw32_default_color_map.
a7ef684b 7077 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7078
fe0055fa
PE
70792011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7080
7081 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7082
e6346438
SM
70832011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7084
7085 * keyboard.c (test_undefined): New function (bug#9751).
7086 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7087
e112cc37
ET
70882011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7089
7090 * sysdep.c (init_sys_modes): Fix the check for the controlling
7091 terminal (Bug#6649).
7092
7b5d6677
EZ
70932011-10-20 Eli Zaretskii <eliz@gnu.org>
7094
7095 * dispextern.h (struct bidi_it): New member next_en_type.
7096
7097 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7098 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7099 current character, check also for next_en_type being WEAK_EN.
7100 (bidi_resolve_weak): Don't enter the expensive loop if the current
7101 position is before next_en_pos. Record the bidi type of the first
7102 non-ET, non-BN character we find, in addition to its position.
7103 (bidi_level_of_next_char): Invalidate next_en_type when
7104 next_en_pos is over-stepped.
7105
7da0b018
PE
71062011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7107
7108 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7109 * editfns.c: Rewrite current-time-zone so that it invokes
7110 the equivalent of (format-time-string "%Z") to get the time zone name.
7111 This fixes a bug when the time zone name contains characters that
7112 need converting from the system time locale to Emacs internal format.
7113 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7114 that patch fixed format-time-string to do the conversion, but
7115 I forgot to fix current-time-zone.
7116 (format_time_string): New function, containing most of
7117 what Fformat_time_string used to contain.
7118 (Fformat_time_string): Rewrite in terms of format_time_string.
7119 This doesn't change this function's behavior.
7120 (current-time-zone): Rewrite to use format_time_string.
7121 This fixes the bug reported by Michael Schierl in
7122 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7123 Jason Rumney's 2007-06-07 change worked around this bug, but
7124 didn't fix it.
7125 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7126
8547b010
EZ
71272011-10-19 Eli Zaretskii <eliz@gnu.org>
7128
7129 * xdisp.c (start_display): If the character at POS is displayed
7130 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7131 (try_window_reusing_current_matrix): If a line ends in a display
7132 vector or the next line starts in a display vector, continue
7133 redrawing the window even though the character position of
7134 start_row was reached.
8547b010
EZ
7135 (Bug#9771, part 2)
7136
4e948d15
CY
71372011-10-18 Chong Yidong <cyd@gnu.org>
7138
7139 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7140 with nobreak-char-display too.
7141
4787455f
EZ
71422011-10-18 Eli Zaretskii <eliz@gnu.org>
7143
7144 Fix part 3 of bug#9771.
7145 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7146 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7147 non-neutral characters if the current character is a paragraph
7148 separator (a.k.a. Newline). This avoids running the same
7149 expensive loop twice, once when we consume the preceding newline
7150 and the other time when the line actually needs to be displayed.
7151 Avoid the loop when we see neutrals on the base embedding level
7152 following a character whose directionality is the same as the
7153 paragraph's. This avoids running the expensive loop when a line
7154 ends in a long sequence of neutrals, like control characters.
7155 Add assertion against STRONG_AL type. Slightly rearrange code
7156 that determines the type of a neutral given the first non-neutral
7157 that follows it.
7158 (bidi_level_of_next_char): Set next_en_pos to zero when
7159 invalidating its info.
7160
2c91f553
EZ
71612011-10-17 Eli Zaretskii <eliz@gnu.org>
7162
7163 * xdisp.c (push_display_prop): Determine whether to record string
7164 or buffer position by IT->string, not by IT->method. Allow
7165 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7166 (move_it_vertically_backward): Don't look for character position
7167 immediately after the newline when in a continuation line.
7168 (Bug#9771, part 1)
2c91f553 7169
c7b08b0d
MR
71702011-10-15 Martin Rudalics <rudalics@gmx.at>
7171
7172 * window.c (coordinates_in_window): Rewrite and delabelize
7173 vertical border check. (Bug#5357) (Bug#9618)
7174
6b02f655
SM
71752011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7176
7177 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7178 errors in XSetWindowBorder (bug#9310).
7179
81d40c92
DA
71802011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7181
7182 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7183 avoid crash when xmalloc overrun checking is enabled.
7184
d4172c3b
EZ
71852011-10-13 Eli Zaretskii <eliz@gnu.org>
7186
7187 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7188 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7189 cursor motion with <left> and <right> arrow keys.
7190
7191 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7192 some callers set that themselves.
7193
b00eea75
EZ
71942011-10-12 Eli Zaretskii <eliz@gnu.org>
7195
7196 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7197 display string and the previous row comes from the same string and
7198 is empty. (Bug#9739) (Bug#9738)
7199
8fe012c4
SM
72002011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7201
7202 * doc.c (get_doc_string): Encode file name (bug#9735).
7203
0074aef2
EZ
72042011-10-12 Eli Zaretskii <eliz@gnu.org>
7205
79beb178
EZ
7206 * bidi.c (bidi_level_of_next_char):
7207 * xdisp.c (get_visually_first_element): Remove old incorrect
7208 comments regarding the Unicode Line Separator character.
7209
0074aef2
EZ
7210 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7211
6e4b3fbe
DA
72122011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7213
7214 * alloc.c (Fgc_status): Do not access beyond zombies array
7215 boundary if nzombies > MAX_ZOMBIES.
7216 * alloc.c (dump_zombies): Add missing format specifier.
7217
0324f3af
PE
72182011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7219
b5525cac
PE
7220 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7221 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7222
0324f3af
PE
7223 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7224 Some packages use them to denote characters with modifiers.
7225
e9b5f888
AS
72262011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7227
7228 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7229 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7230 matching a pp-number. Rename parameter var to var1.
7231
127827c0
SM
72322011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7233
7234 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7235
c8fd3bd0
GM
72362011-10-08 Glenn Morris <rgm@gnu.org>
7237
7238 * callint.c (Fcall_interactively): Give a more explicit error for the
7239 'c' case with a non-character input. (Bug#8479)
7240
352ec8ff
EZ
72412011-10-08 Eli Zaretskii <eliz@gnu.org>
7242
03669ccb
EZ
7243 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7244 lines.
7061c986
EZ
7245 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7246 lines that are hscrolled on the left.
03669ccb 7247
352ec8ff
EZ
7248 * dispnew.c (buffer_posn_from_coords): Account for a possible
7249 presence of header-line. (Bug#4426)
7250
a66cfb1c
SM
72512011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7252
6b02f655
SM
7253 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7254 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7255
7c5ee88e
PE
72562011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7257
7258 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7259 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7260 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7261 this makes Emacs dump core during garbage collection on rare
7262 occasions. sizeof is obviously inferior to offsetof here, so
7263 stick with offsetof.
7264 (GC_POINTER_ALIGNMENT): New macro.
7265 (mark_memory): Omit 3rd (offset) arg; caller changed.
7266 Don't assume EMACS_INT alignment is the same as pointer alignment.
7267
df1bbe5b
SM
72682011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7269
7270 * keyboard.c (read_key_sequence_remapped): New var.
7271 (read_key_sequence): Compute remapping in the right buffer.
7272 (command_loop_1): Use read_key_sequence's remapping directly.
7273
51553db6
SM
72742011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7275
32c1fffd
SM
7276 * dired.c (file_name_completion): Don't expand file name.
7277 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7278 before checking file name handler.
7279
51553db6
SM
7280 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7281 they've been requested explicitly (bug#9591).
7282
b6bd1599 72832011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7284
7285 * keymap.c (Fsingle_key_description): Use make_specified_string
7286 instead of build_string to build string from push_key_description.
7287 (Bug#5193)
7288
f701dc2a
PE
72892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7290
4222c55d
PE
7291 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7292 This fixes a Y2038 bug on 64-bit hosts.
7293 * buffer.c (reset_buffer):
7294 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7295 (Fclear_buffer_auto_save_failure):
7296 Use 0, not -1, to represent an unset failure time, since time_t
7297 might not be signed.
7298
f701dc2a
PE
7299 Remove dependency on glibc malloc internals.
7300 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7301 Move back here from lisp.h, but with their new implementations.
7302 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7303 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7304 * charset.c (charset_table_init): New static var.
7305 (syms_of_charset): Use it instead of xmalloc. This removes a
7306 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7307 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7308 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7309 Move back to alloc.c.
7310 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7311 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7312
9ceebf39
JD
73132011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7314
7315 * nsterm.m (windowDidResize): Call x_set_window_size only when
7316 ns_in_resize is true. Otherwise set pixelwidth/height and
7317 call change_frame_size (Bug#9628).
7318
cb993c58
PE
73192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7320
3930c88b
PE
7321 Port --enable-checking=all to Fedora 14 x86-64.
7322 * charset.c (syms_of_charset): Also account for glibc malloc's
7323 internal overhead when calculating the initial malloc maximum.
7324
cb993c58
PE
7325 Port --enable-checking=all to Fedora 14 x86.
7326 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7327 Move to lisp.h.
7328 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7329 (overrun_check_realloc, overrun_check_free):
7330 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7331 That way, xmalloc returns a properly-aligned pointer even if
7332 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7333 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7334 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7335 into account when calculating the initial malloc maximum.
7336 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7337 Move here from alloc.c, so that charset.c can use it too.
7338 Properly align; the old code wasn't right for common 32-bit hosts
7339 when configured with --enable-checking=all.
7340 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7341 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7342
31bed486
EZ
73432011-09-29 Eli Zaretskii <eliz@gnu.org>
7344
04c70788 7345 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7346 use EDOM.
7347
fbcaa2f3
EZ
73482011-09-28 Eli Zaretskii <eliz@gnu.org>
7349
7350 * xdisp.c (compute_display_string_end): If there's no display
7351 string at CHARPOS, return -1.
7352
7353 * bidi.c (bidi_fetch_char): When compute_display_string_end
7354 returns a negative value, treat the character as a normal
7355 character not covered by a display string. (Bug#9624)
7356
a239d4e9
JB
73572011-09-28 Juanma Barranquero <lekktu@gmail.com>
7358
7359 * lread.c (Fread_from_string): Fix typo in docstring.
7360
88652fd5
EZ
73612011-09-27 Eli Zaretskii <eliz@gnu.org>
7362
7363 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7364 newline, reseat the iterator instead of bidi-iterating there one
7365 character at a time. (Bug#9610)
32c1fffd
SM
7366 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7367 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7368
ed497dd4
AS
73692011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7370
7371 * lread.c (readevalloop): Use correct code for NBSP.
7372 (read1): Likewise. (Bug#9608)
7373
b2bf61aa
MA
73742011-09-25 Michael Albinus <michael.albinus@gmx.de>
7375
7376 * dbusbind.c (Fdbus_register_signal): When service is not
7377 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7378
32bbb17c
GM
73792011-09-25 Glenn Morris <rgm@gnu.org>
7380
7381 * buffer.c (truncate-lines): Doc fix.
7382
94e0933e
CY
73832011-09-24 Chong Yidong <cyd@stupidchicken.com>
7384
7385 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7386 (Fset_window_next_buffers): Doc fix.
7387
cddde921
GM
73882011-09-24 Glenn Morris <rgm@gnu.org>
7389
7390 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7391
1260aef1
PE
73922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7393
25b4bfa0
PE
7394 Fix minor problems found by static checking.
7395 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7396 * indent.c (Fvertical_motion): Fix == vs = typo.
7397
e3cbd34b
EZ
73982011-09-24 Eli Zaretskii <eliz@gnu.org>
7399
a66cfb1c
SM
7400 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7401 Default value is now t. Doc fix.
6bf7006f 7402
e3cbd34b 7403 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7404 logic when moving up, not only when moving down. Fix the
e3cbd34b 7405 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7406 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7407
7408 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7409 CHARPOS is covered by a display string which includes newlines.
7410 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7411 is covered by a display string with embedded newlines.
7412
a3de0cbd
MA
74132011-09-24 Michael Albinus <michael.albinus@gmx.de>
7414
7415 * dbusbind.c (Fdbus_register_signal): Add match rule to
7416 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7417 (Fdbus_register_method, Vdbus_registered_objects_table):
7418 Fix docstring.
a3de0cbd 7419
b260039d
JM
74202011-09-24 Jim Meyering <meyering@redhat.com>
7421
32c1fffd 7422 do not ignore write error for any output size
b260039d
JM
7423 The previous change was incomplete.
7424 While it makes emacs --batch detect the vast majority of stdout
7425 write failures, errors were still ignored whenever the output size is
7426 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7427 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7428 && echo FAIL: ignored write error
7429 FAIL: ignored write error
7430 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7431 && echo FAIL: ignored write error
7432 FAIL: ignored write error
7433 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7434
8eca8a7c
AS
74352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7436
7437 * emacs.c (Fkill_emacs): In noninteractive mode exit
7438 non-successfully if a write error occurred on stdout. (Bug#9574)
7439
3341db62
EZ
74402011-09-21 Eli Zaretskii <eliz@gnu.org>
7441
7442 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7443 the xassert test.
7444
7445 * dispextern.h (struct it): Update the comment documenting what
7446 can it->OBJECT be.
7447
8c203dbf
EZ
74482011-09-20 Eli Zaretskii <eliz@gnu.org>
7449
7450 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7451 a display string, extend search for cursor position to end of row.
7452 (find_row_edges): If the row ends in a newline from a display
7453 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7454 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7455 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7456 non-empty line. Fixes confusing cursor motion with arrow keys at
7457 the beginning of a line that starts with whitespace.
8c203dbf 7458
a4824228
LMI
74592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7460
7461 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7462 (bug#9493).
7463
33ed493b
CY
74642011-09-18 Chong Yidong <cyd@stupidchicken.com>
7465
7466 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7467 boolean (Bug#9154).
7468
56cd55c8
EZ
74692011-09-18 Eli Zaretskii <eliz@gnu.org>
7470
7471 * xdisp.c (display_line): Record maximum and minimum buffer
7472 positions even if no glyphs were produced (e.g., by a zero-width
7473 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7474 buffer positions that will be removed from the glyph row because
7475 they don't fit.
c02dcedf
EZ
7476 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7477 column is beyond frame width: don't subtract 1 "pixel" when
7478 computing width of the stretch.
3e62b7e0
EZ
7479 (reseat_at_next_visible_line_start): Undo the change made on
7480 2011-09-17 that saved paragraph information and restored it after
7481 the call to `reseat'. (Bug#9545)
56cd55c8 7482
5ed99d36 74832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7484
7485 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7486 and turn window cursor on if cleared (Bug#9415).
7487
5ed99d36 74882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7489
7490 * search.c (boyer_moore): Take unibyte characters from pattern
7491 literally. (Bug#9458)
7492
9bade7b2
EZ
74932011-09-18 Eli Zaretskii <eliz@gnu.org>
7494
7495 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7496
e5e9d610
PE
74972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7498
87e4427a
PE
7499 Fix minor problem found by static checking.
7500 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7501 initialized, to pacify gcc -Wuninitialized.
7502
e5e9d610
PE
7503 * fileio.c: Report proper errno when syscall falls.
7504 (Finsert_file_contents): Save and restore errno,
7505 so that report_file_error outputs the correct diagnostic.
7506 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7507
a1674f0b
EZ
75082011-09-18 Eli Zaretskii <eliz@gnu.org>
7509
7510 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7511
fbfb6dd4
EZ
75122011-09-17 Eli Zaretskii <eliz@gnu.org>
7513
7514 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7515 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7516
bb187662
EZ
75172011-09-17 Eli Zaretskii <eliz@gnu.org>
7518
1137e8b8 7519 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7520 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7521
7522 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7523 (bidi_find_paragraph_start): Search back for paragraph beginning
7524 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7525 (bidi_move_to_visually_next): Only trigger paragraph-related
7526 computations when the last character is a newline or at EOB, not
7527 just any NEUTRAL_B. (Bug#9470)
7528
bb187662
EZ
7529 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7530 truncated lines if point is covered by a display string. (Bug#9524)
7531
2e621251
PE
75322011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7533
7534 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7535 (cons_to_x_long): New function.
7536 (lisp_data_to_selection_data): Use it. Correct the test for
7537 short-versus-long data; it was negated. Break out of vector
7538 loop, for efficiency, when a long datum is discovered.
7539
91a15bc6
SM
75402011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7541
7542 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7543
b41c3a35
EZ
75442011-09-16 Eli Zaretskii <eliz@gnu.org>
7545
7546 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7547 GCC PR/17406) by declaring this function with external scope.
7548
7812ba2d
PE
75492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7550
7551 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7552 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7553
cf7edc2a
AS
75542011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7555
7556 * editfns.c (Fformat): Correctly handle text properties on "%%".
7557
bd01620e
EZ
75582011-09-15 Eli Zaretskii <eliz@gnu.org>
7559
7560 * xterm.c (x_draw_composite_glyph_string_foreground):
7561 * w32term.c (x_draw_composite_glyph_string_foreground):
7562 * term.c (encode_terminal_code):
7563 * composite.c (composition_update_it, get_composition_id):
7564 * xdisp.c (get_next_display_element)
7565 (fill_composite_glyph_string): Add comments about special meaning
7566 of TAB characters in a composition.
7567
a02719a3
PE
75682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7569
7570 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7571 This occurs when processing a multibyte format.
7572 Problem reported by Wolfgang Jenker.
a02719a3 7573
72589a3c
JB
75742011-09-15 Johan Bockgård <bojohan@gnu.org>
7575
7576 * xdisp.c (try_cursor_movement): Only check for exact match if
7577 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7578
1c14176c
PE
75792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7580
7581 Remove unused external symbols.
7582 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7583 * xdisp.c (calc_pixel_width_or_height): Now static.
7584 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7585 * indent.c (check_display_width):
7586 * w32term.c: Fix comment to match code.
7587 * xterm.c, xterm.h (x_catching_errors): Remove.
7588
d2eea5b5
PE
75892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7590
7591 * xselect.c: Use signed conversions more consistently (Bug#9498).
7592 (selection_data_to_lisp_data): Assume incoming selection data are
7593 signed integers, not unsigned. This is to be consistent with
7594 outgoing selection data, which was modified to use signed integers
7595 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7596 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7597 expects long, not unsigned long.
7598
46888499
EZ
75992011-09-14 Eli Zaretskii <eliz@gnu.org>
7600
7601 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7602 computation of loop end. Reported by Johan Bockgård
7603 <bojohan@gnu.org>.
7604
ef8ef9fb
CY
76052011-09-13 Chong Yidong <cyd@stupidchicken.com>
7606
7607 * frame.c (Fother_visible_frames_p): Function deleted.
7608
fa819fed
EZ
76092011-09-12 Eli Zaretskii <eliz@gnu.org>
7610
7611 * indent.c (compute_motion): Process display vector front to back
7612 rather than the other way around. (Bug#2496)
7613
2ba8e008
SM
76142011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7615
7616 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7617
20f53c69
CY
76182011-09-11 Chong Yidong <cyd@stupidchicken.com>
7619
7620 * minibuf.c (Fread_from_minibuffer): Doc fix.
7621
d562d7a4
EZ
76222011-09-11 Eli Zaretskii <eliz@gnu.org>
7623
7624 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7625 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7626
1c4d7f3d
LMI
76272011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7628
7629 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7630 value for non-existent files.
7631
b885bf36
EZ
76322011-09-11 Eli Zaretskii <eliz@gnu.org>
7633
7634 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7635 set its "size" to -1. This will set the modtime_size field of
7636 the corresponding buffer to -1, which is what
7637 verify-visited-file-modtime expects for files that do not exist.
7638 (Bug#9139)
7639
6612f0bf
PE
76402011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7641
7642 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7643 here ...
7644 * lisp.h: ... from here. push_key_description is no longer
7645 defined in keyboard.c, so its declaration should not be in
7646 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7647 logically belongs with push_key_description.
7648
dfb3f755
PE
76492011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7650
7651 * buffer.h: Include <sys/types.h> instead of <time.h>.
7652 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7653 Problem reported by Herbert J. Skuhra.
7654
3134906c
LMI
76552011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7656
7657 * xml.c (parse_region): Make the parsing work for
7658 non-comment-starting XML files again (bug#9144).
7659
8d903f4e
AS
76602011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7661
7662 * image.c (gif_load): Fix calculation of bottom and right corner.
7663 (Bug#9468)
7664
80ad64f4
EZ
76652011-09-10 Eli Zaretskii <eliz@gnu.org>
7666
7667 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7668 redisplay in small windows.
7669
208a048d
EZ
76702011-09-09 Eli Zaretskii <eliz@gnu.org>
7671
7672 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7673
9b1c252e
MR
76742011-09-08 Martin Rudalics <rudalics@gmx.at>
7675
7676 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7677 Operate on live windows only.
7678
2949f33b
JB
76792011-09-08 Juanma Barranquero <lekktu@gmail.com>
7680
7681 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7682
e08dcafd
EZ
76832011-09-07 Eli Zaretskii <eliz@gnu.org>
7684
7685 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7686 only under bidi iteration.
7687
115b96bd
JD
76882011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7689
7690 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7691
c8199d0f
PE
76922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7693
7694 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7695 Without this fix, the command to link temacs failed due to an
7696 undefined symbol __builtin_isnan. This is because
7697 /usr/include/iso/math_c99.h #defines isnan(x) to
7698 __builtin_isnan(x), but the bundled gcc, which identifies itself
7699 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7700 a __builtin_isnan.
7701 * floatfns.c (isnan): #undef, and then #define to a clone of
7702 what's in data.c.
7703 (Fisnan): Always define, since it's always available now.
7704 (syms_of_floatfns): Always define isnan at the Lisp level.
7705
e39b275c 77062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7707
7708 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7709
b2db44d9 77102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7711
f4af5137 7712 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7713 The previous code assumed that file offsets (off_t values) fit in
7714 EMACS_INT variables, which is not true on typical 32-bit hosts.
7715 The code messed up by falsely reporting buffer overflow in cases
7716 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7717 when "big" contains more than 2**29 bytes, even though this
7718 inserts just one byte and does not overflow the buffer.
7719 (Finsert_file_contents): Store file offsets as off_t
7720 values, not as EMACS_INT values. Check for overflow when
7721 converting between EMACS_INT and off_t. When checking for
7722 buffer overflow or for overlap, take the offsets into account.
7723 Don't use EMACS_INT for small values where int suffices.
7724 When checking for overlap, fix a typo: ZV was used where
7725 ZV_BYTE was intended.
7726 (Fwrite_region): Don't assume off_t fits into 'long'.
7727 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7728
ecfc0a49
MA
77292011-09-05 Michael Albinus <michael.albinus@gmx.de>
7730
7731 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7732
6511acf2 77332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7734
0999621a 7735 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7736
7737 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7738 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7739 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7740 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7741 (modify_event_symbol): Do not assume that the length of
7742 name_alist_or_stem is safe to alloca and fits in int.
7743 (Fexecute_extended_command): Likewise for function name and binding.
7744 (Frecursion_depth): Wrap around reliably on integer overflow.
7745 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7746 since some callers pass EMACS_INT values.
7747 (Fsingle_key_description): Don't crash if symbol name contains more
7748 than MAX_ALLOCA bytes.
7749 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7750 (get_minibuffer): Arg is now EMACS_INT, not int.
7751 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7752 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7753 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7754
2be7d702
PE
7755 * dbusbind.c (signature_cat): New function.
7756 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7757 Do not overrun buffer; instead, report string overflow.
7758
9d1df220
PE
7759 * dispnew.c (add_window_display_history): Don't overrun buffer.
7760 Truncate instead; this is OK since it's just a log.
7761
33ef5c64
PE
7762 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7763 even if the time zone offset is outlandishly large.
7764 Don't mishandle offset == INT_MIN.
7765
66c6fdd5
PE
7766 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7767 when creating daemon; the previous buffer-overflow check was incorrect.
7768
d749b01b
PE
7769 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7770 which has the guts of the old verror function.
7771
b5cd1905
PE
7772 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7773 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7774
6e1a67fb
PE
7775 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7776 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7777 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7778 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7779 length of string rather than counting it via multiple sprintfs;
7780 that's simpler and more reliable.
c21721cc
PE
7781 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7782 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7783 sprintf, in case result does not fit in int.
7784
c57b67fc
PE
7785 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7786 (fontset_from_font): Print it.
7787
8a401434
PE
7788 * frame.c (tty_frame_count): Now printmax_t, not int.
7789 (make_terminal_frame, set_term_frame_name): Print it.
7790 (x_report_frame_params): In X, window IDs are unsigned long,
7791 not signed long, so print them as unsigned.
7792 (validate_x_resource_name): Check for implausibly long names,
7793 and don't assume name length fits in 'int'.
7794 (x_get_resource_string): Don't blindly alloca invocation name;
7795 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7796 not fit in int.
7797
6e1a67fb
PE
7798 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7799 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7800 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7801
0df02bf3
PE
7802 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7803 Use esprintf, not sprintf, in case result does not fit in int.
7804
48e30793
PE
7805 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7806 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7807 it as a large positive number.
7808 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7809 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7810
a66ff6d8
PE
7811 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7812 in case result does not fit in int.
7813
aca216ff
PE
7814 * print.c (float_to_string): Detect width overflow more reliably.
7815 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7816 buffer overrun. Don't assume list length fits in 'int'. Treat
7817 print length of 0 as 0, not as infinity; to be consistent with other
7818 uses of print length in this function. Don't overflow print length
7819 index. Don't assume hash table size fits in 'long', or that
7820 vectorlike size fits in 'unsigned long'.
7821
31c286f7
PE
7822 * process.c (make_process): Use printmax_t, not int, to format
7823 process-name gensyms.
7824
55e5faa1
PE
7825 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7826
80f2e268
PE
7827 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7828 to avoid potential buffer overrun.
7829
670741ab
PE
7830 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7831 if X resource line is longer than 512 bytes.
7832
b7163a50
PE
7833 * xfns.c (x_window): Make sprintf buffer a bit bigger
7834 to avoid potential buffer overrun.
7835
ae58ff1f
PE
7836 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7837
c43c8a6a
PE
7838 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7839
3f8236f4
PE
78402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7841
53e9fe90 7842 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7843 Without these, Emacs silently mishandles large integers sometimes.
7844 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7845 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7846
6511acf2
PE
7847 * xdisp.c (try_window_id): Check Emacs fixnum range before
7848 converting to 'int'.
806add1d 7849
6511acf2 7850 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7851 Check that an Emacs fixnum is in range before assigning it to 'int'.
7852 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7853 values converted from Emacs fixnums.
7854 (Frecenter): Don't wrap around a line count if it is out of 'int'
7855 range; instead, treat it as an extreme value.
7856 (Fset_window_configuration, compare_window_configurations):
7857 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7858
6511acf2
PE
7859 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7860 that can exceed INT_MAX. Check that EMACS_INT value is in range
7861 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7862 (match_limit): Don't assume that a fixnum can fit in 'int'.
7863
6511acf2 7864 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7865 exceed INT_MAX.
7866
6511acf2 7867 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7868 (Fvertical_motion): Don't wrap around LINES values that don't fit
7869 in 'int'. Instead, treat them as extreme values. This is good
7870 enough for windows, which can't have more than INT_MAX lines anyway.
7871
fcb901a7
LMI
78722011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7873
0f2f6b6d
LMI
7874 * Require libxml/parser.h to avoid compilation warning.
7875
fcb901a7
LMI
7876 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7877
7878 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7879 since this reportedly can destroy thread storage.
7880
6e20a0d4
CY
78812011-08-30 Chong Yidong <cyd@stupidchicken.com>
7882
7883 * syntax.c (find_defun_start): Update all cache variables if
7884 exiting early (Bug#9401).
7885
148ae00e
EZ
78862011-08-30 Eli Zaretskii <eliz@gnu.org>
7887
f6cfbd8f
EZ
7888 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7889
148ae00e
EZ
7890 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7891 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7892 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7893
7894 * term.c (tty_append_glyph): New function.
7895 (produce_stretch_glyph): Static function and its prototype deleted.
7896
a66cfb1c
SM
7897 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7898 Add prototypes.
148ae00e 7899
c4a07a4c
PE
79002011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7901
7902 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7903 when checking :margin (Bug#9390).
7904 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7905 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7906 so that the name doesn't mislead. All uses changed.
7907
6bc8cd65
JB
79082011-08-28 Johan Bockgård <bojohan@gnu.org>
7909
7910 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7911 set_tty_hooks.
7912
dca4927e
EZ
79132011-08-27 Eli Zaretskii <eliz@gnu.org>
7914
7915 * xdisp.c (move_it_to): Don't bail out early when reaching
7916 position beyond to_charpos, if we are scanning backwards.
7917 (move_it_vertically_backward): When DY == 0, make sure we get to
7918 the first character in the line after the newline.
7919
f2cad773
PE
79202011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7921
7922 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7923 (ccl_driver): Do not generate an out-of-range pointer.
7924 (Fccl_execute_on_string): Remove unnecessary check for
7925 integer overflow, noted by Stefan Monnier in
7926 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7927 Remove a FIXME that didn't need fixing.
7928 Simplify the newly-introduced buffer reallocation code.
7929
0cae2cdb
JB
79302011-08-27 Juanma Barranquero <lekktu@gmail.com>
7931
7932 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7933
5fc295a4 79342011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7935
70c60eb2 7936 Integer and memory overflow issues (Bug#9196).
726e0ab1 7937
d31850da
PE
7938 * doc.c (get_doc_string): Rework so that
7939 get_doc_string_buffer_size is the actual buffer size, rather than
7940 being 1 less than the actual buffer size; this makes xpalloc more
7941 convenient.
7942
a69fbedb
PE
7943 * image.c (x_allocate_bitmap_record, cache_image):
7944 * xselect.c (Fx_register_dnd_atom):
7945 Simplify previous changes by using xpalloc.
7946
fe5c5d37
PE
7947 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7948 since either will do and ptrdiff_t is convenient with xpalloc.
7949
0065d054
PE
7950 * charset.c (charset_table_size)
7951 (struct charset_sort_data.priority): Now ptrdiff_t.
7952 (charset_compare): Don't overflow if priorities differ greatly.
7953 (Fsort_charsets): Don't assume list length fits in int.
7954 Check for size-calculation overflow when allocating sort data.
7955 (syms_of_charset): Allocate an initial charset table that is
7956 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7957
7958 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7959
7960 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7961 The actual value is always <= INT_MAX, and leaving it unsigned made
7962 overflow checking harder.
7963
7964 * dispextern.h (struct glyph_matrix.rows_allocated)
7965 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7966 with xpalloc. The values are still always <= INT_MAX.
7967
7968 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7969
7970 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7971 (SAFE_NALLOCA): New macro.
7972
7973 * region-cache.c (struct boundary.pos, find_cache_boundary)
7974 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7975 (set_cache_region, invalidate_region_cache)
7976 (revalidate_region_cache, know_region_cache, region_cache_forward)
7977 (region_cache_backward, pp_cache):
7978 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7979 so that ptrdiff_t * can be passed to xpalloc.
7980 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7981 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7982 (pp_cache): Don't assume cache_len fits in int.
7983 * region-cache.h: Adjust extern decls to match.
7984
7985 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7986 EMACS_INT, since either will do, for xpalloc.
7987
7988 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7989 (xnmalloc, xnrealloc, xpalloc): New functions.
7990
726e0ab1
PE
7991 * bidi.c (bidi_shelve_header_size): New constant.
7992 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7993 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7994
51f30bc5 7995 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7996 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7997 (overlay_strings):
7998 Don't update size of array until after memory allocation succeeds,
7999 because xmalloc/xrealloc may not return.
0065d054
PE
8000 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8001 now that we have proper integer overflow checking.
8002 (record_overlay_string, overlay_strings): Catch overflows when
8003 calculating size of overlay_str_buf.
726e0ab1 8004
0065d054
PE
8005 * callproc.c (Fcall_process): Check for size overflow when
8006 calculating size of args2.
8007 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8008 Normally we prefer signed values, but sticking with ptrdiff_t would
8009 require adding more-complicated checks.
726e0ab1
PE
8010
8011 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8012 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8013 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8014 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8015
8016 * character.c (Fstring): Check for size-calculation overflow.
8017
8018 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8019 unnecessary integer overflow. Check for size overflow.
8020 (encode_coding_object): Don't update size until xmalloc succeeds.
8021
8022 * composite.c (get_composition_id): Check for overflow in glyph
8023 length calculations.
8024
8025 Integer and memory overflow fixes for display code.
8026 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8027 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8028 (scrolling_window): Check for overflow in size calculations.
8029 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8030 Don't assume glyph table len fits in int.
8031 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8032 (row_table_size): Now ptrdiff_t, not int.
8033 (scrolling_window): Avoid overflow in size calculations.
8034 Don't update size until allocation succeeds.
8035 * fns.c (concat): Check for overflow in size calculations.
8036 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8037 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8038 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8039
8040 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8041 (get_doc_string): Check for size calculation overflow.
8042 Don't update size until allocation succeeds.
8043 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8044 EMACS_INT, where ptrdiff_t will do.
8045 (Fsubstitute_command_keys): Check for string overflow.
8046
8047 * editfns.c (set_time_zone_rule): Don't assume environment length
8048 fits in int.
8049 (message_length): Now ptrdiff_t, not int.
8050 (Fmessage_box): Don't update size until allocation succeeds.
8051 Don't assume message length fits in int.
8052 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8053
0065d054
PE
8054 * emacs.c (main): Do not reallocate argv, since there is a null at
8055 the end that can be overwritten, and this way there's no need to
8056 worry about size-calculation overflow.
8057 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8058
8059 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8060 alloc succeeds.
8061 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8062
8063 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8064 (x_set_scroll_bar_width, x_figure_window_size):
8065 Check for integer overflow.
8066 (x_set_alpha): Do not assume XINT fits in int.
8067
8068 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8069 This is for the members text_lines, text_cols, total_lines, total_cols,
8070 where the system imposes an 'int' limit.
8071
8072 * fringe.c (Fdefine_fringe_bitmap):
8073 Don't update size until alloc works.
8074
8075 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8076 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8077
8078 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8079 Check for size-calculation overflow.
8080 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8081 do, as we prefer signed integers.
8082 (id_to_widget.max_size, id_to_widget.used)
8083 (xg_store_widget_in_map, xg_remove_widget_from_map)
8084 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8085 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8086 Use and return ptrdiff_t, not int.
8087 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8088 * gtkutil.h: Change prototypes to match the above.
8089
8090 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8091 are duplicate now that they've been promoted to lisp.h.
8092 (x_allocate_bitmap_record, x_alloc_image_color)
8093 (make_image_cache, cache_image, xpm_load):
8094 Don't update size until alloc is done.
8095 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8096 (x_detect_edges):
3256efce 8097 Check for size calculation overflow.
726e0ab1
PE
8098 (ct_colors_allocated_max): New constant.
8099 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8100 overflow.
3256efce 8101
726e0ab1
PE
8102 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8103 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8104 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8105 Use ptrdiff_t, not int, to count maps.
8106 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8107 calculations. Don't update size until allocation succeeds.
8108 Redo calculations to avoid overflow.
726e0ab1
PE
8109 * keyboard.h: Change prototypes to match the above.
8110
8111 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8112 to count maps.
8113 (current_minor_maps): Check for size calculation overflow.
8114 * keymap.h: Change prototypes to match the above.
8115
8116 * lread.c (read1, init_obarray): Don't update size until alloc done.
8117
8118 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8119 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8120
726e0ab1
PE
8121 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8122 Now ptrdiff_t, not int.
8123 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8124 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8125
8126 * process.c (Fnetwork_interface_list): Check for overflow
8127 in size calculation.
8128
8129 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8130
8131 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8132 overflow. Don't bother calling xmalloc when xrealloc will do.
8133
8134 * search.c (Freplace_match): Check for size calculation overflow.
8135 (Fset_match_data): Don't assume list lengths fit in 'int'.
8136
8137 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8138 for command line length. Do not attempt to address one before the
8139 beginning of an array, as that's not portable.
8140
8141 * term.c (max_frame_lines): Remove; unused.
8142 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8143 not int.
8144 (encode_terminal_code, calculate_costs): Check for size
8145 calculation overflow.
8146 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8147 table lengths and related sizes. Don't update size until alloc
8148 done. Redo calculations to avoid overflow.
8149 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8150
8151 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8152 subtracting pointers.
8153 (gobble_line): Check for overflow more carefully. Don't update size
8154 until alloc done.
8155
8156 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8157 Don't update size until alloc done.
8158 Redo size calculations to avoid overflow.
8159 Check for size calculation overflow.
0065d054 8160 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8161
8162 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8163 Use ptrdiff_t, not int, for sizes.
8164 (store_mode_line_noprop_char): Don't update size until alloc done.
8165
0065d054
PE
8166 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8167 Use ptrdiff_t, not int, for sizes.
8168 (Finternal_make_lisp_face, cache_face):
8169 Check for size calculation overflow.
8170 (cache_face): Treat size calculation overflows as if they were
8171 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8172
8173 * xfns.c (x_encode_text, x_set_name_internal)
8174 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8175 sizes, since they can exceed INT_MAX in size. Check for size
8176 calculation overflow.
8177
0065d054
PE
8178 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8179 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8180 Don't update size until alloc done.
8181
0065d054 8182 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8183 as sprintf is limited to int lengths.
1d526e2f 8184
252c5ee1
PE
8185 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8186 (X_LONG_MIN): New macros.
864d7ce7
PE
8187 Use them to make the following changes clearer.
8188 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8189 This change doesn't affect the value now, but it may help remind
8190 future maintainers not to raise the value too much later.
8191 (SELECTION_QUANTUM): Remove, replacing with ...
8192 (selection_quantum): ... new function, which avoids overflow.
8193 All uses changed.
8194 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8195 assumption that selection length fits in 'int'.
8196 (x_reply_selection_request, x_handle_selection_request)
8197 (x_get_window_property, receive_incremental_selection)
8198 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8199 (lisp_data_to_selection_data, clean_local_selection_data):
8200 Use ptrdiff_t, not int, to record length of selection.
8201 (x_reply_selection_request, x_get_window_property)
8202 (receive_incremental_selection, x_property_data_to_lisp):
8203 Redo calculations to avoid overflow.
8204 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8205 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8206 something.
8207 (x_get_window_property, receive_incremental_selection)
8208 (lisp_data_to_selection_data, x_property_data_to_lisp):
8209 Check for size-calculation overflow.
8210 (x_get_window_property, receive_incremental_selection)
8211 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8212 Don't store size until memory allocation succeeds.
8213 (x_get_window_property): Plug memory leak on memory exhaustion.
8214 Don't double-block input; malloc is safe here. Don't assume 2**34
8215 - 4 fits in unsigned long. Add an xassert to check
8216 XGetWindowProperty overflow. Be more careful about overflow
8217 calculations, and distinguish size from memory overflow better.
8218 (receive_incremental_selection): When tracing, don't assume
8219 unsigned int is less than INT_MAX.
8220 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8221 harmful) conversions of unsigned short to int.
8222 (lisp_data_to_selection_data): Don't assume that integers
8223 in the range -65535 through -1 fit in an X unsigned short.
8224 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8225 result parameters unless successful. Rely on cons_to_unsigned
8226 to report problems with elements; the old code wasn't right anyway.
8227 (x_check_property_data): Check for int overflow; we cannot use
8228 a wider type due to X limits.
8229 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8230
726e0ab1 8231 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8232
0065d054
PE
8233 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8234 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8235 (x_color_cells): Don't store size until memory allocation succeeds.
8236 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8237 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8238 (x_term_init): Don't assume length fits in int (sprintf is limited
8239 to int size).
bc18e09d 8240
ebfa62c0
PE
8241 Use ptrdiff_t for composition IDs.
8242 * character.c (lisp_string_width):
8243 * composite.c (composition_table_size, n_compositions)
8244 (get_composition_id, composition_gstring_from_id):
8245 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8246 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8247 * window.c (Frecenter):
8248 Use ptrdiff_t, not int, for composition IDs.
8249 * composite.c (get_composition_id): Check for integer overflow.
8250 * composite.h: Adjust prototypes to match the above changes.
8251
d3411f89
PE
8252 Use ptrdiff_t for hash table indexes.
8253 * category.c (hash_get_category_set):
8254 * ccl.c (ccl_driver):
8255 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8256 * coding.c (coding_system_charset_list, detect_coding_system):
8257 * coding.h (struct coding_system.id):
8258 * composite.c (get_composition_id, gstring_lookup_cache):
8259 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8260 * image.c (xpm_get_color_table_h):
8261 * lisp.h (hash_lookup, hash_put):
8262 * minibuf.c (Ftest_completion):
8263 Use ptrdiff_t for hash table indexes, not int (which is too
8264 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8265 32-bit --with-wide-int hosts).
8266
e097a6fa
PE
8267 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8268 Add a FIXME comment about memory leaks.
8269 (syms_of_charset): Don't assume xmalloc returns.
8270
5637687f
PE
8271 Don't assume that stated character widths fit in int.
8272 * character.c (Fchar_width, c_string_width, lisp_string_width):
8273 * character.h (CHAR_WIDTH):
8274 * indent.c (MULTIBYTE_BYTES_WIDTH):
8275 Use sanitize_char_width to avoid undefined and/or bad behavior
8276 with outlandish widths.
a66cfb1c 8277 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8278 now that we have two such functions. All uses changed.
8279 (sanitize_char_width): New inline function.
8280
a2271ba2
PE
8281 Don't assume that tab-width fits in int.
8282 * character.h (sanitize_width): New inline function.
8283 (SANE_TAB_WIDTH): New macro.
8284 (ASCII_CHAR_WIDTH): Use it.
8285 * indent.c (sane_tab_width): Remove. All uses replaced by
8286 SANE_TAB_WIDTH (current_buffer).
8287 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8288
18c52557
PE
8289 * fileio.c: Integer overflow issues with file modes.
8290 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8291
caeeedc1
PE
8292 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8293 Remove unreachable code.
8294 (read_hex, load_charset_map_from_file): Check for integer overflow.
8295
6df6ae42 8296 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8297 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8298 (x_send_scroll_bar_event): Likewise. Check that the size does not
8299 exceed limits imposed by XClientMessageEvent, as well as the usual
8300 ptrdiff_t and size_t limits.
8301
b13995db
PE
8302 * keyboard.c: Overflow, signedness and related fixes.
8303 (make_lispy_movement): Use same integer type in forward decl
8304 that is used in the definition.
8305 (read_key_sequence, keyremap_step):
8306 Change bufsize argument back to int, undoing my 2011-03-30 change.
8307 We prefer signed types, and int is wide enough here.
8308 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8309 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8310 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8311 length, not size_t. Use ptrdiff_t for index, not int.
8312 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8313 possibility of integer overflow.
8314
13464394
PE
8315 Overflow, signedness and related fixes for images.
8316
8317 * dispextern.h (struct it.stack[0].u.image.image_id)
8318 (struct_it.image_id, struct image.id, struct image_cache.size)
8319 (struct image_cache.used, struct image_cache.ref_count):
8320 * gtkutil.c (update_frame_tool_bar):
8321 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8322 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8323 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8324 * nsmenu.m (update_frame_tool_bar):
8325 * xdisp.c (calc_pixel_width_or_height):
8326 * xfns.c (image_cache_refcount):
8327 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8328 on typical 64-bit hosts.
8329
8330 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8331 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8332 Omit unnecessary casts to int.
8333 (parse_image_spec): Check that integers fall into 'int' range
8334 when the callers expect that.
8335 (image_ascent): Redo ascent calculation to avoid int overflow.
8336 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8337 (lookup_image): Remove unnecessary tests.
8338 (xbm_image_p): Locals are now of int, not EMACS_INT,
8339 since parse_image_check makes sure they fit into int.
8340 (png_load, gif_load, svg_load_image):
8341 Prefer int to unsigned where either will do.
8342 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8343 old tiff_error_handler and tiff_warning_handler.
8344 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8345 stack buffer overflows. It uses only the features of vsnprintf
8346 that are common to both POSIX and native Microsoft.
8347 (tiff_error_handler, tiff_warning_handler): Use it.
8348 (tiff_load, gif_load, imagemagick_load_image):
8349 Don't assume :index value fits in 'int'.
8350 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8351 (imagemagick_load_image): Check that crop parameters fit into
8352 the integer types that MagickCropImage accepts. Don't assume
8353 Vimagemagick_render_type has a nonnegative value. Don't assume
8354 size_t fits in 'long'.
8355 (gs_load): Use printmax_t to print the widest integers possible.
8356 Check for integer overflow when computing image height and width.
8357
c11821d4
EZ
83582011-08-26 Eli Zaretskii <eliz@gnu.org>
8359
8360 * xdisp.c (redisplay_window): Don't force window start if point
8361 will be invisible in the resulting window. (Bug#9324)
8362
0c95fcf7
EZ
83632011-08-25 Eli Zaretskii <eliz@gnu.org>
8364
8365 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8366 the display spec is of the form `(space ...)'.
8367 (handle_display_spec): Return the value returned by
8368 handle_single_display_spec, not just 1 or zero.
8369 (handle_single_display_spec): If the display spec is of the form
8370 `(space ...)', and specifies display in the text area, return 2
8371 rather than 1.
fee65a97 8372 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8373 accurately, and prefer exact match for point under bidi.
8374 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8375
8376 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8377 into disp_prop; all users changed.
8378
8379 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8380 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8381 for the text covered by the display property.
8382
e4ed06f1
CY
83832011-08-25 Chong Yidong <cyd@stupidchicken.com>
8384
8385 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8386 Change return value to nil.
8387 (Frecord_buffer): Delete unused function.
8388
f67cdd7f
EZ
83892011-08-24 Eli Zaretskii <eliz@gnu.org>
8390
5980d4c6
EZ
8391 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8392 buffers, return left-to-right.
8610fe8b
EZ
8393 (set_cursor_from_row): Consider candidate row a win if its glyph
8394 represents a newline and point is on that newline. Fixes cursor
8395 positioning on the newline at EOL of R2L text within L2R
8396 paragraph, and vice versa.
8397 (try_cursor_movement): Check continued rows, in addition to
8398 continuation rows. Fixes unwarranted scroll when point enters a
8399 continued line of R2L text within an L2R paragraph, or vice versa.
8400 (cursor_row_p): Consider the case of point being equal to
8401 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8402 from the end of a short line to the beginning of a continued line
8403 of R2L text within L2R paragraph.
8404 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8405 composed characters.
5980d4c6 8406
f67cdd7f
EZ
8407 * bidi.c (bidi_check_type): Use xassert.
8408 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8409 members.
8410
bca633fb
EZ
84112011-08-23 Eli Zaretskii <eliz@gnu.org>
8412
8413 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8414 a character.
8415
4a5885a7
CY
84162011-08-23 Chong Yidong <cyd@stupidchicken.com>
8417
8418 * nsfont.m (ns_otf_to_script): Fix typo.
8419
0902a04e
KH
84202011-08-22 Kenichi Handa <handa@m17n.org>
8421
8422 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8423 extra slot even if the purpose is char-code-property-table.
8424
1a2e6670
EZ
84252011-08-23 Eli Zaretskii <eliz@gnu.org>
8426
8ddde651
EZ
8427 * xdisp.c (redisplay_window): When computing centering_position,
8428 account for the height of the header line. (Bug#8874)
8429
425cc014
EZ
8430 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8431 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8432 candidate is selected by the mouse, and that candidate has a
8433 composed character under the mouse.
8434
1a2e6670
EZ
8435 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8436 coordinates reported by pos-visible-in-window-p for a composed
8437 character in column zero.
8438
8b76d6f8
SM
84392011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8440
8441 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8442
dac347dd
EZ
84432011-08-22 Eli Zaretskii <eliz@gnu.org>
8444
8445 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8446 consider it a hit if to_charpos is anywhere in the range of the
8447 composed buffer positions.
8448
e013fb34
CY
84492011-08-22 Chong Yidong <cyd@stupidchicken.com>
8450
8451 * image.c (gif_load): Don't assume that each subimage has the same
8452 dimensions as the base image. Handle disposal method that is
8453 "undefined" by the gif spec (Bug#9335).
8454
bd1ba3e8
CY
84552011-08-20 Chong Yidong <cyd@stupidchicken.com>
8456
8457 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8458 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8459
54a1215b
EZ
84602011-08-19 Eli Zaretskii <eliz@gnu.org>
8461
823564e5
EZ
8462 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8463 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8464 from an Org mode buffer to a Speedbar frame.
8465
54a1215b
EZ
8466 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8467 a composition, take its buffer position from IT->cmp_it.charpos.
8468 Fixes cursor positioning at the beginning of a line that begins
8469 with a composed character.
8470
9778ebcc
EZ
84712011-08-18 Eli Zaretskii <eliz@gnu.org>
8472
0be6ee06
EZ
8473 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8474 character bidirectional type, use STRONG_L instead. Fixes crashes
8475 in a buffer produced by `describe-categories'.
8476
9778ebcc
EZ
8477 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8478 members before the level stack, so they would be saved and
8479 restored when copying iterator state. Fixes incorrect reordering
8480 around TABs covered by display properties.
8481
156bffbe
AS
84822011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8483
6b02f655 8484 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8485
72ad093b
CY
84862011-08-17 Chong Yidong <cyd@stupidchicken.com>
8487
8488 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8489 (internal_condition_case_2, internal_condition_case_n):
8490 Remove unnecessary aborts (Bug#9081).
72ad093b 8491
35774242
EZ
84922011-08-17 Eli Zaretskii <eliz@gnu.org>
8493
8494 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8495 has no `load' handler, try opening the file locally. (Bug#9311)
8496
db76dd85
KB
84972011-08-16 Ken Brown <kbrown@cornell.edu>
8498
8499 * gmalloc.c: Expand comment.
8500
b215eee5
EZ
85012011-08-16 Eli Zaretskii <eliz@gnu.org>
8502
8503 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8504 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8505
a4579d33
KB
85062011-08-16 Ken Brown <kbrown@cornell.edu>
8507
8508 Fix memory allocation problems in Cygwin build (Bug#9273).
8509
8510 * unexcw.c ( __malloc_initialized): Declare external variable.
8511 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8512
8b76d6f8
SM
8513 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8514 New variables.
a4579d33
KB
8515 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8516 dumped emacs.
8517 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8518 in the static heap.
8519 [CYGWIN] (special_realloc): New function.
8520 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8521 requests to realloc storage in the static heap.
8522
3ebec551
PE
85232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8524
8525 * bidi.c (bidi_initialize): Remove unused local.
8526
9fd8be00
EZ
85272011-08-15 Eli Zaretskii <eliz@gnu.org>
8528
6b02f655
SM
8529 * bidimirror.h:
8530 * biditype.h: Remove file.
8531 * makefile.w32-in ($(BLD)/bidi.$(O)):
8532 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8533
8534 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8535
8536 * chartab.c: Improve commentary for the uniprop_table API.
8537
32413314
EZ
8538 * bidi.c (bidi_paragraph_init): Support zero value of
8539 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8540 (bidi_initialize): Use uniprop_table instead of including
8541 biditype.h and bidimirror.h.
32413314 8542
9fd8be00
EZ
8543 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8544 coordinates of the iterator when restoring from ppos_it.
8545 (Bug#9296)
8546
5cf2b69b
KH
85472011-08-14 Kenichi Handa <handa@m17n.org>
8548
8549 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8550 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8551
daf17d00
EZ
85522011-08-14 Eli Zaretskii <eliz@gnu.org>
8553
8554 * xdisp.c (move_it_in_display_line_to): Don't invoke
8555 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8556 ppos_it. Fixes vertical cursor motion when line beginning is
8557 covered by an image. (Bug#9296)
8558
08e3161a
JD
85592011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8560
8561 * nsterm.h (ns_run_ascript): Declare.
8562 (NSAPP_DATA2_RUNASSCRIPT): Define.
8563
8564 * nsfns.m (as_script, as_result, as_status): New static variables.
8565 (ns_run_ascript): New function.
5e617bc2 8566 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8567 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8568 the event loop. Get status from as_status (Bug#7276).
8569
8570 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8571 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8572 the event loop (Bug#7276).
8573
a3720aa2
AS
85742011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8575
8576 * gnutls.c (QCgnutls_bootprop_priority)
8577 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8578 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8579 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8580 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8581 (QCgnutls_bootprop_verify_hostname_error)
8582 (QCgnutls_bootprop_callbacks_verify): Rename from
8583 Qgnutls_bootprop_..., all uses changed.
8584
8585 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8586 uses changed.
8587
0a0d27fb
PE
85882011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8589
19d5c50c
PE
8590 * xfaces.c (Qframe_set_background_mode): Now static.
8591 * dispextern.h (Qframe_set_background_mode): Remove decl.
8592
0a0d27fb
PE
8593 * process.c (Fnetwork_interface_info): Declare local only if needed.
8594
377538cb
JD
85952011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8598 (Fnetwork_interface_list): Allocate in increments of bytes instead
8599 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8600 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8601 sockaddr.
8602 (struct ifflag_def): notrailers is smart on OSX.
8603 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8604 Get hardware address with getifaddrs if available.
8605
08fff70c
EZ
86062011-08-12 Eli Zaretskii <eliz@gnu.org>
8607
8608 * xdisp.c (iterate_out_of_display_property): xassert that
8609 IT->position is set to within IT->object's boundaries. Break from
8610 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8611 when IT->position is set up wrongly due to some bug.
8612 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8613 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8614 entry. Force push_it to save on the stack the current
8615 buffer/string position, to be restored by pop_it. Fix flags in
8616 the iterator structure wrt the object coming from a display
8617 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8618 properties. (Bug#9284)
8619
7be1c708 86202011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8621
7be1c708
CY
8622 * fontset.c (fontset_get_font_group): Add proper type checks.
8623 (Bug#9172)
aac0c6e3 8624
7be1c708 86252011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8626
7be1c708
CY
8627 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8628 and LC_VERSION_MIN_MACOSX.
8629 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8630 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8631
97bb72a6
EZ
86322011-08-08 Eli Zaretskii <eliz@gnu.org>
8633
8634 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8635 no-display-properties-and-no-overlays under bidi display.
8636 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8637 properties and overlays.
97bb72a6 8638
d5617611
CY
86392011-08-08 Chong Yidong <cyd@stupidchicken.com>
8640
37e11a63
CY
8641 * editfns.c (Fset_time_zone_rule): Document relationship with the
8642 setenv function.
8643
d5617611
CY
8644 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8645 the font entity extracted from the cache (Bug#8109).
8646
58872834
CY
86472011-08-07 Chong Yidong <cyd@stupidchicken.com>
8648
8649 * composite.c (autocmp_chars): Don't reset point. That is done by
8650 restore_point_unwind (Bug#5984).
8651
75bfc667
JL
86522011-08-07 Juri Linkov <juri@jurta.org>
8653
8654 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8655 to show the arg `TIME' instead of `TIMEVAL'.
8656
d1410150
EZ
86572011-08-06 Eli Zaretskii <eliz@gnu.org>
8658
8659 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8660 display property strides EOL and includes a newline, as in
8661 longlines-mode. (Bug#9254)
75b771e4
EZ
8662 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8663 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8664
8665 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8666 is non-zero, even if the data buffer is NULL. Fixes a crash in
8667 vertical-motion with longlines-mode. (Bug#9254)
8668
35928349
EZ
86692011-08-05 Eli Zaretskii <eliz@gnu.org>
8670
ec7cc85b
EZ
8671 * bidi.c <bidi_cache_total_alloc>: Now static.
8672 (bidi_initialize): Initialize bidi_cache_total_alloc.
8673
8b76d6f8 8674 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8675 cache. (Bug#9221)
8676
8677 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8678 amount allocated this far in `bidi_cache_total_alloc'.
8679 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8680 non-zero, only free the data buffer without restoring the cache
8681 contents. All callers changed.
8682
8683 * dispextern.h (bidi_unshelve_cache): Update prototype.
8684
8685 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8686 (move_it_in_display_line, move_it_to)
8687 (move_it_vertically_backward, move_it_by_lines): Replace the call
8688 to xfree to an equivalent call to bidi_unshelve_cache.
8689 (move_it_in_display_line_to): Fix logic of returning
412b6358 8690 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8691
e2e2423b
EZ
86922011-08-05 Eli Zaretskii <eliz@gnu.org>
8693
8694 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8695 came from a string character with a `cursor' property. (Bug#9229)
8696
ae9e757a
JD
86972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8698
8699 * Makefile.in (LIB_PTHREAD): New variable.
8700 (LIBES): Add LIB_PTHREAD (Bug#9216).
8701
8702 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8703 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8704
213bd7f2
AS
87052011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8706
6b02f655 8707 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8708
99aaf75f
JD
87092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8710
8711 * xterm.c (x_find_topmost_parent): New function.
8712 (x_set_frame_alpha): Find topmost parent window with
8713 x_find_topmost_parent and set the property there also (bug#9181).
8714 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8715
c74e9d86
PE
87162011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8717
8718 * callproc.c (Fcall_process): Avoid vfork clobbering
8719 the local vars buffer, coding_systems, current_dir.
8720
640c8776
SM
87212011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8722
8723 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8724
f26d0e4c
PE
87252011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8726
8a10d76c
PE
8727 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8728 so that it is not optimized away.
8729
f26d0e4c
PE
8730 * xdisp.c (compute_display_string_pos): Remove unused local.
8731
55439c61
EZ
87322011-08-02 Eli Zaretskii <eliz@gnu.org>
8733
8734 Fix slow cursor motion and scrolling in large buffers with
8735 selective display, like Org Mode buffers. (Bug#9218)
8736
8737 * dispextern.h (struct bidi_it): New member disp_prop_p.
8738
8739 * xdisp.c: Remove one-slot cache of display string positions.
8740 (compute_display_string_pos): Accept an additional argument
5e617bc2 8741 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8742 for a display string or property. If found, set DISP_PROP_P
8743 non-zero.
8744
8745 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8746 DISP_PROP_P, and pass it to compute_display_string_pos.
8747 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8748 non-zero. All callers of bidi_fetch_char changed.
8749
fb33fa43
SM
87502011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8751
8752 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8753
b099e063
DM
87542010-12-03 Don March <don@ohspite.net>
8755
8756 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8757 last character M-[char] is translated to ESC [char] (bug#7541).
8758
5cc7f7af
KH
87592011-08-02 Kenichi Handa <handa@m17n.org>
8760
d0fffa3f 8761 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8762
8763 * chartab.c (uniprop_table): Make it non-static.
8764
525d5e6e
EZ
87652011-08-01 Eli Zaretskii <eliz@gnu.org>
8766
8767 * xdisp.c (forward_to_next_line_start): Accept additional argument
8768 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8769 on the newline.
8770 (reseat_at_next_visible_line_start): Use the bidi iterator state
8771 returned by forward_to_next_line_start to restore the state of
8772 it->bidi_it after backing up to previous newline. (Bug#9212)
8773
31011111
AS
87742011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8775
8776 * regex.c (re_comp): Protoize.
8777 (re_exec): Fix return type.
8778 (regexec): Fix type of `ret'. (Bug#9203)
8779
476371c4
PE
87802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8781
e5d76069
PE
8782 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8783 This is needed if max-image-size is a floating-point number.
8784
9a79b20c
AS
87852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8786
8787 * print.c (print_object): Print empty symbol as ##.
8788
8789 * lread.c (read1): Read ## as empty symbol.
8790
d8c2fa78
AA
87912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8792
8793 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8794 setting frame foreground color (Bug#9175).
8795 (x_set_background_color): Likewise.
8796
ffe57a7a
AA
8797 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8798 contents (Bug#9176).
8799 (EmacsTooltip -init): Remove bezels and add shadows to
8800 tooltip windows.
8801
bf3492a5
AA
8802 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8803 or scroll bar (Bug#8470).
8804
d55e9c53
AA
8805 * nsfont.m (nsfont_open): Remove assignment to voffset and
8806 unnecessary vars hshink, expand, hd, full_height, min_height.
8807 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8808
8809 * nsterm.h (nsfont_info): Remove voffset field.
8810
d8c2fa78 88112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8812
8813 Implement strike-through and overline on NextStep (Bug#8863).
8814
8815 * nsfont.m (nsfont_open): Use underline position provided by font,
8816 instead of hard-coded value of 2.
8817 (nsfont_draw): Call ns_draw_text_decoration instead.
8818
8819 * nsterm.h: Add declaration for ns_draw_text_decoration.
8820
8821 * nsterm.m (ns_draw_text_decoration): New function for drawing
8822 underline, overline, and strike-through.
8823 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8824 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8825 accommodate underlining, etc.
4843aac3 8826
4cc60b9b
EZ
88272011-07-28 Eli Zaretskii <eliz@gnu.org>
8828
bc7ece87
EZ
8829 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8830 default.
4cc60b9b 8831
476371c4
PE
88322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8833
66606eea
PE
8834 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8835 Without this fix, if a signal arrives just after memory fills up,
8836 'malloc' might be invoked reentrantly.
8837
476371c4
PE
8838 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8839 In other words, assume that every image size is allowed, on non-X
8840 hosts. This assumption is probably wrong, but it lets Emacs compile.
8841
f3fcc40d
AS
88422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8843
8844 * regex.c (re_iswctype): Convert return values to boolean.
8845
350c992f
EZ
88462011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8847
8848 * xdisp.c (compute_display_string_pos): Don't use cached display
8849 string position if the buffer had its restriction changed.
8850 (Bug#9184)
8851
5266b4bb
PE
88522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8853
8854 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8855
2573a837 88562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8857
41f55ccd 8858 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8859
39e378da
PE
8860 * bidi.c: Integer size and overflow fixes.
8861 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8862 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8863 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8864 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8865 (bidi_find_other_level_edge):
8866 Use ptrdiff_t instead of EMACS_INT where either will do.
8867 This works better on 32-bit hosts configured --with-wide-int.
8868 (bidi_cache_ensure_space): Check for size-calculation overflow.
8869 Use % rather than repeated addition, for better worst-case speed.
8870 Don't set bidi_cache_size until after xrealloc returns, because it
8871 might not return.
8872 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8873 (bidi_cache_ensure_space): Also check that the bidi cache size
8874 does not exceed that of the largest Lisp string or buffer. See Eli
8875 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8876
5e927815
PE
8877 * alloc.c (__malloc_size_t): Remove.
8878 All uses replaced by size_t. See Andreas Schwab's note
8879 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8880
ca4aa935
PE
8881 * image.c: Improve checking for integer overflow.
8882 (check_image_size): Assume that f is nonnull, since
8883 it is always nonnull in practice. This is one less thing to
8884 worry about when checking for integer overflow later.
8885 (x_check_image_size): New function, which checks for integer
8886 overflow issues inside X.
8887 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8888 This removes the need for a memory_full check.
8889 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8890 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8891 (xbm_read_bitmap_data): Change locals back to 'int', since
8892 their values must fit in 'int'.
8893 (xpm_load_image, png_load, tiff_load):
8894 Invoke x_create_x_image_and_pixmap earlier,
8895 to avoid much needless work if the image is too large.
8896 (tiff_load): Treat overly large images as if
8897 x_create_x_image_and_pixmap failed, not as malloc failures.
8898 (gs_load): Use x_check_image_size.
8899
5f8f9cc2
PE
8900 * gtkutil.c: Omit integer casts.
8901 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8902 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8903
5adf60bc
PE
8904 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8905
c8907a93
PE
8906 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8907 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8908 would wrongly return t on a 64-bit host.
8909
e3c25c68
PE
8910 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8911 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8912 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8913 and therefore cause GCC to emit a bogus diagnostic in some cases.
8914
3f791afe
PE
8915 * image.c: Integer signedness and overflow and related fixes.
8916 This is not an exhaustive set of fixes, but it's time to
8917 record what I've got.
8918 (lookup_pixel_color, check_image_size): Remove redundant decls.
8919 (check_image_size): Don't assume that arbitrary EMACS_INT values
8920 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8921 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8922 (tiff_load, imagemagick_load_image):
8923 Check for overflow in size calculations.
8924 (x_create_x_image_and_pixmap): Remove unnecessary test for
8925 xmalloc returning NULL; that can't happen.
8926 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8927 (xpm_color_bucket): Use better integer hashing function.
8928 (xpm_cache_color): Don't possibly over-allocate memory.
8929 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8930 (gif_memory_source):
8931 Use ptrdiff_t, not int or size_t, to record sizes.
8932 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8933 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8934 either works, as we prefer signed integers.
8935 (tiff_read_from_memory, tiff_write_from_memory):
8936 Return tsize_t, not size_t, since that's what the TIFF API wants.
8937 (tiff_read_from_memory): Don't fail simply because the read would
8938 go past EOF; instead, return a short read.
8939 (tiff_load): Omit no-longer-needed casts.
8940 (Fimagemagick_types): Don't assume size fits into 'int'.
8941
3cc5a532
PE
8942 Improve hashing quality when configured --with-wide-int.
8943 * fns.c (hash_string): New function, taken from sxhash_string.
8944 Do not discard information about ASCII character case; this
8945 discarding is no longer needed.
8946 (sxhash-string): Use it. Change sig to match it. Caller changed.
8947 * lisp.h: Declare it.
8948 * lread.c (hash_string): Remove, since we now use fns.c's version.
8949 The fns.c version returns a wider integer if --with-wide-int is
8950 specified, so this should help the quality of the hashing a bit.
8951
b312a492
PE
8952 * emacs.c: Integer overflow minor fix.
8953 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8954 Define only if GNU_LINUX.
8955 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8956
dfd153ae
PE
8957 * dispnew.c: Integer signedness and overflow fixes.
8958 Remove unnecessary forward decls, that were a maintenance hassle.
8959 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8960 All uses changed.
8961 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8962 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8963 (prepare_desired_row, line_draw_cost):
8964 Use int, not unsigned, where either works.
8965 (save_current_matrix, restore_current_matrix):
8966 Use ptrdiff_t, not size_t, where either works.
8967 (init_display): Check for overflow more accurately, and without
8968 relying on undefined behavior.
8969
a81d11a3
PE
8970 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8971 Remove, replacing with the new symbols in lisp.h. All uses changed.
8972 * fileio.c (make_temp_name):
8973 * filelock.c (lock_file_1, lock_file):
8974 * xdisp.c (message_dolog):
8975 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8976 Use pMd etc. instead.
8977 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8978 replacing the pWIDE etc. symbols removed from editfns.c.
8979
3300e6fd
PE
8980 * keyboard.h (num_input_events): Now uintmax_t.
8981 This is (very slightly) less likely to mess up due to wraparound.
8982 All uses changed.
8983
fd05c7e9
PE
8984 * buffer.c: Integer signedness fixes.
8985 (alloc_buffer_text, enlarge_buffer_text):
8986 Use ptrdiff_t rather than size_t when either will do, as we prefer
8987 signed integers.
8988
903fe15d
PE
8989 * alloc.c: Integer signedness and overflow fixes.
8990 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8991 (__malloc_size_t): Default to size_t, not to int.
8992 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8993 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8994 Prefer ptrdiff_t to size_t when either would do, as we prefer
8995 signed integers.
8996 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8997 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8998 Now const. Initialize with values that are in range even if char
8999 is signed.
9000 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9001 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9002 These functions do the right thing with sizes > 2**32.
9003 (check_depth): Now ptrdiff_t, not int.
9004 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9005 Adjust to new way of storing sizes. Check for size overflow bugs
9006 in rest of code.
9007 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9008 slightly wrong anyway, as it missed one instance of
9009 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9010 (refill_memory_reserve): Omit needless cast to size_t.
9011 (mark_object_loop_halt): Mark as externally visible.
9012
ac82cc6a
PE
9013 * xselect.c: Integer signedness and overflow fixes.
9014 (Fx_register_dnd_atom, x_handle_dnd_message):
9015 Use ptrdiff_t, not size_t, since we prefer signed.
9016 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9017 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9018 x_dnd_atoms_size and x_dnd_atoms_length.
9019
c2d1e36d
PE
9020 * doprnt.c: Prefer signed to unsigned when either works.
9021 * eval.c (verror):
9022 * doprnt.c (doprnt):
9023 * lisp.h (doprnt):
9024 * xdisp.c (vmessage):
9025 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9026 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9027 prefer signed arithmetic to avoid comparison confusion.
9028 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9029 but is a bit tricky.
9030
0e926e56
PE
9031 Assume freestanding C89 headers, string.h, stdlib.h.
9032 * data.c, doprnt.c, floatfns.c, print.c:
9033 Include float.h unconditionally.
9034 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9035 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9036 * regex.c: Likewise for stddef.h, string.h.
9037 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9038 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9039 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9040 (STDC_HEADERS): Remove obsolete defines.
9041 * sysdep.c: Include limits.h unconditionally.
9042
9cfdb3ec
PE
9043 Assume support for memcmp, memcpy, memmove, memset.
9044 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9045 * regex.c (memcmp, memcpy):
9046 Remove; we assume C89 now.
9047
9048 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9049 (__malloc_safe_bcopy): Remove; no longer needed.
9050
cf950e6b 9051 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9052 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9053 well either way, and we prefer signed to unsigned.
9054
dbf38e02
LMI
90552011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9056
9057 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9058 closes the connection while we're reading (bug#9182).
9059
d6f0886c 90602011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9061
d6f0886c
JD
9062 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9063 are specified (Bug#9168).
24e0f6b1 9064
2eb1f9e6
PE
90652011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9066
9067 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9068 Found by GCC static checking and --with-wide-int on a 32-bit host.
9069
22381272 90702011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9071
9072 * xdisp.c (compute_display_string_pos): Fix logic of caching
9073 previous display string position. Initialize cached_prev_pos to
9074 -1. Fixes slow-down at the beginning of a buffer.
9075
f25e39b4
EZ
90762011-07-24 Eli Zaretskii <eliz@gnu.org>
9077
9078 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9079 for attrs[LFACE_FONTSET_INDEX].
9080
04c4b52e
PE
90812011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9082
9083 * xml.c (parse_region): Remove unused local
9084 that was recently introduced.
9085
c1734fbd
EZ
90862011-07-23 Eli Zaretskii <eliz@gnu.org>
9087
be18c5a5
EZ
9088 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9089 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9090
c1734fbd
EZ
9091 * xdisp.c (move_it_in_display_line_to): Record the best matching
9092 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9093 exit if none of the characters scanned was an exact match.
9094 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9095 when exact match is impossible due to invisible text, and the
9096 lines are truncated.
9097
a258d627
JD
90982011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9099
9100 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9101 for OSX >= 10.7.
9102
b6d5a689
EZ
91032011-07-22 Eli Zaretskii <eliz@gnu.org>
9104
0f74f785
EZ
9105 Fix a significant slow-down of cursor motion with C-n, C-p,
9106 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9107 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9108 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9109 (next_element_from_buffer): Call compute_stop_pos_backwards to
9110 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9111 base_level_stop.
9112 (reseat): Don't look for prev_stop, as that could mean a very long
9113 run.
9114 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9115 <cached_disp_overlay_modiff>: Cache for last found display string
9116 position.
551918c1 9117 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9118 about the same buffer in the same area of character positions, and
9119 the buffer wasn't changed since the time the display string
9120 position was cached.
551918c1 9121
b2d0c91a
EZ
91222011-07-22 Eli Zaretskii <eliz@gnu.org>
9123
9124 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9125 is an integer, which is important for empty lines. (Bug#9149)
9126
043604ee
CY
91272011-07-22 Chong Yidong <cyd@stupidchicken.com>
9128
9129 * frame.c (Fmodify_frame_parameters): In tty case, update the
9130 default face if necessary (Bug#4238).
9131
da4adb04
CY
91322011-07-21 Chong Yidong <cyd@stupidchicken.com>
9133
9134 * editfns.c (Fstring_to_char): No need to explain what a character
9135 is in the docstring (Bug#6576).
9136
9abd0532
LMI
91372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9138
9139 * xml.c (parse_region): Make sure we always return a tree.
9140
36881d16
HK
91412011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9142
9143 * xml.c (parse_region): If a document contains only comments,
9144 return that, too.
9145
1e98674d
LMI
91462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9147
9148 * xml.c (make_dom): Return comments, too.
9149
590bd467
PE
91502011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9151
9152 Port to OpenBSD.
9153 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9154 and the surrounding thread.
9155 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9156 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9157 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9158 timer goes off.
9159 * s/openbsd.h (BROKEN_SIGIO): Define.
9160 * unexelf.c (unexec) [__OpenBSD__]:
9161 Don't update the .mdebug section of the Alpha COFF symbol table.
9162
f41628b2
LMI
91632011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9164
9165 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9166 (bug#8460).
9167
b59b67c5
PE
91682011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9169
15e3a074
PE
9170 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9171 This fixes some race conditions on the permissions of any newly
9172 created file.
9173
41bed37d
PE
9174 * alloc.c (valid_pointer_p): Use pipe, not open.
9175 This fixes some permissions issues when debugging.
9176
b59b67c5
PE
9177 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9178 If fchown fails to set both uid and gid, try to set just gid,
9179 as that is sometimes allowed. Adjust the file's mode to eliminate
9180 setuid or setgid bits that are inappropriate if fchown fails.
9181
925a6be7
SM
91822011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9183
9184 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9185 to compare Lisp_Objects.
9186 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9187 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9188 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9189
52968808
AS
91902011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9191
0a6a104b
AS
9192 * lread.c (read_integer): Unread even EOF character.
9193 (read1): Likewise. Properly record start position of symbol.
9194
52968808
AS
9195 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9196 symbol character follows.
9197
9e381cdd
PE
91982011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9199
9200 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9201 This works around a problem with the previous change to Fcopy_file.
9202 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9203 and without this change, GCC might complain about discarding
9204 fchown's return value.
9205
b5641435
JB
92062011-07-16 Juanma Barranquero <lekktu@gmail.com>
9207
9208 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9209
a8031457
PE
92102011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9211
9212 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9213
dd889327
LMI
92142011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9215
750c33f7
LMI
9216 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9217 it's used from the C level.
9218
dd889327
LMI
9219 * process.c: Use the same condition for POLL_FOR_INPUT in both
9220 keyboard.c and process.c (bug#1858).
9221
87e86684
LM
92222011-07-09 Lawrence Mitchell <wence@gmx.li>
9223
9224 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9225 (Fgnutls_boot): Use it.
9226
64348f40
AS
92272011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9228
9229 * doc.c (Fsubstitute_command_keys): Revert last change.
9230
1d698799
LMI
92312011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9232
f863868c
LMI
9233 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9234 quotes the next character, and doesn't affect other longer
9235 sequences (bug#8935).
9236
1d698799
LMI
9237 * lread.c (syms_of_lread): Clarify that is isn't only
9238 `eval-buffer' and `eval-defun' that's affected by
9239 `lexical-binding' (bug#8460).
9240
aa4b6df6
EZ
92412011-07-15 Eli Zaretskii <eliz@gnu.org>
9242
9243 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9244 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9245
5d856da6
PE
92462011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9247
ad6042bb
PE
9248 Fix minor problems found by static checking.
9249 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9250 (elsz): Now a signed constant, not a size_t var. We prefer signed
9251 types to unsigned, to avoid integer comparison confusion. Without
9252 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9253 "cannot optimize loop, the loop counter may overflow", a symptom
9254 of the confusion.
f00bbb22 9255 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9256 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9257
6468f31c
LMI
92582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9259
49080b10
LMI
9260 * search.c (Fre_search_backward): Mention `case-fold-search' in
9261 all the re_search_* functions (bug#8138).
9262
6468f31c
LMI
9263 * keyboard.c (Fopen_dribble_file): Document when the file is
9264 closed (bug#8056).
9265
c965adc5
EZ
92662011-07-14 Eli Zaretskii <eliz@gnu.org>
9267
df9733bf
EZ
9268 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9269 bidi_cache_idx.
9270
0bb23927
EZ
9271 Support bidi reordering of display and overlay strings.
9272 * xdisp.c (compute_display_string_pos)
9273 (compute_display_string_end): Accept additional argument STRING.
9274 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9275 (reseat_to_string): Initialize bidi_it->string.s and
9276 bidi_it->string.schars.
9277 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9278 NULL (avoids a crash in bidi_paragraph_init).
9279 Initialize itb.string.lstring.
0bb23927
EZ
9280 (init_iterator): Call bidi_init_it only of a valid
9281 buffer position was specified. Initialize paragraph_embedding to
9282 L2R.
9283 (reseat_to_string): Initialize the bidi iterator.
9284 (display_string): If we need to ignore text properties of
9285 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9286 original value of -1 will not work with bidi.)
9287 (compute_display_string_pos): First arg is now struct
9288 `text_pos *'; all callers changed. Support display properties on
9289 Lisp strings.
9290 (compute_display_string_end): Support display properties on Lisp
9291 strings.
9292 (init_iterator, reseat_1, reseat_to_string): Initialize the
9293 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9294 when iterating on a string not from display properties).
640c8776
SM
9295 (compute_display_string_pos, compute_display_string_end):
9296 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9297 arrow keys.
9298 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9299 base_level_stop; instead, set base_level_stop to BEGV.
9300 Fixes crashes in vertical-motion.
0bb23927
EZ
9301 (next_element_from_buffer): Improve commentary for when
9302 the iterator is before prev_stop.
9303 (init_iterator): Initialize bidi_p from the default value of
9304 bidi-display-reordering, not from buffer-local value. Use the
9305 buffer-local value only if initializing for buffer iteration.
9306 (handle_invisible_prop): Support invisible properties on strings
9307 that are being bidi-reordered.
9308 (set_iterator_to_next): Support bidi reordering of C strings and
9309 Lisp strings.
9310 (next_element_from_string): Support bidi reordering of Lisp
9311 strings.
9312 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9313 (display_string): Support display of R2L glyph rows.
9314 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9315 (init_iterator): Don't initialize it->bidi_p for strings
9316 here.
9317 (reseat_to_string): Initialize it->bidi_p for strings here.
9318 (next_element_from_string, next_element_from_c_string)
9319 (next_element_from_buffer): Add xassert's for correspondence
9320 between IT's object being iterated and it->bidi_it.string
9321 structure.
9322 (face_before_or_after_it_pos): Support bidi iteration.
9323 (next_element_from_c_string): Handle the case of the first string
9324 character that is not the first one in the visual order.
9325 (get_visually_first_element): New function, refactored from common
9326 parts of next_element_from_buffer, next_element_from_string, and
9327 next_element_from_c_string.
9328 (tool_bar_lines_needed, redisplay_tool_bar)
9329 (display_menu_bar): Force left-to-right direction. Add a FIXME
9330 comment for making that be controlled by a user option.
9331 (push_it, pop_it): Save and restore the state of the
9332 bidi iterator. Save and restore the bidi_p flag.
9333 (pop_it): Iterate out of display property for string iteration as
9334 well.
9335 (iterate_out_of_display_property): Support iteration over strings.
9336 (handle_single_display_spec): Set up it->bidi_it for iteration
9337 over a display string, and call bidi_init_it.
9338 (handle_single_display_spec, next_overlay_string)
9339 (get_overlay_strings_1, push_display_prop): Set up the bidi
9340 iterator for displaying display or overlay strings.
9341 (forward_to_next_line_start): Don't use the shortcut if
9342 bidi-iterating.
9343 (back_to_previous_visible_line_start): If handle_display_prop
9344 pushed the iterator stack, restore the internal state of the bidi
9345 iterator by calling bidi_pop_it same number of times.
9346 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9347 and we are bidi-iterating, don't decrement the iterator position;
9348 instead, set the first_elt flag in the bidi iterator, to produce
9349 the same effect.
9350 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9351 (push_display_prop): xassert that we are iterating a buffer.
9352 (push_it, pop_it): Save and restore paragraph_embedding member.
9353 (handle_single_display_spec, next_overlay_string)
9354 (get_overlay_strings_1, reseat_1, reseat_to_string)
9355 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9356 correctly. Don't assume unibyte strings are not bidi-reordered.
9357 (compute_display_string_pos)
9358 (compute_display_string_end): Fix handling the case of C string.
9359 (push_it, pop_it): Save and restore from_disp_prop_p.
9360 (handle_single_display_spec, push_display_prop): Set the
9361 from_disp_prop_p flag.
9362 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9363 (pop_it): Call iterate_out_of_display_property only if we are
9364 popping after iteration over a string that came from a display
9365 property. Fix a typo in popping stretch info. Add an assertion
9366 for verifying that the iterator position is in sync with the bidi
9367 iterator.
9368 (handle_single_display_spec, get_overlay_strings_1)
9369 (push_display_prop): Fix initialization of paragraph direction for
9370 string when that of the parent object is not yet determined.
9371 (reseat_1): Call bidi_init_it to resync the bidi
9372 iterator with IT's position. (Bug#7616)
9373 (find_row_edges): If ROW->start.pos gives position
9374 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9375 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9376 Reset the from_disp_prop_p flag.
9377 (SAVE_IT, RESTORE_IT): New macros.
9378 (pos_visible_p, face_before_or_after_it_pos)
9379 (back_to_previous_visible_line_start)
9380 (move_it_in_display_line_to, move_it_in_display_line)
9381 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9382 (try_scrolling, redisplay_window, display_line): Use them when
9383 saving a temporary copy of the iterator and restoring it back.
9384 (back_to_previous_visible_line_start, reseat_1)
9385 (init_iterator): Empty the bidi cache "stack".
9386 (move_it_in_display_line_to): If iterator ended up at
9387 EOL, but we never saw any buffer positions smaller than
9388 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9389 motion in bidi-reordered lines.
9390 (move_it_in_display_line_to): Record prev_method and prev_pos
9391 immediately before the call to set_iterator_to_next. Fixes cursor
9392 motion in bidi-reordered lines with stretch glyphs and strings
9393 displayed in margins. (Bug#8133) (Bug#8867)
9394 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9395 TO_CHARPOS.
640c8776
SM
9396 (pos_visible_p): Support positions in bidi-reordered lines.
9397 Save and restore bidi cache.
0bb23927
EZ
9398
9399 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9400 (bidi_paragraph_info): Delete unused struct.
9401 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9402 (bidi_cache_start): New variable.
9403 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9404 to zero.
9405 (bidi_cache_fetch_state, bidi_cache_search)
9406 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9407 (bidi_cache_find, bidi_peek_at_next_level)
9408 (bidi_level_of_next_char, bidi_find_other_level_edge)
9409 (bidi_move_to_visually_next): Compare cache index with
9410 bidi_cache_start rather than with zero.
9411 (bidi_fetch_char): Accept new argument STRING; all callers
9412 changed. Support iteration over a string. Support strings with
9413 display properties. Support unibyte strings. Fix the type of
9414 `len' according to what STRING_CHAR_AND_LENGTH expects.
9415 (bidi_paragraph_init, bidi_resolve_explicit_1)
9416 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9417 (bidi_level_of_next_char, bidi_move_to_visually_next):
9418 Support iteration over a string.
0bb23927
EZ
9419 (bidi_set_sor_type, bidi_resolve_explicit_1)
9420 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9421 can now be zero (for strings); special values 0 and -1 were
9422 changed to -1 and -2, respectively.
9423 (bidi_char_at_pos): New function.
9424 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9425 Call it instead of FETCH_MULTIBYTE_CHAR.
9426 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9427 initialized to valid values.
9428 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9429 values.
9430 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9431 the test for valid cached positions. Fix the logic for looking up
9432 the sentinel state in the cache. GCPRO the Lisp string we are
9433 iterating.
9434 (bidi_push_it, bidi_pop_it): New functions.
9435 (bidi_initialize): Initialize the bidi cache start stack pointer.
9436 (bidi_cache_ensure_space): New function, refactored from part of
9437 bidi_cache_iterator_state. Don't assume the required size is just
9438 one BIDI_CACHE_CHUNK away.
9439 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9440 (bidi_count_bytes, bidi_char_at_pos): New functions.
9441 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9442 always valid if bidi_cache_idx is valid.
9443 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9444 is valid if it's going to be used.
9445 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9446 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9447 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9448 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9449 (bidi_find_other_level_edge, bidi_cache_start_stack):
9450 All variables related to cache indices are now EMACS_INT.
c965adc5 9451
0bb23927
EZ
9452 * dispextern.h (struct bidi_string_data): New structure.
9453 (struct bidi_it): New member `string'. Make flag members be 1-bit
9454 fields, and put them last in the struct.
640c8776
SM
9455 (compute_display_string_pos, compute_display_string_end):
9456 Update prototypes.
0bb23927
EZ
9457 (bidi_push_it, bidi_pop_it): Add prototypes.
9458 (struct iterator_stack_entry): New members bidi_p,
9459 paragraph_embedding, and from_disp_prop_p.
9460 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9461 (bidi_shelve_cache, bidi_unshelve_cache):
9462 Declare prototypes.
0bb23927
EZ
9463
9464 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9465 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9466 and vector-like objects.
9467
9468 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9469 cache around display iteration.
9470
9471 * window.c (Fwindow_end, window_scroll_pixel_based)
9472 (displayed_window_lines, Frecenter): Save and restore the bidi
9473 cache around display iteration.
9474
3bbd2265
LMI
94752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9476
9477 * editfns.c (Fdelete_region): Clarify the use of the named
9478 parameters (bug#6788).
9479
adc47434
MR
94802011-07-14 Martin Rudalics <rudalics@gmx.at>
9481
9482 * indent.c (Fvertical_motion): Set and restore w->pointm when
9483 saving and restoring the window's buffer (Bug#9006).
9484
837c31f8
LMI
94852011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9486
9487 * editfns.c (Fstring_to_char): Clarify just what is returned
9488 (bug#6576). Text by Eli Zaretskii.
9489
ac389d0c
JB
94902011-07-13 Juanma Barranquero <lekktu@gmail.com>
9491
9492 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9493
0be0ce47
EZ
94942011-07-13 Eli Zaretskii <eliz@gnu.org>
9495
9496 * buffer.c (mmap_find): Fix a typo.
9497
cd18e7e3
JB
94982011-07-13 Johan Bockgård <bojohan@gnu.org>
9499
9500 Fix execution of x selection hooks.
9501 * xselect.c (Qx_lost_selection_functions)
9502 (Qx_sent_selection_functions): New vars.
9503 (syms_of_xselect): DEFSYM them.
9504 (x_handle_selection_request): Pass Qx_sent_selection_functions
9505 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9506 (x_handle_selection_clear,x_clear_frame_selections):
9507 Pass Qx_lost_selection_functions rather than
9508 Vx_lost_selection_functions to Frun_hook_with_args.
9509
47ea7f44
PE
95102011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9511
ac389d0c 9512 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9513 The old code sometimes used this field without initializing it.
9514
47ea7f44
PE
9515 * alloc.c (gc_sweep): Don't read past end of array.
9516 In theory, the old code could also have corrupted Emacs internals,
9517 though it'd be very unlikely.
9518
bc985c87
AS
95192011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9520
9521 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9522 argument. (Bug#4026)
bc985c87 9523
0cf34688
LMI
95242011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9525
b3dadd76
LMI
9526 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9527 key" (bug#4257).
9528
0cf34688
LMI
9529 * window.c (Fset_window_start): Doc fix (bug#4199).
9530 (Fset_window_hscroll): Ditto.
9531
270768cd
PE
95322011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9533
077e3dda 9534 Fix minor new problems caught by GCC 4.6.1.
270768cd 9535 * term.c (init_tty): Remove unused local.
490011a6 9536 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9537 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9538 not used otherwise.
270768cd 9539
b1f58454
CY
95402011-07-12 Chong Yidong <cyd@stupidchicken.com>
9541
9542 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9543
22b9578d
LMI
95442011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9545
6e70ab07
LMI
9546 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9547 are the mini-buffer and the echo area (bug#3320).
9548
22b9578d
LMI
9549 * term.c (init_tty): Remove support for supdup, c10 and perq
9550 terminals, which are no longer supported (bug#1482).
9551
8974cc9f
JB
95522011-07-10 Johan Bockgård <bojohan@gnu.org>
9553
9554 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9555
a560d974
JD
95562011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9557
9558 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9559 for non-popups (Bug#3642).
9560
1dae0f0a
AS
95612011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9562
268c2c36 9563 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9564 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9565 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9566 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9567 * data.c (fmod): Likewise.
9568 * dispnew.c (swap_glyphs_in_rows): Likewise.
9569 * emacs.c (memory_warning_signal): Likewise.
9570 * floatfns.c (float_error): Likewise.
9571 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9572 (otf_open, font_otf_capability, generate_otf_features)
9573 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9574 Likewise.
9575 * image.c (pbm_read_file): Likewise.
9576 * indent.c (string_display_width): Likewise.
9577 * intervals.c (check_for_interval, search_for_interval)
9578 (inc_interval_count, count_intervals, root_interval)
9579 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9580 * lread.c (defalias): Likewise.
268c2c36 9581 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9582 * regex.c (set_image_of_range_1, set_image_of_range)
9583 (regex_grow_registers): Likewise.
9584 * sysdep.c (strerror): Likewise.
9585 * termcap.c (valid_filename_p, tprint, main): Likewise.
9586 * tparam.c (main): Likewise.
9587 * unexhp9k800.c (run_time_remap, save_data_space)
9588 (update_file_ptrs, read_header, write_header, calculate_checksum)
9589 (copy_file, copy_rest, display_header): Likewise.
9590 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9591 Likewise.
9592 * xdisp.c (check_it): Likewise.
9593 * xfaces.c (register_color, unregister_color, unregister_colors):
9594 Likewise.
9595 * xfns.c (print_fontset_result): Likewise.
9596 * xrdb.c (member, fatal, main): Likewise.
9597
99033785
PE
95982011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9599
9600 Fix minor problems found by static checking (Bug#9031).
9601 * chartab.c (char_table_set_range, map_sub_char_table):
9602 Remove unused locals.
9603 (uniprop_table): Now static.
9604 * composite.c (_work_char): Remove unused static var.
9605
9cb2ac56
JB
96062011-07-09 Juanma Barranquero <lekktu@gmail.com>
9607
9608 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9609
f25661f0
JD
96102011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9611
9612 * gtkutil.c (qttip_cb): Remove code without function.
9613
8278c4fe
EZ
96142011-07-09 Eli Zaretskii <eliz@gnu.org>
9615
9616 * w32.c (pthread_sigmask): New stub.
9617
1692ae2d 96182011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9619
8a6ebd58 9620 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9621 sigprocmask is portable only for single-threaded applications, and
9622 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9623 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9624 (LIBES): Use it.
9625 * callproc.c (Fcall_process):
9626 * process.c (create_process):
9627 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9628 Use pthread_sigmask, not sigprocmask.
123403e4 9629
1b854618
JD
96302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9631
9632 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9633 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9634 wrong (Bug#8591).
9635
3fe4b549
JD
96362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9637
0ce7e563
JD
9638 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9639 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9640 (xg_hide_tooltip): Fix comment.
9641
3fe4b549
JD
9642 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9643 in registerServicesMenuSendTypes.
9644 (validRequestorForSendType): Don't check ns_return_types.
9645
9646 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9647 ns_return_type.
9648
5df75e47
JR
96492011-07-08 Jason Rumney <jasonr@gnu.org>
9650
22610910
JR
9651 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9652 SH_SHOW for hidden windows (Bug#5482).
9653
5df75e47
JR
9654 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9655 frame struct members of non-existent frames (Bug#6284).
9656
699c10bd
JD
96572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9658
4393663b
JD
9659 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9660 variable firstTime not needed on OSX >= 10.6.
9661 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9662 >= 10.5. Use setKnobProportion, setDoubleValue.
9663
9664 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9665 (MAC_OS_X_VERSION_10_5): Define if not defined.
9666 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9667 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9668 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9669
9670 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9671 cString and lossyCString on OSX >= 10.4.
4393663b 9672
58179cce 9673 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9674 sizeToFit on OSX >= 10.2.
9675
9676 * nsimage.m (allocInitFromFile): Don't use deprecated method
9677 bestRepresentationForDevice on OSX >= 10.6.
9678
9679 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9680 to avoid warning.
9681
9682 * emacs.c: Declare unexec_init_emacs_zone.
9683
a63e0781
JD
9684 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9685
699c10bd
JD
9686 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9687
9688 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9689 on svcsMenu (Bug#8842).
9690
9691 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9692 ns_return_types.
9693 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9694
9695 * nsterm.m (QUTF8_STRING): Declare.
9696 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9697 (validRequestorForSendType): Return type is (id).
9698 Change indexOfObjectIdenticalTo to indexOfObject.
9699 Check if we have local selection before returning self (Bug#8842).
9700 (writeSelectionToPasteboard): Put local selection into paste board
9701 if we have a local selection (Bug#8842).
9702 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9703
9704 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9705 (ns_get_local_selection): Declare.
9706
54e10184
LMI
97072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9708
9888ff71
LMI
9709 * keymap.c (describe_map_tree): Don't insert a double newline at
9710 the end of the buffer (bug#1169) and return whether we inserted
9711 something.
9712
54e10184
LMI
9713 * callint.c (Fcall_interactively): Change "reading args" to
9714 "providing args" to try to clarify what it does (bug#1010).
9715
15fa4783
KH
97162011-07-07 Kenichi Handa <handa@m17n.org>
9717
9718 * composite.c (composition_compute_stop_pos): Ignore a static
9719 composition starting before CHARPOS (Bug#8915).
9720
9721 * xdisp.c (handle_composition_prop): Likewise.
9722
a8815b00
EZ
97232011-07-07 Eli Zaretskii <eliz@gnu.org>
9724
9725 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9726 (Bug#9015)
9727
ef7b981d 97282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9729
9730 * character.h (unicode_category_t): New enum type.
9731
9732 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9733 (Qchar_code_property_table): New variable.
9734 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9735 (UNIPROP_COMPRESSED_FORM_P): New macros.
9736 (char_table_ascii): Uncompress the compressed values.
9737 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9738 Uncompress the compressed values.
ac389d0c 9739 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9740 (char_table_ref_and_range): Uncompress the compressed values.
9741 (sub_char_table_set): New arg is_uniprop. Callers changed.
9742 Uncompress the compressed values.
9743 (sub_char_table_set_range): Args changed. Callers changed.
9744 (char_table_set_range): Adjuted for the above change.
9745 (map_sub_char_table): Delete args default_val and parent. Add arg
9746 top. Give decoded values to a Lisp function.
640c8776 9747 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9748 values to a Lisp function. Gcpro more variables.
9749 (uniprop_table_uncompress)
9750 (uniprop_decode_value_run_length): New functions.
9751 (uniprop_decoder, uniprop_decoder_count): New variables.
9752 (uniprop_get_decoder, uniprop_encode_value_character)
9753 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9754 New functions.
9755 (uniprop_encoder, uniprop_encoder_count): New variables.
9756 (uniprop_get_encoder, uniprop_table)
9757 (Funicode_property_table_internal, Fget_unicode_property_internal)
9758 (Fput_unicode_property_internal): New functions.
9759 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9760 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9761 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9762 char-code-property-alist.
9763
640c8776 9764 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9765 Vunicode_category_table.
9766
640c8776 9767 * font.c (font_range): Adjust for the change of
c805dec0
KH
9768 Vunicode_category_table.
9769
76b397fb
DN
97702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9771
9772 * m/iris4d.h: Remove file, move contents ...
9773 * s/irix6-5.h: ... here.
9774
22b4128e
PE
97752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9776
9777 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9778 * alloc.c (mark_buffer):
9779 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9780 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9781 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9782 This isn't true in general, and it's particularly not true
9783 if Emacs is configured with --with-wide-int.
9784 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9785 New macros, used in the buffer.c change.
9786
869795d6
JD
97872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9788
9789 * xsettings.c: Use both GConf and GSettings if both are available.
9790 (store_config_changed_event): Add comment.
9791 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9792 (store_tool_bar_style_changed): New functions.
5e617bc2 9793 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9794 (struct xsettings): Move font inside HAVE_XFT.
9795 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9796 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9797 Move inside HAVE_XFT.
640c8776 9798 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9799 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9800 also.
9801 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9802 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9803 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9804 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9805 (parse_settings): Move check for font inside HAVE_XFT.
9806 (read_settings, apply_xft_settings): Add comment.
9807 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9808 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9809 call store_font_name_changed.
9810 (xft_settings_event): Add comment.
9811 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9812 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9813 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9814 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9815 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9816 (xsettings_get_system_font, xsettings_get_system_normal_font):
9817 Add comment.
869795d6 9818
d8ed26bd
PE
98192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9820
9821 Random fixes. E.g., (random) never returned negative values.
9822 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9823 subseconds part to the entropy, as that's a bit more random.
9824 Prefer signed to unsigned, since the signedness doesn't matter and
9825 in general we prefer signed. When given a limit, use a
9826 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9827 latter isn't right if USE_2_TAGS_FOR_INTS.
9828 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9829 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9830
cabf1cac
SM
98312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9832
9833 * textprop.c (text_property_stickiness):
9834 Obey Vtext_property_default_nonsticky.
9835 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9836 * w32fns.c (syms_of_w32fns):
9837 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9838
6e9b2be9
PE
98392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9840
9841 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9842 This is more efficient than Ffile_directory_p and avoids a minor race.
9843
90186c68
LMI
98442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9845
7c301272
LMI
9846 * buffer.c (Foverlay_put): Say what the return value is
9847 (bug#7835).
9848
c4f2d8d4
LMI
9849 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9850 is a directory before asking whether to use the file name
9851 (bug#7564).
ad637907
LMI
9852 (barf_or_query_if_file_exists): Make the "File is a directory"
9853 error be more correct.
c4f2d8d4 9854
90186c68
LMI
9855 * fns.c (Frequire): Remove the mention of the .gz files, since
9856 that's installation-specific, but keep the mention of
9857 `get-load-suffixes'.
9858
da64016e
PE
98592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9860
9861 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9862 Report string overflow if the output is too long.
9863
7d47b580
JB
98642011-07-04 Juanma Barranquero <lekktu@gmail.com>
9865
a555cb87
JB
9866 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9867 (syms_of_gnutls): Remove duplicate DEFSYM for
9868 Qgnutls_bootprop_verify_hostname_error, an error for
9869 Qgnutls_bootprop_verify_error (which is no longer used).
9870
7d47b580
JB
9871 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9872 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9873 Also (re)move comments that are misplaced or no longer relevant.
9874
1e49bfab
LMI
98752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9876
9877 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9878
1485f4c0
CY
98792011-07-03 Chong Yidong <cyd@stupidchicken.com>
9880
9881 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9882 and background color parameters if they have been changed.
9883
a9ab721e
LMI
98842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9885
9886 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9887
cf7cff57
PE
98882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9889
2e13213d
PE
9890 * xsettings.c (SYSTEM_FONT): Define only when used.
9891 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9892
cf7cff57
PE
9893 * keymap.c (access_keymap_1): Now static.
9894
7a8e04f7
CY
98952011-07-02 Chong Yidong <cyd@stupidchicken.com>
9896
9897 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9898 leave any prefix arg for the up event (Bug#1586).
9899
61352f62
LMI
99002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9901
69bb1ef7
LMI
9902 * lread.c (syms_of_lread): Mention single symbols defined by
9903 `defvar' or `defconst' (bug#7154).
9904
61352f62 9905 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9906 (Frequire): Mention get-load-suffixes.
61352f62 9907
28545e04
MR
99082011-07-02 Martin Rudalics <rudalics@gmx.at>
9909
9910 * window.h (window): Remove clone_number slot.
9911 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9912 Remove.
9913 (make_parent_window, make_window, saved_window)
9914 (Fset_window_configuration, save_window_save): Don't deal with
9915 clone numbers.
9916 * buffer.c (Qclone_number): Remove declaration.
9917 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9918
3349e122
SM
99192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9920
9921 Add multiple inheritance to keymaps.
9922 * keymap.c (Fmake_composed_keymap): New function.
9923 (Fset_keymap_parent): Simplify.
9924 (fix_submap_inheritance): Remove.
9925 (access_keymap_1): New function extracted from access_keymap to handle
9926 embedded parents and handle lists of maps.
9927 (access_keymap): Use it.
9928 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9929 (Fcopy_keymap): Handle embedded parents.
9930 (Fcommand_remapping, define_as_prefix): Simplify.
9931 (Fkey_binding): Simplify.
9932 (syms_of_keymap): Move minibuffer-local-completion-map,
9933 minibuffer-local-filename-completion-map,
9934 minibuffer-local-must-match-map, and
9935 minibuffer-local-filename-must-match-map to Elisp.
9936 (syms_of_keymap): Defsubr make-composed-keymap.
9937 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9938 (parse_menu_item): Trivial simplification.
9939
3279eb87
GM
99402011-07-01 Glenn Morris <rgm@gnu.org>
9941
9942 * Makefile.in (SETTINGS_LIBS): Fix typo.
9943
4550efdf
KI
99442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9945
9946 * coding.c (Fencode_coding_string): Record the last coding system
9947 used, as the function doc string says (bug#8738).
9948
0949d2b6
JD
99492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9950
9951 * xsettings.c (store_monospaced_changed): Take new font as arg and
9952 check for change against current_mono_font.
9953 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9954 (emacs_settings_constructor, emacs_settings_get_property)
9955 (emacs_settings_set_property, emacs_settings_class_init)
9956 (emacs_settings_init, gsettings_obj): Remove.
9957 (something_changedCB): New function for HAVE_GSETTINGS.
9958 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9959 with value as argument.
9960 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9961 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9962 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9963 "changed".
9964
9965 * xgselect.c: Add defined (HAVE_GSETTINGS).
9966 (xgselect_initialize): Ditto.
9967
9968 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9969 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9970 xg_select.
9971
bbc6b304
PE
99722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9973
9974 * eval.c (struct backtrace): Simplify and port the data structure.
9975 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9976 signed bit field, as this assumption is not portable and it makes
9977 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9978 "char debug_on_exit : 1" as this is not portable either; instead,
9979 use the portable "unsigned int debug_on_exit : 1". Remove unused
9980 member evalargs. Remove obsolete comments about cc bombing out.
9981
9851bfc5
JD
99822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9983
51bb811f 9984 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9985 Let HAVE_GSETTINGS override HAVE_GCONF.
9986 (store_monospaced_changed): New function.
9987 (EMACS_SETTINGS): A new type derived from GObject to handle
9988 GSettings notifications.
9989 (emacs_settings_constructor, emacs_settings_get_property)
9990 (emacs_settings_set_property, emacs_settings_class_init):
9991 New functions.
9992 (gsettings_client, gsettings_obj): New variables.
9993 (GSETTINGS_SCHEMA): New define.
9994 (something_changedCB): Call store_monospaced_changed.
9995 (init_gsettings): New function.
9996 (xsettings_initialize): Call init_gsettings.
9997 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9998 to NULL.
9999
640c8776 10000 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10001 GCONF_CFLAGS/LIBS.
10002
5386012d
MR
100032011-06-29 Martin Rudalics <rudalics@gmx.at>
10004
10005 * window.c (resize_root_window, grow_mini_window)
10006 (shrink_mini_window): Rename Qresize_root_window to
10007 Qwindow_resize_root_window and Qresize_root_window_vertically to
10008 Qwindow_resize_root_window_vertically.
10009
f13e0b08
PE
100102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10011
10012 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10013
94515237
JB
100142011-06-27 Juanma Barranquero <lekktu@gmail.com>
10015
10016 * makefile.w32-in: Redesign dependencies so they reflect more
10017 clearly which files are directly included by each source file,
10018 and not through other includes.
10019
e43b6e43
MR
100202011-06-27 Martin Rudalics <rudalics@gmx.at>
10021
10022 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10023 (sort_overlays, overlay_strings): When an overlay's clone number
10024 matches the window's clone number process the overlay even if
10025 the overlay's window property doesn't match the current window.
10026
d68443dc
MR
10027 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10028 (Fwindow_hchild): Rename to Fwindow_left_child.
10029 (Fwindow_next): Rename to Fwindow_next_sibling.
10030 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10031 (resize_window_check): Rename to window_resize_check.
10032 (resize_window_apply): Rename to window_resize_apply.
10033 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10034 (Fdelete_other_windows_internal, resize_frame_windows)
10035 (Fsplit_window_internal, Fdelete_window_internal)
10036 (grow_mini_window, shrink_mini_window)
10037 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10038
c7e73be5
JD
100392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10040
10041 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10042 (emacs_fixed_set_min_size): Remove.
10043 (emacs_fixed_new): Take frame as argument.
10044
10045 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10046 (_EmacsFixedPrivate): Remove minwidth/height.
10047 Add struct frame *f.
10048 (emacs_fixed_init): Initialize priv->f.
10049 (get_parent_class, emacs_fixed_set_min_size): Remove.
10050 (emacs_fixed_new): Set priv->f to argument.
10051 (emacs_fixed_get_preferred_width)
10052 (emacs_fixed_get_preferred_height): Use min_width/height from
10053 frames size_hint to set minimum and natural (Bug#8919).
10054 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10055 and use min_width/height from frames size_hint to set
10056 min_width/height (Bug#8919).
10057
10058 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10059 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10060 Fix indentation.
c7e73be5 10061
cf99dcf8
EZ
100622011-06-26 Eli Zaretskii <eliz@gnu.org>
10063
10064 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10065 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10066 called at ZV.
10067
029529ac
CY
100682011-06-26 Chong Yidong <cyd@stupidchicken.com>
10069
10070 * process.c (wait_reading_process_output): Bypass select if
10071 waiting for a cell while ignoring keyboard input, and input is
10072 pending. Suggested by Jan Djärv (Bug#8869).
10073
7a7ef429
PE
100742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10075
10076 Use gnulib's dup2 module instead of rolling our own.
10077 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10078
11fdef7d 100792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10080
10081 * dispnew.c (scrolling_window): Before scrolling, turn off a
10082 mouse-highlight in the window being scrolled.
10083
cd3520a4
JB
100842011-06-24 Juanma Barranquero <lekktu@gmail.com>
10085
10086 Move DEFSYM to lisp.h and use everywhere.
10087
10088 * character.h (DEFSYM): Move declaration...
10089 * lisp.h (DEFSYM): ...here.
10090
10091 * gnutls.c:
10092 * minibuf.c:
10093 * w32menu.c:
10094 * w32proc.c:
10095 * w32select.c: Don't include character.h.
10096
10097 * alloc.c (syms_of_alloc):
10098 * buffer.c (syms_of_buffer):
10099 * bytecode.c (syms_of_bytecode):
10100 * callint.c (syms_of_callint):
10101 * casefiddle.c (syms_of_casefiddle):
10102 * casetab.c (init_casetab_once):
10103 * category.c (init_category_once, syms_of_category):
10104 * ccl.c (syms_of_ccl):
10105 * cmds.c (syms_of_cmds):
10106 * composite.c (syms_of_composite):
10107 * dbusbind.c (syms_of_dbusbind):
10108 * dired.c (syms_of_dired):
10109 * dispnew.c (syms_of_display):
10110 * doc.c (syms_of_doc):
10111 * editfns.c (syms_of_editfns):
10112 * emacs.c (syms_of_emacs):
10113 * eval.c (syms_of_eval):
10114 * fileio.c (syms_of_fileio):
10115 * fns.c (syms_of_fns):
10116 * frame.c (syms_of_frame):
10117 * fringe.c (syms_of_fringe):
10118 * insdel.c (syms_of_insdel):
10119 * keymap.c (syms_of_keymap):
10120 * lread.c (init_obarray, syms_of_lread):
10121 * macros.c (syms_of_macros):
10122 * msdos.c (syms_of_msdos):
10123 * print.c (syms_of_print):
10124 * process.c (syms_of_process):
10125 * search.c (syms_of_search):
10126 * sound.c (syms_of_sound):
10127 * syntax.c (init_syntax_once, syms_of_syntax):
10128 * terminal.c (syms_of_terminal):
10129 * textprop.c (syms_of_textprop):
10130 * undo.c (syms_of_undo):
10131 * w32.c (globals_of_w32):
10132 * window.c (syms_of_window):
10133 * xdisp.c (syms_of_xdisp):
10134 * xfaces.c (syms_of_xfaces):
10135 * xfns.c (syms_of_xfns):
10136 * xmenu.c (syms_of_xmenu):
10137 * xsettings.c (syms_of_xsettings):
10138 * xterm.c (syms_of_xterm): Use DEFSYM.
10139
4228cf16
TZ
101402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10141
cd3520a4 10142 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10143
7fcccf1e
PE
101442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10145
7efb4e0e
PE
10146 Integer and buffer overflow fixes (Bug#8873).
10147
ff5844ad
PE
10148 * print.c (printchar, strout): Check for string overflow.
10149 (PRINTPREPARE, printchar, strout):
10150 Don't set size unless allocation succeeds.
10151
90532f02
PE
10152 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10153 for sizes. Check for string overflow more accurately.
10154 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10155
6d84508d
PE
10156 * macros.c: Integer and buffer overflow fixes.
10157 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10158 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10159 Use ptrdiff_t, not int, for sizes.
10160 Don't increment bufsize until after realloc succeeds.
10161 Check for size-calculation overflow.
10162 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10163
437b2cb4
PE
10164 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10165
8b9ac8b4
PE
10166 * lread.c: Integer overflow fixes.
10167 (read_integer): Radix is now EMACS_INT, not int,
10168 to improve quality of diagnostics for out-of-range radices.
10169 Calculate buffer size correctly for out-of-range radices.
10170 (read1): Check for integer overflow in radices, and in
10171 read-circle numbers.
82cb60d3
PE
10172 (read_escape): Avoid int overflow.
10173 (Fload, openp, read_buffer_size, read1)
10174 (substitute_object_recurse, read_vector, read_list, map_obarray):
10175 Use ptrdiff_t, not int, for sizes.
10176 (read1): Use EMACS_INT, not int, for sizes.
20270765 10177 Check for size overflow.
8b9ac8b4 10178
7fcccf1e
PE
10179 * image.c (cache_image): Check for size arithmetic overflow.
10180
bfbbd7e7
PE
10181 * lread.c: Integer overflow issues.
10182 (saved_doc_string_size, saved_doc_string_length)
10183 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10184 Now ptrdiff_t, not int.
10185 (read1): Don't assume doc string length fits in int. Check for
10186 out-of-range doc string lengths.
10187 (read_list): Don't assume file position fits in int.
39019e54 10188 (read_escape): Check for hex character overflow.
bfbbd7e7 10189
4e323265
LL
101902011-06-22 Leo Liu <sdl.web@gmail.com>
10191
10192 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10193 Move to minibuffer.el.
10194
85fece3e
PE
101952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10196
20b84ce9 10197 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10198 The following patches are for when GLYPH_DEBUG && !XASSERT.
10199 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10200 * dispnew.c (flush_stdout):
10201 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10202 Mark as externally visible.
10203 * dispnew.c (check_window_matrix_pointers): Now static.
10204 * dispnew.c (window_to_frame_vpos):
10205 * xfns.c (unwind_create_frame):
10206 * xterm.c (x_check_font): Remove unused local.
10207 * scroll.c (CHECK_BOUNDS):
10208 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10209 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10210 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10211 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10212 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10213 Now static.
10214 (debug_method_add): Use va_list and vsprintf rather than relying
10215 on undefined behavior with wrong number of arguments.
10216 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10217 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10218 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10219 since we're not interested in debugging glyphs with old libraries.
10220 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10221 GCC 4.6.0's static checking.
10222
0766b489
PE
102232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10224
31fd4b32
PE
10225 Integer overflow and signedness fixes (Bug#8873).
10226 A few related buffer overrun fixes, too.
10227
b79e8648
PE
10228 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10229
0766b489
PE
10230 * dispextern.h (struct face.stipple):
10231 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10232 (x_bitmap_mask, x_allocate_bitmap_record)
10233 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10234 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10235 (x_create_bitmap_from_xpm_data):
10236 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10237 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10238 (.bitmaps_last):
10239 * xfaces.c (load_pixmap):
10240 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10241 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10242 (.bitmaps_last, struct x_output.icon_bitmap):
10243 Use ptrdiff_t, not int, for bitmap indexes.
10244 (x_allocate_bitmap_record): Check for size overflow.
10245 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10246
b081724f
PE
10247 Use ptrdiff_t, not int, for overlay counts.
10248 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10249 * editfns.c (overlays_around, get_pos_property):
10250 * textprop.c (get_char_property_and_overlay):
10251 * xdisp.c (next_overlay_change, note_mouse_highlight):
10252 * xfaces.c (face_at_buffer_position):
21514da7
PE
10253 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10254 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10255 (Fnext_overlay_change, Fprevious_overlay_change)
10256 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10257 Use ptrdiff_t, not int, for sizes.
21514da7 10258 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10259
3de73e5e
PE
10260 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10261
2606c57b
PE
10262 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10263 (x_session_initialize): Do not assume string length fits in int.
10264
aaafe47a
PE
10265 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10266 This is unlikely, but can occur if DPI is outlandish.
10267
2674ddc8 10268 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10269 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10270
28154962
PE
10271 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10272 * xrdb.c (magic_file_p, search_magic_path):
10273 Omit last arg SUFFIX; it was always 0. All callers changed.
10274 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10275
7de51af5
PE
10276 * xfont.c (xfont_match): Avoid need for strlen.
10277
25ed6cc3
PE
10278 * xfns.c: Don't assume strlen fits in int.
10279 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10280
4eab31dd
PE
10281 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10282 not unsigned long, as we prefer signed integers. All callers changed.
10283 Detect integer overflow in repeat count.
10284 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10285 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10286
171e2a58
PE
10287 * termcap.c: Don't assume sizes fit in int and never overflow.
10288 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10289 (gobble_line): Check for size-calculation overflow.
10290
ad39faca 10291 * minibuf.c (Fread_buffer):
6e5bb2dc 10292 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10293 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10294 Don't assume string length fits in int.
10295
52c61c22 10296 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10297 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10298
b5b8c9e5
PE
10299 * font.c: Don't assume string length fits in int.
10300 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10301 Use ptrdiff_t, not int.
ccd6111c
PE
10302 (font_intern_prop): Don't assume string length fits in int.
10303 Don't assume integer property fits in fixnum.
10304 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10305
882f0d81 10306 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10307 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10308 Reformulate so as not to need the command string.
10309 Invoke gzip -cd rather than gunzip, as it's more portable.
10310 (lock_info_type, lock_file_1, lock_file):
10311 Don't assume pid_t and time_t fit in unsigned long.
10312 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10313 (current_lock_owner): Prefer signed type for sizes.
10314 Use memcpy, not strncpy, where memcpy is what is really wanted.
10315 Don't assume (via atoi) that time_t and pid_t fit in int.
10316 Check for time_t and/or pid_t out of range, e.g., via a network share.
10317 Don't alloca where an auto var works fine.
10318
93f4cf88
PE
10319 * fileio.c: Fix some integer overflow issues.
10320 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10321 Don't assume string length fits in int.
10322 (directory_file_name): Don't assume string length fits in long.
10323 (make_temp_name): Don't assume pid fits in int, or that its print
10324 length is less than 20.
10325
f3e92b69
PE
10326 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10327
1bfdaf10
PE
10328 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10329
35016e9a
PE
10330 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10331
3d1e65a1
PE
10332 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10333 We prefer signed integers, even for size calculations.
10334
0b963a93
PE
10335 * emacs.c: Don't assume string length fits in 'int'.
10336 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10337 (main): Don't invoke strlen when not needed.
10338
573f4b54
PE
10339 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10340 (XD_DEBUG_MESSAGE): Don't waste a byte.
10341
989f33ba
PE
10342 * callproc.c (getenv_internal_1, getenv_internal)
10343 (Fgetenv_internal):
965d34eb
PE
10344 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10345
e4d29b33
PE
10346 * lread.c (invalid_syntax): Omit length argument.
10347 All uses changed. This doesn't fix a bug, but it simplifies the
10348 code away from its former Hollerith-constant appearance, and it's
10349 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10350 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10351
eb49b136
PE
10352 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10353 This didn't break anything, but it didn't help either.
10354 It's confusing to put a bogus integer in a place where the actual
10355 value does not matter.
9f62aeb1 10356 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10357 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10358
15375a22
PE
10359 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10360 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10361 implementation.
b61cc01c
PE
10362 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10363 We prefer signed types, and the value cannot exceed the EMACS_INT
10364 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10365 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10366 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10367 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10368
53b2623d
PE
10369 * indent.c (sane_tab_width): New function.
10370 (current_column, scan_for_column, Findent_to, position_indentation)
10371 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10372 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10373
51cab52b 10374 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10375
f2ed8a70
PE
10376 * lisp.h (lint_assume): New macro.
10377 * composite.c (composition_gstring_put_cache):
10378 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10379
abe80cc6
PE
10380 * editfns.c, insdel.c:
10381 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10382
b02c740e
PE
10383 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10384
ebc96716
PE
10385 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10386
b4e50fa0 10387 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10388 Use much-faster test for byte-length change.
311d5d7c 10389 Don't assume string byte-length fits in 'int'.
a4cf38e4 10390 Check that character arg fits in 'int'.
85461888 10391 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10392
c0c1ee9f
PE
10393 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10394
a498d7f4
PE
10395 * fns.c (concat): Catch string overflow earlier.
10396 Do not rely on integer wraparound.
10397
51cab52b
PE
10398 * dispextern.h (struct it.overlay_strings_charpos)
10399 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10400 * xdisp.c (forward_to_next_line_start)
10401 (back_to_previous_visible_line_start)
10402 (reseat_at_next_visible_line_start, next_element_from_buffer):
10403 Don't arbitrarily truncate the value of 'selective' to int.
10404
76031fad
PE
10405 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10406
5eb55db9
PE
10407 * composite.c: Don't truncate sizes to 'int'.
10408 (composition_gstring_p, composition_reseat_it)
10409 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10410 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10411 not EMACS_UINT, for indexes.
5eb55db9 10412
0703a717
PE
10413 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10414
d6202519
PE
10415 * buffer.c: Include <verify.h>.
10416 (struct sortvec.priority, struct sortstr.priority):
8961a454 10417 Now EMACS_INT, not int.
c20998a7 10418 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10419 (struct sortstr.size, record_overlay_string)
10420 (struct sortstrlist.size, struct sortlist.used):
10421 Don't truncate size to int.
10422 (record_overlay_string): Check for size-calculation overflow.
d6202519 10423 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10424
d5a19415
JM
104252011-06-22 Jim Meyering <meyering@redhat.com>
10426
029529ac 10427 Don't leak an XBM-image-sized buffer
d5a19415
JM
10428 * image.c (xbm_load): Free the image buffer after using it.
10429
a9041e6c
PE
104302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10431
10432 Port to Sun C.
10433 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10434 that Sun C diagnosed.
10435 * fns.c (secure_hash): Fix pointer signedness issue.
10436 * intervals.c (static_offset_intervals): New function.
10437 (offset_intervals): Use it.
10438
7f3f739f
LL
104392011-06-21 Leo Liu <sdl.web@gmail.com>
10440
10441 * deps.mk (fns.o):
10442 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10443 sha512.h.
10444
10445 * fns.c (secure_hash): Rename from crypto_hash_function and change
10446 the first arg to accept symbols.
5b66d427 10447 (Fsecure_hash): New primitive.
7f3f739f
LL
10448 (syms_of_fns): New symbols.
10449
76147d94
DD
104502011-06-20 Deniz Dogan <deniz@dogan.se>
10451
10452 * process.c (Fset_process_buffer): Clarify return value in
10453 docstring.
10454
7d7d0045
CY
104552011-06-18 Chong Yidong <cyd@stupidchicken.com>
10456
10457 * dispnew.c (add_window_display_history): Use BVAR.
10458
10459 * xdisp.c (debug_method_add): Use BVAR.
10460 (check_window_end, dump_glyph_matrix, dump_glyph)
10461 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10462
10463 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10464 Likewise.
10465
10466 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10467 check till after the cache is created in init_frame_faces.
10468
ff2bc410
SM
104692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10470
10471 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10472
28177add
PE
104732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10474
dd3482fe
PE
10475 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10476 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10477 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10478
393d71f3 10479 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10480 * fileio.c (Finsert_file_contents):
10481 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10482 Remove the old (too-loose) buffer overflow checks.
10483 They weren't needed, since make_gap checks for buffer overflow.
10484 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10485 The old code merely checked for Emacs fixnum overflow, and relied
10486 on undefined (wraparound) behavior. The new code avoids undefined
10487 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10488
2e6813b0 10489 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10490 Tune. Don't use wider integers than needed. Don't use alloca.
10491 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10492
599a9e4f
PE
10493 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10494
99561444
PE
10495 * insdel.c, lisp.h (buffer_overflow): New function.
10496 (insert_from_buffer_1, replace_range, replace_range_2):
10497 * insdel.c (make_gap_larger):
10498 * editfns.c (Finsert_char):
10499 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10500
28177add
PE
10501 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10502
e69dafad
PE
105032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10504
4baa020d 10505 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10506
b1c46f02
PE
10507 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10508 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10509
e69dafad
PE
10510 * fileio.c: Don't assume EMACS_INT fits in off_t.
10511 (emacs_lseek): New static function.
10512 (Finsert_file_contents, Fwrite_region): Use it.
10513 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10514
566684ea
PE
10515 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10516
e6966cd6
PE
10517 * fns.c: Don't overflow int when computing a list length.
10518 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10519 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10520 truncation on 64-bit hosts. Check for QUIT every
10521 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10522 faster and is responsive enough.
10523 (Flength): Report an error instead of overflowing an integer.
10524 (Fsafe_length): Return a float if the value is not representable
10525 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10526 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10527 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10528
dd0b0efb
PE
10529 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10530 (header_size, word_size): New constants.
10531 (allocate_vectorlike): Don't check size overflow here.
10532 (allocate_vector): Check it here instead, since this is the only
10533 caller of allocate_vectorlike that could cause overflow.
10534 Check that the new vector's length is representable as a fixnum.
10535
86fe5cfe
PE
10536 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10537 The previous code was bogus. For example, next_almost_prime (32)
10538 returned 39, which is undesirable as it is a multiple of 3; and
10539 next_almost_prime (24) returned 25, which is a multiple of 5 so
10540 why was the code bothering to check for multiples of 7?
10541
80e88859
PE
10542 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10543
4a2f0ad6
PE
10544 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10545
f66c7cf8
PE
10546 Variadic C functions now count arguments with ptrdiff_t.
10547 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10548 Back then I didn't know that the Emacs coding style prefers signed int.
10549 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10550 were being counted with int, which may truncate counts on 64-bit
10551 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10552 * lisp.h (struct Lisp_Subr.function.aMANY)
10553 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10554 Arg counts are now ptrdiff_t, not size_t.
10555 All variadic functions and their callers changed accordingly.
10556 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10557 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10558 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10559 * callint.c (Fcall_interactively): Check arg count for overflow,
10560 to avoid potential buffer overrun. Use signed char, not 'int',
10561 for 'varies' array, so that we needn't bother to check its size
10562 calculation for overflow.
10563 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10564 * eval.c (apply_lambda):
10565 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10566 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10567 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10568
a1759b76
PE
10569 * callint.c (Fcall_interactively): Don't use index var as event count.
10570
d96be9fc
PE
10571 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10572 * mem-limits.h (SIZE): Remove; no longer used.
10573
a690a978 10574 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10575
578c21e6
PE
10576 Remove unnecessary casts.
10577 * xterm.c (x_term_init):
10578 * xfns.c (x_set_border_pixel):
10579 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10580 These aren't needed now that we assume ANSI C.
10581
96f53c6c
PE
10582 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10583 It's more likely to cause problems (due to unsigned overflow)
10584 than to cure them.
10585
83c77d31
PE
10586 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10587
ee2079f1
PE
10588 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10589
6da65536
PE
10590 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10591
7147c4a4
PE
10592 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10593
193e32d9
PE
10594 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10595
e5533da6
PE
10596 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10597
9910e595
PE
10598 GLYPH_CODE_FACE returns EMACS_INT, not int.
10599 * dispextern.h (merge_faces):
10600 * xfaces.c (merge_faces):
01103c44
PE
10601 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10602 Don't assume EMACS_INT fits in int.
9910e595 10603
2638320e
PE
10604 * character.h (CHAR_VALID_P): Remove unused parameter.
10605 * fontset.c, lisp.h, xdisp.c: All uses changed.
10606
045eb8d9
PE
10607 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10608
c1f134b5
PE
10609 * fns.c (concat): Minor tuning based on overflow analysis.
10610 This doesn't fix any bugs. Use int to hold character, instead
10611 of constantly refetching from Emacs object. Use XFASTINT, not
10612 XINT, for value known to be a character. Don't bother comparing
10613 a single byte to 0400, as it's always less.
10614
395fcb93 10615 * floatfns.c (Fexpt):
327eeec8
PE
10616 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10617
abbd3d23
PE
10618 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10619 for characters.
10620
684a03ef
PE
10621 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10622
0fed43f3
PE
10623 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10624 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10625 incorrectly succeed when S was a string, because 4294967386 was
10626 truncated before it was used.
10627
8fd02eb7
PE
10628 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10629 Otherwise, an out-of-range integer could cause undefined behavior
10630 on a 64-bit host.
10631
f8c86b69
PE
10632 * composite.c: Use int, not EMACS_INT, for characters.
10633 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10634 EMACS_INT, for values that are known to be in character range.
10635 This doesn't fix any bugs but is the usual style inside Emacs and
10636 may generate better code on 32-bit machines.
10637
34206dd2
PE
10638 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10639 This is for reasons similar to the recent CHAR_STRING fix.
10640 * charset.c (Fencode_char): Check that character arg is actually
10641 a character. Pass an int to ENCODE_CHAR.
10642 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10643 wider than 'int', as a compile-time check to prevent future regressions
10644 in this area.
10645
c5958d4c 10646 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10647
10648 Make sure a 64-bit char is never passed to CHAR_STRING.
10649 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10650 by silently ignoring the top 32 bits, allowing some values
10651 that were far too large to be valid characters.
10652 * character.h: Include <verify.h>.
10653 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10654 arguments are no wider than unsigned, as a compile-time check
10655 to prevent future regressions in this area.
10656 * data.c (Faset):
01103c44 10657 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10658 (Fsubst_char_in_region):
10659 * fns.c (concat):
10660 * xdisp.c (decode_mode_spec_coding):
10661 Adjust to CHAR_STRING's new requirement.
10662 * editfns.c (Finsert_char, Fsubst_char_in_region):
10663 * fns.c (concat): Check that character args are actually
10664 characters. Without this test, these functions did the wrong
10665 thing with wildly out-of-range values on 64-bit hosts.
10666
d37ca623
PE
10667 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10668 These casts should not be needed on 32-bit hosts, either.
10669 * keyboard.c (read_char):
10670 * lread.c (Fload): Remove casts to unsigned.
10671
ea204efb
PE
10672 * lisp.h (UNSIGNED_CMP): New macro.
10673 This fixes comparison bugs on 64-bit hosts.
10674 (ASCII_CHAR_P): Use it.
10675 * casefiddle.c (casify_object):
01103c44 10676 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10677 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10678 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10679 * dispextern.h (FACE_FROM_ID):
10680 * keyboard.c (read_char): Use UNSIGNED_CMP.
10681
41cb286c
PE
10682 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10683 not to EMACS_INT, to avoid GCC warning.
10684
4a1b9832
PE
10685 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10686
55daad71
PE
10687 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10688 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10689 isn't needed on 32-bit machines.
8f95c75c 10690
01103c44
PE
10691 * buffer.c (Fgenerate_new_buffer_name):
10692 Use EMACS_INT for count, not int.
0ceccced 10693 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10694
10695 * data.c (Qcompiled_function): Now static.
10696
c6f072e7
PE
10697 * window.c (window_body_lines): Now static.
10698
20ce5912
PE
10699 * image.c (gif_load): Rename local to avoid shadowing.
10700
9c4c5f81
PE
10701 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10702 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10703 * alloc.c (make_save_value): Integer argument is now of type
10704 ptrdiff_t, not int.
10705 (mark_object): Use ptrdiff_t, not int.
10706 * lisp.h (pD): New macro.
10707 * print.c (print_object): Use it.
10708
c0c5c8ae
PE
10709 * alloc.c: Use EMACS_INT, not int, to count objects.
10710 (total_conses, total_markers, total_symbols, total_vector_size)
10711 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10712 (total_free_floats, total_floats, total_free_intervals)
10713 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10714 Now EMACS_INT, not int. All uses changed.
10715 (Fgarbage_collect): Compute overall total using a double, so that
10716 integer overflow is less likely to be a problem. Check for overflow
10717 when converting back to an integer.
5a25e253
PE
10718 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10719 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10720 These were 'int' variables that could overflow on 64-bit hosts;
10721 they were never used, so remove them instead of repairing them.
211a0b2a 10722 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10723 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10724 Previously, this ceilinged at INT_MAX, but that doesn't work on
10725 64-bit machines.
e46bb31a 10726 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10727
c78baabf 10728 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10729 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10730 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10731 when a (possibly-narrower) signed value would do just as well.
10732 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10733
c9d624c6
PE
10734 * alloc.c: Catch some string size overflows that we were missing.
10735 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10736 for convenience in STRING_BYTES_MAX.
10737 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10738 The definition here is exact; the one in lisp.h was approximate.
10739 (allocate_string_data): Check for string overflow. This catches
10740 some instances we weren't catching before. Also, it catches
10741 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10742 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10743 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10744
c9d624c6
PE
10745 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10746 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10747 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10748
353032ce
PE
10749 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10750
2bccce07
PE
10751 * alloc.c (Fmake_string): Check for out-of-range init.
10752
0ac30604
SM
107532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10754
10755 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10756
c195f2de
JD
107572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10758
10759 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10760 xg_get_default_scrollbar_width.
10761
10762 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10763 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10764 (style_changed_cb): Call update_theme_scrollbar_width and call
10765 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10766 all frames (Bug#8505).
10767 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10768 Call gtk_window_set_resizable if HAVE_GTK3.
10769 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10770 and height if HAVE_GTK3 (Bug#8505).
10771 (scroll_bar_width_for_theme): New variable.
10772 (update_theme_scrollbar_width): New function.
10773 (xg_get_default_scrollbar_width): Move code to
10774 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10775 (xg_initialize): Call update_theme_scrollbar_width.
10776
10777 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10778
10779 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10780
e10ac9f1
MR
107812011-06-12 Martin Rudalics <rudalics@gmx.at>
10782
10783 * frame.c (make_frame): Call other_buffer_safely instead of
10784 other_buffer.
10785
10786 * window.c (temp_output_buffer_show): Call display_buffer with
10787 second argument Vtemp_buffer_show_specifiers and reset latter
10788 immediately after the call.
10789 (Vtemp_buffer_show_specifiers): New variable.
10790 (auto_window_vscroll_p, next_screen_context_lines)
10791 (Vscroll_preserve_screen_position): Remove leading asterisks from
10792 doc-strings.
10793
2d3c217e 107942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10795
7b7f97e8 10796 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10797 * buffer.c (Qclone_number): Remove for now, as it's unused.
10798 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10799 (record_buffer): Remove unused local.
10800 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10801 (set_frame_buffer_list): Remove; unused.
10802 * frame.h (other_visible_frames): Remove decl.
10803 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10804 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10805 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10806 if HAVE_GPM.
10807 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10808 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10809 Define only if HAVE_GPM.
10810 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10811 (update_hints_inhibit): Remove; never set. All uses removed.
10812 * widgetprv.h (emacsFrameClassRec): Remove decl.
10813 * window.c (delete_deletable_window): Now returns void, since it
10814 wasn't returning anything.
10815 (compare_window_configurations): Remove unused locals.
10816 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10817 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10818 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10819 the same widths as pointers. This follows up on the 2011-05-06 patch.
10820 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10821 * xterm.h: Likewise.
10822 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10823
1384b89e
JB
108242011-06-12 Juanma Barranquero <lekktu@gmail.com>
10825
10826 * makefile.w32-in: Update dependencies.
10827 (LISP_H): Add lib/intprops.h.
10828
1100a63c
CY
108292011-06-11 Chong Yidong <cyd@stupidchicken.com>
10830
10831 * image.c (gif_load): Add animation frame delay to the metadata.
10832 (syms_of_image): Use DEFSYM. New symbol `delay'.
10833
6198ccd0
MR
108342011-06-11 Martin Rudalics <rudalics@gmx.at>
10835
10836 * window.c (delete_deletable_window): Re-add.
10837 (Fset_window_configuration): Rewrite to handle dead buffers and
10838 consequently deletable windows.
10839 (window_tree, Fwindow_tree): Remove. Supply functionality in
10840 window.el.
10841 (compare_window_configurations): Simplify code.
10842
b6e3633c
AS
108432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10844
1ab0dee5
AS
10845 * image.c (imagemagick_load_image): Fix type mismatch.
10846 (Fimagemagick_types): Likewise.
10847
b6e3633c
AS
10848 * window.h (replace_buffer_in_windows): Declare.
10849
9397e56f
MR
108502011-06-11 Martin Rudalics <rudalics@gmx.at>
10851
10852 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10853 Qclone_number. Remove external declaration of Qdelete_window.
10854 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10855 code.
640c8776
SM
10856 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10857 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10858 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10859 buffer list implementation.
10860 (other_buffer_safely): New function.
10861 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10862 calls to replace_buffer_in_windows and
10863 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10864 if allowed.
10865 (record_buffer): Inhibit quitting and rewrite using quittable
10866 functions. Run Qbuffer_list_update_hook if allowed.
10867 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10868 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10869 Move switch-to-buffer to window.el.
9397e56f
MR
10870 (bury-buffer): Move to window.el.
10871 (Vbuffer_list_update_hook): New variable.
10872
10873 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10874 section.
10875
10876 * window.h (resize_frame_windows): Move up in code.
10877 (Fwindow_frame): Remove EXFUN.
10878 (replace_buffer_in_all_windows): Remove prototype.
10879 (replace_buffer_in_windows_safely): Add prototype.
10880
10881 * window.c: Declare Qdelete_window static again. Move down
10882 declaration of select_count.
10883 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10884 (Fother_window): Move to window.el.
10885 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10886 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10887 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10888 window.el.
10889 (replace_buffer_in_windows): Implement by calling
10890 Qreplace_buffer_in_windows.
10891 (replace_buffer_in_all_windows): Remove with some functionality
10892 moved into replace_buffer_in_windows_safely.
10893 (replace_buffer_in_windows_safely): New function.
10894 (select_window_norecord, select_frame_norecord): Move in front
10895 of run_window_configuration_change_hook. Remove now obsolete
10896 declarations.
640c8776
SM
10897 (Fset_window_buffer): Rewrite doc-string.
10898 Call Qrecord_window_buffer.
9397e56f
MR
10899 (keys_of_window): Move binding for other-window to window.el.
10900
b50691aa
CY
109012011-06-11 Chong Yidong <cyd@stupidchicken.com>
10902
10903 * dispextern.h (struct image): Replace data member, whose int_val
10904 and ptr_val fields were not used by anything, with a single
10905 lisp_val object.
10906
10907 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10908 (gif_clear_image, gif_load, imagemagick_load_image)
10909 (gs_clear_image, gs_load): Callers changed.
10910
3f754b86
PE
109112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10912
cca69397
PE
10913 * buffer.h: Include <time.h>, for time_t.
10914 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10915
109e28d0
PE
10916 Fix minor problems found by static checking.
10917
60737f02
PE
10918 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10919
4b66faf3
PE
10920 Make identifiers static if they are not used in other modules.
10921 * data.c (Qcompiled_function, Qframe, Qvector):
10922 * image.c (QimageMagick, Qsvg):
10923 * minibuf.c (Qmetadata):
10924 * window.c (resize_window_check, resize_root_window): Now static.
10925 * window.h (resize_window_check, resize_root_window): Remove decls.
10926
109e28d0
PE
10927 * window.c (window_deletion_count, delete_deletable_window):
10928 Remove; unused.
46a4ce9e
PE
10929 (window_body_lines): Now static.
10930 (Fdelete_other_windows_internal): Mark vars as initialized.
10931 Make sure 'resize_failed' is initialized.
10932 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10933 (resize_window_apply): Remove unused local.
10934 * window.h (delete_deletable_window): Remove decl.
10935
109e28d0 10936 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10937 (imagemagick_load_image): Fix pointer signedness problem by changing
10938 last arg from unsigned char * to char *. All uses changed.
10939 Also, fix a local for similar reasons.
10940 Remove unused locals. Remove locals to avoid shadowing.
10941 (fn_rsvg_handle_free): Remove; unused.
10942 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10943 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10944
3f754b86
PE
10945 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10946
2547adb1
CY
109472011-06-10 Chong Yidong <cyd@stupidchicken.com>
10948
10949 * image.c (gif_load): Fix omitted cast error introduced by
10950 2011-06-06 change.
10951
2c8e37d4
MR
109522011-06-10 Martin Rudalics <rudalics@gmx.at>
10953
10954 * window.h (resize_proportionally, orig_total_lines)
10955 (orig_top_line): Remove from window structure.
10956 (set_window_height, set_window_width, change_window_heights)
10957 (Fdelete_window): Remove prototypes.
10958 (resize_frame_windows): Remove duplicate declaration.
10959
440a42e3
EZ
109602011-06-10 Eli Zaretskii <eliz@gnu.org>
10961
10962 * window.h (resize_frame_windows, resize_window_check)
10963 (delete_deletable_window, resize_root_window)
10964 (resize_frame_windows): Declare prototypes.
10965
10966 * window.c (resize_window_apply): Make definition be "static" to
10967 match the prototype.
10968
562dd5e9
MR
109692011-06-10 Martin Rudalics <rudalics@gmx.at>
10970
10971 * window.c: Remove declarations of Qwindow_size_fixed,
10972 window_min_size_1, window_min_size_2, window_min_size,
10973 size_window, window_fixed_size_p, enlarge_window, delete_window.
10974 Remove static from declaration of Qdelete_window, it's
10975 temporarily needed by Fbury_buffer.
10976 (replace_window): Don't assign orig_top_line and
10977 orig_total_lines.
10978 (Fdelete_window, delete_window): Remove. Window deletion is
10979 handled by window.el.
640c8776
SM
10980 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10981 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10982 (Fdelete_other_windows): Remove. Deleting other windows is
10983 handled by window.el.
10984 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10985 handled in window.el.
10986 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10987 Window minimum sizes are handled in window.el.
10988 (shrink_windows, size_window, set_window_height)
10989 (set_window_width, change_window_heights, window_height)
10990 (window_width, CURBEG, CURSIZE, enlarge_window)
10991 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10992 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10993 handled in window.el.
10994 (make_dummy_parent): Rename to make_parent_window and give it a
10995 second argument horflag.
10996 (make_window): Don't set resize_proportionally any more.
10997 (Fsplit_window): Remove. Windows are split in window.el.
10998 (save_restore_action, save_restore_orig_size)
10999 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11000 Resize mini windows in window.el.
11001 (grow_mini_window, shrink_mini_window): Implement by calling
11002 Qresize_root_window_vertically, resize_window_check and
11003 resize_window_apply.
640c8776
SM
11004 (saved_window, Fset_window_configuration, save_window_save):
11005 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11006 resize_proportionally.
11007 (window_min_height, window_min_width): Move to window.el.
11008 (keys_of_window): Move bindings for delete-other-windows,
11009 split-window, delete-window and enlarge-window to window.el.
11010
11011 * buffer.c: Temporarily extern Qdelete_window.
11012 (Fbury_buffer): Temporarily call Qdelete_window instead of
11013 Fdelete_window (Fbury_buffer will move to window.el soon).
11014
11015 * frame.c (set_menu_bar_lines_1): Remove code handling
11016 orig_top_line and orig_total_lines.
11017
11018 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11019 set_window_height but set heights directly.
11020 (change_frame_size_1): Use resize_frame_windows.
11021
11022 * xdisp.c (init_xdisp): Don't use set_window_height but set
11023 heights directly.
11024
640c8776
SM
11025 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11026 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11027 run_window_configuration_change_hook.
11028
11029 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11030 instead of change_window_heights and run
11031 run_window_configuration_change_hook.
11032
1a13852e
MR
110332011-06-09 Martin Rudalics <rudalics@gmx.at>
11034
11035 * window.c (replace_window): Rename second argument REPLACEMENT to
11036 NEW. New third argument SETFLAG. Rewrite.
11037 (delete_window, make_dummy_parent): Call replace_window with
11038 third argument 1.
11039 (window_list_1): Move down in code.
11040 (run_window_configuration_change_hook): Move set_buffer part
11041 before select_frame_norecord part in order to unwind correctly.
11042 Rename count1 to count.
11043 (recombine_windows, delete_deletable_window, resize_root_window)
11044 (Fdelete_other_windows_internal)
11045 (Frun_window_configuration_change_hook, make_parent_window)
11046 (resize_window_check, resize_window_apply, Fresize_window_apply)
11047 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11048 (Fdelete_window_internal, Fresize_mini_window_internal):
11049 New functions.
1a13852e
MR
11050 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11051
f3d1777e
MR
110522011-06-08 Martin Rudalics <rudalics@gmx.at>
11053
496e208e
MR
11054 * window.h (window): Add some new members to window structure -
11055 normal_lines, normal_cols, new_total, new_normal, clone_number,
11056 splits, nest, prev_buffers, next_buffers.
11057 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11058 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11059
f3d1777e
MR
11060 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11061 Remove.
496e208e
MR
11062 (make_dummy_parent): Set new members of windows structure.
11063 (make_window): Move down in code. Handle new members of window
11064 structure.
11065 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11066 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11067 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11068 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11069 (Fset_window_next_buffers, Fset_window_clone_number):
11070 New functions.
496e208e
MR
11071 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11072 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11073 Doc-string fixes.
11074 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11075 Argument WINDOW can be now internal window too.
11076 (Fwindow_use_time): Move up in code.
11077 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11078 Rewrite doc-string.
11079 (Fset_window_configuration, saved_window)
11080 (Fcurrent_window_configuration, save_window_save): Handle new
11081 members of window structure.
b9e809c2
MR
11082 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11083 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11084 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11085 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11086 Qget_mru_window, Qresize_root_window,
11087 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11088 Qauto_buffer_name; staticpro them.
f3d1777e 11089
abde8f8c
MR
110902011-06-07 Martin Rudalics <rudalics@gmx.at>
11091
11092 * window.c (Fwindow_total_size, Fwindow_left_column)
11093 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11094 (Fwindow_list_1): New functions.
11095 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11096 (Fwindow_width, Fscroll_left, Fscroll_right):
11097 Use window_body_cols instead of window_box_text_cols.
11098 (delete_window, Fset_window_configuration):
11099 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11100 (delete_all_subwindows): Take a window as argument and not a
11101 structure. Rewrite.
190b47e6
MR
11102 (window_loop): Remove handling of GET_LRU_WINDOW and
11103 GET_LARGEST_WINDOW.
11104 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11105
11106 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11107 window_box_text_cols. delete_all_subwindows now takes a
11108 Lisp_Object as argument.
abde8f8c 11109
640c8776
SM
11110 * indent.c (compute_motion, Fcompute_motion):
11111 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11112
fa8a67e6
MR
11113 * frame.c (delete_frame): Call delete_all_subwindows with root
11114 window as argument.
11115
a54e3482
DC
111162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11117
11118 * fns.c (Fputhash): Document return value.
11119
60002bf5
CY
111202011-06-06 Chong Yidong <cyd@stupidchicken.com>
11121
11122 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11123
0c671da6 111242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11125
b862a52a 11126 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11127
be44ca6c
PE
11128 Check for overflow when converting integer to cons and back.
11129 * charset.c (Fdefine_charset_internal, Fdecode_char):
11130 Use cons_to_unsigned to catch overflow.
11131 (Fencode_char): Use INTEGER_TO_CONS.
11132 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11133 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11134 * data.c (long_to_cons, cons_to_long): Remove.
11135 (cons_to_unsigned, cons_to_signed): New functions.
11136 These signal an error for invalid or out-of-range values.
11137 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11138 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11139 * font.c (Ffont_variation_glyphs):
11140 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11141 * lisp.h: Include <intprops.h>.
11142 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11143 (cons_to_signed, cons_to_unsigned): New decls.
11144 (long_to_cons, cons_to_long): Remove decls.
11145 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11146 (Fprimitive_undo): Use CONS_TO_INTEGER.
11147 * xfns.c (Fx_window_property): Likewise.
11148 * xselect.c: Include <limits.h>.
11149 (x_own_selection, selection_data_to_lisp_data):
11150 Use INTEGER_TO_CONS.
11151 (x_handle_selection_request, x_handle_selection_clear)
11152 (x_get_foreign_selection, Fx_disown_selection_internal)
11153 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11154 (lisp_data_to_selection_data): Use cons_to_unsigned.
11155 (x_fill_property_data): Use cons_to_signed.
11156 Report values out of range.
11157
d1f3d2af
PE
11158 Check for buffer and string overflow more precisely.
11159 * buffer.h (BUF_BYTES_MAX): New macro.
11160 * lisp.h (STRING_BYTES_MAX): New macro.
11161 * alloc.c (Fmake_string):
11162 * character.c (string_escape_byte8):
11163 * coding.c (coding_alloc_by_realloc):
11164 * doprnt.c (doprnt):
11165 * editfns.c (Fformat):
11166 * eval.c (verror):
11167 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11168 since they may not be the same number.
11169 * editfns.c (Finsert_char):
11170 * fileio.c (Finsert_file_contents):
11171 Likewise for BUF_BYTES_MAX.
11172
dd52fcea
PE
11173 * image.c: Use ptrdiff_t, not int, for sizes.
11174 (slurp_file): Switch from int to ptrdiff_t.
11175 All uses changed.
11176 (slurp_file): Check that file size fits in both size_t (for
11177 malloc) and ptrdiff_t (for sanity and safety).
11178
7f9bbdbb
PE
11179 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11180 if b->modtime has its maximal value.
11181
dfe18f82
PE
11182 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11183
84acfcf0
PE
11184 Don't assume time_t can fit into int.
11185 * buffer.h (struct buffer.modtime): Now time_t, not int.
11186 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11187 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11188
ccd9a01a
PE
11189 Minor fixes for signed vs unsigned integers.
11190 * character.h (MAYBE_UNIFY_CHAR):
11191 * charset.c (maybe_unify_char):
11192 * keyboard.c (read_char, reorder_modifiers):
11193 XINT -> XFASTINT, since the integer must be nonnegative.
11194 * ftfont.c (ftfont_spec_pattern):
11195 * keymap.c (access_keymap, silly_event_symbol_error):
11196 XUINT -> XFASTINT, since the integer must be nonnegative.
11197 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11198 since it makes no difference and we prefer signed.
11199 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11200 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11201 nonnegative.
11202
d6d100dd
SM
112032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11204
11205 * window.h (Fwindow_frame): Declare.
11206
2b6148e4
PE
112072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11208
11209 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11210 (SPARE_MEMORY): Always define.
11211 (LARGE_REQUEST): Remove.
11212 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11213
f230ecc9
MR
112142011-06-06 Martin Rudalics <rudalics@gmx.at>
11215
727e958e
MR
11216 * lisp.h: Move EXFUNS for Fframe_root_window,
11217 Fframe_first_window and Fset_frame_selected_window to window.h.
11218
11219 * window.h: Move EXFUNS for Fframe_root_window,
11220 Fframe_first_window and Fset_frame_selected_window here from
11221 lisp.h.
11222
11223 * frame.c (Fwindow_frame, Fframe_first_window)
11224 (Fframe_root_window, Fframe_selected_window)
11225 (Fset_frame_selected_window): Move to window.c.
11226 (Factive_minibuffer_window): Move to minibuf.c.
11227 (Fother_visible_frames_p): New function.
11228
11229 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11230
f230ecc9
MR
11231 * window.c (decode_window, decode_any_window): Move up in code.
11232 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11233 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11234 (Fwindow_buffer): Move up and rewrite doc-string.
11235 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11236 (Fwindow_prev): New functions.
727e958e
MR
11237 (Fwindow_frame): Move here from frame.c. Accept any window as
11238 argument.
11239 (Fframe_root_window, Fframe_first_window)
11240 (Fframe_selected_window): Move here from frame.c. Accept frame
11241 or arbitrary window as argument. Update doc-strings.
11242 (Fminibuffer_window): Move up in code.
11243 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11244 (Fset_frame_selected_window): Move here from frame.c.
11245 Marginal rewrite.
727e958e
MR
11246 (Fselected_window, select_window, Fselect_window): Move up in
11247 code. Minor doc-string fixes.
f230ecc9 11248
4d09bcf6
PE
112492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11250
11251 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11252 Do not assume that spare memory exists; that assumption is valid
11253 only if SYSTEM_MALLOC.
11254 (LARGE_REQUEST): New macro, so that the issue of large requests
11255 is separated from the issue of spare memory.
11256
810928a2
AS
112572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11258
172418ad
AS
11259 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11260 format. (Bug#8806)
11261
43f862f7
AS
11262 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11263
810928a2
AS
11264 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11265 before statements.
11266
a059fe24
JD
112672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11268
11269 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11270
11271 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11272
11273 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11274 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11275
989bf368
JB
112762011-06-05 Juanma Barranquero <lekktu@gmail.com>
11277
11278 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11279
4b80f674
CY
112802011-06-04 Chong Yidong <cyd@stupidchicken.com>
11281
11282 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11283 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11284 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11285 New error handlers.
4b80f674
CY
11286 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11287 Obey Vx_select_enable_clipboard_manager. Catch errors in
11288 x_clipboard_manager_save (Bug#8779).
11289 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11290 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11291
99a33b77 112922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11293
11294 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11295
99a33b77 112962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11297
11298 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11299 in the current matrix if keep_current_p is non-zero.
11300
8264569d
EZ
113012011-06-04 Eli Zaretskii <eliz@gnu.org>
11302
11303 * bidi.c (bidi_level_of_next_char): Fix last change.
11304
57f97249
EZ
113052011-06-03 Eli Zaretskii <eliz@gnu.org>
11306
fec2107c 11307 Support bidi reordering of text covered by display properties.
57f97249 11308
fec2107c
EZ
11309 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11310 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11311 (bidi_cache_search, bidi_cache_iterator_state)
11312 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11313 (bidi_level_of_next_char, bidi_move_to_visually_next):
11314 Support character positions inside a run of characters covered by a
fec2107c
EZ
11315 display string.
11316 (bidi_paragraph_init, bidi_resolve_explicit_1)
11317 (bidi_level_of_next_char): Call bidi_fetch_char and
11318 bidi_fetch_char_advance instead of FETCH_CHAR and
11319 FETCH_CHAR_ADVANCE.
11320 (bidi_init_it): Initialize new members.
11321 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11322 definitions.
11323 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11324 instead of using explicit *_CHAR codes.
d6d100dd
SM
11325 (bidi_resolve_explicit, bidi_resolve_weak):
11326 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11327 bidirectional text is supported only in multibyte buffers.
11328 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11329 it to initialize the frame_window_p member of struct bidi_it.
11330 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11331 (bidi_resolve_explicit, bidi_resolve_weak)
11332 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11333 bidi_it->nchars is non-positive.
11334 (bidi_level_of_next_char): Don't try to lookup the cache for the
11335 next/previous character if nothing is cached there yet, or if we
11336 were just reseat()'ed to a new position.
c40e2fb2 11337
0e14fe90
EZ
11338 * xdisp.c (set_cursor_from_row): Set start and stop points
11339 according to the row's direction when priming the loop that looks
11340 for the glyph on which to display cursor.
11341 (single_display_spec_intangible_p): Function deleted.
11342 (display_prop_intangible_p): Reimplement to call
11343 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11344 Accept 3 additional arguments needed by handle_display_spec.
11345 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11346 values: lists, `(when COND...)' forms, etc.
11347 (single_display_spec_string_p): Support property values that are
11348 lists with the argument STRING its top-level element.
11349 (display_prop_string_p): Fix the condition for processing a
11350 property that is a list to be consistent with handle_display_spec.
fec2107c 11351 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11352 last portion of handle_display_prop.
11353 (compute_display_string_pos): Accept additional argument
11354 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11355 value of a `display' property is a "replacing spec".
11356 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11357 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11358 the display property, but just return a value indicating whether
11359 the display property will replace the characters it covers.
11360 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11361 frame_window_p members of struct bidi_it.
d6d100dd
SM
11362 (compute_display_string_pos, compute_display_string_end):
11363 New functions.
fec2107c
EZ
11364 (push_it): Accept second argument POSITION, where pop_it should
11365 jump to continue iteration.
11366 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11367
fec2107c
EZ
11368 * keyboard.c (adjust_point_for_property): Adjust the call to
11369 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11370
11371 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11372 (bidi_init_it): Update prototypes.
11373 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11374 (compute_display_string_pos, compute_display_string_end):
11375 Declare prototypes.
fec2107c
EZ
11376 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11377 EMACS_INT.
fc6f18ce 11378
40087514 113792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11380
57f53182
PE
11381 Malloc failure behavior now depends on size of allocation.
11382 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11383 * lisp.h: Change signatures accordingly.
11384 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11385 All callers changed. (Bug#8762)
11386
11387 * gnutls.c: Use Emacs's memory allocators.
11388 Without this change, the gnutls library would invoke malloc etc.
11389 directly, which causes problems on non-SYNC_INPUT hosts, and which
11390 runs afoul of improving memory_full behavior. (Bug#8761)
11391 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11392 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11393 xfree instead of the default malloc, realloc, free.
11394 (Fgnutls_boot): No need to check for memory allocation failure,
11395 since xmalloc does that for us.
11396
ac32cd99 11397 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11398 * category.c (hash_get_category_set):
11399 * ccl.c (ccl_driver):
11400 * charset.c (Fdefine_charset_internal):
11401 * charset.h (struct charset.hash_index):
11402 * composite.c (get_composition_id, gstring_lookup_cache)
11403 (composition_gstring_put_cache):
11404 * composite.h (struct composition.hash_index):
11405 * dispextern.h (struct image.hash):
11406 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11407 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11408 (hashfn_equal, hashfn_user_defined, make_hash_table)
11409 (maybe_resize_hash_table, hash_lookup, hash_put)
11410 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11411 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11412 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11413 * image.c (make_image, search_image_cache, lookup_image)
11414 (xpm_put_color_table_h):
11415 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11416 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11417 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11418 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11419 * alloc.c (allocate_vectorlike):
11420 Check for overflow in vector size calculations.
11421 * ccl.c (ccl_driver):
11422 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11423 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11424 need to be updated by these changes.
40087514
PE
11425 * fns.c (make_hash_table, maybe_resize_hash_table):
11426 Check for integer overflow with large hash tables.
0de4bb68
PE
11427 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11428 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11429 (SXHASH_REDUCE): New macro.
11430 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11431 Use it instead of discarding useful hash info with large hash values.
11432 (sxhash_float): New function.
11433 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11434 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11435 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11436 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11437 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11438 Adjust signatures to match updated version of code.
11439 (consing_since_gc): Now EMACS_INT, since a single hash table can
11440 use more than INT_MAX bytes.
11441
698d32e2
DN
114422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11443
11444 Make it possible to build with GCC-4.6+ -O2 -flto.
11445
11446 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11447
fd6fa53f
SM
114482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11449
11450 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11451 Call minibuffer-inactive-mode.
11452
864db017
JB
114532011-05-31 Juanma Barranquero <lekktu@gmail.com>
11454
11455 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11456 Update dependencies.
11457
2ad0baf4
DN
114582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11459
11460 * data.c (init_data): Remove code for UTS, this system is not
11461 supported anymore.
11462
4fcc2638
DN
114632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11464
11465 Don't force ./temacs to start in terminal mode.
11466
11467 * frame.c (make_initial_frame): Initialize faces in all cases, not
11468 only when CANNOT_DUMP is defined.
11469 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11470
c56e0fd5
DN
114712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11472
11473 * dispnew.c (add_window_display_history): Use const for the string
11474 pointer. Remove declaration, not needed.
11475
333d54da 114762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11477
55d4c1b2 11478 Use 'inline', not 'INLINE'.
333d54da 11479 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11480 * alloc.c, fontset.c (INLINE): Remove.
11481 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11482 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11483 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11484 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11485 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11486
738db178
DN
114872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11488
11489 Make it possible to run ./temacs.
11490
11491 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11492 syms_of_callproc does the same thing. Remove test for
11493 "initialized", do it in the caller.
11494 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11495
620c53a6
SM
114962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11497
11498 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11499 (read_minibuf): Use get_minibuffer.
11500 (syms_of_minibuf): Use DEFSYM.
11501 (Qmetadata): New var.
11502 * data.c (Qbuffer): Don't make it static.
11503 (syms_of_data): Use DEFSYM.
11504
e003a292
PE
115052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11506
11507 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11508 (CCL_CODE_MIN): New macro.
11509
ed008a6d
PE
115102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11511
3687c2ef
PE
11512 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11513
ed008a6d
PE
11514 * eval.c (Qdebug): Now static.
11515 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11516 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11517 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11518
d66c4c7c
CY
115192011-05-29 Chong Yidong <cyd@stupidchicken.com>
11520
11521 * image.c: Various fixes to ImageMagick code comments.
11522 (Fimagemagick_types): Doc fix.
11523
5fbc2025
PE
115242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11525
0196f88a
PE
11526 Minor fixes prompted by GCC 4.6.0 warnings.
11527
11528 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11529
5fbc2025
PE
11530 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11531 (x_clipboard_manager_save_all): Move extern decl to ...
11532 * xterm.h: ... here, so that it can be checked for consistency.
11533
1dd3c2d9
CY
115342011-05-29 Chong Yidong <cyd@stupidchicken.com>
11535
11536 * xselect.c (x_clipboard_manager_save_frame)
11537 (x_clipboard_manager_save_all): New functions.
11538 (Fx_clipboard_manager_save): Lisp function deleted.
11539
11540 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11541 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11542
11543 * xterm.h: Update prototype.
11544
5ba6571d
WX
115452011-05-28 William Xu <william.xwl@gmail.com>
11546
11547 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11548 exiting (Bug#8239).
11549
3eaff834
JM
115502011-05-28 Jim Meyering <meyering@redhat.com>
11551
e1900994 11552 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11553 * fns.c (to_uchar): Define.
11554 (crypto_hash_function): Use it to convert some newly-signed
11555 variables to unsigned, to avoid sign-extension bugs. For example,
11556 without this change, (md5 "truc") would evaluate to
11557 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11558 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11559 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11560
0f6990a7
PE
115612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11562
11563 Integer overflow fixes.
c8a9ca5a 11564
08686060
PE
11565 * dbusbind.c: Serial number integer overflow fixes.
11566 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11567 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11568 to hold a serial number that is too large for a fixnum.
11569 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11570 Check for serial numbers out of range. Decode any serial number
59568bf0 11571 that was so large that it became a float. (Bug#8722)
08686060 11572
2d1fc3c7
PE
11573 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11574 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11575 Use XFASTINT rather than XUINT when numbers are nonnegative.
11576 (xd_append_arg, Fdbus_method_return_internal):
11577 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11578 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11579 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11580 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11581 (Bug#8722)
2d1fc3c7 11582
c8a9ca5a
PE
11583 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11584
519e1d69
PE
11585 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11586
6df6ae42 11587 ccl: Add integer overflow checks.
30569699
PE
11588 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11589 (IN_INT_RANGE): New macros.
11590 (ccl_driver): Use them to check for integer overflow when
11591 decoding a CCL program. Many of the new checks are whether XINT (x)
11592 fits in int; it doesn't always, on 64-bit hosts. The new version
11593 doesn't catch all possible integer overflows, but it's an
847044ea 11594 improvement. (Bug#8719)
30569699 11595
c11285dc
PE
11596 * alloc.c (make_event_array): Use XINT, not XUINT.
11597 There's no need for unsigned here.
11598
fdccd48e
PE
11599 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11600 This follows up to the 2011-05-06 change that substituted uintptr_t
11601 for EMACS_INT. This case wasn't caught back then.
11602
37910ab2
PE
11603 Rework Fformat to avoid integer overflow issues.
11604 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11605 now (part of C89). Include <verify.h>.
11606 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11607 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11608 (Fformat): Avoid the prepass trying to compute sizes; it was only
11609 approximate and thus did not catch overflow reliably. Instead, walk
11610 through the format just once, formatting and computing sizes as we go,
11611 checking for integer overflow at every step, and allocating a larger
11612 buffer as needed. Keep track separately whether the format is
11613 multibyte. Keep only the most-recently calculated precision, rather
11614 than them all. Record whether each argument has been converted to
11615 string. Use EMACS_INT, not int, for byte and char and arg counts.
11616 Support field widths and precisions larger than INT_MAX. Avoid
11617 sprintf's undefined behavior with conversion specifications such as %#d
11618 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11619 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11620 formatting out-of-range floating point numbers with int
9173deec 11621 formats. (Bug#8668)
37910ab2 11622
2e6578fb
PE
11623 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11624
0ae6bdee
PE
11625 * data.c: Avoid integer truncation in expressions involving floats.
11626 * data.c: Include <intprops.h>.
11627 (arith_driver): When there's an integer overflow in an expression
11628 involving floating point, convert the integers to floating point
11629 so that the resulting value does not suffer from catastrophic
11630 integer truncation. For example, on a 64-bit host (* 4
11631 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11632 Do not rely on undefined behavior after integer overflow.
11633
de883a70
PE
11634 merge count_size_as_multibyte, parse_str_to_multibyte
11635 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11636 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11637 Check for integer overflow.
11638 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11639 since it's now a duplicate of the other. This is more of
11640 a character than a buffer op, so better that it's in character.c.
11641 * fns.c, print.c: Adjust to above changes.
11642
2ff916cb
PE
116432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11644
11645 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11646
f1b54466
PE
116472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11648
fb1ac845
PE
11649 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11650 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11651 (x_clipboard_manager_save): Now static.
11652 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11653
f1b54466
PE
11654 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11655 (crypto_hash_function): Now static.
11656 Fix pointer signedness problems. Avoid unnecessary initializations.
11657
a9f737ee
CY
116582011-05-27 Chong Yidong <cyd@stupidchicken.com>
11659
11660 * termhooks.h (Vselection_alist): Make it terminal-local.
11661
11662 * terminal.c (create_terminal): Initialize it.
11663
11664 * xselect.c: Support for clipboard managers.
11665 (Vselection_alist): Move to termhooks.h as terminal-local var.
11666 (LOCAL_SELECTION): New macro.
11667 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11668 (symbol_to_x_atom): Remove gratuitous arg.
11669 (x_handle_selection_request, lisp_data_to_selection_data)
11670 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11671 (x_own_selection, x_get_local_selection, x_convert_selection):
11672 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11673 (some_frame_on_display): Delete unused function.
11674 (Fx_own_selection_internal, Fx_get_selection_internal)
11675 (Fx_disown_selection_internal, Fx_selection_owner_p)
11676 (Fx_selection_exists_p): New optional frame arg.
11677 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11678 (x_handle_selection_clear): Don't treat other terminals with the
11679 same keyboard specially. Use the terminal-local Vselection_alist.
11680 (x_clear_frame_selections): Use Frun_hook_with_args.
11681
11682 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11683
11684 * xterm.h: Add support for those atoms.
11685
e067f0c1
CY
116862011-05-26 Chong Yidong <cyd@stupidchicken.com>
11687
11688 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11689 (converted_selections, conversion_fail_tag): New global variables.
11690 (x_selection_request_lisp_error): Free the above.
11691 (x_get_local_selection): Remove unnecessary code.
11692 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11693 of converted selections stored in converted_selections.
11694 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11695 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11696 (x_convert_selection): New function.
11697 (x_handle_selection_event): Simplify.
11698 (x_get_foreign_selection): Don't ignore incoming requests while
11699 waiting for an answer; this will fail when we implement
11700 SAVE_TARGETS, and seems unnecessary anyway.
11701 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11702 (Vx_sent_selection_functions): Doc fix.
11703
0f4aebc0
LL
117042011-05-26 Leo Liu <sdl.web@gmail.com>
11705
11706 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11707
e61124cd
YM
117082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11709
11710 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11711
11712 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11713 for fringe update if it has periodic bitmap.
ac389d0c 11714 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11715 and fringe_bitmap_periodic_p.
11716
11717 * fringe.c (get_fringe_bitmap_data): New function.
11718 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11719 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11720 row. Mark glyph row for fringe update if periodicity changed.
11721
11722 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11723 for fringe update unless it has periodic bitmap.
11724
f16d9837
KH
117252011-05-25 Kenichi Handa <handa@m17n.org>
11726
11727 * xdisp.c (get_next_display_element): Set correct it->face_id for
11728 a static composition.
11729
e1b90ef6
LL
117302011-05-24 Leo Liu <sdl.web@gmail.com>
11731
11732 * deps.mk (fns.o):
11733 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11734
11735 * fns.c (crypto_hash_function, Fsha1): New function.
11736 (Fmd5): Use crypto_hash_function.
11737 (syms_of_fns): Add Ssha1.
11738
7400048f
PE
117392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11740
11741 * gnutls.c: Remove unused macros.
11742 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11743 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11744 Remove macros that are defined and never used.
11745 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11746
abb71cf4
CY
117472011-05-22 Chong Yidong <cyd@stupidchicken.com>
11748
11749 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11750 (Fx_get_selection_internal): Minor cleanup.
11751 (Fx_own_selection_internal): Rename arguments for consistency with
11752 select.el.
11753
6307db39
PE
117542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11755
11756 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11757
f3d4e0a4
CY
117582011-05-22 Chong Yidong <cyd@stupidchicken.com>
11759
11760 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11761
4d8ade89
YM
117622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11763
11764 * dispnew.c (scrolling_window): Don't exclude the case that the
11765 last enabled row in the desired matrix touches the bottom boundary.
11766
32078c8d
GM
117672011-05-21 Glenn Morris <rgm@gnu.org>
11768
11769 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11770 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11771 and add some more files.
32078c8d 11772
7285dc67
EZ
117732011-05-20 Eli Zaretskii <eliz@gnu.org>
11774
11775 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11776 report_file_error introduced by the change from 2011-05-07.
11777
89d1bd22
PE
117782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11779
11780 * systime.h (Time): Define only if emacs is defined.
11781 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11782 where the include path doesn't have X11/X.h by default. See
11783 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11784
cd394be1 117852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11786
11787 * composite.c (find_automatic_composition): Fix previous change.
11788
b9704ad9
GM
117892011-05-20 Glenn Morris <rgm@gnu.org>
11790
11791 * lisp.mk: New file, split from Makefile.in.
11792 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11793 (shortlisp): Remove.
11794 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11795
4a720484
GM
117962011-05-19 Glenn Morris <rgm@gnu.org>
11797
11798 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11799 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11800 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11801 (lisp): Set the order to that of loadup.el.
11802 (shortlisp): Make it a copy of $lisp.
11803 (SOME_MACHINE_LISP): Remove.
11804 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11805 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11806
a28d4396
KH
118072011-05-18 Kenichi Handa <handa@m17n.org>
11808
11809 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11810 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11811 (find_automatic_composition): Mostly rewrite for efficiency.
11812
a2b1fa8e
JB
118132011-05-18 Juanma Barranquero <lekktu@gmail.com>
11814
11815 * makefile.w32-in: Update dependencies.
11816
8e1f5610
CS
118172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11818
11819 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11820 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11821
7025ee00 118222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11823
cdfa6eab
PE
11824 Fix some integer overflow issues, such as string length overflow.
11825
06d6db33
PE
11826 * insdel.c (count_size_as_multibyte): Check for string overflow.
11827
2b4560a8
PE
11828 * character.c (lisp_string_width): Check for string overflow.
11829 Use EMACS_INT, not int, for string indexes and lengths; in
11830 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11831 the resulting string length overflows an EMACS_INT; instead,
11832 report a string overflow if no precision given. When checking for
11833 precision exhaustion, use a check that cannot possibly have
11834 integer overflow. (Bug#8675)
11835 * character.h (lisp_string_width): Adjust to new signature.
11836
cb93f9be
PE
11837 * alloc.c (string_overflow): New function.
11838 (Fmake_string): Use it. This doesn't change behavior, but saves
11839 a few bytes and will simplify future changes.
11840 * character.c (string_escape_byte8): Likewise.
11841 * lisp.h (string_overflow): New decl.
11842
1a1f3366
PE
11843 Fixups, following up to the user-interface timestamp change.
11844 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11845 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11846 * msdos.c (mouse_get_pos): Likewise.
11847 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11848 * w32gui.h (Time): Define by including "systime.h" rather than by
11849 declaring it ourselves. (Bug#8664)
11850
d4e3e4d3
PE
11851 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11852 * image.c (clear_image_cache): Likewise.
11853
f6a24d19
PE
11854 * term.c (term_mouse_position): Don't assume time_t wraparound.
11855
08dc5ae6
PE
11856 Be more systematic about user-interface timestamps.
11857 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11858 and sometimes 'EMACS_UINT', to represent these timestamps.
11859 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11860 This makes the code easier to follow, and makes it easier to catch
11861 integer overflow bugs such as Bug#8664.
11862 * frame.c (Fmouse_position, Fmouse_pixel_position):
11863 Use Time, not unsigned long, for user-interface timestamps.
11864 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11865 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11866 * keyboard.h (last_event_timestamp): Likewise.
11867 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11868 * menu.h (xmenu_show): Likewise.
11869 * term.c (term_mouse_position): Likewise.
11870 * termhooks.h (struct input_event.timestamp): Likewise.
11871 (struct terminal.mouse_position_hook): Likewise.
11872 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11873 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11874 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11875 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11876 what it was before.
11877 * menu.h, termhooks.h: Include "systime.h", for Time.
11878
8e55734a
PE
11879 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11880 Don't assume that the difference between two unsigned long values
11881 can fit into an integer. At this point, we know button_down_time
11882 <= event->timestamp, so the difference must be nonnegative, so
11883 there's no need to cast the result if double-click-time is
11884 nonnegative, as it should be; check that it's nonnegative, just in
11885 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11886 apart (about 25 days). (Bug#8664)
8e55734a 11887
841f1b75 11888 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11889 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11890
3e26f69c
PE
11891 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11892 that always fit in int. Use a sentinel instead of a counter, to
11893 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11894 * frame.h (struct frame): Use int for menu_bar_items_used
11895 instead of EMACS_INT, since it always fits in int.
3e26f69c 11896
5cc152c0
PE
11897 * menu.c (grow_menu_items): Check for int overflow.
11898
d89eb65e
PE
11899 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11900
5235bd3e
PE
11901 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11902 Before, the code was not consistent. These values cannot exceed
11903 2**31 - 1 so there's no need to make them unsigned.
11904 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11905 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11906 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11907 as modifiers.
11908 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11909
bc827e23
PE
11910 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11911 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11912 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11913 presumably because the widths might not match.
11914
78eb494e
PE
11915 * window.c (size_window): Avoid needless test at loop start.
11916
04f2d78b
CB
119172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11918
11919 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11920
d2fc7e3d 119212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11922
11923 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11924
d2fc7e3d 119252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11926
11927 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11928 `width' to `bar_area_x' and `bar_area_width', respectively.
11929 (x_scroll_run): Take account of fringe background extension.
11930
04f2d78b
CB
11931 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11932 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11933 `bar_area_width', respectively.
11934 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11935 background extension.
11936
79b70037
GM
119372011-05-10 Jim Meyering <meyering@redhat.com>
11938
11939 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11940
2f142cc5
JB
119412011-05-10 Juanma Barranquero <lekktu@gmail.com>
11942
11943 * image.c (Finit_image_library): Return t for built-in image types,
11944 like pbm and xbm. (Bug#8640)
11945
57679c86
AS
119462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11947
11948 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11949
888c9e86
EZ
119502011-05-07 Eli Zaretskii <eliz@gnu.org>
11951
b0512a1d
EZ
11952 * w32console.c (Fset_screen_color): Doc fix.
11953 (Fget_screen_color): New function.
11954 (syms_of_ntterm): Defsubr it.
11955
7285dc67
EZ
11956 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11957 unlink the temporary file if Fcall_process didn't create it in the
11958 first place.
11959 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11960 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11961 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11962 cue to call_process_cleanup not to close that handle.
11963
4d3fcc8e
BK
119642011-05-07 Ben Key <bkey76@gmail.com>
11965
11966 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11967 one of two shell specific rules, either bootstrap-temacs-CMD or
11968 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11969 to the previous implementation of the bootstrap-temacs rule.
11970 The bootstrap-temacs-CMD rule is similar to the previous
11971 implementation of the bootstrap-temacs rule except that it
11972 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11973 variable.
11974
11975 These changes, along with some changes to nt/configure.bat,
11976 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11977 earlier fix to add support for --cflags and --ldflags options
11978 that include quotes so that it works whether make uses cmd or
11979 sh as the shell.
11980
b4289b64
MA
119812011-05-06 Michael Albinus <michael.albinus@gmx.de>
11982
11983 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11984 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11985 is a constant.
11986 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11987 a string. Handle both cases.
11988 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11989 (Fdbus_register_method): Use Qinvalid_function.
11990
af4c0e28
JB
119912011-05-06 Juanma Barranquero <lekktu@gmail.com>
11992
11993 * makefile.w32-in: Update dependencies.
11994 (LISP_H): Add inttypes.h and stdin.h.
11995 (PROCESS_H): Add unistd.h.
11996
c51453d9
EZ
119972011-05-06 Eli Zaretskii <eliz@gnu.org>
11998
11999 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12000 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12001
8ff0ac3c 120022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12003
4c4b566b
PE
12004 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12005
aab2b9b5
PE
12006 * term.c (vfatal): Remove stray call to va_end.
12007 It's not needed and the C Standard doesn't allow it here anyway.
12008
c378da0b
PE
12009 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12010 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12011
288b08c7
PE
12012 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12013 bytes.
12014
e3601888
PE
12015 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12016
db6c0e74
PE
12017 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12018
dd5963ea
PE
12019 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12020
88c9450f
PE
12021 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12022
2f9442b8
PE
12023 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12024
c032b5f8
PE
12025 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12026 * charset.c (Fdefine_charset_internal): Don't initialize
12027 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12028 32-bit int (Bug#8600).
a108c10b
PE
12029
12030 * lread.c (read_integer): Be more consistent with string-to-number.
12031 Use string_to_number to do the actual conversion; this avoids
12032 rounding errors and fixes some other screwups. Without this fix,
12033 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12034 (digit_to_number): Move earlier, for benefit of read_integer.
12035 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12036 not a digit in any supported base. (Bug#8602)
a108c10b 12037
ad5f9eea
PE
12038 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12039
aec1708a
PE
12040 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12041 to match comment at start of function. This also removes a
12042 GCC warning about overflow in a 32+64-bit port.
12043
47be4ab5
PE
12044 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12045
371cac43
PE
12046 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12047 Reported by Stefan Monnier in
12048 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12049 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12050 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12051
d01a7826
PE
12052 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12053 (EMACS_UINTPTR): Likewise, with uintptr_t.
12054
7fd47d5c
PE
12055 * lisp.h: Prefer 64-bit EMACS_INT if available.
12056 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12057 on 32-bit hosts that have 64-bit int, so that they can access
12058 large files.
122b0c86
PE
12059 However, temporarily disable this change unless the temporary
12060 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12061
8727937b
PE
12062 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12063
8ac068ac
PE
12064 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12065 This removes an assumption that EMACS_INT and long are the same
12066 width as pointers. The assumption is true for Emacs porting targets
12067 now, but we want to make other targets possible.
12068 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12069 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12070 In the rest of the code, change types of integers that hold casted
12071 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12072 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12073 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12074 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12075 No need to cast type when ORing.
12076 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12077 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12078 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12079 assume EMACS_INT is the same width as char *.
12080 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12081 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12082 Remove no-longer-needed casts.
12083 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12084 (xg_tool_bar_help_callback, xg_make_tool_item):
12085 Use EMACS_INTPTR to hold an integer
12086 that will be cast to void *; this can avoid a GCC warning
12087 if EMACS_INT is not the same width as void *.
12088 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12089 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12090 (current_message_1, set_message_1):
12091 Use a local to convert to proper width without a cast.
12092 * xmenu.c (dialog_selection_callback): Likewise.
12093
ede49d71
PE
12094 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12095 Also, don't assume VALBITS / RAND_BITS is less than 5,
12096 and don't rely on undefined behavior when shifting a 1 left into
12097 the sign bit.
12098 * lisp.h (get_random): Change signature to match.
12099
2f30ecd0
PE
12100 * lread.c (hash_string): Use size_t, not int, for hash computation.
12101 Normally we prefer signed values; but hashing is special, because
12102 it's better to use unsigned division on hash table sizes so that
12103 the remainder is nonnegative. Also, size_t is the natural width
12104 for hashing into memory. The previous code used 'int', which doesn't
12105 retain enough info to hash well into very large tables.
12106 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12107
2a866e7b
PE
12108 * dbusbind.c: Don't possibly lose pointer info when converting.
12109 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12110 Use XPNTR rather than XHASH, so that the high-order bits of
12111 the pointer aren't lost when converting through void *.
12112
51639eac
PE
12113 * eval.c (Fautoload): Don't double-shift a pointer.
12114
92394119
PE
12115 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12116
dbdb9a7c
JB
121172011-05-06 Juanma Barranquero <lekktu@gmail.com>
12118
12119 * gnutls.c (DEF_GNUTLS_FN):
12120 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12121
db7a0b4f
AS
121222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12123
12124 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12125 marker. (Bug#8610)
12126
cd394be1 121272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12128
12129 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12130 New version that can reserve upto 2GB of heap space.
12131
f7ff1b0f 121322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12133
12134 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12135
639c109b
TZ
121362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12137
12138 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12139 `gnutls_certificate_set_x509_key_file'.
12140
d2127135
JB
121412011-05-05 Juanma Barranquero <lekktu@gmail.com>
12142
12143 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12144 Update dependencies.
12145
e968f4f3
JB
121462011-05-04 Juanma Barranquero <lekktu@gmail.com>
12147
12148 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12149 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12150 Remove unused parameter `fildes'.
12151 * process.c (read_process_output, send_process): Don't pass it.
12152
84d358f0
JB
121532011-05-04 Juanma Barranquero <lekktu@gmail.com>
12154
12155 Fix previous change: the library cache is defined in w32.c.
12156 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12157 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12158
0898ca10
JB
121592011-05-04 Juanma Barranquero <lekktu@gmail.com>
12160
12161 Implement dynamic loading of GnuTLS on Windows.
12162
12163 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12164 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12165 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12166 Declare.
12167
12168 * gnutls.c (Qgnutls_dll): Define.
12169 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12170 (gnutls_*): Declare function pointers.
12171 (init_gnutls_functions): New function to initialize function pointers.
12172 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12173 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12174 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12175 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12176 (emacs_gnutls_write, emacs_gnutls_read)
12177 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12178 (Fgnutls_available_p): New function.
12179 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12180 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12181 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12182
12183 * image.c: Include w32.h.
12184 (Vimage_type_cache): Delete.
12185 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12186 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12187 (w32_delayed_load): Move to w32.c.
12188
12189 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12190
12191 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12192 (w32_delayed_load): Move from image.c. When loading a library, record
12193 its filename in the :loaded-from property of the library id.
12194 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12195 Initialize and staticpro them.
12196 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12197
12198 * process.c: Include lisp.h before w32.h, not after.
12199 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12200 instead of gnutls_record_check_pending.
12201
12202 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12203
ff4de4aa
TZ
122042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12205
12206 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12207 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12208 as passed in.
12209
abe95abb
JD
122102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12211
12212 * xterm.c (x_set_frame_alpha): Do not set property on anything
12213 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12214
e16e55d4
JB
122152011-05-02 Juanma Barranquero <lekktu@gmail.com>
12216
12217 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12218
bafcf6a5
JB
122192011-05-02 Juanma Barranquero <lekktu@gmail.com>
12220
12221 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12222 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12223 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12224 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12225 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12226 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12227 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12228 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12229 (Qgnutls_bootprop_callbacks_verify): Make static.
12230
e7a6747f
AS
122312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12232
19ed11ba
AS
12233 * callproc.c: Indentation fixup.
12234
e7a6747f 12235 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12236 (wait_for_termination, interruptible_wait_for_termination):
12237 Move after wait_for_termination_1.
e7a6747f 12238
1ef14cb4
LMI
122392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12240
12241 * sysdep.c (interruptible_wait_for_termination): New function
12242 which is like wait_for_termination, but allows keyboard
12243 interruptions.
12244
12245 * callproc.c (Fcall_process): Add (:file "file") as an option for
12246 the STDOUT buffer.
12247 (Fcall_process_region): Ditto.
12248
330d880c
EZ
122492011-04-30 Eli Zaretskii <eliz@gnu.org>
12250
8db90b73
EZ
12251 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12252 rather than `XVECTOR (FOO)->size'.
12253
330d880c
EZ
12254 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12255 inttypes.h, as a gnulib replacement is used if it not available in
12256 system headers.
12257
15cbd324
EZ
122582011-04-21 Eli Zaretskii <eliz@gnu.org>
12259
12260 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12261 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12262 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12263
12264 * coding.c (coding_alloc_by_realloc): Error out if destination
12265 will grow beyond MOST_POSITIVE_FIXNUM.
12266 (decode_coding_emacs_mule): Abort if there isn't enough place in
12267 charbuf for the composition carryover bytes. Reserve an extra
12268 space for up to 2 characters produced in a loop.
12269 (decode_coding_iso_2022): Abort if there isn't enough place in
12270 charbuf for the composition carryover bytes.
12271
122722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12273
ae940cca
EZ
12274 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12275 aborting when %lld or %lll format is passed.
12276 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12277 %llo or %llx format is passed. (Bug#8545)
12278
03ab8921
EZ
12279 * window.c (window_scroll_line_based): Use a marker instead of
12280 simple variables to record original value of point. (Bug#7952)
12281
afda1437
EZ
12282 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12283 produced by %s or %c overflows available buffer space. (Bug#8545)
12284
f76dee0c
PE
122852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12286
12287 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12288 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12289
fdc5744d
JB
122902011-04-28 Juanma Barranquero <lekktu@gmail.com>
12291
12292 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12293
638f053a
JB
122942011-04-28 Juanma Barranquero <lekktu@gmail.com>
12295
12296 * keyboard.c (Qdelayed_warnings_hook): Define.
12297 (command_loop_1): Run `delayed-warnings-hook'
12298 if Vdelayed_warnings_list is non-nil.
12299 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12300 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12301
d178f871
EZ
123022011-04-28 Eli Zaretskii <eliz@gnu.org>
12303
12304 * doprnt.c (doprnt): Don't return value smaller than the buffer
12305 size if the message was truncated. (Bug#8545).
12306
b124fd93
JB
123072011-04-28 Juanma Barranquero <lekktu@gmail.com>
12308
12309 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12310 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12311
e810457d
PE
123122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12313
12314 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12315
ea51cceb
JB
123162011-04-27 Juanma Barranquero <lekktu@gmail.com>
12317
12318 * makefile.w32-in: Update dependencies.
12319
94dcfacf
EZ
123202011-04-27 Eli Zaretskii <eliz@gnu.org>
12321
12322 Improve `doprnt' and its usage. (Bug#8545)
12323 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12324 `format_end'. Remove support for %l as a conversion specifier.
12325 Don't use xrealloc. Improve diagnostics when the %l size modifier
12326 is used. Update the commentary.
12327
12328 * eval.c (verror): Simplify calculation of size_t.
12329
12330 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12331 messages.
12332
f61f41d7
PE
123332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12334
12335 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12336 change.
12337
96fb4434
PE
123382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12339
12340 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12341 This makes this file independent of the recent pseudovector change.
12342
671875da 123432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12344
69e9b5a3
PE
12345 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12346
b5f869a7 12347 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12348 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12349 Remove unused local.
c8926152 12350 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12351
841a1577 12352 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12353 GCC 4.6.0 optimizes based on type-based alias analysis.
12354 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12355 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12356 != &v->size, and therefore "v->size = 1; b->size = 2; return
12357 v->size;" must therefore return 1. This assumption is incorrect
12358 for Emacs, since it type-puns struct Lisp_Vector * with many other
12359 types. To fix this problem, this patch adds a new type struct
f904488f 12360 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12361 and pseudovectors, and helps optimizing compilers not get fooled
12362 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12363 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12364 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12365 the size member.
eab3844f
PE
12366 (XSETPVECTYPE): Rewrite in terms of new macro.
12367 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12368 This is a bit clearer, and further avoids the possibility of
12369 undesirable aliasing.
12370 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12371 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12372 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12373 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12374 (ASIZE): Now uses header.size rather than size.
12375 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12376 to avoid the hassle of writing XVECTOR (foo)->header.size.
12377 (struct vectorlike_header): New type.
eab3844f
PE
12378 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12379 object, to help avoid aliasing.
12380 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12381 (SUBRP): Likewise, since Lisp_Subr is a special case.
12382 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12383 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12384 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12385 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12386 changed to be "header.size" and "header.next".
12387 * buffer.h (struct buffer): Likewise.
12388 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12389 * frame.h (struct frame): Likewise.
12390 * process.h (struct Lisp_Process): Likewise.
12391 * termhooks.h (struct terminal): Likewise.
12392 * window.c (struct save_window_data, struct saved_window): Likewise.
12393 * window.h (struct window): Likewise.
12394 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12395 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12396 * buffer.c (init_buffer_once): Likewise.
12397 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12398 special case.
12399 * process.c (Fformat_network_address): Use local var for size,
12400 for brevity.
12401
0df1eac5
PE
12402 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12403
847ab9d1 12404 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12405 * data.c (atof): Remove decl; no longer used or needed.
12406 (digit_to_number): Move to lread.c.
12407 (Fstring_to_number): Use new string_to_number function, to be
12408 consistent with how the Lisp reader treats infinities and NaNs.
12409 Do not assume that floating-point numbers represent EMACS_INT
12410 without losing information; this is not true on most 64-bit hosts.
12411 Avoid double-rounding errors, by insisting on integers when
12412 parsing non-base-10 numbers, as the documentation specifies.
12413 * lisp.h (string_to_number): New decl, replacing ...
12414 (isfloat_string): Remove.
bc0a5c13 12415 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12416 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12417 appears to have been a coding error. Similarly, do not accept
12418 strings like +-1e0 as floating point numbers. Do not report
12419 overflow for integer overflows unless the base is not 10 which
12420 means we have no simple and reliable way to continue.
12421 Break out the floating-point parsing into a new
12422 function string_to_number, so that Fstring_to_number parses
12423 floating point numbers consistently with the Lisp reader.
04f2d78b 12424 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12425 (E_CHAR, EXP_INT): Remove, replacing with ...
12426 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12427 (string_to_number): New function, replacing isfloat_string.
12428 This function checks for valid syntax and produces the resulting
12429 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12430 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12431 so that overflow for non-base-10 numbers is reported only when
12432 there's no portable and simple way to convert to floating point.
452f4150 12433
67769ffc
PE
12434 * textprop.c (set_text_properties_1): Rewrite for clarity,
12435 and to avoid GCC warning about integer overflow.
12436
c20db43f
PE
12437 * intervals.h (struct interval): Use EMACS_INT for members
12438 where EMACS_UINT might cause problems. See
12439 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12440 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12441 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12442 All uses changed.
37aa2f85
PE
12443 (offset_intervals): Tell GCC not to worry about length overflow
12444 when negating a negative length.
c20db43f 12445
2538aa2f
PE
12446 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12447 (overrun_check_free): Likewise.
12448
f2d3008d
PE
12449 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12450 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12451 word size.
12452
ec8df744
PE
12453 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12454 (gnutls_make_error): Rename local to avoid shadowing.
12455 (gnutls_emacs_global_deinit): ifdef out; not used.
12456 (Fgnutls_boot): Use const for pointer to readonly storage.
12457 Comment out unused local. Fix pointer signedness problems.
12458
640ee02d
PE
12459 * lread.c (openp): Don't stuff size_t into an 'int'.
12460 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12461 about possible signed overflow.
12462
6048fb2a
PE
12463 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12464 (GDK_KEY_g): Don't define if already defined.
12465 (xg_prepare_tooltip): Avoid pointer signedness problem.
12466 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12467
fa3c87e1
PE
12468 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12469 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12470
2172544b
PE
12471 * xfns.c (Fx_window_property): Simplify a bit,
12472 to make a bit faster and to avoid GCC 4.6.0 warning.
12473 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12474
9b821a21
PE
12475 * fns.c (internal_equal): Don't assume size_t fits in int.
12476
3c616cfa
PE
12477 * alloc.c (compact_small_strings): Tighten assertion a little.
12478
c2982e87
PE
12479 Replace pEd with more-general pI, and fix some printf arg casts.
12480 * lisp.h (pI): New macro, generalizing old pEd macro to other
12481 conversion specifiers. For example, use "...%"pI"d..." rather
12482 than "...%"pEd"...".
12483 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12484 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12485 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12486 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12487 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12488 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12489 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12490 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12491 64-bit hosts.
12492 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12493 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12494 * print.c (safe_debug_print, print_object): Likewise.
12495 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12496 to int.
6f04d126
PE
12497 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12498 avoiding the 0 flag, which is not portable.
c2982e87
PE
12499 * process.c (Fmake_network_process): Use pI to avoid cast.
12500 * region-cache.c (pp_cache): Likewise.
12501 * xdisp.c (decode_mode_spec): Likewise.
12502 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12503 behavior on 64-bit hosts with printf arg.
6f04d126 12504 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12505 (x_stop_queuing_selection_requests): Likewise.
12506 (x_get_window_property): Don't truncate byte count to an 'int'
12507 when tracing.
0b432f21 12508
5e073ec7
PE
12509 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12510 here, since it parses constructs like leading '-' and spaces,
12511 which are not wanted; and it overflows with large numbers.
12512 Instead, simply match F[0-9]+, which is what is wanted anyway.
12513
36372bf9
PE
12514 * alloc.c: Remove unportable assumptions about struct layout.
12515 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12516 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12517 (allocate_vectorlike, make_pure_vector): Use the new macros,
12518 plus offsetof, to remove unportable assumptions about struct layout.
12519 These assumptions hold on all porting targets that I know of, but
12520 they are not guaranteed, they're easy to remove, and removing them
12521 makes further changes easier.
12522
0b432f21
PE
12523 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12524 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12525 (string_overrun_cookie): Now const. Use initializers that
12526 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12527 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12528 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12529 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12530 multiple of sizeof (EMACS_INT); it need not be, if
12531 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12532 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12533
895009e1
JB
125342011-04-26 Juanma Barranquero <lekktu@gmail.com>
12535
12536 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12537
6a7a1b0b
TZ
125382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12539
12540 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12541 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12542 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12543
841a1577 125442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12545
12546 * lisp.h (Qdebug): List symbol.
895009e1 12547 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12548 * keyboard.c (debug-on-event): New variable.
12549 (handle_user_signal): Break into debugger when debug-on-event
12550 matches the current signal symbol.
12551
f2d3ba6f
DN
125522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12553
12554 * alloc.c (check_sblock, check_string_bytes)
12555 (check_string_free_list): Convert to standard C.
12556
42ce4c63
TZ
125572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12558
12559 * w32.c (emacs_gnutls_push): Fix typo.
12560
825cd63c
EZ
125612011-04-25 Eli Zaretskii <eliz@gnu.org>
12562
fb11d64d
EZ
12563 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12564 "cast to pointer from integer of different size".
12565
825cd63c
EZ
12566 Improve doprnt and its use in verror. (Bug#8545)
12567 * doprnt.c (doprnt): Document the set of format control sequences
12568 supported by the function. Use SAFE_ALLOCA instead of always
12569 using `alloca'.
12570
12571 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12572 is one byte too soon. Don't use xrealloc; instead xfree and
12573 xmalloc anew.
12574
e061a11b
TZ
125752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12576
12577 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12578 callbacks stage.
12579
12580 * gnutls.c: Renamed global_initialized to
12581 gnutls_global_initialized. Added internals for the
12582 :verify-hostname-error, :verify-error, and :verify-flags
12583 parameters of `gnutls-boot' and documented those parameters in the
12584 docstring. Start callback support.
9173deec
JB
12585 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12586 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12587 on error. Return error code.
e061a11b
TZ
12588 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12589 (emacs_gnutls_read): Likewise.
12590 (Fgnutls_boot): Return handshake error code.
12591 (emacs_gnutls_handle_error): New function.
12592 (wsaerror_to_errno): Likewise.
12593
12594 * w32.h (emacs_gnutls_pull): Add prototype.
12595 (emacs_gnutls_push): Likewise.
12596
12597 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12598 (emacs_gnutls_push): Likewise.
12599
126002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12601
12602 * process.c (wait_reading_process_output): Check if GnuTLS
12603 buffered some data internally if no FDs are set for TLS
12604 connections.
12605
12606 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12607 (LIBS): Link to USER_LIBS.
12608 ($(BLD)/gnutls.$(0)): New target.
12609
fa6996bc
EZ
126102011-04-24 Eli Zaretskii <eliz@gnu.org>
12611
eb35682e
EZ
12612 * xdisp.c (handle_single_display_spec): Rename the
12613 display_replaced_before_p argument into display_replaced_p, to
12614 make it consistent with the commentary. Fix typos in the
12615 commentary.
12616
e2ad650c
EZ
12617 * textprop.c (syms_of_textprop): Remove dead code.
12618 (copy_text_properties): Delete obsolete commentary about an
12619 interface that was deleted long ago. Fix typos in the description
12620 of arguments.
12621
1b2de274
EZ
12622 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12623 to changes in oldXMenu/XMenu.h from 2011-04-16.
12624 <menu_help_message, prev_menu_help_message>: Constify.
12625 (IT_menu_make_room): menu->help_text is now `const char **';
12626 adjust.
12627
12628 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12629 to changes in oldXMenu/XMenu.h from 2011-04-16.
12630 (struct XMenu): Declare `help_text' `const char **'.
12631
12632 * xfaces.c <Qunspecified>: Make extern again.
12633
12634 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12635 required by POSIX.
1b2de274 12636
762b15be
EZ
12637 * doc.c (get_doc_string): Improve the format passed to `error'.
12638
12639 * doprnt.c (doprnt): Improve commentary.
12640
12641 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12642
12643 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12644 them with etags.
12645
f1052e5d
EZ
12646 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12647 changes in globals.h immediately force recompilation.
762b15be
EZ
12648 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12649 $(CURDIR)/s/ms-w32.h.
12650 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12651
fa6996bc
EZ
12652 * character.c (Fchar_direction): Function deleted.
12653 (syms_of_character): Don't defsubr it.
12654 <char-direction-table>: Deleted.
12655
e6c3da20
EZ
126562011-04-23 Eli Zaretskii <eliz@gnu.org>
12657
12658 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12659 * doprnt.c: Include limits.h.
12660 (SIZE_MAX): New macro.
04f2d78b
CB
12661 (doprnt): Return a size_t value. 2nd arg is now size_t.
12662 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12663 Improve overflow protection. Support `l' modifier for integer
12664 conversions. Support %l conversion. Don't assume an EMACS_INT
12665 argument for integer conversions and for %c.
12666
12667 * lisp.h (doprnt): Restore prototype.
12668
12669 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12670 $(SRC)/character.h.
12671
12672 * Makefile.in (base_obj): Add back doprnt.o.
12673
12674 * deps.mk (doprnt.o): Add back prerequisites.
12675 (callint.o): Depend on character.h.
12676
12677 * eval.c (internal_lisp_condition_case): Include the handler
12678 representation in the error message.
12679 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12680 when breaking from the loop.
12681
12682 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12683
12684 * callint.c (Fcall_interactively): When displaying error message
12685 about invalid control letter, pass the character's codepoint, not
12686 a pointer to its multibyte form. Improve display of the character
12687 in octal and display also its hex code.
12688
12689 * character.c (char_string): Use %x to display the (unsigned)
12690 codepoint of an invalid character, to avoid displaying a bogus
12691 negative value.
12692
12693 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12694 `error', not SYMBOL_NAME itself.
12695
12696 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12697 character arguments to `error'.
12698
12699 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12700 to `error' in error message about FINAL_CHAR argument. Make sure
12701 FINAL_CHAR is a character, and use %c when it is passed as
12702 argument to `error'.
12703
4ffd0d6b 127042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12705
12706 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12707
12708 * w32.c: Include <time.h>.
12709 (sys_localtime): New function.
12710
4ffd0d6b 127112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12712
12713 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12714
4ffd0d6b 12715 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12716
4ffd0d6b 127172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12718
4ffd0d6b
GM
12719 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12720 zombies (Bug#8467).
aac0c6e3 12721
04c56954
EZ
127222011-04-19 Eli Zaretskii <eliz@gnu.org>
12723
12724 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12725 gl_state.e_property when gl_state.object is Qt.
12726
12727 * insdel.c (make_gap_larger): Remove limitation of buffer size
12728 to <= INT_MAX.
12729
16a43933
CY
127302011-04-18 Chong Yidong <cyd@stupidchicken.com>
12731
12732 * xdisp.c (lookup_glyphless_char_display)
12733 (produce_glyphless_glyph): Handle cons cell entry in
12734 glyphless-char-display.
12735 (Vglyphless_char_display): Document it.
12736
12737 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12738 glyphless-char-display.
12739
4581706e
CY
127402011-04-17 Chong Yidong <cyd@stupidchicken.com>
12741
12742 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12743
12744 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12745
12746 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12747 definition for no-X builds.
12748
4887c6e2 127492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12750
fd35b6f9
PE
12751 Static checks with GCC 4.6.0 and non-default toolkits.
12752
5c1ccb01
PE
12753 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12754
006c5daa
PE
12755 * process.c (keyboard_bit_set): Define only if SIGIO.
12756 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12757 (send_process): Repair possible setjmp clobbering.
12758
efc736d3
PE
12759 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12760
4e2fe2e6
PE
12761 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12762
f97334a2
PE
12763 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12764
4e75f29d
PE
12765 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12766 Define only if needed.
12767
90efadd1
PE
12768 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12769 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12770 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12771
3c647824
PE
12772 * dispextern.h (struct redisplay_interface): Rename param
12773 to avoid shadowing.
e264f262 12774 * termhooks.h (struct terminal): Likewise.
761383f4 12775 * xterm.c (xembed_send_message): Likewise.
3c647824 12776
b58c5c4a
PE
12777 * insdel.c (make_gap_smaller): Define only if
12778 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12779
cad59032
PE
12780 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12781 it.
12782
c339dc2e
PE
12783 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12784 so that we aren't warned about unused symbols.
12785
91a3e27b
PE
12786 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12787
399c71d3 12788 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12789
8ffc96f5
PE
12790 * xfns.c (x_real_positions): Mark locals as initialized.
12791
eef9bc79
PE
12792 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12793
098db9dd
PE
12794 * xterm.c: Fix problems found by static analysis with other toolkits.
12795 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12796 (x_dispatch_event): Declare static if USE_GTK, and
12797 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12798 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12799 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12800 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12801 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12802
eb18f6cc
PE
12803 * xmenu.c (menu_help_callback): Pointer type fixes.
12804 Use const pointers when pointing at readonly data. Avoid pointer
12805 signedness clashes.
12806 (FALSE): Remove unused macro.
12807 (update_frame_menubar): Remove unused decl.
12808
1fe72bf8
PE
12809 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12810
60d9e1db
PE
12811 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12812 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12813 (single_menu_item): Rename local to avoid shadowing.
12814
39261c26
PE
12815 * keyboard.c (make_lispy_event): Remove unused local var.
12816
018c5e19
PE
12817 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12818 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12819
63d2b86e
PE
12820 * bitmaps: Change bitmaps from unsigned char back to the X11
12821 compatible char. Avoid the old compiler warnings about
12822 out-of-range initializers by using, for example, '\xab' rather
12823 than 0xab.
12824
aefd87e1
PE
12825 * xgselect.c (xgselect_initialize): Check vs interface
12826 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12827
bf501fb9
PE
12828 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12829
e9829fdf
PE
12830 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12831 to read-only memory.
12832
1086c095
PE
12833 * fns.c (vector): Remove; this old hack is no longer needed.
12834
2baccd04 12835 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12836 Remove unused var.
dde42981 12837 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12838
72391843 12839 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12840
436c16df 12841 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12842 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12843 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12844
92bb796d 12845 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12846 (x_term_init): Remove local to avoid shadowing.
92bb796d 12847
764430a3 12848 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12849
12850 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12851 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12852
d1dfb56c
EZ
128532011-04-16 Eli Zaretskii <eliz@gnu.org>
12854
c4354cb4
EZ
12855 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12856
d1dfb56c
EZ
12857 Fix regex.c, syntax.c and friends for buffers > 2GB.
12858 * syntax.h (struct gl_state_s): Declare character position members
12859 EMACS_INT.
12860
12861 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12862
04f2d78b
CB
12863 * textprop.c (verify_interval_modification, interval_of):
12864 Declare arguments EMACS_INT.
d1dfb56c
EZ
12865
12866 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12867 EMACS_INT.
12868
12869 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12870
12871 * indent.c (Fvertical_motion): Local variable it_start is now
12872 EMACS_INT.
12873
12874 * regex.c (re_match, re_match_2, re_match_2_internal)
12875 (bcmp_translate, regcomp, regexec, print_double_string)
12876 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12877 (re_compile_pattern, re_exec): Declare arguments and local
12878 variables `size_t' and `ssize_t' and return values `regoff_t', as
12879 appropriate.
12880 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12881 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12882 <compile_stack_type>: `size' and `avail' are now `size_t'.
12883
12884 * regex.h <regoff_t>: Use ssize_t, not int.
12885 (re_search, re_search_2, re_match, re_match_2): Arguments that
12886 specify buffer/string position and length are now ssize_t and
12887 size_t. Return type is regoff_t.
12888
613052cd
BK
128892011-04-16 Ben Key <bkey76@gmail.com>
12890
12891 * nsfont.m: Fixed bugs in ns_get_family and
12892 ns_descriptor_to_entity that were caused by using free to
12893 deallocate memory blocks that were allocated by xmalloc (via
12894 xstrdup). This caused Emacs to crash when compiled with
12895 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12896 --enable-checking=xmallocoverrun). xfree is now used to
12897 deallocate these memory blocks.
12898
4170f62f 128992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12900
71b41406
PE
12901 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12902
9587a89d
PE
12903 emacs_write: Accept and return EMACS_INT for sizes.
12904 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12905 et seq.
12906 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12907 Accept and return EMACS_INT.
12908 (emacs_gnutls_write): Return the number of bytes written on
12909 partial writes.
12910 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12911 (emacs_read, emacs_write): Remove check for negative size, as the
12912 Emacs source code has been audited now.
9587a89d
PE
12913 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12914 (emacs_read, emacs_write): Use it.
273a5f82
PE
12915 * process.c (send_process): Adjust to the new signatures of
12916 emacs_write and emacs_gnutls_write. Do not attempt to store
12917 a byte offset into an 'int'; it might overflow.
9587a89d 12918 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12919
3e047f51
PE
12920 * sound.c: Don't assume sizes fit in 'int'.
12921 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12922 Return EMACS_INT, not int.
3e047f51 12923 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12924 Accept EMACS_INT, not int.
12925 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12926 record read return values.
12927
cc39a9db
BK
129282011-04-15 Ben Key <bkey76@gmail.com>
12929
c9d0ec6d
JB
12930 * keyboard.c (Qundefined): Don't declare static since it is used
12931 in nsfns.m.
12932 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12933 static since they are used in nsfont.m.
cc39a9db 12934
6c60eb9f
SM
129352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12936
12937 * process.c (Qprocessp): Don't declare static.
12938 * lisp.h (Qprocessp): Declare again.
12939
7990b61a
JB
129402011-04-15 Juanma Barranquero <lekktu@gmail.com>
12941
12942 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12943
5d4cb038
PE
129442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12945
8bd7b830 12946 Improve C-level modularity by making more things 'static'.
cd64ea1d 12947
e3b27b31
PE
12948 Don't publish debugger-only interfaces to other modules.
12949 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12950 (verify_bytepos, count_markers): Move decls to the only modules
12951 that need them.
12952 * region-cache.h (pp_cache): Likewise.
12953 * window.h (check_all_windows): Likewise.
12954 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12955
5d4cb038
PE
12956 * sysdep.c (croak): Now static, if
12957 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12958 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12959
12960 * alloc.c (refill_memory_reserve): Now static if
12961 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12962 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12963
e87b6180
PE
12964 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12965 Define only if USE_LUCID.
12966
ac64929e
PE
12967 * xrdb.c (x_customization_string, x_rm_string): Now static.
12968
6f37259d
PE
12969 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12970 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12971
1683e3ab
PE
12972 * xdisp.c (draw_row_with_mouse_face): Now static.
12973 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12974
de9c2632
PE
12975 * window.h (check_all_windows): Mark externally visible.
12976
2b96acb7
PE
12977 * window.c (window_deletion_count): Now static.
12978
12979 * undo.c: Make symbols static if they're not exported.
12980 (last_undo_buffer, last_boundary_position, pending_boundary):
12981 Now static.
12982
50436f33
PE
12983 * textprop.c (interval_insert_behind_hooks): Now static.
12984 (interval_insert_in_front_hooks): Likewise.
12985
64520e5c
PE
12986 * term.c: Make symbols static if they're not exported.
12987 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12988 (max_frame_lines, tty_set_terminal_modes):
12989 (tty_reset_terminal_modes, tty_turn_off_highlight):
12990 (get_tty_terminal): Now static.
12991 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12992 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12993 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12994 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12995 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12996
1fa53021
PE
12997 * sysdep.c: Make symbols static if they're not exported.
12998 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12999 Now static.
13000 (sigprocmask_set, full_mask): Remove; unused.
13001 (wait_debugging): Mark as visible.
13002 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13003 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13004
d4b43b22
PE
13005 * syntax.c (syntax_temp): Define only if !__GNUC__.
13006
b7c513d0
PE
13007 * sound.c (current_sound_device, current_sound): Now static.
13008
989b29ad
PE
13009 * search.c (searchbufs, searchbuf_head): Now static.
13010
13a55a78
PE
13011 * scroll.c (scroll_cost): Remove; unused.
13012 * dispextern.h (scroll_cost): Remove decl.
13013
de68a1fc
PE
13014 * region-cache.h (pp_cache): Mark as externally visible.
13015
40ccffa6
PE
13016 * process.c: Make symbols static if they're not exported.
13017 (process_tick, update_tick, create_process, chan_process):
13018 (Vprocess_alist, proc_buffered_char, datagram_access):
13019 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13020 (deactivate_process): Mark defn as static, as well as decl.
13021 * lisp.h (create_process): Remove decl.
13022 * process.h (chan_process, Vprocess_alist): Remove decls.
13023
ad64fc97
PE
13024 * print.c: Make symbols static if they're not exported.
13025 (print_depth, new_backquote_output, being_printed, print_buffer):
13026 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13027 (print_interval, print_number_index, initial_stderr_stream):
13028 Now static.
13029 * lisp.h (Fprinc): Remove decl.
13030 (debug_output_compilation_hack): Mark as externally visible.
13031
adddb265
PE
13032 * sysdep.c (croak): Move decl from here to syssignal.h.
13033 * syssignal.h (croak): Put it here, so the API can be checked when
13034 'croak' is called from dissociate_if_controlling_tty.
13035
1717ede2
PE
13036 * minibuf.c: Make symbols static if they're not exported.
13037 (minibuf_save_list, choose_minibuf_frame): Now static.
13038 * lisp.h (choose_minibuf_frame): Remove decl.
13039
fa5fb2bc
PE
13040 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13041
1e3890d1
PE
13042 * lread.c: Make symbols static if they're not exported.
13043 (read_objects, initial_obarray, oblookup_last_bucket_number):
13044 Now static.
13045 (make_symbol): Remove; unused.
13046 * lisp.h (initial_obarray, make_symbol): Remove decls.
13047
8a1414fa
PE
13048 * keyboard.c: Make symbols static if they're not exported.
13049 (single_kboard, recent_keys_index, total_keys, recent_keys):
13050 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13051 (this_single_command_key_start, echoing, last_auto_save):
13052 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13053 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13054 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13055 (Vlispy_mouse_stem, double_click_count):
13056 Now static.
13057 (force_auto_save_soon): Define only if SIGDANGER.
13058 (ignore_mouse_drag_p): Now static if
13059 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13060 (print_help): Remove; unused.
13061 (stop_character, last_timer_event): Mark as externally visible.
13062 * keyboard.h (ignore_mouse_drag_p): Declare only if
13063 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13064 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13065 * lisp.h (echoing): Remove decl.
13066 (force_auto_save_soon): Declare only if SIGDANGER.
13067 * xdisp.c (redisplay_window): Simplify code, to make it more
13068 obvious that ignore_mouse_drag_p is not accessed if !defined
13069 USE_GTK && !defined HAVE_NS.
13070
93ea6e8f
PE
13071 * intervals.c: Make symbols static if they're not exported.
13072 (merge_properties_sticky, merge_interval_right, delete_interval):
13073 Now static.
13074 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13075
77382fcc
PE
13076 * insdel.c: Make symbols static if they're not exported.
13077 However, leave prepare_to_modify_buffer alone. It's never
13078 called from outside this function, but that appears to be a bug.
13079 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13080 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13081 (adjust_after_replace_noundo): Remove; unused.
13082 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13083 (signal_before_change): Remove decls.
77382fcc 13084
9306c32e
PE
13085 * indent.c (val_compute_motion, val_vmotion): Now static.
13086
cd44d2eb
PE
13087 * image.c: Make symbols static if they're not exported.
13088 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13089 if USE_GTK.
13090 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13091 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13092
ad9a7a06
PE
13093 * fringe.c (standard_bitmaps): Now static.
13094 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13095
81626931
PE
13096 * frame.c: Make symbols static if they're not exported.
13097 (x_report_frame_params, make_terminal_frame): Now static.
13098 (get_frame_param): Now static, unless HAVE_NS.
13099 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13100 (x_get_resource_string): Remove; not used.
13101 * frame.h (make_terminal_frame, x_report_frame_params):
13102 (x_get_resource_string); Remove decls.
13103 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13104 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13105
239f9db9
PE
13106 * font.c, fontset.c: Make symbols static if they're not exported.
13107 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13108 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13109 * font.c (font_close_object): Now static.
13110 * font.h (font_close_object): Remove.
13111 * fontset.c (FONTSET_OBJLIST): Remove.
13112 (free_realized_fontset) #if-0 the body, which does nothing.
13113 (face_suitable_for_char_p): #if-0, as it's never called.
13114 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13115 * xfaces.c (face_at_string_position):
13116 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13117 since 0 is always ASCII.
13118
dfcf3579
PE
13119 * fns.c (weak_hash_tables): Now static.
13120
5045092b
PE
13121 * fileio.c: Make symbols static if they're not exported.
13122 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13123 (Vwrite_region_annotation_buffers): Now static.
13124
57a96f5c
PE
13125 * eval.c: Make symbols static if they're not exported.
13126 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13127 * lisp.h (backtrace_list): Remove decl.
13128
35f08c38
PE
13129 * emacs.c: Make symbols static if they're not exported.
13130 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13131 (fatal_error_code, fatal_error_signal_hook, standard_args):
13132 Now static.
13133 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13134 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13135 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13136 * lisp.h (fatal_error_signal_hook): Remove decl.
13137 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13138
f44bd759
PE
13139 * editfns.c: Move a (normally-unused) function to its only use.
13140 * editfns.c, lisp.h (get_operating_system_release): Remove.
13141 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13142 worth the hassle of breaking this out.
13143
b532497d
PE
13144 * xterm.c: Make symbols static if they're not exported.
13145 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13146 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13147 (x_destroy_window, x_delete_display):
13148 Now static.
13149 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13150 (x_mouse_leave): Remove; unused.
13151 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13152 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13153 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13154 Remove decls.
13155 (x_mouse_leave): Declare only if WINDOWSNT.
13156 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13157 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13158 USE_X_TOOLKIT.
13159
1675728f
PE
13160 * ftxfont.c: Make symbols static if they're not exported.
13161 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13162 HAVE_FREETYPE.
13163 * font.h (ftxfont_driver): Likewise.
13164
e4cebfca
PE
13165 * xfns.c: Make symbols static if they're not exported.
13166 (x_last_font_name, x_display_info_for_name):
13167 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13168 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13169 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13170 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13171 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13172 (last_show_tip_args): Now static.
13173 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13174 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13175 (x_screen_planes): Remove; unused.
13176 * dispextern.h (x_screen_planes): Remove decl.
13177
5bf46f05
PE
13178 * dispnew.c: Make symbols static if they're not exported.
13179 * dispextern.h (redraw_garbaged_frames, scrolling):
13180 (increment_row_positions): Remove.
13181 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13182 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13183 Now static.
13184 (redraw_garbaged_frames): Remove; unused.
13185
435f4c28
PE
13186 * xfaces.c: Make symbols static if they're not exported.
13187 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13188 Remove decls.
13189 * xterm.h (defined_color): Remove decls.
13190 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13191 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13192 (menu_face_changed_default, defined_color, free_realized_face):
13193 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13194 (ascii_face_of_lisp_face): Remove; unused.
13195
8524aef3
PE
13196 * xdisp.c: Make symbols static if they're not exported.
13197 * dispextern.h (scratch_glyph_row, window_box_edges):
13198 (glyph_to_pixel_coords, set_cursor_from_row):
13199 (get_next_display_element, set_iterator_to_next):
13200 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13201 (show_mouse_face): Remove decls
13202 * frame.h (message_buf_print): Likewise.
13203 * lisp.h (pop_message, set_message, check_point_in_composition):
13204 Likewise.
13205 * xterm.h (set_vertical_scroll_bar): Likewise.
13206 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13207 (message_buf_print, scratch_glyph_row, displayed_buffer):
13208 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13209 (get_next_display_element, show_mouse_face, window_box_edges):
13210 (frame_to_window_pixel_xy, check_point_in_composition):
13211 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13212 (glyph_to_pixel_coords): Remove; unused.
13213
16390cd2
PE
13214 * dired.c (file_name_completion): Now static.
13215
13216 * dbusbind.c (xd_in_read_queued_messages): Now static.
13217
a25f4dfa
PE
13218 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13219 * data.c (circular_list_error): Remove.
13220
14a9c8df
PE
13221 * commands.h (last_point_position, last_point_position_buffer):
13222 (last_point_position_window): Remove decls.
13223 * keyboard.c: Make these variables static.
13224
04f2d78b
CB
13225 * coding.h (coding, code_convert_region, encode_coding_gap):
13226 Remove decls.
74ab6df5
PE
13227 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13228 (iso_code_class, detect_coding, code_convert_region): Now static.
13229 (encode_coding_gap): Remove; unused.
13230
38dfbee1
PE
13231 * chartab.c (chartab_chars, chartab_bits): Now static.
13232
a2cb4e63
PE
13233 * charset.h (charset_iso_8859_1): Remove decl.
13234 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13235 Now static.
13236
127198fd
PE
13237 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13238 * ccl.c (Vccl_program_table): Now static.
13239 (check_ccl_update): Remove; unused.
13240
d85b608f
PE
13241 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13242 * category.h: ... from here.
13243 * category.c (check_category_table, set_category_set): Now static.
13244
31cd66f3
PE
13245 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13246 * lisp.h: Remove these decls.
13247
c358e587
PE
13248 * buffer.c (buffer_count): Remove unused var.
13249
e78aecca
PE
13250 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13251 so that it's not optimized away.
13252 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13253 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13254 exported only to the debugger.
13255
e192d7d3 13256 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13257 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13258
92470028
PE
13259 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13260 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13261 was inaccessible from Lisp.
13262 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13263 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13264
244ed907
PE
13265 alloc.c: Import and export fewer symbols, and remove unused items.
13266 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13267 is defined.
13268 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13269 it's not optimized away by whole-program optimization.
13270 (message_enable_multibyte, free_misc): Remove.
13271 (catchlist, handlerlist, mark_backtrace):
13272 Declare only if BYTE_MARK_STACK.
13273 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13274 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13275 (message_enable_multibyte): Remove decl.
13276 (free_misc, interval_free_list, float_block, float_block_index):
13277 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13278 (cons_free_list, last_marked_index):
13279 Now static.
13280 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13281 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13282 (mark_backtrace): Define only if BYTE_MARK_STACK.
13283 * xdisp.c (message_enable_multibyte): Now static.
13284
61c2b50e 13285 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13286 This makes it easier for human readers (and static analyzers)
13287 to see whether these variables are used from other modules.
13288 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13289 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13290 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13291 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13292 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13293 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13294 * xmenu.c, xselect.c:
13295 Declare Q* vars static if they are not used in other modules.
13296 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13297 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13298 Remove decls of unexported vars.
13299 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13300
95c82688
PE
13301 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13302
16a97296
PE
13303 Make Emacs functions such as Fatom 'static' by default.
13304 This makes it easier for human readers (and static analyzers)
13305 to see whether these functions can be called from other modules.
13306 DEFUN now defines a static function. To make the function external
13307 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13308 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13309 (Finit_image_library):
16a97296
PE
13310 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13311 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13312 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13313 Remove decls, since these functions are now static.
13314 (Funintern, Fget_internal_run_time): New decls, since these functions
13315 were already external.
95c82688 13316
16a97296
PE
13317 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13318 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13319 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13320 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13321 * keyboard.c, keymap.c, lread.c:
13322 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13323 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13324 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13325 Mark functions with DEFUE instead of DEFUN,
13326 if they are used in other modules.
13327 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13328 decls for now-static functions.
13329 * buffer.h (Fdelete_overlay): Remove decl.
13330 * callproc.c (Fgetenv_internal): Mark as internal.
13331 * composite.c (Fremove_list_of_text_properties): Remove decl.
13332 (Fcomposition_get_gstring): New forward static decl.
13333 * composite.h (Fcomposite_get_gstring): Remove decl.
13334 * dired.c (Ffile_attributes): New forward static decl.
13335 * doc.c (Fdocumntation_property): New forward static decl.
13336 * eval.c (Ffetch_bytecode): New forward static decl.
13337 (Funintern): Remove extern decl; now in .h file where it belongs.
13338 * fileio.c (Fmake_symbolic_link): New forward static decl.
13339 * image.c (Finit_image_library): New forward static decl.
13340 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13341 * intervals.h (Fprevious_property_change):
13342 (Fremove_list_of_text_properties): Remove decls.
13343 * keyboard.c (Fthis_command_keys): Remove decl.
13344 (Fcommand_execute): New forward static decl.
13345 * keymap.c (Flookup_key): New forward static decl.
13346 (Fcopy_keymap): Now static.
13347 * keymap.h (Flookup_key): Remove decl.
13348 * process.c (Fget_process): New forward static decl.
13349 (Fprocess_datagram_address): Mark as internal.
13350 * syntax.c (Fsyntax_table_p): New forward static decl.
13351 (skip_chars): Remove duplicate decl.
13352 * textprop.c (Fprevious_property_change): New forward static decl.
13353 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13354 Now internal.
13355 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13356 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13357
785bbd42
PE
13358 * editfns.c (Fformat): Remove unreachable code.
13359
8b913b57
AS
133602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13361
13362 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13363 change. (Bug#8496)
13364
a6744a35
EZ
133652011-04-13 Eli Zaretskii <eliz@gnu.org>
13366
13367 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13368 when at ZV. (Bug#8487)
13369
e7974947
AS
133702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13371
baad03f0
AS
13372 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13373 (Bug#8437)
13374 * keyboard.c (parse_tool_bar_item): Likewise.
13375 * sound.c (sound_cleanup, alsa_close): Likewise.
13376 * termcap.c (tgetent): Likewise.
13377 * xfns.c (x_default_font_parameter): Likewise.
13378 * xsettings.c (read_and_apply_settings): Likewise.
13379
e7974947
AS
13380 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13381 (overrun_check_free): Protoize.
13382
28272684
PE
133832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13384
13385 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13386 since callers should never pass a negative size.
13387 Change the signature to match that of plain 'read' and 'write'; see
13388 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13389 * lisp.h: Update prototypes of emacs_write and emacs_read.
13390
11997c76
EZ
133912011-04-11 Eli Zaretskii <eliz@gnu.org>
13392
13393 * xdisp.c (redisplay_window): Don't try to determine the character
13394 position of the scroll margin if the window start point w->startp
e896f03c 13395 is outside the buffer's accessible region. (Bug#8468)
11997c76 13396
8a2cbd72
EZ
133972011-04-10 Eli Zaretskii <eliz@gnu.org>
13398
13399 Fix write-region and its subroutines for buffers > 2GB.
13400 * fileio.c (a_write, e_write): Modify declaration of arguments and
13401 local variables to support buffers larger than 2GB.
13402 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13403
13404 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13405 argument, local variables, and return value.
13406
13407 * lisp.h: Update prototypes of emacs_write and emacs_read.
13408
13409 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13410
4073e537 134112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13412
1ebfdcb6
PE
13413 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13414
b2ded58d
PE
13415 Fix more problems found by GCC 4.6.0's static checks.
13416
7d66342c
PE
13417 * xdisp.c (vmessage): Use a better test for character truncation.
13418
bbf47d44
PE
13419 * charset.c (load_charset_map): <, not <=, for optimization,
13420 and to avoid potential problems with integer overflow.
9248994d 13421 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13422 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13423 * editfns.c (Fformat): Likewise.
1e69125e 13424 * syntax.c (skip_chars): Likewise.
3befa583 13425
e3019616
PE
13426 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13427 This also lets GCC 4.6.0 generate slightly better loop code.
13428
becfa255
PE
13429 * callint.c (Fcall_interactively): <, not <=, for optimization.
13430 (Fcall_interactively): Count the number of arguments produced,
13431 not the number of arguments given. This is simpler and lets GCC
13432 4.6.0 generate slightly better code.
13433
dae0cd48
PE
13434 * ftfont.c: Distingish more carefully between FcChar8 and char.
13435 The previous code passed unsigned char * to a functions like
13436 strlen and xstrcasecmp that expect char *, which does not
13437 conform to the C standard.
13438 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13439 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13440 char * when the C standard requires it.
13441
76032d70
PE
13442 * keyboard.c (read_char): Remove unused var.
13443
eb3f1cc8
PE
13444 * eval.c: Port to Windows vsnprintf (Bug#8435).
13445 Include <limits.h>.
13446 (SIZE_MAX): Define if the headers do not.
13447 (verror): Do not give up if vsnprintf returns a negative count.
13448 Instead, grow the buffer. This ports to Windows vsnprintf, which
13449 does not conform to C99. Problem reported by Eli Zaretskii.
13450 Also, simplify the allocation scheme, by avoiding the need for
13451 calling realloc, and removing the ALLOCATED variable.
13452
70476b54
PE
13453 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13454
12020a9e
PE
13455 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13456 But keep the doprint source code for now, as we might revamp it
13457 and use it again (Bug#8435).
ea6c7ae6
PE
13458 * lisp.h (doprnt): Remove.
13459 * Makefile.in (base_obj): Remove doprnt.o.
13460 * deps.mk (doprnt.o): Remove.
13461
5fdb398c
PE
13462 error: Print 32- and 64-bit integers portably (Bug#8435).
13463 Without this change, on typical 64-bit hosts error ("...%d...", N)
13464 was used to print both 32- and 64-bit integers N, which relied on
13465 undefined behavior.
61bdb816 13466 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13467 * lisp.h (error, verror): Mark as printf-like functions.
13468 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13469 Report overflow in size calculations when allocating printf buffer.
13470 Do not truncate output string at its first null byte.
13471 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13472 Truncate the output at a character boundary, since vsnprintf does not
13473 do that.
13474 * charset.c (check_iso_charset_parameter): Convert internal
13475 character to string before calling 'error', since %c now has the
13476 printf meaning.
13477 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13478 overflow when computing char to be passed to 'error'. Do not
13479 pass Lisp_Object to 'error'; pass the integer instead.
13480 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13481 formatted with plain %d.
13482
b189fa66
PE
13483 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13484
bff87ef0
PE
13485 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13486
7e2cac20
PE
13487 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13488
ce4d90b5
PE
13489 * xterm.c (x_catch_errors): Remove duplicate declaration.
13490
266c9547
PE
13491 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13492
79c49ad2
PE
13493 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13494
368f4090
JM
134952011-04-10 Jim Meyering <meyering@redhat.com>
13496
13497 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13498 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13499 return ssize_t not "int", and use size_t as the buffer length.
13500 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13501 * gnutls.h: Update declarations.
13502 * process.c (read_process_output): Use ssize_t, to match.
13503 (send_process): Likewise.
13504
a32d4040
CY
135052011-04-09 Chong Yidong <cyd@stupidchicken.com>
13506
13507 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13508
8546720e 135092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13510
04f2d78b
CB
13511 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13512 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13513
8546720e
GM
13514 * xterm.c (handle_one_xevent):
13515 * xmenu.c (create_and_show_popup_menu):
13516 * xselect.c (x_decline_selection_request)
13517 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13518
0a2f5c1a 135192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13520
13521 Fix some uses of `int' instead of EMACS_INT.
13522 * search.c (string_match_1, fast_string_match)
13523 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13524 (scan_buffer, find_next_newline_no_quit)
13525 (find_before_next_newline, search_command, Freplace_match)
13526 (Fmatch_data): Make some `int' variables be EMACS_INT.
13527
13528 * xdisp.c (display_count_lines): 3rd argument and return value now
13529 EMACS_INT. All callers changed.
13530 (pint2hrstr): Last argument is now EMACS_INT.
13531
13532 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13533 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13534 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13535 (decode_coding_utf_16, decode_coding_emacs_mule)
13536 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13537 (decode_coding_ccl, decode_coding_charset)
13538 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13539 (decode_coding_iso_2022, decode_coding_emacs_mule)
13540 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13541 <char_offset, last_offset>: Declare EMACS_INT.
13542 (encode_coding_utf_8, encode_coding_utf_16)
13543 (encode_coding_emacs_mule, encode_invocation_designation)
13544 (encode_designation_at_bol, encode_coding_iso_2022)
13545 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13546 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13547 Declare EMACS_INT.
13548 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13549 (encode_invocation_designation): Last argument P_NCHARS is now
13550 EMACS_INT.
13551 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13552 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13553
13554 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13555 All users changed.
13556
13557 * ccl.c (Fccl_execute_on_string): Declare some variables
13558 EMACS_INT.
13559
8546720e 135602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13561
13562 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13563
4e19a977
CS
135642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13565
13566 * process.c (Fformat_network_address): Doc fix.
13567
87302331
R
135682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13569
ee7683eb 13570 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13571
cbb59342
CY
135722011-04-08 Chong Yidong <cyd@stupidchicken.com>
13573
13574 * keyboard.c (read_char): Call Lisp function help-form-show,
13575 instead of using internal_with_output_to_temp_buffer.
13576 (Qhelp_form_show): New var.
e0d38eeb 13577 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13578
13579 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13580
13581 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13582
e67a13ab
CY
135832011-04-06 Chong Yidong <cyd@stupidchicken.com>
13584
04f2d78b
CB
13585 * process.c (Flist_processes): Remove to Lisp.
13586 (list_processes_1): Delete.
e67a13ab 13587
973f782d
EZ
135882011-04-06 Eli Zaretskii <eliz@gnu.org>
13589
7c106b1e
EZ
13590 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13591
973f782d
EZ
13592 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13593
41cf7d1a 135942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13595
ca23cc88
PE
13596 Fix more problems found by GCC 4.6.0's static checks.
13597
f390e2d5
PE
13598 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13599
42eea0d0
PE
13600 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13601
b69769da 13602 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13603
f9541e84
PE
13604 * xdisp.c (vmessage): Mark as a printf-like function.
13605
13841b55
PE
13606 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13607
c136c10f
PE
13608 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13609
5e2d4a30
PE
13610 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13611 printf-like functions.
13612 (tiff_load): Add casts to remove these marks before passing them
13613 to system-supplied API.
13614
583f48b9
PE
13615 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13616
b25d760e
PE
13617 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13618 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13619 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13620 directly, rather than having caller test rule sign. This avoids
13621 some unnecessary tests.
13622 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13623 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13624 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13625
bc7b6697 13626 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13627 (xfont_open): Avoid unnecessary tests.
bc7b6697 13628
27ccc379
PE
13629 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13630
dcd5c89a
PE
13631 * composite.h, composite.c (composition_gstring_put_cache):
13632 Use EMACS_INT, not int, for length.
13633
b13a45c6
PE
13634 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13635 breaking out part of COMPOSITION_DECODE_RULE.
13636 (COMPOSITION_DECODE_RULE): Use it.
13637 * composite.c (get_composition_id): Remove unused local vars,
13638 by using the new macro.
13639
1e792e4d
PE
13640 * textprop.c (set_text_properties_1): Change while to do-while,
13641 since the condition is always true at first.
13642
dc6c6455 13643 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13644 (interval_deletion_adjustment): Return unsigned value.
13645 All uses changed.
dc6c6455 13646
aba7731a
PE
13647 * process.c (list_processes_1, create_pty, read_process_output):
13648 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13649 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13650 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13651 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13652 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13653
fdfc4bf3
PE
13654 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13655
fca8fe46 13656 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13657 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13658
06a0259a 13659 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13660 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13661 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13662
e7b9e80f
PE
13663 * print.c (print_error_message): Avoid int overflow.
13664
56201685
PE
13665 * font.c (font_list_entities): Redo for clarity,
13666 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13667
78834453 13668 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13669 (font_score): Avoid potential overflow in diff calculation.
78834453 13670
0bc0b309 13671 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13672 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13673
e610eaca
PE
13674 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13675
b895abce
PE
13676 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13677 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13678 can always succeed if overflow has undefined behavior.
13679
1f1d9321 13680 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13681 (wordify): Omit three unnecessary tests.
1f1d9321 13682
c59478bc
PE
13683 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13684 All callers changed. This avoids the need for an unused var.
13685
79b73827
PE
13686 * casefiddle.c (casify_region): Remove var that is set but not used.
13687
a4db5dfe
PE
13688 * dired.c (file_name_completion): Remove var that is set but not used.
13689
43aae36e
PE
13690 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13691
2a47c44d 13692 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13693 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13694
a37c69bf
PE
13695 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13696 Check for integer overflow on size calculations.
13697
328ab8e7
PE
13698 * buffer.c (Fprevious_overlay_change): Remove var that is set
13699 but not used.
13700
e5a2a5cb
PE
13701 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13702 Remove vars that are set but not used.
8d84a6eb 13703 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13704 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13705
a60e5f68
PE
13706 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13707
f661cb61 13708 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13709 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13710
f0397f5a
PE
13711 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13712 that are set but not used.
13713
8664db06 13714 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13715 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13716
6abdaa4a
PE
13717 * xselect.c (x_get_local_selection, x_handle_property_notify):
13718 Remove vars that are set but not used.
13719
0ce7538d 13720 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13721 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13722
9ae848fc
PE
13723 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13724 Remove var that is set but not used.
0b918413
PE
13725 (scroll_bar_windows_size): Now size_t, not int.
13726 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13727 Check for overflow.
9ae848fc 13728
a5a62657
PE
13729 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13730 (map_tty_color) [!defined MSDOS]: Likewise.
13731
5c5cdd39
PE
13732 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13733
66ebf983
PE
13734 * coding.c: Remove vars that are set but not used.
13735 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13736 All callers changed.
13737 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13738 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13739 (decode_coding_charset): Remove vars that are set but not used.
13740
1be4d761
PE
13741 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13742 that is set but not used.
13743
47553fa8
PE
13744 * print.c (print_object): Remove var that is set but not used.
13745
1f7196bf 13746 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13747 The gnulib version avoids calling malloc in the usual case,
13748 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13749 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13750 * filelock.c (current_lock_owner): Likewise.
13751 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13752 * sysdep.c: Include allocator.h, careadlinkat.h.
13753 (emacs_no_realloc_allocator): New static constant.
13754 (emacs_readlink): New function.
fdb61804
PE
13755 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13756 ../lib/careadlinkat.h.
d1fdcab7 13757
f84c17c7
SM
137582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13759
13760 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13761 first non-nil return value).
13762
ef3862ad
JD
137632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13764
13765 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13766 if not defined (Bug#8403).
13767
376a7006
JB
137682011-04-02 Juanma Barranquero <lekktu@gmail.com>
13769
13770 * xdisp.c (display_count_lines): Remove parameter `start',
13771 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13772 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13773 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13774 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13775 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13776 and thereabouts. All callers changed.
13777 (get_per_char_metric): Remove parameter `f', unused since
13778 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13779
6ca3801d
JM
137802011-04-02 Jim Meyering <meyering@redhat.com>
13781
13782 do not dereference NULL upon failed strdup
13783 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13784 (ns_get_family): Likewise.
13785
d8e2b5ba
JB
137862011-04-02 Juanma Barranquero <lekktu@gmail.com>
13787
13788 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13789
8c74fcbd
JD
137902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13791
13792 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13793 later (Bug#8403).
13794
7200d79c
SM
137952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13796
03408648 13797 Add lexical binding.
7200d79c 13798
03408648
SM
13799 * window.c (Ftemp_output_buffer_show): New fun.
13800 (Fsave_window_excursion):
13801 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13802
13803 * lread.c (lisp_file_lexically_bound_p): New function.
13804 (Fload): Bind Qlexical_binding.
13805 (readevalloop): Remove `evalfun' arg.
13806 Bind Qinternal_interpreter_environment.
13807 (Feval_buffer): Bind Qlexical_binding.
13808 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13809 Mark as dynamic.
13810 (syms_of_lread): Declare `lexical-binding'.
13811
13812 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13813
13814 * keyboard.c (eval_dyn): New fun.
13815 (menu_item_eval_property): Use it.
ca105506
SM
13816
13817 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13818
03408648
SM
13819 * fns.c (concat, mapcar1): Accept byte-code-functions.
13820
13821 * eval.c (Fsetq): Handle lexical vars.
13822 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13823 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13824 (FletX, Flet): Obey lexical binding.
13825 (Fcommandp): Handle closures.
13826 (Feval): New `lexical' arg.
13827 (eval_sub): New function extracted from Feval. Use it almost
13828 everywhere where Feval was used. Look up vars in lexical env.
13829 Handle closures.
13830 (Ffunctionp): Move from subr.el.
13831 (Ffuncall): Handle closures.
13832 (apply_lambda): Remove `eval_flags'.
13833 (funcall_lambda): Handle closures and new byte-code-functions.
13834 (Fspecial_variable_p): New function.
13835 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13836 but without exporting it to Lisp.
23aba0ea 13837
23aba0ea 13838 * doc.c (Fdocumentation, store_function_docstring):
03408648 13839 * data.c (Finteractive_form): Handle closures.
23aba0ea 13840
03408648
SM
13841 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13842 interactive spec.
ba83908c 13843
04f2d78b
CB
13844 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13845 New byte-codes.
03408648
SM
13846 (exec_byte_code): New function extracted from Fbyte_code to handle new
13847 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13848
03408648 13849 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13850
03408648 13851 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13852
e2abce01
JB
138532011-03-31 Juanma Barranquero <lekktu@gmail.com>
13854
13855 * xdisp.c (redisplay_internal): Fix prototype.
13856
63696a73 138572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13858
63696a73 13859 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13860 (try_scrolling): Use it when setting scroll_limit.
13861 Limit scrolling to 100 screen lines.
63696a73
EZ
13862 (redisplay_window): Even when falling back on "recentering",
13863 position point in the window according to scroll-conservatively,
13864 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13865
13866 (try_scrolling): When point is above the window, allow searching
13867 as far as scroll_max, or one screenful, to compute vertical
13868 distance from PT to the scroll margin position. This prevents
13869 try_scrolling from unnecessarily failing when
13870 scroll-conservatively is set to a value slightly larger than the
13871 window height. Clean up the case of PT below the margin at bottom
13872 of window: scroll_max can no longer be INT_MAX. When aggressive
13873 scrolling is in use, don't let point enter the opposite scroll
13874 margin as result of the scroll.
13875 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13876 threshold of 100 lines for never-recentering scrolling.
13877
e4cc2dfc
JB
138782011-03-31 Juanma Barranquero <lekktu@gmail.com>
13879
13880 * dispextern.h (move_it_by_lines):
13881 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13882 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13883 (message_log_check_duplicate): Remove parameters `prev_bol' and
13884 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13885 (redisplay_internal): Remove parameter `preserve_echo_area',
13886 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13887
13888 * indent.c (Fvertical_motion):
13889 * window.c (window_scroll_pixel_based, Frecenter):
13890 Don't pass `need_y_p' to `move_it_by_lines'.
13891
1c470562
SM
138922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13893
44f230aa
SM
13894 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13895 steal a few bits to be more compact.
13896 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13897 Remove unneeded casts.
13898
1c470562
SM
13899 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13900
888adce9
ZK
139012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13902
13903 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13904 binding" message (bug#7967).
13905
f838ed7b
PE
139062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13907
77861b95
PE
13908 Fix more problems found by GCC 4.6.0's static checks.
13909
de6dbc14
PE
13910 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13911 Remove unused local var.
13912
f838ed7b
PE
13913 * editfns.c (Fmessage_box): Remove unused local var.
13914
792c7b2b
PE
13915 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13916 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13917 Omit unused local vars.
c499e557 13918 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13919 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13920 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13921 Omit unused local var.
13922
ba0165e1
PE
13923 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13924 Don't assume string length fits in int.
32ad8845 13925 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13926 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13927
3c59b4c9
PE
13928 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13929 instead of alloca (Bug#8344).
13930
a3eed478 13931 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13932 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13933
eb4d412d
PE
13934 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13935
1658b401
PE
13936 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13937 concerns.
13938
13939 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13940
13941 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13942
9a2c6e05
PE
13943 * keyboard.c (syms_of_keyboard): Use the same style as later
13944 in this function when indexing through an array. This also
13945 works around GCC bug 48267.
13946
03d0a109
PE
13947 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13948
44f730c8
PE
13949 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13950
fe75f926
PE
13951 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13952 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13953
ffa8c828
PE
13954 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13955 This avoids undefined behavior on integer overflow, and is a bit
13956 more convenient anyway since it is compared to a size_t variable.
13957
c5101a77
PE
13958 Variadic C functions now count arguments with size_t, not int.
13959 This avoids an unnecessary limitation on 64-bit machines, which
13960 caused (substring ...) to crash on large vectors (Bug#8344).
13961 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13962 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13963 All variadic functions and their callers changed accordingly.
c5101a77
PE
13964 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13965 * data.c (arith_driver, float_arith_driver): Likewise.
13966 * editfns.c (general_insert_function): Likewise.
13967 * eval.c (struct backtrace.nargs, interactive_p)
13968 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13969 (funcall_lambda, mark_backtrace): Likewise.
13970 * fns.c (concat): Likewise.
13971 * frame.c (x_set_frame_parameters): Likewise.
13972 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13973 0 if not found, not -1. All callers changed.
13974
dd3f25f7
PE
13975 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13976 (stack_copy_size): Now size_t, not int.
13977 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13978
461c2ab9
JB
139792011-03-28 Juanma Barranquero <lekktu@gmail.com>
13980
13981 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13982 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13983 All callers changed.
13984
13985 * lisp.h (multibyte_char_to_unibyte):
13986 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13987 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13988 * character.h (CHAR_TO_BYTE8):
13989 * cmds.c (internal_self_insert):
13990 * editfns.c (general_insert_function):
13991 * keymap.c (push_key_description):
13992 * search.c (Freplace_match):
13993 * xdisp.c (message_dolog, set_message_1): All callers changed.
13994
f6d62986
SM
139952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13996
13997 * keyboard.c (safe_run_hook_funcall): New function.
13998 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13999 don't set the hook to nil, but remove the offending function instead.
14000 (Qcommand_hook_internal): Remove, unused.
14001 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14002 Vcommand_hook_internal.
14003
14004 * eval.c (enum run_hooks_condition): Remove.
14005 (funcall_nil, funcall_not): New functions.
14006 (run_hook_with_args): Call each function through a `funcall' argument.
14007 Remove `cond' argument, now redundant.
14008 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14009 (Frun_hook_with_args_until_failure): Adjust accordingly.
14010 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14011
1db5b1ad
JB
140122011-03-28 Juanma Barranquero <lekktu@gmail.com>
14013
14014 * dispextern.h (string_buffer_position): Remove declaration.
14015
14016 * print.c (strout): Remove parameter `multibyte', unused since
14017 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14018
14019 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14020 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14021 All callers changed.
14022
14023 * w32.c (_wsa_errlist): Use braces for struct initializers.
14024
14025 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14026 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14027 All callers changed.
14028 (string_buffer_position): Likewise. Also, make static (it's never
14029 used outside xdisp.c).
14030 (cursor_row_p): Remove parameter `w', unused since
14031 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14032 (decode_mode_spec): Remove parameter `precision', introduced during
14033 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14034 All callers changed.
14035
5ffb62aa
JD
140362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14037
14038 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14039
461c2ab9 140402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14041
14042 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14043 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14044 (ns_update_auto_hide_menu_bar): New functions.
14045 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14046 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14047 ns_constrain_all_frames.
14048 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14049 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14050
5c380ffb
JD
140512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14052
14053 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14054
9af30bdf
GM
140552011-03-27 Glenn Morris <rgm@gnu.org>
14056
14057 * syssignal.h: Replace RETSIGTYPE with void.
14058 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14059 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14060 Replace SIGTYPE with void everywhere.
14061 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14062 * s/template.h (SIGTYPE): Remove commented out definition.
14063
e2abce01
JB
140642011-03-26 Eli Zaretskii <eliz@gnu.org>
14065
14066 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14067 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14068
f868cd8a
JB
140692011-03-26 Juanma Barranquero <lekktu@gmail.com>
14070
59eb0929
JB
14071 * w32.c (read_unc_volume): Use parameter `henum', instead of
14072 global variable `wget_enum_handle'.
14073
14074 * keymap.c (describe_vector): Remove parameters `indices' and
14075 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14076 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14077
f868cd8a
JB
14078 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14079
14080 * keyboard.c (timer_check): Remove parameter `do_it_now',
14081 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14082 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14083 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14084
14085 * keyboard.c (read_char):
14086 * w32menu.c (w32_menu_display_help):
14087 * xmenu.c (show_help_event, menu_help_callback):
14088 Adjust calls to `show_help_echo'.
14089
14090 * gtkutil.c (xg_maybe_add_timer):
14091 * keyboard.c (readable_events):
14092 * process.c (wait_reading_process_output):
14093 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14094
14095 * insdel.c (adjust_markers_gap_motion):
14096 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14097 (gap_left, gap_right): Don't call it.
14098
2ecf6fdb
CY
140992011-03-25 Chong Yidong <cyd@stupidchicken.com>
14100
14101 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14102 incurred during fontification.
14103
6b1f9ba4
JB
141042011-03-25 Juanma Barranquero <lekktu@gmail.com>
14105
14106 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14107 (DEFVAR_PER_BUFFER): Don't pass it.
14108
14109 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14110 (scrolling_window): Don't pass it.
14111
0f4a96b5
JB
141122011-03-25 Juanma Barranquero <lekktu@gmail.com>
14113
14114 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14115
14116 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14117 and `suffix'.
14118 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14119 of variables specific to SELinux and computation of `encoded_absname'.
14120
14121 * image.c (XPutPixel): Remove unused variable `height'.
14122
14123 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14124
14125 * unexw32.c (get_section_info): Remove unused variable `section'.
14126
14127 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14128 (system_process_attributes): Remove unused variable `sess'.
14129 (sys_read): Remove unused variable `err'.
14130
14131 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14132 (w32_wnd_proc): Remove unused variable `isdead'.
14133 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14134 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14135 (x_create_tip_frame): Remove unused variable `tem'.
14136
14137 * w32inevt.c (w32_console_read_socket):
14138 Remove unused variable `no_events'.
14139
14140 * w32term.c (x_draw_composite_glyph_string_foreground):
14141 Remove unused variable `width'.
14142
1149507c
JB
141432011-03-24 Juanma Barranquero <lekktu@gmail.com>
14144
14145 * w32term.c (x_set_glyph_string_clipping):
14146 Don't pass uninitialized region to CombineRgn.
14147
9c88f339
JB
141482011-03-23 Juanma Barranquero <lekktu@gmail.com>
14149
14150 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14151 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14152 (Fx_close_connection): Remove unused variable `i'.
14153
14154 * w32font.c (w32font_draw): Return number of glyphs.
14155 (w32font_open_internal): Remove unused variable `i'.
14156 (w32font_driver): Add missing initializer.
14157
14158 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14159 (fill_in_menu): Remove unused variable `items_added'.
14160
14161 * w32term.c (last_mouse_press_frame): Remove static global variable.
14162 (w32_clip_to_row): Remove unused variable `f'.
14163 (x_delete_terminal): Remove unused variable `i'.
14164
14165 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14166 (NOTHING): Remove unused static global variable.
14167 (uniscribe_check_otf): Remove unused variable `table'.
14168 (uniscribe_font_driver): Add missing initializers.
14169
dee091a3
JD
141702011-03-23 Julien Danjou <julien@danjou.info>
14171
14172 * term.c (Fsuspend_tty, Fresume_tty):
14173 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14174 * window.c (temp_output_buffer_show):
14175 * insdel.c (signal_before_change):
14176 * frame.c (Fhandle_switch_frame):
14177 * fileio.c (Fdo_auto_save):
14178 * emacs.c (Fkill_emacs):
14179 * editfns.c (save_excursion_restore):
14180 * cmds.c (internal_self_insert):
14181 * callint.c (Fcall_interactively):
14182 * buffer.c (Fkill_all_local_variables):
14183 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14184 Use Frun_hooks.
0f4a96b5 14185 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14186 unconditionally since it does the check itself.
dee091a3 14187
2c520ab5 141882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14189
c9c49752
PE
14190 Fix more problems found by GCC 4.5.2's static checks.
14191
8abc3f12
PE
14192 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14193 the first time through the loop, since we know p0 < p1 then.
14194 This also avoids a gcc -Wstrict-overflow warning.
14195
a2d26660
PE
14196 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14197 leading to a memory leak, possible in functions like
14198 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14199 of objects (Bug#8318).
a2d26660 14200
916c72e9
PE
14201 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14202 that could (at least in theory) be that large.
14203
19ab8a18
PE
14204 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14205 This is less likely to overflow, and avoids undefined behavior if
14206 overflow does occur. All callers changed. Use strtoul to scan
14207 for the unsigned long integer.
b7cbbd6f
PE
14208 (pint2hrstr): Simplify and tune code slightly.
14209 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14210
f0641eff
PE
14211 * scroll.c (do_scrolling): Work around GCC bug 48228.
14212 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14213
7f650bb9
PE
14214 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14215 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14216 (validate_x_resource_name): Simplify count usage.
14217 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14218
37dd57d1
PE
14219 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14220 fail (Bug#8306).
81e56e61 14221
699979fc 14222 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14223
401bf9b4
PE
14224 * process.c (Fmake_network_process): Use socklen_t, not int,
14225 where POSIX says socklen_t is required in portable programs.
14226 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14227 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14228 (Fmake_network_process, server_accept_connection):
14229 (wait_reading_process_output, read_process_output):
14230 Likewise.
14231
b93aacde
PE
14232 * process.c: Rename or move locals to avoid shadowing.
14233 (list_processes_1, Fmake_network_process):
14234 (read_process_output_error_handler, exec_sentinel_error_handler):
14235 Rename or move locals.
4dc343ee 14236 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14237 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14238 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14239 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14240 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14241
af8a867c 14242 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14243 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14244 Include tparam.h instead, since it declares them.
af8a867c
PE
14245 * cm.h (PC): Remove extern decl; tparam.h now does this.
14246 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14247 * terminfo.c: Include tparam.h, to check interfaces.
14248 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14249 (tparam): Adjust signature to match interface in tparam.h;
14250 this removes some undefined behavior. Check that outstring and len
14251 are zero, which they always are with Emacs.
14252 * tparam.h (PC, BC, UP): New extern decls.
14253
0248044d 14254 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14255 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14256
8ff096c1 14257 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14258 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14259 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14260 (ftfont_list): Remove unused local.
49eaafba
PE
14261 (get_adstyle_property, ftfont_pattern_entity):
14262 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14263 Rename locals to avoid shadowing.
8ff096c1 14264
e2be39f6
PE
14265 * xfont.c (xfont_list_family): Mark var as initialized.
14266
c9735e30
PE
14267 * xml.c (make_dom): Now static.
14268
8f5201ae
PE
14269 * composite.c (composition_compute_stop_pos): Rename local to
14270 avoid shadowing.
b246f932
PE
14271 (composition_reseat_it): Remove unused locals.
14272 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14273 (composition_update_it): Mark var as initialized.
11b61122
PE
14274 (find_automatic_composition): Mark vars as initialized,
14275 with a FIXME (Bug#8290).
8f5201ae 14276
760fbc2c
PE
14277 character.h: Rename locals to avoid shadowing.
14278 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14279 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14280 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14281 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14282 to avoid shadowing.
14283
ff08eb85
PE
14284 * textprop.c (property_change_between_p): Remove; unused.
14285
fc7bf025
PE
14286 * intervals.c (interval_start_pos): Now static.
14287
235d7abc
PE
14288 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14289
44f230aa
SM
14290 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14291 Rename locals to avoid shadowing.
3e7d6594 14292
50060332
PE
14293 * sound.c (wav_play, au_play, Fplay_sound_internal):
14294 Fix pointer signedness.
d01f234b 14295 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14296 (wav_play): Initialize a variable to 0, to prevent undefined
14297 behavior (Bug#8278).
50060332 14298
c4fc4e30
PE
14299 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14300
918436ed
PE
14301 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14302
c939f91b
PE
14303 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14304 clobbering (Bug#8298).
b9c7f648
PE
14305 * sysdep.c (sys_subshell): Likewise.
14306 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14307
6bd8c144
PE
14308 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14309 This should get cleaned up, so that child_setup has the
14310 same signature on all platforms.
14311
7710357c 14312 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14313 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14314
c59da222
CY
143152011-03-22 Chong Yidong <cyd@stupidchicken.com>
14316
14317 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14318 not to be necessary, and produces flickering.
14319
66b87493
GM
143202011-03-20 Glenn Morris <rgm@gnu.org>
14321
14322 * config.in: Remove file.
14323
45b6f6d5
JB
143242011-03-20 Juanma Barranquero <lekktu@gmail.com>
14325
14326 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14327 are now in src/globals.h.
14328 (syms_of_minibuf): Remove spurious & from previous change.
14329
cd394be1 143302011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14331
14332 * minibuf.c (completing-read-function): New variable.
14333 (completing-read-default): Rename from completing-read.
14334 (completing-read): Call completing-read-function.
14335
b14e3e21
CY
143362011-03-19 Juanma Barranquero <lekktu@gmail.com>
14337
14338 * xfaces.c (Fx_load_color_file):
14339 Read color file from absolute filename (bug#8250).
14340
f2b726e6
JB
143412011-03-19 Juanma Barranquero <lekktu@gmail.com>
14342
14343 * makefile.w32-in: Update dependencies.
14344
09f6ff02
EZ
143452011-03-17 Eli Zaretskii <eliz@gnu.org>
14346
14347 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14348
29a6015a
PE
143492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14350
a3a6c54e
PE
14351 Fix more problems found by GCC 4.5.2's static checks.
14352
b766f867
PE
14353 * process.c (make_serial_process_unwind, send_process_trap):
14354 (sigchld_handler): Now static.
14355
be02381c
PE
14356 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14357 That way, the code declares only the vars that it needs.
14358 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14359 * s/cygwin.h (PTY_ITERATION): Likewise.
14360 * s/darwin.h (PTY_ITERATION): Likewise.
14361 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14362
57048744
PE
14363 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14364 * process.c (allocate_pty): Don't declare stb unless it's needed.
14365
7914961c 14366 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14367 (CONSTANTLIM): Remove; unused.
14368 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14369 Define only if needed.
7914961c 14370
b3967b18
PE
14371 * unexelf.c (unexec): Name an expression,
14372 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14373 Use a different way to cause a compilation error if anyone uses
14374 n rather than nn, a way that does not involve shadowing.
73366a00 14375 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14376
29a6015a
PE
14377 * deps.mk (unexalpha.o): Remove; unused.
14378
43cfc33e 14379 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14380 * unexec.h: New file.
ce701a33
PE
14381 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14382 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14383 Depend on unexec.h.
14384 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14385 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14386 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14387 Change as necessary to match prototype in unexec.h.
ce701a33 14388
01f44d5a
PE
14389 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14390 shadowing.
4f63c6bb 14391 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14392
a6670b0b
PE
14393 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14394 Rename locals to avoid shadowing.
14395
cef2010d 14396 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14397 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14398
d4d7173a
PE
14399 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14400
f08b802a
PE
14401 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14402 warning when compiling print.c.
14403
3ddb0639
PE
14404 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14405 instead of using an uninitialized var.
5ad03b97 14406 (font_sort_entities): Mark var as initialized.
3ddb0639 14407
170a2692
PE
14408 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14409
e663c700
PE
14410 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14411 pointers to constants.
89bc529a 14412 (font_parse_fcname): Remove unused vars.
7b81e2d0 14413 (font_delete_unmatched): Now static.
ea838e10 14414 (font_get_spec): Remove; unused.
13a547c6
PE
14415 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14416 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14417 Rename or move locals to avoid shadowing.
e663c700 14418
2a80c887 14419 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14420 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14421
1384fa33 14422 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14423 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14424
8b2c52e9
PE
14425 * alloc.c (mark_backtrace): Move decl from here ...
14426 * lisp.h: ... to here, so that it can be checked.
14427
475545b5 14428 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14429 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14430 (lisp_indirect_variable): Name an expression,
14431 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14432 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14433
b1349114 14434 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14435 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14436 Use const pointer when appropriate.
b1349114 14437
a2928364
PE
14438 * lisp.h (get_system_name, get_operating_system_release):
14439 Move decls here, to check interfaces.
14440 * process.c (get_operating_system_release): Move decl to lisp.h.
14441 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14442 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14443 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14444 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14445 (Fformat_time_string, Fencode_time, Finsert_char):
14446 (Ftranslate_region_internal, Fformat):
14447 Rename or remove local vars to avoid shadowing.
9710023e 14448 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14449
a415e694
PE
14450 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14451 avoid shadowing.
14452
8ef4622d
PE
14453 * lisp.h (eassert): Check that the argument compiles, even if
14454 ENABLE_CHECKING is not defined.
14455
946f9a5b
PE
14456 * data.c (Findirect_variable): Name an expression, to avoid
14457 gcc -Wbad-function-cast warning.
112396d6 14458 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14459 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14460 (Fmake_variable_buffer_local, Fmake_local_variable):
14461 Mark variables as initialized.
52746918 14462 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14463
e5aab7e7 14464 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14465 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14466 Rename locals to avoid shadowing.
dff45157
PE
14467 (mark_stack): Move local variables into the #ifdef region where
14468 they're used.
7bc26fdb
PE
14469 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14470 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14471 needed otherwise.
14472 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14473 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14474 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14475
e5aab7e7
PE
14476 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14477 avoids undefined behavior in theory.
14478
4da60324
PE
14479 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14480
88043301
PE
14481 Use functions, not macros, for up- and down-casing (Bug#8254).
14482 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14483 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14484 to use the following functions instead of these macros.
14485 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14486 EMACS_INT, since callers assume the returned value fits in int.
14487 (upcase1): Likewise, for UPCASE_TABLE.
14488 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14489 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14490 the race-condition problem in the old DOWNCASE.
88043301 14491
19ed5445
PE
14492 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14493 Rename locals to avoid shadowing.
14494 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14495 (regex_compile, re_search_2, re_match_2_internal):
14496 Remove unused local vars.
952db0d7
PE
14497 (FREE_VAR): Rewrite so as not to use empty "else",
14498 which gcc can warn about.
da053e48 14499 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14500 (RETALLOC_IF): Define only if needed.
14501 (WORDCHAR_P): Likewise. This one is never needed, but is used
14502 only in a comment talking about a compiler bug, so put inside
14503 the #if 0 of that comment.
14504 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14505 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14506 Remove; unused.
19ed5445 14507
1f3561e4 14508 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14509 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14510 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14511
ded6f8f7
PE
14512 * search.c (simple_search): Remove unused var.
14513
dbd37a95
PE
14514 * dired.c (compile_pattern): Move decl from here ...
14515 * lisp.h: ... to here, so that it can be checked.
14516 (struct re_registers): New forward decl.
14517
7e47afad
PE
14518 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14519
85f24f61
PE
14520 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14521 All uses changed.
14522 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14523 Rename locals to avoid shadowing.
5671df8f 14524 (Fvertical_motion): Mark locals as initialized.
85f24f61 14525
181aa2be 14526 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14527 (casify_region): Mark local as initialized.
181aa2be 14528
930d429c
PE
14529 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14530
7082eac6
PE
14531 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14532 New macros, so that the caller can use some names other than
14533 gcpro1, gcpro2, etc.
14534 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14535 of the new macros.
14536 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14537 argument, for consistency with GCPRO2_VAR, etc: it is now the
14538 prefix of the variable, not the variable itself. All uses
14539 changed.
38b2c076
PE
14540 * dired.c (directory_files_internal, file_name_completion):
14541 Rename locals to avoid shadowing.
14542
15206ed9
PE
14543 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14544 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14545 dired.c's scmp function, had undefined behavior.
14546 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14547 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14548 * buffer.h: ... to here, because these macros use current_buffer,
14549 and the new implementation with inline functions needs to have
14550 current_buffer in scope now, rather than later when the macros
14551 are used.
14552 (downcase, upcase1): New static inline functions.
14553 (DOWNCASE, UPCASE1): Reimplement using these functions.
14554 This avoids undefined behavior in expressions like
14555 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14556 from race conditions in accessing the global variables
14557 case_temp1 and case_temp2.
14558 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14559 * lisp.h (case_temp1, case_temp2): Remove their decls.
14560 * character.h (ASCII_CHAR_P): Move from here ...
14561 * lisp.h: ... to here, so that the inline functions mentioned
14562 above can use them.
14563
4a6bea26
PE
14564 * dired.c (directory_files_internal_unwind): Now static.
14565
f14b7e14
PE
14566 * fileio.c (file_name_as_directory, directory_file_name):
14567 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14568 Now static.
2893f146
PE
14569 (file_name_as_directory): Use const pointers when appropriate.
14570 (Fexpand_file_name): Likewise. In particular, newdir might
14571 point at constant storage, so make it a const pointer.
fd4ead52 14572 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14573 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14574 signedness issues.
f839df0c
PE
14575 (Fset_file_times, Finsert_file_contents, auto_save_error):
14576 Rename locals to avoid shadowing.
f14b7e14 14577
5716756e 14578 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14579 (Ftry_completion, Fall_completions): Rename or remove locals
14580 to avoid shadowing.
5716756e 14581
b4c3046a
PE
14582 * marker.c (bytepos_to_charpos): Remove; unused.
14583
b45db522
PE
14584 * lisp.h (verify_bytepos, count_markers): New decls,
14585 so that gcc does not warn that these functions aren't declared.
14586
85876d07
PE
14587 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14588 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14589 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14590 (copy_text): Remove unused local var.
85876d07 14591
03d78a21 14592 * filelock.c (within_one_second): Now static.
b3dd38ab 14593 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14594
5df8f01b
PE
14595 * buffer.c (fix_overlays_before): Mark locals as initialized.
14596 (fix_start_end_in_overlays): Likewise. This function should be
14597 simplified by using pointers-to-pointers, but that's a different
14598 matter.
b1d876f1 14599 (switch_to_buffer_1): Now static.
8f54f30a
PE
14600 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14601 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14602
a70072c9 14603 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14604 Fix pointer signedness issue.
edced198
PE
14605 (sys_subshell): Mark local as volatile if checking for lint,
14606 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14607 (MAXPATHLEN): Define only if needed.
a70072c9 14608
a0977c44
PE
14609 * process.c (serial_open, serial_configure): Move decls from here ...
14610 * systty.h: ... to here, so that they can be checked.
14611
a884fdcc
PE
14612 * fns.c (get_random, seed_random): Move extern decls from here ...
14613 * lisp.h: ... to here, so that they can be checked.
14614
604efe86 14615 * sysdep.c (reset_io): Now static.
b8950c94 14616 (wait_for_termination_signal): Remove; unused.
604efe86 14617
38fc62d9
PE
14618 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14619 (copy_keymap_item, append_key, push_text_char_description):
14620 Now static.
1004a21a 14621 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14622 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14623 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14624 (describe_map_tree):
14625 Rename locals to avoid shadowing.
38fc62d9 14626
2f2650da
PE
14627 * keyboard.c: Declare functions static if they are not used elsewhere.
14628 (echo_char, echo_dash, cmd_error, top_level_2):
14629 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14630 (read_char, kbd_buffer_get_event, make_lispy_position):
14631 (make_lispy_event, make_lispy_movement, apply_modifiers):
14632 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14633 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14634 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14635 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14636 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14637
a053e86c 14638 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14639 (mark_kboards): Move decl here ...
14640 * alloc.c (mark_kboards): ... from here.
a053e86c 14641
4752793e
PE
14642 * lisp.h (force_auto_save_soon): New decl.
14643
74f10ca7 14644 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14645 (DEFINE_DUMMY_FUNCTION): New macro.
14646 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14647 Use it.
c03cd23f
PE
14648 (main): Add casts to avoid warnings
14649 if GCC considers string literals to be constants.
74f10ca7 14650
022e70d4
PE
14651 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14652
59d6fe83
PE
14653 * dbusbind.c: Pointer signedness fixes.
14654 (xd_signature, xd_append_arg, xd_initialize):
14655 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14656 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14657 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14658 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14659
78320123
PE
14660 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14661 if GCC considers string literals to be constants.
49cebcca 14662 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14663
35ac2a97
SM
146642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14665
fb103ca9
SM
14666 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14667 (print_preprocess, print_object): New macro to fix last change.
14668
35ac2a97
SM
14669 * print.c (print_preprocess): Don't forget font objects.
14670
62973b41
JB
146712011-03-16 Juanma Barranquero <lekktu@gmail.com>
14672
14673 * emacs.c (USAGE3): Doc fixes.
14674
0e48bb22
AS
146752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14676
14677 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14678 structure.
14679
7684e57b
JB
146802011-03-14 Juanma Barranquero <lekktu@gmail.com>
14681
14682 * lisp.h (VWindow_system, Qfile_name_history):
14683 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14684 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14685 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14686
14687 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14688 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14689
14690 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14691 * w32console.c (detect_input_pending, read_input_pending)
14692 (encode_terminal_code):
14693 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14694 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14695 (w32_system_caret_y, Qfile_name_history):
14696 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14697 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14698 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14699 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14700 * w32proc.c (Qlocal, report_file_error):
14701 * w32term.c (Vwindow_system, updating_frame):
14702 * w32uniscribe.c (initialized, uniscribe_font_driver):
14703 Remove unneeded extern declarations.
14704
2aa46d6c
CY
147052011-03-14 Chong Yidong <cyd@stupidchicken.com>
14706
c96bbc66 14707 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14708
cffc6f3b
CY
147092011-03-13 Chong Yidong <cyd@stupidchicken.com>
14710
14711 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14712 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14713 These macros can no longer be used for assignment.
14714
44f230aa
SM
14715 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14716 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14717 (record_buffer_markers, fetch_buffer_markers): New functions for
14718 recording and fetching special buffer markers.
14719 (set_buffer_internal_1, set_buffer_temp): Use them.
14720
14721 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14722
14723 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14724
14725 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14726 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14727
14728 * xdisp.c (hscroll_window_tree):
14729 (reconsider_clip_changes): Use PT instead of BUF_PT.
14730
d251f04b
EZ
147312011-03-13 Eli Zaretskii <eliz@gnu.org>
14732
14733 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14734 $(EMACS_ROOT)/lib/intprops.h.
14735
f0c77cd1
PE
147362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14737
3eca4629
PE
14738 Fix more problems found by GCC 4.5.2's static checks.
14739
7c86ee98
PE
14740 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14741 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14742 (xg_free_frame_widgets): Make it clear that a local variable is
14743 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14744 (gdk_window_get_screen): Make it clear that this macro is needed
14745 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14746 (int_gtk_range_get_value): New function, which avoids a diagnostic
14747 from gcc -Wbad-function-cast.
14748 (xg_set_toolkit_scroll_bar_thumb): Use it.
14749 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14750 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14751 (get_utf8_string, xg_get_file_with_chooser):
14752 Rename locals to avoid shadowing.
14753 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14754
41729b81
PE
14755 * xgselect.c (xg_select): Remove unused var.
14756
f0c77cd1
PE
14757 * image.c (four_corners_best): Mark locals as initialized.
14758 (gif_load): Initialize transparent_p to zero (Bug#8238).
14759 Mark another local as initialized.
ec6cf4c6 14760 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14761
ce0ad53d 14762 * image.c (clear_image_cache): Now static.
d5d5a617 14763 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14764 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14765 (x_edge_detection): Remove unnecessary cast that
14766 gcc -Wbad-function-cast diagnoses.
2037898d 14767 (gif_load): Fix pointer signedness.
6ae141d6
PE
14768 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14769 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14770
33383987 147712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14772
d32df629
PE
14773 Improve quality of tests for time stamp overflow.
14774 For example, without this patch (encode-time 0 0 0 1 1
14775 1152921504606846976) returns the obviously-bogus value (-948597
14776 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14777 reports time overflow. See
14778 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14779 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14780 * editfns.c: Include limits.h and intprops.h.
14781 (TIME_T_MIN, TIME_T_MAX): New macros.
14782 (time_overflow): Move earlier, to before first use.
14783 (hi_time, lo_time): New functions, for an accurate test for
14784 out-of-range times.
14785 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14786 (Fget_internal_run_time): Don't assume time_t fits in int.
14787 (make_time): Use list2 instead of Fcons twice.
14788 (Fdecode_time): More accurate test for out-of-range times.
14789 (check_tm_member): New function.
14790 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14791 (lisp_time_argument): Don't rely on undefined left-shift and
14792 right-shift behavior when checking for time stamp overflow.
8be6f318 14793
fe31d94c
PE
14794 * editfns.c (time_overflow): New function, refactoring common code.
14795 (Fformat_time_string, Fdecode_time, Fencode_time):
14796 (Fcurrent_time_string): Use it.
14797
8be6f318
PE
14798 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14799 * dired.c (make_time): Move to ...
14800 * editfns.c (make_time): ... here.
14801 * systime.h: Note the move.
14802
09d9db2c 148032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14804
126bc0dc
YM
14805 * fringe.c (update_window_fringes): Remove unused variables.
14806
c47cbdfd
YM
14807 * unexmacosx.c (copy_data_segment): Also copy __got section.
14808 (Bug#8223)
14809
7ac80be9
EZ
148102011-03-12 Eli Zaretskii <eliz@gnu.org>
14811
c96bbc66 14812 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14813 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14814 Constify `char *' arguments and their references according to
14815 prototypes in tparam.h.
14816
ecb0f94d 14817 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14818
7ac80be9
EZ
14819 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14820 Adapt all references accordingly.
14821
14822 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14823
ef1fd07e
TT
148242011-03-11 Tom Tromey <tromey@redhat.com>
14825
14826 * buffer.c (syms_of_buffer): Remove obsolete comment.
14827
7ef4b50c
EZ
148282011-03-11 Eli Zaretskii <eliz@gnu.org>
14829
14830 * termhooks.h (encode_terminal_code): Declare prototype.
14831
14832 * msdos.c (encode_terminal_code): Don't declare prototype.
14833
14834 * term.c (encode_terminal_code): Now external again, used by
14835 w32console.c and msdos.c.
14836
44f230aa
SM
14837 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14838 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14839
4b1ec863 148402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14841
1714f52b 14842 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14843
4b1ec863
PE
14844 * fringe.c (update_window_fringes): Mark locals as initialized
14845 (Bug#8227).
14846 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14847
524c7aa6
PE
14848 * alloc.c (mark_fringe_data): Move decl from here ...
14849 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14850 to check its interface.
14851 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14852
a5c0af81 14853 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14854 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14855 (fontset_font): Mark local as initialized.
a9a06e0b 14856 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14857
b4716021
PE
14858 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14859
811e9bac 14860 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14861 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14862 (x_own_selection, Fx_disown_selection_internal): Rename locals
14863 to avoid shadowing.
14864 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14865
7e3ab302
PE
14866 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14867 so that the caller can use some name other than gcpro1.
14868 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14869 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14870 (Fx_backspace_delete_keys_p):
14871 Use them to avoid shadowing, and rename vars to avoid shadowing.
14872 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14873 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14874 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14875 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14876 Remove unused locals.
7e3ab302
PE
14877 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14878 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14879 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14880 macros.
f78faa98 14881
e2b13473
PE
14882 * xterm.h (x_mouse_leave): New decl.
14883
77f23912
PE
14884 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14885 Remove unused functions.
cdf4ba58
PE
14886 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14887 (x_calc_absolute_position): Now static.
7411c686 14888 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14889 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14890 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14891 unless they are used.
38d0b34a
PE
14892 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14893 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14894 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14895 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14896 (x_error_catcher, x_connection_closed, x_error_handler):
14897 (x_error_quitter, xembed_send_message, x_iconify_frame):
14898 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14899 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14900 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14901
44f230aa
SM
14902 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14903 Rename or move locals to avoid shadowing.
6b463e58 14904 (tty_defined_color, merge_face_heights): Now static.
5967d051 14905 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14906 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14907 does not deduce is never used uninitialized.
73719eba
PE
14908 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14909 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14910
426994c3 14911 * terminal.c (store_terminal_param): Now static.
5489860b 14912
032f1620 14913 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14914 (set_frame_menubar): Remove unused local.
d4323972 14915 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14916 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14917 since they might point to immutable storage.
281585b0
PE
14918 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14919 since it's unused otherwise.
032f1620 14920
367c19e5 14921 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14922 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14923 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14924 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14925 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14926 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14927 does not deduce are never used uninitialized.
70739cbe 14928
07b48fa9
PE
14929 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14930
8868a238 14931 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14932 * window.c (window_loop, size_window):
14933 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14934
7e5cf297 14935 * window.c (display_buffer): Now static.
d6550a9f
PE
14936 (size_window): Mark variables that gcc -Wuninitialized
14937 does not deduce are never used uninitialized.
a586633d
PE
14938 * window.h (check_all_windows): New decl, to forestall
14939 gcc -Wmissing-prototypes diagnostic.
5b555da1 14940 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14941
f6095868
PE
14942 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14943 shadowing.
14944 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14945 Include <limits.h>.
14946 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14947 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14948 (load_charset_map): Mark variables that gcc -Wuninitialized
14949 does not deduce are never used uninitialized.
53df7c11 14950 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14951
f38b440c
PE
14952 * coding.c (coding_set_source, coding_set_destination):
14953 Use "else { /* comment */ }" rather than "else /* comment */;"
14954 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14955 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14956 a block, when the outer 'i' will do.
14957 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14958 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14959 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14960 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14961 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14962 Rename locals to avoid shadowing.
14963 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14964 * coding.c (emacs_mule_char, encode_invocation_designation):
14965 Now static, since they're not used elsewhere.
413bb2db 14966 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14967 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14968 (decode_coding_emacs_mule): Mark variables that gcc
14969 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14970 (detect_coding_iso_2022): Initialize a local variable that might
14971 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14972 this initialization is needed. (Bug#8211)
5f58e762
PE
14973 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14974 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14975 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14976 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14977 Remove unused macros.
f38b440c 14978
232b38b9 14979 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14980 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14981 * character.c (string_count_byte8): Likewise.
232b38b9 14982
fb90da1b
PE
14983 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14984 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14985
fb93dbc2
PE
14986 * chartab.c (copy_sub_char_table): Now static, since it's not used
14987 elsewhere.
5c156ace
PE
14988 (sub_char_table_ref_and_range, char_table_ref_and_range):
14989 Rename locals to avoid shadowing.
bbcd0949 14990 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14991
7d3b3862 14992 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14993 (BIDI_BOB): Remove unused macro.
7d3b3862 14994
6be7d3da
PE
14995 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14996 deduce are never used uninitialized.
c2ed9c8b 14997 * term.c (encode_terminal_code): Likewise.
6be7d3da 14998
75f8807f 14999 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15000
50938595
PE
15001 * tparam.h: New file.
15002 * term.c, tparam.h: Include it.
15003 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15004 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15005 Move these decls to tparam.h, and make them agree with what
15006 is actually in tparam.c. The previous trick of using incompatible
15007 decls in different modules does not conform to the C standard.
15008 All callers of tparam changed to use tparam's actual API.
15009 * tparam.c (tparam1, tparam, tgoto):
15010 Use const pointers where appropriate.
15011
fbceeba2
PE
15012 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15013 * cm.h (struct cm): Likewise.
15014 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15015 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15016 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15017 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15018 (turn_on_face, init_tty): Likewise.
15019 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15020
7f3f1250
PE
15021 * term.c (term_mouse_position): Rename local to avoid shadowing.
15022
e6ca6543
PE
15023 * alloc.c (mark_ttys): Move decl from here ...
15024 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15025
c40f8d15
AS
150262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15027
15028 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15029
cfe0661d
JB
150302011-03-09 Juanma Barranquero <lekktu@gmail.com>
15031
15032 * search.c (compile_pattern_1): Remove argument regp, unused since
15033 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15034 (compile_pattern): Don't pass it.
15035
0afb4571
J
150362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15037
15038 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15039 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15040 for ! HAVE_GTK3.
15041 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15042
15043 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15044
15045 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15046 gdk_window_get_screen, gdk_window_get_geometry,
15047 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15048 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15049 (xg_get_pixbuf_from_pixmap): New function.
15050 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15051 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15052 Call xg_get_pixbuf_from_pixmap instead of
15053 gdk_pixbuf_get_from_drawable.
15054 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15055 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15056 (xg_check_special_colors): Use GtkStyleContext and its functions
15057 for HAVE_GTK3.
15058 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15059 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15060 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15061 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15062 Call gtk_widget_get_preferred_size.
0afb4571
J
15063 (xg_frame_resized): gdk_window_get_geometry only takes 5
15064 parameters.
44f230aa
SM
15065 (xg_win_to_widget, xg_event_is_for_menubar):
15066 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15067 (xg_set_widget_bg): New function.
15068 (delete_cb): New function.
895009e1 15069 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15070 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15071 (xg_set_background_color): Call xg_set_widget_bg.
15072 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15073 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15074 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15075 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15076 if ! HAVE_GTK3.
15077 (update_frame_tool_bar): Call gtk_widget_hide.
15078 (xg_initialize): Use GDK_KEY_g.
15079
15080 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15081 if ! HAVE_GTK3
15082 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15083
15084 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15085 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15086 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15087
1c2cc4ef
JB
150882011-03-08 Juanma Barranquero <lekktu@gmail.com>
15089
15090 * w32xfns.c (select_palette): Check success of RealizePalette against
15091 GDI_ERROR, not zero.
15092
33383987 15093See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15094
15095;; Local Variables:
15096;; coding: utf-8
aac0c6e3
MR
15097;; End:
15098
2f097256 15099 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15100
15101 This file is part of GNU Emacs.
15102
15103 GNU Emacs is free software: you can redistribute it and/or modify
15104 it under the terms of the GNU General Public License as published by
15105 the Free Software Foundation, either version 3 of the License, or
15106 (at your option) any later version.
15107
15108 GNU Emacs is distributed in the hope that it will be useful,
15109 but WITHOUT ANY WARRANTY; without even the implied warranty of
15110 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15111 GNU General Public License for more details.
15112
15113 You should have received a copy of the GNU General Public License
15114 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.