* editfns.c: Move a (normally-unused) function to its only use.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b532497d
PE
12011-04-13 Paul Eggert <eggert@cs.ucla.edu>
2
f44bd759
PE
3 * editfns.c: Move a (normally-unused) function to its only use.
4 * editfns.c, lisp.h (get_operating_system_release): Remove.
5 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6 worth the hassle of breaking this out.
7
b532497d
PE
8 * xterm.c: Make symbols static if they're not exported.
9 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11 (x_destroy_window, x_delete_display):
12 Now static.
13 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14 (x_mouse_leave): Remove; unused.
15 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
17 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
18 Remove decls.
19 (x_mouse_leave): Declare only if WINDOWSNT.
20 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
21 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
22 USE_X_TOOLKIT.
23
a25f4dfa
PE
242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
25
1675728f
PE
26 * ftxfont.c: Make symbols static if they're not exported.
27 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
28 HAVE_FREETYPE.
29 * font.h (ftxfont_driver): Likewise.
30
e4cebfca
PE
31 * xfns.c: Make symbols static if they're not exported.
32 (x_last_font_name, x_display_info_for_name):
33 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
34 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
35 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
36 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
37 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
38 (last_show_tip_args): Now static.
39 (xic_defaut_fontset, xic_create_fontsetname): Define only if
40 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
41 (x_screen_planes): Remove; unused.
42 * dispextern.h (x_screen_planes): Remove decl.
43
5bf46f05
PE
44 * dispnew.c: Make symbols static if they're not exported.
45 * dispextern.h (redraw_garbaged_frames, scrolling):
46 (increment_row_positions): Remove.
47 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
48 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
49 Now static.
50 (redraw_garbaged_frames): Remove; unused.
51
435f4c28
PE
52 * xfaces.c: Make symbols static if they're not exported.
53 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
54 Remove decls.
55 * xterm.h (defined_color): Remove decls.
56 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
57 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
58 (menu_face_changed_default, defined_color, free_realized_face):
59 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
60 (ascii_face_of_lisp_face): Remove; unused.
61
8524aef3
PE
62 * xdisp.c: Make symbols static if they're not exported.
63 * dispextern.h (scratch_glyph_row, window_box_edges):
64 (glyph_to_pixel_coords, set_cursor_from_row):
65 (get_next_display_element, set_iterator_to_next):
66 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
67 (show_mouse_face): Remove decls
68 * frame.h (message_buf_print): Likewise.
69 * lisp.h (pop_message, set_message, check_point_in_composition):
70 Likewise.
71 * xterm.h (set_vertical_scroll_bar): Likewise.
72 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
73 (message_buf_print, scratch_glyph_row, displayed_buffer):
74 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
75 (get_next_display_element, show_mouse_face, window_box_edges):
76 (frame_to_window_pixel_xy, check_point_in_composition):
77 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
78 (glyph_to_pixel_coords): Remove; unused.
79
16390cd2
PE
80 * dired.c (file_name_completion): Now static.
81
82 * dbusbind.c (xd_in_read_queued_messages): Now static.
83
a25f4dfa
PE
84 * lisp.h (circular_list_error, FOREACH): Remove; unused.
85 * data.c (circular_list_error): Remove.
86
16a97296
PE
872011-04-11 Paul Eggert <eggert@cs.ucla.edu>
88
14a9c8df
PE
89 * commands.h (last_point_position, last_point_position_buffer):
90 (last_point_position_window): Remove decls.
91 * keyboard.c: Make these variables static.
92
74ab6df5
PE
93 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
94 decls.
95 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
96 (iso_code_class, detect_coding, code_convert_region): Now static.
97 (encode_coding_gap): Remove; unused.
98
38dfbee1
PE
99 * chartab.c (chartab_chars, chartab_bits): Now static.
100
a2cb4e63
PE
101 * charset.h (charset_iso_8859_1): Remove decl.
102 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
103 Now static.
104
127198fd
PE
105 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
106 * ccl.c (Vccl_program_table): Now static.
107 (check_ccl_update): Remove; unused.
108
d85b608f
PE
109 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
110 * category.h: ... from here.
111 * category.c (check_category_table, set_category_set): Now static.
112
31cd66f3
PE
113 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
114 * lisp.h: Remove these decls.
115
c358e587
PE
116 * buffer.c (buffer_count): Remove unused var.
117
e78aecca
PE
118 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
119 so that it's not optimized away.
120 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
121 * dispextern.h (bidi_dump_cached_states): Remove, since it's
122 exported only to the debugger.
123
e192d7d3
PE
124 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
125 * atimer.h (run_all_atimers): Removed; not exported.
126
92470028
PE
127 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
128 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
129 was inaccessible from Lisp.
130 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
131 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
132
244ed907
PE
133 alloc.c: Import and export fewer symbols, and remove unused items.
134 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
135 is defined.
136 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
137 it's not optimized away by whole-program optimization.
138 (message_enable_multibyte, free_misc): Remove.
139 (catchlist, handlerlist, mark_backtrace):
140 Declare only if BYTE_MARK_STACK.
141 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
142 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
143 (message_enable_multibyte): Remove decl.
144 (free_misc, interval_free_list, float_block, float_block_index):
145 (n_float_blocks, float_free_list, cons_block, cons_block_index):
146 (cons_free_list, last_marked_index):
147 Now static.
148 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
149 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
150 (mark_backtrace): Define only if BYTE_MARK_STACK.
151 * xdisp.c (message_enable_multibyte): Now static.
152
955cbe7b
PE
153 Declare Lisp_Object Q* variables to be 'static' if not exproted.
154 This makes it easier for human readers (and static analyzers)
155 to see whether these variables are used from other modules.
156 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
157 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
158 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
159 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
160 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
161 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
162 * xmenu.c, xselect.c:
163 Declare Q* vars static if they are not used in other modules.
164 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
165 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
166 Remove decls of unexported vars.
167 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
168
95c82688
PE
169 * lisp.h (DEFINE_FUNC): Make sname 'static'.
170
16a97296
PE
171 Make Emacs functions such as Fatom 'static' by default.
172 This makes it easier for human readers (and static analyzers)
173 to see whether these functions can be called from other modules.
174 DEFUN now defines a static function. To make the function external
175 so that it can be used in other C modules, use the new macro DEFUE.
176 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
177 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
178 static function definition. Use DEFUE if you want an extern one.
179 (DEFUE, INFUN): New macros.
180 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
181 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
182 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
183 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
184 Remove decls, since these functions are now static.
185 (Funintern, Fget_internal_run_time): New decls, since these functions
186 were already external.
95c82688 187
16a97296
PE
188 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
189 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
190 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
191 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
192 * keyboard.c, keymap.c, lread.c:
193 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
194 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
195 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
196 Mark functions with DEFUE instead of DEFUN,
197 if they are used in other modules.
198 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
199 decls for now-static functions.
200 * buffer.h (Fdelete_overlay): Remove decl.
201 * callproc.c (Fgetenv_internal): Mark as internal.
202 * composite.c (Fremove_list_of_text_properties): Remove decl.
203 (Fcomposition_get_gstring): New forward static decl.
204 * composite.h (Fcomposite_get_gstring): Remove decl.
205 * dired.c (Ffile_attributes): New forward static decl.
206 * doc.c (Fdocumntation_property): New forward static decl.
207 * eval.c (Ffetch_bytecode): New forward static decl.
208 (Funintern): Remove extern decl; now in .h file where it belongs.
209 * fileio.c (Fmake_symbolic_link): New forward static decl.
210 * image.c (Finit_image_library): New forward static decl.
211 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
212 * intervals.h (Fprevious_property_change):
213 (Fremove_list_of_text_properties): Remove decls.
214 * keyboard.c (Fthis_command_keys): Remove decl.
215 (Fcommand_execute): New forward static decl.
216 * keymap.c (Flookup_key): New forward static decl.
217 (Fcopy_keymap): Now static.
218 * keymap.h (Flookup_key): Remove decl.
219 * process.c (Fget_process): New forward static decl.
220 (Fprocess_datagram_address): Mark as internal.
221 * syntax.c (Fsyntax_table_p): New forward static decl.
222 (skip_chars): Remove duplicate decl.
223 * textprop.c (Fprevious_property_change): New forward static decl.
224 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
225 Now internal.
226 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
227 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
228
785bbd42
PE
2292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
230
231 * editfns.c (Fformat): Remove unreachable code.
232
4073e537 2332011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 234
b2ded58d
PE
235 Fix more problems found by GCC 4.6.0's static checks.
236
7d66342c
PE
237 * xdisp.c (vmessage): Use a better test for character truncation.
238
bbf47d44
PE
239 * charset.c (load_charset_map): <, not <=, for optimization,
240 and to avoid potential problems with integer overflow.
9248994d 241 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 242 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 243 * editfns.c (Fformat): Likewise.
1e69125e 244 * syntax.c (skip_chars): Likewise.
3befa583 245
e3019616
PE
246 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
247 This also lets GCC 4.6.0 generate slightly better loop code.
248
becfa255
PE
249 * callint.c (Fcall_interactively): <, not <=, for optimization.
250 (Fcall_interactively): Count the number of arguments produced,
251 not the number of arguments given. This is simpler and lets GCC
252 4.6.0 generate slightly better code.
253
dae0cd48
PE
254 * ftfont.c: Distingish more carefully between FcChar8 and char.
255 The previous code passed unsigned char * to a functions like
256 strlen and xstrcasecmp that expect char *, which does not
257 conform to the C standard.
258 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
259 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
260 char * when the C standard requires it.
261
76032d70
PE
262 * keyboard.c (read_char): Remove unused var.
263
eb3f1cc8
PE
264 * eval.c: Port to Windows vsnprintf (Bug#8435).
265 Include <limits.h>.
266 (SIZE_MAX): Define if the headers do not.
267 (verror): Do not give up if vsnprintf returns a negative count.
268 Instead, grow the buffer. This ports to Windows vsnprintf, which
269 does not conform to C99. Problem reported by Eli Zaretskii.
270 Also, simplify the allocation scheme, by avoiding the need for
271 calling realloc, and removing the ALLOCATED variable.
272
70476b54
PE
273 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
274
12020a9e
PE
275 Remove invocations of doprnt, as Emacs now uses vsnprintf.
276 But keep the doprint source code for now, as we might revamp it
277 and use it again (Bug#8435).
ea6c7ae6
PE
278 * lisp.h (doprnt): Remove.
279 * Makefile.in (base_obj): Remove doprnt.o.
280 * deps.mk (doprnt.o): Remove.
281
5fdb398c
PE
282 error: Print 32- and 64-bit integers portably (Bug#8435).
283 Without this change, on typical 64-bit hosts error ("...%d...", N)
284 was used to print both 32- and 64-bit integers N, which relied on
285 undefined behavior.
286 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
287 New macro.
288 * lisp.h (error, verror): Mark as printf-like functions.
289 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
290 Report overflow in size calculations when allocating printf buffer.
291 Do not truncate output string at its first null byte.
292 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
293 Truncate the output at a character boundary, since vsnprintf does not
294 do that.
295 * charset.c (check_iso_charset_parameter): Convert internal
296 character to string before calling 'error', since %c now has the
297 printf meaning.
298 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
299 overflow when computing char to be passed to 'error'. Do not
300 pass Lisp_Object to 'error'; pass the integer instead.
301 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
302 formatted with plain %d.
303
b189fa66
PE
304 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
305
bff87ef0
PE
306 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
307
7e2cac20
PE
308 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
309
ce4d90b5
PE
310 * xterm.c (x_catch_errors): Remove duplicate declaration.
311
266c9547
PE
312 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
313
79c49ad2
PE
314 * xdisp.c, lisp.h (message_nolog): Remove; unused.
315
368f4090
JM
3162011-04-10 Jim Meyering <meyering@redhat.com>
317
318 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
319 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
320 return ssize_t not "int", and use size_t as the buffer length.
321 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
322 * gnutls.h: Update declarations.
323 * process.c (read_process_output): Use ssize_t, to match.
324 (send_process): Likewise.
325
a32d4040
CY
3262011-04-09 Chong Yidong <cyd@stupidchicken.com>
327
328 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
329
8546720e 3302011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 331
8546720e
GM
332 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
333 unsigned char, to match FcChar8 type definition.
aac0c6e3 334
8546720e
GM
335 * xterm.c (handle_one_xevent):
336 * xmenu.c (create_and_show_popup_menu):
337 * xselect.c (x_decline_selection_request)
338 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 339
a53e2e89
EZ
3402011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
341
342 Fix some uses of `int' instead of EMACS_INT.
343 * search.c (string_match_1, fast_string_match)
344 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
345 (scan_buffer, find_next_newline_no_quit)
346 (find_before_next_newline, search_command, Freplace_match)
347 (Fmatch_data): Make some `int' variables be EMACS_INT.
348
349 * xdisp.c (display_count_lines): 3rd argument and return value now
350 EMACS_INT. All callers changed.
351 (pint2hrstr): Last argument is now EMACS_INT.
352
353 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
354 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
355 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
356 (decode_coding_utf_16, decode_coding_emacs_mule)
357 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
358 (decode_coding_ccl, decode_coding_charset)
359 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
360 (decode_coding_iso_2022, decode_coding_emacs_mule)
361 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
362 <char_offset, last_offset>: Declare EMACS_INT.
363 (encode_coding_utf_8, encode_coding_utf_16)
364 (encode_coding_emacs_mule, encode_invocation_designation)
365 (encode_designation_at_bol, encode_coding_iso_2022)
366 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
367 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
368 Declare EMACS_INT.
369 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
370 (encode_invocation_designation): Last argument P_NCHARS is now
371 EMACS_INT.
372 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
373 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
374
375 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
376 All users changed.
377
378 * ccl.c (Fccl_execute_on_string): Declare some variables
379 EMACS_INT.
380
8546720e 3812011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
382
383 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
384
4e19a977
CS
3852011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
386
387 * process.c (Fformat_network_address): Doc fix.
388
87302331
R
3892011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
390
391 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
392
cbb59342
CY
3932011-04-08 Chong Yidong <cyd@stupidchicken.com>
394
395 * keyboard.c (read_char): Call Lisp function help-form-show,
396 instead of using internal_with_output_to_temp_buffer.
397 (Qhelp_form_show): New var.
e0d38eeb 398 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
399
400 * print.c (internal_with_output_to_temp_buffer): Function deleted.
401
402 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
403
e67a13ab
CY
4042011-04-06 Chong Yidong <cyd@stupidchicken.com>
405
406 * process.c (Flist_processes): Removed to Lisp.
407 (list_processes_1): Deleted.
408
973f782d
EZ
4092011-04-06 Eli Zaretskii <eliz@gnu.org>
410
7c106b1e
EZ
411 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
412
973f782d
EZ
413 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
414
41cf7d1a 4152011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 416
ca23cc88
PE
417 Fix more problems found by GCC 4.6.0's static checks.
418
f390e2d5
PE
419 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
420
42eea0d0
PE
421 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
422
b69769da 423 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 424
f9541e84
PE
425 * xdisp.c (vmessage): Mark as a printf-like function.
426
13841b55
PE
427 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
428
c136c10f
PE
429 * sound.c (sound_warning): Don't crash if arg contains a printf format.
430
5e2d4a30
PE
431 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
432 printf-like functions.
433 (tiff_load): Add casts to remove these marks before passing them
434 to system-supplied API.
435
583f48b9
PE
436 * eval.c (Fsignal): Remove excess argument to 'fatal'.
437
b25d760e
PE
438 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
439 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
440 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
441 directly, rather than having caller test rule sign. This avoids
442 some unnecessary tests.
443 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
444 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
445 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 446
bc7b6697 447 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 448 (xfont_open): Avoid unnecessary tests.
bc7b6697 449
27ccc379
PE
450 * composite.c (composition_gstring_put_cache): Use unsigned integer.
451
dcd5c89a
PE
452 * composite.h, composite.c (composition_gstring_put_cache):
453 Use EMACS_INT, not int, for length.
454
b13a45c6
PE
455 * composite.h (COMPOSITION_DECODE_REFS): New macro,
456 breaking out part of COMPOSITION_DECODE_RULE.
457 (COMPOSITION_DECODE_RULE): Use it.
458 * composite.c (get_composition_id): Remove unused local vars,
459 by using the new macro.
460
1e792e4d
PE
461 * textprop.c (set_text_properties_1): Change while to do-while,
462 since the condition is always true at first.
463
dc6c6455 464 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
465 (interval_deletion_adjustment): Return unsigned value.
466 All uses changed.
dc6c6455 467
aba7731a
PE
468 * process.c (list_processes_1, create_pty, read_process_output):
469 (exec_sentinel): Remove vars that were set but not used.
afd4052b 470 (create_pty): Remove unnecessary "volatile"s.
bc57d757 471 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 472 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 473 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 474
fdfc4bf3
PE
475 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
476
fca8fe46 477 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 478 (update_syntax_table): Use unsigned instead of int.
fca8fe46 479
06a0259a 480 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 481 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 482 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 483
e7b9e80f
PE
484 * print.c (print_error_message): Avoid int overflow.
485
56201685
PE
486 * font.c (font_list_entities): Redo for clarity,
487 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
488
78834453 489 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 490 (font_score): Avoid potential overflow in diff calculation.
78834453 491
0bc0b309 492 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 493 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 494
e610eaca
PE
495 * eval.c (funcall_lambda): Rename local to avoid shadowing.
496
b895abce
PE
497 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
498 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
499 can always succeed if overflow has undefined behavior.
500
1f1d9321 501 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 502 (wordify): Omit three unnecessary tests.
1f1d9321 503
c59478bc
PE
504 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
505 All callers changed. This avoids the need for an unused var.
506
79b73827
PE
507 * casefiddle.c (casify_region): Remove var that is set but not used.
508
a4db5dfe
PE
509 * dired.c (file_name_completion): Remove var that is set but not used.
510
43aae36e
PE
511 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
512
2a47c44d 513 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 514 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 515
a37c69bf
PE
516 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
517 Check for integer overflow on size calculations.
518
328ab8e7
PE
519 * buffer.c (Fprevious_overlay_change): Remove var that is set
520 but not used.
521
e5a2a5cb
PE
522 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
523 Remove vars that are set but not used.
8d84a6eb 524 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 525 (timer_check_2): Mark vars as initialized.
e5a2a5cb 526
a60e5f68
PE
527 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
528
f661cb61 529 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 530 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 531
f0397f5a
PE
532 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
533 that are set but not used.
534
8664db06 535 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 536 if XCreateBitmapFromData fails (Bug#8410).
8664db06 537
6abdaa4a
PE
538 * xselect.c (x_get_local_selection, x_handle_property_notify):
539 Remove vars that are set but not used.
540
0ce7538d 541 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 542 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 543
9ae848fc
PE
544 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
545 Remove var that is set but not used.
0b918413
PE
546 (scroll_bar_windows_size): Now size_t, not int.
547 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
548 Check for overflow.
9ae848fc 549
a5a62657
PE
550 * xfaces.c (realize_named_face): Remove vars that are set but not used.
551 (map_tty_color) [!defined MSDOS]: Likewise.
552
5c5cdd39
PE
553 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
554
66ebf983
PE
555 * coding.c: Remove vars that are set but not used.
556 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
557 All callers changed.
558 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
559 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
560 (decode_coding_charset): Remove vars that are set but not used.
561
1be4d761
PE
562 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
563 that is set but not used.
564
47553fa8
PE
565 * print.c (print_object): Remove var that is set but not used.
566
1f7196bf 567 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
568 The gnulib version avoids calling malloc in the usual case,
569 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
570 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
571 * filelock.c (current_lock_owner): Likewise.
572 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
573 * sysdep.c: Include allocator.h, careadlinkat.h.
574 (emacs_no_realloc_allocator): New static constant.
575 (emacs_readlink): New function.
fdb61804
PE
576 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
577 ../lib/careadlinkat.h.
d1fdcab7 578
f84c17c7
SM
5792011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
580
581 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
582 first non-nil return value).
583
ef3862ad
JD
5842011-04-03 Jan Djärv <jan.h.d@swipnet.se>
585
586 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
587 if not defined (Bug#8403).
588
376a7006
JB
5892011-04-02 Juanma Barranquero <lekktu@gmail.com>
590
591 * xdisp.c (display_count_lines): Remove parameter `start',
592 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
593 (get_char_face_and_encoding): Remove parameter `multibyte_p',
594 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
595 (fill_stretch_glyph_string): Remove parameters `row' and `area',
596 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
597 and thereabouts. All callers changed.
598 (get_per_char_metric): Remove parameter `f', unused since
599 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
600
6ca3801d
JM
6012011-04-02 Jim Meyering <meyering@redhat.com>
602
603 do not dereference NULL upon failed strdup
604 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
605 (ns_get_family): Likewise.
606
d8e2b5ba
JB
6072011-04-02 Juanma Barranquero <lekktu@gmail.com>
608
609 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
610
8c74fcbd
JD
6112011-04-02 Jan Djärv <jan.h.d@swipnet.se>
612
613 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
614 later (Bug#8403).
615
7200d79c
SM
6162011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
617
03408648 618 Add lexical binding.
7200d79c 619
03408648
SM
620 * window.c (Ftemp_output_buffer_show): New fun.
621 (Fsave_window_excursion):
622 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
623
624 * lread.c (lisp_file_lexically_bound_p): New function.
625 (Fload): Bind Qlexical_binding.
626 (readevalloop): Remove `evalfun' arg.
627 Bind Qinternal_interpreter_environment.
628 (Feval_buffer): Bind Qlexical_binding.
629 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
630 Mark as dynamic.
631 (syms_of_lread): Declare `lexical-binding'.
632
633 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
634
635 * keyboard.c (eval_dyn): New fun.
636 (menu_item_eval_property): Use it.
ca105506
SM
637
638 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 639
03408648
SM
640 * fns.c (concat, mapcar1): Accept byte-code-functions.
641
642 * eval.c (Fsetq): Handle lexical vars.
643 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
644 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
645 (FletX, Flet): Obey lexical binding.
646 (Fcommandp): Handle closures.
647 (Feval): New `lexical' arg.
648 (eval_sub): New function extracted from Feval. Use it almost
649 everywhere where Feval was used. Look up vars in lexical env.
650 Handle closures.
651 (Ffunctionp): Move from subr.el.
652 (Ffuncall): Handle closures.
653 (apply_lambda): Remove `eval_flags'.
654 (funcall_lambda): Handle closures and new byte-code-functions.
655 (Fspecial_variable_p): New function.
656 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
657 but without exporting it to Lisp.
23aba0ea 658
23aba0ea 659 * doc.c (Fdocumentation, store_function_docstring):
03408648 660 * data.c (Finteractive_form): Handle closures.
23aba0ea 661
03408648
SM
662 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
663 interactive spec.
ba83908c 664
03408648
SM
665 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
666 byte-codes.
667 (exec_byte_code): New function extracted from Fbyte_code to handle new
668 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 669
03408648 670 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 671
03408648 672 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 673
e2abce01
JB
6742011-03-31 Juanma Barranquero <lekktu@gmail.com>
675
676 * xdisp.c (redisplay_internal): Fix prototype.
677
63696a73 6782011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 679
63696a73
EZ
680 * xdisp.c (SCROLL_LIMIT): New macro.
681 (try_scrolling): Use it when setting scroll_limit. Limit
682 scrolling to 100 screen lines.
683 (redisplay_window): Even when falling back on "recentering",
684 position point in the window according to scroll-conservatively,
685 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
686
687 (try_scrolling): When point is above the window, allow searching
688 as far as scroll_max, or one screenful, to compute vertical
689 distance from PT to the scroll margin position. This prevents
690 try_scrolling from unnecessarily failing when
691 scroll-conservatively is set to a value slightly larger than the
692 window height. Clean up the case of PT below the margin at bottom
693 of window: scroll_max can no longer be INT_MAX. When aggressive
694 scrolling is in use, don't let point enter the opposite scroll
695 margin as result of the scroll.
696 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
697 threshold of 100 lines for never-recentering scrolling.
698
e4cc2dfc
JB
6992011-03-31 Juanma Barranquero <lekktu@gmail.com>
700
701 * dispextern.h (move_it_by_lines):
702 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
703 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
704 (message_log_check_duplicate): Remove parameters `prev_bol' and
705 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
706 (redisplay_internal): Remove parameter `preserve_echo_area',
707 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
708
709 * indent.c (Fvertical_motion):
710 * window.c (window_scroll_pixel_based, Frecenter):
711 Don't pass `need_y_p' to `move_it_by_lines'.
712
1c470562
SM
7132011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
714
44f230aa
SM
715 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
716 steal a few bits to be more compact.
717 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
718 Remove unneeded casts.
719
1c470562
SM
720 * bytecode.c (Fbyte_code): CAR and CDR can GC.
721
888adce9
ZK
7222011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
723
724 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
725 binding" message (bug#7967).
726
f838ed7b
PE
7272011-03-30 Paul Eggert <eggert@cs.ucla.edu>
728
77861b95
PE
729 Fix more problems found by GCC 4.6.0's static checks.
730
de6dbc14
PE
731 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
732 Remove unused local var.
733
f838ed7b
PE
734 * editfns.c (Fmessage_box): Remove unused local var.
735
792c7b2b
PE
736 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
737 (note_mode_line_or_margin_highlight, note_mouse_highlight):
738 Omit unused local vars.
c499e557 739 * window.c (shrink_windows): Omit unused local var.
b01a1c29 740 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
741 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
742 Omit unused local var.
743
ba0165e1
PE
744 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
745 Don't assume string length fits in int.
32ad8845 746 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 747 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 748
3c59b4c9
PE
749 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
750 instead of alloca (Bug#8344).
751
a3eed478 752 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 753 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 754
eb4d412d
PE
755 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
756
1658b401
PE
757 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
758 concerns.
759
760 * term.c (produce_glyphless_glyph): Remove unnecessary test.
761
762 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 763
9a2c6e05
PE
764 * keyboard.c (syms_of_keyboard): Use the same style as later
765 in this function when indexing through an array. This also
766 works around GCC bug 48267.
767
03d0a109
PE
768 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
769
44f730c8
PE
770 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
771
fe75f926
PE
772 * chartab.c (sub_char_table_ref_and_range): Redo for slight
773 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
774
ffa8c828
PE
775 * keyboard.c, keyboard.h (num_input_events): Now size_t.
776 This avoids undefined behavior on integer overflow, and is a bit
777 more convenient anyway since it is compared to a size_t variable.
778
c5101a77
PE
779 Variadic C functions now count arguments with size_t, not int.
780 This avoids an unnecessary limitation on 64-bit machines, which
781 caused (substring ...) to crash on large vectors (Bug#8344).
782 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
783 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 784 All variadic functions and their callers changed accordingly.
c5101a77
PE
785 (struct gcpro.nvars): Now size_t, not int. All uses changed.
786 * data.c (arith_driver, float_arith_driver): Likewise.
787 * editfns.c (general_insert_function): Likewise.
788 * eval.c (struct backtrace.nargs, interactive_p)
789 (internal_condition_case_n, run_hook_with_args, apply_lambda)
790 (funcall_lambda, mark_backtrace): Likewise.
791 * fns.c (concat): Likewise.
792 * frame.c (x_set_frame_parameters): Likewise.
793 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
794 0 if not found, not -1. All callers changed.
795
dd3f25f7
PE
796 * alloc.c (garbage_collect): Don't assume stack size fits in int.
797 (stack_copy_size): Now size_t, not int.
798 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
799
461c2ab9
JB
8002011-03-28 Juanma Barranquero <lekktu@gmail.com>
801
802 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
803 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
804 All callers changed.
805
806 * lisp.h (multibyte_char_to_unibyte):
807 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
808 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
809 * character.h (CHAR_TO_BYTE8):
810 * cmds.c (internal_self_insert):
811 * editfns.c (general_insert_function):
812 * keymap.c (push_key_description):
813 * search.c (Freplace_match):
814 * xdisp.c (message_dolog, set_message_1): All callers changed.
815
f6d62986
SM
8162011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
817
818 * keyboard.c (safe_run_hook_funcall): New function.
819 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
820 don't set the hook to nil, but remove the offending function instead.
821 (Qcommand_hook_internal): Remove, unused.
822 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
823 Vcommand_hook_internal.
824
825 * eval.c (enum run_hooks_condition): Remove.
826 (funcall_nil, funcall_not): New functions.
827 (run_hook_with_args): Call each function through a `funcall' argument.
828 Remove `cond' argument, now redundant.
829 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
830 (Frun_hook_with_args_until_failure): Adjust accordingly.
831 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
832
1db5b1ad
JB
8332011-03-28 Juanma Barranquero <lekktu@gmail.com>
834
835 * dispextern.h (string_buffer_position): Remove declaration.
836
837 * print.c (strout): Remove parameter `multibyte', unused since
838 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
839
840 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
841 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
842 All callers changed.
843
844 * w32.c (_wsa_errlist): Use braces for struct initializers.
845
846 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
847 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
848 All callers changed.
849 (string_buffer_position): Likewise. Also, make static (it's never
850 used outside xdisp.c).
851 (cursor_row_p): Remove parameter `w', unused since
852 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
853 (decode_mode_spec): Remove parameter `precision', introduced during
854 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
855 All callers changed.
856
5ffb62aa
JD
8572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
858
859 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
860
461c2ab9 8612011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
862
863 * nsterm.m (ns_menu_bar_is_hidden): New variable.
864 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
865 (ns_update_auto_hide_menu_bar): New functions.
866 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
867 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
868 ns_constrain_all_frames.
869 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
870 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
871
5c380ffb
JD
8722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
873
874 * nsmenu.m (runDialogAt): Remove argument to timer_check.
875
9af30bdf
GM
8762011-03-27 Glenn Morris <rgm@gnu.org>
877
878 * syssignal.h: Replace RETSIGTYPE with void.
879 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
880 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
881 Replace SIGTYPE with void everywhere.
882 * s/usg5-4-common.h (SIGTYPE): Remove definition.
883 * s/template.h (SIGTYPE): Remove commented out definition.
884
e2abce01
JB
8852011-03-26 Eli Zaretskii <eliz@gnu.org>
886
887 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
888 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
889
f868cd8a
JB
8902011-03-26 Juanma Barranquero <lekktu@gmail.com>
891
59eb0929
JB
892 * w32.c (read_unc_volume): Use parameter `henum', instead of
893 global variable `wget_enum_handle'.
894
895 * keymap.c (describe_vector): Remove parameters `indices' and
896 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
897 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
898
f868cd8a
JB
899 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
900
901 * keyboard.c (timer_check): Remove parameter `do_it_now',
902 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
903 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
904 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
905
906 * keyboard.c (read_char):
907 * w32menu.c (w32_menu_display_help):
908 * xmenu.c (show_help_event, menu_help_callback):
909 Adjust calls to `show_help_echo'.
910
911 * gtkutil.c (xg_maybe_add_timer):
912 * keyboard.c (readable_events):
913 * process.c (wait_reading_process_output):
914 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
915
916 * insdel.c (adjust_markers_gap_motion):
917 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
918 (gap_left, gap_right): Don't call it.
919
2ecf6fdb
CY
9202011-03-25 Chong Yidong <cyd@stupidchicken.com>
921
922 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
923 incurred during fontification.
924
6b1f9ba4
JB
9252011-03-25 Juanma Barranquero <lekktu@gmail.com>
926
927 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
928 (DEFVAR_PER_BUFFER): Don't pass it.
929
930 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
931 (scrolling_window): Don't pass it.
932
0f4a96b5
JB
9332011-03-25 Juanma Barranquero <lekktu@gmail.com>
934
935 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
936
937 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
938 and `suffix'.
939 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
940 of variables specific to SELinux and computation of `encoded_absname'.
941
942 * image.c (XPutPixel): Remove unused variable `height'.
943
944 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
945
946 * unexw32.c (get_section_info): Remove unused variable `section'.
947
948 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
949 (system_process_attributes): Remove unused variable `sess'.
950 (sys_read): Remove unused variable `err'.
951
952 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
953 (w32_wnd_proc): Remove unused variable `isdead'.
954 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
955 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
956 (x_create_tip_frame): Remove unused variable `tem'.
957
958 * w32inevt.c (w32_console_read_socket):
959 Remove unused variable `no_events'.
960
961 * w32term.c (x_draw_composite_glyph_string_foreground):
962 Remove unused variable `width'.
963
1149507c
JB
9642011-03-24 Juanma Barranquero <lekktu@gmail.com>
965
966 * w32term.c (x_set_glyph_string_clipping):
967 Don't pass uninitialized region to CombineRgn.
968
9c88f339
JB
9692011-03-23 Juanma Barranquero <lekktu@gmail.com>
970
971 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
972 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
973 (Fx_close_connection): Remove unused variable `i'.
974
975 * w32font.c (w32font_draw): Return number of glyphs.
976 (w32font_open_internal): Remove unused variable `i'.
977 (w32font_driver): Add missing initializer.
978
979 * w32menu.c (utf8to16): Remove unused variable `utf16'.
980 (fill_in_menu): Remove unused variable `items_added'.
981
982 * w32term.c (last_mouse_press_frame): Remove static global variable.
983 (w32_clip_to_row): Remove unused variable `f'.
984 (x_delete_terminal): Remove unused variable `i'.
985
986 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
987 (NOTHING): Remove unused static global variable.
988 (uniscribe_check_otf): Remove unused variable `table'.
989 (uniscribe_font_driver): Add missing initializers.
990
dee091a3
JD
9912011-03-23 Julien Danjou <julien@danjou.info>
992
993 * term.c (Fsuspend_tty, Fresume_tty):
994 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
995 * window.c (temp_output_buffer_show):
996 * insdel.c (signal_before_change):
997 * frame.c (Fhandle_switch_frame):
998 * fileio.c (Fdo_auto_save):
999 * emacs.c (Fkill_emacs):
1000 * editfns.c (save_excursion_restore):
1001 * cmds.c (internal_self_insert):
1002 * callint.c (Fcall_interactively):
1003 * buffer.c (Fkill_all_local_variables):
1004 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1005 Use Frun_hooks.
0f4a96b5 1006 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1007 unconditionnaly since it does the check itself.
1008
2c520ab5 10092011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1010
c9c49752
PE
1011 Fix more problems found by GCC 4.5.2's static checks.
1012
8abc3f12
PE
1013 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1014 the first time through the loop, since we know p0 < p1 then.
1015 This also avoids a gcc -Wstrict-overflow warning.
1016
a2d26660
PE
1017 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1018 leading to a memory leak, possible in functions like
1019 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1020 of objects (Bug#8318).
a2d26660 1021
916c72e9
PE
1022 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1023 that could (at least in theory) be that large.
1024
19ab8a18
PE
1025 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1026 This is less likely to overflow, and avoids undefined behavior if
1027 overflow does occur. All callers changed. Use strtoul to scan
1028 for the unsigned long integer.
b7cbbd6f
PE
1029 (pint2hrstr): Simplify and tune code slightly.
1030 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1031
f0641eff
PE
1032 * scroll.c (do_scrolling): Work around GCC bug 48228.
1033 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1034
7f650bb9
PE
1035 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1036 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1037 (validate_x_resource_name): Simplify count usage.
1038 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1039
37dd57d1
PE
1040 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1041 fail (Bug#8306).
81e56e61 1042
699979fc 1043 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1044
401bf9b4
PE
1045 * process.c (Fmake_network_process): Use socklen_t, not int,
1046 where POSIX says socklen_t is required in portable programs.
1047 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1048 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1049 (Fmake_network_process, server_accept_connection):
1050 (wait_reading_process_output, read_process_output):
1051 Likewise.
1052
b93aacde
PE
1053 * process.c: Rename or move locals to avoid shadowing.
1054 (list_processes_1, Fmake_network_process):
1055 (read_process_output_error_handler, exec_sentinel_error_handler):
1056 Rename or move locals.
4dc343ee 1057 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1058 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1059 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1060 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1061 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1062
af8a867c 1063 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1064 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1065 Include tparam.h instead, since it declares them.
af8a867c
PE
1066 * cm.h (PC): Remove extern decl; tparam.h now does this.
1067 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1068 * terminfo.c: Include tparam.h, to check interfaces.
1069 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1070 (tparam): Adjust signature to match interface in tparam.h;
1071 this removes some undefined behavior. Check that outstring and len
1072 are zero, which they always are with Emacs.
1073 * tparam.h (PC, BC, UP): New extern decls.
1074
0248044d 1075 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1076 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1077
8ff096c1 1078 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1079 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1080 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1081 (ftfont_list): Remove unused local.
49eaafba
PE
1082 (get_adstyle_property, ftfont_pattern_entity):
1083 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1084 Rename locals to avoid shadowing.
8ff096c1 1085
e2be39f6
PE
1086 * xfont.c (xfont_list_family): Mark var as initialized.
1087
c9735e30
PE
1088 * xml.c (make_dom): Now static.
1089
8f5201ae
PE
1090 * composite.c (composition_compute_stop_pos): Rename local to
1091 avoid shadowing.
b246f932
PE
1092 (composition_reseat_it): Remove unused locals.
1093 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1094 (composition_update_it): Mark var as initialized.
11b61122
PE
1095 (find_automatic_composition): Mark vars as initialized,
1096 with a FIXME (Bug#8290).
8f5201ae 1097
760fbc2c
PE
1098 character.h: Rename locals to avoid shadowing.
1099 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1100 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1101 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1102 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1103 to avoid shadowing.
1104
ff08eb85
PE
1105 * textprop.c (property_change_between_p): Remove; unused.
1106
fc7bf025
PE
1107 * intervals.c (interval_start_pos): Now static.
1108
235d7abc
PE
1109 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1110
44f230aa
SM
1111 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1112 Rename locals to avoid shadowing.
3e7d6594 1113
50060332
PE
1114 * sound.c (wav_play, au_play, Fplay_sound_internal):
1115 Fix pointer signedness.
d01f234b 1116 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1117 (wav_play): Initialize a variable to 0, to prevent undefined
1118 behavior (Bug#8278).
50060332 1119
c4fc4e30
PE
1120 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1121
918436ed
PE
1122 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1123
c939f91b
PE
1124 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1125 clobbering (Bug#8298).
b9c7f648
PE
1126 * sysdep.c (sys_subshell): Likewise.
1127 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1128
6bd8c144
PE
1129 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1130 This should get cleaned up, so that child_setup has the
1131 same signature on all platforms.
1132
7710357c 1133 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1134 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1135
c59da222
CY
11362011-03-22 Chong Yidong <cyd@stupidchicken.com>
1137
1138 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1139 not to be necessary, and produces flickering.
1140
66b87493
GM
11412011-03-20 Glenn Morris <rgm@gnu.org>
1142
1143 * config.in: Remove file.
1144
45b6f6d5
JB
11452011-03-20 Juanma Barranquero <lekktu@gmail.com>
1146
1147 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1148 are now in src/globals.h.
1149 (syms_of_minibuf): Remove spurious & from previous change.
1150
3ec03f7e
LL
11512011-03-20 Leo <sdl.web@gmail.com>
1152
1153 * minibuf.c (completing-read-function): New variable.
1154 (completing-read-default): Rename from completing-read.
1155 (completing-read): Call completing-read-function.
1156
b14e3e21
CY
11572011-03-19 Juanma Barranquero <lekktu@gmail.com>
1158
1159 * xfaces.c (Fx_load_color_file):
1160 Read color file from absolute filename (bug#8250).
1161
f2b726e6
JB
11622011-03-19 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * makefile.w32-in: Update dependencies.
1165
09f6ff02
EZ
11662011-03-17 Eli Zaretskii <eliz@gnu.org>
1167
1168 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1169
29a6015a
PE
11702011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1171
a3a6c54e
PE
1172 Fix more problems found by GCC 4.5.2's static checks.
1173
b766f867
PE
1174 * process.c (make_serial_process_unwind, send_process_trap):
1175 (sigchld_handler): Now static.
1176
be02381c
PE
1177 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1178 That way, the code declares only the vars that it needs.
1179 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1180 * s/cygwin.h (PTY_ITERATION): Likewise.
1181 * s/darwin.h (PTY_ITERATION): Likewise.
1182 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1183
57048744
PE
1184 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1185 * process.c (allocate_pty): Don't declare stb unless it's needed.
1186
7914961c 1187 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1188 (CONSTANTLIM): Remove; unused.
1189 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1190 Define only if needed.
7914961c 1191
b3967b18
PE
1192 * unexelf.c (unexec): Name an expression,
1193 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1194 Use a different way to cause a compilation error if anyone uses
1195 n rather than nn, a way that does not involve shadowing.
73366a00 1196 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1197
29a6015a
PE
1198 * deps.mk (unexalpha.o): Remove; unused.
1199
43cfc33e 1200 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1201 * unexec.h: New file.
ce701a33
PE
1202 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1203 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1204 Depend on unexec.h.
1205 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1206 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1207 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1208 Change as necessary to match prototype in unexec.h.
ce701a33 1209
01f44d5a
PE
1210 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1211 shadowing.
4f63c6bb 1212 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1213
a6670b0b
PE
1214 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1215 Rename locals to avoid shadowing.
1216
cef2010d 1217 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1218 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1219
d4d7173a
PE
1220 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1221
f08b802a
PE
1222 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1223 warning when compiling print.c.
1224
3ddb0639
PE
1225 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1226 instead of using an uninitialized var.
5ad03b97 1227 (font_sort_entities): Mark var as initialized.
3ddb0639 1228
170a2692
PE
1229 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1230
e663c700
PE
1231 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1232 pointers to constants.
89bc529a 1233 (font_parse_fcname): Remove unused vars.
7b81e2d0 1234 (font_delete_unmatched): Now static.
ea838e10 1235 (font_get_spec): Remove; unused.
13a547c6
PE
1236 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1237 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1238 Rename or move locals to avoid shadowing.
e663c700 1239
2a80c887 1240 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1241 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1242
1384fa33 1243 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1244 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1245
8b2c52e9
PE
1246 * alloc.c (mark_backtrace): Move decl from here ...
1247 * lisp.h: ... to here, so that it can be checked.
1248
475545b5 1249 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1250 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1251 (lisp_indirect_variable): Name an expression,
1252 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1253 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1254
b1349114 1255 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1256 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1257 Use const pointer when appropriate.
b1349114 1258
a2928364
PE
1259 * lisp.h (get_system_name, get_operating_system_release):
1260 Move decls here, to check interfaces.
1261 * process.c (get_operating_system_release): Move decl to lisp.h.
1262 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1263 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1264 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1265 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1266 (Fformat_time_string, Fencode_time, Finsert_char):
1267 (Ftranslate_region_internal, Fformat):
1268 Rename or remove local vars to avoid shadowing.
9710023e 1269 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1270
a415e694
PE
1271 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1272 avoid shadowing.
1273
8ef4622d
PE
1274 * lisp.h (eassert): Check that the argument compiles, even if
1275 ENABLE_CHECKING is not defined.
1276
946f9a5b
PE
1277 * data.c (Findirect_variable): Name an expression, to avoid
1278 gcc -Wbad-function-cast warning.
112396d6 1279 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1280 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1281 (Fmake_variable_buffer_local, Fmake_local_variable):
1282 Mark variables as initialized.
52746918 1283 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1284
e5aab7e7 1285 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1286 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1287 Rename locals to avoid shadowing.
dff45157
PE
1288 (mark_stack): Move local variables into the #ifdef region where
1289 they're used.
7bc26fdb
PE
1290 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1291 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1292 needed otherwise.
1293 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1294 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1295 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1296
e5aab7e7
PE
1297 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1298 avoids undefined behavior in theory.
1299
4da60324
PE
1300 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1301
88043301
PE
1302 Use functions, not macros, for up- and down-casing (Bug#8254).
1303 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1304 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1305 to use the following functions instead of these macros.
1306 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1307 EMACS_INT, since callers assume the returned value fits in int.
1308 (upcase1): Likewise, for UPCASE_TABLE.
1309 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1310 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1311 the race-condition problem in the old DOWNCASE.
88043301 1312
19ed5445
PE
1313 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1314 Rename locals to avoid shadowing.
1315 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1316 (regex_compile, re_search_2, re_match_2_internal):
1317 Remove unused local vars.
952db0d7
PE
1318 (FREE_VAR): Rewrite so as not to use empty "else",
1319 which gcc can warn about.
da053e48 1320 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1321 (RETALLOC_IF): Define only if needed.
1322 (WORDCHAR_P): Likewise. This one is never needed, but is used
1323 only in a comment talking about a compiler bug, so put inside
1324 the #if 0 of that comment.
1325 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1326 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1327 Remove; unused.
19ed5445 1328
1f3561e4 1329 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1330 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1331 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1332
ded6f8f7
PE
1333 * search.c (simple_search): Remove unused var.
1334
dbd37a95
PE
1335 * dired.c (compile_pattern): Move decl from here ...
1336 * lisp.h: ... to here, so that it can be checked.
1337 (struct re_registers): New forward decl.
1338
7e47afad
PE
1339 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1340
85f24f61
PE
1341 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1342 All uses changed.
1343 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1344 Rename locals to avoid shadowing.
5671df8f 1345 (Fvertical_motion): Mark locals as initialized.
85f24f61 1346
181aa2be 1347 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1348 (casify_region): Mark local as initialized.
181aa2be 1349
930d429c
PE
1350 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1351
7082eac6
PE
1352 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1353 New macros, so that the caller can use some names other than
1354 gcpro1, gcpro2, etc.
1355 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1356 of the new macros.
1357 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1358 argument, for consistency with GCPRO2_VAR, etc: it is now the
1359 prefix of the variable, not the variable itself. All uses
1360 changed.
38b2c076
PE
1361 * dired.c (directory_files_internal, file_name_completion):
1362 Rename locals to avoid shadowing.
1363
15206ed9
PE
1364 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1365 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1366 dired.c's scmp function, had undefined behavior.
1367 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1368 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1369 * buffer.h: ... to here, because these macros use current_buffer,
1370 and the new implementation with inline functions needs to have
1371 current_buffer in scope now, rather than later when the macros
1372 are used.
1373 (downcase, upcase1): New static inline functions.
1374 (DOWNCASE, UPCASE1): Reimplement using these functions.
1375 This avoids undefined behavior in expressions like
1376 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1377 from race conditions in accessing the global variables
1378 case_temp1 and case_temp2.
1379 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1380 * lisp.h (case_temp1, case_temp2): Remove their decls.
1381 * character.h (ASCII_CHAR_P): Move from here ...
1382 * lisp.h: ... to here, so that the inline functions mentioned
1383 above can use them.
1384
4a6bea26
PE
1385 * dired.c (directory_files_internal_unwind): Now static.
1386
f14b7e14
PE
1387 * fileio.c (file_name_as_directory, directory_file_name):
1388 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1389 Now static.
2893f146
PE
1390 (file_name_as_directory): Use const pointers when appropriate.
1391 (Fexpand_file_name): Likewise. In particular, newdir might
1392 point at constant storage, so make it a const pointer.
fd4ead52 1393 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1394 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1395 signedness issues.
f839df0c
PE
1396 (Fset_file_times, Finsert_file_contents, auto_save_error):
1397 Rename locals to avoid shadowing.
f14b7e14 1398
5716756e 1399 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1400 (Ftry_completion, Fall_completions): Rename or remove locals
1401 to avoid shadowing.
5716756e 1402
b4c3046a
PE
1403 * marker.c (bytepos_to_charpos): Remove; unused.
1404
b45db522
PE
1405 * lisp.h (verify_bytepos, count_markers): New decls,
1406 so that gcc does not warn that these functions aren't declared.
1407
85876d07
PE
1408 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1409 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1410 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1411 (copy_text): Remove unused local var.
85876d07 1412
03d78a21 1413 * filelock.c (within_one_second): Now static.
b3dd38ab 1414 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1415
5df8f01b
PE
1416 * buffer.c (fix_overlays_before): Mark locals as initialized.
1417 (fix_start_end_in_overlays): Likewise. This function should be
1418 simplified by using pointers-to-pointers, but that's a different
1419 matter.
b1d876f1 1420 (switch_to_buffer_1): Now static.
8f54f30a
PE
1421 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1422 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1423
a70072c9 1424 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1425 Fix pointer signedness issue.
edced198
PE
1426 (sys_subshell): Mark local as volatile if checking for lint,
1427 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1428 (MAXPATHLEN): Define only if needed.
a70072c9 1429
a0977c44
PE
1430 * process.c (serial_open, serial_configure): Move decls from here ...
1431 * systty.h: ... to here, so that they can be checked.
1432
a884fdcc
PE
1433 * fns.c (get_random, seed_random): Move extern decls from here ...
1434 * lisp.h: ... to here, so that they can be checked.
1435
604efe86 1436 * sysdep.c (reset_io): Now static.
b8950c94 1437 (wait_for_termination_signal): Remove; unused.
604efe86 1438
38fc62d9
PE
1439 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1440 (copy_keymap_item, append_key, push_text_char_description):
1441 Now static.
1004a21a 1442 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1443 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1444 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1445 (describe_map_tree):
1446 Rename locals to avoid shadowing.
38fc62d9 1447
2f2650da
PE
1448 * keyboard.c: Declare functions static if they are not used elsewhere.
1449 (echo_char, echo_dash, cmd_error, top_level_2):
1450 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1451 (read_char, kbd_buffer_get_event, make_lispy_position):
1452 (make_lispy_event, make_lispy_movement, apply_modifiers):
1453 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1454 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1455 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1456 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1457 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1458
a053e86c 1459 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1460 (mark_kboards): Move decl here ...
1461 * alloc.c (mark_kboards): ... from here.
a053e86c 1462
4752793e
PE
1463 * lisp.h (force_auto_save_soon): New decl.
1464
74f10ca7 1465 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1466 (DEFINE_DUMMY_FUNCTION): New macro.
1467 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1468 Use it.
c03cd23f
PE
1469 (main): Add casts to avoid warnings
1470 if GCC considers string literals to be constants.
74f10ca7 1471
022e70d4
PE
1472 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1473
59d6fe83
PE
1474 * dbusbind.c: Pointer signedness fixes.
1475 (xd_signature, xd_append_arg, xd_initialize):
1476 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1477 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1478 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1479 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1480
78320123
PE
1481 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1482 if GCC considers string literals to be constants.
49cebcca 1483 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1484
35ac2a97
SM
14852011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1486
fb103ca9
SM
1487 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1488 (print_preprocess, print_object): New macro to fix last change.
1489
35ac2a97
SM
1490 * print.c (print_preprocess): Don't forget font objects.
1491
62973b41
JB
14922011-03-16 Juanma Barranquero <lekktu@gmail.com>
1493
1494 * emacs.c (USAGE3): Doc fixes.
1495
0e48bb22
AS
14962011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1497
1498 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1499 structure.
1500
7684e57b
JB
15012011-03-14 Juanma Barranquero <lekktu@gmail.com>
1502
1503 * lisp.h (VWindow_system, Qfile_name_history):
1504 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1505 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1506 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1507
1508 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1509 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1510
1511 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1512 * w32console.c (detect_input_pending, read_input_pending)
1513 (encode_terminal_code):
1514 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1515 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1516 (w32_system_caret_y, Qfile_name_history):
1517 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1518 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1519 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1520 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1521 * w32proc.c (Qlocal, report_file_error):
1522 * w32term.c (Vwindow_system, updating_frame):
1523 * w32uniscribe.c (initialized, uniscribe_font_driver):
1524 Remove unneeded extern declarations.
1525
2aa46d6c
CY
15262011-03-14 Chong Yidong <cyd@stupidchicken.com>
1527
c96bbc66 1528 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1529
cffc6f3b
CY
15302011-03-13 Chong Yidong <cyd@stupidchicken.com>
1531
1532 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1533 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1534 These macros can no longer be used for assignment.
1535
44f230aa
SM
1536 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1537 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1538 (record_buffer_markers, fetch_buffer_markers): New functions for
1539 recording and fetching special buffer markers.
1540 (set_buffer_internal_1, set_buffer_temp): Use them.
1541
1542 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1543
1544 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1545
1546 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1547 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1548
1549 * xdisp.c (hscroll_window_tree):
1550 (reconsider_clip_changes): Use PT instead of BUF_PT.
1551
d251f04b
EZ
15522011-03-13 Eli Zaretskii <eliz@gnu.org>
1553
1554 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1555 $(EMACS_ROOT)/lib/intprops.h.
1556
f0c77cd1
PE
15572011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1558
3eca4629
PE
1559 Fix more problems found by GCC 4.5.2's static checks.
1560
7c86ee98
PE
1561 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1562 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1563 (xg_free_frame_widgets): Make it clear that a local variable is
1564 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1565 (gdk_window_get_screen): Make it clear that this macro is needed
1566 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1567 (int_gtk_range_get_value): New function, which avoids a diagnostic
1568 from gcc -Wbad-function-cast.
1569 (xg_set_toolkit_scroll_bar_thumb): Use it.
1570 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1571 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1572 (get_utf8_string, xg_get_file_with_chooser):
1573 Rename locals to avoid shadowing.
1574 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1575
41729b81
PE
1576 * xgselect.c (xg_select): Remove unused var.
1577
f0c77cd1
PE
1578 * image.c (four_corners_best): Mark locals as initialized.
1579 (gif_load): Initialize transparent_p to zero (Bug#8238).
1580 Mark another local as initialized.
ec6cf4c6 1581 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1582
ce0ad53d 1583 * image.c (clear_image_cache): Now static.
d5d5a617 1584 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1585 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1586 (x_edge_detection): Remove unnecessary cast that
1587 gcc -Wbad-function-cast diagnoses.
2037898d 1588 (gif_load): Fix pointer signedness.
6ae141d6
PE
1589 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1590 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1591
33383987 15922011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1593
d32df629
PE
1594 Improve quality of tests for time stamp overflow.
1595 For example, without this patch (encode-time 0 0 0 1 1
1596 1152921504606846976) returns the obviously-bogus value (-948597
1597 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1598 reports time overflow. See
1599 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1600 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1601 * editfns.c: Include limits.h and intprops.h.
1602 (TIME_T_MIN, TIME_T_MAX): New macros.
1603 (time_overflow): Move earlier, to before first use.
1604 (hi_time, lo_time): New functions, for an accurate test for
1605 out-of-range times.
1606 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1607 (Fget_internal_run_time): Don't assume time_t fits in int.
1608 (make_time): Use list2 instead of Fcons twice.
1609 (Fdecode_time): More accurate test for out-of-range times.
1610 (check_tm_member): New function.
1611 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1612 (lisp_time_argument): Don't rely on undefined left-shift and
1613 right-shift behavior when checking for time stamp overflow.
8be6f318 1614
fe31d94c
PE
1615 * editfns.c (time_overflow): New function, refactoring common code.
1616 (Fformat_time_string, Fdecode_time, Fencode_time):
1617 (Fcurrent_time_string): Use it.
1618
8be6f318
PE
1619 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1620 * dired.c (make_time): Move to ...
1621 * editfns.c (make_time): ... here.
1622 * systime.h: Note the move.
1623
09d9db2c 16242011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1625
126bc0dc
YM
1626 * fringe.c (update_window_fringes): Remove unused variables.
1627
c47cbdfd
YM
1628 * unexmacosx.c (copy_data_segment): Also copy __got section.
1629 (Bug#8223)
1630
7ac80be9
EZ
16312011-03-12 Eli Zaretskii <eliz@gnu.org>
1632
c96bbc66 1633 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1634 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1635 Constify `char *' arguments and their references according to
1636 prototypes in tparam.h.
1637
ecb0f94d 1638 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1639
7ac80be9
EZ
1640 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1641 Adapt all references accordingly.
1642
1643 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1644
ef1fd07e
TT
16452011-03-11 Tom Tromey <tromey@redhat.com>
1646
1647 * buffer.c (syms_of_buffer): Remove obsolete comment.
1648
7ef4b50c
EZ
16492011-03-11 Eli Zaretskii <eliz@gnu.org>
1650
1651 * termhooks.h (encode_terminal_code): Declare prototype.
1652
1653 * msdos.c (encode_terminal_code): Don't declare prototype.
1654
1655 * term.c (encode_terminal_code): Now external again, used by
1656 w32console.c and msdos.c.
1657
44f230aa
SM
1658 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1659 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1660
4b1ec863 16612011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1662
1714f52b 1663 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1664
4b1ec863
PE
1665 * fringe.c (update_window_fringes): Mark locals as initialized
1666 (Bug#8227).
1667 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1668
524c7aa6
PE
1669 * alloc.c (mark_fringe_data): Move decl from here ...
1670 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1671 to check its interface.
1672 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1673
a5c0af81 1674 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1675 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1676 (fontset_font): Mark local as initialized.
a9a06e0b 1677 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1678
b4716021
PE
1679 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1680
811e9bac 1681 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1682 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1683 (x_own_selection, Fx_disown_selection_internal): Rename locals
1684 to avoid shadowing.
1685 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1686
7e3ab302
PE
1687 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1688 so that the caller can use some name other than gcpro1.
1689 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1690 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1691 (Fx_backspace_delete_keys_p):
1692 Use them to avoid shadowing, and rename vars to avoid shadowing.
1693 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1694 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1695 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1696 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1697 Remove unused locals.
7e3ab302
PE
1698 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1699 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1700 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1701 macros.
f78faa98 1702
e2b13473
PE
1703 * xterm.h (x_mouse_leave): New decl.
1704
77f23912
PE
1705 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1706 Remove unused functions.
cdf4ba58
PE
1707 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1708 (x_calc_absolute_position): Now static.
7411c686 1709 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1710 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1711 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1712 unless they are used.
38d0b34a
PE
1713 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1714 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1715 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1716 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1717 (x_error_catcher, x_connection_closed, x_error_handler):
1718 (x_error_quitter, xembed_send_message, x_iconify_frame):
1719 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1720 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1721 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1722
44f230aa
SM
1723 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1724 Rename or move locals to avoid shadowing.
6b463e58 1725 (tty_defined_color, merge_face_heights): Now static.
5967d051 1726 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1727 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1728 does not deduce is never used uninitialized.
73719eba
PE
1729 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1730 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1731
426994c3 1732 * terminal.c (store_terminal_param): Now static.
5489860b 1733
032f1620 1734 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1735 (set_frame_menubar): Remove unused local.
d4323972 1736 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1737 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1738 since they might point to immutable storage.
281585b0
PE
1739 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1740 since it's unused otherwise.
032f1620 1741
367c19e5 1742 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1743 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1744 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1745 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1746 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1747 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1748 does not deduce are never used uninitialized.
70739cbe 1749
07b48fa9
PE
1750 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1751
8868a238 1752 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1753 * window.c (window_loop, size_window):
1754 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1755
7e5cf297 1756 * window.c (display_buffer): Now static.
d6550a9f
PE
1757 (size_window): Mark variables that gcc -Wuninitialized
1758 does not deduce are never used uninitialized.
a586633d
PE
1759 * window.h (check_all_windows): New decl, to forestall
1760 gcc -Wmissing-prototypes diagnostic.
5b555da1 1761 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1762
f6095868
PE
1763 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1764 shadowing.
1765 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1766 Include <limits.h>.
1767 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1768 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1769 (load_charset_map): Mark variables that gcc -Wuninitialized
1770 does not deduce are never used uninitialized.
53df7c11 1771 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1772
f38b440c
PE
1773 * coding.c (coding_set_source, coding_set_destination):
1774 Use "else { /* comment */ }" rather than "else /* comment */;"
1775 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1776 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1777 a block, when the outer 'i' will do.
1778 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1779 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1780 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1781 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1782 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1783 Rename locals to avoid shadowing.
1784 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1785 * coding.c (emacs_mule_char, encode_invocation_designation):
1786 Now static, since they're not used elsewhere.
413bb2db 1787 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1788 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1789 (decode_coding_emacs_mule): Mark variables that gcc
1790 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1791 (detect_coding_iso_2022): Initialize a local variable that might
1792 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1793 this initialization is needed. (Bug#8211)
5f58e762
PE
1794 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1795 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1796 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1797 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1798 Remove unused macros.
f38b440c 1799
232b38b9 1800 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1801 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1802 * character.c (string_count_byte8): Likewise.
232b38b9 1803
fb90da1b
PE
1804 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1805 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1806
fb93dbc2
PE
1807 * chartab.c (copy_sub_char_table): Now static, since it's not used
1808 elsewhere.
5c156ace
PE
1809 (sub_char_table_ref_and_range, char_table_ref_and_range):
1810 Rename locals to avoid shadowing.
bbcd0949 1811 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1812
7d3b3862 1813 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1814 (BIDI_BOB): Remove unused macro.
7d3b3862 1815
6be7d3da
PE
1816 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1817 deduce are never used uninitialized.
c2ed9c8b 1818 * term.c (encode_terminal_code): Likewise.
6be7d3da 1819
75f8807f 1820 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1821
50938595
PE
1822 * tparam.h: New file.
1823 * term.c, tparam.h: Include it.
1824 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1825 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1826 Move these decls to tparam.h, and make them agree with what
1827 is actually in tparam.c. The previous trick of using incompatible
1828 decls in different modules does not conform to the C standard.
1829 All callers of tparam changed to use tparam's actual API.
1830 * tparam.c (tparam1, tparam, tgoto):
1831 Use const pointers where appropriate.
1832
fbceeba2
PE
1833 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1834 * cm.h (struct cm): Likewise.
1835 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1836 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1837 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1838 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1839 (turn_on_face, init_tty): Likewise.
1840 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1841
7f3f1250
PE
1842 * term.c (term_mouse_position): Rename local to avoid shadowing.
1843
e6ca6543
PE
1844 * alloc.c (mark_ttys): Move decl from here ...
1845 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1846
c40f8d15
AS
18472011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1850
cfe0661d
JB
18512011-03-09 Juanma Barranquero <lekktu@gmail.com>
1852
1853 * search.c (compile_pattern_1): Remove argument regp, unused since
1854 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1855 (compile_pattern): Don't pass it.
1856
0afb4571
J
18572011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1858
1859 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1860 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1861 for ! HAVE_GTK3.
1862 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1863
1864 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1865
1866 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1867 gdk_window_get_screen, gdk_window_get_geometry,
1868 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1869 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1870 (xg_get_pixbuf_from_pixmap): New function.
1871 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1872 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1873 Call xg_get_pixbuf_from_pixmap instead of
1874 gdk_pixbuf_get_from_drawable.
1875 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1876 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1877 (xg_check_special_colors): Use GtkStyleContext and its functions
1878 for HAVE_GTK3.
1879 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1880 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1881 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1882 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1883 Call gtk_widget_get_preferred_size.
0afb4571
J
1884 (xg_frame_resized): gdk_window_get_geometry only takes 5
1885 parameters.
44f230aa
SM
1886 (xg_win_to_widget, xg_event_is_for_menubar):
1887 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1888 (xg_set_widget_bg): New function.
1889 (delete_cb): New function.
1890 (xg_create_frame_widgets): connect delete-event to delete_cb.
1891 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1892 (xg_set_background_color): Call xg_set_widget_bg.
1893 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1894 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1895 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1896 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1897 if ! HAVE_GTK3.
1898 (update_frame_tool_bar): Call gtk_widget_hide.
1899 (xg_initialize): Use GDK_KEY_g.
1900
1901 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1902 if ! HAVE_GTK3
1903 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1904
1905 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1906 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1907 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1908
1c2cc4ef
JB
19092011-03-08 Juanma Barranquero <lekktu@gmail.com>
1910
1911 * w32xfns.c (select_palette): Check success of RealizePalette against
1912 GDI_ERROR, not zero.
1913
33383987 1914See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1915
1916;; Local Variables:
1917;; coding: utf-8
aac0c6e3
MR
1918;; End:
1919
33383987 1920 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1921
1922 This file is part of GNU Emacs.
1923
1924 GNU Emacs is free software: you can redistribute it and/or modify
1925 it under the terms of the GNU General Public License as published by
1926 the Free Software Foundation, either version 3 of the License, or
1927 (at your option) any later version.
1928
1929 GNU Emacs is distributed in the hope that it will be useful,
1930 but WITHOUT ANY WARRANTY; without even the implied warranty of
1931 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1932 GNU General Public License for more details.
1933
1934 You should have received a copy of the GNU General Public License
1935 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.