Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7da0b018
PE
12011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4 * editfns.c: Rewrite current-time-zone so that it invokes
5 the equivalent of (format-time-string "%Z") to get the time zone name.
6 This fixes a bug when the time zone name contains characters that
7 need converting from the system time locale to Emacs internal format.
8 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9 that patch fixed format-time-string to do the conversion, but
10 I forgot to fix current-time-zone.
11 (format_time_string): New function, containing most of
12 what Fformat_time_string used to contain.
13 (Fformat_time_string): Rewrite in terms of format_time_string.
14 This doesn't change this function's behavior.
15 (current-time-zone): Rewrite to use format_time_string.
16 This fixes the bug reported by Michael Schierl in
17 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
18 Jason Rumney's 2007-06-07 change worked around this bug, but
19 didn't fix it.
20 * systime.h (tzname, timezone): Remove no-longer-used declarations.
21
8547b010
EZ
222011-10-19 Eli Zaretskii <eliz@gnu.org>
23
24 * xdisp.c (start_display): If the character at POS is displayed
25 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
26 (try_window_reusing_current_matrix): If a line ends in a display
27 vector or the next line starts in a display vector, continue
28 redrawing the window even though the character position of
29 start_row was reached.
8547b010
EZ
30 (Bug#9771, part 2)
31
4e948d15
CY
322011-10-18 Chong Yidong <cyd@gnu.org>
33
34 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
35 with nobreak-char-display too.
36
4787455f
EZ
372011-10-18 Eli Zaretskii <eliz@gnu.org>
38
39 Fix part 3 of bug#9771.
40 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
41 (bidi_resolve_neutral): Don't enter the expensive loop looking for
42 non-neutral characters if the current character is a paragraph
43 separator (a.k.a. Newline). This avoids running the same
44 expensive loop twice, once when we consume the preceding newline
45 and the other time when the line actually needs to be displayed.
46 Avoid the loop when we see neutrals on the base embedding level
47 following a character whose directionality is the same as the
48 paragraph's. This avoids running the expensive loop when a line
49 ends in a long sequence of neutrals, like control characters.
50 Add assertion against STRONG_AL type. Slightly rearrange code
51 that determines the type of a neutral given the first non-neutral
52 that follows it.
53 (bidi_level_of_next_char): Set next_en_pos to zero when
54 invalidating its info.
55
2c91f553
EZ
562011-10-17 Eli Zaretskii <eliz@gnu.org>
57
58 * xdisp.c (push_display_prop): Determine whether to record string
59 or buffer position by IT->string, not by IT->method. Allow
60 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
61 (move_it_vertically_backward): Don't look for character position
62 immediately after the newline when in a continuation line.
63 (Bug#9771, part 1)
2c91f553 64
c7b08b0d
MR
652011-10-15 Martin Rudalics <rudalics@gmx.at>
66
67 * window.c (coordinates_in_window): Rewrite and delabelize
68 vertical border check. (Bug#5357) (Bug#9618)
69
6b02f655
SM
702011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
71
72 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
73 errors in XSetWindowBorder (bug#9310).
74
81d40c92
DA
752011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
76
77 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
78 avoid crash when xmalloc overrun checking is enabled.
79
d4172c3b
EZ
802011-10-13 Eli Zaretskii <eliz@gnu.org>
81
82 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
83 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
84 cursor motion with <left> and <right> arrow keys.
85
86 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
87 some callers set that themselves.
88
b00eea75
EZ
892011-10-12 Eli Zaretskii <eliz@gnu.org>
90
91 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
92 display string and the previous row comes from the same string and
93 is empty. (Bug#9739) (Bug#9738)
94
8fe012c4
SM
952011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
96
97 * doc.c (get_doc_string): Encode file name (bug#9735).
98
0074aef2
EZ
992011-10-12 Eli Zaretskii <eliz@gnu.org>
100
79beb178
EZ
101 * bidi.c (bidi_level_of_next_char):
102 * xdisp.c (get_visually_first_element): Remove old incorrect
103 comments regarding the Unicode Line Separator character.
104
0074aef2
EZ
105 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
106
6e4b3fbe
DA
1072011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
108
109 * alloc.c (Fgc_status): Do not access beyond zombies array
110 boundary if nzombies > MAX_ZOMBIES.
111 * alloc.c (dump_zombies): Add missing format specifier.
112
0324f3af
PE
1132011-10-12 Paul Eggert <eggert@cs.ucla.edu>
114
b5525cac
PE
115 * xdisp.c (set_cursor_from_row): Simplify conditionals,
116 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
117
0324f3af
PE
118 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
119 Some packages use them to denote characters with modifiers.
120
e9b5f888
AS
1212011-10-11 Andreas Schwab <schwab@linux-m68k.org>
122
123 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
124 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
125 matching a pp-number. Rename parameter var to var1.
126
127827c0
SM
1272011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
128
129 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
130
c8fd3bd0
GM
1312011-10-08 Glenn Morris <rgm@gnu.org>
132
133 * callint.c (Fcall_interactively): Give a more explicit error for the
134 'c' case with a non-character input. (Bug#8479)
135
352ec8ff
EZ
1362011-10-08 Eli Zaretskii <eliz@gnu.org>
137
03669ccb
EZ
138 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
139 lines.
7061c986
EZ
140 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
141 lines that are hscrolled on the left.
03669ccb 142
352ec8ff
EZ
143 * dispnew.c (buffer_posn_from_coords): Account for a possible
144 presence of header-line. (Bug#4426)
145
a66cfb1c
SM
1462011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
147
6b02f655
SM
148 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
149 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 150
7c5ee88e
PE
1512011-10-07 Paul Eggert <eggert@cs.ucla.edu>
152
153 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
154 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
155 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
156 this makes Emacs dump core during garbage collection on rare
157 occasions. sizeof is obviously inferior to offsetof here, so
158 stick with offsetof.
159 (GC_POINTER_ALIGNMENT): New macro.
160 (mark_memory): Omit 3rd (offset) arg; caller changed.
161 Don't assume EMACS_INT alignment is the same as pointer alignment.
162
df1bbe5b
SM
1632011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
164
165 * keyboard.c (read_key_sequence_remapped): New var.
166 (read_key_sequence): Compute remapping in the right buffer.
167 (command_loop_1): Use read_key_sequence's remapping directly.
168
51553db6
SM
1692011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
170
32c1fffd
SM
171 * dired.c (file_name_completion): Don't expand file name.
172 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
173 before checking file name handler.
174
51553db6
SM
175 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
176 they've been requested explicitly (bug#9591).
177
b6bd1599 1782011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
179
180 * keymap.c (Fsingle_key_description): Use make_specified_string
181 instead of build_string to build string from push_key_description.
182 (Bug#5193)
183
f701dc2a
PE
1842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
185
4222c55d
PE
186 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
187 This fixes a Y2038 bug on 64-bit hosts.
188 * buffer.c (reset_buffer):
189 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
190 (Fclear_buffer_auto_save_failure):
191 Use 0, not -1, to represent an unset failure time, since time_t
192 might not be signed.
193
f701dc2a
PE
194 Remove dependency on glibc malloc internals.
195 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
196 Move back here from lisp.h, but with their new implementations.
197 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
198 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
199 * charset.c (charset_table_init): New static var.
200 (syms_of_charset): Use it instead of xmalloc. This removes a
201 dependency on glibc malloc internals. See Eli Zaretskii's comment in
202 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
203 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
204 Move back to alloc.c.
205 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
206 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
207
9ceebf39
JD
2082011-09-30 Jan Djärv <jan.h.d@swipnet.se>
209
210 * nsterm.m (windowDidResize): Call x_set_window_size only when
211 ns_in_resize is true. Otherwise set pixelwidth/height and
212 call change_frame_size (Bug#9628).
213
cb993c58
PE
2142011-09-30 Paul Eggert <eggert@cs.ucla.edu>
215
3930c88b
PE
216 Port --enable-checking=all to Fedora 14 x86-64.
217 * charset.c (syms_of_charset): Also account for glibc malloc's
218 internal overhead when calculating the initial malloc maximum.
219
cb993c58
PE
220 Port --enable-checking=all to Fedora 14 x86.
221 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
222 Move to lisp.h.
223 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
224 (overrun_check_realloc, overrun_check_free):
225 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
226 That way, xmalloc returns a properly-aligned pointer even if
227 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
228 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
229 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
230 into account when calculating the initial malloc maximum.
231 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
232 Move here from alloc.c, so that charset.c can use it too.
233 Properly align; the old code wasn't right for common 32-bit hosts
234 when configured with --enable-checking=all.
235 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
236 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
237
31bed486
EZ
2382011-09-29 Eli Zaretskii <eliz@gnu.org>
239
04c70788 240 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
241 use EDOM.
242
fbcaa2f3
EZ
2432011-09-28 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (compute_display_string_end): If there's no display
246 string at CHARPOS, return -1.
247
248 * bidi.c (bidi_fetch_char): When compute_display_string_end
249 returns a negative value, treat the character as a normal
250 character not covered by a display string. (Bug#9624)
251
a239d4e9
JB
2522011-09-28 Juanma Barranquero <lekktu@gmail.com>
253
254 * lread.c (Fread_from_string): Fix typo in docstring.
255
88652fd5
EZ
2562011-09-27 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (handle_invisible_prop): If invisible text ends on a
259 newline, reseat the iterator instead of bidi-iterating there one
260 character at a time. (Bug#9610)
32c1fffd
SM
261 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
262 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 263
ed497dd4
AS
2642011-09-27 Andreas Schwab <schwab@linux-m68k.org>
265
266 * lread.c (readevalloop): Use correct code for NBSP.
267 (read1): Likewise. (Bug#9608)
268
b2bf61aa
MA
2692011-09-25 Michael Albinus <michael.albinus@gmx.de>
270
271 * dbusbind.c (Fdbus_register_signal): When service is not
272 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
273
32bbb17c
GM
2742011-09-25 Glenn Morris <rgm@gnu.org>
275
276 * buffer.c (truncate-lines): Doc fix.
277
94e0933e
CY
2782011-09-24 Chong Yidong <cyd@stupidchicken.com>
279
280 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
281 (Fset_window_next_buffers): Doc fix.
282
cddde921
GM
2832011-09-24 Glenn Morris <rgm@gnu.org>
284
285 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
286
1260aef1
PE
2872011-09-24 Paul Eggert <eggert@cs.ucla.edu>
288
25b4bfa0
PE
289 Fix minor problems found by static checking.
290 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
291 * indent.c (Fvertical_motion): Fix == vs = typo.
292
e3cbd34b
EZ
2932011-09-24 Eli Zaretskii <eliz@gnu.org>
294
a66cfb1c
SM
295 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
296 Default value is now t. Doc fix.
6bf7006f 297
e3cbd34b 298 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 299 logic when moving up, not only when moving down. Fix the
e3cbd34b 300 confusing name and values of the it_overshoot_expected variable;
32c1fffd 301 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
302
303 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
304 CHARPOS is covered by a display string which includes newlines.
305 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
306 is covered by a display string with embedded newlines.
307
a3de0cbd
MA
3082011-09-24 Michael Albinus <michael.albinus@gmx.de>
309
310 * dbusbind.c (Fdbus_register_signal): Add match rule to
311 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
312 (Fdbus_register_method, Vdbus_registered_objects_table):
313 Fix docstring.
a3de0cbd 314
b260039d
JM
3152011-09-24 Jim Meyering <meyering@redhat.com>
316
32c1fffd 317 do not ignore write error for any output size
b260039d
JM
318 The previous change was incomplete.
319 While it makes emacs --batch detect the vast majority of stdout
320 write failures, errors were still ignored whenever the output size is
321 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
322 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
323 && echo FAIL: ignored write error
324 FAIL: ignored write error
325 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
326 && echo FAIL: ignored write error
327 FAIL: ignored write error
328 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
329
8eca8a7c
AS
3302011-09-23 Andreas Schwab <schwab@linux-m68k.org>
331
332 * emacs.c (Fkill_emacs): In noninteractive mode exit
333 non-successfully if a write error occurred on stdout. (Bug#9574)
334
3341db62
EZ
3352011-09-21 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
338 the xassert test.
339
340 * dispextern.h (struct it): Update the comment documenting what
341 can it->OBJECT be.
342
8c203dbf
EZ
3432011-09-20 Eli Zaretskii <eliz@gnu.org>
344
345 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
346 a display string, extend search for cursor position to end of row.
347 (find_row_edges): If the row ends in a newline from a display
348 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
349 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
350 (Fcurrent_bidi_paragraph_direction): Fix search for previous
351 non-empty line. Fixes confusing cursor motion with arrow keys at
352 the beginning of a line that starts with whitespace.
8c203dbf 353
a4824228
LMI
3542011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
355
356 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
357 (bug#9493).
358
33ed493b
CY
3592011-09-18 Chong Yidong <cyd@stupidchicken.com>
360
361 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
362 boolean (Bug#9154).
363
56cd55c8
EZ
3642011-09-18 Eli Zaretskii <eliz@gnu.org>
365
366 * xdisp.c (display_line): Record maximum and minimum buffer
367 positions even if no glyphs were produced (e.g., by a zero-width
368 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
369 buffer positions that will be removed from the glyph row because
370 they don't fit.
c02dcedf
EZ
371 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
372 column is beyond frame width: don't subtract 1 "pixel" when
373 computing width of the stretch.
3e62b7e0
EZ
374 (reseat_at_next_visible_line_start): Undo the change made on
375 2011-09-17 that saved paragraph information and restored it after
376 the call to `reseat'. (Bug#9545)
56cd55c8 377
5ed99d36 3782011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
379
380 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
381 and turn window cursor on if cleared (Bug#9415).
382
5ed99d36 3832011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
384
385 * search.c (boyer_moore): Take unibyte characters from pattern
386 literally. (Bug#9458)
387
9bade7b2
EZ
3882011-09-18 Eli Zaretskii <eliz@gnu.org>
389
390 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
391
e5e9d610
PE
3922011-09-18 Paul Eggert <eggert@cs.ucla.edu>
393
87e4427a
PE
394 Fix minor problem found by static checking.
395 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
396 initialized, to pacify gcc -Wuninitialized.
397
e5e9d610
PE
398 * fileio.c: Report proper errno when syscall falls.
399 (Finsert_file_contents): Save and restore errno,
400 so that report_file_error outputs the correct diagnostic.
401 (Fwrite_region) [CLASH_DETECTION]: Likewise.
402
a1674f0b
EZ
4032011-09-18 Eli Zaretskii <eliz@gnu.org>
404
405 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
406
fbfb6dd4
EZ
4072011-09-17 Eli Zaretskii <eliz@gnu.org>
408
409 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
410 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
411
bb187662
EZ
4122011-09-17 Eli Zaretskii <eliz@gnu.org>
413
1137e8b8 414 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 415 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
416
417 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
418 (bidi_find_paragraph_start): Search back for paragraph beginning
419 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
420 (bidi_move_to_visually_next): Only trigger paragraph-related
421 computations when the last character is a newline or at EOB, not
422 just any NEUTRAL_B. (Bug#9470)
423
bb187662
EZ
424 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
425 truncated lines if point is covered by a display string. (Bug#9524)
426
2e621251
PE
4272011-09-16 Paul Eggert <eggert@cs.ucla.edu>
428
429 * xselect.c: Relax test for outgoing X longs (Bug#9498).
430 (cons_to_x_long): New function.
431 (lisp_data_to_selection_data): Use it. Correct the test for
432 short-versus-long data; it was negated. Break out of vector
433 loop, for efficiency, when a long datum is discovered.
434
91a15bc6
SM
4352011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
436
437 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
438
b41c3a35
EZ
4392011-09-16 Eli Zaretskii <eliz@gnu.org>
440
441 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
442 GCC PR/17406) by declaring this function with external scope.
443
7812ba2d
PE
4442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
445
446 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
447 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
448
cf7edc2a
AS
4492011-09-15 Andreas Schwab <schwab@linux-m68k.org>
450
451 * editfns.c (Fformat): Correctly handle text properties on "%%".
452
bd01620e
EZ
4532011-09-15 Eli Zaretskii <eliz@gnu.org>
454
455 * xterm.c (x_draw_composite_glyph_string_foreground):
456 * w32term.c (x_draw_composite_glyph_string_foreground):
457 * term.c (encode_terminal_code):
458 * composite.c (composition_update_it, get_composition_id):
459 * xdisp.c (get_next_display_element)
460 (fill_composite_glyph_string): Add comments about special meaning
461 of TAB characters in a composition.
462
a02719a3
PE
4632011-09-15 Paul Eggert <eggert@cs.ucla.edu>
464
465 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
466 This occurs when processing a multibyte format.
467 Problem reported by Wolfgang Jenker.
a02719a3 468
72589a3c
JB
4692011-09-15 Johan Bockgård <bojohan@gnu.org>
470
471 * xdisp.c (try_cursor_movement): Only check for exact match if
472 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
473
1c14176c
PE
4742011-09-14 Paul Eggert <eggert@cs.ucla.edu>
475
476 Remove unused external symbols.
477 * dispextern.h (calc_pixel_width_or_height): Remove decl.
478 * xdisp.c (calc_pixel_width_or_height): Now static.
479 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
480 * indent.c (check_display_width):
481 * w32term.c: Fix comment to match code.
482 * xterm.c, xterm.h (x_catching_errors): Remove.
483
d2eea5b5
PE
4842011-09-14 Paul Eggert <eggert@cs.ucla.edu>
485
486 * xselect.c: Use signed conversions more consistently (Bug#9498).
487 (selection_data_to_lisp_data): Assume incoming selection data are
488 signed integers, not unsigned. This is to be consistent with
489 outgoing selection data, which was modified to use signed integers
490 in as part of the fix to Bug#9196 in response to Jan D.'s comment
491 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
492 expects long, not unsigned long.
493
46888499
EZ
4942011-09-14 Eli Zaretskii <eliz@gnu.org>
495
496 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
497 computation of loop end. Reported by Johan Bockgård
498 <bojohan@gnu.org>.
499
ef8ef9fb
CY
5002011-09-13 Chong Yidong <cyd@stupidchicken.com>
501
502 * frame.c (Fother_visible_frames_p): Function deleted.
503
fa819fed
EZ
5042011-09-12 Eli Zaretskii <eliz@gnu.org>
505
506 * indent.c (compute_motion): Process display vector front to back
507 rather than the other way around. (Bug#2496)
508
2ba8e008
SM
5092011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
510
511 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
512
20f53c69
CY
5132011-09-11 Chong Yidong <cyd@stupidchicken.com>
514
515 * minibuf.c (Fread_from_minibuffer): Doc fix.
516
d562d7a4
EZ
5172011-09-11 Eli Zaretskii <eliz@gnu.org>
518
519 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
520 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
521
1c4d7f3d
LMI
5222011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
523
524 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
525 value for non-existent files.
526
b885bf36
EZ
5272011-09-11 Eli Zaretskii <eliz@gnu.org>
528
529 * fileio.c (Finsert_file_contents): If the file cannot be opened,
530 set its "size" to -1. This will set the modtime_size field of
531 the corresponding buffer to -1, which is what
532 verify-visited-file-modtime expects for files that do not exist.
533 (Bug#9139)
534
6612f0bf
PE
5352011-09-11 Paul Eggert <eggert@cs.ucla.edu>
536
537 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
538 here ...
539 * lisp.h: ... from here. push_key_description is no longer
540 defined in keyboard.c, so its declaration should not be in
541 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
542 logically belongs with push_key_description.
543
dfb3f755
PE
5442011-09-10 Paul Eggert <eggert@cs.ucla.edu>
545
546 * buffer.h: Include <sys/types.h> instead of <time.h>.
547 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
548 Problem reported by Herbert J. Skuhra.
549
3134906c
LMI
5502011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
551
552 * xml.c (parse_region): Make the parsing work for
553 non-comment-starting XML files again (bug#9144).
554
8d903f4e
AS
5552011-09-10 Andreas Schwab <schwab@linux-m68k.org>
556
557 * image.c (gif_load): Fix calculation of bottom and right corner.
558 (Bug#9468)
559
80ad64f4
EZ
5602011-09-10 Eli Zaretskii <eliz@gnu.org>
561
562 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
563 redisplay in small windows.
564
208a048d
EZ
5652011-09-09 Eli Zaretskii <eliz@gnu.org>
566
567 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
568
9b1c252e
MR
5692011-09-08 Martin Rudalics <rudalics@gmx.at>
570
571 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
572 Operate on live windows only.
573
2949f33b
JB
5742011-09-08 Juanma Barranquero <lekktu@gmail.com>
575
576 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
577
e08dcafd
EZ
5782011-09-07 Eli Zaretskii <eliz@gnu.org>
579
580 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
581 only under bidi iteration.
582
115b96bd
JD
5832011-09-07 Jan Djärv <jan.h.d@swipnet.se>
584
585 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
586
c8199d0f
PE
5872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
588
589 isnan: Fix porting problem to Solaris 10 with bundled gcc.
590 Without this fix, the command to link temacs failed due to an
591 undefined symbol __builtin_isnan. This is because
592 /usr/include/iso/math_c99.h #defines isnan(x) to
593 __builtin_isnan(x), but the bundled gcc, which identifies itself
594 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
595 a __builtin_isnan.
596 * floatfns.c (isnan): #undef, and then #define to a clone of
597 what's in data.c.
598 (Fisnan): Always define, since it's always available now.
599 (syms_of_floatfns): Always define isnan at the Lisp level.
600
e39b275c 6012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
602
603 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
604
b2db44d9 6052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 606
f4af5137 607 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
608 The previous code assumed that file offsets (off_t values) fit in
609 EMACS_INT variables, which is not true on typical 32-bit hosts.
610 The code messed up by falsely reporting buffer overflow in cases
611 such as (insert-file-contents "big" nil 1 2) into an empty buffer
612 when "big" contains more than 2**29 bytes, even though this
613 inserts just one byte and does not overflow the buffer.
614 (Finsert_file_contents): Store file offsets as off_t
615 values, not as EMACS_INT values. Check for overflow when
616 converting between EMACS_INT and off_t. When checking for
617 buffer overflow or for overlap, take the offsets into account.
618 Don't use EMACS_INT for small values where int suffices.
619 When checking for overlap, fix a typo: ZV was used where
620 ZV_BYTE was intended.
621 (Fwrite_region): Don't assume off_t fits into 'long'.
622 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
623
ecfc0a49
MA
6242011-09-05 Michael Albinus <michael.albinus@gmx.de>
625
626 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
627
6511acf2 6282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 629
0999621a 630 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
631
632 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 633 (esprintf, exprintf, evxprintf): New functions.
62f19c19 634 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 635 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
636 (modify_event_symbol): Do not assume that the length of
637 name_alist_or_stem is safe to alloca and fits in int.
638 (Fexecute_extended_command): Likewise for function name and binding.
639 (Frecursion_depth): Wrap around reliably on integer overflow.
640 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
641 since some callers pass EMACS_INT values.
642 (Fsingle_key_description): Don't crash if symbol name contains more
643 than MAX_ALLOCA bytes.
644 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
645 (get_minibuffer): Arg is now EMACS_INT, not int.
646 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 647 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
648 * window.h (command_loop_level, minibuf_level): Reflect API changes.
649
2be7d702
PE
650 * dbusbind.c (signature_cat): New function.
651 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
652 Do not overrun buffer; instead, report string overflow.
653
9d1df220
PE
654 * dispnew.c (add_window_display_history): Don't overrun buffer.
655 Truncate instead; this is OK since it's just a log.
656
33ef5c64
PE
657 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
658 even if the time zone offset is outlandishly large.
659 Don't mishandle offset == INT_MIN.
660
66c6fdd5
PE
661 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
662 when creating daemon; the previous buffer-overflow check was incorrect.
663
d749b01b
PE
664 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
665 which has the guts of the old verror function.
666
b5cd1905
PE
667 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
668 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
669
6e1a67fb
PE
670 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
671 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 672 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 673 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
674 length of string rather than counting it via multiple sprintfs;
675 that's simpler and more reliable.
c21721cc
PE
676 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
677 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
678 sprintf, in case result does not fit in int.
679
c57b67fc
PE
680 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
681 (fontset_from_font): Print it.
682
8a401434
PE
683 * frame.c (tty_frame_count): Now printmax_t, not int.
684 (make_terminal_frame, set_term_frame_name): Print it.
685 (x_report_frame_params): In X, window IDs are unsigned long,
686 not signed long, so print them as unsigned.
687 (validate_x_resource_name): Check for implausibly long names,
688 and don't assume name length fits in 'int'.
689 (x_get_resource_string): Don't blindly alloca invocation name;
690 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
691 not fit in int.
692
6e1a67fb
PE
693 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
694 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
695 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
696
0df02bf3
PE
697 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
698 Use esprintf, not sprintf, in case result does not fit in int.
699
48e30793
PE
700 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
701 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
702 it as a large positive number.
703 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
704 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
705
a66ff6d8
PE
706 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
707 in case result does not fit in int.
708
aca216ff
PE
709 * print.c (float_to_string): Detect width overflow more reliably.
710 (print_object): Make sprintf buffer a bit bigger, to avoid potential
711 buffer overrun. Don't assume list length fits in 'int'. Treat
712 print length of 0 as 0, not as infinity; to be consistent with other
713 uses of print length in this function. Don't overflow print length
714 index. Don't assume hash table size fits in 'long', or that
715 vectorlike size fits in 'unsigned long'.
716
31c286f7
PE
717 * process.c (make_process): Use printmax_t, not int, to format
718 process-name gensyms.
719
55e5faa1
PE
720 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
721
80f2e268
PE
722 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
723 to avoid potential buffer overrun.
724
670741ab
PE
725 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
726 if X resource line is longer than 512 bytes.
727
b7163a50
PE
728 * xfns.c (x_window): Make sprintf buffer a bit bigger
729 to avoid potential buffer overrun.
730
ae58ff1f
PE
731 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
732
c43c8a6a
PE
733 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
734
3f8236f4
PE
7352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
736
53e9fe90 737 Integer overflow fixes for scrolling, etc.
6511acf2
PE
738 Without these, Emacs silently mishandles large integers sometimes.
739 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
740 it were "C-u 1 M-x recenter" on a typical 64-bit host.
741
6511acf2
PE
742 * xdisp.c (try_window_id): Check Emacs fixnum range before
743 converting to 'int'.
806add1d 744
6511acf2 745 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
746 Check that an Emacs fixnum is in range before assigning it to 'int'.
747 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
748 values converted from Emacs fixnums.
749 (Frecenter): Don't wrap around a line count if it is out of 'int'
750 range; instead, treat it as an extreme value.
751 (Fset_window_configuration, compare_window_configurations):
752 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
753
6511acf2
PE
754 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
755 that can exceed INT_MAX. Check that EMACS_INT value is in range
756 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
757 (match_limit): Don't assume that a fixnum can fit in 'int'.
758
6511acf2 759 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
760 exceed INT_MAX.
761
6511acf2 762 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
763 (Fvertical_motion): Don't wrap around LINES values that don't fit
764 in 'int'. Instead, treat them as extreme values. This is good
765 enough for windows, which can't have more than INT_MAX lines anyway.
766
fcb901a7
LMI
7672011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
768
0f2f6b6d
LMI
769 * Require libxml/parser.h to avoid compilation warning.
770
fcb901a7
LMI
771 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
772
773 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
774 since this reportedly can destroy thread storage.
775
6e20a0d4
CY
7762011-08-30 Chong Yidong <cyd@stupidchicken.com>
777
778 * syntax.c (find_defun_start): Update all cache variables if
779 exiting early (Bug#9401).
780
148ae00e
EZ
7812011-08-30 Eli Zaretskii <eliz@gnu.org>
782
f6cfbd8f
EZ
783 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
784
148ae00e
EZ
785 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
786 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
787 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
788
789 * term.c (tty_append_glyph): New function.
790 (produce_stretch_glyph): Static function and its prototype deleted.
791
a66cfb1c
SM
792 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
793 Add prototypes.
148ae00e 794
c4a07a4c
PE
7952011-08-29 Paul Eggert <eggert@cs.ucla.edu>
796
797 * image.c (parse_image_spec): Check for nonnegative, not for positive,
798 when checking :margin (Bug#9390).
799 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 800 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
801 so that the name doesn't mislead. All uses changed.
802
6bc8cd65
JB
8032011-08-28 Johan Bockgård <bojohan@gnu.org>
804
805 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
806 set_tty_hooks.
807
dca4927e
EZ
8082011-08-27 Eli Zaretskii <eliz@gnu.org>
809
810 * xdisp.c (move_it_to): Don't bail out early when reaching
811 position beyond to_charpos, if we are scanning backwards.
812 (move_it_vertically_backward): When DY == 0, make sure we get to
813 the first character in the line after the newline.
814
f2cad773
PE
8152011-08-27 Paul Eggert <eggert@cs.ucla.edu>
816
817 * ccl.c: Improve and simplify overflow checking (Bug#9196).
818 (ccl_driver): Do not generate an out-of-range pointer.
819 (Fccl_execute_on_string): Remove unnecessary check for
820 integer overflow, noted by Stefan Monnier in
821 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
822 Remove a FIXME that didn't need fixing.
823 Simplify the newly-introduced buffer reallocation code.
824
0cae2cdb
JB
8252011-08-27 Juanma Barranquero <lekktu@gmail.com>
826
827 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
828
5fc295a4 8292011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 830
70c60eb2 831 Integer and memory overflow issues (Bug#9196).
726e0ab1 832
d31850da
PE
833 * doc.c (get_doc_string): Rework so that
834 get_doc_string_buffer_size is the actual buffer size, rather than
835 being 1 less than the actual buffer size; this makes xpalloc more
836 convenient.
837
a69fbedb
PE
838 * image.c (x_allocate_bitmap_record, cache_image):
839 * xselect.c (Fx_register_dnd_atom):
840 Simplify previous changes by using xpalloc.
841
fe5c5d37
PE
842 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
843 since either will do and ptrdiff_t is convenient with xpalloc.
844
0065d054
PE
845 * charset.c (charset_table_size)
846 (struct charset_sort_data.priority): Now ptrdiff_t.
847 (charset_compare): Don't overflow if priorities differ greatly.
848 (Fsort_charsets): Don't assume list length fits in int.
849 Check for size-calculation overflow when allocating sort data.
850 (syms_of_charset): Allocate an initial charset table that is
851 just under 64 KiB, to avoid problems with glibc malloc and mmap.
852
853 * cmds.c (internal_self_insert): Check for size-calculation overflow.
854
855 * composite.h (struct composition.glyph_len): Now int, not unsigned.
856 The actual value is always <= INT_MAX, and leaving it unsigned made
857 overflow checking harder.
858
859 * dispextern.h (struct glyph_matrix.rows_allocated)
860 (struct face_cache.size): Now ptrdiff_t, for convenience in use
861 with xpalloc. The values are still always <= INT_MAX.
862
863 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
864
865 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
866 (SAFE_NALLOCA): New macro.
867
868 * region-cache.c (struct boundary.pos, find_cache_boundary)
869 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
870 (set_cache_region, invalidate_region_cache)
871 (revalidate_region_cache, know_region_cache, region_cache_forward)
872 (region_cache_backward, pp_cache):
873 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
874 so that ptrdiff_t * can be passed to xpalloc.
875 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
876 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
877 (pp_cache): Don't assume cache_len fits in int.
878 * region-cache.h: Adjust extern decls to match.
879
880 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
881 EMACS_INT, since either will do, for xpalloc.
882
883 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
884 (xnmalloc, xnrealloc, xpalloc): New functions.
885
726e0ab1
PE
886 * bidi.c (bidi_shelve_header_size): New constant.
887 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
888 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
889
51f30bc5 890 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
891 * buffer.c (overlays_at, overlays_in, record_overlay_string)
892 (overlay_strings):
893 Don't update size of array until after memory allocation succeeds,
894 because xmalloc/xrealloc may not return.
0065d054
PE
895 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
896 now that we have proper integer overflow checking.
897 (record_overlay_string, overlay_strings): Catch overflows when
898 calculating size of overlay_str_buf.
726e0ab1 899
0065d054
PE
900 * callproc.c (Fcall_process): Check for size overflow when
901 calculating size of args2.
902 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
903 Normally we prefer signed values, but sticking with ptrdiff_t would
904 require adding more-complicated checks.
726e0ab1
PE
905
906 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
907 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
908 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 909 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
910
911 * character.c (Fstring): Check for size-calculation overflow.
912
913 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
914 unnecessary integer overflow. Check for size overflow.
915 (encode_coding_object): Don't update size until xmalloc succeeds.
916
917 * composite.c (get_composition_id): Check for overflow in glyph
918 length calculations.
919
920 Integer and memory overflow fixes for display code.
921 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
922 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
923 (scrolling_window): Check for overflow in size calculations.
924 (line_draw_cost, realloc_glyph_pool, add_row_entry):
925 Don't assume glyph table len fits in int.
926 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
927 (row_table_size): Now ptrdiff_t, not int.
928 (scrolling_window): Avoid overflow in size calculations.
929 Don't update size until allocation succeeds.
930 * fns.c (concat): Check for overflow in size calculations.
931 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
932 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
933 (NEXT_ALMOST_PRIME_LIMIT): New constant.
934
935 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
936 (get_doc_string): Check for size calculation overflow.
937 Don't update size until allocation succeeds.
938 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
939 EMACS_INT, where ptrdiff_t will do.
940 (Fsubstitute_command_keys): Check for string overflow.
941
942 * editfns.c (set_time_zone_rule): Don't assume environment length
943 fits in int.
944 (message_length): Now ptrdiff_t, not int.
945 (Fmessage_box): Don't update size until allocation succeeds.
946 Don't assume message length fits in int.
947 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
948
0065d054
PE
949 * emacs.c (main): Do not reallocate argv, since there is a null at
950 the end that can be overwritten, and this way there's no need to
951 worry about size-calculation overflow.
952 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
953
954 * eval.c (init_eval_once, grow_specpdl): Don't update size until
955 alloc succeeds.
956 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
957
958 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
959 (x_set_scroll_bar_width, x_figure_window_size):
960 Check for integer overflow.
961 (x_set_alpha): Do not assume XINT fits in int.
962
963 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
964 This is for the members text_lines, text_cols, total_lines, total_cols,
965 where the system imposes an 'int' limit.
966
967 * fringe.c (Fdefine_fringe_bitmap):
968 Don't update size until alloc works.
969
970 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
971 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
972
973 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
974 Check for size-calculation overflow.
975 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
976 do, as we prefer signed integers.
977 (id_to_widget.max_size, id_to_widget.used)
978 (xg_store_widget_in_map, xg_remove_widget_from_map)
979 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
980 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
981 Use and return ptrdiff_t, not int.
982 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
983 * gtkutil.h: Change prototypes to match the above.
984
985 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
986 are duplicate now that they've been promoted to lisp.h.
987 (x_allocate_bitmap_record, x_alloc_image_color)
988 (make_image_cache, cache_image, xpm_load):
989 Don't update size until alloc is done.
990 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
991 (x_detect_edges):
3256efce 992 Check for size calculation overflow.
726e0ab1
PE
993 (ct_colors_allocated_max): New constant.
994 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
995 overflow.
3256efce 996
726e0ab1
PE
997 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
998 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
999 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1000 Use ptrdiff_t, not int, to count maps.
1001 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1002 calculations. Don't update size until allocation succeeds.
1003 Redo calculations to avoid overflow.
726e0ab1
PE
1004 * keyboard.h: Change prototypes to match the above.
1005
1006 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1007 to count maps.
1008 (current_minor_maps): Check for size calculation overflow.
1009 * keymap.h: Change prototypes to match the above.
1010
1011 * lread.c (read1, init_obarray): Don't update size until alloc done.
1012
1013 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1014 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1015
726e0ab1
PE
1016 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1017 Now ptrdiff_t, not int.
1018 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1019 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1020
1021 * process.c (Fnetwork_interface_list): Check for overflow
1022 in size calculation.
1023
1024 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1025
1026 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1027 overflow. Don't bother calling xmalloc when xrealloc will do.
1028
1029 * search.c (Freplace_match): Check for size calculation overflow.
1030 (Fset_match_data): Don't assume list lengths fit in 'int'.
1031
1032 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1033 for command line length. Do not attempt to address one before the
1034 beginning of an array, as that's not portable.
1035
1036 * term.c (max_frame_lines): Remove; unused.
1037 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1038 not int.
1039 (encode_terminal_code, calculate_costs): Check for size
1040 calculation overflow.
1041 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1042 table lengths and related sizes. Don't update size until alloc
1043 done. Redo calculations to avoid overflow.
1044 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1045
1046 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1047 subtracting pointers.
1048 (gobble_line): Check for overflow more carefully. Don't update size
1049 until alloc done.
1050
1051 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1052 Don't update size until alloc done.
1053 Redo size calculations to avoid overflow.
1054 Check for size calculation overflow.
0065d054 1055 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1056
1057 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1058 Use ptrdiff_t, not int, for sizes.
1059 (store_mode_line_noprop_char): Don't update size until alloc done.
1060
0065d054
PE
1061 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1062 Use ptrdiff_t, not int, for sizes.
1063 (Finternal_make_lisp_face, cache_face):
1064 Check for size calculation overflow.
1065 (cache_face): Treat size calculation overflows as if they were
1066 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1067
1068 * xfns.c (x_encode_text, x_set_name_internal)
1069 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1070 sizes, since they can exceed INT_MAX in size. Check for size
1071 calculation overflow.
1072
0065d054
PE
1073 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1074 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1075 Don't update size until alloc done.
1076
0065d054 1077 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1078 as sprintf is limited to int lengths.
1d526e2f 1079
252c5ee1
PE
1080 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1081 (X_LONG_MIN): New macros.
864d7ce7
PE
1082 Use them to make the following changes clearer.
1083 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1084 This change doesn't affect the value now, but it may help remind
1085 future maintainers not to raise the value too much later.
1086 (SELECTION_QUANTUM): Remove, replacing with ...
1087 (selection_quantum): ... new function, which avoids overflow.
1088 All uses changed.
1089 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1090 assumption that selection length fits in 'int'.
1091 (x_reply_selection_request, x_handle_selection_request)
1092 (x_get_window_property, receive_incremental_selection)
1093 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1094 (lisp_data_to_selection_data, clean_local_selection_data):
1095 Use ptrdiff_t, not int, to record length of selection.
1096 (x_reply_selection_request, x_get_window_property)
1097 (receive_incremental_selection, x_property_data_to_lisp):
1098 Redo calculations to avoid overflow.
1099 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1100 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1101 something.
1102 (x_get_window_property, receive_incremental_selection)
1103 (lisp_data_to_selection_data, x_property_data_to_lisp):
1104 Check for size-calculation overflow.
1105 (x_get_window_property, receive_incremental_selection)
1106 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1107 Don't store size until memory allocation succeeds.
1108 (x_get_window_property): Plug memory leak on memory exhaustion.
1109 Don't double-block input; malloc is safe here. Don't assume 2**34
1110 - 4 fits in unsigned long. Add an xassert to check
1111 XGetWindowProperty overflow. Be more careful about overflow
1112 calculations, and distinguish size from memory overflow better.
1113 (receive_incremental_selection): When tracing, don't assume
1114 unsigned int is less than INT_MAX.
1115 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1116 harmful) conversions of unsigned short to int.
1117 (lisp_data_to_selection_data): Don't assume that integers
1118 in the range -65535 through -1 fit in an X unsigned short.
1119 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1120 result parameters unless successful. Rely on cons_to_unsigned
1121 to report problems with elements; the old code wasn't right anyway.
1122 (x_check_property_data): Check for int overflow; we cannot use
1123 a wider type due to X limits.
1124 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1125
726e0ab1 1126 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1127
0065d054
PE
1128 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1129 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1130 (x_color_cells): Don't store size until memory allocation succeeds.
1131 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1132 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1133 (x_term_init): Don't assume length fits in int (sprintf is limited
1134 to int size).
bc18e09d 1135
ebfa62c0
PE
1136 Use ptrdiff_t for composition IDs.
1137 * character.c (lisp_string_width):
1138 * composite.c (composition_table_size, n_compositions)
1139 (get_composition_id, composition_gstring_from_id):
1140 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1141 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1142 * window.c (Frecenter):
1143 Use ptrdiff_t, not int, for composition IDs.
1144 * composite.c (get_composition_id): Check for integer overflow.
1145 * composite.h: Adjust prototypes to match the above changes.
1146
d3411f89
PE
1147 Use ptrdiff_t for hash table indexes.
1148 * category.c (hash_get_category_set):
1149 * ccl.c (ccl_driver):
1150 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1151 * coding.c (coding_system_charset_list, detect_coding_system):
1152 * coding.h (struct coding_system.id):
1153 * composite.c (get_composition_id, gstring_lookup_cache):
1154 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1155 * image.c (xpm_get_color_table_h):
1156 * lisp.h (hash_lookup, hash_put):
1157 * minibuf.c (Ftest_completion):
1158 Use ptrdiff_t for hash table indexes, not int (which is too
1159 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1160 32-bit --with-wide-int hosts).
1161
e097a6fa
PE
1162 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1163 Add a FIXME comment about memory leaks.
1164 (syms_of_charset): Don't assume xmalloc returns.
1165
5637687f
PE
1166 Don't assume that stated character widths fit in int.
1167 * character.c (Fchar_width, c_string_width, lisp_string_width):
1168 * character.h (CHAR_WIDTH):
1169 * indent.c (MULTIBYTE_BYTES_WIDTH):
1170 Use sanitize_char_width to avoid undefined and/or bad behavior
1171 with outlandish widths.
a66cfb1c 1172 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1173 now that we have two such functions. All uses changed.
1174 (sanitize_char_width): New inline function.
1175
a2271ba2
PE
1176 Don't assume that tab-width fits in int.
1177 * character.h (sanitize_width): New inline function.
1178 (SANE_TAB_WIDTH): New macro.
1179 (ASCII_CHAR_WIDTH): Use it.
1180 * indent.c (sane_tab_width): Remove. All uses replaced by
1181 SANE_TAB_WIDTH (current_buffer).
1182 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1183
18c52557
PE
1184 * fileio.c: Integer overflow issues with file modes.
1185 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1186
caeeedc1
PE
1187 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1188 Remove unreachable code.
1189 (read_hex, load_charset_map_from_file): Check for integer overflow.
1190
50849c52
PE
1191 * xterm.c: don't go over XClientMessageEvent limit
1192 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1193 (x_send_scroll_bar_event): Likewise. Check that the size does not
1194 exceed limits imposed by XClientMessageEvent, as well as the usual
1195 ptrdiff_t and size_t limits.
1196
b13995db
PE
1197 * keyboard.c: Overflow, signedness and related fixes.
1198 (make_lispy_movement): Use same integer type in forward decl
1199 that is used in the definition.
1200 (read_key_sequence, keyremap_step):
1201 Change bufsize argument back to int, undoing my 2011-03-30 change.
1202 We prefer signed types, and int is wide enough here.
1203 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1204 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1205 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1206 length, not size_t. Use ptrdiff_t for index, not int.
1207 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1208 possibility of integer overflow.
1209
13464394
PE
1210 Overflow, signedness and related fixes for images.
1211
1212 * dispextern.h (struct it.stack[0].u.image.image_id)
1213 (struct_it.image_id, struct image.id, struct image_cache.size)
1214 (struct image_cache.used, struct image_cache.ref_count):
1215 * gtkutil.c (update_frame_tool_bar):
1216 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1217 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1218 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1219 * nsmenu.m (update_frame_tool_bar):
1220 * xdisp.c (calc_pixel_width_or_height):
1221 * xfns.c (image_cache_refcount):
1222 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1223 on typical 64-bit hosts.
1224
1225 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1226 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1227 Omit unnecessary casts to int.
1228 (parse_image_spec): Check that integers fall into 'int' range
1229 when the callers expect that.
1230 (image_ascent): Redo ascent calculation to avoid int overflow.
1231 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1232 (lookup_image): Remove unnecessary tests.
1233 (xbm_image_p): Locals are now of int, not EMACS_INT,
1234 since parse_image_check makes sure they fit into int.
1235 (png_load, gif_load, svg_load_image):
1236 Prefer int to unsigned where either will do.
1237 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1238 old tiff_error_handler and tiff_warning_handler.
1239 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1240 stack buffer overflows. It uses only the features of vsnprintf
1241 that are common to both POSIX and native Microsoft.
1242 (tiff_error_handler, tiff_warning_handler): Use it.
1243 (tiff_load, gif_load, imagemagick_load_image):
1244 Don't assume :index value fits in 'int'.
1245 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1246 (imagemagick_load_image): Check that crop parameters fit into
1247 the integer types that MagickCropImage accepts. Don't assume
1248 Vimagemagick_render_type has a nonnegative value. Don't assume
1249 size_t fits in 'long'.
1250 (gs_load): Use printmax_t to print the widest integers possible.
1251 Check for integer overflow when computing image height and width.
1252
c11821d4
EZ
12532011-08-26 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (redisplay_window): Don't force window start if point
1256 will be invisible in the resulting window. (Bug#9324)
1257
0c95fcf7
EZ
12582011-08-25 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1261 the display spec is of the form `(space ...)'.
1262 (handle_display_spec): Return the value returned by
1263 handle_single_display_spec, not just 1 or zero.
1264 (handle_single_display_spec): If the display spec is of the form
1265 `(space ...)', and specifies display in the text area, return 2
1266 rather than 1.
fee65a97 1267 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1268 accurately, and prefer exact match for point under bidi.
1269 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1270
1271 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1272 into disp_prop; all users changed.
1273
1274 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1275 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1276 for the text covered by the display property.
1277
e4ed06f1
CY
12782011-08-25 Chong Yidong <cyd@stupidchicken.com>
1279
1280 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1281 Change return value to nil.
1282 (Frecord_buffer): Delete unused function.
1283
f67cdd7f
EZ
12842011-08-24 Eli Zaretskii <eliz@gnu.org>
1285
5980d4c6
EZ
1286 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1287 buffers, return left-to-right.
8610fe8b
EZ
1288 (set_cursor_from_row): Consider candidate row a win if its glyph
1289 represents a newline and point is on that newline. Fixes cursor
1290 positioning on the newline at EOL of R2L text within L2R
1291 paragraph, and vice versa.
1292 (try_cursor_movement): Check continued rows, in addition to
1293 continuation rows. Fixes unwarranted scroll when point enters a
1294 continued line of R2L text within an L2R paragraph, or vice versa.
1295 (cursor_row_p): Consider the case of point being equal to
1296 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1297 from the end of a short line to the beginning of a continued line
1298 of R2L text within L2R paragraph.
1299 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1300 composed characters.
5980d4c6 1301
f67cdd7f
EZ
1302 * bidi.c (bidi_check_type): Use xassert.
1303 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1304 members.
1305
bca633fb
EZ
13062011-08-23 Eli Zaretskii <eliz@gnu.org>
1307
1308 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1309 a character.
1310
4a5885a7
CY
13112011-08-23 Chong Yidong <cyd@stupidchicken.com>
1312
1313 * nsfont.m (ns_otf_to_script): Fix typo.
1314
0902a04e
KH
13152011-08-22 Kenichi Handa <handa@m17n.org>
1316
1317 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1318 extra slot even if the purpose is char-code-property-table.
1319
1a2e6670
EZ
13202011-08-23 Eli Zaretskii <eliz@gnu.org>
1321
8ddde651
EZ
1322 * xdisp.c (redisplay_window): When computing centering_position,
1323 account for the height of the header line. (Bug#8874)
1324
425cc014
EZ
1325 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1326 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1327 candidate is selected by the mouse, and that candidate has a
1328 composed character under the mouse.
1329
1a2e6670
EZ
1330 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1331 coordinates reported by pos-visible-in-window-p for a composed
1332 character in column zero.
1333
8b76d6f8
SM
13342011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1335
1336 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1337
dac347dd
EZ
13382011-08-22 Eli Zaretskii <eliz@gnu.org>
1339
1340 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1341 consider it a hit if to_charpos is anywhere in the range of the
1342 composed buffer positions.
1343
e013fb34
CY
13442011-08-22 Chong Yidong <cyd@stupidchicken.com>
1345
1346 * image.c (gif_load): Don't assume that each subimage has the same
1347 dimensions as the base image. Handle disposal method that is
1348 "undefined" by the gif spec (Bug#9335).
1349
bd1ba3e8
CY
13502011-08-20 Chong Yidong <cyd@stupidchicken.com>
1351
1352 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1353 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1354
54a1215b
EZ
13552011-08-19 Eli Zaretskii <eliz@gnu.org>
1356
823564e5
EZ
1357 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1358 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1359 from an Org mode buffer to a Speedbar frame.
1360
54a1215b
EZ
1361 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1362 a composition, take its buffer position from IT->cmp_it.charpos.
1363 Fixes cursor positioning at the beginning of a line that begins
1364 with a composed character.
1365
9778ebcc
EZ
13662011-08-18 Eli Zaretskii <eliz@gnu.org>
1367
0be6ee06
EZ
1368 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1369 character bidirectional type, use STRONG_L instead. Fixes crashes
1370 in a buffer produced by `describe-categories'.
1371
9778ebcc
EZ
1372 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1373 members before the level stack, so they would be saved and
1374 restored when copying iterator state. Fixes incorrect reordering
1375 around TABs covered by display properties.
1376
156bffbe
AS
13772011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1378
6b02f655 1379 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1380
72ad093b
CY
13812011-08-17 Chong Yidong <cyd@stupidchicken.com>
1382
1383 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1384 (internal_condition_case_2, internal_condition_case_n):
1385 Remove unnecessary aborts (Bug#9081).
72ad093b 1386
35774242
EZ
13872011-08-17 Eli Zaretskii <eliz@gnu.org>
1388
1389 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1390 has no `load' handler, try opening the file locally. (Bug#9311)
1391
db76dd85
KB
13922011-08-16 Ken Brown <kbrown@cornell.edu>
1393
1394 * gmalloc.c: Expand comment.
1395
b215eee5
EZ
13962011-08-16 Eli Zaretskii <eliz@gnu.org>
1397
1398 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1399 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1400
a4579d33
KB
14012011-08-16 Ken Brown <kbrown@cornell.edu>
1402
1403 Fix memory allocation problems in Cygwin build (Bug#9273).
1404
1405 * unexcw.c ( __malloc_initialized): Declare external variable.
1406 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1407
8b76d6f8
SM
1408 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1409 New variables.
a4579d33
KB
1410 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1411 dumped emacs.
1412 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1413 in the static heap.
1414 [CYGWIN] (special_realloc): New function.
1415 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1416 requests to realloc storage in the static heap.
1417
3ebec551
PE
14182011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 * bidi.c (bidi_initialize): Remove unused local.
1421
9fd8be00
EZ
14222011-08-15 Eli Zaretskii <eliz@gnu.org>
1423
6b02f655
SM
1424 * bidimirror.h:
1425 * biditype.h: Remove file.
1426 * makefile.w32-in ($(BLD)/bidi.$(O)):
1427 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1428
1429 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1430
1431 * chartab.c: Improve commentary for the uniprop_table API.
1432
32413314
EZ
1433 * bidi.c (bidi_paragraph_init): Support zero value of
1434 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1435 (bidi_initialize): Use uniprop_table instead of including
1436 biditype.h and bidimirror.h.
32413314 1437
9fd8be00
EZ
1438 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1439 coordinates of the iterator when restoring from ppos_it.
1440 (Bug#9296)
1441
5cf2b69b
KH
14422011-08-14 Kenichi Handa <handa@m17n.org>
1443
1444 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1445 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1446
daf17d00
EZ
14472011-08-14 Eli Zaretskii <eliz@gnu.org>
1448
1449 * xdisp.c (move_it_in_display_line_to): Don't invoke
1450 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1451 ppos_it. Fixes vertical cursor motion when line beginning is
1452 covered by an image. (Bug#9296)
1453
08e3161a
JD
14542011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1455
1456 * nsterm.h (ns_run_ascript): Declare.
1457 (NSAPP_DATA2_RUNASSCRIPT): Define.
1458
1459 * nsfns.m (as_script, as_result, as_status): New static variables.
1460 (ns_run_ascript): New function.
5e617bc2 1461 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1462 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1463 the event loop. Get status from as_status (Bug#7276).
1464
1465 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1466 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1467 the event loop (Bug#7276).
1468
a3720aa2
AS
14692011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1470
1471 * gnutls.c (QCgnutls_bootprop_priority)
1472 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1473 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1474 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1475 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1476 (QCgnutls_bootprop_verify_hostname_error)
1477 (QCgnutls_bootprop_callbacks_verify): Rename from
1478 Qgnutls_bootprop_..., all uses changed.
1479
1480 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1481 uses changed.
1482
0a0d27fb
PE
14832011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1484
19d5c50c
PE
1485 * xfaces.c (Qframe_set_background_mode): Now static.
1486 * dispextern.h (Qframe_set_background_mode): Remove decl.
1487
0a0d27fb
PE
1488 * process.c (Fnetwork_interface_info): Declare local only if needed.
1489
377538cb
JD
14902011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1491
1492 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1493 (Fnetwork_interface_list): Allocate in increments of bytes instead
1494 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1495 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1496 sockaddr.
1497 (struct ifflag_def): notrailers is smart on OSX.
1498 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1499 Get hardware address with getifaddrs if available.
1500
08fff70c
EZ
15012011-08-12 Eli Zaretskii <eliz@gnu.org>
1502
1503 * xdisp.c (iterate_out_of_display_property): xassert that
1504 IT->position is set to within IT->object's boundaries. Break from
1505 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1506 when IT->position is set up wrongly due to some bug.
1507 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1508 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1509 entry. Force push_it to save on the stack the current
1510 buffer/string position, to be restored by pop_it. Fix flags in
1511 the iterator structure wrt the object coming from a display
1512 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1513 properties. (Bug#9284)
1514
7be1c708 15152011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1516
7be1c708
CY
1517 * fontset.c (fontset_get_font_group): Add proper type checks.
1518 (Bug#9172)
aac0c6e3 1519
7be1c708 15202011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1521
7be1c708
CY
1522 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1523 and LC_VERSION_MIN_MACOSX.
1524 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1525 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1526
97bb72a6
EZ
15272011-08-08 Eli Zaretskii <eliz@gnu.org>
1528
1529 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1530 no-display-properties-and-no-overlays under bidi display.
1531 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1532 properties and overlays.
97bb72a6 1533
d5617611
CY
15342011-08-08 Chong Yidong <cyd@stupidchicken.com>
1535
37e11a63
CY
1536 * editfns.c (Fset_time_zone_rule): Document relationship with the
1537 setenv function.
1538
d5617611
CY
1539 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1540 the font entity extracted from the cache (Bug#8109).
1541
58872834
CY
15422011-08-07 Chong Yidong <cyd@stupidchicken.com>
1543
1544 * composite.c (autocmp_chars): Don't reset point. That is done by
1545 restore_point_unwind (Bug#5984).
1546
75bfc667
JL
15472011-08-07 Juri Linkov <juri@jurta.org>
1548
1549 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1550 to show the arg `TIME' instead of `TIMEVAL'.
1551
d1410150
EZ
15522011-08-06 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1555 display property strides EOL and includes a newline, as in
1556 longlines-mode. (Bug#9254)
75b771e4
EZ
1557 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1558 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1559
1560 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1561 is non-zero, even if the data buffer is NULL. Fixes a crash in
1562 vertical-motion with longlines-mode. (Bug#9254)
1563
35928349
EZ
15642011-08-05 Eli Zaretskii <eliz@gnu.org>
1565
ec7cc85b
EZ
1566 * bidi.c <bidi_cache_total_alloc>: Now static.
1567 (bidi_initialize): Initialize bidi_cache_total_alloc.
1568
8b76d6f8 1569 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1570 cache. (Bug#9221)
1571
1572 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1573 amount allocated this far in `bidi_cache_total_alloc'.
1574 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1575 non-zero, only free the data buffer without restoring the cache
1576 contents. All callers changed.
1577
1578 * dispextern.h (bidi_unshelve_cache): Update prototype.
1579
1580 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1581 (move_it_in_display_line, move_it_to)
1582 (move_it_vertically_backward, move_it_by_lines): Replace the call
1583 to xfree to an equivalent call to bidi_unshelve_cache.
1584 (move_it_in_display_line_to): Fix logic of returning
412b6358 1585 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1586
e2e2423b
EZ
15872011-08-05 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1590 came from a string character with a `cursor' property. (Bug#9229)
1591
ae9e757a
JD
15922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1593
1594 * Makefile.in (LIB_PTHREAD): New variable.
1595 (LIBES): Add LIB_PTHREAD (Bug#9216).
1596
1597 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1598 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1599
213bd7f2
AS
16002011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1601
6b02f655 1602 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1603
99aaf75f
JD
16042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1605
1606 * xterm.c (x_find_topmost_parent): New function.
1607 (x_set_frame_alpha): Find topmost parent window with
1608 x_find_topmost_parent and set the property there also (bug#9181).
1609 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1610
c74e9d86
PE
16112011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1612
1613 * callproc.c (Fcall_process): Avoid vfork clobbering
1614 the local vars buffer, coding_systems, current_dir.
1615
640c8776
SM
16162011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1617
1618 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1619
f26d0e4c
PE
16202011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1621
8a10d76c
PE
1622 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1623 so that it is not optimized away.
1624
f26d0e4c
PE
1625 * xdisp.c (compute_display_string_pos): Remove unused local.
1626
55439c61
EZ
16272011-08-02 Eli Zaretskii <eliz@gnu.org>
1628
1629 Fix slow cursor motion and scrolling in large buffers with
1630 selective display, like Org Mode buffers. (Bug#9218)
1631
1632 * dispextern.h (struct bidi_it): New member disp_prop_p.
1633
1634 * xdisp.c: Remove one-slot cache of display string positions.
1635 (compute_display_string_pos): Accept an additional argument
5e617bc2 1636 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1637 for a display string or property. If found, set DISP_PROP_P
1638 non-zero.
1639
1640 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1641 DISP_PROP_P, and pass it to compute_display_string_pos.
1642 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1643 non-zero. All callers of bidi_fetch_char changed.
1644
fb33fa43
SM
16452011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1646
1647 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1648
b099e063
DM
16492010-12-03 Don March <don@ohspite.net>
1650
1651 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1652 last character M-[char] is translated to ESC [char] (bug#7541).
1653
5cc7f7af
KH
16542011-08-02 Kenichi Handa <handa@m17n.org>
1655
d0fffa3f 1656 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1657
1658 * chartab.c (uniprop_table): Make it non-static.
1659
525d5e6e
EZ
16602011-08-01 Eli Zaretskii <eliz@gnu.org>
1661
1662 * xdisp.c (forward_to_next_line_start): Accept additional argument
1663 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1664 on the newline.
1665 (reseat_at_next_visible_line_start): Use the bidi iterator state
1666 returned by forward_to_next_line_start to restore the state of
1667 it->bidi_it after backing up to previous newline. (Bug#9212)
1668
31011111
AS
16692011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1670
1671 * regex.c (re_comp): Protoize.
1672 (re_exec): Fix return type.
1673 (regexec): Fix type of `ret'. (Bug#9203)
1674
476371c4
PE
16752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1676
e5d76069
PE
1677 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1678 This is needed if max-image-size is a floating-point number.
1679
9a79b20c
AS
16802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1681
1682 * print.c (print_object): Print empty symbol as ##.
1683
1684 * lread.c (read1): Read ## as empty symbol.
1685
d8c2fa78
AA
16862011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1687
1688 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1689 setting frame foreground color (Bug#9175).
1690 (x_set_background_color): Likewise.
1691
ffe57a7a
AA
1692 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1693 contents (Bug#9176).
1694 (EmacsTooltip -init): Remove bezels and add shadows to
1695 tooltip windows.
1696
bf3492a5
AA
1697 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1698 or scroll bar (Bug#8470).
1699
d55e9c53
AA
1700 * nsfont.m (nsfont_open): Remove assignment to voffset and
1701 unnecessary vars hshink, expand, hd, full_height, min_height.
1702 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1703
1704 * nsterm.h (nsfont_info): Remove voffset field.
1705
d8c2fa78 17062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1707
1708 Implement strike-through and overline on NextStep (Bug#8863).
1709
1710 * nsfont.m (nsfont_open): Use underline position provided by font,
1711 instead of hard-coded value of 2.
1712 (nsfont_draw): Call ns_draw_text_decoration instead.
1713
1714 * nsterm.h: Add declaration for ns_draw_text_decoration.
1715
1716 * nsterm.m (ns_draw_text_decoration): New function for drawing
1717 underline, overline, and strike-through.
1718 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1719 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1720 accommodate underlining, etc.
4843aac3 1721
4cc60b9b
EZ
17222011-07-28 Eli Zaretskii <eliz@gnu.org>
1723
bc7ece87
EZ
1724 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1725 default.
4cc60b9b 1726
476371c4
PE
17272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1728
66606eea
PE
1729 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1730 Without this fix, if a signal arrives just after memory fills up,
1731 'malloc' might be invoked reentrantly.
1732
476371c4
PE
1733 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1734 In other words, assume that every image size is allowed, on non-X
1735 hosts. This assumption is probably wrong, but it lets Emacs compile.
1736
f3fcc40d
AS
17372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1738
1739 * regex.c (re_iswctype): Convert return values to boolean.
1740
350c992f
EZ
17412011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1742
1743 * xdisp.c (compute_display_string_pos): Don't use cached display
1744 string position if the buffer had its restriction changed.
1745 (Bug#9184)
1746
5266b4bb
PE
17472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1750
2573a837 17512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1752
41f55ccd 1753 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1754
39e378da
PE
1755 * bidi.c: Integer size and overflow fixes.
1756 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1757 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1758 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1759 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1760 (bidi_find_other_level_edge):
1761 Use ptrdiff_t instead of EMACS_INT where either will do.
1762 This works better on 32-bit hosts configured --with-wide-int.
1763 (bidi_cache_ensure_space): Check for size-calculation overflow.
1764 Use % rather than repeated addition, for better worst-case speed.
1765 Don't set bidi_cache_size until after xrealloc returns, because it
1766 might not return.
1767 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1768 (bidi_cache_ensure_space): Also check that the bidi cache size
1769 does not exceed that of the largest Lisp string or buffer. See Eli
1770 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1771
5e927815
PE
1772 * alloc.c (__malloc_size_t): Remove.
1773 All uses replaced by size_t. See Andreas Schwab's note
1774 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1775
ca4aa935
PE
1776 * image.c: Improve checking for integer overflow.
1777 (check_image_size): Assume that f is nonnull, since
1778 it is always nonnull in practice. This is one less thing to
1779 worry about when checking for integer overflow later.
1780 (x_check_image_size): New function, which checks for integer
1781 overflow issues inside X.
1782 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1783 This removes the need for a memory_full check.
1784 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1785 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1786 (xbm_read_bitmap_data): Change locals back to 'int', since
1787 their values must fit in 'int'.
1788 (xpm_load_image, png_load, tiff_load):
1789 Invoke x_create_x_image_and_pixmap earlier,
1790 to avoid much needless work if the image is too large.
1791 (tiff_load): Treat overly large images as if
1792 x_create_x_image_and_pixmap failed, not as malloc failures.
1793 (gs_load): Use x_check_image_size.
1794
5f8f9cc2
PE
1795 * gtkutil.c: Omit integer casts.
1796 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1797 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1798
5adf60bc
PE
1799 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1800
c8907a93
PE
1801 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1802 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1803 would wrongly return t on a 64-bit host.
1804
e3c25c68
PE
1805 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1806 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1807 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1808 and therefore cause GCC to emit a bogus diagnostic in some cases.
1809
3f791afe
PE
1810 * image.c: Integer signedness and overflow and related fixes.
1811 This is not an exhaustive set of fixes, but it's time to
1812 record what I've got.
1813 (lookup_pixel_color, check_image_size): Remove redundant decls.
1814 (check_image_size): Don't assume that arbitrary EMACS_INT values
1815 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1816 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1817 (tiff_load, imagemagick_load_image):
1818 Check for overflow in size calculations.
1819 (x_create_x_image_and_pixmap): Remove unnecessary test for
1820 xmalloc returning NULL; that can't happen.
1821 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1822 (xpm_color_bucket): Use better integer hashing function.
1823 (xpm_cache_color): Don't possibly over-allocate memory.
1824 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1825 (gif_memory_source):
1826 Use ptrdiff_t, not int or size_t, to record sizes.
1827 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1828 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1829 either works, as we prefer signed integers.
1830 (tiff_read_from_memory, tiff_write_from_memory):
1831 Return tsize_t, not size_t, since that's what the TIFF API wants.
1832 (tiff_read_from_memory): Don't fail simply because the read would
1833 go past EOF; instead, return a short read.
1834 (tiff_load): Omit no-longer-needed casts.
1835 (Fimagemagick_types): Don't assume size fits into 'int'.
1836
3cc5a532
PE
1837 Improve hashing quality when configured --with-wide-int.
1838 * fns.c (hash_string): New function, taken from sxhash_string.
1839 Do not discard information about ASCII character case; this
1840 discarding is no longer needed.
1841 (sxhash-string): Use it. Change sig to match it. Caller changed.
1842 * lisp.h: Declare it.
1843 * lread.c (hash_string): Remove, since we now use fns.c's version.
1844 The fns.c version returns a wider integer if --with-wide-int is
1845 specified, so this should help the quality of the hashing a bit.
1846
b312a492
PE
1847 * emacs.c: Integer overflow minor fix.
1848 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1849 Define only if GNU_LINUX.
1850 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1851
dfd153ae
PE
1852 * dispnew.c: Integer signedness and overflow fixes.
1853 Remove unnecessary forward decls, that were a maintenance hassle.
1854 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1855 All uses changed.
1856 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1857 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1858 (prepare_desired_row, line_draw_cost):
1859 Use int, not unsigned, where either works.
1860 (save_current_matrix, restore_current_matrix):
1861 Use ptrdiff_t, not size_t, where either works.
1862 (init_display): Check for overflow more accurately, and without
1863 relying on undefined behavior.
1864
a81d11a3
PE
1865 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1866 Remove, replacing with the new symbols in lisp.h. All uses changed.
1867 * fileio.c (make_temp_name):
1868 * filelock.c (lock_file_1, lock_file):
1869 * xdisp.c (message_dolog):
1870 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1871 Use pMd etc. instead.
1872 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1873 replacing the pWIDE etc. symbols removed from editfns.c.
1874
3300e6fd
PE
1875 * keyboard.h (num_input_events): Now uintmax_t.
1876 This is (very slightly) less likely to mess up due to wraparound.
1877 All uses changed.
1878
fd05c7e9
PE
1879 * buffer.c: Integer signedness fixes.
1880 (alloc_buffer_text, enlarge_buffer_text):
1881 Use ptrdiff_t rather than size_t when either will do, as we prefer
1882 signed integers.
1883
903fe15d
PE
1884 * alloc.c: Integer signedness and overflow fixes.
1885 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1886 (__malloc_size_t): Default to size_t, not to int.
1887 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1888 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1889 Prefer ptrdiff_t to size_t when either would do, as we prefer
1890 signed integers.
1891 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1892 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1893 Now const. Initialize with values that are in range even if char
1894 is signed.
1895 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1896 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1897 These functions do the right thing with sizes > 2**32.
1898 (check_depth): Now ptrdiff_t, not int.
1899 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1900 Adjust to new way of storing sizes. Check for size overflow bugs
1901 in rest of code.
1902 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1903 slightly wrong anyway, as it missed one instance of
1904 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1905 (refill_memory_reserve): Omit needless cast to size_t.
1906 (mark_object_loop_halt): Mark as externally visible.
1907
ac82cc6a
PE
1908 * xselect.c: Integer signedness and overflow fixes.
1909 (Fx_register_dnd_atom, x_handle_dnd_message):
1910 Use ptrdiff_t, not size_t, since we prefer signed.
1911 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1912 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1913 x_dnd_atoms_size and x_dnd_atoms_length.
1914
c2d1e36d
PE
1915 * doprnt.c: Prefer signed to unsigned when either works.
1916 * eval.c (verror):
1917 * doprnt.c (doprnt):
1918 * lisp.h (doprnt):
1919 * xdisp.c (vmessage):
1920 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1921 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1922 prefer signed arithmetic to avoid comparison confusion.
1923 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1924 but is a bit tricky.
1925
0e926e56
PE
1926 Assume freestanding C89 headers, string.h, stdlib.h.
1927 * data.c, doprnt.c, floatfns.c, print.c:
1928 Include float.h unconditionally.
1929 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1930 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1931 * regex.c: Likewise for stddef.h, string.h.
1932 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1933 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1934 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1935 (STDC_HEADERS): Remove obsolete defines.
1936 * sysdep.c: Include limits.h unconditionally.
1937
9cfdb3ec
PE
1938 Assume support for memcmp, memcpy, memmove, memset.
1939 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1940 * regex.c (memcmp, memcpy):
1941 Remove; we assume C89 now.
1942
1943 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1944 (__malloc_safe_bcopy): Remove; no longer needed.
1945
cf950e6b 1946 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1947 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1948 well either way, and we prefer signed to unsigned.
1949
dbf38e02
LMI
19502011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1951
1952 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1953 closes the connection while we're reading (bug#9182).
1954
d6f0886c 19552011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1956
d6f0886c
JD
1957 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1958 are specified (Bug#9168).
24e0f6b1 1959
2eb1f9e6
PE
19602011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1963 Found by GCC static checking and --with-wide-int on a 32-bit host.
1964
22381272 19652011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1966
1967 * xdisp.c (compute_display_string_pos): Fix logic of caching
1968 previous display string position. Initialize cached_prev_pos to
1969 -1. Fixes slow-down at the beginning of a buffer.
1970
f25e39b4
EZ
19712011-07-24 Eli Zaretskii <eliz@gnu.org>
1972
1973 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1974 for attrs[LFACE_FONTSET_INDEX].
1975
04c4b52e
PE
19762011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 * xml.c (parse_region): Remove unused local
1979 that was recently introduced.
1980
c1734fbd
EZ
19812011-07-23 Eli Zaretskii <eliz@gnu.org>
1982
be18c5a5
EZ
1983 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1984 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1985
c1734fbd
EZ
1986 * xdisp.c (move_it_in_display_line_to): Record the best matching
1987 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1988 exit if none of the characters scanned was an exact match.
1989 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1990 when exact match is impossible due to invisible text, and the
1991 lines are truncated.
1992
a258d627
JD
19932011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1994
1995 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1996 for OSX >= 10.7.
1997
b6d5a689
EZ
19982011-07-22 Eli Zaretskii <eliz@gnu.org>
1999
0f74f785
EZ
2000 Fix a significant slow-down of cursor motion with C-n, C-p,
2001 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2002 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2003 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2004 (next_element_from_buffer): Call compute_stop_pos_backwards to
2005 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2006 base_level_stop.
2007 (reseat): Don't look for prev_stop, as that could mean a very long
2008 run.
2009 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2010 <cached_disp_overlay_modiff>: Cache for last found display string
2011 position.
551918c1 2012 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2013 about the same buffer in the same area of character positions, and
2014 the buffer wasn't changed since the time the display string
2015 position was cached.
551918c1 2016
b2d0c91a
EZ
20172011-07-22 Eli Zaretskii <eliz@gnu.org>
2018
2019 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2020 is an integer, which is important for empty lines. (Bug#9149)
2021
043604ee
CY
20222011-07-22 Chong Yidong <cyd@stupidchicken.com>
2023
2024 * frame.c (Fmodify_frame_parameters): In tty case, update the
2025 default face if necessary (Bug#4238).
2026
da4adb04
CY
20272011-07-21 Chong Yidong <cyd@stupidchicken.com>
2028
2029 * editfns.c (Fstring_to_char): No need to explain what a character
2030 is in the docstring (Bug#6576).
2031
9abd0532
LMI
20322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2033
2034 * xml.c (parse_region): Make sure we always return a tree.
2035
36881d16
HK
20362011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2037
2038 * xml.c (parse_region): If a document contains only comments,
2039 return that, too.
2040
1e98674d
LMI
20412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2042
2043 * xml.c (make_dom): Return comments, too.
2044
590bd467
PE
20452011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2046
2047 Port to OpenBSD.
2048 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2049 and the surrounding thread.
2050 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2051 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2052 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2053 timer goes off.
2054 * s/openbsd.h (BROKEN_SIGIO): Define.
2055 * unexelf.c (unexec) [__OpenBSD__]:
2056 Don't update the .mdebug section of the Alpha COFF symbol table.
2057
f41628b2
LMI
20582011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2059
2060 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2061 (bug#8460).
2062
b59b67c5
PE
20632011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2064
15e3a074
PE
2065 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2066 This fixes some race conditions on the permissions of any newly
2067 created file.
2068
41bed37d
PE
2069 * alloc.c (valid_pointer_p): Use pipe, not open.
2070 This fixes some permissions issues when debugging.
2071
b59b67c5
PE
2072 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2073 If fchown fails to set both uid and gid, try to set just gid,
2074 as that is sometimes allowed. Adjust the file's mode to eliminate
2075 setuid or setgid bits that are inappropriate if fchown fails.
2076
925a6be7
SM
20772011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2078
2079 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2080 to compare Lisp_Objects.
2081 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2082 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2083 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2084
52968808
AS
20852011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2086
0a6a104b
AS
2087 * lread.c (read_integer): Unread even EOF character.
2088 (read1): Likewise. Properly record start position of symbol.
2089
52968808
AS
2090 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2091 symbol character follows.
2092
9e381cdd
PE
20932011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2094
2095 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2096 This works around a problem with the previous change to Fcopy_file.
2097 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2098 and without this change, GCC might complain about discarding
2099 fchown's return value.
2100
b5641435
JB
21012011-07-16 Juanma Barranquero <lekktu@gmail.com>
2102
2103 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2104
a8031457
PE
21052011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2108
dd889327
LMI
21092011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2110
750c33f7
LMI
2111 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2112 it's used from the C level.
2113
dd889327
LMI
2114 * process.c: Use the same condition for POLL_FOR_INPUT in both
2115 keyboard.c and process.c (bug#1858).
2116
87e86684
LM
21172011-07-09 Lawrence Mitchell <wence@gmx.li>
2118
2119 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2120 (Fgnutls_boot): Use it.
2121
64348f40
AS
21222011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2123
2124 * doc.c (Fsubstitute_command_keys): Revert last change.
2125
1d698799
LMI
21262011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2127
f863868c
LMI
2128 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2129 quotes the next character, and doesn't affect other longer
2130 sequences (bug#8935).
2131
1d698799
LMI
2132 * lread.c (syms_of_lread): Clarify that is isn't only
2133 `eval-buffer' and `eval-defun' that's affected by
2134 `lexical-binding' (bug#8460).
2135
aa4b6df6
EZ
21362011-07-15 Eli Zaretskii <eliz@gnu.org>
2137
2138 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2139 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2140
5d856da6
PE
21412011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2142
ad6042bb
PE
2143 Fix minor problems found by static checking.
2144 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2145 (elsz): Now a signed constant, not a size_t var. We prefer signed
2146 types to unsigned, to avoid integer comparison confusion. Without
2147 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2148 "cannot optimize loop, the loop counter may overflow", a symptom
2149 of the confusion.
f00bbb22 2150 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2151 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2152
6468f31c
LMI
21532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2154
49080b10
LMI
2155 * search.c (Fre_search_backward): Mention `case-fold-search' in
2156 all the re_search_* functions (bug#8138).
2157
6468f31c
LMI
2158 * keyboard.c (Fopen_dribble_file): Document when the file is
2159 closed (bug#8056).
2160
c965adc5
EZ
21612011-07-14 Eli Zaretskii <eliz@gnu.org>
2162
df9733bf
EZ
2163 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2164 bidi_cache_idx.
2165
0bb23927
EZ
2166 Support bidi reordering of display and overlay strings.
2167 * xdisp.c (compute_display_string_pos)
2168 (compute_display_string_end): Accept additional argument STRING.
2169 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2170 (reseat_to_string): Initialize bidi_it->string.s and
2171 bidi_it->string.schars.
2172 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2173 NULL (avoids a crash in bidi_paragraph_init).
2174 Initialize itb.string.lstring.
0bb23927
EZ
2175 (init_iterator): Call bidi_init_it only of a valid
2176 buffer position was specified. Initialize paragraph_embedding to
2177 L2R.
2178 (reseat_to_string): Initialize the bidi iterator.
2179 (display_string): If we need to ignore text properties of
2180 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2181 original value of -1 will not work with bidi.)
2182 (compute_display_string_pos): First arg is now struct
2183 `text_pos *'; all callers changed. Support display properties on
2184 Lisp strings.
2185 (compute_display_string_end): Support display properties on Lisp
2186 strings.
2187 (init_iterator, reseat_1, reseat_to_string): Initialize the
2188 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2189 when iterating on a string not from display properties).
640c8776
SM
2190 (compute_display_string_pos, compute_display_string_end):
2191 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2192 arrow keys.
2193 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2194 base_level_stop; instead, set base_level_stop to BEGV.
2195 Fixes crashes in vertical-motion.
0bb23927
EZ
2196 (next_element_from_buffer): Improve commentary for when
2197 the iterator is before prev_stop.
2198 (init_iterator): Initialize bidi_p from the default value of
2199 bidi-display-reordering, not from buffer-local value. Use the
2200 buffer-local value only if initializing for buffer iteration.
2201 (handle_invisible_prop): Support invisible properties on strings
2202 that are being bidi-reordered.
2203 (set_iterator_to_next): Support bidi reordering of C strings and
2204 Lisp strings.
2205 (next_element_from_string): Support bidi reordering of Lisp
2206 strings.
2207 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2208 (display_string): Support display of R2L glyph rows.
2209 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2210 (init_iterator): Don't initialize it->bidi_p for strings
2211 here.
2212 (reseat_to_string): Initialize it->bidi_p for strings here.
2213 (next_element_from_string, next_element_from_c_string)
2214 (next_element_from_buffer): Add xassert's for correspondence
2215 between IT's object being iterated and it->bidi_it.string
2216 structure.
2217 (face_before_or_after_it_pos): Support bidi iteration.
2218 (next_element_from_c_string): Handle the case of the first string
2219 character that is not the first one in the visual order.
2220 (get_visually_first_element): New function, refactored from common
2221 parts of next_element_from_buffer, next_element_from_string, and
2222 next_element_from_c_string.
2223 (tool_bar_lines_needed, redisplay_tool_bar)
2224 (display_menu_bar): Force left-to-right direction. Add a FIXME
2225 comment for making that be controlled by a user option.
2226 (push_it, pop_it): Save and restore the state of the
2227 bidi iterator. Save and restore the bidi_p flag.
2228 (pop_it): Iterate out of display property for string iteration as
2229 well.
2230 (iterate_out_of_display_property): Support iteration over strings.
2231 (handle_single_display_spec): Set up it->bidi_it for iteration
2232 over a display string, and call bidi_init_it.
2233 (handle_single_display_spec, next_overlay_string)
2234 (get_overlay_strings_1, push_display_prop): Set up the bidi
2235 iterator for displaying display or overlay strings.
2236 (forward_to_next_line_start): Don't use the shortcut if
2237 bidi-iterating.
2238 (back_to_previous_visible_line_start): If handle_display_prop
2239 pushed the iterator stack, restore the internal state of the bidi
2240 iterator by calling bidi_pop_it same number of times.
2241 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2242 and we are bidi-iterating, don't decrement the iterator position;
2243 instead, set the first_elt flag in the bidi iterator, to produce
2244 the same effect.
2245 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2246 (push_display_prop): xassert that we are iterating a buffer.
2247 (push_it, pop_it): Save and restore paragraph_embedding member.
2248 (handle_single_display_spec, next_overlay_string)
2249 (get_overlay_strings_1, reseat_1, reseat_to_string)
2250 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2251 correctly. Don't assume unibyte strings are not bidi-reordered.
2252 (compute_display_string_pos)
2253 (compute_display_string_end): Fix handling the case of C string.
2254 (push_it, pop_it): Save and restore from_disp_prop_p.
2255 (handle_single_display_spec, push_display_prop): Set the
2256 from_disp_prop_p flag.
2257 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2258 (pop_it): Call iterate_out_of_display_property only if we are
2259 popping after iteration over a string that came from a display
2260 property. Fix a typo in popping stretch info. Add an assertion
2261 for verifying that the iterator position is in sync with the bidi
2262 iterator.
2263 (handle_single_display_spec, get_overlay_strings_1)
2264 (push_display_prop): Fix initialization of paragraph direction for
2265 string when that of the parent object is not yet determined.
2266 (reseat_1): Call bidi_init_it to resync the bidi
2267 iterator with IT's position. (Bug#7616)
2268 (find_row_edges): If ROW->start.pos gives position
2269 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2270 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2271 Reset the from_disp_prop_p flag.
2272 (SAVE_IT, RESTORE_IT): New macros.
2273 (pos_visible_p, face_before_or_after_it_pos)
2274 (back_to_previous_visible_line_start)
2275 (move_it_in_display_line_to, move_it_in_display_line)
2276 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2277 (try_scrolling, redisplay_window, display_line): Use them when
2278 saving a temporary copy of the iterator and restoring it back.
2279 (back_to_previous_visible_line_start, reseat_1)
2280 (init_iterator): Empty the bidi cache "stack".
2281 (move_it_in_display_line_to): If iterator ended up at
2282 EOL, but we never saw any buffer positions smaller than
2283 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2284 motion in bidi-reordered lines.
2285 (move_it_in_display_line_to): Record prev_method and prev_pos
2286 immediately before the call to set_iterator_to_next. Fixes cursor
2287 motion in bidi-reordered lines with stretch glyphs and strings
2288 displayed in margins. (Bug#8133) (Bug#8867)
2289 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2290 TO_CHARPOS.
640c8776
SM
2291 (pos_visible_p): Support positions in bidi-reordered lines.
2292 Save and restore bidi cache.
0bb23927
EZ
2293
2294 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2295 (bidi_paragraph_info): Delete unused struct.
2296 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2297 (bidi_cache_start): New variable.
2298 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2299 to zero.
2300 (bidi_cache_fetch_state, bidi_cache_search)
2301 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2302 (bidi_cache_find, bidi_peek_at_next_level)
2303 (bidi_level_of_next_char, bidi_find_other_level_edge)
2304 (bidi_move_to_visually_next): Compare cache index with
2305 bidi_cache_start rather than with zero.
2306 (bidi_fetch_char): Accept new argument STRING; all callers
2307 changed. Support iteration over a string. Support strings with
2308 display properties. Support unibyte strings. Fix the type of
2309 `len' according to what STRING_CHAR_AND_LENGTH expects.
2310 (bidi_paragraph_init, bidi_resolve_explicit_1)
2311 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2312 (bidi_level_of_next_char, bidi_move_to_visually_next):
2313 Support iteration over a string.
0bb23927
EZ
2314 (bidi_set_sor_type, bidi_resolve_explicit_1)
2315 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2316 can now be zero (for strings); special values 0 and -1 were
2317 changed to -1 and -2, respectively.
2318 (bidi_char_at_pos): New function.
2319 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2320 Call it instead of FETCH_MULTIBYTE_CHAR.
2321 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2322 initialized to valid values.
2323 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2324 values.
2325 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2326 the test for valid cached positions. Fix the logic for looking up
2327 the sentinel state in the cache. GCPRO the Lisp string we are
2328 iterating.
2329 (bidi_push_it, bidi_pop_it): New functions.
2330 (bidi_initialize): Initialize the bidi cache start stack pointer.
2331 (bidi_cache_ensure_space): New function, refactored from part of
2332 bidi_cache_iterator_state. Don't assume the required size is just
2333 one BIDI_CACHE_CHUNK away.
2334 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2335 (bidi_count_bytes, bidi_char_at_pos): New functions.
2336 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2337 always valid if bidi_cache_idx is valid.
2338 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2339 is valid if it's going to be used.
2340 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2341 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2342 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2343 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2344 (bidi_find_other_level_edge, bidi_cache_start_stack):
2345 All variables related to cache indices are now EMACS_INT.
c965adc5 2346
0bb23927
EZ
2347 * dispextern.h (struct bidi_string_data): New structure.
2348 (struct bidi_it): New member `string'. Make flag members be 1-bit
2349 fields, and put them last in the struct.
640c8776
SM
2350 (compute_display_string_pos, compute_display_string_end):
2351 Update prototypes.
0bb23927
EZ
2352 (bidi_push_it, bidi_pop_it): Add prototypes.
2353 (struct iterator_stack_entry): New members bidi_p,
2354 paragraph_embedding, and from_disp_prop_p.
2355 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2356 (bidi_shelve_cache, bidi_unshelve_cache):
2357 Declare prototypes.
0bb23927
EZ
2358
2359 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2360 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2361 and vector-like objects.
2362
2363 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2364 cache around display iteration.
2365
2366 * window.c (Fwindow_end, window_scroll_pixel_based)
2367 (displayed_window_lines, Frecenter): Save and restore the bidi
2368 cache around display iteration.
2369
3bbd2265
LMI
23702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2371
2372 * editfns.c (Fdelete_region): Clarify the use of the named
2373 parameters (bug#6788).
2374
adc47434
MR
23752011-07-14 Martin Rudalics <rudalics@gmx.at>
2376
2377 * indent.c (Fvertical_motion): Set and restore w->pointm when
2378 saving and restoring the window's buffer (Bug#9006).
2379
837c31f8
LMI
23802011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2381
2382 * editfns.c (Fstring_to_char): Clarify just what is returned
2383 (bug#6576). Text by Eli Zaretskii.
2384
ac389d0c
JB
23852011-07-13 Juanma Barranquero <lekktu@gmail.com>
2386
2387 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2388
0be0ce47
EZ
23892011-07-13 Eli Zaretskii <eliz@gnu.org>
2390
2391 * buffer.c (mmap_find): Fix a typo.
2392
cd18e7e3
JB
23932011-07-13 Johan Bockgård <bojohan@gnu.org>
2394
2395 Fix execution of x selection hooks.
2396 * xselect.c (Qx_lost_selection_functions)
2397 (Qx_sent_selection_functions): New vars.
2398 (syms_of_xselect): DEFSYM them.
2399 (x_handle_selection_request): Pass Qx_sent_selection_functions
2400 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2401 (x_handle_selection_clear,x_clear_frame_selections):
2402 Pass Qx_lost_selection_functions rather than
2403 Vx_lost_selection_functions to Frun_hook_with_args.
2404
47ea7f44
PE
24052011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2406
ac389d0c 2407 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2408 The old code sometimes used this field without initializing it.
2409
47ea7f44
PE
2410 * alloc.c (gc_sweep): Don't read past end of array.
2411 In theory, the old code could also have corrupted Emacs internals,
2412 though it'd be very unlikely.
2413
bc985c87
AS
24142011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2415
2416 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2417 argument. (Bug#4026)
bc985c87 2418
0cf34688
LMI
24192011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2420
b3dadd76
LMI
2421 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2422 key" (bug#4257).
2423
0cf34688
LMI
2424 * window.c (Fset_window_start): Doc fix (bug#4199).
2425 (Fset_window_hscroll): Ditto.
2426
270768cd
PE
24272011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2428
077e3dda 2429 Fix minor new problems caught by GCC 4.6.1.
270768cd 2430 * term.c (init_tty): Remove unused local.
490011a6 2431 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2432 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2433 not used otherwise.
270768cd 2434
b1f58454
CY
24352011-07-12 Chong Yidong <cyd@stupidchicken.com>
2436
2437 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2438
22b9578d
LMI
24392011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2440
6e70ab07
LMI
2441 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2442 are the mini-buffer and the echo area (bug#3320).
2443
22b9578d
LMI
2444 * term.c (init_tty): Remove support for supdup, c10 and perq
2445 terminals, which are no longer supported (bug#1482).
2446
8974cc9f
JB
24472011-07-10 Johan Bockgård <bojohan@gnu.org>
2448
2449 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2450
a560d974
JD
24512011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2452
2453 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2454 for non-popups (Bug#3642).
2455
1dae0f0a
AS
24562011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2457
268c2c36 2458 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2459 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2460 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2461 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2462 * data.c (fmod): Likewise.
2463 * dispnew.c (swap_glyphs_in_rows): Likewise.
2464 * emacs.c (memory_warning_signal): Likewise.
2465 * floatfns.c (float_error): Likewise.
2466 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2467 (otf_open, font_otf_capability, generate_otf_features)
2468 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2469 Likewise.
2470 * image.c (pbm_read_file): Likewise.
2471 * indent.c (string_display_width): Likewise.
2472 * intervals.c (check_for_interval, search_for_interval)
2473 (inc_interval_count, count_intervals, root_interval)
2474 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2475 * lread.c (defalias): Likewise.
268c2c36 2476 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2477 * regex.c (set_image_of_range_1, set_image_of_range)
2478 (regex_grow_registers): Likewise.
2479 * sysdep.c (strerror): Likewise.
2480 * termcap.c (valid_filename_p, tprint, main): Likewise.
2481 * tparam.c (main): Likewise.
2482 * unexhp9k800.c (run_time_remap, save_data_space)
2483 (update_file_ptrs, read_header, write_header, calculate_checksum)
2484 (copy_file, copy_rest, display_header): Likewise.
2485 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2486 Likewise.
2487 * xdisp.c (check_it): Likewise.
2488 * xfaces.c (register_color, unregister_color, unregister_colors):
2489 Likewise.
2490 * xfns.c (print_fontset_result): Likewise.
2491 * xrdb.c (member, fatal, main): Likewise.
2492
99033785
PE
24932011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2494
2495 Fix minor problems found by static checking (Bug#9031).
2496 * chartab.c (char_table_set_range, map_sub_char_table):
2497 Remove unused locals.
2498 (uniprop_table): Now static.
2499 * composite.c (_work_char): Remove unused static var.
2500
9cb2ac56
JB
25012011-07-09 Juanma Barranquero <lekktu@gmail.com>
2502
2503 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2504
f25661f0
JD
25052011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2506
2507 * gtkutil.c (qttip_cb): Remove code without function.
2508
8278c4fe
EZ
25092011-07-09 Eli Zaretskii <eliz@gnu.org>
2510
2511 * w32.c (pthread_sigmask): New stub.
2512
1692ae2d 25132011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2514
8a6ebd58 2515 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2516 sigprocmask is portable only for single-threaded applications, and
2517 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2518 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2519 (LIBES): Use it.
2520 * callproc.c (Fcall_process):
2521 * process.c (create_process):
2522 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2523 Use pthread_sigmask, not sigprocmask.
123403e4 2524
1b854618
JD
25252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2526
2527 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2528 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2529 wrong (Bug#8591).
2530
3fe4b549
JD
25312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2532
0ce7e563
JD
2533 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2534 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2535 (xg_hide_tooltip): Fix comment.
2536
3fe4b549
JD
2537 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2538 in registerServicesMenuSendTypes.
2539 (validRequestorForSendType): Don't check ns_return_types.
2540
2541 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2542 ns_return_type.
2543
5df75e47
JR
25442011-07-08 Jason Rumney <jasonr@gnu.org>
2545
2546 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2547 frame struct members of non-existent frames (Bug#6284).
2548
699c10bd
JD
25492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2550
4393663b
JD
2551 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2552 variable firstTime not needed on OSX >= 10.6.
2553 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2554 >= 10.5. Use setKnobProportion, setDoubleValue.
2555
2556 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2557 (MAC_OS_X_VERSION_10_5): Define if not defined.
2558 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2559 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2560 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2561
2562 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2563 cString and lossyCString on OSX >= 10.4
2564
2565 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2566 sizeToFit on OSX >= 10.2.
2567
2568 * nsimage.m (allocInitFromFile): Don't use deprecated method
2569 bestRepresentationForDevice on OSX >= 10.6.
2570
2571 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2572 to avoid warning.
2573
2574 * emacs.c: Declare unexec_init_emacs_zone.
2575
a63e0781
JD
2576 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2577
699c10bd
JD
2578 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2579
2580 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2581 on svcsMenu (Bug#8842).
2582
2583 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2584 ns_return_types.
2585 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2586
2587 * nsterm.m (QUTF8_STRING): Declare.
2588 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2589 (validRequestorForSendType): Return type is (id).
2590 Change indexOfObjectIdenticalTo to indexOfObject.
2591 Check if we have local selection before returning self (Bug#8842).
2592 (writeSelectionToPasteboard): Put local selection into paste board
2593 if we have a local selection (Bug#8842).
2594 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2595
2596 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2597 (ns_get_local_selection): Declare.
2598
54e10184
LMI
25992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2600
9888ff71
LMI
2601 * keymap.c (describe_map_tree): Don't insert a double newline at
2602 the end of the buffer (bug#1169) and return whether we inserted
2603 something.
2604
54e10184
LMI
2605 * callint.c (Fcall_interactively): Change "reading args" to
2606 "providing args" to try to clarify what it does (bug#1010).
2607
15fa4783
KH
26082011-07-07 Kenichi Handa <handa@m17n.org>
2609
2610 * composite.c (composition_compute_stop_pos): Ignore a static
2611 composition starting before CHARPOS (Bug#8915).
2612
2613 * xdisp.c (handle_composition_prop): Likewise.
2614
a8815b00
EZ
26152011-07-07 Eli Zaretskii <eliz@gnu.org>
2616
2617 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2618 (Bug#9015)
2619
ef7b981d 26202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2621
2622 * character.h (unicode_category_t): New enum type.
2623
2624 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2625 (Qchar_code_property_table): New variable.
2626 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2627 (UNIPROP_COMPRESSED_FORM_P): New macros.
2628 (char_table_ascii): Uncompress the compressed values.
2629 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2630 Uncompress the compressed values.
ac389d0c 2631 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2632 (char_table_ref_and_range): Uncompress the compressed values.
2633 (sub_char_table_set): New arg is_uniprop. Callers changed.
2634 Uncompress the compressed values.
2635 (sub_char_table_set_range): Args changed. Callers changed.
2636 (char_table_set_range): Adjuted for the above change.
2637 (map_sub_char_table): Delete args default_val and parent. Add arg
2638 top. Give decoded values to a Lisp function.
640c8776 2639 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2640 values to a Lisp function. Gcpro more variables.
2641 (uniprop_table_uncompress)
2642 (uniprop_decode_value_run_length): New functions.
2643 (uniprop_decoder, uniprop_decoder_count): New variables.
2644 (uniprop_get_decoder, uniprop_encode_value_character)
2645 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2646 New functions.
2647 (uniprop_encoder, uniprop_encoder_count): New variables.
2648 (uniprop_get_encoder, uniprop_table)
2649 (Funicode_property_table_internal, Fget_unicode_property_internal)
2650 (Fput_unicode_property_internal): New functions.
2651 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2652 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2653 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2654 char-code-property-alist.
2655
640c8776 2656 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2657 Vunicode_category_table.
2658
640c8776 2659 * font.c (font_range): Adjust for the change of
c805dec0
KH
2660 Vunicode_category_table.
2661
76b397fb
DN
26622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2663
2664 * m/iris4d.h: Remove file, move contents ...
2665 * s/irix6-5.h: ... here.
2666
22b4128e
PE
26672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2670 * alloc.c (mark_buffer):
2671 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2672 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2673 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2674 This isn't true in general, and it's particularly not true
2675 if Emacs is configured with --with-wide-int.
2676 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2677 New macros, used in the buffer.c change.
2678
869795d6
JD
26792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2680
2681 * xsettings.c: Use both GConf and GSettings if both are available.
2682 (store_config_changed_event): Add comment.
2683 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2684 (store_tool_bar_style_changed): New functions.
5e617bc2 2685 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2686 (struct xsettings): Move font inside HAVE_XFT.
2687 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2688 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2689 Move inside HAVE_XFT.
640c8776 2690 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2691 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2692 also.
2693 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2694 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2695 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2696 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2697 (parse_settings): Move check for font inside HAVE_XFT.
2698 (read_settings, apply_xft_settings): Add comment.
2699 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2700 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2701 call store_font_name_changed.
2702 (xft_settings_event): Add comment.
2703 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2704 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2705 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2706 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2707 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2708 (xsettings_get_system_font, xsettings_get_system_normal_font):
2709 Add comment.
869795d6 2710
d8ed26bd
PE
27112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 Random fixes. E.g., (random) never returned negative values.
2714 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2715 subseconds part to the entropy, as that's a bit more random.
2716 Prefer signed to unsigned, since the signedness doesn't matter and
2717 in general we prefer signed. When given a limit, use a
2718 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2719 latter isn't right if USE_2_TAGS_FOR_INTS.
2720 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2721 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2722
cabf1cac
SM
27232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2724
2725 * textprop.c (text_property_stickiness):
2726 Obey Vtext_property_default_nonsticky.
2727 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2728 * w32fns.c (syms_of_w32fns):
2729 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2730
6e9b2be9
PE
27312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2732
2733 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2734 This is more efficient than Ffile_directory_p and avoids a minor race.
2735
90186c68
LMI
27362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2737
7c301272
LMI
2738 * buffer.c (Foverlay_put): Say what the return value is
2739 (bug#7835).
2740
c4f2d8d4
LMI
2741 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2742 is a directory before asking whether to use the file name
2743 (bug#7564).
ad637907
LMI
2744 (barf_or_query_if_file_exists): Make the "File is a directory"
2745 error be more correct.
c4f2d8d4 2746
90186c68
LMI
2747 * fns.c (Frequire): Remove the mention of the .gz files, since
2748 that's installation-specific, but keep the mention of
2749 `get-load-suffixes'.
2750
da64016e
PE
27512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2754 Report string overflow if the output is too long.
2755
7d47b580
JB
27562011-07-04 Juanma Barranquero <lekktu@gmail.com>
2757
a555cb87
JB
2758 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2759 (syms_of_gnutls): Remove duplicate DEFSYM for
2760 Qgnutls_bootprop_verify_hostname_error, an error for
2761 Qgnutls_bootprop_verify_error (which is no longer used).
2762
7d47b580
JB
2763 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2764 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2765 Also (re)move comments that are misplaced or no longer relevant.
2766
1e49bfab
LMI
27672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2768
2769 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2770
1485f4c0
CY
27712011-07-03 Chong Yidong <cyd@stupidchicken.com>
2772
2773 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2774 and background color parameters if they have been changed.
2775
a9ab721e
LMI
27762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2777
2778 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2779
cf7cff57
PE
27802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2781
2e13213d
PE
2782 * xsettings.c (SYSTEM_FONT): Define only when used.
2783 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2784
cf7cff57
PE
2785 * keymap.c (access_keymap_1): Now static.
2786
7a8e04f7
CY
27872011-07-02 Chong Yidong <cyd@stupidchicken.com>
2788
2789 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2790 leave any prefix arg for the up event (Bug#1586).
2791
61352f62
LMI
27922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2793
69bb1ef7
LMI
2794 * lread.c (syms_of_lread): Mention single symbols defined by
2795 `defvar' or `defconst' (bug#7154).
2796
61352f62 2797 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2798 (Frequire): Mention get-load-suffixes.
61352f62 2799
28545e04
MR
28002011-07-02 Martin Rudalics <rudalics@gmx.at>
2801
2802 * window.h (window): Remove clone_number slot.
2803 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2804 Remove.
2805 (make_parent_window, make_window, saved_window)
2806 (Fset_window_configuration, save_window_save): Don't deal with
2807 clone numbers.
2808 * buffer.c (Qclone_number): Remove declaration.
2809 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2810
3349e122
SM
28112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2812
2813 Add multiple inheritance to keymaps.
2814 * keymap.c (Fmake_composed_keymap): New function.
2815 (Fset_keymap_parent): Simplify.
2816 (fix_submap_inheritance): Remove.
2817 (access_keymap_1): New function extracted from access_keymap to handle
2818 embedded parents and handle lists of maps.
2819 (access_keymap): Use it.
2820 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2821 (Fcopy_keymap): Handle embedded parents.
2822 (Fcommand_remapping, define_as_prefix): Simplify.
2823 (Fkey_binding): Simplify.
2824 (syms_of_keymap): Move minibuffer-local-completion-map,
2825 minibuffer-local-filename-completion-map,
2826 minibuffer-local-must-match-map, and
2827 minibuffer-local-filename-must-match-map to Elisp.
2828 (syms_of_keymap): Defsubr make-composed-keymap.
2829 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2830 (parse_menu_item): Trivial simplification.
2831
3279eb87
GM
28322011-07-01 Glenn Morris <rgm@gnu.org>
2833
2834 * Makefile.in (SETTINGS_LIBS): Fix typo.
2835
4550efdf
KI
28362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2837
2838 * coding.c (Fencode_coding_string): Record the last coding system
2839 used, as the function doc string says (bug#8738).
2840
0949d2b6
JD
28412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2842
2843 * xsettings.c (store_monospaced_changed): Take new font as arg and
2844 check for change against current_mono_font.
2845 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2846 (emacs_settings_constructor, emacs_settings_get_property)
2847 (emacs_settings_set_property, emacs_settings_class_init)
2848 (emacs_settings_init, gsettings_obj): Remove.
2849 (something_changedCB): New function for HAVE_GSETTINGS.
2850 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2851 with value as argument.
2852 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2853 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2854 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2855 "changed".
2856
2857 * xgselect.c: Add defined (HAVE_GSETTINGS).
2858 (xgselect_initialize): Ditto.
2859
2860 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2861 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2862 xg_select.
2863
bbc6b304
PE
28642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 * eval.c (struct backtrace): Simplify and port the data structure.
2867 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2868 signed bit field, as this assumption is not portable and it makes
2869 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2870 "char debug_on_exit : 1" as this is not portable either; instead,
2871 use the portable "unsigned int debug_on_exit : 1". Remove unused
2872 member evalargs. Remove obsolete comments about cc bombing out.
2873
9851bfc5
JD
28742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2875
51bb811f 2876 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2877 Let HAVE_GSETTINGS override HAVE_GCONF.
2878 (store_monospaced_changed): New function.
2879 (EMACS_SETTINGS): A new type derived from GObject to handle
2880 GSettings notifications.
2881 (emacs_settings_constructor, emacs_settings_get_property)
2882 (emacs_settings_set_property, emacs_settings_class_init):
2883 New functions.
2884 (gsettings_client, gsettings_obj): New variables.
2885 (GSETTINGS_SCHEMA): New define.
2886 (something_changedCB): Call store_monospaced_changed.
2887 (init_gsettings): New function.
2888 (xsettings_initialize): Call init_gsettings.
2889 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2890 to NULL.
2891
640c8776 2892 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2893 GCONF_CFLAGS/LIBS.
2894
5386012d
MR
28952011-06-29 Martin Rudalics <rudalics@gmx.at>
2896
2897 * window.c (resize_root_window, grow_mini_window)
2898 (shrink_mini_window): Rename Qresize_root_window to
2899 Qwindow_resize_root_window and Qresize_root_window_vertically to
2900 Qwindow_resize_root_window_vertically.
2901
f13e0b08
PE
29022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2903
2904 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2905
94515237
JB
29062011-06-27 Juanma Barranquero <lekktu@gmail.com>
2907
2908 * makefile.w32-in: Redesign dependencies so they reflect more
2909 clearly which files are directly included by each source file,
2910 and not through other includes.
2911
e43b6e43
MR
29122011-06-27 Martin Rudalics <rudalics@gmx.at>
2913
2914 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2915 (sort_overlays, overlay_strings): When an overlay's clone number
2916 matches the window's clone number process the overlay even if
2917 the overlay's window property doesn't match the current window.
2918
d68443dc
MR
2919 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2920 (Fwindow_hchild): Rename to Fwindow_left_child.
2921 (Fwindow_next): Rename to Fwindow_next_sibling.
2922 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2923 (resize_window_check): Rename to window_resize_check.
2924 (resize_window_apply): Rename to window_resize_apply.
2925 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2926 (Fdelete_other_windows_internal, resize_frame_windows)
2927 (Fsplit_window_internal, Fdelete_window_internal)
2928 (grow_mini_window, shrink_mini_window)
2929 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2930
c7e73be5
JD
29312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2932
2933 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2934 (emacs_fixed_set_min_size): Remove.
2935 (emacs_fixed_new): Take frame as argument.
2936
2937 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2938 (_EmacsFixedPrivate): Remove minwidth/height.
2939 Add struct frame *f.
2940 (emacs_fixed_init): Initialize priv->f.
2941 (get_parent_class, emacs_fixed_set_min_size): Remove.
2942 (emacs_fixed_new): Set priv->f to argument.
2943 (emacs_fixed_get_preferred_width)
2944 (emacs_fixed_get_preferred_height): Use min_width/height from
2945 frames size_hint to set minimum and natural (Bug#8919).
2946 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2947 and use min_width/height from frames size_hint to set
2948 min_width/height (Bug#8919).
2949
2950 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2951 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2952 Fix indentation.
c7e73be5 2953
cf99dcf8
EZ
29542011-06-26 Eli Zaretskii <eliz@gnu.org>
2955
2956 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2957 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2958 called at ZV.
2959
029529ac
CY
29602011-06-26 Chong Yidong <cyd@stupidchicken.com>
2961
2962 * process.c (wait_reading_process_output): Bypass select if
2963 waiting for a cell while ignoring keyboard input, and input is
2964 pending. Suggested by Jan Djärv (Bug#8869).
2965
7a7ef429
PE
29662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Use gnulib's dup2 module instead of rolling our own.
2969 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2970
11fdef7d 29712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2972
2973 * dispnew.c (scrolling_window): Before scrolling, turn off a
2974 mouse-highlight in the window being scrolled.
2975
cd3520a4
JB
29762011-06-24 Juanma Barranquero <lekktu@gmail.com>
2977
2978 Move DEFSYM to lisp.h and use everywhere.
2979
2980 * character.h (DEFSYM): Move declaration...
2981 * lisp.h (DEFSYM): ...here.
2982
2983 * gnutls.c:
2984 * minibuf.c:
2985 * w32menu.c:
2986 * w32proc.c:
2987 * w32select.c: Don't include character.h.
2988
2989 * alloc.c (syms_of_alloc):
2990 * buffer.c (syms_of_buffer):
2991 * bytecode.c (syms_of_bytecode):
2992 * callint.c (syms_of_callint):
2993 * casefiddle.c (syms_of_casefiddle):
2994 * casetab.c (init_casetab_once):
2995 * category.c (init_category_once, syms_of_category):
2996 * ccl.c (syms_of_ccl):
2997 * cmds.c (syms_of_cmds):
2998 * composite.c (syms_of_composite):
2999 * dbusbind.c (syms_of_dbusbind):
3000 * dired.c (syms_of_dired):
3001 * dispnew.c (syms_of_display):
3002 * doc.c (syms_of_doc):
3003 * editfns.c (syms_of_editfns):
3004 * emacs.c (syms_of_emacs):
3005 * eval.c (syms_of_eval):
3006 * fileio.c (syms_of_fileio):
3007 * fns.c (syms_of_fns):
3008 * frame.c (syms_of_frame):
3009 * fringe.c (syms_of_fringe):
3010 * insdel.c (syms_of_insdel):
3011 * keymap.c (syms_of_keymap):
3012 * lread.c (init_obarray, syms_of_lread):
3013 * macros.c (syms_of_macros):
3014 * msdos.c (syms_of_msdos):
3015 * print.c (syms_of_print):
3016 * process.c (syms_of_process):
3017 * search.c (syms_of_search):
3018 * sound.c (syms_of_sound):
3019 * syntax.c (init_syntax_once, syms_of_syntax):
3020 * terminal.c (syms_of_terminal):
3021 * textprop.c (syms_of_textprop):
3022 * undo.c (syms_of_undo):
3023 * w32.c (globals_of_w32):
3024 * window.c (syms_of_window):
3025 * xdisp.c (syms_of_xdisp):
3026 * xfaces.c (syms_of_xfaces):
3027 * xfns.c (syms_of_xfns):
3028 * xmenu.c (syms_of_xmenu):
3029 * xsettings.c (syms_of_xsettings):
3030 * xterm.c (syms_of_xterm): Use DEFSYM.
3031
4228cf16
TZ
30322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3033
cd3520a4 3034 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3035
7fcccf1e
PE
30362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3037
7efb4e0e
PE
3038 Integer and buffer overflow fixes (Bug#8873).
3039
ff5844ad
PE
3040 * print.c (printchar, strout): Check for string overflow.
3041 (PRINTPREPARE, printchar, strout):
3042 Don't set size unless allocation succeeds.
3043
90532f02
PE
3044 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3045 for sizes. Check for string overflow more accurately.
3046 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3047
6d84508d
PE
3048 * macros.c: Integer and buffer overflow fixes.
3049 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3050 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3051 Use ptrdiff_t, not int, for sizes.
3052 Don't increment bufsize until after realloc succeeds.
3053 Check for size-calculation overflow.
3054 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3055
437b2cb4
PE
3056 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3057
8b9ac8b4
PE
3058 * lread.c: Integer overflow fixes.
3059 (read_integer): Radix is now EMACS_INT, not int,
3060 to improve quality of diagnostics for out-of-range radices.
3061 Calculate buffer size correctly for out-of-range radices.
3062 (read1): Check for integer overflow in radices, and in
3063 read-circle numbers.
82cb60d3
PE
3064 (read_escape): Avoid int overflow.
3065 (Fload, openp, read_buffer_size, read1)
3066 (substitute_object_recurse, read_vector, read_list, map_obarray):
3067 Use ptrdiff_t, not int, for sizes.
3068 (read1): Use EMACS_INT, not int, for sizes.
20270765 3069 Check for size overflow.
8b9ac8b4 3070
7fcccf1e
PE
3071 * image.c (cache_image): Check for size arithmetic overflow.
3072
bfbbd7e7
PE
3073 * lread.c: Integer overflow issues.
3074 (saved_doc_string_size, saved_doc_string_length)
3075 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3076 Now ptrdiff_t, not int.
3077 (read1): Don't assume doc string length fits in int. Check for
3078 out-of-range doc string lengths.
3079 (read_list): Don't assume file position fits in int.
39019e54 3080 (read_escape): Check for hex character overflow.
bfbbd7e7 3081
4e323265
LL
30822011-06-22 Leo Liu <sdl.web@gmail.com>
3083
3084 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3085 Move to minibuffer.el.
3086
85fece3e
PE
30872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3088
20b84ce9 3089 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3090 The following patches are for when GLYPH_DEBUG && !XASSERT.
3091 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3092 * dispnew.c (flush_stdout):
3093 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3094 Mark as externally visible.
3095 * dispnew.c (check_window_matrix_pointers): Now static.
3096 * dispnew.c (window_to_frame_vpos):
3097 * xfns.c (unwind_create_frame):
3098 * xterm.c (x_check_font): Remove unused local.
3099 * scroll.c (CHECK_BOUNDS):
3100 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3101 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3102 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3103 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3104 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3105 Now static.
3106 (debug_method_add): Use va_list and vsprintf rather than relying
3107 on undefined behavior with wrong number of arguments.
3108 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3109 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3110 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3111 since we're not interested in debugging glyphs with old libraries.
3112 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3113 GCC 4.6.0's static checking.
3114
0766b489
PE
31152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3116
31fd4b32
PE
3117 Integer overflow and signedness fixes (Bug#8873).
3118 A few related buffer overrun fixes, too.
3119
b79e8648
PE
3120 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3121
0766b489
PE
3122 * dispextern.h (struct face.stipple):
3123 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3124 (x_bitmap_mask, x_allocate_bitmap_record)
3125 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3126 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3127 (x_create_bitmap_from_xpm_data):
3128 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3129 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3130 (.bitmaps_last):
3131 * xfaces.c (load_pixmap):
3132 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3133 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3134 (.bitmaps_last, struct x_output.icon_bitmap):
3135 Use ptrdiff_t, not int, for bitmap indexes.
3136 (x_allocate_bitmap_record): Check for size overflow.
3137 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3138
b081724f
PE
3139 Use ptrdiff_t, not int, for overlay counts.
3140 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3141 * editfns.c (overlays_around, get_pos_property):
3142 * textprop.c (get_char_property_and_overlay):
3143 * xdisp.c (next_overlay_change, note_mouse_highlight):
3144 * xfaces.c (face_at_buffer_position):
21514da7
PE
3145 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3146 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3147 (Fnext_overlay_change, Fprevious_overlay_change)
3148 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3149 Use ptrdiff_t, not int, for sizes.
21514da7 3150 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3151
3de73e5e
PE
3152 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3153
2606c57b
PE
3154 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3155 (x_session_initialize): Do not assume string length fits in int.
3156
aaafe47a
PE
3157 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3158 This is unlikely, but can occur if DPI is outlandish.
3159
2674ddc8 3160 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3161 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3162
28154962
PE
3163 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3164 * xrdb.c (magic_file_p, search_magic_path):
3165 Omit last arg SUFFIX; it was always 0. All callers changed.
3166 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3167
7de51af5
PE
3168 * xfont.c (xfont_match): Avoid need for strlen.
3169
25ed6cc3
PE
3170 * xfns.c: Don't assume strlen fits in int.
3171 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3172
4eab31dd
PE
3173 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3174 not unsigned long, as we prefer signed integers. All callers changed.
3175 Detect integer overflow in repeat count.
3176 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3177 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3178
171e2a58
PE
3179 * termcap.c: Don't assume sizes fit in int and never overflow.
3180 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3181 (gobble_line): Check for size-calculation overflow.
3182
ad39faca 3183 * minibuf.c (Fread_buffer):
6e5bb2dc 3184 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3185 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3186 Don't assume string length fits in int.
3187
52c61c22 3188 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3189 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3190
b5b8c9e5
PE
3191 * font.c: Don't assume string length fits in int.
3192 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3193 Use ptrdiff_t, not int.
ccd6111c
PE
3194 (font_intern_prop): Don't assume string length fits in int.
3195 Don't assume integer property fits in fixnum.
3196 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3197
882f0d81 3198 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3199 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3200 Reformulate so as not to need the command string.
3201 Invoke gzip -cd rather than gunzip, as it's more portable.
3202 (lock_info_type, lock_file_1, lock_file):
3203 Don't assume pid_t and time_t fit in unsigned long.
3204 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3205 (current_lock_owner): Prefer signed type for sizes.
3206 Use memcpy, not strncpy, where memcpy is what is really wanted.
3207 Don't assume (via atoi) that time_t and pid_t fit in int.
3208 Check for time_t and/or pid_t out of range, e.g., via a network share.
3209 Don't alloca where an auto var works fine.
3210
93f4cf88
PE
3211 * fileio.c: Fix some integer overflow issues.
3212 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3213 Don't assume string length fits in int.
3214 (directory_file_name): Don't assume string length fits in long.
3215 (make_temp_name): Don't assume pid fits in int, or that its print
3216 length is less than 20.
3217
f3e92b69
PE
3218 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3219
1bfdaf10
PE
3220 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3221
35016e9a
PE
3222 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3223
3d1e65a1
PE
3224 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3225 We prefer signed integers, even for size calculations.
3226
0b963a93
PE
3227 * emacs.c: Don't assume string length fits in 'int'.
3228 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3229 (main): Don't invoke strlen when not needed.
3230
573f4b54
PE
3231 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3232 (XD_DEBUG_MESSAGE): Don't waste a byte.
3233
989f33ba
PE
3234 * callproc.c (getenv_internal_1, getenv_internal)
3235 (Fgetenv_internal):
965d34eb
PE
3236 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3237
e4d29b33
PE
3238 * lread.c (invalid_syntax): Omit length argument.
3239 All uses changed. This doesn't fix a bug, but it simplifies the
3240 code away from its former Hollerith-constant appearance, and it's
3241 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3242 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3243
eb49b136
PE
3244 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3245 This didn't break anything, but it didn't help either.
3246 It's confusing to put a bogus integer in a place where the actual
3247 value does not matter.
9f62aeb1 3248 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3249 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3250
15375a22
PE
3251 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3252 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3253 implementation.
b61cc01c
PE
3254 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3255 We prefer signed types, and the value cannot exceed the EMACS_INT
3256 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3257 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3258 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3259 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3260
53b2623d
PE
3261 * indent.c (sane_tab_width): New function.
3262 (current_column, scan_for_column, Findent_to, position_indentation)
3263 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3264 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3265
51cab52b 3266 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3267
f2ed8a70
PE
3268 * lisp.h (lint_assume): New macro.
3269 * composite.c (composition_gstring_put_cache):
3270 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3271
abe80cc6
PE
3272 * editfns.c, insdel.c:
3273 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3274
b02c740e
PE
3275 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3276
ebc96716
PE
3277 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3278
b4e50fa0 3279 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3280 Use much-faster test for byte-length change.
311d5d7c 3281 Don't assume string byte-length fits in 'int'.
a4cf38e4 3282 Check that character arg fits in 'int'.
85461888 3283 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3284
c0c1ee9f
PE
3285 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3286
a498d7f4
PE
3287 * fns.c (concat): Catch string overflow earlier.
3288 Do not rely on integer wraparound.
3289
51cab52b
PE
3290 * dispextern.h (struct it.overlay_strings_charpos)
3291 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3292 * xdisp.c (forward_to_next_line_start)
3293 (back_to_previous_visible_line_start)
3294 (reseat_at_next_visible_line_start, next_element_from_buffer):
3295 Don't arbitrarily truncate the value of 'selective' to int.
3296
76031fad
PE
3297 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3298
5eb55db9
PE
3299 * composite.c: Don't truncate sizes to 'int'.
3300 (composition_gstring_p, composition_reseat_it)
3301 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3302 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3303 not EMACS_UINT, for indexes.
5eb55db9 3304
0703a717
PE
3305 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3306
d6202519
PE
3307 * buffer.c: Include <verify.h>.
3308 (struct sortvec.priority, struct sortstr.priority):
8961a454 3309 Now EMACS_INT, not int.
c20998a7 3310 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3311 (struct sortstr.size, record_overlay_string)
3312 (struct sortstrlist.size, struct sortlist.used):
3313 Don't truncate size to int.
3314 (record_overlay_string): Check for size-calculation overflow.
d6202519 3315 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3316
d5a19415
JM
33172011-06-22 Jim Meyering <meyering@redhat.com>
3318
029529ac 3319 Don't leak an XBM-image-sized buffer
d5a19415
JM
3320 * image.c (xbm_load): Free the image buffer after using it.
3321
a9041e6c
PE
33222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 Port to Sun C.
3325 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3326 that Sun C diagnosed.
3327 * fns.c (secure_hash): Fix pointer signedness issue.
3328 * intervals.c (static_offset_intervals): New function.
3329 (offset_intervals): Use it.
3330
7f3f739f
LL
33312011-06-21 Leo Liu <sdl.web@gmail.com>
3332
3333 * deps.mk (fns.o):
3334 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3335 sha512.h.
3336
3337 * fns.c (secure_hash): Rename from crypto_hash_function and change
3338 the first arg to accept symbols.
5b66d427 3339 (Fsecure_hash): New primitive.
7f3f739f
LL
3340 (syms_of_fns): New symbols.
3341
76147d94
DD
33422011-06-20 Deniz Dogan <deniz@dogan.se>
3343
3344 * process.c (Fset_process_buffer): Clarify return value in
3345 docstring.
3346
7d7d0045
CY
33472011-06-18 Chong Yidong <cyd@stupidchicken.com>
3348
3349 * dispnew.c (add_window_display_history): Use BVAR.
3350
3351 * xdisp.c (debug_method_add): Use BVAR.
3352 (check_window_end, dump_glyph_matrix, dump_glyph)
3353 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3354
3355 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3356 Likewise.
3357
3358 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3359 check till after the cache is created in init_frame_faces.
3360
ff2bc410
SM
33612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3362
3363 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3364
28177add
PE
33652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3366
dd3482fe
PE
3367 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3368 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3369 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3370
393d71f3 3371 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3372 * fileio.c (Finsert_file_contents):
3373 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3374 Remove the old (too-loose) buffer overflow checks.
3375 They weren't needed, since make_gap checks for buffer overflow.
3376 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3377 The old code merely checked for Emacs fixnum overflow, and relied
3378 on undefined (wraparound) behavior. The new code avoids undefined
3379 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3380
2e6813b0 3381 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3382 Tune. Don't use wider integers than needed. Don't use alloca.
3383 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3384
599a9e4f
PE
3385 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3386
99561444
PE
3387 * insdel.c, lisp.h (buffer_overflow): New function.
3388 (insert_from_buffer_1, replace_range, replace_range_2):
3389 * insdel.c (make_gap_larger):
3390 * editfns.c (Finsert_char):
3391 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3392
28177add
PE
3393 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3394
e69dafad
PE
33952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3396
a7af7fde 3397 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3398
b1c46f02
PE
3399 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3400 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3401
e69dafad
PE
3402 * fileio.c: Don't assume EMACS_INT fits in off_t.
3403 (emacs_lseek): New static function.
3404 (Finsert_file_contents, Fwrite_region): Use it.
3405 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3406
566684ea
PE
3407 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3408
e6966cd6
PE
3409 * fns.c: Don't overflow int when computing a list length.
3410 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3411 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3412 truncation on 64-bit hosts. Check for QUIT every
3413 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3414 faster and is responsive enough.
3415 (Flength): Report an error instead of overflowing an integer.
3416 (Fsafe_length): Return a float if the value is not representable
3417 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3418 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3419 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3420
dd0b0efb
PE
3421 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3422 (header_size, word_size): New constants.
3423 (allocate_vectorlike): Don't check size overflow here.
3424 (allocate_vector): Check it here instead, since this is the only
3425 caller of allocate_vectorlike that could cause overflow.
3426 Check that the new vector's length is representable as a fixnum.
3427
86fe5cfe
PE
3428 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3429 The previous code was bogus. For example, next_almost_prime (32)
3430 returned 39, which is undesirable as it is a multiple of 3; and
3431 next_almost_prime (24) returned 25, which is a multiple of 5 so
3432 why was the code bothering to check for multiples of 7?
3433
80e88859
PE
3434 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3435
4a2f0ad6
PE
3436 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3437
f66c7cf8
PE
3438 Variadic C functions now count arguments with ptrdiff_t.
3439 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3440 Back then I didn't know that the Emacs coding style prefers signed int.
3441 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3442 were being counted with int, which may truncate counts on 64-bit
3443 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3444 * lisp.h (struct Lisp_Subr.function.aMANY)
3445 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3446 Arg counts are now ptrdiff_t, not size_t.
3447 All variadic functions and their callers changed accordingly.
3448 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3449 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3450 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3451 * callint.c (Fcall_interactively): Check arg count for overflow,
3452 to avoid potential buffer overrun. Use signed char, not 'int',
3453 for 'varies' array, so that we needn't bother to check its size
3454 calculation for overflow.
3455 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3456 * eval.c (apply_lambda):
3457 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3458 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3459 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3460
a1759b76
PE
3461 * callint.c (Fcall_interactively): Don't use index var as event count.
3462
d96be9fc
PE
3463 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3464 * mem-limits.h (SIZE): Remove; no longer used.
3465
a690a978 3466 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3467
578c21e6
PE
3468 Remove unnecessary casts.
3469 * xterm.c (x_term_init):
3470 * xfns.c (x_set_border_pixel):
3471 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3472 These aren't needed now that we assume ANSI C.
3473
96f53c6c
PE
3474 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3475 It's more likely to cause problems (due to unsigned overflow)
3476 than to cure them.
3477
83c77d31
PE
3478 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3479
ee2079f1
PE
3480 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3481
6da65536
PE
3482 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3483
7147c4a4
PE
3484 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3485
193e32d9
PE
3486 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3487
e5533da6
PE
3488 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3489
9910e595
PE
3490 GLYPH_CODE_FACE returns EMACS_INT, not int.
3491 * dispextern.h (merge_faces):
3492 * xfaces.c (merge_faces):
01103c44
PE
3493 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3494 Don't assume EMACS_INT fits in int.
9910e595 3495
2638320e
PE
3496 * character.h (CHAR_VALID_P): Remove unused parameter.
3497 * fontset.c, lisp.h, xdisp.c: All uses changed.
3498
045eb8d9
PE
3499 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3500
c1f134b5
PE
3501 * fns.c (concat): Minor tuning based on overflow analysis.
3502 This doesn't fix any bugs. Use int to hold character, instead
3503 of constantly refetching from Emacs object. Use XFASTINT, not
3504 XINT, for value known to be a character. Don't bother comparing
3505 a single byte to 0400, as it's always less.
3506
395fcb93 3507 * floatfns.c (Fexpt):
327eeec8
PE
3508 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3509
abbd3d23
PE
3510 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3511 for characters.
3512
684a03ef
PE
3513 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3514
0fed43f3
PE
3515 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3516 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3517 incorrectly succeed when S was a string, because 4294967386 was
3518 truncated before it was used.
3519
8fd02eb7
PE
3520 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3521 Otherwise, an out-of-range integer could cause undefined behavior
3522 on a 64-bit host.
3523
f8c86b69
PE
3524 * composite.c: Use int, not EMACS_INT, for characters.
3525 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3526 EMACS_INT, for values that are known to be in character range.
3527 This doesn't fix any bugs but is the usual style inside Emacs and
3528 may generate better code on 32-bit machines.
3529
34206dd2
PE
3530 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3531 This is for reasons similar to the recent CHAR_STRING fix.
3532 * charset.c (Fencode_char): Check that character arg is actually
3533 a character. Pass an int to ENCODE_CHAR.
3534 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3535 wider than 'int', as a compile-time check to prevent future regressions
3536 in this area.
3537
c5958d4c 3538 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3539
3540 Make sure a 64-bit char is never passed to CHAR_STRING.
3541 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3542 by silently ignoring the top 32 bits, allowing some values
3543 that were far too large to be valid characters.
3544 * character.h: Include <verify.h>.
3545 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3546 arguments are no wider than unsigned, as a compile-time check
3547 to prevent future regressions in this area.
3548 * data.c (Faset):
01103c44 3549 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3550 (Fsubst_char_in_region):
3551 * fns.c (concat):
3552 * xdisp.c (decode_mode_spec_coding):
3553 Adjust to CHAR_STRING's new requirement.
3554 * editfns.c (Finsert_char, Fsubst_char_in_region):
3555 * fns.c (concat): Check that character args are actually
3556 characters. Without this test, these functions did the wrong
3557 thing with wildly out-of-range values on 64-bit hosts.
3558
d37ca623
PE
3559 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3560 These casts should not be needed on 32-bit hosts, either.
3561 * keyboard.c (read_char):
3562 * lread.c (Fload): Remove casts to unsigned.
3563
ea204efb
PE
3564 * lisp.h (UNSIGNED_CMP): New macro.
3565 This fixes comparison bugs on 64-bit hosts.
3566 (ASCII_CHAR_P): Use it.
3567 * casefiddle.c (casify_object):
01103c44 3568 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3569 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3570 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3571 * dispextern.h (FACE_FROM_ID):
3572 * keyboard.c (read_char): Use UNSIGNED_CMP.
3573
41cb286c
PE
3574 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3575 not to EMACS_INT, to avoid GCC warning.
3576
4a1b9832
PE
3577 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3578
55daad71
PE
3579 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3580 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3581 isn't needed on 32-bit machines.
8f95c75c 3582
01103c44
PE
3583 * buffer.c (Fgenerate_new_buffer_name):
3584 Use EMACS_INT for count, not int.
0ceccced 3585 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3586
3587 * data.c (Qcompiled_function): Now static.
3588
c6f072e7
PE
3589 * window.c (window_body_lines): Now static.
3590
20ce5912
PE
3591 * image.c (gif_load): Rename local to avoid shadowing.
3592
9c4c5f81
PE
3593 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3594 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3595 * alloc.c (make_save_value): Integer argument is now of type
3596 ptrdiff_t, not int.
3597 (mark_object): Use ptrdiff_t, not int.
3598 * lisp.h (pD): New macro.
3599 * print.c (print_object): Use it.
3600
c0c5c8ae
PE
3601 * alloc.c: Use EMACS_INT, not int, to count objects.
3602 (total_conses, total_markers, total_symbols, total_vector_size)
3603 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3604 (total_free_floats, total_floats, total_free_intervals)
3605 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3606 Now EMACS_INT, not int. All uses changed.
3607 (Fgarbage_collect): Compute overall total using a double, so that
3608 integer overflow is less likely to be a problem. Check for overflow
3609 when converting back to an integer.
5a25e253
PE
3610 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3611 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3612 These were 'int' variables that could overflow on 64-bit hosts;
3613 they were never used, so remove them instead of repairing them.
211a0b2a 3614 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3615 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3616 Previously, this ceilinged at INT_MAX, but that doesn't work on
3617 64-bit machines.
e46bb31a 3618 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3619
c78baabf 3620 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3621 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3622 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3623 when a (possibly-narrower) signed value would do just as well.
3624 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3625
c9d624c6
PE
3626 * alloc.c: Catch some string size overflows that we were missing.
3627 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3628 for convenience in STRING_BYTES_MAX.
3629 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3630 The definition here is exact; the one in lisp.h was approximate.
3631 (allocate_string_data): Check for string overflow. This catches
3632 some instances we weren't catching before. Also, it catches
3633 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3634 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3635 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3636
c9d624c6
PE
3637 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3638 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3639 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3640
353032ce
PE
3641 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3642
2bccce07
PE
3643 * alloc.c (Fmake_string): Check for out-of-range init.
3644
0ac30604
SM
36452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3646
3647 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3648
c195f2de
JD
36492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3650
3651 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3652 xg_get_default_scrollbar_width.
3653
3654 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3655 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3656 (style_changed_cb): Call update_theme_scrollbar_width and call
3657 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3658 all frames (Bug#8505).
3659 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3660 Call gtk_window_set_resizable if HAVE_GTK3.
3661 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3662 and height if HAVE_GTK3 (Bug#8505).
3663 (scroll_bar_width_for_theme): New variable.
3664 (update_theme_scrollbar_width): New function.
3665 (xg_get_default_scrollbar_width): Move code to
3666 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3667 (xg_initialize): Call update_theme_scrollbar_width.
3668
3669 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3670
3671 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3672
e10ac9f1
MR
36732011-06-12 Martin Rudalics <rudalics@gmx.at>
3674
3675 * frame.c (make_frame): Call other_buffer_safely instead of
3676 other_buffer.
3677
3678 * window.c (temp_output_buffer_show): Call display_buffer with
3679 second argument Vtemp_buffer_show_specifiers and reset latter
3680 immediately after the call.
3681 (Vtemp_buffer_show_specifiers): New variable.
3682 (auto_window_vscroll_p, next_screen_context_lines)
3683 (Vscroll_preserve_screen_position): Remove leading asterisks from
3684 doc-strings.
3685
2d3c217e 36862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3687
7b7f97e8 3688 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3689 * buffer.c (Qclone_number): Remove for now, as it's unused.
3690 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3691 (record_buffer): Remove unused local.
3692 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3693 (set_frame_buffer_list): Remove; unused.
3694 * frame.h (other_visible_frames): Remove decl.
3695 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3696 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3697 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3698 if HAVE_GPM.
3699 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3700 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3701 Define only if HAVE_GPM.
3702 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3703 (update_hints_inhibit): Remove; never set. All uses removed.
3704 * widgetprv.h (emacsFrameClassRec): Remove decl.
3705 * window.c (delete_deletable_window): Now returns void, since it
3706 wasn't returning anything.
3707 (compare_window_configurations): Remove unused locals.
3708 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3709 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3710 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3711 the same widths as pointers. This follows up on the 2011-05-06 patch.
3712 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3713 * xterm.h: Likewise.
3714 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3715
1384b89e
JB
37162011-06-12 Juanma Barranquero <lekktu@gmail.com>
3717
3718 * makefile.w32-in: Update dependencies.
3719 (LISP_H): Add lib/intprops.h.
3720
1100a63c
CY
37212011-06-11 Chong Yidong <cyd@stupidchicken.com>
3722
3723 * image.c (gif_load): Add animation frame delay to the metadata.
3724 (syms_of_image): Use DEFSYM. New symbol `delay'.
3725
6198ccd0
MR
37262011-06-11 Martin Rudalics <rudalics@gmx.at>
3727
3728 * window.c (delete_deletable_window): Re-add.
3729 (Fset_window_configuration): Rewrite to handle dead buffers and
3730 consequently deletable windows.
3731 (window_tree, Fwindow_tree): Remove. Supply functionality in
3732 window.el.
3733 (compare_window_configurations): Simplify code.
3734
b6e3633c
AS
37352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3736
1ab0dee5
AS
3737 * image.c (imagemagick_load_image): Fix type mismatch.
3738 (Fimagemagick_types): Likewise.
3739
b6e3633c
AS
3740 * window.h (replace_buffer_in_windows): Declare.
3741
9397e56f
MR
37422011-06-11 Martin Rudalics <rudalics@gmx.at>
3743
3744 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3745 Qclone_number. Remove external declaration of Qdelete_window.
3746 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3747 code.
640c8776
SM
3748 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3749 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3750 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3751 buffer list implementation.
3752 (other_buffer_safely): New function.
3753 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3754 calls to replace_buffer_in_windows and
3755 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3756 if allowed.
3757 (record_buffer): Inhibit quitting and rewrite using quittable
3758 functions. Run Qbuffer_list_update_hook if allowed.
3759 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3760 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3761 Move switch-to-buffer to window.el.
9397e56f
MR
3762 (bury-buffer): Move to window.el.
3763 (Vbuffer_list_update_hook): New variable.
3764
3765 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3766 section.
3767
3768 * window.h (resize_frame_windows): Move up in code.
3769 (Fwindow_frame): Remove EXFUN.
3770 (replace_buffer_in_all_windows): Remove prototype.
3771 (replace_buffer_in_windows_safely): Add prototype.
3772
3773 * window.c: Declare Qdelete_window static again. Move down
3774 declaration of select_count.
3775 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3776 (Fother_window): Move to window.el.
3777 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3778 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3779 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3780 window.el.
3781 (replace_buffer_in_windows): Implement by calling
3782 Qreplace_buffer_in_windows.
3783 (replace_buffer_in_all_windows): Remove with some functionality
3784 moved into replace_buffer_in_windows_safely.
3785 (replace_buffer_in_windows_safely): New function.
3786 (select_window_norecord, select_frame_norecord): Move in front
3787 of run_window_configuration_change_hook. Remove now obsolete
3788 declarations.
640c8776
SM
3789 (Fset_window_buffer): Rewrite doc-string.
3790 Call Qrecord_window_buffer.
9397e56f
MR
3791 (keys_of_window): Move binding for other-window to window.el.
3792
b50691aa
CY
37932011-06-11 Chong Yidong <cyd@stupidchicken.com>
3794
3795 * dispextern.h (struct image): Replace data member, whose int_val
3796 and ptr_val fields were not used by anything, with a single
3797 lisp_val object.
3798
3799 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3800 (gif_clear_image, gif_load, imagemagick_load_image)
3801 (gs_clear_image, gs_load): Callers changed.
3802
3f754b86
PE
38032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3804
cca69397
PE
3805 * buffer.h: Include <time.h>, for time_t.
3806 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3807
109e28d0
PE
3808 Fix minor problems found by static checking.
3809
60737f02
PE
3810 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3811
4b66faf3
PE
3812 Make identifiers static if they are not used in other modules.
3813 * data.c (Qcompiled_function, Qframe, Qvector):
3814 * image.c (QimageMagick, Qsvg):
3815 * minibuf.c (Qmetadata):
3816 * window.c (resize_window_check, resize_root_window): Now static.
3817 * window.h (resize_window_check, resize_root_window): Remove decls.
3818
109e28d0
PE
3819 * window.c (window_deletion_count, delete_deletable_window):
3820 Remove; unused.
46a4ce9e
PE
3821 (window_body_lines): Now static.
3822 (Fdelete_other_windows_internal): Mark vars as initialized.
3823 Make sure 'resize_failed' is initialized.
3824 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3825 (resize_window_apply): Remove unused local.
3826 * window.h (delete_deletable_window): Remove decl.
3827
109e28d0 3828 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3829 (imagemagick_load_image): Fix pointer signedness problem by changing
3830 last arg from unsigned char * to char *. All uses changed.
3831 Also, fix a local for similar reasons.
3832 Remove unused locals. Remove locals to avoid shadowing.
3833 (fn_rsvg_handle_free): Remove; unused.
3834 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3835 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3836
3f754b86
PE
3837 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3838
2547adb1
CY
38392011-06-10 Chong Yidong <cyd@stupidchicken.com>
3840
3841 * image.c (gif_load): Fix omitted cast error introduced by
3842 2011-06-06 change.
3843
2c8e37d4
MR
38442011-06-10 Martin Rudalics <rudalics@gmx.at>
3845
3846 * window.h (resize_proportionally, orig_total_lines)
3847 (orig_top_line): Remove from window structure.
3848 (set_window_height, set_window_width, change_window_heights)
3849 (Fdelete_window): Remove prototypes.
3850 (resize_frame_windows): Remove duplicate declaration.
3851
440a42e3
EZ
38522011-06-10 Eli Zaretskii <eliz@gnu.org>
3853
3854 * window.h (resize_frame_windows, resize_window_check)
3855 (delete_deletable_window, resize_root_window)
3856 (resize_frame_windows): Declare prototypes.
3857
3858 * window.c (resize_window_apply): Make definition be "static" to
3859 match the prototype.
3860
562dd5e9
MR
38612011-06-10 Martin Rudalics <rudalics@gmx.at>
3862
3863 * window.c: Remove declarations of Qwindow_size_fixed,
3864 window_min_size_1, window_min_size_2, window_min_size,
3865 size_window, window_fixed_size_p, enlarge_window, delete_window.
3866 Remove static from declaration of Qdelete_window, it's
3867 temporarily needed by Fbury_buffer.
3868 (replace_window): Don't assign orig_top_line and
3869 orig_total_lines.
3870 (Fdelete_window, delete_window): Remove. Window deletion is
3871 handled by window.el.
640c8776
SM
3872 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3873 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3874 (Fdelete_other_windows): Remove. Deleting other windows is
3875 handled by window.el.
3876 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3877 handled in window.el.
3878 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3879 Window minimum sizes are handled in window.el.
3880 (shrink_windows, size_window, set_window_height)
3881 (set_window_width, change_window_heights, window_height)
3882 (window_width, CURBEG, CURSIZE, enlarge_window)
3883 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3884 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3885 handled in window.el.
3886 (make_dummy_parent): Rename to make_parent_window and give it a
3887 second argument horflag.
3888 (make_window): Don't set resize_proportionally any more.
3889 (Fsplit_window): Remove. Windows are split in window.el.
3890 (save_restore_action, save_restore_orig_size)
3891 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3892 Resize mini windows in window.el.
3893 (grow_mini_window, shrink_mini_window): Implement by calling
3894 Qresize_root_window_vertically, resize_window_check and
3895 resize_window_apply.
640c8776
SM
3896 (saved_window, Fset_window_configuration, save_window_save):
3897 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3898 resize_proportionally.
3899 (window_min_height, window_min_width): Move to window.el.
3900 (keys_of_window): Move bindings for delete-other-windows,
3901 split-window, delete-window and enlarge-window to window.el.
3902
3903 * buffer.c: Temporarily extern Qdelete_window.
3904 (Fbury_buffer): Temporarily call Qdelete_window instead of
3905 Fdelete_window (Fbury_buffer will move to window.el soon).
3906
3907 * frame.c (set_menu_bar_lines_1): Remove code handling
3908 orig_top_line and orig_total_lines.
3909
3910 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3911 set_window_height but set heights directly.
3912 (change_frame_size_1): Use resize_frame_windows.
3913
3914 * xdisp.c (init_xdisp): Don't use set_window_height but set
3915 heights directly.
3916
640c8776
SM
3917 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3918 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3919 run_window_configuration_change_hook.
3920
3921 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3922 instead of change_window_heights and run
3923 run_window_configuration_change_hook.
3924
1a13852e
MR
39252011-06-09 Martin Rudalics <rudalics@gmx.at>
3926
3927 * window.c (replace_window): Rename second argument REPLACEMENT to
3928 NEW. New third argument SETFLAG. Rewrite.
3929 (delete_window, make_dummy_parent): Call replace_window with
3930 third argument 1.
3931 (window_list_1): Move down in code.
3932 (run_window_configuration_change_hook): Move set_buffer part
3933 before select_frame_norecord part in order to unwind correctly.
3934 Rename count1 to count.
3935 (recombine_windows, delete_deletable_window, resize_root_window)
3936 (Fdelete_other_windows_internal)
3937 (Frun_window_configuration_change_hook, make_parent_window)
3938 (resize_window_check, resize_window_apply, Fresize_window_apply)
3939 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3940 (Fdelete_window_internal, Fresize_mini_window_internal):
3941 New functions.
1a13852e
MR
3942 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3943
f3d1777e
MR
39442011-06-08 Martin Rudalics <rudalics@gmx.at>
3945
496e208e
MR
3946 * window.h (window): Add some new members to window structure -
3947 normal_lines, normal_cols, new_total, new_normal, clone_number,
3948 splits, nest, prev_buffers, next_buffers.
3949 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3950 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3951
f3d1777e
MR
3952 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3953 Remove.
496e208e
MR
3954 (make_dummy_parent): Set new members of windows structure.
3955 (make_window): Move down in code. Handle new members of window
3956 structure.
3957 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3958 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3959 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3960 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3961 (Fset_window_next_buffers, Fset_window_clone_number):
3962 New functions.
496e208e
MR
3963 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3964 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3965 Doc-string fixes.
3966 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3967 Argument WINDOW can be now internal window too.
3968 (Fwindow_use_time): Move up in code.
3969 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3970 Rewrite doc-string.
3971 (Fset_window_configuration, saved_window)
3972 (Fcurrent_window_configuration, save_window_save): Handle new
3973 members of window structure.
b9e809c2
MR
3974 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3975 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3976 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3977 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3978 Qget_mru_window, Qresize_root_window,
3979 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3980 Qauto_buffer_name; staticpro them.
f3d1777e 3981
abde8f8c
MR
39822011-06-07 Martin Rudalics <rudalics@gmx.at>
3983
3984 * window.c (Fwindow_total_size, Fwindow_left_column)
3985 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3986 (Fwindow_list_1): New functions.
3987 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3988 (Fwindow_width, Fscroll_left, Fscroll_right):
3989 Use window_body_cols instead of window_box_text_cols.
3990 (delete_window, Fset_window_configuration):
3991 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3992 (delete_all_subwindows): Take a window as argument and not a
3993 structure. Rewrite.
190b47e6
MR
3994 (window_loop): Remove handling of GET_LRU_WINDOW and
3995 GET_LARGEST_WINDOW.
3996 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3997
3998 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3999 window_box_text_cols. delete_all_subwindows now takes a
4000 Lisp_Object as argument.
abde8f8c 4001
640c8776
SM
4002 * indent.c (compute_motion, Fcompute_motion):
4003 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4004
fa8a67e6
MR
4005 * frame.c (delete_frame): Call delete_all_subwindows with root
4006 window as argument.
4007
a54e3482
DC
40082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4009
4010 * fns.c (Fputhash): Document return value.
4011
60002bf5
CY
40122011-06-06 Chong Yidong <cyd@stupidchicken.com>
4013
4014 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4015
0c671da6 40162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4017
b862a52a 4018 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4019
be44ca6c
PE
4020 Check for overflow when converting integer to cons and back.
4021 * charset.c (Fdefine_charset_internal, Fdecode_char):
4022 Use cons_to_unsigned to catch overflow.
4023 (Fencode_char): Use INTEGER_TO_CONS.
4024 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4025 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4026 * data.c (long_to_cons, cons_to_long): Remove.
4027 (cons_to_unsigned, cons_to_signed): New functions.
4028 These signal an error for invalid or out-of-range values.
4029 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4030 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4031 * font.c (Ffont_variation_glyphs):
4032 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4033 * lisp.h: Include <intprops.h>.
4034 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4035 (cons_to_signed, cons_to_unsigned): New decls.
4036 (long_to_cons, cons_to_long): Remove decls.
4037 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4038 (Fprimitive_undo): Use CONS_TO_INTEGER.
4039 * xfns.c (Fx_window_property): Likewise.
4040 * xselect.c: Include <limits.h>.
4041 (x_own_selection, selection_data_to_lisp_data):
4042 Use INTEGER_TO_CONS.
4043 (x_handle_selection_request, x_handle_selection_clear)
4044 (x_get_foreign_selection, Fx_disown_selection_internal)
4045 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4046 (lisp_data_to_selection_data): Use cons_to_unsigned.
4047 (x_fill_property_data): Use cons_to_signed.
4048 Report values out of range.
4049
d1f3d2af
PE
4050 Check for buffer and string overflow more precisely.
4051 * buffer.h (BUF_BYTES_MAX): New macro.
4052 * lisp.h (STRING_BYTES_MAX): New macro.
4053 * alloc.c (Fmake_string):
4054 * character.c (string_escape_byte8):
4055 * coding.c (coding_alloc_by_realloc):
4056 * doprnt.c (doprnt):
4057 * editfns.c (Fformat):
4058 * eval.c (verror):
4059 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4060 since they may not be the same number.
4061 * editfns.c (Finsert_char):
4062 * fileio.c (Finsert_file_contents):
4063 Likewise for BUF_BYTES_MAX.
4064
dd52fcea
PE
4065 * image.c: Use ptrdiff_t, not int, for sizes.
4066 (slurp_file): Switch from int to ptrdiff_t.
4067 All uses changed.
4068 (slurp_file): Check that file size fits in both size_t (for
4069 malloc) and ptrdiff_t (for sanity and safety).
4070
7f9bbdbb
PE
4071 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4072 if b->modtime has its maximal value.
4073
dfe18f82
PE
4074 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4075
84acfcf0
PE
4076 Don't assume time_t can fit into int.
4077 * buffer.h (struct buffer.modtime): Now time_t, not int.
4078 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4079 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4080
ccd9a01a
PE
4081 Minor fixes for signed vs unsigned integers.
4082 * character.h (MAYBE_UNIFY_CHAR):
4083 * charset.c (maybe_unify_char):
4084 * keyboard.c (read_char, reorder_modifiers):
4085 XINT -> XFASTINT, since the integer must be nonnegative.
4086 * ftfont.c (ftfont_spec_pattern):
4087 * keymap.c (access_keymap, silly_event_symbol_error):
4088 XUINT -> XFASTINT, since the integer must be nonnegative.
4089 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4090 since it makes no difference and we prefer signed.
4091 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4092 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4093 nonnegative.
4094
d6d100dd
SM
40952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4096
4097 * window.h (Fwindow_frame): Declare.
4098
2b6148e4
PE
40992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4102 (SPARE_MEMORY): Always define.
4103 (LARGE_REQUEST): Remove.
4104 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4105
f230ecc9
MR
41062011-06-06 Martin Rudalics <rudalics@gmx.at>
4107
727e958e
MR
4108 * lisp.h: Move EXFUNS for Fframe_root_window,
4109 Fframe_first_window and Fset_frame_selected_window to window.h.
4110
4111 * window.h: Move EXFUNS for Fframe_root_window,
4112 Fframe_first_window and Fset_frame_selected_window here from
4113 lisp.h.
4114
4115 * frame.c (Fwindow_frame, Fframe_first_window)
4116 (Fframe_root_window, Fframe_selected_window)
4117 (Fset_frame_selected_window): Move to window.c.
4118 (Factive_minibuffer_window): Move to minibuf.c.
4119 (Fother_visible_frames_p): New function.
4120
4121 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4122
f230ecc9
MR
4123 * window.c (decode_window, decode_any_window): Move up in code.
4124 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4125 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4126 (Fwindow_buffer): Move up and rewrite doc-string.
4127 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4128 (Fwindow_prev): New functions.
727e958e
MR
4129 (Fwindow_frame): Move here from frame.c. Accept any window as
4130 argument.
4131 (Fframe_root_window, Fframe_first_window)
4132 (Fframe_selected_window): Move here from frame.c. Accept frame
4133 or arbitrary window as argument. Update doc-strings.
4134 (Fminibuffer_window): Move up in code.
4135 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4136 (Fset_frame_selected_window): Move here from frame.c.
4137 Marginal rewrite.
727e958e
MR
4138 (Fselected_window, select_window, Fselect_window): Move up in
4139 code. Minor doc-string fixes.
f230ecc9 4140
4d09bcf6
PE
41412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4142
4143 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4144 Do not assume that spare memory exists; that assumption is valid
4145 only if SYSTEM_MALLOC.
4146 (LARGE_REQUEST): New macro, so that the issue of large requests
4147 is separated from the issue of spare memory.
4148
810928a2
AS
41492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4150
172418ad
AS
4151 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4152 format. (Bug#8806)
4153
43f862f7
AS
4154 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4155
810928a2
AS
4156 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4157 before statements.
4158
a059fe24
JD
41592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4160
4161 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4162
4163 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4164
4165 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4166 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4167
989bf368
JB
41682011-06-05 Juanma Barranquero <lekktu@gmail.com>
4169
4170 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4171
4b80f674
CY
41722011-06-04 Chong Yidong <cyd@stupidchicken.com>
4173
4174 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4175 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4176 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4177 New error handlers.
4b80f674
CY
4178 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4179 Obey Vx_select_enable_clipboard_manager. Catch errors in
4180 x_clipboard_manager_save (Bug#8779).
4181 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4182 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4183
99a33b77 41842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4185
4186 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4187
99a33b77 41882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4189
4190 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4191 in the current matrix if keep_current_p is non-zero.
4192
8264569d
EZ
41932011-06-04 Eli Zaretskii <eliz@gnu.org>
4194
4195 * bidi.c (bidi_level_of_next_char): Fix last change.
4196
57f97249
EZ
41972011-06-03 Eli Zaretskii <eliz@gnu.org>
4198
fec2107c 4199 Support bidi reordering of text covered by display properties.
57f97249 4200
fec2107c
EZ
4201 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4202 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4203 (bidi_cache_search, bidi_cache_iterator_state)
4204 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4205 (bidi_level_of_next_char, bidi_move_to_visually_next):
4206 Support character positions inside a run of characters covered by a
fec2107c
EZ
4207 display string.
4208 (bidi_paragraph_init, bidi_resolve_explicit_1)
4209 (bidi_level_of_next_char): Call bidi_fetch_char and
4210 bidi_fetch_char_advance instead of FETCH_CHAR and
4211 FETCH_CHAR_ADVANCE.
4212 (bidi_init_it): Initialize new members.
4213 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4214 definitions.
4215 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4216 instead of using explicit *_CHAR codes.
d6d100dd
SM
4217 (bidi_resolve_explicit, bidi_resolve_weak):
4218 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4219 bidirectional text is supported only in multibyte buffers.
4220 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4221 it to initialize the frame_window_p member of struct bidi_it.
4222 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4223 (bidi_resolve_explicit, bidi_resolve_weak)
4224 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4225 bidi_it->nchars is non-positive.
4226 (bidi_level_of_next_char): Don't try to lookup the cache for the
4227 next/previous character if nothing is cached there yet, or if we
4228 were just reseat()'ed to a new position.
c40e2fb2 4229
0e14fe90
EZ
4230 * xdisp.c (set_cursor_from_row): Set start and stop points
4231 according to the row's direction when priming the loop that looks
4232 for the glyph on which to display cursor.
4233 (single_display_spec_intangible_p): Function deleted.
4234 (display_prop_intangible_p): Reimplement to call
4235 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4236 Accept 3 additional arguments needed by handle_display_spec.
4237 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4238 values: lists, `(when COND...)' forms, etc.
4239 (single_display_spec_string_p): Support property values that are
4240 lists with the argument STRING its top-level element.
4241 (display_prop_string_p): Fix the condition for processing a
4242 property that is a list to be consistent with handle_display_spec.
fec2107c 4243 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4244 last portion of handle_display_prop.
4245 (compute_display_string_pos): Accept additional argument
4246 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4247 value of a `display' property is a "replacing spec".
4248 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4249 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4250 the display property, but just return a value indicating whether
4251 the display property will replace the characters it covers.
4252 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4253 frame_window_p members of struct bidi_it.
d6d100dd
SM
4254 (compute_display_string_pos, compute_display_string_end):
4255 New functions.
fec2107c
EZ
4256 (push_it): Accept second argument POSITION, where pop_it should
4257 jump to continue iteration.
4258 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4259
fec2107c
EZ
4260 * keyboard.c (adjust_point_for_property): Adjust the call to
4261 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4262
4263 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4264 (bidi_init_it): Update prototypes.
4265 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4266 (compute_display_string_pos, compute_display_string_end):
4267 Declare prototypes.
fec2107c
EZ
4268 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4269 EMACS_INT.
fc6f18ce 4270
40087514 42712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4272
57f53182
PE
4273 Malloc failure behavior now depends on size of allocation.
4274 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4275 * lisp.h: Change signatures accordingly.
4276 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4277 All callers changed. (Bug#8762)
4278
4279 * gnutls.c: Use Emacs's memory allocators.
4280 Without this change, the gnutls library would invoke malloc etc.
4281 directly, which causes problems on non-SYNC_INPUT hosts, and which
4282 runs afoul of improving memory_full behavior. (Bug#8761)
4283 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4284 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4285 xfree instead of the default malloc, realloc, free.
4286 (Fgnutls_boot): No need to check for memory allocation failure,
4287 since xmalloc does that for us.
4288
ac32cd99 4289 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4290 * category.c (hash_get_category_set):
4291 * ccl.c (ccl_driver):
4292 * charset.c (Fdefine_charset_internal):
4293 * charset.h (struct charset.hash_index):
4294 * composite.c (get_composition_id, gstring_lookup_cache)
4295 (composition_gstring_put_cache):
4296 * composite.h (struct composition.hash_index):
4297 * dispextern.h (struct image.hash):
4298 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4299 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4300 (hashfn_equal, hashfn_user_defined, make_hash_table)
4301 (maybe_resize_hash_table, hash_lookup, hash_put)
4302 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4303 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4304 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4305 * image.c (make_image, search_image_cache, lookup_image)
4306 (xpm_put_color_table_h):
4307 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4308 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4309 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4310 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4311 * alloc.c (allocate_vectorlike):
4312 Check for overflow in vector size calculations.
4313 * ccl.c (ccl_driver):
4314 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4315 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4316 need to be updated by these changes.
40087514
PE
4317 * fns.c (make_hash_table, maybe_resize_hash_table):
4318 Check for integer overflow with large hash tables.
0de4bb68
PE
4319 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4320 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4321 (SXHASH_REDUCE): New macro.
4322 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4323 Use it instead of discarding useful hash info with large hash values.
4324 (sxhash_float): New function.
4325 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4326 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4327 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4328 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4329 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4330 Adjust signatures to match updated version of code.
4331 (consing_since_gc): Now EMACS_INT, since a single hash table can
4332 use more than INT_MAX bytes.
4333
698d32e2
DN
43342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4335
4336 Make it possible to build with GCC-4.6+ -O2 -flto.
4337
4338 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4339
fd6fa53f
SM
43402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4341
4342 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4343 Call minibuffer-inactive-mode.
4344
864db017
JB
43452011-05-31 Juanma Barranquero <lekktu@gmail.com>
4346
4347 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4348 Update dependencies.
4349
2ad0baf4
DN
43502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4351
4352 * data.c (init_data): Remove code for UTS, this system is not
4353 supported anymore.
4354
4fcc2638
DN
43552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4356
4357 Don't force ./temacs to start in terminal mode.
4358
4359 * frame.c (make_initial_frame): Initialize faces in all cases, not
4360 only when CANNOT_DUMP is defined.
4361 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4362
c56e0fd5
DN
43632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4364
4365 * dispnew.c (add_window_display_history): Use const for the string
4366 pointer. Remove declaration, not needed.
4367
333d54da 43682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4369
55d4c1b2 4370 Use 'inline', not 'INLINE'.
333d54da 4371 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4372 * alloc.c, fontset.c (INLINE): Remove.
4373 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4374 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4375 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4376 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4377 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4378
738db178
DN
43792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4380
4381 Make it possible to run ./temacs.
4382
4383 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4384 syms_of_callproc does the same thing. Remove test for
4385 "initialized", do it in the caller.
4386 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4387
620c53a6
SM
43882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4389
4390 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4391 (read_minibuf): Use get_minibuffer.
4392 (syms_of_minibuf): Use DEFSYM.
4393 (Qmetadata): New var.
4394 * data.c (Qbuffer): Don't make it static.
4395 (syms_of_data): Use DEFSYM.
4396
e003a292
PE
43972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4398
4399 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4400 (CCL_CODE_MIN): New macro.
4401
ed008a6d
PE
44022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4403
3687c2ef
PE
4404 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4405
ed008a6d
PE
4406 * eval.c (Qdebug): Now static.
4407 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4408 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4409 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4410
d66c4c7c
CY
44112011-05-29 Chong Yidong <cyd@stupidchicken.com>
4412
4413 * image.c: Various fixes to ImageMagick code comments.
4414 (Fimagemagick_types): Doc fix.
4415
5fbc2025
PE
44162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4417
0196f88a
PE
4418 Minor fixes prompted by GCC 4.6.0 warnings.
4419
4420 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4421
5fbc2025
PE
4422 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4423 (x_clipboard_manager_save_all): Move extern decl to ...
4424 * xterm.h: ... here, so that it can be checked for consistency.
4425
1dd3c2d9
CY
44262011-05-29 Chong Yidong <cyd@stupidchicken.com>
4427
4428 * xselect.c (x_clipboard_manager_save_frame)
4429 (x_clipboard_manager_save_all): New functions.
4430 (Fx_clipboard_manager_save): Lisp function deleted.
4431
4432 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4433 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4434
4435 * xterm.h: Update prototype.
4436
5ba6571d
WX
44372011-05-28 William Xu <william.xwl@gmail.com>
4438
4439 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4440 exiting (Bug#8239).
4441
3eaff834
JM
44422011-05-28 Jim Meyering <meyering@redhat.com>
4443
e1900994 4444 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4445 * fns.c (to_uchar): Define.
4446 (crypto_hash_function): Use it to convert some newly-signed
4447 variables to unsigned, to avoid sign-extension bugs. For example,
4448 without this change, (md5 "truc") would evaluate to
4449 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4450 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4451 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4452
0f6990a7
PE
44532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4454
4455 Integer overflow fixes.
c8a9ca5a 4456
08686060
PE
4457 * dbusbind.c: Serial number integer overflow fixes.
4458 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4459 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4460 to hold a serial number that is too large for a fixnum.
4461 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4462 Check for serial numbers out of range. Decode any serial number
59568bf0 4463 that was so large that it became a float. (Bug#8722)
08686060 4464
2d1fc3c7
PE
4465 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4466 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4467 Use XFASTINT rather than XUINT when numbers are nonnegative.
4468 (xd_append_arg, Fdbus_method_return_internal):
4469 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4470 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4471 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4472 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4473 (Bug#8722)
2d1fc3c7 4474
c8a9ca5a
PE
4475 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4476
519e1d69
PE
4477 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4478
30569699
PE
4479 ccl: add integer overflow checks
4480 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4481 (IN_INT_RANGE): New macros.
4482 (ccl_driver): Use them to check for integer overflow when
4483 decoding a CCL program. Many of the new checks are whether XINT (x)
4484 fits in int; it doesn't always, on 64-bit hosts. The new version
4485 doesn't catch all possible integer overflows, but it's an
847044ea 4486 improvement. (Bug#8719)
30569699 4487
c11285dc
PE
4488 * alloc.c (make_event_array): Use XINT, not XUINT.
4489 There's no need for unsigned here.
4490
fdccd48e
PE
4491 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4492 This follows up to the 2011-05-06 change that substituted uintptr_t
4493 for EMACS_INT. This case wasn't caught back then.
4494
37910ab2
PE
4495 Rework Fformat to avoid integer overflow issues.
4496 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4497 now (part of C89). Include <verify.h>.
4498 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4499 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4500 (Fformat): Avoid the prepass trying to compute sizes; it was only
4501 approximate and thus did not catch overflow reliably. Instead, walk
4502 through the format just once, formatting and computing sizes as we go,
4503 checking for integer overflow at every step, and allocating a larger
4504 buffer as needed. Keep track separately whether the format is
4505 multibyte. Keep only the most-recently calculated precision, rather
4506 than them all. Record whether each argument has been converted to
4507 string. Use EMACS_INT, not int, for byte and char and arg counts.
4508 Support field widths and precisions larger than INT_MAX. Avoid
4509 sprintf's undefined behavior with conversion specifications such as %#d
4510 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4511 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4512 formatting out-of-range floating point numbers with int
9173deec 4513 formats. (Bug#8668)
37910ab2 4514
2e6578fb
PE
4515 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4516
0ae6bdee
PE
4517 * data.c: Avoid integer truncation in expressions involving floats.
4518 * data.c: Include <intprops.h>.
4519 (arith_driver): When there's an integer overflow in an expression
4520 involving floating point, convert the integers to floating point
4521 so that the resulting value does not suffer from catastrophic
4522 integer truncation. For example, on a 64-bit host (* 4
4523 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4524 Do not rely on undefined behavior after integer overflow.
4525
de883a70
PE
4526 merge count_size_as_multibyte, parse_str_to_multibyte
4527 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4528 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4529 Check for integer overflow.
4530 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4531 since it's now a duplicate of the other. This is more of
4532 a character than a buffer op, so better that it's in character.c.
4533 * fns.c, print.c: Adjust to above changes.
4534
2ff916cb
PE
45352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4536
4537 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4538
f1b54466
PE
45392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4540
fb1ac845
PE
4541 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4542 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4543 (x_clipboard_manager_save): Now static.
4544 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4545
f1b54466
PE
4546 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4547 (crypto_hash_function): Now static.
4548 Fix pointer signedness problems. Avoid unnecessary initializations.
4549
a9f737ee
CY
45502011-05-27 Chong Yidong <cyd@stupidchicken.com>
4551
4552 * termhooks.h (Vselection_alist): Make it terminal-local.
4553
4554 * terminal.c (create_terminal): Initialize it.
4555
4556 * xselect.c: Support for clipboard managers.
4557 (Vselection_alist): Move to termhooks.h as terminal-local var.
4558 (LOCAL_SELECTION): New macro.
4559 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4560 (symbol_to_x_atom): Remove gratuitous arg.
4561 (x_handle_selection_request, lisp_data_to_selection_data)
4562 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4563 (x_own_selection, x_get_local_selection, x_convert_selection):
4564 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4565 (some_frame_on_display): Delete unused function.
4566 (Fx_own_selection_internal, Fx_get_selection_internal)
4567 (Fx_disown_selection_internal, Fx_selection_owner_p)
4568 (Fx_selection_exists_p): New optional frame arg.
4569 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4570 (x_handle_selection_clear): Don't treat other terminals with the
4571 same keyboard specially. Use the terminal-local Vselection_alist.
4572 (x_clear_frame_selections): Use Frun_hook_with_args.
4573
4574 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4575
4576 * xterm.h: Add support for those atoms.
4577
e067f0c1
CY
45782011-05-26 Chong Yidong <cyd@stupidchicken.com>
4579
4580 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4581 (converted_selections, conversion_fail_tag): New global variables.
4582 (x_selection_request_lisp_error): Free the above.
4583 (x_get_local_selection): Remove unnecessary code.
4584 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4585 of converted selections stored in converted_selections.
4586 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4587 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4588 (x_convert_selection): New function.
4589 (x_handle_selection_event): Simplify.
4590 (x_get_foreign_selection): Don't ignore incoming requests while
4591 waiting for an answer; this will fail when we implement
4592 SAVE_TARGETS, and seems unnecessary anyway.
4593 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4594 (Vx_sent_selection_functions): Doc fix.
4595
0f4aebc0
LL
45962011-05-26 Leo Liu <sdl.web@gmail.com>
4597
4598 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4599
e61124cd
YM
46002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4601
4602 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4603
4604 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4605 for fringe update if it has periodic bitmap.
ac389d0c 4606 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4607 and fringe_bitmap_periodic_p.
4608
4609 * fringe.c (get_fringe_bitmap_data): New function.
4610 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4611 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4612 row. Mark glyph row for fringe update if periodicity changed.
4613
4614 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4615 for fringe update unless it has periodic bitmap.
4616
f16d9837
KH
46172011-05-25 Kenichi Handa <handa@m17n.org>
4618
4619 * xdisp.c (get_next_display_element): Set correct it->face_id for
4620 a static composition.
4621
e1b90ef6
LL
46222011-05-24 Leo Liu <sdl.web@gmail.com>
4623
4624 * deps.mk (fns.o):
4625 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4626
4627 * fns.c (crypto_hash_function, Fsha1): New function.
4628 (Fmd5): Use crypto_hash_function.
4629 (syms_of_fns): Add Ssha1.
4630
7400048f
PE
46312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4632
4633 * gnutls.c: Remove unused macros.
4634 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4635 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4636 Remove macros that are defined and never used.
4637 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4638
abb71cf4
CY
46392011-05-22 Chong Yidong <cyd@stupidchicken.com>
4640
4641 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4642 (Fx_get_selection_internal): Minor cleanup.
4643 (Fx_own_selection_internal): Rename arguments for consistency with
4644 select.el.
4645
6307db39
PE
46462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4647
4648 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4649
f3d4e0a4
CY
46502011-05-22 Chong Yidong <cyd@stupidchicken.com>
4651
4652 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4653
4d8ade89
YM
46542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4655
4656 * dispnew.c (scrolling_window): Don't exclude the case that the
4657 last enabled row in the desired matrix touches the bottom boundary.
4658
32078c8d
GM
46592011-05-21 Glenn Morris <rgm@gnu.org>
4660
4661 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4662 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4663 and add some more files.
32078c8d 4664
7285dc67
EZ
46652011-05-20 Eli Zaretskii <eliz@gnu.org>
4666
4667 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4668 report_file_error introduced by the change from 2011-05-07.
4669
89d1bd22
PE
46702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4671
4672 * systime.h (Time): Define only if emacs is defined.
4673 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4674 where the include path doesn't have X11/X.h by default. See
4675 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4676
e23640bb 46772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4678
4679 * composite.c (find_automatic_composition): Fix previous change.
4680
b9704ad9
GM
46812011-05-20 Glenn Morris <rgm@gnu.org>
4682
4683 * lisp.mk: New file, split from Makefile.in.
4684 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4685 (shortlisp): Remove.
4686 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4687
4a720484
GM
46882011-05-19 Glenn Morris <rgm@gnu.org>
4689
4690 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4691 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4692 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4693 (lisp): Set the order to that of loadup.el.
4694 (shortlisp): Make it a copy of $lisp.
4695 (SOME_MACHINE_LISP): Remove.
4696 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4697 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4698
a28d4396
KH
46992011-05-18 Kenichi Handa <handa@m17n.org>
4700
4701 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4702 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4703 (find_automatic_composition): Mostly rewrite for efficiency.
4704
a2b1fa8e
JB
47052011-05-18 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * makefile.w32-in: Update dependencies.
4708
8e1f5610
CS
47092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4710
4711 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4712 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4713
7025ee00 47142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4715
cdfa6eab
PE
4716 Fix some integer overflow issues, such as string length overflow.
4717
06d6db33
PE
4718 * insdel.c (count_size_as_multibyte): Check for string overflow.
4719
2b4560a8
PE
4720 * character.c (lisp_string_width): Check for string overflow.
4721 Use EMACS_INT, not int, for string indexes and lengths; in
4722 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4723 the resulting string length overflows an EMACS_INT; instead,
4724 report a string overflow if no precision given. When checking for
4725 precision exhaustion, use a check that cannot possibly have
4726 integer overflow. (Bug#8675)
4727 * character.h (lisp_string_width): Adjust to new signature.
4728
cb93f9be
PE
4729 * alloc.c (string_overflow): New function.
4730 (Fmake_string): Use it. This doesn't change behavior, but saves
4731 a few bytes and will simplify future changes.
4732 * character.c (string_escape_byte8): Likewise.
4733 * lisp.h (string_overflow): New decl.
4734
1a1f3366
PE
4735 Fixups, following up to the user-interface timestamp change.
4736 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4737 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4738 * msdos.c (mouse_get_pos): Likewise.
4739 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4740 * w32gui.h (Time): Define by including "systime.h" rather than by
4741 declaring it ourselves. (Bug#8664)
4742
d4e3e4d3
PE
4743 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4744 * image.c (clear_image_cache): Likewise.
4745
f6a24d19
PE
4746 * term.c (term_mouse_position): Don't assume time_t wraparound.
4747
08dc5ae6
PE
4748 Be more systematic about user-interface timestamps.
4749 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4750 and sometimes 'EMACS_UINT', to represent these timestamps.
4751 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4752 This makes the code easier to follow, and makes it easier to catch
4753 integer overflow bugs such as Bug#8664.
4754 * frame.c (Fmouse_position, Fmouse_pixel_position):
4755 Use Time, not unsigned long, for user-interface timestamps.
4756 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4757 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4758 * keyboard.h (last_event_timestamp): Likewise.
4759 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4760 * menu.h (xmenu_show): Likewise.
4761 * term.c (term_mouse_position): Likewise.
4762 * termhooks.h (struct input_event.timestamp): Likewise.
4763 (struct terminal.mouse_position_hook): Likewise.
4764 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4765 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4766 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4767 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4768 what it was before.
4769 * menu.h, termhooks.h: Include "systime.h", for Time.
4770
8e55734a
PE
4771 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4772 Don't assume that the difference between two unsigned long values
4773 can fit into an integer. At this point, we know button_down_time
4774 <= event->timestamp, so the difference must be nonnegative, so
4775 there's no need to cast the result if double-click-time is
4776 nonnegative, as it should be; check that it's nonnegative, just in
4777 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4778 apart (about 25 days). (Bug#8664)
8e55734a 4779
841f1b75 4780 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4781 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4782
3e26f69c
PE
4783 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4784 that always fit in int. Use a sentinel instead of a counter, to
4785 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4786 * frame.h (struct frame): Use int for menu_bar_items_used
4787 instead of EMACS_INT, since it always fits in int.
3e26f69c 4788
5cc152c0
PE
4789 * menu.c (grow_menu_items): Check for int overflow.
4790
d89eb65e
PE
4791 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4792
5235bd3e
PE
4793 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4794 Before, the code was not consistent. These values cannot exceed
4795 2**31 - 1 so there's no need to make them unsigned.
4796 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4797 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4798 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4799 as modifiers.
4800 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4801
bc827e23
PE
4802 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4803 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4804 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4805 presumably because the widths might not match.
4806
78eb494e
PE
4807 * window.c (size_window): Avoid needless test at loop start.
4808
04f2d78b
CB
48092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4810
4811 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4812
d2fc7e3d 48132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4814
4815 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4816
d2fc7e3d 48172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4818
4819 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4820 `width' to `bar_area_x' and `bar_area_width', respectively.
4821 (x_scroll_run): Take account of fringe background extension.
4822
04f2d78b
CB
4823 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4824 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4825 `bar_area_width', respectively.
4826 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4827 background extension.
4828
79b70037
GM
48292011-05-10 Jim Meyering <meyering@redhat.com>
4830
4831 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4832
2f142cc5
JB
48332011-05-10 Juanma Barranquero <lekktu@gmail.com>
4834
4835 * image.c (Finit_image_library): Return t for built-in image types,
4836 like pbm and xbm. (Bug#8640)
4837
57679c86
AS
48382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4839
4840 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4841
888c9e86
EZ
48422011-05-07 Eli Zaretskii <eliz@gnu.org>
4843
b0512a1d
EZ
4844 * w32console.c (Fset_screen_color): Doc fix.
4845 (Fget_screen_color): New function.
4846 (syms_of_ntterm): Defsubr it.
4847
7285dc67
EZ
4848 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4849 unlink the temporary file if Fcall_process didn't create it in the
4850 first place.
4851 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4852 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4853 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4854 cue to call_process_cleanup not to close that handle.
4855
4d3fcc8e
BK
48562011-05-07 Ben Key <bkey76@gmail.com>
4857
4858 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4859 one of two shell specific rules, either bootstrap-temacs-CMD or
4860 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4861 to the previous implementation of the bootstrap-temacs rule.
4862 The bootstrap-temacs-CMD rule is similar to the previous
4863 implementation of the bootstrap-temacs rule except that it
4864 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4865 variable.
4866
4867 These changes, along with some changes to nt/configure.bat,
4868 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4869 earlier fix to add support for --cflags and --ldflags options
4870 that include quotes so that it works whether make uses cmd or
4871 sh as the shell.
4872
b4289b64
MA
48732011-05-06 Michael Albinus <michael.albinus@gmx.de>
4874
4875 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4876 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4877 is a constant.
4878 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4879 a string. Handle both cases.
4880 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4881 (Fdbus_register_method): Use Qinvalid_function.
4882
af4c0e28
JB
48832011-05-06 Juanma Barranquero <lekktu@gmail.com>
4884
4885 * makefile.w32-in: Update dependencies.
4886 (LISP_H): Add inttypes.h and stdin.h.
4887 (PROCESS_H): Add unistd.h.
4888
c51453d9
EZ
48892011-05-06 Eli Zaretskii <eliz@gnu.org>
4890
4891 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4892 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4893
8ff0ac3c 48942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4895
4c4b566b
PE
4896 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4897
aab2b9b5
PE
4898 * term.c (vfatal): Remove stray call to va_end.
4899 It's not needed and the C Standard doesn't allow it here anyway.
4900
c378da0b
PE
4901 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4902 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4903
288b08c7
PE
4904 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4905 bytes.
4906
e3601888
PE
4907 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4908
db6c0e74
PE
4909 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4910
dd5963ea
PE
4911 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4912
88c9450f
PE
4913 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4914
2f9442b8
PE
4915 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4916
c032b5f8
PE
4917 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4918 * charset.c (Fdefine_charset_internal): Don't initialize
4919 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4920 32-bit int (Bug#8600).
a108c10b
PE
4921
4922 * lread.c (read_integer): Be more consistent with string-to-number.
4923 Use string_to_number to do the actual conversion; this avoids
4924 rounding errors and fixes some other screwups. Without this fix,
4925 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4926 (digit_to_number): Move earlier, for benefit of read_integer.
4927 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4928 not a digit in any supported base. (Bug#8602)
a108c10b 4929
ad5f9eea
PE
4930 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4931
aec1708a
PE
4932 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4933 to match comment at start of function. This also removes a
4934 GCC warning about overflow in a 32+64-bit port.
4935
47be4ab5
PE
4936 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4937
371cac43
PE
4938 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4939 Reported by Stefan Monnier in
4940 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4941 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4942 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4943
d01a7826
PE
4944 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4945 (EMACS_UINTPTR): Likewise, with uintptr_t.
4946
7fd47d5c
PE
4947 * lisp.h: Prefer 64-bit EMACS_INT if available.
4948 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4949 on 32-bit hosts that have 64-bit int, so that they can access
4950 large files.
122b0c86
PE
4951 However, temporarily disable this change unless the temporary
4952 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4953
8727937b
PE
4954 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4955
8ac068ac
PE
4956 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4957 This removes an assumption that EMACS_INT and long are the same
4958 width as pointers. The assumption is true for Emacs porting targets
4959 now, but we want to make other targets possible.
4960 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4961 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4962 In the rest of the code, change types of integers that hold casted
4963 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4964 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4965 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4966 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4967 No need to cast type when ORing.
4968 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4969 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4970 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4971 assume EMACS_INT is the same width as char *.
4972 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4973 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4974 Remove no-longer-needed casts.
4975 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4976 (xg_tool_bar_help_callback, xg_make_tool_item):
4977 Use EMACS_INTPTR to hold an integer
4978 that will be cast to void *; this can avoid a GCC warning
4979 if EMACS_INT is not the same width as void *.
4980 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4981 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4982 (current_message_1, set_message_1):
4983 Use a local to convert to proper width without a cast.
4984 * xmenu.c (dialog_selection_callback): Likewise.
4985
ede49d71
PE
4986 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4987 Also, don't assume VALBITS / RAND_BITS is less than 5,
4988 and don't rely on undefined behavior when shifting a 1 left into
4989 the sign bit.
4990 * lisp.h (get_random): Change signature to match.
4991
2f30ecd0
PE
4992 * lread.c (hash_string): Use size_t, not int, for hash computation.
4993 Normally we prefer signed values; but hashing is special, because
4994 it's better to use unsigned division on hash table sizes so that
4995 the remainder is nonnegative. Also, size_t is the natural width
4996 for hashing into memory. The previous code used 'int', which doesn't
4997 retain enough info to hash well into very large tables.
4998 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4999
2a866e7b
PE
5000 * dbusbind.c: Don't possibly lose pointer info when converting.
5001 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5002 Use XPNTR rather than XHASH, so that the high-order bits of
5003 the pointer aren't lost when converting through void *.
5004
51639eac
PE
5005 * eval.c (Fautoload): Don't double-shift a pointer.
5006
92394119
PE
5007 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5008
dbdb9a7c
JB
50092011-05-06 Juanma Barranquero <lekktu@gmail.com>
5010
5011 * gnutls.c (DEF_GNUTLS_FN):
5012 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5013
db7a0b4f
AS
50142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5015
5016 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5017 marker. (Bug#8610)
5018
f7ff1b0f 50192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5020
5021 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5022 New version that can reserve upto 2GB of heap space.
5023
f7ff1b0f 50242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5025
5026 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5027
639c109b
TZ
50282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5029
5030 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5031 `gnutls_certificate_set_x509_key_file'.
5032
d2127135
JB
50332011-05-05 Juanma Barranquero <lekktu@gmail.com>
5034
5035 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5036 Update dependencies.
5037
e968f4f3
JB
50382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5039
5040 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5041 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5042 Remove unused parameter `fildes'.
5043 * process.c (read_process_output, send_process): Don't pass it.
5044
84d358f0
JB
50452011-05-04 Juanma Barranquero <lekktu@gmail.com>
5046
5047 Fix previous change: the library cache is defined in w32.c.
5048 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5049 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5050
0898ca10
JB
50512011-05-04 Juanma Barranquero <lekktu@gmail.com>
5052
5053 Implement dynamic loading of GnuTLS on Windows.
5054
5055 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5056 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5057 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5058 Declare.
5059
5060 * gnutls.c (Qgnutls_dll): Define.
5061 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5062 (gnutls_*): Declare function pointers.
5063 (init_gnutls_functions): New function to initialize function pointers.
5064 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5065 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5066 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5067 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5068 (emacs_gnutls_write, emacs_gnutls_read)
5069 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5070 (Fgnutls_available_p): New function.
5071 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5072 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5073 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5074
5075 * image.c: Include w32.h.
5076 (Vimage_type_cache): Delete.
5077 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5078 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5079 (w32_delayed_load): Move to w32.c.
5080
5081 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5082
5083 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5084 (w32_delayed_load): Move from image.c. When loading a library, record
5085 its filename in the :loaded-from property of the library id.
5086 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5087 Initialize and staticpro them.
5088 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5089
5090 * process.c: Include lisp.h before w32.h, not after.
5091 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5092 instead of gnutls_record_check_pending.
5093
5094 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5095
ff4de4aa
TZ
50962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5097
5098 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5099 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5100 as passed in.
5101
abe95abb
JD
51022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5103
5104 * xterm.c (x_set_frame_alpha): Do not set property on anything
5105 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5106
e16e55d4
JB
51072011-05-02 Juanma Barranquero <lekktu@gmail.com>
5108
5109 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5110
bafcf6a5
JB
51112011-05-02 Juanma Barranquero <lekktu@gmail.com>
5112
5113 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5114 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5115 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5116 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5117 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5118 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5119 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5120 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5121 (Qgnutls_bootprop_callbacks_verify): Make static.
5122
e7a6747f
AS
51232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5124
19ed11ba
AS
5125 * callproc.c: Indentation fixup.
5126
e7a6747f 5127 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5128 (wait_for_termination, interruptible_wait_for_termination):
5129 Move after wait_for_termination_1.
e7a6747f 5130
1ef14cb4
LMI
51312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5132
5133 * sysdep.c (interruptible_wait_for_termination): New function
5134 which is like wait_for_termination, but allows keyboard
5135 interruptions.
5136
5137 * callproc.c (Fcall_process): Add (:file "file") as an option for
5138 the STDOUT buffer.
5139 (Fcall_process_region): Ditto.
5140
330d880c
EZ
51412011-04-30 Eli Zaretskii <eliz@gnu.org>
5142
8db90b73
EZ
5143 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5144 rather than `XVECTOR (FOO)->size'.
5145
330d880c
EZ
5146 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5147 inttypes.h, as a gnulib replacement is used if it not available in
5148 system headers.
5149
15cbd324
EZ
51502011-04-21 Eli Zaretskii <eliz@gnu.org>
5151
5152 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5153 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5154 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5155
5156 * coding.c (coding_alloc_by_realloc): Error out if destination
5157 will grow beyond MOST_POSITIVE_FIXNUM.
5158 (decode_coding_emacs_mule): Abort if there isn't enough place in
5159 charbuf for the composition carryover bytes. Reserve an extra
5160 space for up to 2 characters produced in a loop.
5161 (decode_coding_iso_2022): Abort if there isn't enough place in
5162 charbuf for the composition carryover bytes.
5163
51642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5165
ae940cca
EZ
5166 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5167 aborting when %lld or %lll format is passed.
5168 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5169 %llo or %llx format is passed. (Bug#8545)
5170
03ab8921
EZ
5171 * window.c (window_scroll_line_based): Use a marker instead of
5172 simple variables to record original value of point. (Bug#7952)
5173
afda1437
EZ
5174 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5175 produced by %s or %c overflows available buffer space. (Bug#8545)
5176
f76dee0c
PE
51772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5178
5179 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5180 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5181
fdc5744d
JB
51822011-04-28 Juanma Barranquero <lekktu@gmail.com>
5183
5184 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5185
638f053a
JB
51862011-04-28 Juanma Barranquero <lekktu@gmail.com>
5187
5188 * keyboard.c (Qdelayed_warnings_hook): Define.
5189 (command_loop_1): Run `delayed-warnings-hook'
5190 if Vdelayed_warnings_list is non-nil.
5191 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5192 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5193
d178f871
EZ
51942011-04-28 Eli Zaretskii <eliz@gnu.org>
5195
5196 * doprnt.c (doprnt): Don't return value smaller than the buffer
5197 size if the message was truncated. (Bug#8545).
5198
b124fd93
JB
51992011-04-28 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5202 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5203
e810457d
PE
52042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5205
5206 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5207
ea51cceb
JB
52082011-04-27 Juanma Barranquero <lekktu@gmail.com>
5209
5210 * makefile.w32-in: Update dependencies.
5211
94dcfacf
EZ
52122011-04-27 Eli Zaretskii <eliz@gnu.org>
5213
5214 Improve `doprnt' and its usage. (Bug#8545)
5215 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5216 `format_end'. Remove support for %l as a conversion specifier.
5217 Don't use xrealloc. Improve diagnostics when the %l size modifier
5218 is used. Update the commentary.
5219
5220 * eval.c (verror): Simplify calculation of size_t.
5221
5222 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5223 messages.
5224
f61f41d7
PE
52252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5226
5227 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5228 change.
5229
96fb4434
PE
52302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5231
5232 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5233 This makes this file independent of the recent pseudovector change.
5234
671875da 52352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5236
69e9b5a3
PE
5237 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5238
b5f869a7 5239 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5240 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5241 Remove unused local.
c8926152 5242 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5243
841a1577 5244 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5245 GCC 4.6.0 optimizes based on type-based alias analysis.
5246 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5247 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5248 != &v->size, and therefore "v->size = 1; b->size = 2; return
5249 v->size;" must therefore return 1. This assumption is incorrect
5250 for Emacs, since it type-puns struct Lisp_Vector * with many other
5251 types. To fix this problem, this patch adds a new type struct
f904488f 5252 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5253 and pseudovectors, and helps optimizing compilers not get fooled
5254 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5255 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5256 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5257 the size member.
eab3844f
PE
5258 (XSETPVECTYPE): Rewrite in terms of new macro.
5259 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5260 This is a bit clearer, and further avoids the possibility of
5261 undesirable aliasing.
5262 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5263 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5264 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5265 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5266 (ASIZE): Now uses header.size rather than size.
5267 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5268 to avoid the hassle of writing XVECTOR (foo)->header.size.
5269 (struct vectorlike_header): New type.
eab3844f
PE
5270 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5271 object, to help avoid aliasing.
5272 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5273 (SUBRP): Likewise, since Lisp_Subr is a special case.
5274 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5275 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5276 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5277 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5278 changed to be "header.size" and "header.next".
5279 * buffer.h (struct buffer): Likewise.
5280 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5281 * frame.h (struct frame): Likewise.
5282 * process.h (struct Lisp_Process): Likewise.
5283 * termhooks.h (struct terminal): Likewise.
5284 * window.c (struct save_window_data, struct saved_window): Likewise.
5285 * window.h (struct window): Likewise.
5286 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5287 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5288 * buffer.c (init_buffer_once): Likewise.
5289 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5290 special case.
5291 * process.c (Fformat_network_address): Use local var for size,
5292 for brevity.
5293
0df1eac5
PE
5294 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5295
847ab9d1 5296 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5297 * data.c (atof): Remove decl; no longer used or needed.
5298 (digit_to_number): Move to lread.c.
5299 (Fstring_to_number): Use new string_to_number function, to be
5300 consistent with how the Lisp reader treats infinities and NaNs.
5301 Do not assume that floating-point numbers represent EMACS_INT
5302 without losing information; this is not true on most 64-bit hosts.
5303 Avoid double-rounding errors, by insisting on integers when
5304 parsing non-base-10 numbers, as the documentation specifies.
5305 * lisp.h (string_to_number): New decl, replacing ...
5306 (isfloat_string): Remove.
bc0a5c13 5307 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5308 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5309 appears to have been a coding error. Similarly, do not accept
5310 strings like +-1e0 as floating point numbers. Do not report
5311 overflow for integer overflows unless the base is not 10 which
5312 means we have no simple and reliable way to continue.
5313 Break out the floating-point parsing into a new
5314 function string_to_number, so that Fstring_to_number parses
5315 floating point numbers consistently with the Lisp reader.
04f2d78b 5316 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5317 (E_CHAR, EXP_INT): Remove, replacing with ...
5318 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5319 (string_to_number): New function, replacing isfloat_string.
5320 This function checks for valid syntax and produces the resulting
5321 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5322 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5323 so that overflow for non-base-10 numbers is reported only when
5324 there's no portable and simple way to convert to floating point.
452f4150 5325
67769ffc
PE
5326 * textprop.c (set_text_properties_1): Rewrite for clarity,
5327 and to avoid GCC warning about integer overflow.
5328
c20db43f
PE
5329 * intervals.h (struct interval): Use EMACS_INT for members
5330 where EMACS_UINT might cause problems. See
5331 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5332 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5333 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5334 All uses changed.
37aa2f85
PE
5335 (offset_intervals): Tell GCC not to worry about length overflow
5336 when negating a negative length.
c20db43f 5337
2538aa2f
PE
5338 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5339 (overrun_check_free): Likewise.
5340
f2d3008d
PE
5341 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5342 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5343 word size.
5344
ec8df744
PE
5345 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5346 (gnutls_make_error): Rename local to avoid shadowing.
5347 (gnutls_emacs_global_deinit): ifdef out; not used.
5348 (Fgnutls_boot): Use const for pointer to readonly storage.
5349 Comment out unused local. Fix pointer signedness problems.
5350
640ee02d
PE
5351 * lread.c (openp): Don't stuff size_t into an 'int'.
5352 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5353 about possible signed overflow.
5354
6048fb2a
PE
5355 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5356 (GDK_KEY_g): Don't define if already defined.
5357 (xg_prepare_tooltip): Avoid pointer signedness problem.
5358 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5359
fa3c87e1
PE
5360 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5361 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5362
2172544b
PE
5363 * xfns.c (Fx_window_property): Simplify a bit,
5364 to make a bit faster and to avoid GCC 4.6.0 warning.
5365 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5366
9b821a21
PE
5367 * fns.c (internal_equal): Don't assume size_t fits in int.
5368
3c616cfa
PE
5369 * alloc.c (compact_small_strings): Tighten assertion a little.
5370
c2982e87
PE
5371 Replace pEd with more-general pI, and fix some printf arg casts.
5372 * lisp.h (pI): New macro, generalizing old pEd macro to other
5373 conversion specifiers. For example, use "...%"pI"d..." rather
5374 than "...%"pEd"...".
5375 (pEd): Remove. All uses replaced with similar uses of pI.
5376 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5377 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5378 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5379 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5380 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5381 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5382 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5383 64-bit hosts.
5384 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5385 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5386 * print.c (safe_debug_print, print_object): Likewise.
5387 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5388 to int.
6f04d126
PE
5389 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5390 avoiding the 0 flag, which is not portable.
c2982e87
PE
5391 * process.c (Fmake_network_process): Use pI to avoid cast.
5392 * region-cache.c (pp_cache): Likewise.
5393 * xdisp.c (decode_mode_spec): Likewise.
5394 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5395 behavior on 64-bit hosts with printf arg.
6f04d126 5396 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5397 (x_stop_queuing_selection_requests): Likewise.
5398 (x_get_window_property): Don't truncate byte count to an 'int'
5399 when tracing.
0b432f21 5400
5e073ec7
PE
5401 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5402 here, since it parses constructs like leading '-' and spaces,
5403 which are not wanted; and it overflows with large numbers.
5404 Instead, simply match F[0-9]+, which is what is wanted anyway.
5405
36372bf9
PE
5406 * alloc.c: Remove unportable assumptions about struct layout.
5407 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5408 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5409 (allocate_vectorlike, make_pure_vector): Use the new macros,
5410 plus offsetof, to remove unportable assumptions about struct layout.
5411 These assumptions hold on all porting targets that I know of, but
5412 they are not guaranteed, they're easy to remove, and removing them
5413 makes further changes easier.
5414
0b432f21
PE
5415 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5416 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5417 (string_overrun_cookie): Now const. Use initializers that
5418 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5419 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5420 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5421 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5422 multiple of sizeof (EMACS_INT); it need not be, if
5423 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5424 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5425
895009e1
JB
54262011-04-26 Juanma Barranquero <lekktu@gmail.com>
5427
5428 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5429
6a7a1b0b
TZ
54302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5431
5432 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5433 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5434 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5435
841a1577 54362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5437
5438 * lisp.h (Qdebug): List symbol.
895009e1 5439 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5440 * keyboard.c (debug-on-event): New variable.
5441 (handle_user_signal): Break into debugger when debug-on-event
5442 matches the current signal symbol.
5443
f2d3ba6f
DN
54442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5445
5446 * alloc.c (check_sblock, check_string_bytes)
5447 (check_string_free_list): Convert to standard C.
5448
42ce4c63
TZ
54492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5450
5451 * w32.c (emacs_gnutls_push): Fix typo.
5452
825cd63c
EZ
54532011-04-25 Eli Zaretskii <eliz@gnu.org>
5454
fb11d64d
EZ
5455 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5456 "cast to pointer from integer of different size".
5457
825cd63c
EZ
5458 Improve doprnt and its use in verror. (Bug#8545)
5459 * doprnt.c (doprnt): Document the set of format control sequences
5460 supported by the function. Use SAFE_ALLOCA instead of always
5461 using `alloca'.
5462
5463 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5464 is one byte too soon. Don't use xrealloc; instead xfree and
5465 xmalloc anew.
5466
e061a11b
TZ
54672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5468
5469 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5470 callbacks stage.
5471
5472 * gnutls.c: Renamed global_initialized to
5473 gnutls_global_initialized. Added internals for the
5474 :verify-hostname-error, :verify-error, and :verify-flags
5475 parameters of `gnutls-boot' and documented those parameters in the
5476 docstring. Start callback support.
9173deec
JB
5477 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5478 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5479 on error. Return error code.
e061a11b
TZ
5480 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5481 (emacs_gnutls_read): Likewise.
5482 (Fgnutls_boot): Return handshake error code.
5483 (emacs_gnutls_handle_error): New function.
5484 (wsaerror_to_errno): Likewise.
5485
5486 * w32.h (emacs_gnutls_pull): Add prototype.
5487 (emacs_gnutls_push): Likewise.
5488
5489 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5490 (emacs_gnutls_push): Likewise.
5491
54922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5493
5494 * process.c (wait_reading_process_output): Check if GnuTLS
5495 buffered some data internally if no FDs are set for TLS
5496 connections.
5497
5498 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5499 (LIBS): Link to USER_LIBS.
5500 ($(BLD)/gnutls.$(0)): New target.
5501
fa6996bc
EZ
55022011-04-24 Eli Zaretskii <eliz@gnu.org>
5503
eb35682e
EZ
5504 * xdisp.c (handle_single_display_spec): Rename the
5505 display_replaced_before_p argument into display_replaced_p, to
5506 make it consistent with the commentary. Fix typos in the
5507 commentary.
5508
e2ad650c
EZ
5509 * textprop.c (syms_of_textprop): Remove dead code.
5510 (copy_text_properties): Delete obsolete commentary about an
5511 interface that was deleted long ago. Fix typos in the description
5512 of arguments.
5513
1b2de274
EZ
5514 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5515 to changes in oldXMenu/XMenu.h from 2011-04-16.
5516 <menu_help_message, prev_menu_help_message>: Constify.
5517 (IT_menu_make_room): menu->help_text is now `const char **';
5518 adjust.
5519
5520 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5521 to changes in oldXMenu/XMenu.h from 2011-04-16.
5522 (struct XMenu): Declare `help_text' `const char **'.
5523
5524 * xfaces.c <Qunspecified>: Make extern again.
5525
5526 * syntax.c: Include sys/types.h before including regex.h, as
5527 required by Posix.
5528
762b15be
EZ
5529 * doc.c (get_doc_string): Improve the format passed to `error'.
5530
5531 * doprnt.c (doprnt): Improve commentary.
5532
5533 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5534
5535 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5536 them with etags.
5537
f1052e5d
EZ
5538 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5539 changes in globals.h immediately force recompilation.
762b15be
EZ
5540 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5541 $(CURDIR)/s/ms-w32.h.
5542 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5543
fa6996bc
EZ
5544 * character.c (Fchar_direction): Function deleted.
5545 (syms_of_character): Don't defsubr it.
5546 <char-direction-table>: Deleted.
5547
e6c3da20
EZ
55482011-04-23 Eli Zaretskii <eliz@gnu.org>
5549
5550 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5551 * doprnt.c: Include limits.h.
5552 (SIZE_MAX): New macro.
04f2d78b
CB
5553 (doprnt): Return a size_t value. 2nd arg is now size_t.
5554 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5555 Improve overflow protection. Support `l' modifier for integer
5556 conversions. Support %l conversion. Don't assume an EMACS_INT
5557 argument for integer conversions and for %c.
5558
5559 * lisp.h (doprnt): Restore prototype.
5560
5561 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5562 $(SRC)/character.h.
5563
5564 * Makefile.in (base_obj): Add back doprnt.o.
5565
5566 * deps.mk (doprnt.o): Add back prerequisites.
5567 (callint.o): Depend on character.h.
5568
5569 * eval.c (internal_lisp_condition_case): Include the handler
5570 representation in the error message.
5571 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5572 when breaking from the loop.
5573
5574 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5575
5576 * callint.c (Fcall_interactively): When displaying error message
5577 about invalid control letter, pass the character's codepoint, not
5578 a pointer to its multibyte form. Improve display of the character
5579 in octal and display also its hex code.
5580
5581 * character.c (char_string): Use %x to display the (unsigned)
5582 codepoint of an invalid character, to avoid displaying a bogus
5583 negative value.
5584
5585 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5586 `error', not SYMBOL_NAME itself.
5587
5588 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5589 character arguments to `error'.
5590
5591 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5592 to `error' in error message about FINAL_CHAR argument. Make sure
5593 FINAL_CHAR is a character, and use %c when it is passed as
5594 argument to `error'.
5595
4ffd0d6b 55962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5597
5598 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5599
5600 * w32.c: Include <time.h>.
5601 (sys_localtime): New function.
5602
4ffd0d6b 56032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5604
5605 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5606
4ffd0d6b 5607 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5608
4ffd0d6b 56092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5610
4ffd0d6b
GM
5611 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5612 zombies (Bug#8467).
aac0c6e3 5613
04c56954
EZ
56142011-04-19 Eli Zaretskii <eliz@gnu.org>
5615
5616 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5617 gl_state.e_property when gl_state.object is Qt.
5618
5619 * insdel.c (make_gap_larger): Remove limitation of buffer size
5620 to <= INT_MAX.
5621
16a43933
CY
56222011-04-18 Chong Yidong <cyd@stupidchicken.com>
5623
5624 * xdisp.c (lookup_glyphless_char_display)
5625 (produce_glyphless_glyph): Handle cons cell entry in
5626 glyphless-char-display.
5627 (Vglyphless_char_display): Document it.
5628
5629 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5630 glyphless-char-display.
5631
4581706e
CY
56322011-04-17 Chong Yidong <cyd@stupidchicken.com>
5633
5634 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5635
5636 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5637
5638 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5639 definition for no-X builds.
5640
4887c6e2 56412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5642
fd35b6f9
PE
5643 Static checks with GCC 4.6.0 and non-default toolkits.
5644
5c1ccb01
PE
5645 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5646
006c5daa
PE
5647 * process.c (keyboard_bit_set): Define only if SIGIO.
5648 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5649 (send_process): Repair possible setjmp clobbering.
5650
efc736d3
PE
5651 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5652
4e2fe2e6
PE
5653 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5654
f97334a2
PE
5655 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5656
4e75f29d
PE
5657 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5658 Define only if needed.
5659
90efadd1
PE
5660 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5661 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5662 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5663
3c647824
PE
5664 * dispextern.h (struct redisplay_interface): Rename param
5665 to avoid shadowing.
e264f262 5666 * termhooks.h (struct terminal): Likewise.
761383f4 5667 * xterm.c (xembed_send_message): Likewise.
3c647824 5668
b58c5c4a
PE
5669 * insdel.c (make_gap_smaller): Define only if
5670 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5671
cad59032
PE
5672 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5673 it.
5674
c339dc2e
PE
5675 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5676 so that we aren't warned about unused symbols.
5677
91a3e27b
PE
5678 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5679
399c71d3 5680 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5681
8ffc96f5
PE
5682 * xfns.c (x_real_positions): Mark locals as initialized.
5683
eef9bc79
PE
5684 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5685
098db9dd
PE
5686 * xterm.c: Fix problems found by static analysis with other toolkits.
5687 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5688 (x_dispatch_event): Declare static if USE_GTK, and
5689 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5690 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5691 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5692 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5693 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5694
eb18f6cc
PE
5695 * xmenu.c (menu_help_callback): Pointer type fixes.
5696 Use const pointers when pointing at readonly data. Avoid pointer
5697 signedness clashes.
5698 (FALSE): Remove unused macro.
5699 (update_frame_menubar): Remove unused decl.
5700
1fe72bf8
PE
5701 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5702
60d9e1db
PE
5703 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5704 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5705 (single_menu_item): Rename local to avoid shadowing.
5706
39261c26
PE
5707 * keyboard.c (make_lispy_event): Remove unused local var.
5708
018c5e19
PE
5709 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5710 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5711
63d2b86e
PE
5712 * bitmaps: Change bitmaps from unsigned char back to the X11
5713 compatible char. Avoid the old compiler warnings about
5714 out-of-range initializers by using, for example, '\xab' rather
5715 than 0xab.
5716
aefd87e1
PE
5717 * xgselect.c (xgselect_initialize): Check vs interface
5718 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5719
bf501fb9
PE
5720 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5721
e9829fdf
PE
5722 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5723 to read-only memory.
5724
1086c095
PE
5725 * fns.c (vector): Remove; this old hack is no longer needed.
5726
2baccd04 5727 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5728 Remove unused var.
dde42981 5729 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5730
72391843 5731 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5732
436c16df 5733 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5734 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5735 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5736
92bb796d 5737 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5738 (x_term_init): Remove local to avoid shadowing.
92bb796d 5739
764430a3 5740 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5741
5742 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5743 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5744
d1dfb56c
EZ
57452011-04-16 Eli Zaretskii <eliz@gnu.org>
5746
c4354cb4
EZ
5747 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5748
d1dfb56c
EZ
5749 Fix regex.c, syntax.c and friends for buffers > 2GB.
5750 * syntax.h (struct gl_state_s): Declare character position members
5751 EMACS_INT.
5752
5753 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5754
04f2d78b
CB
5755 * textprop.c (verify_interval_modification, interval_of):
5756 Declare arguments EMACS_INT.
d1dfb56c
EZ
5757
5758 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5759 EMACS_INT.
5760
5761 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5762
5763 * indent.c (Fvertical_motion): Local variable it_start is now
5764 EMACS_INT.
5765
5766 * regex.c (re_match, re_match_2, re_match_2_internal)
5767 (bcmp_translate, regcomp, regexec, print_double_string)
5768 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5769 (re_compile_pattern, re_exec): Declare arguments and local
5770 variables `size_t' and `ssize_t' and return values `regoff_t', as
5771 appropriate.
5772 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5773 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5774 <compile_stack_type>: `size' and `avail' are now `size_t'.
5775
5776 * regex.h <regoff_t>: Use ssize_t, not int.
5777 (re_search, re_search_2, re_match, re_match_2): Arguments that
5778 specify buffer/string position and length are now ssize_t and
5779 size_t. Return type is regoff_t.
5780
613052cd
BK
57812011-04-16 Ben Key <bkey76@gmail.com>
5782
5783 * nsfont.m: Fixed bugs in ns_get_family and
5784 ns_descriptor_to_entity that were caused by using free to
5785 deallocate memory blocks that were allocated by xmalloc (via
5786 xstrdup). This caused Emacs to crash when compiled with
5787 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5788 --enable-checking=xmallocoverrun). xfree is now used to
5789 deallocate these memory blocks.
5790
4170f62f 57912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5792
71b41406
PE
5793 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5794
9587a89d
PE
5795 emacs_write: Accept and return EMACS_INT for sizes.
5796 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5797 et seq.
5798 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5799 Accept and return EMACS_INT.
5800 (emacs_gnutls_write): Return the number of bytes written on
5801 partial writes.
5802 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5803 (emacs_read, emacs_write): Remove check for negative size, as the
5804 Emacs source code has been audited now.
9587a89d
PE
5805 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5806 (emacs_read, emacs_write): Use it.
273a5f82
PE
5807 * process.c (send_process): Adjust to the new signatures of
5808 emacs_write and emacs_gnutls_write. Do not attempt to store
5809 a byte offset into an 'int'; it might overflow.
9587a89d 5810 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5811
3e047f51
PE
5812 * sound.c: Don't assume sizes fit in 'int'.
5813 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5814 Return EMACS_INT, not int.
3e047f51 5815 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5816 Accept EMACS_INT, not int.
5817 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5818 record read return values.
5819
cc39a9db
BK
58202011-04-15 Ben Key <bkey76@gmail.com>
5821
c9d0ec6d
JB
5822 * keyboard.c (Qundefined): Don't declare static since it is used
5823 in nsfns.m.
5824 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5825 static since they are used in nsfont.m.
cc39a9db 5826
6c60eb9f
SM
58272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5828
5829 * process.c (Qprocessp): Don't declare static.
5830 * lisp.h (Qprocessp): Declare again.
5831
7990b61a
JB
58322011-04-15 Juanma Barranquero <lekktu@gmail.com>
5833
5834 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5835
5d4cb038
PE
58362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5837
8bd7b830 5838 Improve C-level modularity by making more things 'static'.
cd64ea1d 5839
e3b27b31
PE
5840 Don't publish debugger-only interfaces to other modules.
5841 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5842 (verify_bytepos, count_markers): Move decls to the only modules
5843 that need them.
5844 * region-cache.h (pp_cache): Likewise.
5845 * window.h (check_all_windows): Likewise.
5846 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5847
5d4cb038
PE
5848 * sysdep.c (croak): Now static, if
5849 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5850 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5851
5852 * alloc.c (refill_memory_reserve): Now static if
5853 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5854 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5855
e87b6180
PE
5856 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5857 Define only if USE_LUCID.
5858
ac64929e
PE
5859 * xrdb.c (x_customization_string, x_rm_string): Now static.
5860
6f37259d
PE
5861 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5862 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5863
1683e3ab
PE
5864 * xdisp.c (draw_row_with_mouse_face): Now static.
5865 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5866
de9c2632
PE
5867 * window.h (check_all_windows): Mark externally visible.
5868
2b96acb7
PE
5869 * window.c (window_deletion_count): Now static.
5870
5871 * undo.c: Make symbols static if they're not exported.
5872 (last_undo_buffer, last_boundary_position, pending_boundary):
5873 Now static.
5874
50436f33
PE
5875 * textprop.c (interval_insert_behind_hooks): Now static.
5876 (interval_insert_in_front_hooks): Likewise.
5877
64520e5c
PE
5878 * term.c: Make symbols static if they're not exported.
5879 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5880 (max_frame_lines, tty_set_terminal_modes):
5881 (tty_reset_terminal_modes, tty_turn_off_highlight):
5882 (get_tty_terminal): Now static.
5883 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5884 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5885 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5886 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5887 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5888
1fa53021
PE
5889 * sysdep.c: Make symbols static if they're not exported.
5890 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5891 Now static.
5892 (sigprocmask_set, full_mask): Remove; unused.
5893 (wait_debugging): Mark as visible.
5894 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5895 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5896
d4b43b22
PE
5897 * syntax.c (syntax_temp): Define only if !__GNUC__.
5898
b7c513d0
PE
5899 * sound.c (current_sound_device, current_sound): Now static.
5900
989b29ad
PE
5901 * search.c (searchbufs, searchbuf_head): Now static.
5902
13a55a78
PE
5903 * scroll.c (scroll_cost): Remove; unused.
5904 * dispextern.h (scroll_cost): Remove decl.
5905
de68a1fc
PE
5906 * region-cache.h (pp_cache): Mark as externally visible.
5907
40ccffa6
PE
5908 * process.c: Make symbols static if they're not exported.
5909 (process_tick, update_tick, create_process, chan_process):
5910 (Vprocess_alist, proc_buffered_char, datagram_access):
5911 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5912 (deactivate_process): Mark defn as static, as well as decl.
5913 * lisp.h (create_process): Remove decl.
5914 * process.h (chan_process, Vprocess_alist): Remove decls.
5915
ad64fc97
PE
5916 * print.c: Make symbols static if they're not exported.
5917 (print_depth, new_backquote_output, being_printed, print_buffer):
5918 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5919 (print_interval, print_number_index, initial_stderr_stream):
5920 Now static.
5921 * lisp.h (Fprinc): Remove decl.
5922 (debug_output_compilation_hack): Mark as externally visible.
5923
adddb265
PE
5924 * sysdep.c (croak): Move decl from here to syssignal.h.
5925 * syssignal.h (croak): Put it here, so the API can be checked when
5926 'croak' is called from dissociate_if_controlling_tty.
5927
1717ede2
PE
5928 * minibuf.c: Make symbols static if they're not exported.
5929 (minibuf_save_list, choose_minibuf_frame): Now static.
5930 * lisp.h (choose_minibuf_frame): Remove decl.
5931
fa5fb2bc
PE
5932 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5933
1e3890d1
PE
5934 * lread.c: Make symbols static if they're not exported.
5935 (read_objects, initial_obarray, oblookup_last_bucket_number):
5936 Now static.
5937 (make_symbol): Remove; unused.
5938 * lisp.h (initial_obarray, make_symbol): Remove decls.
5939
8a1414fa
PE
5940 * keyboard.c: Make symbols static if they're not exported.
5941 (single_kboard, recent_keys_index, total_keys, recent_keys):
5942 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5943 (this_single_command_key_start, echoing, last_auto_save):
5944 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5945 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5946 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5947 (Vlispy_mouse_stem, double_click_count):
5948 Now static.
5949 (force_auto_save_soon): Define only if SIGDANGER.
5950 (ignore_mouse_drag_p): Now static if
5951 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5952 (print_help): Remove; unused.
5953 (stop_character, last_timer_event): Mark as externally visible.
5954 * keyboard.h (ignore_mouse_drag_p): Declare only if
5955 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5956 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5957 * lisp.h (echoing): Remove decl.
5958 (force_auto_save_soon): Declare only if SIGDANGER.
5959 * xdisp.c (redisplay_window): Simplify code, to make it more
5960 obvious that ignore_mouse_drag_p is not accessed if !defined
5961 USE_GTK && !defined HAVE_NS.
5962
93ea6e8f
PE
5963 * intervals.c: Make symbols static if they're not exported.
5964 (merge_properties_sticky, merge_interval_right, delete_interval):
5965 Now static.
5966 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5967
77382fcc
PE
5968 * insdel.c: Make symbols static if they're not exported.
5969 However, leave prepare_to_modify_buffer alone. It's never
5970 called from outside this function, but that appears to be a bug.
5971 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5972 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5973 (adjust_after_replace_noundo): Remove; unused.
5974 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5975 (signal_before_change): Remove decls.
77382fcc 5976
9306c32e
PE
5977 * indent.c (val_compute_motion, val_vmotion): Now static.
5978
cd44d2eb
PE
5979 * image.c: Make symbols static if they're not exported.
5980 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5981 if USE_GTK.
5982 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5983 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5984
ad9a7a06
PE
5985 * fringe.c (standard_bitmaps): Now static.
5986 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5987
81626931
PE
5988 * frame.c: Make symbols static if they're not exported.
5989 (x_report_frame_params, make_terminal_frame): Now static.
5990 (get_frame_param): Now static, unless HAVE_NS.
5991 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5992 (x_get_resource_string): Remove; not used.
5993 * frame.h (make_terminal_frame, x_report_frame_params):
5994 (x_get_resource_string); Remove decls.
5995 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5996 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5997
239f9db9
PE
5998 * font.c, fontset.c: Make symbols static if they're not exported.
5999 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6000 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6001 * font.c (font_close_object): Now static.
6002 * font.h (font_close_object): Remove.
6003 * fontset.c (FONTSET_OBJLIST): Remove.
6004 (free_realized_fontset) #if-0 the body, which does nothing.
6005 (face_suitable_for_char_p): #if-0, as it's never called.
6006 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6007 * xfaces.c (face_at_string_position):
6008 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6009 since 0 is always ASCII.
6010
dfcf3579
PE
6011 * fns.c (weak_hash_tables): Now static.
6012
5045092b
PE
6013 * fileio.c: Make symbols static if they're not exported.
6014 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6015 (Vwrite_region_annotation_buffers): Now static.
6016
57a96f5c
PE
6017 * eval.c: Make symbols static if they're not exported.
6018 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6019 * lisp.h (backtrace_list): Remove decl.
6020
35f08c38
PE
6021 * emacs.c: Make symbols static if they're not exported.
6022 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6023 (fatal_error_code, fatal_error_signal_hook, standard_args):
6024 Now static.
6025 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6026 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6027 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6028 * lisp.h (fatal_error_signal_hook): Remove decl.
6029 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6030
f44bd759
PE
6031 * editfns.c: Move a (normally-unused) function to its only use.
6032 * editfns.c, lisp.h (get_operating_system_release): Remove.
6033 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6034 worth the hassle of breaking this out.
6035
b532497d
PE
6036 * xterm.c: Make symbols static if they're not exported.
6037 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6038 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6039 (x_destroy_window, x_delete_display):
6040 Now static.
6041 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6042 (x_mouse_leave): Remove; unused.
6043 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6044 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6045 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6046 Remove decls.
6047 (x_mouse_leave): Declare only if WINDOWSNT.
6048 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6049 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6050 USE_X_TOOLKIT.
6051
1675728f
PE
6052 * ftxfont.c: Make symbols static if they're not exported.
6053 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6054 HAVE_FREETYPE.
6055 * font.h (ftxfont_driver): Likewise.
6056
e4cebfca
PE
6057 * xfns.c: Make symbols static if they're not exported.
6058 (x_last_font_name, x_display_info_for_name):
6059 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6060 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6061 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6062 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6063 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6064 (last_show_tip_args): Now static.
6065 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6066 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6067 (x_screen_planes): Remove; unused.
6068 * dispextern.h (x_screen_planes): Remove decl.
6069
5bf46f05
PE
6070 * dispnew.c: Make symbols static if they're not exported.
6071 * dispextern.h (redraw_garbaged_frames, scrolling):
6072 (increment_row_positions): Remove.
6073 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6074 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6075 Now static.
6076 (redraw_garbaged_frames): Remove; unused.
6077
435f4c28
PE
6078 * xfaces.c: Make symbols static if they're not exported.
6079 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6080 Remove decls.
6081 * xterm.h (defined_color): Remove decls.
6082 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6083 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6084 (menu_face_changed_default, defined_color, free_realized_face):
6085 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6086 (ascii_face_of_lisp_face): Remove; unused.
6087
8524aef3
PE
6088 * xdisp.c: Make symbols static if they're not exported.
6089 * dispextern.h (scratch_glyph_row, window_box_edges):
6090 (glyph_to_pixel_coords, set_cursor_from_row):
6091 (get_next_display_element, set_iterator_to_next):
6092 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6093 (show_mouse_face): Remove decls
6094 * frame.h (message_buf_print): Likewise.
6095 * lisp.h (pop_message, set_message, check_point_in_composition):
6096 Likewise.
6097 * xterm.h (set_vertical_scroll_bar): Likewise.
6098 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6099 (message_buf_print, scratch_glyph_row, displayed_buffer):
6100 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6101 (get_next_display_element, show_mouse_face, window_box_edges):
6102 (frame_to_window_pixel_xy, check_point_in_composition):
6103 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6104 (glyph_to_pixel_coords): Remove; unused.
6105
16390cd2
PE
6106 * dired.c (file_name_completion): Now static.
6107
6108 * dbusbind.c (xd_in_read_queued_messages): Now static.
6109
a25f4dfa
PE
6110 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6111 * data.c (circular_list_error): Remove.
6112
14a9c8df
PE
6113 * commands.h (last_point_position, last_point_position_buffer):
6114 (last_point_position_window): Remove decls.
6115 * keyboard.c: Make these variables static.
6116
04f2d78b
CB
6117 * coding.h (coding, code_convert_region, encode_coding_gap):
6118 Remove decls.
74ab6df5
PE
6119 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6120 (iso_code_class, detect_coding, code_convert_region): Now static.
6121 (encode_coding_gap): Remove; unused.
6122
38dfbee1
PE
6123 * chartab.c (chartab_chars, chartab_bits): Now static.
6124
a2cb4e63
PE
6125 * charset.h (charset_iso_8859_1): Remove decl.
6126 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6127 Now static.
6128
127198fd
PE
6129 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6130 * ccl.c (Vccl_program_table): Now static.
6131 (check_ccl_update): Remove; unused.
6132
d85b608f
PE
6133 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6134 * category.h: ... from here.
6135 * category.c (check_category_table, set_category_set): Now static.
6136
31cd66f3
PE
6137 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6138 * lisp.h: Remove these decls.
6139
c358e587
PE
6140 * buffer.c (buffer_count): Remove unused var.
6141
e78aecca
PE
6142 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6143 so that it's not optimized away.
6144 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6145 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6146 exported only to the debugger.
6147
e192d7d3 6148 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6149 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6150
92470028
PE
6151 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6152 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6153 was inaccessible from Lisp.
6154 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6155 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6156
244ed907
PE
6157 alloc.c: Import and export fewer symbols, and remove unused items.
6158 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6159 is defined.
6160 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6161 it's not optimized away by whole-program optimization.
6162 (message_enable_multibyte, free_misc): Remove.
6163 (catchlist, handlerlist, mark_backtrace):
6164 Declare only if BYTE_MARK_STACK.
6165 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6166 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6167 (message_enable_multibyte): Remove decl.
6168 (free_misc, interval_free_list, float_block, float_block_index):
6169 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6170 (cons_free_list, last_marked_index):
6171 Now static.
6172 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6173 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6174 (mark_backtrace): Define only if BYTE_MARK_STACK.
6175 * xdisp.c (message_enable_multibyte): Now static.
6176
61c2b50e 6177 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6178 This makes it easier for human readers (and static analyzers)
6179 to see whether these variables are used from other modules.
6180 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6181 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6182 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6183 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6184 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6185 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6186 * xmenu.c, xselect.c:
6187 Declare Q* vars static if they are not used in other modules.
6188 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6189 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6190 Remove decls of unexported vars.
6191 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6192
95c82688
PE
6193 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6194
16a97296
PE
6195 Make Emacs functions such as Fatom 'static' by default.
6196 This makes it easier for human readers (and static analyzers)
6197 to see whether these functions can be called from other modules.
6198 DEFUN now defines a static function. To make the function external
6199 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6200 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6201 (Finit_image_library):
16a97296
PE
6202 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6203 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6204 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6205 Remove decls, since these functions are now static.
6206 (Funintern, Fget_internal_run_time): New decls, since these functions
6207 were already external.
95c82688 6208
16a97296
PE
6209 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6210 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6211 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6212 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6213 * keyboard.c, keymap.c, lread.c:
6214 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6215 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6216 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6217 Mark functions with DEFUE instead of DEFUN,
6218 if they are used in other modules.
6219 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6220 decls for now-static functions.
6221 * buffer.h (Fdelete_overlay): Remove decl.
6222 * callproc.c (Fgetenv_internal): Mark as internal.
6223 * composite.c (Fremove_list_of_text_properties): Remove decl.
6224 (Fcomposition_get_gstring): New forward static decl.
6225 * composite.h (Fcomposite_get_gstring): Remove decl.
6226 * dired.c (Ffile_attributes): New forward static decl.
6227 * doc.c (Fdocumntation_property): New forward static decl.
6228 * eval.c (Ffetch_bytecode): New forward static decl.
6229 (Funintern): Remove extern decl; now in .h file where it belongs.
6230 * fileio.c (Fmake_symbolic_link): New forward static decl.
6231 * image.c (Finit_image_library): New forward static decl.
6232 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6233 * intervals.h (Fprevious_property_change):
6234 (Fremove_list_of_text_properties): Remove decls.
6235 * keyboard.c (Fthis_command_keys): Remove decl.
6236 (Fcommand_execute): New forward static decl.
6237 * keymap.c (Flookup_key): New forward static decl.
6238 (Fcopy_keymap): Now static.
6239 * keymap.h (Flookup_key): Remove decl.
6240 * process.c (Fget_process): New forward static decl.
6241 (Fprocess_datagram_address): Mark as internal.
6242 * syntax.c (Fsyntax_table_p): New forward static decl.
6243 (skip_chars): Remove duplicate decl.
6244 * textprop.c (Fprevious_property_change): New forward static decl.
6245 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6246 Now internal.
6247 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6248 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6249
785bbd42
PE
6250 * editfns.c (Fformat): Remove unreachable code.
6251
8b913b57
AS
62522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6253
6254 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6255 change. (Bug#8496)
6256
a6744a35
EZ
62572011-04-13 Eli Zaretskii <eliz@gnu.org>
6258
6259 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6260 when at ZV. (Bug#8487)
6261
e7974947
AS
62622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6263
baad03f0
AS
6264 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6265 (Bug#8437)
6266 * keyboard.c (parse_tool_bar_item): Likewise.
6267 * sound.c (sound_cleanup, alsa_close): Likewise.
6268 * termcap.c (tgetent): Likewise.
6269 * xfns.c (x_default_font_parameter): Likewise.
6270 * xsettings.c (read_and_apply_settings): Likewise.
6271
e7974947
AS
6272 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6273 (overrun_check_free): Protoize.
6274
28272684
PE
62752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6276
6277 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6278 since callers should never pass a negative size.
6279 Change the signature to match that of plain 'read' and 'write'; see
6280 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6281 * lisp.h: Update prototypes of emacs_write and emacs_read.
6282
11997c76
EZ
62832011-04-11 Eli Zaretskii <eliz@gnu.org>
6284
6285 * xdisp.c (redisplay_window): Don't try to determine the character
6286 position of the scroll margin if the window start point w->startp
e896f03c 6287 is outside the buffer's accessible region. (Bug#8468)
11997c76 6288
8a2cbd72
EZ
62892011-04-10 Eli Zaretskii <eliz@gnu.org>
6290
6291 Fix write-region and its subroutines for buffers > 2GB.
6292 * fileio.c (a_write, e_write): Modify declaration of arguments and
6293 local variables to support buffers larger than 2GB.
6294 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6295
6296 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6297 argument, local variables, and return value.
6298
6299 * lisp.h: Update prototypes of emacs_write and emacs_read.
6300
6301 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6302
4073e537 63032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6304
1ebfdcb6
PE
6305 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6306
b2ded58d
PE
6307 Fix more problems found by GCC 4.6.0's static checks.
6308
7d66342c
PE
6309 * xdisp.c (vmessage): Use a better test for character truncation.
6310
bbf47d44
PE
6311 * charset.c (load_charset_map): <, not <=, for optimization,
6312 and to avoid potential problems with integer overflow.
9248994d 6313 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6314 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6315 * editfns.c (Fformat): Likewise.
1e69125e 6316 * syntax.c (skip_chars): Likewise.
3befa583 6317
e3019616
PE
6318 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6319 This also lets GCC 4.6.0 generate slightly better loop code.
6320
becfa255
PE
6321 * callint.c (Fcall_interactively): <, not <=, for optimization.
6322 (Fcall_interactively): Count the number of arguments produced,
6323 not the number of arguments given. This is simpler and lets GCC
6324 4.6.0 generate slightly better code.
6325
dae0cd48
PE
6326 * ftfont.c: Distingish more carefully between FcChar8 and char.
6327 The previous code passed unsigned char * to a functions like
6328 strlen and xstrcasecmp that expect char *, which does not
6329 conform to the C standard.
6330 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6331 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6332 char * when the C standard requires it.
6333
76032d70
PE
6334 * keyboard.c (read_char): Remove unused var.
6335
eb3f1cc8
PE
6336 * eval.c: Port to Windows vsnprintf (Bug#8435).
6337 Include <limits.h>.
6338 (SIZE_MAX): Define if the headers do not.
6339 (verror): Do not give up if vsnprintf returns a negative count.
6340 Instead, grow the buffer. This ports to Windows vsnprintf, which
6341 does not conform to C99. Problem reported by Eli Zaretskii.
6342 Also, simplify the allocation scheme, by avoiding the need for
6343 calling realloc, and removing the ALLOCATED variable.
6344
70476b54
PE
6345 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6346
12020a9e
PE
6347 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6348 But keep the doprint source code for now, as we might revamp it
6349 and use it again (Bug#8435).
ea6c7ae6
PE
6350 * lisp.h (doprnt): Remove.
6351 * Makefile.in (base_obj): Remove doprnt.o.
6352 * deps.mk (doprnt.o): Remove.
6353
5fdb398c
PE
6354 error: Print 32- and 64-bit integers portably (Bug#8435).
6355 Without this change, on typical 64-bit hosts error ("...%d...", N)
6356 was used to print both 32- and 64-bit integers N, which relied on
6357 undefined behavior.
6358 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6359 New macro.
6360 * lisp.h (error, verror): Mark as printf-like functions.
6361 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6362 Report overflow in size calculations when allocating printf buffer.
6363 Do not truncate output string at its first null byte.
6364 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6365 Truncate the output at a character boundary, since vsnprintf does not
6366 do that.
6367 * charset.c (check_iso_charset_parameter): Convert internal
6368 character to string before calling 'error', since %c now has the
6369 printf meaning.
6370 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6371 overflow when computing char to be passed to 'error'. Do not
6372 pass Lisp_Object to 'error'; pass the integer instead.
6373 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6374 formatted with plain %d.
6375
b189fa66
PE
6376 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6377
bff87ef0
PE
6378 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6379
7e2cac20
PE
6380 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6381
ce4d90b5
PE
6382 * xterm.c (x_catch_errors): Remove duplicate declaration.
6383
266c9547
PE
6384 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6385
79c49ad2
PE
6386 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6387
368f4090
JM
63882011-04-10 Jim Meyering <meyering@redhat.com>
6389
6390 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6391 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6392 return ssize_t not "int", and use size_t as the buffer length.
6393 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6394 * gnutls.h: Update declarations.
6395 * process.c (read_process_output): Use ssize_t, to match.
6396 (send_process): Likewise.
6397
a32d4040
CY
63982011-04-09 Chong Yidong <cyd@stupidchicken.com>
6399
6400 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6401
8546720e 64022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6403
04f2d78b
CB
6404 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6405 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6406
8546720e
GM
6407 * xterm.c (handle_one_xevent):
6408 * xmenu.c (create_and_show_popup_menu):
6409 * xselect.c (x_decline_selection_request)
6410 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6411
0a2f5c1a 64122011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6413
6414 Fix some uses of `int' instead of EMACS_INT.
6415 * search.c (string_match_1, fast_string_match)
6416 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6417 (scan_buffer, find_next_newline_no_quit)
6418 (find_before_next_newline, search_command, Freplace_match)
6419 (Fmatch_data): Make some `int' variables be EMACS_INT.
6420
6421 * xdisp.c (display_count_lines): 3rd argument and return value now
6422 EMACS_INT. All callers changed.
6423 (pint2hrstr): Last argument is now EMACS_INT.
6424
6425 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6426 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6427 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6428 (decode_coding_utf_16, decode_coding_emacs_mule)
6429 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6430 (decode_coding_ccl, decode_coding_charset)
6431 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6432 (decode_coding_iso_2022, decode_coding_emacs_mule)
6433 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6434 <char_offset, last_offset>: Declare EMACS_INT.
6435 (encode_coding_utf_8, encode_coding_utf_16)
6436 (encode_coding_emacs_mule, encode_invocation_designation)
6437 (encode_designation_at_bol, encode_coding_iso_2022)
6438 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6439 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6440 Declare EMACS_INT.
6441 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6442 (encode_invocation_designation): Last argument P_NCHARS is now
6443 EMACS_INT.
6444 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6445 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6446
6447 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6448 All users changed.
6449
6450 * ccl.c (Fccl_execute_on_string): Declare some variables
6451 EMACS_INT.
6452
8546720e 64532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6454
6455 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6456
4e19a977
CS
64572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6458
6459 * process.c (Fformat_network_address): Doc fix.
6460
87302331
R
64612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6462
6463 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6464
cbb59342
CY
64652011-04-08 Chong Yidong <cyd@stupidchicken.com>
6466
6467 * keyboard.c (read_char): Call Lisp function help-form-show,
6468 instead of using internal_with_output_to_temp_buffer.
6469 (Qhelp_form_show): New var.
e0d38eeb 6470 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6471
6472 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6473
6474 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6475
e67a13ab
CY
64762011-04-06 Chong Yidong <cyd@stupidchicken.com>
6477
04f2d78b
CB
6478 * process.c (Flist_processes): Remove to Lisp.
6479 (list_processes_1): Delete.
e67a13ab 6480
973f782d
EZ
64812011-04-06 Eli Zaretskii <eliz@gnu.org>
6482
7c106b1e
EZ
6483 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6484
973f782d
EZ
6485 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6486
41cf7d1a 64872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6488
ca23cc88
PE
6489 Fix more problems found by GCC 4.6.0's static checks.
6490
f390e2d5
PE
6491 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6492
42eea0d0
PE
6493 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6494
b69769da 6495 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6496
f9541e84
PE
6497 * xdisp.c (vmessage): Mark as a printf-like function.
6498
13841b55
PE
6499 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6500
c136c10f
PE
6501 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6502
5e2d4a30
PE
6503 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6504 printf-like functions.
6505 (tiff_load): Add casts to remove these marks before passing them
6506 to system-supplied API.
6507
583f48b9
PE
6508 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6509
b25d760e
PE
6510 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6511 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6512 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6513 directly, rather than having caller test rule sign. This avoids
6514 some unnecessary tests.
6515 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6516 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6517 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6518
bc7b6697 6519 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6520 (xfont_open): Avoid unnecessary tests.
bc7b6697 6521
27ccc379
PE
6522 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6523
dcd5c89a
PE
6524 * composite.h, composite.c (composition_gstring_put_cache):
6525 Use EMACS_INT, not int, for length.
6526
b13a45c6
PE
6527 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6528 breaking out part of COMPOSITION_DECODE_RULE.
6529 (COMPOSITION_DECODE_RULE): Use it.
6530 * composite.c (get_composition_id): Remove unused local vars,
6531 by using the new macro.
6532
1e792e4d
PE
6533 * textprop.c (set_text_properties_1): Change while to do-while,
6534 since the condition is always true at first.
6535
dc6c6455 6536 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6537 (interval_deletion_adjustment): Return unsigned value.
6538 All uses changed.
dc6c6455 6539
aba7731a
PE
6540 * process.c (list_processes_1, create_pty, read_process_output):
6541 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6542 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6543 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6544 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6545 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6546
fdfc4bf3
PE
6547 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6548
fca8fe46 6549 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6550 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6551
06a0259a 6552 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6553 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6554 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6555
e7b9e80f
PE
6556 * print.c (print_error_message): Avoid int overflow.
6557
56201685
PE
6558 * font.c (font_list_entities): Redo for clarity,
6559 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6560
78834453 6561 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6562 (font_score): Avoid potential overflow in diff calculation.
78834453 6563
0bc0b309 6564 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6565 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6566
e610eaca
PE
6567 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6568
b895abce
PE
6569 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6570 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6571 can always succeed if overflow has undefined behavior.
6572
1f1d9321 6573 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6574 (wordify): Omit three unnecessary tests.
1f1d9321 6575
c59478bc
PE
6576 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6577 All callers changed. This avoids the need for an unused var.
6578
79b73827
PE
6579 * casefiddle.c (casify_region): Remove var that is set but not used.
6580
a4db5dfe
PE
6581 * dired.c (file_name_completion): Remove var that is set but not used.
6582
43aae36e
PE
6583 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6584
2a47c44d 6585 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6586 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6587
a37c69bf
PE
6588 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6589 Check for integer overflow on size calculations.
6590
328ab8e7
PE
6591 * buffer.c (Fprevious_overlay_change): Remove var that is set
6592 but not used.
6593
e5a2a5cb
PE
6594 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6595 Remove vars that are set but not used.
8d84a6eb 6596 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6597 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6598
a60e5f68
PE
6599 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6600
f661cb61 6601 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6602 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6603
f0397f5a
PE
6604 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6605 that are set but not used.
6606
8664db06 6607 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6608 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6609
6abdaa4a
PE
6610 * xselect.c (x_get_local_selection, x_handle_property_notify):
6611 Remove vars that are set but not used.
6612
0ce7538d 6613 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6614 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6615
9ae848fc
PE
6616 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6617 Remove var that is set but not used.
0b918413
PE
6618 (scroll_bar_windows_size): Now size_t, not int.
6619 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6620 Check for overflow.
9ae848fc 6621
a5a62657
PE
6622 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6623 (map_tty_color) [!defined MSDOS]: Likewise.
6624
5c5cdd39
PE
6625 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6626
66ebf983
PE
6627 * coding.c: Remove vars that are set but not used.
6628 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6629 All callers changed.
6630 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6631 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6632 (decode_coding_charset): Remove vars that are set but not used.
6633
1be4d761
PE
6634 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6635 that is set but not used.
6636
47553fa8
PE
6637 * print.c (print_object): Remove var that is set but not used.
6638
1f7196bf 6639 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6640 The gnulib version avoids calling malloc in the usual case,
6641 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6642 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6643 * filelock.c (current_lock_owner): Likewise.
6644 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6645 * sysdep.c: Include allocator.h, careadlinkat.h.
6646 (emacs_no_realloc_allocator): New static constant.
6647 (emacs_readlink): New function.
fdb61804
PE
6648 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6649 ../lib/careadlinkat.h.
d1fdcab7 6650
f84c17c7
SM
66512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6652
6653 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6654 first non-nil return value).
6655
ef3862ad
JD
66562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6657
6658 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6659 if not defined (Bug#8403).
6660
376a7006
JB
66612011-04-02 Juanma Barranquero <lekktu@gmail.com>
6662
6663 * xdisp.c (display_count_lines): Remove parameter `start',
6664 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6665 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6666 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6667 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6668 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6669 and thereabouts. All callers changed.
6670 (get_per_char_metric): Remove parameter `f', unused since
6671 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6672
6ca3801d
JM
66732011-04-02 Jim Meyering <meyering@redhat.com>
6674
6675 do not dereference NULL upon failed strdup
6676 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6677 (ns_get_family): Likewise.
6678
d8e2b5ba
JB
66792011-04-02 Juanma Barranquero <lekktu@gmail.com>
6680
6681 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6682
8c74fcbd
JD
66832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6684
6685 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6686 later (Bug#8403).
6687
7200d79c
SM
66882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6689
03408648 6690 Add lexical binding.
7200d79c 6691
03408648
SM
6692 * window.c (Ftemp_output_buffer_show): New fun.
6693 (Fsave_window_excursion):
6694 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6695
6696 * lread.c (lisp_file_lexically_bound_p): New function.
6697 (Fload): Bind Qlexical_binding.
6698 (readevalloop): Remove `evalfun' arg.
6699 Bind Qinternal_interpreter_environment.
6700 (Feval_buffer): Bind Qlexical_binding.
6701 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6702 Mark as dynamic.
6703 (syms_of_lread): Declare `lexical-binding'.
6704
6705 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6706
6707 * keyboard.c (eval_dyn): New fun.
6708 (menu_item_eval_property): Use it.
ca105506
SM
6709
6710 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6711
03408648
SM
6712 * fns.c (concat, mapcar1): Accept byte-code-functions.
6713
6714 * eval.c (Fsetq): Handle lexical vars.
6715 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6716 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6717 (FletX, Flet): Obey lexical binding.
6718 (Fcommandp): Handle closures.
6719 (Feval): New `lexical' arg.
6720 (eval_sub): New function extracted from Feval. Use it almost
6721 everywhere where Feval was used. Look up vars in lexical env.
6722 Handle closures.
6723 (Ffunctionp): Move from subr.el.
6724 (Ffuncall): Handle closures.
6725 (apply_lambda): Remove `eval_flags'.
6726 (funcall_lambda): Handle closures and new byte-code-functions.
6727 (Fspecial_variable_p): New function.
6728 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6729 but without exporting it to Lisp.
23aba0ea 6730
23aba0ea 6731 * doc.c (Fdocumentation, store_function_docstring):
03408648 6732 * data.c (Finteractive_form): Handle closures.
23aba0ea 6733
03408648
SM
6734 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6735 interactive spec.
ba83908c 6736
04f2d78b
CB
6737 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6738 New byte-codes.
03408648
SM
6739 (exec_byte_code): New function extracted from Fbyte_code to handle new
6740 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6741
03408648 6742 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6743
03408648 6744 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6745
e2abce01
JB
67462011-03-31 Juanma Barranquero <lekktu@gmail.com>
6747
6748 * xdisp.c (redisplay_internal): Fix prototype.
6749
63696a73 67502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6751
63696a73 6752 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6753 (try_scrolling): Use it when setting scroll_limit.
6754 Limit scrolling to 100 screen lines.
63696a73
EZ
6755 (redisplay_window): Even when falling back on "recentering",
6756 position point in the window according to scroll-conservatively,
6757 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6758
6759 (try_scrolling): When point is above the window, allow searching
6760 as far as scroll_max, or one screenful, to compute vertical
6761 distance from PT to the scroll margin position. This prevents
6762 try_scrolling from unnecessarily failing when
6763 scroll-conservatively is set to a value slightly larger than the
6764 window height. Clean up the case of PT below the margin at bottom
6765 of window: scroll_max can no longer be INT_MAX. When aggressive
6766 scrolling is in use, don't let point enter the opposite scroll
6767 margin as result of the scroll.
6768 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6769 threshold of 100 lines for never-recentering scrolling.
6770
e4cc2dfc
JB
67712011-03-31 Juanma Barranquero <lekktu@gmail.com>
6772
6773 * dispextern.h (move_it_by_lines):
6774 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6775 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6776 (message_log_check_duplicate): Remove parameters `prev_bol' and
6777 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6778 (redisplay_internal): Remove parameter `preserve_echo_area',
6779 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6780
6781 * indent.c (Fvertical_motion):
6782 * window.c (window_scroll_pixel_based, Frecenter):
6783 Don't pass `need_y_p' to `move_it_by_lines'.
6784
1c470562
SM
67852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6786
44f230aa
SM
6787 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6788 steal a few bits to be more compact.
6789 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6790 Remove unneeded casts.
6791
1c470562
SM
6792 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6793
888adce9
ZK
67942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6795
6796 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6797 binding" message (bug#7967).
6798
f838ed7b
PE
67992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6800
77861b95
PE
6801 Fix more problems found by GCC 4.6.0's static checks.
6802
de6dbc14
PE
6803 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6804 Remove unused local var.
6805
f838ed7b
PE
6806 * editfns.c (Fmessage_box): Remove unused local var.
6807
792c7b2b
PE
6808 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6809 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6810 Omit unused local vars.
c499e557 6811 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6812 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6813 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6814 Omit unused local var.
6815
ba0165e1
PE
6816 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6817 Don't assume string length fits in int.
32ad8845 6818 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6819 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6820
3c59b4c9
PE
6821 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6822 instead of alloca (Bug#8344).
6823
a3eed478 6824 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6825 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6826
eb4d412d
PE
6827 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6828
1658b401
PE
6829 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6830 concerns.
6831
6832 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6833
6834 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6835
9a2c6e05
PE
6836 * keyboard.c (syms_of_keyboard): Use the same style as later
6837 in this function when indexing through an array. This also
6838 works around GCC bug 48267.
6839
03d0a109
PE
6840 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6841
44f730c8
PE
6842 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6843
fe75f926
PE
6844 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6845 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6846
ffa8c828
PE
6847 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6848 This avoids undefined behavior on integer overflow, and is a bit
6849 more convenient anyway since it is compared to a size_t variable.
6850
c5101a77
PE
6851 Variadic C functions now count arguments with size_t, not int.
6852 This avoids an unnecessary limitation on 64-bit machines, which
6853 caused (substring ...) to crash on large vectors (Bug#8344).
6854 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6855 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6856 All variadic functions and their callers changed accordingly.
c5101a77
PE
6857 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6858 * data.c (arith_driver, float_arith_driver): Likewise.
6859 * editfns.c (general_insert_function): Likewise.
6860 * eval.c (struct backtrace.nargs, interactive_p)
6861 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6862 (funcall_lambda, mark_backtrace): Likewise.
6863 * fns.c (concat): Likewise.
6864 * frame.c (x_set_frame_parameters): Likewise.
6865 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6866 0 if not found, not -1. All callers changed.
6867
dd3f25f7
PE
6868 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6869 (stack_copy_size): Now size_t, not int.
6870 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6871
461c2ab9
JB
68722011-03-28 Juanma Barranquero <lekktu@gmail.com>
6873
6874 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6875 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6876 All callers changed.
6877
6878 * lisp.h (multibyte_char_to_unibyte):
6879 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6880 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6881 * character.h (CHAR_TO_BYTE8):
6882 * cmds.c (internal_self_insert):
6883 * editfns.c (general_insert_function):
6884 * keymap.c (push_key_description):
6885 * search.c (Freplace_match):
6886 * xdisp.c (message_dolog, set_message_1): All callers changed.
6887
f6d62986
SM
68882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6889
6890 * keyboard.c (safe_run_hook_funcall): New function.
6891 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6892 don't set the hook to nil, but remove the offending function instead.
6893 (Qcommand_hook_internal): Remove, unused.
6894 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6895 Vcommand_hook_internal.
6896
6897 * eval.c (enum run_hooks_condition): Remove.
6898 (funcall_nil, funcall_not): New functions.
6899 (run_hook_with_args): Call each function through a `funcall' argument.
6900 Remove `cond' argument, now redundant.
6901 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6902 (Frun_hook_with_args_until_failure): Adjust accordingly.
6903 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6904
1db5b1ad
JB
69052011-03-28 Juanma Barranquero <lekktu@gmail.com>
6906
6907 * dispextern.h (string_buffer_position): Remove declaration.
6908
6909 * print.c (strout): Remove parameter `multibyte', unused since
6910 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6911
6912 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6913 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6914 All callers changed.
6915
6916 * w32.c (_wsa_errlist): Use braces for struct initializers.
6917
6918 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6919 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6920 All callers changed.
6921 (string_buffer_position): Likewise. Also, make static (it's never
6922 used outside xdisp.c).
6923 (cursor_row_p): Remove parameter `w', unused since
6924 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6925 (decode_mode_spec): Remove parameter `precision', introduced during
6926 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6927 All callers changed.
6928
5ffb62aa
JD
69292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6930
6931 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6932
461c2ab9 69332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6934
6935 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6936 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6937 (ns_update_auto_hide_menu_bar): New functions.
6938 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6939 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6940 ns_constrain_all_frames.
6941 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6942 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6943
5c380ffb
JD
69442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6945
6946 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6947
9af30bdf
GM
69482011-03-27 Glenn Morris <rgm@gnu.org>
6949
6950 * syssignal.h: Replace RETSIGTYPE with void.
6951 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6952 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6953 Replace SIGTYPE with void everywhere.
6954 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6955 * s/template.h (SIGTYPE): Remove commented out definition.
6956
e2abce01
JB
69572011-03-26 Eli Zaretskii <eliz@gnu.org>
6958
6959 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6960 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6961
f868cd8a
JB
69622011-03-26 Juanma Barranquero <lekktu@gmail.com>
6963
59eb0929
JB
6964 * w32.c (read_unc_volume): Use parameter `henum', instead of
6965 global variable `wget_enum_handle'.
6966
6967 * keymap.c (describe_vector): Remove parameters `indices' and
6968 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6969 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6970
f868cd8a
JB
6971 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6972
6973 * keyboard.c (timer_check): Remove parameter `do_it_now',
6974 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6975 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6976 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6977
6978 * keyboard.c (read_char):
6979 * w32menu.c (w32_menu_display_help):
6980 * xmenu.c (show_help_event, menu_help_callback):
6981 Adjust calls to `show_help_echo'.
6982
6983 * gtkutil.c (xg_maybe_add_timer):
6984 * keyboard.c (readable_events):
6985 * process.c (wait_reading_process_output):
6986 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6987
6988 * insdel.c (adjust_markers_gap_motion):
6989 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6990 (gap_left, gap_right): Don't call it.
6991
2ecf6fdb
CY
69922011-03-25 Chong Yidong <cyd@stupidchicken.com>
6993
6994 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6995 incurred during fontification.
6996
6b1f9ba4
JB
69972011-03-25 Juanma Barranquero <lekktu@gmail.com>
6998
6999 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7000 (DEFVAR_PER_BUFFER): Don't pass it.
7001
7002 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7003 (scrolling_window): Don't pass it.
7004
0f4a96b5
JB
70052011-03-25 Juanma Barranquero <lekktu@gmail.com>
7006
7007 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7008
7009 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7010 and `suffix'.
7011 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7012 of variables specific to SELinux and computation of `encoded_absname'.
7013
7014 * image.c (XPutPixel): Remove unused variable `height'.
7015
7016 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7017
7018 * unexw32.c (get_section_info): Remove unused variable `section'.
7019
7020 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7021 (system_process_attributes): Remove unused variable `sess'.
7022 (sys_read): Remove unused variable `err'.
7023
7024 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7025 (w32_wnd_proc): Remove unused variable `isdead'.
7026 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7027 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7028 (x_create_tip_frame): Remove unused variable `tem'.
7029
7030 * w32inevt.c (w32_console_read_socket):
7031 Remove unused variable `no_events'.
7032
7033 * w32term.c (x_draw_composite_glyph_string_foreground):
7034 Remove unused variable `width'.
7035
1149507c
JB
70362011-03-24 Juanma Barranquero <lekktu@gmail.com>
7037
7038 * w32term.c (x_set_glyph_string_clipping):
7039 Don't pass uninitialized region to CombineRgn.
7040
9c88f339
JB
70412011-03-23 Juanma Barranquero <lekktu@gmail.com>
7042
7043 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7044 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7045 (Fx_close_connection): Remove unused variable `i'.
7046
7047 * w32font.c (w32font_draw): Return number of glyphs.
7048 (w32font_open_internal): Remove unused variable `i'.
7049 (w32font_driver): Add missing initializer.
7050
7051 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7052 (fill_in_menu): Remove unused variable `items_added'.
7053
7054 * w32term.c (last_mouse_press_frame): Remove static global variable.
7055 (w32_clip_to_row): Remove unused variable `f'.
7056 (x_delete_terminal): Remove unused variable `i'.
7057
7058 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7059 (NOTHING): Remove unused static global variable.
7060 (uniscribe_check_otf): Remove unused variable `table'.
7061 (uniscribe_font_driver): Add missing initializers.
7062
dee091a3
JD
70632011-03-23 Julien Danjou <julien@danjou.info>
7064
7065 * term.c (Fsuspend_tty, Fresume_tty):
7066 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7067 * window.c (temp_output_buffer_show):
7068 * insdel.c (signal_before_change):
7069 * frame.c (Fhandle_switch_frame):
7070 * fileio.c (Fdo_auto_save):
7071 * emacs.c (Fkill_emacs):
7072 * editfns.c (save_excursion_restore):
7073 * cmds.c (internal_self_insert):
7074 * callint.c (Fcall_interactively):
7075 * buffer.c (Fkill_all_local_variables):
7076 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7077 Use Frun_hooks.
0f4a96b5 7078 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7079 unconditionnaly since it does the check itself.
7080
2c520ab5 70812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7082
c9c49752
PE
7083 Fix more problems found by GCC 4.5.2's static checks.
7084
8abc3f12
PE
7085 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7086 the first time through the loop, since we know p0 < p1 then.
7087 This also avoids a gcc -Wstrict-overflow warning.
7088
a2d26660
PE
7089 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7090 leading to a memory leak, possible in functions like
7091 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7092 of objects (Bug#8318).
a2d26660 7093
916c72e9
PE
7094 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7095 that could (at least in theory) be that large.
7096
19ab8a18
PE
7097 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7098 This is less likely to overflow, and avoids undefined behavior if
7099 overflow does occur. All callers changed. Use strtoul to scan
7100 for the unsigned long integer.
b7cbbd6f
PE
7101 (pint2hrstr): Simplify and tune code slightly.
7102 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7103
f0641eff
PE
7104 * scroll.c (do_scrolling): Work around GCC bug 48228.
7105 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7106
7f650bb9
PE
7107 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7108 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7109 (validate_x_resource_name): Simplify count usage.
7110 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7111
37dd57d1
PE
7112 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7113 fail (Bug#8306).
81e56e61 7114
699979fc 7115 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7116
401bf9b4
PE
7117 * process.c (Fmake_network_process): Use socklen_t, not int,
7118 where POSIX says socklen_t is required in portable programs.
7119 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7120 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7121 (Fmake_network_process, server_accept_connection):
7122 (wait_reading_process_output, read_process_output):
7123 Likewise.
7124
b93aacde
PE
7125 * process.c: Rename or move locals to avoid shadowing.
7126 (list_processes_1, Fmake_network_process):
7127 (read_process_output_error_handler, exec_sentinel_error_handler):
7128 Rename or move locals.
4dc343ee 7129 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7130 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7131 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7132 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7133 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7134
af8a867c 7135 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7136 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7137 Include tparam.h instead, since it declares them.
af8a867c
PE
7138 * cm.h (PC): Remove extern decl; tparam.h now does this.
7139 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7140 * terminfo.c: Include tparam.h, to check interfaces.
7141 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7142 (tparam): Adjust signature to match interface in tparam.h;
7143 this removes some undefined behavior. Check that outstring and len
7144 are zero, which they always are with Emacs.
7145 * tparam.h (PC, BC, UP): New extern decls.
7146
0248044d 7147 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7148 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7149
8ff096c1 7150 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7151 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7152 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7153 (ftfont_list): Remove unused local.
49eaafba
PE
7154 (get_adstyle_property, ftfont_pattern_entity):
7155 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7156 Rename locals to avoid shadowing.
8ff096c1 7157
e2be39f6
PE
7158 * xfont.c (xfont_list_family): Mark var as initialized.
7159
c9735e30
PE
7160 * xml.c (make_dom): Now static.
7161
8f5201ae
PE
7162 * composite.c (composition_compute_stop_pos): Rename local to
7163 avoid shadowing.
b246f932
PE
7164 (composition_reseat_it): Remove unused locals.
7165 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7166 (composition_update_it): Mark var as initialized.
11b61122
PE
7167 (find_automatic_composition): Mark vars as initialized,
7168 with a FIXME (Bug#8290).
8f5201ae 7169
760fbc2c
PE
7170 character.h: Rename locals to avoid shadowing.
7171 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7172 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7173 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7174 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7175 to avoid shadowing.
7176
ff08eb85
PE
7177 * textprop.c (property_change_between_p): Remove; unused.
7178
fc7bf025
PE
7179 * intervals.c (interval_start_pos): Now static.
7180
235d7abc
PE
7181 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7182
44f230aa
SM
7183 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7184 Rename locals to avoid shadowing.
3e7d6594 7185
50060332
PE
7186 * sound.c (wav_play, au_play, Fplay_sound_internal):
7187 Fix pointer signedness.
d01f234b 7188 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7189 (wav_play): Initialize a variable to 0, to prevent undefined
7190 behavior (Bug#8278).
50060332 7191
c4fc4e30
PE
7192 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7193
918436ed
PE
7194 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7195
c939f91b
PE
7196 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7197 clobbering (Bug#8298).
b9c7f648
PE
7198 * sysdep.c (sys_subshell): Likewise.
7199 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7200
6bd8c144
PE
7201 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7202 This should get cleaned up, so that child_setup has the
7203 same signature on all platforms.
7204
7710357c 7205 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7206 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7207
c59da222
CY
72082011-03-22 Chong Yidong <cyd@stupidchicken.com>
7209
7210 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7211 not to be necessary, and produces flickering.
7212
66b87493
GM
72132011-03-20 Glenn Morris <rgm@gnu.org>
7214
7215 * config.in: Remove file.
7216
45b6f6d5
JB
72172011-03-20 Juanma Barranquero <lekktu@gmail.com>
7218
7219 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7220 are now in src/globals.h.
7221 (syms_of_minibuf): Remove spurious & from previous change.
7222
3ec03f7e
LL
72232011-03-20 Leo <sdl.web@gmail.com>
7224
7225 * minibuf.c (completing-read-function): New variable.
7226 (completing-read-default): Rename from completing-read.
7227 (completing-read): Call completing-read-function.
7228
b14e3e21
CY
72292011-03-19 Juanma Barranquero <lekktu@gmail.com>
7230
7231 * xfaces.c (Fx_load_color_file):
7232 Read color file from absolute filename (bug#8250).
7233
f2b726e6
JB
72342011-03-19 Juanma Barranquero <lekktu@gmail.com>
7235
7236 * makefile.w32-in: Update dependencies.
7237
09f6ff02
EZ
72382011-03-17 Eli Zaretskii <eliz@gnu.org>
7239
7240 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7241
29a6015a
PE
72422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7243
a3a6c54e
PE
7244 Fix more problems found by GCC 4.5.2's static checks.
7245
b766f867
PE
7246 * process.c (make_serial_process_unwind, send_process_trap):
7247 (sigchld_handler): Now static.
7248
be02381c
PE
7249 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7250 That way, the code declares only the vars that it needs.
7251 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7252 * s/cygwin.h (PTY_ITERATION): Likewise.
7253 * s/darwin.h (PTY_ITERATION): Likewise.
7254 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7255
57048744
PE
7256 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7257 * process.c (allocate_pty): Don't declare stb unless it's needed.
7258
7914961c 7259 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7260 (CONSTANTLIM): Remove; unused.
7261 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7262 Define only if needed.
7914961c 7263
b3967b18
PE
7264 * unexelf.c (unexec): Name an expression,
7265 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7266 Use a different way to cause a compilation error if anyone uses
7267 n rather than nn, a way that does not involve shadowing.
73366a00 7268 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7269
29a6015a
PE
7270 * deps.mk (unexalpha.o): Remove; unused.
7271
43cfc33e 7272 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7273 * unexec.h: New file.
ce701a33
PE
7274 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7275 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7276 Depend on unexec.h.
7277 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7278 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7279 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7280 Change as necessary to match prototype in unexec.h.
ce701a33 7281
01f44d5a
PE
7282 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7283 shadowing.
4f63c6bb 7284 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7285
a6670b0b
PE
7286 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7287 Rename locals to avoid shadowing.
7288
cef2010d 7289 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7290 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7291
d4d7173a
PE
7292 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7293
f08b802a
PE
7294 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7295 warning when compiling print.c.
7296
3ddb0639
PE
7297 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7298 instead of using an uninitialized var.
5ad03b97 7299 (font_sort_entities): Mark var as initialized.
3ddb0639 7300
170a2692
PE
7301 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7302
e663c700
PE
7303 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7304 pointers to constants.
89bc529a 7305 (font_parse_fcname): Remove unused vars.
7b81e2d0 7306 (font_delete_unmatched): Now static.
ea838e10 7307 (font_get_spec): Remove; unused.
13a547c6
PE
7308 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7309 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7310 Rename or move locals to avoid shadowing.
e663c700 7311
2a80c887 7312 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7313 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7314
1384fa33 7315 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7316 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7317
8b2c52e9
PE
7318 * alloc.c (mark_backtrace): Move decl from here ...
7319 * lisp.h: ... to here, so that it can be checked.
7320
475545b5 7321 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7322 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7323 (lisp_indirect_variable): Name an expression,
7324 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7325 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7326
b1349114 7327 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7328 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7329 Use const pointer when appropriate.
b1349114 7330
a2928364
PE
7331 * lisp.h (get_system_name, get_operating_system_release):
7332 Move decls here, to check interfaces.
7333 * process.c (get_operating_system_release): Move decl to lisp.h.
7334 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7335 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7336 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7337 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7338 (Fformat_time_string, Fencode_time, Finsert_char):
7339 (Ftranslate_region_internal, Fformat):
7340 Rename or remove local vars to avoid shadowing.
9710023e 7341 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7342
a415e694
PE
7343 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7344 avoid shadowing.
7345
8ef4622d
PE
7346 * lisp.h (eassert): Check that the argument compiles, even if
7347 ENABLE_CHECKING is not defined.
7348
946f9a5b
PE
7349 * data.c (Findirect_variable): Name an expression, to avoid
7350 gcc -Wbad-function-cast warning.
112396d6 7351 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7352 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7353 (Fmake_variable_buffer_local, Fmake_local_variable):
7354 Mark variables as initialized.
52746918 7355 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7356
e5aab7e7 7357 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7358 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7359 Rename locals to avoid shadowing.
dff45157
PE
7360 (mark_stack): Move local variables into the #ifdef region where
7361 they're used.
7bc26fdb
PE
7362 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7363 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7364 needed otherwise.
7365 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7366 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7367 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7368
e5aab7e7
PE
7369 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7370 avoids undefined behavior in theory.
7371
4da60324
PE
7372 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7373
88043301
PE
7374 Use functions, not macros, for up- and down-casing (Bug#8254).
7375 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7376 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7377 to use the following functions instead of these macros.
7378 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7379 EMACS_INT, since callers assume the returned value fits in int.
7380 (upcase1): Likewise, for UPCASE_TABLE.
7381 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7382 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7383 the race-condition problem in the old DOWNCASE.
88043301 7384
19ed5445
PE
7385 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7386 Rename locals to avoid shadowing.
7387 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7388 (regex_compile, re_search_2, re_match_2_internal):
7389 Remove unused local vars.
952db0d7
PE
7390 (FREE_VAR): Rewrite so as not to use empty "else",
7391 which gcc can warn about.
da053e48 7392 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7393 (RETALLOC_IF): Define only if needed.
7394 (WORDCHAR_P): Likewise. This one is never needed, but is used
7395 only in a comment talking about a compiler bug, so put inside
7396 the #if 0 of that comment.
7397 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7398 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7399 Remove; unused.
19ed5445 7400
1f3561e4 7401 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7402 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7403 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7404
ded6f8f7
PE
7405 * search.c (simple_search): Remove unused var.
7406
dbd37a95
PE
7407 * dired.c (compile_pattern): Move decl from here ...
7408 * lisp.h: ... to here, so that it can be checked.
7409 (struct re_registers): New forward decl.
7410
7e47afad
PE
7411 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7412
85f24f61
PE
7413 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7414 All uses changed.
7415 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7416 Rename locals to avoid shadowing.
5671df8f 7417 (Fvertical_motion): Mark locals as initialized.
85f24f61 7418
181aa2be 7419 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7420 (casify_region): Mark local as initialized.
181aa2be 7421
930d429c
PE
7422 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7423
7082eac6
PE
7424 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7425 New macros, so that the caller can use some names other than
7426 gcpro1, gcpro2, etc.
7427 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7428 of the new macros.
7429 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7430 argument, for consistency with GCPRO2_VAR, etc: it is now the
7431 prefix of the variable, not the variable itself. All uses
7432 changed.
38b2c076
PE
7433 * dired.c (directory_files_internal, file_name_completion):
7434 Rename locals to avoid shadowing.
7435
15206ed9
PE
7436 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7437 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7438 dired.c's scmp function, had undefined behavior.
7439 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7440 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7441 * buffer.h: ... to here, because these macros use current_buffer,
7442 and the new implementation with inline functions needs to have
7443 current_buffer in scope now, rather than later when the macros
7444 are used.
7445 (downcase, upcase1): New static inline functions.
7446 (DOWNCASE, UPCASE1): Reimplement using these functions.
7447 This avoids undefined behavior in expressions like
7448 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7449 from race conditions in accessing the global variables
7450 case_temp1 and case_temp2.
7451 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7452 * lisp.h (case_temp1, case_temp2): Remove their decls.
7453 * character.h (ASCII_CHAR_P): Move from here ...
7454 * lisp.h: ... to here, so that the inline functions mentioned
7455 above can use them.
7456
4a6bea26
PE
7457 * dired.c (directory_files_internal_unwind): Now static.
7458
f14b7e14
PE
7459 * fileio.c (file_name_as_directory, directory_file_name):
7460 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7461 Now static.
2893f146
PE
7462 (file_name_as_directory): Use const pointers when appropriate.
7463 (Fexpand_file_name): Likewise. In particular, newdir might
7464 point at constant storage, so make it a const pointer.
fd4ead52 7465 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7466 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7467 signedness issues.
f839df0c
PE
7468 (Fset_file_times, Finsert_file_contents, auto_save_error):
7469 Rename locals to avoid shadowing.
f14b7e14 7470
5716756e 7471 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7472 (Ftry_completion, Fall_completions): Rename or remove locals
7473 to avoid shadowing.
5716756e 7474
b4c3046a
PE
7475 * marker.c (bytepos_to_charpos): Remove; unused.
7476
b45db522
PE
7477 * lisp.h (verify_bytepos, count_markers): New decls,
7478 so that gcc does not warn that these functions aren't declared.
7479
85876d07
PE
7480 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7481 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7482 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7483 (copy_text): Remove unused local var.
85876d07 7484
03d78a21 7485 * filelock.c (within_one_second): Now static.
b3dd38ab 7486 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7487
5df8f01b
PE
7488 * buffer.c (fix_overlays_before): Mark locals as initialized.
7489 (fix_start_end_in_overlays): Likewise. This function should be
7490 simplified by using pointers-to-pointers, but that's a different
7491 matter.
b1d876f1 7492 (switch_to_buffer_1): Now static.
8f54f30a
PE
7493 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7494 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7495
a70072c9 7496 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7497 Fix pointer signedness issue.
edced198
PE
7498 (sys_subshell): Mark local as volatile if checking for lint,
7499 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7500 (MAXPATHLEN): Define only if needed.
a70072c9 7501
a0977c44
PE
7502 * process.c (serial_open, serial_configure): Move decls from here ...
7503 * systty.h: ... to here, so that they can be checked.
7504
a884fdcc
PE
7505 * fns.c (get_random, seed_random): Move extern decls from here ...
7506 * lisp.h: ... to here, so that they can be checked.
7507
604efe86 7508 * sysdep.c (reset_io): Now static.
b8950c94 7509 (wait_for_termination_signal): Remove; unused.
604efe86 7510
38fc62d9
PE
7511 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7512 (copy_keymap_item, append_key, push_text_char_description):
7513 Now static.
1004a21a 7514 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7515 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7516 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7517 (describe_map_tree):
7518 Rename locals to avoid shadowing.
38fc62d9 7519
2f2650da
PE
7520 * keyboard.c: Declare functions static if they are not used elsewhere.
7521 (echo_char, echo_dash, cmd_error, top_level_2):
7522 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7523 (read_char, kbd_buffer_get_event, make_lispy_position):
7524 (make_lispy_event, make_lispy_movement, apply_modifiers):
7525 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7526 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7527 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7528 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7529 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7530
a053e86c 7531 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7532 (mark_kboards): Move decl here ...
7533 * alloc.c (mark_kboards): ... from here.
a053e86c 7534
4752793e
PE
7535 * lisp.h (force_auto_save_soon): New decl.
7536
74f10ca7 7537 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7538 (DEFINE_DUMMY_FUNCTION): New macro.
7539 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7540 Use it.
c03cd23f
PE
7541 (main): Add casts to avoid warnings
7542 if GCC considers string literals to be constants.
74f10ca7 7543
022e70d4
PE
7544 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7545
59d6fe83
PE
7546 * dbusbind.c: Pointer signedness fixes.
7547 (xd_signature, xd_append_arg, xd_initialize):
7548 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7549 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7550 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7551 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7552
78320123
PE
7553 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7554 if GCC considers string literals to be constants.
49cebcca 7555 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7556
35ac2a97
SM
75572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7558
fb103ca9
SM
7559 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7560 (print_preprocess, print_object): New macro to fix last change.
7561
35ac2a97
SM
7562 * print.c (print_preprocess): Don't forget font objects.
7563
62973b41
JB
75642011-03-16 Juanma Barranquero <lekktu@gmail.com>
7565
7566 * emacs.c (USAGE3): Doc fixes.
7567
0e48bb22
AS
75682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7569
7570 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7571 structure.
7572
7684e57b
JB
75732011-03-14 Juanma Barranquero <lekktu@gmail.com>
7574
7575 * lisp.h (VWindow_system, Qfile_name_history):
7576 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7577 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7578 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7579
7580 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7581 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7582
7583 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7584 * w32console.c (detect_input_pending, read_input_pending)
7585 (encode_terminal_code):
7586 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7587 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7588 (w32_system_caret_y, Qfile_name_history):
7589 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7590 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7591 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7592 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7593 * w32proc.c (Qlocal, report_file_error):
7594 * w32term.c (Vwindow_system, updating_frame):
7595 * w32uniscribe.c (initialized, uniscribe_font_driver):
7596 Remove unneeded extern declarations.
7597
2aa46d6c
CY
75982011-03-14 Chong Yidong <cyd@stupidchicken.com>
7599
c96bbc66 7600 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7601
cffc6f3b
CY
76022011-03-13 Chong Yidong <cyd@stupidchicken.com>
7603
7604 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7605 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7606 These macros can no longer be used for assignment.
7607
44f230aa
SM
7608 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7609 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7610 (record_buffer_markers, fetch_buffer_markers): New functions for
7611 recording and fetching special buffer markers.
7612 (set_buffer_internal_1, set_buffer_temp): Use them.
7613
7614 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7615
7616 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7617
7618 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7619 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7620
7621 * xdisp.c (hscroll_window_tree):
7622 (reconsider_clip_changes): Use PT instead of BUF_PT.
7623
d251f04b
EZ
76242011-03-13 Eli Zaretskii <eliz@gnu.org>
7625
7626 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7627 $(EMACS_ROOT)/lib/intprops.h.
7628
f0c77cd1
PE
76292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7630
3eca4629
PE
7631 Fix more problems found by GCC 4.5.2's static checks.
7632
7c86ee98
PE
7633 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7634 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7635 (xg_free_frame_widgets): Make it clear that a local variable is
7636 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7637 (gdk_window_get_screen): Make it clear that this macro is needed
7638 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7639 (int_gtk_range_get_value): New function, which avoids a diagnostic
7640 from gcc -Wbad-function-cast.
7641 (xg_set_toolkit_scroll_bar_thumb): Use it.
7642 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7643 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7644 (get_utf8_string, xg_get_file_with_chooser):
7645 Rename locals to avoid shadowing.
7646 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7647
41729b81
PE
7648 * xgselect.c (xg_select): Remove unused var.
7649
f0c77cd1
PE
7650 * image.c (four_corners_best): Mark locals as initialized.
7651 (gif_load): Initialize transparent_p to zero (Bug#8238).
7652 Mark another local as initialized.
ec6cf4c6 7653 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7654
ce0ad53d 7655 * image.c (clear_image_cache): Now static.
d5d5a617 7656 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7657 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7658 (x_edge_detection): Remove unnecessary cast that
7659 gcc -Wbad-function-cast diagnoses.
2037898d 7660 (gif_load): Fix pointer signedness.
6ae141d6
PE
7661 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7662 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7663
33383987 76642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7665
d32df629
PE
7666 Improve quality of tests for time stamp overflow.
7667 For example, without this patch (encode-time 0 0 0 1 1
7668 1152921504606846976) returns the obviously-bogus value (-948597
7669 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7670 reports time overflow. See
7671 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7672 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7673 * editfns.c: Include limits.h and intprops.h.
7674 (TIME_T_MIN, TIME_T_MAX): New macros.
7675 (time_overflow): Move earlier, to before first use.
7676 (hi_time, lo_time): New functions, for an accurate test for
7677 out-of-range times.
7678 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7679 (Fget_internal_run_time): Don't assume time_t fits in int.
7680 (make_time): Use list2 instead of Fcons twice.
7681 (Fdecode_time): More accurate test for out-of-range times.
7682 (check_tm_member): New function.
7683 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7684 (lisp_time_argument): Don't rely on undefined left-shift and
7685 right-shift behavior when checking for time stamp overflow.
8be6f318 7686
fe31d94c
PE
7687 * editfns.c (time_overflow): New function, refactoring common code.
7688 (Fformat_time_string, Fdecode_time, Fencode_time):
7689 (Fcurrent_time_string): Use it.
7690
8be6f318
PE
7691 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7692 * dired.c (make_time): Move to ...
7693 * editfns.c (make_time): ... here.
7694 * systime.h: Note the move.
7695
09d9db2c 76962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7697
126bc0dc
YM
7698 * fringe.c (update_window_fringes): Remove unused variables.
7699
c47cbdfd
YM
7700 * unexmacosx.c (copy_data_segment): Also copy __got section.
7701 (Bug#8223)
7702
7ac80be9
EZ
77032011-03-12 Eli Zaretskii <eliz@gnu.org>
7704
c96bbc66 7705 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7706 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7707 Constify `char *' arguments and their references according to
7708 prototypes in tparam.h.
7709
ecb0f94d 7710 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7711
7ac80be9
EZ
7712 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7713 Adapt all references accordingly.
7714
7715 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7716
ef1fd07e
TT
77172011-03-11 Tom Tromey <tromey@redhat.com>
7718
7719 * buffer.c (syms_of_buffer): Remove obsolete comment.
7720
7ef4b50c
EZ
77212011-03-11 Eli Zaretskii <eliz@gnu.org>
7722
7723 * termhooks.h (encode_terminal_code): Declare prototype.
7724
7725 * msdos.c (encode_terminal_code): Don't declare prototype.
7726
7727 * term.c (encode_terminal_code): Now external again, used by
7728 w32console.c and msdos.c.
7729
44f230aa
SM
7730 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7731 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7732
4b1ec863 77332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7734
1714f52b 7735 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7736
4b1ec863
PE
7737 * fringe.c (update_window_fringes): Mark locals as initialized
7738 (Bug#8227).
7739 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7740
524c7aa6
PE
7741 * alloc.c (mark_fringe_data): Move decl from here ...
7742 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7743 to check its interface.
7744 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7745
a5c0af81 7746 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7747 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7748 (fontset_font): Mark local as initialized.
a9a06e0b 7749 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7750
b4716021
PE
7751 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7752
811e9bac 7753 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7754 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7755 (x_own_selection, Fx_disown_selection_internal): Rename locals
7756 to avoid shadowing.
7757 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7758
7e3ab302
PE
7759 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7760 so that the caller can use some name other than gcpro1.
7761 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7762 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7763 (Fx_backspace_delete_keys_p):
7764 Use them to avoid shadowing, and rename vars to avoid shadowing.
7765 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7766 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7767 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7768 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7769 Remove unused locals.
7e3ab302
PE
7770 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7771 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7772 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7773 macros.
f78faa98 7774
e2b13473
PE
7775 * xterm.h (x_mouse_leave): New decl.
7776
77f23912
PE
7777 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7778 Remove unused functions.
cdf4ba58
PE
7779 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7780 (x_calc_absolute_position): Now static.
7411c686 7781 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7782 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7783 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7784 unless they are used.
38d0b34a
PE
7785 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7786 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7787 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7788 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7789 (x_error_catcher, x_connection_closed, x_error_handler):
7790 (x_error_quitter, xembed_send_message, x_iconify_frame):
7791 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7792 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7793 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7794
44f230aa
SM
7795 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7796 Rename or move locals to avoid shadowing.
6b463e58 7797 (tty_defined_color, merge_face_heights): Now static.
5967d051 7798 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7799 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7800 does not deduce is never used uninitialized.
73719eba
PE
7801 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7802 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7803
426994c3 7804 * terminal.c (store_terminal_param): Now static.
5489860b 7805
032f1620 7806 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7807 (set_frame_menubar): Remove unused local.
d4323972 7808 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7809 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7810 since they might point to immutable storage.
281585b0
PE
7811 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7812 since it's unused otherwise.
032f1620 7813
367c19e5 7814 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7815 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7816 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7817 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7818 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7819 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7820 does not deduce are never used uninitialized.
70739cbe 7821
07b48fa9
PE
7822 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7823
8868a238 7824 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7825 * window.c (window_loop, size_window):
7826 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7827
7e5cf297 7828 * window.c (display_buffer): Now static.
d6550a9f
PE
7829 (size_window): Mark variables that gcc -Wuninitialized
7830 does not deduce are never used uninitialized.
a586633d
PE
7831 * window.h (check_all_windows): New decl, to forestall
7832 gcc -Wmissing-prototypes diagnostic.
5b555da1 7833 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7834
f6095868
PE
7835 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7836 shadowing.
7837 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7838 Include <limits.h>.
7839 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7840 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7841 (load_charset_map): Mark variables that gcc -Wuninitialized
7842 does not deduce are never used uninitialized.
53df7c11 7843 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7844
f38b440c
PE
7845 * coding.c (coding_set_source, coding_set_destination):
7846 Use "else { /* comment */ }" rather than "else /* comment */;"
7847 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7848 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7849 a block, when the outer 'i' will do.
7850 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7851 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7852 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7853 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7854 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7855 Rename locals to avoid shadowing.
7856 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7857 * coding.c (emacs_mule_char, encode_invocation_designation):
7858 Now static, since they're not used elsewhere.
413bb2db 7859 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7860 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7861 (decode_coding_emacs_mule): Mark variables that gcc
7862 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7863 (detect_coding_iso_2022): Initialize a local variable that might
7864 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7865 this initialization is needed. (Bug#8211)
5f58e762
PE
7866 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7867 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7868 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7869 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7870 Remove unused macros.
f38b440c 7871
232b38b9 7872 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7873 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7874 * character.c (string_count_byte8): Likewise.
232b38b9 7875
fb90da1b
PE
7876 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7877 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7878
fb93dbc2
PE
7879 * chartab.c (copy_sub_char_table): Now static, since it's not used
7880 elsewhere.
5c156ace
PE
7881 (sub_char_table_ref_and_range, char_table_ref_and_range):
7882 Rename locals to avoid shadowing.
bbcd0949 7883 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7884
7d3b3862 7885 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7886 (BIDI_BOB): Remove unused macro.
7d3b3862 7887
6be7d3da
PE
7888 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7889 deduce are never used uninitialized.
c2ed9c8b 7890 * term.c (encode_terminal_code): Likewise.
6be7d3da 7891
75f8807f 7892 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7893
50938595
PE
7894 * tparam.h: New file.
7895 * term.c, tparam.h: Include it.
7896 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7897 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7898 Move these decls to tparam.h, and make them agree with what
7899 is actually in tparam.c. The previous trick of using incompatible
7900 decls in different modules does not conform to the C standard.
7901 All callers of tparam changed to use tparam's actual API.
7902 * tparam.c (tparam1, tparam, tgoto):
7903 Use const pointers where appropriate.
7904
fbceeba2
PE
7905 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7906 * cm.h (struct cm): Likewise.
7907 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7908 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7909 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7910 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7911 (turn_on_face, init_tty): Likewise.
7912 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7913
7f3f1250
PE
7914 * term.c (term_mouse_position): Rename local to avoid shadowing.
7915
e6ca6543
PE
7916 * alloc.c (mark_ttys): Move decl from here ...
7917 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7918
c40f8d15
AS
79192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7920
7921 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7922
cfe0661d
JB
79232011-03-09 Juanma Barranquero <lekktu@gmail.com>
7924
7925 * search.c (compile_pattern_1): Remove argument regp, unused since
7926 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7927 (compile_pattern): Don't pass it.
7928
0afb4571
J
79292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7930
7931 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7932 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7933 for ! HAVE_GTK3.
7934 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7935
7936 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7937
7938 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7939 gdk_window_get_screen, gdk_window_get_geometry,
7940 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7941 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7942 (xg_get_pixbuf_from_pixmap): New function.
7943 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7944 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7945 Call xg_get_pixbuf_from_pixmap instead of
7946 gdk_pixbuf_get_from_drawable.
7947 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7948 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7949 (xg_check_special_colors): Use GtkStyleContext and its functions
7950 for HAVE_GTK3.
7951 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7952 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7953 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7954 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7955 Call gtk_widget_get_preferred_size.
0afb4571
J
7956 (xg_frame_resized): gdk_window_get_geometry only takes 5
7957 parameters.
44f230aa
SM
7958 (xg_win_to_widget, xg_event_is_for_menubar):
7959 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7960 (xg_set_widget_bg): New function.
7961 (delete_cb): New function.
895009e1 7962 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7963 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7964 (xg_set_background_color): Call xg_set_widget_bg.
7965 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7966 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7967 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7968 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7969 if ! HAVE_GTK3.
7970 (update_frame_tool_bar): Call gtk_widget_hide.
7971 (xg_initialize): Use GDK_KEY_g.
7972
7973 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7974 if ! HAVE_GTK3
7975 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7976
7977 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7978 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7979 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7980
1c2cc4ef
JB
79812011-03-08 Juanma Barranquero <lekktu@gmail.com>
7982
7983 * w32xfns.c (select_palette): Check success of RealizePalette against
7984 GDI_ERROR, not zero.
7985
33383987 7986See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7987
7988;; Local Variables:
7989;; coding: utf-8
aac0c6e3
MR
7990;; End:
7991
33383987 7992 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7993
7994 This file is part of GNU Emacs.
7995
7996 GNU Emacs is free software: you can redistribute it and/or modify
7997 it under the terms of the GNU General Public License as published by
7998 the Free Software Foundation, either version 3 of the License, or
7999 (at your option) any later version.
8000
8001 GNU Emacs is distributed in the hope that it will be useful,
8002 but WITHOUT ANY WARRANTY; without even the implied warranty of
8003 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8004 GNU General Public License for more details.
8005
8006 You should have received a copy of the GNU General Public License
8007 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.