* alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
476371c4
PE
12011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
66606eea
PE
3 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4 Without this fix, if a signal arrives just after memory fills up,
5 'malloc' might be invoked reentrantly.
6
476371c4
PE
7 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8 In other words, assume that every image size is allowed, on non-X
9 hosts. This assumption is probably wrong, but it lets Emacs compile.
10
f3fcc40d
AS
112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12
13 * regex.c (re_iswctype): Convert return values to boolean.
14
350c992f
EZ
152011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
16
17 * xdisp.c (compute_display_string_pos): Don't use cached display
18 string position if the buffer had its restriction changed.
19 (Bug#9184)
20
5266b4bb
PE
212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
22
23 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
24
2573a837 252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 26
41f55ccd 27 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 28
39e378da
PE
29 * bidi.c: Integer size and overflow fixes.
30 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
31 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
32 (bidi_cache_find_level_change, bidi_cache_ensure_space)
33 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
34 (bidi_find_other_level_edge):
35 Use ptrdiff_t instead of EMACS_INT where either will do.
36 This works better on 32-bit hosts configured --with-wide-int.
37 (bidi_cache_ensure_space): Check for size-calculation overflow.
38 Use % rather than repeated addition, for better worst-case speed.
39 Don't set bidi_cache_size until after xrealloc returns, because it
40 might not return.
41 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
42 (bidi_cache_ensure_space): Also check that the bidi cache size
43 does not exceed that of the largest Lisp string or buffer. See Eli
44 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 45
5e927815
PE
46 * alloc.c (__malloc_size_t): Remove.
47 All uses replaced by size_t. See Andreas Schwab's note
48 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
49
ca4aa935
PE
50 * image.c: Improve checking for integer overflow.
51 (check_image_size): Assume that f is nonnull, since
52 it is always nonnull in practice. This is one less thing to
53 worry about when checking for integer overflow later.
54 (x_check_image_size): New function, which checks for integer
55 overflow issues inside X.
56 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
57 This removes the need for a memory_full check.
58 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
59 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
60 (xbm_read_bitmap_data): Change locals back to 'int', since
61 their values must fit in 'int'.
62 (xpm_load_image, png_load, tiff_load):
63 Invoke x_create_x_image_and_pixmap earlier,
64 to avoid much needless work if the image is too large.
65 (tiff_load): Treat overly large images as if
66 x_create_x_image_and_pixmap failed, not as malloc failures.
67 (gs_load): Use x_check_image_size.
68
5f8f9cc2
PE
69 * gtkutil.c: Omit integer casts.
70 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
71 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
72
5adf60bc
PE
73 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
74
c8907a93
PE
75 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
76 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
77 would wrongly return t on a 64-bit host.
78
e3c25c68
PE
79 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
80 The plain *_OVERFLOW macros run afoul of GCC bug 49705
81 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
82 and therefore cause GCC to emit a bogus diagnostic in some cases.
83
3f791afe
PE
84 * image.c: Integer signedness and overflow and related fixes.
85 This is not an exhaustive set of fixes, but it's time to
86 record what I've got.
87 (lookup_pixel_color, check_image_size): Remove redundant decls.
88 (check_image_size): Don't assume that arbitrary EMACS_INT values
89 fit in 'int', or that arbitrary 'double' values fit in 'int'.
90 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
91 (tiff_load, imagemagick_load_image):
92 Check for overflow in size calculations.
93 (x_create_x_image_and_pixmap): Remove unnecessary test for
94 xmalloc returning NULL; that can't happen.
95 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
96 (xpm_color_bucket): Use better integer hashing function.
97 (xpm_cache_color): Don't possibly over-allocate memory.
98 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
99 (gif_memory_source):
100 Use ptrdiff_t, not int or size_t, to record sizes.
101 (png_load): Don't assume values greater than 2**31 fit in 'int'.
102 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
103 either works, as we prefer signed integers.
104 (tiff_read_from_memory, tiff_write_from_memory):
105 Return tsize_t, not size_t, since that's what the TIFF API wants.
106 (tiff_read_from_memory): Don't fail simply because the read would
107 go past EOF; instead, return a short read.
108 (tiff_load): Omit no-longer-needed casts.
109 (Fimagemagick_types): Don't assume size fits into 'int'.
110
3cc5a532
PE
111 Improve hashing quality when configured --with-wide-int.
112 * fns.c (hash_string): New function, taken from sxhash_string.
113 Do not discard information about ASCII character case; this
114 discarding is no longer needed.
115 (sxhash-string): Use it. Change sig to match it. Caller changed.
116 * lisp.h: Declare it.
117 * lread.c (hash_string): Remove, since we now use fns.c's version.
118 The fns.c version returns a wider integer if --with-wide-int is
119 specified, so this should help the quality of the hashing a bit.
120
b312a492
PE
121 * emacs.c: Integer overflow minor fix.
122 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
123 Define only if GNU_LINUX.
124 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
125
dfd153ae
PE
126 * dispnew.c: Integer signedness and overflow fixes.
127 Remove unnecessary forward decls, that were a maintenance hassle.
128 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
129 All uses changed.
130 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
131 (scrolling_window): Use ptrdiff_t, not int, for byte count.
132 (prepare_desired_row, line_draw_cost):
133 Use int, not unsigned, where either works.
134 (save_current_matrix, restore_current_matrix):
135 Use ptrdiff_t, not size_t, where either works.
136 (init_display): Check for overflow more accurately, and without
137 relying on undefined behavior.
138
a81d11a3
PE
139 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
140 Remove, replacing with the new symbols in lisp.h. All uses changed.
141 * fileio.c (make_temp_name):
142 * filelock.c (lock_file_1, lock_file):
143 * xdisp.c (message_dolog):
144 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
145 Use pMd etc. instead.
146 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
147 replacing the pWIDE etc. symbols removed from editfns.c.
148
3300e6fd
PE
149 * keyboard.h (num_input_events): Now uintmax_t.
150 This is (very slightly) less likely to mess up due to wraparound.
151 All uses changed.
152
fd05c7e9
PE
153 * buffer.c: Integer signedness fixes.
154 (alloc_buffer_text, enlarge_buffer_text):
155 Use ptrdiff_t rather than size_t when either will do, as we prefer
156 signed integers.
157
903fe15d
PE
158 * alloc.c: Integer signedness and overflow fixes.
159 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
160 (__malloc_size_t): Default to size_t, not to int.
161 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
162 (Fgarbage_collect, mark_object_loop_halt, mark_object):
163 Prefer ptrdiff_t to size_t when either would do, as we prefer
164 signed integers.
165 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
166 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
167 Now const. Initialize with values that are in range even if char
168 is signed.
169 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
170 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
171 These functions do the right thing with sizes > 2**32.
172 (check_depth): Now ptrdiff_t, not int.
173 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
174 Adjust to new way of storing sizes. Check for size overflow bugs
175 in rest of code.
176 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
177 slightly wrong anyway, as it missed one instance of
178 XMALLOC_OVERRUN_CHECK_OVERHEAD.
179 (refill_memory_reserve): Omit needless cast to size_t.
180 (mark_object_loop_halt): Mark as externally visible.
181
ac82cc6a
PE
182 * xselect.c: Integer signedness and overflow fixes.
183 (Fx_register_dnd_atom, x_handle_dnd_message):
184 Use ptrdiff_t, not size_t, since we prefer signed.
185 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
186 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
187 x_dnd_atoms_size and x_dnd_atoms_length.
188
c2d1e36d
PE
189 * doprnt.c: Prefer signed to unsigned when either works.
190 * eval.c (verror):
191 * doprnt.c (doprnt):
192 * lisp.h (doprnt):
193 * xdisp.c (vmessage):
194 Use ptrdiff_t, not size_t, when using or implementing doprnt,
195 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
196 prefer signed arithmetic to avoid comparison confusion.
197 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
198 but is a bit tricky.
199
0e926e56
PE
200 Assume freestanding C89 headers, string.h, stdlib.h.
201 * data.c, doprnt.c, floatfns.c, print.c:
202 Include float.h unconditionally.
203 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
204 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
205 * regex.c: Likewise for stddef.h, string.h.
206 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
207 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
208 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
209 (STDC_HEADERS): Remove obsolete defines.
210 * sysdep.c: Include limits.h unconditionally.
211
9cfdb3ec
PE
212 Assume support for memcmp, memcpy, memmove, memset.
213 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
214 * regex.c (memcmp, memcpy):
215 Remove; we assume C89 now.
216
217 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
218 (__malloc_safe_bcopy): Remove; no longer needed.
219
cf950e6b 220 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
221 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
222 well either way, and we prefer signed to unsigned.
223
dbf38e02
LMI
2242011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
225
226 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
227 closes the connection while we're reading (bug#9182).
228
d6f0886c
JD
2292011-07-25 Jan Djärv <jan.h.d@swipnet.se>
230
231 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
232 are specified (Bug#9168).
233
2eb1f9e6
PE
2342011-07-25 Paul Eggert <eggert@cs.ucla.edu>
235
236 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
237 Found by GCC static checking and --with-wide-int on a 32-bit host.
238
22381272 2392011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
240
241 * xdisp.c (compute_display_string_pos): Fix logic of caching
242 previous display string position. Initialize cached_prev_pos to
243 -1. Fixes slow-down at the beginning of a buffer.
244
f25e39b4
EZ
2452011-07-24 Eli Zaretskii <eliz@gnu.org>
246
247 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
248 for attrs[LFACE_FONTSET_INDEX].
249
04c4b52e
PE
2502011-07-23 Paul Eggert <eggert@cs.ucla.edu>
251
252 * xml.c (parse_region): Remove unused local
253 that was recently introduced.
254
c1734fbd
EZ
2552011-07-23 Eli Zaretskii <eliz@gnu.org>
256
be18c5a5
EZ
257 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
258 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
259
c1734fbd
EZ
260 * xdisp.c (move_it_in_display_line_to): Record the best matching
261 position for TO_CHARPOS while scanning the line, and restore it on
262 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
263 vertical-motion and pos-visible-in-window-p under bidi redisplay
264 when exact match is impossible due to invisible text, and the
265 lines are truncated.
266
a258d627
JD
2672011-07-23 Jan Djärv <jan.h.d@swipnet.se>
268
269 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
270 for OSX >= 10.7.
271
b6d5a689
EZ
2722011-07-22 Eli Zaretskii <eliz@gnu.org>
273
0f74f785
EZ
274 Fix a significant slow-down of cursor motion with C-n, C-p,
275 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
276 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 277 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
278 (next_element_from_buffer): Call compute_stop_pos_backwards to
279 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
280 base_level_stop.
281 (reseat): Don't look for prev_stop, as that could mean a very long
282 run.
283 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
284 <cached_disp_overlay_modiff>: Cache for last found display string
285 position.
551918c1 286 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
287 about the same buffer in the same area of character positions, and
288 the buffer wasn't changed since the time the display string
289 position was cached.
551918c1 290
b2d0c91a
EZ
2912011-07-22 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
294 is an integer, which is important for empty lines. (Bug#9149)
295
043604ee
CY
2962011-07-22 Chong Yidong <cyd@stupidchicken.com>
297
298 * frame.c (Fmodify_frame_parameters): In tty case, update the
299 default face if necessary (Bug#4238).
300
da4adb04
CY
3012011-07-21 Chong Yidong <cyd@stupidchicken.com>
302
303 * editfns.c (Fstring_to_char): No need to explain what a character
304 is in the docstring (Bug#6576).
305
9abd0532
LMI
3062011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
307
308 * xml.c (parse_region): Make sure we always return a tree.
309
36881d16
HK
3102011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
311
312 * xml.c (parse_region): If a document contains only comments,
313 return that, too.
314
1e98674d
LMI
3152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
316
317 * xml.c (make_dom): Return comments, too.
318
590bd467
PE
3192011-07-19 Paul Eggert <eggert@cs.ucla.edu>
320
321 Port to OpenBSD.
322 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
323 and the surrounding thread.
324 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
325 rather than fgets, and retry after EINTR. Otherwise, 'emacs
326 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
327 timer goes off.
328 * s/openbsd.h (BROKEN_SIGIO): Define.
329 * unexelf.c (unexec) [__OpenBSD__]:
330 Don't update the .mdebug section of the Alpha COFF symbol table.
331
f41628b2
LMI
3322011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
333
334 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
335 (bug#8460).
336
b59b67c5
PE
3372011-07-18 Paul Eggert <eggert@cs.ucla.edu>
338
15e3a074
PE
339 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
340 This fixes some race conditions on the permissions of any newly
341 created file.
342
41bed37d
PE
343 * alloc.c (valid_pointer_p): Use pipe, not open.
344 This fixes some permissions issues when debugging.
345
b59b67c5
PE
346 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
347 If fchown fails to set both uid and gid, try to set just gid,
348 as that is sometimes allowed. Adjust the file's mode to eliminate
349 setuid or setgid bits that are inappropriate if fchown fails.
350
925a6be7
SM
3512011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
352
353 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
354 to compare Lisp_Objects.
355 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
356 global_gnutls_log_level, don't mistake it for a Lisp_Object.
357 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
358
52968808
AS
3592011-07-17 Andreas Schwab <schwab@linux-m68k.org>
360
0a6a104b
AS
361 * lread.c (read_integer): Unread even EOF character.
362 (read1): Likewise. Properly record start position of symbol.
363
52968808
AS
364 * lread.c (read1): Read `#:' as empty uninterned symbol if no
365 symbol character follows.
366
9e381cdd
PE
3672011-07-17 Paul Eggert <eggert@cs.ucla.edu>
368
369 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
370 This works around a problem with the previous change to Fcopy_file.
371 Recent glibc declares fchown with __attribute__((warn_unused_result)),
372 and without this change, GCC might complain about discarding
373 fchown's return value.
374
b5641435
JB
3752011-07-16 Juanma Barranquero <lekktu@gmail.com>
376
377 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
378
a8031457
PE
3792011-07-16 Paul Eggert <eggert@cs.ucla.edu>
380
381 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
382
dd889327
LMI
3832011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
384
750c33f7
LMI
385 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
386 it's used from the C level.
387
dd889327
LMI
388 * process.c: Use the same condition for POLL_FOR_INPUT in both
389 keyboard.c and process.c (bug#1858).
390
87e86684
LM
3912011-07-09 Lawrence Mitchell <wence@gmx.li>
392
393 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
394 (Fgnutls_boot): Use it.
395
64348f40
AS
3962011-07-15 Andreas Schwab <schwab@linux-m68k.org>
397
398 * doc.c (Fsubstitute_command_keys): Revert last change.
399
1d698799
LMI
4002011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
401
f863868c
LMI
402 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
403 quotes the next character, and doesn't affect other longer
404 sequences (bug#8935).
405
1d698799
LMI
406 * lread.c (syms_of_lread): Clarify that is isn't only
407 `eval-buffer' and `eval-defun' that's affected by
408 `lexical-binding' (bug#8460).
409
aa4b6df6
EZ
4102011-07-15 Eli Zaretskii <eliz@gnu.org>
411
412 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
413 bidi redisplay when a line includes both an image and is
414 truncated.
415
5d856da6
PE
4162011-07-14 Paul Eggert <eggert@cs.ucla.edu>
417
ad6042bb
PE
418 Fix minor problems found by static checking.
419 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
420 (elsz): Now a signed constant, not a size_t var. We prefer signed
421 types to unsigned, to avoid integer comparison confusion. Without
422 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
423 "cannot optimize loop, the loop counter may overflow", a symptom
424 of the confusion.
f00bbb22 425 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
426 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
427
6468f31c
LMI
4282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
429
49080b10
LMI
430 * search.c (Fre_search_backward): Mention `case-fold-search' in
431 all the re_search_* functions (bug#8138).
432
6468f31c
LMI
433 * keyboard.c (Fopen_dribble_file): Document when the file is
434 closed (bug#8056).
435
c965adc5
EZ
4362011-07-14 Eli Zaretskii <eliz@gnu.org>
437
df9733bf
EZ
438 * bidi.c (bidi_dump_cached_states): Fix format of displaying
439 bidi_cache_idx.
440
0bb23927
EZ
441 Support bidi reordering of display and overlay strings.
442 * xdisp.c (compute_display_string_pos)
443 (compute_display_string_end): Accept additional argument STRING.
444 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
445 (reseat_to_string): Initialize bidi_it->string.s and
446 bidi_it->string.schars.
447 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
448 NULL (avoids a crash in bidi_paragraph_init). Initialize
449 itb.string.lstring.
450 (init_iterator): Call bidi_init_it only of a valid
451 buffer position was specified. Initialize paragraph_embedding to
452 L2R.
453 (reseat_to_string): Initialize the bidi iterator.
454 (display_string): If we need to ignore text properties of
455 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
456 original value of -1 will not work with bidi.)
457 (compute_display_string_pos): First arg is now struct
458 `text_pos *'; all callers changed. Support display properties on
459 Lisp strings.
460 (compute_display_string_end): Support display properties on Lisp
461 strings.
462 (init_iterator, reseat_1, reseat_to_string): Initialize the
463 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
464 when iterating on a string not from display properties).
465 (compute_display_string_pos, compute_display_string_end): Fix
466 calculation of the object to scan. Fixes an error when using
467 arrow keys.
468 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
469 base_level_stop; instead, set base_level_stop to BEGV. Fixes
470 crashes in vertical-motion.
471 (next_element_from_buffer): Improve commentary for when
472 the iterator is before prev_stop.
473 (init_iterator): Initialize bidi_p from the default value of
474 bidi-display-reordering, not from buffer-local value. Use the
475 buffer-local value only if initializing for buffer iteration.
476 (handle_invisible_prop): Support invisible properties on strings
477 that are being bidi-reordered.
478 (set_iterator_to_next): Support bidi reordering of C strings and
479 Lisp strings.
480 (next_element_from_string): Support bidi reordering of Lisp
481 strings.
482 (handle_stop_backwards): Support Lisp strings as well.
483 (display_string): Support display of R2L glyph rows. Use
484 IT_STRING_CHARPOS when displaying from a Lisp string.
485 (init_iterator): Don't initialize it->bidi_p for strings
486 here.
487 (reseat_to_string): Initialize it->bidi_p for strings here.
488 (next_element_from_string, next_element_from_c_string)
489 (next_element_from_buffer): Add xassert's for correspondence
490 between IT's object being iterated and it->bidi_it.string
491 structure.
492 (face_before_or_after_it_pos): Support bidi iteration.
493 (next_element_from_c_string): Handle the case of the first string
494 character that is not the first one in the visual order.
495 (get_visually_first_element): New function, refactored from common
496 parts of next_element_from_buffer, next_element_from_string, and
497 next_element_from_c_string.
498 (tool_bar_lines_needed, redisplay_tool_bar)
499 (display_menu_bar): Force left-to-right direction. Add a FIXME
500 comment for making that be controlled by a user option.
501 (push_it, pop_it): Save and restore the state of the
502 bidi iterator. Save and restore the bidi_p flag.
503 (pop_it): Iterate out of display property for string iteration as
504 well.
505 (iterate_out_of_display_property): Support iteration over strings.
506 (handle_single_display_spec): Set up it->bidi_it for iteration
507 over a display string, and call bidi_init_it.
508 (handle_single_display_spec, next_overlay_string)
509 (get_overlay_strings_1, push_display_prop): Set up the bidi
510 iterator for displaying display or overlay strings.
511 (forward_to_next_line_start): Don't use the shortcut if
512 bidi-iterating.
513 (back_to_previous_visible_line_start): If handle_display_prop
514 pushed the iterator stack, restore the internal state of the bidi
515 iterator by calling bidi_pop_it same number of times.
516 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
517 and we are bidi-iterating, don't decrement the iterator position;
518 instead, set the first_elt flag in the bidi iterator, to produce
519 the same effect.
520 (reseat_1): Remove redundant setting of string_from_display_prop_p.
521 (push_display_prop): xassert that we are iterating a buffer.
522 (push_it, pop_it): Save and restore paragraph_embedding member.
523 (handle_single_display_spec, next_overlay_string)
524 (get_overlay_strings_1, reseat_1, reseat_to_string)
525 (push_display_prop): Set up the `unibyte' member of bidi_it.string
526 correctly. Don't assume unibyte strings are not bidi-reordered.
527 (compute_display_string_pos)
528 (compute_display_string_end): Fix handling the case of C string.
529 (push_it, pop_it): Save and restore from_disp_prop_p.
530 (handle_single_display_spec, push_display_prop): Set the
531 from_disp_prop_p flag.
532 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
533 (pop_it): Call iterate_out_of_display_property only if we are
534 popping after iteration over a string that came from a display
535 property. Fix a typo in popping stretch info. Add an assertion
536 for verifying that the iterator position is in sync with the bidi
537 iterator.
538 (handle_single_display_spec, get_overlay_strings_1)
539 (push_display_prop): Fix initialization of paragraph direction for
540 string when that of the parent object is not yet determined.
541 (reseat_1): Call bidi_init_it to resync the bidi
542 iterator with IT's position. (Bug#7616)
543 (find_row_edges): If ROW->start.pos gives position
544 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
545 (handle_stop, back_to_previous_visible_line_start, reseat_1):
546 Reset the from_disp_prop_p flag.
547 (SAVE_IT, RESTORE_IT): New macros.
548 (pos_visible_p, face_before_or_after_it_pos)
549 (back_to_previous_visible_line_start)
550 (move_it_in_display_line_to, move_it_in_display_line)
551 (move_it_to, move_it_vertically_backward, move_it_by_lines)
552 (try_scrolling, redisplay_window, display_line): Use them when
553 saving a temporary copy of the iterator and restoring it back.
554 (back_to_previous_visible_line_start, reseat_1)
555 (init_iterator): Empty the bidi cache "stack".
556 (move_it_in_display_line_to): If iterator ended up at
557 EOL, but we never saw any buffer positions smaller than
558 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
559 motion in bidi-reordered lines.
560 (move_it_in_display_line_to): Record prev_method and prev_pos
561 immediately before the call to set_iterator_to_next. Fixes cursor
562 motion in bidi-reordered lines with stretch glyphs and strings
563 displayed in margins. (Bug#8133) (Bug#8867)
564 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
565 TO_CHARPOS.
566 (pos_visible_p): Support positions in bidi-reordered lines. Save
567 and restore bidi cache.
568
569 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
570 (bidi_paragraph_info): Delete unused struct.
571 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
572 (bidi_cache_start): New variable.
573 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
574 to zero.
575 (bidi_cache_fetch_state, bidi_cache_search)
576 (bidi_cache_find_level_change, bidi_cache_iterator_state)
577 (bidi_cache_find, bidi_peek_at_next_level)
578 (bidi_level_of_next_char, bidi_find_other_level_edge)
579 (bidi_move_to_visually_next): Compare cache index with
580 bidi_cache_start rather than with zero.
581 (bidi_fetch_char): Accept new argument STRING; all callers
582 changed. Support iteration over a string. Support strings with
583 display properties. Support unibyte strings. Fix the type of
584 `len' according to what STRING_CHAR_AND_LENGTH expects.
585 (bidi_paragraph_init, bidi_resolve_explicit_1)
586 (bidi_resolve_explicit, bidi_resolve_weak)
587 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
588 iteration over a string.
589 (bidi_set_sor_type, bidi_resolve_explicit_1)
590 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
591 can now be zero (for strings); special values 0 and -1 were
592 changed to -1 and -2, respectively.
593 (bidi_char_at_pos): New function.
594 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
595 Call it instead of FETCH_MULTIBYTE_CHAR.
596 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
597 initialized to valid values.
598 (bidi_init_it): Don't initialize charpos and bytepos with invalid
599 values.
600 (bidi_level_of_next_char): Allow the sentinel "position" to pass
601 the test for valid cached positions. Fix the logic for looking up
602 the sentinel state in the cache. GCPRO the Lisp string we are
603 iterating.
604 (bidi_push_it, bidi_pop_it): New functions.
605 (bidi_initialize): Initialize the bidi cache start stack pointer.
606 (bidi_cache_ensure_space): New function, refactored from part of
607 bidi_cache_iterator_state. Don't assume the required size is just
608 one BIDI_CACHE_CHUNK away.
609 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
610 (bidi_count_bytes, bidi_char_at_pos): New functions.
611 (bidi_cache_search): Don't assume bidi_cache_last_idx is
612 always valid if bidi_cache_idx is valid.
613 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
614 is valid if it's going to be used.
615 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
616 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
617 (bidi_cache_find_level_change, bidi_cache_ensure_space)
618 (bidi_cache_iterator_state, bidi_cache_find)
619 (bidi_find_other_level_edge, bidi_cache_start_stack): All
620 variables related to cache indices are now EMACS_INT.
621
0bb23927
EZ
622 * dispextern.h (struct bidi_string_data): New structure.
623 (struct bidi_it): New member `string'. Make flag members be 1-bit
624 fields, and put them last in the struct.
625 (compute_display_string_pos, compute_display_string_end): Update
626 prototypes.
627 (bidi_push_it, bidi_pop_it): Add prototypes.
628 (struct iterator_stack_entry): New members bidi_p,
629 paragraph_embedding, and from_disp_prop_p.
630 (struct it): Member bidi_p is now a bit field 1 bit wide.
631 (bidi_shelve_cache, bidi_unshelve_cache): Declare
632 prototypes.
633
634 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
635 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
636 and vector-like objects.
637
638 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
639 cache around display iteration.
640
641 * window.c (Fwindow_end, window_scroll_pixel_based)
642 (displayed_window_lines, Frecenter): Save and restore the bidi
643 cache around display iteration.
644
3bbd2265
LMI
6452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
646
647 * editfns.c (Fdelete_region): Clarify the use of the named
648 parameters (bug#6788).
649
adc47434
MR
6502011-07-14 Martin Rudalics <rudalics@gmx.at>
651
652 * indent.c (Fvertical_motion): Set and restore w->pointm when
653 saving and restoring the window's buffer (Bug#9006).
654
837c31f8
LMI
6552011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
656
657 * editfns.c (Fstring_to_char): Clarify just what is returned
658 (bug#6576). Text by Eli Zaretskii.
659
ac389d0c
JB
6602011-07-13 Juanma Barranquero <lekktu@gmail.com>
661
662 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
663
0be0ce47
EZ
6642011-07-13 Eli Zaretskii <eliz@gnu.org>
665
666 * buffer.c (mmap_find): Fix a typo.
667
cd18e7e3
JB
6682011-07-13 Johan Bockgård <bojohan@gnu.org>
669
670 Fix execution of x selection hooks.
671 * xselect.c (Qx_lost_selection_functions)
672 (Qx_sent_selection_functions): New vars.
673 (syms_of_xselect): DEFSYM them.
674 (x_handle_selection_request): Pass Qx_sent_selection_functions
675 rather than Vx_sent_selection_functions to Frun_hook_with_args.
676 (x_handle_selection_clear,x_clear_frame_selections):
677 Pass Qx_lost_selection_functions rather than
678 Vx_lost_selection_functions to Frun_hook_with_args.
679
47ea7f44
PE
6802011-07-13 Paul Eggert <eggert@cs.ucla.edu>
681
ac389d0c 682 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
683 The old code sometimes used this field without initializing it.
684
47ea7f44
PE
685 * alloc.c (gc_sweep): Don't read past end of array.
686 In theory, the old code could also have corrupted Emacs internals,
687 though it'd be very unlikely.
688
bc985c87
AS
6892011-07-12 Andreas Schwab <schwab@linux-m68k.org>
690
691 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 692 argument. (Bug#4026)
bc985c87 693
0cf34688
LMI
6942011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
695
b3dadd76
LMI
696 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
697 key" (bug#4257).
698
0cf34688
LMI
699 * window.c (Fset_window_start): Doc fix (bug#4199).
700 (Fset_window_hscroll): Ditto.
701
270768cd
PE
7022011-07-12 Paul Eggert <eggert@cs.ucla.edu>
703
077e3dda 704 Fix minor new problems caught by GCC 4.6.1.
270768cd 705 * term.c (init_tty): Remove unused local.
490011a6 706 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 707 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 708 not used otherwise.
270768cd 709
b1f58454
CY
7102011-07-12 Chong Yidong <cyd@stupidchicken.com>
711
712 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
713
22b9578d
LMI
7142011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
715
6e70ab07
LMI
716 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
717 are the mini-buffer and the echo area (bug#3320).
718
22b9578d
LMI
719 * term.c (init_tty): Remove support for supdup, c10 and perq
720 terminals, which are no longer supported (bug#1482).
721
8974cc9f
JB
7222011-07-10 Johan Bockgård <bojohan@gnu.org>
723
724 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
725
a560d974
JD
7262011-07-10 Jan Djärv <jan.h.d@swipnet.se>
727
728 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
729 for non-popups (Bug#3642).
730
1dae0f0a
AS
7312011-07-10 Andreas Schwab <schwab@linux-m68k.org>
732
268c2c36 733 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 734 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
735 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
736 * cm.c (losecursor): Likewise.
1dae0f0a
AS
737 * data.c (fmod): Likewise.
738 * dispnew.c (swap_glyphs_in_rows): Likewise.
739 * emacs.c (memory_warning_signal): Likewise.
740 * floatfns.c (float_error): Likewise.
741 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
742 (otf_open, font_otf_capability, generate_otf_features)
743 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
744 Likewise.
745 * image.c (pbm_read_file): Likewise.
746 * indent.c (string_display_width): Likewise.
747 * intervals.c (check_for_interval, search_for_interval)
748 (inc_interval_count, count_intervals, root_interval)
749 (adjust_intervals_for_insertion, make_new_interval): Likewise.
750 * lread.c (defalias): Likewise.
268c2c36 751 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
752 * regex.c (set_image_of_range_1, set_image_of_range)
753 (regex_grow_registers): Likewise.
754 * sysdep.c (strerror): Likewise.
755 * termcap.c (valid_filename_p, tprint, main): Likewise.
756 * tparam.c (main): Likewise.
757 * unexhp9k800.c (run_time_remap, save_data_space)
758 (update_file_ptrs, read_header, write_header, calculate_checksum)
759 (copy_file, copy_rest, display_header): Likewise.
760 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
761 Likewise.
762 * xdisp.c (check_it): Likewise.
763 * xfaces.c (register_color, unregister_color, unregister_colors):
764 Likewise.
765 * xfns.c (print_fontset_result): Likewise.
766 * xrdb.c (member, fatal, main): Likewise.
767
99033785
PE
7682011-07-10 Paul Eggert <eggert@cs.ucla.edu>
769
770 Fix minor problems found by static checking (Bug#9031).
771 * chartab.c (char_table_set_range, map_sub_char_table):
772 Remove unused locals.
773 (uniprop_table): Now static.
774 * composite.c (_work_char): Remove unused static var.
775
9cb2ac56
JB
7762011-07-09 Juanma Barranquero <lekktu@gmail.com>
777
778 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
779
f25661f0
JD
7802011-07-09 Jan Djärv <jan.h.d@swipnet.se>
781
782 * gtkutil.c (qttip_cb): Remove code without function.
783
8278c4fe
EZ
7842011-07-09 Eli Zaretskii <eliz@gnu.org>
785
786 * w32.c (pthread_sigmask): New stub.
787
1692ae2d 7882011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 789
8a6ebd58 790 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
791 sigprocmask is portable only for single-threaded applications, and
792 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
793 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
794 (LIBES): Use it.
795 * callproc.c (Fcall_process):
796 * process.c (create_process):
797 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
798 Use pthread_sigmask, not sigprocmask.
123403e4 799
1b854618
JD
8002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
801
802 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
803 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
804 wrong (Bug#8591).
805
3fe4b549
JD
8062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
807
0ce7e563
JD
808 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
809 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
810 (xg_hide_tooltip): Fix comment.
811
3fe4b549
JD
812 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
813 in registerServicesMenuSendTypes.
814 (validRequestorForSendType): Don't check ns_return_types.
815
816 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
817 ns_return_type.
818
5df75e47
JR
8192011-07-08 Jason Rumney <jasonr@gnu.org>
820
821 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
822 frame struct members of non-existent frames (Bug#6284).
823
699c10bd
JD
8242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
825
4393663b
JD
826 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
827 variable firstTime not needed on OSX >= 10.6.
828 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
829 >= 10.5. Use setKnobProportion, setDoubleValue.
830
831 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
832 (MAC_OS_X_VERSION_10_5): Define if not defined.
833 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
834 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
835 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
836
837 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
838 cString and lossyCString on OSX >= 10.4
839
840 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
841 sizeToFit on OSX >= 10.2.
842
843 * nsimage.m (allocInitFromFile): Don't use deprecated method
844 bestRepresentationForDevice on OSX >= 10.6.
845
846 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
847 to avoid warning.
848
849 * emacs.c: Declare unexec_init_emacs_zone.
850
a63e0781
JD
851 * nsgui.h: Fix compiler warning about gnulib redefining verify.
852
699c10bd
JD
853 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
854
855 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
856 on svcsMenu (Bug#8842).
857
858 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
859 ns_return_types.
860 (Fns_list_services): Just return Qnil on 10.6, code not working there.
861
862 * nsterm.m (QUTF8_STRING): Declare.
863 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
864 (validRequestorForSendType): Return type is (id).
865 Change indexOfObjectIdenticalTo to indexOfObject.
866 Check if we have local selection before returning self (Bug#8842).
867 (writeSelectionToPasteboard): Put local selection into paste board
868 if we have a local selection (Bug#8842).
869 (syms_of_nsterm): DEFSYM QUTF8_STRING.
870
871 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
872 (ns_get_local_selection): Declare.
873
54e10184
LMI
8742011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
875
9888ff71
LMI
876 * keymap.c (describe_map_tree): Don't insert a double newline at
877 the end of the buffer (bug#1169) and return whether we inserted
878 something.
879
54e10184
LMI
880 * callint.c (Fcall_interactively): Change "reading args" to
881 "providing args" to try to clarify what it does (bug#1010).
882
15fa4783
KH
8832011-07-07 Kenichi Handa <handa@m17n.org>
884
885 * composite.c (composition_compute_stop_pos): Ignore a static
886 composition starting before CHARPOS (Bug#8915).
887
888 * xdisp.c (handle_composition_prop): Likewise.
889
a8815b00
EZ
8902011-07-07 Eli Zaretskii <eliz@gnu.org>
891
892 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
893 (Bug#9015)
894
ef7b981d 8952011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
896
897 * character.h (unicode_category_t): New enum type.
898
899 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
900 (Qchar_code_property_table): New variable.
901 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
902 (UNIPROP_COMPRESSED_FORM_P): New macros.
903 (char_table_ascii): Uncompress the compressed values.
904 (sub_char_table_ref): New arg is_uniprop. Callers changed.
905 Uncompress the compressed values.
ac389d0c 906 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
907 (char_table_ref_and_range): Uncompress the compressed values.
908 (sub_char_table_set): New arg is_uniprop. Callers changed.
909 Uncompress the compressed values.
910 (sub_char_table_set_range): Args changed. Callers changed.
911 (char_table_set_range): Adjuted for the above change.
912 (map_sub_char_table): Delete args default_val and parent. Add arg
913 top. Give decoded values to a Lisp function.
914 (map_char_table): Adjusted for the above change. Give decoded
915 values to a Lisp function. Gcpro more variables.
916 (uniprop_table_uncompress)
917 (uniprop_decode_value_run_length): New functions.
918 (uniprop_decoder, uniprop_decoder_count): New variables.
919 (uniprop_get_decoder, uniprop_encode_value_character)
920 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
921 New functions.
922 (uniprop_encoder, uniprop_encoder_count): New variables.
923 (uniprop_get_encoder, uniprop_table)
924 (Funicode_property_table_internal, Fget_unicode_property_internal)
925 (Fput_unicode_property_internal): New functions.
926 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
927 Sunicode_property_table_internal, Sget_unicode_property_internal,
928 and Sput_unicode_property_internal. Defvar_lisp
929 char-code-property-alist.
930
931 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
932 Vunicode_category_table.
933
934 * font.c (font_range): Adjusted for the change of
935 Vunicode_category_table.
936
76b397fb
DN
9372011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
938
939 * m/iris4d.h: Remove file, move contents ...
940 * s/irix6-5.h: ... here.
941
22b4128e
PE
9422011-07-06 Paul Eggert <eggert@cs.ucla.edu>
943
944 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
945 * alloc.c (mark_buffer):
946 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
947 (clone_per_buffer_values): Don't assume that
22b4128e
PE
948 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
949 This isn't true in general, and it's particularly not true
950 if Emacs is configured with --with-wide-int.
951 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
952 New macros, used in the buffer.c change.
953
869795d6
JD
9542011-07-05 Jan Djärv <jan.h.d@swipnet.se>
955
956 * xsettings.c: Use both GConf and GSettings if both are available.
957 (store_config_changed_event): Add comment.
958 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
959 (store_tool_bar_style_changed): New functions.
960 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
961 (struct xsettings): Move font inside HAVE_XFT.
962 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
963 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
964 Move inside HAVE_XFT.
965 (something_changed_gsettingsCB): Renamed from something_changedCB.
966 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
967 also.
968 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
969 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
970 (something_changed_gconfCB): Renamed from something_changedCB.
971 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
972 (parse_settings): Move check for font inside HAVE_XFT.
973 (read_settings, apply_xft_settings): Add comment.
974 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
975 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
976 call store_font_name_changed.
977 (xft_settings_event): Add comment.
978 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
979 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
980 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
981 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
982 (xsettings_initialize): Call init_gsettings last.
983 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
984 comment.
985
d8ed26bd
PE
9862011-07-05 Paul Eggert <eggert@cs.ucla.edu>
987
988 Random fixes. E.g., (random) never returned negative values.
989 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
990 subseconds part to the entropy, as that's a bit more random.
991 Prefer signed to unsigned, since the signedness doesn't matter and
992 in general we prefer signed. When given a limit, use a
993 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
994 latter isn't right if USE_2_TAGS_FOR_INTS.
995 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
996 not 0..VALMASK. Don't discard "excess" bits that random () returns.
997
cabf1cac
SM
9982011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
999
1000 * textprop.c (text_property_stickiness):
1001 Obey Vtext_property_default_nonsticky.
1002 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1003 * w32fns.c (syms_of_w32fns):
1004 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1005
6e9b2be9
PE
10062011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1009 This is more efficient than Ffile_directory_p and avoids a minor race.
1010
90186c68
LMI
10112011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1012
7c301272
LMI
1013 * buffer.c (Foverlay_put): Say what the return value is
1014 (bug#7835).
1015
c4f2d8d4
LMI
1016 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1017 is a directory before asking whether to use the file name
1018 (bug#7564).
ad637907
LMI
1019 (barf_or_query_if_file_exists): Make the "File is a directory"
1020 error be more correct.
c4f2d8d4 1021
90186c68
LMI
1022 * fns.c (Frequire): Remove the mention of the .gz files, since
1023 that's installation-specific, but keep the mention of
1024 `get-load-suffixes'.
1025
da64016e
PE
10262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1029 Report string overflow if the output is too long.
1030
7d47b580
JB
10312011-07-04 Juanma Barranquero <lekktu@gmail.com>
1032
a555cb87
JB
1033 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1034 (syms_of_gnutls): Remove duplicate DEFSYM for
1035 Qgnutls_bootprop_verify_hostname_error, an error for
1036 Qgnutls_bootprop_verify_error (which is no longer used).
1037
7d47b580
JB
1038 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1039 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1040 Also (re)move comments that are misplaced or no longer relevant.
1041
1e49bfab
LMI
10422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1043
1044 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1045
1485f4c0
CY
10462011-07-03 Chong Yidong <cyd@stupidchicken.com>
1047
1048 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1049 and background color parameters if they have been changed.
1050
a9ab721e
LMI
10512011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1052
1053 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1054
cf7cff57
PE
10552011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1056
2e13213d
PE
1057 * xsettings.c (SYSTEM_FONT): Define only when used.
1058 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1059
cf7cff57
PE
1060 * keymap.c (access_keymap_1): Now static.
1061
7a8e04f7
CY
10622011-07-02 Chong Yidong <cyd@stupidchicken.com>
1063
1064 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1065 leave any prefix arg for the up event (Bug#1586).
1066
61352f62
LMI
10672011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1068
69bb1ef7
LMI
1069 * lread.c (syms_of_lread): Mention single symbols defined by
1070 `defvar' or `defconst' (bug#7154).
1071
61352f62 1072 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1073 (Frequire): Mention get-load-suffixes.
61352f62 1074
28545e04
MR
10752011-07-02 Martin Rudalics <rudalics@gmx.at>
1076
1077 * window.h (window): Remove clone_number slot.
1078 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1079 Remove.
1080 (make_parent_window, make_window, saved_window)
1081 (Fset_window_configuration, save_window_save): Don't deal with
1082 clone numbers.
1083 * buffer.c (Qclone_number): Remove declaration.
1084 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1085
3349e122
SM
10862011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1087
1088 Add multiple inheritance to keymaps.
1089 * keymap.c (Fmake_composed_keymap): New function.
1090 (Fset_keymap_parent): Simplify.
1091 (fix_submap_inheritance): Remove.
1092 (access_keymap_1): New function extracted from access_keymap to handle
1093 embedded parents and handle lists of maps.
1094 (access_keymap): Use it.
1095 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1096 (Fcopy_keymap): Handle embedded parents.
1097 (Fcommand_remapping, define_as_prefix): Simplify.
1098 (Fkey_binding): Simplify.
1099 (syms_of_keymap): Move minibuffer-local-completion-map,
1100 minibuffer-local-filename-completion-map,
1101 minibuffer-local-must-match-map, and
1102 minibuffer-local-filename-must-match-map to Elisp.
1103 (syms_of_keymap): Defsubr make-composed-keymap.
1104 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1105 (parse_menu_item): Trivial simplification.
1106
3279eb87
GM
11072011-07-01 Glenn Morris <rgm@gnu.org>
1108
1109 * Makefile.in (SETTINGS_LIBS): Fix typo.
1110
4550efdf
KI
11112011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1112
1113 * coding.c (Fencode_coding_string): Record the last coding system
1114 used, as the function doc string says (bug#8738).
1115
0949d2b6
JD
11162011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1117
1118 * xsettings.c (store_monospaced_changed): Take new font as arg and
1119 check for change against current_mono_font.
1120 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1121 (emacs_settings_constructor, emacs_settings_get_property)
1122 (emacs_settings_set_property, emacs_settings_class_init)
1123 (emacs_settings_init, gsettings_obj): Remove.
1124 (something_changedCB): New function for HAVE_GSETTINGS.
1125 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1126 with value as argument.
1127 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1128 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1129 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1130 "changed".
1131
1132 * xgselect.c: Add defined (HAVE_GSETTINGS).
1133 (xgselect_initialize): Ditto.
1134
1135 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1136 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1137 xg_select.
1138
bbc6b304
PE
11392011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 * eval.c (struct backtrace): Simplify and port the data structure.
1142 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1143 signed bit field, as this assumption is not portable and it makes
1144 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1145 "char debug_on_exit : 1" as this is not portable either; instead,
1146 use the portable "unsigned int debug_on_exit : 1". Remove unused
1147 member evalargs. Remove obsolete comments about cc bombing out.
1148
9851bfc5
JD
11492011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1150
51bb811f 1151 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1152 Let HAVE_GSETTINGS override HAVE_GCONF.
1153 (store_monospaced_changed): New function.
1154 (EMACS_SETTINGS): A new type derived from GObject to handle
1155 GSettings notifications.
1156 (emacs_settings_constructor, emacs_settings_get_property)
1157 (emacs_settings_set_property, emacs_settings_class_init):
1158 New functions.
1159 (gsettings_client, gsettings_obj): New variables.
1160 (GSETTINGS_SCHEMA): New define.
1161 (something_changedCB): Call store_monospaced_changed.
1162 (init_gsettings): New function.
1163 (xsettings_initialize): Call init_gsettings.
1164 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1165 to NULL.
1166
1167 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1168 GCONF_CFLAGS/LIBS.
1169
5386012d
MR
11702011-06-29 Martin Rudalics <rudalics@gmx.at>
1171
1172 * window.c (resize_root_window, grow_mini_window)
1173 (shrink_mini_window): Rename Qresize_root_window to
1174 Qwindow_resize_root_window and Qresize_root_window_vertically to
1175 Qwindow_resize_root_window_vertically.
1176
f13e0b08
PE
11772011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1178
1179 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1180
94515237
JB
11812011-06-27 Juanma Barranquero <lekktu@gmail.com>
1182
1183 * makefile.w32-in: Redesign dependencies so they reflect more
1184 clearly which files are directly included by each source file,
1185 and not through other includes.
1186
e43b6e43
MR
11872011-06-27 Martin Rudalics <rudalics@gmx.at>
1188
1189 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1190 (sort_overlays, overlay_strings): When an overlay's clone number
1191 matches the window's clone number process the overlay even if
1192 the overlay's window property doesn't match the current window.
1193
d68443dc
MR
1194 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1195 (Fwindow_hchild): Rename to Fwindow_left_child.
1196 (Fwindow_next): Rename to Fwindow_next_sibling.
1197 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1198 (resize_window_check): Rename to window_resize_check.
1199 (resize_window_apply): Rename to window_resize_apply.
1200 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1201 (Fdelete_other_windows_internal, resize_frame_windows)
1202 (Fsplit_window_internal, Fdelete_window_internal)
1203 (grow_mini_window, shrink_mini_window)
1204 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1205
c7e73be5
JD
12062011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1207
1208 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1209 (emacs_fixed_set_min_size): Remove.
1210 (emacs_fixed_new): Take frame as argument.
1211
1212 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1213 (_EmacsFixedPrivate): Remove minwidth/height.
1214 Add struct frame *f.
1215 (emacs_fixed_init): Initialize priv->f.
1216 (get_parent_class, emacs_fixed_set_min_size): Remove.
1217 (emacs_fixed_new): Set priv->f to argument.
1218 (emacs_fixed_get_preferred_width)
1219 (emacs_fixed_get_preferred_height): Use min_width/height from
1220 frames size_hint to set minimum and natural (Bug#8919).
1221 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1222 and use min_width/height from frames size_hint to set
1223 min_width/height (Bug#8919).
1224
1225 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1226 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1227 Fix indentation.
c7e73be5 1228
cf99dcf8
EZ
12292011-06-26 Eli Zaretskii <eliz@gnu.org>
1230
1231 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1232 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1233 called at ZV.
1234
029529ac
CY
12352011-06-26 Chong Yidong <cyd@stupidchicken.com>
1236
1237 * process.c (wait_reading_process_output): Bypass select if
1238 waiting for a cell while ignoring keyboard input, and input is
1239 pending. Suggested by Jan Djärv (Bug#8869).
1240
7a7ef429
PE
12412011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 Use gnulib's dup2 module instead of rolling our own.
1244 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1245
11fdef7d 12462011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1247
1248 * dispnew.c (scrolling_window): Before scrolling, turn off a
1249 mouse-highlight in the window being scrolled.
1250
cd3520a4
JB
12512011-06-24 Juanma Barranquero <lekktu@gmail.com>
1252
1253 Move DEFSYM to lisp.h and use everywhere.
1254
1255 * character.h (DEFSYM): Move declaration...
1256 * lisp.h (DEFSYM): ...here.
1257
1258 * gnutls.c:
1259 * minibuf.c:
1260 * w32menu.c:
1261 * w32proc.c:
1262 * w32select.c: Don't include character.h.
1263
1264 * alloc.c (syms_of_alloc):
1265 * buffer.c (syms_of_buffer):
1266 * bytecode.c (syms_of_bytecode):
1267 * callint.c (syms_of_callint):
1268 * casefiddle.c (syms_of_casefiddle):
1269 * casetab.c (init_casetab_once):
1270 * category.c (init_category_once, syms_of_category):
1271 * ccl.c (syms_of_ccl):
1272 * cmds.c (syms_of_cmds):
1273 * composite.c (syms_of_composite):
1274 * dbusbind.c (syms_of_dbusbind):
1275 * dired.c (syms_of_dired):
1276 * dispnew.c (syms_of_display):
1277 * doc.c (syms_of_doc):
1278 * editfns.c (syms_of_editfns):
1279 * emacs.c (syms_of_emacs):
1280 * eval.c (syms_of_eval):
1281 * fileio.c (syms_of_fileio):
1282 * fns.c (syms_of_fns):
1283 * frame.c (syms_of_frame):
1284 * fringe.c (syms_of_fringe):
1285 * insdel.c (syms_of_insdel):
1286 * keymap.c (syms_of_keymap):
1287 * lread.c (init_obarray, syms_of_lread):
1288 * macros.c (syms_of_macros):
1289 * msdos.c (syms_of_msdos):
1290 * print.c (syms_of_print):
1291 * process.c (syms_of_process):
1292 * search.c (syms_of_search):
1293 * sound.c (syms_of_sound):
1294 * syntax.c (init_syntax_once, syms_of_syntax):
1295 * terminal.c (syms_of_terminal):
1296 * textprop.c (syms_of_textprop):
1297 * undo.c (syms_of_undo):
1298 * w32.c (globals_of_w32):
1299 * window.c (syms_of_window):
1300 * xdisp.c (syms_of_xdisp):
1301 * xfaces.c (syms_of_xfaces):
1302 * xfns.c (syms_of_xfns):
1303 * xmenu.c (syms_of_xmenu):
1304 * xsettings.c (syms_of_xsettings):
1305 * xterm.c (syms_of_xterm): Use DEFSYM.
1306
4228cf16
TZ
13072011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1308
cd3520a4 1309 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1310
7fcccf1e
PE
13112011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1312
7efb4e0e
PE
1313 Integer and buffer overflow fixes (Bug#8873).
1314
ff5844ad
PE
1315 * print.c (printchar, strout): Check for string overflow.
1316 (PRINTPREPARE, printchar, strout):
1317 Don't set size unless allocation succeeds.
1318
90532f02
PE
1319 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1320 for sizes. Check for string overflow more accurately.
1321 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1322
6d84508d
PE
1323 * macros.c: Integer and buffer overflow fixes.
1324 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1325 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1326 Use ptrdiff_t, not int, for sizes.
1327 Don't increment bufsize until after realloc succeeds.
1328 Check for size-calculation overflow.
1329 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1330
437b2cb4
PE
1331 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1332
8b9ac8b4
PE
1333 * lread.c: Integer overflow fixes.
1334 (read_integer): Radix is now EMACS_INT, not int,
1335 to improve quality of diagnostics for out-of-range radices.
1336 Calculate buffer size correctly for out-of-range radices.
1337 (read1): Check for integer overflow in radices, and in
1338 read-circle numbers.
82cb60d3
PE
1339 (read_escape): Avoid int overflow.
1340 (Fload, openp, read_buffer_size, read1)
1341 (substitute_object_recurse, read_vector, read_list, map_obarray):
1342 Use ptrdiff_t, not int, for sizes.
1343 (read1): Use EMACS_INT, not int, for sizes.
20270765 1344 Check for size overflow.
8b9ac8b4 1345
7fcccf1e
PE
1346 * image.c (cache_image): Check for size arithmetic overflow.
1347
bfbbd7e7
PE
1348 * lread.c: Integer overflow issues.
1349 (saved_doc_string_size, saved_doc_string_length)
1350 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1351 Now ptrdiff_t, not int.
1352 (read1): Don't assume doc string length fits in int. Check for
1353 out-of-range doc string lengths.
1354 (read_list): Don't assume file position fits in int.
39019e54 1355 (read_escape): Check for hex character overflow.
bfbbd7e7 1356
4e323265
LL
13572011-06-22 Leo Liu <sdl.web@gmail.com>
1358
1359 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1360 Move to minibuffer.el.
1361
85fece3e
PE
13622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1363
20b84ce9 1364 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1365 The following patches are for when GLYPH_DEBUG && !XASSERT.
1366 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1367 * dispnew.c (flush_stdout):
1368 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1369 Mark as externally visible.
1370 * dispnew.c (check_window_matrix_pointers): Now static.
1371 * dispnew.c (window_to_frame_vpos):
1372 * xfns.c (unwind_create_frame):
1373 * xterm.c (x_check_font): Remove unused local.
1374 * scroll.c (CHECK_BOUNDS):
1375 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1376 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1377 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1378 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1379 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1380 Now static.
1381 (debug_method_add): Use va_list and vsprintf rather than relying
1382 on undefined behavior with wrong number of arguments.
1383 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1384 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1385 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1386 since we're not interested in debugging glyphs with old libraries.
1387 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1388 GCC 4.6.0's static checking.
1389
0766b489
PE
13902011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1391
31fd4b32
PE
1392 Integer overflow and signedness fixes (Bug#8873).
1393 A few related buffer overrun fixes, too.
1394
b79e8648
PE
1395 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1396
0766b489
PE
1397 * dispextern.h (struct face.stipple):
1398 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1399 (x_bitmap_mask, x_allocate_bitmap_record)
1400 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1401 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1402 (x_create_bitmap_from_xpm_data):
1403 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1404 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1405 (.bitmaps_last):
1406 * xfaces.c (load_pixmap):
1407 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1408 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1409 (.bitmaps_last, struct x_output.icon_bitmap):
1410 Use ptrdiff_t, not int, for bitmap indexes.
1411 (x_allocate_bitmap_record): Check for size overflow.
1412 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1413
b081724f
PE
1414 Use ptrdiff_t, not int, for overlay counts.
1415 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1416 * editfns.c (overlays_around, get_pos_property):
1417 * textprop.c (get_char_property_and_overlay):
1418 * xdisp.c (next_overlay_change, note_mouse_highlight):
1419 * xfaces.c (face_at_buffer_position):
21514da7
PE
1420 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1421 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1422 (Fnext_overlay_change, Fprevious_overlay_change)
1423 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1424 Use ptrdiff_t, not int, for sizes.
21514da7 1425 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1426
3de73e5e
PE
1427 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1428
2606c57b
PE
1429 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1430 (x_session_initialize): Do not assume string length fits in int.
1431
aaafe47a
PE
1432 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1433 This is unlikely, but can occur if DPI is outlandish.
1434
2674ddc8 1435 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1436 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1437
28154962
PE
1438 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1439 * xrdb.c (magic_file_p, search_magic_path):
1440 Omit last arg SUFFIX; it was always 0. All callers changed.
1441 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1442
7de51af5
PE
1443 * xfont.c (xfont_match): Avoid need for strlen.
1444
25ed6cc3
PE
1445 * xfns.c: Don't assume strlen fits in int.
1446 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1447
4eab31dd
PE
1448 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1449 not unsigned long, as we prefer signed integers. All callers changed.
1450 Detect integer overflow in repeat count.
1451 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1452 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1453
171e2a58
PE
1454 * termcap.c: Don't assume sizes fit in int and never overflow.
1455 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1456 (gobble_line): Check for size-calculation overflow.
1457
ad39faca 1458 * minibuf.c (Fread_buffer):
6e5bb2dc 1459 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1460 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1461 Don't assume string length fits in int.
1462
52c61c22 1463 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1464 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1465
b5b8c9e5
PE
1466 * font.c: Don't assume string length fits in int.
1467 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1468 Use ptrdiff_t, not int.
ccd6111c
PE
1469 (font_intern_prop): Don't assume string length fits in int.
1470 Don't assume integer property fits in fixnum.
1471 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1472
882f0d81 1473 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1474 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1475 Reformulate so as not to need the command string.
1476 Invoke gzip -cd rather than gunzip, as it's more portable.
1477 (lock_info_type, lock_file_1, lock_file):
1478 Don't assume pid_t and time_t fit in unsigned long.
1479 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1480 (current_lock_owner): Prefer signed type for sizes.
1481 Use memcpy, not strncpy, where memcpy is what is really wanted.
1482 Don't assume (via atoi) that time_t and pid_t fit in int.
1483 Check for time_t and/or pid_t out of range, e.g., via a network share.
1484 Don't alloca where an auto var works fine.
1485
93f4cf88
PE
1486 * fileio.c: Fix some integer overflow issues.
1487 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1488 Don't assume string length fits in int.
1489 (directory_file_name): Don't assume string length fits in long.
1490 (make_temp_name): Don't assume pid fits in int, or that its print
1491 length is less than 20.
1492
f3e92b69
PE
1493 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1494
1bfdaf10
PE
1495 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1496
35016e9a
PE
1497 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1498
3d1e65a1
PE
1499 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1500 We prefer signed integers, even for size calculations.
1501
0b963a93
PE
1502 * emacs.c: Don't assume string length fits in 'int'.
1503 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1504 (main): Don't invoke strlen when not needed.
1505
573f4b54
PE
1506 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1507 (XD_DEBUG_MESSAGE): Don't waste a byte.
1508
989f33ba
PE
1509 * callproc.c (getenv_internal_1, getenv_internal)
1510 (Fgetenv_internal):
965d34eb
PE
1511 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1512
e4d29b33
PE
1513 * lread.c (invalid_syntax): Omit length argument.
1514 All uses changed. This doesn't fix a bug, but it simplifies the
1515 code away from its former Hollerith-constant appearance, and it's
1516 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1517 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1518
eb49b136
PE
1519 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1520 This didn't break anything, but it didn't help either.
1521 It's confusing to put a bogus integer in a place where the actual
1522 value does not matter.
9f62aeb1 1523 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1524 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1525
15375a22
PE
1526 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1527 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1528 implementation.
b61cc01c
PE
1529 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1530 We prefer signed types, and the value cannot exceed the EMACS_INT
1531 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1532 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1533 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1534 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1535
53b2623d
PE
1536 * indent.c (sane_tab_width): New function.
1537 (current_column, scan_for_column, Findent_to, position_indentation)
1538 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1539 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1540
51cab52b 1541 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1542
f2ed8a70
PE
1543 * lisp.h (lint_assume): New macro.
1544 * composite.c (composition_gstring_put_cache):
1545 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1546
abe80cc6
PE
1547 * editfns.c, insdel.c:
1548 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1549
b02c740e
PE
1550 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1551
ebc96716
PE
1552 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1553
b4e50fa0 1554 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1555 Use much-faster test for byte-length change.
311d5d7c 1556 Don't assume string byte-length fits in 'int'.
a4cf38e4 1557 Check that character arg fits in 'int'.
85461888 1558 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1559
c0c1ee9f
PE
1560 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1561
a498d7f4
PE
1562 * fns.c (concat): Catch string overflow earlier.
1563 Do not rely on integer wraparound.
1564
51cab52b
PE
1565 * dispextern.h (struct it.overlay_strings_charpos)
1566 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1567 * xdisp.c (forward_to_next_line_start)
1568 (back_to_previous_visible_line_start)
1569 (reseat_at_next_visible_line_start, next_element_from_buffer):
1570 Don't arbitrarily truncate the value of 'selective' to int.
1571
76031fad
PE
1572 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1573
5eb55db9
PE
1574 * composite.c: Don't truncate sizes to 'int'.
1575 (composition_gstring_p, composition_reseat_it)
1576 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1577 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1578 not EMACS_UINT, for indexes.
5eb55db9 1579
0703a717
PE
1580 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1581
d6202519
PE
1582 * buffer.c: Include <verify.h>.
1583 (struct sortvec.priority, struct sortstr.priority):
8961a454 1584 Now EMACS_INT, not int.
c20998a7 1585 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1586 (struct sortstr.size, record_overlay_string)
1587 (struct sortstrlist.size, struct sortlist.used):
1588 Don't truncate size to int.
1589 (record_overlay_string): Check for size-calculation overflow.
d6202519 1590 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1591
d5a19415
JM
15922011-06-22 Jim Meyering <meyering@redhat.com>
1593
029529ac 1594 Don't leak an XBM-image-sized buffer
d5a19415
JM
1595 * image.c (xbm_load): Free the image buffer after using it.
1596
a9041e6c
PE
15972011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1598
1599 Port to Sun C.
1600 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1601 that Sun C diagnosed.
1602 * fns.c (secure_hash): Fix pointer signedness issue.
1603 * intervals.c (static_offset_intervals): New function.
1604 (offset_intervals): Use it.
1605
7f3f739f
LL
16062011-06-21 Leo Liu <sdl.web@gmail.com>
1607
1608 * deps.mk (fns.o):
1609 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1610 sha512.h.
1611
1612 * fns.c (secure_hash): Rename from crypto_hash_function and change
1613 the first arg to accept symbols.
5b66d427 1614 (Fsecure_hash): New primitive.
7f3f739f
LL
1615 (syms_of_fns): New symbols.
1616
76147d94
DD
16172011-06-20 Deniz Dogan <deniz@dogan.se>
1618
1619 * process.c (Fset_process_buffer): Clarify return value in
1620 docstring.
1621
7d7d0045
CY
16222011-06-18 Chong Yidong <cyd@stupidchicken.com>
1623
1624 * dispnew.c (add_window_display_history): Use BVAR.
1625
1626 * xdisp.c (debug_method_add): Use BVAR.
1627 (check_window_end, dump_glyph_matrix, dump_glyph)
1628 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1629
1630 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1631 Likewise.
1632
1633 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1634 check till after the cache is created in init_frame_faces.
1635
ff2bc410
SM
16362011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1637
1638 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1639
28177add
PE
16402011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1641
dd3482fe
PE
1642 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1643 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1644 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1645
393d71f3 1646 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1647 * fileio.c (Finsert_file_contents):
1648 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1649 Remove the old (too-loose) buffer overflow checks.
1650 They weren't needed, since make_gap checks for buffer overflow.
1651 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1652 The old code merely checked for Emacs fixnum overflow, and relied
1653 on undefined (wraparound) behavior. The new code avoids undefined
1654 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1655
2e6813b0 1656 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1657 Tune. Don't use wider integers than needed. Don't use alloca.
1658 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1659
599a9e4f
PE
1660 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1661
99561444
PE
1662 * insdel.c, lisp.h (buffer_overflow): New function.
1663 (insert_from_buffer_1, replace_range, replace_range_2):
1664 * insdel.c (make_gap_larger):
1665 * editfns.c (Finsert_char):
1666 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1667
28177add
PE
1668 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1669
e69dafad
PE
16702011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1671
a7af7fde 1672 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1673
b1c46f02
PE
1674 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1675 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1676
e69dafad
PE
1677 * fileio.c: Don't assume EMACS_INT fits in off_t.
1678 (emacs_lseek): New static function.
1679 (Finsert_file_contents, Fwrite_region): Use it.
1680 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1681
566684ea
PE
1682 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1683
e6966cd6
PE
1684 * fns.c: Don't overflow int when computing a list length.
1685 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1686 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1687 truncation on 64-bit hosts. Check for QUIT every
1688 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1689 faster and is responsive enough.
1690 (Flength): Report an error instead of overflowing an integer.
1691 (Fsafe_length): Return a float if the value is not representable
1692 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1693 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1694 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1695
dd0b0efb
PE
1696 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1697 (header_size, word_size): New constants.
1698 (allocate_vectorlike): Don't check size overflow here.
1699 (allocate_vector): Check it here instead, since this is the only
1700 caller of allocate_vectorlike that could cause overflow.
1701 Check that the new vector's length is representable as a fixnum.
1702
86fe5cfe
PE
1703 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1704 The previous code was bogus. For example, next_almost_prime (32)
1705 returned 39, which is undesirable as it is a multiple of 3; and
1706 next_almost_prime (24) returned 25, which is a multiple of 5 so
1707 why was the code bothering to check for multiples of 7?
1708
80e88859
PE
1709 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1710
4a2f0ad6
PE
1711 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1712
f66c7cf8
PE
1713 Variadic C functions now count arguments with ptrdiff_t.
1714 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1715 Back then I didn't know that the Emacs coding style prefers signed int.
1716 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1717 were being counted with int, which may truncate counts on 64-bit
1718 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1719 * lisp.h (struct Lisp_Subr.function.aMANY)
1720 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1721 Arg counts are now ptrdiff_t, not size_t.
1722 All variadic functions and their callers changed accordingly.
1723 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1724 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1725 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1726 * callint.c (Fcall_interactively): Check arg count for overflow,
1727 to avoid potential buffer overrun. Use signed char, not 'int',
1728 for 'varies' array, so that we needn't bother to check its size
1729 calculation for overflow.
1730 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1731 * eval.c (apply_lambda):
1732 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1733 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1734 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1735
a1759b76
PE
1736 * callint.c (Fcall_interactively): Don't use index var as event count.
1737
d96be9fc
PE
1738 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1739 * mem-limits.h (SIZE): Remove; no longer used.
1740
a690a978 1741 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1742
578c21e6
PE
1743 Remove unnecessary casts.
1744 * xterm.c (x_term_init):
1745 * xfns.c (x_set_border_pixel):
1746 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1747 These aren't needed now that we assume ANSI C.
1748
96f53c6c
PE
1749 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1750 It's more likely to cause problems (due to unsigned overflow)
1751 than to cure them.
1752
83c77d31
PE
1753 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1754
ee2079f1
PE
1755 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1756
6da65536
PE
1757 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1758
7147c4a4
PE
1759 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1760
193e32d9
PE
1761 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1762
e5533da6
PE
1763 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1764
9910e595
PE
1765 GLYPH_CODE_FACE returns EMACS_INT, not int.
1766 * dispextern.h (merge_faces):
1767 * xfaces.c (merge_faces):
01103c44
PE
1768 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1769 Don't assume EMACS_INT fits in int.
9910e595 1770
2638320e
PE
1771 * character.h (CHAR_VALID_P): Remove unused parameter.
1772 * fontset.c, lisp.h, xdisp.c: All uses changed.
1773
045eb8d9
PE
1774 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1775
c1f134b5
PE
1776 * fns.c (concat): Minor tuning based on overflow analysis.
1777 This doesn't fix any bugs. Use int to hold character, instead
1778 of constantly refetching from Emacs object. Use XFASTINT, not
1779 XINT, for value known to be a character. Don't bother comparing
1780 a single byte to 0400, as it's always less.
1781
395fcb93 1782 * floatfns.c (Fexpt):
327eeec8
PE
1783 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1784
abbd3d23
PE
1785 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1786 for characters.
1787
684a03ef
PE
1788 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1789
0fed43f3
PE
1790 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1791 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1792 incorrectly succeed when S was a string, because 4294967386 was
1793 truncated before it was used.
1794
8fd02eb7
PE
1795 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1796 Otherwise, an out-of-range integer could cause undefined behavior
1797 on a 64-bit host.
1798
f8c86b69
PE
1799 * composite.c: Use int, not EMACS_INT, for characters.
1800 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1801 EMACS_INT, for values that are known to be in character range.
1802 This doesn't fix any bugs but is the usual style inside Emacs and
1803 may generate better code on 32-bit machines.
1804
34206dd2
PE
1805 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1806 This is for reasons similar to the recent CHAR_STRING fix.
1807 * charset.c (Fencode_char): Check that character arg is actually
1808 a character. Pass an int to ENCODE_CHAR.
1809 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1810 wider than 'int', as a compile-time check to prevent future regressions
1811 in this area.
1812
c5958d4c 1813 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1814
1815 Make sure a 64-bit char is never passed to CHAR_STRING.
1816 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1817 by silently ignoring the top 32 bits, allowing some values
1818 that were far too large to be valid characters.
1819 * character.h: Include <verify.h>.
1820 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1821 arguments are no wider than unsigned, as a compile-time check
1822 to prevent future regressions in this area.
1823 * data.c (Faset):
01103c44 1824 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1825 (Fsubst_char_in_region):
1826 * fns.c (concat):
1827 * xdisp.c (decode_mode_spec_coding):
1828 Adjust to CHAR_STRING's new requirement.
1829 * editfns.c (Finsert_char, Fsubst_char_in_region):
1830 * fns.c (concat): Check that character args are actually
1831 characters. Without this test, these functions did the wrong
1832 thing with wildly out-of-range values on 64-bit hosts.
1833
d37ca623
PE
1834 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1835 These casts should not be needed on 32-bit hosts, either.
1836 * keyboard.c (read_char):
1837 * lread.c (Fload): Remove casts to unsigned.
1838
ea204efb
PE
1839 * lisp.h (UNSIGNED_CMP): New macro.
1840 This fixes comparison bugs on 64-bit hosts.
1841 (ASCII_CHAR_P): Use it.
1842 * casefiddle.c (casify_object):
01103c44 1843 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1844 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1845 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1846 * dispextern.h (FACE_FROM_ID):
1847 * keyboard.c (read_char): Use UNSIGNED_CMP.
1848
41cb286c
PE
1849 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1850 not to EMACS_INT, to avoid GCC warning.
1851
4a1b9832
PE
1852 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1853
55daad71
PE
1854 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1855 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1856 isn't needed on 32-bit machines.
8f95c75c 1857
01103c44
PE
1858 * buffer.c (Fgenerate_new_buffer_name):
1859 Use EMACS_INT for count, not int.
0ceccced 1860 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1861
1862 * data.c (Qcompiled_function): Now static.
1863
c6f072e7
PE
1864 * window.c (window_body_lines): Now static.
1865
20ce5912
PE
1866 * image.c (gif_load): Rename local to avoid shadowing.
1867
9c4c5f81
PE
1868 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1869 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1870 * alloc.c (make_save_value): Integer argument is now of type
1871 ptrdiff_t, not int.
1872 (mark_object): Use ptrdiff_t, not int.
1873 * lisp.h (pD): New macro.
1874 * print.c (print_object): Use it.
1875
c0c5c8ae
PE
1876 * alloc.c: Use EMACS_INT, not int, to count objects.
1877 (total_conses, total_markers, total_symbols, total_vector_size)
1878 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1879 (total_free_floats, total_floats, total_free_intervals)
1880 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1881 Now EMACS_INT, not int. All uses changed.
1882 (Fgarbage_collect): Compute overall total using a double, so that
1883 integer overflow is less likely to be a problem. Check for overflow
1884 when converting back to an integer.
5a25e253
PE
1885 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1886 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1887 These were 'int' variables that could overflow on 64-bit hosts;
1888 they were never used, so remove them instead of repairing them.
211a0b2a 1889 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1890 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1891 Previously, this ceilinged at INT_MAX, but that doesn't work on
1892 64-bit machines.
e46bb31a 1893 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1894
c78baabf 1895 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1896 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1897 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1898 when a (possibly-narrower) signed value would do just as well.
1899 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1900
c9d624c6
PE
1901 * alloc.c: Catch some string size overflows that we were missing.
1902 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1903 for convenience in STRING_BYTES_MAX.
1904 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1905 The definition here is exact; the one in lisp.h was approximate.
1906 (allocate_string_data): Check for string overflow. This catches
1907 some instances we weren't catching before. Also, it catches
1908 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1909 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1910 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1911
c9d624c6
PE
1912 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1913 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1914 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1915
353032ce
PE
1916 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1917
2bccce07
PE
1918 * alloc.c (Fmake_string): Check for out-of-range init.
1919
0ac30604
SM
19202011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1921
1922 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1923
c195f2de
JD
19242011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1925
1926 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1927 xg_get_default_scrollbar_width.
1928
1929 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1930 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1931 (style_changed_cb): Call update_theme_scrollbar_width and call
1932 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1933 all frames (Bug#8505).
1934 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1935 Call gtk_window_set_resizable if HAVE_GTK3.
1936 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1937 and height if HAVE_GTK3 (Bug#8505).
1938 (scroll_bar_width_for_theme): New variable.
1939 (update_theme_scrollbar_width): New function.
1940 (xg_get_default_scrollbar_width): Move code to
1941 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1942 (xg_initialize): Call update_theme_scrollbar_width.
1943
1944 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1945
1946 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1947
e10ac9f1
MR
19482011-06-12 Martin Rudalics <rudalics@gmx.at>
1949
1950 * frame.c (make_frame): Call other_buffer_safely instead of
1951 other_buffer.
1952
1953 * window.c (temp_output_buffer_show): Call display_buffer with
1954 second argument Vtemp_buffer_show_specifiers and reset latter
1955 immediately after the call.
1956 (Vtemp_buffer_show_specifiers): New variable.
1957 (auto_window_vscroll_p, next_screen_context_lines)
1958 (Vscroll_preserve_screen_position): Remove leading asterisks from
1959 doc-strings.
1960
2d3c217e 19612011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1962
7b7f97e8 1963 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1964 * buffer.c (Qclone_number): Remove for now, as it's unused.
1965 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1966 (record_buffer): Remove unused local.
1967 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1968 (set_frame_buffer_list): Remove; unused.
1969 * frame.h (other_visible_frames): Remove decl.
1970 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1971 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1972 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1973 if HAVE_GPM.
1974 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1975 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1976 Define only if HAVE_GPM.
1977 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1978 (update_hints_inhibit): Remove; never set. All uses removed.
1979 * widgetprv.h (emacsFrameClassRec): Remove decl.
1980 * window.c (delete_deletable_window): Now returns void, since it
1981 wasn't returning anything.
1982 (compare_window_configurations): Remove unused locals.
1983 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1984 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1985 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1986 the same widths as pointers. This follows up on the 2011-05-06 patch.
1987 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1988 * xterm.h: Likewise.
1989 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1990
1384b89e
JB
19912011-06-12 Juanma Barranquero <lekktu@gmail.com>
1992
1993 * makefile.w32-in: Update dependencies.
1994 (LISP_H): Add lib/intprops.h.
1995
1100a63c
CY
19962011-06-11 Chong Yidong <cyd@stupidchicken.com>
1997
1998 * image.c (gif_load): Add animation frame delay to the metadata.
1999 (syms_of_image): Use DEFSYM. New symbol `delay'.
2000
6198ccd0
MR
20012011-06-11 Martin Rudalics <rudalics@gmx.at>
2002
2003 * window.c (delete_deletable_window): Re-add.
2004 (Fset_window_configuration): Rewrite to handle dead buffers and
2005 consequently deletable windows.
2006 (window_tree, Fwindow_tree): Remove. Supply functionality in
2007 window.el.
2008 (compare_window_configurations): Simplify code.
2009
b6e3633c
AS
20102011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2011
1ab0dee5
AS
2012 * image.c (imagemagick_load_image): Fix type mismatch.
2013 (Fimagemagick_types): Likewise.
2014
b6e3633c
AS
2015 * window.h (replace_buffer_in_windows): Declare.
2016
9397e56f
MR
20172011-06-11 Martin Rudalics <rudalics@gmx.at>
2018
2019 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2020 Qclone_number. Remove external declaration of Qdelete_window.
2021 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2022 code.
2023 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2024 Qbuffer_list_update_hook if allowed.
2025 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2026 buffer list implementation.
2027 (other_buffer_safely): New function.
2028 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2029 calls to replace_buffer_in_windows and
2030 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2031 if allowed.
2032 (record_buffer): Inhibit quitting and rewrite using quittable
2033 functions. Run Qbuffer_list_update_hook if allowed.
2034 (Frecord_buffer, Funrecord_buffer): New functions.
2035 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2036 switch-to-buffer to window.el.
2037 (bury-buffer): Move to window.el.
2038 (Vbuffer_list_update_hook): New variable.
2039
2040 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2041 section.
2042
2043 * window.h (resize_frame_windows): Move up in code.
2044 (Fwindow_frame): Remove EXFUN.
2045 (replace_buffer_in_all_windows): Remove prototype.
2046 (replace_buffer_in_windows_safely): Add prototype.
2047
2048 * window.c: Declare Qdelete_window static again. Move down
2049 declaration of select_count.
2050 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2051 (Fother_window): Move to window.el.
2052 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2053 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2054 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2055 window.el.
2056 (replace_buffer_in_windows): Implement by calling
2057 Qreplace_buffer_in_windows.
2058 (replace_buffer_in_all_windows): Remove with some functionality
2059 moved into replace_buffer_in_windows_safely.
2060 (replace_buffer_in_windows_safely): New function.
2061 (select_window_norecord, select_frame_norecord): Move in front
2062 of run_window_configuration_change_hook. Remove now obsolete
2063 declarations.
2064 (Fset_window_buffer): Rewrite doc-string. Call
2065 Qrecord_window_buffer.
2066 (keys_of_window): Move binding for other-window to window.el.
2067
b50691aa
CY
20682011-06-11 Chong Yidong <cyd@stupidchicken.com>
2069
2070 * dispextern.h (struct image): Replace data member, whose int_val
2071 and ptr_val fields were not used by anything, with a single
2072 lisp_val object.
2073
2074 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2075 (gif_clear_image, gif_load, imagemagick_load_image)
2076 (gs_clear_image, gs_load): Callers changed.
2077
3f754b86
PE
20782011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2079
cca69397
PE
2080 * buffer.h: Include <time.h>, for time_t.
2081 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2082
109e28d0
PE
2083 Fix minor problems found by static checking.
2084
60737f02
PE
2085 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2086
4b66faf3
PE
2087 Make identifiers static if they are not used in other modules.
2088 * data.c (Qcompiled_function, Qframe, Qvector):
2089 * image.c (QimageMagick, Qsvg):
2090 * minibuf.c (Qmetadata):
2091 * window.c (resize_window_check, resize_root_window): Now static.
2092 * window.h (resize_window_check, resize_root_window): Remove decls.
2093
109e28d0
PE
2094 * window.c (window_deletion_count, delete_deletable_window):
2095 Remove; unused.
46a4ce9e
PE
2096 (window_body_lines): Now static.
2097 (Fdelete_other_windows_internal): Mark vars as initialized.
2098 Make sure 'resize_failed' is initialized.
2099 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2100 (resize_window_apply): Remove unused local.
2101 * window.h (delete_deletable_window): Remove decl.
2102
109e28d0 2103 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2104 (imagemagick_load_image): Fix pointer signedness problem by changing
2105 last arg from unsigned char * to char *. All uses changed.
2106 Also, fix a local for similar reasons.
2107 Remove unused locals. Remove locals to avoid shadowing.
2108 (fn_rsvg_handle_free): Remove; unused.
2109 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2110 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2111
3f754b86
PE
2112 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2113
2547adb1
CY
21142011-06-10 Chong Yidong <cyd@stupidchicken.com>
2115
2116 * image.c (gif_load): Fix omitted cast error introduced by
2117 2011-06-06 change.
2118
2c8e37d4
MR
21192011-06-10 Martin Rudalics <rudalics@gmx.at>
2120
2121 * window.h (resize_proportionally, orig_total_lines)
2122 (orig_top_line): Remove from window structure.
2123 (set_window_height, set_window_width, change_window_heights)
2124 (Fdelete_window): Remove prototypes.
2125 (resize_frame_windows): Remove duplicate declaration.
2126
440a42e3
EZ
21272011-06-10 Eli Zaretskii <eliz@gnu.org>
2128
2129 * window.h (resize_frame_windows, resize_window_check)
2130 (delete_deletable_window, resize_root_window)
2131 (resize_frame_windows): Declare prototypes.
2132
2133 * window.c (resize_window_apply): Make definition be "static" to
2134 match the prototype.
2135
562dd5e9
MR
21362011-06-10 Martin Rudalics <rudalics@gmx.at>
2137
2138 * window.c: Remove declarations of Qwindow_size_fixed,
2139 window_min_size_1, window_min_size_2, window_min_size,
2140 size_window, window_fixed_size_p, enlarge_window, delete_window.
2141 Remove static from declaration of Qdelete_window, it's
2142 temporarily needed by Fbury_buffer.
2143 (replace_window): Don't assign orig_top_line and
2144 orig_total_lines.
2145 (Fdelete_window, delete_window): Remove. Window deletion is
2146 handled by window.el.
2147 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2148 Fdelete_window calls with calls to Qdelete_window.
2149 (Fdelete_other_windows): Remove. Deleting other windows is
2150 handled by window.el.
2151 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2152 handled in window.el.
2153 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2154 Window minimum sizes are handled in window.el.
2155 (shrink_windows, size_window, set_window_height)
2156 (set_window_width, change_window_heights, window_height)
2157 (window_width, CURBEG, CURSIZE, enlarge_window)
2158 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2159 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2160 handled in window.el.
2161 (make_dummy_parent): Rename to make_parent_window and give it a
2162 second argument horflag.
2163 (make_window): Don't set resize_proportionally any more.
2164 (Fsplit_window): Remove. Windows are split in window.el.
2165 (save_restore_action, save_restore_orig_size)
2166 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2167 Resize mini windows in window.el.
2168 (grow_mini_window, shrink_mini_window): Implement by calling
2169 Qresize_root_window_vertically, resize_window_check and
2170 resize_window_apply.
2171 (saved_window, Fset_window_configuration, save_window_save): Do
2172 not handle orig_top_line, orig_total_lines, and
2173 resize_proportionally.
2174 (window_min_height, window_min_width): Move to window.el.
2175 (keys_of_window): Move bindings for delete-other-windows,
2176 split-window, delete-window and enlarge-window to window.el.
2177
2178 * buffer.c: Temporarily extern Qdelete_window.
2179 (Fbury_buffer): Temporarily call Qdelete_window instead of
2180 Fdelete_window (Fbury_buffer will move to window.el soon).
2181
2182 * frame.c (set_menu_bar_lines_1): Remove code handling
2183 orig_top_line and orig_total_lines.
2184
2185 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2186 set_window_height but set heights directly.
2187 (change_frame_size_1): Use resize_frame_windows.
2188
2189 * xdisp.c (init_xdisp): Don't use set_window_height but set
2190 heights directly.
2191
2192 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2193 resize_frame_windows instead of change_window_heights and run
2194 run_window_configuration_change_hook.
2195
2196 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2197 instead of change_window_heights and run
2198 run_window_configuration_change_hook.
2199
1a13852e
MR
22002011-06-09 Martin Rudalics <rudalics@gmx.at>
2201
2202 * window.c (replace_window): Rename second argument REPLACEMENT to
2203 NEW. New third argument SETFLAG. Rewrite.
2204 (delete_window, make_dummy_parent): Call replace_window with
2205 third argument 1.
2206 (window_list_1): Move down in code.
2207 (run_window_configuration_change_hook): Move set_buffer part
2208 before select_frame_norecord part in order to unwind correctly.
2209 Rename count1 to count.
2210 (recombine_windows, delete_deletable_window, resize_root_window)
2211 (Fdelete_other_windows_internal)
2212 (Frun_window_configuration_change_hook, make_parent_window)
2213 (resize_window_check, resize_window_apply, Fresize_window_apply)
2214 (resize_frame_windows, Fsplit_window_internal)
2215 (Fdelete_window_internal, Fresize_mini_window_internal): New
2216 functions.
2217 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2218
f3d1777e
MR
22192011-06-08 Martin Rudalics <rudalics@gmx.at>
2220
496e208e
MR
2221 * window.h (window): Add some new members to window structure -
2222 normal_lines, normal_cols, new_total, new_normal, clone_number,
2223 splits, nest, prev_buffers, next_buffers.
2224 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2225 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2226
f3d1777e
MR
2227 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2228 Remove.
496e208e
MR
2229 (make_dummy_parent): Set new members of windows structure.
2230 (make_window): Move down in code. Handle new members of window
2231 structure.
2232 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2233 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2234 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2235 (Fset_window_prev_buffers, Fwindow_next_buffers)
2236 (Fset_window_next_buffers, Fset_window_clone_number): New
2237 functions.
2238 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2239 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2240 Doc-string fixes.
2241 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2242 Argument WINDOW can be now internal window too.
2243 (Fwindow_use_time): Move up in code.
2244 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2245 Rewrite doc-string.
2246 (Fset_window_configuration, saved_window)
2247 (Fcurrent_window_configuration, save_window_save): Handle new
2248 members of window structure.
b9e809c2
MR
2249 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2250 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2251 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2252 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2253 Qget_mru_window, Qresize_root_window,
2254 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2255 Qauto_buffer_name; staticpro them.
f3d1777e 2256
abde8f8c
MR
22572011-06-07 Martin Rudalics <rudalics@gmx.at>
2258
2259 * window.c (Fwindow_total_size, Fwindow_left_column)
2260 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2261 (Fwindow_list_1): New functions.
2262 (window_box_text_cols): Replace with window_body_cols.
2263 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2264 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2265 (delete_window, Fset_window_configuration): Call
2266 delete_all_subwindows with window as argument.
2267 (delete_all_subwindows): Take a window as argument and not a
2268 structure. Rewrite.
190b47e6
MR
2269 (window_loop): Remove handling of GET_LRU_WINDOW and
2270 GET_LARGEST_WINDOW.
2271 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2272
2273 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2274 window_box_text_cols. delete_all_subwindows now takes a
2275 Lisp_Object as argument.
abde8f8c
MR
2276
2277 * indent.c (compute_motion, Fcompute_motion): Use
2278 window_body_cols instead of window_box_text_cols.
2279
fa8a67e6
MR
2280 * frame.c (delete_frame): Call delete_all_subwindows with root
2281 window as argument.
2282
a54e3482
DC
22832011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2284
2285 * fns.c (Fputhash): Document return value.
2286
60002bf5
CY
22872011-06-06 Chong Yidong <cyd@stupidchicken.com>
2288
2289 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2290
0c671da6 22912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2292
b862a52a 2293 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2294
be44ca6c
PE
2295 Check for overflow when converting integer to cons and back.
2296 * charset.c (Fdefine_charset_internal, Fdecode_char):
2297 Use cons_to_unsigned to catch overflow.
2298 (Fencode_char): Use INTEGER_TO_CONS.
2299 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2300 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2301 * data.c (long_to_cons, cons_to_long): Remove.
2302 (cons_to_unsigned, cons_to_signed): New functions.
2303 These signal an error for invalid or out-of-range values.
2304 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2305 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2306 * font.c (Ffont_variation_glyphs):
2307 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2308 * lisp.h: Include <intprops.h>.
2309 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2310 (cons_to_signed, cons_to_unsigned): New decls.
2311 (long_to_cons, cons_to_long): Remove decls.
2312 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2313 (Fprimitive_undo): Use CONS_TO_INTEGER.
2314 * xfns.c (Fx_window_property): Likewise.
2315 * xselect.c: Include <limits.h>.
2316 (x_own_selection, selection_data_to_lisp_data):
2317 Use INTEGER_TO_CONS.
2318 (x_handle_selection_request, x_handle_selection_clear)
2319 (x_get_foreign_selection, Fx_disown_selection_internal)
2320 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2321 (lisp_data_to_selection_data): Use cons_to_unsigned.
2322 (x_fill_property_data): Use cons_to_signed.
2323 Report values out of range.
2324
d1f3d2af
PE
2325 Check for buffer and string overflow more precisely.
2326 * buffer.h (BUF_BYTES_MAX): New macro.
2327 * lisp.h (STRING_BYTES_MAX): New macro.
2328 * alloc.c (Fmake_string):
2329 * character.c (string_escape_byte8):
2330 * coding.c (coding_alloc_by_realloc):
2331 * doprnt.c (doprnt):
2332 * editfns.c (Fformat):
2333 * eval.c (verror):
2334 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2335 since they may not be the same number.
2336 * editfns.c (Finsert_char):
2337 * fileio.c (Finsert_file_contents):
2338 Likewise for BUF_BYTES_MAX.
2339
dd52fcea
PE
2340 * image.c: Use ptrdiff_t, not int, for sizes.
2341 (slurp_file): Switch from int to ptrdiff_t.
2342 All uses changed.
2343 (slurp_file): Check that file size fits in both size_t (for
2344 malloc) and ptrdiff_t (for sanity and safety).
2345
7f9bbdbb
PE
2346 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2347 if b->modtime has its maximal value.
2348
dfe18f82
PE
2349 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2350
84acfcf0
PE
2351 Don't assume time_t can fit into int.
2352 * buffer.h (struct buffer.modtime): Now time_t, not int.
2353 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2354 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2355
ccd9a01a
PE
2356 Minor fixes for signed vs unsigned integers.
2357 * character.h (MAYBE_UNIFY_CHAR):
2358 * charset.c (maybe_unify_char):
2359 * keyboard.c (read_char, reorder_modifiers):
2360 XINT -> XFASTINT, since the integer must be nonnegative.
2361 * ftfont.c (ftfont_spec_pattern):
2362 * keymap.c (access_keymap, silly_event_symbol_error):
2363 XUINT -> XFASTINT, since the integer must be nonnegative.
2364 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2365 since it makes no difference and we prefer signed.
2366 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2367 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2368 nonnegative.
2369
d6d100dd
SM
23702011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 * window.h (Fwindow_frame): Declare.
2373
2b6148e4
PE
23742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2377 (SPARE_MEMORY): Always define.
2378 (LARGE_REQUEST): Remove.
2379 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2380
f230ecc9
MR
23812011-06-06 Martin Rudalics <rudalics@gmx.at>
2382
727e958e
MR
2383 * lisp.h: Move EXFUNS for Fframe_root_window,
2384 Fframe_first_window and Fset_frame_selected_window to window.h.
2385
2386 * window.h: Move EXFUNS for Fframe_root_window,
2387 Fframe_first_window and Fset_frame_selected_window here from
2388 lisp.h.
2389
2390 * frame.c (Fwindow_frame, Fframe_first_window)
2391 (Fframe_root_window, Fframe_selected_window)
2392 (Fset_frame_selected_window): Move to window.c.
2393 (Factive_minibuffer_window): Move to minibuf.c.
2394 (Fother_visible_frames_p): New function.
2395
2396 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2397
f230ecc9
MR
2398 * window.c (decode_window, decode_any_window): Move up in code.
2399 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2400 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2401 (Fwindow_buffer): Move up and rewrite doc-string.
2402 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2403 (Fwindow_prev): New functions.
727e958e
MR
2404 (Fwindow_frame): Move here from frame.c. Accept any window as
2405 argument.
2406 (Fframe_root_window, Fframe_first_window)
2407 (Fframe_selected_window): Move here from frame.c. Accept frame
2408 or arbitrary window as argument. Update doc-strings.
2409 (Fminibuffer_window): Move up in code.
2410 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2411 (Fset_frame_selected_window): Move here from frame.c.
2412 Marginal rewrite.
727e958e
MR
2413 (Fselected_window, select_window, Fselect_window): Move up in
2414 code. Minor doc-string fixes.
f230ecc9 2415
4d09bcf6
PE
24162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2417
2418 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2419 Do not assume that spare memory exists; that assumption is valid
2420 only if SYSTEM_MALLOC.
2421 (LARGE_REQUEST): New macro, so that the issue of large requests
2422 is separated from the issue of spare memory.
2423
810928a2
AS
24242011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2425
172418ad
AS
2426 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2427 format. (Bug#8806)
2428
43f862f7
AS
2429 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2430
810928a2
AS
2431 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2432 before statements.
2433
a059fe24
JD
24342011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2435
2436 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2437
2438 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2439
2440 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2441 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2442
989bf368
JB
24432011-06-05 Juanma Barranquero <lekktu@gmail.com>
2444
2445 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2446
4b80f674
CY
24472011-06-04 Chong Yidong <cyd@stupidchicken.com>
2448
2449 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2450 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2451 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2452 New error handlers.
4b80f674
CY
2453 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2454 Obey Vx_select_enable_clipboard_manager. Catch errors in
2455 x_clipboard_manager_save (Bug#8779).
2456 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2457 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2458
99a33b77 24592011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2460
2461 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2462
99a33b77 24632011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2464
2465 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2466 in the current matrix if keep_current_p is non-zero.
2467
8264569d
EZ
24682011-06-04 Eli Zaretskii <eliz@gnu.org>
2469
2470 * bidi.c (bidi_level_of_next_char): Fix last change.
2471
57f97249
EZ
24722011-06-03 Eli Zaretskii <eliz@gnu.org>
2473
fec2107c 2474 Support bidi reordering of text covered by display properties.
57f97249 2475
fec2107c
EZ
2476 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2477 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2478 (bidi_cache_search, bidi_cache_iterator_state)
2479 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2480 (bidi_level_of_next_char, bidi_move_to_visually_next):
2481 Support character positions inside a run of characters covered by a
fec2107c
EZ
2482 display string.
2483 (bidi_paragraph_init, bidi_resolve_explicit_1)
2484 (bidi_level_of_next_char): Call bidi_fetch_char and
2485 bidi_fetch_char_advance instead of FETCH_CHAR and
2486 FETCH_CHAR_ADVANCE.
2487 (bidi_init_it): Initialize new members.
2488 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2489 definitions.
2490 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2491 instead of using explicit *_CHAR codes.
d6d100dd
SM
2492 (bidi_resolve_explicit, bidi_resolve_weak):
2493 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2494 bidirectional text is supported only in multibyte buffers.
2495 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2496 it to initialize the frame_window_p member of struct bidi_it.
2497 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2498 (bidi_resolve_explicit, bidi_resolve_weak)
2499 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2500 bidi_it->nchars is non-positive.
2501 (bidi_level_of_next_char): Don't try to lookup the cache for the
2502 next/previous character if nothing is cached there yet, or if we
2503 were just reseat()'ed to a new position.
c40e2fb2 2504
0e14fe90
EZ
2505 * xdisp.c (set_cursor_from_row): Set start and stop points
2506 according to the row's direction when priming the loop that looks
2507 for the glyph on which to display cursor.
2508 (single_display_spec_intangible_p): Function deleted.
2509 (display_prop_intangible_p): Reimplement to call
2510 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2511 Accept 3 additional arguments needed by handle_display_spec.
2512 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2513 values: lists, `(when COND...)' forms, etc.
2514 (single_display_spec_string_p): Support property values that are
2515 lists with the argument STRING its top-level element.
2516 (display_prop_string_p): Fix the condition for processing a
2517 property that is a list to be consistent with handle_display_spec.
fec2107c 2518 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2519 last portion of handle_display_prop.
2520 (compute_display_string_pos): Accept additional argument
2521 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2522 value of a `display' property is a "replacing spec".
2523 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2524 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2525 the display property, but just return a value indicating whether
2526 the display property will replace the characters it covers.
2527 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2528 frame_window_p members of struct bidi_it.
d6d100dd
SM
2529 (compute_display_string_pos, compute_display_string_end):
2530 New functions.
fec2107c
EZ
2531 (push_it): Accept second argument POSITION, where pop_it should
2532 jump to continue iteration.
2533 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2534
fec2107c
EZ
2535 * keyboard.c (adjust_point_for_property): Adjust the call to
2536 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2537
2538 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2539 (bidi_init_it): Update prototypes.
2540 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2541 (compute_display_string_pos, compute_display_string_end):
2542 Declare prototypes.
fec2107c
EZ
2543 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2544 EMACS_INT.
fc6f18ce 2545
40087514 25462011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2547
57f53182
PE
2548 Malloc failure behavior now depends on size of allocation.
2549 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2550 * lisp.h: Change signatures accordingly.
2551 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2552 All callers changed. (Bug#8762)
2553
2554 * gnutls.c: Use Emacs's memory allocators.
2555 Without this change, the gnutls library would invoke malloc etc.
2556 directly, which causes problems on non-SYNC_INPUT hosts, and which
2557 runs afoul of improving memory_full behavior. (Bug#8761)
2558 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2559 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2560 xfree instead of the default malloc, realloc, free.
2561 (Fgnutls_boot): No need to check for memory allocation failure,
2562 since xmalloc does that for us.
2563
ac32cd99 2564 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2565 * category.c (hash_get_category_set):
2566 * ccl.c (ccl_driver):
2567 * charset.c (Fdefine_charset_internal):
2568 * charset.h (struct charset.hash_index):
2569 * composite.c (get_composition_id, gstring_lookup_cache)
2570 (composition_gstring_put_cache):
2571 * composite.h (struct composition.hash_index):
2572 * dispextern.h (struct image.hash):
2573 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2574 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2575 (hashfn_equal, hashfn_user_defined, make_hash_table)
2576 (maybe_resize_hash_table, hash_lookup, hash_put)
2577 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2578 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2579 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2580 * image.c (make_image, search_image_cache, lookup_image)
2581 (xpm_put_color_table_h):
2582 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2583 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2584 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2585 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2586 * alloc.c (allocate_vectorlike):
2587 Check for overflow in vector size calculations.
2588 * ccl.c (ccl_driver):
2589 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2590 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2591 need to be updated by these changes.
40087514
PE
2592 * fns.c (make_hash_table, maybe_resize_hash_table):
2593 Check for integer overflow with large hash tables.
0de4bb68
PE
2594 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2595 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2596 (SXHASH_REDUCE): New macro.
2597 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2598 Use it instead of discarding useful hash info with large hash values.
2599 (sxhash_float): New function.
2600 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2601 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2602 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2603 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2604 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2605 Adjust signatures to match updated version of code.
2606 (consing_since_gc): Now EMACS_INT, since a single hash table can
2607 use more than INT_MAX bytes.
2608
698d32e2
DN
26092011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2610
2611 Make it possible to build with GCC-4.6+ -O2 -flto.
2612
2613 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2614
fd6fa53f
SM
26152011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2616
2617 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2618 Call minibuffer-inactive-mode.
2619
864db017
JB
26202011-05-31 Juanma Barranquero <lekktu@gmail.com>
2621
2622 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2623 Update dependencies.
2624
2ad0baf4
DN
26252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2626
2627 * data.c (init_data): Remove code for UTS, this system is not
2628 supported anymore.
2629
4fcc2638
DN
26302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2631
2632 Don't force ./temacs to start in terminal mode.
2633
2634 * frame.c (make_initial_frame): Initialize faces in all cases, not
2635 only when CANNOT_DUMP is defined.
2636 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2637
c56e0fd5
DN
26382011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2639
2640 * dispnew.c (add_window_display_history): Use const for the string
2641 pointer. Remove declaration, not needed.
2642
333d54da 26432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2644
55d4c1b2 2645 Use 'inline', not 'INLINE'.
333d54da 2646 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2647 * alloc.c, fontset.c (INLINE): Remove.
2648 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2649 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2650 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2651 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2652 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2653
738db178
DN
26542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2655
2656 Make it possible to run ./temacs.
2657
2658 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2659 syms_of_callproc does the same thing. Remove test for
2660 "initialized", do it in the caller.
2661 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2662
620c53a6
SM
26632011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2664
2665 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2666 (read_minibuf): Use get_minibuffer.
2667 (syms_of_minibuf): Use DEFSYM.
2668 (Qmetadata): New var.
2669 * data.c (Qbuffer): Don't make it static.
2670 (syms_of_data): Use DEFSYM.
2671
e003a292
PE
26722011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2675 (CCL_CODE_MIN): New macro.
2676
ed008a6d
PE
26772011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2678
3687c2ef
PE
2679 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2680
ed008a6d
PE
2681 * eval.c (Qdebug): Now static.
2682 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2683 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2684 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2685
d66c4c7c
CY
26862011-05-29 Chong Yidong <cyd@stupidchicken.com>
2687
2688 * image.c: Various fixes to ImageMagick code comments.
2689 (Fimagemagick_types): Doc fix.
2690
5fbc2025
PE
26912011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2692
0196f88a
PE
2693 Minor fixes prompted by GCC 4.6.0 warnings.
2694
2695 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2696
5fbc2025
PE
2697 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2698 (x_clipboard_manager_save_all): Move extern decl to ...
2699 * xterm.h: ... here, so that it can be checked for consistency.
2700
1dd3c2d9
CY
27012011-05-29 Chong Yidong <cyd@stupidchicken.com>
2702
2703 * xselect.c (x_clipboard_manager_save_frame)
2704 (x_clipboard_manager_save_all): New functions.
2705 (Fx_clipboard_manager_save): Lisp function deleted.
2706
2707 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2708 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2709
2710 * xterm.h: Update prototype.
2711
5ba6571d
WX
27122011-05-28 William Xu <william.xwl@gmail.com>
2713
2714 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2715 exiting (Bug#8239).
2716
3eaff834
JM
27172011-05-28 Jim Meyering <meyering@redhat.com>
2718
e1900994 2719 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2720 * fns.c (to_uchar): Define.
2721 (crypto_hash_function): Use it to convert some newly-signed
2722 variables to unsigned, to avoid sign-extension bugs. For example,
2723 without this change, (md5 "truc") would evaluate to
2724 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2725 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2726 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2727
0f6990a7
PE
27282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 Integer overflow fixes.
c8a9ca5a 2731
08686060
PE
2732 * dbusbind.c: Serial number integer overflow fixes.
2733 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2734 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2735 to hold a serial number that is too large for a fixnum.
2736 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2737 Check for serial numbers out of range. Decode any serial number
59568bf0 2738 that was so large that it became a float. (Bug#8722)
08686060 2739
2d1fc3c7
PE
2740 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2741 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2742 Use XFASTINT rather than XUINT when numbers are nonnegative.
2743 (xd_append_arg, Fdbus_method_return_internal):
2744 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2745 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2746 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2747 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2748 (Bug#8722)
2d1fc3c7 2749
c8a9ca5a
PE
2750 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2751
519e1d69
PE
2752 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2753
30569699
PE
2754 ccl: add integer overflow checks
2755 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2756 (IN_INT_RANGE): New macros.
2757 (ccl_driver): Use them to check for integer overflow when
2758 decoding a CCL program. Many of the new checks are whether XINT (x)
2759 fits in int; it doesn't always, on 64-bit hosts. The new version
2760 doesn't catch all possible integer overflows, but it's an
847044ea 2761 improvement. (Bug#8719)
30569699 2762
c11285dc
PE
2763 * alloc.c (make_event_array): Use XINT, not XUINT.
2764 There's no need for unsigned here.
2765
fdccd48e
PE
2766 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2767 This follows up to the 2011-05-06 change that substituted uintptr_t
2768 for EMACS_INT. This case wasn't caught back then.
2769
37910ab2
PE
2770 Rework Fformat to avoid integer overflow issues.
2771 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2772 now (part of C89). Include <verify.h>.
2773 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2774 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2775 (Fformat): Avoid the prepass trying to compute sizes; it was only
2776 approximate and thus did not catch overflow reliably. Instead, walk
2777 through the format just once, formatting and computing sizes as we go,
2778 checking for integer overflow at every step, and allocating a larger
2779 buffer as needed. Keep track separately whether the format is
2780 multibyte. Keep only the most-recently calculated precision, rather
2781 than them all. Record whether each argument has been converted to
2782 string. Use EMACS_INT, not int, for byte and char and arg counts.
2783 Support field widths and precisions larger than INT_MAX. Avoid
2784 sprintf's undefined behavior with conversion specifications such as %#d
2785 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2786 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2787 formatting out-of-range floating point numbers with int
9173deec 2788 formats. (Bug#8668)
37910ab2 2789
2e6578fb
PE
2790 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2791
0ae6bdee
PE
2792 * data.c: Avoid integer truncation in expressions involving floats.
2793 * data.c: Include <intprops.h>.
2794 (arith_driver): When there's an integer overflow in an expression
2795 involving floating point, convert the integers to floating point
2796 so that the resulting value does not suffer from catastrophic
2797 integer truncation. For example, on a 64-bit host (* 4
2798 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2799 Do not rely on undefined behavior after integer overflow.
2800
de883a70
PE
2801 merge count_size_as_multibyte, parse_str_to_multibyte
2802 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2803 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2804 Check for integer overflow.
2805 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2806 since it's now a duplicate of the other. This is more of
2807 a character than a buffer op, so better that it's in character.c.
2808 * fns.c, print.c: Adjust to above changes.
2809
2ff916cb
PE
28102011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2811
2812 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2813
f1b54466
PE
28142011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2815
fb1ac845
PE
2816 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2817 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2818 (x_clipboard_manager_save): Now static.
2819 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2820
f1b54466
PE
2821 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2822 (crypto_hash_function): Now static.
2823 Fix pointer signedness problems. Avoid unnecessary initializations.
2824
a9f737ee
CY
28252011-05-27 Chong Yidong <cyd@stupidchicken.com>
2826
2827 * termhooks.h (Vselection_alist): Make it terminal-local.
2828
2829 * terminal.c (create_terminal): Initialize it.
2830
2831 * xselect.c: Support for clipboard managers.
2832 (Vselection_alist): Move to termhooks.h as terminal-local var.
2833 (LOCAL_SELECTION): New macro.
2834 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2835 (symbol_to_x_atom): Remove gratuitous arg.
2836 (x_handle_selection_request, lisp_data_to_selection_data)
2837 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2838 (x_own_selection, x_get_local_selection, x_convert_selection):
2839 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2840 (some_frame_on_display): Delete unused function.
2841 (Fx_own_selection_internal, Fx_get_selection_internal)
2842 (Fx_disown_selection_internal, Fx_selection_owner_p)
2843 (Fx_selection_exists_p): New optional frame arg.
2844 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2845 (x_handle_selection_clear): Don't treat other terminals with the
2846 same keyboard specially. Use the terminal-local Vselection_alist.
2847 (x_clear_frame_selections): Use Frun_hook_with_args.
2848
2849 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2850
2851 * xterm.h: Add support for those atoms.
2852
e067f0c1
CY
28532011-05-26 Chong Yidong <cyd@stupidchicken.com>
2854
2855 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2856 (converted_selections, conversion_fail_tag): New global variables.
2857 (x_selection_request_lisp_error): Free the above.
2858 (x_get_local_selection): Remove unnecessary code.
2859 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2860 of converted selections stored in converted_selections.
2861 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2862 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2863 (x_convert_selection): New function.
2864 (x_handle_selection_event): Simplify.
2865 (x_get_foreign_selection): Don't ignore incoming requests while
2866 waiting for an answer; this will fail when we implement
2867 SAVE_TARGETS, and seems unnecessary anyway.
2868 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2869 (Vx_sent_selection_functions): Doc fix.
2870
0f4aebc0
LL
28712011-05-26 Leo Liu <sdl.web@gmail.com>
2872
2873 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2874
e61124cd
YM
28752011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2876
2877 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2878
2879 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2880 for fringe update if it has periodic bitmap.
ac389d0c 2881 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2882 and fringe_bitmap_periodic_p.
2883
2884 * fringe.c (get_fringe_bitmap_data): New function.
2885 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2886 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2887 row. Mark glyph row for fringe update if periodicity changed.
2888
2889 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2890 for fringe update unless it has periodic bitmap.
2891
f16d9837
KH
28922011-05-25 Kenichi Handa <handa@m17n.org>
2893
2894 * xdisp.c (get_next_display_element): Set correct it->face_id for
2895 a static composition.
2896
e1b90ef6
LL
28972011-05-24 Leo Liu <sdl.web@gmail.com>
2898
2899 * deps.mk (fns.o):
2900 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2901
2902 * fns.c (crypto_hash_function, Fsha1): New function.
2903 (Fmd5): Use crypto_hash_function.
2904 (syms_of_fns): Add Ssha1.
2905
7400048f
PE
29062011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 * gnutls.c: Remove unused macros.
2909 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2910 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2911 Remove macros that are defined and never used.
2912 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2913
abb71cf4
CY
29142011-05-22 Chong Yidong <cyd@stupidchicken.com>
2915
2916 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2917 (Fx_get_selection_internal): Minor cleanup.
2918 (Fx_own_selection_internal): Rename arguments for consistency with
2919 select.el.
2920
6307db39
PE
29212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2924
f3d4e0a4
CY
29252011-05-22 Chong Yidong <cyd@stupidchicken.com>
2926
2927 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2928
4d8ade89
YM
29292011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2930
2931 * dispnew.c (scrolling_window): Don't exclude the case that the
2932 last enabled row in the desired matrix touches the bottom boundary.
2933
32078c8d
GM
29342011-05-21 Glenn Morris <rgm@gnu.org>
2935
2936 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2937 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2938 and add some more files.
32078c8d 2939
7285dc67
EZ
29402011-05-20 Eli Zaretskii <eliz@gnu.org>
2941
2942 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2943 report_file_error introduced by the change from 2011-05-07.
2944
89d1bd22
PE
29452011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2946
2947 * systime.h (Time): Define only if emacs is defined.
2948 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2949 where the include path doesn't have X11/X.h by default. See
2950 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2951
e23640bb 29522011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2953
2954 * composite.c (find_automatic_composition): Fix previous change.
2955
b9704ad9
GM
29562011-05-20 Glenn Morris <rgm@gnu.org>
2957
2958 * lisp.mk: New file, split from Makefile.in.
2959 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2960 (shortlisp): Remove.
2961 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2962
4a720484
GM
29632011-05-19 Glenn Morris <rgm@gnu.org>
2964
2965 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2966 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2967 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2968 (lisp): Set the order to that of loadup.el.
2969 (shortlisp): Make it a copy of $lisp.
2970 (SOME_MACHINE_LISP): Remove.
2971 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2972 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2973
a28d4396
KH
29742011-05-18 Kenichi Handa <handa@m17n.org>
2975
2976 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2977 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2978 (find_automatic_composition): Mostly rewrite for efficiency.
2979
a2b1fa8e
JB
29802011-05-18 Juanma Barranquero <lekktu@gmail.com>
2981
2982 * makefile.w32-in: Update dependencies.
2983
8e1f5610
CS
29842011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2985
2986 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2987 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2988
7025ee00 29892011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2990
cdfa6eab
PE
2991 Fix some integer overflow issues, such as string length overflow.
2992
06d6db33
PE
2993 * insdel.c (count_size_as_multibyte): Check for string overflow.
2994
2b4560a8
PE
2995 * character.c (lisp_string_width): Check for string overflow.
2996 Use EMACS_INT, not int, for string indexes and lengths; in
2997 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2998 the resulting string length overflows an EMACS_INT; instead,
2999 report a string overflow if no precision given. When checking for
3000 precision exhaustion, use a check that cannot possibly have
3001 integer overflow. (Bug#8675)
3002 * character.h (lisp_string_width): Adjust to new signature.
3003
cb93f9be
PE
3004 * alloc.c (string_overflow): New function.
3005 (Fmake_string): Use it. This doesn't change behavior, but saves
3006 a few bytes and will simplify future changes.
3007 * character.c (string_escape_byte8): Likewise.
3008 * lisp.h (string_overflow): New decl.
3009
1a1f3366
PE
3010 Fixups, following up to the user-interface timestamp change.
3011 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3012 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3013 * msdos.c (mouse_get_pos): Likewise.
3014 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3015 * w32gui.h (Time): Define by including "systime.h" rather than by
3016 declaring it ourselves. (Bug#8664)
3017
d4e3e4d3
PE
3018 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3019 * image.c (clear_image_cache): Likewise.
3020
f6a24d19
PE
3021 * term.c (term_mouse_position): Don't assume time_t wraparound.
3022
08dc5ae6
PE
3023 Be more systematic about user-interface timestamps.
3024 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3025 and sometimes 'EMACS_UINT', to represent these timestamps.
3026 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3027 This makes the code easier to follow, and makes it easier to catch
3028 integer overflow bugs such as Bug#8664.
3029 * frame.c (Fmouse_position, Fmouse_pixel_position):
3030 Use Time, not unsigned long, for user-interface timestamps.
3031 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3032 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3033 * keyboard.h (last_event_timestamp): Likewise.
3034 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3035 * menu.h (xmenu_show): Likewise.
3036 * term.c (term_mouse_position): Likewise.
3037 * termhooks.h (struct input_event.timestamp): Likewise.
3038 (struct terminal.mouse_position_hook): Likewise.
3039 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3040 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3041 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3042 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3043 what it was before.
3044 * menu.h, termhooks.h: Include "systime.h", for Time.
3045
8e55734a
PE
3046 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3047 Don't assume that the difference between two unsigned long values
3048 can fit into an integer. At this point, we know button_down_time
3049 <= event->timestamp, so the difference must be nonnegative, so
3050 there's no need to cast the result if double-click-time is
3051 nonnegative, as it should be; check that it's nonnegative, just in
3052 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3053 apart (about 25 days). (Bug#8664)
8e55734a 3054
841f1b75 3055 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3056 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3057
3e26f69c
PE
3058 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3059 that always fit in int. Use a sentinel instead of a counter, to
3060 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3061 * frame.h (struct frame): Use int for menu_bar_items_used
3062 instead of EMACS_INT, since it always fits in int.
3e26f69c 3063
5cc152c0
PE
3064 * menu.c (grow_menu_items): Check for int overflow.
3065
d89eb65e
PE
3066 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3067
5235bd3e
PE
3068 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3069 Before, the code was not consistent. These values cannot exceed
3070 2**31 - 1 so there's no need to make them unsigned.
3071 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3072 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3073 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3074 as modifiers.
3075 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3076
bc827e23
PE
3077 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3078 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3079 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3080 presumably because the widths might not match.
3081
78eb494e
PE
3082 * window.c (size_window): Avoid needless test at loop start.
3083
04f2d78b
CB
30842011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3085
3086 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3087
d2fc7e3d 30882011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3089
3090 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3091
d2fc7e3d 30922011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3093
3094 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3095 `width' to `bar_area_x' and `bar_area_width', respectively.
3096 (x_scroll_run): Take account of fringe background extension.
3097
04f2d78b
CB
3098 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3099 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3100 `bar_area_width', respectively.
3101 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3102 background extension.
3103
79b70037
GM
31042011-05-10 Jim Meyering <meyering@redhat.com>
3105
3106 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3107
2f142cc5
JB
31082011-05-10 Juanma Barranquero <lekktu@gmail.com>
3109
3110 * image.c (Finit_image_library): Return t for built-in image types,
3111 like pbm and xbm. (Bug#8640)
3112
57679c86
AS
31132011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3114
3115 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3116
888c9e86
EZ
31172011-05-07 Eli Zaretskii <eliz@gnu.org>
3118
b0512a1d
EZ
3119 * w32console.c (Fset_screen_color): Doc fix.
3120 (Fget_screen_color): New function.
3121 (syms_of_ntterm): Defsubr it.
3122
7285dc67
EZ
3123 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3124 unlink the temporary file if Fcall_process didn't create it in the
3125 first place.
3126 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3127 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3128 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3129 cue to call_process_cleanup not to close that handle.
3130
4d3fcc8e
BK
31312011-05-07 Ben Key <bkey76@gmail.com>
3132
3133 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3134 one of two shell specific rules, either bootstrap-temacs-CMD or
3135 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3136 to the previous implementation of the bootstrap-temacs rule.
3137 The bootstrap-temacs-CMD rule is similar to the previous
3138 implementation of the bootstrap-temacs rule except that it
3139 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3140 variable.
3141
3142 These changes, along with some changes to nt/configure.bat,
3143 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3144 earlier fix to add support for --cflags and --ldflags options
3145 that include quotes so that it works whether make uses cmd or
3146 sh as the shell.
3147
b4289b64
MA
31482011-05-06 Michael Albinus <michael.albinus@gmx.de>
3149
3150 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3151 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3152 is a constant.
3153 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3154 a string. Handle both cases.
3155 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3156 (Fdbus_register_method): Use Qinvalid_function.
3157
af4c0e28
JB
31582011-05-06 Juanma Barranquero <lekktu@gmail.com>
3159
3160 * makefile.w32-in: Update dependencies.
3161 (LISP_H): Add inttypes.h and stdin.h.
3162 (PROCESS_H): Add unistd.h.
3163
c51453d9
EZ
31642011-05-06 Eli Zaretskii <eliz@gnu.org>
3165
3166 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3167 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3168
8ff0ac3c 31692011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3170
4c4b566b
PE
3171 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3172
aab2b9b5
PE
3173 * term.c (vfatal): Remove stray call to va_end.
3174 It's not needed and the C Standard doesn't allow it here anyway.
3175
c378da0b
PE
3176 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3177 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3178
288b08c7
PE
3179 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3180 bytes.
3181
e3601888
PE
3182 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3183
db6c0e74
PE
3184 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3185
dd5963ea
PE
3186 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3187
88c9450f
PE
3188 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3189
2f9442b8
PE
3190 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3191
c032b5f8
PE
3192 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3193 * charset.c (Fdefine_charset_internal): Don't initialize
3194 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3195 32-bit int (Bug#8600).
a108c10b
PE
3196
3197 * lread.c (read_integer): Be more consistent with string-to-number.
3198 Use string_to_number to do the actual conversion; this avoids
3199 rounding errors and fixes some other screwups. Without this fix,
3200 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3201 (digit_to_number): Move earlier, for benefit of read_integer.
3202 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3203 not a digit in any supported base. (Bug#8602)
a108c10b 3204
ad5f9eea
PE
3205 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3206
aec1708a
PE
3207 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3208 to match comment at start of function. This also removes a
3209 GCC warning about overflow in a 32+64-bit port.
3210
47be4ab5
PE
3211 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3212
371cac43
PE
3213 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3214 Reported by Stefan Monnier in
3215 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3216 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3217 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3218
d01a7826
PE
3219 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3220 (EMACS_UINTPTR): Likewise, with uintptr_t.
3221
7fd47d5c
PE
3222 * lisp.h: Prefer 64-bit EMACS_INT if available.
3223 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3224 on 32-bit hosts that have 64-bit int, so that they can access
3225 large files.
122b0c86
PE
3226 However, temporarily disable this change unless the temporary
3227 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3228
8727937b
PE
3229 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3230
8ac068ac
PE
3231 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3232 This removes an assumption that EMACS_INT and long are the same
3233 width as pointers. The assumption is true for Emacs porting targets
3234 now, but we want to make other targets possible.
3235 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3236 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3237 In the rest of the code, change types of integers that hold casted
3238 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3239 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3240 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3241 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3242 No need to cast type when ORing.
3243 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3244 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3245 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3246 assume EMACS_INT is the same width as char *.
3247 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3248 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3249 Remove no-longer-needed casts.
3250 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3251 (xg_tool_bar_help_callback, xg_make_tool_item):
3252 Use EMACS_INTPTR to hold an integer
3253 that will be cast to void *; this can avoid a GCC warning
3254 if EMACS_INT is not the same width as void *.
3255 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3256 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3257 (current_message_1, set_message_1):
3258 Use a local to convert to proper width without a cast.
3259 * xmenu.c (dialog_selection_callback): Likewise.
3260
ede49d71
PE
3261 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3262 Also, don't assume VALBITS / RAND_BITS is less than 5,
3263 and don't rely on undefined behavior when shifting a 1 left into
3264 the sign bit.
3265 * lisp.h (get_random): Change signature to match.
3266
2f30ecd0
PE
3267 * lread.c (hash_string): Use size_t, not int, for hash computation.
3268 Normally we prefer signed values; but hashing is special, because
3269 it's better to use unsigned division on hash table sizes so that
3270 the remainder is nonnegative. Also, size_t is the natural width
3271 for hashing into memory. The previous code used 'int', which doesn't
3272 retain enough info to hash well into very large tables.
3273 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3274
2a866e7b
PE
3275 * dbusbind.c: Don't possibly lose pointer info when converting.
3276 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3277 Use XPNTR rather than XHASH, so that the high-order bits of
3278 the pointer aren't lost when converting through void *.
3279
51639eac
PE
3280 * eval.c (Fautoload): Don't double-shift a pointer.
3281
92394119
PE
3282 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3283
dbdb9a7c
JB
32842011-05-06 Juanma Barranquero <lekktu@gmail.com>
3285
3286 * gnutls.c (DEF_GNUTLS_FN):
3287 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3288
db7a0b4f
AS
32892011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3290
3291 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3292 marker. (Bug#8610)
3293
f7ff1b0f 32942011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3295
3296 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3297 New version that can reserve upto 2GB of heap space.
3298
f7ff1b0f 32992011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3300
3301 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3302
639c109b
TZ
33032011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3304
3305 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3306 `gnutls_certificate_set_x509_key_file'.
3307
d2127135
JB
33082011-05-05 Juanma Barranquero <lekktu@gmail.com>
3309
3310 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3311 Update dependencies.
3312
e968f4f3
JB
33132011-05-04 Juanma Barranquero <lekktu@gmail.com>
3314
3315 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3316 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3317 Remove unused parameter `fildes'.
3318 * process.c (read_process_output, send_process): Don't pass it.
3319
84d358f0
JB
33202011-05-04 Juanma Barranquero <lekktu@gmail.com>
3321
3322 Fix previous change: the library cache is defined in w32.c.
3323 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3324 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3325
0898ca10
JB
33262011-05-04 Juanma Barranquero <lekktu@gmail.com>
3327
3328 Implement dynamic loading of GnuTLS on Windows.
3329
3330 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3331 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3332 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3333 Declare.
3334
3335 * gnutls.c (Qgnutls_dll): Define.
3336 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3337 (gnutls_*): Declare function pointers.
3338 (init_gnutls_functions): New function to initialize function pointers.
3339 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3340 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3341 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3342 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3343 (emacs_gnutls_write, emacs_gnutls_read)
3344 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3345 (Fgnutls_available_p): New function.
3346 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3347 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3348 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3349
3350 * image.c: Include w32.h.
3351 (Vimage_type_cache): Delete.
3352 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3353 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3354 (w32_delayed_load): Move to w32.c.
3355
3356 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3357
3358 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3359 (w32_delayed_load): Move from image.c. When loading a library, record
3360 its filename in the :loaded-from property of the library id.
3361 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3362 Initialize and staticpro them.
3363 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3364
3365 * process.c: Include lisp.h before w32.h, not after.
3366 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3367 instead of gnutls_record_check_pending.
3368
3369 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3370
ff4de4aa
TZ
33712011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3372
3373 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3374 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3375 as passed in.
3376
abe95abb
JD
33772011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3378
3379 * xterm.c (x_set_frame_alpha): Do not set property on anything
3380 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3381
e16e55d4
JB
33822011-05-02 Juanma Barranquero <lekktu@gmail.com>
3383
3384 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3385
bafcf6a5
JB
33862011-05-02 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3389 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3390 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3391 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3392 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3393 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3394 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3395 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3396 (Qgnutls_bootprop_callbacks_verify): Make static.
3397
e7a6747f
AS
33982011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3399
19ed11ba
AS
3400 * callproc.c: Indentation fixup.
3401
e7a6747f 3402 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3403 (wait_for_termination, interruptible_wait_for_termination):
3404 Move after wait_for_termination_1.
e7a6747f 3405
1ef14cb4
LMI
34062011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3407
3408 * sysdep.c (interruptible_wait_for_termination): New function
3409 which is like wait_for_termination, but allows keyboard
3410 interruptions.
3411
3412 * callproc.c (Fcall_process): Add (:file "file") as an option for
3413 the STDOUT buffer.
3414 (Fcall_process_region): Ditto.
3415
330d880c
EZ
34162011-04-30 Eli Zaretskii <eliz@gnu.org>
3417
8db90b73
EZ
3418 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3419 rather than `XVECTOR (FOO)->size'.
3420
330d880c
EZ
3421 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3422 inttypes.h, as a gnulib replacement is used if it not available in
3423 system headers.
3424
15cbd324
EZ
34252011-04-21 Eli Zaretskii <eliz@gnu.org>
3426
3427 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3428 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3429 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3430
3431 * coding.c (coding_alloc_by_realloc): Error out if destination
3432 will grow beyond MOST_POSITIVE_FIXNUM.
3433 (decode_coding_emacs_mule): Abort if there isn't enough place in
3434 charbuf for the composition carryover bytes. Reserve an extra
3435 space for up to 2 characters produced in a loop.
3436 (decode_coding_iso_2022): Abort if there isn't enough place in
3437 charbuf for the composition carryover bytes.
3438
34392011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3440
ae940cca
EZ
3441 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3442 aborting when %lld or %lll format is passed.
3443 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3444 %llo or %llx format is passed. (Bug#8545)
3445
03ab8921
EZ
3446 * window.c (window_scroll_line_based): Use a marker instead of
3447 simple variables to record original value of point. (Bug#7952)
3448
afda1437
EZ
3449 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3450 produced by %s or %c overflows available buffer space. (Bug#8545)
3451
f76dee0c
PE
34522011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3453
3454 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3455 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3456
fdc5744d
JB
34572011-04-28 Juanma Barranquero <lekktu@gmail.com>
3458
3459 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3460
638f053a
JB
34612011-04-28 Juanma Barranquero <lekktu@gmail.com>
3462
3463 * keyboard.c (Qdelayed_warnings_hook): Define.
3464 (command_loop_1): Run `delayed-warnings-hook'
3465 if Vdelayed_warnings_list is non-nil.
3466 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3467 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3468
d178f871
EZ
34692011-04-28 Eli Zaretskii <eliz@gnu.org>
3470
3471 * doprnt.c (doprnt): Don't return value smaller than the buffer
3472 size if the message was truncated. (Bug#8545).
3473
b124fd93
JB
34742011-04-28 Juanma Barranquero <lekktu@gmail.com>
3475
3476 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3477 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3478
e810457d
PE
34792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3480
3481 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3482
ea51cceb
JB
34832011-04-27 Juanma Barranquero <lekktu@gmail.com>
3484
3485 * makefile.w32-in: Update dependencies.
3486
94dcfacf
EZ
34872011-04-27 Eli Zaretskii <eliz@gnu.org>
3488
3489 Improve `doprnt' and its usage. (Bug#8545)
3490 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3491 `format_end'. Remove support for %l as a conversion specifier.
3492 Don't use xrealloc. Improve diagnostics when the %l size modifier
3493 is used. Update the commentary.
3494
3495 * eval.c (verror): Simplify calculation of size_t.
3496
3497 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3498 messages.
3499
f61f41d7
PE
35002011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3501
3502 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3503 change.
3504
96fb4434
PE
35052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3508 This makes this file independent of the recent pseudovector change.
3509
671875da 35102011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3511
69e9b5a3
PE
3512 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3513
b5f869a7 3514 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3515 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3516 Remove unused local.
c8926152 3517 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3518
841a1577 3519 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3520 GCC 4.6.0 optimizes based on type-based alias analysis.
3521 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3522 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3523 != &v->size, and therefore "v->size = 1; b->size = 2; return
3524 v->size;" must therefore return 1. This assumption is incorrect
3525 for Emacs, since it type-puns struct Lisp_Vector * with many other
3526 types. To fix this problem, this patch adds a new type struct
f904488f 3527 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3528 and pseudovectors, and helps optimizing compilers not get fooled
3529 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3530 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3531 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3532 the size member.
eab3844f
PE
3533 (XSETPVECTYPE): Rewrite in terms of new macro.
3534 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3535 This is a bit clearer, and further avoids the possibility of
3536 undesirable aliasing.
3537 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3538 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3539 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3540 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3541 (ASIZE): Now uses header.size rather than size.
3542 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3543 to avoid the hassle of writing XVECTOR (foo)->header.size.
3544 (struct vectorlike_header): New type.
eab3844f
PE
3545 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3546 object, to help avoid aliasing.
3547 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3548 (SUBRP): Likewise, since Lisp_Subr is a special case.
3549 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3550 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3551 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3552 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3553 changed to be "header.size" and "header.next".
3554 * buffer.h (struct buffer): Likewise.
3555 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3556 * frame.h (struct frame): Likewise.
3557 * process.h (struct Lisp_Process): Likewise.
3558 * termhooks.h (struct terminal): Likewise.
3559 * window.c (struct save_window_data, struct saved_window): Likewise.
3560 * window.h (struct window): Likewise.
3561 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3562 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3563 * buffer.c (init_buffer_once): Likewise.
3564 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3565 special case.
3566 * process.c (Fformat_network_address): Use local var for size,
3567 for brevity.
3568
0df1eac5
PE
3569 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3570
847ab9d1 3571 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3572 * data.c (atof): Remove decl; no longer used or needed.
3573 (digit_to_number): Move to lread.c.
3574 (Fstring_to_number): Use new string_to_number function, to be
3575 consistent with how the Lisp reader treats infinities and NaNs.
3576 Do not assume that floating-point numbers represent EMACS_INT
3577 without losing information; this is not true on most 64-bit hosts.
3578 Avoid double-rounding errors, by insisting on integers when
3579 parsing non-base-10 numbers, as the documentation specifies.
3580 * lisp.h (string_to_number): New decl, replacing ...
3581 (isfloat_string): Remove.
bc0a5c13 3582 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3583 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3584 appears to have been a coding error. Similarly, do not accept
3585 strings like +-1e0 as floating point numbers. Do not report
3586 overflow for integer overflows unless the base is not 10 which
3587 means we have no simple and reliable way to continue.
3588 Break out the floating-point parsing into a new
3589 function string_to_number, so that Fstring_to_number parses
3590 floating point numbers consistently with the Lisp reader.
04f2d78b 3591 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3592 (E_CHAR, EXP_INT): Remove, replacing with ...
3593 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3594 (string_to_number): New function, replacing isfloat_string.
3595 This function checks for valid syntax and produces the resulting
3596 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3597 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3598 so that overflow for non-base-10 numbers is reported only when
3599 there's no portable and simple way to convert to floating point.
452f4150 3600
67769ffc
PE
3601 * textprop.c (set_text_properties_1): Rewrite for clarity,
3602 and to avoid GCC warning about integer overflow.
3603
c20db43f
PE
3604 * intervals.h (struct interval): Use EMACS_INT for members
3605 where EMACS_UINT might cause problems. See
3606 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3607 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3608 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3609 All uses changed.
37aa2f85
PE
3610 (offset_intervals): Tell GCC not to worry about length overflow
3611 when negating a negative length.
c20db43f 3612
2538aa2f
PE
3613 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3614 (overrun_check_free): Likewise.
3615
f2d3008d
PE
3616 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3617 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3618 word size.
3619
ec8df744
PE
3620 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3621 (gnutls_make_error): Rename local to avoid shadowing.
3622 (gnutls_emacs_global_deinit): ifdef out; not used.
3623 (Fgnutls_boot): Use const for pointer to readonly storage.
3624 Comment out unused local. Fix pointer signedness problems.
3625
640ee02d
PE
3626 * lread.c (openp): Don't stuff size_t into an 'int'.
3627 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3628 about possible signed overflow.
3629
6048fb2a
PE
3630 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3631 (GDK_KEY_g): Don't define if already defined.
3632 (xg_prepare_tooltip): Avoid pointer signedness problem.
3633 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3634
fa3c87e1
PE
3635 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3636 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3637
2172544b
PE
3638 * xfns.c (Fx_window_property): Simplify a bit,
3639 to make a bit faster and to avoid GCC 4.6.0 warning.
3640 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3641
9b821a21
PE
3642 * fns.c (internal_equal): Don't assume size_t fits in int.
3643
3c616cfa
PE
3644 * alloc.c (compact_small_strings): Tighten assertion a little.
3645
c2982e87
PE
3646 Replace pEd with more-general pI, and fix some printf arg casts.
3647 * lisp.h (pI): New macro, generalizing old pEd macro to other
3648 conversion specifiers. For example, use "...%"pI"d..." rather
3649 than "...%"pEd"...".
3650 (pEd): Remove. All uses replaced with similar uses of pI.
3651 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3652 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3653 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3654 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3655 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3656 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3657 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3658 64-bit hosts.
3659 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3660 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3661 * print.c (safe_debug_print, print_object): Likewise.
3662 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3663 to int.
6f04d126
PE
3664 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3665 avoiding the 0 flag, which is not portable.
c2982e87
PE
3666 * process.c (Fmake_network_process): Use pI to avoid cast.
3667 * region-cache.c (pp_cache): Likewise.
3668 * xdisp.c (decode_mode_spec): Likewise.
3669 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3670 behavior on 64-bit hosts with printf arg.
6f04d126 3671 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3672 (x_stop_queuing_selection_requests): Likewise.
3673 (x_get_window_property): Don't truncate byte count to an 'int'
3674 when tracing.
0b432f21 3675
5e073ec7
PE
3676 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3677 here, since it parses constructs like leading '-' and spaces,
3678 which are not wanted; and it overflows with large numbers.
3679 Instead, simply match F[0-9]+, which is what is wanted anyway.
3680
36372bf9
PE
3681 * alloc.c: Remove unportable assumptions about struct layout.
3682 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3683 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3684 (allocate_vectorlike, make_pure_vector): Use the new macros,
3685 plus offsetof, to remove unportable assumptions about struct layout.
3686 These assumptions hold on all porting targets that I know of, but
3687 they are not guaranteed, they're easy to remove, and removing them
3688 makes further changes easier.
3689
0b432f21
PE
3690 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3691 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3692 (string_overrun_cookie): Now const. Use initializers that
3693 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3694 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3695 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3696 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3697 multiple of sizeof (EMACS_INT); it need not be, if
3698 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3699 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3700
895009e1
JB
37012011-04-26 Juanma Barranquero <lekktu@gmail.com>
3702
3703 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3704
6a7a1b0b
TZ
37052011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3706
3707 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3708 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3709 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3710
841a1577 37112011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3712
3713 * lisp.h (Qdebug): List symbol.
895009e1 3714 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3715 * keyboard.c (debug-on-event): New variable.
3716 (handle_user_signal): Break into debugger when debug-on-event
3717 matches the current signal symbol.
3718
f2d3ba6f
DN
37192011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3720
3721 * alloc.c (check_sblock, check_string_bytes)
3722 (check_string_free_list): Convert to standard C.
3723
42ce4c63
TZ
37242011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3725
3726 * w32.c (emacs_gnutls_push): Fix typo.
3727
825cd63c
EZ
37282011-04-25 Eli Zaretskii <eliz@gnu.org>
3729
fb11d64d
EZ
3730 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3731 "cast to pointer from integer of different size".
3732
825cd63c
EZ
3733 Improve doprnt and its use in verror. (Bug#8545)
3734 * doprnt.c (doprnt): Document the set of format control sequences
3735 supported by the function. Use SAFE_ALLOCA instead of always
3736 using `alloca'.
3737
3738 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3739 is one byte too soon. Don't use xrealloc; instead xfree and
3740 xmalloc anew.
3741
e061a11b
TZ
37422011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3743
3744 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3745 callbacks stage.
3746
3747 * gnutls.c: Renamed global_initialized to
3748 gnutls_global_initialized. Added internals for the
3749 :verify-hostname-error, :verify-error, and :verify-flags
3750 parameters of `gnutls-boot' and documented those parameters in the
3751 docstring. Start callback support.
9173deec
JB
3752 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3753 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3754 on error. Return error code.
e061a11b
TZ
3755 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3756 (emacs_gnutls_read): Likewise.
3757 (Fgnutls_boot): Return handshake error code.
3758 (emacs_gnutls_handle_error): New function.
3759 (wsaerror_to_errno): Likewise.
3760
3761 * w32.h (emacs_gnutls_pull): Add prototype.
3762 (emacs_gnutls_push): Likewise.
3763
3764 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3765 (emacs_gnutls_push): Likewise.
3766
37672011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3768
3769 * process.c (wait_reading_process_output): Check if GnuTLS
3770 buffered some data internally if no FDs are set for TLS
3771 connections.
3772
3773 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3774 (LIBS): Link to USER_LIBS.
3775 ($(BLD)/gnutls.$(0)): New target.
3776
fa6996bc
EZ
37772011-04-24 Eli Zaretskii <eliz@gnu.org>
3778
eb35682e
EZ
3779 * xdisp.c (handle_single_display_spec): Rename the
3780 display_replaced_before_p argument into display_replaced_p, to
3781 make it consistent with the commentary. Fix typos in the
3782 commentary.
3783
e2ad650c
EZ
3784 * textprop.c (syms_of_textprop): Remove dead code.
3785 (copy_text_properties): Delete obsolete commentary about an
3786 interface that was deleted long ago. Fix typos in the description
3787 of arguments.
3788
1b2de274
EZ
3789 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3790 to changes in oldXMenu/XMenu.h from 2011-04-16.
3791 <menu_help_message, prev_menu_help_message>: Constify.
3792 (IT_menu_make_room): menu->help_text is now `const char **';
3793 adjust.
3794
3795 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3796 to changes in oldXMenu/XMenu.h from 2011-04-16.
3797 (struct XMenu): Declare `help_text' `const char **'.
3798
3799 * xfaces.c <Qunspecified>: Make extern again.
3800
3801 * syntax.c: Include sys/types.h before including regex.h, as
3802 required by Posix.
3803
762b15be
EZ
3804 * doc.c (get_doc_string): Improve the format passed to `error'.
3805
3806 * doprnt.c (doprnt): Improve commentary.
3807
3808 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3809
3810 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3811 them with etags.
3812
f1052e5d
EZ
3813 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3814 changes in globals.h immediately force recompilation.
762b15be
EZ
3815 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3816 $(CURDIR)/s/ms-w32.h.
3817 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3818
fa6996bc
EZ
3819 * character.c (Fchar_direction): Function deleted.
3820 (syms_of_character): Don't defsubr it.
3821 <char-direction-table>: Deleted.
3822
e6c3da20
EZ
38232011-04-23 Eli Zaretskii <eliz@gnu.org>
3824
3825 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3826 * doprnt.c: Include limits.h.
3827 (SIZE_MAX): New macro.
04f2d78b
CB
3828 (doprnt): Return a size_t value. 2nd arg is now size_t.
3829 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3830 Improve overflow protection. Support `l' modifier for integer
3831 conversions. Support %l conversion. Don't assume an EMACS_INT
3832 argument for integer conversions and for %c.
3833
3834 * lisp.h (doprnt): Restore prototype.
3835
3836 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3837 $(SRC)/character.h.
3838
3839 * Makefile.in (base_obj): Add back doprnt.o.
3840
3841 * deps.mk (doprnt.o): Add back prerequisites.
3842 (callint.o): Depend on character.h.
3843
3844 * eval.c (internal_lisp_condition_case): Include the handler
3845 representation in the error message.
3846 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3847 when breaking from the loop.
3848
3849 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3850
3851 * callint.c (Fcall_interactively): When displaying error message
3852 about invalid control letter, pass the character's codepoint, not
3853 a pointer to its multibyte form. Improve display of the character
3854 in octal and display also its hex code.
3855
3856 * character.c (char_string): Use %x to display the (unsigned)
3857 codepoint of an invalid character, to avoid displaying a bogus
3858 negative value.
3859
3860 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3861 `error', not SYMBOL_NAME itself.
3862
3863 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3864 character arguments to `error'.
3865
3866 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3867 to `error' in error message about FINAL_CHAR argument. Make sure
3868 FINAL_CHAR is a character, and use %c when it is passed as
3869 argument to `error'.
3870
4ffd0d6b 38712011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3872
3873 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3874
3875 * w32.c: Include <time.h>.
3876 (sys_localtime): New function.
3877
4ffd0d6b 38782011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3879
3880 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3881
4ffd0d6b 3882 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3883
4ffd0d6b 38842011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3885
4ffd0d6b
GM
3886 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3887 zombies (Bug#8467).
aac0c6e3 3888
04c56954
EZ
38892011-04-19 Eli Zaretskii <eliz@gnu.org>
3890
3891 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3892 gl_state.e_property when gl_state.object is Qt.
3893
3894 * insdel.c (make_gap_larger): Remove limitation of buffer size
3895 to <= INT_MAX.
3896
16a43933
CY
38972011-04-18 Chong Yidong <cyd@stupidchicken.com>
3898
3899 * xdisp.c (lookup_glyphless_char_display)
3900 (produce_glyphless_glyph): Handle cons cell entry in
3901 glyphless-char-display.
3902 (Vglyphless_char_display): Document it.
3903
3904 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3905 glyphless-char-display.
3906
4581706e
CY
39072011-04-17 Chong Yidong <cyd@stupidchicken.com>
3908
3909 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3910
3911 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3912
3913 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3914 definition for no-X builds.
3915
4887c6e2 39162011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3917
fd35b6f9
PE
3918 Static checks with GCC 4.6.0 and non-default toolkits.
3919
5c1ccb01
PE
3920 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3921
006c5daa
PE
3922 * process.c (keyboard_bit_set): Define only if SIGIO.
3923 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3924 (send_process): Repair possible setjmp clobbering.
3925
efc736d3
PE
3926 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3927
4e2fe2e6
PE
3928 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3929
f97334a2
PE
3930 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3931
4e75f29d
PE
3932 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3933 Define only if needed.
3934
90efadd1
PE
3935 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3936 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3937 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3938
3c647824
PE
3939 * dispextern.h (struct redisplay_interface): Rename param
3940 to avoid shadowing.
e264f262 3941 * termhooks.h (struct terminal): Likewise.
761383f4 3942 * xterm.c (xembed_send_message): Likewise.
3c647824 3943
b58c5c4a
PE
3944 * insdel.c (make_gap_smaller): Define only if
3945 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3946
cad59032
PE
3947 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3948 it.
3949
c339dc2e
PE
3950 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3951 so that we aren't warned about unused symbols.
3952
91a3e27b
PE
3953 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3954
399c71d3 3955 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3956
8ffc96f5
PE
3957 * xfns.c (x_real_positions): Mark locals as initialized.
3958
eef9bc79
PE
3959 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3960
098db9dd
PE
3961 * xterm.c: Fix problems found by static analysis with other toolkits.
3962 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3963 (x_dispatch_event): Declare static if USE_GTK, and
3964 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3965 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3966 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3967 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3968 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3969
eb18f6cc
PE
3970 * xmenu.c (menu_help_callback): Pointer type fixes.
3971 Use const pointers when pointing at readonly data. Avoid pointer
3972 signedness clashes.
3973 (FALSE): Remove unused macro.
3974 (update_frame_menubar): Remove unused decl.
3975
1fe72bf8
PE
3976 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3977
60d9e1db
PE
3978 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3979 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3980 (single_menu_item): Rename local to avoid shadowing.
3981
39261c26
PE
3982 * keyboard.c (make_lispy_event): Remove unused local var.
3983
018c5e19
PE
3984 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3985 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3986
63d2b86e
PE
3987 * bitmaps: Change bitmaps from unsigned char back to the X11
3988 compatible char. Avoid the old compiler warnings about
3989 out-of-range initializers by using, for example, '\xab' rather
3990 than 0xab.
3991
aefd87e1
PE
3992 * xgselect.c (xgselect_initialize): Check vs interface
3993 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3994
bf501fb9
PE
3995 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3996
e9829fdf
PE
3997 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3998 to read-only memory.
3999
1086c095
PE
4000 * fns.c (vector): Remove; this old hack is no longer needed.
4001
2baccd04 4002 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4003 Remove unused var.
dde42981 4004 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4005
72391843 4006 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4007
436c16df 4008 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4009 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4010 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4011
92bb796d 4012 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4013 (x_term_init): Remove local to avoid shadowing.
92bb796d 4014
764430a3 4015 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4016
4017 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4018 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4019
d1dfb56c
EZ
40202011-04-16 Eli Zaretskii <eliz@gnu.org>
4021
c4354cb4
EZ
4022 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4023
d1dfb56c
EZ
4024 Fix regex.c, syntax.c and friends for buffers > 2GB.
4025 * syntax.h (struct gl_state_s): Declare character position members
4026 EMACS_INT.
4027
4028 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4029
04f2d78b
CB
4030 * textprop.c (verify_interval_modification, interval_of):
4031 Declare arguments EMACS_INT.
d1dfb56c
EZ
4032
4033 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4034 EMACS_INT.
4035
4036 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4037
4038 * indent.c (Fvertical_motion): Local variable it_start is now
4039 EMACS_INT.
4040
4041 * regex.c (re_match, re_match_2, re_match_2_internal)
4042 (bcmp_translate, regcomp, regexec, print_double_string)
4043 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4044 (re_compile_pattern, re_exec): Declare arguments and local
4045 variables `size_t' and `ssize_t' and return values `regoff_t', as
4046 appropriate.
4047 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4048 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4049 <compile_stack_type>: `size' and `avail' are now `size_t'.
4050
4051 * regex.h <regoff_t>: Use ssize_t, not int.
4052 (re_search, re_search_2, re_match, re_match_2): Arguments that
4053 specify buffer/string position and length are now ssize_t and
4054 size_t. Return type is regoff_t.
4055
613052cd
BK
40562011-04-16 Ben Key <bkey76@gmail.com>
4057
4058 * nsfont.m: Fixed bugs in ns_get_family and
4059 ns_descriptor_to_entity that were caused by using free to
4060 deallocate memory blocks that were allocated by xmalloc (via
4061 xstrdup). This caused Emacs to crash when compiled with
4062 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4063 --enable-checking=xmallocoverrun). xfree is now used to
4064 deallocate these memory blocks.
4065
4170f62f 40662011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4067
71b41406
PE
4068 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4069
9587a89d
PE
4070 emacs_write: Accept and return EMACS_INT for sizes.
4071 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4072 et seq.
4073 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4074 Accept and return EMACS_INT.
4075 (emacs_gnutls_write): Return the number of bytes written on
4076 partial writes.
4077 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4078 (emacs_read, emacs_write): Remove check for negative size, as the
4079 Emacs source code has been audited now.
9587a89d
PE
4080 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4081 (emacs_read, emacs_write): Use it.
273a5f82
PE
4082 * process.c (send_process): Adjust to the new signatures of
4083 emacs_write and emacs_gnutls_write. Do not attempt to store
4084 a byte offset into an 'int'; it might overflow.
9587a89d 4085 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4086
3e047f51
PE
4087 * sound.c: Don't assume sizes fit in 'int'.
4088 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4089 Return EMACS_INT, not int.
3e047f51 4090 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4091 Accept EMACS_INT, not int.
4092 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4093 record read return values.
4094
cc39a9db
BK
40952011-04-15 Ben Key <bkey76@gmail.com>
4096
c9d0ec6d
JB
4097 * keyboard.c (Qundefined): Don't declare static since it is used
4098 in nsfns.m.
4099 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4100 static since they are used in nsfont.m.
cc39a9db 4101
6c60eb9f
SM
41022011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4103
4104 * process.c (Qprocessp): Don't declare static.
4105 * lisp.h (Qprocessp): Declare again.
4106
7990b61a
JB
41072011-04-15 Juanma Barranquero <lekktu@gmail.com>
4108
4109 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4110
5d4cb038
PE
41112011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4112
8bd7b830 4113 Improve C-level modularity by making more things 'static'.
cd64ea1d 4114
e3b27b31
PE
4115 Don't publish debugger-only interfaces to other modules.
4116 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4117 (verify_bytepos, count_markers): Move decls to the only modules
4118 that need them.
4119 * region-cache.h (pp_cache): Likewise.
4120 * window.h (check_all_windows): Likewise.
4121 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4122
5d4cb038
PE
4123 * sysdep.c (croak): Now static, if
4124 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4125 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4126
4127 * alloc.c (refill_memory_reserve): Now static if
4128 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4129 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4130
e87b6180
PE
4131 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4132 Define only if USE_LUCID.
4133
ac64929e
PE
4134 * xrdb.c (x_customization_string, x_rm_string): Now static.
4135
6f37259d
PE
4136 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4137 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4138
1683e3ab
PE
4139 * xdisp.c (draw_row_with_mouse_face): Now static.
4140 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4141
de9c2632
PE
4142 * window.h (check_all_windows): Mark externally visible.
4143
2b96acb7
PE
4144 * window.c (window_deletion_count): Now static.
4145
4146 * undo.c: Make symbols static if they're not exported.
4147 (last_undo_buffer, last_boundary_position, pending_boundary):
4148 Now static.
4149
50436f33
PE
4150 * textprop.c (interval_insert_behind_hooks): Now static.
4151 (interval_insert_in_front_hooks): Likewise.
4152
64520e5c
PE
4153 * term.c: Make symbols static if they're not exported.
4154 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4155 (max_frame_lines, tty_set_terminal_modes):
4156 (tty_reset_terminal_modes, tty_turn_off_highlight):
4157 (get_tty_terminal): Now static.
4158 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4159 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4160 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4161 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4162 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4163
1fa53021
PE
4164 * sysdep.c: Make symbols static if they're not exported.
4165 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4166 Now static.
4167 (sigprocmask_set, full_mask): Remove; unused.
4168 (wait_debugging): Mark as visible.
4169 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4170 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4171
d4b43b22
PE
4172 * syntax.c (syntax_temp): Define only if !__GNUC__.
4173
b7c513d0
PE
4174 * sound.c (current_sound_device, current_sound): Now static.
4175
989b29ad
PE
4176 * search.c (searchbufs, searchbuf_head): Now static.
4177
13a55a78
PE
4178 * scroll.c (scroll_cost): Remove; unused.
4179 * dispextern.h (scroll_cost): Remove decl.
4180
de68a1fc
PE
4181 * region-cache.h (pp_cache): Mark as externally visible.
4182
40ccffa6
PE
4183 * process.c: Make symbols static if they're not exported.
4184 (process_tick, update_tick, create_process, chan_process):
4185 (Vprocess_alist, proc_buffered_char, datagram_access):
4186 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4187 (deactivate_process): Mark defn as static, as well as decl.
4188 * lisp.h (create_process): Remove decl.
4189 * process.h (chan_process, Vprocess_alist): Remove decls.
4190
ad64fc97
PE
4191 * print.c: Make symbols static if they're not exported.
4192 (print_depth, new_backquote_output, being_printed, print_buffer):
4193 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4194 (print_interval, print_number_index, initial_stderr_stream):
4195 Now static.
4196 * lisp.h (Fprinc): Remove decl.
4197 (debug_output_compilation_hack): Mark as externally visible.
4198
adddb265
PE
4199 * sysdep.c (croak): Move decl from here to syssignal.h.
4200 * syssignal.h (croak): Put it here, so the API can be checked when
4201 'croak' is called from dissociate_if_controlling_tty.
4202
1717ede2
PE
4203 * minibuf.c: Make symbols static if they're not exported.
4204 (minibuf_save_list, choose_minibuf_frame): Now static.
4205 * lisp.h (choose_minibuf_frame): Remove decl.
4206
fa5fb2bc
PE
4207 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4208
1e3890d1
PE
4209 * lread.c: Make symbols static if they're not exported.
4210 (read_objects, initial_obarray, oblookup_last_bucket_number):
4211 Now static.
4212 (make_symbol): Remove; unused.
4213 * lisp.h (initial_obarray, make_symbol): Remove decls.
4214
8a1414fa
PE
4215 * keyboard.c: Make symbols static if they're not exported.
4216 (single_kboard, recent_keys_index, total_keys, recent_keys):
4217 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4218 (this_single_command_key_start, echoing, last_auto_save):
4219 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4220 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4221 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4222 (Vlispy_mouse_stem, double_click_count):
4223 Now static.
4224 (force_auto_save_soon): Define only if SIGDANGER.
4225 (ignore_mouse_drag_p): Now static if
4226 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4227 (print_help): Remove; unused.
4228 (stop_character, last_timer_event): Mark as externally visible.
4229 * keyboard.h (ignore_mouse_drag_p): Declare only if
4230 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4231 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4232 * lisp.h (echoing): Remove decl.
4233 (force_auto_save_soon): Declare only if SIGDANGER.
4234 * xdisp.c (redisplay_window): Simplify code, to make it more
4235 obvious that ignore_mouse_drag_p is not accessed if !defined
4236 USE_GTK && !defined HAVE_NS.
4237
93ea6e8f
PE
4238 * intervals.c: Make symbols static if they're not exported.
4239 (merge_properties_sticky, merge_interval_right, delete_interval):
4240 Now static.
4241 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4242
77382fcc
PE
4243 * insdel.c: Make symbols static if they're not exported.
4244 However, leave prepare_to_modify_buffer alone. It's never
4245 called from outside this function, but that appears to be a bug.
4246 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4247 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4248 (adjust_after_replace_noundo): Remove; unused.
4249 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4250 (signal_before_change): Remove decls.
77382fcc 4251
9306c32e
PE
4252 * indent.c (val_compute_motion, val_vmotion): Now static.
4253
cd44d2eb
PE
4254 * image.c: Make symbols static if they're not exported.
4255 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4256 if USE_GTK.
4257 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4258 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4259
ad9a7a06
PE
4260 * fringe.c (standard_bitmaps): Now static.
4261 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4262
81626931
PE
4263 * frame.c: Make symbols static if they're not exported.
4264 (x_report_frame_params, make_terminal_frame): Now static.
4265 (get_frame_param): Now static, unless HAVE_NS.
4266 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4267 (x_get_resource_string): Remove; not used.
4268 * frame.h (make_terminal_frame, x_report_frame_params):
4269 (x_get_resource_string); Remove decls.
4270 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4271 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4272
239f9db9
PE
4273 * font.c, fontset.c: Make symbols static if they're not exported.
4274 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4275 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4276 * font.c (font_close_object): Now static.
4277 * font.h (font_close_object): Remove.
4278 * fontset.c (FONTSET_OBJLIST): Remove.
4279 (free_realized_fontset) #if-0 the body, which does nothing.
4280 (face_suitable_for_char_p): #if-0, as it's never called.
4281 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4282 * xfaces.c (face_at_string_position):
4283 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4284 since 0 is always ASCII.
4285
dfcf3579
PE
4286 * fns.c (weak_hash_tables): Now static.
4287
5045092b
PE
4288 * fileio.c: Make symbols static if they're not exported.
4289 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4290 (Vwrite_region_annotation_buffers): Now static.
4291
57a96f5c
PE
4292 * eval.c: Make symbols static if they're not exported.
4293 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4294 * lisp.h (backtrace_list): Remove decl.
4295
35f08c38
PE
4296 * emacs.c: Make symbols static if they're not exported.
4297 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4298 (fatal_error_code, fatal_error_signal_hook, standard_args):
4299 Now static.
4300 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4301 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4302 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4303 * lisp.h (fatal_error_signal_hook): Remove decl.
4304 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4305
f44bd759
PE
4306 * editfns.c: Move a (normally-unused) function to its only use.
4307 * editfns.c, lisp.h (get_operating_system_release): Remove.
4308 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4309 worth the hassle of breaking this out.
4310
b532497d
PE
4311 * xterm.c: Make symbols static if they're not exported.
4312 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4313 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4314 (x_destroy_window, x_delete_display):
4315 Now static.
4316 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4317 (x_mouse_leave): Remove; unused.
4318 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4319 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4320 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4321 Remove decls.
4322 (x_mouse_leave): Declare only if WINDOWSNT.
4323 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4324 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4325 USE_X_TOOLKIT.
4326
1675728f
PE
4327 * ftxfont.c: Make symbols static if they're not exported.
4328 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4329 HAVE_FREETYPE.
4330 * font.h (ftxfont_driver): Likewise.
4331
e4cebfca
PE
4332 * xfns.c: Make symbols static if they're not exported.
4333 (x_last_font_name, x_display_info_for_name):
4334 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4335 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4336 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4337 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4338 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4339 (last_show_tip_args): Now static.
4340 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4341 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4342 (x_screen_planes): Remove; unused.
4343 * dispextern.h (x_screen_planes): Remove decl.
4344
5bf46f05
PE
4345 * dispnew.c: Make symbols static if they're not exported.
4346 * dispextern.h (redraw_garbaged_frames, scrolling):
4347 (increment_row_positions): Remove.
4348 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4349 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4350 Now static.
4351 (redraw_garbaged_frames): Remove; unused.
4352
435f4c28
PE
4353 * xfaces.c: Make symbols static if they're not exported.
4354 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4355 Remove decls.
4356 * xterm.h (defined_color): Remove decls.
4357 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4358 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4359 (menu_face_changed_default, defined_color, free_realized_face):
4360 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4361 (ascii_face_of_lisp_face): Remove; unused.
4362
8524aef3
PE
4363 * xdisp.c: Make symbols static if they're not exported.
4364 * dispextern.h (scratch_glyph_row, window_box_edges):
4365 (glyph_to_pixel_coords, set_cursor_from_row):
4366 (get_next_display_element, set_iterator_to_next):
4367 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4368 (show_mouse_face): Remove decls
4369 * frame.h (message_buf_print): Likewise.
4370 * lisp.h (pop_message, set_message, check_point_in_composition):
4371 Likewise.
4372 * xterm.h (set_vertical_scroll_bar): Likewise.
4373 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4374 (message_buf_print, scratch_glyph_row, displayed_buffer):
4375 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4376 (get_next_display_element, show_mouse_face, window_box_edges):
4377 (frame_to_window_pixel_xy, check_point_in_composition):
4378 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4379 (glyph_to_pixel_coords): Remove; unused.
4380
16390cd2
PE
4381 * dired.c (file_name_completion): Now static.
4382
4383 * dbusbind.c (xd_in_read_queued_messages): Now static.
4384
a25f4dfa
PE
4385 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4386 * data.c (circular_list_error): Remove.
4387
14a9c8df
PE
4388 * commands.h (last_point_position, last_point_position_buffer):
4389 (last_point_position_window): Remove decls.
4390 * keyboard.c: Make these variables static.
4391
04f2d78b
CB
4392 * coding.h (coding, code_convert_region, encode_coding_gap):
4393 Remove decls.
74ab6df5
PE
4394 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4395 (iso_code_class, detect_coding, code_convert_region): Now static.
4396 (encode_coding_gap): Remove; unused.
4397
38dfbee1
PE
4398 * chartab.c (chartab_chars, chartab_bits): Now static.
4399
a2cb4e63
PE
4400 * charset.h (charset_iso_8859_1): Remove decl.
4401 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4402 Now static.
4403
127198fd
PE
4404 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4405 * ccl.c (Vccl_program_table): Now static.
4406 (check_ccl_update): Remove; unused.
4407
d85b608f
PE
4408 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4409 * category.h: ... from here.
4410 * category.c (check_category_table, set_category_set): Now static.
4411
31cd66f3
PE
4412 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4413 * lisp.h: Remove these decls.
4414
c358e587
PE
4415 * buffer.c (buffer_count): Remove unused var.
4416
e78aecca
PE
4417 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4418 so that it's not optimized away.
4419 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4420 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4421 exported only to the debugger.
4422
e192d7d3 4423 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4424 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4425
92470028
PE
4426 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4427 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4428 was inaccessible from Lisp.
4429 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4430 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4431
244ed907
PE
4432 alloc.c: Import and export fewer symbols, and remove unused items.
4433 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4434 is defined.
4435 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4436 it's not optimized away by whole-program optimization.
4437 (message_enable_multibyte, free_misc): Remove.
4438 (catchlist, handlerlist, mark_backtrace):
4439 Declare only if BYTE_MARK_STACK.
4440 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4441 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4442 (message_enable_multibyte): Remove decl.
4443 (free_misc, interval_free_list, float_block, float_block_index):
4444 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4445 (cons_free_list, last_marked_index):
4446 Now static.
4447 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4448 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4449 (mark_backtrace): Define only if BYTE_MARK_STACK.
4450 * xdisp.c (message_enable_multibyte): Now static.
4451
61c2b50e 4452 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4453 This makes it easier for human readers (and static analyzers)
4454 to see whether these variables are used from other modules.
4455 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4456 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4457 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4458 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4459 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4460 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4461 * xmenu.c, xselect.c:
4462 Declare Q* vars static if they are not used in other modules.
4463 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4464 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4465 Remove decls of unexported vars.
4466 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4467
95c82688
PE
4468 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4469
16a97296
PE
4470 Make Emacs functions such as Fatom 'static' by default.
4471 This makes it easier for human readers (and static analyzers)
4472 to see whether these functions can be called from other modules.
4473 DEFUN now defines a static function. To make the function external
4474 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4475 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4476 (Finit_image_library):
16a97296
PE
4477 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4478 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4479 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4480 Remove decls, since these functions are now static.
4481 (Funintern, Fget_internal_run_time): New decls, since these functions
4482 were already external.
95c82688 4483
16a97296
PE
4484 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4485 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4486 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4487 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4488 * keyboard.c, keymap.c, lread.c:
4489 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4490 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4491 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4492 Mark functions with DEFUE instead of DEFUN,
4493 if they are used in other modules.
4494 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4495 decls for now-static functions.
4496 * buffer.h (Fdelete_overlay): Remove decl.
4497 * callproc.c (Fgetenv_internal): Mark as internal.
4498 * composite.c (Fremove_list_of_text_properties): Remove decl.
4499 (Fcomposition_get_gstring): New forward static decl.
4500 * composite.h (Fcomposite_get_gstring): Remove decl.
4501 * dired.c (Ffile_attributes): New forward static decl.
4502 * doc.c (Fdocumntation_property): New forward static decl.
4503 * eval.c (Ffetch_bytecode): New forward static decl.
4504 (Funintern): Remove extern decl; now in .h file where it belongs.
4505 * fileio.c (Fmake_symbolic_link): New forward static decl.
4506 * image.c (Finit_image_library): New forward static decl.
4507 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4508 * intervals.h (Fprevious_property_change):
4509 (Fremove_list_of_text_properties): Remove decls.
4510 * keyboard.c (Fthis_command_keys): Remove decl.
4511 (Fcommand_execute): New forward static decl.
4512 * keymap.c (Flookup_key): New forward static decl.
4513 (Fcopy_keymap): Now static.
4514 * keymap.h (Flookup_key): Remove decl.
4515 * process.c (Fget_process): New forward static decl.
4516 (Fprocess_datagram_address): Mark as internal.
4517 * syntax.c (Fsyntax_table_p): New forward static decl.
4518 (skip_chars): Remove duplicate decl.
4519 * textprop.c (Fprevious_property_change): New forward static decl.
4520 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4521 Now internal.
4522 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4523 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4524
785bbd42
PE
4525 * editfns.c (Fformat): Remove unreachable code.
4526
8b913b57
AS
45272011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4528
4529 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4530 change. (Bug#8496)
4531
a6744a35
EZ
45322011-04-13 Eli Zaretskii <eliz@gnu.org>
4533
4534 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4535 when at ZV. (Bug#8487)
4536
e7974947
AS
45372011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4538
baad03f0
AS
4539 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4540 (Bug#8437)
4541 * keyboard.c (parse_tool_bar_item): Likewise.
4542 * sound.c (sound_cleanup, alsa_close): Likewise.
4543 * termcap.c (tgetent): Likewise.
4544 * xfns.c (x_default_font_parameter): Likewise.
4545 * xsettings.c (read_and_apply_settings): Likewise.
4546
e7974947
AS
4547 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4548 (overrun_check_free): Protoize.
4549
28272684
PE
45502011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4551
4552 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4553 since callers should never pass a negative size.
4554 Change the signature to match that of plain 'read' and 'write'; see
4555 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4556 * lisp.h: Update prototypes of emacs_write and emacs_read.
4557
11997c76
EZ
45582011-04-11 Eli Zaretskii <eliz@gnu.org>
4559
4560 * xdisp.c (redisplay_window): Don't try to determine the character
4561 position of the scroll margin if the window start point w->startp
e896f03c 4562 is outside the buffer's accessible region. (Bug#8468)
11997c76 4563
8a2cbd72
EZ
45642011-04-10 Eli Zaretskii <eliz@gnu.org>
4565
4566 Fix write-region and its subroutines for buffers > 2GB.
4567 * fileio.c (a_write, e_write): Modify declaration of arguments and
4568 local variables to support buffers larger than 2GB.
4569 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4570
4571 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4572 argument, local variables, and return value.
4573
4574 * lisp.h: Update prototypes of emacs_write and emacs_read.
4575
4576 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4577
4073e537 45782011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4579
1ebfdcb6
PE
4580 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4581
b2ded58d
PE
4582 Fix more problems found by GCC 4.6.0's static checks.
4583
7d66342c
PE
4584 * xdisp.c (vmessage): Use a better test for character truncation.
4585
bbf47d44
PE
4586 * charset.c (load_charset_map): <, not <=, for optimization,
4587 and to avoid potential problems with integer overflow.
9248994d 4588 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4589 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4590 * editfns.c (Fformat): Likewise.
1e69125e 4591 * syntax.c (skip_chars): Likewise.
3befa583 4592
e3019616
PE
4593 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4594 This also lets GCC 4.6.0 generate slightly better loop code.
4595
becfa255
PE
4596 * callint.c (Fcall_interactively): <, not <=, for optimization.
4597 (Fcall_interactively): Count the number of arguments produced,
4598 not the number of arguments given. This is simpler and lets GCC
4599 4.6.0 generate slightly better code.
4600
dae0cd48
PE
4601 * ftfont.c: Distingish more carefully between FcChar8 and char.
4602 The previous code passed unsigned char * to a functions like
4603 strlen and xstrcasecmp that expect char *, which does not
4604 conform to the C standard.
4605 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4606 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4607 char * when the C standard requires it.
4608
76032d70
PE
4609 * keyboard.c (read_char): Remove unused var.
4610
eb3f1cc8
PE
4611 * eval.c: Port to Windows vsnprintf (Bug#8435).
4612 Include <limits.h>.
4613 (SIZE_MAX): Define if the headers do not.
4614 (verror): Do not give up if vsnprintf returns a negative count.
4615 Instead, grow the buffer. This ports to Windows vsnprintf, which
4616 does not conform to C99. Problem reported by Eli Zaretskii.
4617 Also, simplify the allocation scheme, by avoiding the need for
4618 calling realloc, and removing the ALLOCATED variable.
4619
70476b54
PE
4620 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4621
12020a9e
PE
4622 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4623 But keep the doprint source code for now, as we might revamp it
4624 and use it again (Bug#8435).
ea6c7ae6
PE
4625 * lisp.h (doprnt): Remove.
4626 * Makefile.in (base_obj): Remove doprnt.o.
4627 * deps.mk (doprnt.o): Remove.
4628
5fdb398c
PE
4629 error: Print 32- and 64-bit integers portably (Bug#8435).
4630 Without this change, on typical 64-bit hosts error ("...%d...", N)
4631 was used to print both 32- and 64-bit integers N, which relied on
4632 undefined behavior.
4633 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4634 New macro.
4635 * lisp.h (error, verror): Mark as printf-like functions.
4636 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4637 Report overflow in size calculations when allocating printf buffer.
4638 Do not truncate output string at its first null byte.
4639 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4640 Truncate the output at a character boundary, since vsnprintf does not
4641 do that.
4642 * charset.c (check_iso_charset_parameter): Convert internal
4643 character to string before calling 'error', since %c now has the
4644 printf meaning.
4645 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4646 overflow when computing char to be passed to 'error'. Do not
4647 pass Lisp_Object to 'error'; pass the integer instead.
4648 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4649 formatted with plain %d.
4650
b189fa66
PE
4651 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4652
bff87ef0
PE
4653 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4654
7e2cac20
PE
4655 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4656
ce4d90b5
PE
4657 * xterm.c (x_catch_errors): Remove duplicate declaration.
4658
266c9547
PE
4659 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4660
79c49ad2
PE
4661 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4662
368f4090
JM
46632011-04-10 Jim Meyering <meyering@redhat.com>
4664
4665 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4666 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4667 return ssize_t not "int", and use size_t as the buffer length.
4668 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4669 * gnutls.h: Update declarations.
4670 * process.c (read_process_output): Use ssize_t, to match.
4671 (send_process): Likewise.
4672
a32d4040
CY
46732011-04-09 Chong Yidong <cyd@stupidchicken.com>
4674
4675 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4676
8546720e 46772011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4678
04f2d78b
CB
4679 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4680 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4681
8546720e
GM
4682 * xterm.c (handle_one_xevent):
4683 * xmenu.c (create_and_show_popup_menu):
4684 * xselect.c (x_decline_selection_request)
4685 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4686
0a2f5c1a 46872011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4688
4689 Fix some uses of `int' instead of EMACS_INT.
4690 * search.c (string_match_1, fast_string_match)
4691 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4692 (scan_buffer, find_next_newline_no_quit)
4693 (find_before_next_newline, search_command, Freplace_match)
4694 (Fmatch_data): Make some `int' variables be EMACS_INT.
4695
4696 * xdisp.c (display_count_lines): 3rd argument and return value now
4697 EMACS_INT. All callers changed.
4698 (pint2hrstr): Last argument is now EMACS_INT.
4699
4700 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4701 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4702 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4703 (decode_coding_utf_16, decode_coding_emacs_mule)
4704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4705 (decode_coding_ccl, decode_coding_charset)
4706 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4707 (decode_coding_iso_2022, decode_coding_emacs_mule)
4708 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4709 <char_offset, last_offset>: Declare EMACS_INT.
4710 (encode_coding_utf_8, encode_coding_utf_16)
4711 (encode_coding_emacs_mule, encode_invocation_designation)
4712 (encode_designation_at_bol, encode_coding_iso_2022)
4713 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4714 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4715 Declare EMACS_INT.
4716 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4717 (encode_invocation_designation): Last argument P_NCHARS is now
4718 EMACS_INT.
4719 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4720 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4721
4722 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4723 All users changed.
4724
4725 * ccl.c (Fccl_execute_on_string): Declare some variables
4726 EMACS_INT.
4727
8546720e 47282011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4729
4730 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4731
4e19a977
CS
47322011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4733
4734 * process.c (Fformat_network_address): Doc fix.
4735
87302331
R
47362011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4737
4738 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4739
cbb59342
CY
47402011-04-08 Chong Yidong <cyd@stupidchicken.com>
4741
4742 * keyboard.c (read_char): Call Lisp function help-form-show,
4743 instead of using internal_with_output_to_temp_buffer.
4744 (Qhelp_form_show): New var.
e0d38eeb 4745 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4746
4747 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4748
4749 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4750
e67a13ab
CY
47512011-04-06 Chong Yidong <cyd@stupidchicken.com>
4752
04f2d78b
CB
4753 * process.c (Flist_processes): Remove to Lisp.
4754 (list_processes_1): Delete.
e67a13ab 4755
973f782d
EZ
47562011-04-06 Eli Zaretskii <eliz@gnu.org>
4757
7c106b1e
EZ
4758 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4759
973f782d
EZ
4760 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4761
41cf7d1a 47622011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4763
ca23cc88
PE
4764 Fix more problems found by GCC 4.6.0's static checks.
4765
f390e2d5
PE
4766 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4767
42eea0d0
PE
4768 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4769
b69769da 4770 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4771
f9541e84
PE
4772 * xdisp.c (vmessage): Mark as a printf-like function.
4773
13841b55
PE
4774 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4775
c136c10f
PE
4776 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4777
5e2d4a30
PE
4778 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4779 printf-like functions.
4780 (tiff_load): Add casts to remove these marks before passing them
4781 to system-supplied API.
4782
583f48b9
PE
4783 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4784
b25d760e
PE
4785 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4786 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4787 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4788 directly, rather than having caller test rule sign. This avoids
4789 some unnecessary tests.
4790 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4791 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4792 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4793
bc7b6697 4794 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4795 (xfont_open): Avoid unnecessary tests.
bc7b6697 4796
27ccc379
PE
4797 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4798
dcd5c89a
PE
4799 * composite.h, composite.c (composition_gstring_put_cache):
4800 Use EMACS_INT, not int, for length.
4801
b13a45c6
PE
4802 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4803 breaking out part of COMPOSITION_DECODE_RULE.
4804 (COMPOSITION_DECODE_RULE): Use it.
4805 * composite.c (get_composition_id): Remove unused local vars,
4806 by using the new macro.
4807
1e792e4d
PE
4808 * textprop.c (set_text_properties_1): Change while to do-while,
4809 since the condition is always true at first.
4810
dc6c6455 4811 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4812 (interval_deletion_adjustment): Return unsigned value.
4813 All uses changed.
dc6c6455 4814
aba7731a
PE
4815 * process.c (list_processes_1, create_pty, read_process_output):
4816 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4817 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4818 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4819 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4820 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4821
fdfc4bf3
PE
4822 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4823
fca8fe46 4824 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4825 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4826
06a0259a 4827 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4828 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4829 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4830
e7b9e80f
PE
4831 * print.c (print_error_message): Avoid int overflow.
4832
56201685
PE
4833 * font.c (font_list_entities): Redo for clarity,
4834 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4835
78834453 4836 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4837 (font_score): Avoid potential overflow in diff calculation.
78834453 4838
0bc0b309 4839 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4840 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4841
e610eaca
PE
4842 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4843
b895abce
PE
4844 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4845 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4846 can always succeed if overflow has undefined behavior.
4847
1f1d9321 4848 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4849 (wordify): Omit three unnecessary tests.
1f1d9321 4850
c59478bc
PE
4851 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4852 All callers changed. This avoids the need for an unused var.
4853
79b73827
PE
4854 * casefiddle.c (casify_region): Remove var that is set but not used.
4855
a4db5dfe
PE
4856 * dired.c (file_name_completion): Remove var that is set but not used.
4857
43aae36e
PE
4858 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4859
2a47c44d 4860 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4861 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4862
a37c69bf
PE
4863 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4864 Check for integer overflow on size calculations.
4865
328ab8e7
PE
4866 * buffer.c (Fprevious_overlay_change): Remove var that is set
4867 but not used.
4868
e5a2a5cb
PE
4869 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4870 Remove vars that are set but not used.
8d84a6eb 4871 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4872 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4873
a60e5f68
PE
4874 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4875
f661cb61 4876 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4877 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4878
f0397f5a
PE
4879 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4880 that are set but not used.
4881
8664db06 4882 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4883 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4884
6abdaa4a
PE
4885 * xselect.c (x_get_local_selection, x_handle_property_notify):
4886 Remove vars that are set but not used.
4887
0ce7538d 4888 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4889 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4890
9ae848fc
PE
4891 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4892 Remove var that is set but not used.
0b918413
PE
4893 (scroll_bar_windows_size): Now size_t, not int.
4894 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4895 Check for overflow.
9ae848fc 4896
a5a62657
PE
4897 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4898 (map_tty_color) [!defined MSDOS]: Likewise.
4899
5c5cdd39
PE
4900 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4901
66ebf983
PE
4902 * coding.c: Remove vars that are set but not used.
4903 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4904 All callers changed.
4905 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4906 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4907 (decode_coding_charset): Remove vars that are set but not used.
4908
1be4d761
PE
4909 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4910 that is set but not used.
4911
47553fa8
PE
4912 * print.c (print_object): Remove var that is set but not used.
4913
1f7196bf 4914 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4915 The gnulib version avoids calling malloc in the usual case,
4916 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4917 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4918 * filelock.c (current_lock_owner): Likewise.
4919 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4920 * sysdep.c: Include allocator.h, careadlinkat.h.
4921 (emacs_no_realloc_allocator): New static constant.
4922 (emacs_readlink): New function.
fdb61804
PE
4923 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4924 ../lib/careadlinkat.h.
d1fdcab7 4925
f84c17c7
SM
49262011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4927
4928 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4929 first non-nil return value).
4930
ef3862ad
JD
49312011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4932
4933 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4934 if not defined (Bug#8403).
4935
376a7006
JB
49362011-04-02 Juanma Barranquero <lekktu@gmail.com>
4937
4938 * xdisp.c (display_count_lines): Remove parameter `start',
4939 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4940 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4941 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4942 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4943 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4944 and thereabouts. All callers changed.
4945 (get_per_char_metric): Remove parameter `f', unused since
4946 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4947
6ca3801d
JM
49482011-04-02 Jim Meyering <meyering@redhat.com>
4949
4950 do not dereference NULL upon failed strdup
4951 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4952 (ns_get_family): Likewise.
4953
d8e2b5ba
JB
49542011-04-02 Juanma Barranquero <lekktu@gmail.com>
4955
4956 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4957
8c74fcbd
JD
49582011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4959
4960 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4961 later (Bug#8403).
4962
7200d79c
SM
49632011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4964
03408648 4965 Add lexical binding.
7200d79c 4966
03408648
SM
4967 * window.c (Ftemp_output_buffer_show): New fun.
4968 (Fsave_window_excursion):
4969 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4970
4971 * lread.c (lisp_file_lexically_bound_p): New function.
4972 (Fload): Bind Qlexical_binding.
4973 (readevalloop): Remove `evalfun' arg.
4974 Bind Qinternal_interpreter_environment.
4975 (Feval_buffer): Bind Qlexical_binding.
4976 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4977 Mark as dynamic.
4978 (syms_of_lread): Declare `lexical-binding'.
4979
4980 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4981
4982 * keyboard.c (eval_dyn): New fun.
4983 (menu_item_eval_property): Use it.
ca105506
SM
4984
4985 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4986
03408648
SM
4987 * fns.c (concat, mapcar1): Accept byte-code-functions.
4988
4989 * eval.c (Fsetq): Handle lexical vars.
4990 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4991 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4992 (FletX, Flet): Obey lexical binding.
4993 (Fcommandp): Handle closures.
4994 (Feval): New `lexical' arg.
4995 (eval_sub): New function extracted from Feval. Use it almost
4996 everywhere where Feval was used. Look up vars in lexical env.
4997 Handle closures.
4998 (Ffunctionp): Move from subr.el.
4999 (Ffuncall): Handle closures.
5000 (apply_lambda): Remove `eval_flags'.
5001 (funcall_lambda): Handle closures and new byte-code-functions.
5002 (Fspecial_variable_p): New function.
5003 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5004 but without exporting it to Lisp.
23aba0ea 5005
23aba0ea 5006 * doc.c (Fdocumentation, store_function_docstring):
03408648 5007 * data.c (Finteractive_form): Handle closures.
23aba0ea 5008
03408648
SM
5009 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5010 interactive spec.
ba83908c 5011
04f2d78b
CB
5012 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5013 New byte-codes.
03408648
SM
5014 (exec_byte_code): New function extracted from Fbyte_code to handle new
5015 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5016
03408648 5017 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5018
03408648 5019 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5020
e2abce01
JB
50212011-03-31 Juanma Barranquero <lekktu@gmail.com>
5022
5023 * xdisp.c (redisplay_internal): Fix prototype.
5024
63696a73 50252011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5026
63696a73 5027 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5028 (try_scrolling): Use it when setting scroll_limit.
5029 Limit scrolling to 100 screen lines.
63696a73
EZ
5030 (redisplay_window): Even when falling back on "recentering",
5031 position point in the window according to scroll-conservatively,
5032 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5033
5034 (try_scrolling): When point is above the window, allow searching
5035 as far as scroll_max, or one screenful, to compute vertical
5036 distance from PT to the scroll margin position. This prevents
5037 try_scrolling from unnecessarily failing when
5038 scroll-conservatively is set to a value slightly larger than the
5039 window height. Clean up the case of PT below the margin at bottom
5040 of window: scroll_max can no longer be INT_MAX. When aggressive
5041 scrolling is in use, don't let point enter the opposite scroll
5042 margin as result of the scroll.
5043 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5044 threshold of 100 lines for never-recentering scrolling.
5045
e4cc2dfc
JB
50462011-03-31 Juanma Barranquero <lekktu@gmail.com>
5047
5048 * dispextern.h (move_it_by_lines):
5049 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5050 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5051 (message_log_check_duplicate): Remove parameters `prev_bol' and
5052 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5053 (redisplay_internal): Remove parameter `preserve_echo_area',
5054 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5055
5056 * indent.c (Fvertical_motion):
5057 * window.c (window_scroll_pixel_based, Frecenter):
5058 Don't pass `need_y_p' to `move_it_by_lines'.
5059
1c470562
SM
50602011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5061
44f230aa
SM
5062 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5063 steal a few bits to be more compact.
5064 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5065 Remove unneeded casts.
5066
1c470562
SM
5067 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5068
888adce9
ZK
50692011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5070
5071 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5072 binding" message (bug#7967).
5073
f838ed7b
PE
50742011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5075
77861b95
PE
5076 Fix more problems found by GCC 4.6.0's static checks.
5077
de6dbc14
PE
5078 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5079 Remove unused local var.
5080
f838ed7b
PE
5081 * editfns.c (Fmessage_box): Remove unused local var.
5082
792c7b2b
PE
5083 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5084 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5085 Omit unused local vars.
c499e557 5086 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5087 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5088 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5089 Omit unused local var.
5090
ba0165e1
PE
5091 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5092 Don't assume string length fits in int.
32ad8845 5093 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5094 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5095
3c59b4c9
PE
5096 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5097 instead of alloca (Bug#8344).
5098
a3eed478 5099 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5100 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5101
eb4d412d
PE
5102 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5103
1658b401
PE
5104 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5105 concerns.
5106
5107 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5108
5109 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5110
9a2c6e05
PE
5111 * keyboard.c (syms_of_keyboard): Use the same style as later
5112 in this function when indexing through an array. This also
5113 works around GCC bug 48267.
5114
03d0a109
PE
5115 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5116
44f730c8
PE
5117 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5118
fe75f926
PE
5119 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5120 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5121
ffa8c828
PE
5122 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5123 This avoids undefined behavior on integer overflow, and is a bit
5124 more convenient anyway since it is compared to a size_t variable.
5125
c5101a77
PE
5126 Variadic C functions now count arguments with size_t, not int.
5127 This avoids an unnecessary limitation on 64-bit machines, which
5128 caused (substring ...) to crash on large vectors (Bug#8344).
5129 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5130 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5131 All variadic functions and their callers changed accordingly.
c5101a77
PE
5132 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5133 * data.c (arith_driver, float_arith_driver): Likewise.
5134 * editfns.c (general_insert_function): Likewise.
5135 * eval.c (struct backtrace.nargs, interactive_p)
5136 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5137 (funcall_lambda, mark_backtrace): Likewise.
5138 * fns.c (concat): Likewise.
5139 * frame.c (x_set_frame_parameters): Likewise.
5140 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5141 0 if not found, not -1. All callers changed.
5142
dd3f25f7
PE
5143 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5144 (stack_copy_size): Now size_t, not int.
5145 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5146
461c2ab9
JB
51472011-03-28 Juanma Barranquero <lekktu@gmail.com>
5148
5149 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5150 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5151 All callers changed.
5152
5153 * lisp.h (multibyte_char_to_unibyte):
5154 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5155 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5156 * character.h (CHAR_TO_BYTE8):
5157 * cmds.c (internal_self_insert):
5158 * editfns.c (general_insert_function):
5159 * keymap.c (push_key_description):
5160 * search.c (Freplace_match):
5161 * xdisp.c (message_dolog, set_message_1): All callers changed.
5162
f6d62986
SM
51632011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5164
5165 * keyboard.c (safe_run_hook_funcall): New function.
5166 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5167 don't set the hook to nil, but remove the offending function instead.
5168 (Qcommand_hook_internal): Remove, unused.
5169 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5170 Vcommand_hook_internal.
5171
5172 * eval.c (enum run_hooks_condition): Remove.
5173 (funcall_nil, funcall_not): New functions.
5174 (run_hook_with_args): Call each function through a `funcall' argument.
5175 Remove `cond' argument, now redundant.
5176 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5177 (Frun_hook_with_args_until_failure): Adjust accordingly.
5178 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5179
1db5b1ad
JB
51802011-03-28 Juanma Barranquero <lekktu@gmail.com>
5181
5182 * dispextern.h (string_buffer_position): Remove declaration.
5183
5184 * print.c (strout): Remove parameter `multibyte', unused since
5185 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5186
5187 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5188 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5189 All callers changed.
5190
5191 * w32.c (_wsa_errlist): Use braces for struct initializers.
5192
5193 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5194 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5195 All callers changed.
5196 (string_buffer_position): Likewise. Also, make static (it's never
5197 used outside xdisp.c).
5198 (cursor_row_p): Remove parameter `w', unused since
5199 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5200 (decode_mode_spec): Remove parameter `precision', introduced during
5201 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5202 All callers changed.
5203
5ffb62aa
JD
52042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5205
5206 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5207
461c2ab9 52082011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5209
5210 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5211 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5212 (ns_update_auto_hide_menu_bar): New functions.
5213 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5214 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5215 ns_constrain_all_frames.
5216 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5217 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5218
5c380ffb
JD
52192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5220
5221 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5222
9af30bdf
GM
52232011-03-27 Glenn Morris <rgm@gnu.org>
5224
5225 * syssignal.h: Replace RETSIGTYPE with void.
5226 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5227 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5228 Replace SIGTYPE with void everywhere.
5229 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5230 * s/template.h (SIGTYPE): Remove commented out definition.
5231
e2abce01
JB
52322011-03-26 Eli Zaretskii <eliz@gnu.org>
5233
5234 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5235 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5236
f868cd8a
JB
52372011-03-26 Juanma Barranquero <lekktu@gmail.com>
5238
59eb0929
JB
5239 * w32.c (read_unc_volume): Use parameter `henum', instead of
5240 global variable `wget_enum_handle'.
5241
5242 * keymap.c (describe_vector): Remove parameters `indices' and
5243 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5244 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5245
f868cd8a
JB
5246 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5247
5248 * keyboard.c (timer_check): Remove parameter `do_it_now',
5249 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5250 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5251 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5252
5253 * keyboard.c (read_char):
5254 * w32menu.c (w32_menu_display_help):
5255 * xmenu.c (show_help_event, menu_help_callback):
5256 Adjust calls to `show_help_echo'.
5257
5258 * gtkutil.c (xg_maybe_add_timer):
5259 * keyboard.c (readable_events):
5260 * process.c (wait_reading_process_output):
5261 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5262
5263 * insdel.c (adjust_markers_gap_motion):
5264 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5265 (gap_left, gap_right): Don't call it.
5266
2ecf6fdb
CY
52672011-03-25 Chong Yidong <cyd@stupidchicken.com>
5268
5269 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5270 incurred during fontification.
5271
6b1f9ba4
JB
52722011-03-25 Juanma Barranquero <lekktu@gmail.com>
5273
5274 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5275 (DEFVAR_PER_BUFFER): Don't pass it.
5276
5277 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5278 (scrolling_window): Don't pass it.
5279
0f4a96b5
JB
52802011-03-25 Juanma Barranquero <lekktu@gmail.com>
5281
5282 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5283
5284 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5285 and `suffix'.
5286 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5287 of variables specific to SELinux and computation of `encoded_absname'.
5288
5289 * image.c (XPutPixel): Remove unused variable `height'.
5290
5291 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5292
5293 * unexw32.c (get_section_info): Remove unused variable `section'.
5294
5295 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5296 (system_process_attributes): Remove unused variable `sess'.
5297 (sys_read): Remove unused variable `err'.
5298
5299 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5300 (w32_wnd_proc): Remove unused variable `isdead'.
5301 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5302 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5303 (x_create_tip_frame): Remove unused variable `tem'.
5304
5305 * w32inevt.c (w32_console_read_socket):
5306 Remove unused variable `no_events'.
5307
5308 * w32term.c (x_draw_composite_glyph_string_foreground):
5309 Remove unused variable `width'.
5310
1149507c
JB
53112011-03-24 Juanma Barranquero <lekktu@gmail.com>
5312
5313 * w32term.c (x_set_glyph_string_clipping):
5314 Don't pass uninitialized region to CombineRgn.
5315
9c88f339
JB
53162011-03-23 Juanma Barranquero <lekktu@gmail.com>
5317
5318 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5319 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5320 (Fx_close_connection): Remove unused variable `i'.
5321
5322 * w32font.c (w32font_draw): Return number of glyphs.
5323 (w32font_open_internal): Remove unused variable `i'.
5324 (w32font_driver): Add missing initializer.
5325
5326 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5327 (fill_in_menu): Remove unused variable `items_added'.
5328
5329 * w32term.c (last_mouse_press_frame): Remove static global variable.
5330 (w32_clip_to_row): Remove unused variable `f'.
5331 (x_delete_terminal): Remove unused variable `i'.
5332
5333 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5334 (NOTHING): Remove unused static global variable.
5335 (uniscribe_check_otf): Remove unused variable `table'.
5336 (uniscribe_font_driver): Add missing initializers.
5337
dee091a3
JD
53382011-03-23 Julien Danjou <julien@danjou.info>
5339
5340 * term.c (Fsuspend_tty, Fresume_tty):
5341 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5342 * window.c (temp_output_buffer_show):
5343 * insdel.c (signal_before_change):
5344 * frame.c (Fhandle_switch_frame):
5345 * fileio.c (Fdo_auto_save):
5346 * emacs.c (Fkill_emacs):
5347 * editfns.c (save_excursion_restore):
5348 * cmds.c (internal_self_insert):
5349 * callint.c (Fcall_interactively):
5350 * buffer.c (Fkill_all_local_variables):
5351 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5352 Use Frun_hooks.
0f4a96b5 5353 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5354 unconditionnaly since it does the check itself.
5355
2c520ab5 53562011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5357
c9c49752
PE
5358 Fix more problems found by GCC 4.5.2's static checks.
5359
8abc3f12
PE
5360 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5361 the first time through the loop, since we know p0 < p1 then.
5362 This also avoids a gcc -Wstrict-overflow warning.
5363
a2d26660
PE
5364 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5365 leading to a memory leak, possible in functions like
5366 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5367 of objects (Bug#8318).
a2d26660 5368
916c72e9
PE
5369 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5370 that could (at least in theory) be that large.
5371
19ab8a18
PE
5372 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5373 This is less likely to overflow, and avoids undefined behavior if
5374 overflow does occur. All callers changed. Use strtoul to scan
5375 for the unsigned long integer.
b7cbbd6f
PE
5376 (pint2hrstr): Simplify and tune code slightly.
5377 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5378
f0641eff
PE
5379 * scroll.c (do_scrolling): Work around GCC bug 48228.
5380 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5381
7f650bb9
PE
5382 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5383 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5384 (validate_x_resource_name): Simplify count usage.
5385 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5386
37dd57d1
PE
5387 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5388 fail (Bug#8306).
81e56e61 5389
699979fc 5390 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5391
401bf9b4
PE
5392 * process.c (Fmake_network_process): Use socklen_t, not int,
5393 where POSIX says socklen_t is required in portable programs.
5394 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5395 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5396 (Fmake_network_process, server_accept_connection):
5397 (wait_reading_process_output, read_process_output):
5398 Likewise.
5399
b93aacde
PE
5400 * process.c: Rename or move locals to avoid shadowing.
5401 (list_processes_1, Fmake_network_process):
5402 (read_process_output_error_handler, exec_sentinel_error_handler):
5403 Rename or move locals.
4dc343ee 5404 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5405 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5406 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5407 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5408 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5409
af8a867c 5410 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5411 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5412 Include tparam.h instead, since it declares them.
af8a867c
PE
5413 * cm.h (PC): Remove extern decl; tparam.h now does this.
5414 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5415 * terminfo.c: Include tparam.h, to check interfaces.
5416 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5417 (tparam): Adjust signature to match interface in tparam.h;
5418 this removes some undefined behavior. Check that outstring and len
5419 are zero, which they always are with Emacs.
5420 * tparam.h (PC, BC, UP): New extern decls.
5421
0248044d 5422 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5423 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5424
8ff096c1 5425 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5426 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5427 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5428 (ftfont_list): Remove unused local.
49eaafba
PE
5429 (get_adstyle_property, ftfont_pattern_entity):
5430 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5431 Rename locals to avoid shadowing.
8ff096c1 5432
e2be39f6
PE
5433 * xfont.c (xfont_list_family): Mark var as initialized.
5434
c9735e30
PE
5435 * xml.c (make_dom): Now static.
5436
8f5201ae
PE
5437 * composite.c (composition_compute_stop_pos): Rename local to
5438 avoid shadowing.
b246f932
PE
5439 (composition_reseat_it): Remove unused locals.
5440 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5441 (composition_update_it): Mark var as initialized.
11b61122
PE
5442 (find_automatic_composition): Mark vars as initialized,
5443 with a FIXME (Bug#8290).
8f5201ae 5444
760fbc2c
PE
5445 character.h: Rename locals to avoid shadowing.
5446 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5447 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5448 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5449 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5450 to avoid shadowing.
5451
ff08eb85
PE
5452 * textprop.c (property_change_between_p): Remove; unused.
5453
fc7bf025
PE
5454 * intervals.c (interval_start_pos): Now static.
5455
235d7abc
PE
5456 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5457
44f230aa
SM
5458 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5459 Rename locals to avoid shadowing.
3e7d6594 5460
50060332
PE
5461 * sound.c (wav_play, au_play, Fplay_sound_internal):
5462 Fix pointer signedness.
d01f234b 5463 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5464 (wav_play): Initialize a variable to 0, to prevent undefined
5465 behavior (Bug#8278).
50060332 5466
c4fc4e30
PE
5467 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5468
918436ed
PE
5469 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5470
c939f91b
PE
5471 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5472 clobbering (Bug#8298).
b9c7f648
PE
5473 * sysdep.c (sys_subshell): Likewise.
5474 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5475
6bd8c144
PE
5476 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5477 This should get cleaned up, so that child_setup has the
5478 same signature on all platforms.
5479
7710357c 5480 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5481 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5482
c59da222
CY
54832011-03-22 Chong Yidong <cyd@stupidchicken.com>
5484
5485 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5486 not to be necessary, and produces flickering.
5487
66b87493
GM
54882011-03-20 Glenn Morris <rgm@gnu.org>
5489
5490 * config.in: Remove file.
5491
45b6f6d5
JB
54922011-03-20 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5495 are now in src/globals.h.
5496 (syms_of_minibuf): Remove spurious & from previous change.
5497
3ec03f7e
LL
54982011-03-20 Leo <sdl.web@gmail.com>
5499
5500 * minibuf.c (completing-read-function): New variable.
5501 (completing-read-default): Rename from completing-read.
5502 (completing-read): Call completing-read-function.
5503
b14e3e21
CY
55042011-03-19 Juanma Barranquero <lekktu@gmail.com>
5505
5506 * xfaces.c (Fx_load_color_file):
5507 Read color file from absolute filename (bug#8250).
5508
f2b726e6
JB
55092011-03-19 Juanma Barranquero <lekktu@gmail.com>
5510
5511 * makefile.w32-in: Update dependencies.
5512
09f6ff02
EZ
55132011-03-17 Eli Zaretskii <eliz@gnu.org>
5514
5515 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5516
29a6015a
PE
55172011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5518
a3a6c54e
PE
5519 Fix more problems found by GCC 4.5.2's static checks.
5520
b766f867
PE
5521 * process.c (make_serial_process_unwind, send_process_trap):
5522 (sigchld_handler): Now static.
5523
be02381c
PE
5524 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5525 That way, the code declares only the vars that it needs.
5526 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5527 * s/cygwin.h (PTY_ITERATION): Likewise.
5528 * s/darwin.h (PTY_ITERATION): Likewise.
5529 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5530
57048744
PE
5531 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5532 * process.c (allocate_pty): Don't declare stb unless it's needed.
5533
7914961c 5534 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5535 (CONSTANTLIM): Remove; unused.
5536 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5537 Define only if needed.
7914961c 5538
b3967b18
PE
5539 * unexelf.c (unexec): Name an expression,
5540 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5541 Use a different way to cause a compilation error if anyone uses
5542 n rather than nn, a way that does not involve shadowing.
73366a00 5543 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5544
29a6015a
PE
5545 * deps.mk (unexalpha.o): Remove; unused.
5546
43cfc33e 5547 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5548 * unexec.h: New file.
ce701a33
PE
5549 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5550 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5551 Depend on unexec.h.
5552 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5553 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5554 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5555 Change as necessary to match prototype in unexec.h.
ce701a33 5556
01f44d5a
PE
5557 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5558 shadowing.
4f63c6bb 5559 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5560
a6670b0b
PE
5561 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5562 Rename locals to avoid shadowing.
5563
cef2010d 5564 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5565 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5566
d4d7173a
PE
5567 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5568
f08b802a
PE
5569 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5570 warning when compiling print.c.
5571
3ddb0639
PE
5572 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5573 instead of using an uninitialized var.
5ad03b97 5574 (font_sort_entities): Mark var as initialized.
3ddb0639 5575
170a2692
PE
5576 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5577
e663c700
PE
5578 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5579 pointers to constants.
89bc529a 5580 (font_parse_fcname): Remove unused vars.
7b81e2d0 5581 (font_delete_unmatched): Now static.
ea838e10 5582 (font_get_spec): Remove; unused.
13a547c6
PE
5583 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5584 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5585 Rename or move locals to avoid shadowing.
e663c700 5586
2a80c887 5587 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5588 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5589
1384fa33 5590 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5591 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5592
8b2c52e9
PE
5593 * alloc.c (mark_backtrace): Move decl from here ...
5594 * lisp.h: ... to here, so that it can be checked.
5595
475545b5 5596 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5597 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5598 (lisp_indirect_variable): Name an expression,
5599 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5600 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5601
b1349114 5602 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5603 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5604 Use const pointer when appropriate.
b1349114 5605
a2928364
PE
5606 * lisp.h (get_system_name, get_operating_system_release):
5607 Move decls here, to check interfaces.
5608 * process.c (get_operating_system_release): Move decl to lisp.h.
5609 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5610 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5611 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5612 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5613 (Fformat_time_string, Fencode_time, Finsert_char):
5614 (Ftranslate_region_internal, Fformat):
5615 Rename or remove local vars to avoid shadowing.
9710023e 5616 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5617
a415e694
PE
5618 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5619 avoid shadowing.
5620
8ef4622d
PE
5621 * lisp.h (eassert): Check that the argument compiles, even if
5622 ENABLE_CHECKING is not defined.
5623
946f9a5b
PE
5624 * data.c (Findirect_variable): Name an expression, to avoid
5625 gcc -Wbad-function-cast warning.
112396d6 5626 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5627 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5628 (Fmake_variable_buffer_local, Fmake_local_variable):
5629 Mark variables as initialized.
52746918 5630 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5631
e5aab7e7 5632 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5633 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5634 Rename locals to avoid shadowing.
dff45157
PE
5635 (mark_stack): Move local variables into the #ifdef region where
5636 they're used.
7bc26fdb
PE
5637 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5638 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5639 needed otherwise.
5640 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5641 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5642 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5643
e5aab7e7
PE
5644 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5645 avoids undefined behavior in theory.
5646
4da60324
PE
5647 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5648
88043301
PE
5649 Use functions, not macros, for up- and down-casing (Bug#8254).
5650 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5651 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5652 to use the following functions instead of these macros.
5653 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5654 EMACS_INT, since callers assume the returned value fits in int.
5655 (upcase1): Likewise, for UPCASE_TABLE.
5656 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5657 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5658 the race-condition problem in the old DOWNCASE.
88043301 5659
19ed5445
PE
5660 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5661 Rename locals to avoid shadowing.
5662 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5663 (regex_compile, re_search_2, re_match_2_internal):
5664 Remove unused local vars.
952db0d7
PE
5665 (FREE_VAR): Rewrite so as not to use empty "else",
5666 which gcc can warn about.
da053e48 5667 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5668 (RETALLOC_IF): Define only if needed.
5669 (WORDCHAR_P): Likewise. This one is never needed, but is used
5670 only in a comment talking about a compiler bug, so put inside
5671 the #if 0 of that comment.
5672 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5673 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5674 Remove; unused.
19ed5445 5675
1f3561e4 5676 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5677 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5678 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5679
ded6f8f7
PE
5680 * search.c (simple_search): Remove unused var.
5681
dbd37a95
PE
5682 * dired.c (compile_pattern): Move decl from here ...
5683 * lisp.h: ... to here, so that it can be checked.
5684 (struct re_registers): New forward decl.
5685
7e47afad
PE
5686 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5687
85f24f61
PE
5688 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5689 All uses changed.
5690 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5691 Rename locals to avoid shadowing.
5671df8f 5692 (Fvertical_motion): Mark locals as initialized.
85f24f61 5693
181aa2be 5694 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5695 (casify_region): Mark local as initialized.
181aa2be 5696
930d429c
PE
5697 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5698
7082eac6
PE
5699 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5700 New macros, so that the caller can use some names other than
5701 gcpro1, gcpro2, etc.
5702 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5703 of the new macros.
5704 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5705 argument, for consistency with GCPRO2_VAR, etc: it is now the
5706 prefix of the variable, not the variable itself. All uses
5707 changed.
38b2c076
PE
5708 * dired.c (directory_files_internal, file_name_completion):
5709 Rename locals to avoid shadowing.
5710
15206ed9
PE
5711 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5712 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5713 dired.c's scmp function, had undefined behavior.
5714 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5715 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5716 * buffer.h: ... to here, because these macros use current_buffer,
5717 and the new implementation with inline functions needs to have
5718 current_buffer in scope now, rather than later when the macros
5719 are used.
5720 (downcase, upcase1): New static inline functions.
5721 (DOWNCASE, UPCASE1): Reimplement using these functions.
5722 This avoids undefined behavior in expressions like
5723 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5724 from race conditions in accessing the global variables
5725 case_temp1 and case_temp2.
5726 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5727 * lisp.h (case_temp1, case_temp2): Remove their decls.
5728 * character.h (ASCII_CHAR_P): Move from here ...
5729 * lisp.h: ... to here, so that the inline functions mentioned
5730 above can use them.
5731
4a6bea26
PE
5732 * dired.c (directory_files_internal_unwind): Now static.
5733
f14b7e14
PE
5734 * fileio.c (file_name_as_directory, directory_file_name):
5735 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5736 Now static.
2893f146
PE
5737 (file_name_as_directory): Use const pointers when appropriate.
5738 (Fexpand_file_name): Likewise. In particular, newdir might
5739 point at constant storage, so make it a const pointer.
fd4ead52 5740 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5741 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5742 signedness issues.
f839df0c
PE
5743 (Fset_file_times, Finsert_file_contents, auto_save_error):
5744 Rename locals to avoid shadowing.
f14b7e14 5745
5716756e 5746 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5747 (Ftry_completion, Fall_completions): Rename or remove locals
5748 to avoid shadowing.
5716756e 5749
b4c3046a
PE
5750 * marker.c (bytepos_to_charpos): Remove; unused.
5751
b45db522
PE
5752 * lisp.h (verify_bytepos, count_markers): New decls,
5753 so that gcc does not warn that these functions aren't declared.
5754
85876d07
PE
5755 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5756 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5757 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5758 (copy_text): Remove unused local var.
85876d07 5759
03d78a21 5760 * filelock.c (within_one_second): Now static.
b3dd38ab 5761 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5762
5df8f01b
PE
5763 * buffer.c (fix_overlays_before): Mark locals as initialized.
5764 (fix_start_end_in_overlays): Likewise. This function should be
5765 simplified by using pointers-to-pointers, but that's a different
5766 matter.
b1d876f1 5767 (switch_to_buffer_1): Now static.
8f54f30a
PE
5768 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5769 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5770
a70072c9 5771 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5772 Fix pointer signedness issue.
edced198
PE
5773 (sys_subshell): Mark local as volatile if checking for lint,
5774 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5775 (MAXPATHLEN): Define only if needed.
a70072c9 5776
a0977c44
PE
5777 * process.c (serial_open, serial_configure): Move decls from here ...
5778 * systty.h: ... to here, so that they can be checked.
5779
a884fdcc
PE
5780 * fns.c (get_random, seed_random): Move extern decls from here ...
5781 * lisp.h: ... to here, so that they can be checked.
5782
604efe86 5783 * sysdep.c (reset_io): Now static.
b8950c94 5784 (wait_for_termination_signal): Remove; unused.
604efe86 5785
38fc62d9
PE
5786 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5787 (copy_keymap_item, append_key, push_text_char_description):
5788 Now static.
1004a21a 5789 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5790 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5791 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5792 (describe_map_tree):
5793 Rename locals to avoid shadowing.
38fc62d9 5794
2f2650da
PE
5795 * keyboard.c: Declare functions static if they are not used elsewhere.
5796 (echo_char, echo_dash, cmd_error, top_level_2):
5797 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5798 (read_char, kbd_buffer_get_event, make_lispy_position):
5799 (make_lispy_event, make_lispy_movement, apply_modifiers):
5800 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5801 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5802 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5803 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5804 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5805
a053e86c 5806 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5807 (mark_kboards): Move decl here ...
5808 * alloc.c (mark_kboards): ... from here.
a053e86c 5809
4752793e
PE
5810 * lisp.h (force_auto_save_soon): New decl.
5811
74f10ca7 5812 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5813 (DEFINE_DUMMY_FUNCTION): New macro.
5814 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5815 Use it.
c03cd23f
PE
5816 (main): Add casts to avoid warnings
5817 if GCC considers string literals to be constants.
74f10ca7 5818
022e70d4
PE
5819 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5820
59d6fe83
PE
5821 * dbusbind.c: Pointer signedness fixes.
5822 (xd_signature, xd_append_arg, xd_initialize):
5823 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5824 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5825 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5826 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5827
78320123
PE
5828 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5829 if GCC considers string literals to be constants.
49cebcca 5830 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5831
35ac2a97
SM
58322011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5833
fb103ca9
SM
5834 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5835 (print_preprocess, print_object): New macro to fix last change.
5836
35ac2a97
SM
5837 * print.c (print_preprocess): Don't forget font objects.
5838
62973b41
JB
58392011-03-16 Juanma Barranquero <lekktu@gmail.com>
5840
5841 * emacs.c (USAGE3): Doc fixes.
5842
0e48bb22
AS
58432011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5844
5845 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5846 structure.
5847
7684e57b
JB
58482011-03-14 Juanma Barranquero <lekktu@gmail.com>
5849
5850 * lisp.h (VWindow_system, Qfile_name_history):
5851 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5852 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5853 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5854
5855 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5856 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5857
5858 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5859 * w32console.c (detect_input_pending, read_input_pending)
5860 (encode_terminal_code):
5861 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5862 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5863 (w32_system_caret_y, Qfile_name_history):
5864 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5865 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5866 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5867 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5868 * w32proc.c (Qlocal, report_file_error):
5869 * w32term.c (Vwindow_system, updating_frame):
5870 * w32uniscribe.c (initialized, uniscribe_font_driver):
5871 Remove unneeded extern declarations.
5872
2aa46d6c
CY
58732011-03-14 Chong Yidong <cyd@stupidchicken.com>
5874
c96bbc66 5875 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5876
cffc6f3b
CY
58772011-03-13 Chong Yidong <cyd@stupidchicken.com>
5878
5879 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5880 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5881 These macros can no longer be used for assignment.
5882
44f230aa
SM
5883 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5884 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5885 (record_buffer_markers, fetch_buffer_markers): New functions for
5886 recording and fetching special buffer markers.
5887 (set_buffer_internal_1, set_buffer_temp): Use them.
5888
5889 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5890
5891 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5892
5893 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5894 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5895
5896 * xdisp.c (hscroll_window_tree):
5897 (reconsider_clip_changes): Use PT instead of BUF_PT.
5898
d251f04b
EZ
58992011-03-13 Eli Zaretskii <eliz@gnu.org>
5900
5901 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5902 $(EMACS_ROOT)/lib/intprops.h.
5903
f0c77cd1
PE
59042011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5905
3eca4629
PE
5906 Fix more problems found by GCC 4.5.2's static checks.
5907
7c86ee98
PE
5908 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5909 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5910 (xg_free_frame_widgets): Make it clear that a local variable is
5911 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5912 (gdk_window_get_screen): Make it clear that this macro is needed
5913 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5914 (int_gtk_range_get_value): New function, which avoids a diagnostic
5915 from gcc -Wbad-function-cast.
5916 (xg_set_toolkit_scroll_bar_thumb): Use it.
5917 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5918 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5919 (get_utf8_string, xg_get_file_with_chooser):
5920 Rename locals to avoid shadowing.
5921 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5922
41729b81
PE
5923 * xgselect.c (xg_select): Remove unused var.
5924
f0c77cd1
PE
5925 * image.c (four_corners_best): Mark locals as initialized.
5926 (gif_load): Initialize transparent_p to zero (Bug#8238).
5927 Mark another local as initialized.
ec6cf4c6 5928 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5929
ce0ad53d 5930 * image.c (clear_image_cache): Now static.
d5d5a617 5931 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5932 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5933 (x_edge_detection): Remove unnecessary cast that
5934 gcc -Wbad-function-cast diagnoses.
2037898d 5935 (gif_load): Fix pointer signedness.
6ae141d6
PE
5936 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5937 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5938
33383987 59392011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5940
d32df629
PE
5941 Improve quality of tests for time stamp overflow.
5942 For example, without this patch (encode-time 0 0 0 1 1
5943 1152921504606846976) returns the obviously-bogus value (-948597
5944 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5945 reports time overflow. See
5946 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5947 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5948 * editfns.c: Include limits.h and intprops.h.
5949 (TIME_T_MIN, TIME_T_MAX): New macros.
5950 (time_overflow): Move earlier, to before first use.
5951 (hi_time, lo_time): New functions, for an accurate test for
5952 out-of-range times.
5953 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5954 (Fget_internal_run_time): Don't assume time_t fits in int.
5955 (make_time): Use list2 instead of Fcons twice.
5956 (Fdecode_time): More accurate test for out-of-range times.
5957 (check_tm_member): New function.
5958 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5959 (lisp_time_argument): Don't rely on undefined left-shift and
5960 right-shift behavior when checking for time stamp overflow.
8be6f318 5961
fe31d94c
PE
5962 * editfns.c (time_overflow): New function, refactoring common code.
5963 (Fformat_time_string, Fdecode_time, Fencode_time):
5964 (Fcurrent_time_string): Use it.
5965
8be6f318
PE
5966 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5967 * dired.c (make_time): Move to ...
5968 * editfns.c (make_time): ... here.
5969 * systime.h: Note the move.
5970
09d9db2c 59712011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5972
126bc0dc
YM
5973 * fringe.c (update_window_fringes): Remove unused variables.
5974
c47cbdfd
YM
5975 * unexmacosx.c (copy_data_segment): Also copy __got section.
5976 (Bug#8223)
5977
7ac80be9
EZ
59782011-03-12 Eli Zaretskii <eliz@gnu.org>
5979
c96bbc66 5980 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5981 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5982 Constify `char *' arguments and their references according to
5983 prototypes in tparam.h.
5984
ecb0f94d 5985 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5986
7ac80be9
EZ
5987 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5988 Adapt all references accordingly.
5989
5990 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5991
ef1fd07e
TT
59922011-03-11 Tom Tromey <tromey@redhat.com>
5993
5994 * buffer.c (syms_of_buffer): Remove obsolete comment.
5995
7ef4b50c
EZ
59962011-03-11 Eli Zaretskii <eliz@gnu.org>
5997
5998 * termhooks.h (encode_terminal_code): Declare prototype.
5999
6000 * msdos.c (encode_terminal_code): Don't declare prototype.
6001
6002 * term.c (encode_terminal_code): Now external again, used by
6003 w32console.c and msdos.c.
6004
44f230aa
SM
6005 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6006 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6007
4b1ec863 60082011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6009
1714f52b 6010 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6011
4b1ec863
PE
6012 * fringe.c (update_window_fringes): Mark locals as initialized
6013 (Bug#8227).
6014 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6015
524c7aa6
PE
6016 * alloc.c (mark_fringe_data): Move decl from here ...
6017 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6018 to check its interface.
6019 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6020
a5c0af81 6021 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6022 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6023 (fontset_font): Mark local as initialized.
a9a06e0b 6024 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6025
b4716021
PE
6026 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6027
811e9bac 6028 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6029 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6030 (x_own_selection, Fx_disown_selection_internal): Rename locals
6031 to avoid shadowing.
6032 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6033
7e3ab302
PE
6034 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6035 so that the caller can use some name other than gcpro1.
6036 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6037 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6038 (Fx_backspace_delete_keys_p):
6039 Use them to avoid shadowing, and rename vars to avoid shadowing.
6040 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6041 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6042 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6043 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6044 Remove unused locals.
7e3ab302
PE
6045 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6046 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6047 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6048 macros.
f78faa98 6049
e2b13473
PE
6050 * xterm.h (x_mouse_leave): New decl.
6051
77f23912
PE
6052 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6053 Remove unused functions.
cdf4ba58
PE
6054 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6055 (x_calc_absolute_position): Now static.
7411c686 6056 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6057 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6058 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6059 unless they are used.
38d0b34a
PE
6060 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6061 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6062 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6063 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6064 (x_error_catcher, x_connection_closed, x_error_handler):
6065 (x_error_quitter, xembed_send_message, x_iconify_frame):
6066 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6067 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6068 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6069
44f230aa
SM
6070 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6071 Rename or move locals to avoid shadowing.
6b463e58 6072 (tty_defined_color, merge_face_heights): Now static.
5967d051 6073 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6074 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6075 does not deduce is never used uninitialized.
73719eba
PE
6076 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6077 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6078
426994c3 6079 * terminal.c (store_terminal_param): Now static.
5489860b 6080
032f1620 6081 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6082 (set_frame_menubar): Remove unused local.
d4323972 6083 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6084 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6085 since they might point to immutable storage.
281585b0
PE
6086 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6087 since it's unused otherwise.
032f1620 6088
367c19e5 6089 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6090 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6091 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6092 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6093 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6094 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6095 does not deduce are never used uninitialized.
70739cbe 6096
07b48fa9
PE
6097 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6098
8868a238 6099 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6100 * window.c (window_loop, size_window):
6101 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6102
7e5cf297 6103 * window.c (display_buffer): Now static.
d6550a9f
PE
6104 (size_window): Mark variables that gcc -Wuninitialized
6105 does not deduce are never used uninitialized.
a586633d
PE
6106 * window.h (check_all_windows): New decl, to forestall
6107 gcc -Wmissing-prototypes diagnostic.
5b555da1 6108 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6109
f6095868
PE
6110 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6111 shadowing.
6112 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6113 Include <limits.h>.
6114 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6115 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6116 (load_charset_map): Mark variables that gcc -Wuninitialized
6117 does not deduce are never used uninitialized.
53df7c11 6118 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6119
f38b440c
PE
6120 * coding.c (coding_set_source, coding_set_destination):
6121 Use "else { /* comment */ }" rather than "else /* comment */;"
6122 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6123 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6124 a block, when the outer 'i' will do.
6125 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6126 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6127 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6128 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6129 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6130 Rename locals to avoid shadowing.
6131 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6132 * coding.c (emacs_mule_char, encode_invocation_designation):
6133 Now static, since they're not used elsewhere.
413bb2db 6134 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6135 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6136 (decode_coding_emacs_mule): Mark variables that gcc
6137 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6138 (detect_coding_iso_2022): Initialize a local variable that might
6139 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6140 this initialization is needed. (Bug#8211)
5f58e762
PE
6141 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6142 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6143 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6144 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6145 Remove unused macros.
f38b440c 6146
232b38b9 6147 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6148 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6149 * character.c (string_count_byte8): Likewise.
232b38b9 6150
fb90da1b
PE
6151 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6152 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6153
fb93dbc2
PE
6154 * chartab.c (copy_sub_char_table): Now static, since it's not used
6155 elsewhere.
5c156ace
PE
6156 (sub_char_table_ref_and_range, char_table_ref_and_range):
6157 Rename locals to avoid shadowing.
bbcd0949 6158 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6159
7d3b3862 6160 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6161 (BIDI_BOB): Remove unused macro.
7d3b3862 6162
6be7d3da
PE
6163 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6164 deduce are never used uninitialized.
c2ed9c8b 6165 * term.c (encode_terminal_code): Likewise.
6be7d3da 6166
75f8807f 6167 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6168
50938595
PE
6169 * tparam.h: New file.
6170 * term.c, tparam.h: Include it.
6171 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6172 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6173 Move these decls to tparam.h, and make them agree with what
6174 is actually in tparam.c. The previous trick of using incompatible
6175 decls in different modules does not conform to the C standard.
6176 All callers of tparam changed to use tparam's actual API.
6177 * tparam.c (tparam1, tparam, tgoto):
6178 Use const pointers where appropriate.
6179
fbceeba2
PE
6180 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6181 * cm.h (struct cm): Likewise.
6182 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6183 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6184 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6185 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6186 (turn_on_face, init_tty): Likewise.
6187 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6188
7f3f1250
PE
6189 * term.c (term_mouse_position): Rename local to avoid shadowing.
6190
e6ca6543
PE
6191 * alloc.c (mark_ttys): Move decl from here ...
6192 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6193
c40f8d15
AS
61942011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6195
6196 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6197
cfe0661d
JB
61982011-03-09 Juanma Barranquero <lekktu@gmail.com>
6199
6200 * search.c (compile_pattern_1): Remove argument regp, unused since
6201 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6202 (compile_pattern): Don't pass it.
6203
0afb4571
J
62042011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6205
6206 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6207 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6208 for ! HAVE_GTK3.
6209 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6210
6211 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6212
6213 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6214 gdk_window_get_screen, gdk_window_get_geometry,
6215 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6216 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6217 (xg_get_pixbuf_from_pixmap): New function.
6218 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6219 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6220 Call xg_get_pixbuf_from_pixmap instead of
6221 gdk_pixbuf_get_from_drawable.
6222 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6223 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6224 (xg_check_special_colors): Use GtkStyleContext and its functions
6225 for HAVE_GTK3.
6226 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6227 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6228 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6229 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6230 Call gtk_widget_get_preferred_size.
0afb4571
J
6231 (xg_frame_resized): gdk_window_get_geometry only takes 5
6232 parameters.
44f230aa
SM
6233 (xg_win_to_widget, xg_event_is_for_menubar):
6234 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6235 (xg_set_widget_bg): New function.
6236 (delete_cb): New function.
895009e1 6237 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6238 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6239 (xg_set_background_color): Call xg_set_widget_bg.
6240 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6241 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6242 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6243 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6244 if ! HAVE_GTK3.
6245 (update_frame_tool_bar): Call gtk_widget_hide.
6246 (xg_initialize): Use GDK_KEY_g.
6247
6248 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6249 if ! HAVE_GTK3
6250 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6251
6252 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6253 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6254 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6255
1c2cc4ef
JB
62562011-03-08 Juanma Barranquero <lekktu@gmail.com>
6257
6258 * w32xfns.c (select_palette): Check success of RealizePalette against
6259 GDI_ERROR, not zero.
6260
33383987 6261See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6262
6263;; Local Variables:
6264;; coding: utf-8
aac0c6e3
MR
6265;; End:
6266
33383987 6267 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6268
6269 This file is part of GNU Emacs.
6270
6271 GNU Emacs is free software: you can redistribute it and/or modify
6272 it under the terms of the GNU General Public License as published by
6273 the Free Software Foundation, either version 3 of the License, or
6274 (at your option) any later version.
6275
6276 GNU Emacs is distributed in the hope that it will be useful,
6277 but WITHOUT ANY WARRANTY; without even the implied warranty of
6278 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6279 GNU General Public License for more details.
6280
6281 You should have received a copy of the GNU General Public License
6282 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.